{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/1597","repository_url":"https://api.github.com/repos/apache/incubator-airflow","labels_url":"https://api.github.com/repos/apache/incubator-airflow/issues/1597/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/issues/1597/comments","events_url":"https://api.github.com/repos/apache/incubator-airflow/issues/1597/events","html_url":"https://github.com/apache/incubator-airflow/pull/1597","id":160502401,"number":1597,"title":"[AIRFLOW-227] Show environmentally defined configs in the config view","user":{"login":"sekikn","id":898388,"avatar_url":"https://avatars.githubusercontent.com/u/898388?v=3","gravatar_id":"","url":"https://api.github.com/users/sekikn","html_url":"https://github.com/sekikn","followers_url":"https://api.github.com/users/sekikn/followers","following_url":"https://api.github.com/users/sekikn/following{/other_user}","gists_url":"https://api.github.com/users/sekikn/gists{/gist_id}","starred_url":"https://api.github.com/users/sekikn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sekikn/subscriptions","organizations_url":"https://api.github.com/users/sekikn/orgs","repos_url":"https://api.github.com/users/sekikn/repos","events_url":"https://api.github.com/users/sekikn/events{/privacy}","received_events_url":"https://api.github.com/users/sekikn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-06-15T19:21:00Z","updated_at":"2016-06-20T22:23:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/1597","html_url":"https://github.com/apache/incubator-airflow/pull/1597","diff_url":"https://github.com/apache/incubator-airflow/pull/1597.diff","patch_url":"https://github.com/apache/incubator-airflow/pull/1597.patch"},"body":"Dear Airflow Maintainers,\r\n\r\nPlease accept this PR that addresses the following issues:\r\n- https://issues.apache.org/jira/browse/AIRFLOW-227\r\n\r\nTesting Done:\r\n- executed run_unit_tests.sh and confirmed all 175 tests passed\r\n- confirmed that the new page:\r\n\r\n  - shows no parameter if expose_config is false\r\n  - shows all parameters if expose_config is true, including environment variables such as AIRFLOW__CORE__FOO=bar\r\n\r\nRight now the config page (when set to display) just loads the airflow.cfg and lists that,\r\nso any configuration values that are set via an environment variable are not shown.\r\nThis patch add a new page that shows all configuration values which are loaded via any means,\r\nonly if expose_config is set to true."},"comment":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/comments/227288157","html_url":"https://github.com/apache/incubator-airflow/pull/1597#issuecomment-227288157","issue_url":"https://api.github.com/repos/apache/incubator-airflow/issues/1597","id":227288157,"user":{"login":"criccomini","id":167569,"avatar_url":"https://avatars.githubusercontent.com/u/167569?v=3","gravatar_id":"","url":"https://api.github.com/users/criccomini","html_url":"https://github.com/criccomini","followers_url":"https://api.github.com/users/criccomini/followers","following_url":"https://api.github.com/users/criccomini/following{/other_user}","gists_url":"https://api.github.com/users/criccomini/gists{/gist_id}","starred_url":"https://api.github.com/users/criccomini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/criccomini/subscriptions","organizations_url":"https://api.github.com/users/criccomini/orgs","repos_url":"https://api.github.com/users/criccomini/repos","events_url":"https://api.github.com/users/criccomini/events{/privacy}","received_events_url":"https://api.github.com/users/criccomini/received_events","type":"User","site_admin":false},"created_at":"2016-06-20T22:23:24Z","updated_at":"2016-06-20T22:23:24Z","body":"> Should we display all configs finally loaded\r\n\r\nYea, I think that's the most intuitive."}}
{"actor":{"display_login":"criccomini"}}