{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic/pulls/comments/82530023","pull_request_review_id":3431986,"id":82530023,"diff_hunk":"@@ -34,7 +33,7 @@ type Operations interface {\n \n \tSetHostname(hostname string, aliases ...string) error\n \tApply(endpoint *NetworkEndpoint) error\n-\tMountLabel(ctx context.Context, devicePath, target string) error\n+\tMountLabel(ctx context.Context, devicePath string, target string) error","path":"lib/tether/interfaces.go","position":null,"original_position":13,"commit_id":"c31ef01eecd3634db8e4982f2fc0dab705a69e51","original_commit_id":"c31ef01eecd3634db8e4982f2fc0dab705a69e51","user":{"login":"hickeng","id":3923729,"avatar_url":"https://avatars.githubusercontent.com/u/3923729?v=3","gravatar_id":"","url":"https://api.github.com/users/hickeng","html_url":"https://github.com/hickeng","followers_url":"https://api.github.com/users/hickeng/followers","following_url":"https://api.github.com/users/hickeng/following{/other_user}","gists_url":"https://api.github.com/users/hickeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hickeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hickeng/subscriptions","organizations_url":"https://api.github.com/users/hickeng/orgs","repos_url":"https://api.github.com/users/hickeng/repos","events_url":"https://api.github.com/users/hickeng/events{/privacy}","received_events_url":"https://api.github.com/users/hickeng/received_events","type":"User","site_admin":false},"body":"why changing the signature - it's a noop.","created_at":"2016-10-09T19:51:05Z","updated_at":"2016-10-09T19:52:13Z","html_url":"https://github.com/vmware/vic/pull/2536#discussion_r82530023","pull_request_url":"https://api.github.com/repos/vmware/vic/pulls/2536","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments/82530023"},"html":{"href":"https://github.com/vmware/vic/pull/2536#discussion_r82530023"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic/pulls/2536"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/2536","id":87574952,"html_url":"https://github.com/vmware/vic/pull/2536","diff_url":"https://github.com/vmware/vic/pull/2536.diff","patch_url":"https://github.com/vmware/vic/pull/2536.patch","issue_url":"https://api.github.com/repos/vmware/vic/issues/2536","number":2536,"state":"open","locked":false,"title":"Creates new block device package to remove our reliance on udev for volume mounting WIP","user":{"login":"matthewavery","id":8620942,"avatar_url":"https://avatars.githubusercontent.com/u/8620942?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewavery","html_url":"https://github.com/matthewavery","followers_url":"https://api.github.com/users/matthewavery/followers","following_url":"https://api.github.com/users/matthewavery/following{/other_user}","gists_url":"https://api.github.com/users/matthewavery/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewavery/subscriptions","organizations_url":"https://api.github.com/users/matthewavery/orgs","repos_url":"https://api.github.com/users/matthewavery/repos","events_url":"https://api.github.com/users/matthewavery/events{/privacy}","received_events_url":"https://api.github.com/users/matthewavery/received_events","type":"User","site_admin":false},"body":"This Commit uses a new vendored package to inspect attached block devices and create a map which is then used to look up(by label) all of the mounts that are expected for the container. We need this in order to strip out udev and more of systemd. It will also keeps us from having the race condition where udev has not finished sym linking block devices when we `switch-root` which then breaks udev causing us to lose any labeled devices that we intend to mount. \r\n\r\n\r\nFixes #2485 \r\nFixes #2472 \r\n","created_at":"2016-09-30T22:17:33Z","updated_at":"2016-10-09T19:52:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79805413354fc7841490d8f4e00918eac6dfd901","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic/pulls/2536/commits","review_comments_url":"https://api.github.com/repos/vmware/vic/pulls/2536/comments","review_comment_url":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic/issues/2536/comments","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/c31ef01eecd3634db8e4982f2fc0dab705a69e51","head":{"label":"matthewavery:tether-mount-bug","ref":"tether-mount-bug","sha":"c31ef01eecd3634db8e4982f2fc0dab705a69e51","user":{"login":"matthewavery","id":8620942,"avatar_url":"https://avatars.githubusercontent.com/u/8620942?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewavery","html_url":"https://github.com/matthewavery","followers_url":"https://api.github.com/users/matthewavery/followers","following_url":"https://api.github.com/users/matthewavery/following{/other_user}","gists_url":"https://api.github.com/users/matthewavery/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewavery/subscriptions","organizations_url":"https://api.github.com/users/matthewavery/orgs","repos_url":"https://api.github.com/users/matthewavery/repos","events_url":"https://api.github.com/users/matthewavery/events{/privacy}","received_events_url":"https://api.github.com/users/matthewavery/received_events","type":"User","site_admin":false},"repo":{"id":55441893,"name":"vic","full_name":"matthewavery/vic","owner":{"login":"matthewavery","id":8620942,"avatar_url":"https://avatars.githubusercontent.com/u/8620942?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewavery","html_url":"https://github.com/matthewavery","followers_url":"https://api.github.com/users/matthewavery/followers","following_url":"https://api.github.com/users/matthewavery/following{/other_user}","gists_url":"https://api.github.com/users/matthewavery/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewavery/subscriptions","organizations_url":"https://api.github.com/users/matthewavery/orgs","repos_url":"https://api.github.com/users/matthewavery/repos","events_url":"https://api.github.com/users/matthewavery/events{/privacy}","received_events_url":"https://api.github.com/users/matthewavery/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthewavery/vic","description":"Integrated containers on vSphere","fork":true,"url":"https://api.github.com/repos/matthewavery/vic","forks_url":"https://api.github.com/repos/matthewavery/vic/forks","keys_url":"https://api.github.com/repos/matthewavery/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewavery/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewavery/vic/teams","hooks_url":"https://api.github.com/repos/matthewavery/vic/hooks","issue_events_url":"https://api.github.com/repos/matthewavery/vic/issues/events{/number}","events_url":"https://api.github.com/repos/matthewavery/vic/events","assignees_url":"https://api.github.com/repos/matthewavery/vic/assignees{/user}","branches_url":"https://api.github.com/repos/matthewavery/vic/branches{/branch}","tags_url":"https://api.github.com/repos/matthewavery/vic/tags","blobs_url":"https://api.github.com/repos/matthewavery/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewavery/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewavery/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewavery/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewavery/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewavery/vic/languages","stargazers_url":"https://api.github.com/repos/matthewavery/vic/stargazers","contributors_url":"https://api.github.com/repos/matthewavery/vic/contributors","subscribers_url":"https://api.github.com/repos/matthewavery/vic/subscribers","subscription_url":"https://api.github.com/repos/matthewavery/vic/subscription","commits_url":"https://api.github.com/repos/matthewavery/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewavery/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewavery/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewavery/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewavery/vic/contents/{+path}","compare_url":"https://api.github.com/repos/matthewavery/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewavery/vic/merges","archive_url":"https://api.github.com/repos/matthewavery/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewavery/vic/downloads","issues_url":"https://api.github.com/repos/matthewavery/vic/issues{/number}","pulls_url":"https://api.github.com/repos/matthewavery/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewavery/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewavery/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewavery/vic/labels{/name}","releases_url":"https://api.github.com/repos/matthewavery/vic/releases{/id}","deployments_url":"https://api.github.com/repos/matthewavery/vic/deployments","created_at":"2016-04-04T20:19:26Z","updated_at":"2016-04-04T20:19:27Z","pushed_at":"2016-10-09T19:50:56Z","git_url":"git://github.com/matthewavery/vic.git","ssh_url":"git@github.com:matthewavery/vic.git","clone_url":"https://github.com/matthewavery/vic.git","svn_url":"https://github.com/matthewavery/vic","homepage":null,"size":29801,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"bdd96cf557aee6c34b99ef7a38416818ccd7ba91","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49597898,"name":"vic","full_name":"vmware/vic","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic","description":"Integrated containers engine on vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic","forks_url":"https://api.github.com/repos/vmware/vic/forks","keys_url":"https://api.github.com/repos/vmware/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic/teams","hooks_url":"https://api.github.com/repos/vmware/vic/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic/events","assignees_url":"https://api.github.com/repos/vmware/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic/tags","blobs_url":"https://api.github.com/repos/vmware/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic/languages","stargazers_url":"https://api.github.com/repos/vmware/vic/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic/subscription","commits_url":"https://api.github.com/repos/vmware/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic/merges","archive_url":"https://api.github.com/repos/vmware/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic/downloads","issues_url":"https://api.github.com/repos/vmware/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic/deployments","created_at":"2016-01-13T19:53:57Z","updated_at":"2016-10-05T20:53:52Z","pushed_at":"2016-10-09T19:50:57Z","git_url":"git://github.com/vmware/vic.git","ssh_url":"git@github.com:vmware/vic.git","clone_url":"https://github.com/vmware/vic.git","svn_url":"https://github.com/vmware/vic","homepage":"","size":81394,"stargazers_count":139,"watchers_count":139,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":53,"mirror_url":null,"open_issues_count":475,"forks":53,"open_issues":475,"watchers":139,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/2536"},"html":{"href":"https://github.com/vmware/vic/pull/2536"},"issue":{"href":"https://api.github.com/repos/vmware/vic/issues/2536"},"comments":{"href":"https://api.github.com/repos/vmware/vic/issues/2536/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic/pulls/2536/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic/pulls/2536/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic/statuses/c31ef01eecd3634db8e4982f2fc0dab705a69e51"}}}}
{"actor":{"display_login":"hickeng"}}