{"action":"created","comment":{"url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/pulls/comments/78132870","id":78132870,"diff_hunk":"@@ -25,22 +25,17 @@ public RabbitMQTransportInfrastructure(SettingsHolder settings, string connectio\n             var connectionConfiguration = new ConnectionStringParser(settings).Parse(connectionString);\n             connectionFactory = new ConnectionFactory(connectionConfiguration);\n \n-            SetUsePublisherConfirmsIfPresent(settings, connectionConfiguration);\n-\n             CreateTopology();\n \n-            channelProvider = new ChannelProvider(connectionFactory, routingTopology, connectionConfiguration.UsePublisherConfirms);\n-\n-            RequireOutboxConsent = false;\n-        }\n-\n-        static void SetUsePublisherConfirmsIfPresent(SettingsHolder settings, ConnectionConfiguration connectionConfiguration)\n-        {\n-            if (settings.HasSetting(SettingsKeys.UsePublisherConfirms))\n+            bool usePublisherConfirms;\n+            if (!settings.TryGet(SettingsKeys.UsePublisherConfirms, out usePublisherConfirms))","path":"src/NServiceBus.RabbitMQ/RabbitMQTransportInfrastructure.cs","position":17,"original_position":17,"commit_id":"17a19d98cee67e37200ba8706bc05204e910f057","original_commit_id":"45b0a5baac82d5053601b10c4cedfad603a55c4a","user":{"login":"adamralph","id":677704,"avatar_url":"https://avatars.githubusercontent.com/u/677704?v=3","gravatar_id":"","url":"https://api.github.com/users/adamralph","html_url":"https://github.com/adamralph","followers_url":"https://api.github.com/users/adamralph/followers","following_url":"https://api.github.com/users/adamralph/following{/other_user}","gists_url":"https://api.github.com/users/adamralph/gists{/gist_id}","starred_url":"https://api.github.com/users/adamralph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamralph/subscriptions","organizations_url":"https://api.github.com/users/adamralph/orgs","repos_url":"https://api.github.com/users/adamralph/repos","events_url":"https://api.github.com/users/adamralph/events{/privacy}","received_events_url":"https://api.github.com/users/adamralph/received_events","type":"User","site_admin":false},"body":"👍 much better","created_at":"2016-09-09T06:09:19Z","updated_at":"2016-09-09T06:09:19Z","html_url":"https://github.com/Particular/NServiceBus.RabbitMQ/pull/207#discussion_r78132870","pull_request_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/pulls/207","_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/pulls/comments/78132870"},"html":{"href":"https://github.com/Particular/NServiceBus.RabbitMQ/pull/207#discussion_r78132870"},"pull_request":{"href":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/pulls/207"}}},"pull_request":{"url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/pulls/207","id":84560611,"html_url":"https://github.com/Particular/NServiceBus.RabbitMQ/pull/207","diff_url":"https://github.com/Particular/NServiceBus.RabbitMQ/pull/207.diff","patch_url":"https://github.com/Particular/NServiceBus.RabbitMQ/pull/207.patch","issue_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/issues/207","number":207,"state":"open","locked":false,"title":"Revise publisher confirms code api","user":{"login":"bording","id":753669,"avatar_url":"https://avatars.githubusercontent.com/u/753669?v=3","gravatar_id":"","url":"https://api.github.com/users/bording","html_url":"https://github.com/bording","followers_url":"https://api.github.com/users/bording/followers","following_url":"https://api.github.com/users/bording/following{/other_user}","gists_url":"https://api.github.com/users/bording/gists{/gist_id}","starred_url":"https://api.github.com/users/bording/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bording/subscriptions","organizations_url":"https://api.github.com/users/bording/orgs","repos_url":"https://api.github.com/users/bording/repos","events_url":"https://api.github.com/users/bording/events{/privacy}","received_events_url":"https://api.github.com/users/bording/received_events","type":"User","site_admin":false},"body":"After looking over #196, here are some additional changes that I would have suggested making before merging it.","created_at":"2016-09-08T21:51:56Z","updated_at":"2016-09-09T06:09:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"028bad4ec2f784c3991a8002a8a723087752f357","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/pulls/207/commits","review_comments_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/pulls/207/comments","review_comment_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/issues/207/comments","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/statuses/17a19d98cee67e37200ba8706bc05204e910f057","head":{"label":"Particular:revise-publisher-confirms-code-api","ref":"revise-publisher-confirms-code-api","sha":"17a19d98cee67e37200ba8706bc05204e910f057","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":12695271,"name":"NServiceBus.RabbitMQ","full_name":"Particular/NServiceBus.RabbitMQ","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus.RabbitMQ","description":"RabbitMQ transport for NServiceBus","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ","forks_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/deployments","created_at":"2013-09-09T07:15:32Z","updated_at":"2016-05-28T05:04:04Z","pushed_at":"2016-09-08T22:19:20Z","git_url":"git://github.com/Particular/NServiceBus.RabbitMQ.git","ssh_url":"git@github.com:Particular/NServiceBus.RabbitMQ.git","clone_url":"https://github.com/Particular/NServiceBus.RabbitMQ.git","svn_url":"https://github.com/Particular/NServiceBus.RabbitMQ","homepage":"http://docs.particular.net/nservicebus/rabbitmq/","size":9141,"stargazers_count":21,"watchers_count":21,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":26,"forks":18,"open_issues":26,"watchers":21,"default_branch":"develop"}},"base":{"label":"Particular:release-4.0.0","ref":"release-4.0.0","sha":"cde4e1f8eb8a903acbf28276d8d1d5e4900ccca8","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":12695271,"name":"NServiceBus.RabbitMQ","full_name":"Particular/NServiceBus.RabbitMQ","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus.RabbitMQ","description":"RabbitMQ transport for NServiceBus","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ","forks_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/deployments","created_at":"2013-09-09T07:15:32Z","updated_at":"2016-05-28T05:04:04Z","pushed_at":"2016-09-08T22:19:20Z","git_url":"git://github.com/Particular/NServiceBus.RabbitMQ.git","ssh_url":"git@github.com:Particular/NServiceBus.RabbitMQ.git","clone_url":"https://github.com/Particular/NServiceBus.RabbitMQ.git","svn_url":"https://github.com/Particular/NServiceBus.RabbitMQ","homepage":"http://docs.particular.net/nservicebus/rabbitmq/","size":9141,"stargazers_count":21,"watchers_count":21,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":26,"forks":18,"open_issues":26,"watchers":21,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/pulls/207"},"html":{"href":"https://github.com/Particular/NServiceBus.RabbitMQ/pull/207"},"issue":{"href":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/issues/207"},"comments":{"href":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/NServiceBus.RabbitMQ/statuses/17a19d98cee67e37200ba8706bc05204e910f057"}}}}
{"actor":{"display_login":"adamralph"}}