{"action":"closed","number":8584,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/8584","id":85668851,"html_url":"https://github.com/nodejs/node/pull/8584","diff_url":"https://github.com/nodejs/node/pull/8584.diff","patch_url":"https://github.com/nodejs/node/pull/8584.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/8584","number":8584,"state":"closed","locked":false,"title":"test: cleanup test-child-process-stdio.js","user":{"login":"pmatzavin","id":10002753,"avatar_url":"https://avatars.githubusercontent.com/u/10002753?v=3","gravatar_id":"","url":"https://api.github.com/users/pmatzavin","html_url":"https://github.com/pmatzavin","followers_url":"https://api.github.com/users/pmatzavin/followers","following_url":"https://api.github.com/users/pmatzavin/following{/other_user}","gists_url":"https://api.github.com/users/pmatzavin/gists{/gist_id}","starred_url":"https://api.github.com/users/pmatzavin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmatzavin/subscriptions","organizations_url":"https://api.github.com/users/pmatzavin/orgs","repos_url":"https://api.github.com/users/pmatzavin/repos","events_url":"https://api.github.com/users/pmatzavin/events{/privacy}","received_events_url":"https://api.github.com/users/pmatzavin/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\n\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n\r\n- refactor vars to const and let \r\n\r\nissue: [nodejs/code-and-learn#56(comment)](https://github.com/nodejs/code-and-learn/issues/56#issuecomment-247447165)\r\n\r\nmodified file: test/parallel/test-child-process-stdio.js\r\n\r\nrefactor variable declaration \"var common\" to \"const common\"\r\nrefactor variable declaration \"var assert\" to \"const assert\"\r\nrefactor variable declaration \"var options\" to \"let options\"\r\nrefactor variable declaration \"var child\" to \"let child\"","created_at":"2016-09-17T09:04:20Z","updated_at":"2016-09-22T17:34:07Z","closed_at":"2016-09-22T17:34:06Z","merged_at":null,"merge_commit_sha":"597305141c9280c7da27550bd59f59f39868ba31","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/8584/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/8584/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/8584/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/44e123106993e9d9aa83d1d81a19fa2ded30c5b2","head":{"label":"pmatzavin:test-cleanup-test-child-process-stdio","ref":"test-cleanup-test-child-process-stdio","sha":"44e123106993e9d9aa83d1d81a19fa2ded30c5b2","user":{"login":"pmatzavin","id":10002753,"avatar_url":"https://avatars.githubusercontent.com/u/10002753?v=3","gravatar_id":"","url":"https://api.github.com/users/pmatzavin","html_url":"https://github.com/pmatzavin","followers_url":"https://api.github.com/users/pmatzavin/followers","following_url":"https://api.github.com/users/pmatzavin/following{/other_user}","gists_url":"https://api.github.com/users/pmatzavin/gists{/gist_id}","starred_url":"https://api.github.com/users/pmatzavin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmatzavin/subscriptions","organizations_url":"https://api.github.com/users/pmatzavin/orgs","repos_url":"https://api.github.com/users/pmatzavin/repos","events_url":"https://api.github.com/users/pmatzavin/events{/privacy}","received_events_url":"https://api.github.com/users/pmatzavin/received_events","type":"User","site_admin":false},"repo":{"id":68417496,"name":"node-1","full_name":"pmatzavin/node-1","owner":{"login":"pmatzavin","id":10002753,"avatar_url":"https://avatars.githubusercontent.com/u/10002753?v=3","gravatar_id":"","url":"https://api.github.com/users/pmatzavin","html_url":"https://github.com/pmatzavin","followers_url":"https://api.github.com/users/pmatzavin/followers","following_url":"https://api.github.com/users/pmatzavin/following{/other_user}","gists_url":"https://api.github.com/users/pmatzavin/gists{/gist_id}","starred_url":"https://api.github.com/users/pmatzavin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmatzavin/subscriptions","organizations_url":"https://api.github.com/users/pmatzavin/orgs","repos_url":"https://api.github.com/users/pmatzavin/repos","events_url":"https://api.github.com/users/pmatzavin/events{/privacy}","received_events_url":"https://api.github.com/users/pmatzavin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmatzavin/node-1","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/pmatzavin/node-1","forks_url":"https://api.github.com/repos/pmatzavin/node-1/forks","keys_url":"https://api.github.com/repos/pmatzavin/node-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmatzavin/node-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmatzavin/node-1/teams","hooks_url":"https://api.github.com/repos/pmatzavin/node-1/hooks","issue_events_url":"https://api.github.com/repos/pmatzavin/node-1/issues/events{/number}","events_url":"https://api.github.com/repos/pmatzavin/node-1/events","assignees_url":"https://api.github.com/repos/pmatzavin/node-1/assignees{/user}","branches_url":"https://api.github.com/repos/pmatzavin/node-1/branches{/branch}","tags_url":"https://api.github.com/repos/pmatzavin/node-1/tags","blobs_url":"https://api.github.com/repos/pmatzavin/node-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmatzavin/node-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmatzavin/node-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmatzavin/node-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmatzavin/node-1/statuses/{sha}","languages_url":"https://api.github.com/repos/pmatzavin/node-1/languages","stargazers_url":"https://api.github.com/repos/pmatzavin/node-1/stargazers","contributors_url":"https://api.github.com/repos/pmatzavin/node-1/contributors","subscribers_url":"https://api.github.com/repos/pmatzavin/node-1/subscribers","subscription_url":"https://api.github.com/repos/pmatzavin/node-1/subscription","commits_url":"https://api.github.com/repos/pmatzavin/node-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmatzavin/node-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmatzavin/node-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmatzavin/node-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmatzavin/node-1/contents/{+path}","compare_url":"https://api.github.com/repos/pmatzavin/node-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmatzavin/node-1/merges","archive_url":"https://api.github.com/repos/pmatzavin/node-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmatzavin/node-1/downloads","issues_url":"https://api.github.com/repos/pmatzavin/node-1/issues{/number}","pulls_url":"https://api.github.com/repos/pmatzavin/node-1/pulls{/number}","milestones_url":"https://api.github.com/repos/pmatzavin/node-1/milestones{/number}","notifications_url":"https://api.github.com/repos/pmatzavin/node-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmatzavin/node-1/labels{/name}","releases_url":"https://api.github.com/repos/pmatzavin/node-1/releases{/id}","deployments_url":"https://api.github.com/repos/pmatzavin/node-1/deployments","created_at":"2016-09-16T22:05:17Z","updated_at":"2016-09-16T22:05:38Z","pushed_at":"2016-09-19T15:22:48Z","git_url":"git://github.com/pmatzavin/node-1.git","ssh_url":"git@github.com:pmatzavin/node-1.git","clone_url":"https://github.com/pmatzavin/node-1.git","svn_url":"https://github.com/pmatzavin/node-1","homepage":"https://nodejs.org","size":227239,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"c5ce7f4d9e36fc9f06547de1e41cdf4b2ac02720","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-09-22T16:42:43Z","pushed_at":"2016-09-22T17:33:15Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":304591,"stargazers_count":26953,"watchers_count":26953,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4345,"mirror_url":null,"open_issues_count":827,"forks":4345,"open_issues":827,"watchers":26953,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/8584"},"html":{"href":"https://github.com/nodejs/node/pull/8584"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/8584"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/8584/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/8584/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/8584/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/44e123106993e9d9aa83d1d81a19fa2ded30c5b2"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":3,"review_comments":3,"commits":2,"additions":8,"deletions":8,"changed_files":1}}
{"actor":{"display_login":"jasnell"}}