{"action":"created","comment":{"url":"https://api.github.com/repos/AtomLinter/linter-phpmd/pulls/comments/62541203","id":62541203,"diff_hunk":"@@ -49,8 +38,8 @@ module.exports =\n         filePath = textEditor.getPath()\n         command = @executablePath\n         ruleset = @rulesets\n-        if @projectRules\n-          rulesetPath = helpers.find(filePath, 'ruleset.xml')\n+        if /^[a-z0-9]+\\.xml$/gi.test(@rulesets)","path":"lib/main.coffee","position":39,"original_position":34,"commit_id":"e775b7847681f7d4bba7ae8a7fea6f82f369b47d","original_commit_id":"9698d3f7f900a42aa0e45d34d8c2d0a041f6a3d9","user":{"login":"Arcanemagus","id":427137,"avatar_url":"https://avatars.githubusercontent.com/u/427137?v=3","gravatar_id":"","url":"https://api.github.com/users/Arcanemagus","html_url":"https://github.com/Arcanemagus","followers_url":"https://api.github.com/users/Arcanemagus/followers","following_url":"https://api.github.com/users/Arcanemagus/following{/other_user}","gists_url":"https://api.github.com/users/Arcanemagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Arcanemagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arcanemagus/subscriptions","organizations_url":"https://api.github.com/users/Arcanemagus/orgs","repos_url":"https://api.github.com/users/Arcanemagus/repos","events_url":"https://api.github.com/users/Arcanemagus/events{/privacy}","received_events_url":"https://api.github.com/users/Arcanemagus/received_events","type":"User","site_admin":false},"body":"Since it's a major release I'm not too worried about migration, but it wouldn't be that hard. Something along the lines of running\r\n\r\n```js\r\nif (atom.config.get('linter-phpmd.projectRules') !== undefined):\r\n  atom.notifications.addInfo('The automatic searching for ruleset.xml has been removed. To regain that functionality please add ruleset.xml to the Rulesets setting.')\r\n```\r\n\r\nThe conditional probably isn't perfect, and the wording could use a bit of work, but that's close :stuck_out_tongue:.","created_at":"2016-05-09T17:46:46Z","updated_at":"2016-05-09T17:46:46Z","html_url":"https://github.com/AtomLinter/linter-phpmd/pull/59#discussion_r62541203","pull_request_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/pulls/59","_links":{"self":{"href":"https://api.github.com/repos/AtomLinter/linter-phpmd/pulls/comments/62541203"},"html":{"href":"https://github.com/AtomLinter/linter-phpmd/pull/59#discussion_r62541203"},"pull_request":{"href":"https://api.github.com/repos/AtomLinter/linter-phpmd/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/AtomLinter/linter-phpmd/pulls/59","id":69176280,"html_url":"https://github.com/AtomLinter/linter-phpmd/pull/59","diff_url":"https://github.com/AtomLinter/linter-phpmd/pull/59.diff","patch_url":"https://github.com/AtomLinter/linter-phpmd/pull/59.patch","issue_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/issues/59","number":59,"state":"open","locked":false,"title":"Ability to specify ruleset filename","user":{"login":"stipsan","id":81981,"avatar_url":"https://avatars.githubusercontent.com/u/81981?v=3","gravatar_id":"","url":"https://api.github.com/users/stipsan","html_url":"https://github.com/stipsan","followers_url":"https://api.github.com/users/stipsan/followers","following_url":"https://api.github.com/users/stipsan/following{/other_user}","gists_url":"https://api.github.com/users/stipsan/gists{/gist_id}","starred_url":"https://api.github.com/users/stipsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stipsan/subscriptions","organizations_url":"https://api.github.com/users/stipsan/orgs","repos_url":"https://api.github.com/users/stipsan/repos","events_url":"https://api.github.com/users/stipsan/events{/privacy}","received_events_url":"https://api.github.com/users/stipsan/received_events","type":"User","site_admin":false},"body":"PHPMD allows you to actually enter a filename path in the ruleset\ncommand itself, but it requires you to enter the path.\nThis commit allows passing a simple filename, and if it detects a xml\nfilename passed without being a relative or absolute path it'll look in\nthe current or parent directories to find the file.\n\nFixes #58","created_at":"2016-05-06T16:31:32Z","updated_at":"2016-05-09T17:46:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3514079e3e29feae8577455bc08fe6ad453ce7c3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/pulls/59/commits","review_comments_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/pulls/59/comments","review_comment_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/issues/59/comments","statuses_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/statuses/e775b7847681f7d4bba7ae8a7fea6f82f369b47d","head":{"label":"stipsan:master","ref":"master","sha":"e775b7847681f7d4bba7ae8a7fea6f82f369b47d","user":{"login":"stipsan","id":81981,"avatar_url":"https://avatars.githubusercontent.com/u/81981?v=3","gravatar_id":"","url":"https://api.github.com/users/stipsan","html_url":"https://github.com/stipsan","followers_url":"https://api.github.com/users/stipsan/followers","following_url":"https://api.github.com/users/stipsan/following{/other_user}","gists_url":"https://api.github.com/users/stipsan/gists{/gist_id}","starred_url":"https://api.github.com/users/stipsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stipsan/subscriptions","organizations_url":"https://api.github.com/users/stipsan/orgs","repos_url":"https://api.github.com/users/stipsan/repos","events_url":"https://api.github.com/users/stipsan/events{/privacy}","received_events_url":"https://api.github.com/users/stipsan/received_events","type":"User","site_admin":false},"repo":{"id":58218152,"name":"linter-phpmd","full_name":"stipsan/linter-phpmd","owner":{"login":"stipsan","id":81981,"avatar_url":"https://avatars.githubusercontent.com/u/81981?v=3","gravatar_id":"","url":"https://api.github.com/users/stipsan","html_url":"https://github.com/stipsan","followers_url":"https://api.github.com/users/stipsan/followers","following_url":"https://api.github.com/users/stipsan/following{/other_user}","gists_url":"https://api.github.com/users/stipsan/gists{/gist_id}","starred_url":"https://api.github.com/users/stipsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stipsan/subscriptions","organizations_url":"https://api.github.com/users/stipsan/orgs","repos_url":"https://api.github.com/users/stipsan/repos","events_url":"https://api.github.com/users/stipsan/events{/privacy}","received_events_url":"https://api.github.com/users/stipsan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stipsan/linter-phpmd","description":"Atom linter plugin for php, using phpmd.","fork":true,"url":"https://api.github.com/repos/stipsan/linter-phpmd","forks_url":"https://api.github.com/repos/stipsan/linter-phpmd/forks","keys_url":"https://api.github.com/repos/stipsan/linter-phpmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stipsan/linter-phpmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stipsan/linter-phpmd/teams","hooks_url":"https://api.github.com/repos/stipsan/linter-phpmd/hooks","issue_events_url":"https://api.github.com/repos/stipsan/linter-phpmd/issues/events{/number}","events_url":"https://api.github.com/repos/stipsan/linter-phpmd/events","assignees_url":"https://api.github.com/repos/stipsan/linter-phpmd/assignees{/user}","branches_url":"https://api.github.com/repos/stipsan/linter-phpmd/branches{/branch}","tags_url":"https://api.github.com/repos/stipsan/linter-phpmd/tags","blobs_url":"https://api.github.com/repos/stipsan/linter-phpmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stipsan/linter-phpmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stipsan/linter-phpmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/stipsan/linter-phpmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stipsan/linter-phpmd/statuses/{sha}","languages_url":"https://api.github.com/repos/stipsan/linter-phpmd/languages","stargazers_url":"https://api.github.com/repos/stipsan/linter-phpmd/stargazers","contributors_url":"https://api.github.com/repos/stipsan/linter-phpmd/contributors","subscribers_url":"https://api.github.com/repos/stipsan/linter-phpmd/subscribers","subscription_url":"https://api.github.com/repos/stipsan/linter-phpmd/subscription","commits_url":"https://api.github.com/repos/stipsan/linter-phpmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/stipsan/linter-phpmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/stipsan/linter-phpmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/stipsan/linter-phpmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/stipsan/linter-phpmd/contents/{+path}","compare_url":"https://api.github.com/repos/stipsan/linter-phpmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stipsan/linter-phpmd/merges","archive_url":"https://api.github.com/repos/stipsan/linter-phpmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stipsan/linter-phpmd/downloads","issues_url":"https://api.github.com/repos/stipsan/linter-phpmd/issues{/number}","pulls_url":"https://api.github.com/repos/stipsan/linter-phpmd/pulls{/number}","milestones_url":"https://api.github.com/repos/stipsan/linter-phpmd/milestones{/number}","notifications_url":"https://api.github.com/repos/stipsan/linter-phpmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stipsan/linter-phpmd/labels{/name}","releases_url":"https://api.github.com/repos/stipsan/linter-phpmd/releases{/id}","deployments_url":"https://api.github.com/repos/stipsan/linter-phpmd/deployments","created_at":"2016-05-06T15:51:12Z","updated_at":"2016-05-06T15:51:13Z","pushed_at":"2016-05-09T17:06:55Z","git_url":"git://github.com/stipsan/linter-phpmd.git","ssh_url":"git@github.com:stipsan/linter-phpmd.git","clone_url":"https://github.com/stipsan/linter-phpmd.git","svn_url":"https://github.com/stipsan/linter-phpmd","homepage":null,"size":51,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AtomLinter:master","ref":"master","sha":"c8c1e110d05506f846eda503020dd4dcfe738a1a","user":{"login":"AtomLinter","id":7242824,"avatar_url":"https://avatars.githubusercontent.com/u/7242824?v=3","gravatar_id":"","url":"https://api.github.com/users/AtomLinter","html_url":"https://github.com/AtomLinter","followers_url":"https://api.github.com/users/AtomLinter/followers","following_url":"https://api.github.com/users/AtomLinter/following{/other_user}","gists_url":"https://api.github.com/users/AtomLinter/gists{/gist_id}","starred_url":"https://api.github.com/users/AtomLinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtomLinter/subscriptions","organizations_url":"https://api.github.com/users/AtomLinter/orgs","repos_url":"https://api.github.com/users/AtomLinter/repos","events_url":"https://api.github.com/users/AtomLinter/events{/privacy}","received_events_url":"https://api.github.com/users/AtomLinter/received_events","type":"Organization","site_admin":false},"repo":{"id":18725889,"name":"linter-phpmd","full_name":"AtomLinter/linter-phpmd","owner":{"login":"AtomLinter","id":7242824,"avatar_url":"https://avatars.githubusercontent.com/u/7242824?v=3","gravatar_id":"","url":"https://api.github.com/users/AtomLinter","html_url":"https://github.com/AtomLinter","followers_url":"https://api.github.com/users/AtomLinter/followers","following_url":"https://api.github.com/users/AtomLinter/following{/other_user}","gists_url":"https://api.github.com/users/AtomLinter/gists{/gist_id}","starred_url":"https://api.github.com/users/AtomLinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtomLinter/subscriptions","organizations_url":"https://api.github.com/users/AtomLinter/orgs","repos_url":"https://api.github.com/users/AtomLinter/repos","events_url":"https://api.github.com/users/AtomLinter/events{/privacy}","received_events_url":"https://api.github.com/users/AtomLinter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AtomLinter/linter-phpmd","description":"Atom linter plugin for php, using phpmd.","fork":false,"url":"https://api.github.com/repos/AtomLinter/linter-phpmd","forks_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/forks","keys_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/teams","hooks_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/hooks","issue_events_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/issues/events{/number}","events_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/events","assignees_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/assignees{/user}","branches_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/branches{/branch}","tags_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/tags","blobs_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/statuses/{sha}","languages_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/languages","stargazers_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/stargazers","contributors_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/contributors","subscribers_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/subscribers","subscription_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/subscription","commits_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/contents/{+path}","compare_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/merges","archive_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/downloads","issues_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/issues{/number}","pulls_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/pulls{/number}","milestones_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/milestones{/number}","notifications_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/labels{/name}","releases_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/releases{/id}","deployments_url":"https://api.github.com/repos/AtomLinter/linter-phpmd/deployments","created_at":"2014-04-13T09:37:20Z","updated_at":"2016-01-29T00:09:59Z","pushed_at":"2016-05-09T17:06:55Z","git_url":"git://github.com/AtomLinter/linter-phpmd.git","ssh_url":"git@github.com:AtomLinter/linter-phpmd.git","clone_url":"https://github.com/AtomLinter/linter-phpmd.git","svn_url":"https://github.com/AtomLinter/linter-phpmd","homepage":null,"size":54,"stargazers_count":13,"watchers_count":13,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":6,"forks":5,"open_issues":6,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AtomLinter/linter-phpmd/pulls/59"},"html":{"href":"https://github.com/AtomLinter/linter-phpmd/pull/59"},"issue":{"href":"https://api.github.com/repos/AtomLinter/linter-phpmd/issues/59"},"comments":{"href":"https://api.github.com/repos/AtomLinter/linter-phpmd/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/AtomLinter/linter-phpmd/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/AtomLinter/linter-phpmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AtomLinter/linter-phpmd/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/AtomLinter/linter-phpmd/statuses/e775b7847681f7d4bba7ae8a7fea6f82f369b47d"}}}}