{"action":"created","comment":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/comments/81584614","pull_request_review_id":2553993,"id":81584614,"diff_hunk":"@@ -222,9 +222,7 @@ void ValidateWatchApp (string path, string mainBundleIdentifier, string mainShor\n \t\t\t\tcount++;\n \t\t\t}\n \n-\t\t\tif (count > 0)\n-\t\t\t\tLog.LogError (\"The Watch App '{0}' contains more than 1 Watch Extension.\", name);\n-\t\t\telse if (count == 0)\n+\t\t\tif (count == 0)","path":"msbuild/Xamarin.iOS.Tasks.Core/Tasks/ValidateAppBundleTaskBase.cs","position":null,"original_position":7,"commit_id":"677448da11b4e5170c3e00095c92d1243e271ecf","original_commit_id":"677448da11b4e5170c3e00095c92d1243e271ecf","user":{"login":"rolfbjarne","id":249268,"avatar_url":"https://avatars.githubusercontent.com/u/249268?v=3","gravatar_id":"","url":"https://api.github.com/users/rolfbjarne","html_url":"https://github.com/rolfbjarne","followers_url":"https://api.github.com/users/rolfbjarne/followers","following_url":"https://api.github.com/users/rolfbjarne/following{/other_user}","gists_url":"https://api.github.com/users/rolfbjarne/gists{/gist_id}","starred_url":"https://api.github.com/users/rolfbjarne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolfbjarne/subscriptions","organizations_url":"https://api.github.com/users/rolfbjarne/orgs","repos_url":"https://api.github.com/users/rolfbjarne/repos","events_url":"https://api.github.com/users/rolfbjarne/events{/privacy}","received_events_url":"https://api.github.com/users/rolfbjarne/received_events","type":"User","site_admin":false},"body":"OK, if you're just removing tests that you added in this PR it's fine.","created_at":"2016-10-03T16:18:37Z","updated_at":"2016-10-03T16:18:38Z","html_url":"https://github.com/xamarin/xamarin-macios/pull/913#discussion_r81584614","pull_request_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/913","_links":{"self":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/comments/81584614"},"html":{"href":"https://github.com/xamarin/xamarin-macios/pull/913#discussion_r81584614"},"pull_request":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/913"}}},"pull_request":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/913","id":87211193,"html_url":"https://github.com/xamarin/xamarin-macios/pull/913","diff_url":"https://github.com/xamarin/xamarin-macios/pull/913.diff","patch_url":"https://github.com/xamarin/xamarin-macios/pull/913.patch","issue_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/913","number":913,"state":"open","locked":false,"title":"[msbuild] Fixed IsWatchExtension state property","user":{"login":"jstedfast","id":338984,"avatar_url":"https://avatars.githubusercontent.com/u/338984?v=3","gravatar_id":"","url":"https://api.github.com/users/jstedfast","html_url":"https://github.com/jstedfast","followers_url":"https://api.github.com/users/jstedfast/followers","following_url":"https://api.github.com/users/jstedfast/following{/other_user}","gists_url":"https://api.github.com/users/jstedfast/gists{/gist_id}","starred_url":"https://api.github.com/users/jstedfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstedfast/subscriptions","organizations_url":"https://api.github.com/users/jstedfast/orgs","repos_url":"https://api.github.com/users/jstedfast/repos","events_url":"https://api.github.com/users/jstedfast/events{/privacy}","received_events_url":"https://api.github.com/users/jstedfast/received_events","type":"User","site_admin":false},"body":"The problem was that this property was evaluating to True\r\nfor the main app bundle because it assumed that if the\r\nproject contained a Watch app, that it was the WatchExtension.\r\n\r\nThis logic only holds true for WatchOS1, but not WatchOS2.\r\n\r\nFixes https://bugzilla.xamarin.com/show_bug.cgi?id=44841","created_at":"2016-09-28T22:08:15Z","updated_at":"2016-10-03T16:18:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50e79a86327120725a4305ada954c3c7871e2957","assignee":{"login":"spouliot","id":260465,"avatar_url":"https://avatars.githubusercontent.com/u/260465?v=3","gravatar_id":"","url":"https://api.github.com/users/spouliot","html_url":"https://github.com/spouliot","followers_url":"https://api.github.com/users/spouliot/followers","following_url":"https://api.github.com/users/spouliot/following{/other_user}","gists_url":"https://api.github.com/users/spouliot/gists{/gist_id}","starred_url":"https://api.github.com/users/spouliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spouliot/subscriptions","organizations_url":"https://api.github.com/users/spouliot/orgs","repos_url":"https://api.github.com/users/spouliot/repos","events_url":"https://api.github.com/users/spouliot/events{/privacy}","received_events_url":"https://api.github.com/users/spouliot/received_events","type":"User","site_admin":false},"assignees":[{"login":"spouliot","id":260465,"avatar_url":"https://avatars.githubusercontent.com/u/260465?v=3","gravatar_id":"","url":"https://api.github.com/users/spouliot","html_url":"https://github.com/spouliot","followers_url":"https://api.github.com/users/spouliot/followers","following_url":"https://api.github.com/users/spouliot/following{/other_user}","gists_url":"https://api.github.com/users/spouliot/gists{/gist_id}","starred_url":"https://api.github.com/users/spouliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spouliot/subscriptions","organizations_url":"https://api.github.com/users/spouliot/orgs","repos_url":"https://api.github.com/users/spouliot/repos","events_url":"https://api.github.com/users/spouliot/events{/privacy}","received_events_url":"https://api.github.com/users/spouliot/received_events","type":"User","site_admin":false},{"login":"VincentDondain","id":7839202,"avatar_url":"https://avatars.githubusercontent.com/u/7839202?v=3","gravatar_id":"","url":"https://api.github.com/users/VincentDondain","html_url":"https://github.com/VincentDondain","followers_url":"https://api.github.com/users/VincentDondain/followers","following_url":"https://api.github.com/users/VincentDondain/following{/other_user}","gists_url":"https://api.github.com/users/VincentDondain/gists{/gist_id}","starred_url":"https://api.github.com/users/VincentDondain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VincentDondain/subscriptions","organizations_url":"https://api.github.com/users/VincentDondain/orgs","repos_url":"https://api.github.com/users/VincentDondain/repos","events_url":"https://api.github.com/users/VincentDondain/events{/privacy}","received_events_url":"https://api.github.com/users/VincentDondain/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/913/commits","review_comments_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/913/comments","review_comment_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/913/comments","statuses_url":"https://api.github.com/repos/xamarin/xamarin-macios/statuses/677448da11b4e5170c3e00095c92d1243e271ecf","head":{"label":"jstedfast:msbuild-iswatchextension","ref":"msbuild-iswatchextension","sha":"677448da11b4e5170c3e00095c92d1243e271ecf","user":{"login":"jstedfast","id":338984,"avatar_url":"https://avatars.githubusercontent.com/u/338984?v=3","gravatar_id":"","url":"https://api.github.com/users/jstedfast","html_url":"https://github.com/jstedfast","followers_url":"https://api.github.com/users/jstedfast/followers","following_url":"https://api.github.com/users/jstedfast/following{/other_user}","gists_url":"https://api.github.com/users/jstedfast/gists{/gist_id}","starred_url":"https://api.github.com/users/jstedfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstedfast/subscriptions","organizations_url":"https://api.github.com/users/jstedfast/orgs","repos_url":"https://api.github.com/users/jstedfast/repos","events_url":"https://api.github.com/users/jstedfast/events{/privacy}","received_events_url":"https://api.github.com/users/jstedfast/received_events","type":"User","site_admin":false},"repo":{"id":58662588,"name":"xamarin-macios","full_name":"jstedfast/xamarin-macios","owner":{"login":"jstedfast","id":338984,"avatar_url":"https://avatars.githubusercontent.com/u/338984?v=3","gravatar_id":"","url":"https://api.github.com/users/jstedfast","html_url":"https://github.com/jstedfast","followers_url":"https://api.github.com/users/jstedfast/followers","following_url":"https://api.github.com/users/jstedfast/following{/other_user}","gists_url":"https://api.github.com/users/jstedfast/gists{/gist_id}","starred_url":"https://api.github.com/users/jstedfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstedfast/subscriptions","organizations_url":"https://api.github.com/users/jstedfast/orgs","repos_url":"https://api.github.com/users/jstedfast/repos","events_url":"https://api.github.com/users/jstedfast/events{/privacy}","received_events_url":"https://api.github.com/users/jstedfast/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jstedfast/xamarin-macios","description":"Bridges the worlds of .NET with the native APIs of Mac, iOS, tvOS, and watchOS.","fork":true,"url":"https://api.github.com/repos/jstedfast/xamarin-macios","forks_url":"https://api.github.com/repos/jstedfast/xamarin-macios/forks","keys_url":"https://api.github.com/repos/jstedfast/xamarin-macios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jstedfast/xamarin-macios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jstedfast/xamarin-macios/teams","hooks_url":"https://api.github.com/repos/jstedfast/xamarin-macios/hooks","issue_events_url":"https://api.github.com/repos/jstedfast/xamarin-macios/issues/events{/number}","events_url":"https://api.github.com/repos/jstedfast/xamarin-macios/events","assignees_url":"https://api.github.com/repos/jstedfast/xamarin-macios/assignees{/user}","branches_url":"https://api.github.com/repos/jstedfast/xamarin-macios/branches{/branch}","tags_url":"https://api.github.com/repos/jstedfast/xamarin-macios/tags","blobs_url":"https://api.github.com/repos/jstedfast/xamarin-macios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jstedfast/xamarin-macios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jstedfast/xamarin-macios/git/refs{/sha}","trees_url":"https://api.github.com/repos/jstedfast/xamarin-macios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jstedfast/xamarin-macios/statuses/{sha}","languages_url":"https://api.github.com/repos/jstedfast/xamarin-macios/languages","stargazers_url":"https://api.github.com/repos/jstedfast/xamarin-macios/stargazers","contributors_url":"https://api.github.com/repos/jstedfast/xamarin-macios/contributors","subscribers_url":"https://api.github.com/repos/jstedfast/xamarin-macios/subscribers","subscription_url":"https://api.github.com/repos/jstedfast/xamarin-macios/subscription","commits_url":"https://api.github.com/repos/jstedfast/xamarin-macios/commits{/sha}","git_commits_url":"https://api.github.com/repos/jstedfast/xamarin-macios/git/commits{/sha}","comments_url":"https://api.github.com/repos/jstedfast/xamarin-macios/comments{/number}","issue_comment_url":"https://api.github.com/repos/jstedfast/xamarin-macios/issues/comments{/number}","contents_url":"https://api.github.com/repos/jstedfast/xamarin-macios/contents/{+path}","compare_url":"https://api.github.com/repos/jstedfast/xamarin-macios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jstedfast/xamarin-macios/merges","archive_url":"https://api.github.com/repos/jstedfast/xamarin-macios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jstedfast/xamarin-macios/downloads","issues_url":"https://api.github.com/repos/jstedfast/xamarin-macios/issues{/number}","pulls_url":"https://api.github.com/repos/jstedfast/xamarin-macios/pulls{/number}","milestones_url":"https://api.github.com/repos/jstedfast/xamarin-macios/milestones{/number}","notifications_url":"https://api.github.com/repos/jstedfast/xamarin-macios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jstedfast/xamarin-macios/labels{/name}","releases_url":"https://api.github.com/repos/jstedfast/xamarin-macios/releases{/id}","deployments_url":"https://api.github.com/repos/jstedfast/xamarin-macios/deployments","created_at":"2016-05-12T17:28:59Z","updated_at":"2016-05-12T17:29:07Z","pushed_at":"2016-10-03T15:31:43Z","git_url":"git://github.com/jstedfast/xamarin-macios.git","ssh_url":"git@github.com:jstedfast/xamarin-macios.git","clone_url":"https://github.com/jstedfast/xamarin-macios.git","svn_url":"https://github.com/jstedfast/xamarin-macios","homepage":null,"size":36323,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xamarin:master","ref":"master","sha":"6f377302936ce1965734e47f40620938ed012737","user":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":56710511,"name":"xamarin-macios","full_name":"xamarin/xamarin-macios","owner":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xamarin/xamarin-macios","description":"Bridges the worlds of .NET with the native APIs of Mac, iOS, tvOS, and watchOS.","fork":false,"url":"https://api.github.com/repos/xamarin/xamarin-macios","forks_url":"https://api.github.com/repos/xamarin/xamarin-macios/forks","keys_url":"https://api.github.com/repos/xamarin/xamarin-macios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/xamarin-macios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/xamarin-macios/teams","hooks_url":"https://api.github.com/repos/xamarin/xamarin-macios/hooks","issue_events_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/xamarin-macios/events","assignees_url":"https://api.github.com/repos/xamarin/xamarin-macios/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/xamarin-macios/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/xamarin-macios/tags","blobs_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/xamarin-macios/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/xamarin-macios/languages","stargazers_url":"https://api.github.com/repos/xamarin/xamarin-macios/stargazers","contributors_url":"https://api.github.com/repos/xamarin/xamarin-macios/contributors","subscribers_url":"https://api.github.com/repos/xamarin/xamarin-macios/subscribers","subscription_url":"https://api.github.com/repos/xamarin/xamarin-macios/subscription","commits_url":"https://api.github.com/repos/xamarin/xamarin-macios/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/xamarin-macios/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/xamarin-macios/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/xamarin-macios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/xamarin-macios/merges","archive_url":"https://api.github.com/repos/xamarin/xamarin-macios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/xamarin-macios/downloads","issues_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/xamarin-macios/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/xamarin-macios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/xamarin-macios/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/xamarin-macios/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/xamarin-macios/deployments","created_at":"2016-04-20T18:24:26Z","updated_at":"2016-10-03T02:23:04Z","pushed_at":"2016-10-03T15:45:27Z","git_url":"git://github.com/xamarin/xamarin-macios.git","ssh_url":"git@github.com:xamarin/xamarin-macios.git","clone_url":"https://github.com/xamarin/xamarin-macios.git","svn_url":"https://github.com/xamarin/xamarin-macios","homepage":null,"size":38822,"stargazers_count":642,"watchers_count":642,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"open_issues_count":15,"forks":115,"open_issues":15,"watchers":642,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/913"},"html":{"href":"https://github.com/xamarin/xamarin-macios/pull/913"},"issue":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/issues/913"},"comments":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/issues/913/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/913/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/913/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/statuses/677448da11b4e5170c3e00095c92d1243e271ecf"}}}}
{"actor":{"display_login":"rolfbjarne"}}