{"action":"created","issue":{"url":"https://api.github.com/repos/Leaflet/Leaflet.markercluster/issues/441","repository_url":"https://api.github.com/repos/Leaflet/Leaflet.markercluster","labels_url":"https://api.github.com/repos/Leaflet/Leaflet.markercluster/issues/441/labels{/name}","comments_url":"https://api.github.com/repos/Leaflet/Leaflet.markercluster/issues/441/comments","events_url":"https://api.github.com/repos/Leaflet/Leaflet.markercluster/issues/441/events","html_url":"https://github.com/Leaflet/Leaflet.markercluster/issues/441","id":56932208,"number":441,"title":"CommonJS support?","user":{"login":"MandarinConLaBarba","id":961948,"avatar_url":"https://avatars.githubusercontent.com/u/961948?v=3","gravatar_id":"","url":"https://api.github.com/users/MandarinConLaBarba","html_url":"https://github.com/MandarinConLaBarba","followers_url":"https://api.github.com/users/MandarinConLaBarba/followers","following_url":"https://api.github.com/users/MandarinConLaBarba/following{/other_user}","gists_url":"https://api.github.com/users/MandarinConLaBarba/gists{/gist_id}","starred_url":"https://api.github.com/users/MandarinConLaBarba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MandarinConLaBarba/subscriptions","organizations_url":"https://api.github.com/users/MandarinConLaBarba/orgs","repos_url":"https://api.github.com/users/MandarinConLaBarba/repos","events_url":"https://api.github.com/users/MandarinConLaBarba/events{/privacy}","received_events_url":"https://api.github.com/users/MandarinConLaBarba/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2015-02-08T00:19:41Z","updated_at":"2016-12-11T21:27:55Z","closed_at":null,"body":"I didn't see anything in the issue list about this - are there plans/hopes/aspirations for support for CommonJS-style module definition? It seems odd to me that Leaflet core supports CommonJS but this plugin doesn't.\n"},"comment":{"url":"https://api.github.com/repos/Leaflet/Leaflet.markercluster/issues/comments/266309306","html_url":"https://github.com/Leaflet/Leaflet.markercluster/issues/441#issuecomment-266309306","issue_url":"https://api.github.com/repos/Leaflet/Leaflet.markercluster/issues/441","id":266309306,"user":{"login":"crudbetter","id":378139,"avatar_url":"https://avatars.githubusercontent.com/u/378139?v=3","gravatar_id":"","url":"https://api.github.com/users/crudbetter","html_url":"https://github.com/crudbetter","followers_url":"https://api.github.com/users/crudbetter/followers","following_url":"https://api.github.com/users/crudbetter/following{/other_user}","gists_url":"https://api.github.com/users/crudbetter/gists{/gist_id}","starred_url":"https://api.github.com/users/crudbetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crudbetter/subscriptions","organizations_url":"https://api.github.com/users/crudbetter/orgs","repos_url":"https://api.github.com/users/crudbetter/repos","events_url":"https://api.github.com/users/crudbetter/events{/privacy}","received_events_url":"https://api.github.com/users/crudbetter/received_events","type":"User","site_admin":false},"created_at":"2016-12-11T21:27:55Z","updated_at":"2016-12-11T21:27:55Z","body":"Looking at the source `require('leaflet')` sets both `module.exports = L` and `window.L = L`. Which is why `require('leaflet.markercluster')` works (it uses `window.L`).\r\n\r\nIdeally I would prefer to use `require('leaflet').noConflict()` to get rid of setting `window.L`. \r\n\r\nAt the moment I cannot then find a way of \"passing\" `L` to `leaflet.markercluster`. Have tried `browserify-shim` so far without success.\r\n\r\n"}}
{"actor":{"display_login":"crudbetter"}}