{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/pulls/comments/72414614","id":72414614,"diff_hunk":"@@ -387,21 +411,76 @@ private void runSequential() {\n         }\n     }\n \n-    private void moveLogFiles() {\n-        if (isLocal(simulatorProperties)) {\n-            File workerHome = newFile(getSimulatorHome(), WORKERS_HOME_NAME);\n-            File targetDirectory = ensureExistingDirectory(newFile(\".\", WORKERS_HOME_NAME), testSuite.getId());\n-\n-            String workerPath = workerHome.getAbsolutePath();\n-            String targetPath = targetDirectory.getAbsolutePath();\n-\n-            execute(format(\"mv %s/%s/* %s || true\", workerPath, testSuite.getId(), targetPath));\n-            execute(format(\"rmdir %s/%s || true\", workerPath, testSuite.getId()));\n-            execute(format(\"rmdir %s || true\", workerPath));\n-            execute(format(\"mv ./agent.err %s/ || true\", targetPath));\n-            execute(format(\"mv ./agent.out %s/ || true\", targetPath));\n-            execute(format(\"mv ./failures-%s.txt %s/ || true\", testSuite.getId(), targetPath));\n+    private void downloadLocal() {\n+        File workerHome = newFile(getSimulatorHome(), WORKERS_HOME_NAME);\n+        File targetDirectory = ensureExistingDirectory(newFile(\".\", WORKERS_HOME_NAME), testSuite.getId());","path":"simulator/src/main/java/com/hazelcast/simulator/coordinator/Coordinator.java","position":103,"original_position":103,"commit_id":"0f3d4e7424e0725a85977fb767234a910005bf5f","original_commit_id":"0f3d4e7424e0725a85977fb767234a910005bf5f","user":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"body":"We might re-use `outputDirectory` here, since it should be the same for local and remote.","created_at":"2016-07-27T10:16:24Z","updated_at":"2016-07-27T10:16:24Z","html_url":"https://github.com/hazelcast/hazelcast-simulator/pull/983#discussion_r72414614","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/pulls/983","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast-simulator/pulls/comments/72414614"},"html":{"href":"https://github.com/hazelcast/hazelcast-simulator/pull/983#discussion_r72414614"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast-simulator/pulls/983"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/pulls/983","id":78974555,"html_url":"https://github.com/hazelcast/hazelcast-simulator/pull/983","diff_url":"https://github.com/hazelcast/hazelcast-simulator/pull/983.diff","patch_url":"https://github.com/hazelcast/hazelcast-simulator/pull/983.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/issues/983","number":983,"state":"open","locked":false,"title":"Configurable output directory","user":{"login":"pveentjer","id":105243,"avatar_url":"https://avatars.githubusercontent.com/u/105243?v=3","gravatar_id":"","url":"https://api.github.com/users/pveentjer","html_url":"https://github.com/pveentjer","followers_url":"https://api.github.com/users/pveentjer/followers","following_url":"https://api.github.com/users/pveentjer/following{/other_user}","gists_url":"https://api.github.com/users/pveentjer/gists{/gist_id}","starred_url":"https://api.github.com/users/pveentjer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pveentjer/subscriptions","organizations_url":"https://api.github.com/users/pveentjer/orgs","repos_url":"https://api.github.com/users/pveentjer/repos","events_url":"https://api.github.com/users/pveentjer/events{/privacy}","received_events_url":"https://api.github.com/users/pveentjer/received_events","type":"User","site_admin":false},"body":"The output directory for all artifacts for a testsuite run are now downloaded in a new directory in the working directory. This directory will have some timestamp by default, but by setting the testsuite id, the directory name is also determined.\r\n\r\nThere is also an automatic download of the worker directories of the remote machine for that given testsuite-id.\r\n\r\nFixes https://github.com/hazelcast/hazelcast-simulator/issues/887","created_at":"2016-07-27T07:02:40Z","updated_at":"2016-07-27T10:16:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28eed825806bb13af69ad9ff311e468bea7ccf52","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/milestones/9","html_url":"https://github.com/hazelcast/hazelcast-simulator/milestones/0.8","labels_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/milestones/9/labels","id":1697871,"number":9,"title":"0.8","description":"","creator":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":108,"state":"open","created_at":"2016-04-11T13:45:19Z","updated_at":"2016-07-27T09:02:18Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/pulls/983/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/pulls/983/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/issues/983/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/statuses/0f3d4e7424e0725a85977fb767234a910005bf5f","head":{"label":"pveentjer:feature/3.x/configurable-output-directory","ref":"feature/3.x/configurable-output-directory","sha":"0f3d4e7424e0725a85977fb767234a910005bf5f","user":{"login":"pveentjer","id":105243,"avatar_url":"https://avatars.githubusercontent.com/u/105243?v=3","gravatar_id":"","url":"https://api.github.com/users/pveentjer","html_url":"https://github.com/pveentjer","followers_url":"https://api.github.com/users/pveentjer/followers","following_url":"https://api.github.com/users/pveentjer/following{/other_user}","gists_url":"https://api.github.com/users/pveentjer/gists{/gist_id}","starred_url":"https://api.github.com/users/pveentjer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pveentjer/subscriptions","organizations_url":"https://api.github.com/users/pveentjer/orgs","repos_url":"https://api.github.com/users/pveentjer/repos","events_url":"https://api.github.com/users/pveentjer/events{/privacy}","received_events_url":"https://api.github.com/users/pveentjer/received_events","type":"User","site_admin":false},"repo":{"id":39063004,"name":"hazelcast-simulator","full_name":"pveentjer/hazelcast-simulator","owner":{"login":"pveentjer","id":105243,"avatar_url":"https://avatars.githubusercontent.com/u/105243?v=3","gravatar_id":"","url":"https://api.github.com/users/pveentjer","html_url":"https://github.com/pveentjer","followers_url":"https://api.github.com/users/pveentjer/followers","following_url":"https://api.github.com/users/pveentjer/following{/other_user}","gists_url":"https://api.github.com/users/pveentjer/gists{/gist_id}","starred_url":"https://api.github.com/users/pveentjer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pveentjer/subscriptions","organizations_url":"https://api.github.com/users/pveentjer/orgs","repos_url":"https://api.github.com/users/pveentjer/repos","events_url":"https://api.github.com/users/pveentjer/events{/privacy}","received_events_url":"https://api.github.com/users/pveentjer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pveentjer/hazelcast-simulator","description":"A tool for stress testing Hazelcast","fork":true,"url":"https://api.github.com/repos/pveentjer/hazelcast-simulator","forks_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/forks","keys_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/teams","hooks_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/hooks","issue_events_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/events","assignees_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/tags","blobs_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/languages","stargazers_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/stargazers","contributors_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/contributors","subscribers_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/subscribers","subscription_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/subscription","commits_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/merges","archive_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/downloads","issues_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/labels{/name}","releases_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/releases{/id}","deployments_url":"https://api.github.com/repos/pveentjer/hazelcast-simulator/deployments","created_at":"2015-07-14T08:23:21Z","updated_at":"2016-05-21T04:16:49Z","pushed_at":"2016-07-27T10:03:33Z","git_url":"git://github.com/pveentjer/hazelcast-simulator.git","ssh_url":"git@github.com:pveentjer/hazelcast-simulator.git","clone_url":"https://github.com/pveentjer/hazelcast-simulator.git","svn_url":"https://github.com/pveentjer/hazelcast-simulator","homepage":null,"size":14355,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"940f1334d18f58098b5d77c629ea2120dc7f93d2","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":11445479,"name":"hazelcast-simulator","full_name":"hazelcast/hazelcast-simulator","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast-simulator","description":"A tool for stress testing Hazelcast","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast-simulator","forks_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/releases{/id}","deployments_url":"https://api.github.com/repos/hazelcast/hazelcast-simulator/deployments","created_at":"2013-07-16T09:18:54Z","updated_at":"2016-07-13T01:57:44Z","pushed_at":"2016-07-27T10:03:33Z","git_url":"git://github.com/hazelcast/hazelcast-simulator.git","ssh_url":"git@github.com:hazelcast/hazelcast-simulator.git","clone_url":"https://github.com/hazelcast/hazelcast-simulator.git","svn_url":"https://github.com/hazelcast/hazelcast-simulator","homepage":null,"size":14766,"stargazers_count":26,"watchers_count":26,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":107,"forks":39,"open_issues":107,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast-simulator/pulls/983"},"html":{"href":"https://github.com/hazelcast/hazelcast-simulator/pull/983"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast-simulator/issues/983"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast-simulator/issues/983/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast-simulator/pulls/983/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast-simulator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast-simulator/pulls/983/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast-simulator/statuses/0f3d4e7424e0725a85977fb767234a910005bf5f"}}}}
{"actor":{"display_login":"Donnerbart"}}