{"action":"closed","number":210,"pull_request":{"url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/pulls/210","id":95247700,"html_url":"https://github.com/mupen64plus/mupen64plus-core/pull/210","diff_url":"https://github.com/mupen64plus/mupen64plus-core/pull/210.diff","patch_url":"https://github.com/mupen64plus/mupen64plus-core/pull/210.patch","issue_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/issues/210","number":210,"state":"closed","locked":false,"title":"Avoid processing CIC response pif ram as commands","user":{"login":"raphnet","id":4382324,"avatar_url":"https://avatars.githubusercontent.com/u/4382324?v=3","gravatar_id":"","url":"https://api.github.com/users/raphnet","html_url":"https://github.com/raphnet","followers_url":"https://api.github.com/users/raphnet/followers","following_url":"https://api.github.com/users/raphnet/following{/other_user}","gists_url":"https://api.github.com/users/raphnet/gists{/gist_id}","starred_url":"https://api.github.com/users/raphnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raphnet/subscriptions","organizations_url":"https://api.github.com/users/raphnet/orgs","repos_url":"https://api.github.com/users/raphnet/repos","events_url":"https://api.github.com/users/raphnet/events{/privacy}","received_events_url":"https://api.github.com/users/raphnet/received_events","type":"User","site_admin":false},"body":"When a CIC challenge took place in update_pif_write(), the pif ram\r\ncontains a bunch 0xFF followed by 0x00 at offsets 46 and 47. Offsets\r\n48 onwards contains the challenge answer.\r\n\r\nThen when update_pif_read() is called, the 0xFF bytes are skipped\r\nup to the two 0x00 bytes that increase the channel to 2. Then the\r\nchallenge answer is (incorrectly) processed as if it were commands\r\nfor the third controller.\r\n\r\nThis cause issues with the raphnetraw plugin since it modifies pif ram\r\nto store the result or command error flags. This corrupts the response\r\nand leads to challenge failure.","created_at":"2016-11-25T04:01:46Z","updated_at":"2016-11-25T04:48:46Z","closed_at":"2016-11-25T04:48:46Z","merged_at":null,"merge_commit_sha":"05004bf97d0bd7ba418bac5a584845ffab1eefa3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/pulls/210/commits","review_comments_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/pulls/210/comments","review_comment_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/issues/210/comments","statuses_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/statuses/bbeecb805c8956c99869d9860cbf507558cb3071","head":{"label":"raphnet:pifram_cicfix","ref":"pifram_cicfix","sha":"bbeecb805c8956c99869d9860cbf507558cb3071","user":{"login":"raphnet","id":4382324,"avatar_url":"https://avatars.githubusercontent.com/u/4382324?v=3","gravatar_id":"","url":"https://api.github.com/users/raphnet","html_url":"https://github.com/raphnet","followers_url":"https://api.github.com/users/raphnet/followers","following_url":"https://api.github.com/users/raphnet/following{/other_user}","gists_url":"https://api.github.com/users/raphnet/gists{/gist_id}","starred_url":"https://api.github.com/users/raphnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raphnet/subscriptions","organizations_url":"https://api.github.com/users/raphnet/orgs","repos_url":"https://api.github.com/users/raphnet/repos","events_url":"https://api.github.com/users/raphnet/events{/privacy}","received_events_url":"https://api.github.com/users/raphnet/received_events","type":"User","site_admin":false},"repo":{"id":74723060,"name":"mupen64plus-core","full_name":"raphnet/mupen64plus-core","owner":{"login":"raphnet","id":4382324,"avatar_url":"https://avatars.githubusercontent.com/u/4382324?v=3","gravatar_id":"","url":"https://api.github.com/users/raphnet","html_url":"https://github.com/raphnet","followers_url":"https://api.github.com/users/raphnet/followers","following_url":"https://api.github.com/users/raphnet/following{/other_user}","gists_url":"https://api.github.com/users/raphnet/gists{/gist_id}","starred_url":"https://api.github.com/users/raphnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raphnet/subscriptions","organizations_url":"https://api.github.com/users/raphnet/orgs","repos_url":"https://api.github.com/users/raphnet/repos","events_url":"https://api.github.com/users/raphnet/events{/privacy}","received_events_url":"https://api.github.com/users/raphnet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/raphnet/mupen64plus-core","description":"Core module of the Mupen64Plus project","fork":true,"url":"https://api.github.com/repos/raphnet/mupen64plus-core","forks_url":"https://api.github.com/repos/raphnet/mupen64plus-core/forks","keys_url":"https://api.github.com/repos/raphnet/mupen64plus-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raphnet/mupen64plus-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raphnet/mupen64plus-core/teams","hooks_url":"https://api.github.com/repos/raphnet/mupen64plus-core/hooks","issue_events_url":"https://api.github.com/repos/raphnet/mupen64plus-core/issues/events{/number}","events_url":"https://api.github.com/repos/raphnet/mupen64plus-core/events","assignees_url":"https://api.github.com/repos/raphnet/mupen64plus-core/assignees{/user}","branches_url":"https://api.github.com/repos/raphnet/mupen64plus-core/branches{/branch}","tags_url":"https://api.github.com/repos/raphnet/mupen64plus-core/tags","blobs_url":"https://api.github.com/repos/raphnet/mupen64plus-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raphnet/mupen64plus-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raphnet/mupen64plus-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/raphnet/mupen64plus-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raphnet/mupen64plus-core/statuses/{sha}","languages_url":"https://api.github.com/repos/raphnet/mupen64plus-core/languages","stargazers_url":"https://api.github.com/repos/raphnet/mupen64plus-core/stargazers","contributors_url":"https://api.github.com/repos/raphnet/mupen64plus-core/contributors","subscribers_url":"https://api.github.com/repos/raphnet/mupen64plus-core/subscribers","subscription_url":"https://api.github.com/repos/raphnet/mupen64plus-core/subscription","commits_url":"https://api.github.com/repos/raphnet/mupen64plus-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/raphnet/mupen64plus-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/raphnet/mupen64plus-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/raphnet/mupen64plus-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/raphnet/mupen64plus-core/contents/{+path}","compare_url":"https://api.github.com/repos/raphnet/mupen64plus-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raphnet/mupen64plus-core/merges","archive_url":"https://api.github.com/repos/raphnet/mupen64plus-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raphnet/mupen64plus-core/downloads","issues_url":"https://api.github.com/repos/raphnet/mupen64plus-core/issues{/number}","pulls_url":"https://api.github.com/repos/raphnet/mupen64plus-core/pulls{/number}","milestones_url":"https://api.github.com/repos/raphnet/mupen64plus-core/milestones{/number}","notifications_url":"https://api.github.com/repos/raphnet/mupen64plus-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raphnet/mupen64plus-core/labels{/name}","releases_url":"https://api.github.com/repos/raphnet/mupen64plus-core/releases{/id}","deployments_url":"https://api.github.com/repos/raphnet/mupen64plus-core/deployments","created_at":"2016-11-25T03:36:31Z","updated_at":"2016-11-25T03:36:33Z","pushed_at":"2016-11-25T04:48:38Z","git_url":"git://github.com/raphnet/mupen64plus-core.git","ssh_url":"git@github.com:raphnet/mupen64plus-core.git","clone_url":"https://github.com/raphnet/mupen64plus-core.git","svn_url":"https://github.com/raphnet/mupen64plus-core","homepage":"","size":11399,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mupen64plus:master","ref":"master","sha":"01890573c8b2e01afa229babd0c03d3d72634c27","user":{"login":"mupen64plus","id":6205049,"avatar_url":"https://avatars.githubusercontent.com/u/6205049?v=3","gravatar_id":"","url":"https://api.github.com/users/mupen64plus","html_url":"https://github.com/mupen64plus","followers_url":"https://api.github.com/users/mupen64plus/followers","following_url":"https://api.github.com/users/mupen64plus/following{/other_user}","gists_url":"https://api.github.com/users/mupen64plus/gists{/gist_id}","starred_url":"https://api.github.com/users/mupen64plus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mupen64plus/subscriptions","organizations_url":"https://api.github.com/users/mupen64plus/orgs","repos_url":"https://api.github.com/users/mupen64plus/repos","events_url":"https://api.github.com/users/mupen64plus/events{/privacy}","received_events_url":"https://api.github.com/users/mupen64plus/received_events","type":"Organization","site_admin":false},"repo":{"id":15262758,"name":"mupen64plus-core","full_name":"mupen64plus/mupen64plus-core","owner":{"login":"mupen64plus","id":6205049,"avatar_url":"https://avatars.githubusercontent.com/u/6205049?v=3","gravatar_id":"","url":"https://api.github.com/users/mupen64plus","html_url":"https://github.com/mupen64plus","followers_url":"https://api.github.com/users/mupen64plus/followers","following_url":"https://api.github.com/users/mupen64plus/following{/other_user}","gists_url":"https://api.github.com/users/mupen64plus/gists{/gist_id}","starred_url":"https://api.github.com/users/mupen64plus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mupen64plus/subscriptions","organizations_url":"https://api.github.com/users/mupen64plus/orgs","repos_url":"https://api.github.com/users/mupen64plus/repos","events_url":"https://api.github.com/users/mupen64plus/events{/privacy}","received_events_url":"https://api.github.com/users/mupen64plus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mupen64plus/mupen64plus-core","description":"Core module of the Mupen64Plus project","fork":false,"url":"https://api.github.com/repos/mupen64plus/mupen64plus-core","forks_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/forks","keys_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/teams","hooks_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/hooks","issue_events_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/issues/events{/number}","events_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/events","assignees_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/assignees{/user}","branches_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/branches{/branch}","tags_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/tags","blobs_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/statuses/{sha}","languages_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/languages","stargazers_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/stargazers","contributors_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/contributors","subscribers_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/subscribers","subscription_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/subscription","commits_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/contents/{+path}","compare_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/merges","archive_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/downloads","issues_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/issues{/number}","pulls_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/pulls{/number}","milestones_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/milestones{/number}","notifications_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/labels{/name}","releases_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/releases{/id}","deployments_url":"https://api.github.com/repos/mupen64plus/mupen64plus-core/deployments","created_at":"2013-12-17T18:41:09Z","updated_at":"2016-11-24T11:10:33Z","pushed_at":"2016-11-25T04:12:40Z","git_url":"git://github.com/mupen64plus/mupen64plus-core.git","ssh_url":"git@github.com:mupen64plus/mupen64plus-core.git","clone_url":"https://github.com/mupen64plus/mupen64plus-core.git","svn_url":"https://github.com/mupen64plus/mupen64plus-core","homepage":"","size":11399,"stargazers_count":271,"watchers_count":271,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":45,"forks":47,"open_issues":45,"watchers":271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mupen64plus/mupen64plus-core/pulls/210"},"html":{"href":"https://github.com/mupen64plus/mupen64plus-core/pull/210"},"issue":{"href":"https://api.github.com/repos/mupen64plus/mupen64plus-core/issues/210"},"comments":{"href":"https://api.github.com/repos/mupen64plus/mupen64plus-core/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/mupen64plus/mupen64plus-core/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/mupen64plus/mupen64plus-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mupen64plus/mupen64plus-core/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/mupen64plus/mupen64plus-core/statuses/bbeecb805c8956c99869d9860cbf507558cb3071"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":2,"additions":11,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"raphnet"}}