{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/dashboard/issues/492","repository_url":"https://api.github.com/repos/kubernetes/dashboard","labels_url":"https://api.github.com/repos/kubernetes/dashboard/issues/492/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/dashboard/issues/492/comments","events_url":"https://api.github.com/repos/kubernetes/dashboard/issues/492/events","html_url":"https://github.com/kubernetes/dashboard/pull/492","id":138426458,"number":492,"title":"Label Key validation on Deploy page","user":{"login":"digitalfishpond","id":13361549,"avatar_url":"https://avatars.githubusercontent.com/u/13361549?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalfishpond","html_url":"https://github.com/digitalfishpond","followers_url":"https://api.github.com/users/digitalfishpond/followers","following_url":"https://api.github.com/users/digitalfishpond/following{/other_user}","gists_url":"https://api.github.com/users/digitalfishpond/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalfishpond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalfishpond/subscriptions","organizations_url":"https://api.github.com/users/digitalfishpond/orgs","repos_url":"https://api.github.com/users/digitalfishpond/repos","events_url":"https://api.github.com/users/digitalfishpond/events{/privacy}","received_events_url":"https://api.github.com/users/digitalfishpond/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/dashboard/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-03-04T09:29:04Z","updated_at":"2016-03-04T12:28:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/dashboard/pulls/492","html_url":"https://github.com/kubernetes/dashboard/pull/492","diff_url":"https://github.com/kubernetes/dashboard/pull/492.diff","patch_url":"https://github.com/kubernetes/dashboard/pull/492.patch"},"body":"Validation on Deploy Page: Labels -> Label Key\r\nseparate validation for pattern of prefix (before forward slash if there is one) and name (after forward slash if there is one present, or entire string if not), and for string length of each.\r\nOnly one slash is permitted (consistent with backend validation)\r\n\r\nvalidation for 'value' will be in a separate PR.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/kubernetes/dashboard/492)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/dashboard/issues/comments/192260601","html_url":"https://github.com/kubernetes/dashboard/pull/492#issuecomment-192260601","issue_url":"https://api.github.com/repos/kubernetes/dashboard/issues/492","id":192260601,"user":{"login":"digitalfishpond","id":13361549,"avatar_url":"https://avatars.githubusercontent.com/u/13361549?v=3","gravatar_id":"","url":"https://api.github.com/users/digitalfishpond","html_url":"https://github.com/digitalfishpond","followers_url":"https://api.github.com/users/digitalfishpond/followers","following_url":"https://api.github.com/users/digitalfishpond/following{/other_user}","gists_url":"https://api.github.com/users/digitalfishpond/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalfishpond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalfishpond/subscriptions","organizations_url":"https://api.github.com/users/digitalfishpond/orgs","repos_url":"https://api.github.com/users/digitalfishpond/repos","events_url":"https://api.github.com/users/digitalfishpond/events{/privacy}","received_events_url":"https://api.github.com/users/digitalfishpond/received_events","type":"User","site_admin":false},"created_at":"2016-03-04T12:28:44Z","updated_at":"2016-03-04T12:28:44Z","body":"\n\n\n\n\n\n\n\n*[src/app/frontend/deploy/deploylabel_controller.js, line 100 \\[r1\\]](https://reviewable.io:443/reviews/kubernetes/dashboard/492#-KC0DnD8Ls7eBHsCEnCP:-KC0Zt7LTBMQgIiWqcK4:311517096) ([raw file](https://github.com/kubernetes/dashboard/blob/8a72a4d10e0f8082eae3fc888f94042d855e842b/src/app/frontend/deploy/deploylabel_controller.js#L100)):*\n@bryk label key validation now has five distinct parts (each with separate messages) and some depend on shared values (such as whether the string contains a slash or not). Refactoring this code to directive would require five new directives (each related to a different message in the html) and a proper tangle of shared values... should I get started? Or shall I add a TODO so that I can have a chance to sort out validation for Label Value in time for Monday?\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/kubernetes/dashboard/492)*\n<!-- Sent from Reviewable.io -->\n"}}