{"action":"created","comment":{"url":"https://api.github.com/repos/MeanfishLtd/errantry/pulls/comments/70587484","id":70587484,"diff_hunk":"@@ -16,9 +18,18 @@ import DialogueGraphEditor from \"./DialogueGraphEditor\";\n import * as DialogueTab from \"~/schema/workspace/DialogueTab\";\n import * as presentation from \"./DialogueEditor.presentation\";\n \n-import { DIALOGUE_LINE, DIALOGUE_PATH, DIALOGUE_MULTIPLE, DIALOGUE_CHOICE, DIALOGUE_CONDITIONAL }\n+import { DIALOGUE_LINE, DIALOGUE_MULTIPLE, DIALOGUE_CHOICE, DIALOGUE_CONDITIONAL }\n     from \"~/schema/project/DialogueType\";\n \n+// Utility functions for inspecting the types' supported fields\n+function typeCanHaveActor (type) { return type === DIALOGUE_LINE; }\n+function typeCanHaveConditionals (type) { return type === DIALOGUE_LINE; }\n+function typeCanHaveConditions (type) {\n+  return type === DIALOGUE_CHOICE || type === DIALOGUE_CONDITIONAL;\n+}\n+function typeCanHaveChoices (type) { return type === DIALOGUE_MULTIPLE; }\n+function typeCanHaveLine (type) { return type && type !== DIALOGUE_CHOICE; }","path":"src/editor/app/route/Main/editor/DialogueEditor.js","position":24,"original_position":24,"commit_id":"b2b1d62ecf6c3f08a42482f396747bc0c514ee3b","original_commit_id":"b2b1d62ecf6c3f08a42482f396747bc0c514ee3b","user":{"login":"iridiankin","id":16244827,"avatar_url":"https://avatars.githubusercontent.com/u/16244827?v=3","gravatar_id":"","url":"https://api.github.com/users/iridiankin","html_url":"https://github.com/iridiankin","followers_url":"https://api.github.com/users/iridiankin/followers","following_url":"https://api.github.com/users/iridiankin/following{/other_user}","gists_url":"https://api.github.com/users/iridiankin/gists{/gist_id}","starred_url":"https://api.github.com/users/iridiankin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iridiankin/subscriptions","organizations_url":"https://api.github.com/users/iridiankin/orgs","repos_url":"https://api.github.com/users/iridiankin/repos","events_url":"https://api.github.com/users/iridiankin/events{/privacy}","received_events_url":"https://api.github.com/users/iridiankin/received_events","type":"User","site_admin":false},"body":"should be type && (type !== DIALOGUE_CHOICE), as it is, this is parsed as (type && type) !== DIALOGUE_CHOICE which is the same as type !== DIALOGUE_CHOICE ","created_at":"2016-07-13T08:54:22Z","updated_at":"2016-07-13T08:54:22Z","html_url":"https://github.com/MeanfishLtd/errantry/pull/40#discussion_r70587484","pull_request_url":"https://api.github.com/repos/MeanfishLtd/errantry/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/MeanfishLtd/errantry/pulls/comments/70587484"},"html":{"href":"https://github.com/MeanfishLtd/errantry/pull/40#discussion_r70587484"},"pull_request":{"href":"https://api.github.com/repos/MeanfishLtd/errantry/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/MeanfishLtd/errantry/pulls/40","id":76942410,"html_url":"https://github.com/MeanfishLtd/errantry/pull/40","diff_url":"https://github.com/MeanfishLtd/errantry/pull/40.diff","patch_url":"https://github.com/MeanfishLtd/errantry/pull/40.patch","issue_url":"https://api.github.com/repos/MeanfishLtd/errantry/issues/40","number":40,"state":"open","locked":false,"title":"Feature/dialogue editor improvements 2","user":{"login":"shundread","id":2118109,"avatar_url":"https://avatars.githubusercontent.com/u/2118109?v=3","gravatar_id":"","url":"https://api.github.com/users/shundread","html_url":"https://github.com/shundread","followers_url":"https://api.github.com/users/shundread/followers","following_url":"https://api.github.com/users/shundread/following{/other_user}","gists_url":"https://api.github.com/users/shundread/gists{/gist_id}","starred_url":"https://api.github.com/users/shundread/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shundread/subscriptions","organizations_url":"https://api.github.com/users/shundread/orgs","repos_url":"https://api.github.com/users/shundread/repos","events_url":"https://api.github.com/users/shundread/events{/privacy}","received_events_url":"https://api.github.com/users/shundread/received_events","type":"User","site_admin":false},"body":"This branch does some polishing of the dialogue editor, by making sure only meaningful fields are ever displayed in the properties tab, clearer strings in the UI, fixing an instance of absent string and improperly set style and improvement of list-based dialogue tabs by providing clear separation between different items so there's no confusion as to where does one item end and the next one begin.","created_at":"2016-07-11T12:05:26Z","updated_at":"2016-07-13T08:54:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1827b6d689a5b9e5debb067bff5c0afacdbf9a3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MeanfishLtd/errantry/pulls/40/commits","review_comments_url":"https://api.github.com/repos/MeanfishLtd/errantry/pulls/40/comments","review_comment_url":"https://api.github.com/repos/MeanfishLtd/errantry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MeanfishLtd/errantry/issues/40/comments","statuses_url":"https://api.github.com/repos/MeanfishLtd/errantry/statuses/b2b1d62ecf6c3f08a42482f396747bc0c514ee3b","head":{"label":"MeanfishLtd:feature/dialogue_editor_improvements_2","ref":"feature/dialogue_editor_improvements_2","sha":"b2b1d62ecf6c3f08a42482f396747bc0c514ee3b","user":{"login":"MeanfishLtd","id":14345951,"avatar_url":"https://avatars.githubusercontent.com/u/14345951?v=3","gravatar_id":"","url":"https://api.github.com/users/MeanfishLtd","html_url":"https://github.com/MeanfishLtd","followers_url":"https://api.github.com/users/MeanfishLtd/followers","following_url":"https://api.github.com/users/MeanfishLtd/following{/other_user}","gists_url":"https://api.github.com/users/MeanfishLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/MeanfishLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeanfishLtd/subscriptions","organizations_url":"https://api.github.com/users/MeanfishLtd/orgs","repos_url":"https://api.github.com/users/MeanfishLtd/repos","events_url":"https://api.github.com/users/MeanfishLtd/events{/privacy}","received_events_url":"https://api.github.com/users/MeanfishLtd/received_events","type":"Organization","site_admin":false},"repo":{"id":50299885,"name":"errantry","full_name":"MeanfishLtd/errantry","owner":{"login":"MeanfishLtd","id":14345951,"avatar_url":"https://avatars.githubusercontent.com/u/14345951?v=3","gravatar_id":"","url":"https://api.github.com/users/MeanfishLtd","html_url":"https://github.com/MeanfishLtd","followers_url":"https://api.github.com/users/MeanfishLtd/followers","following_url":"https://api.github.com/users/MeanfishLtd/following{/other_user}","gists_url":"https://api.github.com/users/MeanfishLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/MeanfishLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeanfishLtd/subscriptions","organizations_url":"https://api.github.com/users/MeanfishLtd/orgs","repos_url":"https://api.github.com/users/MeanfishLtd/repos","events_url":"https://api.github.com/users/MeanfishLtd/events{/privacy}","received_events_url":"https://api.github.com/users/MeanfishLtd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MeanfishLtd/errantry","description":"Old version of the Errantry Editor","fork":false,"url":"https://api.github.com/repos/MeanfishLtd/errantry","forks_url":"https://api.github.com/repos/MeanfishLtd/errantry/forks","keys_url":"https://api.github.com/repos/MeanfishLtd/errantry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MeanfishLtd/errantry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MeanfishLtd/errantry/teams","hooks_url":"https://api.github.com/repos/MeanfishLtd/errantry/hooks","issue_events_url":"https://api.github.com/repos/MeanfishLtd/errantry/issues/events{/number}","events_url":"https://api.github.com/repos/MeanfishLtd/errantry/events","assignees_url":"https://api.github.com/repos/MeanfishLtd/errantry/assignees{/user}","branches_url":"https://api.github.com/repos/MeanfishLtd/errantry/branches{/branch}","tags_url":"https://api.github.com/repos/MeanfishLtd/errantry/tags","blobs_url":"https://api.github.com/repos/MeanfishLtd/errantry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MeanfishLtd/errantry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MeanfishLtd/errantry/git/refs{/sha}","trees_url":"https://api.github.com/repos/MeanfishLtd/errantry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MeanfishLtd/errantry/statuses/{sha}","languages_url":"https://api.github.com/repos/MeanfishLtd/errantry/languages","stargazers_url":"https://api.github.com/repos/MeanfishLtd/errantry/stargazers","contributors_url":"https://api.github.com/repos/MeanfishLtd/errantry/contributors","subscribers_url":"https://api.github.com/repos/MeanfishLtd/errantry/subscribers","subscription_url":"https://api.github.com/repos/MeanfishLtd/errantry/subscription","commits_url":"https://api.github.com/repos/MeanfishLtd/errantry/commits{/sha}","git_commits_url":"https://api.github.com/repos/MeanfishLtd/errantry/git/commits{/sha}","comments_url":"https://api.github.com/repos/MeanfishLtd/errantry/comments{/number}","issue_comment_url":"https://api.github.com/repos/MeanfishLtd/errantry/issues/comments{/number}","contents_url":"https://api.github.com/repos/MeanfishLtd/errantry/contents/{+path}","compare_url":"https://api.github.com/repos/MeanfishLtd/errantry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MeanfishLtd/errantry/merges","archive_url":"https://api.github.com/repos/MeanfishLtd/errantry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MeanfishLtd/errantry/downloads","issues_url":"https://api.github.com/repos/MeanfishLtd/errantry/issues{/number}","pulls_url":"https://api.github.com/repos/MeanfishLtd/errantry/pulls{/number}","milestones_url":"https://api.github.com/repos/MeanfishLtd/errantry/milestones{/number}","notifications_url":"https://api.github.com/repos/MeanfishLtd/errantry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MeanfishLtd/errantry/labels{/name}","releases_url":"https://api.github.com/repos/MeanfishLtd/errantry/releases{/id}","deployments_url":"https://api.github.com/repos/MeanfishLtd/errantry/deployments","created_at":"2016-01-24T17:55:08Z","updated_at":"2016-05-16T11:36:53Z","pushed_at":"2016-07-13T08:03:16Z","git_url":"git://github.com/MeanfishLtd/errantry.git","ssh_url":"git@github.com:MeanfishLtd/errantry.git","clone_url":"https://github.com/MeanfishLtd/errantry.git","svn_url":"https://github.com/MeanfishLtd/errantry","homepage":null,"size":99829,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"MeanfishLtd:valaa","ref":"valaa","sha":"5d9d36dd030c1658ada42dd193336cd6871e31df","user":{"login":"MeanfishLtd","id":14345951,"avatar_url":"https://avatars.githubusercontent.com/u/14345951?v=3","gravatar_id":"","url":"https://api.github.com/users/MeanfishLtd","html_url":"https://github.com/MeanfishLtd","followers_url":"https://api.github.com/users/MeanfishLtd/followers","following_url":"https://api.github.com/users/MeanfishLtd/following{/other_user}","gists_url":"https://api.github.com/users/MeanfishLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/MeanfishLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeanfishLtd/subscriptions","organizations_url":"https://api.github.com/users/MeanfishLtd/orgs","repos_url":"https://api.github.com/users/MeanfishLtd/repos","events_url":"https://api.github.com/users/MeanfishLtd/events{/privacy}","received_events_url":"https://api.github.com/users/MeanfishLtd/received_events","type":"Organization","site_admin":false},"repo":{"id":50299885,"name":"errantry","full_name":"MeanfishLtd/errantry","owner":{"login":"MeanfishLtd","id":14345951,"avatar_url":"https://avatars.githubusercontent.com/u/14345951?v=3","gravatar_id":"","url":"https://api.github.com/users/MeanfishLtd","html_url":"https://github.com/MeanfishLtd","followers_url":"https://api.github.com/users/MeanfishLtd/followers","following_url":"https://api.github.com/users/MeanfishLtd/following{/other_user}","gists_url":"https://api.github.com/users/MeanfishLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/MeanfishLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeanfishLtd/subscriptions","organizations_url":"https://api.github.com/users/MeanfishLtd/orgs","repos_url":"https://api.github.com/users/MeanfishLtd/repos","events_url":"https://api.github.com/users/MeanfishLtd/events{/privacy}","received_events_url":"https://api.github.com/users/MeanfishLtd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MeanfishLtd/errantry","description":"Old version of the Errantry Editor","fork":false,"url":"https://api.github.com/repos/MeanfishLtd/errantry","forks_url":"https://api.github.com/repos/MeanfishLtd/errantry/forks","keys_url":"https://api.github.com/repos/MeanfishLtd/errantry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MeanfishLtd/errantry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MeanfishLtd/errantry/teams","hooks_url":"https://api.github.com/repos/MeanfishLtd/errantry/hooks","issue_events_url":"https://api.github.com/repos/MeanfishLtd/errantry/issues/events{/number}","events_url":"https://api.github.com/repos/MeanfishLtd/errantry/events","assignees_url":"https://api.github.com/repos/MeanfishLtd/errantry/assignees{/user}","branches_url":"https://api.github.com/repos/MeanfishLtd/errantry/branches{/branch}","tags_url":"https://api.github.com/repos/MeanfishLtd/errantry/tags","blobs_url":"https://api.github.com/repos/MeanfishLtd/errantry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MeanfishLtd/errantry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MeanfishLtd/errantry/git/refs{/sha}","trees_url":"https://api.github.com/repos/MeanfishLtd/errantry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MeanfishLtd/errantry/statuses/{sha}","languages_url":"https://api.github.com/repos/MeanfishLtd/errantry/languages","stargazers_url":"https://api.github.com/repos/MeanfishLtd/errantry/stargazers","contributors_url":"https://api.github.com/repos/MeanfishLtd/errantry/contributors","subscribers_url":"https://api.github.com/repos/MeanfishLtd/errantry/subscribers","subscription_url":"https://api.github.com/repos/MeanfishLtd/errantry/subscription","commits_url":"https://api.github.com/repos/MeanfishLtd/errantry/commits{/sha}","git_commits_url":"https://api.github.com/repos/MeanfishLtd/errantry/git/commits{/sha}","comments_url":"https://api.github.com/repos/MeanfishLtd/errantry/comments{/number}","issue_comment_url":"https://api.github.com/repos/MeanfishLtd/errantry/issues/comments{/number}","contents_url":"https://api.github.com/repos/MeanfishLtd/errantry/contents/{+path}","compare_url":"https://api.github.com/repos/MeanfishLtd/errantry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MeanfishLtd/errantry/merges","archive_url":"https://api.github.com/repos/MeanfishLtd/errantry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MeanfishLtd/errantry/downloads","issues_url":"https://api.github.com/repos/MeanfishLtd/errantry/issues{/number}","pulls_url":"https://api.github.com/repos/MeanfishLtd/errantry/pulls{/number}","milestones_url":"https://api.github.com/repos/MeanfishLtd/errantry/milestones{/number}","notifications_url":"https://api.github.com/repos/MeanfishLtd/errantry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MeanfishLtd/errantry/labels{/name}","releases_url":"https://api.github.com/repos/MeanfishLtd/errantry/releases{/id}","deployments_url":"https://api.github.com/repos/MeanfishLtd/errantry/deployments","created_at":"2016-01-24T17:55:08Z","updated_at":"2016-05-16T11:36:53Z","pushed_at":"2016-07-13T08:03:16Z","git_url":"git://github.com/MeanfishLtd/errantry.git","ssh_url":"git@github.com:MeanfishLtd/errantry.git","clone_url":"https://github.com/MeanfishLtd/errantry.git","svn_url":"https://github.com/MeanfishLtd/errantry","homepage":null,"size":99829,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MeanfishLtd/errantry/pulls/40"},"html":{"href":"https://github.com/MeanfishLtd/errantry/pull/40"},"issue":{"href":"https://api.github.com/repos/MeanfishLtd/errantry/issues/40"},"comments":{"href":"https://api.github.com/repos/MeanfishLtd/errantry/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/MeanfishLtd/errantry/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/MeanfishLtd/errantry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MeanfishLtd/errantry/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/MeanfishLtd/errantry/statuses/b2b1d62ecf6c3f08a42482f396747bc0c514ee3b"}}}}
{"actor":{"display_login":"iridiankin"}}