{"action":"created","issue":{"url":"https://api.github.com/repos/chipKIT32/chipKIT-core/issues/298","repository_url":"https://api.github.com/repos/chipKIT32/chipKIT-core","labels_url":"https://api.github.com/repos/chipKIT32/chipKIT-core/issues/298/labels{/name}","comments_url":"https://api.github.com/repos/chipKIT32/chipKIT-core/issues/298/comments","events_url":"https://api.github.com/repos/chipKIT32/chipKIT-core/issues/298/events","html_url":"https://github.com/chipKIT32/chipKIT-core/pull/298","id":189555199,"number":298,"title":"Add missing pin definitions for Change Notify","user":{"login":"eric-wieser","id":425260,"avatar_url":"https://avatars.githubusercontent.com/u/425260?v=3","gravatar_id":"","url":"https://api.github.com/users/eric-wieser","html_url":"https://github.com/eric-wieser","followers_url":"https://api.github.com/users/eric-wieser/followers","following_url":"https://api.github.com/users/eric-wieser/following{/other_user}","gists_url":"https://api.github.com/users/eric-wieser/gists{/gist_id}","starred_url":"https://api.github.com/users/eric-wieser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eric-wieser/subscriptions","organizations_url":"https://api.github.com/users/eric-wieser/orgs","repos_url":"https://api.github.com/users/eric-wieser/repos","events_url":"https://api.github.com/users/eric-wieser/events{/privacy}","received_events_url":"https://api.github.com/users/eric-wieser/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-11-16T01:15:03Z","updated_at":"2016-11-17T09:16:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chipKIT32/chipKIT-core/pulls/298","html_url":"https://github.com/chipKIT32/chipKIT-core/pull/298","diff_url":"https://github.com/chipKIT32/chipKIT-core/pull/298.diff","patch_url":"https://github.com/chipKIT32/chipKIT-core/pull/298.patch"},"body":"Added from the datasheet"},"comment":{"url":"https://api.github.com/repos/chipKIT32/chipKIT-core/issues/comments/261194688","html_url":"https://github.com/chipKIT32/chipKIT-core/pull/298#issuecomment-261194688","issue_url":"https://api.github.com/repos/chipKIT32/chipKIT-core/issues/298","id":261194688,"user":{"login":"majenkotech","id":3812892,"avatar_url":"https://avatars.githubusercontent.com/u/3812892?v=3","gravatar_id":"","url":"https://api.github.com/users/majenkotech","html_url":"https://github.com/majenkotech","followers_url":"https://api.github.com/users/majenkotech/followers","following_url":"https://api.github.com/users/majenkotech/following{/other_user}","gists_url":"https://api.github.com/users/majenkotech/gists{/gist_id}","starred_url":"https://api.github.com/users/majenkotech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majenkotech/subscriptions","organizations_url":"https://api.github.com/users/majenkotech/orgs","repos_url":"https://api.github.com/users/majenkotech/repos","events_url":"https://api.github.com/users/majenkotech/events{/privacy}","received_events_url":"https://api.github.com/users/majenkotech/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T09:16:47Z","updated_at":"2016-11-17T09:16:47Z","body":"Base addresses only make any kind of logical sense when there are multiple identical blocks of registers doing the same job for multiple peripherals. Since that is not the case with change notification, where there is only one set of registers for the entire system, and that set is the same on all non PPS chips, where is the benefit of having base address macros? Where is the sense in offering a choice of one? Just use the address of cncon if you really must abstract it with a struct. Personally I think that struct is pointless, since the idea behind the structs is they give you an easy interface to abstracted items defined by the board definition. There is nothing defined by the board definition, so the structs is not needed. You can just directly use the registers, or the pre existing \"Bits\" structs.\r\n\r\n"}}
{"actor":{"display_login":"majenkotech"}}