{"action":"created","comment":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments/58254128","id":58254128,"diff_hunk":"@@ -980,6 +980,32 @@ public function testUpdateLocationStructValues(array $data)\n      *\n      * @see \\eZ\\Publish\\API\\Repository\\LocationService::updateLocation()\n      * @depends eZ\\Publish\\API\\Repository\\Tests\\LocationServiceTest::testLoadLocation\n+     */\n+    public function testUpdateLocationWithSameRemoteId()\n+    {\n+        $repository = $this->getRepository();\n+\n+        $locationId = $this->generateId('location', 5);\n+        /* BEGIN: Use Case */\n+        // $locationId and remote ID is the IDs of the same, existing location\n+        $locationService = $repository->getLocationService();\n+\n+        $originalLocation = $locationService->loadLocation($locationId);\n+\n+        $updateStruct = $locationService->newLocationUpdateStruct();\n+\n+        // Remote ID of an existing location with the same locationId\n+        $updateStruct->remoteId = '3f6d92f8044aed134f32153517850f5a';\n+\n+        $locationService->updateLocation($originalLocation, $updateStruct);","path":"eZ/Publish/API/Repository/Tests/LocationServiceTest.php","position":21,"original_position":21,"commit_id":"ca752a78b534907739642c4c687cad8b6e6321bc","original_commit_id":"ca752a78b534907739642c4c687cad8b6e6321bc","user":{"login":"emodric","id":362286,"avatar_url":"https://avatars.githubusercontent.com/u/362286?v=3","gravatar_id":"","url":"https://api.github.com/users/emodric","html_url":"https://github.com/emodric","followers_url":"https://api.github.com/users/emodric/followers","following_url":"https://api.github.com/users/emodric/following{/other_user}","gists_url":"https://api.github.com/users/emodric/gists{/gist_id}","starred_url":"https://api.github.com/users/emodric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emodric/subscriptions","organizations_url":"https://api.github.com/users/emodric/orgs","repos_url":"https://api.github.com/users/emodric/repos","events_url":"https://api.github.com/users/emodric/events{/privacy}","received_events_url":"https://api.github.com/users/emodric/received_events","type":"User","site_admin":false},"body":"Shouldn't we assert here that we got the updated location?","created_at":"2016-04-01T19:16:53Z","updated_at":"2016-04-01T19:16:53Z","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1631#discussion_r58254128","pull_request_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1631","_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments/58254128"},"html":{"href":"https://github.com/ezsystems/ezpublish-kernel/pull/1631#discussion_r58254128"},"pull_request":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1631"}}},"pull_request":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1631","id":64961030,"html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1631","diff_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1631.diff","patch_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1631.patch","issue_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1631","number":1631,"state":"open","locked":false,"title":"EZP-25648: Allow location update with same remoteId","user":{"login":"htollefsen","id":3762720,"avatar_url":"https://avatars.githubusercontent.com/u/3762720?v=3","gravatar_id":"","url":"https://api.github.com/users/htollefsen","html_url":"https://github.com/htollefsen","followers_url":"https://api.github.com/users/htollefsen/followers","following_url":"https://api.github.com/users/htollefsen/following{/other_user}","gists_url":"https://api.github.com/users/htollefsen/gists{/gist_id}","starred_url":"https://api.github.com/users/htollefsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htollefsen/subscriptions","organizations_url":"https://api.github.com/users/htollefsen/orgs","repos_url":"https://api.github.com/users/htollefsen/repos","events_url":"https://api.github.com/users/htollefsen/events{/privacy}","received_events_url":"https://api.github.com/users/htollefsen/received_events","type":"User","site_admin":false},"body":"Issue: https://jira.ez.no/browse/EZP-25648\r\n\r\nShould be allowed to update a location with the same remote id, as it won't produce a duplicate.\r\n","created_at":"2016-04-01T15:21:56Z","updated_at":"2016-04-01T19:16:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2daba4d2f2d3dc7b503a9a6a272a8048c08c2148","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1631/commits","review_comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1631/comments","review_comment_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1631/comments","statuses_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/statuses/ca752a78b534907739642c4c687cad8b6e6321bc","head":{"label":"htollefsen:master","ref":"master","sha":"ca752a78b534907739642c4c687cad8b6e6321bc","user":{"login":"htollefsen","id":3762720,"avatar_url":"https://avatars.githubusercontent.com/u/3762720?v=3","gravatar_id":"","url":"https://api.github.com/users/htollefsen","html_url":"https://github.com/htollefsen","followers_url":"https://api.github.com/users/htollefsen/followers","following_url":"https://api.github.com/users/htollefsen/following{/other_user}","gists_url":"https://api.github.com/users/htollefsen/gists{/gist_id}","starred_url":"https://api.github.com/users/htollefsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htollefsen/subscriptions","organizations_url":"https://api.github.com/users/htollefsen/orgs","repos_url":"https://api.github.com/users/htollefsen/repos","events_url":"https://api.github.com/users/htollefsen/events{/privacy}","received_events_url":"https://api.github.com/users/htollefsen/received_events","type":"User","site_admin":false},"repo":{"id":55241656,"name":"ezpublish-kernel","full_name":"htollefsen/ezpublish-kernel","owner":{"login":"htollefsen","id":3762720,"avatar_url":"https://avatars.githubusercontent.com/u/3762720?v=3","gravatar_id":"","url":"https://api.github.com/users/htollefsen","html_url":"https://github.com/htollefsen","followers_url":"https://api.github.com/users/htollefsen/followers","following_url":"https://api.github.com/users/htollefsen/following{/other_user}","gists_url":"https://api.github.com/users/htollefsen/gists{/gist_id}","starred_url":"https://api.github.com/users/htollefsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htollefsen/subscriptions","organizations_url":"https://api.github.com/users/htollefsen/orgs","repos_url":"https://api.github.com/users/htollefsen/repos","events_url":"https://api.github.com/users/htollefsen/events{/privacy}","received_events_url":"https://api.github.com/users/htollefsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/htollefsen/ezpublish-kernel","description":"eZ Platform (aka eZ Publish 6.x) kernel","fork":true,"url":"https://api.github.com/repos/htollefsen/ezpublish-kernel","forks_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/forks","keys_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/teams","hooks_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/hooks","issue_events_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/issues/events{/number}","events_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/events","assignees_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/assignees{/user}","branches_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/branches{/branch}","tags_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/tags","blobs_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/languages","stargazers_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/stargazers","contributors_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/contributors","subscribers_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/subscribers","subscription_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/subscription","commits_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/contents/{+path}","compare_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/merges","archive_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/downloads","issues_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/issues{/number}","pulls_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/labels{/name}","releases_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/releases{/id}","deployments_url":"https://api.github.com/repos/htollefsen/ezpublish-kernel/deployments","created_at":"2016-04-01T15:19:03Z","updated_at":"2016-04-01T15:19:12Z","pushed_at":"2016-04-01T17:05:18Z","git_url":"git://github.com/htollefsen/ezpublish-kernel.git","ssh_url":"git@github.com:htollefsen/ezpublish-kernel.git","clone_url":"https://github.com/htollefsen/ezpublish-kernel.git","svn_url":"https://github.com/htollefsen/ezpublish-kernel","homepage":"http://ezplatform.com/","size":44260,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ezsystems:master","ref":"master","sha":"4ea37e8265e1e2244e56cbb7bbd31271c7db956c","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":1663890,"name":"ezpublish-kernel","full_name":"ezsystems/ezpublish-kernel","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/ezpublish-kernel","description":"eZ Platform (aka eZ Publish 6.x) kernel","fork":false,"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel","forks_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/forks","keys_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/teams","hooks_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/events","assignees_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/tags","blobs_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/languages","stargazers_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/subscription","commits_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/merges","archive_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/downloads","issues_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/releases{/id}","deployments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/deployments","created_at":"2011-04-26T08:54:24Z","updated_at":"2016-02-24T10:32:27Z","pushed_at":"2016-04-01T17:05:20Z","git_url":"git://github.com/ezsystems/ezpublish-kernel.git","ssh_url":"git@github.com:ezsystems/ezpublish-kernel.git","clone_url":"https://github.com/ezsystems/ezpublish-kernel.git","svn_url":"https://github.com/ezsystems/ezpublish-kernel","homepage":"http://ezplatform.com/","size":48845,"stargazers_count":111,"watchers_count":111,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":144,"mirror_url":null,"open_issues_count":69,"forks":144,"open_issues":69,"watchers":111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1631"},"html":{"href":"https://github.com/ezsystems/ezpublish-kernel/pull/1631"},"issue":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1631"},"comments":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1631/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1631/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1631/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/statuses/ca752a78b534907739642c4c687cad8b6e6321bc"}}}}