{"action":"created","comment":{"url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/comments/61540722","id":61540722,"diff_hunk":"@@ -289,6 +289,7 @@ def build_vm_xml(vm_name, **dargs):\n                 if cpu_topology:\n                     cpuxml.topology = cpu_topology\n                 vmxml.cpu = cpuxml\n+                vmxml[\"vcpu\"] = int(params.get(\"vcpus_nums\"))","path":"libvirt/tests/src/virsh_cmd/domain/virsh_managedsave.py","position":4,"original_position":4,"commit_id":"ba8d4e95958e6c01294b1fdd111ce9e438c79c85","original_commit_id":"ba8d4e95958e6c01294b1fdd111ce9e438c79c85","user":{"login":"crazyAxe","id":17571510,"avatar_url":"https://avatars.githubusercontent.com/u/17571510?v=3","gravatar_id":"","url":"https://api.github.com/users/crazyAxe","html_url":"https://github.com/crazyAxe","followers_url":"https://api.github.com/users/crazyAxe/followers","following_url":"https://api.github.com/users/crazyAxe/following{/other_user}","gists_url":"https://api.github.com/users/crazyAxe/gists{/gist_id}","starred_url":"https://api.github.com/users/crazyAxe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crazyAxe/subscriptions","organizations_url":"https://api.github.com/users/crazyAxe/orgs","repos_url":"https://api.github.com/users/crazyAxe/repos","events_url":"https://api.github.com/users/crazyAxe/events{/privacy}","received_events_url":"https://api.github.com/users/crazyAxe/received_events","type":"User","site_admin":false},"body":"'vmxml.vcpu'  is indeed better. Actually i just found the vmxml[\"vcpu\"] in function set_vm_vcpus to set the value ,  so used it here. I'll  improve it, thank. ","created_at":"2016-04-29T07:04:38Z","updated_at":"2016-04-29T07:04:38Z","html_url":"https://github.com/autotest/tp-libvirt/pull/771#discussion_r61540722","pull_request_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/771","_links":{"self":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/comments/61540722"},"html":{"href":"https://github.com/autotest/tp-libvirt/pull/771#discussion_r61540722"},"pull_request":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/771"}}},"pull_request":{"url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/771","id":68001987,"html_url":"https://github.com/autotest/tp-libvirt/pull/771","diff_url":"https://github.com/autotest/tp-libvirt/pull/771.diff","patch_url":"https://github.com/autotest/tp-libvirt/pull/771.patch","issue_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/771","number":771,"state":"open","locked":false,"title":"managedsave: add expected vcpus for cpu_mode test","user":{"login":"crazyAxe","id":17571510,"avatar_url":"https://avatars.githubusercontent.com/u/17571510?v=3","gravatar_id":"","url":"https://api.github.com/users/crazyAxe","html_url":"https://github.com/crazyAxe","followers_url":"https://api.github.com/users/crazyAxe/followers","following_url":"https://api.github.com/users/crazyAxe/following{/other_user}","gists_url":"https://api.github.com/users/crazyAxe/gists{/gist_id}","starred_url":"https://api.github.com/users/crazyAxe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crazyAxe/subscriptions","organizations_url":"https://api.github.com/users/crazyAxe/orgs","repos_url":"https://api.github.com/users/crazyAxe/repos","events_url":"https://api.github.com/users/crazyAxe/events{/privacy}","received_events_url":"https://api.github.com/users/crazyAxe/received_events","type":"User","site_admin":false},"body":"the amount of vcpus should be equal or more than (sockets * cores * threads)","created_at":"2016-04-27T06:15:25Z","updated_at":"2016-04-29T07:04:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfa04c955567d6566cd0c3cee301f2d93c059c8b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/771/commits","review_comments_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/771/comments","review_comment_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/771/comments","statuses_url":"https://api.github.com/repos/autotest/tp-libvirt/statuses/ba8d4e95958e6c01294b1fdd111ce9e438c79c85","head":{"label":"crazyAxe:master","ref":"master","sha":"ba8d4e95958e6c01294b1fdd111ce9e438c79c85","user":{"login":"crazyAxe","id":17571510,"avatar_url":"https://avatars.githubusercontent.com/u/17571510?v=3","gravatar_id":"","url":"https://api.github.com/users/crazyAxe","html_url":"https://github.com/crazyAxe","followers_url":"https://api.github.com/users/crazyAxe/followers","following_url":"https://api.github.com/users/crazyAxe/following{/other_user}","gists_url":"https://api.github.com/users/crazyAxe/gists{/gist_id}","starred_url":"https://api.github.com/users/crazyAxe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crazyAxe/subscriptions","organizations_url":"https://api.github.com/users/crazyAxe/orgs","repos_url":"https://api.github.com/users/crazyAxe/repos","events_url":"https://api.github.com/users/crazyAxe/events{/privacy}","received_events_url":"https://api.github.com/users/crazyAxe/received_events","type":"User","site_admin":false},"repo":{"id":57011744,"name":"tp-libvirt","full_name":"crazyAxe/tp-libvirt","owner":{"login":"crazyAxe","id":17571510,"avatar_url":"https://avatars.githubusercontent.com/u/17571510?v=3","gravatar_id":"","url":"https://api.github.com/users/crazyAxe","html_url":"https://github.com/crazyAxe","followers_url":"https://api.github.com/users/crazyAxe/followers","following_url":"https://api.github.com/users/crazyAxe/following{/other_user}","gists_url":"https://api.github.com/users/crazyAxe/gists{/gist_id}","starred_url":"https://api.github.com/users/crazyAxe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crazyAxe/subscriptions","organizations_url":"https://api.github.com/users/crazyAxe/orgs","repos_url":"https://api.github.com/users/crazyAxe/repos","events_url":"https://api.github.com/users/crazyAxe/events{/privacy}","received_events_url":"https://api.github.com/users/crazyAxe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crazyAxe/tp-libvirt","description":"Test Provider for Libvirt and related virtualization backends","fork":true,"url":"https://api.github.com/repos/crazyAxe/tp-libvirt","forks_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/forks","keys_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/teams","hooks_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/hooks","issue_events_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/issues/events{/number}","events_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/events","assignees_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/assignees{/user}","branches_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/branches{/branch}","tags_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/tags","blobs_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/statuses/{sha}","languages_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/languages","stargazers_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/stargazers","contributors_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/contributors","subscribers_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/subscribers","subscription_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/subscription","commits_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/contents/{+path}","compare_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/merges","archive_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/downloads","issues_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/issues{/number}","pulls_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/pulls{/number}","milestones_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/milestones{/number}","notifications_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/labels{/name}","releases_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/releases{/id}","deployments_url":"https://api.github.com/repos/crazyAxe/tp-libvirt/deployments","created_at":"2016-04-25T04:30:06Z","updated_at":"2016-04-25T04:30:09Z","pushed_at":"2016-04-27T05:50:00Z","git_url":"git://github.com/crazyAxe/tp-libvirt.git","ssh_url":"git@github.com:crazyAxe/tp-libvirt.git","clone_url":"https://github.com/crazyAxe/tp-libvirt.git","svn_url":"https://github.com/crazyAxe/tp-libvirt","homepage":null,"size":10398,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"autotest:master","ref":"master","sha":"bbd78fb0228106b69c5d6034807574bfacc608d5","user":{"login":"autotest","id":472856,"avatar_url":"https://avatars.githubusercontent.com/u/472856?v=3","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"repo":{"id":16180517,"name":"tp-libvirt","full_name":"autotest/tp-libvirt","owner":{"login":"autotest","id":472856,"avatar_url":"https://avatars.githubusercontent.com/u/472856?v=3","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/autotest/tp-libvirt","description":"Test Provider for Libvirt and related virtualization backends","fork":false,"url":"https://api.github.com/repos/autotest/tp-libvirt","forks_url":"https://api.github.com/repos/autotest/tp-libvirt/forks","keys_url":"https://api.github.com/repos/autotest/tp-libvirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autotest/tp-libvirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autotest/tp-libvirt/teams","hooks_url":"https://api.github.com/repos/autotest/tp-libvirt/hooks","issue_events_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/events{/number}","events_url":"https://api.github.com/repos/autotest/tp-libvirt/events","assignees_url":"https://api.github.com/repos/autotest/tp-libvirt/assignees{/user}","branches_url":"https://api.github.com/repos/autotest/tp-libvirt/branches{/branch}","tags_url":"https://api.github.com/repos/autotest/tp-libvirt/tags","blobs_url":"https://api.github.com/repos/autotest/tp-libvirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autotest/tp-libvirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autotest/tp-libvirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/autotest/tp-libvirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autotest/tp-libvirt/statuses/{sha}","languages_url":"https://api.github.com/repos/autotest/tp-libvirt/languages","stargazers_url":"https://api.github.com/repos/autotest/tp-libvirt/stargazers","contributors_url":"https://api.github.com/repos/autotest/tp-libvirt/contributors","subscribers_url":"https://api.github.com/repos/autotest/tp-libvirt/subscribers","subscription_url":"https://api.github.com/repos/autotest/tp-libvirt/subscription","commits_url":"https://api.github.com/repos/autotest/tp-libvirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/autotest/tp-libvirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/autotest/tp-libvirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/autotest/tp-libvirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/autotest/tp-libvirt/contents/{+path}","compare_url":"https://api.github.com/repos/autotest/tp-libvirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autotest/tp-libvirt/merges","archive_url":"https://api.github.com/repos/autotest/tp-libvirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autotest/tp-libvirt/downloads","issues_url":"https://api.github.com/repos/autotest/tp-libvirt/issues{/number}","pulls_url":"https://api.github.com/repos/autotest/tp-libvirt/pulls{/number}","milestones_url":"https://api.github.com/repos/autotest/tp-libvirt/milestones{/number}","notifications_url":"https://api.github.com/repos/autotest/tp-libvirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autotest/tp-libvirt/labels{/name}","releases_url":"https://api.github.com/repos/autotest/tp-libvirt/releases{/id}","deployments_url":"https://api.github.com/repos/autotest/tp-libvirt/deployments","created_at":"2014-01-23T17:58:18Z","updated_at":"2016-04-25T13:14:25Z","pushed_at":"2016-04-28T09:16:38Z","git_url":"git://github.com/autotest/tp-libvirt.git","ssh_url":"git@github.com:autotest/tp-libvirt.git","clone_url":"https://github.com/autotest/tp-libvirt.git","svn_url":"https://github.com/autotest/tp-libvirt","homepage":null,"size":11136,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":32,"forks":57,"open_issues":32,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/771"},"html":{"href":"https://github.com/autotest/tp-libvirt/pull/771"},"issue":{"href":"https://api.github.com/repos/autotest/tp-libvirt/issues/771"},"comments":{"href":"https://api.github.com/repos/autotest/tp-libvirt/issues/771/comments"},"review_comments":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/771/comments"},"review_comment":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/autotest/tp-libvirt/pulls/771/commits"},"statuses":{"href":"https://api.github.com/repos/autotest/tp-libvirt/statuses/ba8d4e95958e6c01294b1fdd111ce9e438c79c85"}}}}