{"action":"created","issue":{"url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/2417","repository_url":"https://api.github.com/repos/Valloric/YouCompleteMe","labels_url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/2417/labels{/name}","comments_url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/2417/comments","events_url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/2417/events","html_url":"https://github.com/Valloric/YouCompleteMe/pull/2417","id":186096630,"number":2417,"title":"[READY] install: refine ouput on error","user":{"login":"ngergo","id":5185941,"avatar_url":"https://avatars.githubusercontent.com/u/5185941?v=3","gravatar_id":"","url":"https://api.github.com/users/ngergo","html_url":"https://github.com/ngergo","followers_url":"https://api.github.com/users/ngergo/followers","following_url":"https://api.github.com/users/ngergo/following{/other_user}","gists_url":"https://api.github.com/users/ngergo/gists{/gist_id}","starred_url":"https://api.github.com/users/ngergo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngergo/subscriptions","organizations_url":"https://api.github.com/users/ngergo/orgs","repos_url":"https://api.github.com/users/ngergo/repos","events_url":"https://api.github.com/users/ngergo/events{/privacy}","received_events_url":"https://api.github.com/users/ngergo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-29T19:34:02Z","updated_at":"2016-10-29T19:45:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Valloric/YouCompleteMe/pulls/2417","html_url":"https://github.com/Valloric/YouCompleteMe/pull/2417","diff_url":"https://github.com/Valloric/YouCompleteMe/pull/2417.diff","patch_url":"https://github.com/Valloric/YouCompleteMe/pull/2417.patch"},"body":"# PR Prelude\r\n\r\nThank you for working on YCM! :)\r\n\r\n**Please complete these steps and check these boxes (by putting an `x` inside\r\nthe brackets) _before_ filing your PR:**\r\n\r\n- [x] I have read and understood YCM's [CONTRIBUTING][cont] document.\r\n- [x] I have read and understood YCM's [CODE_OF_CONDUCT][code] document.\r\n- [x] I have included tests for the changes in my PR. If not, I have included a\r\n  rationale for why I haven't.\r\n- [x] **I understand my PR may be closed if it becomes obvious I didn't\r\n  actually perform all of these steps.**\r\n\r\n# Why this change is necessary and useful\r\n\r\n[Please explain **in detail** why the changes in this PR are needed.]\r\n\r\n[cont]: https://github.com/Valloric/YouCompleteMe/blob/master/CONTRIBUTING.md\r\n[code]: https://github.com/Valloric/YouCompleteMe/blob/master/CODE_OF_CONDUCT.md\r\n\r\nBefore this patch a traceback was shown when subprocess call, that runs\r\n`build.py`, failed. The reason of the error is the output of the build\r\nscript rather the `CalledProcessError` exception that only shows\r\n`build.py` failed with a specific `python` version.\r\n\r\nThis modifications is intended to separate the output of the build\r\nprocess that gives the user a more specific reason of the error. And\r\nbelow that the command run.\r\n\r\nBefore:\r\n\r\n```\r\nPlease install CMake and retry.\r\nTraceback (most recent call last):\r\n  File \"install.py\", line 44, in <module>\r\n    Main()\r\n  File \"install.py\", line 33, in Main\r\n    subprocess.check_call( [ python_binary, build_file ] + sys.argv[1:] )\r\n  File \"/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py\", line 540, in check_call\r\n    raise CalledProcessError(retcode, cmd)\r\nsubprocess.CalledProcessError: Command '['path/to/python', u'path/to/build.py']' returned non-zero exit status 1\r\n```\r\n\r\nAfter:\r\n\r\n```\r\nBuilding ycmd using [path/to/build.py] with python binary at [path/to/python]:\r\nError message from build.py...\r\n\r\nException raised:\r\nCommand '['path/to/python', u'path/to/build.py']' returned non-zero exit status 1\r\n```\r\n\r\nSigned-off-by: Gergő Nagy <grigori.grant@gmail.com>\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/valloric/youcompleteme/2417)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/comments/257111940","html_url":"https://github.com/Valloric/YouCompleteMe/pull/2417#issuecomment-257111940","issue_url":"https://api.github.com/repos/Valloric/YouCompleteMe/issues/2417","id":257111940,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2016-10-29T19:45:56Z","updated_at":"2016-10-29T19:45:56Z","body":"## [Current coverage](https://codecov.io/gh/Valloric/YouCompleteMe/pull/2417?src=pr) is 81.13% (diff: 100%)\n> Merging [#2417](https://codecov.io/gh/Valloric/YouCompleteMe/pull/2417?src=pr) into [master](https://codecov.io/gh/Valloric/YouCompleteMe/branch/master?src=pr) will not change coverage\n\n```diff\n@@             master      #2417   diff @@\n==========================================\n  Files            17         17          \n  Lines          1871       1871          \n  Methods           0          0          \n  Messages          0          0          \n  Branches          0          0          \n==========================================\n  Hits           1518       1518          \n  Misses          353        353          \n  Partials          0          0          \n```\n\n\n\n> Powered by [Codecov](https://codecov.io?src=pr). Last update [c895f09...5de004c](https://codecov.io/gh/Valloric/YouCompleteMe/compare/c895f0937506250191d9eb80747561bbbb481ea0...5de004ccb8e288a87d0115974fe1c388341df42f?src=pr)"}}
{"actor":{"display_login":"codecov-io"}}