{"action":"created","issue":{"url":"https://api.github.com/repos/jserv/facebooc/issues/28","repository_url":"https://api.github.com/repos/jserv/facebooc","labels_url":"https://api.github.com/repos/jserv/facebooc/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/jserv/facebooc/issues/28/comments","events_url":"https://api.github.com/repos/jserv/facebooc/issues/28/events","html_url":"https://github.com/jserv/facebooc/pull/28","id":155009215,"number":28,"title":"Slightly optimize serverServe","user":{"login":"lecopzer","id":6748260,"avatar_url":"https://avatars.githubusercontent.com/u/6748260?v=3","gravatar_id":"","url":"https://api.github.com/users/lecopzer","html_url":"https://github.com/lecopzer","followers_url":"https://api.github.com/users/lecopzer/followers","following_url":"https://api.github.com/users/lecopzer/following{/other_user}","gists_url":"https://api.github.com/users/lecopzer/gists{/gist_id}","starred_url":"https://api.github.com/users/lecopzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lecopzer/subscriptions","organizations_url":"https://api.github.com/users/lecopzer/orgs","repos_url":"https://api.github.com/users/lecopzer/repos","events_url":"https://api.github.com/users/lecopzer/events{/privacy}","received_events_url":"https://api.github.com/users/lecopzer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-05-16T11:14:54Z","updated_at":"2016-05-16T14:17:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jserv/facebooc/pulls/28","html_url":"https://github.com/jserv/facebooc/pull/28","diff_url":"https://github.com/jserv/facebooc/pull/28.diff","patch_url":"https://github.com/jserv/facebooc/pull/28.patch"},"body":"Change control flow of `serverServe` \r\n\r\nIn previous, we always check all fd in for-loop FD_SETSIZE times\r\nBut actually we do not use such many fd, so we waste a lot of time in checking fd.\r\nFd  is always  bigger than previous, so `sock` should be smallest after `serverServe` \r\n\r\nAfter optimize, measure by perf record -F 25000\r\nClock percentage of `serverServe` reduces from 3% to 0.6%\r\nBut didn't obviously reduce execution time.  (GET 1000 times improve about 1% to equal)"},"comment":{"url":"https://api.github.com/repos/jserv/facebooc/issues/comments/219436248","html_url":"https://github.com/jserv/facebooc/pull/28#issuecomment-219436248","issue_url":"https://api.github.com/repos/jserv/facebooc/issues/28","id":219436248,"user":{"login":"jserv","id":478921,"avatar_url":"https://avatars.githubusercontent.com/u/478921?v=3","gravatar_id":"","url":"https://api.github.com/users/jserv","html_url":"https://github.com/jserv","followers_url":"https://api.github.com/users/jserv/followers","following_url":"https://api.github.com/users/jserv/following{/other_user}","gists_url":"https://api.github.com/users/jserv/gists{/gist_id}","starred_url":"https://api.github.com/users/jserv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jserv/subscriptions","organizations_url":"https://api.github.com/users/jserv/orgs","repos_url":"https://api.github.com/users/jserv/repos","events_url":"https://api.github.com/users/jserv/events{/privacy}","received_events_url":"https://api.github.com/users/jserv/received_events","type":"User","site_admin":false},"created_at":"2016-05-16T14:17:31Z","updated_at":"2016-05-16T14:17:31Z","body":"Affirmative!"}}