{"action":"created","comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/comments/72887355","id":72887355,"diff_hunk":"@@ -317,13 +348,31 @@ def filter(event)\n       # retrieve the current aggregate map\n       aggregate_maps_element = @@aggregate_maps[task_id]\n       \n+\n       # create aggregate map, if it doesn't exist\n       if (aggregate_maps_element.nil?)\n         return if @map_action == \"update\"\n         # create new event from previous map, if @push_previous_map_as_event is enabled\n         if (@push_previous_map_as_event and !@@aggregate_maps.empty?)\n           previous_map = @@aggregate_maps.shift[1].map\n           event_to_yield = LogStash::Event.new(previous_map)\n+\n+          if @timeout_task_id_field\n+            event_to_yield[@timeout_task_id_field] = task_id\n+          end\n+\n+          # Call code block if available\n+          if @timeout_code\n+            begin\n+              @timeout_codeblock.call(event)\n+              events_to_flush << event","path":"lib/logstash/filters/aggregate.rb","position":78,"original_position":78,"commit_id":"e32f2ce01e71ed78953787aaff596a1b9ce58228","original_commit_id":"e32f2ce01e71ed78953787aaff596a1b9ce58228","user":{"login":"fbaligand","id":3750300,"avatar_url":"https://avatars.githubusercontent.com/u/3750300?v=3","gravatar_id":"","url":"https://api.github.com/users/fbaligand","html_url":"https://github.com/fbaligand","followers_url":"https://api.github.com/users/fbaligand/followers","following_url":"https://api.github.com/users/fbaligand/following{/other_user}","gists_url":"https://api.github.com/users/fbaligand/gists{/gist_id}","starred_url":"https://api.github.com/users/fbaligand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbaligand/subscriptions","organizations_url":"https://api.github.com/users/fbaligand/orgs","repos_url":"https://api.github.com/users/fbaligand/repos","events_url":"https://api.github.com/users/fbaligand/events{/privacy}","received_events_url":"https://api.github.com/users/fbaligand/received_events","type":"User","site_admin":false},"body":"Up to me, in filter method, there are no events to flush.\r\nSo this line has to be removed.\r\nDo you agree with that ?","created_at":"2016-07-30T13:27:45Z","updated_at":"2016-07-30T13:27:45Z","html_url":"https://github.com/logstash-plugins/logstash-filter-aggregate/pull/37#discussion_r72887355","pull_request_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/comments/72887355"},"html":{"href":"https://github.com/logstash-plugins/logstash-filter-aggregate/pull/37#discussion_r72887355"},"pull_request":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/37","id":78306252,"html_url":"https://github.com/logstash-plugins/logstash-filter-aggregate/pull/37","diff_url":"https://github.com/logstash-plugins/logstash-filter-aggregate/pull/37.diff","patch_url":"https://github.com/logstash-plugins/logstash-filter-aggregate/pull/37.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/issues/37","number":37,"state":"open","locked":false,"title":"#33 Pull request to add timeout event creation","user":{"login":"pandaadb","id":15109364,"avatar_url":"https://avatars.githubusercontent.com/u/15109364?v=3","gravatar_id":"","url":"https://api.github.com/users/pandaadb","html_url":"https://github.com/pandaadb","followers_url":"https://api.github.com/users/pandaadb/followers","following_url":"https://api.github.com/users/pandaadb/following{/other_user}","gists_url":"https://api.github.com/users/pandaadb/gists{/gist_id}","starred_url":"https://api.github.com/users/pandaadb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandaadb/subscriptions","organizations_url":"https://api.github.com/users/pandaadb/orgs","repos_url":"https://api.github.com/users/pandaadb/repos","events_url":"https://api.github.com/users/pandaadb/events{/privacy}","received_events_url":"https://api.github.com/users/pandaadb/received_events","type":"User","site_admin":false},"body":"Hi Fabien,\r\n\r\nThis is the pull request. As you know I had a bit of merge nightmare - I hope it is all readable and OK :) Let me know what you think,\r\n\r\nRegards,\r\nArtur","created_at":"2016-07-21T12:22:38Z","updated_at":"2016-07-30T13:27:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15994603e1be3027102f22ee8e13bcab74d4551d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/37/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/37/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/issues/37/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/statuses/e32f2ce01e71ed78953787aaff596a1b9ce58228","head":{"label":"pandaadb:master","ref":"master","sha":"e32f2ce01e71ed78953787aaff596a1b9ce58228","user":{"login":"pandaadb","id":15109364,"avatar_url":"https://avatars.githubusercontent.com/u/15109364?v=3","gravatar_id":"","url":"https://api.github.com/users/pandaadb","html_url":"https://github.com/pandaadb","followers_url":"https://api.github.com/users/pandaadb/followers","following_url":"https://api.github.com/users/pandaadb/following{/other_user}","gists_url":"https://api.github.com/users/pandaadb/gists{/gist_id}","starred_url":"https://api.github.com/users/pandaadb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandaadb/subscriptions","organizations_url":"https://api.github.com/users/pandaadb/orgs","repos_url":"https://api.github.com/users/pandaadb/repos","events_url":"https://api.github.com/users/pandaadb/events{/privacy}","received_events_url":"https://api.github.com/users/pandaadb/received_events","type":"User","site_admin":false},"repo":{"id":61117564,"name":"logstash-filter-aggregate","full_name":"pandaadb/logstash-filter-aggregate","owner":{"login":"pandaadb","id":15109364,"avatar_url":"https://avatars.githubusercontent.com/u/15109364?v=3","gravatar_id":"","url":"https://api.github.com/users/pandaadb","html_url":"https://github.com/pandaadb","followers_url":"https://api.github.com/users/pandaadb/followers","following_url":"https://api.github.com/users/pandaadb/following{/other_user}","gists_url":"https://api.github.com/users/pandaadb/gists{/gist_id}","starred_url":"https://api.github.com/users/pandaadb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandaadb/subscriptions","organizations_url":"https://api.github.com/users/pandaadb/orgs","repos_url":"https://api.github.com/users/pandaadb/repos","events_url":"https://api.github.com/users/pandaadb/events{/privacy}","received_events_url":"https://api.github.com/users/pandaadb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pandaadb/logstash-filter-aggregate","description":"The aim of this filter is to aggregate informations available among several events (typically log lines) belonging to a same task, and finally push aggregated information into final task event.","fork":true,"url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate","forks_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/forks","keys_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/teams","hooks_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/hooks","issue_events_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/issues/events{/number}","events_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/events","assignees_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/assignees{/user}","branches_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/branches{/branch}","tags_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/tags","blobs_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/statuses/{sha}","languages_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/languages","stargazers_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/stargazers","contributors_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/contributors","subscribers_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/subscribers","subscription_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/subscription","commits_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/contents/{+path}","compare_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/merges","archive_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/downloads","issues_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/issues{/number}","pulls_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/pulls{/number}","milestones_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/milestones{/number}","notifications_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/labels{/name}","releases_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/releases{/id}","deployments_url":"https://api.github.com/repos/pandaadb/logstash-filter-aggregate/deployments","created_at":"2016-06-14T11:32:17Z","updated_at":"2016-06-14T11:32:18Z","pushed_at":"2016-07-27T09:45:49Z","git_url":"git://github.com/pandaadb/logstash-filter-aggregate.git","ssh_url":"git@github.com:pandaadb/logstash-filter-aggregate.git","clone_url":"https://github.com/pandaadb/logstash-filter-aggregate.git","svn_url":"https://github.com/pandaadb/logstash-filter-aggregate","homepage":null,"size":109,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash-plugins:master","ref":"master","sha":"5d3ea98a12d6e3b8414ab24dda15d257ff87c3a3","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":33984534,"name":"logstash-filter-aggregate","full_name":"logstash-plugins/logstash-filter-aggregate","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-filter-aggregate","description":"The aim of this filter is to aggregate informations available among several events (typically log lines) belonging to a same task, and finally push aggregated information into final task event.","fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/releases{/id}","deployments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/deployments","created_at":"2015-04-15T09:16:31Z","updated_at":"2016-07-20T10:13:12Z","pushed_at":"2016-07-27T09:45:50Z","git_url":"git://github.com/logstash-plugins/logstash-filter-aggregate.git","ssh_url":"git@github.com:logstash-plugins/logstash-filter-aggregate.git","clone_url":"https://github.com/logstash-plugins/logstash-filter-aggregate.git","svn_url":"https://github.com/logstash-plugins/logstash-filter-aggregate","homepage":null,"size":103,"stargazers_count":14,"watchers_count":14,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":7,"forks":12,"open_issues":7,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/37"},"html":{"href":"https://github.com/logstash-plugins/logstash-filter-aggregate/pull/37"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/issues/37"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-filter-aggregate/statuses/e32f2ce01e71ed78953787aaff596a1b9ce58228"}}}}
{"actor":{"display_login":"fbaligand"}}