{"action":"closed","issue":{"url":"https://api.github.com/repos/hashicorp/terraform/issues/7318","repository_url":"https://api.github.com/repos/hashicorp/terraform","labels_url":"https://api.github.com/repos/hashicorp/terraform/issues/7318/labels{/name}","comments_url":"https://api.github.com/repos/hashicorp/terraform/issues/7318/comments","events_url":"https://api.github.com/repos/hashicorp/terraform/issues/7318/events","html_url":"https://github.com/hashicorp/terraform/issues/7318","id":162157498,"number":7318,"title":"(Un)Tainting (un)tainted resource is allowed","user":{"login":"radeksimko","id":287584,"avatar_url":"https://avatars.githubusercontent.com/u/287584?v=3","gravatar_id":"","url":"https://api.github.com/users/radeksimko","html_url":"https://github.com/radeksimko","followers_url":"https://api.github.com/users/radeksimko/followers","following_url":"https://api.github.com/users/radeksimko/following{/other_user}","gists_url":"https://api.github.com/users/radeksimko/gists{/gist_id}","starred_url":"https://api.github.com/users/radeksimko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radeksimko/subscriptions","organizations_url":"https://api.github.com/users/radeksimko/orgs","repos_url":"https://api.github.com/users/radeksimko/repos","events_url":"https://api.github.com/users/radeksimko/events{/privacy}","received_events_url":"https://api.github.com/users/radeksimko/received_events","type":"User","site_admin":false},"labels":[{"id":85946957,"url":"https://api.github.com/repos/hashicorp/terraform/labels/bug","name":"bug","color":"f7c6c7","default":true},{"id":127939292,"url":"https://api.github.com/repos/hashicorp/terraform/labels/core","name":"core","color":"cccccc","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-24T14:18:32Z","updated_at":"2016-11-02T05:03:33Z","closed_at":"2016-11-02T05:03:33Z","body":"I'm not entirely sure whether to treat this as a bug or a feature.\n### Behaviour in `0.6.16`\n\n```\n$ terraform untaint aws_vpc.main\nError untainting aws_vpc.main: Nothing to untaint.\nYou can use `terraform show` to inspect the current state.\n$ terraform untaint aws_vpc.main\nError untainting aws_vpc.main: Nothing to untaint.\nYou can use `terraform show` to inspect the current state.\n```\n\n```\n$ terraform taint aws_vpc.main\nThe resource aws_vpc.main in the module root has been marked as tainted!\n$ terraform taint aws_vpc.main\nThe resource aws_vpc.main in the module root has been marked as tainted!\n```\n### Behaviour in `0.7+` (`master`)\n\n```\n$ terraform untaint aws_vpc.main\nThe resource aws_vpc.main in the module root has been successfully untainted!\n$ terraform untaint aws_vpc.main\nThe resource aws_vpc.main in the module root has been successfully untainted!\n```\n\n```\n$ terraform taint aws_vpc.main\nThe resource aws_vpc.main in the module root has been marked as tainted!\n$ terraform taint aws_vpc.main\nThe resource aws_vpc.main in the module root has been marked as tainted!\n```\n\nI admit it's good that the behaviour is now consistent for both taint & untaint, but I was more expecting the `(un)taint` operation to fail it the resource is already (un)tainted.\n\nAny reasons why keeping it as is?\n"}}
{"actor":{"display_login":"mitchellh"}}