{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/college-costs/issues/175","repository_url":"https://api.github.com/repos/cfpb/college-costs","labels_url":"https://api.github.com/repos/cfpb/college-costs/issues/175/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/college-costs/issues/175/comments","events_url":"https://api.github.com/repos/cfpb/college-costs/issues/175/events","html_url":"https://github.com/cfpb/college-costs/pull/175","id":158427868,"number":175,"title":"New BLS Expenses Data handling","user":{"login":"mistergone","id":1490703,"avatar_url":"https://avatars.githubusercontent.com/u/1490703?v=3","gravatar_id":"","url":"https://api.github.com/users/mistergone","html_url":"https://github.com/mistergone","followers_url":"https://api.github.com/users/mistergone/followers","following_url":"https://api.github.com/users/mistergone/following{/other_user}","gists_url":"https://api.github.com/users/mistergone/gists{/gist_id}","starred_url":"https://api.github.com/users/mistergone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistergone/subscriptions","organizations_url":"https://api.github.com/users/mistergone/orgs","repos_url":"https://api.github.com/users/mistergone/repos","events_url":"https://api.github.com/users/mistergone/events{/privacy}","received_events_url":"https://api.github.com/users/mistergone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-06-03T18:35:20Z","updated_at":"2016-06-03T20:55:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cfpb/college-costs/pulls/175","html_url":"https://github.com/cfpb/college-costs/pull/175","diff_url":"https://github.com/cfpb/college-costs/pull/175.diff","patch_url":"https://github.com/cfpb/college-costs/pull/175.patch"},"body":"This is a fairly big PR in terms of code changes, but as far as effect goes, it mostly just updates the app to use the new BLS Expenses API, and it applies the improvements of data quality to the front-end. It also moves the budget worksheet handling into its own \"expenses\" model and view.\r\n\r\n__Note!__ This PR doesn't do any style or structure changes as outlined in our latest design. The changes in this PR are mostly processing changes, and the only HTML changes were to add a missing input.\r\n\r\n## Additions\r\n- Added an 'expenses' model in `expenses-model.js`\r\n- Added an 'expenses' view in `expenses-view.js`\r\n- Replaced `get-model-values.js` with three separate dispatchers, `get-financial-values.js`,  `get-expenses-values.js`, and  `get-school-values.js`. This change helps us avoid `require()` loops.\r\n\r\n## Removals\r\n- `get-model-values.js` removed, replaced with files noted above\r\n\r\n## Changes\r\n- The app now uses the `/api/expenses/` endpoint\r\n- Fixed functional tests for budget worksheet section\r\n- Fixed an error in how `get-api-values.js` was coded ( a `return` inside a `.done` doesn't actually do anything)\r\n\r\n## Testing\r\n- All unit tests pass\r\n- All functional tests pass\r\n\r\n## Review\r\n- @marteki and @higs4281 and @amymok and anyone who likes Javascript!\r\n\r\n## Screenshots\r\nThe best screenshot:\r\n<img width=\"542\" alt=\"screen shot 2016-06-03 at 12 01 42 pm\" src=\"https://cloud.githubusercontent.com/assets/1490703/15788741/fc0e4bfc-2996-11e6-8795-3d690705d7b1.png\">\r\n\r\n## Checklist\r\n* [x] Changes are limited to a single goal (no scope creep)\r\n* [x] Code can be automatically merged (no conflicts)\r\n* [x] Code follows the standards laid out in the [front end playbook](https://github.com/cfpb/front-end)\r\n* [x] Passes all existing automated tests\r\n* [x] New functions include new tests\r\n* [x] New functions are documented (with a description, list of inputs, and expected output)\r\n* [x] Placeholder code is flagged\r\n* [x] Visually tested in supported browsers and devices \r\n* [x] Project documentation has been updated (including the \"Unreleased\" section of the CHANGELOG)\r\n\r\n## Special Thanks\r\nThanks to @wpears and @sephcoster for helping me learn about deferreds and how I was doing them wrong!\r\n\r\n## Animated GIF\r\n__\"Wait, what do you mean that `return` isn't doing anything?\"__\r\n![drwho-realization](https://cloud.githubusercontent.com/assets/1490703/15789037/51f9b406-2998-11e6-9081-72f69bc0afeb.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/cfpb/college-costs/issues/comments/223692169","html_url":"https://github.com/cfpb/college-costs/pull/175#issuecomment-223692169","issue_url":"https://api.github.com/repos/cfpb/college-costs/issues/175","id":223692169,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-06-03T20:55:00Z","updated_at":"2016-06-03T20:55:00Z","body":"\n[![Coverage Status](https://coveralls.io/builds/6458429/badge)](https://coveralls.io/builds/6458429)\n\nCoverage remained the same at 100.0% when pulling **85bddb82517007e05d8abd990aa4809d7a46966a on bls** into **0987ff190ff15d3edab8bd01504800b445319144 on master**.\n"}}
{"actor":{"display_login":"coveralls"}}