{"action":"created","issue":{"url":"https://api.github.com/repos/TerriaJS/terriajs/issues/1964","repository_url":"https://api.github.com/repos/TerriaJS/terriajs","labels_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/1964/labels{/name}","comments_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/1964/comments","events_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/1964/events","html_url":"https://github.com/TerriaJS/terriajs/issues/1964","id":171794609,"number":1964,"title":"Proxying tile requests that start with // doesn't work right","user":{"login":"stevage","id":678344,"avatar_url":"https://avatars.githubusercontent.com/u/678344?v=3","gravatar_id":"","url":"https://api.github.com/users/stevage","html_url":"https://github.com/stevage","followers_url":"https://api.github.com/users/stevage/followers","following_url":"https://api.github.com/users/stevage/following{/other_user}","gists_url":"https://api.github.com/users/stevage/gists{/gist_id}","starred_url":"https://api.github.com/users/stevage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevage/subscriptions","organizations_url":"https://api.github.com/users/stevage/orgs","repos_url":"https://api.github.com/users/stevage/repos","events_url":"https://api.github.com/users/stevage/events{/privacy}","received_events_url":"https://api.github.com/users/stevage/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/TerriaJS/terriajs/labels/T-Bug","name":"T-Bug","color":"EE2222"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-18T00:59:35Z","updated_at":"2016-08-18T01:09:14Z","closed_at":null,"body":"In Parlmap, I'm seeing this error browser-side when switching to Positron:\r\n\r\n```\r\nFailed to load resource: the server responded with a status of 500 (Internal Server Error)\r\n2016-08-18 10:48:36.887 http://localhost:3005/proxy///cartodb-basemaps-d.global.ssl.fastly.net/light_all/3/0/0.png \r\n```\r\n\r\nNotice the URL it tries to resolve starts with `//` which doesn't really make sense outside the browser context, I believe.\r\n\r\nThe server complains:\r\n\r\n```\r\nError: Invalid URI \"http:///cartodb-basemaps-b.global.ssl.fastly.net/light_all/3/0/0.png\"\r\n    at Request.init (/Users/stevebennett/odev/nicta/nationalmap/parlmap/node_modules/request/request.js:288:31)\r\n```\r\n\r\nThe workaround is to add fastly.net to `corsDomains` so it doesn't get proxied at all. (For that matter, do we actually need to proxy these tile requests? They don't seem to be XHRs.)"},"comment":{"url":"https://api.github.com/repos/TerriaJS/terriajs/issues/comments/240596093","html_url":"https://github.com/TerriaJS/terriajs/issues/1964#issuecomment-240596093","issue_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/1964","id":240596093,"user":{"login":"stevage","id":678344,"avatar_url":"https://avatars.githubusercontent.com/u/678344?v=3","gravatar_id":"","url":"https://api.github.com/users/stevage","html_url":"https://github.com/stevage","followers_url":"https://api.github.com/users/stevage/followers","following_url":"https://api.github.com/users/stevage/following{/other_user}","gists_url":"https://api.github.com/users/stevage/gists{/gist_id}","starred_url":"https://api.github.com/users/stevage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevage/subscriptions","organizations_url":"https://api.github.com/users/stevage/orgs","repos_url":"https://api.github.com/users/stevage/repos","events_url":"https://api.github.com/users/stevage/events{/privacy}","received_events_url":"https://api.github.com/users/stevage/received_events","type":"User","site_admin":false},"created_at":"2016-08-18T01:09:14Z","updated_at":"2016-08-18T01:09:14Z","body":"(Ok, the actual cause of me seeing this was failing to pass the config file to terriajs-server, so it was trying and failing to act as an open proxy. So, there's no actual impact here at the moment, but it's still a bug I think.)"}}
{"actor":{"display_login":"stevage"}}