{"action":"closed","number":62,"pull_request":{"url":"https://api.github.com/repos/tableau/document-api-python/pulls/62","id":78787404,"html_url":"https://github.com/tableau/document-api-python/pull/62","diff_url":"https://github.com/tableau/document-api-python/pull/62.diff","patch_url":"https://github.com/tableau/document-api-python/pull/62.patch","issue_url":"https://api.github.com/repos/tableau/document-api-python/issues/62","number":62,"state":"closed","locked":false,"title":"New approach for checking we are loading the right file","user":{"login":"t8y8","id":4370533,"avatar_url":"https://avatars.githubusercontent.com/u/4370533?v=3","gravatar_id":"","url":"https://api.github.com/users/t8y8","html_url":"https://github.com/t8y8","followers_url":"https://api.github.com/users/t8y8/followers","following_url":"https://api.github.com/users/t8y8/following{/other_user}","gists_url":"https://api.github.com/users/t8y8/gists{/gist_id}","starred_url":"https://api.github.com/users/t8y8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t8y8/subscriptions","organizations_url":"https://api.github.com/users/t8y8/orgs","repos_url":"https://api.github.com/users/t8y8/repos","events_url":"https://api.github.com/users/t8y8/events{/privacy}","received_events_url":"https://api.github.com/users/t8y8/received_events","type":"User","site_admin":false},"body":"This subsumes #60.\r\n\r\nHere's an approach for feedback, I pulled the logic up into the xml_open class because otherwise I'd need to pass the root tag all the way down through the helper functions and it made the try-with-if-raise nesting complex in `find_file_in_zip`.\r\n\r\nI want to clean up a bit more of that logic, but this is a good start for feedback","created_at":"2016-07-26T03:43:13Z","updated_at":"2016-07-27T10:57:01Z","closed_at":"2016-07-27T10:57:01Z","merged_at":"2016-07-27T10:57:01Z","merge_commit_sha":"4d6ff518cb86b49902d35a746874d241e5576e96","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tableau/document-api-python/pulls/62/commits","review_comments_url":"https://api.github.com/repos/tableau/document-api-python/pulls/62/comments","review_comment_url":"https://api.github.com/repos/tableau/document-api-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tableau/document-api-python/issues/62/comments","statuses_url":"https://api.github.com/repos/tableau/document-api-python/statuses/5ef0fa06dd6dc618a08cee7289934d69ecc9a7b2","head":{"label":"t8y8:bugfix-60-xml-open","ref":"bugfix-60-xml-open","sha":"5ef0fa06dd6dc618a08cee7289934d69ecc9a7b2","user":{"login":"t8y8","id":4370533,"avatar_url":"https://avatars.githubusercontent.com/u/4370533?v=3","gravatar_id":"","url":"https://api.github.com/users/t8y8","html_url":"https://github.com/t8y8","followers_url":"https://api.github.com/users/t8y8/followers","following_url":"https://api.github.com/users/t8y8/following{/other_user}","gists_url":"https://api.github.com/users/t8y8/gists{/gist_id}","starred_url":"https://api.github.com/users/t8y8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t8y8/subscriptions","organizations_url":"https://api.github.com/users/t8y8/orgs","repos_url":"https://api.github.com/users/t8y8/repos","events_url":"https://api.github.com/users/t8y8/events{/privacy}","received_events_url":"https://api.github.com/users/t8y8/received_events","type":"User","site_admin":false},"repo":{"id":64185475,"name":"document-api-python","full_name":"t8y8/document-api-python","owner":{"login":"t8y8","id":4370533,"avatar_url":"https://avatars.githubusercontent.com/u/4370533?v=3","gravatar_id":"","url":"https://api.github.com/users/t8y8","html_url":"https://github.com/t8y8","followers_url":"https://api.github.com/users/t8y8/followers","following_url":"https://api.github.com/users/t8y8/following{/other_user}","gists_url":"https://api.github.com/users/t8y8/gists{/gist_id}","starred_url":"https://api.github.com/users/t8y8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t8y8/subscriptions","organizations_url":"https://api.github.com/users/t8y8/orgs","repos_url":"https://api.github.com/users/t8y8/repos","events_url":"https://api.github.com/users/t8y8/events{/privacy}","received_events_url":"https://api.github.com/users/t8y8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/t8y8/document-api-python","description":null,"fork":true,"url":"https://api.github.com/repos/t8y8/document-api-python","forks_url":"https://api.github.com/repos/t8y8/document-api-python/forks","keys_url":"https://api.github.com/repos/t8y8/document-api-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/t8y8/document-api-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/t8y8/document-api-python/teams","hooks_url":"https://api.github.com/repos/t8y8/document-api-python/hooks","issue_events_url":"https://api.github.com/repos/t8y8/document-api-python/issues/events{/number}","events_url":"https://api.github.com/repos/t8y8/document-api-python/events","assignees_url":"https://api.github.com/repos/t8y8/document-api-python/assignees{/user}","branches_url":"https://api.github.com/repos/t8y8/document-api-python/branches{/branch}","tags_url":"https://api.github.com/repos/t8y8/document-api-python/tags","blobs_url":"https://api.github.com/repos/t8y8/document-api-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/t8y8/document-api-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/t8y8/document-api-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/t8y8/document-api-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/t8y8/document-api-python/statuses/{sha}","languages_url":"https://api.github.com/repos/t8y8/document-api-python/languages","stargazers_url":"https://api.github.com/repos/t8y8/document-api-python/stargazers","contributors_url":"https://api.github.com/repos/t8y8/document-api-python/contributors","subscribers_url":"https://api.github.com/repos/t8y8/document-api-python/subscribers","subscription_url":"https://api.github.com/repos/t8y8/document-api-python/subscription","commits_url":"https://api.github.com/repos/t8y8/document-api-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/t8y8/document-api-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/t8y8/document-api-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/t8y8/document-api-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/t8y8/document-api-python/contents/{+path}","compare_url":"https://api.github.com/repos/t8y8/document-api-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/t8y8/document-api-python/merges","archive_url":"https://api.github.com/repos/t8y8/document-api-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/t8y8/document-api-python/downloads","issues_url":"https://api.github.com/repos/t8y8/document-api-python/issues{/number}","pulls_url":"https://api.github.com/repos/t8y8/document-api-python/pulls{/number}","milestones_url":"https://api.github.com/repos/t8y8/document-api-python/milestones{/number}","notifications_url":"https://api.github.com/repos/t8y8/document-api-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/t8y8/document-api-python/labels{/name}","releases_url":"https://api.github.com/repos/t8y8/document-api-python/releases{/id}","deployments_url":"https://api.github.com/repos/t8y8/document-api-python/deployments","created_at":"2016-07-26T03:04:44Z","updated_at":"2016-07-26T03:04:45Z","pushed_at":"2016-07-27T10:51:28Z","git_url":"git://github.com/t8y8/document-api-python.git","ssh_url":"git@github.com:t8y8/document-api-python.git","clone_url":"https://github.com/t8y8/document-api-python.git","svn_url":"https://github.com/t8y8/document-api-python","homepage":null,"size":125,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tableau:development","ref":"development","sha":"aa93eeff7cd02431479aa5a92309b3ed10bfca5b","user":{"login":"tableau","id":828667,"avatar_url":"https://avatars.githubusercontent.com/u/828667?v=3","gravatar_id":"","url":"https://api.github.com/users/tableau","html_url":"https://github.com/tableau","followers_url":"https://api.github.com/users/tableau/followers","following_url":"https://api.github.com/users/tableau/following{/other_user}","gists_url":"https://api.github.com/users/tableau/gists{/gist_id}","starred_url":"https://api.github.com/users/tableau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tableau/subscriptions","organizations_url":"https://api.github.com/users/tableau/orgs","repos_url":"https://api.github.com/users/tableau/repos","events_url":"https://api.github.com/users/tableau/events{/privacy}","received_events_url":"https://api.github.com/users/tableau/received_events","type":"Organization","site_admin":false},"repo":{"id":58406499,"name":"document-api-python","full_name":"tableau/document-api-python","owner":{"login":"tableau","id":828667,"avatar_url":"https://avatars.githubusercontent.com/u/828667?v=3","gravatar_id":"","url":"https://api.github.com/users/tableau","html_url":"https://github.com/tableau","followers_url":"https://api.github.com/users/tableau/followers","following_url":"https://api.github.com/users/tableau/following{/other_user}","gists_url":"https://api.github.com/users/tableau/gists{/gist_id}","starred_url":"https://api.github.com/users/tableau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tableau/subscriptions","organizations_url":"https://api.github.com/users/tableau/orgs","repos_url":"https://api.github.com/users/tableau/repos","events_url":"https://api.github.com/users/tableau/events{/privacy}","received_events_url":"https://api.github.com/users/tableau/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tableau/document-api-python","description":"","fork":false,"url":"https://api.github.com/repos/tableau/document-api-python","forks_url":"https://api.github.com/repos/tableau/document-api-python/forks","keys_url":"https://api.github.com/repos/tableau/document-api-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tableau/document-api-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tableau/document-api-python/teams","hooks_url":"https://api.github.com/repos/tableau/document-api-python/hooks","issue_events_url":"https://api.github.com/repos/tableau/document-api-python/issues/events{/number}","events_url":"https://api.github.com/repos/tableau/document-api-python/events","assignees_url":"https://api.github.com/repos/tableau/document-api-python/assignees{/user}","branches_url":"https://api.github.com/repos/tableau/document-api-python/branches{/branch}","tags_url":"https://api.github.com/repos/tableau/document-api-python/tags","blobs_url":"https://api.github.com/repos/tableau/document-api-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tableau/document-api-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tableau/document-api-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/tableau/document-api-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tableau/document-api-python/statuses/{sha}","languages_url":"https://api.github.com/repos/tableau/document-api-python/languages","stargazers_url":"https://api.github.com/repos/tableau/document-api-python/stargazers","contributors_url":"https://api.github.com/repos/tableau/document-api-python/contributors","subscribers_url":"https://api.github.com/repos/tableau/document-api-python/subscribers","subscription_url":"https://api.github.com/repos/tableau/document-api-python/subscription","commits_url":"https://api.github.com/repos/tableau/document-api-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/tableau/document-api-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/tableau/document-api-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/tableau/document-api-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/tableau/document-api-python/contents/{+path}","compare_url":"https://api.github.com/repos/tableau/document-api-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tableau/document-api-python/merges","archive_url":"https://api.github.com/repos/tableau/document-api-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tableau/document-api-python/downloads","issues_url":"https://api.github.com/repos/tableau/document-api-python/issues{/number}","pulls_url":"https://api.github.com/repos/tableau/document-api-python/pulls{/number}","milestones_url":"https://api.github.com/repos/tableau/document-api-python/milestones{/number}","notifications_url":"https://api.github.com/repos/tableau/document-api-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tableau/document-api-python/labels{/name}","releases_url":"https://api.github.com/repos/tableau/document-api-python/releases{/id}","deployments_url":"https://api.github.com/repos/tableau/document-api-python/deployments","created_at":"2016-05-09T20:38:09Z","updated_at":"2016-07-26T08:23:48Z","pushed_at":"2016-07-27T10:57:01Z","git_url":"git://github.com/tableau/document-api-python.git","ssh_url":"git@github.com:tableau/document-api-python.git","clone_url":"https://github.com/tableau/document-api-python.git","svn_url":"https://github.com/tableau/document-api-python","homepage":null,"size":170,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":20,"forks":2,"open_issues":20,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tableau/document-api-python/pulls/62"},"html":{"href":"https://github.com/tableau/document-api-python/pull/62"},"issue":{"href":"https://api.github.com/repos/tableau/document-api-python/issues/62"},"comments":{"href":"https://api.github.com/repos/tableau/document-api-python/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/tableau/document-api-python/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/tableau/document-api-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tableau/document-api-python/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/tableau/document-api-python/statuses/5ef0fa06dd6dc618a08cee7289934d69ecc9a7b2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"t8y8","id":4370533,"avatar_url":"https://avatars.githubusercontent.com/u/4370533?v=3","gravatar_id":"","url":"https://api.github.com/users/t8y8","html_url":"https://github.com/t8y8","followers_url":"https://api.github.com/users/t8y8/followers","following_url":"https://api.github.com/users/t8y8/following{/other_user}","gists_url":"https://api.github.com/users/t8y8/gists{/gist_id}","starred_url":"https://api.github.com/users/t8y8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t8y8/subscriptions","organizations_url":"https://api.github.com/users/t8y8/orgs","repos_url":"https://api.github.com/users/t8y8/repos","events_url":"https://api.github.com/users/t8y8/events{/privacy}","received_events_url":"https://api.github.com/users/t8y8/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":3,"additions":46,"deletions":12,"changed_files":5}}
{"actor":{"display_login":"t8y8"}}