{"action":"created","issue":{"url":"https://api.github.com/repos/stripe/smokescreen/issues/1","repository_url":"https://api.github.com/repos/stripe/smokescreen","labels_url":"https://api.github.com/repos/stripe/smokescreen/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/stripe/smokescreen/issues/1/comments","events_url":"https://api.github.com/repos/stripe/smokescreen/issues/1/events","html_url":"https://github.com/stripe/smokescreen/pull/1","id":172197585,"number":1,"title":"Dial down smokescreen logging.","user":{"login":"gphat","id":45159,"avatar_url":"https://avatars.githubusercontent.com/u/45159?v=3","gravatar_id":"","url":"https://api.github.com/users/gphat","html_url":"https://github.com/gphat","followers_url":"https://api.github.com/users/gphat/followers","following_url":"https://api.github.com/users/gphat/following{/other_user}","gists_url":"https://api.github.com/users/gphat/gists{/gist_id}","starred_url":"https://api.github.com/users/gphat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gphat/subscriptions","organizations_url":"https://api.github.com/users/gphat/orgs","repos_url":"https://api.github.com/users/gphat/repos","events_url":"https://api.github.com/users/gphat/events{/privacy}","received_events_url":"https://api.github.com/users/gphat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-08-19T18:57:53Z","updated_at":"2016-08-19T22:46:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stripe/smokescreen/pulls/1","html_url":"https://github.com/stripe/smokescreen/pull/1","diff_url":"https://github.com/stripe/smokescreen/pull/1.diff","patch_url":"https://github.com/stripe/smokescreen/pull/1.patch"},"body":"# What's this PR do?\r\n\r\nDials down smokescreen logging, since it's pretty loud.\r\n\r\nSpecifically, it sets the proxy's verbose flag to false. That control's the [rudimentary logging](https://github.com/elazarl/goproxy/blob/bee2110779c23d999b253c0ec8873757dc43d9a3/ctx.go#L56) and prevents a bunch of stuff from coming out. Specifically, `WARN` will continue to work.\r\n\r\n# Why?\r\n\r\nSpecifically, it's been responsible for about 115MM log events in the last 24 hours in our setup.\r\n\r\n# Note\r\n\r\nI'm biasing to action here. Not sure what uses these logs and if they are needed for anything. Happy to adjust!\r\n\r\nr? @antifuchs \r\ncc @andrew-d @zenazn @ebroder  "},"comment":{"url":"https://api.github.com/repos/stripe/smokescreen/issues/comments/241153734","html_url":"https://github.com/stripe/smokescreen/pull/1#issuecomment-241153734","issue_url":"https://api.github.com/repos/stripe/smokescreen/issues/1","id":241153734,"user":{"login":"zenazn","id":12960,"avatar_url":"https://avatars.githubusercontent.com/u/12960?v=3","gravatar_id":"","url":"https://api.github.com/users/zenazn","html_url":"https://github.com/zenazn","followers_url":"https://api.github.com/users/zenazn/followers","following_url":"https://api.github.com/users/zenazn/following{/other_user}","gists_url":"https://api.github.com/users/zenazn/gists{/gist_id}","starred_url":"https://api.github.com/users/zenazn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenazn/subscriptions","organizations_url":"https://api.github.com/users/zenazn/orgs","repos_url":"https://api.github.com/users/zenazn/repos","events_url":"https://api.github.com/users/zenazn/events{/privacy}","received_events_url":"https://api.github.com/users/zenazn/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T22:46:11Z","updated_at":"2016-08-19T22:46:11Z","body":"I don't particularly enjoy `smokescreen`'s current logging; I was suggesting that we take some time (not necessarily now) to write logging that is both dense and helpful (and e.g., includes `action_id`s, and is easy to Splunk and ???)\r\n\r\nPost-hoc verbose flags ~never work—they're never on when they're most helpful, and since they're ~never on, they tend to bitrot very quickly. I would be more in favor of eliminating logs all together and accepting the consequences there than adding a post-hoc verbose flag."}}
{"actor":{"display_login":"zenazn"}}