{"action":"created","issue":{"url":"https://api.github.com/repos/deis/deis/issues/5102","repository_url":"https://api.github.com/repos/deis/deis","labels_url":"https://api.github.com/repos/deis/deis/issues/5102/labels{/name}","comments_url":"https://api.github.com/repos/deis/deis/issues/5102/comments","events_url":"https://api.github.com/repos/deis/deis/issues/5102/events","html_url":"https://github.com/deis/deis/issues/5102","id":183504526,"number":5102,"title":"(Custom) domain with no certificate still serves https","user":{"login":"nathansamson","id":93735,"avatar_url":"https://avatars.githubusercontent.com/u/93735?v=3","gravatar_id":"","url":"https://api.github.com/users/nathansamson","html_url":"https://github.com/nathansamson","followers_url":"https://api.github.com/users/nathansamson/followers","following_url":"https://api.github.com/users/nathansamson/following{/other_user}","gists_url":"https://api.github.com/users/nathansamson/gists{/gist_id}","starred_url":"https://api.github.com/users/nathansamson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathansamson/subscriptions","organizations_url":"https://api.github.com/users/nathansamson/orgs","repos_url":"https://api.github.com/users/nathansamson/repos","events_url":"https://api.github.com/users/nathansamson/events{/privacy}","received_events_url":"https://api.github.com/users/nathansamson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/deis/deis/labels/router","name":"router","color":"bfdadc"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-17T19:26:08Z","updated_at":"2016-10-21T20:29:28Z","closed_at":null,"body":"Steps to reproduce:\r\n* Install deis v 1.13\r\n* Create 2 applications (a and b)\r\n* Add a custom domain to both applications (a.example.org and b.example.org)\r\n* Add a https certificate to one of the domains (b.example.org)\r\n* Access https://a.example.org\r\n\r\nSee that the connection is accepted but served with the certificate for b.example.org. After accepting the exception of the invalid certificate in your browser traffic will be served by application B instead of application A.\r\n\r\nAn example can be seen in https://fiesta-mundial.beeple.eu/ vs http://fiesta-mundial.beeple.eu/ \r\n\r\n\r\nI am not sure what an acceptable solution would be, but I would suggest either a \"connection not accepted / reset\" or if this is not possible in nginx router configuration a 404 when accessing the domain over HTTPs if no certificate is set.\r\n\r\nI have not tested this but either this also will occur in deis/router (deis V2); or an updated nginx configuration should be relatively easily translatable to Deis V1 as the only significant change in router component (AFAIK) is how the config is generated and not the possibilities of the configuration (at least as far as HTTPs is concerned)"},"comment":{"url":"https://api.github.com/repos/deis/deis/issues/comments/255457349","html_url":"https://github.com/deis/deis/issues/5102#issuecomment-255457349","issue_url":"https://api.github.com/repos/deis/deis/issues/5102","id":255457349,"user":{"login":"bacongobbler","id":1360539,"avatar_url":"https://avatars.githubusercontent.com/u/1360539?v=3","gravatar_id":"","url":"https://api.github.com/users/bacongobbler","html_url":"https://github.com/bacongobbler","followers_url":"https://api.github.com/users/bacongobbler/followers","following_url":"https://api.github.com/users/bacongobbler/following{/other_user}","gists_url":"https://api.github.com/users/bacongobbler/gists{/gist_id}","starred_url":"https://api.github.com/users/bacongobbler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bacongobbler/subscriptions","organizations_url":"https://api.github.com/users/bacongobbler/orgs","repos_url":"https://api.github.com/users/bacongobbler/repos","events_url":"https://api.github.com/users/bacongobbler/events{/privacy}","received_events_url":"https://api.github.com/users/bacongobbler/received_events","type":"User","site_admin":false},"created_at":"2016-10-21T20:29:28Z","updated_at":"2016-10-21T20:29:28Z","body":"Sorry, I wasn't able to see anything out of the ordinary. I don't believe this is an issue on v2, just with v1."}}
{"actor":{"display_login":"bacongobbler"}}