{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corert/issues/1145","repository_url":"https://api.github.com/repos/dotnet/corert","labels_url":"https://api.github.com/repos/dotnet/corert/issues/1145/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corert/issues/1145/comments","events_url":"https://api.github.com/repos/dotnet/corert/issues/1145/events","html_url":"https://github.com/dotnet/corert/pull/1145","id":148585697,"number":1145,"title":"Revisited stack management and fix for issue #1110","user":{"login":"manu-silicon","id":13194660,"avatar_url":"https://avatars.githubusercontent.com/u/13194660?v=3","gravatar_id":"","url":"https://api.github.com/users/manu-silicon","html_url":"https://github.com/manu-silicon","followers_url":"https://api.github.com/users/manu-silicon/followers","following_url":"https://api.github.com/users/manu-silicon/following{/other_user}","gists_url":"https://api.github.com/users/manu-silicon/gists{/gist_id}","starred_url":"https://api.github.com/users/manu-silicon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manu-silicon/subscriptions","organizations_url":"https://api.github.com/users/manu-silicon/orgs","repos_url":"https://api.github.com/users/manu-silicon/repos","events_url":"https://api.github.com/users/manu-silicon/events{/privacy}","received_events_url":"https://api.github.com/users/manu-silicon/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/corert/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-04-15T07:52:36Z","updated_at":"2016-04-18T06:30:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/corert/pulls/1145","html_url":"https://github.com/dotnet/corert/pull/1145","diff_url":"https://github.com/dotnet/corert/pull/1145.diff","patch_url":"https://github.com/dotnet/corert/pull/1145.patch"},"body":"I've followed the suggestion I made for #1110 to change the evaluation stack. This is not final but before I continue I'd like feedback if this goes in the right direction.\r\n\r\nSo far what is not implemented is that now the stack contains object, not structs, so it means allocation and no optimization have been made to cache the allocation of stack entries.\r\n\r\nAs part of this, I've also removed the check against MSVC in the C++ code generation and added some macros to take into account the differences.\r\n\r\nI'm using Debug.Assert for internal sanity checks, but I saw some incoming commits using the Code Contract facilities which goes against the discussion we had on issue #320.\r\n\r\nThe new type VariableEntry is still too generic and could be split at least in two, one for just holding a variable/expression and one that also stores the ```Aux``` field."},"comment":{"url":"https://api.github.com/repos/dotnet/corert/issues/comments/211224961","html_url":"https://github.com/dotnet/corert/pull/1145#issuecomment-211224961","issue_url":"https://api.github.com/repos/dotnet/corert/issues/1145","id":211224961,"user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"created_at":"2016-04-18T06:30:45Z","updated_at":"2016-04-18T06:30:45Z","body":"> I'm not sure if there is much benefits in keeping them\r\n\r\nIt may look better to merge them into one."}}