{"action":"created","comment":{"url":"https://api.github.com/repos/caffe2/caffe2/pulls/comments/91779280","pull_request_review_id":12291905,"id":91779280,"diff_hunk":"@@ -1,41 +1,70 @@\n-# Excludes\n+# ---[ Excludes\n set(Caffe2_DIR_EXCLUDES\n-        \"/binaries\"\n-        \"/contrib\"\n-        \"/distributed\"\n-        \"/mpi\"\n-        \"/image\"","path":"caffe2/CMakeLists.txt","position":8,"original_position":8,"commit_id":"62ccc4cac23c4750dd134b427bc5b2b116449d97","original_commit_id":"62ccc4cac23c4750dd134b427bc5b2b116449d97","user":{"login":"slayton58","id":4992598,"avatar_url":"https://avatars.githubusercontent.com/u/4992598?v=3","gravatar_id":"","url":"https://api.github.com/users/slayton58","html_url":"https://github.com/slayton58","followers_url":"https://api.github.com/users/slayton58/followers","following_url":"https://api.github.com/users/slayton58/following{/other_user}","gists_url":"https://api.github.com/users/slayton58/gists{/gist_id}","starred_url":"https://api.github.com/users/slayton58/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slayton58/subscriptions","organizations_url":"https://api.github.com/users/slayton58/orgs","repos_url":"https://api.github.com/users/slayton58/repos","events_url":"https://api.github.com/users/slayton58/events{/privacy}","received_events_url":"https://api.github.com/users/slayton58/received_events","type":"User","site_admin":false},"body":"They shouldn't be excluded wholesale either. If you can give me a list of OMP-requiring files I can build an explicit exclusion list for them","created_at":"2016-12-09T19:30:35Z","updated_at":"2016-12-09T19:30:35Z","html_url":"https://github.com/caffe2/caffe2/pull/54#discussion_r91779280","pull_request_url":"https://api.github.com/repos/caffe2/caffe2/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/caffe2/caffe2/pulls/comments/91779280"},"html":{"href":"https://github.com/caffe2/caffe2/pull/54#discussion_r91779280"},"pull_request":{"href":"https://api.github.com/repos/caffe2/caffe2/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/caffe2/caffe2/pulls/54","id":96760236,"html_url":"https://github.com/caffe2/caffe2/pull/54","diff_url":"https://github.com/caffe2/caffe2/pull/54.diff","patch_url":"https://github.com/caffe2/caffe2/pull/54.patch","issue_url":"https://api.github.com/repos/caffe2/caffe2/issues/54","number":54,"state":"open","locked":false,"title":"Initial CMake building with deps","user":{"login":"slayton58","id":4992598,"avatar_url":"https://avatars.githubusercontent.com/u/4992598?v=3","gravatar_id":"","url":"https://api.github.com/users/slayton58","html_url":"https://github.com/slayton58","followers_url":"https://api.github.com/users/slayton58/followers","following_url":"https://api.github.com/users/slayton58/following{/other_user}","gists_url":"https://api.github.com/users/slayton58/gists{/gist_id}","starred_url":"https://api.github.com/users/slayton58/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slayton58/subscriptions","organizations_url":"https://api.github.com/users/slayton58/orgs","repos_url":"https://api.github.com/users/slayton58/repos","events_url":"https://api.github.com/users/slayton58/events{/privacy}","received_events_url":"https://api.github.com/users/slayton58/received_events","type":"User","site_admin":false},"body":"Based very heavily on Caffe1's cmake build system (and incorporating multiple of their files unchanged for now).\r\n\r\nBuilds a test binary using shared libs with some external dependency resolution (cuDNN, NCCL etc.)\r\n\r\nPushing so @bwasti and @Yangqing can see + build on it.","created_at":"2016-12-06T16:41:38Z","updated_at":"2016-12-09T19:30:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74027840115b6c01f7ceb42a3064e7250c614d9c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/caffe2/caffe2/pulls/54/commits","review_comments_url":"https://api.github.com/repos/caffe2/caffe2/pulls/54/comments","review_comment_url":"https://api.github.com/repos/caffe2/caffe2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caffe2/caffe2/issues/54/comments","statuses_url":"https://api.github.com/repos/caffe2/caffe2/statuses/62ccc4cac23c4750dd134b427bc5b2b116449d97","head":{"label":"slayton58:cmake","ref":"cmake","sha":"62ccc4cac23c4750dd134b427bc5b2b116449d97","user":{"login":"slayton58","id":4992598,"avatar_url":"https://avatars.githubusercontent.com/u/4992598?v=3","gravatar_id":"","url":"https://api.github.com/users/slayton58","html_url":"https://github.com/slayton58","followers_url":"https://api.github.com/users/slayton58/followers","following_url":"https://api.github.com/users/slayton58/following{/other_user}","gists_url":"https://api.github.com/users/slayton58/gists{/gist_id}","starred_url":"https://api.github.com/users/slayton58/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slayton58/subscriptions","organizations_url":"https://api.github.com/users/slayton58/orgs","repos_url":"https://api.github.com/users/slayton58/repos","events_url":"https://api.github.com/users/slayton58/events{/privacy}","received_events_url":"https://api.github.com/users/slayton58/received_events","type":"User","site_admin":false},"repo":{"id":41569197,"name":"caffe2","full_name":"slayton58/caffe2","owner":{"login":"slayton58","id":4992598,"avatar_url":"https://avatars.githubusercontent.com/u/4992598?v=3","gravatar_id":"","url":"https://api.github.com/users/slayton58","html_url":"https://github.com/slayton58","followers_url":"https://api.github.com/users/slayton58/followers","following_url":"https://api.github.com/users/slayton58/following{/other_user}","gists_url":"https://api.github.com/users/slayton58/gists{/gist_id}","starred_url":"https://api.github.com/users/slayton58/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slayton58/subscriptions","organizations_url":"https://api.github.com/users/slayton58/orgs","repos_url":"https://api.github.com/users/slayton58/repos","events_url":"https://api.github.com/users/slayton58/events{/privacy}","received_events_url":"https://api.github.com/users/slayton58/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slayton58/caffe2","description":"This is currently an experimental refactoring of Caffe.","fork":true,"url":"https://api.github.com/repos/slayton58/caffe2","forks_url":"https://api.github.com/repos/slayton58/caffe2/forks","keys_url":"https://api.github.com/repos/slayton58/caffe2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slayton58/caffe2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slayton58/caffe2/teams","hooks_url":"https://api.github.com/repos/slayton58/caffe2/hooks","issue_events_url":"https://api.github.com/repos/slayton58/caffe2/issues/events{/number}","events_url":"https://api.github.com/repos/slayton58/caffe2/events","assignees_url":"https://api.github.com/repos/slayton58/caffe2/assignees{/user}","branches_url":"https://api.github.com/repos/slayton58/caffe2/branches{/branch}","tags_url":"https://api.github.com/repos/slayton58/caffe2/tags","blobs_url":"https://api.github.com/repos/slayton58/caffe2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slayton58/caffe2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slayton58/caffe2/git/refs{/sha}","trees_url":"https://api.github.com/repos/slayton58/caffe2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slayton58/caffe2/statuses/{sha}","languages_url":"https://api.github.com/repos/slayton58/caffe2/languages","stargazers_url":"https://api.github.com/repos/slayton58/caffe2/stargazers","contributors_url":"https://api.github.com/repos/slayton58/caffe2/contributors","subscribers_url":"https://api.github.com/repos/slayton58/caffe2/subscribers","subscription_url":"https://api.github.com/repos/slayton58/caffe2/subscription","commits_url":"https://api.github.com/repos/slayton58/caffe2/commits{/sha}","git_commits_url":"https://api.github.com/repos/slayton58/caffe2/git/commits{/sha}","comments_url":"https://api.github.com/repos/slayton58/caffe2/comments{/number}","issue_comment_url":"https://api.github.com/repos/slayton58/caffe2/issues/comments{/number}","contents_url":"https://api.github.com/repos/slayton58/caffe2/contents/{+path}","compare_url":"https://api.github.com/repos/slayton58/caffe2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slayton58/caffe2/merges","archive_url":"https://api.github.com/repos/slayton58/caffe2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slayton58/caffe2/downloads","issues_url":"https://api.github.com/repos/slayton58/caffe2/issues{/number}","pulls_url":"https://api.github.com/repos/slayton58/caffe2/pulls{/number}","milestones_url":"https://api.github.com/repos/slayton58/caffe2/milestones{/number}","notifications_url":"https://api.github.com/repos/slayton58/caffe2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slayton58/caffe2/labels{/name}","releases_url":"https://api.github.com/repos/slayton58/caffe2/releases{/id}","deployments_url":"https://api.github.com/repos/slayton58/caffe2/deployments","created_at":"2015-08-28T21:06:44Z","updated_at":"2016-10-07T16:35:33Z","pushed_at":"2016-12-09T15:30:07Z","git_url":"git://github.com/slayton58/caffe2.git","ssh_url":"git@github.com:slayton58/caffe2.git","clone_url":"https://github.com/slayton58/caffe2.git","svn_url":"https://github.com/slayton58/caffe2","homepage":"","size":24440,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"caffe2:cmake","ref":"cmake","sha":"35a83ceb1b002c0b79c9763ed2039483d84e4610","user":{"login":"caffe2","id":13072719,"avatar_url":"https://avatars.githubusercontent.com/u/13072719?v=3","gravatar_id":"","url":"https://api.github.com/users/caffe2","html_url":"https://github.com/caffe2","followers_url":"https://api.github.com/users/caffe2/followers","following_url":"https://api.github.com/users/caffe2/following{/other_user}","gists_url":"https://api.github.com/users/caffe2/gists{/gist_id}","starred_url":"https://api.github.com/users/caffe2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caffe2/subscriptions","organizations_url":"https://api.github.com/users/caffe2/orgs","repos_url":"https://api.github.com/users/caffe2/repos","events_url":"https://api.github.com/users/caffe2/events{/privacy}","received_events_url":"https://api.github.com/users/caffe2/received_events","type":"Organization","site_admin":false},"repo":{"id":38066334,"name":"caffe2","full_name":"caffe2/caffe2","owner":{"login":"caffe2","id":13072719,"avatar_url":"https://avatars.githubusercontent.com/u/13072719?v=3","gravatar_id":"","url":"https://api.github.com/users/caffe2","html_url":"https://github.com/caffe2","followers_url":"https://api.github.com/users/caffe2/followers","following_url":"https://api.github.com/users/caffe2/following{/other_user}","gists_url":"https://api.github.com/users/caffe2/gists{/gist_id}","starred_url":"https://api.github.com/users/caffe2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caffe2/subscriptions","organizations_url":"https://api.github.com/users/caffe2/orgs","repos_url":"https://api.github.com/users/caffe2/repos","events_url":"https://api.github.com/users/caffe2/events{/privacy}","received_events_url":"https://api.github.com/users/caffe2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caffe2/caffe2","description":"This is currently an experimental refactoring of Caffe.","fork":false,"url":"https://api.github.com/repos/caffe2/caffe2","forks_url":"https://api.github.com/repos/caffe2/caffe2/forks","keys_url":"https://api.github.com/repos/caffe2/caffe2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caffe2/caffe2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caffe2/caffe2/teams","hooks_url":"https://api.github.com/repos/caffe2/caffe2/hooks","issue_events_url":"https://api.github.com/repos/caffe2/caffe2/issues/events{/number}","events_url":"https://api.github.com/repos/caffe2/caffe2/events","assignees_url":"https://api.github.com/repos/caffe2/caffe2/assignees{/user}","branches_url":"https://api.github.com/repos/caffe2/caffe2/branches{/branch}","tags_url":"https://api.github.com/repos/caffe2/caffe2/tags","blobs_url":"https://api.github.com/repos/caffe2/caffe2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caffe2/caffe2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caffe2/caffe2/git/refs{/sha}","trees_url":"https://api.github.com/repos/caffe2/caffe2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caffe2/caffe2/statuses/{sha}","languages_url":"https://api.github.com/repos/caffe2/caffe2/languages","stargazers_url":"https://api.github.com/repos/caffe2/caffe2/stargazers","contributors_url":"https://api.github.com/repos/caffe2/caffe2/contributors","subscribers_url":"https://api.github.com/repos/caffe2/caffe2/subscribers","subscription_url":"https://api.github.com/repos/caffe2/caffe2/subscription","commits_url":"https://api.github.com/repos/caffe2/caffe2/commits{/sha}","git_commits_url":"https://api.github.com/repos/caffe2/caffe2/git/commits{/sha}","comments_url":"https://api.github.com/repos/caffe2/caffe2/comments{/number}","issue_comment_url":"https://api.github.com/repos/caffe2/caffe2/issues/comments{/number}","contents_url":"https://api.github.com/repos/caffe2/caffe2/contents/{+path}","compare_url":"https://api.github.com/repos/caffe2/caffe2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caffe2/caffe2/merges","archive_url":"https://api.github.com/repos/caffe2/caffe2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caffe2/caffe2/downloads","issues_url":"https://api.github.com/repos/caffe2/caffe2/issues{/number}","pulls_url":"https://api.github.com/repos/caffe2/caffe2/pulls{/number}","milestones_url":"https://api.github.com/repos/caffe2/caffe2/milestones{/number}","notifications_url":"https://api.github.com/repos/caffe2/caffe2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caffe2/caffe2/labels{/name}","releases_url":"https://api.github.com/repos/caffe2/caffe2/releases{/id}","deployments_url":"https://api.github.com/repos/caffe2/caffe2/deployments","created_at":"2015-06-25T18:23:47Z","updated_at":"2016-12-09T02:50:47Z","pushed_at":"2016-12-09T15:30:07Z","git_url":"git://github.com/caffe2/caffe2.git","ssh_url":"git@github.com:caffe2/caffe2.git","clone_url":"https://github.com/caffe2/caffe2.git","svn_url":"https://github.com/caffe2/caffe2","homepage":"","size":25424,"stargazers_count":612,"watchers_count":612,"language":"Jupyter Notebook","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":177,"mirror_url":null,"open_issues_count":22,"forks":177,"open_issues":22,"watchers":612,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/caffe2/caffe2/pulls/54"},"html":{"href":"https://github.com/caffe2/caffe2/pull/54"},"issue":{"href":"https://api.github.com/repos/caffe2/caffe2/issues/54"},"comments":{"href":"https://api.github.com/repos/caffe2/caffe2/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/caffe2/caffe2/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/caffe2/caffe2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caffe2/caffe2/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/caffe2/caffe2/statuses/62ccc4cac23c4750dd134b427bc5b2b116449d97"}}}}
{"actor":{"display_login":"slayton58"}}