{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/68418409","id":68418409,"diff_hunk":"@@ -252,6 +252,16 @@ def validate_proposal_after_save(proposal)\n       validation_error I18n.t(\"barclamp.#{@bc_name}.validation.cisco_nexus\")\n     end\n \n+    # cisco_apic_ml2 mech driver needs also openvswitch mech driver\n+    if ml2_mechanism_drivers.include?(\"cisco_apic_ml2\") && ml2_mechanism_drivers.include?(\"openvswitch\")\n+      validation_error I18n.t(\"barclamp.#{@bc_name}.validation.cisco_apic_ml2\")\n+    end\n+\n+    # cisco_apic_ml2 mech driver needs opflex as the type_driver\n+    if ml2_mechanism_drivers.include? \"cisco_apic_ml2\" && ml2_type_drivers != [\"opflex\"]","path":"crowbar_framework/app/models/neutron_service.rb","position":42,"original_position":42,"commit_id":"a252fe6db0be13815643d8d4c54c5bfa161227ad","original_commit_id":"a252fe6db0be13815643d8d4c54c5bfa161227ad","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Lint/RequireParentheses: Use parentheses in the method call to avoid confusion about precedence.","created_at":"2016-06-24T15:48:27Z","updated_at":"2016-06-24T15:48:27Z","html_url":"https://github.com/crowbar/crowbar-openstack/pull/416#discussion_r68418409","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/416","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/68418409"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/416#discussion_r68418409"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/416"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/416","id":75130614,"html_url":"https://github.com/crowbar/crowbar-openstack/pull/416","diff_url":"https://github.com/crowbar/crowbar-openstack/pull/416.diff","patch_url":"https://github.com/crowbar/crowbar-openstack/pull/416.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/416","number":416,"state":"open","locked":false,"title":"[WIP]Support Cisco APIC Opflex integration","user":{"login":"mmnelemane","id":13483069,"avatar_url":"https://avatars.githubusercontent.com/u/13483069?v=3","gravatar_id":"","url":"https://api.github.com/users/mmnelemane","html_url":"https://github.com/mmnelemane","followers_url":"https://api.github.com/users/mmnelemane/followers","following_url":"https://api.github.com/users/mmnelemane/following{/other_user}","gists_url":"https://api.github.com/users/mmnelemane/gists{/gist_id}","starred_url":"https://api.github.com/users/mmnelemane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmnelemane/subscriptions","organizations_url":"https://api.github.com/users/mmnelemane/orgs","repos_url":"https://api.github.com/users/mmnelemane/repos","events_url":"https://api.github.com/users/mmnelemane/events{/privacy}","received_events_url":"https://api.github.com/users/mmnelemane/received_events","type":"User","site_admin":false},"body":"The changes here allow configuration of Cisco ACI as the ML2 backend for neutron. Cisco ACI uses Opflex to program the switches and expects the corresponding agents to be configured on the compute nodes. This PR does not do complete automation of the setup and expects some manual steps (Will be published in a separate PR) to be done on the compute nodes of the ACI before applying the barclamp to configure neutron services. ","created_at":"2016-06-24T15:24:04Z","updated_at":"2016-06-24T15:48:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2fc9fe714ffa469c2a1ca94597b1b7fe367c1c8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/416/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/416/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/416/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/a252fe6db0be13815643d8d4c54c5bfa161227ad","head":{"label":"mmnelemane:apic1","ref":"apic1","sha":"a252fe6db0be13815643d8d4c54c5bfa161227ad","user":{"login":"mmnelemane","id":13483069,"avatar_url":"https://avatars.githubusercontent.com/u/13483069?v=3","gravatar_id":"","url":"https://api.github.com/users/mmnelemane","html_url":"https://github.com/mmnelemane","followers_url":"https://api.github.com/users/mmnelemane/followers","following_url":"https://api.github.com/users/mmnelemane/following{/other_user}","gists_url":"https://api.github.com/users/mmnelemane/gists{/gist_id}","starred_url":"https://api.github.com/users/mmnelemane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmnelemane/subscriptions","organizations_url":"https://api.github.com/users/mmnelemane/orgs","repos_url":"https://api.github.com/users/mmnelemane/repos","events_url":"https://api.github.com/users/mmnelemane/events{/privacy}","received_events_url":"https://api.github.com/users/mmnelemane/received_events","type":"User","site_admin":false},"repo":{"id":45601858,"name":"crowbar-openstack","full_name":"mmnelemane/crowbar-openstack","owner":{"login":"mmnelemane","id":13483069,"avatar_url":"https://avatars.githubusercontent.com/u/13483069?v=3","gravatar_id":"","url":"https://api.github.com/users/mmnelemane","html_url":"https://github.com/mmnelemane","followers_url":"https://api.github.com/users/mmnelemane/followers","following_url":"https://api.github.com/users/mmnelemane/following{/other_user}","gists_url":"https://api.github.com/users/mmnelemane/gists{/gist_id}","starred_url":"https://api.github.com/users/mmnelemane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmnelemane/subscriptions","organizations_url":"https://api.github.com/users/mmnelemane/orgs","repos_url":"https://api.github.com/users/mmnelemane/repos","events_url":"https://api.github.com/users/mmnelemane/events{/privacy}","received_events_url":"https://api.github.com/users/mmnelemane/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmnelemane/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/mmnelemane/crowbar-openstack","forks_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/mmnelemane/crowbar-openstack/deployments","created_at":"2015-11-05T09:43:10Z","updated_at":"2016-01-20T16:50:50Z","pushed_at":"2016-06-24T15:48:21Z","git_url":"git://github.com/mmnelemane/crowbar-openstack.git","ssh_url":"git@github.com:mmnelemane/crowbar-openstack.git","clone_url":"https://github.com/mmnelemane/crowbar-openstack.git","svn_url":"https://github.com/mmnelemane/crowbar-openstack","homepage":null,"size":16901,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"8cd9c9b0f1ad200fb5347402709e6cc36788a94d","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006903,"name":"crowbar-openstack","full_name":"crowbar/crowbar-openstack","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-openstack","forks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/deployments","created_at":"2015-07-13T10:55:33Z","updated_at":"2016-01-11T12:29:07Z","pushed_at":"2016-06-24T15:48:21Z","git_url":"git://github.com/crowbar/crowbar-openstack.git","ssh_url":"git@github.com:crowbar/crowbar-openstack.git","clone_url":"https://github.com/crowbar/crowbar-openstack.git","svn_url":"https://github.com/crowbar/crowbar-openstack","homepage":null,"size":17160,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":33,"forks":29,"open_issues":33,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/416"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/416"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/416"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/416/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/416/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/416/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/a252fe6db0be13815643d8d4c54c5bfa161227ad"}}}}
{"actor":{"display_login":"houndci-bot"}}