{"push_id":1189363133,"size":609,"distinct_size":609,"ref":"refs/heads/master","head":"aed11fdc7c07e42fbaefb5110f5ee5eab2db5a3e","before":"b3efdb91f0c5ff959786eaebed7928100d67d49f","commits":[{"sha":"792f625bec5b6c1ab2629e0a6c353df8cc70920e","author":{"name":"Brian McManus","email":"0333d78c69c20e972e0cc29c516e596059dd043e@gmail.com"},"message":"Fixes Inflector#titleize to work with SafeBuffer\n\nThe way Inflector#titleize was implemented did not work properly when\ncalled on a SafeBuffer object. Using the global `$&` variable in the\ngsub resulted in calling capitalize on a nil object for reasons I still\ndo not fully understand. Removing the UNSAFE_STRING_METHODS override for\nthe gsub method in SafeBuffer \"fixed\" the bug but is obviously\nunacceptable.\n\nAn example of this is very easy to see in rails console:\n\n    ActiveSupport::SafeBuffer.new(\"my test\").titleize\n    > NoMethodError: undefined method `capitalize' for nil:NilClass\n\nUsing the non global version of gsub with a |match| arg passed to the\nblock fixes the problem. Again I do not quite understand why. I noticed\nthat other parts of Inflector were already using the standard block arg\nversion of gsub so I don't think it should be a problem to convert this\nmethod to using it as well.","distinct":true,"url":"https://api.github.com/repos/mrb/rails/commits/792f625bec5b6c1ab2629e0a6c353df8cc70920e"},{"sha":"a3ddd5f1572f6ebf95f4c0a789413ee1b2ecbab5","author":{"name":"Grzegorz Witek","email":"42b7fe265199706d6dece057c24cafa4ef611f2e@gmail.com"},"message":"Use correct timezone when parsing date in json\n\nFixes https://github.com/rails/rails/issues/22171\n\nTime specified in ISO 8601 format without `Z` should be considered as local\ntime, yet until now it was treated as UTC.\n\nThis commit fixes problem by parsing time using timezone specified in\napplication config.\n\nThe downside of this solution is performance hit (`Time.zone.parse` is ~ 1.6x\nslower than `Time.parse`), so maybe there's a better solution.","distinct":true,"url":"https://api.github.com/repos/mrb/rails/commits/a3ddd5f1572f6ebf95f4c0a789413ee1b2ecbab5"},{"sha":"941a735bbeafd9068bba8d29fa1c7c5371ad8ce3","author":{"name":"Naoto Koshikawa","email":"d506b2cb8fb53ac45a9dd0a44178d37f29a79a7e@ppworks.jp"},"message":"Skip comments when exec mysqldump","distinct":true,"url":"https://api.github.com/repos/mrb/rails/commits/941a735bbeafd9068bba8d29fa1c7c5371ad8ce3"},{"sha":"335fcc214a4b7ea5e10b3610cce6faea4262e4f6","author":{"name":"Genadi Samokovarov","email":"b7e19e8411f161f9f68b8ddf0100a3c29b45b61b@gmail.com"},"message":"Introduce Module#delegate_missing_to\n\nWhen building decorators, a common pattern may emerge:\n\n    class Partition\n      def initialize(first_event)\n        @events = [ first_event ]\n      end\n\n      def people\n        if @events.first.detail.people.any?\n          @events.collect { |e| Array(e.detail.people) }.flatten.uniq\n        else\n          @events.collect(&:creator).uniq\n        end\n      end\n\n      private\n        def respond_to_missing?(name, include_private = false)\n          @events.respond_to?(name, include_private)\n        end\n\n        def method_missing(method, *args, &block)\n          @events.send(method, *args, &block)\n        end\n    end\n\nWith `Module#delegate_missing_to`, the above is condensed to:\n\n    class Partition\n      delegate_missing_to :@events\n\n      def initialize(first_event)\n        @events = [ first_event ]\n      end\n\n      def people\n        if @events.first.detail.people.any?\n          @events.collect { |e| Array(e.detail.people) }.flatten.uniq\n        else\n          @events.collect(&:creator).uniq\n        end\n      end\n    end\n\nDavid suggested it in #23824.","distinct":true,"url":"https://api.github.com/repos/mrb/rails/commits/335fcc214a4b7ea5e10b3610cce6faea4262e4f6"},{"sha":"325ccb150c1fe28ccf4ebfc50e7bc17c0cc6bffa","author":{"name":"Mehmet Emin İNAÇ","email":"0d7591a6e9fc886a66305c0c55c21c19ec685c75@gmail.com"},"message":"Added some useful configuration options into configuring.md [ci skip]\n\nAdded information about inserting middlewares with indexes. I think this information useful. We can use indexes also for `insert_after` but the behavior is not same and this is not the right place to give full information about all configuration options.\nThe configuration for I18n fallbacks is important for production environment. Especially using different fallbacks for different locales.","distinct":true,"url":"https://api.github.com/repos/mrb/rails/commits/325ccb150c1fe28ccf4ebfc50e7bc17c0cc6bffa"},{"sha":"b50f5a5ac6fc554eaad3138cb42f678a41794771","author":{"name":"Matthew Draper","email":"4dc1fb8cebf1553ab7fd31206f1e48fe4714fa6e@trebex.net"},"message":"Don't inherit from Concurrent::CountDownLatch\n\nThat class mangles .new, which interferes with our deprecation warning.\n\nMore generally, it suggests we shouldn't be subclassing without a very\ngood reason, and avoiding one allocation doesn't seem to meet that\ncriteria.\n\nIn passing, recommend the simpler Concurrent::Event for the common\ncount=1 case.","distinct":true,"url":"https://api.github.com/repos/mrb/rails/commits/b50f5a5ac6fc554eaad3138cb42f678a41794771"},{"sha":"5ae26e1eeccef9e90850fff9b2395d41bed3462f","author":{"name":"Jon Moss","email":"b4a5ea001e047040e8c9075b67a268293138da2c@jonathanmoss.me"},"message":"Un-hide helper and assets options for controller generator\n\nThese options were hidden via 9b36cf0fa4cbdcb2e2072ef1b8179a98b13efce3,\nbut these options have tests written for them, and I believe that they\nare supposed to be public API.\n\nFixes #24168.","distinct":true,"url":"https://api.github.com/repos/mrb/rails/commits/5ae26e1eeccef9e90850fff9b2395d41bed3462f"},{"sha":"0d3cf26b673fafa950472aa4718de9a6630b45b4","author":{"name":"Vipul A M","email":"eed064c2f96e1e85a9ee3713d4325f5e37f2084b@gmail.com"},"message":"- Renamed NestedParametersTest to NestedParametersPermitTest, to indicate what we are actually testing in this file","distinct":true,"url":"https://api.github.com/repos/mrb/rails/commits/0d3cf26b673fafa950472aa4718de9a6630b45b4"},{"sha":"79f2f0b3cfd455a3cda98f8914a229ef0664dd3f","author":{"name":"Kathleen McMahon","email":"73bfa71f18383f42197106fcbcd4e1d72d2194e1@users.noreply.github.com"},"message":"Issue 22240: adds link to list of instance methods [ci skip]\n\nUpdate associations.rb\n\nUpdate associations.rb\n\nupdates link to instance methods [ci skip]","distinct":true,"url":"https://api.github.com/repos/mrb/rails/commits/79f2f0b3cfd455a3cda98f8914a229ef0664dd3f"},{"sha":"cfa1df4b07bee5b2bbcbf9edd2ac287b4fb23c18","author":{"name":"yuuji.yaginuma","email":"b1bc678335c01ebd6debb3ede5487e599c040f7b@gmail.com"},"message":"update record specified in key\n\n`#first_or_initialize` does not use attributes to data acquisition.\nTherefore, there is a possibility of updating the different record than the one\nspecified in the key, I think this is not expected behavior.","distinct":true,"url":"https://api.github.com/repos/mrb/rails/commits/cfa1df4b07bee5b2bbcbf9edd2ac287b4fb23c18"},{"sha":"e6ed3aaf437887bc25a1f715f21c5ca3ebbc966f","author":{"name":"Genadi Samokovarov","email":"b7e19e8411f161f9f68b8ddf0100a3c29b45b61b@gmail.com"},"message":"Always genererate models with ApplicationRecord parent\n\nCurrently, if we generate a model while\n`app/model/application_record.rb` isn't present, we'll end up with a\nmodel with an `ActiveRecord::Base` parent _and_ a newly generated\n`app/models/application_record.rb`.\n\nWhile the behavior for choosing an `ActiveRecord::Base` was chosen for\nan easier migration math to 5.0, generating the\n`app/model/application_record.rb` file kinda contradicts with it.\n\nIn any case, I think we should decide on a behavior and stick to it.\nHere, I'm changing the generated parent to always be `ApplicationRecord`\nand to always create `app/model/application_record.rb` if it doesn't\nexist.","distinct":true,"url":"https://api.github.com/repos/mrb/rails/commits/e6ed3aaf437887bc25a1f715f21c5ca3ebbc966f"},{"sha":"09a90bb6a06b1dafc9881651f585e8b40dda4227","author":{"name":"Ralin Chimev","email":"5c82d3a08bb68b9cc6b1f370cb1b437183dc3200@gmail.com"},"message":"PostgreSQL: Fix db:structure:load silent failure on SQL error\n\nThe command line flag \"-v ON_ERROR_STOP=1\" should be used when invoking psql to make sure errors are not suppressed.\n\nExample: psql -v ON_ERROR_STOP=1 -q -f awesome-file.sql my-app-db\n\nFixes #23818.","distinct":true,"url":"https://api.github.com/repos/mrb/rails/commits/09a90bb6a06b1dafc9881651f585e8b40dda4227"},{"sha":"c650341573243307fbe6f63702a9a4e4e289cfcd","author":{"name":"Jon Moss","email":"b4a5ea001e047040e8c9075b67a268293138da2c@jonathanmoss.me"},"message":"Fix ActiveRecord::LogSubscriber edge case\n\nIf an attribute was of the binary type, and also was a Hash, it would\npreviously not be logged, and instead raise an error saying that\n`bytesize` was not defined for the `attribute.value` (a `Hash`).\n\nNow, as is done on 4-2-stable, the attribute's database value is\n`bytesize`d, and then logged out to the terminal.\n\nReproduction script:\n\n```ruby\nrequire 'active_record'\nrequire 'minitest/autorun'\nrequire 'logger'\n\nActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:')\nActiveRecord::Base.logger = Logger.new(STDOUT)\n\nActiveRecord::Schema.define do\n  create_table :posts, force: true do |t|\n    t.binary :preferences\n  end\nend\n\nclass Post < ActiveRecord::Base\n  serialize :preferences\nend\n\nclass BugTest < Minitest::Test\n  def test_24955\n    Post.create!(preferences: {a: 1})\n\n    assert_equal 1, Post.count\n  end\nend\n```","distinct":true,"url":"https://api.github.com/repos/mrb/rails/commits/c650341573243307fbe6f63702a9a4e4e289cfcd"},{"sha":"2a71885a3f88562c57f81230d31518e5189c0dda","author":{"name":"Ryuta Kamizono","email":"eaaec3c25cb0fb33a7ca3dcb58ed29b01ce2c843@gmail.com"},"message":"Remove magic comment in generated `schema.rb`\n\nRails 5.0 has been dropped Ruby 1.9 support.\nI think no need magic comment anymore.","distinct":true,"url":"https://api.github.com/repos/mrb/rails/commits/2a71885a3f88562c57f81230d31518e5189c0dda"},{"sha":"f3ba0c1dd32821ad700b2784d160d1c161fb3125","author":{"name":"Matthew Wear","email":"a20cbe6581e25d2606bff389513565d989bda06b@newrelic.com"},"message":"Add ActiveSupport::Notifications hook to Broadcaster#broadcast\n\nThis addition of this notification hook will give users better visibility\ninto the messages being sent over the PubSub adapter.","distinct":true,"url":"https://api.github.com/repos/mrb/rails/commits/f3ba0c1dd32821ad700b2784d160d1c161fb3125"},{"sha":"f0f4cb2f64566020b6edd48e0a81fd744ffc2e4c","author":{"name":"yuuji.yaginuma","email":"b1bc678335c01ebd6debb3ede5487e599c040f7b@gmail.com"},"message":"generate mailer layout files if it does not already exist\n\nCurrently, if `ApplicationMailer` does not exist, it is generated when\nrun the mailer generator, but layouts files does not generate.\nHowever, because it uses the layouts in `ApplicationMailer`,\nlayouts are required.\n\nFollow up to #24161","distinct":true,"url":"https://api.github.com/repos/mrb/rails/commits/f0f4cb2f64566020b6edd48e0a81fd744ffc2e4c"},{"sha":"97877e1a23e10a2d134241a3f7a00a0652e966e0","author":{"name":"Vipul A M","email":"eed064c2f96e1e85a9ee3713d4325f5e37f2084b@gmail.com"},"message":"Add `ActiveRecord::Migration::CheckPending` to default middlewares for API Apps\n[ci skip]","distinct":true,"url":"https://api.github.com/repos/mrb/rails/commits/97877e1a23e10a2d134241a3f7a00a0652e966e0"},{"sha":"8a00a8c8e124a83cf9564e9b3f9683cf01556e04","author":{"name":"Vipul A M","email":"eed064c2f96e1e85a9ee3713d4325f5e37f2084b@gmail.com"},"message":"Change output genereated for middlewares on a new application. This has changed quite a bit after Executor middleware addition.\n[ci skip]","distinct":true,"url":"https://api.github.com/repos/mrb/rails/commits/8a00a8c8e124a83cf9564e9b3f9683cf01556e04"},{"sha":"80b23fedfb6dddc1885cace126d5caae8d232564","author":{"name":"Vipul A M","email":"eed064c2f96e1e85a9ee3713d4325f5e37f2084b@gmail.com"},"message":"The `ActiveRecord::ConnectionAdapters::ConnectionManagement` and `ActiveRecord::QueryCache` middlewares were removed with `Executor` addition on d3c9d808e3e242155a44fd2a89ef272cfade8fe8\nRemoves traces and reference of these from all places.\n[ci skip]","distinct":true,"url":"https://api.github.com/repos/mrb/rails/commits/80b23fedfb6dddc1885cace126d5caae8d232564"},{"sha":"e464b3cb3b32f968758f21549b17e4d0338e9dd0","author":{"name":"Vipul A M","email":"eed064c2f96e1e85a9ee3713d4325f5e37f2084b@gmail.com"},"message":"Pass over API Apps guide grammar. [ci skip]","distinct":true,"url":"https://api.github.com/repos/mrb/rails/commits/e464b3cb3b32f968758f21549b17e4d0338e9dd0"}]}
{"actor":{"display_login":"mrb"}}