{"action":"created","comment":{"url":"https://api.github.com/repos/libpd/libpd/pulls/comments/80367620","id":80367620,"diff_hunk":"@@ -24,7 +24,10 @@\n \n // define this to use C++11 std::mutex for locking\n #ifdef LIBPD_USE_STD_MUTEX\n-    #if __cplusplus < 201103L\n+\t#ifdef _WIN32\n+\t\t// __cplusplus is badly behaved in windows. just assume we have mutex","path":"cpp/PdBase.hpp","position":6,"original_position":6,"commit_id":"d2491d468117c99e2e52b4321ba36e258664faea","original_commit_id":"d2491d468117c99e2e52b4321ba36e258664faea","user":{"login":"danomatika","id":480637,"avatar_url":"https://avatars.githubusercontent.com/u/480637?v=3","gravatar_id":"","url":"https://api.github.com/users/danomatika","html_url":"https://github.com/danomatika","followers_url":"https://api.github.com/users/danomatika/followers","following_url":"https://api.github.com/users/danomatika/following{/other_user}","gists_url":"https://api.github.com/users/danomatika/gists{/gist_id}","starred_url":"https://api.github.com/users/danomatika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danomatika/subscriptions","organizations_url":"https://api.github.com/users/danomatika/orgs","repos_url":"https://api.github.com/users/danomatika/repos","events_url":"https://api.github.com/users/danomatika/events{/privacy}","received_events_url":"https://api.github.com/users/danomatika/received_events","type":"User","site_admin":false},"body":"Ok, I follow you. In looking around stack overflow, it seems like doing an explicit check will not always work since compilers can lie and not everything might be supported. In that case, it's better to leave the responsibility on the user and honor the define. I've decided to drop the _cplusplus check.","created_at":"2016-09-24T19:51:05Z","updated_at":"2016-09-24T19:51:05Z","html_url":"https://github.com/libpd/libpd/pull/100#discussion_r80367620","pull_request_url":"https://api.github.com/repos/libpd/libpd/pulls/100","_links":{"self":{"href":"https://api.github.com/repos/libpd/libpd/pulls/comments/80367620"},"html":{"href":"https://github.com/libpd/libpd/pull/100#discussion_r80367620"},"pull_request":{"href":"https://api.github.com/repos/libpd/libpd/pulls/100"}}},"pull_request":{"url":"https://api.github.com/repos/libpd/libpd/pulls/100","id":41981080,"html_url":"https://github.com/libpd/libpd/pull/100","diff_url":"https://github.com/libpd/libpd/pull/100.diff","patch_url":"https://github.com/libpd/libpd/pull/100.patch","issue_url":"https://api.github.com/repos/libpd/libpd/issues/100","number":100,"state":"open","locked":false,"title":"Fixed some cpplib build issues under Windows/Mingw.","user":{"login":"eigenbom","id":1103761,"avatar_url":"https://avatars.githubusercontent.com/u/1103761?v=3","gravatar_id":"","url":"https://api.github.com/users/eigenbom","html_url":"https://github.com/eigenbom","followers_url":"https://api.github.com/users/eigenbom/followers","following_url":"https://api.github.com/users/eigenbom/following{/other_user}","gists_url":"https://api.github.com/users/eigenbom/gists{/gist_id}","starred_url":"https://api.github.com/users/eigenbom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eigenbom/subscriptions","organizations_url":"https://api.github.com/users/eigenbom/orgs","repos_url":"https://api.github.com/users/eigenbom/repos","events_url":"https://api.github.com/users/eigenbom/events{/privacy}","received_events_url":"https://api.github.com/users/eigenbom/received_events","type":"User","site_admin":false},"body":"Symbols weren't exporting for the cpplib under Windows/Mingw, so I patched the Makefile.\r\n\r\nAlso patched the makefiles for two samples to get them running under Windows/Mingw. \r\n> gcc version 5.2.0 (Rev3, Built by MSYS2 project)","created_at":"2015-08-10T01:17:24Z","updated_at":"2016-09-24T19:51:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24fe9fc97d7f2a21f17e40acc6c99ce6b6d7be9e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/libpd/libpd/pulls/100/commits","review_comments_url":"https://api.github.com/repos/libpd/libpd/pulls/100/comments","review_comment_url":"https://api.github.com/repos/libpd/libpd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libpd/libpd/issues/100/comments","statuses_url":"https://api.github.com/repos/libpd/libpd/statuses/d2491d468117c99e2e52b4321ba36e258664faea","head":{"label":"eigenbom:master","ref":"master","sha":"d2491d468117c99e2e52b4321ba36e258664faea","user":{"login":"eigenbom","id":1103761,"avatar_url":"https://avatars.githubusercontent.com/u/1103761?v=3","gravatar_id":"","url":"https://api.github.com/users/eigenbom","html_url":"https://github.com/eigenbom","followers_url":"https://api.github.com/users/eigenbom/followers","following_url":"https://api.github.com/users/eigenbom/following{/other_user}","gists_url":"https://api.github.com/users/eigenbom/gists{/gist_id}","starred_url":"https://api.github.com/users/eigenbom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eigenbom/subscriptions","organizations_url":"https://api.github.com/users/eigenbom/orgs","repos_url":"https://api.github.com/users/eigenbom/repos","events_url":"https://api.github.com/users/eigenbom/events{/privacy}","received_events_url":"https://api.github.com/users/eigenbom/received_events","type":"User","site_admin":false},"repo":{"id":40456379,"name":"libpd","full_name":"eigenbom/libpd","owner":{"login":"eigenbom","id":1103761,"avatar_url":"https://avatars.githubusercontent.com/u/1103761?v=3","gravatar_id":"","url":"https://api.github.com/users/eigenbom","html_url":"https://github.com/eigenbom","followers_url":"https://api.github.com/users/eigenbom/followers","following_url":"https://api.github.com/users/eigenbom/following{/other_user}","gists_url":"https://api.github.com/users/eigenbom/gists{/gist_id}","starred_url":"https://api.github.com/users/eigenbom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eigenbom/subscriptions","organizations_url":"https://api.github.com/users/eigenbom/orgs","repos_url":"https://api.github.com/users/eigenbom/repos","events_url":"https://api.github.com/users/eigenbom/events{/privacy}","received_events_url":"https://api.github.com/users/eigenbom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eigenbom/libpd","description":"Pure Data embeddable audio synthesis library","fork":true,"url":"https://api.github.com/repos/eigenbom/libpd","forks_url":"https://api.github.com/repos/eigenbom/libpd/forks","keys_url":"https://api.github.com/repos/eigenbom/libpd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eigenbom/libpd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eigenbom/libpd/teams","hooks_url":"https://api.github.com/repos/eigenbom/libpd/hooks","issue_events_url":"https://api.github.com/repos/eigenbom/libpd/issues/events{/number}","events_url":"https://api.github.com/repos/eigenbom/libpd/events","assignees_url":"https://api.github.com/repos/eigenbom/libpd/assignees{/user}","branches_url":"https://api.github.com/repos/eigenbom/libpd/branches{/branch}","tags_url":"https://api.github.com/repos/eigenbom/libpd/tags","blobs_url":"https://api.github.com/repos/eigenbom/libpd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eigenbom/libpd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eigenbom/libpd/git/refs{/sha}","trees_url":"https://api.github.com/repos/eigenbom/libpd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eigenbom/libpd/statuses/{sha}","languages_url":"https://api.github.com/repos/eigenbom/libpd/languages","stargazers_url":"https://api.github.com/repos/eigenbom/libpd/stargazers","contributors_url":"https://api.github.com/repos/eigenbom/libpd/contributors","subscribers_url":"https://api.github.com/repos/eigenbom/libpd/subscribers","subscription_url":"https://api.github.com/repos/eigenbom/libpd/subscription","commits_url":"https://api.github.com/repos/eigenbom/libpd/commits{/sha}","git_commits_url":"https://api.github.com/repos/eigenbom/libpd/git/commits{/sha}","comments_url":"https://api.github.com/repos/eigenbom/libpd/comments{/number}","issue_comment_url":"https://api.github.com/repos/eigenbom/libpd/issues/comments{/number}","contents_url":"https://api.github.com/repos/eigenbom/libpd/contents/{+path}","compare_url":"https://api.github.com/repos/eigenbom/libpd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eigenbom/libpd/merges","archive_url":"https://api.github.com/repos/eigenbom/libpd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eigenbom/libpd/downloads","issues_url":"https://api.github.com/repos/eigenbom/libpd/issues{/number}","pulls_url":"https://api.github.com/repos/eigenbom/libpd/pulls{/number}","milestones_url":"https://api.github.com/repos/eigenbom/libpd/milestones{/number}","notifications_url":"https://api.github.com/repos/eigenbom/libpd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eigenbom/libpd/labels{/name}","releases_url":"https://api.github.com/repos/eigenbom/libpd/releases{/id}","deployments_url":"https://api.github.com/repos/eigenbom/libpd/deployments","created_at":"2015-08-10T01:06:03Z","updated_at":"2015-08-10T01:06:04Z","pushed_at":"2015-08-10T06:12:38Z","git_url":"git://github.com/eigenbom/libpd.git","ssh_url":"git@github.com:eigenbom/libpd.git","clone_url":"https://github.com/eigenbom/libpd.git","svn_url":"https://github.com/eigenbom/libpd","homepage":"http://libpd.cc","size":7436,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libpd:master","ref":"master","sha":"7fe8c090b459531c48888f149b801f9cd25d93bc","user":{"login":"libpd","id":1118297,"avatar_url":"https://avatars.githubusercontent.com/u/1118297?v=3","gravatar_id":"","url":"https://api.github.com/users/libpd","html_url":"https://github.com/libpd","followers_url":"https://api.github.com/users/libpd/followers","following_url":"https://api.github.com/users/libpd/following{/other_user}","gists_url":"https://api.github.com/users/libpd/gists{/gist_id}","starred_url":"https://api.github.com/users/libpd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libpd/subscriptions","organizations_url":"https://api.github.com/users/libpd/orgs","repos_url":"https://api.github.com/users/libpd/repos","events_url":"https://api.github.com/users/libpd/events{/privacy}","received_events_url":"https://api.github.com/users/libpd/received_events","type":"Organization","site_admin":false},"repo":{"id":2767832,"name":"libpd","full_name":"libpd/libpd","owner":{"login":"libpd","id":1118297,"avatar_url":"https://avatars.githubusercontent.com/u/1118297?v=3","gravatar_id":"","url":"https://api.github.com/users/libpd","html_url":"https://github.com/libpd","followers_url":"https://api.github.com/users/libpd/followers","following_url":"https://api.github.com/users/libpd/following{/other_user}","gists_url":"https://api.github.com/users/libpd/gists{/gist_id}","starred_url":"https://api.github.com/users/libpd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libpd/subscriptions","organizations_url":"https://api.github.com/users/libpd/orgs","repos_url":"https://api.github.com/users/libpd/repos","events_url":"https://api.github.com/users/libpd/events{/privacy}","received_events_url":"https://api.github.com/users/libpd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libpd/libpd","description":"Pure Data embeddable audio synthesis library","fork":false,"url":"https://api.github.com/repos/libpd/libpd","forks_url":"https://api.github.com/repos/libpd/libpd/forks","keys_url":"https://api.github.com/repos/libpd/libpd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libpd/libpd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libpd/libpd/teams","hooks_url":"https://api.github.com/repos/libpd/libpd/hooks","issue_events_url":"https://api.github.com/repos/libpd/libpd/issues/events{/number}","events_url":"https://api.github.com/repos/libpd/libpd/events","assignees_url":"https://api.github.com/repos/libpd/libpd/assignees{/user}","branches_url":"https://api.github.com/repos/libpd/libpd/branches{/branch}","tags_url":"https://api.github.com/repos/libpd/libpd/tags","blobs_url":"https://api.github.com/repos/libpd/libpd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libpd/libpd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libpd/libpd/git/refs{/sha}","trees_url":"https://api.github.com/repos/libpd/libpd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libpd/libpd/statuses/{sha}","languages_url":"https://api.github.com/repos/libpd/libpd/languages","stargazers_url":"https://api.github.com/repos/libpd/libpd/stargazers","contributors_url":"https://api.github.com/repos/libpd/libpd/contributors","subscribers_url":"https://api.github.com/repos/libpd/libpd/subscribers","subscription_url":"https://api.github.com/repos/libpd/libpd/subscription","commits_url":"https://api.github.com/repos/libpd/libpd/commits{/sha}","git_commits_url":"https://api.github.com/repos/libpd/libpd/git/commits{/sha}","comments_url":"https://api.github.com/repos/libpd/libpd/comments{/number}","issue_comment_url":"https://api.github.com/repos/libpd/libpd/issues/comments{/number}","contents_url":"https://api.github.com/repos/libpd/libpd/contents/{+path}","compare_url":"https://api.github.com/repos/libpd/libpd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libpd/libpd/merges","archive_url":"https://api.github.com/repos/libpd/libpd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libpd/libpd/downloads","issues_url":"https://api.github.com/repos/libpd/libpd/issues{/number}","pulls_url":"https://api.github.com/repos/libpd/libpd/pulls{/number}","milestones_url":"https://api.github.com/repos/libpd/libpd/milestones{/number}","notifications_url":"https://api.github.com/repos/libpd/libpd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libpd/libpd/labels{/name}","releases_url":"https://api.github.com/repos/libpd/libpd/releases{/id}","deployments_url":"https://api.github.com/repos/libpd/libpd/deployments","created_at":"2011-11-13T19:16:13Z","updated_at":"2016-09-20T02:22:41Z","pushed_at":"2016-09-24T19:01:33Z","git_url":"git://github.com/libpd/libpd.git","ssh_url":"git@github.com:libpd/libpd.git","clone_url":"https://github.com/libpd/libpd.git","svn_url":"https://github.com/libpd/libpd","homepage":"http://libpd.cc","size":26897,"stargazers_count":571,"watchers_count":571,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":175,"mirror_url":null,"open_issues_count":22,"forks":175,"open_issues":22,"watchers":571,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libpd/libpd/pulls/100"},"html":{"href":"https://github.com/libpd/libpd/pull/100"},"issue":{"href":"https://api.github.com/repos/libpd/libpd/issues/100"},"comments":{"href":"https://api.github.com/repos/libpd/libpd/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/libpd/libpd/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/libpd/libpd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libpd/libpd/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/libpd/libpd/statuses/d2491d468117c99e2e52b4321ba36e258664faea"}}}}
{"actor":{"display_login":"danomatika"}}