{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/66241085","id":66241085,"diff_hunk":"@@ -256,16 +256,31 @@ public int hashCode() {\n      */\n     private class RecordingMap<V> extends HashMap<String, V> {\n \n-        RecordingMap() {}\n+        private final String prefix;\n+\n+        RecordingMap() {\n+            this(\"\");\n+        }\n+\n+        RecordingMap(String prefix) {\n+            this.prefix = prefix;\n+        }\n \n         RecordingMap(Map<String, ? extends V> m) {\n+            this(m, \"\");\n+        }\n+\n+        RecordingMap(Map<String, ? extends V> m, String prefix) {\n             super(m);\n+            this.prefix = prefix;\n         }\n \n         @Override\n         public V get(Object key) {\n-            if (key instanceof String)\n-                ignore((String) key);\n+            if (key instanceof String) {\n+                String keyWithPrefix = prefix + key;","path":"clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java","position":56,"original_position":56,"commit_id":"8502a21efc3a76929adefccd696e6e140bd3de83","original_commit_id":"8502a21efc3a76929adefccd696e6e140bd3de83","user":{"login":"ijuma","id":24747,"avatar_url":"https://avatars.githubusercontent.com/u/24747?v=3","gravatar_id":"","url":"https://api.github.com/users/ijuma","html_url":"https://github.com/ijuma","followers_url":"https://api.github.com/users/ijuma/followers","following_url":"https://api.github.com/users/ijuma/following{/other_user}","gists_url":"https://api.github.com/users/ijuma/gists{/gist_id}","starred_url":"https://api.github.com/users/ijuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijuma/subscriptions","organizations_url":"https://api.github.com/users/ijuma/orgs","repos_url":"https://api.github.com/users/ijuma/repos","events_url":"https://api.github.com/users/ijuma/events{/privacy}","received_events_url":"https://api.github.com/users/ijuma/received_events","type":"User","site_admin":false},"body":"We should probably avoid string concatenation if `prefix.isEmpty` (since it's the common case).","created_at":"2016-06-08T11:52:59Z","updated_at":"2016-06-08T11:52:59Z","html_url":"https://github.com/apache/kafka/pull/1479#discussion_r66241085","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/1479","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/66241085"},"html":{"href":"https://github.com/apache/kafka/pull/1479#discussion_r66241085"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/1479"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/1479","id":72903094,"html_url":"https://github.com/apache/kafka/pull/1479","diff_url":"https://github.com/apache/kafka/pull/1479.diff","patch_url":"https://github.com/apache/kafka/pull/1479.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/1479","number":1479,"state":"open","locked":false,"title":"KAFKA-3711: Ensure a RecordingMap is passed to configured instances","user":{"login":"jklukas","id":691060,"avatar_url":"https://avatars.githubusercontent.com/u/691060?v=3","gravatar_id":"","url":"https://api.github.com/users/jklukas","html_url":"https://github.com/jklukas","followers_url":"https://api.github.com/users/jklukas/followers","following_url":"https://api.github.com/users/jklukas/following{/other_user}","gists_url":"https://api.github.com/users/jklukas/gists{/gist_id}","starred_url":"https://api.github.com/users/jklukas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklukas/subscriptions","organizations_url":"https://api.github.com/users/jklukas/orgs","repos_url":"https://api.github.com/users/jklukas/repos","events_url":"https://api.github.com/users/jklukas/events{/privacy}","received_events_url":"https://api.github.com/users/jklukas/received_events","type":"User","site_admin":false},"body":"See https://issues.apache.org/jira/browse/KAFKA-3711\r\n\r\nI've tested locally that this change does indeed resolve the warning I mention in the ticket:\r\n```\r\norg.apache.kafka.clients.consumer.ConsumerConfig: The configuration metric.dropwizard.registry = kafka-metrics was supplied but isn't a known config.\r\n```\r\nwhere `metric.dropwizard.registry` is a configuration value defined in a custom `MetricReporter` (https://github.com/SimpleFinance/kafka-dropwizard-reporter).\r\n\r\nWith this change, the above warning no longer appears, as @ewencp predicted.\r\n\r\nThis contribution is my original work and I license the work to the project under the project's open source license.","created_at":"2016-06-07T16:03:33Z","updated_at":"2016-06-08T11:52:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cd5c2ef2685fa14daa53fddbbbeb412dc609fa0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/1479/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/1479/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/1479/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/8502a21efc3a76929adefccd696e6e140bd3de83","head":{"label":"jklukas:abstractconfig-originals","ref":"abstractconfig-originals","sha":"8502a21efc3a76929adefccd696e6e140bd3de83","user":{"login":"jklukas","id":691060,"avatar_url":"https://avatars.githubusercontent.com/u/691060?v=3","gravatar_id":"","url":"https://api.github.com/users/jklukas","html_url":"https://github.com/jklukas","followers_url":"https://api.github.com/users/jklukas/followers","following_url":"https://api.github.com/users/jklukas/following{/other_user}","gists_url":"https://api.github.com/users/jklukas/gists{/gist_id}","starred_url":"https://api.github.com/users/jklukas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklukas/subscriptions","organizations_url":"https://api.github.com/users/jklukas/orgs","repos_url":"https://api.github.com/users/jklukas/repos","events_url":"https://api.github.com/users/jklukas/events{/privacy}","received_events_url":"https://api.github.com/users/jklukas/received_events","type":"User","site_admin":false},"repo":{"id":57044447,"name":"kafka","full_name":"jklukas/kafka","owner":{"login":"jklukas","id":691060,"avatar_url":"https://avatars.githubusercontent.com/u/691060?v=3","gravatar_id":"","url":"https://api.github.com/users/jklukas","html_url":"https://github.com/jklukas","followers_url":"https://api.github.com/users/jklukas/followers","following_url":"https://api.github.com/users/jklukas/following{/other_user}","gists_url":"https://api.github.com/users/jklukas/gists{/gist_id}","starred_url":"https://api.github.com/users/jklukas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklukas/subscriptions","organizations_url":"https://api.github.com/users/jklukas/orgs","repos_url":"https://api.github.com/users/jklukas/repos","events_url":"https://api.github.com/users/jklukas/events{/privacy}","received_events_url":"https://api.github.com/users/jklukas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jklukas/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/jklukas/kafka","forks_url":"https://api.github.com/repos/jklukas/kafka/forks","keys_url":"https://api.github.com/repos/jklukas/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jklukas/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jklukas/kafka/teams","hooks_url":"https://api.github.com/repos/jklukas/kafka/hooks","issue_events_url":"https://api.github.com/repos/jklukas/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/jklukas/kafka/events","assignees_url":"https://api.github.com/repos/jklukas/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/jklukas/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/jklukas/kafka/tags","blobs_url":"https://api.github.com/repos/jklukas/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jklukas/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jklukas/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/jklukas/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jklukas/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/jklukas/kafka/languages","stargazers_url":"https://api.github.com/repos/jklukas/kafka/stargazers","contributors_url":"https://api.github.com/repos/jklukas/kafka/contributors","subscribers_url":"https://api.github.com/repos/jklukas/kafka/subscribers","subscription_url":"https://api.github.com/repos/jklukas/kafka/subscription","commits_url":"https://api.github.com/repos/jklukas/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/jklukas/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/jklukas/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/jklukas/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/jklukas/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/jklukas/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jklukas/kafka/merges","archive_url":"https://api.github.com/repos/jklukas/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jklukas/kafka/downloads","issues_url":"https://api.github.com/repos/jklukas/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/jklukas/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/jklukas/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/jklukas/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jklukas/kafka/labels{/name}","releases_url":"https://api.github.com/repos/jklukas/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/jklukas/kafka/deployments","created_at":"2016-04-25T13:36:09Z","updated_at":"2016-04-25T13:36:14Z","pushed_at":"2016-06-08T06:43:22Z","git_url":"git://github.com/jklukas/kafka.git","ssh_url":"git@github.com:jklukas/kafka.git","clone_url":"https://github.com/jklukas/kafka.git","svn_url":"https://github.com/jklukas/kafka","homepage":null,"size":31486,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"06a57cf19c45e82245ada886ea885087ce60ab80","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-06-08T07:17:38Z","pushed_at":"2016-06-08T06:43:22Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":43365,"stargazers_count":3215,"watchers_count":3215,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1975,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":181,"forks":1975,"open_issues":181,"watchers":3215,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/1479"},"html":{"href":"https://github.com/apache/kafka/pull/1479"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/1479"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/1479/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/1479/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/1479/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/8502a21efc3a76929adefccd696e6e140bd3de83"}}}}
{"actor":{"display_login":"ijuma"}}