{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls/comments/68153642","id":68153642,"diff_hunk":"@@ -69,6 +69,10 @@ module.exports = function(ctx, startingSelectedIds) {\n     });\n   };\n \n+  var emitModify = function() {\n+    ctx.map.fire('draw.modified', { features });","path":"src/modes/simple_select.js","position":5,"original_position":5,"commit_id":"e43fa202004df621e1c1280c0e00414703283646","original_commit_id":"e43fa202004df621e1c1280c0e00414703283646","user":{"login":"mcwhittemore","id":1551510,"avatar_url":"https://avatars.githubusercontent.com/u/1551510?v=3","gravatar_id":"","url":"https://api.github.com/users/mcwhittemore","html_url":"https://github.com/mcwhittemore","followers_url":"https://api.github.com/users/mcwhittemore/followers","following_url":"https://api.github.com/users/mcwhittemore/following{/other_user}","gists_url":"https://api.github.com/users/mcwhittemore/gists{/gist_id}","starred_url":"https://api.github.com/users/mcwhittemore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcwhittemore/subscriptions","organizations_url":"https://api.github.com/users/mcwhittemore/orgs","repos_url":"https://api.github.com/users/mcwhittemore/repos","events_url":"https://api.github.com/users/mcwhittemore/events{/privacy}","received_events_url":"https://api.github.com/users/mcwhittemore/received_events","type":"User","site_admin":false},"body":"`features` should be dropped from this file and we should use what is currently selected.","created_at":"2016-06-22T23:28:25Z","updated_at":"2016-06-22T23:28:25Z","html_url":"https://github.com/mapbox/mapbox-gl-draw/pull/396#discussion_r68153642","pull_request_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls/396","_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls/comments/68153642"},"html":{"href":"https://github.com/mapbox/mapbox-gl-draw/pull/396#discussion_r68153642"},"pull_request":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls/396"}}},"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls/396","id":74868190,"html_url":"https://github.com/mapbox/mapbox-gl-draw/pull/396","diff_url":"https://github.com/mapbox/mapbox-gl-draw/pull/396.diff","patch_url":"https://github.com/mapbox/mapbox-gl-draw/pull/396.patch","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/issues/396","number":396,"state":"open","locked":false,"title":"Change modified event firing; closes #393","user":{"login":"davidtheclark","id":628431,"avatar_url":"https://avatars.githubusercontent.com/u/628431?v=3","gravatar_id":"","url":"https://api.github.com/users/davidtheclark","html_url":"https://github.com/davidtheclark","followers_url":"https://api.github.com/users/davidtheclark/followers","following_url":"https://api.github.com/users/davidtheclark/following{/other_user}","gists_url":"https://api.github.com/users/davidtheclark/gists{/gist_id}","starred_url":"https://api.github.com/users/davidtheclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidtheclark/subscriptions","organizations_url":"https://api.github.com/users/davidtheclark/orgs","repos_url":"https://api.github.com/users/davidtheclark/repos","events_url":"https://api.github.com/users/davidtheclark/events{/privacy}","received_events_url":"https://api.github.com/users/davidtheclark/received_events","type":"User","site_admin":false},"body":"Refs #393 and #395.\r\n\r\nThis seemed to me like a straightforward way to make the `draw.modified` event more meaningful, and it addresses all the cases in https://github.com/mapbox/mapbox-gl-draw/issues/393#issuecomment-227880372: it *only* fires: \r\n\r\n- When you finish moving a feature.\r\n- When you finish moving a vertex. \r\n- When you delete a vertex.\r\n\r\nTests are failing because there are some `draw.modified` event tests that want the event to fire a lot more often than it would after this modification.\r\n\r\nWhat do you think @mcwhittemore , @ghoshkaj , @tmcw ?","created_at":"2016-06-22T22:23:56Z","updated_at":"2016-06-22T23:28:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e32372547b8c773b268561ba1c99efc32c884e93","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls/396/commits","review_comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls/396/comments","review_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/issues/396/comments","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/statuses/e43fa202004df621e1c1280c0e00414703283646","head":{"label":"mapbox:draw-modified-fixes","ref":"draw-modified-fixes","sha":"e43fa202004df621e1c1280c0e00414703283646","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":29943859,"name":"mapbox-gl-draw","full_name":"mapbox/mapbox-gl-draw","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-gl-draw","description":"Draw tools for mapbox-gl-js","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-gl-draw","forks_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/deployments","created_at":"2015-01-28T01:12:21Z","updated_at":"2016-06-13T15:21:43Z","pushed_at":"2016-06-22T22:23:56Z","git_url":"git://github.com/mapbox/mapbox-gl-draw.git","ssh_url":"git@github.com:mapbox/mapbox-gl-draw.git","clone_url":"https://github.com/mapbox/mapbox-gl-draw.git","svn_url":"https://github.com/mapbox/mapbox-gl-draw","homepage":"","size":4132,"stargazers_count":54,"watchers_count":54,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":34,"forks":19,"open_issues":34,"watchers":54,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"f346c0b3b5afe812cde7f16fdae635cd37a10460","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":29943859,"name":"mapbox-gl-draw","full_name":"mapbox/mapbox-gl-draw","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-gl-draw","description":"Draw tools for mapbox-gl-js","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-gl-draw","forks_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-gl-draw/deployments","created_at":"2015-01-28T01:12:21Z","updated_at":"2016-06-13T15:21:43Z","pushed_at":"2016-06-22T22:23:56Z","git_url":"git://github.com/mapbox/mapbox-gl-draw.git","ssh_url":"git@github.com:mapbox/mapbox-gl-draw.git","clone_url":"https://github.com/mapbox/mapbox-gl-draw.git","svn_url":"https://github.com/mapbox/mapbox-gl-draw","homepage":"","size":4132,"stargazers_count":54,"watchers_count":54,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":34,"forks":19,"open_issues":34,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls/396"},"html":{"href":"https://github.com/mapbox/mapbox-gl-draw/pull/396"},"issue":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-draw/issues/396"},"comments":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-draw/issues/396/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls/396/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-draw/pulls/396/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-draw/statuses/e43fa202004df621e1c1280c0e00414703283646"}}}}
{"actor":{"display_login":"mcwhittemore"}}