{"action":"created","issue":{"url":"https://api.github.com/repos/algolia/react-element-to-jsx-string/issues/26","repository_url":"https://api.github.com/repos/algolia/react-element-to-jsx-string","labels_url":"https://api.github.com/repos/algolia/react-element-to-jsx-string/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/algolia/react-element-to-jsx-string/issues/26/comments","events_url":"https://api.github.com/repos/algolia/react-element-to-jsx-string/issues/26/events","html_url":"https://github.com/algolia/react-element-to-jsx-string/pull/26","id":155054644,"number":26,"title":"allow omitting boolean attributes","user":{"login":"p0wl","id":596578,"avatar_url":"https://avatars.githubusercontent.com/u/596578?v=3","gravatar_id":"","url":"https://api.github.com/users/p0wl","html_url":"https://github.com/p0wl","followers_url":"https://api.github.com/users/p0wl/followers","following_url":"https://api.github.com/users/p0wl/following{/other_user}","gists_url":"https://api.github.com/users/p0wl/gists{/gist_id}","starred_url":"https://api.github.com/users/p0wl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p0wl/subscriptions","organizations_url":"https://api.github.com/users/p0wl/orgs","repos_url":"https://api.github.com/users/p0wl/repos","events_url":"https://api.github.com/users/p0wl/events{/privacy}","received_events_url":"https://api.github.com/users/p0wl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-16T15:30:59Z","updated_at":"2016-05-25T14:16:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/algolia/react-element-to-jsx-string/pulls/26","html_url":"https://github.com/algolia/react-element-to-jsx-string/pull/26","diff_url":"https://github.com/algolia/react-element-to-jsx-string/pull/26.diff","patch_url":"https://github.com/algolia/react-element-to-jsx-string/pull/26.patch"},"body":"according to https://facebook.github.io/react/docs/jsx-in-depth.html#boolean-attributes it is ok to omit the value of boolean attributes if the value is true. Attributes with value false are unnecessary.\r\n\r\nThis PR allows (via options: {omitBools: true}) that\r\n\r\n```\r\n<Button primary={true}>A Button</Button>\r\n```\r\n\r\nbecomes\r\n\r\n```\r\n<Button primary>A Button</Button>\r\n```\r\n\r\nI think this is a good idea in general, but I thought I'll create a option for this, as this is unexpected behavior for existing consumers. What do you think? Should the short syntax be the default?"},"comment":{"url":"https://api.github.com/repos/algolia/react-element-to-jsx-string/issues/comments/221589934","html_url":"https://github.com/algolia/react-element-to-jsx-string/pull/26#issuecomment-221589934","issue_url":"https://api.github.com/repos/algolia/react-element-to-jsx-string/issues/26","id":221589934,"user":{"login":"p0wl","id":596578,"avatar_url":"https://avatars.githubusercontent.com/u/596578?v=3","gravatar_id":"","url":"https://api.github.com/users/p0wl","html_url":"https://github.com/p0wl","followers_url":"https://api.github.com/users/p0wl/followers","following_url":"https://api.github.com/users/p0wl/following{/other_user}","gists_url":"https://api.github.com/users/p0wl/gists{/gist_id}","starred_url":"https://api.github.com/users/p0wl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p0wl/subscriptions","organizations_url":"https://api.github.com/users/p0wl/orgs","repos_url":"https://api.github.com/users/p0wl/repos","events_url":"https://api.github.com/users/p0wl/events{/privacy}","received_events_url":"https://api.github.com/users/p0wl/received_events","type":"User","site_admin":false},"created_at":"2016-05-25T14:16:26Z","updated_at":"2016-05-25T14:16:26Z","body":"I agree. I've removed the option commits and force pushed. documented the support of boolean attributes in the README.\r\n\r\nIf someone needs it as an option, the commit is still available here: https://github.com/Jimdo/react-element-to-jsx-string/tree/boolean-values-option\r\n\r\nWould be great if you merge and bump. Thanks for your project! I'll use it in our pattern library soon!"}}
{"actor":{"display_login":"p0wl"}}