{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/9759","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/9759/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/9759/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/9759/events","html_url":"https://github.com/nodejs/node/pull/9759","id":191251160,"number":9759,"title":"timers: prevent infinite loop when subsequent immediates are cleared","user":{"login":"hassy","id":1490,"avatar_url":"https://avatars.githubusercontent.com/u/1490?v=3","gravatar_id":"","url":"https://api.github.com/users/hassy","html_url":"https://github.com/hassy","followers_url":"https://api.github.com/users/hassy/followers","following_url":"https://api.github.com/users/hassy/following{/other_user}","gists_url":"https://api.github.com/users/hassy/gists{/gist_id}","starred_url":"https://api.github.com/users/hassy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hassy/subscriptions","organizations_url":"https://api.github.com/users/hassy/orgs","repos_url":"https://api.github.com/users/hassy/repos","events_url":"https://api.github.com/users/hassy/events{/privacy}","received_events_url":"https://api.github.com/users/hassy/received_events","type":"User","site_admin":false},"labels":[{"id":155435976,"url":"https://api.github.com/repos/nodejs/node/labels/timers","name":"timers","color":"f7c6c7","default":false}],"state":"open","locked":false,"assignee":{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars.githubusercontent.com/u/1093990?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},"assignees":[{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars.githubusercontent.com/u/1093990?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2016-11-23T11:52:52Z","updated_at":"2016-12-13T13:10:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/9759","html_url":"https://github.com/nodejs/node/pull/9759","diff_url":"https://github.com/nodejs/node/pull/9759.diff","patch_url":"https://github.com/nodejs/node/pull/9759.patch"},"body":"PR to go with: https://github.com/nodejs/node/issues/9756\r\n\r\nI am not familiar with timers, so the proposed solution could well be wrong. Looking forward to feedback on that!\r\n\r\n##### Checklist\r\n\r\n- [x] `make -j8 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n\r\n- [x] tests and/or benchmarks are included\r\n\r\n- [ ] documentation is changed or added\r\n\r\n- [ ] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n\r\ntimers\r\n\r\n##### Description of change\r\n\r\nRemove the unnecessary `if` branch.\r\n\r\nIf current `immediate` has no callback, proceed onto the next one in the queue."},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/266734331","html_url":"https://github.com/nodejs/node/pull/9759#issuecomment-266734331","issue_url":"https://api.github.com/repos/nodejs/node/issues/9759","id":266734331,"user":{"login":"hassy","id":1490,"avatar_url":"https://avatars.githubusercontent.com/u/1490?v=3","gravatar_id":"","url":"https://api.github.com/users/hassy","html_url":"https://github.com/hassy","followers_url":"https://api.github.com/users/hassy/followers","following_url":"https://api.github.com/users/hassy/following{/other_user}","gists_url":"https://api.github.com/users/hassy/gists{/gist_id}","starred_url":"https://api.github.com/users/hassy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hassy/subscriptions","organizations_url":"https://api.github.com/users/hassy/orgs","repos_url":"https://api.github.com/users/hassy/repos","events_url":"https://api.github.com/users/hassy/events{/privacy}","received_events_url":"https://api.github.com/users/hassy/received_events","type":"User","site_admin":false},"created_at":"2016-12-13T13:10:18Z","updated_at":"2016-12-13T13:10:18Z","body":"@Fishrock123 Is it OK to `--force-with-lease` with the final fixes and a proper commit message as per [CONTRIBUTING.md](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md)?"}}
{"actor":{"display_login":"hassy"}}