{"action":"created","issue":{"url":"https://api.github.com/repos/everypolitician/everypolitician/issues/472","repository_url":"https://api.github.com/repos/everypolitician/everypolitician","labels_url":"https://api.github.com/repos/everypolitician/everypolitician/issues/472/labels{/name}","comments_url":"https://api.github.com/repos/everypolitician/everypolitician/issues/472/comments","events_url":"https://api.github.com/repos/everypolitician/everypolitician/issues/472/events","html_url":"https://github.com/everypolitician/everypolitician/issues/472","id":167054985,"number":472,"title":"Incoming data: handle image URLs that 404","user":{"login":"davewhiteland","id":111320,"avatar_url":"https://avatars.githubusercontent.com/u/111320?v=3","gravatar_id":"","url":"https://api.github.com/users/davewhiteland","html_url":"https://github.com/davewhiteland","followers_url":"https://api.github.com/users/davewhiteland/followers","following_url":"https://api.github.com/users/davewhiteland/following{/other_user}","gists_url":"https://api.github.com/users/davewhiteland/gists{/gist_id}","starred_url":"https://api.github.com/users/davewhiteland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davewhiteland/subscriptions","organizations_url":"https://api.github.com/users/davewhiteland/orgs","repos_url":"https://api.github.com/users/davewhiteland/repos","events_url":"https://api.github.com/users/davewhiteland/events{/privacy}","received_events_url":"https://api.github.com/users/davewhiteland/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/everypolitician/everypolitician/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/everypolitician/everypolitician/labels/import","name":"import","color":"006b75"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-07-22T14:16:34Z","updated_at":"2016-07-23T15:26:52Z","closed_at":null,"body":"# Problem\r\n\r\nWhen reconciling against incoming twitter data, the twitter image is sometimes broken because the URL 404s. That \"bad\" URL ends up in the data even though at this point we know it's not a useful image.\r\n\r\n![screen shot 2016-07-22 at 15 13 10](https://cloud.githubusercontent.com/assets/111320/17059870/229f0b7c-501f-11e6-811d-4e8868ec9d5c.png)\r\n\r\nI _think_ this happens because people can readily change their profile image (not sure).\r\n\r\n# Proposed Solution\r\n\r\nCurrently I don't think we notice the failure, but if we loaded that in the reconciliation tool with some JavaScript we could know when these are 404ing. But that presupposes it is being run through the reconciliation tool.\r\n\r\nSo maybe there's a case for testing health of any image URL that's added to the data?\r\n\r\n# Acceptance Criteria\r\n\r\nImage URLs that do not yield images (specifically 404 returned instead) at time of import do not get added to the data.\r\n\r\n# Not Required\r\n\r\n—\r\n\r\n# Prerequisites\r\n\r\n—\r\n\r\n# Related Issues\r\n\r\n—\r\n# Due Date\r\n\r\n—\r\n\r\n# Design?\r\n\r\nNo.\r\n\r\n# Text?\r\n\r\nNo.\r\n\r\n# Bloggable?\r\n\r\nProbably not."},"comment":{"url":"https://api.github.com/repos/everypolitician/everypolitician/issues/comments/234723990","html_url":"https://github.com/everypolitician/everypolitician/issues/472#issuecomment-234723990","issue_url":"https://api.github.com/repos/everypolitician/everypolitician/issues/472","id":234723990,"user":{"login":"wfdd","id":8489551,"avatar_url":"https://avatars.githubusercontent.com/u/8489551?v=3","gravatar_id":"","url":"https://api.github.com/users/wfdd","html_url":"https://github.com/wfdd","followers_url":"https://api.github.com/users/wfdd/followers","following_url":"https://api.github.com/users/wfdd/following{/other_user}","gists_url":"https://api.github.com/users/wfdd/gists{/gist_id}","starred_url":"https://api.github.com/users/wfdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfdd/subscriptions","organizations_url":"https://api.github.com/users/wfdd/orgs","repos_url":"https://api.github.com/users/wfdd/repos","events_url":"https://api.github.com/users/wfdd/events{/privacy}","received_events_url":"https://api.github.com/users/wfdd/received_events","type":"User","site_admin":false},"created_at":"2016-07-23T15:26:52Z","updated_at":"2016-07-23T15:26:52Z","body":"Well, it's a technical compromise - I'd have no particular reason to remove those URLs if it weren't for a limitation of the image cacher.  I could actually revert that change now that the thumbnails have been generated.  Anyway, my point was some other people might've done the same and it's generally a good idea to be cognisant of how the tools that we use can lead us to make the wrong (or right) choices."}}
{"actor":{"display_login":"wfdd"}}