{"action":"created","comment":{"url":"https://api.github.com/repos/lede-project/source/pulls/comments/90169428","pull_request_review_id":10691812,"id":90169428,"diff_hunk":"@@ -335,11 +335,19 @@ wndr3700v5)\n wt3020)\n \tucidef_set_led_default \"power\" \"power\" \"$board:blue:power\" \"0\"\n \t;;\n-y1|\\\n+y1)\n+\tucidef_set_led_default \"power\" \"power\" \"$board:blue:power\" \"1\"\n+\tset_usb_led \"$board:blue:usb\"\n+\tset_wifi_led \"$board:blue:wifi\" \"wlan1\"\n+\tucidef_set_led_netdev \"wifi5g\" \"wifi5g\" \"$board:blue:wifi5g\" \"wlan0\" \"link tx rx\"\n+\tucidef_set_led_netdev \"lan\" \"lan\" \"$board:blue:lan\" \"eth0.1\" \"tx rx\"\n+\tucidef_set_led_netdev \"wan\" \"wan\" \"$board:blue:internet\" \"eth0.2\" \"tx rx\"\n+\t;;\n y1s)\n \tucidef_set_led_default \"power\" \"power\" \"$board:blue:power\" \"1\"","path":"target/linux/ramips/base-files/etc/board.d/01_leds","position":14,"original_position":14,"commit_id":"bd58e8adb286ed9b52d4ee92ea1a56e6cbc1197b","original_commit_id":"bd58e8adb286ed9b52d4ee92ea1a56e6cbc1197b","user":{"login":"mkresin","id":4547948,"avatar_url":"https://avatars.githubusercontent.com/u/4547948?v=3","gravatar_id":"","url":"https://api.github.com/users/mkresin","html_url":"https://github.com/mkresin","followers_url":"https://api.github.com/users/mkresin/followers","following_url":"https://api.github.com/users/mkresin/following{/other_user}","gists_url":"https://api.github.com/users/mkresin/gists{/gist_id}","starred_url":"https://api.github.com/users/mkresin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkresin/subscriptions","organizations_url":"https://api.github.com/users/mkresin/orgs","repos_url":"https://api.github.com/users/mkresin/repos","events_url":"https://api.github.com/users/mkresin/events{/privacy}","received_events_url":"https://api.github.com/users/mkresin/received_events","type":"User","site_admin":false},"body":"This shouldn't be required. The LED is already handled by target/linux/ramips/base-files/etc/diag.sh.","created_at":"2016-11-30T05:06:39Z","updated_at":"2016-11-30T05:06:39Z","html_url":"https://github.com/lede-project/source/pull/572#discussion_r90169428","pull_request_url":"https://api.github.com/repos/lede-project/source/pulls/572","_links":{"self":{"href":"https://api.github.com/repos/lede-project/source/pulls/comments/90169428"},"html":{"href":"https://github.com/lede-project/source/pull/572#discussion_r90169428"},"pull_request":{"href":"https://api.github.com/repos/lede-project/source/pulls/572"}}},"pull_request":{"url":"https://api.github.com/repos/lede-project/source/pulls/572","id":95810052,"html_url":"https://github.com/lede-project/source/pull/572","diff_url":"https://github.com/lede-project/source/pull/572.diff","patch_url":"https://github.com/lede-project/source/pull/572.patch","issue_url":"https://api.github.com/repos/lede-project/source/issues/572","number":572,"state":"open","locked":false,"title":"ramips: fix y1/y1s led","user":{"login":"hbl0307106015","id":3126149,"avatar_url":"https://avatars.githubusercontent.com/u/3126149?v=3","gravatar_id":"","url":"https://api.github.com/users/hbl0307106015","html_url":"https://github.com/hbl0307106015","followers_url":"https://api.github.com/users/hbl0307106015/followers","following_url":"https://api.github.com/users/hbl0307106015/following{/other_user}","gists_url":"https://api.github.com/users/hbl0307106015/gists{/gist_id}","starred_url":"https://api.github.com/users/hbl0307106015/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbl0307106015/subscriptions","organizations_url":"https://api.github.com/users/hbl0307106015/orgs","repos_url":"https://api.github.com/users/hbl0307106015/repos","events_url":"https://api.github.com/users/hbl0307106015/events{/privacy}","received_events_url":"https://api.github.com/users/hbl0307106015/received_events","type":"User","site_admin":false},"body":"This commit fix the y1 & y1s leds' definition.","created_at":"2016-11-30T01:19:30Z","updated_at":"2016-11-30T05:11:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"624bcfc0f88960108281b4d96d7e974159bb8b98","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lede-project/source/pulls/572/commits","review_comments_url":"https://api.github.com/repos/lede-project/source/pulls/572/comments","review_comment_url":"https://api.github.com/repos/lede-project/source/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lede-project/source/issues/572/comments","statuses_url":"https://api.github.com/repos/lede-project/source/statuses/bd58e8adb286ed9b52d4ee92ea1a56e6cbc1197b","head":{"label":"hbl0307106015:y1-bug-fix","ref":"y1-bug-fix","sha":"bd58e8adb286ed9b52d4ee92ea1a56e6cbc1197b","user":{"login":"hbl0307106015","id":3126149,"avatar_url":"https://avatars.githubusercontent.com/u/3126149?v=3","gravatar_id":"","url":"https://api.github.com/users/hbl0307106015","html_url":"https://github.com/hbl0307106015","followers_url":"https://api.github.com/users/hbl0307106015/followers","following_url":"https://api.github.com/users/hbl0307106015/following{/other_user}","gists_url":"https://api.github.com/users/hbl0307106015/gists{/gist_id}","starred_url":"https://api.github.com/users/hbl0307106015/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbl0307106015/subscriptions","organizations_url":"https://api.github.com/users/hbl0307106015/orgs","repos_url":"https://api.github.com/users/hbl0307106015/repos","events_url":"https://api.github.com/users/hbl0307106015/events{/privacy}","received_events_url":"https://api.github.com/users/hbl0307106015/received_events","type":"User","site_admin":false},"repo":{"id":68994895,"name":"source","full_name":"hbl0307106015/source","owner":{"login":"hbl0307106015","id":3126149,"avatar_url":"https://avatars.githubusercontent.com/u/3126149?v=3","gravatar_id":"","url":"https://api.github.com/users/hbl0307106015","html_url":"https://github.com/hbl0307106015","followers_url":"https://api.github.com/users/hbl0307106015/followers","following_url":"https://api.github.com/users/hbl0307106015/following{/other_user}","gists_url":"https://api.github.com/users/hbl0307106015/gists{/gist_id}","starred_url":"https://api.github.com/users/hbl0307106015/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbl0307106015/subscriptions","organizations_url":"https://api.github.com/users/hbl0307106015/orgs","repos_url":"https://api.github.com/users/hbl0307106015/repos","events_url":"https://api.github.com/users/hbl0307106015/events{/privacy}","received_events_url":"https://api.github.com/users/hbl0307106015/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hbl0307106015/source","description":"Mirror of https://git.lede-project.org/?p=source.git Please send your PRs against this tree. They will be merged via staging trees and appear in this tree once the staging trees get merged back into source.git","fork":true,"url":"https://api.github.com/repos/hbl0307106015/source","forks_url":"https://api.github.com/repos/hbl0307106015/source/forks","keys_url":"https://api.github.com/repos/hbl0307106015/source/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hbl0307106015/source/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hbl0307106015/source/teams","hooks_url":"https://api.github.com/repos/hbl0307106015/source/hooks","issue_events_url":"https://api.github.com/repos/hbl0307106015/source/issues/events{/number}","events_url":"https://api.github.com/repos/hbl0307106015/source/events","assignees_url":"https://api.github.com/repos/hbl0307106015/source/assignees{/user}","branches_url":"https://api.github.com/repos/hbl0307106015/source/branches{/branch}","tags_url":"https://api.github.com/repos/hbl0307106015/source/tags","blobs_url":"https://api.github.com/repos/hbl0307106015/source/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hbl0307106015/source/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hbl0307106015/source/git/refs{/sha}","trees_url":"https://api.github.com/repos/hbl0307106015/source/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hbl0307106015/source/statuses/{sha}","languages_url":"https://api.github.com/repos/hbl0307106015/source/languages","stargazers_url":"https://api.github.com/repos/hbl0307106015/source/stargazers","contributors_url":"https://api.github.com/repos/hbl0307106015/source/contributors","subscribers_url":"https://api.github.com/repos/hbl0307106015/source/subscribers","subscription_url":"https://api.github.com/repos/hbl0307106015/source/subscription","commits_url":"https://api.github.com/repos/hbl0307106015/source/commits{/sha}","git_commits_url":"https://api.github.com/repos/hbl0307106015/source/git/commits{/sha}","comments_url":"https://api.github.com/repos/hbl0307106015/source/comments{/number}","issue_comment_url":"https://api.github.com/repos/hbl0307106015/source/issues/comments{/number}","contents_url":"https://api.github.com/repos/hbl0307106015/source/contents/{+path}","compare_url":"https://api.github.com/repos/hbl0307106015/source/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hbl0307106015/source/merges","archive_url":"https://api.github.com/repos/hbl0307106015/source/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hbl0307106015/source/downloads","issues_url":"https://api.github.com/repos/hbl0307106015/source/issues{/number}","pulls_url":"https://api.github.com/repos/hbl0307106015/source/pulls{/number}","milestones_url":"https://api.github.com/repos/hbl0307106015/source/milestones{/number}","notifications_url":"https://api.github.com/repos/hbl0307106015/source/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hbl0307106015/source/labels{/name}","releases_url":"https://api.github.com/repos/hbl0307106015/source/releases{/id}","deployments_url":"https://api.github.com/repos/hbl0307106015/source/deployments","created_at":"2016-09-23T06:17:19Z","updated_at":"2016-09-23T06:17:37Z","pushed_at":"2016-11-30T01:38:23Z","git_url":"git://github.com/hbl0307106015/source.git","ssh_url":"git@github.com:hbl0307106015/source.git","clone_url":"https://github.com/hbl0307106015/source.git","svn_url":"https://github.com/hbl0307106015/source","homepage":"","size":131937,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lede-project:master","ref":"master","sha":"c0e66478b520b07c33343161f722351f5f858990","user":{"login":"lede-project","id":18146401,"avatar_url":"https://avatars.githubusercontent.com/u/18146401?v=3","gravatar_id":"","url":"https://api.github.com/users/lede-project","html_url":"https://github.com/lede-project","followers_url":"https://api.github.com/users/lede-project/followers","following_url":"https://api.github.com/users/lede-project/following{/other_user}","gists_url":"https://api.github.com/users/lede-project/gists{/gist_id}","starred_url":"https://api.github.com/users/lede-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lede-project/subscriptions","organizations_url":"https://api.github.com/users/lede-project/orgs","repos_url":"https://api.github.com/users/lede-project/repos","events_url":"https://api.github.com/users/lede-project/events{/privacy}","received_events_url":"https://api.github.com/users/lede-project/received_events","type":"Organization","site_admin":false},"repo":{"id":58552470,"name":"source","full_name":"lede-project/source","owner":{"login":"lede-project","id":18146401,"avatar_url":"https://avatars.githubusercontent.com/u/18146401?v=3","gravatar_id":"","url":"https://api.github.com/users/lede-project","html_url":"https://github.com/lede-project","followers_url":"https://api.github.com/users/lede-project/followers","following_url":"https://api.github.com/users/lede-project/following{/other_user}","gists_url":"https://api.github.com/users/lede-project/gists{/gist_id}","starred_url":"https://api.github.com/users/lede-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lede-project/subscriptions","organizations_url":"https://api.github.com/users/lede-project/orgs","repos_url":"https://api.github.com/users/lede-project/repos","events_url":"https://api.github.com/users/lede-project/events{/privacy}","received_events_url":"https://api.github.com/users/lede-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lede-project/source","description":"Mirror of https://git.lede-project.org/?p=source.git Please send your PRs against this tree. They will be merged via staging trees and appear in this tree once the staging trees get merged back into source.git","fork":false,"url":"https://api.github.com/repos/lede-project/source","forks_url":"https://api.github.com/repos/lede-project/source/forks","keys_url":"https://api.github.com/repos/lede-project/source/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lede-project/source/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lede-project/source/teams","hooks_url":"https://api.github.com/repos/lede-project/source/hooks","issue_events_url":"https://api.github.com/repos/lede-project/source/issues/events{/number}","events_url":"https://api.github.com/repos/lede-project/source/events","assignees_url":"https://api.github.com/repos/lede-project/source/assignees{/user}","branches_url":"https://api.github.com/repos/lede-project/source/branches{/branch}","tags_url":"https://api.github.com/repos/lede-project/source/tags","blobs_url":"https://api.github.com/repos/lede-project/source/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lede-project/source/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lede-project/source/git/refs{/sha}","trees_url":"https://api.github.com/repos/lede-project/source/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lede-project/source/statuses/{sha}","languages_url":"https://api.github.com/repos/lede-project/source/languages","stargazers_url":"https://api.github.com/repos/lede-project/source/stargazers","contributors_url":"https://api.github.com/repos/lede-project/source/contributors","subscribers_url":"https://api.github.com/repos/lede-project/source/subscribers","subscription_url":"https://api.github.com/repos/lede-project/source/subscription","commits_url":"https://api.github.com/repos/lede-project/source/commits{/sha}","git_commits_url":"https://api.github.com/repos/lede-project/source/git/commits{/sha}","comments_url":"https://api.github.com/repos/lede-project/source/comments{/number}","issue_comment_url":"https://api.github.com/repos/lede-project/source/issues/comments{/number}","contents_url":"https://api.github.com/repos/lede-project/source/contents/{+path}","compare_url":"https://api.github.com/repos/lede-project/source/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lede-project/source/merges","archive_url":"https://api.github.com/repos/lede-project/source/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lede-project/source/downloads","issues_url":"https://api.github.com/repos/lede-project/source/issues{/number}","pulls_url":"https://api.github.com/repos/lede-project/source/pulls{/number}","milestones_url":"https://api.github.com/repos/lede-project/source/milestones{/number}","notifications_url":"https://api.github.com/repos/lede-project/source/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lede-project/source/labels{/name}","releases_url":"https://api.github.com/repos/lede-project/source/releases{/id}","deployments_url":"https://api.github.com/repos/lede-project/source/deployments","created_at":"2016-05-11T14:31:34Z","updated_at":"2016-11-29T16:37:43Z","pushed_at":"2016-11-30T01:39:25Z","git_url":"git://github.com/lede-project/source.git","ssh_url":"git@github.com:lede-project/source.git","clone_url":"https://github.com/lede-project/source.git","svn_url":"https://github.com/lede-project/source","homepage":"","size":149227,"stargazers_count":346,"watchers_count":346,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":227,"mirror_url":null,"open_issues_count":32,"forks":227,"open_issues":32,"watchers":346,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lede-project/source/pulls/572"},"html":{"href":"https://github.com/lede-project/source/pull/572"},"issue":{"href":"https://api.github.com/repos/lede-project/source/issues/572"},"comments":{"href":"https://api.github.com/repos/lede-project/source/issues/572/comments"},"review_comments":{"href":"https://api.github.com/repos/lede-project/source/pulls/572/comments"},"review_comment":{"href":"https://api.github.com/repos/lede-project/source/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lede-project/source/pulls/572/commits"},"statuses":{"href":"https://api.github.com/repos/lede-project/source/statuses/bd58e8adb286ed9b52d4ee92ea1a56e6cbc1197b"}}}}
{"actor":{"display_login":"mkresin"}}