{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/12634","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12634/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12634/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12634/events","html_url":"https://github.com/joomla/joomla-cms/pull/12634","id":186127001,"number":12634,"title":"Subform.Repeatable styling (alternative to #12419)","user":{"login":"ciar4n","id":2803503,"avatar_url":"https://avatars.githubusercontent.com/u/2803503?v=3","gravatar_id":"","url":"https://api.github.com/users/ciar4n","html_url":"https://github.com/ciar4n","followers_url":"https://api.github.com/users/ciar4n/followers","following_url":"https://api.github.com/users/ciar4n/following{/other_user}","gists_url":"https://api.github.com/users/ciar4n/gists{/gist_id}","starred_url":"https://api.github.com/users/ciar4n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciar4n/subscriptions","organizations_url":"https://api.github.com/users/ciar4n/orgs","repos_url":"https://api.github.com/users/ciar4n/repos","events_url":"https://api.github.com/users/ciar4n/events{/privacy}","received_events_url":"https://api.github.com/users/ciar4n/received_events","type":"User","site_admin":false},"labels":[{"id":60721348,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-10-30T09:52:59Z","updated_at":"2016-11-14T13:34:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12634","html_url":"https://github.com/joomla/joomla-cms/pull/12634","diff_url":"https://github.com/joomla/joomla-cms/pull/12634.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/12634.patch"},"body":"This is an alternative PR to #12419 based on the suggestion by @coolcat-creations \n### Summary of Changes\n\nA PR to add some styling to repeatable subforms (joomla.form.field.subform.repeatable). \n### Testing Instructions\n\nCreate ../modules/mod_login/test.xml to which add the following...\n\n```\n<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<form>\n    <fieldset name=\"sample\" class=\"sample-subform\">\n        <field name=\"image\" type=\"media\" default=\"\" label=\"Sample Field 1\"  description=\"Desc1\" size=\"30\" />\n        <field name=\"text\" type=\"text\" default=\"\" label=\"Sample Field 2\" description=\"Desc2\" />\n        <field name=\"color\" type=\"color\" default=\"#dddddd\" label=\"Sample Field 2\" description=\"Desc2\" />\n    </fieldset>\n</form>\n```\n\nAdd the following to the ../modules/mod_login/mod_login.xml file:\n\n```\n<field name=\"subformtest\" type=\"subform\" formsource=\"modules/mod_login/test.xml\" class=\"advancedSelect\" min=\"0\" max=\"50\" multiple=\"true\" layout=\"joomla.form.field.subform.repeatable\" groupByFieldset=\"true\" label=\"Repeatable Subform\" description=\"Desc\" />\n```\n\n**Before Patch**\n![repeatable1](https://cloud.githubusercontent.com/assets/2803503/19409295/ccde4e2c-92c8-11e6-937c-a1ce26c1a11a.png)\n\n**After Patch**\n![repeatable3](https://cloud.githubusercontent.com/assets/2803503/19835677/ce2964a6-9e85-11e6-9e4b-1b9110d24e71.png)\n\nNote: Tried changing the icons directly (../layouts/joomla/form/field/subform/repeatable/secion.php) however any changes here did not reflect within the form. Possibly the wrong place? Changed the icons with CSS instead which is not ideal.\n### Documentation Changes Required\n\nNone\n"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/260335526","html_url":"https://github.com/joomla/joomla-cms/pull/12634#issuecomment-260335526","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12634","id":260335526,"user":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars.githubusercontent.com/u/2596554?v=3","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"created_at":"2016-11-14T13:34:51Z","updated_at":"2016-11-14T13:34:51Z","body":"I have tested this item :white_check_mark: successfully on 5feab1a7b9ecfa6092ab86d071b2172ec581083d<br /><br />:+1:<hr /><sub>This comment was created with the <a href=\"https://github.com/joomla/jissues\">J!Tracker Application</a> at <a href=\"https://issues.joomla.org/tracker/joomla-cms/12634\">issues.joomla.org/tracker/joomla-cms/12634</a>.</sub>"}}
{"actor":{"display_login":"zero-24"}}