{"action":"created","issue":{"url":"https://api.github.com/repos/KSP-KOS/KOS/issues/1850","repository_url":"https://api.github.com/repos/KSP-KOS/KOS","labels_url":"https://api.github.com/repos/KSP-KOS/KOS/issues/1850/labels{/name}","comments_url":"https://api.github.com/repos/KSP-KOS/KOS/issues/1850/comments","events_url":"https://api.github.com/repos/KSP-KOS/KOS/issues/1850/events","html_url":"https://github.com/KSP-KOS/KOS/pull/1850","id":184318314,"number":1850,"title":"CommNet support for KSP 1.2.0","user":{"login":"hvacengi","id":2975036,"avatar_url":"https://avatars.githubusercontent.com/u/2975036?v=3","gravatar_id":"","url":"https://api.github.com/users/hvacengi","html_url":"https://github.com/hvacengi","followers_url":"https://api.github.com/users/hvacengi/followers","following_url":"https://api.github.com/users/hvacengi/following{/other_user}","gists_url":"https://api.github.com/users/hvacengi/gists{/gist_id}","starred_url":"https://api.github.com/users/hvacengi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hvacengi/subscriptions","organizations_url":"https://api.github.com/users/hvacengi/orgs","repos_url":"https://api.github.com/users/hvacengi/repos","events_url":"https://api.github.com/users/hvacengi/events{/privacy}","received_events_url":"https://api.github.com/users/hvacengi/received_events","type":"User","site_admin":false},"labels":[{"id":181725334,"url":"https://api.github.com/repos/KSP-KOS/KOS/labels/Pending%20Documentation","name":"Pending Documentation","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-20T19:24:55Z","updated_at":"2016-11-07T22:43:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/KSP-KOS/KOS/pulls/1850","html_url":"https://github.com/KSP-KOS/KOS/pull/1850","diff_url":"https://github.com/KSP-KOS/KOS/pull/1850.diff","patch_url":"https://github.com/KSP-KOS/KOS/pull/1850.patch"},"body":"An overhaul of the connectivity system to accommodate more abstraction and support CommNet along with RemoteTech for communication enforcement.\n\nI suggest that any reviewers read through the commit messages as I explained pretty thoroughly what I was changing and why.\n\nEssentially there is now a `ConnectivityManager` class which exposes static methods to access instances of `IConnectivityManager` which enforce connection.  All other changes were made to centralize all of this logic so that it didn't need to be spread across many classes, nor did it need to be tied to `SharedObjects`.\n\nThis is built on top of #1843 because I'm further extending the settings system.\n\nA few important notes:\n- I included a hack to make things work with \"Require Signal for Control\" enabled with CommNet.  I have not done substantial testing to make sure that this doesn't break control lockout somewhere else in KSP.  In fact, if we would like we can move this logic into it's own \"addon\" dll to make it easy to opt in/out of.  Or we could remove the hack and just say that kOS doesn't support that setting.\n- At least one of the two ships you are testing communication between must have a relay antenna.  This is a limitation on the part of KSP, where they do not calculate connections between unloaded vessels that have no relay.  I ran into some fringe cases where it works one direction but not the other, so I set up this logic to try reversing the connection if no connection is shown initially.\n"},"comment":{"url":"https://api.github.com/repos/KSP-KOS/KOS/issues/comments/258987288","html_url":"https://github.com/KSP-KOS/KOS/pull/1850#issuecomment-258987288","issue_url":"https://api.github.com/repos/KSP-KOS/KOS/issues/1850","id":258987288,"user":{"login":"Dunbaratu","id":5216848,"avatar_url":"https://avatars.githubusercontent.com/u/5216848?v=3","gravatar_id":"","url":"https://api.github.com/users/Dunbaratu","html_url":"https://github.com/Dunbaratu","followers_url":"https://api.github.com/users/Dunbaratu/followers","following_url":"https://api.github.com/users/Dunbaratu/following{/other_user}","gists_url":"https://api.github.com/users/Dunbaratu/gists{/gist_id}","starred_url":"https://api.github.com/users/Dunbaratu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dunbaratu/subscriptions","organizations_url":"https://api.github.com/users/Dunbaratu/orgs","repos_url":"https://api.github.com/users/Dunbaratu/repos","events_url":"https://api.github.com/users/Dunbaratu/events{/privacy}","received_events_url":"https://api.github.com/users/Dunbaratu/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T22:43:05Z","updated_at":"2016-11-07T22:43:05Z","body":"When you make the adjustments to documentation and the naming convention of \"stock\" connectivity manager, let me know and I'll push the button on the merge.  (I often don't see it when you update a PR or make a new PR against a PR branch so I might not see it if you don't make an announcement here.)"}}
{"actor":{"display_login":"Dunbaratu"}}