{"push_id":1117965907,"size":7,"distinct_size":7,"ref":"refs/heads/master","head":"dbbf27bb38187f15f21c2cd165cc1c697af518ce","before":"7db3c55f42305b226307e2fe665231e134d3c885","commits":[{"sha":"c0f9b5629fcbf02aac66b479096ee16a2546c6d1","author":{"email":"8dc7c09356db0b1762fb140617d7375c0a5a4131@cockroachlabs.com","name":"Andrei Matei"},"message":"sql: fix a bug in purging old leases\n\nIterating over an aliased slice caused some leases to not be removed.\n\nA test for this will be added in the later commit with the other tests\nbecause it needs some methods in the LeaseManager that don't exist yet.","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/c0f9b5629fcbf02aac66b479096ee16a2546c6d1"},{"sha":"e18db5d657f94fc6cd2484cb44a3bcd904d37d01","author":{"email":"8dc7c09356db0b1762fb140617d7375c0a5a4131@cockroachlabs.com","name":"Andrei Matei"},"message":"sql: integrate the table name cache with the leases\n\nSo here the problem: before this change, the planner had a cache used\nto resolve table names to descriptor ids. This cache was updated by\ngossip, async wrt the schema change transaction. This meant that the\nname of a deleted table could be resolved to the old id for a while\nafter the drop committed. #5483\n\nThis change moves the cache into the leasing subsystem - a name is only\nresolved to a table we have lease on, guaranteeing that the name is\nvalid.\n\nThis change in isolation makes things slightly worse than they were for\nRENAME: RENAME is not a schema change; leases are not retracted when\nwe're about to perform a rename. RENAME does however trigger a gossip\nupdate, which used to update the name cache. Now, the new cache is only\nupdated as a result of new descriptor versions being published, which is\nnot the case. The next commit makes RENAME be a proper schema change\nthat increments the descriptor version.\n\nfixes #5483","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/e18db5d657f94fc6cd2484cb44a3bcd904d37d01"},{"sha":"0f259058bbe636c240a0ff9aba65822813fc9c2b","author":{"email":"8dc7c09356db0b1762fb140617d7375c0a5a4131@cockroachlabs.com","name":"Andrei Matei"},"message":"sql: make RENAME TABLE a schema change\n\nSplitting the RENAME into a sync part (updating the descriptor) and an\nasync part (deleting the mapping of the old name to the id) makes it so\nthat the table name cache in LeaseManager can be reliably used to\nresolve names: the schema changer waits until the old name is not in\nuse any more before removing the mapping, and the name cache is\nguaranteed to have been updated when the transaction doing the RENAME\nreturns.","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/0f259058bbe636c240a0ff9aba65822813fc9c2b"},{"sha":"463b6ffb1a1b134fcee1ea2d588ae721663ba38f","author":{"email":"8dc7c09356db0b1762fb140617d7375c0a5a4131@cockroachlabs.com","name":"Andrei Matei"},"message":"sql: move getTableID to its only user - sql/internal","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/463b6ffb1a1b134fcee1ea2d588ae721663ba38f"},{"sha":"cf124cf6ae20a5bf2f223708bdc842096bbe3787","author":{"email":"8dc7c09356db0b1762fb140617d7375c0a5a4131@cockroachlabs.com","name":"Andrei Matei"},"message":"sql: testing knobs improvements\n\n- expose the LeaseManager through the testing shim\n- expose the clock through the testing shim\n- add a new notification type for rename schema changes","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/cf124cf6ae20a5bf2f223708bdc842096bbe3787"},{"sha":"6bf3fe379d91fbc0b3c383762e7595a16afc5b75","author":{"email":"8dc7c09356db0b1762fb140617d7375c0a5a4131@cockroachlabs.com","name":"Andrei Matei"},"message":"sql: add more leasing and rename tests","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/6bf3fe379d91fbc0b3c383762e7595a16afc5b75"},{"sha":"dbbf27bb38187f15f21c2cd165cc1c697af518ce","author":{"email":"5a8372f5628deb22ab258f403701c7c55f2b695f@gmail.com","name":"Andrei Matei"},"message":"Merge pull request #6595 from andreimatei/rename\n\nsql: integrate the name cache with the lease system; remove rename races","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/dbbf27bb38187f15f21c2cd165cc1c697af518ce"}]}