{"action":"created","issue":{"url":"https://api.github.com/repos/mwilliamson/spur.py/issues/42","repository_url":"https://api.github.com/repos/mwilliamson/spur.py","labels_url":"https://api.github.com/repos/mwilliamson/spur.py/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/mwilliamson/spur.py/issues/42/comments","events_url":"https://api.github.com/repos/mwilliamson/spur.py/issues/42/events","html_url":"https://github.com/mwilliamson/spur.py/pull/42","id":157773430,"number":42,"title":"Added a sock parameter to SshShell","user":{"login":"lindycoder","id":12926519,"avatar_url":"https://avatars.githubusercontent.com/u/12926519?v=3","gravatar_id":"","url":"https://api.github.com/users/lindycoder","html_url":"https://github.com/lindycoder","followers_url":"https://api.github.com/users/lindycoder/followers","following_url":"https://api.github.com/users/lindycoder/following{/other_user}","gists_url":"https://api.github.com/users/lindycoder/gists{/gist_id}","starred_url":"https://api.github.com/users/lindycoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindycoder/subscriptions","organizations_url":"https://api.github.com/users/lindycoder/orgs","repos_url":"https://api.github.com/users/lindycoder/repos","events_url":"https://api.github.com/users/lindycoder/events{/privacy}","received_events_url":"https://api.github.com/users/lindycoder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-05-31T21:20:36Z","updated_at":"2016-06-01T19:09:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mwilliamson/spur.py/pulls/42","html_url":"https://github.com/mwilliamson/spur.py/pull/42","diff_url":"https://github.com/mwilliamson/spur.py/pull/42.diff","patch_url":"https://github.com/mwilliamson/spur.py/pull/42.patch"},"body":"It is a pass-through to the paramiko.client.connect method\r\n\r\nresolves #41\r\n\r\nAnother part of this feature could be to have an helper to craft the proxy_command\r\nthat can be passed to the sock= param"},"comment":{"url":"https://api.github.com/repos/mwilliamson/spur.py/issues/comments/223094279","html_url":"https://github.com/mwilliamson/spur.py/pull/42#issuecomment-223094279","issue_url":"https://api.github.com/repos/mwilliamson/spur.py/issues/42","id":223094279,"user":{"login":"mwilliamson","id":391876,"avatar_url":"https://avatars.githubusercontent.com/u/391876?v=3","gravatar_id":"","url":"https://api.github.com/users/mwilliamson","html_url":"https://github.com/mwilliamson","followers_url":"https://api.github.com/users/mwilliamson/followers","following_url":"https://api.github.com/users/mwilliamson/following{/other_user}","gists_url":"https://api.github.com/users/mwilliamson/gists{/gist_id}","starred_url":"https://api.github.com/users/mwilliamson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwilliamson/subscriptions","organizations_url":"https://api.github.com/users/mwilliamson/orgs","repos_url":"https://api.github.com/users/mwilliamson/repos","events_url":"https://api.github.com/users/mwilliamson/events{/privacy}","received_events_url":"https://api.github.com/users/mwilliamson/received_events","type":"User","site_admin":false},"created_at":"2016-06-01T19:09:46Z","updated_at":"2016-06-01T19:09:46Z","body":"Presumably if you're explicitly passing in a socket then the port is unused? Therefore, an appropriate test might be to check that the connection works when using an invalid port (perhaps with a check that the connection fails with the invalid port when not passing `sock`).\r\n\r\nThere are also a couple of minor stylistic changes that I'd like to make -- would you rather I point them out and let you fix them, or for me to fix them up myself? I'm happy either way.\r\n\r\nWere you planning to add a function to help construct `ProxyCommand`? By no means essential for this pull request though."}}
{"actor":{"display_login":"mwilliamson"}}