{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/88707666","pull_request_review_id":9275537,"id":88707666,"diff_hunk":"@@ -203,6 +208,11 @@ class LogManager(val logDirs: Array[File],\n                          delay = InitialTaskDelayMs,\n                          period = flushCheckpointMs,\n                          TimeUnit.MILLISECONDS)\n+      scheduler.schedule(\"kafka-delete-logs\",","path":"core/src/main/scala/kafka/log/LogManager.scala","position":52,"original_position":52,"commit_id":"f114e09d379b4f06042d355f367fbc4c18451fb3","original_commit_id":"6022ffb4e621a2ee09bb7e8c2ae833e3ddce93a4","user":{"login":"jjkoshy","id":112339,"avatar_url":"https://avatars.githubusercontent.com/u/112339?v=3","gravatar_id":"","url":"https://api.github.com/users/jjkoshy","html_url":"https://github.com/jjkoshy","followers_url":"https://api.github.com/users/jjkoshy/followers","following_url":"https://api.github.com/users/jjkoshy/following{/other_user}","gists_url":"https://api.github.com/users/jjkoshy/gists{/gist_id}","starred_url":"https://api.github.com/users/jjkoshy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjkoshy/subscriptions","organizations_url":"https://api.github.com/users/jjkoshy/orgs","repos_url":"https://api.github.com/users/jjkoshy/repos","events_url":"https://api.github.com/users/jjkoshy/events{/privacy}","received_events_url":"https://api.github.com/users/jjkoshy/received_events","type":"User","site_admin":false},"body":"That can be avoided by using a separate scheduler.","created_at":"2016-11-18T18:08:53Z","updated_at":"2016-11-18T18:08:53Z","html_url":"https://github.com/apache/kafka/pull/1664#discussion_r88707666","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/1664","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/88707666"},"html":{"href":"https://github.com/apache/kafka/pull/1664#discussion_r88707666"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/1664"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/1664","id":78773919,"html_url":"https://github.com/apache/kafka/pull/1664","diff_url":"https://github.com/apache/kafka/pull/1664.diff","patch_url":"https://github.com/apache/kafka/pull/1664.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/1664","number":1664,"state":"open","locked":false,"title":"KAFKA-1911: Async delete topic","user":{"login":"sutambe","id":1181418,"avatar_url":"https://avatars.githubusercontent.com/u/1181418?v=3","gravatar_id":"","url":"https://api.github.com/users/sutambe","html_url":"https://github.com/sutambe","followers_url":"https://api.github.com/users/sutambe/followers","following_url":"https://api.github.com/users/sutambe/following{/other_user}","gists_url":"https://api.github.com/users/sutambe/gists{/gist_id}","starred_url":"https://api.github.com/users/sutambe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sutambe/subscriptions","organizations_url":"https://api.github.com/users/sutambe/orgs","repos_url":"https://api.github.com/users/sutambe/repos","events_url":"https://api.github.com/users/sutambe/events{/privacy}","received_events_url":"https://api.github.com/users/sutambe/received_events","type":"User","site_admin":false},"body":"The last patch submitted by @MayureshGharat (back in Dec 15) has been rebased to the latest trunk. I took care of a couple of test failures (MetricsTest) along the way. @jjkoshy , @granders , @avianey , you may be interested in this PR.\n","created_at":"2016-07-26T00:23:04Z","updated_at":"2016-11-18T18:08:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7339fb8b1956dc583a492c234be62037092e62cd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/1664/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/1664/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/1664/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/f114e09d379b4f06042d355f367fbc4c18451fb3","head":{"label":"sutambe:async-delete-topic","ref":"async-delete-topic","sha":"f114e09d379b4f06042d355f367fbc4c18451fb3","user":{"login":"sutambe","id":1181418,"avatar_url":"https://avatars.githubusercontent.com/u/1181418?v=3","gravatar_id":"","url":"https://api.github.com/users/sutambe","html_url":"https://github.com/sutambe","followers_url":"https://api.github.com/users/sutambe/followers","following_url":"https://api.github.com/users/sutambe/following{/other_user}","gists_url":"https://api.github.com/users/sutambe/gists{/gist_id}","starred_url":"https://api.github.com/users/sutambe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sutambe/subscriptions","organizations_url":"https://api.github.com/users/sutambe/orgs","repos_url":"https://api.github.com/users/sutambe/repos","events_url":"https://api.github.com/users/sutambe/events{/privacy}","received_events_url":"https://api.github.com/users/sutambe/received_events","type":"User","site_admin":false},"repo":{"id":61243815,"name":"kafka","full_name":"sutambe/kafka","owner":{"login":"sutambe","id":1181418,"avatar_url":"https://avatars.githubusercontent.com/u/1181418?v=3","gravatar_id":"","url":"https://api.github.com/users/sutambe","html_url":"https://github.com/sutambe","followers_url":"https://api.github.com/users/sutambe/followers","following_url":"https://api.github.com/users/sutambe/following{/other_user}","gists_url":"https://api.github.com/users/sutambe/gists{/gist_id}","starred_url":"https://api.github.com/users/sutambe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sutambe/subscriptions","organizations_url":"https://api.github.com/users/sutambe/orgs","repos_url":"https://api.github.com/users/sutambe/repos","events_url":"https://api.github.com/users/sutambe/events{/privacy}","received_events_url":"https://api.github.com/users/sutambe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sutambe/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/sutambe/kafka","forks_url":"https://api.github.com/repos/sutambe/kafka/forks","keys_url":"https://api.github.com/repos/sutambe/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sutambe/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sutambe/kafka/teams","hooks_url":"https://api.github.com/repos/sutambe/kafka/hooks","issue_events_url":"https://api.github.com/repos/sutambe/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/sutambe/kafka/events","assignees_url":"https://api.github.com/repos/sutambe/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/sutambe/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/sutambe/kafka/tags","blobs_url":"https://api.github.com/repos/sutambe/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sutambe/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sutambe/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/sutambe/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sutambe/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/sutambe/kafka/languages","stargazers_url":"https://api.github.com/repos/sutambe/kafka/stargazers","contributors_url":"https://api.github.com/repos/sutambe/kafka/contributors","subscribers_url":"https://api.github.com/repos/sutambe/kafka/subscribers","subscription_url":"https://api.github.com/repos/sutambe/kafka/subscription","commits_url":"https://api.github.com/repos/sutambe/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/sutambe/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/sutambe/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/sutambe/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/sutambe/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/sutambe/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sutambe/kafka/merges","archive_url":"https://api.github.com/repos/sutambe/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sutambe/kafka/downloads","issues_url":"https://api.github.com/repos/sutambe/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/sutambe/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/sutambe/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/sutambe/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sutambe/kafka/labels{/name}","releases_url":"https://api.github.com/repos/sutambe/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/sutambe/kafka/deployments","created_at":"2016-06-15T21:55:46Z","updated_at":"2016-06-15T21:55:50Z","pushed_at":"2016-11-16T17:31:38Z","git_url":"git://github.com/sutambe/kafka.git","ssh_url":"git@github.com:sutambe/kafka.git","clone_url":"https://github.com/sutambe/kafka.git","svn_url":"https://github.com/sutambe/kafka","homepage":null,"size":35495,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"4f1d8c6859c5767c314de84bd654cb7e1153db4b","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-11-18T15:57:57Z","pushed_at":"2016-11-18T18:03:07Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":53369,"stargazers_count":4128,"watchers_count":4128,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2556,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":293,"forks":2556,"open_issues":293,"watchers":4128,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/1664"},"html":{"href":"https://github.com/apache/kafka/pull/1664"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/1664"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/1664/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/1664/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/1664/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/f114e09d379b4f06042d355f367fbc4c18451fb3"}}}}
{"actor":{"display_login":"jjkoshy"}}