{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/92891956","pull_request_review_id":13417302,"id":92891956,"diff_hunk":"@@ -111,6 +119,32 @@ private void ParseConfigurationString(string propertyName, ProjectRootElement pr\n             }\n         }\n \n+        private void CreateRuntimeIdentifier(ProjectRootElement project)\n+        {\n+            var rid = Microsoft.DotNet.PlatformAbstractions.RuntimeEnvironment.GetRuntimeIdentifier();\n+\n+            string[] ridParts = rid.Split('-');\n+\n+            if (ridParts.Length < 1)\n+                throw new System.InvalidOperationException($\"Unknwon rid format {rid}.\");\n+\n+            string osNameAndVersion = ridParts[0];\n+\n+            // For now force the rid to always be win7 for windows.\n+            if (osNameAndVersion.StartsWith(\"win\"))\n+            {\n+                osNameAndVersion = \"win7\";","path":"src/Tools/CoreFx.Tools/GenerateConfigurationProps.cs","position":null,"original_position":94,"commit_id":"9549fe83a08d7f38829c7b677b899221d2362394","original_commit_id":"aee7aa289c02a32af4184e9a6248a098bc3ed699","user":{"login":"mellinoe","id":8918977,"avatar_url":"https://avatars.githubusercontent.com/u/8918977?v=3","gravatar_id":"","url":"https://api.github.com/users/mellinoe","html_url":"https://github.com/mellinoe","followers_url":"https://api.github.com/users/mellinoe/followers","following_url":"https://api.github.com/users/mellinoe/following{/other_user}","gists_url":"https://api.github.com/users/mellinoe/gists{/gist_id}","starred_url":"https://api.github.com/users/mellinoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellinoe/subscriptions","organizations_url":"https://api.github.com/users/mellinoe/orgs","repos_url":"https://api.github.com/users/mellinoe/repos","events_url":"https://api.github.com/users/mellinoe/events{/privacy}","received_events_url":"https://api.github.com/users/mellinoe/received_events","type":"User","site_admin":false},"body":"Yeah I only kept it this way because it was defaulting to that before my changes (to detect the default test RID), and I didn't want to cause too much churn. For now, we should just remove any special-casing there and see how it goes.","created_at":"2016-12-16T21:47:46Z","updated_at":"2016-12-16T21:47:46Z","html_url":"https://github.com/dotnet/corefx/pull/14550#discussion_r92891956","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/14550","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/92891956"},"html":{"href":"https://github.com/dotnet/corefx/pull/14550#discussion_r92891956"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/14550"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/14550","id":98254753,"html_url":"https://github.com/dotnet/corefx/pull/14550","diff_url":"https://github.com/dotnet/corefx/pull/14550.diff","patch_url":"https://github.com/dotnet/corefx/pull/14550.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/14550","number":14550,"state":"open","locked":false,"title":"Initial set of work for building external dependencies","user":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":"This adds an external folder with some basic infrastructure to\r\ntemplate project.json files by TFM and RID so that we can only\r\nrestore the set that we actually need.\r\n\r\nUpdates our configuration generation to add RuntimeOS and ArchGroup\r\nso we can use those to build up a NugetRuntimeIdentifier for using\r\nto restore the builds.\r\n\r\ncc @ericstj @mellinoe @joperezr @chcosta","created_at":"2016-12-15T23:53:47Z","updated_at":"2016-12-16T21:47:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f99be44473bd5f53dde92f07a793d0d0ed4c3188","assignee":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"assignees":[{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/4","html_url":"https://github.com/dotnet/corefx/milestone/4","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/4/labels","id":1248719,"number":4,"title":"2.0.0","description":".NET Core 2.0 Placeholder (next major release)\r\nhttps://github.com/dotnet/core/blob/master/roadmap.md\r\n\r\nNote: Previously known as 1.2.","creator":{"login":"joshfree","id":1302850,"avatar_url":"https://avatars.githubusercontent.com/u/1302850?v=3","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"open_issues":323,"closed_issues":3357,"state":"open","created_at":"2015-08-10T18:04:00Z","updated_at":"2016-12-16T20:38:03Z","due_on":"2017-04-30T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/14550/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/14550/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/14550/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/9549fe83a08d7f38829c7b677b899221d2362394","head":{"label":"weshaggard:AddExternalDeps","ref":"AddExternalDeps","sha":"9549fe83a08d7f38829c7b677b899221d2362394","user":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"repo":{"id":26735900,"name":"corefx","full_name":"weshaggard/corefx","owner":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/weshaggard/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/weshaggard/corefx","forks_url":"https://api.github.com/repos/weshaggard/corefx/forks","keys_url":"https://api.github.com/repos/weshaggard/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weshaggard/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weshaggard/corefx/teams","hooks_url":"https://api.github.com/repos/weshaggard/corefx/hooks","issue_events_url":"https://api.github.com/repos/weshaggard/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/weshaggard/corefx/events","assignees_url":"https://api.github.com/repos/weshaggard/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/weshaggard/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/weshaggard/corefx/tags","blobs_url":"https://api.github.com/repos/weshaggard/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weshaggard/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weshaggard/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/weshaggard/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weshaggard/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/weshaggard/corefx/languages","stargazers_url":"https://api.github.com/repos/weshaggard/corefx/stargazers","contributors_url":"https://api.github.com/repos/weshaggard/corefx/contributors","subscribers_url":"https://api.github.com/repos/weshaggard/corefx/subscribers","subscription_url":"https://api.github.com/repos/weshaggard/corefx/subscription","commits_url":"https://api.github.com/repos/weshaggard/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/weshaggard/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/weshaggard/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/weshaggard/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/weshaggard/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/weshaggard/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weshaggard/corefx/merges","archive_url":"https://api.github.com/repos/weshaggard/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weshaggard/corefx/downloads","issues_url":"https://api.github.com/repos/weshaggard/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/weshaggard/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/weshaggard/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/weshaggard/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weshaggard/corefx/labels{/name}","releases_url":"https://api.github.com/repos/weshaggard/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/weshaggard/corefx/deployments","created_at":"2014-11-17T02:05:52Z","updated_at":"2016-10-25T17:02:15Z","pushed_at":"2016-12-16T21:11:41Z","git_url":"git://github.com/weshaggard/corefx.git","ssh_url":"git@github.com:weshaggard/corefx.git","clone_url":"https://github.com/weshaggard/corefx.git","svn_url":"https://github.com/weshaggard/corefx","homepage":"","size":124270,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:dev/eng","ref":"dev/eng","sha":"3398321b7a54c5d47e4530651d3bee43794c1320","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-12-16T18:23:44Z","pushed_at":"2016-12-16T21:46:38Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":125595,"stargazers_count":10953,"watchers_count":10953,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2808,"mirror_url":null,"open_issues_count":1302,"forks":2808,"open_issues":1302,"watchers":10953,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/14550"},"html":{"href":"https://github.com/dotnet/corefx/pull/14550"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/14550"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/14550/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/14550/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/14550/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/9549fe83a08d7f38829c7b677b899221d2362394"}}}}
{"actor":{"display_login":"mellinoe"}}