{"action":"created","issue":{"url":"https://api.github.com/repos/doctrine/common/issues/734","repository_url":"https://api.github.com/repos/doctrine/common","labels_url":"https://api.github.com/repos/doctrine/common/issues/734/labels{/name}","comments_url":"https://api.github.com/repos/doctrine/common/issues/734/comments","events_url":"https://api.github.com/repos/doctrine/common/issues/734/events","html_url":"https://github.com/doctrine/common/pull/734","id":171308578,"number":734,"title":"ProxyGenerator: Added support for PHP 7.1 features","user":{"login":"Majkl578","id":144181,"avatar_url":"https://avatars.githubusercontent.com/u/144181?v=3","gravatar_id":"","url":"https://api.github.com/users/Majkl578","html_url":"https://github.com/Majkl578","followers_url":"https://api.github.com/users/Majkl578/followers","following_url":"https://api.github.com/users/Majkl578/following{/other_user}","gists_url":"https://api.github.com/users/Majkl578/gists{/gist_id}","starred_url":"https://api.github.com/users/Majkl578/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Majkl578/subscriptions","organizations_url":"https://api.github.com/users/Majkl578/orgs","repos_url":"https://api.github.com/users/Majkl578/repos","events_url":"https://api.github.com/users/Majkl578/events{/privacy}","received_events_url":"https://api.github.com/users/Majkl578/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-08-16T02:28:31Z","updated_at":"2016-09-30T14:08:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/doctrine/common/pulls/734","html_url":"https://github.com/doctrine/common/pull/734","diff_url":"https://github.com/doctrine/common/pull/734.diff","patch_url":"https://github.com/doctrine/common/pull/734.patch"},"body":"This was supposed to work without any change in the generator, but it's unfortunately not the case. There are multiple problems:\r\n1) generating nullable type with FQCN is broken - generated code results in parse error;\r\n2) reflection with nullable FQCN is broken - unable to generate proxy;\r\n3) it's impossible to distinguish _nullable type with null default value_ and _non-nullable type with null default value_ - may change function signature in the proxy.\r\n\r\nForwarded upstream for more discussion to the PR where the changes were originally discussed and where you can also find more discussion with some other concerns: https://github.com/php/php-src/pull/2068#issuecomment-239983716\r\nIn case of no activity there I'll forward it to the bugs tracker soon or eventually php.internals.\r\n\r\n(Travis still has old PHP 7.1 version without the changes, they'll appear in beta3.)"},"comment":{"url":"https://api.github.com/repos/doctrine/common/issues/comments/250753578","html_url":"https://github.com/doctrine/common/pull/734#issuecomment-250753578","issue_url":"https://api.github.com/repos/doctrine/common/issues/734","id":250753578,"user":{"login":"Majkl578","id":144181,"avatar_url":"https://avatars.githubusercontent.com/u/144181?v=3","gravatar_id":"","url":"https://api.github.com/users/Majkl578","html_url":"https://github.com/Majkl578","followers_url":"https://api.github.com/users/Majkl578/followers","following_url":"https://api.github.com/users/Majkl578/following{/other_user}","gists_url":"https://api.github.com/users/Majkl578/gists{/gist_id}","starred_url":"https://api.github.com/users/Majkl578/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Majkl578/subscriptions","organizations_url":"https://api.github.com/users/Majkl578/orgs","repos_url":"https://api.github.com/users/Majkl578/repos","events_url":"https://api.github.com/users/Majkl578/events{/privacy}","received_events_url":"https://api.github.com/users/Majkl578/received_events","type":"User","site_admin":false},"created_at":"2016-09-30T14:08:21Z","updated_at":"2016-09-30T14:08:21Z","body":"PR updated, now also includes support void return type and iterable pseudotype. Tested against PHP 7.1 RC3."}}
{"actor":{"display_login":"Majkl578"}}