{"action":"created","issue":{"url":"https://api.github.com/repos/ethcore/parity/issues/2601","repository_url":"https://api.github.com/repos/ethcore/parity","labels_url":"https://api.github.com/repos/ethcore/parity/issues/2601/labels{/name}","comments_url":"https://api.github.com/repos/ethcore/parity/issues/2601/comments","events_url":"https://api.github.com/repos/ethcore/parity/issues/2601/events","html_url":"https://github.com/ethcore/parity/pull/2601","id":182615392,"number":2601,"title":"mitigate refcell conflict in state diffing","user":{"login":"rphmeier","id":10121380,"avatar_url":"https://avatars.githubusercontent.com/u/10121380?v=3","gravatar_id":"","url":"https://api.github.com/users/rphmeier","html_url":"https://github.com/rphmeier","followers_url":"https://api.github.com/users/rphmeier/followers","following_url":"https://api.github.com/users/rphmeier/following{/other_user}","gists_url":"https://api.github.com/users/rphmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/rphmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rphmeier/subscriptions","organizations_url":"https://api.github.com/users/rphmeier/orgs","repos_url":"https://api.github.com/users/rphmeier/repos","events_url":"https://api.github.com/users/rphmeier/events{/privacy}","received_events_url":"https://api.github.com/users/rphmeier/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ethcore/parity/labels/A0-pleasereview","name":"A0-pleasereview","color":"666666"},{"url":"https://api.github.com/repos/ethcore/parity/labels/M0-core","name":"M0-core","color":"eeffff"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-12T19:41:32Z","updated_at":"2016-10-12T20:17:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ethcore/parity/pulls/2601","html_url":"https://github.com/ethcore/parity/pull/2601","diff_url":"https://github.com/ethcore/parity/pull/2601.diff","patch_url":"https://github.com/ethcore/parity/pull/2601.patch"},"body":"Should fix #2600 \r\n\r\nI also switched a few uses of `borrow_mut` to `get_mut`, which should lead to better overall correctness.\r\nThese RefCells are pretty dangerous, and the strange mishmash of interior and actual mutability in this structure can lead to correctness issues, not to mention some slight runtime overhead.\r\n\r\nIt can probably be refactored a bit to make it safer. Use of `RefCell` should be considered similar to `Option::unwrap`."},"comment":{"url":"https://api.github.com/repos/ethcore/parity/issues/comments/253326374","html_url":"https://github.com/ethcore/parity/pull/2601#issuecomment-253326374","issue_url":"https://api.github.com/repos/ethcore/parity/issues/2601","id":253326374,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-10-12T20:17:11Z","updated_at":"2016-10-12T20:17:11Z","body":"\n[![Coverage Status](https://coveralls.io/builds/8308261/badge)](https://coveralls.io/builds/8308261)\n\nCoverage increased (+0.003%) to 86.465% when pulling **590469e95ca38c6ad49433e38224ee6cb183f0a3 on diff-cell-panic** into **c9ce25c8f337ec7ab6e1c2751823444551c8303a on master**.\n"}}
{"actor":{"display_login":"coveralls"}}