{"action":"created","comment":{"url":"https://api.github.com/repos/osuosl/streamwebs/pulls/comments/71596031","id":71596031,"diff_hunk":"@@ -1,19 +1,21 @@\n {% load staticfiles %}\n-{% load pipeline %}\n-\n <!DOCTYPE html>\n <html lang=\"en\">\n <head>\n     <meta charset=\"utf-8\" />\n     <title>{% block title %}Streamwebs{% endblock %}</title>\n     <link rel=\"stylesheet\" type=\"text/css\" href=\"{% static 'streamwebs/style.css' %}\" />\n     <link rel=\"shortcut icon\" href=\"{% static 'streamwebs/images/favicon.ico' %}\" />\n-    {% javascript 'libraries' %}\n+    {% load pipeline %}","path":"streamwebs_frontend/streamwebs/templates/streamwebs/base.html","position":12,"original_position":12,"commit_id":"bc72997968ec4642f92f05114d9a5097b42e9f29","original_commit_id":"bc72997968ec4642f92f05114d9a5097b42e9f29","user":{"login":"alxngyn","id":7299081,"avatar_url":"https://avatars.githubusercontent.com/u/7299081?v=3","gravatar_id":"","url":"https://api.github.com/users/alxngyn","html_url":"https://github.com/alxngyn","followers_url":"https://api.github.com/users/alxngyn/followers","following_url":"https://api.github.com/users/alxngyn/following{/other_user}","gists_url":"https://api.github.com/users/alxngyn/gists{/gist_id}","starred_url":"https://api.github.com/users/alxngyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxngyn/subscriptions","organizations_url":"https://api.github.com/users/alxngyn/orgs","repos_url":"https://api.github.com/users/alxngyn/repos","events_url":"https://api.github.com/users/alxngyn/events{/privacy}","received_events_url":"https://api.github.com/users/alxngyn/received_events","type":"User","site_admin":false},"body":"should we ignore/remove pipeline completely and just import the JS libraries by <script> tags?","created_at":"2016-07-20T20:01:50Z","updated_at":"2016-07-20T20:01:50Z","html_url":"https://github.com/osuosl/streamwebs/pull/91#discussion_r71596031","pull_request_url":"https://api.github.com/repos/osuosl/streamwebs/pulls/91","_links":{"self":{"href":"https://api.github.com/repos/osuosl/streamwebs/pulls/comments/71596031"},"html":{"href":"https://github.com/osuosl/streamwebs/pull/91#discussion_r71596031"},"pull_request":{"href":"https://api.github.com/repos/osuosl/streamwebs/pulls/91"}}},"pull_request":{"url":"https://api.github.com/repos/osuosl/streamwebs/pulls/91","id":78069578,"html_url":"https://github.com/osuosl/streamwebs/pull/91","diff_url":"https://github.com/osuosl/streamwebs/pull/91.diff","patch_url":"https://github.com/osuosl/streamwebs/pull/91.patch","issue_url":"https://api.github.com/repos/osuosl/streamwebs/issues/91","number":91,"state":"open","locked":false,"title":"Made the index.html, register.html, login.html use base template","user":{"login":"elenatorrey","id":17771984,"avatar_url":"https://avatars.githubusercontent.com/u/17771984?v=3","gravatar_id":"","url":"https://api.github.com/users/elenatorrey","html_url":"https://github.com/elenatorrey","followers_url":"https://api.github.com/users/elenatorrey/followers","following_url":"https://api.github.com/users/elenatorrey/following{/other_user}","gists_url":"https://api.github.com/users/elenatorrey/gists{/gist_id}","starred_url":"https://api.github.com/users/elenatorrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elenatorrey/subscriptions","organizations_url":"https://api.github.com/users/elenatorrey/orgs","repos_url":"https://api.github.com/users/elenatorrey/repos","events_url":"https://api.github.com/users/elenatorrey/events{/privacy}","received_events_url":"https://api.github.com/users/elenatorrey/received_events","type":"User","site_admin":false},"body":"<!--\r\n  This is a guideline for what a PR should look like.\r\n  Feel free to modify it to fit your specific needs.\r\n\r\n  Please list the issue this fixes in the PR\r\n-->\r\nfixes issue #86\r\n\r\n## Changes in this PR.\r\n<!--\r\n  Please include a list of all things this PR will accomplish\r\n  Use the checkbox syntax to show what is done and what is yet to be completed.\r\n  This gives context to the diff.\r\n-->\r\n\r\n- [X] base.html is set up for index, login and register pages\r\n- [X] had to remove the {% javascript 'libraries' %} line because apparently the pipeline compressor isn't configured completely and it was causing an error when testing \r\n\r\n\r\n## Testing this PR.\r\n<!--\r\n  Please include a list of explicit instructions for testing this PR.\r\n  If the instructions are 'run `make test`' say that,\r\n  If they are more complicated be thorough.\r\n-->\r\n\r\n1. flake8\r\n2. ./runtests.sh\r\n3. docker-compose up\r\n\r\n### Expected Output.\r\n<!--\r\n  Please insert either a description of what should happen when testing\r\n  your PR or a code-block with terminal output.\r\n-->\r\n\r\nRan 11 tests in 0.388s\r\n\r\nOK\r\nDestroying test database for alias 'default'...\r\n\r\n\r\n@osuosl/devs\r\n\r\n","created_at":"2016-07-20T00:04:40Z","updated_at":"2016-07-20T20:01:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d1ecbab5d3a6f247449b8b4c7745de65935191c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/osuosl/streamwebs/pulls/91/commits","review_comments_url":"https://api.github.com/repos/osuosl/streamwebs/pulls/91/comments","review_comment_url":"https://api.github.com/repos/osuosl/streamwebs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/osuosl/streamwebs/issues/91/comments","statuses_url":"https://api.github.com/repos/osuosl/streamwebs/statuses/bc72997968ec4642f92f05114d9a5097b42e9f29","head":{"label":"osuosl:etorrey/basetemplate","ref":"etorrey/basetemplate","sha":"bc72997968ec4642f92f05114d9a5097b42e9f29","user":{"login":"osuosl","id":1380625,"avatar_url":"https://avatars.githubusercontent.com/u/1380625?v=3","gravatar_id":"","url":"https://api.github.com/users/osuosl","html_url":"https://github.com/osuosl","followers_url":"https://api.github.com/users/osuosl/followers","following_url":"https://api.github.com/users/osuosl/following{/other_user}","gists_url":"https://api.github.com/users/osuosl/gists{/gist_id}","starred_url":"https://api.github.com/users/osuosl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osuosl/subscriptions","organizations_url":"https://api.github.com/users/osuosl/orgs","repos_url":"https://api.github.com/users/osuosl/repos","events_url":"https://api.github.com/users/osuosl/events{/privacy}","received_events_url":"https://api.github.com/users/osuosl/received_events","type":"Organization","site_admin":false},"repo":{"id":46070727,"name":"streamwebs","full_name":"osuosl/streamwebs","owner":{"login":"osuosl","id":1380625,"avatar_url":"https://avatars.githubusercontent.com/u/1380625?v=3","gravatar_id":"","url":"https://api.github.com/users/osuosl","html_url":"https://github.com/osuosl","followers_url":"https://api.github.com/users/osuosl/followers","following_url":"https://api.github.com/users/osuosl/following{/other_user}","gists_url":"https://api.github.com/users/osuosl/gists{/gist_id}","starred_url":"https://api.github.com/users/osuosl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osuosl/subscriptions","organizations_url":"https://api.github.com/users/osuosl/orgs","repos_url":"https://api.github.com/users/osuosl/repos","events_url":"https://api.github.com/users/osuosl/events{/privacy}","received_events_url":"https://api.github.com/users/osuosl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osuosl/streamwebs","description":"Streamwebs.org website","fork":false,"url":"https://api.github.com/repos/osuosl/streamwebs","forks_url":"https://api.github.com/repos/osuosl/streamwebs/forks","keys_url":"https://api.github.com/repos/osuosl/streamwebs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osuosl/streamwebs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osuosl/streamwebs/teams","hooks_url":"https://api.github.com/repos/osuosl/streamwebs/hooks","issue_events_url":"https://api.github.com/repos/osuosl/streamwebs/issues/events{/number}","events_url":"https://api.github.com/repos/osuosl/streamwebs/events","assignees_url":"https://api.github.com/repos/osuosl/streamwebs/assignees{/user}","branches_url":"https://api.github.com/repos/osuosl/streamwebs/branches{/branch}","tags_url":"https://api.github.com/repos/osuosl/streamwebs/tags","blobs_url":"https://api.github.com/repos/osuosl/streamwebs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osuosl/streamwebs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osuosl/streamwebs/git/refs{/sha}","trees_url":"https://api.github.com/repos/osuosl/streamwebs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osuosl/streamwebs/statuses/{sha}","languages_url":"https://api.github.com/repos/osuosl/streamwebs/languages","stargazers_url":"https://api.github.com/repos/osuosl/streamwebs/stargazers","contributors_url":"https://api.github.com/repos/osuosl/streamwebs/contributors","subscribers_url":"https://api.github.com/repos/osuosl/streamwebs/subscribers","subscription_url":"https://api.github.com/repos/osuosl/streamwebs/subscription","commits_url":"https://api.github.com/repos/osuosl/streamwebs/commits{/sha}","git_commits_url":"https://api.github.com/repos/osuosl/streamwebs/git/commits{/sha}","comments_url":"https://api.github.com/repos/osuosl/streamwebs/comments{/number}","issue_comment_url":"https://api.github.com/repos/osuosl/streamwebs/issues/comments{/number}","contents_url":"https://api.github.com/repos/osuosl/streamwebs/contents/{+path}","compare_url":"https://api.github.com/repos/osuosl/streamwebs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osuosl/streamwebs/merges","archive_url":"https://api.github.com/repos/osuosl/streamwebs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osuosl/streamwebs/downloads","issues_url":"https://api.github.com/repos/osuosl/streamwebs/issues{/number}","pulls_url":"https://api.github.com/repos/osuosl/streamwebs/pulls{/number}","milestones_url":"https://api.github.com/repos/osuosl/streamwebs/milestones{/number}","notifications_url":"https://api.github.com/repos/osuosl/streamwebs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osuosl/streamwebs/labels{/name}","releases_url":"https://api.github.com/repos/osuosl/streamwebs/releases{/id}","deployments_url":"https://api.github.com/repos/osuosl/streamwebs/deployments","created_at":"2015-11-12T18:01:39Z","updated_at":"2016-05-16T17:57:32Z","pushed_at":"2016-07-20T15:54:48Z","git_url":"git://github.com/osuosl/streamwebs.git","ssh_url":"git@github.com:osuosl/streamwebs.git","clone_url":"https://github.com/osuosl/streamwebs.git","svn_url":"https://github.com/osuosl/streamwebs","homepage":null,"size":2453,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":51,"forks":0,"open_issues":51,"watchers":0,"default_branch":"develop"}},"base":{"label":"osuosl:develop","ref":"develop","sha":"fe701f5bbb5062c4fbb9a6d86a537fd129c64a8c","user":{"login":"osuosl","id":1380625,"avatar_url":"https://avatars.githubusercontent.com/u/1380625?v=3","gravatar_id":"","url":"https://api.github.com/users/osuosl","html_url":"https://github.com/osuosl","followers_url":"https://api.github.com/users/osuosl/followers","following_url":"https://api.github.com/users/osuosl/following{/other_user}","gists_url":"https://api.github.com/users/osuosl/gists{/gist_id}","starred_url":"https://api.github.com/users/osuosl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osuosl/subscriptions","organizations_url":"https://api.github.com/users/osuosl/orgs","repos_url":"https://api.github.com/users/osuosl/repos","events_url":"https://api.github.com/users/osuosl/events{/privacy}","received_events_url":"https://api.github.com/users/osuosl/received_events","type":"Organization","site_admin":false},"repo":{"id":46070727,"name":"streamwebs","full_name":"osuosl/streamwebs","owner":{"login":"osuosl","id":1380625,"avatar_url":"https://avatars.githubusercontent.com/u/1380625?v=3","gravatar_id":"","url":"https://api.github.com/users/osuosl","html_url":"https://github.com/osuosl","followers_url":"https://api.github.com/users/osuosl/followers","following_url":"https://api.github.com/users/osuosl/following{/other_user}","gists_url":"https://api.github.com/users/osuosl/gists{/gist_id}","starred_url":"https://api.github.com/users/osuosl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osuosl/subscriptions","organizations_url":"https://api.github.com/users/osuosl/orgs","repos_url":"https://api.github.com/users/osuosl/repos","events_url":"https://api.github.com/users/osuosl/events{/privacy}","received_events_url":"https://api.github.com/users/osuosl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osuosl/streamwebs","description":"Streamwebs.org website","fork":false,"url":"https://api.github.com/repos/osuosl/streamwebs","forks_url":"https://api.github.com/repos/osuosl/streamwebs/forks","keys_url":"https://api.github.com/repos/osuosl/streamwebs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osuosl/streamwebs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osuosl/streamwebs/teams","hooks_url":"https://api.github.com/repos/osuosl/streamwebs/hooks","issue_events_url":"https://api.github.com/repos/osuosl/streamwebs/issues/events{/number}","events_url":"https://api.github.com/repos/osuosl/streamwebs/events","assignees_url":"https://api.github.com/repos/osuosl/streamwebs/assignees{/user}","branches_url":"https://api.github.com/repos/osuosl/streamwebs/branches{/branch}","tags_url":"https://api.github.com/repos/osuosl/streamwebs/tags","blobs_url":"https://api.github.com/repos/osuosl/streamwebs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osuosl/streamwebs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osuosl/streamwebs/git/refs{/sha}","trees_url":"https://api.github.com/repos/osuosl/streamwebs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osuosl/streamwebs/statuses/{sha}","languages_url":"https://api.github.com/repos/osuosl/streamwebs/languages","stargazers_url":"https://api.github.com/repos/osuosl/streamwebs/stargazers","contributors_url":"https://api.github.com/repos/osuosl/streamwebs/contributors","subscribers_url":"https://api.github.com/repos/osuosl/streamwebs/subscribers","subscription_url":"https://api.github.com/repos/osuosl/streamwebs/subscription","commits_url":"https://api.github.com/repos/osuosl/streamwebs/commits{/sha}","git_commits_url":"https://api.github.com/repos/osuosl/streamwebs/git/commits{/sha}","comments_url":"https://api.github.com/repos/osuosl/streamwebs/comments{/number}","issue_comment_url":"https://api.github.com/repos/osuosl/streamwebs/issues/comments{/number}","contents_url":"https://api.github.com/repos/osuosl/streamwebs/contents/{+path}","compare_url":"https://api.github.com/repos/osuosl/streamwebs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osuosl/streamwebs/merges","archive_url":"https://api.github.com/repos/osuosl/streamwebs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osuosl/streamwebs/downloads","issues_url":"https://api.github.com/repos/osuosl/streamwebs/issues{/number}","pulls_url":"https://api.github.com/repos/osuosl/streamwebs/pulls{/number}","milestones_url":"https://api.github.com/repos/osuosl/streamwebs/milestones{/number}","notifications_url":"https://api.github.com/repos/osuosl/streamwebs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osuosl/streamwebs/labels{/name}","releases_url":"https://api.github.com/repos/osuosl/streamwebs/releases{/id}","deployments_url":"https://api.github.com/repos/osuosl/streamwebs/deployments","created_at":"2015-11-12T18:01:39Z","updated_at":"2016-05-16T17:57:32Z","pushed_at":"2016-07-20T15:54:48Z","git_url":"git://github.com/osuosl/streamwebs.git","ssh_url":"git@github.com:osuosl/streamwebs.git","clone_url":"https://github.com/osuosl/streamwebs.git","svn_url":"https://github.com/osuosl/streamwebs","homepage":null,"size":2453,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":51,"forks":0,"open_issues":51,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/osuosl/streamwebs/pulls/91"},"html":{"href":"https://github.com/osuosl/streamwebs/pull/91"},"issue":{"href":"https://api.github.com/repos/osuosl/streamwebs/issues/91"},"comments":{"href":"https://api.github.com/repos/osuosl/streamwebs/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/osuosl/streamwebs/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/osuosl/streamwebs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/osuosl/streamwebs/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/osuosl/streamwebs/statuses/bc72997968ec4642f92f05114d9a5097b42e9f29"}}}}
{"actor":{"display_login":"alxngyn"}}