{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/marathon/pulls/comments/78200056","id":78200056,"diff_hunk":"@@ -125,6 +120,17 @@ private[impl] class LaunchQueueActor(\n       sender() ! None\n   }\n \n+  private[this] def receiveInstanceUpdateToSuspendedActor: Receive = {\n+    case update: InstanceChange if suspendedLauncherPathIds(update.runSpecId) =>\n+      // Do not defer. If an AppTaskLauncherActor restarts, it retrieves a new task list.\n+      // If we defer this, there is a potential deadlock (resolved by timeout):\n+      //   * AppTaskLauncher waits for in-flight tasks\n+      //   * TaskOp gets processed and one of the update steps calls this here\n+      //   * ... blocked until timeout ...\n+      //   * The task launch notification (that the AppTaskLauncherActor waits for) gets sent to the actor\n+      sender() ! None","path":"src/main/scala/mesosphere/marathon/core/launchqueue/impl/LaunchQueueActor.scala","position":50,"original_position":50,"commit_id":"bf2abd9b73bdaec7ad7cd7de63f4ddf624cd6cd3","original_commit_id":"bf2abd9b73bdaec7ad7cd7de63f4ddf624cd6cd3","user":{"login":"jasongilanfarr","id":794214,"avatar_url":"https://avatars.githubusercontent.com/u/794214?v=3","gravatar_id":"","url":"https://api.github.com/users/jasongilanfarr","html_url":"https://github.com/jasongilanfarr","followers_url":"https://api.github.com/users/jasongilanfarr/followers","following_url":"https://api.github.com/users/jasongilanfarr/following{/other_user}","gists_url":"https://api.github.com/users/jasongilanfarr/gists{/gist_id}","starred_url":"https://api.github.com/users/jasongilanfarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasongilanfarr/subscriptions","organizations_url":"https://api.github.com/users/jasongilanfarr/orgs","repos_url":"https://api.github.com/users/jasongilanfarr/repos","events_url":"https://api.github.com/users/jasongilanfarr/events{/privacy}","received_events_url":"https://api.github.com/users/jasongilanfarr/received_events","type":"User","site_admin":false},"body":"Maybe better as Option.empty[T] for readability sake...","created_at":"2016-09-09T15:30:31Z","updated_at":"2016-09-09T15:30:31Z","html_url":"https://github.com/mesosphere/marathon/pull/4342#discussion_r78200056","pull_request_url":"https://api.github.com/repos/mesosphere/marathon/pulls/4342","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/comments/78200056"},"html":{"href":"https://github.com/mesosphere/marathon/pull/4342#discussion_r78200056"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/4342"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/marathon/pulls/4342","id":84669090,"html_url":"https://github.com/mesosphere/marathon/pull/4342","diff_url":"https://github.com/mesosphere/marathon/pull/4342.diff","patch_url":"https://github.com/mesosphere/marathon/pull/4342.patch","issue_url":"https://api.github.com/repos/mesosphere/marathon/issues/4342","number":4342,"state":"open","locked":false,"title":"Implement InstanceChangeHandler in former TaskUpdateStepImpls","user":{"login":"meichstedt","id":414354,"avatar_url":"https://avatars.githubusercontent.com/u/414354?v=3","gravatar_id":"","url":"https://api.github.com/users/meichstedt","html_url":"https://github.com/meichstedt","followers_url":"https://api.github.com/users/meichstedt/followers","following_url":"https://api.github.com/users/meichstedt/following{/other_user}","gists_url":"https://api.github.com/users/meichstedt/gists{/gist_id}","starred_url":"https://api.github.com/users/meichstedt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meichstedt/subscriptions","organizations_url":"https://api.github.com/users/meichstedt/orgs","repos_url":"https://api.github.com/users/meichstedt/repos","events_url":"https://api.github.com/users/meichstedt/events{/privacy}","received_events_url":"https://api.github.com/users/meichstedt/received_events","type":"User","site_admin":false},"body":"added implementation for new `InstanceChange` to the steps that currently propagate `TaskChanged`. Will remove old stuff and rename steps in a follow up PR","created_at":"2016-09-09T15:20:35Z","updated_at":"2016-09-09T15:30:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6905969ffff583141191b6016dc849763c2c0d30","assignee":{"login":"jasongilanfarr","id":794214,"avatar_url":"https://avatars.githubusercontent.com/u/794214?v=3","gravatar_id":"","url":"https://api.github.com/users/jasongilanfarr","html_url":"https://github.com/jasongilanfarr","followers_url":"https://api.github.com/users/jasongilanfarr/followers","following_url":"https://api.github.com/users/jasongilanfarr/following{/other_user}","gists_url":"https://api.github.com/users/jasongilanfarr/gists{/gist_id}","starred_url":"https://api.github.com/users/jasongilanfarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasongilanfarr/subscriptions","organizations_url":"https://api.github.com/users/jasongilanfarr/orgs","repos_url":"https://api.github.com/users/jasongilanfarr/repos","events_url":"https://api.github.com/users/jasongilanfarr/events{/privacy}","received_events_url":"https://api.github.com/users/jasongilanfarr/received_events","type":"User","site_admin":false},"assignees":[{"login":"jasongilanfarr","id":794214,"avatar_url":"https://avatars.githubusercontent.com/u/794214?v=3","gravatar_id":"","url":"https://api.github.com/users/jasongilanfarr","html_url":"https://github.com/jasongilanfarr","followers_url":"https://api.github.com/users/jasongilanfarr/followers","following_url":"https://api.github.com/users/jasongilanfarr/following{/other_user}","gists_url":"https://api.github.com/users/jasongilanfarr/gists{/gist_id}","starred_url":"https://api.github.com/users/jasongilanfarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasongilanfarr/subscriptions","organizations_url":"https://api.github.com/users/jasongilanfarr/orgs","repos_url":"https://api.github.com/users/jasongilanfarr/repos","events_url":"https://api.github.com/users/jasongilanfarr/events{/privacy}","received_events_url":"https://api.github.com/users/jasongilanfarr/received_events","type":"User","site_admin":false},{"login":"unterstein","id":904420,"avatar_url":"https://avatars.githubusercontent.com/u/904420?v=3","gravatar_id":"","url":"https://api.github.com/users/unterstein","html_url":"https://github.com/unterstein","followers_url":"https://api.github.com/users/unterstein/followers","following_url":"https://api.github.com/users/unterstein/following{/other_user}","gists_url":"https://api.github.com/users/unterstein/gists{/gist_id}","starred_url":"https://api.github.com/users/unterstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unterstein/subscriptions","organizations_url":"https://api.github.com/users/unterstein/orgs","repos_url":"https://api.github.com/users/unterstein/repos","events_url":"https://api.github.com/users/unterstein/events{/privacy}","received_events_url":"https://api.github.com/users/unterstein/received_events","type":"User","site_admin":false},{"login":"jdef","id":2348332,"avatar_url":"https://avatars.githubusercontent.com/u/2348332?v=3","gravatar_id":"","url":"https://api.github.com/users/jdef","html_url":"https://github.com/jdef","followers_url":"https://api.github.com/users/jdef/followers","following_url":"https://api.github.com/users/jdef/following{/other_user}","gists_url":"https://api.github.com/users/jdef/gists{/gist_id}","starred_url":"https://api.github.com/users/jdef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdef/subscriptions","organizations_url":"https://api.github.com/users/jdef/orgs","repos_url":"https://api.github.com/users/jdef/repos","events_url":"https://api.github.com/users/jdef/events{/privacy}","received_events_url":"https://api.github.com/users/jdef/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/marathon/pulls/4342/commits","review_comments_url":"https://api.github.com/repos/mesosphere/marathon/pulls/4342/comments","review_comment_url":"https://api.github.com/repos/mesosphere/marathon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/marathon/issues/4342/comments","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/bf2abd9b73bdaec7ad7cd7de63f4ddf624cd6cd3","head":{"label":"mesosphere:me/pods/instanceChange","ref":"me/pods/instanceChange","sha":"bf2abd9b73bdaec7ad7cd7de63f4ddf624cd6cd3","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":10941409,"name":"marathon","full_name":"mesosphere/marathon","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/marathon","description":"Deploy and manage containers (including Docker) on top of Apache Mesos at scale.","fork":false,"url":"https://api.github.com/repos/mesosphere/marathon","forks_url":"https://api.github.com/repos/mesosphere/marathon/forks","keys_url":"https://api.github.com/repos/mesosphere/marathon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/marathon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/marathon/teams","hooks_url":"https://api.github.com/repos/mesosphere/marathon/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/marathon/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/marathon/events","assignees_url":"https://api.github.com/repos/mesosphere/marathon/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/marathon/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/marathon/tags","blobs_url":"https://api.github.com/repos/mesosphere/marathon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/marathon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/marathon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/marathon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/marathon/languages","stargazers_url":"https://api.github.com/repos/mesosphere/marathon/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/marathon/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/marathon/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/marathon/subscription","commits_url":"https://api.github.com/repos/mesosphere/marathon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/marathon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/marathon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/marathon/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/marathon/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/marathon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/marathon/merges","archive_url":"https://api.github.com/repos/mesosphere/marathon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/marathon/downloads","issues_url":"https://api.github.com/repos/mesosphere/marathon/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/marathon/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/marathon/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/marathon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/marathon/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/marathon/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/marathon/deployments","created_at":"2013-06-25T14:56:34Z","updated_at":"2016-09-09T08:08:21Z","pushed_at":"2016-09-09T15:28:18Z","git_url":"git://github.com/mesosphere/marathon.git","ssh_url":"git@github.com:mesosphere/marathon.git","clone_url":"https://github.com/mesosphere/marathon.git","svn_url":"https://github.com/mesosphere/marathon","homepage":"https://mesosphere.github.io/marathon/","size":30501,"stargazers_count":2763,"watchers_count":2763,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":611,"mirror_url":null,"open_issues_count":687,"forks":611,"open_issues":687,"watchers":2763,"default_branch":"master"}},"base":{"label":"mesosphere:feature/pods","ref":"feature/pods","sha":"0cb591f3951acb0a6eac57defcc1ba068c49aaf7","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":10941409,"name":"marathon","full_name":"mesosphere/marathon","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars.githubusercontent.com/u/3458585?v=3","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/marathon","description":"Deploy and manage containers (including Docker) on top of Apache Mesos at scale.","fork":false,"url":"https://api.github.com/repos/mesosphere/marathon","forks_url":"https://api.github.com/repos/mesosphere/marathon/forks","keys_url":"https://api.github.com/repos/mesosphere/marathon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/marathon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/marathon/teams","hooks_url":"https://api.github.com/repos/mesosphere/marathon/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/marathon/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/marathon/events","assignees_url":"https://api.github.com/repos/mesosphere/marathon/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/marathon/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/marathon/tags","blobs_url":"https://api.github.com/repos/mesosphere/marathon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/marathon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/marathon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/marathon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/marathon/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/marathon/languages","stargazers_url":"https://api.github.com/repos/mesosphere/marathon/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/marathon/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/marathon/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/marathon/subscription","commits_url":"https://api.github.com/repos/mesosphere/marathon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/marathon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/marathon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/marathon/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/marathon/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/marathon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/marathon/merges","archive_url":"https://api.github.com/repos/mesosphere/marathon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/marathon/downloads","issues_url":"https://api.github.com/repos/mesosphere/marathon/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/marathon/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/marathon/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/marathon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/marathon/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/marathon/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/marathon/deployments","created_at":"2013-06-25T14:56:34Z","updated_at":"2016-09-09T08:08:21Z","pushed_at":"2016-09-09T15:28:18Z","git_url":"git://github.com/mesosphere/marathon.git","ssh_url":"git@github.com:mesosphere/marathon.git","clone_url":"https://github.com/mesosphere/marathon.git","svn_url":"https://github.com/mesosphere/marathon","homepage":"https://mesosphere.github.io/marathon/","size":30501,"stargazers_count":2763,"watchers_count":2763,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":611,"mirror_url":null,"open_issues_count":687,"forks":611,"open_issues":687,"watchers":2763,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/4342"},"html":{"href":"https://github.com/mesosphere/marathon/pull/4342"},"issue":{"href":"https://api.github.com/repos/mesosphere/marathon/issues/4342"},"comments":{"href":"https://api.github.com/repos/mesosphere/marathon/issues/4342/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/4342/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/marathon/pulls/4342/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/marathon/statuses/bf2abd9b73bdaec7ad7cd7de63f4ddf624cd6cd3"}}}}
{"actor":{"display_login":"jasongilanfarr"}}