{"action":"closed","number":447,"pull_request":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/447","id":92390499,"html_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/447","diff_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/447.diff","patch_url":"https://github.com/department-of-veterans-affairs/vets-api/pull/447.patch","issue_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/447","number":447,"state":"closed","locked":false,"title":"stop using a singleton for SAML::SettingsService","user":{"login":"aub","id":2895,"avatar_url":"https://avatars.githubusercontent.com/u/2895?v=3","gravatar_id":"","url":"https://api.github.com/users/aub","html_url":"https://github.com/aub","followers_url":"https://api.github.com/users/aub/followers","following_url":"https://api.github.com/users/aub/following{/other_user}","gists_url":"https://api.github.com/users/aub/gists{/gist_id}","starred_url":"https://api.github.com/users/aub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aub/subscriptions","organizations_url":"https://api.github.com/users/aub/orgs","repos_url":"https://api.github.com/users/aub/repos","events_url":"https://api.github.com/users/aub/events{/privacy}","received_events_url":"https://api.github.com/users/aub/received_events","type":"User","site_admin":false},"body":"We were using a singleton for storing the SAML settings, but then in the controllers we would get back the data from it and change it. Not great. This gets rid of the singleton and generates the data each time it's requested but still only queries the metadata endpoint once per app server instance.","created_at":"2016-11-04T18:15:19Z","updated_at":"2016-11-06T00:07:00Z","closed_at":"2016-11-06T00:07:00Z","merged_at":"2016-11-06T00:07:00Z","merge_commit_sha":"b363e14a5970cc4d669ec38a1397a33aeacd7af4","assignee":{"login":"saneshark","id":591737,"avatar_url":"https://avatars.githubusercontent.com/u/591737?v=3","gravatar_id":"","url":"https://api.github.com/users/saneshark","html_url":"https://github.com/saneshark","followers_url":"https://api.github.com/users/saneshark/followers","following_url":"https://api.github.com/users/saneshark/following{/other_user}","gists_url":"https://api.github.com/users/saneshark/gists{/gist_id}","starred_url":"https://api.github.com/users/saneshark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saneshark/subscriptions","organizations_url":"https://api.github.com/users/saneshark/orgs","repos_url":"https://api.github.com/users/saneshark/repos","events_url":"https://api.github.com/users/saneshark/events{/privacy}","received_events_url":"https://api.github.com/users/saneshark/received_events","type":"User","site_admin":false},"assignees":[{"login":"saneshark","id":591737,"avatar_url":"https://avatars.githubusercontent.com/u/591737?v=3","gravatar_id":"","url":"https://api.github.com/users/saneshark","html_url":"https://github.com/saneshark","followers_url":"https://api.github.com/users/saneshark/followers","following_url":"https://api.github.com/users/saneshark/following{/other_user}","gists_url":"https://api.github.com/users/saneshark/gists{/gist_id}","starred_url":"https://api.github.com/users/saneshark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saneshark/subscriptions","organizations_url":"https://api.github.com/users/saneshark/orgs","repos_url":"https://api.github.com/users/saneshark/repos","events_url":"https://api.github.com/users/saneshark/events{/privacy}","received_events_url":"https://api.github.com/users/saneshark/received_events","type":"User","site_admin":false},{"login":"omgitsbillryan","id":3077884,"avatar_url":"https://avatars.githubusercontent.com/u/3077884?v=3","gravatar_id":"","url":"https://api.github.com/users/omgitsbillryan","html_url":"https://github.com/omgitsbillryan","followers_url":"https://api.github.com/users/omgitsbillryan/followers","following_url":"https://api.github.com/users/omgitsbillryan/following{/other_user}","gists_url":"https://api.github.com/users/omgitsbillryan/gists{/gist_id}","starred_url":"https://api.github.com/users/omgitsbillryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omgitsbillryan/subscriptions","organizations_url":"https://api.github.com/users/omgitsbillryan/orgs","repos_url":"https://api.github.com/users/omgitsbillryan/repos","events_url":"https://api.github.com/users/omgitsbillryan/events{/privacy}","received_events_url":"https://api.github.com/users/omgitsbillryan/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/447/commits","review_comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/447/comments","review_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/447/comments","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/statuses/e7d6df3fb17bce85f252c0d612c2f3e375f5d887","head":{"label":"department-of-veterans-affairs:nosingle","ref":"nosingle","sha":"e7d6df3fb17bce85f252c0d612c2f3e375f5d887","user":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":62409417,"name":"vets-api","full_name":"department-of-veterans-affairs/vets-api","owner":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/department-of-veterans-affairs/vets-api","description":"API for vets.gov","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/releases{/id}","deployments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/deployments","created_at":"2016-07-01T17:33:19Z","updated_at":"2016-11-04T14:35:42Z","pushed_at":"2016-11-06T00:06:59Z","git_url":"git://github.com/department-of-veterans-affairs/vets-api.git","ssh_url":"git@github.com:department-of-veterans-affairs/vets-api.git","clone_url":"https://github.com/department-of-veterans-affairs/vets-api.git","svn_url":"https://github.com/department-of-veterans-affairs/vets-api","homepage":null,"size":6154,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":35,"forks":1,"open_issues":35,"watchers":7,"default_branch":"master"}},"base":{"label":"department-of-veterans-affairs:master","ref":"master","sha":"63bff78dfef4e42336f136eb0d0bc92d0e2d2b85","user":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":62409417,"name":"vets-api","full_name":"department-of-veterans-affairs/vets-api","owner":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/department-of-veterans-affairs/vets-api","description":"API for vets.gov","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/releases{/id}","deployments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/deployments","created_at":"2016-07-01T17:33:19Z","updated_at":"2016-11-04T14:35:42Z","pushed_at":"2016-11-06T00:06:59Z","git_url":"git://github.com/department-of-veterans-affairs/vets-api.git","ssh_url":"git@github.com:department-of-veterans-affairs/vets-api.git","clone_url":"https://github.com/department-of-veterans-affairs/vets-api.git","svn_url":"https://github.com/department-of-veterans-affairs/vets-api","homepage":null,"size":6154,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":35,"forks":1,"open_issues":35,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/447"},"html":{"href":"https://github.com/department-of-veterans-affairs/vets-api/pull/447"},"issue":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/447"},"comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/issues/447/comments"},"review_comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/447/comments"},"review_comment":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/pulls/447/commits"},"statuses":{"href":"https://api.github.com/repos/department-of-veterans-affairs/vets-api/statuses/e7d6df3fb17bce85f252c0d612c2f3e375f5d887"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"aub","id":2895,"avatar_url":"https://avatars.githubusercontent.com/u/2895?v=3","gravatar_id":"","url":"https://api.github.com/users/aub","html_url":"https://github.com/aub","followers_url":"https://api.github.com/users/aub/followers","following_url":"https://api.github.com/users/aub/following{/other_user}","gists_url":"https://api.github.com/users/aub/gists{/gist_id}","starred_url":"https://api.github.com/users/aub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aub/subscriptions","organizations_url":"https://api.github.com/users/aub/orgs","repos_url":"https://api.github.com/users/aub/repos","events_url":"https://api.github.com/users/aub/events{/privacy}","received_events_url":"https://api.github.com/users/aub/received_events","type":"User","site_admin":false},"comments":1,"review_comments":4,"commits":6,"additions":22,"deletions":17,"changed_files":4}}
{"actor":{"display_login":"aub"}}