{"action":"created","comment":{"url":"https://api.github.com/repos/DBCDK/smaug/pulls/comments/74056851","id":74056851,"diff_hunk":"@@ -50,22 +50,18 @@ export default class DbcConfigStore extends InmemoryConfigStore {\n         return new Promise((resolve, reject) => {\n           return this.stores.clientStore.get(client.id)\n             .then((fetchedClient) => {\n-              var overrideAgency = typeof (fetchedClient.search || {}).agency !== 'undefined';\n-              var overrideProfile = typeof (fetchedClient.search || {}).profile !== 'undefined';\n+              const clientConfig = Object.assign({}, fetchedClient.config);\n \n-              if (overrideAgency && overrideProfile) {\n-                config.search.agency = fetchedClient.search.agency;\n-                config.search.profile = fetchedClient.search.profile;\n-              }\n-              else if (overrideAgency || overrideProfile) {\n-                return reject(new Error('both (or neither) client.search.agency and client.search.profile must be set'));\n-              }\n+              var overrideAgency = typeof (clientConfig.search || {}).agency !== 'undefined';\n+              var overrideProfile = typeof (clientConfig.search || {}).profile !== 'undefined';\n \n-              if (typeof (fetchedClient.search || {}).collectionidentifiers !== 'undefined') {\n-                config.search.collectionidentifiers = fetchedClient.search.collectionidentifiers;\n+              if (overrideAgency ? !overrideProfile : overrideProfile) { // XOR","path":"src/oauth/configstore/dbc.js","position":20,"original_position":20,"commit_id":"820d753acdd0981d0a2812a614b02e28c3c4b600","original_commit_id":"820d753acdd0981d0a2812a614b02e28c3c4b600","user":{"login":"adamtulinius","id":749381,"avatar_url":"https://avatars.githubusercontent.com/u/749381?v=3","gravatar_id":"","url":"https://api.github.com/users/adamtulinius","html_url":"https://github.com/adamtulinius","followers_url":"https://api.github.com/users/adamtulinius/followers","following_url":"https://api.github.com/users/adamtulinius/following{/other_user}","gists_url":"https://api.github.com/users/adamtulinius/gists{/gist_id}","starred_url":"https://api.github.com/users/adamtulinius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamtulinius/subscriptions","organizations_url":"https://api.github.com/users/adamtulinius/orgs","repos_url":"https://api.github.com/users/adamtulinius/repos","events_url":"https://api.github.com/users/adamtulinius/events{/privacy}","received_events_url":"https://api.github.com/users/adamtulinius/received_events","type":"User","site_admin":false},"body":"That is just butt-ugly","created_at":"2016-08-09T13:27:40Z","updated_at":"2016-08-09T13:27:40Z","html_url":"https://github.com/DBCDK/smaug/pull/152#discussion_r74056851","pull_request_url":"https://api.github.com/repos/DBCDK/smaug/pulls/152","_links":{"self":{"href":"https://api.github.com/repos/DBCDK/smaug/pulls/comments/74056851"},"html":{"href":"https://github.com/DBCDK/smaug/pull/152#discussion_r74056851"},"pull_request":{"href":"https://api.github.com/repos/DBCDK/smaug/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/DBCDK/smaug/pulls/152","id":80616218,"html_url":"https://github.com/DBCDK/smaug/pull/152","diff_url":"https://github.com/DBCDK/smaug/pull/152.diff","patch_url":"https://github.com/DBCDK/smaug/pull/152.patch","issue_url":"https://api.github.com/repos/DBCDK/smaug/issues/152","number":152,"state":"open","locked":false,"title":"configstore and caching.","user":{"login":"hyatt03","id":2140680,"avatar_url":"https://avatars.githubusercontent.com/u/2140680?v=3","gravatar_id":"","url":"https://api.github.com/users/hyatt03","html_url":"https://github.com/hyatt03","followers_url":"https://api.github.com/users/hyatt03/followers","following_url":"https://api.github.com/users/hyatt03/following{/other_user}","gists_url":"https://api.github.com/users/hyatt03/gists{/gist_id}","starred_url":"https://api.github.com/users/hyatt03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyatt03/subscriptions","organizations_url":"https://api.github.com/users/hyatt03/orgs","repos_url":"https://api.github.com/users/hyatt03/repos","events_url":"https://api.github.com/users/hyatt03/events{/privacy}","received_events_url":"https://api.github.com/users/hyatt03/received_events","type":"User","site_admin":false},"body":"Issue #92 ","created_at":"2016-08-09T13:03:54Z","updated_at":"2016-08-09T13:27:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"765b29ecba3d5521a13fad21c110cd0712e05ce7","assignee":{"login":"adamtulinius","id":749381,"avatar_url":"https://avatars.githubusercontent.com/u/749381?v=3","gravatar_id":"","url":"https://api.github.com/users/adamtulinius","html_url":"https://github.com/adamtulinius","followers_url":"https://api.github.com/users/adamtulinius/followers","following_url":"https://api.github.com/users/adamtulinius/following{/other_user}","gists_url":"https://api.github.com/users/adamtulinius/gists{/gist_id}","starred_url":"https://api.github.com/users/adamtulinius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamtulinius/subscriptions","organizations_url":"https://api.github.com/users/adamtulinius/orgs","repos_url":"https://api.github.com/users/adamtulinius/repos","events_url":"https://api.github.com/users/adamtulinius/events{/privacy}","received_events_url":"https://api.github.com/users/adamtulinius/received_events","type":"User","site_admin":false},"assignees":[{"login":"adamtulinius","id":749381,"avatar_url":"https://avatars.githubusercontent.com/u/749381?v=3","gravatar_id":"","url":"https://api.github.com/users/adamtulinius","html_url":"https://github.com/adamtulinius","followers_url":"https://api.github.com/users/adamtulinius/followers","following_url":"https://api.github.com/users/adamtulinius/following{/other_user}","gists_url":"https://api.github.com/users/adamtulinius/gists{/gist_id}","starred_url":"https://api.github.com/users/adamtulinius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamtulinius/subscriptions","organizations_url":"https://api.github.com/users/adamtulinius/orgs","repos_url":"https://api.github.com/users/adamtulinius/repos","events_url":"https://api.github.com/users/adamtulinius/events{/privacy}","received_events_url":"https://api.github.com/users/adamtulinius/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DBCDK/smaug/pulls/152/commits","review_comments_url":"https://api.github.com/repos/DBCDK/smaug/pulls/152/comments","review_comment_url":"https://api.github.com/repos/DBCDK/smaug/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DBCDK/smaug/issues/152/comments","statuses_url":"https://api.github.com/repos/DBCDK/smaug/statuses/820d753acdd0981d0a2812a614b02e28c3c4b600","head":{"label":"DBCDK:dev/jph","ref":"dev/jph","sha":"820d753acdd0981d0a2812a614b02e28c3c4b600","user":{"login":"DBCDK","id":555633,"avatar_url":"https://avatars.githubusercontent.com/u/555633?v=3","gravatar_id":"","url":"https://api.github.com/users/DBCDK","html_url":"https://github.com/DBCDK","followers_url":"https://api.github.com/users/DBCDK/followers","following_url":"https://api.github.com/users/DBCDK/following{/other_user}","gists_url":"https://api.github.com/users/DBCDK/gists{/gist_id}","starred_url":"https://api.github.com/users/DBCDK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DBCDK/subscriptions","organizations_url":"https://api.github.com/users/DBCDK/orgs","repos_url":"https://api.github.com/users/DBCDK/repos","events_url":"https://api.github.com/users/DBCDK/events{/privacy}","received_events_url":"https://api.github.com/users/DBCDK/received_events","type":"Organization","site_admin":false},"repo":{"id":54030515,"name":"smaug","full_name":"DBCDK/smaug","owner":{"login":"DBCDK","id":555633,"avatar_url":"https://avatars.githubusercontent.com/u/555633?v=3","gravatar_id":"","url":"https://api.github.com/users/DBCDK","html_url":"https://github.com/DBCDK","followers_url":"https://api.github.com/users/DBCDK/followers","following_url":"https://api.github.com/users/DBCDK/following{/other_user}","gists_url":"https://api.github.com/users/DBCDK/gists{/gist_id}","starred_url":"https://api.github.com/users/DBCDK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DBCDK/subscriptions","organizations_url":"https://api.github.com/users/DBCDK/orgs","repos_url":"https://api.github.com/users/DBCDK/repos","events_url":"https://api.github.com/users/DBCDK/events{/privacy}","received_events_url":"https://api.github.com/users/DBCDK/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DBCDK/smaug","description":"authentication service for DBCDK/serviceprovider","fork":false,"url":"https://api.github.com/repos/DBCDK/smaug","forks_url":"https://api.github.com/repos/DBCDK/smaug/forks","keys_url":"https://api.github.com/repos/DBCDK/smaug/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DBCDK/smaug/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DBCDK/smaug/teams","hooks_url":"https://api.github.com/repos/DBCDK/smaug/hooks","issue_events_url":"https://api.github.com/repos/DBCDK/smaug/issues/events{/number}","events_url":"https://api.github.com/repos/DBCDK/smaug/events","assignees_url":"https://api.github.com/repos/DBCDK/smaug/assignees{/user}","branches_url":"https://api.github.com/repos/DBCDK/smaug/branches{/branch}","tags_url":"https://api.github.com/repos/DBCDK/smaug/tags","blobs_url":"https://api.github.com/repos/DBCDK/smaug/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DBCDK/smaug/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DBCDK/smaug/git/refs{/sha}","trees_url":"https://api.github.com/repos/DBCDK/smaug/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DBCDK/smaug/statuses/{sha}","languages_url":"https://api.github.com/repos/DBCDK/smaug/languages","stargazers_url":"https://api.github.com/repos/DBCDK/smaug/stargazers","contributors_url":"https://api.github.com/repos/DBCDK/smaug/contributors","subscribers_url":"https://api.github.com/repos/DBCDK/smaug/subscribers","subscription_url":"https://api.github.com/repos/DBCDK/smaug/subscription","commits_url":"https://api.github.com/repos/DBCDK/smaug/commits{/sha}","git_commits_url":"https://api.github.com/repos/DBCDK/smaug/git/commits{/sha}","comments_url":"https://api.github.com/repos/DBCDK/smaug/comments{/number}","issue_comment_url":"https://api.github.com/repos/DBCDK/smaug/issues/comments{/number}","contents_url":"https://api.github.com/repos/DBCDK/smaug/contents/{+path}","compare_url":"https://api.github.com/repos/DBCDK/smaug/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DBCDK/smaug/merges","archive_url":"https://api.github.com/repos/DBCDK/smaug/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DBCDK/smaug/downloads","issues_url":"https://api.github.com/repos/DBCDK/smaug/issues{/number}","pulls_url":"https://api.github.com/repos/DBCDK/smaug/pulls{/number}","milestones_url":"https://api.github.com/repos/DBCDK/smaug/milestones{/number}","notifications_url":"https://api.github.com/repos/DBCDK/smaug/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DBCDK/smaug/labels{/name}","releases_url":"https://api.github.com/repos/DBCDK/smaug/releases{/id}","deployments_url":"https://api.github.com/repos/DBCDK/smaug/deployments","created_at":"2016-03-16T12:37:03Z","updated_at":"2016-05-23T08:56:49Z","pushed_at":"2016-08-09T13:18:01Z","git_url":"git://github.com/DBCDK/smaug.git","ssh_url":"git@github.com:DBCDK/smaug.git","clone_url":"https://github.com/DBCDK/smaug.git","svn_url":"https://github.com/DBCDK/smaug","homepage":"","size":156,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":1,"default_branch":"master"}},"base":{"label":"DBCDK:master","ref":"master","sha":"fedaa0c2b6e23b258bd7b8d8a54a51149a4e1c52","user":{"login":"DBCDK","id":555633,"avatar_url":"https://avatars.githubusercontent.com/u/555633?v=3","gravatar_id":"","url":"https://api.github.com/users/DBCDK","html_url":"https://github.com/DBCDK","followers_url":"https://api.github.com/users/DBCDK/followers","following_url":"https://api.github.com/users/DBCDK/following{/other_user}","gists_url":"https://api.github.com/users/DBCDK/gists{/gist_id}","starred_url":"https://api.github.com/users/DBCDK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DBCDK/subscriptions","organizations_url":"https://api.github.com/users/DBCDK/orgs","repos_url":"https://api.github.com/users/DBCDK/repos","events_url":"https://api.github.com/users/DBCDK/events{/privacy}","received_events_url":"https://api.github.com/users/DBCDK/received_events","type":"Organization","site_admin":false},"repo":{"id":54030515,"name":"smaug","full_name":"DBCDK/smaug","owner":{"login":"DBCDK","id":555633,"avatar_url":"https://avatars.githubusercontent.com/u/555633?v=3","gravatar_id":"","url":"https://api.github.com/users/DBCDK","html_url":"https://github.com/DBCDK","followers_url":"https://api.github.com/users/DBCDK/followers","following_url":"https://api.github.com/users/DBCDK/following{/other_user}","gists_url":"https://api.github.com/users/DBCDK/gists{/gist_id}","starred_url":"https://api.github.com/users/DBCDK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DBCDK/subscriptions","organizations_url":"https://api.github.com/users/DBCDK/orgs","repos_url":"https://api.github.com/users/DBCDK/repos","events_url":"https://api.github.com/users/DBCDK/events{/privacy}","received_events_url":"https://api.github.com/users/DBCDK/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DBCDK/smaug","description":"authentication service for DBCDK/serviceprovider","fork":false,"url":"https://api.github.com/repos/DBCDK/smaug","forks_url":"https://api.github.com/repos/DBCDK/smaug/forks","keys_url":"https://api.github.com/repos/DBCDK/smaug/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DBCDK/smaug/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DBCDK/smaug/teams","hooks_url":"https://api.github.com/repos/DBCDK/smaug/hooks","issue_events_url":"https://api.github.com/repos/DBCDK/smaug/issues/events{/number}","events_url":"https://api.github.com/repos/DBCDK/smaug/events","assignees_url":"https://api.github.com/repos/DBCDK/smaug/assignees{/user}","branches_url":"https://api.github.com/repos/DBCDK/smaug/branches{/branch}","tags_url":"https://api.github.com/repos/DBCDK/smaug/tags","blobs_url":"https://api.github.com/repos/DBCDK/smaug/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DBCDK/smaug/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DBCDK/smaug/git/refs{/sha}","trees_url":"https://api.github.com/repos/DBCDK/smaug/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DBCDK/smaug/statuses/{sha}","languages_url":"https://api.github.com/repos/DBCDK/smaug/languages","stargazers_url":"https://api.github.com/repos/DBCDK/smaug/stargazers","contributors_url":"https://api.github.com/repos/DBCDK/smaug/contributors","subscribers_url":"https://api.github.com/repos/DBCDK/smaug/subscribers","subscription_url":"https://api.github.com/repos/DBCDK/smaug/subscription","commits_url":"https://api.github.com/repos/DBCDK/smaug/commits{/sha}","git_commits_url":"https://api.github.com/repos/DBCDK/smaug/git/commits{/sha}","comments_url":"https://api.github.com/repos/DBCDK/smaug/comments{/number}","issue_comment_url":"https://api.github.com/repos/DBCDK/smaug/issues/comments{/number}","contents_url":"https://api.github.com/repos/DBCDK/smaug/contents/{+path}","compare_url":"https://api.github.com/repos/DBCDK/smaug/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DBCDK/smaug/merges","archive_url":"https://api.github.com/repos/DBCDK/smaug/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DBCDK/smaug/downloads","issues_url":"https://api.github.com/repos/DBCDK/smaug/issues{/number}","pulls_url":"https://api.github.com/repos/DBCDK/smaug/pulls{/number}","milestones_url":"https://api.github.com/repos/DBCDK/smaug/milestones{/number}","notifications_url":"https://api.github.com/repos/DBCDK/smaug/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DBCDK/smaug/labels{/name}","releases_url":"https://api.github.com/repos/DBCDK/smaug/releases{/id}","deployments_url":"https://api.github.com/repos/DBCDK/smaug/deployments","created_at":"2016-03-16T12:37:03Z","updated_at":"2016-05-23T08:56:49Z","pushed_at":"2016-08-09T13:18:01Z","git_url":"git://github.com/DBCDK/smaug.git","ssh_url":"git@github.com:DBCDK/smaug.git","clone_url":"https://github.com/DBCDK/smaug.git","svn_url":"https://github.com/DBCDK/smaug","homepage":"","size":156,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DBCDK/smaug/pulls/152"},"html":{"href":"https://github.com/DBCDK/smaug/pull/152"},"issue":{"href":"https://api.github.com/repos/DBCDK/smaug/issues/152"},"comments":{"href":"https://api.github.com/repos/DBCDK/smaug/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/DBCDK/smaug/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/DBCDK/smaug/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DBCDK/smaug/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/DBCDK/smaug/statuses/820d753acdd0981d0a2812a614b02e28c3c4b600"}}}}
{"actor":{"display_login":"adamtulinius"}}