{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6138","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6138/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6138/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6138/events","html_url":"https://github.com/cockroachdb/cockroach/pull/6138","id":149292881,"number":6138,"title":"sql: Correctly send timestamps with(out) offset based on `WITH TIME ZONE`","user":{"login":"dt","id":15615,"avatar_url":"https://avatars.githubusercontent.com/u/15615?v=3","gravatar_id":"","url":"https://api.github.com/users/dt","html_url":"https://github.com/dt","followers_url":"https://api.github.com/users/dt/followers","following_url":"https://api.github.com/users/dt/following{/other_user}","gists_url":"https://api.github.com/users/dt/gists{/gist_id}","starred_url":"https://api.github.com/users/dt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dt/subscriptions","organizations_url":"https://api.github.com/users/dt/orgs","repos_url":"https://api.github.com/users/dt/repos","events_url":"https://api.github.com/users/dt/events{/privacy}","received_events_url":"https://api.github.com/users/dt/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cockroachdb/cockroach/labels/docs-todo","name":"docs-todo","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"vivekmenezes","id":11774212,"avatar_url":"https://avatars.githubusercontent.com/u/11774212?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekmenezes","html_url":"https://github.com/vivekmenezes","followers_url":"https://api.github.com/users/vivekmenezes/followers","following_url":"https://api.github.com/users/vivekmenezes/following{/other_user}","gists_url":"https://api.github.com/users/vivekmenezes/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekmenezes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekmenezes/subscriptions","organizations_url":"https://api.github.com/users/vivekmenezes/orgs","repos_url":"https://api.github.com/users/vivekmenezes/repos","events_url":"https://api.github.com/users/vivekmenezes/events{/privacy}","received_events_url":"https://api.github.com/users/vivekmenezes/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2016-04-18T22:44:45Z","updated_at":"2016-04-19T21:15:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6138","html_url":"https://github.com/cockroachdb/cockroach/pull/6138","diff_url":"https://github.com/cockroachdb/cockroach/pull/6138.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/6138.patch"},"body":"A `TIMESTAMP WITH TIME ZONE` should be rendered in the session timezone and include an explicit offset, while a `TIMESTAMP` should have no offset (and some clients in fact fail to parse one with an offset).\r\n\r\nTo support that we also need to correctly parse `WITH TIME ZONE` and plumb that attribute through to/from the column type, and make the session's location available to pgwire's rendering.\r\n\r\nCloses #5863.\r\nCloses #5953.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/6138)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/212133696","html_url":"https://github.com/cockroachdb/cockroach/pull/6138#issuecomment-212133696","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6138","id":212133696,"user":{"login":"dt","id":15615,"avatar_url":"https://avatars.githubusercontent.com/u/15615?v=3","gravatar_id":"","url":"https://api.github.com/users/dt","html_url":"https://github.com/dt","followers_url":"https://api.github.com/users/dt/followers","following_url":"https://api.github.com/users/dt/following{/other_user}","gists_url":"https://api.github.com/users/dt/gists{/gist_id}","starred_url":"https://api.github.com/users/dt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dt/subscriptions","organizations_url":"https://api.github.com/users/dt/orgs","repos_url":"https://api.github.com/users/dt/repos","events_url":"https://api.github.com/users/dt/events{/privacy}","received_events_url":"https://api.github.com/users/dt/received_events","type":"User","site_admin":false},"created_at":"2016-04-19T21:15:51Z","updated_at":"2016-04-19T21:15:51Z","body":"Alternative implementation that uses separate types for timestamps with and without offsets #6165"}}