{"action":"created","issue":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/7995","repository_url":"https://api.github.com/repos/code-dot-org/code-dot-org","labels_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/7995/labels{/name}","comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/7995/comments","events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/7995/events","html_url":"https://github.com/code-dot-org/code-dot-org/pull/7995","id":150233039,"number":7995,"title":"Include hammer and lodash normally","user":{"login":"islemaster","id":1615761,"avatar_url":"https://avatars.githubusercontent.com/u/1615761?v=3","gravatar_id":"","url":"https://api.github.com/users/islemaster","html_url":"https://github.com/islemaster","followers_url":"https://api.github.com/users/islemaster/followers","following_url":"https://api.github.com/users/islemaster/following{/other_user}","gists_url":"https://api.github.com/users/islemaster/gists{/gist_id}","starred_url":"https://api.github.com/users/islemaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/islemaster/subscriptions","organizations_url":"https://api.github.com/users/islemaster/orgs","repos_url":"https://api.github.com/users/islemaster/repos","events_url":"https://api.github.com/users/islemaster/events{/privacy}","received_events_url":"https://api.github.com/users/islemaster/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bcjordan","id":206973,"avatar_url":"https://avatars.githubusercontent.com/u/206973?v=3","gravatar_id":"","url":"https://api.github.com/users/bcjordan","html_url":"https://github.com/bcjordan","followers_url":"https://api.github.com/users/bcjordan/followers","following_url":"https://api.github.com/users/bcjordan/following{/other_user}","gists_url":"https://api.github.com/users/bcjordan/gists{/gist_id}","starred_url":"https://api.github.com/users/bcjordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcjordan/subscriptions","organizations_url":"https://api.github.com/users/bcjordan/orgs","repos_url":"https://api.github.com/users/bcjordan/repos","events_url":"https://api.github.com/users/bcjordan/events{/privacy}","received_events_url":"https://api.github.com/users/bcjordan/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-04-22T00:59:42Z","updated_at":"2016-04-22T01:05:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/7995","html_url":"https://github.com/code-dot-org/code-dot-org/pull/7995","diff_url":"https://github.com/code-dot-org/code-dot-org/pull/7995.diff","patch_url":"https://github.com/code-dot-org/code-dot-org/pull/7995.patch"},"body":"Before we were using special `getHammer` and `getLodash` functions in utils to include those libraries (though inconsistently).  Ironically, utils.js itself didn't need either library.  This PR removes those helpers and changes every place they were used to include using normal `require()` syntax.  It also cleans up some related include errors I found along the way (including full lodash, for example).\r\n\r\n### Benefits\r\n* Requiring utils.js no longer introduces a dependency on window, which may lead to faster test iteration in some cases.\r\n* Being consistent about how we require these will help us stay consistent in the future, and maybe make it easier to update if/when we switch to standard lodash.\r\n\r\n### Risks\r\n* It seems the getLodash util was originally added so we could wrap the require statement in some weird amd fixup.  I'm not sure what its original purpose was, but I don't see that it's still necessary."},"comment":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/comments/213188756","html_url":"https://github.com/code-dot-org/code-dot-org/pull/7995#issuecomment-213188756","issue_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/7995","id":213188756,"user":{"login":"islemaster","id":1615761,"avatar_url":"https://avatars.githubusercontent.com/u/1615761?v=3","gravatar_id":"","url":"https://api.github.com/users/islemaster","html_url":"https://github.com/islemaster","followers_url":"https://api.github.com/users/islemaster/followers","following_url":"https://api.github.com/users/islemaster/following{/other_user}","gists_url":"https://api.github.com/users/islemaster/gists{/gist_id}","starred_url":"https://api.github.com/users/islemaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/islemaster/subscriptions","organizations_url":"https://api.github.com/users/islemaster/orgs","repos_url":"https://api.github.com/users/islemaster/repos","events_url":"https://api.github.com/users/islemaster/events{/privacy}","received_events_url":"https://api.github.com/users/islemaster/received_events","type":"User","site_admin":false},"created_at":"2016-04-22T01:05:20Z","updated_at":"2016-04-22T01:05:20Z","body":"Note: I carefully verified that utils was included everywhere that `Function.prototype.inherits` or `String.prototype.repeats` is used, even if it appeared to be otherwise unused."}}