{"action":"created","issue":{"url":"https://api.github.com/repos/davidker/unisys/issues/33","repository_url":"https://api.github.com/repos/davidker/unisys","labels_url":"https://api.github.com/repos/davidker/unisys/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/davidker/unisys/issues/33/comments","events_url":"https://api.github.com/repos/davidker/unisys/issues/33/events","html_url":"https://github.com/davidker/unisys/issues/33","id":152600915,"number":33,"title":"visorhba: visor_thread_start(): setting 'thrinfo->id = 0' in error path isn't enough","user":{"login":"selltc","id":12817577,"avatar_url":"https://avatars.githubusercontent.com/u/12817577?v=3","gravatar_id":"","url":"https://api.github.com/users/selltc","html_url":"https://github.com/selltc","followers_url":"https://api.github.com/users/selltc/followers","following_url":"https://api.github.com/users/selltc/following{/other_user}","gists_url":"https://api.github.com/users/selltc/gists{/gist_id}","starred_url":"https://api.github.com/users/selltc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selltc/subscriptions","organizations_url":"https://api.github.com/users/selltc/orgs","repos_url":"https://api.github.com/users/selltc/repos","events_url":"https://api.github.com/users/selltc/events{/privacy}","received_events_url":"https://api.github.com/users/selltc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-02T17:27:28Z","updated_at":"2016-05-03T18:45:17Z","closed_at":null,"body":"Even though we do `thrinfo->id = 0` in the error path, this isn't enough to prevent the code from accessing thrinfo->task later on, even though it is an invalid value.\r\n\r\nSource: Dan Carpenter <dan.carpenter@oracle.com> Mon 5/2/2016 5:53 AM\r\n> visor_thread_start():\r\n> I'm nervous about the error handling here.  Is setting ->id to zero\r\n> really sufficient to prevent dereferencing ->task?\r\n\r\nSee [KanBoard-991](http://ustr-erl-6690.na.uis.unisys.com/?controller=task&action=show&task_id=991&project_id=37)\r\n"},"comment":{"url":"https://api.github.com/repos/davidker/unisys/issues/comments/216626458","html_url":"https://github.com/davidker/unisys/issues/33#issuecomment-216626458","issue_url":"https://api.github.com/repos/davidker/unisys/issues/33","id":216626458,"user":{"login":"selltc","id":12817577,"avatar_url":"https://avatars.githubusercontent.com/u/12817577?v=3","gravatar_id":"","url":"https://api.github.com/users/selltc","html_url":"https://github.com/selltc","followers_url":"https://api.github.com/users/selltc/followers","following_url":"https://api.github.com/users/selltc/following{/other_user}","gists_url":"https://api.github.com/users/selltc/gists{/gist_id}","starred_url":"https://api.github.com/users/selltc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selltc/subscriptions","organizations_url":"https://api.github.com/users/selltc/orgs","repos_url":"https://api.github.com/users/selltc/repos","events_url":"https://api.github.com/users/selltc/events{/privacy}","received_events_url":"https://api.github.com/users/selltc/received_events","type":"User","site_admin":false},"created_at":"2016-05-03T18:45:17Z","updated_at":"2016-05-03T18:45:17Z","body":"Commit a6c51b1825a983fd17e0947ae972de3810085c2a is my first-crack at this.  It is regression-test and checkpatch clean."}}