{"action":"created","issue":{"url":"https://api.github.com/repos/meedan/react-native-share-menu/issues/10","repository_url":"https://api.github.com/repos/meedan/react-native-share-menu","labels_url":"https://api.github.com/repos/meedan/react-native-share-menu/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/meedan/react-native-share-menu/issues/10/comments","events_url":"https://api.github.com/repos/meedan/react-native-share-menu/issues/10/events","html_url":"https://github.com/meedan/react-native-share-menu/issues/10","id":181635379,"number":10,"title":"Android: method does not override or implement a method from a supertype @Override","user":{"login":"alyrik","id":10388022,"avatar_url":"https://avatars.githubusercontent.com/u/10388022?v=3","gravatar_id":"","url":"https://api.github.com/users/alyrik","html_url":"https://github.com/alyrik","followers_url":"https://api.github.com/users/alyrik/followers","following_url":"https://api.github.com/users/alyrik/following{/other_user}","gists_url":"https://api.github.com/users/alyrik/gists{/gist_id}","starred_url":"https://api.github.com/users/alyrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alyrik/subscriptions","organizations_url":"https://api.github.com/users/alyrik/orgs","repos_url":"https://api.github.com/users/alyrik/repos","events_url":"https://api.github.com/users/alyrik/events{/privacy}","received_events_url":"https://api.github.com/users/alyrik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-07T10:30:49Z","updated_at":"2016-10-07T12:35:26Z","closed_at":null,"body":"```\r\n.../MainActivity.java:26: error: method does not override or implement a method from a supertype\r\n    @Override\r\n    ^\r\n1 error\r\n:app:compileDebugJavaWithJavac FAILED\r\n```\r\n\r\nI'n using RN 0.34.1.\r\n\r\nFile MainActivity.java seems to be originally structured in a different way you described it in Readme:\r\n\r\n ```\r\npackage com.androidreact;\r\n\r\nimport com.facebook.react.ReactActivity;\r\n\r\npublic class MainActivity extends ReactActivity {\r\n\r\n    /**\r\n     * Returns the name of the main component registered from JavaScript.\r\n     * This is used to schedule rendering of the component.\r\n     */\r\n    @Override\r\n    protected String getMainComponentName() {\r\n        return \"AndroidReact\";\r\n    }\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/meedan/react-native-share-menu/issues/comments/252240942","html_url":"https://github.com/meedan/react-native-share-menu/issues/10#issuecomment-252240942","issue_url":"https://api.github.com/repos/meedan/react-native-share-menu/issues/10","id":252240942,"user":{"login":"alyrik","id":10388022,"avatar_url":"https://avatars.githubusercontent.com/u/10388022?v=3","gravatar_id":"","url":"https://api.github.com/users/alyrik","html_url":"https://github.com/alyrik","followers_url":"https://api.github.com/users/alyrik/followers","following_url":"https://api.github.com/users/alyrik/following{/other_user}","gists_url":"https://api.github.com/users/alyrik/gists{/gist_id}","starred_url":"https://api.github.com/users/alyrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alyrik/subscriptions","organizations_url":"https://api.github.com/users/alyrik/orgs","repos_url":"https://api.github.com/users/alyrik/repos","events_url":"https://api.github.com/users/alyrik/events{/privacy}","received_events_url":"https://api.github.com/users/alyrik/received_events","type":"User","site_admin":false},"created_at":"2016-10-07T12:35:26Z","updated_at":"2016-10-07T12:35:26Z","body":"It builds without error only with RN 0.28.\r\n\r\nThis activity is generated by RN generator. There are two files:\r\n![screen shot 2016-10-07 at 15 33 53](https://cloud.githubusercontent.com/assets/10388022/19189980/8189189c-8ca3-11e6-905b-3e92c25a8040.png)\r\n\r\nThe contents of the second file is following:\r\n\r\n```\r\npackage com.androidreact;\r\n\r\nimport android.app.Application;\r\nimport android.util.Log;\r\n\r\nimport com.facebook.react.ReactApplication;\r\nimport com.facebook.react.ReactInstanceManager;\r\nimport com.facebook.react.ReactNativeHost;\r\nimport com.facebook.react.ReactPackage;\r\nimport com.facebook.react.shell.MainReactPackage;\r\n\r\nimport java.util.Arrays;\r\nimport java.util.List;\r\n\r\npublic class MainApplication extends Application implements ReactApplication {\r\n\r\n  private final ReactNativeHost mReactNativeHost = new ReactNativeHost(this) {\r\n    @Override\r\n    protected boolean getUseDeveloperSupport() {\r\n      return BuildConfig.DEBUG;\r\n    }\r\n\r\n    @Override\r\n    protected List<ReactPackage> getPackages() {\r\n      return Arrays.<ReactPackage>asList(\r\n          new MainReactPackage()\r\n      );\r\n    }\r\n  };\r\n\r\n  @Override\r\n  public ReactNativeHost getReactNativeHost() {\r\n      return mReactNativeHost;\r\n  }\r\n}\r\n```\r\n"}}
{"actor":{"display_login":"alyrik"}}