{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/comments/54169090","id":54169090,"diff_hunk":"@@ -96,33 +94,32 @@ export class CommandExecutor {\n             }\n         });\n \n-        Q.delay(300).then(() => deferred.resolve(result.spawnedProcess));\n+        // TODO - PROMISE: We need to consume result.outcome here","path":"src/common/commandExecutor.ts","position":42,"original_position":42,"commit_id":"0af0605ced5125b9f36750b772599c36757efe10","original_commit_id":"0af0605ced5125b9f36750b772599c36757efe10","user":{"login":"dlebu","id":12283206,"avatar_url":"https://avatars.githubusercontent.com/u/12283206?v=3","gravatar_id":"","url":"https://api.github.com/users/dlebu","html_url":"https://github.com/dlebu","followers_url":"https://api.github.com/users/dlebu/followers","following_url":"https://api.github.com/users/dlebu/following{/other_user}","gists_url":"https://api.github.com/users/dlebu/gists{/gist_id}","starred_url":"https://api.github.com/users/dlebu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlebu/subscriptions","organizations_url":"https://api.github.com/users/dlebu/orgs","repos_url":"https://api.github.com/users/dlebu/repos","events_url":"https://api.github.com/users/dlebu/events{/privacy}","received_events_url":"https://api.github.com/users/dlebu/received_events","type":"User","site_admin":false},"body":"Is there anything blocking us from consuming `result.outcome`?","created_at":"2016-02-25T21:38:48Z","updated_at":"2016-02-25T21:38:48Z","html_url":"https://github.com/Microsoft/vscode-react-native/pull/79#discussion_r54169090","pull_request_url":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/79","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/comments/54169090"},"html":{"href":"https://github.com/Microsoft/vscode-react-native/pull/79#discussion_r54169090"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/79"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/79","id":60557413,"html_url":"https://github.com/Microsoft/vscode-react-native/pull/79","diff_url":"https://github.com/Microsoft/vscode-react-native/pull/79.diff","patch_url":"https://github.com/Microsoft/vscode-react-native/pull/79.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode-react-native/issues/79","number":79,"state":"open","locked":false,"title":"Rewrote code to have a single pipe of promises, that propagates all the fatal errors to the top level. Created entryPoint class to properly capture and show errors in all the entry points in the code","user":{"login":"digeff","id":14098140,"avatar_url":"https://avatars.githubusercontent.com/u/14098140?v=3","gravatar_id":"","url":"https://api.github.com/users/digeff","html_url":"https://github.com/digeff","followers_url":"https://api.github.com/users/digeff/followers","following_url":"https://api.github.com/users/digeff/following{/other_user}","gists_url":"https://api.github.com/users/digeff/gists{/gist_id}","starred_url":"https://api.github.com/users/digeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digeff/subscriptions","organizations_url":"https://api.github.com/users/digeff/orgs","repos_url":"https://api.github.com/users/digeff/repos","events_url":"https://api.github.com/users/digeff/events{/privacy}","received_events_url":"https://api.github.com/users/digeff/received_events","type":"User","site_admin":false},"body":"* Rewrote code to have a single pipe of promises, that propagates all the fatal errors to the top level\r\n* Created entryPoint class to properly capture and show errors in all the entry points in the code\r\n\r\nThis PR should solve these two issues: \r\n - https://github.com/Microsoft/vscode-react-native/issues/55\r\n - https://github.com/Microsoft/vscode-react-native/issues/69\r\n\r\nI added some TODO - PROMISEs that should be addressed when we solve this issue: https://github.com/Microsoft/vscode-react-native/issues/56","created_at":"2016-02-24T18:43:06Z","updated_at":"2016-02-25T21:38:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79f4edf1b8fb40a3e040672e8e8db378661b914a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/79/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/79/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode-react-native/issues/79/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode-react-native/statuses/0af0605ced5125b9f36750b772599c36757efe10","head":{"label":"Microsoft:reorganized_promises_pipeing","ref":"reorganized_promises_pipeing","sha":"0af0605ced5125b9f36750b772599c36757efe10","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":50060429,"name":"vscode-react-native","full_name":"Microsoft/vscode-react-native","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-react-native","description":"vscode extension for react native","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-react-native","forks_url":"https://api.github.com/repos/Microsoft/vscode-react-native/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-react-native/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-react-native/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-react-native/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-react-native/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-react-native/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-react-native/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-react-native/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-react-native/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-react-native/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-react-native/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-react-native/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-react-native/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-react-native/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-react-native/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-react-native/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-react-native/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-react-native/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-react-native/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-react-native/deployments","created_at":"2016-01-20T21:10:07Z","updated_at":"2016-02-25T17:52:12Z","pushed_at":"2016-02-25T20:14:01Z","git_url":"git://github.com/Microsoft/vscode-react-native.git","ssh_url":"git@github.com:Microsoft/vscode-react-native.git","clone_url":"https://github.com/Microsoft/vscode-react-native.git","svn_url":"https://github.com/Microsoft/vscode-react-native","homepage":null,"size":3084,"stargazers_count":63,"watchers_count":63,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":19,"forks":0,"open_issues":19,"watchers":63,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"65d822180b4afc49591a59155f833c84c57c7875","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":50060429,"name":"vscode-react-native","full_name":"Microsoft/vscode-react-native","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-react-native","description":"vscode extension for react native","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-react-native","forks_url":"https://api.github.com/repos/Microsoft/vscode-react-native/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-react-native/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-react-native/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-react-native/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-react-native/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-react-native/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-react-native/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-react-native/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-react-native/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-react-native/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-react-native/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-react-native/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-react-native/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-react-native/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-react-native/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-react-native/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-react-native/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-react-native/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-react-native/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-react-native/deployments","created_at":"2016-01-20T21:10:07Z","updated_at":"2016-02-25T17:52:12Z","pushed_at":"2016-02-25T20:14:01Z","git_url":"git://github.com/Microsoft/vscode-react-native.git","ssh_url":"git@github.com:Microsoft/vscode-react-native.git","clone_url":"https://github.com/Microsoft/vscode-react-native.git","svn_url":"https://github.com/Microsoft/vscode-react-native","homepage":null,"size":3084,"stargazers_count":63,"watchers_count":63,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":19,"forks":0,"open_issues":19,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/79"},"html":{"href":"https://github.com/Microsoft/vscode-react-native/pull/79"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode-react-native/issues/79"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode-react-native/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode-react-native/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode-react-native/statuses/0af0605ced5125b9f36750b772599c36757efe10"}}}}