{"action":"created","comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/71738970","id":71738970,"diff_hunk":"@@ -3339,9 +3327,8 @@ float vehicle::wheels_area (int *const cnt) const\n float vehicle::k_friction() const\n {\n     // calculate safe speed reduction due to wheel friction\n-    float fr0 = 1000.0;\n-    float kf = ( fr0 / (fr0 + wheels_area()) );\n-    return kf;\n+    constexpr float fr0 = 9000.0;","path":"src/vehicle.cpp","position":37,"original_position":37,"commit_id":"2d3542a41be7bdd8197a737e0a86869b45580fc0","original_commit_id":"d26488ce1db60f61a7bf8ad03efa2a4941678836","user":{"login":"mugling","id":12238606,"avatar_url":"https://avatars.githubusercontent.com/u/12238606?v=3","gravatar_id":"","url":"https://api.github.com/users/mugling","html_url":"https://github.com/mugling","followers_url":"https://api.github.com/users/mugling/followers","following_url":"https://api.github.com/users/mugling/following{/other_user}","gists_url":"https://api.github.com/users/mugling/gists{/gist_id}","starred_url":"https://api.github.com/users/mugling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mugling/subscriptions","organizations_url":"https://api.github.com/users/mugling/orgs","repos_url":"https://api.github.com/users/mugling/repos","events_url":"https://api.github.com/users/mugling/events{/privacy}","received_events_url":"https://api.github.com/users/mugling/received_events","type":"User","site_admin":false},"body":"Might be best to document is as unknown magical value - at least that makes it clear future removal would be acceptable","created_at":"2016-07-21T16:27:11Z","updated_at":"2016-07-21T16:27:11Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/17687#discussion_r71738970","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/17687","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/71738970"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/17687#discussion_r71738970"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/17687"}}},"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/17687","id":77496912,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/17687","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/17687.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/17687.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/17687","number":17687,"state":"open","locked":false,"title":"Vehicle boat/traction update","user":{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars.githubusercontent.com/u/1878860?v=3","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false},"body":"Mostly refactoring for future land vehicle/boat split.\r\nWheel configuration, traction etc. functions got a `bool boat` argument. If false, it checks the wheels. If true, the boat parts.\r\n\r\nOther code changes:\r\n* Removed hardcoded division by 9 of wheel area. Adjusted `k_mass` so that it doesn't change from current values.\r\n* Removed some hardcoded boat checks\r\n* Changed the \"nothing grabbed\" condition from `grab_point == tripoint_zero` to `grab_type == OBJECT_NONE`. This allows grabbing stuff below self\r\n\r\nGameplay changes:\r\n* Updated vehicle push/pull. Had to, because vehicle push/pull is related to all of: traction, wheel configuration, pivoting. All of those were changed here, so vehicle grab could easily regress otherwise. On the positive side, the changes make dragging bicycles a much less painful experience for the user - I didn't manage to lose my grabbed bike by walking around.\r\n* Added a \"K traction\" display to vehicle interaction menu. It displays the multiplier on acceleration (1.0 or less) due to bad traction, calculated for dirt (the most common terrain for offroading).\r\n* Added a warning message when acceleration of a vehicle is 0. Can happen when biking on a heavy vehicle, for example.","created_at":"2016-07-14T17:49:58Z","updated_at":"2016-07-21T16:27:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9f2601bf7712759b7224550e789fd6acb63018c","assignee":{"login":"mugling","id":12238606,"avatar_url":"https://avatars.githubusercontent.com/u/12238606?v=3","gravatar_id":"","url":"https://api.github.com/users/mugling","html_url":"https://github.com/mugling","followers_url":"https://api.github.com/users/mugling/followers","following_url":"https://api.github.com/users/mugling/following{/other_user}","gists_url":"https://api.github.com/users/mugling/gists{/gist_id}","starred_url":"https://api.github.com/users/mugling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mugling/subscriptions","organizations_url":"https://api.github.com/users/mugling/orgs","repos_url":"https://api.github.com/users/mugling/repos","events_url":"https://api.github.com/users/mugling/events{/privacy}","received_events_url":"https://api.github.com/users/mugling/received_events","type":"User","site_admin":false},"assignees":[{"login":"mugling","id":12238606,"avatar_url":"https://avatars.githubusercontent.com/u/12238606?v=3","gravatar_id":"","url":"https://api.github.com/users/mugling","html_url":"https://github.com/mugling","followers_url":"https://api.github.com/users/mugling/followers","following_url":"https://api.github.com/users/mugling/following{/other_user}","gists_url":"https://api.github.com/users/mugling/gists{/gist_id}","starred_url":"https://api.github.com/users/mugling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mugling/subscriptions","organizations_url":"https://api.github.com/users/mugling/orgs","repos_url":"https://api.github.com/users/mugling/repos","events_url":"https://api.github.com/users/mugling/events{/privacy}","received_events_url":"https://api.github.com/users/mugling/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/17687/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/17687/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/17687/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/2d3542a41be7bdd8197a737e0a86869b45580fc0","head":{"label":"Coolthulhu:vehicle-boat-disp","ref":"vehicle-boat-disp","sha":"2d3542a41be7bdd8197a737e0a86869b45580fc0","user":{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars.githubusercontent.com/u/1878860?v=3","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false},"repo":{"id":23649904,"name":"Cataclysm-DDA","full_name":"Coolthulhu/Cataclysm-DDA","owner":{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars.githubusercontent.com/u/1878860?v=3","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Coolthulhu/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA","forks_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/Coolthulhu/Cataclysm-DDA/deployments","created_at":"2014-09-04T05:39:34Z","updated_at":"2016-01-12T18:12:09Z","pushed_at":"2016-07-21T15:45:34Z","git_url":"git://github.com/Coolthulhu/Cataclysm-DDA.git","ssh_url":"git@github.com:Coolthulhu/Cataclysm-DDA.git","clone_url":"https://github.com/Coolthulhu/Cataclysm-DDA.git","svn_url":"https://github.com/Coolthulhu/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":830440,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"d667c8cc7ba3fd904e9b06cfc8ba186aabf0ee4f","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/deployments","created_at":"2012-09-26T22:57:43Z","updated_at":"2016-07-21T14:15:44Z","pushed_at":"2016-07-21T15:45:36Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":1097143,"stargazers_count":997,"watchers_count":997,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":914,"mirror_url":null,"open_issues_count":1271,"forks":914,"open_issues":1271,"watchers":997,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/17687"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/17687"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/17687"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/17687/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/17687/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/17687/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/2d3542a41be7bdd8197a737e0a86869b45580fc0"}}}}
{"actor":{"display_login":"mugling"}}