{"action":"created","issue":{"url":"https://api.github.com/repos/LMMS/lmms/issues/2574","repository_url":"https://api.github.com/repos/LMMS/lmms","labels_url":"https://api.github.com/repos/LMMS/lmms/issues/2574/labels{/name}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/2574/comments","events_url":"https://api.github.com/repos/LMMS/lmms/issues/2574/events","html_url":"https://github.com/LMMS/lmms/pull/2574","id":134107224,"number":2574,"title":"Refactor the drawing of TCO's; Get rid of hardcoded colors in TCOs; Even out the color scheme","user":{"login":"Umcaruje","id":6282045,"avatar_url":"https://avatars.githubusercontent.com/u/6282045?v=3","gravatar_id":"","url":"https://api.github.com/users/Umcaruje","html_url":"https://github.com/Umcaruje","followers_url":"https://api.github.com/users/Umcaruje/followers","following_url":"https://api.github.com/users/Umcaruje/following{/other_user}","gists_url":"https://api.github.com/users/Umcaruje/gists{/gist_id}","starred_url":"https://api.github.com/users/Umcaruje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Umcaruje/subscriptions","organizations_url":"https://api.github.com/users/Umcaruje/orgs","repos_url":"https://api.github.com/users/Umcaruje/repos","events_url":"https://api.github.com/users/Umcaruje/events{/privacy}","received_events_url":"https://api.github.com/users/Umcaruje/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":22,"created_at":"2016-02-16T21:53:27Z","updated_at":"2016-02-29T18:18:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/2574","html_url":"https://github.com/LMMS/lmms/pull/2574","diff_url":"https://github.com/LMMS/lmms/pull/2574.diff","patch_url":"https://github.com/LMMS/lmms/pull/2574.patch"},"body":"Per https://github.com/HDDigitizerMusic/lmms-alt-theme/issues/8\r\n\r\nFixes #2148\r\n\r\nThis PR does several things:\r\n\r\n1. Fixes incorrect rendering of TCO's: they was a one pixel gap between the grid and the TCOs. Also fix the incorect rendering of the bar-lines on Instrument pattern TCO's:\r\nBefore & after\r\n![screenshot from 2016-02-16 22 36 26](https://cloud.githubusercontent.com/assets/6282045/13092401/031899b6-d500-11e5-9cf4-535731f54c30.png)     ![screenshot from 2016-02-16 22 36 48](https://cloud.githubusercontent.com/assets/6282045/13092402/031bab4c-d500-11e5-85b2-c80b8aae5cca.png)\r\n\r\n2. Adds a Boolean `qproperty-gradient` that allows themers to get rid of the hardcoded gradients on TCO's. \r\n\r\n3. Removes all of the hard coded colors, so now you can change the color of a muted and selected TCO, as well as the shadow of the text.\r\n\r\n4. Evens out the muted and selected colors, so they all are the same.\r\n\r\n5. Implements missing muted foreground color for automation patterns.\r\n\r\n6. All pattern text stays the same color when the pattern is muted, for better readability.\r\n\r\nComparison:\r\n\r\nOld\r\n![screenshot from 2016-02-16 22 30 25](https://cloud.githubusercontent.com/assets/6282045/13092345/b5363c62-d4ff-11e5-8bdc-5f864a407c2f.png)\r\n\r\nNew\r\n![screenshot from 2016-02-16 23 27 32](https://cloud.githubusercontent.com/assets/6282045/13093364/26ede986-d505-11e5-977e-820a9ebb7212.png)\r\n\r\nNew with gradients off\r\n![screenshot from 2016-02-16 23 28 28](https://cloud.githubusercontent.com/assets/6282045/13093369/2aaec4c8-d505-11e5-8182-e18100162ed9.png)"},"comment":{"url":"https://api.github.com/repos/LMMS/lmms/issues/comments/190318003","html_url":"https://github.com/LMMS/lmms/pull/2574#issuecomment-190318003","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/2574","id":190318003,"user":{"login":"tresf","id":6345473,"avatar_url":"https://avatars.githubusercontent.com/u/6345473?v=3","gravatar_id":"","url":"https://api.github.com/users/tresf","html_url":"https://github.com/tresf","followers_url":"https://api.github.com/users/tresf/followers","following_url":"https://api.github.com/users/tresf/following{/other_user}","gists_url":"https://api.github.com/users/tresf/gists{/gist_id}","starred_url":"https://api.github.com/users/tresf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tresf/subscriptions","organizations_url":"https://api.github.com/users/tresf/orgs","repos_url":"https://api.github.com/users/tresf/repos","events_url":"https://api.github.com/users/tresf/events{/privacy}","received_events_url":"https://api.github.com/users/tresf/received_events","type":"User","site_admin":false},"created_at":"2016-02-29T18:18:17Z","updated_at":"2016-02-29T18:18:17Z","body":"@Umcaruje well I don't think it harms to have an external API to force the redraw and agreed, out of scope.\r\n\r\nI don't have a chance to compile and test this for a few days, so if someone else can give it the OK, that would be great."}}