{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/chris-smith/rosjs/pulls/4","id":87566242,"html_url":"https://github.com/chris-smith/rosjs/pull/4","diff_url":"https://github.com/chris-smith/rosjs/pull/4.diff","patch_url":"https://github.com/chris-smith/rosjs/pull/4.patch","issue_url":"https://api.github.com/repos/chris-smith/rosjs/issues/4","number":4,"state":"closed","locked":false,"title":"Shutdown","user":{"login":"chris-smith","id":5223570,"avatar_url":"https://avatars.githubusercontent.com/u/5223570?v=3","gravatar_id":"","url":"https://api.github.com/users/chris-smith","html_url":"https://github.com/chris-smith","followers_url":"https://api.github.com/users/chris-smith/followers","following_url":"https://api.github.com/users/chris-smith/following{/other_user}","gists_url":"https://api.github.com/users/chris-smith/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-smith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-smith/subscriptions","organizations_url":"https://api.github.com/users/chris-smith/orgs","repos_url":"https://api.github.com/users/chris-smith/repos","events_url":"https://api.github.com/users/chris-smith/events{/privacy}","received_events_url":"https://api.github.com/users/chris-smith/received_events","type":"User","site_admin":false},"body":"Shiwei found a bug where rosnodejs crashed in the Spinner because a client that had been shutdown tried to queue a message - this adds a number of checks to ensure this state doesn't happen. Also adds tests for specific instances of these bugs and a \"stress\" test that rapid-fire creates and destroys publishers/subscribers and services/clients.","created_at":"2016-09-30T21:05:20Z","updated_at":"2016-10-04T13:13:38Z","closed_at":"2016-10-04T13:13:38Z","merged_at":"2016-10-04T13:13:38Z","merge_commit_sha":"a5f34c30d72751fc0153887de1ce686da88d9718","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chris-smith/rosjs/pulls/4/commits","review_comments_url":"https://api.github.com/repos/chris-smith/rosjs/pulls/4/comments","review_comment_url":"https://api.github.com/repos/chris-smith/rosjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chris-smith/rosjs/issues/4/comments","statuses_url":"https://api.github.com/repos/chris-smith/rosjs/statuses/c8a4b0535c540113032afd3d9c0e15a3eae6269a","head":{"label":"chris-smith:shutdown","ref":"shutdown","sha":"c8a4b0535c540113032afd3d9c0e15a3eae6269a","user":{"login":"chris-smith","id":5223570,"avatar_url":"https://avatars.githubusercontent.com/u/5223570?v=3","gravatar_id":"","url":"https://api.github.com/users/chris-smith","html_url":"https://github.com/chris-smith","followers_url":"https://api.github.com/users/chris-smith/followers","following_url":"https://api.github.com/users/chris-smith/following{/other_user}","gists_url":"https://api.github.com/users/chris-smith/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-smith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-smith/subscriptions","organizations_url":"https://api.github.com/users/chris-smith/orgs","repos_url":"https://api.github.com/users/chris-smith/repos","events_url":"https://api.github.com/users/chris-smith/events{/privacy}","received_events_url":"https://api.github.com/users/chris-smith/received_events","type":"User","site_admin":false},"repo":{"id":55931274,"name":"rosjs","full_name":"chris-smith/rosjs","owner":{"login":"chris-smith","id":5223570,"avatar_url":"https://avatars.githubusercontent.com/u/5223570?v=3","gravatar_id":"","url":"https://api.github.com/users/chris-smith","html_url":"https://github.com/chris-smith","followers_url":"https://api.github.com/users/chris-smith/followers","following_url":"https://api.github.com/users/chris-smith/following{/other_user}","gists_url":"https://api.github.com/users/chris-smith/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-smith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-smith/subscriptions","organizations_url":"https://api.github.com/users/chris-smith/orgs","repos_url":"https://api.github.com/users/chris-smith/repos","events_url":"https://api.github.com/users/chris-smith/events{/privacy}","received_events_url":"https://api.github.com/users/chris-smith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chris-smith/rosjs","description":"Client library for writing ROS nodes in JavaScript","fork":true,"url":"https://api.github.com/repos/chris-smith/rosjs","forks_url":"https://api.github.com/repos/chris-smith/rosjs/forks","keys_url":"https://api.github.com/repos/chris-smith/rosjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chris-smith/rosjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chris-smith/rosjs/teams","hooks_url":"https://api.github.com/repos/chris-smith/rosjs/hooks","issue_events_url":"https://api.github.com/repos/chris-smith/rosjs/issues/events{/number}","events_url":"https://api.github.com/repos/chris-smith/rosjs/events","assignees_url":"https://api.github.com/repos/chris-smith/rosjs/assignees{/user}","branches_url":"https://api.github.com/repos/chris-smith/rosjs/branches{/branch}","tags_url":"https://api.github.com/repos/chris-smith/rosjs/tags","blobs_url":"https://api.github.com/repos/chris-smith/rosjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chris-smith/rosjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chris-smith/rosjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/chris-smith/rosjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chris-smith/rosjs/statuses/{sha}","languages_url":"https://api.github.com/repos/chris-smith/rosjs/languages","stargazers_url":"https://api.github.com/repos/chris-smith/rosjs/stargazers","contributors_url":"https://api.github.com/repos/chris-smith/rosjs/contributors","subscribers_url":"https://api.github.com/repos/chris-smith/rosjs/subscribers","subscription_url":"https://api.github.com/repos/chris-smith/rosjs/subscription","commits_url":"https://api.github.com/repos/chris-smith/rosjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/chris-smith/rosjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/chris-smith/rosjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/chris-smith/rosjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/chris-smith/rosjs/contents/{+path}","compare_url":"https://api.github.com/repos/chris-smith/rosjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chris-smith/rosjs/merges","archive_url":"https://api.github.com/repos/chris-smith/rosjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chris-smith/rosjs/downloads","issues_url":"https://api.github.com/repos/chris-smith/rosjs/issues{/number}","pulls_url":"https://api.github.com/repos/chris-smith/rosjs/pulls{/number}","milestones_url":"https://api.github.com/repos/chris-smith/rosjs/milestones{/number}","notifications_url":"https://api.github.com/repos/chris-smith/rosjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chris-smith/rosjs/labels{/name}","releases_url":"https://api.github.com/repos/chris-smith/rosjs/releases{/id}","deployments_url":"https://api.github.com/repos/chris-smith/rosjs/deployments","created_at":"2016-04-11T01:03:28Z","updated_at":"2016-04-11T01:03:30Z","pushed_at":"2016-10-04T13:13:39Z","git_url":"git://github.com/chris-smith/rosjs.git","ssh_url":"git@github.com:chris-smith/rosjs.git","clone_url":"https://github.com/chris-smith/rosjs.git","svn_url":"https://github.com/chris-smith/rosjs","homepage":"","size":973,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"kinetic-devel"}},"base":{"label":"chris-smith:indigo-devel","ref":"indigo-devel","sha":"11699423aae845e19140c6cae52a9cdb074a0b70","user":{"login":"chris-smith","id":5223570,"avatar_url":"https://avatars.githubusercontent.com/u/5223570?v=3","gravatar_id":"","url":"https://api.github.com/users/chris-smith","html_url":"https://github.com/chris-smith","followers_url":"https://api.github.com/users/chris-smith/followers","following_url":"https://api.github.com/users/chris-smith/following{/other_user}","gists_url":"https://api.github.com/users/chris-smith/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-smith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-smith/subscriptions","organizations_url":"https://api.github.com/users/chris-smith/orgs","repos_url":"https://api.github.com/users/chris-smith/repos","events_url":"https://api.github.com/users/chris-smith/events{/privacy}","received_events_url":"https://api.github.com/users/chris-smith/received_events","type":"User","site_admin":false},"repo":{"id":55931274,"name":"rosjs","full_name":"chris-smith/rosjs","owner":{"login":"chris-smith","id":5223570,"avatar_url":"https://avatars.githubusercontent.com/u/5223570?v=3","gravatar_id":"","url":"https://api.github.com/users/chris-smith","html_url":"https://github.com/chris-smith","followers_url":"https://api.github.com/users/chris-smith/followers","following_url":"https://api.github.com/users/chris-smith/following{/other_user}","gists_url":"https://api.github.com/users/chris-smith/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-smith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-smith/subscriptions","organizations_url":"https://api.github.com/users/chris-smith/orgs","repos_url":"https://api.github.com/users/chris-smith/repos","events_url":"https://api.github.com/users/chris-smith/events{/privacy}","received_events_url":"https://api.github.com/users/chris-smith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chris-smith/rosjs","description":"Client library for writing ROS nodes in JavaScript","fork":true,"url":"https://api.github.com/repos/chris-smith/rosjs","forks_url":"https://api.github.com/repos/chris-smith/rosjs/forks","keys_url":"https://api.github.com/repos/chris-smith/rosjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chris-smith/rosjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chris-smith/rosjs/teams","hooks_url":"https://api.github.com/repos/chris-smith/rosjs/hooks","issue_events_url":"https://api.github.com/repos/chris-smith/rosjs/issues/events{/number}","events_url":"https://api.github.com/repos/chris-smith/rosjs/events","assignees_url":"https://api.github.com/repos/chris-smith/rosjs/assignees{/user}","branches_url":"https://api.github.com/repos/chris-smith/rosjs/branches{/branch}","tags_url":"https://api.github.com/repos/chris-smith/rosjs/tags","blobs_url":"https://api.github.com/repos/chris-smith/rosjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chris-smith/rosjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chris-smith/rosjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/chris-smith/rosjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chris-smith/rosjs/statuses/{sha}","languages_url":"https://api.github.com/repos/chris-smith/rosjs/languages","stargazers_url":"https://api.github.com/repos/chris-smith/rosjs/stargazers","contributors_url":"https://api.github.com/repos/chris-smith/rosjs/contributors","subscribers_url":"https://api.github.com/repos/chris-smith/rosjs/subscribers","subscription_url":"https://api.github.com/repos/chris-smith/rosjs/subscription","commits_url":"https://api.github.com/repos/chris-smith/rosjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/chris-smith/rosjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/chris-smith/rosjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/chris-smith/rosjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/chris-smith/rosjs/contents/{+path}","compare_url":"https://api.github.com/repos/chris-smith/rosjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chris-smith/rosjs/merges","archive_url":"https://api.github.com/repos/chris-smith/rosjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chris-smith/rosjs/downloads","issues_url":"https://api.github.com/repos/chris-smith/rosjs/issues{/number}","pulls_url":"https://api.github.com/repos/chris-smith/rosjs/pulls{/number}","milestones_url":"https://api.github.com/repos/chris-smith/rosjs/milestones{/number}","notifications_url":"https://api.github.com/repos/chris-smith/rosjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chris-smith/rosjs/labels{/name}","releases_url":"https://api.github.com/repos/chris-smith/rosjs/releases{/id}","deployments_url":"https://api.github.com/repos/chris-smith/rosjs/deployments","created_at":"2016-04-11T01:03:28Z","updated_at":"2016-04-11T01:03:30Z","pushed_at":"2016-10-04T13:13:39Z","git_url":"git://github.com/chris-smith/rosjs.git","ssh_url":"git@github.com:chris-smith/rosjs.git","clone_url":"https://github.com/chris-smith/rosjs.git","svn_url":"https://github.com/chris-smith/rosjs","homepage":"","size":973,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"kinetic-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/chris-smith/rosjs/pulls/4"},"html":{"href":"https://github.com/chris-smith/rosjs/pull/4"},"issue":{"href":"https://api.github.com/repos/chris-smith/rosjs/issues/4"},"comments":{"href":"https://api.github.com/repos/chris-smith/rosjs/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/chris-smith/rosjs/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/chris-smith/rosjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chris-smith/rosjs/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/chris-smith/rosjs/statuses/c8a4b0535c540113032afd3d9c0e15a3eae6269a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"chris-smith","id":5223570,"avatar_url":"https://avatars.githubusercontent.com/u/5223570?v=3","gravatar_id":"","url":"https://api.github.com/users/chris-smith","html_url":"https://github.com/chris-smith","followers_url":"https://api.github.com/users/chris-smith/followers","following_url":"https://api.github.com/users/chris-smith/following{/other_user}","gists_url":"https://api.github.com/users/chris-smith/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-smith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-smith/subscriptions","organizations_url":"https://api.github.com/users/chris-smith/orgs","repos_url":"https://api.github.com/users/chris-smith/repos","events_url":"https://api.github.com/users/chris-smith/events{/privacy}","received_events_url":"https://api.github.com/users/chris-smith/received_events","type":"User","site_admin":false},"comments":2,"review_comments":1,"commits":2,"additions":848,"deletions":145,"changed_files":13}}
{"actor":{"display_login":"chris-smith"}}