{"action":"created","comment":{"url":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments/92107395","pull_request_review_id":12615767,"id":92107395,"diff_hunk":"@@ -38,7 +38,7 @@ module Crystal\n     def define_method_from_method_missing(method_missing, signature, original_call)\n       name_node = StringLiteral.new(signature.name)\n       args_nodes = [] of ASTNode\n-      named_args_nodes = nil\n+      named_args_nodes = [] of NamedArgument","path":"src/compiler/crystal/semantic/method_missing.cr","position":5,"original_position":5,"commit_id":"0e7f42dfedaf0e272edf35d39435f2557c8153bb","original_commit_id":"0e7f42dfedaf0e272edf35d39435f2557c8153bb","user":{"login":"splattael","id":28908,"avatar_url":"https://avatars.githubusercontent.com/u/28908?v=3","gravatar_id":"","url":"https://api.github.com/users/splattael","html_url":"https://github.com/splattael","followers_url":"https://api.github.com/users/splattael/followers","following_url":"https://api.github.com/users/splattael/following{/other_user}","gists_url":"https://api.github.com/users/splattael/gists{/gist_id}","starred_url":"https://api.github.com/users/splattael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splattael/subscriptions","organizations_url":"https://api.github.com/users/splattael/orgs","repos_url":"https://api.github.com/users/splattael/repos","events_url":"https://api.github.com/users/splattael/events{/privacy}","received_events_url":"https://api.github.com/users/splattael/received_events","type":"User","site_admin":false},"body":"@asterite Oh, that's true. I wanted to stay \"symmetrical\" with `args_nodes`.\r\nI wonder, is allocating an array a hotspot here?\r\n\r\nAnyway, I could revert the change for `named_args_nodes`. How about the other changes? Should I close this PR?","created_at":"2016-12-13T06:55:42Z","updated_at":"2016-12-13T06:55:43Z","html_url":"https://github.com/crystal-lang/crystal/pull/3660#discussion_r92107395","pull_request_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/3660","_links":{"self":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments/92107395"},"html":{"href":"https://github.com/crystal-lang/crystal/pull/3660#discussion_r92107395"},"pull_request":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/3660"}}},"pull_request":{"url":"https://api.github.com/repos/crystal-lang/crystal/pulls/3660","id":97297073,"html_url":"https://github.com/crystal-lang/crystal/pull/3660","diff_url":"https://github.com/crystal-lang/crystal/pull/3660.diff","patch_url":"https://github.com/crystal-lang/crystal/pull/3660.patch","issue_url":"https://api.github.com/repos/crystal-lang/crystal/issues/3660","number":3660,"state":"open","locked":false,"title":"Tiny refactor of method_missing definition","user":{"login":"splattael","id":28908,"avatar_url":"https://avatars.githubusercontent.com/u/28908?v=3","gravatar_id":"","url":"https://api.github.com/users/splattael","html_url":"https://github.com/splattael","followers_url":"https://api.github.com/users/splattael/followers","following_url":"https://api.github.com/users/splattael/following{/other_user}","gists_url":"https://api.github.com/users/splattael/gists{/gist_id}","starred_url":"https://api.github.com/users/splattael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splattael/subscriptions","organizations_url":"https://api.github.com/users/splattael/orgs","repos_url":"https://api.github.com/users/splattael/repos","events_url":"https://api.github.com/users/splattael/events{/privacy}","received_events_url":"https://api.github.com/users/splattael/received_events","type":"User","site_admin":false},"body":"* Removed unused var `args_node`\n* Handle `named_args_nodes` similar to `args_nodes`\n* Drop `try` for non-nil `named_args`","created_at":"2016-12-09T11:57:45Z","updated_at":"2016-12-13T06:55:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a7090a3a8919c4fd8f97b8d51ec4dc230064aaa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/3660/commits","review_comments_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/3660/comments","review_comment_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crystal-lang/crystal/issues/3660/comments","statuses_url":"https://api.github.com/repos/crystal-lang/crystal/statuses/0e7f42dfedaf0e272edf35d39435f2557c8153bb","head":{"label":"splattael:gh/refactor-mm","ref":"gh/refactor-mm","sha":"0e7f42dfedaf0e272edf35d39435f2557c8153bb","user":{"login":"splattael","id":28908,"avatar_url":"https://avatars.githubusercontent.com/u/28908?v=3","gravatar_id":"","url":"https://api.github.com/users/splattael","html_url":"https://github.com/splattael","followers_url":"https://api.github.com/users/splattael/followers","following_url":"https://api.github.com/users/splattael/following{/other_user}","gists_url":"https://api.github.com/users/splattael/gists{/gist_id}","starred_url":"https://api.github.com/users/splattael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splattael/subscriptions","organizations_url":"https://api.github.com/users/splattael/orgs","repos_url":"https://api.github.com/users/splattael/repos","events_url":"https://api.github.com/users/splattael/events{/privacy}","received_events_url":"https://api.github.com/users/splattael/received_events","type":"User","site_admin":false},"repo":{"id":37493580,"name":"crystal","full_name":"splattael/crystal","owner":{"login":"splattael","id":28908,"avatar_url":"https://avatars.githubusercontent.com/u/28908?v=3","gravatar_id":"","url":"https://api.github.com/users/splattael","html_url":"https://github.com/splattael","followers_url":"https://api.github.com/users/splattael/followers","following_url":"https://api.github.com/users/splattael/following{/other_user}","gists_url":"https://api.github.com/users/splattael/gists{/gist_id}","starred_url":"https://api.github.com/users/splattael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splattael/subscriptions","organizations_url":"https://api.github.com/users/splattael/orgs","repos_url":"https://api.github.com/users/splattael/repos","events_url":"https://api.github.com/users/splattael/events{/privacy}","received_events_url":"https://api.github.com/users/splattael/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/splattael/crystal","description":"The Crystal Programming Language","fork":true,"url":"https://api.github.com/repos/splattael/crystal","forks_url":"https://api.github.com/repos/splattael/crystal/forks","keys_url":"https://api.github.com/repos/splattael/crystal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/splattael/crystal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/splattael/crystal/teams","hooks_url":"https://api.github.com/repos/splattael/crystal/hooks","issue_events_url":"https://api.github.com/repos/splattael/crystal/issues/events{/number}","events_url":"https://api.github.com/repos/splattael/crystal/events","assignees_url":"https://api.github.com/repos/splattael/crystal/assignees{/user}","branches_url":"https://api.github.com/repos/splattael/crystal/branches{/branch}","tags_url":"https://api.github.com/repos/splattael/crystal/tags","blobs_url":"https://api.github.com/repos/splattael/crystal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/splattael/crystal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/splattael/crystal/git/refs{/sha}","trees_url":"https://api.github.com/repos/splattael/crystal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/splattael/crystal/statuses/{sha}","languages_url":"https://api.github.com/repos/splattael/crystal/languages","stargazers_url":"https://api.github.com/repos/splattael/crystal/stargazers","contributors_url":"https://api.github.com/repos/splattael/crystal/contributors","subscribers_url":"https://api.github.com/repos/splattael/crystal/subscribers","subscription_url":"https://api.github.com/repos/splattael/crystal/subscription","commits_url":"https://api.github.com/repos/splattael/crystal/commits{/sha}","git_commits_url":"https://api.github.com/repos/splattael/crystal/git/commits{/sha}","comments_url":"https://api.github.com/repos/splattael/crystal/comments{/number}","issue_comment_url":"https://api.github.com/repos/splattael/crystal/issues/comments{/number}","contents_url":"https://api.github.com/repos/splattael/crystal/contents/{+path}","compare_url":"https://api.github.com/repos/splattael/crystal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/splattael/crystal/merges","archive_url":"https://api.github.com/repos/splattael/crystal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/splattael/crystal/downloads","issues_url":"https://api.github.com/repos/splattael/crystal/issues{/number}","pulls_url":"https://api.github.com/repos/splattael/crystal/pulls{/number}","milestones_url":"https://api.github.com/repos/splattael/crystal/milestones{/number}","notifications_url":"https://api.github.com/repos/splattael/crystal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/splattael/crystal/labels{/name}","releases_url":"https://api.github.com/repos/splattael/crystal/releases{/id}","deployments_url":"https://api.github.com/repos/splattael/crystal/deployments","created_at":"2015-06-15T21:57:54Z","updated_at":"2016-02-24T16:09:42Z","pushed_at":"2016-12-09T11:57:34Z","git_url":"git://github.com/splattael/crystal.git","ssh_url":"git@github.com:splattael/crystal.git","clone_url":"https://github.com/splattael/crystal.git","svn_url":"https://github.com/splattael/crystal","homepage":"http://crystal-lang.org","size":39447,"stargazers_count":0,"watchers_count":0,"language":"Crystal","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crystal-lang:master","ref":"master","sha":"8295d8ccae7a393d0490e648fcbf964625aab93b","user":{"login":"crystal-lang","id":6539796,"avatar_url":"https://avatars.githubusercontent.com/u/6539796?v=3","gravatar_id":"","url":"https://api.github.com/users/crystal-lang","html_url":"https://github.com/crystal-lang","followers_url":"https://api.github.com/users/crystal-lang/followers","following_url":"https://api.github.com/users/crystal-lang/following{/other_user}","gists_url":"https://api.github.com/users/crystal-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/crystal-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crystal-lang/subscriptions","organizations_url":"https://api.github.com/users/crystal-lang/orgs","repos_url":"https://api.github.com/users/crystal-lang/repos","events_url":"https://api.github.com/users/crystal-lang/events{/privacy}","received_events_url":"https://api.github.com/users/crystal-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":6887813,"name":"crystal","full_name":"crystal-lang/crystal","owner":{"login":"crystal-lang","id":6539796,"avatar_url":"https://avatars.githubusercontent.com/u/6539796?v=3","gravatar_id":"","url":"https://api.github.com/users/crystal-lang","html_url":"https://github.com/crystal-lang","followers_url":"https://api.github.com/users/crystal-lang/followers","following_url":"https://api.github.com/users/crystal-lang/following{/other_user}","gists_url":"https://api.github.com/users/crystal-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/crystal-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crystal-lang/subscriptions","organizations_url":"https://api.github.com/users/crystal-lang/orgs","repos_url":"https://api.github.com/users/crystal-lang/repos","events_url":"https://api.github.com/users/crystal-lang/events{/privacy}","received_events_url":"https://api.github.com/users/crystal-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crystal-lang/crystal","description":"The Crystal Programming Language","fork":false,"url":"https://api.github.com/repos/crystal-lang/crystal","forks_url":"https://api.github.com/repos/crystal-lang/crystal/forks","keys_url":"https://api.github.com/repos/crystal-lang/crystal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crystal-lang/crystal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crystal-lang/crystal/teams","hooks_url":"https://api.github.com/repos/crystal-lang/crystal/hooks","issue_events_url":"https://api.github.com/repos/crystal-lang/crystal/issues/events{/number}","events_url":"https://api.github.com/repos/crystal-lang/crystal/events","assignees_url":"https://api.github.com/repos/crystal-lang/crystal/assignees{/user}","branches_url":"https://api.github.com/repos/crystal-lang/crystal/branches{/branch}","tags_url":"https://api.github.com/repos/crystal-lang/crystal/tags","blobs_url":"https://api.github.com/repos/crystal-lang/crystal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crystal-lang/crystal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crystal-lang/crystal/git/refs{/sha}","trees_url":"https://api.github.com/repos/crystal-lang/crystal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crystal-lang/crystal/statuses/{sha}","languages_url":"https://api.github.com/repos/crystal-lang/crystal/languages","stargazers_url":"https://api.github.com/repos/crystal-lang/crystal/stargazers","contributors_url":"https://api.github.com/repos/crystal-lang/crystal/contributors","subscribers_url":"https://api.github.com/repos/crystal-lang/crystal/subscribers","subscription_url":"https://api.github.com/repos/crystal-lang/crystal/subscription","commits_url":"https://api.github.com/repos/crystal-lang/crystal/commits{/sha}","git_commits_url":"https://api.github.com/repos/crystal-lang/crystal/git/commits{/sha}","comments_url":"https://api.github.com/repos/crystal-lang/crystal/comments{/number}","issue_comment_url":"https://api.github.com/repos/crystal-lang/crystal/issues/comments{/number}","contents_url":"https://api.github.com/repos/crystal-lang/crystal/contents/{+path}","compare_url":"https://api.github.com/repos/crystal-lang/crystal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crystal-lang/crystal/merges","archive_url":"https://api.github.com/repos/crystal-lang/crystal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crystal-lang/crystal/downloads","issues_url":"https://api.github.com/repos/crystal-lang/crystal/issues{/number}","pulls_url":"https://api.github.com/repos/crystal-lang/crystal/pulls{/number}","milestones_url":"https://api.github.com/repos/crystal-lang/crystal/milestones{/number}","notifications_url":"https://api.github.com/repos/crystal-lang/crystal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crystal-lang/crystal/labels{/name}","releases_url":"https://api.github.com/repos/crystal-lang/crystal/releases{/id}","deployments_url":"https://api.github.com/repos/crystal-lang/crystal/deployments","created_at":"2012-11-27T17:32:32Z","updated_at":"2016-12-13T05:03:33Z","pushed_at":"2016-12-13T05:08:13Z","git_url":"git://github.com/crystal-lang/crystal.git","ssh_url":"git@github.com:crystal-lang/crystal.git","clone_url":"https://github.com/crystal-lang/crystal.git","svn_url":"https://github.com/crystal-lang/crystal","homepage":"http://crystal-lang.org","size":69352,"stargazers_count":6685,"watchers_count":6685,"language":"Crystal","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":556,"mirror_url":null,"open_issues_count":378,"forks":556,"open_issues":378,"watchers":6685,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/3660"},"html":{"href":"https://github.com/crystal-lang/crystal/pull/3660"},"issue":{"href":"https://api.github.com/repos/crystal-lang/crystal/issues/3660"},"comments":{"href":"https://api.github.com/repos/crystal-lang/crystal/issues/3660/comments"},"review_comments":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/3660/comments"},"review_comment":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/3660/commits"},"statuses":{"href":"https://api.github.com/repos/crystal-lang/crystal/statuses/0e7f42dfedaf0e272edf35d39435f2557c8153bb"}}}}
{"actor":{"display_login":"splattael"}}