{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/79693717","id":79693717,"diff_hunk":"@@ -403,15 +436,16 @@ static void __GetGlyphRunDetails(_CTTypesetter* ts, CFRange range, CGRect frameS\n \n             // TODO::\n             // This is a temp workaround until we can have actual glyph origins\n-            run->_glyphOrigins.emplace_back(CGPoint{ xPos, yPos });\n-            for (int index = 0; index < glyphRunDetails._dwriteGlyphRun[i].glyphCount - 1; index++) {\n-                run->_glyphOrigins.emplace_back(CGPoint{ xPos + glyphRunDetails._dwriteGlyphRun[i].glyphAdvances[index], yPos });\n+            for (int index = 0; index < glyphRunDetails._dwriteGlyphRun[i].glyphCount; index++) {\n+                run->_glyphOrigins.emplace_back(CGPoint{ xPos, yPos });\n+                run->_glyphAdvances.emplace_back(CGSize{ glyphRunDetails._dwriteGlyphRun[i].glyphAdvances[index], 0.0f });","path":"Frameworks/CoreText/DWriteWrapper.mm","position":118,"original_position":110,"commit_id":"e6622579827672542b8089e44b58cb1dd2dd80bd","original_commit_id":"8c414467615be15f6033f0d28e81ac563d40ec1d","user":{"login":"aballway","id":7557395,"avatar_url":"https://avatars.githubusercontent.com/u/7557395?v=3","gravatar_id":"","url":"https://api.github.com/users/aballway","html_url":"https://github.com/aballway","followers_url":"https://api.github.com/users/aballway/followers","following_url":"https://api.github.com/users/aballway/following{/other_user}","gists_url":"https://api.github.com/users/aballway/gists{/gist_id}","starred_url":"https://api.github.com/users/aballway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aballway/subscriptions","organizations_url":"https://api.github.com/users/aballway/orgs","repos_url":"https://api.github.com/users/aballway/repos","events_url":"https://api.github.com/users/aballway/events{/privacy}","received_events_url":"https://api.github.com/users/aballway/received_events","type":"User","site_admin":false},"body":"The offset is always 0.0, but so is the yPos, despite it very much not always being 0...\r\n\r\n---\r\nIn reply to: [79692524](https://github.com/Microsoft/WinObjC/pull/989#discussion_r79692524) [](ancestors = 79692524)","created_at":"2016-09-20T19:34:36Z","updated_at":"2016-09-20T19:34:36Z","html_url":"https://github.com/Microsoft/WinObjC/pull/989#discussion_r79693717","pull_request_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/989","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/79693717"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/989#discussion_r79693717"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/989"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/989","id":84680129,"html_url":"https://github.com/Microsoft/WinObjC/pull/989","diff_url":"https://github.com/Microsoft/WinObjC/pull/989.diff","patch_url":"https://github.com/Microsoft/WinObjC/pull/989.patch","issue_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/989","number":989,"state":"open","locked":false,"title":"Implement CTLineCreateWithAttributedString, CTRunGetGlyphs, CTRun Get…","user":{"login":"aballway","id":7557395,"avatar_url":"https://avatars.githubusercontent.com/u/7557395?v=3","gravatar_id":"","url":"https://api.github.com/users/aballway","html_url":"https://github.com/aballway","followers_url":"https://api.github.com/users/aballway/followers","following_url":"https://api.github.com/users/aballway/following{/other_user}","gists_url":"https://api.github.com/users/aballway/gists{/gist_id}","starred_url":"https://api.github.com/users/aballway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aballway/subscriptions","organizations_url":"https://api.github.com/users/aballway/orgs","repos_url":"https://api.github.com/users/aballway/repos","events_url":"https://api.github.com/users/aballway/events{/privacy}","received_events_url":"https://api.github.com/users/aballway/received_events","type":"User","site_admin":false},"body":"…Ptr functions, and add CTLine tests\r\n\r\nHas some temporary workarounds until we get CTFont and glyphOrigins working properly, and some code will have to change when we change the structures we use.","created_at":"2016-09-09T16:31:06Z","updated_at":"2016-09-20T19:34:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9d0a733ddd50cdbc6643abe4544ccc8ae88ba09","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/989/commits","review_comments_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/989/comments","review_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/989/comments","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/e6622579827672542b8089e44b58cb1dd2dd80bd","head":{"label":"aballway:coretext","ref":"coretext","sha":"e6622579827672542b8089e44b58cb1dd2dd80bd","user":{"login":"aballway","id":7557395,"avatar_url":"https://avatars.githubusercontent.com/u/7557395?v=3","gravatar_id":"","url":"https://api.github.com/users/aballway","html_url":"https://github.com/aballway","followers_url":"https://api.github.com/users/aballway/followers","following_url":"https://api.github.com/users/aballway/following{/other_user}","gists_url":"https://api.github.com/users/aballway/gists{/gist_id}","starred_url":"https://api.github.com/users/aballway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aballway/subscriptions","organizations_url":"https://api.github.com/users/aballway/orgs","repos_url":"https://api.github.com/users/aballway/repos","events_url":"https://api.github.com/users/aballway/events{/privacy}","received_events_url":"https://api.github.com/users/aballway/received_events","type":"User","site_admin":false},"repo":{"id":62087158,"name":"WinObjC","full_name":"aballway/WinObjC","owner":{"login":"aballway","id":7557395,"avatar_url":"https://avatars.githubusercontent.com/u/7557395?v=3","gravatar_id":"","url":"https://api.github.com/users/aballway","html_url":"https://github.com/aballway","followers_url":"https://api.github.com/users/aballway/followers","following_url":"https://api.github.com/users/aballway/following{/other_user}","gists_url":"https://api.github.com/users/aballway/gists{/gist_id}","starred_url":"https://api.github.com/users/aballway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aballway/subscriptions","organizations_url":"https://api.github.com/users/aballway/orgs","repos_url":"https://api.github.com/users/aballway/repos","events_url":"https://api.github.com/users/aballway/events{/privacy}","received_events_url":"https://api.github.com/users/aballway/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aballway/WinObjC","description":"Objective-C for Windows","fork":true,"url":"https://api.github.com/repos/aballway/WinObjC","forks_url":"https://api.github.com/repos/aballway/WinObjC/forks","keys_url":"https://api.github.com/repos/aballway/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aballway/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aballway/WinObjC/teams","hooks_url":"https://api.github.com/repos/aballway/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/aballway/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/aballway/WinObjC/events","assignees_url":"https://api.github.com/repos/aballway/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/aballway/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/aballway/WinObjC/tags","blobs_url":"https://api.github.com/repos/aballway/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aballway/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aballway/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/aballway/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aballway/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/aballway/WinObjC/languages","stargazers_url":"https://api.github.com/repos/aballway/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/aballway/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/aballway/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/aballway/WinObjC/subscription","commits_url":"https://api.github.com/repos/aballway/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/aballway/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/aballway/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/aballway/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/aballway/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/aballway/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aballway/WinObjC/merges","archive_url":"https://api.github.com/repos/aballway/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aballway/WinObjC/downloads","issues_url":"https://api.github.com/repos/aballway/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/aballway/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/aballway/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/aballway/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aballway/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/aballway/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/aballway/WinObjC/deployments","created_at":"2016-06-27T20:48:04Z","updated_at":"2016-06-28T17:00:56Z","pushed_at":"2016-09-20T18:24:00Z","git_url":"git://github.com/aballway/WinObjC.git","ssh_url":"git@github.com:aballway/WinObjC.git","clone_url":"https://github.com/aballway/WinObjC.git","svn_url":"https://github.com/aballway/WinObjC","homepage":"","size":333092,"stargazers_count":0,"watchers_count":0,"language":"Objective-C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:CT-DW","ref":"CT-DW","sha":"9409ea730e1c8725f0f9fa1a6dceed5b11313fe6","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":37950166,"name":"WinObjC","full_name":"Microsoft/WinObjC","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/WinObjC","description":"Objective-C for Windows","fork":false,"url":"https://api.github.com/repos/Microsoft/WinObjC","forks_url":"https://api.github.com/repos/Microsoft/WinObjC/forks","keys_url":"https://api.github.com/repos/Microsoft/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/WinObjC/teams","hooks_url":"https://api.github.com/repos/Microsoft/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/WinObjC/events","assignees_url":"https://api.github.com/repos/Microsoft/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/WinObjC/tags","blobs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/WinObjC/languages","stargazers_url":"https://api.github.com/repos/Microsoft/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/WinObjC/subscription","commits_url":"https://api.github.com/repos/Microsoft/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/WinObjC/merges","archive_url":"https://api.github.com/repos/Microsoft/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/WinObjC/downloads","issues_url":"https://api.github.com/repos/Microsoft/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/WinObjC/deployments","created_at":"2015-06-23T23:14:58Z","updated_at":"2016-09-20T11:49:42Z","pushed_at":"2016-09-20T18:41:47Z","git_url":"git://github.com/Microsoft/WinObjC.git","ssh_url":"git@github.com:Microsoft/WinObjC.git","clone_url":"https://github.com/Microsoft/WinObjC.git","svn_url":"https://github.com/Microsoft/WinObjC","homepage":"","size":336283,"stargazers_count":5449,"watchers_count":5449,"language":"Objective-C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":697,"mirror_url":null,"open_issues_count":232,"forks":697,"open_issues":232,"watchers":5449,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/989"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/989"},"issue":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/989"},"comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/989/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/989/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/989/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/WinObjC/statuses/e6622579827672542b8089e44b58cb1dd2dd80bd"}}}}
{"actor":{"display_login":"aballway"}}