{"push_id":1304728710,"size":128,"distinct_size":21,"ref":"refs/heads/master","head":"717795e52fea0492638c1076ab7664ea0e019734","before":"3b3881d8326f7c7c8dc81f2da7434428b8c6c5da","commits":[{"sha":"068d563582c7edf8943a730ea312787b7fb5953f","author":{"name":"Philip Tricca","email":"fa6bb6553939a5e6b97832794c956c35da7d12d5@intel.com"},"message":"tcti_device: Replace global function pointer to debug print function.\n\nWe replace this global function pointer with a user supplied, per-TCTI\ncallback function and data in the opaque portion of the TCTI structure.\nThis allows any consumer of the TCTI to provide a function for handling\nlogging / debug messages. The consumer can also supply data (via a void\npointer) that the callback will pass to the callback as the first parameter\nwhen invoked. This is a very common pattern and quite flexible. It's a\nuseful mechanism when trying to keep from having global data in an\napplication.\n\nUsing this mechanism we're able to provide a replacement implementation\nof the old global function pointer. We simply supply a pointer to the\ndebug print function and the user data (in this case a NULL pointer)\nto achieve the same functionality as before. Backward compatibility with\nthe old DebugPrintf is maintained for now to accomodate the socket TCTI.\nThis will go away as soon as the socket TCTI is ported over.\n\nThe signature for the callback will be common to our TCTIs and so we\nlocate it with the TCTI magic stuff renaming magic.h -> common.h in the\ntcti directory. We also provide a convenience function for use within\nthe TCTI for invoking the callback.\n\nSigned-off-by: Philip Tricca <philip.b.tricca@intel.com>","distinct":false,"url":"https://api.github.com/repos/flihp/TPM2.0-TSS/commits/068d563582c7edf8943a730ea312787b7fb5953f"},{"sha":"09a5bcdd4e3b98cc4a8b4d237b5c296d07d1c390","author":{"name":"Philip Tricca","email":"fa6bb6553939a5e6b97832794c956c35da7d12d5@intel.com"},"message":"test: Add test cases to test TCTI logging mechanism in device TCTI.\n\nI had to break my own goal of keeping the cmocka specific code in the\ntest driver and out of the test functions. Their assert_* functions are\nsuper useful through and much better than a pile of if / else tests on\nreturn values.\nI'm also not 100% convinced I like this structure for the test case\nlayout but it's not too late to change this up if we can come up with a\nbetter approach.\n\nSigned-off-by: Philip Tricca <philip.b.tricca@intel.com>","distinct":false,"url":"https://api.github.com/repos/flihp/TPM2.0-TSS/commits/09a5bcdd4e3b98cc4a8b4d237b5c296d07d1c390"},{"sha":"0d292d1f7947d6c96a19147b55869596f0155593","author":{"name":"wcarthur","email":"c5589e5599cda3e6be2d78273f7231027e50c550@intel.com"},"message":"Fixed bugs in AddSession and DeleteSession (these never worked right to\nbegin with).\n\nBecause AddSession never worked right (the list always had only the latest\ncreated session), fixing these bugs cause a failure in the simple HMAC session\ntest (HMAC computed incorrectly because GetSessionStruct found the wrong\nsession (multiple entries with same session handle).  This required fixes\nin CmdRspAuthsTests to delete previously created sessions.","distinct":false,"url":"https://api.github.com/repos/flihp/TPM2.0-TSS/commits/0d292d1f7947d6c96a19147b55869596f0155593"},{"sha":"a870758a476f72c401a8213be07dcd2dbada1295","author":{"name":"wcarthur","email":"c5589e5599cda3e6be2d78273f7231027e50c550@intel.com"},"message":"Fixed bad comment.","distinct":false,"url":"https://api.github.com/repos/flihp/TPM2.0-TSS/commits/a870758a476f72c401a8213be07dcd2dbada1295"},{"sha":"25c513ebe381a397416719eb690264fb1718a6ae","author":{"name":"wcarthur1","email":"c5589e5599cda3e6be2d78273f7231027e50c550@intel.com"},"message":"Merge pull request #151 from flihp/tcti_device_printf\n\nTcti device printf","distinct":false,"url":"https://api.github.com/repos/flihp/TPM2.0-TSS/commits/25c513ebe381a397416719eb690264fb1718a6ae"},{"sha":"748405322fc5b43d3123266f7f4a5a7a0ba5f30e","author":{"name":"Philip Tricca","email":"fa6bb6553939a5e6b97832794c956c35da7d12d5@intel.com"},"message":"tcti: Remove magic & version parameters from the Init functions.\n\nAllowing users to pass these values causes a situation where an unusable\nTCTI context is created. There's no real reason to expose this data to\nconsumers of this library. This internal data has also been moved from the\ninstalled common include file to the private sysapi/include/tcti_util.h.\n\nSigned-off-by: Philip Tricca <philip.b.tricca@intel.com>","distinct":false,"url":"https://api.github.com/repos/flihp/TPM2.0-TSS/commits/748405322fc5b43d3123266f7f4a5a7a0ba5f30e"},{"sha":"64da97c52440e099df6802ef1269622eb53b55f7","author":{"name":"wcarthur","email":"c5589e5599cda3e6be2d78273f7231027e50c550@intel.com"},"message":"Bug fix:  not checking connection ID for some commands (Load,\nContextSave, FlushContext).\n\nAlso had to move location of GetConnectionID call.","distinct":false,"url":"https://api.github.com/repos/flihp/TPM2.0-TSS/commits/64da97c52440e099df6802ef1269622eb53b55f7"},{"sha":"ee69aba3a30da9c0b5f3e1631d919629d539fe4d","author":{"name":"wcarthur","email":"c5589e5599cda3e6be2d78273f7231027e50c550@intel.com"},"message":"Fixed bug in TestRM (uninitialized sizes for TPM2B's passed to CreatePrimaryComplete).\nFailures noticed when running under Linux.","distinct":false,"url":"https://api.github.com/repos/flihp/TPM2.0-TSS/commits/ee69aba3a30da9c0b5f3e1631d919629d539fe4d"},{"sha":"abb4b095775e39c7b62bf6fadc56d7d0edcc441e","author":{"name":"wcarthur","email":"c5589e5599cda3e6be2d78273f7231027e50c550@intel.com"},"message":"Fixed StartAuthSessionWithParams:  when StartAuthSession fails,\nstructures were left on the sessions list.  Needed to delete these.\nThey didn't really cause any problems, but did represent a memory\nleak.  And they complicated debug.","distinct":false,"url":"https://api.github.com/repos/flihp/TPM2.0-TSS/commits/abb4b095775e39c7b62bf6fadc56d7d0edcc441e"},{"sha":"3aa33ac4d83612f72e7f336e63a5e56f22e784ce","author":{"name":"wcarthur","email":"c5589e5599cda3e6be2d78273f7231027e50c550@intel.com"},"message":"Enable  connection specific creation and shutdown of sessions (this is\npreparation for getcap tests).","distinct":false,"url":"https://api.github.com/repos/flihp/TPM2.0-TSS/commits/3aa33ac4d83612f72e7f336e63a5e56f22e784ce"},{"sha":"6b104cd185adf8f5e8c10bd75b8d3284012fd326","author":{"name":"wcarthur1","email":"c5589e5599cda3e6be2d78273f7231027e50c550@intel.com"},"message":"Merge pull request #164 from flihp/remove_magic_version\n\ntcti: Remove magic & version parameters from the Init functions.","distinct":false,"url":"https://api.github.com/repos/flihp/TPM2.0-TSS/commits/6b104cd185adf8f5e8c10bd75b8d3284012fd326"},{"sha":"39d58fabfc5cee3d6470057f11e4967c95a50737","author":{"name":"Philip Tricca","email":"fa6bb6553939a5e6b97832794c956c35da7d12d5@intel.com"},"message":"Revert \"Enable  connection specific creation and shutdown of sessions (this is\"\n\nThis breaks the tpmtest code. Reverting it till the tpmtest code is\nupdate.\n\nThis reverts commit 3aa33ac4d83612f72e7f336e63a5e56f22e784ce.","distinct":false,"url":"https://api.github.com/repos/flihp/TPM2.0-TSS/commits/39d58fabfc5cee3d6470057f11e4967c95a50737"},{"sha":"7ddc98efd7bd8dfb27539a3e6942e98800380a5d","author":{"name":"wcarthur","email":"c5589e5599cda3e6be2d78273f7231027e50c550@intel.com"},"message":"Enable connection specific creation and shutdown of sessions (this is preparation for getcap tests).\n\nThis has a positive side effect of removing global data from the\nStartAuthSession function thus breaking the coupling between it and the\nresourcemgr implementation.\n\nSigned-off-by: Philip Tricca <philip.b.tricca@intel.com>","distinct":false,"url":"https://api.github.com/repos/flihp/TPM2.0-TSS/commits/7ddc98efd7bd8dfb27539a3e6942e98800380a5d"},{"sha":"08ad9452a66a4fa397bdd3de275425548f5570e5","author":{"name":"wcarthur1","email":"c5589e5599cda3e6be2d78273f7231027e50c550@intel.com"},"message":"Fixed instances of 0x80006 errors (insufficient buffer) when running\non Linux caused by uninitialized size for simple TPM2B structures.","distinct":false,"url":"https://api.github.com/repos/flihp/TPM2.0-TSS/commits/08ad9452a66a4fa397bdd3de275425548f5570e5"},{"sha":"e2761a423b42d38722e052a174e34c97873487e3","author":{"name":"wcarthur1","email":"c5589e5599cda3e6be2d78273f7231027e50c550@intel.com"},"message":"Fixed bug when running against IBM simulator.  Need to check for\nIBM manufacturer ID.","distinct":false,"url":"https://api.github.com/repos/flihp/TPM2.0-TSS/commits/e2761a423b42d38722e052a174e34c97873487e3"},{"sha":"faac11ff4873b629848c20057529e4f6f252ced6","author":{"name":"Philip Tricca","email":"fa6bb6553939a5e6b97832794c956c35da7d12d5@intel.com"},"message":"tcti_device_test: Remove MAGIC and VERSION from Init call.\n\nThis accounts for an API change from\n748405322fc5b43d3123266f7f4a5a7a0ba5f30e\n\nSigned-off-by: Philip Tricca <philip.b.tricca@intel.com>","distinct":false,"url":"https://api.github.com/repos/flihp/TPM2.0-TSS/commits/faac11ff4873b629848c20057529e4f6f252ced6"},{"sha":"0c37a4aa889e3a8263fdda6493258ce2f16d359a","author":{"name":"wcarthur1","email":"c5589e5599cda3e6be2d78273f7231027e50c550@intel.com"},"message":"Merge pull request #170 from flihp/unit_magic\n\ntcti_device_test: Remove MAGIC and VERSION from Init call.","distinct":false,"url":"https://api.github.com/repos/flihp/TPM2.0-TSS/commits/0c37a4aa889e3a8263fdda6493258ce2f16d359a"},{"sha":"decc21c958b94d23f2a1af802986ec3711abd9b9","author":{"name":"Philip Tricca","email":"fa6bb6553939a5e6b97832794c956c35da7d12d5@intel.com"},"message":"Remove debug data from TCTI function signature.\n\nBoth the device and socket TCTI init functions take as a final parameter\na string. AFAIK these strings are only used in a debug print function as\na way to track which TCTI is being initialized and when. This is useful\nto client code but not something that should be reflected in the API\nthat we expose.\n\nThis patch removes this parameter and the corresponding debug printf\ncall from both TCTI init functions. An identical debug printf is added\nto each client (resourcemgr, tpmclient, tpmtest) to keep the output\nconsistent. Unit tests are updated as well.\n\nSigned-off-by: Philip Tricca <philip.b.tricca@intel.com>","distinct":false,"url":"https://api.github.com/repos/flihp/TPM2.0-TSS/commits/decc21c958b94d23f2a1af802986ec3711abd9b9"},{"sha":"34b014743810dc41be994af2f8a4c6e9e5a76a8d","author":{"name":"wcarthur1","email":"c5589e5599cda3e6be2d78273f7231027e50c550@intel.com"},"message":"Merge pull request #171 from flihp/tcti_init_string\n\nRemove debug data from TCTI function signature.","distinct":false,"url":"https://api.github.com/repos/flihp/TPM2.0-TSS/commits/34b014743810dc41be994af2f8a4c6e9e5a76a8d"},{"sha":"3f00a33da5f0f8dcc19d8eb86355d77483a49962","author":{"name":"wcarthur","email":"c5589e5599cda3e6be2d78273f7231027e50c550@intel.com"},"message":"Debugability enhancements to RESOURCE_MANAGER_ENTRY structure\nto make looking at the list's entries easier.","distinct":false,"url":"https://api.github.com/repos/flihp/TPM2.0-TSS/commits/3f00a33da5f0f8dcc19d8eb86355d77483a49962"}]}
{"actor":{"display_login":"flihp"}}