{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/52335468","id":52335468,"diff_hunk":"@@ -751,10 +750,17 @@ void AudioMixer::broadcastMixes() {\n             ++framesSinceCutoffEvent;\n         }\n \n-        quint64 now = usecTimestampNow();\n-        if (now - _lastPerSecondCallbackTime > USECS_PER_SECOND) {\n+        using namespace std::chrono;\n+        static const seconds ONE_SECOND { 1 };\n+\n+        auto now = Clock::now();","path":"assignment-client/src/audio/AudioMixer.cpp","position":17,"original_position":17,"commit_id":"ccadb5483a4fe84d4f06a680c45842728d3fb3d2","original_commit_id":"ccadb5483a4fe84d4f06a680c45842728d3fb3d2","user":{"login":"ZappoMan","id":2093195,"avatar_url":"https://avatars.githubusercontent.com/u/2093195?v=3","gravatar_id":"","url":"https://api.github.com/users/ZappoMan","html_url":"https://github.com/ZappoMan","followers_url":"https://api.github.com/users/ZappoMan/followers","following_url":"https://api.github.com/users/ZappoMan/following{/other_user}","gists_url":"https://api.github.com/users/ZappoMan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZappoMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZappoMan/subscriptions","organizations_url":"https://api.github.com/users/ZappoMan/orgs","repos_url":"https://api.github.com/users/ZappoMan/repos","events_url":"https://api.github.com/users/ZappoMan/events{/privacy}","received_events_url":"https://api.github.com/users/ZappoMan/received_events","type":"User","site_admin":false},"body":"you should keep using `usecTimestampNow()` there's no benefit from mixing the timing paradigms, it will only introduce confusion later down the road.","created_at":"2016-02-09T16:45:00Z","updated_at":"2016-02-09T16:45:00Z","html_url":"https://github.com/highfidelity/hifi/pull/7050#discussion_r52335468","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/7050","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/52335468"},"html":{"href":"https://github.com/highfidelity/hifi/pull/7050#discussion_r52335468"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/7050"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/7050","id":58748785,"html_url":"https://github.com/highfidelity/hifi/pull/7050","diff_url":"https://github.com/highfidelity/hifi/pull/7050.diff","patch_url":"https://github.com/highfidelity/hifi/pull/7050.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/7050","number":7050,"state":"open","locked":false,"title":"Fix audio stats","user":{"login":"Atlante45","id":4036492,"avatar_url":"https://avatars.githubusercontent.com/u/4036492?v=3","gravatar_id":"","url":"https://api.github.com/users/Atlante45","html_url":"https://github.com/Atlante45","followers_url":"https://api.github.com/users/Atlante45/followers","following_url":"https://api.github.com/users/Atlante45/following{/other_user}","gists_url":"https://api.github.com/users/Atlante45/gists{/gist_id}","starred_url":"https://api.github.com/users/Atlante45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Atlante45/subscriptions","organizations_url":"https://api.github.com/users/Atlante45/orgs","repos_url":"https://api.github.com/users/Atlante45/repos","events_url":"https://api.github.com/users/Atlante45/events{/privacy}","received_events_url":"https://api.github.com/users/Atlante45/received_events","type":"User","site_admin":false},"body":"Fixes upstream audio stats not always being reported by the mixer.","created_at":"2016-02-09T13:46:01Z","updated_at":"2016-02-09T16:45:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d0429cb009e13d8b000a08e42ee7869bf98cf94","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/7050/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/7050/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/7050/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/ccadb5483a4fe84d4f06a680c45842728d3fb3d2","head":{"label":"Atlante45:fix/audio-stats","ref":"fix/audio-stats","sha":"ccadb5483a4fe84d4f06a680c45842728d3fb3d2","user":{"login":"Atlante45","id":4036492,"avatar_url":"https://avatars.githubusercontent.com/u/4036492?v=3","gravatar_id":"","url":"https://api.github.com/users/Atlante45","html_url":"https://github.com/Atlante45","followers_url":"https://api.github.com/users/Atlante45/followers","following_url":"https://api.github.com/users/Atlante45/following{/other_user}","gists_url":"https://api.github.com/users/Atlante45/gists{/gist_id}","starred_url":"https://api.github.com/users/Atlante45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Atlante45/subscriptions","organizations_url":"https://api.github.com/users/Atlante45/orgs","repos_url":"https://api.github.com/users/Atlante45/repos","events_url":"https://api.github.com/users/Atlante45/events{/privacy}","received_events_url":"https://api.github.com/users/Atlante45/received_events","type":"User","site_admin":false},"repo":{"id":11436474,"name":"hifi","full_name":"Atlante45/hifi","owner":{"login":"Atlante45","id":4036492,"avatar_url":"https://avatars.githubusercontent.com/u/4036492?v=3","gravatar_id":"","url":"https://api.github.com/users/Atlante45","html_url":"https://github.com/Atlante45","followers_url":"https://api.github.com/users/Atlante45/followers","following_url":"https://api.github.com/users/Atlante45/following{/other_user}","gists_url":"https://api.github.com/users/Atlante45/gists{/gist_id}","starred_url":"https://api.github.com/users/Atlante45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Atlante45/subscriptions","organizations_url":"https://api.github.com/users/Atlante45/orgs","repos_url":"https://api.github.com/users/Atlante45/repos","events_url":"https://api.github.com/users/Atlante45/events{/privacy}","received_events_url":"https://api.github.com/users/Atlante45/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Atlante45/hifi","description":"Test platform for various render and interface tests for next-gen VR system","fork":true,"url":"https://api.github.com/repos/Atlante45/hifi","forks_url":"https://api.github.com/repos/Atlante45/hifi/forks","keys_url":"https://api.github.com/repos/Atlante45/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Atlante45/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Atlante45/hifi/teams","hooks_url":"https://api.github.com/repos/Atlante45/hifi/hooks","issue_events_url":"https://api.github.com/repos/Atlante45/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/Atlante45/hifi/events","assignees_url":"https://api.github.com/repos/Atlante45/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/Atlante45/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/Atlante45/hifi/tags","blobs_url":"https://api.github.com/repos/Atlante45/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Atlante45/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Atlante45/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/Atlante45/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Atlante45/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/Atlante45/hifi/languages","stargazers_url":"https://api.github.com/repos/Atlante45/hifi/stargazers","contributors_url":"https://api.github.com/repos/Atlante45/hifi/contributors","subscribers_url":"https://api.github.com/repos/Atlante45/hifi/subscribers","subscription_url":"https://api.github.com/repos/Atlante45/hifi/subscription","commits_url":"https://api.github.com/repos/Atlante45/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/Atlante45/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/Atlante45/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/Atlante45/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/Atlante45/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/Atlante45/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Atlante45/hifi/merges","archive_url":"https://api.github.com/repos/Atlante45/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Atlante45/hifi/downloads","issues_url":"https://api.github.com/repos/Atlante45/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/Atlante45/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/Atlante45/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/Atlante45/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Atlante45/hifi/labels{/name}","releases_url":"https://api.github.com/repos/Atlante45/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/Atlante45/hifi/deployments","created_at":"2013-07-15T23:52:30Z","updated_at":"2015-05-08T13:17:34Z","pushed_at":"2016-02-09T13:43:10Z","git_url":"git://github.com/Atlante45/hifi.git","ssh_url":"git@github.com:Atlante45/hifi.git","clone_url":"https://github.com/Atlante45/hifi.git","svn_url":"https://github.com/Atlante45/hifi","homepage":null,"size":190897,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"07759bb5db20fef38c780ebf36688dcd3d2b8730","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2016-02-07T18:48:54Z","pushed_at":"2016-02-09T13:46:02Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":228757,"stargazers_count":354,"watchers_count":354,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":206,"mirror_url":null,"open_issues_count":58,"forks":206,"open_issues":58,"watchers":354,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/7050"},"html":{"href":"https://github.com/highfidelity/hifi/pull/7050"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/7050"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/7050/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/7050/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/7050/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/ccadb5483a4fe84d4f06a680c45842728d3fb3d2"}}}}