{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/77767792","id":77767792,"diff_hunk":"@@ -343,6 +343,11 @@ func (psc *PetSetController) syncPetSet(ps *apps.PetSet, pets []*api.Pod) (int,\n \t\t\tif err == nil {\n \t\t\t\tnumPets++\n \t\t\t}\n+\t\t\tswitch err.(type) {\n+\t\t\tcase *unhealthyPetBlock:\n+\t\t\t\t//We are not passing this error up, but we don't increment numPets if we encounter it","path":"pkg/controller/petset/pet_set.go","position":6,"original_position":6,"commit_id":"8678d752a0d5a8eeda38f196d4e8414e76ced992","original_commit_id":"8678d752a0d5a8eeda38f196d4e8414e76ced992","user":{"login":"nebril","id":1417888,"avatar_url":"https://avatars.githubusercontent.com/u/1417888?v=3","gravatar_id":"","url":"https://api.github.com/users/nebril","html_url":"https://github.com/nebril","followers_url":"https://api.github.com/users/nebril/followers","following_url":"https://api.github.com/users/nebril/following{/other_user}","gists_url":"https://api.github.com/users/nebril/gists{/gist_id}","starred_url":"https://api.github.com/users/nebril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nebril/subscriptions","organizations_url":"https://api.github.com/users/nebril/orgs","repos_url":"https://api.github.com/users/nebril/repos","events_url":"https://api.github.com/users/nebril/events{/privacy}","received_events_url":"https://api.github.com/users/nebril/received_events","type":"User","site_admin":false},"body":"Will do.","created_at":"2016-09-07T06:49:26Z","updated_at":"2016-09-07T06:49:26Z","html_url":"https://github.com/kubernetes/kubernetes/pull/32117#discussion_r77767792","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32117","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/77767792"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/32117#discussion_r77767792"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32117"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32117","id":84101139,"html_url":"https://github.com/kubernetes/kubernetes/pull/32117","diff_url":"https://github.com/kubernetes/kubernetes/pull/32117.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/32117.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/32117","number":32117,"state":"open","locked":false,"title":"PetSet returns valid replica count in status","user":{"login":"nebril","id":1417888,"avatar_url":"https://avatars.githubusercontent.com/u/1417888?v=3","gravatar_id":"","url":"https://api.github.com/users/nebril","html_url":"https://github.com/nebril","followers_url":"https://api.github.com/users/nebril/followers","following_url":"https://api.github.com/users/nebril/following{/other_user}","gists_url":"https://api.github.com/users/nebril/gists{/gist_id}","starred_url":"https://api.github.com/users/nebril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nebril/subscriptions","organizations_url":"https://api.github.com/users/nebril/orgs","repos_url":"https://api.github.com/users/nebril/repos","events_url":"https://api.github.com/users/nebril/events{/privacy}","received_events_url":"https://api.github.com/users/nebril/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**: It prevents the PetSet replica count to be invalid regardless of pods not being created due to \r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #31965\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n```release-note\r\n```\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/32117)\n<!-- Reviewable:end -->\n","created_at":"2016-09-06T10:56:11Z","updated_at":"2016-09-07T06:49:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bc5992240b1a881c6271c1b9a0c7319a8e02917","assignee":{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false},"assignees":[{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32117/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32117/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/32117/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/8678d752a0d5a8eeda38f196d4e8414e76ced992","head":{"label":"nebril:petset-count","ref":"petset-count","sha":"8678d752a0d5a8eeda38f196d4e8414e76ced992","user":{"login":"nebril","id":1417888,"avatar_url":"https://avatars.githubusercontent.com/u/1417888?v=3","gravatar_id":"","url":"https://api.github.com/users/nebril","html_url":"https://github.com/nebril","followers_url":"https://api.github.com/users/nebril/followers","following_url":"https://api.github.com/users/nebril/following{/other_user}","gists_url":"https://api.github.com/users/nebril/gists{/gist_id}","starred_url":"https://api.github.com/users/nebril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nebril/subscriptions","organizations_url":"https://api.github.com/users/nebril/orgs","repos_url":"https://api.github.com/users/nebril/repos","events_url":"https://api.github.com/users/nebril/events{/privacy}","received_events_url":"https://api.github.com/users/nebril/received_events","type":"User","site_admin":false},"repo":{"id":59016977,"name":"kubernetes","full_name":"nebril/kubernetes","owner":{"login":"nebril","id":1417888,"avatar_url":"https://avatars.githubusercontent.com/u/1417888?v=3","gravatar_id":"","url":"https://api.github.com/users/nebril","html_url":"https://github.com/nebril","followers_url":"https://api.github.com/users/nebril/followers","following_url":"https://api.github.com/users/nebril/following{/other_user}","gists_url":"https://api.github.com/users/nebril/gists{/gist_id}","starred_url":"https://api.github.com/users/nebril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nebril/subscriptions","organizations_url":"https://api.github.com/users/nebril/orgs","repos_url":"https://api.github.com/users/nebril/repos","events_url":"https://api.github.com/users/nebril/events{/privacy}","received_events_url":"https://api.github.com/users/nebril/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nebril/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/nebril/kubernetes","forks_url":"https://api.github.com/repos/nebril/kubernetes/forks","keys_url":"https://api.github.com/repos/nebril/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nebril/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nebril/kubernetes/teams","hooks_url":"https://api.github.com/repos/nebril/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/nebril/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/nebril/kubernetes/events","assignees_url":"https://api.github.com/repos/nebril/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/nebril/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/nebril/kubernetes/tags","blobs_url":"https://api.github.com/repos/nebril/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nebril/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nebril/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/nebril/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nebril/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/nebril/kubernetes/languages","stargazers_url":"https://api.github.com/repos/nebril/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/nebril/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/nebril/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/nebril/kubernetes/subscription","commits_url":"https://api.github.com/repos/nebril/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/nebril/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/nebril/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/nebril/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/nebril/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/nebril/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nebril/kubernetes/merges","archive_url":"https://api.github.com/repos/nebril/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nebril/kubernetes/downloads","issues_url":"https://api.github.com/repos/nebril/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/nebril/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/nebril/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/nebril/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nebril/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/nebril/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/nebril/kubernetes/deployments","created_at":"2016-05-17T11:37:02Z","updated_at":"2016-05-17T11:37:17Z","pushed_at":"2016-09-06T10:52:25Z","git_url":"git://github.com/nebril/kubernetes.git","ssh_url":"git@github.com:nebril/kubernetes.git","clone_url":"https://github.com/nebril/kubernetes.git","svn_url":"https://github.com/nebril/kubernetes","homepage":"http://kubernetes.io","size":318962,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"08f49bff7642760158ba08712b3f6ac125d00ede","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-09-07T06:49:22Z","pushed_at":"2016-09-07T06:22:03Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":557229,"stargazers_count":16568,"watchers_count":16568,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5345,"mirror_url":null,"open_issues_count":4407,"forks":5345,"open_issues":4407,"watchers":16568,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32117"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/32117"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/32117"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/32117/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32117/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32117/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/8678d752a0d5a8eeda38f196d4e8414e76ced992"}}}}
{"actor":{"display_login":"nebril"}}