{"action":"created","issue":{"url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2289","repository_url":"https://api.github.com/repos/openmicroscopy/bioformats","labels_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2289/labels{/name}","comments_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2289/comments","events_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2289/events","html_url":"https://github.com/openmicroscopy/bioformats/pull/2289","id":141648511,"number":2289,"title":"Remove non-OME DLLs from the repository","user":{"login":"joshmoore","id":88113,"avatar_url":"https://avatars.githubusercontent.com/u/88113?v=3","gravatar_id":"","url":"https://api.github.com/users/joshmoore","html_url":"https://github.com/joshmoore","followers_url":"https://api.github.com/users/joshmoore/followers","following_url":"https://api.github.com/users/joshmoore/following{/other_user}","gists_url":"https://api.github.com/users/joshmoore/gists{/gist_id}","starred_url":"https://api.github.com/users/joshmoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshmoore/subscriptions","organizations_url":"https://api.github.com/users/joshmoore/orgs","repos_url":"https://api.github.com/users/joshmoore/repos","events_url":"https://api.github.com/users/joshmoore/events{/privacy}","received_events_url":"https://api.github.com/users/joshmoore/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openmicroscopy/bioformats/labels/develop","name":"develop","color":"02e10c"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2016-03-17T17:18:08Z","updated_at":"2016-04-14T21:37:43Z","closed_at":"2016-04-08T14:01:26Z","pull_request":{"url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/2289","html_url":"https://github.com/openmicroscopy/bioformats/pull/2289","diff_url":"https://github.com/openmicroscopy/bioformats/pull/2289.diff","patch_url":"https://github.com/openmicroscopy/bioformats/pull/2289.patch"},"body":"As discussed with @RichardMyers et al., having these opaque\r\nbinaries in a GPL'd codebase puts the OME Team in a precarious\r\nposition. It was decided to leave the status quo for 5.1.8\r\nbut to remove them early enough so that alternative delivery\r\nmethods could be found for the SlideBook6Reader users.\r\n\r\nSee:\r\n\r\n - https://github.com/openmicroscopy/bioformats/pull/1993\r\n - https://github.com/openmicroscopy/bioformats/pull/2217"},"comment":{"url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/comments/210159847","html_url":"https://github.com/openmicroscopy/bioformats/pull/2289#issuecomment-210159847","issue_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2289","id":210159847,"user":{"login":"RichardMyers","id":4415803,"avatar_url":"https://avatars.githubusercontent.com/u/4415803?v=3","gravatar_id":"","url":"https://api.github.com/users/RichardMyers","html_url":"https://github.com/RichardMyers","followers_url":"https://api.github.com/users/RichardMyers/followers","following_url":"https://api.github.com/users/RichardMyers/following{/other_user}","gists_url":"https://api.github.com/users/RichardMyers/gists{/gist_id}","starred_url":"https://api.github.com/users/RichardMyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichardMyers/subscriptions","organizations_url":"https://api.github.com/users/RichardMyers/orgs","repos_url":"https://api.github.com/users/RichardMyers/repos","events_url":"https://api.github.com/users/RichardMyers/events{/privacy}","received_events_url":"https://api.github.com/users/RichardMyers/received_events","type":"User","site_admin":false},"created_at":"2016-04-14T21:37:43Z","updated_at":"2016-04-14T21:37:43Z","body":"After 5.1.9 we need to host SlideBook6Reader.java from our update site to enable the missing .dll warning dialog on startup, the question is how do we remove it from the openmicroscopy/bioformats repo in a safe manner.\r\n\r\nAfter 5.1.9 I can put in a pull request to delete SlideBook6Readers.java;  I assume readers.txt stays the same.  Are there other changes I should make?\r\n\r\nI assume this will break test scripts.  Should I remove dependencies on SlideBook6Reader.java that might occur in other parts of the codebase?  I'm afraid I'm not really qualified to make those changes.\r\n\r\nIf your test scripts can be modified to first update SlideBook6Reader.jar from the new SlideBook update site, then maybe that is the only change that needs to be made for the test scripts.\r\n\r\nFrom 5.1.9 user must enable the SlideBook update site, but on non-Windows systems it will silently fail (only a message to the debug log).\r\n\r\nFrom version d.e.f we can expect that the new warning dialog will appear at startup for any users running on systems I haven't added dlls for.  Hopefully we'll have some non-Windows dlls available by then too.\r\n\r\n"}}