{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/smart-answers/pulls/comments/59168022","id":59168022,"diff_hunk":"@@ -4,8 +4,8 @@ module SmartAnswer::Calculators\n   class BenefitCapCalculatorDataQueryTest < ActiveSupport::TestCase\n     context BenefitCapCalculatorDataQuery do\n       setup do\n-        query = BenefitCapCalculatorDataQuery.new\n-        @rates = query.data.fetch(\"rates\")\n+        @query = BenefitCapCalculatorDataQuery.new\n+        @rates = @query.data.fetch(\"rates\")","path":"test/unit/calculators/benefit_cap_calculator_data_query_test.rb","position":null,"original_position":7,"commit_id":"a91ae4d1bf02b139b291d1ea4d84e0ac65260350","original_commit_id":"7c655ce8a86c7d6b99a1ff4cf9e1079fe7bad577","user":{"login":"chrisroos","id":6556,"avatar_url":"https://avatars.githubusercontent.com/u/6556?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisroos","html_url":"https://github.com/chrisroos","followers_url":"https://api.github.com/users/chrisroos/followers","following_url":"https://api.github.com/users/chrisroos/following{/other_user}","gists_url":"https://api.github.com/users/chrisroos/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisroos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisroos/subscriptions","organizations_url":"https://api.github.com/users/chrisroos/orgs","repos_url":"https://api.github.com/users/chrisroos/repos","events_url":"https://api.github.com/users/chrisroos/events{/privacy}","received_events_url":"https://api.github.com/users/chrisroos/received_events","type":"User","site_admin":false},"body":"This commit is essentially empty. Are there other changes that should be included?","created_at":"2016-04-11T08:16:26Z","updated_at":"2016-04-11T08:16:26Z","html_url":"https://github.com/alphagov/smart-answers/pull/2452#discussion_r59168022","pull_request_url":"https://api.github.com/repos/alphagov/smart-answers/pulls/2452","_links":{"self":{"href":"https://api.github.com/repos/alphagov/smart-answers/pulls/comments/59168022"},"html":{"href":"https://github.com/alphagov/smart-answers/pull/2452#discussion_r59168022"},"pull_request":{"href":"https://api.github.com/repos/alphagov/smart-answers/pulls/2452"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/smart-answers/pulls/2452","id":65805211,"html_url":"https://github.com/alphagov/smart-answers/pull/2452","diff_url":"https://github.com/alphagov/smart-answers/pull/2452.diff","patch_url":"https://github.com/alphagov/smart-answers/pull/2452.patch","issue_url":"https://api.github.com/repos/alphagov/smart-answers/issues/2452","number":2452,"state":"open","locked":false,"title":"Refactor Benefit cap calculator (Making benefit rates and type configurable)","user":{"login":"ikennaokpala","id":84896,"avatar_url":"https://avatars.githubusercontent.com/u/84896?v=3","gravatar_id":"","url":"https://api.github.com/users/ikennaokpala","html_url":"https://github.com/ikennaokpala","followers_url":"https://api.github.com/users/ikennaokpala/followers","following_url":"https://api.github.com/users/ikennaokpala/following{/other_user}","gists_url":"https://api.github.com/users/ikennaokpala/gists{/gist_id}","starred_url":"https://api.github.com/users/ikennaokpala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikennaokpala/subscriptions","organizations_url":"https://api.github.com/users/ikennaokpala/orgs","repos_url":"https://api.github.com/users/ikennaokpala/repos","events_url":"https://api.github.com/users/ikennaokpala/events{/privacy}","received_events_url":"https://api.github.com/users/ikennaokpala/received_events","type":"User","site_admin":false},"body":"Trello Story: https://trello.com/c/LvffB57l/100-refactor-benefit-cap-calculator\r\n\r\n## Motivation \r\n\r\nThe motivation behind this refactoring, is that in story [34](Trello Story: https://trello.com/c/LvffB57l/100-refactor-benefit-cap-calculator) a second flow to display future benefit caps will be added. This second flow will have a slightly lists for benefits affected by the cap and exempt for the cap.\r\n\r\n## Changes\r\n\r\n* Introduced YAML to hold benefit cap data:\r\n   * Rates (For different family types)\r\n   * Exempt Benefits\r\n   *  Benefits that are affected by the cap\r\n\r\n*  Update benefit cap calculator flow to read data from YAML for benefit cap calculator.\r\n\r\n*  Refactored Question 5 a to o \r\n     * Replace hard coded case/switch with dynamic loop driven by data from the YAML.\r\n \r\n* Updated all affected tests.\r\n\r\n## Factcheck \r\n\r\n Link: https://smart-answers-pr-2452.herokuapp.com/benefit-cap-calculator/\r\n Link on GOV.UK: https://gov.uk/benefit-cap-calculator/\r\n\r\nThe [factcheck](https://smart-answers-pr-2452.herokuapp.com/benefit-cap-calculator/) should work exactly the same as [GOV.UK](https://gov.uk/benefit-cap-calculator)\r\n","created_at":"2016-04-08T15:38:39Z","updated_at":"2016-04-11T08:16:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a43e59f97f48b4b86362601f2bee2b9b8c354d4","assignee":{"login":"chrisroos","id":6556,"avatar_url":"https://avatars.githubusercontent.com/u/6556?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisroos","html_url":"https://github.com/chrisroos","followers_url":"https://api.github.com/users/chrisroos/followers","following_url":"https://api.github.com/users/chrisroos/following{/other_user}","gists_url":"https://api.github.com/users/chrisroos/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisroos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisroos/subscriptions","organizations_url":"https://api.github.com/users/chrisroos/orgs","repos_url":"https://api.github.com/users/chrisroos/repos","events_url":"https://api.github.com/users/chrisroos/events{/privacy}","received_events_url":"https://api.github.com/users/chrisroos/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/smart-answers/pulls/2452/commits","review_comments_url":"https://api.github.com/repos/alphagov/smart-answers/pulls/2452/comments","review_comment_url":"https://api.github.com/repos/alphagov/smart-answers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/smart-answers/issues/2452/comments","statuses_url":"https://api.github.com/repos/alphagov/smart-answers/statuses/a91ae4d1bf02b139b291d1ea4d84e0ac65260350","head":{"label":"alphagov:benefit-cap-calculator-refactoring","ref":"benefit-cap-calculator-refactoring","sha":"a91ae4d1bf02b139b291d1ea4d84e0ac65260350","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":2651887,"name":"smart-answers","full_name":"alphagov/smart-answers","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/smart-answers","description":"smart-answers","fork":false,"url":"https://api.github.com/repos/alphagov/smart-answers","forks_url":"https://api.github.com/repos/alphagov/smart-answers/forks","keys_url":"https://api.github.com/repos/alphagov/smart-answers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/smart-answers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/smart-answers/teams","hooks_url":"https://api.github.com/repos/alphagov/smart-answers/hooks","issue_events_url":"https://api.github.com/repos/alphagov/smart-answers/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/smart-answers/events","assignees_url":"https://api.github.com/repos/alphagov/smart-answers/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/smart-answers/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/smart-answers/tags","blobs_url":"https://api.github.com/repos/alphagov/smart-answers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/smart-answers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/smart-answers/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/smart-answers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/smart-answers/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/smart-answers/languages","stargazers_url":"https://api.github.com/repos/alphagov/smart-answers/stargazers","contributors_url":"https://api.github.com/repos/alphagov/smart-answers/contributors","subscribers_url":"https://api.github.com/repos/alphagov/smart-answers/subscribers","subscription_url":"https://api.github.com/repos/alphagov/smart-answers/subscription","commits_url":"https://api.github.com/repos/alphagov/smart-answers/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/smart-answers/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/smart-answers/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/smart-answers/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/smart-answers/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/smart-answers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/smart-answers/merges","archive_url":"https://api.github.com/repos/alphagov/smart-answers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/smart-answers/downloads","issues_url":"https://api.github.com/repos/alphagov/smart-answers/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/smart-answers/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/smart-answers/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/smart-answers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/smart-answers/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/smart-answers/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/smart-answers/deployments","created_at":"2011-10-26T15:39:01Z","updated_at":"2016-04-03T23:35:55Z","pushed_at":"2016-04-08T15:38:40Z","git_url":"git://github.com/alphagov/smart-answers.git","ssh_url":"git@github.com:alphagov/smart-answers.git","clone_url":"https://github.com/alphagov/smart-answers.git","svn_url":"https://github.com/alphagov/smart-answers","homepage":"","size":47088,"stargazers_count":77,"watchers_count":77,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":12,"forks":43,"open_issues":12,"watchers":77,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"a806305a5e96751e9965c7e0595c3763c721fbad","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":2651887,"name":"smart-answers","full_name":"alphagov/smart-answers","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/smart-answers","description":"smart-answers","fork":false,"url":"https://api.github.com/repos/alphagov/smart-answers","forks_url":"https://api.github.com/repos/alphagov/smart-answers/forks","keys_url":"https://api.github.com/repos/alphagov/smart-answers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/smart-answers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/smart-answers/teams","hooks_url":"https://api.github.com/repos/alphagov/smart-answers/hooks","issue_events_url":"https://api.github.com/repos/alphagov/smart-answers/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/smart-answers/events","assignees_url":"https://api.github.com/repos/alphagov/smart-answers/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/smart-answers/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/smart-answers/tags","blobs_url":"https://api.github.com/repos/alphagov/smart-answers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/smart-answers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/smart-answers/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/smart-answers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/smart-answers/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/smart-answers/languages","stargazers_url":"https://api.github.com/repos/alphagov/smart-answers/stargazers","contributors_url":"https://api.github.com/repos/alphagov/smart-answers/contributors","subscribers_url":"https://api.github.com/repos/alphagov/smart-answers/subscribers","subscription_url":"https://api.github.com/repos/alphagov/smart-answers/subscription","commits_url":"https://api.github.com/repos/alphagov/smart-answers/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/smart-answers/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/smart-answers/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/smart-answers/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/smart-answers/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/smart-answers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/smart-answers/merges","archive_url":"https://api.github.com/repos/alphagov/smart-answers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/smart-answers/downloads","issues_url":"https://api.github.com/repos/alphagov/smart-answers/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/smart-answers/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/smart-answers/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/smart-answers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/smart-answers/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/smart-answers/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/smart-answers/deployments","created_at":"2011-10-26T15:39:01Z","updated_at":"2016-04-03T23:35:55Z","pushed_at":"2016-04-08T15:38:40Z","git_url":"git://github.com/alphagov/smart-answers.git","ssh_url":"git@github.com:alphagov/smart-answers.git","clone_url":"https://github.com/alphagov/smart-answers.git","svn_url":"https://github.com/alphagov/smart-answers","homepage":"","size":47088,"stargazers_count":77,"watchers_count":77,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":12,"forks":43,"open_issues":12,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/smart-answers/pulls/2452"},"html":{"href":"https://github.com/alphagov/smart-answers/pull/2452"},"issue":{"href":"https://api.github.com/repos/alphagov/smart-answers/issues/2452"},"comments":{"href":"https://api.github.com/repos/alphagov/smart-answers/issues/2452/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/smart-answers/pulls/2452/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/smart-answers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/smart-answers/pulls/2452/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/smart-answers/statuses/a91ae4d1bf02b139b291d1ea4d84e0ac65260350"}}}}