{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/91455454","pull_request_review_id":11963285,"id":91455454,"diff_hunk":"@@ -7125,9 +7125,15 @@ body.site.fluid {\n }\n .site-title {\n \tfont-size: 40px;\n+\tfont-size: calc(16px + 2.16vw);","path":"templates/protostar/css/template.css","position":4,"original_position":4,"commit_id":"774094dad2dc8b9df36e363011e0cb10619a1439","original_commit_id":"774094dad2dc8b9df36e363011e0cb10619a1439","user":{"login":"ggppdk","id":5092940,"avatar_url":"https://avatars.githubusercontent.com/u/5092940?v=3","gravatar_id":"","url":"https://api.github.com/users/ggppdk","html_url":"https://github.com/ggppdk","followers_url":"https://api.github.com/users/ggppdk/followers","following_url":"https://api.github.com/users/ggppdk/following{/other_user}","gists_url":"https://api.github.com/users/ggppdk/gists{/gist_id}","starred_url":"https://api.github.com/users/ggppdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggppdk/subscriptions","organizations_url":"https://api.github.com/users/ggppdk/orgs","repos_url":"https://api.github.com/users/ggppdk/repos","events_url":"https://api.github.com/users/ggppdk/events{/privacy}","received_events_url":"https://api.github.com/users/ggppdk/received_events","type":"User","site_admin":false},"body":"it does not work in all browsers, only need is to fallback to existing values (this happens in IE8)","created_at":"2016-12-08T07:01:38Z","updated_at":"2016-12-08T07:01:38Z","html_url":"https://github.com/joomla/joomla-cms/pull/13064#discussion_r91455454","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13064","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/91455454"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/13064#discussion_r91455454"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13064"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13064","id":96346685,"html_url":"https://github.com/joomla/joomla-cms/pull/13064","diff_url":"https://github.com/joomla/joomla-cms/pull/13064.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/13064.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13064","number":13064,"state":"open","locked":false,"title":"Responsive site title for protostar","user":{"login":"ggppdk","id":5092940,"avatar_url":"https://avatars.githubusercontent.com/u/5092940?v=3","gravatar_id":"","url":"https://api.github.com/users/ggppdk","html_url":"https://github.com/ggppdk","followers_url":"https://api.github.com/users/ggppdk/followers","following_url":"https://api.github.com/users/ggppdk/following{/other_user}","gists_url":"https://api.github.com/users/ggppdk/gists{/gist_id}","starred_url":"https://api.github.com/users/ggppdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggppdk/subscriptions","organizations_url":"https://api.github.com/users/ggppdk/orgs","repos_url":"https://api.github.com/users/ggppdk/repos","events_url":"https://api.github.com/users/ggppdk/events{/privacy}","received_events_url":"https://api.github.com/users/ggppdk/received_events","type":"User","site_admin":false},"body":"Pull Request for Issues #13056 , #11053\r\n\r\n### Summary of Changes\r\nMake the site title 's **font-size**,\r\nresponsive to the viewport while maintaining \r\n-- a minimum of 22px+ and a maximum of 40px\r\n-- lowest: 22px, at 480px: 26px, at 800px: 33px, at 1024px: 40px\r\n\r\nBrowsers supported: all browsers and IE9+ \r\nNOTE: for non-supporting browsers (e.g. IE8) the old CSS values will be used as fallback\r\n(that is why you have font-size defined twice)\r\n\r\nAlso the LESS compiling works, (reported below as broken, i fixed it)\r\n\r\n### Testing Instructions\r\nApply patch and visit the site frontend,\r\n-- then resize your browser window to see that site title scale up / down, but also notice that it maintains a minimum of 22px and a maximum of 40px\r\n\r\nA note: i think, it will be good to start making use of calc() in more places\r\n(while of course using a fallback for non-supporting browsers)\r\n\r\n### Documentation Changes Required\r\nnone","created_at":"2016-12-02T20:23:41Z","updated_at":"2016-12-08T07:01:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fe209438c2acad98ccb00d7c02e8180a0a36841","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13064/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13064/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13064/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/774094dad2dc8b9df36e363011e0cb10619a1439","head":{"label":"ggppdk:protostar_site_title_responsive","ref":"protostar_site_title_responsive","sha":"774094dad2dc8b9df36e363011e0cb10619a1439","user":{"login":"ggppdk","id":5092940,"avatar_url":"https://avatars.githubusercontent.com/u/5092940?v=3","gravatar_id":"","url":"https://api.github.com/users/ggppdk","html_url":"https://github.com/ggppdk","followers_url":"https://api.github.com/users/ggppdk/followers","following_url":"https://api.github.com/users/ggppdk/following{/other_user}","gists_url":"https://api.github.com/users/ggppdk/gists{/gist_id}","starred_url":"https://api.github.com/users/ggppdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggppdk/subscriptions","organizations_url":"https://api.github.com/users/ggppdk/orgs","repos_url":"https://api.github.com/users/ggppdk/repos","events_url":"https://api.github.com/users/ggppdk/events{/privacy}","received_events_url":"https://api.github.com/users/ggppdk/received_events","type":"User","site_admin":false},"repo":{"id":57083813,"name":"joomla-cms","full_name":"ggppdk/joomla-cms","owner":{"login":"ggppdk","id":5092940,"avatar_url":"https://avatars.githubusercontent.com/u/5092940?v=3","gravatar_id":"","url":"https://api.github.com/users/ggppdk","html_url":"https://github.com/ggppdk","followers_url":"https://api.github.com/users/ggppdk/followers","following_url":"https://api.github.com/users/ggppdk/following{/other_user}","gists_url":"https://api.github.com/users/ggppdk/gists{/gist_id}","starred_url":"https://api.github.com/users/ggppdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggppdk/subscriptions","organizations_url":"https://api.github.com/users/ggppdk/orgs","repos_url":"https://api.github.com/users/ggppdk/repos","events_url":"https://api.github.com/users/ggppdk/events{/privacy}","received_events_url":"https://api.github.com/users/ggppdk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ggppdk/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/ggppdk/joomla-cms","forks_url":"https://api.github.com/repos/ggppdk/joomla-cms/forks","keys_url":"https://api.github.com/repos/ggppdk/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ggppdk/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ggppdk/joomla-cms/teams","hooks_url":"https://api.github.com/repos/ggppdk/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/ggppdk/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/ggppdk/joomla-cms/events","assignees_url":"https://api.github.com/repos/ggppdk/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/ggppdk/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/ggppdk/joomla-cms/tags","blobs_url":"https://api.github.com/repos/ggppdk/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ggppdk/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ggppdk/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/ggppdk/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ggppdk/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/ggppdk/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/ggppdk/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/ggppdk/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/ggppdk/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/ggppdk/joomla-cms/subscription","commits_url":"https://api.github.com/repos/ggppdk/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/ggppdk/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/ggppdk/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/ggppdk/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/ggppdk/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/ggppdk/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ggppdk/joomla-cms/merges","archive_url":"https://api.github.com/repos/ggppdk/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ggppdk/joomla-cms/downloads","issues_url":"https://api.github.com/repos/ggppdk/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/ggppdk/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/ggppdk/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/ggppdk/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ggppdk/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/ggppdk/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/ggppdk/joomla-cms/deployments","created_at":"2016-04-25T23:51:51Z","updated_at":"2016-11-03T19:19:23Z","pushed_at":"2016-12-04T15:06:02Z","git_url":"git://github.com/ggppdk/joomla-cms.git","ssh_url":"git@github.com:ggppdk/joomla-cms.git","clone_url":"https://github.com/ggppdk/joomla-cms.git","svn_url":"https://github.com/ggppdk/joomla-cms","homepage":"https://www.joomla.org","size":165141,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"b23fadb23c94706c6a1b0ec536809f0643ab42cb","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-12-07T20:37:53Z","pushed_at":"2016-12-07T23:46:01Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":313294,"stargazers_count":2206,"watchers_count":2206,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2350,"mirror_url":null,"open_issues_count":590,"forks":2350,"open_issues":590,"watchers":2206,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13064"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/13064"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/13064"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/13064/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13064/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13064/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/774094dad2dc8b9df36e363011e0cb10619a1439"}}}}
{"actor":{"display_login":"ggppdk"}}