{"action":"created","issue":{"url":"https://api.github.com/repos/python-diamond/Diamond/issues/521","repository_url":"https://api.github.com/repos/python-diamond/Diamond","labels_url":"https://api.github.com/repos/python-diamond/Diamond/issues/521/labels{/name}","comments_url":"https://api.github.com/repos/python-diamond/Diamond/issues/521/comments","events_url":"https://api.github.com/repos/python-diamond/Diamond/issues/521/events","html_url":"https://github.com/python-diamond/Diamond/pull/521","id":171160115,"number":521,"title":"Feature/tsdb tag handling","user":{"login":"kullervo16","id":9899429,"avatar_url":"https://avatars.githubusercontent.com/u/9899429?v=3","gravatar_id":"","url":"https://api.github.com/users/kullervo16","html_url":"https://github.com/kullervo16","followers_url":"https://api.github.com/users/kullervo16/followers","following_url":"https://api.github.com/users/kullervo16/following{/other_user}","gists_url":"https://api.github.com/users/kullervo16/gists{/gist_id}","starred_url":"https://api.github.com/users/kullervo16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kullervo16/subscriptions","organizations_url":"https://api.github.com/users/kullervo16/orgs","repos_url":"https://api.github.com/users/kullervo16/repos","events_url":"https://api.github.com/users/kullervo16/events{/privacy}","received_events_url":"https://api.github.com/users/kullervo16/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-08-15T12:24:29Z","updated_at":"2016-08-28T08:30:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/python-diamond/Diamond/pulls/521","html_url":"https://github.com/python-diamond/Diamond/pull/521","diff_url":"https://github.com/python-diamond/Diamond/pull/521.diff","patch_url":"https://github.com/python-diamond/Diamond/pull/521.patch"},"body":"I had some issues using the tags clause of the tsdbhandler.. if you do not know the format in which to specify the tags, the handler will simply not send any data (and not log any error either).... so you had to look into the OpenTSDB documentation to find out that tags are key value pairs, separated by spaces... and since the tags are appended to the default tag, it should start with a space...\r\n\r\nChanged this to:\r\n* overcome the missing space \r\n* allow both comma separated and space separated tags\r\n* documented the format, the default tag, added an example and a link to the proper openTSDB page.\r\n\r\nI also added some tests to test this behaviour (and hence also the basic tsdb collector behaviour)"},"comment":{"url":"https://api.github.com/repos/python-diamond/Diamond/issues/comments/242963036","html_url":"https://github.com/python-diamond/Diamond/pull/521#issuecomment-242963036","issue_url":"https://api.github.com/repos/python-diamond/Diamond/issues/521","id":242963036,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-08-28T08:30:40Z","updated_at":"2016-08-28T08:30:40Z","body":"\n[![Coverage Status](https://coveralls.io/builds/7640732/badge)](https://coveralls.io/builds/7640732)\n\nCoverage increased (+0.3%) to 59.662% when pulling **4df1d694105d1097dbafa8121ff1ac821ae1ca0f on kullervo16:feature/tsdb_tag_handling** into **fa8da843e06910d82cdd35f1cf1013b359bcb4e5 on python-diamond:master**.\n"}}
{"actor":{"display_login":"coveralls"}}