{"action":"created","issue":{"url":"https://api.github.com/repos/Windows-XAML/Template10/issues/781","repository_url":"https://api.github.com/repos/Windows-XAML/Template10","labels_url":"https://api.github.com/repos/Windows-XAML/Template10/issues/781/labels{/name}","comments_url":"https://api.github.com/repos/Windows-XAML/Template10/issues/781/comments","events_url":"https://api.github.com/repos/Windows-XAML/Template10/issues/781/events","html_url":"https://github.com/Windows-XAML/Template10/pull/781","id":142890209,"number":781,"title":"Minimal example of tooltips on Hamburger Menu Items, only when the ha…","user":{"login":"o0rebelious0o","id":2041260,"avatar_url":"https://avatars.githubusercontent.com/u/2041260?v=3","gravatar_id":"","url":"https://api.github.com/users/o0rebelious0o","html_url":"https://github.com/o0rebelious0o","followers_url":"https://api.github.com/users/o0rebelious0o/followers","following_url":"https://api.github.com/users/o0rebelious0o/following{/other_user}","gists_url":"https://api.github.com/users/o0rebelious0o/gists{/gist_id}","starred_url":"https://api.github.com/users/o0rebelious0o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/o0rebelious0o/subscriptions","organizations_url":"https://api.github.com/users/o0rebelious0o/orgs","repos_url":"https://api.github.com/users/o0rebelious0o/repos","events_url":"https://api.github.com/users/o0rebelious0o/events{/privacy}","received_events_url":"https://api.github.com/users/o0rebelious0o/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-03-23T07:57:21Z","updated_at":"2016-03-23T17:16:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Windows-XAML/Template10/pulls/781","html_url":"https://github.com/Windows-XAML/Template10/pull/781","diff_url":"https://github.com/Windows-XAML/Template10/pull/781.diff","patch_url":"https://github.com/Windows-XAML/Template10/pull/781.patch"},"body":"…mburger menu is closed\r\n\r\nBased on #766 and #769 I thought it would be cool to have a go at one-upping the first party apps by getting the tooltip showing for Hamburger menu items, only when the Menu pane isn't open.\r\n\r\nI'd be happy to see what people think of this approach, refactor and make a real pull request.\r\n\r\nRight now, I get the HamburgerButton label by manually checking the children of the Content UIElement in the HamburgerButtonInfo, but adding a property would be nicer so you can specify the tooltip directly, or it defaults to null which hides the tooltip.  Depends how automated people think it should be...  I also thing it would be nice if the \"ToolTip\" property, if set would set the screenreader text for accessibility purposes.\r\n\r\nThoughts?\r\n\r\n*I'm not intending for this to get pulled, but to get some feedback and refactor as appropriate*"},"comment":{"url":"https://api.github.com/repos/Windows-XAML/Template10/issues/comments/200447952","html_url":"https://github.com/Windows-XAML/Template10/pull/781#issuecomment-200447952","issue_url":"https://api.github.com/repos/Windows-XAML/Template10/issues/781","id":200447952,"user":{"login":"o0rebelious0o","id":2041260,"avatar_url":"https://avatars.githubusercontent.com/u/2041260?v=3","gravatar_id":"","url":"https://api.github.com/users/o0rebelious0o","html_url":"https://github.com/o0rebelious0o","followers_url":"https://api.github.com/users/o0rebelious0o/followers","following_url":"https://api.github.com/users/o0rebelious0o/following{/other_user}","gists_url":"https://api.github.com/users/o0rebelious0o/gists{/gist_id}","starred_url":"https://api.github.com/users/o0rebelious0o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/o0rebelious0o/subscriptions","organizations_url":"https://api.github.com/users/o0rebelious0o/orgs","repos_url":"https://api.github.com/users/o0rebelious0o/repos","events_url":"https://api.github.com/users/o0rebelious0o/events{/privacy}","received_events_url":"https://api.github.com/users/o0rebelious0o/received_events","type":"User","site_admin":false},"created_at":"2016-03-23T17:16:12Z","updated_at":"2016-03-23T17:16:12Z","body":"haha, parameter=\"Potato\".... whoops, I was using the for debugging and forgot to take it out :laughing: \r\n\r\nI'll use `nameof` instead of the magic string, I think that was an autogenerated snippet which I didn't update.\r\n\r\nI'll look at how the tooltip behaves when things are disabled; really IMO the buttons shouldn't be using a click event through to codebehind, they should be bound to a delegatecommand which can disable them properly with a predicate.  The tooltip itself is attached to the radiobutton of the template, so I *think* it should show regardless of the underlying button state, but again, would have to check.\r\n\r\nWhilst I'm looking at it, I'll also look at accessibility such as tabstops and narrator, these are really important for any professional quality apps building on T10."}}