{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/16249","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16249/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16249/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16249/events","html_url":"https://github.com/cms-sw/cmssw/pull/16249","id":183701990,"number":16249,"title":"Add HO, HF, and CaloTower Reco Geometry Display","user":{"login":"ianna","id":1390682,"avatar_url":"https://avatars.githubusercontent.com/u/1390682?v=3","gravatar_id":"","url":"https://api.github.com/users/ianna","html_url":"https://github.com/ianna","followers_url":"https://api.github.com/users/ianna/followers","following_url":"https://api.github.com/users/ianna/following{/other_user}","gists_url":"https://api.github.com/users/ianna/gists{/gist_id}","starred_url":"https://api.github.com/users/ianna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianna/subscriptions","organizations_url":"https://api.github.com/users/ianna/orgs","repos_url":"https://api.github.com/users/ianna/repos","events_url":"https://api.github.com/users/ianna/events{/privacy}","received_events_url":"https://api.github.com/users/ianna/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/fully-signed","name":"fully-signed","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-approved","name":"orp-approved","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/visualization-approved","name":"visualization-approved","color":"009800"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":72,"closed_issues":1734,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-10-22T15:54:51Z","due_on":null,"closed_at":null},"comments":11,"created_at":"2016-10-18T14:25:07Z","updated_at":"2016-10-22T16:35:24Z","closed_at":"2016-10-20T19:09:31Z","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/16249","html_url":"https://github.com/cms-sw/cmssw/pull/16249","diff_url":"https://github.com/cms-sw/cmssw/pull/16249.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/16249.patch"},"body":"* Add HcalOuter reco geometry display (note, cells look strange - dEta seems to be zero)\r\n* Add HcalForward reco geometry display (note, cells look in-side-out)\r\n* Add CaloTower reco geometry (note, cells in HF and HE region look fine, cells in HB region seem to have zero dEta)\r\n* Corners order is modeled on HB/HE since the same shapes are used\r\n* Add an option switch to dump reco geometry for only one specific subdetector\r\n\r\n@kpedro88, @bsunanda - FYI\r\nLong lines in barrel region are CaloTowers:\r\n![screenshot 2016-10-18 16 22 01](https://cloud.githubusercontent.com/assets/1390682/19481726/35795020-954f-11e6-9b82-2c9cb5017397.png)\r\n\r\nHere are only CaloTowers (light green) plus Ecal cells (blue):\r\n![screenshot 2016-10-18 16 21 22](https://cloud.githubusercontent.com/assets/1390682/19481751/50618556-954f-11e6-90c8-2b43afa50f0a.png)\r\n"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/255538617","html_url":"https://github.com/cms-sw/cmssw/pull/16249#issuecomment-255538617","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16249","id":255538617,"user":{"login":"kpedro88","id":4672808,"avatar_url":"https://avatars.githubusercontent.com/u/4672808?v=3","gravatar_id":"","url":"https://api.github.com/users/kpedro88","html_url":"https://github.com/kpedro88","followers_url":"https://api.github.com/users/kpedro88/followers","following_url":"https://api.github.com/users/kpedro88/following{/other_user}","gists_url":"https://api.github.com/users/kpedro88/gists{/gist_id}","starred_url":"https://api.github.com/users/kpedro88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpedro88/subscriptions","organizations_url":"https://api.github.com/users/kpedro88/orgs","repos_url":"https://api.github.com/users/kpedro88/repos","events_url":"https://api.github.com/users/kpedro88/events{/privacy}","received_events_url":"https://api.github.com/users/kpedro88/received_events","type":"User","site_admin":false},"created_at":"2016-10-22T16:35:24Z","updated_at":"2016-10-22T16:35:24Z","body":"@ianna sorry, forgot to reply to your question:\r\n\r\nin `CaloTowersCreationAlgo`, I think only the tower center is used: `theTowerGeometry->getGeometry(id)->getPosition()` (positions of individual ECAL and HCAL cells can also be used).\r\n\r\nI'm not sure about downstream uses of CaloTowers in reco algorithms, @slava77 is probably more knowledgeable."}}
{"actor":{"display_login":"kpedro88"}}