{"action":"created","comment":{"url":"https://api.github.com/repos/Alfresco/Aikau/pulls/comments/76942939","id":76942939,"diff_hunk":"@@ -474,8 +474,8 @@ define([\"dojo/_base/declare\",\n             duration: payload.duration || 0,\n             fullScreenMode: payload.fullScreenMode || false,\n             fullScreenPadding: !isNaN(payload.fullScreenPadding) ? payload.fullScreenPadding : 10,\n-            widgetsContent: payload.widgetsContent,\n-            widgetsButtons: payload.widgetsButtons,\n+            widgetsContent: lang.clone(payload.widgetsContent),\n+            widgetsButtons: lang.clone(payload.widgetsButtons),","path":"aikau/src/main/resources/alfresco/services/DialogService.js","position":7,"original_position":7,"commit_id":"b2ae14a72a6561dc5556e6db14bebce34f4097c5","original_commit_id":"b2ae14a72a6561dc5556e6db14bebce34f4097c5","user":{"login":"MartinDoyleUK","id":2427267,"avatar_url":"https://avatars.githubusercontent.com/u/2427267?v=3","gravatar_id":"","url":"https://api.github.com/users/MartinDoyleUK","html_url":"https://github.com/MartinDoyleUK","followers_url":"https://api.github.com/users/MartinDoyleUK/followers","following_url":"https://api.github.com/users/MartinDoyleUK/following{/other_user}","gists_url":"https://api.github.com/users/MartinDoyleUK/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinDoyleUK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinDoyleUK/subscriptions","organizations_url":"https://api.github.com/users/MartinDoyleUK/orgs","repos_url":"https://api.github.com/users/MartinDoyleUK/repos","events_url":"https://api.github.com/users/MartinDoyleUK/events{/privacy}","received_events_url":"https://api.github.com/users/MartinDoyleUK/received_events","type":"User","site_admin":false},"body":"Just to double-check that the widgetsContent and widgetsButtons are either never undefined/null or do not cause a problem with lang.clone if they are?","created_at":"2016-08-31T08:15:19Z","updated_at":"2016-08-31T08:15:19Z","html_url":"https://github.com/Alfresco/Aikau/pull/1218#discussion_r76942939","pull_request_url":"https://api.github.com/repos/Alfresco/Aikau/pulls/1218","_links":{"self":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/comments/76942939"},"html":{"href":"https://github.com/Alfresco/Aikau/pull/1218#discussion_r76942939"},"pull_request":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/1218"}}},"pull_request":{"url":"https://api.github.com/repos/Alfresco/Aikau/pulls/1218","id":83329728,"html_url":"https://github.com/Alfresco/Aikau/pull/1218","diff_url":"https://github.com/Alfresco/Aikau/pull/1218.diff","patch_url":"https://github.com/Alfresco/Aikau/pull/1218.patch","issue_url":"https://api.github.com/repos/Alfresco/Aikau/issues/1218","number":1218,"state":"open","locked":false,"title":"AKU-1080: Ensure DialogService clones widget models","user":{"login":"draperd","id":1084047,"avatar_url":"https://avatars.githubusercontent.com/u/1084047?v=3","gravatar_id":"","url":"https://api.github.com/users/draperd","html_url":"https://github.com/draperd","followers_url":"https://api.github.com/users/draperd/followers","following_url":"https://api.github.com/users/draperd/following{/other_user}","gists_url":"https://api.github.com/users/draperd/gists{/gist_id}","starred_url":"https://api.github.com/users/draperd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/draperd/subscriptions","organizations_url":"https://api.github.com/users/draperd/orgs","repos_url":"https://api.github.com/users/draperd/repos","events_url":"https://api.github.com/users/draperd/events{/privacy}","received_events_url":"https://api.github.com/users/draperd/received_events","type":"User","site_admin":false},"body":"This PR addresses https://issues.alfresco.com/jira/browse/AKU-1080 to ensure that the DialogService clones widget models that are provided. This ensures that repeated invocations of the same dialog (in the failing case a dialog containing a form) will not use a model updated (for example with pubSubScope data) with the first invocation. A unit test has been added that replicates the failing use case to ensure that it is fixed.","created_at":"2016-08-30T19:14:07Z","updated_at":"2016-08-31T08:15:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"653a0d776bccba7a51219df39d24e140844db072","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Alfresco/Aikau/pulls/1218/commits","review_comments_url":"https://api.github.com/repos/Alfresco/Aikau/pulls/1218/comments","review_comment_url":"https://api.github.com/repos/Alfresco/Aikau/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alfresco/Aikau/issues/1218/comments","statuses_url":"https://api.github.com/repos/Alfresco/Aikau/statuses/b2ae14a72a6561dc5556e6db14bebce34f4097c5","head":{"label":"Alfresco:feature/AKU-1080_DialogServiceCloning","ref":"feature/AKU-1080_DialogServiceCloning","sha":"b2ae14a72a6561dc5556e6db14bebce34f4097c5","user":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars.githubusercontent.com/u/391127?v=3","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"repo":{"id":29740360,"name":"Aikau","full_name":"Alfresco/Aikau","owner":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars.githubusercontent.com/u/391127?v=3","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alfresco/Aikau","description":"Aikau UI framework","fork":false,"url":"https://api.github.com/repos/Alfresco/Aikau","forks_url":"https://api.github.com/repos/Alfresco/Aikau/forks","keys_url":"https://api.github.com/repos/Alfresco/Aikau/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alfresco/Aikau/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alfresco/Aikau/teams","hooks_url":"https://api.github.com/repos/Alfresco/Aikau/hooks","issue_events_url":"https://api.github.com/repos/Alfresco/Aikau/issues/events{/number}","events_url":"https://api.github.com/repos/Alfresco/Aikau/events","assignees_url":"https://api.github.com/repos/Alfresco/Aikau/assignees{/user}","branches_url":"https://api.github.com/repos/Alfresco/Aikau/branches{/branch}","tags_url":"https://api.github.com/repos/Alfresco/Aikau/tags","blobs_url":"https://api.github.com/repos/Alfresco/Aikau/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alfresco/Aikau/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alfresco/Aikau/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alfresco/Aikau/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alfresco/Aikau/statuses/{sha}","languages_url":"https://api.github.com/repos/Alfresco/Aikau/languages","stargazers_url":"https://api.github.com/repos/Alfresco/Aikau/stargazers","contributors_url":"https://api.github.com/repos/Alfresco/Aikau/contributors","subscribers_url":"https://api.github.com/repos/Alfresco/Aikau/subscribers","subscription_url":"https://api.github.com/repos/Alfresco/Aikau/subscription","commits_url":"https://api.github.com/repos/Alfresco/Aikau/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alfresco/Aikau/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alfresco/Aikau/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alfresco/Aikau/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alfresco/Aikau/contents/{+path}","compare_url":"https://api.github.com/repos/Alfresco/Aikau/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alfresco/Aikau/merges","archive_url":"https://api.github.com/repos/Alfresco/Aikau/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alfresco/Aikau/downloads","issues_url":"https://api.github.com/repos/Alfresco/Aikau/issues{/number}","pulls_url":"https://api.github.com/repos/Alfresco/Aikau/pulls{/number}","milestones_url":"https://api.github.com/repos/Alfresco/Aikau/milestones{/number}","notifications_url":"https://api.github.com/repos/Alfresco/Aikau/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alfresco/Aikau/labels{/name}","releases_url":"https://api.github.com/repos/Alfresco/Aikau/releases{/id}","deployments_url":"https://api.github.com/repos/Alfresco/Aikau/deployments","created_at":"2015-01-23T16:04:14Z","updated_at":"2016-08-06T21:44:18Z","pushed_at":"2016-08-31T08:12:02Z","git_url":"git://github.com/Alfresco/Aikau.git","ssh_url":"git@github.com:Alfresco/Aikau.git","clone_url":"https://github.com/Alfresco/Aikau.git","svn_url":"https://github.com/Alfresco/Aikau","homepage":null,"size":79504,"stargazers_count":50,"watchers_count":50,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":7,"forks":39,"open_issues":7,"watchers":50,"default_branch":"master"}},"base":{"label":"Alfresco:develop","ref":"develop","sha":"75544f79b115009d6e4ccda5984e149aea815b9f","user":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars.githubusercontent.com/u/391127?v=3","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"repo":{"id":29740360,"name":"Aikau","full_name":"Alfresco/Aikau","owner":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars.githubusercontent.com/u/391127?v=3","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alfresco/Aikau","description":"Aikau UI framework","fork":false,"url":"https://api.github.com/repos/Alfresco/Aikau","forks_url":"https://api.github.com/repos/Alfresco/Aikau/forks","keys_url":"https://api.github.com/repos/Alfresco/Aikau/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alfresco/Aikau/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alfresco/Aikau/teams","hooks_url":"https://api.github.com/repos/Alfresco/Aikau/hooks","issue_events_url":"https://api.github.com/repos/Alfresco/Aikau/issues/events{/number}","events_url":"https://api.github.com/repos/Alfresco/Aikau/events","assignees_url":"https://api.github.com/repos/Alfresco/Aikau/assignees{/user}","branches_url":"https://api.github.com/repos/Alfresco/Aikau/branches{/branch}","tags_url":"https://api.github.com/repos/Alfresco/Aikau/tags","blobs_url":"https://api.github.com/repos/Alfresco/Aikau/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alfresco/Aikau/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alfresco/Aikau/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alfresco/Aikau/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alfresco/Aikau/statuses/{sha}","languages_url":"https://api.github.com/repos/Alfresco/Aikau/languages","stargazers_url":"https://api.github.com/repos/Alfresco/Aikau/stargazers","contributors_url":"https://api.github.com/repos/Alfresco/Aikau/contributors","subscribers_url":"https://api.github.com/repos/Alfresco/Aikau/subscribers","subscription_url":"https://api.github.com/repos/Alfresco/Aikau/subscription","commits_url":"https://api.github.com/repos/Alfresco/Aikau/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alfresco/Aikau/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alfresco/Aikau/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alfresco/Aikau/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alfresco/Aikau/contents/{+path}","compare_url":"https://api.github.com/repos/Alfresco/Aikau/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alfresco/Aikau/merges","archive_url":"https://api.github.com/repos/Alfresco/Aikau/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alfresco/Aikau/downloads","issues_url":"https://api.github.com/repos/Alfresco/Aikau/issues{/number}","pulls_url":"https://api.github.com/repos/Alfresco/Aikau/pulls{/number}","milestones_url":"https://api.github.com/repos/Alfresco/Aikau/milestones{/number}","notifications_url":"https://api.github.com/repos/Alfresco/Aikau/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alfresco/Aikau/labels{/name}","releases_url":"https://api.github.com/repos/Alfresco/Aikau/releases{/id}","deployments_url":"https://api.github.com/repos/Alfresco/Aikau/deployments","created_at":"2015-01-23T16:04:14Z","updated_at":"2016-08-06T21:44:18Z","pushed_at":"2016-08-31T08:12:02Z","git_url":"git://github.com/Alfresco/Aikau.git","ssh_url":"git@github.com:Alfresco/Aikau.git","clone_url":"https://github.com/Alfresco/Aikau.git","svn_url":"https://github.com/Alfresco/Aikau","homepage":null,"size":79504,"stargazers_count":50,"watchers_count":50,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":7,"forks":39,"open_issues":7,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/1218"},"html":{"href":"https://github.com/Alfresco/Aikau/pull/1218"},"issue":{"href":"https://api.github.com/repos/Alfresco/Aikau/issues/1218"},"comments":{"href":"https://api.github.com/repos/Alfresco/Aikau/issues/1218/comments"},"review_comments":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/1218/comments"},"review_comment":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alfresco/Aikau/pulls/1218/commits"},"statuses":{"href":"https://api.github.com/repos/Alfresco/Aikau/statuses/b2ae14a72a6561dc5556e6db14bebce34f4097c5"}}}}
{"actor":{"display_login":"MartinDoyleUK"}}