{"action":"created","issue":{"url":"https://api.github.com/repos/Rookies-RGSOC2016/hoodie-electron-app/issues/50","repository_url":"https://api.github.com/repos/Rookies-RGSOC2016/hoodie-electron-app","labels_url":"https://api.github.com/repos/Rookies-RGSOC2016/hoodie-electron-app/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/Rookies-RGSOC2016/hoodie-electron-app/issues/50/comments","events_url":"https://api.github.com/repos/Rookies-RGSOC2016/hoodie-electron-app/issues/50/events","html_url":"https://github.com/Rookies-RGSOC2016/hoodie-electron-app/pull/50","id":174055874,"number":50,"title":"Issue/49","user":{"login":"titay2","id":17122525,"avatar_url":"https://avatars.githubusercontent.com/u/17122525?v=3","gravatar_id":"","url":"https://api.github.com/users/titay2","html_url":"https://github.com/titay2","followers_url":"https://api.github.com/users/titay2/followers","following_url":"https://api.github.com/users/titay2/following{/other_user}","gists_url":"https://api.github.com/users/titay2/gists{/gist_id}","starred_url":"https://api.github.com/users/titay2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/titay2/subscriptions","organizations_url":"https://api.github.com/users/titay2/orgs","repos_url":"https://api.github.com/users/titay2/repos","events_url":"https://api.github.com/users/titay2/events{/privacy}","received_events_url":"https://api.github.com/users/titay2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-08-30T15:48:47Z","updated_at":"2016-09-01T20:18:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Rookies-RGSOC2016/hoodie-electron-app/pulls/50","html_url":"https://github.com/Rookies-RGSOC2016/hoodie-electron-app/pull/50","diff_url":"https://github.com/Rookies-RGSOC2016/hoodie-electron-app/pull/50.diff","patch_url":"https://github.com/Rookies-RGSOC2016/hoodie-electron-app/pull/50.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/Rookies-RGSOC2016/hoodie-electron-app/issues/comments/244199204","html_url":"https://github.com/Rookies-RGSOC2016/hoodie-electron-app/pull/50#issuecomment-244199204","issue_url":"https://api.github.com/repos/Rookies-RGSOC2016/hoodie-electron-app/issues/50","id":244199204,"user":{"login":"gr2m","id":39992,"avatar_url":"https://avatars.githubusercontent.com/u/39992?v=3","gravatar_id":"","url":"https://api.github.com/users/gr2m","html_url":"https://github.com/gr2m","followers_url":"https://api.github.com/users/gr2m/followers","following_url":"https://api.github.com/users/gr2m/following{/other_user}","gists_url":"https://api.github.com/users/gr2m/gists{/gist_id}","starred_url":"https://api.github.com/users/gr2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gr2m/subscriptions","organizations_url":"https://api.github.com/users/gr2m/orgs","repos_url":"https://api.github.com/users/gr2m/repos","events_url":"https://api.github.com/users/gr2m/events{/privacy}","received_events_url":"https://api.github.com/users/gr2m/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T20:18:26Z","updated_at":"2016-09-01T20:18:26Z","body":"@titay2 I cleaned up the code a little bit and removed the styling of the modal. I had no problems with it, can you check it again? If it works for you, I’d say let’s merge it in?\r\n\r\nOne more thing I’d like to do with the code before moving over to riot.js is to add a route for editing an app. I’d suggest something like `/#abc4567/edit` for the app with id `abc4567`. In the `handleRoute` function where we check for the routes, we can then check for these routes with something like this\r\n\r\n```\r\nif (path.substr(-5) === '/edit') {\r\n  var id = path.substr(0, path.length - 5)\r\n  renderEditAppForm(id)\r\n  return\r\n}\r\n```\r\n\r\nAnd then implement `renderEditAppForm` similar to how `renderAppDetail` is implemented. \r\nDoes that all make sense? But as I said, I’d suggest we merge this PR in, and then work on the route in a separate PR"}}
{"actor":{"display_login":"gr2m"}}