{"action":"created","comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/81292892","pull_request_review_id":2282448,"id":81292892,"diff_hunk":"@@ -72,12 +73,8 @@ void ResponseFromHMI::SendResponseToMobile(\n void ResponseFromHMI::CreateHMIRequest(\n     const hmi_apis::FunctionID::eType& function_id,\n     const smart_objects::SmartObject& msg_params) const {\n-  smart_objects::SmartObjectSPtr result = new smart_objects::SmartObject;\n-\n-  if (!result) {\n-    SDL_ERROR(\"Memory allocation failed.\");\n-    return;\n-  }\n+  smart_objects::SmartObjectSPtr result =\n+      utils::MakeShared<smart_objects::SmartObject>();","path":"src/components/application_manager/src/commands/hmi/response_from_hmi.cc","position":null,"original_position":19,"commit_id":"a005ca737f9100994641cbae928096d2c88df162","original_commit_id":"bcecdc24dfba5b03b0e43d6910e4c096f98b364e","user":{"login":"anosach-luxoft","id":11158680,"avatar_url":"https://avatars.githubusercontent.com/u/11158680?v=3","gravatar_id":"","url":"https://api.github.com/users/anosach-luxoft","html_url":"https://github.com/anosach-luxoft","followers_url":"https://api.github.com/users/anosach-luxoft/followers","following_url":"https://api.github.com/users/anosach-luxoft/following{/other_user}","gists_url":"https://api.github.com/users/anosach-luxoft/gists{/gist_id}","starred_url":"https://api.github.com/users/anosach-luxoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anosach-luxoft/subscriptions","organizations_url":"https://api.github.com/users/anosach-luxoft/orgs","repos_url":"https://api.github.com/users/anosach-luxoft/repos","events_url":"https://api.github.com/users/anosach-luxoft/events{/privacy}","received_events_url":"https://api.github.com/users/anosach-luxoft/received_events","type":"User","site_admin":false},"body":"@Kozoriz stop. You changed `MakeShared` usage to simple `new`?? No, I mean to change nothrow new to regular new in `MakeShared`","created_at":"2016-09-30T07:53:30Z","updated_at":"2016-09-30T07:53:30Z","html_url":"https://github.com/smartdevicelink/sdl_core/pull/853#discussion_r81292892","pull_request_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/853","_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/81292892"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/853#discussion_r81292892"},"pull_request":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/853"}}},"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/853","id":87069810,"html_url":"https://github.com/smartdevicelink/sdl_core/pull/853","diff_url":"https://github.com/smartdevicelink/sdl_core/pull/853.diff","patch_url":"https://github.com/smartdevicelink/sdl_core/pull/853.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/853","number":853,"state":"open","locked":false,"title":"Cover commands with unit tests","user":{"login":"Kozoriz","id":8917619,"avatar_url":"https://avatars.githubusercontent.com/u/8917619?v=3","gravatar_id":"","url":"https://api.github.com/users/Kozoriz","html_url":"https://github.com/Kozoriz","followers_url":"https://api.github.com/users/Kozoriz/followers","following_url":"https://api.github.com/users/Kozoriz/following{/other_user}","gists_url":"https://api.github.com/users/Kozoriz/gists{/gist_id}","starred_url":"https://api.github.com/users/Kozoriz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kozoriz/subscriptions","organizations_url":"https://api.github.com/users/Kozoriz/orgs","repos_url":"https://api.github.com/users/Kozoriz/repos","events_url":"https://api.github.com/users/Kozoriz/events{/privacy}","received_events_url":"https://api.github.com/users/Kozoriz/received_events","type":"User","site_admin":false},"body":" - set_icon_response\r\n - response_from_hmi\r\n - delete_sub_menu_request\r\n - command_notification_impl\r\n - on_hmi_status_notification_from_mobile\r\n - notification_to_hmi\r\n - on_button_event_notification\r\n - on_button_press_notification\r\n\r\nRelated task : [APPLINK-28072)](https://adc.luxoft.com/jira/browse/APPLINK-28072)","created_at":"2016-09-28T07:48:20Z","updated_at":"2016-09-30T07:53:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"763e6d45edec3ab71e5ba799901415cbaa402db5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/853/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/853/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/853/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/a005ca737f9100994641cbae928096d2c88df162","head":{"label":"Kozoriz:feature/Fully_cover_commands_with_unit_tests","ref":"feature/Fully_cover_commands_with_unit_tests","sha":"a005ca737f9100994641cbae928096d2c88df162","user":{"login":"Kozoriz","id":8917619,"avatar_url":"https://avatars.githubusercontent.com/u/8917619?v=3","gravatar_id":"","url":"https://api.github.com/users/Kozoriz","html_url":"https://github.com/Kozoriz","followers_url":"https://api.github.com/users/Kozoriz/followers","following_url":"https://api.github.com/users/Kozoriz/following{/other_user}","gists_url":"https://api.github.com/users/Kozoriz/gists{/gist_id}","starred_url":"https://api.github.com/users/Kozoriz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kozoriz/subscriptions","organizations_url":"https://api.github.com/users/Kozoriz/orgs","repos_url":"https://api.github.com/users/Kozoriz/repos","events_url":"https://api.github.com/users/Kozoriz/events{/privacy}","received_events_url":"https://api.github.com/users/Kozoriz/received_events","type":"User","site_admin":false},"repo":{"id":54200684,"name":"sdl_core","full_name":"Kozoriz/sdl_core","owner":{"login":"Kozoriz","id":8917619,"avatar_url":"https://avatars.githubusercontent.com/u/8917619?v=3","gravatar_id":"","url":"https://api.github.com/users/Kozoriz","html_url":"https://github.com/Kozoriz","followers_url":"https://api.github.com/users/Kozoriz/followers","following_url":"https://api.github.com/users/Kozoriz/following{/other_user}","gists_url":"https://api.github.com/users/Kozoriz/gists{/gist_id}","starred_url":"https://api.github.com/users/Kozoriz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kozoriz/subscriptions","organizations_url":"https://api.github.com/users/Kozoriz/orgs","repos_url":"https://api.github.com/users/Kozoriz/repos","events_url":"https://api.github.com/users/Kozoriz/events{/privacy}","received_events_url":"https://api.github.com/users/Kozoriz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kozoriz/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":true,"url":"https://api.github.com/repos/Kozoriz/sdl_core","forks_url":"https://api.github.com/repos/Kozoriz/sdl_core/forks","keys_url":"https://api.github.com/repos/Kozoriz/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kozoriz/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kozoriz/sdl_core/teams","hooks_url":"https://api.github.com/repos/Kozoriz/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/Kozoriz/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/Kozoriz/sdl_core/events","assignees_url":"https://api.github.com/repos/Kozoriz/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/Kozoriz/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/Kozoriz/sdl_core/tags","blobs_url":"https://api.github.com/repos/Kozoriz/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kozoriz/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kozoriz/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kozoriz/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kozoriz/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/Kozoriz/sdl_core/languages","stargazers_url":"https://api.github.com/repos/Kozoriz/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/Kozoriz/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/Kozoriz/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/Kozoriz/sdl_core/subscription","commits_url":"https://api.github.com/repos/Kozoriz/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kozoriz/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kozoriz/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kozoriz/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kozoriz/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/Kozoriz/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kozoriz/sdl_core/merges","archive_url":"https://api.github.com/repos/Kozoriz/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kozoriz/sdl_core/downloads","issues_url":"https://api.github.com/repos/Kozoriz/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/Kozoriz/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/Kozoriz/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/Kozoriz/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kozoriz/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/Kozoriz/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/Kozoriz/sdl_core/deployments","created_at":"2016-03-18T12:49:23Z","updated_at":"2016-03-18T12:49:31Z","pushed_at":"2016-09-30T07:39:12Z","git_url":"git://github.com/Kozoriz/sdl_core.git","ssh_url":"git@github.com:Kozoriz/sdl_core.git","clone_url":"https://github.com/Kozoriz/sdl_core.git","svn_url":"https://github.com/Kozoriz/sdl_core","homepage":"","size":176249,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"smartdevicelink:develop","ref":"develop","sha":"4ed200b3a1faa61b1810ee907b82a094bb32f564","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24724170,"name":"sdl_core","full_name":"smartdevicelink/sdl_core","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_core","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_core/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_core/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_core/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_core/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/deployments","created_at":"2014-10-02T15:16:26Z","updated_at":"2016-09-29T03:18:39Z","pushed_at":"2016-09-30T07:39:13Z","git_url":"git://github.com/smartdevicelink/sdl_core.git","ssh_url":"git@github.com:smartdevicelink/sdl_core.git","clone_url":"https://github.com/smartdevicelink/sdl_core.git","svn_url":"https://github.com/smartdevicelink/sdl_core","homepage":"","size":312898,"stargazers_count":79,"watchers_count":79,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"open_issues_count":101,"forks":98,"open_issues":101,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/853"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/853"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/853"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/853/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/853/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/853/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/a005ca737f9100994641cbae928096d2c88df162"}}}}
{"actor":{"display_login":"anosach-luxoft"}}