{"action":"created","issue":{"url":"https://api.github.com/repos/canjs/can-construct/issues/6","repository_url":"https://api.github.com/repos/canjs/can-construct","labels_url":"https://api.github.com/repos/canjs/can-construct/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/canjs/can-construct/issues/6/comments","events_url":"https://api.github.com/repos/canjs/can-construct/issues/6/events","html_url":"https://github.com/canjs/can-construct/issues/6","id":159697890,"number":6,"title":"Parameter CleanUp","user":{"login":"BigAB","id":76821,"avatar_url":"https://avatars.githubusercontent.com/u/76821?v=3","gravatar_id":"","url":"https://api.github.com/users/BigAB","html_url":"https://github.com/BigAB","followers_url":"https://api.github.com/users/BigAB/followers","following_url":"https://api.github.com/users/BigAB/following{/other_user}","gists_url":"https://api.github.com/users/BigAB/gists{/gist_id}","starred_url":"https://api.github.com/users/BigAB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BigAB/subscriptions","organizations_url":"https://api.github.com/users/BigAB/orgs","repos_url":"https://api.github.com/users/BigAB/repos","events_url":"https://api.github.com/users/BigAB/events{/privacy}","received_events_url":"https://api.github.com/users/BigAB/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-06-10T18:48:42Z","updated_at":"2016-06-10T20:39:00Z","closed_at":null,"body":"_(Lovingly copy'pasted from https://github.com/canjs/can-define/issues/21)_\r\nI have always considered the arguments passed in to Map.extend params confusing and unintuitive.\r\n\r\n`can.DefineMap.extend( instancePropsMethods )` -> one argument extends the prototype\r\n`can.DefineMap.extend( static, instancePropsMethods )` -> if I add a second argument, I have to move the options to the second position because now the first position extends the constructors 'static' methods\r\n`can.DefineMap.extend(  'name', static, instancePropsMethods )` -> to add a name I have to shift it all down because the first argument is now a string for name.\r\n\r\nI can't think other examples in other popular libraries that make you shift around your arguments depending on how many you provide.\r\n\r\nWith this as an opportunity to break from the legacy confusion, would you consider a signature like:\r\n\r\n`can.DefineMap.extend(prototype, [,static]  [, options:{ name } ])`\r\n_where options would be an optional argument which is an object with an optional name property_\r\n"},"comment":{"url":"https://api.github.com/repos/canjs/can-construct/issues/comments/225289598","html_url":"https://github.com/canjs/can-construct/issues/6#issuecomment-225289598","issue_url":"https://api.github.com/repos/canjs/can-construct/issues/6","id":225289598,"user":{"login":"justinbmeyer","id":78602,"avatar_url":"https://avatars.githubusercontent.com/u/78602?v=3","gravatar_id":"","url":"https://api.github.com/users/justinbmeyer","html_url":"https://github.com/justinbmeyer","followers_url":"https://api.github.com/users/justinbmeyer/followers","following_url":"https://api.github.com/users/justinbmeyer/following{/other_user}","gists_url":"https://api.github.com/users/justinbmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/justinbmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinbmeyer/subscriptions","organizations_url":"https://api.github.com/users/justinbmeyer/orgs","repos_url":"https://api.github.com/users/justinbmeyer/repos","events_url":"https://api.github.com/users/justinbmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/justinbmeyer/received_events","type":"User","site_admin":false},"created_at":"2016-06-10T20:39:00Z","updated_at":"2016-06-10T20:39:00Z","body":"I'm not sure why there's an `options` argument when all it's ever going to take is the name.\r\n\r\nOther thoughts from people can be found here: http://forums.donejs.com/t/an-opportunity-to-clean-up-some-legacy-api-stuff/308\r\n\r\nI don't think this is going to be something in 3.0, but lets keep this open to discus for 4.0.  (_my secret hope is that we can use ES Class declarations by then_)."}}
{"actor":{"display_login":"justinbmeyer"}}