{"action":"created","issue":{"url":"https://api.github.com/repos/uxmal/reko/issues/99","labels_url":"https://api.github.com/repos/uxmal/reko/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/uxmal/reko/issues/99/comments","events_url":"https://api.github.com/repos/uxmal/reko/issues/99/events","html_url":"https://github.com/uxmal/reko/issues/99","id":125768112,"number":99,"title":"UserSignatureBuilder does not resolve type references","user":{"login":"ptomin","id":13188041,"avatar_url":"https://avatars.githubusercontent.com/u/13188041?v=3","gravatar_id":"","url":"https://api.github.com/users/ptomin","html_url":"https://github.com/ptomin","followers_url":"https://api.github.com/users/ptomin/followers","following_url":"https://api.github.com/users/ptomin/following{/other_user}","gists_url":"https://api.github.com/users/ptomin/gists{/gist_id}","starred_url":"https://api.github.com/users/ptomin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptomin/subscriptions","organizations_url":"https://api.github.com/users/ptomin/orgs","repos_url":"https://api.github.com/users/ptomin/repos","events_url":"https://api.github.com/users/ptomin/events{/privacy}","received_events_url":"https://api.github.com/users/ptomin/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-01-09T16:33:00Z","updated_at":"2016-01-15T20:09:37Z","closed_at":"2016-01-15T20:09:37Z","body":"e.g. if CSignature = \"BYTE testFunc(BYTE a, BYTE b)\" then UserSignatureBuilder throws CParserException exception. Type BYTE was not found but it was defined in windows32.xml.\r\n\r\nI think, UserSignatureBuilder should pass type defintions were obtained from *.xml files to CParser\r\n(Typedefs property of ParserState should be set)"},"comment":{"url":"https://api.github.com/repos/uxmal/reko/issues/comments/172074308","html_url":"https://github.com/uxmal/reko/issues/99#issuecomment-172074308","issue_url":"https://api.github.com/repos/uxmal/reko/issues/99","id":172074308,"user":{"login":"uxmal","id":10154465,"avatar_url":"https://avatars.githubusercontent.com/u/10154465?v=3","gravatar_id":"","url":"https://api.github.com/users/uxmal","html_url":"https://github.com/uxmal","followers_url":"https://api.github.com/users/uxmal/followers","following_url":"https://api.github.com/users/uxmal/following{/other_user}","gists_url":"https://api.github.com/users/uxmal/gists{/gist_id}","starred_url":"https://api.github.com/users/uxmal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uxmal/subscriptions","organizations_url":"https://api.github.com/users/uxmal/orgs","repos_url":"https://api.github.com/users/uxmal/repos","events_url":"https://api.github.com/users/uxmal/events{/privacy}","received_events_url":"https://api.github.com/users/uxmal/received_events","type":"User","site_admin":false},"created_at":"2016-01-15T20:09:37Z","updated_at":"2016-01-15T20:09:37Z","body":"1. Glad to finally have knocked this out of the park!\r\n2. If you identify the need for unit tests, don't hesistate to write them and submit PR's  <g>\r\n3. There is a feedback loop here. A user runs reko on a binary and it discovers structures. Today, these are imginatively called `Eq_1`, `Eq_2` etc. At the end of the decompilation run, user should be able to edit the names and fields of the data structures, whereupon a restart of reko should pick up the new names. \r\n\r\nThere should be a way for a user to add custom data types to the project, the question is how. Adding a C header file should be easy enough; reko has an ANSI C compiler to handle that. Is that enough? Does reko need a full blown source code editor, or something in between.\r\n\r\n In any case, this belongs in a separate issue. I will close this now and open a separate issue for 3. above."}}