{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/comments/76083241","id":76083241,"diff_hunk":"@@ -0,0 +1,75 @@\n+/*\n+ * Copyright 2016 Google Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package com.google.cloud.tools.appengine.v2.internal.cloudsdk;\n+\n+import com.google.cloud.tools.appengine.api.AppEngineException;\n+import com.google.cloud.tools.appengine.v2.AppEngineRequest;\n+import com.google.cloud.tools.appengine.v2.OutputHandler;\n+import com.google.cloud.tools.appengine.v2.internal.process.CliProcessManagerProvider;\n+import com.google.cloud.tools.appengine.v2.internal.process.io.NullOutputHandler;\n+import com.google.cloud.tools.appengine.v2.internal.process.io.StringResultConverter;\n+import com.google.common.base.Preconditions;\n+\n+import java.io.IOException;\n+import java.util.concurrent.Future;\n+\n+/**\n+ * The CloudSdkRequest template, all requests will essentially be instances of this class\n+ * while providing all the parts to actually initiate a request.\n+ *\n+ * @param <R> Request result type\n+ */\n+public class CloudSdkRequest<R> implements AppEngineRequest<R> {\n+  private final CloudSdkProcessFactory processProvider;\n+  private final CliProcessManagerProvider<R> processManagerProvider;\n+  private final StringResultConverter<R> resultConverter;\n+  private OutputHandler outputHandler;\n+  private boolean mutable = true;\n+\n+  /**\n+   * Create a new CloudSdkRequest, there are no subclasses, just configure the providers correctly.\n+   */\n+  public CloudSdkRequest(CloudSdkProcessFactory processProvider,","path":"src/main/java/com/google/cloud/tools/appengine/v2/internal/cloudsdk/CloudSdkRequest.java","position":46,"original_position":46,"commit_id":"3f589b068bc9778596fd487d60abd976feaf8ce5","original_commit_id":"3f589b068bc9778596fd487d60abd976feaf8ce5","user":{"login":"akerekes","id":3378942,"avatar_url":"https://avatars.githubusercontent.com/u/3378942?v=3","gravatar_id":"","url":"https://api.github.com/users/akerekes","html_url":"https://github.com/akerekes","followers_url":"https://api.github.com/users/akerekes/followers","following_url":"https://api.github.com/users/akerekes/following{/other_user}","gists_url":"https://api.github.com/users/akerekes/gists{/gist_id}","starred_url":"https://api.github.com/users/akerekes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akerekes/subscriptions","organizations_url":"https://api.github.com/users/akerekes/orgs","repos_url":"https://api.github.com/users/akerekes/repos","events_url":"https://api.github.com/users/akerekes/events{/privacy}","received_events_url":"https://api.github.com/users/akerekes/received_events","type":"User","site_admin":false},"body":"`processFactory`?","created_at":"2016-08-24T15:47:00Z","updated_at":"2016-08-24T15:47:00Z","html_url":"https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/182#discussion_r76083241","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/182","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/comments/76083241"},"html":{"href":"https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/182#discussion_r76083241"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/182"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/182","id":79364365,"html_url":"https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/182","diff_url":"https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/182.diff","patch_url":"https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/182.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/issues/182","number":182,"state":"open","locked":false,"title":"Futures (Request for feedback)","user":{"login":"loosebazooka","id":1304826,"avatar_url":"https://avatars.githubusercontent.com/u/1304826?v=3","gravatar_id":"","url":"https://api.github.com/users/loosebazooka","html_url":"https://github.com/loosebazooka","followers_url":"https://api.github.com/users/loosebazooka/followers","following_url":"https://api.github.com/users/loosebazooka/following{/other_user}","gists_url":"https://api.github.com/users/loosebazooka/gists{/gist_id}","starred_url":"https://api.github.com/users/loosebazooka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loosebazooka/subscriptions","organizations_url":"https://api.github.com/users/loosebazooka/orgs","repos_url":"https://api.github.com/users/loosebazooka/repos","events_url":"https://api.github.com/users/loosebazooka/events{/privacy}","received_events_url":"https://api.github.com/users/loosebazooka/received_events","type":"User","site_admin":false},"body":"Looking for highlevel feedback, you can ignore formatting/comment issues till later.\r\n\r\n@patflynn @meltsufin @etanshaul @akerekes @aslo @elharo @nbashirbello @joaoandremartins \r\n\r\nIt might make sense to pull the branch down into your repository and explore the v2 package path. Start with DeployExample.java\r\n\r\nCloudSdkv2 is just to disambiguate with the original cloudSdk to keep changes out of the main packages.","created_at":"2016-07-29T14:03:11Z","updated_at":"2016-08-24T15:47:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"098f06bb5e1a53e899ee269433612a3fb3879617","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/182/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/182/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/issues/182/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/statuses/3f589b068bc9778596fd487d60abd976feaf8ce5","head":{"label":"GoogleCloudPlatform:futures","ref":"futures","sha":"3f589b068bc9778596fd487d60abd976feaf8ce5","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":54120965,"name":"appengine-plugins-core","full_name":"GoogleCloudPlatform/appengine-plugins-core","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/appengine-plugins-core","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/deployments","created_at":"2016-03-17T13:42:30Z","updated_at":"2016-07-29T14:05:16Z","pushed_at":"2016-08-24T15:17:06Z","git_url":"git://github.com/GoogleCloudPlatform/appengine-plugins-core.git","ssh_url":"git@github.com:GoogleCloudPlatform/appengine-plugins-core.git","clone_url":"https://github.com/GoogleCloudPlatform/appengine-plugins-core.git","svn_url":"https://github.com/GoogleCloudPlatform/appengine-plugins-core","homepage":null,"size":665,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":32,"forks":2,"open_issues":32,"watchers":7,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"f48f5d092918b8f5f397e07477548b4ca19317f7","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":54120965,"name":"appengine-plugins-core","full_name":"GoogleCloudPlatform/appengine-plugins-core","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/appengine-plugins-core","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/deployments","created_at":"2016-03-17T13:42:30Z","updated_at":"2016-07-29T14:05:16Z","pushed_at":"2016-08-24T15:17:06Z","git_url":"git://github.com/GoogleCloudPlatform/appengine-plugins-core.git","ssh_url":"git@github.com:GoogleCloudPlatform/appengine-plugins-core.git","clone_url":"https://github.com/GoogleCloudPlatform/appengine-plugins-core.git","svn_url":"https://github.com/GoogleCloudPlatform/appengine-plugins-core","homepage":null,"size":665,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":32,"forks":2,"open_issues":32,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/182"},"html":{"href":"https://github.com/GoogleCloudPlatform/appengine-plugins-core/pull/182"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/issues/182"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/issues/182/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/182/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/pulls/182/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-plugins-core/statuses/3f589b068bc9778596fd487d60abd976feaf8ce5"}}}}
{"actor":{"display_login":"akerekes"}}