{"action":"created","comment":{"url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/pulls/comments/66944330","id":66944330,"diff_hunk":"@@ -2,6 +2,7 @@ module FloodRiskEngine\n   class Organisation < ActiveRecord::Base\n     belongs_to :contact\n     has_one :enrollment, dependent: :restrict_with_exception\n+    has_many :partners","path":"app/models/flood_risk_engine/organisation.rb","position":4,"original_position":4,"commit_id":"8fe9ec594af62c292ef747daea61c39170ef297c","original_commit_id":"9cb63b1b3f8523a5093c49dd7233da28b60c0229","user":{"login":"autotelik","id":110434,"avatar_url":"https://avatars.githubusercontent.com/u/110434?v=3","gravatar_id":"","url":"https://api.github.com/users/autotelik","html_url":"https://github.com/autotelik","followers_url":"https://api.github.com/users/autotelik/followers","following_url":"https://api.github.com/users/autotelik/following{/other_user}","gists_url":"https://api.github.com/users/autotelik/gists{/gist_id}","starred_url":"https://api.github.com/users/autotelik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotelik/subscriptions","organizations_url":"https://api.github.com/users/autotelik/orgs","repos_url":"https://api.github.com/users/autotelik/repos","events_url":"https://api.github.com/users/autotelik/events{/privacy}","received_events_url":"https://api.github.com/users/autotelik/received_events","type":"User","site_admin":false},"body":"Too late and irrelevant now in big scheme of things .. but not sure why STI was over kill, when its the correct abstraction ?  Coming from a C++/OO background it seemed very straight fwd to implement and understand. The enum adds complexity here with no benefit in managing behaviour.","created_at":"2016-06-14T10:18:42Z","updated_at":"2016-06-14T10:18:42Z","html_url":"https://github.com/EnvironmentAgency/flood-risk-engine/pull/145#discussion_r66944330","pull_request_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/pulls/145","_links":{"self":{"href":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/pulls/comments/66944330"},"html":{"href":"https://github.com/EnvironmentAgency/flood-risk-engine/pull/145#discussion_r66944330"},"pull_request":{"href":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/pulls/145"}}},"pull_request":{"url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/pulls/145","id":73589782,"html_url":"https://github.com/EnvironmentAgency/flood-risk-engine/pull/145","diff_url":"https://github.com/EnvironmentAgency/flood-risk-engine/pull/145.diff","patch_url":"https://github.com/EnvironmentAgency/flood-risk-engine/pull/145.patch","issue_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/issues/145","number":145,"state":"open","locked":false,"title":"Add partnership step - where the name of a partner is entered.","user":{"login":"reggieb","id":213040,"avatar_url":"https://avatars.githubusercontent.com/u/213040?v=3","gravatar_id":"","url":"https://api.github.com/users/reggieb","html_url":"https://github.com/reggieb","followers_url":"https://api.github.com/users/reggieb/followers","following_url":"https://api.github.com/users/reggieb/following{/other_user}","gists_url":"https://api.github.com/users/reggieb/gists{/gist_id}","starred_url":"https://api.github.com/users/reggieb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reggieb/subscriptions","organizations_url":"https://api.github.com/users/reggieb/orgs","repos_url":"https://api.github.com/users/reggieb/repos","events_url":"https://api.github.com/users/reggieb/events{/privacy}","received_events_url":"https://api.github.com/users/reggieb/received_events","type":"User","site_admin":false},"body":"See [RIP-89](https://eaflood.atlassian.net/browse/RIP-89)\r\n\r\nI'll need to return to this page to ensure that when a user is sent back to this page, it allows them to add an additional partner (as in WEX). I have added some functionality in preparation for this (`form.partner_count`)","created_at":"2016-06-13T14:57:53Z","updated_at":"2016-06-14T10:18:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e74db0789f314061e84afe5dd002f09b739f2905","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/pulls/145/commits","review_comments_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/pulls/145/comments","review_comment_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/issues/145/comments","statuses_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/statuses/8fe9ec594af62c292ef747daea61c39170ef297c","head":{"label":"EnvironmentAgency:feature/RIP_89_add_partner_page","ref":"feature/RIP_89_add_partner_page","sha":"8fe9ec594af62c292ef747daea61c39170ef297c","user":{"login":"EnvironmentAgency","id":5528822,"avatar_url":"https://avatars.githubusercontent.com/u/5528822?v=3","gravatar_id":"","url":"https://api.github.com/users/EnvironmentAgency","html_url":"https://github.com/EnvironmentAgency","followers_url":"https://api.github.com/users/EnvironmentAgency/followers","following_url":"https://api.github.com/users/EnvironmentAgency/following{/other_user}","gists_url":"https://api.github.com/users/EnvironmentAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/EnvironmentAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnvironmentAgency/subscriptions","organizations_url":"https://api.github.com/users/EnvironmentAgency/orgs","repos_url":"https://api.github.com/users/EnvironmentAgency/repos","events_url":"https://api.github.com/users/EnvironmentAgency/events{/privacy}","received_events_url":"https://api.github.com/users/EnvironmentAgency/received_events","type":"Organization","site_admin":false},"repo":{"id":55592441,"name":"flood-risk-engine","full_name":"EnvironmentAgency/flood-risk-engine","owner":{"login":"EnvironmentAgency","id":5528822,"avatar_url":"https://avatars.githubusercontent.com/u/5528822?v=3","gravatar_id":"","url":"https://api.github.com/users/EnvironmentAgency","html_url":"https://github.com/EnvironmentAgency","followers_url":"https://api.github.com/users/EnvironmentAgency/followers","following_url":"https://api.github.com/users/EnvironmentAgency/following{/other_user}","gists_url":"https://api.github.com/users/EnvironmentAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/EnvironmentAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnvironmentAgency/subscriptions","organizations_url":"https://api.github.com/users/EnvironmentAgency/orgs","repos_url":"https://api.github.com/users/EnvironmentAgency/repos","events_url":"https://api.github.com/users/EnvironmentAgency/events{/privacy}","received_events_url":"https://api.github.com/users/EnvironmentAgency/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EnvironmentAgency/flood-risk-engine","description":"Core functionality shared between the flood risk front and back office applications","fork":false,"url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine","forks_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/forks","keys_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/teams","hooks_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/hooks","issue_events_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/issues/events{/number}","events_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/events","assignees_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/assignees{/user}","branches_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/branches{/branch}","tags_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/tags","blobs_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/languages","stargazers_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/stargazers","contributors_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/contributors","subscribers_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/subscribers","subscription_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/subscription","commits_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/contents/{+path}","compare_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/merges","archive_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/downloads","issues_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/issues{/number}","pulls_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/labels{/name}","releases_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/releases{/id}","deployments_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/deployments","created_at":"2016-04-06T09:19:14Z","updated_at":"2016-04-06T10:34:56Z","pushed_at":"2016-06-14T10:02:47Z","git_url":"git://github.com/EnvironmentAgency/flood-risk-engine.git","ssh_url":"git@github.com:EnvironmentAgency/flood-risk-engine.git","clone_url":"https://github.com/EnvironmentAgency/flood-risk-engine.git","svn_url":"https://github.com/EnvironmentAgency/flood-risk-engine","homepage":null,"size":750,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":0,"default_branch":"develop"}},"base":{"label":"EnvironmentAgency:develop","ref":"develop","sha":"72de633b5347b0c213ab47c0d2dc997319a4f42d","user":{"login":"EnvironmentAgency","id":5528822,"avatar_url":"https://avatars.githubusercontent.com/u/5528822?v=3","gravatar_id":"","url":"https://api.github.com/users/EnvironmentAgency","html_url":"https://github.com/EnvironmentAgency","followers_url":"https://api.github.com/users/EnvironmentAgency/followers","following_url":"https://api.github.com/users/EnvironmentAgency/following{/other_user}","gists_url":"https://api.github.com/users/EnvironmentAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/EnvironmentAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnvironmentAgency/subscriptions","organizations_url":"https://api.github.com/users/EnvironmentAgency/orgs","repos_url":"https://api.github.com/users/EnvironmentAgency/repos","events_url":"https://api.github.com/users/EnvironmentAgency/events{/privacy}","received_events_url":"https://api.github.com/users/EnvironmentAgency/received_events","type":"Organization","site_admin":false},"repo":{"id":55592441,"name":"flood-risk-engine","full_name":"EnvironmentAgency/flood-risk-engine","owner":{"login":"EnvironmentAgency","id":5528822,"avatar_url":"https://avatars.githubusercontent.com/u/5528822?v=3","gravatar_id":"","url":"https://api.github.com/users/EnvironmentAgency","html_url":"https://github.com/EnvironmentAgency","followers_url":"https://api.github.com/users/EnvironmentAgency/followers","following_url":"https://api.github.com/users/EnvironmentAgency/following{/other_user}","gists_url":"https://api.github.com/users/EnvironmentAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/EnvironmentAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnvironmentAgency/subscriptions","organizations_url":"https://api.github.com/users/EnvironmentAgency/orgs","repos_url":"https://api.github.com/users/EnvironmentAgency/repos","events_url":"https://api.github.com/users/EnvironmentAgency/events{/privacy}","received_events_url":"https://api.github.com/users/EnvironmentAgency/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EnvironmentAgency/flood-risk-engine","description":"Core functionality shared between the flood risk front and back office applications","fork":false,"url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine","forks_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/forks","keys_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/teams","hooks_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/hooks","issue_events_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/issues/events{/number}","events_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/events","assignees_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/assignees{/user}","branches_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/branches{/branch}","tags_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/tags","blobs_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/languages","stargazers_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/stargazers","contributors_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/contributors","subscribers_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/subscribers","subscription_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/subscription","commits_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/contents/{+path}","compare_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/merges","archive_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/downloads","issues_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/issues{/number}","pulls_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/labels{/name}","releases_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/releases{/id}","deployments_url":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/deployments","created_at":"2016-04-06T09:19:14Z","updated_at":"2016-04-06T10:34:56Z","pushed_at":"2016-06-14T10:02:47Z","git_url":"git://github.com/EnvironmentAgency/flood-risk-engine.git","ssh_url":"git@github.com:EnvironmentAgency/flood-risk-engine.git","clone_url":"https://github.com/EnvironmentAgency/flood-risk-engine.git","svn_url":"https://github.com/EnvironmentAgency/flood-risk-engine","homepage":null,"size":750,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/pulls/145"},"html":{"href":"https://github.com/EnvironmentAgency/flood-risk-engine/pull/145"},"issue":{"href":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/issues/145"},"comments":{"href":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/EnvironmentAgency/flood-risk-engine/statuses/8fe9ec594af62c292ef747daea61c39170ef297c"}}}}
{"actor":{"display_login":"autotelik"}}