{"action":"created","comment":{"url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/comments/65601941","id":65601941,"diff_hunk":"@@ -361,9 +361,13 @@ def run_dasdfmt(self, to_format=None):\n                 continue\n \n         # need to make devicetree aware of disk changes\n-        threadMgr.add(AnacondaThread(name=THREAD_STORAGE, target=storageInitialize,\n-                                     args=(self.storage, self.data, self.storage.devicetree.protectedDevNames)))\n-        self._initialize()\n+        self.storage.devicetree.populate()\n+        if not flags.automatedInstall:\n+            # reinit storage\n+            threadMgr.add(AnacondaThread(name=THREAD_STORAGE, target=storageInitialize,\n+                                         args=(self.storage, self.data, self.storage.devicetree.protectedDevNames)))\n+            # update the summary screen with the changes\n+            self._initialize()","path":"pyanaconda/ui/tui/spokes/storage.py","position":26,"original_position":26,"commit_id":"479ac440498d0750335f25be752232d2b4ad0c13","original_commit_id":"479ac440498d0750335f25be752232d2b4ad0c13","user":{"login":"snbueno","id":6331078,"avatar_url":"https://avatars.githubusercontent.com/u/6331078?v=3","gravatar_id":"","url":"https://api.github.com/users/snbueno","html_url":"https://github.com/snbueno","followers_url":"https://api.github.com/users/snbueno/followers","following_url":"https://api.github.com/users/snbueno/following{/other_user}","gists_url":"https://api.github.com/users/snbueno/gists{/gist_id}","starred_url":"https://api.github.com/users/snbueno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snbueno/subscriptions","organizations_url":"https://api.github.com/users/snbueno/orgs","repos_url":"https://api.github.com/users/snbueno/repos","events_url":"https://api.github.com/users/snbueno/events{/privacy}","received_events_url":"https://api.github.com/users/snbueno/received_events","type":"User","site_admin":false},"body":"It's necessary to wait on this thread in manual installations because otherwise the screen won't refresh with the updated config. (Obviously, it's not necessary in ks, since you don't see the storage spoke.)","created_at":"2016-06-02T19:20:57Z","updated_at":"2016-06-02T19:20:57Z","html_url":"https://github.com/rhinstaller/anaconda/pull/637#discussion_r65601941","pull_request_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/637","_links":{"self":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/comments/65601941"},"html":{"href":"https://github.com/rhinstaller/anaconda/pull/637#discussion_r65601941"},"pull_request":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/637"}}},"pull_request":{"url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/637","id":70863351,"html_url":"https://github.com/rhinstaller/anaconda/pull/637","diff_url":"https://github.com/rhinstaller/anaconda/pull/637.diff","patch_url":"https://github.com/rhinstaller/anaconda/pull/637.patch","issue_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/637","number":637,"state":"open","locked":false,"title":"Fix some residual issues of dasdfmt in text-mode. (#1259437)","user":{"login":"snbueno","id":6331078,"avatar_url":"https://avatars.githubusercontent.com/u/6331078?v=3","gravatar_id":"","url":"https://api.github.com/users/snbueno","html_url":"https://github.com/snbueno","followers_url":"https://api.github.com/users/snbueno/followers","following_url":"https://api.github.com/users/snbueno/following{/other_user}","gists_url":"https://api.github.com/users/snbueno/gists{/gist_id}","starred_url":"https://api.github.com/users/snbueno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snbueno/subscriptions","organizations_url":"https://api.github.com/users/snbueno/orgs","repos_url":"https://api.github.com/users/snbueno/repos","events_url":"https://api.github.com/users/snbueno/events{/privacy}","received_events_url":"https://api.github.com/users/snbueno/received_events","type":"User","site_admin":false},"body":"Some of these are dumb errors. For example, need to make sure we pass\r\na list of device names, not device objects, to the methods that determine\r\nwhether a DASD needs to be formatted.\r\n\r\ndevicetree.populate() needs to be called so that the devicetree is\r\nactually made aware of the changes.\r\n\r\nAdditionally, only call storageInitialize and self._initialize() after\r\nall of this is we're doing a manual installation. This makes sure things\r\nlike the summary screen get updated with accurate information about any\r\nnewly-formatted DASDs.\r\n\r\nResolves: rhbz#1259437","created_at":"2016-05-20T14:26:35Z","updated_at":"2016-06-02T19:20:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7f3ad64eed06defd0f352ae851f8fbae693d688","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/637/commits","review_comments_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/637/comments","review_comment_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/637/comments","statuses_url":"https://api.github.com/repos/rhinstaller/anaconda/statuses/479ac440498d0750335f25be752232d2b4ad0c13","head":{"label":"snbueno:1259437","ref":"1259437","sha":"479ac440498d0750335f25be752232d2b4ad0c13","user":{"login":"snbueno","id":6331078,"avatar_url":"https://avatars.githubusercontent.com/u/6331078?v=3","gravatar_id":"","url":"https://api.github.com/users/snbueno","html_url":"https://github.com/snbueno","followers_url":"https://api.github.com/users/snbueno/followers","following_url":"https://api.github.com/users/snbueno/following{/other_user}","gists_url":"https://api.github.com/users/snbueno/gists{/gist_id}","starred_url":"https://api.github.com/users/snbueno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snbueno/subscriptions","organizations_url":"https://api.github.com/users/snbueno/orgs","repos_url":"https://api.github.com/users/snbueno/repos","events_url":"https://api.github.com/users/snbueno/events{/privacy}","received_events_url":"https://api.github.com/users/snbueno/received_events","type":"User","site_admin":false},"repo":{"id":31965619,"name":"anaconda","full_name":"snbueno/anaconda","owner":{"login":"snbueno","id":6331078,"avatar_url":"https://avatars.githubusercontent.com/u/6331078?v=3","gravatar_id":"","url":"https://api.github.com/users/snbueno","html_url":"https://github.com/snbueno","followers_url":"https://api.github.com/users/snbueno/followers","following_url":"https://api.github.com/users/snbueno/following{/other_user}","gists_url":"https://api.github.com/users/snbueno/gists{/gist_id}","starred_url":"https://api.github.com/users/snbueno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snbueno/subscriptions","organizations_url":"https://api.github.com/users/snbueno/orgs","repos_url":"https://api.github.com/users/snbueno/repos","events_url":"https://api.github.com/users/snbueno/events{/privacy}","received_events_url":"https://api.github.com/users/snbueno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/snbueno/anaconda","description":"Graphical system installer","fork":true,"url":"https://api.github.com/repos/snbueno/anaconda","forks_url":"https://api.github.com/repos/snbueno/anaconda/forks","keys_url":"https://api.github.com/repos/snbueno/anaconda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snbueno/anaconda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snbueno/anaconda/teams","hooks_url":"https://api.github.com/repos/snbueno/anaconda/hooks","issue_events_url":"https://api.github.com/repos/snbueno/anaconda/issues/events{/number}","events_url":"https://api.github.com/repos/snbueno/anaconda/events","assignees_url":"https://api.github.com/repos/snbueno/anaconda/assignees{/user}","branches_url":"https://api.github.com/repos/snbueno/anaconda/branches{/branch}","tags_url":"https://api.github.com/repos/snbueno/anaconda/tags","blobs_url":"https://api.github.com/repos/snbueno/anaconda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snbueno/anaconda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snbueno/anaconda/git/refs{/sha}","trees_url":"https://api.github.com/repos/snbueno/anaconda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snbueno/anaconda/statuses/{sha}","languages_url":"https://api.github.com/repos/snbueno/anaconda/languages","stargazers_url":"https://api.github.com/repos/snbueno/anaconda/stargazers","contributors_url":"https://api.github.com/repos/snbueno/anaconda/contributors","subscribers_url":"https://api.github.com/repos/snbueno/anaconda/subscribers","subscription_url":"https://api.github.com/repos/snbueno/anaconda/subscription","commits_url":"https://api.github.com/repos/snbueno/anaconda/commits{/sha}","git_commits_url":"https://api.github.com/repos/snbueno/anaconda/git/commits{/sha}","comments_url":"https://api.github.com/repos/snbueno/anaconda/comments{/number}","issue_comment_url":"https://api.github.com/repos/snbueno/anaconda/issues/comments{/number}","contents_url":"https://api.github.com/repos/snbueno/anaconda/contents/{+path}","compare_url":"https://api.github.com/repos/snbueno/anaconda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snbueno/anaconda/merges","archive_url":"https://api.github.com/repos/snbueno/anaconda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snbueno/anaconda/downloads","issues_url":"https://api.github.com/repos/snbueno/anaconda/issues{/number}","pulls_url":"https://api.github.com/repos/snbueno/anaconda/pulls{/number}","milestones_url":"https://api.github.com/repos/snbueno/anaconda/milestones{/number}","notifications_url":"https://api.github.com/repos/snbueno/anaconda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snbueno/anaconda/labels{/name}","releases_url":"https://api.github.com/repos/snbueno/anaconda/releases{/id}","deployments_url":"https://api.github.com/repos/snbueno/anaconda/deployments","created_at":"2015-03-10T15:37:00Z","updated_at":"2015-03-10T15:37:03Z","pushed_at":"2016-05-20T14:54:34Z","git_url":"git://github.com/snbueno/anaconda.git","ssh_url":"git@github.com:snbueno/anaconda.git","clone_url":"https://github.com/snbueno/anaconda.git","svn_url":"https://github.com/snbueno/anaconda","homepage":null,"size":123658,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rhinstaller:rhel7-branch","ref":"rhel7-branch","sha":"3e450833a9ba4dfccf5fd3adf7cf315d9a1f4090","user":{"login":"rhinstaller","id":10549274,"avatar_url":"https://avatars.githubusercontent.com/u/10549274?v=3","gravatar_id":"","url":"https://api.github.com/users/rhinstaller","html_url":"https://github.com/rhinstaller","followers_url":"https://api.github.com/users/rhinstaller/followers","following_url":"https://api.github.com/users/rhinstaller/following{/other_user}","gists_url":"https://api.github.com/users/rhinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinstaller/subscriptions","organizations_url":"https://api.github.com/users/rhinstaller/orgs","repos_url":"https://api.github.com/users/rhinstaller/repos","events_url":"https://api.github.com/users/rhinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/rhinstaller/received_events","type":"Organization","site_admin":false},"repo":{"id":30210846,"name":"anaconda","full_name":"rhinstaller/anaconda","owner":{"login":"rhinstaller","id":10549274,"avatar_url":"https://avatars.githubusercontent.com/u/10549274?v=3","gravatar_id":"","url":"https://api.github.com/users/rhinstaller","html_url":"https://github.com/rhinstaller","followers_url":"https://api.github.com/users/rhinstaller/followers","following_url":"https://api.github.com/users/rhinstaller/following{/other_user}","gists_url":"https://api.github.com/users/rhinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinstaller/subscriptions","organizations_url":"https://api.github.com/users/rhinstaller/orgs","repos_url":"https://api.github.com/users/rhinstaller/repos","events_url":"https://api.github.com/users/rhinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/rhinstaller/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rhinstaller/anaconda","description":"Graphical system installer","fork":false,"url":"https://api.github.com/repos/rhinstaller/anaconda","forks_url":"https://api.github.com/repos/rhinstaller/anaconda/forks","keys_url":"https://api.github.com/repos/rhinstaller/anaconda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhinstaller/anaconda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhinstaller/anaconda/teams","hooks_url":"https://api.github.com/repos/rhinstaller/anaconda/hooks","issue_events_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/events{/number}","events_url":"https://api.github.com/repos/rhinstaller/anaconda/events","assignees_url":"https://api.github.com/repos/rhinstaller/anaconda/assignees{/user}","branches_url":"https://api.github.com/repos/rhinstaller/anaconda/branches{/branch}","tags_url":"https://api.github.com/repos/rhinstaller/anaconda/tags","blobs_url":"https://api.github.com/repos/rhinstaller/anaconda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhinstaller/anaconda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhinstaller/anaconda/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhinstaller/anaconda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhinstaller/anaconda/statuses/{sha}","languages_url":"https://api.github.com/repos/rhinstaller/anaconda/languages","stargazers_url":"https://api.github.com/repos/rhinstaller/anaconda/stargazers","contributors_url":"https://api.github.com/repos/rhinstaller/anaconda/contributors","subscribers_url":"https://api.github.com/repos/rhinstaller/anaconda/subscribers","subscription_url":"https://api.github.com/repos/rhinstaller/anaconda/subscription","commits_url":"https://api.github.com/repos/rhinstaller/anaconda/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhinstaller/anaconda/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhinstaller/anaconda/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhinstaller/anaconda/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhinstaller/anaconda/contents/{+path}","compare_url":"https://api.github.com/repos/rhinstaller/anaconda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhinstaller/anaconda/merges","archive_url":"https://api.github.com/repos/rhinstaller/anaconda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhinstaller/anaconda/downloads","issues_url":"https://api.github.com/repos/rhinstaller/anaconda/issues{/number}","pulls_url":"https://api.github.com/repos/rhinstaller/anaconda/pulls{/number}","milestones_url":"https://api.github.com/repos/rhinstaller/anaconda/milestones{/number}","notifications_url":"https://api.github.com/repos/rhinstaller/anaconda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhinstaller/anaconda/labels{/name}","releases_url":"https://api.github.com/repos/rhinstaller/anaconda/releases{/id}","deployments_url":"https://api.github.com/repos/rhinstaller/anaconda/deployments","created_at":"2015-02-02T21:56:45Z","updated_at":"2016-06-01T13:10:28Z","pushed_at":"2016-06-02T19:04:27Z","git_url":"git://github.com/rhinstaller/anaconda.git","ssh_url":"git@github.com:rhinstaller/anaconda.git","clone_url":"https://github.com/rhinstaller/anaconda.git","svn_url":"https://github.com/rhinstaller/anaconda","homepage":null,"size":192412,"stargazers_count":52,"watchers_count":52,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":66,"mirror_url":null,"open_issues_count":30,"forks":66,"open_issues":30,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/637"},"html":{"href":"https://github.com/rhinstaller/anaconda/pull/637"},"issue":{"href":"https://api.github.com/repos/rhinstaller/anaconda/issues/637"},"comments":{"href":"https://api.github.com/repos/rhinstaller/anaconda/issues/637/comments"},"review_comments":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/637/comments"},"review_comment":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rhinstaller/anaconda/pulls/637/commits"},"statuses":{"href":"https://api.github.com/repos/rhinstaller/anaconda/statuses/479ac440498d0750335f25be752232d2b4ad0c13"}}}}
{"actor":{"display_login":"snbueno"}}