{"action":"created","issue":{"url":"https://api.github.com/repos/hypothesis/h/issues/4012","repository_url":"https://api.github.com/repos/hypothesis/h","labels_url":"https://api.github.com/repos/hypothesis/h/issues/4012/labels{/name}","comments_url":"https://api.github.com/repos/hypothesis/h/issues/4012/comments","events_url":"https://api.github.com/repos/hypothesis/h/issues/4012/events","html_url":"https://github.com/hypothesis/h/pull/4012","id":186012411,"number":4012,"title":"Improve the group invite link field","user":{"login":"seanh","id":22498,"avatar_url":"https://avatars.githubusercontent.com/u/22498?v=3","gravatar_id":"","url":"https://api.github.com/users/seanh","html_url":"https://github.com/seanh","followers_url":"https://api.github.com/users/seanh/followers","following_url":"https://api.github.com/users/seanh/following{/other_user}","gists_url":"https://api.github.com/users/seanh/gists{/gist_id}","starred_url":"https://api.github.com/users/seanh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanh/subscriptions","organizations_url":"https://api.github.com/users/seanh/orgs","repos_url":"https://api.github.com/users/seanh/repos","events_url":"https://api.github.com/users/seanh/events{/privacy}","received_events_url":"https://api.github.com/users/seanh/received_events","type":"User","site_admin":false},"labels":[{"id":427068869,"url":"https://api.github.com/repos/hypothesis/h/labels/Feature:%20Activity%20Pages","name":"Feature: Activity Pages","color":"5319e7","default":false},{"id":460185446,"url":"https://api.github.com/repos/hypothesis/h/labels/Needs%20Review","name":"Needs Review","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-28T20:19:06Z","updated_at":"2016-10-28T20:23:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hypothesis/h/pulls/4012","html_url":"https://github.com/hypothesis/h/pull/4012","diff_url":"https://github.com/hypothesis/h/pull/4012.diff","patch_url":"https://github.com/hypothesis/h/pull/4012.patch"},"body":"Some improvements to the group invite field on the group page. This is the old group page (`/groups/abcxyz/my-group`), but the same group invite field is needed on the new group sidebar, and I intend to component-ize and reuse this code.\r\n\r\nChanges:\r\n\r\n* Text tweak\r\n\r\n* Twitter, Facebook etc buttons removed\r\n\r\n* The link text is now read-only so you can't edit it!\r\n\r\n* Text is autoselected when you click on it:\r\n\r\n   ![autoselect](https://cloud.githubusercontent.com/assets/22498/19820827/069ba814-9d53-11e6-89e5-d71a7ec1eda5.gif)\r\n\r\n* Added a clipboard icon which copies the text when clicked:\r\n\r\n   ![copy](https://cloud.githubusercontent.com/assets/22498/19820841/16b3ab52-9d53-11e6-9746-98929d302d6c.gif)\r\n\r\n   GitHub uses a tooltip to show the _copied_ notification:\r\n\r\n   ![github](https://cloud.githubusercontent.com/assets/22498/19820938/98f53f04-9d53-11e6-9c49-454495b0418d.gif)\r\n\r\n   Unfortunately our own implementation of these kind of JavaScript tooltips is buggy and couldn't be used for this. I didn't want to have to go and fix that problem now, so I went for the different approach to success notification above.\r\n\r\n   Note that the GitHub button also \"looks clicky\" when you click it, ours doesn't. Maybe we can fix that.\r\n\r\n   This shouldn't happen, but if for some reason the copy fails (`document.execCommand('copy')` returns `false`):\r\n\r\n   ![copyfail](https://cloud.githubusercontent.com/assets/22498/19820855/2afcbcf2-9d53-11e6-9630-953a97b3f0c2.gif)\r\n\r\n   I haven't dealt with cases where `document.execCommand` doesn't exist.\r\n\r\n* If JavaScript isn't available there's no copy button:\r\n\r\n   ![nojs](https://cloud.githubusercontent.com/assets/22498/19820884/4ad9aae4-9d53-11e6-8f60-a7d11bc6717f.png)\r\n\r\n   (the autoselect doesn't work either)\r\n\r\n* The click target size of the copy button is as big as its corner of the input field, you don't actually have to click on the (small) icon:\r\n\r\n   ![screenshot from 2016-10-28 21-07-58](https://cloud.githubusercontent.com/assets/22498/19820902/60a89aa6-9d53-11e6-93f6-41b0ed341e2f.png)\r\n"},"comment":{"url":"https://api.github.com/repos/hypothesis/h/issues/comments/257019136","html_url":"https://github.com/hypothesis/h/pull/4012#issuecomment-257019136","issue_url":"https://api.github.com/repos/hypothesis/h/issues/4012","id":257019136,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2016-10-28T20:23:08Z","updated_at":"2016-10-28T20:23:08Z","body":"## [Current coverage](https://codecov.io/gh/hypothesis/h/pull/4012?src=pr) is 81.75% (diff: 100%)\n> Merging [#4012](https://codecov.io/gh/hypothesis/h/pull/4012?src=pr) into [master](https://codecov.io/gh/hypothesis/h/branch/master?src=pr) will not change coverage\n\n```diff\n@@             master      #4012   diff @@\n==========================================\n  Files           157        157          \n  Lines          5874       5874          \n  Methods           0          0          \n  Messages          0          0          \n  Branches        660        660          \n==========================================\n  Hits           4802       4802          \n+ Misses         1003       1001     -2   \n- Partials         69         71     +2   \n```\n\n> Powered by [Codecov](https://codecov.io?src=pr). Last update [56c20b9...ea8c258](https://codecov.io/gh/hypothesis/h/compare/56c20b9a5f4b1a658578d8e2f63fa8176d11f066...ea8c25809354ca143fc3168cd2192f8858b98eab?src=pr)"}}
{"actor":{"display_login":"codecov-io"}}