{"action":"opened","number":654,"pull_request":{"url":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls/654","id":92451629,"html_url":"https://github.com/benmosher/eslint-plugin-import/pull/654","diff_url":"https://github.com/benmosher/eslint-plugin-import/pull/654.diff","patch_url":"https://github.com/benmosher/eslint-plugin-import/pull/654.patch","issue_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/issues/654","number":654,"state":"open","locked":false,"title":"fix unambiguous regex","user":{"login":"benmosher","id":3709196,"avatar_url":"https://avatars.githubusercontent.com/u/3709196?v=3","gravatar_id":"","url":"https://api.github.com/users/benmosher","html_url":"https://github.com/benmosher","followers_url":"https://api.github.com/users/benmosher/followers","following_url":"https://api.github.com/users/benmosher/following{/other_user}","gists_url":"https://api.github.com/users/benmosher/gists{/gist_id}","starred_url":"https://api.github.com/users/benmosher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benmosher/subscriptions","organizations_url":"https://api.github.com/users/benmosher/orgs","repos_url":"https://api.github.com/users/benmosher/repos","events_url":"https://api.github.com/users/benmosher/events{/privacy}","received_events_url":"https://api.github.com/users/benmosher/received_events","type":"User","site_admin":false},"body":"Key notes:\r\n- used a `&&` instead of `||` for the auto-ignore (fail) so it wasn't even used unless the file is ignored anyway, and then it would ignore the ignore if the regex passed\r\n- did not set regex to `multiline` mode, so it would fail on files unless `import`/`export` is the first line (double fail)\r\n\r\nI also had to comment out a parser error test for CoffeeScript that should never have passed in v2 if I had implemented this correctly to begin with.\r\n\r\nTo publish this, need to bump+publish `eslint-module-utils`, then bump the dep in the plugin and publish it too.\r\n\r\nI'm thinking this should be semver-minor since it's a large enough fix that it's nearly a feature.\r\n\r\nTechnically a breaking change to `eslint-module-utils`, but that's [not a big deal](https://www.npmjs.com/browse/depended/eslint-module-utils).\r\n\r\nfixes #615\r\nfixes #634\r\nfixes #649","created_at":"2016-11-05T12:14:46Z","updated_at":"2016-11-05T12:14:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls/654/commits","review_comments_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls/654/comments","review_comment_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls/comments{/number}","comments_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/issues/654/comments","statuses_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/statuses/b35d4897103c7d0ee1340879c47905cfd1fcf62d","head":{"label":"benmosher:fix-unambiguous-regex","ref":"fix-unambiguous-regex","sha":"b35d4897103c7d0ee1340879c47905cfd1fcf62d","user":{"login":"benmosher","id":3709196,"avatar_url":"https://avatars.githubusercontent.com/u/3709196?v=3","gravatar_id":"","url":"https://api.github.com/users/benmosher","html_url":"https://github.com/benmosher","followers_url":"https://api.github.com/users/benmosher/followers","following_url":"https://api.github.com/users/benmosher/following{/other_user}","gists_url":"https://api.github.com/users/benmosher/gists{/gist_id}","starred_url":"https://api.github.com/users/benmosher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benmosher/subscriptions","organizations_url":"https://api.github.com/users/benmosher/orgs","repos_url":"https://api.github.com/users/benmosher/repos","events_url":"https://api.github.com/users/benmosher/events{/privacy}","received_events_url":"https://api.github.com/users/benmosher/received_events","type":"User","site_admin":false},"repo":{"id":32238354,"name":"eslint-plugin-import","full_name":"benmosher/eslint-plugin-import","owner":{"login":"benmosher","id":3709196,"avatar_url":"https://avatars.githubusercontent.com/u/3709196?v=3","gravatar_id":"","url":"https://api.github.com/users/benmosher","html_url":"https://github.com/benmosher","followers_url":"https://api.github.com/users/benmosher/followers","following_url":"https://api.github.com/users/benmosher/following{/other_user}","gists_url":"https://api.github.com/users/benmosher/gists{/gist_id}","starred_url":"https://api.github.com/users/benmosher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benmosher/subscriptions","organizations_url":"https://api.github.com/users/benmosher/orgs","repos_url":"https://api.github.com/users/benmosher/repos","events_url":"https://api.github.com/users/benmosher/events{/privacy}","received_events_url":"https://api.github.com/users/benmosher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benmosher/eslint-plugin-import","description":"ESLint plugin with rules that help validate proper imports.","fork":false,"url":"https://api.github.com/repos/benmosher/eslint-plugin-import","forks_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/forks","keys_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/teams","hooks_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/hooks","issue_events_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/issues/events{/number}","events_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/events","assignees_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/assignees{/user}","branches_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/branches{/branch}","tags_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/tags","blobs_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/git/refs{/sha}","trees_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/statuses/{sha}","languages_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/languages","stargazers_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/stargazers","contributors_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/contributors","subscribers_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/subscribers","subscription_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/subscription","commits_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/commits{/sha}","git_commits_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/git/commits{/sha}","comments_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/comments{/number}","issue_comment_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/issues/comments{/number}","contents_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/contents/{+path}","compare_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/merges","archive_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/downloads","issues_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/issues{/number}","pulls_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls{/number}","milestones_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/milestones{/number}","notifications_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/labels{/name}","releases_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/releases{/id}","deployments_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/deployments","created_at":"2015-03-15T00:21:57Z","updated_at":"2016-11-04T15:34:28Z","pushed_at":"2016-11-05T12:14:46Z","git_url":"git://github.com/benmosher/eslint-plugin-import.git","ssh_url":"git@github.com:benmosher/eslint-plugin-import.git","clone_url":"https://github.com/benmosher/eslint-plugin-import.git","svn_url":"https://github.com/benmosher/eslint-plugin-import","homepage":null,"size":1298,"stargazers_count":492,"watchers_count":492,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":126,"mirror_url":null,"open_issues_count":84,"forks":126,"open_issues":84,"watchers":492,"default_branch":"master"}},"base":{"label":"benmosher:master","ref":"master","sha":"4744468fff86a8fbb1d8cc466578cfbb1fbadc34","user":{"login":"benmosher","id":3709196,"avatar_url":"https://avatars.githubusercontent.com/u/3709196?v=3","gravatar_id":"","url":"https://api.github.com/users/benmosher","html_url":"https://github.com/benmosher","followers_url":"https://api.github.com/users/benmosher/followers","following_url":"https://api.github.com/users/benmosher/following{/other_user}","gists_url":"https://api.github.com/users/benmosher/gists{/gist_id}","starred_url":"https://api.github.com/users/benmosher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benmosher/subscriptions","organizations_url":"https://api.github.com/users/benmosher/orgs","repos_url":"https://api.github.com/users/benmosher/repos","events_url":"https://api.github.com/users/benmosher/events{/privacy}","received_events_url":"https://api.github.com/users/benmosher/received_events","type":"User","site_admin":false},"repo":{"id":32238354,"name":"eslint-plugin-import","full_name":"benmosher/eslint-plugin-import","owner":{"login":"benmosher","id":3709196,"avatar_url":"https://avatars.githubusercontent.com/u/3709196?v=3","gravatar_id":"","url":"https://api.github.com/users/benmosher","html_url":"https://github.com/benmosher","followers_url":"https://api.github.com/users/benmosher/followers","following_url":"https://api.github.com/users/benmosher/following{/other_user}","gists_url":"https://api.github.com/users/benmosher/gists{/gist_id}","starred_url":"https://api.github.com/users/benmosher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benmosher/subscriptions","organizations_url":"https://api.github.com/users/benmosher/orgs","repos_url":"https://api.github.com/users/benmosher/repos","events_url":"https://api.github.com/users/benmosher/events{/privacy}","received_events_url":"https://api.github.com/users/benmosher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benmosher/eslint-plugin-import","description":"ESLint plugin with rules that help validate proper imports.","fork":false,"url":"https://api.github.com/repos/benmosher/eslint-plugin-import","forks_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/forks","keys_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/teams","hooks_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/hooks","issue_events_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/issues/events{/number}","events_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/events","assignees_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/assignees{/user}","branches_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/branches{/branch}","tags_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/tags","blobs_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/git/refs{/sha}","trees_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/statuses/{sha}","languages_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/languages","stargazers_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/stargazers","contributors_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/contributors","subscribers_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/subscribers","subscription_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/subscription","commits_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/commits{/sha}","git_commits_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/git/commits{/sha}","comments_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/comments{/number}","issue_comment_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/issues/comments{/number}","contents_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/contents/{+path}","compare_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/merges","archive_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/downloads","issues_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/issues{/number}","pulls_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls{/number}","milestones_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/milestones{/number}","notifications_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/labels{/name}","releases_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/releases{/id}","deployments_url":"https://api.github.com/repos/benmosher/eslint-plugin-import/deployments","created_at":"2015-03-15T00:21:57Z","updated_at":"2016-11-04T15:34:28Z","pushed_at":"2016-11-05T12:14:46Z","git_url":"git://github.com/benmosher/eslint-plugin-import.git","ssh_url":"git@github.com:benmosher/eslint-plugin-import.git","clone_url":"https://github.com/benmosher/eslint-plugin-import.git","svn_url":"https://github.com/benmosher/eslint-plugin-import","homepage":null,"size":1298,"stargazers_count":492,"watchers_count":492,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":126,"mirror_url":null,"open_issues_count":84,"forks":126,"open_issues":84,"watchers":492,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls/654"},"html":{"href":"https://github.com/benmosher/eslint-plugin-import/pull/654"},"issue":{"href":"https://api.github.com/repos/benmosher/eslint-plugin-import/issues/654"},"comments":{"href":"https://api.github.com/repos/benmosher/eslint-plugin-import/issues/654/comments"},"review_comments":{"href":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls/654/comments"},"review_comment":{"href":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/benmosher/eslint-plugin-import/pulls/654/commits"},"statuses":{"href":"https://api.github.com/repos/benmosher/eslint-plugin-import/statuses/b35d4897103c7d0ee1340879c47905cfd1fcf62d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":37,"deletions":13,"changed_files":5}}
{"actor":{"display_login":"benmosher"}}