{"action":"created","issue":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/977","repository_url":"https://api.github.com/repos/triplea-game/triplea","labels_url":"https://api.github.com/repos/triplea-game/triplea/issues/977/labels{/name}","comments_url":"https://api.github.com/repos/triplea-game/triplea/issues/977/comments","events_url":"https://api.github.com/repos/triplea-game/triplea/issues/977/events","html_url":"https://github.com/triplea-game/triplea/pull/977","id":165989878,"number":977,"title":"Remove unnecessary lock around gameData when getting technology front…","user":{"login":"DanVanAtta","id":12397753,"avatar_url":"https://avatars.githubusercontent.com/u/12397753?v=3","gravatar_id":"","url":"https://api.github.com/users/DanVanAtta","html_url":"https://github.com/DanVanAtta","followers_url":"https://api.github.com/users/DanVanAtta/followers","following_url":"https://api.github.com/users/DanVanAtta/following{/other_user}","gists_url":"https://api.github.com/users/DanVanAtta/gists{/gist_id}","starred_url":"https://api.github.com/users/DanVanAtta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanVanAtta/subscriptions","organizations_url":"https://api.github.com/users/DanVanAtta/orgs","repos_url":"https://api.github.com/users/DanVanAtta/repos","events_url":"https://api.github.com/users/DanVanAtta/events{/privacy}","received_events_url":"https://api.github.com/users/DanVanAtta/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/triplea-game/triplea/labels/Include%20with%201.9%20release","name":"Include with 1.9 release","color":"0e8a16"}],"state":"open","locked":false,"assignee":{"login":"ron-murhammer","id":1427689,"avatar_url":"https://avatars.githubusercontent.com/u/1427689?v=3","gravatar_id":"","url":"https://api.github.com/users/ron-murhammer","html_url":"https://github.com/ron-murhammer","followers_url":"https://api.github.com/users/ron-murhammer/followers","following_url":"https://api.github.com/users/ron-murhammer/following{/other_user}","gists_url":"https://api.github.com/users/ron-murhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/ron-murhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ron-murhammer/subscriptions","organizations_url":"https://api.github.com/users/ron-murhammer/orgs","repos_url":"https://api.github.com/users/ron-murhammer/repos","events_url":"https://api.github.com/users/ron-murhammer/events{/privacy}","received_events_url":"https://api.github.com/users/ron-murhammer/received_events","type":"User","site_admin":false},"assignees":[{"login":"ron-murhammer","id":1427689,"avatar_url":"https://avatars.githubusercontent.com/u/1427689?v=3","gravatar_id":"","url":"https://api.github.com/users/ron-murhammer","html_url":"https://github.com/ron-murhammer","followers_url":"https://api.github.com/users/ron-murhammer/followers","following_url":"https://api.github.com/users/ron-murhammer/following{/other_user}","gists_url":"https://api.github.com/users/ron-murhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/ron-murhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ron-murhammer/subscriptions","organizations_url":"https://api.github.com/users/ron-murhammer/orgs","repos_url":"https://api.github.com/users/ron-murhammer/repos","events_url":"https://api.github.com/users/ron-murhammer/events{/privacy}","received_events_url":"https://api.github.com/users/ron-murhammer/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2016-07-17T18:49:55Z","updated_at":"2016-07-25T22:30:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/977","html_url":"https://github.com/triplea-game/triplea/pull/977","diff_url":"https://github.com/triplea-game/triplea/pull/977.diff","patch_url":"https://github.com/triplea-game/triplea/pull/977.patch"},"body":"…ier. The locking throws a lock exception when getting a screenshot, but has no impact.\r\n\r\nPlus, remove a couple of empty javadocs and commented out code. #952\r\n\r\nFixes\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/triplea-game/triplea/977)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/comments/235106147","html_url":"https://github.com/triplea-game/triplea/pull/977#issuecomment-235106147","issue_url":"https://api.github.com/repos/triplea-game/triplea/issues/977","id":235106147,"user":{"login":"ron-murhammer","id":1427689,"avatar_url":"https://avatars.githubusercontent.com/u/1427689?v=3","gravatar_id":"","url":"https://api.github.com/users/ron-murhammer","html_url":"https://github.com/ron-murhammer","followers_url":"https://api.github.com/users/ron-murhammer/followers","following_url":"https://api.github.com/users/ron-murhammer/following{/other_user}","gists_url":"https://api.github.com/users/ron-murhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/ron-murhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ron-murhammer/subscriptions","organizations_url":"https://api.github.com/users/ron-murhammer/orgs","repos_url":"https://api.github.com/users/ron-murhammer/repos","events_url":"https://api.github.com/users/ron-murhammer/events{/privacy}","received_events_url":"https://api.github.com/users/ron-murhammer/received_events","type":"User","site_admin":false},"created_at":"2016-07-25T22:30:04Z","updated_at":"2016-07-25T22:30:04Z","body":"@DanVanAtta Alright, I don't particularly like the change but agree the locking is inconsistent and probably in many cases unnecessary. Just concerned about changing things like this as there is lots of indirection and hard to follow code and I'm guessing some of the locking is needed. I also don't like that it works in 1.9 and somehow was broken since then. Since it is a pretty simple function of export a screenshot, you'd think we should have some sort of unit test so we would have realized when it broke."}}
{"actor":{"display_login":"ron-murhammer"}}