{"action":"opened","number":903,"pull_request":{"url":"https://api.github.com/repos/awesomeWM/awesome/pulls/903","id":70090552,"html_url":"https://github.com/awesomeWM/awesome/pull/903","diff_url":"https://github.com/awesomeWM/awesome/pull/903.diff","patch_url":"https://github.com/awesomeWM/awesome/pull/903.patch","issue_url":"https://api.github.com/repos/awesomeWM/awesome/issues/903","number":903,"state":"open","locked":false,"title":"Fix fallback for the window type","user":{"login":"psychon","id":89482,"avatar_url":"https://avatars.githubusercontent.com/u/89482?v=3","gravatar_id":"","url":"https://api.github.com/users/psychon","html_url":"https://github.com/psychon","followers_url":"https://api.github.com/users/psychon/followers","following_url":"https://api.github.com/users/psychon/following{/other_user}","gists_url":"https://api.github.com/users/psychon/gists{/gist_id}","starred_url":"https://api.github.com/users/psychon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychon/subscriptions","organizations_url":"https://api.github.com/users/psychon/orgs","repos_url":"https://api.github.com/users/psychon/repos","events_url":"https://api.github.com/users/psychon/events{/privacy}","received_events_url":"https://api.github.com/users/psychon/received_events","type":"User","site_admin":false},"body":"EWMH specifies that\r\n\r\n   If _NET_WM_WINDOW_TYPE is not set, then managed windows with WM_TRANSIENT_FOR\r\n   set MUST be taken as [_NET_WM_WINDOW_TYPE_DIALOG].\r\n\r\nWe implement this by forcing a window's type to be \"dialog\" when it has a\r\nWM_TRANSIENT_FOR property. For windows that have a _NET_WM_WINDOW_TYPE property,\r\nthis type change is then later undone. However, when a window changes its\r\nWM_TRANSIENT_FOR property during runtime, then we would set its type to \"dialog\"\r\nunconditionally.\r\n\r\nThis commit fixes this by explicitly tracking if we found a _NET_WM_WINDOW_TYPE\r\nproperty on the window and only applying the fallback if we did not find such a\r\nproperty.\r\n\r\nFixes-one-of-the-sub-issues-from: https://github.com/awesomeWM/awesome/issues/889\r\nSigned-off-by: Uli Schlachter <psychon@znc.in>","created_at":"2016-05-14T12:15:30Z","updated_at":"2016-05-14T12:15:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/903/commits","review_comments_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/903/comments","review_comment_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awesomeWM/awesome/issues/903/comments","statuses_url":"https://api.github.com/repos/awesomeWM/awesome/statuses/cbdf40363781ebfe1d2a0e453d363c7ccd269612","head":{"label":"psychon:fix_window_type_fallback","ref":"fix_window_type_fallback","sha":"cbdf40363781ebfe1d2a0e453d363c7ccd269612","user":{"login":"psychon","id":89482,"avatar_url":"https://avatars.githubusercontent.com/u/89482?v=3","gravatar_id":"","url":"https://api.github.com/users/psychon","html_url":"https://github.com/psychon","followers_url":"https://api.github.com/users/psychon/followers","following_url":"https://api.github.com/users/psychon/following{/other_user}","gists_url":"https://api.github.com/users/psychon/gists{/gist_id}","starred_url":"https://api.github.com/users/psychon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychon/subscriptions","organizations_url":"https://api.github.com/users/psychon/orgs","repos_url":"https://api.github.com/users/psychon/repos","events_url":"https://api.github.com/users/psychon/events{/privacy}","received_events_url":"https://api.github.com/users/psychon/received_events","type":"User","site_admin":false},"repo":{"id":28717216,"name":"awesome","full_name":"psychon/awesome","owner":{"login":"psychon","id":89482,"avatar_url":"https://avatars.githubusercontent.com/u/89482?v=3","gravatar_id":"","url":"https://api.github.com/users/psychon","html_url":"https://github.com/psychon","followers_url":"https://api.github.com/users/psychon/followers","following_url":"https://api.github.com/users/psychon/following{/other_user}","gists_url":"https://api.github.com/users/psychon/gists{/gist_id}","starred_url":"https://api.github.com/users/psychon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psychon/subscriptions","organizations_url":"https://api.github.com/users/psychon/orgs","repos_url":"https://api.github.com/users/psychon/repos","events_url":"https://api.github.com/users/psychon/events{/privacy}","received_events_url":"https://api.github.com/users/psychon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/psychon/awesome","description":"awesome window manager","fork":true,"url":"https://api.github.com/repos/psychon/awesome","forks_url":"https://api.github.com/repos/psychon/awesome/forks","keys_url":"https://api.github.com/repos/psychon/awesome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psychon/awesome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psychon/awesome/teams","hooks_url":"https://api.github.com/repos/psychon/awesome/hooks","issue_events_url":"https://api.github.com/repos/psychon/awesome/issues/events{/number}","events_url":"https://api.github.com/repos/psychon/awesome/events","assignees_url":"https://api.github.com/repos/psychon/awesome/assignees{/user}","branches_url":"https://api.github.com/repos/psychon/awesome/branches{/branch}","tags_url":"https://api.github.com/repos/psychon/awesome/tags","blobs_url":"https://api.github.com/repos/psychon/awesome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psychon/awesome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psychon/awesome/git/refs{/sha}","trees_url":"https://api.github.com/repos/psychon/awesome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psychon/awesome/statuses/{sha}","languages_url":"https://api.github.com/repos/psychon/awesome/languages","stargazers_url":"https://api.github.com/repos/psychon/awesome/stargazers","contributors_url":"https://api.github.com/repos/psychon/awesome/contributors","subscribers_url":"https://api.github.com/repos/psychon/awesome/subscribers","subscription_url":"https://api.github.com/repos/psychon/awesome/subscription","commits_url":"https://api.github.com/repos/psychon/awesome/commits{/sha}","git_commits_url":"https://api.github.com/repos/psychon/awesome/git/commits{/sha}","comments_url":"https://api.github.com/repos/psychon/awesome/comments{/number}","issue_comment_url":"https://api.github.com/repos/psychon/awesome/issues/comments{/number}","contents_url":"https://api.github.com/repos/psychon/awesome/contents/{+path}","compare_url":"https://api.github.com/repos/psychon/awesome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psychon/awesome/merges","archive_url":"https://api.github.com/repos/psychon/awesome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psychon/awesome/downloads","issues_url":"https://api.github.com/repos/psychon/awesome/issues{/number}","pulls_url":"https://api.github.com/repos/psychon/awesome/pulls{/number}","milestones_url":"https://api.github.com/repos/psychon/awesome/milestones{/number}","notifications_url":"https://api.github.com/repos/psychon/awesome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psychon/awesome/labels{/name}","releases_url":"https://api.github.com/repos/psychon/awesome/releases{/id}","deployments_url":"https://api.github.com/repos/psychon/awesome/deployments","created_at":"2015-01-02T15:31:52Z","updated_at":"2016-01-17T13:28:29Z","pushed_at":"2016-05-14T12:15:23Z","git_url":"git://github.com/psychon/awesome.git","ssh_url":"git@github.com:psychon/awesome.git","clone_url":"https://github.com/psychon/awesome.git","svn_url":"https://github.com/psychon/awesome","homepage":"https://awesome.naquadah.org/","size":11497,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awesomeWM:master","ref":"master","sha":"63dad3f8ae1ed12d0b1b6035a96b921d78f8c70a","user":{"login":"awesomeWM","id":6843364,"avatar_url":"https://avatars.githubusercontent.com/u/6843364?v=3","gravatar_id":"","url":"https://api.github.com/users/awesomeWM","html_url":"https://github.com/awesomeWM","followers_url":"https://api.github.com/users/awesomeWM/followers","following_url":"https://api.github.com/users/awesomeWM/following{/other_user}","gists_url":"https://api.github.com/users/awesomeWM/gists{/gist_id}","starred_url":"https://api.github.com/users/awesomeWM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesomeWM/subscriptions","organizations_url":"https://api.github.com/users/awesomeWM/orgs","repos_url":"https://api.github.com/users/awesomeWM/repos","events_url":"https://api.github.com/users/awesomeWM/events{/privacy}","received_events_url":"https://api.github.com/users/awesomeWM/received_events","type":"Organization","site_admin":false},"repo":{"id":17378009,"name":"awesome","full_name":"awesomeWM/awesome","owner":{"login":"awesomeWM","id":6843364,"avatar_url":"https://avatars.githubusercontent.com/u/6843364?v=3","gravatar_id":"","url":"https://api.github.com/users/awesomeWM","html_url":"https://github.com/awesomeWM","followers_url":"https://api.github.com/users/awesomeWM/followers","following_url":"https://api.github.com/users/awesomeWM/following{/other_user}","gists_url":"https://api.github.com/users/awesomeWM/gists{/gist_id}","starred_url":"https://api.github.com/users/awesomeWM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesomeWM/subscriptions","organizations_url":"https://api.github.com/users/awesomeWM/orgs","repos_url":"https://api.github.com/users/awesomeWM/repos","events_url":"https://api.github.com/users/awesomeWM/events{/privacy}","received_events_url":"https://api.github.com/users/awesomeWM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awesomeWM/awesome","description":"awesome window manager","fork":false,"url":"https://api.github.com/repos/awesomeWM/awesome","forks_url":"https://api.github.com/repos/awesomeWM/awesome/forks","keys_url":"https://api.github.com/repos/awesomeWM/awesome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awesomeWM/awesome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awesomeWM/awesome/teams","hooks_url":"https://api.github.com/repos/awesomeWM/awesome/hooks","issue_events_url":"https://api.github.com/repos/awesomeWM/awesome/issues/events{/number}","events_url":"https://api.github.com/repos/awesomeWM/awesome/events","assignees_url":"https://api.github.com/repos/awesomeWM/awesome/assignees{/user}","branches_url":"https://api.github.com/repos/awesomeWM/awesome/branches{/branch}","tags_url":"https://api.github.com/repos/awesomeWM/awesome/tags","blobs_url":"https://api.github.com/repos/awesomeWM/awesome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awesomeWM/awesome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awesomeWM/awesome/git/refs{/sha}","trees_url":"https://api.github.com/repos/awesomeWM/awesome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awesomeWM/awesome/statuses/{sha}","languages_url":"https://api.github.com/repos/awesomeWM/awesome/languages","stargazers_url":"https://api.github.com/repos/awesomeWM/awesome/stargazers","contributors_url":"https://api.github.com/repos/awesomeWM/awesome/contributors","subscribers_url":"https://api.github.com/repos/awesomeWM/awesome/subscribers","subscription_url":"https://api.github.com/repos/awesomeWM/awesome/subscription","commits_url":"https://api.github.com/repos/awesomeWM/awesome/commits{/sha}","git_commits_url":"https://api.github.com/repos/awesomeWM/awesome/git/commits{/sha}","comments_url":"https://api.github.com/repos/awesomeWM/awesome/comments{/number}","issue_comment_url":"https://api.github.com/repos/awesomeWM/awesome/issues/comments{/number}","contents_url":"https://api.github.com/repos/awesomeWM/awesome/contents/{+path}","compare_url":"https://api.github.com/repos/awesomeWM/awesome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awesomeWM/awesome/merges","archive_url":"https://api.github.com/repos/awesomeWM/awesome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awesomeWM/awesome/downloads","issues_url":"https://api.github.com/repos/awesomeWM/awesome/issues{/number}","pulls_url":"https://api.github.com/repos/awesomeWM/awesome/pulls{/number}","milestones_url":"https://api.github.com/repos/awesomeWM/awesome/milestones{/number}","notifications_url":"https://api.github.com/repos/awesomeWM/awesome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awesomeWM/awesome/labels{/name}","releases_url":"https://api.github.com/repos/awesomeWM/awesome/releases{/id}","deployments_url":"https://api.github.com/repos/awesomeWM/awesome/deployments","created_at":"2014-03-03T19:56:16Z","updated_at":"2016-05-14T10:57:49Z","pushed_at":"2016-05-14T11:14:55Z","git_url":"git://github.com/awesomeWM/awesome.git","ssh_url":"git@github.com:awesomeWM/awesome.git","clone_url":"https://github.com/awesomeWM/awesome.git","svn_url":"https://github.com/awesomeWM/awesome","homepage":"https://awesomewm.org/","size":15786,"stargazers_count":750,"watchers_count":750,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":116,"mirror_url":null,"open_issues_count":126,"forks":116,"open_issues":126,"watchers":750,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/903"},"html":{"href":"https://github.com/awesomeWM/awesome/pull/903"},"issue":{"href":"https://api.github.com/repos/awesomeWM/awesome/issues/903"},"comments":{"href":"https://api.github.com/repos/awesomeWM/awesome/issues/903/comments"},"review_comments":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/903/comments"},"review_comment":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/903/commits"},"statuses":{"href":"https://api.github.com/repos/awesomeWM/awesome/statuses/cbdf40363781ebfe1d2a0e453d363c7ccd269612"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":2,"changed_files":3}}