{"action":"created","comment":{"url":"https://api.github.com/repos/geolessel/pco-api-elixir/pulls/comments/68099828","id":68099828,"diff_hunk":"@@ -0,0 +1,47 @@\n+defmodule PcoApi.People.EmailTest do","path":"test/pco_api/people/email_test.exs","position":1,"original_position":1,"commit_id":"a01ad0d7f51146644afa9b2eea79e8e588cc2ece","original_commit_id":"a01ad0d7f51146644afa9b2eea79e8e588cc2ece","user":{"login":"credoci","id":16824169,"avatar_url":"https://avatars.githubusercontent.com/u/16824169?v=3","gravatar_id":"","url":"https://api.github.com/users/credoci","html_url":"https://github.com/credoci","followers_url":"https://api.github.com/users/credoci/followers","following_url":"https://api.github.com/users/credoci/following{/other_user}","gists_url":"https://api.github.com/users/credoci/gists{/gist_id}","starred_url":"https://api.github.com/users/credoci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/credoci/subscriptions","organizations_url":"https://api.github.com/users/credoci/orgs","repos_url":"https://api.github.com/users/credoci/repos","events_url":"https://api.github.com/users/credoci/events{/privacy}","received_events_url":"https://api.github.com/users/credoci/received_events","type":"User","site_admin":false},"body":"Modules should have a @moduledoc tag.","created_at":"2016-06-22T17:42:45Z","updated_at":"2016-06-22T17:42:45Z","html_url":"https://github.com/geolessel/pco-api-elixir/pull/29#discussion_r68099828","pull_request_url":"https://api.github.com/repos/geolessel/pco-api-elixir/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/geolessel/pco-api-elixir/pulls/comments/68099828"},"html":{"href":"https://github.com/geolessel/pco-api-elixir/pull/29#discussion_r68099828"},"pull_request":{"href":"https://api.github.com/repos/geolessel/pco-api-elixir/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/geolessel/pco-api-elixir/pulls/29","id":73151209,"html_url":"https://github.com/geolessel/pco-api-elixir/pull/29","diff_url":"https://github.com/geolessel/pco-api-elixir/pull/29.diff","patch_url":"https://github.com/geolessel/pco-api-elixir/pull/29.patch","issue_url":"https://api.github.com/repos/geolessel/pco-api-elixir/issues/29","number":29,"state":"closed","locked":false,"title":"change(Actions): Major breaking rewrite of Actions","user":{"login":"geolessel","id":385726,"avatar_url":"https://avatars.githubusercontent.com/u/385726?v=3","gravatar_id":"","url":"https://api.github.com/users/geolessel","html_url":"https://github.com/geolessel","followers_url":"https://api.github.com/users/geolessel/followers","following_url":"https://api.github.com/users/geolessel/following{/other_user}","gists_url":"https://api.github.com/users/geolessel/gists{/gist_id}","starred_url":"https://api.github.com/users/geolessel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geolessel/subscriptions","organizations_url":"https://api.github.com/users/geolessel/orgs","repos_url":"https://api.github.com/users/geolessel/repos","events_url":"https://api.github.com/users/geolessel/events{/privacy}","received_events_url":"https://api.github.com/users/geolessel/received_events","type":"User","site_admin":false},"body":"This completely changes the way the API works so we should really discuss. Here are some of the major points (I may have forgotten some as I started this rewrite a week or so ago):\r\n\r\n* Split up `PcoApi.Actions` into submodules of `Get`, `Create`, `Self`, `New` (will also make `Update` when the time comes)\r\n* Less magic in the modules for hitting the endpoints\r\n* Split out a `list` function from `get`. `get` is now only responsible for getting singular records. `list` gets a list of records.\r\n* When you define an endpoint module, you'll need to define just a handful of explicit functions:\r\n  * `list\\0` to define the listing URL\r\n  * `list\\1` to define the URL to use when passed a `Query`\r\n  * `get\\1` to define how to get a single record with an ID\r\n  * `create\\1` to define the URL used when creating a record\r\n  * `self\\1` to define the URL to use when a record needs to get itself but doesn't have a `self` link\r\n  * `new\\1` to define what kind of record this module is (ie `Person`, `Address`, etc)\r\n\r\nIgnore all the endpoint modules expect `Person` in this PR if you can. I had to comment stuff out to get it to compile so I could test `Person`. Those tests pass, BTW.\r\n\r\nWhat are your thoughts on this approach?","created_at":"2016-06-09T02:58:19Z","updated_at":"2016-06-22T17:42:46Z","closed_at":"2016-06-22T17:42:30Z","merged_at":"2016-06-22T17:42:30Z","merge_commit_sha":"406127190b1e15074a36b14668bc9669d0f48d0c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/geolessel/pco-api-elixir/pulls/29/commits","review_comments_url":"https://api.github.com/repos/geolessel/pco-api-elixir/pulls/29/comments","review_comment_url":"https://api.github.com/repos/geolessel/pco-api-elixir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geolessel/pco-api-elixir/issues/29/comments","statuses_url":"https://api.github.com/repos/geolessel/pco-api-elixir/statuses/a01ad0d7f51146644afa9b2eea79e8e588cc2ece","head":{"label":"geolessel:gl/actions-rewrite","ref":"gl/actions-rewrite","sha":"a01ad0d7f51146644afa9b2eea79e8e588cc2ece","user":{"login":"geolessel","id":385726,"avatar_url":"https://avatars.githubusercontent.com/u/385726?v=3","gravatar_id":"","url":"https://api.github.com/users/geolessel","html_url":"https://github.com/geolessel","followers_url":"https://api.github.com/users/geolessel/followers","following_url":"https://api.github.com/users/geolessel/following{/other_user}","gists_url":"https://api.github.com/users/geolessel/gists{/gist_id}","starred_url":"https://api.github.com/users/geolessel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geolessel/subscriptions","organizations_url":"https://api.github.com/users/geolessel/orgs","repos_url":"https://api.github.com/users/geolessel/repos","events_url":"https://api.github.com/users/geolessel/events{/privacy}","received_events_url":"https://api.github.com/users/geolessel/received_events","type":"User","site_admin":false},"repo":{"id":58768085,"name":"pco-api-elixir","full_name":"geolessel/pco-api-elixir","owner":{"login":"geolessel","id":385726,"avatar_url":"https://avatars.githubusercontent.com/u/385726?v=3","gravatar_id":"","url":"https://api.github.com/users/geolessel","html_url":"https://github.com/geolessel","followers_url":"https://api.github.com/users/geolessel/followers","following_url":"https://api.github.com/users/geolessel/following{/other_user}","gists_url":"https://api.github.com/users/geolessel/gists{/gist_id}","starred_url":"https://api.github.com/users/geolessel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geolessel/subscriptions","organizations_url":"https://api.github.com/users/geolessel/orgs","repos_url":"https://api.github.com/users/geolessel/repos","events_url":"https://api.github.com/users/geolessel/events{/privacy}","received_events_url":"https://api.github.com/users/geolessel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geolessel/pco-api-elixir","description":"An Elixir package for consuming Planning Center Online's public API","fork":false,"url":"https://api.github.com/repos/geolessel/pco-api-elixir","forks_url":"https://api.github.com/repos/geolessel/pco-api-elixir/forks","keys_url":"https://api.github.com/repos/geolessel/pco-api-elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geolessel/pco-api-elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geolessel/pco-api-elixir/teams","hooks_url":"https://api.github.com/repos/geolessel/pco-api-elixir/hooks","issue_events_url":"https://api.github.com/repos/geolessel/pco-api-elixir/issues/events{/number}","events_url":"https://api.github.com/repos/geolessel/pco-api-elixir/events","assignees_url":"https://api.github.com/repos/geolessel/pco-api-elixir/assignees{/user}","branches_url":"https://api.github.com/repos/geolessel/pco-api-elixir/branches{/branch}","tags_url":"https://api.github.com/repos/geolessel/pco-api-elixir/tags","blobs_url":"https://api.github.com/repos/geolessel/pco-api-elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geolessel/pco-api-elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geolessel/pco-api-elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/geolessel/pco-api-elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geolessel/pco-api-elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/geolessel/pco-api-elixir/languages","stargazers_url":"https://api.github.com/repos/geolessel/pco-api-elixir/stargazers","contributors_url":"https://api.github.com/repos/geolessel/pco-api-elixir/contributors","subscribers_url":"https://api.github.com/repos/geolessel/pco-api-elixir/subscribers","subscription_url":"https://api.github.com/repos/geolessel/pco-api-elixir/subscription","commits_url":"https://api.github.com/repos/geolessel/pco-api-elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/geolessel/pco-api-elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/geolessel/pco-api-elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/geolessel/pco-api-elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/geolessel/pco-api-elixir/contents/{+path}","compare_url":"https://api.github.com/repos/geolessel/pco-api-elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geolessel/pco-api-elixir/merges","archive_url":"https://api.github.com/repos/geolessel/pco-api-elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geolessel/pco-api-elixir/downloads","issues_url":"https://api.github.com/repos/geolessel/pco-api-elixir/issues{/number}","pulls_url":"https://api.github.com/repos/geolessel/pco-api-elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/geolessel/pco-api-elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/geolessel/pco-api-elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geolessel/pco-api-elixir/labels{/name}","releases_url":"https://api.github.com/repos/geolessel/pco-api-elixir/releases{/id}","deployments_url":"https://api.github.com/repos/geolessel/pco-api-elixir/deployments","created_at":"2016-05-13T19:44:41Z","updated_at":"2016-05-13T20:04:32Z","pushed_at":"2016-06-22T17:42:32Z","git_url":"git://github.com/geolessel/pco-api-elixir.git","ssh_url":"git@github.com:geolessel/pco-api-elixir.git","clone_url":"https://github.com/geolessel/pco-api-elixir.git","svn_url":"https://github.com/geolessel/pco-api-elixir","homepage":null,"size":220,"stargazers_count":1,"watchers_count":1,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"geolessel:master","ref":"master","sha":"19b91b084d16cf2e183d27ac7795281b7f7ea966","user":{"login":"geolessel","id":385726,"avatar_url":"https://avatars.githubusercontent.com/u/385726?v=3","gravatar_id":"","url":"https://api.github.com/users/geolessel","html_url":"https://github.com/geolessel","followers_url":"https://api.github.com/users/geolessel/followers","following_url":"https://api.github.com/users/geolessel/following{/other_user}","gists_url":"https://api.github.com/users/geolessel/gists{/gist_id}","starred_url":"https://api.github.com/users/geolessel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geolessel/subscriptions","organizations_url":"https://api.github.com/users/geolessel/orgs","repos_url":"https://api.github.com/users/geolessel/repos","events_url":"https://api.github.com/users/geolessel/events{/privacy}","received_events_url":"https://api.github.com/users/geolessel/received_events","type":"User","site_admin":false},"repo":{"id":58768085,"name":"pco-api-elixir","full_name":"geolessel/pco-api-elixir","owner":{"login":"geolessel","id":385726,"avatar_url":"https://avatars.githubusercontent.com/u/385726?v=3","gravatar_id":"","url":"https://api.github.com/users/geolessel","html_url":"https://github.com/geolessel","followers_url":"https://api.github.com/users/geolessel/followers","following_url":"https://api.github.com/users/geolessel/following{/other_user}","gists_url":"https://api.github.com/users/geolessel/gists{/gist_id}","starred_url":"https://api.github.com/users/geolessel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geolessel/subscriptions","organizations_url":"https://api.github.com/users/geolessel/orgs","repos_url":"https://api.github.com/users/geolessel/repos","events_url":"https://api.github.com/users/geolessel/events{/privacy}","received_events_url":"https://api.github.com/users/geolessel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geolessel/pco-api-elixir","description":"An Elixir package for consuming Planning Center Online's public API","fork":false,"url":"https://api.github.com/repos/geolessel/pco-api-elixir","forks_url":"https://api.github.com/repos/geolessel/pco-api-elixir/forks","keys_url":"https://api.github.com/repos/geolessel/pco-api-elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geolessel/pco-api-elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geolessel/pco-api-elixir/teams","hooks_url":"https://api.github.com/repos/geolessel/pco-api-elixir/hooks","issue_events_url":"https://api.github.com/repos/geolessel/pco-api-elixir/issues/events{/number}","events_url":"https://api.github.com/repos/geolessel/pco-api-elixir/events","assignees_url":"https://api.github.com/repos/geolessel/pco-api-elixir/assignees{/user}","branches_url":"https://api.github.com/repos/geolessel/pco-api-elixir/branches{/branch}","tags_url":"https://api.github.com/repos/geolessel/pco-api-elixir/tags","blobs_url":"https://api.github.com/repos/geolessel/pco-api-elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geolessel/pco-api-elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geolessel/pco-api-elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/geolessel/pco-api-elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geolessel/pco-api-elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/geolessel/pco-api-elixir/languages","stargazers_url":"https://api.github.com/repos/geolessel/pco-api-elixir/stargazers","contributors_url":"https://api.github.com/repos/geolessel/pco-api-elixir/contributors","subscribers_url":"https://api.github.com/repos/geolessel/pco-api-elixir/subscribers","subscription_url":"https://api.github.com/repos/geolessel/pco-api-elixir/subscription","commits_url":"https://api.github.com/repos/geolessel/pco-api-elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/geolessel/pco-api-elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/geolessel/pco-api-elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/geolessel/pco-api-elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/geolessel/pco-api-elixir/contents/{+path}","compare_url":"https://api.github.com/repos/geolessel/pco-api-elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geolessel/pco-api-elixir/merges","archive_url":"https://api.github.com/repos/geolessel/pco-api-elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geolessel/pco-api-elixir/downloads","issues_url":"https://api.github.com/repos/geolessel/pco-api-elixir/issues{/number}","pulls_url":"https://api.github.com/repos/geolessel/pco-api-elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/geolessel/pco-api-elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/geolessel/pco-api-elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geolessel/pco-api-elixir/labels{/name}","releases_url":"https://api.github.com/repos/geolessel/pco-api-elixir/releases{/id}","deployments_url":"https://api.github.com/repos/geolessel/pco-api-elixir/deployments","created_at":"2016-05-13T19:44:41Z","updated_at":"2016-05-13T20:04:32Z","pushed_at":"2016-06-22T17:42:32Z","git_url":"git://github.com/geolessel/pco-api-elixir.git","ssh_url":"git@github.com:geolessel/pco-api-elixir.git","clone_url":"https://github.com/geolessel/pco-api-elixir.git","svn_url":"https://github.com/geolessel/pco-api-elixir","homepage":null,"size":220,"stargazers_count":1,"watchers_count":1,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geolessel/pco-api-elixir/pulls/29"},"html":{"href":"https://github.com/geolessel/pco-api-elixir/pull/29"},"issue":{"href":"https://api.github.com/repos/geolessel/pco-api-elixir/issues/29"},"comments":{"href":"https://api.github.com/repos/geolessel/pco-api-elixir/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/geolessel/pco-api-elixir/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/geolessel/pco-api-elixir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geolessel/pco-api-elixir/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/geolessel/pco-api-elixir/statuses/a01ad0d7f51146644afa9b2eea79e8e588cc2ece"}}}}
{"actor":{"display_login":"credoci"}}