{"action":"created","issue":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8863","repository_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8863/labels{/name}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8863/comments","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8863/events","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8863","id":163682271,"number":8863,"title":"HPCC-15855 ESP cores in LDAP cache code","user":{"login":"richardkchapman","id":900820,"avatar_url":"https://avatars.githubusercontent.com/u/900820?v=3","gravatar_id":"","url":"https://api.github.com/users/richardkchapman","html_url":"https://github.com/richardkchapman","followers_url":"https://api.github.com/users/richardkchapman/followers","following_url":"https://api.github.com/users/richardkchapman/following{/other_user}","gists_url":"https://api.github.com/users/richardkchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/richardkchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardkchapman/subscriptions","organizations_url":"https://api.github.com/users/richardkchapman/orgs","repos_url":"https://api.github.com/users/richardkchapman/repos","events_url":"https://api.github.com/users/richardkchapman/events{/privacy}","received_events_url":"https://api.github.com/users/richardkchapman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-07-04T13:56:40Z","updated_at":"2016-07-05T08:49:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/8863","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8863","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8863.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8863.patch"},"body":"Rolling back changes made in HPCC-15482.\r\n\r\nSigned-off-by: Richard Chapman <rchapman@hpccsystems.com>"},"comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments/230421698","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/8863#issuecomment-230421698","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/8863","id":230421698,"user":{"login":"ghalliday","id":902490,"avatar_url":"https://avatars.githubusercontent.com/u/902490?v=3","gravatar_id":"","url":"https://api.github.com/users/ghalliday","html_url":"https://github.com/ghalliday","followers_url":"https://api.github.com/users/ghalliday/followers","following_url":"https://api.github.com/users/ghalliday/following{/other_user}","gists_url":"https://api.github.com/users/ghalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ghalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghalliday/subscriptions","organizations_url":"https://api.github.com/users/ghalliday/orgs","repos_url":"https://api.github.com/users/ghalliday/repos","events_url":"https://api.github.com/users/ghalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ghalliday/received_events","type":"User","site_admin":false},"created_at":"2016-07-05T08:49:10Z","updated_at":"2016-07-05T08:49:10Z","body":"There are various pieces of code that could be improved:\r\n\r\n- use a map to a CachedUser instead of a CachedUser *\r\n- avoid some appending to temporary buffers - e.g., use the version of md5_string that starts form a string.\r\n- Examine why clone() is called on the user instead of LINK().  ` m_userCache[username] = new CachedUser(sec_user.clone()); `\r\n"}}
{"actor":{"display_login":"ghalliday"}}