{"action":"closed","number":153,"pull_request":{"url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/pulls/153","id":65415162,"html_url":"https://github.com/panpawn/Pokemon-Showdown/pull/153","diff_url":"https://github.com/panpawn/Pokemon-Showdown/pull/153.diff","patch_url":"https://github.com/panpawn/Pokemon-Showdown/pull/153.patch","issue_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/issues/153","number":153,"state":"closed","locked":false,"title":"Fix Roomshop and improve error messages","user":{"login":"SilverTactic","id":5235804,"avatar_url":"https://avatars.githubusercontent.com/u/5235804?v=3","gravatar_id":"","url":"https://api.github.com/users/SilverTactic","html_url":"https://github.com/SilverTactic","followers_url":"https://api.github.com/users/SilverTactic/followers","following_url":"https://api.github.com/users/SilverTactic/following{/other_user}","gists_url":"https://api.github.com/users/SilverTactic/gists{/gist_id}","starred_url":"https://api.github.com/users/SilverTactic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SilverTactic/subscriptions","organizations_url":"https://api.github.com/users/SilverTactic/orgs","repos_url":"https://api.github.com/users/SilverTactic/repos","events_url":"https://api.github.com/users/SilverTactic/events{/privacy}","received_events_url":"https://api.github.com/users/SilverTactic/received_events","type":"User","site_admin":false},"body":"Couple of things about this\r\n1) The error was in <code>/roomshop add</code>and not <code>/roomshop buy</code> (it has nothing to do with my last PR). Not including the item description or price parameters caused the script to crash\r\n2) Improved error messages. You should now get more meaningful error messages if you don't use the command(s) the correct way\r\n3) Fully tested\r\n\r\nChanges made:\r\n1) Room founders, &, and ~ can now edit the room shop\r\n2) Entering just <code>/roomshop</code> displays the roomshop. Entering something like <code>/roomshop potato</code> will give you an error message, stating that 'x' is an invalid command","created_at":"2016-04-06T06:19:38Z","updated_at":"2016-04-06T20:20:05Z","closed_at":"2016-04-06T20:20:05Z","merged_at":null,"merge_commit_sha":"283d5861d2d087e2671c850c52c4d45dc8c9adc1","assignee":{"login":"jd4564","id":2987451,"avatar_url":"https://avatars.githubusercontent.com/u/2987451?v=3","gravatar_id":"","url":"https://api.github.com/users/jd4564","html_url":"https://github.com/jd4564","followers_url":"https://api.github.com/users/jd4564/followers","following_url":"https://api.github.com/users/jd4564/following{/other_user}","gists_url":"https://api.github.com/users/jd4564/gists{/gist_id}","starred_url":"https://api.github.com/users/jd4564/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jd4564/subscriptions","organizations_url":"https://api.github.com/users/jd4564/orgs","repos_url":"https://api.github.com/users/jd4564/repos","events_url":"https://api.github.com/users/jd4564/events{/privacy}","received_events_url":"https://api.github.com/users/jd4564/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/pulls/153/commits","review_comments_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/pulls/153/comments","review_comment_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/pulls/comments{/number}","comments_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/issues/153/comments","statuses_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/statuses/a7788ef0ab82d1d3dd58f7625a8292925db05dec","head":{"label":"SilverTactic:patch-47","ref":"patch-47","sha":"a7788ef0ab82d1d3dd58f7625a8292925db05dec","user":{"login":"SilverTactic","id":5235804,"avatar_url":"https://avatars.githubusercontent.com/u/5235804?v=3","gravatar_id":"","url":"https://api.github.com/users/SilverTactic","html_url":"https://github.com/SilverTactic","followers_url":"https://api.github.com/users/SilverTactic/followers","following_url":"https://api.github.com/users/SilverTactic/following{/other_user}","gists_url":"https://api.github.com/users/SilverTactic/gists{/gist_id}","starred_url":"https://api.github.com/users/SilverTactic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SilverTactic/subscriptions","organizations_url":"https://api.github.com/users/SilverTactic/orgs","repos_url":"https://api.github.com/users/SilverTactic/repos","events_url":"https://api.github.com/users/SilverTactic/events{/privacy}","received_events_url":"https://api.github.com/users/SilverTactic/received_events","type":"User","site_admin":false},"repo":{"id":24759130,"name":"Pokemon-Showdown","full_name":"SilverTactic/Pokemon-Showdown","owner":{"login":"SilverTactic","id":5235804,"avatar_url":"https://avatars.githubusercontent.com/u/5235804?v=3","gravatar_id":"","url":"https://api.github.com/users/SilverTactic","html_url":"https://github.com/SilverTactic","followers_url":"https://api.github.com/users/SilverTactic/followers","following_url":"https://api.github.com/users/SilverTactic/following{/other_user}","gists_url":"https://api.github.com/users/SilverTactic/gists{/gist_id}","starred_url":"https://api.github.com/users/SilverTactic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SilverTactic/subscriptions","organizations_url":"https://api.github.com/users/SilverTactic/orgs","repos_url":"https://api.github.com/users/SilverTactic/repos","events_url":"https://api.github.com/users/SilverTactic/events{/privacy}","received_events_url":"https://api.github.com/users/SilverTactic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SilverTactic/Pokemon-Showdown","description":"Pokémon battle simulator.","fork":true,"url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown","forks_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/forks","keys_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/teams","hooks_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/hooks","issue_events_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/issues/events{/number}","events_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/events","assignees_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/assignees{/user}","branches_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/branches{/branch}","tags_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/tags","blobs_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/statuses/{sha}","languages_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/languages","stargazers_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/stargazers","contributors_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/contributors","subscribers_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/subscribers","subscription_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/subscription","commits_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/issues/comments{/number}","contents_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/contents/{+path}","compare_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/merges","archive_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/downloads","issues_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/issues{/number}","pulls_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/pulls{/number}","milestones_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/milestones{/number}","notifications_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/labels{/name}","releases_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/releases{/id}","deployments_url":"https://api.github.com/repos/SilverTactic/Pokemon-Showdown/deployments","created_at":"2014-10-03T13:20:55Z","updated_at":"2015-01-09T15:03:41Z","pushed_at":"2016-04-06T06:44:26Z","git_url":"git://github.com/SilverTactic/Pokemon-Showdown.git","ssh_url":"git@github.com:SilverTactic/Pokemon-Showdown.git","clone_url":"https://github.com/SilverTactic/Pokemon-Showdown.git","svn_url":"https://github.com/SilverTactic/Pokemon-Showdown","homepage":"http://pokemonshowdown.com","size":52890,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"panpawn:master","ref":"master","sha":"ab0ec3360e4f7c00892d21e43a717a873a141ce4","user":{"login":"panpawn","id":5314189,"avatar_url":"https://avatars.githubusercontent.com/u/5314189?v=3","gravatar_id":"","url":"https://api.github.com/users/panpawn","html_url":"https://github.com/panpawn","followers_url":"https://api.github.com/users/panpawn/followers","following_url":"https://api.github.com/users/panpawn/following{/other_user}","gists_url":"https://api.github.com/users/panpawn/gists{/gist_id}","starred_url":"https://api.github.com/users/panpawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panpawn/subscriptions","organizations_url":"https://api.github.com/users/panpawn/orgs","repos_url":"https://api.github.com/users/panpawn/repos","events_url":"https://api.github.com/users/panpawn/events{/privacy}","received_events_url":"https://api.github.com/users/panpawn/received_events","type":"User","site_admin":false},"repo":{"id":12385273,"name":"Pokemon-Showdown","full_name":"panpawn/Pokemon-Showdown","owner":{"login":"panpawn","id":5314189,"avatar_url":"https://avatars.githubusercontent.com/u/5314189?v=3","gravatar_id":"","url":"https://api.github.com/users/panpawn","html_url":"https://github.com/panpawn","followers_url":"https://api.github.com/users/panpawn/followers","following_url":"https://api.github.com/users/panpawn/following{/other_user}","gists_url":"https://api.github.com/users/panpawn/gists{/gist_id}","starred_url":"https://api.github.com/users/panpawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panpawn/subscriptions","organizations_url":"https://api.github.com/users/panpawn/orgs","repos_url":"https://api.github.com/users/panpawn/repos","events_url":"https://api.github.com/users/panpawn/events{/privacy}","received_events_url":"https://api.github.com/users/panpawn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/panpawn/Pokemon-Showdown","description":"Pokémon battle simulator.","fork":true,"url":"https://api.github.com/repos/panpawn/Pokemon-Showdown","forks_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/forks","keys_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/teams","hooks_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/hooks","issue_events_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/issues/events{/number}","events_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/events","assignees_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/assignees{/user}","branches_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/branches{/branch}","tags_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/tags","blobs_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/statuses/{sha}","languages_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/languages","stargazers_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/stargazers","contributors_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/contributors","subscribers_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/subscribers","subscription_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/subscription","commits_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/issues/comments{/number}","contents_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/contents/{+path}","compare_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/merges","archive_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/downloads","issues_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/issues{/number}","pulls_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/pulls{/number}","milestones_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/milestones{/number}","notifications_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/labels{/name}","releases_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/releases{/id}","deployments_url":"https://api.github.com/repos/panpawn/Pokemon-Showdown/deployments","created_at":"2013-08-26T17:30:38Z","updated_at":"2015-11-26T17:37:35Z","pushed_at":"2016-04-06T20:18:41Z","git_url":"git://github.com/panpawn/Pokemon-Showdown.git","ssh_url":"git@github.com:panpawn/Pokemon-Showdown.git","clone_url":"https://github.com/panpawn/Pokemon-Showdown.git","svn_url":"https://github.com/panpawn/Pokemon-Showdown","homepage":"http://gold.psim.us","size":59601,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":5,"forks":19,"open_issues":5,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/panpawn/Pokemon-Showdown/pulls/153"},"html":{"href":"https://github.com/panpawn/Pokemon-Showdown/pull/153"},"issue":{"href":"https://api.github.com/repos/panpawn/Pokemon-Showdown/issues/153"},"comments":{"href":"https://api.github.com/repos/panpawn/Pokemon-Showdown/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/panpawn/Pokemon-Showdown/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/panpawn/Pokemon-Showdown/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/panpawn/Pokemon-Showdown/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/panpawn/Pokemon-Showdown/statuses/a7788ef0ab82d1d3dd58f7625a8292925db05dec"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":2,"additions":26,"deletions":20,"changed_files":1}}