{"action":"created","issue":{"url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/issues/1","repository_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table","labels_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/issues/1/comments","events_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/issues/1/events","html_url":"https://github.com/ConciergeAuctions/react-mui-table/pull/1","id":196786297,"number":1,"title":"Implement sorting and filtering. Make example folder.","user":{"login":"Nathan-Schwartz","id":7296584,"avatar_url":"https://avatars.githubusercontent.com/u/7296584?v=3","gravatar_id":"","url":"https://api.github.com/users/Nathan-Schwartz","html_url":"https://github.com/Nathan-Schwartz","followers_url":"https://api.github.com/users/Nathan-Schwartz/followers","following_url":"https://api.github.com/users/Nathan-Schwartz/following{/other_user}","gists_url":"https://api.github.com/users/Nathan-Schwartz/gists{/gist_id}","starred_url":"https://api.github.com/users/Nathan-Schwartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nathan-Schwartz/subscriptions","organizations_url":"https://api.github.com/users/Nathan-Schwartz/orgs","repos_url":"https://api.github.com/users/Nathan-Schwartz/repos","events_url":"https://api.github.com/users/Nathan-Schwartz/events{/privacy}","received_events_url":"https://api.github.com/users/Nathan-Schwartz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-20T21:31:30Z","updated_at":"2016-12-20T23:54:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/pulls/1","html_url":"https://github.com/ConciergeAuctions/react-mui-table/pull/1","diff_url":"https://github.com/ConciergeAuctions/react-mui-table/pull/1.diff","patch_url":"https://github.com/ConciergeAuctions/react-mui-table/pull/1.patch"},"body":"The table wasn't updating when receiving new props. Reason being that PureComponent doesn't check deep equality. I used normal Component with isEqual in componentShouldUpdate for the main component, but unsure if we should continue using PureComponent elsewhere. If we do it could potentially limit the compatibility of our package for users.\r\n\r\nNot sure if we want to do debouncing/throttling within the package. Atm it seems like it is one more package and option to handle.\r\n\r\nFilter functionality still needs to be implemented, and then I will be able to actually test this in our application. After all of that is done I will feel more comfortable refactoring and doing things like adding ES7 class properties.\r\n"},"comment":{"url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/issues/comments/268393940","html_url":"https://github.com/ConciergeAuctions/react-mui-table/pull/1#issuecomment-268393940","issue_url":"https://api.github.com/repos/ConciergeAuctions/react-mui-table/issues/1","id":268393940,"user":{"login":"Nathan-Schwartz","id":7296584,"avatar_url":"https://avatars.githubusercontent.com/u/7296584?v=3","gravatar_id":"","url":"https://api.github.com/users/Nathan-Schwartz","html_url":"https://github.com/Nathan-Schwartz","followers_url":"https://api.github.com/users/Nathan-Schwartz/followers","following_url":"https://api.github.com/users/Nathan-Schwartz/following{/other_user}","gists_url":"https://api.github.com/users/Nathan-Schwartz/gists{/gist_id}","starred_url":"https://api.github.com/users/Nathan-Schwartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nathan-Schwartz/subscriptions","organizations_url":"https://api.github.com/users/Nathan-Schwartz/orgs","repos_url":"https://api.github.com/users/Nathan-Schwartz/repos","events_url":"https://api.github.com/users/Nathan-Schwartz/events{/privacy}","received_events_url":"https://api.github.com/users/Nathan-Schwartz/received_events","type":"User","site_admin":false},"created_at":"2016-12-20T23:54:06Z","updated_at":"2016-12-20T23:54:06Z","body":"Lets hold off. Filters went pretty quickly so I might as well take care of checkboxes before we merge. Its a WIP so no need to review yet"}}
{"actor":{"display_login":"Nathan-Schwartz"}}