{"action":"closed","number":32,"pull_request":{"url":"https://api.github.com/repos/ethz-asl/rovio/pulls/32","id":56017264,"html_url":"https://github.com/ethz-asl/rovio/pull/32","diff_url":"https://github.com/ethz-asl/rovio/pull/32.diff","patch_url":"https://github.com/ethz-asl/rovio/pull/32.patch","issue_url":"https://api.github.com/repos/ethz-asl/rovio/issues/32","number":32,"state":"closed","locked":false,"title":"Update code so it can use OpenCV 3 libs","user":{"login":"TSC21","id":5048656,"avatar_url":"https://avatars.githubusercontent.com/u/5048656?v=3","gravatar_id":"","url":"https://api.github.com/users/TSC21","html_url":"https://github.com/TSC21","followers_url":"https://api.github.com/users/TSC21/followers","following_url":"https://api.github.com/users/TSC21/following{/other_user}","gists_url":"https://api.github.com/users/TSC21/gists{/gist_id}","starred_url":"https://api.github.com/users/TSC21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TSC21/subscriptions","organizations_url":"https://api.github.com/users/TSC21/orgs","repos_url":"https://api.github.com/users/TSC21/repos","events_url":"https://api.github.com/users/TSC21/events{/privacy}","received_events_url":"https://api.github.com/users/TSC21/received_events","type":"User","site_admin":false},"body":"@bloesch, I updated the code so it can use OpenCV 3 libs/binaries. It already compiles but I get a seg fault when running any of the nodes. Using `gdb`, I get:\r\n```bash\r\nProgram received signal SIGSEGV, Segmentation fault.\r\n0x00007ffff6bb4282 in cv::Mat::copyTo(cv::_OutputArray const&) const () from /usr/lib/x86_64-linux-gnu/libopencv_core.so.2.4\r\n```\r\nThe above may be related to the fact that `libopencv-*2.4` is installed, but removing it breaks ROS install. If anyone has a recommendation on how to solve the symbolic link problem, I appreciate it, and everyone will benefit. It may be just a little detail in `CMakeLists.txt`, which I'm missing.\r\n\r\nRecommended: install OpenCV 3 by src. Seems like that the build doesn't link to `ros-<ros-distro>-opencv3`. If I remove `find_package(OpenCV REQUIRED)` and `target_link_libraries(${PROJECT_NAME} ... ${OpenCV_LIBS}`, it gets symbolic link errors during compile time.","created_at":"2016-01-14T10:33:53Z","updated_at":"2016-05-18T17:01:48Z","closed_at":"2016-05-18T17:01:48Z","merged_at":null,"merge_commit_sha":"a7d0bcbdd54f4cb70b230d267fe09c4b8bd844b3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ethz-asl/rovio/pulls/32/commits","review_comments_url":"https://api.github.com/repos/ethz-asl/rovio/pulls/32/comments","review_comment_url":"https://api.github.com/repos/ethz-asl/rovio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethz-asl/rovio/issues/32/comments","statuses_url":"https://api.github.com/repos/ethz-asl/rovio/statuses/b10042e9653d355f85d2fdbc67260ebf89a604f2","head":{"label":"TSC21:opencv3","ref":"opencv3","sha":"b10042e9653d355f85d2fdbc67260ebf89a604f2","user":{"login":"TSC21","id":5048656,"avatar_url":"https://avatars.githubusercontent.com/u/5048656?v=3","gravatar_id":"","url":"https://api.github.com/users/TSC21","html_url":"https://github.com/TSC21","followers_url":"https://api.github.com/users/TSC21/followers","following_url":"https://api.github.com/users/TSC21/following{/other_user}","gists_url":"https://api.github.com/users/TSC21/gists{/gist_id}","starred_url":"https://api.github.com/users/TSC21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TSC21/subscriptions","organizations_url":"https://api.github.com/users/TSC21/orgs","repos_url":"https://api.github.com/users/TSC21/repos","events_url":"https://api.github.com/users/TSC21/events{/privacy}","received_events_url":"https://api.github.com/users/TSC21/received_events","type":"User","site_admin":false},"repo":{"id":49580494,"name":"rovio","full_name":"TSC21/rovio","owner":{"login":"TSC21","id":5048656,"avatar_url":"https://avatars.githubusercontent.com/u/5048656?v=3","gravatar_id":"","url":"https://api.github.com/users/TSC21","html_url":"https://github.com/TSC21","followers_url":"https://api.github.com/users/TSC21/followers","following_url":"https://api.github.com/users/TSC21/following{/other_user}","gists_url":"https://api.github.com/users/TSC21/gists{/gist_id}","starred_url":"https://api.github.com/users/TSC21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TSC21/subscriptions","organizations_url":"https://api.github.com/users/TSC21/orgs","repos_url":"https://api.github.com/users/TSC21/repos","events_url":"https://api.github.com/users/TSC21/events{/privacy}","received_events_url":"https://api.github.com/users/TSC21/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TSC21/rovio","description":"","fork":true,"url":"https://api.github.com/repos/TSC21/rovio","forks_url":"https://api.github.com/repos/TSC21/rovio/forks","keys_url":"https://api.github.com/repos/TSC21/rovio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TSC21/rovio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TSC21/rovio/teams","hooks_url":"https://api.github.com/repos/TSC21/rovio/hooks","issue_events_url":"https://api.github.com/repos/TSC21/rovio/issues/events{/number}","events_url":"https://api.github.com/repos/TSC21/rovio/events","assignees_url":"https://api.github.com/repos/TSC21/rovio/assignees{/user}","branches_url":"https://api.github.com/repos/TSC21/rovio/branches{/branch}","tags_url":"https://api.github.com/repos/TSC21/rovio/tags","blobs_url":"https://api.github.com/repos/TSC21/rovio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TSC21/rovio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TSC21/rovio/git/refs{/sha}","trees_url":"https://api.github.com/repos/TSC21/rovio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TSC21/rovio/statuses/{sha}","languages_url":"https://api.github.com/repos/TSC21/rovio/languages","stargazers_url":"https://api.github.com/repos/TSC21/rovio/stargazers","contributors_url":"https://api.github.com/repos/TSC21/rovio/contributors","subscribers_url":"https://api.github.com/repos/TSC21/rovio/subscribers","subscription_url":"https://api.github.com/repos/TSC21/rovio/subscription","commits_url":"https://api.github.com/repos/TSC21/rovio/commits{/sha}","git_commits_url":"https://api.github.com/repos/TSC21/rovio/git/commits{/sha}","comments_url":"https://api.github.com/repos/TSC21/rovio/comments{/number}","issue_comment_url":"https://api.github.com/repos/TSC21/rovio/issues/comments{/number}","contents_url":"https://api.github.com/repos/TSC21/rovio/contents/{+path}","compare_url":"https://api.github.com/repos/TSC21/rovio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TSC21/rovio/merges","archive_url":"https://api.github.com/repos/TSC21/rovio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TSC21/rovio/downloads","issues_url":"https://api.github.com/repos/TSC21/rovio/issues{/number}","pulls_url":"https://api.github.com/repos/TSC21/rovio/pulls{/number}","milestones_url":"https://api.github.com/repos/TSC21/rovio/milestones{/number}","notifications_url":"https://api.github.com/repos/TSC21/rovio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TSC21/rovio/labels{/name}","releases_url":"https://api.github.com/repos/TSC21/rovio/releases{/id}","deployments_url":"https://api.github.com/repos/TSC21/rovio/deployments","created_at":"2016-01-13T14:55:52Z","updated_at":"2016-01-13T14:55:53Z","pushed_at":"2016-01-14T16:52:03Z","git_url":"git://github.com/TSC21/rovio.git","ssh_url":"git@github.com:TSC21/rovio.git","clone_url":"https://github.com/TSC21/rovio.git","svn_url":"https://github.com/TSC21/rovio","homepage":null,"size":780,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethz-asl:master","ref":"master","sha":"61cde9dc5845963d7782e0558ed46d1a4dde084d","user":{"login":"ethz-asl","id":475362,"avatar_url":"https://avatars.githubusercontent.com/u/475362?v=3","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"repo":{"id":40291700,"name":"rovio","full_name":"ethz-asl/rovio","owner":{"login":"ethz-asl","id":475362,"avatar_url":"https://avatars.githubusercontent.com/u/475362?v=3","gravatar_id":"","url":"https://api.github.com/users/ethz-asl","html_url":"https://github.com/ethz-asl","followers_url":"https://api.github.com/users/ethz-asl/followers","following_url":"https://api.github.com/users/ethz-asl/following{/other_user}","gists_url":"https://api.github.com/users/ethz-asl/gists{/gist_id}","starred_url":"https://api.github.com/users/ethz-asl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethz-asl/subscriptions","organizations_url":"https://api.github.com/users/ethz-asl/orgs","repos_url":"https://api.github.com/users/ethz-asl/repos","events_url":"https://api.github.com/users/ethz-asl/events{/privacy}","received_events_url":"https://api.github.com/users/ethz-asl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethz-asl/rovio","description":"","fork":false,"url":"https://api.github.com/repos/ethz-asl/rovio","forks_url":"https://api.github.com/repos/ethz-asl/rovio/forks","keys_url":"https://api.github.com/repos/ethz-asl/rovio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethz-asl/rovio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethz-asl/rovio/teams","hooks_url":"https://api.github.com/repos/ethz-asl/rovio/hooks","issue_events_url":"https://api.github.com/repos/ethz-asl/rovio/issues/events{/number}","events_url":"https://api.github.com/repos/ethz-asl/rovio/events","assignees_url":"https://api.github.com/repos/ethz-asl/rovio/assignees{/user}","branches_url":"https://api.github.com/repos/ethz-asl/rovio/branches{/branch}","tags_url":"https://api.github.com/repos/ethz-asl/rovio/tags","blobs_url":"https://api.github.com/repos/ethz-asl/rovio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethz-asl/rovio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethz-asl/rovio/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethz-asl/rovio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethz-asl/rovio/statuses/{sha}","languages_url":"https://api.github.com/repos/ethz-asl/rovio/languages","stargazers_url":"https://api.github.com/repos/ethz-asl/rovio/stargazers","contributors_url":"https://api.github.com/repos/ethz-asl/rovio/contributors","subscribers_url":"https://api.github.com/repos/ethz-asl/rovio/subscribers","subscription_url":"https://api.github.com/repos/ethz-asl/rovio/subscription","commits_url":"https://api.github.com/repos/ethz-asl/rovio/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethz-asl/rovio/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethz-asl/rovio/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethz-asl/rovio/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethz-asl/rovio/contents/{+path}","compare_url":"https://api.github.com/repos/ethz-asl/rovio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethz-asl/rovio/merges","archive_url":"https://api.github.com/repos/ethz-asl/rovio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethz-asl/rovio/downloads","issues_url":"https://api.github.com/repos/ethz-asl/rovio/issues{/number}","pulls_url":"https://api.github.com/repos/ethz-asl/rovio/pulls{/number}","milestones_url":"https://api.github.com/repos/ethz-asl/rovio/milestones{/number}","notifications_url":"https://api.github.com/repos/ethz-asl/rovio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethz-asl/rovio/labels{/name}","releases_url":"https://api.github.com/repos/ethz-asl/rovio/releases{/id}","deployments_url":"https://api.github.com/repos/ethz-asl/rovio/deployments","created_at":"2015-08-06T07:43:05Z","updated_at":"2016-05-15T15:43:07Z","pushed_at":"2016-05-18T17:00:59Z","git_url":"git://github.com/ethz-asl/rovio.git","ssh_url":"git@github.com:ethz-asl/rovio.git","clone_url":"https://github.com/ethz-asl/rovio.git","svn_url":"https://github.com/ethz-asl/rovio","homepage":null,"size":865,"stargazers_count":56,"watchers_count":56,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":13,"forks":41,"open_issues":13,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethz-asl/rovio/pulls/32"},"html":{"href":"https://github.com/ethz-asl/rovio/pull/32"},"issue":{"href":"https://api.github.com/repos/ethz-asl/rovio/issues/32"},"comments":{"href":"https://api.github.com/repos/ethz-asl/rovio/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/ethz-asl/rovio/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/ethz-asl/rovio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethz-asl/rovio/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/ethz-asl/rovio/statuses/b10042e9653d355f85d2fdbc67260ebf89a604f2"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":7,"review_comments":2,"commits":7,"additions":57,"deletions":39,"changed_files":9}}