{"action":"created","comment":{"url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/pulls/comments/88161977","pull_request_review_id":8743573,"id":88161977,"diff_hunk":"@@ -93,4 +106,118 @@ public function getPropertyType( $propertyName = null ) {\n \t\treturn array( $property->findPropertyTypeID() );\n \t}\n \n+\t/**\n+\t * This mirrors the functionality of the parser function #info and makes it available to lua.\n+\t *\n+\t * @param string\t$text\ttext to show inside the info popup\n+\t * @param string    $icon   identifier for the icon to use\n+\t *\n+\t * @uses \\SMW\\ParserFunctionFactory::__construct\n+\t *\n+\t * @return string[]\n+\t */\n+\tpublic function info( $text, $icon='info' )\n+\t{\n+\t\t$parser = $this->getEngine()->getParser();\n+\n+\t\t# do some parameter processing\n+\t\tif ( !trim($text) || ! is_string($text) ) {","path":"src/ScribuntoLuaLibrary.php","position":62,"original_position":62,"commit_id":"667424341d31483bb29dc04a33edc44b20ca65a8","original_commit_id":"667424341d31483bb29dc04a33edc44b20ca65a8","user":{"login":"JeroenDeDauw","id":146040,"avatar_url":"https://avatars.githubusercontent.com/u/146040?v=3","gravatar_id":"","url":"https://api.github.com/users/JeroenDeDauw","html_url":"https://github.com/JeroenDeDauw","followers_url":"https://api.github.com/users/JeroenDeDauw/followers","following_url":"https://api.github.com/users/JeroenDeDauw/following{/other_user}","gists_url":"https://api.github.com/users/JeroenDeDauw/gists{/gist_id}","starred_url":"https://api.github.com/users/JeroenDeDauw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeroenDeDauw/subscriptions","organizations_url":"https://api.github.com/users/JeroenDeDauw/orgs","repos_url":"https://api.github.com/users/JeroenDeDauw/repos","events_url":"https://api.github.com/users/JeroenDeDauw/events{/privacy}","received_events_url":"https://api.github.com/users/JeroenDeDauw/received_events","type":"User","site_admin":false},"body":"Rather than writing comments (for which we use `//`), consider splitting up the function into smaller, well named functions, that do one single thing. That makes the code a lot easier to read and maintain.","created_at":"2016-11-16T03:13:11Z","updated_at":"2016-11-16T03:18:53Z","html_url":"https://github.com/SemanticMediaWiki/SemanticScribunto/pull/20#discussion_r88161977","pull_request_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/pulls/comments/88161977"},"html":{"href":"https://github.com/SemanticMediaWiki/SemanticScribunto/pull/20#discussion_r88161977"},"pull_request":{"href":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/pulls/20","id":93804258,"html_url":"https://github.com/SemanticMediaWiki/SemanticScribunto/pull/20","diff_url":"https://github.com/SemanticMediaWiki/SemanticScribunto/pull/20.diff","patch_url":"https://github.com/SemanticMediaWiki/SemanticScribunto/pull/20.patch","issue_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/issues/20","number":20,"state":"open","locked":false,"title":"Adding mw.smw.info to available smw functions","user":{"login":"oetterer","id":9444462,"avatar_url":"https://avatars.githubusercontent.com/u/9444462?v=3","gravatar_id":"","url":"https://api.github.com/users/oetterer","html_url":"https://github.com/oetterer","followers_url":"https://api.github.com/users/oetterer/followers","following_url":"https://api.github.com/users/oetterer/following{/other_user}","gists_url":"https://api.github.com/users/oetterer/gists{/gist_id}","starred_url":"https://api.github.com/users/oetterer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oetterer/subscriptions","organizations_url":"https://api.github.com/users/oetterer/orgs","repos_url":"https://api.github.com/users/oetterer/repos","events_url":"https://api.github.com/users/oetterer/events{/privacy}","received_events_url":"https://api.github.com/users/oetterer/received_events","type":"User","site_admin":false},"body":"Soo, this time with a branch. not sure, this is better, though. This will be my last PR for today.\r\n\r\nThis one follows a slightly different path. To remove the usage of `\\ParserHooks\\FunctionRunner`, the contents of `InfoParserFunction`'s `handle` have been replicated. That meant, also doing the parameter verification in the new function. Fortunately `#ino` is lightweight and not that complicated.","created_at":"2016-11-15T16:51:01Z","updated_at":"2016-11-16T03:18:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9683b6d13acab5a8145d5601862853acb9f49e1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/pulls/20/commits","review_comments_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/pulls/20/comments","review_comment_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/issues/20/comments","statuses_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/statuses/667424341d31483bb29dc04a33edc44b20ca65a8","head":{"label":"oetterer:ssc_info","ref":"ssc_info","sha":"667424341d31483bb29dc04a33edc44b20ca65a8","user":{"login":"oetterer","id":9444462,"avatar_url":"https://avatars.githubusercontent.com/u/9444462?v=3","gravatar_id":"","url":"https://api.github.com/users/oetterer","html_url":"https://github.com/oetterer","followers_url":"https://api.github.com/users/oetterer/followers","following_url":"https://api.github.com/users/oetterer/following{/other_user}","gists_url":"https://api.github.com/users/oetterer/gists{/gist_id}","starred_url":"https://api.github.com/users/oetterer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oetterer/subscriptions","organizations_url":"https://api.github.com/users/oetterer/orgs","repos_url":"https://api.github.com/users/oetterer/repos","events_url":"https://api.github.com/users/oetterer/events{/privacy}","received_events_url":"https://api.github.com/users/oetterer/received_events","type":"User","site_admin":false},"repo":{"id":73685398,"name":"SemanticScribunto","full_name":"oetterer/SemanticScribunto","owner":{"login":"oetterer","id":9444462,"avatar_url":"https://avatars.githubusercontent.com/u/9444462?v=3","gravatar_id":"","url":"https://api.github.com/users/oetterer","html_url":"https://github.com/oetterer","followers_url":"https://api.github.com/users/oetterer/followers","following_url":"https://api.github.com/users/oetterer/following{/other_user}","gists_url":"https://api.github.com/users/oetterer/gists{/gist_id}","starred_url":"https://api.github.com/users/oetterer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oetterer/subscriptions","organizations_url":"https://api.github.com/users/oetterer/orgs","repos_url":"https://api.github.com/users/oetterer/repos","events_url":"https://api.github.com/users/oetterer/events{/privacy}","received_events_url":"https://api.github.com/users/oetterer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oetterer/SemanticScribunto","description":"Provides service functions to support the Scribunto extension","fork":true,"url":"https://api.github.com/repos/oetterer/SemanticScribunto","forks_url":"https://api.github.com/repos/oetterer/SemanticScribunto/forks","keys_url":"https://api.github.com/repos/oetterer/SemanticScribunto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oetterer/SemanticScribunto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oetterer/SemanticScribunto/teams","hooks_url":"https://api.github.com/repos/oetterer/SemanticScribunto/hooks","issue_events_url":"https://api.github.com/repos/oetterer/SemanticScribunto/issues/events{/number}","events_url":"https://api.github.com/repos/oetterer/SemanticScribunto/events","assignees_url":"https://api.github.com/repos/oetterer/SemanticScribunto/assignees{/user}","branches_url":"https://api.github.com/repos/oetterer/SemanticScribunto/branches{/branch}","tags_url":"https://api.github.com/repos/oetterer/SemanticScribunto/tags","blobs_url":"https://api.github.com/repos/oetterer/SemanticScribunto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oetterer/SemanticScribunto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oetterer/SemanticScribunto/git/refs{/sha}","trees_url":"https://api.github.com/repos/oetterer/SemanticScribunto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oetterer/SemanticScribunto/statuses/{sha}","languages_url":"https://api.github.com/repos/oetterer/SemanticScribunto/languages","stargazers_url":"https://api.github.com/repos/oetterer/SemanticScribunto/stargazers","contributors_url":"https://api.github.com/repos/oetterer/SemanticScribunto/contributors","subscribers_url":"https://api.github.com/repos/oetterer/SemanticScribunto/subscribers","subscription_url":"https://api.github.com/repos/oetterer/SemanticScribunto/subscription","commits_url":"https://api.github.com/repos/oetterer/SemanticScribunto/commits{/sha}","git_commits_url":"https://api.github.com/repos/oetterer/SemanticScribunto/git/commits{/sha}","comments_url":"https://api.github.com/repos/oetterer/SemanticScribunto/comments{/number}","issue_comment_url":"https://api.github.com/repos/oetterer/SemanticScribunto/issues/comments{/number}","contents_url":"https://api.github.com/repos/oetterer/SemanticScribunto/contents/{+path}","compare_url":"https://api.github.com/repos/oetterer/SemanticScribunto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oetterer/SemanticScribunto/merges","archive_url":"https://api.github.com/repos/oetterer/SemanticScribunto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oetterer/SemanticScribunto/downloads","issues_url":"https://api.github.com/repos/oetterer/SemanticScribunto/issues{/number}","pulls_url":"https://api.github.com/repos/oetterer/SemanticScribunto/pulls{/number}","milestones_url":"https://api.github.com/repos/oetterer/SemanticScribunto/milestones{/number}","notifications_url":"https://api.github.com/repos/oetterer/SemanticScribunto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oetterer/SemanticScribunto/labels{/name}","releases_url":"https://api.github.com/repos/oetterer/SemanticScribunto/releases{/id}","deployments_url":"https://api.github.com/repos/oetterer/SemanticScribunto/deployments","created_at":"2016-11-14T08:53:10Z","updated_at":"2016-11-14T08:53:11Z","pushed_at":"2016-11-15T16:40:06Z","git_url":"git://github.com/oetterer/SemanticScribunto.git","ssh_url":"git@github.com:oetterer/SemanticScribunto.git","clone_url":"https://github.com/oetterer/SemanticScribunto.git","svn_url":"https://github.com/oetterer/SemanticScribunto","homepage":null,"size":55,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SemanticMediaWiki:master","ref":"master","sha":"0c6cd85afdb3c99a5a76cbdf8589ca9c208cf9b0","user":{"login":"SemanticMediaWiki","id":1623598,"avatar_url":"https://avatars.githubusercontent.com/u/1623598?v=3","gravatar_id":"","url":"https://api.github.com/users/SemanticMediaWiki","html_url":"https://github.com/SemanticMediaWiki","followers_url":"https://api.github.com/users/SemanticMediaWiki/followers","following_url":"https://api.github.com/users/SemanticMediaWiki/following{/other_user}","gists_url":"https://api.github.com/users/SemanticMediaWiki/gists{/gist_id}","starred_url":"https://api.github.com/users/SemanticMediaWiki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SemanticMediaWiki/subscriptions","organizations_url":"https://api.github.com/users/SemanticMediaWiki/orgs","repos_url":"https://api.github.com/users/SemanticMediaWiki/repos","events_url":"https://api.github.com/users/SemanticMediaWiki/events{/privacy}","received_events_url":"https://api.github.com/users/SemanticMediaWiki/received_events","type":"Organization","site_admin":false},"repo":{"id":60571235,"name":"SemanticScribunto","full_name":"SemanticMediaWiki/SemanticScribunto","owner":{"login":"SemanticMediaWiki","id":1623598,"avatar_url":"https://avatars.githubusercontent.com/u/1623598?v=3","gravatar_id":"","url":"https://api.github.com/users/SemanticMediaWiki","html_url":"https://github.com/SemanticMediaWiki","followers_url":"https://api.github.com/users/SemanticMediaWiki/followers","following_url":"https://api.github.com/users/SemanticMediaWiki/following{/other_user}","gists_url":"https://api.github.com/users/SemanticMediaWiki/gists{/gist_id}","starred_url":"https://api.github.com/users/SemanticMediaWiki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SemanticMediaWiki/subscriptions","organizations_url":"https://api.github.com/users/SemanticMediaWiki/orgs","repos_url":"https://api.github.com/users/SemanticMediaWiki/repos","events_url":"https://api.github.com/users/SemanticMediaWiki/events{/privacy}","received_events_url":"https://api.github.com/users/SemanticMediaWiki/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SemanticMediaWiki/SemanticScribunto","description":"Provides service functions to support the Scribunto extension","fork":false,"url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto","forks_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/forks","keys_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/teams","hooks_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/hooks","issue_events_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/issues/events{/number}","events_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/events","assignees_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/assignees{/user}","branches_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/branches{/branch}","tags_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/tags","blobs_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/git/refs{/sha}","trees_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/statuses/{sha}","languages_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/languages","stargazers_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/stargazers","contributors_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/contributors","subscribers_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/subscribers","subscription_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/subscription","commits_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/commits{/sha}","git_commits_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/git/commits{/sha}","comments_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/comments{/number}","issue_comment_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/issues/comments{/number}","contents_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/contents/{+path}","compare_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/merges","archive_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/downloads","issues_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/issues{/number}","pulls_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/pulls{/number}","milestones_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/milestones{/number}","notifications_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/labels{/name}","releases_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/releases{/id}","deployments_url":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/deployments","created_at":"2016-06-07T01:05:41Z","updated_at":"2016-11-05T02:13:16Z","pushed_at":"2016-11-15T16:51:01Z","git_url":"git://github.com/SemanticMediaWiki/SemanticScribunto.git","ssh_url":"git@github.com:SemanticMediaWiki/SemanticScribunto.git","clone_url":"https://github.com/SemanticMediaWiki/SemanticScribunto.git","svn_url":"https://github.com/SemanticMediaWiki/SemanticScribunto","homepage":null,"size":41,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/pulls/20"},"html":{"href":"https://github.com/SemanticMediaWiki/SemanticScribunto/pull/20"},"issue":{"href":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/issues/20"},"comments":{"href":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/SemanticMediaWiki/SemanticScribunto/statuses/667424341d31483bb29dc04a33edc44b20ca65a8"}}}}
{"actor":{"display_login":"JeroenDeDauw"}}