{"action":"created","comment":{"url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/pulls/comments/49280826","id":49280826,"diff_hunk":"@@ -129,6 +129,25 @@ public ConnectableDevice(JSONObject json) {\n         setLastSeenOnWifi(json.optString(KEY_LAST_SEEN, null));\n         setLastConnected(json.optLong(KEY_LAST_CONNECTED, 0));\n         setLastDetection(json.optLong(KEY_LAST_DETECTED, 0));\n+\n+        //Deserialize the associated services as well\n+        try {\n+            JSONObject jsonServices = json.getJSONObject(KEY_SERVICES);","path":"src/com/connectsdk/device/ConnectableDevice.java","position":7,"original_position":7,"commit_id":"517585af199ac4870fcfc00191502e82e2d4148a","original_commit_id":"517585af199ac4870fcfc00191502e82e2d4148a","user":{"login":"se-bastiaan","id":1799914,"avatar_url":"https://avatars.githubusercontent.com/u/1799914?v=3","gravatar_id":"","url":"https://api.github.com/users/se-bastiaan","html_url":"https://github.com/se-bastiaan","followers_url":"https://api.github.com/users/se-bastiaan/followers","following_url":"https://api.github.com/users/se-bastiaan/following{/other_user}","gists_url":"https://api.github.com/users/se-bastiaan/gists{/gist_id}","starred_url":"https://api.github.com/users/se-bastiaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/se-bastiaan/subscriptions","organizations_url":"https://api.github.com/users/se-bastiaan/orgs","repos_url":"https://api.github.com/users/se-bastiaan/repos","events_url":"https://api.github.com/users/se-bastiaan/events{/privacy}","received_events_url":"https://api.github.com/users/se-bastiaan/received_events","type":"User","site_admin":false},"body":"You should probably use 'optJSONObject here, just like the piece of code above this.","created_at":"2016-01-10T20:17:26Z","updated_at":"2016-01-10T20:17:26Z","html_url":"https://github.com/ConnectSDK/Connect-SDK-Android-Core/pull/92#discussion_r49280826","pull_request_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/pulls/92","_links":{"self":{"href":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/pulls/comments/49280826"},"html":{"href":"https://github.com/ConnectSDK/Connect-SDK-Android-Core/pull/92#discussion_r49280826"},"pull_request":{"href":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/pulls/92"}}},"pull_request":{"url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/pulls/92","id":54506186,"html_url":"https://github.com/ConnectSDK/Connect-SDK-Android-Core/pull/92","diff_url":"https://github.com/ConnectSDK/Connect-SDK-Android-Core/pull/92.diff","patch_url":"https://github.com/ConnectSDK/Connect-SDK-Android-Core/pull/92.patch","issue_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/issues/92","number":92,"state":"open","locked":false,"title":"- Added support for custom data in the MediaInfo object class + other fix","user":{"login":"GoMino","id":578618,"avatar_url":"https://avatars.githubusercontent.com/u/578618?v=3","gravatar_id":"","url":"https://api.github.com/users/GoMino","html_url":"https://github.com/GoMino","followers_url":"https://api.github.com/users/GoMino/followers","following_url":"https://api.github.com/users/GoMino/following{/other_user}","gists_url":"https://api.github.com/users/GoMino/gists{/gist_id}","starred_url":"https://api.github.com/users/GoMino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoMino/subscriptions","organizations_url":"https://api.github.com/users/GoMino/orgs","repos_url":"https://api.github.com/users/GoMino/repos","events_url":"https://api.github.com/users/GoMino/events{/privacy}","received_events_url":"https://api.github.com/users/GoMino/received_events","type":"User","site_admin":false},"body":"- Make sure the ConnectableDevice id is set with the serviceDescription UUID if any, instead of a generated one.\r\n- Fix the ConnectableDevice constructor with a JSONObject as argument to properly initialize the serialized DeviceServices if any.\r\n- Fix a bug where the serviceDescription does not get set to the ConnectableDevice when first discovered (was only set on the DeviceService at first, and then on the ConnectableDevice, when it get updated).\r\n- Added Support for startPosition and customData parameters in playMedia method of MediaPlayer capability.","created_at":"2015-12-23T20:59:03Z","updated_at":"2016-01-10T20:17:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9089b93be2d256349adbede5ceb7b99192a010c9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/pulls/92/commits","review_comments_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/pulls/92/comments","review_comment_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/issues/92/comments","statuses_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/statuses/517585af199ac4870fcfc00191502e82e2d4148a","head":{"label":"GoMino:dev","ref":"dev","sha":"517585af199ac4870fcfc00191502e82e2d4148a","user":{"login":"GoMino","id":578618,"avatar_url":"https://avatars.githubusercontent.com/u/578618?v=3","gravatar_id":"","url":"https://api.github.com/users/GoMino","html_url":"https://github.com/GoMino","followers_url":"https://api.github.com/users/GoMino/followers","following_url":"https://api.github.com/users/GoMino/following{/other_user}","gists_url":"https://api.github.com/users/GoMino/gists{/gist_id}","starred_url":"https://api.github.com/users/GoMino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoMino/subscriptions","organizations_url":"https://api.github.com/users/GoMino/orgs","repos_url":"https://api.github.com/users/GoMino/repos","events_url":"https://api.github.com/users/GoMino/events{/privacy}","received_events_url":"https://api.github.com/users/GoMino/received_events","type":"User","site_admin":false},"repo":{"id":48504362,"name":"Connect-SDK-Android-Core","full_name":"GoMino/Connect-SDK-Android-Core","owner":{"login":"GoMino","id":578618,"avatar_url":"https://avatars.githubusercontent.com/u/578618?v=3","gravatar_id":"","url":"https://api.github.com/users/GoMino","html_url":"https://github.com/GoMino","followers_url":"https://api.github.com/users/GoMino/followers","following_url":"https://api.github.com/users/GoMino/following{/other_user}","gists_url":"https://api.github.com/users/GoMino/gists{/gist_id}","starred_url":"https://api.github.com/users/GoMino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoMino/subscriptions","organizations_url":"https://api.github.com/users/GoMino/orgs","repos_url":"https://api.github.com/users/GoMino/repos","events_url":"https://api.github.com/users/GoMino/events{/privacy}","received_events_url":"https://api.github.com/users/GoMino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GoMino/Connect-SDK-Android-Core","description":"Core source code for the Android Connect SDK project","fork":true,"url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core","forks_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/forks","keys_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/teams","hooks_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/hooks","issue_events_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/issues/events{/number}","events_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/events","assignees_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/assignees{/user}","branches_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/branches{/branch}","tags_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/tags","blobs_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/statuses/{sha}","languages_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/languages","stargazers_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/stargazers","contributors_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/contributors","subscribers_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/subscribers","subscription_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/subscription","commits_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/contents/{+path}","compare_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/merges","archive_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/downloads","issues_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/issues{/number}","pulls_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/pulls{/number}","milestones_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/milestones{/number}","notifications_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/labels{/name}","releases_url":"https://api.github.com/repos/GoMino/Connect-SDK-Android-Core/releases{/id}","created_at":"2015-12-23T18:07:24Z","updated_at":"2015-12-23T18:07:25Z","pushed_at":"2015-12-23T19:27:59Z","git_url":"git://github.com/GoMino/Connect-SDK-Android-Core.git","ssh_url":"git@github.com:GoMino/Connect-SDK-Android-Core.git","clone_url":"https://github.com/GoMino/Connect-SDK-Android-Core.git","svn_url":"https://github.com/GoMino/Connect-SDK-Android-Core","homepage":"","size":12323,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ConnectSDK:dev","ref":"dev","sha":"3bd9bcdaf7c0ed78d8f0026c2cef479ae386dbee","user":{"login":"ConnectSDK","id":6496007,"avatar_url":"https://avatars.githubusercontent.com/u/6496007?v=3","gravatar_id":"","url":"https://api.github.com/users/ConnectSDK","html_url":"https://github.com/ConnectSDK","followers_url":"https://api.github.com/users/ConnectSDK/followers","following_url":"https://api.github.com/users/ConnectSDK/following{/other_user}","gists_url":"https://api.github.com/users/ConnectSDK/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnectSDK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnectSDK/subscriptions","organizations_url":"https://api.github.com/users/ConnectSDK/orgs","repos_url":"https://api.github.com/users/ConnectSDK/repos","events_url":"https://api.github.com/users/ConnectSDK/events{/privacy}","received_events_url":"https://api.github.com/users/ConnectSDK/received_events","type":"Organization","site_admin":false},"repo":{"id":22969679,"name":"Connect-SDK-Android-Core","full_name":"ConnectSDK/Connect-SDK-Android-Core","owner":{"login":"ConnectSDK","id":6496007,"avatar_url":"https://avatars.githubusercontent.com/u/6496007?v=3","gravatar_id":"","url":"https://api.github.com/users/ConnectSDK","html_url":"https://github.com/ConnectSDK","followers_url":"https://api.github.com/users/ConnectSDK/followers","following_url":"https://api.github.com/users/ConnectSDK/following{/other_user}","gists_url":"https://api.github.com/users/ConnectSDK/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnectSDK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnectSDK/subscriptions","organizations_url":"https://api.github.com/users/ConnectSDK/orgs","repos_url":"https://api.github.com/users/ConnectSDK/repos","events_url":"https://api.github.com/users/ConnectSDK/events{/privacy}","received_events_url":"https://api.github.com/users/ConnectSDK/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ConnectSDK/Connect-SDK-Android-Core","description":"Core source code for the Android Connect SDK project","fork":false,"url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core","forks_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/forks","keys_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/teams","hooks_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/hooks","issue_events_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/issues/events{/number}","events_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/events","assignees_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/assignees{/user}","branches_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/branches{/branch}","tags_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/tags","blobs_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/statuses/{sha}","languages_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/languages","stargazers_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/stargazers","contributors_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/contributors","subscribers_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/subscribers","subscription_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/subscription","commits_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/contents/{+path}","compare_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/merges","archive_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/downloads","issues_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/issues{/number}","pulls_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/pulls{/number}","milestones_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/milestones{/number}","notifications_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/labels{/name}","releases_url":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/releases{/id}","created_at":"2014-08-14T21:45:58Z","updated_at":"2015-12-22T02:17:28Z","pushed_at":"2015-12-23T20:59:03Z","git_url":"git://github.com/ConnectSDK/Connect-SDK-Android-Core.git","ssh_url":"git@github.com:ConnectSDK/Connect-SDK-Android-Core.git","clone_url":"https://github.com/ConnectSDK/Connect-SDK-Android-Core.git","svn_url":"https://github.com/ConnectSDK/Connect-SDK-Android-Core","homepage":"","size":12402,"stargazers_count":16,"watchers_count":16,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":12,"forks":19,"open_issues":12,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/pulls/92"},"html":{"href":"https://github.com/ConnectSDK/Connect-SDK-Android-Core/pull/92"},"issue":{"href":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/issues/92"},"comments":{"href":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/issues/92/comments"},"review_comments":{"href":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/pulls/92/comments"},"review_comment":{"href":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/pulls/92/commits"},"statuses":{"href":"https://api.github.com/repos/ConnectSDK/Connect-SDK-Android-Core/statuses/517585af199ac4870fcfc00191502e82e2d4148a"}}}}