{"action":"created","comment":{"url":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments/63999908","id":63999908,"diff_hunk":"@@ -375,15 +375,19 @@ defmodule URI do\n   defdelegate to_string(uri), to: String.Chars.URI\n \n   @doc ~S\"\"\"\n-  Merges two URIs as per RFC 3986 §5.2\n+  Merges two URIs.\n+\n+  This function merges two URIs as per [RFC\n+  3986](https://www.ietf.org/rfc/rfc3986.txt) §5.2.\n \n   ## Examples\n \n-      iex> URI.merge(URI.parse(\"http://google.com\"), \"/query\") |> to_string\n+      iex> URI.merge(URI.parse(\"http://google.com\"), \"/query\") |> to_string()\n       \"http://google.com/query\"\n \n-      iex> URI.merge(\"http://example.com\", \"http://google.com\")|> to_string\n+      iex> URI.merge(\"http://example.com\", \"http://google.com\")|> to_string()","path":"lib/elixir/lib/uri.ex","position":17,"original_position":17,"commit_id":"8b3703111551d9c16894af2118d9f3911d2efb18","original_commit_id":"8b3703111551d9c16894af2118d9f3911d2efb18","user":{"login":"josevalim","id":9582,"avatar_url":"https://avatars.githubusercontent.com/u/9582?v=3","gravatar_id":"","url":"https://api.github.com/users/josevalim","html_url":"https://github.com/josevalim","followers_url":"https://api.github.com/users/josevalim/followers","following_url":"https://api.github.com/users/josevalim/following{/other_user}","gists_url":"https://api.github.com/users/josevalim/gists{/gist_id}","starred_url":"https://api.github.com/users/josevalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josevalim/subscriptions","organizations_url":"https://api.github.com/users/josevalim/orgs","repos_url":"https://api.github.com/users/josevalim/repos","events_url":"https://api.github.com/users/josevalim/events{/privacy}","received_events_url":"https://api.github.com/users/josevalim/received_events","type":"User","site_admin":false},"body":"Btw, those calls will not warn. We will only warn if a variable becomes a function call, which is not possible in the case above.","created_at":"2016-05-20T07:12:00Z","updated_at":"2016-05-20T07:12:00Z","html_url":"https://github.com/elixir-lang/elixir/pull/4654#discussion_r63999908","pull_request_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/4654","_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments/63999908"},"html":{"href":"https://github.com/elixir-lang/elixir/pull/4654#discussion_r63999908"},"pull_request":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/4654"}}},"pull_request":{"url":"https://api.github.com/repos/elixir-lang/elixir/pulls/4654","id":70810467,"html_url":"https://github.com/elixir-lang/elixir/pull/4654","diff_url":"https://github.com/elixir-lang/elixir/pull/4654.diff","patch_url":"https://github.com/elixir-lang/elixir/pull/4654.patch","issue_url":"https://api.github.com/repos/elixir-lang/elixir/issues/4654","number":4654,"state":"open","locked":false,"title":"Polish docs for URI.merge/2 and fix a bunch of future warnings","user":{"login":"whatyouhide","id":3890250,"avatar_url":"https://avatars.githubusercontent.com/u/3890250?v=3","gravatar_id":"","url":"https://api.github.com/users/whatyouhide","html_url":"https://github.com/whatyouhide","followers_url":"https://api.github.com/users/whatyouhide/followers","following_url":"https://api.github.com/users/whatyouhide/following{/other_user}","gists_url":"https://api.github.com/users/whatyouhide/gists{/gist_id}","starred_url":"https://api.github.com/users/whatyouhide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatyouhide/subscriptions","organizations_url":"https://api.github.com/users/whatyouhide/orgs","repos_url":"https://api.github.com/users/whatyouhide/repos","events_url":"https://api.github.com/users/whatyouhide/events{/privacy}","received_events_url":"https://api.github.com/users/whatyouhide/received_events","type":"User","site_admin":false},"body":"I added parens to a bunch of parens-less `to_string/1` calls that will warn in Elixir v1.4.","created_at":"2016-05-20T07:09:54Z","updated_at":"2016-05-20T07:12:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd75f957d0ac78f0a677ad28d08222eaca599aed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/4654/commits","review_comments_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/4654/comments","review_comment_url":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/issues/4654/comments","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/8b3703111551d9c16894af2118d9f3911d2efb18","head":{"label":"whatyouhide:uri-merge-docs","ref":"uri-merge-docs","sha":"8b3703111551d9c16894af2118d9f3911d2efb18","user":{"login":"whatyouhide","id":3890250,"avatar_url":"https://avatars.githubusercontent.com/u/3890250?v=3","gravatar_id":"","url":"https://api.github.com/users/whatyouhide","html_url":"https://github.com/whatyouhide","followers_url":"https://api.github.com/users/whatyouhide/followers","following_url":"https://api.github.com/users/whatyouhide/following{/other_user}","gists_url":"https://api.github.com/users/whatyouhide/gists{/gist_id}","starred_url":"https://api.github.com/users/whatyouhide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatyouhide/subscriptions","organizations_url":"https://api.github.com/users/whatyouhide/orgs","repos_url":"https://api.github.com/users/whatyouhide/repos","events_url":"https://api.github.com/users/whatyouhide/events{/privacy}","received_events_url":"https://api.github.com/users/whatyouhide/received_events","type":"User","site_admin":false},"repo":{"id":27794017,"name":"elixir","full_name":"whatyouhide/elixir","owner":{"login":"whatyouhide","id":3890250,"avatar_url":"https://avatars.githubusercontent.com/u/3890250?v=3","gravatar_id":"","url":"https://api.github.com/users/whatyouhide","html_url":"https://github.com/whatyouhide","followers_url":"https://api.github.com/users/whatyouhide/followers","following_url":"https://api.github.com/users/whatyouhide/following{/other_user}","gists_url":"https://api.github.com/users/whatyouhide/gists{/gist_id}","starred_url":"https://api.github.com/users/whatyouhide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatyouhide/subscriptions","organizations_url":"https://api.github.com/users/whatyouhide/orgs","repos_url":"https://api.github.com/users/whatyouhide/repos","events_url":"https://api.github.com/users/whatyouhide/events{/privacy}","received_events_url":"https://api.github.com/users/whatyouhide/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whatyouhide/elixir","description":"Elixir is a dynamic, functional language designed for building scalable and maintainable applications","fork":true,"url":"https://api.github.com/repos/whatyouhide/elixir","forks_url":"https://api.github.com/repos/whatyouhide/elixir/forks","keys_url":"https://api.github.com/repos/whatyouhide/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whatyouhide/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whatyouhide/elixir/teams","hooks_url":"https://api.github.com/repos/whatyouhide/elixir/hooks","issue_events_url":"https://api.github.com/repos/whatyouhide/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/whatyouhide/elixir/events","assignees_url":"https://api.github.com/repos/whatyouhide/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/whatyouhide/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/whatyouhide/elixir/tags","blobs_url":"https://api.github.com/repos/whatyouhide/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whatyouhide/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whatyouhide/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/whatyouhide/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whatyouhide/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/whatyouhide/elixir/languages","stargazers_url":"https://api.github.com/repos/whatyouhide/elixir/stargazers","contributors_url":"https://api.github.com/repos/whatyouhide/elixir/contributors","subscribers_url":"https://api.github.com/repos/whatyouhide/elixir/subscribers","subscription_url":"https://api.github.com/repos/whatyouhide/elixir/subscription","commits_url":"https://api.github.com/repos/whatyouhide/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/whatyouhide/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/whatyouhide/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/whatyouhide/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/whatyouhide/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/whatyouhide/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whatyouhide/elixir/merges","archive_url":"https://api.github.com/repos/whatyouhide/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whatyouhide/elixir/downloads","issues_url":"https://api.github.com/repos/whatyouhide/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/whatyouhide/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/whatyouhide/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/whatyouhide/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whatyouhide/elixir/labels{/name}","releases_url":"https://api.github.com/repos/whatyouhide/elixir/releases{/id}","deployments_url":"https://api.github.com/repos/whatyouhide/elixir/deployments","created_at":"2014-12-10T00:12:42Z","updated_at":"2015-02-14T09:28:19Z","pushed_at":"2016-05-20T07:09:39Z","git_url":"git://github.com/whatyouhide/elixir.git","ssh_url":"git@github.com:whatyouhide/elixir.git","clone_url":"https://github.com/whatyouhide/elixir.git","svn_url":"https://github.com/whatyouhide/elixir","homepage":"http://elixir-lang.org/","size":34855,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elixir-lang:master","ref":"master","sha":"21ab40a49d7b76da1229fd6151100a1dae78af6e","user":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":1234714,"name":"elixir","full_name":"elixir-lang/elixir","owner":{"login":"elixir-lang","id":1481354,"avatar_url":"https://avatars.githubusercontent.com/u/1481354?v=3","gravatar_id":"","url":"https://api.github.com/users/elixir-lang","html_url":"https://github.com/elixir-lang","followers_url":"https://api.github.com/users/elixir-lang/followers","following_url":"https://api.github.com/users/elixir-lang/following{/other_user}","gists_url":"https://api.github.com/users/elixir-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/elixir-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elixir-lang/subscriptions","organizations_url":"https://api.github.com/users/elixir-lang/orgs","repos_url":"https://api.github.com/users/elixir-lang/repos","events_url":"https://api.github.com/users/elixir-lang/events{/privacy}","received_events_url":"https://api.github.com/users/elixir-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elixir-lang/elixir","description":"Elixir is a dynamic, functional language designed for building scalable and maintainable applications","fork":false,"url":"https://api.github.com/repos/elixir-lang/elixir","forks_url":"https://api.github.com/repos/elixir-lang/elixir/forks","keys_url":"https://api.github.com/repos/elixir-lang/elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elixir-lang/elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elixir-lang/elixir/teams","hooks_url":"https://api.github.com/repos/elixir-lang/elixir/hooks","issue_events_url":"https://api.github.com/repos/elixir-lang/elixir/issues/events{/number}","events_url":"https://api.github.com/repos/elixir-lang/elixir/events","assignees_url":"https://api.github.com/repos/elixir-lang/elixir/assignees{/user}","branches_url":"https://api.github.com/repos/elixir-lang/elixir/branches{/branch}","tags_url":"https://api.github.com/repos/elixir-lang/elixir/tags","blobs_url":"https://api.github.com/repos/elixir-lang/elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elixir-lang/elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elixir-lang/elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/elixir-lang/elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elixir-lang/elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/elixir-lang/elixir/languages","stargazers_url":"https://api.github.com/repos/elixir-lang/elixir/stargazers","contributors_url":"https://api.github.com/repos/elixir-lang/elixir/contributors","subscribers_url":"https://api.github.com/repos/elixir-lang/elixir/subscribers","subscription_url":"https://api.github.com/repos/elixir-lang/elixir/subscription","commits_url":"https://api.github.com/repos/elixir-lang/elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/elixir-lang/elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/elixir-lang/elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/elixir-lang/elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/elixir-lang/elixir/contents/{+path}","compare_url":"https://api.github.com/repos/elixir-lang/elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elixir-lang/elixir/merges","archive_url":"https://api.github.com/repos/elixir-lang/elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elixir-lang/elixir/downloads","issues_url":"https://api.github.com/repos/elixir-lang/elixir/issues{/number}","pulls_url":"https://api.github.com/repos/elixir-lang/elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/elixir-lang/elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/elixir-lang/elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elixir-lang/elixir/labels{/name}","releases_url":"https://api.github.com/repos/elixir-lang/elixir/releases{/id}","deployments_url":"https://api.github.com/repos/elixir-lang/elixir/deployments","created_at":"2011-01-09T08:43:57Z","updated_at":"2016-05-20T05:57:11Z","pushed_at":"2016-05-20T07:09:54Z","git_url":"git://github.com/elixir-lang/elixir.git","ssh_url":"git@github.com:elixir-lang/elixir.git","clone_url":"https://github.com/elixir-lang/elixir.git","svn_url":"https://github.com/elixir-lang/elixir","homepage":"http://elixir-lang.org/","size":43432,"stargazers_count":6997,"watchers_count":6997,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":966,"mirror_url":null,"open_issues_count":31,"forks":966,"open_issues":31,"watchers":6997,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/4654"},"html":{"href":"https://github.com/elixir-lang/elixir/pull/4654"},"issue":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/4654"},"comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/issues/4654/comments"},"review_comments":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/4654/comments"},"review_comment":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elixir-lang/elixir/pulls/4654/commits"},"statuses":{"href":"https://api.github.com/repos/elixir-lang/elixir/statuses/8b3703111551d9c16894af2118d9f3911d2efb18"}}}}
{"actor":{"display_login":"josevalim"}}