{"action":"created","comment":{"url":"https://api.github.com/repos/Eyescale/Lunchbox/pulls/comments/85759575","pull_request_review_id":6455716,"id":85759575,"diff_hunk":"@@ -18,10 +18,15 @@\n \n namespace lunchbox\n {\n-template< class T > Buffer< T >::Buffer( Buffer< T >& from )\n+template< class T > Buffer< T >::Buffer( const Buffer< T >& from )\n {\n-    _data = from._data; _size = from._size; _maxSize = from._maxSize;\n-    from._data = 0; from._size = 0; from._maxSize = 0;\n+    *this = from;","path":"lunchbox/buffer.ipp","position":18,"original_position":18,"commit_id":"06435f734d8c45df8ecc76ddb1ef700e801d624b","original_commit_id":"06435f734d8c45df8ecc76ddb1ef700e801d624b","user":{"login":"eile","id":354947,"avatar_url":"https://avatars.githubusercontent.com/u/354947?v=3","gravatar_id":"","url":"https://api.github.com/users/eile","html_url":"https://github.com/eile","followers_url":"https://api.github.com/users/eile/followers","following_url":"https://api.github.com/users/eile/following{/other_user}","gists_url":"https://api.github.com/users/eile/gists{/gist_id}","starred_url":"https://api.github.com/users/eile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eile/subscriptions","organizations_url":"https://api.github.com/users/eile/orgs","repos_url":"https://api.github.com/users/eile/repos","events_url":"https://api.github.com/users/eile/events{/privacy}","received_events_url":"https://api.github.com/users/eile/received_events","type":"User","site_admin":false},"body":"how so? operator = () calls replace which does a memcpy.","created_at":"2016-10-31T15:14:20Z","updated_at":"2016-10-31T15:14:20Z","html_url":"https://github.com/Eyescale/Lunchbox/pull/280#discussion_r85759575","pull_request_url":"https://api.github.com/repos/Eyescale/Lunchbox/pulls/280","_links":{"self":{"href":"https://api.github.com/repos/Eyescale/Lunchbox/pulls/comments/85759575"},"html":{"href":"https://github.com/Eyescale/Lunchbox/pull/280#discussion_r85759575"},"pull_request":{"href":"https://api.github.com/repos/Eyescale/Lunchbox/pulls/280"}}},"pull_request":{"url":"https://api.github.com/repos/Eyescale/Lunchbox/pulls/280","id":91014332,"html_url":"https://github.com/Eyescale/Lunchbox/pull/280","diff_url":"https://github.com/Eyescale/Lunchbox/pull/280.diff","patch_url":"https://github.com/Eyescale/Lunchbox/pull/280.patch","issue_url":"https://api.github.com/repos/Eyescale/Lunchbox/issues/280","number":280,"state":"open","locked":false,"title":"Use some C++11","user":{"login":"eile","id":354947,"avatar_url":"https://avatars.githubusercontent.com/u/354947?v=3","gravatar_id":"","url":"https://api.github.com/users/eile","html_url":"https://github.com/eile","followers_url":"https://api.github.com/users/eile/followers","following_url":"https://api.github.com/users/eile/following{/other_user}","gists_url":"https://api.github.com/users/eile/gists{/gist_id}","starred_url":"https://api.github.com/users/eile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eile/subscriptions","organizations_url":"https://api.github.com/users/eile/orgs","repos_url":"https://api.github.com/users/eile/repos","events_url":"https://api.github.com/users/eile/events{/privacy}","received_events_url":"https://api.github.com/users/eile/received_events","type":"User","site_admin":false},"body":null,"created_at":"2016-10-26T14:21:15Z","updated_at":"2016-10-31T15:14:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f47bba2bed8e0a930ab003a3608cae9b5c7ecd55","assignee":{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars.githubusercontent.com/u/701401?v=3","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},"assignees":[{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars.githubusercontent.com/u/701401?v=3","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},{"login":"hernando","id":791427,"avatar_url":"https://avatars.githubusercontent.com/u/791427?v=3","gravatar_id":"","url":"https://api.github.com/users/hernando","html_url":"https://github.com/hernando","followers_url":"https://api.github.com/users/hernando/followers","following_url":"https://api.github.com/users/hernando/following{/other_user}","gists_url":"https://api.github.com/users/hernando/gists{/gist_id}","starred_url":"https://api.github.com/users/hernando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hernando/subscriptions","organizations_url":"https://api.github.com/users/hernando/orgs","repos_url":"https://api.github.com/users/hernando/repos","events_url":"https://api.github.com/users/hernando/events{/privacy}","received_events_url":"https://api.github.com/users/hernando/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Eyescale/Lunchbox/pulls/280/commits","review_comments_url":"https://api.github.com/repos/Eyescale/Lunchbox/pulls/280/comments","review_comment_url":"https://api.github.com/repos/Eyescale/Lunchbox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Eyescale/Lunchbox/issues/280/comments","statuses_url":"https://api.github.com/repos/Eyescale/Lunchbox/statuses/06435f734d8c45df8ecc76ddb1ef700e801d624b","head":{"label":"eile:master","ref":"master","sha":"06435f734d8c45df8ecc76ddb1ef700e801d624b","user":{"login":"eile","id":354947,"avatar_url":"https://avatars.githubusercontent.com/u/354947?v=3","gravatar_id":"","url":"https://api.github.com/users/eile","html_url":"https://github.com/eile","followers_url":"https://api.github.com/users/eile/followers","following_url":"https://api.github.com/users/eile/following{/other_user}","gists_url":"https://api.github.com/users/eile/gists{/gist_id}","starred_url":"https://api.github.com/users/eile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eile/subscriptions","organizations_url":"https://api.github.com/users/eile/orgs","repos_url":"https://api.github.com/users/eile/repos","events_url":"https://api.github.com/users/eile/events{/privacy}","received_events_url":"https://api.github.com/users/eile/received_events","type":"User","site_admin":false},"repo":{"id":13585320,"name":"Lunchbox","full_name":"eile/Lunchbox","owner":{"login":"eile","id":354947,"avatar_url":"https://avatars.githubusercontent.com/u/354947?v=3","gravatar_id":"","url":"https://api.github.com/users/eile","html_url":"https://github.com/eile","followers_url":"https://api.github.com/users/eile/followers","following_url":"https://api.github.com/users/eile/following{/other_user}","gists_url":"https://api.github.com/users/eile/gists{/gist_id}","starred_url":"https://api.github.com/users/eile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eile/subscriptions","organizations_url":"https://api.github.com/users/eile/orgs","repos_url":"https://api.github.com/users/eile/repos","events_url":"https://api.github.com/users/eile/events{/privacy}","received_events_url":"https://api.github.com/users/eile/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eile/Lunchbox","description":"Your toolbox, since the free lunch is over: a C++ library for multi-threaded programming","fork":true,"url":"https://api.github.com/repos/eile/Lunchbox","forks_url":"https://api.github.com/repos/eile/Lunchbox/forks","keys_url":"https://api.github.com/repos/eile/Lunchbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eile/Lunchbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eile/Lunchbox/teams","hooks_url":"https://api.github.com/repos/eile/Lunchbox/hooks","issue_events_url":"https://api.github.com/repos/eile/Lunchbox/issues/events{/number}","events_url":"https://api.github.com/repos/eile/Lunchbox/events","assignees_url":"https://api.github.com/repos/eile/Lunchbox/assignees{/user}","branches_url":"https://api.github.com/repos/eile/Lunchbox/branches{/branch}","tags_url":"https://api.github.com/repos/eile/Lunchbox/tags","blobs_url":"https://api.github.com/repos/eile/Lunchbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eile/Lunchbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eile/Lunchbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/eile/Lunchbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eile/Lunchbox/statuses/{sha}","languages_url":"https://api.github.com/repos/eile/Lunchbox/languages","stargazers_url":"https://api.github.com/repos/eile/Lunchbox/stargazers","contributors_url":"https://api.github.com/repos/eile/Lunchbox/contributors","subscribers_url":"https://api.github.com/repos/eile/Lunchbox/subscribers","subscription_url":"https://api.github.com/repos/eile/Lunchbox/subscription","commits_url":"https://api.github.com/repos/eile/Lunchbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/eile/Lunchbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/eile/Lunchbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/eile/Lunchbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/eile/Lunchbox/contents/{+path}","compare_url":"https://api.github.com/repos/eile/Lunchbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eile/Lunchbox/merges","archive_url":"https://api.github.com/repos/eile/Lunchbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eile/Lunchbox/downloads","issues_url":"https://api.github.com/repos/eile/Lunchbox/issues{/number}","pulls_url":"https://api.github.com/repos/eile/Lunchbox/pulls{/number}","milestones_url":"https://api.github.com/repos/eile/Lunchbox/milestones{/number}","notifications_url":"https://api.github.com/repos/eile/Lunchbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eile/Lunchbox/labels{/name}","releases_url":"https://api.github.com/repos/eile/Lunchbox/releases{/id}","deployments_url":"https://api.github.com/repos/eile/Lunchbox/deployments","created_at":"2013-10-15T09:07:02Z","updated_at":"2015-05-08T14:24:47Z","pushed_at":"2016-10-31T14:02:10Z","git_url":"git://github.com/eile/Lunchbox.git","ssh_url":"git@github.com:eile/Lunchbox.git","clone_url":"https://github.com/eile/Lunchbox.git","svn_url":"https://github.com/eile/Lunchbox","homepage":"http://pogl.wordpress.com/category/lunchbox/","size":35194,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Eyescale:master","ref":"master","sha":"585720d47a6f92fc7ab9a3e0a82e7ae4a86d5dfd","user":{"login":"Eyescale","id":354955,"avatar_url":"https://avatars.githubusercontent.com/u/354955?v=3","gravatar_id":"","url":"https://api.github.com/users/Eyescale","html_url":"https://github.com/Eyescale","followers_url":"https://api.github.com/users/Eyescale/followers","following_url":"https://api.github.com/users/Eyescale/following{/other_user}","gists_url":"https://api.github.com/users/Eyescale/gists{/gist_id}","starred_url":"https://api.github.com/users/Eyescale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eyescale/subscriptions","organizations_url":"https://api.github.com/users/Eyescale/orgs","repos_url":"https://api.github.com/users/Eyescale/repos","events_url":"https://api.github.com/users/Eyescale/events{/privacy}","received_events_url":"https://api.github.com/users/Eyescale/received_events","type":"Organization","site_admin":false},"repo":{"id":3708760,"name":"Lunchbox","full_name":"Eyescale/Lunchbox","owner":{"login":"Eyescale","id":354955,"avatar_url":"https://avatars.githubusercontent.com/u/354955?v=3","gravatar_id":"","url":"https://api.github.com/users/Eyescale","html_url":"https://github.com/Eyescale","followers_url":"https://api.github.com/users/Eyescale/followers","following_url":"https://api.github.com/users/Eyescale/following{/other_user}","gists_url":"https://api.github.com/users/Eyescale/gists{/gist_id}","starred_url":"https://api.github.com/users/Eyescale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eyescale/subscriptions","organizations_url":"https://api.github.com/users/Eyescale/orgs","repos_url":"https://api.github.com/users/Eyescale/repos","events_url":"https://api.github.com/users/Eyescale/events{/privacy}","received_events_url":"https://api.github.com/users/Eyescale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Eyescale/Lunchbox","description":"Your toolbox, since the free lunch is over: a C++ library for multi-threaded programming","fork":false,"url":"https://api.github.com/repos/Eyescale/Lunchbox","forks_url":"https://api.github.com/repos/Eyescale/Lunchbox/forks","keys_url":"https://api.github.com/repos/Eyescale/Lunchbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Eyescale/Lunchbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Eyescale/Lunchbox/teams","hooks_url":"https://api.github.com/repos/Eyescale/Lunchbox/hooks","issue_events_url":"https://api.github.com/repos/Eyescale/Lunchbox/issues/events{/number}","events_url":"https://api.github.com/repos/Eyescale/Lunchbox/events","assignees_url":"https://api.github.com/repos/Eyescale/Lunchbox/assignees{/user}","branches_url":"https://api.github.com/repos/Eyescale/Lunchbox/branches{/branch}","tags_url":"https://api.github.com/repos/Eyescale/Lunchbox/tags","blobs_url":"https://api.github.com/repos/Eyescale/Lunchbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Eyescale/Lunchbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Eyescale/Lunchbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/Eyescale/Lunchbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Eyescale/Lunchbox/statuses/{sha}","languages_url":"https://api.github.com/repos/Eyescale/Lunchbox/languages","stargazers_url":"https://api.github.com/repos/Eyescale/Lunchbox/stargazers","contributors_url":"https://api.github.com/repos/Eyescale/Lunchbox/contributors","subscribers_url":"https://api.github.com/repos/Eyescale/Lunchbox/subscribers","subscription_url":"https://api.github.com/repos/Eyescale/Lunchbox/subscription","commits_url":"https://api.github.com/repos/Eyescale/Lunchbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/Eyescale/Lunchbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/Eyescale/Lunchbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/Eyescale/Lunchbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/Eyescale/Lunchbox/contents/{+path}","compare_url":"https://api.github.com/repos/Eyescale/Lunchbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Eyescale/Lunchbox/merges","archive_url":"https://api.github.com/repos/Eyescale/Lunchbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Eyescale/Lunchbox/downloads","issues_url":"https://api.github.com/repos/Eyescale/Lunchbox/issues{/number}","pulls_url":"https://api.github.com/repos/Eyescale/Lunchbox/pulls{/number}","milestones_url":"https://api.github.com/repos/Eyescale/Lunchbox/milestones{/number}","notifications_url":"https://api.github.com/repos/Eyescale/Lunchbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Eyescale/Lunchbox/labels{/name}","releases_url":"https://api.github.com/repos/Eyescale/Lunchbox/releases{/id}","deployments_url":"https://api.github.com/repos/Eyescale/Lunchbox/deployments","created_at":"2012-03-13T16:38:51Z","updated_at":"2016-10-31T13:44:03Z","pushed_at":"2016-10-31T14:02:10Z","git_url":"git://github.com/Eyescale/Lunchbox.git","ssh_url":"git@github.com:Eyescale/Lunchbox.git","clone_url":"https://github.com/Eyescale/Lunchbox.git","svn_url":"https://github.com/Eyescale/Lunchbox","homepage":"http://pogl.wordpress.com/category/lunchbox/","size":35342,"stargazers_count":25,"watchers_count":25,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":5,"forks":26,"open_issues":5,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Eyescale/Lunchbox/pulls/280"},"html":{"href":"https://github.com/Eyescale/Lunchbox/pull/280"},"issue":{"href":"https://api.github.com/repos/Eyescale/Lunchbox/issues/280"},"comments":{"href":"https://api.github.com/repos/Eyescale/Lunchbox/issues/280/comments"},"review_comments":{"href":"https://api.github.com/repos/Eyescale/Lunchbox/pulls/280/comments"},"review_comment":{"href":"https://api.github.com/repos/Eyescale/Lunchbox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Eyescale/Lunchbox/pulls/280/commits"},"statuses":{"href":"https://api.github.com/repos/Eyescale/Lunchbox/statuses/06435f734d8c45df8ecc76ddb1ef700e801d624b"}}}}
{"actor":{"display_login":"eile"}}