{"action":"created","issue":{"url":"https://api.github.com/repos/shama/bel/issues/26","repository_url":"https://api.github.com/repos/shama/bel","labels_url":"https://api.github.com/repos/shama/bel/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/shama/bel/issues/26/comments","events_url":"https://api.github.com/repos/shama/bel/issues/26/events","html_url":"https://github.com/shama/bel/issues/26","id":157027673,"number":26,"title":"Network requests on each render","user":{"login":"arturi","id":1199054,"avatar_url":"https://avatars.githubusercontent.com/u/1199054?v=3","gravatar_id":"","url":"https://api.github.com/users/arturi","html_url":"https://github.com/arturi","followers_url":"https://api.github.com/users/arturi/followers","following_url":"https://api.github.com/users/arturi/following{/other_user}","gists_url":"https://api.github.com/users/arturi/gists{/gist_id}","starred_url":"https://api.github.com/users/arturi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arturi/subscriptions","organizations_url":"https://api.github.com/users/arturi/orgs","repos_url":"https://api.github.com/users/arturi/repos","events_url":"https://api.github.com/users/arturi/events{/privacy}","received_events_url":"https://api.github.com/users/arturi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2016-05-26T16:42:09Z","updated_at":"2016-09-10T15:58:34Z","closed_at":null,"body":"Hi! Thanks for the module.\r\n\r\nI have an example here: http://requirebin.com/?gist=f2a99cc27c465ed51eb8159830836ca4. In it, each time I call `update` and `bel` creates a new element, a local network request is made for the base64 inlined image, even though it did not change.\r\n\r\nShould this be happening? I guess it makes sense, new element is created, `bel` is fetching it’s content. But that results in a poor performance — when I add a relatively large image, like 3mb, the Chrome browser tab can barely function and the interface becomes unusable. \r\n\r\nTo reproduce: navigate to http://uppy.io/examples/modal/index.html, click “open modal” and drag two files to the dragdrop area. Open network tab, click “upload”.\r\n\r\nWhat am I doing wrong? Thank you!"},"comment":{"url":"https://api.github.com/repos/shama/bel/issues/comments/246119566","html_url":"https://github.com/shama/bel/issues/26#issuecomment-246119566","issue_url":"https://api.github.com/repos/shama/bel/issues/26","id":246119566,"user":{"login":"yoshuawuyts","id":2467194,"avatar_url":"https://avatars.githubusercontent.com/u/2467194?v=3","gravatar_id":"","url":"https://api.github.com/users/yoshuawuyts","html_url":"https://github.com/yoshuawuyts","followers_url":"https://api.github.com/users/yoshuawuyts/followers","following_url":"https://api.github.com/users/yoshuawuyts/following{/other_user}","gists_url":"https://api.github.com/users/yoshuawuyts/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshuawuyts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshuawuyts/subscriptions","organizations_url":"https://api.github.com/users/yoshuawuyts/orgs","repos_url":"https://api.github.com/users/yoshuawuyts/repos","events_url":"https://api.github.com/users/yoshuawuyts/events{/privacy}","received_events_url":"https://api.github.com/users/yoshuawuyts/received_events","type":"User","site_admin":false},"created_at":"2016-09-10T15:58:34Z","updated_at":"2016-09-10T15:58:34Z","body":"Waiting on patrick-steele-idem/morphdom#77 to be published; made a demo on how to create widgets with the isSameNode() API here: shama/on-load#10 (comment) (e.g. thunking!)\r\n\r\nThat patch should fix this issue :tada:"}}
{"actor":{"display_login":"yoshuawuyts"}}