{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23427","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23427/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23427/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23427/events","html_url":"https://github.com/kubernetes/kubernetes/pull/23427","id":143215987,"number":23427,"title":"Migrate to the new conversion generator - part1","user":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"c7def8"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00"}],"state":"open","locked":false,"assignee":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-03-24T10:56:52Z","updated_at":"2016-03-24T11:04:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/23427","html_url":"https://github.com/kubernetes/kubernetes/pull/23427","diff_url":"https://github.com/kubernetes/kubernetes/pull/23427.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/23427.patch"},"body":"This PR contains two commits:\r\n- few more fixes to the generator\r\n- migration of the pkg/api/v1 to use the new generator\r\n\r\nThe second commit is big, but I reviewed the changes and they contain:\r\n- conversions between types that we didn't even generating conversion between\r\n- changes in how we handle maps/pointers/slices - previously we were explicitly referencing fields, now we are using \"shadowing in, out\" to make the code more generic\r\n- lack of auto-generated method for ReplicationControllerSpec (because these types are different (*int vs int for Replicas) and a preexisting conversion already exists\r\n\r\nMost of issues in the first commit (e.g. adding references to \"in\" and \"out\" for slices/maps/points) were discovered by our tests. So I'm pretty confident that this change is correct now."},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/200788547","html_url":"https://github.com/kubernetes/kubernetes/pull/23427#issuecomment-200788547","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/23427","id":200788547,"user":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars.githubusercontent.com/u/13653959?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2016-03-24T11:04:48Z","updated_at":"2016-03-24T11:04:48Z","body":"Labelling this PR as size/M"}}