{"push_id":1329893639,"size":1,"distinct_size":1,"ref":"refs/heads/branch-1.0.x","head":"40637ef8fc773dc47882334fcee760bbffcd09b4","before":"77769ad557ebe41633ca589d8d4e5e39494bf1cc","commits":[{"sha":"40637ef8fc773dc47882334fcee760bbffcd09b4","author":{"name":"Todd Lipcon","email":"dd5965a1ccaca30b2dd5053f256a6d9b88ca567f@apache.org"},"message":"cache: fix behavior on single-CPU systems\n\nOn a system with only a single CPU, shard_bits_ would be set to 0. This\nwould then result in calculating 'hash >> (32 - 0)' which is undefined\nbehavior. With optimizations, this would turn into a no-op, and we'd end\nup using the whole hash as the shard index, instead of 0, causing a\ncrash.\n\nThe fix is to widen the hash to uint64_t before shifting.\n\nTested by manually making NumCPUs return 1 and running cache-test.\n\nChange-Id: I7809e5697df657a589b2ceae5c6d4edbf161b52a\nReviewed-on: http://gerrit.cloudera.org:8080/4535\nTested-by: Kudu Jenkins\nReviewed-by: Adar Dembo <adar@cloudera.com>\n(cherry picked from commit 69e65780843040c085ca34901803b97b59595c0e)\nReviewed-on: http://gerrit.cloudera.org:8080/4608\nReviewed-by: Todd Lipcon <todd@apache.org>","distinct":true,"url":"https://api.github.com/repos/cloudera/kudu/commits/40637ef8fc773dc47882334fcee760bbffcd09b4"}]}
{"actor":{"display_login":"cloudera-gerrit"}}