{"action":"created","comment":{"url":"https://api.github.com/repos/asilvas/node-image-steam/pulls/comments/83739476","pull_request_review_id":4563548,"id":83739476,"diff_hunk":"@@ -109,6 +126,15 @@ p.getInfo = function(req) {\n     }\n   }\n \n+  // forward original image if no operation on image and browser support image format\n+  if (routeInfo.imageSteps.length === 0 && this.options.ifNoOperation && this.options.ifNoOperation.justForward === true) {","path":"lib/router/router.js","position":29,"original_position":29,"commit_id":"56a8e3714784d55a760006133b4aa03c2187d393","original_commit_id":"56a8e3714784d55a760006133b4aa03c2187d393","user":{"login":"asilvas","id":981007,"avatar_url":"https://avatars.githubusercontent.com/u/981007?v=3","gravatar_id":"","url":"https://api.github.com/users/asilvas","html_url":"https://github.com/asilvas","followers_url":"https://api.github.com/users/asilvas/followers","following_url":"https://api.github.com/users/asilvas/following{/other_user}","gists_url":"https://api.github.com/users/asilvas/gists{/gist_id}","starred_url":"https://api.github.com/users/asilvas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilvas/subscriptions","organizations_url":"https://api.github.com/users/asilvas/orgs","repos_url":"https://api.github.com/users/asilvas/repos","events_url":"https://api.github.com/users/asilvas/events{/privacy}","received_events_url":"https://api.github.com/users/asilvas/received_events","type":"User","site_admin":false},"body":"Please use `noop` query. This is consistent with the existing `useOriginal` query.\r\n\r\nhttps://github.com/asilvas/node-image-steam/blob/master/lib/http/connect.js#L138","created_at":"2016-10-17T21:35:20Z","updated_at":"2016-10-17T21:35:20Z","html_url":"https://github.com/asilvas/node-image-steam/pull/45#discussion_r83739476","pull_request_url":"https://api.github.com/repos/asilvas/node-image-steam/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/asilvas/node-image-steam/pulls/comments/83739476"},"html":{"href":"https://github.com/asilvas/node-image-steam/pull/45#discussion_r83739476"},"pull_request":{"href":"https://api.github.com/repos/asilvas/node-image-steam/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/asilvas/node-image-steam/pulls/45","id":89699687,"html_url":"https://github.com/asilvas/node-image-steam/pull/45","diff_url":"https://github.com/asilvas/node-image-steam/pull/45.diff","patch_url":"https://github.com/asilvas/node-image-steam/pull/45.patch","issue_url":"https://api.github.com/repos/asilvas/node-image-steam/issues/45","number":45,"state":"open","locked":false,"title":"Allow send original image if no operation is required and browser supports the format","user":{"login":"surfdude75","id":13541229,"avatar_url":"https://avatars.githubusercontent.com/u/13541229?v=3","gravatar_id":"","url":"https://api.github.com/users/surfdude75","html_url":"https://github.com/surfdude75","followers_url":"https://api.github.com/users/surfdude75/followers","following_url":"https://api.github.com/users/surfdude75/following{/other_user}","gists_url":"https://api.github.com/users/surfdude75/gists{/gist_id}","starred_url":"https://api.github.com/users/surfdude75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surfdude75/subscriptions","organizations_url":"https://api.github.com/users/surfdude75/orgs","repos_url":"https://api.github.com/users/surfdude75/repos","events_url":"https://api.github.com/users/surfdude75/events{/privacy}","received_events_url":"https://api.github.com/users/surfdude75/received_events","type":"User","site_admin":false},"body":"All images are processed even if no operation is required.\r\nIt seems a nice default since it saves bandwidth because of the use of webp format when the browser supports it. But for some applications it waste cpu and storage resources.\r\nI added an \"ifNoOperation\" option in router options So you can set it to send the original image if no operation is required and the browser supports the image format. Content-type if defined based on path and if not possible it is defined by a default one set on options.\r\nHere is how the option is:\r\nrouter: { ifNoOperation: { justForward: true, imageTypeIfUnknown: 'image/jpeg' } }\r\n      ","created_at":"2016-10-17T20:46:48Z","updated_at":"2016-10-17T21:39:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e5c6c237eb11267bfc3e874875d00f23be040a1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/asilvas/node-image-steam/pulls/45/commits","review_comments_url":"https://api.github.com/repos/asilvas/node-image-steam/pulls/45/comments","review_comment_url":"https://api.github.com/repos/asilvas/node-image-steam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/asilvas/node-image-steam/issues/45/comments","statuses_url":"https://api.github.com/repos/asilvas/node-image-steam/statuses/56a8e3714784d55a760006133b4aa03c2187d393","head":{"label":"surfdude75:forward-if-no-operation","ref":"forward-if-no-operation","sha":"56a8e3714784d55a760006133b4aa03c2187d393","user":{"login":"surfdude75","id":13541229,"avatar_url":"https://avatars.githubusercontent.com/u/13541229?v=3","gravatar_id":"","url":"https://api.github.com/users/surfdude75","html_url":"https://github.com/surfdude75","followers_url":"https://api.github.com/users/surfdude75/followers","following_url":"https://api.github.com/users/surfdude75/following{/other_user}","gists_url":"https://api.github.com/users/surfdude75/gists{/gist_id}","starred_url":"https://api.github.com/users/surfdude75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surfdude75/subscriptions","organizations_url":"https://api.github.com/users/surfdude75/orgs","repos_url":"https://api.github.com/users/surfdude75/repos","events_url":"https://api.github.com/users/surfdude75/events{/privacy}","received_events_url":"https://api.github.com/users/surfdude75/received_events","type":"User","site_admin":false},"repo":{"id":59512911,"name":"node-image-steam","full_name":"surfdude75/node-image-steam","owner":{"login":"surfdude75","id":13541229,"avatar_url":"https://avatars.githubusercontent.com/u/13541229?v=3","gravatar_id":"","url":"https://api.github.com/users/surfdude75","html_url":"https://github.com/surfdude75","followers_url":"https://api.github.com/users/surfdude75/followers","following_url":"https://api.github.com/users/surfdude75/following{/other_user}","gists_url":"https://api.github.com/users/surfdude75/gists{/gist_id}","starred_url":"https://api.github.com/users/surfdude75/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surfdude75/subscriptions","organizations_url":"https://api.github.com/users/surfdude75/orgs","repos_url":"https://api.github.com/users/surfdude75/repos","events_url":"https://api.github.com/users/surfdude75/events{/privacy}","received_events_url":"https://api.github.com/users/surfdude75/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/surfdude75/node-image-steam","description":"A simple, fast, and highly customizable on-the-fly image manipulation web server built atop Node.js","fork":true,"url":"https://api.github.com/repos/surfdude75/node-image-steam","forks_url":"https://api.github.com/repos/surfdude75/node-image-steam/forks","keys_url":"https://api.github.com/repos/surfdude75/node-image-steam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/surfdude75/node-image-steam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/surfdude75/node-image-steam/teams","hooks_url":"https://api.github.com/repos/surfdude75/node-image-steam/hooks","issue_events_url":"https://api.github.com/repos/surfdude75/node-image-steam/issues/events{/number}","events_url":"https://api.github.com/repos/surfdude75/node-image-steam/events","assignees_url":"https://api.github.com/repos/surfdude75/node-image-steam/assignees{/user}","branches_url":"https://api.github.com/repos/surfdude75/node-image-steam/branches{/branch}","tags_url":"https://api.github.com/repos/surfdude75/node-image-steam/tags","blobs_url":"https://api.github.com/repos/surfdude75/node-image-steam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/surfdude75/node-image-steam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/surfdude75/node-image-steam/git/refs{/sha}","trees_url":"https://api.github.com/repos/surfdude75/node-image-steam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/surfdude75/node-image-steam/statuses/{sha}","languages_url":"https://api.github.com/repos/surfdude75/node-image-steam/languages","stargazers_url":"https://api.github.com/repos/surfdude75/node-image-steam/stargazers","contributors_url":"https://api.github.com/repos/surfdude75/node-image-steam/contributors","subscribers_url":"https://api.github.com/repos/surfdude75/node-image-steam/subscribers","subscription_url":"https://api.github.com/repos/surfdude75/node-image-steam/subscription","commits_url":"https://api.github.com/repos/surfdude75/node-image-steam/commits{/sha}","git_commits_url":"https://api.github.com/repos/surfdude75/node-image-steam/git/commits{/sha}","comments_url":"https://api.github.com/repos/surfdude75/node-image-steam/comments{/number}","issue_comment_url":"https://api.github.com/repos/surfdude75/node-image-steam/issues/comments{/number}","contents_url":"https://api.github.com/repos/surfdude75/node-image-steam/contents/{+path}","compare_url":"https://api.github.com/repos/surfdude75/node-image-steam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/surfdude75/node-image-steam/merges","archive_url":"https://api.github.com/repos/surfdude75/node-image-steam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/surfdude75/node-image-steam/downloads","issues_url":"https://api.github.com/repos/surfdude75/node-image-steam/issues{/number}","pulls_url":"https://api.github.com/repos/surfdude75/node-image-steam/pulls{/number}","milestones_url":"https://api.github.com/repos/surfdude75/node-image-steam/milestones{/number}","notifications_url":"https://api.github.com/repos/surfdude75/node-image-steam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/surfdude75/node-image-steam/labels{/name}","releases_url":"https://api.github.com/repos/surfdude75/node-image-steam/releases{/id}","deployments_url":"https://api.github.com/repos/surfdude75/node-image-steam/deployments","created_at":"2016-05-23T19:37:20Z","updated_at":"2016-05-23T19:37:22Z","pushed_at":"2016-10-17T20:21:53Z","git_url":"git://github.com/surfdude75/node-image-steam.git","ssh_url":"git@github.com:surfdude75/node-image-steam.git","clone_url":"https://github.com/surfdude75/node-image-steam.git","svn_url":"https://github.com/surfdude75/node-image-steam","homepage":"","size":6457,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"asilvas:master","ref":"master","sha":"83b7d4943f655140f2ca74dc05c6b172a72f54d0","user":{"login":"asilvas","id":981007,"avatar_url":"https://avatars.githubusercontent.com/u/981007?v=3","gravatar_id":"","url":"https://api.github.com/users/asilvas","html_url":"https://github.com/asilvas","followers_url":"https://api.github.com/users/asilvas/followers","following_url":"https://api.github.com/users/asilvas/following{/other_user}","gists_url":"https://api.github.com/users/asilvas/gists{/gist_id}","starred_url":"https://api.github.com/users/asilvas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilvas/subscriptions","organizations_url":"https://api.github.com/users/asilvas/orgs","repos_url":"https://api.github.com/users/asilvas/repos","events_url":"https://api.github.com/users/asilvas/events{/privacy}","received_events_url":"https://api.github.com/users/asilvas/received_events","type":"User","site_admin":false},"repo":{"id":39019649,"name":"node-image-steam","full_name":"asilvas/node-image-steam","owner":{"login":"asilvas","id":981007,"avatar_url":"https://avatars.githubusercontent.com/u/981007?v=3","gravatar_id":"","url":"https://api.github.com/users/asilvas","html_url":"https://github.com/asilvas","followers_url":"https://api.github.com/users/asilvas/followers","following_url":"https://api.github.com/users/asilvas/following{/other_user}","gists_url":"https://api.github.com/users/asilvas/gists{/gist_id}","starred_url":"https://api.github.com/users/asilvas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asilvas/subscriptions","organizations_url":"https://api.github.com/users/asilvas/orgs","repos_url":"https://api.github.com/users/asilvas/repos","events_url":"https://api.github.com/users/asilvas/events{/privacy}","received_events_url":"https://api.github.com/users/asilvas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asilvas/node-image-steam","description":"A simple, fast, and highly customizable on-the-fly image manipulation web server built atop Node.js","fork":false,"url":"https://api.github.com/repos/asilvas/node-image-steam","forks_url":"https://api.github.com/repos/asilvas/node-image-steam/forks","keys_url":"https://api.github.com/repos/asilvas/node-image-steam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asilvas/node-image-steam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asilvas/node-image-steam/teams","hooks_url":"https://api.github.com/repos/asilvas/node-image-steam/hooks","issue_events_url":"https://api.github.com/repos/asilvas/node-image-steam/issues/events{/number}","events_url":"https://api.github.com/repos/asilvas/node-image-steam/events","assignees_url":"https://api.github.com/repos/asilvas/node-image-steam/assignees{/user}","branches_url":"https://api.github.com/repos/asilvas/node-image-steam/branches{/branch}","tags_url":"https://api.github.com/repos/asilvas/node-image-steam/tags","blobs_url":"https://api.github.com/repos/asilvas/node-image-steam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asilvas/node-image-steam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asilvas/node-image-steam/git/refs{/sha}","trees_url":"https://api.github.com/repos/asilvas/node-image-steam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asilvas/node-image-steam/statuses/{sha}","languages_url":"https://api.github.com/repos/asilvas/node-image-steam/languages","stargazers_url":"https://api.github.com/repos/asilvas/node-image-steam/stargazers","contributors_url":"https://api.github.com/repos/asilvas/node-image-steam/contributors","subscribers_url":"https://api.github.com/repos/asilvas/node-image-steam/subscribers","subscription_url":"https://api.github.com/repos/asilvas/node-image-steam/subscription","commits_url":"https://api.github.com/repos/asilvas/node-image-steam/commits{/sha}","git_commits_url":"https://api.github.com/repos/asilvas/node-image-steam/git/commits{/sha}","comments_url":"https://api.github.com/repos/asilvas/node-image-steam/comments{/number}","issue_comment_url":"https://api.github.com/repos/asilvas/node-image-steam/issues/comments{/number}","contents_url":"https://api.github.com/repos/asilvas/node-image-steam/contents/{+path}","compare_url":"https://api.github.com/repos/asilvas/node-image-steam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asilvas/node-image-steam/merges","archive_url":"https://api.github.com/repos/asilvas/node-image-steam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asilvas/node-image-steam/downloads","issues_url":"https://api.github.com/repos/asilvas/node-image-steam/issues{/number}","pulls_url":"https://api.github.com/repos/asilvas/node-image-steam/pulls{/number}","milestones_url":"https://api.github.com/repos/asilvas/node-image-steam/milestones{/number}","notifications_url":"https://api.github.com/repos/asilvas/node-image-steam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asilvas/node-image-steam/labels{/name}","releases_url":"https://api.github.com/repos/asilvas/node-image-steam/releases{/id}","deployments_url":"https://api.github.com/repos/asilvas/node-image-steam/deployments","created_at":"2015-07-13T15:11:18Z","updated_at":"2016-09-29T17:06:55Z","pushed_at":"2016-10-17T20:46:49Z","git_url":"git://github.com/asilvas/node-image-steam.git","ssh_url":"git@github.com:asilvas/node-image-steam.git","clone_url":"https://github.com/asilvas/node-image-steam.git","svn_url":"https://github.com/asilvas/node-image-steam","homepage":"","size":6453,"stargazers_count":36,"watchers_count":36,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":12,"forks":4,"open_issues":12,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/asilvas/node-image-steam/pulls/45"},"html":{"href":"https://github.com/asilvas/node-image-steam/pull/45"},"issue":{"href":"https://api.github.com/repos/asilvas/node-image-steam/issues/45"},"comments":{"href":"https://api.github.com/repos/asilvas/node-image-steam/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/asilvas/node-image-steam/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/asilvas/node-image-steam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/asilvas/node-image-steam/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/asilvas/node-image-steam/statuses/56a8e3714784d55a760006133b4aa03c2187d393"}}}}
{"actor":{"display_login":"asilvas"}}