{"action":"created","issue":{"url":"https://api.github.com/repos/QuickBlox/quickblox-javascript-sdk/issues/130","repository_url":"https://api.github.com/repos/QuickBlox/quickblox-javascript-sdk","labels_url":"https://api.github.com/repos/QuickBlox/quickblox-javascript-sdk/issues/130/labels{/name}","comments_url":"https://api.github.com/repos/QuickBlox/quickblox-javascript-sdk/issues/130/comments","events_url":"https://api.github.com/repos/QuickBlox/quickblox-javascript-sdk/issues/130/events","html_url":"https://github.com/QuickBlox/quickblox-javascript-sdk/pull/130","id":149377328,"number":130,"title":"WIP - Sprint 2 (Node optmz.)","user":{"login":"dimaspirit","id":5120723,"avatar_url":"https://avatars.githubusercontent.com/u/5120723?v=3","gravatar_id":"","url":"https://api.github.com/users/dimaspirit","html_url":"https://github.com/dimaspirit","followers_url":"https://api.github.com/users/dimaspirit/followers","following_url":"https://api.github.com/users/dimaspirit/following{/other_user}","gists_url":"https://api.github.com/users/dimaspirit/gists{/gist_id}","starred_url":"https://api.github.com/users/dimaspirit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimaspirit/subscriptions","organizations_url":"https://api.github.com/users/dimaspirit/orgs","repos_url":"https://api.github.com/users/dimaspirit/repos","events_url":"https://api.github.com/users/dimaspirit/events{/privacy}","received_events_url":"https://api.github.com/users/dimaspirit/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"soulfly","id":373137,"avatar_url":"https://avatars.githubusercontent.com/u/373137?v=3","gravatar_id":"","url":"https://api.github.com/users/soulfly","html_url":"https://github.com/soulfly","followers_url":"https://api.github.com/users/soulfly/followers","following_url":"https://api.github.com/users/soulfly/following{/other_user}","gists_url":"https://api.github.com/users/soulfly/gists{/gist_id}","starred_url":"https://api.github.com/users/soulfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soulfly/subscriptions","organizations_url":"https://api.github.com/users/soulfly/orgs","repos_url":"https://api.github.com/users/soulfly/repos","events_url":"https://api.github.com/users/soulfly/events{/privacy}","received_events_url":"https://api.github.com/users/soulfly/received_events","type":"User","site_admin":false},"assignees":[{"login":"soulfly","id":373137,"avatar_url":"https://avatars.githubusercontent.com/u/373137?v=3","gravatar_id":"","url":"https://api.github.com/users/soulfly","html_url":"https://github.com/soulfly","followers_url":"https://api.github.com/users/soulfly/followers","following_url":"https://api.github.com/users/soulfly/following{/other_user}","gists_url":"https://api.github.com/users/soulfly/gists{/gist_id}","starred_url":"https://api.github.com/users/soulfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soulfly/subscriptions","organizations_url":"https://api.github.com/users/soulfly/orgs","repos_url":"https://api.github.com/users/soulfly/repos","events_url":"https://api.github.com/users/soulfly/events{/privacy}","received_events_url":"https://api.github.com/users/soulfly/received_events","type":"User","site_admin":false},{"login":"dimaspirit","id":5120723,"avatar_url":"https://avatars.githubusercontent.com/u/5120723?v=3","gravatar_id":"","url":"https://api.github.com/users/dimaspirit","html_url":"https://github.com/dimaspirit","followers_url":"https://api.github.com/users/dimaspirit/followers","following_url":"https://api.github.com/users/dimaspirit/following{/other_user}","gists_url":"https://api.github.com/users/dimaspirit/gists{/gist_id}","starred_url":"https://api.github.com/users/dimaspirit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimaspirit/subscriptions","organizations_url":"https://api.github.com/users/dimaspirit/orgs","repos_url":"https://api.github.com/users/dimaspirit/repos","events_url":"https://api.github.com/users/dimaspirit/events{/privacy}","received_events_url":"https://api.github.com/users/dimaspirit/received_events","type":"User","site_admin":false},{"login":"IegorKozakov","id":7466787,"avatar_url":"https://avatars.githubusercontent.com/u/7466787?v=3","gravatar_id":"","url":"https://api.github.com/users/IegorKozakov","html_url":"https://github.com/IegorKozakov","followers_url":"https://api.github.com/users/IegorKozakov/followers","following_url":"https://api.github.com/users/IegorKozakov/following{/other_user}","gists_url":"https://api.github.com/users/IegorKozakov/gists{/gist_id}","starred_url":"https://api.github.com/users/IegorKozakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IegorKozakov/subscriptions","organizations_url":"https://api.github.com/users/IegorKozakov/orgs","repos_url":"https://api.github.com/users/IegorKozakov/repos","events_url":"https://api.github.com/users/IegorKozakov/events{/privacy}","received_events_url":"https://api.github.com/users/IegorKozakov/received_events","type":"User","site_admin":false},{"login":"Vladlukhanin","id":9371326,"avatar_url":"https://avatars.githubusercontent.com/u/9371326?v=3","gravatar_id":"","url":"https://api.github.com/users/Vladlukhanin","html_url":"https://github.com/Vladlukhanin","followers_url":"https://api.github.com/users/Vladlukhanin/followers","following_url":"https://api.github.com/users/Vladlukhanin/following{/other_user}","gists_url":"https://api.github.com/users/Vladlukhanin/gists{/gist_id}","starred_url":"https://api.github.com/users/Vladlukhanin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vladlukhanin/subscriptions","organizations_url":"https://api.github.com/users/Vladlukhanin/orgs","repos_url":"https://api.github.com/users/Vladlukhanin/repos","events_url":"https://api.github.com/users/Vladlukhanin/events{/privacy}","received_events_url":"https://api.github.com/users/Vladlukhanin/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-04-19T07:48:44Z","updated_at":"2016-09-15T13:57:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/QuickBlox/quickblox-javascript-sdk/pulls/130","html_url":"https://github.com/QuickBlox/quickblox-javascript-sdk/pull/130","diff_url":"https://github.com/QuickBlox/quickblox-javascript-sdk/pull/130.diff","patch_url":"https://github.com/QuickBlox/quickblox-javascript-sdk/pull/130.patch"},"body":"IN PROGRESS - DON'T MERGE\r\nOptimize exist code for Node env.\r\n\r\nHave issue with QB.chat.disconnect() methon on node.js (OS X)"},"comment":{"url":"https://api.github.com/repos/QuickBlox/quickblox-javascript-sdk/issues/comments/247335343","html_url":"https://github.com/QuickBlox/quickblox-javascript-sdk/pull/130#issuecomment-247335343","issue_url":"https://api.github.com/repos/QuickBlox/quickblox-javascript-sdk/issues/130","id":247335343,"user":{"login":"soulfly","id":373137,"avatar_url":"https://avatars.githubusercontent.com/u/373137?v=3","gravatar_id":"","url":"https://api.github.com/users/soulfly","html_url":"https://github.com/soulfly","followers_url":"https://api.github.com/users/soulfly/followers","following_url":"https://api.github.com/users/soulfly/following{/other_user}","gists_url":"https://api.github.com/users/soulfly/gists{/gist_id}","starred_url":"https://api.github.com/users/soulfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soulfly/subscriptions","organizations_url":"https://api.github.com/users/soulfly/orgs","repos_url":"https://api.github.com/users/soulfly/repos","events_url":"https://api.github.com/users/soulfly/events{/privacy}","received_events_url":"https://api.github.com/users/soulfly/received_events","type":"User","site_admin":false},"created_at":"2016-09-15T13:57:17Z","updated_at":"2016-09-15T13:57:17Z","body":"4) _autoSendPresence больше не нужно - смотри пункт 47 Chat: remove auto sending presence logic из универсальной доки\r\n5) Дублируется код по разбору екстрапарамов в методах send и sendSystemMessage - я уже писал об этом\r\n\r\n              Object.keys(message.extension).forEach(function(field) {\r\n                if (field === 'attachments') {\r\n\r\n                  // attachments\r\n                  message.extension[field].forEach(function(attach) {\r\n                    stanza.c('attachment', attach).up();\r\n                  });\r\n\r\n                } else if (typeof message.extension[field] === 'object') {\r\n                  self._JStoXML(field, message.extension[field], stanza);\r\n                } else {\r\n                  stanza.c(field).t(message.extension[field]).up();\r\n                }\r\n              });\r\n\r\n6) _JStoXML и _XMLtoJS можно переместить из qbChat в qbChatHelpers"}}
{"actor":{"display_login":"soulfly"}}