{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/69442815","id":69442815,"diff_hunk":"@@ -0,0 +1,78 @@\n+/*\n+ * Copyright (c) 2002-2016 \"Neo Technology,\"\n+ * Network Engine for Objects in Lund AB [http://neotechnology.com]\n+ *\n+ * This file is part of Neo4j.\n+ *\n+ * Neo4j is free software: you can redistribute it and/or modify\n+ * it under the terms of the GNU General Public License as published by\n+ * the Free Software Foundation, either version 3 of the License, or\n+ * (at your option) any later version.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+ * GNU General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU General Public License\n+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.\n+ */\n+package org.neo4j.bolt.v1.runtime.internal;\n+\n+import java.util.concurrent.TimeUnit;\n+import java.util.function.Supplier;\n+\n+import org.neo4j.function.Predicates;\n+import org.neo4j.kernel.api.exceptions.TransactionFailureException;\n+import org.neo4j.kernel.impl.transaction.log.TransactionIdStore;\n+\n+import static org.neo4j.kernel.impl.transaction.log.TransactionIdStore.BASE_TX_ID;\n+\n+class TransactionIdTracking implements SessionStateMachine.SPI.TransactionIdTracker\n+{\n+    private final Supplier<TransactionIdStore> transactionIdStore;\n+    private final int timeout;\n+    private final TimeUnit timeoutUnit;\n+\n+    private long txId;\n+\n+    TransactionIdTracking( Supplier<TransactionIdStore> transactionIdStore, long transactionId, int timeout,\n+                           TimeUnit unit )\n+    {\n+        this.transactionIdStore = transactionIdStore;\n+        this.txId = transactionId;\n+        this.timeout = timeout;\n+        this.timeoutUnit = unit;\n+    }\n+\n+    @Override\n+    public void assertUpToDate() throws TransactionFailureException\n+    {\n+        if ( txId <= BASE_TX_ID )\n+        {\n+            return;\n+        }\n+\n+        try\n+        {\n+            Predicates.await( () -> txId <= transactionIdStore.get().getLastClosedTransactionId(), timeout, timeoutUnit,","path":"community/bolt/src/main/java/org/neo4j/bolt/v1/runtime/internal/TransactionIdTracking.java","position":58,"original_position":58,"commit_id":"d4d0dc2109a313acdf4cba83d540f315ab3be9f5","original_commit_id":"d4d0dc2109a313acdf4cba83d540f315ab3be9f5","user":{"login":"davidegrohmann","id":6573166,"avatar_url":"https://avatars.githubusercontent.com/u/6573166?v=3","gravatar_id":"","url":"https://api.github.com/users/davidegrohmann","html_url":"https://github.com/davidegrohmann","followers_url":"https://api.github.com/users/davidegrohmann/followers","following_url":"https://api.github.com/users/davidegrohmann/following{/other_user}","gists_url":"https://api.github.com/users/davidegrohmann/gists{/gist_id}","starred_url":"https://api.github.com/users/davidegrohmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidegrohmann/subscriptions","organizations_url":"https://api.github.com/users/davidegrohmann/orgs","repos_url":"https://api.github.com/users/davidegrohmann/repos","events_url":"https://api.github.com/users/davidegrohmann/events{/privacy}","received_events_url":"https://api.github.com/users/davidegrohmann/received_events","type":"User","site_admin":false},"body":"I don't understand how you can claim here we use `Exception`s for control flow, do you think it is better  to duplicated the code and write the same `while` loop here instead of using `Predicates.await`?\r\n\r\nI'll remove the caught exception as a cuase since it is not relevant and I'll improve the message of the exception we throw.","created_at":"2016-07-04T11:09:35Z","updated_at":"2016-07-04T11:09:35Z","html_url":"https://github.com/neo4j/neo4j/pull/7444#discussion_r69442815","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/7444","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/69442815"},"html":{"href":"https://github.com/neo4j/neo4j/pull/7444#discussion_r69442815"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/7444"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/7444","id":74969746,"html_url":"https://github.com/neo4j/neo4j/pull/7444","diff_url":"https://github.com/neo4j/neo4j/pull/7444.diff","patch_url":"https://github.com/neo4j/neo4j/pull/7444.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/7444","number":7444,"state":"open","locked":false,"title":"Initial work to check that a db is up to a certain version before running queries","user":{"login":"davidegrohmann","id":6573166,"avatar_url":"https://avatars.githubusercontent.com/u/6573166?v=3","gravatar_id":"","url":"https://api.github.com/users/davidegrohmann","html_url":"https://github.com/davidegrohmann","followers_url":"https://api.github.com/users/davidegrohmann/followers","following_url":"https://api.github.com/users/davidegrohmann/following{/other_user}","gists_url":"https://api.github.com/users/davidegrohmann/gists{/gist_id}","starred_url":"https://api.github.com/users/davidegrohmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidegrohmann/subscriptions","organizations_url":"https://api.github.com/users/davidegrohmann/orgs","repos_url":"https://api.github.com/users/davidegrohmann/repos","events_url":"https://api.github.com/users/davidegrohmann/events{/privacy}","received_events_url":"https://api.github.com/users/davidegrohmann/received_events","type":"User","site_admin":false},"body":"This behaviour is not used yet since there is no support yet in the drivers.","created_at":"2016-06-23T14:56:58Z","updated_at":"2016-07-04T11:09:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c419f236056197ab94da209188c5909c2ff8afae","assignee":{"login":"lutovich","id":1638145,"avatar_url":"https://avatars.githubusercontent.com/u/1638145?v=3","gravatar_id":"","url":"https://api.github.com/users/lutovich","html_url":"https://github.com/lutovich","followers_url":"https://api.github.com/users/lutovich/followers","following_url":"https://api.github.com/users/lutovich/following{/other_user}","gists_url":"https://api.github.com/users/lutovich/gists{/gist_id}","starred_url":"https://api.github.com/users/lutovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutovich/subscriptions","organizations_url":"https://api.github.com/users/lutovich/orgs","repos_url":"https://api.github.com/users/lutovich/repos","events_url":"https://api.github.com/users/lutovich/events{/privacy}","received_events_url":"https://api.github.com/users/lutovich/received_events","type":"User","site_admin":false},"assignees":[{"login":"lutovich","id":1638145,"avatar_url":"https://avatars.githubusercontent.com/u/1638145?v=3","gravatar_id":"","url":"https://api.github.com/users/lutovich","html_url":"https://github.com/lutovich","followers_url":"https://api.github.com/users/lutovich/followers","following_url":"https://api.github.com/users/lutovich/following{/other_user}","gists_url":"https://api.github.com/users/lutovich/gists{/gist_id}","starred_url":"https://api.github.com/users/lutovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutovich/subscriptions","organizations_url":"https://api.github.com/users/lutovich/orgs","repos_url":"https://api.github.com/users/lutovich/repos","events_url":"https://api.github.com/users/lutovich/events{/privacy}","received_events_url":"https://api.github.com/users/lutovich/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/7444/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/7444/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/7444/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/d4d0dc2109a313acdf4cba83d540f315ab3be9f5","head":{"label":"davidegrohmann:3.1-begin-tx-version-check","ref":"3.1-begin-tx-version-check","sha":"d4d0dc2109a313acdf4cba83d540f315ab3be9f5","user":{"login":"davidegrohmann","id":6573166,"avatar_url":"https://avatars.githubusercontent.com/u/6573166?v=3","gravatar_id":"","url":"https://api.github.com/users/davidegrohmann","html_url":"https://github.com/davidegrohmann","followers_url":"https://api.github.com/users/davidegrohmann/followers","following_url":"https://api.github.com/users/davidegrohmann/following{/other_user}","gists_url":"https://api.github.com/users/davidegrohmann/gists{/gist_id}","starred_url":"https://api.github.com/users/davidegrohmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidegrohmann/subscriptions","organizations_url":"https://api.github.com/users/davidegrohmann/orgs","repos_url":"https://api.github.com/users/davidegrohmann/repos","events_url":"https://api.github.com/users/davidegrohmann/events{/privacy}","received_events_url":"https://api.github.com/users/davidegrohmann/received_events","type":"User","site_admin":false},"repo":{"id":16693960,"name":"neo4j","full_name":"davidegrohmann/neo4j","owner":{"login":"davidegrohmann","id":6573166,"avatar_url":"https://avatars.githubusercontent.com/u/6573166?v=3","gravatar_id":"","url":"https://api.github.com/users/davidegrohmann","html_url":"https://github.com/davidegrohmann","followers_url":"https://api.github.com/users/davidegrohmann/followers","following_url":"https://api.github.com/users/davidegrohmann/following{/other_user}","gists_url":"https://api.github.com/users/davidegrohmann/gists{/gist_id}","starred_url":"https://api.github.com/users/davidegrohmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidegrohmann/subscriptions","organizations_url":"https://api.github.com/users/davidegrohmann/orgs","repos_url":"https://api.github.com/users/davidegrohmann/repos","events_url":"https://api.github.com/users/davidegrohmann/events{/privacy}","received_events_url":"https://api.github.com/users/davidegrohmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidegrohmann/neo4j","description":"The World's Leading Graph Database","fork":true,"url":"https://api.github.com/repos/davidegrohmann/neo4j","forks_url":"https://api.github.com/repos/davidegrohmann/neo4j/forks","keys_url":"https://api.github.com/repos/davidegrohmann/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidegrohmann/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidegrohmann/neo4j/teams","hooks_url":"https://api.github.com/repos/davidegrohmann/neo4j/hooks","issue_events_url":"https://api.github.com/repos/davidegrohmann/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/davidegrohmann/neo4j/events","assignees_url":"https://api.github.com/repos/davidegrohmann/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/davidegrohmann/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/davidegrohmann/neo4j/tags","blobs_url":"https://api.github.com/repos/davidegrohmann/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidegrohmann/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidegrohmann/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidegrohmann/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidegrohmann/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/davidegrohmann/neo4j/languages","stargazers_url":"https://api.github.com/repos/davidegrohmann/neo4j/stargazers","contributors_url":"https://api.github.com/repos/davidegrohmann/neo4j/contributors","subscribers_url":"https://api.github.com/repos/davidegrohmann/neo4j/subscribers","subscription_url":"https://api.github.com/repos/davidegrohmann/neo4j/subscription","commits_url":"https://api.github.com/repos/davidegrohmann/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidegrohmann/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidegrohmann/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidegrohmann/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidegrohmann/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/davidegrohmann/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidegrohmann/neo4j/merges","archive_url":"https://api.github.com/repos/davidegrohmann/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidegrohmann/neo4j/downloads","issues_url":"https://api.github.com/repos/davidegrohmann/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/davidegrohmann/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/davidegrohmann/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/davidegrohmann/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidegrohmann/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/davidegrohmann/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/davidegrohmann/neo4j/deployments","created_at":"2014-02-10T11:59:43Z","updated_at":"2015-10-01T08:40:18Z","pushed_at":"2016-07-04T09:25:23Z","git_url":"git://github.com/davidegrohmann/neo4j.git","ssh_url":"git@github.com:davidegrohmann/neo4j.git","clone_url":"https://github.com/davidegrohmann/neo4j.git","svn_url":"https://github.com/davidegrohmann/neo4j","homepage":"http://neo4j.org","size":301136,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.1"}},"base":{"label":"neo4j:3.1","ref":"3.1","sha":"b0f7d9f20b0d6894e5d620ba4f3a38257b1b62e7","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2016-07-04T10:33:39Z","pushed_at":"2016-07-04T11:01:51Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":370322,"stargazers_count":2758,"watchers_count":2758,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":943,"mirror_url":null,"open_issues_count":375,"forks":943,"open_issues":375,"watchers":2758,"default_branch":"3.1"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/7444"},"html":{"href":"https://github.com/neo4j/neo4j/pull/7444"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/7444"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/7444/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/7444/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/7444/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/d4d0dc2109a313acdf4cba83d540f315ab3be9f5"}}}}
{"actor":{"display_login":"davidegrohmann"}}