{"action":"created","comment":{"url":"https://api.github.com/repos/novoda/spikes/pulls/comments/63572954","id":63572954,"diff_hunk":"@@ -0,0 +1,41 @@\n+jest.unmock('../../../core/service/oauth-helper.js')\n+jest.unmock('../../../core/service/percent-encoder.js')\n+// var OauthHelper = require('../../../core/service/oauth-helper.js')\n+\n+describe('OauthHelper', () => {\n+\n+  // commented out because it's failing for a strange reason","path":"ReactNative/ReactTwitter/__tests__/core/service/oauth-helper.test.js","position":7,"original_position":7,"commit_id":"f3ec11da2609b0f063245d93289b54ddf415abaa","original_commit_id":"2fcf0e570834fdf3ca86989f74b44a4b020f5ab3","user":{"login":"xrigau","id":1626673,"avatar_url":"https://avatars.githubusercontent.com/u/1626673?v=3","gravatar_id":"","url":"https://api.github.com/users/xrigau","html_url":"https://github.com/xrigau","followers_url":"https://api.github.com/users/xrigau/followers","following_url":"https://api.github.com/users/xrigau/following{/other_user}","gists_url":"https://api.github.com/users/xrigau/gists{/gist_id}","starred_url":"https://api.github.com/users/xrigau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xrigau/subscriptions","organizations_url":"https://api.github.com/users/xrigau/orgs","repos_url":"https://api.github.com/users/xrigau/repos","events_url":"https://api.github.com/users/xrigau/events{/privacy}","received_events_url":"https://api.github.com/users/xrigau/received_events","type":"User","site_admin":false},"body":"did this pairing happen?","created_at":"2016-05-17T18:01:00Z","updated_at":"2016-05-17T18:01:00Z","html_url":"https://github.com/novoda/spikes/pull/35#discussion_r63572954","pull_request_url":"https://api.github.com/repos/novoda/spikes/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/novoda/spikes/pulls/comments/63572954"},"html":{"href":"https://github.com/novoda/spikes/pull/35#discussion_r63572954"},"pull_request":{"href":"https://api.github.com/repos/novoda/spikes/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/novoda/spikes/pulls/35","id":69860535,"html_url":"https://github.com/novoda/spikes/pull/35","diff_url":"https://github.com/novoda/spikes/pull/35.diff","patch_url":"https://github.com/novoda/spikes/pull/35.patch","issue_url":"https://api.github.com/repos/novoda/spikes/issues/35","number":35,"state":"closed","locked":false,"title":"Access token Request","user":{"login":"eduardb","id":2426348,"avatar_url":"https://avatars.githubusercontent.com/u/2426348?v=3","gravatar_id":"","url":"https://api.github.com/users/eduardb","html_url":"https://github.com/eduardb","followers_url":"https://api.github.com/users/eduardb/followers","following_url":"https://api.github.com/users/eduardb/following{/other_user}","gists_url":"https://api.github.com/users/eduardb/gists{/gist_id}","starred_url":"https://api.github.com/users/eduardb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eduardb/subscriptions","organizations_url":"https://api.github.com/users/eduardb/orgs","repos_url":"https://api.github.com/users/eduardb/repos","events_url":"https://api.github.com/users/eduardb/events{/privacy}","received_events_url":"https://api.github.com/users/eduardb/received_events","type":"User","site_admin":false},"body":"We created two helper classes for the Twitter login flow. One that is a generic oauth helper, that creates a signature for a request and builds an authorization header. The second one is is for creating signed request to the Twitter API. For now we only have implemented the `requestToken` method that will provide a token for us to be used with login in the future.\r\n\r\nWe wrote tests for the `PercentEncoder` and `OauthHelper`, but we had to comment out the later ones because they were failing due to some react native stuff (CryptoJS to be more specific).\r\n\r\nTo test this functionality, we have included a debug screen accessible from the main screen (Oauth)\r\n\r\n| iOS | Android |\r\n| --- | --- |\r\n| ![may-12-2016 17-36-15](https://cloud.githubusercontent.com/assets/2426348/15220518/10e51cf8-1868-11e6-94bd-34c384b9eeab.gif) | ![ezgif com-video-to-gif 1](https://cloud.githubusercontent.com/assets/2426348/15220505/02dee0bc-1868-11e6-9c6d-41cb17b2f088.gif) |\r\n\r\nPaired with @gbasile ","created_at":"2016-05-12T15:47:12Z","updated_at":"2016-05-17T18:01:01Z","closed_at":"2016-05-13T10:09:13Z","merged_at":"2016-05-13T10:09:13Z","merge_commit_sha":"c75cabfaca5eab426486041973386df7b146bd4c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/novoda/spikes/pulls/35/commits","review_comments_url":"https://api.github.com/repos/novoda/spikes/pulls/35/comments","review_comment_url":"https://api.github.com/repos/novoda/spikes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/novoda/spikes/issues/35/comments","statuses_url":"https://api.github.com/repos/novoda/spikes/statuses/f3ec11da2609b0f063245d93289b54ddf415abaa","head":{"label":"novoda:react/PT-68/oauth","ref":"react/PT-68/oauth","sha":"f3ec11da2609b0f063245d93289b54ddf415abaa","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":13300550,"name":"spikes","full_name":"novoda/spikes","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/spikes","description":"Where ideas & concepts are born & incubated","fork":false,"url":"https://api.github.com/repos/novoda/spikes","forks_url":"https://api.github.com/repos/novoda/spikes/forks","keys_url":"https://api.github.com/repos/novoda/spikes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/spikes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/spikes/teams","hooks_url":"https://api.github.com/repos/novoda/spikes/hooks","issue_events_url":"https://api.github.com/repos/novoda/spikes/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/spikes/events","assignees_url":"https://api.github.com/repos/novoda/spikes/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/spikes/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/spikes/tags","blobs_url":"https://api.github.com/repos/novoda/spikes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/spikes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/spikes/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/spikes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/spikes/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/spikes/languages","stargazers_url":"https://api.github.com/repos/novoda/spikes/stargazers","contributors_url":"https://api.github.com/repos/novoda/spikes/contributors","subscribers_url":"https://api.github.com/repos/novoda/spikes/subscribers","subscription_url":"https://api.github.com/repos/novoda/spikes/subscription","commits_url":"https://api.github.com/repos/novoda/spikes/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/spikes/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/spikes/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/spikes/issues/comments{/number}","contents_url":"https://api.github.com/repos/novoda/spikes/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/spikes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/spikes/merges","archive_url":"https://api.github.com/repos/novoda/spikes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/spikes/downloads","issues_url":"https://api.github.com/repos/novoda/spikes/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/spikes/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/spikes/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/spikes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/spikes/labels{/name}","releases_url":"https://api.github.com/repos/novoda/spikes/releases{/id}","deployments_url":"https://api.github.com/repos/novoda/spikes/deployments","created_at":"2013-10-03T14:31:43Z","updated_at":"2016-05-13T10:13:11Z","pushed_at":"2016-05-17T16:48:29Z","git_url":"git://github.com/novoda/spikes.git","ssh_url":"git@github.com:novoda/spikes.git","clone_url":"https://github.com/novoda/spikes.git","svn_url":"https://github.com/novoda/spikes","homepage":"","size":12214,"stargazers_count":41,"watchers_count":41,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":41,"default_branch":"master"}},"base":{"label":"novoda:react/PT-68/twitter-login","ref":"react/PT-68/twitter-login","sha":"f3629e7e758d3a6d132a07f7c779a3d941ef7a98","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":13300550,"name":"spikes","full_name":"novoda/spikes","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/spikes","description":"Where ideas & concepts are born & incubated","fork":false,"url":"https://api.github.com/repos/novoda/spikes","forks_url":"https://api.github.com/repos/novoda/spikes/forks","keys_url":"https://api.github.com/repos/novoda/spikes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/spikes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/spikes/teams","hooks_url":"https://api.github.com/repos/novoda/spikes/hooks","issue_events_url":"https://api.github.com/repos/novoda/spikes/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/spikes/events","assignees_url":"https://api.github.com/repos/novoda/spikes/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/spikes/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/spikes/tags","blobs_url":"https://api.github.com/repos/novoda/spikes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/spikes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/spikes/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/spikes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/spikes/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/spikes/languages","stargazers_url":"https://api.github.com/repos/novoda/spikes/stargazers","contributors_url":"https://api.github.com/repos/novoda/spikes/contributors","subscribers_url":"https://api.github.com/repos/novoda/spikes/subscribers","subscription_url":"https://api.github.com/repos/novoda/spikes/subscription","commits_url":"https://api.github.com/repos/novoda/spikes/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/spikes/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/spikes/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/spikes/issues/comments{/number}","contents_url":"https://api.github.com/repos/novoda/spikes/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/spikes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/spikes/merges","archive_url":"https://api.github.com/repos/novoda/spikes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/spikes/downloads","issues_url":"https://api.github.com/repos/novoda/spikes/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/spikes/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/spikes/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/spikes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/spikes/labels{/name}","releases_url":"https://api.github.com/repos/novoda/spikes/releases{/id}","deployments_url":"https://api.github.com/repos/novoda/spikes/deployments","created_at":"2013-10-03T14:31:43Z","updated_at":"2016-05-13T10:13:11Z","pushed_at":"2016-05-17T16:48:29Z","git_url":"git://github.com/novoda/spikes.git","ssh_url":"git@github.com:novoda/spikes.git","clone_url":"https://github.com/novoda/spikes.git","svn_url":"https://github.com/novoda/spikes","homepage":"","size":12214,"stargazers_count":41,"watchers_count":41,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/novoda/spikes/pulls/35"},"html":{"href":"https://github.com/novoda/spikes/pull/35"},"issue":{"href":"https://api.github.com/repos/novoda/spikes/issues/35"},"comments":{"href":"https://api.github.com/repos/novoda/spikes/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/novoda/spikes/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/novoda/spikes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/novoda/spikes/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/novoda/spikes/statuses/f3ec11da2609b0f063245d93289b54ddf415abaa"}}}}