{"action":"created","issue":{"url":"https://api.github.com/repos/systemd/systemd/issues/3609","repository_url":"https://api.github.com/repos/systemd/systemd","labels_url":"https://api.github.com/repos/systemd/systemd/issues/3609/labels{/name}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/3609/comments","events_url":"https://api.github.com/repos/systemd/systemd/issues/3609/events","html_url":"https://github.com/systemd/systemd/pull/3609","id":162423994,"number":3609,"title":"resolved: don't put route-only domains into resolv.conf \"search\"","user":{"login":"martinpitt","id":200109,"avatar_url":"https://avatars.githubusercontent.com/u/200109?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpitt","html_url":"https://github.com/martinpitt","followers_url":"https://api.github.com/users/martinpitt/followers","following_url":"https://api.github.com/users/martinpitt/following{/other_user}","gists_url":"https://api.github.com/users/martinpitt/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpitt/subscriptions","organizations_url":"https://api.github.com/users/martinpitt/orgs","repos_url":"https://api.github.com/users/martinpitt/repos","events_url":"https://api.github.com/users/martinpitt/events{/privacy}","received_events_url":"https://api.github.com/users/martinpitt/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/systemd/systemd/labels/resolve","name":"resolve","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-27T10:48:45Z","updated_at":"2016-06-27T12:57:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/3609","html_url":"https://github.com/systemd/systemd/pull/3609","diff_url":"https://github.com/systemd/systemd/pull/3609.diff","patch_url":"https://github.com/systemd/systemd/pull/3609.patch"},"body":"Route-only domains (\"Domains= ~foo\") are documented to not get used as search\r\nsuffixes. So enable filtering them out in manager_write_resolv_conf().\r\n\r\nFix the accidentally inverted logic in manager_compile_search_domains() and\r\nsimplify it, so that the filtering actually works. Also change the type of the\r\nfilter_route to bool, as it is being called that way.\r\n\r\nNote: the included test case is more complex than necessary for this bug. But I want to use the same one for PR #3420 (regardless which way it actually gets decided how this should work), i. e. in that PR I will just add an assertion that the domain-restricted server is/is not in `resolv.conf`."},"comment":{"url":"https://api.github.com/repos/systemd/systemd/issues/comments/228737673","html_url":"https://github.com/systemd/systemd/pull/3609#issuecomment-228737673","issue_url":"https://api.github.com/repos/systemd/systemd/issues/3609","id":228737673,"user":{"login":"martinpitt","id":200109,"avatar_url":"https://avatars.githubusercontent.com/u/200109?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpitt","html_url":"https://github.com/martinpitt","followers_url":"https://api.github.com/users/martinpitt/followers","following_url":"https://api.github.com/users/martinpitt/following{/other_user}","gists_url":"https://api.github.com/users/martinpitt/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpitt/subscriptions","organizations_url":"https://api.github.com/users/martinpitt/orgs","repos_url":"https://api.github.com/users/martinpitt/repos","events_url":"https://api.github.com/users/martinpitt/events{/privacy}","received_events_url":"https://api.github.com/users/martinpitt/received_events","type":"User","site_admin":false},"created_at":"2016-06-27T12:57:06Z","updated_at":"2016-06-27T12:57:06Z","body":"Hmm, now when I look at the diff it looks like it should cancel itself out and the net effect should be zero. But the `~domain` clearly appears in the generated `resolv.conf` without this in 230, and it works fine with this patch. I am clearly missing something, maybe this already got fixed in a different commit after 230, let me take a closer look."}}
{"actor":{"display_login":"martinpitt"}}