{"action":"created","issue":{"url":"https://api.github.com/repos/wistia/nsq-ruby/issues/36","repository_url":"https://api.github.com/repos/wistia/nsq-ruby","labels_url":"https://api.github.com/repos/wistia/nsq-ruby/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/wistia/nsq-ruby/issues/36/comments","events_url":"https://api.github.com/repos/wistia/nsq-ruby/issues/36/events","html_url":"https://github.com/wistia/nsq-ruby/pull/36","id":195400728,"number":36,"title":"Close sockets when closing the connection","user":{"login":"leklund","id":23857,"avatar_url":"https://avatars.githubusercontent.com/u/23857?v=3","gravatar_id":"","url":"https://api.github.com/users/leklund","html_url":"https://github.com/leklund","followers_url":"https://api.github.com/users/leklund/followers","following_url":"https://api.github.com/users/leklund/following{/other_user}","gists_url":"https://api.github.com/users/leklund/gists{/gist_id}","starred_url":"https://api.github.com/users/leklund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leklund/subscriptions","organizations_url":"https://api.github.com/users/leklund/orgs","repos_url":"https://api.github.com/users/leklund/repos","events_url":"https://api.github.com/users/leklund/events{/privacy}","received_events_url":"https://api.github.com/users/leklund/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-13T23:38:25Z","updated_at":"2016-12-13T23:38:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wistia/nsq-ruby/pulls/36","html_url":"https://github.com/wistia/nsq-ruby/pull/36","diff_url":"https://github.com/wistia/nsq-ruby/pull/36.diff","patch_url":"https://github.com/wistia/nsq-ruby/pull/36.patch"},"body":"Without calling `@socket.close`, the sockets will be left open when `close_connection` is called.\r\n\r\nThis PR fixes an issue described in #34 \r\n\r\nChanges:\r\n\r\n* call `@socket.close` when closing the connection just before setting it to nil\r\n* set `sync_close` to true when upgrading to an SSL connection so that the underlying TCP connection is closed at the same time."},"comment":{"url":"https://api.github.com/repos/wistia/nsq-ruby/issues/comments/266897193","html_url":"https://github.com/wistia/nsq-ruby/pull/36#issuecomment-266897193","issue_url":"https://api.github.com/repos/wistia/nsq-ruby/issues/36","id":266897193,"user":{"login":"wistia-mentionbot","id":18702830,"avatar_url":"https://avatars.githubusercontent.com/u/18702830?v=3","gravatar_id":"","url":"https://api.github.com/users/wistia-mentionbot","html_url":"https://github.com/wistia-mentionbot","followers_url":"https://api.github.com/users/wistia-mentionbot/followers","following_url":"https://api.github.com/users/wistia-mentionbot/following{/other_user}","gists_url":"https://api.github.com/users/wistia-mentionbot/gists{/gist_id}","starred_url":"https://api.github.com/users/wistia-mentionbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wistia-mentionbot/subscriptions","organizations_url":"https://api.github.com/users/wistia-mentionbot/orgs","repos_url":"https://api.github.com/users/wistia-mentionbot/repos","events_url":"https://api.github.com/users/wistia-mentionbot/events{/privacy}","received_events_url":"https://api.github.com/users/wistia-mentionbot/received_events","type":"User","site_admin":false},"created_at":"2016-12-13T23:38:35Z","updated_at":"2016-12-13T23:38:35Z","body":"@leklund, thanks for your PR! By analyzing the annotation information on this pull request, we identified @bschwartz, @freerobby and @alieander to be potential reviewers"}}
{"actor":{"display_login":"wistia-mentionbot"}}