{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/pulls/comments/78515501","id":78515501,"diff_hunk":"@@ -434,6 +435,7 @@ bool M2MConnectionHandlerPimpl::resolve_hostname(const char *address,\n     if(_socket_server > 0) {\n         close(_socket_server);\n         _socket_server = -1;\n+        pthread_join(_listen_thread, NULL);","path":"source/m2mconnectionhandlerpimpl.cpp","position":14,"original_position":14,"commit_id":"bfdb80b9a8902eb19f4a87874269ed61501fcd41","original_commit_id":"bfdb80b9a8902eb19f4a87874269ed61501fcd41","user":{"login":"anttiylitokola","id":13655184,"avatar_url":"https://avatars.githubusercontent.com/u/13655184?v=3","gravatar_id":"","url":"https://api.github.com/users/anttiylitokola","html_url":"https://github.com/anttiylitokola","followers_url":"https://api.github.com/users/anttiylitokola/followers","following_url":"https://api.github.com/users/anttiylitokola/following{/other_user}","gists_url":"https://api.github.com/users/anttiylitokola/gists{/gist_id}","starred_url":"https://api.github.com/users/anttiylitokola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anttiylitokola/subscriptions","organizations_url":"https://api.github.com/users/anttiylitokola/orgs","repos_url":"https://api.github.com/users/anttiylitokola/repos","events_url":"https://api.github.com/users/anttiylitokola/events{/privacy}","received_events_url":"https://api.github.com/users/anttiylitokola/received_events","type":"User","site_admin":false},"body":"Document says following:\r\n\"If that thread has already terminated, then  pthread_join() returns immediately.\"\r\nBut there is also statement:\r\n\"Joining with a thread that has previously been joined results in  undefined behavior.\"\r\n\r\nSo it's pretty confusing... Valgrind didn't spot any issues when pthread_join was executed multiple times.","created_at":"2016-09-13T08:20:47Z","updated_at":"2016-09-13T08:20:47Z","html_url":"https://github.com/ARMmbed/mbed-client-linux/pull/54#discussion_r78515501","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-linux/pulls/comments/78515501"},"html":{"href":"https://github.com/ARMmbed/mbed-client-linux/pull/54#discussion_r78515501"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-linux/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/pulls/54","id":84992454,"html_url":"https://github.com/ARMmbed/mbed-client-linux/pull/54","diff_url":"https://github.com/ARMmbed/mbed-client-linux/pull/54.diff","patch_url":"https://github.com/ARMmbed/mbed-client-linux/pull/54.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/issues/54","number":54,"state":"open","locked":false,"title":"Fix error: IOTCLT-850 During reconnections, resolve_hostname() should…","user":{"login":"anttiylitokola","id":13655184,"avatar_url":"https://avatars.githubusercontent.com/u/13655184?v=3","gravatar_id":"","url":"https://api.github.com/users/anttiylitokola","html_url":"https://github.com/anttiylitokola","followers_url":"https://api.github.com/users/anttiylitokola/followers","following_url":"https://api.github.com/users/anttiylitokola/following{/other_user}","gists_url":"https://api.github.com/users/anttiylitokola/gists{/gist_id}","starred_url":"https://api.github.com/users/anttiylitokola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anttiylitokola/subscriptions","organizations_url":"https://api.github.com/users/anttiylitokola/orgs","repos_url":"https://api.github.com/users/anttiylitokola/repos","events_url":"https://api.github.com/users/anttiylitokola/events{/privacy}","received_events_url":"https://api.github.com/users/anttiylitokola/received_events","type":"User","site_admin":false},"body":"… wait for 'listener' thread to terminate before creating a new socket","created_at":"2016-09-13T06:36:15Z","updated_at":"2016-09-13T08:20:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b9077b47a796fd981feb2f75c8dd4a136c09f2f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/pulls/54/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/pulls/54/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/issues/54/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/statuses/bfdb80b9a8902eb19f4a87874269ed61501fcd41","head":{"label":"ARMmbed:iotclt850","ref":"iotclt850","sha":"bfdb80b9a8902eb19f4a87874269ed61501fcd41","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":34735232,"name":"mbed-client-linux","full_name":"ARMmbed/mbed-client-linux","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-client-linux","description":"Linux specific component for mbed-client C++ library","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-client-linux","forks_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/deployments","created_at":"2015-04-28T14:24:40Z","updated_at":"2016-07-01T08:22:11Z","pushed_at":"2016-09-13T06:36:15Z","git_url":"git://github.com/ARMmbed/mbed-client-linux.git","ssh_url":"git@github.com:ARMmbed/mbed-client-linux.git","clone_url":"https://github.com/ARMmbed/mbed-client-linux.git","svn_url":"https://github.com/ARMmbed/mbed-client-linux","homepage":"","size":224,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"ec8649ddeef9bb48ca62267fa4f2f07e481619f4","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":34735232,"name":"mbed-client-linux","full_name":"ARMmbed/mbed-client-linux","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-client-linux","description":"Linux specific component for mbed-client C++ library","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-client-linux","forks_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-client-linux/deployments","created_at":"2015-04-28T14:24:40Z","updated_at":"2016-07-01T08:22:11Z","pushed_at":"2016-09-13T06:36:15Z","git_url":"git://github.com/ARMmbed/mbed-client-linux.git","ssh_url":"git@github.com:ARMmbed/mbed-client-linux.git","clone_url":"https://github.com/ARMmbed/mbed-client-linux.git","svn_url":"https://github.com/ARMmbed/mbed-client-linux","homepage":"","size":224,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-linux/pulls/54"},"html":{"href":"https://github.com/ARMmbed/mbed-client-linux/pull/54"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-linux/issues/54"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-linux/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-linux/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-linux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-linux/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-client-linux/statuses/bfdb80b9a8902eb19f4a87874269ed61501fcd41"}}}}
{"actor":{"display_login":"anttiylitokola"}}