{"action":"created","comment":{"url":"https://api.github.com/repos/sourcegraph/sublime-lsp/pulls/comments/87786362","pull_request_review_id":8383143,"id":87786362,"diff_hunk":"@@ -243,31 +293,37 @@ def __init__(self, binary_path, args, env, root_path):\n         The script file to run is passed to the constructor.\n         \"\"\"\n         super(ServerClient, self).__init__(binary_path, args, env, root_path)\n-        print(\"Trying to spawn executable from: \" + binary_path)\n+        log.debug('Trying to spawn {0}'.format(' '.join(self.args)))\n         try:\n             if os.name == \"nt\":\n                 # linux subprocess module does not have STARTUPINFO\n                 # so only use it if on Windows\n                 si = subprocess.STARTUPINFO()\n                 si.dwFlags |= subprocess.SW_HIDE | subprocess.STARTF_USESHOWWINDOW\n                 self.server_proc = subprocess.Popen(self.args,\n-                                                    stdin=subprocess.PIPE, stdout=subprocess.PIPE, startupinfo=si, cwd=self.root_path, env=self.env)\n+                                                    stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, startupinfo=si, cwd=self.root_path, env=self.env)\n             else:\n                 log.debug(\"opening \" + binary_path)\n                 self.server_proc = subprocess.Popen(self.args,\n-                                                    stdin=subprocess.PIPE, stdout=subprocess.PIPE, cwd=self.root_path, env=self.env)\n+                                                    stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, cwd=self.root_path, env=self.env)\n         except Exception as err:\n             print(err)\n             self.server_proc = None\n         # start reader thread\n         if self.server_proc and (not self.server_proc.poll()):\n-            log.debug(\"server proc \" + str(self.server_proc))\n+            log.debug(\"server process \" + str(self.server_proc.pid))\n             log.debug(\"starting reader thread\")\n             readerThread = threading.Thread(target=ServerClient.__reader, args=(\n                 self.server_proc.stdout, self.msgq, self.eventq, self.asyncReq, self.reqType, self.server_proc, self.event_handlers))\n             readerThread.daemon = True\n             readerThread.start()\n-        self.postCmd(lsp_helpers.init_message(\"file://\" + self.root_path, self.server_proc.pid))\n+            log.debug(\"starting logger thread\")","path":"typescript/libs/lsp_client.py","position":134,"original_position":133,"commit_id":"f4f2d7413c17124664c6aa698f6a0be61dfd0576","original_commit_id":"e0f8af9f891ec7b427d8368591fda26c39806926","user":{"login":"alexsaveliev","id":7010538,"avatar_url":"https://avatars.githubusercontent.com/u/7010538?v=3","gravatar_id":"","url":"https://api.github.com/users/alexsaveliev","html_url":"https://github.com/alexsaveliev","followers_url":"https://api.github.com/users/alexsaveliev/followers","following_url":"https://api.github.com/users/alexsaveliev/following{/other_user}","gists_url":"https://api.github.com/users/alexsaveliev/gists{/gist_id}","starred_url":"https://api.github.com/users/alexsaveliev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexsaveliev/subscriptions","organizations_url":"https://api.github.com/users/alexsaveliev/orgs","repos_url":"https://api.github.com/users/alexsaveliev/repos","events_url":"https://api.github.com/users/alexsaveliev/events{/privacy}","received_events_url":"https://api.github.com/users/alexsaveliev/received_events","type":"User","site_admin":false},"body":"Should be addressed by https://github.com/alexsaveliev/sublime-lsp/commit/f4f2d7413c17124664c6aa698f6a0be61dfd0576#diff-5cde716076cda2c46cc19898b623da71R334","created_at":"2016-11-14T11:54:41Z","updated_at":"2016-11-14T11:54:41Z","html_url":"https://github.com/sourcegraph/sublime-lsp/pull/5#discussion_r87786362","pull_request_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/sourcegraph/sublime-lsp/pulls/comments/87786362"},"html":{"href":"https://github.com/sourcegraph/sublime-lsp/pull/5#discussion_r87786362"},"pull_request":{"href":"https://api.github.com/repos/sourcegraph/sublime-lsp/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/sourcegraph/sublime-lsp/pulls/5","id":93333274,"html_url":"https://github.com/sourcegraph/sublime-lsp/pull/5","diff_url":"https://github.com/sourcegraph/sublime-lsp/pull/5.diff","patch_url":"https://github.com/sourcegraph/sublime-lsp/pull/5.patch","issue_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/issues/5","number":5,"state":"open","locked":false,"title":"TS/JS language support; Windows support","user":{"login":"alexsaveliev","id":7010538,"avatar_url":"https://avatars.githubusercontent.com/u/7010538?v=3","gravatar_id":"","url":"https://api.github.com/users/alexsaveliev","html_url":"https://github.com/alexsaveliev","followers_url":"https://api.github.com/users/alexsaveliev/followers","following_url":"https://api.github.com/users/alexsaveliev/following{/other_user}","gists_url":"https://api.github.com/users/alexsaveliev/gists{/gist_id}","starred_url":"https://api.github.com/users/alexsaveliev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexsaveliev/subscriptions","organizations_url":"https://api.github.com/users/alexsaveliev/orgs","repos_url":"https://api.github.com/users/alexsaveliev/repos","events_url":"https://api.github.com/users/alexsaveliev/events{/privacy}","received_events_url":"https://api.github.com/users/alexsaveliev/received_events","type":"User","site_admin":false},"body":"- Windows support (dealing with Windows-specific URI `file:///`, looking for LSP server executable in `PATH` while trying extensions from `PATHEXT`)\r\n- Decorating results of \"Find References\" by using local file system data in a separate thread. We need to have some data not provided by the LSP protocol (such as matching lines text and symbol information) to construct \"Find References\" results page\r\n- Added installation instructions for TypeScript/JavaScript\r\n- Dumping LSP server's stderr messages","created_at":"2016-11-11T13:38:26Z","updated_at":"2016-11-14T11:54:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af8cc0b58dbd73c837d9be3d5772167c593cc623","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/pulls/5/commits","review_comments_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/pulls/5/comments","review_comment_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/issues/5/comments","statuses_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/statuses/f4f2d7413c17124664c6aa698f6a0be61dfd0576","head":{"label":"alexsaveliev:master","ref":"master","sha":"f4f2d7413c17124664c6aa698f6a0be61dfd0576","user":{"login":"alexsaveliev","id":7010538,"avatar_url":"https://avatars.githubusercontent.com/u/7010538?v=3","gravatar_id":"","url":"https://api.github.com/users/alexsaveliev","html_url":"https://github.com/alexsaveliev","followers_url":"https://api.github.com/users/alexsaveliev/followers","following_url":"https://api.github.com/users/alexsaveliev/following{/other_user}","gists_url":"https://api.github.com/users/alexsaveliev/gists{/gist_id}","starred_url":"https://api.github.com/users/alexsaveliev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexsaveliev/subscriptions","organizations_url":"https://api.github.com/users/alexsaveliev/orgs","repos_url":"https://api.github.com/users/alexsaveliev/repos","events_url":"https://api.github.com/users/alexsaveliev/events{/privacy}","received_events_url":"https://api.github.com/users/alexsaveliev/received_events","type":"User","site_admin":false},"repo":{"id":73167149,"name":"sublime-lsp","full_name":"alexsaveliev/sublime-lsp","owner":{"login":"alexsaveliev","id":7010538,"avatar_url":"https://avatars.githubusercontent.com/u/7010538?v=3","gravatar_id":"","url":"https://api.github.com/users/alexsaveliev","html_url":"https://github.com/alexsaveliev","followers_url":"https://api.github.com/users/alexsaveliev/followers","following_url":"https://api.github.com/users/alexsaveliev/following{/other_user}","gists_url":"https://api.github.com/users/alexsaveliev/gists{/gist_id}","starred_url":"https://api.github.com/users/alexsaveliev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexsaveliev/subscriptions","organizations_url":"https://api.github.com/users/alexsaveliev/orgs","repos_url":"https://api.github.com/users/alexsaveliev/repos","events_url":"https://api.github.com/users/alexsaveliev/events{/privacy}","received_events_url":"https://api.github.com/users/alexsaveliev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexsaveliev/sublime-lsp","description":"An LSP adapter for Sublime Text 3.","fork":true,"url":"https://api.github.com/repos/alexsaveliev/sublime-lsp","forks_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/forks","keys_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/teams","hooks_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/hooks","issue_events_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/issues/events{/number}","events_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/events","assignees_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/assignees{/user}","branches_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/branches{/branch}","tags_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/tags","blobs_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/statuses/{sha}","languages_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/languages","stargazers_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/stargazers","contributors_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/contributors","subscribers_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/subscribers","subscription_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/subscription","commits_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/contents/{+path}","compare_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/merges","archive_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/downloads","issues_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/issues{/number}","pulls_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/pulls{/number}","milestones_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/milestones{/number}","notifications_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/labels{/name}","releases_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/releases{/id}","deployments_url":"https://api.github.com/repos/alexsaveliev/sublime-lsp/deployments","created_at":"2016-11-08T08:53:58Z","updated_at":"2016-11-08T08:53:59Z","pushed_at":"2016-11-14T11:53:14Z","git_url":"git://github.com/alexsaveliev/sublime-lsp.git","ssh_url":"git@github.com:alexsaveliev/sublime-lsp.git","clone_url":"https://github.com/alexsaveliev/sublime-lsp.git","svn_url":"https://github.com/alexsaveliev/sublime-lsp","homepage":"https://langserver.org","size":39323,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sourcegraph:master","ref":"master","sha":"2866d87cf8987ddfe61ef4b42d9d6b58e44d8b64","user":{"login":"sourcegraph","id":3979584,"avatar_url":"https://avatars.githubusercontent.com/u/3979584?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"repo":{"id":72587457,"name":"sublime-lsp","full_name":"sourcegraph/sublime-lsp","owner":{"login":"sourcegraph","id":3979584,"avatar_url":"https://avatars.githubusercontent.com/u/3979584?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sourcegraph/sublime-lsp","description":"An LSP adapter for Sublime Text 3.","fork":true,"url":"https://api.github.com/repos/sourcegraph/sublime-lsp","forks_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/forks","keys_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/teams","hooks_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/hooks","issue_events_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/issues/events{/number}","events_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/events","assignees_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/assignees{/user}","branches_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/branches{/branch}","tags_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/tags","blobs_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/languages","stargazers_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/stargazers","contributors_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/contributors","subscribers_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/subscribers","subscription_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/subscription","commits_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/contents/{+path}","compare_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/merges","archive_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/downloads","issues_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/issues{/number}","pulls_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/labels{/name}","releases_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/releases{/id}","deployments_url":"https://api.github.com/repos/sourcegraph/sublime-lsp/deployments","created_at":"2016-11-02T00:04:30Z","updated_at":"2016-11-08T12:36:00Z","pushed_at":"2016-11-14T11:53:14Z","git_url":"git://github.com/sourcegraph/sublime-lsp.git","ssh_url":"git@github.com:sourcegraph/sublime-lsp.git","clone_url":"https://github.com/sourcegraph/sublime-lsp.git","svn_url":"https://github.com/sourcegraph/sublime-lsp","homepage":"https://langserver.org","size":39294,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sourcegraph/sublime-lsp/pulls/5"},"html":{"href":"https://github.com/sourcegraph/sublime-lsp/pull/5"},"issue":{"href":"https://api.github.com/repos/sourcegraph/sublime-lsp/issues/5"},"comments":{"href":"https://api.github.com/repos/sourcegraph/sublime-lsp/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/sourcegraph/sublime-lsp/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/sourcegraph/sublime-lsp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sourcegraph/sublime-lsp/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/sourcegraph/sublime-lsp/statuses/f4f2d7413c17124664c6aa698f6a0be61dfd0576"}}}}
{"actor":{"display_login":"alexsaveliev"}}