{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corert/pulls/comments/88158681","pull_request_review_id":8740638,"id":88158681,"diff_hunk":"@@ -22,11 +22,11 @@ public enum ReadyToRunHelperId\n         GetThreadStaticBase,\n         DelegateCtor,\n         ResolveVirtualFunction,\n-\n         TypeHandle,\n         FieldHandle,\n         MethodDictionary,\n         MethodEntry,\n+        ResolveGenericVirtualMethod","path":"src/ILCompiler.Compiler/src/Compiler/DependencyAnalysis/ReadyToRunHelperNode.cs","position":9,"original_position":9,"commit_id":"ddee7c88788708f39f160aa01ddfe48ccc5cde0d","original_commit_id":"ddee7c88788708f39f160aa01ddfe48ccc5cde0d","user":{"login":"MichalStrehovsky","id":13110571,"avatar_url":"https://avatars.githubusercontent.com/u/13110571?v=3","gravatar_id":"","url":"https://api.github.com/users/MichalStrehovsky","html_url":"https://github.com/MichalStrehovsky","followers_url":"https://api.github.com/users/MichalStrehovsky/followers","following_url":"https://api.github.com/users/MichalStrehovsky/following{/other_user}","gists_url":"https://api.github.com/users/MichalStrehovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/MichalStrehovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichalStrehovsky/subscriptions","organizations_url":"https://api.github.com/users/MichalStrehovsky/orgs","repos_url":"https://api.github.com/users/MichalStrehovsky/repos","events_url":"https://api.github.com/users/MichalStrehovsky/events{/privacy}","received_events_url":"https://api.github.com/users/MichalStrehovsky/received_events","type":"User","site_admin":false},"body":"Do we really need a separate helper?","created_at":"2016-11-16T02:34:21Z","updated_at":"2016-11-16T02:38:05Z","html_url":"https://github.com/dotnet/corert/pull/2217#discussion_r88158681","pull_request_url":"https://api.github.com/repos/dotnet/corert/pulls/2217","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments/88158681"},"html":{"href":"https://github.com/dotnet/corert/pull/2217#discussion_r88158681"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corert/pulls/2217"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corert/pulls/2217","id":93887322,"html_url":"https://github.com/dotnet/corert/pull/2217","diff_url":"https://github.com/dotnet/corert/pull/2217.diff","patch_url":"https://github.com/dotnet/corert/pull/2217.patch","issue_url":"https://api.github.com/repos/dotnet/corert/issues/2217","number":2217,"state":"closed","locked":false,"title":"Allow GVMs to be present on types","user":{"login":"nattress","id":116900,"avatar_url":"https://avatars.githubusercontent.com/u/116900?v=3","gravatar_id":"","url":"https://api.github.com/users/nattress","html_url":"https://github.com/nattress","followers_url":"https://api.github.com/users/nattress/followers","following_url":"https://api.github.com/users/nattress/following{/other_user}","gists_url":"https://api.github.com/users/nattress/gists{/gist_id}","starred_url":"https://api.github.com/users/nattress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nattress/subscriptions","organizations_url":"https://api.github.com/users/nattress/orgs","repos_url":"https://api.github.com/users/nattress/repos","events_url":"https://api.github.com/users/nattress/events{/privacy}","received_events_url":"https://api.github.com/users/nattress/received_events","type":"User","site_admin":false},"body":"In order to compile larger bodies of code (such as XUnit) without full\r\nGVM support, emit a R2R helper at GVM callsites that fails fast at\r\nruntime. I left the check for GVMs in-place in\r\n`ConstructedEETypeNode.OutputVirtualSlots` to make sure we don't\r\nactually put them in the VTable since they'll eventually be dispatched\r\nvia a lookup table.","created_at":"2016-11-16T01:54:10Z","updated_at":"2016-11-16T02:38:05Z","closed_at":"2016-11-16T02:21:02Z","merged_at":"2016-11-16T02:21:02Z","merge_commit_sha":"642eddcaefc8a7ccad6a9a30877391482eeb0a49","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corert/pulls/2217/commits","review_comments_url":"https://api.github.com/repos/dotnet/corert/pulls/2217/comments","review_comment_url":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corert/issues/2217/comments","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/ddee7c88788708f39f160aa01ddfe48ccc5cde0d","head":{"label":"nattress:gvms","ref":"gvms","sha":"ddee7c88788708f39f160aa01ddfe48ccc5cde0d","user":{"login":"nattress","id":116900,"avatar_url":"https://avatars.githubusercontent.com/u/116900?v=3","gravatar_id":"","url":"https://api.github.com/users/nattress","html_url":"https://github.com/nattress","followers_url":"https://api.github.com/users/nattress/followers","following_url":"https://api.github.com/users/nattress/following{/other_user}","gists_url":"https://api.github.com/users/nattress/gists{/gist_id}","starred_url":"https://api.github.com/users/nattress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nattress/subscriptions","organizations_url":"https://api.github.com/users/nattress/orgs","repos_url":"https://api.github.com/users/nattress/repos","events_url":"https://api.github.com/users/nattress/events{/privacy}","received_events_url":"https://api.github.com/users/nattress/received_events","type":"User","site_admin":false},"repo":{"id":46596706,"name":"corert","full_name":"nattress/corert","owner":{"login":"nattress","id":116900,"avatar_url":"https://avatars.githubusercontent.com/u/116900?v=3","gravatar_id":"","url":"https://api.github.com/users/nattress","html_url":"https://github.com/nattress","followers_url":"https://api.github.com/users/nattress/followers","following_url":"https://api.github.com/users/nattress/following{/other_user}","gists_url":"https://api.github.com/users/nattress/gists{/gist_id}","starred_url":"https://api.github.com/users/nattress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nattress/subscriptions","organizations_url":"https://api.github.com/users/nattress/orgs","repos_url":"https://api.github.com/users/nattress/repos","events_url":"https://api.github.com/users/nattress/events{/privacy}","received_events_url":"https://api.github.com/users/nattress/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nattress/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET Native compiler toolchain.","fork":true,"url":"https://api.github.com/repos/nattress/corert","forks_url":"https://api.github.com/repos/nattress/corert/forks","keys_url":"https://api.github.com/repos/nattress/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nattress/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nattress/corert/teams","hooks_url":"https://api.github.com/repos/nattress/corert/hooks","issue_events_url":"https://api.github.com/repos/nattress/corert/issues/events{/number}","events_url":"https://api.github.com/repos/nattress/corert/events","assignees_url":"https://api.github.com/repos/nattress/corert/assignees{/user}","branches_url":"https://api.github.com/repos/nattress/corert/branches{/branch}","tags_url":"https://api.github.com/repos/nattress/corert/tags","blobs_url":"https://api.github.com/repos/nattress/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nattress/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nattress/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/nattress/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nattress/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/nattress/corert/languages","stargazers_url":"https://api.github.com/repos/nattress/corert/stargazers","contributors_url":"https://api.github.com/repos/nattress/corert/contributors","subscribers_url":"https://api.github.com/repos/nattress/corert/subscribers","subscription_url":"https://api.github.com/repos/nattress/corert/subscription","commits_url":"https://api.github.com/repos/nattress/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/nattress/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/nattress/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/nattress/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/nattress/corert/contents/{+path}","compare_url":"https://api.github.com/repos/nattress/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nattress/corert/merges","archive_url":"https://api.github.com/repos/nattress/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nattress/corert/downloads","issues_url":"https://api.github.com/repos/nattress/corert/issues{/number}","pulls_url":"https://api.github.com/repos/nattress/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/nattress/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/nattress/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nattress/corert/labels{/name}","releases_url":"https://api.github.com/repos/nattress/corert/releases{/id}","deployments_url":"https://api.github.com/repos/nattress/corert/deployments","created_at":"2015-11-21T01:52:47Z","updated_at":"2016-11-04T18:46:59Z","pushed_at":"2016-11-16T02:21:05Z","git_url":"git://github.com/nattress/corert.git","ssh_url":"git@github.com:nattress/corert.git","clone_url":"https://github.com/nattress/corert.git","svn_url":"https://github.com/nattress/corert","homepage":"http://dotnet.github.io/","size":12472,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"bcdf6145843bd5c51aca14d672787bf39d3a7616","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42552143,"name":"corert","full_name":"dotnet/corert","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET Native compiler toolchain.","fork":false,"url":"https://api.github.com/repos/dotnet/corert","forks_url":"https://api.github.com/repos/dotnet/corert/forks","keys_url":"https://api.github.com/repos/dotnet/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corert/teams","hooks_url":"https://api.github.com/repos/dotnet/corert/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corert/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corert/events","assignees_url":"https://api.github.com/repos/dotnet/corert/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corert/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corert/tags","blobs_url":"https://api.github.com/repos/dotnet/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corert/languages","stargazers_url":"https://api.github.com/repos/dotnet/corert/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corert/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corert/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corert/subscription","commits_url":"https://api.github.com/repos/dotnet/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corert/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corert/merges","archive_url":"https://api.github.com/repos/dotnet/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corert/downloads","issues_url":"https://api.github.com/repos/dotnet/corert/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corert/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corert/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corert/deployments","created_at":"2015-09-15T23:10:53Z","updated_at":"2016-11-14T10:52:22Z","pushed_at":"2016-11-16T02:21:02Z","git_url":"git://github.com/dotnet/corert.git","ssh_url":"git@github.com:dotnet/corert.git","clone_url":"https://github.com/dotnet/corert.git","svn_url":"https://github.com/dotnet/corert","homepage":"http://dotnet.github.io/","size":21932,"stargazers_count":473,"watchers_count":473,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":153,"mirror_url":null,"open_issues_count":161,"forks":153,"open_issues":161,"watchers":473,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/2217"},"html":{"href":"https://github.com/dotnet/corert/pull/2217"},"issue":{"href":"https://api.github.com/repos/dotnet/corert/issues/2217"},"comments":{"href":"https://api.github.com/repos/dotnet/corert/issues/2217/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corert/pulls/2217/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corert/pulls/2217/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corert/statuses/ddee7c88788708f39f160aa01ddfe48ccc5cde0d"}}}}
{"actor":{"display_login":"MichalStrehovsky"}}