{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/70862542","id":70862542,"diff_hunk":"@@ -299,6 +302,9 @@ type ComponentInput struct {\n \n \tExpectToBuild bool\n \tScratchImage  bool\n+\t// For keeping track of if this image was retrieved from a Dockerfile,\n+\t// which changes our BuildConfig results","path":"pkg/generate/app/componentref.go","position":20,"original_position":20,"commit_id":"270d95525e9d9acf843396831f02be294d5cd275","original_commit_id":"270d95525e9d9acf843396831f02be294d5cd275","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"@rhcarvalho in your scenario, FromDockerfile would be false.\r\n\r\nFromDockerfile is true when we figured out which image you want to use by parsing the Dockerfile you supplied (either in the repo or via the -D flag).\r\n\r\n@oatmealraisin it would be better if this comment explained *how* it changes the results.  \"when true, an imagechangetrigger will not be associated with the buildconfig because the user has not expressed a desire to reference an imagestream, they are directly referencing an image\"  or some such thing.\r\n\r\n","created_at":"2016-07-14T18:52:42Z","updated_at":"2016-07-14T18:52:42Z","html_url":"https://github.com/openshift/origin/pull/9553#discussion_r70862542","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/9553","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/70862542"},"html":{"href":"https://github.com/openshift/origin/pull/9553#discussion_r70862542"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/9553"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/9553","id":75161634,"html_url":"https://github.com/openshift/origin/pull/9553","diff_url":"https://github.com/openshift/origin/pull/9553.diff","patch_url":"https://github.com/openshift/origin/pull/9553.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/9553","number":9553,"state":"open","locked":false,"title":"Removed fields added to the build strategy when using --strategy=docker.","user":{"login":"oatmealraisin","id":6402382,"avatar_url":"https://avatars.githubusercontent.com/u/6402382?v=3","gravatar_id":"","url":"https://api.github.com/users/oatmealraisin","html_url":"https://github.com/oatmealraisin","followers_url":"https://api.github.com/users/oatmealraisin/followers","following_url":"https://api.github.com/users/oatmealraisin/following{/other_user}","gists_url":"https://api.github.com/users/oatmealraisin/gists{/gist_id}","starred_url":"https://api.github.com/users/oatmealraisin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oatmealraisin/subscriptions","organizations_url":"https://api.github.com/users/oatmealraisin/orgs","repos_url":"https://api.github.com/users/oatmealraisin/repos","events_url":"https://api.github.com/users/oatmealraisin/events{/privacy}","received_events_url":"https://api.github.com/users/oatmealraisin/received_events","type":"User","site_admin":false},"body":"Fixes #6347 \r\n\r\nOld output:\r\n```\r\n$ oc new-app https://github.com/openshift/ruby-hello-world --strategy=docker -o yaml\r\n...\r\n- apiVersion: v1\r\n  kind: BuildConfig\r\n  metadata:\r\n    annotations:\r\n      openshift.io/generated-by: OpenShiftNewApp\r\n    creationTimestamp: null\r\n    labels:\r\n      app: ruby-hello-world\r\n    name: ruby-hello-world\r\n  spec:\r\n    output:\r\n      to:\r\n        kind: ImageStreamTag\r\n        name: ruby-hello-world:latest\r\n    postCommit: {}\r\n    resources: {}\r\n    source:\r\n      git:\r\n        uri: https://github.com/openshift/ruby-hello-world\r\n      secrets: []\r\n      type: Git\r\n    strategy:\r\n      dockerStrategy:\r\n        from:\r\n          kind: ImageStreamTag\r\n          name: ruby-22-centos7:latest\r\n      type: Docker\r\n    triggers:\r\n    - github:\r\n        secret: 9kT3d_Dtngco-2amnzkE\r\n      type: GitHub\r\n    - generic:\r\n        secret: b5HW8CYUDQqVK7UgTO7F\r\n      type: Generic\r\n    - type: ConfigChange\r\n    - imageChange: {}\r\n      type: ImageChange\r\n  status:\r\n    lastVersion: 0\r\n...\r\n```\r\n\r\nNew Output:\r\n```\r\n$ oc new-app https://github.com/openshift/ruby-hello-world --strategy=docker -o yaml\r\n...\r\n- apiVersion: v1\r\n  kind: BuildConfig\r\n  metadata:\r\n    annotations:\r\n      openshift.io/generated-by: OpenShiftNewApp\r\n    creationTimestamp: null\r\n    labels:\r\n      app: ruby-hello-world\r\n    name: ruby-hello-world\r\n  spec:\r\n    output:\r\n      to:\r\n        kind: ImageStreamTag\r\n        name: ruby-hello-world:latest\r\n    postCommit: {}\r\n    resources: {}\r\n    source:\r\n      git:\r\n        uri: https://github.com/openshift/ruby-hello-world\r\n      secrets: []\r\n      type: Git\r\n    strategy:\r\n      dockerStrategy: {}\r\n      type: Docker\r\n    triggers:\r\n    - github:\r\n        secret: ue-VeLrxT1w_OnBpdQhp\r\n      type: GitHub\r\n    - generic:\r\n        secret: oS3Jr_kkqLvLPQJqsntn\r\n      type: Generic\r\n    - type: ConfigChange\r\n    - imageChange: {}\r\n      type: ImageChange\r\n  status:\r\n    lastVersion: 0\r\n...\r\n```","created_at":"2016-06-24T19:26:23Z","updated_at":"2016-07-14T18:52:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7246994ea2b8727e48783fa8962efaa2b9c14133","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/9553/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/9553/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/9553/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/270d95525e9d9acf843396831f02be294d5cd275","head":{"label":"oatmealraisin:rymurphy_6347","ref":"rymurphy_6347","sha":"270d95525e9d9acf843396831f02be294d5cd275","user":{"login":"oatmealraisin","id":6402382,"avatar_url":"https://avatars.githubusercontent.com/u/6402382?v=3","gravatar_id":"","url":"https://api.github.com/users/oatmealraisin","html_url":"https://github.com/oatmealraisin","followers_url":"https://api.github.com/users/oatmealraisin/followers","following_url":"https://api.github.com/users/oatmealraisin/following{/other_user}","gists_url":"https://api.github.com/users/oatmealraisin/gists{/gist_id}","starred_url":"https://api.github.com/users/oatmealraisin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oatmealraisin/subscriptions","organizations_url":"https://api.github.com/users/oatmealraisin/orgs","repos_url":"https://api.github.com/users/oatmealraisin/repos","events_url":"https://api.github.com/users/oatmealraisin/events{/privacy}","received_events_url":"https://api.github.com/users/oatmealraisin/received_events","type":"User","site_admin":false},"repo":{"id":60552506,"name":"origin","full_name":"oatmealraisin/origin","owner":{"login":"oatmealraisin","id":6402382,"avatar_url":"https://avatars.githubusercontent.com/u/6402382?v=3","gravatar_id":"","url":"https://api.github.com/users/oatmealraisin","html_url":"https://github.com/oatmealraisin","followers_url":"https://api.github.com/users/oatmealraisin/followers","following_url":"https://api.github.com/users/oatmealraisin/following{/other_user}","gists_url":"https://api.github.com/users/oatmealraisin/gists{/gist_id}","starred_url":"https://api.github.com/users/oatmealraisin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oatmealraisin/subscriptions","organizations_url":"https://api.github.com/users/oatmealraisin/orgs","repos_url":"https://api.github.com/users/oatmealraisin/repos","events_url":"https://api.github.com/users/oatmealraisin/events{/privacy}","received_events_url":"https://api.github.com/users/oatmealraisin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oatmealraisin/origin","description":"OpenShift - Build, deploy, and manage cloud-native and legacy applications with Kubernetes and Docker","fork":true,"url":"https://api.github.com/repos/oatmealraisin/origin","forks_url":"https://api.github.com/repos/oatmealraisin/origin/forks","keys_url":"https://api.github.com/repos/oatmealraisin/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oatmealraisin/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oatmealraisin/origin/teams","hooks_url":"https://api.github.com/repos/oatmealraisin/origin/hooks","issue_events_url":"https://api.github.com/repos/oatmealraisin/origin/issues/events{/number}","events_url":"https://api.github.com/repos/oatmealraisin/origin/events","assignees_url":"https://api.github.com/repos/oatmealraisin/origin/assignees{/user}","branches_url":"https://api.github.com/repos/oatmealraisin/origin/branches{/branch}","tags_url":"https://api.github.com/repos/oatmealraisin/origin/tags","blobs_url":"https://api.github.com/repos/oatmealraisin/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oatmealraisin/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oatmealraisin/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/oatmealraisin/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oatmealraisin/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/oatmealraisin/origin/languages","stargazers_url":"https://api.github.com/repos/oatmealraisin/origin/stargazers","contributors_url":"https://api.github.com/repos/oatmealraisin/origin/contributors","subscribers_url":"https://api.github.com/repos/oatmealraisin/origin/subscribers","subscription_url":"https://api.github.com/repos/oatmealraisin/origin/subscription","commits_url":"https://api.github.com/repos/oatmealraisin/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/oatmealraisin/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/oatmealraisin/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/oatmealraisin/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/oatmealraisin/origin/contents/{+path}","compare_url":"https://api.github.com/repos/oatmealraisin/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oatmealraisin/origin/merges","archive_url":"https://api.github.com/repos/oatmealraisin/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oatmealraisin/origin/downloads","issues_url":"https://api.github.com/repos/oatmealraisin/origin/issues{/number}","pulls_url":"https://api.github.com/repos/oatmealraisin/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/oatmealraisin/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/oatmealraisin/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oatmealraisin/origin/labels{/name}","releases_url":"https://api.github.com/repos/oatmealraisin/origin/releases{/id}","deployments_url":"https://api.github.com/repos/oatmealraisin/origin/deployments","created_at":"2016-06-06T18:47:57Z","updated_at":"2016-06-06T18:48:05Z","pushed_at":"2016-07-14T16:41:33Z","git_url":"git://github.com/oatmealraisin/origin.git","ssh_url":"git@github.com:oatmealraisin/origin.git","clone_url":"https://github.com/oatmealraisin/origin.git","svn_url":"https://github.com/oatmealraisin/origin","homepage":"http://www.openshift.org","size":271890,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"ff15d547def47854a33b64e47293ef2c468d40c2","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-07-14T16:38:31Z","pushed_at":"2016-07-14T18:50:19Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":542874,"stargazers_count":1483,"watchers_count":1483,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":882,"mirror_url":null,"open_issues_count":1062,"forks":882,"open_issues":1062,"watchers":1483,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/9553"},"html":{"href":"https://github.com/openshift/origin/pull/9553"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/9553"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/9553/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/9553/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/9553/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/270d95525e9d9acf843396831f02be294d5cd275"}}}}
{"actor":{"display_login":"bparees"}}