{"action":"created","issue":{"url":"https://api.github.com/repos/wix/react-native-navigation/issues/223","repository_url":"https://api.github.com/repos/wix/react-native-navigation","labels_url":"https://api.github.com/repos/wix/react-native-navigation/issues/223/labels{/name}","comments_url":"https://api.github.com/repos/wix/react-native-navigation/issues/223/comments","events_url":"https://api.github.com/repos/wix/react-native-navigation/issues/223/events","html_url":"https://github.com/wix/react-native-navigation/issues/223","id":172340015,"number":223,"title":"Android Install Readme Incomplete","user":{"login":"AdamBrodzinski","id":1445367,"avatar_url":"https://avatars.githubusercontent.com/u/1445367?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamBrodzinski","html_url":"https://github.com/AdamBrodzinski","followers_url":"https://api.github.com/users/AdamBrodzinski/followers","following_url":"https://api.github.com/users/AdamBrodzinski/following{/other_user}","gists_url":"https://api.github.com/users/AdamBrodzinski/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamBrodzinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamBrodzinski/subscriptions","organizations_url":"https://api.github.com/users/AdamBrodzinski/orgs","repos_url":"https://api.github.com/users/AdamBrodzinski/repos","events_url":"https://api.github.com/users/AdamBrodzinski/events{/privacy}","received_events_url":"https://api.github.com/users/AdamBrodzinski/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"DanielZlotin","id":6660239,"avatar_url":"https://avatars.githubusercontent.com/u/6660239?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielZlotin","html_url":"https://github.com/DanielZlotin","followers_url":"https://api.github.com/users/DanielZlotin/followers","following_url":"https://api.github.com/users/DanielZlotin/following{/other_user}","gists_url":"https://api.github.com/users/DanielZlotin/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielZlotin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielZlotin/subscriptions","organizations_url":"https://api.github.com/users/DanielZlotin/orgs","repos_url":"https://api.github.com/users/DanielZlotin/repos","events_url":"https://api.github.com/users/DanielZlotin/events{/privacy}","received_events_url":"https://api.github.com/users/DanielZlotin/received_events","type":"User","site_admin":false},"assignees":[{"login":"DanielZlotin","id":6660239,"avatar_url":"https://avatars.githubusercontent.com/u/6660239?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielZlotin","html_url":"https://github.com/DanielZlotin","followers_url":"https://api.github.com/users/DanielZlotin/followers","following_url":"https://api.github.com/users/DanielZlotin/following{/other_user}","gists_url":"https://api.github.com/users/DanielZlotin/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielZlotin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielZlotin/subscriptions","organizations_url":"https://api.github.com/users/DanielZlotin/orgs","repos_url":"https://api.github.com/users/DanielZlotin/repos","events_url":"https://api.github.com/users/DanielZlotin/events{/privacy}","received_events_url":"https://api.github.com/users/DanielZlotin/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/wix/react-native-navigation/milestones/1","html_url":"https://github.com/wix/react-native-navigation/milestones/2.0.0","labels_url":"https://api.github.com/repos/wix/react-native-navigation/milestones/1/labels","id":1914844,"number":1,"title":"2.0.0","description":"We wanted to share with you our general plans for version 2.0.0\r\n\r\nWe'll use this milestone to collect all PRs and issues that will be a part of the version.\r\nOur general goals for this version are:\r\n\r\n1. React-native-controllers will be deprecated and fully merged into react-native-navigation.\r\n2. iOS - Redesign and Refactor\r\n3. Android - Redesign and Refactor\r\n4. Complete feature parity between Android and iOS\r\n5. upgrade to latest react-native\r\nThe main feature that we are planning for this version are:\r\n1. Screens lifecycle\r\n2. Pass props and functions\r\n3. Dynamic styling\r\n4. Drawer for Android","creator":{"login":"DanielZlotin","id":6660239,"avatar_url":"https://avatars.githubusercontent.com/u/6660239?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielZlotin","html_url":"https://github.com/DanielZlotin","followers_url":"https://api.github.com/users/DanielZlotin/followers","following_url":"https://api.github.com/users/DanielZlotin/following{/other_user}","gists_url":"https://api.github.com/users/DanielZlotin/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielZlotin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielZlotin/subscriptions","organizations_url":"https://api.github.com/users/DanielZlotin/orgs","repos_url":"https://api.github.com/users/DanielZlotin/repos","events_url":"https://api.github.com/users/DanielZlotin/events{/privacy}","received_events_url":"https://api.github.com/users/DanielZlotin/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":25,"state":"open","created_at":"2016-08-01T07:15:56Z","updated_at":"2016-09-12T09:21:21Z","due_on":"2016-11-30T00:00:00Z","closed_at":null},"comments":25,"created_at":"2016-08-21T20:35:54Z","updated_at":"2016-09-15T05:09:22Z","closed_at":null,"body":"First I want to say thanks for making this library. It's working awesome on iOS!!\r\n\r\nI'm struggling to make it work for Android though. It seems like the readme for Android breaks down half way and assumes knowledge of the Android ecosystem.\r\n\r\nI'm also happy to PR fixes to the readme once I can figure out what's missing.\r\n\r\nReact Native 0.30\r\nReact 15.2.0\r\nreact-native-navigation 2.0.0-experimental.71\r\n\r\nFirstly the readme says to run `npm install react-native-navigation --save` but that installs version 1.X. This works for iOS but fails on Android with a missing Splash module.\r\n\r\nAn hour later I figured out that I needed the 2.0 beta and installed that. Steps 1 and 2 and great and didn't have any issues with that.\r\n\r\nStep 3 assumes you know where to locate `MainActivity`. Then after extending the class I hit a missing symbol error and guessed at importing the missing file (and also later confirmed by looking at the redux example).\r\n\r\nStep 4 completely loses me but i've figured out how to at least make the compiler work... though the app launches with \"Foo stopped running\" so I must be doing something wrong here. \r\n\r\nMy fresh app had a `MainApplication.java` file which I commented out and added an `App.java` file like your examples. I added in the custom class (with name of App instead of MyApplication) and changed the xml file. The instructions for changing the XML is not enough for a non Android dev. I guessed by looking at the example.\r\n\r\nUltimately I still can't get the app to work on an upgraded RN 0.30 install (and used react-native upgrade).\r\n\r\nHere are my changed Android files:\r\n\r\nadded `android:name=\".App\"` to config\r\n```xml\r\n<manifest xmlns:android=\"http://schemas.android.com/apk/res/android\"\r\n    package=\"com.badger\">\r\n\r\n    <uses-permission android:name=\"android.permission.INTERNET\" />\r\n\r\n    <application\r\n      android:name=\".App\"\r\n      android:allowBackup=\"true\"\r\n      android:label=\"@string/app_name\"\r\n      android:icon=\"@mipmap/ic_launcher\"\r\n      android:theme=\"@style/AppTheme\">\r\n      <activity\r\n        android:name=\".MainActivity\"\r\n        android:label=\"@string/app_name\"\r\n        android:configChanges=\"keyboard|keyboardHidden|orientation|screenSize\">\r\n        <intent-filter>\r\n            <action android:name=\"android.intent.action.MAIN\" />\r\n            <category android:name=\"android.intent.category.LAUNCHER\" />\r\n        </intent-filter>\r\n      </activity>\r\n      <activity android:name=\"com.facebook.react.devsupport.DevSettingsActivity\" />\r\n    </application>\r\n\r\n</manifest>\r\n```\r\n\r\n```java\r\npackage com.badger;\r\n\r\nimport com.reactnativenavigation.controllers.SplashActivity;\r\n\r\npublic class MainActivity extends SplashActivity {\r\n\r\n}\r\n```\r\n\r\n```java\r\n// ..../com/badger/App.java\r\npackage com.badger;\r\n\r\nimport android.support.annotation.NonNull;\r\n\r\nimport com.facebook.react.ReactPackage;\r\nimport com.reactnativenavigation.NavigationApplication;\r\n\r\nimport java.util.Collections;\r\nimport java.util.List;\r\n\r\npublic class App extends NavigationApplication {\r\n    @Override\r\n    public boolean isDebug() {\r\n        return BuildConfig.DEBUG;\r\n    }\r\n\r\n    @NonNull\r\n    @Override\r\n    public List<ReactPackage> createAdditionalReactPackages() {\r\n        return Collections.emptyList();\r\n    }\r\n}\r\n```\r\n\r\n```java\r\n// ..../com/badger/MainApplication.java\r\n/*\r\npackage com.badger;\r\n\r\nimport android.app.Application;\r\nimport android.util.Log;\r\n\r\nimport com.facebook.react.ReactApplication;\r\nimport com.facebook.react.ReactInstanceManager;\r\nimport com.facebook.react.ReactNativeHost;\r\nimport com.facebook.react.ReactPackage;\r\nimport com.facebook.react.shell.MainReactPackage;\r\n\r\nimport java.util.Arrays;\r\nimport java.util.List;\r\n\r\npublic class MainApplication extends Application implements ReactApplication {\r\n\r\n  private final ReactNativeHost mReactNativeHost = new ReactNativeHost(this) {\r\n    @Override\r\n    protected boolean getUseDeveloperSupport() {\r\n      return BuildConfig.DEBUG;\r\n    }\r\n\r\n    @Override\r\n    protected List<ReactPackage> getPackages() {\r\n      return Arrays.<ReactPackage>asList(\r\n          new MainReactPackage()\r\n      );\r\n    }\r\n  };\r\n\r\n  @Override\r\n  public ReactNativeHost getReactNativeHost() {\r\n      return mReactNativeHost;\r\n  }\r\n}\r\n*/\r\n```\r\n\r\nWith the logger running I get this once starting up:\r\n\r\n```\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: FATAL EXCEPTION: main\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: Process: com.badger, PID: 2577\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: java.lang.RuntimeException: Unable to instantiate application com.badger.App: java.lang.ClassNotFoundException: Didn't find class \"com.badger.App\" on path: DexPathList[[zip file \"/data/app/com.badger-2/base.apk\"],nativeLibraryDirectories=[/data/app/com.badger-2/lib/x86, /data/app/com.badger-2/base.apk!/lib/x86, /vendor/lib, /system/lib]]\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \tat android.app.LoadedApk.makeApplication(LoadedApk.java:578)\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \tat android.app.ActivityThread.handleBindApplication(ActivityThread.java:4680)\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \tat android.app.ActivityThread.-wrap1(ActivityThread.java)\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \tat android.app.ActivityThread$H.handleMessage(ActivityThread.java:1405)\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \tat android.os.Handler.dispatchMessage(Handler.java:102)\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \tat android.os.Looper.loop(Looper.java:148)\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \tat android.app.ActivityThread.main(ActivityThread.java:5417)\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \tat java.lang.reflect.Method.invoke(Native Method)\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \tat com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \tat com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: Caused by: java.lang.ClassNotFoundException: Didn't find class \"com.badger.App\" on path: DexPathList[[zip file \"/data/app/com.badger-2/base.apk\"],nativeLibraryDirectories=[/data/app/com.badger-2/lib/x86, /data/app/com.badger-2/base.apk!/lib/x86, /vendor/lib, /system/lib]]\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \tat dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:56)\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \tat java.lang.ClassLoader.loadClass(ClassLoader.java:511)\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \tat java.lang.ClassLoader.loadClass(ClassLoader.java:469)\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \tat android.app.Instrumentation.newApplication(Instrumentation.java:981)\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \tat android.app.LoadedApk.makeApplication(LoadedApk.java:573)\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \t... 9 more\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \tSuppressed: java.lang.ClassNotFoundException: com.badger.App\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \t\tat java.lang.Class.classForName(Native Method)\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \t\tat java.lang.BootClassLoader.findClass(ClassLoader.java:781)\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \t\tat java.lang.BootClassLoader.loadClass(ClassLoader.java:841)\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \t\tat java.lang.ClassLoader.loadClass(ClassLoader.java:504)\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \t\t... 12 more\r\n08-21 16:28:57.672  2577  2577 E AndroidRuntime: \tCaused by: java.lang.NoClassDefFoundError: Class not found using the boot class loader; no stack trace available\r\n```\r\n\r\nVery confused... any help would be appreciated!!"},"comment":{"url":"https://api.github.com/repos/wix/react-native-navigation/issues/comments/247236168","html_url":"https://github.com/wix/react-native-navigation/issues/223#issuecomment-247236168","issue_url":"https://api.github.com/repos/wix/react-native-navigation/issues/223","id":247236168,"user":{"login":"guyca","id":12352397,"avatar_url":"https://avatars.githubusercontent.com/u/12352397?v=3","gravatar_id":"","url":"https://api.github.com/users/guyca","html_url":"https://github.com/guyca","followers_url":"https://api.github.com/users/guyca/followers","following_url":"https://api.github.com/users/guyca/following{/other_user}","gists_url":"https://api.github.com/users/guyca/gists{/gist_id}","starred_url":"https://api.github.com/users/guyca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyca/subscriptions","organizations_url":"https://api.github.com/users/guyca/orgs","repos_url":"https://api.github.com/users/guyca/repos","events_url":"https://api.github.com/users/guyca/events{/privacy}","received_events_url":"https://api.github.com/users/guyca/received_events","type":"User","site_admin":false},"created_at":"2016-09-15T05:09:22Z","updated_at":"2016-09-15T05:09:22Z","body":"@beast He means it's enough to specify `compile project(':react-native-navigation')` since there are no differences between release and debug versions."}}
{"actor":{"display_login":"guyca"}}