{"action":"created","comment":{"url":"https://api.github.com/repos/google/WebFundamentals/pulls/comments/91370716","pull_request_review_id":11879657,"id":91370716,"diff_hunk":"@@ -0,0 +1,37 @@\n+project_path: /web/_project.yaml\n+book_path: /web/tools/_book.yaml\n+description: Reference documentation for the \"Page Does Not Automatically Request Geolocation On Page Load\" Lighthouse audit.\n+\n+{# wf_updated_on: 2016-11-30 #}\n+{# wf_published_on: 2016-11-30 #}\n+\n+# Page Does Not Automatically Request Geolocation On Page Load  {: .page-title }\n+\n+## Why the audit is important {: #why }\n+\n+Users are mistrustful of or confused by pages that automatically request\n+their location on page load. Rather than automatically requesting a\n+user's location on page load, tie the request to a user's gesture, such as\n+a tapping a \"Find Stores Near Me\" button. Make sure that the gesture clearly\n+and explicitly expresses the need for the user's location.\n+\n+## How to pass the audit {: #how }\n+\n+Under **URLs**, Lighthouse reports the line and column numbers where your\n+code is requesting the user's location. Remove these calls, and tie the\n+requests to user gestures instead. \n+\n+See [Ask permission responsibly][ask] for a list of best practices when\n+requesting a user's location.\n+\n+[ask]: /web/fundamentals/native-hardware/user-location/#ask_permission_responsibly\n+\n+{% include \"web/tools/lighthouse/audits/implementation-heading.html\" %}\n+\n+If geolocation permission was already granted to a page before Lighthouse's\n+audit, Lighthouse cannot determine if the page requests the user's location\n+on page load. Reset the permissions and run Lighthouse again.\n+\n+Lighthouse collects the JavaScript that was executed on page load. If this\n+code contains calls to `geolocation.getCurrentPosition()` or\n+`geolocation.watchPosition()`, then the user's location was requested.","path":"src/content/en/tools/lighthouse/audits/geolocation-on-load.md","position":37,"original_position":37,"commit_id":"730bdaef58e9211a59e8302b605cd1ceeb885ca6","original_commit_id":"31ecd243a3a3861d17028cce609f1e2a93d60fb0","user":{"login":"kaycebasques","id":4713486,"avatar_url":"https://avatars.githubusercontent.com/u/4713486?v=3","gravatar_id":"","url":"https://api.github.com/users/kaycebasques","html_url":"https://github.com/kaycebasques","followers_url":"https://api.github.com/users/kaycebasques/followers","following_url":"https://api.github.com/users/kaycebasques/following{/other_user}","gists_url":"https://api.github.com/users/kaycebasques/gists{/gist_id}","starred_url":"https://api.github.com/users/kaycebasques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaycebasques/subscriptions","organizations_url":"https://api.github.com/users/kaycebasques/orgs","repos_url":"https://api.github.com/users/kaycebasques/repos","events_url":"https://api.github.com/users/kaycebasques/events{/privacy}","received_events_url":"https://api.github.com/users/kaycebasques/received_events","type":"User","site_admin":false},"body":":heavy_check_mark: ","created_at":"2016-12-07T19:40:22Z","updated_at":"2016-12-07T19:40:22Z","html_url":"https://github.com/google/WebFundamentals/pull/3926#discussion_r91370716","pull_request_url":"https://api.github.com/repos/google/WebFundamentals/pulls/3926","_links":{"self":{"href":"https://api.github.com/repos/google/WebFundamentals/pulls/comments/91370716"},"html":{"href":"https://github.com/google/WebFundamentals/pull/3926#discussion_r91370716"},"pull_request":{"href":"https://api.github.com/repos/google/WebFundamentals/pulls/3926"}}},"pull_request":{"url":"https://api.github.com/repos/google/WebFundamentals/pulls/3926","id":96648243,"html_url":"https://github.com/google/WebFundamentals/pull/3926","diff_url":"https://github.com/google/WebFundamentals/pull/3926.diff","patch_url":"https://github.com/google/WebFundamentals/pull/3926.patch","issue_url":"https://api.github.com/repos/google/WebFundamentals/issues/3926","number":3926,"state":"open","locked":false,"title":"add do better web audit references","user":{"login":"kaycebasques","id":4713486,"avatar_url":"https://avatars.githubusercontent.com/u/4713486?v=3","gravatar_id":"","url":"https://api.github.com/users/kaycebasques","html_url":"https://github.com/kaycebasques","followers_url":"https://api.github.com/users/kaycebasques/followers","following_url":"https://api.github.com/users/kaycebasques/following{/other_user}","gists_url":"https://api.github.com/users/kaycebasques/gists{/gist_id}","starred_url":"https://api.github.com/users/kaycebasques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaycebasques/subscriptions","organizations_url":"https://api.github.com/users/kaycebasques/orgs","repos_url":"https://api.github.com/users/kaycebasques/repos","events_url":"https://api.github.com/users/kaycebasques/events{/privacy}","received_events_url":"https://api.github.com/users/kaycebasques/received_events","type":"User","site_admin":false},"body":"ok @ebidel you're up, plz review","created_at":"2016-12-06T02:12:31Z","updated_at":"2016-12-07T19:40:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4cb0158266ac4ed0ad7cbc819b08cfde1013af79","assignee":{"login":"ebidel","id":238208,"avatar_url":"https://avatars.githubusercontent.com/u/238208?v=3","gravatar_id":"","url":"https://api.github.com/users/ebidel","html_url":"https://github.com/ebidel","followers_url":"https://api.github.com/users/ebidel/followers","following_url":"https://api.github.com/users/ebidel/following{/other_user}","gists_url":"https://api.github.com/users/ebidel/gists{/gist_id}","starred_url":"https://api.github.com/users/ebidel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebidel/subscriptions","organizations_url":"https://api.github.com/users/ebidel/orgs","repos_url":"https://api.github.com/users/ebidel/repos","events_url":"https://api.github.com/users/ebidel/events{/privacy}","received_events_url":"https://api.github.com/users/ebidel/received_events","type":"User","site_admin":false},"assignees":[{"login":"ebidel","id":238208,"avatar_url":"https://avatars.githubusercontent.com/u/238208?v=3","gravatar_id":"","url":"https://api.github.com/users/ebidel","html_url":"https://github.com/ebidel","followers_url":"https://api.github.com/users/ebidel/followers","following_url":"https://api.github.com/users/ebidel/following{/other_user}","gists_url":"https://api.github.com/users/ebidel/gists{/gist_id}","starred_url":"https://api.github.com/users/ebidel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebidel/subscriptions","organizations_url":"https://api.github.com/users/ebidel/orgs","repos_url":"https://api.github.com/users/ebidel/repos","events_url":"https://api.github.com/users/ebidel/events{/privacy}","received_events_url":"https://api.github.com/users/ebidel/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/WebFundamentals/pulls/3926/commits","review_comments_url":"https://api.github.com/repos/google/WebFundamentals/pulls/3926/comments","review_comment_url":"https://api.github.com/repos/google/WebFundamentals/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/WebFundamentals/issues/3926/comments","statuses_url":"https://api.github.com/repos/google/WebFundamentals/statuses/730bdaef58e9211a59e8302b605cd1ceeb885ca6","head":{"label":"kaycebasques:lighthouse-dbw","ref":"lighthouse-dbw","sha":"730bdaef58e9211a59e8302b605cd1ceeb885ca6","user":{"login":"kaycebasques","id":4713486,"avatar_url":"https://avatars.githubusercontent.com/u/4713486?v=3","gravatar_id":"","url":"https://api.github.com/users/kaycebasques","html_url":"https://github.com/kaycebasques","followers_url":"https://api.github.com/users/kaycebasques/followers","following_url":"https://api.github.com/users/kaycebasques/following{/other_user}","gists_url":"https://api.github.com/users/kaycebasques/gists{/gist_id}","starred_url":"https://api.github.com/users/kaycebasques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaycebasques/subscriptions","organizations_url":"https://api.github.com/users/kaycebasques/orgs","repos_url":"https://api.github.com/users/kaycebasques/repos","events_url":"https://api.github.com/users/kaycebasques/events{/privacy}","received_events_url":"https://api.github.com/users/kaycebasques/received_events","type":"User","site_admin":false},"repo":{"id":46754727,"name":"WebFundamentals","full_name":"kaycebasques/WebFundamentals","owner":{"login":"kaycebasques","id":4713486,"avatar_url":"https://avatars.githubusercontent.com/u/4713486?v=3","gravatar_id":"","url":"https://api.github.com/users/kaycebasques","html_url":"https://github.com/kaycebasques","followers_url":"https://api.github.com/users/kaycebasques/followers","following_url":"https://api.github.com/users/kaycebasques/following{/other_user}","gists_url":"https://api.github.com/users/kaycebasques/gists{/gist_id}","starred_url":"https://api.github.com/users/kaycebasques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaycebasques/subscriptions","organizations_url":"https://api.github.com/users/kaycebasques/orgs","repos_url":"https://api.github.com/users/kaycebasques/repos","events_url":"https://api.github.com/users/kaycebasques/events{/privacy}","received_events_url":"https://api.github.com/users/kaycebasques/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaycebasques/WebFundamentals","description":"Best practices for modern web development","fork":true,"url":"https://api.github.com/repos/kaycebasques/WebFundamentals","forks_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/forks","keys_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/teams","hooks_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/hooks","issue_events_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/issues/events{/number}","events_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/events","assignees_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/assignees{/user}","branches_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/branches{/branch}","tags_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/tags","blobs_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/statuses/{sha}","languages_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/languages","stargazers_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/stargazers","contributors_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/contributors","subscribers_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/subscribers","subscription_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/subscription","commits_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/contents/{+path}","compare_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/merges","archive_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/downloads","issues_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/issues{/number}","pulls_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/pulls{/number}","milestones_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/milestones{/number}","notifications_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/labels{/name}","releases_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/releases{/id}","deployments_url":"https://api.github.com/repos/kaycebasques/WebFundamentals/deployments","created_at":"2015-11-23T23:33:37Z","updated_at":"2016-11-30T06:20:14Z","pushed_at":"2016-12-07T18:59:05Z","git_url":"git://github.com/kaycebasques/WebFundamentals.git","ssh_url":"git@github.com:kaycebasques/WebFundamentals.git","clone_url":"https://github.com/kaycebasques/WebFundamentals.git","svn_url":"https://github.com/kaycebasques/WebFundamentals","homepage":"https://developers.google.com/web/fundamentals","size":1151575,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"7cf9c4d0c194d5c213a8dec3353a80d95987b5fa","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":19249835,"name":"WebFundamentals","full_name":"google/WebFundamentals","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/WebFundamentals","description":"Best practices for modern web development","fork":false,"url":"https://api.github.com/repos/google/WebFundamentals","forks_url":"https://api.github.com/repos/google/WebFundamentals/forks","keys_url":"https://api.github.com/repos/google/WebFundamentals/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/WebFundamentals/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/WebFundamentals/teams","hooks_url":"https://api.github.com/repos/google/WebFundamentals/hooks","issue_events_url":"https://api.github.com/repos/google/WebFundamentals/issues/events{/number}","events_url":"https://api.github.com/repos/google/WebFundamentals/events","assignees_url":"https://api.github.com/repos/google/WebFundamentals/assignees{/user}","branches_url":"https://api.github.com/repos/google/WebFundamentals/branches{/branch}","tags_url":"https://api.github.com/repos/google/WebFundamentals/tags","blobs_url":"https://api.github.com/repos/google/WebFundamentals/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/WebFundamentals/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/WebFundamentals/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/WebFundamentals/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/WebFundamentals/statuses/{sha}","languages_url":"https://api.github.com/repos/google/WebFundamentals/languages","stargazers_url":"https://api.github.com/repos/google/WebFundamentals/stargazers","contributors_url":"https://api.github.com/repos/google/WebFundamentals/contributors","subscribers_url":"https://api.github.com/repos/google/WebFundamentals/subscribers","subscription_url":"https://api.github.com/repos/google/WebFundamentals/subscription","commits_url":"https://api.github.com/repos/google/WebFundamentals/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/WebFundamentals/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/WebFundamentals/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/WebFundamentals/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/WebFundamentals/contents/{+path}","compare_url":"https://api.github.com/repos/google/WebFundamentals/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/WebFundamentals/merges","archive_url":"https://api.github.com/repos/google/WebFundamentals/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/WebFundamentals/downloads","issues_url":"https://api.github.com/repos/google/WebFundamentals/issues{/number}","pulls_url":"https://api.github.com/repos/google/WebFundamentals/pulls{/number}","milestones_url":"https://api.github.com/repos/google/WebFundamentals/milestones{/number}","notifications_url":"https://api.github.com/repos/google/WebFundamentals/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/WebFundamentals/labels{/name}","releases_url":"https://api.github.com/repos/google/WebFundamentals/releases{/id}","deployments_url":"https://api.github.com/repos/google/WebFundamentals/deployments","created_at":"2014-04-28T18:45:45Z","updated_at":"2016-12-07T15:08:21Z","pushed_at":"2016-12-07T19:34:34Z","git_url":"git://github.com/google/WebFundamentals.git","ssh_url":"git@github.com:google/WebFundamentals.git","clone_url":"https://github.com/google/WebFundamentals.git","svn_url":"https://github.com/google/WebFundamentals","homepage":"https://developers.google.com/web/fundamentals","size":1186773,"stargazers_count":6783,"watchers_count":6783,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1284,"mirror_url":null,"open_issues_count":111,"forks":1284,"open_issues":111,"watchers":6783,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/WebFundamentals/pulls/3926"},"html":{"href":"https://github.com/google/WebFundamentals/pull/3926"},"issue":{"href":"https://api.github.com/repos/google/WebFundamentals/issues/3926"},"comments":{"href":"https://api.github.com/repos/google/WebFundamentals/issues/3926/comments"},"review_comments":{"href":"https://api.github.com/repos/google/WebFundamentals/pulls/3926/comments"},"review_comment":{"href":"https://api.github.com/repos/google/WebFundamentals/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/WebFundamentals/pulls/3926/commits"},"statuses":{"href":"https://api.github.com/repos/google/WebFundamentals/statuses/730bdaef58e9211a59e8302b605cd1ceeb885ca6"}}}}
{"actor":{"display_login":"kaycebasques"}}