{"action":"created","comment":{"url":"https://api.github.com/repos/buildbot/metabbotcfg/pulls/comments/52835702","id":52835702,"diff_hunk":"@@ -295,16 +295,14 @@ def mklintyfactory():\n         # the version of Buildbot running the metabuildbot!\n         VirtualenvSetup(name='virtualenv setup',\n             no_site_packages=True,\n-            virtualenv_packages=['pyflakes', 'pylint==1.1.0', 'pep8==1.4.6', '--editable=master', '--editable=slave'],\n+            virtualenv_packages=['pyflakes', 'pylint==1.1.0', '--editable=master', '--editable=slave'],\n             virtualenv_dir='../sandbox',\n             haltOnFailure=True),\n \n-        PyFlakes(command=\"../sandbox/bin/pyflakes master/buildbot\", name=\"pyflakes - master\", flunkOnFailure=True),\n-        PyFlakes(command=\"../sandbox/bin/pyflakes slave/buildslave\", name=\"pyflakes - slave\", flunkOnFailure=True),\n         ShellCommand(command=\"../sandbox/bin/pylint --rcfile common/pylintrc buildbot\", name=\"pylint - master\", flunkOnFailure=True),\n         ShellCommand(command=\"../sandbox/bin/pylint --rcfile common/pylintrc buildslave\", name=\"pylint - slave\", flunkOnFailure=True),\n-        ShellCommand(command=\"../sandbox/bin/pep8 --config common/pep8rc master/buildbot\", name=\"pep8 - master\", flunkOnFailure=True),\n-        ShellCommand(command=\"../sandbox/bin/pep8 --config common/pep8rc slave/buildslave\", name=\"pep8 - slave\", flunkOnFailure=True),\n+        ShellCommand(command=\"../sandbox/bin/flake8 --config common/flake8rc master/buildbot\", name=\"flake8 - master\", flunkOnFailure=True),\n+        ShellCommand(command=\"../sandbox/bin/flake8 --config common/flake8rc slave/buildslave\", name=\"flake8 - slave\", flunkOnFailure=True),","path":"builders.py","position":16,"original_position":16,"commit_id":"e4c8854845e0a355e26a62f4a8d09c37924e6b13","original_commit_id":"58b8d9f051b15b2bf6d6e864e1e2cdb60906f06b","user":{"login":"djmitche","id":28673,"avatar_url":"https://avatars.githubusercontent.com/u/28673?v=3","gravatar_id":"","url":"https://api.github.com/users/djmitche","html_url":"https://github.com/djmitche","followers_url":"https://api.github.com/users/djmitche/followers","following_url":"https://api.github.com/users/djmitche/following{/other_user}","gists_url":"https://api.github.com/users/djmitche/gists{/gist_id}","starred_url":"https://api.github.com/users/djmitche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djmitche/subscriptions","organizations_url":"https://api.github.com/users/djmitche/orgs","repos_url":"https://api.github.com/users/djmitche/repos","events_url":"https://api.github.com/users/djmitche/events{/privacy}","received_events_url":"https://api.github.com/users/djmitche/received_events","type":"User","site_admin":false},"body":"fixed\n","created_at":"2016-02-14T00:16:03Z","updated_at":"2016-02-14T00:16:03Z","html_url":"https://github.com/buildbot/metabbotcfg/pull/33#discussion_r52835702","pull_request_url":"https://api.github.com/repos/buildbot/metabbotcfg/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/buildbot/metabbotcfg/pulls/comments/52835702"},"html":{"href":"https://github.com/buildbot/metabbotcfg/pull/33#discussion_r52835702"},"pull_request":{"href":"https://api.github.com/repos/buildbot/metabbotcfg/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/buildbot/metabbotcfg/pulls/33","id":59281848,"html_url":"https://github.com/buildbot/metabbotcfg/pull/33","diff_url":"https://github.com/buildbot/metabbotcfg/pull/33.diff","patch_url":"https://github.com/buildbot/metabbotcfg/pull/33.patch","issue_url":"https://api.github.com/repos/buildbot/metabbotcfg/issues/33","number":33,"state":"open","locked":false,"title":"we run flake8 instead of pep8 and pyflakes now","user":{"login":"djmitche","id":28673,"avatar_url":"https://avatars.githubusercontent.com/u/28673?v=3","gravatar_id":"","url":"https://api.github.com/users/djmitche","html_url":"https://github.com/djmitche","followers_url":"https://api.github.com/users/djmitche/followers","following_url":"https://api.github.com/users/djmitche/following{/other_user}","gists_url":"https://api.github.com/users/djmitche/gists{/gist_id}","starred_url":"https://api.github.com/users/djmitche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djmitche/subscriptions","organizations_url":"https://api.github.com/users/djmitche/orgs","repos_url":"https://api.github.com/users/djmitche/repos","events_url":"https://api.github.com/users/djmitche/events{/privacy}","received_events_url":"https://api.github.com/users/djmitche/received_events","type":"User","site_admin":false},"body":"We made this change in the buildbot repo a while back, but didn't replicate it here.","created_at":"2016-02-13T23:51:19Z","updated_at":"2016-02-14T00:16:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e45e587442b9da983b7e6ef1570adf44c1dc46f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/buildbot/metabbotcfg/pulls/33/commits","review_comments_url":"https://api.github.com/repos/buildbot/metabbotcfg/pulls/33/comments","review_comment_url":"https://api.github.com/repos/buildbot/metabbotcfg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/buildbot/metabbotcfg/issues/33/comments","statuses_url":"https://api.github.com/repos/buildbot/metabbotcfg/statuses/e4c8854845e0a355e26a62f4a8d09c37924e6b13","head":{"label":"djmitche:fix-lint","ref":"fix-lint","sha":"e4c8854845e0a355e26a62f4a8d09c37924e6b13","user":{"login":"djmitche","id":28673,"avatar_url":"https://avatars.githubusercontent.com/u/28673?v=3","gravatar_id":"","url":"https://api.github.com/users/djmitche","html_url":"https://github.com/djmitche","followers_url":"https://api.github.com/users/djmitche/followers","following_url":"https://api.github.com/users/djmitche/following{/other_user}","gists_url":"https://api.github.com/users/djmitche/gists{/gist_id}","starred_url":"https://api.github.com/users/djmitche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djmitche/subscriptions","organizations_url":"https://api.github.com/users/djmitche/orgs","repos_url":"https://api.github.com/users/djmitche/repos","events_url":"https://api.github.com/users/djmitche/events{/privacy}","received_events_url":"https://api.github.com/users/djmitche/received_events","type":"User","site_admin":false},"repo":{"id":27728935,"name":"metabbotcfg","full_name":"djmitche/metabbotcfg","owner":{"login":"djmitche","id":28673,"avatar_url":"https://avatars.githubusercontent.com/u/28673?v=3","gravatar_id":"","url":"https://api.github.com/users/djmitche","html_url":"https://github.com/djmitche","followers_url":"https://api.github.com/users/djmitche/followers","following_url":"https://api.github.com/users/djmitche/following{/other_user}","gists_url":"https://api.github.com/users/djmitche/gists{/gist_id}","starred_url":"https://api.github.com/users/djmitche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djmitche/subscriptions","organizations_url":"https://api.github.com/users/djmitche/orgs","repos_url":"https://api.github.com/users/djmitche/repos","events_url":"https://api.github.com/users/djmitche/events{/privacy}","received_events_url":"https://api.github.com/users/djmitche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/djmitche/metabbotcfg","description":"Configuration for the metabuildbot","fork":true,"url":"https://api.github.com/repos/djmitche/metabbotcfg","forks_url":"https://api.github.com/repos/djmitche/metabbotcfg/forks","keys_url":"https://api.github.com/repos/djmitche/metabbotcfg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djmitche/metabbotcfg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djmitche/metabbotcfg/teams","hooks_url":"https://api.github.com/repos/djmitche/metabbotcfg/hooks","issue_events_url":"https://api.github.com/repos/djmitche/metabbotcfg/issues/events{/number}","events_url":"https://api.github.com/repos/djmitche/metabbotcfg/events","assignees_url":"https://api.github.com/repos/djmitche/metabbotcfg/assignees{/user}","branches_url":"https://api.github.com/repos/djmitche/metabbotcfg/branches{/branch}","tags_url":"https://api.github.com/repos/djmitche/metabbotcfg/tags","blobs_url":"https://api.github.com/repos/djmitche/metabbotcfg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djmitche/metabbotcfg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djmitche/metabbotcfg/git/refs{/sha}","trees_url":"https://api.github.com/repos/djmitche/metabbotcfg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djmitche/metabbotcfg/statuses/{sha}","languages_url":"https://api.github.com/repos/djmitche/metabbotcfg/languages","stargazers_url":"https://api.github.com/repos/djmitche/metabbotcfg/stargazers","contributors_url":"https://api.github.com/repos/djmitche/metabbotcfg/contributors","subscribers_url":"https://api.github.com/repos/djmitche/metabbotcfg/subscribers","subscription_url":"https://api.github.com/repos/djmitche/metabbotcfg/subscription","commits_url":"https://api.github.com/repos/djmitche/metabbotcfg/commits{/sha}","git_commits_url":"https://api.github.com/repos/djmitche/metabbotcfg/git/commits{/sha}","comments_url":"https://api.github.com/repos/djmitche/metabbotcfg/comments{/number}","issue_comment_url":"https://api.github.com/repos/djmitche/metabbotcfg/issues/comments{/number}","contents_url":"https://api.github.com/repos/djmitche/metabbotcfg/contents/{+path}","compare_url":"https://api.github.com/repos/djmitche/metabbotcfg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djmitche/metabbotcfg/merges","archive_url":"https://api.github.com/repos/djmitche/metabbotcfg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djmitche/metabbotcfg/downloads","issues_url":"https://api.github.com/repos/djmitche/metabbotcfg/issues{/number}","pulls_url":"https://api.github.com/repos/djmitche/metabbotcfg/pulls{/number}","milestones_url":"https://api.github.com/repos/djmitche/metabbotcfg/milestones{/number}","notifications_url":"https://api.github.com/repos/djmitche/metabbotcfg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djmitche/metabbotcfg/labels{/name}","releases_url":"https://api.github.com/repos/djmitche/metabbotcfg/releases{/id}","deployments_url":"https://api.github.com/repos/djmitche/metabbotcfg/deployments","created_at":"2014-12-08T18:35:10Z","updated_at":"2016-01-19T16:55:35Z","pushed_at":"2016-02-14T00:15:57Z","git_url":"git://github.com/djmitche/metabbotcfg.git","ssh_url":"git@github.com:djmitche/metabbotcfg.git","clone_url":"https://github.com/djmitche/metabbotcfg.git","svn_url":"https://github.com/djmitche/metabbotcfg","homepage":"http://buildbot.buildbot.net","size":244,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"buildbot:master","ref":"master","sha":"720b39314c0c69a2cfdf45c2d9f413b22b0f57e4","user":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"repo":{"id":768241,"name":"metabbotcfg","full_name":"buildbot/metabbotcfg","owner":{"login":"buildbot","id":324515,"avatar_url":"https://avatars.githubusercontent.com/u/324515?v=3","gravatar_id":"","url":"https://api.github.com/users/buildbot","html_url":"https://github.com/buildbot","followers_url":"https://api.github.com/users/buildbot/followers","following_url":"https://api.github.com/users/buildbot/following{/other_user}","gists_url":"https://api.github.com/users/buildbot/gists{/gist_id}","starred_url":"https://api.github.com/users/buildbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildbot/subscriptions","organizations_url":"https://api.github.com/users/buildbot/orgs","repos_url":"https://api.github.com/users/buildbot/repos","events_url":"https://api.github.com/users/buildbot/events{/privacy}","received_events_url":"https://api.github.com/users/buildbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildbot/metabbotcfg","description":"Configuration for the metabuildbot","fork":false,"url":"https://api.github.com/repos/buildbot/metabbotcfg","forks_url":"https://api.github.com/repos/buildbot/metabbotcfg/forks","keys_url":"https://api.github.com/repos/buildbot/metabbotcfg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildbot/metabbotcfg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildbot/metabbotcfg/teams","hooks_url":"https://api.github.com/repos/buildbot/metabbotcfg/hooks","issue_events_url":"https://api.github.com/repos/buildbot/metabbotcfg/issues/events{/number}","events_url":"https://api.github.com/repos/buildbot/metabbotcfg/events","assignees_url":"https://api.github.com/repos/buildbot/metabbotcfg/assignees{/user}","branches_url":"https://api.github.com/repos/buildbot/metabbotcfg/branches{/branch}","tags_url":"https://api.github.com/repos/buildbot/metabbotcfg/tags","blobs_url":"https://api.github.com/repos/buildbot/metabbotcfg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildbot/metabbotcfg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildbot/metabbotcfg/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildbot/metabbotcfg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildbot/metabbotcfg/statuses/{sha}","languages_url":"https://api.github.com/repos/buildbot/metabbotcfg/languages","stargazers_url":"https://api.github.com/repos/buildbot/metabbotcfg/stargazers","contributors_url":"https://api.github.com/repos/buildbot/metabbotcfg/contributors","subscribers_url":"https://api.github.com/repos/buildbot/metabbotcfg/subscribers","subscription_url":"https://api.github.com/repos/buildbot/metabbotcfg/subscription","commits_url":"https://api.github.com/repos/buildbot/metabbotcfg/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildbot/metabbotcfg/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildbot/metabbotcfg/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildbot/metabbotcfg/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildbot/metabbotcfg/contents/{+path}","compare_url":"https://api.github.com/repos/buildbot/metabbotcfg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildbot/metabbotcfg/merges","archive_url":"https://api.github.com/repos/buildbot/metabbotcfg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildbot/metabbotcfg/downloads","issues_url":"https://api.github.com/repos/buildbot/metabbotcfg/issues{/number}","pulls_url":"https://api.github.com/repos/buildbot/metabbotcfg/pulls{/number}","milestones_url":"https://api.github.com/repos/buildbot/metabbotcfg/milestones{/number}","notifications_url":"https://api.github.com/repos/buildbot/metabbotcfg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildbot/metabbotcfg/labels{/name}","releases_url":"https://api.github.com/repos/buildbot/metabbotcfg/releases{/id}","deployments_url":"https://api.github.com/repos/buildbot/metabbotcfg/deployments","created_at":"2010-07-10T23:41:07Z","updated_at":"2015-10-17T17:52:21Z","pushed_at":"2016-02-14T00:15:58Z","git_url":"git://github.com/buildbot/metabbotcfg.git","ssh_url":"git@github.com:buildbot/metabbotcfg.git","clone_url":"https://github.com/buildbot/metabbotcfg.git","svn_url":"https://github.com/buildbot/metabbotcfg","homepage":"http://buildbot.buildbot.net","size":227,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":5,"forks":7,"open_issues":5,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buildbot/metabbotcfg/pulls/33"},"html":{"href":"https://github.com/buildbot/metabbotcfg/pull/33"},"issue":{"href":"https://api.github.com/repos/buildbot/metabbotcfg/issues/33"},"comments":{"href":"https://api.github.com/repos/buildbot/metabbotcfg/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/buildbot/metabbotcfg/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/buildbot/metabbotcfg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/buildbot/metabbotcfg/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/buildbot/metabbotcfg/statuses/e4c8854845e0a355e26a62f4a8d09c37924e6b13"}}}}