{"action":"created","issue":{"url":"https://api.github.com/repos/stripe/veneur/issues/54","repository_url":"https://api.github.com/repos/stripe/veneur","labels_url":"https://api.github.com/repos/stripe/veneur/issues/54/labels{/name}","comments_url":"https://api.github.com/repos/stripe/veneur/issues/54/comments","events_url":"https://api.github.com/repos/stripe/veneur/issues/54/events","html_url":"https://github.com/stripe/veneur/pull/54","id":169937654,"number":54,"title":"Add tags to service checks and events.","user":{"login":"gphat","id":45159,"avatar_url":"https://avatars.githubusercontent.com/u/45159?v=3","gravatar_id":"","url":"https://api.github.com/users/gphat","html_url":"https://github.com/gphat","followers_url":"https://api.github.com/users/gphat/followers","following_url":"https://api.github.com/users/gphat/following{/other_user}","gists_url":"https://api.github.com/users/gphat/gists{/gist_id}","starred_url":"https://api.github.com/users/gphat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gphat/subscriptions","organizations_url":"https://api.github.com/users/gphat/orgs","repos_url":"https://api.github.com/users/gphat/repos","events_url":"https://api.github.com/users/gphat/events{/privacy}","received_events_url":"https://api.github.com/users/gphat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"tummychow","id":4285049,"avatar_url":"https://avatars.githubusercontent.com/u/4285049?v=3","gravatar_id":"","url":"https://api.github.com/users/tummychow","html_url":"https://github.com/tummychow","followers_url":"https://api.github.com/users/tummychow/followers","following_url":"https://api.github.com/users/tummychow/following{/other_user}","gists_url":"https://api.github.com/users/tummychow/gists{/gist_id}","starred_url":"https://api.github.com/users/tummychow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tummychow/subscriptions","organizations_url":"https://api.github.com/users/tummychow/orgs","repos_url":"https://api.github.com/users/tummychow/repos","events_url":"https://api.github.com/users/tummychow/events{/privacy}","received_events_url":"https://api.github.com/users/tummychow/received_events","type":"User","site_admin":false},"assignees":[{"login":"tummychow","id":4285049,"avatar_url":"https://avatars.githubusercontent.com/u/4285049?v=3","gravatar_id":"","url":"https://api.github.com/users/tummychow","html_url":"https://github.com/tummychow","followers_url":"https://api.github.com/users/tummychow/followers","following_url":"https://api.github.com/users/tummychow/following{/other_user}","gists_url":"https://api.github.com/users/tummychow/gists{/gist_id}","starred_url":"https://api.github.com/users/tummychow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tummychow/subscriptions","organizations_url":"https://api.github.com/users/tummychow/orgs","repos_url":"https://api.github.com/users/tummychow/repos","events_url":"https://api.github.com/users/tummychow/events{/privacy}","received_events_url":"https://api.github.com/users/tummychow/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-08-08T14:31:30Z","updated_at":"2016-08-08T18:00:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stripe/veneur/pulls/54","html_url":"https://github.com/stripe/veneur/pull/54","diff_url":"https://github.com/stripe/veneur/pull/54.diff","patch_url":"https://github.com/stripe/veneur/pull/54.patch"},"body":"#### Summary\r\nAppends \"global\" server tags to service checks and events.\r\n\r\n#### Motivation\r\nI was investigating a `No Data` alert this morning and noticed that the service check in question did not have a `host_env`. After investigating I realized that events and service checks no longer have their global tags applied. This fixes that.\r\n\r\n# Note\r\nWhen I was tracing through the code it occurred to me that `Flush` could be modified to take in the server's hostname and tags and using them when emitting the `[]DDMetric`.  Doing this eliminates the trailing iteration over all metrics to fixup `Hostname` and `Tags`. This seemed like a good change, since we're already doing this with the Histogram's percentiles.\r\n\r\nThis is [in a single commit](https://github.com/stripe/veneur/pull/54/commits/61fc244a7537c64b8a38596fec7def1a10ae4dcd) and can be pulled out if you disagree!\r\n\r\n#### Test plan\r\nWe don't seem to have any way to test this phase of the flusher. Perhaps we should pluck out the parts of `flusher.go` that \"prepare\" the data and make them testable?\r\n\r\n#### Rollout/monitoring/revert plan\r\n* Merge\r\n* Update SHA in puppet-land\r\n* Puppet the fleet\r\n\r\nr? @tummychow \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/stripe/veneur/issues/comments/238323099","html_url":"https://github.com/stripe/veneur/pull/54#issuecomment-238323099","issue_url":"https://api.github.com/repos/stripe/veneur/issues/54","id":238323099,"user":{"login":"gphat","id":45159,"avatar_url":"https://avatars.githubusercontent.com/u/45159?v=3","gravatar_id":"","url":"https://api.github.com/users/gphat","html_url":"https://github.com/gphat","followers_url":"https://api.github.com/users/gphat/followers","following_url":"https://api.github.com/users/gphat/following{/other_user}","gists_url":"https://api.github.com/users/gphat/gists{/gist_id}","starred_url":"https://api.github.com/users/gphat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gphat/subscriptions","organizations_url":"https://api.github.com/users/gphat/orgs","repos_url":"https://api.github.com/users/gphat/repos","events_url":"https://api.github.com/users/gphat/events{/privacy}","received_events_url":"https://api.github.com/users/gphat/received_events","type":"User","site_admin":false},"created_at":"2016-08-08T18:00:06Z","updated_at":"2016-08-08T18:00:06Z","body":"I moved it because I wasn't sure how else to test the concatenation of the two tags. Got any ideas for how to make that a bit easier? Since it was down in the flusher's bowels…"}}
{"actor":{"display_login":"gphat"}}