{"action":"opened","issue":{"url":"https://api.github.com/repos/nijel/weblate/issues/1070","repository_url":"https://api.github.com/repos/nijel/weblate","labels_url":"https://api.github.com/repos/nijel/weblate/issues/1070/labels{/name}","comments_url":"https://api.github.com/repos/nijel/weblate/issues/1070/comments","events_url":"https://api.github.com/repos/nijel/weblate/issues/1070/events","html_url":"https://github.com/nijel/weblate/issues/1070","id":148425292,"number":1070,"title":"GroupACL sometimes allows user permissions to apply","user":{"login":"matejcik","id":596073,"avatar_url":"https://avatars.githubusercontent.com/u/596073?v=3","gravatar_id":"","url":"https://api.github.com/users/matejcik","html_url":"https://github.com/matejcik","followers_url":"https://api.github.com/users/matejcik/followers","following_url":"https://api.github.com/users/matejcik/following{/other_user}","gists_url":"https://api.github.com/users/matejcik/gists{/gist_id}","starred_url":"https://api.github.com/users/matejcik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matejcik/subscriptions","organizations_url":"https://api.github.com/users/matejcik/orgs","repos_url":"https://api.github.com/users/matejcik/repos","events_url":"https://api.github.com/users/matejcik/events{/privacy}","received_events_url":"https://api.github.com/users/matejcik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-04-14T17:06:44Z","updated_at":"2016-04-14T17:06:44Z","closed_at":null,"body":"While testing GroupACLs in the wild, we discovered some problems.\r\n\r\nThe first clue was that `can_suggest` checks both the GroupACL mechanism and the traditional mechanism -- meaning that even if a GroupACL applies, users can still add suggestions (if they have the permissions from the Users or Guests group). This is desirable in our case :) but goes against how GroupACLs should work -- that is, by locking out permissions from all but the assigned groups.\r\n\r\nThis seems to be the case for all callers of `check_permission`, which allows both `has_group_perm` and `user.has_perm` calls. (`has_group_perm` calls `user.has_perm` internally when appropriate)\r\n\r\nPlease take a look at the source, check if this is really a bug the way I think it is a bug, and if so, i'll send a PR to fix it :)"}}