{"action":"closed","number":1668,"pull_request":{"url":"https://api.github.com/repos/matrix-org/synapse/pulls/1668","id":96414587,"html_url":"https://github.com/matrix-org/synapse/pull/1668","diff_url":"https://github.com/matrix-org/synapse/pull/1668.diff","patch_url":"https://github.com/matrix-org/synapse/pull/1668.patch","issue_url":"https://api.github.com/repos/matrix-org/synapse/issues/1668","number":1668,"state":"closed","locked":false,"title":"Logging: Fix console filter breaking when level is DEBUG","user":{"login":"pik","id":10236920,"avatar_url":"https://avatars.githubusercontent.com/u/10236920?v=3","gravatar_id":"","url":"https://api.github.com/users/pik","html_url":"https://github.com/pik","followers_url":"https://api.github.com/users/pik/followers","following_url":"https://api.github.com/users/pik/following{/other_user}","gists_url":"https://api.github.com/users/pik/gists{/gist_id}","starred_url":"https://api.github.com/users/pik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pik/subscriptions","organizations_url":"https://api.github.com/users/pik/orgs","repos_url":"https://api.github.com/users/pik/repos","events_url":"https://api.github.com/users/pik/events{/privacy}","received_events_url":"https://api.github.com/users/pik/received_events","type":"User","site_admin":false},"body":"Specifically the default Template does not add a `filters: [context]` to the console handler which causes the `_fmt % record.__dict__` to produce a KeyError. On a side-note, why is the alternate path PythonCode (it produces no-logging as far as I can see) vs. simply `logging.config.dictConfig(yaml.load(DEFAULT_LOG_CONFIG.template))` wouldn't that be preferable anyways? ","created_at":"2016-12-03T23:24:49Z","updated_at":"2016-12-05T16:38:26Z","closed_at":"2016-12-05T16:38:26Z","merged_at":"2016-12-05T16:38:26Z","merge_commit_sha":"3e90250ea3cf59103353f5f19b141bc60b4c9b3c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/matrix-org/synapse/pulls/1668/commits","review_comments_url":"https://api.github.com/repos/matrix-org/synapse/pulls/1668/comments","review_comment_url":"https://api.github.com/repos/matrix-org/synapse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matrix-org/synapse/issues/1668/comments","statuses_url":"https://api.github.com/repos/matrix-org/synapse/statuses/c46e7a9c9b98738e3b283d476201ef149a695dd1","head":{"label":"pik:bug-console-filter","ref":"bug-console-filter","sha":"c46e7a9c9b98738e3b283d476201ef149a695dd1","user":{"login":"pik","id":10236920,"avatar_url":"https://avatars.githubusercontent.com/u/10236920?v=3","gravatar_id":"","url":"https://api.github.com/users/pik","html_url":"https://github.com/pik","followers_url":"https://api.github.com/users/pik/followers","following_url":"https://api.github.com/users/pik/following{/other_user}","gists_url":"https://api.github.com/users/pik/gists{/gist_id}","starred_url":"https://api.github.com/users/pik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pik/subscriptions","organizations_url":"https://api.github.com/users/pik/orgs","repos_url":"https://api.github.com/users/pik/repos","events_url":"https://api.github.com/users/pik/events{/privacy}","received_events_url":"https://api.github.com/users/pik/received_events","type":"User","site_admin":false},"repo":{"id":68250758,"name":"synapse","full_name":"pik/synapse","owner":{"login":"pik","id":10236920,"avatar_url":"https://avatars.githubusercontent.com/u/10236920?v=3","gravatar_id":"","url":"https://api.github.com/users/pik","html_url":"https://github.com/pik","followers_url":"https://api.github.com/users/pik/followers","following_url":"https://api.github.com/users/pik/following{/other_user}","gists_url":"https://api.github.com/users/pik/gists{/gist_id}","starred_url":"https://api.github.com/users/pik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pik/subscriptions","organizations_url":"https://api.github.com/users/pik/orgs","repos_url":"https://api.github.com/users/pik/repos","events_url":"https://api.github.com/users/pik/events{/privacy}","received_events_url":"https://api.github.com/users/pik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pik/synapse","description":"Synapse: Matrix reference homeserver","fork":true,"url":"https://api.github.com/repos/pik/synapse","forks_url":"https://api.github.com/repos/pik/synapse/forks","keys_url":"https://api.github.com/repos/pik/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pik/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pik/synapse/teams","hooks_url":"https://api.github.com/repos/pik/synapse/hooks","issue_events_url":"https://api.github.com/repos/pik/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/pik/synapse/events","assignees_url":"https://api.github.com/repos/pik/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/pik/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/pik/synapse/tags","blobs_url":"https://api.github.com/repos/pik/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pik/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pik/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/pik/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pik/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/pik/synapse/languages","stargazers_url":"https://api.github.com/repos/pik/synapse/stargazers","contributors_url":"https://api.github.com/repos/pik/synapse/contributors","subscribers_url":"https://api.github.com/repos/pik/synapse/subscribers","subscription_url":"https://api.github.com/repos/pik/synapse/subscription","commits_url":"https://api.github.com/repos/pik/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/pik/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/pik/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/pik/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/pik/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/pik/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pik/synapse/merges","archive_url":"https://api.github.com/repos/pik/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pik/synapse/downloads","issues_url":"https://api.github.com/repos/pik/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/pik/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/pik/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/pik/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pik/synapse/labels{/name}","releases_url":"https://api.github.com/repos/pik/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/pik/synapse/deployments","created_at":"2016-09-14T23:13:21Z","updated_at":"2016-09-14T23:13:24Z","pushed_at":"2016-12-03T23:30:00Z","git_url":"git://github.com/pik/synapse.git","ssh_url":"git@github.com:pik/synapse.git","clone_url":"https://github.com/pik/synapse.git","svn_url":"https://github.com/pik/synapse","homepage":"http://matrix.org","size":13020,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matrix-org:develop","ref":"develop","sha":"59984e9f5872348e709fd52a729084b722bf8828","user":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars.githubusercontent.com/u/8418310?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"repo":{"id":22844864,"name":"synapse","full_name":"matrix-org/synapse","owner":{"login":"matrix-org","id":8418310,"avatar_url":"https://avatars.githubusercontent.com/u/8418310?v=3","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matrix-org/synapse","description":"Synapse: Matrix reference homeserver","fork":false,"url":"https://api.github.com/repos/matrix-org/synapse","forks_url":"https://api.github.com/repos/matrix-org/synapse/forks","keys_url":"https://api.github.com/repos/matrix-org/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-org/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-org/synapse/teams","hooks_url":"https://api.github.com/repos/matrix-org/synapse/hooks","issue_events_url":"https://api.github.com/repos/matrix-org/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-org/synapse/events","assignees_url":"https://api.github.com/repos/matrix-org/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-org/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-org/synapse/tags","blobs_url":"https://api.github.com/repos/matrix-org/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-org/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-org/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-org/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-org/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-org/synapse/languages","stargazers_url":"https://api.github.com/repos/matrix-org/synapse/stargazers","contributors_url":"https://api.github.com/repos/matrix-org/synapse/contributors","subscribers_url":"https://api.github.com/repos/matrix-org/synapse/subscribers","subscription_url":"https://api.github.com/repos/matrix-org/synapse/subscription","commits_url":"https://api.github.com/repos/matrix-org/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-org/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-org/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-org/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-org/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-org/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-org/synapse/merges","archive_url":"https://api.github.com/repos/matrix-org/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-org/synapse/downloads","issues_url":"https://api.github.com/repos/matrix-org/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-org/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-org/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-org/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-org/synapse/labels{/name}","releases_url":"https://api.github.com/repos/matrix-org/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-org/synapse/deployments","created_at":"2014-08-11T15:51:42Z","updated_at":"2016-12-04T21:36:45Z","pushed_at":"2016-12-05T16:38:26Z","git_url":"git://github.com/matrix-org/synapse.git","ssh_url":"git@github.com:matrix-org/synapse.git","clone_url":"https://github.com/matrix-org/synapse.git","svn_url":"https://github.com/matrix-org/synapse","homepage":"http://matrix.org","size":19259,"stargazers_count":1394,"watchers_count":1394,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":163,"mirror_url":null,"open_issues_count":487,"forks":163,"open_issues":487,"watchers":1394,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/1668"},"html":{"href":"https://github.com/matrix-org/synapse/pull/1668"},"issue":{"href":"https://api.github.com/repos/matrix-org/synapse/issues/1668"},"comments":{"href":"https://api.github.com/repos/matrix-org/synapse/issues/1668/comments"},"review_comments":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/1668/comments"},"review_comment":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/1668/commits"},"statuses":{"href":"https://api.github.com/repos/matrix-org/synapse/statuses/c46e7a9c9b98738e3b283d476201ef149a695dd1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"erikjohnston","id":8428120,"avatar_url":"https://avatars.githubusercontent.com/u/8428120?v=3","gravatar_id":"","url":"https://api.github.com/users/erikjohnston","html_url":"https://github.com/erikjohnston","followers_url":"https://api.github.com/users/erikjohnston/followers","following_url":"https://api.github.com/users/erikjohnston/following{/other_user}","gists_url":"https://api.github.com/users/erikjohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/erikjohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikjohnston/subscriptions","organizations_url":"https://api.github.com/users/erikjohnston/orgs","repos_url":"https://api.github.com/users/erikjohnston/repos","events_url":"https://api.github.com/users/erikjohnston/events{/privacy}","received_events_url":"https://api.github.com/users/erikjohnston/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"erikjohnston"}}