{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/70506999","id":70506999,"diff_hunk":"@@ -186,7 +182,7 @@ void CEventServer::Run()\n     CLog::Log(LOGERROR, \"ES: Invalid port range specified %d, defaulting to 10\", port_range);\n     port_range = 10;\n   }\n-  if (!m_pSocket->Bind(any_addr, m_iPort, port_range))\n+  if (!m_pSocket->Bind(!CSettings::GetInstance().GetBool(CSettings::SETTING_SERVICES_ESALLINTERFACES), m_iPort, port_range))","path":"xbmc/network/EventServer.cpp","position":21,"original_position":21,"commit_id":"12e006dfee5da0f398b01ae317ea13c2a1780c4c","original_commit_id":"12e006dfee5da0f398b01ae317ea13c2a1780c4c","user":{"login":"Paxxi","id":874927,"avatar_url":"https://avatars.githubusercontent.com/u/874927?v=3","gravatar_id":"","url":"https://api.github.com/users/Paxxi","html_url":"https://github.com/Paxxi","followers_url":"https://api.github.com/users/Paxxi/followers","following_url":"https://api.github.com/users/Paxxi/following{/other_user}","gists_url":"https://api.github.com/users/Paxxi/gists{/gist_id}","starred_url":"https://api.github.com/users/Paxxi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Paxxi/subscriptions","organizations_url":"https://api.github.com/users/Paxxi/orgs","repos_url":"https://api.github.com/users/Paxxi/repos","events_url":"https://api.github.com/users/Paxxi/events{/privacy}","received_events_url":"https://api.github.com/users/Paxxi/received_events","type":"User","site_admin":false},"body":"This predates this PR so not meant as critique. Are there any good reasons for wanting to bind to localhost only? It seems to complicate our lives and I have a hard time to see any benefit from it.","created_at":"2016-07-12T19:37:53Z","updated_at":"2016-07-12T19:37:53Z","html_url":"https://github.com/xbmc/xbmc/pull/10104#discussion_r70506999","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/10104","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/70506999"},"html":{"href":"https://github.com/xbmc/xbmc/pull/10104#discussion_r70506999"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10104"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/10104","id":77112130,"html_url":"https://github.com/xbmc/xbmc/pull/10104","diff_url":"https://github.com/xbmc/xbmc/pull/10104.diff","patch_url":"https://github.com/xbmc/xbmc/pull/10104.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/10104","number":10104,"state":"open","locked":false,"title":"Add ipv6 support to Event Server","user":{"login":"Tolriq","id":932609,"avatar_url":"https://avatars.githubusercontent.com/u/932609?v=3","gravatar_id":"","url":"https://api.github.com/users/Tolriq","html_url":"https://github.com/Tolriq","followers_url":"https://api.github.com/users/Tolriq/followers","following_url":"https://api.github.com/users/Tolriq/following{/other_user}","gists_url":"https://api.github.com/users/Tolriq/gists{/gist_id}","starred_url":"https://api.github.com/users/Tolriq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tolriq/subscriptions","organizations_url":"https://api.github.com/users/Tolriq/orgs","repos_url":"https://api.github.com/users/Tolriq/repos","events_url":"https://api.github.com/users/Tolriq/events{/privacy}","received_events_url":"https://api.github.com/users/Tolriq/received_events","type":"User","site_admin":false},"body":"More than inspired by http://trac.kodi.tv/ticket/12491 with some fixes\r\n\r\nUse dual stack when possible with fallback to ipv4 if any problem to not end with an ipv6 listener only.\r\n\r\nTested and working on Windows. Needs tests on other platforms.\r\n\r\nCC @Montellese / @FernetMenta as I saw some feedback on other ipv6 patch from you.\r\n\r\nHad a few report about that missing, and since everything else support ipv6 it should be enabled for event server too.","created_at":"2016-07-12T12:36:55Z","updated_at":"2016-07-12T19:37:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f055f5758229b0381b8672fe6f093417e9eba583","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/86","html_url":"https://github.com/xbmc/xbmc/milestones/Krypton%2017.0-alpha3","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/86/labels","id":1837954,"number":86,"title":"Krypton 17.0-alpha3","description":"","creator":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars.githubusercontent.com/u/907436?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":38,"state":"open","created_at":"2016-06-20T12:10:23Z","updated_at":"2016-07-12T18:25:44Z","due_on":"2016-07-30T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/10104/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/10104/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/10104/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/12e006dfee5da0f398b01ae317ea13c2a1780c4c","head":{"label":"Tolriq:event_server_ipv6","ref":"event_server_ipv6","sha":"12e006dfee5da0f398b01ae317ea13c2a1780c4c","user":{"login":"Tolriq","id":932609,"avatar_url":"https://avatars.githubusercontent.com/u/932609?v=3","gravatar_id":"","url":"https://api.github.com/users/Tolriq","html_url":"https://github.com/Tolriq","followers_url":"https://api.github.com/users/Tolriq/followers","following_url":"https://api.github.com/users/Tolriq/following{/other_user}","gists_url":"https://api.github.com/users/Tolriq/gists{/gist_id}","starred_url":"https://api.github.com/users/Tolriq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tolriq/subscriptions","organizations_url":"https://api.github.com/users/Tolriq/orgs","repos_url":"https://api.github.com/users/Tolriq/repos","events_url":"https://api.github.com/users/Tolriq/events{/privacy}","received_events_url":"https://api.github.com/users/Tolriq/received_events","type":"User","site_admin":false},"repo":{"id":6201721,"name":"xbmc","full_name":"Tolriq/xbmc","owner":{"login":"Tolriq","id":932609,"avatar_url":"https://avatars.githubusercontent.com/u/932609?v=3","gravatar_id":"","url":"https://api.github.com/users/Tolriq","html_url":"https://github.com/Tolriq","followers_url":"https://api.github.com/users/Tolriq/followers","following_url":"https://api.github.com/users/Tolriq/following{/other_user}","gists_url":"https://api.github.com/users/Tolriq/gists{/gist_id}","starred_url":"https://api.github.com/users/Tolriq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tolriq/subscriptions","organizations_url":"https://api.github.com/users/Tolriq/orgs","repos_url":"https://api.github.com/users/Tolriq/repos","events_url":"https://api.github.com/users/Tolriq/events{/privacy}","received_events_url":"https://api.github.com/users/Tolriq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tolriq/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/Tolriq/xbmc","forks_url":"https://api.github.com/repos/Tolriq/xbmc/forks","keys_url":"https://api.github.com/repos/Tolriq/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tolriq/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tolriq/xbmc/teams","hooks_url":"https://api.github.com/repos/Tolriq/xbmc/hooks","issue_events_url":"https://api.github.com/repos/Tolriq/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/Tolriq/xbmc/events","assignees_url":"https://api.github.com/repos/Tolriq/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/Tolriq/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/Tolriq/xbmc/tags","blobs_url":"https://api.github.com/repos/Tolriq/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tolriq/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tolriq/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tolriq/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tolriq/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/Tolriq/xbmc/languages","stargazers_url":"https://api.github.com/repos/Tolriq/xbmc/stargazers","contributors_url":"https://api.github.com/repos/Tolriq/xbmc/contributors","subscribers_url":"https://api.github.com/repos/Tolriq/xbmc/subscribers","subscription_url":"https://api.github.com/repos/Tolriq/xbmc/subscription","commits_url":"https://api.github.com/repos/Tolriq/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tolriq/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tolriq/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tolriq/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tolriq/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/Tolriq/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tolriq/xbmc/merges","archive_url":"https://api.github.com/repos/Tolriq/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tolriq/xbmc/downloads","issues_url":"https://api.github.com/repos/Tolriq/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/Tolriq/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/Tolriq/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/Tolriq/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tolriq/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/Tolriq/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/Tolriq/xbmc/deployments","created_at":"2012-10-13T09:49:39Z","updated_at":"2016-01-11T15:15:40Z","pushed_at":"2016-07-12T18:00:31Z","git_url":"git://github.com/Tolriq/xbmc.git","ssh_url":"git@github.com:Tolriq/xbmc.git","clone_url":"https://github.com/Tolriq/xbmc.git","svn_url":"https://github.com/Tolriq/xbmc","homepage":"http://xbmc.org","size":545411,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"e247a0d2b0ad9bbc744b8a22ffedc9a24a795685","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2016-07-12T15:50:08Z","pushed_at":"2016-07-12T18:00:32Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1751899,"stargazers_count":4904,"watchers_count":4904,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3591,"mirror_url":null,"open_issues_count":194,"forks":3591,"open_issues":194,"watchers":4904,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10104"},"html":{"href":"https://github.com/xbmc/xbmc/pull/10104"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/10104"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/10104/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10104/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/10104/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/12e006dfee5da0f398b01ae317ea13c2a1780c4c"}}}}
{"actor":{"display_login":"Paxxi"}}