{"action":"created","comment":{"url":"https://api.github.com/repos/kupiakos/CS340/pulls/comments/91221564","pull_request_review_id":11730840,"id":91221564,"diff_hunk":"@@ -1,35 +1,55 @@\n package server.plugin;\n+\n+import com.esotericsoftware.yamlbeans.YamlReader;\n+\n import java.io.File;\n-import java.net.MalformedURLException;\n+import java.io.FileReader;\n import java.net.URL;\n import java.net.URLClassLoader;\n-import java.util.Arrays;\n-import java.util.List;\n-import java.util.Objects;\n+import java.util.*;\n import java.util.stream.Collectors;\n \n-import static java.util.Arrays.stream;\n+import static server.plugin.PluginConfig.PluginType.PERSISTENCE;\n \n public class PluginLoader implements IPluginLoader {\n \n     /**\n      * @inheritDoc\n      */\n     @Override\n-    public List<IPlugin> loadConfig(List<PluginConfig> configs, File folder) {\n-        List<String> neededPlugins = configs.stream()\n-                .map(o -> o.getName().toLowerCase())\n+    public List<IPlugin> loadConfig(List<PluginConfig> pluginConfigs, File folder) {\n+        // neededPlugins\n+        List<String> neededPlugins = pluginConfigs.stream()","path":"java/src/server/plugin/PluginLoader.java","position":30,"original_position":30,"commit_id":"47d804cc8ca74b1b7a33c92a23bbbff324e09b12","original_commit_id":"47d804cc8ca74b1b7a33c92a23bbbff324e09b12","user":{"login":"kupiakos","id":3309728,"avatar_url":"https://avatars.githubusercontent.com/u/3309728?v=3","gravatar_id":"","url":"https://api.github.com/users/kupiakos","html_url":"https://github.com/kupiakos","followers_url":"https://api.github.com/users/kupiakos/followers","following_url":"https://api.github.com/users/kupiakos/following{/other_user}","gists_url":"https://api.github.com/users/kupiakos/gists{/gist_id}","starred_url":"https://api.github.com/users/kupiakos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kupiakos/subscriptions","organizations_url":"https://api.github.com/users/kupiakos/orgs","repos_url":"https://api.github.com/users/kupiakos/repos","events_url":"https://api.github.com/users/kupiakos/events{/privacy}","received_events_url":"https://api.github.com/users/kupiakos/received_events","type":"User","site_admin":false},"body":"While shocking that Java 8 doesn't have a native `zip` function for streams, and that two-list-to-map utility function is neat if genericized, in this case `zipNameConfigs` can just be created with\r\n\r\n    pluginConfigs.stream()\r\n            .collect(Collectors.toMap(PluginConfig::getJarName, PluginConfig::getOtherArgs));","created_at":"2016-12-07T03:30:24Z","updated_at":"2016-12-07T03:30:24Z","html_url":"https://github.com/kupiakos/CS340/pull/100#discussion_r91221564","pull_request_url":"https://api.github.com/repos/kupiakos/CS340/pulls/100","_links":{"self":{"href":"https://api.github.com/repos/kupiakos/CS340/pulls/comments/91221564"},"html":{"href":"https://github.com/kupiakos/CS340/pull/100#discussion_r91221564"},"pull_request":{"href":"https://api.github.com/repos/kupiakos/CS340/pulls/100"}}},"pull_request":{"url":"https://api.github.com/repos/kupiakos/CS340/pulls/100","id":96838833,"html_url":"https://github.com/kupiakos/CS340/pull/100","diff_url":"https://github.com/kupiakos/CS340/pull/100.diff","patch_url":"https://github.com/kupiakos/CS340/pull/100.patch","issue_url":"https://api.github.com/repos/kupiakos/CS340/issues/100","number":100,"state":"open","locked":false,"title":"IPlugin -> AbstractPlugin, YAML config file","user":{"login":"Audakel","id":8355511,"avatar_url":"https://avatars.githubusercontent.com/u/8355511?v=3","gravatar_id":"","url":"https://api.github.com/users/Audakel","html_url":"https://github.com/Audakel","followers_url":"https://api.github.com/users/Audakel/followers","following_url":"https://api.github.com/users/Audakel/following{/other_user}","gists_url":"https://api.github.com/users/Audakel/gists{/gist_id}","starred_url":"https://api.github.com/users/Audakel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Audakel/subscriptions","organizations_url":"https://api.github.com/users/Audakel/orgs","repos_url":"https://api.github.com/users/Audakel/repos","events_url":"https://api.github.com/users/Audakel/events{/privacy}","received_events_url":"https://api.github.com/users/Audakel/received_events","type":"User","site_admin":false},"body":"Changed IPlugin to be Abstract to better work with reflection when creating Persistance Plugins.\r\nAlso we now have yaml plugin config file that we use for specifying params.","created_at":"2016-12-07T00:58:17Z","updated_at":"2016-12-07T03:30:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a725a5b0060ff746765f2c864004b92e8a2ad0f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kupiakos/CS340/pulls/100/commits","review_comments_url":"https://api.github.com/repos/kupiakos/CS340/pulls/100/comments","review_comment_url":"https://api.github.com/repos/kupiakos/CS340/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kupiakos/CS340/issues/100/comments","statuses_url":"https://api.github.com/repos/kupiakos/CS340/statuses/47d804cc8ca74b1b7a33c92a23bbbff324e09b12","head":{"label":"Audakel:master","ref":"master","sha":"47d804cc8ca74b1b7a33c92a23bbbff324e09b12","user":{"login":"Audakel","id":8355511,"avatar_url":"https://avatars.githubusercontent.com/u/8355511?v=3","gravatar_id":"","url":"https://api.github.com/users/Audakel","html_url":"https://github.com/Audakel","followers_url":"https://api.github.com/users/Audakel/followers","following_url":"https://api.github.com/users/Audakel/following{/other_user}","gists_url":"https://api.github.com/users/Audakel/gists{/gist_id}","starred_url":"https://api.github.com/users/Audakel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Audakel/subscriptions","organizations_url":"https://api.github.com/users/Audakel/orgs","repos_url":"https://api.github.com/users/Audakel/repos","events_url":"https://api.github.com/users/Audakel/events{/privacy}","received_events_url":"https://api.github.com/users/Audakel/received_events","type":"User","site_admin":false},"repo":{"id":68416692,"name":"CS340","full_name":"Audakel/CS340","owner":{"login":"Audakel","id":8355511,"avatar_url":"https://avatars.githubusercontent.com/u/8355511?v=3","gravatar_id":"","url":"https://api.github.com/users/Audakel","html_url":"https://github.com/Audakel","followers_url":"https://api.github.com/users/Audakel/followers","following_url":"https://api.github.com/users/Audakel/following{/other_user}","gists_url":"https://api.github.com/users/Audakel/gists{/gist_id}","starred_url":"https://api.github.com/users/Audakel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Audakel/subscriptions","organizations_url":"https://api.github.com/users/Audakel/orgs","repos_url":"https://api.github.com/users/Audakel/repos","events_url":"https://api.github.com/users/Audakel/events{/privacy}","received_events_url":"https://api.github.com/users/Audakel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Audakel/CS340","description":null,"fork":true,"url":"https://api.github.com/repos/Audakel/CS340","forks_url":"https://api.github.com/repos/Audakel/CS340/forks","keys_url":"https://api.github.com/repos/Audakel/CS340/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Audakel/CS340/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Audakel/CS340/teams","hooks_url":"https://api.github.com/repos/Audakel/CS340/hooks","issue_events_url":"https://api.github.com/repos/Audakel/CS340/issues/events{/number}","events_url":"https://api.github.com/repos/Audakel/CS340/events","assignees_url":"https://api.github.com/repos/Audakel/CS340/assignees{/user}","branches_url":"https://api.github.com/repos/Audakel/CS340/branches{/branch}","tags_url":"https://api.github.com/repos/Audakel/CS340/tags","blobs_url":"https://api.github.com/repos/Audakel/CS340/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Audakel/CS340/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Audakel/CS340/git/refs{/sha}","trees_url":"https://api.github.com/repos/Audakel/CS340/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Audakel/CS340/statuses/{sha}","languages_url":"https://api.github.com/repos/Audakel/CS340/languages","stargazers_url":"https://api.github.com/repos/Audakel/CS340/stargazers","contributors_url":"https://api.github.com/repos/Audakel/CS340/contributors","subscribers_url":"https://api.github.com/repos/Audakel/CS340/subscribers","subscription_url":"https://api.github.com/repos/Audakel/CS340/subscription","commits_url":"https://api.github.com/repos/Audakel/CS340/commits{/sha}","git_commits_url":"https://api.github.com/repos/Audakel/CS340/git/commits{/sha}","comments_url":"https://api.github.com/repos/Audakel/CS340/comments{/number}","issue_comment_url":"https://api.github.com/repos/Audakel/CS340/issues/comments{/number}","contents_url":"https://api.github.com/repos/Audakel/CS340/contents/{+path}","compare_url":"https://api.github.com/repos/Audakel/CS340/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Audakel/CS340/merges","archive_url":"https://api.github.com/repos/Audakel/CS340/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Audakel/CS340/downloads","issues_url":"https://api.github.com/repos/Audakel/CS340/issues{/number}","pulls_url":"https://api.github.com/repos/Audakel/CS340/pulls{/number}","milestones_url":"https://api.github.com/repos/Audakel/CS340/milestones{/number}","notifications_url":"https://api.github.com/repos/Audakel/CS340/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Audakel/CS340/labels{/name}","releases_url":"https://api.github.com/repos/Audakel/CS340/releases{/id}","deployments_url":"https://api.github.com/repos/Audakel/CS340/deployments","created_at":"2016-09-16T21:47:17Z","updated_at":"2016-09-16T21:47:20Z","pushed_at":"2016-12-07T03:20:50Z","git_url":"git://github.com/Audakel/CS340.git","ssh_url":"git@github.com:Audakel/CS340.git","clone_url":"https://github.com/Audakel/CS340.git","svn_url":"https://github.com/Audakel/CS340","homepage":null,"size":23952,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kupiakos:master","ref":"master","sha":"63e361395e203b8c031445c412c33301832d467b","user":{"login":"kupiakos","id":3309728,"avatar_url":"https://avatars.githubusercontent.com/u/3309728?v=3","gravatar_id":"","url":"https://api.github.com/users/kupiakos","html_url":"https://github.com/kupiakos","followers_url":"https://api.github.com/users/kupiakos/followers","following_url":"https://api.github.com/users/kupiakos/following{/other_user}","gists_url":"https://api.github.com/users/kupiakos/gists{/gist_id}","starred_url":"https://api.github.com/users/kupiakos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kupiakos/subscriptions","organizations_url":"https://api.github.com/users/kupiakos/orgs","repos_url":"https://api.github.com/users/kupiakos/repos","events_url":"https://api.github.com/users/kupiakos/events{/privacy}","received_events_url":"https://api.github.com/users/kupiakos/received_events","type":"User","site_admin":false},"repo":{"id":68044120,"name":"CS340","full_name":"kupiakos/CS340","owner":{"login":"kupiakos","id":3309728,"avatar_url":"https://avatars.githubusercontent.com/u/3309728?v=3","gravatar_id":"","url":"https://api.github.com/users/kupiakos","html_url":"https://github.com/kupiakos","followers_url":"https://api.github.com/users/kupiakos/followers","following_url":"https://api.github.com/users/kupiakos/following{/other_user}","gists_url":"https://api.github.com/users/kupiakos/gists{/gist_id}","starred_url":"https://api.github.com/users/kupiakos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kupiakos/subscriptions","organizations_url":"https://api.github.com/users/kupiakos/orgs","repos_url":"https://api.github.com/users/kupiakos/repos","events_url":"https://api.github.com/users/kupiakos/events{/privacy}","received_events_url":"https://api.github.com/users/kupiakos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kupiakos/CS340","description":null,"fork":false,"url":"https://api.github.com/repos/kupiakos/CS340","forks_url":"https://api.github.com/repos/kupiakos/CS340/forks","keys_url":"https://api.github.com/repos/kupiakos/CS340/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kupiakos/CS340/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kupiakos/CS340/teams","hooks_url":"https://api.github.com/repos/kupiakos/CS340/hooks","issue_events_url":"https://api.github.com/repos/kupiakos/CS340/issues/events{/number}","events_url":"https://api.github.com/repos/kupiakos/CS340/events","assignees_url":"https://api.github.com/repos/kupiakos/CS340/assignees{/user}","branches_url":"https://api.github.com/repos/kupiakos/CS340/branches{/branch}","tags_url":"https://api.github.com/repos/kupiakos/CS340/tags","blobs_url":"https://api.github.com/repos/kupiakos/CS340/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kupiakos/CS340/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kupiakos/CS340/git/refs{/sha}","trees_url":"https://api.github.com/repos/kupiakos/CS340/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kupiakos/CS340/statuses/{sha}","languages_url":"https://api.github.com/repos/kupiakos/CS340/languages","stargazers_url":"https://api.github.com/repos/kupiakos/CS340/stargazers","contributors_url":"https://api.github.com/repos/kupiakos/CS340/contributors","subscribers_url":"https://api.github.com/repos/kupiakos/CS340/subscribers","subscription_url":"https://api.github.com/repos/kupiakos/CS340/subscription","commits_url":"https://api.github.com/repos/kupiakos/CS340/commits{/sha}","git_commits_url":"https://api.github.com/repos/kupiakos/CS340/git/commits{/sha}","comments_url":"https://api.github.com/repos/kupiakos/CS340/comments{/number}","issue_comment_url":"https://api.github.com/repos/kupiakos/CS340/issues/comments{/number}","contents_url":"https://api.github.com/repos/kupiakos/CS340/contents/{+path}","compare_url":"https://api.github.com/repos/kupiakos/CS340/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kupiakos/CS340/merges","archive_url":"https://api.github.com/repos/kupiakos/CS340/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kupiakos/CS340/downloads","issues_url":"https://api.github.com/repos/kupiakos/CS340/issues{/number}","pulls_url":"https://api.github.com/repos/kupiakos/CS340/pulls{/number}","milestones_url":"https://api.github.com/repos/kupiakos/CS340/milestones{/number}","notifications_url":"https://api.github.com/repos/kupiakos/CS340/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kupiakos/CS340/labels{/name}","releases_url":"https://api.github.com/repos/kupiakos/CS340/releases{/id}","deployments_url":"https://api.github.com/repos/kupiakos/CS340/deployments","created_at":"2016-09-12T20:16:04Z","updated_at":"2016-11-21T20:51:25Z","pushed_at":"2016-12-07T03:20:50Z","git_url":"git://github.com/kupiakos/CS340.git","ssh_url":"git@github.com:kupiakos/CS340.git","clone_url":"https://github.com/kupiakos/CS340.git","svn_url":"https://github.com/kupiakos/CS340","homepage":null,"size":24512,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kupiakos/CS340/pulls/100"},"html":{"href":"https://github.com/kupiakos/CS340/pull/100"},"issue":{"href":"https://api.github.com/repos/kupiakos/CS340/issues/100"},"comments":{"href":"https://api.github.com/repos/kupiakos/CS340/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/kupiakos/CS340/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/kupiakos/CS340/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kupiakos/CS340/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/kupiakos/CS340/statuses/47d804cc8ca74b1b7a33c92a23bbbff324e09b12"}}}}
{"actor":{"display_login":"kupiakos"}}