{"action":"created","issue":{"url":"https://api.github.com/repos/OCA/bank-statement-reconcile/issues/137","repository_url":"https://api.github.com/repos/OCA/bank-statement-reconcile","labels_url":"https://api.github.com/repos/OCA/bank-statement-reconcile/issues/137/labels{/name}","comments_url":"https://api.github.com/repos/OCA/bank-statement-reconcile/issues/137/comments","events_url":"https://api.github.com/repos/OCA/bank-statement-reconcile/issues/137/events","html_url":"https://github.com/OCA/bank-statement-reconcile/pull/137","id":151581130,"number":137,"title":"[WIP] [9.0] account transaction base import","user":{"login":"mdietrichc2c","id":7628281,"avatar_url":"https://avatars.githubusercontent.com/u/7628281?v=3","gravatar_id":"","url":"https://api.github.com/users/mdietrichc2c","html_url":"https://github.com/mdietrichc2c","followers_url":"https://api.github.com/users/mdietrichc2c/followers","following_url":"https://api.github.com/users/mdietrichc2c/following{/other_user}","gists_url":"https://api.github.com/users/mdietrichc2c/gists{/gist_id}","starred_url":"https://api.github.com/users/mdietrichc2c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdietrichc2c/subscriptions","organizations_url":"https://api.github.com/users/mdietrichc2c/orgs","repos_url":"https://api.github.com/users/mdietrichc2c/repos","events_url":"https://api.github.com/users/mdietrichc2c/events{/privacy}","received_events_url":"https://api.github.com/users/mdietrichc2c/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-28T08:39:36Z","updated_at":"2016-04-28T09:21:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OCA/bank-statement-reconcile/pulls/137","html_url":"https://github.com/OCA/bank-statement-reconcile/pull/137","diff_url":"https://github.com/OCA/bank-statement-reconcile/pull/137.diff","patch_url":"https://github.com/OCA/bank-statement-reconcile/pull/137.patch"},"body":"This PR is to migrate multiple modules as one:\r\n* `account_statement_base_import`\r\n* `account_statement_base_completion`\r\n* `account_statement_commission`\r\n* parts of `account_statement_ext` (profile attributes + mass insertion/update of lines)\r\n\r\nAll are now grouped under `account_statement_base_import`\r\n\r\nThe main changes are:\r\n* instead of creating / auto-completing a bank statement, with a defined profile, Journal Entries are now used (since the goal is to import a lot of lines with commission amount), and instead of the profile, the journal is now used.\r\n* two booleans were added, in order to use a journal for import, completion or both.\r\n\r\nLeft to do:\r\n* modify the comments / code according to OCA guidelines,\r\n* migrate other modules (*_completion, *_import),\r\n* rename the module to something more \"on point\" (if you have suggestions)"},"comment":{"url":"https://api.github.com/repos/OCA/bank-statement-reconcile/issues/comments/215363335","html_url":"https://github.com/OCA/bank-statement-reconcile/pull/137#issuecomment-215363335","issue_url":"https://api.github.com/repos/OCA/bank-statement-reconcile/issues/137","id":215363335,"user":{"login":"pedrobaeza","id":7165771,"avatar_url":"https://avatars.githubusercontent.com/u/7165771?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrobaeza","html_url":"https://github.com/pedrobaeza","followers_url":"https://api.github.com/users/pedrobaeza/followers","following_url":"https://api.github.com/users/pedrobaeza/following{/other_user}","gists_url":"https://api.github.com/users/pedrobaeza/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrobaeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrobaeza/subscriptions","organizations_url":"https://api.github.com/users/pedrobaeza/orgs","repos_url":"https://api.github.com/users/pedrobaeza/repos","events_url":"https://api.github.com/users/pedrobaeza/events{/privacy}","received_events_url":"https://api.github.com/users/pedrobaeza/received_events","type":"User","site_admin":false},"created_at":"2016-04-28T09:21:27Z","updated_at":"2016-04-28T09:21:27Z","body":"That's not true. There's only a matching for the partner part, that you can even inhibit if you want via a custom module.\r\n\r\nI don't agree to add another import framework that confuses developers on what to use, so :-1: "}}