{"action":"created","comment":{"url":"https://api.github.com/repos/interledger/five-bells-connector/pulls/comments/70082282","id":70082282,"diff_hunk":"@@ -87,7 +87,7 @@ TransferTester.prototype.validateMaxHoldTime = function () {\n \n   if (expiresAt) {\n     this.validateExpiryHoldTime(expiresAt)\n-  } else {\n+  } else if (this.destinationTransfer.executionCondition) {","path":"src/lib/testPaymentExpiry.js","position":5,"original_position":5,"commit_id":"1231dca361a75c8c8881f53c42558941c5a9339d","original_commit_id":"1231dca361a75c8c8881f53c42558941c5a9339d","user":{"login":"sentientwaffle","id":461112,"avatar_url":"https://avatars.githubusercontent.com/u/461112?v=3","gravatar_id":"","url":"https://api.github.com/users/sentientwaffle","html_url":"https://github.com/sentientwaffle","followers_url":"https://api.github.com/users/sentientwaffle/followers","following_url":"https://api.github.com/users/sentientwaffle/following{/other_user}","gists_url":"https://api.github.com/users/sentientwaffle/gists{/gist_id}","starred_url":"https://api.github.com/users/sentientwaffle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sentientwaffle/subscriptions","organizations_url":"https://api.github.com/users/sentientwaffle/orgs","repos_url":"https://api.github.com/users/sentientwaffle/repos","events_url":"https://api.github.com/users/sentientwaffle/events{/privacy}","received_events_url":"https://api.github.com/users/sentientwaffle/received_events","type":"User","site_admin":false},"body":"I don't think this change is needed (see https://github.com/interledger/five-bells-connector/pull/180).","created_at":"2016-07-08T14:27:34Z","updated_at":"2016-07-08T14:27:34Z","html_url":"https://github.com/interledger/five-bells-connector/pull/175#discussion_r70082282","pull_request_url":"https://api.github.com/repos/interledger/five-bells-connector/pulls/175","_links":{"self":{"href":"https://api.github.com/repos/interledger/five-bells-connector/pulls/comments/70082282"},"html":{"href":"https://github.com/interledger/five-bells-connector/pull/175#discussion_r70082282"},"pull_request":{"href":"https://api.github.com/repos/interledger/five-bells-connector/pulls/175"}}},"pull_request":{"url":"https://api.github.com/repos/interledger/five-bells-connector/pulls/175","id":74881058,"html_url":"https://github.com/interledger/five-bells-connector/pull/175","diff_url":"https://github.com/interledger/five-bells-connector/pull/175.diff","patch_url":"https://github.com/interledger/five-bells-connector/pull/175.patch","issue_url":"https://api.github.com/repos/interledger/five-bells-connector/issues/175","number":175,"state":"open","locked":false,"title":"Fix: Support ILP-Plugin-Virtual","user":{"login":"bensharaf","id":3362563,"avatar_url":"https://avatars.githubusercontent.com/u/3362563?v=3","gravatar_id":"","url":"https://api.github.com/users/bensharaf","html_url":"https://github.com/bensharaf","followers_url":"https://api.github.com/users/bensharaf/followers","following_url":"https://api.github.com/users/bensharaf/following{/other_user}","gists_url":"https://api.github.com/users/bensharaf/gists{/gist_id}","starred_url":"https://api.github.com/users/bensharaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bensharaf/subscriptions","organizations_url":"https://api.github.com/users/bensharaf/orgs","repos_url":"https://api.github.com/users/bensharaf/repos","events_url":"https://api.github.com/users/bensharaf/events{/privacy}","received_events_url":"https://api.github.com/users/bensharaf/received_events","type":"User","site_admin":false},"body":"Changes multiledger and testPaymentExpiry so that ILP-Plugin-Virtual is able to be used in the connector. This includes adding a sqlite-based store in src/lib for persistence in ILP-Plugin-Virtual. ILP-Plugin-Virtual is also added as a dependency.","created_at":"2016-06-23T00:52:35Z","updated_at":"2016-07-08T14:27:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b12da53efc0339a6bc842c4220f2a84a878c50fe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/interledger/five-bells-connector/pulls/175/commits","review_comments_url":"https://api.github.com/repos/interledger/five-bells-connector/pulls/175/comments","review_comment_url":"https://api.github.com/repos/interledger/five-bells-connector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/interledger/five-bells-connector/issues/175/comments","statuses_url":"https://api.github.com/repos/interledger/five-bells-connector/statuses/1231dca361a75c8c8881f53c42558941c5a9339d","head":{"label":"interledger:fix/bs-ilp-plugin-virtual","ref":"fix/bs-ilp-plugin-virtual","sha":"1231dca361a75c8c8881f53c42558941c5a9339d","user":{"login":"interledger","id":14062960,"avatar_url":"https://avatars.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"repo":{"id":30608872,"name":"five-bells-connector","full_name":"interledger/five-bells-connector","owner":{"login":"interledger","id":14062960,"avatar_url":"https://avatars.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interledger/five-bells-connector","description":"Reference implementation of an Interledger connector.","fork":false,"url":"https://api.github.com/repos/interledger/five-bells-connector","forks_url":"https://api.github.com/repos/interledger/five-bells-connector/forks","keys_url":"https://api.github.com/repos/interledger/five-bells-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interledger/five-bells-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interledger/five-bells-connector/teams","hooks_url":"https://api.github.com/repos/interledger/five-bells-connector/hooks","issue_events_url":"https://api.github.com/repos/interledger/five-bells-connector/issues/events{/number}","events_url":"https://api.github.com/repos/interledger/five-bells-connector/events","assignees_url":"https://api.github.com/repos/interledger/five-bells-connector/assignees{/user}","branches_url":"https://api.github.com/repos/interledger/five-bells-connector/branches{/branch}","tags_url":"https://api.github.com/repos/interledger/five-bells-connector/tags","blobs_url":"https://api.github.com/repos/interledger/five-bells-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interledger/five-bells-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interledger/five-bells-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/interledger/five-bells-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interledger/five-bells-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/interledger/five-bells-connector/languages","stargazers_url":"https://api.github.com/repos/interledger/five-bells-connector/stargazers","contributors_url":"https://api.github.com/repos/interledger/five-bells-connector/contributors","subscribers_url":"https://api.github.com/repos/interledger/five-bells-connector/subscribers","subscription_url":"https://api.github.com/repos/interledger/five-bells-connector/subscription","commits_url":"https://api.github.com/repos/interledger/five-bells-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/interledger/five-bells-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/interledger/five-bells-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/interledger/five-bells-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/interledger/five-bells-connector/contents/{+path}","compare_url":"https://api.github.com/repos/interledger/five-bells-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interledger/five-bells-connector/merges","archive_url":"https://api.github.com/repos/interledger/five-bells-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interledger/five-bells-connector/downloads","issues_url":"https://api.github.com/repos/interledger/five-bells-connector/issues{/number}","pulls_url":"https://api.github.com/repos/interledger/five-bells-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/interledger/five-bells-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/interledger/five-bells-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interledger/five-bells-connector/labels{/name}","releases_url":"https://api.github.com/repos/interledger/five-bells-connector/releases{/id}","deployments_url":"https://api.github.com/repos/interledger/five-bells-connector/deployments","created_at":"2015-02-10T19:01:26Z","updated_at":"2016-06-20T16:57:31Z","pushed_at":"2016-07-07T22:41:55Z","git_url":"git://github.com/interledger/five-bells-connector.git","ssh_url":"git@github.com:interledger/five-bells-connector.git","clone_url":"https://github.com/interledger/five-bells-connector.git","svn_url":"https://github.com/interledger/five-bells-connector","homepage":"","size":1597,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":13,"forks":9,"open_issues":13,"watchers":5,"default_branch":"master"}},"base":{"label":"interledger:master","ref":"master","sha":"bf4814e71b94bed20caa46e3f20ee3a630f21ba1","user":{"login":"interledger","id":14062960,"avatar_url":"https://avatars.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"repo":{"id":30608872,"name":"five-bells-connector","full_name":"interledger/five-bells-connector","owner":{"login":"interledger","id":14062960,"avatar_url":"https://avatars.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interledger/five-bells-connector","description":"Reference implementation of an Interledger connector.","fork":false,"url":"https://api.github.com/repos/interledger/five-bells-connector","forks_url":"https://api.github.com/repos/interledger/five-bells-connector/forks","keys_url":"https://api.github.com/repos/interledger/five-bells-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interledger/five-bells-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interledger/five-bells-connector/teams","hooks_url":"https://api.github.com/repos/interledger/five-bells-connector/hooks","issue_events_url":"https://api.github.com/repos/interledger/five-bells-connector/issues/events{/number}","events_url":"https://api.github.com/repos/interledger/five-bells-connector/events","assignees_url":"https://api.github.com/repos/interledger/five-bells-connector/assignees{/user}","branches_url":"https://api.github.com/repos/interledger/five-bells-connector/branches{/branch}","tags_url":"https://api.github.com/repos/interledger/five-bells-connector/tags","blobs_url":"https://api.github.com/repos/interledger/five-bells-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interledger/five-bells-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interledger/five-bells-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/interledger/five-bells-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interledger/five-bells-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/interledger/five-bells-connector/languages","stargazers_url":"https://api.github.com/repos/interledger/five-bells-connector/stargazers","contributors_url":"https://api.github.com/repos/interledger/five-bells-connector/contributors","subscribers_url":"https://api.github.com/repos/interledger/five-bells-connector/subscribers","subscription_url":"https://api.github.com/repos/interledger/five-bells-connector/subscription","commits_url":"https://api.github.com/repos/interledger/five-bells-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/interledger/five-bells-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/interledger/five-bells-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/interledger/five-bells-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/interledger/five-bells-connector/contents/{+path}","compare_url":"https://api.github.com/repos/interledger/five-bells-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interledger/five-bells-connector/merges","archive_url":"https://api.github.com/repos/interledger/five-bells-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interledger/five-bells-connector/downloads","issues_url":"https://api.github.com/repos/interledger/five-bells-connector/issues{/number}","pulls_url":"https://api.github.com/repos/interledger/five-bells-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/interledger/five-bells-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/interledger/five-bells-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interledger/five-bells-connector/labels{/name}","releases_url":"https://api.github.com/repos/interledger/five-bells-connector/releases{/id}","deployments_url":"https://api.github.com/repos/interledger/five-bells-connector/deployments","created_at":"2015-02-10T19:01:26Z","updated_at":"2016-06-20T16:57:31Z","pushed_at":"2016-07-07T22:41:55Z","git_url":"git://github.com/interledger/five-bells-connector.git","ssh_url":"git@github.com:interledger/five-bells-connector.git","clone_url":"https://github.com/interledger/five-bells-connector.git","svn_url":"https://github.com/interledger/five-bells-connector","homepage":"","size":1597,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":13,"forks":9,"open_issues":13,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/interledger/five-bells-connector/pulls/175"},"html":{"href":"https://github.com/interledger/five-bells-connector/pull/175"},"issue":{"href":"https://api.github.com/repos/interledger/five-bells-connector/issues/175"},"comments":{"href":"https://api.github.com/repos/interledger/five-bells-connector/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/interledger/five-bells-connector/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/interledger/five-bells-connector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/interledger/five-bells-connector/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/interledger/five-bells-connector/statuses/1231dca361a75c8c8881f53c42558941c5a9339d"}}}}
{"actor":{"display_login":"sentientwaffle"}}