{"action":"created","issue":{"url":"https://api.github.com/repos/camunda/camunda-bpm-platform/issues/225","repository_url":"https://api.github.com/repos/camunda/camunda-bpm-platform","labels_url":"https://api.github.com/repos/camunda/camunda-bpm-platform/issues/225/labels{/name}","comments_url":"https://api.github.com/repos/camunda/camunda-bpm-platform/issues/225/comments","events_url":"https://api.github.com/repos/camunda/camunda-bpm-platform/issues/225/events","html_url":"https://github.com/camunda/camunda-bpm-platform/pull/225","id":149957794,"number":225,"title":"Cam 4450 timer event listener : JobDefinition Changes","user":{"login":"subhrajyotim","id":1927583,"avatar_url":"https://avatars.githubusercontent.com/u/1927583?v=3","gravatar_id":"","url":"https://api.github.com/users/subhrajyotim","html_url":"https://github.com/subhrajyotim","followers_url":"https://api.github.com/users/subhrajyotim/followers","following_url":"https://api.github.com/users/subhrajyotim/following{/other_user}","gists_url":"https://api.github.com/users/subhrajyotim/gists{/gist_id}","starred_url":"https://api.github.com/users/subhrajyotim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subhrajyotim/subscriptions","organizations_url":"https://api.github.com/users/subhrajyotim/orgs","repos_url":"https://api.github.com/users/subhrajyotim/repos","events_url":"https://api.github.com/users/subhrajyotim/events{/privacy}","received_events_url":"https://api.github.com/users/subhrajyotim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"romansmirnov","id":2368139,"avatar_url":"https://avatars.githubusercontent.com/u/2368139?v=3","gravatar_id":"","url":"https://api.github.com/users/romansmirnov","html_url":"https://github.com/romansmirnov","followers_url":"https://api.github.com/users/romansmirnov/followers","following_url":"https://api.github.com/users/romansmirnov/following{/other_user}","gists_url":"https://api.github.com/users/romansmirnov/gists{/gist_id}","starred_url":"https://api.github.com/users/romansmirnov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romansmirnov/subscriptions","organizations_url":"https://api.github.com/users/romansmirnov/orgs","repos_url":"https://api.github.com/users/romansmirnov/repos","events_url":"https://api.github.com/users/romansmirnov/events{/privacy}","received_events_url":"https://api.github.com/users/romansmirnov/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2016-04-21T03:56:54Z","updated_at":"2016-04-28T08:42:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/camunda/camunda-bpm-platform/pulls/225","html_url":"https://github.com/camunda/camunda-bpm-platform/pull/225","diff_url":"https://github.com/camunda/camunda-bpm-platform/pull/225.diff","patch_url":"https://github.com/camunda/camunda-bpm-platform/pull/225.patch"},"body":"Hello Roman,\r\nPlease review the changes. Please let me know what all changes are required.\r\n\r\nThanks a lot for your time.\r\nSubhro."},"comment":{"url":"https://api.github.com/repos/camunda/camunda-bpm-platform/issues/comments/215354260","html_url":"https://github.com/camunda/camunda-bpm-platform/pull/225#issuecomment-215354260","issue_url":"https://api.github.com/repos/camunda/camunda-bpm-platform/issues/225","id":215354260,"user":{"login":"subhrajyotim","id":1927583,"avatar_url":"https://avatars.githubusercontent.com/u/1927583?v=3","gravatar_id":"","url":"https://api.github.com/users/subhrajyotim","html_url":"https://github.com/subhrajyotim","followers_url":"https://api.github.com/users/subhrajyotim/followers","following_url":"https://api.github.com/users/subhrajyotim/following{/other_user}","gists_url":"https://api.github.com/users/subhrajyotim/gists{/gist_id}","starred_url":"https://api.github.com/users/subhrajyotim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subhrajyotim/subscriptions","organizations_url":"https://api.github.com/users/subhrajyotim/orgs","repos_url":"https://api.github.com/users/subhrajyotim/repos","events_url":"https://api.github.com/users/subhrajyotim/events{/privacy}","received_events_url":"https://api.github.com/users/subhrajyotim/received_events","type":"User","site_admin":false},"created_at":"2016-04-28T08:42:54Z","updated_at":"2016-04-28T08:42:54Z","body":"Hello Roman,\n\nI have done the changes as u mentioned. Let me know if all is ok.\n\nThanks again for your time,\nSubhro.\n\nOn Thu, Apr 28, 2016 at 1:19 PM, Roman Smirnov <notifications@github.com>\nwrote:\n\n> Hi Subhro,\n>\n> CmmnDeployer.java:L122, I have not set any acvitiyId on the\n> TimerEventListenerJobDeclaration or JobDefinitionEntity, hence the if check\n> has no activity checks, not sure if this is correct.\n>\n> Good point! It necessary to set the activity id on the\n> TimerEventListenerJobDeclaration. Therefore I would suggest to extend the\n> TimerEventListenerJobDeclaration as follows:\n>\n> public class TimerEventListenerJobDeclaration extends TimerJobDeclaration<CaseExecutionEntity> {\n>\n>   protected CmmnActivity cmmnActivity;\n>\n>   public void setActivity(CmmnActivity activity) {\n>     this.cmmnActivity = activity;\n>   }\n>\n>   public String getActivityId() {\n>     if (cmmnActivity != null) {\n>       return cmmnActivity.getId();\n>     }\n>     else {\n>       return null;\n>     }\n>   }\n> }\n>\n> Then you should be able to set the activity on the\n> TimerEventListenerJobDeclaration in\n> TimerEventListenerItemHandler#initializeTimerEventListenerJobDeclaration()\n> .\n>\n> As a consequence, the if-check in line CmmnDeployer.java:L122 should\n> contain the activity check.\n>\n> Could you please adjust this?\n>\n> Thanks.\n>\n> Cheers,\n> Roman\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly or view it on GitHub\n> <https://github.com/camunda/camunda-bpm-platform/pull/225#issuecomment-215338680>\n>\n"}}