{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/addons-frontend/issues/1190","repository_url":"https://api.github.com/repos/mozilla/addons-frontend","labels_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/1190/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/1190/comments","events_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/1190/events","html_url":"https://github.com/mozilla/addons-frontend/pull/1190","id":181608749,"number":1190,"title":"Use CentredInput in SearchForm","user":{"login":"mstriemer","id":211578,"avatar_url":"https://avatars.githubusercontent.com/u/211578?v=3","gravatar_id":"","url":"https://api.github.com/users/mstriemer","html_url":"https://github.com/mstriemer","followers_url":"https://api.github.com/users/mstriemer/followers","following_url":"https://api.github.com/users/mstriemer/following{/other_user}","gists_url":"https://api.github.com/users/mstriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/mstriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstriemer/subscriptions","organizations_url":"https://api.github.com/users/mstriemer/orgs","repos_url":"https://api.github.com/users/mstriemer/repos","events_url":"https://api.github.com/users/mstriemer/events{/privacy}","received_events_url":"https://api.github.com/users/mstriemer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/addons-frontend/labels/pull%20request%20ready","name":"pull request ready","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"tofumatt","id":90871,"avatar_url":"https://avatars.githubusercontent.com/u/90871?v=3","gravatar_id":"","url":"https://api.github.com/users/tofumatt","html_url":"https://github.com/tofumatt","followers_url":"https://api.github.com/users/tofumatt/followers","following_url":"https://api.github.com/users/tofumatt/following{/other_user}","gists_url":"https://api.github.com/users/tofumatt/gists{/gist_id}","starred_url":"https://api.github.com/users/tofumatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofumatt/subscriptions","organizations_url":"https://api.github.com/users/tofumatt/orgs","repos_url":"https://api.github.com/users/tofumatt/repos","events_url":"https://api.github.com/users/tofumatt/events{/privacy}","received_events_url":"https://api.github.com/users/tofumatt/received_events","type":"User","site_admin":false},"assignees":[{"login":"tofumatt","id":90871,"avatar_url":"https://avatars.githubusercontent.com/u/90871?v=3","gravatar_id":"","url":"https://api.github.com/users/tofumatt","html_url":"https://github.com/tofumatt","followers_url":"https://api.github.com/users/tofumatt/followers","following_url":"https://api.github.com/users/tofumatt/following{/other_user}","gists_url":"https://api.github.com/users/tofumatt/gists{/gist_id}","starred_url":"https://api.github.com/users/tofumatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofumatt/subscriptions","organizations_url":"https://api.github.com/users/tofumatt/orgs","repos_url":"https://api.github.com/users/tofumatt/repos","events_url":"https://api.github.com/users/tofumatt/events{/privacy}","received_events_url":"https://api.github.com/users/tofumatt/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-10-07T08:12:46Z","updated_at":"2016-10-11T21:32:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/1190","html_url":"https://github.com/mozilla/addons-frontend/pull/1190","diff_url":"https://github.com/mozilla/addons-frontend/pull/1190.diff","patch_url":"https://github.com/mozilla/addons-frontend/pull/1190.patch"},"body":"This was how we wanted the input to look on Marketplace so I'm guessing we want to do something similar here.\r\n\r\nI put `<CentredInput />` in the `src/ui/components` folder, I'm not sure if we want to name that something else. I think I like the idea of having an app that's just reusable components though. Perhaps the magnifying glass could get moved into a wrapper component called `<CentredSearchInput />` or something.\r\n\r\nWe could probably make a little app in `src/ui` to be a styleguide and show off and document the components as well.\r\n\r\n![centred-search-form mov](https://cloud.githubusercontent.com/assets/211578/19182972/7d08bb06-8c76-11e6-92e6-041fa9a9d8ad.gif)\r\n\r\n@pwalm thoughts?"},"comment":{"url":"https://api.github.com/repos/mozilla/addons-frontend/issues/comments/253053281","html_url":"https://github.com/mozilla/addons-frontend/pull/1190#issuecomment-253053281","issue_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/1190","id":253053281,"user":{"login":"mstriemer","id":211578,"avatar_url":"https://avatars.githubusercontent.com/u/211578?v=3","gravatar_id":"","url":"https://api.github.com/users/mstriemer","html_url":"https://github.com/mstriemer","followers_url":"https://api.github.com/users/mstriemer/followers","following_url":"https://api.github.com/users/mstriemer/following{/other_user}","gists_url":"https://api.github.com/users/mstriemer/gists{/gist_id}","starred_url":"https://api.github.com/users/mstriemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstriemer/subscriptions","organizations_url":"https://api.github.com/users/mstriemer/orgs","repos_url":"https://api.github.com/users/mstriemer/repos","events_url":"https://api.github.com/users/mstriemer/events{/privacy}","received_events_url":"https://api.github.com/users/mstriemer/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T21:32:55Z","updated_at":"2016-10-11T21:32:55Z","body":"> It looks like it's ever-so-slightly to the left and not centred, maybe it's just the magnifying glass making it look that way and it needs some left-padding?\r\n\r\nI centred the text and put the icon beside it rather than centring the two together. I was going to ask @pwalm for his thoughts and mocked them both out. I now think both centred looks better though, but I'll post the pictures anyway.\r\n\r\n<img width=\"411\" alt=\"screenshot 2016-10-11 16 20 45\" src=\"https://cloud.githubusercontent.com/assets/211578/19289412/4bafd794-8fd0-11e6-869a-2eae41edd34d.png\">\r\n> Text centred\r\n\r\n<img width=\"411\" alt=\"screenshot 2016-10-11 16 27 06\" src=\"https://cloud.githubusercontent.com/assets/211578/19289411/4bab0b88-8fd0-11e6-8242-982a2ef66e91.png\">\r\n> Both centred"}}
{"actor":{"display_login":"mstriemer"}}