{"action":"created","comment":{"url":"https://api.github.com/repos/lob/hapi-rate-limiter/pulls/comments/77684121","id":77684121,"diff_hunk":"@@ -110,7 +125,7 @@ describe('plugin', () => {\n   }]);\n \n   beforeEach(() => {\n-    return redisClient.flushdb();","path":"test/index.test.js","position":null,"original_position":26,"commit_id":"162e1a8f536e840e522dbcb9944d18cc1932feed","original_commit_id":"5e646efb2b615c8a8dc031cd66929f368af156af","user":{"login":"sjl2","id":8300986,"avatar_url":"https://avatars.githubusercontent.com/u/8300986?v=3","gravatar_id":"","url":"https://api.github.com/users/sjl2","html_url":"https://github.com/sjl2","followers_url":"https://api.github.com/users/sjl2/followers","following_url":"https://api.github.com/users/sjl2/following{/other_user}","gists_url":"https://api.github.com/users/sjl2/gists{/gist_id}","starred_url":"https://api.github.com/users/sjl2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjl2/subscriptions","organizations_url":"https://api.github.com/users/sjl2/orgs","repos_url":"https://api.github.com/users/sjl2/repos","events_url":"https://api.github.com/users/sjl2/events{/privacy}","received_events_url":"https://api.github.com/users/sjl2/received_events","type":"User","site_admin":false},"body":"@charlesbjohnson Could you explain this a little more?","created_at":"2016-09-06T17:46:12Z","updated_at":"2016-09-06T17:46:12Z","html_url":"https://github.com/lob/hapi-rate-limiter/pull/18#discussion_r77684121","pull_request_url":"https://api.github.com/repos/lob/hapi-rate-limiter/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/lob/hapi-rate-limiter/pulls/comments/77684121"},"html":{"href":"https://github.com/lob/hapi-rate-limiter/pull/18#discussion_r77684121"},"pull_request":{"href":"https://api.github.com/repos/lob/hapi-rate-limiter/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/lob/hapi-rate-limiter/pulls/18","id":83728445,"html_url":"https://github.com/lob/hapi-rate-limiter/pull/18","diff_url":"https://github.com/lob/hapi-rate-limiter/pull/18.diff","patch_url":"https://github.com/lob/hapi-rate-limiter/pull/18.patch","issue_url":"https://api.github.com/repos/lob/hapi-rate-limiter/issues/18","number":18,"state":"open","locked":false,"title":"feat(rateLimitKey): Allows endpoint specification of the rateLimitKey…","user":{"login":"sjl2","id":8300986,"avatar_url":"https://avatars.githubusercontent.com/u/8300986?v=3","gravatar_id":"","url":"https://api.github.com/users/sjl2","html_url":"https://github.com/sjl2","followers_url":"https://api.github.com/users/sjl2/followers","following_url":"https://api.github.com/users/sjl2/following{/other_user}","gists_url":"https://api.github.com/users/sjl2/gists{/gist_id}","starred_url":"https://api.github.com/users/sjl2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjl2/subscriptions","organizations_url":"https://api.github.com/users/sjl2/orgs","repos_url":"https://api.github.com/users/sjl2/repos","events_url":"https://api.github.com/users/sjl2/events{/privacy}","received_events_url":"https://api.github.com/users/sjl2/received_events","type":"User","site_admin":false},"body":"… function\r\n\r\nWhat: Allow an endpoint's hapi-rate-limiter settings to customize the function used to generate the rate limit key.\r\n\r\nWhy: Need this functionality for certain endpoints that don't require authentication\r\n- e.g. Instead of using api_key, an endpoint that doesn't require the api_key can use IP address.\r\n","created_at":"2016-09-02T00:23:31Z","updated_at":"2016-09-06T17:46:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7229f32617b7b9dbd8865cd1140504d392d616c7","assignee":{"login":"charlesbjohnson","id":4823640,"avatar_url":"https://avatars.githubusercontent.com/u/4823640?v=3","gravatar_id":"","url":"https://api.github.com/users/charlesbjohnson","html_url":"https://github.com/charlesbjohnson","followers_url":"https://api.github.com/users/charlesbjohnson/followers","following_url":"https://api.github.com/users/charlesbjohnson/following{/other_user}","gists_url":"https://api.github.com/users/charlesbjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesbjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesbjohnson/subscriptions","organizations_url":"https://api.github.com/users/charlesbjohnson/orgs","repos_url":"https://api.github.com/users/charlesbjohnson/repos","events_url":"https://api.github.com/users/charlesbjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/charlesbjohnson/received_events","type":"User","site_admin":false},"assignees":[{"login":"charlesbjohnson","id":4823640,"avatar_url":"https://avatars.githubusercontent.com/u/4823640?v=3","gravatar_id":"","url":"https://api.github.com/users/charlesbjohnson","html_url":"https://github.com/charlesbjohnson","followers_url":"https://api.github.com/users/charlesbjohnson/followers","following_url":"https://api.github.com/users/charlesbjohnson/following{/other_user}","gists_url":"https://api.github.com/users/charlesbjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesbjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesbjohnson/subscriptions","organizations_url":"https://api.github.com/users/charlesbjohnson/orgs","repos_url":"https://api.github.com/users/charlesbjohnson/repos","events_url":"https://api.github.com/users/charlesbjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/charlesbjohnson/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/lob/hapi-rate-limiter/pulls/18/commits","review_comments_url":"https://api.github.com/repos/lob/hapi-rate-limiter/pulls/18/comments","review_comment_url":"https://api.github.com/repos/lob/hapi-rate-limiter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lob/hapi-rate-limiter/issues/18/comments","statuses_url":"https://api.github.com/repos/lob/hapi-rate-limiter/statuses/162e1a8f536e840e522dbcb9944d18cc1932feed","head":{"label":"lob:endpoint-rate-limit-key","ref":"endpoint-rate-limit-key","sha":"162e1a8f536e840e522dbcb9944d18cc1932feed","user":{"login":"lob","id":4955790,"avatar_url":"https://avatars.githubusercontent.com/u/4955790?v=3","gravatar_id":"","url":"https://api.github.com/users/lob","html_url":"https://github.com/lob","followers_url":"https://api.github.com/users/lob/followers","following_url":"https://api.github.com/users/lob/following{/other_user}","gists_url":"https://api.github.com/users/lob/gists{/gist_id}","starred_url":"https://api.github.com/users/lob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lob/subscriptions","organizations_url":"https://api.github.com/users/lob/orgs","repos_url":"https://api.github.com/users/lob/repos","events_url":"https://api.github.com/users/lob/events{/privacy}","received_events_url":"https://api.github.com/users/lob/received_events","type":"Organization","site_admin":false},"repo":{"id":62758348,"name":"hapi-rate-limiter","full_name":"lob/hapi-rate-limiter","owner":{"login":"lob","id":4955790,"avatar_url":"https://avatars.githubusercontent.com/u/4955790?v=3","gravatar_id":"","url":"https://api.github.com/users/lob","html_url":"https://github.com/lob","followers_url":"https://api.github.com/users/lob/followers","following_url":"https://api.github.com/users/lob/following{/other_user}","gists_url":"https://api.github.com/users/lob/gists{/gist_id}","starred_url":"https://api.github.com/users/lob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lob/subscriptions","organizations_url":"https://api.github.com/users/lob/orgs","repos_url":"https://api.github.com/users/lob/repos","events_url":"https://api.github.com/users/lob/events{/privacy}","received_events_url":"https://api.github.com/users/lob/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lob/hapi-rate-limiter","description":null,"fork":false,"url":"https://api.github.com/repos/lob/hapi-rate-limiter","forks_url":"https://api.github.com/repos/lob/hapi-rate-limiter/forks","keys_url":"https://api.github.com/repos/lob/hapi-rate-limiter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lob/hapi-rate-limiter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lob/hapi-rate-limiter/teams","hooks_url":"https://api.github.com/repos/lob/hapi-rate-limiter/hooks","issue_events_url":"https://api.github.com/repos/lob/hapi-rate-limiter/issues/events{/number}","events_url":"https://api.github.com/repos/lob/hapi-rate-limiter/events","assignees_url":"https://api.github.com/repos/lob/hapi-rate-limiter/assignees{/user}","branches_url":"https://api.github.com/repos/lob/hapi-rate-limiter/branches{/branch}","tags_url":"https://api.github.com/repos/lob/hapi-rate-limiter/tags","blobs_url":"https://api.github.com/repos/lob/hapi-rate-limiter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lob/hapi-rate-limiter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lob/hapi-rate-limiter/git/refs{/sha}","trees_url":"https://api.github.com/repos/lob/hapi-rate-limiter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lob/hapi-rate-limiter/statuses/{sha}","languages_url":"https://api.github.com/repos/lob/hapi-rate-limiter/languages","stargazers_url":"https://api.github.com/repos/lob/hapi-rate-limiter/stargazers","contributors_url":"https://api.github.com/repos/lob/hapi-rate-limiter/contributors","subscribers_url":"https://api.github.com/repos/lob/hapi-rate-limiter/subscribers","subscription_url":"https://api.github.com/repos/lob/hapi-rate-limiter/subscription","commits_url":"https://api.github.com/repos/lob/hapi-rate-limiter/commits{/sha}","git_commits_url":"https://api.github.com/repos/lob/hapi-rate-limiter/git/commits{/sha}","comments_url":"https://api.github.com/repos/lob/hapi-rate-limiter/comments{/number}","issue_comment_url":"https://api.github.com/repos/lob/hapi-rate-limiter/issues/comments{/number}","contents_url":"https://api.github.com/repos/lob/hapi-rate-limiter/contents/{+path}","compare_url":"https://api.github.com/repos/lob/hapi-rate-limiter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lob/hapi-rate-limiter/merges","archive_url":"https://api.github.com/repos/lob/hapi-rate-limiter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lob/hapi-rate-limiter/downloads","issues_url":"https://api.github.com/repos/lob/hapi-rate-limiter/issues{/number}","pulls_url":"https://api.github.com/repos/lob/hapi-rate-limiter/pulls{/number}","milestones_url":"https://api.github.com/repos/lob/hapi-rate-limiter/milestones{/number}","notifications_url":"https://api.github.com/repos/lob/hapi-rate-limiter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lob/hapi-rate-limiter/labels{/name}","releases_url":"https://api.github.com/repos/lob/hapi-rate-limiter/releases{/id}","deployments_url":"https://api.github.com/repos/lob/hapi-rate-limiter/deployments","created_at":"2016-07-06T22:50:13Z","updated_at":"2016-07-28T19:12:02Z","pushed_at":"2016-09-06T17:40:49Z","git_url":"git://github.com/lob/hapi-rate-limiter.git","ssh_url":"git@github.com:lob/hapi-rate-limiter.git","clone_url":"https://github.com/lob/hapi-rate-limiter.git","svn_url":"https://github.com/lob/hapi-rate-limiter","homepage":null,"size":40,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"lob:master","ref":"master","sha":"6bcdc09fa925a979303842bf4da9fe36da0fe034","user":{"login":"lob","id":4955790,"avatar_url":"https://avatars.githubusercontent.com/u/4955790?v=3","gravatar_id":"","url":"https://api.github.com/users/lob","html_url":"https://github.com/lob","followers_url":"https://api.github.com/users/lob/followers","following_url":"https://api.github.com/users/lob/following{/other_user}","gists_url":"https://api.github.com/users/lob/gists{/gist_id}","starred_url":"https://api.github.com/users/lob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lob/subscriptions","organizations_url":"https://api.github.com/users/lob/orgs","repos_url":"https://api.github.com/users/lob/repos","events_url":"https://api.github.com/users/lob/events{/privacy}","received_events_url":"https://api.github.com/users/lob/received_events","type":"Organization","site_admin":false},"repo":{"id":62758348,"name":"hapi-rate-limiter","full_name":"lob/hapi-rate-limiter","owner":{"login":"lob","id":4955790,"avatar_url":"https://avatars.githubusercontent.com/u/4955790?v=3","gravatar_id":"","url":"https://api.github.com/users/lob","html_url":"https://github.com/lob","followers_url":"https://api.github.com/users/lob/followers","following_url":"https://api.github.com/users/lob/following{/other_user}","gists_url":"https://api.github.com/users/lob/gists{/gist_id}","starred_url":"https://api.github.com/users/lob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lob/subscriptions","organizations_url":"https://api.github.com/users/lob/orgs","repos_url":"https://api.github.com/users/lob/repos","events_url":"https://api.github.com/users/lob/events{/privacy}","received_events_url":"https://api.github.com/users/lob/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lob/hapi-rate-limiter","description":null,"fork":false,"url":"https://api.github.com/repos/lob/hapi-rate-limiter","forks_url":"https://api.github.com/repos/lob/hapi-rate-limiter/forks","keys_url":"https://api.github.com/repos/lob/hapi-rate-limiter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lob/hapi-rate-limiter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lob/hapi-rate-limiter/teams","hooks_url":"https://api.github.com/repos/lob/hapi-rate-limiter/hooks","issue_events_url":"https://api.github.com/repos/lob/hapi-rate-limiter/issues/events{/number}","events_url":"https://api.github.com/repos/lob/hapi-rate-limiter/events","assignees_url":"https://api.github.com/repos/lob/hapi-rate-limiter/assignees{/user}","branches_url":"https://api.github.com/repos/lob/hapi-rate-limiter/branches{/branch}","tags_url":"https://api.github.com/repos/lob/hapi-rate-limiter/tags","blobs_url":"https://api.github.com/repos/lob/hapi-rate-limiter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lob/hapi-rate-limiter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lob/hapi-rate-limiter/git/refs{/sha}","trees_url":"https://api.github.com/repos/lob/hapi-rate-limiter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lob/hapi-rate-limiter/statuses/{sha}","languages_url":"https://api.github.com/repos/lob/hapi-rate-limiter/languages","stargazers_url":"https://api.github.com/repos/lob/hapi-rate-limiter/stargazers","contributors_url":"https://api.github.com/repos/lob/hapi-rate-limiter/contributors","subscribers_url":"https://api.github.com/repos/lob/hapi-rate-limiter/subscribers","subscription_url":"https://api.github.com/repos/lob/hapi-rate-limiter/subscription","commits_url":"https://api.github.com/repos/lob/hapi-rate-limiter/commits{/sha}","git_commits_url":"https://api.github.com/repos/lob/hapi-rate-limiter/git/commits{/sha}","comments_url":"https://api.github.com/repos/lob/hapi-rate-limiter/comments{/number}","issue_comment_url":"https://api.github.com/repos/lob/hapi-rate-limiter/issues/comments{/number}","contents_url":"https://api.github.com/repos/lob/hapi-rate-limiter/contents/{+path}","compare_url":"https://api.github.com/repos/lob/hapi-rate-limiter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lob/hapi-rate-limiter/merges","archive_url":"https://api.github.com/repos/lob/hapi-rate-limiter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lob/hapi-rate-limiter/downloads","issues_url":"https://api.github.com/repos/lob/hapi-rate-limiter/issues{/number}","pulls_url":"https://api.github.com/repos/lob/hapi-rate-limiter/pulls{/number}","milestones_url":"https://api.github.com/repos/lob/hapi-rate-limiter/milestones{/number}","notifications_url":"https://api.github.com/repos/lob/hapi-rate-limiter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lob/hapi-rate-limiter/labels{/name}","releases_url":"https://api.github.com/repos/lob/hapi-rate-limiter/releases{/id}","deployments_url":"https://api.github.com/repos/lob/hapi-rate-limiter/deployments","created_at":"2016-07-06T22:50:13Z","updated_at":"2016-07-28T19:12:02Z","pushed_at":"2016-09-06T17:40:49Z","git_url":"git://github.com/lob/hapi-rate-limiter.git","ssh_url":"git@github.com:lob/hapi-rate-limiter.git","clone_url":"https://github.com/lob/hapi-rate-limiter.git","svn_url":"https://github.com/lob/hapi-rate-limiter","homepage":null,"size":40,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lob/hapi-rate-limiter/pulls/18"},"html":{"href":"https://github.com/lob/hapi-rate-limiter/pull/18"},"issue":{"href":"https://api.github.com/repos/lob/hapi-rate-limiter/issues/18"},"comments":{"href":"https://api.github.com/repos/lob/hapi-rate-limiter/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/lob/hapi-rate-limiter/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/lob/hapi-rate-limiter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lob/hapi-rate-limiter/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/lob/hapi-rate-limiter/statuses/162e1a8f536e840e522dbcb9944d18cc1932feed"}}}}
{"actor":{"display_login":"sjl2"}}