{"action":"created","issue":{"url":"https://api.github.com/repos/OTRS/otrs/issues/1272","repository_url":"https://api.github.com/repos/OTRS/otrs","labels_url":"https://api.github.com/repos/OTRS/otrs/issues/1272/labels{/name}","comments_url":"https://api.github.com/repos/OTRS/otrs/issues/1272/comments","events_url":"https://api.github.com/repos/OTRS/otrs/issues/1272/events","html_url":"https://github.com/OTRS/otrs/pull/1272","id":160618449,"number":1272,"title":"Fixed empty attachment links and ugly filesize formatting","user":{"login":"pboguslawski","id":8192649,"avatar_url":"https://avatars.githubusercontent.com/u/8192649?v=3","gravatar_id":"","url":"https://api.github.com/users/pboguslawski","html_url":"https://github.com/pboguslawski","followers_url":"https://api.github.com/users/pboguslawski/followers","following_url":"https://api.github.com/users/pboguslawski/following{/other_user}","gists_url":"https://api.github.com/users/pboguslawski/gists{/gist_id}","starred_url":"https://api.github.com/users/pboguslawski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboguslawski/subscriptions","organizations_url":"https://api.github.com/users/pboguslawski/orgs","repos_url":"https://api.github.com/users/pboguslawski/repos","events_url":"https://api.github.com/users/pboguslawski/events{/privacy}","received_events_url":"https://api.github.com/users/pboguslawski/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"dvuckovic","id":6049445,"avatar_url":"https://avatars.githubusercontent.com/u/6049445?v=3","gravatar_id":"","url":"https://api.github.com/users/dvuckovic","html_url":"https://github.com/dvuckovic","followers_url":"https://api.github.com/users/dvuckovic/followers","following_url":"https://api.github.com/users/dvuckovic/following{/other_user}","gists_url":"https://api.github.com/users/dvuckovic/gists{/gist_id}","starred_url":"https://api.github.com/users/dvuckovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvuckovic/subscriptions","organizations_url":"https://api.github.com/users/dvuckovic/orgs","repos_url":"https://api.github.com/users/dvuckovic/repos","events_url":"https://api.github.com/users/dvuckovic/events{/privacy}","received_events_url":"https://api.github.com/users/dvuckovic/received_events","type":"User","site_admin":false},"assignees":[{"login":"dvuckovic","id":6049445,"avatar_url":"https://avatars.githubusercontent.com/u/6049445?v=3","gravatar_id":"","url":"https://api.github.com/users/dvuckovic","html_url":"https://github.com/dvuckovic","followers_url":"https://api.github.com/users/dvuckovic/followers","following_url":"https://api.github.com/users/dvuckovic/following{/other_user}","gists_url":"https://api.github.com/users/dvuckovic/gists{/gist_id}","starred_url":"https://api.github.com/users/dvuckovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvuckovic/subscriptions","organizations_url":"https://api.github.com/users/dvuckovic/orgs","repos_url":"https://api.github.com/users/dvuckovic/repos","events_url":"https://api.github.com/users/dvuckovic/events{/privacy}","received_events_url":"https://api.github.com/users/dvuckovic/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-06-16T09:34:46Z","updated_at":"2016-09-07T14:45:59Z","closed_at":"2016-09-07T14:45:59Z","pull_request":{"url":"https://api.github.com/repos/OTRS/otrs/pulls/1272","html_url":"https://github.com/OTRS/otrs/pull/1272","diff_url":"https://github.com/OTRS/otrs/pull/1272.diff","patch_url":"https://github.com/OTRS/otrs/pull/1272.patch"},"body":"OTRS adds empty link in HTML code in attachment block in AgentTicketZoom\r\nand CustomerTicketZoom, i.e.:\r\n\r\n    <label>Attachment:</label>\r\n    <p class=\"Value\">\r\n        <a class=\"\" href=\"/otrs/index.pl?Action=AgentTicketAttachment;ArticleID=2;FileID=1\" target=\"AttachmentWindow\" title=\"Download\">test1.pdf</a>\r\n        <a class=\"\" href=\"\" title=\"\"></a> , 332.1 KB\r\n        <br>\r\n        <a class=\"\" href=\"/otrs/index.pl?Action=AgentTicketAttachment;ArticleID=2;FileID=3\" target=\"AttachmentWindow\" title=\"Download\">test2.txt</a>\r\n        <a class=\"\" href=\"\" title=\"\"></a> , 6 B\r\n        <br>\r\n    </p>\r\n\r\nThis disrupts tools like FlashGot when selecting a few attachments\r\nto download in one shot.\r\n\r\nAttachment sizes in AgentTicketZoom and CustomerTicketZoom are separated\r\nfrom filename with ugly \" , \" while in attachment upload forms there\r\nis nicer formatting like \"filename (size)\".\r\n\r\nThis mod fixes both issues.\r\n\r\nRelated: https://dev.ib.pl/ib/otrs/issues/69\r\nAuthor-Change-Id: IB#1020949"},"comment":{"url":"https://api.github.com/repos/OTRS/otrs/issues/comments/245303943","html_url":"https://github.com/OTRS/otrs/pull/1272#issuecomment-245303943","issue_url":"https://api.github.com/repos/OTRS/otrs/issues/1272","id":245303943,"user":{"login":"dvuckovic","id":6049445,"avatar_url":"https://avatars.githubusercontent.com/u/6049445?v=3","gravatar_id":"","url":"https://api.github.com/users/dvuckovic","html_url":"https://github.com/dvuckovic","followers_url":"https://api.github.com/users/dvuckovic/followers","following_url":"https://api.github.com/users/dvuckovic/following{/other_user}","gists_url":"https://api.github.com/users/dvuckovic/gists{/gist_id}","starred_url":"https://api.github.com/users/dvuckovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvuckovic/subscriptions","organizations_url":"https://api.github.com/users/dvuckovic/orgs","repos_url":"https://api.github.com/users/dvuckovic/repos","events_url":"https://api.github.com/users/dvuckovic/events{/privacy}","received_events_url":"https://api.github.com/users/dvuckovic/received_events","type":"User","site_admin":false},"created_at":"2016-09-07T14:45:59Z","updated_at":"2016-09-07T14:45:59Z","body":"Merged in c170675, although with some changes.\r\n\r\n@pboguslawski Please consider using Template Toolkit directives instead of new blocks, they are very efficient in offloading processing from the module code.\r\n\r\nMany thanks for your contribution!"}}
{"actor":{"display_login":"dvuckovic"}}