{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/wcf/pulls/comments/71626389","id":71626389,"diff_hunk":"@@ -111,13 +124,91 @@ public static void Https_SecModeTrans_ClientCredTypeNone_ServerCertValModePeerOr\n         string testString = \"Hello\";\n         ChannelFactory<IWcfService> factory = null;\n         IWcfService serviceProxy = null;\n+        CommunicationException communicationException = null;\n \n         try\n         {\n             // *** SETUP *** \\\\\n             BasicHttpsBinding binding = new BasicHttpsBinding(BasicHttpsSecurityMode.Transport);\n             binding.Security.Transport.ClientCredentialType = HttpClientCredentialType.None;\n-            endpointAddress = new EndpointAddress(new Uri(Endpoints.Https_SecModeTrans_ClientCredTypeNone_ServerCertValModePeerTrust_Address));\n+            endpointAddress = new EndpointAddress(new Uri(\n+                                Endpoints.Https_SecModeTrans_ClientCredTypeNone_ServerCertValModePeerOrChainTrust_Address));","path":"src/System.Private.ServiceModel/tests/Scenarios/Security/TransportSecurity/Https/HttpsTests.cs","position":78,"original_position":78,"commit_id":"e4bde262c9b383aaac58b28b32d79bd7ccb8a3ac","original_commit_id":"e4bde262c9b383aaac58b28b32d79bd7ccb8a3ac","user":{"login":"iamjasonp","id":1616847,"avatar_url":"https://avatars.githubusercontent.com/u/1616847?v=3","gravatar_id":"","url":"https://api.github.com/users/iamjasonp","html_url":"https://github.com/iamjasonp","followers_url":"https://api.github.com/users/iamjasonp/followers","following_url":"https://api.github.com/users/iamjasonp/following{/other_user}","gists_url":"https://api.github.com/users/iamjasonp/gists{/gist_id}","starred_url":"https://api.github.com/users/iamjasonp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamjasonp/subscriptions","organizations_url":"https://api.github.com/users/iamjasonp/orgs","repos_url":"https://api.github.com/users/iamjasonp/repos","events_url":"https://api.github.com/users/iamjasonp/events{/privacy}","received_events_url":"https://api.github.com/users/iamjasonp/received_events","type":"User","site_admin":false},"body":"Is this endpoint correct? \r\nThe test is named Https_SecModeTrans_CertValMode_PeerTrust_Fails_Not_In_TrustedPeople\r\nbut you're using a cert that is capable of doing PeerOrChainTrust? ","created_at":"2016-07-20T23:41:49Z","updated_at":"2016-07-20T23:41:49Z","html_url":"https://github.com/dotnet/wcf/pull/1382#discussion_r71626389","pull_request_url":"https://api.github.com/repos/dotnet/wcf/pulls/1382","_links":{"self":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/comments/71626389"},"html":{"href":"https://github.com/dotnet/wcf/pull/1382#discussion_r71626389"},"pull_request":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/1382"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/wcf/pulls/1382","id":77976457,"html_url":"https://github.com/dotnet/wcf/pull/1382","diff_url":"https://github.com/dotnet/wcf/pull/1382.diff","patch_url":"https://github.com/dotnet/wcf/pull/1382.patch","issue_url":"https://api.github.com/repos/dotnet/wcf/issues/1382","number":1382,"state":"open","locked":false,"title":"Improve PeerTrust scenario tests","user":{"login":"roncain","id":3913124,"avatar_url":"https://avatars.githubusercontent.com/u/3913124?v=3","gravatar_id":"","url":"https://api.github.com/users/roncain","html_url":"https://github.com/roncain","followers_url":"https://api.github.com/users/roncain/followers","following_url":"https://api.github.com/users/roncain/following{/other_user}","gists_url":"https://api.github.com/users/roncain/gists{/gist_id}","starred_url":"https://api.github.com/users/roncain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roncain/subscriptions","organizations_url":"https://api.github.com/users/roncain/orgs","repos_url":"https://api.github.com/users/roncain/repos","events_url":"https://api.github.com/users/roncain/events{/privacy}","received_events_url":"https://api.github.com/users/roncain/received_events","type":"User","site_admin":false},"body":"This adds a new certificate that can be used for PeerTrust,\r\nnew test endpoints that use it, and new scenario tests that\r\ntest PeerTrust, PeerOrChainTrust and ChainTrust.","created_at":"2016-07-19T13:33:38Z","updated_at":"2016-07-20T23:41:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42275accf5a5cb2cb1b6584f1d74139d29b83c9a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/wcf/pulls/1382/commits","review_comments_url":"https://api.github.com/repos/dotnet/wcf/pulls/1382/comments","review_comment_url":"https://api.github.com/repos/dotnet/wcf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/wcf/issues/1382/comments","statuses_url":"https://api.github.com/repos/dotnet/wcf/statuses/e4bde262c9b383aaac58b28b32d79bd7ccb8a3ac","head":{"label":"roncain:improve-peertrust","ref":"improve-peertrust","sha":"e4bde262c9b383aaac58b28b32d79bd7ccb8a3ac","user":{"login":"roncain","id":3913124,"avatar_url":"https://avatars.githubusercontent.com/u/3913124?v=3","gravatar_id":"","url":"https://api.github.com/users/roncain","html_url":"https://github.com/roncain","followers_url":"https://api.github.com/users/roncain/followers","following_url":"https://api.github.com/users/roncain/following{/other_user}","gists_url":"https://api.github.com/users/roncain/gists{/gist_id}","starred_url":"https://api.github.com/users/roncain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roncain/subscriptions","organizations_url":"https://api.github.com/users/roncain/orgs","repos_url":"https://api.github.com/users/roncain/repos","events_url":"https://api.github.com/users/roncain/events{/privacy}","received_events_url":"https://api.github.com/users/roncain/received_events","type":"User","site_admin":false},"repo":{"id":39504510,"name":"wcf","full_name":"roncain/wcf","owner":{"login":"roncain","id":3913124,"avatar_url":"https://avatars.githubusercontent.com/u/3913124?v=3","gravatar_id":"","url":"https://api.github.com/users/roncain","html_url":"https://github.com/roncain","followers_url":"https://api.github.com/users/roncain/followers","following_url":"https://api.github.com/users/roncain/following{/other_user}","gists_url":"https://api.github.com/users/roncain/gists{/gist_id}","starred_url":"https://api.github.com/users/roncain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roncain/subscriptions","organizations_url":"https://api.github.com/users/roncain/orgs","repos_url":"https://api.github.com/users/roncain/repos","events_url":"https://api.github.com/users/roncain/events{/privacy}","received_events_url":"https://api.github.com/users/roncain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roncain/wcf","description":"This repo contains the client-oriented WCF libraries that enable applications built on .NET Core to communicate with WCF services.","fork":true,"url":"https://api.github.com/repos/roncain/wcf","forks_url":"https://api.github.com/repos/roncain/wcf/forks","keys_url":"https://api.github.com/repos/roncain/wcf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roncain/wcf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roncain/wcf/teams","hooks_url":"https://api.github.com/repos/roncain/wcf/hooks","issue_events_url":"https://api.github.com/repos/roncain/wcf/issues/events{/number}","events_url":"https://api.github.com/repos/roncain/wcf/events","assignees_url":"https://api.github.com/repos/roncain/wcf/assignees{/user}","branches_url":"https://api.github.com/repos/roncain/wcf/branches{/branch}","tags_url":"https://api.github.com/repos/roncain/wcf/tags","blobs_url":"https://api.github.com/repos/roncain/wcf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roncain/wcf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roncain/wcf/git/refs{/sha}","trees_url":"https://api.github.com/repos/roncain/wcf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roncain/wcf/statuses/{sha}","languages_url":"https://api.github.com/repos/roncain/wcf/languages","stargazers_url":"https://api.github.com/repos/roncain/wcf/stargazers","contributors_url":"https://api.github.com/repos/roncain/wcf/contributors","subscribers_url":"https://api.github.com/repos/roncain/wcf/subscribers","subscription_url":"https://api.github.com/repos/roncain/wcf/subscription","commits_url":"https://api.github.com/repos/roncain/wcf/commits{/sha}","git_commits_url":"https://api.github.com/repos/roncain/wcf/git/commits{/sha}","comments_url":"https://api.github.com/repos/roncain/wcf/comments{/number}","issue_comment_url":"https://api.github.com/repos/roncain/wcf/issues/comments{/number}","contents_url":"https://api.github.com/repos/roncain/wcf/contents/{+path}","compare_url":"https://api.github.com/repos/roncain/wcf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roncain/wcf/merges","archive_url":"https://api.github.com/repos/roncain/wcf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roncain/wcf/downloads","issues_url":"https://api.github.com/repos/roncain/wcf/issues{/number}","pulls_url":"https://api.github.com/repos/roncain/wcf/pulls{/number}","milestones_url":"https://api.github.com/repos/roncain/wcf/milestones{/number}","notifications_url":"https://api.github.com/repos/roncain/wcf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roncain/wcf/labels{/name}","releases_url":"https://api.github.com/repos/roncain/wcf/releases{/id}","deployments_url":"https://api.github.com/repos/roncain/wcf/deployments","created_at":"2015-07-22T12:21:54Z","updated_at":"2016-01-12T17:24:47Z","pushed_at":"2016-07-20T13:01:44Z","git_url":"git://github.com/roncain/wcf.git","ssh_url":"git@github.com:roncain/wcf.git","clone_url":"https://github.com/roncain/wcf.git","svn_url":"https://github.com/roncain/wcf","homepage":"","size":6404,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"9f5be203ad4755af9e5c89e3e8689282e1c5bafd","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":35562993,"name":"wcf","full_name":"dotnet/wcf","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/wcf","description":"This repo contains the client-oriented WCF libraries that enable applications built on .NET Core to communicate with WCF services.","fork":false,"url":"https://api.github.com/repos/dotnet/wcf","forks_url":"https://api.github.com/repos/dotnet/wcf/forks","keys_url":"https://api.github.com/repos/dotnet/wcf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/wcf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/wcf/teams","hooks_url":"https://api.github.com/repos/dotnet/wcf/hooks","issue_events_url":"https://api.github.com/repos/dotnet/wcf/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/wcf/events","assignees_url":"https://api.github.com/repos/dotnet/wcf/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/wcf/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/wcf/tags","blobs_url":"https://api.github.com/repos/dotnet/wcf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/wcf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/wcf/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/wcf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/wcf/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/wcf/languages","stargazers_url":"https://api.github.com/repos/dotnet/wcf/stargazers","contributors_url":"https://api.github.com/repos/dotnet/wcf/contributors","subscribers_url":"https://api.github.com/repos/dotnet/wcf/subscribers","subscription_url":"https://api.github.com/repos/dotnet/wcf/subscription","commits_url":"https://api.github.com/repos/dotnet/wcf/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/wcf/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/wcf/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/wcf/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/wcf/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/wcf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/wcf/merges","archive_url":"https://api.github.com/repos/dotnet/wcf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/wcf/downloads","issues_url":"https://api.github.com/repos/dotnet/wcf/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/wcf/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/wcf/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/wcf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/wcf/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/wcf/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/wcf/deployments","created_at":"2015-05-13T17:17:03Z","updated_at":"2016-07-18T23:25:51Z","pushed_at":"2016-07-20T20:13:55Z","git_url":"git://github.com/dotnet/wcf.git","ssh_url":"git@github.com:dotnet/wcf.git","clone_url":"https://github.com/dotnet/wcf.git","svn_url":"https://github.com/dotnet/wcf","homepage":"","size":7943,"stargazers_count":665,"watchers_count":665,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":229,"mirror_url":null,"open_issues_count":157,"forks":229,"open_issues":157,"watchers":665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/1382"},"html":{"href":"https://github.com/dotnet/wcf/pull/1382"},"issue":{"href":"https://api.github.com/repos/dotnet/wcf/issues/1382"},"comments":{"href":"https://api.github.com/repos/dotnet/wcf/issues/1382/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/1382/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/wcf/pulls/1382/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/wcf/statuses/e4bde262c9b383aaac58b28b32d79bd7ccb8a3ac"}}}}
{"actor":{"display_login":"iamjasonp"}}