{"action":"created","issue":{"url":"https://api.github.com/repos/bcgov/rcaaqs/issues/13","repository_url":"https://api.github.com/repos/bcgov/rcaaqs","labels_url":"https://api.github.com/repos/bcgov/rcaaqs/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/bcgov/rcaaqs/issues/13/comments","events_url":"https://api.github.com/repos/bcgov/rcaaqs/issues/13/events","html_url":"https://github.com/bcgov/rcaaqs/issues/13","id":187138315,"number":13,"title":"Enhance pm_data_complete to deal with exception","user":{"login":"ateucher","id":2816635,"avatar_url":"https://avatars.githubusercontent.com/u/2816635?v=3","gravatar_id":"","url":"https://api.github.com/users/ateucher","html_url":"https://github.com/ateucher","followers_url":"https://api.github.com/users/ateucher/followers","following_url":"https://api.github.com/users/ateucher/following{/other_user}","gists_url":"https://api.github.com/users/ateucher/gists{/gist_id}","starred_url":"https://api.github.com/users/ateucher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ateucher/subscriptions","organizations_url":"https://api.github.com/users/ateucher/orgs","repos_url":"https://api.github.com/users/ateucher/repos","events_url":"https://api.github.com/users/ateucher/events{/privacy}","received_events_url":"https://api.github.com/users/ateucher/received_events","type":"User","site_admin":false},"labels":[{"id":250300940,"url":"https://api.github.com/repos/bcgov/rcaaqs/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-03T17:32:27Z","updated_at":"2016-11-17T18:38:39Z","closed_at":null,"body":"Functionality for PM<sub>2.5</sub> CAAQS calculation has been implemented, including evaluating data completeness criteria. However, `pm_data_complete` currently does not deal with the exception to the data completeness criteria as outlined in the [Guidance Document](http://www.ccme.ca/files/Resources/air/aqms/pn_1483_gdad_eng.pdf) (pages 11). It should be enhanced to do so."},"comment":{"url":"https://api.github.com/repos/bcgov/rcaaqs/issues/comments/261330705","html_url":"https://github.com/bcgov/rcaaqs/issues/13#issuecomment-261330705","issue_url":"https://api.github.com/repos/bcgov/rcaaqs/issues/13","id":261330705,"user":{"login":"stephhazlitt","id":7143861,"avatar_url":"https://avatars.githubusercontent.com/u/7143861?v=3","gravatar_id":"","url":"https://api.github.com/users/stephhazlitt","html_url":"https://github.com/stephhazlitt","followers_url":"https://api.github.com/users/stephhazlitt/followers","following_url":"https://api.github.com/users/stephhazlitt/following{/other_user}","gists_url":"https://api.github.com/users/stephhazlitt/gists{/gist_id}","starred_url":"https://api.github.com/users/stephhazlitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephhazlitt/subscriptions","organizations_url":"https://api.github.com/users/stephhazlitt/orgs","repos_url":"https://api.github.com/users/stephhazlitt/repos","events_url":"https://api.github.com/users/stephhazlitt/events{/privacy}","received_events_url":"https://api.github.com/users/stephhazlitt/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T18:38:39Z","updated_at":"2016-11-17T18:38:39Z","body":"The [`rcaaqs` README](https://github.com/bcgov/rcaaqs) demonstrates the `pm_data_complete` function and highlights the step where, at this time, the exception is captured. This issue should incorporate this step into the `pm_data_complete` function.\r\n\r\n`## Then join the results to the data completeness data frame and select \r\n## only the results that are valid. This process could be more efficent\r\nann_98_per <- left_join(ann_98_per, pm_completeness, \r\n                        by = c(\"ems_id\", \"year\"))\r\nann_98_per <- filter(ann_98_per, use_annual | (exceed & annual_valid))\r\nglimpse(ann_98_per)\r\n#> Observations: 23\r\n#> Variables: 15\r\n#> $ ems_id               <chr> \"0220205\", \"0310162\", \"0310162\", \"0310162...\r\n#> $ year                 <int> 2012, 2011, 2012, 2013, 2011, 2012, 2013,...`\r\n\r\n"}}
{"actor":{"display_login":"stephhazlitt"}}