{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/87212320","pull_request_review_id":7832708,"id":87212320,"diff_hunk":"@@ -1,19 +1,26 @@\n module ManageIQ::Providers::Kubernetes::ContainerManager::MetricsCapture::HawkularClientMixin\n   def hawkular_client\n     require 'hawkular/hawkular_client'\n-    @client ||= Hawkular::Metrics::Client.new(\n-      hawkular_entrypoint, hawkular_credentials, hawkular_options)\n+    @client ||= Hawkular::Metrics::Client.new(hawkular_entrypoint, hawkular_credentials, hawkular_options)","path":"app/models/manageiq/providers/kubernetes/container_manager/metrics_capture/hawkular_client_mixin.rb","position":6,"original_position":6,"commit_id":"e1152e917d314c9d6aef7668e7ec682128db26e2","original_commit_id":"e1152e917d314c9d6aef7668e7ec682128db26e2","user":{"login":"enoodle","id":3123328,"avatar_url":"https://avatars.githubusercontent.com/u/3123328?v=3","gravatar_id":"","url":"https://api.github.com/users/enoodle","html_url":"https://github.com/enoodle","followers_url":"https://api.github.com/users/enoodle/followers","following_url":"https://api.github.com/users/enoodle/following{/other_user}","gists_url":"https://api.github.com/users/enoodle/gists{/gist_id}","starred_url":"https://api.github.com/users/enoodle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enoodle/subscriptions","organizations_url":"https://api.github.com/users/enoodle/orgs","repos_url":"https://api.github.com/users/enoodle/repos","events_url":"https://api.github.com/users/enoodle/events{/privacy}","received_events_url":"https://api.github.com/users/enoodle/received_events","type":"User","site_admin":false},"body":"Is there any change here or just joining of the lines?","created_at":"2016-11-09T15:23:19Z","updated_at":"2016-11-09T15:23:20Z","html_url":"https://github.com/ManageIQ/manageiq/pull/12530#discussion_r87212320","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12530","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/87212320"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/12530#discussion_r87212320"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12530"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12530","id":92982124,"html_url":"https://github.com/ManageIQ/manageiq/pull/12530","diff_url":"https://github.com/ManageIQ/manageiq/pull/12530.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/12530.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/12530","number":12530,"state":"open","locked":false,"title":"Automatic detection of hawkular endpoint","user":{"login":"nimrodshn","id":8366181,"avatar_url":"https://avatars.githubusercontent.com/u/8366181?v=3","gravatar_id":"","url":"https://api.github.com/users/nimrodshn","html_url":"https://github.com/nimrodshn","followers_url":"https://api.github.com/users/nimrodshn/followers","following_url":"https://api.github.com/users/nimrodshn/following{/other_user}","gists_url":"https://api.github.com/users/nimrodshn/gists{/gist_id}","starred_url":"https://api.github.com/users/nimrodshn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimrodshn/subscriptions","organizations_url":"https://api.github.com/users/nimrodshn/orgs","repos_url":"https://api.github.com/users/nimrodshn/repos","events_url":"https://api.github.com/users/nimrodshn/events{/privacy}","received_events_url":"https://api.github.com/users/nimrodshn/received_events","type":"User","site_admin":false},"body":"Added automatic detection of Hawkular hostname from route when endpoint is not specified.\r\n\r\nWhen the user does not specify the Hawkular client hostname upon adding a new container provider (i.e. Hawkular endpoint is left blank) we had taken it from the hostname - this behavior is changed in this PR - now we are taking the hostname from the Route. \r\n\r\ncc: @yaacov @enoodle @simon3z ","created_at":"2016-11-09T15:21:56Z","updated_at":"2016-11-09T15:28:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"246beb4d4f30a1c23b7fa35d07adc066eb32398e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12530/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12530/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/12530/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/e1152e917d314c9d6aef7668e7ec682128db26e2","head":{"label":"nimrodshn:automatic_detection_of_hawkular_endpoint","ref":"automatic_detection_of_hawkular_endpoint","sha":"e1152e917d314c9d6aef7668e7ec682128db26e2","user":{"login":"nimrodshn","id":8366181,"avatar_url":"https://avatars.githubusercontent.com/u/8366181?v=3","gravatar_id":"","url":"https://api.github.com/users/nimrodshn","html_url":"https://github.com/nimrodshn","followers_url":"https://api.github.com/users/nimrodshn/followers","following_url":"https://api.github.com/users/nimrodshn/following{/other_user}","gists_url":"https://api.github.com/users/nimrodshn/gists{/gist_id}","starred_url":"https://api.github.com/users/nimrodshn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimrodshn/subscriptions","organizations_url":"https://api.github.com/users/nimrodshn/orgs","repos_url":"https://api.github.com/users/nimrodshn/repos","events_url":"https://api.github.com/users/nimrodshn/events{/privacy}","received_events_url":"https://api.github.com/users/nimrodshn/received_events","type":"User","site_admin":false},"repo":{"id":67916156,"name":"manageiq","full_name":"nimrodshn/manageiq","owner":{"login":"nimrodshn","id":8366181,"avatar_url":"https://avatars.githubusercontent.com/u/8366181?v=3","gravatar_id":"","url":"https://api.github.com/users/nimrodshn","html_url":"https://github.com/nimrodshn","followers_url":"https://api.github.com/users/nimrodshn/followers","following_url":"https://api.github.com/users/nimrodshn/following{/other_user}","gists_url":"https://api.github.com/users/nimrodshn/gists{/gist_id}","starred_url":"https://api.github.com/users/nimrodshn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimrodshn/subscriptions","organizations_url":"https://api.github.com/users/nimrodshn/orgs","repos_url":"https://api.github.com/users/nimrodshn/repos","events_url":"https://api.github.com/users/nimrodshn/events{/privacy}","received_events_url":"https://api.github.com/users/nimrodshn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nimrodshn/manageiq","description":"ManageIQ Open-Source Management Platform","fork":true,"url":"https://api.github.com/repos/nimrodshn/manageiq","forks_url":"https://api.github.com/repos/nimrodshn/manageiq/forks","keys_url":"https://api.github.com/repos/nimrodshn/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nimrodshn/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nimrodshn/manageiq/teams","hooks_url":"https://api.github.com/repos/nimrodshn/manageiq/hooks","issue_events_url":"https://api.github.com/repos/nimrodshn/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/nimrodshn/manageiq/events","assignees_url":"https://api.github.com/repos/nimrodshn/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/nimrodshn/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/nimrodshn/manageiq/tags","blobs_url":"https://api.github.com/repos/nimrodshn/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nimrodshn/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nimrodshn/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/nimrodshn/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nimrodshn/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/nimrodshn/manageiq/languages","stargazers_url":"https://api.github.com/repos/nimrodshn/manageiq/stargazers","contributors_url":"https://api.github.com/repos/nimrodshn/manageiq/contributors","subscribers_url":"https://api.github.com/repos/nimrodshn/manageiq/subscribers","subscription_url":"https://api.github.com/repos/nimrodshn/manageiq/subscription","commits_url":"https://api.github.com/repos/nimrodshn/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/nimrodshn/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/nimrodshn/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/nimrodshn/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/nimrodshn/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/nimrodshn/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nimrodshn/manageiq/merges","archive_url":"https://api.github.com/repos/nimrodshn/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nimrodshn/manageiq/downloads","issues_url":"https://api.github.com/repos/nimrodshn/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/nimrodshn/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/nimrodshn/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/nimrodshn/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nimrodshn/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/nimrodshn/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/nimrodshn/manageiq/deployments","created_at":"2016-09-11T07:21:02Z","updated_at":"2016-09-11T07:21:24Z","pushed_at":"2016-11-09T15:13:45Z","git_url":"git://github.com/nimrodshn/manageiq.git","ssh_url":"git@github.com:nimrodshn/manageiq.git","clone_url":"https://github.com/nimrodshn/manageiq.git","svn_url":"https://github.com/nimrodshn/manageiq","homepage":"manageiq.org","size":158869,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"95ff8250379b14ba1087b00ad5eecb5e67d34e1a","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-11-09T10:50:21Z","pushed_at":"2016-11-09T15:21:56Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":219490,"stargazers_count":348,"watchers_count":348,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":377,"mirror_url":null,"open_issues_count":893,"forks":377,"open_issues":893,"watchers":348,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12530"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/12530"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/12530"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/12530/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12530/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12530/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/e1152e917d314c9d6aef7668e7ec682128db26e2"}}}}
{"actor":{"display_login":"enoodle"}}