{"action":"opened","number":16969,"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16969","id":66593356,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/16969","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/16969.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/16969.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/16969","number":16969,"state":"open","locked":false,"title":"Core/Movement: enable item use and spell cast when dismounting","user":{"login":"tkrokli","id":4903600,"avatar_url":"https://avatars.githubusercontent.com/u/4903600?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrokli","html_url":"https://github.com/tkrokli","followers_url":"https://api.github.com/users/tkrokli/followers","following_url":"https://api.github.com/users/tkrokli/following{/other_user}","gists_url":"https://api.github.com/users/tkrokli/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrokli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrokli/subscriptions","organizations_url":"https://api.github.com/users/tkrokli/orgs","repos_url":"https://api.github.com/users/tkrokli/repos","events_url":"https://api.github.com/users/tkrokli/events{/privacy}","received_events_url":"https://api.github.com/users/tkrokli/received_events","type":"User","site_admin":false},"body":"**Changes proposed**:\r\n\r\nRemove error message and allow spell cast or item use from mounted state on ground, specifically when sitting on a landed flying mount. Current behavior is that the player will get the error message \"You can't do that while moving\" when trying to cast a spell or pick up an item while sitting on a flying mount after having landed.\r\n\r\nBy joschiwald, closes #6236\r\n\r\n- allow spell cast or item use from sitting on landed flying mount\r\n- avoid error message from dismount movement check\r\n- woks more than 90% better than current behaviour\r\n\r\n**Target branch(es)**: 335/6x\r\n\r\n**Issues addressed**: Fixes #6236 [**Dismount - You can't do this while moving**](https://github.com/TrinityCore/TrinityCore/issues/6236)\r\n\r\n**Tests performed**: (Does it build, tested in-game, etc)\r\n- compiles without errors\r\n- no current known errors in-game\r\n\r\n**Known issues and TODO list**:\r\n\r\n- [ ] might need extra testing by multiple online users to discover unknown issues\r\n- [ ] extended feedback from the TC collaborators","created_at":"2016-04-15T05:52:48Z","updated_at":"2016-04-15T05:52:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d010a049124d876b791f9c5b49e252a1be2c489","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16969/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16969/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/16969/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/bbb7a0b118dccc1cec3cdc5d1d7df5bd4bf64841","head":{"label":"tkrokli:cant_do_this_while_moving","ref":"cant_do_this_while_moving","sha":"bbb7a0b118dccc1cec3cdc5d1d7df5bd4bf64841","user":{"login":"tkrokli","id":4903600,"avatar_url":"https://avatars.githubusercontent.com/u/4903600?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrokli","html_url":"https://github.com/tkrokli","followers_url":"https://api.github.com/users/tkrokli/followers","following_url":"https://api.github.com/users/tkrokli/following{/other_user}","gists_url":"https://api.github.com/users/tkrokli/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrokli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrokli/subscriptions","organizations_url":"https://api.github.com/users/tkrokli/orgs","repos_url":"https://api.github.com/users/tkrokli/repos","events_url":"https://api.github.com/users/tkrokli/events{/privacy}","received_events_url":"https://api.github.com/users/tkrokli/received_events","type":"User","site_admin":false},"repo":{"id":33367544,"name":"TrinityCore","full_name":"tkrokli/TrinityCore","owner":{"login":"tkrokli","id":4903600,"avatar_url":"https://avatars.githubusercontent.com/u/4903600?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrokli","html_url":"https://github.com/tkrokli","followers_url":"https://api.github.com/users/tkrokli/followers","following_url":"https://api.github.com/users/tkrokli/following{/other_user}","gists_url":"https://api.github.com/users/tkrokli/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrokli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrokli/subscriptions","organizations_url":"https://api.github.com/users/tkrokli/orgs","repos_url":"https://api.github.com/users/tkrokli/repos","events_url":"https://api.github.com/users/tkrokli/events{/privacy}","received_events_url":"https://api.github.com/users/tkrokli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tkrokli/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/tkrokli/TrinityCore","forks_url":"https://api.github.com/repos/tkrokli/TrinityCore/forks","keys_url":"https://api.github.com/repos/tkrokli/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tkrokli/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tkrokli/TrinityCore/teams","hooks_url":"https://api.github.com/repos/tkrokli/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/tkrokli/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/tkrokli/TrinityCore/events","assignees_url":"https://api.github.com/repos/tkrokli/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/tkrokli/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/tkrokli/TrinityCore/tags","blobs_url":"https://api.github.com/repos/tkrokli/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tkrokli/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tkrokli/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/tkrokli/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tkrokli/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/tkrokli/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/tkrokli/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/tkrokli/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/tkrokli/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/tkrokli/TrinityCore/subscription","commits_url":"https://api.github.com/repos/tkrokli/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/tkrokli/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/tkrokli/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/tkrokli/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/tkrokli/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/tkrokli/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tkrokli/TrinityCore/merges","archive_url":"https://api.github.com/repos/tkrokli/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tkrokli/TrinityCore/downloads","issues_url":"https://api.github.com/repos/tkrokli/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/tkrokli/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/tkrokli/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/tkrokli/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tkrokli/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/tkrokli/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/tkrokli/TrinityCore/deployments","created_at":"2015-04-03T14:46:13Z","updated_at":"2016-02-11T15:10:24Z","pushed_at":"2016-04-15T05:25:39Z","git_url":"git://github.com/tkrokli/TrinityCore.git","ssh_url":"git@github.com:tkrokli/TrinityCore.git","clone_url":"https://github.com/tkrokli/TrinityCore.git","svn_url":"https://github.com/tkrokli/TrinityCore","homepage":"http://www.trinitycore.org","size":376996,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":7,"default_branch":"3.3.5"}},"base":{"label":"TrinityCore:3.3.5","ref":"3.3.5","sha":"e38e1c0c549c6b53993972f0d94a584cb3c46eeb","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/deployments","created_at":"2010-12-28T23:40:07Z","updated_at":"2016-04-15T05:05:54Z","pushed_at":"2016-04-15T05:52:49Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":771035,"stargazers_count":3292,"watchers_count":3292,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3363,"mirror_url":null,"open_issues_count":1410,"forks":3363,"open_issues":1410,"watchers":3292,"default_branch":"6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16969"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/16969"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/16969"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/16969/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16969/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/16969/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/bbb7a0b118dccc1cec3cdc5d1d7df5bd4bf64841"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":12,"deletions":27,"changed_files":3}}