{"action":"created","comment":{"url":"https://api.github.com/repos/google/mobly/pulls/comments/93572410","pull_request_review_id":14102270,"id":93572410,"diff_hunk":"@@ -712,14 +712,11 @@ def _terminate_sl4a(self):\n         the session. Clear corresponding droids and dispatchers from cache.\n         \"\"\"\n         if self.sl4a:\n-            self.sl4a.closeSl4aSession()\n-            self.sl4a.close()\n+            self._terminate_jsonrpc_client(self.sl4a)","path":"mobly/controllers/android_device.py","position":6,"original_position":6,"commit_id":"070f76aec42a6f083fce971114421725217242f0","original_commit_id":"070f76aec42a6f083fce971114421725217242f0","user":{"login":"adorokhine","id":2999402,"avatar_url":"https://avatars.githubusercontent.com/u/2999402?v=3","gravatar_id":"","url":"https://api.github.com/users/adorokhine","html_url":"https://github.com/adorokhine","followers_url":"https://api.github.com/users/adorokhine/followers","following_url":"https://api.github.com/users/adorokhine/following{/other_user}","gists_url":"https://api.github.com/users/adorokhine/gists{/gist_id}","starred_url":"https://api.github.com/users/adorokhine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adorokhine/subscriptions","organizations_url":"https://api.github.com/users/adorokhine/orgs","repos_url":"https://api.github.com/users/adorokhine/repos","events_url":"https://api.github.com/users/adorokhine/events{/privacy}","received_events_url":"https://api.github.com/users/adorokhine/received_events","type":"User","site_admin":false},"body":"Doesn't work because terminate_jsonrpc_client calls stop_app to kill the apk.\r\nThis is why I originally had self.ed clean up first but you yelled at me. :)","created_at":"2016-12-22T06:38:12Z","updated_at":"2016-12-22T06:38:17Z","html_url":"https://github.com/google/mobly/pull/49#discussion_r93572410","pull_request_url":"https://api.github.com/repos/google/mobly/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/google/mobly/pulls/comments/93572410"},"html":{"href":"https://github.com/google/mobly/pull/49#discussion_r93572410"},"pull_request":{"href":"https://api.github.com/repos/google/mobly/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/google/mobly/pulls/49","id":98879347,"html_url":"https://github.com/google/mobly/pull/49","diff_url":"https://github.com/google/mobly/pull/49.diff","patch_url":"https://github.com/google/mobly/pull/49.patch","issue_url":"https://api.github.com/repos/google/mobly/issues/49","number":49,"state":"open","locked":false,"title":"Remove the extra attempt to teardown sl4a in AndroidDevice","user":{"login":"xpconanfan","id":2242277,"avatar_url":"https://avatars.githubusercontent.com/u/2242277?v=3","gravatar_id":"","url":"https://api.github.com/users/xpconanfan","html_url":"https://github.com/xpconanfan","followers_url":"https://api.github.com/users/xpconanfan/followers","following_url":"https://api.github.com/users/xpconanfan/following{/other_user}","gists_url":"https://api.github.com/users/xpconanfan/gists{/gist_id}","starred_url":"https://api.github.com/users/xpconanfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xpconanfan/subscriptions","organizations_url":"https://api.github.com/users/xpconanfan/orgs","repos_url":"https://api.github.com/users/xpconanfan/repos","events_url":"https://api.github.com/users/xpconanfan/events{/privacy}","received_events_url":"https://api.github.com/users/xpconanfan/received_events","type":"User","site_admin":false},"body":"fixes #48 ","created_at":"2016-12-21T06:31:06Z","updated_at":"2016-12-22T06:38:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd6f099fe16797f59bb934b0daf9a8e2440bd173","assignee":{"login":"xpconanfan","id":2242277,"avatar_url":"https://avatars.githubusercontent.com/u/2242277?v=3","gravatar_id":"","url":"https://api.github.com/users/xpconanfan","html_url":"https://github.com/xpconanfan","followers_url":"https://api.github.com/users/xpconanfan/followers","following_url":"https://api.github.com/users/xpconanfan/following{/other_user}","gists_url":"https://api.github.com/users/xpconanfan/gists{/gist_id}","starred_url":"https://api.github.com/users/xpconanfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xpconanfan/subscriptions","organizations_url":"https://api.github.com/users/xpconanfan/orgs","repos_url":"https://api.github.com/users/xpconanfan/repos","events_url":"https://api.github.com/users/xpconanfan/events{/privacy}","received_events_url":"https://api.github.com/users/xpconanfan/received_events","type":"User","site_admin":false},"assignees":[{"login":"xpconanfan","id":2242277,"avatar_url":"https://avatars.githubusercontent.com/u/2242277?v=3","gravatar_id":"","url":"https://api.github.com/users/xpconanfan","html_url":"https://github.com/xpconanfan","followers_url":"https://api.github.com/users/xpconanfan/followers","following_url":"https://api.github.com/users/xpconanfan/following{/other_user}","gists_url":"https://api.github.com/users/xpconanfan/gists{/gist_id}","starred_url":"https://api.github.com/users/xpconanfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xpconanfan/subscriptions","organizations_url":"https://api.github.com/users/xpconanfan/orgs","repos_url":"https://api.github.com/users/xpconanfan/repos","events_url":"https://api.github.com/users/xpconanfan/events{/privacy}","received_events_url":"https://api.github.com/users/xpconanfan/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/google/mobly/milestones/1","html_url":"https://github.com/google/mobly/milestone/1","labels_url":"https://api.github.com/repos/google/mobly/milestones/1/labels","id":2208892,"number":1,"title":"Mobly Release 1.1","description":"New features:\r\n* Snippet lib support\r\n* Attenuator lib\r\n* Customizable log prefix tag in AndroidDevice","creator":{"login":"xpconanfan","id":2242277,"avatar_url":"https://avatars.githubusercontent.com/u/2242277?v=3","gravatar_id":"","url":"https://api.github.com/users/xpconanfan","html_url":"https://github.com/xpconanfan","followers_url":"https://api.github.com/users/xpconanfan/followers","following_url":"https://api.github.com/users/xpconanfan/following{/other_user}","gists_url":"https://api.github.com/users/xpconanfan/gists{/gist_id}","starred_url":"https://api.github.com/users/xpconanfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xpconanfan/subscriptions","organizations_url":"https://api.github.com/users/xpconanfan/orgs","repos_url":"https://api.github.com/users/xpconanfan/repos","events_url":"https://api.github.com/users/xpconanfan/events{/privacy}","received_events_url":"https://api.github.com/users/xpconanfan/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":3,"state":"open","created_at":"2016-12-21T02:32:56Z","updated_at":"2016-12-22T05:56:46Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/google/mobly/pulls/49/commits","review_comments_url":"https://api.github.com/repos/google/mobly/pulls/49/comments","review_comment_url":"https://api.github.com/repos/google/mobly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/mobly/issues/49/comments","statuses_url":"https://api.github.com/repos/google/mobly/statuses/070f76aec42a6f083fce971114421725217242f0","head":{"label":"google:sl4a-shell","ref":"sl4a-shell","sha":"070f76aec42a6f083fce971114421725217242f0","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":73104945,"name":"mobly","full_name":"google/mobly","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/mobly","description":"Mobly - Test framework for integration tests with complex test bed setup","fork":false,"url":"https://api.github.com/repos/google/mobly","forks_url":"https://api.github.com/repos/google/mobly/forks","keys_url":"https://api.github.com/repos/google/mobly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/mobly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/mobly/teams","hooks_url":"https://api.github.com/repos/google/mobly/hooks","issue_events_url":"https://api.github.com/repos/google/mobly/issues/events{/number}","events_url":"https://api.github.com/repos/google/mobly/events","assignees_url":"https://api.github.com/repos/google/mobly/assignees{/user}","branches_url":"https://api.github.com/repos/google/mobly/branches{/branch}","tags_url":"https://api.github.com/repos/google/mobly/tags","blobs_url":"https://api.github.com/repos/google/mobly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/mobly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/mobly/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/mobly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/mobly/statuses/{sha}","languages_url":"https://api.github.com/repos/google/mobly/languages","stargazers_url":"https://api.github.com/repos/google/mobly/stargazers","contributors_url":"https://api.github.com/repos/google/mobly/contributors","subscribers_url":"https://api.github.com/repos/google/mobly/subscribers","subscription_url":"https://api.github.com/repos/google/mobly/subscription","commits_url":"https://api.github.com/repos/google/mobly/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/mobly/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/mobly/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/mobly/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/mobly/contents/{+path}","compare_url":"https://api.github.com/repos/google/mobly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/mobly/merges","archive_url":"https://api.github.com/repos/google/mobly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/mobly/downloads","issues_url":"https://api.github.com/repos/google/mobly/issues{/number}","pulls_url":"https://api.github.com/repos/google/mobly/pulls{/number}","milestones_url":"https://api.github.com/repos/google/mobly/milestones{/number}","notifications_url":"https://api.github.com/repos/google/mobly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/mobly/labels{/name}","releases_url":"https://api.github.com/repos/google/mobly/releases{/id}","deployments_url":"https://api.github.com/repos/google/mobly/deployments","created_at":"2016-11-07T17:45:31Z","updated_at":"2016-12-21T07:25:29Z","pushed_at":"2016-12-22T06:36:18Z","git_url":"git://github.com/google/mobly.git","ssh_url":"git@github.com:google/mobly.git","clone_url":"https://github.com/google/mobly.git","svn_url":"https://github.com/google/mobly","homepage":"http://google.github.io/mobly","size":196,"stargazers_count":40,"watchers_count":40,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":13,"forks":6,"open_issues":13,"watchers":40,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"4ed6875774857f9c5d23989b498d766b72205115","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":73104945,"name":"mobly","full_name":"google/mobly","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/mobly","description":"Mobly - Test framework for integration tests with complex test bed setup","fork":false,"url":"https://api.github.com/repos/google/mobly","forks_url":"https://api.github.com/repos/google/mobly/forks","keys_url":"https://api.github.com/repos/google/mobly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/mobly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/mobly/teams","hooks_url":"https://api.github.com/repos/google/mobly/hooks","issue_events_url":"https://api.github.com/repos/google/mobly/issues/events{/number}","events_url":"https://api.github.com/repos/google/mobly/events","assignees_url":"https://api.github.com/repos/google/mobly/assignees{/user}","branches_url":"https://api.github.com/repos/google/mobly/branches{/branch}","tags_url":"https://api.github.com/repos/google/mobly/tags","blobs_url":"https://api.github.com/repos/google/mobly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/mobly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/mobly/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/mobly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/mobly/statuses/{sha}","languages_url":"https://api.github.com/repos/google/mobly/languages","stargazers_url":"https://api.github.com/repos/google/mobly/stargazers","contributors_url":"https://api.github.com/repos/google/mobly/contributors","subscribers_url":"https://api.github.com/repos/google/mobly/subscribers","subscription_url":"https://api.github.com/repos/google/mobly/subscription","commits_url":"https://api.github.com/repos/google/mobly/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/mobly/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/mobly/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/mobly/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/mobly/contents/{+path}","compare_url":"https://api.github.com/repos/google/mobly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/mobly/merges","archive_url":"https://api.github.com/repos/google/mobly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/mobly/downloads","issues_url":"https://api.github.com/repos/google/mobly/issues{/number}","pulls_url":"https://api.github.com/repos/google/mobly/pulls{/number}","milestones_url":"https://api.github.com/repos/google/mobly/milestones{/number}","notifications_url":"https://api.github.com/repos/google/mobly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/mobly/labels{/name}","releases_url":"https://api.github.com/repos/google/mobly/releases{/id}","deployments_url":"https://api.github.com/repos/google/mobly/deployments","created_at":"2016-11-07T17:45:31Z","updated_at":"2016-12-21T07:25:29Z","pushed_at":"2016-12-22T06:36:18Z","git_url":"git://github.com/google/mobly.git","ssh_url":"git@github.com:google/mobly.git","clone_url":"https://github.com/google/mobly.git","svn_url":"https://github.com/google/mobly","homepage":"http://google.github.io/mobly","size":196,"stargazers_count":40,"watchers_count":40,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":13,"forks":6,"open_issues":13,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/mobly/pulls/49"},"html":{"href":"https://github.com/google/mobly/pull/49"},"issue":{"href":"https://api.github.com/repos/google/mobly/issues/49"},"comments":{"href":"https://api.github.com/repos/google/mobly/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/google/mobly/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/google/mobly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/mobly/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/google/mobly/statuses/070f76aec42a6f083fce971114421725217242f0"}}}}
{"actor":{"display_login":"adorokhine"}}