{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments/85025615","pull_request_review_id":5766256,"id":85025615,"diff_hunk":"@@ -167,11 +189,30 @@ def test_sync_recognize_with_empty_results(self):\n         client = self._makeOne(credentials=credentials)\n         client.connection = _Connection(SYNC_RECOGNIZE_EMPTY_RESPONSE)\n \n-        with self.assertRaises(ValueError):\n-            sample = Sample(source_uri=self.AUDIO_SOURCE_URI,\n-                            encoding=speech.Encoding.FLAC,\n-                            sample_rate=self.SAMPLE_RATE)\n-            client.sync_recognize(sample)\n+        with self.assertRaises(IndexError):","path":"speech/unit_tests/test_client.py","position":83,"original_position":83,"commit_id":"1aab8b1c05e7413d60c8078916324ad0cf18a047","original_commit_id":"1aab8b1c05e7413d60c8078916324ad0cf18a047","user":{"login":"daspecster","id":192456,"avatar_url":"https://avatars.githubusercontent.com/u/192456?v=3","gravatar_id":"","url":"https://api.github.com/users/daspecster","html_url":"https://github.com/daspecster","followers_url":"https://api.github.com/users/daspecster/followers","following_url":"https://api.github.com/users/daspecster/following{/other_user}","gists_url":"https://api.github.com/users/daspecster/gists{/gist_id}","starred_url":"https://api.github.com/users/daspecster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daspecster/subscriptions","organizations_url":"https://api.github.com/users/daspecster/orgs","repos_url":"https://api.github.com/users/daspecster/repos","events_url":"https://api.github.com/users/daspecster/events{/privacy}","received_events_url":"https://api.github.com/users/daspecster/received_events","type":"User","site_admin":false},"body":"I'm not sure which is correct I guess. I was thinking about it and it seemed like IndexError would be the right one but I guess an argument for ValueError could be made too?","created_at":"2016-10-25T23:45:22Z","updated_at":"2016-10-25T23:45:22Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2615#discussion_r85025615","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2615","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments/85025615"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2615#discussion_r85025615"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2615"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2615","id":90911010,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2615","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2615.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2615.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/2615","number":2615,"state":"open","locked":false,"title":"Add Speech GAPIC for sync_recognize.","user":{"login":"daspecster","id":192456,"avatar_url":"https://avatars.githubusercontent.com/u/192456?v=3","gravatar_id":"","url":"https://api.github.com/users/daspecster","html_url":"https://github.com/daspecster","followers_url":"https://api.github.com/users/daspecster/followers","following_url":"https://api.github.com/users/daspecster/following{/other_user}","gists_url":"https://api.github.com/users/daspecster/gists{/gist_id}","starred_url":"https://api.github.com/users/daspecster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daspecster/subscriptions","organizations_url":"https://api.github.com/users/daspecster/orgs","repos_url":"https://api.github.com/users/daspecster/repos","events_url":"https://api.github.com/users/daspecster/events{/privacy}","received_events_url":"https://api.github.com/users/daspecster/received_events","type":"User","site_admin":false},"body":"This adds GAPIC support to speech sync_recognize().","created_at":"2016-10-25T23:28:51Z","updated_at":"2016-10-25T23:45:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14527948952422f3ab9288d783ff8ebbc92aab59","assignee":{"login":"tseaver","id":242750,"avatar_url":"https://avatars.githubusercontent.com/u/242750?v=3","gravatar_id":"","url":"https://api.github.com/users/tseaver","html_url":"https://github.com/tseaver","followers_url":"https://api.github.com/users/tseaver/followers","following_url":"https://api.github.com/users/tseaver/following{/other_user}","gists_url":"https://api.github.com/users/tseaver/gists{/gist_id}","starred_url":"https://api.github.com/users/tseaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tseaver/subscriptions","organizations_url":"https://api.github.com/users/tseaver/orgs","repos_url":"https://api.github.com/users/tseaver/repos","events_url":"https://api.github.com/users/tseaver/events{/privacy}","received_events_url":"https://api.github.com/users/tseaver/received_events","type":"User","site_admin":false},"assignees":[{"login":"tseaver","id":242750,"avatar_url":"https://avatars.githubusercontent.com/u/242750?v=3","gravatar_id":"","url":"https://api.github.com/users/tseaver","html_url":"https://github.com/tseaver","followers_url":"https://api.github.com/users/tseaver/followers","following_url":"https://api.github.com/users/tseaver/following{/other_user}","gists_url":"https://api.github.com/users/tseaver/gists{/gist_id}","starred_url":"https://api.github.com/users/tseaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tseaver/subscriptions","organizations_url":"https://api.github.com/users/tseaver/orgs","repos_url":"https://api.github.com/users/tseaver/repos","events_url":"https://api.github.com/users/tseaver/events{/privacy}","received_events_url":"https://api.github.com/users/tseaver/received_events","type":"User","site_admin":false},{"login":"dhermes","id":520669,"avatar_url":"https://avatars.githubusercontent.com/u/520669?v=3","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2615/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2615/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/2615/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/1aab8b1c05e7413d60c8078916324ad0cf18a047","head":{"label":"daspecster:add-speech-sync-gapic","ref":"add-speech-sync-gapic","sha":"1aab8b1c05e7413d60c8078916324ad0cf18a047","user":{"login":"daspecster","id":192456,"avatar_url":"https://avatars.githubusercontent.com/u/192456?v=3","gravatar_id":"","url":"https://api.github.com/users/daspecster","html_url":"https://github.com/daspecster","followers_url":"https://api.github.com/users/daspecster/followers","following_url":"https://api.github.com/users/daspecster/following{/other_user}","gists_url":"https://api.github.com/users/daspecster/gists{/gist_id}","starred_url":"https://api.github.com/users/daspecster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daspecster/subscriptions","organizations_url":"https://api.github.com/users/daspecster/orgs","repos_url":"https://api.github.com/users/daspecster/repos","events_url":"https://api.github.com/users/daspecster/events{/privacy}","received_events_url":"https://api.github.com/users/daspecster/received_events","type":"User","site_admin":false},"repo":{"id":43923717,"name":"google-cloud-python","full_name":"daspecster/google-cloud-python","owner":{"login":"daspecster","id":192456,"avatar_url":"https://avatars.githubusercontent.com/u/192456?v=3","gravatar_id":"","url":"https://api.github.com/users/daspecster","html_url":"https://github.com/daspecster","followers_url":"https://api.github.com/users/daspecster/followers","following_url":"https://api.github.com/users/daspecster/following{/other_user}","gists_url":"https://api.github.com/users/daspecster/gists{/gist_id}","starred_url":"https://api.github.com/users/daspecster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daspecster/subscriptions","organizations_url":"https://api.github.com/users/daspecster/orgs","repos_url":"https://api.github.com/users/daspecster/repos","events_url":"https://api.github.com/users/daspecster/events{/privacy}","received_events_url":"https://api.github.com/users/daspecster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daspecster/google-cloud-python","description":"Google Cloud Client Library for Python","fork":true,"url":"https://api.github.com/repos/daspecster/google-cloud-python","forks_url":"https://api.github.com/repos/daspecster/google-cloud-python/forks","keys_url":"https://api.github.com/repos/daspecster/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daspecster/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daspecster/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/daspecster/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/daspecster/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/daspecster/google-cloud-python/events","assignees_url":"https://api.github.com/repos/daspecster/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/daspecster/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/daspecster/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/daspecster/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daspecster/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daspecster/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/daspecster/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daspecster/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/daspecster/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/daspecster/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/daspecster/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/daspecster/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/daspecster/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/daspecster/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/daspecster/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/daspecster/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/daspecster/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/daspecster/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/daspecster/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daspecster/google-cloud-python/merges","archive_url":"https://api.github.com/repos/daspecster/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daspecster/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/daspecster/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/daspecster/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/daspecster/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/daspecster/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daspecster/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/daspecster/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/daspecster/google-cloud-python/deployments","created_at":"2015-10-09T00:31:09Z","updated_at":"2016-10-24T15:13:15Z","pushed_at":"2016-10-25T23:27:31Z","git_url":"git://github.com/daspecster/google-cloud-python.git","ssh_url":"git@github.com:daspecster/google-cloud-python.git","clone_url":"https://github.com/daspecster/google-cloud-python.git","svn_url":"https://github.com/daspecster/google-cloud-python","homepage":"https://googlecloudplatform.github.io/gcloud-python/","size":74144,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"0f8fdb6d2360e937dfba395b142de42c618eb228","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":16316451,"name":"google-cloud-python","full_name":"GoogleCloudPlatform/google-cloud-python","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python","description":"Google Cloud Client Library for Python","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/deployments","created_at":"2014-01-28T15:51:47Z","updated_at":"2016-10-25T15:16:06Z","pushed_at":"2016-10-25T23:28:52Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-python.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-python.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-python.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-python","homepage":"https://googlecloudplatform.github.io/google-cloud-python/","size":98815,"stargazers_count":433,"watchers_count":433,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":216,"mirror_url":null,"open_issues_count":238,"forks":216,"open_issues":238,"watchers":433,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2615"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2615"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/2615"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/2615/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2615/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2615/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/1aab8b1c05e7413d60c8078916324ad0cf18a047"}}}}
{"actor":{"display_login":"daspecster"}}