{"action":"created","issue":{"url":"https://api.github.com/repos/zanata/zanata-platform/issues/18","repository_url":"https://api.github.com/repos/zanata/zanata-platform","labels_url":"https://api.github.com/repos/zanata/zanata-platform/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/zanata/zanata-platform/issues/18/comments","events_url":"https://api.github.com/repos/zanata/zanata-platform/issues/18/events","html_url":"https://github.com/zanata/zanata-platform/pull/18","id":185813343,"number":18,"title":"chore(ZNTA-1413): use takari for incremental builds","user":{"login":"seanf","id":54155,"avatar_url":"https://avatars.githubusercontent.com/u/54155?v=3","gravatar_id":"","url":"https://api.github.com/users/seanf","html_url":"https://github.com/seanf","followers_url":"https://api.github.com/users/seanf/followers","following_url":"https://api.github.com/users/seanf/following{/other_user}","gists_url":"https://api.github.com/users/seanf/gists{/gist_id}","starred_url":"https://api.github.com/users/seanf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanf/subscriptions","organizations_url":"https://api.github.com/users/seanf/orgs","repos_url":"https://api.github.com/users/seanf/repos","events_url":"https://api.github.com/users/seanf/events{/privacy}","received_events_url":"https://api.github.com/users/seanf/received_events","type":"User","site_admin":false},"labels":[{"id":465775127,"url":"https://api.github.com/repos/zanata/zanata-platform/labels/Awaiting%20review","name":"Awaiting review","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"huangp","id":1005842,"avatar_url":"https://avatars.githubusercontent.com/u/1005842?v=3","gravatar_id":"","url":"https://api.github.com/users/huangp","html_url":"https://github.com/huangp","followers_url":"https://api.github.com/users/huangp/followers","following_url":"https://api.github.com/users/huangp/following{/other_user}","gists_url":"https://api.github.com/users/huangp/gists{/gist_id}","starred_url":"https://api.github.com/users/huangp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huangp/subscriptions","organizations_url":"https://api.github.com/users/huangp/orgs","repos_url":"https://api.github.com/users/huangp/repos","events_url":"https://api.github.com/users/huangp/events{/privacy}","received_events_url":"https://api.github.com/users/huangp/received_events","type":"User","site_admin":false},"assignees":[{"login":"huangp","id":1005842,"avatar_url":"https://avatars.githubusercontent.com/u/1005842?v=3","gravatar_id":"","url":"https://api.github.com/users/huangp","html_url":"https://github.com/huangp","followers_url":"https://api.github.com/users/huangp/followers","following_url":"https://api.github.com/users/huangp/following{/other_user}","gists_url":"https://api.github.com/users/huangp/gists{/gist_id}","starred_url":"https://api.github.com/users/huangp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huangp/subscriptions","organizations_url":"https://api.github.com/users/huangp/orgs","repos_url":"https://api.github.com/users/huangp/repos","events_url":"https://api.github.com/users/huangp/events{/privacy}","received_events_url":"https://api.github.com/users/huangp/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-10-28T00:35:37Z","updated_at":"2016-11-07T03:56:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zanata/zanata-platform/pulls/18","html_url":"https://github.com/zanata/zanata-platform/pull/18","diff_url":"https://github.com/zanata/zanata-platform/pull/18.diff","patch_url":"https://github.com/zanata/zanata-platform/pull/18.patch"},"body":"https://zanata.atlassian.net/browse/ZNTA-1413\r\n\r\n## Reviewer tasks\r\n\r\nThe following is based on the\r\n[Zanata Development Guidelines](https://github.com/zanata/zanata-server/wiki/Development-Guidelines).\r\nAs a reviewer, you should check the guidelines regularly for updates, and just\r\nto refresh your memory.\r\n\r\nThe reviewer can use this list for reference to make sure\r\nthey have considered all the important points.\r\n\r\nUse the checkboxes or not, whatever works best for you.\r\n- Code quality\r\n  - [ ] Code passes style check (checkstyle/eslint)\r\n  - [ ] Code is clear and concise\r\n  - [ ] UI code is internationalised\r\n  - [ ] Code has adequate comments where appropriate\r\n  - Code is in an appropriate place\r\n    - [ ] Classes are in appropriate packages\r\n    - [ ] Code fits with class's responsibilities (SRP)\r\n  - [ ] Configuration files are documented enough\r\n  - If code is removed\r\n    - [ ] No remaining code references the removed code\r\n      - [ ] No orphaned rewrite rules\r\n    - [ ] No orphaned config settings\r\n    - [ ] No remaining comments refer to the removed code\r\n    - [ ] Unused imports and libraries are removed\r\n- Testing\r\n  - [ ] New code has tests\r\n  - [ ] Changed code has tests\r\n  - [ ] All tests pass\r\n  - [ ] Test coverage stable or increased\r\n- Documentation\r\n  - [ ] New features are documented\r\n  - [ ] Docs removed for deleted features\r\n  - [ ] Docs updated for all changed features\r\n  - [ ] Developer/sysadmin docs updated if appropriate\r\n- If there are new dependencies\r\n  - [ ] Does each new dependency pass all the\r\n     [Considerations for new dependencies](https://github.com/zanata/zanata-server/wiki/Development-Guidelines#new-technologies-and-dependencies)?\r\n---\r\n\r\n_This template can be updated in .github/PULL_REQUEST_TEMPLATE.md_\r\n\r\n<!-- Reviewable:start -->\r\n---\r\n\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/zanata/zanata-platform/18)\r\n\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/zanata/zanata-platform/issues/comments/258742399","html_url":"https://github.com/zanata/zanata-platform/pull/18#issuecomment-258742399","issue_url":"https://api.github.com/repos/zanata/zanata-platform/issues/18","id":258742399,"user":{"login":"huangp","id":1005842,"avatar_url":"https://avatars.githubusercontent.com/u/1005842?v=3","gravatar_id":"","url":"https://api.github.com/users/huangp","html_url":"https://github.com/huangp","followers_url":"https://api.github.com/users/huangp/followers","following_url":"https://api.github.com/users/huangp/following{/other_user}","gists_url":"https://api.github.com/users/huangp/gists{/gist_id}","starred_url":"https://api.github.com/users/huangp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huangp/subscriptions","organizations_url":"https://api.github.com/users/huangp/orgs","repos_url":"https://api.github.com/users/huangp/repos","events_url":"https://api.github.com/users/huangp/events{/privacy}","received_events_url":"https://api.github.com/users/huangp/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T03:56:53Z","updated_at":"2016-11-07T03:56:53Z","body":"\n\n\n\nReviewed 36 of 36 files at r1.\nReview status: all files reviewed at latest revision, 5 unresolved discussions.\n\n---\n\n*[parent/checkstyle-suppressions.xml, line 16 at r1](https://reviewable.io:443/reviews/zanata/zanata-platform/18#-KVwqIDWsnTj3H_SZYdx:-KVwqIDWsnTj3H_SZYdy:bz11yxk) ([raw file](https://github.com/zanata/zanata-platform/blob/9abfe4fd7190e5dce5bac96ea1fac99f1b341e26/parent/checkstyle-suppressions.xml#L16)):*\n> ```XML\n>   <!-- Ignore old Liquibase changelogs -->\n>   <suppress checks=\".*\" files=\"db\\.changelog-(1\\..a?|2\\..|3\\.[01])\\.xml$\" />\n>   <suppress checks=\".*\" files=\"db/.*_baseline\\.sql$\" />\n> ```\n\nAre these no longer a problem? We still have codemirror cache js file under src/main/resources\n\n---\n\n*[server/functional-test/src/test/conf/zanata-ds.xml, line 15 at r1](https://reviewable.io:443/reviews/zanata/zanata-platform/18#-KVwsZnGoSpc7znXT0mU:-KVwsZnGoSpc7znXT0mV:bpn202h) ([raw file](https://github.com/zanata/zanata-platform/blob/2bfcf13f340690b688f9b25c5d307cad94ed4216/server/functional-test/src/test/conf/zanata-ds.xml#L15)):*\n> ```XML\n>     use-ccm=\"true\"\n>     use-java-context=\"true\">\n>     <connection-url>@ds.connection.url@</connection-url>\n> ```\n\nCan you explain what is this ```@xxx@``` thing for?\n\n---\n\n*[server/zanata-frontend/pom.xml, line 173 at r1](https://reviewable.io:443/reviews/zanata/zanata-platform/18#-KVwuMaXReHOha6TnvNe:-KVwuMaXReHOha6TnvNf:b-izz176) ([raw file](https://github.com/zanata/zanata-platform/blob/9abfe4fd7190e5dce5bac96ea1fac99f1b341e26/server/zanata-frontend/pom.xml#L173)):*\n> ```XML\n>             </goals>\n>             <configuration>\n>               <skip>${skipTests}</skip>\n> ```\n\nDon't we want this?\n\n---\n\n*[server/zanata-frontend/pom.xml, line 245 at r1](https://reviewable.io:443/reviews/zanata/zanata-platform/18#-KVwukOTWpicvyoxFoJc:-KVwukOTWpicvyoxFoJd:b-2b6t3z) ([raw file](https://github.com/zanata/zanata-platform/blob/2bfcf13f340690b688f9b25c5d307cad94ed4216/server/zanata-frontend/pom.xml#L245)):*\n> ```XML\n>               <directory>src</directory>\n>               <includes>\n>                 <include>*/node_modules/**</include>\n> ```\n\nWhat about the stuff under src/editor/app/dist?\n\n---\n\n*[server/zanata-test-war/pom.xml, line 171 at r1](https://reviewable.io:443/reviews/zanata/zanata-platform/18#-KVwvKi95gwtQzwumaFw:-KVwvKi95gwtQzwumaFx:byj4k2k) ([raw file](https://github.com/zanata/zanata-platform/blob/2bfcf13f340690b688f9b25c5d307cad94ed4216/server/zanata-test-war/pom.xml#L171)):*\n> ```XML\n>       </plugin>\n>       <plugin>\n>         <artifactId>maven-war-plugin</artifactId>\n> ```\n\nBefore this change, if we skipFuncTests then this module won't do much but looks like now it will do war overlay regardless whether we are going to run functional test. Is this true?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/zanata/zanata-platform/18)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"huangp"}}