{"action":"created","comment":{"url":"https://api.github.com/repos/lcdb/lcdb-workflows/pulls/comments/69128318","id":69128318,"diff_hunk":"@@ -1,4 +0,0 @@\n-sampletable: pasilla_sampletable.tsv\n-sample_dir: pasilla\n-assembly: dm6\n-data_dir: /data/LCDB/references","path":"test/config.yaml","position":4,"original_position":4,"commit_id":"5423ff05c5e14d598a973b6dc3236eb29b611f85","original_commit_id":"f9639e14a375f6b78c75a077b54fa74a431aa4a7","user":{"login":"jfear","id":1240432,"avatar_url":"https://avatars.githubusercontent.com/u/1240432?v=3","gravatar_id":"","url":"https://api.github.com/users/jfear","html_url":"https://github.com/jfear","followers_url":"https://api.github.com/users/jfear/followers","following_url":"https://api.github.com/users/jfear/following{/other_user}","gists_url":"https://api.github.com/users/jfear/gists{/gist_id}","starred_url":"https://api.github.com/users/jfear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfear/subscriptions","organizations_url":"https://api.github.com/users/jfear/orgs","repos_url":"https://api.github.com/users/jfear/repos","events_url":"https://api.github.com/users/jfear/events{/privacy}","received_events_url":"https://api.github.com/users/jfear/received_events","type":"User","site_admin":false},"body":"What about the resources dir? could we just move things there?","created_at":"2016-06-30T13:10:28Z","updated_at":"2016-06-30T13:10:28Z","html_url":"https://github.com/lcdb/lcdb-workflows/pull/38#discussion_r69128318","pull_request_url":"https://api.github.com/repos/lcdb/lcdb-workflows/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/lcdb/lcdb-workflows/pulls/comments/69128318"},"html":{"href":"https://github.com/lcdb/lcdb-workflows/pull/38#discussion_r69128318"},"pull_request":{"href":"https://api.github.com/repos/lcdb/lcdb-workflows/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/lcdb/lcdb-workflows/pulls/38","id":75647733,"html_url":"https://github.com/lcdb/lcdb-workflows/pull/38","diff_url":"https://github.com/lcdb/lcdb-workflows/pull/38.diff","patch_url":"https://github.com/lcdb/lcdb-workflows/pull/38.patch","issue_url":"https://api.github.com/repos/lcdb/lcdb-workflows/issues/38","number":38,"state":"open","locked":false,"title":"Cluster config","user":{"login":"daler","id":115406,"avatar_url":"https://avatars.githubusercontent.com/u/115406?v=3","gravatar_id":"","url":"https://api.github.com/users/daler","html_url":"https://github.com/daler","followers_url":"https://api.github.com/users/daler/followers","following_url":"https://api.github.com/users/daler/following{/other_user}","gists_url":"https://api.github.com/users/daler/gists{/gist_id}","starred_url":"https://api.github.com/users/daler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daler/subscriptions","organizations_url":"https://api.github.com/users/daler/orgs","repos_url":"https://api.github.com/users/daler/repos","events_url":"https://api.github.com/users/daler/events{/privacy}","received_events_url":"https://api.github.com/users/daler/received_events","type":"User","site_admin":false},"body":"This PR adds a mechanism for supplying cluster config settings for each rule alongside all other settings for the rule, instead of maintaining a separate cluster config yaml file. If you want to submit the workflow as a set of cluster jobs, use the new `lcdb/lcdb-submit.py` wrapper. It will read the config, make a cluster config on the fly, and provide that cluster config inside a newly created batch script that can be submitted to the cluster.\r\n\r\nI also removed the `test` workflow in this PR. The reason is that it was getting out of date with the changes in config and snakefile architecture. Most of the rules are already moved over to the mapping config anyway, and the rest will be incorporated into the rnaseq workflow.\r\n\r\nI've updated the main README to reflect these changes, and to show the commands for how to test. The big change is that we no longer provide the top-level repo, rather, provide the path to the snakefile that you want to test as the first argument.\r\n\r\nYou can also provide `--config` to specify a particular config file to test. This will become useful as we incorporate more test datasets and as we build more comprehensive tests.\r\n\r\nThe new `--cluster` arg is what handles the cluster config yaml building. The full test can be done like this:\r\n\r\n```bash\r\ntest/run_test.py workflows/mapping/Snakefile --cluster --build-env --clean\r\n```\r\n\r\nIt will create a temp bash script and run it. That bash script looks something like this:\r\n\r\n```bash\r\n#!/bin/bash\r\n\r\nset -eo pipefail\r\n\r\nsource activate lcdb-workflows-$USER-env\r\nsnakemake --directory workflows/mapping -s workflows/mapping/Snakefile clean\r\ntime snakemake --cluster-config test-cluster-config.yaml \\\r\n    --cluster \"sbatch {cluster.args} --cpus-per-task={threads}\" \\\r\n    --jobname \"s.{rulename}.{jobid}.sh\" \\\r\n    -j 999 \\\r\n    --rerun-incomplete \\\r\n    -T \\\r\n    --verbose \\\r\n    --directory workflows/mapping \\\r\n    -s workflows/mapping/Snakefile \\\r\n     \\\r\n    > workflows/mapping/Snakefile.log 2>&1\r\n```\r\n\r\n(so check `workflows/mapping/Snakefile.log` for the log output)\r\n","created_at":"2016-06-29T13:28:42Z","updated_at":"2016-06-30T13:10:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36f0ab2f9c32cefed02c39b630eb0f9ddc2c215d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lcdb/lcdb-workflows/pulls/38/commits","review_comments_url":"https://api.github.com/repos/lcdb/lcdb-workflows/pulls/38/comments","review_comment_url":"https://api.github.com/repos/lcdb/lcdb-workflows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lcdb/lcdb-workflows/issues/38/comments","statuses_url":"https://api.github.com/repos/lcdb/lcdb-workflows/statuses/5423ff05c5e14d598a973b6dc3236eb29b611f85","head":{"label":"lcdb:cluster-config","ref":"cluster-config","sha":"5423ff05c5e14d598a973b6dc3236eb29b611f85","user":{"login":"lcdb","id":7584817,"avatar_url":"https://avatars.githubusercontent.com/u/7584817?v=3","gravatar_id":"","url":"https://api.github.com/users/lcdb","html_url":"https://github.com/lcdb","followers_url":"https://api.github.com/users/lcdb/followers","following_url":"https://api.github.com/users/lcdb/following{/other_user}","gists_url":"https://api.github.com/users/lcdb/gists{/gist_id}","starred_url":"https://api.github.com/users/lcdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcdb/subscriptions","organizations_url":"https://api.github.com/users/lcdb/orgs","repos_url":"https://api.github.com/users/lcdb/repos","events_url":"https://api.github.com/users/lcdb/events{/privacy}","received_events_url":"https://api.github.com/users/lcdb/received_events","type":"Organization","site_admin":false},"repo":{"id":58685798,"name":"lcdb-workflows","full_name":"lcdb/lcdb-workflows","owner":{"login":"lcdb","id":7584817,"avatar_url":"https://avatars.githubusercontent.com/u/7584817?v=3","gravatar_id":"","url":"https://api.github.com/users/lcdb","html_url":"https://github.com/lcdb","followers_url":"https://api.github.com/users/lcdb/followers","following_url":"https://api.github.com/users/lcdb/following{/other_user}","gists_url":"https://api.github.com/users/lcdb/gists{/gist_id}","starred_url":"https://api.github.com/users/lcdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcdb/subscriptions","organizations_url":"https://api.github.com/users/lcdb/orgs","repos_url":"https://api.github.com/users/lcdb/repos","events_url":"https://api.github.com/users/lcdb/events{/privacy}","received_events_url":"https://api.github.com/users/lcdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lcdb/lcdb-workflows","description":"snakemake workflows for LCDB bioinformatics","fork":false,"url":"https://api.github.com/repos/lcdb/lcdb-workflows","forks_url":"https://api.github.com/repos/lcdb/lcdb-workflows/forks","keys_url":"https://api.github.com/repos/lcdb/lcdb-workflows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lcdb/lcdb-workflows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lcdb/lcdb-workflows/teams","hooks_url":"https://api.github.com/repos/lcdb/lcdb-workflows/hooks","issue_events_url":"https://api.github.com/repos/lcdb/lcdb-workflows/issues/events{/number}","events_url":"https://api.github.com/repos/lcdb/lcdb-workflows/events","assignees_url":"https://api.github.com/repos/lcdb/lcdb-workflows/assignees{/user}","branches_url":"https://api.github.com/repos/lcdb/lcdb-workflows/branches{/branch}","tags_url":"https://api.github.com/repos/lcdb/lcdb-workflows/tags","blobs_url":"https://api.github.com/repos/lcdb/lcdb-workflows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lcdb/lcdb-workflows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lcdb/lcdb-workflows/git/refs{/sha}","trees_url":"https://api.github.com/repos/lcdb/lcdb-workflows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lcdb/lcdb-workflows/statuses/{sha}","languages_url":"https://api.github.com/repos/lcdb/lcdb-workflows/languages","stargazers_url":"https://api.github.com/repos/lcdb/lcdb-workflows/stargazers","contributors_url":"https://api.github.com/repos/lcdb/lcdb-workflows/contributors","subscribers_url":"https://api.github.com/repos/lcdb/lcdb-workflows/subscribers","subscription_url":"https://api.github.com/repos/lcdb/lcdb-workflows/subscription","commits_url":"https://api.github.com/repos/lcdb/lcdb-workflows/commits{/sha}","git_commits_url":"https://api.github.com/repos/lcdb/lcdb-workflows/git/commits{/sha}","comments_url":"https://api.github.com/repos/lcdb/lcdb-workflows/comments{/number}","issue_comment_url":"https://api.github.com/repos/lcdb/lcdb-workflows/issues/comments{/number}","contents_url":"https://api.github.com/repos/lcdb/lcdb-workflows/contents/{+path}","compare_url":"https://api.github.com/repos/lcdb/lcdb-workflows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lcdb/lcdb-workflows/merges","archive_url":"https://api.github.com/repos/lcdb/lcdb-workflows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lcdb/lcdb-workflows/downloads","issues_url":"https://api.github.com/repos/lcdb/lcdb-workflows/issues{/number}","pulls_url":"https://api.github.com/repos/lcdb/lcdb-workflows/pulls{/number}","milestones_url":"https://api.github.com/repos/lcdb/lcdb-workflows/milestones{/number}","notifications_url":"https://api.github.com/repos/lcdb/lcdb-workflows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lcdb/lcdb-workflows/labels{/name}","releases_url":"https://api.github.com/repos/lcdb/lcdb-workflows/releases{/id}","deployments_url":"https://api.github.com/repos/lcdb/lcdb-workflows/deployments","created_at":"2016-05-13T00:11:01Z","updated_at":"2016-05-13T02:11:22Z","pushed_at":"2016-06-30T13:02:10Z","git_url":"git://github.com/lcdb/lcdb-workflows.git","ssh_url":"git@github.com:lcdb/lcdb-workflows.git","clone_url":"https://github.com/lcdb/lcdb-workflows.git","svn_url":"https://github.com/lcdb/lcdb-workflows","homepage":null,"size":10471,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":13,"forks":0,"open_issues":13,"watchers":0,"default_branch":"master"}},"base":{"label":"lcdb:master","ref":"master","sha":"b290a77aa439d280a803398d9cb967b3cd8c1d71","user":{"login":"lcdb","id":7584817,"avatar_url":"https://avatars.githubusercontent.com/u/7584817?v=3","gravatar_id":"","url":"https://api.github.com/users/lcdb","html_url":"https://github.com/lcdb","followers_url":"https://api.github.com/users/lcdb/followers","following_url":"https://api.github.com/users/lcdb/following{/other_user}","gists_url":"https://api.github.com/users/lcdb/gists{/gist_id}","starred_url":"https://api.github.com/users/lcdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcdb/subscriptions","organizations_url":"https://api.github.com/users/lcdb/orgs","repos_url":"https://api.github.com/users/lcdb/repos","events_url":"https://api.github.com/users/lcdb/events{/privacy}","received_events_url":"https://api.github.com/users/lcdb/received_events","type":"Organization","site_admin":false},"repo":{"id":58685798,"name":"lcdb-workflows","full_name":"lcdb/lcdb-workflows","owner":{"login":"lcdb","id":7584817,"avatar_url":"https://avatars.githubusercontent.com/u/7584817?v=3","gravatar_id":"","url":"https://api.github.com/users/lcdb","html_url":"https://github.com/lcdb","followers_url":"https://api.github.com/users/lcdb/followers","following_url":"https://api.github.com/users/lcdb/following{/other_user}","gists_url":"https://api.github.com/users/lcdb/gists{/gist_id}","starred_url":"https://api.github.com/users/lcdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcdb/subscriptions","organizations_url":"https://api.github.com/users/lcdb/orgs","repos_url":"https://api.github.com/users/lcdb/repos","events_url":"https://api.github.com/users/lcdb/events{/privacy}","received_events_url":"https://api.github.com/users/lcdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lcdb/lcdb-workflows","description":"snakemake workflows for LCDB bioinformatics","fork":false,"url":"https://api.github.com/repos/lcdb/lcdb-workflows","forks_url":"https://api.github.com/repos/lcdb/lcdb-workflows/forks","keys_url":"https://api.github.com/repos/lcdb/lcdb-workflows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lcdb/lcdb-workflows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lcdb/lcdb-workflows/teams","hooks_url":"https://api.github.com/repos/lcdb/lcdb-workflows/hooks","issue_events_url":"https://api.github.com/repos/lcdb/lcdb-workflows/issues/events{/number}","events_url":"https://api.github.com/repos/lcdb/lcdb-workflows/events","assignees_url":"https://api.github.com/repos/lcdb/lcdb-workflows/assignees{/user}","branches_url":"https://api.github.com/repos/lcdb/lcdb-workflows/branches{/branch}","tags_url":"https://api.github.com/repos/lcdb/lcdb-workflows/tags","blobs_url":"https://api.github.com/repos/lcdb/lcdb-workflows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lcdb/lcdb-workflows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lcdb/lcdb-workflows/git/refs{/sha}","trees_url":"https://api.github.com/repos/lcdb/lcdb-workflows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lcdb/lcdb-workflows/statuses/{sha}","languages_url":"https://api.github.com/repos/lcdb/lcdb-workflows/languages","stargazers_url":"https://api.github.com/repos/lcdb/lcdb-workflows/stargazers","contributors_url":"https://api.github.com/repos/lcdb/lcdb-workflows/contributors","subscribers_url":"https://api.github.com/repos/lcdb/lcdb-workflows/subscribers","subscription_url":"https://api.github.com/repos/lcdb/lcdb-workflows/subscription","commits_url":"https://api.github.com/repos/lcdb/lcdb-workflows/commits{/sha}","git_commits_url":"https://api.github.com/repos/lcdb/lcdb-workflows/git/commits{/sha}","comments_url":"https://api.github.com/repos/lcdb/lcdb-workflows/comments{/number}","issue_comment_url":"https://api.github.com/repos/lcdb/lcdb-workflows/issues/comments{/number}","contents_url":"https://api.github.com/repos/lcdb/lcdb-workflows/contents/{+path}","compare_url":"https://api.github.com/repos/lcdb/lcdb-workflows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lcdb/lcdb-workflows/merges","archive_url":"https://api.github.com/repos/lcdb/lcdb-workflows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lcdb/lcdb-workflows/downloads","issues_url":"https://api.github.com/repos/lcdb/lcdb-workflows/issues{/number}","pulls_url":"https://api.github.com/repos/lcdb/lcdb-workflows/pulls{/number}","milestones_url":"https://api.github.com/repos/lcdb/lcdb-workflows/milestones{/number}","notifications_url":"https://api.github.com/repos/lcdb/lcdb-workflows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lcdb/lcdb-workflows/labels{/name}","releases_url":"https://api.github.com/repos/lcdb/lcdb-workflows/releases{/id}","deployments_url":"https://api.github.com/repos/lcdb/lcdb-workflows/deployments","created_at":"2016-05-13T00:11:01Z","updated_at":"2016-05-13T02:11:22Z","pushed_at":"2016-06-30T13:02:10Z","git_url":"git://github.com/lcdb/lcdb-workflows.git","ssh_url":"git@github.com:lcdb/lcdb-workflows.git","clone_url":"https://github.com/lcdb/lcdb-workflows.git","svn_url":"https://github.com/lcdb/lcdb-workflows","homepage":null,"size":10471,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":13,"forks":0,"open_issues":13,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lcdb/lcdb-workflows/pulls/38"},"html":{"href":"https://github.com/lcdb/lcdb-workflows/pull/38"},"issue":{"href":"https://api.github.com/repos/lcdb/lcdb-workflows/issues/38"},"comments":{"href":"https://api.github.com/repos/lcdb/lcdb-workflows/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/lcdb/lcdb-workflows/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/lcdb/lcdb-workflows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lcdb/lcdb-workflows/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/lcdb/lcdb-workflows/statuses/5423ff05c5e14d598a973b6dc3236eb29b611f85"}}}}
{"actor":{"display_login":"jfear"}}