{"action":"created","comment":{"url":"https://api.github.com/repos/graalvm/graal-core/pulls/comments/68718111","id":68718111,"diff_hunk":"@@ -71,19 +81,24 @@ static long arrayBaseOffset() {\n         return UNSAFE.arrayBaseOffset(char[].class);\n     }\n \n+    @Fold\n+    static int hashOf(String value) {\n+        return value.hashCode();\n+    }\n+\n     @Snippet\n-    public static String create(@ConstantParameter String compilationTimeString) {\n-        int i = compilationTimeString.length();\n+    public static String create(@ConstantParameter String value) {\n+        int i = value.length();\n         char[] array = (char[]) NewArrayNode.newUninitializedArray(char.class, i);\n-        Word cArray = CStringConstant.cstring(compilationTimeString);","path":"graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/replacements/NewStringSnippets.java","position":49,"original_position":49,"commit_id":"11fd4143dccd5b4a398ad55a9d6f8eada872291a","original_commit_id":"11fd4143dccd5b4a398ad55a9d6f8eada872291a","user":{"login":"dougxc","id":5080087,"avatar_url":"https://avatars.githubusercontent.com/u/5080087?v=3","gravatar_id":"","url":"https://api.github.com/users/dougxc","html_url":"https://github.com/dougxc","followers_url":"https://api.github.com/users/dougxc/followers","following_url":"https://api.github.com/users/dougxc/following{/other_user}","gists_url":"https://api.github.com/users/dougxc/gists{/gist_id}","starred_url":"https://api.github.com/users/dougxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougxc/subscriptions","organizations_url":"https://api.github.com/users/dougxc/orgs","repos_url":"https://api.github.com/users/dougxc/repos","events_url":"https://api.github.com/users/dougxc/events{/privacy}","received_events_url":"https://api.github.com/users/dougxc/received_events","type":"User","site_admin":false},"body":"The jdk9 issue Tom alludes to is [Compact Strings](http://openjdk.java.net/jeps/254) which means `String.value` is now a `byte[]`. As such, I second Tom's suggestion to generate a call to a `String` constructor.","created_at":"2016-06-28T08:38:37Z","updated_at":"2016-06-28T08:38:37Z","html_url":"https://github.com/graalvm/graal-core/pull/189#discussion_r68718111","pull_request_url":"https://api.github.com/repos/graalvm/graal-core/pulls/189","_links":{"self":{"href":"https://api.github.com/repos/graalvm/graal-core/pulls/comments/68718111"},"html":{"href":"https://github.com/graalvm/graal-core/pull/189#discussion_r68718111"},"pull_request":{"href":"https://api.github.com/repos/graalvm/graal-core/pulls/189"}}},"pull_request":{"url":"https://api.github.com/repos/graalvm/graal-core/pulls/189","id":74953849,"html_url":"https://github.com/graalvm/graal-core/pull/189","diff_url":"https://github.com/graalvm/graal-core/pull/189.diff","patch_url":"https://github.com/graalvm/graal-core/pull/189.patch","issue_url":"https://api.github.com/repos/graalvm/graal-core/issues/189","number":189,"state":"open","locked":false,"title":"Update directives instrumentation API","user":{"login":"mur47x111","id":4658782,"avatar_url":"https://avatars.githubusercontent.com/u/4658782?v=3","gravatar_id":"","url":"https://api.github.com/users/mur47x111","html_url":"https://github.com/mur47x111","followers_url":"https://api.github.com/users/mur47x111/followers","following_url":"https://api.github.com/users/mur47x111/following{/other_user}","gists_url":"https://api.github.com/users/mur47x111/gists{/gist_id}","starred_url":"https://api.github.com/users/mur47x111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mur47x111/subscriptions","organizations_url":"https://api.github.com/users/mur47x111/orgs","repos_url":"https://api.github.com/users/mur47x111/repos","events_url":"https://api.github.com/users/mur47x111/events{/privacy}","received_events_url":"https://api.github.com/users/mur47x111/received_events","type":"User","site_admin":false},"body":"Update directives instrumentation API as well as the underlying mechanism. \r\n- Move node classes to the package com.oracle.graal.nodes.debug.instrumentation\r\n- Create mapping from BCI to nodes in BytecodeParser. This is for precisely locating the instrumentation target.\r\n- Thanks to the precise bytecode mapping, InstrumentationNode and instrumentation-related phases are refined. Also, the redundant directive API method for inspecting invocation and the additional boolean parameter to the constructor of InstrumentationBeginNode are not needed.\r\n\r\nAdd comments to related classes. \r\nAdd multiple tests in com.oracle.graal.api.directives.test","created_at":"2016-06-23T13:23:28Z","updated_at":"2016-06-28T08:38:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"gilles-duboscq","id":341830,"avatar_url":"https://avatars.githubusercontent.com/u/341830?v=3","gravatar_id":"","url":"https://api.github.com/users/gilles-duboscq","html_url":"https://github.com/gilles-duboscq","followers_url":"https://api.github.com/users/gilles-duboscq/followers","following_url":"https://api.github.com/users/gilles-duboscq/following{/other_user}","gists_url":"https://api.github.com/users/gilles-duboscq/gists{/gist_id}","starred_url":"https://api.github.com/users/gilles-duboscq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilles-duboscq/subscriptions","organizations_url":"https://api.github.com/users/gilles-duboscq/orgs","repos_url":"https://api.github.com/users/gilles-duboscq/repos","events_url":"https://api.github.com/users/gilles-duboscq/events{/privacy}","received_events_url":"https://api.github.com/users/gilles-duboscq/received_events","type":"User","site_admin":false},"assignees":[{"login":"gilles-duboscq","id":341830,"avatar_url":"https://avatars.githubusercontent.com/u/341830?v=3","gravatar_id":"","url":"https://api.github.com/users/gilles-duboscq","html_url":"https://github.com/gilles-duboscq","followers_url":"https://api.github.com/users/gilles-duboscq/followers","following_url":"https://api.github.com/users/gilles-duboscq/following{/other_user}","gists_url":"https://api.github.com/users/gilles-duboscq/gists{/gist_id}","starred_url":"https://api.github.com/users/gilles-duboscq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilles-duboscq/subscriptions","organizations_url":"https://api.github.com/users/gilles-duboscq/orgs","repos_url":"https://api.github.com/users/gilles-duboscq/repos","events_url":"https://api.github.com/users/gilles-duboscq/events{/privacy}","received_events_url":"https://api.github.com/users/gilles-duboscq/received_events","type":"User","site_admin":false},{"login":"tkrodriguez","id":5193177,"avatar_url":"https://avatars.githubusercontent.com/u/5193177?v=3","gravatar_id":"","url":"https://api.github.com/users/tkrodriguez","html_url":"https://github.com/tkrodriguez","followers_url":"https://api.github.com/users/tkrodriguez/followers","following_url":"https://api.github.com/users/tkrodriguez/following{/other_user}","gists_url":"https://api.github.com/users/tkrodriguez/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrodriguez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrodriguez/subscriptions","organizations_url":"https://api.github.com/users/tkrodriguez/orgs","repos_url":"https://api.github.com/users/tkrodriguez/repos","events_url":"https://api.github.com/users/tkrodriguez/events{/privacy}","received_events_url":"https://api.github.com/users/tkrodriguez/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/graalvm/graal-core/pulls/189/commits","review_comments_url":"https://api.github.com/repos/graalvm/graal-core/pulls/189/comments","review_comment_url":"https://api.github.com/repos/graalvm/graal-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graalvm/graal-core/issues/189/comments","statuses_url":"https://api.github.com/repos/graalvm/graal-core/statuses/11fd4143dccd5b4a398ad55a9d6f8eada872291a","head":{"label":"mur47x111:master","ref":"master","sha":"11fd4143dccd5b4a398ad55a9d6f8eada872291a","user":{"login":"mur47x111","id":4658782,"avatar_url":"https://avatars.githubusercontent.com/u/4658782?v=3","gravatar_id":"","url":"https://api.github.com/users/mur47x111","html_url":"https://github.com/mur47x111","followers_url":"https://api.github.com/users/mur47x111/followers","following_url":"https://api.github.com/users/mur47x111/following{/other_user}","gists_url":"https://api.github.com/users/mur47x111/gists{/gist_id}","starred_url":"https://api.github.com/users/mur47x111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mur47x111/subscriptions","organizations_url":"https://api.github.com/users/mur47x111/orgs","repos_url":"https://api.github.com/users/mur47x111/repos","events_url":"https://api.github.com/users/mur47x111/events{/privacy}","received_events_url":"https://api.github.com/users/mur47x111/received_events","type":"User","site_admin":false},"repo":{"id":61795417,"name":"graal-core","full_name":"mur47x111/graal-core","owner":{"login":"mur47x111","id":4658782,"avatar_url":"https://avatars.githubusercontent.com/u/4658782?v=3","gravatar_id":"","url":"https://api.github.com/users/mur47x111","html_url":"https://github.com/mur47x111","followers_url":"https://api.github.com/users/mur47x111/followers","following_url":"https://api.github.com/users/mur47x111/following{/other_user}","gists_url":"https://api.github.com/users/mur47x111/gists{/gist_id}","starred_url":"https://api.github.com/users/mur47x111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mur47x111/subscriptions","organizations_url":"https://api.github.com/users/mur47x111/orgs","repos_url":"https://api.github.com/users/mur47x111/repos","events_url":"https://api.github.com/users/mur47x111/events{/privacy}","received_events_url":"https://api.github.com/users/mur47x111/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mur47x111/graal-core","description":"Graal Compiler & Truffle Partial evaluator.","fork":true,"url":"https://api.github.com/repos/mur47x111/graal-core","forks_url":"https://api.github.com/repos/mur47x111/graal-core/forks","keys_url":"https://api.github.com/repos/mur47x111/graal-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mur47x111/graal-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mur47x111/graal-core/teams","hooks_url":"https://api.github.com/repos/mur47x111/graal-core/hooks","issue_events_url":"https://api.github.com/repos/mur47x111/graal-core/issues/events{/number}","events_url":"https://api.github.com/repos/mur47x111/graal-core/events","assignees_url":"https://api.github.com/repos/mur47x111/graal-core/assignees{/user}","branches_url":"https://api.github.com/repos/mur47x111/graal-core/branches{/branch}","tags_url":"https://api.github.com/repos/mur47x111/graal-core/tags","blobs_url":"https://api.github.com/repos/mur47x111/graal-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mur47x111/graal-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mur47x111/graal-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/mur47x111/graal-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mur47x111/graal-core/statuses/{sha}","languages_url":"https://api.github.com/repos/mur47x111/graal-core/languages","stargazers_url":"https://api.github.com/repos/mur47x111/graal-core/stargazers","contributors_url":"https://api.github.com/repos/mur47x111/graal-core/contributors","subscribers_url":"https://api.github.com/repos/mur47x111/graal-core/subscribers","subscription_url":"https://api.github.com/repos/mur47x111/graal-core/subscription","commits_url":"https://api.github.com/repos/mur47x111/graal-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/mur47x111/graal-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/mur47x111/graal-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/mur47x111/graal-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/mur47x111/graal-core/contents/{+path}","compare_url":"https://api.github.com/repos/mur47x111/graal-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mur47x111/graal-core/merges","archive_url":"https://api.github.com/repos/mur47x111/graal-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mur47x111/graal-core/downloads","issues_url":"https://api.github.com/repos/mur47x111/graal-core/issues{/number}","pulls_url":"https://api.github.com/repos/mur47x111/graal-core/pulls{/number}","milestones_url":"https://api.github.com/repos/mur47x111/graal-core/milestones{/number}","notifications_url":"https://api.github.com/repos/mur47x111/graal-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mur47x111/graal-core/labels{/name}","releases_url":"https://api.github.com/repos/mur47x111/graal-core/releases{/id}","deployments_url":"https://api.github.com/repos/mur47x111/graal-core/deployments","created_at":"2016-06-23T10:07:46Z","updated_at":"2016-06-23T10:07:53Z","pushed_at":"2016-06-23T13:20:19Z","git_url":"git://github.com/mur47x111/graal-core.git","ssh_url":"git@github.com:mur47x111/graal-core.git","clone_url":"https://github.com/mur47x111/graal-core.git","svn_url":"https://github.com/mur47x111/graal-core","homepage":"","size":33301,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graalvm:master","ref":"master","sha":"2bcac0e4992c5012aaf872c8241db4770d27d7bb","user":{"login":"graalvm","id":10176827,"avatar_url":"https://avatars.githubusercontent.com/u/10176827?v=3","gravatar_id":"","url":"https://api.github.com/users/graalvm","html_url":"https://github.com/graalvm","followers_url":"https://api.github.com/users/graalvm/followers","following_url":"https://api.github.com/users/graalvm/following{/other_user}","gists_url":"https://api.github.com/users/graalvm/gists{/gist_id}","starred_url":"https://api.github.com/users/graalvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graalvm/subscriptions","organizations_url":"https://api.github.com/users/graalvm/orgs","repos_url":"https://api.github.com/users/graalvm/repos","events_url":"https://api.github.com/users/graalvm/events{/privacy}","received_events_url":"https://api.github.com/users/graalvm/received_events","type":"Organization","site_admin":false},"repo":{"id":51001011,"name":"graal-core","full_name":"graalvm/graal-core","owner":{"login":"graalvm","id":10176827,"avatar_url":"https://avatars.githubusercontent.com/u/10176827?v=3","gravatar_id":"","url":"https://api.github.com/users/graalvm","html_url":"https://github.com/graalvm","followers_url":"https://api.github.com/users/graalvm/followers","following_url":"https://api.github.com/users/graalvm/following{/other_user}","gists_url":"https://api.github.com/users/graalvm/gists{/gist_id}","starred_url":"https://api.github.com/users/graalvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graalvm/subscriptions","organizations_url":"https://api.github.com/users/graalvm/orgs","repos_url":"https://api.github.com/users/graalvm/repos","events_url":"https://api.github.com/users/graalvm/events{/privacy}","received_events_url":"https://api.github.com/users/graalvm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graalvm/graal-core","description":"Graal Compiler & Truffle Partial evaluator.","fork":false,"url":"https://api.github.com/repos/graalvm/graal-core","forks_url":"https://api.github.com/repos/graalvm/graal-core/forks","keys_url":"https://api.github.com/repos/graalvm/graal-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graalvm/graal-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graalvm/graal-core/teams","hooks_url":"https://api.github.com/repos/graalvm/graal-core/hooks","issue_events_url":"https://api.github.com/repos/graalvm/graal-core/issues/events{/number}","events_url":"https://api.github.com/repos/graalvm/graal-core/events","assignees_url":"https://api.github.com/repos/graalvm/graal-core/assignees{/user}","branches_url":"https://api.github.com/repos/graalvm/graal-core/branches{/branch}","tags_url":"https://api.github.com/repos/graalvm/graal-core/tags","blobs_url":"https://api.github.com/repos/graalvm/graal-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graalvm/graal-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graalvm/graal-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/graalvm/graal-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graalvm/graal-core/statuses/{sha}","languages_url":"https://api.github.com/repos/graalvm/graal-core/languages","stargazers_url":"https://api.github.com/repos/graalvm/graal-core/stargazers","contributors_url":"https://api.github.com/repos/graalvm/graal-core/contributors","subscribers_url":"https://api.github.com/repos/graalvm/graal-core/subscribers","subscription_url":"https://api.github.com/repos/graalvm/graal-core/subscription","commits_url":"https://api.github.com/repos/graalvm/graal-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/graalvm/graal-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/graalvm/graal-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/graalvm/graal-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/graalvm/graal-core/contents/{+path}","compare_url":"https://api.github.com/repos/graalvm/graal-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graalvm/graal-core/merges","archive_url":"https://api.github.com/repos/graalvm/graal-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graalvm/graal-core/downloads","issues_url":"https://api.github.com/repos/graalvm/graal-core/issues{/number}","pulls_url":"https://api.github.com/repos/graalvm/graal-core/pulls{/number}","milestones_url":"https://api.github.com/repos/graalvm/graal-core/milestones{/number}","notifications_url":"https://api.github.com/repos/graalvm/graal-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graalvm/graal-core/labels{/name}","releases_url":"https://api.github.com/repos/graalvm/graal-core/releases{/id}","deployments_url":"https://api.github.com/repos/graalvm/graal-core/deployments","created_at":"2016-02-03T13:22:19Z","updated_at":"2016-06-24T19:52:02Z","pushed_at":"2016-06-28T02:59:07Z","git_url":"git://github.com/graalvm/graal-core.git","ssh_url":"git@github.com:graalvm/graal-core.git","clone_url":"https://github.com/graalvm/graal-core.git","svn_url":"https://github.com/graalvm/graal-core","homepage":"","size":33457,"stargazers_count":44,"watchers_count":44,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":16,"forks":28,"open_issues":16,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graalvm/graal-core/pulls/189"},"html":{"href":"https://github.com/graalvm/graal-core/pull/189"},"issue":{"href":"https://api.github.com/repos/graalvm/graal-core/issues/189"},"comments":{"href":"https://api.github.com/repos/graalvm/graal-core/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/graalvm/graal-core/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/graalvm/graal-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graalvm/graal-core/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/graalvm/graal-core/statuses/11fd4143dccd5b4a398ad55a9d6f8eada872291a"}}}}
{"actor":{"display_login":"dougxc"}}