{"action":"created","issue":{"url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/398","repository_url":"https://api.github.com/repos/QCoDeS/Qcodes","labels_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/398/labels{/name}","comments_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/398/comments","events_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/398/events","html_url":"https://github.com/QCoDeS/Qcodes/pull/398","id":190757601,"number":398,"title":"add handling of unknown types to JSON stream","user":{"login":"peendebak","id":17724047,"avatar_url":"https://avatars.githubusercontent.com/u/17724047?v=3","gravatar_id":"","url":"https://api.github.com/users/peendebak","html_url":"https://github.com/peendebak","followers_url":"https://api.github.com/users/peendebak/followers","following_url":"https://api.github.com/users/peendebak/following{/other_user}","gists_url":"https://api.github.com/users/peendebak/gists{/gist_id}","starred_url":"https://api.github.com/users/peendebak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peendebak/subscriptions","organizations_url":"https://api.github.com/users/peendebak/orgs","repos_url":"https://api.github.com/users/peendebak/repos","events_url":"https://api.github.com/users/peendebak/events{/privacy}","received_events_url":"https://api.github.com/users/peendebak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-21T15:56:46Z","updated_at":"2016-11-21T17:12:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/398","html_url":"https://github.com/QCoDeS/Qcodes/pull/398","diff_url":"https://github.com/QCoDeS/Qcodes/pull/398.diff","patch_url":"https://github.com/QCoDeS/Qcodes/pull/398.patch"},"body":"@alexcjohnson @giulioungaretti \r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/comments/262002734","html_url":"https://github.com/QCoDeS/Qcodes/pull/398#issuecomment-262002734","issue_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/398","id":262002734,"user":{"login":"alexcjohnson","id":2678795,"avatar_url":"https://avatars.githubusercontent.com/u/2678795?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcjohnson","html_url":"https://github.com/alexcjohnson","followers_url":"https://api.github.com/users/alexcjohnson/followers","following_url":"https://api.github.com/users/alexcjohnson/following{/other_user}","gists_url":"https://api.github.com/users/alexcjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcjohnson/subscriptions","organizations_url":"https://api.github.com/users/alexcjohnson/orgs","repos_url":"https://api.github.com/users/alexcjohnson/repos","events_url":"https://api.github.com/users/alexcjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/alexcjohnson/received_events","type":"User","site_admin":false},"created_at":"2016-11-21T17:12:33Z","updated_at":"2016-11-21T17:12:33Z","body":"Removing the `finally` was part of the suggested change (and the most important part, as it could lead to confusing errors). The other part is handling the two branches symmetrically. Right now `try` returns, but `except` sets `s`, which gets returned in the outer scope. Not a huge deal (so 💃 ), but really they should either both return or both set `s` for a later return.\r\n\r\nIncidentally, we don't seem to have any tests for `NumpyJSONEncoder` do we? It's probably largely covered by way of metadata tests, but if you wanted to write a short test for it in `test_helpers.py` you would have my undying gratitude 🍻 "}}
{"actor":{"display_login":"alexcjohnson"}}