{"action":"created","comment":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/comments/63870189","id":63870189,"diff_hunk":"@@ -3220,46 +3231,53 @@ public interface NSExpression : NSSecureCoding, NSCopying {\n \t\t[Export (\"expressionType\")]\n \t\tNSExpressionType ExpressionType { get; }\n \n-\t\t[Export (\"constantValue\")]\n-\t\tNSObject ConstantValue { get; }\n+\t\t[Sealed, Internal, Export (\"expressionBlock\")]\n+\t\tNSExpressionCallbackHandler _Block { get; }\n \n-\t\t[Export (\"keyPath\")]\n-\t\tstring KeyPath { get; }\n+\t\t[Sealed, Internal, Export (\"constantValue\")]\n+\t\tNSObject _ConstantValue { get; }\n \n-\t\t[Export (\"function\")]\n-\t\tstring Function { get; }\n+\t\t[Sealed, Internal, Export (\"keyPath\")]\n+\t\tstring _KeyPath { get; }\n \n-\t\t[Export (\"variable\")]\n-\t\tstring Variable { get; }\n+\t\t[Sealed, Internal, Export (\"function\")]\n+\t\tstring _Function { get; }\n \n-\t\t[Export (\"operand\")]\n-\t\tNSExpression Operand { get; }\n+\t\t[Sealed, Internal, Export (\"variable\")]\n+\t\tstring _Variable { get; }\n \n-\t\t[Export (\"arguments\")]\n-\t\tNSExpression[] Arguments { get; }\n+\t\t[Sealed, Internal, Export (\"operand\")]\n+\t\tNSExpression _Operand { get; }\n \n-\t\t[Export (\"collection\")]\n-\t\tNSObject Collection { get; }\n+\t\t[Sealed, Internal, Export (\"arguments\")]\n+\t\tNSExpression[] _Arguments { get; }\n \n-\t\t[Export (\"predicate\")]\n-\t\tNSPredicate Predicate { get; }\n+\t\t[Sealed, Internal, Export (\"collection\")]\n+\t\tNSObject _Collection { get; }\n \n-\t\t[Export (\"leftExpression\")]\n-\t\tNSExpression LeftExpression { get; }\n+\t\t[Sealed, Internal, Export (\"predicate\")]\n+\t\tNSPredicate _Predicate { get; }\n \n-\t\t[Export (\"rightExpression\")]\n-\t\tNSExpression RightExpression { get; }\n+\t\t[Sealed, Internal, Export (\"leftExpression\")]\n+\t\tNSExpression _LeftExpression { get; }\n+\n+\t\t[Sealed, Internal, Export (\"rightExpression\")]\n+\t\tNSExpression _RightExpression { get; }\n \n \t\t[Mac(10,11),iOS(9,0)]\n-\t\t[Export (\"trueExpression\")]\n-\t\tNSExpression TrueExpression { get; }\n+\t\t[Sealed, Internal, Export (\"trueExpression\")]\n+\t\tNSExpression _TrueExpression { get; }\n \n \t\t[Mac(10,11),iOS(9,0)]\n-\t\t[Export (\"falseExpression\")]\n-\t\tNSExpression FalseExpression { get; }\n+\t\t[Sealed, Internal, Export (\"falseExpression\")]\n+\t\tNSExpression _FalseExpression { get; }\n \n-\t\t[Export (\"expressionValueWithObject:context:\")]\n+\t\t[Obsolete(\"ValueWithObject is deprecated, please use EvaluateWith instead.\")]\n+\t\t[Sealed, Export (\"expressionValueWithObject:context:\")]\n \t\tNSExpression ExpressionValueWithObject (NSObject object1, NSMutableDictionary context);\n+\n+\t\t[Export (\"expressionValueWithObject:context:\")]\n+\t\tNSObject EvaluateWith ([NullAllowed] NSObject object1, [NullAllowed] NSMutableDictionary context);","path":"src/foundation.cs","position":118,"original_position":118,"commit_id":"f62faf4344b1077b86341db2adcd56874a575d5a","original_commit_id":"f62faf4344b1077b86341db2adcd56874a575d5a","user":{"login":"rolfbjarne","id":249268,"avatar_url":"https://avatars.githubusercontent.com/u/249268?v=3","gravatar_id":"","url":"https://api.github.com/users/rolfbjarne","html_url":"https://github.com/rolfbjarne","followers_url":"https://api.github.com/users/rolfbjarne/followers","following_url":"https://api.github.com/users/rolfbjarne/following{/other_user}","gists_url":"https://api.github.com/users/rolfbjarne/gists{/gist_id}","starred_url":"https://api.github.com/users/rolfbjarne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolfbjarne/subscriptions","organizations_url":"https://api.github.com/users/rolfbjarne/orgs","repos_url":"https://api.github.com/users/rolfbjarne/repos","events_url":"https://api.github.com/users/rolfbjarne/events{/privacy}","received_events_url":"https://api.github.com/users/rolfbjarne/received_events","type":"User","site_admin":false},"body":"`object1` is kind of ugly, maybe use `@object` or `obj` instead.","created_at":"2016-05-19T12:40:33Z","updated_at":"2016-05-19T12:40:33Z","html_url":"https://github.com/xamarin/xamarin-macios/pull/57#discussion_r63870189","pull_request_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/comments/63870189"},"html":{"href":"https://github.com/xamarin/xamarin-macios/pull/57#discussion_r63870189"},"pull_request":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/57"}}},"pull_request":{"url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/57","id":70223471,"html_url":"https://github.com/xamarin/xamarin-macios/pull/57","diff_url":"https://github.com/xamarin/xamarin-macios/pull/57.diff","patch_url":"https://github.com/xamarin/xamarin-macios/pull/57.patch","issue_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/57","number":57,"state":"open","locked":false,"title":"[Fix] Add missing selectors for NSExpression.","user":{"login":"mandel-macaque","id":2190086,"avatar_url":"https://avatars.githubusercontent.com/u/2190086?v=3","gravatar_id":"","url":"https://api.github.com/users/mandel-macaque","html_url":"https://github.com/mandel-macaque","followers_url":"https://api.github.com/users/mandel-macaque/followers","following_url":"https://api.github.com/users/mandel-macaque/following{/other_user}","gists_url":"https://api.github.com/users/mandel-macaque/gists{/gist_id}","starred_url":"https://api.github.com/users/mandel-macaque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandel-macaque/subscriptions","organizations_url":"https://api.github.com/users/mandel-macaque/orgs","repos_url":"https://api.github.com/users/mandel-macaque/repos","events_url":"https://api.github.com/users/mandel-macaque/events{/privacy}","received_events_url":"https://api.github.com/users/mandel-macaque/received_events","type":"User","site_admin":false},"body":"Added the missing static factory methods and the missing property. In\r\norder to give a clean API a new flag was added to the NSExpression class\r\nto track if the Block property does return a block or a null ptr. The\r\nidea is to avoid user from seeing an obj-c exception.\r\n\r\nThis commit fixes bug #35012:\r\n\r\nhttps://bugzilla.xamarin.com/show_bug.cgi?id=35012","created_at":"2016-05-16T16:37:20Z","updated_at":"2016-05-19T12:40:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f93ab05e5c43d5f2050ed1686e219e37e0094c7e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/57/commits","review_comments_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/57/comments","review_comment_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/57/comments","statuses_url":"https://api.github.com/repos/xamarin/xamarin-macios/statuses/f62faf4344b1077b86341db2adcd56874a575d5a","head":{"label":"mandel-macaque:bug-35012","ref":"bug-35012","sha":"f62faf4344b1077b86341db2adcd56874a575d5a","user":{"login":"mandel-macaque","id":2190086,"avatar_url":"https://avatars.githubusercontent.com/u/2190086?v=3","gravatar_id":"","url":"https://api.github.com/users/mandel-macaque","html_url":"https://github.com/mandel-macaque","followers_url":"https://api.github.com/users/mandel-macaque/followers","following_url":"https://api.github.com/users/mandel-macaque/following{/other_user}","gists_url":"https://api.github.com/users/mandel-macaque/gists{/gist_id}","starred_url":"https://api.github.com/users/mandel-macaque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandel-macaque/subscriptions","organizations_url":"https://api.github.com/users/mandel-macaque/orgs","repos_url":"https://api.github.com/users/mandel-macaque/repos","events_url":"https://api.github.com/users/mandel-macaque/events{/privacy}","received_events_url":"https://api.github.com/users/mandel-macaque/received_events","type":"User","site_admin":false},"repo":{"id":57903038,"name":"xamarin-macios","full_name":"mandel-macaque/xamarin-macios","owner":{"login":"mandel-macaque","id":2190086,"avatar_url":"https://avatars.githubusercontent.com/u/2190086?v=3","gravatar_id":"","url":"https://api.github.com/users/mandel-macaque","html_url":"https://github.com/mandel-macaque","followers_url":"https://api.github.com/users/mandel-macaque/followers","following_url":"https://api.github.com/users/mandel-macaque/following{/other_user}","gists_url":"https://api.github.com/users/mandel-macaque/gists{/gist_id}","starred_url":"https://api.github.com/users/mandel-macaque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandel-macaque/subscriptions","organizations_url":"https://api.github.com/users/mandel-macaque/orgs","repos_url":"https://api.github.com/users/mandel-macaque/repos","events_url":"https://api.github.com/users/mandel-macaque/events{/privacy}","received_events_url":"https://api.github.com/users/mandel-macaque/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mandel-macaque/xamarin-macios","description":"Bridges the worlds of .NET with the native APIs of Mac, iOS, tvOS, and watchOS.","fork":true,"url":"https://api.github.com/repos/mandel-macaque/xamarin-macios","forks_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/forks","keys_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/teams","hooks_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/hooks","issue_events_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/issues/events{/number}","events_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/events","assignees_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/assignees{/user}","branches_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/branches{/branch}","tags_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/tags","blobs_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/statuses/{sha}","languages_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/languages","stargazers_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/stargazers","contributors_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/contributors","subscribers_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/subscribers","subscription_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/subscription","commits_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/contents/{+path}","compare_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/merges","archive_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/downloads","issues_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/issues{/number}","pulls_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/pulls{/number}","milestones_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/milestones{/number}","notifications_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/labels{/name}","releases_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/releases{/id}","deployments_url":"https://api.github.com/repos/mandel-macaque/xamarin-macios/deployments","created_at":"2016-05-02T16:14:33Z","updated_at":"2016-05-02T16:14:40Z","pushed_at":"2016-05-19T10:53:00Z","git_url":"git://github.com/mandel-macaque/xamarin-macios.git","ssh_url":"git@github.com:mandel-macaque/xamarin-macios.git","clone_url":"https://github.com/mandel-macaque/xamarin-macios.git","svn_url":"https://github.com/mandel-macaque/xamarin-macios","homepage":null,"size":13411,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xamarin:master","ref":"master","sha":"323c7f42fc8a946ad483b622501baee74642a520","user":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":56710511,"name":"xamarin-macios","full_name":"xamarin/xamarin-macios","owner":{"login":"xamarin","id":790012,"avatar_url":"https://avatars.githubusercontent.com/u/790012?v=3","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xamarin/xamarin-macios","description":"Bridges the worlds of .NET with the native APIs of Mac, iOS, tvOS, and watchOS.","fork":false,"url":"https://api.github.com/repos/xamarin/xamarin-macios","forks_url":"https://api.github.com/repos/xamarin/xamarin-macios/forks","keys_url":"https://api.github.com/repos/xamarin/xamarin-macios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/xamarin-macios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/xamarin-macios/teams","hooks_url":"https://api.github.com/repos/xamarin/xamarin-macios/hooks","issue_events_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/xamarin-macios/events","assignees_url":"https://api.github.com/repos/xamarin/xamarin-macios/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/xamarin-macios/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/xamarin-macios/tags","blobs_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/xamarin-macios/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/xamarin-macios/languages","stargazers_url":"https://api.github.com/repos/xamarin/xamarin-macios/stargazers","contributors_url":"https://api.github.com/repos/xamarin/xamarin-macios/contributors","subscribers_url":"https://api.github.com/repos/xamarin/xamarin-macios/subscribers","subscription_url":"https://api.github.com/repos/xamarin/xamarin-macios/subscription","commits_url":"https://api.github.com/repos/xamarin/xamarin-macios/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/xamarin-macios/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/xamarin-macios/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/xamarin-macios/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/xamarin-macios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/xamarin-macios/merges","archive_url":"https://api.github.com/repos/xamarin/xamarin-macios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/xamarin-macios/downloads","issues_url":"https://api.github.com/repos/xamarin/xamarin-macios/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/xamarin-macios/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/xamarin-macios/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/xamarin-macios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/xamarin-macios/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/xamarin-macios/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/xamarin-macios/deployments","created_at":"2016-04-20T18:24:26Z","updated_at":"2016-05-19T12:05:51Z","pushed_at":"2016-05-19T12:33:35Z","git_url":"git://github.com/xamarin/xamarin-macios.git","ssh_url":"git@github.com:xamarin/xamarin-macios.git","clone_url":"https://github.com/xamarin/xamarin-macios.git","svn_url":"https://github.com/xamarin/xamarin-macios","homepage":null,"size":13476,"stargazers_count":550,"watchers_count":550,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":72,"mirror_url":null,"open_issues_count":6,"forks":72,"open_issues":6,"watchers":550,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/57"},"html":{"href":"https://github.com/xamarin/xamarin-macios/pull/57"},"issue":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/issues/57"},"comments":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/xamarin-macios/statuses/f62faf4344b1077b86341db2adcd56874a575d5a"}}}}