{"action":"opened","number":248,"pull_request":{"url":"https://api.github.com/repos/cakephp/migrations/pulls/248","id":74671997,"html_url":"https://github.com/cakephp/migrations/pull/248","diff_url":"https://github.com/cakephp/migrations/pull/248.diff","patch_url":"https://github.com/cakephp/migrations/pull/248.patch","issue_url":"https://api.github.com/repos/cakephp/migrations/issues/248","number":248,"state":"open","locked":false,"title":"Dump command and require-table","user":{"login":"HavokInspiration","id":5243386,"avatar_url":"https://avatars.githubusercontent.com/u/5243386?v=3","gravatar_id":"","url":"https://api.github.com/users/HavokInspiration","html_url":"https://github.com/HavokInspiration","followers_url":"https://api.github.com/users/HavokInspiration/followers","following_url":"https://api.github.com/users/HavokInspiration/following{/other_user}","gists_url":"https://api.github.com/users/HavokInspiration/gists{/gist_id}","starred_url":"https://api.github.com/users/HavokInspiration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HavokInspiration/subscriptions","organizations_url":"https://api.github.com/users/HavokInspiration/orgs","repos_url":"https://api.github.com/users/HavokInspiration/repos","events_url":"https://api.github.com/users/HavokInspiration/events{/privacy}","received_events_url":"https://api.github.com/users/HavokInspiration/received_events","type":"User","site_admin":false},"body":"The ``dump`` command should not set ``require-table`` to true when fetching the tables to add to the dump because it can lead to unexpected results as reported in #232 and #244.\r\n\r\nIt turned out the issue experienced by @ypnos-web and @dereuromark are because of this option.\r\n\r\n@lorenzo As specified in #232, it should be known that tables from plugins will also be added to the dump when migrating or rolling back a set of migrations (basically, the system will now add every tables it finds in the dump), potentially creating a situations where tables from plugin will be added in diffs.\r\nMaybe there could be an option in the migration diff command to exclude tables :\r\n- by specifying a list of table names\r\n- by specifying a plugin name. When used it will fetch all ORM table classes in the said plugin and exclude them from the diff. \r\n\r\nWe can keep the idea on the side right now and consider it if you have users reporting this issue. What do you think ?","created_at":"2016-06-21T19:36:02Z","updated_at":"2016-06-21T19:36:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cakephp/migrations/milestones/30","html_url":"https://github.com/cakephp/migrations/milestones/1.6.3","labels_url":"https://api.github.com/repos/cakephp/migrations/milestones/30/labels","id":1832963,"number":30,"title":"1.6.3","description":"","creator":{"login":"HavokInspiration","id":5243386,"avatar_url":"https://avatars.githubusercontent.com/u/5243386?v=3","gravatar_id":"","url":"https://api.github.com/users/HavokInspiration","html_url":"https://github.com/HavokInspiration","followers_url":"https://api.github.com/users/HavokInspiration/followers","following_url":"https://api.github.com/users/HavokInspiration/following{/other_user}","gists_url":"https://api.github.com/users/HavokInspiration/gists{/gist_id}","starred_url":"https://api.github.com/users/HavokInspiration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HavokInspiration/subscriptions","organizations_url":"https://api.github.com/users/HavokInspiration/orgs","repos_url":"https://api.github.com/users/HavokInspiration/repos","events_url":"https://api.github.com/users/HavokInspiration/events{/privacy}","received_events_url":"https://api.github.com/users/HavokInspiration/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":0,"state":"open","created_at":"2016-06-16T18:48:57Z","updated_at":"2016-06-21T19:36:03Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cakephp/migrations/pulls/248/commits","review_comments_url":"https://api.github.com/repos/cakephp/migrations/pulls/248/comments","review_comment_url":"https://api.github.com/repos/cakephp/migrations/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cakephp/migrations/issues/248/comments","statuses_url":"https://api.github.com/repos/cakephp/migrations/statuses/61f70c83ef7d67d5a1360bb5f31406186c6fa360","head":{"label":"cakephp:dump-require-table","ref":"dump-require-table","sha":"61f70c83ef7d67d5a1360bb5f31406186c6fa360","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":23262129,"name":"migrations","full_name":"cakephp/migrations","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/migrations","description":"CakePHP 3.0 database migrations plugin","fork":false,"url":"https://api.github.com/repos/cakephp/migrations","forks_url":"https://api.github.com/repos/cakephp/migrations/forks","keys_url":"https://api.github.com/repos/cakephp/migrations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/migrations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/migrations/teams","hooks_url":"https://api.github.com/repos/cakephp/migrations/hooks","issue_events_url":"https://api.github.com/repos/cakephp/migrations/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/migrations/events","assignees_url":"https://api.github.com/repos/cakephp/migrations/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/migrations/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/migrations/tags","blobs_url":"https://api.github.com/repos/cakephp/migrations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/migrations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/migrations/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/migrations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/migrations/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/migrations/languages","stargazers_url":"https://api.github.com/repos/cakephp/migrations/stargazers","contributors_url":"https://api.github.com/repos/cakephp/migrations/contributors","subscribers_url":"https://api.github.com/repos/cakephp/migrations/subscribers","subscription_url":"https://api.github.com/repos/cakephp/migrations/subscription","commits_url":"https://api.github.com/repos/cakephp/migrations/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/migrations/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/migrations/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/migrations/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakephp/migrations/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/migrations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/migrations/merges","archive_url":"https://api.github.com/repos/cakephp/migrations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/migrations/downloads","issues_url":"https://api.github.com/repos/cakephp/migrations/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/migrations/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/migrations/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/migrations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/migrations/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/migrations/releases{/id}","deployments_url":"https://api.github.com/repos/cakephp/migrations/deployments","created_at":"2014-08-23T17:40:26Z","updated_at":"2016-05-31T15:54:49Z","pushed_at":"2016-06-21T19:36:03Z","git_url":"git://github.com/cakephp/migrations.git","ssh_url":"git@github.com:cakephp/migrations.git","clone_url":"https://github.com/cakephp/migrations.git","svn_url":"https://github.com/cakephp/migrations","homepage":null,"size":676,"stargazers_count":71,"watchers_count":71,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":16,"forks":46,"open_issues":16,"watchers":71,"default_branch":"master"}},"base":{"label":"cakephp:master","ref":"master","sha":"71850bdce921998c4b6aebadbb8a7b4a0a5864a8","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":23262129,"name":"migrations","full_name":"cakephp/migrations","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars.githubusercontent.com/u/23666?v=3","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/migrations","description":"CakePHP 3.0 database migrations plugin","fork":false,"url":"https://api.github.com/repos/cakephp/migrations","forks_url":"https://api.github.com/repos/cakephp/migrations/forks","keys_url":"https://api.github.com/repos/cakephp/migrations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/migrations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/migrations/teams","hooks_url":"https://api.github.com/repos/cakephp/migrations/hooks","issue_events_url":"https://api.github.com/repos/cakephp/migrations/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/migrations/events","assignees_url":"https://api.github.com/repos/cakephp/migrations/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/migrations/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/migrations/tags","blobs_url":"https://api.github.com/repos/cakephp/migrations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/migrations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/migrations/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/migrations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/migrations/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/migrations/languages","stargazers_url":"https://api.github.com/repos/cakephp/migrations/stargazers","contributors_url":"https://api.github.com/repos/cakephp/migrations/contributors","subscribers_url":"https://api.github.com/repos/cakephp/migrations/subscribers","subscription_url":"https://api.github.com/repos/cakephp/migrations/subscription","commits_url":"https://api.github.com/repos/cakephp/migrations/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/migrations/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/migrations/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/migrations/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakephp/migrations/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/migrations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/migrations/merges","archive_url":"https://api.github.com/repos/cakephp/migrations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/migrations/downloads","issues_url":"https://api.github.com/repos/cakephp/migrations/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/migrations/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/migrations/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/migrations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/migrations/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/migrations/releases{/id}","deployments_url":"https://api.github.com/repos/cakephp/migrations/deployments","created_at":"2014-08-23T17:40:26Z","updated_at":"2016-05-31T15:54:49Z","pushed_at":"2016-06-21T19:36:03Z","git_url":"git://github.com/cakephp/migrations.git","ssh_url":"git@github.com:cakephp/migrations.git","clone_url":"https://github.com/cakephp/migrations.git","svn_url":"https://github.com/cakephp/migrations","homepage":null,"size":676,"stargazers_count":71,"watchers_count":71,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":16,"forks":46,"open_issues":16,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/migrations/pulls/248"},"html":{"href":"https://github.com/cakephp/migrations/pull/248"},"issue":{"href":"https://api.github.com/repos/cakephp/migrations/issues/248"},"comments":{"href":"https://api.github.com/repos/cakephp/migrations/issues/248/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/migrations/pulls/248/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/migrations/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cakephp/migrations/pulls/248/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/migrations/statuses/61f70c83ef7d67d5a1360bb5f31406186c6fa360"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"HavokInspiration"}}