{"action":"created","issue":{"url":"https://api.github.com/repos/catkin/catkin_tools/issues/313","repository_url":"https://api.github.com/repos/catkin/catkin_tools","labels_url":"https://api.github.com/repos/catkin/catkin_tools/issues/313/labels{/name}","comments_url":"https://api.github.com/repos/catkin/catkin_tools/issues/313/comments","events_url":"https://api.github.com/repos/catkin/catkin_tools/issues/313/events","html_url":"https://github.com/catkin/catkin_tools/pull/313","id":146885838,"number":313,"title":"catkin_build: fix cmake args check","user":{"login":"xqms","id":233455,"avatar_url":"https://avatars.githubusercontent.com/u/233455?v=3","gravatar_id":"","url":"https://api.github.com/users/xqms","html_url":"https://github.com/xqms","followers_url":"https://api.github.com/users/xqms/followers","following_url":"https://api.github.com/users/xqms/following{/other_user}","gists_url":"https://api.github.com/users/xqms/gists{/gist_id}","starred_url":"https://api.github.com/users/xqms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xqms/subscriptions","organizations_url":"https://api.github.com/users/xqms/orgs","repos_url":"https://api.github.com/users/xqms/repos","events_url":"https://api.github.com/users/xqms/events{/privacy}","received_events_url":"https://api.github.com/users/xqms/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-04-08T10:22:59Z","updated_at":"2016-04-08T19:56:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/catkin/catkin_tools/pulls/313","html_url":"https://github.com/catkin/catkin_tools/pull/313","diff_url":"https://github.com/catkin/catkin_tools/pull/313.diff","patch_url":"https://github.com/catkin/catkin_tools/pull/313.patch"},"body":"The check as it was would force a cmake run on every package if\r\ncmake_args were saved in the context, since then\r\nctx.cmake_args != opts.cmake_args.\r\n\r\nSince opts.cmake_args are already appended to ctx.cmake_args by\r\nContext.load, the second check is unnecessary."},"comment":{"url":"https://api.github.com/repos/catkin/catkin_tools/issues/comments/207577378","html_url":"https://github.com/catkin/catkin_tools/pull/313#issuecomment-207577378","issue_url":"https://api.github.com/repos/catkin/catkin_tools/issues/313","id":207577378,"user":{"login":"jbohren","id":1253450,"avatar_url":"https://avatars.githubusercontent.com/u/1253450?v=3","gravatar_id":"","url":"https://api.github.com/users/jbohren","html_url":"https://github.com/jbohren","followers_url":"https://api.github.com/users/jbohren/followers","following_url":"https://api.github.com/users/jbohren/following{/other_user}","gists_url":"https://api.github.com/users/jbohren/gists{/gist_id}","starred_url":"https://api.github.com/users/jbohren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbohren/subscriptions","organizations_url":"https://api.github.com/users/jbohren/orgs","repos_url":"https://api.github.com/users/jbohren/repos","events_url":"https://api.github.com/users/jbohren/events{/privacy}","received_events_url":"https://api.github.com/users/jbohren/received_events","type":"User","site_admin":false},"created_at":"2016-04-08T19:56:22Z","updated_at":"2016-04-08T19:56:22Z","body":"@xqms This has already been fixed in #293 in the exact same way (https://github.com/catkin/catkin_tools/pull/293/files#diff-a07688918e375a3e61cecbe117f4d208R369)\r\n\r\n"}}