{"action":"created","comment":{"url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/comments/70856924","id":70856924,"diff_hunk":"@@ -108,12 +108,13 @@ def _is_suitable_ref(self, desc, ref):\n     def _suitable_reftype(self, ref1, ref2, subtypes):\n         \"\"\"\n         \"\"\"\n+        if not subtypes and ref2.Identifier == ua.ObjectIds.HasSubtype:\n+            return False\n         if ref1.Identifier == ref2.Identifier:\n             return True\n-        #TODO: Please check the changes here","path":"opcua/server/address_space.py","position":8,"original_position":8,"commit_id":"c8d5e730b2e14b8583023b75df646b71884bfe9c","original_commit_id":"c2997ee05024355fd8dc3ac027f7654916199063","user":{"login":"oroulet","id":2564046,"avatar_url":"https://avatars.githubusercontent.com/u/2564046?v=3","gravatar_id":"","url":"https://api.github.com/users/oroulet","html_url":"https://github.com/oroulet","followers_url":"https://api.github.com/users/oroulet/followers","following_url":"https://api.github.com/users/oroulet/following{/other_user}","gists_url":"https://api.github.com/users/oroulet/gists{/gist_id}","starred_url":"https://api.github.com/users/oroulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oroulet/subscriptions","organizations_url":"https://api.github.com/users/oroulet/orgs","repos_url":"https://api.github.com/users/oroulet/repos","events_url":"https://api.github.com/users/oroulet/events{/privacy}","received_events_url":"https://api.github.com/users/oroulet/received_events","type":"User","site_admin":false},"body":"now I moved all chnages linked to this in one commit to make it clearer","created_at":"2016-07-14T18:22:04Z","updated_at":"2016-07-14T18:22:04Z","html_url":"https://github.com/FreeOpcUa/python-opcua/pull/244#discussion_r70856924","pull_request_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/244","_links":{"self":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/comments/70856924"},"html":{"href":"https://github.com/FreeOpcUa/python-opcua/pull/244#discussion_r70856924"},"pull_request":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/244"}}},"pull_request":{"url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/244","id":77238898,"html_url":"https://github.com/FreeOpcUa/python-opcua/pull/244","diff_url":"https://github.com/FreeOpcUa/python-opcua/pull/244.diff","patch_url":"https://github.com/FreeOpcUa/python-opcua/pull/244.patch","issue_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/244","number":244,"state":"open","locked":false,"title":"restructure use of types DO NOT MERGE","user":{"login":"oroulet","id":2564046,"avatar_url":"https://avatars.githubusercontent.com/u/2564046?v=3","gravatar_id":"","url":"https://api.github.com/users/oroulet","html_url":"https://github.com/oroulet","followers_url":"https://api.github.com/users/oroulet/followers","following_url":"https://api.github.com/users/oroulet/following{/other_user}","gists_url":"https://api.github.com/users/oroulet/gists{/gist_id}","starred_url":"https://api.github.com/users/oroulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oroulet/subscriptions","organizations_url":"https://api.github.com/users/oroulet/orgs","repos_url":"https://api.github.com/users/oroulet/repos","events_url":"https://api.github.com/users/oroulet/events{/privacy}","received_events_url":"https://api.github.com/users/oroulet/received_events","type":"User","site_admin":false},"body":"- [x] finish instantiate function\r\n- [x] add create_xxx_type functions (available through Node.add_xx_type)\r\n- [ ] remove add_subtype method (it creates a node using ObjectType attrtibutes but set node class to whatever.....)\r\n- [ ] use instantiate function inside create_xxx function OR let create_xxx function create nodes with arbitratry nodeclass/variable class without instanyiating(this is much faster and maybe desired)\r\n- [ ] update all examples \r\n- [ ] add tests\r\n- [ ] add create_reference_type function","created_at":"2016-07-13T06:58:13Z","updated_at":"2016-07-14T18:22:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb03c2b256b6d01a894eee35b994054a5894826e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/244/commits","review_comments_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/244/comments","review_comment_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/244/comments","statuses_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/statuses/c8d5e730b2e14b8583023b75df646b71884bfe9c","head":{"label":"FreeOpcUa:inst","ref":"inst","sha":"c8d5e730b2e14b8583023b75df646b71884bfe9c","user":{"login":"FreeOpcUa","id":7480453,"avatar_url":"https://avatars.githubusercontent.com/u/7480453?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeOpcUa","html_url":"https://github.com/FreeOpcUa","followers_url":"https://api.github.com/users/FreeOpcUa/followers","following_url":"https://api.github.com/users/FreeOpcUa/following{/other_user}","gists_url":"https://api.github.com/users/FreeOpcUa/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeOpcUa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeOpcUa/subscriptions","organizations_url":"https://api.github.com/users/FreeOpcUa/orgs","repos_url":"https://api.github.com/users/FreeOpcUa/repos","events_url":"https://api.github.com/users/FreeOpcUa/events{/privacy}","received_events_url":"https://api.github.com/users/FreeOpcUa/received_events","type":"Organization","site_admin":false},"repo":{"id":31074280,"name":"python-opcua","full_name":"FreeOpcUa/python-opcua","owner":{"login":"FreeOpcUa","id":7480453,"avatar_url":"https://avatars.githubusercontent.com/u/7480453?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeOpcUa","html_url":"https://github.com/FreeOpcUa","followers_url":"https://api.github.com/users/FreeOpcUa/followers","following_url":"https://api.github.com/users/FreeOpcUa/following{/other_user}","gists_url":"https://api.github.com/users/FreeOpcUa/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeOpcUa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeOpcUa/subscriptions","organizations_url":"https://api.github.com/users/FreeOpcUa/orgs","repos_url":"https://api.github.com/users/FreeOpcUa/repos","events_url":"https://api.github.com/users/FreeOpcUa/events{/privacy}","received_events_url":"https://api.github.com/users/FreeOpcUa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeOpcUa/python-opcua","description":"LGPL Pure Python OPC-UA Client and Server","fork":false,"url":"https://api.github.com/repos/FreeOpcUa/python-opcua","forks_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/forks","keys_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/teams","hooks_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/hooks","issue_events_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/events{/number}","events_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/events","assignees_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/assignees{/user}","branches_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/branches{/branch}","tags_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/tags","blobs_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/languages","stargazers_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/stargazers","contributors_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/contributors","subscribers_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/subscribers","subscription_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/subscription","commits_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/contents/{+path}","compare_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/merges","archive_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/downloads","issues_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues{/number}","pulls_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/labels{/name}","releases_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/releases{/id}","deployments_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/deployments","created_at":"2015-02-20T16:46:53Z","updated_at":"2016-07-13T17:03:48Z","pushed_at":"2016-07-14T18:21:16Z","git_url":"git://github.com/FreeOpcUa/python-opcua.git","ssh_url":"git@github.com:FreeOpcUa/python-opcua.git","clone_url":"https://github.com/FreeOpcUa/python-opcua.git","svn_url":"https://github.com/FreeOpcUa/python-opcua","homepage":"http://freeopcua.github.io/","size":3101,"stargazers_count":69,"watchers_count":69,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":24,"forks":40,"open_issues":24,"watchers":69,"default_branch":"master"}},"base":{"label":"FreeOpcUa:master","ref":"master","sha":"1df17a7713d34e4e65f1fce43b05197654207f86","user":{"login":"FreeOpcUa","id":7480453,"avatar_url":"https://avatars.githubusercontent.com/u/7480453?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeOpcUa","html_url":"https://github.com/FreeOpcUa","followers_url":"https://api.github.com/users/FreeOpcUa/followers","following_url":"https://api.github.com/users/FreeOpcUa/following{/other_user}","gists_url":"https://api.github.com/users/FreeOpcUa/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeOpcUa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeOpcUa/subscriptions","organizations_url":"https://api.github.com/users/FreeOpcUa/orgs","repos_url":"https://api.github.com/users/FreeOpcUa/repos","events_url":"https://api.github.com/users/FreeOpcUa/events{/privacy}","received_events_url":"https://api.github.com/users/FreeOpcUa/received_events","type":"Organization","site_admin":false},"repo":{"id":31074280,"name":"python-opcua","full_name":"FreeOpcUa/python-opcua","owner":{"login":"FreeOpcUa","id":7480453,"avatar_url":"https://avatars.githubusercontent.com/u/7480453?v=3","gravatar_id":"","url":"https://api.github.com/users/FreeOpcUa","html_url":"https://github.com/FreeOpcUa","followers_url":"https://api.github.com/users/FreeOpcUa/followers","following_url":"https://api.github.com/users/FreeOpcUa/following{/other_user}","gists_url":"https://api.github.com/users/FreeOpcUa/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeOpcUa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeOpcUa/subscriptions","organizations_url":"https://api.github.com/users/FreeOpcUa/orgs","repos_url":"https://api.github.com/users/FreeOpcUa/repos","events_url":"https://api.github.com/users/FreeOpcUa/events{/privacy}","received_events_url":"https://api.github.com/users/FreeOpcUa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeOpcUa/python-opcua","description":"LGPL Pure Python OPC-UA Client and Server","fork":false,"url":"https://api.github.com/repos/FreeOpcUa/python-opcua","forks_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/forks","keys_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/teams","hooks_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/hooks","issue_events_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/events{/number}","events_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/events","assignees_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/assignees{/user}","branches_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/branches{/branch}","tags_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/tags","blobs_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/languages","stargazers_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/stargazers","contributors_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/contributors","subscribers_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/subscribers","subscription_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/subscription","commits_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/contents/{+path}","compare_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/merges","archive_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/downloads","issues_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues{/number}","pulls_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/labels{/name}","releases_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/releases{/id}","deployments_url":"https://api.github.com/repos/FreeOpcUa/python-opcua/deployments","created_at":"2015-02-20T16:46:53Z","updated_at":"2016-07-13T17:03:48Z","pushed_at":"2016-07-14T18:21:16Z","git_url":"git://github.com/FreeOpcUa/python-opcua.git","ssh_url":"git@github.com:FreeOpcUa/python-opcua.git","clone_url":"https://github.com/FreeOpcUa/python-opcua.git","svn_url":"https://github.com/FreeOpcUa/python-opcua","homepage":"http://freeopcua.github.io/","size":3101,"stargazers_count":69,"watchers_count":69,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":24,"forks":40,"open_issues":24,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/244"},"html":{"href":"https://github.com/FreeOpcUa/python-opcua/pull/244"},"issue":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/244"},"comments":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/FreeOpcUa/python-opcua/statuses/c8d5e730b2e14b8583023b75df646b71884bfe9c"}}}}
{"actor":{"display_login":"oroulet"}}