{"action":"closed","number":11719,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11719","id":82146971,"html_url":"https://github.com/joomla/joomla-cms/pull/11719","diff_url":"https://github.com/joomla/joomla-cms/pull/11719.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/11719.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/11719","number":11719,"state":"closed","locked":false,"title":"[com_contact] Move event trigger to correct place","user":{"login":"nvyush","id":20832832,"avatar_url":"https://avatars.githubusercontent.com/u/20832832?v=3","gravatar_id":"","url":"https://api.github.com/users/nvyush","html_url":"https://github.com/nvyush","followers_url":"https://api.github.com/users/nvyush/followers","following_url":"https://api.github.com/users/nvyush/following{/other_user}","gists_url":"https://api.github.com/users/nvyush/gists{/gist_id}","starred_url":"https://api.github.com/users/nvyush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvyush/subscriptions","organizations_url":"https://api.github.com/users/nvyush/orgs","repos_url":"https://api.github.com/users/nvyush/repos","events_url":"https://api.github.com/users/nvyush/events{/privacy}","received_events_url":"https://api.github.com/users/nvyush/received_events","type":"User","site_admin":false},"body":"Pull Request for Issue # .\r\n\r\n### Summary of Changes\r\n1) Event trigger of the event `afterDisplayTitle` is in the wrong place — when option 'show_contact_category' is 'show_with_link' it triggers BEFORE of displaying the title.\r\n\r\n2) The option 'show_contact_category' can't be simultaneously 'show_no_link' and 'show_with_link', two `if` replaced with `if` - `elseif`.\r\n\r\n### Testing Instructions\r\n1) Create a test contact.\r\n2) Create test contact category, place test contacts to it.\r\n3) Create test menu item of type 'Contacts' - 'Single Contact' for the test contact.\r\n4) Set option 'Contact Display Options' - 'Contact Category' of the test menu item to value 'Show Without Link'. There must be no difference for page of test contact.\r\n5) Set option 'Contact Display Options' - 'Contact Category' of the test menu item to value 'Show With Link'. There must be no difference for page of test contact unless you use event `afterDisplayTitle`.\r\n\r\n### Documentation Changes Required\r\nNone","created_at":"2016-08-22T07:48:39Z","updated_at":"2016-08-25T20:31:42Z","closed_at":"2016-08-25T20:31:42Z","merged_at":"2016-08-25T20:31:42Z","merge_commit_sha":"c8a1b8aaadab6a7d4a1d6723e175b68bbbf77b38","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/16","html_url":"https://github.com/joomla/joomla-cms/milestones/Joomla%203.6.3","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/16/labels","id":1901872,"number":16,"title":"Joomla 3.6.3","description":"","creator":{"login":"wilsonge","id":1986000,"avatar_url":"https://avatars.githubusercontent.com/u/1986000?v=3","gravatar_id":"","url":"https://api.github.com/users/wilsonge","html_url":"https://github.com/wilsonge","followers_url":"https://api.github.com/users/wilsonge/followers","following_url":"https://api.github.com/users/wilsonge/following{/other_user}","gists_url":"https://api.github.com/users/wilsonge/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonge/subscriptions","organizations_url":"https://api.github.com/users/wilsonge/orgs","repos_url":"https://api.github.com/users/wilsonge/repos","events_url":"https://api.github.com/users/wilsonge/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonge/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":203,"state":"open","created_at":"2016-07-25T09:08:01Z","updated_at":"2016-08-25T20:31:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11719/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/11719/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/11719/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/be99007fe54f7e5d289d8fdd0f7a387a26c9d485","head":{"label":"nvyush:patch-2","ref":"patch-2","sha":"be99007fe54f7e5d289d8fdd0f7a387a26c9d485","user":{"login":"nvyush","id":20832832,"avatar_url":"https://avatars.githubusercontent.com/u/20832832?v=3","gravatar_id":"","url":"https://api.github.com/users/nvyush","html_url":"https://github.com/nvyush","followers_url":"https://api.github.com/users/nvyush/followers","following_url":"https://api.github.com/users/nvyush/following{/other_user}","gists_url":"https://api.github.com/users/nvyush/gists{/gist_id}","starred_url":"https://api.github.com/users/nvyush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvyush/subscriptions","organizations_url":"https://api.github.com/users/nvyush/orgs","repos_url":"https://api.github.com/users/nvyush/repos","events_url":"https://api.github.com/users/nvyush/events{/privacy}","received_events_url":"https://api.github.com/users/nvyush/received_events","type":"User","site_admin":false},"repo":{"id":65971626,"name":"joomla-cms","full_name":"nvyush/joomla-cms","owner":{"login":"nvyush","id":20832832,"avatar_url":"https://avatars.githubusercontent.com/u/20832832?v=3","gravatar_id":"","url":"https://api.github.com/users/nvyush","html_url":"https://github.com/nvyush","followers_url":"https://api.github.com/users/nvyush/followers","following_url":"https://api.github.com/users/nvyush/following{/other_user}","gists_url":"https://api.github.com/users/nvyush/gists{/gist_id}","starred_url":"https://api.github.com/users/nvyush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvyush/subscriptions","organizations_url":"https://api.github.com/users/nvyush/orgs","repos_url":"https://api.github.com/users/nvyush/repos","events_url":"https://api.github.com/users/nvyush/events{/privacy}","received_events_url":"https://api.github.com/users/nvyush/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nvyush/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/nvyush/joomla-cms","forks_url":"https://api.github.com/repos/nvyush/joomla-cms/forks","keys_url":"https://api.github.com/repos/nvyush/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nvyush/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nvyush/joomla-cms/teams","hooks_url":"https://api.github.com/repos/nvyush/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/nvyush/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/nvyush/joomla-cms/events","assignees_url":"https://api.github.com/repos/nvyush/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/nvyush/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/nvyush/joomla-cms/tags","blobs_url":"https://api.github.com/repos/nvyush/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nvyush/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nvyush/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/nvyush/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nvyush/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/nvyush/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/nvyush/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/nvyush/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/nvyush/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/nvyush/joomla-cms/subscription","commits_url":"https://api.github.com/repos/nvyush/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/nvyush/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/nvyush/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/nvyush/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/nvyush/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/nvyush/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nvyush/joomla-cms/merges","archive_url":"https://api.github.com/repos/nvyush/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nvyush/joomla-cms/downloads","issues_url":"https://api.github.com/repos/nvyush/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/nvyush/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/nvyush/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/nvyush/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nvyush/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/nvyush/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/nvyush/joomla-cms/deployments","created_at":"2016-08-18T06:35:22Z","updated_at":"2016-08-18T06:35:37Z","pushed_at":"2016-08-24T08:04:38Z","git_url":"git://github.com/nvyush/joomla-cms.git","ssh_url":"git@github.com:nvyush/joomla-cms.git","clone_url":"https://github.com/nvyush/joomla-cms.git","svn_url":"https://github.com/nvyush/joomla-cms","homepage":"https://www.joomla.org","size":155245,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"825890696267c9265d660c529ad21fe76bc8932d","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-08-25T19:07:07Z","pushed_at":"2016-08-25T20:31:43Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":291990,"stargazers_count":2122,"watchers_count":2122,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2278,"mirror_url":null,"open_issues_count":471,"forks":2278,"open_issues":471,"watchers":2122,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11719"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/11719"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/11719"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/11719/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11719/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/11719/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/be99007fe54f7e5d289d8fdd0f7a387a26c9d485"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rdeutz","id":467356,"avatar_url":"https://avatars.githubusercontent.com/u/467356?v=3","gravatar_id":"","url":"https://api.github.com/users/rdeutz","html_url":"https://github.com/rdeutz","followers_url":"https://api.github.com/users/rdeutz/followers","following_url":"https://api.github.com/users/rdeutz/following{/other_user}","gists_url":"https://api.github.com/users/rdeutz/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeutz/subscriptions","organizations_url":"https://api.github.com/users/rdeutz/orgs","repos_url":"https://api.github.com/users/rdeutz/repos","events_url":"https://api.github.com/users/rdeutz/events{/privacy}","received_events_url":"https://api.github.com/users/rdeutz/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":2,"additions":63,"deletions":93,"changed_files":1}}
{"actor":{"display_login":"rdeutz"}}