{"action":"created","comment":{"url":"https://api.github.com/repos/mholt/caddy/pulls/comments/75512358","id":75512358,"diff_hunk":"@@ -836,7 +839,7 @@ var (\n \tinstancesMu sync.Mutex\n )\n \n-const (\n+var (","path":"caddy.go","position":42,"original_position":42,"commit_id":"a609fa5f563be2837d7dbce59f1fc634402a0f9a","original_commit_id":"a609fa5f563be2837d7dbce59f1fc634402a0f9a","user":{"login":"miekg","id":353371,"avatar_url":"https://avatars.githubusercontent.com/u/353371?v=3","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"body":"[ Quoting <notifications@github.com> in \"Re: [mholt/caddy] Implement missing...\" ]\n>> @@ -836,7 +839,7 @@ var (\n>>  \tinstancesMu sync.Mutex\n>>  )\n>>\n>> -const (\n>> +var (\n>\n>Ohh, from your main function, not your plugin, I see... that should work. Okay.\n\nYep! :-) (sorry if that wasn't clear)\n","created_at":"2016-08-19T16:33:02Z","updated_at":"2016-08-19T16:33:02Z","html_url":"https://github.com/mholt/caddy/pull/1048#discussion_r75512358","pull_request_url":"https://api.github.com/repos/mholt/caddy/pulls/1048","_links":{"self":{"href":"https://api.github.com/repos/mholt/caddy/pulls/comments/75512358"},"html":{"href":"https://github.com/mholt/caddy/pull/1048#discussion_r75512358"},"pull_request":{"href":"https://api.github.com/repos/mholt/caddy/pulls/1048"}}},"pull_request":{"url":"https://api.github.com/repos/mholt/caddy/pulls/1048","id":81909526,"html_url":"https://github.com/mholt/caddy/pull/1048","diff_url":"https://github.com/mholt/caddy/pull/1048.diff","patch_url":"https://github.com/mholt/caddy/pull/1048.patch","issue_url":"https://api.github.com/repos/mholt/caddy/issues/1048","number":1048,"state":"open","locked":false,"title":"Implement missing bits for an external servertype","user":{"login":"miekg","id":353371,"avatar_url":"https://avatars.githubusercontent.com/u/353371?v=3","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"body":"Make ServerListeners public and add two helper methods to get access\r\nto the address they listen on. This is useful for tests (among other\r\nthings)\r\n\r\nAlso make DefaultConfigFile a var so it can be overridden by server\r\ntypes.","created_at":"2016-08-19T00:21:25Z","updated_at":"2016-08-19T16:33:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1777d485f88455bd4dd9a59616c8893ab8eff26e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mholt/caddy/pulls/1048/commits","review_comments_url":"https://api.github.com/repos/mholt/caddy/pulls/1048/comments","review_comment_url":"https://api.github.com/repos/mholt/caddy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mholt/caddy/issues/1048/comments","statuses_url":"https://api.github.com/repos/mholt/caddy/statuses/a609fa5f563be2837d7dbce59f1fc634402a0f9a","head":{"label":"miekg:missingbits","ref":"missingbits","sha":"a609fa5f563be2837d7dbce59f1fc634402a0f9a","user":{"login":"miekg","id":353371,"avatar_url":"https://avatars.githubusercontent.com/u/353371?v=3","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"repo":{"id":63529744,"name":"caddy","full_name":"miekg/caddy","owner":{"login":"miekg","id":353371,"avatar_url":"https://avatars.githubusercontent.com/u/353371?v=3","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miekg/caddy","description":"Fast, cross-platform HTTP/2 web server with automatic HTTPS","fork":true,"url":"https://api.github.com/repos/miekg/caddy","forks_url":"https://api.github.com/repos/miekg/caddy/forks","keys_url":"https://api.github.com/repos/miekg/caddy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miekg/caddy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miekg/caddy/teams","hooks_url":"https://api.github.com/repos/miekg/caddy/hooks","issue_events_url":"https://api.github.com/repos/miekg/caddy/issues/events{/number}","events_url":"https://api.github.com/repos/miekg/caddy/events","assignees_url":"https://api.github.com/repos/miekg/caddy/assignees{/user}","branches_url":"https://api.github.com/repos/miekg/caddy/branches{/branch}","tags_url":"https://api.github.com/repos/miekg/caddy/tags","blobs_url":"https://api.github.com/repos/miekg/caddy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miekg/caddy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miekg/caddy/git/refs{/sha}","trees_url":"https://api.github.com/repos/miekg/caddy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miekg/caddy/statuses/{sha}","languages_url":"https://api.github.com/repos/miekg/caddy/languages","stargazers_url":"https://api.github.com/repos/miekg/caddy/stargazers","contributors_url":"https://api.github.com/repos/miekg/caddy/contributors","subscribers_url":"https://api.github.com/repos/miekg/caddy/subscribers","subscription_url":"https://api.github.com/repos/miekg/caddy/subscription","commits_url":"https://api.github.com/repos/miekg/caddy/commits{/sha}","git_commits_url":"https://api.github.com/repos/miekg/caddy/git/commits{/sha}","comments_url":"https://api.github.com/repos/miekg/caddy/comments{/number}","issue_comment_url":"https://api.github.com/repos/miekg/caddy/issues/comments{/number}","contents_url":"https://api.github.com/repos/miekg/caddy/contents/{+path}","compare_url":"https://api.github.com/repos/miekg/caddy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miekg/caddy/merges","archive_url":"https://api.github.com/repos/miekg/caddy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miekg/caddy/downloads","issues_url":"https://api.github.com/repos/miekg/caddy/issues{/number}","pulls_url":"https://api.github.com/repos/miekg/caddy/pulls{/number}","milestones_url":"https://api.github.com/repos/miekg/caddy/milestones{/number}","notifications_url":"https://api.github.com/repos/miekg/caddy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miekg/caddy/labels{/name}","releases_url":"https://api.github.com/repos/miekg/caddy/releases{/id}","deployments_url":"https://api.github.com/repos/miekg/caddy/deployments","created_at":"2016-07-17T12:00:14Z","updated_at":"2016-07-17T12:00:17Z","pushed_at":"2016-08-19T00:21:05Z","git_url":"git://github.com/miekg/caddy.git","ssh_url":"git@github.com:miekg/caddy.git","clone_url":"https://github.com/miekg/caddy.git","svn_url":"https://github.com/miekg/caddy","homepage":"https://caddyserver.com","size":2094,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mholt:master","ref":"master","sha":"fdc62d015fd5c20e03143e2eea17528892270169","user":{"login":"mholt","id":1128849,"avatar_url":"https://avatars.githubusercontent.com/u/1128849?v=3","gravatar_id":"","url":"https://api.github.com/users/mholt","html_url":"https://github.com/mholt","followers_url":"https://api.github.com/users/mholt/followers","following_url":"https://api.github.com/users/mholt/following{/other_user}","gists_url":"https://api.github.com/users/mholt/gists{/gist_id}","starred_url":"https://api.github.com/users/mholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mholt/subscriptions","organizations_url":"https://api.github.com/users/mholt/orgs","repos_url":"https://api.github.com/users/mholt/repos","events_url":"https://api.github.com/users/mholt/events{/privacy}","received_events_url":"https://api.github.com/users/mholt/received_events","type":"User","site_admin":false},"repo":{"id":29207621,"name":"caddy","full_name":"mholt/caddy","owner":{"login":"mholt","id":1128849,"avatar_url":"https://avatars.githubusercontent.com/u/1128849?v=3","gravatar_id":"","url":"https://api.github.com/users/mholt","html_url":"https://github.com/mholt","followers_url":"https://api.github.com/users/mholt/followers","following_url":"https://api.github.com/users/mholt/following{/other_user}","gists_url":"https://api.github.com/users/mholt/gists{/gist_id}","starred_url":"https://api.github.com/users/mholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mholt/subscriptions","organizations_url":"https://api.github.com/users/mholt/orgs","repos_url":"https://api.github.com/users/mholt/repos","events_url":"https://api.github.com/users/mholt/events{/privacy}","received_events_url":"https://api.github.com/users/mholt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mholt/caddy","description":"Fast, cross-platform HTTP/2 web server with automatic HTTPS","fork":false,"url":"https://api.github.com/repos/mholt/caddy","forks_url":"https://api.github.com/repos/mholt/caddy/forks","keys_url":"https://api.github.com/repos/mholt/caddy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mholt/caddy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mholt/caddy/teams","hooks_url":"https://api.github.com/repos/mholt/caddy/hooks","issue_events_url":"https://api.github.com/repos/mholt/caddy/issues/events{/number}","events_url":"https://api.github.com/repos/mholt/caddy/events","assignees_url":"https://api.github.com/repos/mholt/caddy/assignees{/user}","branches_url":"https://api.github.com/repos/mholt/caddy/branches{/branch}","tags_url":"https://api.github.com/repos/mholt/caddy/tags","blobs_url":"https://api.github.com/repos/mholt/caddy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mholt/caddy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mholt/caddy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mholt/caddy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mholt/caddy/statuses/{sha}","languages_url":"https://api.github.com/repos/mholt/caddy/languages","stargazers_url":"https://api.github.com/repos/mholt/caddy/stargazers","contributors_url":"https://api.github.com/repos/mholt/caddy/contributors","subscribers_url":"https://api.github.com/repos/mholt/caddy/subscribers","subscription_url":"https://api.github.com/repos/mholt/caddy/subscription","commits_url":"https://api.github.com/repos/mholt/caddy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mholt/caddy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mholt/caddy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mholt/caddy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mholt/caddy/contents/{+path}","compare_url":"https://api.github.com/repos/mholt/caddy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mholt/caddy/merges","archive_url":"https://api.github.com/repos/mholt/caddy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mholt/caddy/downloads","issues_url":"https://api.github.com/repos/mholt/caddy/issues{/number}","pulls_url":"https://api.github.com/repos/mholt/caddy/pulls{/number}","milestones_url":"https://api.github.com/repos/mholt/caddy/milestones{/number}","notifications_url":"https://api.github.com/repos/mholt/caddy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mholt/caddy/labels{/name}","releases_url":"https://api.github.com/repos/mholt/caddy/releases{/id}","deployments_url":"https://api.github.com/repos/mholt/caddy/deployments","created_at":"2015-01-13T19:45:03Z","updated_at":"2016-08-19T16:26:56Z","pushed_at":"2016-08-19T05:18:57Z","git_url":"git://github.com/mholt/caddy.git","ssh_url":"git@github.com:mholt/caddy.git","clone_url":"https://github.com/mholt/caddy.git","svn_url":"https://github.com/mholt/caddy","homepage":"https://caddyserver.com","size":3436,"stargazers_count":7652,"watchers_count":7652,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":485,"mirror_url":null,"open_issues_count":49,"forks":485,"open_issues":49,"watchers":7652,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mholt/caddy/pulls/1048"},"html":{"href":"https://github.com/mholt/caddy/pull/1048"},"issue":{"href":"https://api.github.com/repos/mholt/caddy/issues/1048"},"comments":{"href":"https://api.github.com/repos/mholt/caddy/issues/1048/comments"},"review_comments":{"href":"https://api.github.com/repos/mholt/caddy/pulls/1048/comments"},"review_comment":{"href":"https://api.github.com/repos/mholt/caddy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mholt/caddy/pulls/1048/commits"},"statuses":{"href":"https://api.github.com/repos/mholt/caddy/statuses/a609fa5f563be2837d7dbce59f1fc634402a0f9a"}}}}
{"actor":{"display_login":"miekg"}}