{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/4813","labels_url":"https://api.github.com/repos/nodejs/node/issues/4813/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/4813/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/4813/events","html_url":"https://github.com/nodejs/node/pull/4813","id":128088860,"number":4813,"title":"Add arrow function rules to eslint","user":{"login":"cjihrig","id":2512748,"avatar_url":"https://avatars.githubusercontent.com/u/2512748?v=3","gravatar_id":"","url":"https://api.github.com/users/cjihrig","html_url":"https://github.com/cjihrig","followers_url":"https://api.github.com/users/cjihrig/followers","following_url":"https://api.github.com/users/cjihrig/following{/other_user}","gists_url":"https://api.github.com/users/cjihrig/gists{/gist_id}","starred_url":"https://api.github.com/users/cjihrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjihrig/subscriptions","organizations_url":"https://api.github.com/users/cjihrig/orgs","repos_url":"https://api.github.com/users/cjihrig/repos","events_url":"https://api.github.com/users/cjihrig/events{/privacy}","received_events_url":"https://api.github.com/users/cjihrig/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v4.x","name":"dont-land-on-v4.x","color":"fad8c7"},{"url":"https://api.github.com/repos/nodejs/node/labels/tools","name":"tools","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":21,"created_at":"2016-01-22T05:41:01Z","updated_at":"2016-01-23T06:04:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/4813","html_url":"https://github.com/nodejs/node/pull/4813","diff_url":"https://github.com/nodejs/node/pull/4813.diff","patch_url":"https://github.com/nodejs/node/pull/4813.patch"},"body":"This PR enforces the following linting rules:\r\n* arrow-parens - requires parens around arrow function arguments\r\n* arrow-spacing - ensures a space on each side of the =>\r\n* no-arrow-condition - prevents accidental use of => in cases\r\nwhere the user really intends to use <=\r\n\r\nThe only code that violated these rules existed in the `test` directory.\r\nR= @rvagg "},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/174152490","html_url":"https://github.com/nodejs/node/pull/4813#issuecomment-174152490","issue_url":"https://api.github.com/repos/nodejs/node/issues/4813","id":174152490,"user":{"login":"thefourtheye","id":696611,"avatar_url":"https://avatars.githubusercontent.com/u/696611?v=3","gravatar_id":"","url":"https://api.github.com/users/thefourtheye","html_url":"https://github.com/thefourtheye","followers_url":"https://api.github.com/users/thefourtheye/followers","following_url":"https://api.github.com/users/thefourtheye/following{/other_user}","gists_url":"https://api.github.com/users/thefourtheye/gists{/gist_id}","starred_url":"https://api.github.com/users/thefourtheye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefourtheye/subscriptions","organizations_url":"https://api.github.com/users/thefourtheye/orgs","repos_url":"https://api.github.com/users/thefourtheye/repos","events_url":"https://api.github.com/users/thefourtheye/events{/privacy}","received_events_url":"https://api.github.com/users/thefourtheye/received_events","type":"User","site_admin":false},"created_at":"2016-01-23T06:04:24Z","updated_at":"2016-01-23T06:04:24Z","body":"> not adding this rule shouldn't impact anything\r\n\r\nYes, but I am thinking of a very rare case. Let's say we land a fix which is specific to 4.x and if that doesn't follow this rule, then we will have two slightly different style systems and it wouldn't be consistent, right?"}}