{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/85929865","pull_request_review_id":6614325,"id":85929865,"diff_hunk":"@@ -38,68 +35,46 @@\n                 discussion = new window.Discussion(threads, {pages: threadPages, sort: sortPreference});\n                 courseSettings = new window.DiscussionCourseSettings(options.course_settings);\n \n-                // Create the new post view\n-                newPostView = new NewPostView({\n-                    el: $('.new-post-article'),\n-                    collection: discussion,\n-                    course_settings: courseSettings,\n-                    mode: 'tab'\n+                discussionBoardView = new DiscussionBoardView({\n+                    el: $('.discussion-board'),\n+                    discussion: discussion,\n+                    courseSettings: courseSettings\n                 });\n-                newPostView.render();\n \n                 // Set up the router to manage the page's history\n                 router = new DiscussionRouter({\n                     courseId: options.courseId,\n                     discussion: discussion,\n                     courseSettings: courseSettings,\n-                    newPostView: newPostView\n+                    discussionBoardView: discussionBoardView\n                 });\n-                router.start();\n \n-                // Initialize and render search box\n-                searchBox = new DiscussionSearchView({\n-                    el: $('.forum-search'),\n-                    threadListView: router.nav\n-                }).render();\n-\n-                // Initialize and render breadcrumbs\n-                BreadcrumbsModel = Backbone.Model.extend({\n-                    defaults: {\n-                        contents: []\n-                    }\n+                // Create the new post view\n+                newPostView = new NewPostView({\n+                    el: $('.new-post-article'),\n+                    collection: discussion,\n+                    course_settings: courseSettings,\n+                    mode: 'tab'\n                 });\n+                newPostView.render();\n+                router.newPostView = newPostView;","path":"lms/djangoapps/discussion/static/discussion/js/discussion_board_factory.js","position":72,"original_position":72,"commit_id":"a4646081b1501b648168a234443cb194aee47a27","original_commit_id":"a4646081b1501b648168a234443cb194aee47a27","user":{"login":"alisan617","id":16127998,"avatar_url":"https://avatars.githubusercontent.com/u/16127998?v=3","gravatar_id":"","url":"https://api.github.com/users/alisan617","html_url":"https://github.com/alisan617","followers_url":"https://api.github.com/users/alisan617/followers","following_url":"https://api.github.com/users/alisan617/following{/other_user}","gists_url":"https://api.github.com/users/alisan617/gists{/gist_id}","starred_url":"https://api.github.com/users/alisan617/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alisan617/subscriptions","organizations_url":"https://api.github.com/users/alisan617/orgs","repos_url":"https://api.github.com/users/alisan617/repos","events_url":"https://api.github.com/users/alisan617/events{/privacy}","received_events_url":"https://api.github.com/users/alisan617/received_events","type":"User","site_admin":false},"body":"@andy-armstrong This was my question yesterday. The new post view has to stick with router. Did I miss anything?","created_at":"2016-11-01T13:43:24Z","updated_at":"2016-11-01T13:43:24Z","html_url":"https://github.com/edx/edx-platform/pull/13843#discussion_r85929865","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/13843","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/85929865"},"html":{"href":"https://github.com/edx/edx-platform/pull/13843#discussion_r85929865"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13843"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/13843","id":91011854,"html_url":"https://github.com/edx/edx-platform/pull/13843","diff_url":"https://github.com/edx/edx-platform/pull/13843.diff","patch_url":"https://github.com/edx/edx-platform/pull/13843.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/13843","number":13843,"state":"open","locked":false,"title":"Separate discussion thread list view","user":{"login":"alisan617","id":16127998,"avatar_url":"https://avatars.githubusercontent.com/u/16127998?v=3","gravatar_id":"","url":"https://api.github.com/users/alisan617","html_url":"https://github.com/alisan617","followers_url":"https://api.github.com/users/alisan617/followers","following_url":"https://api.github.com/users/alisan617/following{/other_user}","gists_url":"https://api.github.com/users/alisan617/gists{/gist_id}","starred_url":"https://api.github.com/users/alisan617/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alisan617/subscriptions","organizations_url":"https://api.github.com/users/alisan617/orgs","repos_url":"https://api.github.com/users/alisan617/repos","events_url":"https://api.github.com/users/alisan617/events{/privacy}","received_events_url":"https://api.github.com/users/alisan617/received_events","type":"User","site_admin":false},"body":"[TNL-5669](https://openedx.atlassian.net/browse/TNL-5669)\n## Description\n- separate the all topics list in sidebar from the discussion thread list view, so that inline discussion can re-use the view in common.\n- new Discussion Board view has Home view, all topics view, breadcrumb, and search view.\n## Sandbox\n\n[https://alisan617.sandbox.edx.org/](https://alisan617.sandbox.edx.org/)\n## Reviewers\n- [ ] @andy-armstrong \n- [ ] @bjacobel \n","created_at":"2016-10-26T14:08:51Z","updated_at":"2016-11-01T13:43:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbee4feda7ee57ee44a995487c6edc4dc7a543d0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/13843/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/13843/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/13843/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/a4646081b1501b648168a234443cb194aee47a27","head":{"label":"edx:alisan/testing-discussion","ref":"alisan/testing-discussion","sha":"a4646081b1501b648168a234443cb194aee47a27","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-11-01T07:30:47Z","pushed_at":"2016-11-01T13:23:34Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":851896,"stargazers_count":2840,"watchers_count":2840,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1696,"mirror_url":null,"open_issues_count":152,"forks":1696,"open_issues":152,"watchers":2840,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"9d1e77e0289cd6128f77f6a2aff44048fae37083","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-11-01T07:30:47Z","pushed_at":"2016-11-01T13:23:34Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":851896,"stargazers_count":2840,"watchers_count":2840,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1696,"mirror_url":null,"open_issues_count":152,"forks":1696,"open_issues":152,"watchers":2840,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13843"},"html":{"href":"https://github.com/edx/edx-platform/pull/13843"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/13843"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/13843/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13843/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13843/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/a4646081b1501b648168a234443cb194aee47a27"}}}}
{"actor":{"display_login":"alisan617"}}