{"action":"created","comment":{"url":"https://api.github.com/repos/ably/ably-ios/pulls/comments/74996950","id":74996950,"diff_hunk":"@@ -832,7 +832,22 @@ class RestClient: QuickSpec {\n                 let object = try! NSJSONSerialization.JSONObjectWithData(transport.rawDataSent.first!, options: NSJSONReadingOptions(rawValue: 0))\n                 expect(NSJSONSerialization.isValidJSONObject(object)).to(beTrue())\n             }\n-\n+            \n+            // RSC7b\n+            it(\"X-Ably-Lib: [lib][.optional variant]?-[version] should be included in all REST requests\") {\n+                let client = ARTRest(options: AblyTests.commonAppSetup())\n+                client.httpExecutor = testHTTPExecutor\n+                let channel = client.channels.get(\"test\")\n+                waitUntil(timeout: testTimeout) { done in\n+                    channel.publish(nil, data: \"message\") { error in\n+                        expect(error).to(beNil())\n+                        let headerLibVersion = testHTTPExecutor.requests.first!.allHTTPHeaderFields?[\"X-Ably-Lib\"]\n+                        let ablyBundleLibVersion = ARTDefault.libraryVersion()\n+                        expect(headerLibVersion).to(equal(ablyBundleLibVersion))","path":"Spec/RestClient.swift","position":16,"original_position":16,"commit_id":"a4e3774951a0fa909386fdeb60a3b52a39d44b0f","original_commit_id":"a4e3774951a0fa909386fdeb60a3b52a39d44b0f","user":{"login":"mattheworiordan","id":43789,"avatar_url":"https://avatars.githubusercontent.com/u/43789?v=3","gravatar_id":"","url":"https://api.github.com/users/mattheworiordan","html_url":"https://github.com/mattheworiordan","followers_url":"https://api.github.com/users/mattheworiordan/followers","following_url":"https://api.github.com/users/mattheworiordan/following{/other_user}","gists_url":"https://api.github.com/users/mattheworiordan/gists{/gist_id}","starred_url":"https://api.github.com/users/mattheworiordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattheworiordan/subscriptions","organizations_url":"https://api.github.com/users/mattheworiordan/orgs","repos_url":"https://api.github.com/users/mattheworiordan/repos","events_url":"https://api.github.com/users/mattheworiordan/events{/privacy}","received_events_url":"https://api.github.com/users/mattheworiordan/received_events","type":"User","site_admin":false},"body":"Whilst I understand that you don't necessarily want the the test to change for every time a version changes, it does feel like this test needs to be a bit more verbose i.e. can it not at least check that the header matches `ios-0.8.*` for example?  It just means the test confirms what we expect as opposed to simply referencing another part of the internals of the lib.  ","created_at":"2016-08-16T18:50:10Z","updated_at":"2016-08-16T18:50:10Z","html_url":"https://github.com/ably/ably-ios/pull/464#discussion_r74996950","pull_request_url":"https://api.github.com/repos/ably/ably-ios/pulls/464","_links":{"self":{"href":"https://api.github.com/repos/ably/ably-ios/pulls/comments/74996950"},"html":{"href":"https://github.com/ably/ably-ios/pull/464#discussion_r74996950"},"pull_request":{"href":"https://api.github.com/repos/ably/ably-ios/pulls/464"}}},"pull_request":{"url":"https://api.github.com/repos/ably/ably-ios/pulls/464","id":81521572,"html_url":"https://github.com/ably/ably-ios/pull/464","diff_url":"https://github.com/ably/ably-ios/pull/464.diff","patch_url":"https://github.com/ably/ably-ios/pull/464.patch","issue_url":"https://api.github.com/repos/ably/ably-ios/issues/464","number":464,"state":"open","locked":false,"title":"Rsc7b","user":{"login":"EvgenyKarkan","id":2069158,"avatar_url":"https://avatars.githubusercontent.com/u/2069158?v=3","gravatar_id":"","url":"https://api.github.com/users/EvgenyKarkan","html_url":"https://github.com/EvgenyKarkan","followers_url":"https://api.github.com/users/EvgenyKarkan/followers","following_url":"https://api.github.com/users/EvgenyKarkan/following{/other_user}","gists_url":"https://api.github.com/users/EvgenyKarkan/gists{/gist_id}","starred_url":"https://api.github.com/users/EvgenyKarkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EvgenyKarkan/subscriptions","organizations_url":"https://api.github.com/users/EvgenyKarkan/orgs","repos_url":"https://api.github.com/users/EvgenyKarkan/repos","events_url":"https://api.github.com/users/EvgenyKarkan/events{/privacy}","received_events_url":"https://api.github.com/users/EvgenyKarkan/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-16T18:33:40Z","updated_at":"2016-08-16T18:50:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36f38395411218920411b4eaf307fd966d3edb62","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ably/ably-ios/pulls/464/commits","review_comments_url":"https://api.github.com/repos/ably/ably-ios/pulls/464/comments","review_comment_url":"https://api.github.com/repos/ably/ably-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ably/ably-ios/issues/464/comments","statuses_url":"https://api.github.com/repos/ably/ably-ios/statuses/a4e3774951a0fa909386fdeb60a3b52a39d44b0f","head":{"label":"EvgenyKarkan:RSC7b","ref":"RSC7b","sha":"a4e3774951a0fa909386fdeb60a3b52a39d44b0f","user":{"login":"EvgenyKarkan","id":2069158,"avatar_url":"https://avatars.githubusercontent.com/u/2069158?v=3","gravatar_id":"","url":"https://api.github.com/users/EvgenyKarkan","html_url":"https://github.com/EvgenyKarkan","followers_url":"https://api.github.com/users/EvgenyKarkan/followers","following_url":"https://api.github.com/users/EvgenyKarkan/following{/other_user}","gists_url":"https://api.github.com/users/EvgenyKarkan/gists{/gist_id}","starred_url":"https://api.github.com/users/EvgenyKarkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EvgenyKarkan/subscriptions","organizations_url":"https://api.github.com/users/EvgenyKarkan/orgs","repos_url":"https://api.github.com/users/EvgenyKarkan/repos","events_url":"https://api.github.com/users/EvgenyKarkan/events{/privacy}","received_events_url":"https://api.github.com/users/EvgenyKarkan/received_events","type":"User","site_admin":false},"repo":{"id":65799289,"name":"ably-ios","full_name":"EvgenyKarkan/ably-ios","owner":{"login":"EvgenyKarkan","id":2069158,"avatar_url":"https://avatars.githubusercontent.com/u/2069158?v=3","gravatar_id":"","url":"https://api.github.com/users/EvgenyKarkan","html_url":"https://github.com/EvgenyKarkan","followers_url":"https://api.github.com/users/EvgenyKarkan/followers","following_url":"https://api.github.com/users/EvgenyKarkan/following{/other_user}","gists_url":"https://api.github.com/users/EvgenyKarkan/gists{/gist_id}","starred_url":"https://api.github.com/users/EvgenyKarkan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EvgenyKarkan/subscriptions","organizations_url":"https://api.github.com/users/EvgenyKarkan/orgs","repos_url":"https://api.github.com/users/EvgenyKarkan/repos","events_url":"https://api.github.com/users/EvgenyKarkan/events{/privacy}","received_events_url":"https://api.github.com/users/EvgenyKarkan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EvgenyKarkan/ably-ios","description":"iOS Objective-C client for Ably real-time messaging service","fork":true,"url":"https://api.github.com/repos/EvgenyKarkan/ably-ios","forks_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/forks","keys_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/teams","hooks_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/hooks","issue_events_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/issues/events{/number}","events_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/events","assignees_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/assignees{/user}","branches_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/branches{/branch}","tags_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/tags","blobs_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/languages","stargazers_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/stargazers","contributors_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/contributors","subscribers_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/subscribers","subscription_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/subscription","commits_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/contents/{+path}","compare_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/merges","archive_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/downloads","issues_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/issues{/number}","pulls_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/labels{/name}","releases_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/releases{/id}","deployments_url":"https://api.github.com/repos/EvgenyKarkan/ably-ios/deployments","created_at":"2016-08-16T07:50:42Z","updated_at":"2016-08-16T07:50:44Z","pushed_at":"2016-08-16T14:51:33Z","git_url":"git://github.com/EvgenyKarkan/ably-ios.git","ssh_url":"git@github.com:EvgenyKarkan/ably-ios.git","clone_url":"https://github.com/EvgenyKarkan/ably-ios.git","svn_url":"https://github.com/EvgenyKarkan/ably-ios","homepage":null,"size":2401,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ably:master","ref":"master","sha":"c68bcb60e9c05210b410259934585e7d971c9232","user":{"login":"ably","id":1859245,"avatar_url":"https://avatars.githubusercontent.com/u/1859245?v=3","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"repo":{"id":27377471,"name":"ably-ios","full_name":"ably/ably-ios","owner":{"login":"ably","id":1859245,"avatar_url":"https://avatars.githubusercontent.com/u/1859245?v=3","gravatar_id":"","url":"https://api.github.com/users/ably","html_url":"https://github.com/ably","followers_url":"https://api.github.com/users/ably/followers","following_url":"https://api.github.com/users/ably/following{/other_user}","gists_url":"https://api.github.com/users/ably/gists{/gist_id}","starred_url":"https://api.github.com/users/ably/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably/subscriptions","organizations_url":"https://api.github.com/users/ably/orgs","repos_url":"https://api.github.com/users/ably/repos","events_url":"https://api.github.com/users/ably/events{/privacy}","received_events_url":"https://api.github.com/users/ably/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ably/ably-ios","description":"iOS Objective-C client for Ably real-time messaging service","fork":false,"url":"https://api.github.com/repos/ably/ably-ios","forks_url":"https://api.github.com/repos/ably/ably-ios/forks","keys_url":"https://api.github.com/repos/ably/ably-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ably/ably-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ably/ably-ios/teams","hooks_url":"https://api.github.com/repos/ably/ably-ios/hooks","issue_events_url":"https://api.github.com/repos/ably/ably-ios/issues/events{/number}","events_url":"https://api.github.com/repos/ably/ably-ios/events","assignees_url":"https://api.github.com/repos/ably/ably-ios/assignees{/user}","branches_url":"https://api.github.com/repos/ably/ably-ios/branches{/branch}","tags_url":"https://api.github.com/repos/ably/ably-ios/tags","blobs_url":"https://api.github.com/repos/ably/ably-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ably/ably-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ably/ably-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/ably/ably-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ably/ably-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/ably/ably-ios/languages","stargazers_url":"https://api.github.com/repos/ably/ably-ios/stargazers","contributors_url":"https://api.github.com/repos/ably/ably-ios/contributors","subscribers_url":"https://api.github.com/repos/ably/ably-ios/subscribers","subscription_url":"https://api.github.com/repos/ably/ably-ios/subscription","commits_url":"https://api.github.com/repos/ably/ably-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/ably/ably-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/ably/ably-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/ably/ably-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/ably/ably-ios/contents/{+path}","compare_url":"https://api.github.com/repos/ably/ably-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ably/ably-ios/merges","archive_url":"https://api.github.com/repos/ably/ably-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ably/ably-ios/downloads","issues_url":"https://api.github.com/repos/ably/ably-ios/issues{/number}","pulls_url":"https://api.github.com/repos/ably/ably-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/ably/ably-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/ably/ably-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ably/ably-ios/labels{/name}","releases_url":"https://api.github.com/repos/ably/ably-ios/releases{/id}","deployments_url":"https://api.github.com/repos/ably/ably-ios/deployments","created_at":"2014-12-01T12:00:37Z","updated_at":"2016-08-16T15:13:33Z","pushed_at":"2016-08-16T18:34:31Z","git_url":"git://github.com/ably/ably-ios.git","ssh_url":"git@github.com:ably/ably-ios.git","clone_url":"https://github.com/ably/ably-ios.git","svn_url":"https://github.com/ably/ably-ios","homepage":null,"size":2976,"stargazers_count":2,"watchers_count":2,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":24,"forks":8,"open_issues":24,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ably/ably-ios/pulls/464"},"html":{"href":"https://github.com/ably/ably-ios/pull/464"},"issue":{"href":"https://api.github.com/repos/ably/ably-ios/issues/464"},"comments":{"href":"https://api.github.com/repos/ably/ably-ios/issues/464/comments"},"review_comments":{"href":"https://api.github.com/repos/ably/ably-ios/pulls/464/comments"},"review_comment":{"href":"https://api.github.com/repos/ably/ably-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ably/ably-ios/pulls/464/commits"},"statuses":{"href":"https://api.github.com/repos/ably/ably-ios/statuses/a4e3774951a0fa909386fdeb60a3b52a39d44b0f"}}}}
{"actor":{"display_login":"mattheworiordan"}}