{"action":"closed","number":3833,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/3833","id":79263111,"html_url":"https://github.com/apple/swift/pull/3833","diff_url":"https://github.com/apple/swift/pull/3833.diff","patch_url":"https://github.com/apple/swift/pull/3833.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/3833","number":3833,"state":"closed","locked":false,"title":"[SILGen] Directly silgen access of #dsohandle","user":{"login":"bitjammer","id":693829,"avatar_url":"https://avatars.githubusercontent.com/u/693829?v=3","gravatar_id":"","url":"https://api.github.com/users/bitjammer","html_url":"https://github.com/bitjammer","followers_url":"https://api.github.com/users/bitjammer/followers","following_url":"https://api.github.com/users/bitjammer/following{/other_user}","gists_url":"https://api.github.com/users/bitjammer/gists{/gist_id}","starred_url":"https://api.github.com/users/bitjammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitjammer/subscriptions","organizations_url":"https://api.github.com/users/bitjammer/orgs","repos_url":"https://api.github.com/users/bitjammer/repos","events_url":"https://api.github.com/users/bitjammer/events{/privacy}","received_events_url":"https://api.github.com/users/bitjammer/received_events","type":"User","site_admin":false},"body":"Synthesizing a VarDecl for #dsohandle causes some unwanted accessors to\r\nbe expected, but we really don't need them: this is a global variable\r\nfor the start of the image. There are only two uses of getDSOHandle:\r\ngetting the type and emitting the SIL for it. Rather than perform\r\nacrobatics to turn off switches, just emit access directly where it's\r\nneeded.\r\n\r\nrdar://problem/26565092","created_at":"2016-07-28T20:31:22Z","updated_at":"2016-07-29T22:55:32Z","closed_at":"2016-07-29T22:55:32Z","merged_at":"2016-07-29T22:55:32Z","merge_commit_sha":"3034b0139c39b10154966a62a1f11eedcb08b4f1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/3833/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/3833/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/3833/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/1d075adfb7cab17eeca395e70f69178db0620b19","head":{"label":"bitjammer:dsohandle-multi-file-26565092","ref":"dsohandle-multi-file-26565092","sha":"1d075adfb7cab17eeca395e70f69178db0620b19","user":{"login":"bitjammer","id":693829,"avatar_url":"https://avatars.githubusercontent.com/u/693829?v=3","gravatar_id":"","url":"https://api.github.com/users/bitjammer","html_url":"https://github.com/bitjammer","followers_url":"https://api.github.com/users/bitjammer/followers","following_url":"https://api.github.com/users/bitjammer/following{/other_user}","gists_url":"https://api.github.com/users/bitjammer/gists{/gist_id}","starred_url":"https://api.github.com/users/bitjammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitjammer/subscriptions","organizations_url":"https://api.github.com/users/bitjammer/orgs","repos_url":"https://api.github.com/users/bitjammer/repos","events_url":"https://api.github.com/users/bitjammer/events{/privacy}","received_events_url":"https://api.github.com/users/bitjammer/received_events","type":"User","site_admin":false},"repo":{"id":47589068,"name":"swift","full_name":"bitjammer/swift","owner":{"login":"bitjammer","id":693829,"avatar_url":"https://avatars.githubusercontent.com/u/693829?v=3","gravatar_id":"","url":"https://api.github.com/users/bitjammer","html_url":"https://github.com/bitjammer","followers_url":"https://api.github.com/users/bitjammer/followers","following_url":"https://api.github.com/users/bitjammer/following{/other_user}","gists_url":"https://api.github.com/users/bitjammer/gists{/gist_id}","starred_url":"https://api.github.com/users/bitjammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitjammer/subscriptions","organizations_url":"https://api.github.com/users/bitjammer/orgs","repos_url":"https://api.github.com/users/bitjammer/repos","events_url":"https://api.github.com/users/bitjammer/events{/privacy}","received_events_url":"https://api.github.com/users/bitjammer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bitjammer/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/bitjammer/swift","forks_url":"https://api.github.com/repos/bitjammer/swift/forks","keys_url":"https://api.github.com/repos/bitjammer/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitjammer/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitjammer/swift/teams","hooks_url":"https://api.github.com/repos/bitjammer/swift/hooks","issue_events_url":"https://api.github.com/repos/bitjammer/swift/issues/events{/number}","events_url":"https://api.github.com/repos/bitjammer/swift/events","assignees_url":"https://api.github.com/repos/bitjammer/swift/assignees{/user}","branches_url":"https://api.github.com/repos/bitjammer/swift/branches{/branch}","tags_url":"https://api.github.com/repos/bitjammer/swift/tags","blobs_url":"https://api.github.com/repos/bitjammer/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitjammer/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitjammer/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitjammer/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitjammer/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/bitjammer/swift/languages","stargazers_url":"https://api.github.com/repos/bitjammer/swift/stargazers","contributors_url":"https://api.github.com/repos/bitjammer/swift/contributors","subscribers_url":"https://api.github.com/repos/bitjammer/swift/subscribers","subscription_url":"https://api.github.com/repos/bitjammer/swift/subscription","commits_url":"https://api.github.com/repos/bitjammer/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitjammer/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitjammer/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitjammer/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitjammer/swift/contents/{+path}","compare_url":"https://api.github.com/repos/bitjammer/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitjammer/swift/merges","archive_url":"https://api.github.com/repos/bitjammer/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitjammer/swift/downloads","issues_url":"https://api.github.com/repos/bitjammer/swift/issues{/number}","pulls_url":"https://api.github.com/repos/bitjammer/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/bitjammer/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/bitjammer/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitjammer/swift/labels{/name}","releases_url":"https://api.github.com/repos/bitjammer/swift/releases{/id}","deployments_url":"https://api.github.com/repos/bitjammer/swift/deployments","created_at":"2015-12-08T00:54:04Z","updated_at":"2015-12-08T00:54:21Z","pushed_at":"2016-07-29T21:38:02Z","git_url":"git://github.com/bitjammer/swift.git","ssh_url":"git@github.com:bitjammer/swift.git","clone_url":"https://github.com/bitjammer/swift.git","svn_url":"https://github.com/bitjammer/swift","homepage":"","size":106958,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"136c8d4f853fa59253984603bfd06b78d929cb1a","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-07-29T22:14:04Z","pushed_at":"2016-07-29T22:55:31Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":166998,"stargazers_count":32682,"watchers_count":32682,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4553,"mirror_url":null,"open_issues_count":91,"forks":4553,"open_issues":91,"watchers":32682,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/3833"},"html":{"href":"https://github.com/apple/swift/pull/3833"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/3833"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/3833/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/3833/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/3833/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/1d075adfb7cab17eeca395e70f69178db0620b19"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bitjammer","id":693829,"avatar_url":"https://avatars.githubusercontent.com/u/693829?v=3","gravatar_id":"","url":"https://api.github.com/users/bitjammer","html_url":"https://github.com/bitjammer","followers_url":"https://api.github.com/users/bitjammer/followers","following_url":"https://api.github.com/users/bitjammer/following{/other_user}","gists_url":"https://api.github.com/users/bitjammer/gists{/gist_id}","starred_url":"https://api.github.com/users/bitjammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitjammer/subscriptions","organizations_url":"https://api.github.com/users/bitjammer/orgs","repos_url":"https://api.github.com/users/bitjammer/repos","events_url":"https://api.github.com/users/bitjammer/events{/privacy}","received_events_url":"https://api.github.com/users/bitjammer/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":2,"additions":68,"deletions":39,"changed_files":9}}
{"actor":{"display_login":"bitjammer"}}