{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/32523","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/32523/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/32523/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/32523/events","html_url":"https://github.com/kubernetes/kubernetes/pull/32523","id":176489817,"number":32523,"title":"Use scale subresource","user":{"login":"fraenkel","id":929377,"avatar_url":"https://avatars.githubusercontent.com/u/929377?v=3","gravatar_id":"","url":"https://api.github.com/users/fraenkel","html_url":"https://github.com/fraenkel","followers_url":"https://api.github.com/users/fraenkel/followers","following_url":"https://api.github.com/users/fraenkel/following{/other_user}","gists_url":"https://api.github.com/users/fraenkel/gists{/gist_id}","starred_url":"https://api.github.com/users/fraenkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fraenkel/subscriptions","organizations_url":"https://api.github.com/users/fraenkel/orgs","repos_url":"https://api.github.com/users/fraenkel/repos","events_url":"https://api.github.com/users/fraenkel/events{/privacy}","received_events_url":"https://api.github.com/users/fraenkel/received_events","type":"User","site_admin":false},"labels":[{"id":176978828,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf","default":false},{"id":240247879,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-rebase","name":"needs-rebase","color":"BDBDBD","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253451057,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"assignees":[{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"milestone":null,"comments":15,"created_at":"2016-09-12T21:29:24Z","updated_at":"2016-12-05T14:13:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/32523","html_url":"https://github.com/kubernetes/kubernetes/pull/32523","diff_url":"https://github.com/kubernetes/kubernetes/pull/32523.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/32523.patch"},"body":"fixes #29698\n\nThis has one additional fix from the previous change which is to return the new version after the scale.\nSince I cannot see the actual error from the failure it is hard to say what went wrong.\n\n<!-- Reviewable:start -->\n\n---\n\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/32523)\n\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/264863855","html_url":"https://github.com/kubernetes/kubernetes/pull/32523#issuecomment-264863855","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/32523","id":264863855,"user":{"login":"fraenkel","id":929377,"avatar_url":"https://avatars.githubusercontent.com/u/929377?v=3","gravatar_id":"","url":"https://api.github.com/users/fraenkel","html_url":"https://github.com/fraenkel","followers_url":"https://api.github.com/users/fraenkel/followers","following_url":"https://api.github.com/users/fraenkel/following{/other_user}","gists_url":"https://api.github.com/users/fraenkel/gists{/gist_id}","starred_url":"https://api.github.com/users/fraenkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fraenkel/subscriptions","organizations_url":"https://api.github.com/users/fraenkel/orgs","repos_url":"https://api.github.com/users/fraenkel/repos","events_url":"https://api.github.com/users/fraenkel/events{/privacy}","received_events_url":"https://api.github.com/users/fraenkel/received_events","type":"User","site_admin":false},"created_at":"2016-12-05T14:13:51Z","updated_at":"2016-12-05T14:13:51Z","body":"We are back to the same original issue above with regards to subresources.\r\n\r\n```\r\n--- FAIL: TestReplicationControllerScaleRetry (0.00s)\r\npanic: interface conversion: runtime.Object is *api.ReplicationController, not *extensions.Scale [recovered]\r\n\tpanic: interface conversion: runtime.Object is *api.ReplicationController, not *extensions.Scale\r\n\r\ngoroutine 275 [running]:\r\npanic(0x1177aa0, 0xc420588200)\r\n\t/usr/local/Cellar/go/1.7.4/libexec/src/runtime/panic.go:500 +0x1a1\r\ntesting.tRunner.func1(0xc4208fee40)\r\n\t/usr/local/Cellar/go/1.7.4/libexec/src/testing/testing.go:579 +0x25d\r\npanic(0x1177aa0, 0xc420588200)\r\n\t/usr/local/Cellar/go/1.7.4/libexec/src/runtime/panic.go:458 +0x243\r\nk8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/typed/extensions/internalversion/fake.(*FakeScales).Get(0xc420899680, 0x13177e2, 0x15, 0x1302479, 0x6, 0x1bc8a40, 0xc420899680, 0xc4207de370)\r\n\t/Users/fraenkel/go/src/k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/typed/extensions/internalversion/fake/fake_scale_expansion.go:33 +0x254\r\nk8s.io/kubernetes/pkg/kubectl.(*ErrorScales).Get(0xc4208996a0, 0x13177e2, 0x15, 0x1302479, 0x6, 0x0, 0x2165c50, 0xc4208f8e10)\r\n\t<autogenerated>:717 +0x75\r\nk8s.io/kubernetes/pkg/kubectl.(*ReplicationControllerScaler).ScaleSimple(0xc420899640, 0x1303ab9, 0x7, 0x1302479, 0x6, 0xc420899660, 0x3, 0x2100000, 0x0, 0x0, ...)\r\n\t/Users/fraenkel/go/src/k8s.io/kubernetes/pkg/kubectl/scale.go:171 +0xb0\r\nk8s.io/kubernetes/pkg/kubectl.ScaleCondition.func1(0x1bc8f40, 0xc420899640, 0xc420899660)\r\n\t/Users/fraenkel/go/src/k8s.io/kubernetes/pkg/kubectl/scale.go:123 +0x80\r\nk8s.io/kubernetes/pkg/kubectl.TestReplicationControllerScaleRetry(0xc4208fee40)\r\n\t/Users/fraenkel/go/src/k8s.io/kubernetes/pkg/kubectl/scale_test.go:84 +0x2fa\r\n```"}}
{"actor":{"display_login":"fraenkel"}}