{"action":"created","comment":{"url":"https://api.github.com/repos/wmde/MultiFeed/pulls/comments/53923647","id":53923647,"diff_hunk":"@@ -0,0 +1,237 @@\n+<?php namespace App\\Tests;\n+\n+use App\\ItemFactory;\n+\n+/**\n+ * @SuppressWarnings(PHPMD.StaticAccess)\n+ */\n+class ItemFactoryTest extends \\PHPUnit_Framework_TestCase\n+{\n+\n+\tprivate function createSimplePieItemStub( $categories, $authors, $enclosures ) {\n+\t\t$methods = [\n+\t\t\t'get_title',\n+\t\t\t'get_link',\n+\t\t\t'get_description',\n+\t\t\t'get_id',\n+\t\t\t'get_date',\n+\t\t\t'get_categories',\n+\t\t\t'get_authors',\n+\t\t\t'get_enclosures'\n+\t\t];\n+\n+\t\t$feedStub = $this->getMockBuilder( 'SimplePie' )\n+\t\t\t->getMock();\n+\n+\t\t$stub = $this->getMockBuilder( 'SimplePie_Item' )\n+\t\t\t->setMethods( $methods )\n+\t\t\t->setConstructorArgs( [$feedStub, []] )\n+\t\t\t->getMock();\n+\n+\t\t$stub->method( 'get_categories' )\n+\t\t\t->willReturn( $categories );\n+\n+\t\t$stub->method( 'get_authors' )\n+\t\t\t->willReturn( $authors );\n+\n+\t\t$stub->method( 'get_enclosures' )\n+\t\t\t->willReturn( $enclosures );\n+\n+\t\treturn $stub;\n+\t}\n+\n+\tprivate function createSimplePieCategoryStub( $term ) {\n+\t\t$stub = $this->getMockBuilder( 'SimplePie_Category' )\n+\t\t\t->setMethods( ['get_term'] )\n+\t\t\t->getMock();\n+\n+\t\t$stub->method( 'get_term' )\n+\t\t\t->willReturn($term);","path":"tests/ItemFactoryTest.php","position":49,"original_position":49,"commit_id":"2b8317ca9a4566811d5a5ed0f7f3587aed3ed323","original_commit_id":"2b8317ca9a4566811d5a5ed0f7f3587aed3ed323","user":{"login":"manicki","id":3524114,"avatar_url":"https://avatars.githubusercontent.com/u/3524114?v=3","gravatar_id":"","url":"https://api.github.com/users/manicki","html_url":"https://github.com/manicki","followers_url":"https://api.github.com/users/manicki/followers","following_url":"https://api.github.com/users/manicki/following{/other_user}","gists_url":"https://api.github.com/users/manicki/gists{/gist_id}","starred_url":"https://api.github.com/users/manicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manicki/subscriptions","organizations_url":"https://api.github.com/users/manicki/orgs","repos_url":"https://api.github.com/users/manicki/repos","events_url":"https://api.github.com/users/manicki/events{/privacy}","received_events_url":"https://api.github.com/users/manicki/received_events","type":"User","site_admin":false},"body":"spaces inside brackets missing","created_at":"2016-02-24T11:08:27Z","updated_at":"2016-02-24T11:08:27Z","html_url":"https://github.com/wmde/MultiFeed/pull/4#discussion_r53923647","pull_request_url":"https://api.github.com/repos/wmde/MultiFeed/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/wmde/MultiFeed/pulls/comments/53923647"},"html":{"href":"https://github.com/wmde/MultiFeed/pull/4#discussion_r53923647"},"pull_request":{"href":"https://api.github.com/repos/wmde/MultiFeed/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/wmde/MultiFeed/pulls/4","id":60367484,"html_url":"https://github.com/wmde/MultiFeed/pull/4","diff_url":"https://github.com/wmde/MultiFeed/pull/4.diff","patch_url":"https://github.com/wmde/MultiFeed/pull/4.patch","issue_url":"https://api.github.com/repos/wmde/MultiFeed/issues/4","number":4,"state":"open","locked":false,"title":"Add MultiFeed, ItemFactory","user":{"login":"inyono","id":1508477,"avatar_url":"https://avatars.githubusercontent.com/u/1508477?v=3","gravatar_id":"","url":"https://api.github.com/users/inyono","html_url":"https://github.com/inyono","followers_url":"https://api.github.com/users/inyono/followers","following_url":"https://api.github.com/users/inyono/following{/other_user}","gists_url":"https://api.github.com/users/inyono/gists{/gist_id}","starred_url":"https://api.github.com/users/inyono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inyono/subscriptions","organizations_url":"https://api.github.com/users/inyono/orgs","repos_url":"https://api.github.com/users/inyono/repos","events_url":"https://api.github.com/users/inyono/events{/privacy}","received_events_url":"https://api.github.com/users/inyono/received_events","type":"User","site_admin":false},"body":"@manicki. Adds the working code from yesterday including tests and adapted coding style.\r\n\r\nSome open things:\r\n* #2. If we have the add the correct one, the code probably needs some reworking to comply those.\r\n* #3. Currently `phpmd` throws one warning about the complexity of `ItemFactoryTest`.\r\n* `index.php` probably needs some rework. It's just there to demonstrate to give an example.\r\n* No documentation, yet. Should I add Doxygen tags?\r\n\r\n\r\n","created_at":"2016-02-23T16:29:21Z","updated_at":"2016-02-24T11:08:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdd3d3269857a991469b28a0a72ce821f930eb15","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wmde/MultiFeed/pulls/4/commits","review_comments_url":"https://api.github.com/repos/wmde/MultiFeed/pulls/4/comments","review_comment_url":"https://api.github.com/repos/wmde/MultiFeed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wmde/MultiFeed/issues/4/comments","statuses_url":"https://api.github.com/repos/wmde/MultiFeed/statuses/2b8317ca9a4566811d5a5ed0f7f3587aed3ed323","head":{"label":"wmde:multifeed","ref":"multifeed","sha":"2b8317ca9a4566811d5a5ed0f7f3587aed3ed323","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":52279289,"name":"MultiFeed","full_name":"wmde/MultiFeed","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/MultiFeed","description":"","fork":false,"url":"https://api.github.com/repos/wmde/MultiFeed","forks_url":"https://api.github.com/repos/wmde/MultiFeed/forks","keys_url":"https://api.github.com/repos/wmde/MultiFeed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/MultiFeed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/MultiFeed/teams","hooks_url":"https://api.github.com/repos/wmde/MultiFeed/hooks","issue_events_url":"https://api.github.com/repos/wmde/MultiFeed/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/MultiFeed/events","assignees_url":"https://api.github.com/repos/wmde/MultiFeed/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/MultiFeed/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/MultiFeed/tags","blobs_url":"https://api.github.com/repos/wmde/MultiFeed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/MultiFeed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/MultiFeed/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/MultiFeed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/MultiFeed/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/MultiFeed/languages","stargazers_url":"https://api.github.com/repos/wmde/MultiFeed/stargazers","contributors_url":"https://api.github.com/repos/wmde/MultiFeed/contributors","subscribers_url":"https://api.github.com/repos/wmde/MultiFeed/subscribers","subscription_url":"https://api.github.com/repos/wmde/MultiFeed/subscription","commits_url":"https://api.github.com/repos/wmde/MultiFeed/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/MultiFeed/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/MultiFeed/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/MultiFeed/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmde/MultiFeed/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/MultiFeed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/MultiFeed/merges","archive_url":"https://api.github.com/repos/wmde/MultiFeed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/MultiFeed/downloads","issues_url":"https://api.github.com/repos/wmde/MultiFeed/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/MultiFeed/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/MultiFeed/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/MultiFeed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/MultiFeed/labels{/name}","releases_url":"https://api.github.com/repos/wmde/MultiFeed/releases{/id}","deployments_url":"https://api.github.com/repos/wmde/MultiFeed/deployments","created_at":"2016-02-22T14:31:54Z","updated_at":"2016-02-22T14:31:54Z","pushed_at":"2016-02-23T16:29:21Z","git_url":"git://github.com/wmde/MultiFeed.git","ssh_url":"git@github.com:wmde/MultiFeed.git","clone_url":"https://github.com/wmde/MultiFeed.git","svn_url":"https://github.com/wmde/MultiFeed","homepage":null,"size":4,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"wmde:master","ref":"master","sha":"fa92135170c093fdf6a84d06d38728b2b4420f5d","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":52279289,"name":"MultiFeed","full_name":"wmde/MultiFeed","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/MultiFeed","description":"","fork":false,"url":"https://api.github.com/repos/wmde/MultiFeed","forks_url":"https://api.github.com/repos/wmde/MultiFeed/forks","keys_url":"https://api.github.com/repos/wmde/MultiFeed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/MultiFeed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/MultiFeed/teams","hooks_url":"https://api.github.com/repos/wmde/MultiFeed/hooks","issue_events_url":"https://api.github.com/repos/wmde/MultiFeed/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/MultiFeed/events","assignees_url":"https://api.github.com/repos/wmde/MultiFeed/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/MultiFeed/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/MultiFeed/tags","blobs_url":"https://api.github.com/repos/wmde/MultiFeed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/MultiFeed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/MultiFeed/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/MultiFeed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/MultiFeed/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/MultiFeed/languages","stargazers_url":"https://api.github.com/repos/wmde/MultiFeed/stargazers","contributors_url":"https://api.github.com/repos/wmde/MultiFeed/contributors","subscribers_url":"https://api.github.com/repos/wmde/MultiFeed/subscribers","subscription_url":"https://api.github.com/repos/wmde/MultiFeed/subscription","commits_url":"https://api.github.com/repos/wmde/MultiFeed/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/MultiFeed/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/MultiFeed/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/MultiFeed/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmde/MultiFeed/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/MultiFeed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/MultiFeed/merges","archive_url":"https://api.github.com/repos/wmde/MultiFeed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/MultiFeed/downloads","issues_url":"https://api.github.com/repos/wmde/MultiFeed/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/MultiFeed/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/MultiFeed/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/MultiFeed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/MultiFeed/labels{/name}","releases_url":"https://api.github.com/repos/wmde/MultiFeed/releases{/id}","deployments_url":"https://api.github.com/repos/wmde/MultiFeed/deployments","created_at":"2016-02-22T14:31:54Z","updated_at":"2016-02-22T14:31:54Z","pushed_at":"2016-02-23T16:29:21Z","git_url":"git://github.com/wmde/MultiFeed.git","ssh_url":"git@github.com:wmde/MultiFeed.git","clone_url":"https://github.com/wmde/MultiFeed.git","svn_url":"https://github.com/wmde/MultiFeed","homepage":null,"size":4,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wmde/MultiFeed/pulls/4"},"html":{"href":"https://github.com/wmde/MultiFeed/pull/4"},"issue":{"href":"https://api.github.com/repos/wmde/MultiFeed/issues/4"},"comments":{"href":"https://api.github.com/repos/wmde/MultiFeed/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/wmde/MultiFeed/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/wmde/MultiFeed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wmde/MultiFeed/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/wmde/MultiFeed/statuses/2b8317ca9a4566811d5a5ed0f7f3587aed3ed323"}}}}