{"action":"opened","number":3419,"pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/3419","id":97298243,"html_url":"https://github.com/ethereum/go-ethereum/pull/3419","diff_url":"https://github.com/ethereum/go-ethereum/pull/3419.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/3419.patch","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/3419","number":3419,"state":"open","locked":false,"title":"build/nsis: safe update of PATH","user":{"login":"bas-vk","id":4280775,"avatar_url":"https://avatars.githubusercontent.com/u/4280775?v=3","gravatar_id":"","url":"https://api.github.com/users/bas-vk","html_url":"https://github.com/bas-vk","followers_url":"https://api.github.com/users/bas-vk/followers","following_url":"https://api.github.com/users/bas-vk/following{/other_user}","gists_url":"https://api.github.com/users/bas-vk/gists{/gist_id}","starred_url":"https://api.github.com/users/bas-vk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bas-vk/subscriptions","organizations_url":"https://api.github.com/users/bas-vk/orgs","repos_url":"https://api.github.com/users/bas-vk/repos","events_url":"https://api.github.com/users/bas-vk/events{/privacy}","received_events_url":"https://api.github.com/users/bas-vk/received_events","type":"User","site_admin":false},"body":"The NSIS installer currently uses `EnvVarUpdate` to update the registry, including updating the `PATH` variable. If `PATH` is larger than NSIS_MAX_STRLEN (default 1024) the fetched path is an empty string. After appending the install directory to the empty string its written to the registry. This means overwritten the current PATH entries.\r\n\r\nThere are 2 parts to this PR:\r\n1. `PATH` is updated through the use of a new `AddToPath`/`RemoveFromPath` functions. These functions check the current and new PATH to $NSIS_MAX_STRLEN and aborts if the path would become corrupt.\r\n2. Use a [special build](http://nsis.sourceforge.net/Special_Builds#Large_strings) of NSIS that has a NSIS_MAX_STRLEN of 8k instead of 1k. This needs to be installed on the CI server.\r\n\r\nFixes https://github.com/ethereum/go-ethereum/issues/3406","created_at":"2016-12-09T12:06:33Z","updated_at":"2016-12-09T12:06:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e1b2a824a1040edd9720ac1bcae4ce18446fea6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/3419/commits","review_comments_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/3419/comments","review_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/3419/comments","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/01cb08d533562cae1a2d586dc814ba3120de037a","head":{"label":"bas-vk:nsis-path","ref":"nsis-path","sha":"01cb08d533562cae1a2d586dc814ba3120de037a","user":{"login":"bas-vk","id":4280775,"avatar_url":"https://avatars.githubusercontent.com/u/4280775?v=3","gravatar_id":"","url":"https://api.github.com/users/bas-vk","html_url":"https://github.com/bas-vk","followers_url":"https://api.github.com/users/bas-vk/followers","following_url":"https://api.github.com/users/bas-vk/following{/other_user}","gists_url":"https://api.github.com/users/bas-vk/gists{/gist_id}","starred_url":"https://api.github.com/users/bas-vk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bas-vk/subscriptions","organizations_url":"https://api.github.com/users/bas-vk/orgs","repos_url":"https://api.github.com/users/bas-vk/repos","events_url":"https://api.github.com/users/bas-vk/events{/privacy}","received_events_url":"https://api.github.com/users/bas-vk/received_events","type":"User","site_admin":false},"repo":{"id":33240025,"name":"go-ethereum","full_name":"bas-vk/go-ethereum","owner":{"login":"bas-vk","id":4280775,"avatar_url":"https://avatars.githubusercontent.com/u/4280775?v=3","gravatar_id":"","url":"https://api.github.com/users/bas-vk","html_url":"https://github.com/bas-vk","followers_url":"https://api.github.com/users/bas-vk/followers","following_url":"https://api.github.com/users/bas-vk/following{/other_user}","gists_url":"https://api.github.com/users/bas-vk/gists{/gist_id}","starred_url":"https://api.github.com/users/bas-vk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bas-vk/subscriptions","organizations_url":"https://api.github.com/users/bas-vk/orgs","repos_url":"https://api.github.com/users/bas-vk/repos","events_url":"https://api.github.com/users/bas-vk/events{/privacy}","received_events_url":"https://api.github.com/users/bas-vk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bas-vk/go-ethereum","description":"Jeffrey Wilcke's Go implementation of the Ethereum y/w paper","fork":true,"url":"https://api.github.com/repos/bas-vk/go-ethereum","forks_url":"https://api.github.com/repos/bas-vk/go-ethereum/forks","keys_url":"https://api.github.com/repos/bas-vk/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bas-vk/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bas-vk/go-ethereum/teams","hooks_url":"https://api.github.com/repos/bas-vk/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/bas-vk/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/bas-vk/go-ethereum/events","assignees_url":"https://api.github.com/repos/bas-vk/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/bas-vk/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/bas-vk/go-ethereum/tags","blobs_url":"https://api.github.com/repos/bas-vk/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bas-vk/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bas-vk/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/bas-vk/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bas-vk/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/bas-vk/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/bas-vk/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/bas-vk/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/bas-vk/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/bas-vk/go-ethereum/subscription","commits_url":"https://api.github.com/repos/bas-vk/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/bas-vk/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/bas-vk/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/bas-vk/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/bas-vk/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/bas-vk/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bas-vk/go-ethereum/merges","archive_url":"https://api.github.com/repos/bas-vk/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bas-vk/go-ethereum/downloads","issues_url":"https://api.github.com/repos/bas-vk/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/bas-vk/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/bas-vk/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/bas-vk/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bas-vk/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/bas-vk/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/bas-vk/go-ethereum/deployments","created_at":"2015-04-01T09:53:33Z","updated_at":"2016-06-01T14:26:25Z","pushed_at":"2016-12-09T12:04:38Z","git_url":"git://github.com/bas-vk/go-ethereum.git","ssh_url":"git@github.com:bas-vk/go-ethereum.git","clone_url":"https://github.com/bas-vk/go-ethereum.git","svn_url":"https://github.com/bas-vk/go-ethereum","homepage":"","size":70229,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"develop"}},"base":{"label":"ethereum:master","ref":"master","sha":"0fe35b907addf1c066cb4d7c717bb23f9f2e7be4","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15452919,"name":"go-ethereum","full_name":"ethereum/go-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/go-ethereum","description":"Official Go implementation of the Ethereum protocol","fork":false,"url":"https://api.github.com/repos/ethereum/go-ethereum","forks_url":"https://api.github.com/repos/ethereum/go-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/go-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/go-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/go-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/go-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/go-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/go-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/go-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/go-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/go-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/go-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/go-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/go-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/go-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/go-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/go-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/go-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/go-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/go-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/go-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/go-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/go-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/go-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/go-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/go-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/go-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/go-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/go-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/go-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/go-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/go-ethereum/deployments","created_at":"2013-12-26T13:05:46Z","updated_at":"2016-12-09T08:14:30Z","pushed_at":"2016-12-09T12:06:33Z","git_url":"git://github.com/ethereum/go-ethereum.git","ssh_url":"git@github.com:ethereum/go-ethereum.git","clone_url":"https://github.com/ethereum/go-ethereum.git","svn_url":"https://github.com/ethereum/go-ethereum","homepage":"https://geth.ethereum.org","size":185130,"stargazers_count":2599,"watchers_count":2599,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":887,"mirror_url":null,"open_issues_count":312,"forks":887,"open_issues":312,"watchers":2599,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/3419"},"html":{"href":"https://github.com/ethereum/go-ethereum/pull/3419"},"issue":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/3419"},"comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/issues/3419/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/3419/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/go-ethereum/pulls/3419/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/go-ethereum/statuses/01cb08d533562cae1a2d586dc814ba3120de037a"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":164,"deletions":3,"changed_files":5}}
{"actor":{"display_login":"bas-vk"}}