{"action":"opened","number":3680,"pull_request":{"url":"https://api.github.com/repos/reactjs/react-router/pulls/3680","id":79276571,"html_url":"https://github.com/reactjs/react-router/pull/3680","diff_url":"https://github.com/reactjs/react-router/pull/3680.diff","patch_url":"https://github.com/reactjs/react-router/pull/3680.patch","issue_url":"https://api.github.com/repos/reactjs/react-router/issues/3680","number":3680,"state":"open","locked":false,"title":"Fix handling of patterns that are method names","user":{"login":"taion","id":3112159,"avatar_url":"https://avatars.githubusercontent.com/u/3112159?v=3","gravatar_id":"","url":"https://api.github.com/users/taion","html_url":"https://github.com/taion","followers_url":"https://api.github.com/users/taion/followers","following_url":"https://api.github.com/users/taion/following{/other_user}","gists_url":"https://api.github.com/users/taion/gists{/gist_id}","starred_url":"https://api.github.com/users/taion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taion/subscriptions","organizations_url":"https://api.github.com/users/taion/orgs","repos_url":"https://api.github.com/users/taion/repos","events_url":"https://api.github.com/users/taion/events{/privacy}","received_events_url":"https://api.github.com/users/taion/received_events","type":"User","site_admin":false},"body":"Fixes #3679.\n\nIncludes #3678 (needed for CI to pass).\n\n`PatternUtils` is sort of a mess, incidentally. There's no reason to export `compilePattern`, and there's no real reason that `getParams` should still exist (nothig calls it). I also don't know why `getRouteParams` is completely separate module, either.\n\nI want to fix/deprecate, but it's not that compelling right now.","created_at":"2016-07-28T22:03:34Z","updated_at":"2016-07-28T22:03:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/reactjs/react-router/pulls/3680/commits","review_comments_url":"https://api.github.com/repos/reactjs/react-router/pulls/3680/comments","review_comment_url":"https://api.github.com/repos/reactjs/react-router/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactjs/react-router/issues/3680/comments","statuses_url":"https://api.github.com/repos/reactjs/react-router/statuses/14ebf7837883d740cdcf6d234d4da77be64ac8e3","head":{"label":"reactjs:pattern-cache","ref":"pattern-cache","sha":"14ebf7837883d740cdcf6d234d4da77be64ac8e3","user":{"login":"reactjs","id":6412038,"avatar_url":"https://avatars.githubusercontent.com/u/6412038?v=3","gravatar_id":"","url":"https://api.github.com/users/reactjs","html_url":"https://github.com/reactjs","followers_url":"https://api.github.com/users/reactjs/followers","following_url":"https://api.github.com/users/reactjs/following{/other_user}","gists_url":"https://api.github.com/users/reactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactjs/subscriptions","organizations_url":"https://api.github.com/users/reactjs/orgs","repos_url":"https://api.github.com/users/reactjs/repos","events_url":"https://api.github.com/users/reactjs/events{/privacy}","received_events_url":"https://api.github.com/users/reactjs/received_events","type":"Organization","site_admin":false},"repo":{"id":19872456,"name":"react-router","full_name":"reactjs/react-router","owner":{"login":"reactjs","id":6412038,"avatar_url":"https://avatars.githubusercontent.com/u/6412038?v=3","gravatar_id":"","url":"https://api.github.com/users/reactjs","html_url":"https://github.com/reactjs","followers_url":"https://api.github.com/users/reactjs/followers","following_url":"https://api.github.com/users/reactjs/following{/other_user}","gists_url":"https://api.github.com/users/reactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactjs/subscriptions","organizations_url":"https://api.github.com/users/reactjs/orgs","repos_url":"https://api.github.com/users/reactjs/repos","events_url":"https://api.github.com/users/reactjs/events{/privacy}","received_events_url":"https://api.github.com/users/reactjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactjs/react-router","description":"A complete routing library for React","fork":false,"url":"https://api.github.com/repos/reactjs/react-router","forks_url":"https://api.github.com/repos/reactjs/react-router/forks","keys_url":"https://api.github.com/repos/reactjs/react-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactjs/react-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactjs/react-router/teams","hooks_url":"https://api.github.com/repos/reactjs/react-router/hooks","issue_events_url":"https://api.github.com/repos/reactjs/react-router/issues/events{/number}","events_url":"https://api.github.com/repos/reactjs/react-router/events","assignees_url":"https://api.github.com/repos/reactjs/react-router/assignees{/user}","branches_url":"https://api.github.com/repos/reactjs/react-router/branches{/branch}","tags_url":"https://api.github.com/repos/reactjs/react-router/tags","blobs_url":"https://api.github.com/repos/reactjs/react-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactjs/react-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactjs/react-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactjs/react-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactjs/react-router/statuses/{sha}","languages_url":"https://api.github.com/repos/reactjs/react-router/languages","stargazers_url":"https://api.github.com/repos/reactjs/react-router/stargazers","contributors_url":"https://api.github.com/repos/reactjs/react-router/contributors","subscribers_url":"https://api.github.com/repos/reactjs/react-router/subscribers","subscription_url":"https://api.github.com/repos/reactjs/react-router/subscription","commits_url":"https://api.github.com/repos/reactjs/react-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactjs/react-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactjs/react-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactjs/react-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactjs/react-router/contents/{+path}","compare_url":"https://api.github.com/repos/reactjs/react-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactjs/react-router/merges","archive_url":"https://api.github.com/repos/reactjs/react-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactjs/react-router/downloads","issues_url":"https://api.github.com/repos/reactjs/react-router/issues{/number}","pulls_url":"https://api.github.com/repos/reactjs/react-router/pulls{/number}","milestones_url":"https://api.github.com/repos/reactjs/react-router/milestones{/number}","notifications_url":"https://api.github.com/repos/reactjs/react-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactjs/react-router/labels{/name}","releases_url":"https://api.github.com/repos/reactjs/react-router/releases{/id}","deployments_url":"https://api.github.com/repos/reactjs/react-router/deployments","created_at":"2014-05-16T22:22:51Z","updated_at":"2016-07-28T20:39:22Z","pushed_at":"2016-07-28T22:03:35Z","git_url":"git://github.com/reactjs/react-router.git","ssh_url":"git@github.com:reactjs/react-router.git","clone_url":"https://github.com/reactjs/react-router.git","svn_url":"https://github.com/reactjs/react-router","homepage":"","size":8565,"stargazers_count":14611,"watchers_count":14611,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3238,"mirror_url":null,"open_issues_count":18,"forks":3238,"open_issues":18,"watchers":14611,"default_branch":"master"}},"base":{"label":"reactjs:master","ref":"master","sha":"85da0569199dda5f85bb72dddf669446ed1c17ce","user":{"login":"reactjs","id":6412038,"avatar_url":"https://avatars.githubusercontent.com/u/6412038?v=3","gravatar_id":"","url":"https://api.github.com/users/reactjs","html_url":"https://github.com/reactjs","followers_url":"https://api.github.com/users/reactjs/followers","following_url":"https://api.github.com/users/reactjs/following{/other_user}","gists_url":"https://api.github.com/users/reactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactjs/subscriptions","organizations_url":"https://api.github.com/users/reactjs/orgs","repos_url":"https://api.github.com/users/reactjs/repos","events_url":"https://api.github.com/users/reactjs/events{/privacy}","received_events_url":"https://api.github.com/users/reactjs/received_events","type":"Organization","site_admin":false},"repo":{"id":19872456,"name":"react-router","full_name":"reactjs/react-router","owner":{"login":"reactjs","id":6412038,"avatar_url":"https://avatars.githubusercontent.com/u/6412038?v=3","gravatar_id":"","url":"https://api.github.com/users/reactjs","html_url":"https://github.com/reactjs","followers_url":"https://api.github.com/users/reactjs/followers","following_url":"https://api.github.com/users/reactjs/following{/other_user}","gists_url":"https://api.github.com/users/reactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactjs/subscriptions","organizations_url":"https://api.github.com/users/reactjs/orgs","repos_url":"https://api.github.com/users/reactjs/repos","events_url":"https://api.github.com/users/reactjs/events{/privacy}","received_events_url":"https://api.github.com/users/reactjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactjs/react-router","description":"A complete routing library for React","fork":false,"url":"https://api.github.com/repos/reactjs/react-router","forks_url":"https://api.github.com/repos/reactjs/react-router/forks","keys_url":"https://api.github.com/repos/reactjs/react-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactjs/react-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactjs/react-router/teams","hooks_url":"https://api.github.com/repos/reactjs/react-router/hooks","issue_events_url":"https://api.github.com/repos/reactjs/react-router/issues/events{/number}","events_url":"https://api.github.com/repos/reactjs/react-router/events","assignees_url":"https://api.github.com/repos/reactjs/react-router/assignees{/user}","branches_url":"https://api.github.com/repos/reactjs/react-router/branches{/branch}","tags_url":"https://api.github.com/repos/reactjs/react-router/tags","blobs_url":"https://api.github.com/repos/reactjs/react-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactjs/react-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactjs/react-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactjs/react-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactjs/react-router/statuses/{sha}","languages_url":"https://api.github.com/repos/reactjs/react-router/languages","stargazers_url":"https://api.github.com/repos/reactjs/react-router/stargazers","contributors_url":"https://api.github.com/repos/reactjs/react-router/contributors","subscribers_url":"https://api.github.com/repos/reactjs/react-router/subscribers","subscription_url":"https://api.github.com/repos/reactjs/react-router/subscription","commits_url":"https://api.github.com/repos/reactjs/react-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactjs/react-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactjs/react-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactjs/react-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactjs/react-router/contents/{+path}","compare_url":"https://api.github.com/repos/reactjs/react-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactjs/react-router/merges","archive_url":"https://api.github.com/repos/reactjs/react-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactjs/react-router/downloads","issues_url":"https://api.github.com/repos/reactjs/react-router/issues{/number}","pulls_url":"https://api.github.com/repos/reactjs/react-router/pulls{/number}","milestones_url":"https://api.github.com/repos/reactjs/react-router/milestones{/number}","notifications_url":"https://api.github.com/repos/reactjs/react-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactjs/react-router/labels{/name}","releases_url":"https://api.github.com/repos/reactjs/react-router/releases{/id}","deployments_url":"https://api.github.com/repos/reactjs/react-router/deployments","created_at":"2014-05-16T22:22:51Z","updated_at":"2016-07-28T20:39:22Z","pushed_at":"2016-07-28T22:03:35Z","git_url":"git://github.com/reactjs/react-router.git","ssh_url":"git@github.com:reactjs/react-router.git","clone_url":"https://github.com/reactjs/react-router.git","svn_url":"https://github.com/reactjs/react-router","homepage":"","size":8565,"stargazers_count":14611,"watchers_count":14611,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3238,"mirror_url":null,"open_issues_count":18,"forks":3238,"open_issues":18,"watchers":14611,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactjs/react-router/pulls/3680"},"html":{"href":"https://github.com/reactjs/react-router/pull/3680"},"issue":{"href":"https://api.github.com/repos/reactjs/react-router/issues/3680"},"comments":{"href":"https://api.github.com/repos/reactjs/react-router/issues/3680/comments"},"review_comments":{"href":"https://api.github.com/repos/reactjs/react-router/pulls/3680/comments"},"review_comment":{"href":"https://api.github.com/repos/reactjs/react-router/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactjs/react-router/pulls/3680/commits"},"statuses":{"href":"https://api.github.com/repos/reactjs/react-router/statuses/14ebf7837883d740cdcf6d234d4da77be64ac8e3"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":27,"deletions":97,"changed_files":6}}
{"actor":{"display_login":"taion"}}