{"action":"created","comment":{"url":"https://api.github.com/repos/alertlogic/erlcloud/pulls/comments/78173123","id":78173123,"diff_hunk":"@@ -32,6 +32,10 @@\n          describe_snapshot_attribute/2, describe_snapshot_attribute/3,\n          describe_snapshots/0, describe_snapshots/1, describe_snapshots/2,\n          describe_snapshots/3, describe_snapshots/4,\n+         describe_snapshots_paged/0, describe_snapshots_paged/1,\n+         describe_snapshots_paged/2, describe_snapshots_paged/3,\n+         describe_snapshots_paged/4,\n+         next_snapshots_page/0,","path":"src/erlcloud_ec2.erl","position":7,"original_position":7,"commit_id":"cfc4904165ffbf519f7d1add30c8eb932e73d885","original_commit_id":"cfc4904165ffbf519f7d1add30c8eb932e73d885","user":{"login":"kkuzmin","id":6872804,"avatar_url":"https://avatars.githubusercontent.com/u/6872804?v=3","gravatar_id":"","url":"https://api.github.com/users/kkuzmin","html_url":"https://github.com/kkuzmin","followers_url":"https://api.github.com/users/kkuzmin/followers","following_url":"https://api.github.com/users/kkuzmin/following{/other_user}","gists_url":"https://api.github.com/users/kkuzmin/gists{/gist_id}","starred_url":"https://api.github.com/users/kkuzmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkuzmin/subscriptions","organizations_url":"https://api.github.com/users/kkuzmin/orgs","repos_url":"https://api.github.com/users/kkuzmin/repos","events_url":"https://api.github.com/users/kkuzmin/events{/privacy}","received_events_url":"https://api.github.com/users/kkuzmin/received_events","type":"User","site_admin":false},"body":"Hi Sergey,\r\n\r\nI'd suggest to follow the common pattern  and name this function like `describe_snapshots_next_page()`. Same for other functions below.","created_at":"2016-09-09T12:45:00Z","updated_at":"2016-09-09T12:45:00Z","html_url":"https://github.com/alertlogic/erlcloud/pull/121#discussion_r78173123","pull_request_url":"https://api.github.com/repos/alertlogic/erlcloud/pulls/121","_links":{"self":{"href":"https://api.github.com/repos/alertlogic/erlcloud/pulls/comments/78173123"},"html":{"href":"https://github.com/alertlogic/erlcloud/pull/121#discussion_r78173123"},"pull_request":{"href":"https://api.github.com/repos/alertlogic/erlcloud/pulls/121"}}},"pull_request":{"url":"https://api.github.com/repos/alertlogic/erlcloud/pulls/121","id":84627930,"html_url":"https://github.com/alertlogic/erlcloud/pull/121","diff_url":"https://github.com/alertlogic/erlcloud/pull/121.diff","patch_url":"https://github.com/alertlogic/erlcloud/pull/121.patch","issue_url":"https://api.github.com/repos/alertlogic/erlcloud/issues/121","number":121,"state":"open","locked":false,"title":"[DO NOT MERGE]  Implemented 4 paginated functions in erlcloud_ec2","user":{"login":"SergeyOvchinnik","id":8599706,"avatar_url":"https://avatars.githubusercontent.com/u/8599706?v=3","gravatar_id":"","url":"https://api.github.com/users/SergeyOvchinnik","html_url":"https://github.com/SergeyOvchinnik","followers_url":"https://api.github.com/users/SergeyOvchinnik/followers","following_url":"https://api.github.com/users/SergeyOvchinnik/following{/other_user}","gists_url":"https://api.github.com/users/SergeyOvchinnik/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyOvchinnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyOvchinnik/subscriptions","organizations_url":"https://api.github.com/users/SergeyOvchinnik/orgs","repos_url":"https://api.github.com/users/SergeyOvchinnik/repos","events_url":"https://api.github.com/users/SergeyOvchinnik/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyOvchinnik/received_events","type":"User","site_admin":false},"body":"Problem:\r\nsome functions in ec2 module in erlcloud did not have support for pagination features on library level\r\n\r\nSolution:\r\nImplemented paginated versions of 4 functions: \r\ndescribe_instances, \r\ndescribe_snapshots, \r\ndescribe_tags, \r\ndescribe_instance_status\r\n\r\nReviewers:\r\n@kkuzmin @ddosia @motobob ","created_at":"2016-09-09T10:26:50Z","updated_at":"2016-09-09T12:45:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70a9cabed150e23238390c899df1ff7a22ce94ce","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alertlogic/erlcloud/pulls/121/commits","review_comments_url":"https://api.github.com/repos/alertlogic/erlcloud/pulls/121/comments","review_comment_url":"https://api.github.com/repos/alertlogic/erlcloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alertlogic/erlcloud/issues/121/comments","statuses_url":"https://api.github.com/repos/alertlogic/erlcloud/statuses/cfc4904165ffbf519f7d1add30c8eb932e73d885","head":{"label":"SergeyOvchinnik:master","ref":"master","sha":"cfc4904165ffbf519f7d1add30c8eb932e73d885","user":{"login":"SergeyOvchinnik","id":8599706,"avatar_url":"https://avatars.githubusercontent.com/u/8599706?v=3","gravatar_id":"","url":"https://api.github.com/users/SergeyOvchinnik","html_url":"https://github.com/SergeyOvchinnik","followers_url":"https://api.github.com/users/SergeyOvchinnik/followers","following_url":"https://api.github.com/users/SergeyOvchinnik/following{/other_user}","gists_url":"https://api.github.com/users/SergeyOvchinnik/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyOvchinnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyOvchinnik/subscriptions","organizations_url":"https://api.github.com/users/SergeyOvchinnik/orgs","repos_url":"https://api.github.com/users/SergeyOvchinnik/repos","events_url":"https://api.github.com/users/SergeyOvchinnik/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyOvchinnik/received_events","type":"User","site_admin":false},"repo":{"id":67717649,"name":"erlcloud","full_name":"SergeyOvchinnik/erlcloud","owner":{"login":"SergeyOvchinnik","id":8599706,"avatar_url":"https://avatars.githubusercontent.com/u/8599706?v=3","gravatar_id":"","url":"https://api.github.com/users/SergeyOvchinnik","html_url":"https://github.com/SergeyOvchinnik","followers_url":"https://api.github.com/users/SergeyOvchinnik/followers","following_url":"https://api.github.com/users/SergeyOvchinnik/following{/other_user}","gists_url":"https://api.github.com/users/SergeyOvchinnik/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyOvchinnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyOvchinnik/subscriptions","organizations_url":"https://api.github.com/users/SergeyOvchinnik/orgs","repos_url":"https://api.github.com/users/SergeyOvchinnik/repos","events_url":"https://api.github.com/users/SergeyOvchinnik/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyOvchinnik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SergeyOvchinnik/erlcloud","description":"Cloud Computing library for erlang (Amazon EC2, S3, SQS, SimpleDB, Mechanical Turk, ELB)","fork":true,"url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud","forks_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/forks","keys_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/teams","hooks_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/hooks","issue_events_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/issues/events{/number}","events_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/events","assignees_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/assignees{/user}","branches_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/branches{/branch}","tags_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/tags","blobs_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/statuses/{sha}","languages_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/languages","stargazers_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/stargazers","contributors_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/contributors","subscribers_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/subscribers","subscription_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/subscription","commits_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/contents/{+path}","compare_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/merges","archive_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/downloads","issues_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/issues{/number}","pulls_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/pulls{/number}","milestones_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/milestones{/number}","notifications_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/labels{/name}","releases_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/releases{/id}","deployments_url":"https://api.github.com/repos/SergeyOvchinnik/erlcloud/deployments","created_at":"2016-09-08T15:50:22Z","updated_at":"2016-09-08T15:50:23Z","pushed_at":"2016-09-09T10:16:32Z","git_url":"git://github.com/SergeyOvchinnik/erlcloud.git","ssh_url":"git@github.com:SergeyOvchinnik/erlcloud.git","clone_url":"https://github.com/SergeyOvchinnik/erlcloud.git","svn_url":"https://github.com/SergeyOvchinnik/erlcloud","homepage":"","size":3375,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alertlogic:master","ref":"master","sha":"20db9233a56fd80e7b8439ef1c34cd49f8a5c63d","user":{"login":"alertlogic","id":1900859,"avatar_url":"https://avatars.githubusercontent.com/u/1900859?v=3","gravatar_id":"","url":"https://api.github.com/users/alertlogic","html_url":"https://github.com/alertlogic","followers_url":"https://api.github.com/users/alertlogic/followers","following_url":"https://api.github.com/users/alertlogic/following{/other_user}","gists_url":"https://api.github.com/users/alertlogic/gists{/gist_id}","starred_url":"https://api.github.com/users/alertlogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alertlogic/subscriptions","organizations_url":"https://api.github.com/users/alertlogic/orgs","repos_url":"https://api.github.com/users/alertlogic/repos","events_url":"https://api.github.com/users/alertlogic/events{/privacy}","received_events_url":"https://api.github.com/users/alertlogic/received_events","type":"Organization","site_admin":false},"repo":{"id":34382596,"name":"erlcloud","full_name":"alertlogic/erlcloud","owner":{"login":"alertlogic","id":1900859,"avatar_url":"https://avatars.githubusercontent.com/u/1900859?v=3","gravatar_id":"","url":"https://api.github.com/users/alertlogic","html_url":"https://github.com/alertlogic","followers_url":"https://api.github.com/users/alertlogic/followers","following_url":"https://api.github.com/users/alertlogic/following{/other_user}","gists_url":"https://api.github.com/users/alertlogic/gists{/gist_id}","starred_url":"https://api.github.com/users/alertlogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alertlogic/subscriptions","organizations_url":"https://api.github.com/users/alertlogic/orgs","repos_url":"https://api.github.com/users/alertlogic/repos","events_url":"https://api.github.com/users/alertlogic/events{/privacy}","received_events_url":"https://api.github.com/users/alertlogic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alertlogic/erlcloud","description":"Cloud Computing library for erlang (Amazon EC2, S3, SQS, SimpleDB, Mechanical Turk, ELB)","fork":true,"url":"https://api.github.com/repos/alertlogic/erlcloud","forks_url":"https://api.github.com/repos/alertlogic/erlcloud/forks","keys_url":"https://api.github.com/repos/alertlogic/erlcloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alertlogic/erlcloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alertlogic/erlcloud/teams","hooks_url":"https://api.github.com/repos/alertlogic/erlcloud/hooks","issue_events_url":"https://api.github.com/repos/alertlogic/erlcloud/issues/events{/number}","events_url":"https://api.github.com/repos/alertlogic/erlcloud/events","assignees_url":"https://api.github.com/repos/alertlogic/erlcloud/assignees{/user}","branches_url":"https://api.github.com/repos/alertlogic/erlcloud/branches{/branch}","tags_url":"https://api.github.com/repos/alertlogic/erlcloud/tags","blobs_url":"https://api.github.com/repos/alertlogic/erlcloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alertlogic/erlcloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alertlogic/erlcloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/alertlogic/erlcloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alertlogic/erlcloud/statuses/{sha}","languages_url":"https://api.github.com/repos/alertlogic/erlcloud/languages","stargazers_url":"https://api.github.com/repos/alertlogic/erlcloud/stargazers","contributors_url":"https://api.github.com/repos/alertlogic/erlcloud/contributors","subscribers_url":"https://api.github.com/repos/alertlogic/erlcloud/subscribers","subscription_url":"https://api.github.com/repos/alertlogic/erlcloud/subscription","commits_url":"https://api.github.com/repos/alertlogic/erlcloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/alertlogic/erlcloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/alertlogic/erlcloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/alertlogic/erlcloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/alertlogic/erlcloud/contents/{+path}","compare_url":"https://api.github.com/repos/alertlogic/erlcloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alertlogic/erlcloud/merges","archive_url":"https://api.github.com/repos/alertlogic/erlcloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alertlogic/erlcloud/downloads","issues_url":"https://api.github.com/repos/alertlogic/erlcloud/issues{/number}","pulls_url":"https://api.github.com/repos/alertlogic/erlcloud/pulls{/number}","milestones_url":"https://api.github.com/repos/alertlogic/erlcloud/milestones{/number}","notifications_url":"https://api.github.com/repos/alertlogic/erlcloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alertlogic/erlcloud/labels{/name}","releases_url":"https://api.github.com/repos/alertlogic/erlcloud/releases{/id}","deployments_url":"https://api.github.com/repos/alertlogic/erlcloud/deployments","created_at":"2015-04-22T09:53:41Z","updated_at":"2016-04-19T11:40:10Z","pushed_at":"2016-09-09T10:26:50Z","git_url":"git://github.com/alertlogic/erlcloud.git","ssh_url":"git@github.com:alertlogic/erlcloud.git","clone_url":"https://github.com/alertlogic/erlcloud.git","svn_url":"https://github.com/alertlogic/erlcloud","homepage":"","size":3365,"stargazers_count":5,"watchers_count":5,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":8,"forks":18,"open_issues":8,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alertlogic/erlcloud/pulls/121"},"html":{"href":"https://github.com/alertlogic/erlcloud/pull/121"},"issue":{"href":"https://api.github.com/repos/alertlogic/erlcloud/issues/121"},"comments":{"href":"https://api.github.com/repos/alertlogic/erlcloud/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/alertlogic/erlcloud/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/alertlogic/erlcloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alertlogic/erlcloud/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/alertlogic/erlcloud/statuses/cfc4904165ffbf519f7d1add30c8eb932e73d885"}}}}
{"actor":{"display_login":"kkuzmin"}}