{"action":"created","comment":{"url":"https://api.github.com/repos/plumpudding/hopglass/pulls/comments/66334177","id":66334177,"diff_hunk":"@@ -248,11 +322,15 @@ define([\"moment\", \"numeral\", \"tablesort\", \"tablesort.numeric\"],\n     attributeEntry(attributes, \"Site\", showSite(d, config))\n     attributeEntry(attributes, \"Uptime\", showUptime(d))\n     attributeEntry(attributes, \"Teil des Netzes\", showFirstseen(d))\n+    attributeEntry(attributes, \"Kanal 2.4 GHz\", showWifiChannel(dictGet(d.nodeinfo, [\"wireless\", \"chan2\"])))\n+    attributeEntry(attributes, \"Kanal 5 GHz\", showWifiChannel(dictGet(d.nodeinfo, [\"wireless\", \"chan5\"])))\n     attributeEntry(attributes, \"Systemlast\", showLoad(d))\n     attributeEntry(attributes, \"Arbeitsspeicher\", showRAM(d))\n+    attributeEntry(attributes, \"Airtime 2.4 GHz\", showAirtime(2, dictGet(d.statistics, [\"wireless\", \"airtime2\"])))\n+    attributeEntry(attributes, \"Airtime 5 GHz\", showAirtime(5, dictGet(d.statistics, [\"wireless\", \"airtime5\"])))","path":"lib/infobox/node.js","position":97,"original_position":97,"commit_id":"14e488ac99f942803f4c61eee298e096530283a4","original_commit_id":"14e488ac99f942803f4c61eee298e096530283a4","user":{"login":"plumpudding","id":3250809,"avatar_url":"https://avatars.githubusercontent.com/u/3250809?v=3","gravatar_id":"","url":"https://api.github.com/users/plumpudding","html_url":"https://github.com/plumpudding","followers_url":"https://api.github.com/users/plumpudding/followers","following_url":"https://api.github.com/users/plumpudding/following{/other_user}","gists_url":"https://api.github.com/users/plumpudding/gists{/gist_id}","starred_url":"https://api.github.com/users/plumpudding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plumpudding/subscriptions","organizations_url":"https://api.github.com/users/plumpudding/orgs","repos_url":"https://api.github.com/users/plumpudding/repos","events_url":"https://api.github.com/users/plumpudding/events{/privacy}","received_events_url":"https://api.github.com/users/plumpudding/received_events","type":"User","site_admin":false},"body":"airtime bitte unter die kanäle","created_at":"2016-06-08T20:33:37Z","updated_at":"2016-06-08T20:33:37Z","html_url":"https://github.com/plumpudding/hopglass/pull/38#discussion_r66334177","pull_request_url":"https://api.github.com/repos/plumpudding/hopglass/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/plumpudding/hopglass/pulls/comments/66334177"},"html":{"href":"https://github.com/plumpudding/hopglass/pull/38#discussion_r66334177"},"pull_request":{"href":"https://api.github.com/repos/plumpudding/hopglass/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/plumpudding/hopglass/pulls/38","id":71730357,"html_url":"https://github.com/plumpudding/hopglass/pull/38","diff_url":"https://github.com/plumpudding/hopglass/pull/38.diff","patch_url":"https://github.com/plumpudding/hopglass/pull/38.patch","issue_url":"https://api.github.com/repos/plumpudding/hopglass/issues/38","number":38,"state":"open","locked":false,"title":"infobox: added wifi channel, airtime and batctl nexthop","user":{"login":"eberhab","id":5958544,"avatar_url":"https://avatars.githubusercontent.com/u/5958544?v=3","gravatar_id":"","url":"https://api.github.com/users/eberhab","html_url":"https://github.com/eberhab","followers_url":"https://api.github.com/users/eberhab/followers","following_url":"https://api.github.com/users/eberhab/following{/other_user}","gists_url":"https://api.github.com/users/eberhab/gists{/gist_id}","starred_url":"https://api.github.com/users/eberhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eberhab/subscriptions","organizations_url":"https://api.github.com/users/eberhab/orgs","repos_url":"https://api.github.com/users/eberhab/repos","events_url":"https://api.github.com/users/eberhab/events{/privacy}","received_events_url":"https://api.github.com/users/eberhab/received_events","type":"User","site_admin":false},"body":"I'd like to put this up for discussion first. An increasing number of communities seems to be interested to display wifi channel and used airtime percentage in the infobox. It probably has yet to be decided on where in the json dicts these information should be located. The current implementation expects all values in the nodeinfo json which is maybe not what we ultimately want. Airtime and nexthop are changing values which are probably more suited to be put inside the statistics json.\r\n\r\nAlso I used the opportunity of displaying the wifi channel to add a translation to frequencies and in case of 5GHz bands a description of the channels. I highlighted DFS channels with exclamation marks as they are to my knoweledge not allowed to be used with openwrt.\r\n","created_at":"2016-05-27T15:24:08Z","updated_at":"2016-06-08T20:33:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4fe05b6ef719d3e6790f4cd68e2a7059a8a02dd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/plumpudding/hopglass/pulls/38/commits","review_comments_url":"https://api.github.com/repos/plumpudding/hopglass/pulls/38/comments","review_comment_url":"https://api.github.com/repos/plumpudding/hopglass/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plumpudding/hopglass/issues/38/comments","statuses_url":"https://api.github.com/repos/plumpudding/hopglass/statuses/14e488ac99f942803f4c61eee298e096530283a4","head":{"label":"eberhab:master","ref":"master","sha":"14e488ac99f942803f4c61eee298e096530283a4","user":{"login":"eberhab","id":5958544,"avatar_url":"https://avatars.githubusercontent.com/u/5958544?v=3","gravatar_id":"","url":"https://api.github.com/users/eberhab","html_url":"https://github.com/eberhab","followers_url":"https://api.github.com/users/eberhab/followers","following_url":"https://api.github.com/users/eberhab/following{/other_user}","gists_url":"https://api.github.com/users/eberhab/gists{/gist_id}","starred_url":"https://api.github.com/users/eberhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eberhab/subscriptions","organizations_url":"https://api.github.com/users/eberhab/orgs","repos_url":"https://api.github.com/users/eberhab/repos","events_url":"https://api.github.com/users/eberhab/events{/privacy}","received_events_url":"https://api.github.com/users/eberhab/received_events","type":"User","site_admin":false},"repo":{"id":59822892,"name":"hopglass","full_name":"eberhab/hopglass","owner":{"login":"eberhab","id":5958544,"avatar_url":"https://avatars.githubusercontent.com/u/5958544?v=3","gravatar_id":"","url":"https://api.github.com/users/eberhab","html_url":"https://github.com/eberhab","followers_url":"https://api.github.com/users/eberhab/followers","following_url":"https://api.github.com/users/eberhab/following{/other_user}","gists_url":"https://api.github.com/users/eberhab/gists{/gist_id}","starred_url":"https://api.github.com/users/eberhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eberhab/subscriptions","organizations_url":"https://api.github.com/users/eberhab/orgs","repos_url":"https://api.github.com/users/eberhab/repos","events_url":"https://api.github.com/users/eberhab/events{/privacy}","received_events_url":"https://api.github.com/users/eberhab/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eberhab/hopglass","description":"Visualize the Freifunk Mesh","fork":true,"url":"https://api.github.com/repos/eberhab/hopglass","forks_url":"https://api.github.com/repos/eberhab/hopglass/forks","keys_url":"https://api.github.com/repos/eberhab/hopglass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eberhab/hopglass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eberhab/hopglass/teams","hooks_url":"https://api.github.com/repos/eberhab/hopglass/hooks","issue_events_url":"https://api.github.com/repos/eberhab/hopglass/issues/events{/number}","events_url":"https://api.github.com/repos/eberhab/hopglass/events","assignees_url":"https://api.github.com/repos/eberhab/hopglass/assignees{/user}","branches_url":"https://api.github.com/repos/eberhab/hopglass/branches{/branch}","tags_url":"https://api.github.com/repos/eberhab/hopglass/tags","blobs_url":"https://api.github.com/repos/eberhab/hopglass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eberhab/hopglass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eberhab/hopglass/git/refs{/sha}","trees_url":"https://api.github.com/repos/eberhab/hopglass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eberhab/hopglass/statuses/{sha}","languages_url":"https://api.github.com/repos/eberhab/hopglass/languages","stargazers_url":"https://api.github.com/repos/eberhab/hopglass/stargazers","contributors_url":"https://api.github.com/repos/eberhab/hopglass/contributors","subscribers_url":"https://api.github.com/repos/eberhab/hopglass/subscribers","subscription_url":"https://api.github.com/repos/eberhab/hopglass/subscription","commits_url":"https://api.github.com/repos/eberhab/hopglass/commits{/sha}","git_commits_url":"https://api.github.com/repos/eberhab/hopglass/git/commits{/sha}","comments_url":"https://api.github.com/repos/eberhab/hopglass/comments{/number}","issue_comment_url":"https://api.github.com/repos/eberhab/hopglass/issues/comments{/number}","contents_url":"https://api.github.com/repos/eberhab/hopglass/contents/{+path}","compare_url":"https://api.github.com/repos/eberhab/hopglass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eberhab/hopglass/merges","archive_url":"https://api.github.com/repos/eberhab/hopglass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eberhab/hopglass/downloads","issues_url":"https://api.github.com/repos/eberhab/hopglass/issues{/number}","pulls_url":"https://api.github.com/repos/eberhab/hopglass/pulls{/number}","milestones_url":"https://api.github.com/repos/eberhab/hopglass/milestones{/number}","notifications_url":"https://api.github.com/repos/eberhab/hopglass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eberhab/hopglass/labels{/name}","releases_url":"https://api.github.com/repos/eberhab/hopglass/releases{/id}","deployments_url":"https://api.github.com/repos/eberhab/hopglass/deployments","created_at":"2016-05-27T09:30:24Z","updated_at":"2016-05-27T09:30:25Z","pushed_at":"2016-06-06T14:55:19Z","git_url":"git://github.com/eberhab/hopglass.git","ssh_url":"git@github.com:eberhab/hopglass.git","clone_url":"https://github.com/eberhab/hopglass.git","svn_url":"https://github.com/eberhab/hopglass","homepage":null,"size":870,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"plumpudding:master","ref":"master","sha":"1bcd2b797dc1ac2dc804084f6934a33112e942f6","user":{"login":"plumpudding","id":3250809,"avatar_url":"https://avatars.githubusercontent.com/u/3250809?v=3","gravatar_id":"","url":"https://api.github.com/users/plumpudding","html_url":"https://github.com/plumpudding","followers_url":"https://api.github.com/users/plumpudding/followers","following_url":"https://api.github.com/users/plumpudding/following{/other_user}","gists_url":"https://api.github.com/users/plumpudding/gists{/gist_id}","starred_url":"https://api.github.com/users/plumpudding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plumpudding/subscriptions","organizations_url":"https://api.github.com/users/plumpudding/orgs","repos_url":"https://api.github.com/users/plumpudding/repos","events_url":"https://api.github.com/users/plumpudding/events{/privacy}","received_events_url":"https://api.github.com/users/plumpudding/received_events","type":"User","site_admin":false},"repo":{"id":51018839,"name":"hopglass","full_name":"plumpudding/hopglass","owner":{"login":"plumpudding","id":3250809,"avatar_url":"https://avatars.githubusercontent.com/u/3250809?v=3","gravatar_id":"","url":"https://api.github.com/users/plumpudding","html_url":"https://github.com/plumpudding","followers_url":"https://api.github.com/users/plumpudding/followers","following_url":"https://api.github.com/users/plumpudding/following{/other_user}","gists_url":"https://api.github.com/users/plumpudding/gists{/gist_id}","starred_url":"https://api.github.com/users/plumpudding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plumpudding/subscriptions","organizations_url":"https://api.github.com/users/plumpudding/orgs","repos_url":"https://api.github.com/users/plumpudding/repos","events_url":"https://api.github.com/users/plumpudding/events{/privacy}","received_events_url":"https://api.github.com/users/plumpudding/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/plumpudding/hopglass","description":"Visualize the Freifunk Mesh","fork":false,"url":"https://api.github.com/repos/plumpudding/hopglass","forks_url":"https://api.github.com/repos/plumpudding/hopglass/forks","keys_url":"https://api.github.com/repos/plumpudding/hopglass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plumpudding/hopglass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plumpudding/hopglass/teams","hooks_url":"https://api.github.com/repos/plumpudding/hopglass/hooks","issue_events_url":"https://api.github.com/repos/plumpudding/hopglass/issues/events{/number}","events_url":"https://api.github.com/repos/plumpudding/hopglass/events","assignees_url":"https://api.github.com/repos/plumpudding/hopglass/assignees{/user}","branches_url":"https://api.github.com/repos/plumpudding/hopglass/branches{/branch}","tags_url":"https://api.github.com/repos/plumpudding/hopglass/tags","blobs_url":"https://api.github.com/repos/plumpudding/hopglass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plumpudding/hopglass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plumpudding/hopglass/git/refs{/sha}","trees_url":"https://api.github.com/repos/plumpudding/hopglass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plumpudding/hopglass/statuses/{sha}","languages_url":"https://api.github.com/repos/plumpudding/hopglass/languages","stargazers_url":"https://api.github.com/repos/plumpudding/hopglass/stargazers","contributors_url":"https://api.github.com/repos/plumpudding/hopglass/contributors","subscribers_url":"https://api.github.com/repos/plumpudding/hopglass/subscribers","subscription_url":"https://api.github.com/repos/plumpudding/hopglass/subscription","commits_url":"https://api.github.com/repos/plumpudding/hopglass/commits{/sha}","git_commits_url":"https://api.github.com/repos/plumpudding/hopglass/git/commits{/sha}","comments_url":"https://api.github.com/repos/plumpudding/hopglass/comments{/number}","issue_comment_url":"https://api.github.com/repos/plumpudding/hopglass/issues/comments{/number}","contents_url":"https://api.github.com/repos/plumpudding/hopglass/contents/{+path}","compare_url":"https://api.github.com/repos/plumpudding/hopglass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plumpudding/hopglass/merges","archive_url":"https://api.github.com/repos/plumpudding/hopglass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plumpudding/hopglass/downloads","issues_url":"https://api.github.com/repos/plumpudding/hopglass/issues{/number}","pulls_url":"https://api.github.com/repos/plumpudding/hopglass/pulls{/number}","milestones_url":"https://api.github.com/repos/plumpudding/hopglass/milestones{/number}","notifications_url":"https://api.github.com/repos/plumpudding/hopglass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plumpudding/hopglass/labels{/name}","releases_url":"https://api.github.com/repos/plumpudding/hopglass/releases{/id}","deployments_url":"https://api.github.com/repos/plumpudding/hopglass/deployments","created_at":"2016-02-03T17:54:49Z","updated_at":"2016-05-02T10:51:20Z","pushed_at":"2016-06-06T14:55:19Z","git_url":"git://github.com/plumpudding/hopglass.git","ssh_url":"git@github.com:plumpudding/hopglass.git","clone_url":"https://github.com/plumpudding/hopglass.git","svn_url":"https://github.com/plumpudding/hopglass","homepage":null,"size":1026,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":11,"forks":16,"open_issues":11,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plumpudding/hopglass/pulls/38"},"html":{"href":"https://github.com/plumpudding/hopglass/pull/38"},"issue":{"href":"https://api.github.com/repos/plumpudding/hopglass/issues/38"},"comments":{"href":"https://api.github.com/repos/plumpudding/hopglass/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/plumpudding/hopglass/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/plumpudding/hopglass/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plumpudding/hopglass/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/plumpudding/hopglass/statuses/14e488ac99f942803f4c61eee298e096530283a4"}}}}
{"actor":{"display_login":"plumpudding"}}