{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/paas-cf/issues/174","repository_url":"https://api.github.com/repos/alphagov/paas-cf","labels_url":"https://api.github.com/repos/alphagov/paas-cf/issues/174/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/paas-cf/issues/174/comments","events_url":"https://api.github.com/repos/alphagov/paas-cf/issues/174/events","html_url":"https://github.com/alphagov/paas-cf/pull/174","id":143196849,"number":174,"title":"[#113608503] Remove our own simple_app_test","user":{"login":"dcarley","id":260438,"avatar_url":"https://avatars.githubusercontent.com/u/260438?v=3","gravatar_id":"","url":"https://api.github.com/users/dcarley","html_url":"https://github.com/dcarley","followers_url":"https://api.github.com/users/dcarley/followers","following_url":"https://api.github.com/users/dcarley/following{/other_user}","gists_url":"https://api.github.com/users/dcarley/gists{/gist_id}","starred_url":"https://api.github.com/users/dcarley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcarley/subscriptions","organizations_url":"https://api.github.com/users/dcarley/orgs","repos_url":"https://api.github.com/users/dcarley/repos","events_url":"https://api.github.com/users/dcarley/events{/privacy}","received_events_url":"https://api.github.com/users/dcarley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-24T09:30:18Z","updated_at":"2016-03-29T13:43:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alphagov/paas-cf/pulls/174","html_url":"https://github.com/alphagov/paas-cf/pull/174","diff_url":"https://github.com/alphagov/paas-cf/pull/174.diff","patch_url":"https://github.com/alphagov/paas-cf/pull/174.patch"},"body":"## What\r\n\r\nThis was added when we introduced the custom acceptance test suite alongside\r\nthe existing Cloud Foundry acceptance tests. It duplicates functionality in\r\nthe CF tests and was a placeholder until we added other tests to our custom\r\nsuite.\r\n\r\ne18e80b adds our first real custom acceptance test so we no longer need to\r\nhave this. We need to keep `tests/acceptance-tests/example_apps` though\r\nbecause it's used by that new HTTP test.\r\n\r\n## How to review\r\n\r\n1. Checkout this branch:\r\n\r\n    ```\r\n113608503-remove_test_acceptance_test\r\n```\r\n1. Deploy the pipelines from branch:\r\n\r\n    ```\r\nBRANCH=$(git rev-parse --abbrev-ref HEAD) make dev pipelines\r\n```\r\n1. Run the `create-bosh-cloudfoundry` pipeline and confirm that the `custom-acceptance-tests` job passes.\r\n\r\n## Who can review\r\n\r\nAnyone but @dcarley"},"comment":{"url":"https://api.github.com/repos/alphagov/paas-cf/issues/comments/202899012","html_url":"https://github.com/alphagov/paas-cf/pull/174#issuecomment-202899012","issue_url":"https://api.github.com/repos/alphagov/paas-cf/issues/174","id":202899012,"user":{"login":"keymon","id":280032,"avatar_url":"https://avatars.githubusercontent.com/u/280032?v=3","gravatar_id":"","url":"https://api.github.com/users/keymon","html_url":"https://github.com/keymon","followers_url":"https://api.github.com/users/keymon/followers","following_url":"https://api.github.com/users/keymon/following{/other_user}","gists_url":"https://api.github.com/users/keymon/gists{/gist_id}","starred_url":"https://api.github.com/users/keymon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymon/subscriptions","organizations_url":"https://api.github.com/users/keymon/orgs","repos_url":"https://api.github.com/users/keymon/repos","events_url":"https://api.github.com/users/keymon/events{/privacy}","received_events_url":"https://api.github.com/users/keymon/received_events","type":"User","site_admin":false},"created_at":"2016-03-29T13:43:03Z","updated_at":"2016-03-29T13:43:03Z","body":"Spoken with @dcarley this is ready to merge :+1: "}}