{"action":"created","comment":{"url":"https://api.github.com/repos/audioscience/avdecc-lib/pulls/comments/78166881","id":78166881,"diff_hunk":"@@ -62,12 +62,27 @@ class net_interface\n     /// \\return The network interface IP address by index for a device.\n     ///\n     AVDECC_CONTROLLER_LIB32_API virtual const char * STDCALL get_dev_ip_address_by_index(size_t dev_index, size_t ip_index) = 0;\n+    \n+    ///\n+    /// \\return The network interface MAC address by index for a device.\n+    ///\n+    AVDECC_CONTROLLER_LIB32_API virtual uint64_t STDCALL get_dev_mac_addr_by_index(size_t dev_index) = 0;\n \n     /// This function is OS dependant. In linux and OSX the return is the same as for a call to\n     /// get_dev_desc_by_index(). In Windows this function returns a GUID as a string.\n     /// \\return The corresponding network interface name by index.\n     ///\n     AVDECC_CONTROLLER_LIB32_API virtual char * STDCALL get_dev_name_by_index(size_t dev_index) = 0;\n+    \n+    ///\n+    /// \\return True if ip_addr_str is the IP address of the device specified by dev_index.\n+    ///\n+    AVDECC_CONTROLLER_LIB32_API virtual bool STDCALL find_selected_interface_by_ip_address(size_t dev_index, char * ip_addr_str) = 0;\n+    \n+    ///\n+    /// \\return True if mac_addr is the MAC address of the device specified by dev_index.\n+    ///\n+    AVDECC_CONTROLLER_LIB32_API virtual bool STDCALL find_selected_interface_by_mac_address(size_t dev_index, uint64_t mac_addr) = 0;","path":"controller/lib/include/net_interface.h","position":24,"original_position":24,"commit_id":"60425dc72c17a86ae3814c666451921e46889141","original_commit_id":"60425dc72c17a86ae3814c666451921e46889141","user":{"login":"andrew-elder","id":814195,"avatar_url":"https://avatars.githubusercontent.com/u/814195?v=3","gravatar_id":"","url":"https://api.github.com/users/andrew-elder","html_url":"https://github.com/andrew-elder","followers_url":"https://api.github.com/users/andrew-elder/followers","following_url":"https://api.github.com/users/andrew-elder/following{/other_user}","gists_url":"https://api.github.com/users/andrew-elder/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-elder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-elder/subscriptions","organizations_url":"https://api.github.com/users/andrew-elder/orgs","repos_url":"https://api.github.com/users/andrew-elder/repos","events_url":"https://api.github.com/users/andrew-elder/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-elder/received_events","type":"User","site_admin":false},"body":"I think \"find\" is the wrong word here. To me \"find\" implies a search operation, but that is not what this function does. Maybe compare_interfaces_mac_address() ?","created_at":"2016-09-09T11:47:52Z","updated_at":"2016-09-09T11:47:52Z","html_url":"https://github.com/audioscience/avdecc-lib/pull/295#discussion_r78166881","pull_request_url":"https://api.github.com/repos/audioscience/avdecc-lib/pulls/295","_links":{"self":{"href":"https://api.github.com/repos/audioscience/avdecc-lib/pulls/comments/78166881"},"html":{"href":"https://github.com/audioscience/avdecc-lib/pull/295#discussion_r78166881"},"pull_request":{"href":"https://api.github.com/repos/audioscience/avdecc-lib/pulls/295"}}},"pull_request":{"url":"https://api.github.com/repos/audioscience/avdecc-lib/pulls/295","id":84566568,"html_url":"https://github.com/audioscience/avdecc-lib/pull/295","diff_url":"https://github.com/audioscience/avdecc-lib/pull/295.diff","patch_url":"https://github.com/audioscience/avdecc-lib/pull/295.patch","issue_url":"https://api.github.com/repos/audioscience/avdecc-lib/issues/295","number":295,"state":"open","locked":false,"title":"osx/msvc network interface","user":{"login":"vronchetti","id":8479744,"avatar_url":"https://avatars.githubusercontent.com/u/8479744?v=3","gravatar_id":"","url":"https://api.github.com/users/vronchetti","html_url":"https://github.com/vronchetti","followers_url":"https://api.github.com/users/vronchetti/followers","following_url":"https://api.github.com/users/vronchetti/following{/other_user}","gists_url":"https://api.github.com/users/vronchetti/gists{/gist_id}","starred_url":"https://api.github.com/users/vronchetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vronchetti/subscriptions","organizations_url":"https://api.github.com/users/vronchetti/orgs","repos_url":"https://api.github.com/users/vronchetti/repos","events_url":"https://api.github.com/users/vronchetti/events{/privacy}","received_events_url":"https://api.github.com/users/vronchetti/received_events","type":"User","site_admin":false},"body":" 1) Add MAC address to network interface list.\r\n 2) Allow for an interface to be selected by IP Address or MAC via the -i command line argument\r\n 2) Add command line argument -p to print the available interfaces and exit.","created_at":"2016-09-08T22:40:08Z","updated_at":"2016-09-09T11:47:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa77de5c3f74bccab4f453780beffd493f2ad895","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/audioscience/avdecc-lib/pulls/295/commits","review_comments_url":"https://api.github.com/repos/audioscience/avdecc-lib/pulls/295/comments","review_comment_url":"https://api.github.com/repos/audioscience/avdecc-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/audioscience/avdecc-lib/issues/295/comments","statuses_url":"https://api.github.com/repos/audioscience/avdecc-lib/statuses/60425dc72c17a86ae3814c666451921e46889141","head":{"label":"vronchetti:vfr/staging","ref":"vfr/staging","sha":"60425dc72c17a86ae3814c666451921e46889141","user":{"login":"vronchetti","id":8479744,"avatar_url":"https://avatars.githubusercontent.com/u/8479744?v=3","gravatar_id":"","url":"https://api.github.com/users/vronchetti","html_url":"https://github.com/vronchetti","followers_url":"https://api.github.com/users/vronchetti/followers","following_url":"https://api.github.com/users/vronchetti/following{/other_user}","gists_url":"https://api.github.com/users/vronchetti/gists{/gist_id}","starred_url":"https://api.github.com/users/vronchetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vronchetti/subscriptions","organizations_url":"https://api.github.com/users/vronchetti/orgs","repos_url":"https://api.github.com/users/vronchetti/repos","events_url":"https://api.github.com/users/vronchetti/events{/privacy}","received_events_url":"https://api.github.com/users/vronchetti/received_events","type":"User","site_admin":false},"repo":{"id":23071485,"name":"avdecc-lib","full_name":"vronchetti/avdecc-lib","owner":{"login":"vronchetti","id":8479744,"avatar_url":"https://avatars.githubusercontent.com/u/8479744?v=3","gravatar_id":"","url":"https://api.github.com/users/vronchetti","html_url":"https://github.com/vronchetti","followers_url":"https://api.github.com/users/vronchetti/followers","following_url":"https://api.github.com/users/vronchetti/following{/other_user}","gists_url":"https://api.github.com/users/vronchetti/gists{/gist_id}","starred_url":"https://api.github.com/users/vronchetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vronchetti/subscriptions","organizations_url":"https://api.github.com/users/vronchetti/orgs","repos_url":"https://api.github.com/users/vronchetti/repos","events_url":"https://api.github.com/users/vronchetti/events{/privacy}","received_events_url":"https://api.github.com/users/vronchetti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vronchetti/avdecc-lib","description":"Simple C++ library for implementing IEEE1722.1 (AVB Device Enumeration, Discovery and Control)","fork":true,"url":"https://api.github.com/repos/vronchetti/avdecc-lib","forks_url":"https://api.github.com/repos/vronchetti/avdecc-lib/forks","keys_url":"https://api.github.com/repos/vronchetti/avdecc-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vronchetti/avdecc-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vronchetti/avdecc-lib/teams","hooks_url":"https://api.github.com/repos/vronchetti/avdecc-lib/hooks","issue_events_url":"https://api.github.com/repos/vronchetti/avdecc-lib/issues/events{/number}","events_url":"https://api.github.com/repos/vronchetti/avdecc-lib/events","assignees_url":"https://api.github.com/repos/vronchetti/avdecc-lib/assignees{/user}","branches_url":"https://api.github.com/repos/vronchetti/avdecc-lib/branches{/branch}","tags_url":"https://api.github.com/repos/vronchetti/avdecc-lib/tags","blobs_url":"https://api.github.com/repos/vronchetti/avdecc-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vronchetti/avdecc-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vronchetti/avdecc-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/vronchetti/avdecc-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vronchetti/avdecc-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/vronchetti/avdecc-lib/languages","stargazers_url":"https://api.github.com/repos/vronchetti/avdecc-lib/stargazers","contributors_url":"https://api.github.com/repos/vronchetti/avdecc-lib/contributors","subscribers_url":"https://api.github.com/repos/vronchetti/avdecc-lib/subscribers","subscription_url":"https://api.github.com/repos/vronchetti/avdecc-lib/subscription","commits_url":"https://api.github.com/repos/vronchetti/avdecc-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/vronchetti/avdecc-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/vronchetti/avdecc-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/vronchetti/avdecc-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/vronchetti/avdecc-lib/contents/{+path}","compare_url":"https://api.github.com/repos/vronchetti/avdecc-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vronchetti/avdecc-lib/merges","archive_url":"https://api.github.com/repos/vronchetti/avdecc-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vronchetti/avdecc-lib/downloads","issues_url":"https://api.github.com/repos/vronchetti/avdecc-lib/issues{/number}","pulls_url":"https://api.github.com/repos/vronchetti/avdecc-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/vronchetti/avdecc-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/vronchetti/avdecc-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vronchetti/avdecc-lib/labels{/name}","releases_url":"https://api.github.com/repos/vronchetti/avdecc-lib/releases{/id}","deployments_url":"https://api.github.com/repos/vronchetti/avdecc-lib/deployments","created_at":"2014-08-18T13:06:12Z","updated_at":"2014-08-12T19:59:45Z","pushed_at":"2016-09-08T22:35:54Z","git_url":"git://github.com/vronchetti/avdecc-lib.git","ssh_url":"git@github.com:vronchetti/avdecc-lib.git","clone_url":"https://github.com/vronchetti/avdecc-lib.git","svn_url":"https://github.com/vronchetti/avdecc-lib","homepage":null,"size":3635,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"audioscience:staging","ref":"staging","sha":"09746d5c6e7906637f256c48e18c0af71be54ac5","user":{"login":"audioscience","id":1200605,"avatar_url":"https://avatars.githubusercontent.com/u/1200605?v=3","gravatar_id":"","url":"https://api.github.com/users/audioscience","html_url":"https://github.com/audioscience","followers_url":"https://api.github.com/users/audioscience/followers","following_url":"https://api.github.com/users/audioscience/following{/other_user}","gists_url":"https://api.github.com/users/audioscience/gists{/gist_id}","starred_url":"https://api.github.com/users/audioscience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/audioscience/subscriptions","organizations_url":"https://api.github.com/users/audioscience/orgs","repos_url":"https://api.github.com/users/audioscience/repos","events_url":"https://api.github.com/users/audioscience/events{/privacy}","received_events_url":"https://api.github.com/users/audioscience/received_events","type":"Organization","site_admin":false},"repo":{"id":12380117,"name":"avdecc-lib","full_name":"audioscience/avdecc-lib","owner":{"login":"audioscience","id":1200605,"avatar_url":"https://avatars.githubusercontent.com/u/1200605?v=3","gravatar_id":"","url":"https://api.github.com/users/audioscience","html_url":"https://github.com/audioscience","followers_url":"https://api.github.com/users/audioscience/followers","following_url":"https://api.github.com/users/audioscience/following{/other_user}","gists_url":"https://api.github.com/users/audioscience/gists{/gist_id}","starred_url":"https://api.github.com/users/audioscience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/audioscience/subscriptions","organizations_url":"https://api.github.com/users/audioscience/orgs","repos_url":"https://api.github.com/users/audioscience/repos","events_url":"https://api.github.com/users/audioscience/events{/privacy}","received_events_url":"https://api.github.com/users/audioscience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/audioscience/avdecc-lib","description":"Simple C++ library for implementing IEEE1722.1 (AVB Device Enumeration, Discovery and Control)","fork":false,"url":"https://api.github.com/repos/audioscience/avdecc-lib","forks_url":"https://api.github.com/repos/audioscience/avdecc-lib/forks","keys_url":"https://api.github.com/repos/audioscience/avdecc-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/audioscience/avdecc-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/audioscience/avdecc-lib/teams","hooks_url":"https://api.github.com/repos/audioscience/avdecc-lib/hooks","issue_events_url":"https://api.github.com/repos/audioscience/avdecc-lib/issues/events{/number}","events_url":"https://api.github.com/repos/audioscience/avdecc-lib/events","assignees_url":"https://api.github.com/repos/audioscience/avdecc-lib/assignees{/user}","branches_url":"https://api.github.com/repos/audioscience/avdecc-lib/branches{/branch}","tags_url":"https://api.github.com/repos/audioscience/avdecc-lib/tags","blobs_url":"https://api.github.com/repos/audioscience/avdecc-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/audioscience/avdecc-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/audioscience/avdecc-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/audioscience/avdecc-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/audioscience/avdecc-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/audioscience/avdecc-lib/languages","stargazers_url":"https://api.github.com/repos/audioscience/avdecc-lib/stargazers","contributors_url":"https://api.github.com/repos/audioscience/avdecc-lib/contributors","subscribers_url":"https://api.github.com/repos/audioscience/avdecc-lib/subscribers","subscription_url":"https://api.github.com/repos/audioscience/avdecc-lib/subscription","commits_url":"https://api.github.com/repos/audioscience/avdecc-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/audioscience/avdecc-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/audioscience/avdecc-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/audioscience/avdecc-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/audioscience/avdecc-lib/contents/{+path}","compare_url":"https://api.github.com/repos/audioscience/avdecc-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/audioscience/avdecc-lib/merges","archive_url":"https://api.github.com/repos/audioscience/avdecc-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/audioscience/avdecc-lib/downloads","issues_url":"https://api.github.com/repos/audioscience/avdecc-lib/issues{/number}","pulls_url":"https://api.github.com/repos/audioscience/avdecc-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/audioscience/avdecc-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/audioscience/avdecc-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/audioscience/avdecc-lib/labels{/name}","releases_url":"https://api.github.com/repos/audioscience/avdecc-lib/releases{/id}","deployments_url":"https://api.github.com/repos/audioscience/avdecc-lib/deployments","created_at":"2013-08-26T13:38:58Z","updated_at":"2016-09-05T09:49:03Z","pushed_at":"2016-09-08T22:40:08Z","git_url":"git://github.com/audioscience/avdecc-lib.git","ssh_url":"git@github.com:audioscience/avdecc-lib.git","clone_url":"https://github.com/audioscience/avdecc-lib.git","svn_url":"https://github.com/audioscience/avdecc-lib","homepage":null,"size":3934,"stargazers_count":25,"watchers_count":25,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":20,"forks":19,"open_issues":20,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/audioscience/avdecc-lib/pulls/295"},"html":{"href":"https://github.com/audioscience/avdecc-lib/pull/295"},"issue":{"href":"https://api.github.com/repos/audioscience/avdecc-lib/issues/295"},"comments":{"href":"https://api.github.com/repos/audioscience/avdecc-lib/issues/295/comments"},"review_comments":{"href":"https://api.github.com/repos/audioscience/avdecc-lib/pulls/295/comments"},"review_comment":{"href":"https://api.github.com/repos/audioscience/avdecc-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/audioscience/avdecc-lib/pulls/295/commits"},"statuses":{"href":"https://api.github.com/repos/audioscience/avdecc-lib/statuses/60425dc72c17a86ae3814c666451921e46889141"}}}}
{"actor":{"display_login":"andrew-elder"}}