{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/8434","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/8434/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/8434/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/8434/events","html_url":"https://github.com/facebook/react-native/pull/8434","id":162296747,"number":8434,"title":"Update docs with ReactInstanceManager API change","user":{"login":"clarle","id":686352,"avatar_url":"https://avatars.githubusercontent.com/u/686352?v=3","gravatar_id":"","url":"https://api.github.com/users/clarle","html_url":"https://github.com/clarle","followers_url":"https://api.github.com/users/clarle/followers","following_url":"https://api.github.com/users/clarle/following{/other_user}","gists_url":"https://api.github.com/users/clarle/gists{/gist_id}","starred_url":"https://api.github.com/users/clarle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clarle/subscriptions","organizations_url":"https://api.github.com/users/clarle/orgs","repos_url":"https://api.github.com/users/clarle/repos","events_url":"https://api.github.com/users/clarle/events{/privacy}","received_events_url":"https://api.github.com/users/clarle/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7"},{"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20needs-revision","name":"GH Review: needs-revision","color":"e11d21"},{"url":"https://api.github.com/repos/facebook/react-native/labels/Import%20Failed","name":"Import Failed","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-06-25T19:50:31Z","updated_at":"2016-06-26T20:22:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/8434","html_url":"https://github.com/facebook/react-native/pull/8434","diff_url":"https://github.com/facebook/react-native/pull/8434.diff","patch_url":"https://github.com/facebook/react-native/pull/8434.patch"},"body":"Documentation update for existing Android app integration due to API changes to `ReactInstanceManager`.\r\n\r\n- `onPause` is now `onHostPause`\r\n- `onResume` is `onHostResume`\r\n\r\nThis might be useful for other people searching it up, but when I got the error:\r\n\r\n`Module 0 is not a registered callable module`\r\n\r\nIt was because my Gradle file accidentally was using the version of React Native from Maven Central instead of the one within my `node_modules` directory, which was a much older version (0.20.1).\r\n\r\nHowever, I thought it was the right one because when I switched directories, my app was giving me errors since `mReactInstanceManager.onPause` and `mReactInstanceManager.onResume` didn't exist.\r\n\r\nThe change in the API wasn't reflected in the docs, and it took me forever to figure that out. Hope this saves some other people some time!"},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/228620629","html_url":"https://github.com/facebook/react-native/pull/8434#issuecomment-228620629","issue_url":"https://api.github.com/repos/facebook/react-native/issues/8434","id":228620629,"user":{"login":"grabbou","id":2464966,"avatar_url":"https://avatars.githubusercontent.com/u/2464966?v=3","gravatar_id":"","url":"https://api.github.com/users/grabbou","html_url":"https://github.com/grabbou","followers_url":"https://api.github.com/users/grabbou/followers","following_url":"https://api.github.com/users/grabbou/following{/other_user}","gists_url":"https://api.github.com/users/grabbou/gists{/gist_id}","starred_url":"https://api.github.com/users/grabbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grabbou/subscriptions","organizations_url":"https://api.github.com/users/grabbou/orgs","repos_url":"https://api.github.com/users/grabbou/repos","events_url":"https://api.github.com/users/grabbou/events{/privacy}","received_events_url":"https://api.github.com/users/grabbou/received_events","type":"User","site_admin":false},"created_at":"2016-06-26T20:22:48Z","updated_at":"2016-06-26T20:22:48Z","body":"Yup @satya164, that should definitelly be cherry-picked to avoid confusion :)"}}
{"actor":{"display_login":"grabbou"}}