{"push_id":1141099042,"size":1,"distinct_size":1,"ref":"refs/heads/dataset-closing","head":"830299650d56ac69fc0b58d380cce0165401149f","before":"be2854f98fd5dafa315bb347b5f704a5965b62e0","commits":[{"sha":"830299650d56ac69fc0b58d380cce0165401149f","author":{"name":"Ryan","email":"8f18e670ec432ee5e15365d38d203f741b57c02e@axiomdatascience.com"},"message":"Properly close datasets (fixes #4)\n\nTo start, simply check `isopen()` and only then sync and close.\n\nThose changes alone caused quite a bit of test breakage since previously files\nwere never being closed (`self.close()` kept recursing until a stack overflow,\ncaught by the RuntimeError handler around the `sync()` call --- see be2854f).\n\nTo fix this, I replaced a few instances where `EnhancedDataset` was used in a\n`with` statement. This means that the files won't close immediately when\nexiting the context, and instead will only close when either (a) you manually\ncall close or (b) the object is finally deallocated.","distinct":true,"url":"https://api.github.com/repos/RSully/axiom-pyaxiom/commits/830299650d56ac69fc0b58d380cce0165401149f"}]}
{"actor":{"display_login":"RSully"}}