{"action":"created","comment":{"url":"https://api.github.com/repos/enthought/traits/pulls/comments/67839796","id":67839796,"diff_hunk":"@@ -0,0 +1,35 @@\n+\"\"\" Unit tests for the Disallow singleton.\n+\"\"\"\n+from traits.testing.unittest_tools import unittest\n+from ..api import Disallow, HasTraits, TraitError\n+\n+\n+class A(HasTraits):\n+\n+    x = Disallow\n+\n+\n+class B(HasTraits):\n+\n+    _ = Disallow\n+\n+\n+class TestDisallow(unittest.TestCase):\n+\n+    def test_trait_get_set(self):\n+        a = A()\n+\n+        with self.assertRaises(AttributeError):\n+            a.x\n+\n+        with self.assertRaises(TraitError):\n+            a.x = 123","path":"traits/tests/test_disallow.py","position":26,"original_position":26,"commit_id":"17a4c0b1583a542916156c8fbb1b19f9eca67c97","original_commit_id":"a3730c65b50afc56ab803a7cf9741fe0117baadd","user":{"login":"sjagoe","id":80012,"avatar_url":"https://avatars.githubusercontent.com/u/80012?v=3","gravatar_id":"","url":"https://api.github.com/users/sjagoe","html_url":"https://github.com/sjagoe","followers_url":"https://api.github.com/users/sjagoe/followers","following_url":"https://api.github.com/users/sjagoe/following{/other_user}","gists_url":"https://api.github.com/users/sjagoe/gists{/gist_id}","starred_url":"https://api.github.com/users/sjagoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjagoe/subscriptions","organizations_url":"https://api.github.com/users/sjagoe/orgs","repos_url":"https://api.github.com/users/sjagoe/repos","events_url":"https://api.github.com/users/sjagoe/events{/privacy}","received_events_url":"https://api.github.com/users/sjagoe/received_events","type":"User","site_admin":false},"body":"Should this test assert that `a.other_attribute = 'something'` is allowed?","created_at":"2016-06-21T09:54:34Z","updated_at":"2016-06-21T09:54:34Z","html_url":"https://github.com/enthought/traits/pull/298#discussion_r67839796","pull_request_url":"https://api.github.com/repos/enthought/traits/pulls/298","_links":{"self":{"href":"https://api.github.com/repos/enthought/traits/pulls/comments/67839796"},"html":{"href":"https://github.com/enthought/traits/pull/298#discussion_r67839796"},"pull_request":{"href":"https://api.github.com/repos/enthought/traits/pulls/298"}}},"pull_request":{"url":"https://api.github.com/repos/enthought/traits/pulls/298","id":71826000,"html_url":"https://github.com/enthought/traits/pull/298","diff_url":"https://github.com/enthought/traits/pull/298.diff","patch_url":"https://github.com/enthought/traits/pull/298.patch","issue_url":"https://api.github.com/repos/enthought/traits/issues/298","number":298,"state":"open","locked":false,"title":"WIP: ENH: cython port of ctraits.c","user":{"login":"dpinte","id":538104,"avatar_url":"https://avatars.githubusercontent.com/u/538104?v=3","gravatar_id":"","url":"https://api.github.com/users/dpinte","html_url":"https://github.com/dpinte","followers_url":"https://api.github.com/users/dpinte/followers","following_url":"https://api.github.com/users/dpinte/following{/other_user}","gists_url":"https://api.github.com/users/dpinte/gists{/gist_id}","starred_url":"https://api.github.com/users/dpinte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpinte/subscriptions","organizations_url":"https://api.github.com/users/dpinte/orgs","repos_url":"https://api.github.com/users/dpinte/repos","events_url":"https://api.github.com/users/dpinte/events{/privacy}","received_events_url":"https://api.github.com/users/dpinte/received_events","type":"User","site_admin":false},"body":"This PR is the result of work started in 2013 to migrate `ctraits.c` to Cython. Thanks to the input of multiple developers, it comes in as a clean enhancement over the current code base, a test suite that passe without any changes. It open the doors to a many future enhancements.\r\n\r\nThanks to @jvkersch, @pberkes and @sjagoe for the work!","created_at":"2016-05-29T12:25:41Z","updated_at":"2016-06-21T09:54:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"546e50010a07dbe1ae1b5a6008522178498a6ced","assignee":null,"milestone":{"url":"https://api.github.com/repos/enthought/traits/milestones/2","html_url":"https://github.com/enthought/traits/milestones/5.0.0%20release","labels_url":"https://api.github.com/repos/enthought/traits/milestones/2/labels","id":1810852,"number":2,"title":"5.0.0 release","description":"","creator":{"login":"mdickinson","id":662003,"avatar_url":"https://avatars.githubusercontent.com/u/662003?v=3","gravatar_id":"","url":"https://api.github.com/users/mdickinson","html_url":"https://github.com/mdickinson","followers_url":"https://api.github.com/users/mdickinson/followers","following_url":"https://api.github.com/users/mdickinson/following{/other_user}","gists_url":"https://api.github.com/users/mdickinson/gists{/gist_id}","starred_url":"https://api.github.com/users/mdickinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdickinson/subscriptions","organizations_url":"https://api.github.com/users/mdickinson/orgs","repos_url":"https://api.github.com/users/mdickinson/repos","events_url":"https://api.github.com/users/mdickinson/events{/privacy}","received_events_url":"https://api.github.com/users/mdickinson/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2016-06-06T13:31:22Z","updated_at":"2016-06-07T12:16:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/enthought/traits/pulls/298/commits","review_comments_url":"https://api.github.com/repos/enthought/traits/pulls/298/comments","review_comment_url":"https://api.github.com/repos/enthought/traits/pulls/comments{/number}","comments_url":"https://api.github.com/repos/enthought/traits/issues/298/comments","statuses_url":"https://api.github.com/repos/enthought/traits/statuses/17a4c0b1583a542916156c8fbb1b19f9eca67c97","head":{"label":"enthought:enh/cython-port","ref":"enh/cython-port","sha":"17a4c0b1583a542916156c8fbb1b19f9eca67c97","user":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=3","gravatar_id":"","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"repo":{"id":1301745,"name":"traits","full_name":"enthought/traits","owner":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=3","gravatar_id":"","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enthought/traits","description":"Optional type-checking, data dependencies, and event notifications for Python","fork":false,"url":"https://api.github.com/repos/enthought/traits","forks_url":"https://api.github.com/repos/enthought/traits/forks","keys_url":"https://api.github.com/repos/enthought/traits/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enthought/traits/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enthought/traits/teams","hooks_url":"https://api.github.com/repos/enthought/traits/hooks","issue_events_url":"https://api.github.com/repos/enthought/traits/issues/events{/number}","events_url":"https://api.github.com/repos/enthought/traits/events","assignees_url":"https://api.github.com/repos/enthought/traits/assignees{/user}","branches_url":"https://api.github.com/repos/enthought/traits/branches{/branch}","tags_url":"https://api.github.com/repos/enthought/traits/tags","blobs_url":"https://api.github.com/repos/enthought/traits/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enthought/traits/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enthought/traits/git/refs{/sha}","trees_url":"https://api.github.com/repos/enthought/traits/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enthought/traits/statuses/{sha}","languages_url":"https://api.github.com/repos/enthought/traits/languages","stargazers_url":"https://api.github.com/repos/enthought/traits/stargazers","contributors_url":"https://api.github.com/repos/enthought/traits/contributors","subscribers_url":"https://api.github.com/repos/enthought/traits/subscribers","subscription_url":"https://api.github.com/repos/enthought/traits/subscription","commits_url":"https://api.github.com/repos/enthought/traits/commits{/sha}","git_commits_url":"https://api.github.com/repos/enthought/traits/git/commits{/sha}","comments_url":"https://api.github.com/repos/enthought/traits/comments{/number}","issue_comment_url":"https://api.github.com/repos/enthought/traits/issues/comments{/number}","contents_url":"https://api.github.com/repos/enthought/traits/contents/{+path}","compare_url":"https://api.github.com/repos/enthought/traits/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enthought/traits/merges","archive_url":"https://api.github.com/repos/enthought/traits/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enthought/traits/downloads","issues_url":"https://api.github.com/repos/enthought/traits/issues{/number}","pulls_url":"https://api.github.com/repos/enthought/traits/pulls{/number}","milestones_url":"https://api.github.com/repos/enthought/traits/milestones{/number}","notifications_url":"https://api.github.com/repos/enthought/traits/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enthought/traits/labels{/name}","releases_url":"https://api.github.com/repos/enthought/traits/releases{/id}","deployments_url":"https://api.github.com/repos/enthought/traits/deployments","created_at":"2011-01-28T04:46:40Z","updated_at":"2016-05-28T16:27:42Z","pushed_at":"2016-06-21T08:46:10Z","git_url":"git://github.com/enthought/traits.git","ssh_url":"git@github.com:enthought/traits.git","clone_url":"https://github.com/enthought/traits.git","svn_url":"https://github.com/enthought/traits","homepage":"","size":43260,"stargazers_count":134,"watchers_count":134,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":45,"mirror_url":null,"open_issues_count":89,"forks":45,"open_issues":89,"watchers":134,"default_branch":"master"}},"base":{"label":"enthought:master","ref":"master","sha":"e441ab19071bee09054a205e6ec3ea06db1e8aac","user":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=3","gravatar_id":"","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"repo":{"id":1301745,"name":"traits","full_name":"enthought/traits","owner":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=3","gravatar_id":"","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enthought/traits","description":"Optional type-checking, data dependencies, and event notifications for Python","fork":false,"url":"https://api.github.com/repos/enthought/traits","forks_url":"https://api.github.com/repos/enthought/traits/forks","keys_url":"https://api.github.com/repos/enthought/traits/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enthought/traits/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enthought/traits/teams","hooks_url":"https://api.github.com/repos/enthought/traits/hooks","issue_events_url":"https://api.github.com/repos/enthought/traits/issues/events{/number}","events_url":"https://api.github.com/repos/enthought/traits/events","assignees_url":"https://api.github.com/repos/enthought/traits/assignees{/user}","branches_url":"https://api.github.com/repos/enthought/traits/branches{/branch}","tags_url":"https://api.github.com/repos/enthought/traits/tags","blobs_url":"https://api.github.com/repos/enthought/traits/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enthought/traits/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enthought/traits/git/refs{/sha}","trees_url":"https://api.github.com/repos/enthought/traits/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enthought/traits/statuses/{sha}","languages_url":"https://api.github.com/repos/enthought/traits/languages","stargazers_url":"https://api.github.com/repos/enthought/traits/stargazers","contributors_url":"https://api.github.com/repos/enthought/traits/contributors","subscribers_url":"https://api.github.com/repos/enthought/traits/subscribers","subscription_url":"https://api.github.com/repos/enthought/traits/subscription","commits_url":"https://api.github.com/repos/enthought/traits/commits{/sha}","git_commits_url":"https://api.github.com/repos/enthought/traits/git/commits{/sha}","comments_url":"https://api.github.com/repos/enthought/traits/comments{/number}","issue_comment_url":"https://api.github.com/repos/enthought/traits/issues/comments{/number}","contents_url":"https://api.github.com/repos/enthought/traits/contents/{+path}","compare_url":"https://api.github.com/repos/enthought/traits/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enthought/traits/merges","archive_url":"https://api.github.com/repos/enthought/traits/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enthought/traits/downloads","issues_url":"https://api.github.com/repos/enthought/traits/issues{/number}","pulls_url":"https://api.github.com/repos/enthought/traits/pulls{/number}","milestones_url":"https://api.github.com/repos/enthought/traits/milestones{/number}","notifications_url":"https://api.github.com/repos/enthought/traits/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enthought/traits/labels{/name}","releases_url":"https://api.github.com/repos/enthought/traits/releases{/id}","deployments_url":"https://api.github.com/repos/enthought/traits/deployments","created_at":"2011-01-28T04:46:40Z","updated_at":"2016-05-28T16:27:42Z","pushed_at":"2016-06-21T08:46:10Z","git_url":"git://github.com/enthought/traits.git","ssh_url":"git@github.com:enthought/traits.git","clone_url":"https://github.com/enthought/traits.git","svn_url":"https://github.com/enthought/traits","homepage":"","size":43260,"stargazers_count":134,"watchers_count":134,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":45,"mirror_url":null,"open_issues_count":89,"forks":45,"open_issues":89,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enthought/traits/pulls/298"},"html":{"href":"https://github.com/enthought/traits/pull/298"},"issue":{"href":"https://api.github.com/repos/enthought/traits/issues/298"},"comments":{"href":"https://api.github.com/repos/enthought/traits/issues/298/comments"},"review_comments":{"href":"https://api.github.com/repos/enthought/traits/pulls/298/comments"},"review_comment":{"href":"https://api.github.com/repos/enthought/traits/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/enthought/traits/pulls/298/commits"},"statuses":{"href":"https://api.github.com/repos/enthought/traits/statuses/17a4c0b1583a542916156c8fbb1b19f9eca67c97"}}}}
{"actor":{"display_login":"sjagoe"}}