{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/64992714","id":64992714,"diff_hunk":"@@ -247,7 +247,7 @@ triggers:\n === Image Change Trigger\n \n The ImageChange trigger results in a new deployment whenever the value of an\n-image stream tag changes.\n+image stream tag changes either by a build or because it was imported.","path":"dev_guide/deployments.adoc","position":19,"original_position":19,"commit_id":"97c25356b03bef326537fbf7aa454100ec58a53a","original_commit_id":"97c25356b03bef326537fbf7aa454100ec58a53a","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"body":"Correct. CCT is responsible for triggering new deployments on pod template\nchanges. If it's on, **any template change** should trigger a deployment,\nif it's off, template changes will not trigger deployments automatically.\nEssentially, CCT is (almost) a global on/off for a DC. ICTs set to\nautomatc: true will always update images in templates, automatic: false\nwill update only for the initial deployment so people wont get stuck with\nImagePullBackOff errors\n\nOn Fri, May 27, 2016 at 11:35 PM, Ben Parees <notifications@github.com>\nwrote:\n\n> In dev_guide/deployments.adoc\n> <https://github.com/openshift/openshift-docs/pull/2150#discussion_r64969500>\n> :\n>\n> > @@ -247,7 +247,7 @@ triggers:\n> >  === Image Change Trigger\n> >\n> >  The ImageChange trigger results in a new deployment whenever the value of an\n> > -image stream tag changes.\n> > +image stream tag changes either by a build or because it was imported.\n>\n> yeah, without the CCT (but with an ICT in automatic mode) the DC will be\n> updated w/ the new image information (at a minimum this will happen when a\n> deployment is explicilty requested), but no deployment will be triggered\n> automatically. I believe.\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/openshift/openshift-docs/pull/2150/files/97c25356b03bef326537fbf7aa454100ec58a53a#r64969500>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe/ADuFf7WSZ9mITHQhBAKpYFiw3cohCHuVks5qF2OlgaJpZM4ImsqM>\n> .\n>\n","created_at":"2016-05-28T19:08:28Z","updated_at":"2016-05-28T19:08:28Z","html_url":"https://github.com/openshift/openshift-docs/pull/2150#discussion_r64992714","pull_request_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/2150","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments/64992714"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/2150#discussion_r64992714"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/2150"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-docs/pulls/2150","id":71417594,"html_url":"https://github.com/openshift/openshift-docs/pull/2150","diff_url":"https://github.com/openshift/openshift-docs/pull/2150.diff","patch_url":"https://github.com/openshift/openshift-docs/pull/2150.patch","issue_url":"https://api.github.com/repos/openshift/openshift-docs/issues/2150","number":2150,"state":"open","locked":false,"title":"Information about deployment triggers","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"body":"@bparees we can start from here. \r\n\r\ncc: @adellape @tnguyen-rh would love your suggestions for working and how to structure the table","created_at":"2016-05-25T15:59:16Z","updated_at":"2016-05-28T19:08:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"976c99f69baa29cb86e13042d37a88290bf09933","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/2150/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/2150/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/issues/2150/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/97c25356b03bef326537fbf7aa454100ec58a53a","head":{"label":"kargakis:deployment-triggers-doc","ref":"deployment-triggers-doc","sha":"97c25356b03bef326537fbf7aa454100ec58a53a","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"repo":{"id":31673812,"name":"openshift-docs","full_name":"kargakis/openshift-docs","owner":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kargakis/openshift-docs","description":"OpenShift Documentation","fork":true,"url":"https://api.github.com/repos/kargakis/openshift-docs","forks_url":"https://api.github.com/repos/kargakis/openshift-docs/forks","keys_url":"https://api.github.com/repos/kargakis/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kargakis/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kargakis/openshift-docs/teams","hooks_url":"https://api.github.com/repos/kargakis/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/kargakis/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/kargakis/openshift-docs/events","assignees_url":"https://api.github.com/repos/kargakis/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/kargakis/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/kargakis/openshift-docs/tags","blobs_url":"https://api.github.com/repos/kargakis/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kargakis/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kargakis/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/kargakis/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kargakis/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/kargakis/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/kargakis/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/kargakis/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/kargakis/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/kargakis/openshift-docs/subscription","commits_url":"https://api.github.com/repos/kargakis/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/kargakis/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/kargakis/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/kargakis/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/kargakis/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/kargakis/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kargakis/openshift-docs/merges","archive_url":"https://api.github.com/repos/kargakis/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kargakis/openshift-docs/downloads","issues_url":"https://api.github.com/repos/kargakis/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/kargakis/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/kargakis/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/kargakis/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kargakis/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/kargakis/openshift-docs/releases{/id}","deployments_url":"https://api.github.com/repos/kargakis/openshift-docs/deployments","created_at":"2015-03-04T18:50:38Z","updated_at":"2016-01-23T15:38:16Z","pushed_at":"2016-05-25T15:55:36Z","git_url":"git://github.com/kargakis/openshift-docs.git","ssh_url":"git@github.com:kargakis/openshift-docs.git","clone_url":"https://github.com/kargakis/openshift-docs.git","svn_url":"https://github.com/kargakis/openshift-docs","homepage":null,"size":11684,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"3a091c8c1ab9a00a2c6e10e1469fd70c71b90eb2","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":21740844,"name":"openshift-docs","full_name":"openshift/openshift-docs","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-docs","description":"OpenShift Documentation","fork":false,"url":"https://api.github.com/repos/openshift/openshift-docs","forks_url":"https://api.github.com/repos/openshift/openshift-docs/forks","keys_url":"https://api.github.com/repos/openshift/openshift-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-docs/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-docs/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-docs/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-docs/events","assignees_url":"https://api.github.com/repos/openshift/openshift-docs/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-docs/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-docs/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-docs/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-docs/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-docs/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-docs/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-docs/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-docs/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-docs/merges","archive_url":"https://api.github.com/repos/openshift/openshift-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-docs/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-docs/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-docs/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-docs/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-docs/deployments","created_at":"2014-07-11T15:14:42Z","updated_at":"2016-05-18T14:49:12Z","pushed_at":"2016-05-27T18:42:15Z","git_url":"git://github.com/openshift/openshift-docs.git","ssh_url":"git@github.com:openshift/openshift-docs.git","clone_url":"https://github.com/openshift/openshift-docs.git","svn_url":"https://github.com/openshift/openshift-docs","homepage":"https://docs.openshift.org/latest/welcome/index.html","size":17345,"stargazers_count":45,"watchers_count":45,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":212,"mirror_url":null,"open_issues_count":188,"forks":212,"open_issues":188,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/2150"},"html":{"href":"https://github.com/openshift/openshift-docs/pull/2150"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/2150"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/issues/2150/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/2150/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-docs/pulls/2150/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-docs/statuses/97c25356b03bef326537fbf7aa454100ec58a53a"}}}}
{"actor":{"display_login":"kargakis"}}