{"action":"created","issue":{"url":"https://api.github.com/repos/linbox-team/givaro/issues/30","repository_url":"https://api.github.com/repos/linbox-team/givaro","labels_url":"https://api.github.com/repos/linbox-team/givaro/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/linbox-team/givaro/issues/30/comments","events_url":"https://api.github.com/repos/linbox-team/givaro/issues/30/events","html_url":"https://github.com/linbox-team/givaro/issues/30","id":182250784,"number":30,"title":"Fishy check in src/library/poly1/givpoly1muldiv.inl","user":{"login":"fingolfin","id":241512,"avatar_url":"https://avatars.githubusercontent.com/u/241512?v=3","gravatar_id":"","url":"https://api.github.com/users/fingolfin","html_url":"https://github.com/fingolfin","followers_url":"https://api.github.com/users/fingolfin/followers","following_url":"https://api.github.com/users/fingolfin/following{/other_user}","gists_url":"https://api.github.com/users/fingolfin/gists{/gist_id}","starred_url":"https://api.github.com/users/fingolfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fingolfin/subscriptions","organizations_url":"https://api.github.com/users/fingolfin/orgs","repos_url":"https://api.github.com/users/fingolfin/repos","events_url":"https://api.github.com/users/fingolfin/events{/privacy}","received_events_url":"https://api.github.com/users/fingolfin/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-11T12:28:37Z","updated_at":"2016-10-13T06:11:39Z","closed_at":"2016-10-13T06:11:39Z","body":"The file `src/library/poly1/givpoly1muldiv.inl` contains this check (actually, it contains it twice, but one copy is inside an `#if 0` block):\r\n```\r\n\tif (sR != sQ+sP) R.reallocate(sR = sP+sQ-1);\r\n```\r\nThis looks suspiciously like an off-by-one error. Even if it is intentional, I think a comment should be added to explain the rationable behind it."},"comment":{"url":"https://api.github.com/repos/linbox-team/givaro/issues/comments/253423213","html_url":"https://github.com/linbox-team/givaro/issues/30#issuecomment-253423213","issue_url":"https://api.github.com/repos/linbox-team/givaro/issues/30","id":253423213,"user":{"login":"ClementPernet","id":10073220,"avatar_url":"https://avatars.githubusercontent.com/u/10073220?v=3","gravatar_id":"","url":"https://api.github.com/users/ClementPernet","html_url":"https://github.com/ClementPernet","followers_url":"https://api.github.com/users/ClementPernet/followers","following_url":"https://api.github.com/users/ClementPernet/following{/other_user}","gists_url":"https://api.github.com/users/ClementPernet/gists{/gist_id}","starred_url":"https://api.github.com/users/ClementPernet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClementPernet/subscriptions","organizations_url":"https://api.github.com/users/ClementPernet/orgs","repos_url":"https://api.github.com/users/ClementPernet/repos","events_url":"https://api.github.com/users/ClementPernet/events{/privacy}","received_events_url":"https://api.github.com/users/ClementPernet/received_events","type":"User","site_admin":false},"created_at":"2016-10-13T06:11:39Z","updated_at":"2016-10-13T06:11:39Z","body":"Fixed in adc9680"}}
{"actor":{"display_login":"ClementPernet"}}