{"action":"created","comment":{"url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/pulls/comments/85257239","pull_request_review_id":5983046,"id":85257239,"diff_hunk":"@@ -2,15 +2,15 @@ import { Stream, just } from 'most';\n import create = require('@most/create');\n import firebase = require('firebase');\n import {\n-  AuthenticationInput, CreateUserAuthenticationInput,\n-  EmailAndPasswordAuthenticationInput, PopupAuthenticationInput,\n+  AuthenticationType, CreateUserAuthentication,\n+  EmailAndPasswordAuthentication, PopupAuthentication,\n   REDIRECT, EMAIL_AND_PASSWORD, CREATE_USER, POPUP, ANONYMOUSLY, SIGN_OUT,\n   GET_REDIRECT_RESULT\n } from './types';\n import { convertUserToUserCredential } from './convertUserToUserCredential';\n import { defaultUserCredential } from './defaultUserCredential';\n \n-export function createUserCredential$(method: string, authenticationInput: AuthenticationInput, firebaseInstance: any):\n+export function createUserCredential$(method: string, authenticationInput: AuthenticationType, firebaseInstance: any):","path":"src/drivers/firebase-authentication/createUserCredential$.ts","position":null,"original_position":15,"commit_id":"0351ea523913741bcd72bfa9279f5bd42621591d","original_commit_id":"32c437828160f9bfbbac05a7269345d1fdfbe676","user":{"login":"Frikki","id":180569,"avatar_url":"https://avatars.githubusercontent.com/u/180569?v=3","gravatar_id":"","url":"https://api.github.com/users/Frikki","html_url":"https://github.com/Frikki","followers_url":"https://api.github.com/users/Frikki/followers","following_url":"https://api.github.com/users/Frikki/following{/other_user}","gists_url":"https://api.github.com/users/Frikki/gists{/gist_id}","starred_url":"https://api.github.com/users/Frikki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frikki/subscriptions","organizations_url":"https://api.github.com/users/Frikki/orgs","repos_url":"https://api.github.com/users/Frikki/repos","events_url":"https://api.github.com/users/Frikki/events{/privacy}","received_events_url":"https://api.github.com/users/Frikki/received_events","type":"User","site_admin":false},"body":"✅","created_at":"2016-10-27T02:36:44Z","updated_at":"2016-10-27T02:36:44Z","html_url":"https://github.com/SparksNetwork/sparks-frontend/pull/42#discussion_r85257239","pull_request_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/SparksNetwork/sparks-frontend/pulls/comments/85257239"},"html":{"href":"https://github.com/SparksNetwork/sparks-frontend/pull/42#discussion_r85257239"},"pull_request":{"href":"https://api.github.com/repos/SparksNetwork/sparks-frontend/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/pulls/42","id":91119746,"html_url":"https://github.com/SparksNetwork/sparks-frontend/pull/42","diff_url":"https://github.com/SparksNetwork/sparks-frontend/pull/42.diff","patch_url":"https://github.com/SparksNetwork/sparks-frontend/pull/42.patch","issue_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/issues/42","number":42,"state":"open","locked":false,"title":"refactor(HOC): extract authenticate functions","user":{"login":"Frikki","id":180569,"avatar_url":"https://avatars.githubusercontent.com/u/180569?v=3","gravatar_id":"","url":"https://api.github.com/users/Frikki","html_url":"https://github.com/Frikki","followers_url":"https://api.github.com/users/Frikki/followers","following_url":"https://api.github.com/users/Frikki/following{/other_user}","gists_url":"https://api.github.com/users/Frikki/gists{/gist_id}","starred_url":"https://api.github.com/users/Frikki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frikki/subscriptions","organizations_url":"https://api.github.com/users/Frikki/orgs","repos_url":"https://api.github.com/users/Frikki/repos","events_url":"https://api.github.com/users/Frikki/events{/privacy}","received_events_url":"https://api.github.com/users/Frikki/received_events","type":"User","site_admin":false},"body":"Manditory Checks\r\n---\r\n\r\n- [ ] I added new tests for the issue I fixed or the feature I built\r\n- [x] I ran `npm test` for the package I'm modifying\r\n- [ ] I used `npm run commit` instead of `git commit`\r\n\r\n---\r\n\r\nExtract authenticate functions.\r\nRename types and interfaces.","created_at":"2016-10-27T01:43:43Z","updated_at":"2016-10-27T02:36:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67176a78e59df20cab46d9de2f984237cd459682","assignee":{"login":"TylorS","id":6282473,"avatar_url":"https://avatars.githubusercontent.com/u/6282473?v=3","gravatar_id":"","url":"https://api.github.com/users/TylorS","html_url":"https://github.com/TylorS","followers_url":"https://api.github.com/users/TylorS/followers","following_url":"https://api.github.com/users/TylorS/following{/other_user}","gists_url":"https://api.github.com/users/TylorS/gists{/gist_id}","starred_url":"https://api.github.com/users/TylorS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TylorS/subscriptions","organizations_url":"https://api.github.com/users/TylorS/orgs","repos_url":"https://api.github.com/users/TylorS/repos","events_url":"https://api.github.com/users/TylorS/events{/privacy}","received_events_url":"https://api.github.com/users/TylorS/received_events","type":"User","site_admin":false},"assignees":[{"login":"TylorS","id":6282473,"avatar_url":"https://avatars.githubusercontent.com/u/6282473?v=3","gravatar_id":"","url":"https://api.github.com/users/TylorS","html_url":"https://github.com/TylorS","followers_url":"https://api.github.com/users/TylorS/followers","following_url":"https://api.github.com/users/TylorS/following{/other_user}","gists_url":"https://api.github.com/users/TylorS/gists{/gist_id}","starred_url":"https://api.github.com/users/TylorS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TylorS/subscriptions","organizations_url":"https://api.github.com/users/TylorS/orgs","repos_url":"https://api.github.com/users/TylorS/repos","events_url":"https://api.github.com/users/TylorS/events{/privacy}","received_events_url":"https://api.github.com/users/TylorS/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/pulls/42/commits","review_comments_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/pulls/42/comments","review_comment_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/issues/42/comments","statuses_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/statuses/0351ea523913741bcd72bfa9279f5bd42621591d","head":{"label":"SparksNetwork:frikki/refactor/hoc/authenticate","ref":"frikki/refactor/hoc/authenticate","sha":"0351ea523913741bcd72bfa9279f5bd42621591d","user":{"login":"SparksNetwork","id":19400238,"avatar_url":"https://avatars.githubusercontent.com/u/19400238?v=3","gravatar_id":"","url":"https://api.github.com/users/SparksNetwork","html_url":"https://github.com/SparksNetwork","followers_url":"https://api.github.com/users/SparksNetwork/followers","following_url":"https://api.github.com/users/SparksNetwork/following{/other_user}","gists_url":"https://api.github.com/users/SparksNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/SparksNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparksNetwork/subscriptions","organizations_url":"https://api.github.com/users/SparksNetwork/orgs","repos_url":"https://api.github.com/users/SparksNetwork/repos","events_url":"https://api.github.com/users/SparksNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/SparksNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":66723009,"name":"sparks-frontend","full_name":"SparksNetwork/sparks-frontend","owner":{"login":"SparksNetwork","id":19400238,"avatar_url":"https://avatars.githubusercontent.com/u/19400238?v=3","gravatar_id":"","url":"https://api.github.com/users/SparksNetwork","html_url":"https://github.com/SparksNetwork","followers_url":"https://api.github.com/users/SparksNetwork/followers","following_url":"https://api.github.com/users/SparksNetwork/following{/other_user}","gists_url":"https://api.github.com/users/SparksNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/SparksNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparksNetwork/subscriptions","organizations_url":"https://api.github.com/users/SparksNetwork/orgs","repos_url":"https://api.github.com/users/SparksNetwork/repos","events_url":"https://api.github.com/users/SparksNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/SparksNetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SparksNetwork/sparks-frontend","description":"Sparks.Network Frontend","fork":false,"url":"https://api.github.com/repos/SparksNetwork/sparks-frontend","forks_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/forks","keys_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/teams","hooks_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/hooks","issue_events_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/events","assignees_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/tags","blobs_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/languages","stargazers_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/stargazers","contributors_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/contributors","subscribers_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/subscribers","subscription_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/subscription","commits_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/merges","archive_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/downloads","issues_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/labels{/name}","releases_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/deployments","created_at":"2016-08-27T16:02:55Z","updated_at":"2016-10-24T17:57:07Z","pushed_at":"2016-10-27T02:36:08Z","git_url":"git://github.com/SparksNetwork/sparks-frontend.git","ssh_url":"git@github.com:SparksNetwork/sparks-frontend.git","clone_url":"https://github.com/SparksNetwork/sparks-frontend.git","svn_url":"https://github.com/SparksNetwork/sparks-frontend","homepage":null,"size":1130,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"release"}},"base":{"label":"SparksNetwork:release","ref":"release","sha":"6233ec5b37405958ce8ca9c44a2ccaad89aad592","user":{"login":"SparksNetwork","id":19400238,"avatar_url":"https://avatars.githubusercontent.com/u/19400238?v=3","gravatar_id":"","url":"https://api.github.com/users/SparksNetwork","html_url":"https://github.com/SparksNetwork","followers_url":"https://api.github.com/users/SparksNetwork/followers","following_url":"https://api.github.com/users/SparksNetwork/following{/other_user}","gists_url":"https://api.github.com/users/SparksNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/SparksNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparksNetwork/subscriptions","organizations_url":"https://api.github.com/users/SparksNetwork/orgs","repos_url":"https://api.github.com/users/SparksNetwork/repos","events_url":"https://api.github.com/users/SparksNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/SparksNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":66723009,"name":"sparks-frontend","full_name":"SparksNetwork/sparks-frontend","owner":{"login":"SparksNetwork","id":19400238,"avatar_url":"https://avatars.githubusercontent.com/u/19400238?v=3","gravatar_id":"","url":"https://api.github.com/users/SparksNetwork","html_url":"https://github.com/SparksNetwork","followers_url":"https://api.github.com/users/SparksNetwork/followers","following_url":"https://api.github.com/users/SparksNetwork/following{/other_user}","gists_url":"https://api.github.com/users/SparksNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/SparksNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparksNetwork/subscriptions","organizations_url":"https://api.github.com/users/SparksNetwork/orgs","repos_url":"https://api.github.com/users/SparksNetwork/repos","events_url":"https://api.github.com/users/SparksNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/SparksNetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SparksNetwork/sparks-frontend","description":"Sparks.Network Frontend","fork":false,"url":"https://api.github.com/repos/SparksNetwork/sparks-frontend","forks_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/forks","keys_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/teams","hooks_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/hooks","issue_events_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/events","assignees_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/tags","blobs_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/languages","stargazers_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/stargazers","contributors_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/contributors","subscribers_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/subscribers","subscription_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/subscription","commits_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/merges","archive_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/downloads","issues_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/labels{/name}","releases_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/SparksNetwork/sparks-frontend/deployments","created_at":"2016-08-27T16:02:55Z","updated_at":"2016-10-24T17:57:07Z","pushed_at":"2016-10-27T02:36:08Z","git_url":"git://github.com/SparksNetwork/sparks-frontend.git","ssh_url":"git@github.com:SparksNetwork/sparks-frontend.git","clone_url":"https://github.com/SparksNetwork/sparks-frontend.git","svn_url":"https://github.com/SparksNetwork/sparks-frontend","homepage":null,"size":1130,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":3,"default_branch":"release"}},"_links":{"self":{"href":"https://api.github.com/repos/SparksNetwork/sparks-frontend/pulls/42"},"html":{"href":"https://github.com/SparksNetwork/sparks-frontend/pull/42"},"issue":{"href":"https://api.github.com/repos/SparksNetwork/sparks-frontend/issues/42"},"comments":{"href":"https://api.github.com/repos/SparksNetwork/sparks-frontend/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/SparksNetwork/sparks-frontend/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/SparksNetwork/sparks-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SparksNetwork/sparks-frontend/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/SparksNetwork/sparks-frontend/statuses/0351ea523913741bcd72bfa9279f5bd42621591d"}}}}
{"actor":{"display_login":"Frikki"}}