{"action":"created","comment":{"url":"https://api.github.com/repos/basho/tools.mk/pulls/comments/88317103","pull_request_review_id":8894478,"id":88317103,"diff_hunk":"@@ -35,9 +35,14 @@ EUNIT_OPTS ?=\n compile-no-deps:\n \t${REBAR} compile skip_deps=true\n \n-test: compile\n+test: ct eunit","path":"tools.mk","position":5,"original_position":5,"commit_id":"c7a784c53328b1fad9aa3c10a670bf7dfc331201","original_commit_id":"c7a784c53328b1fad9aa3c10a670bf7dfc331201","user":{"login":"nickelization","id":4108538,"avatar_url":"https://avatars.githubusercontent.com/u/4108538?v=3","gravatar_id":"","url":"https://api.github.com/users/nickelization","html_url":"https://github.com/nickelization","followers_url":"https://api.github.com/users/nickelization/followers","following_url":"https://api.github.com/users/nickelization/following{/other_user}","gists_url":"https://api.github.com/users/nickelization/gists{/gist_id}","starred_url":"https://api.github.com/users/nickelization/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickelization/subscriptions","organizations_url":"https://api.github.com/users/nickelization/orgs","repos_url":"https://api.github.com/users/nickelization/repos","events_url":"https://api.github.com/users/nickelization/events{/privacy}","received_events_url":"https://api.github.com/users/nickelization/received_events","type":"User","site_admin":false},"body":"@lukebakken already covered that in the PR description ;)","created_at":"2016-11-16T19:50:28Z","updated_at":"2016-11-16T19:50:28Z","html_url":"https://github.com/basho/tools.mk/pull/14#discussion_r88317103","pull_request_url":"https://api.github.com/repos/basho/tools.mk/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/basho/tools.mk/pulls/comments/88317103"},"html":{"href":"https://github.com/basho/tools.mk/pull/14#discussion_r88317103"},"pull_request":{"href":"https://api.github.com/repos/basho/tools.mk/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/basho/tools.mk/pulls/14","id":94035835,"html_url":"https://github.com/basho/tools.mk/pull/14","diff_url":"https://github.com/basho/tools.mk/pull/14.diff","patch_url":"https://github.com/basho/tools.mk/pull/14.patch","issue_url":"https://api.github.com/repos/basho/tools.mk/issues/14","number":14,"state":"open","locked":false,"title":"Add Common Test support, and add ct to test target","user":{"login":"nickelization","id":4108538,"avatar_url":"https://avatars.githubusercontent.com/u/4108538?v=3","gravatar_id":"","url":"https://api.github.com/users/nickelization","html_url":"https://github.com/nickelization","followers_url":"https://api.github.com/users/nickelization/followers","following_url":"https://api.github.com/users/nickelization/following{/other_user}","gists_url":"https://api.github.com/users/nickelization/gists{/gist_id}","starred_url":"https://api.github.com/users/nickelization/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickelization/subscriptions","organizations_url":"https://api.github.com/users/nickelization/orgs","repos_url":"https://api.github.com/users/nickelization/repos","events_url":"https://api.github.com/users/nickelization/events{/privacy}","received_events_url":"https://api.github.com/users/nickelization/received_events","type":"User","site_admin":false},"body":"This adds support for Erlang unit tests written in the Common Test framework via the `ct` target, and also adds the `ct` target to the `test` target so that running \"make test\" will run tests in both EUnit suites and Common Test suites.\r\n\r\nIf an existing repository doesn't have any Common Test suites implemented, rebar will log that fact and continue, so this should maintain compatibility for existing users of tools.mk without breaking anything.","created_at":"2016-11-16T19:43:39Z","updated_at":"2016-11-16T19:50:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"981a2b8e32a495fff8efe768a3c0b6052e2a4c24","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/basho/tools.mk/pulls/14/commits","review_comments_url":"https://api.github.com/repos/basho/tools.mk/pulls/14/comments","review_comment_url":"https://api.github.com/repos/basho/tools.mk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/basho/tools.mk/issues/14/comments","statuses_url":"https://api.github.com/repos/basho/tools.mk/statuses/c7a784c53328b1fad9aa3c10a670bf7dfc331201","head":{"label":"basho:feature/common-test-support","ref":"feature/common-test-support","sha":"c7a784c53328b1fad9aa3c10a670bf7dfc331201","user":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"repo":{"id":17219881,"name":"tools.mk","full_name":"basho/tools.mk","owner":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basho/tools.mk","description":"A small makefile library for working with erlang tools","fork":false,"url":"https://api.github.com/repos/basho/tools.mk","forks_url":"https://api.github.com/repos/basho/tools.mk/forks","keys_url":"https://api.github.com/repos/basho/tools.mk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basho/tools.mk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basho/tools.mk/teams","hooks_url":"https://api.github.com/repos/basho/tools.mk/hooks","issue_events_url":"https://api.github.com/repos/basho/tools.mk/issues/events{/number}","events_url":"https://api.github.com/repos/basho/tools.mk/events","assignees_url":"https://api.github.com/repos/basho/tools.mk/assignees{/user}","branches_url":"https://api.github.com/repos/basho/tools.mk/branches{/branch}","tags_url":"https://api.github.com/repos/basho/tools.mk/tags","blobs_url":"https://api.github.com/repos/basho/tools.mk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basho/tools.mk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basho/tools.mk/git/refs{/sha}","trees_url":"https://api.github.com/repos/basho/tools.mk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basho/tools.mk/statuses/{sha}","languages_url":"https://api.github.com/repos/basho/tools.mk/languages","stargazers_url":"https://api.github.com/repos/basho/tools.mk/stargazers","contributors_url":"https://api.github.com/repos/basho/tools.mk/contributors","subscribers_url":"https://api.github.com/repos/basho/tools.mk/subscribers","subscription_url":"https://api.github.com/repos/basho/tools.mk/subscription","commits_url":"https://api.github.com/repos/basho/tools.mk/commits{/sha}","git_commits_url":"https://api.github.com/repos/basho/tools.mk/git/commits{/sha}","comments_url":"https://api.github.com/repos/basho/tools.mk/comments{/number}","issue_comment_url":"https://api.github.com/repos/basho/tools.mk/issues/comments{/number}","contents_url":"https://api.github.com/repos/basho/tools.mk/contents/{+path}","compare_url":"https://api.github.com/repos/basho/tools.mk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basho/tools.mk/merges","archive_url":"https://api.github.com/repos/basho/tools.mk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basho/tools.mk/downloads","issues_url":"https://api.github.com/repos/basho/tools.mk/issues{/number}","pulls_url":"https://api.github.com/repos/basho/tools.mk/pulls{/number}","milestones_url":"https://api.github.com/repos/basho/tools.mk/milestones{/number}","notifications_url":"https://api.github.com/repos/basho/tools.mk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basho/tools.mk/labels{/name}","releases_url":"https://api.github.com/repos/basho/tools.mk/releases{/id}","deployments_url":"https://api.github.com/repos/basho/tools.mk/deployments","created_at":"2014-02-26T18:04:57Z","updated_at":"2016-11-16T18:15:10Z","pushed_at":"2016-11-16T19:43:39Z","git_url":"git://github.com/basho/tools.mk.git","ssh_url":"git@github.com:basho/tools.mk.git","clone_url":"https://github.com/basho/tools.mk.git","svn_url":"https://github.com/basho/tools.mk","homepage":null,"size":24,"stargazers_count":13,"watchers_count":13,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":13,"default_branch":"master"}},"base":{"label":"basho:master","ref":"master","sha":"d275fe0fbdfcdbebe80138640d553842b2796840","user":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"repo":{"id":17219881,"name":"tools.mk","full_name":"basho/tools.mk","owner":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basho/tools.mk","description":"A small makefile library for working with erlang tools","fork":false,"url":"https://api.github.com/repos/basho/tools.mk","forks_url":"https://api.github.com/repos/basho/tools.mk/forks","keys_url":"https://api.github.com/repos/basho/tools.mk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basho/tools.mk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basho/tools.mk/teams","hooks_url":"https://api.github.com/repos/basho/tools.mk/hooks","issue_events_url":"https://api.github.com/repos/basho/tools.mk/issues/events{/number}","events_url":"https://api.github.com/repos/basho/tools.mk/events","assignees_url":"https://api.github.com/repos/basho/tools.mk/assignees{/user}","branches_url":"https://api.github.com/repos/basho/tools.mk/branches{/branch}","tags_url":"https://api.github.com/repos/basho/tools.mk/tags","blobs_url":"https://api.github.com/repos/basho/tools.mk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basho/tools.mk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basho/tools.mk/git/refs{/sha}","trees_url":"https://api.github.com/repos/basho/tools.mk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basho/tools.mk/statuses/{sha}","languages_url":"https://api.github.com/repos/basho/tools.mk/languages","stargazers_url":"https://api.github.com/repos/basho/tools.mk/stargazers","contributors_url":"https://api.github.com/repos/basho/tools.mk/contributors","subscribers_url":"https://api.github.com/repos/basho/tools.mk/subscribers","subscription_url":"https://api.github.com/repos/basho/tools.mk/subscription","commits_url":"https://api.github.com/repos/basho/tools.mk/commits{/sha}","git_commits_url":"https://api.github.com/repos/basho/tools.mk/git/commits{/sha}","comments_url":"https://api.github.com/repos/basho/tools.mk/comments{/number}","issue_comment_url":"https://api.github.com/repos/basho/tools.mk/issues/comments{/number}","contents_url":"https://api.github.com/repos/basho/tools.mk/contents/{+path}","compare_url":"https://api.github.com/repos/basho/tools.mk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basho/tools.mk/merges","archive_url":"https://api.github.com/repos/basho/tools.mk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basho/tools.mk/downloads","issues_url":"https://api.github.com/repos/basho/tools.mk/issues{/number}","pulls_url":"https://api.github.com/repos/basho/tools.mk/pulls{/number}","milestones_url":"https://api.github.com/repos/basho/tools.mk/milestones{/number}","notifications_url":"https://api.github.com/repos/basho/tools.mk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basho/tools.mk/labels{/name}","releases_url":"https://api.github.com/repos/basho/tools.mk/releases{/id}","deployments_url":"https://api.github.com/repos/basho/tools.mk/deployments","created_at":"2014-02-26T18:04:57Z","updated_at":"2016-11-16T18:15:10Z","pushed_at":"2016-11-16T19:43:39Z","git_url":"git://github.com/basho/tools.mk.git","ssh_url":"git@github.com:basho/tools.mk.git","clone_url":"https://github.com/basho/tools.mk.git","svn_url":"https://github.com/basho/tools.mk","homepage":null,"size":24,"stargazers_count":13,"watchers_count":13,"language":"Makefile","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/basho/tools.mk/pulls/14"},"html":{"href":"https://github.com/basho/tools.mk/pull/14"},"issue":{"href":"https://api.github.com/repos/basho/tools.mk/issues/14"},"comments":{"href":"https://api.github.com/repos/basho/tools.mk/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/basho/tools.mk/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/basho/tools.mk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/basho/tools.mk/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/basho/tools.mk/statuses/c7a784c53328b1fad9aa3c10a670bf7dfc331201"}}}}
{"actor":{"display_login":"nickelization"}}