{"action":"created","issue":{"url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/2274","labels_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/2274/labels{/name}","comments_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/2274/comments","events_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/2274/events","html_url":"https://github.com/shuyangzhou/liferay-portal/pull/2274","id":126447210,"number":2274,"title":"Lps 62025 Should always use JspFactoryWrapper to improve performance","user":{"login":"tinatian","id":860623,"avatar_url":"https://avatars.githubusercontent.com/u/860623?v=3","gravatar_id":"","url":"https://api.github.com/users/tinatian","html_url":"https://github.com/tinatian","followers_url":"https://api.github.com/users/tinatian/followers","following_url":"https://api.github.com/users/tinatian/following{/other_user}","gists_url":"https://api.github.com/users/tinatian/gists{/gist_id}","starred_url":"https://api.github.com/users/tinatian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinatian/subscriptions","organizations_url":"https://api.github.com/users/tinatian/orgs","repos_url":"https://api.github.com/users/tinatian/repos","events_url":"https://api.github.com/users/tinatian/events{/privacy}","received_events_url":"https://api.github.com/users/tinatian/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-01-13T15:45:38Z","updated_at":"2016-01-14T00:21:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/2274","html_url":"https://github.com/shuyangzhou/liferay-portal/pull/2274","diff_url":"https://github.com/shuyangzhou/liferay-portal/pull/2274.diff","patch_url":"https://github.com/shuyangzhou/liferay-portal/pull/2274.patch"},"body":"Hi Shuyang,\r\n\r\nCurrently the jsp files in bundles are using the default JspFactory instead of our improved version JspFactoryWrapper, this fix is to make bundles use JspFactoryWrapper which would improve performance on tomcat.\r\n\r\nLily has tested \"login\" with this change, and session count increased by 8%. This should also work with other test cases, but we has not been tested them yet.\r\n\r\n\r\nTina.\r\n"},"comment":{"url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/comments/171482062","html_url":"https://github.com/shuyangzhou/liferay-portal/pull/2274#issuecomment-171482062","issue_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/2274","id":171482062,"user":{"login":"liferay-continuous-integration","id":4502793,"avatar_url":"https://avatars.githubusercontent.com/u/4502793?v=3","gravatar_id":"","url":"https://api.github.com/users/liferay-continuous-integration","html_url":"https://github.com/liferay-continuous-integration","followers_url":"https://api.github.com/users/liferay-continuous-integration/followers","following_url":"https://api.github.com/users/liferay-continuous-integration/following{/other_user}","gists_url":"https://api.github.com/users/liferay-continuous-integration/gists{/gist_id}","starred_url":"https://api.github.com/users/liferay-continuous-integration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liferay-continuous-integration/subscriptions","organizations_url":"https://api.github.com/users/liferay-continuous-integration/orgs","repos_url":"https://api.github.com/users/liferay-continuous-integration/repos","events_url":"https://api.github.com/users/liferay-continuous-integration/events{/privacy}","received_events_url":"https://api.github.com/users/liferay-continuous-integration/received_events","type":"User","site_admin":false},"created_at":"2016-01-14T00:21:24Z","updated_at":"2016-01-14T00:21:24Z","body":"<h1>Some tests FAILED!</h1><p>Build Time: 1 hour 20 minutes 59 seconds</p><h4>Base Branch:</h4><p>Branch Name: <a href=\"https://github.com/liferay/liferay-portal/tree/master\">master</a><br />Branch GIT ID: <a href=\"https://github.com/liferay/liferay-portal/commit/3269127dbb8c627a2e2ce0a5d5b5ea39d3c62454\">3269127dbb8c627a2e2ce0a5d5b5ea39d3c62454</a></p><h4>Job Summary:</h4><ul><li><strike><strong><a href=\"https://test-1-12.liferay.com/job/test-portal-acceptance-pullrequest(master)/766/\">test-portal-acceptance-pullrequest(master)</a></strong></strike></li><li><a href=\"https://test-1-13.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/13815/\">test-portal-acceptance-pullrequest-batch(master)/compile-jsp</a></li><li><a href=\"https://test-1-13.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/13816/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-hypersonic/0</a></li><li><a href=\"https://test-1-20.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/13060/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/0</a></li><li><a href=\"https://test-1-16.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/14606/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/1</a></li><li><a href=\"https://test-1-8.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/21495/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/2</a></li><li><a href=\"https://test-1-14.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/13204/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/3</a></li><li><a href=\"https://test-1-9.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/14431/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/4</a></li><li><a href=\"https://test-1-10.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/14442/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/5</a></li><li><a href=\"https://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/21460/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/6</a></li><li><a href=\"https://test-1-13.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/13817/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/7</a></li><li><a href=\"https://test-1-3.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/21588/\">test-portal-acceptance-pullrequest-batch(master)/integration-hypersonic</a></li><li><a href=\"https://test-1-6.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/20767/\">test-portal-acceptance-pullrequest-batch(master)/integration-mysql</a></li><li><a href=\"https://test-1-16.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/14607/\">test-portal-acceptance-pullrequest-batch(master)/integration-postgresql</a></li><li><a href=\"https://test-1-3.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/21589/\">test-portal-acceptance-pullrequest-batch(master)/modules-integration-hypersonic</a></li><li><a href=\"https://test-1-11.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/13839/\">test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql</a></li><li><a href=\"https://test-1-13.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/13818/\">test-portal-acceptance-pullrequest-batch(master)/modules-integration-postgresql</a></li><li><strike><strong><a href=\"https://test-1-2.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/21753/\">test-portal-acceptance-pullrequest-batch(master)/modules-unit</a></strong></strike></li><li><a href=\"https://test-1-8.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/21496/\">test-portal-acceptance-pullrequest-batch(master)/plugins-compile</a></li><li><a href=\"https://test-1-6.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/20768/\">test-portal-acceptance-pullrequest-batch(master)/portal-web</a></li><li><a href=\"https://test-1-19.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/10901/\">test-portal-acceptance-pullrequest-batch(master)/ruby-sass-compiler</a></li><li><a href=\"https://test-1-8.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/21497/\">test-portal-acceptance-pullrequest-batch(master)/service-builder</a></li><li><a href=\"https://test-1-6.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/20769/\">test-portal-acceptance-pullrequest-batch(master)/tck</a></li><li><a href=\"https://test-1-8.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/21498/\">test-portal-acceptance-pullrequest-batch(master)/unit</a></li><li><a href=\"https://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest-source(master)/1944/\">test-portal-acceptance-pullrequest-source(master)</a></li></ul><h5>For more details click <a href=\"https://test-1-12.liferay.com//userContent/jobs/test-portal-acceptance-pullrequest(master)/builds/766/jenkins-report.html\">here</a>.</h5><hr /><h4>Failed Jobs:</h4><ol><li><h5><a href=\"https://test-1-12.liferay.com/job/test-portal-acceptance-pullrequest(master)/766/\">test-portal-acceptance-pullrequest(master)</a></h5><h6>Job Results:</h6><p>23 Jobs Passed.<br />2 Jobs Failed.</p><pre>Completed with the status of FAILURE.</pre></li><li><h5 job-result=\"UNSTABLE\"><a href=\"https://test-1-2.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/21753/\">test-portal-acceptance-pullrequest-batch(master)/modules-unit</a></h5><h6>Job Results:</h6><p>1120 Tests Passed.<br />1 Test Failed.</p><ol><li><a href=\"https://test-1-2.liferay.com/job/test-portal-acceptance-pullrequest-batch%28master%29/AXIS_VARIABLE=1,label_exp=!master/21753//testReport/com.liferay.source.formatter/SourceFormatterTest/testSourceFormatter\">SourceFormatterTest.testSourceFormatter</a></li></ol></li></ol>"}}