{"action":"created","comment":{"url":"https://api.github.com/repos/scality/S3/pulls/comments/73698993","id":73698993,"diff_hunk":"@@ -0,0 +1,165 @@\n+import crypto from 'crypto';\n+import { errors } from 'arsenal';\n+\n+/** Class exposing common createDataKey,\n+createDecipher and createCipher functions. */\n+export default class Common {","path":"lib/kms/common.js","position":6,"original_position":6,"commit_id":"1e6c91cbf434328a2f848180deacd6fcc6cf62c7","original_commit_id":"1e6c91cbf434328a2f848180deacd6fcc6cf62c7","user":{"login":"alexandre-merle","id":18259837,"avatar_url":"https://avatars.githubusercontent.com/u/18259837?v=3","gravatar_id":"","url":"https://api.github.com/users/alexandre-merle","html_url":"https://github.com/alexandre-merle","followers_url":"https://api.github.com/users/alexandre-merle/followers","following_url":"https://api.github.com/users/alexandre-merle/following{/other_user}","gists_url":"https://api.github.com/users/alexandre-merle/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandre-merle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandre-merle/subscriptions","organizations_url":"https://api.github.com/users/alexandre-merle/orgs","repos_url":"https://api.github.com/users/alexandre-merle/repos","events_url":"https://api.github.com/users/alexandre-merle/events{/privacy}","received_events_url":"https://api.github.com/users/alexandre-merle/received_events","type":"User","site_admin":false},"body":"both are okay :)","created_at":"2016-08-05T14:16:19Z","updated_at":"2016-08-05T14:16:19Z","html_url":"https://github.com/scality/S3/pull/110#discussion_r73698993","pull_request_url":"https://api.github.com/repos/scality/S3/pulls/110","_links":{"self":{"href":"https://api.github.com/repos/scality/S3/pulls/comments/73698993"},"html":{"href":"https://github.com/scality/S3/pull/110#discussion_r73698993"},"pull_request":{"href":"https://api.github.com/repos/scality/S3/pulls/110"}}},"pull_request":{"url":"https://api.github.com/repos/scality/S3/pulls/110","id":79803240,"html_url":"https://github.com/scality/S3/pull/110","diff_url":"https://github.com/scality/S3/pull/110.diff","patch_url":"https://github.com/scality/S3/pull/110.patch","issue_url":"https://api.github.com/repos/scality/S3/issues/110","number":110,"state":"open","locked":false,"title":"Ft/kms","user":{"login":"ploki","id":1005355,"avatar_url":"https://avatars.githubusercontent.com/u/1005355?v=3","gravatar_id":"","url":"https://api.github.com/users/ploki","html_url":"https://github.com/ploki","followers_url":"https://api.github.com/users/ploki/followers","following_url":"https://api.github.com/users/ploki/following{/other_user}","gists_url":"https://api.github.com/users/ploki/gists{/gist_id}","starred_url":"https://api.github.com/users/ploki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ploki/subscriptions","organizations_url":"https://api.github.com/users/ploki/orgs","repos_url":"https://api.github.com/users/ploki/repos","events_url":"https://api.github.com/users/ploki/events{/privacy}","received_events_url":"https://api.github.com/users/ploki/received_events","type":"User","site_admin":false},"body":"Key Management System (for server side encryption usage)\r\n\r\nplease, review the last commit, as others are part of different pull requests.","created_at":"2016-08-02T20:30:31Z","updated_at":"2016-08-05T14:16:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"187bb46d65c106fd5f48fb4d9e78f9781380215d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scality/S3/pulls/110/commits","review_comments_url":"https://api.github.com/repos/scality/S3/pulls/110/comments","review_comment_url":"https://api.github.com/repos/scality/S3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scality/S3/issues/110/comments","statuses_url":"https://api.github.com/repos/scality/S3/statuses/1e6c91cbf434328a2f848180deacd6fcc6cf62c7","head":{"label":"scality:ft/kms","ref":"ft/kms","sha":"1e6c91cbf434328a2f848180deacd6fcc6cf62c7","user":{"login":"scality","id":383812,"avatar_url":"https://avatars.githubusercontent.com/u/383812?v=3","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"repo":{"id":60165924,"name":"S3","full_name":"scality/S3","owner":{"login":"scality","id":383812,"avatar_url":"https://avatars.githubusercontent.com/u/383812?v=3","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scality/S3","description":"An open-source Node.js implementation of a server handling the S3 protocol","fork":false,"url":"https://api.github.com/repos/scality/S3","forks_url":"https://api.github.com/repos/scality/S3/forks","keys_url":"https://api.github.com/repos/scality/S3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scality/S3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scality/S3/teams","hooks_url":"https://api.github.com/repos/scality/S3/hooks","issue_events_url":"https://api.github.com/repos/scality/S3/issues/events{/number}","events_url":"https://api.github.com/repos/scality/S3/events","assignees_url":"https://api.github.com/repos/scality/S3/assignees{/user}","branches_url":"https://api.github.com/repos/scality/S3/branches{/branch}","tags_url":"https://api.github.com/repos/scality/S3/tags","blobs_url":"https://api.github.com/repos/scality/S3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scality/S3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scality/S3/git/refs{/sha}","trees_url":"https://api.github.com/repos/scality/S3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scality/S3/statuses/{sha}","languages_url":"https://api.github.com/repos/scality/S3/languages","stargazers_url":"https://api.github.com/repos/scality/S3/stargazers","contributors_url":"https://api.github.com/repos/scality/S3/contributors","subscribers_url":"https://api.github.com/repos/scality/S3/subscribers","subscription_url":"https://api.github.com/repos/scality/S3/subscription","commits_url":"https://api.github.com/repos/scality/S3/commits{/sha}","git_commits_url":"https://api.github.com/repos/scality/S3/git/commits{/sha}","comments_url":"https://api.github.com/repos/scality/S3/comments{/number}","issue_comment_url":"https://api.github.com/repos/scality/S3/issues/comments{/number}","contents_url":"https://api.github.com/repos/scality/S3/contents/{+path}","compare_url":"https://api.github.com/repos/scality/S3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scality/S3/merges","archive_url":"https://api.github.com/repos/scality/S3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scality/S3/downloads","issues_url":"https://api.github.com/repos/scality/S3/issues{/number}","pulls_url":"https://api.github.com/repos/scality/S3/pulls{/number}","milestones_url":"https://api.github.com/repos/scality/S3/milestones{/number}","notifications_url":"https://api.github.com/repos/scality/S3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scality/S3/labels{/name}","releases_url":"https://api.github.com/repos/scality/S3/releases{/id}","deployments_url":"https://api.github.com/repos/scality/S3/deployments","created_at":"2016-06-01T09:58:56Z","updated_at":"2016-08-04T07:40:28Z","pushed_at":"2016-08-05T13:17:57Z","git_url":"git://github.com/scality/S3.git","ssh_url":"git@github.com:scality/S3.git","clone_url":"https://github.com/scality/S3.git","svn_url":"https://github.com/scality/S3","homepage":"http://s3.scality.com","size":3141,"stargazers_count":173,"watchers_count":173,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":19,"forks":10,"open_issues":19,"watchers":173,"default_branch":"master"}},"base":{"label":"scality:master","ref":"master","sha":"4babe4cca8428a3bc0f78111f23be7d56db60767","user":{"login":"scality","id":383812,"avatar_url":"https://avatars.githubusercontent.com/u/383812?v=3","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"repo":{"id":60165924,"name":"S3","full_name":"scality/S3","owner":{"login":"scality","id":383812,"avatar_url":"https://avatars.githubusercontent.com/u/383812?v=3","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scality/S3","description":"An open-source Node.js implementation of a server handling the S3 protocol","fork":false,"url":"https://api.github.com/repos/scality/S3","forks_url":"https://api.github.com/repos/scality/S3/forks","keys_url":"https://api.github.com/repos/scality/S3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scality/S3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scality/S3/teams","hooks_url":"https://api.github.com/repos/scality/S3/hooks","issue_events_url":"https://api.github.com/repos/scality/S3/issues/events{/number}","events_url":"https://api.github.com/repos/scality/S3/events","assignees_url":"https://api.github.com/repos/scality/S3/assignees{/user}","branches_url":"https://api.github.com/repos/scality/S3/branches{/branch}","tags_url":"https://api.github.com/repos/scality/S3/tags","blobs_url":"https://api.github.com/repos/scality/S3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scality/S3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scality/S3/git/refs{/sha}","trees_url":"https://api.github.com/repos/scality/S3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scality/S3/statuses/{sha}","languages_url":"https://api.github.com/repos/scality/S3/languages","stargazers_url":"https://api.github.com/repos/scality/S3/stargazers","contributors_url":"https://api.github.com/repos/scality/S3/contributors","subscribers_url":"https://api.github.com/repos/scality/S3/subscribers","subscription_url":"https://api.github.com/repos/scality/S3/subscription","commits_url":"https://api.github.com/repos/scality/S3/commits{/sha}","git_commits_url":"https://api.github.com/repos/scality/S3/git/commits{/sha}","comments_url":"https://api.github.com/repos/scality/S3/comments{/number}","issue_comment_url":"https://api.github.com/repos/scality/S3/issues/comments{/number}","contents_url":"https://api.github.com/repos/scality/S3/contents/{+path}","compare_url":"https://api.github.com/repos/scality/S3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scality/S3/merges","archive_url":"https://api.github.com/repos/scality/S3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scality/S3/downloads","issues_url":"https://api.github.com/repos/scality/S3/issues{/number}","pulls_url":"https://api.github.com/repos/scality/S3/pulls{/number}","milestones_url":"https://api.github.com/repos/scality/S3/milestones{/number}","notifications_url":"https://api.github.com/repos/scality/S3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scality/S3/labels{/name}","releases_url":"https://api.github.com/repos/scality/S3/releases{/id}","deployments_url":"https://api.github.com/repos/scality/S3/deployments","created_at":"2016-06-01T09:58:56Z","updated_at":"2016-08-04T07:40:28Z","pushed_at":"2016-08-05T13:17:57Z","git_url":"git://github.com/scality/S3.git","ssh_url":"git@github.com:scality/S3.git","clone_url":"https://github.com/scality/S3.git","svn_url":"https://github.com/scality/S3","homepage":"http://s3.scality.com","size":3141,"stargazers_count":173,"watchers_count":173,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":19,"forks":10,"open_issues":19,"watchers":173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scality/S3/pulls/110"},"html":{"href":"https://github.com/scality/S3/pull/110"},"issue":{"href":"https://api.github.com/repos/scality/S3/issues/110"},"comments":{"href":"https://api.github.com/repos/scality/S3/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/scality/S3/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/scality/S3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scality/S3/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/scality/S3/statuses/1e6c91cbf434328a2f848180deacd6fcc6cf62c7"}}}}
{"actor":{"display_login":"alexandre-merle"}}