{"action":"created","comment":{"url":"https://api.github.com/repos/Talend/react-talend-components/pulls/comments/93032428","pull_request_review_id":13552526,"id":93032428,"diff_hunk":"@@ -50,71 +47,84 @@ $tc-typeahead-items-list-shadow-color: #CCC;\n \tcolor: $tc-typeahead-only-icon-color;\n }\n \n-/************************************* Container Open **************************************/\n .items-container {\n \tdisplay: none;\n+\tposition: absolute;\n+\tmargin-top: 5px;\n+\ttop: 100%;\n+\tmax-height: 70vh;\n+\tmin-width: $tc-typeahead-input-width;\n+\tfont-size: 15px;\n+\tbackground-color: $tc-typeahead-opened-items-container-background-color;\n+\tborder-radius: 4px;\n+\tbox-shadow: 0px 1px 3px 0px $tc-typeahead-items-shadow-color;\n+\toverflow-y: auto;\n+}\n+\n+.is-searching,\n+.no-result {\n+\tpadding: 15px;\n+\tfont-size: 15px;\n+\tfont-style: italic;\n+\tcolor: $tc-typeahead-item-description-color;\n }\n \n-.container-open {\n-\t.items-container {\n-\t\tdisplay: block;\n-\t\tposition: absolute;\n-\t\ttop: 100%;\n-\t\tmin-width: $tc-typeahead-input-width;\n-\t\tbackground-color: $tc-typeahead-opened-items-container-background-color;\n-\t\tborder-radius: 4px;\n-\t\tbox-shadow: 1px 1px 5px 1px $tc-typeahead-items-list-shadow-color;\n-\t\tmax-height: 70vh;\n-\t\toverflow-y: auto;\n+.is-searching,\n+.no-result,\n+.container-open .items-container {\n+\tdisplay: block;\n+\tpadding-top: 1px;\n+\tpadding-bottom: 1px;\n+}\n+\n+.is-searching {\n+\tdisplay: flex;\n+\toverflow: hidden;","path":"src/Typeahead/Typeahead.scss","position":82,"original_position":82,"commit_id":"2d13639fe75174f7a343fc1e97d887f821b140b3","original_commit_id":"2d13639fe75174f7a343fc1e97d887f821b140b3","user":{"login":"frassinier","id":18534166,"avatar_url":"https://avatars.githubusercontent.com/u/18534166?v=3","gravatar_id":"","url":"https://api.github.com/users/frassinier","html_url":"https://github.com/frassinier","followers_url":"https://api.github.com/users/frassinier/followers","following_url":"https://api.github.com/users/frassinier/following{/other_user}","gists_url":"https://api.github.com/users/frassinier/gists{/gist_id}","starred_url":"https://api.github.com/users/frassinier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frassinier/subscriptions","organizations_url":"https://api.github.com/users/frassinier/orgs","repos_url":"https://api.github.com/users/frassinier/repos","events_url":"https://api.github.com/users/frassinier/events{/privacy}","received_events_url":"https://api.github.com/users/frassinier/received_events","type":"User","site_admin":false},"body":"Because of circular component which rotates and implies overflow. ","created_at":"2016-12-19T13:38:49Z","updated_at":"2016-12-19T13:38:49Z","html_url":"https://github.com/Talend/react-talend-components/pull/173#discussion_r93032428","pull_request_url":"https://api.github.com/repos/Talend/react-talend-components/pulls/173","_links":{"self":{"href":"https://api.github.com/repos/Talend/react-talend-components/pulls/comments/93032428"},"html":{"href":"https://github.com/Talend/react-talend-components/pull/173#discussion_r93032428"},"pull_request":{"href":"https://api.github.com/repos/Talend/react-talend-components/pulls/173"}}},"pull_request":{"url":"https://api.github.com/repos/Talend/react-talend-components/pulls/173","id":98204607,"html_url":"https://github.com/Talend/react-talend-components/pull/173","diff_url":"https://github.com/Talend/react-talend-components/pull/173.diff","patch_url":"https://github.com/Talend/react-talend-components/pull/173.patch","issue_url":"https://api.github.com/repos/Talend/react-talend-components/issues/173","number":173,"state":"open","locked":false,"title":"fix(typeahead): add more states while searching","user":{"login":"frassinier","id":18534166,"avatar_url":"https://avatars.githubusercontent.com/u/18534166?v=3","gravatar_id":"","url":"https://api.github.com/users/frassinier","html_url":"https://github.com/frassinier","followers_url":"https://api.github.com/users/frassinier/followers","following_url":"https://api.github.com/users/frassinier/following{/other_user}","gists_url":"https://api.github.com/users/frassinier/gists{/gist_id}","starred_url":"https://api.github.com/users/frassinier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frassinier/subscriptions","organizations_url":"https://api.github.com/users/frassinier/orgs","repos_url":"https://api.github.com/users/frassinier/repos","events_url":"https://api.github.com/users/frassinier/events{/privacy}","received_events_url":"https://api.github.com/users/frassinier/received_events","type":"User","site_admin":false},"body":"**Please check if the PR fulfills these requirements**\r\n\r\n- [x] The commit(s) message(s) follows our [guidelines](https://github.com/talend/tools/blob/master/tools-root-github/CONTRIBUTING.md#commit-message-format)\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [x] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n**What kind of change does this PR introduce?**\r\n\r\n- [x] Bugfix\r\n- [ ] Feature\r\n- [ ] Code style update (formatting, local variables)\r\n- [ ] Refactoring (no functional changes, no api changes)\r\n- [ ] Build / CI related changes\r\n- [ ] Other... Please describe:\r\n\r\n**What is the new behavior?**\r\nadd special behavior for searching and no result cases\r\n\r\n\r\n**Does this PR introduce a breaking change?**\r\n\r\n- [ ] Yes\r\n- [x] No\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\r\n\r\n\r\n**Other information**:\r\n\r\n","created_at":"2016-12-15T18:26:16Z","updated_at":"2016-12-19T13:38:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e5b8c1f0ed7fd37c8e8e41fd2f5d257b5dbca4c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/react-talend-components/pulls/173/commits","review_comments_url":"https://api.github.com/repos/Talend/react-talend-components/pulls/173/comments","review_comment_url":"https://api.github.com/repos/Talend/react-talend-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/react-talend-components/issues/173/comments","statuses_url":"https://api.github.com/repos/Talend/react-talend-components/statuses/2d13639fe75174f7a343fc1e97d887f821b140b3","head":{"label":"Talend:fix/typeahead","ref":"fix/typeahead","sha":"2d13639fe75174f7a343fc1e97d887f821b140b3","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":70495607,"name":"react-talend-components","full_name":"Talend/react-talend-components","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/react-talend-components","description":"Set of stateless react components which implement Talend guidelines","fork":false,"url":"https://api.github.com/repos/Talend/react-talend-components","forks_url":"https://api.github.com/repos/Talend/react-talend-components/forks","keys_url":"https://api.github.com/repos/Talend/react-talend-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/react-talend-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/react-talend-components/teams","hooks_url":"https://api.github.com/repos/Talend/react-talend-components/hooks","issue_events_url":"https://api.github.com/repos/Talend/react-talend-components/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/react-talend-components/events","assignees_url":"https://api.github.com/repos/Talend/react-talend-components/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/react-talend-components/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/react-talend-components/tags","blobs_url":"https://api.github.com/repos/Talend/react-talend-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/react-talend-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/react-talend-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/react-talend-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/react-talend-components/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/react-talend-components/languages","stargazers_url":"https://api.github.com/repos/Talend/react-talend-components/stargazers","contributors_url":"https://api.github.com/repos/Talend/react-talend-components/contributors","subscribers_url":"https://api.github.com/repos/Talend/react-talend-components/subscribers","subscription_url":"https://api.github.com/repos/Talend/react-talend-components/subscription","commits_url":"https://api.github.com/repos/Talend/react-talend-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/react-talend-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/react-talend-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/react-talend-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/react-talend-components/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/react-talend-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/react-talend-components/merges","archive_url":"https://api.github.com/repos/Talend/react-talend-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/react-talend-components/downloads","issues_url":"https://api.github.com/repos/Talend/react-talend-components/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/react-talend-components/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/react-talend-components/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/react-talend-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/react-talend-components/labels{/name}","releases_url":"https://api.github.com/repos/Talend/react-talend-components/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/react-talend-components/deployments","created_at":"2016-10-10T14:22:07Z","updated_at":"2016-12-17T15:40:57Z","pushed_at":"2016-12-19T13:30:45Z","git_url":"git://github.com/Talend/react-talend-components.git","ssh_url":"git@github.com:Talend/react-talend-components.git","clone_url":"https://github.com/Talend/react-talend-components.git","svn_url":"https://github.com/Talend/react-talend-components","homepage":"https://talend.github.io/react-talend-components","size":933,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":17,"forks":1,"open_issues":17,"watchers":7,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"67332ade05bb164a602309b9b138a54703df6388","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":70495607,"name":"react-talend-components","full_name":"Talend/react-talend-components","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/react-talend-components","description":"Set of stateless react components which implement Talend guidelines","fork":false,"url":"https://api.github.com/repos/Talend/react-talend-components","forks_url":"https://api.github.com/repos/Talend/react-talend-components/forks","keys_url":"https://api.github.com/repos/Talend/react-talend-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/react-talend-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/react-talend-components/teams","hooks_url":"https://api.github.com/repos/Talend/react-talend-components/hooks","issue_events_url":"https://api.github.com/repos/Talend/react-talend-components/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/react-talend-components/events","assignees_url":"https://api.github.com/repos/Talend/react-talend-components/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/react-talend-components/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/react-talend-components/tags","blobs_url":"https://api.github.com/repos/Talend/react-talend-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/react-talend-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/react-talend-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/react-talend-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/react-talend-components/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/react-talend-components/languages","stargazers_url":"https://api.github.com/repos/Talend/react-talend-components/stargazers","contributors_url":"https://api.github.com/repos/Talend/react-talend-components/contributors","subscribers_url":"https://api.github.com/repos/Talend/react-talend-components/subscribers","subscription_url":"https://api.github.com/repos/Talend/react-talend-components/subscription","commits_url":"https://api.github.com/repos/Talend/react-talend-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/react-talend-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/react-talend-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/react-talend-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/react-talend-components/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/react-talend-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/react-talend-components/merges","archive_url":"https://api.github.com/repos/Talend/react-talend-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/react-talend-components/downloads","issues_url":"https://api.github.com/repos/Talend/react-talend-components/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/react-talend-components/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/react-talend-components/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/react-talend-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/react-talend-components/labels{/name}","releases_url":"https://api.github.com/repos/Talend/react-talend-components/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/react-talend-components/deployments","created_at":"2016-10-10T14:22:07Z","updated_at":"2016-12-17T15:40:57Z","pushed_at":"2016-12-19T13:30:45Z","git_url":"git://github.com/Talend/react-talend-components.git","ssh_url":"git@github.com:Talend/react-talend-components.git","clone_url":"https://github.com/Talend/react-talend-components.git","svn_url":"https://github.com/Talend/react-talend-components","homepage":"https://talend.github.io/react-talend-components","size":933,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":17,"forks":1,"open_issues":17,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/react-talend-components/pulls/173"},"html":{"href":"https://github.com/Talend/react-talend-components/pull/173"},"issue":{"href":"https://api.github.com/repos/Talend/react-talend-components/issues/173"},"comments":{"href":"https://api.github.com/repos/Talend/react-talend-components/issues/173/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/react-talend-components/pulls/173/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/react-talend-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/react-talend-components/pulls/173/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/react-talend-components/statuses/2d13639fe75174f7a343fc1e97d887f821b140b3"}}}}
{"actor":{"display_login":"frassinier"}}