{"action":"created","comment":{"url":"https://api.github.com/repos/sgmap/mes-aides-ui/pulls/comments/74930621","id":74930621,"diff_hunk":"@@ -72,22 +65,17 @@ <h2 class=\"text-center\">Simulez ces aides locales</h2>\n           <img ng-src=\"/img/{{ provider.imgSrc }}\" alt=\"{{ provider.label }}\"/>\n         </div>\n         <div class=\"col-md-10\">\n-          <div ng-repeat=\"droit in provider.prestations\">\n-            <div class=\"clearfix\" ng-if=\"showDetails && $even\"></div>\n-            <div class=\"col-md-6\" ng-if=\"showDetails || $index < 2\">\n-              <div class=\"row\">\n-                <div class=\"col-xs-10\">\n-                  <h3>{{ droit.label }}</h3>\n-                </div>\n-              </div>\n-              <p>{{ droit.description }}</p>\n-            </div>\n-          </div>\n+          <dl ng-repeat=\"droit in provider.prestations\" ng-if=\"showDetails || $index < 2\">\n+            <dt>{{ droit.label }}</dt>\n+            <dd>{{ droit.description }}</dd>\n+          </dl>\n+\n           <div class=\"col-md-12 showDetailsButtonBlock\">\n             <button class=\"btn\" type=\"button\" ng-show=\"!showDetails && countPrestations(provider) > 2\" ng-click=\"showDetails = ! showDetails\">\n               Voir les {{ countPrestations(provider) - 2 }} autres aides calculées\n             </button>\n           </div>\n+        </div>","path":"app/views/partials/homepage.html","position":47,"original_position":47,"commit_id":"bd1c13145df830cb73f9b7862428402653fd7cdd","original_commit_id":"bd1c13145df830cb73f9b7862428402653fd7cdd","user":{"login":"Flightan","id":1475946,"avatar_url":"https://avatars.githubusercontent.com/u/1475946?v=3","gravatar_id":"","url":"https://api.github.com/users/Flightan","html_url":"https://github.com/Flightan","followers_url":"https://api.github.com/users/Flightan/followers","following_url":"https://api.github.com/users/Flightan/following{/other_user}","gists_url":"https://api.github.com/users/Flightan/gists{/gist_id}","starred_url":"https://api.github.com/users/Flightan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flightan/subscriptions","organizations_url":"https://api.github.com/users/Flightan/orgs","repos_url":"https://api.github.com/users/Flightan/repos","events_url":"https://api.github.com/users/Flightan/events{/privacy}","received_events_url":"https://api.github.com/users/Flightan/received_events","type":"User","site_admin":false},"body":"Bonus missing closing div","created_at":"2016-08-16T13:10:35Z","updated_at":"2016-08-16T13:10:35Z","html_url":"https://github.com/sgmap/mes-aides-ui/pull/351#discussion_r74930621","pull_request_url":"https://api.github.com/repos/sgmap/mes-aides-ui/pulls/351","_links":{"self":{"href":"https://api.github.com/repos/sgmap/mes-aides-ui/pulls/comments/74930621"},"html":{"href":"https://github.com/sgmap/mes-aides-ui/pull/351#discussion_r74930621"},"pull_request":{"href":"https://api.github.com/repos/sgmap/mes-aides-ui/pulls/351"}}},"pull_request":{"url":"https://api.github.com/repos/sgmap/mes-aides-ui/pulls/351","id":81468489,"html_url":"https://github.com/sgmap/mes-aides-ui/pull/351","diff_url":"https://github.com/sgmap/mes-aides-ui/pull/351.diff","patch_url":"https://github.com/sgmap/mes-aides-ui/pull/351.patch","issue_url":"https://api.github.com/repos/sgmap/mes-aides-ui/issues/351","number":351,"state":"open","locked":false,"title":"Convert homepage definitions to native html elements","user":{"login":"Flightan","id":1475946,"avatar_url":"https://avatars.githubusercontent.com/u/1475946?v=3","gravatar_id":"","url":"https://api.github.com/users/Flightan","html_url":"https://github.com/Flightan","followers_url":"https://api.github.com/users/Flightan/followers","following_url":"https://api.github.com/users/Flightan/following{/other_user}","gists_url":"https://api.github.com/users/Flightan/gists{/gist_id}","starred_url":"https://api.github.com/users/Flightan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flightan/subscriptions","organizations_url":"https://api.github.com/users/Flightan/orgs","repos_url":"https://api.github.com/users/Flightan/repos","events_url":"https://api.github.com/users/Flightan/events{/privacy}","received_events_url":"https://api.github.com/users/Flightan/received_events","type":"User","site_admin":false},"body":"The objective of this technique is to provide the definitions of words or phrases by presenting them in a definition list. (https://www.w3.org/TR/WCAG20-TECHS/H40.html)\r\n\r\nThis removes some ugly clearfix hacks and is overall easier to read IMO. It should be better for accessibility but I don't know how to navigate through html elements using the keyboard.","created_at":"2016-08-16T13:10:01Z","updated_at":"2016-08-16T13:10:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f51bdc61d8fbe99ce8d3b3bc23efea7ae68ed8f4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sgmap/mes-aides-ui/pulls/351/commits","review_comments_url":"https://api.github.com/repos/sgmap/mes-aides-ui/pulls/351/comments","review_comment_url":"https://api.github.com/repos/sgmap/mes-aides-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sgmap/mes-aides-ui/issues/351/comments","statuses_url":"https://api.github.com/repos/sgmap/mes-aides-ui/statuses/bd1c13145df830cb73f9b7862428402653fd7cdd","head":{"label":"sgmap:definition_lists","ref":"definition_lists","sha":"bd1c13145df830cb73f9b7862428402653fd7cdd","user":{"login":"sgmap","id":7874148,"avatar_url":"https://avatars.githubusercontent.com/u/7874148?v=3","gravatar_id":"","url":"https://api.github.com/users/sgmap","html_url":"https://github.com/sgmap","followers_url":"https://api.github.com/users/sgmap/followers","following_url":"https://api.github.com/users/sgmap/following{/other_user}","gists_url":"https://api.github.com/users/sgmap/gists{/gist_id}","starred_url":"https://api.github.com/users/sgmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgmap/subscriptions","organizations_url":"https://api.github.com/users/sgmap/orgs","repos_url":"https://api.github.com/users/sgmap/repos","events_url":"https://api.github.com/users/sgmap/events{/privacy}","received_events_url":"https://api.github.com/users/sgmap/received_events","type":"Organization","site_admin":false},"repo":{"id":18399519,"name":"mes-aides-ui","full_name":"sgmap/mes-aides-ui","owner":{"login":"sgmap","id":7874148,"avatar_url":"https://avatars.githubusercontent.com/u/7874148?v=3","gravatar_id":"","url":"https://api.github.com/users/sgmap","html_url":"https://github.com/sgmap","followers_url":"https://api.github.com/users/sgmap/followers","following_url":"https://api.github.com/users/sgmap/following{/other_user}","gists_url":"https://api.github.com/users/sgmap/gists{/gist_id}","starred_url":"https://api.github.com/users/sgmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgmap/subscriptions","organizations_url":"https://api.github.com/users/sgmap/orgs","repos_url":"https://api.github.com/users/sgmap/repos","events_url":"https://api.github.com/users/sgmap/events{/privacy}","received_events_url":"https://api.github.com/users/sgmap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sgmap/mes-aides-ui","description":"Le simulateur global des prestations sociales françaises","fork":false,"url":"https://api.github.com/repos/sgmap/mes-aides-ui","forks_url":"https://api.github.com/repos/sgmap/mes-aides-ui/forks","keys_url":"https://api.github.com/repos/sgmap/mes-aides-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sgmap/mes-aides-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sgmap/mes-aides-ui/teams","hooks_url":"https://api.github.com/repos/sgmap/mes-aides-ui/hooks","issue_events_url":"https://api.github.com/repos/sgmap/mes-aides-ui/issues/events{/number}","events_url":"https://api.github.com/repos/sgmap/mes-aides-ui/events","assignees_url":"https://api.github.com/repos/sgmap/mes-aides-ui/assignees{/user}","branches_url":"https://api.github.com/repos/sgmap/mes-aides-ui/branches{/branch}","tags_url":"https://api.github.com/repos/sgmap/mes-aides-ui/tags","blobs_url":"https://api.github.com/repos/sgmap/mes-aides-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sgmap/mes-aides-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sgmap/mes-aides-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/sgmap/mes-aides-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sgmap/mes-aides-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/sgmap/mes-aides-ui/languages","stargazers_url":"https://api.github.com/repos/sgmap/mes-aides-ui/stargazers","contributors_url":"https://api.github.com/repos/sgmap/mes-aides-ui/contributors","subscribers_url":"https://api.github.com/repos/sgmap/mes-aides-ui/subscribers","subscription_url":"https://api.github.com/repos/sgmap/mes-aides-ui/subscription","commits_url":"https://api.github.com/repos/sgmap/mes-aides-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/sgmap/mes-aides-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/sgmap/mes-aides-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/sgmap/mes-aides-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/sgmap/mes-aides-ui/contents/{+path}","compare_url":"https://api.github.com/repos/sgmap/mes-aides-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sgmap/mes-aides-ui/merges","archive_url":"https://api.github.com/repos/sgmap/mes-aides-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sgmap/mes-aides-ui/downloads","issues_url":"https://api.github.com/repos/sgmap/mes-aides-ui/issues{/number}","pulls_url":"https://api.github.com/repos/sgmap/mes-aides-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/sgmap/mes-aides-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/sgmap/mes-aides-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sgmap/mes-aides-ui/labels{/name}","releases_url":"https://api.github.com/repos/sgmap/mes-aides-ui/releases{/id}","deployments_url":"https://api.github.com/repos/sgmap/mes-aides-ui/deployments","created_at":"2014-04-03T10:42:21Z","updated_at":"2016-06-21T21:18:07Z","pushed_at":"2016-08-16T13:10:01Z","git_url":"git://github.com/sgmap/mes-aides-ui.git","ssh_url":"git@github.com:sgmap/mes-aides-ui.git","clone_url":"https://github.com/sgmap/mes-aides-ui.git","svn_url":"https://github.com/sgmap/mes-aides-ui","homepage":"https://mes-aides.gouv.fr/","size":7907,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":74,"forks":4,"open_issues":74,"watchers":40,"default_branch":"master"}},"base":{"label":"sgmap:master","ref":"master","sha":"81da32fa5046ca141f7023bcde17c94647c16d3b","user":{"login":"sgmap","id":7874148,"avatar_url":"https://avatars.githubusercontent.com/u/7874148?v=3","gravatar_id":"","url":"https://api.github.com/users/sgmap","html_url":"https://github.com/sgmap","followers_url":"https://api.github.com/users/sgmap/followers","following_url":"https://api.github.com/users/sgmap/following{/other_user}","gists_url":"https://api.github.com/users/sgmap/gists{/gist_id}","starred_url":"https://api.github.com/users/sgmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgmap/subscriptions","organizations_url":"https://api.github.com/users/sgmap/orgs","repos_url":"https://api.github.com/users/sgmap/repos","events_url":"https://api.github.com/users/sgmap/events{/privacy}","received_events_url":"https://api.github.com/users/sgmap/received_events","type":"Organization","site_admin":false},"repo":{"id":18399519,"name":"mes-aides-ui","full_name":"sgmap/mes-aides-ui","owner":{"login":"sgmap","id":7874148,"avatar_url":"https://avatars.githubusercontent.com/u/7874148?v=3","gravatar_id":"","url":"https://api.github.com/users/sgmap","html_url":"https://github.com/sgmap","followers_url":"https://api.github.com/users/sgmap/followers","following_url":"https://api.github.com/users/sgmap/following{/other_user}","gists_url":"https://api.github.com/users/sgmap/gists{/gist_id}","starred_url":"https://api.github.com/users/sgmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgmap/subscriptions","organizations_url":"https://api.github.com/users/sgmap/orgs","repos_url":"https://api.github.com/users/sgmap/repos","events_url":"https://api.github.com/users/sgmap/events{/privacy}","received_events_url":"https://api.github.com/users/sgmap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sgmap/mes-aides-ui","description":"Le simulateur global des prestations sociales françaises","fork":false,"url":"https://api.github.com/repos/sgmap/mes-aides-ui","forks_url":"https://api.github.com/repos/sgmap/mes-aides-ui/forks","keys_url":"https://api.github.com/repos/sgmap/mes-aides-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sgmap/mes-aides-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sgmap/mes-aides-ui/teams","hooks_url":"https://api.github.com/repos/sgmap/mes-aides-ui/hooks","issue_events_url":"https://api.github.com/repos/sgmap/mes-aides-ui/issues/events{/number}","events_url":"https://api.github.com/repos/sgmap/mes-aides-ui/events","assignees_url":"https://api.github.com/repos/sgmap/mes-aides-ui/assignees{/user}","branches_url":"https://api.github.com/repos/sgmap/mes-aides-ui/branches{/branch}","tags_url":"https://api.github.com/repos/sgmap/mes-aides-ui/tags","blobs_url":"https://api.github.com/repos/sgmap/mes-aides-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sgmap/mes-aides-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sgmap/mes-aides-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/sgmap/mes-aides-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sgmap/mes-aides-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/sgmap/mes-aides-ui/languages","stargazers_url":"https://api.github.com/repos/sgmap/mes-aides-ui/stargazers","contributors_url":"https://api.github.com/repos/sgmap/mes-aides-ui/contributors","subscribers_url":"https://api.github.com/repos/sgmap/mes-aides-ui/subscribers","subscription_url":"https://api.github.com/repos/sgmap/mes-aides-ui/subscription","commits_url":"https://api.github.com/repos/sgmap/mes-aides-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/sgmap/mes-aides-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/sgmap/mes-aides-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/sgmap/mes-aides-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/sgmap/mes-aides-ui/contents/{+path}","compare_url":"https://api.github.com/repos/sgmap/mes-aides-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sgmap/mes-aides-ui/merges","archive_url":"https://api.github.com/repos/sgmap/mes-aides-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sgmap/mes-aides-ui/downloads","issues_url":"https://api.github.com/repos/sgmap/mes-aides-ui/issues{/number}","pulls_url":"https://api.github.com/repos/sgmap/mes-aides-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/sgmap/mes-aides-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/sgmap/mes-aides-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sgmap/mes-aides-ui/labels{/name}","releases_url":"https://api.github.com/repos/sgmap/mes-aides-ui/releases{/id}","deployments_url":"https://api.github.com/repos/sgmap/mes-aides-ui/deployments","created_at":"2014-04-03T10:42:21Z","updated_at":"2016-06-21T21:18:07Z","pushed_at":"2016-08-16T13:10:01Z","git_url":"git://github.com/sgmap/mes-aides-ui.git","ssh_url":"git@github.com:sgmap/mes-aides-ui.git","clone_url":"https://github.com/sgmap/mes-aides-ui.git","svn_url":"https://github.com/sgmap/mes-aides-ui","homepage":"https://mes-aides.gouv.fr/","size":7907,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":74,"forks":4,"open_issues":74,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sgmap/mes-aides-ui/pulls/351"},"html":{"href":"https://github.com/sgmap/mes-aides-ui/pull/351"},"issue":{"href":"https://api.github.com/repos/sgmap/mes-aides-ui/issues/351"},"comments":{"href":"https://api.github.com/repos/sgmap/mes-aides-ui/issues/351/comments"},"review_comments":{"href":"https://api.github.com/repos/sgmap/mes-aides-ui/pulls/351/comments"},"review_comment":{"href":"https://api.github.com/repos/sgmap/mes-aides-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sgmap/mes-aides-ui/pulls/351/commits"},"statuses":{"href":"https://api.github.com/repos/sgmap/mes-aides-ui/statuses/bd1c13145df830cb73f9b7862428402653fd7cdd"}}}}
{"actor":{"display_login":"Flightan"}}