{"action":"created","issue":{"url":"https://api.github.com/repos/GRIFFINCollaboration/NTuple/issues/15","repository_url":"https://api.github.com/repos/GRIFFINCollaboration/NTuple","labels_url":"https://api.github.com/repos/GRIFFINCollaboration/NTuple/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/GRIFFINCollaboration/NTuple/issues/15/comments","events_url":"https://api.github.com/repos/GRIFFINCollaboration/NTuple/issues/15/events","html_url":"https://github.com/GRIFFINCollaboration/NTuple/issues/15","id":164747804,"number":15,"title":"GriffinND addback","user":{"login":"SmithJK","id":10604745,"avatar_url":"https://avatars.githubusercontent.com/u/10604745?v=3","gravatar_id":"","url":"https://api.github.com/users/SmithJK","html_url":"https://github.com/SmithJK","followers_url":"https://api.github.com/users/SmithJK/followers","following_url":"https://api.github.com/users/SmithJK/following{/other_user}","gists_url":"https://api.github.com/users/SmithJK/gists{/gist_id}","starred_url":"https://api.github.com/users/SmithJK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmithJK/subscriptions","organizations_url":"https://api.github.com/users/SmithJK/orgs","repos_url":"https://api.github.com/users/SmithJK/repos","events_url":"https://api.github.com/users/SmithJK/events{/privacy}","received_events_url":"https://api.github.com/users/SmithJK/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-11T02:10:00Z","updated_at":"2016-07-11T17:34:47Z","closed_at":null,"body":"When creating the GriffinND histograms for angular correlations, it looks to me like the addback algorithm isn't actually adding anything back. It's calculating the crystal 1 and crystal 2 energies, but I don't see where these are added together, either when there's only one detector hit or when there are more than one detectors hit. @AndrewMac1, have you used the addback histograms for angular correlations?"},"comment":{"url":"https://api.github.com/repos/GRIFFINCollaboration/NTuple/issues/comments/231806502","html_url":"https://github.com/GRIFFINCollaboration/NTuple/issues/15#issuecomment-231806502","issue_url":"https://api.github.com/repos/GRIFFINCollaboration/NTuple/issues/15","id":231806502,"user":{"login":"AndrewMac1","id":5428622,"avatar_url":"https://avatars.githubusercontent.com/u/5428622?v=3","gravatar_id":"","url":"https://api.github.com/users/AndrewMac1","html_url":"https://github.com/AndrewMac1","followers_url":"https://api.github.com/users/AndrewMac1/followers","following_url":"https://api.github.com/users/AndrewMac1/following{/other_user}","gists_url":"https://api.github.com/users/AndrewMac1/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewMac1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewMac1/subscriptions","organizations_url":"https://api.github.com/users/AndrewMac1/orgs","repos_url":"https://api.github.com/users/AndrewMac1/repos","events_url":"https://api.github.com/users/AndrewMac1/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewMac1/received_events","type":"User","site_admin":false},"created_at":"2016-07-11T17:34:47Z","updated_at":"2016-07-11T17:34:47Z","body":"I was mixed up the names again and was looking at the wrong thing. Detector method does use the centre of the detectors unlike our analysis, don't worry about that version. Your are right there is a bug in the Github version and I think some lines got commented out accidentally when this was pushed. I haven't looked into it because I am jumping around from one hotel wifi to the next for the next two days but I think the fill lines (987,989 and 990) should not be commented out. Also, I think it should say:\n\nDouble_t fillval2abn[3] = {fGriffinDetector->at(0).Energy(), fGriffinDetector->at(0).Energy(),0.0};\n\nfor line 987. I may also need to be moved up to avoid double counting. I will look into the Github version when I get back and hopefully straighten this out in a few days but maybe try that and let me know.  \n\n----- Original Message -----\nFrom: \"SmithJK\" <notifications@github.com>\nTo: \"GRIFFINCollaboration/NTuple\" <NTuple@noreply.github.com>\nCc: \"AndrewMac1\" <amacle02@uoguelph.ca>, \"Mention\" <mention@noreply.github.com>\nSent: Monday, July 11, 2016 3:51:41 PM\nSubject: Re: [GRIFFINCollaboration/NTuple] GriffinND addback (#15)\n\n`griffin_crystal_unsup_gamma_gamma_corr_edep_det_sparse` uses `GriffinDetMap`. Here's, it is adding together all the interactions that occur in a detector and setting their position to the center of the detector. This means there will be fewer than 52 opening angles (only 16x16 combinations instead of 64x64). This is consistent with what I see in the spectra, but not with the current addback algorithm used in the analysis code, which sets the position of the summed interaction to the center of the crystal with the highest energy (leaving us 64x60 combinations and all 52 opening angles).\n\nBy neighbor addback for `griffin_crystal_unsup_gamma_gamma_corr_edep_cry_addback_sparse`, do you mean an algorithm based on pure detector distance? Or an algorithm consistent with the analysis algorithm? In lines 950-998 of Converter.cc, there are calculations done that look like they are going to add together signals in the same detector when there are no other detectors present. This should produce an entry in the sum peak, but no histogram is ever filled. I *think* this is eliminating the counts in opening angles one and three, but not adding them to opening angle zero, which is what is done in lines 944-949.\n\n---\nYou are receiving this because you were mentioned.\nReply to this email directly or view it on GitHub:\nhttps://github.com/GRIFFINCollaboration/NTuple/issues/15#issuecomment-231758117\n"}}
{"actor":{"display_login":"AndrewMac1"}}