{"action":"created","issue":{"url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/85","repository_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2","labels_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/85/labels{/name}","comments_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/85/comments","events_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/85/events","html_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/85","id":167618339,"number":85,"title":"[SOL-1806] Moved aria-live attributes to popup wrapper","user":{"login":"e-kolpakov","id":3330048,"avatar_url":"https://avatars.githubusercontent.com/u/3330048?v=3","gravatar_id":"","url":"https://api.github.com/users/e-kolpakov","html_url":"https://github.com/e-kolpakov","followers_url":"https://api.github.com/users/e-kolpakov/followers","following_url":"https://api.github.com/users/e-kolpakov/following{/other_user}","gists_url":"https://api.github.com/users/e-kolpakov/gists{/gist_id}","starred_url":"https://api.github.com/users/e-kolpakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-kolpakov/subscriptions","organizations_url":"https://api.github.com/users/e-kolpakov/orgs","repos_url":"https://api.github.com/users/e-kolpakov/repos","events_url":"https://api.github.com/users/e-kolpakov/events{/privacy}","received_events_url":"https://api.github.com/users/e-kolpakov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2016-07-26T14:16:03Z","updated_at":"2016-08-19T01:13:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/pulls/85","html_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/85","diff_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/85.diff","patch_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/85.patch"},"body":"**Description:** This PR modifies ARIA attributes so that only feedback is read to screen-reader user when an item is dropped into a zone, instead of full \"working field\"\r\n\r\n**JIRA:** [SOL-1806](https://openedx.atlassian.net/browse/SOL-1806)\r\n\r\n**Testing instructions:**\r\n0. Enable Screen Reader + make sure your browser support it (e.g. default Ubuntu screen reader does not work with Chrome, but works with Firefox).\r\n0.a. Get used to it speaking out loud everything + learn to notice important parts of it.\r\n1. Create Drag and Drop v2 XBlock in a course. Default configuration should be enough.\r\n2. Open unit with DnDv2 in LMS.\r\n3. Use keyboard or mouse to drop items into correct zones. *Expected behavior:* only feedback is read out loud. *Previous behavior:* almost everything were read out loud (all/some zones and items, feedback)\r\n4. (Unconfirmed - see concerns below) Use keyboard or mouse to drop items into *incorrect* zones. *Expected behavior:* only feedback is read out loud. *Previous behavior:* almost everything were read out loud (all/some zones and items, feedback)\r\n\r\n**Sandboxes:** \r\nLMS: http://dndv2-sandbox3.opencraft.hosting/\r\nStudio: http://studio-dndv2-sandbox3.opencraft.hosting/\r\n\r\nSandboxes use 07ce4db8ba068050d771338b3d10d341a20b2b70 version\r\n\r\n**Reviewers**\r\n\r\n- [x] @mtyaka \r\n- [x] TNL: @cahrens and/or @staubina\r\n- [ ] a11y: @cptvitamin\r\n- [ ] Product: @sstack22\r\n\r\n**Author concerns:**\r\n\r\nDefault Ubuntu screen reader seems to ignore error feedback popups (despite them being absolutely identical to normal popups). This behavior exists in current master, so I'm not sure if it is a real issue; and if so, should it be fixed in scope of this PR."},"comment":{"url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/comments/240902284","html_url":"https://github.com/edx-solutions/xblock-drag-and-drop-v2/pull/85#issuecomment-240902284","issue_url":"https://api.github.com/repos/edx-solutions/xblock-drag-and-drop-v2/issues/85","id":240902284,"user":{"login":"bradenmacdonald","id":945577,"avatar_url":"https://avatars.githubusercontent.com/u/945577?v=3","gravatar_id":"","url":"https://api.github.com/users/bradenmacdonald","html_url":"https://github.com/bradenmacdonald","followers_url":"https://api.github.com/users/bradenmacdonald/followers","following_url":"https://api.github.com/users/bradenmacdonald/following{/other_user}","gists_url":"https://api.github.com/users/bradenmacdonald/gists{/gist_id}","starred_url":"https://api.github.com/users/bradenmacdonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradenmacdonald/subscriptions","organizations_url":"https://api.github.com/users/bradenmacdonald/orgs","repos_url":"https://api.github.com/users/bradenmacdonald/repos","events_url":"https://api.github.com/users/bradenmacdonald/events{/privacy}","received_events_url":"https://api.github.com/users/bradenmacdonald/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T01:13:41Z","updated_at":"2016-08-19T01:13:41Z","body":"Rebased from 71796ad1032f43a0b389aae4ceac0bb65c0acc00 and squashed to 1cb7b9d6673eb552c25718f0daa8cc81d8917a22 . There were some rebase conflicts, so I did a quick post-rebase manual test of both standard + assessment mode using VoiceOver, and everything seems good. Merging now."}}
{"actor":{"display_login":"bradenmacdonald"}}