{"action":"created","comment":{"url":"https://api.github.com/repos/anderspitman/dice-game/pulls/comments/61664320","id":61664320,"diff_hunk":"@@ -1,39 +1,114 @@\n-package dice;\n-\n-import java.util.ArrayList;\n-\n-public class RollResult {\n-    private ArrayList<Integer> rolls;\n-\n-    public RollResult() {\n-        rolls = new ArrayList<Integer>();\n-    }\n-\n-    public void addRoll(int rollValue) {\n-        rolls.add(rollValue);\n-    }\n-\n-    public int sum() {\n-        int sum = 0;\n-\n-        for (int rollIndex = 0; rollIndex < rolls.size(); rollIndex++) {\n-            sum += rolls.get(rollIndex);\n-        }\n-\n-        return sum;\n-    }\n-\n-    public int rollCount() {\n-        return rolls.size();\n-    }\n-\n-    public int[] rollsArray() {\n-        int[] array = new int[rolls.size()];\n-        int index = 0;\n-        for (Integer n : rolls) {\n-            array[index] = n;\n-            index++;\n-        }\n-        return array;\n-    }\n-}\n+package dice;\r\n+\r\n+import java.util.ArrayList;\r\n+\r\n+public class RollResult {\r\n+    private ArrayList<Integer> rolls;\r","path":"shared/src/main/java/dice/RollResult.java","position":45,"original_position":45,"commit_id":"65aabbf1db153f0a5b90a99a85a970652783c1a7","original_commit_id":"65aabbf1db153f0a5b90a99a85a970652783c1a7","user":{"login":"anderspitman","id":7820200,"avatar_url":"https://avatars.githubusercontent.com/u/7820200?v=3","gravatar_id":"","url":"https://api.github.com/users/anderspitman","html_url":"https://github.com/anderspitman","followers_url":"https://api.github.com/users/anderspitman/followers","following_url":"https://api.github.com/users/anderspitman/following{/other_user}","gists_url":"https://api.github.com/users/anderspitman/gists{/gist_id}","starred_url":"https://api.github.com/users/anderspitman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anderspitman/subscriptions","organizations_url":"https://api.github.com/users/anderspitman/orgs","repos_url":"https://api.github.com/users/anderspitman/repos","events_url":"https://api.github.com/users/anderspitman/events{/privacy}","received_events_url":"https://api.github.com/users/anderspitman/received_events","type":"User","site_admin":false},"body":"This can be a `List<Integer>` which polymorphically gets assigned an `ArrayList<Integer>`","created_at":"2016-04-30T03:37:20Z","updated_at":"2016-04-30T03:37:20Z","html_url":"https://github.com/anderspitman/dice-game/pull/114#discussion_r61664320","pull_request_url":"https://api.github.com/repos/anderspitman/dice-game/pulls/114","_links":{"self":{"href":"https://api.github.com/repos/anderspitman/dice-game/pulls/comments/61664320"},"html":{"href":"https://github.com/anderspitman/dice-game/pull/114#discussion_r61664320"},"pull_request":{"href":"https://api.github.com/repos/anderspitman/dice-game/pulls/114"}}},"pull_request":{"url":"https://api.github.com/repos/anderspitman/dice-game/pulls/114","id":68331651,"html_url":"https://github.com/anderspitman/dice-game/pull/114","diff_url":"https://github.com/anderspitman/dice-game/pull/114.diff","patch_url":"https://github.com/anderspitman/dice-game/pull/114.patch","issue_url":"https://api.github.com/repos/anderspitman/dice-game/issues/114","number":114,"state":"open","locked":false,"title":"Additional scoring","user":{"login":"ngdao","id":16847874,"avatar_url":"https://avatars.githubusercontent.com/u/16847874?v=3","gravatar_id":"","url":"https://api.github.com/users/ngdao","html_url":"https://github.com/ngdao","followers_url":"https://api.github.com/users/ngdao/followers","following_url":"https://api.github.com/users/ngdao/following{/other_user}","gists_url":"https://api.github.com/users/ngdao/gists{/gist_id}","starred_url":"https://api.github.com/users/ngdao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngdao/subscriptions","organizations_url":"https://api.github.com/users/ngdao/orgs","repos_url":"https://api.github.com/users/ngdao/repos","events_url":"https://api.github.com/users/ngdao/events{/privacy}","received_events_url":"https://api.github.com/users/ngdao/received_events","type":"User","site_admin":false},"body":"Everything works fine except for 1 bug I can't seem to figure out: whenever I hit 23, getScore() is called twice hence the GUI display wrong score (double the correct score e.i 92 instead of 46). However, the database record the correct score. It's mind-boggling.\r\n\r\n","created_at":"2016-04-29T07:04:33Z","updated_at":"2016-04-30T03:37:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f27dd2893777a5a5783aadb24fb005af67de6bba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/anderspitman/dice-game/pulls/114/commits","review_comments_url":"https://api.github.com/repos/anderspitman/dice-game/pulls/114/comments","review_comment_url":"https://api.github.com/repos/anderspitman/dice-game/pulls/comments{/number}","comments_url":"https://api.github.com/repos/anderspitman/dice-game/issues/114/comments","statuses_url":"https://api.github.com/repos/anderspitman/dice-game/statuses/65aabbf1db153f0a5b90a99a85a970652783c1a7","head":{"label":"ngdao:Additional-Scoring","ref":"Additional-Scoring","sha":"65aabbf1db153f0a5b90a99a85a970652783c1a7","user":{"login":"ngdao","id":16847874,"avatar_url":"https://avatars.githubusercontent.com/u/16847874?v=3","gravatar_id":"","url":"https://api.github.com/users/ngdao","html_url":"https://github.com/ngdao","followers_url":"https://api.github.com/users/ngdao/followers","following_url":"https://api.github.com/users/ngdao/following{/other_user}","gists_url":"https://api.github.com/users/ngdao/gists{/gist_id}","starred_url":"https://api.github.com/users/ngdao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngdao/subscriptions","organizations_url":"https://api.github.com/users/ngdao/orgs","repos_url":"https://api.github.com/users/ngdao/repos","events_url":"https://api.github.com/users/ngdao/events{/privacy}","received_events_url":"https://api.github.com/users/ngdao/received_events","type":"User","site_admin":false},"repo":{"id":56007904,"name":"dice-game","full_name":"ngdao/dice-game","owner":{"login":"ngdao","id":16847874,"avatar_url":"https://avatars.githubusercontent.com/u/16847874?v=3","gravatar_id":"","url":"https://api.github.com/users/ngdao","html_url":"https://github.com/ngdao","followers_url":"https://api.github.com/users/ngdao/followers","following_url":"https://api.github.com/users/ngdao/following{/other_user}","gists_url":"https://api.github.com/users/ngdao/gists{/gist_id}","starred_url":"https://api.github.com/users/ngdao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngdao/subscriptions","organizations_url":"https://api.github.com/users/ngdao/orgs","repos_url":"https://api.github.com/users/ngdao/repos","events_url":"https://api.github.com/users/ngdao/events{/privacy}","received_events_url":"https://api.github.com/users/ngdao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ngdao/dice-game","description":"CSE360 Team Project","fork":true,"url":"https://api.github.com/repos/ngdao/dice-game","forks_url":"https://api.github.com/repos/ngdao/dice-game/forks","keys_url":"https://api.github.com/repos/ngdao/dice-game/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngdao/dice-game/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngdao/dice-game/teams","hooks_url":"https://api.github.com/repos/ngdao/dice-game/hooks","issue_events_url":"https://api.github.com/repos/ngdao/dice-game/issues/events{/number}","events_url":"https://api.github.com/repos/ngdao/dice-game/events","assignees_url":"https://api.github.com/repos/ngdao/dice-game/assignees{/user}","branches_url":"https://api.github.com/repos/ngdao/dice-game/branches{/branch}","tags_url":"https://api.github.com/repos/ngdao/dice-game/tags","blobs_url":"https://api.github.com/repos/ngdao/dice-game/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngdao/dice-game/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngdao/dice-game/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngdao/dice-game/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngdao/dice-game/statuses/{sha}","languages_url":"https://api.github.com/repos/ngdao/dice-game/languages","stargazers_url":"https://api.github.com/repos/ngdao/dice-game/stargazers","contributors_url":"https://api.github.com/repos/ngdao/dice-game/contributors","subscribers_url":"https://api.github.com/repos/ngdao/dice-game/subscribers","subscription_url":"https://api.github.com/repos/ngdao/dice-game/subscription","commits_url":"https://api.github.com/repos/ngdao/dice-game/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngdao/dice-game/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngdao/dice-game/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngdao/dice-game/issues/comments{/number}","contents_url":"https://api.github.com/repos/ngdao/dice-game/contents/{+path}","compare_url":"https://api.github.com/repos/ngdao/dice-game/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngdao/dice-game/merges","archive_url":"https://api.github.com/repos/ngdao/dice-game/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngdao/dice-game/downloads","issues_url":"https://api.github.com/repos/ngdao/dice-game/issues{/number}","pulls_url":"https://api.github.com/repos/ngdao/dice-game/pulls{/number}","milestones_url":"https://api.github.com/repos/ngdao/dice-game/milestones{/number}","notifications_url":"https://api.github.com/repos/ngdao/dice-game/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngdao/dice-game/labels{/name}","releases_url":"https://api.github.com/repos/ngdao/dice-game/releases{/id}","deployments_url":"https://api.github.com/repos/ngdao/dice-game/deployments","created_at":"2016-04-11T21:09:33Z","updated_at":"2016-04-11T21:09:33Z","pushed_at":"2016-04-30T02:49:11Z","git_url":"git://github.com/ngdao/dice-game.git","ssh_url":"git@github.com:ngdao/dice-game.git","clone_url":"https://github.com/ngdao/dice-game.git","svn_url":"https://github.com/ngdao/dice-game","homepage":null,"size":531,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"anderspitman:master","ref":"master","sha":"26c6c7de16425aa9d92ec977f9120587ace348de","user":{"login":"anderspitman","id":7820200,"avatar_url":"https://avatars.githubusercontent.com/u/7820200?v=3","gravatar_id":"","url":"https://api.github.com/users/anderspitman","html_url":"https://github.com/anderspitman","followers_url":"https://api.github.com/users/anderspitman/followers","following_url":"https://api.github.com/users/anderspitman/following{/other_user}","gists_url":"https://api.github.com/users/anderspitman/gists{/gist_id}","starred_url":"https://api.github.com/users/anderspitman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anderspitman/subscriptions","organizations_url":"https://api.github.com/users/anderspitman/orgs","repos_url":"https://api.github.com/users/anderspitman/repos","events_url":"https://api.github.com/users/anderspitman/events{/privacy}","received_events_url":"https://api.github.com/users/anderspitman/received_events","type":"User","site_admin":false},"repo":{"id":54851071,"name":"dice-game","full_name":"anderspitman/dice-game","owner":{"login":"anderspitman","id":7820200,"avatar_url":"https://avatars.githubusercontent.com/u/7820200?v=3","gravatar_id":"","url":"https://api.github.com/users/anderspitman","html_url":"https://github.com/anderspitman","followers_url":"https://api.github.com/users/anderspitman/followers","following_url":"https://api.github.com/users/anderspitman/following{/other_user}","gists_url":"https://api.github.com/users/anderspitman/gists{/gist_id}","starred_url":"https://api.github.com/users/anderspitman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anderspitman/subscriptions","organizations_url":"https://api.github.com/users/anderspitman/orgs","repos_url":"https://api.github.com/users/anderspitman/repos","events_url":"https://api.github.com/users/anderspitman/events{/privacy}","received_events_url":"https://api.github.com/users/anderspitman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anderspitman/dice-game","description":"CSE360 Team Project","fork":false,"url":"https://api.github.com/repos/anderspitman/dice-game","forks_url":"https://api.github.com/repos/anderspitman/dice-game/forks","keys_url":"https://api.github.com/repos/anderspitman/dice-game/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anderspitman/dice-game/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anderspitman/dice-game/teams","hooks_url":"https://api.github.com/repos/anderspitman/dice-game/hooks","issue_events_url":"https://api.github.com/repos/anderspitman/dice-game/issues/events{/number}","events_url":"https://api.github.com/repos/anderspitman/dice-game/events","assignees_url":"https://api.github.com/repos/anderspitman/dice-game/assignees{/user}","branches_url":"https://api.github.com/repos/anderspitman/dice-game/branches{/branch}","tags_url":"https://api.github.com/repos/anderspitman/dice-game/tags","blobs_url":"https://api.github.com/repos/anderspitman/dice-game/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anderspitman/dice-game/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anderspitman/dice-game/git/refs{/sha}","trees_url":"https://api.github.com/repos/anderspitman/dice-game/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anderspitman/dice-game/statuses/{sha}","languages_url":"https://api.github.com/repos/anderspitman/dice-game/languages","stargazers_url":"https://api.github.com/repos/anderspitman/dice-game/stargazers","contributors_url":"https://api.github.com/repos/anderspitman/dice-game/contributors","subscribers_url":"https://api.github.com/repos/anderspitman/dice-game/subscribers","subscription_url":"https://api.github.com/repos/anderspitman/dice-game/subscription","commits_url":"https://api.github.com/repos/anderspitman/dice-game/commits{/sha}","git_commits_url":"https://api.github.com/repos/anderspitman/dice-game/git/commits{/sha}","comments_url":"https://api.github.com/repos/anderspitman/dice-game/comments{/number}","issue_comment_url":"https://api.github.com/repos/anderspitman/dice-game/issues/comments{/number}","contents_url":"https://api.github.com/repos/anderspitman/dice-game/contents/{+path}","compare_url":"https://api.github.com/repos/anderspitman/dice-game/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anderspitman/dice-game/merges","archive_url":"https://api.github.com/repos/anderspitman/dice-game/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anderspitman/dice-game/downloads","issues_url":"https://api.github.com/repos/anderspitman/dice-game/issues{/number}","pulls_url":"https://api.github.com/repos/anderspitman/dice-game/pulls{/number}","milestones_url":"https://api.github.com/repos/anderspitman/dice-game/milestones{/number}","notifications_url":"https://api.github.com/repos/anderspitman/dice-game/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anderspitman/dice-game/labels{/name}","releases_url":"https://api.github.com/repos/anderspitman/dice-game/releases{/id}","deployments_url":"https://api.github.com/repos/anderspitman/dice-game/deployments","created_at":"2016-03-27T22:31:54Z","updated_at":"2016-03-31T23:28:25Z","pushed_at":"2016-04-30T03:07:28Z","git_url":"git://github.com/anderspitman/dice-game.git","ssh_url":"git@github.com:anderspitman/dice-game.git","clone_url":"https://github.com/anderspitman/dice-game.git","svn_url":"https://github.com/anderspitman/dice-game","homepage":null,"size":594,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":34,"forks":5,"open_issues":34,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/anderspitman/dice-game/pulls/114"},"html":{"href":"https://github.com/anderspitman/dice-game/pull/114"},"issue":{"href":"https://api.github.com/repos/anderspitman/dice-game/issues/114"},"comments":{"href":"https://api.github.com/repos/anderspitman/dice-game/issues/114/comments"},"review_comments":{"href":"https://api.github.com/repos/anderspitman/dice-game/pulls/114/comments"},"review_comment":{"href":"https://api.github.com/repos/anderspitman/dice-game/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/anderspitman/dice-game/pulls/114/commits"},"statuses":{"href":"https://api.github.com/repos/anderspitman/dice-game/statuses/65aabbf1db153f0a5b90a99a85a970652783c1a7"}}}}