{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments/51078691","id":51078691,"diff_hunk":"@@ -271,8 +285,9 @@ - (void)displayDidFinish\n {\n   [super displayDidFinish];\n \n+  ASDN::MutexLocker l(_imageLock);\n   // If we've got a block to perform after displaying, do it.\n-  if (self.image && _displayCompletionBlock) {\n+  if (_image && _displayCompletionBlock) {\n \n     // FIXME: _displayCompletionBlock is not protected by lock\n     _displayCompletionBlock(NO);","path":"AsyncDisplayKit/ASImageNode.mm","position":244,"original_position":244,"commit_id":"01c16809044e34ea663fbd52373e44720fe2eca3","original_commit_id":"01c16809044e34ea663fbd52373e44720fe2eca3","user":{"login":"appleguy","id":565251,"avatar_url":"https://avatars.githubusercontent.com/u/565251?v=3","gravatar_id":"","url":"https://api.github.com/users/appleguy","html_url":"https://github.com/appleguy","followers_url":"https://api.github.com/users/appleguy/followers","following_url":"https://api.github.com/users/appleguy/following{/other_user}","gists_url":"https://api.github.com/users/appleguy/gists{/gist_id}","starred_url":"https://api.github.com/users/appleguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleguy/subscriptions","organizations_url":"https://api.github.com/users/appleguy/orgs","repos_url":"https://api.github.com/users/appleguy/repos","events_url":"https://api.github.com/users/appleguy/events{/privacy}","received_events_url":"https://api.github.com/users/appleguy/received_events","type":"User","site_admin":false},"body":"It is likely essential that we release the lock before calling this block. We may want to access the block pointer and store it in a local variable before calling it, which could be a plausible threading issue if the display completion block is changed in the case that a display is canceled or restarted while one is in progress.","created_at":"2016-01-28T04:27:30Z","updated_at":"2016-01-28T04:27:30Z","html_url":"https://github.com/facebook/AsyncDisplayKit/pull/1132#discussion_r51078691","pull_request_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1132","_links":{"self":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments/51078691"},"html":{"href":"https://github.com/facebook/AsyncDisplayKit/pull/1132#discussion_r51078691"},"pull_request":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1132"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1132","id":57452938,"html_url":"https://github.com/facebook/AsyncDisplayKit/pull/1132","diff_url":"https://github.com/facebook/AsyncDisplayKit/pull/1132.diff","patch_url":"https://github.com/facebook/AsyncDisplayKit/pull/1132.patch","issue_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1132","number":1132,"state":"open","locked":false,"title":"Switch to instance methods of draw and display","user":{"login":"garrettmoon","id":90045,"avatar_url":"https://avatars.githubusercontent.com/u/90045?v=3","gravatar_id":"","url":"https://api.github.com/users/garrettmoon","html_url":"https://github.com/garrettmoon","followers_url":"https://api.github.com/users/garrettmoon/followers","following_url":"https://api.github.com/users/garrettmoon/following{/other_user}","gists_url":"https://api.github.com/users/garrettmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettmoon/subscriptions","organizations_url":"https://api.github.com/users/garrettmoon/orgs","repos_url":"https://api.github.com/users/garrettmoon/repos","events_url":"https://api.github.com/users/garrettmoon/events{/privacy}","received_events_url":"https://api.github.com/users/garrettmoon/received_events","type":"User","site_admin":false},"body":"This patch switches to instance methods of draw and display for\r\nASTextNode and ASImageNode to attempt to increase their performance.\r\n\r\nIt also fixes some thread safety issues in ASImageNode which appear\r\nto have been regressions (though probably not hit very often).\r\n\r\nAnd it sets up work for allowing modification of CGContexts before\r\nand after a node's contents are drawn.","created_at":"2016-01-28T04:10:00Z","updated_at":"2016-01-28T04:27:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da3f82c4d4cb8be594bb9d84208685d8b97b6b91","assignee":null,"milestone":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/milestones/16","html_url":"https://github.com/facebook/AsyncDisplayKit/milestones/1.9.7","labels_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/milestones/16/labels","id":1538836,"number":16,"title":"1.9.7","description":null,"creator":{"login":"appleguy","id":565251,"avatar_url":"https://avatars.githubusercontent.com/u/565251?v=3","gravatar_id":"","url":"https://api.github.com/users/appleguy","html_url":"https://github.com/appleguy","followers_url":"https://api.github.com/users/appleguy/followers","following_url":"https://api.github.com/users/appleguy/following{/other_user}","gists_url":"https://api.github.com/users/appleguy/gists{/gist_id}","starred_url":"https://api.github.com/users/appleguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleguy/subscriptions","organizations_url":"https://api.github.com/users/appleguy/orgs","repos_url":"https://api.github.com/users/appleguy/repos","events_url":"https://api.github.com/users/appleguy/events{/privacy}","received_events_url":"https://api.github.com/users/appleguy/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":17,"state":"open","created_at":"2016-01-23T21:06:45Z","updated_at":"2016-01-28T04:12:29Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1132/commits","review_comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1132/comments","review_comment_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1132/comments","statuses_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/01c16809044e34ea663fbd52373e44720fe2eca3","head":{"label":"garrettmoon:switchToInstanceDrawAndDisplay","ref":"switchToInstanceDrawAndDisplay","sha":"01c16809044e34ea663fbd52373e44720fe2eca3","user":{"login":"garrettmoon","id":90045,"avatar_url":"https://avatars.githubusercontent.com/u/90045?v=3","gravatar_id":"","url":"https://api.github.com/users/garrettmoon","html_url":"https://github.com/garrettmoon","followers_url":"https://api.github.com/users/garrettmoon/followers","following_url":"https://api.github.com/users/garrettmoon/following{/other_user}","gists_url":"https://api.github.com/users/garrettmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettmoon/subscriptions","organizations_url":"https://api.github.com/users/garrettmoon/orgs","repos_url":"https://api.github.com/users/garrettmoon/repos","events_url":"https://api.github.com/users/garrettmoon/events{/privacy}","received_events_url":"https://api.github.com/users/garrettmoon/received_events","type":"User","site_admin":false},"repo":{"id":37542421,"name":"AsyncDisplayKit","full_name":"garrettmoon/AsyncDisplayKit","owner":{"login":"garrettmoon","id":90045,"avatar_url":"https://avatars.githubusercontent.com/u/90045?v=3","gravatar_id":"","url":"https://api.github.com/users/garrettmoon","html_url":"https://github.com/garrettmoon","followers_url":"https://api.github.com/users/garrettmoon/followers","following_url":"https://api.github.com/users/garrettmoon/following{/other_user}","gists_url":"https://api.github.com/users/garrettmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettmoon/subscriptions","organizations_url":"https://api.github.com/users/garrettmoon/orgs","repos_url":"https://api.github.com/users/garrettmoon/repos","events_url":"https://api.github.com/users/garrettmoon/events{/privacy}","received_events_url":"https://api.github.com/users/garrettmoon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garrettmoon/AsyncDisplayKit","description":"Smooth asynchronous user interfaces for iOS apps.","fork":true,"url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit","forks_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/forks","keys_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/teams","hooks_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/hooks","issue_events_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/issues/events{/number}","events_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/events","assignees_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/assignees{/user}","branches_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/branches{/branch}","tags_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/tags","blobs_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/statuses/{sha}","languages_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/languages","stargazers_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/stargazers","contributors_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/contributors","subscribers_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/subscribers","subscription_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/subscription","commits_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/contents/{+path}","compare_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/merges","archive_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/downloads","issues_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/issues{/number}","pulls_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/pulls{/number}","milestones_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/milestones{/number}","notifications_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/labels{/name}","releases_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/releases{/id}","deployments_url":"https://api.github.com/repos/garrettmoon/AsyncDisplayKit/deployments","created_at":"2015-06-16T16:33:05Z","updated_at":"2015-06-16T16:33:07Z","pushed_at":"2016-01-28T04:08:33Z","git_url":"git://github.com/garrettmoon/AsyncDisplayKit.git","ssh_url":"git@github.com:garrettmoon/AsyncDisplayKit.git","clone_url":"https://github.com/garrettmoon/AsyncDisplayKit.git","svn_url":"https://github.com/garrettmoon/AsyncDisplayKit","homepage":"http://asyncdisplaykit.org","size":15380,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"29374deedee673e05f9b6079e1cb7088c3bd72e1","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":21265042,"name":"AsyncDisplayKit","full_name":"facebook/AsyncDisplayKit","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/AsyncDisplayKit","description":"Smooth asynchronous user interfaces for iOS apps.","fork":false,"url":"https://api.github.com/repos/facebook/AsyncDisplayKit","forks_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/forks","keys_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/teams","hooks_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/hooks","issue_events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/events","assignees_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/tags","blobs_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/languages","stargazers_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/stargazers","contributors_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/contributors","subscribers_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/subscribers","subscription_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/subscription","commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/merges","archive_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/downloads","issues_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/labels{/name}","releases_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/deployments","created_at":"2014-06-27T05:29:02Z","updated_at":"2016-01-28T03:45:10Z","pushed_at":"2016-01-28T04:10:01Z","git_url":"git://github.com/facebook/AsyncDisplayKit.git","ssh_url":"git@github.com:facebook/AsyncDisplayKit.git","clone_url":"https://github.com/facebook/AsyncDisplayKit.git","svn_url":"https://github.com/facebook/AsyncDisplayKit","homepage":"http://asyncdisplaykit.org","size":16893,"stargazers_count":7173,"watchers_count":7173,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1092,"mirror_url":null,"open_issues_count":160,"forks":1092,"open_issues":160,"watchers":7173,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1132"},"html":{"href":"https://github.com/facebook/AsyncDisplayKit/pull/1132"},"issue":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1132"},"comments":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1132/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1132/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1132/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/01c16809044e34ea663fbd52373e44720fe2eca3"}}}}