{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/81579072","pull_request_review_id":2548856,"id":81579072,"diff_hunk":"@@ -2,4 +2,11 @@ Compat issues with assembly System.Runtime:\n MembersMustExist : Member 'System.Type.IsSecurityCritical.get()' does not exist in the implementation but it does exist in the contract.\n MembersMustExist : Member 'System.Type.IsSecuritySafeCritical.get()' does not exist in the implementation but it does exist in the contract.\n MembersMustExist : Member 'System.Type.IsSecurityTransparent.get()' does not exist in the implementation but it does exist in the contract.\n-Total Issues: 3\n+MembersMustExist : Member 'System.Type.GetType(System.String, System.Func<System.Reflection.AssemblyName, System.Reflection.Assembly>, System.Func<System.Reflection.Assembly, System.String, System.Boolean, System.Type>)' does not exist in the implementation but it does exist in the contract.\n+MembersMustExist : Member 'System.Type.GetType(System.String, System.Func<System.Reflection.AssemblyName, System.Reflection.Assembly>, System.Func<System.Reflection.Assembly, System.String, System.Boolean, System.Type>, System.Boolean)' does not exist in the implementation but it does exist in the contract.","path":"src/System.Runtime/src/ApiCompatBaseline.txt","position":6,"original_position":6,"commit_id":"ff226c115e1a440314a1ca61a1f2a87cf9dbc86b","original_commit_id":"0c6f6f7c01a2940de02c2ef45476c02549e7138d","user":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":"Good that we caught this can we make sure there is an issue filed to get them exposed. ","created_at":"2016-10-03T15:50:26Z","updated_at":"2016-10-03T15:50:26Z","html_url":"https://github.com/dotnet/corefx/pull/12187#discussion_r81579072","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/12187","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/81579072"},"html":{"href":"https://github.com/dotnet/corefx/pull/12187#discussion_r81579072"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/12187"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/12187","id":87261816,"html_url":"https://github.com/dotnet/corefx/pull/12187","diff_url":"https://github.com/dotnet/corefx/pull/12187.diff","patch_url":"https://github.com/dotnet/corefx/pull/12187.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/12187","number":12187,"state":"open","locked":false,"title":"Reference S.P.CoreLib from the facades","user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"Build facades for CoreCLR directly against S.P.CoreLib - similar to how they are built for CoreRT.","created_at":"2016-09-29T07:47:58Z","updated_at":"2016-10-03T15:50:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"264d4698973dc05f69443c51db7ac59de2fe34f7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/12187/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/12187/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/12187/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/ff226c115e1a440314a1ca61a1f2a87cf9dbc86b","head":{"label":"jkotas:CoreLib","ref":"CoreLib","sha":"ff226c115e1a440314a1ca61a1f2a87cf9dbc86b","user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"repo":{"id":30204735,"name":"corefx","full_name":"jkotas/corefx","owner":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jkotas/corefx","description":"This repo contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/jkotas/corefx","forks_url":"https://api.github.com/repos/jkotas/corefx/forks","keys_url":"https://api.github.com/repos/jkotas/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jkotas/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jkotas/corefx/teams","hooks_url":"https://api.github.com/repos/jkotas/corefx/hooks","issue_events_url":"https://api.github.com/repos/jkotas/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/jkotas/corefx/events","assignees_url":"https://api.github.com/repos/jkotas/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/jkotas/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/jkotas/corefx/tags","blobs_url":"https://api.github.com/repos/jkotas/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jkotas/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jkotas/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/jkotas/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jkotas/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/jkotas/corefx/languages","stargazers_url":"https://api.github.com/repos/jkotas/corefx/stargazers","contributors_url":"https://api.github.com/repos/jkotas/corefx/contributors","subscribers_url":"https://api.github.com/repos/jkotas/corefx/subscribers","subscription_url":"https://api.github.com/repos/jkotas/corefx/subscription","commits_url":"https://api.github.com/repos/jkotas/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/jkotas/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/jkotas/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/jkotas/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/jkotas/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/jkotas/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jkotas/corefx/merges","archive_url":"https://api.github.com/repos/jkotas/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jkotas/corefx/downloads","issues_url":"https://api.github.com/repos/jkotas/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/jkotas/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/jkotas/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/jkotas/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jkotas/corefx/labels{/name}","releases_url":"https://api.github.com/repos/jkotas/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/jkotas/corefx/deployments","created_at":"2015-02-02T19:41:31Z","updated_at":"2016-01-11T23:51:50Z","pushed_at":"2016-10-03T15:36:36Z","git_url":"git://github.com/jkotas/corefx.git","ssh_url":"git@github.com:jkotas/corefx.git","clone_url":"https://github.com/jkotas/corefx.git","svn_url":"https://github.com/jkotas/corefx","homepage":"","size":100099,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"76b46ea5517abe4baffee0296ab8a6b6bc1877d6","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-10-03T12:42:32Z","pushed_at":"2016-10-03T15:49:23Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":146213,"stargazers_count":10597,"watchers_count":10597,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2648,"mirror_url":null,"open_issues_count":1537,"forks":2648,"open_issues":1537,"watchers":10597,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/12187"},"html":{"href":"https://github.com/dotnet/corefx/pull/12187"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/12187"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/12187/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/12187/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/12187/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/ff226c115e1a440314a1ca61a1f2a87cf9dbc86b"}}}}
{"actor":{"display_login":"weshaggard"}}