{"action":"created","issue":{"url":"https://api.github.com/repos/getcarina/feedback/issues/60","repository_url":"https://api.github.com/repos/getcarina/feedback","labels_url":"https://api.github.com/repos/getcarina/feedback/issues/60/labels{/name}","comments_url":"https://api.github.com/repos/getcarina/feedback/issues/60/comments","events_url":"https://api.github.com/repos/getcarina/feedback/issues/60/events","html_url":"https://github.com/getcarina/feedback/issues/60","id":147500910,"number":60,"title":"docker.env doesn't compatible with fish","user":{"login":"7sDream","id":7822577,"avatar_url":"https://avatars.githubusercontent.com/u/7822577?v=3","gravatar_id":"","url":"https://api.github.com/users/7sDream","html_url":"https://github.com/7sDream","followers_url":"https://api.github.com/users/7sDream/followers","following_url":"https://api.github.com/users/7sDream/following{/other_user}","gists_url":"https://api.github.com/users/7sDream/gists{/gist_id}","starred_url":"https://api.github.com/users/7sDream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/7sDream/subscriptions","organizations_url":"https://api.github.com/users/7sDream/orgs","repos_url":"https://api.github.com/users/7sDream/repos","events_url":"https://api.github.com/users/7sDream/events{/privacy}","received_events_url":"https://api.github.com/users/7sDream/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-11T17:40:11Z","updated_at":"2016-04-11T17:48:48Z","closed_at":null,"body":"I use fish as my default sh, the current docker.env doesn't compatible with it, see below:\r\n\r\n![source docker.env error](http://ww1.sinaimg.cn/large/88e401f0jw1f2ta90407sj20hr04qta7.jpg)\r\n\r\nBut I don't want switch to bash to run dvm and docker command... could you please add support for fish?\r\n\r\n---\r\n\r\nAs I'm can't wait to use it, I write a [docker.fish](https://gist.github.com/7sDream/4671ac4b6daebd4e7c377b1c83d7a092) for temporary use, it has same function as offical docker.env. Just some convert work, and I don't test all possible station, but it work fine with me(for now)\r\n\r\nBut I still want the OFFICAL fish support! Thanks for your work!"},"comment":{"url":"https://api.github.com/repos/getcarina/feedback/issues/comments/208470475","html_url":"https://github.com/getcarina/feedback/issues/60#issuecomment-208470475","issue_url":"https://api.github.com/repos/getcarina/feedback/issues/60","id":208470475,"user":{"login":"rgbkrk","id":836375,"avatar_url":"https://avatars.githubusercontent.com/u/836375?v=3","gravatar_id":"","url":"https://api.github.com/users/rgbkrk","html_url":"https://github.com/rgbkrk","followers_url":"https://api.github.com/users/rgbkrk/followers","following_url":"https://api.github.com/users/rgbkrk/following{/other_user}","gists_url":"https://api.github.com/users/rgbkrk/gists{/gist_id}","starred_url":"https://api.github.com/users/rgbkrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgbkrk/subscriptions","organizations_url":"https://api.github.com/users/rgbkrk/orgs","repos_url":"https://api.github.com/users/rgbkrk/repos","events_url":"https://api.github.com/users/rgbkrk/events{/privacy}","received_events_url":"https://api.github.com/users/rgbkrk/received_events","type":"User","site_admin":false},"created_at":"2016-04-11T17:48:48Z","updated_at":"2016-04-11T17:48:48Z","body":"Hey @7sDream!\r\n\r\nWe'll have to do this in a couple phases:\r\n\r\n* [ ] On the backend, create a docker.fish file that is returned in the zip file\r\n* [ ] Within libcarina (go bindings) extract the fish shell script\r\n* [ ] `dvm` needs to support multiple shells, likely relying on `$SHELL`\r\n* [ ] `carina` would also need to rely on `$SHELL` to provide the right output to `carina env clusterName`\r\n\r\n/cc @carolynvs I'll get started on the backend bits now."}}