{"action":"created","issue":{"url":"https://api.github.com/repos/dcposch/browser-laptop/issues/3","repository_url":"https://api.github.com/repos/dcposch/browser-laptop","labels_url":"https://api.github.com/repos/dcposch/browser-laptop/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/dcposch/browser-laptop/issues/3/comments","events_url":"https://api.github.com/repos/dcposch/browser-laptop/issues/3/events","html_url":"https://github.com/dcposch/browser-laptop/pull/3","id":187876143,"number":3,"title":"[WIP] Move the Torrent Viewer to its own extension","user":{"login":"dcposch","id":169280,"avatar_url":"https://avatars.githubusercontent.com/u/169280?v=3","gravatar_id":"","url":"https://api.github.com/users/dcposch","html_url":"https://github.com/dcposch","followers_url":"https://api.github.com/users/dcposch/followers","following_url":"https://api.github.com/users/dcposch/following{/other_user}","gists_url":"https://api.github.com/users/dcposch/gists{/gist_id}","starred_url":"https://api.github.com/users/dcposch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcposch/subscriptions","organizations_url":"https://api.github.com/users/dcposch/orgs","repos_url":"https://api.github.com/users/dcposch/repos","events_url":"https://api.github.com/users/dcposch/events{/privacy}","received_events_url":"https://api.github.com/users/dcposch/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-11-08T01:17:44Z","updated_at":"2016-11-09T02:03:03Z","closed_at":"2016-11-09T02:02:14Z","pull_request":{"url":"https://api.github.com/repos/dcposch/browser-laptop/pulls/3","html_url":"https://github.com/dcposch/browser-laptop/pull/3","diff_url":"https://github.com/dcposch/browser-laptop/pull/3.diff","patch_url":"https://github.com/dcposch/browser-laptop/pull/3.patch"},"body":"Previously, torrent support was implemented in the Brave extension.\r\n\r\n### Questions\r\n- **Dev mode**. The Brave extension does some fancy things in developer mode, including different CSP directives, a separate `index.html`, etc. It feels dirty to copy and paste all that into the torrent extension. Is there a better way? (PS: so far, I've just been running `npm run webpack` every time I make a change in the extensions/ folder.)\r\n- **Permissions**. The WebTorrent extension generally has fewer permissions than the Brave extension. I'll experiment with restricting them some more.\r\n- **Key**. Currently, the Brave extension manifest specifies a key and the torrent extension doesn't. See `generate{Brave,Torrent}Manifest()` in `app/extensions.js`. Since these extensions are bundled with the browser rather than served thru eg. the Chrome app store, what does the key do?\r\n\r\n### Work left to do\r\n- **WebTorrent process**. This just gives webtorrent its own extension. The next step is additionally moving the webtorrent client to its own process, for two reasons: we want a single client instead of one per tab, and we want it to have access to Node APIs.\r\n\r\nLMK if this looks reasonable!\r\n\r\n@diracdeltas @bbondy @brendaneich @feross "},"comment":{"url":"https://api.github.com/repos/dcposch/browser-laptop/issues/comments/259316718","html_url":"https://github.com/dcposch/browser-laptop/pull/3#issuecomment-259316718","issue_url":"https://api.github.com/repos/dcposch/browser-laptop/issues/3","id":259316718,"user":{"login":"dcposch","id":169280,"avatar_url":"https://avatars.githubusercontent.com/u/169280?v=3","gravatar_id":"","url":"https://api.github.com/users/dcposch","html_url":"https://github.com/dcposch","followers_url":"https://api.github.com/users/dcposch/followers","following_url":"https://api.github.com/users/dcposch/following{/other_user}","gists_url":"https://api.github.com/users/dcposch/gists{/gist_id}","starred_url":"https://api.github.com/users/dcposch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcposch/subscriptions","organizations_url":"https://api.github.com/users/dcposch/orgs","repos_url":"https://api.github.com/users/dcposch/repos","events_url":"https://api.github.com/users/dcposch/events{/privacy}","received_events_url":"https://api.github.com/users/dcposch/received_events","type":"User","site_admin":false},"created_at":"2016-11-09T02:03:03Z","updated_at":"2016-11-09T02:03:03Z","body":"@diracdeltas @feross thanks"}}
{"actor":{"display_login":"dcposch"}}