{"action":"created","issue":{"url":"https://api.github.com/repos/mesonbuild/meson/issues/390","repository_url":"https://api.github.com/repos/mesonbuild/meson","labels_url":"https://api.github.com/repos/mesonbuild/meson/issues/390/labels{/name}","comments_url":"https://api.github.com/repos/mesonbuild/meson/issues/390/comments","events_url":"https://api.github.com/repos/mesonbuild/meson/issues/390/events","html_url":"https://github.com/mesonbuild/meson/pull/390","id":134227436,"number":390,"title":"Add support for passing a module definitions file for exporting symbols while linking","user":{"login":"nirbheek","id":75801,"avatar_url":"https://avatars.githubusercontent.com/u/75801?v=3","gravatar_id":"","url":"https://api.github.com/users/nirbheek","html_url":"https://github.com/nirbheek","followers_url":"https://api.github.com/users/nirbheek/followers","following_url":"https://api.github.com/users/nirbheek/following{/other_user}","gists_url":"https://api.github.com/users/nirbheek/gists{/gist_id}","starred_url":"https://api.github.com/users/nirbheek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirbheek/subscriptions","organizations_url":"https://api.github.com/users/nirbheek/orgs","repos_url":"https://api.github.com/users/nirbheek/repos","events_url":"https://api.github.com/users/nirbheek/events{/privacy}","received_events_url":"https://api.github.com/users/nirbheek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2016-02-17T09:32:36Z","updated_at":"2016-03-30T10:55:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mesonbuild/meson/pulls/390","html_url":"https://github.com/mesonbuild/meson/pull/390","diff_url":"https://github.com/mesonbuild/meson/pull/390.diff","patch_url":"https://github.com/mesonbuild/meson/pull/390.patch"},"body":"On MSVC, shared libraries only export symbols that have been explicitly exported\r\neither as part of the symbol prototype or via a module definitions file. On\r\ncompilers other than MSVC, all symbols are exported in the shared library by\r\ndefault so this would be a no-op there.\r\n\r\nThe module defs file path can either be relative to the current source directory\r\nor an absolute path using meson.source_root() + '/some/path'"},"comment":{"url":"https://api.github.com/repos/mesonbuild/meson/issues/comments/203377772","html_url":"https://github.com/mesonbuild/meson/pull/390#issuecomment-203377772","issue_url":"https://api.github.com/repos/mesonbuild/meson/issues/390","id":203377772,"user":{"login":"nirbheek","id":75801,"avatar_url":"https://avatars.githubusercontent.com/u/75801?v=3","gravatar_id":"","url":"https://api.github.com/users/nirbheek","html_url":"https://github.com/nirbheek","followers_url":"https://api.github.com/users/nirbheek/followers","following_url":"https://api.github.com/users/nirbheek/following{/other_user}","gists_url":"https://api.github.com/users/nirbheek/gists{/gist_id}","starred_url":"https://api.github.com/users/nirbheek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirbheek/subscriptions","organizations_url":"https://api.github.com/users/nirbheek/orgs","repos_url":"https://api.github.com/users/nirbheek/repos","events_url":"https://api.github.com/users/nirbheek/events{/privacy}","received_events_url":"https://api.github.com/users/nirbheek/received_events","type":"User","site_admin":false},"created_at":"2016-03-30T10:55:48Z","updated_at":"2016-03-30T10:55:48Z","body":"I've added a test to the branch as well. It should all be in order now. :)"}}