{"action":"created","comment":{"url":"https://api.github.com/repos/baidu/tera/pulls/comments/76000640","id":76000640,"diff_hunk":"@@ -1,92 +1,98 @@\n // Copyright (c) 2015, Baidu.com, Inc. All Rights Reserved\n // Use of this source code is governed by a BSD-style license that can be\n // found in the LICENSE file.\n+//\n+// A RowReader describes a Get operation for the specified row and returns\n+// filtered cells from server.\n+// User should call RowReader::GetError() to check if operation is successful.\n \n #ifndef  TERA_READER_H_\n #define  TERA_READER_H_\n \n-#include <stdint.h>\n-#include <list>\n #include <map>\n #include <set>\n #include <string>\n-#include <vector>\n+\n+#include \"error_code.h\"\n \n #pragma GCC visibility push(default)\n namespace tera {\n \n-//用于解析原子计数器\n-class CounterCoding {\n-public:\n-    //整数编码为字节buffer\n-    static std::string EncodeCounter(int64_t counter);\n-    //字节buffer解码为整数\n-    static bool DecodeCounter(const std::string& buf,\n-                              int64_t* counter);\n-};\n-\n class RowReaderImpl;\n class Transaction;\n class Table;\n-/// 读取操作\n class RowReader {\n public:\n-    /// 保存用户读取列的请求，格式为map<family, set<qualifier> >，若map大小为0，表示读取整行\n-    typedef std::map<std::string, std::set<std::string> >ReadColumnList;\n \n-    RowReader();\n-    virtual ~RowReader();\n-    /// 返回row key\n-    virtual const std::string& RowName() = 0;\n-    /// 设置读取特定版本\n-    virtual void SetTimestamp(int64_t ts) = 0;\n-    /// 返回读取时间戳\n-    virtual int64_t GetTimestamp() = 0;\n-    /// 设置快照id\n-    virtual void SetSnapshot(uint64_t snapshot_id) = 0;\n-    /// 取出快照id\n-    virtual uint64_t GetSnapshot() = 0;\n-    /// 读取整个family\n+    // Set request filter conditions. If none, returns all cells of this row.\n+    // Add a column family/column, only returns cells in these columns.\n     virtual void AddColumnFamily(const std::string& family) = 0;\n-    virtual void AddColumn(const std::string& cf_name,\n-                           const std::string& qualifier) = 0;\n-\n-    virtual void SetTimeRange(int64_t ts_start, int64_t ts_end) = 0;\n+    virtual void AddColumn(const std::string& family, const std::string& qualifier) = 0;\n+    // Set the maximum number of versions of each column.","path":"include/tera/reader.h","position":64,"original_position":64,"commit_id":"dd732935ab1b307de8d2a83487ecf63052377458","original_commit_id":"dd732935ab1b307de8d2a83487ecf63052377458","user":{"login":"xupeilin","id":11419707,"avatar_url":"https://avatars.githubusercontent.com/u/11419707?v=3","gravatar_id":"","url":"https://api.github.com/users/xupeilin","html_url":"https://github.com/xupeilin","followers_url":"https://api.github.com/users/xupeilin/followers","following_url":"https://api.github.com/users/xupeilin/following{/other_user}","gists_url":"https://api.github.com/users/xupeilin/gists{/gist_id}","starred_url":"https://api.github.com/users/xupeilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xupeilin/subscriptions","organizations_url":"https://api.github.com/users/xupeilin/orgs","repos_url":"https://api.github.com/users/xupeilin/repos","events_url":"https://api.github.com/users/xupeilin/events{/privacy}","received_events_url":"https://api.github.com/users/xupeilin/received_events","type":"User","site_admin":false},"body":"应该指定是单列的版本数吧，否则会有歧义，比如单行的最大版本数之类\r\nmaximum 和max的区别是？之前说不要用缩写啊。。","created_at":"2016-08-24T06:25:46Z","updated_at":"2016-08-24T06:25:46Z","html_url":"https://github.com/baidu/tera/pull/979#discussion_r76000640","pull_request_url":"https://api.github.com/repos/baidu/tera/pulls/979","_links":{"self":{"href":"https://api.github.com/repos/baidu/tera/pulls/comments/76000640"},"html":{"href":"https://github.com/baidu/tera/pull/979#discussion_r76000640"},"pull_request":{"href":"https://api.github.com/repos/baidu/tera/pulls/979"}}},"pull_request":{"url":"https://api.github.com/repos/baidu/tera/pulls/979","id":82153505,"html_url":"https://github.com/baidu/tera/pull/979","diff_url":"https://github.com/baidu/tera/pull/979.diff","patch_url":"https://github.com/baidu/tera/pull/979.patch","issue_url":"https://api.github.com/repos/baidu/tera/issues/979","number":979,"state":"open","locked":false,"title":"modify reader.h #964","user":{"login":"xupeilin","id":11419707,"avatar_url":"https://avatars.githubusercontent.com/u/11419707?v=3","gravatar_id":"","url":"https://api.github.com/users/xupeilin","html_url":"https://github.com/xupeilin","followers_url":"https://api.github.com/users/xupeilin/followers","following_url":"https://api.github.com/users/xupeilin/following{/other_user}","gists_url":"https://api.github.com/users/xupeilin/gists{/gist_id}","starred_url":"https://api.github.com/users/xupeilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xupeilin/subscriptions","organizations_url":"https://api.github.com/users/xupeilin/orgs","repos_url":"https://api.github.com/users/xupeilin/repos","events_url":"https://api.github.com/users/xupeilin/events{/privacy}","received_events_url":"https://api.github.com/users/xupeilin/received_events","type":"User","site_admin":false},"body":"#964 \r\n开发文档 #978 ","created_at":"2016-08-22T08:46:24Z","updated_at":"2016-08-24T06:25:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3b1c2c0e5d916d22dd795d5955355153d44b730","assignee":{"login":"taocp","id":5194281,"avatar_url":"https://avatars.githubusercontent.com/u/5194281?v=3","gravatar_id":"","url":"https://api.github.com/users/taocp","html_url":"https://github.com/taocp","followers_url":"https://api.github.com/users/taocp/followers","following_url":"https://api.github.com/users/taocp/following{/other_user}","gists_url":"https://api.github.com/users/taocp/gists{/gist_id}","starred_url":"https://api.github.com/users/taocp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taocp/subscriptions","organizations_url":"https://api.github.com/users/taocp/orgs","repos_url":"https://api.github.com/users/taocp/repos","events_url":"https://api.github.com/users/taocp/events{/privacy}","received_events_url":"https://api.github.com/users/taocp/received_events","type":"User","site_admin":false},"assignees":[{"login":"taocp","id":5194281,"avatar_url":"https://avatars.githubusercontent.com/u/5194281?v=3","gravatar_id":"","url":"https://api.github.com/users/taocp","html_url":"https://github.com/taocp","followers_url":"https://api.github.com/users/taocp/followers","following_url":"https://api.github.com/users/taocp/following{/other_user}","gists_url":"https://api.github.com/users/taocp/gists{/gist_id}","starred_url":"https://api.github.com/users/taocp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taocp/subscriptions","organizations_url":"https://api.github.com/users/taocp/orgs","repos_url":"https://api.github.com/users/taocp/repos","events_url":"https://api.github.com/users/taocp/events{/privacy}","received_events_url":"https://api.github.com/users/taocp/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/baidu/tera/pulls/979/commits","review_comments_url":"https://api.github.com/repos/baidu/tera/pulls/979/comments","review_comment_url":"https://api.github.com/repos/baidu/tera/pulls/comments{/number}","comments_url":"https://api.github.com/repos/baidu/tera/issues/979/comments","statuses_url":"https://api.github.com/repos/baidu/tera/statuses/dd732935ab1b307de8d2a83487ecf63052377458","head":{"label":"xupeilin:reader.h-refector","ref":"reader.h-refector","sha":"dd732935ab1b307de8d2a83487ecf63052377458","user":{"login":"xupeilin","id":11419707,"avatar_url":"https://avatars.githubusercontent.com/u/11419707?v=3","gravatar_id":"","url":"https://api.github.com/users/xupeilin","html_url":"https://github.com/xupeilin","followers_url":"https://api.github.com/users/xupeilin/followers","following_url":"https://api.github.com/users/xupeilin/following{/other_user}","gists_url":"https://api.github.com/users/xupeilin/gists{/gist_id}","starred_url":"https://api.github.com/users/xupeilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xupeilin/subscriptions","organizations_url":"https://api.github.com/users/xupeilin/orgs","repos_url":"https://api.github.com/users/xupeilin/repos","events_url":"https://api.github.com/users/xupeilin/events{/privacy}","received_events_url":"https://api.github.com/users/xupeilin/received_events","type":"User","site_admin":false},"repo":{"id":32515161,"name":"tera","full_name":"xupeilin/tera","owner":{"login":"xupeilin","id":11419707,"avatar_url":"https://avatars.githubusercontent.com/u/11419707?v=3","gravatar_id":"","url":"https://api.github.com/users/xupeilin","html_url":"https://github.com/xupeilin","followers_url":"https://api.github.com/users/xupeilin/followers","following_url":"https://api.github.com/users/xupeilin/following{/other_user}","gists_url":"https://api.github.com/users/xupeilin/gists{/gist_id}","starred_url":"https://api.github.com/users/xupeilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xupeilin/subscriptions","organizations_url":"https://api.github.com/users/xupeilin/orgs","repos_url":"https://api.github.com/users/xupeilin/repos","events_url":"https://api.github.com/users/xupeilin/events{/privacy}","received_events_url":"https://api.github.com/users/xupeilin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xupeilin/tera","description":"A distributed table storage system.","fork":true,"url":"https://api.github.com/repos/xupeilin/tera","forks_url":"https://api.github.com/repos/xupeilin/tera/forks","keys_url":"https://api.github.com/repos/xupeilin/tera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xupeilin/tera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xupeilin/tera/teams","hooks_url":"https://api.github.com/repos/xupeilin/tera/hooks","issue_events_url":"https://api.github.com/repos/xupeilin/tera/issues/events{/number}","events_url":"https://api.github.com/repos/xupeilin/tera/events","assignees_url":"https://api.github.com/repos/xupeilin/tera/assignees{/user}","branches_url":"https://api.github.com/repos/xupeilin/tera/branches{/branch}","tags_url":"https://api.github.com/repos/xupeilin/tera/tags","blobs_url":"https://api.github.com/repos/xupeilin/tera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xupeilin/tera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xupeilin/tera/git/refs{/sha}","trees_url":"https://api.github.com/repos/xupeilin/tera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xupeilin/tera/statuses/{sha}","languages_url":"https://api.github.com/repos/xupeilin/tera/languages","stargazers_url":"https://api.github.com/repos/xupeilin/tera/stargazers","contributors_url":"https://api.github.com/repos/xupeilin/tera/contributors","subscribers_url":"https://api.github.com/repos/xupeilin/tera/subscribers","subscription_url":"https://api.github.com/repos/xupeilin/tera/subscription","commits_url":"https://api.github.com/repos/xupeilin/tera/commits{/sha}","git_commits_url":"https://api.github.com/repos/xupeilin/tera/git/commits{/sha}","comments_url":"https://api.github.com/repos/xupeilin/tera/comments{/number}","issue_comment_url":"https://api.github.com/repos/xupeilin/tera/issues/comments{/number}","contents_url":"https://api.github.com/repos/xupeilin/tera/contents/{+path}","compare_url":"https://api.github.com/repos/xupeilin/tera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xupeilin/tera/merges","archive_url":"https://api.github.com/repos/xupeilin/tera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xupeilin/tera/downloads","issues_url":"https://api.github.com/repos/xupeilin/tera/issues{/number}","pulls_url":"https://api.github.com/repos/xupeilin/tera/pulls{/number}","milestones_url":"https://api.github.com/repos/xupeilin/tera/milestones{/number}","notifications_url":"https://api.github.com/repos/xupeilin/tera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xupeilin/tera/labels{/name}","releases_url":"https://api.github.com/repos/xupeilin/tera/releases{/id}","deployments_url":"https://api.github.com/repos/xupeilin/tera/deployments","created_at":"2015-03-19T10:32:01Z","updated_at":"2016-03-17T06:48:11Z","pushed_at":"2016-08-24T06:18:47Z","git_url":"git://github.com/xupeilin/tera.git","ssh_url":"git@github.com:xupeilin/tera.git","clone_url":"https://github.com/xupeilin/tera.git","svn_url":"https://github.com/xupeilin/tera","homepage":"","size":15883,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"baidu:master","ref":"master","sha":"c2d152dfb455b005bdb87dc09781e65e7b6e9a3e","user":{"login":"baidu","id":13245940,"avatar_url":"https://avatars.githubusercontent.com/u/13245940?v=3","gravatar_id":"","url":"https://api.github.com/users/baidu","html_url":"https://github.com/baidu","followers_url":"https://api.github.com/users/baidu/followers","following_url":"https://api.github.com/users/baidu/following{/other_user}","gists_url":"https://api.github.com/users/baidu/gists{/gist_id}","starred_url":"https://api.github.com/users/baidu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baidu/subscriptions","organizations_url":"https://api.github.com/users/baidu/orgs","repos_url":"https://api.github.com/users/baidu/repos","events_url":"https://api.github.com/users/baidu/events{/privacy}","received_events_url":"https://api.github.com/users/baidu/received_events","type":"Organization","site_admin":false},"repo":{"id":18129915,"name":"tera","full_name":"baidu/tera","owner":{"login":"baidu","id":13245940,"avatar_url":"https://avatars.githubusercontent.com/u/13245940?v=3","gravatar_id":"","url":"https://api.github.com/users/baidu","html_url":"https://github.com/baidu","followers_url":"https://api.github.com/users/baidu/followers","following_url":"https://api.github.com/users/baidu/following{/other_user}","gists_url":"https://api.github.com/users/baidu/gists{/gist_id}","starred_url":"https://api.github.com/users/baidu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baidu/subscriptions","organizations_url":"https://api.github.com/users/baidu/orgs","repos_url":"https://api.github.com/users/baidu/repos","events_url":"https://api.github.com/users/baidu/events{/privacy}","received_events_url":"https://api.github.com/users/baidu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/baidu/tera","description":"A distributed, elastic, structured database.","fork":false,"url":"https://api.github.com/repos/baidu/tera","forks_url":"https://api.github.com/repos/baidu/tera/forks","keys_url":"https://api.github.com/repos/baidu/tera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baidu/tera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baidu/tera/teams","hooks_url":"https://api.github.com/repos/baidu/tera/hooks","issue_events_url":"https://api.github.com/repos/baidu/tera/issues/events{/number}","events_url":"https://api.github.com/repos/baidu/tera/events","assignees_url":"https://api.github.com/repos/baidu/tera/assignees{/user}","branches_url":"https://api.github.com/repos/baidu/tera/branches{/branch}","tags_url":"https://api.github.com/repos/baidu/tera/tags","blobs_url":"https://api.github.com/repos/baidu/tera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baidu/tera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baidu/tera/git/refs{/sha}","trees_url":"https://api.github.com/repos/baidu/tera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baidu/tera/statuses/{sha}","languages_url":"https://api.github.com/repos/baidu/tera/languages","stargazers_url":"https://api.github.com/repos/baidu/tera/stargazers","contributors_url":"https://api.github.com/repos/baidu/tera/contributors","subscribers_url":"https://api.github.com/repos/baidu/tera/subscribers","subscription_url":"https://api.github.com/repos/baidu/tera/subscription","commits_url":"https://api.github.com/repos/baidu/tera/commits{/sha}","git_commits_url":"https://api.github.com/repos/baidu/tera/git/commits{/sha}","comments_url":"https://api.github.com/repos/baidu/tera/comments{/number}","issue_comment_url":"https://api.github.com/repos/baidu/tera/issues/comments{/number}","contents_url":"https://api.github.com/repos/baidu/tera/contents/{+path}","compare_url":"https://api.github.com/repos/baidu/tera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baidu/tera/merges","archive_url":"https://api.github.com/repos/baidu/tera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baidu/tera/downloads","issues_url":"https://api.github.com/repos/baidu/tera/issues{/number}","pulls_url":"https://api.github.com/repos/baidu/tera/pulls{/number}","milestones_url":"https://api.github.com/repos/baidu/tera/milestones{/number}","notifications_url":"https://api.github.com/repos/baidu/tera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baidu/tera/labels{/name}","releases_url":"https://api.github.com/repos/baidu/tera/releases{/id}","deployments_url":"https://api.github.com/repos/baidu/tera/deployments","created_at":"2014-03-26T07:22:05Z","updated_at":"2016-08-23T10:06:45Z","pushed_at":"2016-08-24T06:18:48Z","git_url":"git://github.com/baidu/tera.git","ssh_url":"git@github.com:baidu/tera.git","clone_url":"https://github.com/baidu/tera.git","svn_url":"https://github.com/baidu/tera","homepage":"","size":17557,"stargazers_count":412,"watchers_count":412,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":149,"mirror_url":null,"open_issues_count":158,"forks":149,"open_issues":158,"watchers":412,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/baidu/tera/pulls/979"},"html":{"href":"https://github.com/baidu/tera/pull/979"},"issue":{"href":"https://api.github.com/repos/baidu/tera/issues/979"},"comments":{"href":"https://api.github.com/repos/baidu/tera/issues/979/comments"},"review_comments":{"href":"https://api.github.com/repos/baidu/tera/pulls/979/comments"},"review_comment":{"href":"https://api.github.com/repos/baidu/tera/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/baidu/tera/pulls/979/commits"},"statuses":{"href":"https://api.github.com/repos/baidu/tera/statuses/dd732935ab1b307de8d2a83487ecf63052377458"}}}}
{"actor":{"display_login":"xupeilin"}}