{"action":"created","comment":{"url":"https://api.github.com/repos/laravel/framework/pulls/comments/77808790","id":77808790,"diff_hunk":"@@ -89,10 +90,14 @@ public function test_job_is_not_released_if_it_has_exceeded_max_attempts()\n     {\n         $e = new RuntimeException;\n \n-        $job = new WorkerFakeJob(function () use ($e) {\n+        $job = new WorkerFakeJob(function ($job) use ($e) {\n+","path":"tests/Queue/QueueWorkerTest.php","position":13,"original_position":13,"commit_id":"73752e0a2332a6927bedd6872be04077d7faaa3d","original_commit_id":"73752e0a2332a6927bedd6872be04077d7faaa3d","user":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars.githubusercontent.com/u/2829600?v=3","gravatar_id":"","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"body":"please remove this extra line","created_at":"2016-09-07T12:07:08Z","updated_at":"2016-09-07T12:07:08Z","html_url":"https://github.com/laravel/framework/pull/15319#discussion_r77808790","pull_request_url":"https://api.github.com/repos/laravel/framework/pulls/15319","_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments/77808790"},"html":{"href":"https://github.com/laravel/framework/pull/15319#discussion_r77808790"},"pull_request":{"href":"https://api.github.com/repos/laravel/framework/pulls/15319"}}},"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/15319","id":84282053,"html_url":"https://github.com/laravel/framework/pull/15319","diff_url":"https://github.com/laravel/framework/pull/15319.diff","patch_url":"https://github.com/laravel/framework/pull/15319.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/15319","number":15319,"state":"open","locked":false,"title":"[5.3] Check attempts before firing queue job.","user":{"login":"maxbrokman","id":5322152,"avatar_url":"https://avatars.githubusercontent.com/u/5322152?v=3","gravatar_id":"","url":"https://api.github.com/users/maxbrokman","html_url":"https://github.com/maxbrokman","followers_url":"https://api.github.com/users/maxbrokman/followers","following_url":"https://api.github.com/users/maxbrokman/following{/other_user}","gists_url":"https://api.github.com/users/maxbrokman/gists{/gist_id}","starred_url":"https://api.github.com/users/maxbrokman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxbrokman/subscriptions","organizations_url":"https://api.github.com/users/maxbrokman/orgs","repos_url":"https://api.github.com/users/maxbrokman/repos","events_url":"https://api.github.com/users/maxbrokman/events{/privacy}","received_events_url":"https://api.github.com/users/maxbrokman/received_events","type":"User","site_admin":false},"body":"Check jobs before working to see if they have already been received too many times.\r\n\r\nResolves an issue with the `--timeout` feature where jobs the repeatedly timed out would never be marked as `failed`, as the worker process would be killed before\r\nit could reach the failing logic.\r\n\r\nTo maintain compatibility there are now two checks against the number of attempts a job has had, one before working the job and one in the case of an job raising an exception.\r\n\r\nsee laravel/framework#15317 for more details.","created_at":"2016-09-07T11:21:45Z","updated_at":"2016-09-07T12:07:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbcc402b12ebbcfe6bf85ba39dc1194a5636593f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/15319/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/15319/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/15319/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/73752e0a2332a6927bedd6872be04077d7faaa3d","head":{"label":"maxbrokman:queueFailureOnTimeout","ref":"queueFailureOnTimeout","sha":"73752e0a2332a6927bedd6872be04077d7faaa3d","user":{"login":"maxbrokman","id":5322152,"avatar_url":"https://avatars.githubusercontent.com/u/5322152?v=3","gravatar_id":"","url":"https://api.github.com/users/maxbrokman","html_url":"https://github.com/maxbrokman","followers_url":"https://api.github.com/users/maxbrokman/followers","following_url":"https://api.github.com/users/maxbrokman/following{/other_user}","gists_url":"https://api.github.com/users/maxbrokman/gists{/gist_id}","starred_url":"https://api.github.com/users/maxbrokman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxbrokman/subscriptions","organizations_url":"https://api.github.com/users/maxbrokman/orgs","repos_url":"https://api.github.com/users/maxbrokman/repos","events_url":"https://api.github.com/users/maxbrokman/events{/privacy}","received_events_url":"https://api.github.com/users/maxbrokman/received_events","type":"User","site_admin":false},"repo":{"id":67599805,"name":"framework","full_name":"maxbrokman/framework","owner":{"login":"maxbrokman","id":5322152,"avatar_url":"https://avatars.githubusercontent.com/u/5322152?v=3","gravatar_id":"","url":"https://api.github.com/users/maxbrokman","html_url":"https://github.com/maxbrokman","followers_url":"https://api.github.com/users/maxbrokman/followers","following_url":"https://api.github.com/users/maxbrokman/following{/other_user}","gists_url":"https://api.github.com/users/maxbrokman/gists{/gist_id}","starred_url":"https://api.github.com/users/maxbrokman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxbrokman/subscriptions","organizations_url":"https://api.github.com/users/maxbrokman/orgs","repos_url":"https://api.github.com/users/maxbrokman/repos","events_url":"https://api.github.com/users/maxbrokman/events{/privacy}","received_events_url":"https://api.github.com/users/maxbrokman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxbrokman/framework","description":null,"fork":true,"url":"https://api.github.com/repos/maxbrokman/framework","forks_url":"https://api.github.com/repos/maxbrokman/framework/forks","keys_url":"https://api.github.com/repos/maxbrokman/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxbrokman/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxbrokman/framework/teams","hooks_url":"https://api.github.com/repos/maxbrokman/framework/hooks","issue_events_url":"https://api.github.com/repos/maxbrokman/framework/issues/events{/number}","events_url":"https://api.github.com/repos/maxbrokman/framework/events","assignees_url":"https://api.github.com/repos/maxbrokman/framework/assignees{/user}","branches_url":"https://api.github.com/repos/maxbrokman/framework/branches{/branch}","tags_url":"https://api.github.com/repos/maxbrokman/framework/tags","blobs_url":"https://api.github.com/repos/maxbrokman/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxbrokman/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxbrokman/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxbrokman/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxbrokman/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/maxbrokman/framework/languages","stargazers_url":"https://api.github.com/repos/maxbrokman/framework/stargazers","contributors_url":"https://api.github.com/repos/maxbrokman/framework/contributors","subscribers_url":"https://api.github.com/repos/maxbrokman/framework/subscribers","subscription_url":"https://api.github.com/repos/maxbrokman/framework/subscription","commits_url":"https://api.github.com/repos/maxbrokman/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxbrokman/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxbrokman/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxbrokman/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxbrokman/framework/contents/{+path}","compare_url":"https://api.github.com/repos/maxbrokman/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxbrokman/framework/merges","archive_url":"https://api.github.com/repos/maxbrokman/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxbrokman/framework/downloads","issues_url":"https://api.github.com/repos/maxbrokman/framework/issues{/number}","pulls_url":"https://api.github.com/repos/maxbrokman/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/maxbrokman/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/maxbrokman/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxbrokman/framework/labels{/name}","releases_url":"https://api.github.com/repos/maxbrokman/framework/releases{/id}","deployments_url":"https://api.github.com/repos/maxbrokman/framework/deployments","created_at":"2016-09-07T11:17:00Z","updated_at":"2016-09-07T11:17:06Z","pushed_at":"2016-09-07T11:27:43Z","git_url":"git://github.com/maxbrokman/framework.git","ssh_url":"git@github.com:maxbrokman/framework.git","clone_url":"https://github.com/maxbrokman/framework.git","svn_url":"https://github.com/maxbrokman/framework","homepage":"http://laravel.com","size":50605,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.3"}},"base":{"label":"laravel:5.3","ref":"5.3","sha":"e68358dc4072b0826e193826e62b886d3f6322df","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","deployments_url":"https://api.github.com/repos/laravel/framework/deployments","created_at":"2013-01-10T21:27:28Z","updated_at":"2016-09-07T06:10:03Z","pushed_at":"2016-09-07T11:27:44Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":50605,"stargazers_count":5877,"watchers_count":5877,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3447,"mirror_url":null,"open_issues_count":163,"forks":3447,"open_issues":163,"watchers":5877,"default_branch":"5.3"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/15319"},"html":{"href":"https://github.com/laravel/framework/pull/15319"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/15319"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/15319/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/15319/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/15319/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/73752e0a2332a6927bedd6872be04077d7faaa3d"}}}}
{"actor":{"display_login":"GrahamCampbell"}}