{"action":"closed","number":4658,"pull_request":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/4658","id":92969466,"html_url":"https://github.com/google/ggrc-core/pull/4658","diff_url":"https://github.com/google/ggrc-core/pull/4658.diff","patch_url":"https://github.com/google/ggrc-core/pull/4658.patch","issue_url":"https://api.github.com/repos/google/ggrc-core/issues/4658","number":4658,"state":"closed","locked":false,"title":"GGRC-39 Change help button to point to Google help page","user":{"login":"plamut","id":1235663,"avatar_url":"https://avatars.githubusercontent.com/u/1235663?v=3","gravatar_id":"","url":"https://api.github.com/users/plamut","html_url":"https://github.com/plamut","followers_url":"https://api.github.com/users/plamut/followers","following_url":"https://api.github.com/users/plamut/following{/other_user}","gists_url":"https://api.github.com/users/plamut/gists{/gist_id}","starred_url":"https://api.github.com/users/plamut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plamut/subscriptions","organizations_url":"https://api.github.com/users/plamut/orgs","repos_url":"https://api.github.com/users/plamut/repos","events_url":"https://api.github.com/users/plamut/events{/privacy}","received_events_url":"https://api.github.com/users/plamut/received_events","type":"User","site_admin":false},"body":"The `Help` link in the upper right corner of the page should now open the Google help page<sup>1</sup> instead of the existing internal help modal. I heard that if using Google laptop, the link takes you to directly to the GRC help page (right, @Smotko?).\r\n\r\nAdding the `please review` label because this issue has a higher priority.\r\n\r\nIf we now need to remove the (non-used?) help modal window, the `helps` DB table and other related assets, and if this is in scope of this PR, please let me know and I will update the PR. Otherwise I suggest opening a refactoring ticket, because after all removing all that is not strictly needed for the fix.\r\n\r\n---\r\n\r\n<sup>1</sup>The URL needs to be configured by setting the `GRC_EXTERNAL_HELP_URL` environment variable.","created_at":"2016-11-09T14:09:23Z","updated_at":"2016-11-10T22:00:24Z","closed_at":"2016-11-10T22:00:23Z","merged_at":"2016-11-10T22:00:23Z","merge_commit_sha":"6605c878c0f87a4b0700e7a76f46235820c5d9f5","assignee":{"login":"Smotko","id":513444,"avatar_url":"https://avatars.githubusercontent.com/u/513444?v=3","gravatar_id":"","url":"https://api.github.com/users/Smotko","html_url":"https://github.com/Smotko","followers_url":"https://api.github.com/users/Smotko/followers","following_url":"https://api.github.com/users/Smotko/following{/other_user}","gists_url":"https://api.github.com/users/Smotko/gists{/gist_id}","starred_url":"https://api.github.com/users/Smotko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smotko/subscriptions","organizations_url":"https://api.github.com/users/Smotko/orgs","repos_url":"https://api.github.com/users/Smotko/repos","events_url":"https://api.github.com/users/Smotko/events{/privacy}","received_events_url":"https://api.github.com/users/Smotko/received_events","type":"User","site_admin":false},"assignees":[{"login":"Smotko","id":513444,"avatar_url":"https://avatars.githubusercontent.com/u/513444?v=3","gravatar_id":"","url":"https://api.github.com/users/Smotko","html_url":"https://github.com/Smotko","followers_url":"https://api.github.com/users/Smotko/followers","following_url":"https://api.github.com/users/Smotko/following{/other_user}","gists_url":"https://api.github.com/users/Smotko/gists{/gist_id}","starred_url":"https://api.github.com/users/Smotko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smotko/subscriptions","organizations_url":"https://api.github.com/users/Smotko/orgs","repos_url":"https://api.github.com/users/Smotko/repos","events_url":"https://api.github.com/users/Smotko/events{/privacy}","received_events_url":"https://api.github.com/users/Smotko/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/google/ggrc-core/milestones/26","html_url":"https://github.com/google/ggrc-core/milestones/0.9.7-Quince-PATCH4","labels_url":"https://api.github.com/repos/google/ggrc-core/milestones/26/labels","id":2122087,"number":26,"title":"0.9.7-Quince-PATCH4","description":"","creator":{"login":"Smotko","id":513444,"avatar_url":"https://avatars.githubusercontent.com/u/513444?v=3","gravatar_id":"","url":"https://api.github.com/users/Smotko","html_url":"https://github.com/Smotko","followers_url":"https://api.github.com/users/Smotko/followers","following_url":"https://api.github.com/users/Smotko/following{/other_user}","gists_url":"https://api.github.com/users/Smotko/gists{/gist_id}","starred_url":"https://api.github.com/users/Smotko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smotko/subscriptions","organizations_url":"https://api.github.com/users/Smotko/orgs","repos_url":"https://api.github.com/users/Smotko/repos","events_url":"https://api.github.com/users/Smotko/events{/privacy}","received_events_url":"https://api.github.com/users/Smotko/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":5,"state":"open","created_at":"2016-11-08T14:46:14Z","updated_at":"2016-11-10T22:00:23Z","due_on":"2016-11-17T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/google/ggrc-core/pulls/4658/commits","review_comments_url":"https://api.github.com/repos/google/ggrc-core/pulls/4658/comments","review_comment_url":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ggrc-core/issues/4658/comments","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/f32a2d215f82898e781900081254682a1e504d07","head":{"label":"plamut:ggrc-39","ref":"ggrc-39","sha":"f32a2d215f82898e781900081254682a1e504d07","user":{"login":"plamut","id":1235663,"avatar_url":"https://avatars.githubusercontent.com/u/1235663?v=3","gravatar_id":"","url":"https://api.github.com/users/plamut","html_url":"https://github.com/plamut","followers_url":"https://api.github.com/users/plamut/followers","following_url":"https://api.github.com/users/plamut/following{/other_user}","gists_url":"https://api.github.com/users/plamut/gists{/gist_id}","starred_url":"https://api.github.com/users/plamut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plamut/subscriptions","organizations_url":"https://api.github.com/users/plamut/orgs","repos_url":"https://api.github.com/users/plamut/repos","events_url":"https://api.github.com/users/plamut/events{/privacy}","received_events_url":"https://api.github.com/users/plamut/received_events","type":"User","site_admin":false},"repo":{"id":46784845,"name":"ggrc-core","full_name":"plamut/ggrc-core","owner":{"login":"plamut","id":1235663,"avatar_url":"https://avatars.githubusercontent.com/u/1235663?v=3","gravatar_id":"","url":"https://api.github.com/users/plamut","html_url":"https://github.com/plamut","followers_url":"https://api.github.com/users/plamut/followers","following_url":"https://api.github.com/users/plamut/following{/other_user}","gists_url":"https://api.github.com/users/plamut/gists{/gist_id}","starred_url":"https://api.github.com/users/plamut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plamut/subscriptions","organizations_url":"https://api.github.com/users/plamut/orgs","repos_url":"https://api.github.com/users/plamut/repos","events_url":"https://api.github.com/users/plamut/events{/privacy}","received_events_url":"https://api.github.com/users/plamut/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/plamut/ggrc-core","description":"GGRC Core","fork":true,"url":"https://api.github.com/repos/plamut/ggrc-core","forks_url":"https://api.github.com/repos/plamut/ggrc-core/forks","keys_url":"https://api.github.com/repos/plamut/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plamut/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plamut/ggrc-core/teams","hooks_url":"https://api.github.com/repos/plamut/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/plamut/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/plamut/ggrc-core/events","assignees_url":"https://api.github.com/repos/plamut/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/plamut/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/plamut/ggrc-core/tags","blobs_url":"https://api.github.com/repos/plamut/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plamut/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plamut/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/plamut/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plamut/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/plamut/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/plamut/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/plamut/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/plamut/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/plamut/ggrc-core/subscription","commits_url":"https://api.github.com/repos/plamut/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/plamut/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/plamut/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/plamut/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/plamut/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/plamut/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plamut/ggrc-core/merges","archive_url":"https://api.github.com/repos/plamut/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plamut/ggrc-core/downloads","issues_url":"https://api.github.com/repos/plamut/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/plamut/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/plamut/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/plamut/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plamut/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/plamut/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/plamut/ggrc-core/deployments","created_at":"2015-11-24T10:37:33Z","updated_at":"2016-11-07T17:12:47Z","pushed_at":"2016-11-10T15:35:46Z","git_url":"git://github.com/plamut/ggrc-core.git","ssh_url":"git@github.com:plamut/ggrc-core.git","clone_url":"https://github.com/plamut/ggrc-core.git","svn_url":"https://github.com/plamut/ggrc-core","homepage":null,"size":56371,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"google:release/0.9.7-Quince","ref":"release/0.9.7-Quince","sha":"4feb91eb98c75d37ab7fe5fe84f11c597d7c48a0","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":9304637,"name":"ggrc-core","full_name":"google/ggrc-core","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/ggrc-core","description":"GGRC Core","fork":false,"url":"https://api.github.com/repos/google/ggrc-core","forks_url":"https://api.github.com/repos/google/ggrc-core/forks","keys_url":"https://api.github.com/repos/google/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ggrc-core/teams","hooks_url":"https://api.github.com/repos/google/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/google/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/google/ggrc-core/events","assignees_url":"https://api.github.com/repos/google/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/google/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/google/ggrc-core/tags","blobs_url":"https://api.github.com/repos/google/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/google/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/google/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/google/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/google/ggrc-core/subscription","commits_url":"https://api.github.com/repos/google/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/google/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ggrc-core/merges","archive_url":"https://api.github.com/repos/google/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ggrc-core/downloads","issues_url":"https://api.github.com/repos/google/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/google/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/google/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/google/ggrc-core/deployments","created_at":"2013-04-08T19:16:28Z","updated_at":"2016-11-02T01:18:34Z","pushed_at":"2016-11-10T22:00:24Z","git_url":"git://github.com/google/ggrc-core.git","ssh_url":"git@github.com:google/ggrc-core.git","clone_url":"https://github.com/google/ggrc-core.git","svn_url":"https://github.com/google/ggrc-core","homepage":null,"size":66631,"stargazers_count":141,"watchers_count":141,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":17,"forks":110,"open_issues":17,"watchers":141,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/4658"},"html":{"href":"https://github.com/google/ggrc-core/pull/4658"},"issue":{"href":"https://api.github.com/repos/google/ggrc-core/issues/4658"},"comments":{"href":"https://api.github.com/repos/google/ggrc-core/issues/4658/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/4658/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/4658/commits"},"statuses":{"href":"https://api.github.com/repos/google/ggrc-core/statuses/f32a2d215f82898e781900081254682a1e504d07"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Smotko","id":513444,"avatar_url":"https://avatars.githubusercontent.com/u/513444?v=3","gravatar_id":"","url":"https://api.github.com/users/Smotko","html_url":"https://github.com/Smotko","followers_url":"https://api.github.com/users/Smotko/followers","following_url":"https://api.github.com/users/Smotko/following{/other_user}","gists_url":"https://api.github.com/users/Smotko/gists{/gist_id}","starred_url":"https://api.github.com/users/Smotko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smotko/subscriptions","organizations_url":"https://api.github.com/users/Smotko/orgs","repos_url":"https://api.github.com/users/Smotko/repos","events_url":"https://api.github.com/users/Smotko/events{/privacy}","received_events_url":"https://api.github.com/users/Smotko/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":1,"additions":14,"deletions":1,"changed_files":8}}
{"actor":{"display_login":"Smotko"}}