{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/logstash/issues/5129","repository_url":"https://api.github.com/repos/elastic/logstash","labels_url":"https://api.github.com/repos/elastic/logstash/issues/5129/labels{/name}","comments_url":"https://api.github.com/repos/elastic/logstash/issues/5129/comments","events_url":"https://api.github.com/repos/elastic/logstash/issues/5129/events","html_url":"https://github.com/elastic/logstash/issues/5129","id":148925168,"number":5129,"title":"Sighup is ignored by logstash 2.3.1","user":{"login":"randude","id":16238019,"avatar_url":"https://avatars.githubusercontent.com/u/16238019?v=3","gravatar_id":"","url":"https://api.github.com/users/randude","html_url":"https://github.com/randude","followers_url":"https://api.github.com/users/randude/followers","following_url":"https://api.github.com/users/randude/following{/other_user}","gists_url":"https://api.github.com/users/randude/gists{/gist_id}","starred_url":"https://api.github.com/users/randude/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randude/subscriptions","organizations_url":"https://api.github.com/users/randude/orgs","repos_url":"https://api.github.com/users/randude/repos","events_url":"https://api.github.com/users/randude/events{/privacy}","received_events_url":"https://api.github.com/users/randude/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/logstash/labels/bug","name":"bug","color":"e11d21"},{"url":"https://api.github.com/repos/elastic/logstash/labels/unconfirmed","name":"unconfirmed","color":"cc317c"}],"state":"open","locked":false,"assignee":{"login":"jsvd","id":31809,"avatar_url":"https://avatars.githubusercontent.com/u/31809?v=3","gravatar_id":"","url":"https://api.github.com/users/jsvd","html_url":"https://github.com/jsvd","followers_url":"https://api.github.com/users/jsvd/followers","following_url":"https://api.github.com/users/jsvd/following{/other_user}","gists_url":"https://api.github.com/users/jsvd/gists{/gist_id}","starred_url":"https://api.github.com/users/jsvd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsvd/subscriptions","organizations_url":"https://api.github.com/users/jsvd/orgs","repos_url":"https://api.github.com/users/jsvd/repos","events_url":"https://api.github.com/users/jsvd/events{/privacy}","received_events_url":"https://api.github.com/users/jsvd/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2016-04-17T06:56:01Z","updated_at":"2016-04-19T19:49:23Z","closed_at":null,"body":"https://discuss.elastic.co/t/sighup-doesnt-work-for-reloading-conf/47403\r\n\r\nsighup is supposed to cause logstash 2.3.1 to reload conf files. This doesnt happen on my ubuntu 12 machine. \r\nHowever, --auto-reload does seem to be working.\r\n\r\nYour questions will reach our wider community members there, and if we confirm that there is a bug, then we can open a new issue here.\r\n\r\nI'm sending the sighup using the kill command manually as the root user.\r\n"},"comment":{"url":"https://api.github.com/repos/elastic/logstash/issues/comments/212094760","html_url":"https://github.com/elastic/logstash/issues/5129#issuecomment-212094760","issue_url":"https://api.github.com/repos/elastic/logstash/issues/5129","id":212094760,"user":{"login":"jordansissel","id":131818,"avatar_url":"https://avatars.githubusercontent.com/u/131818?v=3","gravatar_id":"","url":"https://api.github.com/users/jordansissel","html_url":"https://github.com/jordansissel","followers_url":"https://api.github.com/users/jordansissel/followers","following_url":"https://api.github.com/users/jordansissel/following{/other_user}","gists_url":"https://api.github.com/users/jordansissel/gists{/gist_id}","starred_url":"https://api.github.com/users/jordansissel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordansissel/subscriptions","organizations_url":"https://api.github.com/users/jordansissel/orgs","repos_url":"https://api.github.com/users/jordansissel/repos","events_url":"https://api.github.com/users/jordansissel/events{/privacy}","received_events_url":"https://api.github.com/users/jordansissel/received_events","type":"User","site_admin":false},"created_at":"2016-04-19T19:49:23Z","updated_at":"2016-04-19T19:49:23Z","body":"> it crashes when it tries to reload the bad conf as expected.\r\n\r\nCan you describe what you mean by \"it crashes\" ? Logstash should not crash if the configuration is bad upon reload. When I test this, I get this error message and Logstash continues running with the old configuration:\r\n\r\n```\r\nSIGHUP received. {:level=>:warn}\r\nfetched an invalid config {:config=>\"input { file { path => \\\"/tmp/x2\\\"  }\\nfilt\r\ner {\\n  mutate {\\n    add_tag => \\\"fancy1\\\"\\n  }\\n}\\noutput { stdout { codec =>\r\nrubydebug } }\\n\\n\", :reason=>\"Expected one of #, => at line 3, column 10 (byte 5\r\n5) after input { file { path => \\\"/tmp/x2\\\"  }\\nfilter {\\n  mutate \", :level=>:e\r\nrror}\r\n```\r\n\r\nAlso, when I send SIGHUP, it seems to work fine for me (tested on Logstash 2.3.1). If the configuration is invalid, Logstash will log an error and continue with the old config. If the configuration file hasn't changed, Logstash will not do anything. "}}