{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node-v0.x-archive/issues/25353","repository_url":"https://api.github.com/repos/nodejs/node-v0.x-archive","labels_url":"https://api.github.com/repos/nodejs/node-v0.x-archive/issues/25353/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node-v0.x-archive/issues/25353/comments","events_url":"https://api.github.com/repos/nodejs/node-v0.x-archive/issues/25353/events","html_url":"https://github.com/nodejs/node-v0.x-archive/issues/25353","id":78289464,"number":25353,"title":"url.parse() fails if auth contain a colon","user":{"login":"ben-page","id":744035,"avatar_url":"https://avatars.githubusercontent.com/u/744035?v=3","gravatar_id":"","url":"https://api.github.com/users/ben-page","html_url":"https://github.com/ben-page","followers_url":"https://api.github.com/users/ben-page/followers","following_url":"https://api.github.com/users/ben-page/following{/other_user}","gists_url":"https://api.github.com/users/ben-page/gists{/gist_id}","starred_url":"https://api.github.com/users/ben-page/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben-page/subscriptions","organizations_url":"https://api.github.com/users/ben-page/orgs","repos_url":"https://api.github.com/users/ben-page/repos","events_url":"https://api.github.com/users/ben-page/events{/privacy}","received_events_url":"https://api.github.com/users/ben-page/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node-v0.x-archive/labels/P-3","name":"P-3","color":"009800"},{"url":"https://api.github.com/repos/nodejs/node-v0.x-archive/labels/S-confirmed-bug","name":"S-confirmed-bug","color":"444444"}],"state":"closed","locked":false,"assignee":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"milestone":null,"comments":11,"created_at":"2015-05-19T23:20:43Z","updated_at":"2016-04-08T17:56:20Z","closed_at":"2016-04-08T17:56:20Z","body":"If the user or the password component of auth contains colons, url.parse() fails.\r\n```javascript\r\nvar url = require('url');\r\n\r\nvar user = encodeURIComponent('us:er');\r\nvar password = encodeURIComponent('pass:word');\r\nvar uri = 'http://' + user + ':' + password + '@localhost/';\r\nconsole.log(uri); // http://us%3Aer:pass%3Aword@localhost/\r\n\r\nvar parsed = url.parse(uri);\r\nconsole.log(parsed.auth); // us:er:pass:word\r\n```\r\n\r\nThe output of parse() is not understood by format().\r\n```javascript\r\nconsole.log(url.format(parsed)); // http://us:er%3Apass%3Aword@localhost/\r\n```\r\n\r\nI think auth needs to be split into two fields (username and password)."},"comment":{"url":"https://api.github.com/repos/nodejs/node-v0.x-archive/issues/comments/207537141","html_url":"https://github.com/nodejs/node-v0.x-archive/issues/25353#issuecomment-207537141","issue_url":"https://api.github.com/repos/nodejs/node-v0.x-archive/issues/25353","id":207537141,"user":{"login":"ChALkeR","id":291301,"avatar_url":"https://avatars.githubusercontent.com/u/291301?v=3","gravatar_id":"","url":"https://api.github.com/users/ChALkeR","html_url":"https://github.com/ChALkeR","followers_url":"https://api.github.com/users/ChALkeR/followers","following_url":"https://api.github.com/users/ChALkeR/following{/other_user}","gists_url":"https://api.github.com/users/ChALkeR/gists{/gist_id}","starred_url":"https://api.github.com/users/ChALkeR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChALkeR/subscriptions","organizations_url":"https://api.github.com/users/ChALkeR/orgs","repos_url":"https://api.github.com/users/ChALkeR/repos","events_url":"https://api.github.com/users/ChALkeR/events{/privacy}","received_events_url":"https://api.github.com/users/ChALkeR/received_events","type":"User","site_admin":false},"created_at":"2016-04-08T17:56:20Z","updated_at":"2016-04-08T17:56:20Z","body":"This is reported to nodejs/node issues as https://github.com/nodejs/node/issues/1802.\r\nNo need to keep this open here, the discussion should move there."}}