{"action":"created","comment":{"url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/comments/64443745","id":64443745,"diff_hunk":"@@ -0,0 +1,69 @@\n+var ClientSuccessRateGraph = (function() {\n+  var neutralLineColor = \"#878787\"; // greys.neutral\n+\n+  function createChartLegend(successLineColor) {\n+    return {\n+      topLine: neutralLineColor,\n+      successRate: successLineColor\n+    }\n+  }\n+\n+  function initializeChart($chartEl, dataKeys, timeseriesParamsFn) {\n+    var $canvas = $(\"<canvas id='canvas' height='141'></canvas>\");","path":"admin/src/main/resources/io/buoyant/admin/js/client_success_graph.js","position":12,"original_position":12,"commit_id":"2a7aaefe423c94b4c83961d122876ece173e7799","original_commit_id":"2a7aaefe423c94b4c83961d122876ece173e7799","user":{"login":"esbie","id":41829,"avatar_url":"https://avatars.githubusercontent.com/u/41829?v=3","gravatar_id":"","url":"https://api.github.com/users/esbie","html_url":"https://github.com/esbie","followers_url":"https://api.github.com/users/esbie/followers","following_url":"https://api.github.com/users/esbie/following{/other_user}","gists_url":"https://api.github.com/users/esbie/gists{/gist_id}","starred_url":"https://api.github.com/users/esbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esbie/subscriptions","organizations_url":"https://api.github.com/users/esbie/orgs","repos_url":"https://api.github.com/users/esbie/repos","events_url":"https://api.github.com/users/esbie/events{/privacy}","received_events_url":"https://api.github.com/users/esbie/received_events","type":"User","site_admin":false},"body":"lol we should not have so many charts all with id of \"canvas\" (id is supposed to guarantee uniqueness)","created_at":"2016-05-24T18:02:57Z","updated_at":"2016-05-24T18:02:57Z","html_url":"https://github.com/BuoyantIO/linkerd/pull/441#discussion_r64443745","pull_request_url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/441","_links":{"self":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/comments/64443745"},"html":{"href":"https://github.com/BuoyantIO/linkerd/pull/441#discussion_r64443745"},"pull_request":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/441"}}},"pull_request":{"url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/441","id":71143259,"html_url":"https://github.com/BuoyantIO/linkerd/pull/441","diff_url":"https://github.com/BuoyantIO/linkerd/pull/441.diff","patch_url":"https://github.com/BuoyantIO/linkerd/pull/441.patch","issue_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/441","number":441,"state":"open","locked":false,"title":"Change client latency graph to be a success rate graph","user":{"login":"rmars","id":549258,"avatar_url":"https://avatars.githubusercontent.com/u/549258?v=3","gravatar_id":"","url":"https://api.github.com/users/rmars","html_url":"https://github.com/rmars","followers_url":"https://api.github.com/users/rmars/followers","following_url":"https://api.github.com/users/rmars/following{/other_user}","gists_url":"https://api.github.com/users/rmars/gists{/gist_id}","starred_url":"https://api.github.com/users/rmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmars/subscriptions","organizations_url":"https://api.github.com/users/rmars/orgs","repos_url":"https://api.github.com/users/rmars/repos","events_url":"https://api.github.com/users/rmars/events{/privacy}","received_events_url":"https://api.github.com/users/rmars/received_events","type":"User","site_admin":false},"body":"Fixes #411\r\n\r\nI had to do some smoothie chart hacks to get the gray line to not be drawn over the client's coloured line - advice on that appreciated.\r\n\r\nSome screenshots, with random data:\r\n![screen shot 2016-05-23 at 5 54 09 pm](https://cloud.githubusercontent.com/assets/549258/15488847/67001bd8-210f-11e6-9c47-101c27968665.png)\r\n\r\n![screen shot 2016-05-23 at 5 02 53 pm](https://cloud.githubusercontent.com/assets/549258/15488855/721ad544-210f-11e6-9f9c-70eb98420915.png)\r\n\r\n![screen shot 2016-05-23 at 5 01 47 pm](https://cloud.githubusercontent.com/assets/549258/15488849/6c15690c-210f-11e6-989b-abb46aa94d47.png)","created_at":"2016-05-24T00:56:12Z","updated_at":"2016-05-24T18:02:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d605ee51626e93833433b08322e4d5c9708b7a1d","assignee":{"login":"rmars","id":549258,"avatar_url":"https://avatars.githubusercontent.com/u/549258?v=3","gravatar_id":"","url":"https://api.github.com/users/rmars","html_url":"https://github.com/rmars","followers_url":"https://api.github.com/users/rmars/followers","following_url":"https://api.github.com/users/rmars/following{/other_user}","gists_url":"https://api.github.com/users/rmars/gists{/gist_id}","starred_url":"https://api.github.com/users/rmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmars/subscriptions","organizations_url":"https://api.github.com/users/rmars/orgs","repos_url":"https://api.github.com/users/rmars/repos","events_url":"https://api.github.com/users/rmars/events{/privacy}","received_events_url":"https://api.github.com/users/rmars/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/441/commits","review_comments_url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/441/comments","review_comment_url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/441/comments","statuses_url":"https://api.github.com/repos/BuoyantIO/linkerd/statuses/2a7aaefe423c94b4c83961d122876ece173e7799","head":{"label":"BuoyantIO:rmars/dashboard-client-tweaks","ref":"rmars/dashboard-client-tweaks","sha":"2a7aaefe423c94b4c83961d122876ece173e7799","user":{"login":"BuoyantIO","id":10824329,"avatar_url":"https://avatars.githubusercontent.com/u/10824329?v=3","gravatar_id":"","url":"https://api.github.com/users/BuoyantIO","html_url":"https://github.com/BuoyantIO","followers_url":"https://api.github.com/users/BuoyantIO/followers","following_url":"https://api.github.com/users/BuoyantIO/following{/other_user}","gists_url":"https://api.github.com/users/BuoyantIO/gists{/gist_id}","starred_url":"https://api.github.com/users/BuoyantIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuoyantIO/subscriptions","organizations_url":"https://api.github.com/users/BuoyantIO/orgs","repos_url":"https://api.github.com/users/BuoyantIO/repos","events_url":"https://api.github.com/users/BuoyantIO/events{/privacy}","received_events_url":"https://api.github.com/users/BuoyantIO/received_events","type":"Organization","site_admin":false},"repo":{"id":49605596,"name":"linkerd","full_name":"BuoyantIO/linkerd","owner":{"login":"BuoyantIO","id":10824329,"avatar_url":"https://avatars.githubusercontent.com/u/10824329?v=3","gravatar_id":"","url":"https://api.github.com/users/BuoyantIO","html_url":"https://github.com/BuoyantIO","followers_url":"https://api.github.com/users/BuoyantIO/followers","following_url":"https://api.github.com/users/BuoyantIO/following{/other_user}","gists_url":"https://api.github.com/users/BuoyantIO/gists{/gist_id}","starred_url":"https://api.github.com/users/BuoyantIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuoyantIO/subscriptions","organizations_url":"https://api.github.com/users/BuoyantIO/orgs","repos_url":"https://api.github.com/users/BuoyantIO/repos","events_url":"https://api.github.com/users/BuoyantIO/events{/privacy}","received_events_url":"https://api.github.com/users/BuoyantIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BuoyantIO/linkerd","description":"A dynamic linker for microservices.","fork":false,"url":"https://api.github.com/repos/BuoyantIO/linkerd","forks_url":"https://api.github.com/repos/BuoyantIO/linkerd/forks","keys_url":"https://api.github.com/repos/BuoyantIO/linkerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BuoyantIO/linkerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BuoyantIO/linkerd/teams","hooks_url":"https://api.github.com/repos/BuoyantIO/linkerd/hooks","issue_events_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/events{/number}","events_url":"https://api.github.com/repos/BuoyantIO/linkerd/events","assignees_url":"https://api.github.com/repos/BuoyantIO/linkerd/assignees{/user}","branches_url":"https://api.github.com/repos/BuoyantIO/linkerd/branches{/branch}","tags_url":"https://api.github.com/repos/BuoyantIO/linkerd/tags","blobs_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BuoyantIO/linkerd/statuses/{sha}","languages_url":"https://api.github.com/repos/BuoyantIO/linkerd/languages","stargazers_url":"https://api.github.com/repos/BuoyantIO/linkerd/stargazers","contributors_url":"https://api.github.com/repos/BuoyantIO/linkerd/contributors","subscribers_url":"https://api.github.com/repos/BuoyantIO/linkerd/subscribers","subscription_url":"https://api.github.com/repos/BuoyantIO/linkerd/subscription","commits_url":"https://api.github.com/repos/BuoyantIO/linkerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/BuoyantIO/linkerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/BuoyantIO/linkerd/contents/{+path}","compare_url":"https://api.github.com/repos/BuoyantIO/linkerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BuoyantIO/linkerd/merges","archive_url":"https://api.github.com/repos/BuoyantIO/linkerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BuoyantIO/linkerd/downloads","issues_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues{/number}","pulls_url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls{/number}","milestones_url":"https://api.github.com/repos/BuoyantIO/linkerd/milestones{/number}","notifications_url":"https://api.github.com/repos/BuoyantIO/linkerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BuoyantIO/linkerd/labels{/name}","releases_url":"https://api.github.com/repos/BuoyantIO/linkerd/releases{/id}","deployments_url":"https://api.github.com/repos/BuoyantIO/linkerd/deployments","created_at":"2016-01-13T22:14:52Z","updated_at":"2016-05-24T02:13:30Z","pushed_at":"2016-05-24T18:01:48Z","git_url":"git://github.com/BuoyantIO/linkerd.git","ssh_url":"git@github.com:BuoyantIO/linkerd.git","clone_url":"https://github.com/BuoyantIO/linkerd.git","svn_url":"https://github.com/BuoyantIO/linkerd","homepage":"https://linkerd.io","size":1825,"stargazers_count":758,"watchers_count":758,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":61,"forks":43,"open_issues":61,"watchers":758,"default_branch":"master"}},"base":{"label":"BuoyantIO:master","ref":"master","sha":"065d2829efba15d09d131b983b06c493d2d9b04b","user":{"login":"BuoyantIO","id":10824329,"avatar_url":"https://avatars.githubusercontent.com/u/10824329?v=3","gravatar_id":"","url":"https://api.github.com/users/BuoyantIO","html_url":"https://github.com/BuoyantIO","followers_url":"https://api.github.com/users/BuoyantIO/followers","following_url":"https://api.github.com/users/BuoyantIO/following{/other_user}","gists_url":"https://api.github.com/users/BuoyantIO/gists{/gist_id}","starred_url":"https://api.github.com/users/BuoyantIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuoyantIO/subscriptions","organizations_url":"https://api.github.com/users/BuoyantIO/orgs","repos_url":"https://api.github.com/users/BuoyantIO/repos","events_url":"https://api.github.com/users/BuoyantIO/events{/privacy}","received_events_url":"https://api.github.com/users/BuoyantIO/received_events","type":"Organization","site_admin":false},"repo":{"id":49605596,"name":"linkerd","full_name":"BuoyantIO/linkerd","owner":{"login":"BuoyantIO","id":10824329,"avatar_url":"https://avatars.githubusercontent.com/u/10824329?v=3","gravatar_id":"","url":"https://api.github.com/users/BuoyantIO","html_url":"https://github.com/BuoyantIO","followers_url":"https://api.github.com/users/BuoyantIO/followers","following_url":"https://api.github.com/users/BuoyantIO/following{/other_user}","gists_url":"https://api.github.com/users/BuoyantIO/gists{/gist_id}","starred_url":"https://api.github.com/users/BuoyantIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuoyantIO/subscriptions","organizations_url":"https://api.github.com/users/BuoyantIO/orgs","repos_url":"https://api.github.com/users/BuoyantIO/repos","events_url":"https://api.github.com/users/BuoyantIO/events{/privacy}","received_events_url":"https://api.github.com/users/BuoyantIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BuoyantIO/linkerd","description":"A dynamic linker for microservices.","fork":false,"url":"https://api.github.com/repos/BuoyantIO/linkerd","forks_url":"https://api.github.com/repos/BuoyantIO/linkerd/forks","keys_url":"https://api.github.com/repos/BuoyantIO/linkerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BuoyantIO/linkerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BuoyantIO/linkerd/teams","hooks_url":"https://api.github.com/repos/BuoyantIO/linkerd/hooks","issue_events_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/events{/number}","events_url":"https://api.github.com/repos/BuoyantIO/linkerd/events","assignees_url":"https://api.github.com/repos/BuoyantIO/linkerd/assignees{/user}","branches_url":"https://api.github.com/repos/BuoyantIO/linkerd/branches{/branch}","tags_url":"https://api.github.com/repos/BuoyantIO/linkerd/tags","blobs_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BuoyantIO/linkerd/statuses/{sha}","languages_url":"https://api.github.com/repos/BuoyantIO/linkerd/languages","stargazers_url":"https://api.github.com/repos/BuoyantIO/linkerd/stargazers","contributors_url":"https://api.github.com/repos/BuoyantIO/linkerd/contributors","subscribers_url":"https://api.github.com/repos/BuoyantIO/linkerd/subscribers","subscription_url":"https://api.github.com/repos/BuoyantIO/linkerd/subscription","commits_url":"https://api.github.com/repos/BuoyantIO/linkerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/BuoyantIO/linkerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/BuoyantIO/linkerd/contents/{+path}","compare_url":"https://api.github.com/repos/BuoyantIO/linkerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BuoyantIO/linkerd/merges","archive_url":"https://api.github.com/repos/BuoyantIO/linkerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BuoyantIO/linkerd/downloads","issues_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues{/number}","pulls_url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls{/number}","milestones_url":"https://api.github.com/repos/BuoyantIO/linkerd/milestones{/number}","notifications_url":"https://api.github.com/repos/BuoyantIO/linkerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BuoyantIO/linkerd/labels{/name}","releases_url":"https://api.github.com/repos/BuoyantIO/linkerd/releases{/id}","deployments_url":"https://api.github.com/repos/BuoyantIO/linkerd/deployments","created_at":"2016-01-13T22:14:52Z","updated_at":"2016-05-24T02:13:30Z","pushed_at":"2016-05-24T18:01:48Z","git_url":"git://github.com/BuoyantIO/linkerd.git","ssh_url":"git@github.com:BuoyantIO/linkerd.git","clone_url":"https://github.com/BuoyantIO/linkerd.git","svn_url":"https://github.com/BuoyantIO/linkerd","homepage":"https://linkerd.io","size":1825,"stargazers_count":758,"watchers_count":758,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":61,"forks":43,"open_issues":61,"watchers":758,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/441"},"html":{"href":"https://github.com/BuoyantIO/linkerd/pull/441"},"issue":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/issues/441"},"comments":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/issues/441/comments"},"review_comments":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/441/comments"},"review_comment":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/441/commits"},"statuses":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/statuses/2a7aaefe423c94b4c83961d122876ece173e7799"}}}}
{"actor":{"display_login":"esbie"}}