{"action":"created","issue":{"url":"https://api.github.com/repos/nodogsplash/nodogsplash/issues/132","repository_url":"https://api.github.com/repos/nodogsplash/nodogsplash","labels_url":"https://api.github.com/repos/nodogsplash/nodogsplash/issues/132/labels{/name}","comments_url":"https://api.github.com/repos/nodogsplash/nodogsplash/issues/132/comments","events_url":"https://api.github.com/repos/nodogsplash/nodogsplash/issues/132/events","html_url":"https://github.com/nodogsplash/nodogsplash/pull/132","id":169084395,"number":132,"title":"deauthenticate preauth clients","user":{"login":"ansanto","id":3795747,"avatar_url":"https://avatars.githubusercontent.com/u/3795747?v=3","gravatar_id":"","url":"https://api.github.com/users/ansanto","html_url":"https://github.com/ansanto","followers_url":"https://api.github.com/users/ansanto/followers","following_url":"https://api.github.com/users/ansanto/following{/other_user}","gists_url":"https://api.github.com/users/ansanto/gists{/gist_id}","starred_url":"https://api.github.com/users/ansanto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansanto/subscriptions","organizations_url":"https://api.github.com/users/ansanto/orgs","repos_url":"https://api.github.com/users/ansanto/repos","events_url":"https://api.github.com/users/ansanto/events{/privacy}","received_events_url":"https://api.github.com/users/ansanto/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-03T09:14:08Z","updated_at":"2016-08-04T18:41:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodogsplash/nodogsplash/pulls/132","html_url":"https://github.com/nodogsplash/nodogsplash/pull/132","diff_url":"https://github.com/nodogsplash/nodogsplash/pull/132.diff","patch_url":"https://github.com/nodogsplash/nodogsplash/pull/132.patch"},"body":"@01010000101001100\r\ndoes compile in v 1.0.0\r\n\r\n--- a/src/firewall.c    2016-08-03 10:33:21.513311228 +0200\r\n+++ b/src/firewall.c    2016-08-03 10:47:28.424565842 +0200\r\n@@ -173,7 +173,7 @@\r\n                debug(LOG_NOTICE, \"%s %s inactive %d secs. kB in: %llu  kB out: %llu\",\r\n                      cp1->ip, cp1->mac, config->checkinterval * config->clienttimeout,\r\n                      cp1->counters.incoming/1000, cp1->counters.outgoing/1000);\r\n-               if(cp1->fw_connection_state == FW_MARK_AUTHENTICATED) {\r\n+               if(cp1->fw_connection_state == FW_MARK_AUTHENTICATED || cp1->fw_connection_state == FW_MARK_PREAUTHENTICATED) {\r\n                    iptables_fw_access(AUTH_MAKE_DEAUTHENTICATED, cp1);\r\n                }\r\n                client_list_delete(cp1);\r\n@@ -182,7 +182,7 @@\r\n                debug(LOG_NOTICE, \"%s %s connected %d secs. kB in: %llu kB out: %llu\",\r\n                      cp1->ip, cp1->mac, config->checkinterval * config->clientforceout,\r\n                      cp1->counters.incoming/1000, cp1->counters.outgoing/1000);\r\n-               if(cp1->fw_connection_state == FW_MARK_AUTHENTICATED) {\r\n+               if(cp1->fw_connection_state == FW_MARK_AUTHENTICATED || cp1->fw_connection_state == FW_MARK_PREAUTHENTICATED) {\r\n                    iptables_fw_access(AUTH_MAKE_DEAUTHENTICATED, cp1);\r\n                }\r\n                client_list_delete(cp1);\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/nodogsplash/nodogsplash/issues/comments/237644957","html_url":"https://github.com/nodogsplash/nodogsplash/pull/132#issuecomment-237644957","issue_url":"https://api.github.com/repos/nodogsplash/nodogsplash/issues/132","id":237644957,"user":{"login":"mwarning","id":546193,"avatar_url":"https://avatars.githubusercontent.com/u/546193?v=3","gravatar_id":"","url":"https://api.github.com/users/mwarning","html_url":"https://github.com/mwarning","followers_url":"https://api.github.com/users/mwarning/followers","following_url":"https://api.github.com/users/mwarning/following{/other_user}","gists_url":"https://api.github.com/users/mwarning/gists{/gist_id}","starred_url":"https://api.github.com/users/mwarning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwarning/subscriptions","organizations_url":"https://api.github.com/users/mwarning/orgs","repos_url":"https://api.github.com/users/mwarning/repos","events_url":"https://api.github.com/users/mwarning/events{/privacy}","received_events_url":"https://api.github.com/users/mwarning/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T18:41:34Z","updated_at":"2016-08-04T18:41:34Z","body":"@ansanto this is not a proper merge request.\r\nYou have to fork nodogsplash via the fork button, apply your changes to the fork and then click the \"Create Merge Request\" button.\r\nThis merge request contains some of my own commits and a patch files content as comment. I can read it, but still..."}}
{"actor":{"display_login":"mwarning"}}