{"action":"created","comment":{"url":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/comments/72532435","id":72532435,"diff_hunk":"@@ -781,7 +782,27 @@ function popupHidden()\n end\n playerDropDown.HiddenSignal:connect(popupHidden)\n \n+local function openPlatformProfileUI(rbxUid)\n+\tif not rbxUid or rbxUid < 1 then return end\n+\tpcall(function()\n+\t\tlocal platformService = game:GetService('PlatformService')\n+\t\tif platformService then\n+\t\t\tlocal platformId = platformService:GetPlatformId(rbxUid)\n+\t\t\tif platformId and #platformId > 0 then\n+\t\t\t\tplatformService:PopupProfileUI(Enum.UserInputType.Gamepad1, platformId)\n+\t\t\tend\n+\t\tend\n+\tend)\n+end\n+\n local function onEntryFrameSelected(selectedFrame, selectedPlayer)\n+\tif isTenFootInterface then","path":"CoreScriptsRoot/Modules/PlayerlistModule.lua","position":26,"original_position":26,"commit_id":"a57529831cde45b71d028a89b1e43fe9b8ae1e58","original_commit_id":"a57529831cde45b71d028a89b1e43fe9b8ae1e58","user":{"login":"SolarCrane","id":6992752,"avatar_url":"https://avatars.githubusercontent.com/u/6992752?v=3","gravatar_id":"","url":"https://api.github.com/users/SolarCrane","html_url":"https://github.com/SolarCrane","followers_url":"https://api.github.com/users/SolarCrane/followers","following_url":"https://api.github.com/users/SolarCrane/following{/other_user}","gists_url":"https://api.github.com/users/SolarCrane/gists{/gist_id}","starred_url":"https://api.github.com/users/SolarCrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SolarCrane/subscriptions","organizations_url":"https://api.github.com/users/SolarCrane/orgs","repos_url":"https://api.github.com/users/SolarCrane/repos","events_url":"https://api.github.com/users/SolarCrane/events{/privacy}","received_events_url":"https://api.github.com/users/SolarCrane/received_events","type":"User","site_admin":false},"body":"It seems a bit odd here to check if isTenfootInterface is true and then later check PlatformService for the PlatformId. Is it possible to unify the two checks into checking the exact same thing?","created_at":"2016-07-27T22:00:54Z","updated_at":"2016-07-27T22:00:54Z","html_url":"https://github.com/ROBLOX/Core-Scripts/pull/470#discussion_r72532435","pull_request_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/470","_links":{"self":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/comments/72532435"},"html":{"href":"https://github.com/ROBLOX/Core-Scripts/pull/470#discussion_r72532435"},"pull_request":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/470"}}},"pull_request":{"url":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/470","id":79078738,"html_url":"https://github.com/ROBLOX/Core-Scripts/pull/470","diff_url":"https://github.com/ROBLOX/Core-Scripts/pull/470.diff","patch_url":"https://github.com/ROBLOX/Core-Scripts/pull/470.patch","issue_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/issues/470","number":470,"state":"open","locked":false,"title":"CLIXBOX-842 - Allow users to open gamer cards from player list on Xbox","user":{"login":"jmargh","id":8647162,"avatar_url":"https://avatars.githubusercontent.com/u/8647162?v=3","gravatar_id":"","url":"https://api.github.com/users/jmargh","html_url":"https://github.com/jmargh","followers_url":"https://api.github.com/users/jmargh/followers","following_url":"https://api.github.com/users/jmargh/following{/other_user}","gists_url":"https://api.github.com/users/jmargh/gists{/gist_id}","starred_url":"https://api.github.com/users/jmargh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmargh/subscriptions","organizations_url":"https://api.github.com/users/jmargh/orgs","repos_url":"https://api.github.com/users/jmargh/repos","events_url":"https://api.github.com/users/jmargh/events{/privacy}","received_events_url":"https://api.github.com/users/jmargh/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-27T19:00:17Z","updated_at":"2016-07-27T22:00:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d61458e3afce62b4008f16f907e0e413744c0a23","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/470/commits","review_comments_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/470/comments","review_comment_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/issues/470/comments","statuses_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/statuses/a57529831cde45b71d028a89b1e43fe9b8ae1e58","head":{"label":"jmargh:profileUI","ref":"profileUI","sha":"a57529831cde45b71d028a89b1e43fe9b8ae1e58","user":{"login":"jmargh","id":8647162,"avatar_url":"https://avatars.githubusercontent.com/u/8647162?v=3","gravatar_id":"","url":"https://api.github.com/users/jmargh","html_url":"https://github.com/jmargh","followers_url":"https://api.github.com/users/jmargh/followers","following_url":"https://api.github.com/users/jmargh/following{/other_user}","gists_url":"https://api.github.com/users/jmargh/gists{/gist_id}","starred_url":"https://api.github.com/users/jmargh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmargh/subscriptions","organizations_url":"https://api.github.com/users/jmargh/orgs","repos_url":"https://api.github.com/users/jmargh/repos","events_url":"https://api.github.com/users/jmargh/events{/privacy}","received_events_url":"https://api.github.com/users/jmargh/received_events","type":"User","site_admin":false},"repo":{"id":47432331,"name":"Core-Scripts","full_name":"jmargh/Core-Scripts","owner":{"login":"jmargh","id":8647162,"avatar_url":"https://avatars.githubusercontent.com/u/8647162?v=3","gravatar_id":"","url":"https://api.github.com/users/jmargh","html_url":"https://github.com/jmargh","followers_url":"https://api.github.com/users/jmargh/followers","following_url":"https://api.github.com/users/jmargh/following{/other_user}","gists_url":"https://api.github.com/users/jmargh/gists{/gist_id}","starred_url":"https://api.github.com/users/jmargh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmargh/subscriptions","organizations_url":"https://api.github.com/users/jmargh/orgs","repos_url":"https://api.github.com/users/jmargh/repos","events_url":"https://api.github.com/users/jmargh/events{/privacy}","received_events_url":"https://api.github.com/users/jmargh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmargh/Core-Scripts","description":"All of ROBLOX's core client scripts.","fork":true,"url":"https://api.github.com/repos/jmargh/Core-Scripts","forks_url":"https://api.github.com/repos/jmargh/Core-Scripts/forks","keys_url":"https://api.github.com/repos/jmargh/Core-Scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmargh/Core-Scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmargh/Core-Scripts/teams","hooks_url":"https://api.github.com/repos/jmargh/Core-Scripts/hooks","issue_events_url":"https://api.github.com/repos/jmargh/Core-Scripts/issues/events{/number}","events_url":"https://api.github.com/repos/jmargh/Core-Scripts/events","assignees_url":"https://api.github.com/repos/jmargh/Core-Scripts/assignees{/user}","branches_url":"https://api.github.com/repos/jmargh/Core-Scripts/branches{/branch}","tags_url":"https://api.github.com/repos/jmargh/Core-Scripts/tags","blobs_url":"https://api.github.com/repos/jmargh/Core-Scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmargh/Core-Scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmargh/Core-Scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmargh/Core-Scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmargh/Core-Scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/jmargh/Core-Scripts/languages","stargazers_url":"https://api.github.com/repos/jmargh/Core-Scripts/stargazers","contributors_url":"https://api.github.com/repos/jmargh/Core-Scripts/contributors","subscribers_url":"https://api.github.com/repos/jmargh/Core-Scripts/subscribers","subscription_url":"https://api.github.com/repos/jmargh/Core-Scripts/subscription","commits_url":"https://api.github.com/repos/jmargh/Core-Scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmargh/Core-Scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmargh/Core-Scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmargh/Core-Scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmargh/Core-Scripts/contents/{+path}","compare_url":"https://api.github.com/repos/jmargh/Core-Scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmargh/Core-Scripts/merges","archive_url":"https://api.github.com/repos/jmargh/Core-Scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmargh/Core-Scripts/downloads","issues_url":"https://api.github.com/repos/jmargh/Core-Scripts/issues{/number}","pulls_url":"https://api.github.com/repos/jmargh/Core-Scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/jmargh/Core-Scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/jmargh/Core-Scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmargh/Core-Scripts/labels{/name}","releases_url":"https://api.github.com/repos/jmargh/Core-Scripts/releases{/id}","deployments_url":"https://api.github.com/repos/jmargh/Core-Scripts/deployments","created_at":"2015-12-04T22:38:01Z","updated_at":"2016-01-15T02:36:48Z","pushed_at":"2016-07-27T18:59:15Z","git_url":"git://github.com/jmargh/Core-Scripts.git","ssh_url":"git@github.com:jmargh/Core-Scripts.git","clone_url":"https://github.com/jmargh/Core-Scripts.git","svn_url":"https://github.com/jmargh/Core-Scripts","homepage":"","size":2954,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ROBLOX:master","ref":"master","sha":"9c038cedf2e86b1a776323d909ba5cc42c051ac9","user":{"login":"ROBLOX","id":4195619,"avatar_url":"https://avatars.githubusercontent.com/u/4195619?v=3","gravatar_id":"","url":"https://api.github.com/users/ROBLOX","html_url":"https://github.com/ROBLOX","followers_url":"https://api.github.com/users/ROBLOX/followers","following_url":"https://api.github.com/users/ROBLOX/following{/other_user}","gists_url":"https://api.github.com/users/ROBLOX/gists{/gist_id}","starred_url":"https://api.github.com/users/ROBLOX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROBLOX/subscriptions","organizations_url":"https://api.github.com/users/ROBLOX/orgs","repos_url":"https://api.github.com/users/ROBLOX/repos","events_url":"https://api.github.com/users/ROBLOX/events{/privacy}","received_events_url":"https://api.github.com/users/ROBLOX/received_events","type":"Organization","site_admin":false},"repo":{"id":19040095,"name":"Core-Scripts","full_name":"ROBLOX/Core-Scripts","owner":{"login":"ROBLOX","id":4195619,"avatar_url":"https://avatars.githubusercontent.com/u/4195619?v=3","gravatar_id":"","url":"https://api.github.com/users/ROBLOX","html_url":"https://github.com/ROBLOX","followers_url":"https://api.github.com/users/ROBLOX/followers","following_url":"https://api.github.com/users/ROBLOX/following{/other_user}","gists_url":"https://api.github.com/users/ROBLOX/gists{/gist_id}","starred_url":"https://api.github.com/users/ROBLOX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROBLOX/subscriptions","organizations_url":"https://api.github.com/users/ROBLOX/orgs","repos_url":"https://api.github.com/users/ROBLOX/repos","events_url":"https://api.github.com/users/ROBLOX/events{/privacy}","received_events_url":"https://api.github.com/users/ROBLOX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ROBLOX/Core-Scripts","description":"All of ROBLOX's core client scripts.","fork":false,"url":"https://api.github.com/repos/ROBLOX/Core-Scripts","forks_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/forks","keys_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/teams","hooks_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/hooks","issue_events_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/issues/events{/number}","events_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/events","assignees_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/assignees{/user}","branches_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/branches{/branch}","tags_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/tags","blobs_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/languages","stargazers_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/stargazers","contributors_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/contributors","subscribers_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/subscribers","subscription_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/subscription","commits_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/contents/{+path}","compare_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/merges","archive_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/downloads","issues_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/issues{/number}","pulls_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/labels{/name}","releases_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/releases{/id}","deployments_url":"https://api.github.com/repos/ROBLOX/Core-Scripts/deployments","created_at":"2014-04-22T18:02:17Z","updated_at":"2016-07-04T19:53:01Z","pushed_at":"2016-07-27T19:00:18Z","git_url":"git://github.com/ROBLOX/Core-Scripts.git","ssh_url":"git@github.com:ROBLOX/Core-Scripts.git","clone_url":"https://github.com/ROBLOX/Core-Scripts.git","svn_url":"https://github.com/ROBLOX/Core-Scripts","homepage":"","size":4033,"stargazers_count":53,"watchers_count":53,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"open_issues_count":28,"forks":87,"open_issues":28,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/470"},"html":{"href":"https://github.com/ROBLOX/Core-Scripts/pull/470"},"issue":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/issues/470"},"comments":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/issues/470/comments"},"review_comments":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/470/comments"},"review_comment":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/pulls/470/commits"},"statuses":{"href":"https://api.github.com/repos/ROBLOX/Core-Scripts/statuses/a57529831cde45b71d028a89b1e43fe9b8ae1e58"}}}}
{"actor":{"display_login":"SolarCrane"}}