{"action":"created","issue":{"url":"https://api.github.com/repos/DSpace-Labs/angular2-ui-prototype/issues/36","repository_url":"https://api.github.com/repos/DSpace-Labs/angular2-ui-prototype","labels_url":"https://api.github.com/repos/DSpace-Labs/angular2-ui-prototype/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/DSpace-Labs/angular2-ui-prototype/issues/36/comments","events_url":"https://api.github.com/repos/DSpace-Labs/angular2-ui-prototype/issues/36/events","html_url":"https://github.com/DSpace-Labs/angular2-ui-prototype/pull/36","id":146337296,"number":36,"title":"Dependency cleanup / add WebPack comments","user":{"login":"tdonohue","id":483997,"avatar_url":"https://avatars.githubusercontent.com/u/483997?v=3","gravatar_id":"","url":"https://api.github.com/users/tdonohue","html_url":"https://github.com/tdonohue","followers_url":"https://api.github.com/users/tdonohue/followers","following_url":"https://api.github.com/users/tdonohue/following{/other_user}","gists_url":"https://api.github.com/users/tdonohue/gists{/gist_id}","starred_url":"https://api.github.com/users/tdonohue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdonohue/subscriptions","organizations_url":"https://api.github.com/users/tdonohue/orgs","repos_url":"https://api.github.com/users/tdonohue/repos","events_url":"https://api.github.com/users/tdonohue/events{/privacy}","received_events_url":"https://api.github.com/users/tdonohue/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/DSpace-Labs/angular2-ui-prototype/labels/code%20task","name":"code task","color":"d4c5f9"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-04-06T14:45:17Z","updated_at":"2016-04-07T02:39:18Z","closed_at":"2016-04-06T15:32:25Z","pull_request":{"url":"https://api.github.com/repos/DSpace-Labs/angular2-ui-prototype/pulls/36","html_url":"https://github.com/DSpace-Labs/angular2-ui-prototype/pull/36","diff_url":"https://github.com/DSpace-Labs/angular2-ui-prototype/pull/36.diff","patch_url":"https://github.com/DSpace-Labs/angular2-ui-prototype/pull/36.patch"},"body":"This PR performs some dependency cleanup based on my analysis of what dependencies we are actually using (and why). That analysis is in this wiki page:\r\nhttps://github.com/DSpace-Labs/angular2-ui-prototype/wiki/Project-Dependencies\r\n\r\n* As part of this analysis, I discovered several dependencies which are no longer used: `bootstrap-sass-loader` (replaced by `bootstrap-loader`), `file-loader`, `resolve-url-loader`, `ssl-root-cas`, `webpack-dev-server`, `ws`\r\n* I also fixed warnings about not including: `angular2-express-engine` and `angular2-universal-polyfills` (both are now required by Angular Universal).\r\n* Finally, I enhanced our `webpack.config.js` with some basic comments (which I think accurately describe how it works, but might need review).  This was helpful (to me) in understanding how it works and what dependencies (namely \"loaders\") it actually is using.\r\n\r\nThis PR is ready for review.  I've tested the install, build and watch scripts and everything still seems to work fine with these changes."},"comment":{"url":"https://api.github.com/repos/DSpace-Labs/angular2-ui-prototype/issues/comments/206663788","html_url":"https://github.com/DSpace-Labs/angular2-ui-prototype/pull/36#issuecomment-206663788","issue_url":"https://api.github.com/repos/DSpace-Labs/angular2-ui-prototype/issues/36","id":206663788,"user":{"login":"wellingWilliam","id":16831046,"avatar_url":"https://avatars.githubusercontent.com/u/16831046?v=3","gravatar_id":"","url":"https://api.github.com/users/wellingWilliam","html_url":"https://github.com/wellingWilliam","followers_url":"https://api.github.com/users/wellingWilliam/followers","following_url":"https://api.github.com/users/wellingWilliam/following{/other_user}","gists_url":"https://api.github.com/users/wellingWilliam/gists{/gist_id}","starred_url":"https://api.github.com/users/wellingWilliam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellingWilliam/subscriptions","organizations_url":"https://api.github.com/users/wellingWilliam/orgs","repos_url":"https://api.github.com/users/wellingWilliam/repos","events_url":"https://api.github.com/users/wellingWilliam/events{/privacy}","received_events_url":"https://api.github.com/users/wellingWilliam/received_events","type":"User","site_admin":false},"created_at":"2016-04-07T02:39:18Z","updated_at":"2016-04-07T02:39:18Z","body":"The `cloneNode of null `error is what I mention previously about the preboot dependency.\r\n\r\npreboot_browser.ts\r\nline 123: \r\n`dom.state.body ? load() : dom.onLoad(load);\r\n`should be\r\n`Object.keys(dom.state.body).length > 0 ? load() : dom.onLoad(load);\r\n`\r\nThe `EXCEPTION: UnsubscriptionError `was introduced with a recent upgrade of a dependency. I think preboot actually."}}