{"action":"created","issue":{"url":"https://api.github.com/repos/TechnologyAdvice/stardust/issues/452","repository_url":"https://api.github.com/repos/TechnologyAdvice/stardust","labels_url":"https://api.github.com/repos/TechnologyAdvice/stardust/issues/452/labels{/name}","comments_url":"https://api.github.com/repos/TechnologyAdvice/stardust/issues/452/comments","events_url":"https://api.github.com/repos/TechnologyAdvice/stardust/issues/452/events","html_url":"https://github.com/TechnologyAdvice/stardust/pull/452","id":173871789,"number":452,"title":"perf(shorthand): standardize childKey and shorthand props","user":{"login":"levithomason","id":5067638,"avatar_url":"https://avatars.githubusercontent.com/u/5067638?v=3","gravatar_id":"","url":"https://api.github.com/users/levithomason","html_url":"https://github.com/levithomason","followers_url":"https://api.github.com/users/levithomason/followers","following_url":"https://api.github.com/users/levithomason/following{/other_user}","gists_url":"https://api.github.com/users/levithomason/gists{/gist_id}","starred_url":"https://api.github.com/users/levithomason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levithomason/subscriptions","organizations_url":"https://api.github.com/users/levithomason/orgs","repos_url":"https://api.github.com/users/levithomason/repos","events_url":"https://api.github.com/users/levithomason/events{/privacy}","received_events_url":"https://api.github.com/users/levithomason/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-08-29T21:02:00Z","updated_at":"2016-09-24T10:13:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TechnologyAdvice/stardust/pulls/452","html_url":"https://github.com/TechnologyAdvice/stardust/pull/452","diff_url":"https://github.com/TechnologyAdvice/stardust/pull/452.diff","patch_url":"https://github.com/TechnologyAdvice/stardust/pull/452.patch"},"body":"# WIP\r\n\r\nFixes #391 \r\nFixes #449 \r\n\r\nThis PR standardizes `childKey` and shorthand props.  It also adds `commonTests` and `customPropTypes` for these.  In doing so, it also defines a custom prop type for the `as` prop.\r\n\r\nImplementing these also means we need to implement the standardized content prop names and patterns for shorthand props.  This will also be done here.\r\n\r\n### New `customPropTypes`\r\n\r\n- as\r\n- childKey\r\n- icon\r\n- image\r\n- shorthand\r\n\r\n### New `commonTests`\r\n\r\n- implementsShorthandProp"},"comment":{"url":"https://api.github.com/repos/TechnologyAdvice/stardust/issues/comments/249357236","html_url":"https://github.com/TechnologyAdvice/stardust/pull/452#issuecomment-249357236","issue_url":"https://api.github.com/repos/TechnologyAdvice/stardust/issues/452","id":249357236,"user":{"login":"layershifter","id":14183168,"avatar_url":"https://avatars.githubusercontent.com/u/14183168?v=3","gravatar_id":"","url":"https://api.github.com/users/layershifter","html_url":"https://github.com/layershifter","followers_url":"https://api.github.com/users/layershifter/followers","following_url":"https://api.github.com/users/layershifter/following{/other_user}","gists_url":"https://api.github.com/users/layershifter/gists{/gist_id}","starred_url":"https://api.github.com/users/layershifter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/layershifter/subscriptions","organizations_url":"https://api.github.com/users/layershifter/orgs","repos_url":"https://api.github.com/users/layershifter/repos","events_url":"https://api.github.com/users/layershifter/events{/privacy}","received_events_url":"https://api.github.com/users/layershifter/received_events","type":"User","site_admin":false},"created_at":"2016-09-24T10:13:44Z","updated_at":"2016-09-24T10:13:44Z","body":"Just stupid note about future `customPropTypes.shorthand`, it cannot be simple `PropTypes.node` because it includes `PropTypes.array`."}}
{"actor":{"display_login":"layershifter"}}