{"action":"created","comment":{"url":"https://api.github.com/repos/RichardWarburton/honest-profiler/pulls/comments/75369246","id":75369246,"diff_hunk":"@@ -88,7 +88,8 @@ void JNICALL OnVMDeath(jvmtiEnv *jvmti_env, JNIEnv *jni_env) {\n     IMPLICITLY_USE(jvmti_env);\n     IMPLICITLY_USE(jni_env);\n \n-    prof->stop();\n+    if (prof->isRunning())","path":"src/main/cpp/agent.cpp","position":5,"original_position":5,"commit_id":"d18d69450dece3aeff9544204d5af3c215f92067","original_commit_id":"d18d69450dece3aeff9544204d5af3c215f92067","user":{"login":"RichardWarburton","id":328174,"avatar_url":"https://avatars.githubusercontent.com/u/328174?v=3","gravatar_id":"","url":"https://api.github.com/users/RichardWarburton","html_url":"https://github.com/RichardWarburton","followers_url":"https://api.github.com/users/RichardWarburton/followers","following_url":"https://api.github.com/users/RichardWarburton/following{/other_user}","gists_url":"https://api.github.com/users/RichardWarburton/gists{/gist_id}","starred_url":"https://api.github.com/users/RichardWarburton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichardWarburton/subscriptions","organizations_url":"https://api.github.com/users/RichardWarburton/orgs","repos_url":"https://api.github.com/users/RichardWarburton/repos","events_url":"https://api.github.com/users/RichardWarburton/events{/privacy}","received_events_url":"https://api.github.com/users/RichardWarburton/received_events","type":"User","site_admin":false},"body":"Does this change fix a bug?","created_at":"2016-08-18T19:04:09Z","updated_at":"2016-08-18T19:04:09Z","html_url":"https://github.com/RichardWarburton/honest-profiler/pull/154#discussion_r75369246","pull_request_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/pulls/154","_links":{"self":{"href":"https://api.github.com/repos/RichardWarburton/honest-profiler/pulls/comments/75369246"},"html":{"href":"https://github.com/RichardWarburton/honest-profiler/pull/154#discussion_r75369246"},"pull_request":{"href":"https://api.github.com/repos/RichardWarburton/honest-profiler/pulls/154"}}},"pull_request":{"url":"https://api.github.com/repos/RichardWarburton/honest-profiler/pulls/154","id":81280102,"html_url":"https://github.com/RichardWarburton/honest-profiler/pull/154","diff_url":"https://github.com/RichardWarburton/honest-profiler/pull/154.diff","patch_url":"https://github.com/RichardWarburton/honest-profiler/pull/154.patch","issue_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/issues/154","number":154,"state":"open","locked":false,"title":"Add getters and setters to agent's Profiler class","user":{"login":"ikavalio","id":5453785,"avatar_url":"https://avatars.githubusercontent.com/u/5453785?v=3","gravatar_id":"","url":"https://api.github.com/users/ikavalio","html_url":"https://github.com/ikavalio","followers_url":"https://api.github.com/users/ikavalio/followers","following_url":"https://api.github.com/users/ikavalio/following{/other_user}","gists_url":"https://api.github.com/users/ikavalio/gists{/gist_id}","starred_url":"https://api.github.com/users/ikavalio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikavalio/subscriptions","organizations_url":"https://api.github.com/users/ikavalio/orgs","repos_url":"https://api.github.com/users/ikavalio/repos","events_url":"https://api.github.com/users/ikavalio/events{/privacy}","received_events_url":"https://api.github.com/users/ikavalio/received_events","type":"User","site_admin":false},"body":"Hi Richard,\r\n\r\nThis PR adds getters and setters to Profiler class, so that profiler instance can be configured at runtime via Java (Agent interface) and TCP socket interface (get/set commands). Profiler internally validates all input and frees allocated memory when some data (strings) goes out of the scope. Only **Profiler** specific params can be changed at this moment:\r\n- sampling interval\r\n- max frames to capture\r\n- output file path\r\n\r\nI realize that it introduces a lot of changes, but it doesn't break any existing Agent functionality.","created_at":"2016-08-15T07:47:07Z","updated_at":"2016-08-18T19:04:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6cd1f9a3e0922b56d6e5c3b7206d173ef9d1fe2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/pulls/154/commits","review_comments_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/pulls/154/comments","review_comment_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/issues/154/comments","statuses_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/statuses/d18d69450dece3aeff9544204d5af3c215f92067","head":{"label":"ikavalio:master","ref":"master","sha":"d18d69450dece3aeff9544204d5af3c215f92067","user":{"login":"ikavalio","id":5453785,"avatar_url":"https://avatars.githubusercontent.com/u/5453785?v=3","gravatar_id":"","url":"https://api.github.com/users/ikavalio","html_url":"https://github.com/ikavalio","followers_url":"https://api.github.com/users/ikavalio/followers","following_url":"https://api.github.com/users/ikavalio/following{/other_user}","gists_url":"https://api.github.com/users/ikavalio/gists{/gist_id}","starred_url":"https://api.github.com/users/ikavalio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikavalio/subscriptions","organizations_url":"https://api.github.com/users/ikavalio/orgs","repos_url":"https://api.github.com/users/ikavalio/repos","events_url":"https://api.github.com/users/ikavalio/events{/privacy}","received_events_url":"https://api.github.com/users/ikavalio/received_events","type":"User","site_admin":false},"repo":{"id":64915882,"name":"honest-profiler","full_name":"ikavalio/honest-profiler","owner":{"login":"ikavalio","id":5453785,"avatar_url":"https://avatars.githubusercontent.com/u/5453785?v=3","gravatar_id":"","url":"https://api.github.com/users/ikavalio","html_url":"https://github.com/ikavalio","followers_url":"https://api.github.com/users/ikavalio/followers","following_url":"https://api.github.com/users/ikavalio/following{/other_user}","gists_url":"https://api.github.com/users/ikavalio/gists{/gist_id}","starred_url":"https://api.github.com/users/ikavalio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikavalio/subscriptions","organizations_url":"https://api.github.com/users/ikavalio/orgs","repos_url":"https://api.github.com/users/ikavalio/repos","events_url":"https://api.github.com/users/ikavalio/events{/privacy}","received_events_url":"https://api.github.com/users/ikavalio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ikavalio/honest-profiler","description":"A sampling JVM profiler without the safepoint sample bias","fork":true,"url":"https://api.github.com/repos/ikavalio/honest-profiler","forks_url":"https://api.github.com/repos/ikavalio/honest-profiler/forks","keys_url":"https://api.github.com/repos/ikavalio/honest-profiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ikavalio/honest-profiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ikavalio/honest-profiler/teams","hooks_url":"https://api.github.com/repos/ikavalio/honest-profiler/hooks","issue_events_url":"https://api.github.com/repos/ikavalio/honest-profiler/issues/events{/number}","events_url":"https://api.github.com/repos/ikavalio/honest-profiler/events","assignees_url":"https://api.github.com/repos/ikavalio/honest-profiler/assignees{/user}","branches_url":"https://api.github.com/repos/ikavalio/honest-profiler/branches{/branch}","tags_url":"https://api.github.com/repos/ikavalio/honest-profiler/tags","blobs_url":"https://api.github.com/repos/ikavalio/honest-profiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ikavalio/honest-profiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ikavalio/honest-profiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/ikavalio/honest-profiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ikavalio/honest-profiler/statuses/{sha}","languages_url":"https://api.github.com/repos/ikavalio/honest-profiler/languages","stargazers_url":"https://api.github.com/repos/ikavalio/honest-profiler/stargazers","contributors_url":"https://api.github.com/repos/ikavalio/honest-profiler/contributors","subscribers_url":"https://api.github.com/repos/ikavalio/honest-profiler/subscribers","subscription_url":"https://api.github.com/repos/ikavalio/honest-profiler/subscription","commits_url":"https://api.github.com/repos/ikavalio/honest-profiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/ikavalio/honest-profiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/ikavalio/honest-profiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/ikavalio/honest-profiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/ikavalio/honest-profiler/contents/{+path}","compare_url":"https://api.github.com/repos/ikavalio/honest-profiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ikavalio/honest-profiler/merges","archive_url":"https://api.github.com/repos/ikavalio/honest-profiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ikavalio/honest-profiler/downloads","issues_url":"https://api.github.com/repos/ikavalio/honest-profiler/issues{/number}","pulls_url":"https://api.github.com/repos/ikavalio/honest-profiler/pulls{/number}","milestones_url":"https://api.github.com/repos/ikavalio/honest-profiler/milestones{/number}","notifications_url":"https://api.github.com/repos/ikavalio/honest-profiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ikavalio/honest-profiler/labels{/name}","releases_url":"https://api.github.com/repos/ikavalio/honest-profiler/releases{/id}","deployments_url":"https://api.github.com/repos/ikavalio/honest-profiler/deployments","created_at":"2016-08-04T08:10:21Z","updated_at":"2016-08-05T13:53:53Z","pushed_at":"2016-08-15T07:32:43Z","git_url":"git://github.com/ikavalio/honest-profiler.git","ssh_url":"git@github.com:ikavalio/honest-profiler.git","clone_url":"https://github.com/ikavalio/honest-profiler.git","svn_url":"https://github.com/ikavalio/honest-profiler","homepage":"https://github.com/RichardWarburton/honest-profiler/wiki","size":787,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"RichardWarburton:master","ref":"master","sha":"02508916d6ea2e0b1cd67507b9dc86c8ede23d24","user":{"login":"RichardWarburton","id":328174,"avatar_url":"https://avatars.githubusercontent.com/u/328174?v=3","gravatar_id":"","url":"https://api.github.com/users/RichardWarburton","html_url":"https://github.com/RichardWarburton","followers_url":"https://api.github.com/users/RichardWarburton/followers","following_url":"https://api.github.com/users/RichardWarburton/following{/other_user}","gists_url":"https://api.github.com/users/RichardWarburton/gists{/gist_id}","starred_url":"https://api.github.com/users/RichardWarburton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichardWarburton/subscriptions","organizations_url":"https://api.github.com/users/RichardWarburton/orgs","repos_url":"https://api.github.com/users/RichardWarburton/repos","events_url":"https://api.github.com/users/RichardWarburton/events{/privacy}","received_events_url":"https://api.github.com/users/RichardWarburton/received_events","type":"User","site_admin":false},"repo":{"id":16926533,"name":"honest-profiler","full_name":"RichardWarburton/honest-profiler","owner":{"login":"RichardWarburton","id":328174,"avatar_url":"https://avatars.githubusercontent.com/u/328174?v=3","gravatar_id":"","url":"https://api.github.com/users/RichardWarburton","html_url":"https://github.com/RichardWarburton","followers_url":"https://api.github.com/users/RichardWarburton/followers","following_url":"https://api.github.com/users/RichardWarburton/following{/other_user}","gists_url":"https://api.github.com/users/RichardWarburton/gists{/gist_id}","starred_url":"https://api.github.com/users/RichardWarburton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichardWarburton/subscriptions","organizations_url":"https://api.github.com/users/RichardWarburton/orgs","repos_url":"https://api.github.com/users/RichardWarburton/repos","events_url":"https://api.github.com/users/RichardWarburton/events{/privacy}","received_events_url":"https://api.github.com/users/RichardWarburton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RichardWarburton/honest-profiler","description":"A sampling JVM profiler without the safepoint sample bias","fork":false,"url":"https://api.github.com/repos/RichardWarburton/honest-profiler","forks_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/forks","keys_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/teams","hooks_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/hooks","issue_events_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/issues/events{/number}","events_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/events","assignees_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/assignees{/user}","branches_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/branches{/branch}","tags_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/tags","blobs_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/statuses/{sha}","languages_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/languages","stargazers_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/stargazers","contributors_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/contributors","subscribers_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/subscribers","subscription_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/subscription","commits_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/contents/{+path}","compare_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/merges","archive_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/downloads","issues_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/issues{/number}","pulls_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/pulls{/number}","milestones_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/milestones{/number}","notifications_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/labels{/name}","releases_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/releases{/id}","deployments_url":"https://api.github.com/repos/RichardWarburton/honest-profiler/deployments","created_at":"2014-02-17T21:02:44Z","updated_at":"2016-08-17T23:38:58Z","pushed_at":"2016-08-18T19:03:25Z","git_url":"git://github.com/RichardWarburton/honest-profiler.git","ssh_url":"git@github.com:RichardWarburton/honest-profiler.git","clone_url":"https://github.com/RichardWarburton/honest-profiler.git","svn_url":"https://github.com/RichardWarburton/honest-profiler","homepage":"https://github.com/RichardWarburton/honest-profiler/wiki","size":927,"stargazers_count":449,"watchers_count":449,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":43,"forks":46,"open_issues":43,"watchers":449,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RichardWarburton/honest-profiler/pulls/154"},"html":{"href":"https://github.com/RichardWarburton/honest-profiler/pull/154"},"issue":{"href":"https://api.github.com/repos/RichardWarburton/honest-profiler/issues/154"},"comments":{"href":"https://api.github.com/repos/RichardWarburton/honest-profiler/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/RichardWarburton/honest-profiler/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/RichardWarburton/honest-profiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RichardWarburton/honest-profiler/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/RichardWarburton/honest-profiler/statuses/d18d69450dece3aeff9544204d5af3c215f92067"}}}}
{"actor":{"display_login":"RichardWarburton"}}