{"action":"created","comment":{"url":"https://api.github.com/repos/OpenSlides/OpenSlides/pulls/comments/87720512","pull_request_review_id":8321365,"id":87720512,"diff_hunk":"@@ -351,6 +351,64 @@ angular.module('OpenSlidesApp.core.site', [\n     }\n ])\n \n+.provider('MultiselectFilterProvider', [","path":"openslides/core/static/js/core/site.js","position":4,"original_position":4,"commit_id":"813ac76fd264c356ec0c99e2b33ce605b0b5bd0b","original_commit_id":"813ac76fd264c356ec0c99e2b33ce605b0b5bd0b","user":{"login":"normanjaeckel","id":2073844,"avatar_url":"https://avatars.githubusercontent.com/u/2073844?v=3","gravatar_id":"","url":"https://api.github.com/users/normanjaeckel","html_url":"https://github.com/normanjaeckel","followers_url":"https://api.github.com/users/normanjaeckel/followers","following_url":"https://api.github.com/users/normanjaeckel/following{/other_user}","gists_url":"https://api.github.com/users/normanjaeckel/gists{/gist_id}","starred_url":"https://api.github.com/users/normanjaeckel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanjaeckel/subscriptions","organizations_url":"https://api.github.com/users/normanjaeckel/orgs","repos_url":"https://api.github.com/users/normanjaeckel/repos","events_url":"https://api.github.com/users/normanjaeckel/events{/privacy}","received_events_url":"https://api.github.com/users/normanjaeckel/received_events","type":"User","site_admin":false},"body":"Why do you use a provider and not a factory (or a service)? A provider is useful if we want to configure something in the pre-run phase of Angular. Also the provider should not called Provider, see [here] (https://docs.angularjs.org/guide/providers#provider-recipe).","created_at":"2016-11-13T20:17:04Z","updated_at":"2016-11-13T20:17:04Z","html_url":"https://github.com/OpenSlides/OpenSlides/pull/2592#discussion_r87720512","pull_request_url":"https://api.github.com/repos/OpenSlides/OpenSlides/pulls/2592","_links":{"self":{"href":"https://api.github.com/repos/OpenSlides/OpenSlides/pulls/comments/87720512"},"html":{"href":"https://github.com/OpenSlides/OpenSlides/pull/2592#discussion_r87720512"},"pull_request":{"href":"https://api.github.com/repos/OpenSlides/OpenSlides/pulls/2592"}}},"pull_request":{"url":"https://api.github.com/repos/OpenSlides/OpenSlides/pulls/2592","id":92349085,"html_url":"https://github.com/OpenSlides/OpenSlides/pull/2592","diff_url":"https://github.com/OpenSlides/OpenSlides/pull/2592.diff","patch_url":"https://github.com/OpenSlides/OpenSlides/pull/2592.patch","issue_url":"https://api.github.com/repos/OpenSlides/OpenSlides/issues/2592","number":2592,"state":"open","locked":false,"title":"New table design for users","user":{"login":"FinnStutzenstein","id":8439581,"avatar_url":"https://avatars.githubusercontent.com/u/8439581?v=3","gravatar_id":"","url":"https://api.github.com/users/FinnStutzenstein","html_url":"https://github.com/FinnStutzenstein","followers_url":"https://api.github.com/users/FinnStutzenstein/followers","following_url":"https://api.github.com/users/FinnStutzenstein/following{/other_user}","gists_url":"https://api.github.com/users/FinnStutzenstein/gists{/gist_id}","starred_url":"https://api.github.com/users/FinnStutzenstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FinnStutzenstein/subscriptions","organizations_url":"https://api.github.com/users/FinnStutzenstein/orgs","repos_url":"https://api.github.com/users/FinnStutzenstein/repos","events_url":"https://api.github.com/users/FinnStutzenstein/events{/privacy}","received_events_url":"https://api.github.com/users/FinnStutzenstein/received_events","type":"User","site_admin":false},"body":"@emanuelschuetze This is the new user table. Please test it, I haven't had enough time to do this proper, but (as always) it should be functional ;) Please give some feedback for the layout of the single user rows.\r\n\r\nAlso in this PR I am going to make the table layout more clean (html and css) so that the basic structure could be adapted for every table. But this is currently in a wip state.","created_at":"2016-11-04T14:25:37Z","updated_at":"2016-11-13T20:24:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23e26cd47ec0f1eee97a15a882c778c3a1badf5e","assignee":{"login":"normanjaeckel","id":2073844,"avatar_url":"https://avatars.githubusercontent.com/u/2073844?v=3","gravatar_id":"","url":"https://api.github.com/users/normanjaeckel","html_url":"https://github.com/normanjaeckel","followers_url":"https://api.github.com/users/normanjaeckel/followers","following_url":"https://api.github.com/users/normanjaeckel/following{/other_user}","gists_url":"https://api.github.com/users/normanjaeckel/gists{/gist_id}","starred_url":"https://api.github.com/users/normanjaeckel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanjaeckel/subscriptions","organizations_url":"https://api.github.com/users/normanjaeckel/orgs","repos_url":"https://api.github.com/users/normanjaeckel/repos","events_url":"https://api.github.com/users/normanjaeckel/events{/privacy}","received_events_url":"https://api.github.com/users/normanjaeckel/received_events","type":"User","site_admin":false},"assignees":[{"login":"normanjaeckel","id":2073844,"avatar_url":"https://avatars.githubusercontent.com/u/2073844?v=3","gravatar_id":"","url":"https://api.github.com/users/normanjaeckel","html_url":"https://github.com/normanjaeckel","followers_url":"https://api.github.com/users/normanjaeckel/followers","following_url":"https://api.github.com/users/normanjaeckel/following{/other_user}","gists_url":"https://api.github.com/users/normanjaeckel/gists{/gist_id}","starred_url":"https://api.github.com/users/normanjaeckel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanjaeckel/subscriptions","organizations_url":"https://api.github.com/users/normanjaeckel/orgs","repos_url":"https://api.github.com/users/normanjaeckel/repos","events_url":"https://api.github.com/users/normanjaeckel/events{/privacy}","received_events_url":"https://api.github.com/users/normanjaeckel/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/OpenSlides/OpenSlides/milestones/21","html_url":"https://github.com/OpenSlides/OpenSlides/milestones/2.1","labels_url":"https://api.github.com/repos/OpenSlides/OpenSlides/milestones/21/labels","id":1291312,"number":21,"title":"2.1","description":"","creator":{"login":"ostcar","id":977937,"avatar_url":"https://avatars.githubusercontent.com/u/977937?v=3","gravatar_id":"","url":"https://api.github.com/users/ostcar","html_url":"https://github.com/ostcar","followers_url":"https://api.github.com/users/ostcar/followers","following_url":"https://api.github.com/users/ostcar/following{/other_user}","gists_url":"https://api.github.com/users/ostcar/gists{/gist_id}","starred_url":"https://api.github.com/users/ostcar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ostcar/subscriptions","organizations_url":"https://api.github.com/users/ostcar/orgs","repos_url":"https://api.github.com/users/ostcar/repos","events_url":"https://api.github.com/users/ostcar/events{/privacy}","received_events_url":"https://api.github.com/users/ostcar/received_events","type":"User","site_admin":false},"open_issues":118,"closed_issues":370,"state":"open","created_at":"2015-09-04T21:00:55Z","updated_at":"2016-11-11T15:00:02Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/OpenSlides/OpenSlides/pulls/2592/commits","review_comments_url":"https://api.github.com/repos/OpenSlides/OpenSlides/pulls/2592/comments","review_comment_url":"https://api.github.com/repos/OpenSlides/OpenSlides/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenSlides/OpenSlides/issues/2592/comments","statuses_url":"https://api.github.com/repos/OpenSlides/OpenSlides/statuses/813ac76fd264c356ec0c99e2b33ce605b0b5bd0b","head":{"label":"FinnStutzenstein:UserTable","ref":"UserTable","sha":"813ac76fd264c356ec0c99e2b33ce605b0b5bd0b","user":{"login":"FinnStutzenstein","id":8439581,"avatar_url":"https://avatars.githubusercontent.com/u/8439581?v=3","gravatar_id":"","url":"https://api.github.com/users/FinnStutzenstein","html_url":"https://github.com/FinnStutzenstein","followers_url":"https://api.github.com/users/FinnStutzenstein/followers","following_url":"https://api.github.com/users/FinnStutzenstein/following{/other_user}","gists_url":"https://api.github.com/users/FinnStutzenstein/gists{/gist_id}","starred_url":"https://api.github.com/users/FinnStutzenstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FinnStutzenstein/subscriptions","organizations_url":"https://api.github.com/users/FinnStutzenstein/orgs","repos_url":"https://api.github.com/users/FinnStutzenstein/repos","events_url":"https://api.github.com/users/FinnStutzenstein/events{/privacy}","received_events_url":"https://api.github.com/users/FinnStutzenstein/received_events","type":"User","site_admin":false},"repo":{"id":64663189,"name":"OpenSlides","full_name":"FinnStutzenstein/OpenSlides","owner":{"login":"FinnStutzenstein","id":8439581,"avatar_url":"https://avatars.githubusercontent.com/u/8439581?v=3","gravatar_id":"","url":"https://api.github.com/users/FinnStutzenstein","html_url":"https://github.com/FinnStutzenstein","followers_url":"https://api.github.com/users/FinnStutzenstein/followers","following_url":"https://api.github.com/users/FinnStutzenstein/following{/other_user}","gists_url":"https://api.github.com/users/FinnStutzenstein/gists{/gist_id}","starred_url":"https://api.github.com/users/FinnStutzenstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FinnStutzenstein/subscriptions","organizations_url":"https://api.github.com/users/FinnStutzenstein/orgs","repos_url":"https://api.github.com/users/FinnStutzenstein/repos","events_url":"https://api.github.com/users/FinnStutzenstein/events{/privacy}","received_events_url":"https://api.github.com/users/FinnStutzenstein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FinnStutzenstein/OpenSlides","description":"Presentation and assembly system","fork":true,"url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides","forks_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/forks","keys_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/teams","hooks_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/hooks","issue_events_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/issues/events{/number}","events_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/events","assignees_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/assignees{/user}","branches_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/branches{/branch}","tags_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/tags","blobs_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/git/refs{/sha}","trees_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/statuses/{sha}","languages_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/languages","stargazers_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/stargazers","contributors_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/contributors","subscribers_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/subscribers","subscription_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/subscription","commits_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/commits{/sha}","git_commits_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/git/commits{/sha}","comments_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/comments{/number}","issue_comment_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/issues/comments{/number}","contents_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/contents/{+path}","compare_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/merges","archive_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/downloads","issues_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/issues{/number}","pulls_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/pulls{/number}","milestones_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/milestones{/number}","notifications_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/labels{/name}","releases_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/releases{/id}","deployments_url":"https://api.github.com/repos/FinnStutzenstein/OpenSlides/deployments","created_at":"2016-08-01T11:58:39Z","updated_at":"2016-08-01T11:58:41Z","pushed_at":"2016-11-11T11:22:00Z","git_url":"git://github.com/FinnStutzenstein/OpenSlides.git","ssh_url":"git@github.com:FinnStutzenstein/OpenSlides.git","clone_url":"https://github.com/FinnStutzenstein/OpenSlides.git","svn_url":"https://github.com/FinnStutzenstein/OpenSlides","homepage":"http://openslides.org","size":38836,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenSlides:master","ref":"master","sha":"22ab7a15a323df64f1d940f01dab3f39a3d5dd60","user":{"login":"OpenSlides","id":2055730,"avatar_url":"https://avatars.githubusercontent.com/u/2055730?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenSlides","html_url":"https://github.com/OpenSlides","followers_url":"https://api.github.com/users/OpenSlides/followers","following_url":"https://api.github.com/users/OpenSlides/following{/other_user}","gists_url":"https://api.github.com/users/OpenSlides/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSlides/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSlides/subscriptions","organizations_url":"https://api.github.com/users/OpenSlides/orgs","repos_url":"https://api.github.com/users/OpenSlides/repos","events_url":"https://api.github.com/users/OpenSlides/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSlides/received_events","type":"Organization","site_admin":false},"repo":{"id":5250779,"name":"OpenSlides","full_name":"OpenSlides/OpenSlides","owner":{"login":"OpenSlides","id":2055730,"avatar_url":"https://avatars.githubusercontent.com/u/2055730?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenSlides","html_url":"https://github.com/OpenSlides","followers_url":"https://api.github.com/users/OpenSlides/followers","following_url":"https://api.github.com/users/OpenSlides/following{/other_user}","gists_url":"https://api.github.com/users/OpenSlides/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSlides/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSlides/subscriptions","organizations_url":"https://api.github.com/users/OpenSlides/orgs","repos_url":"https://api.github.com/users/OpenSlides/repos","events_url":"https://api.github.com/users/OpenSlides/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSlides/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenSlides/OpenSlides","description":"Presentation and assembly system","fork":false,"url":"https://api.github.com/repos/OpenSlides/OpenSlides","forks_url":"https://api.github.com/repos/OpenSlides/OpenSlides/forks","keys_url":"https://api.github.com/repos/OpenSlides/OpenSlides/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenSlides/OpenSlides/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenSlides/OpenSlides/teams","hooks_url":"https://api.github.com/repos/OpenSlides/OpenSlides/hooks","issue_events_url":"https://api.github.com/repos/OpenSlides/OpenSlides/issues/events{/number}","events_url":"https://api.github.com/repos/OpenSlides/OpenSlides/events","assignees_url":"https://api.github.com/repos/OpenSlides/OpenSlides/assignees{/user}","branches_url":"https://api.github.com/repos/OpenSlides/OpenSlides/branches{/branch}","tags_url":"https://api.github.com/repos/OpenSlides/OpenSlides/tags","blobs_url":"https://api.github.com/repos/OpenSlides/OpenSlides/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenSlides/OpenSlides/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenSlides/OpenSlides/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenSlides/OpenSlides/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenSlides/OpenSlides/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenSlides/OpenSlides/languages","stargazers_url":"https://api.github.com/repos/OpenSlides/OpenSlides/stargazers","contributors_url":"https://api.github.com/repos/OpenSlides/OpenSlides/contributors","subscribers_url":"https://api.github.com/repos/OpenSlides/OpenSlides/subscribers","subscription_url":"https://api.github.com/repos/OpenSlides/OpenSlides/subscription","commits_url":"https://api.github.com/repos/OpenSlides/OpenSlides/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenSlides/OpenSlides/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenSlides/OpenSlides/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenSlides/OpenSlides/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenSlides/OpenSlides/contents/{+path}","compare_url":"https://api.github.com/repos/OpenSlides/OpenSlides/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenSlides/OpenSlides/merges","archive_url":"https://api.github.com/repos/OpenSlides/OpenSlides/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenSlides/OpenSlides/downloads","issues_url":"https://api.github.com/repos/OpenSlides/OpenSlides/issues{/number}","pulls_url":"https://api.github.com/repos/OpenSlides/OpenSlides/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenSlides/OpenSlides/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenSlides/OpenSlides/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenSlides/OpenSlides/labels{/name}","releases_url":"https://api.github.com/repos/OpenSlides/OpenSlides/releases{/id}","deployments_url":"https://api.github.com/repos/OpenSlides/OpenSlides/deployments","created_at":"2012-07-31T20:04:39Z","updated_at":"2016-11-03T22:21:59Z","pushed_at":"2016-11-13T15:44:49Z","git_url":"git://github.com/OpenSlides/OpenSlides.git","ssh_url":"git@github.com:OpenSlides/OpenSlides.git","clone_url":"https://github.com/OpenSlides/OpenSlides.git","svn_url":"https://github.com/OpenSlides/OpenSlides","homepage":"http://openslides.org","size":39967,"stargazers_count":128,"watchers_count":128,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":201,"forks":47,"open_issues":201,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenSlides/OpenSlides/pulls/2592"},"html":{"href":"https://github.com/OpenSlides/OpenSlides/pull/2592"},"issue":{"href":"https://api.github.com/repos/OpenSlides/OpenSlides/issues/2592"},"comments":{"href":"https://api.github.com/repos/OpenSlides/OpenSlides/issues/2592/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenSlides/OpenSlides/pulls/2592/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenSlides/OpenSlides/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenSlides/OpenSlides/pulls/2592/commits"},"statuses":{"href":"https://api.github.com/repos/OpenSlides/OpenSlides/statuses/813ac76fd264c356ec0c99e2b33ce605b0b5bd0b"}}}}
{"actor":{"display_login":"normanjaeckel"}}