{"action":"created","issue":{"url":"https://api.github.com/repos/exercism/exercism.io/issues/2899","repository_url":"https://api.github.com/repos/exercism/exercism.io","labels_url":"https://api.github.com/repos/exercism/exercism.io/issues/2899/labels{/name}","comments_url":"https://api.github.com/repos/exercism/exercism.io/issues/2899/comments","events_url":"https://api.github.com/repos/exercism/exercism.io/issues/2899/events","html_url":"https://github.com/exercism/exercism.io/pull/2899","id":156075132,"number":2899,"title":"Require English library in db.rake for $CHILD_STATUS","user":{"login":"barnes7td","id":382636,"avatar_url":"https://avatars.githubusercontent.com/u/382636?v=3","gravatar_id":"","url":"https://api.github.com/users/barnes7td","html_url":"https://github.com/barnes7td","followers_url":"https://api.github.com/users/barnes7td/followers","following_url":"https://api.github.com/users/barnes7td/following{/other_user}","gists_url":"https://api.github.com/users/barnes7td/gists{/gist_id}","starred_url":"https://api.github.com/users/barnes7td/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barnes7td/subscriptions","organizations_url":"https://api.github.com/users/barnes7td/orgs","repos_url":"https://api.github.com/users/barnes7td/repos","events_url":"https://api.github.com/users/barnes7td/events{/privacy}","received_events_url":"https://api.github.com/users/barnes7td/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-05-21T00:54:03Z","updated_at":"2016-05-21T17:45:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/exercism/exercism.io/pulls/2899","html_url":"https://github.com/exercism/exercism.io/pull/2899","diff_url":"https://github.com/exercism/exercism.io/pull/2899.diff","patch_url":"https://github.com/exercism/exercism.io/pull/2899.patch"},"body":"While setting up the database locally. I kept running into an undefined method error originating from `db.rake` file:\r\n\r\n```\r\nNoMethodError: undefined method `success?' for nil:NilClass\r\n/Users/#######/code/open-source_contrib/exercism.io/lib/tasks/db.rake:45:in `block (2 levels) in <top (required)>'\r\n```\r\n\r\nThe error was 3 lines all similar to this:\r\n\r\n```\r\nfail \"Failed to create database\" unless $CHILD_STATUS.success?\r\n```\r\n\r\n`$CHILD_STATUS` was `nil` and therefore the error. In order to use the variable `$CHILD_STATUS`, you have to require the English Library in Ruby and that is all I did. I searched the rest of the project and found no reference to this global variable. The alternative would to have been replace all instances of `$CHILD_STATUS` with `$?`, but I prefer the more readable version. \r\n\r\nThis is my first commit, so let me know if I missed something. \r\n\r\nP.S. After reviewing the Contribution guide one last time before creating this PR, I ran rubocop and found 5 issues stating that `raise` should be used instead of `fail`. I amended the PR to conform to rubocop rules."},"comment":{"url":"https://api.github.com/repos/exercism/exercism.io/issues/comments/220791209","html_url":"https://github.com/exercism/exercism.io/pull/2899#issuecomment-220791209","issue_url":"https://api.github.com/repos/exercism/exercism.io/issues/2899","id":220791209,"user":{"login":"siakaramalegos","id":4777393,"avatar_url":"https://avatars.githubusercontent.com/u/4777393?v=3","gravatar_id":"","url":"https://api.github.com/users/siakaramalegos","html_url":"https://github.com/siakaramalegos","followers_url":"https://api.github.com/users/siakaramalegos/followers","following_url":"https://api.github.com/users/siakaramalegos/following{/other_user}","gists_url":"https://api.github.com/users/siakaramalegos/gists{/gist_id}","starred_url":"https://api.github.com/users/siakaramalegos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siakaramalegos/subscriptions","organizations_url":"https://api.github.com/users/siakaramalegos/orgs","repos_url":"https://api.github.com/users/siakaramalegos/repos","events_url":"https://api.github.com/users/siakaramalegos/events{/privacy}","received_events_url":"https://api.github.com/users/siakaramalegos/received_events","type":"User","site_admin":false},"created_at":"2016-05-21T17:45:01Z","updated_at":"2016-05-21T17:45:01Z","body":"I'm still with @barnes7td on this one. The English library allows you to use less cryptic names which is what the original writer of this file intended and contributes to greater readability. Is there a need to refactor this? I don't think so. We just need to give it access to the English library again. This is of course only my opinion though."}}
{"actor":{"display_login":"siakaramalegos"}}