{"action":"created","issue":{"url":"https://api.github.com/repos/0xfe/vexflow/issues/397","repository_url":"https://api.github.com/repos/0xfe/vexflow","labels_url":"https://api.github.com/repos/0xfe/vexflow/issues/397/labels{/name}","comments_url":"https://api.github.com/repos/0xfe/vexflow/issues/397/comments","events_url":"https://api.github.com/repos/0xfe/vexflow/issues/397/events","html_url":"https://github.com/0xfe/vexflow/pull/397","id":165188748,"number":397,"title":"Fix broken articulation positions within stave (and remove hard-coded articulation glyph metrics)","user":{"login":"Silverwolf90","id":1631625,"avatar_url":"https://avatars.githubusercontent.com/u/1631625?v=3","gravatar_id":"","url":"https://api.github.com/users/Silverwolf90","html_url":"https://github.com/Silverwolf90","followers_url":"https://api.github.com/users/Silverwolf90/followers","following_url":"https://api.github.com/users/Silverwolf90/following{/other_user}","gists_url":"https://api.github.com/users/Silverwolf90/gists{/gist_id}","starred_url":"https://api.github.com/users/Silverwolf90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Silverwolf90/subscriptions","organizations_url":"https://api.github.com/users/Silverwolf90/orgs","repos_url":"https://api.github.com/users/Silverwolf90/repos","events_url":"https://api.github.com/users/Silverwolf90/events{/privacy}","received_events_url":"https://api.github.com/users/Silverwolf90/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-07-12T21:45:10Z","updated_at":"2016-07-13T23:41:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/0xfe/vexflow/pulls/397","html_url":"https://github.com/0xfe/vexflow/pull/397","diff_url":"https://github.com/0xfe/vexflow/pull/397.diff","patch_url":"https://github.com/0xfe/vexflow/pull/397.patch"},"body":"I've been wanting to fix this for literally years! \r\n\r\nI wanted to open up a little work I've done around articulations. This is a pretty substantial refactor around the Articulation.draw() method which also includes work done on Glyph to override the default origin.\r\n\r\n### The following pairs are [before-fix/after-fix]\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1631625/16784693/e533e09a-4881-11e6-8fc5-8927b595768a.png)\r\n![image](https://cloud.githubusercontent.com/assets/1631625/16784696/e6c20180-4881-11e6-9316-fe8cbd3473c3.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1631625/16784697/e8ec5398-4881-11e6-89ff-01ebbdb09bd8.png)\r\n![image](https://cloud.githubusercontent.com/assets/1631625/16784700/eb7fec5a-4881-11e6-9ade-cdb94e192d03.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1631625/16784704/eefd3ce8-4881-11e6-9d02-f342b7f2bd8c.png)\r\n![image](https://cloud.githubusercontent.com/assets/1631625/16784707/f22d789c-4881-11e6-8159-6d32854f1370.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1631625/16784711/f56bef3e-4881-11e6-8d7a-a3dcff56069f.png)\r\n![image](https://cloud.githubusercontent.com/assets/1631625/16784717/f89c5bb2-4881-11e6-8b90-1fe59a2819cb.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1631625/16784724/fcff149c-4881-11e6-830e-6190e7796b7a.png)\r\n![image](https://cloud.githubusercontent.com/assets/1631625/16784728/0053633c-4882-11e6-8ae4-538bb9407a80.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1631625/16784734/0589c012-4882-11e6-85a6-d11cd6b64b88.png)\r\n![image](https://cloud.githubusercontent.com/assets/1631625/16784746/142e478c-4882-11e6-95e2-38b4c253da85.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1631625/16784751/17460036-4882-11e6-9f4b-b047fb986fbf.png)\r\n![image](https://cloud.githubusercontent.com/assets/1631625/16784756/1a2f9690-4882-11e6-9338-ac870b2e20c0.png)\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1631625/16784761/1cfa7494-4882-11e6-8ece-7f7b606ea8a3.png)\r\n![image](https://cloud.githubusercontent.com/assets/1631625/16784764/1fed50ea-4882-11e6-9b88-da0cb9d68772.png)"},"comment":{"url":"https://api.github.com/repos/0xfe/vexflow/issues/comments/232518342","html_url":"https://github.com/0xfe/vexflow/pull/397#issuecomment-232518342","issue_url":"https://api.github.com/repos/0xfe/vexflow/issues/397","id":232518342,"user":{"login":"0xfe","id":241299,"avatar_url":"https://avatars.githubusercontent.com/u/241299?v=3","gravatar_id":"","url":"https://api.github.com/users/0xfe","html_url":"https://github.com/0xfe","followers_url":"https://api.github.com/users/0xfe/followers","following_url":"https://api.github.com/users/0xfe/following{/other_user}","gists_url":"https://api.github.com/users/0xfe/gists{/gist_id}","starred_url":"https://api.github.com/users/0xfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xfe/subscriptions","organizations_url":"https://api.github.com/users/0xfe/orgs","repos_url":"https://api.github.com/users/0xfe/repos","events_url":"https://api.github.com/users/0xfe/events{/privacy}","received_events_url":"https://api.github.com/users/0xfe/received_events","type":"User","site_admin":false},"created_at":"2016-07-13T23:41:59Z","updated_at":"2016-07-13T23:41:59Z","body":"Re: opinionated, VexFlow shouldn't be opinionated at all (atleast in the lower level elements like Staves), and agree with you about consistent sane defaults... although in this case I'm not sure that I could get both consistent and sane for the bottom, but maybe I didn't try hard enough. What happens if you set `bottom_text_position` to `numLines`? (It does sound like a bug, thinking about this more.)"}}
{"actor":{"display_login":"0xfe"}}