{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/89342844","pull_request_review_id":9888595,"id":89342844,"diff_hunk":"@@ -27,10 +28,27 @@ func (pm *Manager) enable(p *v2.Plugin, force bool) error {\n \tp.Lock()\n \tp.Restart = true\n \tp.Unlock()\n+\n+\tmnt := filepath.Join(p.Rootfs, \"mnt\")","path":"plugin/manager_linux.go","position":13,"original_position":13,"commit_id":"a51b77d7c3e617c40830ae7da0103eaf516b6318","original_commit_id":"a51b77d7c3e617c40830ae7da0103eaf516b6318","user":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=3","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"body":"If we're going to do this, then yes. My plugin just failed due to this as well. But I'm not sure we should really do this. Plugins can add the mount if they want to, no? Or is this just so they plugin author doesn't have to ask permission from the user since it's a guarantee?","created_at":"2016-11-23T15:47:45Z","updated_at":"2016-11-23T15:47:45Z","html_url":"https://github.com/docker/docker/pull/26398#discussion_r89342844","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/26398","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/89342844"},"html":{"href":"https://github.com/docker/docker/pull/26398#discussion_r89342844"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/26398"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/26398","id":84389069,"html_url":"https://github.com/docker/docker/pull/26398","diff_url":"https://github.com/docker/docker/pull/26398.diff","patch_url":"https://github.com/docker/docker/pull/26398.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/26398","number":26398,"state":"open","locked":false,"title":"plugins: container-rootfs-relative paths","user":{"login":"tiborvass","id":827131,"avatar_url":"https://avatars.githubusercontent.com/u/827131?v=3","gravatar_id":"","url":"https://api.github.com/users/tiborvass","html_url":"https://github.com/tiborvass","followers_url":"https://api.github.com/users/tiborvass/followers","following_url":"https://api.github.com/users/tiborvass/following{/other_user}","gists_url":"https://api.github.com/users/tiborvass/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborvass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborvass/subscriptions","organizations_url":"https://api.github.com/users/tiborvass/orgs","repos_url":"https://api.github.com/users/tiborvass/repos","events_url":"https://api.github.com/users/tiborvass/events{/privacy}","received_events_url":"https://api.github.com/users/tiborvass/received_events","type":"User","site_admin":false},"body":"Legacy plugins expect host-relative paths (such as for Volume.Mount).\r\nHowever, a containerized plugin cannot respond with a host-relative\r\npath. Therefore, this commit modifies new volume plugins' paths in Mount\r\nand List to prepend the container's rootfs path.\r\n\r\nVolume plugins that do mounts and want it to propagate to the host namespace, need to mount inside `/mnt`.\r\n\r\nSigned-off-by: Tibor Vass tibor@docker.com\r\n","created_at":"2016-09-07T23:05:16Z","updated_at":"2016-11-23T15:47:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0486b2d698f48f7543c66cb1dd883d83017995a5","assignee":{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"assignees":[{"login":"vieux","id":1032519,"avatar_url":"https://avatars.githubusercontent.com/u/1032519?v=3","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},{"login":"mlaventure","id":16065150,"avatar_url":"https://avatars.githubusercontent.com/u/16065150?v=3","gravatar_id":"","url":"https://api.github.com/users/mlaventure","html_url":"https://github.com/mlaventure","followers_url":"https://api.github.com/users/mlaventure/followers","following_url":"https://api.github.com/users/mlaventure/following{/other_user}","gists_url":"https://api.github.com/users/mlaventure/gists{/gist_id}","starred_url":"https://api.github.com/users/mlaventure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlaventure/subscriptions","organizations_url":"https://api.github.com/users/mlaventure/orgs","repos_url":"https://api.github.com/users/mlaventure/repos","events_url":"https://api.github.com/users/mlaventure/events{/privacy}","received_events_url":"https://api.github.com/users/mlaventure/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/56","html_url":"https://github.com/docker/docker/milestones/1.13.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/56/labels","id":1839404,"number":56,"title":"1.13.0","description":"","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":110,"closed_issues":983,"state":"open","created_at":"2016-06-20T22:51:25Z","updated_at":"2016-11-23T15:16:08Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker/pulls/26398/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/26398/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/26398/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/a51b77d7c3e617c40830ae7da0103eaf516b6318","head":{"label":"tiborvass:plugin-fixes","ref":"plugin-fixes","sha":"a51b77d7c3e617c40830ae7da0103eaf516b6318","user":{"login":"tiborvass","id":827131,"avatar_url":"https://avatars.githubusercontent.com/u/827131?v=3","gravatar_id":"","url":"https://api.github.com/users/tiborvass","html_url":"https://github.com/tiborvass","followers_url":"https://api.github.com/users/tiborvass/followers","following_url":"https://api.github.com/users/tiborvass/following{/other_user}","gists_url":"https://api.github.com/users/tiborvass/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborvass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborvass/subscriptions","organizations_url":"https://api.github.com/users/tiborvass/orgs","repos_url":"https://api.github.com/users/tiborvass/repos","events_url":"https://api.github.com/users/tiborvass/events{/privacy}","received_events_url":"https://api.github.com/users/tiborvass/received_events","type":"User","site_admin":false},"repo":{"id":16678776,"name":"docker","full_name":"tiborvass/docker","owner":{"login":"tiborvass","id":827131,"avatar_url":"https://avatars.githubusercontent.com/u/827131?v=3","gravatar_id":"","url":"https://api.github.com/users/tiborvass","html_url":"https://github.com/tiborvass","followers_url":"https://api.github.com/users/tiborvass/followers","following_url":"https://api.github.com/users/tiborvass/following{/other_user}","gists_url":"https://api.github.com/users/tiborvass/gists{/gist_id}","starred_url":"https://api.github.com/users/tiborvass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiborvass/subscriptions","organizations_url":"https://api.github.com/users/tiborvass/orgs","repos_url":"https://api.github.com/users/tiborvass/repos","events_url":"https://api.github.com/users/tiborvass/events{/privacy}","received_events_url":"https://api.github.com/users/tiborvass/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tiborvass/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/tiborvass/docker","forks_url":"https://api.github.com/repos/tiborvass/docker/forks","keys_url":"https://api.github.com/repos/tiborvass/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiborvass/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiborvass/docker/teams","hooks_url":"https://api.github.com/repos/tiborvass/docker/hooks","issue_events_url":"https://api.github.com/repos/tiborvass/docker/issues/events{/number}","events_url":"https://api.github.com/repos/tiborvass/docker/events","assignees_url":"https://api.github.com/repos/tiborvass/docker/assignees{/user}","branches_url":"https://api.github.com/repos/tiborvass/docker/branches{/branch}","tags_url":"https://api.github.com/repos/tiborvass/docker/tags","blobs_url":"https://api.github.com/repos/tiborvass/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiborvass/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiborvass/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiborvass/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiborvass/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/tiborvass/docker/languages","stargazers_url":"https://api.github.com/repos/tiborvass/docker/stargazers","contributors_url":"https://api.github.com/repos/tiborvass/docker/contributors","subscribers_url":"https://api.github.com/repos/tiborvass/docker/subscribers","subscription_url":"https://api.github.com/repos/tiborvass/docker/subscription","commits_url":"https://api.github.com/repos/tiborvass/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiborvass/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiborvass/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiborvass/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/tiborvass/docker/contents/{+path}","compare_url":"https://api.github.com/repos/tiborvass/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiborvass/docker/merges","archive_url":"https://api.github.com/repos/tiborvass/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiborvass/docker/downloads","issues_url":"https://api.github.com/repos/tiborvass/docker/issues{/number}","pulls_url":"https://api.github.com/repos/tiborvass/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/tiborvass/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/tiborvass/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiborvass/docker/labels{/name}","releases_url":"https://api.github.com/repos/tiborvass/docker/releases{/id}","deployments_url":"https://api.github.com/repos/tiborvass/docker/deployments","created_at":"2014-02-09T23:31:28Z","updated_at":"2014-07-24T21:22:38Z","pushed_at":"2016-11-23T00:23:39Z","git_url":"git://github.com/tiborvass/docker.git","ssh_url":"git@github.com:tiborvass/docker.git","clone_url":"https://github.com/tiborvass/docker.git","svn_url":"https://github.com/tiborvass/docker","homepage":"http://www.docker.io","size":113753,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"23ea9e45fd6281e82c389e6112457a7bb70f8d89","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-11-23T15:10:08Z","pushed_at":"2016-11-23T15:46:01Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":233619,"stargazers_count":37144,"watchers_count":37144,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11006,"mirror_url":null,"open_issues_count":1956,"forks":11006,"open_issues":1956,"watchers":37144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/26398"},"html":{"href":"https://github.com/docker/docker/pull/26398"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/26398"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/26398/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/26398/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/26398/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/a51b77d7c3e617c40830ae7da0103eaf516b6318"}}}}
{"actor":{"display_login":"cpuguy83"}}