{"action":"created","issue":{"url":"https://api.github.com/repos/erasmus-without-paper/ewp-specs-api-mobilities/issues/2","repository_url":"https://api.github.com/repos/erasmus-without-paper/ewp-specs-api-mobilities","labels_url":"https://api.github.com/repos/erasmus-without-paper/ewp-specs-api-mobilities/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/erasmus-without-paper/ewp-specs-api-mobilities/issues/2/comments","events_url":"https://api.github.com/repos/erasmus-without-paper/ewp-specs-api-mobilities/issues/2/events","html_url":"https://github.com/erasmus-without-paper/ewp-specs-api-mobilities/issues/2","id":178024889,"number":2,"title":"Comments on response*.xsd","user":{"login":"kaiqu","id":18212605,"avatar_url":"https://avatars.githubusercontent.com/u/18212605?v=3","gravatar_id":"","url":"https://api.github.com/users/kaiqu","html_url":"https://github.com/kaiqu","followers_url":"https://api.github.com/users/kaiqu/followers","following_url":"https://api.github.com/users/kaiqu/following{/other_user}","gists_url":"https://api.github.com/users/kaiqu/gists{/gist_id}","starred_url":"https://api.github.com/users/kaiqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaiqu/subscriptions","organizations_url":"https://api.github.com/users/kaiqu/orgs","repos_url":"https://api.github.com/users/kaiqu/repos","events_url":"https://api.github.com/users/kaiqu/events{/privacy}","received_events_url":"https://api.github.com/users/kaiqu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-20T10:37:14Z","updated_at":"2016-10-10T09:00:39Z","closed_at":null,"body":"- I don't know what's meant to be the difference between response.xsd and response_new.xsd, so I comment on both together (maybe some of the missing elements are supposed to be in one and not the other, or the optionality varies)\r\n- Seems to be a combination of Person Mobility and Learning Agreement\r\n- Element \"timeline\" needs to be discussed, as Wojciech has mentioned\r\n  - It seems to represent Learning Agreement (with underlying LA Components), which I think is a better name for it\r\n  - I have used the term \"learning-agreement\" in my comments below\r\n- Element \"id\" = Person Mobility Id, I assume\r\n- Element \"agreement-id\" should be renamed to \"iia-id\"\r\n- Element \"given-names\" should be renamed to \"first-names\"?\r\n- Element \"bday\" should be renamed to \"birth-date\"?\r\n- Element \"gender\" must be optional\r\n- Element \"citizenship\" should be renamed to \"nationality\" and must be optional\r\n- Element \"rec-lang-comp\" should be renamed to \"lang-comp\" (this is an actual competence, not a required one) and must be optional\r\n- Element \"learning-opportunity-specification\" should be\r\n  - renamed to \"(learning-agreement-)components\" containing \"component\" repeated, which contains the rest of the component elements:\r\n    - \"component-id\" (or maybe \"planned\" could serve as identifier?)\r\n    - \"planned\" (mandatory)\r\n    - \"recognized\" (optional)\r\n    - \"recommended\" (optional)\r\n  - enclosed by a \"learning-agreement\" element (optional, repeated by a \"revision\" attribute), also containing:\r\n    - \"signature-date\"\r\n    - \"document-id\" (optional)\r\n- Element \"planned\" should be mandatory\r\n- Element \"recognized\" should be optional\r\n- Element \"learning-opportunity-specification-id\" should be renamed to \"...-code\"\r\n- Elements \"start-term\" and \"end-term\" should be split into \"year\" and \"term\"\r\n- Element \"title\" should be repeated by a \"lang\" attribute\r\n- The following elements from the model are missing:\r\n  - \"person-id\"\r\n  - \"mobility-type\"\r\n  - \"subject-area-code\"\r\n    - In the model, there is a unique Subject Area connected to a Person Mobility\r\n    - I am not sure how this correlates with the (possibly multiple) Subject Areas connected to the underlying LA Components\r\n  - In \"(learning-agreement-)component\"\r\n    - \"success\" (optional)\r\n    - \"credits\" (optional)\r\n    - \"grade\" (optional)\r\n- Are the following Person Mobility elements supposed to be in a separate API? In that case, which one?\r\n  - \"arrival-date\" (optional)\r\n  - \"departure-date\" (optional)\r\n"},"comment":{"url":"https://api.github.com/repos/erasmus-without-paper/ewp-specs-api-mobilities/issues/comments/252565866","html_url":"https://github.com/erasmus-without-paper/ewp-specs-api-mobilities/issues/2#issuecomment-252565866","issue_url":"https://api.github.com/repos/erasmus-without-paper/ewp-specs-api-mobilities/issues/2","id":252565866,"user":{"login":"kaiqu","id":18212605,"avatar_url":"https://avatars.githubusercontent.com/u/18212605?v=3","gravatar_id":"","url":"https://api.github.com/users/kaiqu","html_url":"https://github.com/kaiqu","followers_url":"https://api.github.com/users/kaiqu/followers","following_url":"https://api.github.com/users/kaiqu/following{/other_user}","gists_url":"https://api.github.com/users/kaiqu/gists{/gist_id}","starred_url":"https://api.github.com/users/kaiqu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaiqu/subscriptions","organizations_url":"https://api.github.com/users/kaiqu/orgs","repos_url":"https://api.github.com/users/kaiqu/repos","events_url":"https://api.github.com/users/kaiqu/events{/privacy}","received_events_url":"https://api.github.com/users/kaiqu/received_events","type":"User","site_admin":false},"created_at":"2016-10-10T09:00:39Z","updated_at":"2016-10-10T09:00:39Z","body":"Here are the remaining sub-issues.\r\n\r\n* Notes on \"schemafying\" the examples (where the examples don't contain the information themselves):\r\n\r\n> - Element \"gender\" must be optional\r\n> - Element \"citizenship\" [...] \"nationality\" [...] must be optional\r\n> - Element \"learning-opportunity-specification\" [...]\r\n>   - \"component-id\" (or maybe \"planned\" could serve as identifier?)\r\n>   - \"planned\" (mandatory)\r\n>   - \"recognized\" (optional)\r\n>   - \"recommended\" (optional)\r\n\r\n* Data model question:\r\n\r\n> In the model, there is a unique Subject Area connected to a [Person] Mobility\r\n> I am not sure how this correlates with the (possibly multiple) Subject Areas connected to the underlying LA Components\r\n\r\n* Format question:\r\n\r\n> Are the following [Person] Mobility elements supposed to be in a separate API? In that case, which one?\r\n> - \"arrival-date\" (optional)\r\n> - \"departure-date\" (optional)\r\n\r\n"}}
{"actor":{"display_login":"kaiqu"}}