{"action":"opened","number":2262,"pull_request":{"url":"https://api.github.com/repos/thoughtbot/paperclip/pulls/2262","id":78574457,"html_url":"https://github.com/thoughtbot/paperclip/pull/2262","diff_url":"https://github.com/thoughtbot/paperclip/pull/2262.diff","patch_url":"https://github.com/thoughtbot/paperclip/pull/2262.patch","issue_url":"https://api.github.com/repos/thoughtbot/paperclip/issues/2262","number":2262,"state":"open","locked":false,"title":"Update README preserve_files to be a boolean","user":{"login":"unixmonkey","id":8360,"avatar_url":"https://avatars.githubusercontent.com/u/8360?v=3","gravatar_id":"","url":"https://api.github.com/users/unixmonkey","html_url":"https://github.com/unixmonkey","followers_url":"https://api.github.com/users/unixmonkey/followers","following_url":"https://api.github.com/users/unixmonkey/following{/other_user}","gists_url":"https://api.github.com/users/unixmonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/unixmonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unixmonkey/subscriptions","organizations_url":"https://api.github.com/users/unixmonkey/orgs","repos_url":"https://api.github.com/users/unixmonkey/repos","events_url":"https://api.github.com/users/unixmonkey/events{/privacy}","received_events_url":"https://api.github.com/users/unixmonkey/received_events","type":"User","site_admin":false},"body":"Before this change, the value for `preserve_files` was the string `\"true\"`, potentially confusing users that they should use stringified booleans like `\"true\"` and `\"false\"`.\r\n\r\nHowever `\"false\"` would evaluate as truthy, and preserve files.\r\nThis appears to have been a factor in https://github.com/thoughtbot/paperclip/issues/1445#issuecomment-51430186","created_at":"2016-07-23T15:20:20Z","updated_at":"2016-07-23T15:20:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/thoughtbot/paperclip/pulls/2262/commits","review_comments_url":"https://api.github.com/repos/thoughtbot/paperclip/pulls/2262/comments","review_comment_url":"https://api.github.com/repos/thoughtbot/paperclip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thoughtbot/paperclip/issues/2262/comments","statuses_url":"https://api.github.com/repos/thoughtbot/paperclip/statuses/3d55bc8680825881bb3e359f69fe16f9d28375cf","head":{"label":"unixmonkey:unixmonkey-update-readme-preserve-files","ref":"unixmonkey-update-readme-preserve-files","sha":"3d55bc8680825881bb3e359f69fe16f9d28375cf","user":{"login":"unixmonkey","id":8360,"avatar_url":"https://avatars.githubusercontent.com/u/8360?v=3","gravatar_id":"","url":"https://api.github.com/users/unixmonkey","html_url":"https://github.com/unixmonkey","followers_url":"https://api.github.com/users/unixmonkey/followers","following_url":"https://api.github.com/users/unixmonkey/following{/other_user}","gists_url":"https://api.github.com/users/unixmonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/unixmonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unixmonkey/subscriptions","organizations_url":"https://api.github.com/users/unixmonkey/orgs","repos_url":"https://api.github.com/users/unixmonkey/repos","events_url":"https://api.github.com/users/unixmonkey/events{/privacy}","received_events_url":"https://api.github.com/users/unixmonkey/received_events","type":"User","site_admin":false},"repo":{"id":63978539,"name":"paperclip","full_name":"unixmonkey/paperclip","owner":{"login":"unixmonkey","id":8360,"avatar_url":"https://avatars.githubusercontent.com/u/8360?v=3","gravatar_id":"","url":"https://api.github.com/users/unixmonkey","html_url":"https://github.com/unixmonkey","followers_url":"https://api.github.com/users/unixmonkey/followers","following_url":"https://api.github.com/users/unixmonkey/following{/other_user}","gists_url":"https://api.github.com/users/unixmonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/unixmonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unixmonkey/subscriptions","organizations_url":"https://api.github.com/users/unixmonkey/orgs","repos_url":"https://api.github.com/users/unixmonkey/repos","events_url":"https://api.github.com/users/unixmonkey/events{/privacy}","received_events_url":"https://api.github.com/users/unixmonkey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/unixmonkey/paperclip","description":"Easy file attachment management for ActiveRecord","fork":true,"url":"https://api.github.com/repos/unixmonkey/paperclip","forks_url":"https://api.github.com/repos/unixmonkey/paperclip/forks","keys_url":"https://api.github.com/repos/unixmonkey/paperclip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unixmonkey/paperclip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unixmonkey/paperclip/teams","hooks_url":"https://api.github.com/repos/unixmonkey/paperclip/hooks","issue_events_url":"https://api.github.com/repos/unixmonkey/paperclip/issues/events{/number}","events_url":"https://api.github.com/repos/unixmonkey/paperclip/events","assignees_url":"https://api.github.com/repos/unixmonkey/paperclip/assignees{/user}","branches_url":"https://api.github.com/repos/unixmonkey/paperclip/branches{/branch}","tags_url":"https://api.github.com/repos/unixmonkey/paperclip/tags","blobs_url":"https://api.github.com/repos/unixmonkey/paperclip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unixmonkey/paperclip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unixmonkey/paperclip/git/refs{/sha}","trees_url":"https://api.github.com/repos/unixmonkey/paperclip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unixmonkey/paperclip/statuses/{sha}","languages_url":"https://api.github.com/repos/unixmonkey/paperclip/languages","stargazers_url":"https://api.github.com/repos/unixmonkey/paperclip/stargazers","contributors_url":"https://api.github.com/repos/unixmonkey/paperclip/contributors","subscribers_url":"https://api.github.com/repos/unixmonkey/paperclip/subscribers","subscription_url":"https://api.github.com/repos/unixmonkey/paperclip/subscription","commits_url":"https://api.github.com/repos/unixmonkey/paperclip/commits{/sha}","git_commits_url":"https://api.github.com/repos/unixmonkey/paperclip/git/commits{/sha}","comments_url":"https://api.github.com/repos/unixmonkey/paperclip/comments{/number}","issue_comment_url":"https://api.github.com/repos/unixmonkey/paperclip/issues/comments{/number}","contents_url":"https://api.github.com/repos/unixmonkey/paperclip/contents/{+path}","compare_url":"https://api.github.com/repos/unixmonkey/paperclip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unixmonkey/paperclip/merges","archive_url":"https://api.github.com/repos/unixmonkey/paperclip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unixmonkey/paperclip/downloads","issues_url":"https://api.github.com/repos/unixmonkey/paperclip/issues{/number}","pulls_url":"https://api.github.com/repos/unixmonkey/paperclip/pulls{/number}","milestones_url":"https://api.github.com/repos/unixmonkey/paperclip/milestones{/number}","notifications_url":"https://api.github.com/repos/unixmonkey/paperclip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unixmonkey/paperclip/labels{/name}","releases_url":"https://api.github.com/repos/unixmonkey/paperclip/releases{/id}","deployments_url":"https://api.github.com/repos/unixmonkey/paperclip/deployments","created_at":"2016-07-22T19:35:00Z","updated_at":"2016-07-22T19:35:03Z","pushed_at":"2016-07-23T15:18:46Z","git_url":"git://github.com/unixmonkey/paperclip.git","ssh_url":"git@github.com:unixmonkey/paperclip.git","clone_url":"https://github.com/unixmonkey/paperclip.git","svn_url":"https://github.com/unixmonkey/paperclip","homepage":"https://thoughtbot.com/open-source","size":8271,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"thoughtbot:master","ref":"master","sha":"fbbba2802e22b638af5835830b413c4cb0f7a07b","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":8393,"name":"paperclip","full_name":"thoughtbot/paperclip","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/paperclip","description":"Easy file attachment management for ActiveRecord","fork":false,"url":"https://api.github.com/repos/thoughtbot/paperclip","forks_url":"https://api.github.com/repos/thoughtbot/paperclip/forks","keys_url":"https://api.github.com/repos/thoughtbot/paperclip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/paperclip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/paperclip/teams","hooks_url":"https://api.github.com/repos/thoughtbot/paperclip/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/paperclip/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/paperclip/events","assignees_url":"https://api.github.com/repos/thoughtbot/paperclip/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/paperclip/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/paperclip/tags","blobs_url":"https://api.github.com/repos/thoughtbot/paperclip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/paperclip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/paperclip/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/paperclip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/paperclip/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/paperclip/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/paperclip/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/paperclip/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/paperclip/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/paperclip/subscription","commits_url":"https://api.github.com/repos/thoughtbot/paperclip/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/paperclip/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/paperclip/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/paperclip/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/paperclip/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/paperclip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/paperclip/merges","archive_url":"https://api.github.com/repos/thoughtbot/paperclip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/paperclip/downloads","issues_url":"https://api.github.com/repos/thoughtbot/paperclip/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/paperclip/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/paperclip/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/paperclip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/paperclip/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/paperclip/releases{/id}","deployments_url":"https://api.github.com/repos/thoughtbot/paperclip/deployments","created_at":"2008-04-10T19:58:20Z","updated_at":"2016-07-23T13:56:39Z","pushed_at":"2016-07-23T15:20:20Z","git_url":"git://github.com/thoughtbot/paperclip.git","ssh_url":"git@github.com:thoughtbot/paperclip.git","clone_url":"https://github.com/thoughtbot/paperclip.git","svn_url":"https://github.com/thoughtbot/paperclip","homepage":"https://thoughtbot.com/open-source","size":8271,"stargazers_count":7986,"watchers_count":7986,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1789,"mirror_url":null,"open_issues_count":127,"forks":1789,"open_issues":127,"watchers":7986,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/paperclip/pulls/2262"},"html":{"href":"https://github.com/thoughtbot/paperclip/pull/2262"},"issue":{"href":"https://api.github.com/repos/thoughtbot/paperclip/issues/2262"},"comments":{"href":"https://api.github.com/repos/thoughtbot/paperclip/issues/2262/comments"},"review_comments":{"href":"https://api.github.com/repos/thoughtbot/paperclip/pulls/2262/comments"},"review_comment":{"href":"https://api.github.com/repos/thoughtbot/paperclip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thoughtbot/paperclip/pulls/2262/commits"},"statuses":{"href":"https://api.github.com/repos/thoughtbot/paperclip/statuses/3d55bc8680825881bb3e359f69fe16f9d28375cf"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"unixmonkey"}}