{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/54502869","id":54502869,"diff_hunk":"@@ -2298,6 +2298,60 @@ func waitForDeploymentStatus(c clientset.Interface, ns, deploymentName string, d\n \treturn err\n }\n \n+// waitForDeploymentRollbackCleared waits for given deployment either started rolling back or doesn't need to rollback.\n+func waitForDeploymentRollbackCleared(c clientset.Interface, ns, deploymentName string) error {\n+\treturn wait.Poll(poll, 1*time.Minute, func() (bool, error) {\n+\t\tdeployment, err := c.Extensions().Deployments(ns).Get(deploymentName)\n+\t\tif err != nil {\n+\t\t\treturn false, err\n+\t\t}\n+\t\t// Rollback not set or is kicked off\n+\t\tif deployment.Spec.RollbackTo == nil {","path":"test/e2e/util.go","position":20,"original_position":12,"commit_id":"55348f1284000dfb6f0fe0127ad3e1aa43947c20","original_commit_id":"b2649961d746eb95de24b4b99a82f5857c8f216a","user":{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2016-03-01T00:11:44Z","updated_at":"2016-03-01T00:11:44Z","html_url":"https://github.com/kubernetes/kubernetes/pull/22202#discussion_r54502869","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22202","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/54502869"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/22202#discussion_r54502869"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22202"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22202","id":61145732,"html_url":"https://github.com/kubernetes/kubernetes/pull/22202","diff_url":"https://github.com/kubernetes/kubernetes/pull/22202.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/22202.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/22202","number":22202,"state":"open","locked":false,"title":"Fix deployment e2e rollback flake by waiting for all async actions to happen","user":{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false},"body":"Addresses #22122 \r\n\r\n@bgrant0607 @kargakis @kubernetes/sig-config","created_at":"2016-02-29T21:12:42Z","updated_at":"2016-03-01T00:11:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f68404ac05b3a900f969f8b490da6280bc2f6e89","assignee":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/15","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.2","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/15/labels","id":1278499,"number":15,"title":"v1.2","description":"https://github.com/kubernetes/kubernetes/wiki/Release-1.2","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":170,"closed_issues":441,"state":"open","created_at":"2015-08-29T03:54:16Z","updated_at":"2016-03-01T00:11:45Z","due_on":"2016-03-07T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22202/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22202/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/22202/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/55348f1284000dfb6f0fe0127ad3e1aa43947c20","head":{"label":"janetkuo:fix-rollback-flake","ref":"fix-rollback-flake","sha":"55348f1284000dfb6f0fe0127ad3e1aa43947c20","user":{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false},"repo":{"id":37748937,"name":"kubernetes","full_name":"janetkuo/kubernetes","owner":{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janetkuo/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/janetkuo/kubernetes","forks_url":"https://api.github.com/repos/janetkuo/kubernetes/forks","keys_url":"https://api.github.com/repos/janetkuo/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janetkuo/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janetkuo/kubernetes/teams","hooks_url":"https://api.github.com/repos/janetkuo/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/janetkuo/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/janetkuo/kubernetes/events","assignees_url":"https://api.github.com/repos/janetkuo/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/janetkuo/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/janetkuo/kubernetes/tags","blobs_url":"https://api.github.com/repos/janetkuo/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janetkuo/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janetkuo/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/janetkuo/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janetkuo/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/janetkuo/kubernetes/languages","stargazers_url":"https://api.github.com/repos/janetkuo/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/janetkuo/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/janetkuo/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/janetkuo/kubernetes/subscription","commits_url":"https://api.github.com/repos/janetkuo/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/janetkuo/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/janetkuo/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/janetkuo/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/janetkuo/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/janetkuo/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janetkuo/kubernetes/merges","archive_url":"https://api.github.com/repos/janetkuo/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janetkuo/kubernetes/downloads","issues_url":"https://api.github.com/repos/janetkuo/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/janetkuo/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/janetkuo/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/janetkuo/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janetkuo/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/janetkuo/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/janetkuo/kubernetes/deployments","created_at":"2015-06-19T22:29:18Z","updated_at":"2016-02-02T19:26:14Z","pushed_at":"2016-03-01T00:09:37Z","git_url":"git://github.com/janetkuo/kubernetes.git","ssh_url":"git@github.com:janetkuo/kubernetes.git","clone_url":"https://github.com/janetkuo/kubernetes.git","svn_url":"https://github.com/janetkuo/kubernetes","homepage":"http://kubernetes.io","size":174407,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"83d74dd9528e424c503c05795fe685ca8404630b","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-02-29T23:27:16Z","pushed_at":"2016-03-01T00:09:39Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":332885,"stargazers_count":12968,"watchers_count":12968,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3706,"mirror_url":null,"open_issues_count":2982,"forks":3706,"open_issues":2982,"watchers":12968,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22202"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/22202"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/22202"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/22202/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22202/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/22202/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/55348f1284000dfb6f0fe0127ad3e1aa43947c20"}}}}