{"action":"created","issue":{"url":"https://api.github.com/repos/HoverHell/RedditImageGrab/issues/56","repository_url":"https://api.github.com/repos/HoverHell/RedditImageGrab","labels_url":"https://api.github.com/repos/HoverHell/RedditImageGrab/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/HoverHell/RedditImageGrab/issues/56/comments","events_url":"https://api.github.com/repos/HoverHell/RedditImageGrab/issues/56/events","html_url":"https://github.com/HoverHell/RedditImageGrab/issues/56","id":176235044,"number":56,"title":"[Question] What sites can this download from?","user":{"login":"jtara1","id":7478231,"avatar_url":"https://avatars.githubusercontent.com/u/7478231?v=3","gravatar_id":"","url":"https://api.github.com/users/jtara1","html_url":"https://github.com/jtara1","followers_url":"https://api.github.com/users/jtara1/followers","following_url":"https://api.github.com/users/jtara1/following{/other_user}","gists_url":"https://api.github.com/users/jtara1/gists{/gist_id}","starred_url":"https://api.github.com/users/jtara1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtara1/subscriptions","organizations_url":"https://api.github.com/users/jtara1/orgs","repos_url":"https://api.github.com/users/jtara1/repos","events_url":"https://api.github.com/users/jtara1/events{/privacy}","received_events_url":"https://api.github.com/users/jtara1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-11T09:32:44Z","updated_at":"2016-09-11T15:19:19Z","closed_at":null,"body":"Hello, I'm working on a Python 3 fork of RedditImageGrab.\r\n\r\nGiven that most subreddits are built up by any user's contributions, any reddit submission could be any link, however, most links are Imgur, Reddit Image, or Gfycat hosted.\r\n\r\nIt appears there are classes and functions specifically for DeviantArt, but I recall at some points my fork failed to download any images from **DeviantArt**.\r\n\r\n**Gfycat**  & **Reddit Images** seem to work as expected.\r\n\r\nI implemented another github fork ([jtara1/imgur-downloader](https://github.com/jtara1/imgur-downloader)) of mine to handle all Imgur images and galleries so **Imgur** works well.\r\n\r\nI haven't tested **tumblr** or **pixiv** hosted media yet, but I'd like to add support for them too.\r\n\r\n*Second Question*: \r\n\r\nIs this unit test reliable for RedditImageGrab? I haven't played with it yet, and have been too lazy to port over to my fork.\r\n\r\n> /RedditImageGrab/redditdownload/tests/test-redditdownload.py "},"comment":{"url":"https://api.github.com/repos/HoverHell/RedditImageGrab/issues/comments/246185747","html_url":"https://github.com/HoverHell/RedditImageGrab/issues/56#issuecomment-246185747","issue_url":"https://api.github.com/repos/HoverHell/RedditImageGrab/issues/56","id":246185747,"user":{"login":"rachmadaniHaryono","id":6340878,"avatar_url":"https://avatars.githubusercontent.com/u/6340878?v=3","gravatar_id":"","url":"https://api.github.com/users/rachmadaniHaryono","html_url":"https://github.com/rachmadaniHaryono","followers_url":"https://api.github.com/users/rachmadaniHaryono/followers","following_url":"https://api.github.com/users/rachmadaniHaryono/following{/other_user}","gists_url":"https://api.github.com/users/rachmadaniHaryono/gists{/gist_id}","starred_url":"https://api.github.com/users/rachmadaniHaryono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rachmadaniHaryono/subscriptions","organizations_url":"https://api.github.com/users/rachmadaniHaryono/orgs","repos_url":"https://api.github.com/users/rachmadaniHaryono/repos","events_url":"https://api.github.com/users/rachmadaniHaryono/events{/privacy}","received_events_url":"https://api.github.com/users/rachmadaniHaryono/received_events","type":"User","site_admin":false},"created_at":"2016-09-11T15:19:19Z","updated_at":"2016-09-11T15:19:19Z","body":"Hi, \r\n\r\nI haven't checked yet, but from what I remember it support gfycat, imgur, deviant art, and simple image link. \r\n\r\nI have tumblr and (new) deviant parser, so I can add it here. \r\n\r\nFor pixiv I have a fork of some python pixiv project. If it is working, maybe I can add it here. \r\n\r\nFor the second question. You mean this https://github.com/rachmadaniHaryono/RedditImageGrab/blob/fix-continue/tests/test_redditdownload.py\r\n\r\nNot so reliable. It need better implementation and better testing method.  but it is better than nothing. And also because of this legacy code I'm still testing it py27. \r\n\r\nI also want this program either support of to be ported into python3. If you want to be maintainer for python 3 port of this program, I can help you. If you want,  I can raise new issue so @HoverHell can add link to your fork in Readme. \r\n"}}
{"actor":{"display_login":"rachmadaniHaryono"}}