{"action":"created","issue":{"url":"https://api.github.com/repos/pallets/flask/issues/2006","repository_url":"https://api.github.com/repos/pallets/flask","labels_url":"https://api.github.com/repos/pallets/flask/issues/2006/labels{/name}","comments_url":"https://api.github.com/repos/pallets/flask/issues/2006/comments","events_url":"https://api.github.com/repos/pallets/flask/issues/2006/events","html_url":"https://github.com/pallets/flask/pull/2006","id":175232780,"number":2006,"title":"Don't passthrough_errors unless instructed.","user":{"login":"untitaker","id":837573,"avatar_url":"https://avatars.githubusercontent.com/u/837573?v=3","gravatar_id":"","url":"https://api.github.com/users/untitaker","html_url":"https://github.com/untitaker","followers_url":"https://api.github.com/users/untitaker/followers","following_url":"https://api.github.com/users/untitaker/following{/other_user}","gists_url":"https://api.github.com/users/untitaker/gists{/gist_id}","starred_url":"https://api.github.com/users/untitaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untitaker/subscriptions","organizations_url":"https://api.github.com/users/untitaker/orgs","repos_url":"https://api.github.com/users/untitaker/repos","events_url":"https://api.github.com/users/untitaker/events{/privacy}","received_events_url":"https://api.github.com/users/untitaker/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pallets/flask/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-06T12:19:53Z","updated_at":"2016-09-06T16:14:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pallets/flask/pulls/2006","html_url":"https://github.com/pallets/flask/pull/2006","diff_url":"https://github.com/pallets/flask/pull/2006.diff","patch_url":"https://github.com/pallets/flask/pull/2006.patch"},"body":"Fix #2005\n\nRevert #1679 and #1996\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pallets/flask/2006)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/pallets/flask/issues/comments/245003657","html_url":"https://github.com/pallets/flask/pull/2006#issuecomment-245003657","issue_url":"https://api.github.com/repos/pallets/flask/issues/2006","id":245003657,"user":{"login":"miguelgrinberg","id":2715854,"avatar_url":"https://avatars.githubusercontent.com/u/2715854?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelgrinberg","html_url":"https://github.com/miguelgrinberg","followers_url":"https://api.github.com/users/miguelgrinberg/followers","following_url":"https://api.github.com/users/miguelgrinberg/following{/other_user}","gists_url":"https://api.github.com/users/miguelgrinberg/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelgrinberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelgrinberg/subscriptions","organizations_url":"https://api.github.com/users/miguelgrinberg/orgs","repos_url":"https://api.github.com/users/miguelgrinberg/repos","events_url":"https://api.github.com/users/miguelgrinberg/events{/privacy}","received_events_url":"https://api.github.com/users/miguelgrinberg/received_events","type":"User","site_admin":false},"created_at":"2016-09-06T16:14:18Z","updated_at":"2016-09-06T16:14:18Z","body":"If you merge this, we are back at square one, the passthrough errors option for flask will be broken again. Flask will passthrough errors all right, but then werkzeug will block them.\r\n\r\nI see now how the change in cli.py is a problem, but the change in app.py is perfectly fine and can/should stay. Why is there a need to undo that one as well?\r\n\r\nAs for the cli.py change, would it make sense to adapt that change to only set passthrough errors when the app is loaded eagerly? That seems doable and will only leave passthrough errors incorrectly set when the reloader is used, and that to me is fine, since the reloader and a debugger are normally not used together."}}
{"actor":{"display_login":"miguelgrinberg"}}