{"action":"opened","number":33,"pull_request":{"url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/pulls/33","id":87283640,"html_url":"https://github.com/Sensirion/SmartGadget-Android/pull/33","diff_url":"https://github.com/Sensirion/SmartGadget-Android/pull/33.diff","patch_url":"https://github.com/Sensirion/SmartGadget-Android/pull/33.patch","issue_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/issues/33","number":33,"state":"open","locked":false,"title":"Fix aggregation of RH and T values for download","user":{"login":"honggoff","id":140848,"avatar_url":"https://avatars.githubusercontent.com/u/140848?v=3","gravatar_id":"","url":"https://api.github.com/users/honggoff","html_url":"https://github.com/honggoff","followers_url":"https://api.github.com/users/honggoff/followers","following_url":"https://api.github.com/users/honggoff/following{/other_user}","gists_url":"https://api.github.com/users/honggoff/gists{/gist_id}","starred_url":"https://api.github.com/users/honggoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honggoff/subscriptions","organizations_url":"https://api.github.com/users/honggoff/orgs","repos_url":"https://api.github.com/users/honggoff/repos","events_url":"https://api.github.com/users/honggoff/events{/privacy}","received_events_url":"https://api.github.com/users/honggoff/received_events","type":"User","site_admin":false},"body":"This fixes a serious bug in the download feature that would lose three out of four data points, see the commit message below.\r\n\r\nEven after fixing this bug, there are still more strange issues, I documented them here: #31.\r\n\r\nWhen downloading logged RH/T values, these do not arrive in pairs,\r\nbut independently. Also, they arrive in packets, so several RH values\r\nmight arrive before the corresponding T value does. The code to\r\naggregate these values in pairs did not account for this, losing\r\nthree out of four values by overwriting them in the aggregator.\r\n\r\nThere are now two different aggregation strategies for live and\r\nlogged data: for live values, the timestamp is ignored, for historic\r\nvalues it is not.","created_at":"2016-09-29T10:14:29Z","updated_at":"2016-09-29T10:14:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/pulls/33/commits","review_comments_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/pulls/33/comments","review_comment_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/issues/33/comments","statuses_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/statuses/4d8575887f6b39afdb581e5043aaad1a64ffc073","head":{"label":"honggoff:download_bug","ref":"download_bug","sha":"4d8575887f6b39afdb581e5043aaad1a64ffc073","user":{"login":"honggoff","id":140848,"avatar_url":"https://avatars.githubusercontent.com/u/140848?v=3","gravatar_id":"","url":"https://api.github.com/users/honggoff","html_url":"https://github.com/honggoff","followers_url":"https://api.github.com/users/honggoff/followers","following_url":"https://api.github.com/users/honggoff/following{/other_user}","gists_url":"https://api.github.com/users/honggoff/gists{/gist_id}","starred_url":"https://api.github.com/users/honggoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honggoff/subscriptions","organizations_url":"https://api.github.com/users/honggoff/orgs","repos_url":"https://api.github.com/users/honggoff/repos","events_url":"https://api.github.com/users/honggoff/events{/privacy}","received_events_url":"https://api.github.com/users/honggoff/received_events","type":"User","site_admin":false},"repo":{"id":69555741,"name":"SmartGadget-Android","full_name":"honggoff/SmartGadget-Android","owner":{"login":"honggoff","id":140848,"avatar_url":"https://avatars.githubusercontent.com/u/140848?v=3","gravatar_id":"","url":"https://api.github.com/users/honggoff","html_url":"https://github.com/honggoff","followers_url":"https://api.github.com/users/honggoff/followers","following_url":"https://api.github.com/users/honggoff/following{/other_user}","gists_url":"https://api.github.com/users/honggoff/gists{/gist_id}","starred_url":"https://api.github.com/users/honggoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/honggoff/subscriptions","organizations_url":"https://api.github.com/users/honggoff/orgs","repos_url":"https://api.github.com/users/honggoff/repos","events_url":"https://api.github.com/users/honggoff/events{/privacy}","received_events_url":"https://api.github.com/users/honggoff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/honggoff/SmartGadget-Android","description":"The Sensirion Smart Gadget app allows you to establish a BLE (Bluetooth Low Energy) connection to your Sensirion Smart Gadget. The app displays the current temperature and relative humidity values measured by the integrated sensors.","fork":true,"url":"https://api.github.com/repos/honggoff/SmartGadget-Android","forks_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/forks","keys_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/teams","hooks_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/hooks","issue_events_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/issues/events{/number}","events_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/events","assignees_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/assignees{/user}","branches_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/branches{/branch}","tags_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/tags","blobs_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/languages","stargazers_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/stargazers","contributors_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/contributors","subscribers_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/subscribers","subscription_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/subscription","commits_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/contents/{+path}","compare_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/merges","archive_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/downloads","issues_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/issues{/number}","pulls_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/labels{/name}","releases_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/releases{/id}","deployments_url":"https://api.github.com/repos/honggoff/SmartGadget-Android/deployments","created_at":"2016-09-29T10:07:34Z","updated_at":"2016-09-29T10:07:35Z","pushed_at":"2016-09-29T10:12:39Z","git_url":"git://github.com/honggoff/SmartGadget-Android.git","ssh_url":"git@github.com:honggoff/SmartGadget-Android.git","clone_url":"https://github.com/honggoff/SmartGadget-Android.git","svn_url":"https://github.com/honggoff/SmartGadget-Android","homepage":null,"size":1682,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sensirion:master","ref":"master","sha":"7e7d870fa8da632c46ee341ef445f397f36e87f6","user":{"login":"Sensirion","id":2580116,"avatar_url":"https://avatars.githubusercontent.com/u/2580116?v=3","gravatar_id":"","url":"https://api.github.com/users/Sensirion","html_url":"https://github.com/Sensirion","followers_url":"https://api.github.com/users/Sensirion/followers","following_url":"https://api.github.com/users/Sensirion/following{/other_user}","gists_url":"https://api.github.com/users/Sensirion/gists{/gist_id}","starred_url":"https://api.github.com/users/Sensirion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sensirion/subscriptions","organizations_url":"https://api.github.com/users/Sensirion/orgs","repos_url":"https://api.github.com/users/Sensirion/repos","events_url":"https://api.github.com/users/Sensirion/events{/privacy}","received_events_url":"https://api.github.com/users/Sensirion/received_events","type":"Organization","site_admin":false},"repo":{"id":34846113,"name":"SmartGadget-Android","full_name":"Sensirion/SmartGadget-Android","owner":{"login":"Sensirion","id":2580116,"avatar_url":"https://avatars.githubusercontent.com/u/2580116?v=3","gravatar_id":"","url":"https://api.github.com/users/Sensirion","html_url":"https://github.com/Sensirion","followers_url":"https://api.github.com/users/Sensirion/followers","following_url":"https://api.github.com/users/Sensirion/following{/other_user}","gists_url":"https://api.github.com/users/Sensirion/gists{/gist_id}","starred_url":"https://api.github.com/users/Sensirion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sensirion/subscriptions","organizations_url":"https://api.github.com/users/Sensirion/orgs","repos_url":"https://api.github.com/users/Sensirion/repos","events_url":"https://api.github.com/users/Sensirion/events{/privacy}","received_events_url":"https://api.github.com/users/Sensirion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sensirion/SmartGadget-Android","description":"The Sensirion Smart Gadget app allows you to establish a BLE (Bluetooth Low Energy) connection to your Sensirion Smart Gadget. The app displays the current temperature and relative humidity values measured by the integrated sensors.","fork":false,"url":"https://api.github.com/repos/Sensirion/SmartGadget-Android","forks_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/forks","keys_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/teams","hooks_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/hooks","issue_events_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/issues/events{/number}","events_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/events","assignees_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/assignees{/user}","branches_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/branches{/branch}","tags_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/tags","blobs_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/languages","stargazers_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/stargazers","contributors_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/contributors","subscribers_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/subscribers","subscription_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/subscription","commits_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/contents/{+path}","compare_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/merges","archive_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/downloads","issues_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/issues{/number}","pulls_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/labels{/name}","releases_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/releases{/id}","deployments_url":"https://api.github.com/repos/Sensirion/SmartGadget-Android/deployments","created_at":"2015-04-30T09:26:19Z","updated_at":"2016-09-26T08:21:39Z","pushed_at":"2016-09-29T10:09:59Z","git_url":"git://github.com/Sensirion/SmartGadget-Android.git","ssh_url":"git@github.com:Sensirion/SmartGadget-Android.git","clone_url":"https://github.com/Sensirion/SmartGadget-Android.git","svn_url":"https://github.com/Sensirion/SmartGadget-Android","homepage":null,"size":1682,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sensirion/SmartGadget-Android/pulls/33"},"html":{"href":"https://github.com/Sensirion/SmartGadget-Android/pull/33"},"issue":{"href":"https://api.github.com/repos/Sensirion/SmartGadget-Android/issues/33"},"comments":{"href":"https://api.github.com/repos/Sensirion/SmartGadget-Android/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/Sensirion/SmartGadget-Android/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/Sensirion/SmartGadget-Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sensirion/SmartGadget-Android/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/Sensirion/SmartGadget-Android/statuses/4d8575887f6b39afdb581e5043aaad1a64ffc073"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":282,"deletions":53,"changed_files":7}}
{"actor":{"display_login":"honggoff"}}