{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/comments/60468592","id":60468592,"diff_hunk":"@@ -56,4 +56,11 @@\n     command => \"${::system32}\\\\cmd.exe /c start /b ${_cmd_location} /c \\\"${_installbat}\\\" ${::puppet_agent_pid}\",\n     path    => $::path,\n   }\n+\n+  # PUP-5480/PE-15037 Cache dir loses inheritable SYSTEM perms\n+  exec { 'fix inheritable SYSTEM perms':\n+    command => \"${::system32}\\\\icacls.exe \\\"${::puppet_client_datadir}\\\" /grant \\\"SYSTEM:(OI)(CI)(F)\\\"\",\n+    unless  => \"${::system32}\\\\icacls.exe \\\"${::puppet_client_datadir}\\\" | findstr \\\"SYSTEM:(OI)(CI)(F)\\\"\",\n+    require => Exec['install_puppet.bat'],","path":"manifests/windows/install.pp","position":9,"original_position":9,"commit_id":"5b112106aaaf13f51ee3b7a4f352a81407e01b29","original_commit_id":"5b112106aaaf13f51ee3b7a4f352a81407e01b29","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"As in, the current version of Puppet may break the ACL settings on client_datadir again before we exit?","created_at":"2016-04-20T19:04:10Z","updated_at":"2016-04-20T19:04:10Z","html_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/112#discussion_r60468592","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/112","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/comments/60468592"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/112#discussion_r60468592"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/112"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/112","id":67129687,"html_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/112","diff_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/112.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/112.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/112","number":112,"state":"closed","locked":false,"title":"(PE-15036) Fix Windows permission inheritance","user":{"login":"highb","id":759848,"avatar_url":"https://avatars.githubusercontent.com/u/759848?v=3","gravatar_id":"","url":"https://api.github.com/users/highb","html_url":"https://github.com/highb","followers_url":"https://api.github.com/users/highb/followers","following_url":"https://api.github.com/users/highb/following{/other_user}","gists_url":"https://api.github.com/users/highb/gists{/gist_id}","starred_url":"https://api.github.com/users/highb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highb/subscriptions","organizations_url":"https://api.github.com/users/highb/orgs","repos_url":"https://api.github.com/users/highb/repos","events_url":"https://api.github.com/users/highb/events{/privacy}","received_events_url":"https://api.github.com/users/highb/received_events","type":"User","site_admin":false},"body":"Prior to this commit there was an issue where the inherit permission\r\nvalue on the `client_datadir` folder was being lost, causing the folder\r\nto be inaccessible to the MCO/PCP daemons.\r\n\r\nThis commit ensures that directory has the proper inherit permission,\r\nif it appears that it does not have it. For more details: PE-15036","created_at":"2016-04-20T05:16:18Z","updated_at":"2016-04-20T19:04:10Z","closed_at":"2016-04-20T17:27:06Z","merged_at":"2016-04-20T17:27:06Z","merge_commit_sha":"7580884143e5c793f325d11f73e5c407470076c7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/112/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/112/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/112/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/statuses/5b112106aaaf13f51ee3b7a4f352a81407e01b29","head":{"label":"highb:fix/master/pe-15037_fix_inhieritable_permissions_windows","ref":"fix/master/pe-15037_fix_inhieritable_permissions_windows","sha":"5b112106aaaf13f51ee3b7a4f352a81407e01b29","user":{"login":"highb","id":759848,"avatar_url":"https://avatars.githubusercontent.com/u/759848?v=3","gravatar_id":"","url":"https://api.github.com/users/highb","html_url":"https://github.com/highb","followers_url":"https://api.github.com/users/highb/followers","following_url":"https://api.github.com/users/highb/following{/other_user}","gists_url":"https://api.github.com/users/highb/gists{/gist_id}","starred_url":"https://api.github.com/users/highb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highb/subscriptions","organizations_url":"https://api.github.com/users/highb/orgs","repos_url":"https://api.github.com/users/highb/repos","events_url":"https://api.github.com/users/highb/events{/privacy}","received_events_url":"https://api.github.com/users/highb/received_events","type":"User","site_admin":false},"repo":{"id":42746934,"name":"puppetlabs-puppet_agent","full_name":"highb/puppetlabs-puppet_agent","owner":{"login":"highb","id":759848,"avatar_url":"https://avatars.githubusercontent.com/u/759848?v=3","gravatar_id":"","url":"https://api.github.com/users/highb","html_url":"https://github.com/highb","followers_url":"https://api.github.com/users/highb/followers","following_url":"https://api.github.com/users/highb/following{/other_user}","gists_url":"https://api.github.com/users/highb/gists{/gist_id}","starred_url":"https://api.github.com/users/highb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highb/subscriptions","organizations_url":"https://api.github.com/users/highb/orgs","repos_url":"https://api.github.com/users/highb/repos","events_url":"https://api.github.com/users/highb/events{/privacy}","received_events_url":"https://api.github.com/users/highb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/highb/puppetlabs-puppet_agent","description":"Module for managing Puppet-Agent","fork":true,"url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent","forks_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/forks","keys_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/teams","hooks_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/hooks","issue_events_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/issues/events{/number}","events_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/events","assignees_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/assignees{/user}","branches_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/branches{/branch}","tags_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/tags","blobs_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/statuses/{sha}","languages_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/languages","stargazers_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/stargazers","contributors_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/contributors","subscribers_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/subscribers","subscription_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/subscription","commits_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/contents/{+path}","compare_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/merges","archive_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/downloads","issues_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/issues{/number}","pulls_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/pulls{/number}","milestones_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/milestones{/number}","notifications_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/labels{/name}","releases_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/releases{/id}","deployments_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/deployments","created_at":"2015-09-18T21:03:46Z","updated_at":"2015-09-18T21:03:47Z","pushed_at":"2016-04-20T16:29:37Z","git_url":"git://github.com/highb/puppetlabs-puppet_agent.git","ssh_url":"git@github.com:highb/puppetlabs-puppet_agent.git","clone_url":"https://github.com/highb/puppetlabs-puppet_agent.git","svn_url":"https://github.com/highb/puppetlabs-puppet_agent","homepage":"https://tickets.puppetlabs.com/browse/PUP","size":373,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"1f89c3f924a0dfd7d0da6226c394495c351068ad","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":35058943,"name":"puppetlabs-puppet_agent","full_name":"puppetlabs/puppetlabs-puppet_agent","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent","description":"Module for managing Puppet-Agent","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/deployments","created_at":"2015-05-04T20:50:16Z","updated_at":"2016-04-02T09:13:29Z","pushed_at":"2016-04-20T17:28:50Z","git_url":"git://github.com/puppetlabs/puppetlabs-puppet_agent.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-puppet_agent.git","clone_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent.git","svn_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent","homepage":"https://tickets.puppetlabs.com/browse/PUP","size":431,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":1,"forks":36,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/112"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/112"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/112"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/statuses/5b112106aaaf13f51ee3b7a4f352a81407e01b29"}}}}