{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/81000957","pull_request_review_id":2014122,"id":81000957,"diff_hunk":"@@ -1,152 +1,164 @@\n ﻿// Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.\n-using Roslyn.Test.Performance.Utilities;\n-using System.Collections.Generic;\n+\n+using System;\n using System.IO;\n-using System.Xml;\n+using System.Linq;\n+\n+using Roslyn.Test.Performance.Utilities;\n using static Roslyn.Test.Performance.Utilities.TestUtilities;\n-using static Roslyn.Test.Performance.Runner.Tools;\n \n namespace Roslyn.Test.Performance.Runner\n {\n     public static class Benchview \n     {\n-        private const string s_BenchviewPath = @\"\\\\vcbench-srv4\\benchview\\uploads\\vibench\";\n+        const string sasEnvVar = \"BV_UPLOAD_SAS_TOKEN\";\n+        static string scriptDir = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, \"Microsoft.BenchView.JSONFormat\", \"tools\");\n+        static string outputDir = GetCPCDirectoryPath();\n+        static string[] validSubmissionTypes = new string[] { \"rolling\", \"private\", \"local\" };","path":"src/Test/Perf/Runner/Benchview.cs","position":null,"original_position":22,"commit_id":"4fe9f5ec616690321eb0da03147a5dbc3ba81ab3","original_commit_id":"6c9f0738b700fb7894918cf79d9c80414bf2aad4","user":{"login":"john-soklaski","id":12491965,"avatar_url":"https://avatars.githubusercontent.com/u/12491965?v=3","gravatar_id":"","url":"https://api.github.com/users/john-soklaski","html_url":"https://github.com/john-soklaski","followers_url":"https://api.github.com/users/john-soklaski/followers","following_url":"https://api.github.com/users/john-soklaski/following{/other_user}","gists_url":"https://api.github.com/users/john-soklaski/gists{/gist_id}","starred_url":"https://api.github.com/users/john-soklaski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-soklaski/subscriptions","organizations_url":"https://api.github.com/users/john-soklaski/orgs","repos_url":"https://api.github.com/users/john-soklaski/repos","events_url":"https://api.github.com/users/john-soklaski/events{/privacy}","received_events_url":"https://api.github.com/users/john-soklaski/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2016-09-28T19:43:07Z","updated_at":"2016-09-28T19:43:07Z","html_url":"https://github.com/dotnet/roslyn/pull/14039#discussion_r81000957","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/14039","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/81000957"},"html":{"href":"https://github.com/dotnet/roslyn/pull/14039#discussion_r81000957"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/14039"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/14039","id":86594796,"html_url":"https://github.com/dotnet/roslyn/pull/14039","diff_url":"https://github.com/dotnet/roslyn/pull/14039.diff","patch_url":"https://github.com/dotnet/roslyn/pull/14039.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/14039","number":14039,"state":"open","locked":false,"title":"Upload perf runs to Benchview","user":{"login":"john-soklaski","id":12491965,"avatar_url":"https://avatars.githubusercontent.com/u/12491965?v=3","gravatar_id":"","url":"https://api.github.com/users/john-soklaski","html_url":"https://github.com/john-soklaski","followers_url":"https://api.github.com/users/john-soklaski/followers","following_url":"https://api.github.com/users/john-soklaski/following{/other_user}","gists_url":"https://api.github.com/users/john-soklaski/gists{/gist_id}","starred_url":"https://api.github.com/users/john-soklaski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-soklaski/subscriptions","organizations_url":"https://api.github.com/users/john-soklaski/orgs","repos_url":"https://api.github.com/users/john-soklaski/repos","events_url":"https://api.github.com/users/john-soklaski/events{/privacy}","received_events_url":"https://api.github.com/users/john-soklaski/received_events","type":"User","site_admin":false},"body":"cc:  @dotnet/roslyn-perf @TyOverby ","created_at":"2016-09-23T23:09:15Z","updated_at":"2016-09-28T19:43:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ff9bfec6277bbddf739bef3f0f30bd6f7cc79dd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/14039/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/14039/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/14039/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/4fe9f5ec616690321eb0da03147a5dbc3ba81ab3","head":{"label":"john-soklaski:benchview","ref":"benchview","sha":"4fe9f5ec616690321eb0da03147a5dbc3ba81ab3","user":{"login":"john-soklaski","id":12491965,"avatar_url":"https://avatars.githubusercontent.com/u/12491965?v=3","gravatar_id":"","url":"https://api.github.com/users/john-soklaski","html_url":"https://github.com/john-soklaski","followers_url":"https://api.github.com/users/john-soklaski/followers","following_url":"https://api.github.com/users/john-soklaski/following{/other_user}","gists_url":"https://api.github.com/users/john-soklaski/gists{/gist_id}","starred_url":"https://api.github.com/users/john-soklaski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-soklaski/subscriptions","organizations_url":"https://api.github.com/users/john-soklaski/orgs","repos_url":"https://api.github.com/users/john-soklaski/repos","events_url":"https://api.github.com/users/john-soklaski/events{/privacy}","received_events_url":"https://api.github.com/users/john-soklaski/received_events","type":"User","site_admin":false},"repo":{"id":68265455,"name":"roslyn","full_name":"john-soklaski/roslyn","owner":{"login":"john-soklaski","id":12491965,"avatar_url":"https://avatars.githubusercontent.com/u/12491965?v=3","gravatar_id":"","url":"https://api.github.com/users/john-soklaski","html_url":"https://github.com/john-soklaski","followers_url":"https://api.github.com/users/john-soklaski/followers","following_url":"https://api.github.com/users/john-soklaski/following{/other_user}","gists_url":"https://api.github.com/users/john-soklaski/gists{/gist_id}","starred_url":"https://api.github.com/users/john-soklaski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-soklaski/subscriptions","organizations_url":"https://api.github.com/users/john-soklaski/orgs","repos_url":"https://api.github.com/users/john-soklaski/repos","events_url":"https://api.github.com/users/john-soklaski/events{/privacy}","received_events_url":"https://api.github.com/users/john-soklaski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/john-soklaski/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/john-soklaski/roslyn","forks_url":"https://api.github.com/repos/john-soklaski/roslyn/forks","keys_url":"https://api.github.com/repos/john-soklaski/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/john-soklaski/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/john-soklaski/roslyn/teams","hooks_url":"https://api.github.com/repos/john-soklaski/roslyn/hooks","issue_events_url":"https://api.github.com/repos/john-soklaski/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/john-soklaski/roslyn/events","assignees_url":"https://api.github.com/repos/john-soklaski/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/john-soklaski/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/john-soklaski/roslyn/tags","blobs_url":"https://api.github.com/repos/john-soklaski/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/john-soklaski/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/john-soklaski/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/john-soklaski/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/john-soklaski/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/john-soklaski/roslyn/languages","stargazers_url":"https://api.github.com/repos/john-soklaski/roslyn/stargazers","contributors_url":"https://api.github.com/repos/john-soklaski/roslyn/contributors","subscribers_url":"https://api.github.com/repos/john-soklaski/roslyn/subscribers","subscription_url":"https://api.github.com/repos/john-soklaski/roslyn/subscription","commits_url":"https://api.github.com/repos/john-soklaski/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/john-soklaski/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/john-soklaski/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/john-soklaski/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/john-soklaski/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/john-soklaski/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/john-soklaski/roslyn/merges","archive_url":"https://api.github.com/repos/john-soklaski/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/john-soklaski/roslyn/downloads","issues_url":"https://api.github.com/repos/john-soklaski/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/john-soklaski/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/john-soklaski/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/john-soklaski/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/john-soklaski/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/john-soklaski/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/john-soklaski/roslyn/deployments","created_at":"2016-09-15T04:09:24Z","updated_at":"2016-09-15T04:10:01Z","pushed_at":"2016-09-28T19:42:27Z","git_url":"git://github.com/john-soklaski/roslyn.git","ssh_url":"git@github.com:john-soklaski/roslyn.git","clone_url":"https://github.com/john-soklaski/roslyn.git","svn_url":"https://github.com/john-soklaski/roslyn","homepage":"","size":178584,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"c968cf4b5a2bab55eeae787a850d5de9cc24fce2","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2016-09-28T12:58:11Z","pushed_at":"2016-09-28T19:42:28Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":338782,"stargazers_count":6272,"watchers_count":6272,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1508,"mirror_url":null,"open_issues_count":3283,"forks":1508,"open_issues":3283,"watchers":6272,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/14039"},"html":{"href":"https://github.com/dotnet/roslyn/pull/14039"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/14039"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/14039/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/14039/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/14039/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/4fe9f5ec616690321eb0da03147a5dbc3ba81ab3"}}}}
{"actor":{"display_login":"john-soklaski"}}