{"action":"opened","number":6657,"pull_request":{"url":"https://api.github.com/repos/godotengine/godot/pulls/6657","id":87419592,"html_url":"https://github.com/godotengine/godot/pull/6657","diff_url":"https://github.com/godotengine/godot/pull/6657.diff","patch_url":"https://github.com/godotengine/godot/pull/6657.patch","issue_url":"https://api.github.com/repos/godotengine/godot/issues/6657","number":6657,"state":"open","locked":false,"title":"Use 2 different ENet channels for reliable/unreliable packets","user":{"login":"Faless","id":1687918,"avatar_url":"https://avatars.githubusercontent.com/u/1687918?v=3","gravatar_id":"","url":"https://api.github.com/users/Faless","html_url":"https://github.com/Faless","followers_url":"https://api.github.com/users/Faless/followers","following_url":"https://api.github.com/users/Faless/following{/other_user}","gists_url":"https://api.github.com/users/Faless/gists{/gist_id}","starred_url":"https://api.github.com/users/Faless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Faless/subscriptions","organizations_url":"https://api.github.com/users/Faless/orgs","repos_url":"https://api.github.com/users/Faless/repos","events_url":"https://api.github.com/users/Faless/events{/privacy}","received_events_url":"https://api.github.com/users/Faless/received_events","type":"User","site_admin":false},"body":"This avoids stalling other sequenced but unreliable packets\r\n(i.e. UNRELIABLE_ORDERED) when sending RELIABLE packets.\r\n\r\nImportant Notes:\r\n-\r\n\r\nWith ENet, every packet can be:\r\nReliable/Unreliable (will be resent or not)\r\nSequenced/Unsequenced (order will be enforced, or not)\r\n\r\nA **reliable** (RS) packet MUST be sequenced, will **stall other sequenced packet** on the same channel.\r\nAn **unreliable but sequenced** (US) packet will always be **delivered in order** (if delivered at all). **Will be stalled** by undelivered reliable packets on the same channel.\r\nAn **unreliable and unsequenced** (UU) packet **will not be stalled** by other packets.\r\n\r\nWith this patch reliable and unreliable packets will use two different channels yay!\r\n\r\nSince all unreliable-but-sequenced (US) packets will always share the same channel (and thus sequencing) out-of-order packets will be dropped even if they reference different rpc calls.\r\n\r\n```\r\neg:\r\nRECV: 1-\"set_pos\", // GOOD\r\nRECV: 3-\"set_pos\", // GOOD\r\nRECV: 2-\"set_vel\" // DROPPED\r\n```\r\n\r\nThis makes the UNRELIABLE_ORDERED mode pretty much **useless**.\r\n\r\nThis will force people that want to optimize latency to implement their own timing over unreliable-and-unsequenced (UU) packets.\r\n\r\n**I still strongly reccomend allowing the developers to select the channel when sending RPCs.**","created_at":"2016-09-30T01:01:47Z","updated_at":"2016-09-30T01:01:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/godotengine/godot/pulls/6657/commits","review_comments_url":"https://api.github.com/repos/godotengine/godot/pulls/6657/comments","review_comment_url":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/godotengine/godot/issues/6657/comments","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/8b9e5453a57e873d43d748d9acf16be4b7a1aa19","head":{"label":"Faless:multi_channel_rpc","ref":"multi_channel_rpc","sha":"8b9e5453a57e873d43d748d9acf16be4b7a1aa19","user":{"login":"Faless","id":1687918,"avatar_url":"https://avatars.githubusercontent.com/u/1687918?v=3","gravatar_id":"","url":"https://api.github.com/users/Faless","html_url":"https://github.com/Faless","followers_url":"https://api.github.com/users/Faless/followers","following_url":"https://api.github.com/users/Faless/following{/other_user}","gists_url":"https://api.github.com/users/Faless/gists{/gist_id}","starred_url":"https://api.github.com/users/Faless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Faless/subscriptions","organizations_url":"https://api.github.com/users/Faless/orgs","repos_url":"https://api.github.com/users/Faless/repos","events_url":"https://api.github.com/users/Faless/events{/privacy}","received_events_url":"https://api.github.com/users/Faless/received_events","type":"User","site_admin":false},"repo":{"id":32279486,"name":"godot","full_name":"Faless/godot","owner":{"login":"Faless","id":1687918,"avatar_url":"https://avatars.githubusercontent.com/u/1687918?v=3","gravatar_id":"","url":"https://api.github.com/users/Faless","html_url":"https://github.com/Faless","followers_url":"https://api.github.com/users/Faless/followers","following_url":"https://api.github.com/users/Faless/following{/other_user}","gists_url":"https://api.github.com/users/Faless/gists{/gist_id}","starred_url":"https://api.github.com/users/Faless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Faless/subscriptions","organizations_url":"https://api.github.com/users/Faless/orgs","repos_url":"https://api.github.com/users/Faless/repos","events_url":"https://api.github.com/users/Faless/events{/privacy}","received_events_url":"https://api.github.com/users/Faless/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Faless/godot","description":"Godot Game Engine","fork":true,"url":"https://api.github.com/repos/Faless/godot","forks_url":"https://api.github.com/repos/Faless/godot/forks","keys_url":"https://api.github.com/repos/Faless/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Faless/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Faless/godot/teams","hooks_url":"https://api.github.com/repos/Faless/godot/hooks","issue_events_url":"https://api.github.com/repos/Faless/godot/issues/events{/number}","events_url":"https://api.github.com/repos/Faless/godot/events","assignees_url":"https://api.github.com/repos/Faless/godot/assignees{/user}","branches_url":"https://api.github.com/repos/Faless/godot/branches{/branch}","tags_url":"https://api.github.com/repos/Faless/godot/tags","blobs_url":"https://api.github.com/repos/Faless/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Faless/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Faless/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/Faless/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Faless/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/Faless/godot/languages","stargazers_url":"https://api.github.com/repos/Faless/godot/stargazers","contributors_url":"https://api.github.com/repos/Faless/godot/contributors","subscribers_url":"https://api.github.com/repos/Faless/godot/subscribers","subscription_url":"https://api.github.com/repos/Faless/godot/subscription","commits_url":"https://api.github.com/repos/Faless/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/Faless/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/Faless/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/Faless/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/Faless/godot/contents/{+path}","compare_url":"https://api.github.com/repos/Faless/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Faless/godot/merges","archive_url":"https://api.github.com/repos/Faless/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Faless/godot/downloads","issues_url":"https://api.github.com/repos/Faless/godot/issues{/number}","pulls_url":"https://api.github.com/repos/Faless/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/Faless/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/Faless/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Faless/godot/labels{/name}","releases_url":"https://api.github.com/repos/Faless/godot/releases{/id}","deployments_url":"https://api.github.com/repos/Faless/godot/deployments","created_at":"2015-03-15T19:28:19Z","updated_at":"2015-04-29T11:45:36Z","pushed_at":"2016-09-30T00:48:47Z","git_url":"git://github.com/Faless/godot.git","ssh_url":"git@github.com:Faless/godot.git","clone_url":"https://github.com/Faless/godot.git","svn_url":"https://github.com/Faless/godot","homepage":null,"size":106808,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"godotengine:master","ref":"master","sha":"cb7661df942cfb423c5fe5090c1c114489905c34","user":{"login":"godotengine","id":6318500,"avatar_url":"https://avatars.githubusercontent.com/u/6318500?v=3","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"repo":{"id":15634981,"name":"godot","full_name":"godotengine/godot","owner":{"login":"godotengine","id":6318500,"avatar_url":"https://avatars.githubusercontent.com/u/6318500?v=3","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/godotengine/godot","description":"Godot Engine – Multi-platform 2D and 3D game engine","fork":false,"url":"https://api.github.com/repos/godotengine/godot","forks_url":"https://api.github.com/repos/godotengine/godot/forks","keys_url":"https://api.github.com/repos/godotengine/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/godotengine/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/godotengine/godot/teams","hooks_url":"https://api.github.com/repos/godotengine/godot/hooks","issue_events_url":"https://api.github.com/repos/godotengine/godot/issues/events{/number}","events_url":"https://api.github.com/repos/godotengine/godot/events","assignees_url":"https://api.github.com/repos/godotengine/godot/assignees{/user}","branches_url":"https://api.github.com/repos/godotengine/godot/branches{/branch}","tags_url":"https://api.github.com/repos/godotengine/godot/tags","blobs_url":"https://api.github.com/repos/godotengine/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/godotengine/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/godotengine/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/godotengine/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/godotengine/godot/languages","stargazers_url":"https://api.github.com/repos/godotengine/godot/stargazers","contributors_url":"https://api.github.com/repos/godotengine/godot/contributors","subscribers_url":"https://api.github.com/repos/godotengine/godot/subscribers","subscription_url":"https://api.github.com/repos/godotengine/godot/subscription","commits_url":"https://api.github.com/repos/godotengine/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/godotengine/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/godotengine/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/godotengine/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/godotengine/godot/contents/{+path}","compare_url":"https://api.github.com/repos/godotengine/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/godotengine/godot/merges","archive_url":"https://api.github.com/repos/godotengine/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/godotengine/godot/downloads","issues_url":"https://api.github.com/repos/godotengine/godot/issues{/number}","pulls_url":"https://api.github.com/repos/godotengine/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/godotengine/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/godotengine/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/godotengine/godot/labels{/name}","releases_url":"https://api.github.com/repos/godotengine/godot/releases{/id}","deployments_url":"https://api.github.com/repos/godotengine/godot/deployments","created_at":"2014-01-04T16:05:36Z","updated_at":"2016-09-29T20:18:50Z","pushed_at":"2016-09-29T18:29:34Z","git_url":"git://github.com/godotengine/godot.git","ssh_url":"git@github.com:godotengine/godot.git","clone_url":"https://github.com/godotengine/godot.git","svn_url":"https://github.com/godotengine/godot","homepage":"https://godotengine.org","size":153726,"stargazers_count":6656,"watchers_count":6656,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1731,"mirror_url":null,"open_issues_count":1419,"forks":1731,"open_issues":1419,"watchers":6656,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/godotengine/godot/pulls/6657"},"html":{"href":"https://github.com/godotengine/godot/pull/6657"},"issue":{"href":"https://api.github.com/repos/godotengine/godot/issues/6657"},"comments":{"href":"https://api.github.com/repos/godotengine/godot/issues/6657/comments"},"review_comments":{"href":"https://api.github.com/repos/godotengine/godot/pulls/6657/comments"},"review_comment":{"href":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/godotengine/godot/pulls/6657/commits"},"statuses":{"href":"https://api.github.com/repos/godotengine/godot/statuses/8b9e5453a57e873d43d748d9acf16be4b7a1aa19"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":27,"deletions":16,"changed_files":2}}
{"actor":{"display_login":"Faless"}}