{"action":"created","comment":{"url":"https://api.github.com/repos/python-hyper/hyper-h2/pulls/comments/85482046","pull_request_review_id":6196004,"id":85482046,"diff_hunk":"@@ -317,3 +320,26 @@ def test_alternativeserviceavailable_repr(self):\n             '<AlternativeServiceAvailable origin:example.com, '\n             'field_value:h2=\":8000\"; ma=60>'\n         )\n+\n+\n+def all_events():\n+    \"\"\"\n+    Generates all the classes (i.e., events) defined in h2.events.\n+    \"\"\"\n+    for _, obj in inspect.getmembers(sys.modules['h2.events']):\n+\n+        # We are only interested in objects that are defined in h2.events;\n+        # objects that are imported from other modules are not of interest.\n+        if hasattr(obj, '__module__') and (obj.__module__ != 'h2.events'):\n+            continue\n+\n+        if inspect.isclass(obj):\n+            yield obj\n+\n+\n+@pytest.mark.parametrize('event', all_events())\n+def test_all_events_subclass_from_event(event):\n+    \"\"\"\n+    Every event defined in h2.events subclasses from h2.events.Event.\n+    \"\"\"\n+    assert (event == h2.events.Event) or issubclass(event, h2.events.Event)","path":"test/test_events.py","position":36,"original_position":36,"commit_id":"b50db85c610b7d1fbd8207f631fe910724e7016d","original_commit_id":"b50db85c610b7d1fbd8207f631fe910724e7016d","user":{"login":"Lukasa","id":1382556,"avatar_url":"https://avatars.githubusercontent.com/u/1382556?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukasa","html_url":"https://github.com/Lukasa","followers_url":"https://api.github.com/users/Lukasa/followers","following_url":"https://api.github.com/users/Lukasa/following{/other_user}","gists_url":"https://api.github.com/users/Lukasa/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukasa/subscriptions","organizations_url":"https://api.github.com/users/Lukasa/orgs","repos_url":"https://api.github.com/users/Lukasa/repos","events_url":"https://api.github.com/users/Lukasa/events{/privacy}","received_events_url":"https://api.github.com/users/Lukasa/received_events","type":"User","site_admin":false},"body":"Let's test identity, not equality.","created_at":"2016-10-28T07:15:44Z","updated_at":"2016-10-28T07:15:44Z","html_url":"https://github.com/python-hyper/hyper-h2/pull/370#discussion_r85482046","pull_request_url":"https://api.github.com/repos/python-hyper/hyper-h2/pulls/370","_links":{"self":{"href":"https://api.github.com/repos/python-hyper/hyper-h2/pulls/comments/85482046"},"html":{"href":"https://github.com/python-hyper/hyper-h2/pull/370#discussion_r85482046"},"pull_request":{"href":"https://api.github.com/repos/python-hyper/hyper-h2/pulls/370"}}},"pull_request":{"url":"https://api.github.com/repos/python-hyper/hyper-h2/pulls/370","id":91269408,"html_url":"https://github.com/python-hyper/hyper-h2/pull/370","diff_url":"https://github.com/python-hyper/hyper-h2/pull/370.diff","patch_url":"https://github.com/python-hyper/hyper-h2/pull/370.patch","issue_url":"https://api.github.com/repos/python-hyper/hyper-h2/issues/370","number":370,"state":"open","locked":false,"title":"Add a no-op base class for events","user":{"login":"alexwlchan","id":301220,"avatar_url":"https://avatars.githubusercontent.com/u/301220?v=3","gravatar_id":"","url":"https://api.github.com/users/alexwlchan","html_url":"https://github.com/alexwlchan","followers_url":"https://api.github.com/users/alexwlchan/followers","following_url":"https://api.github.com/users/alexwlchan/following{/other_user}","gists_url":"https://api.github.com/users/alexwlchan/gists{/gist_id}","starred_url":"https://api.github.com/users/alexwlchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexwlchan/subscriptions","organizations_url":"https://api.github.com/users/alexwlchan/orgs","repos_url":"https://api.github.com/users/alexwlchan/repos","events_url":"https://api.github.com/users/alexwlchan/events{/privacy}","received_events_url":"https://api.github.com/users/alexwlchan/received_events","type":"User","site_admin":false},"body":"Fixes #369","created_at":"2016-10-27T19:56:12Z","updated_at":"2016-10-28T07:15:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e46bd7746471bdac42972485e2fa1ad28db2a0cb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/python-hyper/hyper-h2/pulls/370/commits","review_comments_url":"https://api.github.com/repos/python-hyper/hyper-h2/pulls/370/comments","review_comment_url":"https://api.github.com/repos/python-hyper/hyper-h2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python-hyper/hyper-h2/issues/370/comments","statuses_url":"https://api.github.com/repos/python-hyper/hyper-h2/statuses/b50db85c610b7d1fbd8207f631fe910724e7016d","head":{"label":"python-hyper:awlc/events","ref":"awlc/events","sha":"b50db85c610b7d1fbd8207f631fe910724e7016d","user":{"login":"python-hyper","id":13035907,"avatar_url":"https://avatars.githubusercontent.com/u/13035907?v=3","gravatar_id":"","url":"https://api.github.com/users/python-hyper","html_url":"https://github.com/python-hyper","followers_url":"https://api.github.com/users/python-hyper/followers","following_url":"https://api.github.com/users/python-hyper/following{/other_user}","gists_url":"https://api.github.com/users/python-hyper/gists{/gist_id}","starred_url":"https://api.github.com/users/python-hyper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-hyper/subscriptions","organizations_url":"https://api.github.com/users/python-hyper/orgs","repos_url":"https://api.github.com/users/python-hyper/repos","events_url":"https://api.github.com/users/python-hyper/events{/privacy}","received_events_url":"https://api.github.com/users/python-hyper/received_events","type":"Organization","site_admin":false},"repo":{"id":37996233,"name":"hyper-h2","full_name":"python-hyper/hyper-h2","owner":{"login":"python-hyper","id":13035907,"avatar_url":"https://avatars.githubusercontent.com/u/13035907?v=3","gravatar_id":"","url":"https://api.github.com/users/python-hyper","html_url":"https://github.com/python-hyper","followers_url":"https://api.github.com/users/python-hyper/followers","following_url":"https://api.github.com/users/python-hyper/following{/other_user}","gists_url":"https://api.github.com/users/python-hyper/gists{/gist_id}","starred_url":"https://api.github.com/users/python-hyper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-hyper/subscriptions","organizations_url":"https://api.github.com/users/python-hyper/orgs","repos_url":"https://api.github.com/users/python-hyper/repos","events_url":"https://api.github.com/users/python-hyper/events{/privacy}","received_events_url":"https://api.github.com/users/python-hyper/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python-hyper/hyper-h2","description":"HTTP/2 State-Machine based protocol implementation","fork":false,"url":"https://api.github.com/repos/python-hyper/hyper-h2","forks_url":"https://api.github.com/repos/python-hyper/hyper-h2/forks","keys_url":"https://api.github.com/repos/python-hyper/hyper-h2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python-hyper/hyper-h2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python-hyper/hyper-h2/teams","hooks_url":"https://api.github.com/repos/python-hyper/hyper-h2/hooks","issue_events_url":"https://api.github.com/repos/python-hyper/hyper-h2/issues/events{/number}","events_url":"https://api.github.com/repos/python-hyper/hyper-h2/events","assignees_url":"https://api.github.com/repos/python-hyper/hyper-h2/assignees{/user}","branches_url":"https://api.github.com/repos/python-hyper/hyper-h2/branches{/branch}","tags_url":"https://api.github.com/repos/python-hyper/hyper-h2/tags","blobs_url":"https://api.github.com/repos/python-hyper/hyper-h2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python-hyper/hyper-h2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python-hyper/hyper-h2/git/refs{/sha}","trees_url":"https://api.github.com/repos/python-hyper/hyper-h2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python-hyper/hyper-h2/statuses/{sha}","languages_url":"https://api.github.com/repos/python-hyper/hyper-h2/languages","stargazers_url":"https://api.github.com/repos/python-hyper/hyper-h2/stargazers","contributors_url":"https://api.github.com/repos/python-hyper/hyper-h2/contributors","subscribers_url":"https://api.github.com/repos/python-hyper/hyper-h2/subscribers","subscription_url":"https://api.github.com/repos/python-hyper/hyper-h2/subscription","commits_url":"https://api.github.com/repos/python-hyper/hyper-h2/commits{/sha}","git_commits_url":"https://api.github.com/repos/python-hyper/hyper-h2/git/commits{/sha}","comments_url":"https://api.github.com/repos/python-hyper/hyper-h2/comments{/number}","issue_comment_url":"https://api.github.com/repos/python-hyper/hyper-h2/issues/comments{/number}","contents_url":"https://api.github.com/repos/python-hyper/hyper-h2/contents/{+path}","compare_url":"https://api.github.com/repos/python-hyper/hyper-h2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python-hyper/hyper-h2/merges","archive_url":"https://api.github.com/repos/python-hyper/hyper-h2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python-hyper/hyper-h2/downloads","issues_url":"https://api.github.com/repos/python-hyper/hyper-h2/issues{/number}","pulls_url":"https://api.github.com/repos/python-hyper/hyper-h2/pulls{/number}","milestones_url":"https://api.github.com/repos/python-hyper/hyper-h2/milestones{/number}","notifications_url":"https://api.github.com/repos/python-hyper/hyper-h2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python-hyper/hyper-h2/labels{/name}","releases_url":"https://api.github.com/repos/python-hyper/hyper-h2/releases{/id}","deployments_url":"https://api.github.com/repos/python-hyper/hyper-h2/deployments","created_at":"2015-06-24T16:22:19Z","updated_at":"2016-10-26T23:10:19Z","pushed_at":"2016-10-27T20:11:02Z","git_url":"git://github.com/python-hyper/hyper-h2.git","ssh_url":"git@github.com:python-hyper/hyper-h2.git","clone_url":"https://github.com/python-hyper/hyper-h2.git","svn_url":"https://github.com/python-hyper/hyper-h2","homepage":"http://python-hyper.org/h2/","size":1269,"stargazers_count":193,"watchers_count":193,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":23,"forks":41,"open_issues":23,"watchers":193,"default_branch":"master"}},"base":{"label":"python-hyper:master","ref":"master","sha":"d8841f118448b74d9e786b86b1164c4a9b94a72e","user":{"login":"python-hyper","id":13035907,"avatar_url":"https://avatars.githubusercontent.com/u/13035907?v=3","gravatar_id":"","url":"https://api.github.com/users/python-hyper","html_url":"https://github.com/python-hyper","followers_url":"https://api.github.com/users/python-hyper/followers","following_url":"https://api.github.com/users/python-hyper/following{/other_user}","gists_url":"https://api.github.com/users/python-hyper/gists{/gist_id}","starred_url":"https://api.github.com/users/python-hyper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-hyper/subscriptions","organizations_url":"https://api.github.com/users/python-hyper/orgs","repos_url":"https://api.github.com/users/python-hyper/repos","events_url":"https://api.github.com/users/python-hyper/events{/privacy}","received_events_url":"https://api.github.com/users/python-hyper/received_events","type":"Organization","site_admin":false},"repo":{"id":37996233,"name":"hyper-h2","full_name":"python-hyper/hyper-h2","owner":{"login":"python-hyper","id":13035907,"avatar_url":"https://avatars.githubusercontent.com/u/13035907?v=3","gravatar_id":"","url":"https://api.github.com/users/python-hyper","html_url":"https://github.com/python-hyper","followers_url":"https://api.github.com/users/python-hyper/followers","following_url":"https://api.github.com/users/python-hyper/following{/other_user}","gists_url":"https://api.github.com/users/python-hyper/gists{/gist_id}","starred_url":"https://api.github.com/users/python-hyper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-hyper/subscriptions","organizations_url":"https://api.github.com/users/python-hyper/orgs","repos_url":"https://api.github.com/users/python-hyper/repos","events_url":"https://api.github.com/users/python-hyper/events{/privacy}","received_events_url":"https://api.github.com/users/python-hyper/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python-hyper/hyper-h2","description":"HTTP/2 State-Machine based protocol implementation","fork":false,"url":"https://api.github.com/repos/python-hyper/hyper-h2","forks_url":"https://api.github.com/repos/python-hyper/hyper-h2/forks","keys_url":"https://api.github.com/repos/python-hyper/hyper-h2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python-hyper/hyper-h2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python-hyper/hyper-h2/teams","hooks_url":"https://api.github.com/repos/python-hyper/hyper-h2/hooks","issue_events_url":"https://api.github.com/repos/python-hyper/hyper-h2/issues/events{/number}","events_url":"https://api.github.com/repos/python-hyper/hyper-h2/events","assignees_url":"https://api.github.com/repos/python-hyper/hyper-h2/assignees{/user}","branches_url":"https://api.github.com/repos/python-hyper/hyper-h2/branches{/branch}","tags_url":"https://api.github.com/repos/python-hyper/hyper-h2/tags","blobs_url":"https://api.github.com/repos/python-hyper/hyper-h2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python-hyper/hyper-h2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python-hyper/hyper-h2/git/refs{/sha}","trees_url":"https://api.github.com/repos/python-hyper/hyper-h2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python-hyper/hyper-h2/statuses/{sha}","languages_url":"https://api.github.com/repos/python-hyper/hyper-h2/languages","stargazers_url":"https://api.github.com/repos/python-hyper/hyper-h2/stargazers","contributors_url":"https://api.github.com/repos/python-hyper/hyper-h2/contributors","subscribers_url":"https://api.github.com/repos/python-hyper/hyper-h2/subscribers","subscription_url":"https://api.github.com/repos/python-hyper/hyper-h2/subscription","commits_url":"https://api.github.com/repos/python-hyper/hyper-h2/commits{/sha}","git_commits_url":"https://api.github.com/repos/python-hyper/hyper-h2/git/commits{/sha}","comments_url":"https://api.github.com/repos/python-hyper/hyper-h2/comments{/number}","issue_comment_url":"https://api.github.com/repos/python-hyper/hyper-h2/issues/comments{/number}","contents_url":"https://api.github.com/repos/python-hyper/hyper-h2/contents/{+path}","compare_url":"https://api.github.com/repos/python-hyper/hyper-h2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python-hyper/hyper-h2/merges","archive_url":"https://api.github.com/repos/python-hyper/hyper-h2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python-hyper/hyper-h2/downloads","issues_url":"https://api.github.com/repos/python-hyper/hyper-h2/issues{/number}","pulls_url":"https://api.github.com/repos/python-hyper/hyper-h2/pulls{/number}","milestones_url":"https://api.github.com/repos/python-hyper/hyper-h2/milestones{/number}","notifications_url":"https://api.github.com/repos/python-hyper/hyper-h2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python-hyper/hyper-h2/labels{/name}","releases_url":"https://api.github.com/repos/python-hyper/hyper-h2/releases{/id}","deployments_url":"https://api.github.com/repos/python-hyper/hyper-h2/deployments","created_at":"2015-06-24T16:22:19Z","updated_at":"2016-10-26T23:10:19Z","pushed_at":"2016-10-27T20:11:02Z","git_url":"git://github.com/python-hyper/hyper-h2.git","ssh_url":"git@github.com:python-hyper/hyper-h2.git","clone_url":"https://github.com/python-hyper/hyper-h2.git","svn_url":"https://github.com/python-hyper/hyper-h2","homepage":"http://python-hyper.org/h2/","size":1269,"stargazers_count":193,"watchers_count":193,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":23,"forks":41,"open_issues":23,"watchers":193,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python-hyper/hyper-h2/pulls/370"},"html":{"href":"https://github.com/python-hyper/hyper-h2/pull/370"},"issue":{"href":"https://api.github.com/repos/python-hyper/hyper-h2/issues/370"},"comments":{"href":"https://api.github.com/repos/python-hyper/hyper-h2/issues/370/comments"},"review_comments":{"href":"https://api.github.com/repos/python-hyper/hyper-h2/pulls/370/comments"},"review_comment":{"href":"https://api.github.com/repos/python-hyper/hyper-h2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python-hyper/hyper-h2/pulls/370/commits"},"statuses":{"href":"https://api.github.com/repos/python-hyper/hyper-h2/statuses/b50db85c610b7d1fbd8207f631fe910724e7016d"}}}}
{"actor":{"display_login":"Lukasa"}}