{"action":"created","comment":{"url":"https://api.github.com/repos/jitsi/jitsi-meet-react/pulls/comments/70934486","id":70934486,"diff_hunk":"@@ -42,13 +43,26 @@ export class Video extends Component {\n             let style = styles.video;\n             let objectFit = (style && style.objectFit) || 'cover';\n \n-            return (\n+            let video = (\n                 <RTCView\n                     objectFit={ objectFit }\n                     streamURL={ streamURL }\n                     style={ style }\n                 />\n             );\n+\n+            // XXX RTCView does not currently support mirroring for local\n+            // videos, even when providing a transform style property.\n+            // We can achieve the same effect by wrapping the RTCView inside of\n+            // another View, and applying the transform style property to that\n+            // View instead.\n+            if (this.props.mirror) {\n+                return (\n+                    <View style={ styles.mirroredVideo }>{video}</View>","path":"features/base/media/components/native/Video.js","position":26,"original_position":26,"commit_id":"3be8d3ffe0c7b70dc1230ec75a00bd20a878befc","original_commit_id":"3be8d3ffe0c7b70dc1230ec75a00bd20a878befc","user":{"login":"tsareg","id":1167285,"avatar_url":"https://avatars.githubusercontent.com/u/1167285?v=3","gravatar_id":"","url":"https://api.github.com/users/tsareg","html_url":"https://github.com/tsareg","followers_url":"https://api.github.com/users/tsareg/followers","following_url":"https://api.github.com/users/tsareg/following{/other_user}","gists_url":"https://api.github.com/users/tsareg/gists{/gist_id}","starred_url":"https://api.github.com/users/tsareg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsareg/subscriptions","organizations_url":"https://api.github.com/users/tsareg/orgs","repos_url":"https://api.github.com/users/tsareg/repos","events_url":"https://api.github.com/users/tsareg/events{/privacy}","received_events_url":"https://api.github.com/users/tsareg/received_events","type":"User","site_admin":false},"body":"If we have such composition, I'd extract rendering of this view, and rendering of <RTCView> into two private method, e.g. ```_renderVideoElement``` and ```_renderWrappedVideoElement``` and then call them from ```render```. WDYT?","created_at":"2016-07-15T07:56:04Z","updated_at":"2016-07-15T07:56:04Z","html_url":"https://github.com/jitsi/jitsi-meet-react/pull/52#discussion_r70934486","pull_request_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/jitsi/jitsi-meet-react/pulls/comments/70934486"},"html":{"href":"https://github.com/jitsi/jitsi-meet-react/pull/52#discussion_r70934486"},"pull_request":{"href":"https://api.github.com/repos/jitsi/jitsi-meet-react/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/jitsi/jitsi-meet-react/pulls/52","id":77575807,"html_url":"https://github.com/jitsi/jitsi-meet-react/pull/52","diff_url":"https://github.com/jitsi/jitsi-meet-react/pull/52.diff","patch_url":"https://github.com/jitsi/jitsi-meet-react/pull/52.patch","issue_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/issues/52","number":52,"state":"open","locked":false,"title":"Mirror local videos in the stage and in thumbnails.","user":{"login":"legastero","id":38435,"avatar_url":"https://avatars.githubusercontent.com/u/38435?v=3","gravatar_id":"","url":"https://api.github.com/users/legastero","html_url":"https://github.com/legastero","followers_url":"https://api.github.com/users/legastero/followers","following_url":"https://api.github.com/users/legastero/following{/other_user}","gists_url":"https://api.github.com/users/legastero/gists{/gist_id}","starred_url":"https://api.github.com/users/legastero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legastero/subscriptions","organizations_url":"https://api.github.com/users/legastero/orgs","repos_url":"https://api.github.com/users/legastero/repos","events_url":"https://api.github.com/users/legastero/events{/privacy}","received_events_url":"https://api.github.com/users/legastero/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-15T07:44:11Z","updated_at":"2016-07-15T07:56:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4ff3c01e9e27e85a5658c96ed0776fb2257ffbe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/pulls/52/commits","review_comments_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/pulls/52/comments","review_comment_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/issues/52/comments","statuses_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/statuses/3be8d3ffe0c7b70dc1230ec75a00bd20a878befc","head":{"label":"legastero:flip-local-video","ref":"flip-local-video","sha":"3be8d3ffe0c7b70dc1230ec75a00bd20a878befc","user":{"login":"legastero","id":38435,"avatar_url":"https://avatars.githubusercontent.com/u/38435?v=3","gravatar_id":"","url":"https://api.github.com/users/legastero","html_url":"https://github.com/legastero","followers_url":"https://api.github.com/users/legastero/followers","following_url":"https://api.github.com/users/legastero/following{/other_user}","gists_url":"https://api.github.com/users/legastero/gists{/gist_id}","starred_url":"https://api.github.com/users/legastero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legastero/subscriptions","organizations_url":"https://api.github.com/users/legastero/orgs","repos_url":"https://api.github.com/users/legastero/repos","events_url":"https://api.github.com/users/legastero/events{/privacy}","received_events_url":"https://api.github.com/users/legastero/received_events","type":"User","site_admin":false},"repo":{"id":60594443,"name":"jitsi-meet-react","full_name":"legastero/jitsi-meet-react","owner":{"login":"legastero","id":38435,"avatar_url":"https://avatars.githubusercontent.com/u/38435?v=3","gravatar_id":"","url":"https://api.github.com/users/legastero","html_url":"https://github.com/legastero","followers_url":"https://api.github.com/users/legastero/followers","following_url":"https://api.github.com/users/legastero/following{/other_user}","gists_url":"https://api.github.com/users/legastero/gists{/gist_id}","starred_url":"https://api.github.com/users/legastero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legastero/subscriptions","organizations_url":"https://api.github.com/users/legastero/orgs","repos_url":"https://api.github.com/users/legastero/repos","events_url":"https://api.github.com/users/legastero/events{/privacy}","received_events_url":"https://api.github.com/users/legastero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/legastero/jitsi-meet-react","description":"","fork":true,"url":"https://api.github.com/repos/legastero/jitsi-meet-react","forks_url":"https://api.github.com/repos/legastero/jitsi-meet-react/forks","keys_url":"https://api.github.com/repos/legastero/jitsi-meet-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/legastero/jitsi-meet-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/legastero/jitsi-meet-react/teams","hooks_url":"https://api.github.com/repos/legastero/jitsi-meet-react/hooks","issue_events_url":"https://api.github.com/repos/legastero/jitsi-meet-react/issues/events{/number}","events_url":"https://api.github.com/repos/legastero/jitsi-meet-react/events","assignees_url":"https://api.github.com/repos/legastero/jitsi-meet-react/assignees{/user}","branches_url":"https://api.github.com/repos/legastero/jitsi-meet-react/branches{/branch}","tags_url":"https://api.github.com/repos/legastero/jitsi-meet-react/tags","blobs_url":"https://api.github.com/repos/legastero/jitsi-meet-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/legastero/jitsi-meet-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/legastero/jitsi-meet-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/legastero/jitsi-meet-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/legastero/jitsi-meet-react/statuses/{sha}","languages_url":"https://api.github.com/repos/legastero/jitsi-meet-react/languages","stargazers_url":"https://api.github.com/repos/legastero/jitsi-meet-react/stargazers","contributors_url":"https://api.github.com/repos/legastero/jitsi-meet-react/contributors","subscribers_url":"https://api.github.com/repos/legastero/jitsi-meet-react/subscribers","subscription_url":"https://api.github.com/repos/legastero/jitsi-meet-react/subscription","commits_url":"https://api.github.com/repos/legastero/jitsi-meet-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/legastero/jitsi-meet-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/legastero/jitsi-meet-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/legastero/jitsi-meet-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/legastero/jitsi-meet-react/contents/{+path}","compare_url":"https://api.github.com/repos/legastero/jitsi-meet-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/legastero/jitsi-meet-react/merges","archive_url":"https://api.github.com/repos/legastero/jitsi-meet-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/legastero/jitsi-meet-react/downloads","issues_url":"https://api.github.com/repos/legastero/jitsi-meet-react/issues{/number}","pulls_url":"https://api.github.com/repos/legastero/jitsi-meet-react/pulls{/number}","milestones_url":"https://api.github.com/repos/legastero/jitsi-meet-react/milestones{/number}","notifications_url":"https://api.github.com/repos/legastero/jitsi-meet-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/legastero/jitsi-meet-react/labels{/name}","releases_url":"https://api.github.com/repos/legastero/jitsi-meet-react/releases{/id}","deployments_url":"https://api.github.com/repos/legastero/jitsi-meet-react/deployments","created_at":"2016-06-07T08:06:45Z","updated_at":"2016-06-07T08:07:20Z","pushed_at":"2016-07-15T07:31:12Z","git_url":"git://github.com/legastero/jitsi-meet-react.git","ssh_url":"git@github.com:legastero/jitsi-meet-react.git","clone_url":"https://github.com/legastero/jitsi-meet-react.git","svn_url":"https://github.com/legastero/jitsi-meet-react","homepage":null,"size":1099,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jitsi:master","ref":"master","sha":"482217c0b0dd3d62692f221c49efc60bc0e4cfc1","user":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":60539982,"name":"jitsi-meet-react","full_name":"jitsi/jitsi-meet-react","owner":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jitsi/jitsi-meet-react","description":"","fork":false,"url":"https://api.github.com/repos/jitsi/jitsi-meet-react","forks_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/forks","keys_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/teams","hooks_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/hooks","issue_events_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/events","assignees_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/tags","blobs_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/languages","stargazers_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/stargazers","contributors_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/contributors","subscribers_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/subscribers","subscription_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/subscription","commits_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/merges","archive_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/downloads","issues_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/releases{/id}","deployments_url":"https://api.github.com/repos/jitsi/jitsi-meet-react/deployments","created_at":"2016-06-06T15:40:42Z","updated_at":"2016-07-14T22:41:04Z","pushed_at":"2016-07-15T07:51:26Z","git_url":"git://github.com/jitsi/jitsi-meet-react.git","ssh_url":"git@github.com:jitsi/jitsi-meet-react.git","clone_url":"https://github.com/jitsi/jitsi-meet-react.git","svn_url":"https://github.com/jitsi/jitsi-meet-react","homepage":null,"size":1275,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":7,"forks":4,"open_issues":7,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jitsi/jitsi-meet-react/pulls/52"},"html":{"href":"https://github.com/jitsi/jitsi-meet-react/pull/52"},"issue":{"href":"https://api.github.com/repos/jitsi/jitsi-meet-react/issues/52"},"comments":{"href":"https://api.github.com/repos/jitsi/jitsi-meet-react/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/jitsi/jitsi-meet-react/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/jitsi/jitsi-meet-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jitsi/jitsi-meet-react/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/jitsi/jitsi-meet-react/statuses/3be8d3ffe0c7b70dc1230ec75a00bd20a878befc"}}}}
{"actor":{"display_login":"tsareg"}}