{"action":"created","issue":{"url":"https://api.github.com/repos/start-jsk/jsk_mbzirc/issues/68","repository_url":"https://api.github.com/repos/start-jsk/jsk_mbzirc","labels_url":"https://api.github.com/repos/start-jsk/jsk_mbzirc/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/start-jsk/jsk_mbzirc/issues/68/comments","events_url":"https://api.github.com/repos/start-jsk/jsk_mbzirc/issues/68/events","html_url":"https://github.com/start-jsk/jsk_mbzirc/pull/68","id":150322063,"number":68,"title":"[jsk_mbzirc] enable roslint on testing","user":{"login":"furushchev","id":1901008,"avatar_url":"https://avatars.githubusercontent.com/u/1901008?v=3","gravatar_id":"","url":"https://api.github.com/users/furushchev","html_url":"https://github.com/furushchev","followers_url":"https://api.github.com/users/furushchev/followers","following_url":"https://api.github.com/users/furushchev/following{/other_user}","gists_url":"https://api.github.com/users/furushchev/gists{/gist_id}","starred_url":"https://api.github.com/users/furushchev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/furushchev/subscriptions","organizations_url":"https://api.github.com/users/furushchev/orgs","repos_url":"https://api.github.com/users/furushchev/repos","events_url":"https://api.github.com/users/furushchev/events{/privacy}","received_events_url":"https://api.github.com/users/furushchev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-04-22T09:36:52Z","updated_at":"2016-05-06T13:33:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/start-jsk/jsk_mbzirc/pulls/68","html_url":"https://github.com/start-jsk/jsk_mbzirc/pull/68","diff_url":"https://github.com/start-jsk/jsk_mbzirc/pull/68.diff","patch_url":"https://github.com/start-jsk/jsk_mbzirc/pull/68.patch"},"body":"@tongtybj あとはお願いします。。\r\nもう少し詳しく・・・\r\nこのPRのテストは現時点で必ずfailします。\r\nバクイさんの手元で\r\n\r\n```bash\r\nroscd jsk_mbzirc_common\r\ncd ..\r\ngit remote add furushchev https://github.com/furushchev/jsk_mbzirc\r\ngit fetch furushchev\r\ngit checkout add-roslint\r\n```\r\n\r\nをするとこのPRのブランチになります。\r\nこのディレクトリで\r\n\r\n```bash\r\nsudo apt-get install ros-indigo-roslint # 必要な場合\r\nrosrun roslint cpplint $(find . -iname \"*.h\")\r\nrosrun roslint cpplint $(find . -iname \"*.cpp\")\r\nrosrun roslint pep8 $(find . -iname \"*.py\")\r\n```\r\n\r\nとすると要改善点が列挙されるので、直して、僕のブランチにPRしてください。\r\n\r\n僕のブランチへのPRの作り方は\r\n\r\n```\r\ngit push tongtybj add-roslint\r\n```\r\n\r\nして、githubの画面を見ると`Create Pullrequest`があるはずです。\r\n`Compare Changes`というタイトルの画面になるので、`Base fork`を`furushchev/jsk_mbzirc` `add-roslint`にしてPRを作成すればOKです。\r\n\r\n<img width=\"461\" alt=\"2016-04-22 18 47 08\" src=\"https://cloud.githubusercontent.com/assets/1901008/14738094/ae609c22-08ba-11e6-9559-a90484cf35b3.png\">\r\n\r\n`CMakeLists.txt`は`catkin lint`をするか@k-okada lintをするというのでいいのではないでしょうか。"},"comment":{"url":"https://api.github.com/repos/start-jsk/jsk_mbzirc/issues/comments/217441843","html_url":"https://github.com/start-jsk/jsk_mbzirc/pull/68#issuecomment-217441843","issue_url":"https://api.github.com/repos/start-jsk/jsk_mbzirc/issues/68","id":217441843,"user":{"login":"furushchev","id":1901008,"avatar_url":"https://avatars.githubusercontent.com/u/1901008?v=3","gravatar_id":"","url":"https://api.github.com/users/furushchev","html_url":"https://github.com/furushchev","followers_url":"https://api.github.com/users/furushchev/followers","following_url":"https://api.github.com/users/furushchev/following{/other_user}","gists_url":"https://api.github.com/users/furushchev/gists{/gist_id}","starred_url":"https://api.github.com/users/furushchev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/furushchev/subscriptions","organizations_url":"https://api.github.com/users/furushchev/orgs","repos_url":"https://api.github.com/users/furushchev/repos","events_url":"https://api.github.com/users/furushchev/events{/privacy}","received_events_url":"https://api.github.com/users/furushchev/received_events","type":"User","site_admin":false},"created_at":"2016-05-06T13:33:37Z","updated_at":"2016-05-06T13:33:37Z","body":"now travis passed and verified that roslint is enabled.\r\n@k-okada Please merge if there is no problem.\r\n\r\n```bash\r\nThe command \"xvfb-run -a --server-args=\"-screen 0 800x600x24\" catkin build --catkin-make-args run_tests -- -p1 -j1 --limit-status-rate 0.017 --summarize $REPOSITORY_NAME --no-deps\" exited with 0.\r\n0.06s$ catkin_test_results --all --verbose build\r\njsk_mbzirc_common/test_results/jsk_mbzirc_common/roslaunch-check_launch_mbzirc_arena.launch.xml: 1 tests\r\njsk_mbzirc_common/test_results/jsk_mbzirc_common/roslaunch-check_launch_mbzirc_arena_1.launch.xml: 1 tests\r\njsk_mbzirc_common/test_results/jsk_mbzirc_common/roslaunch-check_launch_mbzirc_arena_2.launch.xml: 1 tests\r\njsk_mbzirc_common/test_results/jsk_mbzirc_common/roslaunch-check_launch_mbzirc_arena_3.launch.xml: 1 tests\r\njsk_mbzirc_common/test_results/jsk_mbzirc_common/roslint-jsk_mbzirc_common.xml: 1 tests\r\njsk_mbzirc_tasks/test_results/jsk_mbzirc_tasks/roslaunch-check_launch_jsk_mbzirc_task_1.launch.xml: 1 tests\r\njsk_mbzirc_tasks/test_results/jsk_mbzirc_tasks/roslaunch-check_launch_jsk_mbzirc_task_2.launch.xml: 1 tests\r\njsk_mbzirc_tasks/test_results/jsk_mbzirc_tasks/roslint-jsk_mbzirc_tasks.xml: 1 tests\r\njsk_mbzirc_tasks/test_results/jsk_mbzirc_tasks/rostest-test_jsk_mbzirc_task_1.xml: 2 tests\r\njsk_mbzirc_tasks/test_results/jsk_mbzirc_tasks/rostest-test_jsk_mbzirc_task_2.xml: 2 tests\r\njsk_mbzirc_tasks/test_results/jsk_mbzirc_tasks/rosunit-completed_test.xml: 1 tests\r\njsk_mbzirc_tasks/test_results/jsk_mbzirc_tasks/rosunit-remaining_time_test.xml: 1 tests\r\nSummary: 14 tests, 0 errors, 0 failures\r\n```"}}