{"action":"created","comment":{"url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/pulls/comments/91659661","pull_request_review_id":12170145,"id":91659661,"diff_hunk":"@@ -29,7 +31,38 @@ public class CharacterModification\n         [Range(3, 18)]\n         public int? Mind { get; set; }\n \n-        [Range(1, 100)]\n+        [Range(0,100)] //assuming a level 20 cap\n+        public int? Physical { get; set; }\n+\n+        [Range(0,100)] //assuming a level 20 cap\n+        public int? Subterfuge { get; set; }\n+\n+        [Range(0,100)] //assuming a level 20 cap\n+        public int? Knowledge { get; set; }\n+\n+        [Range(0,100)] //assuming a level 20 cap\n+        public int? Communication { get; set; }\n+\n+        [Range(1, int.MaxValue)]\n         public int? Level { get; set; }\n+\n+        [Range(1, int.MaxValue)]\n+        public int? Experience { get; set;} //when modifying a character, if experience is ever equal or greater than 10xlevel, player advances a level, then experience resets (extra exp rolls over)\n+\n+        internal ICollection<Item> Items { get; set; }","path":"src/GMBuddy.Games/Micro20/InputModels/CharacterModification.cs","position":31,"original_position":31,"commit_id":"657efe47bce6c7a1e2b5214780f889ad54ee463b","original_commit_id":"657efe47bce6c7a1e2b5214780f889ad54ee463b","user":{"login":"jackhorton","id":4370013,"avatar_url":"https://avatars.githubusercontent.com/u/4370013?v=3","gravatar_id":"","url":"https://api.github.com/users/jackhorton","html_url":"https://github.com/jackhorton","followers_url":"https://api.github.com/users/jackhorton/followers","following_url":"https://api.github.com/users/jackhorton/following{/other_user}","gists_url":"https://api.github.com/users/jackhorton/gists{/gist_id}","starred_url":"https://api.github.com/users/jackhorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackhorton/subscriptions","organizations_url":"https://api.github.com/users/jackhorton/orgs","repos_url":"https://api.github.com/users/jackhorton/repos","events_url":"https://api.github.com/users/jackhorton/events{/privacy}","received_events_url":"https://api.github.com/users/jackhorton/received_events","type":"User","site_admin":false},"body":"Why did you mark these all as internal... When I mentioned Internal before, I meant the class, and that was only if you had a corresponding Input/Output model for it. if youre just going to use the raw database model, dont mark it as internal. Internal also makes it untestable in our current setup...","created_at":"2016-12-09T05:05:00Z","updated_at":"2016-12-09T05:05:00Z","html_url":"https://github.com/GMBuddy/gmbuddy-backend/pull/26#discussion_r91659661","pull_request_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/pulls/comments/91659661"},"html":{"href":"https://github.com/GMBuddy/gmbuddy-backend/pull/26#discussion_r91659661"},"pull_request":{"href":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/pulls/26","id":97062488,"html_url":"https://github.com/GMBuddy/gmbuddy-backend/pull/26","diff_url":"https://github.com/GMBuddy/gmbuddy-backend/pull/26.diff","patch_url":"https://github.com/GMBuddy/gmbuddy-backend/pull/26.patch","issue_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/issues/26","number":26,"state":"open","locked":false,"title":"Items spells skills","user":{"login":"MasonHerhusky","id":7897742,"avatar_url":"https://avatars.githubusercontent.com/u/7897742?v=3","gravatar_id":"","url":"https://api.github.com/users/MasonHerhusky","html_url":"https://github.com/MasonHerhusky","followers_url":"https://api.github.com/users/MasonHerhusky/followers","following_url":"https://api.github.com/users/MasonHerhusky/following{/other_user}","gists_url":"https://api.github.com/users/MasonHerhusky/gists{/gist_id}","starred_url":"https://api.github.com/users/MasonHerhusky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MasonHerhusky/subscriptions","organizations_url":"https://api.github.com/users/MasonHerhusky/orgs","repos_url":"https://api.github.com/users/MasonHerhusky/repos","events_url":"https://api.github.com/users/MasonHerhusky/events{/privacy}","received_events_url":"https://api.github.com/users/MasonHerhusky/received_events","type":"User","site_admin":false},"body":"Adding, Getting, Listing, and Modifying spells and items is complete.","created_at":"2016-12-08T05:42:17Z","updated_at":"2016-12-09T05:05:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"471645db3e5fd34207a01e7ef7808ff480ec0f5c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/pulls/26/commits","review_comments_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/pulls/26/comments","review_comment_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/issues/26/comments","statuses_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/statuses/657efe47bce6c7a1e2b5214780f889ad54ee463b","head":{"label":"GMBuddy:items-spells-skills","ref":"items-spells-skills","sha":"657efe47bce6c7a1e2b5214780f889ad54ee463b","user":{"login":"GMBuddy","id":21268740,"avatar_url":"https://avatars.githubusercontent.com/u/21268740?v=3","gravatar_id":"","url":"https://api.github.com/users/GMBuddy","html_url":"https://github.com/GMBuddy","followers_url":"https://api.github.com/users/GMBuddy/followers","following_url":"https://api.github.com/users/GMBuddy/following{/other_user}","gists_url":"https://api.github.com/users/GMBuddy/gists{/gist_id}","starred_url":"https://api.github.com/users/GMBuddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GMBuddy/subscriptions","organizations_url":"https://api.github.com/users/GMBuddy/orgs","repos_url":"https://api.github.com/users/GMBuddy/repos","events_url":"https://api.github.com/users/GMBuddy/events{/privacy}","received_events_url":"https://api.github.com/users/GMBuddy/received_events","type":"Organization","site_admin":false},"repo":{"id":69380567,"name":"gmbuddy-backend","full_name":"GMBuddy/gmbuddy-backend","owner":{"login":"GMBuddy","id":21268740,"avatar_url":"https://avatars.githubusercontent.com/u/21268740?v=3","gravatar_id":"","url":"https://api.github.com/users/GMBuddy","html_url":"https://github.com/GMBuddy","followers_url":"https://api.github.com/users/GMBuddy/followers","following_url":"https://api.github.com/users/GMBuddy/following{/other_user}","gists_url":"https://api.github.com/users/GMBuddy/gists{/gist_id}","starred_url":"https://api.github.com/users/GMBuddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GMBuddy/subscriptions","organizations_url":"https://api.github.com/users/GMBuddy/orgs","repos_url":"https://api.github.com/users/GMBuddy/repos","events_url":"https://api.github.com/users/GMBuddy/events{/privacy}","received_events_url":"https://api.github.com/users/GMBuddy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GMBuddy/gmbuddy-backend","description":null,"fork":false,"url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend","forks_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/forks","keys_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/teams","hooks_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/hooks","issue_events_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/issues/events{/number}","events_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/events","assignees_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/assignees{/user}","branches_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/branches{/branch}","tags_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/tags","blobs_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/languages","stargazers_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/stargazers","contributors_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/contributors","subscribers_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/subscribers","subscription_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/subscription","commits_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/contents/{+path}","compare_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/merges","archive_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/downloads","issues_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/issues{/number}","pulls_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/labels{/name}","releases_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/releases{/id}","deployments_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/deployments","created_at":"2016-09-27T17:15:23Z","updated_at":"2016-12-08T20:08:50Z","pushed_at":"2016-12-08T23:51:26Z","git_url":"git://github.com/GMBuddy/gmbuddy-backend.git","ssh_url":"git@github.com:GMBuddy/gmbuddy-backend.git","clone_url":"https://github.com/GMBuddy/gmbuddy-backend.git","svn_url":"https://github.com/GMBuddy/gmbuddy-backend","homepage":null,"size":924,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":13,"forks":0,"open_issues":13,"watchers":0,"default_branch":"master"}},"base":{"label":"GMBuddy:master","ref":"master","sha":"491ce684b22d0d0da99419d985b5381c917a17ad","user":{"login":"GMBuddy","id":21268740,"avatar_url":"https://avatars.githubusercontent.com/u/21268740?v=3","gravatar_id":"","url":"https://api.github.com/users/GMBuddy","html_url":"https://github.com/GMBuddy","followers_url":"https://api.github.com/users/GMBuddy/followers","following_url":"https://api.github.com/users/GMBuddy/following{/other_user}","gists_url":"https://api.github.com/users/GMBuddy/gists{/gist_id}","starred_url":"https://api.github.com/users/GMBuddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GMBuddy/subscriptions","organizations_url":"https://api.github.com/users/GMBuddy/orgs","repos_url":"https://api.github.com/users/GMBuddy/repos","events_url":"https://api.github.com/users/GMBuddy/events{/privacy}","received_events_url":"https://api.github.com/users/GMBuddy/received_events","type":"Organization","site_admin":false},"repo":{"id":69380567,"name":"gmbuddy-backend","full_name":"GMBuddy/gmbuddy-backend","owner":{"login":"GMBuddy","id":21268740,"avatar_url":"https://avatars.githubusercontent.com/u/21268740?v=3","gravatar_id":"","url":"https://api.github.com/users/GMBuddy","html_url":"https://github.com/GMBuddy","followers_url":"https://api.github.com/users/GMBuddy/followers","following_url":"https://api.github.com/users/GMBuddy/following{/other_user}","gists_url":"https://api.github.com/users/GMBuddy/gists{/gist_id}","starred_url":"https://api.github.com/users/GMBuddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GMBuddy/subscriptions","organizations_url":"https://api.github.com/users/GMBuddy/orgs","repos_url":"https://api.github.com/users/GMBuddy/repos","events_url":"https://api.github.com/users/GMBuddy/events{/privacy}","received_events_url":"https://api.github.com/users/GMBuddy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GMBuddy/gmbuddy-backend","description":null,"fork":false,"url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend","forks_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/forks","keys_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/teams","hooks_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/hooks","issue_events_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/issues/events{/number}","events_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/events","assignees_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/assignees{/user}","branches_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/branches{/branch}","tags_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/tags","blobs_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/languages","stargazers_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/stargazers","contributors_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/contributors","subscribers_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/subscribers","subscription_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/subscription","commits_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/contents/{+path}","compare_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/merges","archive_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/downloads","issues_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/issues{/number}","pulls_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/labels{/name}","releases_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/releases{/id}","deployments_url":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/deployments","created_at":"2016-09-27T17:15:23Z","updated_at":"2016-12-08T20:08:50Z","pushed_at":"2016-12-08T23:51:26Z","git_url":"git://github.com/GMBuddy/gmbuddy-backend.git","ssh_url":"git@github.com:GMBuddy/gmbuddy-backend.git","clone_url":"https://github.com/GMBuddy/gmbuddy-backend.git","svn_url":"https://github.com/GMBuddy/gmbuddy-backend","homepage":null,"size":924,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":13,"forks":0,"open_issues":13,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/pulls/26"},"html":{"href":"https://github.com/GMBuddy/gmbuddy-backend/pull/26"},"issue":{"href":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/issues/26"},"comments":{"href":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/GMBuddy/gmbuddy-backend/statuses/657efe47bce6c7a1e2b5214780f889ad54ee463b"}}}}
{"actor":{"display_login":"jackhorton"}}