{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/75230389","id":75230389,"diff_hunk":"@@ -414,12 +418,16 @@ message ContainerConfig {\n }\n \n message CreateContainerRequest {\n+    // A unique token accompanying the request to allow idempotency. A server\n+    // accepting this message SHOULD ensure that if two requests have the same\n+    // request_id value, they respond with the same container_id both times.\n+    optional string request_id = 1;\n     // The id of the PodSandbox\n-    optional string pod_sandbox_id = 1;","path":"pkg/kubelet/api/v1alpha1/runtime/api.proto","position":23,"original_position":23,"commit_id":"2a0b6b65bdc1da57f621da7a4b57aad617b9d450","original_commit_id":"2a0b6b65bdc1da57f621da7a4b57aad617b9d450","user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"body":"renumbering tags is only viable until we publish this, FWIW","created_at":"2016-08-18T00:11:21Z","updated_at":"2016-08-18T00:11:21Z","html_url":"https://github.com/kubernetes/kubernetes/pull/30830#discussion_r75230389","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30830","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/75230389"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30830#discussion_r75230389"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30830"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30830","id":81735211,"html_url":"https://github.com/kubernetes/kubernetes/pull/30830","diff_url":"https://github.com/kubernetes/kubernetes/pull/30830.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/30830.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30830","number":30830,"state":"open","locked":false,"title":"kubelet/cri: Include a request id for creates","user":{"login":"euank","id":2147649,"avatar_url":"https://avatars.githubusercontent.com/u/2147649?v=3","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"body":"This allows the server to implement idempotency semantics for these\r\ncalls. All other calls can already be implemented idempotently using the\r\nid returned by create.\r\n\r\nThis should be blocked on https://github.com/kubernetes/kubernetes/pull/30753#discussion_r75222057 being resolved\r\n\r\nLet me know if I should include documentation explaining the semantics and reasoning behind this choice and the arguments for/against. I wasn't certain the best place to locate it, but if it's needed I'm sure I can find a spot.\r\n\r\ncc @yujuhong @euank @yifan-gu @kubernetes/sig-node @thockin\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/30830)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-08-17T23:34:53Z","updated_at":"2016-08-18T00:11:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bbb17b80b85669a2aa93d23783cc4583ad1463e","assignee":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"assignees":[{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},{"login":"yujuhong","id":10524058,"avatar_url":"https://avatars.githubusercontent.com/u/10524058?v=3","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30830/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30830/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/30830/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/2a0b6b65bdc1da57f621da7a4b57aad617b9d450","head":{"label":"euank:cri-idempotent-create","ref":"cri-idempotent-create","sha":"2a0b6b65bdc1da57f621da7a4b57aad617b9d450","user":{"login":"euank","id":2147649,"avatar_url":"https://avatars.githubusercontent.com/u/2147649?v=3","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"repo":{"id":55001117,"name":"kubernetes","full_name":"euank/kubernetes","owner":{"login":"euank","id":2147649,"avatar_url":"https://avatars.githubusercontent.com/u/2147649?v=3","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/euank/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/euank/kubernetes","forks_url":"https://api.github.com/repos/euank/kubernetes/forks","keys_url":"https://api.github.com/repos/euank/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/euank/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/euank/kubernetes/teams","hooks_url":"https://api.github.com/repos/euank/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/euank/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/euank/kubernetes/events","assignees_url":"https://api.github.com/repos/euank/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/euank/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/euank/kubernetes/tags","blobs_url":"https://api.github.com/repos/euank/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/euank/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/euank/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/euank/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/euank/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/euank/kubernetes/languages","stargazers_url":"https://api.github.com/repos/euank/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/euank/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/euank/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/euank/kubernetes/subscription","commits_url":"https://api.github.com/repos/euank/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/euank/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/euank/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/euank/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/euank/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/euank/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/euank/kubernetes/merges","archive_url":"https://api.github.com/repos/euank/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/euank/kubernetes/downloads","issues_url":"https://api.github.com/repos/euank/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/euank/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/euank/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/euank/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/euank/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/euank/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/euank/kubernetes/deployments","created_at":"2016-03-29T18:39:10Z","updated_at":"2016-03-29T18:39:23Z","pushed_at":"2016-08-17T23:18:40Z","git_url":"git://github.com/euank/kubernetes.git","ssh_url":"git@github.com:euank/kubernetes.git","clone_url":"https://github.com/euank/kubernetes.git","svn_url":"https://github.com/euank/kubernetes","homepage":"http://kubernetes.io","size":300702,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"332edf8bb383d770078dd759ad54942ef4382f97","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-08-17T23:04:00Z","pushed_at":"2016-08-18T00:02:24Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":529038,"stargazers_count":16175,"watchers_count":16175,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5168,"mirror_url":null,"open_issues_count":4235,"forks":5168,"open_issues":4235,"watchers":16175,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30830"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/30830"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30830"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/30830/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30830/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/30830/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/2a0b6b65bdc1da57f621da7a4b57aad617b9d450"}}}}
{"actor":{"display_login":"thockin"}}