{"push_id":1367292651,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"1ace41be98e2aeb7fe5e432143b9396ae9f48902","before":"bc6cefb787c37dfae41ccb17e9fd4bf259d80ffe","commits":[{"sha":"ebfcfeb59ab4093d6e0d60e95c880d3339e4789d","author":{"name":"Phil Davis","email":"d10d92d1ccfeef7a6a6fe8b3d078e129ceb891cc@inf.org"},"message":"Fix display advanced after input error for system_gateways_edit\n\nUse case:\r\n1) Edit a gateway that has no advanced settings (i.e. the Advanced section does not need to open on page load) - that works fine.\r\n2) Modify the Gateway IP Address to something invalid like 1:2::z\r\n3) Press Save\r\nThe error is shown - \"A valid gateway IP address must be specified\" - good.\r\nThe Advanced section is shown - not good.\r\n\r\nThe problem is that after POSTing the page, and the resulting validation, finding an input error, and re-displaying the page, each of the $pconfig keys is set, even though set to the empty string \"\". So the isset() tests are true, and it gets the wrong idea.\r\n\r\nWe only care about these parameters if they are not \"\". In this case !empty() gives the correct result, because although a value of 0 will be considered empty, 0 is not allowed by the front-end of the UI anyway (as it happens, these parameters are not allowed to be 0), so we never get that case. And by the way, I generally hate empty() because of having to think of all its quirks.","distinct":true,"url":"https://api.github.com/repos/pfsense/pfsense/commits/ebfcfeb59ab4093d6e0d60e95c880d3339e4789d"},{"sha":"1ace41be98e2aeb7fe5e432143b9396ae9f48902","author":{"name":"Renato Botelho","email":"e7bd0c9fa3af309541cca919fc859a7885c8c165@netgate.com"},"message":"Merge pull request #3200 from phil-davis/patch-2","distinct":true,"url":"https://api.github.com/repos/pfsense/pfsense/commits/1ace41be98e2aeb7fe5e432143b9396ae9f48902"}]}
{"actor":{"display_login":"pfSense-git-updates"}}