{"action":"closed","number":8689,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/8689","id":89085542,"html_url":"https://github.com/Automattic/wp-calypso/pull/8689","diff_url":"https://github.com/Automattic/wp-calypso/pull/8689.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/8689.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/8689","number":8689,"state":"closed","locked":false,"title":"Decouple image editor from media modal","user":{"login":"lamosty","id":4988512,"avatar_url":"https://avatars.githubusercontent.com/u/4988512?v=3","gravatar_id":"","url":"https://api.github.com/users/lamosty","html_url":"https://github.com/lamosty","followers_url":"https://api.github.com/users/lamosty/followers","following_url":"https://api.github.com/users/lamosty/following{/other_user}","gists_url":"https://api.github.com/users/lamosty/gists{/gist_id}","starred_url":"https://api.github.com/users/lamosty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamosty/subscriptions","organizations_url":"https://api.github.com/users/lamosty/orgs","repos_url":"https://api.github.com/users/lamosty/repos","events_url":"https://api.github.com/users/lamosty/events{/privacy}","received_events_url":"https://api.github.com/users/lamosty/received_events","type":"User","site_admin":false},"body":"Follow-up of #8499. While we managed to extract the image editor to `blocks/image-editor` in that PR, it is still tied to media modal. Let's decouple it even more in this PR.\r\n\r\n## Testing instructions\r\n\r\n1. Test whether the image editor works as before in media modal;\r\n2. Navigate to http://calypso.localhost:3000/devdocs/blocks/image-editor and test whether the image editor works properly there as well;\r\n\r\nDo you think the image editor could be decoupled even more? What could we improve even more?\r\n\r\n/cc @gwwar @artpi @retrofox @aduth ","created_at":"2016-10-12T20:14:49Z","updated_at":"2016-10-14T17:55:45Z","closed_at":"2016-10-14T17:55:45Z","merged_at":"2016-10-14T17:55:45Z","merge_commit_sha":"754e56f4f8ea12a4de185f9055e22979f8076993","assignee":{"login":"lamosty","id":4988512,"avatar_url":"https://avatars.githubusercontent.com/u/4988512?v=3","gravatar_id":"","url":"https://api.github.com/users/lamosty","html_url":"https://github.com/lamosty","followers_url":"https://api.github.com/users/lamosty/followers","following_url":"https://api.github.com/users/lamosty/following{/other_user}","gists_url":"https://api.github.com/users/lamosty/gists{/gist_id}","starred_url":"https://api.github.com/users/lamosty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamosty/subscriptions","organizations_url":"https://api.github.com/users/lamosty/orgs","repos_url":"https://api.github.com/users/lamosty/repos","events_url":"https://api.github.com/users/lamosty/events{/privacy}","received_events_url":"https://api.github.com/users/lamosty/received_events","type":"User","site_admin":false},"assignees":[{"login":"lamosty","id":4988512,"avatar_url":"https://avatars.githubusercontent.com/u/4988512?v=3","gravatar_id":"","url":"https://api.github.com/users/lamosty","html_url":"https://github.com/lamosty","followers_url":"https://api.github.com/users/lamosty/followers","following_url":"https://api.github.com/users/lamosty/following{/other_user}","gists_url":"https://api.github.com/users/lamosty/gists{/gist_id}","starred_url":"https://api.github.com/users/lamosty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamosty/subscriptions","organizations_url":"https://api.github.com/users/lamosty/orgs","repos_url":"https://api.github.com/users/lamosty/repos","events_url":"https://api.github.com/users/lamosty/events{/privacy}","received_events_url":"https://api.github.com/users/lamosty/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/107","html_url":"https://github.com/Automattic/wp-calypso/milestones/Image%20Editor","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/107/labels","id":1872811,"number":107,"title":"Image Editor","description":null,"creator":{"login":"gwwar","id":1270189,"avatar_url":"https://avatars.githubusercontent.com/u/1270189?v=3","gravatar_id":"","url":"https://api.github.com/users/gwwar","html_url":"https://github.com/gwwar","followers_url":"https://api.github.com/users/gwwar/followers","following_url":"https://api.github.com/users/gwwar/following{/other_user}","gists_url":"https://api.github.com/users/gwwar/gists{/gist_id}","starred_url":"https://api.github.com/users/gwwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwwar/subscriptions","organizations_url":"https://api.github.com/users/gwwar/orgs","repos_url":"https://api.github.com/users/gwwar/repos","events_url":"https://api.github.com/users/gwwar/events{/privacy}","received_events_url":"https://api.github.com/users/gwwar/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":58,"state":"open","created_at":"2016-07-08T18:51:46Z","updated_at":"2016-10-14T17:55:45Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/8689/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/8689/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/8689/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/9290e1d38d2a647ee26f6097a93981e404a168b9","head":{"label":"Automattic:update/decouple-image-editor-from-media-modal","ref":"update/decouple-image-editor-from-media-modal","sha":"9290e1d38d2a647ee26f6097a93981e404a168b9","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2016-10-14T16:21:27Z","pushed_at":"2016-10-14T17:55:45Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":112629,"stargazers_count":7900,"watchers_count":7900,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":994,"mirror_url":null,"open_issues_count":1544,"forks":994,"open_issues":1544,"watchers":7900,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"2aef5ece437586e110279dfbef40d1be628a0111","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2016-10-14T16:21:27Z","pushed_at":"2016-10-14T17:55:45Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":112629,"stargazers_count":7900,"watchers_count":7900,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":994,"mirror_url":null,"open_issues_count":1544,"forks":994,"open_issues":1544,"watchers":7900,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/8689"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/8689"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/8689"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/8689/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/8689/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/8689/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/9290e1d38d2a647ee26f6097a93981e404a168b9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lamosty","id":4988512,"avatar_url":"https://avatars.githubusercontent.com/u/4988512?v=3","gravatar_id":"","url":"https://api.github.com/users/lamosty","html_url":"https://github.com/lamosty","followers_url":"https://api.github.com/users/lamosty/followers","following_url":"https://api.github.com/users/lamosty/following{/other_user}","gists_url":"https://api.github.com/users/lamosty/gists{/gist_id}","starred_url":"https://api.github.com/users/lamosty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamosty/subscriptions","organizations_url":"https://api.github.com/users/lamosty/orgs","repos_url":"https://api.github.com/users/lamosty/repos","events_url":"https://api.github.com/users/lamosty/events{/privacy}","received_events_url":"https://api.github.com/users/lamosty/received_events","type":"User","site_admin":false},"comments":7,"review_comments":13,"commits":17,"additions":165,"deletions":119,"changed_files":9}}
{"actor":{"display_login":"lamosty"}}