{"action":"created","issue":{"url":"https://api.github.com/repos/electron-userland/electron-builder/issues/766","repository_url":"https://api.github.com/repos/electron-userland/electron-builder","labels_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/766/labels{/name}","comments_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/766/comments","events_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/766/events","html_url":"https://github.com/electron-userland/electron-builder/issues/766","id":178237804,"number":766,"title":"Code signing on Windows 10 builds a non-signed Windows 7 installer/executable","user":{"login":"tomzx","id":188960,"avatar_url":"https://avatars.githubusercontent.com/u/188960?v=3","gravatar_id":"","url":"https://api.github.com/users/tomzx","html_url":"https://github.com/tomzx","followers_url":"https://api.github.com/users/tomzx/followers","following_url":"https://api.github.com/users/tomzx/following{/other_user}","gists_url":"https://api.github.com/users/tomzx/gists{/gist_id}","starred_url":"https://api.github.com/users/tomzx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomzx/subscriptions","organizations_url":"https://api.github.com/users/tomzx/orgs","repos_url":"https://api.github.com/users/tomzx/repos","events_url":"https://api.github.com/users/tomzx/events{/privacy}","received_events_url":"https://api.github.com/users/tomzx/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/electron-userland/electron-builder/labels/windows","name":"windows","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-09-21T03:39:02Z","updated_at":"2016-09-26T02:09:28Z","closed_at":null,"body":"* **Version**: 6.7.7\r\n* **WinCodeSign**: 1.4.2\r\n* **Target**: Windows 7/10 ia32/x64\r\n* **Type**: Squirrel installer\r\n\r\nHi,\r\n\r\nI've been successful in building a code signed Windows 10 application using electron-builder. However, if I run the same installer under Windows 7, I see the following dialog window:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/188960/18696422/f6decabc-7f86-11e6-8326-f2abb9ab25f1.png)\r\n\r\nIf I look at the properties of the executable, the *Digital Signatures* tab is missing, indicating that the executable is not signed.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/188960/18696844/13130574-7f8a-11e6-9dcb-6b72dda7524a.png)\r\n\r\nHowever, if I do the same process under Windows 7, I have a different set of issues. I'm unsure if it is my computer of the codesign executable that is part of the WinCodeSign 1.4.2 package, but it will often crash with `Unhandled rejection Error: Exit code: 3221225477` (see http://stackoverflow.com/a/10306977/108301, basically a segfault). If I run it multiple times (until it works), then I get a signed executable/installer. The security warning dialog box now displays the proper publisher name and the *Digital Signatures* is present in the properties of the executable.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/188960/18696872/4b3d693a-7f8a-11e6-9ebb-8d78f66b50d9.png)\r\n\r\nDoes this imply that it is not possible to to have an app signed for both Windows 7 and Windows 10?\r\n\r\nReference logs (When building on Windows 7):\r\n```\r\nE:\\Tom\\Documents\\GIT\\REMOVED>gulp installer-win32\r\n(node:5388) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.\r\n[23:23:21] Using gulpfile E:\\Tom\\Documents\\GIT\\REMOVED\\gulpfile.js\r\n[23:23:21] Starting 'installer-win32'...\r\n[23:23:21] Finished 'installer-win32' after 32 ms\r\nSkip app dependencies rebuild because dev and app dependencies are not separated\r\nPackaging for platform win32 ia32 using electron 1.1.3 to dist\\win-ia32-unpacked\r\n\r\n  electron-builder Found existing nsis C:\\Users\\Tom\\.cache\\nsis\\nsis-3.0.1 +0ms\r\n  electron-builder Found existing winCodeSign C:\\Users\\Tom\\.cache\\winCodeSign\\winCodeSign-1.4.2 +3s\r\n  electron-builder Executing C:\\Users\\Tom\\.cache\\winCodeSign\\winCodeSign-1.4.2\\rcedit.exe E:\\Tom\\Documents\\GIT\\REMOVED\\dist\\win-ia32-unpacked\\REMOVED.exe --set-version-string CompanyName REMOVED --set-version-string FileDescription REMOVED --set-version-string ProductName REMOVED --set-version-string InternalName REMOVED --set-version-string LegalCopyright Copyright © 2016 REMOVED --set-version-string OriginalFilename  --set-file-version 1.1.0 --set-product-version 1.1.0 --set-icon E:\\Tom\\Documents\\GIT\\REMOVED\\assets\\package\\win\\icon.ico +2ms\r\nSigning REMOVED.exe (certificate file \"build\\certs\\REMOVED.p12\")\r\n  electron-builder Executing C:\\Users\\Tom\\.cache\\winCodeSign\\winCodeSign-1.4.2\\windows-6\\signtool.exe sign /t http://timestamp.verisign.com/scripts/timstamp.dll /f build\\certs\\REMOVED.p12 /d REMOVED /du https://REMOVED/ /p REMOVED E:\\Tom\\Documents\\GIT\\REMOVED\\dist\\win-ia32-unpacked\\REMOVED.exe +170ms\r\n  electron-builder Executing C:\\Users\\Tom\\.cache\\winCodeSign\\winCodeSign-1.4.2\\windows-6\\signtool.exe sign /tr http://timestamp.comodoca.com/rfc3161 /f build\\certs\\REMOVED.p12 /fd sha256 /td sha256 /d REMOVED /du https://REMOVED/ /as /p REMOVED E:\\Tom\\Documents\\GIT\\REMOVED\\dist\\win-ia32-unpacked\\REMOVED.exe +538ms\r\nWarning: For windows consider only distributing 64-bit, see https://github.com/electron-userland/electron-builder/issues/359#issuecomment-214851130\r\nBuilding Squirrel.Windows installer\r\n\r\n  electron-builder Found existing Squirrel.Windows C:\\Users\\Tom\\.cache\\Squirrel.Windows\\Squirrel.Windows-1.4.4 +1s\r\nSigning t-150c-0-Update.exe (certificate file \"build\\certs\\REMOVED.p12\")\r\n  electron-builder Executing C:\\Users\\Tom\\.cache\\winCodeSign\\winCodeSign-1.4.2\\windows-6\\signtool.exe sign /t http://timestamp.verisign.com/scripts/timstamp.dll /f build\\certs\\REMOVED.p12 /d REMOVED /du https://REMOVED/ /p REMOVED C:\\Users\\Tom\\AppData\\Local\\Temp\\electron-builder-CGxeG7\\t-150c-0-Update.exe +31ms\r\n  electron-builder Executing C:\\Users\\Tom\\.cache\\winCodeSign\\winCodeSign-1.4.2\\windows-6\\signtool.exe sign /tr http://timestamp.comodoca.com/rfc3161 /f build\\certs\\REMOVED.p12 /fd sha256 /td sha256 /d REMOVED /du https://REMOVED/ /as /p REMOVED C:\\Users\\Tom\\AppData\\Local\\Temp\\electron-builder-CGxeG7\\t-150c-0-Update.exe +223ms\r\nUnhandled rejection Error: Exit code: 3221225477. Command failed: C:\\Users\\Tom\\.cache\\winCodeSign\\winCodeSign-1.4.2\\windows-6\\signtool.exe sign /tr http://timestamp.comodoca.com/rfc3161 /f build\\certs\\REMOVED.p12 /fd sha256 /td sha256 /d REMOVED /du https://REMOVED/ /as /p REMOVED C:\\Users\\Tom\\AppData\\Local\\Temp\\electron-builder-CGxeG7\\t-150c-0-Update.exe\r\n\r\n    at E:\\Tom\\Documents\\GIT\\REMOVED\\node_modules\\electron-builder\\src\\util\\util.ts:96:16\r\n    at ChildProcess.exithandler (child_process.js:213:5)\r\n    at emitTwo (events.js:106:13)\r\n    at ChildProcess.emit (events.js:191:7)\r\n    at maybeClose (internal/child_process.js:877:16)\r\n    at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)\r\nFrom previous event:\r\n    at Object.exec (E:\\Tom\\Documents\\GIT\\REMOVED\\node_modules\\electron-builder\\src\\util\\util.ts:77:9)\r\n    at E:\\Tom\\Documents\\GIT\\REMOVED\\node_modules\\electron-builder\\src\\windowsCodeSign.ts:114:20\r\nFrom previous event:\r\n    at tsAwaiter (E:\\Tom\\Documents\\GIT\\REMOVED\\node_modules\\electron-builder\\src\\util\\awaiter.ts:10:47)\r\n    at WinPackager.sign (E:\\Tom\\Documents\\GIT\\REMOVED\\node_modules\\electron-builder\\src\\winPackager.ts:123:26)\r\n    at bluebird_1.Promise.all.fs_extra_p_1.copy.then (E:\\Tom\\Documents\\GIT\\REMOVED\\node_modules\\electron-builder\\src\\targets\\squirrelP\r\nack.ts:58:28)\r\n    at runCallback (timers.js:574:20)\r\n    at tryOnImmediate (timers.js:554:5)\r\n    at processImmediate [as _immediateCallback] (timers.js:533:5)\r\n```"},"comment":{"url":"https://api.github.com/repos/electron-userland/electron-builder/issues/comments/249464429","html_url":"https://github.com/electron-userland/electron-builder/issues/766#issuecomment-249464429","issue_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/766","id":249464429,"user":{"login":"tomzx","id":188960,"avatar_url":"https://avatars.githubusercontent.com/u/188960?v=3","gravatar_id":"","url":"https://api.github.com/users/tomzx","html_url":"https://github.com/tomzx","followers_url":"https://api.github.com/users/tomzx/followers","following_url":"https://api.github.com/users/tomzx/following{/other_user}","gists_url":"https://api.github.com/users/tomzx/gists{/gist_id}","starred_url":"https://api.github.com/users/tomzx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomzx/subscriptions","organizations_url":"https://api.github.com/users/tomzx/orgs","repos_url":"https://api.github.com/users/tomzx/repos","events_url":"https://api.github.com/users/tomzx/events{/privacy}","received_events_url":"https://api.github.com/users/tomzx/received_events","type":"User","site_admin":false},"created_at":"2016-09-26T02:09:28Z","updated_at":"2016-09-26T02:09:28Z","body":"@dharders Interesting, I thought that NSIS had been deprecated in favor of Squirrel a few versions back (about 3-6 months ago). Do you happen to know if that decision was reversed?"}}
{"actor":{"display_login":"tomzx"}}