{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/61512173","id":61512173,"diff_hunk":"@@ -253,13 +257,15 @@ object ConsoleConsumer extends Logging {\n       .withRequiredArg\n       .describedAs(\"deserializer for values\")\n       .ofType(classOf[String])\n+    val enableLifecycleLoggingOpt = parser.accepts(\"enable-lifecycle-logging\", \"Log lifecycle events of the consumer.\")","path":"core/src/main/scala/kafka/tools/ConsoleConsumer.scala","position":15,"original_position":15,"commit_id":"48e9a1cf1680ea236c1ed9958ccbbc6dbcb92805","original_commit_id":"48e9a1cf1680ea236c1ed9958ccbbc6dbcb92805","user":{"login":"granders","id":1295932,"avatar_url":"https://avatars.githubusercontent.com/u/1295932?v=3","gravatar_id":"","url":"https://api.github.com/users/granders","html_url":"https://github.com/granders","followers_url":"https://api.github.com/users/granders/followers","following_url":"https://api.github.com/users/granders/following{/other_user}","gists_url":"https://api.github.com/users/granders/gists{/gist_id}","starred_url":"https://api.github.com/users/granders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/granders/subscriptions","organizations_url":"https://api.github.com/users/granders/orgs","repos_url":"https://api.github.com/users/granders/repos","events_url":"https://api.github.com/users/granders/events{/privacy}","received_events_url":"https://api.github.com/users/granders/received_events","type":"User","site_admin":false},"body":"My main question about this approach is that I'm not sure which lifecycle events are best to \"log\". If we're providing this flag, it seems surprising to only log a clean shutdown.\r\n\r\nAnd, does \"log\" mean print?\r\n","created_at":"2016-04-28T22:20:54Z","updated_at":"2016-04-28T22:20:54Z","html_url":"https://github.com/apache/kafka/pull/1278#discussion_r61512173","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/1278","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/61512173"},"html":{"href":"https://github.com/apache/kafka/pull/1278#discussion_r61512173"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/1278"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/1278","id":68139306,"html_url":"https://github.com/apache/kafka/pull/1278","diff_url":"https://github.com/apache/kafka/pull/1278.diff","patch_url":"https://github.com/apache/kafka/pull/1278.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/1278","number":1278,"state":"open","locked":false,"title":"KAFKA-3597: Query ConsoleConsumer and VerifiableProducer if they shutdown cleanly","user":{"login":"apovzner","id":5383840,"avatar_url":"https://avatars.githubusercontent.com/u/5383840?v=3","gravatar_id":"","url":"https://api.github.com/users/apovzner","html_url":"https://github.com/apovzner","followers_url":"https://api.github.com/users/apovzner/followers","following_url":"https://api.github.com/users/apovzner/following{/other_user}","gists_url":"https://api.github.com/users/apovzner/gists{/gist_id}","starred_url":"https://api.github.com/users/apovzner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apovzner/subscriptions","organizations_url":"https://api.github.com/users/apovzner/orgs","repos_url":"https://api.github.com/users/apovzner/repos","events_url":"https://api.github.com/users/apovzner/events{/privacy}","received_events_url":"https://api.github.com/users/apovzner/received_events","type":"User","site_admin":false},"body":"Even if a test calls stop() on console_consumer or verifiable_producer, it is still possible that producer/consumer will not shutdown cleanly, and will be killed forcefully after a timeout. It will be useful for some tests to know whether a clean shutdown happened or not. This PR adds methods to console_consumer and verifiable_producer to query whether clean shutdown happened or not.\r\n\r\n@hachikuji and/or @granders Please review.","created_at":"2016-04-27T23:01:21Z","updated_at":"2016-04-28T22:20:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b37d6e0779dd991aa2e059bba6bdac095d482aaf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/1278/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/1278/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/1278/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/48e9a1cf1680ea236c1ed9958ccbbc6dbcb92805","head":{"label":"apovzner:kafka-3597","ref":"kafka-3597","sha":"48e9a1cf1680ea236c1ed9958ccbbc6dbcb92805","user":{"login":"apovzner","id":5383840,"avatar_url":"https://avatars.githubusercontent.com/u/5383840?v=3","gravatar_id":"","url":"https://api.github.com/users/apovzner","html_url":"https://github.com/apovzner","followers_url":"https://api.github.com/users/apovzner/followers","following_url":"https://api.github.com/users/apovzner/following{/other_user}","gists_url":"https://api.github.com/users/apovzner/gists{/gist_id}","starred_url":"https://api.github.com/users/apovzner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apovzner/subscriptions","organizations_url":"https://api.github.com/users/apovzner/orgs","repos_url":"https://api.github.com/users/apovzner/repos","events_url":"https://api.github.com/users/apovzner/events{/privacy}","received_events_url":"https://api.github.com/users/apovzner/received_events","type":"User","site_admin":false},"repo":{"id":44782457,"name":"kafka","full_name":"apovzner/kafka","owner":{"login":"apovzner","id":5383840,"avatar_url":"https://avatars.githubusercontent.com/u/5383840?v=3","gravatar_id":"","url":"https://api.github.com/users/apovzner","html_url":"https://github.com/apovzner","followers_url":"https://api.github.com/users/apovzner/followers","following_url":"https://api.github.com/users/apovzner/following{/other_user}","gists_url":"https://api.github.com/users/apovzner/gists{/gist_id}","starred_url":"https://api.github.com/users/apovzner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apovzner/subscriptions","organizations_url":"https://api.github.com/users/apovzner/orgs","repos_url":"https://api.github.com/users/apovzner/repos","events_url":"https://api.github.com/users/apovzner/events{/privacy}","received_events_url":"https://api.github.com/users/apovzner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apovzner/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/apovzner/kafka","forks_url":"https://api.github.com/repos/apovzner/kafka/forks","keys_url":"https://api.github.com/repos/apovzner/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apovzner/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apovzner/kafka/teams","hooks_url":"https://api.github.com/repos/apovzner/kafka/hooks","issue_events_url":"https://api.github.com/repos/apovzner/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apovzner/kafka/events","assignees_url":"https://api.github.com/repos/apovzner/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apovzner/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apovzner/kafka/tags","blobs_url":"https://api.github.com/repos/apovzner/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apovzner/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apovzner/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apovzner/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apovzner/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apovzner/kafka/languages","stargazers_url":"https://api.github.com/repos/apovzner/kafka/stargazers","contributors_url":"https://api.github.com/repos/apovzner/kafka/contributors","subscribers_url":"https://api.github.com/repos/apovzner/kafka/subscribers","subscription_url":"https://api.github.com/repos/apovzner/kafka/subscription","commits_url":"https://api.github.com/repos/apovzner/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apovzner/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apovzner/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apovzner/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apovzner/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apovzner/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apovzner/kafka/merges","archive_url":"https://api.github.com/repos/apovzner/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apovzner/kafka/downloads","issues_url":"https://api.github.com/repos/apovzner/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apovzner/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apovzner/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apovzner/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apovzner/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apovzner/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apovzner/kafka/deployments","created_at":"2015-10-23T01:03:29Z","updated_at":"2015-10-23T01:03:34Z","pushed_at":"2016-04-28T22:01:31Z","git_url":"git://github.com/apovzner/kafka.git","ssh_url":"git@github.com:apovzner/kafka.git","clone_url":"https://github.com/apovzner/kafka.git","svn_url":"https://github.com/apovzner/kafka","homepage":null,"size":29752,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"8407dac6ee409d832c95533e6f1d5578511232ae","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-04-28T19:57:06Z","pushed_at":"2016-04-28T22:01:32Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":40349,"stargazers_count":3023,"watchers_count":3023,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1817,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":182,"forks":1817,"open_issues":182,"watchers":3023,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/1278"},"html":{"href":"https://github.com/apache/kafka/pull/1278"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/1278"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/1278/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/1278/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/1278/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/48e9a1cf1680ea236c1ed9958ccbbc6dbcb92805"}}}}