{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9237","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9237/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9237/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9237/events","html_url":"https://github.com/ManageIQ/manageiq/pull/9237","id":160524489,"number":9237,"title":"Handle text for Floating Ips in grid views","user":{"login":"hayesr","id":39493,"avatar_url":"https://avatars.githubusercontent.com/u/39493?v=3","gravatar_id":"","url":"https://api.github.com/users/hayesr","html_url":"https://github.com/hayesr","followers_url":"https://api.github.com/users/hayesr/followers","following_url":"https://api.github.com/users/hayesr/following{/other_user}","gists_url":"https://api.github.com/users/hayesr/gists{/gist_id}","starred_url":"https://api.github.com/users/hayesr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayesr/subscriptions","organizations_url":"https://api.github.com/users/hayesr/orgs","repos_url":"https://api.github.com/users/hayesr/repos","events_url":"https://api.github.com/users/hayesr/events{/privacy}","received_events_url":"https://api.github.com/users/hayesr/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/darga/yes","name":"darga/yes","color":"000000"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/ui","name":"ui","color":"5319e7"}],"state":"closed","locked":false,"assignee":{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars.githubusercontent.com/u/3450808?v=3","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"assignees":[{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars.githubusercontent.com/u/3450808?v=3","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ManageIQ/manageiq/milestones/36","html_url":"https://github.com/ManageIQ/manageiq/milestones/Sprint%2042%20Ending%20June%2020,%202016","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones/36/labels","id":1798804,"number":36,"title":"Sprint 42 Ending June 20, 2016","description":"","creator":{"login":"chessbyte","id":82161,"avatar_url":"https://avatars.githubusercontent.com/u/82161?v=3","gravatar_id":"","url":"https://api.github.com/users/chessbyte","html_url":"https://github.com/chessbyte","followers_url":"https://api.github.com/users/chessbyte/followers","following_url":"https://api.github.com/users/chessbyte/following{/other_user}","gists_url":"https://api.github.com/users/chessbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/chessbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chessbyte/subscriptions","organizations_url":"https://api.github.com/users/chessbyte/orgs","repos_url":"https://api.github.com/users/chessbyte/repos","events_url":"https://api.github.com/users/chessbyte/events{/privacy}","received_events_url":"https://api.github.com/users/chessbyte/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":188,"state":"closed","created_at":"2016-05-31T13:42:39Z","updated_at":"2016-07-04T15:49:29Z","due_on":"2016-06-20T04:00:00Z","closed_at":"2016-06-21T13:18:48Z"},"comments":4,"created_at":"2016-06-15T21:09:40Z","updated_at":"2016-07-04T16:26:32Z","closed_at":"2016-06-16T02:36:44Z","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9237","html_url":"https://github.com/ManageIQ/manageiq/pull/9237","diff_url":"https://github.com/ManageIQ/manageiq/pull/9237.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/9237.patch"},"body":"\r\nThis PR addresses https://bugzilla.redhat.com/show_bug.cgi?id=1344044\r\n\r\nI found that the existing spec for `render_quadicon_text` would always pass as it was checking for presence of an anchor tag and this method always returns one even if there is no text. This PR improves that and adds a spec for the Floating IP case.\r\n\r\nIt does, however, add additional conditional branching \"smell\". Refactoring led to larger code changes and so I intend to do this in another PR.\r\n\r\n**Before:**\r\n\r\n![screen shot 2016-06-15 at 2 07 41 pm](https://cloud.githubusercontent.com/assets/39493/16097410/9d78eea6-3302-11e6-9b62-0ebc6e072663.png)\r\n\r\n\r\n**After**\r\n\r\n![screen shot 2016-06-15 at 2 07 49 pm](https://cloud.githubusercontent.com/assets/39493/16097431/a4b05164-3302-11e6-8d0f-da66b20e6c3d.png)\r\n\r\n\r\n> * https://bugzilla.redhat.com/show_bug.cgi?id=1344044\r\n"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/230323452","html_url":"https://github.com/ManageIQ/manageiq/pull/9237#issuecomment-230323452","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9237","id":230323452,"user":{"login":"chessbyte","id":82161,"avatar_url":"https://avatars.githubusercontent.com/u/82161?v=3","gravatar_id":"","url":"https://api.github.com/users/chessbyte","html_url":"https://github.com/chessbyte","followers_url":"https://api.github.com/users/chessbyte/followers","following_url":"https://api.github.com/users/chessbyte/following{/other_user}","gists_url":"https://api.github.com/users/chessbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/chessbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chessbyte/subscriptions","organizations_url":"https://api.github.com/users/chessbyte/orgs","repos_url":"https://api.github.com/users/chessbyte/repos","events_url":"https://api.github.com/users/chessbyte/events{/privacy}","received_events_url":"https://api.github.com/users/chessbyte/received_events","type":"User","site_admin":false},"created_at":"2016-07-04T16:26:32Z","updated_at":"2016-07-04T16:26:32Z","body":"@hayesr Running `git cherry-pick -x -m 1 cb437fe` creates merge conflict.\r\n\r\nPlease create a PR against the `darga` branch."}}
{"actor":{"display_login":"chessbyte"}}