{"action":"created","comment":{"url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/pulls/comments/58369919","id":58369919,"diff_hunk":"@@ -0,0 +1,358 @@\n+import RequestContext, { FileReference, Auth } from 'api-flow'\n+\n+import {\n+    registerImporter,\n+    DynamicValue,\n+    DynamicString\n+} from '../paw-mocks/PawShims'\n+\n+@registerImporter // eslint-disable-line\n+export default class BaseImporter {\n+    static identifier = 'com.luckymarmot.PawExtensions.BaseImporter';\n+    static title = 'Base Importer';","path":"src/base-importer/BaseImporter.js","position":12,"original_position":12,"commit_id":"b5ab9c67329800110d58fcb7175b06e213c54749","original_commit_id":"b5ab9c67329800110d58fcb7175b06e213c54749","user":{"login":"mittsh","id":1319906,"avatar_url":"https://avatars.githubusercontent.com/u/1319906?v=3","gravatar_id":"","url":"https://api.github.com/users/mittsh","html_url":"https://github.com/mittsh","followers_url":"https://api.github.com/users/mittsh/followers","following_url":"https://api.github.com/users/mittsh/following{/other_user}","gists_url":"https://api.github.com/users/mittsh/gists{/gist_id}","starred_url":"https://api.github.com/users/mittsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mittsh/subscriptions","organizations_url":"https://api.github.com/users/mittsh/orgs","repos_url":"https://api.github.com/users/mittsh/repos","events_url":"https://api.github.com/users/mittsh/events{/privacy}","received_events_url":"https://api.github.com/users/mittsh/received_events","type":"User","site_admin":false},"body":"Same for these static properties. They shouldn't be here and we should let the concrete classes set them.","created_at":"2016-04-04T12:48:48Z","updated_at":"2016-04-04T12:48:48Z","html_url":"https://github.com/luckymarmot/Paw-BaseImporter/pull/2#discussion_r58369919","pull_request_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/pulls/comments/58369919"},"html":{"href":"https://github.com/luckymarmot/Paw-BaseImporter/pull/2#discussion_r58369919"},"pull_request":{"href":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/pulls/2","id":65137837,"html_url":"https://github.com/luckymarmot/Paw-BaseImporter/pull/2","diff_url":"https://github.com/luckymarmot/Paw-BaseImporter/pull/2.diff","patch_url":"https://github.com/luckymarmot/Paw-BaseImporter/pull/2.patch","issue_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/issues/2","number":2,"state":"open","locked":false,"title":"create BaseImporter structure","user":{"login":"JonathanMontane","id":5136989,"avatar_url":"https://avatars.githubusercontent.com/u/5136989?v=3","gravatar_id":"","url":"https://api.github.com/users/JonathanMontane","html_url":"https://github.com/JonathanMontane","followers_url":"https://api.github.com/users/JonathanMontane/followers","following_url":"https://api.github.com/users/JonathanMontane/following{/other_user}","gists_url":"https://api.github.com/users/JonathanMontane/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanMontane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanMontane/subscriptions","organizations_url":"https://api.github.com/users/JonathanMontane/orgs","repos_url":"https://api.github.com/users/JonathanMontane/repos","events_url":"https://api.github.com/users/JonathanMontane/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanMontane/received_events","type":"User","site_admin":false},"body":"Moved mocks in src (so that they can be built together with base-importer in a simple fashion)\r\n\r\nCreated PawSims - it should replace Paw objects with mocks if the Paw objects do not exist, and keep them otherwise. Not sure if it works in Paw though.\r\n\r\nCreated BaseImporter and a first batch of tests. Testing is not complete.","created_at":"2016-04-04T12:34:21Z","updated_at":"2016-04-04T12:48:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3463c7f0842bf1f1d08e844cedbadd04f975a04d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/pulls/2/commits","review_comments_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/pulls/2/comments","review_comment_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/issues/2/comments","statuses_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/statuses/b5ab9c67329800110d58fcb7175b06e213c54749","head":{"label":"luckymarmot:001-create-base-importer-architecture","ref":"001-create-base-importer-architecture","sha":"b5ab9c67329800110d58fcb7175b06e213c54749","user":{"login":"luckymarmot","id":3215332,"avatar_url":"https://avatars.githubusercontent.com/u/3215332?v=3","gravatar_id":"","url":"https://api.github.com/users/luckymarmot","html_url":"https://github.com/luckymarmot","followers_url":"https://api.github.com/users/luckymarmot/followers","following_url":"https://api.github.com/users/luckymarmot/following{/other_user}","gists_url":"https://api.github.com/users/luckymarmot/gists{/gist_id}","starred_url":"https://api.github.com/users/luckymarmot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luckymarmot/subscriptions","organizations_url":"https://api.github.com/users/luckymarmot/orgs","repos_url":"https://api.github.com/users/luckymarmot/repos","events_url":"https://api.github.com/users/luckymarmot/events{/privacy}","received_events_url":"https://api.github.com/users/luckymarmot/received_events","type":"Organization","site_admin":false},"repo":{"id":55131041,"name":"Paw-BaseImporter","full_name":"luckymarmot/Paw-BaseImporter","owner":{"login":"luckymarmot","id":3215332,"avatar_url":"https://avatars.githubusercontent.com/u/3215332?v=3","gravatar_id":"","url":"https://api.github.com/users/luckymarmot","html_url":"https://github.com/luckymarmot","followers_url":"https://api.github.com/users/luckymarmot/followers","following_url":"https://api.github.com/users/luckymarmot/following{/other_user}","gists_url":"https://api.github.com/users/luckymarmot/gists{/gist_id}","starred_url":"https://api.github.com/users/luckymarmot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luckymarmot/subscriptions","organizations_url":"https://api.github.com/users/luckymarmot/orgs","repos_url":"https://api.github.com/users/luckymarmot/repos","events_url":"https://api.github.com/users/luckymarmot/events{/privacy}","received_events_url":"https://api.github.com/users/luckymarmot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/luckymarmot/Paw-BaseImporter","description":"Base abstract class for Paw importers","fork":false,"url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter","forks_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/forks","keys_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/teams","hooks_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/hooks","issue_events_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/issues/events{/number}","events_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/events","assignees_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/assignees{/user}","branches_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/branches{/branch}","tags_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/tags","blobs_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/statuses/{sha}","languages_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/languages","stargazers_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/stargazers","contributors_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/contributors","subscribers_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/subscribers","subscription_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/subscription","commits_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/contents/{+path}","compare_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/merges","archive_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/downloads","issues_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/issues{/number}","pulls_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/pulls{/number}","milestones_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/milestones{/number}","notifications_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/labels{/name}","releases_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/releases{/id}","deployments_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/deployments","created_at":"2016-03-31T07:51:36Z","updated_at":"2016-04-01T22:37:25Z","pushed_at":"2016-04-04T12:34:21Z","git_url":"git://github.com/luckymarmot/Paw-BaseImporter.git","ssh_url":"git@github.com:luckymarmot/Paw-BaseImporter.git","clone_url":"https://github.com/luckymarmot/Paw-BaseImporter.git","svn_url":"https://github.com/luckymarmot/Paw-BaseImporter","homepage":null,"size":12,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"luckymarmot:master","ref":"master","sha":"7e3e5dbcecefa1698514632d8dd5d5a5ed8d99b8","user":{"login":"luckymarmot","id":3215332,"avatar_url":"https://avatars.githubusercontent.com/u/3215332?v=3","gravatar_id":"","url":"https://api.github.com/users/luckymarmot","html_url":"https://github.com/luckymarmot","followers_url":"https://api.github.com/users/luckymarmot/followers","following_url":"https://api.github.com/users/luckymarmot/following{/other_user}","gists_url":"https://api.github.com/users/luckymarmot/gists{/gist_id}","starred_url":"https://api.github.com/users/luckymarmot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luckymarmot/subscriptions","organizations_url":"https://api.github.com/users/luckymarmot/orgs","repos_url":"https://api.github.com/users/luckymarmot/repos","events_url":"https://api.github.com/users/luckymarmot/events{/privacy}","received_events_url":"https://api.github.com/users/luckymarmot/received_events","type":"Organization","site_admin":false},"repo":{"id":55131041,"name":"Paw-BaseImporter","full_name":"luckymarmot/Paw-BaseImporter","owner":{"login":"luckymarmot","id":3215332,"avatar_url":"https://avatars.githubusercontent.com/u/3215332?v=3","gravatar_id":"","url":"https://api.github.com/users/luckymarmot","html_url":"https://github.com/luckymarmot","followers_url":"https://api.github.com/users/luckymarmot/followers","following_url":"https://api.github.com/users/luckymarmot/following{/other_user}","gists_url":"https://api.github.com/users/luckymarmot/gists{/gist_id}","starred_url":"https://api.github.com/users/luckymarmot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luckymarmot/subscriptions","organizations_url":"https://api.github.com/users/luckymarmot/orgs","repos_url":"https://api.github.com/users/luckymarmot/repos","events_url":"https://api.github.com/users/luckymarmot/events{/privacy}","received_events_url":"https://api.github.com/users/luckymarmot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/luckymarmot/Paw-BaseImporter","description":"Base abstract class for Paw importers","fork":false,"url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter","forks_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/forks","keys_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/teams","hooks_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/hooks","issue_events_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/issues/events{/number}","events_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/events","assignees_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/assignees{/user}","branches_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/branches{/branch}","tags_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/tags","blobs_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/statuses/{sha}","languages_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/languages","stargazers_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/stargazers","contributors_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/contributors","subscribers_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/subscribers","subscription_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/subscription","commits_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/contents/{+path}","compare_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/merges","archive_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/downloads","issues_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/issues{/number}","pulls_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/pulls{/number}","milestones_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/milestones{/number}","notifications_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/labels{/name}","releases_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/releases{/id}","deployments_url":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/deployments","created_at":"2016-03-31T07:51:36Z","updated_at":"2016-04-01T22:37:25Z","pushed_at":"2016-04-04T12:34:21Z","git_url":"git://github.com/luckymarmot/Paw-BaseImporter.git","ssh_url":"git@github.com:luckymarmot/Paw-BaseImporter.git","clone_url":"https://github.com/luckymarmot/Paw-BaseImporter.git","svn_url":"https://github.com/luckymarmot/Paw-BaseImporter","homepage":null,"size":12,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/pulls/2"},"html":{"href":"https://github.com/luckymarmot/Paw-BaseImporter/pull/2"},"issue":{"href":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/issues/2"},"comments":{"href":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/luckymarmot/Paw-BaseImporter/statuses/b5ab9c67329800110d58fcb7175b06e213c54749"}}}}