{"action":"created","issue":{"url":"https://api.github.com/repos/robotology/yarp/issues/862","repository_url":"https://api.github.com/repos/robotology/yarp","labels_url":"https://api.github.com/repos/robotology/yarp/issues/862/labels{/name}","comments_url":"https://api.github.com/repos/robotology/yarp/issues/862/comments","events_url":"https://api.github.com/repos/robotology/yarp/issues/862/events","html_url":"https://github.com/robotology/yarp/pull/862","id":170102350,"number":862,"title":"[WIP] Fix UDP and MCAST on macOS","user":{"login":"francesco-romano","id":2189180,"avatar_url":"https://avatars.githubusercontent.com/u/2189180?v=3","gravatar_id":"","url":"https://api.github.com/users/francesco-romano","html_url":"https://github.com/francesco-romano","followers_url":"https://api.github.com/users/francesco-romano/followers","following_url":"https://api.github.com/users/francesco-romano/following{/other_user}","gists_url":"https://api.github.com/users/francesco-romano/gists{/gist_id}","starred_url":"https://api.github.com/users/francesco-romano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francesco-romano/subscriptions","organizations_url":"https://api.github.com/users/francesco-romano/orgs","repos_url":"https://api.github.com/users/francesco-romano/repos","events_url":"https://api.github.com/users/francesco-romano/events{/privacy}","received_events_url":"https://api.github.com/users/francesco-romano/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/robotology/yarp/labels/Platform:%20macOS","name":"Platform: macOS","color":"009800"},{"url":"https://api.github.com/repos/robotology/yarp/labels/Severity:%20Major","name":"Severity: Major","color":"e11d21"},{"url":"https://api.github.com/repos/robotology/yarp/labels/Status:%20In%20Progress","name":"Status: In Progress","color":"ededed"},{"url":"https://api.github.com/repos/robotology/yarp/labels/Target:%20YARP%20v2.3.66.1","name":"Target: YARP v2.3.66.1","color":"d93f0b"},{"url":"https://api.github.com/repos/robotology/yarp/labels/Type:%20Bug","name":"Type: Bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"francesco-romano","id":2189180,"avatar_url":"https://avatars.githubusercontent.com/u/2189180?v=3","gravatar_id":"","url":"https://api.github.com/users/francesco-romano","html_url":"https://github.com/francesco-romano","followers_url":"https://api.github.com/users/francesco-romano/followers","following_url":"https://api.github.com/users/francesco-romano/following{/other_user}","gists_url":"https://api.github.com/users/francesco-romano/gists{/gist_id}","starred_url":"https://api.github.com/users/francesco-romano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francesco-romano/subscriptions","organizations_url":"https://api.github.com/users/francesco-romano/orgs","repos_url":"https://api.github.com/users/francesco-romano/repos","events_url":"https://api.github.com/users/francesco-romano/events{/privacy}","received_events_url":"https://api.github.com/users/francesco-romano/received_events","type":"User","site_admin":false},"assignees":[{"login":"francesco-romano","id":2189180,"avatar_url":"https://avatars.githubusercontent.com/u/2189180?v=3","gravatar_id":"","url":"https://api.github.com/users/francesco-romano","html_url":"https://github.com/francesco-romano","followers_url":"https://api.github.com/users/francesco-romano/followers","following_url":"https://api.github.com/users/francesco-romano/following{/other_user}","gists_url":"https://api.github.com/users/francesco-romano/gists{/gist_id}","starred_url":"https://api.github.com/users/francesco-romano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francesco-romano/subscriptions","organizations_url":"https://api.github.com/users/francesco-romano/orgs","repos_url":"https://api.github.com/users/francesco-romano/repos","events_url":"https://api.github.com/users/francesco-romano/events{/privacy}","received_events_url":"https://api.github.com/users/francesco-romano/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/robotology/yarp/milestones/7","html_url":"https://github.com/robotology/yarp/milestones/IFI%20Day%205","labels_url":"https://api.github.com/repos/robotology/yarp/milestones/7/labels","id":1923000,"number":7,"title":"IFI Day 5","description":"","creator":{"login":"drdanz","id":1100056,"avatar_url":"https://avatars.githubusercontent.com/u/1100056?v=3","gravatar_id":"","url":"https://api.github.com/users/drdanz","html_url":"https://github.com/drdanz","followers_url":"https://api.github.com/users/drdanz/followers","following_url":"https://api.github.com/users/drdanz/following{/other_user}","gists_url":"https://api.github.com/users/drdanz/gists{/gist_id}","starred_url":"https://api.github.com/users/drdanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drdanz/subscriptions","organizations_url":"https://api.github.com/users/drdanz/orgs","repos_url":"https://api.github.com/users/drdanz/repos","events_url":"https://api.github.com/users/drdanz/events{/privacy}","received_events_url":"https://api.github.com/users/drdanz/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":17,"state":"open","created_at":"2016-08-04T07:38:23Z","updated_at":"2016-08-09T07:47:49Z","due_on":"2016-08-04T22:00:00Z","closed_at":null},"comments":2,"created_at":"2016-08-09T07:47:49Z","updated_at":"2016-08-09T15:50:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/robotology/yarp/pulls/862","html_url":"https://github.com/robotology/yarp/pull/862","diff_url":"https://github.com/robotology/yarp/pull/862.diff","patch_url":"https://github.com/robotology/yarp/pull/862.patch"},"body":"Fixes #637 \r\n\r\nThis PR fixes UDP and MCAST on macOS.\r\n\r\n**UDP**\r\nCurrently the updated code is included in an `#ifdef __APPLE__` so other OSes should not see any changes in UDP.\r\nAnyway, as discussed with @apaikan probably we should trust more the kernel engineers of the various OSes and their choice for socket buffers.\r\nIn the current macOS implementation thus, the default for the socket buffers are taken from the operating system configuration. Nevertheless they can be overwritten by environment variables.\r\n\r\nWhat about a test (both of compilation and performance) also on other OSes (i.e. Linux and Windows). In this case a manual intervention is needed as the `#ifdef` block should be substituted the older block\r\n\r\n**MCAST**\r\n[Related issue on ACE](https://github.com/DOCGroup/ACE_TAO/issues/281)\r\n\r\nIt seems that the ACE defaults for MCAST are not suited to macOS (at least on modern hardware and software). I overwritten the defaults in case macOS is used.\r\n\r\n@drdanz what do you think of putting in the release notes the corresponding issue if present?\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/robotology/yarp/pull/862%23issuecomment-238479914%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/robotology/yarp/pull/862%23issuecomment-238479914%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22WIP%20flag%20waiting%20for%20some%20updates%20in%20the%20ACE%20issue.%22%2C%20%22created_at%22%3A%20%222016-08-09T07%3A52%3A31Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/2189180%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/francesco-romano%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/robotology/yarp/pull/862#issuecomment-238479914'>General Comment</a></b>\n- <a href='https://github.com/francesco-romano'><img border=0 src='https://avatars.githubusercontent.com/u/2189180?v=3' height=16 width=16'></a> WIP flag waiting for some updates in the ACE issue.\n\n\n<a href='https://www.codereviewhub.com/robotology/yarp/pull/862?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/robotology/yarp/pull/862?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/robotology/yarp/pull/862'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>"},"comment":{"url":"https://api.github.com/repos/robotology/yarp/issues/comments/238597499","html_url":"https://github.com/robotology/yarp/pull/862#issuecomment-238597499","issue_url":"https://api.github.com/repos/robotology/yarp/issues/862","id":238597499,"user":{"login":"francesco-romano","id":2189180,"avatar_url":"https://avatars.githubusercontent.com/u/2189180?v=3","gravatar_id":"","url":"https://api.github.com/users/francesco-romano","html_url":"https://github.com/francesco-romano","followers_url":"https://api.github.com/users/francesco-romano/followers","following_url":"https://api.github.com/users/francesco-romano/following{/other_user}","gists_url":"https://api.github.com/users/francesco-romano/gists{/gist_id}","starred_url":"https://api.github.com/users/francesco-romano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francesco-romano/subscriptions","organizations_url":"https://api.github.com/users/francesco-romano/orgs","repos_url":"https://api.github.com/users/francesco-romano/repos","events_url":"https://api.github.com/users/francesco-romano/events{/privacy}","received_events_url":"https://api.github.com/users/francesco-romano/received_events","type":"User","site_admin":false},"created_at":"2016-08-09T15:50:33Z","updated_at":"2016-08-09T15:50:33Z","body":"Todo to self: remove (or check) error messages in the code."}}
{"actor":{"display_login":"francesco-romano"}}