{"action":"closed","number":462,"pull_request":{"url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/pulls/462","id":98817080,"html_url":"https://github.com/Particular/NServiceBus.AzureServiceBus/pull/462","diff_url":"https://github.com/Particular/NServiceBus.AzureServiceBus/pull/462.diff","patch_url":"https://github.com/Particular/NServiceBus.AzureServiceBus/pull/462.patch","issue_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/issues/462","number":462,"state":"closed","locked":false,"title":"Subscription not removed when unsubscribing with EndpointOrientedTopology","user":{"login":"SeanFeldman","id":1309622,"avatar_url":"https://avatars.githubusercontent.com/u/1309622?v=3","gravatar_id":"","url":"https://api.github.com/users/SeanFeldman","html_url":"https://github.com/SeanFeldman","followers_url":"https://api.github.com/users/SeanFeldman/followers","following_url":"https://api.github.com/users/SeanFeldman/following{/other_user}","gists_url":"https://api.github.com/users/SeanFeldman/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanFeldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanFeldman/subscriptions","organizations_url":"https://api.github.com/users/SeanFeldman/orgs","repos_url":"https://api.github.com/users/SeanFeldman/repos","events_url":"https://api.github.com/users/SeanFeldman/events{/privacy}","received_events_url":"https://api.github.com/users/SeanFeldman/received_events","type":"User","site_admin":false},"body":"## Who's affected\r\n\r\n- Anyone that requires to be able to unsubscribe endpoints from events and using `EndpointOrientedTopology`\r\n\r\n## Symptoms\r\n\r\nUnsubscribe requests are not persisted, causing unsubscribed endpoints continue receiving events after those endpoints were restarts.\r\n\r\n## Details\r\n\r\nSimilar to the issue that was found in `ForwardingTopology` (#392).\r\n\r\nThe request to unsubscribe should be modifying topologies. [Currently](https://github.com/Particular/NServiceBus.AzureServiceBus/blob/e5f64e929ecf7ff2227541870ae9a2c243ed9222/src/Transport/Seam/SubscriptionManager.cs#L28) it doesn't.\r\n\r\nFor the `EndpointOrientedTopology`, subscriber should remove the subscription from the publisher.events topic.\r\n\r\nThis could cause events to accumulate under subscription that is no longer monitored. If there's a high volume of these events, subscription could eventually overflood and cause production degradation.\r\n\r\n#### TODO\r\n- [ ] backport to `support-7.0`\r\n- [ ] port changes to `develop`\r\n\r\n@Particular/azure-maintainers please review","created_at":"2016-12-20T20:11:26Z","updated_at":"2016-12-27T08:56:39Z","closed_at":"2016-12-27T08:56:39Z","merged_at":"2016-12-27T08:56:39Z","merge_commit_sha":"d786e27182da36b4bc4bff8553f21a48004090cf","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/milestones/19","html_url":"https://github.com/Particular/NServiceBus.AzureServiceBus/milestone/19","labels_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/milestones/19/labels","id":2206670,"number":19,"title":"7.1.1","description":null,"creator":{"login":"SeanFeldman","id":1309622,"avatar_url":"https://avatars.githubusercontent.com/u/1309622?v=3","gravatar_id":"","url":"https://api.github.com/users/SeanFeldman","html_url":"https://github.com/SeanFeldman","followers_url":"https://api.github.com/users/SeanFeldman/followers","following_url":"https://api.github.com/users/SeanFeldman/following{/other_user}","gists_url":"https://api.github.com/users/SeanFeldman/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanFeldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanFeldman/subscriptions","organizations_url":"https://api.github.com/users/SeanFeldman/orgs","repos_url":"https://api.github.com/users/SeanFeldman/repos","events_url":"https://api.github.com/users/SeanFeldman/events{/privacy}","received_events_url":"https://api.github.com/users/SeanFeldman/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":1,"state":"open","created_at":"2016-12-20T08:05:44Z","updated_at":"2016-12-27T08:56:39Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/pulls/462/commits","review_comments_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/pulls/462/comments","review_comment_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/issues/462/comments","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/statuses/b90179111cb37e80c6222129eb9007c6cbf75476","head":{"label":"Particular:issue-459-subscription-not-removed","ref":"issue-459-subscription-not-removed","sha":"b90179111cb37e80c6222129eb9007c6cbf75476","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":29854622,"name":"NServiceBus.AzureServiceBus","full_name":"Particular/NServiceBus.AzureServiceBus","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus.AzureServiceBus","description":"The Azure ServiceBus Transport","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus","forks_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/deployments","created_at":"2015-01-26T09:43:55Z","updated_at":"2016-11-24T17:55:04Z","pushed_at":"2016-12-27T08:56:39Z","git_url":"git://github.com/Particular/NServiceBus.AzureServiceBus.git","ssh_url":"git@github.com:Particular/NServiceBus.AzureServiceBus.git","clone_url":"https://github.com/Particular/NServiceBus.AzureServiceBus.git","svn_url":"https://github.com/Particular/NServiceBus.AzureServiceBus","homepage":"https://docs.particular.net/nservicebus/azure-service-bus/","size":3386,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":31,"forks":12,"open_issues":31,"watchers":3,"default_branch":"develop"}},"base":{"label":"Particular:hotfix-7.1.1","ref":"hotfix-7.1.1","sha":"de015b72a0afb70c3528e27659c925c482d62a8f","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":29854622,"name":"NServiceBus.AzureServiceBus","full_name":"Particular/NServiceBus.AzureServiceBus","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus.AzureServiceBus","description":"The Azure ServiceBus Transport","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus","forks_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/deployments","created_at":"2015-01-26T09:43:55Z","updated_at":"2016-11-24T17:55:04Z","pushed_at":"2016-12-27T08:56:39Z","git_url":"git://github.com/Particular/NServiceBus.AzureServiceBus.git","ssh_url":"git@github.com:Particular/NServiceBus.AzureServiceBus.git","clone_url":"https://github.com/Particular/NServiceBus.AzureServiceBus.git","svn_url":"https://github.com/Particular/NServiceBus.AzureServiceBus","homepage":"https://docs.particular.net/nservicebus/azure-service-bus/","size":3386,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":31,"forks":12,"open_issues":31,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/pulls/462"},"html":{"href":"https://github.com/Particular/NServiceBus.AzureServiceBus/pull/462"},"issue":{"href":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/issues/462"},"comments":{"href":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/issues/462/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/pulls/462/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/pulls/462/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/statuses/b90179111cb37e80c6222129eb9007c6cbf75476"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"yvesgoeleven","id":471354,"avatar_url":"https://avatars.githubusercontent.com/u/471354?v=3","gravatar_id":"","url":"https://api.github.com/users/yvesgoeleven","html_url":"https://github.com/yvesgoeleven","followers_url":"https://api.github.com/users/yvesgoeleven/followers","following_url":"https://api.github.com/users/yvesgoeleven/following{/other_user}","gists_url":"https://api.github.com/users/yvesgoeleven/gists{/gist_id}","starred_url":"https://api.github.com/users/yvesgoeleven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yvesgoeleven/subscriptions","organizations_url":"https://api.github.com/users/yvesgoeleven/orgs","repos_url":"https://api.github.com/users/yvesgoeleven/repos","events_url":"https://api.github.com/users/yvesgoeleven/events{/privacy}","received_events_url":"https://api.github.com/users/yvesgoeleven/received_events","type":"User","site_admin":false},"comments":8,"review_comments":12,"maintainer_can_modify":false,"commits":9,"additions":251,"deletions":18,"changed_files":6}}
{"actor":{"display_login":"yvesgoeleven"}}