{"comment":{"url":"https://api.github.com/repos/zhengyangl/safecode-llvm37/comments/18223958","html_url":"https://github.com/zhengyangl/safecode-llvm37/commit/320b4908930f20fa62cf97d97f087d6534541a7d#commitcomment-18223958","id":18223958,"user":{"login":"zhengyangl","id":2017989,"avatar_url":"https://avatars.githubusercontent.com/u/2017989?v=3","gravatar_id":"","url":"https://api.github.com/users/zhengyangl","html_url":"https://github.com/zhengyangl","followers_url":"https://api.github.com/users/zhengyangl/followers","following_url":"https://api.github.com/users/zhengyangl/following{/other_user}","gists_url":"https://api.github.com/users/zhengyangl/gists{/gist_id}","starred_url":"https://api.github.com/users/zhengyangl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhengyangl/subscriptions","organizations_url":"https://api.github.com/users/zhengyangl/orgs","repos_url":"https://api.github.com/users/zhengyangl/repos","events_url":"https://api.github.com/users/zhengyangl/events{/privacy}","received_events_url":"https://api.github.com/users/zhengyangl/received_events","type":"User","site_admin":false},"position":12,"line":16,"path":"projects/poolalloc/lib/DSA/Makefile","commit_id":"320b4908930f20fa62cf97d97f087d6534541a7d","created_at":"2016-07-13T05:26:32Z","updated_at":"2016-07-13T05:26:32Z","body":"The /project/safecode compilation needs libLLVMDataStructure.a as a dependency. If we set LOADABLE_MODULE, according the following lines from /Makefile.rule.\r\n\r\n```\r\n###############################################################################\r\n# Library Build Rules: Four ways to build a library\r\n###############################################################################\r\n\r\n# if we're building a library ...\r\nifdef LIBRARYNAME\r\n\r\n# Make sure there isn't any extraneous whitespace on the LIBRARYNAME option\r\nLIBRARYNAME := $(strip $(LIBRARYNAME))\r\nLIBRARYALIASNAME := $(strip $(LIBRARYALIASNAME))\r\nifdef LOADABLE_MODULE\r\nBaseLibName.A  := $(LIBRARYNAME).a\r\nBaseLibName.SO := $(LIBRARYNAME)$(SHLIBEXT)\r\nBaseAliasName.SO := $(LIBRARYALIASNAME)$(SHLIBEXT)\r\nelse\r\nBaseLibName.A  := lib$(LIBRARYNAME).a\r\nBaseLibName.SO := $(SharedPrefix)$(LIBRARYNAME)$(SHLIBEXT)\r\nBaseAliasName.SO := $(SharedPrefix)$(LIBRARYALIASNAME)$(SHLIBEXT)\r\nendif\r\nLibName.A  := $(LibDir)/$(BaseLibName.A)\r\nLibName.SO := $(SharedLibDir)/$(BaseLibName.SO)\r\nAliasName.SO := $(SharedLibDir)/$(BaseAliasName.SO)\r\nLibName.O  := $(LibDir)/$(LIBRARYNAME).o\r\n```\r\nThe build infrastructure will generate LLVMDataStructure.a, not libLLVMDataStructure.a, this will cause a error when building.\r\n\r\nWe need libLLVMDatastructure.a, so we will not set LOADABLE_MODULE."}}
{"actor":{"display_login":"zhengyangl"}}