{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic/pulls/comments/78426913","id":78426913,"diff_hunk":"@@ -242,7 +245,77 @@ func (s *System) UnsubscribeFromEvents(chan interface{}) {\n \n func (s *System) AuthenticateToRegistry(ctx context.Context, authConfig *types.AuthConfig) (string, string, error) {\n \tdefer trace.End(trace.Begin(\"\"))\n-\treturn RegistryService.Auth(authConfig, dockerversion.DockerUserAgent(ctx))\n+\n+\tfetcher := urlfetcher.NewURLFetcher(urlfetcher.FetcherOptions{\n+\t\tTimeout:  loginTimeout,\n+\t\tUsername: authConfig.Username,\n+\t\tPassword: authConfig.Password,\n+\t})\n+\n+\t// Only look at V2 registries\n+\tvar registryAddress string\n+\tif strings.Contains(authConfig.ServerAddress, \"/v2\") {\n+\t\tregistryAddress = authConfig.ServerAddress\n+\t} else {\n+\t\tregistryAddress = authConfig.ServerAddress + \"/v2/\"\n+\t}\n+\n+\tregistryUrl, err := url.Parse(registryAddress)\n+\tif err != nil {\n+\t\tmsg := fmt.Sprintf(\"Bad login address: %s\", registryAddress)\n+\t\tlog.Debugf(msg)","path":"lib/apiservers/engine/backends/system.go","position":53,"original_position":53,"commit_id":"7f93d75a7f3087a6696f0a6fb950f5620a4d5d21","original_commit_id":"7f93d75a7f3087a6696f0a6fb950f5620a4d5d21","user":{"login":"caglar10ur","id":205498,"avatar_url":"https://avatars.githubusercontent.com/u/205498?v=3","gravatar_id":"","url":"https://api.github.com/users/caglar10ur","html_url":"https://github.com/caglar10ur","followers_url":"https://api.github.com/users/caglar10ur/followers","following_url":"https://api.github.com/users/caglar10ur/following{/other_user}","gists_url":"https://api.github.com/users/caglar10ur/gists{/gist_id}","starred_url":"https://api.github.com/users/caglar10ur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caglar10ur/subscriptions","organizations_url":"https://api.github.com/users/caglar10ur/orgs","repos_url":"https://api.github.com/users/caglar10ur/repos","events_url":"https://api.github.com/users/caglar10ur/events{/privacy}","received_events_url":"https://api.github.com/users/caglar10ur/received_events","type":"User","site_admin":false},"body":"s/Debugf/Errorf/g","created_at":"2016-09-12T18:23:53Z","updated_at":"2016-09-12T18:23:53Z","html_url":"https://github.com/vmware/vic/pull/2259#discussion_r78426913","pull_request_url":"https://api.github.com/repos/vmware/vic/pulls/2259","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments/78426913"},"html":{"href":"https://github.com/vmware/vic/pull/2259#discussion_r78426913"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic/pulls/2259"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/2259","id":84220567,"html_url":"https://github.com/vmware/vic/pull/2259","diff_url":"https://github.com/vmware/vic/pull/2259.diff","patch_url":"https://github.com/vmware/vic/pull/2259.patch","issue_url":"https://api.github.com/repos/vmware/vic/issues/2259","number":2259,"state":"open","locked":false,"title":"Use imagec fetcher for login","user":{"login":"sflxn","id":1330508,"avatar_url":"https://avatars.githubusercontent.com/u/1330508?v=3","gravatar_id":"","url":"https://api.github.com/users/sflxn","html_url":"https://github.com/sflxn","followers_url":"https://api.github.com/users/sflxn/followers","following_url":"https://api.github.com/users/sflxn/following{/other_user}","gists_url":"https://api.github.com/users/sflxn/gists{/gist_id}","starred_url":"https://api.github.com/users/sflxn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sflxn/subscriptions","organizations_url":"https://api.github.com/users/sflxn/orgs","repos_url":"https://api.github.com/users/sflxn/repos","events_url":"https://api.github.com/users/sflxn/events{/privacy}","received_events_url":"https://api.github.com/users/sflxn/received_events","type":"User","site_admin":false},"body":"Refactored fetcher to separate auth and layer fetching. Moved\r\nit to pkg/registry.  Updated the personality server's login to\r\nuse the fetcher code for login to match up the login and pull\r\nauth code.","created_at":"2016-09-07T00:49:23Z","updated_at":"2016-09-12T18:23:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc11f258bc44e9b4cd1b304fe0800b8b512c08e2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic/pulls/2259/commits","review_comments_url":"https://api.github.com/repos/vmware/vic/pulls/2259/comments","review_comment_url":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic/issues/2259/comments","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/7f93d75a7f3087a6696f0a6fb950f5620a4d5d21","head":{"label":"sflxn:docker-login","ref":"docker-login","sha":"7f93d75a7f3087a6696f0a6fb950f5620a4d5d21","user":{"login":"sflxn","id":1330508,"avatar_url":"https://avatars.githubusercontent.com/u/1330508?v=3","gravatar_id":"","url":"https://api.github.com/users/sflxn","html_url":"https://github.com/sflxn","followers_url":"https://api.github.com/users/sflxn/followers","following_url":"https://api.github.com/users/sflxn/following{/other_user}","gists_url":"https://api.github.com/users/sflxn/gists{/gist_id}","starred_url":"https://api.github.com/users/sflxn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sflxn/subscriptions","organizations_url":"https://api.github.com/users/sflxn/orgs","repos_url":"https://api.github.com/users/sflxn/repos","events_url":"https://api.github.com/users/sflxn/events{/privacy}","received_events_url":"https://api.github.com/users/sflxn/received_events","type":"User","site_admin":false},"repo":{"id":55453338,"name":"vic","full_name":"sflxn/vic","owner":{"login":"sflxn","id":1330508,"avatar_url":"https://avatars.githubusercontent.com/u/1330508?v=3","gravatar_id":"","url":"https://api.github.com/users/sflxn","html_url":"https://github.com/sflxn","followers_url":"https://api.github.com/users/sflxn/followers","following_url":"https://api.github.com/users/sflxn/following{/other_user}","gists_url":"https://api.github.com/users/sflxn/gists{/gist_id}","starred_url":"https://api.github.com/users/sflxn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sflxn/subscriptions","organizations_url":"https://api.github.com/users/sflxn/orgs","repos_url":"https://api.github.com/users/sflxn/repos","events_url":"https://api.github.com/users/sflxn/events{/privacy}","received_events_url":"https://api.github.com/users/sflxn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sflxn/vic","description":"Integrated containers on vSphere","fork":true,"url":"https://api.github.com/repos/sflxn/vic","forks_url":"https://api.github.com/repos/sflxn/vic/forks","keys_url":"https://api.github.com/repos/sflxn/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sflxn/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sflxn/vic/teams","hooks_url":"https://api.github.com/repos/sflxn/vic/hooks","issue_events_url":"https://api.github.com/repos/sflxn/vic/issues/events{/number}","events_url":"https://api.github.com/repos/sflxn/vic/events","assignees_url":"https://api.github.com/repos/sflxn/vic/assignees{/user}","branches_url":"https://api.github.com/repos/sflxn/vic/branches{/branch}","tags_url":"https://api.github.com/repos/sflxn/vic/tags","blobs_url":"https://api.github.com/repos/sflxn/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sflxn/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sflxn/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/sflxn/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sflxn/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/sflxn/vic/languages","stargazers_url":"https://api.github.com/repos/sflxn/vic/stargazers","contributors_url":"https://api.github.com/repos/sflxn/vic/contributors","subscribers_url":"https://api.github.com/repos/sflxn/vic/subscribers","subscription_url":"https://api.github.com/repos/sflxn/vic/subscription","commits_url":"https://api.github.com/repos/sflxn/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/sflxn/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/sflxn/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/sflxn/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/sflxn/vic/contents/{+path}","compare_url":"https://api.github.com/repos/sflxn/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sflxn/vic/merges","archive_url":"https://api.github.com/repos/sflxn/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sflxn/vic/downloads","issues_url":"https://api.github.com/repos/sflxn/vic/issues{/number}","pulls_url":"https://api.github.com/repos/sflxn/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/sflxn/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/sflxn/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sflxn/vic/labels{/name}","releases_url":"https://api.github.com/repos/sflxn/vic/releases{/id}","deployments_url":"https://api.github.com/repos/sflxn/vic/deployments","created_at":"2016-04-04T23:42:42Z","updated_at":"2016-04-04T23:42:44Z","pushed_at":"2016-09-07T00:23:54Z","git_url":"git://github.com/sflxn/vic.git","ssh_url":"git@github.com:sflxn/vic.git","clone_url":"https://github.com/sflxn/vic.git","svn_url":"https://github.com/sflxn/vic","homepage":null,"size":28868,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"dcd3c4f1e173748b27ed13cde5b87a91e36bf68c","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49597898,"name":"vic","full_name":"vmware/vic","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic","description":"Integrated containers on vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic","forks_url":"https://api.github.com/repos/vmware/vic/forks","keys_url":"https://api.github.com/repos/vmware/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic/teams","hooks_url":"https://api.github.com/repos/vmware/vic/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic/events","assignees_url":"https://api.github.com/repos/vmware/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic/tags","blobs_url":"https://api.github.com/repos/vmware/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic/languages","stargazers_url":"https://api.github.com/repos/vmware/vic/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic/subscription","commits_url":"https://api.github.com/repos/vmware/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic/merges","archive_url":"https://api.github.com/repos/vmware/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic/downloads","issues_url":"https://api.github.com/repos/vmware/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic/deployments","created_at":"2016-01-13T19:53:57Z","updated_at":"2016-09-12T02:14:29Z","pushed_at":"2016-09-12T18:01:21Z","git_url":"git://github.com/vmware/vic.git","ssh_url":"git@github.com:vmware/vic.git","clone_url":"https://github.com/vmware/vic.git","svn_url":"https://github.com/vmware/vic","homepage":null,"size":79415,"stargazers_count":129,"watchers_count":129,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":47,"mirror_url":null,"open_issues_count":496,"forks":47,"open_issues":496,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/2259"},"html":{"href":"https://github.com/vmware/vic/pull/2259"},"issue":{"href":"https://api.github.com/repos/vmware/vic/issues/2259"},"comments":{"href":"https://api.github.com/repos/vmware/vic/issues/2259/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic/pulls/2259/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic/pulls/2259/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic/statuses/7f93d75a7f3087a6696f0a6fb950f5620a4d5d21"}}}}
{"actor":{"display_login":"caglar10ur"}}