{"action":"created","comment":{"url":"https://api.github.com/repos/xie8899/project/pulls/comments/55155323","id":55155323,"diff_hunk":"@@ -0,0 +1,56 @@\n+# -*- coding: utf-8 -*-\n+# © 2016 Elico Corp (https://www.elico-corp.com).\n+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).\n+from openerp import api, fields, models\n+\n+\n+class BusinessRequirementDeliverable(models.Model):\n+    _inherit = \"business.requirement.deliverable\"\n+\n+    def _prepare_resouce_lines(self):","path":"business_requirement_deliverable_default/models/business_requirement_deliverable_default.py","position":10,"original_position":10,"commit_id":"e5f606b282acdd47c03ce45799520c308d292148","original_commit_id":"e5f606b282acdd47c03ce45799520c308d292148","user":{"login":"elicoidal","id":7600613,"avatar_url":"https://avatars.githubusercontent.com/u/7600613?v=3","gravatar_id":"","url":"https://api.github.com/users/elicoidal","html_url":"https://github.com/elicoidal","followers_url":"https://api.github.com/users/elicoidal/followers","following_url":"https://api.github.com/users/elicoidal/following{/other_user}","gists_url":"https://api.github.com/users/elicoidal/gists{/gist_id}","starred_url":"https://api.github.com/users/elicoidal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elicoidal/subscriptions","organizations_url":"https://api.github.com/users/elicoidal/orgs","repos_url":"https://api.github.com/users/elicoidal/repos","events_url":"https://api.github.com/users/elicoidal/events{/privacy}","received_events_url":"https://api.github.com/users/elicoidal/received_events","type":"User","site_admin":false},"body":"@victormartinelicocorp you misunderstood me: the name is misspelled in the original method","created_at":"2016-03-07T02:04:00Z","updated_at":"2016-03-07T02:04:00Z","html_url":"https://github.com/xie8899/project/pull/14#discussion_r55155323","pull_request_url":"https://api.github.com/repos/xie8899/project/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/xie8899/project/pulls/comments/55155323"},"html":{"href":"https://github.com/xie8899/project/pull/14#discussion_r55155323"},"pull_request":{"href":"https://api.github.com/repos/xie8899/project/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/xie8899/project/pulls/14","id":60123783,"html_url":"https://github.com/xie8899/project/pull/14","diff_url":"https://github.com/xie8899/project/pull/14.diff","patch_url":"https://github.com/xie8899/project/pull/14.patch","issue_url":"https://api.github.com/repos/xie8899/project/issues/14","number":14,"state":"open","locked":false,"title":"[ADD] business_requirement_deliverable_default: BR000092.","user":{"login":"victormartinelicocorp","id":16461806,"avatar_url":"https://avatars.githubusercontent.com/u/16461806?v=3","gravatar_id":"","url":"https://api.github.com/users/victormartinelicocorp","html_url":"https://github.com/victormartinelicocorp","followers_url":"https://api.github.com/users/victormartinelicocorp/followers","following_url":"https://api.github.com/users/victormartinelicocorp/following{/other_user}","gists_url":"https://api.github.com/users/victormartinelicocorp/gists{/gist_id}","starred_url":"https://api.github.com/users/victormartinelicocorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victormartinelicocorp/subscriptions","organizations_url":"https://api.github.com/users/victormartinelicocorp/orgs","repos_url":"https://api.github.com/users/victormartinelicocorp/repos","events_url":"https://api.github.com/users/victormartinelicocorp/events{/privacy}","received_events_url":"https://api.github.com/users/victormartinelicocorp/received_events","type":"User","site_admin":false},"body":"[ADD] business_requirement_deliverable_default: BR000092.\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/xie8899/project/pull/14%23issuecomment-187030317%22%2C%20%22https%3A//github.com/xie8899/project/pull/14%23issuecomment-187515335%22%2C%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r53589289%22%2C%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r53598231%22%2C%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r53601129%22%2C%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r53733487%22%2C%20%22https%3A//github.com/xie8899/project/pull/14%23issuecomment-191673735%22%2C%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r54854952%22%2C%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r54855427%22%2C%20%22https%3A//github.com/xie8899/project/pull/14%23issuecomment-191680897%22%2C%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r54856632%22%2C%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r54857017%22%2C%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r54857078%22%2C%20%22https%3A//github.com/xie8899/project/pull/14%23issuecomment-191686206%22%2C%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r54857806%22%2C%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r54857900%22%2C%20%22https%3A//github.com/xie8899/project/pull/14%23issuecomment-191689765%22%2C%20%22https%3A//github.com/xie8899/project/pull/14%23issuecomment-191690100%22%2C%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r54991682%22%2C%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r54993187%22%2C%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r55154695%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/xie8899/project/pull/14%23issuecomment-187030317%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%40victormartinelicocorp%20%20I%20miss%20the%20unit%20test.%22%2C%20%22created_at%22%3A%20%222016-02-22T06%3A16%3A43Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/3785252%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/duanyp1991%22%7D%7D%2C%20%7B%22body%22%3A%20%22cc%20%40duanyp1991%20%22%2C%20%22created_at%22%3A%20%222016-02-23T03%3A57%3A46Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/16461806%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/victormartinelicocorp%22%7D%7D%2C%20%7B%22body%22%3A%20%22LGTM%22%2C%20%22created_at%22%3A%20%222016-03-03T09%3A23%3A33Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/3785252%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/duanyp1991%22%7D%7D%2C%20%7B%22body%22%3A%20%22Others%20LGTM%22%2C%20%22created_at%22%3A%20%222016-03-03T09%3A43%3A17Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/12975184%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/siyuancn%22%7D%7D%2C%20%7B%22body%22%3A%20%22some%20small%20details.%20needs%20to%20be%20tested.%20other%20than%20that%20LGTM%22%2C%20%22created_at%22%3A%20%222016-03-03T09%3A54%3A32Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7600613%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/elicoidal%22%7D%7D%2C%20%7B%22body%22%3A%20%22%40siyuancn%20by%20the%20way%20can%20you%20install%20it%20in%20our%20ERP%20so%20that%20I%20can%20test%20it%3F%22%2C%20%22created_at%22%3A%20%222016-03-03T10%3A00%3A06Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7600613%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/elicoidal%22%7D%7D%2C%20%7B%22body%22%3A%20%22%40elicoidal%20I%20will%20do%20it%20when%20the%20pr%20is%20merged.%22%2C%20%22created_at%22%3A%20%222016-03-03T10%3A01%3A30Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/12975184%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/siyuancn%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%2C%20%22Pull%20d56ddb2bfa033f191c955d6bda3565b355ea6117%20business_requirement_deliverable_default/models/business_requirement_deliverable_default.py%2049%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r53601129%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22copy%3DFalse%22%2C%20%22created_at%22%3A%20%222016-02-22T09%3A24%3A24Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/3785252%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/duanyp1991%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_default/models/business_requirement_deliverable_default.py%3AL1-51%22%7D%2C%20%22Pull%20e5f606b282acdd47c03ce45799520c308d292148%20business_requirement_deliverable_default/models/business_requirement_deliverable_default.py%2011%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r54855427%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22can%20resource_lines%20be%20empty%3F%22%2C%20%22created_at%22%3A%20%222016-03-03T09%3A36%3A33Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/12975184%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/siyuancn%22%7D%7D%2C%20%7B%22body%22%3A%20%22%40siyuancn%20Yes%2C%20but%20in%20that%20case%20it%20will%20return%20an%20empty%20list%20%60%5B%5D%60%20so%20nothing%20to%20do%20update%20in%20that%20case.%20It%20also%20tested%20because%20it%27s%20mostly%20the%20state%20for%20Products%20%28I%20have%20to%20put%20some%20resources%20in%20one%20or%20two%20products%2C%20so%20it%20have%20resources%20and%20the%20others%20not%29.%22%2C%20%22created_at%22%3A%20%222016-03-04T05%3A29%3A47Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/16461806%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/victormartinelicocorp%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_default/models/business_requirement_deliverable_default.py%3AL1-57%22%7D%2C%20%22Pull%20e5f606b282acdd47c03ce45799520c308d292148%20business_requirement_deliverable_default/README.rst%2044%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r54857900%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22remove%20section%22%2C%20%22created_at%22%3A%20%222016-03-03T09%3A57%3A52Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7600613%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/elicoidal%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_default/README.rst%3AL1-83%22%7D%2C%20%22Pull%20e5f606b282acdd47c03ce45799520c308d292148%20business_requirement_deliverable_default/__init__.py%205%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r54854952%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22no%20need%20import%20tests%20%28unit%20test%29%20in%20__init__.py%22%2C%20%22created_at%22%3A%20%222016-03-03T09%3A32%3A11Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/12975184%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/siyuancn%22%7D%7D%2C%20%7B%22body%22%3A%20%22Do%20not%20import%20tests%20in%20%60__init__.py%60.%22%2C%20%22created_at%22%3A%20%222016-03-07T01%3A45%3A26Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/3785252%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/duanyp1991%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_default/__init__.py%3AL1-6%22%7D%2C%20%22Pull%20e5f606b282acdd47c03ce45799520c308d292148%20business_requirement_deliverable_default/models/business_requirement_deliverable_default.py%2010%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r54856632%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22resource%22%2C%20%22created_at%22%3A%20%222016-03-03T09%3A47%3A25Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7600613%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/elicoidal%22%7D%7D%2C%20%7B%22body%22%3A%20%22%40elicoidal%20As%20far%20I%20read%20there%20is%20no%20rule%20for%20this%20kind%20of%20method%20that%20is%20just%20auxiliary%20%28because%20this%20method%20is%20only%20called%20by%20others%20methods%29.%20So%20for%20me%20it%20is%20better%20to%20have%20a%20self%20descriptive%20name%20and%20naming%20just%20%60resource%60%20for%20me%20is%20not%20desirable.%20%40duanyp1991%20and%20%40siyuancn%20%20Do%20you%20agree%20with%20me%3F%5Cr%5Cn%5Cr%5Cncc%20%40duanyp1991%20%40siyuancn%20%40elicoidal%20%22%2C%20%22created_at%22%3A%20%222016-03-04T06%3A00%3A22Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/16461806%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/victormartinelicocorp%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_default/models/business_requirement_deliverable_default.py%3AL1-57%22%7D%2C%20%22Pull%20d56ddb2bfa033f191c955d6bda3565b355ea6117%20business_requirement_deliverable_default/models/business_requirement_deliverable_default.py%2015%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r53589289%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%60api.one%60%20is%20deprecated%20in%20v9%22%2C%20%22created_at%22%3A%20%222016-02-22T06%3A15%3A13Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/3785252%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/duanyp1991%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_default/models/business_requirement_deliverable_default.py%3AL1-51%22%7D%2C%20%22Pull%20e5f606b282acdd47c03ce45799520c308d292148%20business_requirement_deliverable_default/README.rst%209%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r54857017%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22s/%28%5C%22Business%20Requirement%5C%22%29%20links/%28%5C%22Business%20Requirement%5C%22%29%20and%20links%22%2C%20%22created_at%22%3A%20%222016-03-03T09%3A50%3A35Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7600613%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/elicoidal%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_default/README.rst%3AL1-83%22%7D%2C%20%22Pull%20d56ddb2bfa033f191c955d6bda3565b355ea6117%20business_requirement_deliverable_default/models/business_requirement_deliverable_default.py%2012%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r53598231%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%60%60%60python%5Cr%5Cn%5B%280%2C%200%2C%20x%29%20for%20x%20in%20rl_data%5D%5Cr%5Cn%60%60%60%22%2C%20%22created_at%22%3A%20%222016-02-22T08%3A51%3A43Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/3785252%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/duanyp1991%22%7D%7D%2C%20%7B%22body%22%3A%20%22%40duanyp1991%20According%20to%20functionality%20we%20had%20discuss%20yesterday%20I%20changed%20it%20by%20%5C%22Update%5C%22%20to%20add%20new%20resource_lines%20without%20duplicate%20or%20delete%20previous%20resources.%5Cr%5Cn%60%5B%281%2C%20ids%5Bindex%5D%2C%20item%29%20for%20index%2C%20item%20in%20enumerate%28rl_data%29%5D%60%5Cr%5Cn%5Cr%5Cn%5Cr%5Cn%20%22%2C%20%22created_at%22%3A%20%222016-02-23T03%3A49%3A57Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/16461806%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/victormartinelicocorp%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_default/models/business_requirement_deliverable_default.py%3AL1-51%22%7D%2C%20%22Pull%20e5f606b282acdd47c03ce45799520c308d292148%20business_requirement_deliverable_default/README.rst%2017%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r54857806%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22move%20to%20usage%20section%22%2C%20%22created_at%22%3A%20%222016-03-03T09%3A57%3A07Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7600613%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/elicoidal%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_default/README.rst%3AL1-83%22%7D%2C%20%22Pull%20e5f606b282acdd47c03ce45799520c308d292148%20business_requirement_deliverable_default/README.rst%2011%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/xie8899/project/pull/14%23discussion_r54857078%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22s/deriverable/deliverable%20%28x2%29%22%2C%20%22created_at%22%3A%20%222016-03-03T09%3A51%3A06Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7600613%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/elicoidal%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20business_requirement_deliverable_default/README.rst%3AL1-83%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [x] <a href='#crh-comment-Pull d56ddb2bfa033f191c955d6bda3565b355ea6117 business_requirement_deliverable_default/models/business_requirement_deliverable_default.py 15'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/xie8899/project/pull/14#discussion_r53589289'>File: business_requirement_deliverable_default/models/business_requirement_deliverable_default.py:L1-51</a></b>\n- <a href='https://github.com/duanyp1991'><img border=0 src='https://avatars.githubusercontent.com/u/3785252?v=3' height=16 width=16'></a> `api.one` is deprecated in v9\n- [x] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/xie8899/project/pull/14#issuecomment-187030317'>General Comment</a></b>\n- <a href='https://github.com/duanyp1991'><img border=0 src='https://avatars.githubusercontent.com/u/3785252?v=3' height=16 width=16'></a> @victormartinelicocorp  I miss the unit test.\n- <a href='https://github.com/victormartinelicocorp'><img border=0 src='https://avatars.githubusercontent.com/u/16461806?v=3' height=16 width=16'></a> cc @duanyp1991\n- <a href='https://github.com/duanyp1991'><img border=0 src='https://avatars.githubusercontent.com/u/3785252?v=3' height=16 width=16'></a> LGTM\n- <a href='https://github.com/siyuancn'><img border=0 src='https://avatars.githubusercontent.com/u/12975184?v=3' height=16 width=16'></a> Others LGTM\n- <a href='https://github.com/elicoidal'><img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'></a> some small details. needs to be tested. other than that LGTM\n- <a href='https://github.com/elicoidal'><img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'></a> @siyuancn by the way can you install it in our ERP so that I can test it?\n- <a href='https://github.com/siyuancn'><img border=0 src='https://avatars.githubusercontent.com/u/12975184?v=3' height=16 width=16'></a> @elicoidal I will do it when the pr is merged.\n- [x] <a href='#crh-comment-Pull d56ddb2bfa033f191c955d6bda3565b355ea6117 business_requirement_deliverable_default/models/business_requirement_deliverable_default.py 12'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/xie8899/project/pull/14#discussion_r53598231'>File: business_requirement_deliverable_default/models/business_requirement_deliverable_default.py:L1-51</a></b>\n- <a href='https://github.com/duanyp1991'><img border=0 src='https://avatars.githubusercontent.com/u/3785252?v=3' height=16 width=16'></a> \n```python\n[(0, 0, x) for x in rl_data]\n```\n- <a href='https://github.com/victormartinelicocorp'><img border=0 src='https://avatars.githubusercontent.com/u/16461806?v=3' height=16 width=16'></a> @duanyp1991 According to functionality we had discuss yesterday I changed it by \"Update\" to add new resource_lines without duplicate or delete previous resources.\n`[(1, ids[index], item) for index, item in enumerate(rl_data)]`\n- [x] <a href='#crh-comment-Pull d56ddb2bfa033f191c955d6bda3565b355ea6117 business_requirement_deliverable_default/models/business_requirement_deliverable_default.py 49'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/xie8899/project/pull/14#discussion_r53601129'>File: business_requirement_deliverable_default/models/business_requirement_deliverable_default.py:L1-51</a></b>\n- <a href='https://github.com/duanyp1991'><img border=0 src='https://avatars.githubusercontent.com/u/3785252?v=3' height=16 width=16'></a> copy=False\n- [ ] <a href='#crh-comment-Pull e5f606b282acdd47c03ce45799520c308d292148 business_requirement_deliverable_default/__init__.py 5'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/xie8899/project/pull/14#discussion_r54854952'>File: business_requirement_deliverable_default/__init__.py:L1-6</a></b>\n- <a href='https://github.com/siyuancn'><img border=0 src='https://avatars.githubusercontent.com/u/12975184?v=3' height=16 width=16'></a> no need import tests (unit test) in __init__.py\n- <a href='https://github.com/duanyp1991'><img border=0 src='https://avatars.githubusercontent.com/u/3785252?v=3' height=16 width=16'></a> Do not import tests in `__init__.py`.\n- [ ] <a href='#crh-comment-Pull e5f606b282acdd47c03ce45799520c308d292148 business_requirement_deliverable_default/models/business_requirement_deliverable_default.py 11'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/xie8899/project/pull/14#discussion_r54855427'>File: business_requirement_deliverable_default/models/business_requirement_deliverable_default.py:L1-57</a></b>\n- <a href='https://github.com/siyuancn'><img border=0 src='https://avatars.githubusercontent.com/u/12975184?v=3' height=16 width=16'></a> can resource_lines be empty?\n- <a href='https://github.com/victormartinelicocorp'><img border=0 src='https://avatars.githubusercontent.com/u/16461806?v=3' height=16 width=16'></a> @siyuancn Yes, but in that case it will return an empty list `[]` so nothing to do update in that case. It also tested because it's mostly the state for Products (I have to put some resources in one or two products, so it have resources and the others not).\n- [ ] <a href='#crh-comment-Pull e5f606b282acdd47c03ce45799520c308d292148 business_requirement_deliverable_default/models/business_requirement_deliverable_default.py 10'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/xie8899/project/pull/14#discussion_r54856632'>File: business_requirement_deliverable_default/models/business_requirement_deliverable_default.py:L1-57</a></b>\n- <a href='https://github.com/elicoidal'><img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'></a> resource\n- <a href='https://github.com/victormartinelicocorp'><img border=0 src='https://avatars.githubusercontent.com/u/16461806?v=3' height=16 width=16'></a> @elicoidal As far I read there is no rule for this kind of method that is just auxiliary (because this method is only called by others methods). So for me it is better to have a self descriptive name and naming just `resource` for me is not desirable. @duanyp1991 and @siyuancn  Do you agree with me?\ncc @duanyp1991 @siyuancn @elicoidal\n- [ ] <a href='#crh-comment-Pull e5f606b282acdd47c03ce45799520c308d292148 business_requirement_deliverable_default/README.rst 9'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/xie8899/project/pull/14#discussion_r54857017'>File: business_requirement_deliverable_default/README.rst:L1-83</a></b>\n- <a href='https://github.com/elicoidal'><img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'></a> s/(\"Business Requirement\") links/(\"Business Requirement\") and links\n- [ ] <a href='#crh-comment-Pull e5f606b282acdd47c03ce45799520c308d292148 business_requirement_deliverable_default/README.rst 11'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/xie8899/project/pull/14#discussion_r54857078'>File: business_requirement_deliverable_default/README.rst:L1-83</a></b>\n- <a href='https://github.com/elicoidal'><img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'></a> s/deriverable/deliverable (x2)\n- [ ] <a href='#crh-comment-Pull e5f606b282acdd47c03ce45799520c308d292148 business_requirement_deliverable_default/README.rst 17'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/xie8899/project/pull/14#discussion_r54857806'>File: business_requirement_deliverable_default/README.rst:L1-83</a></b>\n- <a href='https://github.com/elicoidal'><img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'></a> move to usage section\n- [ ] <a href='#crh-comment-Pull e5f606b282acdd47c03ce45799520c308d292148 business_requirement_deliverable_default/README.rst 44'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/xie8899/project/pull/14#discussion_r54857900'>File: business_requirement_deliverable_default/README.rst:L1-83</a></b>\n- <a href='https://github.com/elicoidal'><img border=0 src='https://avatars.githubusercontent.com/u/7600613?v=3' height=16 width=16'></a> remove section\n\n\n<a href='https://www.codereviewhub.com/xie8899/project/pull/14?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/xie8899/project/pull/14?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/xie8899/project/pull/14'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2016-02-22T04:23:37Z","updated_at":"2016-03-07T02:04:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5b29f9a5811007f8969c5f2ccea04654dac505a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xie8899/project/pulls/14/commits","review_comments_url":"https://api.github.com/repos/xie8899/project/pulls/14/comments","review_comment_url":"https://api.github.com/repos/xie8899/project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xie8899/project/issues/14/comments","statuses_url":"https://api.github.com/repos/xie8899/project/statuses/e5f606b282acdd47c03ce45799520c308d292148","head":{"label":"victormartinelicocorp:business_requirement_deliverable_8.0-12208-new-modules-business_requirement_deliverable_default","ref":"business_requirement_deliverable_8.0-12208-new-modules-business_requirement_deliverable_default","sha":"e5f606b282acdd47c03ce45799520c308d292148","user":{"login":"victormartinelicocorp","id":16461806,"avatar_url":"https://avatars.githubusercontent.com/u/16461806?v=3","gravatar_id":"","url":"https://api.github.com/users/victormartinelicocorp","html_url":"https://github.com/victormartinelicocorp","followers_url":"https://api.github.com/users/victormartinelicocorp/followers","following_url":"https://api.github.com/users/victormartinelicocorp/following{/other_user}","gists_url":"https://api.github.com/users/victormartinelicocorp/gists{/gist_id}","starred_url":"https://api.github.com/users/victormartinelicocorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victormartinelicocorp/subscriptions","organizations_url":"https://api.github.com/users/victormartinelicocorp/orgs","repos_url":"https://api.github.com/users/victormartinelicocorp/repos","events_url":"https://api.github.com/users/victormartinelicocorp/events{/privacy}","received_events_url":"https://api.github.com/users/victormartinelicocorp/received_events","type":"User","site_admin":false},"repo":{"id":51131309,"name":"project","full_name":"victormartinelicocorp/project","owner":{"login":"victormartinelicocorp","id":16461806,"avatar_url":"https://avatars.githubusercontent.com/u/16461806?v=3","gravatar_id":"","url":"https://api.github.com/users/victormartinelicocorp","html_url":"https://github.com/victormartinelicocorp","followers_url":"https://api.github.com/users/victormartinelicocorp/followers","following_url":"https://api.github.com/users/victormartinelicocorp/following{/other_user}","gists_url":"https://api.github.com/users/victormartinelicocorp/gists{/gist_id}","starred_url":"https://api.github.com/users/victormartinelicocorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victormartinelicocorp/subscriptions","organizations_url":"https://api.github.com/users/victormartinelicocorp/orgs","repos_url":"https://api.github.com/users/victormartinelicocorp/repos","events_url":"https://api.github.com/users/victormartinelicocorp/events{/privacy}","received_events_url":"https://api.github.com/users/victormartinelicocorp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/victormartinelicocorp/project","description":"Odoo Project Management and Services Company Addons","fork":true,"url":"https://api.github.com/repos/victormartinelicocorp/project","forks_url":"https://api.github.com/repos/victormartinelicocorp/project/forks","keys_url":"https://api.github.com/repos/victormartinelicocorp/project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/victormartinelicocorp/project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/victormartinelicocorp/project/teams","hooks_url":"https://api.github.com/repos/victormartinelicocorp/project/hooks","issue_events_url":"https://api.github.com/repos/victormartinelicocorp/project/issues/events{/number}","events_url":"https://api.github.com/repos/victormartinelicocorp/project/events","assignees_url":"https://api.github.com/repos/victormartinelicocorp/project/assignees{/user}","branches_url":"https://api.github.com/repos/victormartinelicocorp/project/branches{/branch}","tags_url":"https://api.github.com/repos/victormartinelicocorp/project/tags","blobs_url":"https://api.github.com/repos/victormartinelicocorp/project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/victormartinelicocorp/project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/victormartinelicocorp/project/git/refs{/sha}","trees_url":"https://api.github.com/repos/victormartinelicocorp/project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/victormartinelicocorp/project/statuses/{sha}","languages_url":"https://api.github.com/repos/victormartinelicocorp/project/languages","stargazers_url":"https://api.github.com/repos/victormartinelicocorp/project/stargazers","contributors_url":"https://api.github.com/repos/victormartinelicocorp/project/contributors","subscribers_url":"https://api.github.com/repos/victormartinelicocorp/project/subscribers","subscription_url":"https://api.github.com/repos/victormartinelicocorp/project/subscription","commits_url":"https://api.github.com/repos/victormartinelicocorp/project/commits{/sha}","git_commits_url":"https://api.github.com/repos/victormartinelicocorp/project/git/commits{/sha}","comments_url":"https://api.github.com/repos/victormartinelicocorp/project/comments{/number}","issue_comment_url":"https://api.github.com/repos/victormartinelicocorp/project/issues/comments{/number}","contents_url":"https://api.github.com/repos/victormartinelicocorp/project/contents/{+path}","compare_url":"https://api.github.com/repos/victormartinelicocorp/project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/victormartinelicocorp/project/merges","archive_url":"https://api.github.com/repos/victormartinelicocorp/project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/victormartinelicocorp/project/downloads","issues_url":"https://api.github.com/repos/victormartinelicocorp/project/issues{/number}","pulls_url":"https://api.github.com/repos/victormartinelicocorp/project/pulls{/number}","milestones_url":"https://api.github.com/repos/victormartinelicocorp/project/milestones{/number}","notifications_url":"https://api.github.com/repos/victormartinelicocorp/project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/victormartinelicocorp/project/labels{/name}","releases_url":"https://api.github.com/repos/victormartinelicocorp/project/releases{/id}","deployments_url":"https://api.github.com/repos/victormartinelicocorp/project/deployments","created_at":"2016-02-05T06:57:48Z","updated_at":"2016-02-05T06:57:50Z","pushed_at":"2016-03-04T10:03:02Z","git_url":"git://github.com/victormartinelicocorp/project.git","ssh_url":"git@github.com:victormartinelicocorp/project.git","clone_url":"https://github.com/victormartinelicocorp/project.git","svn_url":"https://github.com/victormartinelicocorp/project","homepage":"","size":1600,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"9.0"}},"base":{"label":"xie8899:business_requirement_deliverable_8.0","ref":"business_requirement_deliverable_8.0","sha":"adb54995415bc2d4ed5e028b9a933266b4dd705c","user":{"login":"xie8899","id":14543145,"avatar_url":"https://avatars.githubusercontent.com/u/14543145?v=3","gravatar_id":"","url":"https://api.github.com/users/xie8899","html_url":"https://github.com/xie8899","followers_url":"https://api.github.com/users/xie8899/followers","following_url":"https://api.github.com/users/xie8899/following{/other_user}","gists_url":"https://api.github.com/users/xie8899/gists{/gist_id}","starred_url":"https://api.github.com/users/xie8899/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xie8899/subscriptions","organizations_url":"https://api.github.com/users/xie8899/orgs","repos_url":"https://api.github.com/users/xie8899/repos","events_url":"https://api.github.com/users/xie8899/events{/privacy}","received_events_url":"https://api.github.com/users/xie8899/received_events","type":"User","site_admin":false},"repo":{"id":46115685,"name":"project","full_name":"xie8899/project","owner":{"login":"xie8899","id":14543145,"avatar_url":"https://avatars.githubusercontent.com/u/14543145?v=3","gravatar_id":"","url":"https://api.github.com/users/xie8899","html_url":"https://github.com/xie8899","followers_url":"https://api.github.com/users/xie8899/followers","following_url":"https://api.github.com/users/xie8899/following{/other_user}","gists_url":"https://api.github.com/users/xie8899/gists{/gist_id}","starred_url":"https://api.github.com/users/xie8899/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xie8899/subscriptions","organizations_url":"https://api.github.com/users/xie8899/orgs","repos_url":"https://api.github.com/users/xie8899/repos","events_url":"https://api.github.com/users/xie8899/events{/privacy}","received_events_url":"https://api.github.com/users/xie8899/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xie8899/project","description":"Odoo Project Management and Services Company Addons","fork":true,"url":"https://api.github.com/repos/xie8899/project","forks_url":"https://api.github.com/repos/xie8899/project/forks","keys_url":"https://api.github.com/repos/xie8899/project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xie8899/project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xie8899/project/teams","hooks_url":"https://api.github.com/repos/xie8899/project/hooks","issue_events_url":"https://api.github.com/repos/xie8899/project/issues/events{/number}","events_url":"https://api.github.com/repos/xie8899/project/events","assignees_url":"https://api.github.com/repos/xie8899/project/assignees{/user}","branches_url":"https://api.github.com/repos/xie8899/project/branches{/branch}","tags_url":"https://api.github.com/repos/xie8899/project/tags","blobs_url":"https://api.github.com/repos/xie8899/project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xie8899/project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xie8899/project/git/refs{/sha}","trees_url":"https://api.github.com/repos/xie8899/project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xie8899/project/statuses/{sha}","languages_url":"https://api.github.com/repos/xie8899/project/languages","stargazers_url":"https://api.github.com/repos/xie8899/project/stargazers","contributors_url":"https://api.github.com/repos/xie8899/project/contributors","subscribers_url":"https://api.github.com/repos/xie8899/project/subscribers","subscription_url":"https://api.github.com/repos/xie8899/project/subscription","commits_url":"https://api.github.com/repos/xie8899/project/commits{/sha}","git_commits_url":"https://api.github.com/repos/xie8899/project/git/commits{/sha}","comments_url":"https://api.github.com/repos/xie8899/project/comments{/number}","issue_comment_url":"https://api.github.com/repos/xie8899/project/issues/comments{/number}","contents_url":"https://api.github.com/repos/xie8899/project/contents/{+path}","compare_url":"https://api.github.com/repos/xie8899/project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xie8899/project/merges","archive_url":"https://api.github.com/repos/xie8899/project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xie8899/project/downloads","issues_url":"https://api.github.com/repos/xie8899/project/issues{/number}","pulls_url":"https://api.github.com/repos/xie8899/project/pulls{/number}","milestones_url":"https://api.github.com/repos/xie8899/project/milestones{/number}","notifications_url":"https://api.github.com/repos/xie8899/project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xie8899/project/labels{/name}","releases_url":"https://api.github.com/repos/xie8899/project/releases{/id}","deployments_url":"https://api.github.com/repos/xie8899/project/deployments","created_at":"2015-11-13T10:30:48Z","updated_at":"2016-01-07T16:12:56Z","pushed_at":"2016-03-07T01:48:18Z","git_url":"git://github.com/xie8899/project.git","ssh_url":"git@github.com:xie8899/project.git","clone_url":"https://github.com/xie8899/project.git","svn_url":"https://github.com/xie8899/project","homepage":"","size":1613,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":4,"forks":3,"open_issues":4,"watchers":1,"default_branch":"9.0"}},"_links":{"self":{"href":"https://api.github.com/repos/xie8899/project/pulls/14"},"html":{"href":"https://github.com/xie8899/project/pull/14"},"issue":{"href":"https://api.github.com/repos/xie8899/project/issues/14"},"comments":{"href":"https://api.github.com/repos/xie8899/project/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/xie8899/project/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/xie8899/project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xie8899/project/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/xie8899/project/statuses/e5f606b282acdd47c03ce45799520c308d292148"}}}}