{"action":"opened","number":249,"pull_request":{"url":"https://api.github.com/repos/fo-dicom/fo-dicom/pulls/249","id":66275487,"html_url":"https://github.com/fo-dicom/fo-dicom/pull/249","diff_url":"https://github.com/fo-dicom/fo-dicom/pull/249.diff","patch_url":"https://github.com/fo-dicom/fo-dicom/pull/249.patch","issue_url":"https://api.github.com/repos/fo-dicom/fo-dicom/issues/249","number":249,"state":"open","locked":false,"title":"Proper handling of exceptions during DicomClient.Send(Async). Connected to #239","user":{"login":"anders9ustafsson","id":6515030,"avatar_url":"https://avatars.githubusercontent.com/u/6515030?v=3","gravatar_id":"","url":"https://api.github.com/users/anders9ustafsson","html_url":"https://github.com/anders9ustafsson","followers_url":"https://api.github.com/users/anders9ustafsson/followers","following_url":"https://api.github.com/users/anders9ustafsson/following{/other_user}","gists_url":"https://api.github.com/users/anders9ustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/anders9ustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anders9ustafsson/subscriptions","organizations_url":"https://api.github.com/users/anders9ustafsson/orgs","repos_url":"https://api.github.com/users/anders9ustafsson/repos","events_url":"https://api.github.com/users/anders9ustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/anders9ustafsson/received_events","type":"User","site_admin":false},"body":"Fixes #239 (according to @Ed55 's proposals).\r\n\r\nChanges proposed in this pull request:\r\n- Re-factor `SetComplete` method to handle optional exceptions.\r\n- Unwrap `AggregateException` and re-throw the inner exceptions in the `Send` overloads.\r\n- Re-factor the actual send parts in the `Send` and `SendAsync` overloads to be contained in separate `DoSend(Async)` methods.\r\n\r\nPlease review.","created_at":"2016-04-13T07:15:43Z","updated_at":"2016-04-13T07:15:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a3805636e5c24647b76d6eede3320e9c031667f","assignee":{"login":"anders9ustafsson","id":6515030,"avatar_url":"https://avatars.githubusercontent.com/u/6515030?v=3","gravatar_id":"","url":"https://api.github.com/users/anders9ustafsson","html_url":"https://github.com/anders9ustafsson","followers_url":"https://api.github.com/users/anders9ustafsson/followers","following_url":"https://api.github.com/users/anders9ustafsson/following{/other_user}","gists_url":"https://api.github.com/users/anders9ustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/anders9ustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anders9ustafsson/subscriptions","organizations_url":"https://api.github.com/users/anders9ustafsson/orgs","repos_url":"https://api.github.com/users/anders9ustafsson/repos","events_url":"https://api.github.com/users/anders9ustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/anders9ustafsson/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/fo-dicom/fo-dicom/milestones/3","html_url":"https://github.com/fo-dicom/fo-dicom/milestones/2.1.0","labels_url":"https://api.github.com/repos/fo-dicom/fo-dicom/milestones/3/labels","id":1358825,"number":3,"title":"2.1.0","description":null,"creator":{"login":"anders9ustafsson","id":6515030,"avatar_url":"https://avatars.githubusercontent.com/u/6515030?v=3","gravatar_id":"","url":"https://api.github.com/users/anders9ustafsson","html_url":"https://github.com/anders9ustafsson","followers_url":"https://api.github.com/users/anders9ustafsson/followers","following_url":"https://api.github.com/users/anders9ustafsson/following{/other_user}","gists_url":"https://api.github.com/users/anders9ustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/anders9ustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anders9ustafsson/subscriptions","organizations_url":"https://api.github.com/users/anders9ustafsson/orgs","repos_url":"https://api.github.com/users/anders9ustafsson/repos","events_url":"https://api.github.com/users/anders9ustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/anders9ustafsson/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":29,"state":"open","created_at":"2015-10-16T06:17:06Z","updated_at":"2016-04-13T07:15:44Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/fo-dicom/fo-dicom/pulls/249/commits","review_comments_url":"https://api.github.com/repos/fo-dicom/fo-dicom/pulls/249/comments","review_comment_url":"https://api.github.com/repos/fo-dicom/fo-dicom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fo-dicom/fo-dicom/issues/249/comments","statuses_url":"https://api.github.com/repos/fo-dicom/fo-dicom/statuses/8af1226c674cbe5c145fcb54e9c747942cfe6bc6","head":{"label":"anders9ustafsson:GH-239","ref":"GH-239","sha":"8af1226c674cbe5c145fcb54e9c747942cfe6bc6","user":{"login":"anders9ustafsson","id":6515030,"avatar_url":"https://avatars.githubusercontent.com/u/6515030?v=3","gravatar_id":"","url":"https://api.github.com/users/anders9ustafsson","html_url":"https://github.com/anders9ustafsson","followers_url":"https://api.github.com/users/anders9ustafsson/followers","following_url":"https://api.github.com/users/anders9ustafsson/following{/other_user}","gists_url":"https://api.github.com/users/anders9ustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/anders9ustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anders9ustafsson/subscriptions","organizations_url":"https://api.github.com/users/anders9ustafsson/orgs","repos_url":"https://api.github.com/users/anders9ustafsson/repos","events_url":"https://api.github.com/users/anders9ustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/anders9ustafsson/received_events","type":"User","site_admin":false},"repo":{"id":36347397,"name":"fo-dicom","full_name":"anders9ustafsson/fo-dicom","owner":{"login":"anders9ustafsson","id":6515030,"avatar_url":"https://avatars.githubusercontent.com/u/6515030?v=3","gravatar_id":"","url":"https://api.github.com/users/anders9ustafsson","html_url":"https://github.com/anders9ustafsson","followers_url":"https://api.github.com/users/anders9ustafsson/followers","following_url":"https://api.github.com/users/anders9ustafsson/following{/other_user}","gists_url":"https://api.github.com/users/anders9ustafsson/gists{/gist_id}","starred_url":"https://api.github.com/users/anders9ustafsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anders9ustafsson/subscriptions","organizations_url":"https://api.github.com/users/anders9ustafsson/orgs","repos_url":"https://api.github.com/users/anders9ustafsson/repos","events_url":"https://api.github.com/users/anders9ustafsson/events{/privacy}","received_events_url":"https://api.github.com/users/anders9ustafsson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anders9ustafsson/fo-dicom","description":"Fellow Oak DICOM for .NET","fork":true,"url":"https://api.github.com/repos/anders9ustafsson/fo-dicom","forks_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/forks","keys_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/teams","hooks_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/hooks","issue_events_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/issues/events{/number}","events_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/events","assignees_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/assignees{/user}","branches_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/branches{/branch}","tags_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/tags","blobs_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/git/refs{/sha}","trees_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/statuses/{sha}","languages_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/languages","stargazers_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/stargazers","contributors_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/contributors","subscribers_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/subscribers","subscription_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/subscription","commits_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/commits{/sha}","git_commits_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/git/commits{/sha}","comments_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/comments{/number}","issue_comment_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/issues/comments{/number}","contents_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/contents/{+path}","compare_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/merges","archive_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/downloads","issues_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/issues{/number}","pulls_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/pulls{/number}","milestones_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/milestones{/number}","notifications_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/labels{/name}","releases_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/releases{/id}","deployments_url":"https://api.github.com/repos/anders9ustafsson/fo-dicom/deployments","created_at":"2015-05-27T06:18:31Z","updated_at":"2016-01-15T06:47:50Z","pushed_at":"2016-04-13T07:07:57Z","git_url":"git://github.com/anders9ustafsson/fo-dicom.git","ssh_url":"git@github.com:anders9ustafsson/fo-dicom.git","clone_url":"https://github.com/anders9ustafsson/fo-dicom.git","svn_url":"https://github.com/anders9ustafsson/fo-dicom","homepage":"https://gitter.im/fo-dicom/fo-dicom","size":32091,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"fo-dicom:development","ref":"development","sha":"5373c89508f088fb0987db6b8609a1d47bff9217","user":{"login":"fo-dicom","id":12371708,"avatar_url":"https://avatars.githubusercontent.com/u/12371708?v=3","gravatar_id":"","url":"https://api.github.com/users/fo-dicom","html_url":"https://github.com/fo-dicom","followers_url":"https://api.github.com/users/fo-dicom/followers","following_url":"https://api.github.com/users/fo-dicom/following{/other_user}","gists_url":"https://api.github.com/users/fo-dicom/gists{/gist_id}","starred_url":"https://api.github.com/users/fo-dicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fo-dicom/subscriptions","organizations_url":"https://api.github.com/users/fo-dicom/orgs","repos_url":"https://api.github.com/users/fo-dicom/repos","events_url":"https://api.github.com/users/fo-dicom/events{/privacy}","received_events_url":"https://api.github.com/users/fo-dicom/received_events","type":"Organization","site_admin":false},"repo":{"id":35329761,"name":"fo-dicom","full_name":"fo-dicom/fo-dicom","owner":{"login":"fo-dicom","id":12371708,"avatar_url":"https://avatars.githubusercontent.com/u/12371708?v=3","gravatar_id":"","url":"https://api.github.com/users/fo-dicom","html_url":"https://github.com/fo-dicom","followers_url":"https://api.github.com/users/fo-dicom/followers","following_url":"https://api.github.com/users/fo-dicom/following{/other_user}","gists_url":"https://api.github.com/users/fo-dicom/gists{/gist_id}","starred_url":"https://api.github.com/users/fo-dicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fo-dicom/subscriptions","organizations_url":"https://api.github.com/users/fo-dicom/orgs","repos_url":"https://api.github.com/users/fo-dicom/repos","events_url":"https://api.github.com/users/fo-dicom/events{/privacy}","received_events_url":"https://api.github.com/users/fo-dicom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fo-dicom/fo-dicom","description":"Fellow Oak DICOM for .NET, Universal Windows, Android, iOS and Mono","fork":false,"url":"https://api.github.com/repos/fo-dicom/fo-dicom","forks_url":"https://api.github.com/repos/fo-dicom/fo-dicom/forks","keys_url":"https://api.github.com/repos/fo-dicom/fo-dicom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fo-dicom/fo-dicom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fo-dicom/fo-dicom/teams","hooks_url":"https://api.github.com/repos/fo-dicom/fo-dicom/hooks","issue_events_url":"https://api.github.com/repos/fo-dicom/fo-dicom/issues/events{/number}","events_url":"https://api.github.com/repos/fo-dicom/fo-dicom/events","assignees_url":"https://api.github.com/repos/fo-dicom/fo-dicom/assignees{/user}","branches_url":"https://api.github.com/repos/fo-dicom/fo-dicom/branches{/branch}","tags_url":"https://api.github.com/repos/fo-dicom/fo-dicom/tags","blobs_url":"https://api.github.com/repos/fo-dicom/fo-dicom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fo-dicom/fo-dicom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fo-dicom/fo-dicom/git/refs{/sha}","trees_url":"https://api.github.com/repos/fo-dicom/fo-dicom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fo-dicom/fo-dicom/statuses/{sha}","languages_url":"https://api.github.com/repos/fo-dicom/fo-dicom/languages","stargazers_url":"https://api.github.com/repos/fo-dicom/fo-dicom/stargazers","contributors_url":"https://api.github.com/repos/fo-dicom/fo-dicom/contributors","subscribers_url":"https://api.github.com/repos/fo-dicom/fo-dicom/subscribers","subscription_url":"https://api.github.com/repos/fo-dicom/fo-dicom/subscription","commits_url":"https://api.github.com/repos/fo-dicom/fo-dicom/commits{/sha}","git_commits_url":"https://api.github.com/repos/fo-dicom/fo-dicom/git/commits{/sha}","comments_url":"https://api.github.com/repos/fo-dicom/fo-dicom/comments{/number}","issue_comment_url":"https://api.github.com/repos/fo-dicom/fo-dicom/issues/comments{/number}","contents_url":"https://api.github.com/repos/fo-dicom/fo-dicom/contents/{+path}","compare_url":"https://api.github.com/repos/fo-dicom/fo-dicom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fo-dicom/fo-dicom/merges","archive_url":"https://api.github.com/repos/fo-dicom/fo-dicom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fo-dicom/fo-dicom/downloads","issues_url":"https://api.github.com/repos/fo-dicom/fo-dicom/issues{/number}","pulls_url":"https://api.github.com/repos/fo-dicom/fo-dicom/pulls{/number}","milestones_url":"https://api.github.com/repos/fo-dicom/fo-dicom/milestones{/number}","notifications_url":"https://api.github.com/repos/fo-dicom/fo-dicom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fo-dicom/fo-dicom/labels{/name}","releases_url":"https://api.github.com/repos/fo-dicom/fo-dicom/releases{/id}","deployments_url":"https://api.github.com/repos/fo-dicom/fo-dicom/deployments","created_at":"2015-05-09T13:35:00Z","updated_at":"2016-04-11T07:30:32Z","pushed_at":"2016-04-13T07:15:44Z","git_url":"git://github.com/fo-dicom/fo-dicom.git","ssh_url":"git@github.com:fo-dicom/fo-dicom.git","clone_url":"https://github.com/fo-dicom/fo-dicom.git","svn_url":"https://github.com/fo-dicom/fo-dicom","homepage":"https://gitter.im/fo-dicom/fo-dicom","size":34927,"stargazers_count":65,"watchers_count":65,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":163,"mirror_url":null,"open_issues_count":20,"forks":163,"open_issues":20,"watchers":65,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/fo-dicom/fo-dicom/pulls/249"},"html":{"href":"https://github.com/fo-dicom/fo-dicom/pull/249"},"issue":{"href":"https://api.github.com/repos/fo-dicom/fo-dicom/issues/249"},"comments":{"href":"https://api.github.com/repos/fo-dicom/fo-dicom/issues/249/comments"},"review_comments":{"href":"https://api.github.com/repos/fo-dicom/fo-dicom/pulls/249/comments"},"review_comment":{"href":"https://api.github.com/repos/fo-dicom/fo-dicom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fo-dicom/fo-dicom/pulls/249/commits"},"statuses":{"href":"https://api.github.com/repos/fo-dicom/fo-dicom/statuses/8af1226c674cbe5c145fcb54e9c747942cfe6bc6"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":91,"deletions":28,"changed_files":2}}