{"action":"created","comment":{"url":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/comments/70231074","id":70231074,"diff_hunk":"@@ -165,13 +165,14 @@ public virtual IHttpActionResult GetPropertyFromPackages(string propertyName, st\n \n             var idValues = packageIds.Trim().Split(new[] { '|' }, StringSplitOptions.RemoveEmptyEntries);\n             var versionValues = versions.Trim().Split(new[] { '|' }, StringSplitOptions.RemoveEmptyEntries);\n-            var targetFrameworkValues = String.IsNullOrEmpty(targetFrameworks) ? null :\n-                                                                                 targetFrameworks.Split('|').Select(VersionUtility.ParseFrameworkName).ToList();\n-            var versionConstraintValues = String.IsNullOrEmpty(versionConstraints)\n+            var targetFrameworkValues = String.IsNullOrEmpty(targetFrameworks) \n+                                        ? null \n+                                        : targetFrameworks.Split('|').Select(VersionUtility.ParseFrameworkName).ToList();\n+            var versionConstraintValues = (String.IsNullOrEmpty(versionConstraints)\n                                             ? new string[idValues.Length]\n-                                            : versionConstraints.Split('|');\n+                                            : versionConstraints.Split('|')).ToList();","path":"src/NuGet.Server.V2/Controllers/NuGetODataController.cs","position":null,"original_position":13,"commit_id":"84f26ba0d0b7ebda31ce2771d95c5f79eab3c087","original_commit_id":"84f26ba0d0b7ebda31ce2771d95c5f79eab3c087","user":{"login":"maartenba","id":485230,"avatar_url":"https://avatars.githubusercontent.com/u/485230?v=3","gravatar_id":"","url":"https://api.github.com/users/maartenba","html_url":"https://github.com/maartenba","followers_url":"https://api.github.com/users/maartenba/followers","following_url":"https://api.github.com/users/maartenba/following{/other_user}","gists_url":"https://api.github.com/users/maartenba/gists{/gist_id}","starred_url":"https://api.github.com/users/maartenba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maartenba/subscriptions","organizations_url":"https://api.github.com/users/maartenba/orgs","repos_url":"https://api.github.com/users/maartenba/repos","events_url":"https://api.github.com/users/maartenba/events{/privacy}","received_events_url":"https://api.github.com/users/maartenba/received_events","type":"User","site_admin":false},"body":"Is a ToList() needed here? Just wondering since we have the array.","created_at":"2016-07-11T10:01:25Z","updated_at":"2016-07-11T10:01:25Z","html_url":"https://github.com/NuGet/NuGet.Server/pull/13#discussion_r70231074","pull_request_url":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/comments/70231074"},"html":{"href":"https://github.com/NuGet/NuGet.Server/pull/13#discussion_r70231074"},"pull_request":{"href":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/13","id":75888620,"html_url":"https://github.com/NuGet/NuGet.Server/pull/13","diff_url":"https://github.com/NuGet/NuGet.Server/pull/13.diff","patch_url":"https://github.com/NuGet/NuGet.Server/pull/13.patch","issue_url":"https://api.github.com/repos/NuGet/NuGet.Server/issues/13","number":13,"state":"open","locked":false,"title":"Switch from WCF OData to Web API OData","user":{"login":"andulv","id":5376458,"avatar_url":"https://avatars.githubusercontent.com/u/5376458?v=3","gravatar_id":"","url":"https://api.github.com/users/andulv","html_url":"https://github.com/andulv","followers_url":"https://api.github.com/users/andulv/followers","following_url":"https://api.github.com/users/andulv/following{/other_user}","gists_url":"https://api.github.com/users/andulv/gists{/gist_id}","starred_url":"https://api.github.com/users/andulv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andulv/subscriptions","organizations_url":"https://api.github.com/users/andulv/orgs","repos_url":"https://api.github.com/users/andulv/repos","events_url":"https://api.github.com/users/andulv/events{/privacy}","received_events_url":"https://api.github.com/users/andulv/received_events","type":"User","site_admin":false},"body":"Second part of NuGet/NuGetGallery#3061\r\n\r\nNew projects added:\r\n- src\\NuGet.Server.V2. Class library for creating NuGet feed(s) as Web Api OData controllers. Mostly based on code from NuGetGallery and existing NuGet.Server.\r\n- samples\\NuGet.Server.V2.Samples.OwinHost. Console application that exposes controller from NuGet.Server.V2 as three NuGet feeds.\r\n- tests\\NuGet.Server.V2.Tests. Tests ported from NuGet gallery\r\n\r\nExisting projects (not modified in this PR):\r\n- NuGet.Server - IIS project that uses WCF DataService to create a NuGet feed. \r\n- NuGet.Server.Core - Class library used by NuGet.Server and NuGet.Server.V2.\r\n\r\nTodo:\r\n- [x] Add tests for ApiKeyPackageAuthenticationService.cs\r\n- [x] Create samples folder. Move and rename OwinSampleHost project.\r\n- [x] Update method signatures in NuGetODataController to match the ones in NuGetGalleryODataController / ODataV2FeedController (Return QueryResult<Package> as IHttpActionResult instead of IQueryable/Enablequery, etc.)\r\n- [x] Port relevant tests from NuGetGallery\r\n\r\nNext PR: (?)\r\n- Update NuGet.Server (IIS project) to expose ODataController from NuGet.Server.V2 instead of WCF dataservice.","created_at":"2016-06-30T20:51:47Z","updated_at":"2016-07-11T10:01:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86bb2a70e0e6c49b0c8f0d613f241523f7e5c1a2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/13/commits","review_comments_url":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/13/comments","review_comment_url":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Server/issues/13/comments","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Server/statuses/84f26ba0d0b7ebda31ce2771d95c5f79eab3c087","head":{"label":"andulv:dev3061-2","ref":"dev3061-2","sha":"84f26ba0d0b7ebda31ce2771d95c5f79eab3c087","user":{"login":"andulv","id":5376458,"avatar_url":"https://avatars.githubusercontent.com/u/5376458?v=3","gravatar_id":"","url":"https://api.github.com/users/andulv","html_url":"https://github.com/andulv","followers_url":"https://api.github.com/users/andulv/followers","following_url":"https://api.github.com/users/andulv/following{/other_user}","gists_url":"https://api.github.com/users/andulv/gists{/gist_id}","starred_url":"https://api.github.com/users/andulv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andulv/subscriptions","organizations_url":"https://api.github.com/users/andulv/orgs","repos_url":"https://api.github.com/users/andulv/repos","events_url":"https://api.github.com/users/andulv/events{/privacy}","received_events_url":"https://api.github.com/users/andulv/received_events","type":"User","site_admin":false},"repo":{"id":60120618,"name":"NuGet.Server","full_name":"andulv/NuGet.Server","owner":{"login":"andulv","id":5376458,"avatar_url":"https://avatars.githubusercontent.com/u/5376458?v=3","gravatar_id":"","url":"https://api.github.com/users/andulv","html_url":"https://github.com/andulv","followers_url":"https://api.github.com/users/andulv/followers","following_url":"https://api.github.com/users/andulv/following{/other_user}","gists_url":"https://api.github.com/users/andulv/gists{/gist_id}","starred_url":"https://api.github.com/users/andulv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andulv/subscriptions","organizations_url":"https://api.github.com/users/andulv/orgs","repos_url":"https://api.github.com/users/andulv/repos","events_url":"https://api.github.com/users/andulv/events{/privacy}","received_events_url":"https://api.github.com/users/andulv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andulv/NuGet.Server","description":"The home of the NuGet.server package, a lightweight standalone NuGet server","fork":true,"url":"https://api.github.com/repos/andulv/NuGet.Server","forks_url":"https://api.github.com/repos/andulv/NuGet.Server/forks","keys_url":"https://api.github.com/repos/andulv/NuGet.Server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andulv/NuGet.Server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andulv/NuGet.Server/teams","hooks_url":"https://api.github.com/repos/andulv/NuGet.Server/hooks","issue_events_url":"https://api.github.com/repos/andulv/NuGet.Server/issues/events{/number}","events_url":"https://api.github.com/repos/andulv/NuGet.Server/events","assignees_url":"https://api.github.com/repos/andulv/NuGet.Server/assignees{/user}","branches_url":"https://api.github.com/repos/andulv/NuGet.Server/branches{/branch}","tags_url":"https://api.github.com/repos/andulv/NuGet.Server/tags","blobs_url":"https://api.github.com/repos/andulv/NuGet.Server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andulv/NuGet.Server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andulv/NuGet.Server/git/refs{/sha}","trees_url":"https://api.github.com/repos/andulv/NuGet.Server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andulv/NuGet.Server/statuses/{sha}","languages_url":"https://api.github.com/repos/andulv/NuGet.Server/languages","stargazers_url":"https://api.github.com/repos/andulv/NuGet.Server/stargazers","contributors_url":"https://api.github.com/repos/andulv/NuGet.Server/contributors","subscribers_url":"https://api.github.com/repos/andulv/NuGet.Server/subscribers","subscription_url":"https://api.github.com/repos/andulv/NuGet.Server/subscription","commits_url":"https://api.github.com/repos/andulv/NuGet.Server/commits{/sha}","git_commits_url":"https://api.github.com/repos/andulv/NuGet.Server/git/commits{/sha}","comments_url":"https://api.github.com/repos/andulv/NuGet.Server/comments{/number}","issue_comment_url":"https://api.github.com/repos/andulv/NuGet.Server/issues/comments{/number}","contents_url":"https://api.github.com/repos/andulv/NuGet.Server/contents/{+path}","compare_url":"https://api.github.com/repos/andulv/NuGet.Server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andulv/NuGet.Server/merges","archive_url":"https://api.github.com/repos/andulv/NuGet.Server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andulv/NuGet.Server/downloads","issues_url":"https://api.github.com/repos/andulv/NuGet.Server/issues{/number}","pulls_url":"https://api.github.com/repos/andulv/NuGet.Server/pulls{/number}","milestones_url":"https://api.github.com/repos/andulv/NuGet.Server/milestones{/number}","notifications_url":"https://api.github.com/repos/andulv/NuGet.Server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andulv/NuGet.Server/labels{/name}","releases_url":"https://api.github.com/repos/andulv/NuGet.Server/releases{/id}","deployments_url":"https://api.github.com/repos/andulv/NuGet.Server/deployments","created_at":"2016-05-31T20:20:41Z","updated_at":"2016-05-31T20:20:42Z","pushed_at":"2016-07-08T19:11:44Z","git_url":"git://github.com/andulv/NuGet.Server.git","ssh_url":"git@github.com:andulv/NuGet.Server.git","clone_url":"https://github.com/andulv/NuGet.Server.git","svn_url":"https://github.com/andulv/NuGet.Server","homepage":null,"size":1337,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NuGet:dev","ref":"dev","sha":"4485a470a7ba274eb5ac3265c7d83109a358e0b7","user":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":47568519,"name":"NuGet.Server","full_name":"NuGet/NuGet.Server","owner":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuGet/NuGet.Server","description":"The home of the NuGet.server package, a lightweight standalone NuGet server","fork":false,"url":"https://api.github.com/repos/NuGet/NuGet.Server","forks_url":"https://api.github.com/repos/NuGet/NuGet.Server/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet.Server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet.Server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet.Server/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet.Server/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet.Server/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet.Server/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet.Server/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet.Server/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet.Server/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet.Server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet.Server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet.Server/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet.Server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Server/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet.Server/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet.Server/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet.Server/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet.Server/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet.Server/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet.Server/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet.Server/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Server/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet.Server/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet.Server/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet.Server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet.Server/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet.Server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet.Server/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet.Server/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet.Server/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet.Server/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet.Server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet.Server/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet.Server/releases{/id}","deployments_url":"https://api.github.com/repos/NuGet/NuGet.Server/deployments","created_at":"2015-12-07T17:37:29Z","updated_at":"2016-07-01T03:14:32Z","pushed_at":"2016-07-08T19:11:44Z","git_url":"git://github.com/NuGet/NuGet.Server.git","ssh_url":"git@github.com:NuGet/NuGet.Server.git","clone_url":"https://github.com/NuGet/NuGet.Server.git","svn_url":"https://github.com/NuGet/NuGet.Server","homepage":null,"size":1323,"stargazers_count":44,"watchers_count":44,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":1,"forks":28,"open_issues":1,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/13"},"html":{"href":"https://github.com/NuGet/NuGet.Server/pull/13"},"issue":{"href":"https://api.github.com/repos/NuGet/NuGet.Server/issues/13"},"comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Server/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NuGet/NuGet.Server/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/NuGet/NuGet.Server/statuses/84f26ba0d0b7ebda31ce2771d95c5f79eab3c087"}}}}
{"actor":{"display_login":"maartenba"}}