{"action":"created","comment":{"url":"https://api.github.com/repos/fxbox/app/pulls/comments/61038185","id":61038185,"diff_hunk":"@@ -29,29 +29,26 @@ const storage = localStorage ? localStorage : {\n   clear: () => {},\n };\n \n-export default class Settings extends Model {\n+export default class Settings extends EventDispatcher {\n   constructor() {\n+    super(['session-changed', 'polling-setting-changed']);","path":"app/js/lib/foxbox/settings.js","position":15,"original_position":15,"commit_id":"b800031658b57930fcc6cd7bcdc06039304c8082","original_commit_id":"b800031658b57930fcc6cd7bcdc06039304c8082","user":{"login":"azasypkin","id":1713708,"avatar_url":"https://avatars.githubusercontent.com/u/1713708?v=3","gravatar_id":"","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"body":"Honestly it feels like session should not belong to ```Settings```, but that's what we have now, and I'm trying to differentiate settings from non-settings with ```-setting-``` part in the event name....","created_at":"2016-04-26T07:19:28Z","updated_at":"2016-04-26T07:19:28Z","html_url":"https://github.com/fxbox/app/pull/120#discussion_r61038185","pull_request_url":"https://api.github.com/repos/fxbox/app/pulls/120","_links":{"self":{"href":"https://api.github.com/repos/fxbox/app/pulls/comments/61038185"},"html":{"href":"https://github.com/fxbox/app/pull/120#discussion_r61038185"},"pull_request":{"href":"https://api.github.com/repos/fxbox/app/pulls/120"}}},"pull_request":{"url":"https://api.github.com/repos/fxbox/app/pulls/120","id":67530130,"html_url":"https://github.com/fxbox/app/pull/120","diff_url":"https://github.com/fxbox/app/pull/120.diff","patch_url":"https://github.com/fxbox/app/pull/120.patch","issue_url":"https://api.github.com/repos/fxbox/app/issues/120","number":120,"state":"open","locked":false,"title":" Introduce Foxbox API sub-module. Maintain proper services in-memory cache in a separate submodule. Use EventDispatcher for Network, Settings and WebPush sub-modules. (fixes #116). r=gmarty","user":{"login":"azasypkin","id":1713708,"avatar_url":"https://avatars.githubusercontent.com/u/1713708?v=3","gravatar_id":"","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-22T15:30:20Z","updated_at":"2016-04-26T07:19:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb0266f6fc1674ae0aed943c29ecb4865b20ef37","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fxbox/app/pulls/120/commits","review_comments_url":"https://api.github.com/repos/fxbox/app/pulls/120/comments","review_comment_url":"https://api.github.com/repos/fxbox/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fxbox/app/issues/120/comments","statuses_url":"https://api.github.com/repos/fxbox/app/statuses/b800031658b57930fcc6cd7bcdc06039304c8082","head":{"label":"azasypkin:issue-116-remove-old-services","ref":"issue-116-remove-old-services","sha":"b800031658b57930fcc6cd7bcdc06039304c8082","user":{"login":"azasypkin","id":1713708,"avatar_url":"https://avatars.githubusercontent.com/u/1713708?v=3","gravatar_id":"","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"repo":{"id":53416420,"name":"app","full_name":"azasypkin/app","owner":{"login":"azasypkin","id":1713708,"avatar_url":"https://avatars.githubusercontent.com/u/1713708?v=3","gravatar_id":"","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/azasypkin/app","description":"An app for Project Link","fork":true,"url":"https://api.github.com/repos/azasypkin/app","forks_url":"https://api.github.com/repos/azasypkin/app/forks","keys_url":"https://api.github.com/repos/azasypkin/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azasypkin/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azasypkin/app/teams","hooks_url":"https://api.github.com/repos/azasypkin/app/hooks","issue_events_url":"https://api.github.com/repos/azasypkin/app/issues/events{/number}","events_url":"https://api.github.com/repos/azasypkin/app/events","assignees_url":"https://api.github.com/repos/azasypkin/app/assignees{/user}","branches_url":"https://api.github.com/repos/azasypkin/app/branches{/branch}","tags_url":"https://api.github.com/repos/azasypkin/app/tags","blobs_url":"https://api.github.com/repos/azasypkin/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azasypkin/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azasypkin/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/azasypkin/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azasypkin/app/statuses/{sha}","languages_url":"https://api.github.com/repos/azasypkin/app/languages","stargazers_url":"https://api.github.com/repos/azasypkin/app/stargazers","contributors_url":"https://api.github.com/repos/azasypkin/app/contributors","subscribers_url":"https://api.github.com/repos/azasypkin/app/subscribers","subscription_url":"https://api.github.com/repos/azasypkin/app/subscription","commits_url":"https://api.github.com/repos/azasypkin/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/azasypkin/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/azasypkin/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/azasypkin/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/azasypkin/app/contents/{+path}","compare_url":"https://api.github.com/repos/azasypkin/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azasypkin/app/merges","archive_url":"https://api.github.com/repos/azasypkin/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azasypkin/app/downloads","issues_url":"https://api.github.com/repos/azasypkin/app/issues{/number}","pulls_url":"https://api.github.com/repos/azasypkin/app/pulls{/number}","milestones_url":"https://api.github.com/repos/azasypkin/app/milestones{/number}","notifications_url":"https://api.github.com/repos/azasypkin/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azasypkin/app/labels{/name}","releases_url":"https://api.github.com/repos/azasypkin/app/releases{/id}","deployments_url":"https://api.github.com/repos/azasypkin/app/deployments","created_at":"2016-03-08T13:59:42Z","updated_at":"2016-03-08T13:59:43Z","pushed_at":"2016-04-25T20:39:38Z","git_url":"git://github.com/azasypkin/app.git","ssh_url":"git@github.com:azasypkin/app.git","clone_url":"https://github.com/azasypkin/app.git","svn_url":"https://github.com/azasypkin/app","homepage":"https://fxbox.github.io/app","size":1962,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fxbox:master","ref":"master","sha":"4a453de2b4001d9223e7216015806978fcf6b869","user":{"login":"fxbox","id":17052474,"avatar_url":"https://avatars.githubusercontent.com/u/17052474?v=3","gravatar_id":"","url":"https://api.github.com/users/fxbox","html_url":"https://github.com/fxbox","followers_url":"https://api.github.com/users/fxbox/followers","following_url":"https://api.github.com/users/fxbox/following{/other_user}","gists_url":"https://api.github.com/users/fxbox/gists{/gist_id}","starred_url":"https://api.github.com/users/fxbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxbox/subscriptions","organizations_url":"https://api.github.com/users/fxbox/orgs","repos_url":"https://api.github.com/users/fxbox/repos","events_url":"https://api.github.com/users/fxbox/events{/privacy}","received_events_url":"https://api.github.com/users/fxbox/received_events","type":"Organization","site_admin":false},"repo":{"id":51533667,"name":"app","full_name":"fxbox/app","owner":{"login":"fxbox","id":17052474,"avatar_url":"https://avatars.githubusercontent.com/u/17052474?v=3","gravatar_id":"","url":"https://api.github.com/users/fxbox","html_url":"https://github.com/fxbox","followers_url":"https://api.github.com/users/fxbox/followers","following_url":"https://api.github.com/users/fxbox/following{/other_user}","gists_url":"https://api.github.com/users/fxbox/gists{/gist_id}","starred_url":"https://api.github.com/users/fxbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxbox/subscriptions","organizations_url":"https://api.github.com/users/fxbox/orgs","repos_url":"https://api.github.com/users/fxbox/repos","events_url":"https://api.github.com/users/fxbox/events{/privacy}","received_events_url":"https://api.github.com/users/fxbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fxbox/app","description":"An app for Project Link","fork":false,"url":"https://api.github.com/repos/fxbox/app","forks_url":"https://api.github.com/repos/fxbox/app/forks","keys_url":"https://api.github.com/repos/fxbox/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fxbox/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fxbox/app/teams","hooks_url":"https://api.github.com/repos/fxbox/app/hooks","issue_events_url":"https://api.github.com/repos/fxbox/app/issues/events{/number}","events_url":"https://api.github.com/repos/fxbox/app/events","assignees_url":"https://api.github.com/repos/fxbox/app/assignees{/user}","branches_url":"https://api.github.com/repos/fxbox/app/branches{/branch}","tags_url":"https://api.github.com/repos/fxbox/app/tags","blobs_url":"https://api.github.com/repos/fxbox/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fxbox/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fxbox/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/fxbox/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fxbox/app/statuses/{sha}","languages_url":"https://api.github.com/repos/fxbox/app/languages","stargazers_url":"https://api.github.com/repos/fxbox/app/stargazers","contributors_url":"https://api.github.com/repos/fxbox/app/contributors","subscribers_url":"https://api.github.com/repos/fxbox/app/subscribers","subscription_url":"https://api.github.com/repos/fxbox/app/subscription","commits_url":"https://api.github.com/repos/fxbox/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/fxbox/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/fxbox/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/fxbox/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/fxbox/app/contents/{+path}","compare_url":"https://api.github.com/repos/fxbox/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fxbox/app/merges","archive_url":"https://api.github.com/repos/fxbox/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fxbox/app/downloads","issues_url":"https://api.github.com/repos/fxbox/app/issues{/number}","pulls_url":"https://api.github.com/repos/fxbox/app/pulls{/number}","milestones_url":"https://api.github.com/repos/fxbox/app/milestones{/number}","notifications_url":"https://api.github.com/repos/fxbox/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fxbox/app/labels{/name}","releases_url":"https://api.github.com/repos/fxbox/app/releases{/id}","deployments_url":"https://api.github.com/repos/fxbox/app/deployments","created_at":"2016-02-11T17:46:54Z","updated_at":"2016-04-25T15:49:20Z","pushed_at":"2016-04-25T20:39:38Z","git_url":"git://github.com/fxbox/app.git","ssh_url":"git@github.com:fxbox/app.git","clone_url":"https://github.com/fxbox/app.git","svn_url":"https://github.com/fxbox/app","homepage":"https://fxbox.github.io/app","size":2011,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":24,"forks":7,"open_issues":24,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fxbox/app/pulls/120"},"html":{"href":"https://github.com/fxbox/app/pull/120"},"issue":{"href":"https://api.github.com/repos/fxbox/app/issues/120"},"comments":{"href":"https://api.github.com/repos/fxbox/app/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/fxbox/app/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/fxbox/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fxbox/app/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/fxbox/app/statuses/b800031658b57930fcc6cd7bcdc06039304c8082"}}}}