{"action":"opened","issue":{"url":"https://api.github.com/repos/csoulakian/cs330s16p1/issues/2","repository_url":"https://api.github.com/repos/csoulakian/cs330s16p1","labels_url":"https://api.github.com/repos/csoulakian/cs330s16p1/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/csoulakian/cs330s16p1/issues/2/comments","events_url":"https://api.github.com/repos/csoulakian/cs330s16p1/issues/2/events","html_url":"https://github.com/csoulakian/cs330s16p1/issues/2","id":132877391,"number":2,"title":"Peer Review","user":{"login":"sshah37","id":17169616,"avatar_url":"https://avatars.githubusercontent.com/u/17169616?v=3","gravatar_id":"","url":"https://api.github.com/users/sshah37","html_url":"https://github.com/sshah37","followers_url":"https://api.github.com/users/sshah37/followers","following_url":"https://api.github.com/users/sshah37/following{/other_user}","gists_url":"https://api.github.com/users/sshah37/gists{/gist_id}","starred_url":"https://api.github.com/users/sshah37/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sshah37/subscriptions","organizations_url":"https://api.github.com/users/sshah37/orgs","repos_url":"https://api.github.com/users/sshah37/repos","events_url":"https://api.github.com/users/sshah37/events{/privacy}","received_events_url":"https://api.github.com/users/sshah37/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-02-11T03:16:28Z","updated_at":"2016-02-11T03:16:28Z","closed_at":null,"body":"Yeah, I really gotta agree with Tyler on the commenting, it's very thorough and helpful.\r\n\r\nDon't really know what to add since the code looks more sophisticated and smoother than anything I thought of. One thing to think about that gave me pause though is the benefits of parsing the string directly, rather than parsing a String array of words after a split. I considered a split array in the beginning as well, but if you ever want to add the functionality of determining if the post is a reply or not, which might be an important piece of information, it might take a bit more work post string-split.\r\n\r\n For tweets a mention @ at the very beginning of the post categorizes the tweet as a reply to mentioned user. I imagine if the professor asks us to expand the project later to store data for multiple, possibly related tweets, methods to recognize that a tweet is a reply, who it is a reply to and connect the tweet to the replied user will be important. In that expanded functionality parsing the entirety of the message string allows use of startsWith() methods to recognize a reply immediately. Like, your sorter that matches using the regMentions String would just need an extra if to check if matched mention has index 0 in message string. \r\n\r\nOtherwise, if parsing by split words you'd have to either include a separate method for checking if first mention is reply and storing username of replied-to user. \r\n\r\nTL;DR: Can't really add much since your code and documentation look great as is. Consider switching to a full string parse rather than split word parsing. Allows more discerning sorting, imo. Doubt it makes too much of time difference anyway, if any."}}