{"action":"created","issue":{"url":"https://api.github.com/repos/icelab/formalist-standard-react/issues/63","repository_url":"https://api.github.com/repos/icelab/formalist-standard-react","labels_url":"https://api.github.com/repos/icelab/formalist-standard-react/issues/63/labels{/name}","comments_url":"https://api.github.com/repos/icelab/formalist-standard-react/issues/63/comments","events_url":"https://api.github.com/repos/icelab/formalist-standard-react/issues/63/events","html_url":"https://github.com/icelab/formalist-standard-react/pull/63","id":154409175,"number":63,"title":"Sortable upload files","user":{"login":"chrisbuttery","id":121675,"avatar_url":"https://avatars.githubusercontent.com/u/121675?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisbuttery","html_url":"https://github.com/chrisbuttery","followers_url":"https://api.github.com/users/chrisbuttery/followers","following_url":"https://api.github.com/users/chrisbuttery/following{/other_user}","gists_url":"https://api.github.com/users/chrisbuttery/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisbuttery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisbuttery/subscriptions","organizations_url":"https://api.github.com/users/chrisbuttery/orgs","repos_url":"https://api.github.com/users/chrisbuttery/repos","events_url":"https://api.github.com/users/chrisbuttery/events{/privacy}","received_events_url":"https://api.github.com/users/chrisbuttery/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-05-12T06:47:16Z","updated_at":"2016-05-23T00:38:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/icelab/formalist-standard-react/pulls/63","html_url":"https://github.com/icelab/formalist-standard-react/pull/63","diff_url":"https://github.com/icelab/formalist-standard-react/pull/63.diff","patch_url":"https://github.com/icelab/formalist-standard-react/pull/63.patch"},"body":"The main purpose of this PR was to render all uploading and uploaded files into a `Sortable` component.\r\n\r\nThis [link](https://github.com/icelab/formalist-standard-react/pull/17#issuecomment-214635721) references a list of feedback that needed addressing - with at least 50% of it already merged in to master.\r\n\r\n![sortable](https://cloud.githubusercontent.com/assets/121675/15277661/39460980-1b4e-11e6-9fdc-6131687ee1a6.gif)\r\n\r\nWhenever you get a chance @makenosound, I'll be happy to go through it with you. 👍 \r\n"},"comment":{"url":"https://api.github.com/repos/icelab/formalist-standard-react/issues/comments/220866558","html_url":"https://github.com/icelab/formalist-standard-react/pull/63#issuecomment-220866558","issue_url":"https://api.github.com/repos/icelab/formalist-standard-react/issues/63","id":220866558,"user":{"login":"makenosound","id":4353,"avatar_url":"https://avatars.githubusercontent.com/u/4353?v=3","gravatar_id":"","url":"https://api.github.com/users/makenosound","html_url":"https://github.com/makenosound","followers_url":"https://api.github.com/users/makenosound/followers","following_url":"https://api.github.com/users/makenosound/following{/other_user}","gists_url":"https://api.github.com/users/makenosound/gists{/gist_id}","starred_url":"https://api.github.com/users/makenosound/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makenosound/subscriptions","organizations_url":"https://api.github.com/users/makenosound/orgs","repos_url":"https://api.github.com/users/makenosound/repos","events_url":"https://api.github.com/users/makenosound/events{/privacy}","received_events_url":"https://api.github.com/users/makenosound/received_events","type":"User","site_admin":false},"created_at":"2016-05-23T00:38:05Z","updated_at":"2016-05-23T00:38:05Z","body":"@chrisbuttery — nice work! That’s feeling better for sure. Couple of things that I missed last time:\r\n\r\n- [ ] The little height jump when switching from uploading to uploaded feels a little crappy. Reckon it’s possible to get them to be the same height? Would mean adjusting the thumbnail a little I think, but that’s probably better than having the entire form below shift around.\r\n- [ ] The `buttonText` prop isn’t actually settable from the AST. It’s something we’d need to pass through on the `attributes` object, and I think we want to have it’s name be more in line with the way we’ve done it in the `selectionField`. There it’s `selector_label`, so we want something similar, perhaps `upload_label`.\r\n- [ ] We also want the dropzone hint to be configurable in the same way (I noticed it’s hardcoded in CSS now?), perhaps `dropzone_label` for that.\r\n\r\nThose last two will require an adjustment on the ruby side of things to allow them to come through, but I can do that."}}
{"actor":{"display_login":"makenosound"}}