{"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/paasta/pulls/comments/50289241","id":50289241,"diff_hunk":"@@ -156,10 +156,27 @@ def add_subparser(subparsers):\n     validate_parser.set_defaults(command=paasta_validate)\n \n \n+def check_service_path(service_path):\n+    \"\"\"Check that the specified path exists and has yaml files\n+\n+    :param service_path: Path to directory that should contain yaml files\n+    \"\"\"\n+    if not service_path or not os.path.isdir(service_path):\n+        print failure(\"%s is not a directory\" % service_path,\n+                      \"http://paasta.readthedocs.org/en/latest/yelpsoa_configs.html\")\n+        return 1","path":"paasta_tools/cli/cmds/validate.py","position":12,"original_position":12,"commit_id":"8b0492970d0afaa90af61df1041635d1aea0a503","original_commit_id":"8b0492970d0afaa90af61df1041635d1aea0a503","user":{"login":"Rob-Johnson","id":1389671,"avatar_url":"https://avatars.githubusercontent.com/u/1389671?v=3","gravatar_id":"","url":"https://api.github.com/users/Rob-Johnson","html_url":"https://github.com/Rob-Johnson","followers_url":"https://api.github.com/users/Rob-Johnson/followers","following_url":"https://api.github.com/users/Rob-Johnson/following{/other_user}","gists_url":"https://api.github.com/users/Rob-Johnson/gists{/gist_id}","starred_url":"https://api.github.com/users/Rob-Johnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rob-Johnson/subscriptions","organizations_url":"https://api.github.com/users/Rob-Johnson/orgs","repos_url":"https://api.github.com/users/Rob-Johnson/repos","events_url":"https://api.github.com/users/Rob-Johnson/events{/privacy}","received_events_url":"https://api.github.com/users/Rob-Johnson/received_events","type":"User","site_admin":false},"body":"I know this follows the pattern set in the rest of the file, but I'd really like to see these 0s and 1s changed to True or False and turned to the right exit code at exit time","created_at":"2016-01-20T17:37:52Z","updated_at":"2016-01-20T17:37:52Z","html_url":"https://github.com/Yelp/paasta/pull/161#discussion_r50289241","pull_request_url":"https://api.github.com/repos/Yelp/paasta/pulls/161","_links":{"self":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/comments/50289241"},"html":{"href":"https://github.com/Yelp/paasta/pull/161#discussion_r50289241"},"pull_request":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/161"}}},"pull_request":{"url":"https://api.github.com/repos/Yelp/paasta/pulls/161","id":56097960,"html_url":"https://github.com/Yelp/paasta/pull/161","diff_url":"https://github.com/Yelp/paasta/pull/161.diff","patch_url":"https://github.com/Yelp/paasta/pull/161.patch","issue_url":"https://api.github.com/repos/Yelp/paasta/issues/161","number":161,"state":"open","locked":false,"title":"Make paasta check call validate (Closes #128)","user":{"login":"nhandler","id":102499,"avatar_url":"https://avatars.githubusercontent.com/u/102499?v=3","gravatar_id":"","url":"https://api.github.com/users/nhandler","html_url":"https://github.com/nhandler","followers_url":"https://api.github.com/users/nhandler/followers","following_url":"https://api.github.com/users/nhandler/following{/other_user}","gists_url":"https://api.github.com/users/nhandler/gists{/gist_id}","starred_url":"https://api.github.com/users/nhandler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhandler/subscriptions","organizations_url":"https://api.github.com/users/nhandler/orgs","repos_url":"https://api.github.com/users/nhandler/repos","events_url":"https://api.github.com/users/nhandler/events{/privacy}","received_events_url":"https://api.github.com/users/nhandler/received_events","type":"User","site_admin":false},"body":"This will allow `paasta check` to notify users of additional errors with their service. It will catch things such as invalid yelpsoa config syntax (based on the jsonschemas) and invalid chronos schedules.\r\n\r\nCloses #128 ","created_at":"2016-01-14T21:41:37Z","updated_at":"2016-01-20T17:37:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9011297527e67c2d8d9e4d48a89fd268f2c273a3","assignee":{"login":"nhandler","id":102499,"avatar_url":"https://avatars.githubusercontent.com/u/102499?v=3","gravatar_id":"","url":"https://api.github.com/users/nhandler","html_url":"https://github.com/nhandler","followers_url":"https://api.github.com/users/nhandler/followers","following_url":"https://api.github.com/users/nhandler/following{/other_user}","gists_url":"https://api.github.com/users/nhandler/gists{/gist_id}","starred_url":"https://api.github.com/users/nhandler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhandler/subscriptions","organizations_url":"https://api.github.com/users/nhandler/orgs","repos_url":"https://api.github.com/users/nhandler/repos","events_url":"https://api.github.com/users/nhandler/events{/privacy}","received_events_url":"https://api.github.com/users/nhandler/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/paasta/pulls/161/commits","review_comments_url":"https://api.github.com/repos/Yelp/paasta/pulls/161/comments","review_comment_url":"https://api.github.com/repos/Yelp/paasta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/paasta/issues/161/comments","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/8b0492970d0afaa90af61df1041635d1aea0a503","head":{"label":"Yelp:paasta-check-validate","ref":"paasta-check-validate","sha":"8b0492970d0afaa90af61df1041635d1aea0a503","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":44998824,"name":"paasta","full_name":"Yelp/paasta","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/paasta","description":"An open, distributed platform as a service","fork":false,"url":"https://api.github.com/repos/Yelp/paasta","forks_url":"https://api.github.com/repos/Yelp/paasta/forks","keys_url":"https://api.github.com/repos/Yelp/paasta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/paasta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/paasta/teams","hooks_url":"https://api.github.com/repos/Yelp/paasta/hooks","issue_events_url":"https://api.github.com/repos/Yelp/paasta/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/paasta/events","assignees_url":"https://api.github.com/repos/Yelp/paasta/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/paasta/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/paasta/tags","blobs_url":"https://api.github.com/repos/Yelp/paasta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/paasta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/paasta/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/paasta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/paasta/languages","stargazers_url":"https://api.github.com/repos/Yelp/paasta/stargazers","contributors_url":"https://api.github.com/repos/Yelp/paasta/contributors","subscribers_url":"https://api.github.com/repos/Yelp/paasta/subscribers","subscription_url":"https://api.github.com/repos/Yelp/paasta/subscription","commits_url":"https://api.github.com/repos/Yelp/paasta/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/paasta/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/paasta/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/paasta/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/paasta/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/paasta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/paasta/merges","archive_url":"https://api.github.com/repos/Yelp/paasta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/paasta/downloads","issues_url":"https://api.github.com/repos/Yelp/paasta/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/paasta/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/paasta/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/paasta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/paasta/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/paasta/releases{/id}","created_at":"2015-10-26T21:35:53Z","updated_at":"2016-01-19T20:33:31Z","pushed_at":"2016-01-20T17:23:52Z","git_url":"git://github.com/Yelp/paasta.git","ssh_url":"git@github.com:Yelp/paasta.git","clone_url":"https://github.com/Yelp/paasta.git","svn_url":"https://github.com/Yelp/paasta","homepage":"","size":6415,"stargazers_count":696,"watchers_count":696,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":29,"forks":42,"open_issues":29,"watchers":696,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"a4b9000df8c3a6e9e3bd5f228fb258c0e96debea","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":44998824,"name":"paasta","full_name":"Yelp/paasta","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/paasta","description":"An open, distributed platform as a service","fork":false,"url":"https://api.github.com/repos/Yelp/paasta","forks_url":"https://api.github.com/repos/Yelp/paasta/forks","keys_url":"https://api.github.com/repos/Yelp/paasta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/paasta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/paasta/teams","hooks_url":"https://api.github.com/repos/Yelp/paasta/hooks","issue_events_url":"https://api.github.com/repos/Yelp/paasta/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/paasta/events","assignees_url":"https://api.github.com/repos/Yelp/paasta/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/paasta/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/paasta/tags","blobs_url":"https://api.github.com/repos/Yelp/paasta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/paasta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/paasta/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/paasta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/paasta/languages","stargazers_url":"https://api.github.com/repos/Yelp/paasta/stargazers","contributors_url":"https://api.github.com/repos/Yelp/paasta/contributors","subscribers_url":"https://api.github.com/repos/Yelp/paasta/subscribers","subscription_url":"https://api.github.com/repos/Yelp/paasta/subscription","commits_url":"https://api.github.com/repos/Yelp/paasta/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/paasta/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/paasta/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/paasta/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/paasta/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/paasta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/paasta/merges","archive_url":"https://api.github.com/repos/Yelp/paasta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/paasta/downloads","issues_url":"https://api.github.com/repos/Yelp/paasta/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/paasta/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/paasta/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/paasta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/paasta/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/paasta/releases{/id}","created_at":"2015-10-26T21:35:53Z","updated_at":"2016-01-19T20:33:31Z","pushed_at":"2016-01-20T17:23:52Z","git_url":"git://github.com/Yelp/paasta.git","ssh_url":"git@github.com:Yelp/paasta.git","clone_url":"https://github.com/Yelp/paasta.git","svn_url":"https://github.com/Yelp/paasta","homepage":"","size":6415,"stargazers_count":696,"watchers_count":696,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":29,"forks":42,"open_issues":29,"watchers":696,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/161"},"html":{"href":"https://github.com/Yelp/paasta/pull/161"},"issue":{"href":"https://api.github.com/repos/Yelp/paasta/issues/161"},"comments":{"href":"https://api.github.com/repos/Yelp/paasta/issues/161/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/161/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/161/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/paasta/statuses/8b0492970d0afaa90af61df1041635d1aea0a503"}}}}