{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/15327","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/15327/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/15327/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/15327/events","html_url":"https://github.com/mantidproject/mantid/pull/15327","id":133772053,"number":15327,"title":"clang-tidy: modernize-use-default","user":{"login":"quantumsteve","id":5920552,"avatar_url":"https://avatars.githubusercontent.com/u/5920552?v=3","gravatar_id":"","url":"https://api.github.com/users/quantumsteve","html_url":"https://github.com/quantumsteve","followers_url":"https://api.github.com/users/quantumsteve/followers","following_url":"https://api.github.com/users/quantumsteve/following{/other_user}","gists_url":"https://api.github.com/users/quantumsteve/gists{/gist_id}","starred_url":"https://api.github.com/users/quantumsteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantumsteve/subscriptions","organizations_url":"https://api.github.com/users/quantumsteve/orgs","repos_url":"https://api.github.com/users/quantumsteve/repos","events_url":"https://api.github.com/users/quantumsteve/events{/privacy}","received_events_url":"https://api.github.com/users/quantumsteve/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Framework","name":"Component: Framework","color":"009800"},{"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Maintenance","name":"Misc: Maintenance","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"SimonHeybrock","id":12912489,"avatar_url":"https://avatars.githubusercontent.com/u/12912489?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonHeybrock","html_url":"https://github.com/SimonHeybrock","followers_url":"https://api.github.com/users/SimonHeybrock/followers","following_url":"https://api.github.com/users/SimonHeybrock/following{/other_user}","gists_url":"https://api.github.com/users/SimonHeybrock/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonHeybrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonHeybrock/subscriptions","organizations_url":"https://api.github.com/users/SimonHeybrock/orgs","repos_url":"https://api.github.com/users/SimonHeybrock/repos","events_url":"https://api.github.com/users/SimonHeybrock/events{/privacy}","received_events_url":"https://api.github.com/users/SimonHeybrock/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/5","html_url":"https://github.com/mantidproject/mantid/milestones/Release%203.7","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/5/labels","id":1106939,"number":5,"title":"Release 3.7","description":"","creator":{"login":"peterfpeterson","id":404003,"avatar_url":"https://avatars.githubusercontent.com/u/404003?v=3","gravatar_id":"","url":"https://api.github.com/users/peterfpeterson","html_url":"https://github.com/peterfpeterson","followers_url":"https://api.github.com/users/peterfpeterson/followers","following_url":"https://api.github.com/users/peterfpeterson/following{/other_user}","gists_url":"https://api.github.com/users/peterfpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/peterfpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterfpeterson/subscriptions","organizations_url":"https://api.github.com/users/peterfpeterson/orgs","repos_url":"https://api.github.com/users/peterfpeterson/repos","events_url":"https://api.github.com/users/peterfpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/peterfpeterson/received_events","type":"User","site_admin":false},"open_issues":559,"closed_issues":199,"state":"open","created_at":"2015-05-12T15:38:13Z","updated_at":"2016-02-24T23:29:14Z","due_on":"2016-06-05T23:00:00Z","closed_at":null},"comments":50,"created_at":"2016-02-15T17:23:09Z","updated_at":"2016-02-25T02:54:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/15327","html_url":"https://github.com/mantidproject/mantid/pull/15327","diff_url":"https://github.com/mantidproject/mantid/pull/15327.diff","patch_url":"https://github.com/mantidproject/mantid/pull/15327.patch"},"body":" This fixes #12925.\r\n\r\nThis uses clang-tidy's modernize-use-default tool to replace default bodies of special member functions with `= default;`. I then did quite a bit of cleanup, specifically moving `= default;` into the header` and deleting these member function when they would otherwise by generated by the compiler.\r\n\r\ncode review: There are a number of classes with private virtual destructors. Double-check I didn't delete any of those, potentially making the destructor public.\r\n\r\ntesting: If there are missing symbols, the build should fail. I'm not sure how great our test coverage of constructors is. \r\n\r\nGatekeepers: This PR doesn't handle incremental builds well.The master-incremental pipeline may temporarily fail after this is merged."},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/188577735","html_url":"https://github.com/mantidproject/mantid/pull/15327#issuecomment-188577735","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/15327","id":188577735,"user":{"login":"quantumsteve","id":5920552,"avatar_url":"https://avatars.githubusercontent.com/u/5920552?v=3","gravatar_id":"","url":"https://api.github.com/users/quantumsteve","html_url":"https://github.com/quantumsteve","followers_url":"https://api.github.com/users/quantumsteve/followers","following_url":"https://api.github.com/users/quantumsteve/following{/other_user}","gists_url":"https://api.github.com/users/quantumsteve/gists{/gist_id}","starred_url":"https://api.github.com/users/quantumsteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantumsteve/subscriptions","organizations_url":"https://api.github.com/users/quantumsteve/orgs","repos_url":"https://api.github.com/users/quantumsteve/repos","events_url":"https://api.github.com/users/quantumsteve/events{/privacy}","received_events_url":"https://api.github.com/users/quantumsteve/received_events","type":"User","site_admin":false},"created_at":"2016-02-25T02:54:07Z","updated_at":"2016-02-25T02:54:07Z","body":"In Surface.h, I set the assignment op. to address `= default to fix a build error on Windows."}}