{"action":"created","comment":{"url":"https://api.github.com/repos/PeterJohnson/ntcore/pulls/comments/48759122","id":48759122,"diff_hunk":"@@ -43,6 +42,8 @@ void NetworkTable::SetTeam(int team) {\n   char tmp[30];\n #ifdef _MSC_VER\n   sprintf_s(tmp, \"roboRIO-%d-FRC.local\\n\", team);\n+#elif defined(__ANDROID__)\n+  snprintf(tmp, 30, \"roboRIO-%d-FRC.local\\n\",team);","path":"src/networktables/NetworkTable.cpp","position":13,"original_position":13,"commit_id":"8c58fbc4f3673e89276c8f58df9071dad6334c1b","original_commit_id":"8c58fbc4f3673e89276c8f58df9071dad6334c1b","user":{"login":"ThadHouse","id":7727148,"avatar_url":"https://avatars.githubusercontent.com/u/7727148?v=3","gravatar_id":"","url":"https://api.github.com/users/ThadHouse","html_url":"https://github.com/ThadHouse","followers_url":"https://api.github.com/users/ThadHouse/followers","following_url":"https://api.github.com/users/ThadHouse/following{/other_user}","gists_url":"https://api.github.com/users/ThadHouse/gists{/gist_id}","starred_url":"https://api.github.com/users/ThadHouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThadHouse/subscriptions","organizations_url":"https://api.github.com/users/ThadHouse/orgs","repos_url":"https://api.github.com/users/ThadHouse/repos","events_url":"https://api.github.com/users/ThadHouse/events{/privacy}","received_events_url":"https://api.github.com/users/ThadHouse/received_events","type":"User","site_admin":false},"body":"I used the directions here http://developer.android.com/ndk/guides/standalone_toolchain.html to create a standalone toolchain for android. I believe I used this switch ```--toolchain=arm-linux-androideabi-4.9``` to get the 4.9 version I was using. Then what I did was placed the standalone toolchain in my path, and then changed the arm.gradle file to use the different toolchain prefix. Then just compiled with gradle, and it worked (well kind of). I tested on my nexus 6 with Xamarin, and it worked and connected. However, MDNS did not work, and for some reason the code had be in debug mode, as release mode would not connect to the network properly. \r\n\r\nI was kind of surprised that it worked too. But the changes here are the only changes I needed to get it working and compiling.","created_at":"2016-01-04T18:00:16Z","updated_at":"2016-01-04T18:00:16Z","html_url":"https://github.com/PeterJohnson/ntcore/pull/44#discussion_r48759122","pull_request_url":"https://api.github.com/repos/PeterJohnson/ntcore/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/PeterJohnson/ntcore/pulls/comments/48759122"},"html":{"href":"https://github.com/PeterJohnson/ntcore/pull/44#discussion_r48759122"},"pull_request":{"href":"https://api.github.com/repos/PeterJohnson/ntcore/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/PeterJohnson/ntcore/pulls/44","id":54944438,"html_url":"https://github.com/PeterJohnson/ntcore/pull/44","diff_url":"https://github.com/PeterJohnson/ntcore/pull/44.diff","patch_url":"https://github.com/PeterJohnson/ntcore/pull/44.patch","issue_url":"https://api.github.com/repos/PeterJohnson/ntcore/issues/44","number":44,"state":"open","locked":false,"title":"Fixes Android Build issues","user":{"login":"ThadHouse","id":7727148,"avatar_url":"https://avatars.githubusercontent.com/u/7727148?v=3","gravatar_id":"","url":"https://api.github.com/users/ThadHouse","html_url":"https://github.com/ThadHouse","followers_url":"https://api.github.com/users/ThadHouse/followers","following_url":"https://api.github.com/users/ThadHouse/following{/other_user}","gists_url":"https://api.github.com/users/ThadHouse/gists{/gist_id}","starred_url":"https://api.github.com/users/ThadHouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThadHouse/subscriptions","organizations_url":"https://api.github.com/users/ThadHouse/orgs","repos_url":"https://api.github.com/users/ThadHouse/repos","events_url":"https://api.github.com/users/ThadHouse/events{/privacy}","received_events_url":"https://api.github.com/users/ThadHouse/received_events","type":"User","site_admin":false},"body":"Trying to build with the android standalone compiler, and these 2 things were causing errors. I don't know what an equivalent to basename would be, because I don't really know what it does. ","created_at":"2016-01-04T05:28:22Z","updated_at":"2016-01-04T18:00:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4495eecb95492420b283bf64f9d88a7552eaaf25","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PeterJohnson/ntcore/pulls/44/commits","review_comments_url":"https://api.github.com/repos/PeterJohnson/ntcore/pulls/44/comments","review_comment_url":"https://api.github.com/repos/PeterJohnson/ntcore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PeterJohnson/ntcore/issues/44/comments","statuses_url":"https://api.github.com/repos/PeterJohnson/ntcore/statuses/8c58fbc4f3673e89276c8f58df9071dad6334c1b","head":{"label":"ThadHouse:master","ref":"master","sha":"8c58fbc4f3673e89276c8f58df9071dad6334c1b","user":{"login":"ThadHouse","id":7727148,"avatar_url":"https://avatars.githubusercontent.com/u/7727148?v=3","gravatar_id":"","url":"https://api.github.com/users/ThadHouse","html_url":"https://github.com/ThadHouse","followers_url":"https://api.github.com/users/ThadHouse/followers","following_url":"https://api.github.com/users/ThadHouse/following{/other_user}","gists_url":"https://api.github.com/users/ThadHouse/gists{/gist_id}","starred_url":"https://api.github.com/users/ThadHouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThadHouse/subscriptions","organizations_url":"https://api.github.com/users/ThadHouse/orgs","repos_url":"https://api.github.com/users/ThadHouse/repos","events_url":"https://api.github.com/users/ThadHouse/events{/privacy}","received_events_url":"https://api.github.com/users/ThadHouse/received_events","type":"User","site_admin":false},"repo":{"id":41039686,"name":"ntcore","full_name":"ThadHouse/ntcore","owner":{"login":"ThadHouse","id":7727148,"avatar_url":"https://avatars.githubusercontent.com/u/7727148?v=3","gravatar_id":"","url":"https://api.github.com/users/ThadHouse","html_url":"https://github.com/ThadHouse","followers_url":"https://api.github.com/users/ThadHouse/followers","following_url":"https://api.github.com/users/ThadHouse/following{/other_user}","gists_url":"https://api.github.com/users/ThadHouse/gists{/gist_id}","starred_url":"https://api.github.com/users/ThadHouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThadHouse/subscriptions","organizations_url":"https://api.github.com/users/ThadHouse/orgs","repos_url":"https://api.github.com/users/ThadHouse/repos","events_url":"https://api.github.com/users/ThadHouse/events{/privacy}","received_events_url":"https://api.github.com/users/ThadHouse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ThadHouse/ntcore","description":"NetworkTables Core Library","fork":true,"url":"https://api.github.com/repos/ThadHouse/ntcore","forks_url":"https://api.github.com/repos/ThadHouse/ntcore/forks","keys_url":"https://api.github.com/repos/ThadHouse/ntcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThadHouse/ntcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThadHouse/ntcore/teams","hooks_url":"https://api.github.com/repos/ThadHouse/ntcore/hooks","issue_events_url":"https://api.github.com/repos/ThadHouse/ntcore/issues/events{/number}","events_url":"https://api.github.com/repos/ThadHouse/ntcore/events","assignees_url":"https://api.github.com/repos/ThadHouse/ntcore/assignees{/user}","branches_url":"https://api.github.com/repos/ThadHouse/ntcore/branches{/branch}","tags_url":"https://api.github.com/repos/ThadHouse/ntcore/tags","blobs_url":"https://api.github.com/repos/ThadHouse/ntcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThadHouse/ntcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThadHouse/ntcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThadHouse/ntcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThadHouse/ntcore/statuses/{sha}","languages_url":"https://api.github.com/repos/ThadHouse/ntcore/languages","stargazers_url":"https://api.github.com/repos/ThadHouse/ntcore/stargazers","contributors_url":"https://api.github.com/repos/ThadHouse/ntcore/contributors","subscribers_url":"https://api.github.com/repos/ThadHouse/ntcore/subscribers","subscription_url":"https://api.github.com/repos/ThadHouse/ntcore/subscription","commits_url":"https://api.github.com/repos/ThadHouse/ntcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThadHouse/ntcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThadHouse/ntcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThadHouse/ntcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThadHouse/ntcore/contents/{+path}","compare_url":"https://api.github.com/repos/ThadHouse/ntcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThadHouse/ntcore/merges","archive_url":"https://api.github.com/repos/ThadHouse/ntcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThadHouse/ntcore/downloads","issues_url":"https://api.github.com/repos/ThadHouse/ntcore/issues{/number}","pulls_url":"https://api.github.com/repos/ThadHouse/ntcore/pulls{/number}","milestones_url":"https://api.github.com/repos/ThadHouse/ntcore/milestones{/number}","notifications_url":"https://api.github.com/repos/ThadHouse/ntcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThadHouse/ntcore/labels{/name}","releases_url":"https://api.github.com/repos/ThadHouse/ntcore/releases{/id}","created_at":"2015-08-19T14:35:09Z","updated_at":"2015-08-19T14:35:09Z","pushed_at":"2016-01-04T16:40:39Z","git_url":"git://github.com/ThadHouse/ntcore.git","ssh_url":"git@github.com:ThadHouse/ntcore.git","clone_url":"https://github.com/ThadHouse/ntcore.git","svn_url":"https://github.com/ThadHouse/ntcore","homepage":null,"size":1137,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PeterJohnson:master","ref":"master","sha":"5e2a07d58a83e4e1e6183cd8d3ca3aa1374c701d","user":{"login":"PeterJohnson","id":297126,"avatar_url":"https://avatars.githubusercontent.com/u/297126?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterJohnson","html_url":"https://github.com/PeterJohnson","followers_url":"https://api.github.com/users/PeterJohnson/followers","following_url":"https://api.github.com/users/PeterJohnson/following{/other_user}","gists_url":"https://api.github.com/users/PeterJohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterJohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterJohnson/subscriptions","organizations_url":"https://api.github.com/users/PeterJohnson/orgs","repos_url":"https://api.github.com/users/PeterJohnson/repos","events_url":"https://api.github.com/users/PeterJohnson/events{/privacy}","received_events_url":"https://api.github.com/users/PeterJohnson/received_events","type":"User","site_admin":false},"repo":{"id":39292316,"name":"ntcore","full_name":"PeterJohnson/ntcore","owner":{"login":"PeterJohnson","id":297126,"avatar_url":"https://avatars.githubusercontent.com/u/297126?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterJohnson","html_url":"https://github.com/PeterJohnson","followers_url":"https://api.github.com/users/PeterJohnson/followers","following_url":"https://api.github.com/users/PeterJohnson/following{/other_user}","gists_url":"https://api.github.com/users/PeterJohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterJohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterJohnson/subscriptions","organizations_url":"https://api.github.com/users/PeterJohnson/orgs","repos_url":"https://api.github.com/users/PeterJohnson/repos","events_url":"https://api.github.com/users/PeterJohnson/events{/privacy}","received_events_url":"https://api.github.com/users/PeterJohnson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PeterJohnson/ntcore","description":"NetworkTables Core Library","fork":false,"url":"https://api.github.com/repos/PeterJohnson/ntcore","forks_url":"https://api.github.com/repos/PeterJohnson/ntcore/forks","keys_url":"https://api.github.com/repos/PeterJohnson/ntcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PeterJohnson/ntcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PeterJohnson/ntcore/teams","hooks_url":"https://api.github.com/repos/PeterJohnson/ntcore/hooks","issue_events_url":"https://api.github.com/repos/PeterJohnson/ntcore/issues/events{/number}","events_url":"https://api.github.com/repos/PeterJohnson/ntcore/events","assignees_url":"https://api.github.com/repos/PeterJohnson/ntcore/assignees{/user}","branches_url":"https://api.github.com/repos/PeterJohnson/ntcore/branches{/branch}","tags_url":"https://api.github.com/repos/PeterJohnson/ntcore/tags","blobs_url":"https://api.github.com/repos/PeterJohnson/ntcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PeterJohnson/ntcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PeterJohnson/ntcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/PeterJohnson/ntcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PeterJohnson/ntcore/statuses/{sha}","languages_url":"https://api.github.com/repos/PeterJohnson/ntcore/languages","stargazers_url":"https://api.github.com/repos/PeterJohnson/ntcore/stargazers","contributors_url":"https://api.github.com/repos/PeterJohnson/ntcore/contributors","subscribers_url":"https://api.github.com/repos/PeterJohnson/ntcore/subscribers","subscription_url":"https://api.github.com/repos/PeterJohnson/ntcore/subscription","commits_url":"https://api.github.com/repos/PeterJohnson/ntcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/PeterJohnson/ntcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/PeterJohnson/ntcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/PeterJohnson/ntcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/PeterJohnson/ntcore/contents/{+path}","compare_url":"https://api.github.com/repos/PeterJohnson/ntcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PeterJohnson/ntcore/merges","archive_url":"https://api.github.com/repos/PeterJohnson/ntcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PeterJohnson/ntcore/downloads","issues_url":"https://api.github.com/repos/PeterJohnson/ntcore/issues{/number}","pulls_url":"https://api.github.com/repos/PeterJohnson/ntcore/pulls{/number}","milestones_url":"https://api.github.com/repos/PeterJohnson/ntcore/milestones{/number}","notifications_url":"https://api.github.com/repos/PeterJohnson/ntcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PeterJohnson/ntcore/labels{/name}","releases_url":"https://api.github.com/repos/PeterJohnson/ntcore/releases{/id}","created_at":"2015-07-18T08:45:42Z","updated_at":"2015-11-02T20:47:17Z","pushed_at":"2016-01-04T17:39:46Z","git_url":"git://github.com/PeterJohnson/ntcore.git","ssh_url":"git@github.com:PeterJohnson/ntcore.git","clone_url":"https://github.com/PeterJohnson/ntcore.git","svn_url":"https://github.com/PeterJohnson/ntcore","homepage":null,"size":1468,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":10,"forks":7,"open_issues":10,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PeterJohnson/ntcore/pulls/44"},"html":{"href":"https://github.com/PeterJohnson/ntcore/pull/44"},"issue":{"href":"https://api.github.com/repos/PeterJohnson/ntcore/issues/44"},"comments":{"href":"https://api.github.com/repos/PeterJohnson/ntcore/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/PeterJohnson/ntcore/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/PeterJohnson/ntcore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PeterJohnson/ntcore/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/PeterJohnson/ntcore/statuses/8c58fbc4f3673e89276c8f58df9071dad6334c1b"}}}}