{"action":"created","issue":{"url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/2146","repository_url":"https://api.github.com/repos/quicksilver/Quicksilver","labels_url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/2146/labels{/name}","comments_url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/2146/comments","events_url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/2146/events","html_url":"https://github.com/quicksilver/Quicksilver/pull/2146","id":114324655,"number":2146,"title":"Notification rewrite","user":{"login":"tiennou","id":81099,"avatar_url":"https://avatars.githubusercontent.com/u/81099?v=3","gravatar_id":"","url":"https://api.github.com/users/tiennou","html_url":"https://github.com/tiennou","followers_url":"https://api.github.com/users/tiennou/followers","following_url":"https://api.github.com/users/tiennou/following{/other_user}","gists_url":"https://api.github.com/users/tiennou/gists{/gist_id}","starred_url":"https://api.github.com/users/tiennou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiennou/subscriptions","organizations_url":"https://api.github.com/users/tiennou/orgs","repos_url":"https://api.github.com/users/tiennou/repos","events_url":"https://api.github.com/users/tiennou/events{/privacy}","received_events_url":"https://api.github.com/users/tiennou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2015-10-30T18:08:50Z","updated_at":"2016-11-30T14:09:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/quicksilver/Quicksilver/pulls/2146","html_url":"https://github.com/quicksilver/Quicksilver/pull/2146","diff_url":"https://github.com/quicksilver/Quicksilver/pull/2146.diff","patch_url":"https://github.com/quicksilver/Quicksilver/pull/2146.patch"},"body":"So, this is an alternate version of #2104. Sorry @skurfer, I didn't like the \"one delegate to rule them all approach\", though as I said earlier, it's because of the API.\n\nThis one uses a block to notify what choice the user made. Right now it uses the same kind of block than the alerts do, but depending on some discussion, that can change. I prefer that to moving gobs of important code to [unrelated places](https://github.com/quicksilver/Quicksilver/pull/2104/files?diff=unified#diff-29f2dfd46753000b6ca6b67b790754d9R481). I do agree the update code is not the most streamlined code to pick on, but, well...\n\nSomething I planned for but didn't yet handle is automatically escalating notifications to alerts via the delegate callback (that's why I started on cleaning up `QSAlertManager` first, then proceeded to notification handling). The issue is that I can't think of a good way of _not_ doing so without changing the block's signature. Maybe provide a third method that has the automatic escalation behavior in ?\n"},"comment":{"url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/comments/263882108","html_url":"https://github.com/quicksilver/Quicksilver/pull/2146#issuecomment-263882108","issue_url":"https://api.github.com/repos/quicksilver/Quicksilver/issues/2146","id":263882108,"user":{"login":"skurfer","id":154676,"avatar_url":"https://avatars.githubusercontent.com/u/154676?v=3","gravatar_id":"","url":"https://api.github.com/users/skurfer","html_url":"https://github.com/skurfer","followers_url":"https://api.github.com/users/skurfer/followers","following_url":"https://api.github.com/users/skurfer/following{/other_user}","gists_url":"https://api.github.com/users/skurfer/gists{/gist_id}","starred_url":"https://api.github.com/users/skurfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skurfer/subscriptions","organizations_url":"https://api.github.com/users/skurfer/orgs","repos_url":"https://api.github.com/users/skurfer/repos","events_url":"https://api.github.com/users/skurfer/events{/privacy}","received_events_url":"https://api.github.com/users/skurfer/received_events","type":"User","site_admin":false},"created_at":"2016-11-30T14:09:50Z","updated_at":"2016-11-30T14:09:50Z","body":"Regarding that crash, I think this branch actually fixes a number of similar crashes. We just need to add the file conflict thing to the main thread. And I think that exception only crashes if ou build with the latest SDK, so might not affect release builds (done from 10.10). Going to test."}}
{"actor":{"display_login":"skurfer"}}