{"action":"closed","issue":{"url":"https://api.github.com/repos/SheffieldML/GPy/issues/430","repository_url":"https://api.github.com/repos/SheffieldML/GPy","labels_url":"https://api.github.com/repos/SheffieldML/GPy/issues/430/labels{/name}","comments_url":"https://api.github.com/repos/SheffieldML/GPy/issues/430/comments","events_url":"https://api.github.com/repos/SheffieldML/GPy/issues/430/events","html_url":"https://github.com/SheffieldML/GPy/issues/430","id":172243062,"number":430,"title":"LogisticBasisFuncKernel doesn't allow negative values for slope","user":{"login":"bwengals","id":6325473,"avatar_url":"https://avatars.githubusercontent.com/u/6325473?v=3","gravatar_id":"","url":"https://api.github.com/users/bwengals","html_url":"https://github.com/bwengals","followers_url":"https://api.github.com/users/bwengals/followers","following_url":"https://api.github.com/users/bwengals/following{/other_user}","gists_url":"https://api.github.com/users/bwengals/gists{/gist_id}","starred_url":"https://api.github.com/users/bwengals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwengals/subscriptions","organizations_url":"https://api.github.com/users/bwengals/orgs","repos_url":"https://api.github.com/users/bwengals/repos","events_url":"https://api.github.com/users/bwengals/events{/privacy}","received_events_url":"https://api.github.com/users/bwengals/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-20T00:26:57Z","updated_at":"2016-09-02T07:49:09Z","closed_at":"2016-09-02T07:49:09Z","body":"Hi GPy devs,\r\n\r\nThe LogisticBasisFuncKernel currently only allows positive values for the slope parameter.  This means that the function can only slope up from left to right, not also down from left to right.  Checking the source,  at /GPy/kern/src/basis_funcs.py, I think lines 145 and 147 are where the issue is. \r\n\r\nI'm not sure how the Param class works completely, but removing the Logsumexp() argument seemed to do the trick.\r\n\r\nself.slope = Param('slope', slope, Logexp())  -> self.slope = Param('slope', slope)\r\n\r\nIs this correct?  Would be happy to submit a PR --- is this the right usage of Param?"}}
{"actor":{"display_login":"mzwiessele"}}