{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/85862338","pull_request_review_id":6552115,"id":85862338,"diff_hunk":"@@ -63,7 +64,8 @@ TableBuilder* NewTableBuilder(\n extern Status BuildTable(\n     const std::string& dbname, Env* env, const ImmutableCFOptions& options,\n     const MutableCFOptions& mutable_cf_options, const EnvOptions& env_options,\n-    TableCache* table_cache, InternalIterator* iter, FileMetaData* meta,\n+    TableCache* table_cache, InternalIterator* iter,\n+    ScopedArenaIterator range_del_iter, FileMetaData* meta,","path":"db/builder.h","position":14,"original_position":14,"commit_id":"97c58e761aec491c11a297c708b9b98b4710c255","original_commit_id":"97c58e761aec491c11a297c708b9b98b4710c255","user":{"login":"lightmark","id":1549573,"avatar_url":"https://avatars.githubusercontent.com/u/1549573?v=3","gravatar_id":"","url":"https://api.github.com/users/lightmark","html_url":"https://github.com/lightmark","followers_url":"https://api.github.com/users/lightmark/followers","following_url":"https://api.github.com/users/lightmark/following{/other_user}","gists_url":"https://api.github.com/users/lightmark/gists{/gist_id}","starred_url":"https://api.github.com/users/lightmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightmark/subscriptions","organizations_url":"https://api.github.com/users/lightmark/orgs","repos_url":"https://api.github.com/users/lightmark/repos","events_url":"https://api.github.com/users/lightmark/events{/privacy}","received_events_url":"https://api.github.com/users/lightmark/received_events","type":"User","site_admin":false},"body":"same here","created_at":"2016-11-01T01:00:43Z","updated_at":"2016-11-01T01:05:14Z","html_url":"https://github.com/facebook/rocksdb/pull/1438#discussion_r85862338","pull_request_url":"https://api.github.com/repos/facebook/rocksdb/pulls/1438","_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/85862338"},"html":{"href":"https://github.com/facebook/rocksdb/pull/1438#discussion_r85862338"},"pull_request":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/1438"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/1438","id":91469000,"html_url":"https://github.com/facebook/rocksdb/pull/1438","diff_url":"https://github.com/facebook/rocksdb/pull/1438.diff","patch_url":"https://github.com/facebook/rocksdb/pull/1438.patch","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/1438","number":1438,"state":"open","locked":false,"title":"DeleteRange flush support","user":{"login":"ajkr","id":4780362,"avatar_url":"https://avatars.githubusercontent.com/u/4780362?v=3","gravatar_id":"","url":"https://api.github.com/users/ajkr","html_url":"https://github.com/ajkr","followers_url":"https://api.github.com/users/ajkr/followers","following_url":"https://api.github.com/users/ajkr/following{/other_user}","gists_url":"https://api.github.com/users/ajkr/gists{/gist_id}","starred_url":"https://api.github.com/users/ajkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajkr/subscriptions","organizations_url":"https://api.github.com/users/ajkr/orgs","repos_url":"https://api.github.com/users/ajkr/repos","events_url":"https://api.github.com/users/ajkr/events{/privacy}","received_events_url":"https://api.github.com/users/ajkr/received_events","type":"User","site_admin":false},"body":"Summary: Changed BuildTable() (used for flush) to (1) add range\ntombstones to the aggregator, which is used by CompactionIterator to\ndetermine which keys can be removed; and (2) add aggregator's range\ntombstones to the table that is output for the flush.\n\nTest Plan: flush_job_test, also tested together with end-to-end tests in\nD63927\n","created_at":"2016-10-28T23:44:07Z","updated_at":"2016-11-01T01:05:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"afe650a10490ad0e45a5fd102a6c5da7eca6b4f9","assignee":{"login":"lightmark","id":1549573,"avatar_url":"https://avatars.githubusercontent.com/u/1549573?v=3","gravatar_id":"","url":"https://api.github.com/users/lightmark","html_url":"https://github.com/lightmark","followers_url":"https://api.github.com/users/lightmark/followers","following_url":"https://api.github.com/users/lightmark/following{/other_user}","gists_url":"https://api.github.com/users/lightmark/gists{/gist_id}","starred_url":"https://api.github.com/users/lightmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightmark/subscriptions","organizations_url":"https://api.github.com/users/lightmark/orgs","repos_url":"https://api.github.com/users/lightmark/repos","events_url":"https://api.github.com/users/lightmark/events{/privacy}","received_events_url":"https://api.github.com/users/lightmark/received_events","type":"User","site_admin":false},"assignees":[{"login":"lightmark","id":1549573,"avatar_url":"https://avatars.githubusercontent.com/u/1549573?v=3","gravatar_id":"","url":"https://api.github.com/users/lightmark","html_url":"https://github.com/lightmark","followers_url":"https://api.github.com/users/lightmark/followers","following_url":"https://api.github.com/users/lightmark/following{/other_user}","gists_url":"https://api.github.com/users/lightmark/gists{/gist_id}","starred_url":"https://api.github.com/users/lightmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightmark/subscriptions","organizations_url":"https://api.github.com/users/lightmark/orgs","repos_url":"https://api.github.com/users/lightmark/repos","events_url":"https://api.github.com/users/lightmark/events{/privacy}","received_events_url":"https://api.github.com/users/lightmark/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/rocksdb/pulls/1438/commits","review_comments_url":"https://api.github.com/repos/facebook/rocksdb/pulls/1438/comments","review_comment_url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/1438/comments","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/97c58e761aec491c11a297c708b9b98b4710c255","head":{"label":"ajkr:D62259","ref":"D62259","sha":"97c58e761aec491c11a297c708b9b98b4710c255","user":{"login":"ajkr","id":4780362,"avatar_url":"https://avatars.githubusercontent.com/u/4780362?v=3","gravatar_id":"","url":"https://api.github.com/users/ajkr","html_url":"https://github.com/ajkr","followers_url":"https://api.github.com/users/ajkr/followers","following_url":"https://api.github.com/users/ajkr/following{/other_user}","gists_url":"https://api.github.com/users/ajkr/gists{/gist_id}","starred_url":"https://api.github.com/users/ajkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajkr/subscriptions","organizations_url":"https://api.github.com/users/ajkr/orgs","repos_url":"https://api.github.com/users/ajkr/repos","events_url":"https://api.github.com/users/ajkr/events{/privacy}","received_events_url":"https://api.github.com/users/ajkr/received_events","type":"User","site_admin":false},"repo":{"id":69681666,"name":"rocksdb","full_name":"ajkr/rocksdb","owner":{"login":"ajkr","id":4780362,"avatar_url":"https://avatars.githubusercontent.com/u/4780362?v=3","gravatar_id":"","url":"https://api.github.com/users/ajkr","html_url":"https://github.com/ajkr","followers_url":"https://api.github.com/users/ajkr/followers","following_url":"https://api.github.com/users/ajkr/following{/other_user}","gists_url":"https://api.github.com/users/ajkr/gists{/gist_id}","starred_url":"https://api.github.com/users/ajkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajkr/subscriptions","organizations_url":"https://api.github.com/users/ajkr/orgs","repos_url":"https://api.github.com/users/ajkr/repos","events_url":"https://api.github.com/users/ajkr/events{/privacy}","received_events_url":"https://api.github.com/users/ajkr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajkr/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":true,"url":"https://api.github.com/repos/ajkr/rocksdb","forks_url":"https://api.github.com/repos/ajkr/rocksdb/forks","keys_url":"https://api.github.com/repos/ajkr/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajkr/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajkr/rocksdb/teams","hooks_url":"https://api.github.com/repos/ajkr/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/ajkr/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/ajkr/rocksdb/events","assignees_url":"https://api.github.com/repos/ajkr/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/ajkr/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/ajkr/rocksdb/tags","blobs_url":"https://api.github.com/repos/ajkr/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajkr/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajkr/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajkr/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajkr/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/ajkr/rocksdb/languages","stargazers_url":"https://api.github.com/repos/ajkr/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/ajkr/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/ajkr/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/ajkr/rocksdb/subscription","commits_url":"https://api.github.com/repos/ajkr/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajkr/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajkr/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajkr/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajkr/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/ajkr/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajkr/rocksdb/merges","archive_url":"https://api.github.com/repos/ajkr/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajkr/rocksdb/downloads","issues_url":"https://api.github.com/repos/ajkr/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/ajkr/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/ajkr/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/ajkr/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajkr/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/ajkr/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/ajkr/rocksdb/deployments","created_at":"2016-09-30T16:09:32Z","updated_at":"2016-09-30T16:09:37Z","pushed_at":"2016-10-28T23:41:22Z","git_url":"git://github.com/ajkr/rocksdb.git","ssh_url":"git@github.com:ajkr/rocksdb.git","clone_url":"https://github.com/ajkr/rocksdb.git","svn_url":"https://github.com/ajkr/rocksdb","homepage":"http://rocksdb.org","size":122765,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"2946cadc46e444601e30b3ced0d59d9c938df84b","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":6934395,"name":"rocksdb","full_name":"facebook/rocksdb","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":false,"url":"https://api.github.com/repos/facebook/rocksdb","forks_url":"https://api.github.com/repos/facebook/rocksdb/forks","keys_url":"https://api.github.com/repos/facebook/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/rocksdb/teams","hooks_url":"https://api.github.com/repos/facebook/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/facebook/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/rocksdb/events","assignees_url":"https://api.github.com/repos/facebook/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/rocksdb/tags","blobs_url":"https://api.github.com/repos/facebook/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/rocksdb/languages","stargazers_url":"https://api.github.com/repos/facebook/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/facebook/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/facebook/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/facebook/rocksdb/subscription","commits_url":"https://api.github.com/repos/facebook/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/rocksdb/merges","archive_url":"https://api.github.com/repos/facebook/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/rocksdb/downloads","issues_url":"https://api.github.com/repos/facebook/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/facebook/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/rocksdb/deployments","created_at":"2012-11-30T06:16:18Z","updated_at":"2016-11-01T00:27:29Z","pushed_at":"2016-11-01T01:02:54Z","git_url":"git://github.com/facebook/rocksdb.git","ssh_url":"git@github.com:facebook/rocksdb.git","clone_url":"https://github.com/facebook/rocksdb.git","svn_url":"https://github.com/facebook/rocksdb","homepage":"http://rocksdb.org","size":129322,"stargazers_count":6349,"watchers_count":6349,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1316,"mirror_url":null,"open_issues_count":286,"forks":1316,"open_issues":286,"watchers":6349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/1438"},"html":{"href":"https://github.com/facebook/rocksdb/pull/1438"},"issue":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/1438"},"comments":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/1438/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/1438/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/1438/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/rocksdb/statuses/97c58e761aec491c11a297c708b9b98b4710c255"}}}}
{"actor":{"display_login":"lightmark"}}