{"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/86723654","pull_request_review_id":7366297,"id":86723654,"diff_hunk":"@@ -93,3 +108,166 @@ void console_flush(void)\n {\n \tpl011_flush(console_base());\n }\n+\n+static vaddr_t peripherals_base(paddr_t pa)\n+{\n+\tvoid *va;\n+\n+\tif (cpu_mmu_enabled()) {\n+\t\tva = phys_to_virt(pa, MEM_AREA_IO_NSEC);\n+\t\treturn (vaddr_t)va;\n+\t}\n+\treturn (vaddr_t)pa;\n+}\n+\n+#ifdef CFG_SPI\n+#ifdef CFG_SPI_TEST\n+static void spi_test(void)","path":"core/arch/arm/plat-hikey/main.c","position":47,"original_position":47,"commit_id":"ef663d792498c40a3926f895981b06c1bab39384","original_commit_id":"ef663d792498c40a3926f895981b06c1bab39384","user":{"login":"jenswi-linaro","id":6150306,"avatar_url":"https://avatars.githubusercontent.com/u/6150306?v=3","gravatar_id":"","url":"https://api.github.com/users/jenswi-linaro","html_url":"https://github.com/jenswi-linaro","followers_url":"https://api.github.com/users/jenswi-linaro/followers","following_url":"https://api.github.com/users/jenswi-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jenswi-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswi-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswi-linaro/subscriptions","organizations_url":"https://api.github.com/users/jenswi-linaro/orgs","repos_url":"https://api.github.com/users/jenswi-linaro/repos","events_url":"https://api.github.com/users/jenswi-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jenswi-linaro/received_events","type":"User","site_admin":false},"body":"If possible I'd rather test this via a static TA.","created_at":"2016-11-07T07:36:56Z","updated_at":"2016-11-07T07:36:56Z","html_url":"https://github.com/OP-TEE/optee_os/pull/1161#discussion_r86723654","pull_request_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1161","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/86723654"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/1161#discussion_r86723654"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1161"}}},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1161","id":92483214,"html_url":"https://github.com/OP-TEE/optee_os/pull/1161","diff_url":"https://github.com/OP-TEE/optee_os/pull/1161.diff","patch_url":"https://github.com/OP-TEE/optee_os/pull/1161.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/1161","number":1161,"state":"open","locked":false,"title":"hikey: enable spi by default and add sample test code","user":{"login":"vchong","id":7334750,"avatar_url":"https://avatars.githubusercontent.com/u/7334750?v=3","gravatar_id":"","url":"https://api.github.com/users/vchong","html_url":"https://github.com/vchong","followers_url":"https://api.github.com/users/vchong/followers","following_url":"https://api.github.com/users/vchong/following{/other_user}","gists_url":"https://api.github.com/users/vchong/gists{/gist_id}","starred_url":"https://api.github.com/users/vchong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vchong/subscriptions","organizations_url":"https://api.github.com/users/vchong/orgs","repos_url":"https://api.github.com/users/vchong/repos","events_url":"https://api.github.com/users/vchong/events{/privacy}","received_events_url":"https://api.github.com/users/vchong/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Victor Chong <victor.chong@linaro.org>\r\nTested-by: Victor Chong <victor.chong@linaro.org> (with CFG_SPI_TEST=y)","created_at":"2016-11-06T10:38:54Z","updated_at":"2016-11-07T07:51:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbaeb8d540a864518afecb2aef7819eec69a1a92","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1161/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1161/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/1161/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/ef663d792498c40a3926f895981b06c1bab39384","head":{"label":"vchong:hikey_spi2","ref":"hikey_spi2","sha":"ef663d792498c40a3926f895981b06c1bab39384","user":{"login":"vchong","id":7334750,"avatar_url":"https://avatars.githubusercontent.com/u/7334750?v=3","gravatar_id":"","url":"https://api.github.com/users/vchong","html_url":"https://github.com/vchong","followers_url":"https://api.github.com/users/vchong/followers","following_url":"https://api.github.com/users/vchong/following{/other_user}","gists_url":"https://api.github.com/users/vchong/gists{/gist_id}","starred_url":"https://api.github.com/users/vchong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vchong/subscriptions","organizations_url":"https://api.github.com/users/vchong/orgs","repos_url":"https://api.github.com/users/vchong/repos","events_url":"https://api.github.com/users/vchong/events{/privacy}","received_events_url":"https://api.github.com/users/vchong/received_events","type":"User","site_admin":false},"repo":{"id":32530410,"name":"optee_os","full_name":"vchong/optee_os","owner":{"login":"vchong","id":7334750,"avatar_url":"https://avatars.githubusercontent.com/u/7334750?v=3","gravatar_id":"","url":"https://api.github.com/users/vchong","html_url":"https://github.com/vchong","followers_url":"https://api.github.com/users/vchong/followers","following_url":"https://api.github.com/users/vchong/following{/other_user}","gists_url":"https://api.github.com/users/vchong/gists{/gist_id}","starred_url":"https://api.github.com/users/vchong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vchong/subscriptions","organizations_url":"https://api.github.com/users/vchong/orgs","repos_url":"https://api.github.com/users/vchong/repos","events_url":"https://api.github.com/users/vchong/events{/privacy}","received_events_url":"https://api.github.com/users/vchong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vchong/optee_os","description":"Trusted side of the TEE","fork":true,"url":"https://api.github.com/repos/vchong/optee_os","forks_url":"https://api.github.com/repos/vchong/optee_os/forks","keys_url":"https://api.github.com/repos/vchong/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vchong/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vchong/optee_os/teams","hooks_url":"https://api.github.com/repos/vchong/optee_os/hooks","issue_events_url":"https://api.github.com/repos/vchong/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/vchong/optee_os/events","assignees_url":"https://api.github.com/repos/vchong/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/vchong/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/vchong/optee_os/tags","blobs_url":"https://api.github.com/repos/vchong/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vchong/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vchong/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/vchong/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vchong/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/vchong/optee_os/languages","stargazers_url":"https://api.github.com/repos/vchong/optee_os/stargazers","contributors_url":"https://api.github.com/repos/vchong/optee_os/contributors","subscribers_url":"https://api.github.com/repos/vchong/optee_os/subscribers","subscription_url":"https://api.github.com/repos/vchong/optee_os/subscription","commits_url":"https://api.github.com/repos/vchong/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/vchong/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/vchong/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/vchong/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/vchong/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/vchong/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vchong/optee_os/merges","archive_url":"https://api.github.com/repos/vchong/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vchong/optee_os/downloads","issues_url":"https://api.github.com/repos/vchong/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/vchong/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/vchong/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/vchong/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vchong/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/vchong/optee_os/releases{/id}","deployments_url":"https://api.github.com/repos/vchong/optee_os/deployments","created_at":"2015-03-19T15:38:15Z","updated_at":"2016-01-11T09:37:12Z","pushed_at":"2016-11-07T07:15:51Z","git_url":"git://github.com/vchong/optee_os.git","ssh_url":"git@github.com:vchong/optee_os.git","clone_url":"https://github.com/vchong/optee_os.git","svn_url":"https://github.com/vchong/optee_os","homepage":null,"size":6961,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"68540524672021166c8121b764d69c12e5c4a22d","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":20193261,"name":"optee_os","full_name":"OP-TEE/optee_os","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_os","description":"Trusted side of the TEE","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_os","forks_url":"https://api.github.com/repos/OP-TEE/optee_os/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_os/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_os/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_os/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_os/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_os/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_os/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_os/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_os/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_os/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_os/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_os/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_os/releases{/id}","deployments_url":"https://api.github.com/repos/OP-TEE/optee_os/deployments","created_at":"2014-05-26T17:18:57Z","updated_at":"2016-11-06T15:08:14Z","pushed_at":"2016-11-07T07:17:30Z","git_url":"git://github.com/OP-TEE/optee_os.git","ssh_url":"git@github.com:OP-TEE/optee_os.git","clone_url":"https://github.com/OP-TEE/optee_os.git","svn_url":"https://github.com/OP-TEE/optee_os","homepage":null,"size":11310,"stargazers_count":170,"watchers_count":170,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":169,"mirror_url":null,"open_issues_count":41,"forks":169,"open_issues":41,"watchers":170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1161"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/1161"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/1161"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/1161/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1161/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/1161/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_os/statuses/ef663d792498c40a3926f895981b06c1bab39384"}}}}
{"actor":{"display_login":"jenswi-linaro"}}