{"action":"created","issue":{"url":"https://api.github.com/repos/clojars/clojars-web/issues/492","repository_url":"https://api.github.com/repos/clojars/clojars-web","labels_url":"https://api.github.com/repos/clojars/clojars-web/issues/492/labels{/name}","comments_url":"https://api.github.com/repos/clojars/clojars-web/issues/492/comments","events_url":"https://api.github.com/repos/clojars/clojars-web/issues/492/events","html_url":"https://github.com/clojars/clojars-web/issues/492","id":133105244,"number":492,"title":"Catch exceptions thrown when page number is not an integer","user":{"login":"danielcompton","id":811954,"avatar_url":"https://avatars.githubusercontent.com/u/811954?v=3","gravatar_id":"","url":"https://api.github.com/users/danielcompton","html_url":"https://github.com/danielcompton","followers_url":"https://api.github.com/users/danielcompton/followers","following_url":"https://api.github.com/users/danielcompton/following{/other_user}","gists_url":"https://api.github.com/users/danielcompton/gists{/gist_id}","starred_url":"https://api.github.com/users/danielcompton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielcompton/subscriptions","organizations_url":"https://api.github.com/users/danielcompton/orgs","repos_url":"https://api.github.com/users/danielcompton/repos","events_url":"https://api.github.com/users/danielcompton/events{/privacy}","received_events_url":"https://api.github.com/users/danielcompton/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/clojars/clojars-web/labels/ready","name":"ready","color":"d4c5f9"},{"url":"https://api.github.com/repos/clojars/clojars-web/labels/small","name":"small","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-02-11T22:32:19Z","updated_at":"2016-02-24T18:37:09Z","closed_at":null,"body":"At https://github.com/clojars/clojars-web/blob/33/src/clojars/web.clj#L52, there is no exception handling for when the parameters can't be parsed as an integer. This should be handled and return an error page (500?) to the user.\r\n\r\nA test case is: https://clojars.org/search?q=3&page=%26%2339%3b%2cnetsparker(0x000C93)%2c%26%2339%3b\r\n\r\nor for your local app: [http://localhost:8080/search?q=3&page=%26%2339%3b%2cnetsparker(0x000C93)%2c%26%2339%3b](http://localhost:8080/search?q=3&page=%26%2339%3b%2cnetsparker(0x000C93)%2c%26%2339%3b)"},"comment":{"url":"https://api.github.com/repos/clojars/clojars-web/issues/comments/188398501","html_url":"https://github.com/clojars/clojars-web/issues/492#issuecomment-188398501","issue_url":"https://api.github.com/repos/clojars/clojars-web/issues/492","id":188398501,"user":{"login":"tomjkidd","id":931449,"avatar_url":"https://avatars.githubusercontent.com/u/931449?v=3","gravatar_id":"","url":"https://api.github.com/users/tomjkidd","html_url":"https://github.com/tomjkidd","followers_url":"https://api.github.com/users/tomjkidd/followers","following_url":"https://api.github.com/users/tomjkidd/following{/other_user}","gists_url":"https://api.github.com/users/tomjkidd/gists{/gist_id}","starred_url":"https://api.github.com/users/tomjkidd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomjkidd/subscriptions","organizations_url":"https://api.github.com/users/tomjkidd/orgs","repos_url":"https://api.github.com/users/tomjkidd/repos","events_url":"https://api.github.com/users/tomjkidd/events{/privacy}","received_events_url":"https://api.github.com/users/tomjkidd/received_events","type":"User","site_admin":false},"created_at":"2016-02-24T18:37:09Z","updated_at":"2016-02-24T18:37:09Z","body":"Alright, I made a fork and put in changes that solve the issue for both html and json versions.\r\n\r\nhttps://github.com/tomjkidd/clojars-web\r\n\r\nI am hesitant to make a pull request because the tests don't pass on windows (I don't believe this has anything to do with code I wrote), but could you review the changes just as a sanity check that this is what you want?"}}