{"action":"created","issue":{"url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/329","repository_url":"https://api.github.com/repos/patternfly/angular-patternfly","labels_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/329/labels{/name}","comments_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/329/comments","events_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/329/events","html_url":"https://github.com/patternfly/angular-patternfly/pull/329","id":183032678,"number":329,"title":"pfSelect - destroy the selectpicker when the directive is destroyed","user":{"login":"himdel","id":289743,"avatar_url":"https://avatars.githubusercontent.com/u/289743?v=3","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-14T12:00:19Z","updated_at":"2016-10-14T13:17:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/329","html_url":"https://github.com/patternfly/angular-patternfly/pull/329","diff_url":"https://github.com/patternfly/angular-patternfly/pull/329.diff","patch_url":"https://github.com/patternfly/angular-patternfly/pull/329.patch"},"body":"Since patternfly 3.8, the structure of the HTML generated by the selectpicker js component has changed, and removing the original select element no longer necessarily removes the selectpicker div that's actually visible.\r\n\r\n(Previously, the `select` would just get a class to hide it, and the `div` would appear right after it (as a sibling), whereas now, the new `div` eats up the `select` and moves it inside itself.)\r\n\r\nThis PR makes `pf-select` explicitly destroy the selectpicker when the element with that `pf-select` is going away.\r\n\r\n---\r\n\r\nCode like:\r\n\r\n```\r\n<div ng-if=\"condition\">\r\n  <select pf-select>...</select>\r\n</div>\r\n```\r\n\r\nalways works, but when the if is on the select:\r\n\r\n```\r\n<select pf-select ng-if=\"condition\">...</select>\r\n```\r\n\r\nthen making the condition true and then false causes the selectpicker to stay on the page without this PR."},"comment":{"url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/comments/253796370","html_url":"https://github.com/patternfly/angular-patternfly/pull/329#issuecomment-253796370","issue_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/329","id":253796370,"user":{"login":"dgutride","id":7306953,"avatar_url":"https://avatars.githubusercontent.com/u/7306953?v=3","gravatar_id":"","url":"https://api.github.com/users/dgutride","html_url":"https://github.com/dgutride","followers_url":"https://api.github.com/users/dgutride/followers","following_url":"https://api.github.com/users/dgutride/following{/other_user}","gists_url":"https://api.github.com/users/dgutride/gists{/gist_id}","starred_url":"https://api.github.com/users/dgutride/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgutride/subscriptions","organizations_url":"https://api.github.com/users/dgutride/orgs","repos_url":"https://api.github.com/users/dgutride/repos","events_url":"https://api.github.com/users/dgutride/events{/privacy}","received_events_url":"https://api.github.com/users/dgutride/received_events","type":"User","site_admin":false},"created_at":"2016-10-14T13:17:26Z","updated_at":"2016-10-14T13:17:26Z","body":"Looks good"}}
{"actor":{"display_login":"dgutride"}}