{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/issues/138","repository_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness","labels_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/issues/138/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/issues/138/comments","events_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/issues/138/events","html_url":"https://github.com/jenkinsci/acceptance-test-harness/pull/138","id":161587760,"number":138,"title":"[JENKINS-36045] Rework acquiring Docker CID.","user":{"login":"abayer","id":120218,"avatar_url":"https://avatars.githubusercontent.com/u/120218?v=3","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2016-06-22T03:43:16Z","updated_at":"2016-06-23T10:16:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/pulls/138","html_url":"https://github.com/jenkinsci/acceptance-test-harness/pull/138","diff_url":"https://github.com/jenkinsci/acceptance-test-harness/pull/138.diff","patch_url":"https://github.com/jenkinsci/acceptance-test-harness/pull/138.patch"},"body":"Also effectively rolls back 74ec1821ced1d2ef2b2567e92e699117370ff1bf\r\nas unneeded.\r\n\r\nNOTE: Don't merge this until I've had a chance to run a few more full runs to be sure it's doing the trick - it certainly appears to be fixing things so far, but I've been bit by false positives on this issue before. =) It's still just a band-aid at the core - I can't for the life of me figure out why it's happening in the first place, but this is the best workaround I've got yet.\r\n\r\nEDIT:\r\nI've left the retry in for now, but may end up opting to remove it entirely. The new approach (as described below) reworks how we get the container ID and logs entirely and doesn't seem to run into problems.\r\n\r\n```\r\nMore testing needed to verify this actually does the trick\r\nconsistently, but it does *work* in the non-failure case for\r\nsure. We're now detaching the container, getting the container ID from\r\nthe \"docker run\" output (since that's the output from a detached run)\r\nand running a side process piping \"docker logs --follow (cid)\" to the\r\nlog file. That side process gets automatically killed at the end of\r\nthe test when we kill and rm the container as well.\r\n```\r\n\r\ncc @reviewbybees @olivergondza "},"comment":{"url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/issues/comments/228008215","html_url":"https://github.com/jenkinsci/acceptance-test-harness/pull/138#issuecomment-228008215","issue_url":"https://api.github.com/repos/jenkinsci/acceptance-test-harness/issues/138","id":228008215,"user":{"login":"rsandell","id":300688,"avatar_url":"https://avatars.githubusercontent.com/u/300688?v=3","gravatar_id":"","url":"https://api.github.com/users/rsandell","html_url":"https://github.com/rsandell","followers_url":"https://api.github.com/users/rsandell/followers","following_url":"https://api.github.com/users/rsandell/following{/other_user}","gists_url":"https://api.github.com/users/rsandell/gists{/gist_id}","starred_url":"https://api.github.com/users/rsandell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsandell/subscriptions","organizations_url":"https://api.github.com/users/rsandell/orgs","repos_url":"https://api.github.com/users/rsandell/repos","events_url":"https://api.github.com/users/rsandell/events{/privacy}","received_events_url":"https://api.github.com/users/rsandell/received_events","type":"User","site_admin":false},"created_at":"2016-06-23T10:16:25Z","updated_at":"2016-06-23T10:16:25Z","body":":bee: depending on @jtnord 's final say."}}
{"actor":{"display_login":"rsandell"}}