{"action":"created","issue":{"url":"https://api.github.com/repos/uProxy/ufo-management-server-flask/issues/10","labels_url":"https://api.github.com/repos/uProxy/ufo-management-server-flask/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/uProxy/ufo-management-server-flask/issues/10/comments","events_url":"https://api.github.com/repos/uProxy/ufo-management-server-flask/issues/10/events","html_url":"https://github.com/uProxy/ufo-management-server-flask/pull/10","id":126781368,"number":10,"title":"Start migrating the database tests to the flask version.","user":{"login":"blueandgold","id":6977544,"avatar_url":"https://avatars.githubusercontent.com/u/6977544?v=3","gravatar_id":"","url":"https://api.github.com/users/blueandgold","html_url":"https://github.com/blueandgold","followers_url":"https://api.github.com/users/blueandgold/followers","following_url":"https://api.github.com/users/blueandgold/following{/other_user}","gists_url":"https://api.github.com/users/blueandgold/gists{/gist_id}","starred_url":"https://api.github.com/users/blueandgold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueandgold/subscriptions","organizations_url":"https://api.github.com/users/blueandgold/orgs","repos_url":"https://api.github.com/users/blueandgold/repos","events_url":"https://api.github.com/users/blueandgold/events{/privacy}","received_events_url":"https://api.github.com/users/blueandgold/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"xwsxethan","id":6269245,"avatar_url":"https://avatars.githubusercontent.com/u/6269245?v=3","gravatar_id":"","url":"https://api.github.com/users/xwsxethan","html_url":"https://github.com/xwsxethan","followers_url":"https://api.github.com/users/xwsxethan/followers","following_url":"https://api.github.com/users/xwsxethan/following{/other_user}","gists_url":"https://api.github.com/users/xwsxethan/gists{/gist_id}","starred_url":"https://api.github.com/users/xwsxethan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwsxethan/subscriptions","organizations_url":"https://api.github.com/users/xwsxethan/orgs","repos_url":"https://api.github.com/users/xwsxethan/repos","events_url":"https://api.github.com/users/xwsxethan/events{/privacy}","received_events_url":"https://api.github.com/users/xwsxethan/received_events","type":"User","site_admin":false},"milestone":null,"comments":4,"created_at":"2016-01-15T00:35:14Z","updated_at":"2016-01-15T18:31:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uProxy/ufo-management-server-flask/pulls/10","html_url":"https://github.com/uProxy/ufo-management-server-flask/pull/10","diff_url":"https://github.com/uProxy/ufo-management-server-flask/pull/10.diff","patch_url":"https://github.com/uProxy/ufo-management-server-flask/pull/10.patch"},"body":"Some small notes:\r\n- @patch() seems to need a package reference, which wasn't necessary before.\r\n```python\r\n@patch('ufo.models.RSA._RSAobj.exportKey')\r\n```\r\n- add back base64 encoding, which existed previously\r\n- changed a couple of relative importing in the test seems not needed\r\n- this is mainly for me to get a feel of the flask framework and the test setup\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/uproxy/ufo-management-server-flask/10)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/uProxy/ufo-management-server-flask/issues/comments/172044920","html_url":"https://github.com/uProxy/ufo-management-server-flask/pull/10#issuecomment-172044920","issue_url":"https://api.github.com/repos/uProxy/ufo-management-server-flask/issues/10","id":172044920,"user":{"login":"blueandgold","id":6977544,"avatar_url":"https://avatars.githubusercontent.com/u/6977544?v=3","gravatar_id":"","url":"https://api.github.com/users/blueandgold","html_url":"https://github.com/blueandgold","followers_url":"https://api.github.com/users/blueandgold/followers","following_url":"https://api.github.com/users/blueandgold/following{/other_user}","gists_url":"https://api.github.com/users/blueandgold/gists{/gist_id}","starred_url":"https://api.github.com/users/blueandgold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueandgold/subscriptions","organizations_url":"https://api.github.com/users/blueandgold/orgs","repos_url":"https://api.github.com/users/blueandgold/repos","events_url":"https://api.github.com/users/blueandgold/events{/privacy}","received_events_url":"https://api.github.com/users/blueandgold/received_events","type":"User","site_admin":false},"created_at":"2016-01-15T18:31:21Z","updated_at":"2016-01-15T18:31:21Z","body":"Thanks for the review.  PTAL.  I posed a couple of questions back for discussion.  But definitely can be happy to go the other way.\n\n---\n\nReview status: 1 of 3 files reviewed at latest revision, 6 unresolved discussions.\n\n---\n\n*[ufo/models.py, line 70 \\[r1\\]](https://reviewable.io:443/reviews/uproxy/ufo-management-server-flask/10#-K81ztrwHRC1nUGDT7-S:-K85SCpQP2cUYT8GKDFH:-482097652) ([raw file](https://github.com/uproxy/ufo-management-server-flask/blob/c960eb66154812e8127c9ebbd7455ee2150a2baf/ufo/models.py#L70)):*\nThe idea was to save the encoding step later on during request time, which seems to happen a lot more often.  Thoughts?  It's pretty easy to do either way, but want to double-check here.\n\n---\n\n*[ufo/models_test.py, line 16 \\[r1\\]](https://reviewable.io:443/reviews/uproxy/ufo-management-server-flask/10#-K84tnda92h2WmIyEi-M:-K85R_k1FoBs3S8Ixcki:-499146009) ([raw file](https://github.com/uproxy/ufo-management-server-flask/blob/c960eb66154812e8127c9ebbd7455ee2150a2baf/ufo/models_test.py#L16)):*\nDone.\n\n---\n\n*[ufo/models_test.py, line 27 \\[r1\\]](https://reviewable.io:443/reviews/uproxy/ufo-management-server-flask/10#-K82-f6ixgPUtdwvpUx9:-K85UMfysVv68Ds-QKgk:2016723977) ([raw file](https://github.com/uproxy/ufo-management-server-flask/blob/c960eb66154812e8127c9ebbd7455ee2150a2baf/ufo/models_test.py#L27)):*\nDone, great idea.\n\n---\n\n*[ufo/models_test.py, line 33 \\[r1\\]](https://reviewable.io:443/reviews/uproxy/ufo-management-server-flask/10#-K84uBXdDZlRNHWry1GN:-K85UWAMTz-X-mtwVN8j:-961823460) ([raw file](https://github.com/uproxy/ufo-management-server-flask/blob/c960eb66154812e8127c9ebbd7455ee2150a2baf/ufo/models_test.py#L33)):*\nDone.  I moved the config stuff to a separate method, which you should be able to call in the handler tests.\n\n---\n\n*[ufo/models_test.py, line 36 \\[r1\\]](https://reviewable.io:443/reviews/uproxy/ufo-management-server-flask/10#-K82-aBwJBkdas88fzK3:-K85RfBFQcAYX_ZpoFfz:-499146009) ([raw file](https://github.com/uproxy/ufo-management-server-flask/blob/c960eb66154812e8127c9ebbd7455ee2150a2baf/ufo/models_test.py#L36)):*\nDone.\n\n---\n\n*[ufo/models_test.py, line 41 \\[r1\\]](https://reviewable.io:443/reviews/uproxy/ufo-management-server-flask/10#-K82-qp6rLe-AxgvIqLk:-K85WyzWwElJB3JsAWqz:1977180856) ([raw file](https://github.com/uproxy/ufo-management-server-flask/blob/c960eb66154812e8127c9ebbd7455ee2150a2baf/ufo/models_test.py#L41)):*\nCorrect, that we are testing our implementation only.  The assumption is that RSA library is working correctly and has been tested on their side.  i.e. it seems like of redundant of doing a functional testing such as sign a message with a key and then decode it with the other key.  We can do it this way, but we are just testing how that we are the library in the way that we desire, e.g. 2048 bit.\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/uproxy/ufo-management-server-flask/10#-:-K85Xi8JD0ajaJnMo8CC:1187603920)*\n<!-- Sent from Reviewable.io -->\n"}}