{"action":"created","issue":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/279","repository_url":"https://api.github.com/repos/xamarin/Xamarin.Forms","labels_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/279/labels{/name}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/279/comments","events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/279/events","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/279","id":169407081,"number":279,"title":"Fix for BindingExpression memory leak","user":{"login":"jonathanpeppers","id":840039,"avatar_url":"https://avatars.githubusercontent.com/u/840039?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanpeppers","html_url":"https://github.com/jonathanpeppers","followers_url":"https://api.github.com/users/jonathanpeppers/followers","following_url":"https://api.github.com/users/jonathanpeppers/following{/other_user}","gists_url":"https://api.github.com/users/jonathanpeppers/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanpeppers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanpeppers/subscriptions","organizations_url":"https://api.github.com/users/jonathanpeppers/orgs","repos_url":"https://api.github.com/users/jonathanpeppers/repos","events_url":"https://api.github.com/users/jonathanpeppers/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanpeppers/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2016-08-04T15:45:53Z","updated_at":"2016-10-20T20:07:26Z","closed_at":"2016-08-16T18:19:21Z","pull_request":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/279","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/279","diff_url":"https://github.com/xamarin/Xamarin.Forms/pull/279.diff","patch_url":"https://github.com/xamarin/Xamarin.Forms/pull/279.patch"},"body":"### Description of Change ###\r\n\r\nIn our application we discovered a memory leak in the following situation:\r\n* Have a long-lived ViewModel object (maybe lives the lifetime of your app)\r\n* Bind to it in a View\r\n* The View goes away, and get's GC'd\r\n* A `BindingExpression` object and its children remain in memory as long as the long-lived ViewModel\r\n\r\n### Bugs Fixed ###\r\n\r\n- Not sure if there is an issue out for this, see my unit test that reproduces the issue\r\n\r\n### API Changes ###\r\n\r\nNone\r\n\r\n### Behavioral Changes ###\r\n\r\n`BindingExpression` will not remain in memory when the `View` is GC'd.\r\n\r\n### PR Checklist ###\r\n\r\n- [x] Has tests (if omitted, state reason in description)\r\n- [x] Rebased on top of master at time of PR\r\n- [x] Changes adhere to coding standard\r\n- [x] Consolidate commits as makes sense\r\n"},"comment":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/comments/255213497","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/279#issuecomment-255213497","issue_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/279","id":255213497,"user":{"login":"jamesl77","id":22602023,"avatar_url":"https://avatars.githubusercontent.com/u/22602023?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesl77","html_url":"https://github.com/jamesl77","followers_url":"https://api.github.com/users/jamesl77/followers","following_url":"https://api.github.com/users/jamesl77/following{/other_user}","gists_url":"https://api.github.com/users/jamesl77/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesl77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesl77/subscriptions","organizations_url":"https://api.github.com/users/jamesl77/orgs","repos_url":"https://api.github.com/users/jamesl77/repos","events_url":"https://api.github.com/users/jamesl77/events{/privacy}","received_events_url":"https://api.github.com/users/jamesl77/received_events","type":"User","site_admin":false},"created_at":"2016-10-20T20:07:26Z","updated_at":"2016-10-20T20:07:26Z","body":"Thank you. I'm also a lot of bindings and other stuff. \r\n\r\nI have an issue with `Messenger`, I made a question on SO: http://stackoverflow.com/questions/40163598/does-messenger-really-requires-calling-unscribe\r\n\r\n"}}
{"actor":{"display_login":"jamesl77"}}