{"action":"created","issue":{"url":"https://api.github.com/repos/atom/tree-view/issues/690","repository_url":"https://api.github.com/repos/atom/tree-view","labels_url":"https://api.github.com/repos/atom/tree-view/issues/690/labels{/name}","comments_url":"https://api.github.com/repos/atom/tree-view/issues/690/comments","events_url":"https://api.github.com/repos/atom/tree-view/issues/690/events","html_url":"https://github.com/atom/tree-view/issues/690","id":125098419,"number":690,"title":"Inconsistencies when opening Settings in various window states","user":{"login":"jsejcksn","id":868251,"avatar_url":"https://avatars.githubusercontent.com/u/868251?v=3","gravatar_id":"","url":"https://api.github.com/users/jsejcksn","html_url":"https://github.com/jsejcksn","followers_url":"https://api.github.com/users/jsejcksn/followers","following_url":"https://api.github.com/users/jsejcksn/following{/other_user}","gists_url":"https://api.github.com/users/jsejcksn/gists{/gist_id}","starred_url":"https://api.github.com/users/jsejcksn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsejcksn/subscriptions","organizations_url":"https://api.github.com/users/jsejcksn/orgs","repos_url":"https://api.github.com/users/jsejcksn/repos","events_url":"https://api.github.com/users/jsejcksn/events{/privacy}","received_events_url":"https://api.github.com/users/jsejcksn/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/atom/tree-view/labels/needs-reproduction","name":"needs-reproduction","color":"009800"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-01-06T02:37:59Z","updated_at":"2016-10-12T22:00:18Z","closed_at":"2016-10-09T17:17:10Z","body":"*(I'm using Atom 1.3.2 on OS X 10.11.2)*\r\n\r\nWhen I attempt to open Settings by pressing <kbd>⌘</kbd>+<kbd>,</kbd> (OS X standard shortcut):\r\n\r\n1. in a focused window containing only a new blank document or no document, it opens in a new tab in that window and does not change the toggled state of the tree view or the location of the tree view (toggling tree view has no effect when there is no location set). **:thumbsup: Good behavior**\r\n\r\n  ![existing-window](https://cloud.githubusercontent.com/assets/868251/12132064/d190ccbc-b3dd-11e5-8748-7574492565e9.png)\r\n\r\n2. in a focused window with a project, it opens in a new tab in that window and does not change the toggled state of the tree view or the location of the tree view. **:thumbsup: Good behavior**\r\n\r\n  ![project-window](https://cloud.githubusercontent.com/assets/868251/12132554/54e6984a-b3e2-11e5-9914-e3c20ffd4f4e.png)\r\n\r\n3. without a window already open, it opens a new window and toggles the tree view to visible and changes the location of the tree view to `atom://config`. **:thumbsdown: Bad behavior**\r\n\r\n  ![new-window](https://cloud.githubusercontent.com/assets/868251/12132084/0015beee-b3de-11e5-9476-b85d702b1f2c.png)\r\n\r\n4. with no window focused (but all open windows are minimized), it does nothing. **:thumbsdown: Bad behavior**\r\n  *(but here's a little something because nothing looks pretty boring)*\r\n\r\n  ![lol-1](https://cloud.githubusercontent.com/assets/868251/12132579/b77f0302-b3e2-11e5-86a5-b56d337e8990.gif)\r\n\r\n---\r\n\r\nI noticed that numbers 3 and 4 flashed (briefly highlighted) different menu bar items. 3 flashed `Packages` and 4 flashed `Atom`. This struck me as **very strange** that an app would have different menu items associated with the same shortcut. So I inspected the two menus, finding that (like all other OS X apps), <kbd>⌘</kbd>+<kbd>,</kbd> is assigned to the app's `Preferences` (`Atom > Preferences`), **but also that** it is assigned to `Packages > Settings View > Open`. *(What is this madness?)*\r\n\r\nI did more testing.\r\n\r\nHere are the results for using `Atom > Preferences` on 1–4:\r\n\r\n1a. Same result as 3. :thumbsdown:\r\n2a. Same result as 2. :thumbsup:\r\n3a. Same result as 3.:thumbsdown:\r\n4a. Same result as 3.:thumbsdown:\r\n\r\nHere are the results for using `Packages > Settings View > Open` on 1–4:\r\n\r\n1b. Same result as 1. :thumbsup:\r\n2b. Same result as 2. :thumbsup:\r\n3b. Not possible (Packages menu is not present) :thumbsdown:\r\n4b. Same result as 4. :thumbsdown:\r\n\r\n---\r\n\r\nIn summary, I think it'd be most appropriate if <kbd>⌘</kbd>+<kbd>,</kbd> were mapped only to `Atom > Preferences` (for continuity with other OS X apps) and that any time it were pressed, it would always open a new tab (if required, in a new window), not modify the toggle state of the tree view, and not change the location of the tree view."},"comment":{"url":"https://api.github.com/repos/atom/tree-view/issues/comments/253352498","html_url":"https://github.com/atom/tree-view/issues/690#issuecomment-253352498","issue_url":"https://api.github.com/repos/atom/tree-view/issues/690","id":253352498,"user":{"login":"jsejcksn","id":868251,"avatar_url":"https://avatars.githubusercontent.com/u/868251?v=3","gravatar_id":"","url":"https://api.github.com/users/jsejcksn","html_url":"https://github.com/jsejcksn","followers_url":"https://api.github.com/users/jsejcksn/followers","following_url":"https://api.github.com/users/jsejcksn/following{/other_user}","gists_url":"https://api.github.com/users/jsejcksn/gists{/gist_id}","starred_url":"https://api.github.com/users/jsejcksn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsejcksn/subscriptions","organizations_url":"https://api.github.com/users/jsejcksn/orgs","repos_url":"https://api.github.com/users/jsejcksn/repos","events_url":"https://api.github.com/users/jsejcksn/events{/privacy}","received_events_url":"https://api.github.com/users/jsejcksn/received_events","type":"User","site_admin":false},"created_at":"2016-10-12T22:00:18Z","updated_at":"2016-10-12T22:00:18Z","body":"@Ben3eeE No. 3 is still an issue in 1.10.2 when getting to settings by using Atom > Preferences.\r\n\r\n/cc @lee-dohm (I opened that issue at atom/settings-view#868.)"}}
{"actor":{"display_login":"jsejcksn"}}