{"action":"closed","issue":{"url":"https://api.github.com/repos/coreos/go-oidc/issues/57","repository_url":"https://api.github.com/repos/coreos/go-oidc","labels_url":"https://api.github.com/repos/coreos/go-oidc/issues/57/labels{/name}","comments_url":"https://api.github.com/repos/coreos/go-oidc/issues/57/comments","events_url":"https://api.github.com/repos/coreos/go-oidc/issues/57/events","html_url":"https://github.com/coreos/go-oidc/issues/57","id":136855275,"number":57,"title":"go-oidc/http package pulls in test-only net/http/httptest","user":{"login":"timstclair","id":3272040,"avatar_url":"https://avatars.githubusercontent.com/u/3272040?v=3","gravatar_id":"","url":"https://api.github.com/users/timstclair","html_url":"https://github.com/timstclair","followers_url":"https://api.github.com/users/timstclair/followers","following_url":"https://api.github.com/users/timstclair/following{/other_user}","gists_url":"https://api.github.com/users/timstclair/gists{/gist_id}","starred_url":"https://api.github.com/users/timstclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstclair/subscriptions","organizations_url":"https://api.github.com/users/timstclair/orgs","repos_url":"https://api.github.com/users/timstclair/repos","events_url":"https://api.github.com/users/timstclair/events{/privacy}","received_events_url":"https://api.github.com/users/timstclair/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"ericchiang","id":2342749,"avatar_url":"https://avatars.githubusercontent.com/u/2342749?v=3","gravatar_id":"","url":"https://api.github.com/users/ericchiang","html_url":"https://github.com/ericchiang","followers_url":"https://api.github.com/users/ericchiang/followers","following_url":"https://api.github.com/users/ericchiang/following{/other_user}","gists_url":"https://api.github.com/users/ericchiang/gists{/gist_id}","starred_url":"https://api.github.com/users/ericchiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericchiang/subscriptions","organizations_url":"https://api.github.com/users/ericchiang/orgs","repos_url":"https://api.github.com/users/ericchiang/repos","events_url":"https://api.github.com/users/ericchiang/events{/privacy}","received_events_url":"https://api.github.com/users/ericchiang/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-02-27T00:45:56Z","updated_at":"2016-03-01T19:03:45Z","closed_at":"2016-03-01T19:03:45Z","body":"The go `net/http/httptest` package should only be used in test builds. In particular, that package adds the `httptest.serve` flag which leaks into binaries depending on go-oidc (e.g. https://github.com/kubernetes/kubernetes/issues/21114)\r\n\r\nFrom what I can tell, the [`HandlerClient`](https://github.com/coreos/go-oidc/blob/46fc3c20dcad27d27596c8832b354621bdd8b88f/http/client.go#L13) that uses `httptest` is only used in testing, so I suggest moving it to a test-only package (such as `go-oidc/http/testing` or `go-oidc/http/httptest`)"}}