{"action":"created","comment":{"url":"https://api.github.com/repos/apache/drill/pulls/comments/63430234","id":63430234,"diff_hunk":"@@ -1221,6 +1223,12 @@ public void interrupted(final InterruptedException e) {\n      *   to the user\n      */\n     public void moveToState(final QueryState newState, final Exception ex) {\n+      // if the current thread is the foreman thread, throw an exception\n+      // otherwise the foreman will be blocked forever on acceptExternalEvents\n+      if (myThreadRef == Thread.currentThread()) {","path":"exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java","position":37,"original_position":37,"commit_id":"8608613e8e1f3e847ffde5b233442a0e78f1d1cc","original_commit_id":"8608613e8e1f3e847ffde5b233442a0e78f1d1cc","user":{"login":"adeneche","id":8422943,"avatar_url":"https://avatars.githubusercontent.com/u/8422943?v=3","gravatar_id":"","url":"https://api.github.com/users/adeneche","html_url":"https://github.com/adeneche","followers_url":"https://api.github.com/users/adeneche/followers","following_url":"https://api.github.com/users/adeneche/following{/other_user}","gists_url":"https://api.github.com/users/adeneche/gists{/gist_id}","starred_url":"https://api.github.com/users/adeneche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adeneche/subscriptions","organizations_url":"https://api.github.com/users/adeneche/orgs","repos_url":"https://api.github.com/users/adeneche/repos","events_url":"https://api.github.com/users/adeneche/events{/privacy}","received_events_url":"https://api.github.com/users/adeneche/received_events","type":"User","site_admin":false},"body":"This won't work when submitting remote fragments as the moveToState method can be called either by the foreman thread or by an rpc thread.\r\n\r\nAnyway, I'm working on a better fix that would remove the latch completely.","created_at":"2016-05-16T21:35:32Z","updated_at":"2016-05-16T21:35:32Z","html_url":"https://github.com/apache/drill/pull/503#discussion_r63430234","pull_request_url":"https://api.github.com/repos/apache/drill/pulls/503","_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/comments/63430234"},"html":{"href":"https://github.com/apache/drill/pull/503#discussion_r63430234"},"pull_request":{"href":"https://api.github.com/repos/apache/drill/pulls/503"}}},"pull_request":{"url":"https://api.github.com/repos/apache/drill/pulls/503","id":70125622,"html_url":"https://github.com/apache/drill/pull/503","diff_url":"https://github.com/apache/drill/pull/503.diff","patch_url":"https://github.com/apache/drill/pull/503.patch","issue_url":"https://api.github.com/repos/apache/drill/issues/503","number":503,"state":"open","locked":false,"title":"DRILL-4676: Foreman.moveToState can block forever if called by the fo…","user":{"login":"adeneche","id":8422943,"avatar_url":"https://avatars.githubusercontent.com/u/8422943?v=3","gravatar_id":"","url":"https://api.github.com/users/adeneche","html_url":"https://github.com/adeneche","followers_url":"https://api.github.com/users/adeneche/followers","following_url":"https://api.github.com/users/adeneche/following{/other_user}","gists_url":"https://api.github.com/users/adeneche/gists{/gist_id}","starred_url":"https://api.github.com/users/adeneche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adeneche/subscriptions","organizations_url":"https://api.github.com/users/adeneche/orgs","repos_url":"https://api.github.com/users/adeneche/repos","events_url":"https://api.github.com/users/adeneche/events{/privacy}","received_events_url":"https://api.github.com/users/adeneche/received_events","type":"User","site_admin":false},"body":"…reman thread while the query is still being setup","created_at":"2016-05-15T16:21:18Z","updated_at":"2016-05-16T21:35:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97c783b1c33580290655b9b222eb8515461bfd0f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/drill/pulls/503/commits","review_comments_url":"https://api.github.com/repos/apache/drill/pulls/503/comments","review_comment_url":"https://api.github.com/repos/apache/drill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/drill/issues/503/comments","statuses_url":"https://api.github.com/repos/apache/drill/statuses/8608613e8e1f3e847ffde5b233442a0e78f1d1cc","head":{"label":"adeneche:DRILL-4676","ref":"DRILL-4676","sha":"8608613e8e1f3e847ffde5b233442a0e78f1d1cc","user":{"login":"adeneche","id":8422943,"avatar_url":"https://avatars.githubusercontent.com/u/8422943?v=3","gravatar_id":"","url":"https://api.github.com/users/adeneche","html_url":"https://github.com/adeneche","followers_url":"https://api.github.com/users/adeneche/followers","following_url":"https://api.github.com/users/adeneche/following{/other_user}","gists_url":"https://api.github.com/users/adeneche/gists{/gist_id}","starred_url":"https://api.github.com/users/adeneche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adeneche/subscriptions","organizations_url":"https://api.github.com/users/adeneche/orgs","repos_url":"https://api.github.com/users/adeneche/repos","events_url":"https://api.github.com/users/adeneche/events{/privacy}","received_events_url":"https://api.github.com/users/adeneche/received_events","type":"User","site_admin":false},"repo":{"id":25532970,"name":"incubator-drill","full_name":"adeneche/incubator-drill","owner":{"login":"adeneche","id":8422943,"avatar_url":"https://avatars.githubusercontent.com/u/8422943?v=3","gravatar_id":"","url":"https://api.github.com/users/adeneche","html_url":"https://github.com/adeneche","followers_url":"https://api.github.com/users/adeneche/followers","following_url":"https://api.github.com/users/adeneche/following{/other_user}","gists_url":"https://api.github.com/users/adeneche/gists{/gist_id}","starred_url":"https://api.github.com/users/adeneche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adeneche/subscriptions","organizations_url":"https://api.github.com/users/adeneche/orgs","repos_url":"https://api.github.com/users/adeneche/repos","events_url":"https://api.github.com/users/adeneche/events{/privacy}","received_events_url":"https://api.github.com/users/adeneche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adeneche/incubator-drill","description":"Mirror of Apache Drill (Incubating)","fork":true,"url":"https://api.github.com/repos/adeneche/incubator-drill","forks_url":"https://api.github.com/repos/adeneche/incubator-drill/forks","keys_url":"https://api.github.com/repos/adeneche/incubator-drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adeneche/incubator-drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adeneche/incubator-drill/teams","hooks_url":"https://api.github.com/repos/adeneche/incubator-drill/hooks","issue_events_url":"https://api.github.com/repos/adeneche/incubator-drill/issues/events{/number}","events_url":"https://api.github.com/repos/adeneche/incubator-drill/events","assignees_url":"https://api.github.com/repos/adeneche/incubator-drill/assignees{/user}","branches_url":"https://api.github.com/repos/adeneche/incubator-drill/branches{/branch}","tags_url":"https://api.github.com/repos/adeneche/incubator-drill/tags","blobs_url":"https://api.github.com/repos/adeneche/incubator-drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adeneche/incubator-drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adeneche/incubator-drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/adeneche/incubator-drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adeneche/incubator-drill/statuses/{sha}","languages_url":"https://api.github.com/repos/adeneche/incubator-drill/languages","stargazers_url":"https://api.github.com/repos/adeneche/incubator-drill/stargazers","contributors_url":"https://api.github.com/repos/adeneche/incubator-drill/contributors","subscribers_url":"https://api.github.com/repos/adeneche/incubator-drill/subscribers","subscription_url":"https://api.github.com/repos/adeneche/incubator-drill/subscription","commits_url":"https://api.github.com/repos/adeneche/incubator-drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/adeneche/incubator-drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/adeneche/incubator-drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/adeneche/incubator-drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/adeneche/incubator-drill/contents/{+path}","compare_url":"https://api.github.com/repos/adeneche/incubator-drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adeneche/incubator-drill/merges","archive_url":"https://api.github.com/repos/adeneche/incubator-drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adeneche/incubator-drill/downloads","issues_url":"https://api.github.com/repos/adeneche/incubator-drill/issues{/number}","pulls_url":"https://api.github.com/repos/adeneche/incubator-drill/pulls{/number}","milestones_url":"https://api.github.com/repos/adeneche/incubator-drill/milestones{/number}","notifications_url":"https://api.github.com/repos/adeneche/incubator-drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adeneche/incubator-drill/labels{/name}","releases_url":"https://api.github.com/repos/adeneche/incubator-drill/releases{/id}","deployments_url":"https://api.github.com/repos/adeneche/incubator-drill/deployments","created_at":"2014-10-21T16:25:02Z","updated_at":"2016-02-03T23:43:01Z","pushed_at":"2016-05-16T20:19:26Z","git_url":"git://github.com/adeneche/incubator-drill.git","ssh_url":"git@github.com:adeneche/incubator-drill.git","clone_url":"https://github.com/adeneche/incubator-drill.git","svn_url":"https://github.com/adeneche/incubator-drill","homepage":null,"size":34084,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"09b262776e965ea17a6a863801f7e1ee3e5b3d5a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":5683653,"name":"drill","full_name":"apache/drill","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/drill","description":"Mirror of Apache Drill","fork":false,"url":"https://api.github.com/repos/apache/drill","forks_url":"https://api.github.com/repos/apache/drill/forks","keys_url":"https://api.github.com/repos/apache/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/drill/teams","hooks_url":"https://api.github.com/repos/apache/drill/hooks","issue_events_url":"https://api.github.com/repos/apache/drill/issues/events{/number}","events_url":"https://api.github.com/repos/apache/drill/events","assignees_url":"https://api.github.com/repos/apache/drill/assignees{/user}","branches_url":"https://api.github.com/repos/apache/drill/branches{/branch}","tags_url":"https://api.github.com/repos/apache/drill/tags","blobs_url":"https://api.github.com/repos/apache/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/drill/languages","stargazers_url":"https://api.github.com/repos/apache/drill/stargazers","contributors_url":"https://api.github.com/repos/apache/drill/contributors","subscribers_url":"https://api.github.com/repos/apache/drill/subscribers","subscription_url":"https://api.github.com/repos/apache/drill/subscription","commits_url":"https://api.github.com/repos/apache/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/drill/contents/{+path}","compare_url":"https://api.github.com/repos/apache/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/drill/merges","archive_url":"https://api.github.com/repos/apache/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/drill/downloads","issues_url":"https://api.github.com/repos/apache/drill/issues{/number}","pulls_url":"https://api.github.com/repos/apache/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/drill/labels{/name}","releases_url":"https://api.github.com/repos/apache/drill/releases{/id}","deployments_url":"https://api.github.com/repos/apache/drill/deployments","created_at":"2012-09-05T07:00:26Z","updated_at":"2016-05-15T21:03:57Z","pushed_at":"2016-05-15T16:21:18Z","git_url":"git://github.com/apache/drill.git","ssh_url":"git@github.com:apache/drill.git","clone_url":"https://github.com/apache/drill.git","svn_url":"https://github.com/apache/drill","homepage":"","size":48766,"stargazers_count":617,"watchers_count":617,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":432,"mirror_url":"git://git.apache.org/drill.git","open_issues_count":112,"forks":432,"open_issues":112,"watchers":617,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/503"},"html":{"href":"https://github.com/apache/drill/pull/503"},"issue":{"href":"https://api.github.com/repos/apache/drill/issues/503"},"comments":{"href":"https://api.github.com/repos/apache/drill/issues/503/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/drill/pulls/503/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/drill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/drill/pulls/503/commits"},"statuses":{"href":"https://api.github.com/repos/apache/drill/statuses/8608613e8e1f3e847ffde5b233442a0e78f1d1cc"}}}}