{"action":"created","issue":{"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/951","repository_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map","labels_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/951/labels{/name}","comments_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/951/comments","events_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/951/events","html_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/951","id":172606076,"number":951,"title":"Fix: SS db initial list build delay","user":{"login":"rbryson74","id":11877300,"avatar_url":"https://avatars.githubusercontent.com/u/11877300?v=3","gravatar_id":"","url":"https://api.github.com/users/rbryson74","html_url":"https://github.com/rbryson74","followers_url":"https://api.github.com/users/rbryson74/followers","following_url":"https://api.github.com/users/rbryson74/following{/other_user}","gists_url":"https://api.github.com/users/rbryson74/gists{/gist_id}","starred_url":"https://api.github.com/users/rbryson74/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbryson74/subscriptions","organizations_url":"https://api.github.com/users/rbryson74/orgs","repos_url":"https://api.github.com/users/rbryson74/repos","events_url":"https://api.github.com/users/rbryson74/events{/privacy}","received_events_url":"https://api.github.com/users/rbryson74/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-23T03:43:45Z","updated_at":"2016-08-26T22:24:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/pulls/951","html_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/951","diff_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/951.diff","patch_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/951.patch"},"body":"## Description\r\nthe PR#901 refactor of the get_spawnpoints_in_hex function included a\r\ndouble nested loop over the whole db. This reverts to the method used\r\npreviously.\r\n\r\n## Motivation and Context\r\nThe refactored function can take anywhere from 1 minute to reports of 5+ minutes to build the initial list. \r\n\r\n\r\n## How Has This Been Tested?\r\ntested on my system \r\n\r\nDoes not appear to affect any other code. \r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n\r\nthe PR#901 refactor of the get_spawnpoints_in_hex function included a\r\ndouble nested loop over the whole db. This reverts to the method used\r\npreviously."},"comment":{"url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/comments/242866523","html_url":"https://github.com/PokemonGoMap/PokemonGo-Map/pull/951#issuecomment-242866523","issue_url":"https://api.github.com/repos/PokemonGoMap/PokemonGo-Map/issues/951","id":242866523,"user":{"login":"rbryson74","id":11877300,"avatar_url":"https://avatars.githubusercontent.com/u/11877300?v=3","gravatar_id":"","url":"https://api.github.com/users/rbryson74","html_url":"https://github.com/rbryson74","followers_url":"https://api.github.com/users/rbryson74/followers","following_url":"https://api.github.com/users/rbryson74/following{/other_user}","gists_url":"https://api.github.com/users/rbryson74/gists{/gist_id}","starred_url":"https://api.github.com/users/rbryson74/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbryson74/subscriptions","organizations_url":"https://api.github.com/users/rbryson74/orgs","repos_url":"https://api.github.com/users/rbryson74/repos","events_url":"https://api.github.com/users/rbryson74/events{/privacy}","received_events_url":"https://api.github.com/users/rbryson74/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T22:24:57Z","updated_at":"2016-08-26T22:24:57Z","body":"This method can be redone quite easily to use geopy instead of math. But there will be users that will prefer to use the db over a file for any of a number of reasons. I agree that the loop as created in 901 is `len(hexLocations) *( len(spawnPoints)-spawnsfound)` but that still results in the lists being checked repeatedly when 1 pass is sufficient. And by that what I mean is that for spawnpoint scanning based on distance from a central point, strict adherence to the shape of the regular scanning hex is not necessary. A simple circle will work. The only reason to keep it as a hex is when using -ss in beehive with multiple workers to prevent overlap. But that will not really be needed once the clustering and account idling can be implemented. "}}
{"actor":{"display_login":"rbryson74"}}