{"action":"created","issue":{"url":"https://api.github.com/repos/PyMySQL/mysqlclient-python/issues/106","repository_url":"https://api.github.com/repos/PyMySQL/mysqlclient-python","labels_url":"https://api.github.com/repos/PyMySQL/mysqlclient-python/issues/106/labels{/name}","comments_url":"https://api.github.com/repos/PyMySQL/mysqlclient-python/issues/106/comments","events_url":"https://api.github.com/repos/PyMySQL/mysqlclient-python/issues/106/events","html_url":"https://github.com/PyMySQL/mysqlclient-python/pull/106","id":167931152,"number":106,"title":"Use _binary prefix for bytes/bytearray parameters","user":{"login":"vtermanis","id":6112689,"avatar_url":"https://avatars.githubusercontent.com/u/6112689?v=3","gravatar_id":"","url":"https://api.github.com/users/vtermanis","html_url":"https://github.com/vtermanis","followers_url":"https://api.github.com/users/vtermanis/followers","following_url":"https://api.github.com/users/vtermanis/following{/other_user}","gists_url":"https://api.github.com/users/vtermanis/gists{/gist_id}","starred_url":"https://api.github.com/users/vtermanis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtermanis/subscriptions","organizations_url":"https://api.github.com/users/vtermanis/orgs","repos_url":"https://api.github.com/users/vtermanis/repos","events_url":"https://api.github.com/users/vtermanis/events{/privacy}","received_events_url":"https://api.github.com/users/vtermanis/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2016-07-27T19:05:32Z","updated_at":"2016-09-30T11:37:44Z","closed_at":"2016-09-11T10:55:34Z","pull_request":{"url":"https://api.github.com/repos/PyMySQL/mysqlclient-python/pulls/106","html_url":"https://github.com/PyMySQL/mysqlclient-python/pull/106","diff_url":"https://github.com/PyMySQL/mysqlclient-python/pull/106.diff","patch_url":"https://github.com/PyMySQL/mysqlclient-python/pull/106.patch"},"body":"[PyMySQL](https://github.com/PyMySQL/PyMySQL) already does this via `escape_bytes()` [converters.py](https://github.com/PyMySQL/PyMySQL/blob/master/pymysql/converters.py). For compatibility maybe this is a good idea? (I think this would behave the same as with PyMySQL in that nothing it only affects bytes~~/bytearray~~ + Python 3 and bytearray for both versions.)\r\n\r\nI think it's not possible to add to `Connection.encoders` (via constructor) because e.g. `self.encoders[bytes]` is overridden **after** the `conv` argument is parsed."},"comment":{"url":"https://api.github.com/repos/PyMySQL/mysqlclient-python/issues/comments/250723479","html_url":"https://github.com/PyMySQL/mysqlclient-python/pull/106#issuecomment-250723479","issue_url":"https://api.github.com/repos/PyMySQL/mysqlclient-python/issues/106","id":250723479,"user":{"login":"vtermanis","id":6112689,"avatar_url":"https://avatars.githubusercontent.com/u/6112689?v=3","gravatar_id":"","url":"https://api.github.com/users/vtermanis","html_url":"https://github.com/vtermanis","followers_url":"https://api.github.com/users/vtermanis/followers","following_url":"https://api.github.com/users/vtermanis/following{/other_user}","gists_url":"https://api.github.com/users/vtermanis/gists{/gist_id}","starred_url":"https://api.github.com/users/vtermanis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtermanis/subscriptions","organizations_url":"https://api.github.com/users/vtermanis/orgs","repos_url":"https://api.github.com/users/vtermanis/repos","events_url":"https://api.github.com/users/vtermanis/events{/privacy}","received_events_url":"https://api.github.com/users/vtermanis/received_events","type":"User","site_admin":false},"created_at":"2016-09-30T11:37:44Z","updated_at":"2016-09-30T11:37:44Z","body":">  so with 1.3.8 it suddenly breaks with a double _binary.\r\n\r\nCould new versions of django not require a minimum mysqlclient version to address this?\r\n\r\nAnyway, I do understand that of course it should be backwards compatible. Please do feel free to revert. (At the time of me suggesting the change I was trying to make PyMySQL and mysqlclient be more compatible with each other, that's all. (I assume django doesn't have PyMySQL as a library option?)"}}
{"actor":{"display_login":"vtermanis"}}