{"action":"created","comment":{"url":"https://api.github.com/repos/Fibbing/FibbingNode/pulls/comments/89102273","pull_request_review_id":9650901,"id":89102273,"diff_hunk":"@@ -466,7 +505,30 @@ def process_lsa(self):\n                                  for part in lsa_info.split(SEP_GROUP) if part]\n                     hdr = LSAHeader.parse(lsa_parts.pop(0))\n                     lsa = LSA.parse(hdr, lsa_parts)\n+                    new_seqnum = hdr.lsa_seqnum\n+\n                     log.debug('Parsed %s: %s', action, lsa)\n+\n+                    # For now, we just log lsa seq_num and ignore an LSA when\n+                    # it has an older seq_num than the one in the database\n+                    if hdr.lsa_type == '5':","path":"fibbingnode/southbound/lsdb.py","position":110,"original_position":110,"commit_id":"c5852aa6ef62120f2b2253379b60575f3c71733c","original_commit_id":"c5852aa6ef62120f2b2253379b60575f3c71733c","user":{"login":"oliviertilmans","id":1266001,"avatar_url":"https://avatars.githubusercontent.com/u/1266001?v=3","gravatar_id":"","url":"https://api.github.com/users/oliviertilmans","html_url":"https://github.com/oliviertilmans","followers_url":"https://api.github.com/users/oliviertilmans/followers","following_url":"https://api.github.com/users/oliviertilmans/following{/other_user}","gists_url":"https://api.github.com/users/oliviertilmans/gists{/gist_id}","starred_url":"https://api.github.com/users/oliviertilmans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliviertilmans/subscriptions","organizations_url":"https://api.github.com/users/oliviertilmans/orgs","repos_url":"https://api.github.com/users/oliviertilmans/repos","events_url":"https://api.github.com/users/oliviertilmans/events{/privacy}","received_events_url":"https://api.github.com/users/oliviertilmans/received_events","type":"User","site_admin":false},"body":"Could you expand the seqnum handling to all lsa types ? We basically to keep our view of the LSDB totally in sync with the network, so applying the seqnum handling to all LSA types makes sense.","created_at":"2016-11-22T12:09:07Z","updated_at":"2016-11-22T12:09:10Z","html_url":"https://github.com/Fibbing/FibbingNode/pull/5#discussion_r89102273","pull_request_url":"https://api.github.com/repos/Fibbing/FibbingNode/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/Fibbing/FibbingNode/pulls/comments/89102273"},"html":{"href":"https://github.com/Fibbing/FibbingNode/pull/5#discussion_r89102273"},"pull_request":{"href":"https://api.github.com/repos/Fibbing/FibbingNode/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/Fibbing/FibbingNode/pulls/5","id":94479782,"html_url":"https://github.com/Fibbing/FibbingNode/pull/5","diff_url":"https://github.com/Fibbing/FibbingNode/pull/5.diff","patch_url":"https://github.com/Fibbing/FibbingNode/pull/5.patch","issue_url":"https://api.github.com/repos/Fibbing/FibbingNode/issues/5","number":5,"state":"open","locked":false,"title":"New fibbing features","user":{"login":"lferran","id":11825427,"avatar_url":"https://avatars.githubusercontent.com/u/11825427?v=3","gravatar_id":"","url":"https://api.github.com/users/lferran","html_url":"https://github.com/lferran","followers_url":"https://api.github.com/users/lferran/followers","following_url":"https://api.github.com/users/lferran/following{/other_user}","gists_url":"https://api.github.com/users/lferran/gists{/gist_id}","starred_url":"https://api.github.com/users/lferran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lferran/subscriptions","organizations_url":"https://api.github.com/users/lferran/orgs","repos_url":"https://api.github.com/users/lferran/repos","events_url":"https://api.github.com/users/lferran/events{/privacy}","received_events_url":"https://api.github.com/users/lferran/received_events","type":"User","site_admin":false},"body":"Rebased forked FibbingNode and cherry picked useful commits to have a cleaner history\r\n\r\nThe previous PR can be closed","created_at":"2016-11-19T11:54:26Z","updated_at":"2016-11-22T12:09:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0d4e99fca2feb32d27cfcd8949249aca7dbdee0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Fibbing/FibbingNode/pulls/5/commits","review_comments_url":"https://api.github.com/repos/Fibbing/FibbingNode/pulls/5/comments","review_comment_url":"https://api.github.com/repos/Fibbing/FibbingNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Fibbing/FibbingNode/issues/5/comments","statuses_url":"https://api.github.com/repos/Fibbing/FibbingNode/statuses/c5852aa6ef62120f2b2253379b60575f3c71733c","head":{"label":"lferran:new-fibbing-features","ref":"new-fibbing-features","sha":"c5852aa6ef62120f2b2253379b60575f3c71733c","user":{"login":"lferran","id":11825427,"avatar_url":"https://avatars.githubusercontent.com/u/11825427?v=3","gravatar_id":"","url":"https://api.github.com/users/lferran","html_url":"https://github.com/lferran","followers_url":"https://api.github.com/users/lferran/followers","following_url":"https://api.github.com/users/lferran/following{/other_user}","gists_url":"https://api.github.com/users/lferran/gists{/gist_id}","starred_url":"https://api.github.com/users/lferran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lferran/subscriptions","organizations_url":"https://api.github.com/users/lferran/orgs","repos_url":"https://api.github.com/users/lferran/repos","events_url":"https://api.github.com/users/lferran/events{/privacy}","received_events_url":"https://api.github.com/users/lferran/received_events","type":"User","site_admin":false},"repo":{"id":73427440,"name":"FibbingNode","full_name":"lferran/FibbingNode","owner":{"login":"lferran","id":11825427,"avatar_url":"https://avatars.githubusercontent.com/u/11825427?v=3","gravatar_id":"","url":"https://api.github.com/users/lferran","html_url":"https://github.com/lferran","followers_url":"https://api.github.com/users/lferran/followers","following_url":"https://api.github.com/users/lferran/following{/other_user}","gists_url":"https://api.github.com/users/lferran/gists{/gist_id}","starred_url":"https://api.github.com/users/lferran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lferran/subscriptions","organizations_url":"https://api.github.com/users/lferran/orgs","repos_url":"https://api.github.com/users/lferran/repos","events_url":"https://api.github.com/users/lferran/events{/privacy}","received_events_url":"https://api.github.com/users/lferran/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lferran/FibbingNode","description":"The Fibbing controller code","fork":true,"url":"https://api.github.com/repos/lferran/FibbingNode","forks_url":"https://api.github.com/repos/lferran/FibbingNode/forks","keys_url":"https://api.github.com/repos/lferran/FibbingNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lferran/FibbingNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lferran/FibbingNode/teams","hooks_url":"https://api.github.com/repos/lferran/FibbingNode/hooks","issue_events_url":"https://api.github.com/repos/lferran/FibbingNode/issues/events{/number}","events_url":"https://api.github.com/repos/lferran/FibbingNode/events","assignees_url":"https://api.github.com/repos/lferran/FibbingNode/assignees{/user}","branches_url":"https://api.github.com/repos/lferran/FibbingNode/branches{/branch}","tags_url":"https://api.github.com/repos/lferran/FibbingNode/tags","blobs_url":"https://api.github.com/repos/lferran/FibbingNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lferran/FibbingNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lferran/FibbingNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/lferran/FibbingNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lferran/FibbingNode/statuses/{sha}","languages_url":"https://api.github.com/repos/lferran/FibbingNode/languages","stargazers_url":"https://api.github.com/repos/lferran/FibbingNode/stargazers","contributors_url":"https://api.github.com/repos/lferran/FibbingNode/contributors","subscribers_url":"https://api.github.com/repos/lferran/FibbingNode/subscribers","subscription_url":"https://api.github.com/repos/lferran/FibbingNode/subscription","commits_url":"https://api.github.com/repos/lferran/FibbingNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/lferran/FibbingNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/lferran/FibbingNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/lferran/FibbingNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/lferran/FibbingNode/contents/{+path}","compare_url":"https://api.github.com/repos/lferran/FibbingNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lferran/FibbingNode/merges","archive_url":"https://api.github.com/repos/lferran/FibbingNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lferran/FibbingNode/downloads","issues_url":"https://api.github.com/repos/lferran/FibbingNode/issues{/number}","pulls_url":"https://api.github.com/repos/lferran/FibbingNode/pulls{/number}","milestones_url":"https://api.github.com/repos/lferran/FibbingNode/milestones{/number}","notifications_url":"https://api.github.com/repos/lferran/FibbingNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lferran/FibbingNode/labels{/name}","releases_url":"https://api.github.com/repos/lferran/FibbingNode/releases{/id}","deployments_url":"https://api.github.com/repos/lferran/FibbingNode/deployments","created_at":"2016-11-10T22:49:31Z","updated_at":"2016-11-10T22:49:33Z","pushed_at":"2016-11-22T11:07:25Z","git_url":"git://github.com/lferran/FibbingNode.git","ssh_url":"git@github.com:lferran/FibbingNode.git","clone_url":"https://github.com/lferran/FibbingNode.git","svn_url":"https://github.com/lferran/FibbingNode","homepage":"","size":480,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Fibbing:master","ref":"master","sha":"089d97267083e00a84d0b086ebb73c4328739a6b","user":{"login":"Fibbing","id":13316993,"avatar_url":"https://avatars.githubusercontent.com/u/13316993?v=3","gravatar_id":"","url":"https://api.github.com/users/Fibbing","html_url":"https://github.com/Fibbing","followers_url":"https://api.github.com/users/Fibbing/followers","following_url":"https://api.github.com/users/Fibbing/following{/other_user}","gists_url":"https://api.github.com/users/Fibbing/gists{/gist_id}","starred_url":"https://api.github.com/users/Fibbing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fibbing/subscriptions","organizations_url":"https://api.github.com/users/Fibbing/orgs","repos_url":"https://api.github.com/users/Fibbing/repos","events_url":"https://api.github.com/users/Fibbing/events{/privacy}","received_events_url":"https://api.github.com/users/Fibbing/received_events","type":"Organization","site_admin":false},"repo":{"id":39019514,"name":"FibbingNode","full_name":"Fibbing/FibbingNode","owner":{"login":"Fibbing","id":13316993,"avatar_url":"https://avatars.githubusercontent.com/u/13316993?v=3","gravatar_id":"","url":"https://api.github.com/users/Fibbing","html_url":"https://github.com/Fibbing","followers_url":"https://api.github.com/users/Fibbing/followers","following_url":"https://api.github.com/users/Fibbing/following{/other_user}","gists_url":"https://api.github.com/users/Fibbing/gists{/gist_id}","starred_url":"https://api.github.com/users/Fibbing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fibbing/subscriptions","organizations_url":"https://api.github.com/users/Fibbing/orgs","repos_url":"https://api.github.com/users/Fibbing/repos","events_url":"https://api.github.com/users/Fibbing/events{/privacy}","received_events_url":"https://api.github.com/users/Fibbing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Fibbing/FibbingNode","description":"The Fibbing controller code","fork":false,"url":"https://api.github.com/repos/Fibbing/FibbingNode","forks_url":"https://api.github.com/repos/Fibbing/FibbingNode/forks","keys_url":"https://api.github.com/repos/Fibbing/FibbingNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fibbing/FibbingNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fibbing/FibbingNode/teams","hooks_url":"https://api.github.com/repos/Fibbing/FibbingNode/hooks","issue_events_url":"https://api.github.com/repos/Fibbing/FibbingNode/issues/events{/number}","events_url":"https://api.github.com/repos/Fibbing/FibbingNode/events","assignees_url":"https://api.github.com/repos/Fibbing/FibbingNode/assignees{/user}","branches_url":"https://api.github.com/repos/Fibbing/FibbingNode/branches{/branch}","tags_url":"https://api.github.com/repos/Fibbing/FibbingNode/tags","blobs_url":"https://api.github.com/repos/Fibbing/FibbingNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fibbing/FibbingNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fibbing/FibbingNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fibbing/FibbingNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fibbing/FibbingNode/statuses/{sha}","languages_url":"https://api.github.com/repos/Fibbing/FibbingNode/languages","stargazers_url":"https://api.github.com/repos/Fibbing/FibbingNode/stargazers","contributors_url":"https://api.github.com/repos/Fibbing/FibbingNode/contributors","subscribers_url":"https://api.github.com/repos/Fibbing/FibbingNode/subscribers","subscription_url":"https://api.github.com/repos/Fibbing/FibbingNode/subscription","commits_url":"https://api.github.com/repos/Fibbing/FibbingNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fibbing/FibbingNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fibbing/FibbingNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fibbing/FibbingNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fibbing/FibbingNode/contents/{+path}","compare_url":"https://api.github.com/repos/Fibbing/FibbingNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fibbing/FibbingNode/merges","archive_url":"https://api.github.com/repos/Fibbing/FibbingNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fibbing/FibbingNode/downloads","issues_url":"https://api.github.com/repos/Fibbing/FibbingNode/issues{/number}","pulls_url":"https://api.github.com/repos/Fibbing/FibbingNode/pulls{/number}","milestones_url":"https://api.github.com/repos/Fibbing/FibbingNode/milestones{/number}","notifications_url":"https://api.github.com/repos/Fibbing/FibbingNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fibbing/FibbingNode/labels{/name}","releases_url":"https://api.github.com/repos/Fibbing/FibbingNode/releases{/id}","deployments_url":"https://api.github.com/repos/Fibbing/FibbingNode/deployments","created_at":"2015-07-13T15:09:04Z","updated_at":"2016-11-22T10:56:02Z","pushed_at":"2016-11-22T11:05:00Z","git_url":"git://github.com/Fibbing/FibbingNode.git","ssh_url":"git@github.com:Fibbing/FibbingNode.git","clone_url":"https://github.com/Fibbing/FibbingNode.git","svn_url":"https://github.com/Fibbing/FibbingNode","homepage":"","size":417,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Fibbing/FibbingNode/pulls/5"},"html":{"href":"https://github.com/Fibbing/FibbingNode/pull/5"},"issue":{"href":"https://api.github.com/repos/Fibbing/FibbingNode/issues/5"},"comments":{"href":"https://api.github.com/repos/Fibbing/FibbingNode/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/Fibbing/FibbingNode/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/Fibbing/FibbingNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Fibbing/FibbingNode/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/Fibbing/FibbingNode/statuses/c5852aa6ef62120f2b2253379b60575f3c71733c"}}}}
{"actor":{"display_login":"oliviertilmans"}}