{"action":"created","issue":{"url":"https://api.github.com/repos/wavesoft/CCLib/issues/12","repository_url":"https://api.github.com/repos/wavesoft/CCLib","labels_url":"https://api.github.com/repos/wavesoft/CCLib/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/wavesoft/CCLib/issues/12/comments","events_url":"https://api.github.com/repos/wavesoft/CCLib/issues/12/events","html_url":"https://github.com/wavesoft/CCLib/pull/12","id":192660859,"number":12,"title":"Accept both bytes and bytearray for writeCODE","user":{"login":"Sjord","id":113030,"avatar_url":"https://avatars.githubusercontent.com/u/113030?v=3","gravatar_id":"","url":"https://api.github.com/users/Sjord","html_url":"https://github.com/Sjord","followers_url":"https://api.github.com/users/Sjord/followers","following_url":"https://api.github.com/users/Sjord/following{/other_user}","gists_url":"https://api.github.com/users/Sjord/gists{/gist_id}","starred_url":"https://api.github.com/users/Sjord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sjord/subscriptions","organizations_url":"https://api.github.com/users/Sjord/orgs","repos_url":"https://api.github.com/users/Sjord/repos","events_url":"https://api.github.com/users/Sjord/events{/privacy}","received_events_url":"https://api.github.com/users/Sjord/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-30T19:47:04Z","updated_at":"2016-12-14T10:22:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wavesoft/CCLib/pulls/12","html_url":"https://github.com/wavesoft/CCLib/pull/12","diff_url":"https://github.com/wavesoft/CCLib/pull/12.diff","patch_url":"https://github.com/wavesoft/CCLib/pull/12.patch"},"body":"Make writeCODE work whether data is a bytes, str, or bytearray object. This\r\nmeans we have to change any loops through data, because elements of bytes are\r\nbytes and elements of bytearray are ints. For the write, simply pass the whole\r\nthing to pyserial.write instead of looping through it. For verifying, check the\r\nwhole data instead of looping through it. This breaks the functionality that\r\nthe verify function tells the exact offset of the data error. The retry code is\r\nalso gone, but this already didn't really retry anything.\r\n\r\nThe motivation for this change was that CCHEXFile._loadbin returns a str, and\r\nCCHEXFile._loadhex returns a bytearray. This change makes cc_write_flash.py\r\nwork with .bin files."},"comment":{"url":"https://api.github.com/repos/wavesoft/CCLib/issues/comments/266997846","html_url":"https://github.com/wavesoft/CCLib/pull/12#issuecomment-266997846","issue_url":"https://api.github.com/repos/wavesoft/CCLib/issues/12","id":266997846,"user":{"login":"wavesoft","id":883486,"avatar_url":"https://avatars.githubusercontent.com/u/883486?v=3","gravatar_id":"","url":"https://api.github.com/users/wavesoft","html_url":"https://github.com/wavesoft","followers_url":"https://api.github.com/users/wavesoft/followers","following_url":"https://api.github.com/users/wavesoft/following{/other_user}","gists_url":"https://api.github.com/users/wavesoft/gists{/gist_id}","starred_url":"https://api.github.com/users/wavesoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wavesoft/subscriptions","organizations_url":"https://api.github.com/users/wavesoft/orgs","repos_url":"https://api.github.com/users/wavesoft/repos","events_url":"https://api.github.com/users/wavesoft/events{/privacy}","received_events_url":"https://api.github.com/users/wavesoft/received_events","type":"User","site_admin":false},"created_at":"2016-12-14T10:22:28Z","updated_at":"2016-12-14T10:22:28Z","body":"Hey @Sjord ! Looks great! Sorry for not merging this earlier, I just wanted to have a second look for the verification and I didn't have much of a free time. Thanks for this! 💯  ✨ "}}
{"actor":{"display_login":"wavesoft"}}