{"action":"created","comment":{"url":"https://api.github.com/repos/nvaccess/nvda/pulls/comments/77950640","id":77950640,"diff_hunk":"@@ -106,21 +172,37 @@ def _get_NVDAObjectAtStart(self):\n \tdef _get_bookmark(self):\r\n \t\treturn self.copy()\r\n \r\n-\tdef _getControlFieldForObject(self, obj):\r\n+\tdef _getControlFieldForObject(self, obj,isEmbedded=False,startOfNode=False,endOfNode=False):\r\n+\t\t\"\"\"\r\n+\t\tFetch control field information for the given UIA NVDAObject.\r\n+\t\t@ param obj: the NVDAObject the control field is for.\r\n+\t\t@type obj: L{UIA}\r\n+\t\t@param isEmbedded: True if this NVDAObject is for a leaf node (has no useful children).\r\n+\t\t@ type isEmbedded: bool\r\n+\t\t@param startOfNode: True if the control field represents the very start of this object.\r\n+\t\t@type startOfNode: bool\r\n+\t\t@param endOfNode: True if the control field represents the very end of this object.\r\n+\t\t@type endOfNode: bool\r\n+\t\t@return: The control field for this object\r\n+\t\t@rtype: dict containing NVDA control field data.\r\n+\t\t\"\"\"\r\n \t\trole = obj.role\r\n \t\tfield = textInfos.ControlField()\r\n+\t\t# Ensure this controlField is unique to the object\r\n+\t\tfield['runtimeID']=obj.UIAElement.getRuntimeID()\r\n+\t\tfield['_startOfNode']=startOfNode\r\n+\t\tfield['_endOfNode']=endOfNode\r\n \t\tfield[\"role\"] = obj.role\r\n \t\tstates = obj.states\r\n \t\t# The user doesn't care about certain states, as they are obvious.\r\n \t\tstates.discard(controlTypes.STATE_EDITABLE)\r\n \t\tstates.discard(controlTypes.STATE_MULTILINE)\r\n \t\tstates.discard(controlTypes.STATE_FOCUSED)\r\n \t\tfield[\"states\"] = states\r\n-\t\t# Only include name if the object's inner text is empty.\r\n-\t\t# could be unperformant.\r\n \t\ttext=self.obj.makeTextInfo(obj).text\r\n \t\tif not text or text.isspace():\r\n-\t\t\tfield[\"name\"] = obj.name\r\n+\t\t\tfield['name']=obj.name\r","path":"source/NVDAObjects/UIA/__init__.py","position":186,"original_position":186,"commit_id":"30721d110234731e198a96fbf862b2c02b315665","original_commit_id":"30721d110234731e198a96fbf862b2c02b315665","user":{"login":"jcsteh","id":4166475,"avatar_url":"https://avatars.githubusercontent.com/u/4166475?v=3","gravatar_id":"","url":"https://api.github.com/users/jcsteh","html_url":"https://github.com/jcsteh","followers_url":"https://api.github.com/users/jcsteh/followers","following_url":"https://api.github.com/users/jcsteh/following{/other_user}","gists_url":"https://api.github.com/users/jcsteh/gists{/gist_id}","starred_url":"https://api.github.com/users/jcsteh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcsteh/subscriptions","organizations_url":"https://api.github.com/users/jcsteh/orgs","repos_url":"https://api.github.com/users/jcsteh/repos","events_url":"https://api.github.com/users/jcsteh/events{/privacy}","received_events_url":"https://api.github.com/users/jcsteh/received_events","type":"User","site_admin":false},"body":"So name only gets exposed if there's no text. How does this not break quick navigation to edit fields containing text? I just tested and it doesn't, but I don't quite understand why.\r\n\r\nI'm not sure if this is related, but I notice the text of an edit field doesn't get read when quick navigating. For example:\r\n\r\n`<input type=\"text\" aria-label=\"cow\" value=\"goat\">`\r\n\r\nIf I press e to move to that field, it says \"cow edit\", but you never hear \"goat\".","created_at":"2016-09-08T06:10:14Z","updated_at":"2016-09-08T06:10:14Z","html_url":"https://github.com/nvaccess/nvda/pull/6271#discussion_r77950640","pull_request_url":"https://api.github.com/repos/nvaccess/nvda/pulls/6271","_links":{"self":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/comments/77950640"},"html":{"href":"https://github.com/nvaccess/nvda/pull/6271#discussion_r77950640"},"pull_request":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/6271"}}},"pull_request":{"url":"https://api.github.com/repos/nvaccess/nvda/pulls/6271","id":81427545,"html_url":"https://github.com/nvaccess/nvda/pull/6271","diff_url":"https://github.com/nvaccess/nvda/pull/6271.diff","patch_url":"https://github.com/nvaccess/nvda/pull/6271.patch","issue_url":"https://api.github.com/repos/nvaccess/nvda/issues/6271","number":6271,"state":"open","locked":false,"title":"Initial support for Windows 10 anniversary versions of both Microsoft Edge and Windows 10 Mail.","user":{"login":"michaelDCurran","id":14154141,"avatar_url":"https://avatars.githubusercontent.com/u/14154141?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelDCurran","html_url":"https://github.com/michaelDCurran","followers_url":"https://api.github.com/users/michaelDCurran/followers","following_url":"https://api.github.com/users/michaelDCurran/following{/other_user}","gists_url":"https://api.github.com/users/michaelDCurran/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelDCurran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelDCurran/subscriptions","organizations_url":"https://api.github.com/users/michaelDCurran/orgs","repos_url":"https://api.github.com/users/michaelDCurran/repos","events_url":"https://api.github.com/users/michaelDCurran/events{/privacy}","received_events_url":"https://api.github.com/users/michaelDCurran/received_events","type":"User","site_admin":false},"body":"Fixes #6292. Fixes #5987.","created_at":"2016-08-16T07:43:44Z","updated_at":"2016-09-08T06:10:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb2f0a5621eca5383337fbe194e8af17cc3ddc62","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nvaccess/nvda/pulls/6271/commits","review_comments_url":"https://api.github.com/repos/nvaccess/nvda/pulls/6271/comments","review_comment_url":"https://api.github.com/repos/nvaccess/nvda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nvaccess/nvda/issues/6271/comments","statuses_url":"https://api.github.com/repos/nvaccess/nvda/statuses/30721d110234731e198a96fbf862b2c02b315665","head":{"label":"nvaccess:edgeRS1","ref":"edgeRS1","sha":"30721d110234731e198a96fbf862b2c02b315665","user":{"login":"nvaccess","id":4166525,"avatar_url":"https://avatars.githubusercontent.com/u/4166525?v=3","gravatar_id":"","url":"https://api.github.com/users/nvaccess","html_url":"https://github.com/nvaccess","followers_url":"https://api.github.com/users/nvaccess/followers","following_url":"https://api.github.com/users/nvaccess/following{/other_user}","gists_url":"https://api.github.com/users/nvaccess/gists{/gist_id}","starred_url":"https://api.github.com/users/nvaccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvaccess/subscriptions","organizations_url":"https://api.github.com/users/nvaccess/orgs","repos_url":"https://api.github.com/users/nvaccess/repos","events_url":"https://api.github.com/users/nvaccess/events{/privacy}","received_events_url":"https://api.github.com/users/nvaccess/received_events","type":"Organization","site_admin":false},"repo":{"id":45885732,"name":"nvda","full_name":"nvaccess/nvda","owner":{"login":"nvaccess","id":4166525,"avatar_url":"https://avatars.githubusercontent.com/u/4166525?v=3","gravatar_id":"","url":"https://api.github.com/users/nvaccess","html_url":"https://github.com/nvaccess","followers_url":"https://api.github.com/users/nvaccess/followers","following_url":"https://api.github.com/users/nvaccess/following{/other_user}","gists_url":"https://api.github.com/users/nvaccess/gists{/gist_id}","starred_url":"https://api.github.com/users/nvaccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvaccess/subscriptions","organizations_url":"https://api.github.com/users/nvaccess/orgs","repos_url":"https://api.github.com/users/nvaccess/repos","events_url":"https://api.github.com/users/nvaccess/events{/privacy}","received_events_url":"https://api.github.com/users/nvaccess/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nvaccess/nvda","description":"NVDA, the free and open source Screen Reader for Microsoft Windows","fork":false,"url":"https://api.github.com/repos/nvaccess/nvda","forks_url":"https://api.github.com/repos/nvaccess/nvda/forks","keys_url":"https://api.github.com/repos/nvaccess/nvda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nvaccess/nvda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nvaccess/nvda/teams","hooks_url":"https://api.github.com/repos/nvaccess/nvda/hooks","issue_events_url":"https://api.github.com/repos/nvaccess/nvda/issues/events{/number}","events_url":"https://api.github.com/repos/nvaccess/nvda/events","assignees_url":"https://api.github.com/repos/nvaccess/nvda/assignees{/user}","branches_url":"https://api.github.com/repos/nvaccess/nvda/branches{/branch}","tags_url":"https://api.github.com/repos/nvaccess/nvda/tags","blobs_url":"https://api.github.com/repos/nvaccess/nvda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nvaccess/nvda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nvaccess/nvda/git/refs{/sha}","trees_url":"https://api.github.com/repos/nvaccess/nvda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nvaccess/nvda/statuses/{sha}","languages_url":"https://api.github.com/repos/nvaccess/nvda/languages","stargazers_url":"https://api.github.com/repos/nvaccess/nvda/stargazers","contributors_url":"https://api.github.com/repos/nvaccess/nvda/contributors","subscribers_url":"https://api.github.com/repos/nvaccess/nvda/subscribers","subscription_url":"https://api.github.com/repos/nvaccess/nvda/subscription","commits_url":"https://api.github.com/repos/nvaccess/nvda/commits{/sha}","git_commits_url":"https://api.github.com/repos/nvaccess/nvda/git/commits{/sha}","comments_url":"https://api.github.com/repos/nvaccess/nvda/comments{/number}","issue_comment_url":"https://api.github.com/repos/nvaccess/nvda/issues/comments{/number}","contents_url":"https://api.github.com/repos/nvaccess/nvda/contents/{+path}","compare_url":"https://api.github.com/repos/nvaccess/nvda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nvaccess/nvda/merges","archive_url":"https://api.github.com/repos/nvaccess/nvda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nvaccess/nvda/downloads","issues_url":"https://api.github.com/repos/nvaccess/nvda/issues{/number}","pulls_url":"https://api.github.com/repos/nvaccess/nvda/pulls{/number}","milestones_url":"https://api.github.com/repos/nvaccess/nvda/milestones{/number}","notifications_url":"https://api.github.com/repos/nvaccess/nvda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nvaccess/nvda/labels{/name}","releases_url":"https://api.github.com/repos/nvaccess/nvda/releases{/id}","deployments_url":"https://api.github.com/repos/nvaccess/nvda/deployments","created_at":"2015-11-10T03:47:11Z","updated_at":"2016-09-07T14:56:12Z","pushed_at":"2016-09-08T05:59:10Z","git_url":"git://github.com/nvaccess/nvda.git","ssh_url":"git@github.com:nvaccess/nvda.git","clone_url":"https://github.com/nvaccess/nvda.git","svn_url":"https://github.com/nvaccess/nvda","homepage":null,"size":104848,"stargazers_count":168,"watchers_count":168,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"open_issues_count":2418,"forks":83,"open_issues":2418,"watchers":168,"default_branch":"master"}},"base":{"label":"nvaccess:master","ref":"master","sha":"f5ade272cac48743bab125da99613e44f12d2064","user":{"login":"nvaccess","id":4166525,"avatar_url":"https://avatars.githubusercontent.com/u/4166525?v=3","gravatar_id":"","url":"https://api.github.com/users/nvaccess","html_url":"https://github.com/nvaccess","followers_url":"https://api.github.com/users/nvaccess/followers","following_url":"https://api.github.com/users/nvaccess/following{/other_user}","gists_url":"https://api.github.com/users/nvaccess/gists{/gist_id}","starred_url":"https://api.github.com/users/nvaccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvaccess/subscriptions","organizations_url":"https://api.github.com/users/nvaccess/orgs","repos_url":"https://api.github.com/users/nvaccess/repos","events_url":"https://api.github.com/users/nvaccess/events{/privacy}","received_events_url":"https://api.github.com/users/nvaccess/received_events","type":"Organization","site_admin":false},"repo":{"id":45885732,"name":"nvda","full_name":"nvaccess/nvda","owner":{"login":"nvaccess","id":4166525,"avatar_url":"https://avatars.githubusercontent.com/u/4166525?v=3","gravatar_id":"","url":"https://api.github.com/users/nvaccess","html_url":"https://github.com/nvaccess","followers_url":"https://api.github.com/users/nvaccess/followers","following_url":"https://api.github.com/users/nvaccess/following{/other_user}","gists_url":"https://api.github.com/users/nvaccess/gists{/gist_id}","starred_url":"https://api.github.com/users/nvaccess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvaccess/subscriptions","organizations_url":"https://api.github.com/users/nvaccess/orgs","repos_url":"https://api.github.com/users/nvaccess/repos","events_url":"https://api.github.com/users/nvaccess/events{/privacy}","received_events_url":"https://api.github.com/users/nvaccess/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nvaccess/nvda","description":"NVDA, the free and open source Screen Reader for Microsoft Windows","fork":false,"url":"https://api.github.com/repos/nvaccess/nvda","forks_url":"https://api.github.com/repos/nvaccess/nvda/forks","keys_url":"https://api.github.com/repos/nvaccess/nvda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nvaccess/nvda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nvaccess/nvda/teams","hooks_url":"https://api.github.com/repos/nvaccess/nvda/hooks","issue_events_url":"https://api.github.com/repos/nvaccess/nvda/issues/events{/number}","events_url":"https://api.github.com/repos/nvaccess/nvda/events","assignees_url":"https://api.github.com/repos/nvaccess/nvda/assignees{/user}","branches_url":"https://api.github.com/repos/nvaccess/nvda/branches{/branch}","tags_url":"https://api.github.com/repos/nvaccess/nvda/tags","blobs_url":"https://api.github.com/repos/nvaccess/nvda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nvaccess/nvda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nvaccess/nvda/git/refs{/sha}","trees_url":"https://api.github.com/repos/nvaccess/nvda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nvaccess/nvda/statuses/{sha}","languages_url":"https://api.github.com/repos/nvaccess/nvda/languages","stargazers_url":"https://api.github.com/repos/nvaccess/nvda/stargazers","contributors_url":"https://api.github.com/repos/nvaccess/nvda/contributors","subscribers_url":"https://api.github.com/repos/nvaccess/nvda/subscribers","subscription_url":"https://api.github.com/repos/nvaccess/nvda/subscription","commits_url":"https://api.github.com/repos/nvaccess/nvda/commits{/sha}","git_commits_url":"https://api.github.com/repos/nvaccess/nvda/git/commits{/sha}","comments_url":"https://api.github.com/repos/nvaccess/nvda/comments{/number}","issue_comment_url":"https://api.github.com/repos/nvaccess/nvda/issues/comments{/number}","contents_url":"https://api.github.com/repos/nvaccess/nvda/contents/{+path}","compare_url":"https://api.github.com/repos/nvaccess/nvda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nvaccess/nvda/merges","archive_url":"https://api.github.com/repos/nvaccess/nvda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nvaccess/nvda/downloads","issues_url":"https://api.github.com/repos/nvaccess/nvda/issues{/number}","pulls_url":"https://api.github.com/repos/nvaccess/nvda/pulls{/number}","milestones_url":"https://api.github.com/repos/nvaccess/nvda/milestones{/number}","notifications_url":"https://api.github.com/repos/nvaccess/nvda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nvaccess/nvda/labels{/name}","releases_url":"https://api.github.com/repos/nvaccess/nvda/releases{/id}","deployments_url":"https://api.github.com/repos/nvaccess/nvda/deployments","created_at":"2015-11-10T03:47:11Z","updated_at":"2016-09-07T14:56:12Z","pushed_at":"2016-09-08T05:59:10Z","git_url":"git://github.com/nvaccess/nvda.git","ssh_url":"git@github.com:nvaccess/nvda.git","clone_url":"https://github.com/nvaccess/nvda.git","svn_url":"https://github.com/nvaccess/nvda","homepage":null,"size":104848,"stargazers_count":168,"watchers_count":168,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"open_issues_count":2418,"forks":83,"open_issues":2418,"watchers":168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/6271"},"html":{"href":"https://github.com/nvaccess/nvda/pull/6271"},"issue":{"href":"https://api.github.com/repos/nvaccess/nvda/issues/6271"},"comments":{"href":"https://api.github.com/repos/nvaccess/nvda/issues/6271/comments"},"review_comments":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/6271/comments"},"review_comment":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nvaccess/nvda/pulls/6271/commits"},"statuses":{"href":"https://api.github.com/repos/nvaccess/nvda/statuses/30721d110234731e198a96fbf862b2c02b315665"}}}}
{"actor":{"display_login":"jcsteh"}}