{"action":"created","issue":{"url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/781","repository_url":"https://api.github.com/repos/pyfa-org/Pyfa","labels_url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/781/labels{/name}","comments_url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/781/comments","events_url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/781/events","html_url":"https://github.com/pyfa-org/Pyfa/issues/781","id":184585771,"number":781,"title":"Hard-coded item group causes localization failure","user":{"login":"mingl0280","id":3364434,"avatar_url":"https://avatars.githubusercontent.com/u/3364434?v=3","gravatar_id":"","url":"https://api.github.com/users/mingl0280","html_url":"https://github.com/mingl0280","followers_url":"https://api.github.com/users/mingl0280/followers","following_url":"https://api.github.com/users/mingl0280/following{/other_user}","gists_url":"https://api.github.com/users/mingl0280/gists{/gist_id}","starred_url":"https://api.github.com/users/mingl0280/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingl0280/subscriptions","organizations_url":"https://api.github.com/users/mingl0280/orgs","repos_url":"https://api.github.com/users/mingl0280/repos","events_url":"https://api.github.com/users/mingl0280/events{/privacy}","received_events_url":"https://api.github.com/users/mingl0280/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-21T22:44:03Z","updated_at":"2016-10-22T00:46:17Z","closed_at":null,"body":"I've been doing some translation on the project, and I found when I localized the item name, pyfa cannot be started properly. After digging into the code, I found following lines:\r\nservice\\market.py\r\n```\r\nself.ITEMS_FORCEGROUP = {\r\n            \"Opux Luxury Yacht\": self.les_grp, # One of those is wedding present at CCP fanfest, another was hijacked from ISD guy during an event\r\n            \"Silver Magnate\": self.les_grp,  # Amarr Championship prize\r\n            \"Gold Magnate\": self.les_grp,  # Amarr Championship prize\r\n            \"Armageddon Imperial Issue\": self.les_grp,  # Amarr Championship prize\r\n            \"Apocalypse Imperial Issue\": self.les_grp, # Amarr Championship prize\r\n            \"Guardian-Vexor\": self.les_grp, # Illegal rewards for the Gallente Frontier Tour Lines event arc\r\n            \"Megathron Federate Issue\": self.les_grp, # Reward during Crielere event\r\n            \"Raven State Issue\": self.les_grp,  # AT4 prize\r\n            \"Tempest Tribal Issue\": self.les_grp, # AT4 prize\r\n            \"Apotheosis\": self.les_grp, # 5th EVE anniversary present\r\n            \"Zephyr\": self.les_grp, # 2010 new year gift\r\n            \"Primae\": self.les_grp, # Promotion of planetary interaction\r\n            \"Freki\": self.les_grp, # AT7 prize\r\n            \"Mimir\": self.les_grp, # AT7 prize\r\n            \"Utu\": self.les_grp, # AT8 prize\r\n            \"Adrestia\": self.les_grp, # AT8 prize\r\n            \"Echelon\": self.les_grp, # 2011 new year gift\r\n            \"Malice\": self.les_grp, # AT9 prize\r\n            \"Vangel\": self.les_grp, # AT9 prize\r\n            \"Cambion\": self.les_grp, # AT10 prize\r\n            \"Etana\": self.les_grp, # AT10 prize\r\n            \"Chremoas\": self.les_grp, # AT11 prize :(\r\n            \"Moracha\": self.les_grp, # AT11 prize\r\n            \"Stratios Emergency Responder\": self.les_grp, # Issued for Somer Blink lottery\r\n            \"Miasmos Quafe Ultra Edition\": self.les_grp, # Gift to people who purchased FF HD stream\r\n            \"InterBus Shuttle\": self.les_grp,\r\n            \"Leopard\": self.les_grp, # 2013 new year gift\r\n            \"Whiptail\": self.les_grp, # AT12 prize\r\n            \"Chameleon\": self.les_grp, # AT12 prize\r\n            \"Victorieux Luxury Yacht\":  self.les_grp,  # Worlds Collide prize \\o/ chinese getting owned\r\n            \"Imp\": self.les_grp,  # AT13 prize\r\n            \"Fiend\": self.les_grp,  # AT13 prize\r\n        }\r\n\r\n        self.ITEMS_FORCEGROUP_R = self.__makeRevDict(self.ITEMS_FORCEGROUP)\r\n        self.les_grp.addItems = list(self.getItem(itmn) for itmn in self.ITEMS_FORCEGROUP_R[self.les_grp])\r\n        self.customGroups.add(self.les_grp)\r\n\r\n        # List of items which are forcibly published or hidden\r\n        self.ITEMS_FORCEPUBLISHED = {\r\n            \"Data Subverter I\": False, # Not used in EVE, probably will appear with Dust link\r\n            \"QA Cross Protocol Analyzer\": False, # QA modules used by CCP internally\r\n            \"QA Damage Module\": False,\r\n            \"QA ECCM\": False,\r\n            \"QA Immunity Module\": False,\r\n            \"QA Multiship Module - 10 Players\": False,\r\n            \"QA Multiship Module - 20 Players\": False,\r\n            \"QA Multiship Module - 40 Players\": False,\r\n            \"QA Multiship Module - 5 Players\": False,\r\n            \"QA Remote Armor Repair System - 5 Players\": False,\r\n            \"QA Shield Transporter - 5 Players\": False,\r\n            \"Goru's Shuttle\": False,\r\n            \"Guristas Shuttle\": False,\r\n            \"Mobile Decoy Unit\": False,  # Seems to be left over test mod for deployables\r\n            \"Tournament Micro Jump Unit\": False,  # Normally seen only on tournament arenas\r\n            \"Council Diplomatic Shuttle\": False,  # CSM X celebration\r\n            \"Civilian Gatling Railgun\": True,\r\n            \"Civilian Gatling Pulse Laser\": True,\r\n            \"Civilian Gatling Autocannon\": True,\r\n            \"Civilian Light Electron Blaster\": True,\r\n        }\r\n        ...\r\n```\r\nWhich caused the market service can't find proper name when you localized every string in the database."},"comment":{"url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/comments/255496173","html_url":"https://github.com/pyfa-org/Pyfa/issues/781#issuecomment-255496173","issue_url":"https://api.github.com/repos/pyfa-org/Pyfa/issues/781","id":255496173,"user":{"login":"mingl0280","id":3364434,"avatar_url":"https://avatars.githubusercontent.com/u/3364434?v=3","gravatar_id":"","url":"https://api.github.com/users/mingl0280","html_url":"https://github.com/mingl0280","followers_url":"https://api.github.com/users/mingl0280/followers","following_url":"https://api.github.com/users/mingl0280/following{/other_user}","gists_url":"https://api.github.com/users/mingl0280/gists{/gist_id}","starred_url":"https://api.github.com/users/mingl0280/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mingl0280/subscriptions","organizations_url":"https://api.github.com/users/mingl0280/orgs","repos_url":"https://api.github.com/users/mingl0280/repos","events_url":"https://api.github.com/users/mingl0280/events{/privacy}","received_events_url":"https://api.github.com/users/mingl0280/received_events","type":"User","site_admin":false},"created_at":"2016-10-22T00:46:17Z","updated_at":"2016-10-22T00:46:17Z","body":"> What exactly are you trying to do? Are you using the localized strings in the DB? Got working code? \r\n\r\nThe case is, if you changed all the \"Name\" columns in DB (such as categoryName, typeName, and so on), the whole program crashes. "}}
{"actor":{"display_login":"mingl0280"}}