{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/12725","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/12725/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/12725/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/12725/events","html_url":"https://github.com/dotnet/corefx/issues/12725","id":183476283,"number":12725,"title":"Enhance APICompat to discover [Serializable]","user":{"login":"danmosemsft","id":6385855,"avatar_url":"https://avatars.githubusercontent.com/u/6385855?v=3","gravatar_id":"","url":"https://api.github.com/users/danmosemsft","html_url":"https://github.com/danmosemsft","followers_url":"https://api.github.com/users/danmosemsft/followers","following_url":"https://api.github.com/users/danmosemsft/following{/other_user}","gists_url":"https://api.github.com/users/danmosemsft/gists{/gist_id}","starred_url":"https://api.github.com/users/danmosemsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmosemsft/subscriptions","organizations_url":"https://api.github.com/users/danmosemsft/orgs","repos_url":"https://api.github.com/users/danmosemsft/repos","events_url":"https://api.github.com/users/danmosemsft/events{/privacy}","received_events_url":"https://api.github.com/users/danmosemsft/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/corefx/labels/area-Serialization","name":"area-Serialization","color":"d4c5f9"},{"url":"https://api.github.com/repos/dotnet/corefx/labels/netstandard2.0","name":"netstandard2.0","color":"c5def5"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-17T17:22:07Z","updated_at":"2016-10-17T17:25:25Z","closed_at":null,"body":"Presumably some of these are missing, since BinarySerialization had been removed. It's hard to say how many because it's not represented in the ref assemblies. This may not be much (or even any) since there are still 149 instances of it in the CoreCLR implementations and we inherit most of those implementations. We do need it back since it likely changes serialization behavior.\r\n\r\nTo find them if any, we need to update the apicompat tool then run it against desktop impl on the LHS and CoreFX impl on the RHS. Any types that are present in CoreFX, but are missing the attribute, should have it added.\r\n\r\n@weshaggard sound about right? perhaps there's no much to do here, since it's all over CoreCLR."},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/254274586","html_url":"https://github.com/dotnet/corefx/issues/12725#issuecomment-254274586","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/12725","id":254274586,"user":{"login":"danmosemsft","id":6385855,"avatar_url":"https://avatars.githubusercontent.com/u/6385855?v=3","gravatar_id":"","url":"https://api.github.com/users/danmosemsft","html_url":"https://github.com/danmosemsft","followers_url":"https://api.github.com/users/danmosemsft/followers","following_url":"https://api.github.com/users/danmosemsft/following{/other_user}","gists_url":"https://api.github.com/users/danmosemsft/gists{/gist_id}","starred_url":"https://api.github.com/users/danmosemsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmosemsft/subscriptions","organizations_url":"https://api.github.com/users/danmosemsft/orgs","repos_url":"https://api.github.com/users/danmosemsft/repos","events_url":"https://api.github.com/users/danmosemsft/events{/privacy}","received_events_url":"https://api.github.com/users/danmosemsft/received_events","type":"User","site_admin":false},"created_at":"2016-10-17T17:25:25Z","updated_at":"2016-10-17T17:25:25Z","body":"If you like -- figured we could track all NS2.0 work together. Up to you"}}
{"actor":{"display_login":"danmosemsft"}}