{"action":"created","comment":{"url":"https://api.github.com/repos/hyperium/hyper/pulls/comments/77457280","id":77457280,"diff_hunk":"@@ -56,9 +31,37 @@ enum Kind {\n }\n \n impl Decoder {\n+    pub fn length(x: u64) -> Decoder {\n+        Decoder::Length(x)\n+    }\n+\n+    pub fn chunked() -> Decoder {\n+        Decoder::Chunked(None)\n+    }\n+\n+    pub fn eof() -> Decoder {\n+        Decoder::Eof(false)\n+    }\n+}\n+\n+#[allow(warnings)]\n+// TODO Replace Chunked(Option<u64>) with Chunked(ChunkedState)\n+#[derive(Debug, PartialEq, Clone)]\n+enum ChunkedState {\n+    Init,\n+    Size(u64),\n+    SizeCr,\n+    SizeLf,\n+    Body(usize),\n+    BodyCr,\n+    BodyLf,\n+    End,\n+}","path":"src/http/h1/decode.rs","position":71,"original_position":71,"commit_id":"76a537f343e9316eec100913ea4639de187d14e8","original_commit_id":"76a537f343e9316eec100913ea4639de187d14e8","user":{"login":"seanmonstar","id":51479,"avatar_url":"https://avatars.githubusercontent.com/u/51479?v=3","gravatar_id":"","url":"https://api.github.com/users/seanmonstar","html_url":"https://github.com/seanmonstar","followers_url":"https://api.github.com/users/seanmonstar/followers","following_url":"https://api.github.com/users/seanmonstar/following{/other_user}","gists_url":"https://api.github.com/users/seanmonstar/gists{/gist_id}","starred_url":"https://api.github.com/users/seanmonstar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanmonstar/subscriptions","organizations_url":"https://api.github.com/users/seanmonstar/orgs","repos_url":"https://api.github.com/users/seanmonstar/repos","events_url":"https://api.github.com/users/seanmonstar/events{/privacy}","received_events_url":"https://api.github.com/users/seanmonstar/received_events","type":"User","site_admin":false},"body":"Excellent, I was thinking something like this would be needed. ","created_at":"2016-09-04T19:26:17Z","updated_at":"2016-09-04T19:26:17Z","html_url":"https://github.com/hyperium/hyper/pull/909#discussion_r77457280","pull_request_url":"https://api.github.com/repos/hyperium/hyper/pulls/909","_links":{"self":{"href":"https://api.github.com/repos/hyperium/hyper/pulls/comments/77457280"},"html":{"href":"https://github.com/hyperium/hyper/pull/909#discussion_r77457280"},"pull_request":{"href":"https://api.github.com/repos/hyperium/hyper/pulls/909"}}},"pull_request":{"url":"https://api.github.com/repos/hyperium/hyper/pulls/909","id":83911666,"html_url":"https://github.com/hyperium/hyper/pull/909","diff_url":"https://github.com/hyperium/hyper/pull/909.diff","patch_url":"https://github.com/hyperium/hyper/pull/909.patch","issue_url":"https://api.github.com/repos/hyperium/hyper/issues/909","number":909,"state":"open","locked":false,"title":"Async Chunked Decoding","user":{"login":"shanegibbs","id":2838876,"avatar_url":"https://avatars.githubusercontent.com/u/2838876?v=3","gravatar_id":"","url":"https://api.github.com/users/shanegibbs","html_url":"https://github.com/shanegibbs","followers_url":"https://api.github.com/users/shanegibbs/followers","following_url":"https://api.github.com/users/shanegibbs/following{/other_user}","gists_url":"https://api.github.com/users/shanegibbs/gists{/gist_id}","starred_url":"https://api.github.com/users/shanegibbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanegibbs/subscriptions","organizations_url":"https://api.github.com/users/shanegibbs/orgs","repos_url":"https://api.github.com/users/shanegibbs/repos","events_url":"https://api.github.com/users/shanegibbs/events{/privacy}","received_events_url":"https://api.github.com/users/shanegibbs/received_events","type":"User","site_admin":false},"body":"Initial test to get the ball rolling.\r\n\r\n_Work in progress (will squash commits eventually)_","created_at":"2016-09-04T02:37:20Z","updated_at":"2016-09-04T19:26:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fc6270dbbf72c0a2c757991dee49081ff44ff60","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperium/hyper/pulls/909/commits","review_comments_url":"https://api.github.com/repos/hyperium/hyper/pulls/909/comments","review_comment_url":"https://api.github.com/repos/hyperium/hyper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperium/hyper/issues/909/comments","statuses_url":"https://api.github.com/repos/hyperium/hyper/statuses/76a537f343e9316eec100913ea4639de187d14e8","head":{"label":"shanegibbs:async-chunking","ref":"async-chunking","sha":"76a537f343e9316eec100913ea4639de187d14e8","user":{"login":"shanegibbs","id":2838876,"avatar_url":"https://avatars.githubusercontent.com/u/2838876?v=3","gravatar_id":"","url":"https://api.github.com/users/shanegibbs","html_url":"https://github.com/shanegibbs","followers_url":"https://api.github.com/users/shanegibbs/followers","following_url":"https://api.github.com/users/shanegibbs/following{/other_user}","gists_url":"https://api.github.com/users/shanegibbs/gists{/gist_id}","starred_url":"https://api.github.com/users/shanegibbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanegibbs/subscriptions","organizations_url":"https://api.github.com/users/shanegibbs/orgs","repos_url":"https://api.github.com/users/shanegibbs/repos","events_url":"https://api.github.com/users/shanegibbs/events{/privacy}","received_events_url":"https://api.github.com/users/shanegibbs/received_events","type":"User","site_admin":false},"repo":{"id":67321808,"name":"hyper","full_name":"shanegibbs/hyper","owner":{"login":"shanegibbs","id":2838876,"avatar_url":"https://avatars.githubusercontent.com/u/2838876?v=3","gravatar_id":"","url":"https://api.github.com/users/shanegibbs","html_url":"https://github.com/shanegibbs","followers_url":"https://api.github.com/users/shanegibbs/followers","following_url":"https://api.github.com/users/shanegibbs/following{/other_user}","gists_url":"https://api.github.com/users/shanegibbs/gists{/gist_id}","starred_url":"https://api.github.com/users/shanegibbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanegibbs/subscriptions","organizations_url":"https://api.github.com/users/shanegibbs/orgs","repos_url":"https://api.github.com/users/shanegibbs/repos","events_url":"https://api.github.com/users/shanegibbs/events{/privacy}","received_events_url":"https://api.github.com/users/shanegibbs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shanegibbs/hyper","description":"An HTTP library for Rust","fork":true,"url":"https://api.github.com/repos/shanegibbs/hyper","forks_url":"https://api.github.com/repos/shanegibbs/hyper/forks","keys_url":"https://api.github.com/repos/shanegibbs/hyper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shanegibbs/hyper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shanegibbs/hyper/teams","hooks_url":"https://api.github.com/repos/shanegibbs/hyper/hooks","issue_events_url":"https://api.github.com/repos/shanegibbs/hyper/issues/events{/number}","events_url":"https://api.github.com/repos/shanegibbs/hyper/events","assignees_url":"https://api.github.com/repos/shanegibbs/hyper/assignees{/user}","branches_url":"https://api.github.com/repos/shanegibbs/hyper/branches{/branch}","tags_url":"https://api.github.com/repos/shanegibbs/hyper/tags","blobs_url":"https://api.github.com/repos/shanegibbs/hyper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shanegibbs/hyper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shanegibbs/hyper/git/refs{/sha}","trees_url":"https://api.github.com/repos/shanegibbs/hyper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shanegibbs/hyper/statuses/{sha}","languages_url":"https://api.github.com/repos/shanegibbs/hyper/languages","stargazers_url":"https://api.github.com/repos/shanegibbs/hyper/stargazers","contributors_url":"https://api.github.com/repos/shanegibbs/hyper/contributors","subscribers_url":"https://api.github.com/repos/shanegibbs/hyper/subscribers","subscription_url":"https://api.github.com/repos/shanegibbs/hyper/subscription","commits_url":"https://api.github.com/repos/shanegibbs/hyper/commits{/sha}","git_commits_url":"https://api.github.com/repos/shanegibbs/hyper/git/commits{/sha}","comments_url":"https://api.github.com/repos/shanegibbs/hyper/comments{/number}","issue_comment_url":"https://api.github.com/repos/shanegibbs/hyper/issues/comments{/number}","contents_url":"https://api.github.com/repos/shanegibbs/hyper/contents/{+path}","compare_url":"https://api.github.com/repos/shanegibbs/hyper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shanegibbs/hyper/merges","archive_url":"https://api.github.com/repos/shanegibbs/hyper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shanegibbs/hyper/downloads","issues_url":"https://api.github.com/repos/shanegibbs/hyper/issues{/number}","pulls_url":"https://api.github.com/repos/shanegibbs/hyper/pulls{/number}","milestones_url":"https://api.github.com/repos/shanegibbs/hyper/milestones{/number}","notifications_url":"https://api.github.com/repos/shanegibbs/hyper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shanegibbs/hyper/labels{/name}","releases_url":"https://api.github.com/repos/shanegibbs/hyper/releases{/id}","deployments_url":"https://api.github.com/repos/shanegibbs/hyper/deployments","created_at":"2016-09-04T02:35:31Z","updated_at":"2016-09-04T02:35:34Z","pushed_at":"2016-09-04T14:32:12Z","git_url":"git://github.com/shanegibbs/hyper.git","ssh_url":"git@github.com:shanegibbs/hyper.git","clone_url":"https://github.com/shanegibbs/hyper.git","svn_url":"https://github.com/shanegibbs/hyper","homepage":"http://hyper.rs","size":8217,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperium:master","ref":"master","sha":"8b3c1206846cb96be780923952eafe0dde7850bf","user":{"login":"hyperium","id":8730506,"avatar_url":"https://avatars.githubusercontent.com/u/8730506?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperium","html_url":"https://github.com/hyperium","followers_url":"https://api.github.com/users/hyperium/followers","following_url":"https://api.github.com/users/hyperium/following{/other_user}","gists_url":"https://api.github.com/users/hyperium/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperium/subscriptions","organizations_url":"https://api.github.com/users/hyperium/orgs","repos_url":"https://api.github.com/users/hyperium/repos","events_url":"https://api.github.com/users/hyperium/events{/privacy}","received_events_url":"https://api.github.com/users/hyperium/received_events","type":"Organization","site_admin":false},"repo":{"id":23500865,"name":"hyper","full_name":"hyperium/hyper","owner":{"login":"hyperium","id":8730506,"avatar_url":"https://avatars.githubusercontent.com/u/8730506?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperium","html_url":"https://github.com/hyperium","followers_url":"https://api.github.com/users/hyperium/followers","following_url":"https://api.github.com/users/hyperium/following{/other_user}","gists_url":"https://api.github.com/users/hyperium/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperium/subscriptions","organizations_url":"https://api.github.com/users/hyperium/orgs","repos_url":"https://api.github.com/users/hyperium/repos","events_url":"https://api.github.com/users/hyperium/events{/privacy}","received_events_url":"https://api.github.com/users/hyperium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperium/hyper","description":"An HTTP library for Rust","fork":false,"url":"https://api.github.com/repos/hyperium/hyper","forks_url":"https://api.github.com/repos/hyperium/hyper/forks","keys_url":"https://api.github.com/repos/hyperium/hyper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperium/hyper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperium/hyper/teams","hooks_url":"https://api.github.com/repos/hyperium/hyper/hooks","issue_events_url":"https://api.github.com/repos/hyperium/hyper/issues/events{/number}","events_url":"https://api.github.com/repos/hyperium/hyper/events","assignees_url":"https://api.github.com/repos/hyperium/hyper/assignees{/user}","branches_url":"https://api.github.com/repos/hyperium/hyper/branches{/branch}","tags_url":"https://api.github.com/repos/hyperium/hyper/tags","blobs_url":"https://api.github.com/repos/hyperium/hyper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperium/hyper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperium/hyper/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperium/hyper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperium/hyper/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperium/hyper/languages","stargazers_url":"https://api.github.com/repos/hyperium/hyper/stargazers","contributors_url":"https://api.github.com/repos/hyperium/hyper/contributors","subscribers_url":"https://api.github.com/repos/hyperium/hyper/subscribers","subscription_url":"https://api.github.com/repos/hyperium/hyper/subscription","commits_url":"https://api.github.com/repos/hyperium/hyper/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperium/hyper/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperium/hyper/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperium/hyper/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperium/hyper/contents/{+path}","compare_url":"https://api.github.com/repos/hyperium/hyper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperium/hyper/merges","archive_url":"https://api.github.com/repos/hyperium/hyper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperium/hyper/downloads","issues_url":"https://api.github.com/repos/hyperium/hyper/issues{/number}","pulls_url":"https://api.github.com/repos/hyperium/hyper/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperium/hyper/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperium/hyper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperium/hyper/labels{/name}","releases_url":"https://api.github.com/repos/hyperium/hyper/releases{/id}","deployments_url":"https://api.github.com/repos/hyperium/hyper/deployments","created_at":"2014-08-30T21:14:33Z","updated_at":"2016-09-04T12:51:58Z","pushed_at":"2016-09-04T14:32:12Z","git_url":"git://github.com/hyperium/hyper.git","ssh_url":"git@github.com:hyperium/hyper.git","clone_url":"https://github.com/hyperium/hyper.git","svn_url":"https://github.com/hyperium/hyper","homepage":"http://hyper.rs","size":11233,"stargazers_count":1918,"watchers_count":1918,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":324,"mirror_url":null,"open_issues_count":36,"forks":324,"open_issues":36,"watchers":1918,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperium/hyper/pulls/909"},"html":{"href":"https://github.com/hyperium/hyper/pull/909"},"issue":{"href":"https://api.github.com/repos/hyperium/hyper/issues/909"},"comments":{"href":"https://api.github.com/repos/hyperium/hyper/issues/909/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperium/hyper/pulls/909/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperium/hyper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperium/hyper/pulls/909/commits"},"statuses":{"href":"https://api.github.com/repos/hyperium/hyper/statuses/76a537f343e9316eec100913ea4639de187d14e8"}}}}
{"actor":{"display_login":"seanmonstar"}}