{"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/66270518","id":66270518,"diff_hunk":"@@ -822,4 +822,37 @@ sub testssl {\n         ok(run(test([@ssltest, \"-bio_pair\", \"-tls1\", \"-ct\"])));\n         }\n     };\n+\n+    subtest 'Session ticket + SNI enable tests' => sub {\n+\t######################################################################","path":"test/recipes/80-test_ssl_old.t","position":15,"original_position":15,"commit_id":"4fcd80d764642dfabd16822e4cc9e0e41334e126","original_commit_id":"4fcd80d764642dfabd16822e4cc9e0e41334e126","user":{"login":"ekasper","id":7046250,"avatar_url":"https://avatars.githubusercontent.com/u/7046250?v=3","gravatar_id":"","url":"https://api.github.com/users/ekasper","html_url":"https://github.com/ekasper","followers_url":"https://api.github.com/users/ekasper/followers","following_url":"https://api.github.com/users/ekasper/following{/other_user}","gists_url":"https://api.github.com/users/ekasper/gists{/gist_id}","starred_url":"https://api.github.com/users/ekasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekasper/subscriptions","organizations_url":"https://api.github.com/users/ekasper/orgs","repos_url":"https://api.github.com/users/ekasper/repos","events_url":"https://api.github.com/users/ekasper/events{/privacy}","received_events_url":"https://api.github.com/users/ekasper/received_events","type":"User","site_admin":false},"body":"Oh, and you'll also need to add a ticket expectation to the test results...","created_at":"2016-06-08T14:50:40Z","updated_at":"2016-06-08T14:50:40Z","html_url":"https://github.com/openssl/openssl/pull/1098#discussion_r66270518","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/1098","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/66270518"},"html":{"href":"https://github.com/openssl/openssl/pull/1098#discussion_r66270518"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1098"}}},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/1098","id":70709558,"html_url":"https://github.com/openssl/openssl/pull/1098","diff_url":"https://github.com/openssl/openssl/pull/1098.diff","patch_url":"https://github.com/openssl/openssl/pull/1098.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/1098","number":1098,"state":"open","locked":false,"title":"Fix session ticket and SNI (master)","user":{"login":"tmshort","id":10981912,"avatar_url":"https://avatars.githubusercontent.com/u/10981912?v=3","gravatar_id":"","url":"https://api.github.com/users/tmshort","html_url":"https://github.com/tmshort","followers_url":"https://api.github.com/users/tmshort/followers","following_url":"https://api.github.com/users/tmshort/following{/other_user}","gists_url":"https://api.github.com/users/tmshort/gists{/gist_id}","starred_url":"https://api.github.com/users/tmshort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmshort/subscriptions","organizations_url":"https://api.github.com/users/tmshort/orgs","repos_url":"https://api.github.com/users/tmshort/repos","events_url":"https://api.github.com/users/tmshort/events{/privacy}","received_events_url":"https://api.github.com/users/tmshort/received_events","type":"User","site_admin":false},"body":"When session tickets are used, it's possible that SNI might swtich the\r\nSSL_CTX on an SSL. Normally, this is not a problem, because the\r\ninitial_ctx/session_ctx are used for all session ticket/id processes.\r\n\r\nHowever, when the SNI callback occurs, it's possible that the callback\r\nmay update the options in the SSL from the SSL_CTX, and this could\r\ncause SSL_OP_NO_TICKET to be set. If this occurs, then two bad things\r\ncan happen:\r\n\r\n1. The session ticket TLSEXT may not be written when the ticket expected\r\nflag is set. The state machine transistions to writing the ticket, and\r\nthe client responds with an error as its not expecting a ticket.\r\n2. When creating the session ticket, if the ticket key cb returns 0\r\nthe crypto/hmac contexts are not initialized, and the code crashes when\r\ntrying to encrypt the session ticket.\r\n\r\nTo fix 1, if the ticket TLSEXT is not written out, clear the expected\r\nticket flag.\r\nTo fix 2, consider a return of 0 from the ticket key cb a recoverable\r\nerror, and write a 0 length ticket and continue. The client-side code\r\ncan explicitly handle this case.\r\n\r\nFix these two cases, and add unit test code to validate ticket behavior.","created_at":"2016-05-19T14:58:45Z","updated_at":"2016-06-08T14:50:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6391ab15d97aa48479b27d03d794741b3bd8e200","assignee":{"login":"richsalz","id":7332500,"avatar_url":"https://avatars.githubusercontent.com/u/7332500?v=3","gravatar_id":"","url":"https://api.github.com/users/richsalz","html_url":"https://github.com/richsalz","followers_url":"https://api.github.com/users/richsalz/followers","following_url":"https://api.github.com/users/richsalz/following{/other_user}","gists_url":"https://api.github.com/users/richsalz/gists{/gist_id}","starred_url":"https://api.github.com/users/richsalz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richsalz/subscriptions","organizations_url":"https://api.github.com/users/richsalz/orgs","repos_url":"https://api.github.com/users/richsalz/repos","events_url":"https://api.github.com/users/richsalz/events{/privacy}","received_events_url":"https://api.github.com/users/richsalz/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/openssl/openssl/milestones/1","html_url":"https://github.com/openssl/openssl/milestones/1.1.0","labels_url":"https://api.github.com/repos/openssl/openssl/milestones/1/labels","id":1748232,"number":1,"title":"1.1.0","description":"","creator":{"login":"levitte","id":698918,"avatar_url":"https://avatars.githubusercontent.com/u/698918?v=3","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":102,"state":"open","created_at":"2016-05-04T17:53:39Z","updated_at":"2016-06-08T14:32:00Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/1098/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/1098/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/1098/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/4fcd80d764642dfabd16822e4cc9e0e41334e126","head":{"label":"akamai:tshort-master-sessticket","ref":"tshort-master-sessticket","sha":"4fcd80d764642dfabd16822e4cc9e0e41334e126","user":{"login":"akamai","id":7504551,"avatar_url":"https://avatars.githubusercontent.com/u/7504551?v=3","gravatar_id":"","url":"https://api.github.com/users/akamai","html_url":"https://github.com/akamai","followers_url":"https://api.github.com/users/akamai/followers","following_url":"https://api.github.com/users/akamai/following{/other_user}","gists_url":"https://api.github.com/users/akamai/gists{/gist_id}","starred_url":"https://api.github.com/users/akamai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akamai/subscriptions","organizations_url":"https://api.github.com/users/akamai/orgs","repos_url":"https://api.github.com/users/akamai/repos","events_url":"https://api.github.com/users/akamai/events{/privacy}","received_events_url":"https://api.github.com/users/akamai/received_events","type":"Organization","site_admin":false},"repo":{"id":19614645,"name":"openssl","full_name":"akamai/openssl","owner":{"login":"akamai","id":7504551,"avatar_url":"https://avatars.githubusercontent.com/u/7504551?v=3","gravatar_id":"","url":"https://api.github.com/users/akamai","html_url":"https://github.com/akamai","followers_url":"https://api.github.com/users/akamai/followers","following_url":"https://api.github.com/users/akamai/following{/other_user}","gists_url":"https://api.github.com/users/akamai/gists{/gist_id}","starred_url":"https://api.github.com/users/akamai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akamai/subscriptions","organizations_url":"https://api.github.com/users/akamai/orgs","repos_url":"https://api.github.com/users/akamai/repos","events_url":"https://api.github.com/users/akamai/events{/privacy}","received_events_url":"https://api.github.com/users/akamai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akamai/openssl","description":"Akamai fork of openssl master.","fork":true,"url":"https://api.github.com/repos/akamai/openssl","forks_url":"https://api.github.com/repos/akamai/openssl/forks","keys_url":"https://api.github.com/repos/akamai/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akamai/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akamai/openssl/teams","hooks_url":"https://api.github.com/repos/akamai/openssl/hooks","issue_events_url":"https://api.github.com/repos/akamai/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/akamai/openssl/events","assignees_url":"https://api.github.com/repos/akamai/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/akamai/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/akamai/openssl/tags","blobs_url":"https://api.github.com/repos/akamai/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akamai/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akamai/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/akamai/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akamai/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/akamai/openssl/languages","stargazers_url":"https://api.github.com/repos/akamai/openssl/stargazers","contributors_url":"https://api.github.com/repos/akamai/openssl/contributors","subscribers_url":"https://api.github.com/repos/akamai/openssl/subscribers","subscription_url":"https://api.github.com/repos/akamai/openssl/subscription","commits_url":"https://api.github.com/repos/akamai/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/akamai/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/akamai/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/akamai/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/akamai/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/akamai/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akamai/openssl/merges","archive_url":"https://api.github.com/repos/akamai/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akamai/openssl/downloads","issues_url":"https://api.github.com/repos/akamai/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/akamai/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/akamai/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/akamai/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akamai/openssl/labels{/name}","releases_url":"https://api.github.com/repos/akamai/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/akamai/openssl/deployments","created_at":"2014-05-09T14:50:18Z","updated_at":"2016-01-12T00:11:46Z","pushed_at":"2016-06-08T14:29:20Z","git_url":"git://github.com/akamai/openssl.git","ssh_url":"git@github.com:akamai/openssl.git","clone_url":"https://github.com/akamai/openssl.git","svn_url":"https://github.com/akamai/openssl","homepage":"","size":101351,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"2ee65a672fe18fe275cf7ac1f86e8723ee38ebdc","user":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2016-06-08T07:10:47Z","pushed_at":"2016-06-08T14:32:00Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":107253,"stargazers_count":2734,"watchers_count":2734,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1567,"mirror_url":null,"open_issues_count":113,"forks":1567,"open_issues":113,"watchers":2734,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1098"},"html":{"href":"https://github.com/openssl/openssl/pull/1098"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/1098"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/1098/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1098/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/1098/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/4fcd80d764642dfabd16822e4cc9e0e41334e126"}}}}
{"actor":{"display_login":"ekasper"}}