{"action":"created","issue":{"url":"https://api.github.com/repos/dotpay/PrestaShop/issues/5","repository_url":"https://api.github.com/repos/dotpay/PrestaShop","labels_url":"https://api.github.com/repos/dotpay/PrestaShop/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/dotpay/PrestaShop/issues/5/comments","events_url":"https://api.github.com/repos/dotpay/PrestaShop/issues/5/events","html_url":"https://github.com/dotpay/PrestaShop/pull/5","id":195187366,"number":5,"title":"Ensure extra charge virtual product availability","user":{"login":"jmarceli","id":4281333,"avatar_url":"https://avatars.githubusercontent.com/u/4281333?v=3","gravatar_id":"","url":"https://api.github.com/users/jmarceli","html_url":"https://github.com/jmarceli","followers_url":"https://api.github.com/users/jmarceli/followers","following_url":"https://api.github.com/users/jmarceli/following{/other_user}","gists_url":"https://api.github.com/users/jmarceli/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarceli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarceli/subscriptions","organizations_url":"https://api.github.com/users/jmarceli/orgs","repos_url":"https://api.github.com/users/jmarceli/repos","events_url":"https://api.github.com/users/jmarceli/events{/privacy}","received_events_url":"https://api.github.com/users/jmarceli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"tbajorek","id":11332657,"avatar_url":"https://avatars.githubusercontent.com/u/11332657?v=3","gravatar_id":"","url":"https://api.github.com/users/tbajorek","html_url":"https://github.com/tbajorek","followers_url":"https://api.github.com/users/tbajorek/followers","following_url":"https://api.github.com/users/tbajorek/following{/other_user}","gists_url":"https://api.github.com/users/tbajorek/gists{/gist_id}","starred_url":"https://api.github.com/users/tbajorek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbajorek/subscriptions","organizations_url":"https://api.github.com/users/tbajorek/orgs","repos_url":"https://api.github.com/users/tbajorek/repos","events_url":"https://api.github.com/users/tbajorek/events{/privacy}","received_events_url":"https://api.github.com/users/tbajorek/received_events","type":"User","site_admin":false},"assignees":[{"login":"tbajorek","id":11332657,"avatar_url":"https://avatars.githubusercontent.com/u/11332657?v=3","gravatar_id":"","url":"https://api.github.com/users/tbajorek","html_url":"https://github.com/tbajorek","followers_url":"https://api.github.com/users/tbajorek/followers","following_url":"https://api.github.com/users/tbajorek/following{/other_user}","gists_url":"https://api.github.com/users/tbajorek/gists{/gist_id}","starred_url":"https://api.github.com/users/tbajorek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbajorek/subscriptions","organizations_url":"https://api.github.com/users/tbajorek/orgs","repos_url":"https://api.github.com/users/tbajorek/repos","events_url":"https://api.github.com/users/tbajorek/events{/privacy}","received_events_url":"https://api.github.com/users/tbajorek/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-12-13T08:11:26Z","updated_at":"2016-12-13T11:23:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotpay/PrestaShop/pulls/5","html_url":"https://github.com/dotpay/PrestaShop/pull/5","diff_url":"https://github.com/dotpay/PrestaShop/pull/5.diff","patch_url":"https://github.com/dotpay/PrestaShop/pull/5.patch"},"body":"Fixes possible bugs in multistore configuration caused by empty link_rewrite, name, available_for_order and more.\r\n\r\nThere were some bugs in current module version which causes 500 error when multistore configuration is activated.\r\nIn order to reproduce this bugs install and activate module in normal single store and then add multistore."},"comment":{"url":"https://api.github.com/repos/dotpay/PrestaShop/issues/comments/266713908","html_url":"https://github.com/dotpay/PrestaShop/pull/5#issuecomment-266713908","issue_url":"https://api.github.com/repos/dotpay/PrestaShop/issues/5","id":266713908,"user":{"login":"tbajorek","id":11332657,"avatar_url":"https://avatars.githubusercontent.com/u/11332657?v=3","gravatar_id":"","url":"https://api.github.com/users/tbajorek","html_url":"https://github.com/tbajorek","followers_url":"https://api.github.com/users/tbajorek/followers","following_url":"https://api.github.com/users/tbajorek/following{/other_user}","gists_url":"https://api.github.com/users/tbajorek/gists{/gist_id}","starred_url":"https://api.github.com/users/tbajorek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbajorek/subscriptions","organizations_url":"https://api.github.com/users/tbajorek/orgs","repos_url":"https://api.github.com/users/tbajorek/repos","events_url":"https://api.github.com/users/tbajorek/events{/privacy}","received_events_url":"https://api.github.com/users/tbajorek/received_events","type":"User","site_admin":false},"created_at":"2016-12-13T11:23:12Z","updated_at":"2016-12-13T11:23:12Z","body":"Ok, I understand it. So I think that it would be better to use an existing function from main class of Dotpay module. It could be a public method and after a check that the product data is incomplete, that function could fill an incomplete data, without creating a new product. i think that an improvement of the method addDotpayVirtualProduct() could allow us to not duplicate our code."}}
{"actor":{"display_login":"tbajorek"}}