{"action":"closed","number":2907,"pull_request":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/2907","id":55822102,"html_url":"https://github.com/callemall/material-ui/pull/2907","diff_url":"https://github.com/callemall/material-ui/pull/2907.diff","patch_url":"https://github.com/callemall/material-ui/pull/2907.patch","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/2907","number":2907,"state":"closed","locked":false,"title":"[Core] Initial style refactor","user":{"login":"newoga","id":344018,"avatar_url":"https://avatars.githubusercontent.com/u/344018?v=3","gravatar_id":"","url":"https://api.github.com/users/newoga","html_url":"https://github.com/newoga","followers_url":"https://api.github.com/users/newoga/followers","following_url":"https://api.github.com/users/newoga/following{/other_user}","gists_url":"https://api.github.com/users/newoga/gists{/gist_id}","starred_url":"https://api.github.com/users/newoga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newoga/subscriptions","organizations_url":"https://api.github.com/users/newoga/orgs","repos_url":"https://api.github.com/users/newoga/repos","events_url":"https://api.github.com/users/newoga/events{/privacy}","received_events_url":"https://api.github.com/users/newoga/received_events","type":"User","site_admin":false},"body":"@oliviertassinari @alitaheri \r\n\r\nThis is the start of some of the refactors that I wanted to do, but there is still more. So far I've done the following:\r\n\r\nSimplifies style utilities and removes utils/immutability-helper.js\r\n\r\nThis commit includes a number of changes:\r\n\r\n1. Removes all apply() calls in favor of argument destructuring\r\n2. Simplifies `style-propable` mixin to import/wrap solely from `utils/styles`\r\n3. Search the code base for components that used `utils/immutability-helper` and replaced it with `utils/styles/mergeStyles` or `react-addons-update`\r\n4. Removed `utils/immutability-helper` from src\r\n5. Renamed `utils/styles` merge() to mergeStyles()\r\n6. Prepared deprecation of passing more than one style to `prepareStyles()` (it is imlemented but commented)\r\n7. Fixed all components that are dependent on `utils/styles` to follow new convention (do not import `utils/styles` default export to a `styleUtils` object, just import the method you need)\r\n\r\n**Todo:**\r\n1. Refactor/cleanup `ensureDirection`\r\n2. Decide on whether to use `mergeStyles` or use spread operators in components\r\n3. Investigate opportunities for memoization","created_at":"2016-01-12T21:48:04Z","updated_at":"2016-01-14T16:35:21Z","closed_at":"2016-01-14T16:35:21Z","merged_at":"2016-01-14T16:35:21Z","merge_commit_sha":"862fa33d23095923f1c480a4e364075d8b5ba771","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/callemall/material-ui/pulls/2907/commits","review_comments_url":"https://api.github.com/repos/callemall/material-ui/pulls/2907/comments","review_comment_url":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/2907/comments","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/5ec947fbcc0b81b7c13015e0404f8b8a715e1a17","head":{"label":"newoga:style-refactor","ref":"style-refactor","sha":"5ec947fbcc0b81b7c13015e0404f8b8a715e1a17","user":{"login":"newoga","id":344018,"avatar_url":"https://avatars.githubusercontent.com/u/344018?v=3","gravatar_id":"","url":"https://api.github.com/users/newoga","html_url":"https://github.com/newoga","followers_url":"https://api.github.com/users/newoga/followers","following_url":"https://api.github.com/users/newoga/following{/other_user}","gists_url":"https://api.github.com/users/newoga/gists{/gist_id}","starred_url":"https://api.github.com/users/newoga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newoga/subscriptions","organizations_url":"https://api.github.com/users/newoga/orgs","repos_url":"https://api.github.com/users/newoga/repos","events_url":"https://api.github.com/users/newoga/events{/privacy}","received_events_url":"https://api.github.com/users/newoga/received_events","type":"User","site_admin":false},"repo":{"id":47232679,"name":"material-ui","full_name":"newoga/material-ui","owner":{"login":"newoga","id":344018,"avatar_url":"https://avatars.githubusercontent.com/u/344018?v=3","gravatar_id":"","url":"https://api.github.com/users/newoga","html_url":"https://github.com/newoga","followers_url":"https://api.github.com/users/newoga/followers","following_url":"https://api.github.com/users/newoga/following{/other_user}","gists_url":"https://api.github.com/users/newoga/gists{/gist_id}","starred_url":"https://api.github.com/users/newoga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newoga/subscriptions","organizations_url":"https://api.github.com/users/newoga/orgs","repos_url":"https://api.github.com/users/newoga/repos","events_url":"https://api.github.com/users/newoga/events{/privacy}","received_events_url":"https://api.github.com/users/newoga/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/newoga/material-ui","description":"React Components that Implement Google's Material Design.","fork":true,"url":"https://api.github.com/repos/newoga/material-ui","forks_url":"https://api.github.com/repos/newoga/material-ui/forks","keys_url":"https://api.github.com/repos/newoga/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newoga/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newoga/material-ui/teams","hooks_url":"https://api.github.com/repos/newoga/material-ui/hooks","issue_events_url":"https://api.github.com/repos/newoga/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/newoga/material-ui/events","assignees_url":"https://api.github.com/repos/newoga/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/newoga/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/newoga/material-ui/tags","blobs_url":"https://api.github.com/repos/newoga/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newoga/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newoga/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/newoga/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newoga/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/newoga/material-ui/languages","stargazers_url":"https://api.github.com/repos/newoga/material-ui/stargazers","contributors_url":"https://api.github.com/repos/newoga/material-ui/contributors","subscribers_url":"https://api.github.com/repos/newoga/material-ui/subscribers","subscription_url":"https://api.github.com/repos/newoga/material-ui/subscription","commits_url":"https://api.github.com/repos/newoga/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/newoga/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/newoga/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/newoga/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/newoga/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/newoga/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newoga/material-ui/merges","archive_url":"https://api.github.com/repos/newoga/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newoga/material-ui/downloads","issues_url":"https://api.github.com/repos/newoga/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/newoga/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/newoga/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/newoga/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newoga/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/newoga/material-ui/releases{/id}","created_at":"2015-12-02T02:48:02Z","updated_at":"2015-12-02T02:48:07Z","pushed_at":"2016-01-14T14:44:55Z","git_url":"git://github.com/newoga/material-ui.git","ssh_url":"git@github.com:newoga/material-ui.git","clone_url":"https://github.com/newoga/material-ui.git","svn_url":"https://github.com/newoga/material-ui","homepage":"http://www.material-ui.com","size":35373,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"callemall:master","ref":"master","sha":"3b701fdd78a3c253f14773dc4e94ecb6e73fc971","user":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"repo":{"id":23083156,"name":"material-ui","full_name":"callemall/material-ui","owner":{"login":"callemall","id":1262264,"avatar_url":"https://avatars.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callemall/material-ui","description":"React Components that Implement Google's Material Design.","fork":false,"url":"https://api.github.com/repos/callemall/material-ui","forks_url":"https://api.github.com/repos/callemall/material-ui/forks","keys_url":"https://api.github.com/repos/callemall/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callemall/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callemall/material-ui/teams","hooks_url":"https://api.github.com/repos/callemall/material-ui/hooks","issue_events_url":"https://api.github.com/repos/callemall/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/callemall/material-ui/events","assignees_url":"https://api.github.com/repos/callemall/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/callemall/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/callemall/material-ui/tags","blobs_url":"https://api.github.com/repos/callemall/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callemall/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callemall/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/callemall/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/callemall/material-ui/languages","stargazers_url":"https://api.github.com/repos/callemall/material-ui/stargazers","contributors_url":"https://api.github.com/repos/callemall/material-ui/contributors","subscribers_url":"https://api.github.com/repos/callemall/material-ui/subscribers","subscription_url":"https://api.github.com/repos/callemall/material-ui/subscription","commits_url":"https://api.github.com/repos/callemall/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/callemall/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/callemall/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/callemall/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/callemall/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/callemall/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callemall/material-ui/merges","archive_url":"https://api.github.com/repos/callemall/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callemall/material-ui/downloads","issues_url":"https://api.github.com/repos/callemall/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/callemall/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/callemall/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/callemall/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callemall/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/callemall/material-ui/releases{/id}","created_at":"2014-08-18T19:11:54Z","updated_at":"2016-01-14T16:29:31Z","pushed_at":"2016-01-14T16:35:22Z","git_url":"git://github.com/callemall/material-ui.git","ssh_url":"git@github.com:callemall/material-ui.git","clone_url":"https://github.com/callemall/material-ui.git","svn_url":"https://github.com/callemall/material-ui","homepage":"http://www.material-ui.com","size":45307,"stargazers_count":13072,"watchers_count":13072,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2137,"mirror_url":null,"open_issues_count":502,"forks":2137,"open_issues":502,"watchers":13072,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/2907"},"html":{"href":"https://github.com/callemall/material-ui/pull/2907"},"issue":{"href":"https://api.github.com/repos/callemall/material-ui/issues/2907"},"comments":{"href":"https://api.github.com/repos/callemall/material-ui/issues/2907/comments"},"review_comments":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/2907/comments"},"review_comment":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/2907/commits"},"statuses":{"href":"https://api.github.com/repos/callemall/material-ui/statuses/5ec947fbcc0b81b7c13015e0404f8b8a715e1a17"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"oliviertassinari","id":3165635,"avatar_url":"https://avatars.githubusercontent.com/u/3165635?v=3","gravatar_id":"","url":"https://api.github.com/users/oliviertassinari","html_url":"https://github.com/oliviertassinari","followers_url":"https://api.github.com/users/oliviertassinari/followers","following_url":"https://api.github.com/users/oliviertassinari/following{/other_user}","gists_url":"https://api.github.com/users/oliviertassinari/gists{/gist_id}","starred_url":"https://api.github.com/users/oliviertassinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliviertassinari/subscriptions","organizations_url":"https://api.github.com/users/oliviertassinari/orgs","repos_url":"https://api.github.com/users/oliviertassinari/repos","events_url":"https://api.github.com/users/oliviertassinari/events{/privacy}","received_events_url":"https://api.github.com/users/oliviertassinari/received_events","type":"User","site_admin":false},"comments":11,"review_comments":0,"commits":1,"additions":104,"deletions":107,"changed_files":13}}