{"action":"created","comment":{"url":"https://api.github.com/repos/OCA/server-tools/pulls/comments/79135543","id":79135543,"diff_hunk":"@@ -53,104 +62,106 @@ def _default_model1_id(self):\n         \"\"\"Default model depending on context.\"\"\"\n         return self.env.context.get(\"default_model1_id\", False)\n \n-    @api.multi\n-    @api.depends(\"field1_id\", \"field2_id\", \"field3_id\")\n+    @api.one","path":"base_export_manager/models/ir_exports_line.py","position":36,"original_position":36,"commit_id":"ee91e4e5ba94cd76467f782aaa5ccbeb349ac5fb","original_commit_id":"ee91e4e5ba94cd76467f782aaa5ccbeb349ac5fb","user":{"login":"pedrobaeza","id":7165771,"avatar_url":"https://avatars.githubusercontent.com/u/7165771?v=3","gravatar_id":"","url":"https://api.github.com/users/pedrobaeza","html_url":"https://github.com/pedrobaeza","followers_url":"https://api.github.com/users/pedrobaeza/followers","following_url":"https://api.github.com/users/pedrobaeza/following{/other_user}","gists_url":"https://api.github.com/users/pedrobaeza/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrobaeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrobaeza/subscriptions","organizations_url":"https://api.github.com/users/pedrobaeza/orgs","repos_url":"https://api.github.com/users/pedrobaeza/repos","events_url":"https://api.github.com/users/pedrobaeza/events{/privacy}","received_events_url":"https://api.github.com/users/pedrobaeza/received_events","type":"User","site_admin":false},"body":"No, there's no work needed. `@api.one` is still in v9, v10, and counting.","created_at":"2016-09-16T09:31:17Z","updated_at":"2016-09-16T09:31:17Z","html_url":"https://github.com/OCA/server-tools/pull/521#discussion_r79135543","pull_request_url":"https://api.github.com/repos/OCA/server-tools/pulls/521","_links":{"self":{"href":"https://api.github.com/repos/OCA/server-tools/pulls/comments/79135543"},"html":{"href":"https://github.com/OCA/server-tools/pull/521#discussion_r79135543"},"pull_request":{"href":"https://api.github.com/repos/OCA/server-tools/pulls/521"}}},"pull_request":{"url":"https://api.github.com/repos/OCA/server-tools/pulls/521","id":81606970,"html_url":"https://github.com/OCA/server-tools/pull/521","diff_url":"https://github.com/OCA/server-tools/pull/521.diff","patch_url":"https://github.com/OCA/server-tools/pull/521.patch","issue_url":"https://api.github.com/repos/OCA/server-tools/issues/521","number":521,"state":"open","locked":false,"title":"[FIX][base_export_manager] Fix \"Expected singleton\" bug.","user":{"login":"Yajo","id":973709,"avatar_url":"https://avatars.githubusercontent.com/u/973709?v=3","gravatar_id":"","url":"https://api.github.com/users/Yajo","html_url":"https://github.com/Yajo","followers_url":"https://api.github.com/users/Yajo/followers","following_url":"https://api.github.com/users/Yajo/following{/other_user}","gists_url":"https://api.github.com/users/Yajo/gists{/gist_id}","starred_url":"https://api.github.com/users/Yajo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yajo/subscriptions","organizations_url":"https://api.github.com/users/Yajo/orgs","repos_url":"https://api.github.com/users/Yajo/repos","events_url":"https://api.github.com/users/Yajo/events{/privacy}","received_events_url":"https://api.github.com/users/Yajo/received_events","type":"User","site_admin":false},"body":"If you had a field that got translated in more than 1 addon, you'd possibly get\r\nto this error:\r\n\r\n      File \"/opt/odoo/0079_ahk_openerp/oca/base_export_manager/models/ir_exports_line.py\", line 105, in _compute_label\r\n        field.name)),\r\n      File \"/opt/odoo/common/openerp/v8/openerp/fields.py\", line 825, in __get__\r\n        record.ensure_one()\r\n      File \"/opt/odoo/common/openerp/v8/openerp/models.py\", line 5355, in ensure_one\r\n        raise except_orm(\"ValueError\", \"Expected singleton: %s\" % self)\r\n    except_orm: ('ValueError', 'Expected singleton: ir.translation(4899, 703976)')\r\n\r\nWith this patch, now we let Odoo return the translated string by using its\r\nstandard method to do so, so we have to care for less.\r\n\r\n@Tecnativa\r\n","created_at":"2016-08-17T09:02:58Z","updated_at":"2016-09-16T09:31:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4a0d430b7b8ef9b81d9bc6aa35b5e670f179322","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/OCA/server-tools/milestones/3","html_url":"https://github.com/OCA/server-tools/milestones/8.0","labels_url":"https://api.github.com/repos/OCA/server-tools/milestones/3/labels","id":983662,"number":3,"title":"8.0","description":"","creator":{"login":"max3903","id":939952,"avatar_url":"https://avatars.githubusercontent.com/u/939952?v=3","gravatar_id":"","url":"https://api.github.com/users/max3903","html_url":"https://github.com/max3903","followers_url":"https://api.github.com/users/max3903/followers","following_url":"https://api.github.com/users/max3903/following{/other_user}","gists_url":"https://api.github.com/users/max3903/gists{/gist_id}","starred_url":"https://api.github.com/users/max3903/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/max3903/subscriptions","organizations_url":"https://api.github.com/users/max3903/orgs","repos_url":"https://api.github.com/users/max3903/repos","events_url":"https://api.github.com/users/max3903/events{/privacy}","received_events_url":"https://api.github.com/users/max3903/received_events","type":"User","site_admin":false},"open_issues":44,"closed_issues":81,"state":"open","created_at":"2015-02-17T21:52:00Z","updated_at":"2016-09-16T09:15:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/OCA/server-tools/pulls/521/commits","review_comments_url":"https://api.github.com/repos/OCA/server-tools/pulls/521/comments","review_comment_url":"https://api.github.com/repos/OCA/server-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/server-tools/issues/521/comments","statuses_url":"https://api.github.com/repos/OCA/server-tools/statuses/ee91e4e5ba94cd76467f782aaa5ccbeb349ac5fb","head":{"label":"Tecnativa:8.0-base_export_manager-fix_singleton_error","ref":"8.0-base_export_manager-fix_singleton_error","sha":"ee91e4e5ba94cd76467f782aaa5ccbeb349ac5fb","user":{"login":"Tecnativa","id":18120193,"avatar_url":"https://avatars.githubusercontent.com/u/18120193?v=3","gravatar_id":"","url":"https://api.github.com/users/Tecnativa","html_url":"https://github.com/Tecnativa","followers_url":"https://api.github.com/users/Tecnativa/followers","following_url":"https://api.github.com/users/Tecnativa/following{/other_user}","gists_url":"https://api.github.com/users/Tecnativa/gists{/gist_id}","starred_url":"https://api.github.com/users/Tecnativa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tecnativa/subscriptions","organizations_url":"https://api.github.com/users/Tecnativa/orgs","repos_url":"https://api.github.com/users/Tecnativa/repos","events_url":"https://api.github.com/users/Tecnativa/events{/privacy}","received_events_url":"https://api.github.com/users/Tecnativa/received_events","type":"Organization","site_admin":false},"repo":{"id":58931886,"name":"server-tools","full_name":"Tecnativa/server-tools","owner":{"login":"Tecnativa","id":18120193,"avatar_url":"https://avatars.githubusercontent.com/u/18120193?v=3","gravatar_id":"","url":"https://api.github.com/users/Tecnativa","html_url":"https://github.com/Tecnativa","followers_url":"https://api.github.com/users/Tecnativa/followers","following_url":"https://api.github.com/users/Tecnativa/following{/other_user}","gists_url":"https://api.github.com/users/Tecnativa/gists{/gist_id}","starred_url":"https://api.github.com/users/Tecnativa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tecnativa/subscriptions","organizations_url":"https://api.github.com/users/Tecnativa/orgs","repos_url":"https://api.github.com/users/Tecnativa/repos","events_url":"https://api.github.com/users/Tecnativa/events{/privacy}","received_events_url":"https://api.github.com/users/Tecnativa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Tecnativa/server-tools","description":"Tools for Odoo Administrators to improve some technical features on Odoo.","fork":true,"url":"https://api.github.com/repos/Tecnativa/server-tools","forks_url":"https://api.github.com/repos/Tecnativa/server-tools/forks","keys_url":"https://api.github.com/repos/Tecnativa/server-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tecnativa/server-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tecnativa/server-tools/teams","hooks_url":"https://api.github.com/repos/Tecnativa/server-tools/hooks","issue_events_url":"https://api.github.com/repos/Tecnativa/server-tools/issues/events{/number}","events_url":"https://api.github.com/repos/Tecnativa/server-tools/events","assignees_url":"https://api.github.com/repos/Tecnativa/server-tools/assignees{/user}","branches_url":"https://api.github.com/repos/Tecnativa/server-tools/branches{/branch}","tags_url":"https://api.github.com/repos/Tecnativa/server-tools/tags","blobs_url":"https://api.github.com/repos/Tecnativa/server-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tecnativa/server-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tecnativa/server-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tecnativa/server-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tecnativa/server-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Tecnativa/server-tools/languages","stargazers_url":"https://api.github.com/repos/Tecnativa/server-tools/stargazers","contributors_url":"https://api.github.com/repos/Tecnativa/server-tools/contributors","subscribers_url":"https://api.github.com/repos/Tecnativa/server-tools/subscribers","subscription_url":"https://api.github.com/repos/Tecnativa/server-tools/subscription","commits_url":"https://api.github.com/repos/Tecnativa/server-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tecnativa/server-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tecnativa/server-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tecnativa/server-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tecnativa/server-tools/contents/{+path}","compare_url":"https://api.github.com/repos/Tecnativa/server-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tecnativa/server-tools/merges","archive_url":"https://api.github.com/repos/Tecnativa/server-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tecnativa/server-tools/downloads","issues_url":"https://api.github.com/repos/Tecnativa/server-tools/issues{/number}","pulls_url":"https://api.github.com/repos/Tecnativa/server-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Tecnativa/server-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Tecnativa/server-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tecnativa/server-tools/labels{/name}","releases_url":"https://api.github.com/repos/Tecnativa/server-tools/releases{/id}","deployments_url":"https://api.github.com/repos/Tecnativa/server-tools/deployments","created_at":"2016-05-16T12:48:36Z","updated_at":"2016-05-16T12:48:39Z","pushed_at":"2016-09-15T14:57:55Z","git_url":"git://github.com/Tecnativa/server-tools.git","ssh_url":"git@github.com:Tecnativa/server-tools.git","clone_url":"https://github.com/Tecnativa/server-tools.git","svn_url":"https://github.com/Tecnativa/server-tools","homepage":"https://odoo-community.org/project/tools-maintainers-30","size":5782,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"9.0"}},"base":{"label":"OCA:8.0","ref":"8.0","sha":"e6b3372f8452986c615aa034fc3e56835d7e2406","user":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":20896532,"name":"server-tools","full_name":"OCA/server-tools","owner":{"login":"OCA","id":7600578,"avatar_url":"https://avatars.githubusercontent.com/u/7600578?v=3","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OCA/server-tools","description":"Tools for Odoo Administrators to improve some technical features on Odoo.","fork":false,"url":"https://api.github.com/repos/OCA/server-tools","forks_url":"https://api.github.com/repos/OCA/server-tools/forks","keys_url":"https://api.github.com/repos/OCA/server-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/server-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/server-tools/teams","hooks_url":"https://api.github.com/repos/OCA/server-tools/hooks","issue_events_url":"https://api.github.com/repos/OCA/server-tools/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/server-tools/events","assignees_url":"https://api.github.com/repos/OCA/server-tools/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/server-tools/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/server-tools/tags","blobs_url":"https://api.github.com/repos/OCA/server-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/server-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/server-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/server-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/server-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/server-tools/languages","stargazers_url":"https://api.github.com/repos/OCA/server-tools/stargazers","contributors_url":"https://api.github.com/repos/OCA/server-tools/contributors","subscribers_url":"https://api.github.com/repos/OCA/server-tools/subscribers","subscription_url":"https://api.github.com/repos/OCA/server-tools/subscription","commits_url":"https://api.github.com/repos/OCA/server-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/server-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/server-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/server-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/server-tools/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/server-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/server-tools/merges","archive_url":"https://api.github.com/repos/OCA/server-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/server-tools/downloads","issues_url":"https://api.github.com/repos/OCA/server-tools/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/server-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/server-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/server-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/server-tools/labels{/name}","releases_url":"https://api.github.com/repos/OCA/server-tools/releases{/id}","deployments_url":"https://api.github.com/repos/OCA/server-tools/deployments","created_at":"2014-06-16T18:52:44Z","updated_at":"2016-09-14T19:08:59Z","pushed_at":"2016-09-16T09:13:19Z","git_url":"git://github.com/OCA/server-tools.git","ssh_url":"git@github.com:OCA/server-tools.git","clone_url":"https://github.com/OCA/server-tools.git","svn_url":"https://github.com/OCA/server-tools","homepage":"https://odoo-community.org/project/tools-maintainers-30","size":14348,"stargazers_count":127,"watchers_count":127,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":369,"mirror_url":null,"open_issues_count":132,"forks":369,"open_issues":132,"watchers":127,"default_branch":"9.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/server-tools/pulls/521"},"html":{"href":"https://github.com/OCA/server-tools/pull/521"},"issue":{"href":"https://api.github.com/repos/OCA/server-tools/issues/521"},"comments":{"href":"https://api.github.com/repos/OCA/server-tools/issues/521/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/server-tools/pulls/521/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/server-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/server-tools/pulls/521/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/server-tools/statuses/ee91e4e5ba94cd76467f782aaa5ccbeb349ac5fb"}}}}
{"actor":{"display_login":"pedrobaeza"}}