{"action":"created","issue":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/3554","repository_url":"https://api.github.com/repos/mne-tools/mne-python","labels_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3554/labels{/name}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3554/comments","events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3554/events","html_url":"https://github.com/mne-tools/mne-python/issues/3554","id":174487128,"number":3554,"title":"find_events fails on TRIUX data with legacy stim channels","user":{"login":"jjnurminen","id":8491321,"avatar_url":"https://avatars.githubusercontent.com/u/8491321?v=3","gravatar_id":"","url":"https://api.github.com/users/jjnurminen","html_url":"https://github.com/jjnurminen","followers_url":"https://api.github.com/users/jjnurminen/followers","following_url":"https://api.github.com/users/jjnurminen/following{/other_user}","gists_url":"https://api.github.com/users/jjnurminen/gists{/gist_id}","starred_url":"https://api.github.com/users/jjnurminen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjnurminen/subscriptions","organizations_url":"https://api.github.com/users/jjnurminen/orgs","repos_url":"https://api.github.com/users/jjnurminen/repos","events_url":"https://api.github.com/users/jjnurminen/events{/privacy}","received_events_url":"https://api.github.com/users/jjnurminen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-01T10:17:06Z","updated_at":"2016-09-01T17:29:35Z","closed_at":null,"body":"Not sure if this is a bug or not, but I think the situation could be improved.\r\n\r\nTypically Elekta TRIUX (and recent Vectorview?) systems record triggers only on the digitally coded channel STI101, which contains all trigger information. However, in the data acquisition, there is a possibility of also acquiring 'legacy' trigger channels STI001, STI002, etc. These are binary channels which indicate the corresponding trigger channel being on/off. The main reason for acquiring these would be to support legacy software that does not understand STI101.\r\n\r\nThe problem is that `mne.find_events` fails (does not find any events) for raw files that contain both STI101 and the legacy channels, because it regards all of them as stim channels and considers them simultaneously. Setting `stim_channel=STI101` remedies the situation. I think an easy solution would be to always use STI101 if it exists, and disregard the legacy channels.\r\n\r\n(In some setups, the trigger channel STI201 is also used separately, enabling 32 trigger lines. However this is a rare use case, so I think it doesn't need to be considered by default. Usually STI101 and STI201 are mirrored, i.e. contain identical information.)\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments/244151649","html_url":"https://github.com/mne-tools/mne-python/issues/3554#issuecomment-244151649","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3554","id":244151649,"user":{"login":"jjnurminen","id":8491321,"avatar_url":"https://avatars.githubusercontent.com/u/8491321?v=3","gravatar_id":"","url":"https://api.github.com/users/jjnurminen","html_url":"https://github.com/jjnurminen","followers_url":"https://api.github.com/users/jjnurminen/followers","following_url":"https://api.github.com/users/jjnurminen/following{/other_user}","gists_url":"https://api.github.com/users/jjnurminen/gists{/gist_id}","starred_url":"https://api.github.com/users/jjnurminen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjnurminen/subscriptions","organizations_url":"https://api.github.com/users/jjnurminen/orgs","repos_url":"https://api.github.com/users/jjnurminen/repos","events_url":"https://api.github.com/users/jjnurminen/events{/privacy}","received_events_url":"https://api.github.com/users/jjnurminen/received_events","type":"User","site_admin":false},"created_at":"2016-09-01T17:29:34Z","updated_at":"2016-09-01T17:29:34Z","body":"I already wrote a small patch but it ended up into the wrong branch and my\nattempt at cherry-picking failed. (insert tearful emoji)\n\nOn 1 Sep 2016 7:27 p.m., \"Eric Larson\" <notifications@github.com> wrote:\n\n> Yeah it should try STI 014, STI101, then whatever it does now.\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/mne-tools/mne-python/issues/3554#issuecomment-244134459>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AIGROXJMXpTWFf7w04fItLLxjfzMLyYvks5qlvztgaJpZM4JyiFo>\n> .\n>\n"}}
{"actor":{"display_login":"jjnurminen"}}