{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/79808196","id":79808196,"diff_hunk":"@@ -61,6 +61,10 @@ struct dac_s {\n     DACName dac;\n };\n \n+struct rng_s {","path":"hal/targets/hal/TARGET_Freescale/TARGET_KSDK2_MCUS/api/objects.h","position":4,"original_position":4,"commit_id":"a34b413124719b1738f89ed908ccc7734ce28bc1","original_commit_id":"a34b413124719b1738f89ed908ccc7734ce28bc1","user":{"login":"andresag01","id":3746901,"avatar_url":"https://avatars.githubusercontent.com/u/3746901?v=3","gravatar_id":"","url":"https://api.github.com/users/andresag01","html_url":"https://github.com/andresag01","followers_url":"https://api.github.com/users/andresag01/followers","following_url":"https://api.github.com/users/andresag01/following{/other_user}","gists_url":"https://api.github.com/users/andresag01/gists{/gist_id}","starred_url":"https://api.github.com/users/andresag01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresag01/subscriptions","organizations_url":"https://api.github.com/users/andresag01/orgs","repos_url":"https://api.github.com/users/andresag01/repos","events_url":"https://api.github.com/users/andresag01/events{/privacy}","received_events_url":"https://api.github.com/users/andresag01/received_events","type":"User","site_admin":false},"body":"I understand why mbedtls has a `void *` as a first parameter. Indeed, the API should even work when the value of the parameter is `NULL`. However, I am not entirely sure why this API has a first parameter which is a completely empty structure. Perhaps, at least there should be a way to tell whether it has been initialised or something like this?","created_at":"2016-09-21T11:03:13Z","updated_at":"2016-09-21T11:12:57Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/2765#discussion_r79808196","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/2765","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/79808196"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/2765#discussion_r79808196"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/2765"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/2765","id":86120388,"html_url":"https://github.com/ARMmbed/mbed-os/pull/2765","diff_url":"https://github.com/ARMmbed/mbed-os/pull/2765.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/2765.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/2765","number":2765,"state":"open","locked":false,"title":"RNG HAL addition","user":{"login":"0xc0170","id":2963726,"avatar_url":"https://avatars.githubusercontent.com/u/2963726?v=3","gravatar_id":"","url":"https://api.github.com/users/0xc0170","html_url":"https://github.com/0xc0170","followers_url":"https://api.github.com/users/0xc0170/followers","following_url":"https://api.github.com/users/0xc0170/following{/other_user}","gists_url":"https://api.github.com/users/0xc0170/gists{/gist_id}","starred_url":"https://api.github.com/users/0xc0170/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xc0170/subscriptions","organizations_url":"https://api.github.com/users/0xc0170/orgs","repos_url":"https://api.github.com/users/0xc0170/repos","events_url":"https://api.github.com/users/0xc0170/events{/privacy}","received_events_url":"https://api.github.com/users/0xc0170/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nAdd RNG HAL API + mbedtls wrapper to use it. There are 4 functions, 3 are implemented for all targets (port from the old implementation to the new one):\r\n\r\n- init\r\n- free\r\n- get random numbers\r\n- set seed (this one is just a proposal, would like to get your feedback, and I'll port it for all targets)\r\n\r\n## Status\r\n**IN DEVELOPMENT**\r\n\r\n## Todos\r\n- [ ] Tests\r\n- [ ] Review by mbedtls team\r\n\r\n@sg- @sbutcher-arm @andresag01 @yanesca @pjbakker - please review\r\n","created_at":"2016-09-21T08:45:32Z","updated_at":"2016-09-21T11:12:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3af4b1590c1bbd7315ba14aa1f5cf9c4d7558bfc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/2765/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/2765/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/2765/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/a34b413124719b1738f89ed908ccc7734ce28bc1","head":{"label":"0xc0170:dev_rng_hal","ref":"dev_rng_hal","sha":"a34b413124719b1738f89ed908ccc7734ce28bc1","user":{"login":"0xc0170","id":2963726,"avatar_url":"https://avatars.githubusercontent.com/u/2963726?v=3","gravatar_id":"","url":"https://api.github.com/users/0xc0170","html_url":"https://github.com/0xc0170","followers_url":"https://api.github.com/users/0xc0170/followers","following_url":"https://api.github.com/users/0xc0170/following{/other_user}","gists_url":"https://api.github.com/users/0xc0170/gists{/gist_id}","starred_url":"https://api.github.com/users/0xc0170/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xc0170/subscriptions","organizations_url":"https://api.github.com/users/0xc0170/orgs","repos_url":"https://api.github.com/users/0xc0170/repos","events_url":"https://api.github.com/users/0xc0170/events{/privacy}","received_events_url":"https://api.github.com/users/0xc0170/received_events","type":"User","site_admin":false},"repo":{"id":10604206,"name":"mbed","full_name":"0xc0170/mbed","owner":{"login":"0xc0170","id":2963726,"avatar_url":"https://avatars.githubusercontent.com/u/2963726?v=3","gravatar_id":"","url":"https://api.github.com/users/0xc0170","html_url":"https://github.com/0xc0170","followers_url":"https://api.github.com/users/0xc0170/followers","following_url":"https://api.github.com/users/0xc0170/following{/other_user}","gists_url":"https://api.github.com/users/0xc0170/gists{/gist_id}","starred_url":"https://api.github.com/users/0xc0170/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xc0170/subscriptions","organizations_url":"https://api.github.com/users/0xc0170/orgs","repos_url":"https://api.github.com/users/0xc0170/repos","events_url":"https://api.github.com/users/0xc0170/events{/privacy}","received_events_url":"https://api.github.com/users/0xc0170/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/0xc0170/mbed","description":"mbed libraries and tools","fork":true,"url":"https://api.github.com/repos/0xc0170/mbed","forks_url":"https://api.github.com/repos/0xc0170/mbed/forks","keys_url":"https://api.github.com/repos/0xc0170/mbed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xc0170/mbed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xc0170/mbed/teams","hooks_url":"https://api.github.com/repos/0xc0170/mbed/hooks","issue_events_url":"https://api.github.com/repos/0xc0170/mbed/issues/events{/number}","events_url":"https://api.github.com/repos/0xc0170/mbed/events","assignees_url":"https://api.github.com/repos/0xc0170/mbed/assignees{/user}","branches_url":"https://api.github.com/repos/0xc0170/mbed/branches{/branch}","tags_url":"https://api.github.com/repos/0xc0170/mbed/tags","blobs_url":"https://api.github.com/repos/0xc0170/mbed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xc0170/mbed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xc0170/mbed/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xc0170/mbed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xc0170/mbed/statuses/{sha}","languages_url":"https://api.github.com/repos/0xc0170/mbed/languages","stargazers_url":"https://api.github.com/repos/0xc0170/mbed/stargazers","contributors_url":"https://api.github.com/repos/0xc0170/mbed/contributors","subscribers_url":"https://api.github.com/repos/0xc0170/mbed/subscribers","subscription_url":"https://api.github.com/repos/0xc0170/mbed/subscription","commits_url":"https://api.github.com/repos/0xc0170/mbed/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xc0170/mbed/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xc0170/mbed/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xc0170/mbed/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xc0170/mbed/contents/{+path}","compare_url":"https://api.github.com/repos/0xc0170/mbed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xc0170/mbed/merges","archive_url":"https://api.github.com/repos/0xc0170/mbed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xc0170/mbed/downloads","issues_url":"https://api.github.com/repos/0xc0170/mbed/issues{/number}","pulls_url":"https://api.github.com/repos/0xc0170/mbed/pulls{/number}","milestones_url":"https://api.github.com/repos/0xc0170/mbed/milestones{/number}","notifications_url":"https://api.github.com/repos/0xc0170/mbed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xc0170/mbed/labels{/name}","releases_url":"https://api.github.com/repos/0xc0170/mbed/releases{/id}","deployments_url":"https://api.github.com/repos/0xc0170/mbed/deployments","created_at":"2013-06-10T16:09:18Z","updated_at":"2015-05-04T07:52:43Z","pushed_at":"2016-09-21T08:41:01Z","git_url":"git://github.com/0xc0170/mbed.git","ssh_url":"git@github.com:0xc0170/mbed.git","clone_url":"https://github.com/0xc0170/mbed.git","svn_url":"https://github.com/0xc0170/mbed","homepage":null,"size":63641,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"e4a40cd6a7c8198eec9e1164d82b7f55af29e386","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"name":"mbed-os","full_name":"ARMmbed/mbed-os","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-os","description":"ARM mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2016-09-20T19:36:48Z","pushed_at":"2016-09-21T10:56:43Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":81222,"stargazers_count":748,"watchers_count":748,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":747,"mirror_url":null,"open_issues_count":376,"forks":747,"open_issues":376,"watchers":748,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/2765"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/2765"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/2765"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/2765/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/2765/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/2765/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/a34b413124719b1738f89ed908ccc7734ce28bc1"}}}}
{"actor":{"display_login":"andresag01"}}