{"action":"created","comment":{"url":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/comments/85100205","pull_request_review_id":5834476,"id":85100205,"diff_hunk":"@@ -199,23 +199,46 @@ Public Class ucrGeom\n \r\n \r\n         clsgeom_boxplot.SetGeomName(\"geom_boxplot\")\r\n-        clsgeom_boxplot.AddAesParameter(\"x\", strIncludedDataTypes:={\"factor\", \"numeric\"})\r\n+        clsgeom_boxplot.AddAesParameter(\"x\")\r\n+        'Warning: When x is continuous, there needs to be a grouping variable... for example cut_width(x,0.25). Are there other grouping possibilities ?\r\n+        clsgeom_boxplot.AddAesParameter(\"group\", strIncludedDataTypes:={\"factor\"})\r\n         clsgeom_boxplot.AddAesParameter(\"y\", strIncludedDataTypes:={\"numeric\"}, bIsMandatory:=True)\r\n-        clsgeom_boxplot.AddAesParameter(\"fill\", strIncludedDataTypes:={\"factor\"})\r\n-        clsgeom_boxplot.AddAesParameter(\"colour\", strIncludedDataTypes:={\"factor\"})\r\n+        'Warning: The following aesthetics should be assigned to calculations for the different parameters of a boxplot. Only relevant for sort of summaries. \r\n+        'Question to be discussed: do we want to have access to these ?\r\n+        clsgeom_boxplot.AddAesParameter(\"lower\", strIncludedDataTypes:={\"numeric\"})\r\n+        clsgeom_boxplot.AddAesParameter(\"upper\", strIncludedDataTypes:={\"numeric\"})\r\n+        clsgeom_boxplot.AddAesParameter(\"middle\", strIncludedDataTypes:={\"numeric\"})\r\n+        clsgeom_boxplot.AddAesParameter(\"ymax\", strIncludedDataTypes:={\"numeric\"})\r\n+        clsgeom_boxplot.AddAesParameter(\"ymin\", strIncludedDataTypes:={\"numeric\"})\r\n+\r\n+        clsgeom_boxplot.AddAesParameter(\"fill\", strIncludedDataTypes:={\"factor\", \"numeric\"})\r\n+        clsgeom_boxplot.AddAesParameter(\"colour\", strIncludedDataTypes:={\"factor\", \"numeric\"})\r\n+        clsgeom_boxplot.AddAesParameter(\"alpha\", strIncludedDataTypes:={\"factor\", \"numeric\"})\r\n         clsgeom_boxplot.AddAesParameter(\"linetype\", strIncludedDataTypes:={\"factor\"})\r\n-        clsgeom_boxplot.AddAesParameter(\"size\", strIncludedDataTypes:={\"factor\"})\r\n+        clsgeom_boxplot.AddAesParameter(\"size\", strIncludedDataTypes:={\"factor\", \"numeric\"})\r\n+        clsgeom_boxplot.AddAesParameter(\"weight\", strIncludedDataTypes:={\"numeric\"})\r","path":"instat/ucrGeom.vb","position":25,"original_position":25,"commit_id":"cacfb8742fdb61103f0711cc6c7bcbd132f9bf84","original_commit_id":"cacfb8742fdb61103f0711cc6c7bcbd132f9bf84","user":{"login":"dannyparsons","id":11214914,"avatar_url":"https://avatars.githubusercontent.com/u/11214914?v=3","gravatar_id":"","url":"https://api.github.com/users/dannyparsons","html_url":"https://github.com/dannyparsons","followers_url":"https://api.github.com/users/dannyparsons/followers","following_url":"https://api.github.com/users/dannyparsons/following{/other_user}","gists_url":"https://api.github.com/users/dannyparsons/gists{/gist_id}","starred_url":"https://api.github.com/users/dannyparsons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannyparsons/subscriptions","organizations_url":"https://api.github.com/users/dannyparsons/orgs","repos_url":"https://api.github.com/users/dannyparsons/repos","events_url":"https://api.github.com/users/dannyparsons/events{/privacy}","received_events_url":"https://api.github.com/users/dannyparsons/received_events","type":"User","site_admin":false},"body":"weight is in twice now (also below)","created_at":"2016-10-26T11:17:33Z","updated_at":"2016-10-26T11:17:33Z","html_url":"https://github.com/africanmathsinitiative/Instat/pull/1952#discussion_r85100205","pull_request_url":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/1952","_links":{"self":{"href":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/comments/85100205"},"html":{"href":"https://github.com/africanmathsinitiative/Instat/pull/1952#discussion_r85100205"},"pull_request":{"href":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/1952"}}},"pull_request":{"url":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/1952","id":90970424,"html_url":"https://github.com/africanmathsinitiative/Instat/pull/1952","diff_url":"https://github.com/africanmathsinitiative/Instat/pull/1952.diff","patch_url":"https://github.com/africanmathsinitiative/Instat/pull/1952.patch","issue_url":"https://api.github.com/repos/africanmathsinitiative/Instat/issues/1952","number":1952,"state":"open","locked":false,"title":"Boxplot geom refined","user":{"login":"FrancoisJRenaud","id":22272110,"avatar_url":"https://avatars.githubusercontent.com/u/22272110?v=3","gravatar_id":"","url":"https://api.github.com/users/FrancoisJRenaud","html_url":"https://github.com/FrancoisJRenaud","followers_url":"https://api.github.com/users/FrancoisJRenaud/followers","following_url":"https://api.github.com/users/FrancoisJRenaud/following{/other_user}","gists_url":"https://api.github.com/users/FrancoisJRenaud/gists{/gist_id}","starred_url":"https://api.github.com/users/FrancoisJRenaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrancoisJRenaud/subscriptions","organizations_url":"https://api.github.com/users/FrancoisJRenaud/orgs","repos_url":"https://api.github.com/users/FrancoisJRenaud/repos","events_url":"https://api.github.com/users/FrancoisJRenaud/events{/privacy}","received_events_url":"https://api.github.com/users/FrancoisJRenaud/received_events","type":"User","site_admin":false},"body":"Went through the boxplot geom definition and tried my best to have all parameters available with the right available values etc... A few comments are made when I m not sure about what we want to do about some parameters...","created_at":"2016-10-26T09:48:46Z","updated_at":"2016-10-26T11:17:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd9e8327c93e012e653e21cd650dd746e263dc8b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/1952/commits","review_comments_url":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/1952/comments","review_comment_url":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/africanmathsinitiative/Instat/issues/1952/comments","statuses_url":"https://api.github.com/repos/africanmathsinitiative/Instat/statuses/cacfb8742fdb61103f0711cc6c7bcbd132f9bf84","head":{"label":"FrancoisJRenaud:BoxplotBasedGeneralDebug","ref":"BoxplotBasedGeneralDebug","sha":"cacfb8742fdb61103f0711cc6c7bcbd132f9bf84","user":{"login":"FrancoisJRenaud","id":22272110,"avatar_url":"https://avatars.githubusercontent.com/u/22272110?v=3","gravatar_id":"","url":"https://api.github.com/users/FrancoisJRenaud","html_url":"https://github.com/FrancoisJRenaud","followers_url":"https://api.github.com/users/FrancoisJRenaud/followers","following_url":"https://api.github.com/users/FrancoisJRenaud/following{/other_user}","gists_url":"https://api.github.com/users/FrancoisJRenaud/gists{/gist_id}","starred_url":"https://api.github.com/users/FrancoisJRenaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrancoisJRenaud/subscriptions","organizations_url":"https://api.github.com/users/FrancoisJRenaud/orgs","repos_url":"https://api.github.com/users/FrancoisJRenaud/repos","events_url":"https://api.github.com/users/FrancoisJRenaud/events{/privacy}","received_events_url":"https://api.github.com/users/FrancoisJRenaud/received_events","type":"User","site_admin":false},"repo":{"id":69454888,"name":"Instat","full_name":"FrancoisJRenaud/Instat","owner":{"login":"FrancoisJRenaud","id":22272110,"avatar_url":"https://avatars.githubusercontent.com/u/22272110?v=3","gravatar_id":"","url":"https://api.github.com/users/FrancoisJRenaud","html_url":"https://github.com/FrancoisJRenaud","followers_url":"https://api.github.com/users/FrancoisJRenaud/followers","following_url":"https://api.github.com/users/FrancoisJRenaud/following{/other_user}","gists_url":"https://api.github.com/users/FrancoisJRenaud/gists{/gist_id}","starred_url":"https://api.github.com/users/FrancoisJRenaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrancoisJRenaud/subscriptions","organizations_url":"https://api.github.com/users/FrancoisJRenaud/orgs","repos_url":"https://api.github.com/users/FrancoisJRenaud/repos","events_url":"https://api.github.com/users/FrancoisJRenaud/events{/privacy}","received_events_url":"https://api.github.com/users/FrancoisJRenaud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FrancoisJRenaud/Instat","description":"Development of the new version of Instat","fork":true,"url":"https://api.github.com/repos/FrancoisJRenaud/Instat","forks_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/forks","keys_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/teams","hooks_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/hooks","issue_events_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/issues/events{/number}","events_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/events","assignees_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/assignees{/user}","branches_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/branches{/branch}","tags_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/tags","blobs_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/git/refs{/sha}","trees_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/statuses/{sha}","languages_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/languages","stargazers_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/stargazers","contributors_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/contributors","subscribers_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/subscribers","subscription_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/subscription","commits_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/commits{/sha}","git_commits_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/git/commits{/sha}","comments_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/comments{/number}","issue_comment_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/issues/comments{/number}","contents_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/contents/{+path}","compare_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/merges","archive_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/downloads","issues_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/issues{/number}","pulls_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/pulls{/number}","milestones_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/milestones{/number}","notifications_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/labels{/name}","releases_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/releases{/id}","deployments_url":"https://api.github.com/repos/FrancoisJRenaud/Instat/deployments","created_at":"2016-09-28T11:02:38Z","updated_at":"2016-09-28T11:02:42Z","pushed_at":"2016-10-26T09:44:50Z","git_url":"git://github.com/FrancoisJRenaud/Instat.git","ssh_url":"git@github.com:FrancoisJRenaud/Instat.git","clone_url":"https://github.com/FrancoisJRenaud/Instat.git","svn_url":"https://github.com/FrancoisJRenaud/Instat","homepage":null,"size":449573,"stargazers_count":0,"watchers_count":0,"language":"Visual Basic","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"africanmathsinitiative:master","ref":"master","sha":"5f0a03f4db6447382e244b85989f971e3f3cf6ad","user":{"login":"africanmathsinitiative","id":13917566,"avatar_url":"https://avatars.githubusercontent.com/u/13917566?v=3","gravatar_id":"","url":"https://api.github.com/users/africanmathsinitiative","html_url":"https://github.com/africanmathsinitiative","followers_url":"https://api.github.com/users/africanmathsinitiative/followers","following_url":"https://api.github.com/users/africanmathsinitiative/following{/other_user}","gists_url":"https://api.github.com/users/africanmathsinitiative/gists{/gist_id}","starred_url":"https://api.github.com/users/africanmathsinitiative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/africanmathsinitiative/subscriptions","organizations_url":"https://api.github.com/users/africanmathsinitiative/orgs","repos_url":"https://api.github.com/users/africanmathsinitiative/repos","events_url":"https://api.github.com/users/africanmathsinitiative/events{/privacy}","received_events_url":"https://api.github.com/users/africanmathsinitiative/received_events","type":"Organization","site_admin":false},"repo":{"id":44009238,"name":"Instat","full_name":"africanmathsinitiative/Instat","owner":{"login":"africanmathsinitiative","id":13917566,"avatar_url":"https://avatars.githubusercontent.com/u/13917566?v=3","gravatar_id":"","url":"https://api.github.com/users/africanmathsinitiative","html_url":"https://github.com/africanmathsinitiative","followers_url":"https://api.github.com/users/africanmathsinitiative/followers","following_url":"https://api.github.com/users/africanmathsinitiative/following{/other_user}","gists_url":"https://api.github.com/users/africanmathsinitiative/gists{/gist_id}","starred_url":"https://api.github.com/users/africanmathsinitiative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/africanmathsinitiative/subscriptions","organizations_url":"https://api.github.com/users/africanmathsinitiative/orgs","repos_url":"https://api.github.com/users/africanmathsinitiative/repos","events_url":"https://api.github.com/users/africanmathsinitiative/events{/privacy}","received_events_url":"https://api.github.com/users/africanmathsinitiative/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/africanmathsinitiative/Instat","description":"Development of the new version of Instat","fork":false,"url":"https://api.github.com/repos/africanmathsinitiative/Instat","forks_url":"https://api.github.com/repos/africanmathsinitiative/Instat/forks","keys_url":"https://api.github.com/repos/africanmathsinitiative/Instat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/africanmathsinitiative/Instat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/africanmathsinitiative/Instat/teams","hooks_url":"https://api.github.com/repos/africanmathsinitiative/Instat/hooks","issue_events_url":"https://api.github.com/repos/africanmathsinitiative/Instat/issues/events{/number}","events_url":"https://api.github.com/repos/africanmathsinitiative/Instat/events","assignees_url":"https://api.github.com/repos/africanmathsinitiative/Instat/assignees{/user}","branches_url":"https://api.github.com/repos/africanmathsinitiative/Instat/branches{/branch}","tags_url":"https://api.github.com/repos/africanmathsinitiative/Instat/tags","blobs_url":"https://api.github.com/repos/africanmathsinitiative/Instat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/africanmathsinitiative/Instat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/africanmathsinitiative/Instat/git/refs{/sha}","trees_url":"https://api.github.com/repos/africanmathsinitiative/Instat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/africanmathsinitiative/Instat/statuses/{sha}","languages_url":"https://api.github.com/repos/africanmathsinitiative/Instat/languages","stargazers_url":"https://api.github.com/repos/africanmathsinitiative/Instat/stargazers","contributors_url":"https://api.github.com/repos/africanmathsinitiative/Instat/contributors","subscribers_url":"https://api.github.com/repos/africanmathsinitiative/Instat/subscribers","subscription_url":"https://api.github.com/repos/africanmathsinitiative/Instat/subscription","commits_url":"https://api.github.com/repos/africanmathsinitiative/Instat/commits{/sha}","git_commits_url":"https://api.github.com/repos/africanmathsinitiative/Instat/git/commits{/sha}","comments_url":"https://api.github.com/repos/africanmathsinitiative/Instat/comments{/number}","issue_comment_url":"https://api.github.com/repos/africanmathsinitiative/Instat/issues/comments{/number}","contents_url":"https://api.github.com/repos/africanmathsinitiative/Instat/contents/{+path}","compare_url":"https://api.github.com/repos/africanmathsinitiative/Instat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/africanmathsinitiative/Instat/merges","archive_url":"https://api.github.com/repos/africanmathsinitiative/Instat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/africanmathsinitiative/Instat/downloads","issues_url":"https://api.github.com/repos/africanmathsinitiative/Instat/issues{/number}","pulls_url":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls{/number}","milestones_url":"https://api.github.com/repos/africanmathsinitiative/Instat/milestones{/number}","notifications_url":"https://api.github.com/repos/africanmathsinitiative/Instat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/africanmathsinitiative/Instat/labels{/name}","releases_url":"https://api.github.com/repos/africanmathsinitiative/Instat/releases{/id}","deployments_url":"https://api.github.com/repos/africanmathsinitiative/Instat/deployments","created_at":"2015-10-10T12:10:32Z","updated_at":"2016-10-24T19:29:44Z","pushed_at":"2016-10-26T10:30:28Z","git_url":"git://github.com/africanmathsinitiative/Instat.git","ssh_url":"git@github.com:africanmathsinitiative/Instat.git","clone_url":"https://github.com/africanmathsinitiative/Instat.git","svn_url":"https://github.com/africanmathsinitiative/Instat","homepage":null,"size":451547,"stargazers_count":2,"watchers_count":2,"language":"Visual Basic","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":87,"forks":18,"open_issues":87,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/1952"},"html":{"href":"https://github.com/africanmathsinitiative/Instat/pull/1952"},"issue":{"href":"https://api.github.com/repos/africanmathsinitiative/Instat/issues/1952"},"comments":{"href":"https://api.github.com/repos/africanmathsinitiative/Instat/issues/1952/comments"},"review_comments":{"href":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/1952/comments"},"review_comment":{"href":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/africanmathsinitiative/Instat/pulls/1952/commits"},"statuses":{"href":"https://api.github.com/repos/africanmathsinitiative/Instat/statuses/cacfb8742fdb61103f0711cc6c7bcbd132f9bf84"}}}}
{"actor":{"display_login":"dannyparsons"}}