{"action":"created","issue":{"url":"https://api.github.com/repos/rithms/riot-api-java/issues/74","repository_url":"https://api.github.com/repos/rithms/riot-api-java","labels_url":"https://api.github.com/repos/rithms/riot-api-java/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/rithms/riot-api-java/issues/74/comments","events_url":"https://api.github.com/repos/rithms/riot-api-java/issues/74/events","html_url":"https://github.com/rithms/riot-api-java/issues/74","id":174218311,"number":74,"title":"Inconsistency of championId type","user":{"login":"briceambrosiak","id":7165223,"avatar_url":"https://avatars.githubusercontent.com/u/7165223?v=3","gravatar_id":"","url":"https://api.github.com/users/briceambrosiak","html_url":"https://github.com/briceambrosiak","followers_url":"https://api.github.com/users/briceambrosiak/followers","following_url":"https://api.github.com/users/briceambrosiak/following{/other_user}","gists_url":"https://api.github.com/users/briceambrosiak/gists{/gist_id}","starred_url":"https://api.github.com/users/briceambrosiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briceambrosiak/subscriptions","organizations_url":"https://api.github.com/users/briceambrosiak/orgs","repos_url":"https://api.github.com/users/briceambrosiak/repos","events_url":"https://api.github.com/users/briceambrosiak/events{/privacy}","received_events_url":"https://api.github.com/users/briceambrosiak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-31T08:50:44Z","updated_at":"2016-08-31T09:01:31Z","closed_at":null,"body":"The method `ChampionMastery.getChampionId()` returns a long type. However, `Static.Champion.getDataChampion(...)` takes the id as `int` type (also, field could be name _championId_ for clarity). I don't know if other differences like that exists elsewhere in the API. "},"comment":{"url":"https://api.github.com/repos/rithms/riot-api-java/issues/comments/243702829","html_url":"https://github.com/rithms/riot-api-java/issues/74#issuecomment-243702829","issue_url":"https://api.github.com/repos/rithms/riot-api-java/issues/74","id":243702829,"user":{"login":"rithms","id":3264051,"avatar_url":"https://avatars.githubusercontent.com/u/3264051?v=3","gravatar_id":"","url":"https://api.github.com/users/rithms","html_url":"https://github.com/rithms","followers_url":"https://api.github.com/users/rithms/followers","following_url":"https://api.github.com/users/rithms/following{/other_user}","gists_url":"https://api.github.com/users/rithms/gists{/gist_id}","starred_url":"https://api.github.com/users/rithms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rithms/subscriptions","organizations_url":"https://api.github.com/users/rithms/orgs","repos_url":"https://api.github.com/users/rithms/repos","events_url":"https://api.github.com/users/rithms/events{/privacy}","received_events_url":"https://api.github.com/users/rithms/received_events","type":"User","site_admin":false},"created_at":"2016-08-31T09:01:31Z","updated_at":"2016-08-31T09:01:31Z","body":"These types mirror the types defined in the official [Riot Games API documentation](https://developer.riotgames.com/api/methods).\r\n\r\nA lot of the underlying services that power the API are owned by different teams across Riot. In the past that has been their explanation for little type and naming inconsistencies across endpoints like this.\r\n\r\nIIRC, in the past we addressed this to make the library more consistent, but I guess we overlooked these specific endpoints. (or maybe a thread was made to ask Riot why this inconsistency exists, but we never really did anything about it on our end? idr.)\r\n\r\nEither way, its a simple change. The GSOn conversion should still work if we change the champion ID type to int instead of long in the necessary DTOs."}}
{"actor":{"display_login":"rithms"}}