{"action":"created","issue":{"url":"https://api.github.com/repos/reddit/reddit-mobile/issues/833","repository_url":"https://api.github.com/repos/reddit/reddit-mobile","labels_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/833/labels{/name}","comments_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/833/comments","events_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/833/events","html_url":"https://github.com/reddit/reddit-mobile/pull/833","id":183845247,"number":833,"title":"Add EUCookieNotice support","user":{"login":"schwers","id":307983,"avatar_url":"https://avatars.githubusercontent.com/u/307983?v=3","gravatar_id":"","url":"https://api.github.com/users/schwers","html_url":"https://github.com/schwers","followers_url":"https://api.github.com/users/schwers/followers","following_url":"https://api.github.com/users/schwers/following{/other_user}","gists_url":"https://api.github.com/users/schwers/gists{/gist_id}","starred_url":"https://api.github.com/users/schwers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwers/subscriptions","organizations_url":"https://api.github.com/users/schwers/orgs","repos_url":"https://api.github.com/users/schwers/repos","events_url":"https://api.github.com/users/schwers/events{/privacy}","received_events_url":"https://api.github.com/users/schwers/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-19T01:42:46Z","updated_at":"2016-10-19T21:09:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/833","html_url":"https://github.com/reddit/reddit-mobile/pull/833","diff_url":"https://github.com/reddit/reddit-mobile/pull/833.diff","patch_url":"https://github.com/reddit/reddit-mobile/pull/833.patch"},"body":"This adds support for the EU Cookie Notice to 2X. It does _not_ add the general InfoBar component from 1X (which renders the EUCookie Notice in 1x) that supports app-global messages -- that seemed to be out of scope.\r\n\r\nThe biggest change was how I refactored the rendering of the AppMain and AppTopNav. Essentially AppMain now controls when the TopNav is rendered. I needed to do this so there was a consistent way to place the EUCookieNotice component above content, but after the TopNav, this is kind of of tricky because TopNav is position fixed. I didn't touch AppOverlayMenu's content, but I did move it because of a stacking issue with the SearchBarOverlay (I didn't look too deep here in interest of getting this in 2X quickly). \r\n\r\nGeneral behavior:\r\n\r\nWe rely on Fastly sending a country code via headers. If that country is in the EU and we haven't shown the EUCookieNotice a certain number of times, we show it. The component is responsible for dispatching an action when it's shown on a new page. After we've shown it enough, or when the user clicks close, we stop showing it. \r\n\r\nNow, pictures:\r\n\r\nDaymode:\r\n![image](https://cloud.githubusercontent.com/assets/307983/19502524/51023b46-9562-11e6-8798-60d4f0b5ec59.png)\r\n\r\nNightmode:\r\n![image](https://cloud.githubusercontent.com/assets/307983/19502528/5913e834-9562-11e6-9c97-b2b7a766367f.png)\r\n\r\n👓  @uzi || @nramadas  || @phil303  || @ajacksified \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/reddit/reddit-mobile/issues/comments/254941685","html_url":"https://github.com/reddit/reddit-mobile/pull/833#issuecomment-254941685","issue_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/833","id":254941685,"user":{"login":"phil303","id":787203,"avatar_url":"https://avatars.githubusercontent.com/u/787203?v=3","gravatar_id":"","url":"https://api.github.com/users/phil303","html_url":"https://github.com/phil303","followers_url":"https://api.github.com/users/phil303/followers","following_url":"https://api.github.com/users/phil303/following{/other_user}","gists_url":"https://api.github.com/users/phil303/gists{/gist_id}","starred_url":"https://api.github.com/users/phil303/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil303/subscriptions","organizations_url":"https://api.github.com/users/phil303/orgs","repos_url":"https://api.github.com/users/phil303/repos","events_url":"https://api.github.com/users/phil303/events{/privacy}","received_events_url":"https://api.github.com/users/phil303/received_events","type":"User","site_admin":false},"created_at":"2016-10-19T21:09:49Z","updated_at":"2016-10-19T21:09:49Z","body":"just one comment about leaving a comment. otherwise :tropical_fish:"}}
{"actor":{"display_login":"phil303"}}