{"action":"created","comment":{"url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/pulls/comments/86066747","pull_request_review_id":6743573,"id":86066747,"diff_hunk":"@@ -1,19 +1,89 @@\n package com.dhex.shipping.services;\n \n+import com.dhex.shipping.exceptions.NotValidShippingStatusException;\n+import com.dhex.shipping.exceptions.ShippingNotFoundException;\n import com.dhex.shipping.model.ShippingRequest;\n+import com.dhex.shipping.model.ShippingStatus;\n+import org.junit.Before;\n+import org.junit.Rule;\n import org.junit.Test;\n+import org.junit.rules.ExpectedException;\n+\n+import java.time.LocalDateTime;\n+import java.time.OffsetDateTime;\n+import java.time.ZoneOffset;\n \n import static org.hamcrest.core.Is.is;\n import static org.hamcrest.core.IsNull.notNullValue;\n import static org.junit.Assert.*;\n \n public class ShippingServiceTest {\n+\n+    ShippingRequest shippingRequest;\n+\n+    private ShippingService shippingService;\n+\n+    @Rule\n+    public ExpectedException expectedException = ExpectedException.none();\n+\n+    @Before\n+    public void setUp() throws Exception {","path":"src/test/java/com/dhex/shipping/services/ShippingServiceTest.java","position":30,"original_position":30,"commit_id":"022a3653c7cfb3db404ae3edccfc86e00a46477e","original_commit_id":"022a3653c7cfb3db404ae3edccfc86e00a46477e","user":{"login":"paolocarrasco","id":1524522,"avatar_url":"https://avatars.githubusercontent.com/u/1524522?v=3","gravatar_id":"","url":"https://api.github.com/users/paolocarrasco","html_url":"https://github.com/paolocarrasco","followers_url":"https://api.github.com/users/paolocarrasco/followers","following_url":"https://api.github.com/users/paolocarrasco/following{/other_user}","gists_url":"https://api.github.com/users/paolocarrasco/gists{/gist_id}","starred_url":"https://api.github.com/users/paolocarrasco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paolocarrasco/subscriptions","organizations_url":"https://api.github.com/users/paolocarrasco/orgs","repos_url":"https://api.github.com/users/paolocarrasco/repos","events_url":"https://api.github.com/users/paolocarrasco/events{/privacy}","received_events_url":"https://api.github.com/users/paolocarrasco/received_events","type":"User","site_admin":false},"body":"If we are not expecting any exception, we can omit the throws part in the signature. If we were expecting exceptions, we should declare them explicitly ([don't catch generic exceptions](http://www.javaworld.com/article/2073800/testing-debugging/beware-the-dangers-of-generic-exceptions.html))","created_at":"2016-11-02T03:07:47Z","updated_at":"2016-11-02T03:07:47Z","html_url":"https://github.com/paolocarrasco/dhex-shipping/pull/1#discussion_r86066747","pull_request_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/paolocarrasco/dhex-shipping/pulls/comments/86066747"},"html":{"href":"https://github.com/paolocarrasco/dhex-shipping/pull/1#discussion_r86066747"},"pull_request":{"href":"https://api.github.com/repos/paolocarrasco/dhex-shipping/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/pulls/1","id":89551035,"html_url":"https://github.com/paolocarrasco/dhex-shipping/pull/1","diff_url":"https://github.com/paolocarrasco/dhex-shipping/pull/1.diff","patch_url":"https://github.com/paolocarrasco/dhex-shipping/pull/1.patch","issue_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/issues/1","number":1,"state":"closed","locked":false,"title":"Test based on shiping status criteria are done. Refactor for service …","user":{"login":"Darguelles","id":12415006,"avatar_url":"https://avatars.githubusercontent.com/u/12415006?v=3","gravatar_id":"","url":"https://api.github.com/users/Darguelles","html_url":"https://github.com/Darguelles","followers_url":"https://api.github.com/users/Darguelles/followers","following_url":"https://api.github.com/users/Darguelles/following{/other_user}","gists_url":"https://api.github.com/users/Darguelles/gists{/gist_id}","starred_url":"https://api.github.com/users/Darguelles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Darguelles/subscriptions","organizations_url":"https://api.github.com/users/Darguelles/orgs","repos_url":"https://api.github.com/users/Darguelles/repos","events_url":"https://api.github.com/users/Darguelles/events{/privacy}","received_events_url":"https://api.github.com/users/Darguelles/received_events","type":"User","site_admin":false},"body":"…to pass all of them is pending.\n","created_at":"2016-10-17T02:06:44Z","updated_at":"2016-11-02T03:07:47Z","closed_at":"2016-10-17T02:06:54Z","merged_at":null,"merge_commit_sha":"d19715b17c1ff508423fbd7f884fa3b03e3ff8a7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/pulls/1/commits","review_comments_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/pulls/1/comments","review_comment_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/issues/1/comments","statuses_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/statuses/022a3653c7cfb3db404ae3edccfc86e00a46477e","head":{"label":"Darguelles:refactoring","ref":"refactoring","sha":"022a3653c7cfb3db404ae3edccfc86e00a46477e","user":{"login":"Darguelles","id":12415006,"avatar_url":"https://avatars.githubusercontent.com/u/12415006?v=3","gravatar_id":"","url":"https://api.github.com/users/Darguelles","html_url":"https://github.com/Darguelles","followers_url":"https://api.github.com/users/Darguelles/followers","following_url":"https://api.github.com/users/Darguelles/following{/other_user}","gists_url":"https://api.github.com/users/Darguelles/gists{/gist_id}","starred_url":"https://api.github.com/users/Darguelles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Darguelles/subscriptions","organizations_url":"https://api.github.com/users/Darguelles/orgs","repos_url":"https://api.github.com/users/Darguelles/repos","events_url":"https://api.github.com/users/Darguelles/events{/privacy}","received_events_url":"https://api.github.com/users/Darguelles/received_events","type":"User","site_admin":false},"repo":{"id":71085486,"name":"dhex-shipping","full_name":"Darguelles/dhex-shipping","owner":{"login":"Darguelles","id":12415006,"avatar_url":"https://avatars.githubusercontent.com/u/12415006?v=3","gravatar_id":"","url":"https://api.github.com/users/Darguelles","html_url":"https://github.com/Darguelles","followers_url":"https://api.github.com/users/Darguelles/followers","following_url":"https://api.github.com/users/Darguelles/following{/other_user}","gists_url":"https://api.github.com/users/Darguelles/gists{/gist_id}","starred_url":"https://api.github.com/users/Darguelles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Darguelles/subscriptions","organizations_url":"https://api.github.com/users/Darguelles/orgs","repos_url":"https://api.github.com/users/Darguelles/repos","events_url":"https://api.github.com/users/Darguelles/events{/privacy}","received_events_url":"https://api.github.com/users/Darguelles/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Darguelles/dhex-shipping","description":"Shipping and delivery of international packages.","fork":true,"url":"https://api.github.com/repos/Darguelles/dhex-shipping","forks_url":"https://api.github.com/repos/Darguelles/dhex-shipping/forks","keys_url":"https://api.github.com/repos/Darguelles/dhex-shipping/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Darguelles/dhex-shipping/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Darguelles/dhex-shipping/teams","hooks_url":"https://api.github.com/repos/Darguelles/dhex-shipping/hooks","issue_events_url":"https://api.github.com/repos/Darguelles/dhex-shipping/issues/events{/number}","events_url":"https://api.github.com/repos/Darguelles/dhex-shipping/events","assignees_url":"https://api.github.com/repos/Darguelles/dhex-shipping/assignees{/user}","branches_url":"https://api.github.com/repos/Darguelles/dhex-shipping/branches{/branch}","tags_url":"https://api.github.com/repos/Darguelles/dhex-shipping/tags","blobs_url":"https://api.github.com/repos/Darguelles/dhex-shipping/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Darguelles/dhex-shipping/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Darguelles/dhex-shipping/git/refs{/sha}","trees_url":"https://api.github.com/repos/Darguelles/dhex-shipping/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Darguelles/dhex-shipping/statuses/{sha}","languages_url":"https://api.github.com/repos/Darguelles/dhex-shipping/languages","stargazers_url":"https://api.github.com/repos/Darguelles/dhex-shipping/stargazers","contributors_url":"https://api.github.com/repos/Darguelles/dhex-shipping/contributors","subscribers_url":"https://api.github.com/repos/Darguelles/dhex-shipping/subscribers","subscription_url":"https://api.github.com/repos/Darguelles/dhex-shipping/subscription","commits_url":"https://api.github.com/repos/Darguelles/dhex-shipping/commits{/sha}","git_commits_url":"https://api.github.com/repos/Darguelles/dhex-shipping/git/commits{/sha}","comments_url":"https://api.github.com/repos/Darguelles/dhex-shipping/comments{/number}","issue_comment_url":"https://api.github.com/repos/Darguelles/dhex-shipping/issues/comments{/number}","contents_url":"https://api.github.com/repos/Darguelles/dhex-shipping/contents/{+path}","compare_url":"https://api.github.com/repos/Darguelles/dhex-shipping/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Darguelles/dhex-shipping/merges","archive_url":"https://api.github.com/repos/Darguelles/dhex-shipping/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Darguelles/dhex-shipping/downloads","issues_url":"https://api.github.com/repos/Darguelles/dhex-shipping/issues{/number}","pulls_url":"https://api.github.com/repos/Darguelles/dhex-shipping/pulls{/number}","milestones_url":"https://api.github.com/repos/Darguelles/dhex-shipping/milestones{/number}","notifications_url":"https://api.github.com/repos/Darguelles/dhex-shipping/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Darguelles/dhex-shipping/labels{/name}","releases_url":"https://api.github.com/repos/Darguelles/dhex-shipping/releases{/id}","deployments_url":"https://api.github.com/repos/Darguelles/dhex-shipping/deployments","created_at":"2016-10-17T00:12:52Z","updated_at":"2016-10-17T00:12:53Z","pushed_at":"2016-10-18T01:03:10Z","git_url":"git://github.com/Darguelles/dhex-shipping.git","ssh_url":"git@github.com:Darguelles/dhex-shipping.git","clone_url":"https://github.com/Darguelles/dhex-shipping.git","svn_url":"https://github.com/Darguelles/dhex-shipping","homepage":null,"size":1646,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"paolocarrasco:refactoring","ref":"refactoring","sha":"c4ef560b550ed52eb822dab60e1667dd2c19b7e4","user":{"login":"paolocarrasco","id":1524522,"avatar_url":"https://avatars.githubusercontent.com/u/1524522?v=3","gravatar_id":"","url":"https://api.github.com/users/paolocarrasco","html_url":"https://github.com/paolocarrasco","followers_url":"https://api.github.com/users/paolocarrasco/followers","following_url":"https://api.github.com/users/paolocarrasco/following{/other_user}","gists_url":"https://api.github.com/users/paolocarrasco/gists{/gist_id}","starred_url":"https://api.github.com/users/paolocarrasco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paolocarrasco/subscriptions","organizations_url":"https://api.github.com/users/paolocarrasco/orgs","repos_url":"https://api.github.com/users/paolocarrasco/repos","events_url":"https://api.github.com/users/paolocarrasco/events{/privacy}","received_events_url":"https://api.github.com/users/paolocarrasco/received_events","type":"User","site_admin":false},"repo":{"id":56545357,"name":"dhex-shipping","full_name":"paolocarrasco/dhex-shipping","owner":{"login":"paolocarrasco","id":1524522,"avatar_url":"https://avatars.githubusercontent.com/u/1524522?v=3","gravatar_id":"","url":"https://api.github.com/users/paolocarrasco","html_url":"https://github.com/paolocarrasco","followers_url":"https://api.github.com/users/paolocarrasco/followers","following_url":"https://api.github.com/users/paolocarrasco/following{/other_user}","gists_url":"https://api.github.com/users/paolocarrasco/gists{/gist_id}","starred_url":"https://api.github.com/users/paolocarrasco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paolocarrasco/subscriptions","organizations_url":"https://api.github.com/users/paolocarrasco/orgs","repos_url":"https://api.github.com/users/paolocarrasco/repos","events_url":"https://api.github.com/users/paolocarrasco/events{/privacy}","received_events_url":"https://api.github.com/users/paolocarrasco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paolocarrasco/dhex-shipping","description":"Shipping and delivery of international packages.","fork":false,"url":"https://api.github.com/repos/paolocarrasco/dhex-shipping","forks_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/forks","keys_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/teams","hooks_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/hooks","issue_events_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/issues/events{/number}","events_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/events","assignees_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/assignees{/user}","branches_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/branches{/branch}","tags_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/tags","blobs_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/git/refs{/sha}","trees_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/statuses/{sha}","languages_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/languages","stargazers_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/stargazers","contributors_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/contributors","subscribers_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/subscribers","subscription_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/subscription","commits_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/commits{/sha}","git_commits_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/git/commits{/sha}","comments_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/comments{/number}","issue_comment_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/issues/comments{/number}","contents_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/contents/{+path}","compare_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/merges","archive_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/downloads","issues_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/issues{/number}","pulls_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/pulls{/number}","milestones_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/milestones{/number}","notifications_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/labels{/name}","releases_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/releases{/id}","deployments_url":"https://api.github.com/repos/paolocarrasco/dhex-shipping/deployments","created_at":"2016-04-18T22:03:07Z","updated_at":"2016-04-18T22:27:46Z","pushed_at":"2016-11-02T02:59:08Z","git_url":"git://github.com/paolocarrasco/dhex-shipping.git","ssh_url":"git@github.com:paolocarrasco/dhex-shipping.git","clone_url":"https://github.com/paolocarrasco/dhex-shipping.git","svn_url":"https://github.com/paolocarrasco/dhex-shipping","homepage":null,"size":1643,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":1,"forks":9,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paolocarrasco/dhex-shipping/pulls/1"},"html":{"href":"https://github.com/paolocarrasco/dhex-shipping/pull/1"},"issue":{"href":"https://api.github.com/repos/paolocarrasco/dhex-shipping/issues/1"},"comments":{"href":"https://api.github.com/repos/paolocarrasco/dhex-shipping/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/paolocarrasco/dhex-shipping/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/paolocarrasco/dhex-shipping/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paolocarrasco/dhex-shipping/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/paolocarrasco/dhex-shipping/statuses/022a3653c7cfb3db404ae3edccfc86e00a46477e"}}}}
{"actor":{"display_login":"paolocarrasco"}}