{"action":"closed","number":5292,"pull_request":{"url":"https://api.github.com/repos/clementine-player/Clementine/pulls/5292","id":62500415,"html_url":"https://github.com/clementine-player/Clementine/pull/5292","diff_url":"https://github.com/clementine-player/Clementine/pull/5292.diff","patch_url":"https://github.com/clementine-player/Clementine/pull/5292.patch","issue_url":"https://api.github.com/repos/clementine-player/Clementine/issues/5292","number":5292,"state":"closed","locked":false,"title":"Fix mpris dbus notifications","user":{"login":"printesoi","id":641396,"avatar_url":"https://avatars.githubusercontent.com/u/641396?v=3","gravatar_id":"","url":"https://api.github.com/users/printesoi","html_url":"https://github.com/printesoi","followers_url":"https://api.github.com/users/printesoi/followers","following_url":"https://api.github.com/users/printesoi/following{/other_user}","gists_url":"https://api.github.com/users/printesoi/gists{/gist_id}","starred_url":"https://api.github.com/users/printesoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/printesoi/subscriptions","organizations_url":"https://api.github.com/users/printesoi/orgs","repos_url":"https://api.github.com/users/printesoi/repos","events_url":"https://api.github.com/users/printesoi/events{/privacy}","received_events_url":"https://api.github.com/users/printesoi/received_events","type":"User","site_admin":false},"body":"Clementine does not send the correct signal about the changed properties such as CanGoNext, CanGoPrevious, CanSeek and may cause programs that listen to those changes use the wrong information. \r\n\r\nTo check the corect signals are send one can use:\r\n\r\n`dbus-monitor --session --monitor \"type='signal',interface=org.freedesktop.DBus.Properties,member=PropertiesChanged,path=/org/mpris/MediaPlayer2\"`","created_at":"2016-03-11T05:46:17Z","updated_at":"2016-03-30T14:36:04Z","closed_at":"2016-03-30T14:36:04Z","merged_at":"2016-03-30T14:36:04Z","merge_commit_sha":"9c33369fcc758c82d908d518dfa04dfa156fb6e9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/clementine-player/Clementine/pulls/5292/commits","review_comments_url":"https://api.github.com/repos/clementine-player/Clementine/pulls/5292/comments","review_comment_url":"https://api.github.com/repos/clementine-player/Clementine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clementine-player/Clementine/issues/5292/comments","statuses_url":"https://api.github.com/repos/clementine-player/Clementine/statuses/3dd55e1c8627fc42a57918c72c5a22419313f7b1","head":{"label":"printesoi:fix-mpris-signals","ref":"fix-mpris-signals","sha":"3dd55e1c8627fc42a57918c72c5a22419313f7b1","user":{"login":"printesoi","id":641396,"avatar_url":"https://avatars.githubusercontent.com/u/641396?v=3","gravatar_id":"","url":"https://api.github.com/users/printesoi","html_url":"https://github.com/printesoi","followers_url":"https://api.github.com/users/printesoi/followers","following_url":"https://api.github.com/users/printesoi/following{/other_user}","gists_url":"https://api.github.com/users/printesoi/gists{/gist_id}","starred_url":"https://api.github.com/users/printesoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/printesoi/subscriptions","organizations_url":"https://api.github.com/users/printesoi/orgs","repos_url":"https://api.github.com/users/printesoi/repos","events_url":"https://api.github.com/users/printesoi/events{/privacy}","received_events_url":"https://api.github.com/users/printesoi/received_events","type":"User","site_admin":false},"repo":{"id":39736582,"name":"Clementine","full_name":"printesoi/Clementine","owner":{"login":"printesoi","id":641396,"avatar_url":"https://avatars.githubusercontent.com/u/641396?v=3","gravatar_id":"","url":"https://api.github.com/users/printesoi","html_url":"https://github.com/printesoi","followers_url":"https://api.github.com/users/printesoi/followers","following_url":"https://api.github.com/users/printesoi/following{/other_user}","gists_url":"https://api.github.com/users/printesoi/gists{/gist_id}","starred_url":"https://api.github.com/users/printesoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/printesoi/subscriptions","organizations_url":"https://api.github.com/users/printesoi/orgs","repos_url":"https://api.github.com/users/printesoi/repos","events_url":"https://api.github.com/users/printesoi/events{/privacy}","received_events_url":"https://api.github.com/users/printesoi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/printesoi/Clementine","description":"Clementine Music Player","fork":true,"url":"https://api.github.com/repos/printesoi/Clementine","forks_url":"https://api.github.com/repos/printesoi/Clementine/forks","keys_url":"https://api.github.com/repos/printesoi/Clementine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/printesoi/Clementine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/printesoi/Clementine/teams","hooks_url":"https://api.github.com/repos/printesoi/Clementine/hooks","issue_events_url":"https://api.github.com/repos/printesoi/Clementine/issues/events{/number}","events_url":"https://api.github.com/repos/printesoi/Clementine/events","assignees_url":"https://api.github.com/repos/printesoi/Clementine/assignees{/user}","branches_url":"https://api.github.com/repos/printesoi/Clementine/branches{/branch}","tags_url":"https://api.github.com/repos/printesoi/Clementine/tags","blobs_url":"https://api.github.com/repos/printesoi/Clementine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/printesoi/Clementine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/printesoi/Clementine/git/refs{/sha}","trees_url":"https://api.github.com/repos/printesoi/Clementine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/printesoi/Clementine/statuses/{sha}","languages_url":"https://api.github.com/repos/printesoi/Clementine/languages","stargazers_url":"https://api.github.com/repos/printesoi/Clementine/stargazers","contributors_url":"https://api.github.com/repos/printesoi/Clementine/contributors","subscribers_url":"https://api.github.com/repos/printesoi/Clementine/subscribers","subscription_url":"https://api.github.com/repos/printesoi/Clementine/subscription","commits_url":"https://api.github.com/repos/printesoi/Clementine/commits{/sha}","git_commits_url":"https://api.github.com/repos/printesoi/Clementine/git/commits{/sha}","comments_url":"https://api.github.com/repos/printesoi/Clementine/comments{/number}","issue_comment_url":"https://api.github.com/repos/printesoi/Clementine/issues/comments{/number}","contents_url":"https://api.github.com/repos/printesoi/Clementine/contents/{+path}","compare_url":"https://api.github.com/repos/printesoi/Clementine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/printesoi/Clementine/merges","archive_url":"https://api.github.com/repos/printesoi/Clementine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/printesoi/Clementine/downloads","issues_url":"https://api.github.com/repos/printesoi/Clementine/issues{/number}","pulls_url":"https://api.github.com/repos/printesoi/Clementine/pulls{/number}","milestones_url":"https://api.github.com/repos/printesoi/Clementine/milestones{/number}","notifications_url":"https://api.github.com/repos/printesoi/Clementine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/printesoi/Clementine/labels{/name}","releases_url":"https://api.github.com/repos/printesoi/Clementine/releases{/id}","deployments_url":"https://api.github.com/repos/printesoi/Clementine/deployments","created_at":"2015-07-26T18:26:10Z","updated_at":"2016-03-10T10:09:03Z","pushed_at":"2016-03-30T04:31:05Z","git_url":"git://github.com/printesoi/Clementine.git","ssh_url":"git@github.com:printesoi/Clementine.git","clone_url":"https://github.com/printesoi/Clementine.git","svn_url":"https://github.com/printesoi/Clementine","homepage":null,"size":140805,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clementine-player:master","ref":"master","sha":"2257dcd27895547201377a51262e124bd8762925","user":{"login":"clementine-player","id":5975299,"avatar_url":"https://avatars.githubusercontent.com/u/5975299?v=3","gravatar_id":"","url":"https://api.github.com/users/clementine-player","html_url":"https://github.com/clementine-player","followers_url":"https://api.github.com/users/clementine-player/followers","following_url":"https://api.github.com/users/clementine-player/following{/other_user}","gists_url":"https://api.github.com/users/clementine-player/gists{/gist_id}","starred_url":"https://api.github.com/users/clementine-player/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clementine-player/subscriptions","organizations_url":"https://api.github.com/users/clementine-player/orgs","repos_url":"https://api.github.com/users/clementine-player/repos","events_url":"https://api.github.com/users/clementine-player/events{/privacy}","received_events_url":"https://api.github.com/users/clementine-player/received_events","type":"Organization","site_admin":false},"repo":{"id":14979312,"name":"Clementine","full_name":"clementine-player/Clementine","owner":{"login":"clementine-player","id":5975299,"avatar_url":"https://avatars.githubusercontent.com/u/5975299?v=3","gravatar_id":"","url":"https://api.github.com/users/clementine-player","html_url":"https://github.com/clementine-player","followers_url":"https://api.github.com/users/clementine-player/followers","following_url":"https://api.github.com/users/clementine-player/following{/other_user}","gists_url":"https://api.github.com/users/clementine-player/gists{/gist_id}","starred_url":"https://api.github.com/users/clementine-player/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clementine-player/subscriptions","organizations_url":"https://api.github.com/users/clementine-player/orgs","repos_url":"https://api.github.com/users/clementine-player/repos","events_url":"https://api.github.com/users/clementine-player/events{/privacy}","received_events_url":"https://api.github.com/users/clementine-player/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clementine-player/Clementine","description":":tangerine: Clementine Music Player","fork":false,"url":"https://api.github.com/repos/clementine-player/Clementine","forks_url":"https://api.github.com/repos/clementine-player/Clementine/forks","keys_url":"https://api.github.com/repos/clementine-player/Clementine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clementine-player/Clementine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clementine-player/Clementine/teams","hooks_url":"https://api.github.com/repos/clementine-player/Clementine/hooks","issue_events_url":"https://api.github.com/repos/clementine-player/Clementine/issues/events{/number}","events_url":"https://api.github.com/repos/clementine-player/Clementine/events","assignees_url":"https://api.github.com/repos/clementine-player/Clementine/assignees{/user}","branches_url":"https://api.github.com/repos/clementine-player/Clementine/branches{/branch}","tags_url":"https://api.github.com/repos/clementine-player/Clementine/tags","blobs_url":"https://api.github.com/repos/clementine-player/Clementine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clementine-player/Clementine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clementine-player/Clementine/git/refs{/sha}","trees_url":"https://api.github.com/repos/clementine-player/Clementine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clementine-player/Clementine/statuses/{sha}","languages_url":"https://api.github.com/repos/clementine-player/Clementine/languages","stargazers_url":"https://api.github.com/repos/clementine-player/Clementine/stargazers","contributors_url":"https://api.github.com/repos/clementine-player/Clementine/contributors","subscribers_url":"https://api.github.com/repos/clementine-player/Clementine/subscribers","subscription_url":"https://api.github.com/repos/clementine-player/Clementine/subscription","commits_url":"https://api.github.com/repos/clementine-player/Clementine/commits{/sha}","git_commits_url":"https://api.github.com/repos/clementine-player/Clementine/git/commits{/sha}","comments_url":"https://api.github.com/repos/clementine-player/Clementine/comments{/number}","issue_comment_url":"https://api.github.com/repos/clementine-player/Clementine/issues/comments{/number}","contents_url":"https://api.github.com/repos/clementine-player/Clementine/contents/{+path}","compare_url":"https://api.github.com/repos/clementine-player/Clementine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clementine-player/Clementine/merges","archive_url":"https://api.github.com/repos/clementine-player/Clementine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clementine-player/Clementine/downloads","issues_url":"https://api.github.com/repos/clementine-player/Clementine/issues{/number}","pulls_url":"https://api.github.com/repos/clementine-player/Clementine/pulls{/number}","milestones_url":"https://api.github.com/repos/clementine-player/Clementine/milestones{/number}","notifications_url":"https://api.github.com/repos/clementine-player/Clementine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clementine-player/Clementine/labels{/name}","releases_url":"https://api.github.com/repos/clementine-player/Clementine/releases{/id}","deployments_url":"https://api.github.com/repos/clementine-player/Clementine/deployments","created_at":"2013-12-06T09:55:15Z","updated_at":"2016-03-30T13:24:32Z","pushed_at":"2016-03-30T14:36:05Z","git_url":"git://github.com/clementine-player/Clementine.git","ssh_url":"git@github.com:clementine-player/Clementine.git","clone_url":"https://github.com/clementine-player/Clementine.git","svn_url":"https://github.com/clementine-player/Clementine","homepage":"","size":142738,"stargazers_count":1004,"watchers_count":1004,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":207,"mirror_url":null,"open_issues_count":1504,"forks":207,"open_issues":1504,"watchers":1004,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clementine-player/Clementine/pulls/5292"},"html":{"href":"https://github.com/clementine-player/Clementine/pull/5292"},"issue":{"href":"https://api.github.com/repos/clementine-player/Clementine/issues/5292"},"comments":{"href":"https://api.github.com/repos/clementine-player/Clementine/issues/5292/comments"},"review_comments":{"href":"https://api.github.com/repos/clementine-player/Clementine/pulls/5292/comments"},"review_comment":{"href":"https://api.github.com/repos/clementine-player/Clementine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clementine-player/Clementine/pulls/5292/commits"},"statuses":{"href":"https://api.github.com/repos/clementine-player/Clementine/statuses/3dd55e1c8627fc42a57918c72c5a22419313f7b1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hatstand","id":314491,"avatar_url":"https://avatars.githubusercontent.com/u/314491?v=3","gravatar_id":"","url":"https://api.github.com/users/hatstand","html_url":"https://github.com/hatstand","followers_url":"https://api.github.com/users/hatstand/followers","following_url":"https://api.github.com/users/hatstand/following{/other_user}","gists_url":"https://api.github.com/users/hatstand/gists{/gist_id}","starred_url":"https://api.github.com/users/hatstand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatstand/subscriptions","organizations_url":"https://api.github.com/users/hatstand/orgs","repos_url":"https://api.github.com/users/hatstand/repos","events_url":"https://api.github.com/users/hatstand/events{/privacy}","received_events_url":"https://api.github.com/users/hatstand/received_events","type":"User","site_admin":false},"comments":2,"review_comments":2,"commits":6,"additions":32,"deletions":12,"changed_files":3}}