{"action":"closed","number":515,"pull_request":{"url":"https://api.github.com/repos/WebAssembly/binaryen/pulls/515","id":70407965,"html_url":"https://github.com/WebAssembly/binaryen/pull/515","diff_url":"https://github.com/WebAssembly/binaryen/pull/515.diff","patch_url":"https://github.com/WebAssembly/binaryen/pull/515.patch","issue_url":"https://api.github.com/repos/WebAssembly/binaryen/issues/515","number":515,"state":"closed","locked":false,"title":"Smarter local coalescing","user":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"body":"This tries multiple orders of greedy local coloring instead of just the natural order, and picks the best.\r\n\r\nIt uses a genetic learning class, but no learning for now, it just creates the first generation of random elements, and picks the best. Later we can tune to see if multiple generations with mixing etc is worthwhile.\r\n\r\nThis makes the local index selection stage linearly slower by the number of extra orders (currently I picked 10). This can be significant, however, in some cases finding the interference graph is most of the time anyhow, and that is unchanged. This can be slow, so it's not in the default opt passes (that still has normal coalescing). However, we can probably optimize this stage significantly, I didn't look at it yet.\r\n\r\nSome numbers: with previous coalescing (just use 1 order), BananaBread ends up with 37019 locals (which as mentioned in the previous PR, was already 2% better than asm2wasm and 1% better than the LLVM backend). With 10 orders, 36602, and with 100, 36538, so it's over a 1% improvement with 10, and slightly better with 100. This also has secondary benefits of removing some local copies and so forth.","created_at":"2016-05-17T18:38:39Z","updated_at":"2016-05-17T20:42:26Z","closed_at":"2016-05-17T20:42:26Z","merged_at":"2016-05-17T20:42:26Z","merge_commit_sha":"92cbfdb2fb58986724bb796489b8138d217ca5f1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/WebAssembly/binaryen/pulls/515/commits","review_comments_url":"https://api.github.com/repos/WebAssembly/binaryen/pulls/515/comments","review_comment_url":"https://api.github.com/repos/WebAssembly/binaryen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WebAssembly/binaryen/issues/515/comments","statuses_url":"https://api.github.com/repos/WebAssembly/binaryen/statuses/5d76c53d350cc4565c8c4f4298c8fd346ca8fcb5","head":{"label":"WebAssembly:learn-coloring","ref":"learn-coloring","sha":"5d76c53d350cc4565c8c4f4298c8fd346ca8fcb5","user":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"repo":{"id":45208608,"name":"binaryen","full_name":"WebAssembly/binaryen","owner":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebAssembly/binaryen","description":"Compiler infrastructure and toolchain library for WebAssembly, in C++","fork":false,"url":"https://api.github.com/repos/WebAssembly/binaryen","forks_url":"https://api.github.com/repos/WebAssembly/binaryen/forks","keys_url":"https://api.github.com/repos/WebAssembly/binaryen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebAssembly/binaryen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebAssembly/binaryen/teams","hooks_url":"https://api.github.com/repos/WebAssembly/binaryen/hooks","issue_events_url":"https://api.github.com/repos/WebAssembly/binaryen/issues/events{/number}","events_url":"https://api.github.com/repos/WebAssembly/binaryen/events","assignees_url":"https://api.github.com/repos/WebAssembly/binaryen/assignees{/user}","branches_url":"https://api.github.com/repos/WebAssembly/binaryen/branches{/branch}","tags_url":"https://api.github.com/repos/WebAssembly/binaryen/tags","blobs_url":"https://api.github.com/repos/WebAssembly/binaryen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebAssembly/binaryen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebAssembly/binaryen/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebAssembly/binaryen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebAssembly/binaryen/statuses/{sha}","languages_url":"https://api.github.com/repos/WebAssembly/binaryen/languages","stargazers_url":"https://api.github.com/repos/WebAssembly/binaryen/stargazers","contributors_url":"https://api.github.com/repos/WebAssembly/binaryen/contributors","subscribers_url":"https://api.github.com/repos/WebAssembly/binaryen/subscribers","subscription_url":"https://api.github.com/repos/WebAssembly/binaryen/subscription","commits_url":"https://api.github.com/repos/WebAssembly/binaryen/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebAssembly/binaryen/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebAssembly/binaryen/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebAssembly/binaryen/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebAssembly/binaryen/contents/{+path}","compare_url":"https://api.github.com/repos/WebAssembly/binaryen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebAssembly/binaryen/merges","archive_url":"https://api.github.com/repos/WebAssembly/binaryen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebAssembly/binaryen/downloads","issues_url":"https://api.github.com/repos/WebAssembly/binaryen/issues{/number}","pulls_url":"https://api.github.com/repos/WebAssembly/binaryen/pulls{/number}","milestones_url":"https://api.github.com/repos/WebAssembly/binaryen/milestones{/number}","notifications_url":"https://api.github.com/repos/WebAssembly/binaryen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebAssembly/binaryen/labels{/name}","releases_url":"https://api.github.com/repos/WebAssembly/binaryen/releases{/id}","deployments_url":"https://api.github.com/repos/WebAssembly/binaryen/deployments","created_at":"2015-10-29T20:26:28Z","updated_at":"2016-05-17T04:52:42Z","pushed_at":"2016-05-17T20:42:26Z","git_url":"git://github.com/WebAssembly/binaryen.git","ssh_url":"git@github.com:WebAssembly/binaryen.git","clone_url":"https://github.com/WebAssembly/binaryen.git","svn_url":"https://github.com/WebAssembly/binaryen","homepage":"","size":19733,"stargazers_count":668,"watchers_count":668,"language":"Assembly","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":69,"forks":58,"open_issues":69,"watchers":668,"default_branch":"master"}},"base":{"label":"WebAssembly:master","ref":"master","sha":"90d4fa0164ab0fad4ca7b60489c43eebd41ed9e3","user":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"repo":{"id":45208608,"name":"binaryen","full_name":"WebAssembly/binaryen","owner":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebAssembly/binaryen","description":"Compiler infrastructure and toolchain library for WebAssembly, in C++","fork":false,"url":"https://api.github.com/repos/WebAssembly/binaryen","forks_url":"https://api.github.com/repos/WebAssembly/binaryen/forks","keys_url":"https://api.github.com/repos/WebAssembly/binaryen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebAssembly/binaryen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebAssembly/binaryen/teams","hooks_url":"https://api.github.com/repos/WebAssembly/binaryen/hooks","issue_events_url":"https://api.github.com/repos/WebAssembly/binaryen/issues/events{/number}","events_url":"https://api.github.com/repos/WebAssembly/binaryen/events","assignees_url":"https://api.github.com/repos/WebAssembly/binaryen/assignees{/user}","branches_url":"https://api.github.com/repos/WebAssembly/binaryen/branches{/branch}","tags_url":"https://api.github.com/repos/WebAssembly/binaryen/tags","blobs_url":"https://api.github.com/repos/WebAssembly/binaryen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebAssembly/binaryen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebAssembly/binaryen/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebAssembly/binaryen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebAssembly/binaryen/statuses/{sha}","languages_url":"https://api.github.com/repos/WebAssembly/binaryen/languages","stargazers_url":"https://api.github.com/repos/WebAssembly/binaryen/stargazers","contributors_url":"https://api.github.com/repos/WebAssembly/binaryen/contributors","subscribers_url":"https://api.github.com/repos/WebAssembly/binaryen/subscribers","subscription_url":"https://api.github.com/repos/WebAssembly/binaryen/subscription","commits_url":"https://api.github.com/repos/WebAssembly/binaryen/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebAssembly/binaryen/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebAssembly/binaryen/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebAssembly/binaryen/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebAssembly/binaryen/contents/{+path}","compare_url":"https://api.github.com/repos/WebAssembly/binaryen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebAssembly/binaryen/merges","archive_url":"https://api.github.com/repos/WebAssembly/binaryen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebAssembly/binaryen/downloads","issues_url":"https://api.github.com/repos/WebAssembly/binaryen/issues{/number}","pulls_url":"https://api.github.com/repos/WebAssembly/binaryen/pulls{/number}","milestones_url":"https://api.github.com/repos/WebAssembly/binaryen/milestones{/number}","notifications_url":"https://api.github.com/repos/WebAssembly/binaryen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebAssembly/binaryen/labels{/name}","releases_url":"https://api.github.com/repos/WebAssembly/binaryen/releases{/id}","deployments_url":"https://api.github.com/repos/WebAssembly/binaryen/deployments","created_at":"2015-10-29T20:26:28Z","updated_at":"2016-05-17T04:52:42Z","pushed_at":"2016-05-17T20:42:26Z","git_url":"git://github.com/WebAssembly/binaryen.git","ssh_url":"git@github.com:WebAssembly/binaryen.git","clone_url":"https://github.com/WebAssembly/binaryen.git","svn_url":"https://github.com/WebAssembly/binaryen","homepage":"","size":19733,"stargazers_count":668,"watchers_count":668,"language":"Assembly","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":69,"forks":58,"open_issues":69,"watchers":668,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WebAssembly/binaryen/pulls/515"},"html":{"href":"https://github.com/WebAssembly/binaryen/pull/515"},"issue":{"href":"https://api.github.com/repos/WebAssembly/binaryen/issues/515"},"comments":{"href":"https://api.github.com/repos/WebAssembly/binaryen/issues/515/comments"},"review_comments":{"href":"https://api.github.com/repos/WebAssembly/binaryen/pulls/515/comments"},"review_comment":{"href":"https://api.github.com/repos/WebAssembly/binaryen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WebAssembly/binaryen/pulls/515/commits"},"statuses":{"href":"https://api.github.com/repos/WebAssembly/binaryen/statuses/5d76c53d350cc4565c8c4f4298c8fd346ca8fcb5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":4,"additions":1507,"deletions":15,"changed_files":5}}