{"action":"created","comment":{"url":"https://api.github.com/repos/gartz/pushStateTree/pulls/comments/59133950","id":59133950,"diff_hunk":"@@ -7,48 +9,46 @@ if (typeof PST_NO_SHIM === 'undefined') {\n   var HashChangeEvent = root.HashChangeEvent;\n   var Event = root.Event;\n \n-  (function () {\n-    if (!Element.prototype.addEventListener) {\n-      return;\n-    }\n-\n-    function CustomEvent(event, params) {\n-      params = params || {\n-        bubbles: false,\n-        cancelable: false,\n-        detail: undefined\n-      };\n-      var evt = document.createEvent('CustomEvent');\n-      evt.initCustomEvent(event, params.bubbles, params.cancelable, params.detail);\n-      return evt;\n-    }\n-\n-    CustomEvent.prototype = Event.prototype;\n-\n-    if (!root.CustomEvent || isIE()) {\n-      root.CustomEvent = CustomEvent;\n-    }\n-\n-    // Opera before 15 has HashChangeEvent but throw a DOM Implement error\n-    if (!HashChangeEvent || (root.opera && root.opera.version() < 15) || isIE()) {\n-      HashChangeEvent = root.CustomEvent;\n-    }\n-\n-    if (isIE()) {\n-      Event = CustomEvent;\n-    }\n-\n-    // fix for Safari\n-    try {\n-      new HashChangeEvent('hashchange');\n-    } catch (e) {\n-      HashChangeEvent = CustomEvent;\n-    }\n-\n-    try {\n-      new Event('popstate');\n-    } catch (e) {\n-      Event = CustomEvent;\n-    }\n-  })();\n+  if (!Element.prototype.addEventListener) {\n+    throw new Error('CustomEvent shim needs EventTarget support to work.');\n+  }\n+\n+  let CustomEvent = function CustomEvent(event, params) {\n+    params = params || {\n+      bubbles: false,\n+      cancelable: false,\n+      detail: undefined\n+    };","path":"src/customEvent.shim.js","position":63,"original_position":63,"commit_id":"9e6c1bd08e8e372f6ee095407c256c61902d2c91","original_commit_id":"9e6c1bd08e8e372f6ee095407c256c61902d2c91","user":{"login":"romuloab","id":754933,"avatar_url":"https://avatars.githubusercontent.com/u/754933?v=3","gravatar_id":"","url":"https://api.github.com/users/romuloab","html_url":"https://github.com/romuloab","followers_url":"https://api.github.com/users/romuloab/followers","following_url":"https://api.github.com/users/romuloab/following{/other_user}","gists_url":"https://api.github.com/users/romuloab/gists{/gist_id}","starred_url":"https://api.github.com/users/romuloab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romuloab/subscriptions","organizations_url":"https://api.github.com/users/romuloab/orgs","repos_url":"https://api.github.com/users/romuloab/repos","events_url":"https://api.github.com/users/romuloab/events{/privacy}","received_events_url":"https://api.github.com/users/romuloab/received_events","type":"User","site_admin":false},"body":"oh ok, it's the signature used by the browsers. but I'd argue that you have to check for each param individually instead of all-or-nothing.","created_at":"2016-04-10T13:37:01Z","updated_at":"2016-04-10T13:37:01Z","html_url":"https://github.com/gartz/pushStateTree/pull/46#discussion_r59133950","pull_request_url":"https://api.github.com/repos/gartz/pushStateTree/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/gartz/pushStateTree/pulls/comments/59133950"},"html":{"href":"https://github.com/gartz/pushStateTree/pull/46#discussion_r59133950"},"pull_request":{"href":"https://api.github.com/repos/gartz/pushStateTree/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/gartz/pushStateTree/pulls/46","id":65816224,"html_url":"https://github.com/gartz/pushStateTree/pull/46","diff_url":"https://github.com/gartz/pushStateTree/pull/46.diff","patch_url":"https://github.com/gartz/pushStateTree/pull/46.patch","issue_url":"https://api.github.com/repos/gartz/pushStateTree/issues/46","number":46,"state":"open","locked":false,"title":"Fix multiple routers","user":{"login":"gartz","id":99608,"avatar_url":"https://avatars.githubusercontent.com/u/99608?v=3","gravatar_id":"","url":"https://api.github.com/users/gartz","html_url":"https://github.com/gartz","followers_url":"https://api.github.com/users/gartz/followers","following_url":"https://api.github.com/users/gartz/following{/other_user}","gists_url":"https://api.github.com/users/gartz/gists{/gist_id}","starred_url":"https://api.github.com/users/gartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gartz/subscriptions","organizations_url":"https://api.github.com/users/gartz/orgs","repos_url":"https://api.github.com/users/gartz/repos","events_url":"https://api.github.com/users/gartz/events{/privacy}","received_events_url":"https://api.github.com/users/gartz/received_events","type":"User","site_admin":false},"body":"This release will fix a multiple bugs from the lib and remove some of the deprecated features.\r\n\r\n * [x] Removed debug option and console outputs that are annoying in the debug.\r\n * [x] Make the router `pushState` and `replaceState` get only one param for the `url` and remove support to state and title. It is compatible with old implementations, but will ignore the state and title changes.\r\n * [x] Fix the multiple routers tests, to ensure that tests are in sandboxes and aren't affecting other tests.\r\n * [x] Test if all default history API methods are being wrapped.\r\n * [x] Reduce complexity on regular expressions inside the lib.\r\n * [x] Add support to enable or disable router instances, by making them listen or stop listen for window events.\r\n * [x] Fix shim for old browsers.\r\n * [x] Allow multiple routers to run at same time.\r\n * [x] Make the properties in the routers to not affect globally, like auto-redirect from beautifyLocation, so if the router is inside a basePath, it will only apply in such, not affecting other routers.","created_at":"2016-04-08T16:58:13Z","updated_at":"2016-04-10T13:37:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"930403e467db66bdd94dcf35b830e4dbea461813","assignee":{"login":"AntonioSchmidt","id":5124976,"avatar_url":"https://avatars.githubusercontent.com/u/5124976?v=3","gravatar_id":"","url":"https://api.github.com/users/AntonioSchmidt","html_url":"https://github.com/AntonioSchmidt","followers_url":"https://api.github.com/users/AntonioSchmidt/followers","following_url":"https://api.github.com/users/AntonioSchmidt/following{/other_user}","gists_url":"https://api.github.com/users/AntonioSchmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/AntonioSchmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntonioSchmidt/subscriptions","organizations_url":"https://api.github.com/users/AntonioSchmidt/orgs","repos_url":"https://api.github.com/users/AntonioSchmidt/repos","events_url":"https://api.github.com/users/AntonioSchmidt/events{/privacy}","received_events_url":"https://api.github.com/users/AntonioSchmidt/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/gartz/pushStateTree/milestones/3","html_url":"https://github.com/gartz/pushStateTree/milestones/0.15.0","labels_url":"https://api.github.com/repos/gartz/pushStateTree/milestones/3/labels","id":1670496,"number":3,"title":"0.15.0","description":"* Add Karma for testing\r\n* Migrate from jasmine to Mocha and Chai for tests\r\n* Use WEBPACK to build the lib\r\n* Add ES6 features using Babel\r\n* Add 50%+ code coverage\r\n* Add support to multiple browser env support builds","creator":{"login":"gartz","id":99608,"avatar_url":"https://avatars.githubusercontent.com/u/99608?v=3","gravatar_id":"","url":"https://api.github.com/users/gartz","html_url":"https://github.com/gartz","followers_url":"https://api.github.com/users/gartz/followers","following_url":"https://api.github.com/users/gartz/following{/other_user}","gists_url":"https://api.github.com/users/gartz/gists{/gist_id}","starred_url":"https://api.github.com/users/gartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gartz/subscriptions","organizations_url":"https://api.github.com/users/gartz/orgs","repos_url":"https://api.github.com/users/gartz/repos","events_url":"https://api.github.com/users/gartz/events{/privacy}","received_events_url":"https://api.github.com/users/gartz/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":27,"state":"open","created_at":"2016-03-28T20:38:08Z","updated_at":"2016-04-08T16:58:13Z","due_on":"2016-04-08T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/gartz/pushStateTree/pulls/46/commits","review_comments_url":"https://api.github.com/repos/gartz/pushStateTree/pulls/46/comments","review_comment_url":"https://api.github.com/repos/gartz/pushStateTree/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gartz/pushStateTree/issues/46/comments","statuses_url":"https://api.github.com/repos/gartz/pushStateTree/statuses/9e6c1bd08e8e372f6ee095407c256c61902d2c91","head":{"label":"gartz:fix-multiple-routers","ref":"fix-multiple-routers","sha":"9e6c1bd08e8e372f6ee095407c256c61902d2c91","user":{"login":"gartz","id":99608,"avatar_url":"https://avatars.githubusercontent.com/u/99608?v=3","gravatar_id":"","url":"https://api.github.com/users/gartz","html_url":"https://github.com/gartz","followers_url":"https://api.github.com/users/gartz/followers","following_url":"https://api.github.com/users/gartz/following{/other_user}","gists_url":"https://api.github.com/users/gartz/gists{/gist_id}","starred_url":"https://api.github.com/users/gartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gartz/subscriptions","organizations_url":"https://api.github.com/users/gartz/orgs","repos_url":"https://api.github.com/users/gartz/repos","events_url":"https://api.github.com/users/gartz/events{/privacy}","received_events_url":"https://api.github.com/users/gartz/received_events","type":"User","site_admin":false},"repo":{"id":18025898,"name":"pushStateTree","full_name":"gartz/pushStateTree","owner":{"login":"gartz","id":99608,"avatar_url":"https://avatars.githubusercontent.com/u/99608?v=3","gravatar_id":"","url":"https://api.github.com/users/gartz","html_url":"https://github.com/gartz","followers_url":"https://api.github.com/users/gartz/followers","following_url":"https://api.github.com/users/gartz/following{/other_user}","gists_url":"https://api.github.com/users/gartz/gists{/gist_id}","starred_url":"https://api.github.com/users/gartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gartz/subscriptions","organizations_url":"https://api.github.com/users/gartz/orgs","repos_url":"https://api.github.com/users/gartz/repos","events_url":"https://api.github.com/users/gartz/events{/privacy}","received_events_url":"https://api.github.com/users/gartz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gartz/pushStateTree","description":"A standalone powerful library to manage browser routing with nested level support, complex match expressions and on-fly rules change (convenient to lazy module loading).","fork":false,"url":"https://api.github.com/repos/gartz/pushStateTree","forks_url":"https://api.github.com/repos/gartz/pushStateTree/forks","keys_url":"https://api.github.com/repos/gartz/pushStateTree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gartz/pushStateTree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gartz/pushStateTree/teams","hooks_url":"https://api.github.com/repos/gartz/pushStateTree/hooks","issue_events_url":"https://api.github.com/repos/gartz/pushStateTree/issues/events{/number}","events_url":"https://api.github.com/repos/gartz/pushStateTree/events","assignees_url":"https://api.github.com/repos/gartz/pushStateTree/assignees{/user}","branches_url":"https://api.github.com/repos/gartz/pushStateTree/branches{/branch}","tags_url":"https://api.github.com/repos/gartz/pushStateTree/tags","blobs_url":"https://api.github.com/repos/gartz/pushStateTree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gartz/pushStateTree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gartz/pushStateTree/git/refs{/sha}","trees_url":"https://api.github.com/repos/gartz/pushStateTree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gartz/pushStateTree/statuses/{sha}","languages_url":"https://api.github.com/repos/gartz/pushStateTree/languages","stargazers_url":"https://api.github.com/repos/gartz/pushStateTree/stargazers","contributors_url":"https://api.github.com/repos/gartz/pushStateTree/contributors","subscribers_url":"https://api.github.com/repos/gartz/pushStateTree/subscribers","subscription_url":"https://api.github.com/repos/gartz/pushStateTree/subscription","commits_url":"https://api.github.com/repos/gartz/pushStateTree/commits{/sha}","git_commits_url":"https://api.github.com/repos/gartz/pushStateTree/git/commits{/sha}","comments_url":"https://api.github.com/repos/gartz/pushStateTree/comments{/number}","issue_comment_url":"https://api.github.com/repos/gartz/pushStateTree/issues/comments{/number}","contents_url":"https://api.github.com/repos/gartz/pushStateTree/contents/{+path}","compare_url":"https://api.github.com/repos/gartz/pushStateTree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gartz/pushStateTree/merges","archive_url":"https://api.github.com/repos/gartz/pushStateTree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gartz/pushStateTree/downloads","issues_url":"https://api.github.com/repos/gartz/pushStateTree/issues{/number}","pulls_url":"https://api.github.com/repos/gartz/pushStateTree/pulls{/number}","milestones_url":"https://api.github.com/repos/gartz/pushStateTree/milestones{/number}","notifications_url":"https://api.github.com/repos/gartz/pushStateTree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gartz/pushStateTree/labels{/name}","releases_url":"https://api.github.com/repos/gartz/pushStateTree/releases{/id}","deployments_url":"https://api.github.com/repos/gartz/pushStateTree/deployments","created_at":"2014-03-23T03:44:58Z","updated_at":"2016-02-26T20:40:12Z","pushed_at":"2016-04-09T06:40:10Z","git_url":"git://github.com/gartz/pushStateTree.git","ssh_url":"git@github.com:gartz/pushStateTree.git","clone_url":"https://github.com/gartz/pushStateTree.git","svn_url":"https://github.com/gartz/pushStateTree","homepage":"http://gartz.github.io/pushStateTree/","size":1253,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":14,"default_branch":"master"}},"base":{"label":"gartz:dev","ref":"dev","sha":"ecf1e67c600feb8fd6a3019f83bf4d2e8661d4c3","user":{"login":"gartz","id":99608,"avatar_url":"https://avatars.githubusercontent.com/u/99608?v=3","gravatar_id":"","url":"https://api.github.com/users/gartz","html_url":"https://github.com/gartz","followers_url":"https://api.github.com/users/gartz/followers","following_url":"https://api.github.com/users/gartz/following{/other_user}","gists_url":"https://api.github.com/users/gartz/gists{/gist_id}","starred_url":"https://api.github.com/users/gartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gartz/subscriptions","organizations_url":"https://api.github.com/users/gartz/orgs","repos_url":"https://api.github.com/users/gartz/repos","events_url":"https://api.github.com/users/gartz/events{/privacy}","received_events_url":"https://api.github.com/users/gartz/received_events","type":"User","site_admin":false},"repo":{"id":18025898,"name":"pushStateTree","full_name":"gartz/pushStateTree","owner":{"login":"gartz","id":99608,"avatar_url":"https://avatars.githubusercontent.com/u/99608?v=3","gravatar_id":"","url":"https://api.github.com/users/gartz","html_url":"https://github.com/gartz","followers_url":"https://api.github.com/users/gartz/followers","following_url":"https://api.github.com/users/gartz/following{/other_user}","gists_url":"https://api.github.com/users/gartz/gists{/gist_id}","starred_url":"https://api.github.com/users/gartz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gartz/subscriptions","organizations_url":"https://api.github.com/users/gartz/orgs","repos_url":"https://api.github.com/users/gartz/repos","events_url":"https://api.github.com/users/gartz/events{/privacy}","received_events_url":"https://api.github.com/users/gartz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gartz/pushStateTree","description":"A standalone powerful library to manage browser routing with nested level support, complex match expressions and on-fly rules change (convenient to lazy module loading).","fork":false,"url":"https://api.github.com/repos/gartz/pushStateTree","forks_url":"https://api.github.com/repos/gartz/pushStateTree/forks","keys_url":"https://api.github.com/repos/gartz/pushStateTree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gartz/pushStateTree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gartz/pushStateTree/teams","hooks_url":"https://api.github.com/repos/gartz/pushStateTree/hooks","issue_events_url":"https://api.github.com/repos/gartz/pushStateTree/issues/events{/number}","events_url":"https://api.github.com/repos/gartz/pushStateTree/events","assignees_url":"https://api.github.com/repos/gartz/pushStateTree/assignees{/user}","branches_url":"https://api.github.com/repos/gartz/pushStateTree/branches{/branch}","tags_url":"https://api.github.com/repos/gartz/pushStateTree/tags","blobs_url":"https://api.github.com/repos/gartz/pushStateTree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gartz/pushStateTree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gartz/pushStateTree/git/refs{/sha}","trees_url":"https://api.github.com/repos/gartz/pushStateTree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gartz/pushStateTree/statuses/{sha}","languages_url":"https://api.github.com/repos/gartz/pushStateTree/languages","stargazers_url":"https://api.github.com/repos/gartz/pushStateTree/stargazers","contributors_url":"https://api.github.com/repos/gartz/pushStateTree/contributors","subscribers_url":"https://api.github.com/repos/gartz/pushStateTree/subscribers","subscription_url":"https://api.github.com/repos/gartz/pushStateTree/subscription","commits_url":"https://api.github.com/repos/gartz/pushStateTree/commits{/sha}","git_commits_url":"https://api.github.com/repos/gartz/pushStateTree/git/commits{/sha}","comments_url":"https://api.github.com/repos/gartz/pushStateTree/comments{/number}","issue_comment_url":"https://api.github.com/repos/gartz/pushStateTree/issues/comments{/number}","contents_url":"https://api.github.com/repos/gartz/pushStateTree/contents/{+path}","compare_url":"https://api.github.com/repos/gartz/pushStateTree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gartz/pushStateTree/merges","archive_url":"https://api.github.com/repos/gartz/pushStateTree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gartz/pushStateTree/downloads","issues_url":"https://api.github.com/repos/gartz/pushStateTree/issues{/number}","pulls_url":"https://api.github.com/repos/gartz/pushStateTree/pulls{/number}","milestones_url":"https://api.github.com/repos/gartz/pushStateTree/milestones{/number}","notifications_url":"https://api.github.com/repos/gartz/pushStateTree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gartz/pushStateTree/labels{/name}","releases_url":"https://api.github.com/repos/gartz/pushStateTree/releases{/id}","deployments_url":"https://api.github.com/repos/gartz/pushStateTree/deployments","created_at":"2014-03-23T03:44:58Z","updated_at":"2016-02-26T20:40:12Z","pushed_at":"2016-04-09T06:40:10Z","git_url":"git://github.com/gartz/pushStateTree.git","ssh_url":"git@github.com:gartz/pushStateTree.git","clone_url":"https://github.com/gartz/pushStateTree.git","svn_url":"https://github.com/gartz/pushStateTree","homepage":"http://gartz.github.io/pushStateTree/","size":1253,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gartz/pushStateTree/pulls/46"},"html":{"href":"https://github.com/gartz/pushStateTree/pull/46"},"issue":{"href":"https://api.github.com/repos/gartz/pushStateTree/issues/46"},"comments":{"href":"https://api.github.com/repos/gartz/pushStateTree/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/gartz/pushStateTree/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/gartz/pushStateTree/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gartz/pushStateTree/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/gartz/pushStateTree/statuses/9e6c1bd08e8e372f6ee095407c256c61902d2c91"}}}}