{"action":"closed","number":19986,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19986","id":91513847,"html_url":"https://github.com/NixOS/nixpkgs/pull/19986","diff_url":"https://github.com/NixOS/nixpkgs/pull/19986.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/19986.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/19986","number":19986,"state":"closed","locked":false,"title":"matrix-synapse: Allow keys to be generated","user":{"login":"eqyiel","id":3422442,"avatar_url":"https://avatars.githubusercontent.com/u/3422442?v=3","gravatar_id":"","url":"https://api.github.com/users/eqyiel","html_url":"https://github.com/eqyiel","followers_url":"https://api.github.com/users/eqyiel/followers","following_url":"https://api.github.com/users/eqyiel/following{/other_user}","gists_url":"https://api.github.com/users/eqyiel/gists{/gist_id}","starred_url":"https://api.github.com/users/eqyiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eqyiel/subscriptions","organizations_url":"https://api.github.com/users/eqyiel/orgs","repos_url":"https://api.github.com/users/eqyiel/repos","events_url":"https://api.github.com/users/eqyiel/events{/privacy}","received_events_url":"https://api.github.com/users/eqyiel/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\n\nThe matrix-synapse user has `createHome = true;` which runs before this `preStart` script, so the home directory will always exist and this block will never execute.\n\nAlso don't include default path to keys in the configuration file, because synapse will choke if it tries to open them before they exist (even with `--generate-keys`).\n\nAny existing keys will not be overwritten: https://github.com/matrix-org/synapse/blob/9bba6ebaa903a81cd94fada114aa71e20b685adb/synapse/config/tls.py#L86-L150\n###### Things done\n- [ ] Tested using sandboxing\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\n    on non-NixOS)\n- Built on platform(s)\n  - [x] NixOS\n  - [ ] OS X\n  - [ ] Linux\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\n---\n","created_at":"2016-10-30T07:31:16Z","updated_at":"2016-11-02T09:13:48Z","closed_at":"2016-11-02T09:13:48Z","merged_at":null,"merge_commit_sha":"c0dd49575c0a0bed7d7e983a4378edba36345d0b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19986/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19986/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/19986/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/108e1755d86020f92f1060f8211a8611d4d80107","head":{"label":"eqyiel:master","ref":"master","sha":"108e1755d86020f92f1060f8211a8611d4d80107","user":{"login":"eqyiel","id":3422442,"avatar_url":"https://avatars.githubusercontent.com/u/3422442?v=3","gravatar_id":"","url":"https://api.github.com/users/eqyiel","html_url":"https://github.com/eqyiel","followers_url":"https://api.github.com/users/eqyiel/followers","following_url":"https://api.github.com/users/eqyiel/following{/other_user}","gists_url":"https://api.github.com/users/eqyiel/gists{/gist_id}","starred_url":"https://api.github.com/users/eqyiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eqyiel/subscriptions","organizations_url":"https://api.github.com/users/eqyiel/orgs","repos_url":"https://api.github.com/users/eqyiel/repos","events_url":"https://api.github.com/users/eqyiel/events{/privacy}","received_events_url":"https://api.github.com/users/eqyiel/received_events","type":"User","site_admin":false},"repo":{"id":71031767,"name":"nixpkgs","full_name":"eqyiel/nixpkgs","owner":{"login":"eqyiel","id":3422442,"avatar_url":"https://avatars.githubusercontent.com/u/3422442?v=3","gravatar_id":"","url":"https://api.github.com/users/eqyiel","html_url":"https://github.com/eqyiel","followers_url":"https://api.github.com/users/eqyiel/followers","following_url":"https://api.github.com/users/eqyiel/following{/other_user}","gists_url":"https://api.github.com/users/eqyiel/gists{/gist_id}","starred_url":"https://api.github.com/users/eqyiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eqyiel/subscriptions","organizations_url":"https://api.github.com/users/eqyiel/orgs","repos_url":"https://api.github.com/users/eqyiel/repos","events_url":"https://api.github.com/users/eqyiel/events{/privacy}","received_events_url":"https://api.github.com/users/eqyiel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eqyiel/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/eqyiel/nixpkgs","forks_url":"https://api.github.com/repos/eqyiel/nixpkgs/forks","keys_url":"https://api.github.com/repos/eqyiel/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eqyiel/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eqyiel/nixpkgs/teams","hooks_url":"https://api.github.com/repos/eqyiel/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/eqyiel/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/eqyiel/nixpkgs/events","assignees_url":"https://api.github.com/repos/eqyiel/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/eqyiel/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/eqyiel/nixpkgs/tags","blobs_url":"https://api.github.com/repos/eqyiel/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eqyiel/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eqyiel/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/eqyiel/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eqyiel/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/eqyiel/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/eqyiel/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/eqyiel/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/eqyiel/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/eqyiel/nixpkgs/subscription","commits_url":"https://api.github.com/repos/eqyiel/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/eqyiel/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/eqyiel/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/eqyiel/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/eqyiel/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/eqyiel/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eqyiel/nixpkgs/merges","archive_url":"https://api.github.com/repos/eqyiel/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eqyiel/nixpkgs/downloads","issues_url":"https://api.github.com/repos/eqyiel/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/eqyiel/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/eqyiel/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/eqyiel/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eqyiel/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/eqyiel/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/eqyiel/nixpkgs/deployments","created_at":"2016-10-16T05:20:49Z","updated_at":"2016-10-16T05:21:12Z","pushed_at":"2016-10-30T01:45:48Z","git_url":"git://github.com/eqyiel/nixpkgs.git","ssh_url":"git@github.com:eqyiel/nixpkgs.git","clone_url":"https://github.com/eqyiel/nixpkgs.git","svn_url":"https://github.com/eqyiel/nixpkgs","homepage":null,"size":370955,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"9ca0521099ab44b65c763a200f741356b6073f33","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2016-11-01T15:57:14Z","pushed_at":"2016-11-02T09:13:00Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":626612,"stargazers_count":1366,"watchers_count":1366,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1693,"mirror_url":null,"open_issues_count":1585,"forks":1693,"open_issues":1585,"watchers":1366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19986"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/19986"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/19986"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/19986/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19986/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19986/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/108e1755d86020f92f1060f8211a8611d4d80107"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":7,"review_comments":0,"commits":1,"additions":17,"deletions":13,"changed_files":1}}
{"actor":{"display_login":"rycee"}}