{"action":"created","issue":{"url":"https://api.github.com/repos/go-authboss/authboss/issues/83","repository_url":"https://api.github.com/repos/go-authboss/authboss","labels_url":"https://api.github.com/repos/go-authboss/authboss/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/go-authboss/authboss/issues/83/comments","events_url":"https://api.github.com/repos/go-authboss/authboss/issues/83/events","html_url":"https://github.com/go-authboss/authboss/pull/83","id":152909488,"number":83,"title":"Additional -Maker properties on Config for GAE support","user":{"login":"buu700","id":415435,"avatar_url":"https://avatars.githubusercontent.com/u/415435?v=3","gravatar_id":"","url":"https://api.github.com/users/buu700","html_url":"https://github.com/buu700","followers_url":"https://api.github.com/users/buu700/followers","following_url":"https://api.github.com/users/buu700/following{/other_user}","gists_url":"https://api.github.com/users/buu700/gists{/gist_id}","starred_url":"https://api.github.com/users/buu700/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buu700/subscriptions","organizations_url":"https://api.github.com/users/buu700/orgs","repos_url":"https://api.github.com/users/buu700/repos","events_url":"https://api.github.com/users/buu700/events{/privacy}","received_events_url":"https://api.github.com/users/buu700/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-05-04T01:15:25Z","updated_at":"2016-05-09T16:57:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/go-authboss/authboss/pulls/83","html_url":"https://github.com/go-authboss/authboss/pull/83","diff_url":"https://github.com/go-authboss/authboss/pull/83.diff","patch_url":"https://github.com/go-authboss/authboss/pull/83.patch"},"body":"I tried to keep everything about these new properties as consistent with CookieStoreMaker/SessionStoreMaker as I could. However, I may very well have structured this in such a way that the new -Maker functions won't always have been called by the time they're needed to have been called. I didn't do any testing or thorough investigation beyond some greps to make sure that my change wasn't obviously wrong, as I figure that with your better grasp on the broader structure and context of the code, issues of that nature will be more immediately apparent to you when you review this."},"comment":{"url":"https://api.github.com/repos/go-authboss/authboss/issues/comments/217923206","html_url":"https://github.com/go-authboss/authboss/pull/83#issuecomment-217923206","issue_url":"https://api.github.com/repos/go-authboss/authboss/issues/83","id":217923206,"user":{"login":"aarondl","id":699706,"avatar_url":"https://avatars.githubusercontent.com/u/699706?v=3","gravatar_id":"","url":"https://api.github.com/users/aarondl","html_url":"https://github.com/aarondl","followers_url":"https://api.github.com/users/aarondl/followers","following_url":"https://api.github.com/users/aarondl/following{/other_user}","gists_url":"https://api.github.com/users/aarondl/gists{/gist_id}","starred_url":"https://api.github.com/users/aarondl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarondl/subscriptions","organizations_url":"https://api.github.com/users/aarondl/orgs","repos_url":"https://api.github.com/users/aarondl/repos","events_url":"https://api.github.com/users/aarondl/events{/privacy}","received_events_url":"https://api.github.com/users/aarondl/received_events","type":"User","site_admin":false},"created_at":"2016-05-09T16:57:39Z","updated_at":"2016-05-09T16:57:39Z","body":"You'll have to make sure that you've cloned into `$GOPATH/src/\ngopkg.in/authboss.v0` and then `go test ./...`\n\nAlso it seems like maybe you're not using goimports as a replacement for\ngofmt? Else it would delete any unused imports and the only way to get them\nto stay is to name the import like this. Very nice little program as it\nauto adds and deletes your imports for you. Just thought I'd mention it in\npassing because I can't imagine manually handling imports anymore. Might\nwant to add it to your dev environment! :)\nOn May 9, 2016 9:44 AM, \"Ryan Lester\" <notifications@github.com> wrote:\n\n> Cool, I'll get rid of DisableGoroutines and add some extra info to the\n> -Maker documentation.\n>\n> As far as the go vet issue, thanks! The solution from authboss-sample is\n> working for me; it never occurred to me that one could just name an import\n> _ to explicitly mark it as not intended for direct use in the current\n> file. I'll revert that ModuleName thing as well.\n>\n> Also, how do I run the tests? go test recover/recover_test.go is just\n> complaining about not being allowed to reference the internal module.\n>\n> —\n> You are receiving this because you commented.\n> Reply to this email directly or view it on GitHub\n> <https://github.com/go-authboss/authboss/pull/83#issuecomment-217919596>\n>\n"}}