{"action":"created","issue":{"url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues/342","repository_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues/342/labels{/name}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues/342/comments","events_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues/342/events","html_url":"https://github.com/department-of-veterans-affairs/caseflow/issues/342","id":183951582,"number":342,"title":"Fix missing doc stats","user":{"login":"shanear","id":1596259,"avatar_url":"https://avatars.githubusercontent.com/u/1596259?v=3","gravatar_id":"","url":"https://api.github.com/users/shanear","html_url":"https://github.com/shanear","followers_url":"https://api.github.com/users/shanear/followers","following_url":"https://api.github.com/users/shanear/following{/other_user}","gists_url":"https://api.github.com/users/shanear/gists{/gist_id}","starred_url":"https://api.github.com/users/shanear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanear/subscriptions","organizations_url":"https://api.github.com/users/shanear/orgs","repos_url":"https://api.github.com/users/shanear/repos","events_url":"https://api.github.com/users/shanear/events{/privacy}","received_events_url":"https://api.github.com/users/shanear/received_events","type":"User","site_admin":false},"labels":[{"id":324175563,"url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/labels/bug","name":"bug","color":"fc2929","default":true},{"id":357000626,"url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/labels/caseflow-certification","name":"caseflow-certification","color":"a0dacc","default":false},{"id":481371759,"url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/labels/Ready%20for%20Dev","name":"Ready for Dev","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-19T12:46:05Z","updated_at":"2016-11-30T15:56:23Z","closed_at":null,"body":"The stats for how often a certification was missing documents isn't calculating correctly:\n\n<img width=\"964\" alt=\"screen shot 2016-10-19 at 8 47 24 am\" src=\"https://cloud.githubusercontent.com/assets/1596259/19519205/eb606908-95d8-11e6-9e04-41c574c99d3e.png\">\n\nWe should also add light unit tests for all the `Certification.was_missing_X` methods"},"comment":{"url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues/comments/263910632","html_url":"https://github.com/department-of-veterans-affairs/caseflow/issues/342#issuecomment-263910632","issue_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues/342","id":263910632,"user":{"login":"cmgiven","id":5375557,"avatar_url":"https://avatars.githubusercontent.com/u/5375557?v=3","gravatar_id":"","url":"https://api.github.com/users/cmgiven","html_url":"https://github.com/cmgiven","followers_url":"https://api.github.com/users/cmgiven/followers","following_url":"https://api.github.com/users/cmgiven/following{/other_user}","gists_url":"https://api.github.com/users/cmgiven/gists{/gist_id}","starred_url":"https://api.github.com/users/cmgiven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmgiven/subscriptions","organizations_url":"https://api.github.com/users/cmgiven/orgs","repos_url":"https://api.github.com/users/cmgiven/repos","events_url":"https://api.github.com/users/cmgiven/events{/privacy}","received_events_url":"https://api.github.com/users/cmgiven/received_events","type":"User","site_admin":false},"created_at":"2016-11-30T15:56:23Z","updated_at":"2016-11-30T15:56:23Z","body":"Central issue is that the stats logic assumes that `:form8_started_at` corresponds to the date the appeal was first opened in Caseflow. This attribute is not set, however, until all documents match, so as a result, there is never a missing document as far as the stats are concerned. Two options:\r\n\r\n1. We could use the minimum date that any document matched.\r\n2. We could begin to log the first date a given appeal was opened in Caseflow.\r\n\r\nI prefer option 2, as it's more consistent with the intent of the metric. Option 1, for example, would not register an appeal that was opened with no matching documents."}}
{"actor":{"display_login":"cmgiven"}}