{"action":"created","comment":{"url":"https://api.github.com/repos/jupyter/jupyter_client/pulls/comments/53181628","id":53181628,"diff_hunk":"@@ -104,7 +104,6 @@ def start_kernel(self, kernel_name=None, **kwargs):\n         km = self.kernel_manager_factory(connection_file=os.path.join(\n                     self.connection_dir, \"kernel-%s.json\" % kernel_id),\n                     parent=self, log=self.log, kernel_name=kernel_name,\n-                    **kwargs","path":"jupyter_client/multikernelmanager.py","position":4,"original_position":4,"commit_id":"2eb80a0adf7802df025aa1fa3c170ecabba76464","original_commit_id":"2eb80a0adf7802df025aa1fa3c170ecabba76464","user":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"body":"This line should be left alone, since `start_kernel` is meant as a passthrough for the single kernel-manager constructor.\r\n\r\nIf nothing else, one line above kernel_spec_manager is added to kwargs.","created_at":"2016-02-17T15:40:19Z","updated_at":"2016-02-17T15:40:19Z","html_url":"https://github.com/jupyter/jupyter_client/pull/128#discussion_r53181628","pull_request_url":"https://api.github.com/repos/jupyter/jupyter_client/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/jupyter/jupyter_client/pulls/comments/53181628"},"html":{"href":"https://github.com/jupyter/jupyter_client/pull/128#discussion_r53181628"},"pull_request":{"href":"https://api.github.com/repos/jupyter/jupyter_client/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/jupyter/jupyter_client/pulls/128","id":59660894,"html_url":"https://github.com/jupyter/jupyter_client/pull/128","diff_url":"https://github.com/jupyter/jupyter_client/pull/128.diff","patch_url":"https://github.com/jupyter/jupyter_client/pull/128.patch","issue_url":"https://api.github.com/repos/jupyter/jupyter_client/issues/128","number":128,"state":"open","locked":false,"title":"Avoid passing down unexpected kwargs","user":{"login":"takluyver","id":327925,"avatar_url":"https://avatars.githubusercontent.com/u/327925?v=3","gravatar_id":"","url":"https://api.github.com/users/takluyver","html_url":"https://github.com/takluyver","followers_url":"https://api.github.com/users/takluyver/followers","following_url":"https://api.github.com/users/takluyver/following{/other_user}","gists_url":"https://api.github.com/users/takluyver/gists{/gist_id}","starred_url":"https://api.github.com/users/takluyver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takluyver/subscriptions","organizations_url":"https://api.github.com/users/takluyver/orgs","repos_url":"https://api.github.com/users/takluyver/repos","events_url":"https://api.github.com/users/takluyver/events{/privacy}","received_events_url":"https://api.github.com/users/takluyver/received_events","type":"User","site_admin":false},"body":"Squashes some warnings from recent traitlets changes.\r\n\r\nThere's still another issue with KernelClient - it's passed parameters from the connection info which it doesn't use (key and signature_scheme), because it's also passed a reference to a Session object which already has those things. I'm not sure of the neatest way to resolve that.","created_at":"2016-02-17T15:35:24Z","updated_at":"2016-02-17T15:40:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4157059e0f72b9c76b79b4e9ee894171f4ea71e4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jupyter/jupyter_client/pulls/128/commits","review_comments_url":"https://api.github.com/repos/jupyter/jupyter_client/pulls/128/comments","review_comment_url":"https://api.github.com/repos/jupyter/jupyter_client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyter/jupyter_client/issues/128/comments","statuses_url":"https://api.github.com/repos/jupyter/jupyter_client/statuses/2eb80a0adf7802df025aa1fa3c170ecabba76464","head":{"label":"takluyver:traitlets-kwargs-warnings","ref":"traitlets-kwargs-warnings","sha":"2eb80a0adf7802df025aa1fa3c170ecabba76464","user":{"login":"takluyver","id":327925,"avatar_url":"https://avatars.githubusercontent.com/u/327925?v=3","gravatar_id":"","url":"https://api.github.com/users/takluyver","html_url":"https://github.com/takluyver","followers_url":"https://api.github.com/users/takluyver/followers","following_url":"https://api.github.com/users/takluyver/following{/other_user}","gists_url":"https://api.github.com/users/takluyver/gists{/gist_id}","starred_url":"https://api.github.com/users/takluyver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takluyver/subscriptions","organizations_url":"https://api.github.com/users/takluyver/orgs","repos_url":"https://api.github.com/users/takluyver/repos","events_url":"https://api.github.com/users/takluyver/events{/privacy}","received_events_url":"https://api.github.com/users/takluyver/received_events","type":"User","site_admin":false},"repo":{"id":34819800,"name":"jupyter_client","full_name":"takluyver/jupyter_client","owner":{"login":"takluyver","id":327925,"avatar_url":"https://avatars.githubusercontent.com/u/327925?v=3","gravatar_id":"","url":"https://api.github.com/users/takluyver","html_url":"https://github.com/takluyver","followers_url":"https://api.github.com/users/takluyver/followers","following_url":"https://api.github.com/users/takluyver/following{/other_user}","gists_url":"https://api.github.com/users/takluyver/gists{/gist_id}","starred_url":"https://api.github.com/users/takluyver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takluyver/subscriptions","organizations_url":"https://api.github.com/users/takluyver/orgs","repos_url":"https://api.github.com/users/takluyver/repos","events_url":"https://api.github.com/users/takluyver/events{/privacy}","received_events_url":"https://api.github.com/users/takluyver/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/takluyver/jupyter_client","description":"Jupyter protocol client APIs","fork":true,"url":"https://api.github.com/repos/takluyver/jupyter_client","forks_url":"https://api.github.com/repos/takluyver/jupyter_client/forks","keys_url":"https://api.github.com/repos/takluyver/jupyter_client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/takluyver/jupyter_client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/takluyver/jupyter_client/teams","hooks_url":"https://api.github.com/repos/takluyver/jupyter_client/hooks","issue_events_url":"https://api.github.com/repos/takluyver/jupyter_client/issues/events{/number}","events_url":"https://api.github.com/repos/takluyver/jupyter_client/events","assignees_url":"https://api.github.com/repos/takluyver/jupyter_client/assignees{/user}","branches_url":"https://api.github.com/repos/takluyver/jupyter_client/branches{/branch}","tags_url":"https://api.github.com/repos/takluyver/jupyter_client/tags","blobs_url":"https://api.github.com/repos/takluyver/jupyter_client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/takluyver/jupyter_client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/takluyver/jupyter_client/git/refs{/sha}","trees_url":"https://api.github.com/repos/takluyver/jupyter_client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/takluyver/jupyter_client/statuses/{sha}","languages_url":"https://api.github.com/repos/takluyver/jupyter_client/languages","stargazers_url":"https://api.github.com/repos/takluyver/jupyter_client/stargazers","contributors_url":"https://api.github.com/repos/takluyver/jupyter_client/contributors","subscribers_url":"https://api.github.com/repos/takluyver/jupyter_client/subscribers","subscription_url":"https://api.github.com/repos/takluyver/jupyter_client/subscription","commits_url":"https://api.github.com/repos/takluyver/jupyter_client/commits{/sha}","git_commits_url":"https://api.github.com/repos/takluyver/jupyter_client/git/commits{/sha}","comments_url":"https://api.github.com/repos/takluyver/jupyter_client/comments{/number}","issue_comment_url":"https://api.github.com/repos/takluyver/jupyter_client/issues/comments{/number}","contents_url":"https://api.github.com/repos/takluyver/jupyter_client/contents/{+path}","compare_url":"https://api.github.com/repos/takluyver/jupyter_client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/takluyver/jupyter_client/merges","archive_url":"https://api.github.com/repos/takluyver/jupyter_client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/takluyver/jupyter_client/downloads","issues_url":"https://api.github.com/repos/takluyver/jupyter_client/issues{/number}","pulls_url":"https://api.github.com/repos/takluyver/jupyter_client/pulls{/number}","milestones_url":"https://api.github.com/repos/takluyver/jupyter_client/milestones{/number}","notifications_url":"https://api.github.com/repos/takluyver/jupyter_client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/takluyver/jupyter_client/labels{/name}","releases_url":"https://api.github.com/repos/takluyver/jupyter_client/releases{/id}","deployments_url":"https://api.github.com/repos/takluyver/jupyter_client/deployments","created_at":"2015-04-29T21:42:07Z","updated_at":"2015-04-29T21:42:08Z","pushed_at":"2016-02-17T15:34:59Z","git_url":"git://github.com/takluyver/jupyter_client.git","ssh_url":"git@github.com:takluyver/jupyter_client.git","clone_url":"https://github.com/takluyver/jupyter_client.git","svn_url":"https://github.com/takluyver/jupyter_client","homepage":null,"size":1136,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupyter:master","ref":"master","sha":"7c8e0e93375b140898185becf4bfd87106fcdf55","user":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"repo":{"id":33653575,"name":"jupyter_client","full_name":"jupyter/jupyter_client","owner":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jupyter/jupyter_client","description":"Jupyter protocol client APIs","fork":false,"url":"https://api.github.com/repos/jupyter/jupyter_client","forks_url":"https://api.github.com/repos/jupyter/jupyter_client/forks","keys_url":"https://api.github.com/repos/jupyter/jupyter_client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyter/jupyter_client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyter/jupyter_client/teams","hooks_url":"https://api.github.com/repos/jupyter/jupyter_client/hooks","issue_events_url":"https://api.github.com/repos/jupyter/jupyter_client/issues/events{/number}","events_url":"https://api.github.com/repos/jupyter/jupyter_client/events","assignees_url":"https://api.github.com/repos/jupyter/jupyter_client/assignees{/user}","branches_url":"https://api.github.com/repos/jupyter/jupyter_client/branches{/branch}","tags_url":"https://api.github.com/repos/jupyter/jupyter_client/tags","blobs_url":"https://api.github.com/repos/jupyter/jupyter_client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyter/jupyter_client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyter/jupyter_client/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyter/jupyter_client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyter/jupyter_client/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyter/jupyter_client/languages","stargazers_url":"https://api.github.com/repos/jupyter/jupyter_client/stargazers","contributors_url":"https://api.github.com/repos/jupyter/jupyter_client/contributors","subscribers_url":"https://api.github.com/repos/jupyter/jupyter_client/subscribers","subscription_url":"https://api.github.com/repos/jupyter/jupyter_client/subscription","commits_url":"https://api.github.com/repos/jupyter/jupyter_client/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyter/jupyter_client/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyter/jupyter_client/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyter/jupyter_client/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyter/jupyter_client/contents/{+path}","compare_url":"https://api.github.com/repos/jupyter/jupyter_client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyter/jupyter_client/merges","archive_url":"https://api.github.com/repos/jupyter/jupyter_client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyter/jupyter_client/downloads","issues_url":"https://api.github.com/repos/jupyter/jupyter_client/issues{/number}","pulls_url":"https://api.github.com/repos/jupyter/jupyter_client/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyter/jupyter_client/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyter/jupyter_client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyter/jupyter_client/labels{/name}","releases_url":"https://api.github.com/repos/jupyter/jupyter_client/releases{/id}","deployments_url":"https://api.github.com/repos/jupyter/jupyter_client/deployments","created_at":"2015-04-09T06:57:29Z","updated_at":"2016-01-20T15:12:17Z","pushed_at":"2016-02-17T15:35:24Z","git_url":"git://github.com/jupyter/jupyter_client.git","ssh_url":"git@github.com:jupyter/jupyter_client.git","clone_url":"https://github.com/jupyter/jupyter_client.git","svn_url":"https://github.com/jupyter/jupyter_client","homepage":"http://jupyter-client.readthedocs.org/","size":2129,"stargazers_count":25,"watchers_count":25,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":18,"forks":51,"open_issues":18,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyter/jupyter_client/pulls/128"},"html":{"href":"https://github.com/jupyter/jupyter_client/pull/128"},"issue":{"href":"https://api.github.com/repos/jupyter/jupyter_client/issues/128"},"comments":{"href":"https://api.github.com/repos/jupyter/jupyter_client/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyter/jupyter_client/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyter/jupyter_client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyter/jupyter_client/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/jupyter/jupyter_client/statuses/2eb80a0adf7802df025aa1fa3c170ecabba76464"}}}}