{"action":"created","comment":{"url":"https://api.github.com/repos/serverless/serverless/pulls/comments/91020065","pull_request_review_id":11530550,"id":91020065,"diff_hunk":"@@ -0,0 +1,44 @@\n+<!--\n+title: Hello World Node.js Example","path":"docs/providers/aws/examples/hello-world/aws-csharp/README.md","position":2,"original_position":2,"commit_id":"5e5e0e84a87a41839f863efc097747c95e2e73d7","original_commit_id":"5e5e0e84a87a41839f863efc097747c95e2e73d7","user":{"login":"pmuens","id":1606004,"avatar_url":"https://avatars.githubusercontent.com/u/1606004?v=3","gravatar_id":"","url":"https://api.github.com/users/pmuens","html_url":"https://github.com/pmuens","followers_url":"https://api.github.com/users/pmuens/followers","following_url":"https://api.github.com/users/pmuens/following{/other_user}","gists_url":"https://api.github.com/users/pmuens/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuens/subscriptions","organizations_url":"https://api.github.com/users/pmuens/orgs","repos_url":"https://api.github.com/users/pmuens/repos","events_url":"https://api.github.com/users/pmuens/events{/privacy}","received_events_url":"https://api.github.com/users/pmuens/received_events","type":"User","site_admin":false},"body":"These meta information needs to be updated","created_at":"2016-12-06T06:42:38Z","updated_at":"2016-12-06T06:42:38Z","html_url":"https://github.com/serverless/serverless/pull/2863#discussion_r91020065","pull_request_url":"https://api.github.com/repos/serverless/serverless/pulls/2863","_links":{"self":{"href":"https://api.github.com/repos/serverless/serverless/pulls/comments/91020065"},"html":{"href":"https://github.com/serverless/serverless/pull/2863#discussion_r91020065"},"pull_request":{"href":"https://api.github.com/repos/serverless/serverless/pulls/2863"}}},"pull_request":{"url":"https://api.github.com/repos/serverless/serverless/pulls/2863","id":96518449,"html_url":"https://github.com/serverless/serverless/pull/2863","diff_url":"https://github.com/serverless/serverless/pull/2863.diff","patch_url":"https://github.com/serverless/serverless/pull/2863.patch","issue_url":"https://api.github.com/repos/serverless/serverless/issues/2863","number":2863,"state":"open","locked":false,"title":"created a dotnet core csharp template","user":{"login":"jimmyp","id":183908,"avatar_url":"https://avatars.githubusercontent.com/u/183908?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmyp","html_url":"https://github.com/jimmyp","followers_url":"https://api.github.com/users/jimmyp/followers","following_url":"https://api.github.com/users/jimmyp/following{/other_user}","gists_url":"https://api.github.com/users/jimmyp/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmyp/subscriptions","organizations_url":"https://api.github.com/users/jimmyp/orgs","repos_url":"https://api.github.com/users/jimmyp/repos","events_url":"https://api.github.com/users/jimmyp/events{/privacy}","received_events_url":"https://api.github.com/users/jimmyp/received_events","type":"User","site_admin":false},"body":"<!--\r\n1. Please check out and follow our Contributing Guidelines: https://github.com/serverless/serverless/blob/master/CONTRIBUTING.md\r\n2. Do not remove any section of the template. If something is not applicable leave it empty but leave it in the PR\r\n3. Please follow the template, otherwise we'll have to ask you to update it and it will take longer until your PR is merged\r\n-->\r\n\r\n## What did you implement:\r\n\r\nAdded csharp dotnetcore template support\r\n\r\nCloses #2858\r\n\r\n<!--\r\nBriefly describe the feature if no issue exists for this PR\r\n-->\r\n\r\n## How did you implement it:\r\n\r\nAdded a very simple csharp template with an integration test.\r\n\r\nThe template contains only the http handler the integration test requires. I did add a package for json serialisation and deserialisation otherwise the input and output of the handler would be just streams.\r\n\r\n<!--\r\nIf this is a nontrivial change please briefly describe your implementation so its easy for us to understand and review your code.\r\n-->\r\n\r\n## How can we verify it:\r\n\r\nI verified it by creating and running the unit test. I wasn't sure how to create a local version that included my template and do any manual testing.\r\n\r\n<!--\r\nAdd any applicable config, commands, screenshots or other resources\r\nto make it easy for us to verify this works. The easier you make it for us\r\nto review a PR, the faster we can review and merge it.\r\n\r\nIf you want to verify the template you would first create your project:\r\n\r\n`sls create --template aws-dotnet-csharp`\r\n\r\nthen you would need to build and package\r\n\r\n`./bulid.sh` (bash only for now)\r\n\r\nthen deploy as usual\r\n\r\n`sls deploy`\r\n\r\nYou should then be able to hit the hello handler via api gateway\r\n\r\n-->\r\n\r\n\r\n## Todos:\r\n\r\n- [x] Write tests\r\n- [x] Write documentation\r\n- [x] Fix linting errors\r\n- [x] Make sure code coverage hasn't dropped\r\n- [x] Provide verification config/commands/resources\r\n- [x] Enable [\"Allow edits from maintainers\"](https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/) for this PR\r\n- [x] Change ready for review message below\r\n\r\n\r\n***Is this ready for review?:*** YES\r\n\r\n","created_at":"2016-12-05T12:17:33Z","updated_at":"2016-12-06T06:51:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"911aedbd28231286f847314281980f22029b7c2f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/serverless/serverless/pulls/2863/commits","review_comments_url":"https://api.github.com/repos/serverless/serverless/pulls/2863/comments","review_comment_url":"https://api.github.com/repos/serverless/serverless/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serverless/serverless/issues/2863/comments","statuses_url":"https://api.github.com/repos/serverless/serverless/statuses/5e5e0e84a87a41839f863efc097747c95e2e73d7","head":{"label":"jimmyp:csharp_dotnetcore_template","ref":"csharp_dotnetcore_template","sha":"5e5e0e84a87a41839f863efc097747c95e2e73d7","user":{"login":"jimmyp","id":183908,"avatar_url":"https://avatars.githubusercontent.com/u/183908?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmyp","html_url":"https://github.com/jimmyp","followers_url":"https://api.github.com/users/jimmyp/followers","following_url":"https://api.github.com/users/jimmyp/following{/other_user}","gists_url":"https://api.github.com/users/jimmyp/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmyp/subscriptions","organizations_url":"https://api.github.com/users/jimmyp/orgs","repos_url":"https://api.github.com/users/jimmyp/repos","events_url":"https://api.github.com/users/jimmyp/events{/privacy}","received_events_url":"https://api.github.com/users/jimmyp/received_events","type":"User","site_admin":false},"repo":{"id":75612370,"name":"serverless","full_name":"jimmyp/serverless","owner":{"login":"jimmyp","id":183908,"avatar_url":"https://avatars.githubusercontent.com/u/183908?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmyp","html_url":"https://github.com/jimmyp","followers_url":"https://api.github.com/users/jimmyp/followers","following_url":"https://api.github.com/users/jimmyp/following{/other_user}","gists_url":"https://api.github.com/users/jimmyp/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmyp/subscriptions","organizations_url":"https://api.github.com/users/jimmyp/orgs","repos_url":"https://api.github.com/users/jimmyp/repos","events_url":"https://api.github.com/users/jimmyp/events{/privacy}","received_events_url":"https://api.github.com/users/jimmyp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimmyp/serverless","description":"Serverless Framework – Build web, mobile and IoT applications with serverless architectures using AWS Lambda, Azure Functions, Google CloudFunctions & more! – ","fork":true,"url":"https://api.github.com/repos/jimmyp/serverless","forks_url":"https://api.github.com/repos/jimmyp/serverless/forks","keys_url":"https://api.github.com/repos/jimmyp/serverless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimmyp/serverless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimmyp/serverless/teams","hooks_url":"https://api.github.com/repos/jimmyp/serverless/hooks","issue_events_url":"https://api.github.com/repos/jimmyp/serverless/issues/events{/number}","events_url":"https://api.github.com/repos/jimmyp/serverless/events","assignees_url":"https://api.github.com/repos/jimmyp/serverless/assignees{/user}","branches_url":"https://api.github.com/repos/jimmyp/serverless/branches{/branch}","tags_url":"https://api.github.com/repos/jimmyp/serverless/tags","blobs_url":"https://api.github.com/repos/jimmyp/serverless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimmyp/serverless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimmyp/serverless/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimmyp/serverless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimmyp/serverless/statuses/{sha}","languages_url":"https://api.github.com/repos/jimmyp/serverless/languages","stargazers_url":"https://api.github.com/repos/jimmyp/serverless/stargazers","contributors_url":"https://api.github.com/repos/jimmyp/serverless/contributors","subscribers_url":"https://api.github.com/repos/jimmyp/serverless/subscribers","subscription_url":"https://api.github.com/repos/jimmyp/serverless/subscription","commits_url":"https://api.github.com/repos/jimmyp/serverless/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimmyp/serverless/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimmyp/serverless/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimmyp/serverless/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimmyp/serverless/contents/{+path}","compare_url":"https://api.github.com/repos/jimmyp/serverless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimmyp/serverless/merges","archive_url":"https://api.github.com/repos/jimmyp/serverless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimmyp/serverless/downloads","issues_url":"https://api.github.com/repos/jimmyp/serverless/issues{/number}","pulls_url":"https://api.github.com/repos/jimmyp/serverless/pulls{/number}","milestones_url":"https://api.github.com/repos/jimmyp/serverless/milestones{/number}","notifications_url":"https://api.github.com/repos/jimmyp/serverless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimmyp/serverless/labels{/name}","releases_url":"https://api.github.com/repos/jimmyp/serverless/releases{/id}","deployments_url":"https://api.github.com/repos/jimmyp/serverless/deployments","created_at":"2016-12-05T10:05:51Z","updated_at":"2016-12-05T10:05:53Z","pushed_at":"2016-12-05T21:19:36Z","git_url":"git://github.com/jimmyp/serverless.git","ssh_url":"git@github.com:jimmyp/serverless.git","clone_url":"https://github.com/jimmyp/serverless.git","svn_url":"https://github.com/jimmyp/serverless","homepage":"http://www.serverless.com","size":72726,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"serverless:master","ref":"master","sha":"945e091e6df3473206656156ce387e8365a88750","user":{"login":"serverless","id":13742415,"avatar_url":"https://avatars.githubusercontent.com/u/13742415?v=3","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"repo":{"id":34302698,"name":"serverless","full_name":"serverless/serverless","owner":{"login":"serverless","id":13742415,"avatar_url":"https://avatars.githubusercontent.com/u/13742415?v=3","gravatar_id":"","url":"https://api.github.com/users/serverless","html_url":"https://github.com/serverless","followers_url":"https://api.github.com/users/serverless/followers","following_url":"https://api.github.com/users/serverless/following{/other_user}","gists_url":"https://api.github.com/users/serverless/gists{/gist_id}","starred_url":"https://api.github.com/users/serverless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serverless/subscriptions","organizations_url":"https://api.github.com/users/serverless/orgs","repos_url":"https://api.github.com/users/serverless/repos","events_url":"https://api.github.com/users/serverless/events{/privacy}","received_events_url":"https://api.github.com/users/serverless/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serverless/serverless","description":"Serverless Framework – Build web, mobile and IoT applications with serverless architectures using AWS Lambda, Azure Functions, Google CloudFunctions & more! – ","fork":false,"url":"https://api.github.com/repos/serverless/serverless","forks_url":"https://api.github.com/repos/serverless/serverless/forks","keys_url":"https://api.github.com/repos/serverless/serverless/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serverless/serverless/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serverless/serverless/teams","hooks_url":"https://api.github.com/repos/serverless/serverless/hooks","issue_events_url":"https://api.github.com/repos/serverless/serverless/issues/events{/number}","events_url":"https://api.github.com/repos/serverless/serverless/events","assignees_url":"https://api.github.com/repos/serverless/serverless/assignees{/user}","branches_url":"https://api.github.com/repos/serverless/serverless/branches{/branch}","tags_url":"https://api.github.com/repos/serverless/serverless/tags","blobs_url":"https://api.github.com/repos/serverless/serverless/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serverless/serverless/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serverless/serverless/git/refs{/sha}","trees_url":"https://api.github.com/repos/serverless/serverless/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serverless/serverless/statuses/{sha}","languages_url":"https://api.github.com/repos/serverless/serverless/languages","stargazers_url":"https://api.github.com/repos/serverless/serverless/stargazers","contributors_url":"https://api.github.com/repos/serverless/serverless/contributors","subscribers_url":"https://api.github.com/repos/serverless/serverless/subscribers","subscription_url":"https://api.github.com/repos/serverless/serverless/subscription","commits_url":"https://api.github.com/repos/serverless/serverless/commits{/sha}","git_commits_url":"https://api.github.com/repos/serverless/serverless/git/commits{/sha}","comments_url":"https://api.github.com/repos/serverless/serverless/comments{/number}","issue_comment_url":"https://api.github.com/repos/serverless/serverless/issues/comments{/number}","contents_url":"https://api.github.com/repos/serverless/serverless/contents/{+path}","compare_url":"https://api.github.com/repos/serverless/serverless/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serverless/serverless/merges","archive_url":"https://api.github.com/repos/serverless/serverless/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serverless/serverless/downloads","issues_url":"https://api.github.com/repos/serverless/serverless/issues{/number}","pulls_url":"https://api.github.com/repos/serverless/serverless/pulls{/number}","milestones_url":"https://api.github.com/repos/serverless/serverless/milestones{/number}","notifications_url":"https://api.github.com/repos/serverless/serverless/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serverless/serverless/labels{/name}","releases_url":"https://api.github.com/repos/serverless/serverless/releases{/id}","deployments_url":"https://api.github.com/repos/serverless/serverless/deployments","created_at":"2015-04-21T03:48:40Z","updated_at":"2016-12-06T04:05:48Z","pushed_at":"2016-12-06T04:30:38Z","git_url":"git://github.com/serverless/serverless.git","ssh_url":"git@github.com:serverless/serverless.git","clone_url":"https://github.com/serverless/serverless.git","svn_url":"https://github.com/serverless/serverless","homepage":"http://www.serverless.com","size":91714,"stargazers_count":13170,"watchers_count":13170,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1082,"mirror_url":null,"open_issues_count":203,"forks":1082,"open_issues":203,"watchers":13170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serverless/serverless/pulls/2863"},"html":{"href":"https://github.com/serverless/serverless/pull/2863"},"issue":{"href":"https://api.github.com/repos/serverless/serverless/issues/2863"},"comments":{"href":"https://api.github.com/repos/serverless/serverless/issues/2863/comments"},"review_comments":{"href":"https://api.github.com/repos/serverless/serverless/pulls/2863/comments"},"review_comment":{"href":"https://api.github.com/repos/serverless/serverless/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serverless/serverless/pulls/2863/commits"},"statuses":{"href":"https://api.github.com/repos/serverless/serverless/statuses/5e5e0e84a87a41839f863efc097747c95e2e73d7"}}}}
{"actor":{"display_login":"pmuens"}}