{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/EntityFramework/issues/6176","repository_url":"https://api.github.com/repos/aspnet/EntityFramework","labels_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/6176/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/6176/comments","events_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/6176/events","html_url":"https://github.com/aspnet/EntityFramework/issues/6176","id":167814952,"number":6176,"title":"Publish Microsoft.EntityFrameworkCore.Relational.Tests as a nuget?","user":{"login":"roji","id":1862641,"avatar_url":"https://avatars.githubusercontent.com/u/1862641?v=3","gravatar_id":"","url":"https://api.github.com/users/roji","html_url":"https://github.com/roji","followers_url":"https://api.github.com/users/roji/followers","following_url":"https://api.github.com/users/roji/following{/other_user}","gists_url":"https://api.github.com/users/roji/gists{/gist_id}","starred_url":"https://api.github.com/users/roji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roji/subscriptions","organizations_url":"https://api.github.com/users/roji/orgs","repos_url":"https://api.github.com/users/roji/repos","events_url":"https://api.github.com/users/roji/events{/privacy}","received_events_url":"https://api.github.com/users/roji/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"ajcvickers","id":1430078,"avatar_url":"https://avatars.githubusercontent.com/u/1430078?v=3","gravatar_id":"","url":"https://api.github.com/users/ajcvickers","html_url":"https://github.com/ajcvickers","followers_url":"https://api.github.com/users/ajcvickers/followers","following_url":"https://api.github.com/users/ajcvickers/following{/other_user}","gists_url":"https://api.github.com/users/ajcvickers/gists{/gist_id}","starred_url":"https://api.github.com/users/ajcvickers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajcvickers/subscriptions","organizations_url":"https://api.github.com/users/ajcvickers/orgs","repos_url":"https://api.github.com/users/ajcvickers/repos","events_url":"https://api.github.com/users/ajcvickers/events{/privacy}","received_events_url":"https://api.github.com/users/ajcvickers/received_events","type":"User","site_admin":false},"assignees":[{"login":"ajcvickers","id":1430078,"avatar_url":"https://avatars.githubusercontent.com/u/1430078?v=3","gravatar_id":"","url":"https://api.github.com/users/ajcvickers","html_url":"https://github.com/ajcvickers","followers_url":"https://api.github.com/users/ajcvickers/followers","following_url":"https://api.github.com/users/ajcvickers/following{/other_user}","gists_url":"https://api.github.com/users/ajcvickers/gists{/gist_id}","starred_url":"https://api.github.com/users/ajcvickers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajcvickers/subscriptions","organizations_url":"https://api.github.com/users/ajcvickers/orgs","repos_url":"https://api.github.com/users/ajcvickers/repos","events_url":"https://api.github.com/users/ajcvickers/events{/privacy}","received_events_url":"https://api.github.com/users/ajcvickers/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2016-07-27T09:51:57Z","updated_at":"2016-08-10T19:34:04Z","closed_at":"2016-08-10T19:34:04Z","body":"EFCore already provider the specification test suites as nuget packages for consumption by providers. This is great as it allows providers to automatically check if they implement EFCore behavior correctly, etc.\r\n\r\nThere's also Microsoft.EntityFrameworkCore.Relational.Tests, which contains unit (rather than functional/integration) tests on EFCore components. Aside from running these tests directly, base classes in this project are also used by provider-specific unit test suites (e.g. Microsoft.EntityFrameworkCore.SqlServer.Tests.Migrations) to test their own implementations of various EFCore relational components. Since this package isn't published as a nuget it's not possible for external providers to use it, only SqlServer and Sqlite which happen to be in the solution.\r\n\r\nIt seems like a refactor may be in order: split Microsoft.EntityFrameworkCore.Relational.Tests into one project which contains actual tests to run on relational components, and another project which contains base classes for consumption by providers (and published as a nuget).\r\n\r\nThis obviously isn't very urgent, I'm currently working around it by copying source files into my own project.\r\n\r\nI asked for this before in https://github.com/aspnet/EntityFramework/issues/3016#issuecomment-139851543 but there were definitely more important things back then."},"comment":{"url":"https://api.github.com/repos/aspnet/EntityFramework/issues/comments/238978637","html_url":"https://github.com/aspnet/EntityFramework/issues/6176#issuecomment-238978637","issue_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/6176","id":238978637,"user":{"login":"ajcvickers","id":1430078,"avatar_url":"https://avatars.githubusercontent.com/u/1430078?v=3","gravatar_id":"","url":"https://api.github.com/users/ajcvickers","html_url":"https://github.com/ajcvickers","followers_url":"https://api.github.com/users/ajcvickers/followers","following_url":"https://api.github.com/users/ajcvickers/following{/other_user}","gists_url":"https://api.github.com/users/ajcvickers/gists{/gist_id}","starred_url":"https://api.github.com/users/ajcvickers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajcvickers/subscriptions","organizations_url":"https://api.github.com/users/ajcvickers/orgs","repos_url":"https://api.github.com/users/ajcvickers/repos","events_url":"https://api.github.com/users/ajcvickers/events{/privacy}","received_events_url":"https://api.github.com/users/ajcvickers/received_events","type":"User","site_admin":false},"created_at":"2016-08-10T19:34:04Z","updated_at":"2016-08-10T19:34:04Z","body":"@roji @ErikEJ (and anyone else interested). We discussed in triage and we would likely accept pull requests to move the following from the unit tests into the specification tests:\r\n* EntityFrameworkServiceCollectionExtensionsTest\r\n* MigrationSqlGeneratorTestBase\r\n\r\nI'm going to close this issue as discussion."}}
{"actor":{"display_login":"ajcvickers"}}