{"action":"closed","number":229,"pull_request":{"url":"https://api.github.com/repos/oddnetworks/oddworks/pulls/229","id":90369524,"html_url":"https://github.com/oddnetworks/oddworks/pull/229","diff_url":"https://github.com/oddnetworks/oddworks/pull/229.diff","patch_url":"https://github.com/oddnetworks/oddworks/pull/229.patch","issue_url":"https://api.github.com/repos/oddnetworks/oddworks/issues/229","number":229,"state":"closed","locked":false,"title":"Errors on includes","user":{"login":"aljachimiak","id":1467678,"avatar_url":"https://avatars.githubusercontent.com/u/1467678?v=3","gravatar_id":"","url":"https://api.github.com/users/aljachimiak","html_url":"https://github.com/aljachimiak","followers_url":"https://api.github.com/users/aljachimiak/followers","following_url":"https://api.github.com/users/aljachimiak/following{/other_user}","gists_url":"https://api.github.com/users/aljachimiak/gists{/gist_id}","starred_url":"https://api.github.com/users/aljachimiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljachimiak/subscriptions","organizations_url":"https://api.github.com/users/aljachimiak/orgs","repos_url":"https://api.github.com/users/aljachimiak/repos","events_url":"https://api.github.com/users/aljachimiak/events{/privacy}","received_events_url":"https://api.github.com/users/aljachimiak/received_events","type":"User","site_admin":false},"body":"Issue #160 Came to a new conclusion.  These changes should satisfy the root of these.\r\n- for `response-jsonapi`, there is a new config option called `options.allowPartialIncluded`\r\n    - if true -> a query with `?includes=foo` that has some missing references will respond with only the entities that are present in the db\r\n    - if false -> the response is a valid jsonapi errors response with the 1st error reporting on the main issue, and the following errors reports on the entities missing from the db\r\n- Alters the tests that were using collections with missing entities to use `options.allowPartialIncluded: true`\r\n- Adds a test for the returned errors array when `options.allowPartialIncluded` is false\r\n\r\nNOTE - a similar response should come from relationships endpoint.  That should probably get it's own endpoint.","created_at":"2016-10-21T11:45:41Z","updated_at":"2016-10-21T14:38:00Z","closed_at":"2016-10-21T14:38:00Z","merged_at":"2016-10-21T14:38:00Z","merge_commit_sha":"92bc86711cdccb03005532a5f66c2641621de0ee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/oddnetworks/oddworks/pulls/229/commits","review_comments_url":"https://api.github.com/repos/oddnetworks/oddworks/pulls/229/comments","review_comment_url":"https://api.github.com/repos/oddnetworks/oddworks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oddnetworks/oddworks/issues/229/comments","statuses_url":"https://api.github.com/repos/oddnetworks/oddworks/statuses/a9cdebf1bcda92a5ccd379e415f219bc33385650","head":{"label":"aljachimiak:errors_on_includes","ref":"errors_on_includes","sha":"a9cdebf1bcda92a5ccd379e415f219bc33385650","user":{"login":"aljachimiak","id":1467678,"avatar_url":"https://avatars.githubusercontent.com/u/1467678?v=3","gravatar_id":"","url":"https://api.github.com/users/aljachimiak","html_url":"https://github.com/aljachimiak","followers_url":"https://api.github.com/users/aljachimiak/followers","following_url":"https://api.github.com/users/aljachimiak/following{/other_user}","gists_url":"https://api.github.com/users/aljachimiak/gists{/gist_id}","starred_url":"https://api.github.com/users/aljachimiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljachimiak/subscriptions","organizations_url":"https://api.github.com/users/aljachimiak/orgs","repos_url":"https://api.github.com/users/aljachimiak/repos","events_url":"https://api.github.com/users/aljachimiak/events{/privacy}","received_events_url":"https://api.github.com/users/aljachimiak/received_events","type":"User","site_admin":false},"repo":{"id":64186164,"name":"oddworks","full_name":"aljachimiak/oddworks","owner":{"login":"aljachimiak","id":1467678,"avatar_url":"https://avatars.githubusercontent.com/u/1467678?v=3","gravatar_id":"","url":"https://api.github.com/users/aljachimiak","html_url":"https://github.com/aljachimiak","followers_url":"https://api.github.com/users/aljachimiak/followers","following_url":"https://api.github.com/users/aljachimiak/following{/other_user}","gists_url":"https://api.github.com/users/aljachimiak/gists{/gist_id}","starred_url":"https://api.github.com/users/aljachimiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljachimiak/subscriptions","organizations_url":"https://api.github.com/users/aljachimiak/orgs","repos_url":"https://api.github.com/users/aljachimiak/repos","events_url":"https://api.github.com/users/aljachimiak/events{/privacy}","received_events_url":"https://api.github.com/users/aljachimiak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aljachimiak/oddworks","description":"OTT Video Platform for Roku, Apple, Android, Fire TV, XBOX, and more","fork":true,"url":"https://api.github.com/repos/aljachimiak/oddworks","forks_url":"https://api.github.com/repos/aljachimiak/oddworks/forks","keys_url":"https://api.github.com/repos/aljachimiak/oddworks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aljachimiak/oddworks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aljachimiak/oddworks/teams","hooks_url":"https://api.github.com/repos/aljachimiak/oddworks/hooks","issue_events_url":"https://api.github.com/repos/aljachimiak/oddworks/issues/events{/number}","events_url":"https://api.github.com/repos/aljachimiak/oddworks/events","assignees_url":"https://api.github.com/repos/aljachimiak/oddworks/assignees{/user}","branches_url":"https://api.github.com/repos/aljachimiak/oddworks/branches{/branch}","tags_url":"https://api.github.com/repos/aljachimiak/oddworks/tags","blobs_url":"https://api.github.com/repos/aljachimiak/oddworks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aljachimiak/oddworks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aljachimiak/oddworks/git/refs{/sha}","trees_url":"https://api.github.com/repos/aljachimiak/oddworks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aljachimiak/oddworks/statuses/{sha}","languages_url":"https://api.github.com/repos/aljachimiak/oddworks/languages","stargazers_url":"https://api.github.com/repos/aljachimiak/oddworks/stargazers","contributors_url":"https://api.github.com/repos/aljachimiak/oddworks/contributors","subscribers_url":"https://api.github.com/repos/aljachimiak/oddworks/subscribers","subscription_url":"https://api.github.com/repos/aljachimiak/oddworks/subscription","commits_url":"https://api.github.com/repos/aljachimiak/oddworks/commits{/sha}","git_commits_url":"https://api.github.com/repos/aljachimiak/oddworks/git/commits{/sha}","comments_url":"https://api.github.com/repos/aljachimiak/oddworks/comments{/number}","issue_comment_url":"https://api.github.com/repos/aljachimiak/oddworks/issues/comments{/number}","contents_url":"https://api.github.com/repos/aljachimiak/oddworks/contents/{+path}","compare_url":"https://api.github.com/repos/aljachimiak/oddworks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aljachimiak/oddworks/merges","archive_url":"https://api.github.com/repos/aljachimiak/oddworks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aljachimiak/oddworks/downloads","issues_url":"https://api.github.com/repos/aljachimiak/oddworks/issues{/number}","pulls_url":"https://api.github.com/repos/aljachimiak/oddworks/pulls{/number}","milestones_url":"https://api.github.com/repos/aljachimiak/oddworks/milestones{/number}","notifications_url":"https://api.github.com/repos/aljachimiak/oddworks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aljachimiak/oddworks/labels{/name}","releases_url":"https://api.github.com/repos/aljachimiak/oddworks/releases{/id}","deployments_url":"https://api.github.com/repos/aljachimiak/oddworks/deployments","created_at":"2016-07-26T03:16:54Z","updated_at":"2016-07-26T03:16:55Z","pushed_at":"2016-10-21T14:37:37Z","git_url":"git://github.com/aljachimiak/oddworks.git","ssh_url":"git@github.com:aljachimiak/oddworks.git","clone_url":"https://github.com/aljachimiak/oddworks.git","svn_url":"https://github.com/aljachimiak/oddworks","homepage":"https://www.oddnetworks.com","size":894,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oddnetworks:master","ref":"master","sha":"559ef7498cd678264f490e18640479522c9b689d","user":{"login":"oddnetworks","id":7726625,"avatar_url":"https://avatars.githubusercontent.com/u/7726625?v=3","gravatar_id":"","url":"https://api.github.com/users/oddnetworks","html_url":"https://github.com/oddnetworks","followers_url":"https://api.github.com/users/oddnetworks/followers","following_url":"https://api.github.com/users/oddnetworks/following{/other_user}","gists_url":"https://api.github.com/users/oddnetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/oddnetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oddnetworks/subscriptions","organizations_url":"https://api.github.com/users/oddnetworks/orgs","repos_url":"https://api.github.com/users/oddnetworks/repos","events_url":"https://api.github.com/users/oddnetworks/events{/privacy}","received_events_url":"https://api.github.com/users/oddnetworks/received_events","type":"Organization","site_admin":false},"repo":{"id":52802668,"name":"oddworks","full_name":"oddnetworks/oddworks","owner":{"login":"oddnetworks","id":7726625,"avatar_url":"https://avatars.githubusercontent.com/u/7726625?v=3","gravatar_id":"","url":"https://api.github.com/users/oddnetworks","html_url":"https://github.com/oddnetworks","followers_url":"https://api.github.com/users/oddnetworks/followers","following_url":"https://api.github.com/users/oddnetworks/following{/other_user}","gists_url":"https://api.github.com/users/oddnetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/oddnetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oddnetworks/subscriptions","organizations_url":"https://api.github.com/users/oddnetworks/orgs","repos_url":"https://api.github.com/users/oddnetworks/repos","events_url":"https://api.github.com/users/oddnetworks/events{/privacy}","received_events_url":"https://api.github.com/users/oddnetworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oddnetworks/oddworks","description":"OTT Video Platform for Roku, Apple, Android, Fire TV, XBOX, and more","fork":false,"url":"https://api.github.com/repos/oddnetworks/oddworks","forks_url":"https://api.github.com/repos/oddnetworks/oddworks/forks","keys_url":"https://api.github.com/repos/oddnetworks/oddworks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oddnetworks/oddworks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oddnetworks/oddworks/teams","hooks_url":"https://api.github.com/repos/oddnetworks/oddworks/hooks","issue_events_url":"https://api.github.com/repos/oddnetworks/oddworks/issues/events{/number}","events_url":"https://api.github.com/repos/oddnetworks/oddworks/events","assignees_url":"https://api.github.com/repos/oddnetworks/oddworks/assignees{/user}","branches_url":"https://api.github.com/repos/oddnetworks/oddworks/branches{/branch}","tags_url":"https://api.github.com/repos/oddnetworks/oddworks/tags","blobs_url":"https://api.github.com/repos/oddnetworks/oddworks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oddnetworks/oddworks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oddnetworks/oddworks/git/refs{/sha}","trees_url":"https://api.github.com/repos/oddnetworks/oddworks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oddnetworks/oddworks/statuses/{sha}","languages_url":"https://api.github.com/repos/oddnetworks/oddworks/languages","stargazers_url":"https://api.github.com/repos/oddnetworks/oddworks/stargazers","contributors_url":"https://api.github.com/repos/oddnetworks/oddworks/contributors","subscribers_url":"https://api.github.com/repos/oddnetworks/oddworks/subscribers","subscription_url":"https://api.github.com/repos/oddnetworks/oddworks/subscription","commits_url":"https://api.github.com/repos/oddnetworks/oddworks/commits{/sha}","git_commits_url":"https://api.github.com/repos/oddnetworks/oddworks/git/commits{/sha}","comments_url":"https://api.github.com/repos/oddnetworks/oddworks/comments{/number}","issue_comment_url":"https://api.github.com/repos/oddnetworks/oddworks/issues/comments{/number}","contents_url":"https://api.github.com/repos/oddnetworks/oddworks/contents/{+path}","compare_url":"https://api.github.com/repos/oddnetworks/oddworks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oddnetworks/oddworks/merges","archive_url":"https://api.github.com/repos/oddnetworks/oddworks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oddnetworks/oddworks/downloads","issues_url":"https://api.github.com/repos/oddnetworks/oddworks/issues{/number}","pulls_url":"https://api.github.com/repos/oddnetworks/oddworks/pulls{/number}","milestones_url":"https://api.github.com/repos/oddnetworks/oddworks/milestones{/number}","notifications_url":"https://api.github.com/repos/oddnetworks/oddworks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oddnetworks/oddworks/labels{/name}","releases_url":"https://api.github.com/repos/oddnetworks/oddworks/releases{/id}","deployments_url":"https://api.github.com/repos/oddnetworks/oddworks/deployments","created_at":"2016-02-29T15:42:35Z","updated_at":"2016-09-30T20:04:41Z","pushed_at":"2016-10-21T14:38:01Z","git_url":"git://github.com/oddnetworks/oddworks.git","ssh_url":"git@github.com:oddnetworks/oddworks.git","clone_url":"https://github.com/oddnetworks/oddworks.git","svn_url":"https://github.com/oddnetworks/oddworks","homepage":"https://www.oddnetworks.com","size":1184,"stargazers_count":225,"watchers_count":225,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":29,"forks":33,"open_issues":29,"watchers":225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oddnetworks/oddworks/pulls/229"},"html":{"href":"https://github.com/oddnetworks/oddworks/pull/229"},"issue":{"href":"https://api.github.com/repos/oddnetworks/oddworks/issues/229"},"comments":{"href":"https://api.github.com/repos/oddnetworks/oddworks/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/oddnetworks/oddworks/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/oddnetworks/oddworks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oddnetworks/oddworks/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/oddnetworks/oddworks/statuses/a9cdebf1bcda92a5ccd379e415f219bc33385650"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"blainsmith","id":483829,"avatar_url":"https://avatars.githubusercontent.com/u/483829?v=3","gravatar_id":"","url":"https://api.github.com/users/blainsmith","html_url":"https://github.com/blainsmith","followers_url":"https://api.github.com/users/blainsmith/followers","following_url":"https://api.github.com/users/blainsmith/following{/other_user}","gists_url":"https://api.github.com/users/blainsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/blainsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blainsmith/subscriptions","organizations_url":"https://api.github.com/users/blainsmith/orgs","repos_url":"https://api.github.com/users/blainsmith/repos","events_url":"https://api.github.com/users/blainsmith/events{/privacy}","received_events_url":"https://api.github.com/users/blainsmith/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":117,"deletions":29,"changed_files":2}}
{"actor":{"display_login":"blainsmith"}}