{"action":"created","comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/92964693","pull_request_review_id":13485678,"id":92964693,"diff_hunk":"@@ -1138,7 +1138,7 @@\n +     * @param neighborBlock The updated block.\n +     * @param neighborPos The updated block's position.\n +     */\n-+    public void func_190962_b(IBlockState p_190962_1_, World p_190962_2_, BlockPos p_190962_3_, Block p_190962_4_, BlockPos p_190962_5_){}\n++    public void onNeighborChangeObserver(IBlockState state, World world, BlockPos pos, Block neighborBlock, BlockPos neighborPos){}","path":"patches/minecraft/net/minecraft/block/Block.java.patch","position":null,"original_position":5,"commit_id":"d0944947f4b4549165bc7332c2df1b581882bbd9","original_commit_id":"d0944947f4b4549165bc7332c2df1b581882bbd9","user":{"login":"williewillus","id":2015032,"avatar_url":"https://avatars.githubusercontent.com/u/2015032?v=3","gravatar_id":"","url":"https://api.github.com/users/williewillus","html_url":"https://github.com/williewillus","followers_url":"https://api.github.com/users/williewillus/followers","following_url":"https://api.github.com/users/williewillus/following{/other_user}","gists_url":"https://api.github.com/users/williewillus/gists{/gist_id}","starred_url":"https://api.github.com/users/williewillus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williewillus/subscriptions","organizations_url":"https://api.github.com/users/williewillus/orgs","repos_url":"https://api.github.com/users/williewillus/repos","events_url":"https://api.github.com/users/williewillus/events{/privacy}","received_events_url":"https://api.github.com/users/williewillus/received_events","type":"User","site_admin":false},"body":"Regardless of grammar I don't think it's that clear on first sight. Is the observer the block that this is called on? I agree with `observedNeighborChange` or `onObservedChange`","created_at":"2016-12-19T03:43:32Z","updated_at":"2016-12-19T03:43:32Z","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3547#discussion_r92964693","pull_request_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3547","_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/92964693"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/3547#discussion_r92964693"},"pull_request":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3547"}}},"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3547","id":98467713,"html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3547","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3547.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3547.patch","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3547","number":3547,"state":"open","locked":false,"title":"Add IObserver interface for listening to Observer neighbor updates","user":{"login":"mezz","id":916092,"avatar_url":"https://avatars.githubusercontent.com/u/916092?v=3","gravatar_id":"","url":"https://api.github.com/users/mezz","html_url":"https://github.com/mezz","followers_url":"https://api.github.com/users/mezz/followers","following_url":"https://api.github.com/users/mezz/following{/other_user}","gists_url":"https://api.github.com/users/mezz/gists{/gist_id}","starred_url":"https://api.github.com/users/mezz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mezz/subscriptions","organizations_url":"https://api.github.com/users/mezz/orgs","repos_url":"https://api.github.com/users/mezz/repos","events_url":"https://api.github.com/users/mezz/events{/privacy}","received_events_url":"https://api.github.com/users/mezz/received_events","type":"User","site_admin":false},"body":"PR from @asiekierka \r\n\r\nThis allows modded blocks to receive the exact same updates that the new Observers do.\r\n\r\nTested and it works as expected.","created_at":"2016-12-18T07:56:03Z","updated_at":"2016-12-19T03:43:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"346a3efa7b87455631e3498d13b8bcad661d76da","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3547/commits","review_comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3547/comments","review_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3547/comments","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/d0944947f4b4549165bc7332c2df1b581882bbd9","head":{"label":"mezz:iobserver","ref":"iobserver","sha":"d0944947f4b4549165bc7332c2df1b581882bbd9","user":{"login":"mezz","id":916092,"avatar_url":"https://avatars.githubusercontent.com/u/916092?v=3","gravatar_id":"","url":"https://api.github.com/users/mezz","html_url":"https://github.com/mezz","followers_url":"https://api.github.com/users/mezz/followers","following_url":"https://api.github.com/users/mezz/following{/other_user}","gists_url":"https://api.github.com/users/mezz/gists{/gist_id}","starred_url":"https://api.github.com/users/mezz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mezz/subscriptions","organizations_url":"https://api.github.com/users/mezz/orgs","repos_url":"https://api.github.com/users/mezz/repos","events_url":"https://api.github.com/users/mezz/events{/privacy}","received_events_url":"https://api.github.com/users/mezz/received_events","type":"User","site_admin":false},"repo":{"id":22802638,"name":"MinecraftForge","full_name":"mezz/MinecraftForge","owner":{"login":"mezz","id":916092,"avatar_url":"https://avatars.githubusercontent.com/u/916092?v=3","gravatar_id":"","url":"https://api.github.com/users/mezz","html_url":"https://github.com/mezz","followers_url":"https://api.github.com/users/mezz/followers","following_url":"https://api.github.com/users/mezz/following{/other_user}","gists_url":"https://api.github.com/users/mezz/gists{/gist_id}","starred_url":"https://api.github.com/users/mezz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mezz/subscriptions","organizations_url":"https://api.github.com/users/mezz/orgs","repos_url":"https://api.github.com/users/mezz/repos","events_url":"https://api.github.com/users/mezz/events{/privacy}","received_events_url":"https://api.github.com/users/mezz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mezz/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":true,"url":"https://api.github.com/repos/mezz/MinecraftForge","forks_url":"https://api.github.com/repos/mezz/MinecraftForge/forks","keys_url":"https://api.github.com/repos/mezz/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mezz/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mezz/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/mezz/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/mezz/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/mezz/MinecraftForge/events","assignees_url":"https://api.github.com/repos/mezz/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/mezz/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/mezz/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/mezz/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mezz/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mezz/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/mezz/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mezz/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/mezz/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/mezz/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/mezz/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/mezz/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/mezz/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/mezz/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/mezz/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/mezz/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/mezz/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/mezz/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/mezz/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mezz/MinecraftForge/merges","archive_url":"https://api.github.com/repos/mezz/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mezz/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/mezz/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/mezz/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/mezz/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/mezz/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mezz/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/mezz/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/mezz/MinecraftForge/deployments","created_at":"2014-08-10T05:48:41Z","updated_at":"2016-05-06T23:35:24Z","pushed_at":"2016-12-19T03:07:53Z","git_url":"git://github.com/mezz/MinecraftForge.git","ssh_url":"git@github.com:mezz/MinecraftForge.git","clone_url":"https://github.com/mezz/MinecraftForge.git","svn_url":"https://github.com/mezz/MinecraftForge","homepage":"","size":88684,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"MinecraftForge:1.11.x","ref":"1.11.x","sha":"b9ebc44790d3ed91d6bedd5ff8601021f424e987","user":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"repo":{"id":3301400,"name":"MinecraftForge","full_name":"MinecraftForge/MinecraftForge","owner":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MinecraftForge/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":false,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","forks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/forks","keys_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/events","assignees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/merges","archive_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/deployments","created_at":"2012-01-30T01:35:01Z","updated_at":"2016-12-18T12:28:07Z","pushed_at":"2016-12-19T03:17:01Z","git_url":"git://github.com/MinecraftForge/MinecraftForge.git","ssh_url":"git@github.com:MinecraftForge/MinecraftForge.git","clone_url":"https://github.com/MinecraftForge/MinecraftForge.git","svn_url":"https://github.com/MinecraftForge/MinecraftForge","homepage":"","size":89001,"stargazers_count":1650,"watchers_count":1650,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":850,"mirror_url":null,"open_issues_count":251,"forks":850,"open_issues":251,"watchers":1650,"default_branch":"1.11.x"}},"_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3547"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/3547"},"issue":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3547"},"comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3547/comments"},"review_comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3547/comments"},"review_comment":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3547/commits"},"statuses":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/d0944947f4b4549165bc7332c2df1b581882bbd9"}}}}
{"actor":{"display_login":"williewillus"}}