{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/9796","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/9796/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/9796/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/9796/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/9796","id":162074560,"number":9796,"title":"Update express-graphql to version 0.5.3","user":{"login":"perlerd","id":19549049,"avatar_url":"https://avatars.githubusercontent.com/u/19549049?v=3","gravatar_id":"","url":"https://api.github.com/users/perlerd","html_url":"https://github.com/perlerd","followers_url":"https://api.github.com/users/perlerd/followers","following_url":"https://api.github.com/users/perlerd/following{/other_user}","gists_url":"https://api.github.com/users/perlerd/gists{/gist_id}","starred_url":"https://api.github.com/users/perlerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perlerd/subscriptions","organizations_url":"https://api.github.com/users/perlerd/orgs","repos_url":"https://api.github.com/users/perlerd/repos","events_url":"https://api.github.com/users/perlerd/events{/privacy}","received_events_url":"https://api.github.com/users/perlerd/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Revision%20needed","name":"Revision needed","color":"0e8a16"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-06-24T04:37:22Z","updated_at":"2016-06-26T10:16:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/9796","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/9796","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/9796.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/9796.patch"},"body":"The update of express-graphql to version 0.5.3 caused [this issue](https://github.com/graphql/express-graphql/issues/96). This change should fix this issue. To fix it, I followed [the suggestions](https://github.com/Microsoft/TypeScript/issues/5565#issuecomment-155216760) made by [Anders Hejlsberg](https://github.com/ahejlsberg)."},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/228594076","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/9796#issuecomment-228594076","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/9796","id":228594076,"user":{"login":"perlerd","id":19549049,"avatar_url":"https://avatars.githubusercontent.com/u/19549049?v=3","gravatar_id":"","url":"https://api.github.com/users/perlerd","html_url":"https://github.com/perlerd","followers_url":"https://api.github.com/users/perlerd/followers","following_url":"https://api.github.com/users/perlerd/following{/other_user}","gists_url":"https://api.github.com/users/perlerd/gists{/gist_id}","starred_url":"https://api.github.com/users/perlerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perlerd/subscriptions","organizations_url":"https://api.github.com/users/perlerd/orgs","repos_url":"https://api.github.com/users/perlerd/repos","events_url":"https://api.github.com/users/perlerd/events{/privacy}","received_events_url":"https://api.github.com/users/perlerd/received_events","type":"User","site_admin":false},"created_at":"2016-06-26T10:16:15Z","updated_at":"2016-06-26T10:16:15Z","body":"@isman-usoh: With the current implementation, it is possible to access the declared types using `import {Middleware, Options, OptionsObj} from \"express-graphql\";`. This will not be possible anymore with your proposed solution as you moved these types to a separate namespace. Could you please explain the motivation to put them into a separate namespace?\r\n\r\nI have done the following updates:\r\n- changed _express-graphql/express-graphql-tests.ts_ using your suggestion with some minor adaptations\r\n- added the property _context_ to the type _OptionsObj_ in _express-graphql/express-graphql.d.ts_ (which is still based on my proposed solution) "}}
{"actor":{"display_login":"perlerd"}}