{"action":"created","comment":{"url":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/comments/80570242","id":80570242,"diff_hunk":"@@ -0,0 +1,33 @@\n+#!/bin/bash -eu\n+set -o pipefail\n+\n+# Run automated system tests to verify that checkout still works.\n+\n+# This script starts grunt preview if the current branch is not master.\n+# The ACTIVE_PROFILE environment variable defines which testing environment\n+# should be used in tests/system/site.js.\n+\n+# If the project is not using git, assume we want to test the local build.\n+\n+if git rev-parse ; then\n+    # Get the current branch on CircleCI or local\n+    CURRENT_BRANCH=${CIRCLE_BRANCH:-$(git branch | grep \"*\" | awk '{ print $2 }')}\n+else\n+    CURRENT_BRANCH=develop\n+fi\n+\n+# Start preview if branch is not master.\n+if [ \"$CURRENT_BRANCH\" != \"master\" ]; then\n+    echo \"Running tests against local build\"\n+    # Kill background processes when this script exits.\n+    trap 'kill $(jobs -p)' EXIT\n+    export ACTIVE_PROFILE=local\n+    npm run dev &\n+    while ! echo exit | nc localhost 8443; do sleep 5; done","path":"tests/system/smoke-test.sh","position":null,"original_position":26,"commit_id":"34577b138946365d055f772d2bf76138822b8462","original_commit_id":"f3c2a792fbbcfc38487bb14d2fe939e5281f1a59","user":{"login":"ellenmobify","id":7492180,"avatar_url":"https://avatars.githubusercontent.com/u/7492180?v=3","gravatar_id":"","url":"https://api.github.com/users/ellenmobify","html_url":"https://github.com/ellenmobify","followers_url":"https://api.github.com/users/ellenmobify/followers","following_url":"https://api.github.com/users/ellenmobify/following{/other_user}","gists_url":"https://api.github.com/users/ellenmobify/gists{/gist_id}","starred_url":"https://api.github.com/users/ellenmobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellenmobify/subscriptions","organizations_url":"https://api.github.com/users/ellenmobify/orgs","repos_url":"https://api.github.com/users/ellenmobify/repos","events_url":"https://api.github.com/users/ellenmobify/events{/privacy}","received_events_url":"https://api.github.com/users/ellenmobify/received_events","type":"User","site_admin":false},"body":"I think this bug is no longer happening.","created_at":"2016-09-26T20:53:02Z","updated_at":"2016-09-26T20:53:02Z","html_url":"https://github.com/mobify/progressive-web-scaffold/pull/98#discussion_r80570242","pull_request_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/98","_links":{"self":{"href":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/comments/80570242"},"html":{"href":"https://github.com/mobify/progressive-web-scaffold/pull/98#discussion_r80570242"},"pull_request":{"href":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/98","id":86245195,"html_url":"https://github.com/mobify/progressive-web-scaffold/pull/98","diff_url":"https://github.com/mobify/progressive-web-scaffold/pull/98.diff","patch_url":"https://github.com/mobify/progressive-web-scaffold/pull/98.patch","issue_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/98","number":98,"state":"open","locked":false,"title":"Checkout tests scaffold","user":{"login":"ellenmobify","id":7492180,"avatar_url":"https://avatars.githubusercontent.com/u/7492180?v=3","gravatar_id":"","url":"https://api.github.com/users/ellenmobify","html_url":"https://github.com/ellenmobify","followers_url":"https://api.github.com/users/ellenmobify/followers","following_url":"https://api.github.com/users/ellenmobify/following{/other_user}","gists_url":"https://api.github.com/users/ellenmobify/gists{/gist_id}","starred_url":"https://api.github.com/users/ellenmobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellenmobify/subscriptions","organizations_url":"https://api.github.com/users/ellenmobify/orgs","repos_url":"https://api.github.com/users/ellenmobify/repos","events_url":"https://api.github.com/users/ellenmobify/events{/privacy}","received_events_url":"https://api.github.com/users/ellenmobify/received_events","type":"User","site_admin":false},"body":"Checkout test scaffold and `smoke-test` script to continue auto-detecting test environment for progressive builds 🎉 \r\n\r\nStatus: **Ready for Review**\r\n\r\nReviewers: @mikenikles @marlowpayne @lilyzh @RobotRogue \r\nLinked PRs: none yet, but I hear a nightwatch-commands needs an update\r\n\r\n## Changes\r\n- Pulls over the checkout test scaffold from adaptive generator, updated to ES2015. \r\n- Adds `smoke-test` script to start preview and run tests\r\n\r\n## How to test-drive this PR\r\nI stole these steps from @marlowpayne \r\n\r\n* Clone the Progressive generator https://github.com/mobify/generator-progressive-web\r\n* Hop into the generator's generate.sh file and change line 5 to SCAFFOLD_VERSION_OR_BRANCH=\"nightwatch-scaffold\"\r\n* Run the generator in the directory where your test project will be generated: ./path/to/generator/generate.sh\r\n* Accept the license and provide a test project slug\r\nEnter http://www.merlinspotions.com as the project URL (the URL must include the \"http\" protocol part for .preview())\r\n* Once the new testing project is generated, navigate into the directory\r\n* There's a bug with setting the site URL in the generator, so run the command manually:\r\n```egrep -lR \"siteUrl\" . | tr '\\n' '\\0' | xargs -0 -n1 sed -i '' \"s/\\\"siteUrl\\\": \\\"\\\"/\\\"siteUrl\\\": \\\"http:\\/\\/www.merlinspotions.com\\\"/g\" 2>/dev/null```\r\n* `npm run smoke-test` will run the smoke test script for a production environment, since the current branch is master\r\n* Make a new branch and `npm run smoke-test` to test behaviour for testing local builds\r\n\r\n## TODO\r\n- [x] Resolve bug with `smoke-test` not killing the local server after the script ends\r\n- [ ] Resolve bug with some extra suites getting run\r\n```\r\n[src_folders] Test Suite\r\n============================\r\n\r\n[profiles :: local] Test Suite\r\n==================================\r\n```","created_at":"2016-09-21T21:31:04Z","updated_at":"2016-09-26T20:53:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cda0fbab093db3ea124726e51fae50a73550e3fe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/98/commits","review_comments_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/98/comments","review_comment_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/98/comments","statuses_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/statuses/34577b138946365d055f772d2bf76138822b8462","head":{"label":"mobify:nightwatch-scaffold","ref":"nightwatch-scaffold","sha":"34577b138946365d055f772d2bf76138822b8462","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":62259838,"name":"progressive-web-scaffold","full_name":"mobify/progressive-web-scaffold","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/progressive-web-scaffold","description":"The scaffold / starter kit for Progressive Web","fork":false,"url":"https://api.github.com/repos/mobify/progressive-web-scaffold","forks_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/forks","keys_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/teams","hooks_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/hooks","issue_events_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/events","assignees_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/tags","blobs_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/languages","stargazers_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/stargazers","contributors_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/contributors","subscribers_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/subscribers","subscription_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/subscription","commits_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/merges","archive_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/downloads","issues_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/labels{/name}","releases_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/releases{/id}","deployments_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/deployments","created_at":"2016-06-29T21:42:48Z","updated_at":"2016-09-14T21:52:00Z","pushed_at":"2016-09-26T19:46:48Z","git_url":"git://github.com/mobify/progressive-web-scaffold.git","ssh_url":"git@github.com:mobify/progressive-web-scaffold.git","clone_url":"https://github.com/mobify/progressive-web-scaffold.git","svn_url":"https://github.com/mobify/progressive-web-scaffold","homepage":null,"size":378,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"mobify:develop","ref":"develop","sha":"d573760d6fb95ed3fc8f4aee02588a2224a07eca","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":62259838,"name":"progressive-web-scaffold","full_name":"mobify/progressive-web-scaffold","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/progressive-web-scaffold","description":"The scaffold / starter kit for Progressive Web","fork":false,"url":"https://api.github.com/repos/mobify/progressive-web-scaffold","forks_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/forks","keys_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/teams","hooks_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/hooks","issue_events_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/events","assignees_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/tags","blobs_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/languages","stargazers_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/stargazers","contributors_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/contributors","subscribers_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/subscribers","subscription_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/subscription","commits_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/merges","archive_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/downloads","issues_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/labels{/name}","releases_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/releases{/id}","deployments_url":"https://api.github.com/repos/mobify/progressive-web-scaffold/deployments","created_at":"2016-06-29T21:42:48Z","updated_at":"2016-09-14T21:52:00Z","pushed_at":"2016-09-26T19:46:48Z","git_url":"git://github.com/mobify/progressive-web-scaffold.git","ssh_url":"git@github.com:mobify/progressive-web-scaffold.git","clone_url":"https://github.com/mobify/progressive-web-scaffold.git","svn_url":"https://github.com/mobify/progressive-web-scaffold","homepage":null,"size":378,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/98"},"html":{"href":"https://github.com/mobify/progressive-web-scaffold/pull/98"},"issue":{"href":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/98"},"comments":{"href":"https://api.github.com/repos/mobify/progressive-web-scaffold/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mobify/progressive-web-scaffold/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/mobify/progressive-web-scaffold/statuses/34577b138946365d055f772d2bf76138822b8462"}}}}
{"actor":{"display_login":"ellenmobify"}}