{"action":"created","issue":{"url":"https://api.github.com/repos/ilosuna/mylittleforum/issues/105","repository_url":"https://api.github.com/repos/ilosuna/mylittleforum","labels_url":"https://api.github.com/repos/ilosuna/mylittleforum/issues/105/labels{/name}","comments_url":"https://api.github.com/repos/ilosuna/mylittleforum/issues/105/comments","events_url":"https://api.github.com/repos/ilosuna/mylittleforum/issues/105/events","html_url":"https://github.com/ilosuna/mylittleforum/issues/105","id":191555312,"number":105,"title":"Detect word length also for chinese text","user":{"login":"auge8472","id":1734660,"avatar_url":"https://avatars.githubusercontent.com/u/1734660?v=3","gravatar_id":"","url":"https://api.github.com/users/auge8472","html_url":"https://github.com/auge8472","followers_url":"https://api.github.com/users/auge8472/followers","following_url":"https://api.github.com/users/auge8472/following{/other_user}","gists_url":"https://api.github.com/users/auge8472/gists{/gist_id}","starred_url":"https://api.github.com/users/auge8472/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auge8472/subscriptions","organizations_url":"https://api.github.com/users/auge8472/orgs","repos_url":"https://api.github.com/users/auge8472/repos","events_url":"https://api.github.com/users/auge8472/events{/privacy}","received_events_url":"https://api.github.com/users/auge8472/received_events","type":"User","site_admin":false},"labels":[{"id":385268904,"url":"https://api.github.com/repos/ilosuna/mylittleforum/labels/bug","name":"bug","color":"ee0701","default":true},{"id":385268913,"url":"https://api.github.com/repos/ilosuna/mylittleforum/labels/question","name":"question","color":"cc317c","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-24T16:08:57Z","updated_at":"2016-11-24T17:39:16Z","closed_at":"2016-11-24T17:39:16Z","body":"Chinese literary language has no blanks/spaces in front of or after the punctuation marks. That leads to the situation that **a whole paragraph** with chinese characters **counts as one word**, when checking the word length (see [functions.inc.php, line 1209](https://github.com/ilosuna/mylittleforum/blob/master/includes/functions.inc.php#L1209) (at the moment)).\r\n\r\nTwo suggestions from me.\r\n\r\n- The value of `0` for the setting could disable the check. There are similar checks, that should be handled in the same manner.\r\n- Introduce a language dependent key-value-pair in the language file(s), that declares the characters, that separate words. Maybe this should be optional. Then it would only be used in the case, when the character is not the space/blank.\r\n\r\nI for myself prefer the second approach."},"comment":{"url":"https://api.github.com/repos/ilosuna/mylittleforum/issues/comments/262823557","html_url":"https://github.com/ilosuna/mylittleforum/issues/105#issuecomment-262823557","issue_url":"https://api.github.com/repos/ilosuna/mylittleforum/issues/105","id":262823557,"user":{"login":"derletztekick","id":3595603,"avatar_url":"https://avatars.githubusercontent.com/u/3595603?v=3","gravatar_id":"","url":"https://api.github.com/users/derletztekick","html_url":"https://github.com/derletztekick","followers_url":"https://api.github.com/users/derletztekick/followers","following_url":"https://api.github.com/users/derletztekick/following{/other_user}","gists_url":"https://api.github.com/users/derletztekick/gists{/gist_id}","starred_url":"https://api.github.com/users/derletztekick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derletztekick/subscriptions","organizations_url":"https://api.github.com/users/derletztekick/orgs","repos_url":"https://api.github.com/users/derletztekick/repos","events_url":"https://api.github.com/users/derletztekick/events{/privacy}","received_events_url":"https://api.github.com/users/derletztekick/received_events","type":"User","site_admin":false},"created_at":"2016-11-24T17:39:16Z","updated_at":"2016-11-24T17:39:16Z","body":"The function too_long_word is uses to check the length of the strings. So I add a condition, see https://github.com/ilosuna/mylittleforum/pull/109\r\n\r\nDone."}}
{"actor":{"display_login":"derletztekick"}}