{"action":"created","comment":{"url":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/comments/89781277","pull_request_review_id":10315306,"id":89781277,"diff_hunk":"@@ -38,12 +38,6 @@ DrawContext: abstract class {\n \tcreateYuv420Semiplanar: abstract func (size: IntVector2D) -> Image\n \tcreateYuv420Semiplanar: abstract func ~fromImages (y, uv: Image) -> Image\n \tcreateYuv420Semiplanar: abstract func ~fromRaster (raster: RasterYuv420Semiplanar) -> Image\n-\tcreateImageFromStringAndFont: virtual func (message: String, fontAtlas: Image) -> Image {\n-\t\ttarget := this createMonochrome(This getStringPixelBounds(message, fontAtlas))\n-\t\ttarget fill(ColorRgba black)\n-\t\ttarget write(message, fontAtlas, IntPoint2D new(0, 0))\n-\t\ttarget\n-\t}","path":"source/draw/DrawContext.ooc","position":9,"original_position":9,"commit_id":"d43c1f4263b9820b8301a2578f60bbfc5951bbf8","original_commit_id":"e5c876bd9da8f6c5a9bd735801bae36e2856f55b","user":{"login":"davidpiuva","id":10193545,"avatar_url":"https://avatars.githubusercontent.com/u/10193545?v=3","gravatar_id":"","url":"https://api.github.com/users/davidpiuva","html_url":"https://github.com/davidpiuva","followers_url":"https://api.github.com/users/davidpiuva/followers","following_url":"https://api.github.com/users/davidpiuva/following{/other_user}","gists_url":"https://api.github.com/users/davidpiuva/gists{/gist_id}","starred_url":"https://api.github.com/users/davidpiuva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidpiuva/subscriptions","organizations_url":"https://api.github.com/users/davidpiuva/orgs","repos_url":"https://api.github.com/users/davidpiuva/repos","events_url":"https://api.github.com/users/davidpiuva/events{/privacy}","received_events_url":"https://api.github.com/users/davidpiuva/received_events","type":"User","site_admin":false},"body":"`this createMonochrome` will always create a GPU image from a GPU context. Now, we always create a CPU image no matter what context so this level of abstraction was too high.","created_at":"2016-11-28T13:35:52Z","updated_at":"2016-11-28T13:35:52Z","html_url":"https://github.com/magic-lang/ooc-kean/pull/2010#discussion_r89781277","pull_request_url":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/2010","_links":{"self":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/comments/89781277"},"html":{"href":"https://github.com/magic-lang/ooc-kean/pull/2010#discussion_r89781277"},"pull_request":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/2010"}}},"pull_request":{"url":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/2010","id":95273660,"html_url":"https://github.com/magic-lang/ooc-kean/pull/2010","diff_url":"https://github.com/magic-lang/ooc-kean/pull/2010.diff","patch_url":"https://github.com/magic-lang/ooc-kean/pull/2010.patch","issue_url":"https://api.github.com/repos/magic-lang/ooc-kean/issues/2010","number":2010,"state":"open","locked":false,"title":"Writing filtered text on the CPU","user":{"login":"davidpiuva","id":10193545,"avatar_url":"https://avatars.githubusercontent.com/u/10193545?v=3","gravatar_id":"","url":"https://api.github.com/users/davidpiuva","html_url":"https://github.com/davidpiuva","followers_url":"https://api.github.com/users/davidpiuva/followers","following_url":"https://api.github.com/users/davidpiuva/following{/other_user}","gists_url":"https://api.github.com/users/davidpiuva/gists{/gist_id}","starred_url":"https://api.github.com/users/davidpiuva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidpiuva/subscriptions","organizations_url":"https://api.github.com/users/davidpiuva/orgs","repos_url":"https://api.github.com/users/davidpiuva/repos","events_url":"https://api.github.com/users/davidpiuva/events{/privacy}","received_events_url":"https://api.github.com/users/davidpiuva/received_events","type":"User","site_admin":false},"body":"The previous implementation of CPU writing depended on DrawState for each character and did not support the same filtering as the GPU used. Now there are blit calls for pixel exact filtered drawing that does not require any complex calculations when performed on the CPU. The blit method is an abstraction layer on top of DrawState that can be implemented in a much simpler way on the CPU.","created_at":"2016-11-25T09:34:53Z","updated_at":"2016-11-28T13:35:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68d917abc9e02e86c295a13e2f8888f51e82de8b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/2010/commits","review_comments_url":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/2010/comments","review_comment_url":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magic-lang/ooc-kean/issues/2010/comments","statuses_url":"https://api.github.com/repos/magic-lang/ooc-kean/statuses/d43c1f4263b9820b8301a2578f60bbfc5951bbf8","head":{"label":"davidpiuva:overlay","ref":"overlay","sha":"d43c1f4263b9820b8301a2578f60bbfc5951bbf8","user":{"login":"davidpiuva","id":10193545,"avatar_url":"https://avatars.githubusercontent.com/u/10193545?v=3","gravatar_id":"","url":"https://api.github.com/users/davidpiuva","html_url":"https://github.com/davidpiuva","followers_url":"https://api.github.com/users/davidpiuva/followers","following_url":"https://api.github.com/users/davidpiuva/following{/other_user}","gists_url":"https://api.github.com/users/davidpiuva/gists{/gist_id}","starred_url":"https://api.github.com/users/davidpiuva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidpiuva/subscriptions","organizations_url":"https://api.github.com/users/davidpiuva/orgs","repos_url":"https://api.github.com/users/davidpiuva/repos","events_url":"https://api.github.com/users/davidpiuva/events{/privacy}","received_events_url":"https://api.github.com/users/davidpiuva/received_events","type":"User","site_admin":false},"repo":{"id":28035938,"name":"ooc-kean","full_name":"davidpiuva/ooc-kean","owner":{"login":"davidpiuva","id":10193545,"avatar_url":"https://avatars.githubusercontent.com/u/10193545?v=3","gravatar_id":"","url":"https://api.github.com/users/davidpiuva","html_url":"https://github.com/davidpiuva","followers_url":"https://api.github.com/users/davidpiuva/followers","following_url":"https://api.github.com/users/davidpiuva/following{/other_user}","gists_url":"https://api.github.com/users/davidpiuva/gists{/gist_id}","starred_url":"https://api.github.com/users/davidpiuva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidpiuva/subscriptions","organizations_url":"https://api.github.com/users/davidpiuva/orgs","repos_url":"https://api.github.com/users/davidpiuva/repos","events_url":"https://api.github.com/users/davidpiuva/events{/privacy}","received_events_url":"https://api.github.com/users/davidpiuva/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidpiuva/ooc-kean","description":"OOC port of parts of Kean.","fork":true,"url":"https://api.github.com/repos/davidpiuva/ooc-kean","forks_url":"https://api.github.com/repos/davidpiuva/ooc-kean/forks","keys_url":"https://api.github.com/repos/davidpiuva/ooc-kean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidpiuva/ooc-kean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidpiuva/ooc-kean/teams","hooks_url":"https://api.github.com/repos/davidpiuva/ooc-kean/hooks","issue_events_url":"https://api.github.com/repos/davidpiuva/ooc-kean/issues/events{/number}","events_url":"https://api.github.com/repos/davidpiuva/ooc-kean/events","assignees_url":"https://api.github.com/repos/davidpiuva/ooc-kean/assignees{/user}","branches_url":"https://api.github.com/repos/davidpiuva/ooc-kean/branches{/branch}","tags_url":"https://api.github.com/repos/davidpiuva/ooc-kean/tags","blobs_url":"https://api.github.com/repos/davidpiuva/ooc-kean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidpiuva/ooc-kean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidpiuva/ooc-kean/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidpiuva/ooc-kean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidpiuva/ooc-kean/statuses/{sha}","languages_url":"https://api.github.com/repos/davidpiuva/ooc-kean/languages","stargazers_url":"https://api.github.com/repos/davidpiuva/ooc-kean/stargazers","contributors_url":"https://api.github.com/repos/davidpiuva/ooc-kean/contributors","subscribers_url":"https://api.github.com/repos/davidpiuva/ooc-kean/subscribers","subscription_url":"https://api.github.com/repos/davidpiuva/ooc-kean/subscription","commits_url":"https://api.github.com/repos/davidpiuva/ooc-kean/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidpiuva/ooc-kean/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidpiuva/ooc-kean/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidpiuva/ooc-kean/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidpiuva/ooc-kean/contents/{+path}","compare_url":"https://api.github.com/repos/davidpiuva/ooc-kean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidpiuva/ooc-kean/merges","archive_url":"https://api.github.com/repos/davidpiuva/ooc-kean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidpiuva/ooc-kean/downloads","issues_url":"https://api.github.com/repos/davidpiuva/ooc-kean/issues{/number}","pulls_url":"https://api.github.com/repos/davidpiuva/ooc-kean/pulls{/number}","milestones_url":"https://api.github.com/repos/davidpiuva/ooc-kean/milestones{/number}","notifications_url":"https://api.github.com/repos/davidpiuva/ooc-kean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidpiuva/ooc-kean/labels{/name}","releases_url":"https://api.github.com/repos/davidpiuva/ooc-kean/releases{/id}","deployments_url":"https://api.github.com/repos/davidpiuva/ooc-kean/deployments","created_at":"2014-12-15T12:34:56Z","updated_at":"2016-01-21T11:50:29Z","pushed_at":"2016-11-28T11:48:46Z","git_url":"git://github.com/davidpiuva/ooc-kean.git","ssh_url":"git@github.com:davidpiuva/ooc-kean.git","clone_url":"https://github.com/davidpiuva/ooc-kean.git","svn_url":"https://github.com/davidpiuva/ooc-kean","homepage":null,"size":38461,"stargazers_count":0,"watchers_count":0,"language":"ooc","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"magic-lang:develop","ref":"develop","sha":"e4d188d0a0196da56ee4c30ef179f89a86507e55","user":{"login":"magic-lang","id":16756691,"avatar_url":"https://avatars.githubusercontent.com/u/16756691?v=3","gravatar_id":"","url":"https://api.github.com/users/magic-lang","html_url":"https://github.com/magic-lang","followers_url":"https://api.github.com/users/magic-lang/followers","following_url":"https://api.github.com/users/magic-lang/following{/other_user}","gists_url":"https://api.github.com/users/magic-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/magic-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magic-lang/subscriptions","organizations_url":"https://api.github.com/users/magic-lang/orgs","repos_url":"https://api.github.com/users/magic-lang/repos","events_url":"https://api.github.com/users/magic-lang/events{/privacy}","received_events_url":"https://api.github.com/users/magic-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":25256330,"name":"ooc-kean","full_name":"magic-lang/ooc-kean","owner":{"login":"magic-lang","id":16756691,"avatar_url":"https://avatars.githubusercontent.com/u/16756691?v=3","gravatar_id":"","url":"https://api.github.com/users/magic-lang","html_url":"https://github.com/magic-lang","followers_url":"https://api.github.com/users/magic-lang/followers","following_url":"https://api.github.com/users/magic-lang/following{/other_user}","gists_url":"https://api.github.com/users/magic-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/magic-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magic-lang/subscriptions","organizations_url":"https://api.github.com/users/magic-lang/orgs","repos_url":"https://api.github.com/users/magic-lang/repos","events_url":"https://api.github.com/users/magic-lang/events{/privacy}","received_events_url":"https://api.github.com/users/magic-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magic-lang/ooc-kean","description":"ooc port of parts of Kean.","fork":false,"url":"https://api.github.com/repos/magic-lang/ooc-kean","forks_url":"https://api.github.com/repos/magic-lang/ooc-kean/forks","keys_url":"https://api.github.com/repos/magic-lang/ooc-kean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magic-lang/ooc-kean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magic-lang/ooc-kean/teams","hooks_url":"https://api.github.com/repos/magic-lang/ooc-kean/hooks","issue_events_url":"https://api.github.com/repos/magic-lang/ooc-kean/issues/events{/number}","events_url":"https://api.github.com/repos/magic-lang/ooc-kean/events","assignees_url":"https://api.github.com/repos/magic-lang/ooc-kean/assignees{/user}","branches_url":"https://api.github.com/repos/magic-lang/ooc-kean/branches{/branch}","tags_url":"https://api.github.com/repos/magic-lang/ooc-kean/tags","blobs_url":"https://api.github.com/repos/magic-lang/ooc-kean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magic-lang/ooc-kean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magic-lang/ooc-kean/git/refs{/sha}","trees_url":"https://api.github.com/repos/magic-lang/ooc-kean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magic-lang/ooc-kean/statuses/{sha}","languages_url":"https://api.github.com/repos/magic-lang/ooc-kean/languages","stargazers_url":"https://api.github.com/repos/magic-lang/ooc-kean/stargazers","contributors_url":"https://api.github.com/repos/magic-lang/ooc-kean/contributors","subscribers_url":"https://api.github.com/repos/magic-lang/ooc-kean/subscribers","subscription_url":"https://api.github.com/repos/magic-lang/ooc-kean/subscription","commits_url":"https://api.github.com/repos/magic-lang/ooc-kean/commits{/sha}","git_commits_url":"https://api.github.com/repos/magic-lang/ooc-kean/git/commits{/sha}","comments_url":"https://api.github.com/repos/magic-lang/ooc-kean/comments{/number}","issue_comment_url":"https://api.github.com/repos/magic-lang/ooc-kean/issues/comments{/number}","contents_url":"https://api.github.com/repos/magic-lang/ooc-kean/contents/{+path}","compare_url":"https://api.github.com/repos/magic-lang/ooc-kean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magic-lang/ooc-kean/merges","archive_url":"https://api.github.com/repos/magic-lang/ooc-kean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magic-lang/ooc-kean/downloads","issues_url":"https://api.github.com/repos/magic-lang/ooc-kean/issues{/number}","pulls_url":"https://api.github.com/repos/magic-lang/ooc-kean/pulls{/number}","milestones_url":"https://api.github.com/repos/magic-lang/ooc-kean/milestones{/number}","notifications_url":"https://api.github.com/repos/magic-lang/ooc-kean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magic-lang/ooc-kean/labels{/name}","releases_url":"https://api.github.com/repos/magic-lang/ooc-kean/releases{/id}","deployments_url":"https://api.github.com/repos/magic-lang/ooc-kean/deployments","created_at":"2014-10-15T13:42:17Z","updated_at":"2016-10-27T16:17:04Z","pushed_at":"2016-11-28T11:48:47Z","git_url":"git://github.com/magic-lang/ooc-kean.git","ssh_url":"git@github.com:magic-lang/ooc-kean.git","clone_url":"https://github.com/magic-lang/ooc-kean.git","svn_url":"https://github.com/magic-lang/ooc-kean","homepage":"","size":39116,"stargazers_count":4,"watchers_count":4,"language":"ooc","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":22,"forks":28,"open_issues":22,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/2010"},"html":{"href":"https://github.com/magic-lang/ooc-kean/pull/2010"},"issue":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/issues/2010"},"comments":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/issues/2010/comments"},"review_comments":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/2010/comments"},"review_comment":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/pulls/2010/commits"},"statuses":{"href":"https://api.github.com/repos/magic-lang/ooc-kean/statuses/d43c1f4263b9820b8301a2578f60bbfc5951bbf8"}}}}
{"actor":{"display_login":"davidpiuva"}}