{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments/84819172","pull_request_review_id":5569476,"id":84819172,"diff_hunk":"@@ -1858,6 +1858,253 @@\n           }\n         }\n       }\n+    },\n+    \"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/topics/{topicName}/subscriptions/{subscriptionName}/rules\": {\n+      \"get\": {\n+        \"tags\": [\n+          \"Rules\"\n+        ],\n+        \"operationId\": \"Rules_ListAll\",\n+        \"description\": \"List all the rules\",\n+        \"parameters\": [\n+          {\n+            \"name\": \"resourceGroupName\",\n+            \"in\": \"path\",\n+            \"required\": true,\n+            \"type\": \"string\",\n+            \"description\": \"The name of the resource group.\"\n+          },\n+          {\n+            \"name\": \"namespaceName\",\n+            \"in\": \"path\",\n+            \"required\": true,\n+            \"type\": \"string\",\n+            \"description\": \"The namespace name.\"\n+          },\n+          {\n+            \"name\": \"topicName\",\n+            \"in\": \"path\",\n+            \"required\": true,\n+            \"type\": \"string\",\n+            \"description\": \"The topic name.\"\n+          },\n+          {\n+            \"name\": \"subscriptionName\",\n+            \"in\": \"path\",\n+            \"required\": true,\n+            \"type\": \"string\",\n+            \"description\": \"The subscriptionName name.\"\n+          },\n+          {\n+            \"$ref\": \"#/parameters/ApiVersionParameter\"\n+          },\n+          {\n+            \"$ref\": \"#/parameters/SubscriptionIdParameter\"\n+          }\n+        ],\n+        \"responses\": {\n+          \"200\": {\n+            \"description\": \"Successfully retrieved list of Rules.\",\n+            \"schema\": {\n+              \"$ref\": \"#/definitions/RuleListResult\"\n+            }\n+          }\n+        },\n+        \"x-ms-pageable\": {\n+          \"nextLinkName\": \"nextLink\"\n+        }\n+      }\n+    },\n+    \"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/topics/{topicName}/subscriptions/{subscriptionName}/rules/{ruleName}\": {\n+      \"put\": {\n+        \"tags\": [\n+          \"Rules\"\n+        ],\n+        \"operationId\": \"Rules_CreateOrUpdate\",\n+        \"description\": \"Creates a new rule\",\n+        \"parameters\": [\n+          {\n+            \"name\": \"resourceGroupName\",\n+            \"in\": \"path\",\n+            \"required\": true,\n+            \"type\": \"string\",\n+            \"description\": \"The name of the resource group.\"\n+          },\n+          {\n+            \"name\": \"namespaceName\",\n+            \"in\": \"path\",\n+            \"required\": true,\n+            \"type\": \"string\",\n+            \"description\": \"The namespace name.\"\n+          },\n+          {\n+            \"name\": \"topicName\",\n+            \"in\": \"path\",\n+            \"required\": true,\n+            \"type\": \"string\",\n+            \"description\": \"The topicName name.\"\n+          },\n+          {\n+            \"name\": \"subscriptionName\",\n+            \"in\": \"path\",\n+            \"required\": true,\n+            \"type\": \"string\",\n+            \"description\": \"The subscriptionName name.\"\n+          },\n+          {\n+            \"name\": \"ruleName\",\n+            \"in\": \"path\",\n+            \"required\": true,\n+            \"type\": \"string\",\n+            \"description\": \"The rule name.\"\n+          },\n+          {\n+            \"name\": \"parameters\",\n+            \"in\": \"body\",\n+            \"required\": true,\n+            \"schema\": {\n+              \"$ref\": \"#/definitions/RuleCreateOrUpdateParameters\"\n+            },\n+            \"description\": \"Parameters supplied to create a rules.\"","path":"arm-servicebus/2015-08-01/swagger/servicebus.json","position":120,"original_position":120,"commit_id":"6982a6dbbb4018b51e7c2b809e009df886da30b1","original_commit_id":"6982a6dbbb4018b51e7c2b809e009df886da30b1","user":{"login":"amarzavery","id":4521223,"avatar_url":"https://avatars.githubusercontent.com/u/4521223?v=3","gravatar_id":"","url":"https://api.github.com/users/amarzavery","html_url":"https://github.com/amarzavery","followers_url":"https://api.github.com/users/amarzavery/followers","following_url":"https://api.github.com/users/amarzavery/following{/other_user}","gists_url":"https://api.github.com/users/amarzavery/gists{/gist_id}","starred_url":"https://api.github.com/users/amarzavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amarzavery/subscriptions","organizations_url":"https://api.github.com/users/amarzavery/orgs","repos_url":"https://api.github.com/users/amarzavery/repos","events_url":"https://api.github.com/users/amarzavery/events{/privacy}","received_events_url":"https://api.github.com/users/amarzavery/received_events","type":"User","site_admin":false},"body":"\"Parameters supplied to create a rule~~s~~.","created_at":"2016-10-25T02:01:56Z","updated_at":"2016-10-25T02:01:56Z","html_url":"https://github.com/Azure/azure-rest-api-specs/pull/629#discussion_r84819172","pull_request_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/629","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments/84819172"},"html":{"href":"https://github.com/Azure/azure-rest-api-specs/pull/629#discussion_r84819172"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/629"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/629","id":90695416,"html_url":"https://github.com/Azure/azure-rest-api-specs/pull/629","diff_url":"https://github.com/Azure/azure-rest-api-specs/pull/629.diff","patch_url":"https://github.com/Azure/azure-rest-api-specs/pull/629.patch","issue_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/629","number":629,"state":"open","locked":false,"title":"Adding Rules API to ServiceBus swagger ","user":{"login":"sazeesha","id":12700981,"avatar_url":"https://avatars.githubusercontent.com/u/12700981?v=3","gravatar_id":"","url":"https://api.github.com/users/sazeesha","html_url":"https://github.com/sazeesha","followers_url":"https://api.github.com/users/sazeesha/followers","following_url":"https://api.github.com/users/sazeesha/following{/other_user}","gists_url":"https://api.github.com/users/sazeesha/gists{/gist_id}","starred_url":"https://api.github.com/users/sazeesha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sazeesha/subscriptions","organizations_url":"https://api.github.com/users/sazeesha/orgs","repos_url":"https://api.github.com/users/sazeesha/repos","events_url":"https://api.github.com/users/sazeesha/events{/privacy}","received_events_url":"https://api.github.com/users/sazeesha/received_events","type":"User","site_admin":false},"body":"This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process. \r\n\r\n### PR information\r\n- [ ] The title of the PR is clear and informative.\r\n- [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, [see this page](https://github.com/Azure/azure-powershell/blob/dev/documentation/cleaning-up-commits.md).\r\n- [ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.\r\n- [ ] If applicable, the PR references the bug/issue that it fixes.\r\n- [ ] Swagger files are correctly named (e.g. the `api-version` in the path should match the `api-version` in the spec).\r\n\r\n### Quality of Swagger\r\n- [ ] I have read the [contribution guidelines](https://github.com/Azure/azure-rest-api-specs/blob/master/.github/CONTRIBUTING.md).\r\n- [ ] My spec meets the review criteria:\r\n  - [ ] The spec conforms to the [Swagger 2.0 specification](https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md).\r\n  - [ ] Validation errors from the [Linter extension for VS Code](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/linter.md) have all been fixed for this spec. (**Note:** for large, previously checked in specs, there will likely be many errors shown. Please contact our team so we can set a timeframe for fixing these errors if your PR is not going to address them).\r\n  - [ ] The spec follows the patterns described in the [Swagger good patterns](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-good-patterns.md) document unless the service API makes this impossible.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/azure/azure-rest-api-specs/629)\n<!-- Reviewable:end -->\n","created_at":"2016-10-24T21:22:45Z","updated_at":"2016-10-25T02:11:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2873bf19e128dc5cd487e3633ac402e895bdcf97","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/629/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/629/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/629/comments","statuses_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/statuses/6982a6dbbb4018b51e7c2b809e009df886da30b1","head":{"label":"sazeesha:master","ref":"master","sha":"6982a6dbbb4018b51e7c2b809e009df886da30b1","user":{"login":"sazeesha","id":12700981,"avatar_url":"https://avatars.githubusercontent.com/u/12700981?v=3","gravatar_id":"","url":"https://api.github.com/users/sazeesha","html_url":"https://github.com/sazeesha","followers_url":"https://api.github.com/users/sazeesha/followers","following_url":"https://api.github.com/users/sazeesha/following{/other_user}","gists_url":"https://api.github.com/users/sazeesha/gists{/gist_id}","starred_url":"https://api.github.com/users/sazeesha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sazeesha/subscriptions","organizations_url":"https://api.github.com/users/sazeesha/orgs","repos_url":"https://api.github.com/users/sazeesha/repos","events_url":"https://api.github.com/users/sazeesha/events{/privacy}","received_events_url":"https://api.github.com/users/sazeesha/received_events","type":"User","site_admin":false},"repo":{"id":61410711,"name":"azure-rest-api-specs","full_name":"sazeesha/azure-rest-api-specs","owner":{"login":"sazeesha","id":12700981,"avatar_url":"https://avatars.githubusercontent.com/u/12700981?v=3","gravatar_id":"","url":"https://api.github.com/users/sazeesha","html_url":"https://github.com/sazeesha","followers_url":"https://api.github.com/users/sazeesha/followers","following_url":"https://api.github.com/users/sazeesha/following{/other_user}","gists_url":"https://api.github.com/users/sazeesha/gists{/gist_id}","starred_url":"https://api.github.com/users/sazeesha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sazeesha/subscriptions","organizations_url":"https://api.github.com/users/sazeesha/orgs","repos_url":"https://api.github.com/users/sazeesha/repos","events_url":"https://api.github.com/users/sazeesha/events{/privacy}","received_events_url":"https://api.github.com/users/sazeesha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sazeesha/azure-rest-api-specs","description":"The source for REST API specifications for Microsoft Azure.","fork":true,"url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs","forks_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/forks","keys_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/teams","hooks_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/hooks","issue_events_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/issues/events{/number}","events_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/events","assignees_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/assignees{/user}","branches_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/branches{/branch}","tags_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/tags","blobs_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/statuses/{sha}","languages_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/languages","stargazers_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/stargazers","contributors_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/contributors","subscribers_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/subscribers","subscription_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/subscription","commits_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/contents/{+path}","compare_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/merges","archive_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/downloads","issues_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/issues{/number}","pulls_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/pulls{/number}","milestones_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/milestones{/number}","notifications_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/labels{/name}","releases_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/releases{/id}","deployments_url":"https://api.github.com/repos/sazeesha/azure-rest-api-specs/deployments","created_at":"2016-06-18T01:05:34Z","updated_at":"2016-06-18T01:05:36Z","pushed_at":"2016-10-24T21:22:00Z","git_url":"git://github.com/sazeesha/azure-rest-api-specs.git","ssh_url":"git@github.com:sazeesha/azure-rest-api-specs.git","clone_url":"https://github.com/sazeesha/azure-rest-api-specs.git","svn_url":"https://github.com/sazeesha/azure-rest-api-specs","homepage":"","size":3400,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"10a5d250181c937d962c909c2acc1a440147a0aa","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":39093389,"name":"azure-rest-api-specs","full_name":"Azure/azure-rest-api-specs","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-rest-api-specs","description":"The source for REST API specifications for Microsoft Azure.","fork":false,"url":"https://api.github.com/repos/Azure/azure-rest-api-specs","forks_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/forks","keys_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/teams","hooks_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/events","assignees_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/tags","blobs_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/subscription","commits_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/merges","archive_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/downloads","issues_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-rest-api-specs/deployments","created_at":"2015-07-14T18:37:13Z","updated_at":"2016-10-24T17:40:07Z","pushed_at":"2016-10-25T01:50:22Z","git_url":"git://github.com/Azure/azure-rest-api-specs.git","ssh_url":"git@github.com:Azure/azure-rest-api-specs.git","clone_url":"https://github.com/Azure/azure-rest-api-specs.git","svn_url":"https://github.com/Azure/azure-rest-api-specs","homepage":"","size":5759,"stargazers_count":92,"watchers_count":92,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":190,"mirror_url":null,"open_issues_count":101,"forks":190,"open_issues":101,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/629"},"html":{"href":"https://github.com/Azure/azure-rest-api-specs/pull/629"},"issue":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/629"},"comments":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/issues/629/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/629/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/pulls/629/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-rest-api-specs/statuses/6982a6dbbb4018b51e7c2b809e009df886da30b1"}}}}
{"actor":{"display_login":"amarzavery"}}