{"action":"created","issue":{"url":"https://api.github.com/repos/ipfs/interface-ipfs-core/issues/36","repository_url":"https://api.github.com/repos/ipfs/interface-ipfs-core","labels_url":"https://api.github.com/repos/ipfs/interface-ipfs-core/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/ipfs/interface-ipfs-core/issues/36/comments","events_url":"https://api.github.com/repos/ipfs/interface-ipfs-core/issues/36/events","html_url":"https://github.com/ipfs/interface-ipfs-core/pull/36","id":162640244,"number":36,"title":"DHT API","user":{"login":"diasdavid","id":1211152,"avatar_url":"https://avatars.githubusercontent.com/u/1211152?v=3","gravatar_id":"","url":"https://api.github.com/users/diasdavid","html_url":"https://github.com/diasdavid","followers_url":"https://api.github.com/users/diasdavid/followers","following_url":"https://api.github.com/users/diasdavid/following{/other_user}","gists_url":"https://api.github.com/users/diasdavid/gists{/gist_id}","starred_url":"https://api.github.com/users/diasdavid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasdavid/subscriptions","organizations_url":"https://api.github.com/users/diasdavid/orgs","repos_url":"https://api.github.com/users/diasdavid/repos","events_url":"https://api.github.com/users/diasdavid/events{/privacy}","received_events_url":"https://api.github.com/users/diasdavid/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ipfs/interface-ipfs-core/labels/milestone%202","name":"milestone 2","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"VictorBjelkholm","id":459764,"avatar_url":"https://avatars.githubusercontent.com/u/459764?v=3","gravatar_id":"","url":"https://api.github.com/users/VictorBjelkholm","html_url":"https://github.com/VictorBjelkholm","followers_url":"https://api.github.com/users/VictorBjelkholm/followers","following_url":"https://api.github.com/users/VictorBjelkholm/following{/other_user}","gists_url":"https://api.github.com/users/VictorBjelkholm/gists{/gist_id}","starred_url":"https://api.github.com/users/VictorBjelkholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VictorBjelkholm/subscriptions","organizations_url":"https://api.github.com/users/VictorBjelkholm/orgs","repos_url":"https://api.github.com/users/VictorBjelkholm/repos","events_url":"https://api.github.com/users/VictorBjelkholm/events{/privacy}","received_events_url":"https://api.github.com/users/VictorBjelkholm/received_events","type":"User","site_admin":false},"assignees":[{"login":"VictorBjelkholm","id":459764,"avatar_url":"https://avatars.githubusercontent.com/u/459764?v=3","gravatar_id":"","url":"https://api.github.com/users/VictorBjelkholm","html_url":"https://github.com/VictorBjelkholm","followers_url":"https://api.github.com/users/VictorBjelkholm/followers","following_url":"https://api.github.com/users/VictorBjelkholm/following{/other_user}","gists_url":"https://api.github.com/users/VictorBjelkholm/gists{/gist_id}","starred_url":"https://api.github.com/users/VictorBjelkholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VictorBjelkholm/subscriptions","organizations_url":"https://api.github.com/users/VictorBjelkholm/orgs","repos_url":"https://api.github.com/users/VictorBjelkholm/repos","events_url":"https://api.github.com/users/VictorBjelkholm/events{/privacy}","received_events_url":"https://api.github.com/users/VictorBjelkholm/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-06-28T09:22:20Z","updated_at":"2016-09-18T10:28:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ipfs/interface-ipfs-core/pulls/36","html_url":"https://github.com/ipfs/interface-ipfs-core/pull/36","diff_url":"https://github.com/ipfs/interface-ipfs-core/pull/36.diff","patch_url":"https://github.com/ipfs/interface-ipfs-core/pull/36.patch"},"body":"> **WIP**\r\n\r\n- API calls\r\n  - [x] ipfs.dht.findpeer\r\n  - [x] ipfs.dht.get\r\n  - [x] ipfs.dht.put\r\n  - [x] ipfs.dht.query\r\n  - [x] ipfs.dht.findprovs\r\n- [ ] ~~Works in js-ipfs~~ This will be left for milestone 6 of js-ipfs\r\n- [ ] Works in js-ipfs-api\r\n- requires:\r\n  - [x] https://github.com/ipfs/interface-ipfs-core/issues/53"},"comment":{"url":"https://api.github.com/repos/ipfs/interface-ipfs-core/issues/comments/247839804","html_url":"https://github.com/ipfs/interface-ipfs-core/pull/36#issuecomment-247839804","issue_url":"https://api.github.com/repos/ipfs/interface-ipfs-core/issues/36","id":247839804,"user":{"login":"VictorBjelkholm","id":459764,"avatar_url":"https://avatars.githubusercontent.com/u/459764?v=3","gravatar_id":"","url":"https://api.github.com/users/VictorBjelkholm","html_url":"https://github.com/VictorBjelkholm","followers_url":"https://api.github.com/users/VictorBjelkholm/followers","following_url":"https://api.github.com/users/VictorBjelkholm/following{/other_user}","gists_url":"https://api.github.com/users/VictorBjelkholm/gists{/gist_id}","starred_url":"https://api.github.com/users/VictorBjelkholm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VictorBjelkholm/subscriptions","organizations_url":"https://api.github.com/users/VictorBjelkholm/orgs","repos_url":"https://api.github.com/users/VictorBjelkholm/repos","events_url":"https://api.github.com/users/VictorBjelkholm/events{/privacy}","received_events_url":"https://api.github.com/users/VictorBjelkholm/received_events","type":"User","site_admin":false},"created_at":"2016-09-18T10:28:23Z","updated_at":"2016-09-18T10:28:23Z","body":"@diasdavid \r\n\r\n> @VictorBjelkholm do you have a branch of these tests running on js-ipfs-api?\r\n\r\nYeah, over here: https://github.com/ipfs/js-ipfs-api/pull/385\r\n\r\n> have a section for \"callback API\" and heavily test that one\r\n\r\n:+1: \r\n\r\n> be creative about tests, if you can make them faster or find bugs in the impl through then, big :+1:\r\n\r\n:+1: \r\n\r\n> have a section for \"promise API\" and test at least each function once\r\n\r\nHm, not so sure about this one. The promise API should be tested at one place, to make sure promisify is working correctly, but I don't think we need to test every single function in both the callback way and promise. Makes more sense to have a couple of tests to make sure that one way is working, then always stick with the other otherwise."}}
{"actor":{"display_login":"VictorBjelkholm"}}