{"action":"closed","number":3297,"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/3297","id":62193264,"html_url":"https://github.com/theforeman/foreman/pull/3297","diff_url":"https://github.com/theforeman/foreman/pull/3297.diff","patch_url":"https://github.com/theforeman/foreman/pull/3297.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/3297","number":3297,"state":"closed","locked":false,"title":"Fixes #6924 - Additional validations for Setting","user":{"login":"xprazak2","id":2664090,"avatar_url":"https://avatars.githubusercontent.com/u/2664090?v=3","gravatar_id":"","url":"https://api.github.com/users/xprazak2","html_url":"https://github.com/xprazak2","followers_url":"https://api.github.com/users/xprazak2/followers","following_url":"https://api.github.com/users/xprazak2/following{/other_user}","gists_url":"https://api.github.com/users/xprazak2/gists{/gist_id}","starred_url":"https://api.github.com/users/xprazak2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xprazak2/subscriptions","organizations_url":"https://api.github.com/users/xprazak2/orgs","repos_url":"https://api.github.com/users/xprazak2/repos","events_url":"https://api.github.com/users/xprazak2/events{/privacy}","received_events_url":"https://api.github.com/users/xprazak2/received_events","type":"User","site_admin":false},"body":"Validations for Settings that are supposed to contain IP address and additional check for array setting type, although I am not sure about this one.","created_at":"2016-03-09T08:15:49Z","updated_at":"2016-03-14T16:51:44Z","closed_at":"2016-03-14T16:51:44Z","merged_at":null,"merge_commit_sha":"9499ab026caeade120926296af3e7900f1b17887","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/3297/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/3297/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/3297/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/7ee6586a769e612427d5430a32f617affeef5553","head":{"label":"xprazak2:settings-validation","ref":"settings-validation","sha":"7ee6586a769e612427d5430a32f617affeef5553","user":{"login":"xprazak2","id":2664090,"avatar_url":"https://avatars.githubusercontent.com/u/2664090?v=3","gravatar_id":"","url":"https://api.github.com/users/xprazak2","html_url":"https://github.com/xprazak2","followers_url":"https://api.github.com/users/xprazak2/followers","following_url":"https://api.github.com/users/xprazak2/following{/other_user}","gists_url":"https://api.github.com/users/xprazak2/gists{/gist_id}","starred_url":"https://api.github.com/users/xprazak2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xprazak2/subscriptions","organizations_url":"https://api.github.com/users/xprazak2/orgs","repos_url":"https://api.github.com/users/xprazak2/repos","events_url":"https://api.github.com/users/xprazak2/events{/privacy}","received_events_url":"https://api.github.com/users/xprazak2/received_events","type":"User","site_admin":false},"repo":{"id":33602529,"name":"foreman","full_name":"xprazak2/foreman","owner":{"login":"xprazak2","id":2664090,"avatar_url":"https://avatars.githubusercontent.com/u/2664090?v=3","gravatar_id":"","url":"https://api.github.com/users/xprazak2","html_url":"https://github.com/xprazak2","followers_url":"https://api.github.com/users/xprazak2/followers","following_url":"https://api.github.com/users/xprazak2/following{/other_user}","gists_url":"https://api.github.com/users/xprazak2/gists{/gist_id}","starred_url":"https://api.github.com/users/xprazak2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xprazak2/subscriptions","organizations_url":"https://api.github.com/users/xprazak2/orgs","repos_url":"https://api.github.com/users/xprazak2/repos","events_url":"https://api.github.com/users/xprazak2/events{/privacy}","received_events_url":"https://api.github.com/users/xprazak2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xprazak2/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/xprazak2/foreman","forks_url":"https://api.github.com/repos/xprazak2/foreman/forks","keys_url":"https://api.github.com/repos/xprazak2/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xprazak2/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xprazak2/foreman/teams","hooks_url":"https://api.github.com/repos/xprazak2/foreman/hooks","issue_events_url":"https://api.github.com/repos/xprazak2/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/xprazak2/foreman/events","assignees_url":"https://api.github.com/repos/xprazak2/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/xprazak2/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/xprazak2/foreman/tags","blobs_url":"https://api.github.com/repos/xprazak2/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xprazak2/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xprazak2/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/xprazak2/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xprazak2/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/xprazak2/foreman/languages","stargazers_url":"https://api.github.com/repos/xprazak2/foreman/stargazers","contributors_url":"https://api.github.com/repos/xprazak2/foreman/contributors","subscribers_url":"https://api.github.com/repos/xprazak2/foreman/subscribers","subscription_url":"https://api.github.com/repos/xprazak2/foreman/subscription","commits_url":"https://api.github.com/repos/xprazak2/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/xprazak2/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/xprazak2/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/xprazak2/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/xprazak2/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/xprazak2/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xprazak2/foreman/merges","archive_url":"https://api.github.com/repos/xprazak2/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xprazak2/foreman/downloads","issues_url":"https://api.github.com/repos/xprazak2/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/xprazak2/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/xprazak2/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/xprazak2/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xprazak2/foreman/labels{/name}","releases_url":"https://api.github.com/repos/xprazak2/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/xprazak2/foreman/deployments","created_at":"2015-04-08T11:23:52Z","updated_at":"2015-04-08T11:23:58Z","pushed_at":"2016-03-14T14:13:25Z","git_url":"git://github.com/xprazak2/foreman.git","ssh_url":"git@github.com:xprazak2/foreman.git","clone_url":"https://github.com/xprazak2/foreman.git","svn_url":"https://github.com/xprazak2/foreman","homepage":"http://theforeman.org","size":38807,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"fc362ac8b5f9a9f8fb10ccaec1f68d5471b1bcf8","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman/deployments","created_at":"2009-07-23T15:07:00Z","updated_at":"2016-03-09T08:08:30Z","pushed_at":"2016-03-14T16:51:43Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":59562,"stargazers_count":959,"watchers_count":959,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":494,"mirror_url":null,"open_issues_count":102,"forks":494,"open_issues":102,"watchers":959,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3297"},"html":{"href":"https://github.com/theforeman/foreman/pull/3297"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3297"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3297/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3297/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3297/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/7ee6586a769e612427d5430a32f617affeef5553"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":3,"commits":1,"additions":146,"deletions":18,"changed_files":6}}