{"action":"created","issue":{"url":"https://api.github.com/repos/namely/styleguide/issues/233","labels_url":"https://api.github.com/repos/namely/styleguide/issues/233/labels{/name}","comments_url":"https://api.github.com/repos/namely/styleguide/issues/233/comments","events_url":"https://api.github.com/repos/namely/styleguide/issues/233/events","html_url":"https://github.com/namely/styleguide/pull/233","id":123373476,"number":233,"title":"Fieldsets / Wells","user":{"login":"jasonfellows","id":1119770,"avatar_url":"https://avatars.githubusercontent.com/u/1119770?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonfellows","html_url":"https://github.com/jasonfellows","followers_url":"https://api.github.com/users/jasonfellows/followers","following_url":"https://api.github.com/users/jasonfellows/following{/other_user}","gists_url":"https://api.github.com/users/jasonfellows/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonfellows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonfellows/subscriptions","organizations_url":"https://api.github.com/users/jasonfellows/orgs","repos_url":"https://api.github.com/users/jasonfellows/repos","events_url":"https://api.github.com/users/jasonfellows/events{/privacy}","received_events_url":"https://api.github.com/users/jasonfellows/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/namely/styleguide/labels/refactor","name":"refactor","color":"dec2e5"},{"url":"https://api.github.com/repos/namely/styleguide/labels/RFC","name":"RFC","color":"52ac00"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-12-21T22:37:00Z","updated_at":"2016-01-13T22:27:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/namely/styleguide/pulls/233","html_url":"https://github.com/namely/styleguide/pull/233","diff_url":"https://github.com/namely/styleguide/pull/233.diff","patch_url":"https://github.com/namely/styleguide/pull/233.patch"},"body":"I don't think we need to pass props for 'field-light', et al. to all of our field components. This can be accomplished by styling children of the native `fieldset` node and the `.tooltip` class.\r\n\r\nI'd started working on a FieldSet component and it was completely dumb, no props or any logic, just a wrapper adding functional classes.\r\n\r\nThere are a few things like PTO plan settings that use a well-style appearance, but these can be styled using functional classes. Default styles should cover all other cases.\r\n\r\n<img width=\"438\" alt=\"screen shot 2015-12-21 at 5 32 35 pm\" src=\"https://cloud.githubusercontent.com/assets/1119770/11943053/e8e8b0a4-a808-11e5-858d-f1630dbab040.png\">\r\n<img width=\"437\" alt=\"screen shot 2015-12-21 at 5 32 41 pm\" src=\"https://cloud.githubusercontent.com/assets/1119770/11943056/eaf3674a-a808-11e5-966a-b9d2b507b9d8.png\">\r\n\r\nThis PR covers the following tasks:\r\n- [x] Update forms.js to use native `fieldset`\r\n- [x] Add default style for `fieldset` element\r\n- [x] Update `forms.scss` to style children of `fieldset`\r\n- [x] Create styles in `forms.scss` for forms inside popups\r\n- [x] Fix missing / incorrect hover styles for `inputs` in all three parents \r\n- [x] Remove `fieldColor` props from all fields"},"comment":{"url":"https://api.github.com/repos/namely/styleguide/issues/comments/171457166","html_url":"https://github.com/namely/styleguide/pull/233#issuecomment-171457166","issue_url":"https://api.github.com/repos/namely/styleguide/issues/233","id":171457166,"user":{"login":"katienreed","id":7364813,"avatar_url":"https://avatars.githubusercontent.com/u/7364813?v=3","gravatar_id":"","url":"https://api.github.com/users/katienreed","html_url":"https://github.com/katienreed","followers_url":"https://api.github.com/users/katienreed/followers","following_url":"https://api.github.com/users/katienreed/following{/other_user}","gists_url":"https://api.github.com/users/katienreed/gists{/gist_id}","starred_url":"https://api.github.com/users/katienreed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katienreed/subscriptions","organizations_url":"https://api.github.com/users/katienreed/orgs","repos_url":"https://api.github.com/users/katienreed/repos","events_url":"https://api.github.com/users/katienreed/events{/privacy}","received_events_url":"https://api.github.com/users/katienreed/received_events","type":"User","site_admin":false},"created_at":"2016-01-13T22:27:44Z","updated_at":"2016-01-13T22:27:44Z","body":"+1 looks good to me, Jason!"}}