{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/53698265","id":53698265,"diff_hunk":"@@ -0,0 +1,115 @@\n+module QuadiconHelper","path":"app/helpers/quadicon_helper.rb","position":1,"original_position":1,"commit_id":"2f53535b81e9e2398d005d9b03df30e810f64500","original_commit_id":"2f53535b81e9e2398d005d9b03df30e810f64500","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"body":"One suggestion here is properly mark which methods are private vs public.","created_at":"2016-02-22T21:45:21Z","updated_at":"2016-02-22T21:45:21Z","html_url":"https://github.com/ManageIQ/manageiq/pull/6833#discussion_r53698265","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6833","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/53698265"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/6833#discussion_r53698265"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6833"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6833","id":60043772,"html_url":"https://github.com/ManageIQ/manageiq/pull/6833","diff_url":"https://github.com/ManageIQ/manageiq/pull/6833.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/6833.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/6833","number":6833,"state":"open","locked":false,"title":"Quadicon rendering cleanups #1","user":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"body":"I replaced the base quadicon partial with a helper method.\r\n\r\nThe speed of rendering of of 1000 quadicons on my dev setup is aprox.10% faster (from slightly above 26s down to around 24s). \r\n\r\nIn a series of steps I'd like to have all of the logic move from HAML to Ruby. Then do a proper measurement of the speed change.","created_at":"2016-02-20T09:52:16Z","updated_at":"2016-02-22T21:45:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7795c54bf7be1c97a93980081ee9b0a1646012ae","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6833/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6833/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/6833/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/2f53535b81e9e2398d005d9b03df30e810f64500","head":{"label":"martinpovolny:quadicon_helper","ref":"quadicon_helper","sha":"2f53535b81e9e2398d005d9b03df30e810f64500","user":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"repo":{"id":20877847,"name":"manageiq","full_name":"martinpovolny/manageiq","owner":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinpovolny/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/martinpovolny/manageiq","forks_url":"https://api.github.com/repos/martinpovolny/manageiq/forks","keys_url":"https://api.github.com/repos/martinpovolny/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinpovolny/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinpovolny/manageiq/teams","hooks_url":"https://api.github.com/repos/martinpovolny/manageiq/hooks","issue_events_url":"https://api.github.com/repos/martinpovolny/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/martinpovolny/manageiq/events","assignees_url":"https://api.github.com/repos/martinpovolny/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/martinpovolny/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/martinpovolny/manageiq/tags","blobs_url":"https://api.github.com/repos/martinpovolny/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinpovolny/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinpovolny/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinpovolny/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinpovolny/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/martinpovolny/manageiq/languages","stargazers_url":"https://api.github.com/repos/martinpovolny/manageiq/stargazers","contributors_url":"https://api.github.com/repos/martinpovolny/manageiq/contributors","subscribers_url":"https://api.github.com/repos/martinpovolny/manageiq/subscribers","subscription_url":"https://api.github.com/repos/martinpovolny/manageiq/subscription","commits_url":"https://api.github.com/repos/martinpovolny/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinpovolny/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinpovolny/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinpovolny/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinpovolny/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/martinpovolny/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinpovolny/manageiq/merges","archive_url":"https://api.github.com/repos/martinpovolny/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinpovolny/manageiq/downloads","issues_url":"https://api.github.com/repos/martinpovolny/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/martinpovolny/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/martinpovolny/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/martinpovolny/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinpovolny/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/martinpovolny/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/martinpovolny/manageiq/deployments","created_at":"2014-06-16T08:30:21Z","updated_at":"2016-01-21T14:43:22Z","pushed_at":"2016-02-22T17:55:41Z","git_url":"git://github.com/martinpovolny/manageiq.git","ssh_url":"git@github.com:martinpovolny/manageiq.git","clone_url":"https://github.com/martinpovolny/manageiq.git","svn_url":"https://github.com/martinpovolny/manageiq","homepage":null,"size":122342,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"cf91ead14f5af2c9d45cb4793d514a3032cf622e","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-02-22T06:10:01Z","pushed_at":"2016-02-22T21:41:06Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":142976,"stargazers_count":222,"watchers_count":222,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":238,"mirror_url":null,"open_issues_count":572,"forks":238,"open_issues":572,"watchers":222,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6833"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/6833"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/6833"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/6833/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6833/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/6833/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/2f53535b81e9e2398d005d9b03df30e810f64500"}}}}