{"action":"created","issue":{"url":"https://api.github.com/repos/rethinkdb/rethinkdb/issues/5926","repository_url":"https://api.github.com/repos/rethinkdb/rethinkdb","labels_url":"https://api.github.com/repos/rethinkdb/rethinkdb/issues/5926/labels{/name}","comments_url":"https://api.github.com/repos/rethinkdb/rethinkdb/issues/5926/comments","events_url":"https://api.github.com/repos/rethinkdb/rethinkdb/issues/5926/events","html_url":"https://github.com/rethinkdb/rethinkdb/issues/5926","id":164594250,"number":5926,"title":"GCC 5.3.1 compilation issue in `perfmon.cc`","user":{"login":"VeXocide","id":167416,"avatar_url":"https://avatars.githubusercontent.com/u/167416?v=3","gravatar_id":"","url":"https://api.github.com/users/VeXocide","html_url":"https://github.com/VeXocide","followers_url":"https://api.github.com/users/VeXocide/followers","following_url":"https://api.github.com/users/VeXocide/following{/other_user}","gists_url":"https://api.github.com/users/VeXocide/gists{/gist_id}","starred_url":"https://api.github.com/users/VeXocide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VeXocide/subscriptions","organizations_url":"https://api.github.com/users/VeXocide/orgs","repos_url":"https://api.github.com/users/VeXocide/repos","events_url":"https://api.github.com/users/VeXocide/events{/privacy}","received_events_url":"https://api.github.com/users/VeXocide/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rethinkdb/rethinkdb/labels/cp:build","name":"cp:build","color":"444444"},{"url":"https://api.github.com/repos/rethinkdb/rethinkdb/labels/tp:bug","name":"tp:bug","color":"e102d8"}],"state":"open","locked":false,"assignee":{"login":"VeXocide","id":167416,"avatar_url":"https://avatars.githubusercontent.com/u/167416?v=3","gravatar_id":"","url":"https://api.github.com/users/VeXocide","html_url":"https://github.com/VeXocide","followers_url":"https://api.github.com/users/VeXocide/followers","following_url":"https://api.github.com/users/VeXocide/following{/other_user}","gists_url":"https://api.github.com/users/VeXocide/gists{/gist_id}","starred_url":"https://api.github.com/users/VeXocide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VeXocide/subscriptions","organizations_url":"https://api.github.com/users/VeXocide/orgs","repos_url":"https://api.github.com/users/VeXocide/repos","events_url":"https://api.github.com/users/VeXocide/events{/privacy}","received_events_url":"https://api.github.com/users/VeXocide/received_events","type":"User","site_admin":false},"assignees":[{"login":"VeXocide","id":167416,"avatar_url":"https://avatars.githubusercontent.com/u/167416?v=3","gravatar_id":"","url":"https://api.github.com/users/VeXocide","html_url":"https://github.com/VeXocide","followers_url":"https://api.github.com/users/VeXocide/followers","following_url":"https://api.github.com/users/VeXocide/following{/other_user}","gists_url":"https://api.github.com/users/VeXocide/gists{/gist_id}","starred_url":"https://api.github.com/users/VeXocide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VeXocide/subscriptions","organizations_url":"https://api.github.com/users/VeXocide/orgs","repos_url":"https://api.github.com/users/VeXocide/repos","events_url":"https://api.github.com/users/VeXocide/events{/privacy}","received_events_url":"https://api.github.com/users/VeXocide/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/rethinkdb/rethinkdb/milestones/119","html_url":"https://github.com/rethinkdb/rethinkdb/milestones/2.3.x","labels_url":"https://api.github.com/repos/rethinkdb/rethinkdb/milestones/119/labels","id":1687920,"number":119,"title":"2.3.x","description":null,"creator":{"login":"danielmewes","id":505365,"avatar_url":"https://avatars.githubusercontent.com/u/505365?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmewes","html_url":"https://github.com/danielmewes","followers_url":"https://api.github.com/users/danielmewes/followers","following_url":"https://api.github.com/users/danielmewes/following{/other_user}","gists_url":"https://api.github.com/users/danielmewes/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmewes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmewes/subscriptions","organizations_url":"https://api.github.com/users/danielmewes/orgs","repos_url":"https://api.github.com/users/danielmewes/repos","events_url":"https://api.github.com/users/danielmewes/events{/privacy}","received_events_url":"https://api.github.com/users/danielmewes/received_events","type":"User","site_admin":false},"open_issues":57,"closed_issues":20,"state":"open","created_at":"2016-04-06T18:05:18Z","updated_at":"2016-07-26T00:38:53Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-07-08T18:54:57Z","updated_at":"2016-07-26T18:05:08Z","closed_at":null,"body":"On Slack @shiva proposed the following patch to fix a compilation issue.\r\n```\r\ndiff --git a/src/perfmon/perfmon.cc b/src/perfmon/perfmon.cc\r\nindex c426ad9..68d6666 100644\r\n--- a/src/perfmon/perfmon.cc\r\n+++ b/src/perfmon/perfmon.cc\r\n@@ -159,7 +159,7 @@ stddev_t::stddev_t()\r\nstddev_t::stddev_t(size_t n, double _mean, double variance)\r\n    : N(n), M(_mean), Q(variance * n) {\r\n    if (N == 0)\r\n-        rassert(isnan(M) && isnan(Q));\r\n+       rassert(std::isnan(M) && std::isnan(Q));\r\n}\r\n```\r\n\r\n```\r\ngcc --version \r\ngcc (Ubuntu 5.3.1-14ubuntu2.1) 5.3.1 20160413\r\n```\r\n\r\nIt looks fine at first glance, but I suspect `isnan` may be a macro on certain platforms requiring us to implement an `risnan` similar to `risfinite` in `utils.cc`."},"comment":{"url":"https://api.github.com/repos/rethinkdb/rethinkdb/issues/comments/235353724","html_url":"https://github.com/rethinkdb/rethinkdb/issues/5926#issuecomment-235353724","issue_url":"https://api.github.com/repos/rethinkdb/rethinkdb/issues/5926","id":235353724,"user":{"login":"VeXocide","id":167416,"avatar_url":"https://avatars.githubusercontent.com/u/167416?v=3","gravatar_id":"","url":"https://api.github.com/users/VeXocide","html_url":"https://github.com/VeXocide","followers_url":"https://api.github.com/users/VeXocide/followers","following_url":"https://api.github.com/users/VeXocide/following{/other_user}","gists_url":"https://api.github.com/users/VeXocide/gists{/gist_id}","starred_url":"https://api.github.com/users/VeXocide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VeXocide/subscriptions","organizations_url":"https://api.github.com/users/VeXocide/orgs","repos_url":"https://api.github.com/users/VeXocide/repos","events_url":"https://api.github.com/users/VeXocide/events{/privacy}","received_events_url":"https://api.github.com/users/VeXocide/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T18:05:08Z","updated_at":"2016-07-26T18:05:08Z","body":"Merged into `next` via commits 4986dbf97476d83bf41ee66e79781e776f00de9a."}}
{"actor":{"display_login":"VeXocide"}}