{"action":"created","issue":{"url":"https://api.github.com/repos/ros2/rmw_connext/issues/192","repository_url":"https://api.github.com/repos/ros2/rmw_connext","labels_url":"https://api.github.com/repos/ros2/rmw_connext/issues/192/labels{/name}","comments_url":"https://api.github.com/repos/ros2/rmw_connext/issues/192/comments","events_url":"https://api.github.com/repos/ros2/rmw_connext/issues/192/events","html_url":"https://github.com/ros2/rmw_connext/pull/192","id":163980710,"number":192,"title":"build rmw_connext_dynamic_cpp in two parts to match ABI of Connext as well as ROS","user":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars.githubusercontent.com/u/100427?v=3","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ros2/rmw_connext/labels/in%20progress","name":"in progress","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-07-06T01:31:07Z","updated_at":"2016-07-06T16:35:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ros2/rmw_connext/pulls/192","html_url":"https://github.com/ros2/rmw_connext/pull/192","diff_url":"https://github.com/ros2/rmw_connext/pull/192.diff","patch_url":"https://github.com/ros2/rmw_connext/pull/192.patch"},"body":"Rebase and fixup of https://github.com/ros2/rmw_connext/pull/189 since the merge of #187.\r\n\r\n@dirk-thomas I think this branch is ok, but you should look it over closely. It builds on my mac, but I haven't re-tested it on CI or in my Linux VM for the ABI problem, though if I understand the strategy, I think this should work.\r\n\r\nLike your branch, this pr only moves code around and is careful about what functions get included where (either the functions.cpp file or the publish_take.cpp file, which have different ABI settings)."},"comment":{"url":"https://api.github.com/repos/ros2/rmw_connext/issues/comments/230830051","html_url":"https://github.com/ros2/rmw_connext/pull/192#issuecomment-230830051","issue_url":"https://api.github.com/repos/ros2/rmw_connext/issues/192","id":230830051,"user":{"login":"dirk-thomas","id":1335366,"avatar_url":"https://avatars.githubusercontent.com/u/1335366?v=3","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"created_at":"2016-07-06T16:35:54Z","updated_at":"2016-07-06T16:35:54Z","body":"Seems to work with the official RTI binaries which use the old ABI: http://ci.ros2.org/job/ci_linux/1636/#showFailuresLink\r\n\r\n+1"}}
{"actor":{"display_login":"dirk-thomas"}}