{"action":"opened","number":10254,"pull_request":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/10254","id":95946488,"html_url":"https://github.com/mrdoob/three.js/pull/10254","diff_url":"https://github.com/mrdoob/three.js/pull/10254.diff","patch_url":"https://github.com/mrdoob/three.js/pull/10254.patch","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/10254","number":10254,"state":"open","locked":false,"title":"Expose when, offset and duration parameters in Audio.play()","user":{"login":"sttz","id":173249,"avatar_url":"https://avatars.githubusercontent.com/u/173249?v=3","gravatar_id":"","url":"https://api.github.com/users/sttz","html_url":"https://github.com/sttz","followers_url":"https://api.github.com/users/sttz/followers","following_url":"https://api.github.com/users/sttz/following{/other_user}","gists_url":"https://api.github.com/users/sttz/gists{/gist_id}","starred_url":"https://api.github.com/users/sttz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttz/subscriptions","organizations_url":"https://api.github.com/users/sttz/orgs","repos_url":"https://api.github.com/users/sttz/repos","events_url":"https://api.github.com/users/sttz/events{/privacy}","received_events_url":"https://api.github.com/users/sttz/received_events","type":"User","site_admin":false},"body":"I tried to implemented audio sprites on top of three.js but doing so requires setting the arguments of  `AudioBufferSourceNode.start(when, offset, duration)`, especially `offset` and `duration`.\r\n\r\nIt would be possible to change the `Audio.startTime` property to influence to offset passed to `start()` but `duration` isn't currently passed at all.\r\n\r\nThis pull request exposes all three parameters of `start()` – `when`, `offset` and `duration` as parameters of `Audio.play()`.\r\n\r\nI don't need `when` for audio sprites but it seemed more consistent to expose all three parameters together. Alternatively, only `duration` could be exposed and I could set `this.startTime` before calling `play()`.","created_at":"2016-11-30T18:24:37Z","updated_at":"2016-11-30T18:24:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d245c917f669ec4a6d33bc59731461d77e3331a9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mrdoob/three.js/pulls/10254/commits","review_comments_url":"https://api.github.com/repos/mrdoob/three.js/pulls/10254/comments","review_comment_url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/10254/comments","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/474eb200def91d4f3000eaf87953af411d5d2a43","head":{"label":"sttz:audio_duration","ref":"audio_duration","sha":"474eb200def91d4f3000eaf87953af411d5d2a43","user":{"login":"sttz","id":173249,"avatar_url":"https://avatars.githubusercontent.com/u/173249?v=3","gravatar_id":"","url":"https://api.github.com/users/sttz","html_url":"https://github.com/sttz","followers_url":"https://api.github.com/users/sttz/followers","following_url":"https://api.github.com/users/sttz/following{/other_user}","gists_url":"https://api.github.com/users/sttz/gists{/gist_id}","starred_url":"https://api.github.com/users/sttz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttz/subscriptions","organizations_url":"https://api.github.com/users/sttz/orgs","repos_url":"https://api.github.com/users/sttz/repos","events_url":"https://api.github.com/users/sttz/events{/privacy}","received_events_url":"https://api.github.com/users/sttz/received_events","type":"User","site_admin":false},"repo":{"id":73221861,"name":"three.js","full_name":"sttz/three.js","owner":{"login":"sttz","id":173249,"avatar_url":"https://avatars.githubusercontent.com/u/173249?v=3","gravatar_id":"","url":"https://api.github.com/users/sttz","html_url":"https://github.com/sttz","followers_url":"https://api.github.com/users/sttz/followers","following_url":"https://api.github.com/users/sttz/following{/other_user}","gists_url":"https://api.github.com/users/sttz/gists{/gist_id}","starred_url":"https://api.github.com/users/sttz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttz/subscriptions","organizations_url":"https://api.github.com/users/sttz/orgs","repos_url":"https://api.github.com/users/sttz/repos","events_url":"https://api.github.com/users/sttz/events{/privacy}","received_events_url":"https://api.github.com/users/sttz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sttz/three.js","description":"JavaScript 3D library.","fork":true,"url":"https://api.github.com/repos/sttz/three.js","forks_url":"https://api.github.com/repos/sttz/three.js/forks","keys_url":"https://api.github.com/repos/sttz/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sttz/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sttz/three.js/teams","hooks_url":"https://api.github.com/repos/sttz/three.js/hooks","issue_events_url":"https://api.github.com/repos/sttz/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/sttz/three.js/events","assignees_url":"https://api.github.com/repos/sttz/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/sttz/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/sttz/three.js/tags","blobs_url":"https://api.github.com/repos/sttz/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sttz/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sttz/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/sttz/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sttz/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/sttz/three.js/languages","stargazers_url":"https://api.github.com/repos/sttz/three.js/stargazers","contributors_url":"https://api.github.com/repos/sttz/three.js/contributors","subscribers_url":"https://api.github.com/repos/sttz/three.js/subscribers","subscription_url":"https://api.github.com/repos/sttz/three.js/subscription","commits_url":"https://api.github.com/repos/sttz/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/sttz/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/sttz/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/sttz/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/sttz/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/sttz/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sttz/three.js/merges","archive_url":"https://api.github.com/repos/sttz/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sttz/three.js/downloads","issues_url":"https://api.github.com/repos/sttz/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/sttz/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/sttz/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/sttz/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sttz/three.js/labels{/name}","releases_url":"https://api.github.com/repos/sttz/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/sttz/three.js/deployments","created_at":"2016-11-08T19:55:54Z","updated_at":"2016-11-08T19:56:01Z","pushed_at":"2016-11-30T18:14:24Z","git_url":"git://github.com/sttz/three.js.git","ssh_url":"git@github.com:sttz/three.js.git","clone_url":"https://github.com/sttz/three.js.git","svn_url":"https://github.com/sttz/three.js","homepage":"http://threejs.org/","size":417402,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"mrdoob:dev","ref":"dev","sha":"51e96d21e59418fd12ed8b72d5a7391deecbc49e","user":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"repo":{"id":576201,"name":"three.js","full_name":"mrdoob/three.js","owner":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrdoob/three.js","description":"JavaScript 3D library.","fork":false,"url":"https://api.github.com/repos/mrdoob/three.js","forks_url":"https://api.github.com/repos/mrdoob/three.js/forks","keys_url":"https://api.github.com/repos/mrdoob/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrdoob/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrdoob/three.js/teams","hooks_url":"https://api.github.com/repos/mrdoob/three.js/hooks","issue_events_url":"https://api.github.com/repos/mrdoob/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/mrdoob/three.js/events","assignees_url":"https://api.github.com/repos/mrdoob/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/mrdoob/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/mrdoob/three.js/tags","blobs_url":"https://api.github.com/repos/mrdoob/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrdoob/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrdoob/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrdoob/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mrdoob/three.js/languages","stargazers_url":"https://api.github.com/repos/mrdoob/three.js/stargazers","contributors_url":"https://api.github.com/repos/mrdoob/three.js/contributors","subscribers_url":"https://api.github.com/repos/mrdoob/three.js/subscribers","subscription_url":"https://api.github.com/repos/mrdoob/three.js/subscription","commits_url":"https://api.github.com/repos/mrdoob/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrdoob/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrdoob/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrdoob/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrdoob/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/mrdoob/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrdoob/three.js/merges","archive_url":"https://api.github.com/repos/mrdoob/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrdoob/three.js/downloads","issues_url":"https://api.github.com/repos/mrdoob/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/mrdoob/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mrdoob/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mrdoob/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrdoob/three.js/labels{/name}","releases_url":"https://api.github.com/repos/mrdoob/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/mrdoob/three.js/deployments","created_at":"2010-03-23T18:58:01Z","updated_at":"2016-11-30T15:47:24Z","pushed_at":"2016-11-30T18:24:37Z","git_url":"git://github.com/mrdoob/three.js.git","ssh_url":"git@github.com:mrdoob/three.js.git","clone_url":"https://github.com/mrdoob/three.js.git","svn_url":"https://github.com/mrdoob/three.js","homepage":"http://threejs.org/","size":640453,"stargazers_count":29149,"watchers_count":29149,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":10081,"mirror_url":null,"open_issues_count":854,"forks":10081,"open_issues":854,"watchers":29149,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/10254"},"html":{"href":"https://github.com/mrdoob/three.js/pull/10254"},"issue":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/10254"},"comments":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/10254/comments"},"review_comments":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/10254/comments"},"review_comment":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/10254/commits"},"statuses":{"href":"https://api.github.com/repos/mrdoob/three.js/statuses/474eb200def91d4f3000eaf87953af411d5d2a43"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"sttz"}}