{"action":"created","issue":{"url":"https://api.github.com/repos/askmike/gekko/issues/352","repository_url":"https://api.github.com/repos/askmike/gekko","labels_url":"https://api.github.com/repos/askmike/gekko/issues/352/labels{/name}","comments_url":"https://api.github.com/repos/askmike/gekko/issues/352/comments","events_url":"https://api.github.com/repos/askmike/gekko/issues/352/events","html_url":"https://github.com/askmike/gekko/pull/352","id":162673580,"number":352,"title":"OkCoin China API Wrapper","user":{"login":"xhad","id":6130115,"avatar_url":"https://avatars.githubusercontent.com/u/6130115?v=3","gravatar_id":"","url":"https://api.github.com/users/xhad","html_url":"https://github.com/xhad","followers_url":"https://api.github.com/users/xhad/followers","following_url":"https://api.github.com/users/xhad/following{/other_user}","gists_url":"https://api.github.com/users/xhad/gists{/gist_id}","starred_url":"https://api.github.com/users/xhad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xhad/subscriptions","organizations_url":"https://api.github.com/users/xhad/orgs","repos_url":"https://api.github.com/users/xhad/repos","events_url":"https://api.github.com/users/xhad/events{/privacy}","received_events_url":"https://api.github.com/users/xhad/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-28T12:27:18Z","updated_at":"2016-07-01T15:45:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/askmike/gekko/pulls/352","html_url":"https://github.com/askmike/gekko/pull/352","diff_url":"https://github.com/askmike/gekko/pull/352.diff","patch_url":"https://github.com/askmike/gekko/pull/352.patch"},"body":"Hiya Mike! \r\n\r\nI'm getting an error that I wasn't able to figure out. Any advice off the top of your head about what could be causing this? Could it be the [getTrades date](https://github.com/xhad/gekko/blob/new-bitfinex/exchanges/okcoin.js#L123) formatting?\r\n\r\n`2016-06-28 21:21:14 (DEBUG):\tExchange has data spanning -8 seconds, we need at least 120 seconds.`\r\n`2016-06-28 21:21:14 (INFO):\t\t Unable to use locally stored candles.`\r\n\r\nEverything else seems alright with OkCoin China. I made an npm module and everything seems to work. However, I need to test everything. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/askmike/gekko/issues/comments/229980648","html_url":"https://github.com/askmike/gekko/pull/352#issuecomment-229980648","issue_url":"https://api.github.com/repos/askmike/gekko/issues/352","id":229980648,"user":{"login":"askmike","id":969743,"avatar_url":"https://avatars.githubusercontent.com/u/969743?v=3","gravatar_id":"","url":"https://api.github.com/users/askmike","html_url":"https://github.com/askmike","followers_url":"https://api.github.com/users/askmike/followers","following_url":"https://api.github.com/users/askmike/following{/other_user}","gists_url":"https://api.github.com/users/askmike/gists{/gist_id}","starred_url":"https://api.github.com/users/askmike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/askmike/subscriptions","organizations_url":"https://api.github.com/users/askmike/orgs","repos_url":"https://api.github.com/users/askmike/repos","events_url":"https://api.github.com/users/askmike/events{/privacy}","received_events_url":"https://api.github.com/users/askmike/received_events","type":"User","site_admin":false},"created_at":"2016-07-01T15:45:54Z","updated_at":"2016-07-01T15:45:54Z","body":"Hey,\r\n\r\nNo problem, I am already very happy that you are helping out!\r\n\r\n> However, sometimes a trade won't get filled. Is there a way to callback and cancel until the trade gets filled?\r\n\r\nCurrently, whenever the portfolioManager places an order it expects that order to be placed in the orderbook. [1 minute later the portfolioManager will check](https://github.com/askmike/gekko/blob/stable/core/portfolioManager.js#L273) if the order got (fully) filled. If it did not (sounds like what you are describing) than the portfolioManager will cancel the outstanding order and create a new one.\r\n\r\nShouldn't this automatically resolve the issue you describe?"}}
{"actor":{"display_login":"askmike"}}