{"action":"created","issue":{"url":"https://api.github.com/repos/nunit/nunit/issues/1365","repository_url":"https://api.github.com/repos/nunit/nunit","labels_url":"https://api.github.com/repos/nunit/nunit/issues/1365/labels{/name}","comments_url":"https://api.github.com/repos/nunit/nunit/issues/1365/comments","events_url":"https://api.github.com/repos/nunit/nunit/issues/1365/events","html_url":"https://github.com/nunit/nunit/pull/1365","id":142127242,"number":1365,"title":"Adding a DeclaringClassName property to Test class. Required for nunit/nunit3-vs-adapter#133.","user":{"login":"Green-Bug","id":16991057,"avatar_url":"https://avatars.githubusercontent.com/u/16991057?v=3","gravatar_id":"","url":"https://api.github.com/users/Green-Bug","html_url":"https://github.com/Green-Bug","followers_url":"https://api.github.com/users/Green-Bug/followers","following_url":"https://api.github.com/users/Green-Bug/following{/other_user}","gists_url":"https://api.github.com/users/Green-Bug/gists{/gist_id}","starred_url":"https://api.github.com/users/Green-Bug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Green-Bug/subscriptions","organizations_url":"https://api.github.com/users/Green-Bug/orgs","repos_url":"https://api.github.com/users/Green-Bug/repos","events_url":"https://api.github.com/users/Green-Bug/events{/privacy}","received_events_url":"https://api.github.com/users/Green-Bug/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-20T04:16:00Z","updated_at":"2016-03-20T05:50:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nunit/nunit/pulls/1365","html_url":"https://github.com/nunit/nunit/pull/1365","diff_url":"https://github.com/nunit/nunit/pull/1365.diff","patch_url":"https://github.com/nunit/nunit/pull/1365.patch"},"body":"If a method is added as a test through inheritance the ClassName property of Test class will contain the name of the derived class. This makes it impossible in the VS adapter to figure out the source location for that method.\r\nDeclaringClassName will be set to the class where the method was declared as that’s the class that can be used to find the source location when using DiaSession."},"comment":{"url":"https://api.github.com/repos/nunit/nunit/issues/comments/198854551","html_url":"https://github.com/nunit/nunit/pull/1365#issuecomment-198854551","issue_url":"https://api.github.com/repos/nunit/nunit/issues/1365","id":198854551,"user":{"login":"Green-Bug","id":16991057,"avatar_url":"https://avatars.githubusercontent.com/u/16991057?v=3","gravatar_id":"","url":"https://api.github.com/users/Green-Bug","html_url":"https://github.com/Green-Bug","followers_url":"https://api.github.com/users/Green-Bug/followers","following_url":"https://api.github.com/users/Green-Bug/following{/other_user}","gists_url":"https://api.github.com/users/Green-Bug/gists{/gist_id}","starred_url":"https://api.github.com/users/Green-Bug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Green-Bug/subscriptions","organizations_url":"https://api.github.com/users/Green-Bug/orgs","repos_url":"https://api.github.com/users/Green-Bug/repos","events_url":"https://api.github.com/users/Green-Bug/events{/privacy}","received_events_url":"https://api.github.com/users/Green-Bug/received_events","type":"User","site_admin":false},"created_at":"2016-03-20T05:50:43Z","updated_at":"2016-03-20T05:50:43Z","body":"It is a defensive change. I do not know who takes dependency on the ClassName property and Xml attribute. A method is included as a test because of the derived class but it may be defined in the base class. Having both gives someone more information to work with when parsing the Xml or when extending the adapter. I'm obviously not opposed to simply changing the behavior of ClassName property, it was in fact one of my attempts at the fix. I simply thought that having both gives more flexibility."}}