{"action":"created","comment":{"url":"https://api.github.com/repos/mixpanel/mixpanel-common/pulls/comments/92263428","pull_request_review_id":12759859,"id":92263428,"diff_hunk":"@@ -0,0 +1,130 @@\n+@import '../../stylesheets/defaults'\n+\n+tag-styles()\n+  .tag\n+    align-items center\n+    background-color grey-900\n+    border 1px solid\n+    border-radius 42px\n+    display inline-flex\n+    flex-direction row\n+    font-size 11px\n+    font-weight weight-bold\n+    height 24px\n+    justify-content center\n+    margin 6px 4px 0 0\n+    svg-icon-style(base-color: grey-500, size: 15px)\n+    span\n+      color #fff\n+      margin auto\n+      padding 0 8px\n+      vertical-align middle\n+    .close-icon\n+      cursor pointer\n+      padding-right 5px\n+\n+.mp-tag-selector-container\n+  border-radius 5px\n+  box-shadow: 0 10px 15px 0 rgba(0, 0, 0, 0.1), 0 15px 30px 0 rgba(0, 0, 0, 0.2);\n+  width 378px\n+\n+  .loader\n+    height 72px\n+    width 378px\n+    display flex\n+    mp-loader::shadow","path":"lib/widgets/tag-selector/index.styl","position":35,"original_position":35,"commit_id":"32cd510d0145fbf235e3256f03f1c27aad626113","original_commit_id":"32cd510d0145fbf235e3256f03f1c27aad626113","user":{"login":"jbwyme","id":556882,"avatar_url":"https://avatars.githubusercontent.com/u/556882?v=3","gravatar_id":"","url":"https://api.github.com/users/jbwyme","html_url":"https://github.com/jbwyme","followers_url":"https://api.github.com/users/jbwyme/followers","following_url":"https://api.github.com/users/jbwyme/following{/other_user}","gists_url":"https://api.github.com/users/jbwyme/gists{/gist_id}","starred_url":"https://api.github.com/users/jbwyme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbwyme/subscriptions","organizations_url":"https://api.github.com/users/jbwyme/orgs","repos_url":"https://api.github.com/users/jbwyme/repos","events_url":"https://api.github.com/users/jbwyme/events{/privacy}","received_events_url":"https://api.github.com/users/jbwyme/received_events","type":"User","site_admin":false},"body":"you said don't review the loader stuff but just in case: \r\n\r\n1. Shadow DOM v1 removes the `::shadow` selector\r\n2. We shouldn't need to reach into these styles anyways","created_at":"2016-12-13T20:52:38Z","updated_at":"2016-12-13T20:57:51Z","html_url":"https://github.com/mixpanel/mixpanel-common/pull/94#discussion_r92263428","pull_request_url":"https://api.github.com/repos/mixpanel/mixpanel-common/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/mixpanel/mixpanel-common/pulls/comments/92263428"},"html":{"href":"https://github.com/mixpanel/mixpanel-common/pull/94#discussion_r92263428"},"pull_request":{"href":"https://api.github.com/repos/mixpanel/mixpanel-common/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/mixpanel/mixpanel-common/pulls/94","id":97214744,"html_url":"https://github.com/mixpanel/mixpanel-common/pull/94","diff_url":"https://github.com/mixpanel/mixpanel-common/pull/94.diff","patch_url":"https://github.com/mixpanel/mixpanel-common/pull/94.patch","issue_url":"https://api.github.com/repos/mixpanel/mixpanel-common/issues/94","number":94,"state":"open","locked":false,"title":"Add dash widget","user":{"login":"zachwe","id":538610,"avatar_url":"https://avatars.githubusercontent.com/u/538610?v=3","gravatar_id":"","url":"https://api.github.com/users/zachwe","html_url":"https://github.com/zachwe","followers_url":"https://api.github.com/users/zachwe/followers","following_url":"https://api.github.com/users/zachwe/following{/other_user}","gists_url":"https://api.github.com/users/zachwe/gists{/gist_id}","starred_url":"https://api.github.com/users/zachwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachwe/subscriptions","organizations_url":"https://api.github.com/users/zachwe/orgs","repos_url":"https://api.github.com/users/zachwe/repos","events_url":"https://api.github.com/users/zachwe/events{/privacy}","received_events_url":"https://api.github.com/users/zachwe/received_events","type":"User","site_admin":false},"body":"Basic version of an \"add to dash\" widget that allows a user to select from existing plaintext \"tags\" and create new tags.\r\n\r\nThe visual behaviors that correspond to `loadState` aren't yet implemented. I'm not sure how best to handle the ajax requests—whether to make them from within the component (with the correct endpoints passed in as attributes?) or dispatch CustomEvents that should be caught/acted on by the parent element. So tips/patterns related to that would be much appreciated.","created_at":"2016-12-08T22:35:03Z","updated_at":"2016-12-13T20:57:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9fbc29c702c55051c7615edde2a0a1cecaafa97","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mixpanel/mixpanel-common/pulls/94/commits","review_comments_url":"https://api.github.com/repos/mixpanel/mixpanel-common/pulls/94/comments","review_comment_url":"https://api.github.com/repos/mixpanel/mixpanel-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixpanel/mixpanel-common/issues/94/comments","statuses_url":"https://api.github.com/repos/mixpanel/mixpanel-common/statuses/32cd510d0145fbf235e3256f03f1c27aad626113","head":{"label":"mixpanel:mp-autocomplete","ref":"mp-autocomplete","sha":"32cd510d0145fbf235e3256f03f1c27aad626113","user":{"login":"mixpanel","id":63653,"avatar_url":"https://avatars.githubusercontent.com/u/63653?v=3","gravatar_id":"","url":"https://api.github.com/users/mixpanel","html_url":"https://github.com/mixpanel","followers_url":"https://api.github.com/users/mixpanel/followers","following_url":"https://api.github.com/users/mixpanel/following{/other_user}","gists_url":"https://api.github.com/users/mixpanel/gists{/gist_id}","starred_url":"https://api.github.com/users/mixpanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixpanel/subscriptions","organizations_url":"https://api.github.com/users/mixpanel/orgs","repos_url":"https://api.github.com/users/mixpanel/repos","events_url":"https://api.github.com/users/mixpanel/events{/privacy}","received_events_url":"https://api.github.com/users/mixpanel/received_events","type":"Organization","site_admin":false},"repo":{"id":60127506,"name":"mixpanel-common","full_name":"mixpanel/mixpanel-common","owner":{"login":"mixpanel","id":63653,"avatar_url":"https://avatars.githubusercontent.com/u/63653?v=3","gravatar_id":"","url":"https://api.github.com/users/mixpanel","html_url":"https://github.com/mixpanel","followers_url":"https://api.github.com/users/mixpanel/followers","following_url":"https://api.github.com/users/mixpanel/following{/other_user}","gists_url":"https://api.github.com/users/mixpanel/gists{/gist_id}","starred_url":"https://api.github.com/users/mixpanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixpanel/subscriptions","organizations_url":"https://api.github.com/users/mixpanel/orgs","repos_url":"https://api.github.com/users/mixpanel/repos","events_url":"https://api.github.com/users/mixpanel/events{/privacy}","received_events_url":"https://api.github.com/users/mixpanel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixpanel/mixpanel-common","description":"Contains consistent styles, components, widgets, etc for use across the mixpanel product","fork":false,"url":"https://api.github.com/repos/mixpanel/mixpanel-common","forks_url":"https://api.github.com/repos/mixpanel/mixpanel-common/forks","keys_url":"https://api.github.com/repos/mixpanel/mixpanel-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixpanel/mixpanel-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixpanel/mixpanel-common/teams","hooks_url":"https://api.github.com/repos/mixpanel/mixpanel-common/hooks","issue_events_url":"https://api.github.com/repos/mixpanel/mixpanel-common/issues/events{/number}","events_url":"https://api.github.com/repos/mixpanel/mixpanel-common/events","assignees_url":"https://api.github.com/repos/mixpanel/mixpanel-common/assignees{/user}","branches_url":"https://api.github.com/repos/mixpanel/mixpanel-common/branches{/branch}","tags_url":"https://api.github.com/repos/mixpanel/mixpanel-common/tags","blobs_url":"https://api.github.com/repos/mixpanel/mixpanel-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixpanel/mixpanel-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixpanel/mixpanel-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixpanel/mixpanel-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixpanel/mixpanel-common/statuses/{sha}","languages_url":"https://api.github.com/repos/mixpanel/mixpanel-common/languages","stargazers_url":"https://api.github.com/repos/mixpanel/mixpanel-common/stargazers","contributors_url":"https://api.github.com/repos/mixpanel/mixpanel-common/contributors","subscribers_url":"https://api.github.com/repos/mixpanel/mixpanel-common/subscribers","subscription_url":"https://api.github.com/repos/mixpanel/mixpanel-common/subscription","commits_url":"https://api.github.com/repos/mixpanel/mixpanel-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixpanel/mixpanel-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixpanel/mixpanel-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixpanel/mixpanel-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixpanel/mixpanel-common/contents/{+path}","compare_url":"https://api.github.com/repos/mixpanel/mixpanel-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixpanel/mixpanel-common/merges","archive_url":"https://api.github.com/repos/mixpanel/mixpanel-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixpanel/mixpanel-common/downloads","issues_url":"https://api.github.com/repos/mixpanel/mixpanel-common/issues{/number}","pulls_url":"https://api.github.com/repos/mixpanel/mixpanel-common/pulls{/number}","milestones_url":"https://api.github.com/repos/mixpanel/mixpanel-common/milestones{/number}","notifications_url":"https://api.github.com/repos/mixpanel/mixpanel-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixpanel/mixpanel-common/labels{/name}","releases_url":"https://api.github.com/repos/mixpanel/mixpanel-common/releases{/id}","deployments_url":"https://api.github.com/repos/mixpanel/mixpanel-common/deployments","created_at":"2016-05-31T22:18:16Z","updated_at":"2016-10-27T13:22:18Z","pushed_at":"2016-12-13T20:52:56Z","git_url":"git://github.com/mixpanel/mixpanel-common.git","ssh_url":"git@github.com:mixpanel/mixpanel-common.git","clone_url":"https://github.com/mixpanel/mixpanel-common.git","svn_url":"https://github.com/mixpanel/mixpanel-common","homepage":null,"size":1101,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":2,"default_branch":"master"}},"base":{"label":"mixpanel:master","ref":"master","sha":"32b45fc66a19385ef945c7a0f58b46f587d6bde8","user":{"login":"mixpanel","id":63653,"avatar_url":"https://avatars.githubusercontent.com/u/63653?v=3","gravatar_id":"","url":"https://api.github.com/users/mixpanel","html_url":"https://github.com/mixpanel","followers_url":"https://api.github.com/users/mixpanel/followers","following_url":"https://api.github.com/users/mixpanel/following{/other_user}","gists_url":"https://api.github.com/users/mixpanel/gists{/gist_id}","starred_url":"https://api.github.com/users/mixpanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixpanel/subscriptions","organizations_url":"https://api.github.com/users/mixpanel/orgs","repos_url":"https://api.github.com/users/mixpanel/repos","events_url":"https://api.github.com/users/mixpanel/events{/privacy}","received_events_url":"https://api.github.com/users/mixpanel/received_events","type":"Organization","site_admin":false},"repo":{"id":60127506,"name":"mixpanel-common","full_name":"mixpanel/mixpanel-common","owner":{"login":"mixpanel","id":63653,"avatar_url":"https://avatars.githubusercontent.com/u/63653?v=3","gravatar_id":"","url":"https://api.github.com/users/mixpanel","html_url":"https://github.com/mixpanel","followers_url":"https://api.github.com/users/mixpanel/followers","following_url":"https://api.github.com/users/mixpanel/following{/other_user}","gists_url":"https://api.github.com/users/mixpanel/gists{/gist_id}","starred_url":"https://api.github.com/users/mixpanel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixpanel/subscriptions","organizations_url":"https://api.github.com/users/mixpanel/orgs","repos_url":"https://api.github.com/users/mixpanel/repos","events_url":"https://api.github.com/users/mixpanel/events{/privacy}","received_events_url":"https://api.github.com/users/mixpanel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixpanel/mixpanel-common","description":"Contains consistent styles, components, widgets, etc for use across the mixpanel product","fork":false,"url":"https://api.github.com/repos/mixpanel/mixpanel-common","forks_url":"https://api.github.com/repos/mixpanel/mixpanel-common/forks","keys_url":"https://api.github.com/repos/mixpanel/mixpanel-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixpanel/mixpanel-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixpanel/mixpanel-common/teams","hooks_url":"https://api.github.com/repos/mixpanel/mixpanel-common/hooks","issue_events_url":"https://api.github.com/repos/mixpanel/mixpanel-common/issues/events{/number}","events_url":"https://api.github.com/repos/mixpanel/mixpanel-common/events","assignees_url":"https://api.github.com/repos/mixpanel/mixpanel-common/assignees{/user}","branches_url":"https://api.github.com/repos/mixpanel/mixpanel-common/branches{/branch}","tags_url":"https://api.github.com/repos/mixpanel/mixpanel-common/tags","blobs_url":"https://api.github.com/repos/mixpanel/mixpanel-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixpanel/mixpanel-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixpanel/mixpanel-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixpanel/mixpanel-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixpanel/mixpanel-common/statuses/{sha}","languages_url":"https://api.github.com/repos/mixpanel/mixpanel-common/languages","stargazers_url":"https://api.github.com/repos/mixpanel/mixpanel-common/stargazers","contributors_url":"https://api.github.com/repos/mixpanel/mixpanel-common/contributors","subscribers_url":"https://api.github.com/repos/mixpanel/mixpanel-common/subscribers","subscription_url":"https://api.github.com/repos/mixpanel/mixpanel-common/subscription","commits_url":"https://api.github.com/repos/mixpanel/mixpanel-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixpanel/mixpanel-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixpanel/mixpanel-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixpanel/mixpanel-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixpanel/mixpanel-common/contents/{+path}","compare_url":"https://api.github.com/repos/mixpanel/mixpanel-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixpanel/mixpanel-common/merges","archive_url":"https://api.github.com/repos/mixpanel/mixpanel-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixpanel/mixpanel-common/downloads","issues_url":"https://api.github.com/repos/mixpanel/mixpanel-common/issues{/number}","pulls_url":"https://api.github.com/repos/mixpanel/mixpanel-common/pulls{/number}","milestones_url":"https://api.github.com/repos/mixpanel/mixpanel-common/milestones{/number}","notifications_url":"https://api.github.com/repos/mixpanel/mixpanel-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixpanel/mixpanel-common/labels{/name}","releases_url":"https://api.github.com/repos/mixpanel/mixpanel-common/releases{/id}","deployments_url":"https://api.github.com/repos/mixpanel/mixpanel-common/deployments","created_at":"2016-05-31T22:18:16Z","updated_at":"2016-10-27T13:22:18Z","pushed_at":"2016-12-13T20:52:56Z","git_url":"git://github.com/mixpanel/mixpanel-common.git","ssh_url":"git@github.com:mixpanel/mixpanel-common.git","clone_url":"https://github.com/mixpanel/mixpanel-common.git","svn_url":"https://github.com/mixpanel/mixpanel-common","homepage":null,"size":1101,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixpanel/mixpanel-common/pulls/94"},"html":{"href":"https://github.com/mixpanel/mixpanel-common/pull/94"},"issue":{"href":"https://api.github.com/repos/mixpanel/mixpanel-common/issues/94"},"comments":{"href":"https://api.github.com/repos/mixpanel/mixpanel-common/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/mixpanel/mixpanel-common/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/mixpanel/mixpanel-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixpanel/mixpanel-common/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/mixpanel/mixpanel-common/statuses/32cd510d0145fbf235e3256f03f1c27aad626113"}}}}
{"actor":{"display_login":"jbwyme"}}