{"action":"created","issue":{"url":"https://api.github.com/repos/eduardok/libsmbclient-php/issues/47","repository_url":"https://api.github.com/repos/eduardok/libsmbclient-php","labels_url":"https://api.github.com/repos/eduardok/libsmbclient-php/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/eduardok/libsmbclient-php/issues/47/comments","events_url":"https://api.github.com/repos/eduardok/libsmbclient-php/issues/47/events","html_url":"https://github.com/eduardok/libsmbclient-php/issues/47","id":195089838,"number":47,"title":"Incorrect function definition for smbclient_read","user":{"login":"icewind1991","id":1283854,"avatar_url":"https://avatars.githubusercontent.com/u/1283854?v=3","gravatar_id":"","url":"https://api.github.com/users/icewind1991","html_url":"https://github.com/icewind1991","followers_url":"https://api.github.com/users/icewind1991/followers","following_url":"https://api.github.com/users/icewind1991/following{/other_user}","gists_url":"https://api.github.com/users/icewind1991/gists{/gist_id}","starred_url":"https://api.github.com/users/icewind1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icewind1991/subscriptions","organizations_url":"https://api.github.com/users/icewind1991/orgs","repos_url":"https://api.github.com/users/icewind1991/repos","events_url":"https://api.github.com/users/icewind1991/events{/privacy}","received_events_url":"https://api.github.com/users/icewind1991/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-12T21:24:47Z","updated_at":"2016-12-13T05:43:05Z","closed_at":null,"body":"The [function definition](https://github.com/eduardok/libsmbclient-php/blob/cf9259f563097cecdb7f84d8127ec009fdff90c7/smbclient.c#L271) defines only 2 parameters (state and file) while the [implementation](https://github.com/eduardok/libsmbclient-php/blob/cf9259f563097cecdb7f84d8127ec009fdff90c7/smbclient.c#L1324) (and documentation) use 3 parameters (state, file and count)\r\n\r\nI'm not sure if this has any behavioral effects but it causes reflection to report an invalid number of parameters which in turns trips static code analysers"},"comment":{"url":"https://api.github.com/repos/eduardok/libsmbclient-php/issues/comments/266650605","html_url":"https://github.com/eduardok/libsmbclient-php/issues/47#issuecomment-266650605","issue_url":"https://api.github.com/repos/eduardok/libsmbclient-php/issues/47","id":266650605,"user":{"login":"remicollet","id":270445,"avatar_url":"https://avatars.githubusercontent.com/u/270445?v=3","gravatar_id":"","url":"https://api.github.com/users/remicollet","html_url":"https://github.com/remicollet","followers_url":"https://api.github.com/users/remicollet/followers","following_url":"https://api.github.com/users/remicollet/following{/other_user}","gists_url":"https://api.github.com/users/remicollet/gists{/gist_id}","starred_url":"https://api.github.com/users/remicollet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remicollet/subscriptions","organizations_url":"https://api.github.com/users/remicollet/orgs","repos_url":"https://api.github.com/users/remicollet/repos","events_url":"https://api.github.com/users/remicollet/events{/privacy}","received_events_url":"https://api.github.com/users/remicollet/received_events","type":"User","site_admin":false},"created_at":"2016-12-13T05:43:05Z","updated_at":"2016-12-13T05:43:05Z","body":"Good catch..."}}
{"actor":{"display_login":"remicollet"}}