{"action":"created","issue":{"url":"https://api.github.com/repos/kenwheeler/nuka-carousel/issues/103","repository_url":"https://api.github.com/repos/kenwheeler/nuka-carousel","labels_url":"https://api.github.com/repos/kenwheeler/nuka-carousel/issues/103/labels{/name}","comments_url":"https://api.github.com/repos/kenwheeler/nuka-carousel/issues/103/comments","events_url":"https://api.github.com/repos/kenwheeler/nuka-carousel/issues/103/events","html_url":"https://github.com/kenwheeler/nuka-carousel/issues/103","id":160253467,"number":103,"title":"Slides sometimes render with zero height","user":{"login":"aczerepinski","id":11300677,"avatar_url":"https://avatars.githubusercontent.com/u/11300677?v=3","gravatar_id":"","url":"https://api.github.com/users/aczerepinski","html_url":"https://github.com/aczerepinski","followers_url":"https://api.github.com/users/aczerepinski/followers","following_url":"https://api.github.com/users/aczerepinski/following{/other_user}","gists_url":"https://api.github.com/users/aczerepinski/gists{/gist_id}","starred_url":"https://api.github.com/users/aczerepinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aczerepinski/subscriptions","organizations_url":"https://api.github.com/users/aczerepinski/orgs","repos_url":"https://api.github.com/users/aczerepinski/repos","events_url":"https://api.github.com/users/aczerepinski/events{/privacy}","received_events_url":"https://api.github.com/users/aczerepinski/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-06-14T18:38:00Z","updated_at":"2016-06-29T12:27:24Z","closed_at":null,"body":"I'm testing out 2.0.0 via the master branch, and seeing a new issue where slides will sometimes render with zero height. This is unrelated to/not fixed by commit 5ed9ff5. Resizing my browser window adds height to the slides instantly. I added this code to setDimensions, which fixes it for the most part:\r\n\r\n```\r\nif (firstSlide.offsetHeight === 0) {\r\n   var width = window.innerWidth;\r\n   firstSlide.style.width = width + 'px';\r\n   firstSlide.style.height = (width/2.4) + 'px'; //known ratio for my images - needed for Safari\r\n}\r\n```\r\nI'm not submitting this as a PR right now because it feels a bit hacky and istied to my external CSS and image ratio. Is anyone else experiencing this? Is there a cleaner solution?\r\n\r\nThis isn't an issue on ^1.2.0."},"comment":{"url":"https://api.github.com/repos/kenwheeler/nuka-carousel/issues/comments/229340979","html_url":"https://github.com/kenwheeler/nuka-carousel/issues/103#issuecomment-229340979","issue_url":"https://api.github.com/repos/kenwheeler/nuka-carousel/issues/103","id":229340979,"user":{"login":"kenwheeler","id":286616,"avatar_url":"https://avatars.githubusercontent.com/u/286616?v=3","gravatar_id":"","url":"https://api.github.com/users/kenwheeler","html_url":"https://github.com/kenwheeler","followers_url":"https://api.github.com/users/kenwheeler/followers","following_url":"https://api.github.com/users/kenwheeler/following{/other_user}","gists_url":"https://api.github.com/users/kenwheeler/gists{/gist_id}","starred_url":"https://api.github.com/users/kenwheeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenwheeler/subscriptions","organizations_url":"https://api.github.com/users/kenwheeler/orgs","repos_url":"https://api.github.com/users/kenwheeler/repos","events_url":"https://api.github.com/users/kenwheeler/events{/privacy}","received_events_url":"https://api.github.com/users/kenwheeler/received_events","type":"User","site_admin":false},"created_at":"2016-06-29T12:27:24Z","updated_at":"2016-06-29T12:27:24Z","body":"Wraparound mode is where you never hit the end. Whether you hit next, or swipe, it loops. Not an easy problem to solve. In the past I've done it with clones, but that introduces a whole slew of new issues. With absolute positioning, I can move slides from the back to front when needed."}}
{"actor":{"display_login":"kenwheeler"}}