{"action":"created","issue":{"url":"https://api.github.com/repos/crigroup/ensenso/issues/13","repository_url":"https://api.github.com/repos/crigroup/ensenso","labels_url":"https://api.github.com/repos/crigroup/ensenso/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/crigroup/ensenso/issues/13/comments","events_url":"https://api.github.com/repos/crigroup/ensenso/issues/13/events","html_url":"https://github.com/crigroup/ensenso/issues/13","id":178534085,"number":13,"title":"Contribute back to PCL","user":{"login":"VictorLamoine","id":5566160,"avatar_url":"https://avatars.githubusercontent.com/u/5566160?v=3","gravatar_id":"","url":"https://api.github.com/users/VictorLamoine","html_url":"https://github.com/VictorLamoine","followers_url":"https://api.github.com/users/VictorLamoine/followers","following_url":"https://api.github.com/users/VictorLamoine/following{/other_user}","gists_url":"https://api.github.com/users/VictorLamoine/gists{/gist_id}","starred_url":"https://api.github.com/users/VictorLamoine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VictorLamoine/subscriptions","organizations_url":"https://api.github.com/users/VictorLamoine/orgs","repos_url":"https://api.github.com/users/VictorLamoine/repos","events_url":"https://api.github.com/users/VictorLamoine/events{/privacy}","received_events_url":"https://api.github.com/users/VictorLamoine/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-22T06:41:00Z","updated_at":"2016-09-22T06:50:55Z","closed_at":null,"body":"The code in ensenso_grabber.cpp and ensenso_grabber.h are merely a copy of the PCL driver, while this is totally compliant with the license it is too bad these modifications are not contributed to PCL and thus \"hidden in the dark\".\r\n\r\nFor example, you replace the `openDevice` signature to use a serial number, this is probably very useful to other people and it would be nice to integrate that into the \"official\" driver.\r\n\r\nBenefits:\r\n- One driver and not multiple copies of it\r\n- Easier mainting of the driver (everything in PCL) and your ROS wrapper (everything in your repository)\r\n- Code review by the PCL community\r\n\r\nCaveats:\r\n- You have to wait for your pull requests to be merged on PCL\r\n- It's going to be a litte bit harder to write install instructions (depending on the PCL release cycle)\r\n\r\nWhat do you think?"},"comment":{"url":"https://api.github.com/repos/crigroup/ensenso/issues/comments/248826193","html_url":"https://github.com/crigroup/ensenso/issues/13#issuecomment-248826193","issue_url":"https://api.github.com/repos/crigroup/ensenso/issues/13","id":248826193,"user":{"login":"VictorLamoine","id":5566160,"avatar_url":"https://avatars.githubusercontent.com/u/5566160?v=3","gravatar_id":"","url":"https://api.github.com/users/VictorLamoine","html_url":"https://github.com/VictorLamoine","followers_url":"https://api.github.com/users/VictorLamoine/followers","following_url":"https://api.github.com/users/VictorLamoine/following{/other_user}","gists_url":"https://api.github.com/users/VictorLamoine/gists{/gist_id}","starred_url":"https://api.github.com/users/VictorLamoine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VictorLamoine/subscriptions","organizations_url":"https://api.github.com/users/VictorLamoine/orgs","repos_url":"https://api.github.com/users/VictorLamoine/repos","events_url":"https://api.github.com/users/VictorLamoine/events{/privacy}","received_events_url":"https://api.github.com/users/VictorLamoine/received_events","type":"User","site_admin":false},"created_at":"2016-09-22T06:50:55Z","updated_at":"2016-09-22T06:50:55Z","body":"Also note that if you want to add Travis CI it is possible because I provide pre-compiled PCL versions (on a personnal server) with Ensenso support; take a look at https://github.com/InstitutMaupertuis/advanced_industrial_ci"}}
{"actor":{"display_login":"VictorLamoine"}}