{"action":"created","issue":{"url":"https://api.github.com/repos/phosphorjs/phosphor-ui/issues/20","repository_url":"https://api.github.com/repos/phosphorjs/phosphor-ui","labels_url":"https://api.github.com/repos/phosphorjs/phosphor-ui/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/phosphorjs/phosphor-ui/issues/20/comments","events_url":"https://api.github.com/repos/phosphorjs/phosphor-ui/issues/20/events","html_url":"https://github.com/phosphorjs/phosphor-ui/pull/20","id":150224840,"number":20,"title":"Allow configuring base widget and tab bar classes.","user":{"login":"jjrv","id":778781,"avatar_url":"https://avatars.githubusercontent.com/u/778781?v=3","gravatar_id":"","url":"https://api.github.com/users/jjrv","html_url":"https://github.com/jjrv","followers_url":"https://api.github.com/users/jjrv/followers","following_url":"https://api.github.com/users/jjrv/following{/other_user}","gists_url":"https://api.github.com/users/jjrv/gists{/gist_id}","starred_url":"https://api.github.com/users/jjrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjrv/subscriptions","organizations_url":"https://api.github.com/users/jjrv/orgs","repos_url":"https://api.github.com/users/jjrv/repos","events_url":"https://api.github.com/users/jjrv/events{/privacy}","received_events_url":"https://api.github.com/users/jjrv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-04-22T00:11:55Z","updated_at":"2016-04-23T18:45:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/phosphorjs/phosphor-ui/pulls/20","html_url":"https://github.com/phosphorjs/phosphor-ui/pull/20","diff_url":"https://github.com/phosphorjs/phosphor-ui/pull/20.diff","patch_url":"https://github.com/phosphorjs/phosphor-ui/pull/20.patch"},"body":"Proof of concept (though intended to be usable as is) solution for issue #17.\r\n\r\nAllowing to configure CSS class names turned out to require a few changes in various places, since the variables are no longer static. That feature could be left out, but I do like the idea that users could adapt PhosphorJS widgets to match their own CSS class naming scheme.\r\n\r\nIf this approach is accepted, I could modify the rest of the widgets to match (assuming no unforeseen complications).\r\n"},"comment":{"url":"https://api.github.com/repos/phosphorjs/phosphor-ui/issues/comments/213803950","html_url":"https://github.com/phosphorjs/phosphor-ui/pull/20#issuecomment-213803950","issue_url":"https://api.github.com/repos/phosphorjs/phosphor-ui/issues/20","id":213803950,"user":{"login":"sccolbert","id":137289,"avatar_url":"https://avatars.githubusercontent.com/u/137289?v=3","gravatar_id":"","url":"https://api.github.com/users/sccolbert","html_url":"https://github.com/sccolbert","followers_url":"https://api.github.com/users/sccolbert/followers","following_url":"https://api.github.com/users/sccolbert/following{/other_user}","gists_url":"https://api.github.com/users/sccolbert/gists{/gist_id}","starred_url":"https://api.github.com/users/sccolbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sccolbert/subscriptions","organizations_url":"https://api.github.com/users/sccolbert/orgs","repos_url":"https://api.github.com/users/sccolbert/repos","events_url":"https://api.github.com/users/sccolbert/events{/privacy}","received_events_url":"https://api.github.com/users/sccolbert/received_events","type":"User","site_admin":false},"created_at":"2016-04-23T18:45:52Z","updated_at":"2016-04-23T18:45:52Z","body":"The only reason that `Widget` does not always call `createNode` is so that you can take some node created by a foreign library (like Backbone), and wrap it in a widget. Notice that none of the widget subclasses accept this option, so `createNode` will always be called for those subclasses.\r\n\r\nThis was a concession to practicality, which i'm still not sure will make it into the `1.0` release. The `phosphor-widget` repo does not have this functionality:\r\nhttps://github.com/phosphorjs/phosphor-widget/blob/master/src/widget.ts#L68"}}