{"action":"created","comment":{"url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/pulls/comments/88674908","pull_request_review_id":9242770,"id":88674908,"diff_hunk":"@@ -28,164 +27,122 @@\n use Francken\\Domain\\Posts\\Post;\n use Francken\\Domain\\Posts\\PostRepository;\n use Francken\\Infrastructure\\Books\\BookDetailsRepository;\n-use Francken\\Infrastructure\\Http\\Controllers\\Admin\\RegistrationRequestsController;\n-use Francken\\Infrastructure\\Http\\Controllers\\BookController;\n-use Francken\\Infrastructure\\Http\\Controllers\\CommitteeController;\n+use Francken\\Infrastructure\\EventSourcing\\Factory;\n use Francken\\Infrastructure\\Repositories\\IlluminateRepository;\n use Illuminate\\Contracts\\Foundation\\Application;\n use Illuminate\\Database\\ConnectionInterface as DatabaseConnection;\n use Illuminate\\Support\\ServiceProvider;\n use League\\CommonMark\\CommonMarkConverter;\n \n-class AppServiceProvider extends ServiceProvider\n+final class AppServiceProvider extends ServiceProvider\n {\n+    // This constant contains all the repositories we want to register,\n+    // it contains pairs of the repository's class and the associated\n+    // aggregate's class name\n+    const EventSourcedRepositories = [\n+        [BookRepository::class, Book::class],\n+        [CommitteeRepository::class, Committee::class],\n+        [MemberRepository::class, Member::class],\n+        [PostRepository::class, Post::class],\n+        [RegistrationRequestRepository::class, RegistrationRequest::class],\n+    ];\n+\n+    // Similarly we can register illuminate read models by again providing a pair\n+    // where the first value is the repository's class name and the second value\n+    // are the options that should be given to the illuminate repository\n+    const IlluminateReadModels = [","path":"src/Infrastructure/AppServiceProvider.php","position":59,"original_position":59,"commit_id":"c1f2a18f0a8ac5850c3c110fbafe3ad26c6e72fb","original_commit_id":"c1f2a18f0a8ac5850c3c110fbafe3ad26c6e72fb","user":{"login":"Nitpick-CI","id":12626182,"avatar_url":"https://avatars.githubusercontent.com/u/12626182?v=3","gravatar_id":"","url":"https://api.github.com/users/Nitpick-CI","html_url":"https://github.com/Nitpick-CI","followers_url":"https://api.github.com/users/Nitpick-CI/followers","following_url":"https://api.github.com/users/Nitpick-CI/following{/other_user}","gists_url":"https://api.github.com/users/Nitpick-CI/gists{/gist_id}","starred_url":"https://api.github.com/users/Nitpick-CI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nitpick-CI/subscriptions","organizations_url":"https://api.github.com/users/Nitpick-CI/orgs","repos_url":"https://api.github.com/users/Nitpick-CI/repos","events_url":"https://api.github.com/users/Nitpick-CI/events{/privacy}","received_events_url":"https://api.github.com/users/Nitpick-CI/received_events","type":"User","site_admin":false},"body":"Class constants must be uppercase; expected ILLUMINATEREADMODELS but found IlluminateReadModels","created_at":"2016-11-18T15:17:02Z","updated_at":"2016-11-18T15:17:03Z","html_url":"https://github.com/ProfessorFrancken/ProfessorFrancken/pull/75#discussion_r88674908","pull_request_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/pulls/75","_links":{"self":{"href":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/pulls/comments/88674908"},"html":{"href":"https://github.com/ProfessorFrancken/ProfessorFrancken/pull/75#discussion_r88674908"},"pull_request":{"href":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/pulls/75","id":94379177,"html_url":"https://github.com/ProfessorFrancken/ProfessorFrancken/pull/75","diff_url":"https://github.com/ProfessorFrancken/ProfessorFrancken/pull/75.diff","patch_url":"https://github.com/ProfessorFrancken/ProfessorFrancken/pull/75.patch","issue_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/issues/75","number":75,"state":"open","locked":false,"title":"Feature/improve service providers","user":{"login":"MarkRedeman","id":1114829,"avatar_url":"https://avatars.githubusercontent.com/u/1114829?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkRedeman","html_url":"https://github.com/MarkRedeman","followers_url":"https://api.github.com/users/MarkRedeman/followers","following_url":"https://api.github.com/users/MarkRedeman/following{/other_user}","gists_url":"https://api.github.com/users/MarkRedeman/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkRedeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkRedeman/subscriptions","organizations_url":"https://api.github.com/users/MarkRedeman/orgs","repos_url":"https://api.github.com/users/MarkRedeman/repos","events_url":"https://api.github.com/users/MarkRedeman/events{/privacy}","received_events_url":"https://api.github.com/users/MarkRedeman/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-18T15:16:32Z","updated_at":"2016-11-18T15:17:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccc4bf5383bb68a39072f417c525902acb2873ef","assignee":{"login":"mark-boer","id":12862013,"avatar_url":"https://avatars.githubusercontent.com/u/12862013?v=3","gravatar_id":"","url":"https://api.github.com/users/mark-boer","html_url":"https://github.com/mark-boer","followers_url":"https://api.github.com/users/mark-boer/followers","following_url":"https://api.github.com/users/mark-boer/following{/other_user}","gists_url":"https://api.github.com/users/mark-boer/gists{/gist_id}","starred_url":"https://api.github.com/users/mark-boer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mark-boer/subscriptions","organizations_url":"https://api.github.com/users/mark-boer/orgs","repos_url":"https://api.github.com/users/mark-boer/repos","events_url":"https://api.github.com/users/mark-boer/events{/privacy}","received_events_url":"https://api.github.com/users/mark-boer/received_events","type":"User","site_admin":false},"assignees":[{"login":"mark-boer","id":12862013,"avatar_url":"https://avatars.githubusercontent.com/u/12862013?v=3","gravatar_id":"","url":"https://api.github.com/users/mark-boer","html_url":"https://github.com/mark-boer","followers_url":"https://api.github.com/users/mark-boer/followers","following_url":"https://api.github.com/users/mark-boer/following{/other_user}","gists_url":"https://api.github.com/users/mark-boer/gists{/gist_id}","starred_url":"https://api.github.com/users/mark-boer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mark-boer/subscriptions","organizations_url":"https://api.github.com/users/mark-boer/orgs","repos_url":"https://api.github.com/users/mark-boer/repos","events_url":"https://api.github.com/users/mark-boer/events{/privacy}","received_events_url":"https://api.github.com/users/mark-boer/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/pulls/75/commits","review_comments_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/pulls/75/comments","review_comment_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/issues/75/comments","statuses_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/statuses/c1f2a18f0a8ac5850c3c110fbafe3ad26c6e72fb","head":{"label":"ProfessorFrancken:feature/improve-service-providers","ref":"feature/improve-service-providers","sha":"c1f2a18f0a8ac5850c3c110fbafe3ad26c6e72fb","user":{"login":"ProfessorFrancken","id":19750712,"avatar_url":"https://avatars.githubusercontent.com/u/19750712?v=3","gravatar_id":"","url":"https://api.github.com/users/ProfessorFrancken","html_url":"https://github.com/ProfessorFrancken","followers_url":"https://api.github.com/users/ProfessorFrancken/followers","following_url":"https://api.github.com/users/ProfessorFrancken/following{/other_user}","gists_url":"https://api.github.com/users/ProfessorFrancken/gists{/gist_id}","starred_url":"https://api.github.com/users/ProfessorFrancken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProfessorFrancken/subscriptions","organizations_url":"https://api.github.com/users/ProfessorFrancken/orgs","repos_url":"https://api.github.com/users/ProfessorFrancken/repos","events_url":"https://api.github.com/users/ProfessorFrancken/events{/privacy}","received_events_url":"https://api.github.com/users/ProfessorFrancken/received_events","type":"Organization","site_admin":false},"repo":{"id":50722302,"name":"ProfessorFrancken","full_name":"ProfessorFrancken/ProfessorFrancken","owner":{"login":"ProfessorFrancken","id":19750712,"avatar_url":"https://avatars.githubusercontent.com/u/19750712?v=3","gravatar_id":"","url":"https://api.github.com/users/ProfessorFrancken","html_url":"https://github.com/ProfessorFrancken","followers_url":"https://api.github.com/users/ProfessorFrancken/followers","following_url":"https://api.github.com/users/ProfessorFrancken/following{/other_user}","gists_url":"https://api.github.com/users/ProfessorFrancken/gists{/gist_id}","starred_url":"https://api.github.com/users/ProfessorFrancken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProfessorFrancken/subscriptions","organizations_url":"https://api.github.com/users/ProfessorFrancken/orgs","repos_url":"https://api.github.com/users/ProfessorFrancken/repos","events_url":"https://api.github.com/users/ProfessorFrancken/events{/privacy}","received_events_url":"https://api.github.com/users/ProfessorFrancken/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ProfessorFrancken/ProfessorFrancken","description":null,"fork":false,"url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken","forks_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/forks","keys_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/teams","hooks_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/hooks","issue_events_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/issues/events{/number}","events_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/events","assignees_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/assignees{/user}","branches_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/branches{/branch}","tags_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/tags","blobs_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/statuses/{sha}","languages_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/languages","stargazers_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/stargazers","contributors_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/contributors","subscribers_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/subscribers","subscription_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/subscription","commits_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/contents/{+path}","compare_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/merges","archive_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/downloads","issues_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/issues{/number}","pulls_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/pulls{/number}","milestones_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/milestones{/number}","notifications_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/labels{/name}","releases_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/releases{/id}","deployments_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/deployments","created_at":"2016-01-30T11:38:48Z","updated_at":"2016-11-03T04:10:16Z","pushed_at":"2016-11-18T15:16:33Z","git_url":"git://github.com/ProfessorFrancken/ProfessorFrancken.git","ssh_url":"git@github.com:ProfessorFrancken/ProfessorFrancken.git","clone_url":"https://github.com/ProfessorFrancken/ProfessorFrancken.git","svn_url":"https://github.com/ProfessorFrancken/ProfessorFrancken","homepage":"http://beta.professorfrancken.nl","size":1043,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":3,"default_branch":"master"}},"base":{"label":"ProfessorFrancken:master","ref":"master","sha":"ebcb6b3729315771e03ad3dd8b4fd68ecdec515b","user":{"login":"ProfessorFrancken","id":19750712,"avatar_url":"https://avatars.githubusercontent.com/u/19750712?v=3","gravatar_id":"","url":"https://api.github.com/users/ProfessorFrancken","html_url":"https://github.com/ProfessorFrancken","followers_url":"https://api.github.com/users/ProfessorFrancken/followers","following_url":"https://api.github.com/users/ProfessorFrancken/following{/other_user}","gists_url":"https://api.github.com/users/ProfessorFrancken/gists{/gist_id}","starred_url":"https://api.github.com/users/ProfessorFrancken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProfessorFrancken/subscriptions","organizations_url":"https://api.github.com/users/ProfessorFrancken/orgs","repos_url":"https://api.github.com/users/ProfessorFrancken/repos","events_url":"https://api.github.com/users/ProfessorFrancken/events{/privacy}","received_events_url":"https://api.github.com/users/ProfessorFrancken/received_events","type":"Organization","site_admin":false},"repo":{"id":50722302,"name":"ProfessorFrancken","full_name":"ProfessorFrancken/ProfessorFrancken","owner":{"login":"ProfessorFrancken","id":19750712,"avatar_url":"https://avatars.githubusercontent.com/u/19750712?v=3","gravatar_id":"","url":"https://api.github.com/users/ProfessorFrancken","html_url":"https://github.com/ProfessorFrancken","followers_url":"https://api.github.com/users/ProfessorFrancken/followers","following_url":"https://api.github.com/users/ProfessorFrancken/following{/other_user}","gists_url":"https://api.github.com/users/ProfessorFrancken/gists{/gist_id}","starred_url":"https://api.github.com/users/ProfessorFrancken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProfessorFrancken/subscriptions","organizations_url":"https://api.github.com/users/ProfessorFrancken/orgs","repos_url":"https://api.github.com/users/ProfessorFrancken/repos","events_url":"https://api.github.com/users/ProfessorFrancken/events{/privacy}","received_events_url":"https://api.github.com/users/ProfessorFrancken/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ProfessorFrancken/ProfessorFrancken","description":null,"fork":false,"url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken","forks_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/forks","keys_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/teams","hooks_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/hooks","issue_events_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/issues/events{/number}","events_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/events","assignees_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/assignees{/user}","branches_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/branches{/branch}","tags_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/tags","blobs_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/statuses/{sha}","languages_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/languages","stargazers_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/stargazers","contributors_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/contributors","subscribers_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/subscribers","subscription_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/subscription","commits_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/contents/{+path}","compare_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/merges","archive_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/downloads","issues_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/issues{/number}","pulls_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/pulls{/number}","milestones_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/milestones{/number}","notifications_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/labels{/name}","releases_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/releases{/id}","deployments_url":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/deployments","created_at":"2016-01-30T11:38:48Z","updated_at":"2016-11-03T04:10:16Z","pushed_at":"2016-11-18T15:16:33Z","git_url":"git://github.com/ProfessorFrancken/ProfessorFrancken.git","ssh_url":"git@github.com:ProfessorFrancken/ProfessorFrancken.git","clone_url":"https://github.com/ProfessorFrancken/ProfessorFrancken.git","svn_url":"https://github.com/ProfessorFrancken/ProfessorFrancken","homepage":"http://beta.professorfrancken.nl","size":1043,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/pulls/75"},"html":{"href":"https://github.com/ProfessorFrancken/ProfessorFrancken/pull/75"},"issue":{"href":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/issues/75"},"comments":{"href":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/ProfessorFrancken/ProfessorFrancken/statuses/c1f2a18f0a8ac5850c3c110fbafe3ad26c6e72fb"}}}}
{"actor":{"display_login":"Nitpick-CI"}}