{"action":"created","comment":{"url":"https://api.github.com/repos/NumScale/boost.simd/pulls/comments/82847475","pull_request_review_id":3725817,"id":82847475,"diff_hunk":"@@ -61,13 +61,13 @@ STF_CASE_TPL( \"Check std abs behavior with floating\", STF_IEEE_TYPES )\n   STF_TYPE_IS(r_t, T);\n \n #ifndef BOOST_SIMD_NO_INVALIDS\n-  STF_EQUAL(bs::std_(abs)(bs::Inf<T>()),  bs::Inf<r_t>());\n-  STF_EQUAL(bs::std_(abs)(bs::Minf<T>()), bs::Inf<r_t>());\n-  STF_IEEE_EQUAL(bs::std_(abs)(bs::Nan<T>()),  bs::Nan<r_t>());","path":"test/function/scalar/abs.cpp","position":26,"original_position":26,"commit_id":"3e1d0cf776a48f3a50494c148860f1f80c4a276c","original_commit_id":"3e1d0cf776a48f3a50494c148860f1f80c4a276c","user":{"login":"jfalcou","id":285977,"avatar_url":"https://avatars.githubusercontent.com/u/285977?v=3","gravatar_id":"","url":"https://api.github.com/users/jfalcou","html_url":"https://github.com/jfalcou","followers_url":"https://api.github.com/users/jfalcou/followers","following_url":"https://api.github.com/users/jfalcou/following{/other_user}","gists_url":"https://api.github.com/users/jfalcou/gists{/gist_id}","starred_url":"https://api.github.com/users/jfalcou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfalcou/subscriptions","organizations_url":"https://api.github.com/users/jfalcou/orgs","repos_url":"https://api.github.com/users/jfalcou/repos","events_url":"https://api.github.com/users/jfalcou/events{/privacy}","received_events_url":"https://api.github.com/users/jfalcou/received_events","type":"User","site_admin":false},"body":"the arch argument is compelling enough. WIll merge","created_at":"2016-10-11T17:37:32Z","updated_at":"2016-10-11T17:37:32Z","html_url":"https://github.com/NumScale/boost.simd/pull/290#discussion_r82847475","pull_request_url":"https://api.github.com/repos/NumScale/boost.simd/pulls/290","_links":{"self":{"href":"https://api.github.com/repos/NumScale/boost.simd/pulls/comments/82847475"},"html":{"href":"https://github.com/NumScale/boost.simd/pull/290#discussion_r82847475"},"pull_request":{"href":"https://api.github.com/repos/NumScale/boost.simd/pulls/290"}}},"pull_request":{"url":"https://api.github.com/repos/NumScale/boost.simd/pulls/290","id":88594270,"html_url":"https://github.com/NumScale/boost.simd/pull/290","diff_url":"https://github.com/NumScale/boost.simd/pull/290.diff","patch_url":"https://github.com/NumScale/boost.simd/pull/290.patch","issue_url":"https://api.github.com/repos/NumScale/boost.simd/issues/290","number":290,"state":"open","locked":false,"title":"Equal in unit tests","user":{"login":"jtlap","id":382445,"avatar_url":"https://avatars.githubusercontent.com/u/382445?v=3","gravatar_id":"","url":"https://api.github.com/users/jtlap","html_url":"https://github.com/jtlap","followers_url":"https://api.github.com/users/jtlap/followers","following_url":"https://api.github.com/users/jtlap/following{/other_user}","gists_url":"https://api.github.com/users/jtlap/gists{/gist_id}","starred_url":"https://api.github.com/users/jtlap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtlap/subscriptions","organizations_url":"https://api.github.com/users/jtlap/orgs","repos_url":"https://api.github.com/users/jtlap/repos","events_url":"https://api.github.com/users/jtlap/events{/privacy}","received_events_url":"https://api.github.com/users/jtlap/received_events","type":"User","site_admin":false},"body":"whenever floating are used and result can differ due to IEEE computation  STF_EQUAL(...) is replaced by STF_ULP_EQUAL(...,0.5)","created_at":"2016-10-09T20:53:57Z","updated_at":"2016-10-11T17:37:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a21f5a317603f99ce9fbfb384efec4dceefa254f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NumScale/boost.simd/pulls/290/commits","review_comments_url":"https://api.github.com/repos/NumScale/boost.simd/pulls/290/comments","review_comment_url":"https://api.github.com/repos/NumScale/boost.simd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NumScale/boost.simd/issues/290/comments","statuses_url":"https://api.github.com/repos/NumScale/boost.simd/statuses/3e1d0cf776a48f3a50494c148860f1f80c4a276c","head":{"label":"NumScale:equal_in_unit_tests","ref":"equal_in_unit_tests","sha":"3e1d0cf776a48f3a50494c148860f1f80c4a276c","user":{"login":"NumScale","id":451929,"avatar_url":"https://avatars.githubusercontent.com/u/451929?v=3","gravatar_id":"","url":"https://api.github.com/users/NumScale","html_url":"https://github.com/NumScale","followers_url":"https://api.github.com/users/NumScale/followers","following_url":"https://api.github.com/users/NumScale/following{/other_user}","gists_url":"https://api.github.com/users/NumScale/gists{/gist_id}","starred_url":"https://api.github.com/users/NumScale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NumScale/subscriptions","organizations_url":"https://api.github.com/users/NumScale/orgs","repos_url":"https://api.github.com/users/NumScale/repos","events_url":"https://api.github.com/users/NumScale/events{/privacy}","received_events_url":"https://api.github.com/users/NumScale/received_events","type":"Organization","site_admin":false},"repo":{"id":31229726,"name":"boost.simd","full_name":"NumScale/boost.simd","owner":{"login":"NumScale","id":451929,"avatar_url":"https://avatars.githubusercontent.com/u/451929?v=3","gravatar_id":"","url":"https://api.github.com/users/NumScale","html_url":"https://github.com/NumScale","followers_url":"https://api.github.com/users/NumScale/followers","following_url":"https://api.github.com/users/NumScale/following{/other_user}","gists_url":"https://api.github.com/users/NumScale/gists{/gist_id}","starred_url":"https://api.github.com/users/NumScale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NumScale/subscriptions","organizations_url":"https://api.github.com/users/NumScale/orgs","repos_url":"https://api.github.com/users/NumScale/repos","events_url":"https://api.github.com/users/NumScale/events{/privacy}","received_events_url":"https://api.github.com/users/NumScale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NumScale/boost.simd","description":"Portable SIMD computation library - To be proposed as a Boost library","fork":false,"url":"https://api.github.com/repos/NumScale/boost.simd","forks_url":"https://api.github.com/repos/NumScale/boost.simd/forks","keys_url":"https://api.github.com/repos/NumScale/boost.simd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NumScale/boost.simd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NumScale/boost.simd/teams","hooks_url":"https://api.github.com/repos/NumScale/boost.simd/hooks","issue_events_url":"https://api.github.com/repos/NumScale/boost.simd/issues/events{/number}","events_url":"https://api.github.com/repos/NumScale/boost.simd/events","assignees_url":"https://api.github.com/repos/NumScale/boost.simd/assignees{/user}","branches_url":"https://api.github.com/repos/NumScale/boost.simd/branches{/branch}","tags_url":"https://api.github.com/repos/NumScale/boost.simd/tags","blobs_url":"https://api.github.com/repos/NumScale/boost.simd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NumScale/boost.simd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NumScale/boost.simd/git/refs{/sha}","trees_url":"https://api.github.com/repos/NumScale/boost.simd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NumScale/boost.simd/statuses/{sha}","languages_url":"https://api.github.com/repos/NumScale/boost.simd/languages","stargazers_url":"https://api.github.com/repos/NumScale/boost.simd/stargazers","contributors_url":"https://api.github.com/repos/NumScale/boost.simd/contributors","subscribers_url":"https://api.github.com/repos/NumScale/boost.simd/subscribers","subscription_url":"https://api.github.com/repos/NumScale/boost.simd/subscription","commits_url":"https://api.github.com/repos/NumScale/boost.simd/commits{/sha}","git_commits_url":"https://api.github.com/repos/NumScale/boost.simd/git/commits{/sha}","comments_url":"https://api.github.com/repos/NumScale/boost.simd/comments{/number}","issue_comment_url":"https://api.github.com/repos/NumScale/boost.simd/issues/comments{/number}","contents_url":"https://api.github.com/repos/NumScale/boost.simd/contents/{+path}","compare_url":"https://api.github.com/repos/NumScale/boost.simd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NumScale/boost.simd/merges","archive_url":"https://api.github.com/repos/NumScale/boost.simd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NumScale/boost.simd/downloads","issues_url":"https://api.github.com/repos/NumScale/boost.simd/issues{/number}","pulls_url":"https://api.github.com/repos/NumScale/boost.simd/pulls{/number}","milestones_url":"https://api.github.com/repos/NumScale/boost.simd/milestones{/number}","notifications_url":"https://api.github.com/repos/NumScale/boost.simd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NumScale/boost.simd/labels{/name}","releases_url":"https://api.github.com/repos/NumScale/boost.simd/releases{/id}","deployments_url":"https://api.github.com/repos/NumScale/boost.simd/deployments","created_at":"2015-02-23T21:04:49Z","updated_at":"2016-10-08T11:22:30Z","pushed_at":"2016-10-11T17:36:29Z","git_url":"git://github.com/NumScale/boost.simd.git","ssh_url":"git@github.com:NumScale/boost.simd.git","clone_url":"https://github.com/NumScale/boost.simd.git","svn_url":"https://github.com/NumScale/boost.simd","homepage":"","size":20477,"stargazers_count":66,"watchers_count":66,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":17,"forks":9,"open_issues":17,"watchers":66,"default_branch":"develop"}},"base":{"label":"NumScale:develop","ref":"develop","sha":"f3918e0e630b97ce1ea446a771f76b3a90f2c961","user":{"login":"NumScale","id":451929,"avatar_url":"https://avatars.githubusercontent.com/u/451929?v=3","gravatar_id":"","url":"https://api.github.com/users/NumScale","html_url":"https://github.com/NumScale","followers_url":"https://api.github.com/users/NumScale/followers","following_url":"https://api.github.com/users/NumScale/following{/other_user}","gists_url":"https://api.github.com/users/NumScale/gists{/gist_id}","starred_url":"https://api.github.com/users/NumScale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NumScale/subscriptions","organizations_url":"https://api.github.com/users/NumScale/orgs","repos_url":"https://api.github.com/users/NumScale/repos","events_url":"https://api.github.com/users/NumScale/events{/privacy}","received_events_url":"https://api.github.com/users/NumScale/received_events","type":"Organization","site_admin":false},"repo":{"id":31229726,"name":"boost.simd","full_name":"NumScale/boost.simd","owner":{"login":"NumScale","id":451929,"avatar_url":"https://avatars.githubusercontent.com/u/451929?v=3","gravatar_id":"","url":"https://api.github.com/users/NumScale","html_url":"https://github.com/NumScale","followers_url":"https://api.github.com/users/NumScale/followers","following_url":"https://api.github.com/users/NumScale/following{/other_user}","gists_url":"https://api.github.com/users/NumScale/gists{/gist_id}","starred_url":"https://api.github.com/users/NumScale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NumScale/subscriptions","organizations_url":"https://api.github.com/users/NumScale/orgs","repos_url":"https://api.github.com/users/NumScale/repos","events_url":"https://api.github.com/users/NumScale/events{/privacy}","received_events_url":"https://api.github.com/users/NumScale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NumScale/boost.simd","description":"Portable SIMD computation library - To be proposed as a Boost library","fork":false,"url":"https://api.github.com/repos/NumScale/boost.simd","forks_url":"https://api.github.com/repos/NumScale/boost.simd/forks","keys_url":"https://api.github.com/repos/NumScale/boost.simd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NumScale/boost.simd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NumScale/boost.simd/teams","hooks_url":"https://api.github.com/repos/NumScale/boost.simd/hooks","issue_events_url":"https://api.github.com/repos/NumScale/boost.simd/issues/events{/number}","events_url":"https://api.github.com/repos/NumScale/boost.simd/events","assignees_url":"https://api.github.com/repos/NumScale/boost.simd/assignees{/user}","branches_url":"https://api.github.com/repos/NumScale/boost.simd/branches{/branch}","tags_url":"https://api.github.com/repos/NumScale/boost.simd/tags","blobs_url":"https://api.github.com/repos/NumScale/boost.simd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NumScale/boost.simd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NumScale/boost.simd/git/refs{/sha}","trees_url":"https://api.github.com/repos/NumScale/boost.simd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NumScale/boost.simd/statuses/{sha}","languages_url":"https://api.github.com/repos/NumScale/boost.simd/languages","stargazers_url":"https://api.github.com/repos/NumScale/boost.simd/stargazers","contributors_url":"https://api.github.com/repos/NumScale/boost.simd/contributors","subscribers_url":"https://api.github.com/repos/NumScale/boost.simd/subscribers","subscription_url":"https://api.github.com/repos/NumScale/boost.simd/subscription","commits_url":"https://api.github.com/repos/NumScale/boost.simd/commits{/sha}","git_commits_url":"https://api.github.com/repos/NumScale/boost.simd/git/commits{/sha}","comments_url":"https://api.github.com/repos/NumScale/boost.simd/comments{/number}","issue_comment_url":"https://api.github.com/repos/NumScale/boost.simd/issues/comments{/number}","contents_url":"https://api.github.com/repos/NumScale/boost.simd/contents/{+path}","compare_url":"https://api.github.com/repos/NumScale/boost.simd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NumScale/boost.simd/merges","archive_url":"https://api.github.com/repos/NumScale/boost.simd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NumScale/boost.simd/downloads","issues_url":"https://api.github.com/repos/NumScale/boost.simd/issues{/number}","pulls_url":"https://api.github.com/repos/NumScale/boost.simd/pulls{/number}","milestones_url":"https://api.github.com/repos/NumScale/boost.simd/milestones{/number}","notifications_url":"https://api.github.com/repos/NumScale/boost.simd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NumScale/boost.simd/labels{/name}","releases_url":"https://api.github.com/repos/NumScale/boost.simd/releases{/id}","deployments_url":"https://api.github.com/repos/NumScale/boost.simd/deployments","created_at":"2015-02-23T21:04:49Z","updated_at":"2016-10-08T11:22:30Z","pushed_at":"2016-10-11T17:36:29Z","git_url":"git://github.com/NumScale/boost.simd.git","ssh_url":"git@github.com:NumScale/boost.simd.git","clone_url":"https://github.com/NumScale/boost.simd.git","svn_url":"https://github.com/NumScale/boost.simd","homepage":"","size":20477,"stargazers_count":66,"watchers_count":66,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":17,"forks":9,"open_issues":17,"watchers":66,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NumScale/boost.simd/pulls/290"},"html":{"href":"https://github.com/NumScale/boost.simd/pull/290"},"issue":{"href":"https://api.github.com/repos/NumScale/boost.simd/issues/290"},"comments":{"href":"https://api.github.com/repos/NumScale/boost.simd/issues/290/comments"},"review_comments":{"href":"https://api.github.com/repos/NumScale/boost.simd/pulls/290/comments"},"review_comment":{"href":"https://api.github.com/repos/NumScale/boost.simd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NumScale/boost.simd/pulls/290/commits"},"statuses":{"href":"https://api.github.com/repos/NumScale/boost.simd/statuses/3e1d0cf776a48f3a50494c148860f1f80c4a276c"}}}}
{"actor":{"display_login":"jfalcou"}}