{"action":"created","comment":{"url":"https://api.github.com/repos/appc/spec/pulls/comments/84271181","pull_request_review_id":5058329,"id":84271181,"diff_hunk":"@@ -243,6 +243,8 @@ JSON Schema for the Image Manifest (app image manifest, ACI manifest), conformin\n         * **port** (integer, required) port number that will be used; see also **count**. Must be >=1 and <=65535.\n         * **count** (integer, optional, defaults to 1 if unset) specifies a range of ports, starting with \"port\" and ending with \"port\" + \"count\" - 1. Must be >=1.\n         * **socketActivated** (boolean, optional, defaults to \"false\" if unsupplied) if set to true, the application expects to be [socket activated](http://www.freedesktop.org/software/systemd/man/sd_listen_fds.html) on these ports. To perform socket activation, the ACE MUST pass file descriptors using the [socket activation protocol](http://www.freedesktop.org/software/systemd/man/sd_listen_fds.html) that are listening on these ports when starting this app. If multiple apps in the same pod are using socket activation then the ACE must match the sockets to the correct apps using getsockopt() and getsockname().\n+\t* **userAnnotations** (string map, optional) Arbitrary metadata for end-user use. Must not affect runtime behavior.","path":"spec/aci.md","position":4,"original_position":4,"commit_id":"0d9401e9d2d9372f15c33370de91f436515c041d","original_commit_id":"0d9401e9d2d9372f15c33370de91f436515c041d","user":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"body":"Please update these to:\r\n\r\n(object, optional) map of arbitrary key-value metadata for end-user use. Values must be strings.","created_at":"2016-10-20T12:31:51Z","updated_at":"2016-10-20T12:31:51Z","html_url":"https://github.com/appc/spec/pull/667#discussion_r84271181","pull_request_url":"https://api.github.com/repos/appc/spec/pulls/667","_links":{"self":{"href":"https://api.github.com/repos/appc/spec/pulls/comments/84271181"},"html":{"href":"https://github.com/appc/spec/pull/667#discussion_r84271181"},"pull_request":{"href":"https://api.github.com/repos/appc/spec/pulls/667"}}},"pull_request":{"url":"https://api.github.com/repos/appc/spec/pulls/667","id":90188593,"html_url":"https://github.com/appc/spec/pull/667","diff_url":"https://github.com/appc/spec/pull/667.diff","patch_url":"https://github.com/appc/spec/pull/667.patch","issue_url":"https://api.github.com/repos/appc/spec/issues/667","number":667,"state":"open","locked":false,"title":"spec: update spec to include CRI changes","user":{"login":"squeed","id":551378,"avatar_url":"https://avatars.githubusercontent.com/u/551378?v=3","gravatar_id":"","url":"https://api.github.com/users/squeed","html_url":"https://github.com/squeed","followers_url":"https://api.github.com/users/squeed/followers","following_url":"https://api.github.com/users/squeed/following{/other_user}","gists_url":"https://api.github.com/users/squeed/gists{/gist_id}","starred_url":"https://api.github.com/users/squeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squeed/subscriptions","organizations_url":"https://api.github.com/users/squeed/orgs","repos_url":"https://api.github.com/users/squeed/repos","events_url":"https://api.github.com/users/squeed/events{/privacy}","received_events_url":"https://api.github.com/users/squeed/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-20T12:17:04Z","updated_at":"2016-10-20T12:42:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4cb24a1917dff6d9f9bd1a08e360f700fbbaac1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/appc/spec/pulls/667/commits","review_comments_url":"https://api.github.com/repos/appc/spec/pulls/667/comments","review_comment_url":"https://api.github.com/repos/appc/spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appc/spec/issues/667/comments","statuses_url":"https://api.github.com/repos/appc/spec/statuses/0d9401e9d2d9372f15c33370de91f436515c041d","head":{"label":"squeed:cri-doc-update","ref":"cri-doc-update","sha":"0d9401e9d2d9372f15c33370de91f436515c041d","user":{"login":"squeed","id":551378,"avatar_url":"https://avatars.githubusercontent.com/u/551378?v=3","gravatar_id":"","url":"https://api.github.com/users/squeed","html_url":"https://github.com/squeed","followers_url":"https://api.github.com/users/squeed/followers","following_url":"https://api.github.com/users/squeed/following{/other_user}","gists_url":"https://api.github.com/users/squeed/gists{/gist_id}","starred_url":"https://api.github.com/users/squeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squeed/subscriptions","organizations_url":"https://api.github.com/users/squeed/orgs","repos_url":"https://api.github.com/users/squeed/repos","events_url":"https://api.github.com/users/squeed/events{/privacy}","received_events_url":"https://api.github.com/users/squeed/received_events","type":"User","site_admin":false},"repo":{"id":68377419,"name":"spec","full_name":"squeed/spec","owner":{"login":"squeed","id":551378,"avatar_url":"https://avatars.githubusercontent.com/u/551378?v=3","gravatar_id":"","url":"https://api.github.com/users/squeed","html_url":"https://github.com/squeed","followers_url":"https://api.github.com/users/squeed/followers","following_url":"https://api.github.com/users/squeed/following{/other_user}","gists_url":"https://api.github.com/users/squeed/gists{/gist_id}","starred_url":"https://api.github.com/users/squeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squeed/subscriptions","organizations_url":"https://api.github.com/users/squeed/orgs","repos_url":"https://api.github.com/users/squeed/repos","events_url":"https://api.github.com/users/squeed/events{/privacy}","received_events_url":"https://api.github.com/users/squeed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/squeed/spec","description":"App Container Specification and Tooling","fork":true,"url":"https://api.github.com/repos/squeed/spec","forks_url":"https://api.github.com/repos/squeed/spec/forks","keys_url":"https://api.github.com/repos/squeed/spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squeed/spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squeed/spec/teams","hooks_url":"https://api.github.com/repos/squeed/spec/hooks","issue_events_url":"https://api.github.com/repos/squeed/spec/issues/events{/number}","events_url":"https://api.github.com/repos/squeed/spec/events","assignees_url":"https://api.github.com/repos/squeed/spec/assignees{/user}","branches_url":"https://api.github.com/repos/squeed/spec/branches{/branch}","tags_url":"https://api.github.com/repos/squeed/spec/tags","blobs_url":"https://api.github.com/repos/squeed/spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squeed/spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squeed/spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/squeed/spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squeed/spec/statuses/{sha}","languages_url":"https://api.github.com/repos/squeed/spec/languages","stargazers_url":"https://api.github.com/repos/squeed/spec/stargazers","contributors_url":"https://api.github.com/repos/squeed/spec/contributors","subscribers_url":"https://api.github.com/repos/squeed/spec/subscribers","subscription_url":"https://api.github.com/repos/squeed/spec/subscription","commits_url":"https://api.github.com/repos/squeed/spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/squeed/spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/squeed/spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/squeed/spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/squeed/spec/contents/{+path}","compare_url":"https://api.github.com/repos/squeed/spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squeed/spec/merges","archive_url":"https://api.github.com/repos/squeed/spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squeed/spec/downloads","issues_url":"https://api.github.com/repos/squeed/spec/issues{/number}","pulls_url":"https://api.github.com/repos/squeed/spec/pulls{/number}","milestones_url":"https://api.github.com/repos/squeed/spec/milestones{/number}","notifications_url":"https://api.github.com/repos/squeed/spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squeed/spec/labels{/name}","releases_url":"https://api.github.com/repos/squeed/spec/releases{/id}","deployments_url":"https://api.github.com/repos/squeed/spec/deployments","created_at":"2016-09-16T12:21:50Z","updated_at":"2016-09-16T12:21:53Z","pushed_at":"2016-10-20T12:16:25Z","git_url":"git://github.com/squeed/spec.git","ssh_url":"git@github.com:squeed/spec.git","clone_url":"https://github.com/squeed/spec.git","svn_url":"https://github.com/squeed/spec","homepage":null,"size":1705,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appc:master","ref":"master","sha":"f15767f24ab5751fdf5a6e1f821d79e05a02d43f","user":{"login":"appc","id":10080092,"avatar_url":"https://avatars.githubusercontent.com/u/10080092?v=3","gravatar_id":"","url":"https://api.github.com/users/appc","html_url":"https://github.com/appc","followers_url":"https://api.github.com/users/appc/followers","following_url":"https://api.github.com/users/appc/following{/other_user}","gists_url":"https://api.github.com/users/appc/gists{/gist_id}","starred_url":"https://api.github.com/users/appc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appc/subscriptions","organizations_url":"https://api.github.com/users/appc/orgs","repos_url":"https://api.github.com/users/appc/repos","events_url":"https://api.github.com/users/appc/events{/privacy}","received_events_url":"https://api.github.com/users/appc/received_events","type":"Organization","site_admin":false},"repo":{"id":27782596,"name":"spec","full_name":"appc/spec","owner":{"login":"appc","id":10080092,"avatar_url":"https://avatars.githubusercontent.com/u/10080092?v=3","gravatar_id":"","url":"https://api.github.com/users/appc","html_url":"https://github.com/appc","followers_url":"https://api.github.com/users/appc/followers","following_url":"https://api.github.com/users/appc/following{/other_user}","gists_url":"https://api.github.com/users/appc/gists{/gist_id}","starred_url":"https://api.github.com/users/appc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appc/subscriptions","organizations_url":"https://api.github.com/users/appc/orgs","repos_url":"https://api.github.com/users/appc/repos","events_url":"https://api.github.com/users/appc/events{/privacy}","received_events_url":"https://api.github.com/users/appc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appc/spec","description":"App Container Specification and Tooling","fork":false,"url":"https://api.github.com/repos/appc/spec","forks_url":"https://api.github.com/repos/appc/spec/forks","keys_url":"https://api.github.com/repos/appc/spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appc/spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appc/spec/teams","hooks_url":"https://api.github.com/repos/appc/spec/hooks","issue_events_url":"https://api.github.com/repos/appc/spec/issues/events{/number}","events_url":"https://api.github.com/repos/appc/spec/events","assignees_url":"https://api.github.com/repos/appc/spec/assignees{/user}","branches_url":"https://api.github.com/repos/appc/spec/branches{/branch}","tags_url":"https://api.github.com/repos/appc/spec/tags","blobs_url":"https://api.github.com/repos/appc/spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appc/spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appc/spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/appc/spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appc/spec/statuses/{sha}","languages_url":"https://api.github.com/repos/appc/spec/languages","stargazers_url":"https://api.github.com/repos/appc/spec/stargazers","contributors_url":"https://api.github.com/repos/appc/spec/contributors","subscribers_url":"https://api.github.com/repos/appc/spec/subscribers","subscription_url":"https://api.github.com/repos/appc/spec/subscription","commits_url":"https://api.github.com/repos/appc/spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/appc/spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/appc/spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/appc/spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/appc/spec/contents/{+path}","compare_url":"https://api.github.com/repos/appc/spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appc/spec/merges","archive_url":"https://api.github.com/repos/appc/spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appc/spec/downloads","issues_url":"https://api.github.com/repos/appc/spec/issues{/number}","pulls_url":"https://api.github.com/repos/appc/spec/pulls{/number}","milestones_url":"https://api.github.com/repos/appc/spec/milestones{/number}","notifications_url":"https://api.github.com/repos/appc/spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appc/spec/labels{/name}","releases_url":"https://api.github.com/repos/appc/spec/releases{/id}","deployments_url":"https://api.github.com/repos/appc/spec/deployments","created_at":"2014-12-09T19:17:54Z","updated_at":"2016-10-20T12:35:24Z","pushed_at":"2016-10-20T12:17:04Z","git_url":"git://github.com/appc/spec.git","ssh_url":"git@github.com:appc/spec.git","clone_url":"https://github.com/appc/spec.git","svn_url":"https://github.com/appc/spec","homepage":null,"size":2099,"stargazers_count":1013,"watchers_count":1013,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":142,"mirror_url":null,"open_issues_count":142,"forks":142,"open_issues":142,"watchers":1013,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appc/spec/pulls/667"},"html":{"href":"https://github.com/appc/spec/pull/667"},"issue":{"href":"https://api.github.com/repos/appc/spec/issues/667"},"comments":{"href":"https://api.github.com/repos/appc/spec/issues/667/comments"},"review_comments":{"href":"https://api.github.com/repos/appc/spec/pulls/667/comments"},"review_comment":{"href":"https://api.github.com/repos/appc/spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appc/spec/pulls/667/commits"},"statuses":{"href":"https://api.github.com/repos/appc/spec/statuses/0d9401e9d2d9372f15c33370de91f436515c041d"}}}}
{"actor":{"display_login":"jonboulle"}}