{"action":"created","comment":{"url":"https://api.github.com/repos/scality/S3/pulls/comments/77877962","id":77877962,"diff_hunk":"@@ -1,35 +1,21 @@\n import api from '../api/api';\n import routesUtils from './routesUtils';\n-\n-function _pushMetrics(err, log, utapi, action, resource, contentLength) {\n-    if (!err) {\n-        const timestamp = Date.now();\n-        const reqUid = log.getSerializedUids();\n-        if (action === 'bucketDelete') {\n-            utapi.pushMetricDeleteBucket(reqUid, resource, timestamp);\n-        } else if (action === 'objectDelete') {\n-            utapi.pushMetricDeleteObject(reqUid, resource, timestamp,\n-                contentLength);\n-        } else if (action === 'multipartDelete') {\n-            utapi.pushMetricAbortMultipartUpload(reqUid, resource, timestamp);\n-        }\n-    }\n-}\n+import pushMetrics from '../utilities/pushMetrics';","path":"lib/routes/routeDELETE.js","position":18,"original_position":18,"commit_id":"817c20fb35febda0f9befaa1b68eaf63a8cf6dd0","original_commit_id":"817c20fb35febda0f9befaa1b68eaf63a8cf6dd0","user":{"login":"LaurenSpiegel","id":7368115,"avatar_url":"https://avatars.githubusercontent.com/u/7368115?v=3","gravatar_id":"","url":"https://api.github.com/users/LaurenSpiegel","html_url":"https://github.com/LaurenSpiegel","followers_url":"https://api.github.com/users/LaurenSpiegel/followers","following_url":"https://api.github.com/users/LaurenSpiegel/following{/other_user}","gists_url":"https://api.github.com/users/LaurenSpiegel/gists{/gist_id}","starred_url":"https://api.github.com/users/LaurenSpiegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaurenSpiegel/subscriptions","organizations_url":"https://api.github.com/users/LaurenSpiegel/orgs","repos_url":"https://api.github.com/users/LaurenSpiegel/repos","events_url":"https://api.github.com/users/LaurenSpiegel/events{/privacy}","received_events_url":"https://api.github.com/users/LaurenSpiegel/received_events","type":"User","site_admin":false},"body":"this should be in the new utapi directory once the auth/config pr is merged.","created_at":"2016-09-07T18:26:12Z","updated_at":"2016-09-07T18:26:12Z","html_url":"https://github.com/scality/S3/pull/196#discussion_r77877962","pull_request_url":"https://api.github.com/repos/scality/S3/pulls/196","_links":{"self":{"href":"https://api.github.com/repos/scality/S3/pulls/comments/77877962"},"html":{"href":"https://github.com/scality/S3/pull/196#discussion_r77877962"},"pull_request":{"href":"https://api.github.com/repos/scality/S3/pulls/196"}}},"pull_request":{"url":"https://api.github.com/repos/scality/S3/pulls/196","id":84209102,"html_url":"https://github.com/scality/S3/pull/196","diff_url":"https://github.com/scality/S3/pull/196.diff","patch_url":"https://github.com/scality/S3/pull/196.patch","issue_url":"https://api.github.com/repos/scality/S3/issues/196","number":196,"state":"open","locked":false,"title":"Cleanup/remove utapi timestamp","user":{"login":"rahulreddy","id":914178,"avatar_url":"https://avatars.githubusercontent.com/u/914178?v=3","gravatar_id":"","url":"https://api.github.com/users/rahulreddy","html_url":"https://github.com/rahulreddy","followers_url":"https://api.github.com/users/rahulreddy/followers","following_url":"https://api.github.com/users/rahulreddy/following{/other_user}","gists_url":"https://api.github.com/users/rahulreddy/gists{/gist_id}","starred_url":"https://api.github.com/users/rahulreddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rahulreddy/subscriptions","organizations_url":"https://api.github.com/users/rahulreddy/orgs","repos_url":"https://api.github.com/users/rahulreddy/repos","events_url":"https://api.github.com/users/rahulreddy/events{/privacy}","received_events_url":"https://api.github.com/users/rahulreddy/received_events","type":"User","site_admin":false},"body":"Removes timestamp generation for push metrics as it will be managed by the UtapiClient itself. Additionally, the code for push metrics has been cleanup as a utility instead.\r\n","created_at":"2016-09-06T22:41:47Z","updated_at":"2016-09-07T18:26:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e89cc45eda9f720d069731dc85a7b649f8131c87","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scality/S3/pulls/196/commits","review_comments_url":"https://api.github.com/repos/scality/S3/pulls/196/comments","review_comment_url":"https://api.github.com/repos/scality/S3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scality/S3/issues/196/comments","statuses_url":"https://api.github.com/repos/scality/S3/statuses/817c20fb35febda0f9befaa1b68eaf63a8cf6dd0","head":{"label":"scality:cleanup/removeUtapiTimestamp","ref":"cleanup/removeUtapiTimestamp","sha":"817c20fb35febda0f9befaa1b68eaf63a8cf6dd0","user":{"login":"scality","id":383812,"avatar_url":"https://avatars.githubusercontent.com/u/383812?v=3","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"repo":{"id":60165924,"name":"S3","full_name":"scality/S3","owner":{"login":"scality","id":383812,"avatar_url":"https://avatars.githubusercontent.com/u/383812?v=3","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scality/S3","description":"An open-source Node.js implementation of a server handling the S3 protocol","fork":false,"url":"https://api.github.com/repos/scality/S3","forks_url":"https://api.github.com/repos/scality/S3/forks","keys_url":"https://api.github.com/repos/scality/S3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scality/S3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scality/S3/teams","hooks_url":"https://api.github.com/repos/scality/S3/hooks","issue_events_url":"https://api.github.com/repos/scality/S3/issues/events{/number}","events_url":"https://api.github.com/repos/scality/S3/events","assignees_url":"https://api.github.com/repos/scality/S3/assignees{/user}","branches_url":"https://api.github.com/repos/scality/S3/branches{/branch}","tags_url":"https://api.github.com/repos/scality/S3/tags","blobs_url":"https://api.github.com/repos/scality/S3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scality/S3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scality/S3/git/refs{/sha}","trees_url":"https://api.github.com/repos/scality/S3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scality/S3/statuses/{sha}","languages_url":"https://api.github.com/repos/scality/S3/languages","stargazers_url":"https://api.github.com/repos/scality/S3/stargazers","contributors_url":"https://api.github.com/repos/scality/S3/contributors","subscribers_url":"https://api.github.com/repos/scality/S3/subscribers","subscription_url":"https://api.github.com/repos/scality/S3/subscription","commits_url":"https://api.github.com/repos/scality/S3/commits{/sha}","git_commits_url":"https://api.github.com/repos/scality/S3/git/commits{/sha}","comments_url":"https://api.github.com/repos/scality/S3/comments{/number}","issue_comment_url":"https://api.github.com/repos/scality/S3/issues/comments{/number}","contents_url":"https://api.github.com/repos/scality/S3/contents/{+path}","compare_url":"https://api.github.com/repos/scality/S3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scality/S3/merges","archive_url":"https://api.github.com/repos/scality/S3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scality/S3/downloads","issues_url":"https://api.github.com/repos/scality/S3/issues{/number}","pulls_url":"https://api.github.com/repos/scality/S3/pulls{/number}","milestones_url":"https://api.github.com/repos/scality/S3/milestones{/number}","notifications_url":"https://api.github.com/repos/scality/S3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scality/S3/labels{/name}","releases_url":"https://api.github.com/repos/scality/S3/releases{/id}","deployments_url":"https://api.github.com/repos/scality/S3/deployments","created_at":"2016-06-01T09:58:56Z","updated_at":"2016-09-05T14:41:17Z","pushed_at":"2016-09-07T17:48:12Z","git_url":"git://github.com/scality/S3.git","ssh_url":"git@github.com:scality/S3.git","clone_url":"https://github.com/scality/S3.git","svn_url":"https://github.com/scality/S3","homepage":"http://s3.scality.com","size":3325,"stargazers_count":193,"watchers_count":193,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":25,"forks":17,"open_issues":25,"watchers":193,"default_branch":"master"}},"base":{"label":"scality:master","ref":"master","sha":"62e3164ec58e0169822569b6fae22f8ffda13fa1","user":{"login":"scality","id":383812,"avatar_url":"https://avatars.githubusercontent.com/u/383812?v=3","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"repo":{"id":60165924,"name":"S3","full_name":"scality/S3","owner":{"login":"scality","id":383812,"avatar_url":"https://avatars.githubusercontent.com/u/383812?v=3","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scality/S3","description":"An open-source Node.js implementation of a server handling the S3 protocol","fork":false,"url":"https://api.github.com/repos/scality/S3","forks_url":"https://api.github.com/repos/scality/S3/forks","keys_url":"https://api.github.com/repos/scality/S3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scality/S3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scality/S3/teams","hooks_url":"https://api.github.com/repos/scality/S3/hooks","issue_events_url":"https://api.github.com/repos/scality/S3/issues/events{/number}","events_url":"https://api.github.com/repos/scality/S3/events","assignees_url":"https://api.github.com/repos/scality/S3/assignees{/user}","branches_url":"https://api.github.com/repos/scality/S3/branches{/branch}","tags_url":"https://api.github.com/repos/scality/S3/tags","blobs_url":"https://api.github.com/repos/scality/S3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scality/S3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scality/S3/git/refs{/sha}","trees_url":"https://api.github.com/repos/scality/S3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scality/S3/statuses/{sha}","languages_url":"https://api.github.com/repos/scality/S3/languages","stargazers_url":"https://api.github.com/repos/scality/S3/stargazers","contributors_url":"https://api.github.com/repos/scality/S3/contributors","subscribers_url":"https://api.github.com/repos/scality/S3/subscribers","subscription_url":"https://api.github.com/repos/scality/S3/subscription","commits_url":"https://api.github.com/repos/scality/S3/commits{/sha}","git_commits_url":"https://api.github.com/repos/scality/S3/git/commits{/sha}","comments_url":"https://api.github.com/repos/scality/S3/comments{/number}","issue_comment_url":"https://api.github.com/repos/scality/S3/issues/comments{/number}","contents_url":"https://api.github.com/repos/scality/S3/contents/{+path}","compare_url":"https://api.github.com/repos/scality/S3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scality/S3/merges","archive_url":"https://api.github.com/repos/scality/S3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scality/S3/downloads","issues_url":"https://api.github.com/repos/scality/S3/issues{/number}","pulls_url":"https://api.github.com/repos/scality/S3/pulls{/number}","milestones_url":"https://api.github.com/repos/scality/S3/milestones{/number}","notifications_url":"https://api.github.com/repos/scality/S3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scality/S3/labels{/name}","releases_url":"https://api.github.com/repos/scality/S3/releases{/id}","deployments_url":"https://api.github.com/repos/scality/S3/deployments","created_at":"2016-06-01T09:58:56Z","updated_at":"2016-09-05T14:41:17Z","pushed_at":"2016-09-07T17:48:12Z","git_url":"git://github.com/scality/S3.git","ssh_url":"git@github.com:scality/S3.git","clone_url":"https://github.com/scality/S3.git","svn_url":"https://github.com/scality/S3","homepage":"http://s3.scality.com","size":3325,"stargazers_count":193,"watchers_count":193,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":25,"forks":17,"open_issues":25,"watchers":193,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scality/S3/pulls/196"},"html":{"href":"https://github.com/scality/S3/pull/196"},"issue":{"href":"https://api.github.com/repos/scality/S3/issues/196"},"comments":{"href":"https://api.github.com/repos/scality/S3/issues/196/comments"},"review_comments":{"href":"https://api.github.com/repos/scality/S3/pulls/196/comments"},"review_comment":{"href":"https://api.github.com/repos/scality/S3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scality/S3/pulls/196/commits"},"statuses":{"href":"https://api.github.com/repos/scality/S3/statuses/817c20fb35febda0f9befaa1b68eaf63a8cf6dd0"}}}}
{"actor":{"display_login":"LaurenSpiegel"}}