{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/13185","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/13185/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/13185/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/13185/events","html_url":"https://github.com/ManageIQ/manageiq/pull/13185","id":195655958,"number":13185,"title":"[WIP] VMware DTO Refresh","user":{"login":"agrare","id":12851112,"avatar_url":"https://avatars.githubusercontent.com/u/12851112?v=3","gravatar_id":"","url":"https://api.github.com/users/agrare","html_url":"https://github.com/agrare","followers_url":"https://api.github.com/users/agrare/followers","following_url":"https://api.github.com/users/agrare/following{/other_user}","gists_url":"https://api.github.com/users/agrare/gists{/gist_id}","starred_url":"https://api.github.com/users/agrare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrare/subscriptions","organizations_url":"https://api.github.com/users/agrare/orgs","repos_url":"https://api.github.com/users/agrare/repos","events_url":"https://api.github.com/users/agrare/events{/privacy}","received_events_url":"https://api.github.com/users/agrare/received_events","type":"User","site_admin":false},"labels":[{"id":211525939,"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/providers/vmware/infra","name":"providers/vmware/infra","color":"5319e7","default":false},{"id":110594929,"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/refactoring","name":"refactoring","color":"fbca04","default":false},{"id":176168677,"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/wip","name":"wip","color":"eeeeee","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-14T21:51:38Z","updated_at":"2016-12-19T13:37:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/13185","html_url":"https://github.com/ManageIQ/manageiq/pull/13185","diff_url":"https://github.com/ManageIQ/manageiq/pull/13185.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/13185.patch"},"body":"This moves the VMware InfraManager over to using DTO refresh"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/267965530","html_url":"https://github.com/ManageIQ/manageiq/pull/13185#issuecomment-267965530","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/13185","id":267965530,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-12-19T13:37:27Z","updated_at":"2016-12-19T13:37:27Z","body":"<rubocop />Checked commits https://github.com/agrare/manageiq/compare/48323b43946ed218c64a7cbd0a2fe3ceb46a3300~...4ef68382ce46df1cb3cebd58ca2c392969a1e3ca with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n8 files checked, 25 offenses detected\n\n**app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/cluster.rb**\n- [ ] :warning: - [Line 17](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/cluster.rb#L17), Col 11 - [Lint/UselessAssignment](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Lint/UselessAssignment) - Useless assignment to variable - `new_result`.\n- [ ] :grey_exclamation: - [Line 5](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/cluster.rb#L5), Col 9 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for parse_cluster is too high. [29.48/20]\n\n**app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/host.rb**\n- [ ] :warning: - [Line 106](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/host.rb#L106), Col 13 - [Lint/NonLocalExitFromIterator](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Lint/NonLocalExitFromIterator) - Non-local exit from iterator, without return value. `next`, `break`, `Array#find`, `Array#any?`, etc. is preferred.\n- [ ] :warning: - [Line 117](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/host.rb#L117), Col 11 - [Lint/UselessAssignment](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Lint/UselessAssignment) - Useless assignment to variable - `new_result`.\n- [ ] :warning: - [Line 25](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/host.rb#L25), Col 83 - [Lint/Eval](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Lint/Eval) - The use of `eval` is a serious security risk.\n- [ ] :exclamation: - [Line 130](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/host.rb#L130), Col 77 - [Style/NestedTernaryOperator](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/NestedTernaryOperator) - Ternary operators must not be nested. Prefer `if`/`else` constructs instead.\n- [ ] :exclamation: - [Line 25](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/host.rb#L25), Col 35 - [Style/WordArray](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/WordArray) - Use `%w` or `%W` for an array of words.\n- [ ] :exclamation: - [Line 4](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/host.rb#L4), Col 7 - [Metrics/ModuleLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/ModuleLength) - Module has too many lines. [109/100]\n- [ ] :grey_exclamation: - [Line 118](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/host.rb#L118), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [190/120]\n- [ ] :grey_exclamation: - [Line 130](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/host.rb#L130), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [141/120]\n- [ ] :grey_exclamation: - [Line 5](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/host.rb#L5), Col 9 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for parse_host is too high. [147.5/20]\n- [ ] :grey_exclamation: - [Line 5](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/host.rb#L5), Col 9 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for parse_host is too high. [30/6]\n- [ ] :grey_exclamation: - [Line 5](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/host.rb#L5), Col 9 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [107/25]\n- [ ] :grey_exclamation: - [Line 5](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/host.rb#L5), Col 9 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for parse_host is too high. [31/7]\n- [ ] :grey_exclamation: - [Line 90](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/host.rb#L90), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [124/120]\n\n**app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/storage.rb**\n- [ ] :warning: - [Line 13](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/storage.rb#L13), Col 17 - [Lint/UselessAssignment](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Lint/UselessAssignment) - Useless assignment to variable - `uid`.\n- [ ] :grey_exclamation: - [Line 29](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/storage.rb#L29), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [171/120]\n- [ ] :grey_exclamation: - [Line 30](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/storage.rb#L30), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [181/120]\n- [ ] :grey_exclamation: - [Line 31](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/storage.rb#L31), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/LineLength) - Line is too long. [164/120]\n- [ ] :grey_exclamation: - [Line 5](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/app/models/manageiq/providers/vmware/infra_manager/refresh_parser_common/storage.rb#L5), Col 9 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for parse_storage is too high. [36.84/20]\n\n**app/models/manageiq/providers/vmware/infra_manager/refresh_parser_dto.rb**\n- [ ] :exclamation: - [Line 42](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/app/models/manageiq/providers/vmware/infra_manager/refresh_parser_dto.rb#L42), Col 11 - [Style/CommentAnnotation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/CommentAnnotation) - Annotation keywords like `TODO` should be all upper case, followed by a colon, and a space, then a note describing the problem.\n\n**spec/models/manageiq/providers/vmware/infra_manager/refresher_dto_spec.rb**\n- [ ] :warning: - [Line 5](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/spec/models/manageiq/providers/vmware/infra_manager/refresher_dto_spec.rb#L5), Col 11 - [Lint/UselessAssignment](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Lint/UselessAssignment) - Useless assignment to variable - `server`. Use `_` or `_server` as a variable name to indicate that it won't be used.\n- [ ] :warning: - [Line 5](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/spec/models/manageiq/providers/vmware/infra_manager/refresher_dto_spec.rb#L5), Col 5 - [Lint/UselessAssignment](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Lint/UselessAssignment) - Useless assignment to variable - `guid`. Use `_` or `_guid` as a variable name to indicate that it won't be used.\n- [ ] :exclamation: - [Line 24](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/spec/models/manageiq/providers/vmware/infra_manager/refresher_dto_spec.rb#L24), Col 11 - [Style/CommentAnnotation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/CommentAnnotation) - Annotation keywords like `TODO` should be all upper case, followed by a colon, and a space, then a note describing the problem.\n- [ ] :exclamation: - [Line 25](https://github.com/agrare/manageiq/blob/4ef68382ce46df1cb3cebd58ca2c392969a1e3ca/spec/models/manageiq/providers/vmware/infra_manager/refresher_dto_spec.rb#L25), Col 9 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n"}}
{"actor":{"display_login":"miq-bot"}}