{"action":"created","comment":{"url":"https://api.github.com/repos/JabRef/jabref/pulls/comments/66075241","id":66075241,"diff_hunk":"@@ -213,4 +213,20 @@ public String toString() {\n     public GroupTreeNode copyNode() {\n         return new GroupTreeNode(group);\n     }\n+\n+    /**\n+     * Determines the number of entries in the specified list which are matched by this group.\n+     * @param entries list of entries to be searched\n+     * @return number of hits\n+     */\n+    public int numberOfHits(List<BibEntry> entries) {\n+        int hits = 0;\n+        SearchMatcher matcher = getSearchRule();\n+        for (BibEntry entry : entries) {\n+            if (matcher.isMatch(entry)) {\n+                hits++;\n+            }\n+        }\n+        return hits;\n+    }","path":"src/main/java/net/sf/jabref/logic/groups/GroupTreeNode.java","position":19,"original_position":19,"commit_id":"16097e40e3f946a1c5de7a4e5cdcfe89c60c60dc","original_commit_id":"16097e40e3f946a1c5de7a4e5cdcfe89c60c60dc","user":{"login":"simonharrer","id":375693,"avatar_url":"https://avatars.githubusercontent.com/u/375693?v=3","gravatar_id":"","url":"https://api.github.com/users/simonharrer","html_url":"https://github.com/simonharrer","followers_url":"https://api.github.com/users/simonharrer/followers","following_url":"https://api.github.com/users/simonharrer/following{/other_user}","gists_url":"https://api.github.com/users/simonharrer/gists{/gist_id}","starred_url":"https://api.github.com/users/simonharrer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonharrer/subscriptions","organizations_url":"https://api.github.com/users/simonharrer/orgs","repos_url":"https://api.github.com/users/simonharrer/repos","events_url":"https://api.github.com/users/simonharrer/events{/privacy}","received_events_url":"https://api.github.com/users/simonharrer/received_events","type":"User","site_admin":false},"body":"Ah  ok, the getSearchRule is automatically adjusting to the position in the group tree? Then this make sense. ","created_at":"2016-06-07T13:58:51Z","updated_at":"2016-06-07T13:58:51Z","html_url":"https://github.com/JabRef/jabref/pull/1483#discussion_r66075241","pull_request_url":"https://api.github.com/repos/JabRef/jabref/pulls/1483","_links":{"self":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/comments/66075241"},"html":{"href":"https://github.com/JabRef/jabref/pull/1483#discussion_r66075241"},"pull_request":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/1483"}}},"pull_request":{"url":"https://api.github.com/repos/JabRef/jabref/pulls/1483","id":72756623,"html_url":"https://github.com/JabRef/jabref/pull/1483","diff_url":"https://github.com/JabRef/jabref/pull/1483.diff","patch_url":"https://github.com/JabRef/jabref/pull/1483.patch","issue_url":"https://api.github.com/repos/JabRef/jabref/issues/1483","number":1483,"state":"open","locked":false,"title":"Fixes #1482: Correct number of matched entries is displayed for refining subgroups","user":{"login":"tobiasdiez","id":5037600,"avatar_url":"https://avatars.githubusercontent.com/u/5037600?v=3","gravatar_id":"","url":"https://api.github.com/users/tobiasdiez","html_url":"https://github.com/tobiasdiez","followers_url":"https://api.github.com/users/tobiasdiez/followers","following_url":"https://api.github.com/users/tobiasdiez/following{/other_user}","gists_url":"https://api.github.com/users/tobiasdiez/gists{/gist_id}","starred_url":"https://api.github.com/users/tobiasdiez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobiasdiez/subscriptions","organizations_url":"https://api.github.com/users/tobiasdiez/orgs","repos_url":"https://api.github.com/users/tobiasdiez/repos","events_url":"https://api.github.com/users/tobiasdiez/events{/privacy}","received_events_url":"https://api.github.com/users/tobiasdiez/received_events","type":"User","site_admin":false},"body":"The issue was that, for the number of hits, JabRef only checked if the\r\ngroup taken separately matched the entry. That is, it was completely\r\nignored that the group sits in a tree and might be set up to refine the\r\nsearch of the parent. Taking the example given in #1482, 577 entries\r\nsatisfy the condition `articlé original` but only 38 are also matched by\r\n`articlé`.\r\n\r\n- [x] Change in CHANGELOG.md described\r\n- [x] Tests created for changes\r\n- [ ] Screenshots added (for bigger UI changes)","created_at":"2016-06-06T18:38:14Z","updated_at":"2016-06-07T13:58:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e087d49a76f4e90dde3ad31189a9518c075be7b8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JabRef/jabref/pulls/1483/commits","review_comments_url":"https://api.github.com/repos/JabRef/jabref/pulls/1483/comments","review_comment_url":"https://api.github.com/repos/JabRef/jabref/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JabRef/jabref/issues/1483/comments","statuses_url":"https://api.github.com/repos/JabRef/jabref/statuses/16097e40e3f946a1c5de7a4e5cdcfe89c60c60dc","head":{"label":"tobiasdiez:fix1482","ref":"fix1482","sha":"16097e40e3f946a1c5de7a4e5cdcfe89c60c60dc","user":{"login":"tobiasdiez","id":5037600,"avatar_url":"https://avatars.githubusercontent.com/u/5037600?v=3","gravatar_id":"","url":"https://api.github.com/users/tobiasdiez","html_url":"https://github.com/tobiasdiez","followers_url":"https://api.github.com/users/tobiasdiez/followers","following_url":"https://api.github.com/users/tobiasdiez/following{/other_user}","gists_url":"https://api.github.com/users/tobiasdiez/gists{/gist_id}","starred_url":"https://api.github.com/users/tobiasdiez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobiasdiez/subscriptions","organizations_url":"https://api.github.com/users/tobiasdiez/orgs","repos_url":"https://api.github.com/users/tobiasdiez/repos","events_url":"https://api.github.com/users/tobiasdiez/events{/privacy}","received_events_url":"https://api.github.com/users/tobiasdiez/received_events","type":"User","site_admin":false},"repo":{"id":25407066,"name":"jabref","full_name":"tobiasdiez/jabref","owner":{"login":"tobiasdiez","id":5037600,"avatar_url":"https://avatars.githubusercontent.com/u/5037600?v=3","gravatar_id":"","url":"https://api.github.com/users/tobiasdiez","html_url":"https://github.com/tobiasdiez","followers_url":"https://api.github.com/users/tobiasdiez/followers","following_url":"https://api.github.com/users/tobiasdiez/following{/other_user}","gists_url":"https://api.github.com/users/tobiasdiez/gists{/gist_id}","starred_url":"https://api.github.com/users/tobiasdiez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobiasdiez/subscriptions","organizations_url":"https://api.github.com/users/tobiasdiez/orgs","repos_url":"https://api.github.com/users/tobiasdiez/repos","events_url":"https://api.github.com/users/tobiasdiez/events{/privacy}","received_events_url":"https://api.github.com/users/tobiasdiez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tobiasdiez/jabref","description":"Graphical Java application for managing bibtex (.bib) databases","fork":true,"url":"https://api.github.com/repos/tobiasdiez/jabref","forks_url":"https://api.github.com/repos/tobiasdiez/jabref/forks","keys_url":"https://api.github.com/repos/tobiasdiez/jabref/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tobiasdiez/jabref/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tobiasdiez/jabref/teams","hooks_url":"https://api.github.com/repos/tobiasdiez/jabref/hooks","issue_events_url":"https://api.github.com/repos/tobiasdiez/jabref/issues/events{/number}","events_url":"https://api.github.com/repos/tobiasdiez/jabref/events","assignees_url":"https://api.github.com/repos/tobiasdiez/jabref/assignees{/user}","branches_url":"https://api.github.com/repos/tobiasdiez/jabref/branches{/branch}","tags_url":"https://api.github.com/repos/tobiasdiez/jabref/tags","blobs_url":"https://api.github.com/repos/tobiasdiez/jabref/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tobiasdiez/jabref/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tobiasdiez/jabref/git/refs{/sha}","trees_url":"https://api.github.com/repos/tobiasdiez/jabref/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tobiasdiez/jabref/statuses/{sha}","languages_url":"https://api.github.com/repos/tobiasdiez/jabref/languages","stargazers_url":"https://api.github.com/repos/tobiasdiez/jabref/stargazers","contributors_url":"https://api.github.com/repos/tobiasdiez/jabref/contributors","subscribers_url":"https://api.github.com/repos/tobiasdiez/jabref/subscribers","subscription_url":"https://api.github.com/repos/tobiasdiez/jabref/subscription","commits_url":"https://api.github.com/repos/tobiasdiez/jabref/commits{/sha}","git_commits_url":"https://api.github.com/repos/tobiasdiez/jabref/git/commits{/sha}","comments_url":"https://api.github.com/repos/tobiasdiez/jabref/comments{/number}","issue_comment_url":"https://api.github.com/repos/tobiasdiez/jabref/issues/comments{/number}","contents_url":"https://api.github.com/repos/tobiasdiez/jabref/contents/{+path}","compare_url":"https://api.github.com/repos/tobiasdiez/jabref/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tobiasdiez/jabref/merges","archive_url":"https://api.github.com/repos/tobiasdiez/jabref/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tobiasdiez/jabref/downloads","issues_url":"https://api.github.com/repos/tobiasdiez/jabref/issues{/number}","pulls_url":"https://api.github.com/repos/tobiasdiez/jabref/pulls{/number}","milestones_url":"https://api.github.com/repos/tobiasdiez/jabref/milestones{/number}","notifications_url":"https://api.github.com/repos/tobiasdiez/jabref/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tobiasdiez/jabref/labels{/name}","releases_url":"https://api.github.com/repos/tobiasdiez/jabref/releases{/id}","deployments_url":"https://api.github.com/repos/tobiasdiez/jabref/deployments","created_at":"2014-10-18T19:04:49Z","updated_at":"2014-11-29T22:04:20Z","pushed_at":"2016-06-06T20:31:30Z","git_url":"git://github.com/tobiasdiez/jabref.git","ssh_url":"git@github.com:tobiasdiez/jabref.git","clone_url":"https://github.com/tobiasdiez/jabref.git","svn_url":"https://github.com/tobiasdiez/jabref","homepage":"http://jabref.sourceforge.net/","size":81222,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JabRef:master","ref":"master","sha":"241b336de46a943feb90579a28b512b24eb4cd01","user":{"login":"JabRef","id":3914421,"avatar_url":"https://avatars.githubusercontent.com/u/3914421?v=3","gravatar_id":"","url":"https://api.github.com/users/JabRef","html_url":"https://github.com/JabRef","followers_url":"https://api.github.com/users/JabRef/followers","following_url":"https://api.github.com/users/JabRef/following{/other_user}","gists_url":"https://api.github.com/users/JabRef/gists{/gist_id}","starred_url":"https://api.github.com/users/JabRef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabRef/subscriptions","organizations_url":"https://api.github.com/users/JabRef/orgs","repos_url":"https://api.github.com/users/JabRef/repos","events_url":"https://api.github.com/users/JabRef/events{/privacy}","received_events_url":"https://api.github.com/users/JabRef/received_events","type":"Organization","site_admin":false},"repo":{"id":17634071,"name":"jabref","full_name":"JabRef/jabref","owner":{"login":"JabRef","id":3914421,"avatar_url":"https://avatars.githubusercontent.com/u/3914421?v=3","gravatar_id":"","url":"https://api.github.com/users/JabRef","html_url":"https://github.com/JabRef","followers_url":"https://api.github.com/users/JabRef/followers","following_url":"https://api.github.com/users/JabRef/following{/other_user}","gists_url":"https://api.github.com/users/JabRef/gists{/gist_id}","starred_url":"https://api.github.com/users/JabRef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabRef/subscriptions","organizations_url":"https://api.github.com/users/JabRef/orgs","repos_url":"https://api.github.com/users/JabRef/repos","events_url":"https://api.github.com/users/JabRef/events{/privacy}","received_events_url":"https://api.github.com/users/JabRef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JabRef/jabref","description":"Graphical Java application for managing BibTeX and Biblatex (.bib) databases","fork":false,"url":"https://api.github.com/repos/JabRef/jabref","forks_url":"https://api.github.com/repos/JabRef/jabref/forks","keys_url":"https://api.github.com/repos/JabRef/jabref/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JabRef/jabref/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JabRef/jabref/teams","hooks_url":"https://api.github.com/repos/JabRef/jabref/hooks","issue_events_url":"https://api.github.com/repos/JabRef/jabref/issues/events{/number}","events_url":"https://api.github.com/repos/JabRef/jabref/events","assignees_url":"https://api.github.com/repos/JabRef/jabref/assignees{/user}","branches_url":"https://api.github.com/repos/JabRef/jabref/branches{/branch}","tags_url":"https://api.github.com/repos/JabRef/jabref/tags","blobs_url":"https://api.github.com/repos/JabRef/jabref/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JabRef/jabref/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JabRef/jabref/git/refs{/sha}","trees_url":"https://api.github.com/repos/JabRef/jabref/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JabRef/jabref/statuses/{sha}","languages_url":"https://api.github.com/repos/JabRef/jabref/languages","stargazers_url":"https://api.github.com/repos/JabRef/jabref/stargazers","contributors_url":"https://api.github.com/repos/JabRef/jabref/contributors","subscribers_url":"https://api.github.com/repos/JabRef/jabref/subscribers","subscription_url":"https://api.github.com/repos/JabRef/jabref/subscription","commits_url":"https://api.github.com/repos/JabRef/jabref/commits{/sha}","git_commits_url":"https://api.github.com/repos/JabRef/jabref/git/commits{/sha}","comments_url":"https://api.github.com/repos/JabRef/jabref/comments{/number}","issue_comment_url":"https://api.github.com/repos/JabRef/jabref/issues/comments{/number}","contents_url":"https://api.github.com/repos/JabRef/jabref/contents/{+path}","compare_url":"https://api.github.com/repos/JabRef/jabref/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JabRef/jabref/merges","archive_url":"https://api.github.com/repos/JabRef/jabref/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JabRef/jabref/downloads","issues_url":"https://api.github.com/repos/JabRef/jabref/issues{/number}","pulls_url":"https://api.github.com/repos/JabRef/jabref/pulls{/number}","milestones_url":"https://api.github.com/repos/JabRef/jabref/milestones{/number}","notifications_url":"https://api.github.com/repos/JabRef/jabref/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JabRef/jabref/labels{/name}","releases_url":"https://api.github.com/repos/JabRef/jabref/releases{/id}","deployments_url":"https://api.github.com/repos/JabRef/jabref/deployments","created_at":"2014-03-11T14:48:42Z","updated_at":"2016-06-07T03:32:48Z","pushed_at":"2016-06-07T13:10:22Z","git_url":"git://github.com/JabRef/jabref.git","ssh_url":"git@github.com:JabRef/jabref.git","clone_url":"https://github.com/JabRef/jabref.git","svn_url":"https://github.com/JabRef/jabref","homepage":"http://www.jabref.org","size":89939,"stargazers_count":286,"watchers_count":286,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":236,"mirror_url":null,"open_issues_count":188,"forks":236,"open_issues":188,"watchers":286,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/1483"},"html":{"href":"https://github.com/JabRef/jabref/pull/1483"},"issue":{"href":"https://api.github.com/repos/JabRef/jabref/issues/1483"},"comments":{"href":"https://api.github.com/repos/JabRef/jabref/issues/1483/comments"},"review_comments":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/1483/comments"},"review_comment":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/1483/commits"},"statuses":{"href":"https://api.github.com/repos/JabRef/jabref/statuses/16097e40e3f946a1c5de7a4e5cdcfe89c60c60dc"}}}}
{"actor":{"display_login":"simonharrer"}}