{"action":"created","issue":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3645","repository_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3645/labels{/name}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3645/comments","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3645/events","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3645","id":137317251,"number":3645,"title":"Remove invalid triangles from north and south pole of EllipsoidGeometry","user":{"login":"hpinkos","id":3451886,"avatar_url":"https://avatars.githubusercontent.com/u/3451886?v=3","gravatar_id":"","url":"https://api.github.com/users/hpinkos","html_url":"https://github.com/hpinkos","followers_url":"https://api.github.com/users/hpinkos/followers","following_url":"https://api.github.com/users/hpinkos/following{/other_user}","gists_url":"https://api.github.com/users/hpinkos/gists{/gist_id}","starred_url":"https://api.github.com/users/hpinkos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpinkos/subscriptions","organizations_url":"https://api.github.com/users/hpinkos/orgs","repos_url":"https://api.github.com/users/hpinkos/repos","events_url":"https://api.github.com/users/hpinkos/events{/privacy}","received_events_url":"https://api.github.com/users/hpinkos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-29T17:25:42Z","updated_at":"2016-02-29T20:45:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/3645","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3645","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3645.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3645.patch"},"body":"Fixes #3045\r\nThere wasn't actually a hole in the ellipsoid; the shading for the top slice (and bottom slice, I presume) was off because the normal vector had NaNs due to adjacent triangles with no area.\r\n\r\nSo this PR removes a bunch of triangles being added with two corners at the same position.\r\nThe top and bottom of the ellipsoid needed to be triangulated with a fan instead of a strip."},"comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments/190379760","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/3645#issuecomment-190379760","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/3645","id":190379760,"user":{"login":"mramato","id":1495196,"avatar_url":"https://avatars.githubusercontent.com/u/1495196?v=3","gravatar_id":"","url":"https://api.github.com/users/mramato","html_url":"https://github.com/mramato","followers_url":"https://api.github.com/users/mramato/followers","following_url":"https://api.github.com/users/mramato/following{/other_user}","gists_url":"https://api.github.com/users/mramato/gists{/gist_id}","starred_url":"https://api.github.com/users/mramato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mramato/subscriptions","organizations_url":"https://api.github.com/users/mramato/orgs","repos_url":"https://api.github.com/users/mramato/repos","events_url":"https://api.github.com/users/mramato/events{/privacy}","received_events_url":"https://api.github.com/users/mramato/received_events","type":"User","site_admin":false},"created_at":"2016-02-29T20:45:09Z","updated_at":"2016-02-29T20:45:09Z","body":":+1: from me.  I also checked out some different materials as well and everything is working as expected and a big improvement over master.  Does anyone else want to review this?  If not I'll merge later tonight."}}