{"action":"created","comment":{"url":"https://api.github.com/repos/conan-io/conan/pulls/comments/48685704","id":48685704,"diff_hunk":"@@ -76,6 +76,7 @@ def load_conan(self, conan_file_path, consumer=False):\n             result = self._create_check_conan(loaded, consumer)\n             if consumer:\n                 result.options.initialize_upstream(self._options)\n+\t    type(result).conanfile_directory = property(lambda self, _path=conan_file_path: os.path.dirname(_path))","path":"conans/client/loader.py","position":4,"original_position":4,"commit_id":"c95fca1e1e448f442ec1bf64e0186c57e99f377a","original_commit_id":"c95fca1e1e448f442ec1bf64e0186c57e99f377a","user":{"login":"memsharded","id":15367152,"avatar_url":"https://avatars.githubusercontent.com/u/15367152?v=3","gravatar_id":"","url":"https://api.github.com/users/memsharded","html_url":"https://github.com/memsharded","followers_url":"https://api.github.com/users/memsharded/followers","following_url":"https://api.github.com/users/memsharded/following{/other_user}","gists_url":"https://api.github.com/users/memsharded/gists{/gist_id}","starred_url":"https://api.github.com/users/memsharded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memsharded/subscriptions","organizations_url":"https://api.github.com/users/memsharded/orgs","repos_url":"https://api.github.com/users/memsharded/repos","events_url":"https://api.github.com/users/memsharded/events{/privacy}","received_events_url":"https://api.github.com/users/memsharded/received_events","type":"User","site_admin":false},"body":"Yes, I'd say it'd be better to handle this in a separate pull request. In particular, I think that the conanfile_directory can be made an explicit property in the base ConanFile class. If the path is dynamically assigned as it seems the case, I'd assign it here (and comment in the ConanFile class property that the value is dynamic). I like conanfile user-related things to be at least defined in the base ConanFile class for reference.","created_at":"2016-01-02T16:42:49Z","updated_at":"2016-01-02T16:42:49Z","html_url":"https://github.com/conan-io/conan/pull/65#discussion_r48685704","pull_request_url":"https://api.github.com/repos/conan-io/conan/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/conan-io/conan/pulls/comments/48685704"},"html":{"href":"https://github.com/conan-io/conan/pull/65#discussion_r48685704"},"pull_request":{"href":"https://api.github.com/repos/conan-io/conan/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/conan-io/conan/pulls/65","id":54902851,"html_url":"https://github.com/conan-io/conan/pull/65","diff_url":"https://github.com/conan-io/conan/pull/65.diff","patch_url":"https://github.com/conan-io/conan/pull/65.patch","issue_url":"https://api.github.com/repos/conan-io/conan/issues/65","number":65,"state":"open","locked":false,"title":"Add support for YouCompleteMe integration","user":{"login":"skizzay","id":972461,"avatar_url":"https://avatars.githubusercontent.com/u/972461?v=3","gravatar_id":"","url":"https://api.github.com/users/skizzay","html_url":"https://github.com/skizzay","followers_url":"https://api.github.com/users/skizzay/followers","following_url":"https://api.github.com/users/skizzay/following{/other_user}","gists_url":"https://api.github.com/users/skizzay/gists{/gist_id}","starred_url":"https://api.github.com/users/skizzay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skizzay/subscriptions","organizations_url":"https://api.github.com/users/skizzay/orgs","repos_url":"https://api.github.com/users/skizzay/repos","events_url":"https://api.github.com/users/skizzay/events{/privacy}","received_events_url":"https://api.github.com/users/skizzay/received_events","type":"User","site_admin":false},"body":"Add support for [YouCompleteMe](https://valloric.github.io/YouCompleteMe/) code-completion engine for Vim.  This will generate the python file for it to work with the build/install directories generated by conan.\r\n\r\nAs part of this change, I also added support for calculating the current cpp info when writing the generator.  This allows the current generator to take advantage of the packages intended compilation flags.\r\n\r\nI also attached a property to each `ConanFile` that gets loaded called `conanfile_directory`.  This contains the directory from which the `ConanFile` was loaded. It's completely unrelated to the other change so we can probably create a separate pull request for it, if it's desired.","created_at":"2016-01-02T07:54:45Z","updated_at":"2016-01-02T16:42:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"accc359c9293bc7753de2b298ba8ded82dbce4a4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/conan-io/conan/pulls/65/commits","review_comments_url":"https://api.github.com/repos/conan-io/conan/pulls/65/comments","review_comment_url":"https://api.github.com/repos/conan-io/conan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conan-io/conan/issues/65/comments","statuses_url":"https://api.github.com/repos/conan-io/conan/statuses/c95fca1e1e448f442ec1bf64e0186c57e99f377a","head":{"label":"skizzay:ycm-generator","ref":"ycm-generator","sha":"c95fca1e1e448f442ec1bf64e0186c57e99f377a","user":{"login":"skizzay","id":972461,"avatar_url":"https://avatars.githubusercontent.com/u/972461?v=3","gravatar_id":"","url":"https://api.github.com/users/skizzay","html_url":"https://github.com/skizzay","followers_url":"https://api.github.com/users/skizzay/followers","following_url":"https://api.github.com/users/skizzay/following{/other_user}","gists_url":"https://api.github.com/users/skizzay/gists{/gist_id}","starred_url":"https://api.github.com/users/skizzay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skizzay/subscriptions","organizations_url":"https://api.github.com/users/skizzay/orgs","repos_url":"https://api.github.com/users/skizzay/repos","events_url":"https://api.github.com/users/skizzay/events{/privacy}","received_events_url":"https://api.github.com/users/skizzay/received_events","type":"User","site_admin":false},"repo":{"id":47736614,"name":"conan","full_name":"skizzay/conan","owner":{"login":"skizzay","id":972461,"avatar_url":"https://avatars.githubusercontent.com/u/972461?v=3","gravatar_id":"","url":"https://api.github.com/users/skizzay","html_url":"https://github.com/skizzay","followers_url":"https://api.github.com/users/skizzay/followers","following_url":"https://api.github.com/users/skizzay/following{/other_user}","gists_url":"https://api.github.com/users/skizzay/gists{/gist_id}","starred_url":"https://api.github.com/users/skizzay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skizzay/subscriptions","organizations_url":"https://api.github.com/users/skizzay/orgs","repos_url":"https://api.github.com/users/skizzay/repos","events_url":"https://api.github.com/users/skizzay/events{/privacy}","received_events_url":"https://api.github.com/users/skizzay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skizzay/conan","description":"Conan.io - The open-source C/C++ package manager","fork":true,"url":"https://api.github.com/repos/skizzay/conan","forks_url":"https://api.github.com/repos/skizzay/conan/forks","keys_url":"https://api.github.com/repos/skizzay/conan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skizzay/conan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skizzay/conan/teams","hooks_url":"https://api.github.com/repos/skizzay/conan/hooks","issue_events_url":"https://api.github.com/repos/skizzay/conan/issues/events{/number}","events_url":"https://api.github.com/repos/skizzay/conan/events","assignees_url":"https://api.github.com/repos/skizzay/conan/assignees{/user}","branches_url":"https://api.github.com/repos/skizzay/conan/branches{/branch}","tags_url":"https://api.github.com/repos/skizzay/conan/tags","blobs_url":"https://api.github.com/repos/skizzay/conan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skizzay/conan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skizzay/conan/git/refs{/sha}","trees_url":"https://api.github.com/repos/skizzay/conan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skizzay/conan/statuses/{sha}","languages_url":"https://api.github.com/repos/skizzay/conan/languages","stargazers_url":"https://api.github.com/repos/skizzay/conan/stargazers","contributors_url":"https://api.github.com/repos/skizzay/conan/contributors","subscribers_url":"https://api.github.com/repos/skizzay/conan/subscribers","subscription_url":"https://api.github.com/repos/skizzay/conan/subscription","commits_url":"https://api.github.com/repos/skizzay/conan/commits{/sha}","git_commits_url":"https://api.github.com/repos/skizzay/conan/git/commits{/sha}","comments_url":"https://api.github.com/repos/skizzay/conan/comments{/number}","issue_comment_url":"https://api.github.com/repos/skizzay/conan/issues/comments{/number}","contents_url":"https://api.github.com/repos/skizzay/conan/contents/{+path}","compare_url":"https://api.github.com/repos/skizzay/conan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skizzay/conan/merges","archive_url":"https://api.github.com/repos/skizzay/conan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skizzay/conan/downloads","issues_url":"https://api.github.com/repos/skizzay/conan/issues{/number}","pulls_url":"https://api.github.com/repos/skizzay/conan/pulls{/number}","milestones_url":"https://api.github.com/repos/skizzay/conan/milestones{/number}","notifications_url":"https://api.github.com/repos/skizzay/conan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skizzay/conan/labels{/name}","releases_url":"https://api.github.com/repos/skizzay/conan/releases{/id}","created_at":"2015-12-10T03:56:52Z","updated_at":"2015-12-10T03:56:54Z","pushed_at":"2016-01-02T08:19:49Z","git_url":"git://github.com/skizzay/conan.git","ssh_url":"git@github.com:skizzay/conan.git","clone_url":"https://github.com/skizzay/conan.git","svn_url":"https://github.com/skizzay/conan","homepage":"https://conan.io","size":405,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"conan-io:develop","ref":"develop","sha":"9b782ab0b462aa06698fe225b1eaf1ed3662fc48","user":{"login":"conan-io","id":15212165,"avatar_url":"https://avatars.githubusercontent.com/u/15212165?v=3","gravatar_id":"","url":"https://api.github.com/users/conan-io","html_url":"https://github.com/conan-io","followers_url":"https://api.github.com/users/conan-io/followers","following_url":"https://api.github.com/users/conan-io/following{/other_user}","gists_url":"https://api.github.com/users/conan-io/gists{/gist_id}","starred_url":"https://api.github.com/users/conan-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conan-io/subscriptions","organizations_url":"https://api.github.com/users/conan-io/orgs","repos_url":"https://api.github.com/users/conan-io/repos","events_url":"https://api.github.com/users/conan-io/events{/privacy}","received_events_url":"https://api.github.com/users/conan-io/received_events","type":"Organization","site_admin":false},"repo":{"id":47190624,"name":"conan","full_name":"conan-io/conan","owner":{"login":"conan-io","id":15212165,"avatar_url":"https://avatars.githubusercontent.com/u/15212165?v=3","gravatar_id":"","url":"https://api.github.com/users/conan-io","html_url":"https://github.com/conan-io","followers_url":"https://api.github.com/users/conan-io/followers","following_url":"https://api.github.com/users/conan-io/following{/other_user}","gists_url":"https://api.github.com/users/conan-io/gists{/gist_id}","starred_url":"https://api.github.com/users/conan-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conan-io/subscriptions","organizations_url":"https://api.github.com/users/conan-io/orgs","repos_url":"https://api.github.com/users/conan-io/repos","events_url":"https://api.github.com/users/conan-io/events{/privacy}","received_events_url":"https://api.github.com/users/conan-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conan-io/conan","description":"Conan.io - The open-source C/C++ package manager","fork":false,"url":"https://api.github.com/repos/conan-io/conan","forks_url":"https://api.github.com/repos/conan-io/conan/forks","keys_url":"https://api.github.com/repos/conan-io/conan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conan-io/conan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conan-io/conan/teams","hooks_url":"https://api.github.com/repos/conan-io/conan/hooks","issue_events_url":"https://api.github.com/repos/conan-io/conan/issues/events{/number}","events_url":"https://api.github.com/repos/conan-io/conan/events","assignees_url":"https://api.github.com/repos/conan-io/conan/assignees{/user}","branches_url":"https://api.github.com/repos/conan-io/conan/branches{/branch}","tags_url":"https://api.github.com/repos/conan-io/conan/tags","blobs_url":"https://api.github.com/repos/conan-io/conan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conan-io/conan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conan-io/conan/git/refs{/sha}","trees_url":"https://api.github.com/repos/conan-io/conan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conan-io/conan/statuses/{sha}","languages_url":"https://api.github.com/repos/conan-io/conan/languages","stargazers_url":"https://api.github.com/repos/conan-io/conan/stargazers","contributors_url":"https://api.github.com/repos/conan-io/conan/contributors","subscribers_url":"https://api.github.com/repos/conan-io/conan/subscribers","subscription_url":"https://api.github.com/repos/conan-io/conan/subscription","commits_url":"https://api.github.com/repos/conan-io/conan/commits{/sha}","git_commits_url":"https://api.github.com/repos/conan-io/conan/git/commits{/sha}","comments_url":"https://api.github.com/repos/conan-io/conan/comments{/number}","issue_comment_url":"https://api.github.com/repos/conan-io/conan/issues/comments{/number}","contents_url":"https://api.github.com/repos/conan-io/conan/contents/{+path}","compare_url":"https://api.github.com/repos/conan-io/conan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conan-io/conan/merges","archive_url":"https://api.github.com/repos/conan-io/conan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conan-io/conan/downloads","issues_url":"https://api.github.com/repos/conan-io/conan/issues{/number}","pulls_url":"https://api.github.com/repos/conan-io/conan/pulls{/number}","milestones_url":"https://api.github.com/repos/conan-io/conan/milestones{/number}","notifications_url":"https://api.github.com/repos/conan-io/conan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conan-io/conan/labels{/name}","releases_url":"https://api.github.com/repos/conan-io/conan/releases{/id}","created_at":"2015-12-01T13:17:02Z","updated_at":"2016-01-02T15:59:24Z","pushed_at":"2016-01-02T08:19:49Z","git_url":"git://github.com/conan-io/conan.git","ssh_url":"git@github.com:conan-io/conan.git","clone_url":"https://github.com/conan-io/conan.git","svn_url":"https://github.com/conan-io/conan","homepage":"https://conan.io","size":419,"stargazers_count":204,"watchers_count":204,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":16,"forks":19,"open_issues":16,"watchers":204,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/conan-io/conan/pulls/65"},"html":{"href":"https://github.com/conan-io/conan/pull/65"},"issue":{"href":"https://api.github.com/repos/conan-io/conan/issues/65"},"comments":{"href":"https://api.github.com/repos/conan-io/conan/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/conan-io/conan/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/conan-io/conan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conan-io/conan/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/conan-io/conan/statuses/c95fca1e1e448f442ec1bf64e0186c57e99f377a"}}}}