{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/kanboard/plugin-s3/pulls/4","id":88955999,"html_url":"https://github.com/kanboard/plugin-s3/pull/4","diff_url":"https://github.com/kanboard/plugin-s3/pull/4.diff","patch_url":"https://github.com/kanboard/plugin-s3/pull/4.patch","issue_url":"https://api.github.com/repos/kanboard/plugin-s3/issues/4","number":4,"state":"closed","locked":false,"title":"Config region was never considered because it was defined in the constant.","user":{"login":"moensch","id":223820,"avatar_url":"https://avatars.githubusercontent.com/u/223820?v=3","gravatar_id":"","url":"https://api.github.com/users/moensch","html_url":"https://github.com/moensch","followers_url":"https://api.github.com/users/moensch/followers","following_url":"https://api.github.com/users/moensch/following{/other_user}","gists_url":"https://api.github.com/users/moensch/gists{/gist_id}","starred_url":"https://api.github.com/users/moensch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moensch/subscriptions","organizations_url":"https://api.github.com/users/moensch/orgs","repos_url":"https://api.github.com/users/moensch/repos","events_url":"https://api.github.com/users/moensch/events{/privacy}","received_events_url":"https://api.github.com/users/moensch/received_events","type":"User","site_admin":false},"body":"Rather than using config.php, I defined aws_s3_bucket in the config database. The config setting was ignored because it was always defined in Plugin.php.","created_at":"2016-10-12T05:33:23Z","updated_at":"2016-10-12T23:38:37Z","closed_at":"2016-10-12T23:38:37Z","merged_at":"2016-10-12T23:38:37Z","merge_commit_sha":"be95a8d481fee8998f55f08b93c9635405323e7a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kanboard/plugin-s3/pulls/4/commits","review_comments_url":"https://api.github.com/repos/kanboard/plugin-s3/pulls/4/comments","review_comment_url":"https://api.github.com/repos/kanboard/plugin-s3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kanboard/plugin-s3/issues/4/comments","statuses_url":"https://api.github.com/repos/kanboard/plugin-s3/statuses/74ac6fb8b8cbabc44cc42e06f60cd689bcf6f882","head":{"label":"moensch:master","ref":"master","sha":"74ac6fb8b8cbabc44cc42e06f60cd689bcf6f882","user":{"login":"moensch","id":223820,"avatar_url":"https://avatars.githubusercontent.com/u/223820?v=3","gravatar_id":"","url":"https://api.github.com/users/moensch","html_url":"https://github.com/moensch","followers_url":"https://api.github.com/users/moensch/followers","following_url":"https://api.github.com/users/moensch/following{/other_user}","gists_url":"https://api.github.com/users/moensch/gists{/gist_id}","starred_url":"https://api.github.com/users/moensch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moensch/subscriptions","organizations_url":"https://api.github.com/users/moensch/orgs","repos_url":"https://api.github.com/users/moensch/repos","events_url":"https://api.github.com/users/moensch/events{/privacy}","received_events_url":"https://api.github.com/users/moensch/received_events","type":"User","site_admin":false},"repo":{"id":70665863,"name":"plugin-s3","full_name":"moensch/plugin-s3","owner":{"login":"moensch","id":223820,"avatar_url":"https://avatars.githubusercontent.com/u/223820?v=3","gravatar_id":"","url":"https://api.github.com/users/moensch","html_url":"https://github.com/moensch","followers_url":"https://api.github.com/users/moensch/followers","following_url":"https://api.github.com/users/moensch/following{/other_user}","gists_url":"https://api.github.com/users/moensch/gists{/gist_id}","starred_url":"https://api.github.com/users/moensch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moensch/subscriptions","organizations_url":"https://api.github.com/users/moensch/orgs","repos_url":"https://api.github.com/users/moensch/repos","events_url":"https://api.github.com/users/moensch/events{/privacy}","received_events_url":"https://api.github.com/users/moensch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/moensch/plugin-s3","description":"Plugin to store files to Amazon S3","fork":true,"url":"https://api.github.com/repos/moensch/plugin-s3","forks_url":"https://api.github.com/repos/moensch/plugin-s3/forks","keys_url":"https://api.github.com/repos/moensch/plugin-s3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moensch/plugin-s3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moensch/plugin-s3/teams","hooks_url":"https://api.github.com/repos/moensch/plugin-s3/hooks","issue_events_url":"https://api.github.com/repos/moensch/plugin-s3/issues/events{/number}","events_url":"https://api.github.com/repos/moensch/plugin-s3/events","assignees_url":"https://api.github.com/repos/moensch/plugin-s3/assignees{/user}","branches_url":"https://api.github.com/repos/moensch/plugin-s3/branches{/branch}","tags_url":"https://api.github.com/repos/moensch/plugin-s3/tags","blobs_url":"https://api.github.com/repos/moensch/plugin-s3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moensch/plugin-s3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moensch/plugin-s3/git/refs{/sha}","trees_url":"https://api.github.com/repos/moensch/plugin-s3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moensch/plugin-s3/statuses/{sha}","languages_url":"https://api.github.com/repos/moensch/plugin-s3/languages","stargazers_url":"https://api.github.com/repos/moensch/plugin-s3/stargazers","contributors_url":"https://api.github.com/repos/moensch/plugin-s3/contributors","subscribers_url":"https://api.github.com/repos/moensch/plugin-s3/subscribers","subscription_url":"https://api.github.com/repos/moensch/plugin-s3/subscription","commits_url":"https://api.github.com/repos/moensch/plugin-s3/commits{/sha}","git_commits_url":"https://api.github.com/repos/moensch/plugin-s3/git/commits{/sha}","comments_url":"https://api.github.com/repos/moensch/plugin-s3/comments{/number}","issue_comment_url":"https://api.github.com/repos/moensch/plugin-s3/issues/comments{/number}","contents_url":"https://api.github.com/repos/moensch/plugin-s3/contents/{+path}","compare_url":"https://api.github.com/repos/moensch/plugin-s3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moensch/plugin-s3/merges","archive_url":"https://api.github.com/repos/moensch/plugin-s3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moensch/plugin-s3/downloads","issues_url":"https://api.github.com/repos/moensch/plugin-s3/issues{/number}","pulls_url":"https://api.github.com/repos/moensch/plugin-s3/pulls{/number}","milestones_url":"https://api.github.com/repos/moensch/plugin-s3/milestones{/number}","notifications_url":"https://api.github.com/repos/moensch/plugin-s3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moensch/plugin-s3/labels{/name}","releases_url":"https://api.github.com/repos/moensch/plugin-s3/releases{/id}","deployments_url":"https://api.github.com/repos/moensch/plugin-s3/deployments","created_at":"2016-10-12T05:27:23Z","updated_at":"2016-10-12T05:27:24Z","pushed_at":"2016-10-12T05:32:10Z","git_url":"git://github.com/moensch/plugin-s3.git","ssh_url":"git@github.com:moensch/plugin-s3.git","clone_url":"https://github.com/moensch/plugin-s3.git","svn_url":"https://github.com/moensch/plugin-s3","homepage":"https://kanboard.net/plugin/s3","size":1617,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kanboard:master","ref":"master","sha":"51e399aefa472d010781b58244b8fe1075b2f808","user":{"login":"kanboard","id":13722943,"avatar_url":"https://avatars.githubusercontent.com/u/13722943?v=3","gravatar_id":"","url":"https://api.github.com/users/kanboard","html_url":"https://github.com/kanboard","followers_url":"https://api.github.com/users/kanboard/followers","following_url":"https://api.github.com/users/kanboard/following{/other_user}","gists_url":"https://api.github.com/users/kanboard/gists{/gist_id}","starred_url":"https://api.github.com/users/kanboard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanboard/subscriptions","organizations_url":"https://api.github.com/users/kanboard/orgs","repos_url":"https://api.github.com/users/kanboard/repos","events_url":"https://api.github.com/users/kanboard/events{/privacy}","received_events_url":"https://api.github.com/users/kanboard/received_events","type":"Organization","site_admin":false},"repo":{"id":43036897,"name":"plugin-s3","full_name":"kanboard/plugin-s3","owner":{"login":"kanboard","id":13722943,"avatar_url":"https://avatars.githubusercontent.com/u/13722943?v=3","gravatar_id":"","url":"https://api.github.com/users/kanboard","html_url":"https://github.com/kanboard","followers_url":"https://api.github.com/users/kanboard/followers","following_url":"https://api.github.com/users/kanboard/following{/other_user}","gists_url":"https://api.github.com/users/kanboard/gists{/gist_id}","starred_url":"https://api.github.com/users/kanboard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanboard/subscriptions","organizations_url":"https://api.github.com/users/kanboard/orgs","repos_url":"https://api.github.com/users/kanboard/repos","events_url":"https://api.github.com/users/kanboard/events{/privacy}","received_events_url":"https://api.github.com/users/kanboard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kanboard/plugin-s3","description":"Plugin to store files to Amazon S3","fork":false,"url":"https://api.github.com/repos/kanboard/plugin-s3","forks_url":"https://api.github.com/repos/kanboard/plugin-s3/forks","keys_url":"https://api.github.com/repos/kanboard/plugin-s3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kanboard/plugin-s3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kanboard/plugin-s3/teams","hooks_url":"https://api.github.com/repos/kanboard/plugin-s3/hooks","issue_events_url":"https://api.github.com/repos/kanboard/plugin-s3/issues/events{/number}","events_url":"https://api.github.com/repos/kanboard/plugin-s3/events","assignees_url":"https://api.github.com/repos/kanboard/plugin-s3/assignees{/user}","branches_url":"https://api.github.com/repos/kanboard/plugin-s3/branches{/branch}","tags_url":"https://api.github.com/repos/kanboard/plugin-s3/tags","blobs_url":"https://api.github.com/repos/kanboard/plugin-s3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kanboard/plugin-s3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kanboard/plugin-s3/git/refs{/sha}","trees_url":"https://api.github.com/repos/kanboard/plugin-s3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kanboard/plugin-s3/statuses/{sha}","languages_url":"https://api.github.com/repos/kanboard/plugin-s3/languages","stargazers_url":"https://api.github.com/repos/kanboard/plugin-s3/stargazers","contributors_url":"https://api.github.com/repos/kanboard/plugin-s3/contributors","subscribers_url":"https://api.github.com/repos/kanboard/plugin-s3/subscribers","subscription_url":"https://api.github.com/repos/kanboard/plugin-s3/subscription","commits_url":"https://api.github.com/repos/kanboard/plugin-s3/commits{/sha}","git_commits_url":"https://api.github.com/repos/kanboard/plugin-s3/git/commits{/sha}","comments_url":"https://api.github.com/repos/kanboard/plugin-s3/comments{/number}","issue_comment_url":"https://api.github.com/repos/kanboard/plugin-s3/issues/comments{/number}","contents_url":"https://api.github.com/repos/kanboard/plugin-s3/contents/{+path}","compare_url":"https://api.github.com/repos/kanboard/plugin-s3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kanboard/plugin-s3/merges","archive_url":"https://api.github.com/repos/kanboard/plugin-s3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kanboard/plugin-s3/downloads","issues_url":"https://api.github.com/repos/kanboard/plugin-s3/issues{/number}","pulls_url":"https://api.github.com/repos/kanboard/plugin-s3/pulls{/number}","milestones_url":"https://api.github.com/repos/kanboard/plugin-s3/milestones{/number}","notifications_url":"https://api.github.com/repos/kanboard/plugin-s3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kanboard/plugin-s3/labels{/name}","releases_url":"https://api.github.com/repos/kanboard/plugin-s3/releases{/id}","deployments_url":"https://api.github.com/repos/kanboard/plugin-s3/deployments","created_at":"2015-09-24T01:23:21Z","updated_at":"2016-10-12T01:42:33Z","pushed_at":"2016-10-12T23:38:37Z","git_url":"git://github.com/kanboard/plugin-s3.git","ssh_url":"git@github.com:kanboard/plugin-s3.git","clone_url":"https://github.com/kanboard/plugin-s3.git","svn_url":"https://github.com/kanboard/plugin-s3","homepage":"https://kanboard.net/plugin/s3","size":1567,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kanboard/plugin-s3/pulls/4"},"html":{"href":"https://github.com/kanboard/plugin-s3/pull/4"},"issue":{"href":"https://api.github.com/repos/kanboard/plugin-s3/issues/4"},"comments":{"href":"https://api.github.com/repos/kanboard/plugin-s3/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/kanboard/plugin-s3/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/kanboard/plugin-s3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kanboard/plugin-s3/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/kanboard/plugin-s3/statuses/74ac6fb8b8cbabc44cc42e06f60cd689bcf6f882"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"fguillot","id":323546,"avatar_url":"https://avatars.githubusercontent.com/u/323546?v=3","gravatar_id":"","url":"https://api.github.com/users/fguillot","html_url":"https://github.com/fguillot","followers_url":"https://api.github.com/users/fguillot/followers","following_url":"https://api.github.com/users/fguillot/following{/other_user}","gists_url":"https://api.github.com/users/fguillot/gists{/gist_id}","starred_url":"https://api.github.com/users/fguillot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fguillot/subscriptions","organizations_url":"https://api.github.com/users/fguillot/orgs","repos_url":"https://api.github.com/users/fguillot/repos","events_url":"https://api.github.com/users/fguillot/events{/privacy}","received_events_url":"https://api.github.com/users/fguillot/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"fguillot"}}