{"action":"created","issue":{"url":"https://api.github.com/repos/tc39/test262/issues/642","repository_url":"https://api.github.com/repos/tc39/test262","labels_url":"https://api.github.com/repos/tc39/test262/issues/642/labels{/name}","comments_url":"https://api.github.com/repos/tc39/test262/issues/642/comments","events_url":"https://api.github.com/repos/tc39/test262/issues/642/events","html_url":"https://github.com/tc39/test262/pull/642","id":155618250,"number":642,"title":"Add tests for Intl.getCanonicalLocales","user":{"login":"zbraniecki","id":449986,"avatar_url":"https://avatars.githubusercontent.com/u/449986?v=3","gravatar_id":"","url":"https://api.github.com/users/zbraniecki","html_url":"https://github.com/zbraniecki","followers_url":"https://api.github.com/users/zbraniecki/followers","following_url":"https://api.github.com/users/zbraniecki/following{/other_user}","gists_url":"https://api.github.com/users/zbraniecki/gists{/gist_id}","starred_url":"https://api.github.com/users/zbraniecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbraniecki/subscriptions","organizations_url":"https://api.github.com/users/zbraniecki/orgs","repos_url":"https://api.github.com/users/zbraniecki/repos","events_url":"https://api.github.com/users/zbraniecki/events{/privacy}","received_events_url":"https://api.github.com/users/zbraniecki/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-05-18T22:43:26Z","updated_at":"2016-05-20T06:00:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tc39/test262/pulls/642","html_url":"https://github.com/tc39/test262/pull/642","diff_url":"https://github.com/tc39/test262/pull/642.diff","patch_url":"https://github.com/tc39/test262/pull/642.patch"},"body":"This ports a bunch of tests we wrote for SpiderMonkey implementation into test262 suite - https://dxr.mozilla.org/mozilla-central/source/js/src/tests/Intl\r\n\r\nYou can see background story of why those tests have been chosen here: https://bugzilla.mozilla.org/show_bug.cgi?id=1263040"},"comment":{"url":"https://api.github.com/repos/tc39/test262/issues/comments/220524144","html_url":"https://github.com/tc39/test262/pull/642#issuecomment-220524144","issue_url":"https://api.github.com/repos/tc39/test262/issues/642","id":220524144,"user":{"login":"zbraniecki","id":449986,"avatar_url":"https://avatars.githubusercontent.com/u/449986?v=3","gravatar_id":"","url":"https://api.github.com/users/zbraniecki","html_url":"https://github.com/zbraniecki","followers_url":"https://api.github.com/users/zbraniecki/followers","following_url":"https://api.github.com/users/zbraniecki/following{/other_user}","gists_url":"https://api.github.com/users/zbraniecki/gists{/gist_id}","starred_url":"https://api.github.com/users/zbraniecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbraniecki/subscriptions","organizations_url":"https://api.github.com/users/zbraniecki/orgs","repos_url":"https://api.github.com/users/zbraniecki/repos","events_url":"https://api.github.com/users/zbraniecki/events{/privacy}","received_events_url":"https://api.github.com/users/zbraniecki/received_events","type":"User","site_admin":false},"created_at":"2016-05-20T06:00:10Z","updated_at":"2016-05-20T06:00:10Z","body":"Thanks a lot @leobalter ! It's my first test262 patch, but with the amount of new formatters coming in for 4th ed, I expect to have a lot of tests to write, so it's good to learn :)\r\n\r\nI updated the tests to cover most of the things you listed, but I do have some troubles with the things from step 7 of your list. I'm not sure how to test `HasProperty(O, Pk)` using Proxy, this thing: `locales size and values are not cached, so getting a property can modify the values for the next indexes.` and `ToString operations if kValue is an object (it can change the locales size and values as well)`.\r\n\r\nCan you help me with some mock code or pointers? Thanks!\r\n\r\n"}}
{"actor":{"display_login":"zbraniecki"}}