{"action":"created","comment":{"url":"https://api.github.com/repos/thefrontside/emberx-range-input/pulls/comments/52484867","id":52484867,"diff_hunk":"@@ -61,14 +59,13 @@ export default Ember.Component.extend(PropertyBindings, {\n   value: 0,\n \n   /**\n-   * On any `input` event, copy the numeric value of the DOM element\n-   * onto the `value` property of the component so that it can be\n-   * bound to and from.\n+   * On any `input` event, take the component and the element `value` and send\n+   * it in an action.\n    *\n    * @private\n    */\n-  input: function() {\n-    this.set('value', Number(this.get('element.value')).valueOf());\n+  input() {\n+    this.sendAction('action', this, this.get('element.value'));","path":"addon/components/x-range-input.js","position":39,"original_position":39,"commit_id":"4c9fb066c27c28b2c8384f340b9d3c3b9ab1776d","original_commit_id":"4c9fb066c27c28b2c8384f340b9d3c3b9ab1776d","user":{"login":"cowboyd","id":4205,"avatar_url":"https://avatars.githubusercontent.com/u/4205?v=3","gravatar_id":"","url":"https://api.github.com/users/cowboyd","html_url":"https://github.com/cowboyd","followers_url":"https://api.github.com/users/cowboyd/followers","following_url":"https://api.github.com/users/cowboyd/following{/other_user}","gists_url":"https://api.github.com/users/cowboyd/gists{/gist_id}","starred_url":"https://api.github.com/users/cowboyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cowboyd/subscriptions","organizations_url":"https://api.github.com/users/cowboyd/orgs","repos_url":"https://api.github.com/users/cowboyd/repos","events_url":"https://api.github.com/users/cowboyd/events{/privacy}","received_events_url":"https://api.github.com/users/cowboyd/received_events","type":"User","site_admin":false},"body":"It looks like we're not doing a number conversion anymore, why not?\r\n\r\nAlso, we probably want to still set the `value` property in addition to sending the action. It should still work with 2-way binding, even though it is discouraged. In other words, like a normal Ember input:\r\n\r\n```hbs\r\n<x-range-input min=1 max=11 value=(mut volume)/>\r\n```\r\n\r\nshould still change the `volume` property","created_at":"2016-02-10T16:41:29Z","updated_at":"2016-02-10T16:41:29Z","html_url":"https://github.com/thefrontside/emberx-range-input/pull/6#discussion_r52484867","pull_request_url":"https://api.github.com/repos/thefrontside/emberx-range-input/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/thefrontside/emberx-range-input/pulls/comments/52484867"},"html":{"href":"https://github.com/thefrontside/emberx-range-input/pull/6#discussion_r52484867"},"pull_request":{"href":"https://api.github.com/repos/thefrontside/emberx-range-input/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/thefrontside/emberx-range-input/pulls/6","id":58850698,"html_url":"https://github.com/thefrontside/emberx-range-input/pull/6","diff_url":"https://github.com/thefrontside/emberx-range-input/pull/6.diff","patch_url":"https://github.com/thefrontside/emberx-range-input/pull/6.patch","issue_url":"https://api.github.com/repos/thefrontside/emberx-range-input/issues/6","number":6,"state":"open","locked":false,"title":"Add ddau","user":{"login":"Robdel12","id":2072894,"avatar_url":"https://avatars.githubusercontent.com/u/2072894?v=3","gravatar_id":"","url":"https://api.github.com/users/Robdel12","html_url":"https://github.com/Robdel12","followers_url":"https://api.github.com/users/Robdel12/followers","following_url":"https://api.github.com/users/Robdel12/following{/other_user}","gists_url":"https://api.github.com/users/Robdel12/gists{/gist_id}","starred_url":"https://api.github.com/users/Robdel12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robdel12/subscriptions","organizations_url":"https://api.github.com/users/Robdel12/orgs","repos_url":"https://api.github.com/users/Robdel12/repos","events_url":"https://api.github.com/users/Robdel12/events{/privacy}","received_events_url":"https://api.github.com/users/Robdel12/received_events","type":"User","site_admin":false},"body":"This updates the addon to do data down actions up.","created_at":"2016-02-10T05:55:28Z","updated_at":"2016-02-10T16:41:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5f10359e0a4f03d0e2f8b7d811d9fafcb2cf084","assignee":{"login":"cowboyd","id":4205,"avatar_url":"https://avatars.githubusercontent.com/u/4205?v=3","gravatar_id":"","url":"https://api.github.com/users/cowboyd","html_url":"https://github.com/cowboyd","followers_url":"https://api.github.com/users/cowboyd/followers","following_url":"https://api.github.com/users/cowboyd/following{/other_user}","gists_url":"https://api.github.com/users/cowboyd/gists{/gist_id}","starred_url":"https://api.github.com/users/cowboyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cowboyd/subscriptions","organizations_url":"https://api.github.com/users/cowboyd/orgs","repos_url":"https://api.github.com/users/cowboyd/repos","events_url":"https://api.github.com/users/cowboyd/events{/privacy}","received_events_url":"https://api.github.com/users/cowboyd/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/thefrontside/emberx-range-input/milestones/1","html_url":"https://github.com/thefrontside/emberx-range-input/milestones/V1.0.0","labels_url":"https://api.github.com/repos/thefrontside/emberx-range-input/milestones/1/labels","id":1545225,"number":1,"title":"V1.0.0","description":"","creator":{"login":"Robdel12","id":2072894,"avatar_url":"https://avatars.githubusercontent.com/u/2072894?v=3","gravatar_id":"","url":"https://api.github.com/users/Robdel12","html_url":"https://github.com/Robdel12","followers_url":"https://api.github.com/users/Robdel12/followers","following_url":"https://api.github.com/users/Robdel12/following{/other_user}","gists_url":"https://api.github.com/users/Robdel12/gists{/gist_id}","starred_url":"https://api.github.com/users/Robdel12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robdel12/subscriptions","organizations_url":"https://api.github.com/users/Robdel12/orgs","repos_url":"https://api.github.com/users/Robdel12/repos","events_url":"https://api.github.com/users/Robdel12/events{/privacy}","received_events_url":"https://api.github.com/users/Robdel12/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":1,"state":"open","created_at":"2016-01-26T22:32:47Z","updated_at":"2016-02-10T05:55:29Z","due_on":"2016-02-29T06:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/thefrontside/emberx-range-input/pulls/6/commits","review_comments_url":"https://api.github.com/repos/thefrontside/emberx-range-input/pulls/6/comments","review_comment_url":"https://api.github.com/repos/thefrontside/emberx-range-input/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thefrontside/emberx-range-input/issues/6/comments","statuses_url":"https://api.github.com/repos/thefrontside/emberx-range-input/statuses/4c9fb066c27c28b2c8384f340b9d3c3b9ab1776d","head":{"label":"thefrontside:add_ddau","ref":"add_ddau","sha":"4c9fb066c27c28b2c8384f340b9d3c3b9ab1776d","user":{"login":"thefrontside","id":223096,"avatar_url":"https://avatars.githubusercontent.com/u/223096?v=3","gravatar_id":"","url":"https://api.github.com/users/thefrontside","html_url":"https://github.com/thefrontside","followers_url":"https://api.github.com/users/thefrontside/followers","following_url":"https://api.github.com/users/thefrontside/following{/other_user}","gists_url":"https://api.github.com/users/thefrontside/gists{/gist_id}","starred_url":"https://api.github.com/users/thefrontside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefrontside/subscriptions","organizations_url":"https://api.github.com/users/thefrontside/orgs","repos_url":"https://api.github.com/users/thefrontside/repos","events_url":"https://api.github.com/users/thefrontside/events{/privacy}","received_events_url":"https://api.github.com/users/thefrontside/received_events","type":"Organization","site_admin":false},"repo":{"id":50461994,"name":"emberx-range-input","full_name":"thefrontside/emberx-range-input","owner":{"login":"thefrontside","id":223096,"avatar_url":"https://avatars.githubusercontent.com/u/223096?v=3","gravatar_id":"","url":"https://api.github.com/users/thefrontside","html_url":"https://github.com/thefrontside","followers_url":"https://api.github.com/users/thefrontside/followers","following_url":"https://api.github.com/users/thefrontside/following{/other_user}","gists_url":"https://api.github.com/users/thefrontside/gists{/gist_id}","starred_url":"https://api.github.com/users/thefrontside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefrontside/subscriptions","organizations_url":"https://api.github.com/users/thefrontside/orgs","repos_url":"https://api.github.com/users/thefrontside/repos","events_url":"https://api.github.com/users/thefrontside/events{/privacy}","received_events_url":"https://api.github.com/users/thefrontside/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thefrontside/emberx-range-input","description":"A Slider component for Ember based on the native html5 range input.","fork":false,"url":"https://api.github.com/repos/thefrontside/emberx-range-input","forks_url":"https://api.github.com/repos/thefrontside/emberx-range-input/forks","keys_url":"https://api.github.com/repos/thefrontside/emberx-range-input/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thefrontside/emberx-range-input/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thefrontside/emberx-range-input/teams","hooks_url":"https://api.github.com/repos/thefrontside/emberx-range-input/hooks","issue_events_url":"https://api.github.com/repos/thefrontside/emberx-range-input/issues/events{/number}","events_url":"https://api.github.com/repos/thefrontside/emberx-range-input/events","assignees_url":"https://api.github.com/repos/thefrontside/emberx-range-input/assignees{/user}","branches_url":"https://api.github.com/repos/thefrontside/emberx-range-input/branches{/branch}","tags_url":"https://api.github.com/repos/thefrontside/emberx-range-input/tags","blobs_url":"https://api.github.com/repos/thefrontside/emberx-range-input/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thefrontside/emberx-range-input/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thefrontside/emberx-range-input/git/refs{/sha}","trees_url":"https://api.github.com/repos/thefrontside/emberx-range-input/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thefrontside/emberx-range-input/statuses/{sha}","languages_url":"https://api.github.com/repos/thefrontside/emberx-range-input/languages","stargazers_url":"https://api.github.com/repos/thefrontside/emberx-range-input/stargazers","contributors_url":"https://api.github.com/repos/thefrontside/emberx-range-input/contributors","subscribers_url":"https://api.github.com/repos/thefrontside/emberx-range-input/subscribers","subscription_url":"https://api.github.com/repos/thefrontside/emberx-range-input/subscription","commits_url":"https://api.github.com/repos/thefrontside/emberx-range-input/commits{/sha}","git_commits_url":"https://api.github.com/repos/thefrontside/emberx-range-input/git/commits{/sha}","comments_url":"https://api.github.com/repos/thefrontside/emberx-range-input/comments{/number}","issue_comment_url":"https://api.github.com/repos/thefrontside/emberx-range-input/issues/comments{/number}","contents_url":"https://api.github.com/repos/thefrontside/emberx-range-input/contents/{+path}","compare_url":"https://api.github.com/repos/thefrontside/emberx-range-input/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thefrontside/emberx-range-input/merges","archive_url":"https://api.github.com/repos/thefrontside/emberx-range-input/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thefrontside/emberx-range-input/downloads","issues_url":"https://api.github.com/repos/thefrontside/emberx-range-input/issues{/number}","pulls_url":"https://api.github.com/repos/thefrontside/emberx-range-input/pulls{/number}","milestones_url":"https://api.github.com/repos/thefrontside/emberx-range-input/milestones{/number}","notifications_url":"https://api.github.com/repos/thefrontside/emberx-range-input/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thefrontside/emberx-range-input/labels{/name}","releases_url":"https://api.github.com/repos/thefrontside/emberx-range-input/releases{/id}","deployments_url":"https://api.github.com/repos/thefrontside/emberx-range-input/deployments","created_at":"2016-01-26T21:52:54Z","updated_at":"2016-01-26T22:33:26Z","pushed_at":"2016-02-10T16:35:43Z","git_url":"git://github.com/thefrontside/emberx-range-input.git","ssh_url":"git@github.com:thefrontside/emberx-range-input.git","clone_url":"https://github.com/thefrontside/emberx-range-input.git","svn_url":"https://github.com/thefrontside/emberx-range-input","homepage":"","size":38,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"thefrontside:master","ref":"master","sha":"3d4cbf152bc41c2ca50b08c5fbdeb6d78d5009d0","user":{"login":"thefrontside","id":223096,"avatar_url":"https://avatars.githubusercontent.com/u/223096?v=3","gravatar_id":"","url":"https://api.github.com/users/thefrontside","html_url":"https://github.com/thefrontside","followers_url":"https://api.github.com/users/thefrontside/followers","following_url":"https://api.github.com/users/thefrontside/following{/other_user}","gists_url":"https://api.github.com/users/thefrontside/gists{/gist_id}","starred_url":"https://api.github.com/users/thefrontside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefrontside/subscriptions","organizations_url":"https://api.github.com/users/thefrontside/orgs","repos_url":"https://api.github.com/users/thefrontside/repos","events_url":"https://api.github.com/users/thefrontside/events{/privacy}","received_events_url":"https://api.github.com/users/thefrontside/received_events","type":"Organization","site_admin":false},"repo":{"id":50461994,"name":"emberx-range-input","full_name":"thefrontside/emberx-range-input","owner":{"login":"thefrontside","id":223096,"avatar_url":"https://avatars.githubusercontent.com/u/223096?v=3","gravatar_id":"","url":"https://api.github.com/users/thefrontside","html_url":"https://github.com/thefrontside","followers_url":"https://api.github.com/users/thefrontside/followers","following_url":"https://api.github.com/users/thefrontside/following{/other_user}","gists_url":"https://api.github.com/users/thefrontside/gists{/gist_id}","starred_url":"https://api.github.com/users/thefrontside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefrontside/subscriptions","organizations_url":"https://api.github.com/users/thefrontside/orgs","repos_url":"https://api.github.com/users/thefrontside/repos","events_url":"https://api.github.com/users/thefrontside/events{/privacy}","received_events_url":"https://api.github.com/users/thefrontside/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thefrontside/emberx-range-input","description":"A Slider component for Ember based on the native html5 range input.","fork":false,"url":"https://api.github.com/repos/thefrontside/emberx-range-input","forks_url":"https://api.github.com/repos/thefrontside/emberx-range-input/forks","keys_url":"https://api.github.com/repos/thefrontside/emberx-range-input/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thefrontside/emberx-range-input/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thefrontside/emberx-range-input/teams","hooks_url":"https://api.github.com/repos/thefrontside/emberx-range-input/hooks","issue_events_url":"https://api.github.com/repos/thefrontside/emberx-range-input/issues/events{/number}","events_url":"https://api.github.com/repos/thefrontside/emberx-range-input/events","assignees_url":"https://api.github.com/repos/thefrontside/emberx-range-input/assignees{/user}","branches_url":"https://api.github.com/repos/thefrontside/emberx-range-input/branches{/branch}","tags_url":"https://api.github.com/repos/thefrontside/emberx-range-input/tags","blobs_url":"https://api.github.com/repos/thefrontside/emberx-range-input/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thefrontside/emberx-range-input/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thefrontside/emberx-range-input/git/refs{/sha}","trees_url":"https://api.github.com/repos/thefrontside/emberx-range-input/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thefrontside/emberx-range-input/statuses/{sha}","languages_url":"https://api.github.com/repos/thefrontside/emberx-range-input/languages","stargazers_url":"https://api.github.com/repos/thefrontside/emberx-range-input/stargazers","contributors_url":"https://api.github.com/repos/thefrontside/emberx-range-input/contributors","subscribers_url":"https://api.github.com/repos/thefrontside/emberx-range-input/subscribers","subscription_url":"https://api.github.com/repos/thefrontside/emberx-range-input/subscription","commits_url":"https://api.github.com/repos/thefrontside/emberx-range-input/commits{/sha}","git_commits_url":"https://api.github.com/repos/thefrontside/emberx-range-input/git/commits{/sha}","comments_url":"https://api.github.com/repos/thefrontside/emberx-range-input/comments{/number}","issue_comment_url":"https://api.github.com/repos/thefrontside/emberx-range-input/issues/comments{/number}","contents_url":"https://api.github.com/repos/thefrontside/emberx-range-input/contents/{+path}","compare_url":"https://api.github.com/repos/thefrontside/emberx-range-input/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thefrontside/emberx-range-input/merges","archive_url":"https://api.github.com/repos/thefrontside/emberx-range-input/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thefrontside/emberx-range-input/downloads","issues_url":"https://api.github.com/repos/thefrontside/emberx-range-input/issues{/number}","pulls_url":"https://api.github.com/repos/thefrontside/emberx-range-input/pulls{/number}","milestones_url":"https://api.github.com/repos/thefrontside/emberx-range-input/milestones{/number}","notifications_url":"https://api.github.com/repos/thefrontside/emberx-range-input/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thefrontside/emberx-range-input/labels{/name}","releases_url":"https://api.github.com/repos/thefrontside/emberx-range-input/releases{/id}","deployments_url":"https://api.github.com/repos/thefrontside/emberx-range-input/deployments","created_at":"2016-01-26T21:52:54Z","updated_at":"2016-01-26T22:33:26Z","pushed_at":"2016-02-10T16:35:43Z","git_url":"git://github.com/thefrontside/emberx-range-input.git","ssh_url":"git@github.com:thefrontside/emberx-range-input.git","clone_url":"https://github.com/thefrontside/emberx-range-input.git","svn_url":"https://github.com/thefrontside/emberx-range-input","homepage":"","size":38,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thefrontside/emberx-range-input/pulls/6"},"html":{"href":"https://github.com/thefrontside/emberx-range-input/pull/6"},"issue":{"href":"https://api.github.com/repos/thefrontside/emberx-range-input/issues/6"},"comments":{"href":"https://api.github.com/repos/thefrontside/emberx-range-input/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/thefrontside/emberx-range-input/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/thefrontside/emberx-range-input/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thefrontside/emberx-range-input/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/thefrontside/emberx-range-input/statuses/4c9fb066c27c28b2c8384f340b9d3c3b9ab1776d"}}}}