{"action":"created","issue":{"url":"https://api.github.com/repos/fifengine/fifengine/issues/903","repository_url":"https://api.github.com/repos/fifengine/fifengine","labels_url":"https://api.github.com/repos/fifengine/fifengine/issues/903/labels{/name}","comments_url":"https://api.github.com/repos/fifengine/fifengine/issues/903/comments","events_url":"https://api.github.com/repos/fifengine/fifengine/issues/903/events","html_url":"https://github.com/fifengine/fifengine/issues/903","id":174288269,"number":903,"title":"tinyxml","user":{"login":"jakoch","id":85608,"avatar_url":"https://avatars.githubusercontent.com/u/85608?v=3","gravatar_id":"","url":"https://api.github.com/users/jakoch","html_url":"https://github.com/jakoch","followers_url":"https://api.github.com/users/jakoch/followers","following_url":"https://api.github.com/users/jakoch/following{/other_user}","gists_url":"https://api.github.com/users/jakoch/gists{/gist_id}","starred_url":"https://api.github.com/users/jakoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakoch/subscriptions","organizations_url":"https://api.github.com/users/jakoch/orgs","repos_url":"https://api.github.com/users/jakoch/repos","events_url":"https://api.github.com/users/jakoch/events{/privacy}","received_events_url":"https://api.github.com/users/jakoch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-31T14:28:24Z","updated_at":"2016-08-31T19:04:18Z","closed_at":null,"body":"Hey,\r\n\r\nbecause i arrived at building the TinyXML dependency in the appveyor VS toolchain\r\ni use my chance to raise some questions about it's current state:\r\n\r\nFifengine ships TinyXML v1 - [v2.5.3 internally](https://github.com/fifengine/fifengine/blob/master/engine/core/ext/tinyxml/changes.txt#L256)\r\nThe latest version of TinyXML v1 is [v2.6.2](https://sourceforge.net/projects/tinyxml/files/tinyxml/2.6.2/)\r\nTinyXML v1 is deprecated and unmaintained (latest release 2011-05-15).\r\nIt's time to move...\r\n\r\n- [ ] the dependency is not listed in the wiki\r\n   - please update https://github.com/fifengine/fifengine/wiki/dependencies and add TinyXML v1 there\r\n   - please include a note that this is TinyXML v1 and not TinyXML v2, which is another product line\r\n\r\n- [ ] remove the `engine/core/ext/tinyxml` folder?\r\n  - Question: are you ok, if i remove the interally shipped version of TinyXML?\r\n   - i don't see any significant changes, when compared to the external lib\r\n   - that means, we stop shipping it internally and pull the dependency always externally\r\n\r\n- [ ]  upgrade TinyXML v1 to either TinyXML v2 or RapidXML or PugiXML\r\n  - [ ] which one? \r\n  - [ ] please create a new standalone issue/ticket to track the upgrade process, when you are ready to work on this\r\n\r\nRegards, Jens"},"comment":{"url":"https://api.github.com/repos/fifengine/fifengine/issues/comments/243867158","html_url":"https://github.com/fifengine/fifengine/issues/903#issuecomment-243867158","issue_url":"https://api.github.com/repos/fifengine/fifengine/issues/903","id":243867158,"user":{"login":"vtchill","id":1790219,"avatar_url":"https://avatars.githubusercontent.com/u/1790219?v=3","gravatar_id":"","url":"https://api.github.com/users/vtchill","html_url":"https://github.com/vtchill","followers_url":"https://api.github.com/users/vtchill/followers","following_url":"https://api.github.com/users/vtchill/following{/other_user}","gists_url":"https://api.github.com/users/vtchill/gists{/gist_id}","starred_url":"https://api.github.com/users/vtchill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtchill/subscriptions","organizations_url":"https://api.github.com/users/vtchill/orgs","repos_url":"https://api.github.com/users/vtchill/repos","events_url":"https://api.github.com/users/vtchill/events{/privacy}","received_events_url":"https://api.github.com/users/vtchill/received_events","type":"User","site_admin":false},"created_at":"2016-08-31T19:04:18Z","updated_at":"2016-08-31T19:04:18Z","body":"Agree this is very well done.\r\n\r\nI also agree that moving to tinyXML v2 makes sense. I'm not sure on the level of effort but I think the API has a good amount of change. I think it was only included in ext so that we didn't have to build yet another dependency in the dev kit and have a static library to link to. I am fine with removing and pulling external."}}
{"actor":{"display_login":"vtchill"}}