{"action":"created","comment":{"url":"https://api.github.com/repos/benchflow/drivers-maker/pulls/comments/71989942","id":71989942,"diff_hunk":"@@ -281,19 +251,17 @@ public void kill() throws Exception {\n ","path":"application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java","position":3,"original_position":191,"commit_id":"fce4ce30ff9d80fa0125d3ab4a8ffbaa7fe5350b","original_commit_id":"4d45ed31a5b6729dd2b535005657784ab8198c02","user":{"login":"simonedavico","id":4446853,"avatar_url":"https://avatars.githubusercontent.com/u/4446853?v=3","gravatar_id":"","url":"https://api.github.com/users/simonedavico","html_url":"https://github.com/simonedavico","followers_url":"https://api.github.com/users/simonedavico/followers","following_url":"https://api.github.com/users/simonedavico/following{/other_user}","gists_url":"https://api.github.com/users/simonedavico/gists{/gist_id}","starred_url":"https://api.github.com/users/simonedavico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonedavico/subscriptions","organizations_url":"https://api.github.com/users/simonedavico/orgs","repos_url":"https://api.github.com/users/simonedavico/repos","events_url":"https://api.github.com/users/simonedavico/events{/privacy}","received_events_url":"https://api.github.com/users/simonedavico/received_events","type":"User","site_admin":false},"body":"See [this comment](https://github.com/benchflow/drivers-maker/pull/50#discussion_r71989897).","created_at":"2016-07-24T14:52:52Z","updated_at":"2016-07-24T14:52:52Z","html_url":"https://github.com/benchflow/drivers-maker/pull/50#discussion_r71989942","pull_request_url":"https://api.github.com/repos/benchflow/drivers-maker/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/benchflow/drivers-maker/pulls/comments/71989942"},"html":{"href":"https://github.com/benchflow/drivers-maker/pull/50#discussion_r71989942"},"pull_request":{"href":"https://api.github.com/repos/benchflow/drivers-maker/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/benchflow/drivers-maker/pulls/50","id":78595365,"html_url":"https://github.com/benchflow/drivers-maker/pull/50","diff_url":"https://github.com/benchflow/drivers-maker/pull/50.diff","patch_url":"https://github.com/benchflow/drivers-maker/pull/50.patch","issue_url":"https://api.github.com/repos/benchflow/drivers-maker/issues/50","number":50,"state":"open","locked":false,"title":"Adds monitor resolution","user":{"login":"simonedavico","id":4446853,"avatar_url":"https://avatars.githubusercontent.com/u/4446853?v=3","gravatar_id":"","url":"https://api.github.com/users/simonedavico","html_url":"https://github.com/simonedavico","followers_url":"https://api.github.com/users/simonedavico/followers","following_url":"https://api.github.com/users/simonedavico/following{/other_user}","gists_url":"https://api.github.com/users/simonedavico/gists{/gist_id}","starred_url":"https://api.github.com/users/simonedavico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonedavico/subscriptions","organizations_url":"https://api.github.com/users/simonedavico/orgs","repos_url":"https://api.github.com/users/simonedavico/repos","events_url":"https://api.github.com/users/simonedavico/events{/privacy}","received_events_url":"https://api.github.com/users/simonedavico/received_events","type":"User","site_admin":false},"body":"- Adds BenchFlow monitors resolution in deployment descriptor builder;\r\n- Adds dependency graph for variable resolution between sibling services;\r\n- Adds `volumes_from` dynamic mount support (defaults to `service_name:ro`);\r\n- Updates skeleton driver structure to account for monitors run phases;\r\n- Removes model sources, which are now a [dependency](http://github.com/benchflow/test-definition-model)\r\n- Solves a bug in `WfMSBenchmark` generation.\r\n- TODO @VincenzoFerme:\r\n  - [ ] Check the code with the issues to validate the completeness of the implementation\r\n  - [ ] Check with local notes\r\n  - [ ] _Validate_: benchmark and drivers hierarchy and reuse\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987223%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987227%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987236%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987257%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987288%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987292%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987326%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987335%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987341%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987433%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987441%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987449%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987452%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987457%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987466%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71989792%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71989812%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71989897%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71989903%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71989908%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71989911%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71989930%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71989932%22%2C%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71989938%22%5D%2C%20%22comments%22%3A%20%7B%22Pull%204d45ed31a5b6729dd2b535005657784ab8198c02%20application/src/main/resources/app/drivers/templates/driver/Driver.java%20209%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987288%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Move%20to%20a%20%60startBenchFlowServices%60%20method%22%2C%20%22created_at%22%3A%20%222016-07-24T11%3A45%3A24Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20application/src/main/resources/app/drivers/templates/driver/Driver.java%3AL196-311%22%7D%2C%20%22Pull%204d45ed31a5b6729dd2b535005657784ab8198c02%20application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java%20160%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987441%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22It%20is%20generic%20enough%20to%20be%20placed%20in%20%60HttpBenchmark.java%60%22%2C%20%22created_at%22%3A%20%222016-07-24T11%3A58%3A09Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22See%20%5Bthis%20comment%5D%28https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71989897%29.%22%2C%20%22created_at%22%3A%20%222016-07-24T14%3A50%3A50Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/4446853%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/simonedavico%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java%3AL201-210%22%7D%2C%20%22Pull%204d45ed31a5b6729dd2b535005657784ab8198c02%20application/src/main/resources/app/drivers/templates/driver/Driver.java%20115%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987236%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Move%20to%20a%20%60ServiceInfo.java%60%20file%22%2C%20%22created_at%22%3A%20%222016-07-24T11%3A41%3A14Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20application/src/main/resources/app/drivers/templates/driver/Driver.java%3AL35-192%22%7D%2C%20%22Pull%204d45ed31a5b6729dd2b535005657784ab8198c02%20application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java%20186%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987457%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%60end%60%20and%20%60kill%60%20are%20generic%20enough%20to%20be%20placed%20in%20%60HttpBenchmark.java%60%22%2C%20%22created_at%22%3A%20%222016-07-24T11%3A59%3A39Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22See%20%5Bthis%20comment%5D%28https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71989897%29.%22%2C%20%22created_at%22%3A%20%222016-07-24T14%3A52%3A42Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/4446853%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/simonedavico%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java%3AL214-238%22%7D%2C%20%22Pull%204d45ed31a5b6729dd2b535005657784ab8198c02%20application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java%20172%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987449%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22If%20we%20don%27t%20need%20to%20add%20anything%2C%20I%20guess%20we%20can%20just%20skip%20it%20and%20rely%20on%20the%20superclass%20implementation.%20Is%20it%20right%3F%22%2C%20%22created_at%22%3A%20%222016-07-24T11%3A58%3A55Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22I%20agree.%22%2C%20%22created_at%22%3A%20%222016-07-24T14%3A52%3A20Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/4446853%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/simonedavico%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java%3AL214-238%22%7D%2C%20%22Pull%204d45ed31a5b6729dd2b535005657784ab8198c02%20application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java%20181%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987452%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22It%20is%20generic%20enough%20to%20be%20placed%20in%20%60HttpBenchmark.java%60%22%2C%20%22created_at%22%3A%20%222016-07-24T11%3A59%3A10Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22See%20%5Bthis%20comment%5D%28https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71989897%29.%22%2C%20%22created_at%22%3A%20%222016-07-24T14%3A52%3A30Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/4446853%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/simonedavico%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java%3AL214-238%22%7D%2C%20%22Pull%204d45ed31a5b6729dd2b535005657784ab8198c02%20application/src/main/resources/app/drivers/templates/driver/Driver.java%20392%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987326%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Move%20%60isStarted%28%29%60%2C%20%20to%20a%20%60Utils.java%60%20file%22%2C%20%22created_at%22%3A%20%222016-07-24T11%3A48%3A12Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20application/src/main/resources/app/drivers/templates/driver/Driver.java%3AL196-311%22%7D%2C%20%22Pull%204d45ed31a5b6729dd2b535005657784ab8198c02%20application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java%2067%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71989897%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22There%20seems%20to%20be%20some%20confusion%20regarding%20these%20classes.%20%60WfMSBenchmark.java%60%20and%20%60HttpBenchmark.java%60%20are%20two%20different%20classes%2C%20both%20inheriting%20%60DefaultFabanBenchmark2%60.%20Thus%2C%20this%20method%20goes%20in%20both.%5Cr%5Cn%5Cr%5CnThey%20don%27t%20inherit%20a%20common%20custom%20base%20Benchmark%20class%20because%20it%20would%20be%20much%20more%20troublesome%20to%20generate%20the%20code%20with%20spoon%20%28I%20can%20explain%20the%20technicalities%20in%20private%20if%20you%20want%29.%5Cr%5Cn%22%2C%20%22created_at%22%3A%20%222016-07-24T14%3A49%3A55Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/4446853%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/simonedavico%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java%3AL102-112%22%7D%2C%20%22Pull%204d45ed31a5b6729dd2b535005657784ab8198c02%20application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java%2079%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987433%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22It%20is%20generic%20enough%20to%20be%20placed%20in%20%60HttpBenchmark.java%60%22%2C%20%22created_at%22%3A%20%222016-07-24T11%3A56%3A51Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22See%20%5Bthis%20comment%5D%28https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71989897%29.%22%2C%20%22created_at%22%3A%20%222016-07-24T14%3A50%3A39Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/4446853%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/simonedavico%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java%3AL128-137%22%7D%2C%20%22Pull%204d45ed31a5b6729dd2b535005657784ab8198c02%20application/src/main/resources/app/drivers/templates/driver/Driver.java%20190%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987257%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Move%20to%20a%20%60Utils.java%60%20file%22%2C%20%22created_at%22%3A%20%222016-07-24T11%3A43%3A00Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20application/src/main/resources/app/drivers/templates/driver/Driver.java%3AL35-192%22%7D%2C%20%22Pull%204d45ed31a5b6729dd2b535005657784ab8198c02%20application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java%20191%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987466%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22The%20getter%20and%20setter%20can%20be%20placed%20in%20%60HttpBenchmark.java%60%22%2C%20%22created_at%22%3A%20%222016-07-24T12%3A00%3A13Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java%3AL251-268%22%7D%2C%20%22Pull%204d45ed31a5b6729dd2b535005657784ab8198c02%20application/src/main/resources/app/drivers/templates/driver/Driver.java%20409%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987335%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Move%20to%20a%20%60Utils.java%60%20file%22%2C%20%22created_at%22%3A%20%222016-07-24T11%3A48%3A37Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22Why%20the%20name%20is%20%60Benchmark%60Configuration%3F%22%2C%20%22created_at%22%3A%20%222016-07-24T11%3A49%3A08Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22Because%20it%27s%20the%20configuration%20of%20the%20Faban%20benchmark.%22%2C%20%22created_at%22%3A%20%222016-07-24T14%3A44%3A33Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/4446853%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/simonedavico%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20application/src/main/resources/app/drivers/templates/driver/Driver.java%3AL372-472%22%7D%2C%20%22Pull%204d45ed31a5b6729dd2b535005657784ab8198c02%20application/src/main/resources/app/drivers/templates/driver/Driver.java%2045%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987223%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Move%20to%20a%20%60ServiceInfo.java%60%20file%22%2C%20%22created_at%22%3A%20%222016-07-24T11%3A41%3A03Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%2C%20%7B%22body%22%3A%20%22We%20had%20issues%20with%20classes%20in%20different%20files%20for%20Faban%20benchmarks%2C%20but%20I%20can%20try%20to%20move%20it%20to%20a%20different%20file%20and%20see%20if%20it%20works.%22%2C%20%22created_at%22%3A%20%222016-07-24T14%3A43%3A13Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/4446853%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/simonedavico%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20application/src/main/resources/app/drivers/templates/driver/Driver.java%3AL35-192%22%7D%2C%20%22Pull%204d45ed31a5b6729dd2b535005657784ab8198c02%20application/src/main/resources/app/drivers/templates/driver/Driver.java%20321%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987292%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Move%20to%20a%20%60stopBenchFlowServices%60%20method%22%2C%20%22created_at%22%3A%20%222016-07-24T11%3A46%3A00Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20application/src/main/resources/app/drivers/templates/driver/Driver.java%3AL196-311%22%7D%2C%20%22Pull%204d45ed31a5b6729dd2b535005657784ab8198c02%20application/src/main/resources/app/drivers/templates/driver/Driver.java%2068%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71987227%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Move%20to%20a%20%60ServiceInfo.java%60%20file%22%2C%20%22created_at%22%3A%20%222016-07-24T11%3A41%3A08Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/7163641%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/VincenzoFerme%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20application/src/main/resources/app/drivers/templates/driver/Driver.java%3AL35-192%22%7D%2C%20%22Pull%204d45ed31a5b6729dd2b535005657784ab8198c02%20application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java%2023%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71989903%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22See%20%5Bthis%20comment%5D%28https%3A//github.com/benchflow/drivers-maker/pull/50%23discussion_r71989897%29.%22%2C%20%22created_at%22%3A%20%222016-07-24T14%3A50%3A26Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/4446853%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/simonedavico%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java%3AL24-31%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-Pull 4d45ed31a5b6729dd2b535005657784ab8198c02 application/src/main/resources/app/drivers/templates/driver/Driver.java 45'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/drivers-maker/pull/50#discussion_r71987223'>File: application/src/main/resources/app/drivers/templates/driver/Driver.java:L35-192</a></b>\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Move to a `ServiceInfo.java` file\n- <a href='https://github.com/simonedavico'><img border=0 src='https://avatars.githubusercontent.com/u/4446853?v=3' height=16 width=16'></a> We had issues with classes in different files for Faban benchmarks, but I can try to move it to a different file and see if it works.\n- [ ] <a href='#crh-comment-Pull 4d45ed31a5b6729dd2b535005657784ab8198c02 application/src/main/resources/app/drivers/templates/driver/Driver.java 68'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/drivers-maker/pull/50#discussion_r71987227'>File: application/src/main/resources/app/drivers/templates/driver/Driver.java:L35-192</a></b>\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Move to a `ServiceInfo.java` file\n- [ ] <a href='#crh-comment-Pull 4d45ed31a5b6729dd2b535005657784ab8198c02 application/src/main/resources/app/drivers/templates/driver/Driver.java 115'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/drivers-maker/pull/50#discussion_r71987236'>File: application/src/main/resources/app/drivers/templates/driver/Driver.java:L35-192</a></b>\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Move to a `ServiceInfo.java` file\n- [ ] <a href='#crh-comment-Pull 4d45ed31a5b6729dd2b535005657784ab8198c02 application/src/main/resources/app/drivers/templates/driver/Driver.java 190'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/drivers-maker/pull/50#discussion_r71987257'>File: application/src/main/resources/app/drivers/templates/driver/Driver.java:L35-192</a></b>\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Move to a `Utils.java` file\n- [ ] <a href='#crh-comment-Pull 4d45ed31a5b6729dd2b535005657784ab8198c02 application/src/main/resources/app/drivers/templates/driver/Driver.java 209'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/drivers-maker/pull/50#discussion_r71987288'>File: application/src/main/resources/app/drivers/templates/driver/Driver.java:L196-311</a></b>\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Move to a `startBenchFlowServices` method\n- [ ] <a href='#crh-comment-Pull 4d45ed31a5b6729dd2b535005657784ab8198c02 application/src/main/resources/app/drivers/templates/driver/Driver.java 321'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/drivers-maker/pull/50#discussion_r71987292'>File: application/src/main/resources/app/drivers/templates/driver/Driver.java:L196-311</a></b>\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Move to a `stopBenchFlowServices` method\n- [ ] <a href='#crh-comment-Pull 4d45ed31a5b6729dd2b535005657784ab8198c02 application/src/main/resources/app/drivers/templates/driver/Driver.java 392'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/drivers-maker/pull/50#discussion_r71987326'>File: application/src/main/resources/app/drivers/templates/driver/Driver.java:L196-311</a></b>\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Move `isStarted()`,  to a `Utils.java` file\n- [ ] <a href='#crh-comment-Pull 4d45ed31a5b6729dd2b535005657784ab8198c02 application/src/main/resources/app/drivers/templates/driver/Driver.java 409'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/drivers-maker/pull/50#discussion_r71987335'>File: application/src/main/resources/app/drivers/templates/driver/Driver.java:L372-472</a></b>\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Move to a `Utils.java` file\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> Why the name is `Benchmark`Configuration?\n- <a href='https://github.com/simonedavico'><img border=0 src='https://avatars.githubusercontent.com/u/4446853?v=3' height=16 width=16'></a> Because it's the configuration of the Faban benchmark.\n- [ ] <a href='#crh-comment-Pull 4d45ed31a5b6729dd2b535005657784ab8198c02 application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java 79'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/drivers-maker/pull/50#discussion_r71987433'>File: application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java:L128-137</a></b>\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> It is generic enough to be placed in `HttpBenchmark.java`\n- <a href='https://github.com/simonedavico'><img border=0 src='https://avatars.githubusercontent.com/u/4446853?v=3' height=16 width=16'></a> See [this comment](https://github.com/benchflow/drivers-maker/pull/50#discussion_r71989897).\n- [ ] <a href='#crh-comment-Pull 4d45ed31a5b6729dd2b535005657784ab8198c02 application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java 160'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/drivers-maker/pull/50#discussion_r71987441'>File: application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java:L201-210</a></b>\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> It is generic enough to be placed in `HttpBenchmark.java`\n- <a href='https://github.com/simonedavico'><img border=0 src='https://avatars.githubusercontent.com/u/4446853?v=3' height=16 width=16'></a> See [this comment](https://github.com/benchflow/drivers-maker/pull/50#discussion_r71989897).\n- [ ] <a href='#crh-comment-Pull 4d45ed31a5b6729dd2b535005657784ab8198c02 application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java 172'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/drivers-maker/pull/50#discussion_r71987449'>File: application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java:L214-238</a></b>\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> If we don't need to add anything, I guess we can just skip it and rely on the superclass implementation. Is it right?\n- <a href='https://github.com/simonedavico'><img border=0 src='https://avatars.githubusercontent.com/u/4446853?v=3' height=16 width=16'></a> I agree.\n- [ ] <a href='#crh-comment-Pull 4d45ed31a5b6729dd2b535005657784ab8198c02 application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java 181'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/drivers-maker/pull/50#discussion_r71987452'>File: application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java:L214-238</a></b>\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> It is generic enough to be placed in `HttpBenchmark.java`\n- <a href='https://github.com/simonedavico'><img border=0 src='https://avatars.githubusercontent.com/u/4446853?v=3' height=16 width=16'></a> See [this comment](https://github.com/benchflow/drivers-maker/pull/50#discussion_r71989897).\n- [ ] <a href='#crh-comment-Pull 4d45ed31a5b6729dd2b535005657784ab8198c02 application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java 186'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/drivers-maker/pull/50#discussion_r71987457'>File: application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java:L214-238</a></b>\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> `end` and `kill` are generic enough to be placed in `HttpBenchmark.java`\n- <a href='https://github.com/simonedavico'><img border=0 src='https://avatars.githubusercontent.com/u/4446853?v=3' height=16 width=16'></a> See [this comment](https://github.com/benchflow/drivers-maker/pull/50#discussion_r71989897).\n- [ ] <a href='#crh-comment-Pull 4d45ed31a5b6729dd2b535005657784ab8198c02 application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java 191'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/drivers-maker/pull/50#discussion_r71987466'>File: application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java:L251-268</a></b>\n- <a href='https://github.com/VincenzoFerme'><img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'></a> The getter and setter can be placed in `HttpBenchmark.java`\n- [ ] <a href='#crh-comment-Pull 4d45ed31a5b6729dd2b535005657784ab8198c02 application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java 67'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/drivers-maker/pull/50#discussion_r71989897'>File: application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java:L102-112</a></b>\n- <a href='https://github.com/simonedavico'><img border=0 src='https://avatars.githubusercontent.com/u/4446853?v=3' height=16 width=16'></a> There seems to be some confusion regarding these classes. `WfMSBenchmark.java` and `HttpBenchmark.java` are two different classes, both inheriting `DefaultFabanBenchmark2`. Thus, this method goes in both.\nThey don't inherit a common custom base Benchmark class because it would be much more troublesome to generate the code with spoon (I can explain the technicalities in private if you want).\n- [ ] <a href='#crh-comment-Pull 4d45ed31a5b6729dd2b535005657784ab8198c02 application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java 23'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/benchflow/drivers-maker/pull/50#discussion_r71989903'>File: application/src/main/resources/app/drivers/templates/harness/wfms/WfMSBenchmark.java:L24-31</a></b>\n- <a href='https://github.com/simonedavico'><img border=0 src='https://avatars.githubusercontent.com/u/4446853?v=3' height=16 width=16'></a> See [this comment](https://github.com/benchflow/drivers-maker/pull/50#discussion_r71989897).\n\n\n<a href='https://www.codereviewhub.com/benchflow/drivers-maker/pull/50?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/benchflow/drivers-maker/pull/50?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/benchflow/drivers-maker/pull/50'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2016-07-24T10:50:14Z","updated_at":"2016-07-24T14:52:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5010f0695b93ec23e8bffcbf047ed8e159992bac","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/benchflow/drivers-maker/pulls/50/commits","review_comments_url":"https://api.github.com/repos/benchflow/drivers-maker/pulls/50/comments","review_comment_url":"https://api.github.com/repos/benchflow/drivers-maker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/benchflow/drivers-maker/issues/50/comments","statuses_url":"https://api.github.com/repos/benchflow/drivers-maker/statuses/fce4ce30ff9d80fa0125d3ab4a8ffbaa7fe5350b","head":{"label":"simonedavico:monitor-implementation","ref":"monitor-implementation","sha":"fce4ce30ff9d80fa0125d3ab4a8ffbaa7fe5350b","user":{"login":"simonedavico","id":4446853,"avatar_url":"https://avatars.githubusercontent.com/u/4446853?v=3","gravatar_id":"","url":"https://api.github.com/users/simonedavico","html_url":"https://github.com/simonedavico","followers_url":"https://api.github.com/users/simonedavico/followers","following_url":"https://api.github.com/users/simonedavico/following{/other_user}","gists_url":"https://api.github.com/users/simonedavico/gists{/gist_id}","starred_url":"https://api.github.com/users/simonedavico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonedavico/subscriptions","organizations_url":"https://api.github.com/users/simonedavico/orgs","repos_url":"https://api.github.com/users/simonedavico/repos","events_url":"https://api.github.com/users/simonedavico/events{/privacy}","received_events_url":"https://api.github.com/users/simonedavico/received_events","type":"User","site_admin":false},"repo":{"id":48614387,"name":"faban-drivers-maker","full_name":"simonedavico/faban-drivers-maker","owner":{"login":"simonedavico","id":4446853,"avatar_url":"https://avatars.githubusercontent.com/u/4446853?v=3","gravatar_id":"","url":"https://api.github.com/users/simonedavico","html_url":"https://github.com/simonedavico","followers_url":"https://api.github.com/users/simonedavico/followers","following_url":"https://api.github.com/users/simonedavico/following{/other_user}","gists_url":"https://api.github.com/users/simonedavico/gists{/gist_id}","starred_url":"https://api.github.com/users/simonedavico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonedavico/subscriptions","organizations_url":"https://api.github.com/users/simonedavico/orgs","repos_url":"https://api.github.com/users/simonedavico/repos","events_url":"https://api.github.com/users/simonedavico/events{/privacy}","received_events_url":"https://api.github.com/users/simonedavico/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simonedavico/faban-drivers-maker","description":"Generates Faban drivers from the BenchFlow benchmark definition","fork":true,"url":"https://api.github.com/repos/simonedavico/faban-drivers-maker","forks_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/forks","keys_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/teams","hooks_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/hooks","issue_events_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/issues/events{/number}","events_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/events","assignees_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/assignees{/user}","branches_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/branches{/branch}","tags_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/tags","blobs_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/git/refs{/sha}","trees_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/statuses/{sha}","languages_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/languages","stargazers_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/stargazers","contributors_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/contributors","subscribers_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/subscribers","subscription_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/subscription","commits_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/commits{/sha}","git_commits_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/git/commits{/sha}","comments_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/comments{/number}","issue_comment_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/issues/comments{/number}","contents_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/contents/{+path}","compare_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/merges","archive_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/downloads","issues_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/issues{/number}","pulls_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/pulls{/number}","milestones_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/milestones{/number}","notifications_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/labels{/name}","releases_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/releases{/id}","deployments_url":"https://api.github.com/repos/simonedavico/faban-drivers-maker/deployments","created_at":"2015-12-26T15:04:33Z","updated_at":"2016-02-14T09:08:43Z","pushed_at":"2016-07-24T14:40:17Z","git_url":"git://github.com/simonedavico/faban-drivers-maker.git","ssh_url":"git@github.com:simonedavico/faban-drivers-maker.git","clone_url":"https://github.com/simonedavico/faban-drivers-maker.git","svn_url":"https://github.com/simonedavico/faban-drivers-maker","homepage":null,"size":2631,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"benchflow:dev","ref":"dev","sha":"7dc5674181236bc83c0db64b617fc94c24f3521e","user":{"login":"benchflow","id":11681613,"avatar_url":"https://avatars.githubusercontent.com/u/11681613?v=3","gravatar_id":"","url":"https://api.github.com/users/benchflow","html_url":"https://github.com/benchflow","followers_url":"https://api.github.com/users/benchflow/followers","following_url":"https://api.github.com/users/benchflow/following{/other_user}","gists_url":"https://api.github.com/users/benchflow/gists{/gist_id}","starred_url":"https://api.github.com/users/benchflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benchflow/subscriptions","organizations_url":"https://api.github.com/users/benchflow/orgs","repos_url":"https://api.github.com/users/benchflow/repos","events_url":"https://api.github.com/users/benchflow/events{/privacy}","received_events_url":"https://api.github.com/users/benchflow/received_events","type":"Organization","site_admin":false},"repo":{"id":47876137,"name":"drivers-maker","full_name":"benchflow/drivers-maker","owner":{"login":"benchflow","id":11681613,"avatar_url":"https://avatars.githubusercontent.com/u/11681613?v=3","gravatar_id":"","url":"https://api.github.com/users/benchflow","html_url":"https://github.com/benchflow","followers_url":"https://api.github.com/users/benchflow/followers","following_url":"https://api.github.com/users/benchflow/following{/other_user}","gists_url":"https://api.github.com/users/benchflow/gists{/gist_id}","starred_url":"https://api.github.com/users/benchflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benchflow/subscriptions","organizations_url":"https://api.github.com/users/benchflow/orgs","repos_url":"https://api.github.com/users/benchflow/repos","events_url":"https://api.github.com/users/benchflow/events{/privacy}","received_events_url":"https://api.github.com/users/benchflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/benchflow/drivers-maker","description":"Generates BenchFlow drivers from the BenchFlow test definition","fork":false,"url":"https://api.github.com/repos/benchflow/drivers-maker","forks_url":"https://api.github.com/repos/benchflow/drivers-maker/forks","keys_url":"https://api.github.com/repos/benchflow/drivers-maker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benchflow/drivers-maker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benchflow/drivers-maker/teams","hooks_url":"https://api.github.com/repos/benchflow/drivers-maker/hooks","issue_events_url":"https://api.github.com/repos/benchflow/drivers-maker/issues/events{/number}","events_url":"https://api.github.com/repos/benchflow/drivers-maker/events","assignees_url":"https://api.github.com/repos/benchflow/drivers-maker/assignees{/user}","branches_url":"https://api.github.com/repos/benchflow/drivers-maker/branches{/branch}","tags_url":"https://api.github.com/repos/benchflow/drivers-maker/tags","blobs_url":"https://api.github.com/repos/benchflow/drivers-maker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benchflow/drivers-maker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benchflow/drivers-maker/git/refs{/sha}","trees_url":"https://api.github.com/repos/benchflow/drivers-maker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benchflow/drivers-maker/statuses/{sha}","languages_url":"https://api.github.com/repos/benchflow/drivers-maker/languages","stargazers_url":"https://api.github.com/repos/benchflow/drivers-maker/stargazers","contributors_url":"https://api.github.com/repos/benchflow/drivers-maker/contributors","subscribers_url":"https://api.github.com/repos/benchflow/drivers-maker/subscribers","subscription_url":"https://api.github.com/repos/benchflow/drivers-maker/subscription","commits_url":"https://api.github.com/repos/benchflow/drivers-maker/commits{/sha}","git_commits_url":"https://api.github.com/repos/benchflow/drivers-maker/git/commits{/sha}","comments_url":"https://api.github.com/repos/benchflow/drivers-maker/comments{/number}","issue_comment_url":"https://api.github.com/repos/benchflow/drivers-maker/issues/comments{/number}","contents_url":"https://api.github.com/repos/benchflow/drivers-maker/contents/{+path}","compare_url":"https://api.github.com/repos/benchflow/drivers-maker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benchflow/drivers-maker/merges","archive_url":"https://api.github.com/repos/benchflow/drivers-maker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benchflow/drivers-maker/downloads","issues_url":"https://api.github.com/repos/benchflow/drivers-maker/issues{/number}","pulls_url":"https://api.github.com/repos/benchflow/drivers-maker/pulls{/number}","milestones_url":"https://api.github.com/repos/benchflow/drivers-maker/milestones{/number}","notifications_url":"https://api.github.com/repos/benchflow/drivers-maker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benchflow/drivers-maker/labels{/name}","releases_url":"https://api.github.com/repos/benchflow/drivers-maker/releases{/id}","deployments_url":"https://api.github.com/repos/benchflow/drivers-maker/deployments","created_at":"2015-12-12T11:49:20Z","updated_at":"2016-07-09T14:25:50Z","pushed_at":"2016-07-24T14:40:18Z","git_url":"git://github.com/benchflow/drivers-maker.git","ssh_url":"git@github.com:benchflow/drivers-maker.git","clone_url":"https://github.com/benchflow/drivers-maker.git","svn_url":"https://github.com/benchflow/drivers-maker","homepage":"","size":2516,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":25,"forks":1,"open_issues":25,"watchers":0,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/benchflow/drivers-maker/pulls/50"},"html":{"href":"https://github.com/benchflow/drivers-maker/pull/50"},"issue":{"href":"https://api.github.com/repos/benchflow/drivers-maker/issues/50"},"comments":{"href":"https://api.github.com/repos/benchflow/drivers-maker/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/benchflow/drivers-maker/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/benchflow/drivers-maker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/benchflow/drivers-maker/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/benchflow/drivers-maker/statuses/fce4ce30ff9d80fa0125d3ab4a8ffbaa7fe5350b"}}}}
{"actor":{"display_login":"simonedavico"}}