{"action":"created","issue":{"url":"https://api.github.com/repos/wifidog/wifidog-gateway/issues/263","repository_url":"https://api.github.com/repos/wifidog/wifidog-gateway","labels_url":"https://api.github.com/repos/wifidog/wifidog-gateway/issues/263/labels{/name}","comments_url":"https://api.github.com/repos/wifidog/wifidog-gateway/issues/263/comments","events_url":"https://api.github.com/repos/wifidog/wifidog-gateway/issues/263/events","html_url":"https://github.com/wifidog/wifidog-gateway/issues/263","id":179156842,"number":263,"title":"src/gateway.c line 370","user":{"login":"fbichina","id":20812285,"avatar_url":"https://avatars.githubusercontent.com/u/20812285?v=3","gravatar_id":"","url":"https://api.github.com/users/fbichina","html_url":"https://github.com/fbichina","followers_url":"https://api.github.com/users/fbichina/followers","following_url":"https://api.github.com/users/fbichina/following{/other_user}","gists_url":"https://api.github.com/users/fbichina/gists{/gist_id}","starred_url":"https://api.github.com/users/fbichina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbichina/subscriptions","organizations_url":"https://api.github.com/users/fbichina/orgs","repos_url":"https://api.github.com/users/fbichina/repos","events_url":"https://api.github.com/users/fbichina/events{/privacy}","received_events_url":"https://api.github.com/users/fbichina/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-09-26T07:26:17Z","updated_at":"2016-10-20T08:05:17Z","closed_at":null,"body":"Line 370 in src/gateway.c\r\n\"if ((!config) && (!config->pidfile))\"\r\nIsn't it wired to write this ???"},"comment":{"url":"https://api.github.com/repos/wifidog/wifidog-gateway/issues/comments/255037033","html_url":"https://github.com/wifidog/wifidog-gateway/issues/263#issuecomment-255037033","issue_url":"https://api.github.com/repos/wifidog/wifidog-gateway/issues/263","id":255037033,"user":{"login":"poolborges","id":1090723,"avatar_url":"https://avatars.githubusercontent.com/u/1090723?v=3","gravatar_id":"","url":"https://api.github.com/users/poolborges","html_url":"https://github.com/poolborges","followers_url":"https://api.github.com/users/poolborges/followers","following_url":"https://api.github.com/users/poolborges/following{/other_user}","gists_url":"https://api.github.com/users/poolborges/gists{/gist_id}","starred_url":"https://api.github.com/users/poolborges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poolborges/subscriptions","organizations_url":"https://api.github.com/users/poolborges/orgs","repos_url":"https://api.github.com/users/poolborges/repos","events_url":"https://api.github.com/users/poolborges/events{/privacy}","received_events_url":"https://api.github.com/users/poolborges/received_events","type":"User","site_admin":false},"created_at":"2016-10-20T08:05:17Z","updated_at":"2016-10-20T08:05:17Z","body":"That condition is not valid when only pid is null. \r\nSo it must have a or between righ side and left side\r\nWe read: when conf is null ou pid is null do something.\r\nif ((!config) || (!config->pidfile))\r\n\r\nThe code will be better to read if is write li this\r\n\r\nif ((config == NULL) || (config->pidfile || NUL))\r\n\r\n"}}
{"actor":{"display_login":"poolborges"}}