{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/84586014","pull_request_review_id":5356836,"id":84586014,"diff_hunk":"@@ -737,7 +737,194 @@ ${helpers.single_keyword(\"text-align-last\",\n     }\n </%helpers:longhand>\n \n+<%helpers:longhand name=\"text-emphasis-style\" products=\"gecko\" need_clone=\"True\" animatable=\"False\">\n+    use computed_values::writing_mode::T as writing_mode;\n+    use cssparser::ToCss;\n+    use std::fmt;\n+    use values::LocalToCss;\n+    use values::NoViewportPercentage;\n+\n+    impl NoViewportPercentage for SpecifiedValue {}\n+\n+    pub mod computed_value {\n+        #[derive(Debug, Clone, PartialEq)]\n+        #[cfg_attr(feature = \"servo\", derive(HeapSizeOf))]\n+        pub enum T {\n+            Keyword(Keyword),\n+            None,\n+            String(String),\n+        }\n+\n+        #[derive(Debug, Clone, PartialEq)]\n+        #[cfg_attr(feature = \"servo\", derive(HeapSizeOf))]\n+        pub struct Keyword {","path":"components/style/properties/longhand/inherited_text.mako.rs","position":24,"original_position":24,"commit_id":"769129f5c23dcd86a34ea6a2ae6311875bb80e1c","original_commit_id":"769129f5c23dcd86a34ea6a2ae6311875bb80e1c","user":{"login":"emilio","id":1323194,"avatar_url":"https://avatars.githubusercontent.com/u/1323194?v=3","gravatar_id":"","url":"https://api.github.com/users/emilio","html_url":"https://github.com/emilio","followers_url":"https://api.github.com/users/emilio/followers","following_url":"https://api.github.com/users/emilio/following{/other_user}","gists_url":"https://api.github.com/users/emilio/gists{/gist_id}","starred_url":"https://api.github.com/users/emilio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilio/subscriptions","organizations_url":"https://api.github.com/users/emilio/orgs","repos_url":"https://api.github.com/users/emilio/repos","events_url":"https://api.github.com/users/emilio/events{/privacy}","received_events_url":"https://api.github.com/users/emilio/received_events","type":"User","site_admin":false},"body":"Similarly, I wouldn't call `Keyword` to the computed value, maybe `KeywordValue` is a better choice?","created_at":"2016-10-22T21:52:36Z","updated_at":"2016-10-22T21:52:36Z","html_url":"https://github.com/servo/servo/pull/13860#discussion_r84586014","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/13860","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/84586014"},"html":{"href":"https://github.com/servo/servo/pull/13860#discussion_r84586014"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/13860"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/13860","id":90266135,"html_url":"https://github.com/servo/servo/pull/13860","diff_url":"https://github.com/servo/servo/pull/13860.diff","patch_url":"https://github.com/servo/servo/pull/13860.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/13860","number":13860,"state":"open","locked":false,"title":"Implement parsing/serialization and gecko glue for text-emphasis-style","user":{"login":"canaltinova","id":466239,"avatar_url":"https://avatars.githubusercontent.com/u/466239?v=3","gravatar_id":"","url":"https://api.github.com/users/canaltinova","html_url":"https://github.com/canaltinova","followers_url":"https://api.github.com/users/canaltinova/followers","following_url":"https://api.github.com/users/canaltinova/following{/other_user}","gists_url":"https://api.github.com/users/canaltinova/gists{/gist_id}","starred_url":"https://api.github.com/users/canaltinova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canaltinova/subscriptions","organizations_url":"https://api.github.com/users/canaltinova/orgs","repos_url":"https://api.github.com/users/canaltinova/repos","events_url":"https://api.github.com/users/canaltinova/events{/privacy}","received_events_url":"https://api.github.com/users/canaltinova/received_events","type":"User","site_admin":false},"body":"<!-- Please describe your changes on the following line: -->\r\nImplementation of parsing/serialization and gecko glue for text-emphasis-style.\r\n\r\nr? @Manishearth \r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [X] These changes fix #13853 (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [X] There are tests for these changes\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/13860)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-10-20T19:33:29Z","updated_at":"2016-10-22T21:53:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c42933a978fc677f875e17915f531d817315d57c","assignee":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"assignees":[{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/13860/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/13860/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/13860/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/769129f5c23dcd86a34ea6a2ae6311875bb80e1c","head":{"label":"canaltinova:text-emphasis-style","ref":"text-emphasis-style","sha":"769129f5c23dcd86a34ea6a2ae6311875bb80e1c","user":{"login":"canaltinova","id":466239,"avatar_url":"https://avatars.githubusercontent.com/u/466239?v=3","gravatar_id":"","url":"https://api.github.com/users/canaltinova","html_url":"https://github.com/canaltinova","followers_url":"https://api.github.com/users/canaltinova/followers","following_url":"https://api.github.com/users/canaltinova/following{/other_user}","gists_url":"https://api.github.com/users/canaltinova/gists{/gist_id}","starred_url":"https://api.github.com/users/canaltinova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canaltinova/subscriptions","organizations_url":"https://api.github.com/users/canaltinova/orgs","repos_url":"https://api.github.com/users/canaltinova/repos","events_url":"https://api.github.com/users/canaltinova/events{/privacy}","received_events_url":"https://api.github.com/users/canaltinova/received_events","type":"User","site_admin":false},"repo":{"id":54825367,"name":"servo","full_name":"canaltinova/servo","owner":{"login":"canaltinova","id":466239,"avatar_url":"https://avatars.githubusercontent.com/u/466239?v=3","gravatar_id":"","url":"https://api.github.com/users/canaltinova","html_url":"https://github.com/canaltinova","followers_url":"https://api.github.com/users/canaltinova/followers","following_url":"https://api.github.com/users/canaltinova/following{/other_user}","gists_url":"https://api.github.com/users/canaltinova/gists{/gist_id}","starred_url":"https://api.github.com/users/canaltinova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canaltinova/subscriptions","organizations_url":"https://api.github.com/users/canaltinova/orgs","repos_url":"https://api.github.com/users/canaltinova/repos","events_url":"https://api.github.com/users/canaltinova/events{/privacy}","received_events_url":"https://api.github.com/users/canaltinova/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/canaltinova/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/canaltinova/servo","forks_url":"https://api.github.com/repos/canaltinova/servo/forks","keys_url":"https://api.github.com/repos/canaltinova/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canaltinova/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canaltinova/servo/teams","hooks_url":"https://api.github.com/repos/canaltinova/servo/hooks","issue_events_url":"https://api.github.com/repos/canaltinova/servo/issues/events{/number}","events_url":"https://api.github.com/repos/canaltinova/servo/events","assignees_url":"https://api.github.com/repos/canaltinova/servo/assignees{/user}","branches_url":"https://api.github.com/repos/canaltinova/servo/branches{/branch}","tags_url":"https://api.github.com/repos/canaltinova/servo/tags","blobs_url":"https://api.github.com/repos/canaltinova/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canaltinova/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canaltinova/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/canaltinova/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canaltinova/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/canaltinova/servo/languages","stargazers_url":"https://api.github.com/repos/canaltinova/servo/stargazers","contributors_url":"https://api.github.com/repos/canaltinova/servo/contributors","subscribers_url":"https://api.github.com/repos/canaltinova/servo/subscribers","subscription_url":"https://api.github.com/repos/canaltinova/servo/subscription","commits_url":"https://api.github.com/repos/canaltinova/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/canaltinova/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/canaltinova/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/canaltinova/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/canaltinova/servo/contents/{+path}","compare_url":"https://api.github.com/repos/canaltinova/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canaltinova/servo/merges","archive_url":"https://api.github.com/repos/canaltinova/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canaltinova/servo/downloads","issues_url":"https://api.github.com/repos/canaltinova/servo/issues{/number}","pulls_url":"https://api.github.com/repos/canaltinova/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/canaltinova/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/canaltinova/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canaltinova/servo/labels{/name}","releases_url":"https://api.github.com/repos/canaltinova/servo/releases{/id}","deployments_url":"https://api.github.com/repos/canaltinova/servo/deployments","created_at":"2016-03-27T11:29:49Z","updated_at":"2016-03-27T11:04:18Z","pushed_at":"2016-10-22T16:38:31Z","git_url":"git://github.com/canaltinova/servo.git","ssh_url":"git@github.com:canaltinova/servo.git","clone_url":"https://github.com/canaltinova/servo.git","svn_url":"https://github.com/canaltinova/servo","homepage":"https://servo.org/","size":212301,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"62689ba64deb5f0c93f2fe3dfd69258b21d2fb47","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2016-10-22T16:09:03Z","pushed_at":"2016-10-22T21:23:52Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":302881,"stargazers_count":8092,"watchers_count":8092,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1319,"mirror_url":null,"open_issues_count":1856,"forks":1319,"open_issues":1856,"watchers":8092,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/13860"},"html":{"href":"https://github.com/servo/servo/pull/13860"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/13860"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/13860/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/13860/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/13860/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/769129f5c23dcd86a34ea6a2ae6311875bb80e1c"}}}}
{"actor":{"display_login":"emilio"}}