{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/54979752","id":54979752,"diff_hunk":"@@ -858,9 +859,12 @@ class AsyncEnd2endServerTryCancelTest : public AsyncEnd2endTest {\n \n     bool expected_server_cq_result = true;\n     bool ignore_cq_result = false;\n+    bool want_done_tag = false;\n \n     if (server_try_cancel == CANCEL_BEFORE_PROCESSING) {\n-      ServerTryCancel(&srv_ctx);\n+      srv_ctx.TryCancel();\n+      Verifier(GetParam()).Expect(11, true).Verify(cq_.get());","path":"test/cpp/end2end/async_end2end_test.cc","position":119,"original_position":104,"commit_id":"dbf47fabd406b51e8d3d03c5eb06c5fe6f7d0d5d","original_commit_id":"13ee2f2df3ded81d096a1440a0f273eeece6a2cc","user":{"login":"sreecha","id":2754995,"avatar_url":"https://avatars.githubusercontent.com/u/2754995?v=3","gravatar_id":"","url":"https://api.github.com/users/sreecha","html_url":"https://github.com/sreecha","followers_url":"https://api.github.com/users/sreecha/followers","following_url":"https://api.github.com/users/sreecha/following{/other_user}","gists_url":"https://api.github.com/users/sreecha/gists{/gist_id}","starred_url":"https://api.github.com/users/sreecha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sreecha/subscriptions","organizations_url":"https://api.github.com/users/sreecha/orgs","repos_url":"https://api.github.com/users/sreecha/repos","events_url":"https://api.github.com/users/sreecha/events{/privacy}","received_events_url":"https://api.github.com/users/sreecha/received_events","type":"User","site_admin":false},"body":"Ok. No strong reason. Just that one might wonder why this is being treated as a special case :).\r\n Actually the CANCEL_*_PROCESSING states are all mutually exclusive.. So there shouldn't be any sharing of state between those cases. I don't feel strongly about and its up to you..","created_at":"2016-03-04T01:41:43Z","updated_at":"2016-03-04T01:41:43Z","html_url":"https://github.com/grpc/grpc/pull/5572#discussion_r54979752","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/5572","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/54979752"},"html":{"href":"https://github.com/grpc/grpc/pull/5572#discussion_r54979752"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/5572"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/5572","id":61632520,"html_url":"https://github.com/grpc/grpc/pull/5572","diff_url":"https://github.com/grpc/grpc/pull/5572.diff","patch_url":"https://github.com/grpc/grpc/pull/5572.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/5572","number":5572,"state":"open","locked":false,"title":"Properly integrate async API with server-side cancellations.","user":{"login":"vjpai","id":8864912,"avatar_url":"https://avatars.githubusercontent.com/u/8864912?v=3","gravatar_id":"","url":"https://api.github.com/users/vjpai","html_url":"https://github.com/vjpai","followers_url":"https://api.github.com/users/vjpai/followers","following_url":"https://api.github.com/users/vjpai/following{/other_user}","gists_url":"https://api.github.com/users/vjpai/gists{/gist_id}","starred_url":"https://api.github.com/users/vjpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjpai/subscriptions","organizations_url":"https://api.github.com/users/vjpai/orgs","repos_url":"https://api.github.com/users/vjpai/repos","events_url":"https://api.github.com/users/vjpai/events{/privacy}","received_events_url":"https://api.github.com/users/vjpai/received_events","type":"User","site_admin":false},"body":"There is a comment above IsCancelled that says when it is ok to use this.\r\n\r\nWould also appreciate eyes from @ctiller \r\n","created_at":"2016-03-03T21:59:22Z","updated_at":"2016-03-04T01:41:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"134b9a56c64b79fc8e2d0c68adb069f942022b00","assignee":{"login":"sreecha","id":2754995,"avatar_url":"https://avatars.githubusercontent.com/u/2754995?v=3","gravatar_id":"","url":"https://api.github.com/users/sreecha","html_url":"https://github.com/sreecha","followers_url":"https://api.github.com/users/sreecha/followers","following_url":"https://api.github.com/users/sreecha/following{/other_user}","gists_url":"https://api.github.com/users/sreecha/gists{/gist_id}","starred_url":"https://api.github.com/users/sreecha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sreecha/subscriptions","organizations_url":"https://api.github.com/users/sreecha/orgs","repos_url":"https://api.github.com/users/sreecha/repos","events_url":"https://api.github.com/users/sreecha/events{/privacy}","received_events_url":"https://api.github.com/users/sreecha/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/5572/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/5572/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/5572/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/dbf47fabd406b51e8d3d03c5eb06c5fe6f7d0d5d","head":{"label":"vjpai:srv_ctx","ref":"srv_ctx","sha":"dbf47fabd406b51e8d3d03c5eb06c5fe6f7d0d5d","user":{"login":"vjpai","id":8864912,"avatar_url":"https://avatars.githubusercontent.com/u/8864912?v=3","gravatar_id":"","url":"https://api.github.com/users/vjpai","html_url":"https://github.com/vjpai","followers_url":"https://api.github.com/users/vjpai/followers","following_url":"https://api.github.com/users/vjpai/following{/other_user}","gists_url":"https://api.github.com/users/vjpai/gists{/gist_id}","starred_url":"https://api.github.com/users/vjpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjpai/subscriptions","organizations_url":"https://api.github.com/users/vjpai/orgs","repos_url":"https://api.github.com/users/vjpai/repos","events_url":"https://api.github.com/users/vjpai/events{/privacy}","received_events_url":"https://api.github.com/users/vjpai/received_events","type":"User","site_admin":false},"repo":{"id":43449564,"name":"grpc","full_name":"vjpai/grpc","owner":{"login":"vjpai","id":8864912,"avatar_url":"https://avatars.githubusercontent.com/u/8864912?v=3","gravatar_id":"","url":"https://api.github.com/users/vjpai","html_url":"https://github.com/vjpai","followers_url":"https://api.github.com/users/vjpai/followers","following_url":"https://api.github.com/users/vjpai/following{/other_user}","gists_url":"https://api.github.com/users/vjpai/gists{/gist_id}","starred_url":"https://api.github.com/users/vjpai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjpai/subscriptions","organizations_url":"https://api.github.com/users/vjpai/orgs","repos_url":"https://api.github.com/users/vjpai/repos","events_url":"https://api.github.com/users/vjpai/events{/privacy}","received_events_url":"https://api.github.com/users/vjpai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vjpai/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/vjpai/grpc","forks_url":"https://api.github.com/repos/vjpai/grpc/forks","keys_url":"https://api.github.com/repos/vjpai/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vjpai/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vjpai/grpc/teams","hooks_url":"https://api.github.com/repos/vjpai/grpc/hooks","issue_events_url":"https://api.github.com/repos/vjpai/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/vjpai/grpc/events","assignees_url":"https://api.github.com/repos/vjpai/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/vjpai/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/vjpai/grpc/tags","blobs_url":"https://api.github.com/repos/vjpai/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vjpai/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vjpai/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/vjpai/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vjpai/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/vjpai/grpc/languages","stargazers_url":"https://api.github.com/repos/vjpai/grpc/stargazers","contributors_url":"https://api.github.com/repos/vjpai/grpc/contributors","subscribers_url":"https://api.github.com/repos/vjpai/grpc/subscribers","subscription_url":"https://api.github.com/repos/vjpai/grpc/subscription","commits_url":"https://api.github.com/repos/vjpai/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/vjpai/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/vjpai/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/vjpai/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/vjpai/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/vjpai/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vjpai/grpc/merges","archive_url":"https://api.github.com/repos/vjpai/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vjpai/grpc/downloads","issues_url":"https://api.github.com/repos/vjpai/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/vjpai/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/vjpai/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/vjpai/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vjpai/grpc/labels{/name}","releases_url":"https://api.github.com/repos/vjpai/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/vjpai/grpc/deployments","created_at":"2015-09-30T17:59:22Z","updated_at":"2016-01-11T17:59:46Z","pushed_at":"2016-03-04T00:26:24Z","git_url":"git://github.com/vjpai/grpc.git","ssh_url":"git@github.com:vjpai/grpc.git","clone_url":"https://github.com/vjpai/grpc.git","svn_url":"https://github.com/vjpai/grpc","homepage":"","size":61154,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"4473dd5b88bf18c51f7574bc835c4c74c08ecc80","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2016-03-04T00:51:10Z","pushed_at":"2016-03-04T01:28:23Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":174654,"stargazers_count":4322,"watchers_count":4322,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":753,"mirror_url":null,"open_issues_count":679,"forks":753,"open_issues":679,"watchers":4322,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/5572"},"html":{"href":"https://github.com/grpc/grpc/pull/5572"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/5572"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/5572/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/5572/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/5572/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/dbf47fabd406b51e8d3d03c5eb06c5fe6f7d0d5d"}}}}