{"action":"created","issue":{"url":"https://api.github.com/repos/sympy/sympy/issues/10396","labels_url":"https://api.github.com/repos/sympy/sympy/issues/10396/labels{/name}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/10396/comments","events_url":"https://api.github.com/repos/sympy/sympy/issues/10396/events","html_url":"https://github.com/sympy/sympy/pull/10396","id":126871976,"number":10396,"title":"Extend the guess_generating_function in sympy.concrete.guess (more types of g.f.).","user":{"login":"baruchel","id":6763978,"avatar_url":"https://avatars.githubusercontent.com/u/6763978?v=3","gravatar_id":"","url":"https://api.github.com/users/baruchel","html_url":"https://github.com/baruchel","followers_url":"https://api.github.com/users/baruchel/followers","following_url":"https://api.github.com/users/baruchel/following{/other_user}","gists_url":"https://api.github.com/users/baruchel/gists{/gist_id}","starred_url":"https://api.github.com/users/baruchel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baruchel/subscriptions","organizations_url":"https://api.github.com/users/baruchel/orgs","repos_url":"https://api.github.com/users/baruchel/repos","events_url":"https://api.github.com/users/baruchel/events{/privacy}","received_events_url":"https://api.github.com/users/baruchel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-15T13:25:56Z","updated_at":"2016-01-22T15:41:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/10396","html_url":"https://github.com/sympy/sympy/pull/10396","diff_url":"https://github.com/sympy/sympy/pull/10396.diff","patch_url":"https://github.com/sympy/sympy/pull/10396.patch"},"body":"    Changed returned type of guess_generating_function to dictionary.\r\n    Mapped previous returned type to 'ogf' key (ordinary generating func.).\r\n    Added 'egf' key as a new type (exponential generating function).\r\n\r\nIn order to be on par with other software (see for instance the Superseeker server described at https://oeis.org/ol.html which is able to scan very deeply submitted sequences by using modules for Maple, Mathematica, etc.), I decided to change the returned type of the `guess_generating_function` in sympy.concrete.guess. Now it is a dictionary where keys are labels like \"ogf\" or \"egf\", etc. (see https://oeis.org/wiki/Generating_functions for understanding what they are).\r\n\r\nRight now, I implemented \"egf\" (previous function actually was \"ogf\"). Now the function returns things like {'ogf':stuff1, 'egf':stuff2} while most often, only one will be found for a given sequence (if someone can provide an example where two different g.f. are returned at the same time, I would appreciate and put it in the docstring).\r\n\r\nI am asking here to @certik @mattpap and others if they agree with the first change (since the function is very new, I strongly doubt anybody would complain). If you agree, I will add (in this very same pull request) more types of g.f. coming from https://oeis.org/wiki/Generating_functions\r\n\r\nRegards, tb."},"comment":{"url":"https://api.github.com/repos/sympy/sympy/issues/comments/173955435","html_url":"https://github.com/sympy/sympy/pull/10396#issuecomment-173955435","issue_url":"https://api.github.com/repos/sympy/sympy/issues/10396","id":173955435,"user":{"login":"baruchel","id":6763978,"avatar_url":"https://avatars.githubusercontent.com/u/6763978?v=3","gravatar_id":"","url":"https://api.github.com/users/baruchel","html_url":"https://github.com/baruchel","followers_url":"https://api.github.com/users/baruchel/followers","following_url":"https://api.github.com/users/baruchel/following{/other_user}","gists_url":"https://api.github.com/users/baruchel/gists{/gist_id}","starred_url":"https://api.github.com/users/baruchel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baruchel/subscriptions","organizations_url":"https://api.github.com/users/baruchel/orgs","repos_url":"https://api.github.com/users/baruchel/repos","events_url":"https://api.github.com/users/baruchel/events{/privacy}","received_events_url":"https://api.github.com/users/baruchel/received_events","type":"User","site_admin":false},"created_at":"2016-01-22T15:41:26Z","updated_at":"2016-01-22T15:41:26Z","body":"Two tests have failed but I don't think they are related to my commit; could someone restart them? Thank you."}}