{"action":"created","comment":{"url":"https://api.github.com/repos/django/django/pulls/comments/74100708","id":74100708,"diff_hunk":"@@ -32,6 +32,19 @@ references of :class:`Index` which includes the `index options`_.\n \n A list of the name of the fields on which the index is desired.\n \n+By default the indexes are created with an ascending order for all the columns.\n+To define an index with a descending order for a particular column, a hyphen\n+(-) can be added before the field's name while defining the index.\n+\n+For example::\n+\n+    Index(fields=['headline', '-pub_date'], name='headline_pub_date_reverse_idx')\n+\n+The above index would be issue an SQL with ``(headline, pub_date DESC)``. This\n+is supported only for PostgreSQL, Oracle and some versions of SQLite. If your\n+database doesn't support defining ordering on index columns it will simply be","path":"docs/ref/models/indexes.txt","position":14,"original_position":14,"commit_id":"8ecc14b37d60b1120c8fe7df21a4f3a9f9a974fd","original_commit_id":"8ecc14b37d60b1120c8fe7df21a4f3a9f9a974fd","user":{"login":"timgraham","id":411869,"avatar_url":"https://avatars.githubusercontent.com/u/411869?v=3","gravatar_id":"","url":"https://api.github.com/users/timgraham","html_url":"https://github.com/timgraham","followers_url":"https://api.github.com/users/timgraham/followers","following_url":"https://api.github.com/users/timgraham/following{/other_user}","gists_url":"https://api.github.com/users/timgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/timgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timgraham/subscriptions","organizations_url":"https://api.github.com/users/timgraham/orgs","repos_url":"https://api.github.com/users/timgraham/repos","events_url":"https://api.github.com/users/timgraham/events{/privacy}","received_events_url":"https://api.github.com/users/timgraham/received_events","type":"User","site_admin":false},"body":"The idea for the test is to provide that specifying a sort order in the SQL is indeed ignored and doesn't crash the database. I'm not sure if some other database might require the SQL to be omitted but such a test would detect that case and alert a maintainer to notify us that we should use the feature flag in django/db/models/indexes.py\r\n to strip out the DESC SQL.\r\n\r\nI'm not sure if the unsupported versions of SQLite are important to consider. Generally the feature flag would be computed based on the database information, e.g. https://github.com/django/django/blob/ac1975b18b5a33234284bec86e5a5bb44a4af976/django/db/backends/mysql/features.py#L51-L54","created_at":"2016-08-09T17:07:08Z","updated_at":"2016-08-09T17:07:08Z","html_url":"https://github.com/django/django/pull/6982#discussion_r74100708","pull_request_url":"https://api.github.com/repos/django/django/pulls/6982","_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/comments/74100708"},"html":{"href":"https://github.com/django/django/pull/6982#discussion_r74100708"},"pull_request":{"href":"https://api.github.com/repos/django/django/pulls/6982"}}},"pull_request":{"url":"https://api.github.com/repos/django/django/pulls/6982","id":79033680,"html_url":"https://github.com/django/django/pull/6982","diff_url":"https://github.com/django/django/pull/6982.diff","patch_url":"https://github.com/django/django/pull/6982.patch","issue_url":"https://api.github.com/repos/django/django/issues/6982","number":6982,"state":"open","locked":false,"title":"Refs #20888 -- Added index ordering feature for class based indexes","user":{"login":"akki","id":4801628,"avatar_url":"https://avatars.githubusercontent.com/u/4801628?v=3","gravatar_id":"","url":"https://api.github.com/users/akki","html_url":"https://github.com/akki","followers_url":"https://api.github.com/users/akki/followers","following_url":"https://api.github.com/users/akki/following{/other_user}","gists_url":"https://api.github.com/users/akki/gists{/gist_id}","starred_url":"https://api.github.com/users/akki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akki/subscriptions","organizations_url":"https://api.github.com/users/akki/orgs","repos_url":"https://api.github.com/users/akki/repos","events_url":"https://api.github.com/users/akki/events{/privacy}","received_events_url":"https://api.github.com/users/akki/received_events","type":"User","site_admin":false},"body":"Ticket [#20888](https://code.djangoproject.com/ticket/20888/).\r\n\r\nMySQL doesn't support this feature.\r\n\r\nThis PR is divided into 2 commits\r\n* Modifying the introspections of all databases to take index order (ASC/DESC) into account.\r\n* The feature itself.\r\n\r\nI am using \"refs\" instead of \"fixed\" because the reporter had requested for the feature in `unique_together` as well but I couldn't understand what that means.","created_at":"2016-07-27T14:25:53Z","updated_at":"2016-08-09T17:07:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8c9ea5962b7263d4308052453c72f918174a4a7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/django/django/pulls/6982/commits","review_comments_url":"https://api.github.com/repos/django/django/pulls/6982/comments","review_comment_url":"https://api.github.com/repos/django/django/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django/django/issues/6982/comments","statuses_url":"https://api.github.com/repos/django/django/statuses/8ecc14b37d60b1120c8fe7df21a4f3a9f9a974fd","head":{"label":"akki:gsoc-indexes-order","ref":"gsoc-indexes-order","sha":"8ecc14b37d60b1120c8fe7df21a4f3a9f9a974fd","user":{"login":"akki","id":4801628,"avatar_url":"https://avatars.githubusercontent.com/u/4801628?v=3","gravatar_id":"","url":"https://api.github.com/users/akki","html_url":"https://github.com/akki","followers_url":"https://api.github.com/users/akki/followers","following_url":"https://api.github.com/users/akki/following{/other_user}","gists_url":"https://api.github.com/users/akki/gists{/gist_id}","starred_url":"https://api.github.com/users/akki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akki/subscriptions","organizations_url":"https://api.github.com/users/akki/orgs","repos_url":"https://api.github.com/users/akki/repos","events_url":"https://api.github.com/users/akki/events{/privacy}","received_events_url":"https://api.github.com/users/akki/received_events","type":"User","site_admin":false},"repo":{"id":48555733,"name":"django","full_name":"akki/django","owner":{"login":"akki","id":4801628,"avatar_url":"https://avatars.githubusercontent.com/u/4801628?v=3","gravatar_id":"","url":"https://api.github.com/users/akki","html_url":"https://github.com/akki","followers_url":"https://api.github.com/users/akki/followers","following_url":"https://api.github.com/users/akki/following{/other_user}","gists_url":"https://api.github.com/users/akki/gists{/gist_id}","starred_url":"https://api.github.com/users/akki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akki/subscriptions","organizations_url":"https://api.github.com/users/akki/orgs","repos_url":"https://api.github.com/users/akki/repos","events_url":"https://api.github.com/users/akki/events{/privacy}","received_events_url":"https://api.github.com/users/akki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akki/django","description":"The Web framework for perfectionists with deadlines.","fork":true,"url":"https://api.github.com/repos/akki/django","forks_url":"https://api.github.com/repos/akki/django/forks","keys_url":"https://api.github.com/repos/akki/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akki/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akki/django/teams","hooks_url":"https://api.github.com/repos/akki/django/hooks","issue_events_url":"https://api.github.com/repos/akki/django/issues/events{/number}","events_url":"https://api.github.com/repos/akki/django/events","assignees_url":"https://api.github.com/repos/akki/django/assignees{/user}","branches_url":"https://api.github.com/repos/akki/django/branches{/branch}","tags_url":"https://api.github.com/repos/akki/django/tags","blobs_url":"https://api.github.com/repos/akki/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akki/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akki/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/akki/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akki/django/statuses/{sha}","languages_url":"https://api.github.com/repos/akki/django/languages","stargazers_url":"https://api.github.com/repos/akki/django/stargazers","contributors_url":"https://api.github.com/repos/akki/django/contributors","subscribers_url":"https://api.github.com/repos/akki/django/subscribers","subscription_url":"https://api.github.com/repos/akki/django/subscription","commits_url":"https://api.github.com/repos/akki/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/akki/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/akki/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/akki/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/akki/django/contents/{+path}","compare_url":"https://api.github.com/repos/akki/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akki/django/merges","archive_url":"https://api.github.com/repos/akki/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akki/django/downloads","issues_url":"https://api.github.com/repos/akki/django/issues{/number}","pulls_url":"https://api.github.com/repos/akki/django/pulls{/number}","milestones_url":"https://api.github.com/repos/akki/django/milestones{/number}","notifications_url":"https://api.github.com/repos/akki/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akki/django/labels{/name}","releases_url":"https://api.github.com/repos/akki/django/releases{/id}","deployments_url":"https://api.github.com/repos/akki/django/deployments","created_at":"2015-12-24T20:15:07Z","updated_at":"2016-02-05T14:52:35Z","pushed_at":"2016-08-09T07:54:45Z","git_url":"git://github.com/akki/django.git","ssh_url":"git@github.com:akki/django.git","clone_url":"https://github.com/akki/django.git","svn_url":"https://github.com/akki/django","homepage":"https://www.djangoproject.com/","size":137041,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django:master","ref":"master","sha":"ccd5a23fba91e66656bb19b60bb6d737cab728f5","user":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"repo":{"id":4164482,"name":"django","full_name":"django/django","owner":{"login":"django","id":27804,"avatar_url":"https://avatars.githubusercontent.com/u/27804?v=3","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django/django","description":"The Web framework for perfectionists with deadlines.","fork":false,"url":"https://api.github.com/repos/django/django","forks_url":"https://api.github.com/repos/django/django/forks","keys_url":"https://api.github.com/repos/django/django/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django/django/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django/django/teams","hooks_url":"https://api.github.com/repos/django/django/hooks","issue_events_url":"https://api.github.com/repos/django/django/issues/events{/number}","events_url":"https://api.github.com/repos/django/django/events","assignees_url":"https://api.github.com/repos/django/django/assignees{/user}","branches_url":"https://api.github.com/repos/django/django/branches{/branch}","tags_url":"https://api.github.com/repos/django/django/tags","blobs_url":"https://api.github.com/repos/django/django/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django/django/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django/django/git/refs{/sha}","trees_url":"https://api.github.com/repos/django/django/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django/django/statuses/{sha}","languages_url":"https://api.github.com/repos/django/django/languages","stargazers_url":"https://api.github.com/repos/django/django/stargazers","contributors_url":"https://api.github.com/repos/django/django/contributors","subscribers_url":"https://api.github.com/repos/django/django/subscribers","subscription_url":"https://api.github.com/repos/django/django/subscription","commits_url":"https://api.github.com/repos/django/django/commits{/sha}","git_commits_url":"https://api.github.com/repos/django/django/git/commits{/sha}","comments_url":"https://api.github.com/repos/django/django/comments{/number}","issue_comment_url":"https://api.github.com/repos/django/django/issues/comments{/number}","contents_url":"https://api.github.com/repos/django/django/contents/{+path}","compare_url":"https://api.github.com/repos/django/django/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django/django/merges","archive_url":"https://api.github.com/repos/django/django/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django/django/downloads","issues_url":"https://api.github.com/repos/django/django/issues{/number}","pulls_url":"https://api.github.com/repos/django/django/pulls{/number}","milestones_url":"https://api.github.com/repos/django/django/milestones{/number}","notifications_url":"https://api.github.com/repos/django/django/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django/django/labels{/name}","releases_url":"https://api.github.com/repos/django/django/releases{/id}","deployments_url":"https://api.github.com/repos/django/django/deployments","created_at":"2012-04-28T02:47:18Z","updated_at":"2016-08-09T16:01:25Z","pushed_at":"2016-08-09T16:53:26Z","git_url":"git://github.com/django/django.git","ssh_url":"git@github.com:django/django.git","clone_url":"https://github.com/django/django.git","svn_url":"https://github.com/django/django","homepage":"https://www.djangoproject.com/","size":196756,"stargazers_count":20655,"watchers_count":20655,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8347,"mirror_url":null,"open_issues_count":104,"forks":8347,"open_issues":104,"watchers":20655,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django/django/pulls/6982"},"html":{"href":"https://github.com/django/django/pull/6982"},"issue":{"href":"https://api.github.com/repos/django/django/issues/6982"},"comments":{"href":"https://api.github.com/repos/django/django/issues/6982/comments"},"review_comments":{"href":"https://api.github.com/repos/django/django/pulls/6982/comments"},"review_comment":{"href":"https://api.github.com/repos/django/django/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django/django/pulls/6982/commits"},"statuses":{"href":"https://api.github.com/repos/django/django/statuses/8ecc14b37d60b1120c8fe7df21a4f3a9f9a974fd"}}}}
{"actor":{"display_login":"timgraham"}}