{"push_id":1366223181,"size":71,"distinct_size":71,"ref":"refs/heads/adding-support-for-resource-id","head":"e18578d6aaa80857f9910a376998c201c55f0605","before":"67a5ee9e97f14edaf322f8e4f857b84197cfa682","commits":[{"sha":"73c5360470bee493e440d10b33a173aa42acf23b","author":{"name":"Geordie","email":"96a5744bb30fc6fe4f38dca50248d47bd12d527f@gmail.com"},"message":"NavigatorIOS: stopPropagation on navigationComplete event. Fixes #1241\n\nSummary:\nWith nested NavigatorIOS components:\n\n```\n<NavigatorIOS initialRoute={{\n  component: ComponentWithAnotherNavigatorIOSInSubtree\n  title: 'xyz'\n}}>\n```\n\nNavigating (via push etc.) in ComponentWithAnotherNavigatorIOSInSubtree's `navigator` caused an invariant error, making apps with this structure unusable. The reason was that the `navigationComplete` nativeEvent was being propagated to the outer Navigator due to React's automatic event bubbling, making the outer NavigatorIOS incorrectly think it was holding navigation stack state inconsistent with its native UINavigationController.\n\nConcretely, if the outer navigation stack is empty except for its initial state and something is pushed onto the inner stack, the outer NavigatorIOS suddenly complains that it has 2 items on its stack rather than 1. In reality, the outer Navigator still only has 1 item on its stack but the inner Navigator's event (containing information about the inner Navigator) incorrectly bubbles up and reaches the outer Navigator too.\nCloses https://github.com/facebook/react-native/pull/9828\n\nDifferential Revision: D4030167\n\nPulled By: ericvicenti\n\nfbshipit-source-id: d04de3d5b70b4862a78610c92701ebdab2b047dd","distinct":true,"url":"https://api.github.com/repos/kogosoftwarellc/react-native/commits/73c5360470bee493e440d10b33a173aa42acf23b"},{"sha":"02fc4c8ffaf7ffd4b1c9e2352eacd747996a6362","author":{"name":"Emil Sjolander","email":"fd01956b6f7ea3f89c72dc9353cbe274f619cc70@fb.com"},"message":"Move absolute layout calculation out into seperate function\n\nReviewed By: gkassabli\n\nDifferential Revision: D4028329\n\nfbshipit-source-id: 2903f66b028063cec0a6b3037ca7cb4d6552176d","distinct":true,"url":"https://api.github.com/repos/kogosoftwarellc/react-native/commits/02fc4c8ffaf7ffd4b1c9e2352eacd747996a6362"},{"sha":"4d0b3e684ae0e980b30bf3286d7841ff5a0b7a47","author":{"name":"Emil Sjolander","email":"fd01956b6f7ea3f89c72dc9353cbe274f619cc70@fb.com"},"message":"Remove default: usage to ensure compiler can help with missing cases\n\nReviewed By: gkassabli\n\nDifferential Revision: D4036440\n\nfbshipit-source-id: f5ef4c8afff0f353de50681ad304878f90255fef","distinct":true,"url":"https://api.github.com/repos/kogosoftwarellc/react-native/commits/4d0b3e684ae0e980b30bf3286d7841ff5a0b7a47"},{"sha":"7762f374d50d3b1df8513c826862c2056e8718f9","author":{"name":"David Aurelio","email":"ff048047600c1f3e891446665b5269773d037402@fb.com"},"message":"entry point: remove unused code\n\nSummary: Removes code that is no longer used\n\nReviewed By: matryoshcow\n\nDifferential Revision: D4021932\n\nfbshipit-source-id: d73dc8450478288afd71eab451a30a505e7de945","distinct":true,"url":"https://api.github.com/repos/kogosoftwarellc/react-native/commits/7762f374d50d3b1df8513c826862c2056e8718f9"},{"sha":"40e8d8904b006dadab639d4a9fddb926961e658a","author":{"name":"Mehdi Mulani","email":"679cb16dd8ae19f5de96672ffaf139bf6e7f0519@fb.com"},"message":"RN TextInput: don't let user more than maxLength when TextInput already exceeds it\n\nSummary:\nWe had a classic integer underflow problem here. Before we would let you type endlessly when the text already exceeded the TextInput maxLength, now we only let you erase characters.\n\nThere is still a small problem with the TextInput: how do you handle when the value (set from JS) exceeds the maxLength? This could happen pragmatically, just by passing in a very large value or when changing maxLength (e.g. when changing from 4 to 3 digits in the case of a AMEX security code -> VISA security code).\n\nMe and achen1 discussed firing onChange in these cases and truncating the number manually (to ensure JS's data model) was aware of the change but it seemed fraught with bugs and general weirdness in what the caller would expect to happen.\n\nReviewed By: javache\n\nDifferential Revision: D3991210\n\nfbshipit-source-id: dc401c4a7aefe09fa749cd1168d36343d39dc196","distinct":true,"url":"https://api.github.com/repos/kogosoftwarellc/react-native/commits/40e8d8904b006dadab639d4a9fddb926961e658a"},{"sha":"2230117f360722ddbdb1bc8c87869bc98d392edb","author":{"name":"YUYA FUJIMOTO","email":"c4c02efc8360dbc4a956f5af481bdadc69828593@gmail.com"},"message":"Add HorizontalSwipeJumpFromLeft animation to Navigator\n\nSummary:\nThis brings RN Navigator to add HorizontalSwipeJumpFromLeft animation.\nHorizontalSwipeJumpFromRight has been implemented but FromLeft version of SwipeJumpAnimation hasn't been there.\nCloses https://github.com/facebook/react-native/pull/10406\n\nDifferential Revision: D4035212\n\nfbshipit-source-id: edcbae18148e533b02a7d056de03154fb86280d0","distinct":true,"url":"https://api.github.com/repos/kogosoftwarellc/react-native/commits/2230117f360722ddbdb1bc8c87869bc98d392edb"},{"sha":"1a6b43e67bb017dc835bef05ccb8ff082bd2ae31","author":{"name":"Jean Lauliac","email":"7e54b6bf4c2d61f2bb0f90454ffb09854716e3bb@fb.com"},"message":"react-packager/index.js: @flow\n\nReviewed By: cpojer\n\nDifferential Revision: D4036668\n\nfbshipit-source-id: 286963fd1f18f92389ec642c43dcf4c9d55f19f8","distinct":true,"url":"https://api.github.com/repos/kogosoftwarellc/react-native/commits/1a6b43e67bb017dc835bef05ccb8ff082bd2ae31"},{"sha":"0699a30980ef08a87d51cd67e9d452c9aba427ed","author":{"name":"Emil Sjolander","email":"fd01956b6f7ea3f89c72dc9353cbe274f619cc70@fb.com"},"message":"Fix flex-shrink when shrinking to zero size\n\nReviewed By: gkassabli\n\nDifferential Revision: D4036345\n\nfbshipit-source-id: f6848d7a316a694426f761d5e51d972bd379d90e","distinct":true,"url":"https://api.github.com/repos/kogosoftwarellc/react-native/commits/0699a30980ef08a87d51cd67e9d452c9aba427ed"},{"sha":"c805cf83767a0fd327b4542cf32039bd2134c477","author":{"name":"Emil Sjolander","email":"fd01956b6f7ea3f89c72dc9353cbe274f619cc70@fb.com"},"message":"Use switch instead of ifelse chain\n\nReviewed By: gkassabli\n\nDifferential Revision: D4036445\n\nfbshipit-source-id: 2159946f53507ff3d7505795e5baa5f820cdb65c","distinct":true,"url":"https://api.github.com/repos/kogosoftwarellc/react-native/commits/c805cf83767a0fd327b4542cf32039bd2134c477"},{"sha":"6d3ecbe07afe8fce3671a744954bb9801d3a5ae4","author":{"name":"Emil Sjolander","email":"fd01956b6f7ea3f89c72dc9353cbe274f619cc70@fb.com"},"message":"Use typedefs from header\n\nReviewed By: gkassabli\n\nDifferential Revision: D4036421\n\nfbshipit-source-id: 01f15cb840363850970e6a60e661af06fd6ec9e0","distinct":true,"url":"https://api.github.com/repos/kogosoftwarellc/react-native/commits/6d3ecbe07afe8fce3671a744954bb9801d3a5ae4"},{"sha":"8e2b1aa482fc18971567666052acea2016e1a27e","author":{"name":"Jean Lauliac","email":"7e54b6bf4c2d61f2bb0f90454ffb09854716e3bb@fb.com"},"message":"BundleBase.js: @flow\n\nReviewed By: matryoshcow\n\nDifferential Revision: D4036938\n\nfbshipit-source-id: 2c151d98f99ab1e325bb07050d0a2c59ee8f4761","distinct":true,"url":"https://api.github.com/repos/kogosoftwarellc/react-native/commits/8e2b1aa482fc18971567666052acea2016e1a27e"},{"sha":"ebc8126ad2d7e2288dc0f15f566530d4ece01113","author":{"name":"Konstantin Raev","email":"262a3feb6c5718f8f9d3bda3bc4169ca50eb70b8@fb.com"},"message":"removed leaked internal yarn.lock","distinct":true,"url":"https://api.github.com/repos/kogosoftwarellc/react-native/commits/ebc8126ad2d7e2288dc0f15f566530d4ece01113"},{"sha":"8acf1a052e33e80c10bb8151c684f3d140256b65","author":{"name":"Konstantin Raev","email":"262a3feb6c5718f8f9d3bda3bc4169ca50eb70b8@fb.com"},"message":"Reverted commit D4036668\n\nReviewed By: cpojer\n\nDifferential Revision: D4036668\n\nfbshipit-source-id: 5b75709526c3e87774e0943a76d55cd729c6143d","distinct":true,"url":"https://api.github.com/repos/kogosoftwarellc/react-native/commits/8acf1a052e33e80c10bb8151c684f3d140256b65"},{"sha":"d294e15c43a6222f25953dae8189d0e220dbdf7e","author":{"name":"Dmitry Petukhov","email":"78aa05a1d4c566d88366c7e0d3e8c990287c01fb@roboforex.com"},"message":"Two ReactART TODOs implemented on Android\n\nSummary:\nImplemented 2 TODOs from ReactART for Android:\n- TODO(7255985): Use TextureView and pass Surface from the view to draw on it asynchronously instead of passing the bitmap (which is inefficient especially in terms of memory usage)\n- TODO(6352067): Support dashes in ARTShape\n\nWe use ReactNativeART in our Android project.\n1. Our app crashes sometimes on large screen smartphones with OutOfMemoryError. Crashes happen in ARTSurfaceShadowNode where TODO(7255985) was suggested in a comment in order to use memory more efficiently.\n2. We needed dashes for drawing on ARTSurface.\n\n**Test plan (required)**\n\nI attach a screenshot of our app which shows dashed-lines and two ARTSurfaces on top of each other rendering exactly the same as in the pervious implementation of ARTSurface.\n![screenshot_2016-08-19-16-45-43](https://cloud.githubusercontent.com/assets/18415611/17811741/cafc35c4-662c-11e6-8a63-7c35ef1c5ba9.png)\nCloses https://github.com/facebook/react-native/pull/9486\n\nDifferential Revision: D4021303\n\nPulled By: foghina\n\nfbshipit-source-id: 880175e841e3c598013982a7748b6fc691c7e8d6","distinct":true,"url":"https://api.github.com/repos/kogosoftwarellc/react-native/commits/d294e15c43a6222f25953dae8189d0e220dbdf7e"},{"sha":"db474d95b47e66b5eb6ddbfd5368bdb3d93dd70d","author":{"name":"Héctor Ramos","email":"89f1e7980c8b0e9083eadee29bf6e84eb2cb7aed@users.noreply.github.com"},"message":"Headless JS - fix markdown typo.\n\nSummary: Closes https://github.com/facebook/react-native/pull/10448\n\nDifferential Revision: D4039297\n\nPulled By: lacker\n\nfbshipit-source-id: 21a398e3d35b2aa3d34cd35c865d36cf5a9e4b25","distinct":true,"url":"https://api.github.com/repos/kogosoftwarellc/react-native/commits/db474d95b47e66b5eb6ddbfd5368bdb3d93dd70d"},{"sha":"7fbb46c31656e552a5b02c7dbc656b437f851136","author":{"name":"Matthew Curtis","email":"4dc1fb8cebf1553ab7fd31206f1e48fe4714fa6e@matthewbryancurtis.com"},"message":"Fix typo on line 47 \"make\" to \"makes\"\n\nSummary:\nThanks for submitting a pull request! Please provide enough information so that others can review your pull request:\n\nFix typo on line 47 \"make\" to \"makes\"\n\n> **Unless you are a React Native release maintainer and cherry-picking an *existing* commit into a current release, ensure your pull request is targeting the `master` React Native branch.**\n\nExplain the **motivation** for making this change. What existing problem does the pull request solve?\n\nPrefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.\n\n**Test plan (required)**\n\nDemonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.\n\nMake sure tests pass on both Travis and Circle CI.\n\n**Code formatting**\n\nLook around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTI\nCloses https://github.com/facebook/react-native/pull/10449\n\nDifferential Revision: D4039572\n\nPulled By: hramos\n\nfbshipit-source-id: 21ba41365f24f4f615b73051de63dfd5be6b4893","distinct":true,"url":"https://api.github.com/repos/kogosoftwarellc/react-native/commits/7fbb46c31656e552a5b02c7dbc656b437f851136"},{"sha":"2e06e708fe07d4384aacfdf8f8882ad4bf8788cd","author":{"name":"Jean Lauliac","email":"7e54b6bf4c2d61f2bb0f90454ffb09854716e3bb@fb.com"},"message":"Bundler.js: @flow\n\nReviewed By: davidaurelio\n\nDifferential Revision: D4036964\n\nfbshipit-source-id: dceb81299d076493d12b2ade13354e927c10ea7c","distinct":true,"url":"https://api.github.com/repos/kogosoftwarellc/react-native/commits/2e06e708fe07d4384aacfdf8f8882ad4bf8788cd"},{"sha":"a9d94c2dfb45016125cc30d8ae1574e4e2c7f6f4","author":{"name":"Emil Sjolander","email":"fd01956b6f7ea3f89c72dc9353cbe274f619cc70@fb.com"},"message":"Change flex basis to override main axis size\n\nReviewed By: gkassabli\n\nDifferential Revision: D4029374\n\nfbshipit-source-id: bc3c72879f3937a50bf8a636b547adc7b9a4f5a7","distinct":true,"url":"https://api.github.com/repos/kogosoftwarellc/react-native/commits/a9d94c2dfb45016125cc30d8ae1574e4e2c7f6f4"},{"sha":"0c7bc9801c2e5bf8100be6c975235734f6ccb309","author":{"name":"David Aurelio","email":"ff048047600c1f3e891446665b5269773d037402@fb.com"},"message":"Create integration types and code to use module resolution logic from node-haste\n\nSummary:\nThis creates flow types for the module resolution code in node-haste, and implementations of types used by that code.\n\nThe idea is to use that code until we can replace it with something leaner, and provide objects that don’t touch the file system. These objects will be initialized with the static data provided by ModuleGraph/worker.\n\nReviewed By: cpojer\n\nDifferential Revision: D4037372\n\nfbshipit-source-id: 2698dbb630f4122fc1d839d06e414d0963bd6ff2","distinct":true,"url":"https://api.github.com/repos/kogosoftwarellc/react-native/commits/0c7bc9801c2e5bf8100be6c975235734f6ccb309"},{"sha":"0e5c0d2f2c8ce4b5ce106d80de89f65f4ee07200","author":{"name":"Konstantin Raev","email":"262a3feb6c5718f8f9d3bda3bc4169ca50eb70b8@fb.com"},"message":"test refurb: removed xcpretty on travis + using yarn + e2e tests\n\nSummary:\n- switched to yarn on travis (experimental)\n- removed xcpretty, we need more verbose logs\n- returned jest test for e2e\nCloses https://github.com/facebook/react-native/pull/10442\n\nDifferential Revision: D4043991\n\nPulled By: davidaurelio\n\nfbshipit-source-id: 50062f6a77a17643bf9a7ba7add8cee5b3bb26d2","distinct":true,"url":"https://api.github.com/repos/kogosoftwarellc/react-native/commits/0e5c0d2f2c8ce4b5ce106d80de89f65f4ee07200"}]}
{"actor":{"display_login":"jsdevel"}}