{"action":"created","comment":{"url":"https://api.github.com/repos/Itseez/opencv/pulls/comments/65310787","id":65310787,"diff_hunk":"@@ -287,13 +287,18 @@ Command line arguments of opencv_traincascade application grouped by purposes:\n \n     -   -minHitRate \\<min_hit_rate\\>\n \n-        Minimal desired hit rate for each stage of the classifier. Overall hit rate may be estimated\n-        as (min_hit_rate\\^number_of_stages).\n+        Minimal desired hit rate for each stage of the classifier. The overal hit rate can be calculated as follows.\n+\n+        overall_hit_rate = 1.0 - overall_fail_rate\n+        overall_fail_rate  = max_fail_rate ^ number_of_stages\n+        max_fail_rate = 1.0 - min_hit_rate\n+\n+        and thus overall_hit_rate = ( 1.0 - ( 1.0 - min_hit_rate ) ^ number_of_stages )","path":"doc/tutorials/objdetect/traincascade.markdown","position":12,"original_position":12,"commit_id":"5a03cf830670f64d985f99c55b23d82232e866ba","original_commit_id":"5a03cf830670f64d985f99c55b23d82232e866ba","user":{"login":"vpisarev","id":2110786,"avatar_url":"https://avatars.githubusercontent.com/u/2110786?v=3","gravatar_id":"","url":"https://api.github.com/users/vpisarev","html_url":"https://github.com/vpisarev","followers_url":"https://api.github.com/users/vpisarev/followers","following_url":"https://api.github.com/users/vpisarev/following{/other_user}","gists_url":"https://api.github.com/users/vpisarev/gists{/gist_id}","starred_url":"https://api.github.com/users/vpisarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpisarev/subscriptions","organizations_url":"https://api.github.com/users/vpisarev/orgs","repos_url":"https://api.github.com/users/vpisarev/repos","events_url":"https://api.github.com/users/vpisarev/events{/privacy}","received_events_url":"https://api.github.com/users/vpisarev/received_events","type":"User","site_admin":false},"body":"it's not quite clear for me. If each stage has at least 0.99 hit-rate, when the cascade of 20 stages will have 0.99^20 hit-rate, right? that is, formula should be\r\n\r\n        overall_hit_rate = min_hit_rate ^ number_of_stages\r\n","created_at":"2016-06-01T07:01:26Z","updated_at":"2016-06-01T07:01:26Z","html_url":"https://github.com/Itseez/opencv/pull/6440#discussion_r65310787","pull_request_url":"https://api.github.com/repos/Itseez/opencv/pulls/6440","_links":{"self":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/comments/65310787"},"html":{"href":"https://github.com/Itseez/opencv/pull/6440#discussion_r65310787"},"pull_request":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/6440"}}},"pull_request":{"url":"https://api.github.com/repos/Itseez/opencv/pulls/6440","id":67169124,"html_url":"https://github.com/Itseez/opencv/pull/6440","diff_url":"https://github.com/Itseez/opencv/pull/6440.diff","patch_url":"https://github.com/Itseez/opencv/pull/6440.patch","issue_url":"https://api.github.com/repos/Itseez/opencv/issues/6440","number":6440,"state":"open","locked":false,"title":"fixing wrong traincascade documentation","user":{"login":"StevenPuttemans","id":4621239,"avatar_url":"https://avatars.githubusercontent.com/u/4621239?v=3","gravatar_id":"","url":"https://api.github.com/users/StevenPuttemans","html_url":"https://github.com/StevenPuttemans","followers_url":"https://api.github.com/users/StevenPuttemans/followers","following_url":"https://api.github.com/users/StevenPuttemans/following{/other_user}","gists_url":"https://api.github.com/users/StevenPuttemans/gists{/gist_id}","starred_url":"https://api.github.com/users/StevenPuttemans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StevenPuttemans/subscriptions","organizations_url":"https://api.github.com/users/StevenPuttemans/orgs","repos_url":"https://api.github.com/users/StevenPuttemans/repos","events_url":"https://api.github.com/users/StevenPuttemans/events{/privacy}","received_events_url":"https://api.github.com/users/StevenPuttemans/received_events","type":"User","site_admin":false},"body":"**Master port of https://github.com/Itseez/opencv/pull/6439**\r\n\r\nIt is simply unlogical that the overall hit rate of a cascade would be worse then the individual minimal hit rates for each seperate weak classifier. I guess this is a copy paste error from the following feature that can be set, being the maxFalseAlarmRate.\r\n\r\nExample:\r\nA cascade with -minHitRate 0.95 and -numStages 20, would according to this function, have a overall hit rate of 0.35, which is terribly low.\r\n\r\nIn my opinion this cascade would have a minHitRate of at least 0.95, and even higher if the individual weak classifiers have higher values. How they combine correctly, I will investigate and push in another PR.","created_at":"2016-04-20T11:18:52Z","updated_at":"2016-06-01T07:01:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08637403d44ef4be207d8bcf86a4ad5ae8d6313c","assignee":{"login":"vpisarev","id":2110786,"avatar_url":"https://avatars.githubusercontent.com/u/2110786?v=3","gravatar_id":"","url":"https://api.github.com/users/vpisarev","html_url":"https://github.com/vpisarev","followers_url":"https://api.github.com/users/vpisarev/followers","following_url":"https://api.github.com/users/vpisarev/following{/other_user}","gists_url":"https://api.github.com/users/vpisarev/gists{/gist_id}","starred_url":"https://api.github.com/users/vpisarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpisarev/subscriptions","organizations_url":"https://api.github.com/users/vpisarev/orgs","repos_url":"https://api.github.com/users/vpisarev/repos","events_url":"https://api.github.com/users/vpisarev/events{/privacy}","received_events_url":"https://api.github.com/users/vpisarev/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Itseez/opencv/pulls/6440/commits","review_comments_url":"https://api.github.com/repos/Itseez/opencv/pulls/6440/comments","review_comment_url":"https://api.github.com/repos/Itseez/opencv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Itseez/opencv/issues/6440/comments","statuses_url":"https://api.github.com/repos/Itseez/opencv/statuses/5a03cf830670f64d985f99c55b23d82232e866ba","head":{"label":"StevenPuttemans:fix_docs_traincascade_master","ref":"fix_docs_traincascade_master","sha":"5a03cf830670f64d985f99c55b23d82232e866ba","user":{"login":"StevenPuttemans","id":4621239,"avatar_url":"https://avatars.githubusercontent.com/u/4621239?v=3","gravatar_id":"","url":"https://api.github.com/users/StevenPuttemans","html_url":"https://github.com/StevenPuttemans","followers_url":"https://api.github.com/users/StevenPuttemans/followers","following_url":"https://api.github.com/users/StevenPuttemans/following{/other_user}","gists_url":"https://api.github.com/users/StevenPuttemans/gists{/gist_id}","starred_url":"https://api.github.com/users/StevenPuttemans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StevenPuttemans/subscriptions","organizations_url":"https://api.github.com/users/StevenPuttemans/orgs","repos_url":"https://api.github.com/users/StevenPuttemans/repos","events_url":"https://api.github.com/users/StevenPuttemans/events{/privacy}","received_events_url":"https://api.github.com/users/StevenPuttemans/received_events","type":"User","site_admin":false},"repo":{"id":11422649,"name":"opencv","full_name":"StevenPuttemans/opencv","owner":{"login":"StevenPuttemans","id":4621239,"avatar_url":"https://avatars.githubusercontent.com/u/4621239?v=3","gravatar_id":"","url":"https://api.github.com/users/StevenPuttemans","html_url":"https://github.com/StevenPuttemans","followers_url":"https://api.github.com/users/StevenPuttemans/followers","following_url":"https://api.github.com/users/StevenPuttemans/following{/other_user}","gists_url":"https://api.github.com/users/StevenPuttemans/gists{/gist_id}","starred_url":"https://api.github.com/users/StevenPuttemans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StevenPuttemans/subscriptions","organizations_url":"https://api.github.com/users/StevenPuttemans/orgs","repos_url":"https://api.github.com/users/StevenPuttemans/repos","events_url":"https://api.github.com/users/StevenPuttemans/events{/privacy}","received_events_url":"https://api.github.com/users/StevenPuttemans/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/StevenPuttemans/opencv","description":"Open Source Computer Vision Library","fork":true,"url":"https://api.github.com/repos/StevenPuttemans/opencv","forks_url":"https://api.github.com/repos/StevenPuttemans/opencv/forks","keys_url":"https://api.github.com/repos/StevenPuttemans/opencv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StevenPuttemans/opencv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StevenPuttemans/opencv/teams","hooks_url":"https://api.github.com/repos/StevenPuttemans/opencv/hooks","issue_events_url":"https://api.github.com/repos/StevenPuttemans/opencv/issues/events{/number}","events_url":"https://api.github.com/repos/StevenPuttemans/opencv/events","assignees_url":"https://api.github.com/repos/StevenPuttemans/opencv/assignees{/user}","branches_url":"https://api.github.com/repos/StevenPuttemans/opencv/branches{/branch}","tags_url":"https://api.github.com/repos/StevenPuttemans/opencv/tags","blobs_url":"https://api.github.com/repos/StevenPuttemans/opencv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StevenPuttemans/opencv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StevenPuttemans/opencv/git/refs{/sha}","trees_url":"https://api.github.com/repos/StevenPuttemans/opencv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StevenPuttemans/opencv/statuses/{sha}","languages_url":"https://api.github.com/repos/StevenPuttemans/opencv/languages","stargazers_url":"https://api.github.com/repos/StevenPuttemans/opencv/stargazers","contributors_url":"https://api.github.com/repos/StevenPuttemans/opencv/contributors","subscribers_url":"https://api.github.com/repos/StevenPuttemans/opencv/subscribers","subscription_url":"https://api.github.com/repos/StevenPuttemans/opencv/subscription","commits_url":"https://api.github.com/repos/StevenPuttemans/opencv/commits{/sha}","git_commits_url":"https://api.github.com/repos/StevenPuttemans/opencv/git/commits{/sha}","comments_url":"https://api.github.com/repos/StevenPuttemans/opencv/comments{/number}","issue_comment_url":"https://api.github.com/repos/StevenPuttemans/opencv/issues/comments{/number}","contents_url":"https://api.github.com/repos/StevenPuttemans/opencv/contents/{+path}","compare_url":"https://api.github.com/repos/StevenPuttemans/opencv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StevenPuttemans/opencv/merges","archive_url":"https://api.github.com/repos/StevenPuttemans/opencv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StevenPuttemans/opencv/downloads","issues_url":"https://api.github.com/repos/StevenPuttemans/opencv/issues{/number}","pulls_url":"https://api.github.com/repos/StevenPuttemans/opencv/pulls{/number}","milestones_url":"https://api.github.com/repos/StevenPuttemans/opencv/milestones{/number}","notifications_url":"https://api.github.com/repos/StevenPuttemans/opencv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StevenPuttemans/opencv/labels{/name}","releases_url":"https://api.github.com/repos/StevenPuttemans/opencv/releases{/id}","deployments_url":"https://api.github.com/repos/StevenPuttemans/opencv/deployments","created_at":"2013-07-15T12:30:38Z","updated_at":"2015-04-30T08:46:04Z","pushed_at":"2016-05-23T08:33:09Z","git_url":"git://github.com/StevenPuttemans/opencv.git","ssh_url":"git@github.com:StevenPuttemans/opencv.git","clone_url":"https://github.com/StevenPuttemans/opencv.git","svn_url":"https://github.com/StevenPuttemans/opencv","homepage":"","size":427187,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"2.4"}},"base":{"label":"Itseez:master","ref":"master","sha":"ec63343f34658d9b0ec94dc15e1b71e8f7d1d553","user":{"login":"Itseez","id":1786446,"avatar_url":"https://avatars.githubusercontent.com/u/1786446?v=3","gravatar_id":"","url":"https://api.github.com/users/Itseez","html_url":"https://github.com/Itseez","followers_url":"https://api.github.com/users/Itseez/followers","following_url":"https://api.github.com/users/Itseez/following{/other_user}","gists_url":"https://api.github.com/users/Itseez/gists{/gist_id}","starred_url":"https://api.github.com/users/Itseez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Itseez/subscriptions","organizations_url":"https://api.github.com/users/Itseez/orgs","repos_url":"https://api.github.com/users/Itseez/repos","events_url":"https://api.github.com/users/Itseez/events{/privacy}","received_events_url":"https://api.github.com/users/Itseez/received_events","type":"Organization","site_admin":false},"repo":{"id":5108051,"name":"opencv","full_name":"Itseez/opencv","owner":{"login":"Itseez","id":1786446,"avatar_url":"https://avatars.githubusercontent.com/u/1786446?v=3","gravatar_id":"","url":"https://api.github.com/users/Itseez","html_url":"https://github.com/Itseez","followers_url":"https://api.github.com/users/Itseez/followers","following_url":"https://api.github.com/users/Itseez/following{/other_user}","gists_url":"https://api.github.com/users/Itseez/gists{/gist_id}","starred_url":"https://api.github.com/users/Itseez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Itseez/subscriptions","organizations_url":"https://api.github.com/users/Itseez/orgs","repos_url":"https://api.github.com/users/Itseez/repos","events_url":"https://api.github.com/users/Itseez/events{/privacy}","received_events_url":"https://api.github.com/users/Itseez/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Itseez/opencv","description":"Open Source Computer Vision Library","fork":false,"url":"https://api.github.com/repos/Itseez/opencv","forks_url":"https://api.github.com/repos/Itseez/opencv/forks","keys_url":"https://api.github.com/repos/Itseez/opencv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Itseez/opencv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Itseez/opencv/teams","hooks_url":"https://api.github.com/repos/Itseez/opencv/hooks","issue_events_url":"https://api.github.com/repos/Itseez/opencv/issues/events{/number}","events_url":"https://api.github.com/repos/Itseez/opencv/events","assignees_url":"https://api.github.com/repos/Itseez/opencv/assignees{/user}","branches_url":"https://api.github.com/repos/Itseez/opencv/branches{/branch}","tags_url":"https://api.github.com/repos/Itseez/opencv/tags","blobs_url":"https://api.github.com/repos/Itseez/opencv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Itseez/opencv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Itseez/opencv/git/refs{/sha}","trees_url":"https://api.github.com/repos/Itseez/opencv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Itseez/opencv/statuses/{sha}","languages_url":"https://api.github.com/repos/Itseez/opencv/languages","stargazers_url":"https://api.github.com/repos/Itseez/opencv/stargazers","contributors_url":"https://api.github.com/repos/Itseez/opencv/contributors","subscribers_url":"https://api.github.com/repos/Itseez/opencv/subscribers","subscription_url":"https://api.github.com/repos/Itseez/opencv/subscription","commits_url":"https://api.github.com/repos/Itseez/opencv/commits{/sha}","git_commits_url":"https://api.github.com/repos/Itseez/opencv/git/commits{/sha}","comments_url":"https://api.github.com/repos/Itseez/opencv/comments{/number}","issue_comment_url":"https://api.github.com/repos/Itseez/opencv/issues/comments{/number}","contents_url":"https://api.github.com/repos/Itseez/opencv/contents/{+path}","compare_url":"https://api.github.com/repos/Itseez/opencv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Itseez/opencv/merges","archive_url":"https://api.github.com/repos/Itseez/opencv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Itseez/opencv/downloads","issues_url":"https://api.github.com/repos/Itseez/opencv/issues{/number}","pulls_url":"https://api.github.com/repos/Itseez/opencv/pulls{/number}","milestones_url":"https://api.github.com/repos/Itseez/opencv/milestones{/number}","notifications_url":"https://api.github.com/repos/Itseez/opencv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Itseez/opencv/labels{/name}","releases_url":"https://api.github.com/repos/Itseez/opencv/releases{/id}","deployments_url":"https://api.github.com/repos/Itseez/opencv/deployments","created_at":"2012-07-19T09:40:17Z","updated_at":"2016-06-01T03:06:37Z","pushed_at":"2016-05-31T17:39:22Z","git_url":"git://github.com/Itseez/opencv.git","ssh_url":"git@github.com:Itseez/opencv.git","clone_url":"https://github.com/Itseez/opencv.git","svn_url":"https://github.com/Itseez/opencv","homepage":"opencv.org","size":1075595,"stargazers_count":9752,"watchers_count":9752,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8264,"mirror_url":null,"open_issues_count":1050,"forks":8264,"open_issues":1050,"watchers":9752,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/6440"},"html":{"href":"https://github.com/Itseez/opencv/pull/6440"},"issue":{"href":"https://api.github.com/repos/Itseez/opencv/issues/6440"},"comments":{"href":"https://api.github.com/repos/Itseez/opencv/issues/6440/comments"},"review_comments":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/6440/comments"},"review_comment":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Itseez/opencv/pulls/6440/commits"},"statuses":{"href":"https://api.github.com/repos/Itseez/opencv/statuses/5a03cf830670f64d985f99c55b23d82232e866ba"}}}}
{"actor":{"display_login":"vpisarev"}}