{"action":"created","comment":{"url":"https://api.github.com/repos/SciTools/iris/pulls/comments/52718446","id":52718446,"diff_hunk":"@@ -902,6 +905,22 @@ def _all_other_rules(f):\n             (AuxCoord('son', long_name='season', units='no_unit'),\n              None))\n \n+    # Special case where year is zero and months match.\n+    # Month coordinates (--> scalar coordinates)\n+    if (f.lbtim.ib == 2 and f.lbtim.ic in [1, 2, 4] and\n+            ((len(f.lbcode) != 5) or\n+             (len(f.lbcode) == 5 and\n+              f.lbcode.ix not in [20, 21, 22, 23] and\n+              f.lbcode.iy not in [20, 21, 22, 23])) and\n+            f.lbyr == 0 and f.lbyrd == 0 and\n+            f.lbmon == f.lbmond):\n+        aux_coords_and_dims.append(\n+            (AuxCoord(f.lbmon, long_name='month_number', units='no_unit'),","path":"lib/iris/fileformats/pp_rules.py","position":27,"original_position":27,"commit_id":"d95690fe6ef09808d9d3955ffecbdff5ac484989","original_commit_id":"d95690fe6ef09808d9d3955ffecbdff5ac484989","user":{"login":"ajdawson","id":390602,"avatar_url":"https://avatars.githubusercontent.com/u/390602?v=3","gravatar_id":"","url":"https://api.github.com/users/ajdawson","html_url":"https://github.com/ajdawson","followers_url":"https://api.github.com/users/ajdawson/followers","following_url":"https://api.github.com/users/ajdawson/following{/other_user}","gists_url":"https://api.github.com/users/ajdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/ajdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajdawson/subscriptions","organizations_url":"https://api.github.com/users/ajdawson/orgs","repos_url":"https://api.github.com/users/ajdawson/repos","events_url":"https://api.github.com/users/ajdawson/events{/privacy}","received_events_url":"https://api.github.com/users/ajdawson/received_events","type":"User","site_admin":false},"body":"I'm no expert in this area, and I misunderstood what you were saying initially @marqh (thought you meant month instead of month_number, not as well), please proceed as you see fit.","created_at":"2016-02-12T09:10:22Z","updated_at":"2016-02-12T09:10:22Z","html_url":"https://github.com/SciTools/iris/pull/1926#discussion_r52718446","pull_request_url":"https://api.github.com/repos/SciTools/iris/pulls/1926","_links":{"self":{"href":"https://api.github.com/repos/SciTools/iris/pulls/comments/52718446"},"html":{"href":"https://github.com/SciTools/iris/pull/1926#discussion_r52718446"},"pull_request":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1926"}}},"pull_request":{"url":"https://api.github.com/repos/SciTools/iris/pulls/1926","id":58116128,"html_url":"https://github.com/SciTools/iris/pull/1926","diff_url":"https://github.com/SciTools/iris/pull/1926.diff","patch_url":"https://github.com/SciTools/iris/pull/1926.patch","issue_url":"https://api.github.com/repos/SciTools/iris/issues/1926","number":1926,"state":"open","locked":false,"title":"Add 'month' coord instead of 'time' in pp_rules when lbyr=0 and lbtim.ib==2","user":{"login":"djkirkham","id":16189532,"avatar_url":"https://avatars.githubusercontent.com/u/16189532?v=3","gravatar_id":"","url":"https://api.github.com/users/djkirkham","html_url":"https://github.com/djkirkham","followers_url":"https://api.github.com/users/djkirkham/followers","following_url":"https://api.github.com/users/djkirkham/following{/other_user}","gists_url":"https://api.github.com/users/djkirkham/gists{/gist_id}","starred_url":"https://api.github.com/users/djkirkham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djkirkham/subscriptions","organizations_url":"https://api.github.com/users/djkirkham/orgs","repos_url":"https://api.github.com/users/djkirkham/repos","events_url":"https://api.github.com/users/djkirkham/events{/privacy}","received_events_url":"https://api.github.com/users/djkirkham/received_events","type":"User","site_admin":false},"body":"This change fixes a bug with a class of pp files with lbyr == 0, where the date would cause errors when converting to a datetime object (e.g. when printing a cube).\r\n\r\nWhen processing a pp field with lbtim = 2x, lbyr == lbyrd == 0 and lbmon == lbmond, a numeric 'month' coordinate is created instead of 'time'.","created_at":"2016-02-03T10:15:32Z","updated_at":"2016-02-12T09:10:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65454e8f775ce7241ad04e94f57d82162a62c79e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SciTools/iris/pulls/1926/commits","review_comments_url":"https://api.github.com/repos/SciTools/iris/pulls/1926/comments","review_comment_url":"https://api.github.com/repos/SciTools/iris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SciTools/iris/issues/1926/comments","statuses_url":"https://api.github.com/repos/SciTools/iris/statuses/d95690fe6ef09808d9d3955ffecbdff5ac484989","head":{"label":"djkirkham:bugfix-EPM-1104-pp-zero-years","ref":"bugfix-EPM-1104-pp-zero-years","sha":"d95690fe6ef09808d9d3955ffecbdff5ac484989","user":{"login":"djkirkham","id":16189532,"avatar_url":"https://avatars.githubusercontent.com/u/16189532?v=3","gravatar_id":"","url":"https://api.github.com/users/djkirkham","html_url":"https://github.com/djkirkham","followers_url":"https://api.github.com/users/djkirkham/followers","following_url":"https://api.github.com/users/djkirkham/following{/other_user}","gists_url":"https://api.github.com/users/djkirkham/gists{/gist_id}","starred_url":"https://api.github.com/users/djkirkham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djkirkham/subscriptions","organizations_url":"https://api.github.com/users/djkirkham/orgs","repos_url":"https://api.github.com/users/djkirkham/repos","events_url":"https://api.github.com/users/djkirkham/events{/privacy}","received_events_url":"https://api.github.com/users/djkirkham/received_events","type":"User","site_admin":false},"repo":{"id":50017360,"name":"iris","full_name":"djkirkham/iris","owner":{"login":"djkirkham","id":16189532,"avatar_url":"https://avatars.githubusercontent.com/u/16189532?v=3","gravatar_id":"","url":"https://api.github.com/users/djkirkham","html_url":"https://github.com/djkirkham","followers_url":"https://api.github.com/users/djkirkham/followers","following_url":"https://api.github.com/users/djkirkham/following{/other_user}","gists_url":"https://api.github.com/users/djkirkham/gists{/gist_id}","starred_url":"https://api.github.com/users/djkirkham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djkirkham/subscriptions","organizations_url":"https://api.github.com/users/djkirkham/orgs","repos_url":"https://api.github.com/users/djkirkham/repos","events_url":"https://api.github.com/users/djkirkham/events{/privacy}","received_events_url":"https://api.github.com/users/djkirkham/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/djkirkham/iris","description":"A powerful, easy to use, and community-driven Python library for analysing and visualising meteorological and oceanographic data sets.","fork":true,"url":"https://api.github.com/repos/djkirkham/iris","forks_url":"https://api.github.com/repos/djkirkham/iris/forks","keys_url":"https://api.github.com/repos/djkirkham/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djkirkham/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djkirkham/iris/teams","hooks_url":"https://api.github.com/repos/djkirkham/iris/hooks","issue_events_url":"https://api.github.com/repos/djkirkham/iris/issues/events{/number}","events_url":"https://api.github.com/repos/djkirkham/iris/events","assignees_url":"https://api.github.com/repos/djkirkham/iris/assignees{/user}","branches_url":"https://api.github.com/repos/djkirkham/iris/branches{/branch}","tags_url":"https://api.github.com/repos/djkirkham/iris/tags","blobs_url":"https://api.github.com/repos/djkirkham/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djkirkham/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djkirkham/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/djkirkham/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djkirkham/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/djkirkham/iris/languages","stargazers_url":"https://api.github.com/repos/djkirkham/iris/stargazers","contributors_url":"https://api.github.com/repos/djkirkham/iris/contributors","subscribers_url":"https://api.github.com/repos/djkirkham/iris/subscribers","subscription_url":"https://api.github.com/repos/djkirkham/iris/subscription","commits_url":"https://api.github.com/repos/djkirkham/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/djkirkham/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/djkirkham/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/djkirkham/iris/issues/comments{/number}","contents_url":"https://api.github.com/repos/djkirkham/iris/contents/{+path}","compare_url":"https://api.github.com/repos/djkirkham/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djkirkham/iris/merges","archive_url":"https://api.github.com/repos/djkirkham/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djkirkham/iris/downloads","issues_url":"https://api.github.com/repos/djkirkham/iris/issues{/number}","pulls_url":"https://api.github.com/repos/djkirkham/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/djkirkham/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/djkirkham/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djkirkham/iris/labels{/name}","releases_url":"https://api.github.com/repos/djkirkham/iris/releases{/id}","deployments_url":"https://api.github.com/repos/djkirkham/iris/deployments","created_at":"2016-01-20T08:54:11Z","updated_at":"2016-01-20T08:54:16Z","pushed_at":"2016-02-11T13:32:37Z","git_url":"git://github.com/djkirkham/iris.git","ssh_url":"git@github.com:djkirkham/iris.git","clone_url":"https://github.com/djkirkham/iris.git","svn_url":"https://github.com/djkirkham/iris","homepage":"http://scitools.org.uk/iris/","size":99736,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SciTools:master","ref":"master","sha":"efda1f59e60bd83843eb7d75d42ca8a96ad7e38f","user":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars.githubusercontent.com/u/1391487?v=3","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"repo":{"id":5312648,"name":"iris","full_name":"SciTools/iris","owner":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars.githubusercontent.com/u/1391487?v=3","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SciTools/iris","description":"A powerful, easy to use, and community-driven Python library for analysing and visualising meteorological and oceanographic data sets.","fork":false,"url":"https://api.github.com/repos/SciTools/iris","forks_url":"https://api.github.com/repos/SciTools/iris/forks","keys_url":"https://api.github.com/repos/SciTools/iris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SciTools/iris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SciTools/iris/teams","hooks_url":"https://api.github.com/repos/SciTools/iris/hooks","issue_events_url":"https://api.github.com/repos/SciTools/iris/issues/events{/number}","events_url":"https://api.github.com/repos/SciTools/iris/events","assignees_url":"https://api.github.com/repos/SciTools/iris/assignees{/user}","branches_url":"https://api.github.com/repos/SciTools/iris/branches{/branch}","tags_url":"https://api.github.com/repos/SciTools/iris/tags","blobs_url":"https://api.github.com/repos/SciTools/iris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SciTools/iris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SciTools/iris/git/refs{/sha}","trees_url":"https://api.github.com/repos/SciTools/iris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SciTools/iris/statuses/{sha}","languages_url":"https://api.github.com/repos/SciTools/iris/languages","stargazers_url":"https://api.github.com/repos/SciTools/iris/stargazers","contributors_url":"https://api.github.com/repos/SciTools/iris/contributors","subscribers_url":"https://api.github.com/repos/SciTools/iris/subscribers","subscription_url":"https://api.github.com/repos/SciTools/iris/subscription","commits_url":"https://api.github.com/repos/SciTools/iris/commits{/sha}","git_commits_url":"https://api.github.com/repos/SciTools/iris/git/commits{/sha}","comments_url":"https://api.github.com/repos/SciTools/iris/comments{/number}","issue_comment_url":"https://api.github.com/repos/SciTools/iris/issues/comments{/number}","contents_url":"https://api.github.com/repos/SciTools/iris/contents/{+path}","compare_url":"https://api.github.com/repos/SciTools/iris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SciTools/iris/merges","archive_url":"https://api.github.com/repos/SciTools/iris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SciTools/iris/downloads","issues_url":"https://api.github.com/repos/SciTools/iris/issues{/number}","pulls_url":"https://api.github.com/repos/SciTools/iris/pulls{/number}","milestones_url":"https://api.github.com/repos/SciTools/iris/milestones{/number}","notifications_url":"https://api.github.com/repos/SciTools/iris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SciTools/iris/labels{/name}","releases_url":"https://api.github.com/repos/SciTools/iris/releases{/id}","deployments_url":"https://api.github.com/repos/SciTools/iris/deployments","created_at":"2012-08-06T10:09:14Z","updated_at":"2016-02-02T00:17:18Z","pushed_at":"2016-02-11T16:47:10Z","git_url":"git://github.com/SciTools/iris.git","ssh_url":"git@github.com:SciTools/iris.git","clone_url":"https://github.com/SciTools/iris.git","svn_url":"https://github.com/SciTools/iris","homepage":"http://scitools.org.uk/iris/","size":142176,"stargazers_count":116,"watchers_count":116,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":201,"forks":88,"open_issues":201,"watchers":116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1926"},"html":{"href":"https://github.com/SciTools/iris/pull/1926"},"issue":{"href":"https://api.github.com/repos/SciTools/iris/issues/1926"},"comments":{"href":"https://api.github.com/repos/SciTools/iris/issues/1926/comments"},"review_comments":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1926/comments"},"review_comment":{"href":"https://api.github.com/repos/SciTools/iris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SciTools/iris/pulls/1926/commits"},"statuses":{"href":"https://api.github.com/repos/SciTools/iris/statuses/d95690fe6ef09808d9d3955ffecbdff5ac484989"}}}}