{"action":"created","comment":{"url":"https://api.github.com/repos/LLNL/spack/pulls/comments/58600270","id":58600270,"diff_hunk":"@@ -101,7 +101,7 @@ def patch(self):\n \n     @property\n     def common_config_args(self):\n-        return [\n+        config_args = [\n             '-prefix', self.prefix,","path":"var/spack/repos/builtin/packages/qt/package.py","position":6,"original_position":6,"commit_id":"3a08722d199cc8c84d56ee8f4175de9ea272c712","original_commit_id":"3a08722d199cc8c84d56ee8f4175de9ea272c712","user":{"login":"adamjstewart","id":12021217,"avatar_url":"https://avatars.githubusercontent.com/u/12021217?v=3","gravatar_id":"","url":"https://api.github.com/users/adamjstewart","html_url":"https://github.com/adamjstewart","followers_url":"https://api.github.com/users/adamjstewart/followers","following_url":"https://api.github.com/users/adamjstewart/following{/other_user}","gists_url":"https://api.github.com/users/adamjstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjstewart/subscriptions","organizations_url":"https://api.github.com/users/adamjstewart/orgs","repos_url":"https://api.github.com/users/adamjstewart/repos","events_url":"https://api.github.com/users/adamjstewart/events{/privacy}","received_events_url":"https://api.github.com/users/adamjstewart/received_events","type":"User","site_admin":false},"body":"If you can figure out which options aren't supported by qt3, we can move these out of the common_config_args and into qt4/5 specific ones.","created_at":"2016-04-05T19:27:17Z","updated_at":"2016-04-05T19:27:17Z","html_url":"https://github.com/LLNL/spack/pull/708#discussion_r58600270","pull_request_url":"https://api.github.com/repos/LLNL/spack/pulls/708","_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments/58600270"},"html":{"href":"https://github.com/LLNL/spack/pull/708#discussion_r58600270"},"pull_request":{"href":"https://api.github.com/repos/LLNL/spack/pulls/708"}}},"pull_request":{"url":"https://api.github.com/repos/LLNL/spack/pulls/708","id":64843434,"html_url":"https://github.com/LLNL/spack/pull/708","diff_url":"https://github.com/LLNL/spack/pull/708.diff","patch_url":"https://github.com/LLNL/spack/pull/708.patch","issue_url":"https://api.github.com/repos/LLNL/spack/issues/708","number":708,"state":"open","locked":false,"title":"Prevent use of system GTK+","user":{"login":"adamjstewart","id":12021217,"avatar_url":"https://avatars.githubusercontent.com/u/12021217?v=3","gravatar_id":"","url":"https://api.github.com/users/adamjstewart","html_url":"https://github.com/adamjstewart","followers_url":"https://api.github.com/users/adamjstewart/followers","following_url":"https://api.github.com/users/adamjstewart/following{/other_user}","gists_url":"https://api.github.com/users/adamjstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjstewart/subscriptions","organizations_url":"https://api.github.com/users/adamjstewart/orgs","repos_url":"https://api.github.com/users/adamjstewart/repos","events_url":"https://api.github.com/users/adamjstewart/events{/privacy}","received_events_url":"https://api.github.com/users/adamjstewart/received_events","type":"User","site_admin":false},"body":"As suggested in #704, this should hopefully prevent the use of a system GTK+ when `~gtk` is chosen (the default). I haven't tested it myself, and I'm not familiar with qt, so someone else should test it.\r\n\r\nI assume the configure function for version 3 was missing `common_config_args`? If not I can remove it.","created_at":"2016-03-31T19:17:52Z","updated_at":"2016-04-05T19:27:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d66ddeb70833cb2cacc88d6481444f583dd56746","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/spack/pulls/708/commits","review_comments_url":"https://api.github.com/repos/LLNL/spack/pulls/708/comments","review_comment_url":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/708/comments","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/3a08722d199cc8c84d56ee8f4175de9ea272c712","head":{"label":"adamjstewart:fixes/qt","ref":"fixes/qt","sha":"3a08722d199cc8c84d56ee8f4175de9ea272c712","user":{"login":"adamjstewart","id":12021217,"avatar_url":"https://avatars.githubusercontent.com/u/12021217?v=3","gravatar_id":"","url":"https://api.github.com/users/adamjstewart","html_url":"https://github.com/adamjstewart","followers_url":"https://api.github.com/users/adamjstewart/followers","following_url":"https://api.github.com/users/adamjstewart/following{/other_user}","gists_url":"https://api.github.com/users/adamjstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjstewart/subscriptions","organizations_url":"https://api.github.com/users/adamjstewart/orgs","repos_url":"https://api.github.com/users/adamjstewart/repos","events_url":"https://api.github.com/users/adamjstewart/events{/privacy}","received_events_url":"https://api.github.com/users/adamjstewart/received_events","type":"User","site_admin":false},"repo":{"id":49444175,"name":"spack","full_name":"adamjstewart/spack","owner":{"login":"adamjstewart","id":12021217,"avatar_url":"https://avatars.githubusercontent.com/u/12021217?v=3","gravatar_id":"","url":"https://api.github.com/users/adamjstewart","html_url":"https://github.com/adamjstewart","followers_url":"https://api.github.com/users/adamjstewart/followers","following_url":"https://api.github.com/users/adamjstewart/following{/other_user}","gists_url":"https://api.github.com/users/adamjstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjstewart/subscriptions","organizations_url":"https://api.github.com/users/adamjstewart/orgs","repos_url":"https://api.github.com/users/adamjstewart/repos","events_url":"https://api.github.com/users/adamjstewart/events{/privacy}","received_events_url":"https://api.github.com/users/adamjstewart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adamjstewart/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":true,"url":"https://api.github.com/repos/adamjstewart/spack","forks_url":"https://api.github.com/repos/adamjstewart/spack/forks","keys_url":"https://api.github.com/repos/adamjstewart/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamjstewart/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamjstewart/spack/teams","hooks_url":"https://api.github.com/repos/adamjstewart/spack/hooks","issue_events_url":"https://api.github.com/repos/adamjstewart/spack/issues/events{/number}","events_url":"https://api.github.com/repos/adamjstewart/spack/events","assignees_url":"https://api.github.com/repos/adamjstewart/spack/assignees{/user}","branches_url":"https://api.github.com/repos/adamjstewart/spack/branches{/branch}","tags_url":"https://api.github.com/repos/adamjstewart/spack/tags","blobs_url":"https://api.github.com/repos/adamjstewart/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamjstewart/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamjstewart/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamjstewart/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamjstewart/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/adamjstewart/spack/languages","stargazers_url":"https://api.github.com/repos/adamjstewart/spack/stargazers","contributors_url":"https://api.github.com/repos/adamjstewart/spack/contributors","subscribers_url":"https://api.github.com/repos/adamjstewart/spack/subscribers","subscription_url":"https://api.github.com/repos/adamjstewart/spack/subscription","commits_url":"https://api.github.com/repos/adamjstewart/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamjstewart/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamjstewart/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamjstewart/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamjstewart/spack/contents/{+path}","compare_url":"https://api.github.com/repos/adamjstewart/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamjstewart/spack/merges","archive_url":"https://api.github.com/repos/adamjstewart/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamjstewart/spack/downloads","issues_url":"https://api.github.com/repos/adamjstewart/spack/issues{/number}","pulls_url":"https://api.github.com/repos/adamjstewart/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/adamjstewart/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/adamjstewart/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamjstewart/spack/labels{/name}","releases_url":"https://api.github.com/repos/adamjstewart/spack/releases{/id}","deployments_url":"https://api.github.com/repos/adamjstewart/spack/deployments","created_at":"2016-01-11T18:04:18Z","updated_at":"2016-01-11T18:04:19Z","pushed_at":"2016-04-05T16:01:05Z","git_url":"git://github.com/adamjstewart/spack.git","ssh_url":"git@github.com:adamjstewart/spack.git","clone_url":"https://github.com/adamjstewart/spack.git","svn_url":"https://github.com/adamjstewart/spack","homepage":"http://llnl.github.io/spack","size":5403,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"LLNL:develop","ref":"develop","sha":"d0c8245a58bf184f7921c853ef31734ea2c83e0a","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"LLNL/spack","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/LLNL/spack","forks_url":"https://api.github.com/repos/LLNL/spack/forks","keys_url":"https://api.github.com/repos/LLNL/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/spack/teams","hooks_url":"https://api.github.com/repos/LLNL/spack/hooks","issue_events_url":"https://api.github.com/repos/LLNL/spack/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/spack/events","assignees_url":"https://api.github.com/repos/LLNL/spack/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/spack/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/spack/tags","blobs_url":"https://api.github.com/repos/LLNL/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/spack/languages","stargazers_url":"https://api.github.com/repos/LLNL/spack/stargazers","contributors_url":"https://api.github.com/repos/LLNL/spack/contributors","subscribers_url":"https://api.github.com/repos/LLNL/spack/subscribers","subscription_url":"https://api.github.com/repos/LLNL/spack/subscription","commits_url":"https://api.github.com/repos/LLNL/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/spack/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/spack/merges","archive_url":"https://api.github.com/repos/LLNL/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/spack/downloads","issues_url":"https://api.github.com/repos/LLNL/spack/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/spack/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/spack/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2016-03-23T04:27:23Z","pushed_at":"2016-04-05T17:51:12Z","git_url":"git://github.com/LLNL/spack.git","ssh_url":"git@github.com:LLNL/spack.git","clone_url":"https://github.com/LLNL/spack.git","svn_url":"https://github.com/LLNL/spack","homepage":"http://software.llnl.gov/spack","size":12452,"stargazers_count":100,"watchers_count":100,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":92,"mirror_url":null,"open_issues_count":141,"forks":92,"open_issues":141,"watchers":100,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/708"},"html":{"href":"https://github.com/LLNL/spack/pull/708"},"issue":{"href":"https://api.github.com/repos/LLNL/spack/issues/708"},"comments":{"href":"https://api.github.com/repos/LLNL/spack/issues/708/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/spack/pulls/708/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/spack/pulls/708/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/spack/statuses/3a08722d199cc8c84d56ee8f4175de9ea272c712"}}}}