{"action":"created","comment":{"url":"https://api.github.com/repos/google/syzkaller/pulls/comments/74020266","id":74020266,"diff_hunk":"@@ -288,10 +288,13 @@ func generateArg(name, typ string, a []string, structs map[string]Struct, unname\n \t\t}\n \t\tfmt.Fprintf(out, \"PtrType{%v, Dir: %v, Type: StrConstType{%v, Val: \\\"%v\\\"}}\", common(), fmtDir(\"in\"), common(), a[0]+\"\\\\x00\")\n \tcase \"int8\", \"int16\", \"int32\", \"int64\", \"intptr\":\n-\t\tif want := 0; len(a) != want {\n-\t\t\tfailf(\"wrong number of arguments for %v arg %v, want %v, got %v\", typ, name, want, len(a))\n+\t\tif len(a) == 2 {","path":"sysgen/sysgen.go","position":6,"original_position":6,"commit_id":"aa87ebe231b944ea5e8a3b29345b2564755ec201","original_commit_id":"aa87ebe231b944ea5e8a3b29345b2564755ec201","user":{"login":"dvyukov","id":1095328,"avatar_url":"https://avatars.githubusercontent.com/u/1095328?v=3","gravatar_id":"","url":"https://api.github.com/users/dvyukov","html_url":"https://github.com/dvyukov","followers_url":"https://api.github.com/users/dvyukov/followers","following_url":"https://api.github.com/users/dvyukov/following{/other_user}","gists_url":"https://api.github.com/users/dvyukov/gists{/gist_id}","starred_url":"https://api.github.com/users/dvyukov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvyukov/subscriptions","organizations_url":"https://api.github.com/users/dvyukov/orgs","repos_url":"https://api.github.com/users/dvyukov/repos","events_url":"https://api.github.com/users/dvyukov/events{/privacy}","received_events_url":"https://api.github.com/users/dvyukov/received_events","type":"User","site_admin":false},"body":"It is meant to be inclusive range, or exclusive range?\r\nI think it's more intuitive to have an inclusive range.\r\nPlease extend description of int type on top of sys/sys.txt.\r\n\r\nI agree that using flags for ranges is tedious.\r\nBut my concern is that once we give some meaning to arguments of a type, it will be difficult to change it (some users can have private syscall descriptions). E.g. if later we come up with better meaning for int arguments, we won't be able to change it.\r\nI think that ultimately we want to support not only ranges, but arbitrary sets of values. For example:\r\n```\r\nfoo int32[0, 5-10, 50, 100-200]\r\n```\r\nSo please change the range format to `[begin-end]`. We will be able to extend such form the more general form.\r\nYou can use the following code for parsing:\r\nhttps://play.golang.org/p/CQwd_G6keY\r\n","created_at":"2016-08-09T08:45:53Z","updated_at":"2016-08-09T08:45:53Z","html_url":"https://github.com/google/syzkaller/pull/53#discussion_r74020266","pull_request_url":"https://api.github.com/repos/google/syzkaller/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/google/syzkaller/pulls/comments/74020266"},"html":{"href":"https://github.com/google/syzkaller/pull/53#discussion_r74020266"},"pull_request":{"href":"https://api.github.com/repos/google/syzkaller/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/google/syzkaller/pulls/53","id":80452204,"html_url":"https://github.com/google/syzkaller/pull/53","diff_url":"https://github.com/google/syzkaller/pull/53.diff","patch_url":"https://github.com/google/syzkaller/pull/53.patch","issue_url":"https://api.github.com/repos/google/syzkaller/issues/53","number":53,"state":"open","locked":false,"title":"support range int","user":{"login":"sploving","id":721677,"avatar_url":"https://avatars.githubusercontent.com/u/721677?v=3","gravatar_id":"","url":"https://api.github.com/users/sploving","html_url":"https://github.com/sploving","followers_url":"https://api.github.com/users/sploving/followers","following_url":"https://api.github.com/users/sploving/following{/other_user}","gists_url":"https://api.github.com/users/sploving/gists{/gist_id}","starred_url":"https://api.github.com/users/sploving/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sploving/subscriptions","organizations_url":"https://api.github.com/users/sploving/orgs","repos_url":"https://api.github.com/users/sploving/repos","events_url":"https://api.github.com/users/sploving/events{/privacy}","received_events_url":"https://api.github.com/users/sploving/received_events","type":"User","site_admin":false},"body":"This commit support range int. For instance,   a filed x with int8 [3, 6], means that x could be 3, 4, 5. This is useful for some system calls ,which only accepts a range integer.","created_at":"2016-08-08T13:38:03Z","updated_at":"2016-08-09T08:45:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df02c11e3147a07741ec805f86596b22b014febe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/syzkaller/pulls/53/commits","review_comments_url":"https://api.github.com/repos/google/syzkaller/pulls/53/comments","review_comment_url":"https://api.github.com/repos/google/syzkaller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/syzkaller/issues/53/comments","statuses_url":"https://api.github.com/repos/google/syzkaller/statuses/aa87ebe231b944ea5e8a3b29345b2564755ec201","head":{"label":"sploving:master","ref":"master","sha":"aa87ebe231b944ea5e8a3b29345b2564755ec201","user":{"login":"sploving","id":721677,"avatar_url":"https://avatars.githubusercontent.com/u/721677?v=3","gravatar_id":"","url":"https://api.github.com/users/sploving","html_url":"https://github.com/sploving","followers_url":"https://api.github.com/users/sploving/followers","following_url":"https://api.github.com/users/sploving/following{/other_user}","gists_url":"https://api.github.com/users/sploving/gists{/gist_id}","starred_url":"https://api.github.com/users/sploving/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sploving/subscriptions","organizations_url":"https://api.github.com/users/sploving/orgs","repos_url":"https://api.github.com/users/sploving/repos","events_url":"https://api.github.com/users/sploving/events{/privacy}","received_events_url":"https://api.github.com/users/sploving/received_events","type":"User","site_admin":false},"repo":{"id":50329394,"name":"syzkaller","full_name":"sploving/syzkaller","owner":{"login":"sploving","id":721677,"avatar_url":"https://avatars.githubusercontent.com/u/721677?v=3","gravatar_id":"","url":"https://api.github.com/users/sploving","html_url":"https://github.com/sploving","followers_url":"https://api.github.com/users/sploving/followers","following_url":"https://api.github.com/users/sploving/following{/other_user}","gists_url":"https://api.github.com/users/sploving/gists{/gist_id}","starred_url":"https://api.github.com/users/sploving/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sploving/subscriptions","organizations_url":"https://api.github.com/users/sploving/orgs","repos_url":"https://api.github.com/users/sploving/repos","events_url":"https://api.github.com/users/sploving/events{/privacy}","received_events_url":"https://api.github.com/users/sploving/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sploving/syzkaller","description":"syzkaller is a distributed, unsupervised, coverage-guided Linux syscall fuzzer","fork":true,"url":"https://api.github.com/repos/sploving/syzkaller","forks_url":"https://api.github.com/repos/sploving/syzkaller/forks","keys_url":"https://api.github.com/repos/sploving/syzkaller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sploving/syzkaller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sploving/syzkaller/teams","hooks_url":"https://api.github.com/repos/sploving/syzkaller/hooks","issue_events_url":"https://api.github.com/repos/sploving/syzkaller/issues/events{/number}","events_url":"https://api.github.com/repos/sploving/syzkaller/events","assignees_url":"https://api.github.com/repos/sploving/syzkaller/assignees{/user}","branches_url":"https://api.github.com/repos/sploving/syzkaller/branches{/branch}","tags_url":"https://api.github.com/repos/sploving/syzkaller/tags","blobs_url":"https://api.github.com/repos/sploving/syzkaller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sploving/syzkaller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sploving/syzkaller/git/refs{/sha}","trees_url":"https://api.github.com/repos/sploving/syzkaller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sploving/syzkaller/statuses/{sha}","languages_url":"https://api.github.com/repos/sploving/syzkaller/languages","stargazers_url":"https://api.github.com/repos/sploving/syzkaller/stargazers","contributors_url":"https://api.github.com/repos/sploving/syzkaller/contributors","subscribers_url":"https://api.github.com/repos/sploving/syzkaller/subscribers","subscription_url":"https://api.github.com/repos/sploving/syzkaller/subscription","commits_url":"https://api.github.com/repos/sploving/syzkaller/commits{/sha}","git_commits_url":"https://api.github.com/repos/sploving/syzkaller/git/commits{/sha}","comments_url":"https://api.github.com/repos/sploving/syzkaller/comments{/number}","issue_comment_url":"https://api.github.com/repos/sploving/syzkaller/issues/comments{/number}","contents_url":"https://api.github.com/repos/sploving/syzkaller/contents/{+path}","compare_url":"https://api.github.com/repos/sploving/syzkaller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sploving/syzkaller/merges","archive_url":"https://api.github.com/repos/sploving/syzkaller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sploving/syzkaller/downloads","issues_url":"https://api.github.com/repos/sploving/syzkaller/issues{/number}","pulls_url":"https://api.github.com/repos/sploving/syzkaller/pulls{/number}","milestones_url":"https://api.github.com/repos/sploving/syzkaller/milestones{/number}","notifications_url":"https://api.github.com/repos/sploving/syzkaller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sploving/syzkaller/labels{/name}","releases_url":"https://api.github.com/repos/sploving/syzkaller/releases{/id}","deployments_url":"https://api.github.com/repos/sploving/syzkaller/deployments","created_at":"2016-01-25T05:54:48Z","updated_at":"2016-01-31T02:42:19Z","pushed_at":"2016-08-08T13:33:18Z","git_url":"git://github.com/sploving/syzkaller.git","ssh_url":"git@github.com:sploving/syzkaller.git","clone_url":"https://github.com/sploving/syzkaller.git","svn_url":"https://github.com/sploving/syzkaller","homepage":"","size":1410,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"39350d876d19ab0937511d969844fb9a559dfd8d","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":44087204,"name":"syzkaller","full_name":"google/syzkaller","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/syzkaller","description":"syzkaller is a distributed, unsupervised, coverage-guided Linux syscall fuzzer","fork":false,"url":"https://api.github.com/repos/google/syzkaller","forks_url":"https://api.github.com/repos/google/syzkaller/forks","keys_url":"https://api.github.com/repos/google/syzkaller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/syzkaller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/syzkaller/teams","hooks_url":"https://api.github.com/repos/google/syzkaller/hooks","issue_events_url":"https://api.github.com/repos/google/syzkaller/issues/events{/number}","events_url":"https://api.github.com/repos/google/syzkaller/events","assignees_url":"https://api.github.com/repos/google/syzkaller/assignees{/user}","branches_url":"https://api.github.com/repos/google/syzkaller/branches{/branch}","tags_url":"https://api.github.com/repos/google/syzkaller/tags","blobs_url":"https://api.github.com/repos/google/syzkaller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/syzkaller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/syzkaller/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/syzkaller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/syzkaller/statuses/{sha}","languages_url":"https://api.github.com/repos/google/syzkaller/languages","stargazers_url":"https://api.github.com/repos/google/syzkaller/stargazers","contributors_url":"https://api.github.com/repos/google/syzkaller/contributors","subscribers_url":"https://api.github.com/repos/google/syzkaller/subscribers","subscription_url":"https://api.github.com/repos/google/syzkaller/subscription","commits_url":"https://api.github.com/repos/google/syzkaller/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/syzkaller/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/syzkaller/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/syzkaller/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/syzkaller/contents/{+path}","compare_url":"https://api.github.com/repos/google/syzkaller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/syzkaller/merges","archive_url":"https://api.github.com/repos/google/syzkaller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/syzkaller/downloads","issues_url":"https://api.github.com/repos/google/syzkaller/issues{/number}","pulls_url":"https://api.github.com/repos/google/syzkaller/pulls{/number}","milestones_url":"https://api.github.com/repos/google/syzkaller/milestones{/number}","notifications_url":"https://api.github.com/repos/google/syzkaller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/syzkaller/labels{/name}","releases_url":"https://api.github.com/repos/google/syzkaller/releases{/id}","deployments_url":"https://api.github.com/repos/google/syzkaller/deployments","created_at":"2015-10-12T06:05:05Z","updated_at":"2016-08-06T06:11:30Z","pushed_at":"2016-08-08T13:38:04Z","git_url":"git://github.com/google/syzkaller.git","ssh_url":"git@github.com:google/syzkaller.git","clone_url":"https://github.com/google/syzkaller.git","svn_url":"https://github.com/google/syzkaller","homepage":"","size":1410,"stargazers_count":335,"watchers_count":335,"language":"Go","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":13,"forks":58,"open_issues":13,"watchers":335,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/syzkaller/pulls/53"},"html":{"href":"https://github.com/google/syzkaller/pull/53"},"issue":{"href":"https://api.github.com/repos/google/syzkaller/issues/53"},"comments":{"href":"https://api.github.com/repos/google/syzkaller/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/google/syzkaller/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/google/syzkaller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/syzkaller/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/google/syzkaller/statuses/aa87ebe231b944ea5e8a3b29345b2564755ec201"}}}}
{"actor":{"display_login":"dvyukov"}}