{"action":"created","issue":{"url":"https://api.github.com/repos/thunder-project/thunder/issues/283","repository_url":"https://api.github.com/repos/thunder-project/thunder","labels_url":"https://api.github.com/repos/thunder-project/thunder/issues/283/labels{/name}","comments_url":"https://api.github.com/repos/thunder-project/thunder/issues/283/comments","events_url":"https://api.github.com/repos/thunder-project/thunder/issues/283/events","html_url":"https://github.com/thunder-project/thunder/issues/283","id":149551376,"number":283,"title":"Thunder 1.0.0 Error Loading Multipage Tiffs with \"start=\" and \"stop=\" arguments","user":{"login":"kkcthans","id":15696062,"avatar_url":"https://avatars.githubusercontent.com/u/15696062?v=3","gravatar_id":"","url":"https://api.github.com/users/kkcthans","html_url":"https://github.com/kkcthans","followers_url":"https://api.github.com/users/kkcthans/followers","following_url":"https://api.github.com/users/kkcthans/following{/other_user}","gists_url":"https://api.github.com/users/kkcthans/gists{/gist_id}","starred_url":"https://api.github.com/users/kkcthans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkcthans/subscriptions","organizations_url":"https://api.github.com/users/kkcthans/orgs","repos_url":"https://api.github.com/users/kkcthans/repos","events_url":"https://api.github.com/users/kkcthans/events{/privacy}","received_events_url":"https://api.github.com/users/kkcthans/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-19T18:59:54Z","updated_at":"2016-04-19T23:37:46Z","closed_at":null,"body":"When loading a multipage tif, I get an error (shown below) if I use the start= or stop= arguments for thunder.images.fromtif().  I can load the whole multipage tif just fine, and I only get this error when I add start= and stop= arguments.  I was able to load the same file correctly with thunder 0.6, but it is not working as expected in thunder 1.0.0.\r\n\r\nI've tried going through the code to see if I could do my own pull request, but couldn't quite figure out why the error was changing when there was the start= and stop= arguments.  \r\n\r\nI don't receive this error if I use a directory with single image tiffs saved in the directory.  The start= and stop= arguments work as expected in that context.\r\n\r\n\r\n---------------------------------------------------------------------------\r\nValueError                                Traceback (most recent call last)\r\n<ipython-input-9-553dc6735bb2> in <module>()\r\n----> 1 imgs = td.images.fromtif(fn, start=1, stop=10, nplanes=1)\r\n\r\nC:\\Users\\Kyle\\Anaconda\\lib\\site-packages\\thunder\\images\\readers.pyc in fromtif(path, ext, start, stop, recursive, nplanes, npartitions, labels, engine, credentials)\r\n    371     return frompath(path, accessor=getarray, ext=ext, start=start, stop=stop,\r\n    372                     recursive=recursive, npartitions=npartitions, recount=recount,\r\n--> 373                     labels=labels, engine=engine, credentials=credentials)\r\n    374\r\n    375 def frompng(path, ext='png', start=None, stop=None, recursive=False, npartitions=None, labels=None, engine=None, credentials=None):\r\n\r\nC:\\Users\\Kyle\\Anaconda\\lib\\site-packages\\thunder\\images\\readers.pyc in frompath(path, accessor, ext, start, stop, recursive, npartitions, dims, dtype, labels, recount, engine, credentials)\r\n    208         flattened = list(itertools.chain(*data))\r\n    209         values = [kv[1] for kv in flattened]\r\n--> 210         return fromarray(values, labels=labels)\r\n    211\r\n    212\r\n\r\nC:\\Users\\Kyle\\Anaconda\\lib\\site-packages\\thunder\\images\\readers.pyc in fromarray(values, labels, npartitions, engine)\r\n     79\r\n     80     if values.ndim < 2:\r\n---> 81         raise ValueError('Array for images must have at least 2 dimensions, got %g' % values.ndim)\r\n     82\r\n     83     if values.ndim == 2:\r\n\r\nValueError: Array for images must have at least 2 dimensions, got 1"},"comment":{"url":"https://api.github.com/repos/thunder-project/thunder/issues/comments/212171818","html_url":"https://github.com/thunder-project/thunder/issues/283#issuecomment-212171818","issue_url":"https://api.github.com/repos/thunder-project/thunder/issues/283","id":212171818,"user":{"login":"freeman-lab","id":3387500,"avatar_url":"https://avatars.githubusercontent.com/u/3387500?v=3","gravatar_id":"","url":"https://api.github.com/users/freeman-lab","html_url":"https://github.com/freeman-lab","followers_url":"https://api.github.com/users/freeman-lab/followers","following_url":"https://api.github.com/users/freeman-lab/following{/other_user}","gists_url":"https://api.github.com/users/freeman-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/freeman-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeman-lab/subscriptions","organizations_url":"https://api.github.com/users/freeman-lab/orgs","repos_url":"https://api.github.com/users/freeman-lab/repos","events_url":"https://api.github.com/users/freeman-lab/events{/privacy}","received_events_url":"https://api.github.com/users/freeman-lab/received_events","type":"User","site_admin":false},"created_at":"2016-04-19T23:37:46Z","updated_at":"2016-04-19T23:37:46Z","body":"@kkcthans weird, thanks for reporting! \r\n\r\nJust so I understand, you're trying to load a *single* multi-page tif which has, say, 100 images, and you're calling it with `start=1` and `stop=10` to only load the first 9 images? And it loads the whole thing fine if you don't use those arguments? And it worked in 0.6? \r\n\r\nAs far as I recall `start` and `stop` have always referred to *files* not *images*, both in 0.6 and in 1.0, so in your example I'm surprised that it ever worked as you describe! But maybe I'm confused.\r\n\r\nIn the meantime, I'll start playing around with a test multi-page tif.\r\n\r\n@boazmohar  am I right about this? You do a lot with multi-page tifs."}}