{"action":"created","comment":{"url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/pulls/comments/61129453","id":61129453,"diff_hunk":"@@ -33,7 +34,10 @@ export default function routes({ createRoutes, createStore, stats, dist }) {\n                 this.status = 200;\n                 this.body = renderPage();\n             } else {\n-                const store = createStore ? createStore() : null;\n+                const { store, history, url } = setupForRender(createStore, this.url);\n+\n+                // Give Koa middlewares a chance to interact with the reduxStore\n+                // This can be used to dynamically pass some data to the client.","path":"packages/roc-package-web-app-react/app/server/router.js","position":16,"original_position":16,"commit_id":"b84d2ab58b2b95ec5ba231758b453c0f08321885","original_commit_id":"b84d2ab58b2b95ec5ba231758b453c0f08321885","user":{"login":"PAkerstrand","id":463105,"avatar_url":"https://avatars.githubusercontent.com/u/463105?v=3","gravatar_id":"","url":"https://api.github.com/users/PAkerstrand","html_url":"https://github.com/PAkerstrand","followers_url":"https://api.github.com/users/PAkerstrand/followers","following_url":"https://api.github.com/users/PAkerstrand/following{/other_user}","gists_url":"https://api.github.com/users/PAkerstrand/gists{/gist_id}","starred_url":"https://api.github.com/users/PAkerstrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PAkerstrand/subscriptions","organizations_url":"https://api.github.com/users/PAkerstrand/orgs","repos_url":"https://api.github.com/users/PAkerstrand/repos","events_url":"https://api.github.com/users/PAkerstrand/events{/privacy}","received_events_url":"https://api.github.com/users/PAkerstrand/received_events","type":"User","site_admin":false},"body":"Or could we run the `match` before creating the store? That way we know if we're in the loop at all or not ","created_at":"2016-04-26T17:34:38Z","updated_at":"2016-04-26T17:34:38Z","html_url":"https://github.com/rocjs/roc-package-web-app-react/pull/7#discussion_r61129453","pull_request_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/rocjs/roc-package-web-app-react/pulls/comments/61129453"},"html":{"href":"https://github.com/rocjs/roc-package-web-app-react/pull/7#discussion_r61129453"},"pull_request":{"href":"https://api.github.com/repos/rocjs/roc-package-web-app-react/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/pulls/7","id":67893792,"html_url":"https://github.com/rocjs/roc-package-web-app-react/pull/7","diff_url":"https://github.com/rocjs/roc-package-web-app-react/pull/7.diff","patch_url":"https://github.com/rocjs/roc-package-web-app-react/pull/7.patch","issue_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/issues/7","number":7,"state":"open","locked":false,"title":"React 15 - Updates most dependencies to the latest version","user":{"login":"DLMR","id":2854610,"avatar_url":"https://avatars.githubusercontent.com/u/2854610?v=3","gravatar_id":"","url":"https://api.github.com/users/DLMR","html_url":"https://github.com/DLMR","followers_url":"https://api.github.com/users/DLMR/followers","following_url":"https://api.github.com/users/DLMR/following{/other_user}","gists_url":"https://api.github.com/users/DLMR/gists{/gist_id}","starred_url":"https://api.github.com/users/DLMR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DLMR/subscriptions","organizations_url":"https://api.github.com/users/DLMR/orgs","repos_url":"https://api.github.com/users/DLMR/repos","events_url":"https://api.github.com/users/DLMR/events{/privacy}","received_events_url":"https://api.github.com/users/DLMR/received_events","type":"User","site_admin":false},"body":"Also the examples are updated to reflect this change.\r\n\r\nI have not updated React Helmet to the latest version since it was a bit to many questions about what has changed in the latest version.\r\n\r\nI think we can consider that this closes #2.","created_at":"2016-04-26T14:18:12Z","updated_at":"2016-04-26T17:34:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fe566a05b1ffc1719a64d1c49a23b98aeec81ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/pulls/7/commits","review_comments_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/pulls/7/comments","review_comment_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/issues/7/comments","statuses_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/statuses/b84d2ab58b2b95ec5ba231758b453c0f08321885","head":{"label":"rocjs:feature/react-15","ref":"feature/react-15","sha":"b84d2ab58b2b95ec5ba231758b453c0f08321885","user":{"login":"rocjs","id":17178245,"avatar_url":"https://avatars.githubusercontent.com/u/17178245?v=3","gravatar_id":"","url":"https://api.github.com/users/rocjs","html_url":"https://github.com/rocjs","followers_url":"https://api.github.com/users/rocjs/followers","following_url":"https://api.github.com/users/rocjs/following{/other_user}","gists_url":"https://api.github.com/users/rocjs/gists{/gist_id}","starred_url":"https://api.github.com/users/rocjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocjs/subscriptions","organizations_url":"https://api.github.com/users/rocjs/orgs","repos_url":"https://api.github.com/users/rocjs/repos","events_url":"https://api.github.com/users/rocjs/events{/privacy}","received_events_url":"https://api.github.com/users/rocjs/received_events","type":"Organization","site_admin":false},"repo":{"id":52596083,"name":"roc-package-web-app-react","full_name":"rocjs/roc-package-web-app-react","owner":{"login":"rocjs","id":17178245,"avatar_url":"https://avatars.githubusercontent.com/u/17178245?v=3","gravatar_id":"","url":"https://api.github.com/users/rocjs","html_url":"https://github.com/rocjs","followers_url":"https://api.github.com/users/rocjs/followers","following_url":"https://api.github.com/users/rocjs/following{/other_user}","gists_url":"https://api.github.com/users/rocjs/gists{/gist_id}","starred_url":"https://api.github.com/users/rocjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocjs/subscriptions","organizations_url":"https://api.github.com/users/rocjs/orgs","repos_url":"https://api.github.com/users/rocjs/repos","events_url":"https://api.github.com/users/rocjs/events{/privacy}","received_events_url":"https://api.github.com/users/rocjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rocjs/roc-package-web-app-react","description":"","fork":false,"url":"https://api.github.com/repos/rocjs/roc-package-web-app-react","forks_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/forks","keys_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/teams","hooks_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/hooks","issue_events_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/issues/events{/number}","events_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/events","assignees_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/assignees{/user}","branches_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/branches{/branch}","tags_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/tags","blobs_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/statuses/{sha}","languages_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/languages","stargazers_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/stargazers","contributors_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/contributors","subscribers_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/subscribers","subscription_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/subscription","commits_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/contents/{+path}","compare_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/merges","archive_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/downloads","issues_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/issues{/number}","pulls_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/pulls{/number}","milestones_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/milestones{/number}","notifications_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/labels{/name}","releases_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/releases{/id}","deployments_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/deployments","created_at":"2016-02-26T10:08:52Z","updated_at":"2016-04-19T13:11:43Z","pushed_at":"2016-04-26T14:18:12Z","git_url":"git://github.com/rocjs/roc-package-web-app-react.git","ssh_url":"git@github.com:rocjs/roc-package-web-app-react.git","clone_url":"https://github.com/rocjs/roc-package-web-app-react.git","svn_url":"https://github.com/rocjs/roc-package-web-app-react","homepage":null,"size":88,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"rocjs:master","ref":"master","sha":"508c6cf926e464d6ef980d5f9ba78ed17e54cadc","user":{"login":"rocjs","id":17178245,"avatar_url":"https://avatars.githubusercontent.com/u/17178245?v=3","gravatar_id":"","url":"https://api.github.com/users/rocjs","html_url":"https://github.com/rocjs","followers_url":"https://api.github.com/users/rocjs/followers","following_url":"https://api.github.com/users/rocjs/following{/other_user}","gists_url":"https://api.github.com/users/rocjs/gists{/gist_id}","starred_url":"https://api.github.com/users/rocjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocjs/subscriptions","organizations_url":"https://api.github.com/users/rocjs/orgs","repos_url":"https://api.github.com/users/rocjs/repos","events_url":"https://api.github.com/users/rocjs/events{/privacy}","received_events_url":"https://api.github.com/users/rocjs/received_events","type":"Organization","site_admin":false},"repo":{"id":52596083,"name":"roc-package-web-app-react","full_name":"rocjs/roc-package-web-app-react","owner":{"login":"rocjs","id":17178245,"avatar_url":"https://avatars.githubusercontent.com/u/17178245?v=3","gravatar_id":"","url":"https://api.github.com/users/rocjs","html_url":"https://github.com/rocjs","followers_url":"https://api.github.com/users/rocjs/followers","following_url":"https://api.github.com/users/rocjs/following{/other_user}","gists_url":"https://api.github.com/users/rocjs/gists{/gist_id}","starred_url":"https://api.github.com/users/rocjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocjs/subscriptions","organizations_url":"https://api.github.com/users/rocjs/orgs","repos_url":"https://api.github.com/users/rocjs/repos","events_url":"https://api.github.com/users/rocjs/events{/privacy}","received_events_url":"https://api.github.com/users/rocjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rocjs/roc-package-web-app-react","description":"","fork":false,"url":"https://api.github.com/repos/rocjs/roc-package-web-app-react","forks_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/forks","keys_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/teams","hooks_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/hooks","issue_events_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/issues/events{/number}","events_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/events","assignees_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/assignees{/user}","branches_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/branches{/branch}","tags_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/tags","blobs_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/statuses/{sha}","languages_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/languages","stargazers_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/stargazers","contributors_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/contributors","subscribers_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/subscribers","subscription_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/subscription","commits_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/contents/{+path}","compare_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/merges","archive_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/downloads","issues_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/issues{/number}","pulls_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/pulls{/number}","milestones_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/milestones{/number}","notifications_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/labels{/name}","releases_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/releases{/id}","deployments_url":"https://api.github.com/repos/rocjs/roc-package-web-app-react/deployments","created_at":"2016-02-26T10:08:52Z","updated_at":"2016-04-19T13:11:43Z","pushed_at":"2016-04-26T14:18:12Z","git_url":"git://github.com/rocjs/roc-package-web-app-react.git","ssh_url":"git@github.com:rocjs/roc-package-web-app-react.git","clone_url":"https://github.com/rocjs/roc-package-web-app-react.git","svn_url":"https://github.com/rocjs/roc-package-web-app-react","homepage":null,"size":88,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rocjs/roc-package-web-app-react/pulls/7"},"html":{"href":"https://github.com/rocjs/roc-package-web-app-react/pull/7"},"issue":{"href":"https://api.github.com/repos/rocjs/roc-package-web-app-react/issues/7"},"comments":{"href":"https://api.github.com/repos/rocjs/roc-package-web-app-react/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/rocjs/roc-package-web-app-react/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/rocjs/roc-package-web-app-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rocjs/roc-package-web-app-react/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/rocjs/roc-package-web-app-react/statuses/b84d2ab58b2b95ec5ba231758b453c0f08321885"}}}}