{"action":"created","issue":{"url":"https://api.github.com/repos/jakubgarfield/Bonobo-Git-Server/issues/443","repository_url":"https://api.github.com/repos/jakubgarfield/Bonobo-Git-Server","labels_url":"https://api.github.com/repos/jakubgarfield/Bonobo-Git-Server/issues/443/labels{/name}","comments_url":"https://api.github.com/repos/jakubgarfield/Bonobo-Git-Server/issues/443/comments","events_url":"https://api.github.com/repos/jakubgarfield/Bonobo-Git-Server/issues/443/events","html_url":"https://github.com/jakubgarfield/Bonobo-Git-Server/issues/443","id":132525542,"number":443,"title":"Repo name case sensitivity is inconsistent","user":{"login":"willdean","id":1306085,"avatar_url":"https://avatars.githubusercontent.com/u/1306085?v=3","gravatar_id":"","url":"https://api.github.com/users/willdean","html_url":"https://github.com/willdean","followers_url":"https://api.github.com/users/willdean/followers","following_url":"https://api.github.com/users/willdean/following{/other_user}","gists_url":"https://api.github.com/users/willdean/gists{/gist_id}","starred_url":"https://api.github.com/users/willdean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willdean/subscriptions","organizations_url":"https://api.github.com/users/willdean/orgs","repos_url":"https://api.github.com/users/willdean/repos","events_url":"https://api.github.com/users/willdean/events{/privacy}","received_events_url":"https://api.github.com/users/willdean/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-02-09T20:33:30Z","updated_at":"2016-02-10T15:14:05Z","closed_at":null,"body":"We had a problem today which was caused by someone being given a repo name to clone which was the right name but with a casing error in it.\r\n\r\nThis triggered issued #441 which has now been fixed, but this led me to look into the subject of casing, because even with the fix for #441, you get an **authorisation** error if you mis-case a repo name, not a 'Not found' error, which IMO would point more quickly to the cause.\r\n\r\nIt seems that Bonobo is 'a bit case-sensitive' on repo names, but not very.\r\n\r\nFor example `EFRepositoryPermissionService.HasPermission` needs a repo to have the right case, because otherwise it can't find it.   However, `GitController` does something like this:\r\n\r\n            var directory = GetDirectoryInfo(project);\r\n            if (Repository.IsValid(directory.FullName))\r\n\r\nand this is not case-sensitive - so where this test is performed, it doesn't return a Not Found error, but the auth layer will probably fail you anyway.\r\n\r\nMy personal feeling is that repo names in URLs should be case-sensitive, if for no other reason than that they are are GitHub, but either way, the whole app should be consistent.  (Update: I'm not actually sure they are case-sensitive at GitHub now - I've read both things now, and perhaps they shouldn't be case-sensitive because Windows isn't, and after all we're only looking at file/directory names really)\r\n\r\nI'm happy to produce a PR to fix this in either direction, depending on what people ( @jakubgarfield, @RedX2501  ?)  think is best.\r\n"},"comment":{"url":"https://api.github.com/repos/jakubgarfield/Bonobo-Git-Server/issues/comments/182418440","html_url":"https://github.com/jakubgarfield/Bonobo-Git-Server/issues/443#issuecomment-182418440","issue_url":"https://api.github.com/repos/jakubgarfield/Bonobo-Git-Server/issues/443","id":182418440,"user":{"login":"latop2604","id":2058133,"avatar_url":"https://avatars.githubusercontent.com/u/2058133?v=3","gravatar_id":"","url":"https://api.github.com/users/latop2604","html_url":"https://github.com/latop2604","followers_url":"https://api.github.com/users/latop2604/followers","following_url":"https://api.github.com/users/latop2604/following{/other_user}","gists_url":"https://api.github.com/users/latop2604/gists{/gist_id}","starred_url":"https://api.github.com/users/latop2604/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latop2604/subscriptions","organizations_url":"https://api.github.com/users/latop2604/orgs","repos_url":"https://api.github.com/users/latop2604/repos","events_url":"https://api.github.com/users/latop2604/events{/privacy}","received_events_url":"https://api.github.com/users/latop2604/received_events","type":"User","site_admin":false},"created_at":"2016-02-10T15:14:05Z","updated_at":"2016-02-10T15:14:05Z","body":"The underlying repo storage system (windows) is case insensitive. \r\nUnless you want to support .net core and linux, bonobo should be case insensitive. "}}