{"action":"created","issue":{"url":"https://api.github.com/repos/videojs/video.js/issues/3440","repository_url":"https://api.github.com/repos/videojs/video.js","labels_url":"https://api.github.com/repos/videojs/video.js/issues/3440/labels{/name}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/3440/comments","events_url":"https://api.github.com/repos/videojs/video.js/issues/3440/events","html_url":"https://github.com/videojs/video.js/pull/3440","id":166326838,"number":3440,"title":"Validate errorDisplay as it can be disabled in options (fixes #3014)","user":{"login":"ntadej","id":805384,"avatar_url":"https://avatars.githubusercontent.com/u/805384?v=3","gravatar_id":"","url":"https://api.github.com/users/ntadej","html_url":"https://github.com/ntadej","followers_url":"https://api.github.com/users/ntadej/followers","following_url":"https://api.github.com/users/ntadej/following{/other_user}","gists_url":"https://api.github.com/users/ntadej/gists{/gist_id}","starred_url":"https://api.github.com/users/ntadej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntadej/subscriptions","organizations_url":"https://api.github.com/users/ntadej/orgs","repos_url":"https://api.github.com/users/ntadej/repos","events_url":"https://api.github.com/users/ntadej/events{/privacy}","received_events_url":"https://api.github.com/users/ntadej/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/videojs/video.js/labels/needs:%20LGTM","name":"needs: LGTM","color":"207de5"},{"url":"https://api.github.com/repos/videojs/video.js/labels/patch","name":"patch","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-19T13:08:38Z","updated_at":"2016-07-19T15:13:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/3440","html_url":"https://github.com/videojs/video.js/pull/3440","diff_url":"https://github.com/videojs/video.js/pull/3440.diff","patch_url":"https://github.com/videojs/video.js/pull/3440.patch"},"body":"## Description\r\nAll UI elements can be disabled in options for example\r\n```javascript\r\n{\r\n  'posterImage': false,\r\n  'textTrackDisplay': false,\r\n  'loadingSpinner': false,\r\n  'bigPlayButton': false,\r\n  'controlBar': false,\r\n  'errorDisplay': false,\r\n  'textTrackSettings': false\r\n}\r\n```\r\n\r\nWhen `errorDisplay` is disabled it does not exist anymore. Thus its existence needs to be validated to avoid crashes. The one fixed occurs immediately after player is initialized.\r\n\r\n## Specific Changes proposed\r\nValidate existence of `this.errorDisplay`. This fixes #3014.\r\n\r\n## Requirements Checklist\r\n- [x] Bug fixed\r\n- [ ] Reviewed by Two Core Contributors\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/videojs/video.js/issues/comments/233664760","html_url":"https://github.com/videojs/video.js/pull/3440#issuecomment-233664760","issue_url":"https://api.github.com/repos/videojs/video.js/issues/3440","id":233664760,"user":{"login":"BrandonOCasey","id":2381475,"avatar_url":"https://avatars.githubusercontent.com/u/2381475?v=3","gravatar_id":"","url":"https://api.github.com/users/BrandonOCasey","html_url":"https://github.com/BrandonOCasey","followers_url":"https://api.github.com/users/BrandonOCasey/followers","following_url":"https://api.github.com/users/BrandonOCasey/following{/other_user}","gists_url":"https://api.github.com/users/BrandonOCasey/gists{/gist_id}","starred_url":"https://api.github.com/users/BrandonOCasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrandonOCasey/subscriptions","organizations_url":"https://api.github.com/users/BrandonOCasey/orgs","repos_url":"https://api.github.com/users/BrandonOCasey/repos","events_url":"https://api.github.com/users/BrandonOCasey/events{/privacy}","received_events_url":"https://api.github.com/users/BrandonOCasey/received_events","type":"User","site_admin":false},"created_at":"2016-07-19T15:13:05Z","updated_at":"2016-07-19T15:13:05Z","body":"LGTM"}}
{"actor":{"display_login":"BrandonOCasey"}}