{"action":"created","issue":{"url":"https://api.github.com/repos/IIIF/mirador/issues/1026","repository_url":"https://api.github.com/repos/IIIF/mirador","labels_url":"https://api.github.com/repos/IIIF/mirador/issues/1026/labels{/name}","comments_url":"https://api.github.com/repos/IIIF/mirador/issues/1026/comments","events_url":"https://api.github.com/repos/IIIF/mirador/issues/1026/events","html_url":"https://github.com/IIIF/mirador/pull/1026","id":167344727,"number":1026,"title":"Deletes shape when clicked on the trash can icon.","user":{"login":"radpet","id":13572835,"avatar_url":"https://avatars.githubusercontent.com/u/13572835?v=3","gravatar_id":"","url":"https://api.github.com/users/radpet","html_url":"https://github.com/radpet","followers_url":"https://api.github.com/users/radpet/followers","following_url":"https://api.github.com/users/radpet/following{/other_user}","gists_url":"https://api.github.com/users/radpet/gists{/gist_id}","starred_url":"https://api.github.com/users/radpet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radpet/subscriptions","organizations_url":"https://api.github.com/users/radpet/orgs","repos_url":"https://api.github.com/users/radpet/repos","events_url":"https://api.github.com/users/radpet/events{/privacy}","received_events_url":"https://api.github.com/users/radpet/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-25T11:29:18Z","updated_at":"2016-07-26T20:00:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/IIIF/mirador/pulls/1026","html_url":"https://github.com/IIIF/mirador/pull/1026","diff_url":"https://github.com/IIIF/mirador/pull/1026.diff","patch_url":"https://github.com/IIIF/mirador/pull/1026.patch"},"body":"@rsinghal \r\n## This pr fixes:\r\n\r\nImplement single shape delete action.\r\nDeletes shape action is triggered when you click the trash can icon.\r\nConfirmation message appears.\r\n\r\nAdd check if you try to create annotation without any shapes.\r\n\r\nAdd check if you edit annotation and you have deleted all shapes.\r\nIn case you have no shapes and you try to save it triggers confirmation that the annotation will be deleted.\r\n\r\nUnsubscribe from all events in the osd overlay when the osd is closed (This should fix some large memory leaks)\r\n\r\n## What will be fixed in future pr: (DONE (waiting to merge this pr in order to rebase on top of it and I'll send pr) )\r\n@rsinghal @beaudet\r\nAll confirmation dialogs/popups will be modal implemented with the help of [http://bootboxjs.com/#](http://bootboxjs.com/#)\r\nAll messages displayed will be configured from the i18n langs\r\n\r\nRefactor overlay to keep track of subscribed events in order to unsubscribe from all of them when needed (write unit test to watch for event subscription memory leaks)\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/IIIF/mirador/issues/comments/235386832","html_url":"https://github.com/IIIF/mirador/pull/1026#issuecomment-235386832","issue_url":"https://api.github.com/repos/IIIF/mirador/issues/1026","id":235386832,"user":{"login":"rsinghal","id":2371632,"avatar_url":"https://avatars.githubusercontent.com/u/2371632?v=3","gravatar_id":"","url":"https://api.github.com/users/rsinghal","html_url":"https://github.com/rsinghal","followers_url":"https://api.github.com/users/rsinghal/followers","following_url":"https://api.github.com/users/rsinghal/following{/other_user}","gists_url":"https://api.github.com/users/rsinghal/gists{/gist_id}","starred_url":"https://api.github.com/users/rsinghal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsinghal/subscriptions","organizations_url":"https://api.github.com/users/rsinghal/orgs","repos_url":"https://api.github.com/users/rsinghal/repos","events_url":"https://api.github.com/users/rsinghal/events{/privacy}","received_events_url":"https://api.github.com/users/rsinghal/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T20:00:56Z","updated_at":"2016-07-26T20:00:56Z","body":"I like the work you did with being able to delete an individual shape.  However, I don't agree that saving an annotation that has all shapes deleted should, by default, delete the annotation.  The dialog that pops up could be very confusing to the user, since it is saying that saving causes deletion.  Instead, the dialog should present the user with the option to save the annotation with no shapes or delete the entire annotation, and act accordingly.\r\n\r\nThe option to have an annotation with no shapes is a valid use case in terms of an annotation and there have been discussions to add other ways to display annotations in Mirador (such as through the left side panel).  This means that even though an annotation with no shapes won't show up in Mirador right now, eventually there will be a mechanism to display those annotations.\r\n\r\nRegarding Bootbox - that requires Bootstrap, which we don't use in Mirador.  What do we gain by adding these to Mirador (since it does make the JS and CSS files larger)?  Is there something smaller we can use?"}}
{"actor":{"display_login":"rsinghal"}}