{"action":"created","issue":{"url":"https://api.github.com/repos/mono/MonoGame/issues/5001","repository_url":"https://api.github.com/repos/mono/MonoGame","labels_url":"https://api.github.com/repos/mono/MonoGame/issues/5001/labels{/name}","comments_url":"https://api.github.com/repos/mono/MonoGame/issues/5001/comments","events_url":"https://api.github.com/repos/mono/MonoGame/issues/5001/events","html_url":"https://github.com/mono/MonoGame/pull/5001","id":164722412,"number":5001,"title":"Refactored audio processing for platform extensibility","user":{"login":"tomspilman","id":103522,"avatar_url":"https://avatars.githubusercontent.com/u/103522?v=3","gravatar_id":"","url":"https://api.github.com/users/tomspilman","html_url":"https://github.com/tomspilman","followers_url":"https://api.github.com/users/tomspilman/followers","following_url":"https://api.github.com/users/tomspilman/following{/other_user}","gists_url":"https://api.github.com/users/tomspilman/gists{/gist_id}","starred_url":"https://api.github.com/users/tomspilman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomspilman/subscriptions","organizations_url":"https://api.github.com/users/tomspilman/orgs","repos_url":"https://api.github.com/users/tomspilman/repos","events_url":"https://api.github.com/users/tomspilman/events{/privacy}","received_events_url":"https://api.github.com/users/tomspilman/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mono/MonoGame/milestones/9","html_url":"https://github.com/mono/MonoGame/milestones/3.6%20Release","labels_url":"https://api.github.com/repos/mono/MonoGame/milestones/9/labels","id":1441958,"number":9,"title":"3.6 Release","description":"More unit tests, running unit tests on Mac and Linux, SDL2 replacing OpenTK.","creator":{"login":"dellis1972","id":810617,"avatar_url":"https://avatars.githubusercontent.com/u/810617?v=3","gravatar_id":"","url":"https://api.github.com/users/dellis1972","html_url":"https://github.com/dellis1972","followers_url":"https://api.github.com/users/dellis1972/followers","following_url":"https://api.github.com/users/dellis1972/following{/other_user}","gists_url":"https://api.github.com/users/dellis1972/gists{/gist_id}","starred_url":"https://api.github.com/users/dellis1972/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dellis1972/subscriptions","organizations_url":"https://api.github.com/users/dellis1972/orgs","repos_url":"https://api.github.com/users/dellis1972/repos","events_url":"https://api.github.com/users/dellis1972/events{/privacy}","received_events_url":"https://api.github.com/users/dellis1972/received_events","type":"User","site_admin":false},"open_issues":95,"closed_issues":94,"state":"open","created_at":"2015-12-03T11:17:13Z","updated_at":"2016-07-23T18:13:51Z","due_on":"2016-06-13T07:00:00Z","closed_at":null},"comments":9,"created_at":"2016-07-10T16:16:05Z","updated_at":"2016-07-23T23:20:17Z","closed_at":"2016-07-13T05:23:22Z","pull_request":{"url":"https://api.github.com/repos/mono/MonoGame/pulls/5001","html_url":"https://github.com/mono/MonoGame/pull/5001","diff_url":"https://github.com/mono/MonoGame/pull/5001.diff","patch_url":"https://github.com/mono/MonoGame/pull/5001.patch"},"body":"This is a follow up to #4992 and #4996.\r\n\r\nHere I've added a new `AudioProfile` and `DefaultAudioProfile` classes which do the work previously found in `AudioContent`.\r\n\r\nLike with the work on shader processing and textures... one just need to implement a new instance of `AudioProfile` to add support for converting audio to a new format for a new platform.\r\n\r\nAs part of this I added a bunch of unit tests for `WavImporter` and `AudioContent` to ensure we've compatible with XNA behavior.\r\n\r\nNote that conversion to MSADPCM doesn't result in the exact final sample rates as XNA.  For this reason I worked around those checks in the test.  We need someone else to go investigate and figure this out eventually...  but it isn't critical IMO.\r\n\r\nFixes https://github.com/mono/MonoGame/issues/4283.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mono/MonoGame/issues/comments/234746451","html_url":"https://github.com/mono/MonoGame/pull/5001#issuecomment-234746451","issue_url":"https://api.github.com/repos/mono/MonoGame/issues/5001","id":234746451,"user":{"login":"cra0zy","id":6773302,"avatar_url":"https://avatars.githubusercontent.com/u/6773302?v=3","gravatar_id":"","url":"https://api.github.com/users/cra0zy","html_url":"https://github.com/cra0zy","followers_url":"https://api.github.com/users/cra0zy/followers","following_url":"https://api.github.com/users/cra0zy/following{/other_user}","gists_url":"https://api.github.com/users/cra0zy/gists{/gist_id}","starred_url":"https://api.github.com/users/cra0zy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cra0zy/subscriptions","organizations_url":"https://api.github.com/users/cra0zy/orgs","repos_url":"https://api.github.com/users/cra0zy/repos","events_url":"https://api.github.com/users/cra0zy/events{/privacy}","received_events_url":"https://api.github.com/users/cra0zy/received_events","type":"User","site_admin":false},"created_at":"2016-07-23T23:20:17Z","updated_at":"2016-07-23T23:20:17Z","body":"I think this broke audio compilation, I might be wrong, but nothing else seemed to have touched it. The error while compiling .ogg file with Song processor is:\r\n\r\n```\r\nC:/Music.ogg\r\nC:/Music.ogg: error: Importer 'OggImporter' had unexpected failure!\r\nMicrosoft.Xna.Framework.Content.Pipeline.InvalidContentException: Failed to open file Bonus1. Ensure the file is a valid audio file and is not DRM protected. ---> System.ArgumentException: Incorrect file type!\r\nParameter name: audioFileType\r\n   at Microsoft.Xna.Framework.Content.Pipeline.Audio.AudioContent..ctor(String audioFileName, AudioFileType audioFileType)\r\n   --- End of inner exception stack trace ---\r\n   at Microsoft.Xna.Framework.Content.Pipeline.Audio.AudioContent..ctor(String audioFileName, AudioFileType audioFileType)\r\n   at Microsoft.Xna.Framework.Content.Pipeline.OggImporter.Import(String filename, ContentImporterContext context)\r\n   at Microsoft.Xna.Framework.Content.Pipeline.ContentImporter`1.Microsoft.Xna.Framework.Content.Pipeline.IContentImporter.Import(String filename, ContentImporterContext context)\r\n   at MonoGame.Framework.Content.Pipeline.Builder.PipelineManager.ProcessContent(PipelineBuildEvent pipelineEvent)\r\n```"}}
{"actor":{"display_login":"cra0zy"}}