{"action":"closed","number":15064,"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/15064","id":82860301,"html_url":"https://github.com/laravel/framework/pull/15064","diff_url":"https://github.com/laravel/framework/pull/15064.diff","patch_url":"https://github.com/laravel/framework/pull/15064.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/15064","number":15064,"state":"closed","locked":false,"title":"[5.3] Made DatabaseManager always respect type of connection","user":{"login":"rokkamokka","id":13039440,"avatar_url":"https://avatars.githubusercontent.com/u/13039440?v=3","gravatar_id":"","url":"https://api.github.com/users/rokkamokka","html_url":"https://github.com/rokkamokka","followers_url":"https://api.github.com/users/rokkamokka/followers","following_url":"https://api.github.com/users/rokkamokka/following{/other_user}","gists_url":"https://api.github.com/users/rokkamokka/gists{/gist_id}","starred_url":"https://api.github.com/users/rokkamokka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rokkamokka/subscriptions","organizations_url":"https://api.github.com/users/rokkamokka/orgs","repos_url":"https://api.github.com/users/rokkamokka/repos","events_url":"https://api.github.com/users/rokkamokka/events{/privacy}","received_events_url":"https://api.github.com/users/rokkamokka/received_events","type":"User","site_admin":false},"body":"In the `DatabaseManager connection()` method, the name and type is parsed from the `$name` argument. However, if the connection already exists in `$this->connections`, the type is ignored entirely.\r\n\r\nThis makes it impossible to e.g. write `DB::connection('mysql::write')->select(...)` and expect the select to be made against the write connection.\r\n\r\nNote that changing the type of the connection with the already existing `setPdoForType` method kills the other type of connection; e.g. if we do `DB::connection('mysql::write')`, then queries to the read connection will always go to the write connection henceforth. As far as I can see, this has always been the case, however.\r\n\r\nThis pull request simply always calls the `setPdoForType()` method on the given connection.","created_at":"2016-08-26T09:46:37Z","updated_at":"2016-08-26T16:44:03Z","closed_at":"2016-08-26T16:44:02Z","merged_at":null,"merge_commit_sha":"c771e2864f9ae6a3d9e534a150c3fbe739099863","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/15064/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/15064/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/15064/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/05a6b5eafc0bc3a18385e9c560b06b7a720b2afe","head":{"label":"rokkamokka:5.3","ref":"5.3","sha":"05a6b5eafc0bc3a18385e9c560b06b7a720b2afe","user":{"login":"rokkamokka","id":13039440,"avatar_url":"https://avatars.githubusercontent.com/u/13039440?v=3","gravatar_id":"","url":"https://api.github.com/users/rokkamokka","html_url":"https://github.com/rokkamokka","followers_url":"https://api.github.com/users/rokkamokka/followers","following_url":"https://api.github.com/users/rokkamokka/following{/other_user}","gists_url":"https://api.github.com/users/rokkamokka/gists{/gist_id}","starred_url":"https://api.github.com/users/rokkamokka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rokkamokka/subscriptions","organizations_url":"https://api.github.com/users/rokkamokka/orgs","repos_url":"https://api.github.com/users/rokkamokka/repos","events_url":"https://api.github.com/users/rokkamokka/events{/privacy}","received_events_url":"https://api.github.com/users/rokkamokka/received_events","type":"User","site_admin":false},"repo":{"id":66634117,"name":"framework","full_name":"rokkamokka/framework","owner":{"login":"rokkamokka","id":13039440,"avatar_url":"https://avatars.githubusercontent.com/u/13039440?v=3","gravatar_id":"","url":"https://api.github.com/users/rokkamokka","html_url":"https://github.com/rokkamokka","followers_url":"https://api.github.com/users/rokkamokka/followers","following_url":"https://api.github.com/users/rokkamokka/following{/other_user}","gists_url":"https://api.github.com/users/rokkamokka/gists{/gist_id}","starred_url":"https://api.github.com/users/rokkamokka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rokkamokka/subscriptions","organizations_url":"https://api.github.com/users/rokkamokka/orgs","repos_url":"https://api.github.com/users/rokkamokka/repos","events_url":"https://api.github.com/users/rokkamokka/events{/privacy}","received_events_url":"https://api.github.com/users/rokkamokka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rokkamokka/framework","description":null,"fork":true,"url":"https://api.github.com/repos/rokkamokka/framework","forks_url":"https://api.github.com/repos/rokkamokka/framework/forks","keys_url":"https://api.github.com/repos/rokkamokka/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rokkamokka/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rokkamokka/framework/teams","hooks_url":"https://api.github.com/repos/rokkamokka/framework/hooks","issue_events_url":"https://api.github.com/repos/rokkamokka/framework/issues/events{/number}","events_url":"https://api.github.com/repos/rokkamokka/framework/events","assignees_url":"https://api.github.com/repos/rokkamokka/framework/assignees{/user}","branches_url":"https://api.github.com/repos/rokkamokka/framework/branches{/branch}","tags_url":"https://api.github.com/repos/rokkamokka/framework/tags","blobs_url":"https://api.github.com/repos/rokkamokka/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rokkamokka/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rokkamokka/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/rokkamokka/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rokkamokka/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/rokkamokka/framework/languages","stargazers_url":"https://api.github.com/repos/rokkamokka/framework/stargazers","contributors_url":"https://api.github.com/repos/rokkamokka/framework/contributors","subscribers_url":"https://api.github.com/repos/rokkamokka/framework/subscribers","subscription_url":"https://api.github.com/repos/rokkamokka/framework/subscription","commits_url":"https://api.github.com/repos/rokkamokka/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/rokkamokka/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/rokkamokka/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/rokkamokka/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/rokkamokka/framework/contents/{+path}","compare_url":"https://api.github.com/repos/rokkamokka/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rokkamokka/framework/merges","archive_url":"https://api.github.com/repos/rokkamokka/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rokkamokka/framework/downloads","issues_url":"https://api.github.com/repos/rokkamokka/framework/issues{/number}","pulls_url":"https://api.github.com/repos/rokkamokka/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/rokkamokka/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/rokkamokka/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rokkamokka/framework/labels{/name}","releases_url":"https://api.github.com/repos/rokkamokka/framework/releases{/id}","deployments_url":"https://api.github.com/repos/rokkamokka/framework/deployments","created_at":"2016-08-26T09:12:42Z","updated_at":"2016-08-26T09:12:49Z","pushed_at":"2016-08-26T09:36:20Z","git_url":"git://github.com/rokkamokka/framework.git","ssh_url":"git@github.com:rokkamokka/framework.git","clone_url":"https://github.com/rokkamokka/framework.git","svn_url":"https://github.com/rokkamokka/framework","homepage":"http://laravel.com","size":23702,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.3"}},"base":{"label":"laravel:5.3","ref":"5.3","sha":"a90bac22f56d136ff1459b9184af641a824cb4e9","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","deployments_url":"https://api.github.com/repos/laravel/framework/deployments","created_at":"2013-01-10T21:27:28Z","updated_at":"2016-08-26T13:46:49Z","pushed_at":"2016-08-26T16:42:37Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":50181,"stargazers_count":5815,"watchers_count":5815,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3393,"mirror_url":null,"open_issues_count":224,"forks":3393,"open_issues":224,"watchers":5815,"default_branch":"5.3"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/15064"},"html":{"href":"https://github.com/laravel/framework/pull/15064"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/15064"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/15064/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/15064/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/15064/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/05a6b5eafc0bc3a18385e9c560b06b7a720b2afe"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":7,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"taylorotwell"}}