{"action":"created","comment":{"url":"https://api.github.com/repos/cloudant/swift-cloudant/pulls/comments/71857948","id":71857948,"diff_hunk":"@@ -24,11 +24,10 @@ import Foundation\n  \n  Example usage:\n  ```\n- let deleteAttachment = DeleteAttachmentOperation()\n- deleteAttachment.docId = docId\n- deleteAttachment.revId = revId\n- deleteAttachment.attachmentName = \"myAwesomeAttachment\"\n- deleteAttachment.databaseName = \"exampledb\"\n+ let deleteAttachment = DeleteAttachmentOperation(name: \"myAwesomeAttachment\",","path":"Source/DeleteAttachmentOperation.swift","position":9,"original_position":9,"commit_id":"72a80a2de2a3f7b5743b486c01a643287cd6a4f9","original_commit_id":"72a80a2de2a3f7b5743b486c01a643287cd6a4f9","user":{"login":"ricellis","id":10698320,"avatar_url":"https://avatars.githubusercontent.com/u/10698320?v=3","gravatar_id":"","url":"https://api.github.com/users/ricellis","html_url":"https://github.com/ricellis","followers_url":"https://api.github.com/users/ricellis/followers","following_url":"https://api.github.com/users/ricellis/following{/other_user}","gists_url":"https://api.github.com/users/ricellis/gists{/gist_id}","starred_url":"https://api.github.com/users/ricellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricellis/subscriptions","organizations_url":"https://api.github.com/users/ricellis/orgs","repos_url":"https://api.github.com/users/ricellis/repos","events_url":"https://api.github.com/users/ricellis/events{/privacy}","received_events_url":"https://api.github.com/users/ricellis/received_events","type":"User","site_admin":false},"body":"The guidelines do say to avoid abbreviations and I know you proposed `documentID` at the beginning of #96. I think that would be ok, whilst \"doc\" is a well known abbreviation I think since we use the term \"Document\" in operations, for example, there is value in being consistent. Although it is more to type the IDE will auto-complete at least.\r\nI also think we should probably go with `revision` rather than `revID` - the Couch documentation nearly always refers to it as a \"revision\" (occasionally as a \"revision token\" and rarely as a \"revision ID\"), some other sources talk of a \"revision number\". WDYT?","created_at":"2016-07-22T10:20:15Z","updated_at":"2016-07-22T10:20:15Z","html_url":"https://github.com/cloudant/swift-cloudant/pull/109#discussion_r71857948","pull_request_url":"https://api.github.com/repos/cloudant/swift-cloudant/pulls/109","_links":{"self":{"href":"https://api.github.com/repos/cloudant/swift-cloudant/pulls/comments/71857948"},"html":{"href":"https://github.com/cloudant/swift-cloudant/pull/109#discussion_r71857948"},"pull_request":{"href":"https://api.github.com/repos/cloudant/swift-cloudant/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/cloudant/swift-cloudant/pulls/109","id":78170528,"html_url":"https://github.com/cloudant/swift-cloudant/pull/109","diff_url":"https://github.com/cloudant/swift-cloudant/pull/109.diff","patch_url":"https://github.com/cloudant/swift-cloudant/pull/109.patch","issue_url":"https://api.github.com/repos/cloudant/swift-cloudant/issues/109","number":109,"state":"open","locked":false,"title":"Follow API Guidelines ","user":{"login":"rhyshort","id":1616727,"avatar_url":"https://avatars.githubusercontent.com/u/1616727?v=3","gravatar_id":"","url":"https://api.github.com/users/rhyshort","html_url":"https://github.com/rhyshort","followers_url":"https://api.github.com/users/rhyshort/followers","following_url":"https://api.github.com/users/rhyshort/following{/other_user}","gists_url":"https://api.github.com/users/rhyshort/gists{/gist_id}","starred_url":"https://api.github.com/users/rhyshort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhyshort/subscriptions","organizations_url":"https://api.github.com/users/rhyshort/orgs","repos_url":"https://api.github.com/users/rhyshort/repos","events_url":"https://api.github.com/users/rhyshort/events{/privacy}","received_events_url":"https://api.github.com/users/rhyshort/received_events","type":"User","site_admin":false},"body":"## What\r\n\r\nChanged APIs to follow the swift API guidelines.\r\n\r\n## How\r\n\r\nSee issue #96 for full list of transformations.\r\n\r\n## Testing\r\n\r\nNo new tests, no longer applicable tests have been removed.\r\n\r\n## Issues\r\n\r\nPart of #96.\r\n\r\n## Notes\r\n\r\n`CouchDBClient` methods haven't been touched in this PR, I'm still unsure about the names that I proposed in the issue.\r\nThe code base will need another look through to make sure that the operations are consistent with naming and parameter ordering etc. before #96 can be resolved.","created_at":"2016-07-20T15:42:16Z","updated_at":"2016-07-22T10:20:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4cf63d3052a56b2ecd6023b2fb8e107249df29f6","assignee":{"login":"ricellis","id":10698320,"avatar_url":"https://avatars.githubusercontent.com/u/10698320?v=3","gravatar_id":"","url":"https://api.github.com/users/ricellis","html_url":"https://github.com/ricellis","followers_url":"https://api.github.com/users/ricellis/followers","following_url":"https://api.github.com/users/ricellis/following{/other_user}","gists_url":"https://api.github.com/users/ricellis/gists{/gist_id}","starred_url":"https://api.github.com/users/ricellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricellis/subscriptions","organizations_url":"https://api.github.com/users/ricellis/orgs","repos_url":"https://api.github.com/users/ricellis/repos","events_url":"https://api.github.com/users/ricellis/events{/privacy}","received_events_url":"https://api.github.com/users/ricellis/received_events","type":"User","site_admin":false},"assignees":[{"login":"ricellis","id":10698320,"avatar_url":"https://avatars.githubusercontent.com/u/10698320?v=3","gravatar_id":"","url":"https://api.github.com/users/ricellis","html_url":"https://github.com/ricellis","followers_url":"https://api.github.com/users/ricellis/followers","following_url":"https://api.github.com/users/ricellis/following{/other_user}","gists_url":"https://api.github.com/users/ricellis/gists{/gist_id}","starred_url":"https://api.github.com/users/ricellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricellis/subscriptions","organizations_url":"https://api.github.com/users/ricellis/orgs","repos_url":"https://api.github.com/users/ricellis/repos","events_url":"https://api.github.com/users/ricellis/events{/privacy}","received_events_url":"https://api.github.com/users/ricellis/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/cloudant/swift-cloudant/milestones/4","html_url":"https://github.com/cloudant/swift-cloudant/milestones/0.4.0","labels_url":"https://api.github.com/repos/cloudant/swift-cloudant/milestones/4/labels","id":1857819,"number":4,"title":"0.4.0","description":"","creator":{"login":"rhyshort","id":1616727,"avatar_url":"https://avatars.githubusercontent.com/u/1616727?v=3","gravatar_id":"","url":"https://api.github.com/users/rhyshort","html_url":"https://github.com/rhyshort","followers_url":"https://api.github.com/users/rhyshort/followers","following_url":"https://api.github.com/users/rhyshort/following{/other_user}","gists_url":"https://api.github.com/users/rhyshort/gists{/gist_id}","starred_url":"https://api.github.com/users/rhyshort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhyshort/subscriptions","organizations_url":"https://api.github.com/users/rhyshort/orgs","repos_url":"https://api.github.com/users/rhyshort/repos","events_url":"https://api.github.com/users/rhyshort/events{/privacy}","received_events_url":"https://api.github.com/users/rhyshort/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":4,"state":"open","created_at":"2016-06-30T15:37:51Z","updated_at":"2016-07-20T15:42:16Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cloudant/swift-cloudant/pulls/109/commits","review_comments_url":"https://api.github.com/repos/cloudant/swift-cloudant/pulls/109/comments","review_comment_url":"https://api.github.com/repos/cloudant/swift-cloudant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudant/swift-cloudant/issues/109/comments","statuses_url":"https://api.github.com/repos/cloudant/swift-cloudant/statuses/72a80a2de2a3f7b5743b486c01a643287cd6a4f9","head":{"label":"cloudant:96-follow-api-guidelines","ref":"96-follow-api-guidelines","sha":"72a80a2de2a3f7b5743b486c01a643287cd6a4f9","user":{"login":"cloudant","id":44642,"avatar_url":"https://avatars.githubusercontent.com/u/44642?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudant","html_url":"https://github.com/cloudant","followers_url":"https://api.github.com/users/cloudant/followers","following_url":"https://api.github.com/users/cloudant/following{/other_user}","gists_url":"https://api.github.com/users/cloudant/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudant/subscriptions","organizations_url":"https://api.github.com/users/cloudant/orgs","repos_url":"https://api.github.com/users/cloudant/repos","events_url":"https://api.github.com/users/cloudant/events{/privacy}","received_events_url":"https://api.github.com/users/cloudant/received_events","type":"Organization","site_admin":false},"repo":{"id":55980905,"name":"swift-cloudant","full_name":"cloudant/swift-cloudant","owner":{"login":"cloudant","id":44642,"avatar_url":"https://avatars.githubusercontent.com/u/44642?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudant","html_url":"https://github.com/cloudant","followers_url":"https://api.github.com/users/cloudant/followers","following_url":"https://api.github.com/users/cloudant/following{/other_user}","gists_url":"https://api.github.com/users/cloudant/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudant/subscriptions","organizations_url":"https://api.github.com/users/cloudant/orgs","repos_url":"https://api.github.com/users/cloudant/repos","events_url":"https://api.github.com/users/cloudant/events{/privacy}","received_events_url":"https://api.github.com/users/cloudant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudant/swift-cloudant","description":"A Swift Lang client for Cloudant and CouchDB","fork":false,"url":"https://api.github.com/repos/cloudant/swift-cloudant","forks_url":"https://api.github.com/repos/cloudant/swift-cloudant/forks","keys_url":"https://api.github.com/repos/cloudant/swift-cloudant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudant/swift-cloudant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudant/swift-cloudant/teams","hooks_url":"https://api.github.com/repos/cloudant/swift-cloudant/hooks","issue_events_url":"https://api.github.com/repos/cloudant/swift-cloudant/issues/events{/number}","events_url":"https://api.github.com/repos/cloudant/swift-cloudant/events","assignees_url":"https://api.github.com/repos/cloudant/swift-cloudant/assignees{/user}","branches_url":"https://api.github.com/repos/cloudant/swift-cloudant/branches{/branch}","tags_url":"https://api.github.com/repos/cloudant/swift-cloudant/tags","blobs_url":"https://api.github.com/repos/cloudant/swift-cloudant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudant/swift-cloudant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudant/swift-cloudant/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudant/swift-cloudant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudant/swift-cloudant/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudant/swift-cloudant/languages","stargazers_url":"https://api.github.com/repos/cloudant/swift-cloudant/stargazers","contributors_url":"https://api.github.com/repos/cloudant/swift-cloudant/contributors","subscribers_url":"https://api.github.com/repos/cloudant/swift-cloudant/subscribers","subscription_url":"https://api.github.com/repos/cloudant/swift-cloudant/subscription","commits_url":"https://api.github.com/repos/cloudant/swift-cloudant/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudant/swift-cloudant/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudant/swift-cloudant/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudant/swift-cloudant/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudant/swift-cloudant/contents/{+path}","compare_url":"https://api.github.com/repos/cloudant/swift-cloudant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudant/swift-cloudant/merges","archive_url":"https://api.github.com/repos/cloudant/swift-cloudant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudant/swift-cloudant/downloads","issues_url":"https://api.github.com/repos/cloudant/swift-cloudant/issues{/number}","pulls_url":"https://api.github.com/repos/cloudant/swift-cloudant/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudant/swift-cloudant/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudant/swift-cloudant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudant/swift-cloudant/labels{/name}","releases_url":"https://api.github.com/repos/cloudant/swift-cloudant/releases{/id}","deployments_url":"https://api.github.com/repos/cloudant/swift-cloudant/deployments","created_at":"2016-04-11T14:47:54Z","updated_at":"2016-07-21T09:43:04Z","pushed_at":"2016-07-22T09:04:47Z","git_url":"git://github.com/cloudant/swift-cloudant.git","ssh_url":"git@github.com:cloudant/swift-cloudant.git","clone_url":"https://github.com/cloudant/swift-cloudant.git","svn_url":"https://github.com/cloudant/swift-cloudant","homepage":null,"size":542,"stargazers_count":6,"watchers_count":6,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":24,"forks":1,"open_issues":24,"watchers":6,"default_branch":"master"}},"base":{"label":"cloudant:master","ref":"master","sha":"3c52eb66a294b099c8b8de1214c9fc542393e71c","user":{"login":"cloudant","id":44642,"avatar_url":"https://avatars.githubusercontent.com/u/44642?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudant","html_url":"https://github.com/cloudant","followers_url":"https://api.github.com/users/cloudant/followers","following_url":"https://api.github.com/users/cloudant/following{/other_user}","gists_url":"https://api.github.com/users/cloudant/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudant/subscriptions","organizations_url":"https://api.github.com/users/cloudant/orgs","repos_url":"https://api.github.com/users/cloudant/repos","events_url":"https://api.github.com/users/cloudant/events{/privacy}","received_events_url":"https://api.github.com/users/cloudant/received_events","type":"Organization","site_admin":false},"repo":{"id":55980905,"name":"swift-cloudant","full_name":"cloudant/swift-cloudant","owner":{"login":"cloudant","id":44642,"avatar_url":"https://avatars.githubusercontent.com/u/44642?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudant","html_url":"https://github.com/cloudant","followers_url":"https://api.github.com/users/cloudant/followers","following_url":"https://api.github.com/users/cloudant/following{/other_user}","gists_url":"https://api.github.com/users/cloudant/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudant/subscriptions","organizations_url":"https://api.github.com/users/cloudant/orgs","repos_url":"https://api.github.com/users/cloudant/repos","events_url":"https://api.github.com/users/cloudant/events{/privacy}","received_events_url":"https://api.github.com/users/cloudant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudant/swift-cloudant","description":"A Swift Lang client for Cloudant and CouchDB","fork":false,"url":"https://api.github.com/repos/cloudant/swift-cloudant","forks_url":"https://api.github.com/repos/cloudant/swift-cloudant/forks","keys_url":"https://api.github.com/repos/cloudant/swift-cloudant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudant/swift-cloudant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudant/swift-cloudant/teams","hooks_url":"https://api.github.com/repos/cloudant/swift-cloudant/hooks","issue_events_url":"https://api.github.com/repos/cloudant/swift-cloudant/issues/events{/number}","events_url":"https://api.github.com/repos/cloudant/swift-cloudant/events","assignees_url":"https://api.github.com/repos/cloudant/swift-cloudant/assignees{/user}","branches_url":"https://api.github.com/repos/cloudant/swift-cloudant/branches{/branch}","tags_url":"https://api.github.com/repos/cloudant/swift-cloudant/tags","blobs_url":"https://api.github.com/repos/cloudant/swift-cloudant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudant/swift-cloudant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudant/swift-cloudant/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudant/swift-cloudant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudant/swift-cloudant/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudant/swift-cloudant/languages","stargazers_url":"https://api.github.com/repos/cloudant/swift-cloudant/stargazers","contributors_url":"https://api.github.com/repos/cloudant/swift-cloudant/contributors","subscribers_url":"https://api.github.com/repos/cloudant/swift-cloudant/subscribers","subscription_url":"https://api.github.com/repos/cloudant/swift-cloudant/subscription","commits_url":"https://api.github.com/repos/cloudant/swift-cloudant/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudant/swift-cloudant/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudant/swift-cloudant/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudant/swift-cloudant/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudant/swift-cloudant/contents/{+path}","compare_url":"https://api.github.com/repos/cloudant/swift-cloudant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudant/swift-cloudant/merges","archive_url":"https://api.github.com/repos/cloudant/swift-cloudant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudant/swift-cloudant/downloads","issues_url":"https://api.github.com/repos/cloudant/swift-cloudant/issues{/number}","pulls_url":"https://api.github.com/repos/cloudant/swift-cloudant/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudant/swift-cloudant/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudant/swift-cloudant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudant/swift-cloudant/labels{/name}","releases_url":"https://api.github.com/repos/cloudant/swift-cloudant/releases{/id}","deployments_url":"https://api.github.com/repos/cloudant/swift-cloudant/deployments","created_at":"2016-04-11T14:47:54Z","updated_at":"2016-07-21T09:43:04Z","pushed_at":"2016-07-22T09:04:47Z","git_url":"git://github.com/cloudant/swift-cloudant.git","ssh_url":"git@github.com:cloudant/swift-cloudant.git","clone_url":"https://github.com/cloudant/swift-cloudant.git","svn_url":"https://github.com/cloudant/swift-cloudant","homepage":null,"size":542,"stargazers_count":6,"watchers_count":6,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":24,"forks":1,"open_issues":24,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudant/swift-cloudant/pulls/109"},"html":{"href":"https://github.com/cloudant/swift-cloudant/pull/109"},"issue":{"href":"https://api.github.com/repos/cloudant/swift-cloudant/issues/109"},"comments":{"href":"https://api.github.com/repos/cloudant/swift-cloudant/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudant/swift-cloudant/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudant/swift-cloudant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudant/swift-cloudant/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/cloudant/swift-cloudant/statuses/72a80a2de2a3f7b5743b486c01a643287cd6a4f9"}}}}
{"actor":{"display_login":"ricellis"}}