{"action":"created","issue":{"url":"https://api.github.com/repos/Juniper/py-junos-eznc/issues/622","repository_url":"https://api.github.com/repos/Juniper/py-junos-eznc","labels_url":"https://api.github.com/repos/Juniper/py-junos-eznc/issues/622/labels{/name}","comments_url":"https://api.github.com/repos/Juniper/py-junos-eznc/issues/622/comments","events_url":"https://api.github.com/repos/Juniper/py-junos-eznc/issues/622/events","html_url":"https://github.com/Juniper/py-junos-eznc/pull/622","id":188641512,"number":622,"title":"Added console_has_banner parameter","user":{"login":"pklimai","id":10626378,"avatar_url":"https://avatars.githubusercontent.com/u/10626378?v=3","gravatar_id":"","url":"https://api.github.com/users/pklimai","html_url":"https://github.com/pklimai","followers_url":"https://api.github.com/users/pklimai/followers","following_url":"https://api.github.com/users/pklimai/following{/other_user}","gists_url":"https://api.github.com/users/pklimai/gists{/gist_id}","starred_url":"https://api.github.com/users/pklimai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pklimai/subscriptions","organizations_url":"https://api.github.com/users/pklimai/orgs","repos_url":"https://api.github.com/users/pklimai/repos","events_url":"https://api.github.com/users/pklimai/events{/privacy}","received_events_url":"https://api.github.com/users/pklimai/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-10T22:56:32Z","updated_at":"2016-11-10T22:59:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Juniper/py-junos-eznc/pulls/622","html_url":"https://github.com/Juniper/py-junos-eznc/pull/622","diff_url":"https://github.com/Juniper/py-junos-eznc/pull/622.diff","patch_url":"https://github.com/Juniper/py-junos-eznc/pull/622.patch"},"body":"Hi\r\n\r\nBasically, problem that I am solving with this proposed modification is described [here](http://stackoverflow.com/questions/40493376/how-to-make-junos-pyez-work-via-console-port)\r\n\r\nIn the existing PyEZ version, in comments, it is suggested to uncomment couple of lines in _ev_tty_nologin() function in case \"we're in a hung state\" and \"console connection has a banner or warning\". Really, uncommenting the lines solved my problem but this is not what users are supposed to do (modify library code).\r\n\r\nSo I propose to add the parameter console_has_banner to the Console (also Device) class constructor, allowing to make this switch more easily for users.\r\n\r\nWith this parameter enabled, this script now works much better:\r\n\r\n```\r\nwith Device(host='X.X.X.X', user='XXX', password='XXXXXX', mode='telnet', \r\n        port='2014', gather_facts=True, console_has_banner=True) as dev:\r\n    print(dev.facts)\r\n    print(dev.cli(\"show version\", format='text', warning=False))\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/Juniper/py-junos-eznc/issues/comments/259833312","html_url":"https://github.com/Juniper/py-junos-eznc/pull/622#issuecomment-259833312","issue_url":"https://api.github.com/repos/Juniper/py-junos-eznc/issues/622","id":259833312,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T22:59:28Z","updated_at":"2016-11-10T22:59:28Z","body":"\n[![Coverage Status](https://coveralls.io/builds/8771136/badge)](https://coveralls.io/builds/8771136)\n\nCoverage increased (+0.2%) to 97.036% when pulling **46cc13a5e99d31ea2947902c3bfca281b4d0f3f4 on pklimai:master** into **40124680f5284b0708975cfbdebdfcad3ca54d45 on Juniper:master**.\n"}}
{"actor":{"display_login":"coveralls"}}