{"action":"created","issue":{"url":"https://api.github.com/repos/tristanpenman/valijson/issues/12","labels_url":"https://api.github.com/repos/tristanpenman/valijson/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/tristanpenman/valijson/issues/12/comments","events_url":"https://api.github.com/repos/tristanpenman/valijson/issues/12/events","html_url":"https://github.com/tristanpenman/valijson/issues/12","id":126876231,"number":12,"title":"Compilation warning treats as errors","user":{"login":"davtorresg","id":7453272,"avatar_url":"https://avatars.githubusercontent.com/u/7453272?v=3","gravatar_id":"","url":"https://api.github.com/users/davtorresg","html_url":"https://github.com/davtorresg","followers_url":"https://api.github.com/users/davtorresg/followers","following_url":"https://api.github.com/users/davtorresg/following{/other_user}","gists_url":"https://api.github.com/users/davtorresg/gists{/gist_id}","starred_url":"https://api.github.com/users/davtorresg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davtorresg/subscriptions","organizations_url":"https://api.github.com/users/davtorresg/orgs","repos_url":"https://api.github.com/users/davtorresg/repos","events_url":"https://api.github.com/users/davtorresg/events{/privacy}","received_events_url":"https://api.github.com/users/davtorresg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-15T13:52:06Z","updated_at":"2016-01-16T17:29:10Z","closed_at":null,"body":"In my project, I compiled with the options \"-Wall -Werror\" in order to treat all the warnings as errors. I am facing several warnings of the type \"comparison between signed and unsigned integer expressions\". \r\n\r\nAnalysing this scenario I have one question. For example, in the class \"concrete_constraints.hpp\" we find the struct \"MaxLengthConstraint\" that is defined like \"int64_t\". Later, this value will be compared with a \"size_t\" (warnings) and the warning appears. \r\n\r\nNow my question, I don't understand why \"concepts\" like \"maxItems\", \"minItems\", \"maxProperties\" and \"mimProperties\" are \"int64_t\". Are there scenarios where this values could have a negative value?\r\n\r\nIf they were defined like \"uint64_t\" several warnings would disappear. "},"comment":{"url":"https://api.github.com/repos/tristanpenman/valijson/issues/comments/172233992","html_url":"https://github.com/tristanpenman/valijson/issues/12#issuecomment-172233992","issue_url":"https://api.github.com/repos/tristanpenman/valijson/issues/12","id":172233992,"user":{"login":"davtorresg","id":7453272,"avatar_url":"https://avatars.githubusercontent.com/u/7453272?v=3","gravatar_id":"","url":"https://api.github.com/users/davtorresg","html_url":"https://github.com/davtorresg","followers_url":"https://api.github.com/users/davtorresg/followers","following_url":"https://api.github.com/users/davtorresg/following{/other_user}","gists_url":"https://api.github.com/users/davtorresg/gists{/gist_id}","starred_url":"https://api.github.com/users/davtorresg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davtorresg/subscriptions","organizations_url":"https://api.github.com/users/davtorresg/orgs","repos_url":"https://api.github.com/users/davtorresg/repos","events_url":"https://api.github.com/users/davtorresg/events{/privacy}","received_events_url":"https://api.github.com/users/davtorresg/received_events","type":"User","site_admin":false},"created_at":"2016-01-16T17:29:10Z","updated_at":"2016-01-16T17:29:10Z","body":"Ok, just to let you know another warning that it could be easily cleaned. In the class \"validation_visitor.hpp\", in the constructor, you initialized the member \"strictTypes\" before than \"results\", however, in the section of the attributes of the class, \"results\" was written before than \"strictTypes\""}}