{"action":"created","issue":{"url":"https://api.github.com/repos/mathewdgardner/knex-supermodel/issues/3","repository_url":"https://api.github.com/repos/mathewdgardner/knex-supermodel","labels_url":"https://api.github.com/repos/mathewdgardner/knex-supermodel/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/mathewdgardner/knex-supermodel/issues/3/comments","events_url":"https://api.github.com/repos/mathewdgardner/knex-supermodel/issues/3/events","html_url":"https://github.com/mathewdgardner/knex-supermodel/issues/3","id":170904665,"number":3,"title":"Destroy hides whether a delete occurred.","user":{"login":"gordysc","id":4010111,"avatar_url":"https://avatars.githubusercontent.com/u/4010111?v=3","gravatar_id":"","url":"https://api.github.com/users/gordysc","html_url":"https://github.com/gordysc","followers_url":"https://api.github.com/users/gordysc/followers","following_url":"https://api.github.com/users/gordysc/following{/other_user}","gists_url":"https://api.github.com/users/gordysc/gists{/gist_id}","starred_url":"https://api.github.com/users/gordysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gordysc/subscriptions","organizations_url":"https://api.github.com/users/gordysc/orgs","repos_url":"https://api.github.com/users/gordysc/repos","events_url":"https://api.github.com/users/gordysc/events{/privacy}","received_events_url":"https://api.github.com/users/gordysc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-12T16:03:43Z","updated_at":"2016-08-12T18:05:23Z","closed_at":null,"body":"Currently when I destroy a model, I don't have any visibility into whether something was actually deleted.  Any concerns with me changing this logic to return the number of rows affected?\r\n```\r\ndestroy(opts = {}) {\r\n    const knex = Util.assertKnex(opts.trx || opts.knex || this._trx || Config.knex);\r\n    const id = opts.id || { id: this.id };\r\n\r\n    return knex(Util.table(this))\r\n      .del()\r\n      .where(id)\r\n      .return(this);\r\n  }\r\n```"},"comment":{"url":"https://api.github.com/repos/mathewdgardner/knex-supermodel/issues/comments/239518282","html_url":"https://github.com/mathewdgardner/knex-supermodel/issues/3#issuecomment-239518282","issue_url":"https://api.github.com/repos/mathewdgardner/knex-supermodel/issues/3","id":239518282,"user":{"login":"mathewdgardner","id":1034552,"avatar_url":"https://avatars.githubusercontent.com/u/1034552?v=3","gravatar_id":"","url":"https://api.github.com/users/mathewdgardner","html_url":"https://github.com/mathewdgardner","followers_url":"https://api.github.com/users/mathewdgardner/followers","following_url":"https://api.github.com/users/mathewdgardner/following{/other_user}","gists_url":"https://api.github.com/users/mathewdgardner/gists{/gist_id}","starred_url":"https://api.github.com/users/mathewdgardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathewdgardner/subscriptions","organizations_url":"https://api.github.com/users/mathewdgardner/orgs","repos_url":"https://api.github.com/users/mathewdgardner/repos","events_url":"https://api.github.com/users/mathewdgardner/events{/privacy}","received_events_url":"https://api.github.com/users/mathewdgardner/received_events","type":"User","site_admin":false},"created_at":"2016-08-12T18:05:23Z","updated_at":"2016-08-12T18:05:23Z","body":"I wasn't sure what it should return, tbh, so I was lazy. I'm ok with a change but am not sure what it should return other than a boolean. What do you think?"}}
{"actor":{"display_login":"mathewdgardner"}}