{"action":"closed","number":39,"pull_request":{"url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls/39","id":57210821,"html_url":"https://github.com/apiaryio/fury-adapter-swagger/pull/39","diff_url":"https://github.com/apiaryio/fury-adapter-swagger/pull/39.diff","patch_url":"https://github.com/apiaryio/fury-adapter-swagger/pull/39.patch","issue_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/issues/39","number":39,"state":"closed","locked":false,"title":"Treat JSON Schema validation errors as errors","user":{"login":"kylef","id":44164,"avatar_url":"https://avatars.githubusercontent.com/u/44164?v=3","gravatar_id":"","url":"https://api.github.com/users/kylef","html_url":"https://github.com/kylef","followers_url":"https://api.github.com/users/kylef/followers","following_url":"https://api.github.com/users/kylef/following{/other_user}","gists_url":"https://api.github.com/users/kylef/gists{/gist_id}","starred_url":"https://api.github.com/users/kylef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylef/subscriptions","organizations_url":"https://api.github.com/users/kylef/orgs","repos_url":"https://api.github.com/users/kylef/repos","events_url":"https://api.github.com/users/kylef/events{/privacy}","received_events_url":"https://api.github.com/users/kylef/received_events","type":"User","site_admin":false},"body":"If the Swagger document didn't validate against the JSON Schema, we previously continued to translate the Swagger document to Refract.\r\n\r\nThis change stops that behaviour and instead stops the translation. The problems with translating the \"invalid\" document is that many types in the Swagger document might not be correct and cause our translation to fail and throw JS exceptions. For example if a parameter was not an object but instead none, or an array.\r\n\r\nFor example, before we would fail due to mis-matched types. Here's an example of what would fail before:\r\n\r\n```yaml\r\nswagger: '2.0'\r\ninfo:\r\n  title: Bad Parameters\r\n  version: '1.0'\r\npaths:\r\n  '/':\r\n    get:\r\n      responses:\r\n        200:\r\n          examples:\r\n            foo: t\r\n    parameters:\r\n      -\r\n```\r\n\r\n```\r\n/app/node_modules/fury-adapter-swagger/lib/parser.js:478 \r\n           return parameter['in'] === 'query'; \r\n                           ^ \r\n TypeError: Cannot read property 'in' of null \r\n     at /app/node_modules/fury-adapter-swagger/lib/parser.js:478:27 \r\n```\r\n\r\n","created_at":"2016-01-26T13:34:15Z","updated_at":"2016-02-02T18:43:34Z","closed_at":"2016-02-02T18:43:34Z","merged_at":"2016-02-02T18:43:34Z","merge_commit_sha":"17e89a0b1919883c8bcd21869de84bd5f6b7cfb7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls/39/commits","review_comments_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls/39/comments","review_comment_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/issues/39/comments","statuses_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/statuses/36aeee86bad69d8c9c522cdbf264659c0d4ee177","head":{"label":"apiaryio:kylef/json-schema-errors","ref":"kylef/json-schema-errors","sha":"36aeee86bad69d8c9c522cdbf264659c0d4ee177","user":{"login":"apiaryio","id":765943,"avatar_url":"https://avatars.githubusercontent.com/u/765943?v=3","gravatar_id":"","url":"https://api.github.com/users/apiaryio","html_url":"https://github.com/apiaryio","followers_url":"https://api.github.com/users/apiaryio/followers","following_url":"https://api.github.com/users/apiaryio/following{/other_user}","gists_url":"https://api.github.com/users/apiaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/apiaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiaryio/subscriptions","organizations_url":"https://api.github.com/users/apiaryio/orgs","repos_url":"https://api.github.com/users/apiaryio/repos","events_url":"https://api.github.com/users/apiaryio/events{/privacy}","received_events_url":"https://api.github.com/users/apiaryio/received_events","type":"Organization","site_admin":false},"repo":{"id":42935158,"name":"fury-adapter-swagger","full_name":"apiaryio/fury-adapter-swagger","owner":{"login":"apiaryio","id":765943,"avatar_url":"https://avatars.githubusercontent.com/u/765943?v=3","gravatar_id":"","url":"https://api.github.com/users/apiaryio","html_url":"https://github.com/apiaryio","followers_url":"https://api.github.com/users/apiaryio/followers","following_url":"https://api.github.com/users/apiaryio/following{/other_user}","gists_url":"https://api.github.com/users/apiaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/apiaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiaryio/subscriptions","organizations_url":"https://api.github.com/users/apiaryio/orgs","repos_url":"https://api.github.com/users/apiaryio/repos","events_url":"https://api.github.com/users/apiaryio/events{/privacy}","received_events_url":"https://api.github.com/users/apiaryio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apiaryio/fury-adapter-swagger","description":"Swagger 2.0 parser adapter for Fury.js","fork":false,"url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger","forks_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/forks","keys_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/teams","hooks_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/hooks","issue_events_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/issues/events{/number}","events_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/events","assignees_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/assignees{/user}","branches_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/branches{/branch}","tags_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/tags","blobs_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/git/refs{/sha}","trees_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/statuses/{sha}","languages_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/languages","stargazers_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/stargazers","contributors_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/contributors","subscribers_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/subscribers","subscription_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/subscription","commits_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/commits{/sha}","git_commits_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/git/commits{/sha}","comments_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/comments{/number}","issue_comment_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/issues/comments{/number}","contents_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/contents/{+path}","compare_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/merges","archive_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/downloads","issues_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/issues{/number}","pulls_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls{/number}","milestones_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/milestones{/number}","notifications_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/labels{/name}","releases_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/releases{/id}","deployments_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/deployments","created_at":"2015-09-22T13:24:29Z","updated_at":"2016-01-28T03:20:49Z","pushed_at":"2016-02-02T18:43:34Z","git_url":"git://github.com/apiaryio/fury-adapter-swagger.git","ssh_url":"git@github.com:apiaryio/fury-adapter-swagger.git","clone_url":"https://github.com/apiaryio/fury-adapter-swagger.git","svn_url":"https://github.com/apiaryio/fury-adapter-swagger","homepage":null,"size":153,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"apiaryio:master","ref":"master","sha":"b5663c969899ace40b180568b6dba4236d893308","user":{"login":"apiaryio","id":765943,"avatar_url":"https://avatars.githubusercontent.com/u/765943?v=3","gravatar_id":"","url":"https://api.github.com/users/apiaryio","html_url":"https://github.com/apiaryio","followers_url":"https://api.github.com/users/apiaryio/followers","following_url":"https://api.github.com/users/apiaryio/following{/other_user}","gists_url":"https://api.github.com/users/apiaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/apiaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiaryio/subscriptions","organizations_url":"https://api.github.com/users/apiaryio/orgs","repos_url":"https://api.github.com/users/apiaryio/repos","events_url":"https://api.github.com/users/apiaryio/events{/privacy}","received_events_url":"https://api.github.com/users/apiaryio/received_events","type":"Organization","site_admin":false},"repo":{"id":42935158,"name":"fury-adapter-swagger","full_name":"apiaryio/fury-adapter-swagger","owner":{"login":"apiaryio","id":765943,"avatar_url":"https://avatars.githubusercontent.com/u/765943?v=3","gravatar_id":"","url":"https://api.github.com/users/apiaryio","html_url":"https://github.com/apiaryio","followers_url":"https://api.github.com/users/apiaryio/followers","following_url":"https://api.github.com/users/apiaryio/following{/other_user}","gists_url":"https://api.github.com/users/apiaryio/gists{/gist_id}","starred_url":"https://api.github.com/users/apiaryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiaryio/subscriptions","organizations_url":"https://api.github.com/users/apiaryio/orgs","repos_url":"https://api.github.com/users/apiaryio/repos","events_url":"https://api.github.com/users/apiaryio/events{/privacy}","received_events_url":"https://api.github.com/users/apiaryio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apiaryio/fury-adapter-swagger","description":"Swagger 2.0 parser adapter for Fury.js","fork":false,"url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger","forks_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/forks","keys_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/teams","hooks_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/hooks","issue_events_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/issues/events{/number}","events_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/events","assignees_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/assignees{/user}","branches_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/branches{/branch}","tags_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/tags","blobs_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/git/refs{/sha}","trees_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/statuses/{sha}","languages_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/languages","stargazers_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/stargazers","contributors_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/contributors","subscribers_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/subscribers","subscription_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/subscription","commits_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/commits{/sha}","git_commits_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/git/commits{/sha}","comments_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/comments{/number}","issue_comment_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/issues/comments{/number}","contents_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/contents/{+path}","compare_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/merges","archive_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/downloads","issues_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/issues{/number}","pulls_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls{/number}","milestones_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/milestones{/number}","notifications_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/labels{/name}","releases_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/releases{/id}","deployments_url":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/deployments","created_at":"2015-09-22T13:24:29Z","updated_at":"2016-01-28T03:20:49Z","pushed_at":"2016-02-02T18:43:34Z","git_url":"git://github.com/apiaryio/fury-adapter-swagger.git","ssh_url":"git@github.com:apiaryio/fury-adapter-swagger.git","clone_url":"https://github.com/apiaryio/fury-adapter-swagger.git","svn_url":"https://github.com/apiaryio/fury-adapter-swagger","homepage":null,"size":153,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls/39"},"html":{"href":"https://github.com/apiaryio/fury-adapter-swagger/pull/39"},"issue":{"href":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/issues/39"},"comments":{"href":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/apiaryio/fury-adapter-swagger/statuses/36aeee86bad69d8c9c522cdbf264659c0d4ee177"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"danielgtaylor","id":106826,"avatar_url":"https://avatars.githubusercontent.com/u/106826?v=3","gravatar_id":"","url":"https://api.github.com/users/danielgtaylor","html_url":"https://github.com/danielgtaylor","followers_url":"https://api.github.com/users/danielgtaylor/followers","following_url":"https://api.github.com/users/danielgtaylor/following{/other_user}","gists_url":"https://api.github.com/users/danielgtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgtaylor/subscriptions","organizations_url":"https://api.github.com/users/danielgtaylor/orgs","repos_url":"https://api.github.com/users/danielgtaylor/repos","events_url":"https://api.github.com/users/danielgtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/danielgtaylor/received_events","type":"User","site_admin":false},"comments":2,"review_comments":2,"commits":1,"additions":503,"deletions":2440,"changed_files":47}}