{"action":"created","issue":{"url":"https://api.github.com/repos/opal/opal/issues/1431","repository_url":"https://api.github.com/repos/opal/opal","labels_url":"https://api.github.com/repos/opal/opal/issues/1431/labels{/name}","comments_url":"https://api.github.com/repos/opal/opal/issues/1431/comments","events_url":"https://api.github.com/repos/opal/opal/issues/1431/events","html_url":"https://github.com/opal/opal/pull/1431","id":147817076,"number":1431,"title":"Fix Method#arity and Method#parameters for methods generated using attr_reader/attr_writer.","user":{"login":"iliabylich","id":1265492,"avatar_url":"https://avatars.githubusercontent.com/u/1265492?v=3","gravatar_id":"","url":"https://api.github.com/users/iliabylich","html_url":"https://github.com/iliabylich","followers_url":"https://api.github.com/users/iliabylich/followers","following_url":"https://api.github.com/users/iliabylich/following{/other_user}","gists_url":"https://api.github.com/users/iliabylich/gists{/gist_id}","starred_url":"https://api.github.com/users/iliabylich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iliabylich/subscriptions","organizations_url":"https://api.github.com/users/iliabylich/orgs","repos_url":"https://api.github.com/users/iliabylich/repos","events_url":"https://api.github.com/users/iliabylich/events{/privacy}","received_events_url":"https://api.github.com/users/iliabylich/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-04-12T17:16:27Z","updated_at":"2016-04-13T08:24:42Z","closed_at":"2016-04-12T20:16:33Z","pull_request":{"url":"https://api.github.com/repos/opal/opal/pulls/1431","html_url":"https://github.com/opal/opal/pull/1431","diff_url":"https://github.com/opal/opal/pull/1431.diff","patch_url":"https://github.com/opal/opal/pull/1431.patch"},"body":"Closes https://github.com/opal/opal/issues/1424.\r\n\r\ncc @wied03 @elia "},"comment":{"url":"https://api.github.com/repos/opal/opal/issues/comments/209300275","html_url":"https://github.com/opal/opal/pull/1431#issuecomment-209300275","issue_url":"https://api.github.com/repos/opal/opal/issues/1431","id":209300275,"user":{"login":"eregon","id":168854,"avatar_url":"https://avatars.githubusercontent.com/u/168854?v=3","gravatar_id":"","url":"https://api.github.com/users/eregon","html_url":"https://github.com/eregon","followers_url":"https://api.github.com/users/eregon/followers","following_url":"https://api.github.com/users/eregon/following{/other_user}","gists_url":"https://api.github.com/users/eregon/gists{/gist_id}","starred_url":"https://api.github.com/users/eregon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eregon/subscriptions","organizations_url":"https://api.github.com/users/eregon/orgs","repos_url":"https://api.github.com/users/eregon/repos","events_url":"https://api.github.com/users/eregon/events{/privacy}","received_events_url":"https://api.github.com/users/eregon/received_events","type":"User","site_admin":false},"created_at":"2016-04-13T08:24:42Z","updated_at":"2016-04-13T08:24:42Z","body":"@wied03 @iliabylich This would be perfectly fine for ruby/spec, attr_* are usually implemented differently than other methods for many reasons, so ensuring that Method introspection works would be a good test :smiley: \r\nI don't see anything Opal-specific in the specs per se. Of course most bugs are caused by bugs in implementation internals, but that makes the specs even more interesting to catch bugs or verify behavior on others implementations.\r\nSome complicated regression tests involving 3+ methods might be difficult to translate to a spec, or they would need to be isolated to a smaller failing scenario. But in general, I'm all for having regression tests written as specs in ruby/spec. For instance, jruby+truffle does not have a separate test suite for regressions tests, it only has some additional specs for extra behavior (like integration with other languages)."}}