{"action":"created","comment":{"url":"https://api.github.com/repos/houndci/scss/pulls/comments/60015514","id":60015514,"diff_hunk":"@@ -1,19 +1,57 @@\n-require \"review\"\n-require \"raven\"\n+require \"resque\"\n+\n+require \"config_options\"\n+require \"jobs/completed_file_review_job\"\n+require \"scss_lint\"\n+require \"scss_lint/file\"\n+require \"scss_lint/runner\"\n \n class ScssReviewJob\n   @queue = :scss_review\n \n-  # The following parameters are required for this job to run.\n+  # This job receives the following arguments\n   # - filename\n-  # - commit_sha\n-  # - pull_request_number (pass-through)\n-  # - patch (pass-through)\n   # - content\n   # - config\n+  # - pull_request_number (pass-through)\n+  # - commit_sha (pass-through)\n+  # - patch (pass-through)\n   def self.perform(attributes)\n-    Review.run(attributes)\n-  rescue => exception\n-    Raven.capture_exception(exception)\n+    config = config_for(attributes: attributes)","path":"lib/jobs/scss_review_job.rb","position":29,"original_position":29,"commit_id":"f66eb4d25c13686bc99926006a87b857b4721ab4","original_commit_id":"f66eb4d25c13686bc99926006a87b857b4721ab4","user":{"login":"teoljungberg","id":810650,"avatar_url":"https://avatars.githubusercontent.com/u/810650?v=3","gravatar_id":"","url":"https://api.github.com/users/teoljungberg","html_url":"https://github.com/teoljungberg","followers_url":"https://api.github.com/users/teoljungberg/followers","following_url":"https://api.github.com/users/teoljungberg/following{/other_user}","gists_url":"https://api.github.com/users/teoljungberg/gists{/gist_id}","starred_url":"https://api.github.com/users/teoljungberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teoljungberg/subscriptions","organizations_url":"https://api.github.com/users/teoljungberg/orgs","repos_url":"https://api.github.com/users/teoljungberg/repos","events_url":"https://api.github.com/users/teoljungberg/events{/privacy}","received_events_url":"https://api.github.com/users/teoljungberg/received_events","type":"User","site_admin":false},"body":"I personally prefer having a 1-1 mapping between job-classes and service objects.\r\nWhat made you guys choose merging the service class into the job-class? Fewer moving parts?","created_at":"2016-04-18T07:35:18Z","updated_at":"2016-04-18T07:35:18Z","html_url":"https://github.com/houndci/scss/pull/26#discussion_r60015514","pull_request_url":"https://api.github.com/repos/houndci/scss/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/houndci/scss/pulls/comments/60015514"},"html":{"href":"https://github.com/houndci/scss/pull/26#discussion_r60015514"},"pull_request":{"href":"https://api.github.com/repos/houndci/scss/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/houndci/scss/pulls/26","id":66706935,"html_url":"https://github.com/houndci/scss/pull/26","diff_url":"https://github.com/houndci/scss/pull/26.diff","patch_url":"https://github.com/houndci/scss/pull/26.patch","issue_url":"https://api.github.com/repos/houndci/scss/issues/26","number":26,"state":"open","locked":false,"title":"Switch to CLI wrapper","user":{"login":"thorncp","id":72176,"avatar_url":"https://avatars.githubusercontent.com/u/72176?v=3","gravatar_id":"","url":"https://api.github.com/users/thorncp","html_url":"https://github.com/thorncp","followers_url":"https://api.github.com/users/thorncp/followers","following_url":"https://api.github.com/users/thorncp/following{/other_user}","gists_url":"https://api.github.com/users/thorncp/gists{/gist_id}","starred_url":"https://api.github.com/users/thorncp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thorncp/subscriptions","organizations_url":"https://api.github.com/users/thorncp/orgs","repos_url":"https://api.github.com/users/thorncp/repos","events_url":"https://api.github.com/users/thorncp/events{/privacy}","received_events_url":"https://api.github.com/users/thorncp/received_events","type":"User","site_admin":false},"body":"Copies the CLI wrapper structure from houndci/swift and repurposes it to\r\nwork with scss-lint. This is very close to a direct port, so feedback on the\r\ncode that communicates with the CLI, schedules jobs, etc. is welcome,\r\nbut probably won't be taken into consideration for this PR. Once we have\r\nmultiple services running in similar circumstances, we can explore\r\nmaking improvements and possibly extracting a gem.\r\n\r\nThis is a first step to potentially moving all of Hound's services to a\r\nCLI wrapper approach, with the primary goal of increasing stability and\r\nusing the linters in their natural habitat.","created_at":"2016-04-15T21:22:52Z","updated_at":"2016-04-18T07:35:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"676f4cb419eafdd1b1d8dd3479973102247e3a5a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/houndci/scss/pulls/26/commits","review_comments_url":"https://api.github.com/repos/houndci/scss/pulls/26/comments","review_comment_url":"https://api.github.com/repos/houndci/scss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/houndci/scss/issues/26/comments","statuses_url":"https://api.github.com/repos/houndci/scss/statuses/f66eb4d25c13686bc99926006a87b857b4721ab4","head":{"label":"houndci:ct-cli-wrapper-swift-copy","ref":"ct-cli-wrapper-swift-copy","sha":"f66eb4d25c13686bc99926006a87b857b4721ab4","user":{"login":"houndci","id":17184073,"avatar_url":"https://avatars.githubusercontent.com/u/17184073?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"Organization","site_admin":false},"repo":{"id":35621147,"name":"scss","full_name":"houndci/scss","owner":{"login":"houndci","id":17184073,"avatar_url":"https://avatars.githubusercontent.com/u/17184073?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/houndci/scss","description":"SCSS review service","fork":false,"url":"https://api.github.com/repos/houndci/scss","forks_url":"https://api.github.com/repos/houndci/scss/forks","keys_url":"https://api.github.com/repos/houndci/scss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/houndci/scss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/houndci/scss/teams","hooks_url":"https://api.github.com/repos/houndci/scss/hooks","issue_events_url":"https://api.github.com/repos/houndci/scss/issues/events{/number}","events_url":"https://api.github.com/repos/houndci/scss/events","assignees_url":"https://api.github.com/repos/houndci/scss/assignees{/user}","branches_url":"https://api.github.com/repos/houndci/scss/branches{/branch}","tags_url":"https://api.github.com/repos/houndci/scss/tags","blobs_url":"https://api.github.com/repos/houndci/scss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/houndci/scss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/houndci/scss/git/refs{/sha}","trees_url":"https://api.github.com/repos/houndci/scss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/houndci/scss/statuses/{sha}","languages_url":"https://api.github.com/repos/houndci/scss/languages","stargazers_url":"https://api.github.com/repos/houndci/scss/stargazers","contributors_url":"https://api.github.com/repos/houndci/scss/contributors","subscribers_url":"https://api.github.com/repos/houndci/scss/subscribers","subscription_url":"https://api.github.com/repos/houndci/scss/subscription","commits_url":"https://api.github.com/repos/houndci/scss/commits{/sha}","git_commits_url":"https://api.github.com/repos/houndci/scss/git/commits{/sha}","comments_url":"https://api.github.com/repos/houndci/scss/comments{/number}","issue_comment_url":"https://api.github.com/repos/houndci/scss/issues/comments{/number}","contents_url":"https://api.github.com/repos/houndci/scss/contents/{+path}","compare_url":"https://api.github.com/repos/houndci/scss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/houndci/scss/merges","archive_url":"https://api.github.com/repos/houndci/scss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/houndci/scss/downloads","issues_url":"https://api.github.com/repos/houndci/scss/issues{/number}","pulls_url":"https://api.github.com/repos/houndci/scss/pulls{/number}","milestones_url":"https://api.github.com/repos/houndci/scss/milestones{/number}","notifications_url":"https://api.github.com/repos/houndci/scss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/houndci/scss/labels{/name}","releases_url":"https://api.github.com/repos/houndci/scss/releases{/id}","deployments_url":"https://api.github.com/repos/houndci/scss/deployments","created_at":"2015-05-14T16:03:10Z","updated_at":"2016-02-15T19:18:47Z","pushed_at":"2016-04-15T21:41:25Z","git_url":"git://github.com/houndci/scss.git","ssh_url":"git@github.com:houndci/scss.git","clone_url":"https://github.com/houndci/scss.git","svn_url":"https://github.com/houndci/scss","homepage":"","size":71,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":9,"default_branch":"master"}},"base":{"label":"houndci:master","ref":"master","sha":"001bdc60f27d3e942fb6f7813fe5bfcf3ce53652","user":{"login":"houndci","id":17184073,"avatar_url":"https://avatars.githubusercontent.com/u/17184073?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"Organization","site_admin":false},"repo":{"id":35621147,"name":"scss","full_name":"houndci/scss","owner":{"login":"houndci","id":17184073,"avatar_url":"https://avatars.githubusercontent.com/u/17184073?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/houndci/scss","description":"SCSS review service","fork":false,"url":"https://api.github.com/repos/houndci/scss","forks_url":"https://api.github.com/repos/houndci/scss/forks","keys_url":"https://api.github.com/repos/houndci/scss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/houndci/scss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/houndci/scss/teams","hooks_url":"https://api.github.com/repos/houndci/scss/hooks","issue_events_url":"https://api.github.com/repos/houndci/scss/issues/events{/number}","events_url":"https://api.github.com/repos/houndci/scss/events","assignees_url":"https://api.github.com/repos/houndci/scss/assignees{/user}","branches_url":"https://api.github.com/repos/houndci/scss/branches{/branch}","tags_url":"https://api.github.com/repos/houndci/scss/tags","blobs_url":"https://api.github.com/repos/houndci/scss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/houndci/scss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/houndci/scss/git/refs{/sha}","trees_url":"https://api.github.com/repos/houndci/scss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/houndci/scss/statuses/{sha}","languages_url":"https://api.github.com/repos/houndci/scss/languages","stargazers_url":"https://api.github.com/repos/houndci/scss/stargazers","contributors_url":"https://api.github.com/repos/houndci/scss/contributors","subscribers_url":"https://api.github.com/repos/houndci/scss/subscribers","subscription_url":"https://api.github.com/repos/houndci/scss/subscription","commits_url":"https://api.github.com/repos/houndci/scss/commits{/sha}","git_commits_url":"https://api.github.com/repos/houndci/scss/git/commits{/sha}","comments_url":"https://api.github.com/repos/houndci/scss/comments{/number}","issue_comment_url":"https://api.github.com/repos/houndci/scss/issues/comments{/number}","contents_url":"https://api.github.com/repos/houndci/scss/contents/{+path}","compare_url":"https://api.github.com/repos/houndci/scss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/houndci/scss/merges","archive_url":"https://api.github.com/repos/houndci/scss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/houndci/scss/downloads","issues_url":"https://api.github.com/repos/houndci/scss/issues{/number}","pulls_url":"https://api.github.com/repos/houndci/scss/pulls{/number}","milestones_url":"https://api.github.com/repos/houndci/scss/milestones{/number}","notifications_url":"https://api.github.com/repos/houndci/scss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/houndci/scss/labels{/name}","releases_url":"https://api.github.com/repos/houndci/scss/releases{/id}","deployments_url":"https://api.github.com/repos/houndci/scss/deployments","created_at":"2015-05-14T16:03:10Z","updated_at":"2016-02-15T19:18:47Z","pushed_at":"2016-04-15T21:41:25Z","git_url":"git://github.com/houndci/scss.git","ssh_url":"git@github.com:houndci/scss.git","clone_url":"https://github.com/houndci/scss.git","svn_url":"https://github.com/houndci/scss","homepage":"","size":71,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/houndci/scss/pulls/26"},"html":{"href":"https://github.com/houndci/scss/pull/26"},"issue":{"href":"https://api.github.com/repos/houndci/scss/issues/26"},"comments":{"href":"https://api.github.com/repos/houndci/scss/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/houndci/scss/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/houndci/scss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/houndci/scss/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/houndci/scss/statuses/f66eb4d25c13686bc99926006a87b857b4721ab4"}}}}