{"action":"created","issue":{"url":"https://api.github.com/repos/tsakim/poibin/issues/1","repository_url":"https://api.github.com/repos/tsakim/poibin","labels_url":"https://api.github.com/repos/tsakim/poibin/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/tsakim/poibin/issues/1/comments","events_url":"https://api.github.com/repos/tsakim/poibin/issues/1/events","html_url":"https://github.com/tsakim/poibin/pull/1","id":186142665,"number":1,"title":"making half_n int","user":{"login":"brooksandrew","id":7719483,"avatar_url":"https://avatars.githubusercontent.com/u/7719483?v=3","gravatar_id":"","url":"https://api.github.com/users/brooksandrew","html_url":"https://github.com/brooksandrew","followers_url":"https://api.github.com/users/brooksandrew/followers","following_url":"https://api.github.com/users/brooksandrew/following{/other_user}","gists_url":"https://api.github.com/users/brooksandrew/gists{/gist_id}","starred_url":"https://api.github.com/users/brooksandrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brooksandrew/subscriptions","organizations_url":"https://api.github.com/users/brooksandrew/orgs","repos_url":"https://api.github.com/users/brooksandrew/repos","events_url":"https://api.github.com/users/brooksandrew/events{/privacy}","received_events_url":"https://api.github.com/users/brooksandrew/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-30T15:25:16Z","updated_at":"2016-11-03T12:53:19Z","closed_at":"2016-11-02T09:34:49Z","pull_request":{"url":"https://api.github.com/repos/tsakim/poibin/pulls/1","html_url":"https://github.com/tsakim/poibin/pull/1","diff_url":"https://github.com/tsakim/poibin/pull/1.diff","patch_url":"https://github.com/tsakim/poibin/pull/1.patch"},"body":"First off, great implementation of poisson binomial!  I'm building a system/algorithm/webapp (we'll see how ambitious I get) around the board game Settlers of Catan to quantify the \"luck factor\" (i.e. at turn X, a player has Y resources, what percentile are they are in?)... So i think the poisson binomial cdf is what I want.  I'm surprised how few implementations there are out there for what seems like a pretty common problem, so I've thoroughly enjoyed reading your poibin repo.\n\nIn any case - I might be missing something obvious, but with Python 3.5 (Anaconda 4.2.0), I needed to make the one little change in this PR to run your code.  \n\nWithout this change, this is the my error: \n\n```\nimport poibin\npoibin.PoiBin([0.1, 0.2, 0.3])\n```\n\n```\nTraceback (most recent call last):\n  File \"/Users/ajb/anaconda3/lib/python3.5/site-packages/IPython/core/interactiveshell.py\", line 2881, in run_code\n    exec(code_obj, self.user_global_ns, self.user_ns)\n  File \"<ipython-input-18-de02896a678f>\", line 1, in <module>\n    poibin.PoiBin([0.1, 0.2, 0.3])\n  File \"/Users/ajb/Documents/github/poibin/poibin.py\", line 55, in __init__\n    self.pmf_list = self.get_pmf_xi()\n  File \"/Users/ajb/Documents/github/poibin/poibin.py\", line 135, in get_pmf_xi\n    for i in range(1, half_n + 1):\nTypeError: 'float' object cannot be interpreted as an integer\n```\n"},"comment":{"url":"https://api.github.com/repos/tsakim/poibin/issues/comments/258133965","html_url":"https://github.com/tsakim/poibin/pull/1#issuecomment-258133965","issue_url":"https://api.github.com/repos/tsakim/poibin/issues/1","id":258133965,"user":{"login":"brooksandrew","id":7719483,"avatar_url":"https://avatars.githubusercontent.com/u/7719483?v=3","gravatar_id":"","url":"https://api.github.com/users/brooksandrew","html_url":"https://github.com/brooksandrew","followers_url":"https://api.github.com/users/brooksandrew/followers","following_url":"https://api.github.com/users/brooksandrew/following{/other_user}","gists_url":"https://api.github.com/users/brooksandrew/gists{/gist_id}","starred_url":"https://api.github.com/users/brooksandrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brooksandrew/subscriptions","organizations_url":"https://api.github.com/users/brooksandrew/orgs","repos_url":"https://api.github.com/users/brooksandrew/repos","events_url":"https://api.github.com/users/brooksandrew/events{/privacy}","received_events_url":"https://api.github.com/users/brooksandrew/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T12:53:18Z","updated_at":"2016-11-03T12:53:18Z","body":"@tsakim: awesome. should be fully Python 3.x friendly now, at least on my machine w 3.5 :)"}}
{"actor":{"display_login":"brooksandrew"}}