{"action":"created","comment":{"url":"https://api.github.com/repos/Netflix/dynomite/pulls/comments/92299232","pull_request_review_id":12812122,"id":92299232,"diff_hunk":"@@ -1009,11 +1017,10 @@ dnode_peer_connected(struct context *ctx, struct conn *conn)\n \n     conn->connecting = 0;\n     conn->connected = 1;\n+    peer->state = NORMAL;\n \n-        if (log_loggable(LOG_INFO)) {\n-       log_debug(LOG_INFO, \"dyn: peer connected on sd %d to server '%.*s'\", conn->sd,\n-              server->endpoint.pname.len, server->endpoint.pname.data);\n-        }\n+    log_notice(\"connected to %s '%.*s' from sd %u\", conn_get_type_string(conn),","path":"src/dyn_dnode_peer.c","position":154,"original_position":154,"commit_id":"def1decda3144e2c9a4f53011b53ec16e9c21829","original_commit_id":"def1decda3144e2c9a4f53011b53ec16e9c21829","user":{"login":"ipapapa","id":4562887,"avatar_url":"https://avatars.githubusercontent.com/u/4562887?v=3","gravatar_id":"","url":"https://api.github.com/users/ipapapa","html_url":"https://github.com/ipapapa","followers_url":"https://api.github.com/users/ipapapa/followers","following_url":"https://api.github.com/users/ipapapa/following{/other_user}","gists_url":"https://api.github.com/users/ipapapa/gists{/gist_id}","starred_url":"https://api.github.com/users/ipapapa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipapapa/subscriptions","organizations_url":"https://api.github.com/users/ipapapa/orgs","repos_url":"https://api.github.com/users/ipapapa/repos","events_url":"https://api.github.com/users/ipapapa/events{/privacy}","received_events_url":"https://api.github.com/users/ipapapa/received_events","type":"User","site_admin":false},"body":"What did we change `log_debug` to `log_notice`? First time I see the use of `log_notice`.","created_at":"2016-12-14T00:32:14Z","updated_at":"2016-12-14T00:32:14Z","html_url":"https://github.com/Netflix/dynomite/pull/388#discussion_r92299232","pull_request_url":"https://api.github.com/repos/Netflix/dynomite/pulls/388","_links":{"self":{"href":"https://api.github.com/repos/Netflix/dynomite/pulls/comments/92299232"},"html":{"href":"https://github.com/Netflix/dynomite/pull/388#discussion_r92299232"},"pull_request":{"href":"https://api.github.com/repos/Netflix/dynomite/pulls/388"}}},"pull_request":{"url":"https://api.github.com/repos/Netflix/dynomite/pulls/388","id":97810256,"html_url":"https://github.com/Netflix/dynomite/pull/388","diff_url":"https://github.com/Netflix/dynomite/pull/388.diff","patch_url":"https://github.com/Netflix/dynomite/pull/388.patch","issue_url":"https://api.github.com/repos/Netflix/dynomite/issues/388","number":388,"state":"open","locked":false,"title":"Implement generic task scheduler","user":{"login":"shailesh33","id":12148455,"avatar_url":"https://avatars.githubusercontent.com/u/12148455?v=3","gravatar_id":"","url":"https://api.github.com/users/shailesh33","html_url":"https://github.com/shailesh33","followers_url":"https://api.github.com/users/shailesh33/followers","following_url":"https://api.github.com/users/shailesh33/following{/other_user}","gists_url":"https://api.github.com/users/shailesh33/gists{/gist_id}","starred_url":"https://api.github.com/users/shailesh33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shailesh33/subscriptions","organizations_url":"https://api.github.com/users/shailesh33/orgs","repos_url":"https://api.github.com/users/shailesh33/repos","events_url":"https://api.github.com/users/shailesh33/events{/privacy}","received_events_url":"https://api.github.com/users/shailesh33/received_events","type":"User","site_admin":false},"body":"* Implement a task scheduler that takes tasks with 1 argument for now\r\n* Create a reconnect task everytime a connection to peer is broken\r\n* This reconnect task gets executed in the main loop\r\n* Individual peers will have their own backoff mechanism to be followed\r\n* Convert the connection retry timeouts to msec","created_at":"2016-12-13T18:41:30Z","updated_at":"2016-12-14T00:32:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"641b10e8526b16f72851686908958319e388630a","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Netflix/dynomite/milestones/4","html_url":"https://github.com/Netflix/dynomite/milestone/4","labels_url":"https://api.github.com/repos/Netflix/dynomite/milestones/4/labels","id":2192231,"number":4,"title":"Dynomite v0.5.9","description":"","creator":{"login":"ipapapa","id":4562887,"avatar_url":"https://avatars.githubusercontent.com/u/4562887?v=3","gravatar_id":"","url":"https://api.github.com/users/ipapapa","html_url":"https://github.com/ipapapa","followers_url":"https://api.github.com/users/ipapapa/followers","following_url":"https://api.github.com/users/ipapapa/following{/other_user}","gists_url":"https://api.github.com/users/ipapapa/gists{/gist_id}","starred_url":"https://api.github.com/users/ipapapa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipapapa/subscriptions","organizations_url":"https://api.github.com/users/ipapapa/orgs","repos_url":"https://api.github.com/users/ipapapa/repos","events_url":"https://api.github.com/users/ipapapa/events{/privacy}","received_events_url":"https://api.github.com/users/ipapapa/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":10,"state":"open","created_at":"2016-12-12T21:33:17Z","updated_at":"2016-12-13T18:41:30Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Netflix/dynomite/pulls/388/commits","review_comments_url":"https://api.github.com/repos/Netflix/dynomite/pulls/388/comments","review_comment_url":"https://api.github.com/repos/Netflix/dynomite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Netflix/dynomite/issues/388/comments","statuses_url":"https://api.github.com/repos/Netflix/dynomite/statuses/def1decda3144e2c9a4f53011b53ec16e9c21829","head":{"label":"Netflix:reconnect","ref":"reconnect","sha":"def1decda3144e2c9a4f53011b53ec16e9c21829","user":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":13484625,"name":"dynomite","full_name":"Netflix/dynomite","owner":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/dynomite","description":"A generic dynamo implementation for different k-v storage engines","fork":false,"url":"https://api.github.com/repos/Netflix/dynomite","forks_url":"https://api.github.com/repos/Netflix/dynomite/forks","keys_url":"https://api.github.com/repos/Netflix/dynomite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/dynomite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/dynomite/teams","hooks_url":"https://api.github.com/repos/Netflix/dynomite/hooks","issue_events_url":"https://api.github.com/repos/Netflix/dynomite/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/dynomite/events","assignees_url":"https://api.github.com/repos/Netflix/dynomite/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/dynomite/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/dynomite/tags","blobs_url":"https://api.github.com/repos/Netflix/dynomite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/dynomite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/dynomite/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/dynomite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/dynomite/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/dynomite/languages","stargazers_url":"https://api.github.com/repos/Netflix/dynomite/stargazers","contributors_url":"https://api.github.com/repos/Netflix/dynomite/contributors","subscribers_url":"https://api.github.com/repos/Netflix/dynomite/subscribers","subscription_url":"https://api.github.com/repos/Netflix/dynomite/subscription","commits_url":"https://api.github.com/repos/Netflix/dynomite/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/dynomite/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/dynomite/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/dynomite/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/dynomite/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/dynomite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/dynomite/merges","archive_url":"https://api.github.com/repos/Netflix/dynomite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/dynomite/downloads","issues_url":"https://api.github.com/repos/Netflix/dynomite/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/dynomite/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/dynomite/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/dynomite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/dynomite/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/dynomite/releases{/id}","deployments_url":"https://api.github.com/repos/Netflix/dynomite/deployments","created_at":"2013-10-10T22:36:31Z","updated_at":"2016-12-13T16:20:30Z","pushed_at":"2016-12-13T23:44:19Z","git_url":"git://github.com/Netflix/dynomite.git","ssh_url":"git@github.com:Netflix/dynomite.git","clone_url":"https://github.com/Netflix/dynomite.git","svn_url":"https://github.com/Netflix/dynomite","homepage":"","size":4376,"stargazers_count":1675,"watchers_count":1675,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":202,"mirror_url":null,"open_issues_count":25,"forks":202,"open_issues":25,"watchers":1675,"default_branch":"dev"}},"base":{"label":"Netflix:dev","ref":"dev","sha":"e5fc3ef856e1ff70050b72313576d81338bfa03c","user":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":13484625,"name":"dynomite","full_name":"Netflix/dynomite","owner":{"login":"Netflix","id":913567,"avatar_url":"https://avatars.githubusercontent.com/u/913567?v=3","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/dynomite","description":"A generic dynamo implementation for different k-v storage engines","fork":false,"url":"https://api.github.com/repos/Netflix/dynomite","forks_url":"https://api.github.com/repos/Netflix/dynomite/forks","keys_url":"https://api.github.com/repos/Netflix/dynomite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/dynomite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/dynomite/teams","hooks_url":"https://api.github.com/repos/Netflix/dynomite/hooks","issue_events_url":"https://api.github.com/repos/Netflix/dynomite/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/dynomite/events","assignees_url":"https://api.github.com/repos/Netflix/dynomite/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/dynomite/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/dynomite/tags","blobs_url":"https://api.github.com/repos/Netflix/dynomite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/dynomite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/dynomite/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/dynomite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/dynomite/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/dynomite/languages","stargazers_url":"https://api.github.com/repos/Netflix/dynomite/stargazers","contributors_url":"https://api.github.com/repos/Netflix/dynomite/contributors","subscribers_url":"https://api.github.com/repos/Netflix/dynomite/subscribers","subscription_url":"https://api.github.com/repos/Netflix/dynomite/subscription","commits_url":"https://api.github.com/repos/Netflix/dynomite/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/dynomite/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/dynomite/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/dynomite/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/dynomite/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/dynomite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/dynomite/merges","archive_url":"https://api.github.com/repos/Netflix/dynomite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/dynomite/downloads","issues_url":"https://api.github.com/repos/Netflix/dynomite/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/dynomite/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/dynomite/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/dynomite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/dynomite/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/dynomite/releases{/id}","deployments_url":"https://api.github.com/repos/Netflix/dynomite/deployments","created_at":"2013-10-10T22:36:31Z","updated_at":"2016-12-13T16:20:30Z","pushed_at":"2016-12-13T23:44:19Z","git_url":"git://github.com/Netflix/dynomite.git","ssh_url":"git@github.com:Netflix/dynomite.git","clone_url":"https://github.com/Netflix/dynomite.git","svn_url":"https://github.com/Netflix/dynomite","homepage":"","size":4376,"stargazers_count":1675,"watchers_count":1675,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":202,"mirror_url":null,"open_issues_count":25,"forks":202,"open_issues":25,"watchers":1675,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/dynomite/pulls/388"},"html":{"href":"https://github.com/Netflix/dynomite/pull/388"},"issue":{"href":"https://api.github.com/repos/Netflix/dynomite/issues/388"},"comments":{"href":"https://api.github.com/repos/Netflix/dynomite/issues/388/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/dynomite/pulls/388/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/dynomite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Netflix/dynomite/pulls/388/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/dynomite/statuses/def1decda3144e2c9a4f53011b53ec16e9c21829"}}}}
{"actor":{"display_login":"ipapapa"}}