{"action":"closed","number":31,"pull_request":{"url":"https://api.github.com/repos/testIT-WebTester/webtester-core/pulls/31","id":58499487,"html_url":"https://github.com/testIT-WebTester/webtester-core/pull/31","diff_url":"https://github.com/testIT-WebTester/webtester-core/pull/31.diff","patch_url":"https://github.com/testIT-WebTester/webtester-core/pull/31.patch","issue_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/issues/31","number":31,"state":"closed","locked":false,"title":"Mapping based validation","user":{"login":"slu-it","id":8013955,"avatar_url":"https://avatars.githubusercontent.com/u/8013955?v=3","gravatar_id":"","url":"https://api.github.com/users/slu-it","html_url":"https://github.com/slu-it","followers_url":"https://api.github.com/users/slu-it/followers","following_url":"https://api.github.com/users/slu-it/following{/other_user}","gists_url":"https://api.github.com/users/slu-it/gists{/gist_id}","starred_url":"https://api.github.com/users/slu-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slu-it/subscriptions","organizations_url":"https://api.github.com/users/slu-it/orgs","repos_url":"https://api.github.com/users/slu-it/repos","events_url":"https://api.github.com/users/slu-it/events{/privacy}","received_events_url":"https://api.github.com/users/slu-it/received_events","type":"User","site_admin":false},"body":"With this we can provide an elegant and concise way of validating page object classes.\r\n\r\nIt replaces the current per implementation validation (by overriding the isValidClassFor... method in PageObject) with an annotation based approach. The old method was deprecated and will be removed in v1.3.0.\r\n\r\n**Examples:**\r\n* ```@Mapping(tag=\"div\")``` Will be evaluated as 'valid' in case the web element has the tag 'div'.\r\n* ```@Mapping(tag=\"select\", attribute=\"multiple\")``` Will be evaluated as 'valid' in case the web element has the tag 'select' and the 'multiple' attribute is present.\r\n* ```@Mapping(tag=\"select\", attribute=\"!multiple\")``` Will be evaluated as 'valid' in case the web element has the tag 'select' and the 'multiple' attribute is not present.\r\n* ```@Mapping(tag=\"input\", attribute=\"type\", values={\"text\", \"password\"})``` Will be evaluated as 'valid' in case the web element has the tag 'input' and the 'type' attribute has either the 'text' oder 'password' value.\r\n* ```@Mapping(validator=FooValidator.class)``` Will create a new instance of the given validator class and use it to evaluate the web element.\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/testit-webtester/webtester-core/31)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-02-05T23:32:23Z","updated_at":"2016-02-23T15:49:15Z","closed_at":"2016-02-23T15:49:15Z","merged_at":"2016-02-23T15:49:15Z","merge_commit_sha":"7ceb1f2d4a11cefcd6a8afed7ba15badf97a102d","assignee":{"login":"benhamidene","id":8468144,"avatar_url":"https://avatars.githubusercontent.com/u/8468144?v=3","gravatar_id":"","url":"https://api.github.com/users/benhamidene","html_url":"https://github.com/benhamidene","followers_url":"https://api.github.com/users/benhamidene/followers","following_url":"https://api.github.com/users/benhamidene/following{/other_user}","gists_url":"https://api.github.com/users/benhamidene/gists{/gist_id}","starred_url":"https://api.github.com/users/benhamidene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benhamidene/subscriptions","organizations_url":"https://api.github.com/users/benhamidene/orgs","repos_url":"https://api.github.com/users/benhamidene/repos","events_url":"https://api.github.com/users/benhamidene/events{/privacy}","received_events_url":"https://api.github.com/users/benhamidene/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/testIT-WebTester/webtester-core/milestones/2","html_url":"https://github.com/testIT-WebTester/webtester-core/milestones/1.2.0","labels_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/milestones/2/labels","id":1501681,"number":2,"title":"1.2.0","description":null,"creator":{"login":"slu-it","id":8013955,"avatar_url":"https://avatars.githubusercontent.com/u/8013955?v=3","gravatar_id":"","url":"https://api.github.com/users/slu-it","html_url":"https://github.com/slu-it","followers_url":"https://api.github.com/users/slu-it/followers","following_url":"https://api.github.com/users/slu-it/following{/other_user}","gists_url":"https://api.github.com/users/slu-it/gists{/gist_id}","starred_url":"https://api.github.com/users/slu-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slu-it/subscriptions","organizations_url":"https://api.github.com/users/slu-it/orgs","repos_url":"https://api.github.com/users/slu-it/repos","events_url":"https://api.github.com/users/slu-it/events{/privacy}","received_events_url":"https://api.github.com/users/slu-it/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":1,"state":"open","created_at":"2016-01-12T09:22:44Z","updated_at":"2016-02-23T15:49:15Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/pulls/31/commits","review_comments_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/pulls/31/comments","review_comment_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/issues/31/comments","statuses_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/statuses/2d2c31fe37bd746e04fe447c15373ca845eec94a","head":{"label":"slu-it:mapping-based-validation","ref":"mapping-based-validation","sha":"2d2c31fe37bd746e04fe447c15373ca845eec94a","user":{"login":"slu-it","id":8013955,"avatar_url":"https://avatars.githubusercontent.com/u/8013955?v=3","gravatar_id":"","url":"https://api.github.com/users/slu-it","html_url":"https://github.com/slu-it","followers_url":"https://api.github.com/users/slu-it/followers","following_url":"https://api.github.com/users/slu-it/following{/other_user}","gists_url":"https://api.github.com/users/slu-it/gists{/gist_id}","starred_url":"https://api.github.com/users/slu-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slu-it/subscriptions","organizations_url":"https://api.github.com/users/slu-it/orgs","repos_url":"https://api.github.com/users/slu-it/repos","events_url":"https://api.github.com/users/slu-it/events{/privacy}","received_events_url":"https://api.github.com/users/slu-it/received_events","type":"User","site_admin":false},"repo":{"id":46303213,"name":"webtester-core","full_name":"slu-it/webtester-core","owner":{"login":"slu-it","id":8013955,"avatar_url":"https://avatars.githubusercontent.com/u/8013955?v=3","gravatar_id":"","url":"https://api.github.com/users/slu-it","html_url":"https://github.com/slu-it","followers_url":"https://api.github.com/users/slu-it/followers","following_url":"https://api.github.com/users/slu-it/following{/other_user}","gists_url":"https://api.github.com/users/slu-it/gists{/gist_id}","starred_url":"https://api.github.com/users/slu-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slu-it/subscriptions","organizations_url":"https://api.github.com/users/slu-it/orgs","repos_url":"https://api.github.com/users/slu-it/repos","events_url":"https://api.github.com/users/slu-it/events{/privacy}","received_events_url":"https://api.github.com/users/slu-it/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slu-it/webtester-core","description":"The testIT WebTester core repository containing all of the stable features and support libraries.","fork":true,"url":"https://api.github.com/repos/slu-it/webtester-core","forks_url":"https://api.github.com/repos/slu-it/webtester-core/forks","keys_url":"https://api.github.com/repos/slu-it/webtester-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slu-it/webtester-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slu-it/webtester-core/teams","hooks_url":"https://api.github.com/repos/slu-it/webtester-core/hooks","issue_events_url":"https://api.github.com/repos/slu-it/webtester-core/issues/events{/number}","events_url":"https://api.github.com/repos/slu-it/webtester-core/events","assignees_url":"https://api.github.com/repos/slu-it/webtester-core/assignees{/user}","branches_url":"https://api.github.com/repos/slu-it/webtester-core/branches{/branch}","tags_url":"https://api.github.com/repos/slu-it/webtester-core/tags","blobs_url":"https://api.github.com/repos/slu-it/webtester-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slu-it/webtester-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slu-it/webtester-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/slu-it/webtester-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slu-it/webtester-core/statuses/{sha}","languages_url":"https://api.github.com/repos/slu-it/webtester-core/languages","stargazers_url":"https://api.github.com/repos/slu-it/webtester-core/stargazers","contributors_url":"https://api.github.com/repos/slu-it/webtester-core/contributors","subscribers_url":"https://api.github.com/repos/slu-it/webtester-core/subscribers","subscription_url":"https://api.github.com/repos/slu-it/webtester-core/subscription","commits_url":"https://api.github.com/repos/slu-it/webtester-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/slu-it/webtester-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/slu-it/webtester-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/slu-it/webtester-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/slu-it/webtester-core/contents/{+path}","compare_url":"https://api.github.com/repos/slu-it/webtester-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slu-it/webtester-core/merges","archive_url":"https://api.github.com/repos/slu-it/webtester-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slu-it/webtester-core/downloads","issues_url":"https://api.github.com/repos/slu-it/webtester-core/issues{/number}","pulls_url":"https://api.github.com/repos/slu-it/webtester-core/pulls{/number}","milestones_url":"https://api.github.com/repos/slu-it/webtester-core/milestones{/number}","notifications_url":"https://api.github.com/repos/slu-it/webtester-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slu-it/webtester-core/labels{/name}","releases_url":"https://api.github.com/repos/slu-it/webtester-core/releases{/id}","deployments_url":"https://api.github.com/repos/slu-it/webtester-core/deployments","created_at":"2015-11-16T21:16:20Z","updated_at":"2015-12-10T10:55:02Z","pushed_at":"2016-02-08T19:30:54Z","git_url":"git://github.com/slu-it/webtester-core.git","ssh_url":"git@github.com:slu-it/webtester-core.git","clone_url":"https://github.com/slu-it/webtester-core.git","svn_url":"https://github.com/slu-it/webtester-core","homepage":null,"size":387,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"testIT-WebTester:master","ref":"master","sha":"bcae341c19a56c686d90655234dab8cd59fc866a","user":{"login":"testIT-WebTester","id":15627428,"avatar_url":"https://avatars.githubusercontent.com/u/15627428?v=3","gravatar_id":"","url":"https://api.github.com/users/testIT-WebTester","html_url":"https://github.com/testIT-WebTester","followers_url":"https://api.github.com/users/testIT-WebTester/followers","following_url":"https://api.github.com/users/testIT-WebTester/following{/other_user}","gists_url":"https://api.github.com/users/testIT-WebTester/gists{/gist_id}","starred_url":"https://api.github.com/users/testIT-WebTester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/testIT-WebTester/subscriptions","organizations_url":"https://api.github.com/users/testIT-WebTester/orgs","repos_url":"https://api.github.com/users/testIT-WebTester/repos","events_url":"https://api.github.com/users/testIT-WebTester/events{/privacy}","received_events_url":"https://api.github.com/users/testIT-WebTester/received_events","type":"Organization","site_admin":false},"repo":{"id":46213547,"name":"webtester-core","full_name":"testIT-WebTester/webtester-core","owner":{"login":"testIT-WebTester","id":15627428,"avatar_url":"https://avatars.githubusercontent.com/u/15627428?v=3","gravatar_id":"","url":"https://api.github.com/users/testIT-WebTester","html_url":"https://github.com/testIT-WebTester","followers_url":"https://api.github.com/users/testIT-WebTester/followers","following_url":"https://api.github.com/users/testIT-WebTester/following{/other_user}","gists_url":"https://api.github.com/users/testIT-WebTester/gists{/gist_id}","starred_url":"https://api.github.com/users/testIT-WebTester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/testIT-WebTester/subscriptions","organizations_url":"https://api.github.com/users/testIT-WebTester/orgs","repos_url":"https://api.github.com/users/testIT-WebTester/repos","events_url":"https://api.github.com/users/testIT-WebTester/events{/privacy}","received_events_url":"https://api.github.com/users/testIT-WebTester/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/testIT-WebTester/webtester-core","description":"The testIT WebTester core repository containing all of the stable features and support libraries.","fork":false,"url":"https://api.github.com/repos/testIT-WebTester/webtester-core","forks_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/forks","keys_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/teams","hooks_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/hooks","issue_events_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/issues/events{/number}","events_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/events","assignees_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/assignees{/user}","branches_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/branches{/branch}","tags_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/tags","blobs_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/statuses/{sha}","languages_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/languages","stargazers_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/stargazers","contributors_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/contributors","subscribers_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/subscribers","subscription_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/subscription","commits_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/contents/{+path}","compare_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/merges","archive_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/downloads","issues_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/issues{/number}","pulls_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/pulls{/number}","milestones_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/milestones{/number}","notifications_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/labels{/name}","releases_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/releases{/id}","deployments_url":"https://api.github.com/repos/testIT-WebTester/webtester-core/deployments","created_at":"2015-11-15T10:42:39Z","updated_at":"2016-02-20T19:32:58Z","pushed_at":"2016-02-23T15:49:15Z","git_url":"git://github.com/testIT-WebTester/webtester-core.git","ssh_url":"git@github.com:testIT-WebTester/webtester-core.git","clone_url":"https://github.com/testIT-WebTester/webtester-core.git","svn_url":"https://github.com/testIT-WebTester/webtester-core","homepage":"","size":420,"stargazers_count":33,"watchers_count":33,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":2,"forks":10,"open_issues":2,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/testIT-WebTester/webtester-core/pulls/31"},"html":{"href":"https://github.com/testIT-WebTester/webtester-core/pull/31"},"issue":{"href":"https://api.github.com/repos/testIT-WebTester/webtester-core/issues/31"},"comments":{"href":"https://api.github.com/repos/testIT-WebTester/webtester-core/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/testIT-WebTester/webtester-core/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/testIT-WebTester/webtester-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/testIT-WebTester/webtester-core/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/testIT-WebTester/webtester-core/statuses/2d2c31fe37bd746e04fe447c15373ca845eec94a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"slu-it","id":8013955,"avatar_url":"https://avatars.githubusercontent.com/u/8013955?v=3","gravatar_id":"","url":"https://api.github.com/users/slu-it","html_url":"https://github.com/slu-it","followers_url":"https://api.github.com/users/slu-it/followers","following_url":"https://api.github.com/users/slu-it/following{/other_user}","gists_url":"https://api.github.com/users/slu-it/gists{/gist_id}","starred_url":"https://api.github.com/users/slu-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slu-it/subscriptions","organizations_url":"https://api.github.com/users/slu-it/orgs","repos_url":"https://api.github.com/users/slu-it/repos","events_url":"https://api.github.com/users/slu-it/events{/privacy}","received_events_url":"https://api.github.com/users/slu-it/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":679,"deletions":429,"changed_files":54}}