{"action":"closed","number":90,"pull_request":{"url":"https://api.github.com/repos/pingcap/rust-prometheus/pulls/90","id":93281684,"html_url":"https://github.com/pingcap/rust-prometheus/pull/90","diff_url":"https://github.com/pingcap/rust-prometheus/pull/90.diff","patch_url":"https://github.com/pingcap/rust-prometheus/pull/90.patch","issue_url":"https://api.github.com/repos/pingcap/rust-prometheus/issues/90","number":90,"state":"closed","locked":false,"title":"macros: refactor histogram macros","user":{"login":"overvenus","id":2150711,"avatar_url":"https://avatars.githubusercontent.com/u/2150711?v=3","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false},"body":"Macro API changes:\r\n\r\n* `histogram_opts!`\r\n  * Remove: \r\n    - `histogram_opts!( $ NAME : expr , $ HELP : expr , [ $ ( $ BUCKETS : expr ) , * ] )`\r\n    - `histogram_opts!( $ NAME : expr , $ HELP : expr $ ( , $ CONST_LABELS : expr ) * )`\r\n    - `histogram_opts!( $ NAME : expr , $ HELP : expr , $ CONST_LABELS : expr , [ $ ( $ BUCKETS : expr ) , + ] )`\r\n  * Add:\r\n    - `histogram_opts!( $ NAME : expr , $ HELP : expr )`\r\n    - `histogram_opts!( $ NAME : expr , $ HELP : expr , $ BUCKETS : expr )`\r\n\r\n* `register_histogram!`\r\n  * Remove: \r\n    - `register_histogram!( $ NAME : expr , $ HELP : expr , $ CONST_LABELS : expr )`\r\n    - `register_histogram!( $ NAME : expr , $ HELP : expr , $ CONST_LABELS : expr , [ $ ( $ BUCKETS : expr ) , + ] )`\r\n  * Add:\r\n    - `register_histogram!( $ NAME : expr , $ HELP : expr , $ BUCKETS : expr )`\r\n\r\n\r\n* `register_histogram_vec!`\r\n  * Remove: \r\n    - `register_histogram_vec!( $ NAME : expr , $ HELP : expr , $ CONST_LABELS : expr , $ LABELS_NAMES : expr )`\r\n  * Add:\r\n    - `register_histogram_vec!( $ NAME : expr , $ HELP : expr , $ LABELS_NAMES : expr , $ BUCKETS : expr)`\r\n\r\n\r\nIn a nutshell, `CONST_LABELS` are replaced with `BUCKETS`. \r\n\r\nClose #55 \r\n\r\nPTAL @siddontang ","created_at":"2016-11-11T05:32:50Z","updated_at":"2016-11-19T02:58:10Z","closed_at":"2016-11-19T02:58:10Z","merged_at":null,"merge_commit_sha":"996feb508c541e94ed9111c7a8728e4225eaf744","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/rust-prometheus/pulls/90/commits","review_comments_url":"https://api.github.com/repos/pingcap/rust-prometheus/pulls/90/comments","review_comment_url":"https://api.github.com/repos/pingcap/rust-prometheus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/rust-prometheus/issues/90/comments","statuses_url":"https://api.github.com/repos/pingcap/rust-prometheus/statuses/9cc369911563549183d1074490ed36aa6a2b5be0","head":{"label":"overvenus:refactor-histogram-macros","ref":"refactor-histogram-macros","sha":"9cc369911563549183d1074490ed36aa6a2b5be0","user":{"login":"overvenus","id":2150711,"avatar_url":"https://avatars.githubusercontent.com/u/2150711?v=3","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false},"repo":{"id":66003047,"name":"rust-prometheus","full_name":"overvenus/rust-prometheus","owner":{"login":"overvenus","id":2150711,"avatar_url":"https://avatars.githubusercontent.com/u/2150711?v=3","gravatar_id":"","url":"https://api.github.com/users/overvenus","html_url":"https://github.com/overvenus","followers_url":"https://api.github.com/users/overvenus/followers","following_url":"https://api.github.com/users/overvenus/following{/other_user}","gists_url":"https://api.github.com/users/overvenus/gists{/gist_id}","starred_url":"https://api.github.com/users/overvenus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/overvenus/subscriptions","organizations_url":"https://api.github.com/users/overvenus/orgs","repos_url":"https://api.github.com/users/overvenus/repos","events_url":"https://api.github.com/users/overvenus/events{/privacy}","received_events_url":"https://api.github.com/users/overvenus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/overvenus/rust-prometheus","description":"Prometheus instrumentation library for Rust applications","fork":true,"url":"https://api.github.com/repos/overvenus/rust-prometheus","forks_url":"https://api.github.com/repos/overvenus/rust-prometheus/forks","keys_url":"https://api.github.com/repos/overvenus/rust-prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/overvenus/rust-prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/overvenus/rust-prometheus/teams","hooks_url":"https://api.github.com/repos/overvenus/rust-prometheus/hooks","issue_events_url":"https://api.github.com/repos/overvenus/rust-prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/overvenus/rust-prometheus/events","assignees_url":"https://api.github.com/repos/overvenus/rust-prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/overvenus/rust-prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/overvenus/rust-prometheus/tags","blobs_url":"https://api.github.com/repos/overvenus/rust-prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/overvenus/rust-prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/overvenus/rust-prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/overvenus/rust-prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/overvenus/rust-prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/overvenus/rust-prometheus/languages","stargazers_url":"https://api.github.com/repos/overvenus/rust-prometheus/stargazers","contributors_url":"https://api.github.com/repos/overvenus/rust-prometheus/contributors","subscribers_url":"https://api.github.com/repos/overvenus/rust-prometheus/subscribers","subscription_url":"https://api.github.com/repos/overvenus/rust-prometheus/subscription","commits_url":"https://api.github.com/repos/overvenus/rust-prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/overvenus/rust-prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/overvenus/rust-prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/overvenus/rust-prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/overvenus/rust-prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/overvenus/rust-prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/overvenus/rust-prometheus/merges","archive_url":"https://api.github.com/repos/overvenus/rust-prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/overvenus/rust-prometheus/downloads","issues_url":"https://api.github.com/repos/overvenus/rust-prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/overvenus/rust-prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/overvenus/rust-prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/overvenus/rust-prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/overvenus/rust-prometheus/labels{/name}","releases_url":"https://api.github.com/repos/overvenus/rust-prometheus/releases{/id}","deployments_url":"https://api.github.com/repos/overvenus/rust-prometheus/deployments","created_at":"2016-08-18T14:17:28Z","updated_at":"2016-08-18T14:17:30Z","pushed_at":"2016-11-18T05:22:32Z","git_url":"git://github.com/overvenus/rust-prometheus.git","ssh_url":"git@github.com:overvenus/rust-prometheus.git","clone_url":"https://github.com/overvenus/rust-prometheus.git","svn_url":"https://github.com/overvenus/rust-prometheus","homepage":null,"size":239,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"eb4e8ea76f2be5e9e38c082901db560268fcf808","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":65430363,"name":"rust-prometheus","full_name":"pingcap/rust-prometheus","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/rust-prometheus","description":"Prometheus instrumentation library for Rust applications","fork":false,"url":"https://api.github.com/repos/pingcap/rust-prometheus","forks_url":"https://api.github.com/repos/pingcap/rust-prometheus/forks","keys_url":"https://api.github.com/repos/pingcap/rust-prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/rust-prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/rust-prometheus/teams","hooks_url":"https://api.github.com/repos/pingcap/rust-prometheus/hooks","issue_events_url":"https://api.github.com/repos/pingcap/rust-prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/rust-prometheus/events","assignees_url":"https://api.github.com/repos/pingcap/rust-prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/rust-prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/rust-prometheus/tags","blobs_url":"https://api.github.com/repos/pingcap/rust-prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/rust-prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/rust-prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/rust-prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/rust-prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/rust-prometheus/languages","stargazers_url":"https://api.github.com/repos/pingcap/rust-prometheus/stargazers","contributors_url":"https://api.github.com/repos/pingcap/rust-prometheus/contributors","subscribers_url":"https://api.github.com/repos/pingcap/rust-prometheus/subscribers","subscription_url":"https://api.github.com/repos/pingcap/rust-prometheus/subscription","commits_url":"https://api.github.com/repos/pingcap/rust-prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/rust-prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/rust-prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/rust-prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/rust-prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/rust-prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/rust-prometheus/merges","archive_url":"https://api.github.com/repos/pingcap/rust-prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/rust-prometheus/downloads","issues_url":"https://api.github.com/repos/pingcap/rust-prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/rust-prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/rust-prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/rust-prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/rust-prometheus/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/rust-prometheus/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/rust-prometheus/deployments","created_at":"2016-08-11T02:06:25Z","updated_at":"2016-11-16T22:03:31Z","pushed_at":"2016-11-19T01:23:23Z","git_url":"git://github.com/pingcap/rust-prometheus.git","ssh_url":"git@github.com:pingcap/rust-prometheus.git","clone_url":"https://github.com/pingcap/rust-prometheus.git","svn_url":"https://github.com/pingcap/rust-prometheus","homepage":null,"size":313,"stargazers_count":25,"watchers_count":25,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":12,"forks":5,"open_issues":12,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/rust-prometheus/pulls/90"},"html":{"href":"https://github.com/pingcap/rust-prometheus/pull/90"},"issue":{"href":"https://api.github.com/repos/pingcap/rust-prometheus/issues/90"},"comments":{"href":"https://api.github.com/repos/pingcap/rust-prometheus/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/rust-prometheus/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/rust-prometheus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/rust-prometheus/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/rust-prometheus/statuses/9cc369911563549183d1074490ed36aa6a2b5be0"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":5,"review_comments":0,"commits":1,"additions":27,"deletions":83,"changed_files":2}}
{"actor":{"display_login":"overvenus"}}