{"action":"closed","issue":{"url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/1826","repository_url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL","labels_url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/1826/labels{/name}","comments_url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/1826/comments","events_url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/issues/1826/events","html_url":"https://github.com/LoneGazebo/Community-Patch-DLL/issues/1826","id":155885298,"number":1826,"title":"Futher issue with GetDenounceMessage() in latest version","user":{"login":"Typhlomence","id":18669529,"avatar_url":"https://avatars.githubusercontent.com/u/18669529?v=3","gravatar_id":"","url":"https://api.github.com/users/Typhlomence","html_url":"https://github.com/Typhlomence","followers_url":"https://api.github.com/users/Typhlomence/followers","following_url":"https://api.github.com/users/Typhlomence/following{/other_user}","gists_url":"https://api.github.com/users/Typhlomence/gists{/gist_id}","starred_url":"https://api.github.com/users/Typhlomence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Typhlomence/subscriptions","organizations_url":"https://api.github.com/users/Typhlomence/orgs","repos_url":"https://api.github.com/users/Typhlomence/repos","events_url":"https://api.github.com/users/Typhlomence/events{/privacy}","received_events_url":"https://api.github.com/users/Typhlomence/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/LoneGazebo/Community-Patch-DLL/labels/Question%20for%20issue%20poster","name":"Question for issue poster","color":"cc317c"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-05-20T04:34:30Z","updated_at":"2016-06-15T01:19:15Z","closed_at":"2016-06-15T01:19:15Z","body":"This is a follow up to https://github.com/LoneGazebo/Community-Patch-DLL/issues/1660\r\n\r\nIn that issue, I had suggseted that some of the if statements that returned values for denouncing based on ideology be changed from **m_pPlayer->GetPlayerPolicies()->GetLateGamePolicyTree()** to **GET_PLAYER(ePlayer).GetPlayerPolicies()->GetLateGamePolicyTree()**.\r\n\r\nIt was my intention to suggest that only the statements that returned values 4, 5 and 6 be changed to use GET_PLAYER(ePlayer). However, in the newest committed code, this is changed for the ones that returned 1, 2 and 3 as well.\r\n\r\nI apologise if my previous issue wasn't clear on this point. The final code for that whole section should be:\r\n```\r\n// Guy is a different ideology\r\nif(GetDiploBalance() > 5 && (GET_PLAYER(ePlayer).GetPlayerPolicies()->GetLateGamePolicyTree() != GetPlayer()->GetPlayerPolicies()->GetLateGamePolicyTree()) && (GetPlayer()->GetPlayerPolicies()->GetLateGamePolicyTree() != NO_POLICY_BRANCH_TYPE) && (GET_PLAYER(ePlayer).GetPlayerPolicies()->GetLateGamePolicyTree() != NO_POLICY_BRANCH_TYPE) && GET_PLAYER(ePlayer).GetCulture()->GetPublicOpinionPreferredIdeology() == m_pPlayer->GetPlayerPolicies()->GetLateGamePolicyTree())\r\n{\r\n\tif(m_pPlayer->GetPlayerPolicies()->GetLateGamePolicyTree() == GC.getPOLICY_BRANCH_AUTOCRACY())\r\n\t{\r\n\t\treturn 1;\r\n\t}\r\n\telse if(m_pPlayer->GetPlayerPolicies()->GetLateGamePolicyTree() == GC.getPOLICY_BRANCH_ORDER())\r\n\t{\r\n\t\treturn 2;\r\n\t}\r\n\telse if(m_pPlayer->GetPlayerPolicies()->GetLateGamePolicyTree() == GC.getPOLICY_BRANCH_FREEDOM())\r\n\t{\r\n\t\treturn 3;\r\n\t}\r\n}\r\nelse if(GetDiploBalance() > 5 && (GET_PLAYER(ePlayer).GetPlayerPolicies()->GetLateGamePolicyTree() != GetPlayer()->GetPlayerPolicies()->GetLateGamePolicyTree()) && (GetPlayer()->GetPlayerPolicies()->GetLateGamePolicyTree() != NO_POLICY_BRANCH_TYPE) && (GET_PLAYER(ePlayer).GetPlayerPolicies()->GetLateGamePolicyTree() != NO_POLICY_BRANCH_TYPE) && m_pPlayer->GetCulture()->GetPublicOpinionPreferredIdeology() == GET_PLAYER(ePlayer).GetPlayerPolicies()->GetLateGamePolicyTree())\r\n{\r\n\tif(GET_PLAYER(ePlayer).GetPlayerPolicies()->GetLateGamePolicyTree() == GC.getPOLICY_BRANCH_AUTOCRACY())\r\n\t{\r\n\t\treturn 4;\r\n\t}\r\n\telse if(GET_PLAYER(ePlayer).GetPlayerPolicies()->GetLateGamePolicyTree() == GC.getPOLICY_BRANCH_ORDER())\r\n\t{\r\n\t\treturn 5;\r\n\t}\r\n\telse if(GET_PLAYER(ePlayer).GetPlayerPolicies()->GetLateGamePolicyTree() == GC.getPOLICY_BRANCH_FREEDOM())\r\n\t{\r\n\t\treturn 6;\r\n\t}\r\n}\r\n```"}}
{"actor":{"display_login":"LoneGazebo"}}