{"action":"created","comment":{"url":"https://api.github.com/repos/everypolitician/scraped_page_archive/pulls/comments/80872468","pull_request_review_id":1894177,"id":80872468,"diff_hunk":"@@ -52,7 +52,10 @@ the details of your repo to produce a setting in the form:\n \n ```ruby\n REPO = 'https://YOUR_GITHUB_TOKEN@github.com/everypolitician-scrapers/kenya-mzalendo'\n-ScrapedPageArchive.github_repo_url = REPO\n+storage = ScrapedPageArchive::GitStorage.new\n+storage.github_repo_url = REPO","path":"README.md","position":null,"original_position":6,"commit_id":"fb8f98d599f1752d19f52c1892590fe61065ddd6","original_commit_id":"70e492664da2c46ed851a9250f6bca2e2bb11a7a","user":{"login":"chrismytton","id":22996,"avatar_url":"https://avatars.githubusercontent.com/u/22996?v=3","gravatar_id":"","url":"https://api.github.com/users/chrismytton","html_url":"https://github.com/chrismytton","followers_url":"https://api.github.com/users/chrismytton/followers","following_url":"https://api.github.com/users/chrismytton/following{/other_user}","gists_url":"https://api.github.com/users/chrismytton/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismytton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismytton/subscriptions","organizations_url":"https://api.github.com/users/chrismytton/orgs","repos_url":"https://api.github.com/users/chrismytton/repos","events_url":"https://api.github.com/users/chrismytton/events{/privacy}","received_events_url":"https://api.github.com/users/chrismytton/received_events","type":"User","site_admin":false},"body":"> Constructors that don't take any arguments are a warning sign.\r\n\r\nmindblown.gif\r\n\r\nVery interesting observation! I hadn't really thought about it in those terms before but the more I think about it the more sense it makes. I've moved this option into the constructor in https://github.com/everypolitician/scraped_page_archive/pull/42/commits/23ecf52a861d1098358dde19e4fd65e5f6b93a5e.\r\n\r\n> Do all the methods in these classes need to be public?\r\n\r\nNo, indeed they don't. I've defined a small public interface in https://github.com/everypolitician/scraped_page_archive/pull/42/commits/fb8f98d599f1752d19f52c1892590fe61065ddd6.","created_at":"2016-09-28T09:08:34Z","updated_at":"2016-09-28T09:08:34Z","html_url":"https://github.com/everypolitician/scraped_page_archive/pull/42#discussion_r80872468","pull_request_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/everypolitician/scraped_page_archive/pulls/comments/80872468"},"html":{"href":"https://github.com/everypolitician/scraped_page_archive/pull/42#discussion_r80872468"},"pull_request":{"href":"https://api.github.com/repos/everypolitician/scraped_page_archive/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/everypolitician/scraped_page_archive/pulls/42","id":86543385,"html_url":"https://github.com/everypolitician/scraped_page_archive/pull/42","diff_url":"https://github.com/everypolitician/scraped_page_archive/pull/42.diff","patch_url":"https://github.com/everypolitician/scraped_page_archive/pull/42.patch","issue_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/issues/42","number":42,"state":"open","locked":false,"title":"Extract git operations into a separate storage class","user":{"login":"chrismytton","id":22996,"avatar_url":"https://avatars.githubusercontent.com/u/22996?v=3","gravatar_id":"","url":"https://api.github.com/users/chrismytton","html_url":"https://github.com/chrismytton","followers_url":"https://api.github.com/users/chrismytton/followers","following_url":"https://api.github.com/users/chrismytton/following{/other_user}","gists_url":"https://api.github.com/users/chrismytton/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismytton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismytton/subscriptions","organizations_url":"https://api.github.com/users/chrismytton/orgs","repos_url":"https://api.github.com/users/chrismytton/repos","events_url":"https://api.github.com/users/chrismytton/events{/privacy}","received_events_url":"https://api.github.com/users/chrismytton/received_events","type":"User","site_admin":false},"body":"This introduces a new `GitStorage` class which is an extraction of the git parts of the `ScrapedPageArchive` class. This should make it easier to test the git parts of this gem in isolation. It also means there is looser coupling between `ScrapedPageArchive` and `git`.\r\n\r\nThis change was spurred on by https://github.com/everypolitician/scraped_page_archive/pull/40#discussion_r80220902.","created_at":"2016-09-23T16:34:58Z","updated_at":"2016-09-28T09:08:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eedd643ae96d24b84290fc685a04b739a1696e74","assignee":{"login":"tmtmtmtm","id":57483,"avatar_url":"https://avatars.githubusercontent.com/u/57483?v=3","gravatar_id":"","url":"https://api.github.com/users/tmtmtmtm","html_url":"https://github.com/tmtmtmtm","followers_url":"https://api.github.com/users/tmtmtmtm/followers","following_url":"https://api.github.com/users/tmtmtmtm/following{/other_user}","gists_url":"https://api.github.com/users/tmtmtmtm/gists{/gist_id}","starred_url":"https://api.github.com/users/tmtmtmtm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmtmtmtm/subscriptions","organizations_url":"https://api.github.com/users/tmtmtmtm/orgs","repos_url":"https://api.github.com/users/tmtmtmtm/repos","events_url":"https://api.github.com/users/tmtmtmtm/events{/privacy}","received_events_url":"https://api.github.com/users/tmtmtmtm/received_events","type":"User","site_admin":false},"assignees":[{"login":"tmtmtmtm","id":57483,"avatar_url":"https://avatars.githubusercontent.com/u/57483?v=3","gravatar_id":"","url":"https://api.github.com/users/tmtmtmtm","html_url":"https://github.com/tmtmtmtm","followers_url":"https://api.github.com/users/tmtmtmtm/followers","following_url":"https://api.github.com/users/tmtmtmtm/following{/other_user}","gists_url":"https://api.github.com/users/tmtmtmtm/gists{/gist_id}","starred_url":"https://api.github.com/users/tmtmtmtm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmtmtmtm/subscriptions","organizations_url":"https://api.github.com/users/tmtmtmtm/orgs","repos_url":"https://api.github.com/users/tmtmtmtm/repos","events_url":"https://api.github.com/users/tmtmtmtm/events{/privacy}","received_events_url":"https://api.github.com/users/tmtmtmtm/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/pulls/42/commits","review_comments_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/pulls/42/comments","review_comment_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/issues/42/comments","statuses_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/statuses/fb8f98d599f1752d19f52c1892590fe61065ddd6","head":{"label":"everypolitician:extract-git-storage-class","ref":"extract-git-storage-class","sha":"fb8f98d599f1752d19f52c1892590fe61065ddd6","user":{"login":"everypolitician","id":12497298,"avatar_url":"https://avatars.githubusercontent.com/u/12497298?v=3","gravatar_id":"","url":"https://api.github.com/users/everypolitician","html_url":"https://github.com/everypolitician","followers_url":"https://api.github.com/users/everypolitician/followers","following_url":"https://api.github.com/users/everypolitician/following{/other_user}","gists_url":"https://api.github.com/users/everypolitician/gists{/gist_id}","starred_url":"https://api.github.com/users/everypolitician/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everypolitician/subscriptions","organizations_url":"https://api.github.com/users/everypolitician/orgs","repos_url":"https://api.github.com/users/everypolitician/repos","events_url":"https://api.github.com/users/everypolitician/events{/privacy}","received_events_url":"https://api.github.com/users/everypolitician/received_events","type":"Organization","site_admin":false},"repo":{"id":63885508,"name":"scraped_page_archive","full_name":"everypolitician/scraped_page_archive","owner":{"login":"everypolitician","id":12497298,"avatar_url":"https://avatars.githubusercontent.com/u/12497298?v=3","gravatar_id":"","url":"https://api.github.com/users/everypolitician","html_url":"https://github.com/everypolitician","followers_url":"https://api.github.com/users/everypolitician/followers","following_url":"https://api.github.com/users/everypolitician/following{/other_user}","gists_url":"https://api.github.com/users/everypolitician/gists{/gist_id}","starred_url":"https://api.github.com/users/everypolitician/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everypolitician/subscriptions","organizations_url":"https://api.github.com/users/everypolitician/orgs","repos_url":"https://api.github.com/users/everypolitician/repos","events_url":"https://api.github.com/users/everypolitician/events{/privacy}","received_events_url":"https://api.github.com/users/everypolitician/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/everypolitician/scraped_page_archive","description":"Create an archive of HTML pages scraped by a Ruby scraper","fork":false,"url":"https://api.github.com/repos/everypolitician/scraped_page_archive","forks_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/forks","keys_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/teams","hooks_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/hooks","issue_events_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/issues/events{/number}","events_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/events","assignees_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/assignees{/user}","branches_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/branches{/branch}","tags_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/tags","blobs_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/git/refs{/sha}","trees_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/statuses/{sha}","languages_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/languages","stargazers_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/stargazers","contributors_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/contributors","subscribers_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/subscribers","subscription_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/subscription","commits_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/commits{/sha}","git_commits_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/git/commits{/sha}","comments_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/comments{/number}","issue_comment_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/issues/comments{/number}","contents_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/contents/{+path}","compare_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/merges","archive_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/downloads","issues_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/issues{/number}","pulls_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/pulls{/number}","milestones_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/milestones{/number}","notifications_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/labels{/name}","releases_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/releases{/id}","deployments_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/deployments","created_at":"2016-07-21T16:32:11Z","updated_at":"2016-07-28T16:52:32Z","pushed_at":"2016-09-28T09:04:53Z","git_url":"git://github.com/everypolitician/scraped_page_archive.git","ssh_url":"git@github.com:everypolitician/scraped_page_archive.git","clone_url":"https://github.com/everypolitician/scraped_page_archive.git","svn_url":"https://github.com/everypolitician/scraped_page_archive","homepage":"","size":59,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":16,"forks":0,"open_issues":16,"watchers":0,"default_branch":"master"}},"base":{"label":"everypolitician:master","ref":"master","sha":"196d5e39680db1d2873e4fcd586f2b4ff3865640","user":{"login":"everypolitician","id":12497298,"avatar_url":"https://avatars.githubusercontent.com/u/12497298?v=3","gravatar_id":"","url":"https://api.github.com/users/everypolitician","html_url":"https://github.com/everypolitician","followers_url":"https://api.github.com/users/everypolitician/followers","following_url":"https://api.github.com/users/everypolitician/following{/other_user}","gists_url":"https://api.github.com/users/everypolitician/gists{/gist_id}","starred_url":"https://api.github.com/users/everypolitician/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everypolitician/subscriptions","organizations_url":"https://api.github.com/users/everypolitician/orgs","repos_url":"https://api.github.com/users/everypolitician/repos","events_url":"https://api.github.com/users/everypolitician/events{/privacy}","received_events_url":"https://api.github.com/users/everypolitician/received_events","type":"Organization","site_admin":false},"repo":{"id":63885508,"name":"scraped_page_archive","full_name":"everypolitician/scraped_page_archive","owner":{"login":"everypolitician","id":12497298,"avatar_url":"https://avatars.githubusercontent.com/u/12497298?v=3","gravatar_id":"","url":"https://api.github.com/users/everypolitician","html_url":"https://github.com/everypolitician","followers_url":"https://api.github.com/users/everypolitician/followers","following_url":"https://api.github.com/users/everypolitician/following{/other_user}","gists_url":"https://api.github.com/users/everypolitician/gists{/gist_id}","starred_url":"https://api.github.com/users/everypolitician/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everypolitician/subscriptions","organizations_url":"https://api.github.com/users/everypolitician/orgs","repos_url":"https://api.github.com/users/everypolitician/repos","events_url":"https://api.github.com/users/everypolitician/events{/privacy}","received_events_url":"https://api.github.com/users/everypolitician/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/everypolitician/scraped_page_archive","description":"Create an archive of HTML pages scraped by a Ruby scraper","fork":false,"url":"https://api.github.com/repos/everypolitician/scraped_page_archive","forks_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/forks","keys_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/teams","hooks_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/hooks","issue_events_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/issues/events{/number}","events_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/events","assignees_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/assignees{/user}","branches_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/branches{/branch}","tags_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/tags","blobs_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/git/refs{/sha}","trees_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/statuses/{sha}","languages_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/languages","stargazers_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/stargazers","contributors_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/contributors","subscribers_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/subscribers","subscription_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/subscription","commits_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/commits{/sha}","git_commits_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/git/commits{/sha}","comments_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/comments{/number}","issue_comment_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/issues/comments{/number}","contents_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/contents/{+path}","compare_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/merges","archive_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/downloads","issues_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/issues{/number}","pulls_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/pulls{/number}","milestones_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/milestones{/number}","notifications_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/labels{/name}","releases_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/releases{/id}","deployments_url":"https://api.github.com/repos/everypolitician/scraped_page_archive/deployments","created_at":"2016-07-21T16:32:11Z","updated_at":"2016-07-28T16:52:32Z","pushed_at":"2016-09-28T09:04:53Z","git_url":"git://github.com/everypolitician/scraped_page_archive.git","ssh_url":"git@github.com:everypolitician/scraped_page_archive.git","clone_url":"https://github.com/everypolitician/scraped_page_archive.git","svn_url":"https://github.com/everypolitician/scraped_page_archive","homepage":"","size":59,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":16,"forks":0,"open_issues":16,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/everypolitician/scraped_page_archive/pulls/42"},"html":{"href":"https://github.com/everypolitician/scraped_page_archive/pull/42"},"issue":{"href":"https://api.github.com/repos/everypolitician/scraped_page_archive/issues/42"},"comments":{"href":"https://api.github.com/repos/everypolitician/scraped_page_archive/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/everypolitician/scraped_page_archive/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/everypolitician/scraped_page_archive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/everypolitician/scraped_page_archive/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/everypolitician/scraped_page_archive/statuses/fb8f98d599f1752d19f52c1892590fe61065ddd6"}}}}
{"actor":{"display_login":"chrismytton"}}