{"action":"created","issue":{"url":"https://api.github.com/repos/jongough/ocpn_draw_pi/issues/257","repository_url":"https://api.github.com/repos/jongough/ocpn_draw_pi","labels_url":"https://api.github.com/repos/jongough/ocpn_draw_pi/issues/257/labels{/name}","comments_url":"https://api.github.com/repos/jongough/ocpn_draw_pi/issues/257/comments","events_url":"https://api.github.com/repos/jongough/ocpn_draw_pi/issues/257/events","html_url":"https://github.com/jongough/ocpn_draw_pi/issues/257","id":160545103,"number":257,"title":"boundary calculation too slow for weather routing","user":{"login":"seandepagnier","id":2342579,"avatar_url":"https://avatars.githubusercontent.com/u/2342579?v=3","gravatar_id":"","url":"https://api.github.com/users/seandepagnier","html_url":"https://github.com/seandepagnier","followers_url":"https://api.github.com/users/seandepagnier/followers","following_url":"https://api.github.com/users/seandepagnier/following{/other_user}","gists_url":"https://api.github.com/users/seandepagnier/gists{/gist_id}","starred_url":"https://api.github.com/users/seandepagnier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seandepagnier/subscriptions","organizations_url":"https://api.github.com/users/seandepagnier/orgs","repos_url":"https://api.github.com/users/seandepagnier/repos","events_url":"https://api.github.com/users/seandepagnier/events{/privacy}","received_events_url":"https://api.github.com/users/seandepagnier/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-06-15T23:16:28Z","updated_at":"2016-06-17T12:46:58Z","closed_at":null,"body":"Jon,\r\n\r\nI am not sure how exactly you want to resolve this, but the current method using json messages is far too slow for practical use.\r\n\r\nFirst of all, the boundary test routine should not take a single point, but a segment, because it is currently possible for a weather route to cut across the boundary (cut the corner) as the segment end points are both outside the boundary.\r\n\r\nSecondly, I recommend using a single message to pass a function pointer for boundary segment tests.  The actual boundary segment test routine needs to hash boundaries by some kind of lat/lon grid or possibly binary tree to greatly speed the search.\r\n\r\nI am considering developing some sort of datastructure to contain lat/lon bounding box objects for log(n)  test time to consider which objects are in a certain viewport (or could apply to a segment)\r\n\r\nWhat do you want to do about it?  It would be great to have boundary support in weather routing."},"comment":{"url":"https://api.github.com/repos/jongough/ocpn_draw_pi/issues/comments/226759824","html_url":"https://github.com/jongough/ocpn_draw_pi/issues/257#issuecomment-226759824","issue_url":"https://api.github.com/repos/jongough/ocpn_draw_pi/issues/257","id":226759824,"user":{"login":"seandepagnier","id":2342579,"avatar_url":"https://avatars.githubusercontent.com/u/2342579?v=3","gravatar_id":"","url":"https://api.github.com/users/seandepagnier","html_url":"https://github.com/seandepagnier","followers_url":"https://api.github.com/users/seandepagnier/followers","following_url":"https://api.github.com/users/seandepagnier/following{/other_user}","gists_url":"https://api.github.com/users/seandepagnier/gists{/gist_id}","starred_url":"https://api.github.com/users/seandepagnier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seandepagnier/subscriptions","organizations_url":"https://api.github.com/users/seandepagnier/orgs","repos_url":"https://api.github.com/users/seandepagnier/repos","events_url":"https://api.github.com/users/seandepagnier/events{/privacy}","received_events_url":"https://api.github.com/users/seandepagnier/received_events","type":"User","site_admin":false},"created_at":"2016-06-17T12:46:58Z","updated_at":"2016-06-17T12:46:58Z","body":"I am confused by your last statement.\n\nI pass some function pointers from climatology to weather routing as\nyou can see in weather_routing_pi.cpp:260\n\nWe could simply pass the boundary test routine to weather routing via\na message storing the function pointer as a string in the json\nmessage.  Once weather routing has the function pointer it can call it\nthousands of times without all the overhead of parsing json.\n\nOn 6/17/16, jongough <notifications@github.com> wrote:\n> I am completely new at this game. I think we could do this if we could gain\n> access to the pluginmanager list of plugin addresses, but then I would need\n> to provide the API in the ocpn_plugin.h file. I am hoping that there is a\n> way to use functions from another DLL without having to load the DLL again\n> AND be able to access its functions. But I am struggling a bit here, so any\n> idea how to do it.\n>\n> I don't particularly like the idea of passing function addresses in pointers\n> when they are not in the same executable.\n>\n> ---\n> You are receiving this because you authored the thread.\n> Reply to this email directly or view it on GitHub:\n> https://github.com/jongough/ocpn_draw_pi/issues/257#issuecomment-226702335\n"}}
{"actor":{"display_login":"seandepagnier"}}