{"action":"created","comment":{"url":"https://api.github.com/repos/HOST-Oman/scribus/pulls/comments/60895900","id":60895900,"diff_hunk":"@@ -2178,6 +2178,12 @@ void PageItem_TextFrame::layout()\n \t\t\t// remember possible break\n \t\t\tif (i + 1 < glyphRuns.count() && glyphRuns[i + 1].hasFlag(ScLayout_LineBoundry))\n \t\t\t{\n+\n+\t\t\t\tif( current.glyphs.length() > 1 && (current.glyphs[currentIndex -1].lastChar() != SpecialChars::CJK_NOBREAK_AFTER) &&","path":"scribus/pageitem_textframe.cpp","position":5,"original_position":5,"commit_id":"bd4f5ef5caf8cb0eb817de91ba70eb4177d1cb63","original_commit_id":"bd4f5ef5caf8cb0eb817de91ba70eb4177d1cb63","user":{"login":"khaledhosny","id":93914,"avatar_url":"https://avatars.githubusercontent.com/u/93914?v=3","gravatar_id":"","url":"https://api.github.com/users/khaledhosny","html_url":"https://github.com/khaledhosny","followers_url":"https://api.github.com/users/khaledhosny/followers","following_url":"https://api.github.com/users/khaledhosny/following{/other_user}","gists_url":"https://api.github.com/users/khaledhosny/gists{/gist_id}","starred_url":"https://api.github.com/users/khaledhosny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khaledhosny/subscriptions","organizations_url":"https://api.github.com/users/khaledhosny/orgs","repos_url":"https://api.github.com/users/khaledhosny/repos","events_url":"https://api.github.com/users/khaledhosny/events{/privacy}","received_events_url":"https://api.github.com/users/khaledhosny/received_events","type":"User","site_admin":false},"body":"The space should be before the opening bracket, also there should be spaces around both sides of the minus operator.","created_at":"2016-04-25T10:59:44Z","updated_at":"2016-04-25T10:59:44Z","html_url":"https://github.com/HOST-Oman/scribus/pull/162#discussion_r60895900","pull_request_url":"https://api.github.com/repos/HOST-Oman/scribus/pulls/162","_links":{"self":{"href":"https://api.github.com/repos/HOST-Oman/scribus/pulls/comments/60895900"},"html":{"href":"https://github.com/HOST-Oman/scribus/pull/162#discussion_r60895900"},"pull_request":{"href":"https://api.github.com/repos/HOST-Oman/scribus/pulls/162"}}},"pull_request":{"url":"https://api.github.com/repos/HOST-Oman/scribus/pulls/162","id":67671986,"html_url":"https://github.com/HOST-Oman/scribus/pull/162","diff_url":"https://github.com/HOST-Oman/scribus/pull/162.diff","patch_url":"https://github.com/HOST-Oman/scribus/pull/162.patch","issue_url":"https://api.github.com/repos/HOST-Oman/scribus/issues/162","number":162,"state":"open","locked":false,"title":"Fix CJK line Breaking","user":{"login":"Fahad-Alsaidi","id":1632566,"avatar_url":"https://avatars.githubusercontent.com/u/1632566?v=3","gravatar_id":"","url":"https://api.github.com/users/Fahad-Alsaidi","html_url":"https://github.com/Fahad-Alsaidi","followers_url":"https://api.github.com/users/Fahad-Alsaidi/followers","following_url":"https://api.github.com/users/Fahad-Alsaidi/following{/other_user}","gists_url":"https://api.github.com/users/Fahad-Alsaidi/gists{/gist_id}","starred_url":"https://api.github.com/users/Fahad-Alsaidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fahad-Alsaidi/subscriptions","organizations_url":"https://api.github.com/users/Fahad-Alsaidi/orgs","repos_url":"https://api.github.com/users/Fahad-Alsaidi/repos","events_url":"https://api.github.com/users/Fahad-Alsaidi/events{/privacy}","received_events_url":"https://api.github.com/users/Fahad-Alsaidi/received_events","type":"User","site_admin":false},"body":"This mimic the old stlye in line breaking though we should find a better solution for line breaking in general.\r\n","created_at":"2016-04-25T06:42:04Z","updated_at":"2016-04-25T10:59:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3419e9ba82cc99f3a24d2eafbc5e4fc78b3fcf6e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HOST-Oman/scribus/pulls/162/commits","review_comments_url":"https://api.github.com/repos/HOST-Oman/scribus/pulls/162/comments","review_comment_url":"https://api.github.com/repos/HOST-Oman/scribus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HOST-Oman/scribus/issues/162/comments","statuses_url":"https://api.github.com/repos/HOST-Oman/scribus/statuses/bd4f5ef5caf8cb0eb817de91ba70eb4177d1cb63","head":{"label":"Fahad-Alsaidi:cjkLineBreak","ref":"cjkLineBreak","sha":"bd4f5ef5caf8cb0eb817de91ba70eb4177d1cb63","user":{"login":"Fahad-Alsaidi","id":1632566,"avatar_url":"https://avatars.githubusercontent.com/u/1632566?v=3","gravatar_id":"","url":"https://api.github.com/users/Fahad-Alsaidi","html_url":"https://github.com/Fahad-Alsaidi","followers_url":"https://api.github.com/users/Fahad-Alsaidi/followers","following_url":"https://api.github.com/users/Fahad-Alsaidi/following{/other_user}","gists_url":"https://api.github.com/users/Fahad-Alsaidi/gists{/gist_id}","starred_url":"https://api.github.com/users/Fahad-Alsaidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fahad-Alsaidi/subscriptions","organizations_url":"https://api.github.com/users/Fahad-Alsaidi/orgs","repos_url":"https://api.github.com/users/Fahad-Alsaidi/repos","events_url":"https://api.github.com/users/Fahad-Alsaidi/events{/privacy}","received_events_url":"https://api.github.com/users/Fahad-Alsaidi/received_events","type":"User","site_admin":false},"repo":{"id":54864217,"name":"scribus","full_name":"Fahad-Alsaidi/scribus","owner":{"login":"Fahad-Alsaidi","id":1632566,"avatar_url":"https://avatars.githubusercontent.com/u/1632566?v=3","gravatar_id":"","url":"https://api.github.com/users/Fahad-Alsaidi","html_url":"https://github.com/Fahad-Alsaidi","followers_url":"https://api.github.com/users/Fahad-Alsaidi/followers","following_url":"https://api.github.com/users/Fahad-Alsaidi/following{/other_user}","gists_url":"https://api.github.com/users/Fahad-Alsaidi/gists{/gist_id}","starred_url":"https://api.github.com/users/Fahad-Alsaidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fahad-Alsaidi/subscriptions","organizations_url":"https://api.github.com/users/Fahad-Alsaidi/orgs","repos_url":"https://api.github.com/users/Fahad-Alsaidi/repos","events_url":"https://api.github.com/users/Fahad-Alsaidi/events{/privacy}","received_events_url":"https://api.github.com/users/Fahad-Alsaidi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fahad-Alsaidi/scribus","description":"Mirror of official Scribus SVN (http://bugs.scribus.net ← Submit PRs & Bugs)","fork":true,"url":"https://api.github.com/repos/Fahad-Alsaidi/scribus","forks_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/forks","keys_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/teams","hooks_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/hooks","issue_events_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/issues/events{/number}","events_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/events","assignees_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/assignees{/user}","branches_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/branches{/branch}","tags_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/tags","blobs_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/statuses/{sha}","languages_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/languages","stargazers_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/stargazers","contributors_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/contributors","subscribers_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/subscribers","subscription_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/subscription","commits_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/contents/{+path}","compare_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/merges","archive_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/downloads","issues_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/issues{/number}","pulls_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/pulls{/number}","milestones_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/milestones{/number}","notifications_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/labels{/name}","releases_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/releases{/id}","deployments_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/deployments","created_at":"2016-03-28T03:58:38Z","updated_at":"2016-03-28T03:58:48Z","pushed_at":"2016-04-25T10:45:14Z","git_url":"git://github.com/Fahad-Alsaidi/scribus.git","ssh_url":"git@github.com:Fahad-Alsaidi/scribus.git","clone_url":"https://github.com/Fahad-Alsaidi/scribus.git","svn_url":"https://github.com/Fahad-Alsaidi/scribus","homepage":"http://scribus.io","size":437952,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HOST-Oman:ctl","ref":"ctl","sha":"9214aa52ad3bcb61175aa9e720fca0d2221d907d","user":{"login":"HOST-Oman","id":16079338,"avatar_url":"https://avatars.githubusercontent.com/u/16079338?v=3","gravatar_id":"","url":"https://api.github.com/users/HOST-Oman","html_url":"https://github.com/HOST-Oman","followers_url":"https://api.github.com/users/HOST-Oman/followers","following_url":"https://api.github.com/users/HOST-Oman/following{/other_user}","gists_url":"https://api.github.com/users/HOST-Oman/gists{/gist_id}","starred_url":"https://api.github.com/users/HOST-Oman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HOST-Oman/subscriptions","organizations_url":"https://api.github.com/users/HOST-Oman/orgs","repos_url":"https://api.github.com/users/HOST-Oman/repos","events_url":"https://api.github.com/users/HOST-Oman/events{/privacy}","received_events_url":"https://api.github.com/users/HOST-Oman/received_events","type":"Organization","site_admin":false},"repo":{"id":52158961,"name":"scribus","full_name":"HOST-Oman/scribus","owner":{"login":"HOST-Oman","id":16079338,"avatar_url":"https://avatars.githubusercontent.com/u/16079338?v=3","gravatar_id":"","url":"https://api.github.com/users/HOST-Oman","html_url":"https://github.com/HOST-Oman","followers_url":"https://api.github.com/users/HOST-Oman/followers","following_url":"https://api.github.com/users/HOST-Oman/following{/other_user}","gists_url":"https://api.github.com/users/HOST-Oman/gists{/gist_id}","starred_url":"https://api.github.com/users/HOST-Oman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HOST-Oman/subscriptions","organizations_url":"https://api.github.com/users/HOST-Oman/orgs","repos_url":"https://api.github.com/users/HOST-Oman/repos","events_url":"https://api.github.com/users/HOST-Oman/events{/privacy}","received_events_url":"https://api.github.com/users/HOST-Oman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HOST-Oman/scribus","description":"Mirror of official Scribus SVN (http://bugs.scribus.net ← Submit PRs & Bugs)","fork":true,"url":"https://api.github.com/repos/HOST-Oman/scribus","forks_url":"https://api.github.com/repos/HOST-Oman/scribus/forks","keys_url":"https://api.github.com/repos/HOST-Oman/scribus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HOST-Oman/scribus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HOST-Oman/scribus/teams","hooks_url":"https://api.github.com/repos/HOST-Oman/scribus/hooks","issue_events_url":"https://api.github.com/repos/HOST-Oman/scribus/issues/events{/number}","events_url":"https://api.github.com/repos/HOST-Oman/scribus/events","assignees_url":"https://api.github.com/repos/HOST-Oman/scribus/assignees{/user}","branches_url":"https://api.github.com/repos/HOST-Oman/scribus/branches{/branch}","tags_url":"https://api.github.com/repos/HOST-Oman/scribus/tags","blobs_url":"https://api.github.com/repos/HOST-Oman/scribus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HOST-Oman/scribus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HOST-Oman/scribus/git/refs{/sha}","trees_url":"https://api.github.com/repos/HOST-Oman/scribus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HOST-Oman/scribus/statuses/{sha}","languages_url":"https://api.github.com/repos/HOST-Oman/scribus/languages","stargazers_url":"https://api.github.com/repos/HOST-Oman/scribus/stargazers","contributors_url":"https://api.github.com/repos/HOST-Oman/scribus/contributors","subscribers_url":"https://api.github.com/repos/HOST-Oman/scribus/subscribers","subscription_url":"https://api.github.com/repos/HOST-Oman/scribus/subscription","commits_url":"https://api.github.com/repos/HOST-Oman/scribus/commits{/sha}","git_commits_url":"https://api.github.com/repos/HOST-Oman/scribus/git/commits{/sha}","comments_url":"https://api.github.com/repos/HOST-Oman/scribus/comments{/number}","issue_comment_url":"https://api.github.com/repos/HOST-Oman/scribus/issues/comments{/number}","contents_url":"https://api.github.com/repos/HOST-Oman/scribus/contents/{+path}","compare_url":"https://api.github.com/repos/HOST-Oman/scribus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HOST-Oman/scribus/merges","archive_url":"https://api.github.com/repos/HOST-Oman/scribus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HOST-Oman/scribus/downloads","issues_url":"https://api.github.com/repos/HOST-Oman/scribus/issues{/number}","pulls_url":"https://api.github.com/repos/HOST-Oman/scribus/pulls{/number}","milestones_url":"https://api.github.com/repos/HOST-Oman/scribus/milestones{/number}","notifications_url":"https://api.github.com/repos/HOST-Oman/scribus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HOST-Oman/scribus/labels{/name}","releases_url":"https://api.github.com/repos/HOST-Oman/scribus/releases{/id}","deployments_url":"https://api.github.com/repos/HOST-Oman/scribus/deployments","created_at":"2016-02-20T15:05:04Z","updated_at":"2016-04-17T13:41:15Z","pushed_at":"2016-04-25T10:45:15Z","git_url":"git://github.com/HOST-Oman/scribus.git","ssh_url":"git@github.com:HOST-Oman/scribus.git","clone_url":"https://github.com/HOST-Oman/scribus.git","svn_url":"https://github.com/HOST-Oman/scribus","homepage":"http://scribus.io","size":438497,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":24,"forks":8,"open_issues":24,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HOST-Oman/scribus/pulls/162"},"html":{"href":"https://github.com/HOST-Oman/scribus/pull/162"},"issue":{"href":"https://api.github.com/repos/HOST-Oman/scribus/issues/162"},"comments":{"href":"https://api.github.com/repos/HOST-Oman/scribus/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/HOST-Oman/scribus/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/HOST-Oman/scribus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HOST-Oman/scribus/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/HOST-Oman/scribus/statuses/bd4f5ef5caf8cb0eb817de91ba70eb4177d1cb63"}}}}