{"action":"created","issue":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2318","repository_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto","labels_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2318/labels{/name}","comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2318/comments","events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2318/events","html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2318","id":174134492,"number":2318,"title":"remove citywall inconsistencies and new style for city walls","user":{"login":"nebulon42","id":3531092,"avatar_url":"https://avatars.githubusercontent.com/u/3531092?v=3","gravatar_id":"","url":"https://api.github.com/users/nebulon42","html_url":"https://github.com/nebulon42","followers_url":"https://api.github.com/users/nebulon42/followers","following_url":"https://api.github.com/users/nebulon42/following{/other_user}","gists_url":"https://api.github.com/users/nebulon42/gists{/gist_id}","starred_url":"https://api.github.com/users/nebulon42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nebulon42/subscriptions","organizations_url":"https://api.github.com/users/nebulon42/orgs","repos_url":"https://api.github.com/users/nebulon42/repos","events_url":"https://api.github.com/users/nebulon42/events{/privacy}","received_events_url":"https://api.github.com/users/nebulon42/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-30T21:47:56Z","updated_at":"2016-09-02T06:40:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/2318","html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2318","diff_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2318.diff","patch_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2318.patch"},"body":"Fixes #1333.\r\n\r\nRemoves the extra citywalls layer and moves `historic=citywalls` to line barrier logic. Unifies `barrier=city_wall` and `historic=citywalls` rendering. Because of the special meaning the rendering is a bit more intense than normal walls.\r\n\r\nz14\r\n![z14](https://cloud.githubusercontent.com/assets/3531092/18108316/fc827c38-6f0b-11e6-9bf1-20ef5782a1c8.png)\r\n\r\nz15\r\n![z15](https://cloud.githubusercontent.com/assets/3531092/18108318/fec3cac4-6f0b-11e6-9524-a5b73eb7360d.png)\r\n\r\nz16\r\n![z16](https://cloud.githubusercontent.com/assets/3531092/18108321/01837cb4-6f0c-11e6-9073-a093a64d7a9c.png)\r\n\r\nz17\r\n![z17](https://cloud.githubusercontent.com/assets/3531092/18108324/041f3a58-6f0c-11e6-8074-76443ebf1623.png)\r\n\r\nz18\r\n![z18](https://cloud.githubusercontent.com/assets/3531092/18108327/06f8b600-6f0c-11e6-8971-0edaf674f4b6.png)"},"comment":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/comments/244295558","html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2318#issuecomment-244295558","issue_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2318","id":244295558,"user":{"login":"mboeringa","id":7635726,"avatar_url":"https://avatars.githubusercontent.com/u/7635726?v=3","gravatar_id":"","url":"https://api.github.com/users/mboeringa","html_url":"https://github.com/mboeringa","followers_url":"https://api.github.com/users/mboeringa/followers","following_url":"https://api.github.com/users/mboeringa/following{/other_user}","gists_url":"https://api.github.com/users/mboeringa/gists{/gist_id}","starred_url":"https://api.github.com/users/mboeringa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboeringa/subscriptions","organizations_url":"https://api.github.com/users/mboeringa/orgs","repos_url":"https://api.github.com/users/mboeringa/repos","events_url":"https://api.github.com/users/mboeringa/events{/privacy}","received_events_url":"https://api.github.com/users/mboeringa/received_events","type":"User","site_admin":false},"created_at":"2016-09-02T06:40:02Z","updated_at":"2016-09-02T06:40:02Z","body":"> To me the new rendering is a significant improvement.\r\n\r\nRome is also in a sense a \"worst-case\" example. It is one of the few cities that have roads running directly along the base of the city walls for a significant length. This doesn't happen often, and visibility in most cases should be much better. It was also with Rome in mind, that I suggested to consider putting city walls \"on top\" of roads, instead of rendering them below (but it will mean any \"highway=footway\" tagged on top of the wall, will become invisible - unless it would be possible to only render city walls on top of highway=footway with layer <= 0, which I think based on all I read here in the carto repo, is not feasible)"}}
{"actor":{"display_login":"mboeringa"}}