{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/16536","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16536/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16536/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16536/events","html_url":"https://github.com/cms-sw/cmssw/pull/16536","id":188310420,"number":16536,"title":"Gem and me0 segment bug fix 81x","user":{"login":"jshlee","id":5427173,"avatar_url":"https://avatars.githubusercontent.com/u/5427173?v=3","gravatar_id":"","url":"https://api.github.com/users/jshlee","html_url":"https://github.com/jshlee","followers_url":"https://api.github.com/users/jshlee/followers","following_url":"https://api.github.com/users/jshlee/following{/other_user}","gists_url":"https://api.github.com/users/jshlee/gists{/gist_id}","starred_url":"https://api.github.com/users/jshlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jshlee/subscriptions","organizations_url":"https://api.github.com/users/jshlee/orgs","repos_url":"https://api.github.com/users/jshlee/repos","events_url":"https://api.github.com/users/jshlee/events{/privacy}","received_events_url":"https://api.github.com/users/jshlee/received_events","type":"User","site_admin":false},"labels":[{"id":88653795,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":52820549,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-pending","name":"dqm-pending","color":"fbca04","default":false},{"id":52881721,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/geometry-pending","name":"geometry-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":52820523,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04","default":false},{"id":56131152,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":53,"closed_issues":1936,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-11-17T11:47:13Z","due_on":"2016-11-26T00:00:00Z","closed_at":null},"comments":41,"created_at":"2016-11-09T17:51:20Z","updated_at":"2016-11-17T13:21:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/16536","html_url":"https://github.com/cms-sw/cmssw/pull/16536","diff_url":"https://github.com/cms-sw/cmssw/pull/16536.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/16536.patch"},"body":"ME0Segments changed reference detector from etaPartition to chamber\r\n* ME0SegmentAlgorithm.cc - changed ME0EtaPartition -> ME0Chamber, bug fix for failed fits\r\n* ME0SegmentAlgorithmBase.h - changed ME0EtaPartition -> ME0Chamber\r\n* ME0SegmentBuilder.cc  - changed ME0EtaPartition -> ME0Chamber\r\n* ME0SegmentMatcher.cc - changed ME0EtaPartition -> ME0Chamber\r\n* ME0SegmentsValidation.cc - changed ME0EtaPartition -> ME0Chamber\r\n\r\nmuonME0DigisPreReco_cfi.py - etaResolution was set to 0, this gave me0RecHits 0 for y error, which made ME0Segment fitting fail.\r\n\r\nMuonSegFit - increased number of hits that can be fitted\r\n\r\nMuonGEMDetLayerGeometryBuilder.cc added chamber\r\nMuonME0DetLayerGeometryBuilder.cc added chamber\r\n\r\nGEMSegment.h and ME0Segment.h to use chamberID\r\n\r\nfix ME0Geometry.cc layer and chamber functions\r\n\r\nclean up GEMSegmentBuilder.cc\r\n\r\nMuonTrackLoader.cc added the case for gemSegments\r\n\r\n@calabria @kpedro88 @pietverwilligen @archiesharma @dildick "},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/261244778","html_url":"https://github.com/cms-sw/cmssw/pull/16536#issuecomment-261244778","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/16536","id":261244778,"user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T13:21:51Z","updated_at":"2016-11-17T13:21:51Z","body":"On 11/17/16 2:19 AM, Jason Lee wrote:\n> @slava77 <https://github.com/slava77>\n> The \"ME0s are sorted\" was a testing msg. should have been removed before.\n\nnice\n\n> \n> The ME0 errors are set to really small so that it can be redigi later to\n> study granularity.\n\nPlease describe how this is going to work\n(maybe a sketch of a workflow).\nWhich inputs will you need for that (can it work from AOD?)\n\nIMHO, the current default high level objects (at least segments, but\nmaybe even starting with hits) should have the realistic current resolution.\n\n\n> \n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/cms-sw/cmssw/pull/16536#issuecomment-261209188>, or\n> mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AEdcbpoqhrtaaqyad-HhED8RXMS6vNLvks5q_Co1gaJpZM4Ktzdl>.\n> \n\n"}}
{"actor":{"display_login":"slava77"}}