{"action":"created","issue":{"url":"https://api.github.com/repos/kangax/fabric.js/issues/3261","repository_url":"https://api.github.com/repos/kangax/fabric.js","labels_url":"https://api.github.com/repos/kangax/fabric.js/issues/3261/labels{/name}","comments_url":"https://api.github.com/repos/kangax/fabric.js/issues/3261/comments","events_url":"https://api.github.com/repos/kangax/fabric.js/issues/3261/events","html_url":"https://github.com/kangax/fabric.js/issues/3261","id":176898108,"number":3261,"title":"Incompatibility in 1.6.4 with Text.fontFamily","user":{"login":"awehring","id":13434187,"avatar_url":"https://avatars.githubusercontent.com/u/13434187?v=3","gravatar_id":"","url":"https://api.github.com/users/awehring","html_url":"https://github.com/awehring","followers_url":"https://api.github.com/users/awehring/followers","following_url":"https://api.github.com/users/awehring/following{/other_user}","gists_url":"https://api.github.com/users/awehring/gists{/gist_id}","starred_url":"https://api.github.com/users/awehring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awehring/subscriptions","organizations_url":"https://api.github.com/users/awehring/orgs","repos_url":"https://api.github.com/users/awehring/repos","events_url":"https://api.github.com/users/awehring/events{/privacy}","received_events_url":"https://api.github.com/users/awehring/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-14T12:47:20Z","updated_at":"2016-09-14T12:52:12Z","closed_at":null,"body":"There is an incompatibility between version 1.6.3 and 1.6.4 with `Text` / `IText` `fontFamily`.\r\n\r\nUp to version 1.6.3 the fontFamily could be defined like `\"'Courier New', Courier, monospace\"`.\r\nWith version 1.6.4 this definition is ignored (the displayed font defaults to `Times New Roman`).\r\n\r\nThe problem seems to be related with the ' (single quotes) within the \" (double quote) string.\r\nThis issue might be introduced with #3191 - Fix: Quote font family when setting the context fontstyle.\r\n\r\n## Version\r\n1.6.4\r\n\r\n## Test Case\r\n```\r\nvar text = new fabric.Text('Hello world', {\r\n // Font works with 1.6.3 but not 1.6.4\r\n fontFamily: \"'Courier New', Courier, monospace\",  \r\n fontSize: 30,\r\n left: 100,\r\n top: 100,\r\n fill: 'red'\r\n });\r\n canvas.add(text);\r\n```\r\nhttp://jsfiddle.net/awehring/Da7SP/179/\r\n\r\n## Steps to reproduce\r\nRun the testcase, which is linked to fabric.js version 1.6.4. Gives wrong result.\r\nChange fabric.js version to 1.6.3 (https://cdn.rawgit.com/kangax/fabric.js/1.6.3/dist/fabric.min.js). Gives correct result.\r\n\r\n## Expected Behavior\r\nIn version 1.6.4 and 1.6.3: Shows \"Hello World\" in **Courier New** font.\r\n\r\n## Actual Behavior\r\nIn version 1.6.4: Shows \"Hello World\" in **Times New Roman** font (wrong).\r\nIn version 1.6.3: Shows \"Hello World\" in **Courier New** font (correct).\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/kangax/fabric.js/issues/comments/247002823","html_url":"https://github.com/kangax/fabric.js/issues/3261#issuecomment-247002823","issue_url":"https://api.github.com/repos/kangax/fabric.js/issues/3261","id":247002823,"user":{"login":"asturur","id":1194048,"avatar_url":"https://avatars.githubusercontent.com/u/1194048?v=3","gravatar_id":"","url":"https://api.github.com/users/asturur","html_url":"https://github.com/asturur","followers_url":"https://api.github.com/users/asturur/followers","following_url":"https://api.github.com/users/asturur/following{/other_user}","gists_url":"https://api.github.com/users/asturur/gists{/gist_id}","starred_url":"https://api.github.com/users/asturur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asturur/subscriptions","organizations_url":"https://api.github.com/users/asturur/orgs","repos_url":"https://api.github.com/users/asturur/repos","events_url":"https://api.github.com/users/asturur/events{/privacy}","received_events_url":"https://api.github.com/users/asturur/received_events","type":"User","site_admin":false},"created_at":"2016-09-14T12:52:12Z","updated_at":"2016-09-14T12:52:12Z","body":"well.\r\nI guess users have to properly quote theyr fonts then.\r\nI ll give it a looks.\r\nUsing the quotes was introduced to fix fontnames like 'Slabo 27px'"}}
{"actor":{"display_login":"asturur"}}