{"action":"created","comment":{"url":"https://api.github.com/repos/LLNL/spack/pulls/comments/76690783","id":76690783,"diff_hunk":"@@ -12,30 +36,97 @@ class Adios(Package):\n     \"\"\"\n \n     homepage = \"http://www.olcf.ornl.gov/center-projects/adios/\"\n-    url = \"https://github.com/ornladios/ADIOS/archive/v1.9.0.tar.gz\"\n+    url      = \"https://github.com/ornladios/ADIOS/archive/v1.10.0.tar.gz\"\n+\n+    # make -j is currently broken\n+    parallel = False\n+\n+    version('1.10.0', 'eff450a4c0130479417cfd63186957f3')\n+    version('1.9.0' , '310ff02388bbaa2b1c1710ee970b5678')\n+\n+    variant('shared', default=True,\n+            description='Builds a shared version of the library')\n \n-    version('1.9.0', '310ff02388bbaa2b1c1710ee970b5678')\n+    variant('fortran', default=True,\n+            description='Enable Fortran bindings support')\n+\n+    variant('mpi', default=False, description='Enable MPI support')","path":"var/spack/repos/builtin/packages/adios/package.py","position":52,"original_position":52,"commit_id":"b33777fd2f7eb377727cead7f38ccdf63cd3a71d","original_commit_id":"b33777fd2f7eb377727cead7f38ccdf63cd3a71d","user":{"login":"davydden","id":8023934,"avatar_url":"https://avatars.githubusercontent.com/u/8023934?v=3","gravatar_id":"","url":"https://api.github.com/users/davydden","html_url":"https://github.com/davydden","followers_url":"https://api.github.com/users/davydden/followers","following_url":"https://api.github.com/users/davydden/following{/other_user}","gists_url":"https://api.github.com/users/davydden/gists{/gist_id}","starred_url":"https://api.github.com/users/davydden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davydden/subscriptions","organizations_url":"https://api.github.com/users/davydden/orgs","repos_url":"https://api.github.com/users/davydden/repos","events_url":"https://api.github.com/users/davydden/events{/privacy}","received_events_url":"https://api.github.com/users/davydden/received_events","type":"User","site_admin":false},"body":"yeap, at the end of the day it's a S(upercomputer)Packaging software, so i would say `mpi` should be enabled by default. Although IIRC currently there is no consensus on that within Spack.","created_at":"2016-08-29T21:27:20Z","updated_at":"2016-08-29T21:27:20Z","html_url":"https://github.com/LLNL/spack/pull/1652#discussion_r76690783","pull_request_url":"https://api.github.com/repos/LLNL/spack/pulls/1652","_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments/76690783"},"html":{"href":"https://github.com/LLNL/spack/pull/1652#discussion_r76690783"},"pull_request":{"href":"https://api.github.com/repos/LLNL/spack/pulls/1652"}}},"pull_request":{"url":"https://api.github.com/repos/LLNL/spack/pulls/1652","id":83114638,"html_url":"https://github.com/LLNL/spack/pull/1652","diff_url":"https://github.com/LLNL/spack/pull/1652.diff","patch_url":"https://github.com/LLNL/spack/pull/1652.patch","issue_url":"https://api.github.com/repos/LLNL/spack/issues/1652","number":1652,"state":"open","locked":false,"title":"Update ADIOS Package","user":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"body":"This PR updates the ADIOS package.\r\n\r\n**Changes:**\r\n\r\n- add latest stable release `1.10.0`\r\n- add previous versions (hashes)\r\n- add default license header\r\n- add build options (shamelessly taken from HDF5 package)\r\n- add validation for excisting FC (as in HDF5) and make optional\r\n- handle mxml dependency correctly (not required in 1.10.0+)\r\n- add `CFLAGS=-fPIC` to build shared (python) libs in ADIOS' lib\r\n- remove `-DMPICH_IGNORE_CXX_SEEK` since it is ~~normally~~ afaik not required\r\n- remove `MPICC/CXX/FC` since `--with-mpi` just performs well\r\n- add transforms:\r\n  - `zlib`: useful (optional) default\r\n  - `szip`: optional (compile often broken)\r\n- add transports that are not as performant as the `.bp` format:\r\n  - `hdf5`: non-default\r\n  - `netcdf`: non-default, close #1610","created_at":"2016-08-29T15:08:08Z","updated_at":"2016-08-29T21:27:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e519f99885b4cebee95296fc4fae40a27f8a6bac","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/spack/pulls/1652/commits","review_comments_url":"https://api.github.com/repos/LLNL/spack/pulls/1652/comments","review_comment_url":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/1652/comments","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/b33777fd2f7eb377727cead7f38ccdf63cd3a71d","head":{"label":"ax3l:topic-updateAdios110","ref":"topic-updateAdios110","sha":"b33777fd2f7eb377727cead7f38ccdf63cd3a71d","user":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"repo":{"id":66849594,"name":"spack","full_name":"ax3l/spack","owner":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ax3l/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":true,"url":"https://api.github.com/repos/ax3l/spack","forks_url":"https://api.github.com/repos/ax3l/spack/forks","keys_url":"https://api.github.com/repos/ax3l/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ax3l/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ax3l/spack/teams","hooks_url":"https://api.github.com/repos/ax3l/spack/hooks","issue_events_url":"https://api.github.com/repos/ax3l/spack/issues/events{/number}","events_url":"https://api.github.com/repos/ax3l/spack/events","assignees_url":"https://api.github.com/repos/ax3l/spack/assignees{/user}","branches_url":"https://api.github.com/repos/ax3l/spack/branches{/branch}","tags_url":"https://api.github.com/repos/ax3l/spack/tags","blobs_url":"https://api.github.com/repos/ax3l/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ax3l/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ax3l/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/ax3l/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ax3l/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/ax3l/spack/languages","stargazers_url":"https://api.github.com/repos/ax3l/spack/stargazers","contributors_url":"https://api.github.com/repos/ax3l/spack/contributors","subscribers_url":"https://api.github.com/repos/ax3l/spack/subscribers","subscription_url":"https://api.github.com/repos/ax3l/spack/subscription","commits_url":"https://api.github.com/repos/ax3l/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/ax3l/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/ax3l/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/ax3l/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/ax3l/spack/contents/{+path}","compare_url":"https://api.github.com/repos/ax3l/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ax3l/spack/merges","archive_url":"https://api.github.com/repos/ax3l/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ax3l/spack/downloads","issues_url":"https://api.github.com/repos/ax3l/spack/issues{/number}","pulls_url":"https://api.github.com/repos/ax3l/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/ax3l/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/ax3l/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ax3l/spack/labels{/name}","releases_url":"https://api.github.com/repos/ax3l/spack/releases{/id}","deployments_url":"https://api.github.com/repos/ax3l/spack/deployments","created_at":"2016-08-29T14:12:01Z","updated_at":"2016-08-29T14:12:05Z","pushed_at":"2016-08-29T21:18:52Z","git_url":"git://github.com/ax3l/spack.git","ssh_url":"git@github.com:ax3l/spack.git","clone_url":"https://github.com/ax3l/spack.git","svn_url":"https://github.com/ax3l/spack","homepage":"http://software.llnl.gov/spack","size":10508,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"LLNL:develop","ref":"develop","sha":"31cab4bae2e9a0a868a972bfe6ebffce713975cc","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"LLNL/spack","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/LLNL/spack","forks_url":"https://api.github.com/repos/LLNL/spack/forks","keys_url":"https://api.github.com/repos/LLNL/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/spack/teams","hooks_url":"https://api.github.com/repos/LLNL/spack/hooks","issue_events_url":"https://api.github.com/repos/LLNL/spack/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/spack/events","assignees_url":"https://api.github.com/repos/LLNL/spack/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/spack/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/spack/tags","blobs_url":"https://api.github.com/repos/LLNL/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/spack/languages","stargazers_url":"https://api.github.com/repos/LLNL/spack/stargazers","contributors_url":"https://api.github.com/repos/LLNL/spack/contributors","subscribers_url":"https://api.github.com/repos/LLNL/spack/subscribers","subscription_url":"https://api.github.com/repos/LLNL/spack/subscription","commits_url":"https://api.github.com/repos/LLNL/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/spack/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/spack/merges","archive_url":"https://api.github.com/repos/LLNL/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/spack/downloads","issues_url":"https://api.github.com/repos/LLNL/spack/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/spack/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/spack/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2016-08-29T13:38:34Z","pushed_at":"2016-08-29T21:23:35Z","git_url":"git://github.com/LLNL/spack.git","ssh_url":"git@github.com:LLNL/spack.git","clone_url":"https://github.com/LLNL/spack.git","svn_url":"https://github.com/LLNL/spack","homepage":"http://software.llnl.gov/spack","size":18856,"stargazers_count":148,"watchers_count":148,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":133,"mirror_url":null,"open_issues_count":332,"forks":133,"open_issues":332,"watchers":148,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/1652"},"html":{"href":"https://github.com/LLNL/spack/pull/1652"},"issue":{"href":"https://api.github.com/repos/LLNL/spack/issues/1652"},"comments":{"href":"https://api.github.com/repos/LLNL/spack/issues/1652/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/spack/pulls/1652/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/spack/pulls/1652/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/spack/statuses/b33777fd2f7eb377727cead7f38ccdf63cd3a71d"}}}}
{"actor":{"display_login":"davydden"}}