{"action":"created","comment":{"url":"https://api.github.com/repos/juttle/juttle-viz/pulls/comments/50500720","id":50500720,"diff_hunk":"@@ -141,6 +141,16 @@ var EventsView = JuttleView.extend({\n         this.target.stream_end();\n     },\n \n+    _validateTimeField : function(time) {\n+        // if in timechart overlay, timeField needs to actually be a Date\n+        if (this._targetView) {\n+            return _.isDate(time) && !_.isNaN(time.getTime());","path":"src/views/events.js","position":7,"original_position":7,"commit_id":"0e8548d3c41be09d39734c4038e17469ba62cfc8","original_commit_id":"0e8548d3c41be09d39734c4038e17469ba62cfc8","user":{"login":"rlgomes","id":107359,"avatar_url":"https://avatars.githubusercontent.com/u/107359?v=3","gravatar_id":"","url":"https://api.github.com/users/rlgomes","html_url":"https://github.com/rlgomes","followers_url":"https://api.github.com/users/rlgomes/followers","following_url":"https://api.github.com/users/rlgomes/following{/other_user}","gists_url":"https://api.github.com/users/rlgomes/gists{/gist_id}","starred_url":"https://api.github.com/users/rlgomes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlgomes/subscriptions","organizations_url":"https://api.github.com/users/rlgomes/orgs","repos_url":"https://api.github.com/users/rlgomes/repos","events_url":"https://api.github.com/users/rlgomes/events{/privacy}","received_events_url":"https://api.github.com/users/rlgomes/received_events","type":"User","site_admin":false},"body":"If I learned anything from @davidvgalbraith is that checking for NaN the quickest and easiest way is done with `X === X` ","created_at":"2016-01-22T04:16:01Z","updated_at":"2016-01-22T04:16:01Z","html_url":"https://github.com/juttle/juttle-viz/pull/32#discussion_r50500720","pull_request_url":"https://api.github.com/repos/juttle/juttle-viz/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/juttle/juttle-viz/pulls/comments/50500720"},"html":{"href":"https://github.com/juttle/juttle-viz/pull/32#discussion_r50500720"},"pull_request":{"href":"https://api.github.com/repos/juttle/juttle-viz/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/juttle/juttle-viz/pulls/32","id":56844681,"html_url":"https://github.com/juttle/juttle-viz/pull/32","diff_url":"https://github.com/juttle/juttle-viz/pull/32.diff","patch_url":"https://github.com/juttle/juttle-viz/pull/32.patch","issue_url":"https://api.github.com/repos/juttle/juttle-viz/issues/32","number":32,"state":"open","locked":false,"title":"time field: fix which views require time in points and which ones don't","user":{"login":"go-oleg","id":3344137,"avatar_url":"https://avatars.githubusercontent.com/u/3344137?v=3","gravatar_id":"","url":"https://api.github.com/users/go-oleg","html_url":"https://github.com/go-oleg","followers_url":"https://api.github.com/users/go-oleg/followers","following_url":"https://api.github.com/users/go-oleg/following{/other_user}","gists_url":"https://api.github.com/users/go-oleg/gists{/gist_id}","starred_url":"https://api.github.com/users/go-oleg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-oleg/subscriptions","organizations_url":"https://api.github.com/users/go-oleg/orgs","repos_url":"https://api.github.com/users/go-oleg/repos","events_url":"https://api.github.com/users/go-oleg/events{/privacy}","received_events_url":"https://api.github.com/users/go-oleg/received_events","type":"User","site_admin":false},"body":"There was some code removed in #25 that related to whether a given view requires time in points or not removed. The result was that all views require time in points which is incorrect.\r\n\r\nBring the code back and add tests to make sure views don't complain about points without time.\r\n\r\nFixes #31.\r\n\r\n@rlgomes @mnibecker ","created_at":"2016-01-22T04:07:07Z","updated_at":"2016-01-22T04:16:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efa02121dbfd8ba5b27bd4da901cf01b3a69294e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juttle/juttle-viz/pulls/32/commits","review_comments_url":"https://api.github.com/repos/juttle/juttle-viz/pulls/32/comments","review_comment_url":"https://api.github.com/repos/juttle/juttle-viz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juttle/juttle-viz/issues/32/comments","statuses_url":"https://api.github.com/repos/juttle/juttle-viz/statuses/0e8548d3c41be09d39734c4038e17469ba62cfc8","head":{"label":"juttle:fix-time-field-validation","ref":"fix-time-field-validation","sha":"0e8548d3c41be09d39734c4038e17469ba62cfc8","user":{"login":"juttle","id":8988633,"avatar_url":"https://avatars.githubusercontent.com/u/8988633?v=3","gravatar_id":"","url":"https://api.github.com/users/juttle","html_url":"https://github.com/juttle","followers_url":"https://api.github.com/users/juttle/followers","following_url":"https://api.github.com/users/juttle/following{/other_user}","gists_url":"https://api.github.com/users/juttle/gists{/gist_id}","starred_url":"https://api.github.com/users/juttle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juttle/subscriptions","organizations_url":"https://api.github.com/users/juttle/orgs","repos_url":"https://api.github.com/users/juttle/repos","events_url":"https://api.github.com/users/juttle/events{/privacy}","received_events_url":"https://api.github.com/users/juttle/received_events","type":"Organization","site_admin":false},"repo":{"id":48262224,"name":"juttle-viz","full_name":"juttle/juttle-viz","owner":{"login":"juttle","id":8988633,"avatar_url":"https://avatars.githubusercontent.com/u/8988633?v=3","gravatar_id":"","url":"https://api.github.com/users/juttle","html_url":"https://github.com/juttle","followers_url":"https://api.github.com/users/juttle/followers","following_url":"https://api.github.com/users/juttle/following{/other_user}","gists_url":"https://api.github.com/users/juttle/gists{/gist_id}","starred_url":"https://api.github.com/users/juttle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juttle/subscriptions","organizations_url":"https://api.github.com/users/juttle/orgs","repos_url":"https://api.github.com/users/juttle/repos","events_url":"https://api.github.com/users/juttle/events{/privacy}","received_events_url":"https://api.github.com/users/juttle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juttle/juttle-viz","description":"Juttle Visualization Library","fork":false,"url":"https://api.github.com/repos/juttle/juttle-viz","forks_url":"https://api.github.com/repos/juttle/juttle-viz/forks","keys_url":"https://api.github.com/repos/juttle/juttle-viz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juttle/juttle-viz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juttle/juttle-viz/teams","hooks_url":"https://api.github.com/repos/juttle/juttle-viz/hooks","issue_events_url":"https://api.github.com/repos/juttle/juttle-viz/issues/events{/number}","events_url":"https://api.github.com/repos/juttle/juttle-viz/events","assignees_url":"https://api.github.com/repos/juttle/juttle-viz/assignees{/user}","branches_url":"https://api.github.com/repos/juttle/juttle-viz/branches{/branch}","tags_url":"https://api.github.com/repos/juttle/juttle-viz/tags","blobs_url":"https://api.github.com/repos/juttle/juttle-viz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juttle/juttle-viz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juttle/juttle-viz/git/refs{/sha}","trees_url":"https://api.github.com/repos/juttle/juttle-viz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juttle/juttle-viz/statuses/{sha}","languages_url":"https://api.github.com/repos/juttle/juttle-viz/languages","stargazers_url":"https://api.github.com/repos/juttle/juttle-viz/stargazers","contributors_url":"https://api.github.com/repos/juttle/juttle-viz/contributors","subscribers_url":"https://api.github.com/repos/juttle/juttle-viz/subscribers","subscription_url":"https://api.github.com/repos/juttle/juttle-viz/subscription","commits_url":"https://api.github.com/repos/juttle/juttle-viz/commits{/sha}","git_commits_url":"https://api.github.com/repos/juttle/juttle-viz/git/commits{/sha}","comments_url":"https://api.github.com/repos/juttle/juttle-viz/comments{/number}","issue_comment_url":"https://api.github.com/repos/juttle/juttle-viz/issues/comments{/number}","contents_url":"https://api.github.com/repos/juttle/juttle-viz/contents/{+path}","compare_url":"https://api.github.com/repos/juttle/juttle-viz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juttle/juttle-viz/merges","archive_url":"https://api.github.com/repos/juttle/juttle-viz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juttle/juttle-viz/downloads","issues_url":"https://api.github.com/repos/juttle/juttle-viz/issues{/number}","pulls_url":"https://api.github.com/repos/juttle/juttle-viz/pulls{/number}","milestones_url":"https://api.github.com/repos/juttle/juttle-viz/milestones{/number}","notifications_url":"https://api.github.com/repos/juttle/juttle-viz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juttle/juttle-viz/labels{/name}","releases_url":"https://api.github.com/repos/juttle/juttle-viz/releases{/id}","deployments_url":"https://api.github.com/repos/juttle/juttle-viz/deployments","created_at":"2015-12-19T00:11:08Z","updated_at":"2016-01-18T17:46:14Z","pushed_at":"2016-01-22T04:07:08Z","git_url":"git://github.com/juttle/juttle-viz.git","ssh_url":"git@github.com:juttle/juttle-viz.git","clone_url":"https://github.com/juttle/juttle-viz.git","svn_url":"https://github.com/juttle/juttle-viz","homepage":null,"size":2548,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":13,"forks":0,"open_issues":13,"watchers":2,"default_branch":"master"}},"base":{"label":"juttle:master","ref":"master","sha":"41dfa21dbcf2abd982dc288a3891f43106fa367a","user":{"login":"juttle","id":8988633,"avatar_url":"https://avatars.githubusercontent.com/u/8988633?v=3","gravatar_id":"","url":"https://api.github.com/users/juttle","html_url":"https://github.com/juttle","followers_url":"https://api.github.com/users/juttle/followers","following_url":"https://api.github.com/users/juttle/following{/other_user}","gists_url":"https://api.github.com/users/juttle/gists{/gist_id}","starred_url":"https://api.github.com/users/juttle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juttle/subscriptions","organizations_url":"https://api.github.com/users/juttle/orgs","repos_url":"https://api.github.com/users/juttle/repos","events_url":"https://api.github.com/users/juttle/events{/privacy}","received_events_url":"https://api.github.com/users/juttle/received_events","type":"Organization","site_admin":false},"repo":{"id":48262224,"name":"juttle-viz","full_name":"juttle/juttle-viz","owner":{"login":"juttle","id":8988633,"avatar_url":"https://avatars.githubusercontent.com/u/8988633?v=3","gravatar_id":"","url":"https://api.github.com/users/juttle","html_url":"https://github.com/juttle","followers_url":"https://api.github.com/users/juttle/followers","following_url":"https://api.github.com/users/juttle/following{/other_user}","gists_url":"https://api.github.com/users/juttle/gists{/gist_id}","starred_url":"https://api.github.com/users/juttle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juttle/subscriptions","organizations_url":"https://api.github.com/users/juttle/orgs","repos_url":"https://api.github.com/users/juttle/repos","events_url":"https://api.github.com/users/juttle/events{/privacy}","received_events_url":"https://api.github.com/users/juttle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juttle/juttle-viz","description":"Juttle Visualization Library","fork":false,"url":"https://api.github.com/repos/juttle/juttle-viz","forks_url":"https://api.github.com/repos/juttle/juttle-viz/forks","keys_url":"https://api.github.com/repos/juttle/juttle-viz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juttle/juttle-viz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juttle/juttle-viz/teams","hooks_url":"https://api.github.com/repos/juttle/juttle-viz/hooks","issue_events_url":"https://api.github.com/repos/juttle/juttle-viz/issues/events{/number}","events_url":"https://api.github.com/repos/juttle/juttle-viz/events","assignees_url":"https://api.github.com/repos/juttle/juttle-viz/assignees{/user}","branches_url":"https://api.github.com/repos/juttle/juttle-viz/branches{/branch}","tags_url":"https://api.github.com/repos/juttle/juttle-viz/tags","blobs_url":"https://api.github.com/repos/juttle/juttle-viz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juttle/juttle-viz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juttle/juttle-viz/git/refs{/sha}","trees_url":"https://api.github.com/repos/juttle/juttle-viz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juttle/juttle-viz/statuses/{sha}","languages_url":"https://api.github.com/repos/juttle/juttle-viz/languages","stargazers_url":"https://api.github.com/repos/juttle/juttle-viz/stargazers","contributors_url":"https://api.github.com/repos/juttle/juttle-viz/contributors","subscribers_url":"https://api.github.com/repos/juttle/juttle-viz/subscribers","subscription_url":"https://api.github.com/repos/juttle/juttle-viz/subscription","commits_url":"https://api.github.com/repos/juttle/juttle-viz/commits{/sha}","git_commits_url":"https://api.github.com/repos/juttle/juttle-viz/git/commits{/sha}","comments_url":"https://api.github.com/repos/juttle/juttle-viz/comments{/number}","issue_comment_url":"https://api.github.com/repos/juttle/juttle-viz/issues/comments{/number}","contents_url":"https://api.github.com/repos/juttle/juttle-viz/contents/{+path}","compare_url":"https://api.github.com/repos/juttle/juttle-viz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juttle/juttle-viz/merges","archive_url":"https://api.github.com/repos/juttle/juttle-viz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juttle/juttle-viz/downloads","issues_url":"https://api.github.com/repos/juttle/juttle-viz/issues{/number}","pulls_url":"https://api.github.com/repos/juttle/juttle-viz/pulls{/number}","milestones_url":"https://api.github.com/repos/juttle/juttle-viz/milestones{/number}","notifications_url":"https://api.github.com/repos/juttle/juttle-viz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juttle/juttle-viz/labels{/name}","releases_url":"https://api.github.com/repos/juttle/juttle-viz/releases{/id}","deployments_url":"https://api.github.com/repos/juttle/juttle-viz/deployments","created_at":"2015-12-19T00:11:08Z","updated_at":"2016-01-18T17:46:14Z","pushed_at":"2016-01-22T04:07:08Z","git_url":"git://github.com/juttle/juttle-viz.git","ssh_url":"git@github.com:juttle/juttle-viz.git","clone_url":"https://github.com/juttle/juttle-viz.git","svn_url":"https://github.com/juttle/juttle-viz","homepage":null,"size":2548,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":13,"forks":0,"open_issues":13,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juttle/juttle-viz/pulls/32"},"html":{"href":"https://github.com/juttle/juttle-viz/pull/32"},"issue":{"href":"https://api.github.com/repos/juttle/juttle-viz/issues/32"},"comments":{"href":"https://api.github.com/repos/juttle/juttle-viz/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/juttle/juttle-viz/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/juttle/juttle-viz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juttle/juttle-viz/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/juttle/juttle-viz/statuses/0e8548d3c41be09d39734c4038e17469ba62cfc8"}}}}