{"action":"closed","number":11709,"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/11709","id":55133459,"html_url":"https://github.com/laravel/framework/pull/11709","diff_url":"https://github.com/laravel/framework/pull/11709.diff","patch_url":"https://github.com/laravel/framework/pull/11709.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/11709","number":11709,"state":"closed","locked":false,"title":"[5.2] validateJson should fail on nonstringable values","user":{"login":"tdhsmith","id":1791252,"avatar_url":"https://avatars.githubusercontent.com/u/1791252?v=3","gravatar_id":"","url":"https://api.github.com/users/tdhsmith","html_url":"https://github.com/tdhsmith","followers_url":"https://api.github.com/users/tdhsmith/followers","following_url":"https://api.github.com/users/tdhsmith/following{/other_user}","gists_url":"https://api.github.com/users/tdhsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/tdhsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdhsmith/subscriptions","organizations_url":"https://api.github.com/users/tdhsmith/orgs","repos_url":"https://api.github.com/users/tdhsmith/repos","events_url":"https://api.github.com/users/tdhsmith/events{/privacy}","received_events_url":"https://api.github.com/users/tdhsmith/received_events","type":"User","site_admin":false},"body":"Under current behavior, all values are passed directly into `json_decode`, which will throw an `ErrorException` when its input cannot be coerced to string. Thus the `validateJson` method will sometimes generate exceptions when failures are expected. This is mostly a concern for arrays due to their prevalence (and misconceptions about valid JSON), but it could in general be caused by any object.\r\n\r\nThe rule has been modified to preemptively detect values that will throw this exception and return false for them.","created_at":"2016-01-05T19:41:56Z","updated_at":"2016-01-06T14:41:11Z","closed_at":"2016-01-06T14:41:11Z","merged_at":"2016-01-06T14:41:11Z","merge_commit_sha":"fe49ffc8f90a51726b8a6721d724f314a2979bf6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/11709/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/11709/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/11709/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/1e6d39645c863bab68d13b3b81da23300c0d0851","head":{"label":"tdhsmith:patch-1","ref":"patch-1","sha":"1e6d39645c863bab68d13b3b81da23300c0d0851","user":{"login":"tdhsmith","id":1791252,"avatar_url":"https://avatars.githubusercontent.com/u/1791252?v=3","gravatar_id":"","url":"https://api.github.com/users/tdhsmith","html_url":"https://github.com/tdhsmith","followers_url":"https://api.github.com/users/tdhsmith/followers","following_url":"https://api.github.com/users/tdhsmith/following{/other_user}","gists_url":"https://api.github.com/users/tdhsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/tdhsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdhsmith/subscriptions","organizations_url":"https://api.github.com/users/tdhsmith/orgs","repos_url":"https://api.github.com/users/tdhsmith/repos","events_url":"https://api.github.com/users/tdhsmith/events{/privacy}","received_events_url":"https://api.github.com/users/tdhsmith/received_events","type":"User","site_admin":false},"repo":{"id":49087117,"name":"framework","full_name":"tdhsmith/framework","owner":{"login":"tdhsmith","id":1791252,"avatar_url":"https://avatars.githubusercontent.com/u/1791252?v=3","gravatar_id":"","url":"https://api.github.com/users/tdhsmith","html_url":"https://github.com/tdhsmith","followers_url":"https://api.github.com/users/tdhsmith/followers","following_url":"https://api.github.com/users/tdhsmith/following{/other_user}","gists_url":"https://api.github.com/users/tdhsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/tdhsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdhsmith/subscriptions","organizations_url":"https://api.github.com/users/tdhsmith/orgs","repos_url":"https://api.github.com/users/tdhsmith/repos","events_url":"https://api.github.com/users/tdhsmith/events{/privacy}","received_events_url":"https://api.github.com/users/tdhsmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tdhsmith/framework","description":"","fork":true,"url":"https://api.github.com/repos/tdhsmith/framework","forks_url":"https://api.github.com/repos/tdhsmith/framework/forks","keys_url":"https://api.github.com/repos/tdhsmith/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tdhsmith/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tdhsmith/framework/teams","hooks_url":"https://api.github.com/repos/tdhsmith/framework/hooks","issue_events_url":"https://api.github.com/repos/tdhsmith/framework/issues/events{/number}","events_url":"https://api.github.com/repos/tdhsmith/framework/events","assignees_url":"https://api.github.com/repos/tdhsmith/framework/assignees{/user}","branches_url":"https://api.github.com/repos/tdhsmith/framework/branches{/branch}","tags_url":"https://api.github.com/repos/tdhsmith/framework/tags","blobs_url":"https://api.github.com/repos/tdhsmith/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tdhsmith/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tdhsmith/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/tdhsmith/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tdhsmith/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/tdhsmith/framework/languages","stargazers_url":"https://api.github.com/repos/tdhsmith/framework/stargazers","contributors_url":"https://api.github.com/repos/tdhsmith/framework/contributors","subscribers_url":"https://api.github.com/repos/tdhsmith/framework/subscribers","subscription_url":"https://api.github.com/repos/tdhsmith/framework/subscription","commits_url":"https://api.github.com/repos/tdhsmith/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/tdhsmith/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/tdhsmith/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/tdhsmith/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/tdhsmith/framework/contents/{+path}","compare_url":"https://api.github.com/repos/tdhsmith/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tdhsmith/framework/merges","archive_url":"https://api.github.com/repos/tdhsmith/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tdhsmith/framework/downloads","issues_url":"https://api.github.com/repos/tdhsmith/framework/issues{/number}","pulls_url":"https://api.github.com/repos/tdhsmith/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/tdhsmith/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/tdhsmith/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tdhsmith/framework/labels{/name}","releases_url":"https://api.github.com/repos/tdhsmith/framework/releases{/id}","created_at":"2016-01-05T19:15:58Z","updated_at":"2016-01-05T19:16:03Z","pushed_at":"2016-01-05T19:43:58Z","git_url":"git://github.com/tdhsmith/framework.git","ssh_url":"git@github.com:tdhsmith/framework.git","clone_url":"https://github.com/tdhsmith/framework.git","svn_url":"https://github.com/tdhsmith/framework","homepage":"http://laravel.com","size":20542,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.2"}},"base":{"label":"laravel:5.2","ref":"5.2","sha":"391a6878a9128ba7deecffa48d5c944b40982ad5","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","created_at":"2013-01-10T21:27:28Z","updated_at":"2016-01-06T13:21:39Z","pushed_at":"2016-01-06T14:41:11Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":33476,"stargazers_count":4567,"watchers_count":4567,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2669,"mirror_url":null,"open_issues_count":44,"forks":2669,"open_issues":44,"watchers":4567,"default_branch":"5.2"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/11709"},"html":{"href":"https://github.com/laravel/framework/pull/11709"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/11709"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/11709/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/11709/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/11709/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/1e6d39645c863bab68d13b3b81da23300c0d0851"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"taylorotwell","id":463230,"avatar_url":"https://avatars.githubusercontent.com/u/463230?v=3","gravatar_id":"","url":"https://api.github.com/users/taylorotwell","html_url":"https://github.com/taylorotwell","followers_url":"https://api.github.com/users/taylorotwell/followers","following_url":"https://api.github.com/users/taylorotwell/following{/other_user}","gists_url":"https://api.github.com/users/taylorotwell/gists{/gist_id}","starred_url":"https://api.github.com/users/taylorotwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylorotwell/subscriptions","organizations_url":"https://api.github.com/users/taylorotwell/orgs","repos_url":"https://api.github.com/users/taylorotwell/repos","events_url":"https://api.github.com/users/taylorotwell/events{/privacy}","received_events_url":"https://api.github.com/users/taylorotwell/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":4,"deletions":0,"changed_files":1}}