{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/68744422","id":68744422,"diff_hunk":"@@ -411,13 +414,21 @@ func (r *RollingUpdater) readyPods(oldRc, newRc *api.ReplicationController) (int\n \t\t\treturn 0, 0, err\n \t\t}\n \t\tfor _, pod := range pods.Items {\n-\t\t\tif api.IsPodReady(&pod) {\n-\t\t\t\tswitch controller.Name {\n-\t\t\t\tcase oldRc.Name:\n-\t\t\t\t\toldReady++\n-\t\t\t\tcase newRc.Name:\n-\t\t\t\t\tnewReady++\n-\t\t\t\t}\n+\t\t\tif !api.IsPodReady(&pod) {\n+\t\t\t\tcontinue\n+\t\t\t}\n+\t\t\t// Compute the time where the Pod should be ready, adding the MinReadySeconds.\n+\t\t\tready := unversioned.Time{\n+\t\t\t\tTime: api.GetPodReadyCondition(pod.Status).LastTransitionTime.Add(time.Duration(minReadySeconds) * time.Second),\n+\t\t\t}\n+\t\t\tif ready.Before(unversioned.Now()) {","path":"pkg/kubectl/rolling_updater.go","position":62,"original_position":62,"commit_id":"124f9905b93ab9373cc5591d4e43bc0351d34a1f","original_commit_id":"c3ee0ebc2bb13255b7a7c195e2e27505e5eac91b","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"body":"done","created_at":"2016-06-28T12:12:33Z","updated_at":"2016-06-28T12:12:33Z","html_url":"https://github.com/kubernetes/kubernetes/pull/28111#discussion_r68744422","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28111","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/68744422"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/28111#discussion_r68744422"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28111"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28111","id":75303248,"html_url":"https://github.com/kubernetes/kubernetes/pull/28111","diff_url":"https://github.com/kubernetes/kubernetes/pull/28111.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/28111.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28111","number":28111,"state":"open","locked":false,"title":"WIP: Add MinReadySeconds to rolling updater","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"body":"Add MinReadySeconds support to RollingUpdater that allows to specify the number of seconds to wait on top of the pod is \"ready\" because its readiness probe passed.","created_at":"2016-06-27T12:33:56Z","updated_at":"2016-06-28T12:12:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97ace4b9f8f4c2217c985d743eb3def5ea3e44bb","assignee":{"login":"jlowdermilk","id":2101035,"avatar_url":"https://avatars.githubusercontent.com/u/2101035?v=3","gravatar_id":"","url":"https://api.github.com/users/jlowdermilk","html_url":"https://github.com/jlowdermilk","followers_url":"https://api.github.com/users/jlowdermilk/followers","following_url":"https://api.github.com/users/jlowdermilk/following{/other_user}","gists_url":"https://api.github.com/users/jlowdermilk/gists{/gist_id}","starred_url":"https://api.github.com/users/jlowdermilk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlowdermilk/subscriptions","organizations_url":"https://api.github.com/users/jlowdermilk/orgs","repos_url":"https://api.github.com/users/jlowdermilk/repos","events_url":"https://api.github.com/users/jlowdermilk/events{/privacy}","received_events_url":"https://api.github.com/users/jlowdermilk/received_events","type":"User","site_admin":false},"assignees":[{"login":"jlowdermilk","id":2101035,"avatar_url":"https://avatars.githubusercontent.com/u/2101035?v=3","gravatar_id":"","url":"https://api.github.com/users/jlowdermilk","html_url":"https://github.com/jlowdermilk","followers_url":"https://api.github.com/users/jlowdermilk/followers","following_url":"https://api.github.com/users/jlowdermilk/following{/other_user}","gists_url":"https://api.github.com/users/jlowdermilk/gists{/gist_id}","starred_url":"https://api.github.com/users/jlowdermilk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlowdermilk/subscriptions","organizations_url":"https://api.github.com/users/jlowdermilk/orgs","repos_url":"https://api.github.com/users/jlowdermilk/repos","events_url":"https://api.github.com/users/jlowdermilk/events{/privacy}","received_events_url":"https://api.github.com/users/jlowdermilk/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28111/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28111/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28111/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/124f9905b93ab9373cc5591d4e43bc0351d34a1f","head":{"label":"mfojtik:min-ready-seconds","ref":"min-ready-seconds","sha":"124f9905b93ab9373cc5591d4e43bc0351d34a1f","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"repo":{"id":22151842,"name":"kubernetes","full_name":"mfojtik/kubernetes","owner":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfojtik/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/mfojtik/kubernetes","forks_url":"https://api.github.com/repos/mfojtik/kubernetes/forks","keys_url":"https://api.github.com/repos/mfojtik/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfojtik/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfojtik/kubernetes/teams","hooks_url":"https://api.github.com/repos/mfojtik/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/mfojtik/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/mfojtik/kubernetes/events","assignees_url":"https://api.github.com/repos/mfojtik/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/mfojtik/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/mfojtik/kubernetes/tags","blobs_url":"https://api.github.com/repos/mfojtik/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfojtik/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfojtik/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfojtik/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfojtik/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/mfojtik/kubernetes/languages","stargazers_url":"https://api.github.com/repos/mfojtik/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/mfojtik/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/mfojtik/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/mfojtik/kubernetes/subscription","commits_url":"https://api.github.com/repos/mfojtik/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfojtik/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfojtik/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfojtik/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfojtik/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/mfojtik/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfojtik/kubernetes/merges","archive_url":"https://api.github.com/repos/mfojtik/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfojtik/kubernetes/downloads","issues_url":"https://api.github.com/repos/mfojtik/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/mfojtik/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/mfojtik/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/mfojtik/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfojtik/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/mfojtik/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/mfojtik/kubernetes/deployments","created_at":"2014-07-23T14:06:52Z","updated_at":"2016-01-12T09:38:09Z","pushed_at":"2016-06-28T12:12:13Z","git_url":"git://github.com/mfojtik/kubernetes.git","ssh_url":"git@github.com:mfojtik/kubernetes.git","clone_url":"https://github.com/mfojtik/kubernetes.git","svn_url":"https://github.com/mfojtik/kubernetes","homepage":null,"size":271406,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"f3359fe1347c8be148b0f3b41e1956e3e80f843e","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-06-28T11:15:35Z","pushed_at":"2016-06-28T12:12:14Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":483632,"stargazers_count":15124,"watchers_count":15124,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4725,"mirror_url":null,"open_issues_count":3784,"forks":4725,"open_issues":3784,"watchers":15124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28111"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/28111"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/28111"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/28111/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28111/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28111/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/124f9905b93ab9373cc5591d4e43bc0351d34a1f"}}}}
{"actor":{"display_login":"mfojtik"}}