{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/comments/71946183","id":71946183,"diff_hunk":"@@ -300,9 +300,13 @@\n             id (:id request)\n             encode (get-in connection [:codec :encode])]\n         (if (capsule/expired? capsule)\n-          (let [response (make-ttl_expired-message request)]\n-            (websockets-client/send! ws (encode response))\n-            connection)\n+          (do\n+            (sl/maplog :trace (assoc (capsule/summarize capsule)","path":"src/puppetlabs/pcp/broker/core.clj","position":8,"original_position":8,"commit_id":"ed154bf481a1662f5bc8c2d5295f1f4c6b0d7417","original_commit_id":"ed154bf481a1662f5bc8c2d5295f1f4c6b0d7417","user":{"login":"mruzicka","id":562920,"avatar_url":"https://avatars.githubusercontent.com/u/562920?v=3","gravatar_id":"","url":"https://api.github.com/users/mruzicka","html_url":"https://github.com/mruzicka","followers_url":"https://api.github.com/users/mruzicka/followers","following_url":"https://api.github.com/users/mruzicka/following{/other_user}","gists_url":"https://api.github.com/users/mruzicka/gists{/gist_id}","starred_url":"https://api.github.com/users/mruzicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruzicka/subscriptions","organizations_url":"https://api.github.com/users/mruzicka/orgs","repos_url":"https://api.github.com/users/mruzicka/repos","events_url":"https://api.github.com/users/mruzicka/events{/privacy}","received_events_url":"https://api.github.com/users/mruzicka/received_events","type":"User","site_admin":false},"body":"I actually had it that way, but the thing I din't like about it was to the call to the `make-ttl_expired-message` before logging the message.","created_at":"2016-07-22T21:06:18Z","updated_at":"2016-07-22T21:06:18Z","html_url":"https://github.com/puppetlabs/pcp-broker/pull/133#discussion_r71946183","pull_request_url":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/133","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/comments/71946183"},"html":{"href":"https://github.com/puppetlabs/pcp-broker/pull/133#discussion_r71946183"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/133"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/133","id":78538919,"html_url":"https://github.com/puppetlabs/pcp-broker/pull/133","diff_url":"https://github.com/puppetlabs/pcp-broker/pull/133.diff","patch_url":"https://github.com/puppetlabs/pcp-broker/pull/133.patch","issue_url":"https://api.github.com/repos/puppetlabs/pcp-broker/issues/133","number":133,"state":"open","locked":false,"title":"(PCP-487) Increase timeouts in tests seriously","user":{"login":"mruzicka","id":562920,"avatar_url":"https://avatars.githubusercontent.com/u/562920?v=3","gravatar_id":"","url":"https://api.github.com/users/mruzicka","html_url":"https://github.com/mruzicka","followers_url":"https://api.github.com/users/mruzicka/followers","following_url":"https://api.github.com/users/mruzicka/following{/other_user}","gists_url":"https://api.github.com/users/mruzicka/gists{/gist_id}","starred_url":"https://api.github.com/users/mruzicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruzicka/subscriptions","organizations_url":"https://api.github.com/users/mruzicka/orgs","repos_url":"https://api.github.com/users/mruzicka/repos","events_url":"https://api.github.com/users/mruzicka/events{/privacy}","received_events_url":"https://api.github.com/users/mruzicka/received_events","type":"User","site_admin":false},"body":"This commit increases expiry timeouts on PCP messages exchanged during tests by a factor of 60. This is to avoid occasional failures in CI we keep seeing.\r\nIn contrast to previous attempts to do the same this commit doesn't change the actual timeouts but rather redefines the function which applies the timeout values to the PCP messages: `puppetlabs.pcp.message/set-expiry`.\r\nThis has the desired effect of raising the timeouts for both the test code and the tested code at the same time (previous attempts were only raising the timeouts in the test code).\r\nAdditionally, timeout is also raised in the `puppetlabs.pcp.testutils.client/recv!` function which, too, was causing test failures by not waiting long enough for messages to be received.\r\nFinally the `it-closes-connections-when-not-running-test` test is redesigned such that it avoids another instance of not waiting long enough for the broker to respond.","created_at":"2016-07-22T20:54:54Z","updated_at":"2016-07-22T21:06:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f76429b5f77f405d0ad40d3056e1cfd680b93af9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/133/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/133/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/pcp-broker/issues/133/comments","statuses_url":"https://api.github.com/repos/puppetlabs/pcp-broker/statuses/ed154bf481a1662f5bc8c2d5295f1f4c6b0d7417","head":{"label":"mruzicka:PCP-467_increase_timeouts_seriously","ref":"PCP-467_increase_timeouts_seriously","sha":"ed154bf481a1662f5bc8c2d5295f1f4c6b0d7417","user":{"login":"mruzicka","id":562920,"avatar_url":"https://avatars.githubusercontent.com/u/562920?v=3","gravatar_id":"","url":"https://api.github.com/users/mruzicka","html_url":"https://github.com/mruzicka","followers_url":"https://api.github.com/users/mruzicka/followers","following_url":"https://api.github.com/users/mruzicka/following{/other_user}","gists_url":"https://api.github.com/users/mruzicka/gists{/gist_id}","starred_url":"https://api.github.com/users/mruzicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruzicka/subscriptions","organizations_url":"https://api.github.com/users/mruzicka/orgs","repos_url":"https://api.github.com/users/mruzicka/repos","events_url":"https://api.github.com/users/mruzicka/events{/privacy}","received_events_url":"https://api.github.com/users/mruzicka/received_events","type":"User","site_admin":false},"repo":{"id":51078298,"name":"pcp-broker","full_name":"mruzicka/pcp-broker","owner":{"login":"mruzicka","id":562920,"avatar_url":"https://avatars.githubusercontent.com/u/562920?v=3","gravatar_id":"","url":"https://api.github.com/users/mruzicka","html_url":"https://github.com/mruzicka","followers_url":"https://api.github.com/users/mruzicka/followers","following_url":"https://api.github.com/users/mruzicka/following{/other_user}","gists_url":"https://api.github.com/users/mruzicka/gists{/gist_id}","starred_url":"https://api.github.com/users/mruzicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruzicka/subscriptions","organizations_url":"https://api.github.com/users/mruzicka/orgs","repos_url":"https://api.github.com/users/mruzicka/repos","events_url":"https://api.github.com/users/mruzicka/events{/privacy}","received_events_url":"https://api.github.com/users/mruzicka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mruzicka/pcp-broker","description":"PCP message broker","fork":true,"url":"https://api.github.com/repos/mruzicka/pcp-broker","forks_url":"https://api.github.com/repos/mruzicka/pcp-broker/forks","keys_url":"https://api.github.com/repos/mruzicka/pcp-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mruzicka/pcp-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mruzicka/pcp-broker/teams","hooks_url":"https://api.github.com/repos/mruzicka/pcp-broker/hooks","issue_events_url":"https://api.github.com/repos/mruzicka/pcp-broker/issues/events{/number}","events_url":"https://api.github.com/repos/mruzicka/pcp-broker/events","assignees_url":"https://api.github.com/repos/mruzicka/pcp-broker/assignees{/user}","branches_url":"https://api.github.com/repos/mruzicka/pcp-broker/branches{/branch}","tags_url":"https://api.github.com/repos/mruzicka/pcp-broker/tags","blobs_url":"https://api.github.com/repos/mruzicka/pcp-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mruzicka/pcp-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mruzicka/pcp-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mruzicka/pcp-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mruzicka/pcp-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/mruzicka/pcp-broker/languages","stargazers_url":"https://api.github.com/repos/mruzicka/pcp-broker/stargazers","contributors_url":"https://api.github.com/repos/mruzicka/pcp-broker/contributors","subscribers_url":"https://api.github.com/repos/mruzicka/pcp-broker/subscribers","subscription_url":"https://api.github.com/repos/mruzicka/pcp-broker/subscription","commits_url":"https://api.github.com/repos/mruzicka/pcp-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mruzicka/pcp-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mruzicka/pcp-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mruzicka/pcp-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/mruzicka/pcp-broker/contents/{+path}","compare_url":"https://api.github.com/repos/mruzicka/pcp-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mruzicka/pcp-broker/merges","archive_url":"https://api.github.com/repos/mruzicka/pcp-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mruzicka/pcp-broker/downloads","issues_url":"https://api.github.com/repos/mruzicka/pcp-broker/issues{/number}","pulls_url":"https://api.github.com/repos/mruzicka/pcp-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/mruzicka/pcp-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/mruzicka/pcp-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mruzicka/pcp-broker/labels{/name}","releases_url":"https://api.github.com/repos/mruzicka/pcp-broker/releases{/id}","deployments_url":"https://api.github.com/repos/mruzicka/pcp-broker/deployments","created_at":"2016-02-04T13:40:10Z","updated_at":"2016-02-04T13:40:11Z","pushed_at":"2016-07-22T20:53:08Z","git_url":"git://github.com/mruzicka/pcp-broker.git","ssh_url":"git@github.com:mruzicka/pcp-broker.git","clone_url":"https://github.com/mruzicka/pcp-broker.git","svn_url":"https://github.com/mruzicka/pcp-broker","homepage":"","size":697,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"3e5835a0a3d4a5387c25e7227ecad89058e1dd33","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":22723510,"name":"pcp-broker","full_name":"puppetlabs/pcp-broker","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/pcp-broker","description":"PCP message broker","fork":false,"url":"https://api.github.com/repos/puppetlabs/pcp-broker","forks_url":"https://api.github.com/repos/puppetlabs/pcp-broker/forks","keys_url":"https://api.github.com/repos/puppetlabs/pcp-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/pcp-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/pcp-broker/teams","hooks_url":"https://api.github.com/repos/puppetlabs/pcp-broker/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/pcp-broker/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/pcp-broker/events","assignees_url":"https://api.github.com/repos/puppetlabs/pcp-broker/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/pcp-broker/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/pcp-broker/tags","blobs_url":"https://api.github.com/repos/puppetlabs/pcp-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/pcp-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/pcp-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/pcp-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/pcp-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/pcp-broker/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/pcp-broker/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/pcp-broker/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/pcp-broker/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/pcp-broker/subscription","commits_url":"https://api.github.com/repos/puppetlabs/pcp-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/pcp-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/pcp-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/pcp-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/pcp-broker/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/pcp-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/pcp-broker/merges","archive_url":"https://api.github.com/repos/puppetlabs/pcp-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/pcp-broker/downloads","issues_url":"https://api.github.com/repos/puppetlabs/pcp-broker/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/pcp-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/pcp-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/pcp-broker/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/pcp-broker/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/pcp-broker/deployments","created_at":"2014-08-07T14:07:55Z","updated_at":"2016-01-12T13:22:30Z","pushed_at":"2016-07-22T20:54:54Z","git_url":"git://github.com/puppetlabs/pcp-broker.git","ssh_url":"git@github.com:puppetlabs/pcp-broker.git","clone_url":"https://github.com/puppetlabs/pcp-broker.git","svn_url":"https://github.com/puppetlabs/pcp-broker","homepage":"","size":736,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":1,"forks":9,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/133"},"html":{"href":"https://github.com/puppetlabs/pcp-broker/pull/133"},"issue":{"href":"https://api.github.com/repos/puppetlabs/pcp-broker/issues/133"},"comments":{"href":"https://api.github.com/repos/puppetlabs/pcp-broker/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/pcp-broker/statuses/ed154bf481a1662f5bc8c2d5295f1f4c6b0d7417"}}}}
{"actor":{"display_login":"mruzicka"}}