{"action":"created","comment":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/comments/81443681","pull_request_review_id":2426105,"id":81443681,"diff_hunk":"@@ -0,0 +1,103 @@\n+var debug = require('../../utils/debug');\n+var register = require('../../core/component').registerComponent;\n+\n+var warn = debug('components:pool:warn');\n+\n+/**\n+ * Pool component.\n+ * It initialized a pool of entities that will be reused.\n+ * It avoids creating and destroying the same kind entities\n+ * in dynamic scenes. Useful for example in a game where you want\n+ * to reuse enemies entities\n+ *\n+ * @member {array} poolEls - Available entities in the pool.\n+ * @member {array} pooledEls - Entities of the pool in use.\n+ *\n+ */\n+module.exports.Component = register('pool', {\n+  schema: {\n+    mixin: {default: ''},\n+    size: {default: 0},\n+    dynamicSize: {default: false}\n+  },\n+\n+  multiple: true,\n+\n+  init: function () {\n+    this.createEntities();\n+  },\n+\n+  createEntities: function () {\n+    var mixin = this.data.mixin;\n+    if (!mixin) { return; }\n+    this.poolEls = [];","path":"src/components/scene/pool.js","position":33,"original_position":33,"commit_id":"4bdf65d1ff06d58c2c9f08963d791defa6957d91","original_commit_id":"4bdf65d1ff06d58c2c9f08963d791defa6957d91","user":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars.githubusercontent.com/u/674727?v=3","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"body":"I'd comment that this clears the pool","created_at":"2016-10-01T04:30:50Z","updated_at":"2016-10-01T04:30:50Z","html_url":"https://github.com/aframevr/aframe/pull/1954#discussion_r81443681","pull_request_url":"https://api.github.com/repos/aframevr/aframe/pulls/1954","_links":{"self":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/comments/81443681"},"html":{"href":"https://github.com/aframevr/aframe/pull/1954#discussion_r81443681"},"pull_request":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1954"}}},"pull_request":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/1954","id":87570242,"html_url":"https://github.com/aframevr/aframe/pull/1954","diff_url":"https://github.com/aframevr/aframe/pull/1954.diff","patch_url":"https://github.com/aframevr/aframe/pull/1954.patch","issue_url":"https://api.github.com/repos/aframevr/aframe/issues/1954","number":1954,"state":"open","locked":false,"title":"Add entities pool","user":{"login":"dmarcos","id":39342,"avatar_url":"https://avatars.githubusercontent.com/u/39342?v=3","gravatar_id":"","url":"https://api.github.com/users/dmarcos","html_url":"https://github.com/dmarcos","followers_url":"https://api.github.com/users/dmarcos/followers","following_url":"https://api.github.com/users/dmarcos/following{/other_user}","gists_url":"https://api.github.com/users/dmarcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dmarcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmarcos/subscriptions","organizations_url":"https://api.github.com/users/dmarcos/orgs","repos_url":"https://api.github.com/users/dmarcos/repos","events_url":"https://api.github.com/users/dmarcos/events{/privacy}","received_events_url":"https://api.github.com/users/dmarcos/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-30T21:37:22Z","updated_at":"2016-10-01T04:39:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83343b88520a2aa30932c989904200c368a679ba","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aframevr/aframe/pulls/1954/commits","review_comments_url":"https://api.github.com/repos/aframevr/aframe/pulls/1954/comments","review_comment_url":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aframevr/aframe/issues/1954/comments","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/4bdf65d1ff06d58c2c9f08963d791defa6957d91","head":{"label":"dmarcos:pool","ref":"pool","sha":"4bdf65d1ff06d58c2c9f08963d791defa6957d91","user":{"login":"dmarcos","id":39342,"avatar_url":"https://avatars.githubusercontent.com/u/39342?v=3","gravatar_id":"","url":"https://api.github.com/users/dmarcos","html_url":"https://github.com/dmarcos","followers_url":"https://api.github.com/users/dmarcos/followers","following_url":"https://api.github.com/users/dmarcos/following{/other_user}","gists_url":"https://api.github.com/users/dmarcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dmarcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmarcos/subscriptions","organizations_url":"https://api.github.com/users/dmarcos/orgs","repos_url":"https://api.github.com/users/dmarcos/repos","events_url":"https://api.github.com/users/dmarcos/events{/privacy}","received_events_url":"https://api.github.com/users/dmarcos/received_events","type":"User","site_admin":false},"repo":{"id":49595885,"name":"aframe","full_name":"dmarcos/aframe","owner":{"login":"dmarcos","id":39342,"avatar_url":"https://avatars.githubusercontent.com/u/39342?v=3","gravatar_id":"","url":"https://api.github.com/users/dmarcos","html_url":"https://github.com/dmarcos","followers_url":"https://api.github.com/users/dmarcos/followers","following_url":"https://api.github.com/users/dmarcos/following{/other_user}","gists_url":"https://api.github.com/users/dmarcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dmarcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmarcos/subscriptions","organizations_url":"https://api.github.com/users/dmarcos/orgs","repos_url":"https://api.github.com/users/dmarcos/repos","events_url":"https://api.github.com/users/dmarcos/events{/privacy}","received_events_url":"https://api.github.com/users/dmarcos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmarcos/aframe","description":"Building Blocks for the VR Web","fork":true,"url":"https://api.github.com/repos/dmarcos/aframe","forks_url":"https://api.github.com/repos/dmarcos/aframe/forks","keys_url":"https://api.github.com/repos/dmarcos/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmarcos/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmarcos/aframe/teams","hooks_url":"https://api.github.com/repos/dmarcos/aframe/hooks","issue_events_url":"https://api.github.com/repos/dmarcos/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/dmarcos/aframe/events","assignees_url":"https://api.github.com/repos/dmarcos/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/dmarcos/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/dmarcos/aframe/tags","blobs_url":"https://api.github.com/repos/dmarcos/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmarcos/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmarcos/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmarcos/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmarcos/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/dmarcos/aframe/languages","stargazers_url":"https://api.github.com/repos/dmarcos/aframe/stargazers","contributors_url":"https://api.github.com/repos/dmarcos/aframe/contributors","subscribers_url":"https://api.github.com/repos/dmarcos/aframe/subscribers","subscription_url":"https://api.github.com/repos/dmarcos/aframe/subscription","commits_url":"https://api.github.com/repos/dmarcos/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmarcos/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmarcos/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmarcos/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmarcos/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/dmarcos/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmarcos/aframe/merges","archive_url":"https://api.github.com/repos/dmarcos/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmarcos/aframe/downloads","issues_url":"https://api.github.com/repos/dmarcos/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/dmarcos/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/dmarcos/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/dmarcos/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmarcos/aframe/labels{/name}","releases_url":"https://api.github.com/repos/dmarcos/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/dmarcos/aframe/deployments","created_at":"2016-01-13T19:17:26Z","updated_at":"2016-01-13T19:17:26Z","pushed_at":"2016-10-01T00:24:52Z","git_url":"git://github.com/dmarcos/aframe.git","ssh_url":"git@github.com:dmarcos/aframe.git","clone_url":"https://github.com/dmarcos/aframe.git","svn_url":"https://github.com/dmarcos/aframe","homepage":"https://aframe.io/","size":121105,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aframevr:master","ref":"master","sha":"07e70a4b0ce4c7b8419c4ea725de8cc947968e03","user":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars.githubusercontent.com/u/16024092?v=3","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"repo":{"id":42488903,"name":"aframe","full_name":"aframevr/aframe","owner":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars.githubusercontent.com/u/16024092?v=3","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aframevr/aframe","description":"A web framework for building virtual reality experiences.","fork":false,"url":"https://api.github.com/repos/aframevr/aframe","forks_url":"https://api.github.com/repos/aframevr/aframe/forks","keys_url":"https://api.github.com/repos/aframevr/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aframevr/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aframevr/aframe/teams","hooks_url":"https://api.github.com/repos/aframevr/aframe/hooks","issue_events_url":"https://api.github.com/repos/aframevr/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/aframevr/aframe/events","assignees_url":"https://api.github.com/repos/aframevr/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/aframevr/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/aframevr/aframe/tags","blobs_url":"https://api.github.com/repos/aframevr/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aframevr/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aframevr/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/aframevr/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/aframevr/aframe/languages","stargazers_url":"https://api.github.com/repos/aframevr/aframe/stargazers","contributors_url":"https://api.github.com/repos/aframevr/aframe/contributors","subscribers_url":"https://api.github.com/repos/aframevr/aframe/subscribers","subscription_url":"https://api.github.com/repos/aframevr/aframe/subscription","commits_url":"https://api.github.com/repos/aframevr/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/aframevr/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/aframevr/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/aframevr/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/aframevr/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/aframevr/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aframevr/aframe/merges","archive_url":"https://api.github.com/repos/aframevr/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aframevr/aframe/downloads","issues_url":"https://api.github.com/repos/aframevr/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/aframevr/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/aframevr/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/aframevr/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aframevr/aframe/labels{/name}","releases_url":"https://api.github.com/repos/aframevr/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/aframevr/aframe/deployments","created_at":"2015-09-15T02:04:40Z","updated_at":"2016-10-01T04:09:34Z","pushed_at":"2016-10-01T04:12:20Z","git_url":"git://github.com/aframevr/aframe.git","ssh_url":"git@github.com:aframevr/aframe.git","clone_url":"https://github.com/aframevr/aframe.git","svn_url":"https://github.com/aframevr/aframe","homepage":"https://aframe.io/","size":141835,"stargazers_count":3541,"watchers_count":3541,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":661,"mirror_url":null,"open_issues_count":211,"forks":661,"open_issues":211,"watchers":3541,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1954"},"html":{"href":"https://github.com/aframevr/aframe/pull/1954"},"issue":{"href":"https://api.github.com/repos/aframevr/aframe/issues/1954"},"comments":{"href":"https://api.github.com/repos/aframevr/aframe/issues/1954/comments"},"review_comments":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1954/comments"},"review_comment":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/1954/commits"},"statuses":{"href":"https://api.github.com/repos/aframevr/aframe/statuses/4bdf65d1ff06d58c2c9f08963d791defa6957d91"}}}}
{"actor":{"display_login":"ngokevin"}}