{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/logstash/pulls/comments/74805624","id":74805624,"diff_hunk":"@@ -20,42 +20,40 @@ class LogStash::Outputs::Base < LogStash::Plugin\n \n   # The codec used for output data. Output codecs are a convenient method for encoding your data before it leaves the output, without needing a separate filter in your Logstash pipeline.\n   config :codec, :validate => :codec, :default => \"plain\"\n+  \n+  # Set or return concurrency type\n+  def self.concurrency(type=nil)\n+    if type\n+      @concurrency = type\n+\n+      # TODO remove this in Logstash 6.0\n+      # when we no longer support the :legacy_worker type\n+      # This is hacky, but it can only be here\n+      if type == :legacy_worker","path":"logstash-core/lib/logstash/outputs/base.rb","position":13,"original_position":13,"commit_id":"0b2a29136c38172bc2f827edde27d1d065ea56d3","original_commit_id":"0b2a29136c38172bc2f827edde27d1d065ea56d3","user":{"login":"jordansissel","id":131818,"avatar_url":"https://avatars.githubusercontent.com/u/131818?v=3","gravatar_id":"","url":"https://api.github.com/users/jordansissel","html_url":"https://github.com/jordansissel","followers_url":"https://api.github.com/users/jordansissel/followers","following_url":"https://api.github.com/users/jordansissel/following{/other_user}","gists_url":"https://api.github.com/users/jordansissel/gists{/gist_id}","starred_url":"https://api.github.com/users/jordansissel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordansissel/subscriptions","organizations_url":"https://api.github.com/users/jordansissel/orgs","repos_url":"https://api.github.com/users/jordansissel/repos","events_url":"https://api.github.com/users/jordansissel/events{/privacy}","received_events_url":"https://api.github.com/users/jordansissel/received_events","type":"User","site_admin":false},"body":"Feels inconsistent to have them called `shared`, `single`, and then a two-word name `legacy worker`. Can we call it `legacy` instead of `legacy_worker`? What's the story on the `_worker` suffix?","created_at":"2016-08-15T18:09:39Z","updated_at":"2016-08-15T18:09:39Z","html_url":"https://github.com/elastic/logstash/pull/5752#discussion_r74805624","pull_request_url":"https://api.github.com/repos/elastic/logstash/pulls/5752","_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments/74805624"},"html":{"href":"https://github.com/elastic/logstash/pull/5752#discussion_r74805624"},"pull_request":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5752"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/logstash/pulls/5752","id":80721639,"html_url":"https://github.com/elastic/logstash/pull/5752","diff_url":"https://github.com/elastic/logstash/pull/5752.diff","patch_url":"https://github.com/elastic/logstash/pull/5752.patch","issue_url":"https://api.github.com/repos/elastic/logstash/issues/5752","number":5752,"state":"open","locked":false,"title":"WIP Delegator refactor","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"body":"This WIP cleans up everything related to output delegators and specifically cleans up the nomenclature WRT `concurrency`.\r\n\r\nThis is ready for review, though tests around `Pipeline#plugin` need some work. I need to write some spec helpers to let us properly test alternate registries to satisfy this. Additionally we need to make the plugin registry injectable for proper testability. I'm deliberating doing this in a separate PR.\r\n\r\nFixes #5661  #5658 #5659 #5754 all related to meta issue https://github.com/elastic/logstash/issues/5662","created_at":"2016-08-10T01:29:49Z","updated_at":"2016-08-15T18:09:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bc2adae7c09eb0ffc8ea9e46855ec7a2b342ca8","assignee":{"login":"guyboertje","id":84912,"avatar_url":"https://avatars.githubusercontent.com/u/84912?v=3","gravatar_id":"","url":"https://api.github.com/users/guyboertje","html_url":"https://github.com/guyboertje","followers_url":"https://api.github.com/users/guyboertje/followers","following_url":"https://api.github.com/users/guyboertje/following{/other_user}","gists_url":"https://api.github.com/users/guyboertje/gists{/gist_id}","starred_url":"https://api.github.com/users/guyboertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyboertje/subscriptions","organizations_url":"https://api.github.com/users/guyboertje/orgs","repos_url":"https://api.github.com/users/guyboertje/repos","events_url":"https://api.github.com/users/guyboertje/events{/privacy}","received_events_url":"https://api.github.com/users/guyboertje/received_events","type":"User","site_admin":false},"assignees":[{"login":"guyboertje","id":84912,"avatar_url":"https://avatars.githubusercontent.com/u/84912?v=3","gravatar_id":"","url":"https://api.github.com/users/guyboertje","html_url":"https://github.com/guyboertje","followers_url":"https://api.github.com/users/guyboertje/followers","following_url":"https://api.github.com/users/guyboertje/following{/other_user}","gists_url":"https://api.github.com/users/guyboertje/gists{/gist_id}","starred_url":"https://api.github.com/users/guyboertje/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyboertje/subscriptions","organizations_url":"https://api.github.com/users/guyboertje/orgs","repos_url":"https://api.github.com/users/guyboertje/repos","events_url":"https://api.github.com/users/guyboertje/events{/privacy}","received_events_url":"https://api.github.com/users/guyboertje/received_events","type":"User","site_admin":false},{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},{"login":"jordansissel","id":131818,"avatar_url":"https://avatars.githubusercontent.com/u/131818?v=3","gravatar_id":"","url":"https://api.github.com/users/jordansissel","html_url":"https://github.com/jordansissel","followers_url":"https://api.github.com/users/jordansissel/followers","following_url":"https://api.github.com/users/jordansissel/following{/other_user}","gists_url":"https://api.github.com/users/jordansissel/gists{/gist_id}","starred_url":"https://api.github.com/users/jordansissel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordansissel/subscriptions","organizations_url":"https://api.github.com/users/jordansissel/orgs","repos_url":"https://api.github.com/users/jordansissel/repos","events_url":"https://api.github.com/users/jordansissel/events{/privacy}","received_events_url":"https://api.github.com/users/jordansissel/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/logstash/pulls/5752/commits","review_comments_url":"https://api.github.com/repos/elastic/logstash/pulls/5752/comments","review_comment_url":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/logstash/issues/5752/comments","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/0b2a29136c38172bc2f827edde27d1d065ea56d3","head":{"label":"andrewvc:delegator_refactor","ref":"delegator_refactor","sha":"0b2a29136c38172bc2f827edde27d1d065ea56d3","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"repo":{"id":37559198,"name":"logstash","full_name":"andrewvc/logstash","owner":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewvc/logstash","description":"logstash - transport and process your logs, events, or other data","fork":true,"url":"https://api.github.com/repos/andrewvc/logstash","forks_url":"https://api.github.com/repos/andrewvc/logstash/forks","keys_url":"https://api.github.com/repos/andrewvc/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewvc/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewvc/logstash/teams","hooks_url":"https://api.github.com/repos/andrewvc/logstash/hooks","issue_events_url":"https://api.github.com/repos/andrewvc/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/andrewvc/logstash/events","assignees_url":"https://api.github.com/repos/andrewvc/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/andrewvc/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/andrewvc/logstash/tags","blobs_url":"https://api.github.com/repos/andrewvc/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewvc/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewvc/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewvc/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewvc/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewvc/logstash/languages","stargazers_url":"https://api.github.com/repos/andrewvc/logstash/stargazers","contributors_url":"https://api.github.com/repos/andrewvc/logstash/contributors","subscribers_url":"https://api.github.com/repos/andrewvc/logstash/subscribers","subscription_url":"https://api.github.com/repos/andrewvc/logstash/subscription","commits_url":"https://api.github.com/repos/andrewvc/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewvc/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewvc/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewvc/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewvc/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/andrewvc/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewvc/logstash/merges","archive_url":"https://api.github.com/repos/andrewvc/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewvc/logstash/downloads","issues_url":"https://api.github.com/repos/andrewvc/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/andrewvc/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewvc/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewvc/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewvc/logstash/labels{/name}","releases_url":"https://api.github.com/repos/andrewvc/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/andrewvc/logstash/deployments","created_at":"2015-06-16T22:23:09Z","updated_at":"2015-06-16T22:23:11Z","pushed_at":"2016-08-11T17:53:21Z","git_url":"git://github.com/andrewvc/logstash.git","ssh_url":"git@github.com:andrewvc/logstash.git","clone_url":"https://github.com/andrewvc/logstash.git","svn_url":"https://github.com/andrewvc/logstash","homepage":"https://www.elastic.co/products/logstash","size":78646,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"e7dcdd66ba26992a66b18454629704b144152ed0","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":1090311,"name":"logstash","full_name":"elastic/logstash","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/logstash","description":"logstash - transport and process your logs, events, or other data","fork":false,"url":"https://api.github.com/repos/elastic/logstash","forks_url":"https://api.github.com/repos/elastic/logstash/forks","keys_url":"https://api.github.com/repos/elastic/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/logstash/teams","hooks_url":"https://api.github.com/repos/elastic/logstash/hooks","issue_events_url":"https://api.github.com/repos/elastic/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/logstash/events","assignees_url":"https://api.github.com/repos/elastic/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/logstash/tags","blobs_url":"https://api.github.com/repos/elastic/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/logstash/languages","stargazers_url":"https://api.github.com/repos/elastic/logstash/stargazers","contributors_url":"https://api.github.com/repos/elastic/logstash/contributors","subscribers_url":"https://api.github.com/repos/elastic/logstash/subscribers","subscription_url":"https://api.github.com/repos/elastic/logstash/subscription","commits_url":"https://api.github.com/repos/elastic/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/logstash/merges","archive_url":"https://api.github.com/repos/elastic/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/logstash/downloads","issues_url":"https://api.github.com/repos/elastic/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/logstash/labels{/name}","releases_url":"https://api.github.com/repos/elastic/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/logstash/deployments","created_at":"2010-11-18T01:31:50Z","updated_at":"2016-08-15T16:55:11Z","pushed_at":"2016-08-14T19:09:31Z","git_url":"git://github.com/elastic/logstash.git","ssh_url":"git@github.com:elastic/logstash.git","clone_url":"https://github.com/elastic/logstash.git","svn_url":"https://github.com/elastic/logstash","homepage":"https://www.elastic.co/products/logstash","size":89246,"stargazers_count":6292,"watchers_count":6292,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1867,"mirror_url":null,"open_issues_count":812,"forks":1867,"open_issues":812,"watchers":6292,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5752"},"html":{"href":"https://github.com/elastic/logstash/pull/5752"},"issue":{"href":"https://api.github.com/repos/elastic/logstash/issues/5752"},"comments":{"href":"https://api.github.com/repos/elastic/logstash/issues/5752/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5752/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5752/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/logstash/statuses/0b2a29136c38172bc2f827edde27d1d065ea56d3"}}}}
{"actor":{"display_login":"jordansissel"}}