{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/81570470","pull_request_review_id":2540813,"id":81570470,"diff_hunk":"@@ -19,40 +19,17 @@\n #include \"Core/NetPlayServer.h\"\n #include \"DolphinWX/Frame.h\"\n #include \"DolphinWX/Main.h\"\n+#include \"DolphinWX/NetPlay/NetPlayLauncher.h\"\n #include \"DolphinWX/NetPlay/NetPlaySetupFrame.h\"\n #include \"DolphinWX/NetPlay/NetWindow.h\"\n #include \"DolphinWX/WxUtils.h\"\n \n namespace","path":"Source/Core/DolphinWX/NetPlay/NetPlaySetupFrame.cpp","position":9,"original_position":9,"commit_id":"82d5a79da59c7b7d2b0b50ace75f15ba000c60a2","original_commit_id":"82d5a79da59c7b7d2b0b50ace75f15ba000c60a2","user":{"login":"clinchergt","id":1283149,"avatar_url":"https://avatars.githubusercontent.com/u/1283149?v=3","gravatar_id":"","url":"https://api.github.com/users/clinchergt","html_url":"https://github.com/clinchergt","followers_url":"https://api.github.com/users/clinchergt/followers","following_url":"https://api.github.com/users/clinchergt/following{/other_user}","gists_url":"https://api.github.com/users/clinchergt/gists{/gist_id}","starred_url":"https://api.github.com/users/clinchergt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clinchergt/subscriptions","organizations_url":"https://api.github.com/users/clinchergt/orgs","repos_url":"https://api.github.com/users/clinchergt/repos","events_url":"https://api.github.com/users/clinchergt/events{/privacy}","received_events_url":"https://api.github.com/users/clinchergt/received_events","type":"User","site_admin":false},"body":"Do we still need this anonymous namespace now that it would only really get rid of one `static`?","created_at":"2016-10-03T15:09:52Z","updated_at":"2016-10-03T15:11:36Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/4279#discussion_r81570470","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4279","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/81570470"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/4279#discussion_r81570470"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4279"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4279","id":87706547,"html_url":"https://github.com/dolphin-emu/dolphin/pull/4279","diff_url":"https://github.com/dolphin-emu/dolphin/pull/4279.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/4279.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4279","number":4279,"state":"open","locked":false,"title":"Aestek feature/netplay oneclick","user":{"login":"shuffle2","id":113063,"avatar_url":"https://avatars.githubusercontent.com/u/113063?v=3","gravatar_id":"","url":"https://api.github.com/users/shuffle2","html_url":"https://github.com/shuffle2","followers_url":"https://api.github.com/users/shuffle2/followers","following_url":"https://api.github.com/users/shuffle2/following{/other_user}","gists_url":"https://api.github.com/users/shuffle2/gists{/gist_id}","starred_url":"https://api.github.com/users/shuffle2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuffle2/subscriptions","organizations_url":"https://api.github.com/users/shuffle2/orgs","repos_url":"https://api.github.com/users/shuffle2/repos","events_url":"https://api.github.com/users/shuffle2/events{/privacy}","received_events_url":"https://api.github.com/users/shuffle2/received_events","type":"User","site_admin":false},"body":"Rebase of https://github.com/dolphin-emu/dolphin/pull/4057\r\nPlease test.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dolphin-emu/dolphin/4279)\n<!-- Reviewable:end -->\n","created_at":"2016-10-03T12:19:30Z","updated_at":"2016-10-03T15:11:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19479141cb1a628665b2449692a4e17ead216707","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4279/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4279/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4279/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/82d5a79da59c7b7d2b0b50ace75f15ba000c60a2","head":{"label":"shuffle2:Aestek-feature/netplay-oneclick","ref":"Aestek-feature/netplay-oneclick","sha":"82d5a79da59c7b7d2b0b50ace75f15ba000c60a2","user":{"login":"shuffle2","id":113063,"avatar_url":"https://avatars.githubusercontent.com/u/113063?v=3","gravatar_id":"","url":"https://api.github.com/users/shuffle2","html_url":"https://github.com/shuffle2","followers_url":"https://api.github.com/users/shuffle2/followers","following_url":"https://api.github.com/users/shuffle2/following{/other_user}","gists_url":"https://api.github.com/users/shuffle2/gists{/gist_id}","starred_url":"https://api.github.com/users/shuffle2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuffle2/subscriptions","organizations_url":"https://api.github.com/users/shuffle2/orgs","repos_url":"https://api.github.com/users/shuffle2/repos","events_url":"https://api.github.com/users/shuffle2/events{/privacy}","received_events_url":"https://api.github.com/users/shuffle2/received_events","type":"User","site_admin":false},"repo":{"id":17430796,"name":"dolphin","full_name":"shuffle2/dolphin","owner":{"login":"shuffle2","id":113063,"avatar_url":"https://avatars.githubusercontent.com/u/113063?v=3","gravatar_id":"","url":"https://api.github.com/users/shuffle2","html_url":"https://github.com/shuffle2","followers_url":"https://api.github.com/users/shuffle2/followers","following_url":"https://api.github.com/users/shuffle2/following{/other_user}","gists_url":"https://api.github.com/users/shuffle2/gists{/gist_id}","starred_url":"https://api.github.com/users/shuffle2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuffle2/subscriptions","organizations_url":"https://api.github.com/users/shuffle2/orgs","repos_url":"https://api.github.com/users/shuffle2/repos","events_url":"https://api.github.com/users/shuffle2/events{/privacy}","received_events_url":"https://api.github.com/users/shuffle2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shuffle2/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/shuffle2/dolphin","forks_url":"https://api.github.com/repos/shuffle2/dolphin/forks","keys_url":"https://api.github.com/repos/shuffle2/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shuffle2/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shuffle2/dolphin/teams","hooks_url":"https://api.github.com/repos/shuffle2/dolphin/hooks","issue_events_url":"https://api.github.com/repos/shuffle2/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/shuffle2/dolphin/events","assignees_url":"https://api.github.com/repos/shuffle2/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/shuffle2/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/shuffle2/dolphin/tags","blobs_url":"https://api.github.com/repos/shuffle2/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shuffle2/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shuffle2/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/shuffle2/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shuffle2/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/shuffle2/dolphin/languages","stargazers_url":"https://api.github.com/repos/shuffle2/dolphin/stargazers","contributors_url":"https://api.github.com/repos/shuffle2/dolphin/contributors","subscribers_url":"https://api.github.com/repos/shuffle2/dolphin/subscribers","subscription_url":"https://api.github.com/repos/shuffle2/dolphin/subscription","commits_url":"https://api.github.com/repos/shuffle2/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/shuffle2/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/shuffle2/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/shuffle2/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/shuffle2/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/shuffle2/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shuffle2/dolphin/merges","archive_url":"https://api.github.com/repos/shuffle2/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shuffle2/dolphin/downloads","issues_url":"https://api.github.com/repos/shuffle2/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/shuffle2/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/shuffle2/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/shuffle2/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shuffle2/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/shuffle2/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/shuffle2/dolphin/deployments","created_at":"2014-03-05T06:50:40Z","updated_at":"2016-04-02T19:06:13Z","pushed_at":"2016-10-03T14:15:37Z","git_url":"git://github.com/shuffle2/dolphin.git","ssh_url":"git@github.com:shuffle2/dolphin.git","clone_url":"https://github.com/shuffle2/dolphin.git","svn_url":"https://github.com/shuffle2/dolphin","homepage":null,"size":272829,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"upstream-master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"e38ddfd78768216b49b297423d4a4110798c029a","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2016-10-03T11:39:35Z","pushed_at":"2016-10-03T14:15:42Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":329394,"stargazers_count":2759,"watchers_count":2759,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":738,"mirror_url":null,"open_issues_count":112,"forks":738,"open_issues":112,"watchers":2759,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4279"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/4279"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4279"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4279/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4279/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4279/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/82d5a79da59c7b7d2b0b50ace75f15ba000c60a2"}}}}
{"actor":{"display_login":"clinchergt"}}