{"action":"created","comment":{"url":"https://api.github.com/repos/openthread/openthread/pulls/comments/85055997","pull_request_review_id":5793404,"id":85055997,"diff_hunk":"@@ -277,6 +305,9 @@ class ThreadNetif: public Ip6::Netif\n     Coap::Server mCoapServer;\n     Coap::Client mCoapClient;\n     AddressResolver mAddressResolver;\n+    Dhcp6::Dhcp6Client mDhcp6Client;\n+    Dhcp6::Dhcp6Server mDhcp6Server;","path":"src/core/thread/thread_netif.hpp","position":54,"original_position":54,"commit_id":"872f74c74bda7976744593608dfb191180702b03","original_commit_id":"0b6df327fdde7fea010dac7f1a0fca3b4f31bcfc","user":{"login":"librasungirl","id":19217991,"avatar_url":"https://avatars.githubusercontent.com/u/19217991?v=3","gravatar_id":"","url":"https://api.github.com/users/librasungirl","html_url":"https://github.com/librasungirl","followers_url":"https://api.github.com/users/librasungirl/followers","following_url":"https://api.github.com/users/librasungirl/following{/other_user}","gists_url":"https://api.github.com/users/librasungirl/gists{/gist_id}","starred_url":"https://api.github.com/users/librasungirl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librasungirl/subscriptions","organizations_url":"https://api.github.com/users/librasungirl/orgs","repos_url":"https://api.github.com/users/librasungirl/repos","events_url":"https://api.github.com/users/librasungirl/events{/privacy}","received_events_url":"https://api.github.com/users/librasungirl/received_events","type":"User","site_admin":false},"body":"make sense. will update","created_at":"2016-10-26T06:26:53Z","updated_at":"2016-10-26T06:26:53Z","html_url":"https://github.com/openthread/openthread/pull/884#discussion_r85055997","pull_request_url":"https://api.github.com/repos/openthread/openthread/pulls/884","_links":{"self":{"href":"https://api.github.com/repos/openthread/openthread/pulls/comments/85055997"},"html":{"href":"https://github.com/openthread/openthread/pull/884#discussion_r85055997"},"pull_request":{"href":"https://api.github.com/repos/openthread/openthread/pulls/884"}}},"pull_request":{"url":"https://api.github.com/repos/openthread/openthread/pulls/884","id":90913535,"html_url":"https://github.com/openthread/openthread/pull/884","diff_url":"https://github.com/openthread/openthread/pull/884.diff","patch_url":"https://github.com/openthread/openthread/pull/884.patch","issue_url":"https://api.github.com/repos/openthread/openthread/issues/884","number":884,"state":"open","locked":false,"title":"intial implementation of Dhcp client/server(solicit/release)","user":{"login":"librasungirl","id":19217991,"avatar_url":"https://avatars.githubusercontent.com/u/19217991?v=3","gravatar_id":"","url":"https://api.github.com/users/librasungirl","html_url":"https://github.com/librasungirl","followers_url":"https://api.github.com/users/librasungirl/followers","following_url":"https://api.github.com/users/librasungirl/following{/other_user}","gists_url":"https://api.github.com/users/librasungirl/gists{/gist_id}","starred_url":"https://api.github.com/users/librasungirl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librasungirl/subscriptions","organizations_url":"https://api.github.com/users/librasungirl/orgs","repos_url":"https://api.github.com/users/librasungirl/repos","events_url":"https://api.github.com/users/librasungirl/events{/privacy}","received_events_url":"https://api.github.com/users/librasungirl/received_events","type":"User","site_admin":false},"body":"To Resolve #459 \r\n\r\nThis PR is an initial implement. Further refinement and some enhancement will be patched soon.\r\n@jwhui , would you please have a look and share your opinions if any in advance?\r\n\r\n\r\nAttached some tests here:\r\n[testdhcp_ping.pcapng.zip](https://github.com/openthread/openthread/files/552025/testdhcp_ping.pcapng.zip)\r\n[testdhcp_solicit_release.pcapng.zip](https://github.com/openthread/openthread/files/552233/testdhcp_solicit_release.pcapng.zip)\r\n[Leader_5_3_8.zip](https://github.com/openthread/openthread/files/552036/Leader_5_3_8.zip)\r\n","created_at":"2016-10-25T23:54:32Z","updated_at":"2016-10-26T06:26:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15f75db7ed01df52a01105cf6a49e140e931d7b4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openthread/openthread/pulls/884/commits","review_comments_url":"https://api.github.com/repos/openthread/openthread/pulls/884/comments","review_comment_url":"https://api.github.com/repos/openthread/openthread/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openthread/openthread/issues/884/comments","statuses_url":"https://api.github.com/repos/openthread/openthread/statuses/872f74c74bda7976744593608dfb191180702b03","head":{"label":"librasungirl:pr/dhcp","ref":"pr/dhcp","sha":"872f74c74bda7976744593608dfb191180702b03","user":{"login":"librasungirl","id":19217991,"avatar_url":"https://avatars.githubusercontent.com/u/19217991?v=3","gravatar_id":"","url":"https://api.github.com/users/librasungirl","html_url":"https://github.com/librasungirl","followers_url":"https://api.github.com/users/librasungirl/followers","following_url":"https://api.github.com/users/librasungirl/following{/other_user}","gists_url":"https://api.github.com/users/librasungirl/gists{/gist_id}","starred_url":"https://api.github.com/users/librasungirl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librasungirl/subscriptions","organizations_url":"https://api.github.com/users/librasungirl/orgs","repos_url":"https://api.github.com/users/librasungirl/repos","events_url":"https://api.github.com/users/librasungirl/events{/privacy}","received_events_url":"https://api.github.com/users/librasungirl/received_events","type":"User","site_admin":false},"repo":{"id":58746751,"name":"openthread","full_name":"librasungirl/openthread","owner":{"login":"librasungirl","id":19217991,"avatar_url":"https://avatars.githubusercontent.com/u/19217991?v=3","gravatar_id":"","url":"https://api.github.com/users/librasungirl","html_url":"https://github.com/librasungirl","followers_url":"https://api.github.com/users/librasungirl/followers","following_url":"https://api.github.com/users/librasungirl/following{/other_user}","gists_url":"https://api.github.com/users/librasungirl/gists{/gist_id}","starred_url":"https://api.github.com/users/librasungirl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librasungirl/subscriptions","organizations_url":"https://api.github.com/users/librasungirl/orgs","repos_url":"https://api.github.com/users/librasungirl/repos","events_url":"https://api.github.com/users/librasungirl/events{/privacy}","received_events_url":"https://api.github.com/users/librasungirl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/librasungirl/openthread","description":"OpenThread is an open-source implementation of the Thread networking protocol","fork":true,"url":"https://api.github.com/repos/librasungirl/openthread","forks_url":"https://api.github.com/repos/librasungirl/openthread/forks","keys_url":"https://api.github.com/repos/librasungirl/openthread/keys{/key_id}","collaborators_url":"https://api.github.com/repos/librasungirl/openthread/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/librasungirl/openthread/teams","hooks_url":"https://api.github.com/repos/librasungirl/openthread/hooks","issue_events_url":"https://api.github.com/repos/librasungirl/openthread/issues/events{/number}","events_url":"https://api.github.com/repos/librasungirl/openthread/events","assignees_url":"https://api.github.com/repos/librasungirl/openthread/assignees{/user}","branches_url":"https://api.github.com/repos/librasungirl/openthread/branches{/branch}","tags_url":"https://api.github.com/repos/librasungirl/openthread/tags","blobs_url":"https://api.github.com/repos/librasungirl/openthread/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/librasungirl/openthread/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/librasungirl/openthread/git/refs{/sha}","trees_url":"https://api.github.com/repos/librasungirl/openthread/git/trees{/sha}","statuses_url":"https://api.github.com/repos/librasungirl/openthread/statuses/{sha}","languages_url":"https://api.github.com/repos/librasungirl/openthread/languages","stargazers_url":"https://api.github.com/repos/librasungirl/openthread/stargazers","contributors_url":"https://api.github.com/repos/librasungirl/openthread/contributors","subscribers_url":"https://api.github.com/repos/librasungirl/openthread/subscribers","subscription_url":"https://api.github.com/repos/librasungirl/openthread/subscription","commits_url":"https://api.github.com/repos/librasungirl/openthread/commits{/sha}","git_commits_url":"https://api.github.com/repos/librasungirl/openthread/git/commits{/sha}","comments_url":"https://api.github.com/repos/librasungirl/openthread/comments{/number}","issue_comment_url":"https://api.github.com/repos/librasungirl/openthread/issues/comments{/number}","contents_url":"https://api.github.com/repos/librasungirl/openthread/contents/{+path}","compare_url":"https://api.github.com/repos/librasungirl/openthread/compare/{base}...{head}","merges_url":"https://api.github.com/repos/librasungirl/openthread/merges","archive_url":"https://api.github.com/repos/librasungirl/openthread/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/librasungirl/openthread/downloads","issues_url":"https://api.github.com/repos/librasungirl/openthread/issues{/number}","pulls_url":"https://api.github.com/repos/librasungirl/openthread/pulls{/number}","milestones_url":"https://api.github.com/repos/librasungirl/openthread/milestones{/number}","notifications_url":"https://api.github.com/repos/librasungirl/openthread/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/librasungirl/openthread/labels{/name}","releases_url":"https://api.github.com/repos/librasungirl/openthread/releases{/id}","deployments_url":"https://api.github.com/repos/librasungirl/openthread/deployments","created_at":"2016-05-13T14:23:42Z","updated_at":"2016-10-25T23:43:39Z","pushed_at":"2016-10-26T04:59:15Z","git_url":"git://github.com/librasungirl/openthread.git","ssh_url":"git@github.com:librasungirl/openthread.git","clone_url":"https://github.com/librasungirl/openthread.git","svn_url":"https://github.com/librasungirl/openthread","homepage":"","size":94718,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openthread:master","ref":"master","sha":"f60084049970aa9012d23f6ea3e0682c2e07cb98","user":{"login":"openthread","id":16142269,"avatar_url":"https://avatars.githubusercontent.com/u/16142269?v=3","gravatar_id":"","url":"https://api.github.com/users/openthread","html_url":"https://github.com/openthread","followers_url":"https://api.github.com/users/openthread/followers","following_url":"https://api.github.com/users/openthread/following{/other_user}","gists_url":"https://api.github.com/users/openthread/gists{/gist_id}","starred_url":"https://api.github.com/users/openthread/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openthread/subscriptions","organizations_url":"https://api.github.com/users/openthread/orgs","repos_url":"https://api.github.com/users/openthread/repos","events_url":"https://api.github.com/users/openthread/events{/privacy}","received_events_url":"https://api.github.com/users/openthread/received_events","type":"Organization","site_admin":false},"repo":{"id":55808787,"name":"openthread","full_name":"openthread/openthread","owner":{"login":"openthread","id":16142269,"avatar_url":"https://avatars.githubusercontent.com/u/16142269?v=3","gravatar_id":"","url":"https://api.github.com/users/openthread","html_url":"https://github.com/openthread","followers_url":"https://api.github.com/users/openthread/followers","following_url":"https://api.github.com/users/openthread/following{/other_user}","gists_url":"https://api.github.com/users/openthread/gists{/gist_id}","starred_url":"https://api.github.com/users/openthread/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openthread/subscriptions","organizations_url":"https://api.github.com/users/openthread/orgs","repos_url":"https://api.github.com/users/openthread/repos","events_url":"https://api.github.com/users/openthread/events{/privacy}","received_events_url":"https://api.github.com/users/openthread/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openthread/openthread","description":"OpenThread released by Nest is an open-source implementation of the Thread networking protocol","fork":false,"url":"https://api.github.com/repos/openthread/openthread","forks_url":"https://api.github.com/repos/openthread/openthread/forks","keys_url":"https://api.github.com/repos/openthread/openthread/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openthread/openthread/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openthread/openthread/teams","hooks_url":"https://api.github.com/repos/openthread/openthread/hooks","issue_events_url":"https://api.github.com/repos/openthread/openthread/issues/events{/number}","events_url":"https://api.github.com/repos/openthread/openthread/events","assignees_url":"https://api.github.com/repos/openthread/openthread/assignees{/user}","branches_url":"https://api.github.com/repos/openthread/openthread/branches{/branch}","tags_url":"https://api.github.com/repos/openthread/openthread/tags","blobs_url":"https://api.github.com/repos/openthread/openthread/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openthread/openthread/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openthread/openthread/git/refs{/sha}","trees_url":"https://api.github.com/repos/openthread/openthread/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openthread/openthread/statuses/{sha}","languages_url":"https://api.github.com/repos/openthread/openthread/languages","stargazers_url":"https://api.github.com/repos/openthread/openthread/stargazers","contributors_url":"https://api.github.com/repos/openthread/openthread/contributors","subscribers_url":"https://api.github.com/repos/openthread/openthread/subscribers","subscription_url":"https://api.github.com/repos/openthread/openthread/subscription","commits_url":"https://api.github.com/repos/openthread/openthread/commits{/sha}","git_commits_url":"https://api.github.com/repos/openthread/openthread/git/commits{/sha}","comments_url":"https://api.github.com/repos/openthread/openthread/comments{/number}","issue_comment_url":"https://api.github.com/repos/openthread/openthread/issues/comments{/number}","contents_url":"https://api.github.com/repos/openthread/openthread/contents/{+path}","compare_url":"https://api.github.com/repos/openthread/openthread/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openthread/openthread/merges","archive_url":"https://api.github.com/repos/openthread/openthread/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openthread/openthread/downloads","issues_url":"https://api.github.com/repos/openthread/openthread/issues{/number}","pulls_url":"https://api.github.com/repos/openthread/openthread/pulls{/number}","milestones_url":"https://api.github.com/repos/openthread/openthread/milestones{/number}","notifications_url":"https://api.github.com/repos/openthread/openthread/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openthread/openthread/labels{/name}","releases_url":"https://api.github.com/repos/openthread/openthread/releases{/id}","deployments_url":"https://api.github.com/repos/openthread/openthread/deployments","created_at":"2016-04-08T20:47:41Z","updated_at":"2016-10-22T15:46:58Z","pushed_at":"2016-10-26T05:30:31Z","git_url":"git://github.com/openthread/openthread.git","ssh_url":"git@github.com:openthread/openthread.git","clone_url":"https://github.com/openthread/openthread.git","svn_url":"https://github.com/openthread/openthread","homepage":"","size":561437,"stargazers_count":1004,"watchers_count":1004,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":224,"mirror_url":null,"open_issues_count":45,"forks":224,"open_issues":45,"watchers":1004,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openthread/openthread/pulls/884"},"html":{"href":"https://github.com/openthread/openthread/pull/884"},"issue":{"href":"https://api.github.com/repos/openthread/openthread/issues/884"},"comments":{"href":"https://api.github.com/repos/openthread/openthread/issues/884/comments"},"review_comments":{"href":"https://api.github.com/repos/openthread/openthread/pulls/884/comments"},"review_comment":{"href":"https://api.github.com/repos/openthread/openthread/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openthread/openthread/pulls/884/commits"},"statuses":{"href":"https://api.github.com/repos/openthread/openthread/statuses/872f74c74bda7976744593608dfb191180702b03"}}}}
{"actor":{"display_login":"librasungirl"}}