{"push_id":1371577330,"size":16,"distinct_size":7,"ref":"refs/heads/us76123-ui-fixes","head":"242b747c444e56713148028dd53216be4450ed74","before":"b960ca71e6f6b37d537b00b93fe76a4ebc3094fd","commits":[{"sha":"7305c10d56e03236547bcb28403f1e8a60f407ce","author":{"name":"Jeff Stefaniuk","email":"dfc9aac168d2015835ebb76e5651db5a4c2bf5f0@D2L.com"},"message":"add an upload button to the Change Image screen","distinct":false,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits/7305c10d56e03236547bcb28403f1e8a60f407ce"},{"sha":"dae42b70e03116bdcfd8da1ecb295e3f58b628aa","author":{"name":"Jeff Stefaniuk","email":"dfc9aac168d2015835ebb76e5651db5a4c2bf5f0@D2L.com"},"message":"add in underline for hover/focus","distinct":false,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits/dae42b70e03116bdcfd8da1ecb295e3f58b628aa"},{"sha":"962340077d9134b7469c58eb1df1f0b82b218c2e","author":{"name":"Jeff Stefaniuk","email":"dfc9aac168d2015835ebb76e5651db5a4c2bf5f0@D2L.com"},"message":"no fixed font size","distinct":false,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits/962340077d9134b7469c58eb1df1f0b82b218c2e"},{"sha":"588f988e836ec07c3475698f89d618c1c1ec6a7d","author":{"name":"Jeff Stefaniuk","email":"dfc9aac168d2015835ebb76e5651db5a4c2bf5f0@D2L.com"},"message":"fix change after rebase","distinct":false,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits/588f988e836ec07c3475698f89d618c1c1ec6a7d"},{"sha":"b3033f49534ba706e109da0524e0628624587041","author":{"name":"Jeff Stefaniuk","email":"dfc9aac168d2015835ebb76e5651db5a4c2bf5f0@D2L.com"},"message":"make the image always refresh when the page is navigated to","distinct":false,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits/b3033f49534ba706e109da0524e0628624587041"},{"sha":"f10376d6928668dcc18826b87f93257179a11804","author":{"name":"Jeff Stefaniuk","email":"dfc9aac168d2015835ebb76e5651db5a4c2bf5f0@D2L.com"},"message":"fix 50% width in ie and safari","distinct":false,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits/f10376d6928668dcc18826b87f93257179a11804"},{"sha":"0b1236cd346c527517c4ff76516bdcb95163d7b2","author":{"name":"Jeff Stefaniuk","email":"b3989f2b1ccaf831450053e4a05f118017fa40f4@d2l.com"},"message":"Merge pull request #161 from Brightspace/uploadButton\n\nUS78354 - add an upload button to the Change Image screen","distinct":false,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits/0b1236cd346c527517c4ff76516bdcb95163d7b2"},{"sha":"68ae16640f7b864c0781d14cef95b2719c4c89c2","author":{"name":"Jeff Stefaniuk","email":"dfc9aac168d2015835ebb76e5651db5a4c2bf5f0@D2L.com"},"message":"initial lazy-load work for images\n\nMake it work for searches as well and do cleanup\n\nRemove unused param\n\ninitial loading spinner work\n\nrebase fixes\n\nsometimes it freezes up for a fraction of a second while loading images, make sure that the user can see the loading spinner\n\ndon't use $$ when $ works\n\nuse scrollIntoView for allCourses too\n\ncode review changes\n\nfix for the same page sometimes loading twice\n\ncleanup\n\nremove unnused attribute\n\nadd in spinner ref\n\nrefactor a bit, fix case where you get in a loading loop\n\nremove unused param\n\ndon't lazyload if on a no-results page\n\nremove unused param\n\nupdate clear function after rebase\n\nfixes after rebase","distinct":false,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits/68ae16640f7b864c0781d14cef95b2719c4c89c2"},{"sha":"4b4c00888ac79a51783c2393b52f37726b3b376d","author":{"name":"Jeff Stefaniuk","email":"b3989f2b1ccaf831450053e4a05f118017fa40f4@d2l.com"},"message":"Merge pull request #162 from Brightspace/lazyLoad\n\nUS77514 - Lazy load","distinct":false,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits/4b4c00888ac79a51783c2393b52f37726b3b376d"},{"sha":"8fef912958d0d8f8e08e8c1bdef13c949b5c6510","author":{"name":"Ryan Mahler","email":"3549f5999901dbe7739f81acffc362aded8af84d@d2l.com"},"message":"Various UI fixes\n\n- 60px (the default) was too large for the dropdowns, so it's been shrunk down to 45px tall\n- adjust space between search and \"Pinned\" header to 50px\n- only show Previous Searches if there are previous searches\n- set width of Search field to 5/12 width\n- close sort dropdown when a sorting option is selected","distinct":true,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits/8fef912958d0d8f8e08e8c1bdef13c949b5c6510"},{"sha":"89cba52f1c64970eae095827209402fd3ba31c14","author":{"name":"Ryan Mahler","email":"3549f5999901dbe7739f81acffc362aded8af84d@d2l.com"},"message":"Simplify dropdown openers and CSS\n\nSince we're now closing the dropdown after a click, it doesn't matter that the text changes and would move the dropdown. This significantly simplifies the styling and HTML for the opener, yay! Would be nice to be able to do this with the filter dropdown as well, but since it remains open as the text changes this may not be possible.\n\nThe tab buttons in the filter menu can be controlled by their aria-pressed attribute.\n\nNo need to manually call _toggleFilterDropdown, just use auto-open.\n\nAlso some other minor stuff.","distinct":true,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits/89cba52f1c64970eae095827209402fd3ba31c14"},{"sha":"48c1274d547168e55d2959abcf08762e9a9c668a","author":{"name":"Ryan Mahler","email":"3549f5999901dbe7739f81acffc362aded8af84d@d2l.com"},"message":"Remove space between text and button\n\nWas caused by using display: inline-block, which treats the whitespace between the ending </span> and the opening <d2l-dropdown> as actual whitespace. So, use display: flex with some padding instead.","distinct":true,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits/48c1274d547168e55d2959abcf08762e9a9c668a"},{"sha":"8509c9bf68d3f0600909644596bd0e6a754b95a9","author":{"name":"Ryan Mahler","email":"3549f5999901dbe7739f81acffc362aded8af84d@d2l.com"},"message":"Re-add no-auto-open, and tweak _toggleFilterDropdown\n\nNot sure if because of a bug, or because our multiple-openers-including-a-span is kinda gross, but in order to get the filter dropdown to properly toggle open/closed, we need to keep track of its state internally. Reading the dropdown content's opened attribute doesn't give the correct value.","distinct":true,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits/8509c9bf68d3f0600909644596bd0e6a754b95a9"},{"sha":"3d6522e257899d5e977e72e6eccbbb4b7640f344","author":{"name":"Ryan Mahler","email":"3549f5999901dbe7739f81acffc362aded8af84d@d2l.com"},"message":"Fix bad rebase, whoops","distinct":true,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits/3d6522e257899d5e977e72e6eccbbb4b7640f344"},{"sha":"e6075867e2133ec3ead7be87d5728c3db7949275","author":{"name":"Ryan Mahler","email":"3549f5999901dbe7739f81acffc362aded8af84d@d2l.com"},"message":"Testing fixes\n\n- Fixed dropdown opening when there were no recent searches in incognito mode (put the return in the right place...)\n- Fixed focus/highlighting problems when the filter menu is opened and closed via the opener/text (if a dropdown is closed by clicking on its opener, focus should go back to the opener)\n- Slightly simplify resize logic","distinct":true,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits/e6075867e2133ec3ead7be87d5728c3db7949275"},{"sha":"242b747c444e56713148028dd53216be4450ed74","author":{"name":"Ryan Mahler","email":"3549f5999901dbe7739f81acffc362aded8af84d@d2l.com"},"message":"Move requests for departments/semesters\n\nThis call is... fairly expensive, so no need to do it if the user isn't even opening the all courses overlay. Strictly speaking, we could delay it until they actually click the filter dropdown, but a) may be an overoptimization, and b) would need to add a loading spinner, as it takes a few seconds typically.","distinct":true,"url":"https://api.github.com/repos/Brightspace/d2l-my-courses-ui/commits/242b747c444e56713148028dd53216be4450ed74"}]}
{"actor":{"display_login":"ryantmer"}}