{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/http-remoting/pulls/comments/54152850","id":54152850,"diff_hunk":"@@ -41,6 +45,14 @@ private FeignClients() {}\n      * com.fasterxml.jackson.datatype.guava.GuavaModule} and {@link com.fasterxml.jackson.datatype.jdk7.Jdk7Module}.\n      */\n     public static FeignClientFactory standard() {\n+        return standard(DEFAULT_TIMEOUT_OPTIONS);\n+    }\n+\n+    /**\n+     * Provides a {@link FeignClientFactory} with an {@link ObjectMapper} configured with {@link\n+     * com.fasterxml.jackson.datatype.guava.GuavaModule} and {@link com.fasterxml.jackson.datatype.jdk7.Jdk7Module}.\n+     */\n+    public static FeignClientFactory standard(Request.Options timeoutOptions) {","path":"http-clients/src/main/java/com/palantir/remoting/http/FeignClients.java","position":29,"original_position":29,"commit_id":"a3eccf3edcf188274cb736aea9e27ed4b3494817","original_commit_id":"a3eccf3edcf188274cb736aea9e27ed4b3494817","user":{"login":"pnepywoda","id":13909400,"avatar_url":"https://avatars.githubusercontent.com/u/13909400?v=3","gravatar_id":"","url":"https://api.github.com/users/pnepywoda","html_url":"https://github.com/pnepywoda","followers_url":"https://api.github.com/users/pnepywoda/followers","following_url":"https://api.github.com/users/pnepywoda/following{/other_user}","gists_url":"https://api.github.com/users/pnepywoda/gists{/gist_id}","starred_url":"https://api.github.com/users/pnepywoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnepywoda/subscriptions","organizations_url":"https://api.github.com/users/pnepywoda/orgs","repos_url":"https://api.github.com/users/pnepywoda/repos","events_url":"https://api.github.com/users/pnepywoda/events{/privacy}","received_events_url":"https://api.github.com/users/pnepywoda/received_events","type":"User","site_admin":false},"body":"Ok. I'll wait patiently for a +1 ;)\n","created_at":"2016-02-25T19:48:48Z","updated_at":"2016-02-25T19:48:48Z","html_url":"https://github.com/palantir/http-remoting/pull/69#discussion_r54152850","pull_request_url":"https://api.github.com/repos/palantir/http-remoting/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/comments/54152850"},"html":{"href":"https://github.com/palantir/http-remoting/pull/69#discussion_r54152850"},"pull_request":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/http-remoting/pulls/69","id":60648070,"html_url":"https://github.com/palantir/http-remoting/pull/69","diff_url":"https://github.com/palantir/http-remoting/pull/69.diff","patch_url":"https://github.com/palantir/http-remoting/pull/69.patch","issue_url":"https://api.github.com/repos/palantir/http-remoting/issues/69","number":69,"state":"open","locked":false,"title":"allow specifying timeout options","user":{"login":"pnepywoda","id":13909400,"avatar_url":"https://avatars.githubusercontent.com/u/13909400?v=3","gravatar_id":"","url":"https://api.github.com/users/pnepywoda","html_url":"https://github.com/pnepywoda","followers_url":"https://api.github.com/users/pnepywoda/followers","following_url":"https://api.github.com/users/pnepywoda/following{/other_user}","gists_url":"https://api.github.com/users/pnepywoda/gists{/gist_id}","starred_url":"https://api.github.com/users/pnepywoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnepywoda/subscriptions","organizations_url":"https://api.github.com/users/pnepywoda/orgs","repos_url":"https://api.github.com/users/pnepywoda/repos","events_url":"https://api.github.com/users/pnepywoda/events{/privacy}","received_events_url":"https://api.github.com/users/pnepywoda/received_events","type":"User","site_admin":false},"body":"@markelliot @uschi2000 ","created_at":"2016-02-25T09:26:24Z","updated_at":"2016-02-25T19:48:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e725ae78a6cb3a7a5a50da604d626d194e04698f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/palantir/http-remoting/pulls/69/commits","review_comments_url":"https://api.github.com/repos/palantir/http-remoting/pulls/69/comments","review_comment_url":"https://api.github.com/repos/palantir/http-remoting/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/http-remoting/issues/69/comments","statuses_url":"https://api.github.com/repos/palantir/http-remoting/statuses/a3eccf3edcf188274cb736aea9e27ed4b3494817","head":{"label":"pnepywoda:timeout","ref":"timeout","sha":"a3eccf3edcf188274cb736aea9e27ed4b3494817","user":{"login":"pnepywoda","id":13909400,"avatar_url":"https://avatars.githubusercontent.com/u/13909400?v=3","gravatar_id":"","url":"https://api.github.com/users/pnepywoda","html_url":"https://github.com/pnepywoda","followers_url":"https://api.github.com/users/pnepywoda/followers","following_url":"https://api.github.com/users/pnepywoda/following{/other_user}","gists_url":"https://api.github.com/users/pnepywoda/gists{/gist_id}","starred_url":"https://api.github.com/users/pnepywoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnepywoda/subscriptions","organizations_url":"https://api.github.com/users/pnepywoda/orgs","repos_url":"https://api.github.com/users/pnepywoda/repos","events_url":"https://api.github.com/users/pnepywoda/events{/privacy}","received_events_url":"https://api.github.com/users/pnepywoda/received_events","type":"User","site_admin":false},"repo":{"id":47362072,"name":"http-remoting","full_name":"pnepywoda/http-remoting","owner":{"login":"pnepywoda","id":13909400,"avatar_url":"https://avatars.githubusercontent.com/u/13909400?v=3","gravatar_id":"","url":"https://api.github.com/users/pnepywoda","html_url":"https://github.com/pnepywoda","followers_url":"https://api.github.com/users/pnepywoda/followers","following_url":"https://api.github.com/users/pnepywoda/following{/other_user}","gists_url":"https://api.github.com/users/pnepywoda/gists{/gist_id}","starred_url":"https://api.github.com/users/pnepywoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnepywoda/subscriptions","organizations_url":"https://api.github.com/users/pnepywoda/orgs","repos_url":"https://api.github.com/users/pnepywoda/repos","events_url":"https://api.github.com/users/pnepywoda/events{/privacy}","received_events_url":"https://api.github.com/users/pnepywoda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pnepywoda/http-remoting","description":"","fork":true,"url":"https://api.github.com/repos/pnepywoda/http-remoting","forks_url":"https://api.github.com/repos/pnepywoda/http-remoting/forks","keys_url":"https://api.github.com/repos/pnepywoda/http-remoting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pnepywoda/http-remoting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pnepywoda/http-remoting/teams","hooks_url":"https://api.github.com/repos/pnepywoda/http-remoting/hooks","issue_events_url":"https://api.github.com/repos/pnepywoda/http-remoting/issues/events{/number}","events_url":"https://api.github.com/repos/pnepywoda/http-remoting/events","assignees_url":"https://api.github.com/repos/pnepywoda/http-remoting/assignees{/user}","branches_url":"https://api.github.com/repos/pnepywoda/http-remoting/branches{/branch}","tags_url":"https://api.github.com/repos/pnepywoda/http-remoting/tags","blobs_url":"https://api.github.com/repos/pnepywoda/http-remoting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pnepywoda/http-remoting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pnepywoda/http-remoting/git/refs{/sha}","trees_url":"https://api.github.com/repos/pnepywoda/http-remoting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pnepywoda/http-remoting/statuses/{sha}","languages_url":"https://api.github.com/repos/pnepywoda/http-remoting/languages","stargazers_url":"https://api.github.com/repos/pnepywoda/http-remoting/stargazers","contributors_url":"https://api.github.com/repos/pnepywoda/http-remoting/contributors","subscribers_url":"https://api.github.com/repos/pnepywoda/http-remoting/subscribers","subscription_url":"https://api.github.com/repos/pnepywoda/http-remoting/subscription","commits_url":"https://api.github.com/repos/pnepywoda/http-remoting/commits{/sha}","git_commits_url":"https://api.github.com/repos/pnepywoda/http-remoting/git/commits{/sha}","comments_url":"https://api.github.com/repos/pnepywoda/http-remoting/comments{/number}","issue_comment_url":"https://api.github.com/repos/pnepywoda/http-remoting/issues/comments{/number}","contents_url":"https://api.github.com/repos/pnepywoda/http-remoting/contents/{+path}","compare_url":"https://api.github.com/repos/pnepywoda/http-remoting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pnepywoda/http-remoting/merges","archive_url":"https://api.github.com/repos/pnepywoda/http-remoting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pnepywoda/http-remoting/downloads","issues_url":"https://api.github.com/repos/pnepywoda/http-remoting/issues{/number}","pulls_url":"https://api.github.com/repos/pnepywoda/http-remoting/pulls{/number}","milestones_url":"https://api.github.com/repos/pnepywoda/http-remoting/milestones{/number}","notifications_url":"https://api.github.com/repos/pnepywoda/http-remoting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pnepywoda/http-remoting/labels{/name}","releases_url":"https://api.github.com/repos/pnepywoda/http-remoting/releases{/id}","deployments_url":"https://api.github.com/repos/pnepywoda/http-remoting/deployments","created_at":"2015-12-03T21:33:09Z","updated_at":"2015-12-03T21:33:10Z","pushed_at":"2016-02-25T09:26:02Z","git_url":"git://github.com/pnepywoda/http-remoting.git","ssh_url":"git@github.com:pnepywoda/http-remoting.git","clone_url":"https://github.com/pnepywoda/http-remoting.git","svn_url":"https://github.com/pnepywoda/http-remoting","homepage":null,"size":252,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"bf30cc0008c6f30d6112c3b3cfcad65753fe4746","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":43088077,"name":"http-remoting","full_name":"palantir/http-remoting","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/http-remoting","description":"a collection of useful utilities for use with HTTP remoting setups that use Feign as a client and Jersey as a server","fork":false,"url":"https://api.github.com/repos/palantir/http-remoting","forks_url":"https://api.github.com/repos/palantir/http-remoting/forks","keys_url":"https://api.github.com/repos/palantir/http-remoting/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/http-remoting/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/http-remoting/teams","hooks_url":"https://api.github.com/repos/palantir/http-remoting/hooks","issue_events_url":"https://api.github.com/repos/palantir/http-remoting/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/http-remoting/events","assignees_url":"https://api.github.com/repos/palantir/http-remoting/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/http-remoting/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/http-remoting/tags","blobs_url":"https://api.github.com/repos/palantir/http-remoting/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/http-remoting/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/http-remoting/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/http-remoting/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/http-remoting/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/http-remoting/languages","stargazers_url":"https://api.github.com/repos/palantir/http-remoting/stargazers","contributors_url":"https://api.github.com/repos/palantir/http-remoting/contributors","subscribers_url":"https://api.github.com/repos/palantir/http-remoting/subscribers","subscription_url":"https://api.github.com/repos/palantir/http-remoting/subscription","commits_url":"https://api.github.com/repos/palantir/http-remoting/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/http-remoting/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/http-remoting/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/http-remoting/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/http-remoting/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/http-remoting/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/http-remoting/merges","archive_url":"https://api.github.com/repos/palantir/http-remoting/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/http-remoting/downloads","issues_url":"https://api.github.com/repos/palantir/http-remoting/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/http-remoting/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/http-remoting/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/http-remoting/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/http-remoting/labels{/name}","releases_url":"https://api.github.com/repos/palantir/http-remoting/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/http-remoting/deployments","created_at":"2015-09-24T19:24:22Z","updated_at":"2016-02-22T07:51:54Z","pushed_at":"2016-02-25T09:26:24Z","git_url":"git://github.com/palantir/http-remoting.git","ssh_url":"git@github.com:palantir/http-remoting.git","clone_url":"https://github.com/palantir/http-remoting.git","svn_url":"https://github.com/palantir/http-remoting","homepage":"","size":284,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":7,"forks":13,"open_issues":7,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/69"},"html":{"href":"https://github.com/palantir/http-remoting/pull/69"},"issue":{"href":"https://api.github.com/repos/palantir/http-remoting/issues/69"},"comments":{"href":"https://api.github.com/repos/palantir/http-remoting/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/http-remoting/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/http-remoting/statuses/a3eccf3edcf188274cb736aea9e27ed4b3494817"}}}}