{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/65640124","id":65640124,"diff_hunk":"@@ -0,0 +1,63 @@\n+/**\n+ * Copyright 2016 The AMP HTML Authors. All Rights Reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS-IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.ampproject;\n+\n+import com.google.javascript.jscomp.CodingConvention;\n+import com.google.javascript.jscomp.CodingConventions;\n+import com.google.javascript.jscomp.ClosureCodingConvention;\n+\n+\n+/**\n+ * A coding convention for AMP.\n+ */\n+public final class AmpCodingConvention extends CodingConventions.Proxy {\n+  /** By default, decorate the ClosureCodingConvention. */\n+  public AmpCodingConvention() {\n+    this(new ClosureCodingConvention());\n+  }\n+\n+  /** Decorates a wrapped CodingConvention. */\n+  public AmpCodingConvention(CodingConvention convention) {\n+    super(convention);\n+  }\n+\n+  /**\n+   * {@inheritDoc}\n+   * Because AMP objects can travel between compilation units, we consider\n+   * non-private methods exported.\n+   * Should we decide to do full-program compilation (for version bound JS\n+   * delivery), this could go away there.\n+   */\n+  @Override public boolean isExported(String name, boolean local) {\n+    if (local) {\n+      return false;\n+    }\n+    // ES6 generated module names are not exported.\n+    if (name.contains(\"$\")) {\n+      return false;\n+    }\n+    // We do not export class names and similar by default.\n+    if (Character.isUpperCase(name.charAt(0))) {\n+      return false;\n+    }\n+    // Starting with _ explicitly exports a name.\n+    if (name.startsWith(\"_\")) {\n+      return true;\n+    }\n+    return !name.endsWith(\"_\") && !name.endsWith(\"ForTesting\");","path":"build-system/runner/src/org/ampproject/AmpCodingConvention.java","position":61,"original_position":61,"commit_id":"2dc035b1e5805a05409aa1d11bf0e608db2a480b","original_commit_id":"2dc035b1e5805a05409aa1d11bf0e608db2a480b","user":{"login":"erwinmombay","id":354746,"avatar_url":"https://avatars.githubusercontent.com/u/354746?v=3","gravatar_id":"","url":"https://api.github.com/users/erwinmombay","html_url":"https://github.com/erwinmombay","followers_url":"https://api.github.com/users/erwinmombay/followers","following_url":"https://api.github.com/users/erwinmombay/following{/other_user}","gists_url":"https://api.github.com/users/erwinmombay/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinmombay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinmombay/subscriptions","organizations_url":"https://api.github.com/users/erwinmombay/orgs","repos_url":"https://api.github.com/users/erwinmombay/repos","events_url":"https://api.github.com/users/erwinmombay/events{/privacy}","received_events_url":"https://api.github.com/users/erwinmombay/received_events","type":"User","site_admin":false},"body":"do we need the fortesting check? they do eventually get dce'd since there's no usage of them in the source (besides test)","created_at":"2016-06-03T00:10:42Z","updated_at":"2016-06-03T00:10:42Z","html_url":"https://github.com/ampproject/amphtml/pull/3223#discussion_r65640124","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/3223","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/65640124"},"html":{"href":"https://github.com/ampproject/amphtml/pull/3223#discussion_r65640124"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/3223"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/3223","id":70124892,"html_url":"https://github.com/ampproject/amphtml/pull/3223","diff_url":"https://github.com/ampproject/amphtml/pull/3223.diff","patch_url":"https://github.com/ampproject/amphtml/pull/3223.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/3223","number":3223,"state":"open","locked":false,"title":"Turn on more aggressive compiler optimizations.","user":{"login":"cramforce","id":89679,"avatar_url":"https://avatars.githubusercontent.com/u/89679?v=3","gravatar_id":"","url":"https://api.github.com/users/cramforce","html_url":"https://github.com/cramforce","followers_url":"https://api.github.com/users/cramforce/followers","following_url":"https://api.github.com/users/cramforce/following{/other_user}","gists_url":"https://api.github.com/users/cramforce/gists{/gist_id}","starred_url":"https://api.github.com/users/cramforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramforce/subscriptions","organizations_url":"https://api.github.com/users/cramforce/orgs","repos_url":"https://api.github.com/users/cramforce/repos","events_url":"https://api.github.com/users/cramforce/events{/privacy}","received_events_url":"https://api.github.com/users/cramforce/received_events","type":"User","site_admin":false},"body":"- allows devirtualization of private methods.\r\n- allows renaming of private properties and methods.\r\n- Aliases `.prototype.` pattern where useful.\r\n- other less important optimizations.\r\n\r\nImplements a coding convention for AMP that marks all properties not ending in `_` as exported (so they can travel between co\\\r\nmpilation units).\r\n\r\nThis change by itself has little size impact, but should make our code quite a bit tighter to execute, because many virtual p\\\r\nrivate method calls because function calls. Primarily this is a preparation to turn on private property renaming when the ups\\\r\ntream change lands in closure compiler.","created_at":"2016-05-15T15:51:21Z","updated_at":"2016-06-03T00:10:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27b58c28c2f9331221de170bd9d6deb2c86199fb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/3223/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/3223/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/3223/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/2dc035b1e5805a05409aa1d11bf0e608db2a480b","head":{"label":"cramforce:nocollapse","ref":"nocollapse","sha":"2dc035b1e5805a05409aa1d11bf0e608db2a480b","user":{"login":"cramforce","id":89679,"avatar_url":"https://avatars.githubusercontent.com/u/89679?v=3","gravatar_id":"","url":"https://api.github.com/users/cramforce","html_url":"https://github.com/cramforce","followers_url":"https://api.github.com/users/cramforce/followers","following_url":"https://api.github.com/users/cramforce/following{/other_user}","gists_url":"https://api.github.com/users/cramforce/gists{/gist_id}","starred_url":"https://api.github.com/users/cramforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramforce/subscriptions","organizations_url":"https://api.github.com/users/cramforce/orgs","repos_url":"https://api.github.com/users/cramforce/repos","events_url":"https://api.github.com/users/cramforce/events{/privacy}","received_events_url":"https://api.github.com/users/cramforce/received_events","type":"User","site_admin":false},"repo":{"id":43817601,"name":"amphtml","full_name":"cramforce/amphtml","owner":{"login":"cramforce","id":89679,"avatar_url":"https://avatars.githubusercontent.com/u/89679?v=3","gravatar_id":"","url":"https://api.github.com/users/cramforce","html_url":"https://github.com/cramforce","followers_url":"https://api.github.com/users/cramforce/followers","following_url":"https://api.github.com/users/cramforce/following{/other_user}","gists_url":"https://api.github.com/users/cramforce/gists{/gist_id}","starred_url":"https://api.github.com/users/cramforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cramforce/subscriptions","organizations_url":"https://api.github.com/users/cramforce/orgs","repos_url":"https://api.github.com/users/cramforce/repos","events_url":"https://api.github.com/users/cramforce/events{/privacy}","received_events_url":"https://api.github.com/users/cramforce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cramforce/amphtml","description":"","fork":true,"url":"https://api.github.com/repos/cramforce/amphtml","forks_url":"https://api.github.com/repos/cramforce/amphtml/forks","keys_url":"https://api.github.com/repos/cramforce/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cramforce/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cramforce/amphtml/teams","hooks_url":"https://api.github.com/repos/cramforce/amphtml/hooks","issue_events_url":"https://api.github.com/repos/cramforce/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/cramforce/amphtml/events","assignees_url":"https://api.github.com/repos/cramforce/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/cramforce/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/cramforce/amphtml/tags","blobs_url":"https://api.github.com/repos/cramforce/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cramforce/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cramforce/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/cramforce/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cramforce/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/cramforce/amphtml/languages","stargazers_url":"https://api.github.com/repos/cramforce/amphtml/stargazers","contributors_url":"https://api.github.com/repos/cramforce/amphtml/contributors","subscribers_url":"https://api.github.com/repos/cramforce/amphtml/subscribers","subscription_url":"https://api.github.com/repos/cramforce/amphtml/subscription","commits_url":"https://api.github.com/repos/cramforce/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/cramforce/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/cramforce/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/cramforce/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/cramforce/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/cramforce/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cramforce/amphtml/merges","archive_url":"https://api.github.com/repos/cramforce/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cramforce/amphtml/downloads","issues_url":"https://api.github.com/repos/cramforce/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/cramforce/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/cramforce/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/cramforce/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cramforce/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/cramforce/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/cramforce/amphtml/deployments","created_at":"2015-10-07T13:28:45Z","updated_at":"2015-10-07T13:28:46Z","pushed_at":"2016-06-03T00:09:35Z","git_url":"git://github.com/cramforce/amphtml.git","ssh_url":"git@github.com:cramforce/amphtml.git","clone_url":"https://github.com/cramforce/amphtml.git","svn_url":"https://github.com/cramforce/amphtml","homepage":"","size":59702,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"89575360a7266cc693e4792fd9f4f07e00cf1f99","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2016-06-02T23:45:49Z","pushed_at":"2016-06-03T00:09:33Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":76711,"stargazers_count":7574,"watchers_count":7574,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1024,"mirror_url":null,"open_issues_count":461,"forks":1024,"open_issues":461,"watchers":7574,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/3223"},"html":{"href":"https://github.com/ampproject/amphtml/pull/3223"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/3223"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/3223/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/3223/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/3223/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/2dc035b1e5805a05409aa1d11bf0e608db2a480b"}}}}
{"actor":{"display_login":"erwinmombay"}}