{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/comments/86444193","pull_request_review_id":7104743,"id":86444193,"diff_hunk":"@@ -58,12 +386,39 @@ vol        datastore1  detached\n Note that the that the choices are given in a comma separated list with no spaces, and are shown in\n the help given above with `vmdkops_admin ls -h`.\n \n-# policy\n+### Set\n+Modify attribute settings on a given volume. The volume is identified by its name and datastore,\n+for example if the volume name is `container-vol` then the volume is specified as \"container-vol@datastore-name\".\n+The attributes to set/modify are specified as a comma separated list as \"<attr1>=<value>, <attr2>=<value>....\". For example,\n+a command line would look like this.\n+\n+```bash\n+$ vmdkops-admin set --volume=<volume@datastore> --options=\"<attr1>=<value>, <attr2>=<value>, ...\"\n+```\n+\n+The volume attributes are set and take effect only the next time the volume attached to a VM. The changes do not impact any VM\n+thats currently using the volume. For the present, only the \"access\" attribute is supported to be modified via this command, and","path":"docs/user-guide/admin-cli.md","position":397,"original_position":397,"commit_id":"cc78eacfe347a6169db3b1f868aa6a5fe50b7fd4","original_commit_id":"7aab6399b0c9f2b7860fe68b99f540c0269044cc","user":{"login":"kerneltime","id":774455,"avatar_url":"https://avatars.githubusercontent.com/u/774455?v=3","gravatar_id":"","url":"https://api.github.com/users/kerneltime","html_url":"https://github.com/kerneltime","followers_url":"https://api.github.com/users/kerneltime/followers","following_url":"https://api.github.com/users/kerneltime/following{/other_user}","gists_url":"https://api.github.com/users/kerneltime/gists{/gist_id}","starred_url":"https://api.github.com/users/kerneltime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kerneltime/subscriptions","organizations_url":"https://api.github.com/users/kerneltime/orgs","repos_url":"https://api.github.com/users/kerneltime/repos","events_url":"https://api.github.com/users/kerneltime/events{/privacy}","received_events_url":"https://api.github.com/users/kerneltime/received_events","type":"User","site_admin":false},"body":"It does not show up in help, when the help us updated we can update the documentation.\r\n```\r\n[root@localhost:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py set -h\r\nusage: vmdkops_admin.py set [-h] --volume VOLUME --options OPTIONS\r\n\r\noptional arguments:\r\n  -h, --help         show this help message and exit\r\n  --volume VOLUME    Volume to set options for, specified as\r\n                     \"volume@datastore\".\r\n  --options OPTIONS  Options (specifically, access) to be set on the volume.\r\n```","created_at":"2016-11-03T21:10:51Z","updated_at":"2016-11-03T21:10:52Z","html_url":"https://github.com/vmware/docker-volume-vsphere/pull/689#discussion_r86444193","pull_request_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/689","_links":{"self":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/comments/86444193"},"html":{"href":"https://github.com/vmware/docker-volume-vsphere/pull/689#discussion_r86444193"},"pull_request":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/689"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/689","id":92079562,"html_url":"https://github.com/vmware/docker-volume-vsphere/pull/689","diff_url":"https://github.com/vmware/docker-volume-vsphere/pull/689.diff","patch_url":"https://github.com/vmware/docker-volume-vsphere/pull/689.patch","issue_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/689","number":689,"state":"open","locked":false,"title":"Add documentation for tenancy.","user":{"login":"kerneltime","id":774455,"avatar_url":"https://avatars.githubusercontent.com/u/774455?v=3","gravatar_id":"","url":"https://api.github.com/users/kerneltime","html_url":"https://github.com/kerneltime","followers_url":"https://api.github.com/users/kerneltime/followers","following_url":"https://api.github.com/users/kerneltime/following{/other_user}","gists_url":"https://api.github.com/users/kerneltime/gists{/gist_id}","starred_url":"https://api.github.com/users/kerneltime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kerneltime/subscriptions","organizations_url":"https://api.github.com/users/kerneltime/orgs","repos_url":"https://api.github.com/users/kerneltime/repos","events_url":"https://api.github.com/users/kerneltime/events{/privacy}","received_events_url":"https://api.github.com/users/kerneltime/received_events","type":"User","site_admin":false},"body":"Add documentation for github page.\r\nFixes #687","created_at":"2016-11-03T00:13:23Z","updated_at":"2016-11-03T21:10:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"644b29ecd330d0d3a898259d91b4502e4f8a0c88","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/689/commits","review_comments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/689/comments","review_comment_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/689/comments","statuses_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/statuses/cc78eacfe347a6169db3b1f868aa6a5fe50b7fd4","head":{"label":"vmware:tenancy-doc-n-fix.kerneltime","ref":"tenancy-doc-n-fix.kerneltime","sha":"cc78eacfe347a6169db3b1f868aa6a5fe50b7fd4","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49599693,"name":"docker-volume-vsphere","full_name":"vmware/docker-volume-vsphere","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/docker-volume-vsphere","description":"Docker Volume Driver for vSphere.","fork":false,"url":"https://api.github.com/repos/vmware/docker-volume-vsphere","forks_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/forks","keys_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/teams","hooks_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/hooks","issue_events_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/events","assignees_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/tags","blobs_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/languages","stargazers_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/stargazers","contributors_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/contributors","subscribers_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/subscribers","subscription_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/subscription","commits_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/merges","archive_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/downloads","issues_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/labels{/name}","releases_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/deployments","created_at":"2016-01-13T20:25:36Z","updated_at":"2016-11-01T09:27:56Z","pushed_at":"2016-11-03T20:54:52Z","git_url":"git://github.com/vmware/docker-volume-vsphere.git","ssh_url":"git@github.com:vmware/docker-volume-vsphere.git","clone_url":"https://github.com/vmware/docker-volume-vsphere.git","svn_url":"https://github.com/vmware/docker-volume-vsphere","homepage":"https://vmware.github.io/docker-volume-vsphere","size":8457,"stargazers_count":78,"watchers_count":78,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":20,"mirror_url":null,"open_issues_count":119,"forks":20,"open_issues":119,"watchers":78,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"738f704625d23defafb5632dfc9360062cbf2e66","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49599693,"name":"docker-volume-vsphere","full_name":"vmware/docker-volume-vsphere","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/docker-volume-vsphere","description":"Docker Volume Driver for vSphere.","fork":false,"url":"https://api.github.com/repos/vmware/docker-volume-vsphere","forks_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/forks","keys_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/teams","hooks_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/hooks","issue_events_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/events","assignees_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/tags","blobs_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/languages","stargazers_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/stargazers","contributors_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/contributors","subscribers_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/subscribers","subscription_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/subscription","commits_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/merges","archive_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/downloads","issues_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/labels{/name}","releases_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/deployments","created_at":"2016-01-13T20:25:36Z","updated_at":"2016-11-01T09:27:56Z","pushed_at":"2016-11-03T20:54:52Z","git_url":"git://github.com/vmware/docker-volume-vsphere.git","ssh_url":"git@github.com:vmware/docker-volume-vsphere.git","clone_url":"https://github.com/vmware/docker-volume-vsphere.git","svn_url":"https://github.com/vmware/docker-volume-vsphere","homepage":"https://vmware.github.io/docker-volume-vsphere","size":8457,"stargazers_count":78,"watchers_count":78,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":20,"mirror_url":null,"open_issues_count":119,"forks":20,"open_issues":119,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/689"},"html":{"href":"https://github.com/vmware/docker-volume-vsphere/pull/689"},"issue":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/689"},"comments":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/689/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/689/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/689/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/statuses/cc78eacfe347a6169db3b1f868aa6a5fe50b7fd4"}}}}
{"actor":{"display_login":"kerneltime"}}