{"action":"closed","number":158,"pull_request":{"url":"https://api.github.com/repos/data-cube/agdc-v2/pulls/158","id":85154954,"html_url":"https://github.com/data-cube/agdc-v2/pull/158","diff_url":"https://github.com/data-cube/agdc-v2/pull/158.diff","patch_url":"https://github.com/data-cube/agdc-v2/pull/158.patch","issue_url":"https://api.github.com/repos/data-cube/agdc-v2/issues/158","number":158,"state":"closed","locked":false,"title":"Add support for gridspec origin convention","user":{"login":"ceholden","id":3585769,"avatar_url":"https://avatars.githubusercontent.com/u/3585769?v=3","gravatar_id":"","url":"https://api.github.com/users/ceholden","html_url":"https://github.com/ceholden","followers_url":"https://api.github.com/users/ceholden/followers","following_url":"https://api.github.com/users/ceholden/following{/other_user}","gists_url":"https://api.github.com/users/ceholden/gists{/gist_id}","starred_url":"https://api.github.com/users/ceholden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceholden/subscriptions","organizations_url":"https://api.github.com/users/ceholden/orgs","repos_url":"https://api.github.com/users/ceholden/repos","events_url":"https://api.github.com/users/ceholden/events{/privacy}","received_events_url":"https://api.github.com/users/ceholden/received_events","type":"User","site_admin":false},"body":"This addition follows the addition of `origin` to the `GridSpec` configuration in helping to make tiled data output from the ingestion compatible with existing gridded data. The `origin` specification allows the data to co-align and this proposed change would also allow the tile indexes to be identical by allowing users to count indexes relative to an upper left instead of the current bottom left. My interest in this change comes from wanting our tiled data to be in line with data from the Landsat WELD project grid specification (which IIRC is also being used for the USGS LCMAP project).\r\n\r\nI've added a test that was validated against the WELD tile lookup calculator, and I've also run an ingest with the proposed changes. The tile indices created from this ingest run using `convention = \"upperleft\"` match and since the `origin` addition the tiles also coalign. The current \"convention\" of counting from the bottom left is still default and I don't think I've affected any calculations for that case.\r\n\r\nHappy to iterate on any aspect of this with you all. Thanks!","created_at":"2016-09-14T01:53:37Z","updated_at":"2016-09-14T13:48:56Z","closed_at":"2016-09-14T13:48:56Z","merged_at":null,"merge_commit_sha":"befefc4b8097e29350403a84083890ba086d57b4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/data-cube/agdc-v2/pulls/158/commits","review_comments_url":"https://api.github.com/repos/data-cube/agdc-v2/pulls/158/comments","review_comment_url":"https://api.github.com/repos/data-cube/agdc-v2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/data-cube/agdc-v2/issues/158/comments","statuses_url":"https://api.github.com/repos/data-cube/agdc-v2/statuses/8b00217e1ec3725c37f4d6678810fc39d78856c9","head":{"label":"ceholden:develop","ref":"develop","sha":"8b00217e1ec3725c37f4d6678810fc39d78856c9","user":{"login":"ceholden","id":3585769,"avatar_url":"https://avatars.githubusercontent.com/u/3585769?v=3","gravatar_id":"","url":"https://api.github.com/users/ceholden","html_url":"https://github.com/ceholden","followers_url":"https://api.github.com/users/ceholden/followers","following_url":"https://api.github.com/users/ceholden/following{/other_user}","gists_url":"https://api.github.com/users/ceholden/gists{/gist_id}","starred_url":"https://api.github.com/users/ceholden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceholden/subscriptions","organizations_url":"https://api.github.com/users/ceholden/orgs","repos_url":"https://api.github.com/users/ceholden/repos","events_url":"https://api.github.com/users/ceholden/events{/privacy}","received_events_url":"https://api.github.com/users/ceholden/received_events","type":"User","site_admin":false},"repo":{"id":64338272,"name":"agdc-v2","full_name":"ceholden/agdc-v2","owner":{"login":"ceholden","id":3585769,"avatar_url":"https://avatars.githubusercontent.com/u/3585769?v=3","gravatar_id":"","url":"https://api.github.com/users/ceholden","html_url":"https://github.com/ceholden","followers_url":"https://api.github.com/users/ceholden/followers","following_url":"https://api.github.com/users/ceholden/following{/other_user}","gists_url":"https://api.github.com/users/ceholden/gists{/gist_id}","starred_url":"https://api.github.com/users/ceholden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceholden/subscriptions","organizations_url":"https://api.github.com/users/ceholden/orgs","repos_url":"https://api.github.com/users/ceholden/repos","events_url":"https://api.github.com/users/ceholden/events{/privacy}","received_events_url":"https://api.github.com/users/ceholden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ceholden/agdc-v2","description":"Australian Geoscience Data Cube ","fork":true,"url":"https://api.github.com/repos/ceholden/agdc-v2","forks_url":"https://api.github.com/repos/ceholden/agdc-v2/forks","keys_url":"https://api.github.com/repos/ceholden/agdc-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceholden/agdc-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceholden/agdc-v2/teams","hooks_url":"https://api.github.com/repos/ceholden/agdc-v2/hooks","issue_events_url":"https://api.github.com/repos/ceholden/agdc-v2/issues/events{/number}","events_url":"https://api.github.com/repos/ceholden/agdc-v2/events","assignees_url":"https://api.github.com/repos/ceholden/agdc-v2/assignees{/user}","branches_url":"https://api.github.com/repos/ceholden/agdc-v2/branches{/branch}","tags_url":"https://api.github.com/repos/ceholden/agdc-v2/tags","blobs_url":"https://api.github.com/repos/ceholden/agdc-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceholden/agdc-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceholden/agdc-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceholden/agdc-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceholden/agdc-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/ceholden/agdc-v2/languages","stargazers_url":"https://api.github.com/repos/ceholden/agdc-v2/stargazers","contributors_url":"https://api.github.com/repos/ceholden/agdc-v2/contributors","subscribers_url":"https://api.github.com/repos/ceholden/agdc-v2/subscribers","subscription_url":"https://api.github.com/repos/ceholden/agdc-v2/subscription","commits_url":"https://api.github.com/repos/ceholden/agdc-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceholden/agdc-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceholden/agdc-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceholden/agdc-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceholden/agdc-v2/contents/{+path}","compare_url":"https://api.github.com/repos/ceholden/agdc-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceholden/agdc-v2/merges","archive_url":"https://api.github.com/repos/ceholden/agdc-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceholden/agdc-v2/downloads","issues_url":"https://api.github.com/repos/ceholden/agdc-v2/issues{/number}","pulls_url":"https://api.github.com/repos/ceholden/agdc-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/ceholden/agdc-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/ceholden/agdc-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceholden/agdc-v2/labels{/name}","releases_url":"https://api.github.com/repos/ceholden/agdc-v2/releases{/id}","deployments_url":"https://api.github.com/repos/ceholden/agdc-v2/deployments","created_at":"2016-07-27T20:06:30Z","updated_at":"2016-07-27T20:06:32Z","pushed_at":"2016-09-14T13:48:56Z","git_url":"git://github.com/ceholden/agdc-v2.git","ssh_url":"git@github.com:ceholden/agdc-v2.git","clone_url":"https://github.com/ceholden/agdc-v2.git","svn_url":"https://github.com/ceholden/agdc-v2","homepage":"http://www.datacube.org.au","size":33341,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"data-cube:develop","ref":"develop","sha":"8b00217e1ec3725c37f4d6678810fc39d78856c9","user":{"login":"data-cube","id":12890156,"avatar_url":"https://avatars.githubusercontent.com/u/12890156?v=3","gravatar_id":"","url":"https://api.github.com/users/data-cube","html_url":"https://github.com/data-cube","followers_url":"https://api.github.com/users/data-cube/followers","following_url":"https://api.github.com/users/data-cube/following{/other_user}","gists_url":"https://api.github.com/users/data-cube/gists{/gist_id}","starred_url":"https://api.github.com/users/data-cube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/data-cube/subscriptions","organizations_url":"https://api.github.com/users/data-cube/orgs","repos_url":"https://api.github.com/users/data-cube/repos","events_url":"https://api.github.com/users/data-cube/events{/privacy}","received_events_url":"https://api.github.com/users/data-cube/received_events","type":"Organization","site_admin":false},"repo":{"id":35531022,"name":"agdc-v2","full_name":"data-cube/agdc-v2","owner":{"login":"data-cube","id":12890156,"avatar_url":"https://avatars.githubusercontent.com/u/12890156?v=3","gravatar_id":"","url":"https://api.github.com/users/data-cube","html_url":"https://github.com/data-cube","followers_url":"https://api.github.com/users/data-cube/followers","following_url":"https://api.github.com/users/data-cube/following{/other_user}","gists_url":"https://api.github.com/users/data-cube/gists{/gist_id}","starred_url":"https://api.github.com/users/data-cube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/data-cube/subscriptions","organizations_url":"https://api.github.com/users/data-cube/orgs","repos_url":"https://api.github.com/users/data-cube/repos","events_url":"https://api.github.com/users/data-cube/events{/privacy}","received_events_url":"https://api.github.com/users/data-cube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/data-cube/agdc-v2","description":"Australian Geoscience Data Cube ","fork":true,"url":"https://api.github.com/repos/data-cube/agdc-v2","forks_url":"https://api.github.com/repos/data-cube/agdc-v2/forks","keys_url":"https://api.github.com/repos/data-cube/agdc-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/data-cube/agdc-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/data-cube/agdc-v2/teams","hooks_url":"https://api.github.com/repos/data-cube/agdc-v2/hooks","issue_events_url":"https://api.github.com/repos/data-cube/agdc-v2/issues/events{/number}","events_url":"https://api.github.com/repos/data-cube/agdc-v2/events","assignees_url":"https://api.github.com/repos/data-cube/agdc-v2/assignees{/user}","branches_url":"https://api.github.com/repos/data-cube/agdc-v2/branches{/branch}","tags_url":"https://api.github.com/repos/data-cube/agdc-v2/tags","blobs_url":"https://api.github.com/repos/data-cube/agdc-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/data-cube/agdc-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/data-cube/agdc-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/data-cube/agdc-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/data-cube/agdc-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/data-cube/agdc-v2/languages","stargazers_url":"https://api.github.com/repos/data-cube/agdc-v2/stargazers","contributors_url":"https://api.github.com/repos/data-cube/agdc-v2/contributors","subscribers_url":"https://api.github.com/repos/data-cube/agdc-v2/subscribers","subscription_url":"https://api.github.com/repos/data-cube/agdc-v2/subscription","commits_url":"https://api.github.com/repos/data-cube/agdc-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/data-cube/agdc-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/data-cube/agdc-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/data-cube/agdc-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/data-cube/agdc-v2/contents/{+path}","compare_url":"https://api.github.com/repos/data-cube/agdc-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/data-cube/agdc-v2/merges","archive_url":"https://api.github.com/repos/data-cube/agdc-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/data-cube/agdc-v2/downloads","issues_url":"https://api.github.com/repos/data-cube/agdc-v2/issues{/number}","pulls_url":"https://api.github.com/repos/data-cube/agdc-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/data-cube/agdc-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/data-cube/agdc-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/data-cube/agdc-v2/labels{/name}","releases_url":"https://api.github.com/repos/data-cube/agdc-v2/releases{/id}","deployments_url":"https://api.github.com/repos/data-cube/agdc-v2/deployments","created_at":"2015-05-13T05:58:13Z","updated_at":"2016-09-12T07:41:34Z","pushed_at":"2016-09-14T04:37:53Z","git_url":"git://github.com/data-cube/agdc-v2.git","ssh_url":"git@github.com:data-cube/agdc-v2.git","clone_url":"https://github.com/data-cube/agdc-v2.git","svn_url":"https://github.com/data-cube/agdc-v2","homepage":"http://www.datacube.org.au","size":34408,"stargazers_count":28,"watchers_count":28,"language":"Jupyter Notebook","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":17,"forks":12,"open_issues":17,"watchers":28,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/data-cube/agdc-v2/pulls/158"},"html":{"href":"https://github.com/data-cube/agdc-v2/pull/158"},"issue":{"href":"https://api.github.com/repos/data-cube/agdc-v2/issues/158"},"comments":{"href":"https://api.github.com/repos/data-cube/agdc-v2/issues/158/comments"},"review_comments":{"href":"https://api.github.com/repos/data-cube/agdc-v2/pulls/158/comments"},"review_comment":{"href":"https://api.github.com/repos/data-cube/agdc-v2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/data-cube/agdc-v2/pulls/158/commits"},"statuses":{"href":"https://api.github.com/repos/data-cube/agdc-v2/statuses/8b00217e1ec3725c37f4d6678810fc39d78856c9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":3,"review_comments":0,"commits":0,"additions":0,"deletions":0,"changed_files":0}}
{"actor":{"display_login":"ceholden"}}