{"action":"created","comment":{"url":"https://api.github.com/repos/excaliburjs/Excalibur/pulls/comments/92954307","pull_request_review_id":13475540,"id":92954307,"diff_hunk":"@@ -0,0 +1,8 @@\n+{\n+    \"compilerOptions\": {\n+        \"out\": \"../dist/Excalibur.js\", ","path":"src/spec/tsconfig.json","position":3,"original_position":3,"commit_id":"8bd1330098b45276aaf69ad3e158e69e7970b8cd","original_commit_id":"8bd1330098b45276aaf69ad3e158e69e7970b8cd","user":{"login":"eonarheim","id":612071,"avatar_url":"https://avatars.githubusercontent.com/u/612071?v=3","gravatar_id":"","url":"https://api.github.com/users/eonarheim","html_url":"https://github.com/eonarheim","followers_url":"https://api.github.com/users/eonarheim/followers","following_url":"https://api.github.com/users/eonarheim/following{/other_user}","gists_url":"https://api.github.com/users/eonarheim/gists{/gist_id}","starred_url":"https://api.github.com/users/eonarheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eonarheim/subscriptions","organizations_url":"https://api.github.com/users/eonarheim/orgs","repos_url":"https://api.github.com/users/eonarheim/repos","events_url":"https://api.github.com/users/eonarheim/events{/privacy}","received_events_url":"https://api.github.com/users/eonarheim/received_events","type":"User","site_admin":false},"body":"It doesn't look like it does, I think it is because we have a custom grunt task. If you ran `tsc` in the directory it would. I really only added this tsconfig so that vscode wouldn't complain about the decorators.","created_at":"2016-12-18T23:44:48Z","updated_at":"2016-12-18T23:44:48Z","html_url":"https://github.com/excaliburjs/Excalibur/pull/728#discussion_r92954307","pull_request_url":"https://api.github.com/repos/excaliburjs/Excalibur/pulls/728","_links":{"self":{"href":"https://api.github.com/repos/excaliburjs/Excalibur/pulls/comments/92954307"},"html":{"href":"https://github.com/excaliburjs/Excalibur/pull/728#discussion_r92954307"},"pull_request":{"href":"https://api.github.com/repos/excaliburjs/Excalibur/pulls/728"}}},"pull_request":{"url":"https://api.github.com/repos/excaliburjs/Excalibur/pulls/728","id":97438839,"html_url":"https://github.com/excaliburjs/Excalibur/pull/728","diff_url":"https://github.com/excaliburjs/Excalibur/pull/728.diff","patch_url":"https://github.com/excaliburjs/Excalibur/pull/728.patch","issue_url":"https://api.github.com/repos/excaliburjs/Excalibur/issues/728","number":728,"state":"open","locked":false,"title":"[#684] Implement Obsolete Decorator","user":{"login":"eonarheim","id":612071,"avatar_url":"https://avatars.githubusercontent.com/u/612071?v=3","gravatar_id":"","url":"https://api.github.com/users/eonarheim","html_url":"https://github.com/eonarheim","followers_url":"https://api.github.com/users/eonarheim/followers","following_url":"https://api.github.com/users/eonarheim/following{/other_user}","gists_url":"https://api.github.com/users/eonarheim/gists{/gist_id}","starred_url":"https://api.github.com/users/eonarheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eonarheim/subscriptions","organizations_url":"https://api.github.com/users/eonarheim/orgs","repos_url":"https://api.github.com/users/eonarheim/repos","events_url":"https://api.github.com/users/eonarheim/events{/privacy}","received_events_url":"https://api.github.com/users/eonarheim/received_events","type":"User","site_admin":false},"body":"Closes #684 \r\n\r\n## Changes:\r\n\r\n- Implement `@obsolete` decorator with the ability to pass a custom message and/or suggest a suitable alternative method\r\n- Mark `exPromise.wrap` and `exEngine.fps` as `@obsolete`\r\n- Update grunt build and tsconfig.json to include the `experimentalDecorators` flag\r\n\r\nOne thing to note, is that the decorator api **only works on functions/getters/setters** so if you want to make a particular property obsolete, you'll need to refactor it into getter/setter and decorate accordingly.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/612071/21076294/57fb2f98-beed-11e6-8757-23cbe7b8f592.png)\r\n\r\nThis is what shows up in the console when attempting to use a decorated method.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/612071/21076317/db29c3e8-beed-11e6-8e4a-a420d2d058fc.png)\r\n\r\n","created_at":"2016-12-10T21:34:36Z","updated_at":"2016-12-18T23:44:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ff9cb200b4eb481c1aae6937790861cea9808ae","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/excaliburjs/Excalibur/milestones/12","html_url":"https://github.com/excaliburjs/Excalibur/milestone/12","labels_url":"https://api.github.com/repos/excaliburjs/Excalibur/milestones/12/labels","id":1953399,"number":12,"title":"0.9.0 Release","description":"","creator":{"login":"jedeen","id":675840,"avatar_url":"https://avatars.githubusercontent.com/u/675840?v=3","gravatar_id":"","url":"https://api.github.com/users/jedeen","html_url":"https://github.com/jedeen","followers_url":"https://api.github.com/users/jedeen/followers","following_url":"https://api.github.com/users/jedeen/following{/other_user}","gists_url":"https://api.github.com/users/jedeen/gists{/gist_id}","starred_url":"https://api.github.com/users/jedeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedeen/subscriptions","organizations_url":"https://api.github.com/users/jedeen/orgs","repos_url":"https://api.github.com/users/jedeen/repos","events_url":"https://api.github.com/users/jedeen/events{/privacy}","received_events_url":"https://api.github.com/users/jedeen/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":10,"state":"open","created_at":"2016-08-21T06:58:46Z","updated_at":"2016-12-18T23:27:13Z","due_on":"2017-01-31T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/excaliburjs/Excalibur/pulls/728/commits","review_comments_url":"https://api.github.com/repos/excaliburjs/Excalibur/pulls/728/comments","review_comment_url":"https://api.github.com/repos/excaliburjs/Excalibur/pulls/comments{/number}","comments_url":"https://api.github.com/repos/excaliburjs/Excalibur/issues/728/comments","statuses_url":"https://api.github.com/repos/excaliburjs/Excalibur/statuses/8bd1330098b45276aaf69ad3e158e69e7970b8cd","head":{"label":"excaliburjs:684-implement-obsolete-decorator","ref":"684-implement-obsolete-decorator","sha":"8bd1330098b45276aaf69ad3e158e69e7970b8cd","user":{"login":"excaliburjs","id":6165683,"avatar_url":"https://avatars.githubusercontent.com/u/6165683?v=3","gravatar_id":"","url":"https://api.github.com/users/excaliburjs","html_url":"https://github.com/excaliburjs","followers_url":"https://api.github.com/users/excaliburjs/followers","following_url":"https://api.github.com/users/excaliburjs/following{/other_user}","gists_url":"https://api.github.com/users/excaliburjs/gists{/gist_id}","starred_url":"https://api.github.com/users/excaliburjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/excaliburjs/subscriptions","organizations_url":"https://api.github.com/users/excaliburjs/orgs","repos_url":"https://api.github.com/users/excaliburjs/repos","events_url":"https://api.github.com/users/excaliburjs/events{/privacy}","received_events_url":"https://api.github.com/users/excaliburjs/received_events","type":"Organization","site_admin":false},"repo":{"id":7457728,"name":"Excalibur","full_name":"excaliburjs/Excalibur","owner":{"login":"excaliburjs","id":6165683,"avatar_url":"https://avatars.githubusercontent.com/u/6165683?v=3","gravatar_id":"","url":"https://api.github.com/users/excaliburjs","html_url":"https://github.com/excaliburjs","followers_url":"https://api.github.com/users/excaliburjs/followers","following_url":"https://api.github.com/users/excaliburjs/following{/other_user}","gists_url":"https://api.github.com/users/excaliburjs/gists{/gist_id}","starred_url":"https://api.github.com/users/excaliburjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/excaliburjs/subscriptions","organizations_url":"https://api.github.com/users/excaliburjs/orgs","repos_url":"https://api.github.com/users/excaliburjs/repos","events_url":"https://api.github.com/users/excaliburjs/events{/privacy}","received_events_url":"https://api.github.com/users/excaliburjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/excaliburjs/Excalibur","description":"🎮 A simple HTML5 Canvas game engine written in TypeScript","fork":false,"url":"https://api.github.com/repos/excaliburjs/Excalibur","forks_url":"https://api.github.com/repos/excaliburjs/Excalibur/forks","keys_url":"https://api.github.com/repos/excaliburjs/Excalibur/keys{/key_id}","collaborators_url":"https://api.github.com/repos/excaliburjs/Excalibur/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/excaliburjs/Excalibur/teams","hooks_url":"https://api.github.com/repos/excaliburjs/Excalibur/hooks","issue_events_url":"https://api.github.com/repos/excaliburjs/Excalibur/issues/events{/number}","events_url":"https://api.github.com/repos/excaliburjs/Excalibur/events","assignees_url":"https://api.github.com/repos/excaliburjs/Excalibur/assignees{/user}","branches_url":"https://api.github.com/repos/excaliburjs/Excalibur/branches{/branch}","tags_url":"https://api.github.com/repos/excaliburjs/Excalibur/tags","blobs_url":"https://api.github.com/repos/excaliburjs/Excalibur/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/excaliburjs/Excalibur/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/excaliburjs/Excalibur/git/refs{/sha}","trees_url":"https://api.github.com/repos/excaliburjs/Excalibur/git/trees{/sha}","statuses_url":"https://api.github.com/repos/excaliburjs/Excalibur/statuses/{sha}","languages_url":"https://api.github.com/repos/excaliburjs/Excalibur/languages","stargazers_url":"https://api.github.com/repos/excaliburjs/Excalibur/stargazers","contributors_url":"https://api.github.com/repos/excaliburjs/Excalibur/contributors","subscribers_url":"https://api.github.com/repos/excaliburjs/Excalibur/subscribers","subscription_url":"https://api.github.com/repos/excaliburjs/Excalibur/subscription","commits_url":"https://api.github.com/repos/excaliburjs/Excalibur/commits{/sha}","git_commits_url":"https://api.github.com/repos/excaliburjs/Excalibur/git/commits{/sha}","comments_url":"https://api.github.com/repos/excaliburjs/Excalibur/comments{/number}","issue_comment_url":"https://api.github.com/repos/excaliburjs/Excalibur/issues/comments{/number}","contents_url":"https://api.github.com/repos/excaliburjs/Excalibur/contents/{+path}","compare_url":"https://api.github.com/repos/excaliburjs/Excalibur/compare/{base}...{head}","merges_url":"https://api.github.com/repos/excaliburjs/Excalibur/merges","archive_url":"https://api.github.com/repos/excaliburjs/Excalibur/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/excaliburjs/Excalibur/downloads","issues_url":"https://api.github.com/repos/excaliburjs/Excalibur/issues{/number}","pulls_url":"https://api.github.com/repos/excaliburjs/Excalibur/pulls{/number}","milestones_url":"https://api.github.com/repos/excaliburjs/Excalibur/milestones{/number}","notifications_url":"https://api.github.com/repos/excaliburjs/Excalibur/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/excaliburjs/Excalibur/labels{/name}","releases_url":"https://api.github.com/repos/excaliburjs/Excalibur/releases{/id}","deployments_url":"https://api.github.com/repos/excaliburjs/Excalibur/deployments","created_at":"2013-01-05T17:05:56Z","updated_at":"2016-12-17T20:39:05Z","pushed_at":"2016-12-18T23:27:14Z","git_url":"git://github.com/excaliburjs/Excalibur.git","ssh_url":"git@github.com:excaliburjs/Excalibur.git","clone_url":"https://github.com/excaliburjs/Excalibur.git","svn_url":"https://github.com/excaliburjs/Excalibur","homepage":"http://excaliburjs.com","size":45662,"stargazers_count":104,"watchers_count":104,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":161,"forks":15,"open_issues":161,"watchers":104,"default_branch":"master"}},"base":{"label":"excaliburjs:master","ref":"master","sha":"a085617ccc3de63bfaa55c233a32fe110ddcf989","user":{"login":"excaliburjs","id":6165683,"avatar_url":"https://avatars.githubusercontent.com/u/6165683?v=3","gravatar_id":"","url":"https://api.github.com/users/excaliburjs","html_url":"https://github.com/excaliburjs","followers_url":"https://api.github.com/users/excaliburjs/followers","following_url":"https://api.github.com/users/excaliburjs/following{/other_user}","gists_url":"https://api.github.com/users/excaliburjs/gists{/gist_id}","starred_url":"https://api.github.com/users/excaliburjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/excaliburjs/subscriptions","organizations_url":"https://api.github.com/users/excaliburjs/orgs","repos_url":"https://api.github.com/users/excaliburjs/repos","events_url":"https://api.github.com/users/excaliburjs/events{/privacy}","received_events_url":"https://api.github.com/users/excaliburjs/received_events","type":"Organization","site_admin":false},"repo":{"id":7457728,"name":"Excalibur","full_name":"excaliburjs/Excalibur","owner":{"login":"excaliburjs","id":6165683,"avatar_url":"https://avatars.githubusercontent.com/u/6165683?v=3","gravatar_id":"","url":"https://api.github.com/users/excaliburjs","html_url":"https://github.com/excaliburjs","followers_url":"https://api.github.com/users/excaliburjs/followers","following_url":"https://api.github.com/users/excaliburjs/following{/other_user}","gists_url":"https://api.github.com/users/excaliburjs/gists{/gist_id}","starred_url":"https://api.github.com/users/excaliburjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/excaliburjs/subscriptions","organizations_url":"https://api.github.com/users/excaliburjs/orgs","repos_url":"https://api.github.com/users/excaliburjs/repos","events_url":"https://api.github.com/users/excaliburjs/events{/privacy}","received_events_url":"https://api.github.com/users/excaliburjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/excaliburjs/Excalibur","description":"🎮 A simple HTML5 Canvas game engine written in TypeScript","fork":false,"url":"https://api.github.com/repos/excaliburjs/Excalibur","forks_url":"https://api.github.com/repos/excaliburjs/Excalibur/forks","keys_url":"https://api.github.com/repos/excaliburjs/Excalibur/keys{/key_id}","collaborators_url":"https://api.github.com/repos/excaliburjs/Excalibur/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/excaliburjs/Excalibur/teams","hooks_url":"https://api.github.com/repos/excaliburjs/Excalibur/hooks","issue_events_url":"https://api.github.com/repos/excaliburjs/Excalibur/issues/events{/number}","events_url":"https://api.github.com/repos/excaliburjs/Excalibur/events","assignees_url":"https://api.github.com/repos/excaliburjs/Excalibur/assignees{/user}","branches_url":"https://api.github.com/repos/excaliburjs/Excalibur/branches{/branch}","tags_url":"https://api.github.com/repos/excaliburjs/Excalibur/tags","blobs_url":"https://api.github.com/repos/excaliburjs/Excalibur/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/excaliburjs/Excalibur/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/excaliburjs/Excalibur/git/refs{/sha}","trees_url":"https://api.github.com/repos/excaliburjs/Excalibur/git/trees{/sha}","statuses_url":"https://api.github.com/repos/excaliburjs/Excalibur/statuses/{sha}","languages_url":"https://api.github.com/repos/excaliburjs/Excalibur/languages","stargazers_url":"https://api.github.com/repos/excaliburjs/Excalibur/stargazers","contributors_url":"https://api.github.com/repos/excaliburjs/Excalibur/contributors","subscribers_url":"https://api.github.com/repos/excaliburjs/Excalibur/subscribers","subscription_url":"https://api.github.com/repos/excaliburjs/Excalibur/subscription","commits_url":"https://api.github.com/repos/excaliburjs/Excalibur/commits{/sha}","git_commits_url":"https://api.github.com/repos/excaliburjs/Excalibur/git/commits{/sha}","comments_url":"https://api.github.com/repos/excaliburjs/Excalibur/comments{/number}","issue_comment_url":"https://api.github.com/repos/excaliburjs/Excalibur/issues/comments{/number}","contents_url":"https://api.github.com/repos/excaliburjs/Excalibur/contents/{+path}","compare_url":"https://api.github.com/repos/excaliburjs/Excalibur/compare/{base}...{head}","merges_url":"https://api.github.com/repos/excaliburjs/Excalibur/merges","archive_url":"https://api.github.com/repos/excaliburjs/Excalibur/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/excaliburjs/Excalibur/downloads","issues_url":"https://api.github.com/repos/excaliburjs/Excalibur/issues{/number}","pulls_url":"https://api.github.com/repos/excaliburjs/Excalibur/pulls{/number}","milestones_url":"https://api.github.com/repos/excaliburjs/Excalibur/milestones{/number}","notifications_url":"https://api.github.com/repos/excaliburjs/Excalibur/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/excaliburjs/Excalibur/labels{/name}","releases_url":"https://api.github.com/repos/excaliburjs/Excalibur/releases{/id}","deployments_url":"https://api.github.com/repos/excaliburjs/Excalibur/deployments","created_at":"2013-01-05T17:05:56Z","updated_at":"2016-12-17T20:39:05Z","pushed_at":"2016-12-18T23:27:14Z","git_url":"git://github.com/excaliburjs/Excalibur.git","ssh_url":"git@github.com:excaliburjs/Excalibur.git","clone_url":"https://github.com/excaliburjs/Excalibur.git","svn_url":"https://github.com/excaliburjs/Excalibur","homepage":"http://excaliburjs.com","size":45662,"stargazers_count":104,"watchers_count":104,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":161,"forks":15,"open_issues":161,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/excaliburjs/Excalibur/pulls/728"},"html":{"href":"https://github.com/excaliburjs/Excalibur/pull/728"},"issue":{"href":"https://api.github.com/repos/excaliburjs/Excalibur/issues/728"},"comments":{"href":"https://api.github.com/repos/excaliburjs/Excalibur/issues/728/comments"},"review_comments":{"href":"https://api.github.com/repos/excaliburjs/Excalibur/pulls/728/comments"},"review_comment":{"href":"https://api.github.com/repos/excaliburjs/Excalibur/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/excaliburjs/Excalibur/pulls/728/commits"},"statuses":{"href":"https://api.github.com/repos/excaliburjs/Excalibur/statuses/8bd1330098b45276aaf69ad3e158e69e7970b8cd"}}}}
{"actor":{"display_login":"eonarheim"}}