{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/pulls/comments/73597663","id":73597663,"diff_hunk":"@@ -62,8 +63,8 @@ private synchronized void loadExecutions() {\n                 }\n             }\n             if (execution != null) {\n-                // TODO JENKINS-37154 we would rather not block here\n-                for (StepExecution se : execution.getCurrentExecutions(true).get()) {\n+                // JENKINS-37154 sometimes we must block here in order to get accurate results\n+                for (StepExecution se : execution.getCurrentExecutions(true).get(1, TimeUnit.MINUTES)) {","path":"src/main/java/org/jenkinsci/plugins/workflow/support/steps/input/InputAction.java","position":15,"original_position":15,"commit_id":"1794b9e9baca9ee1b49b5164973b2120209f972d","original_commit_id":"1794b9e9baca9ee1b49b5164973b2120209f972d","user":{"login":"svanoort","id":5400948,"avatar_url":"https://avatars.githubusercontent.com/u/5400948?v=3","gravatar_id":"","url":"https://api.github.com/users/svanoort","html_url":"https://github.com/svanoort","followers_url":"https://api.github.com/users/svanoort/followers","following_url":"https://api.github.com/users/svanoort/following{/other_user}","gists_url":"https://api.github.com/users/svanoort/gists{/gist_id}","starred_url":"https://api.github.com/users/svanoort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svanoort/subscriptions","organizations_url":"https://api.github.com/users/svanoort/orgs","repos_url":"https://api.github.com/users/svanoort/repos","events_url":"https://api.github.com/users/svanoort/events{/privacy}","received_events_url":"https://api.github.com/users/svanoort/received_events","type":"User","site_admin":false},"body":"> The system might be heavily loaded and just need a little time. The script might be doing some calculation in the CPS VM thread. I would not want to cause the list of inputs to be incorrect merely because of some transient load.\r\n\r\nI can see it needing a bit of time, yes --  basically execution time for one (non-asynchronous) step, right?  Or am I missing something?  Feels like if that's taking more than a few seconds, it represents a bit of an issue (should be converted to an async step) and we're better off just timing out in that case.  \r\n\r\nMy concern is that generally there are a limited (not tiny, but still limited) number of request handler threads, and this completely locks one while waiting.  A full minute is awfully long to be holding a thread that is locked up potentially -- better than infinity, but we can still get thread exhaustion.","created_at":"2016-08-04T20:35:34Z","updated_at":"2016-08-04T20:35:34Z","html_url":"https://github.com/jenkinsci/pipeline-input-step-plugin/pull/1#discussion_r73597663","pull_request_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/pulls/comments/73597663"},"html":{"href":"https://github.com/jenkinsci/pipeline-input-step-plugin/pull/1#discussion_r73597663"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/pulls/1","id":79990136,"html_url":"https://github.com/jenkinsci/pipeline-input-step-plugin/pull/1","diff_url":"https://github.com/jenkinsci/pipeline-input-step-plugin/pull/1.diff","patch_url":"https://github.com/jenkinsci/pipeline-input-step-plugin/pull/1.patch","issue_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/issues/1","number":1,"state":"open","locked":false,"title":"[JENKINS-37154] Deadlock when aborting an input step","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"[JENKINS-37154](https://issues.jenkins-ci.org/browse/JENKINS-37154)\r\n\r\nNot the prettiest solution but the best I could come up with after several false starts.\r\n\r\n@reviewbybees","created_at":"2016-08-03T22:27:27Z","updated_at":"2016-08-04T20:35:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"883a1bdc37c211648edf6b1159056fc808d23689","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/pulls/1/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/pulls/1/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/issues/1/comments","statuses_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/statuses/1794b9e9baca9ee1b49b5164973b2120209f972d","head":{"label":"jglick:hang-JENKINS-37154","ref":"hang-JENKINS-37154","sha":"1794b9e9baca9ee1b49b5164973b2120209f972d","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"repo":{"id":64883630,"name":"pipeline-input-step-plugin","full_name":"jglick/pipeline-input-step-plugin","owner":{"login":"jglick","id":154109,"avatar_url":"https://avatars.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jglick/pipeline-input-step-plugin","description":null,"fork":true,"url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin","forks_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/forks","keys_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/teams","hooks_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/hooks","issue_events_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/events","assignees_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/tags","blobs_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/languages","stargazers_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/stargazers","contributors_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/contributors","subscribers_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/subscribers","subscription_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/subscription","commits_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/merges","archive_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/downloads","issues_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jglick/pipeline-input-step-plugin/deployments","created_at":"2016-08-03T22:26:01Z","updated_at":"2016-08-03T22:26:02Z","pushed_at":"2016-08-03T22:26:17Z","git_url":"git://github.com/jglick/pipeline-input-step-plugin.git","ssh_url":"git@github.com:jglick/pipeline-input-step-plugin.git","clone_url":"https://github.com/jglick/pipeline-input-step-plugin.git","svn_url":"https://github.com/jglick/pipeline-input-step-plugin","homepage":"","size":202,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"6efdc1fd5c8abd4daa840f4bc938d901e80cabdd","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":55543019,"name":"pipeline-input-step-plugin","full_name":"jenkinsci/pipeline-input-step-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/pipeline-input-step-plugin","description":"","fork":false,"url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin","forks_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/deployments","created_at":"2016-04-05T20:21:30Z","updated_at":"2016-04-05T20:23:04Z","pushed_at":"2016-08-03T22:27:27Z","git_url":"git://github.com/jenkinsci/pipeline-input-step-plugin.git","ssh_url":"git@github.com:jenkinsci/pipeline-input-step-plugin.git","clone_url":"https://github.com/jenkinsci/pipeline-input-step-plugin.git","svn_url":"https://github.com/jenkinsci/pipeline-input-step-plugin","homepage":"","size":198,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/pulls/1"},"html":{"href":"https://github.com/jenkinsci/pipeline-input-step-plugin/pull/1"},"issue":{"href":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/issues/1"},"comments":{"href":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/pipeline-input-step-plugin/statuses/1794b9e9baca9ee1b49b5164973b2120209f972d"}}}}
{"actor":{"display_login":"svanoort"}}