{"action":"created","issue":{"url":"https://api.github.com/repos/OpenGeoscience/geojs/issues/644","repository_url":"https://api.github.com/repos/OpenGeoscience/geojs","labels_url":"https://api.github.com/repos/OpenGeoscience/geojs/issues/644/labels{/name}","comments_url":"https://api.github.com/repos/OpenGeoscience/geojs/issues/644/comments","events_url":"https://api.github.com/repos/OpenGeoscience/geojs/issues/644/events","html_url":"https://github.com/OpenGeoscience/geojs/pull/644","id":188271277,"number":644,"title":"Remove the lag between layers.","user":{"login":"manthey","id":8781639,"avatar_url":"https://avatars.githubusercontent.com/u/8781639?v=3","gravatar_id":"","url":"https://api.github.com/users/manthey","html_url":"https://github.com/manthey","followers_url":"https://api.github.com/users/manthey/followers","following_url":"https://api.github.com/users/manthey/following{/other_user}","gists_url":"https://api.github.com/users/manthey/gists{/gist_id}","starred_url":"https://api.github.com/users/manthey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manthey/subscriptions","organizations_url":"https://api.github.com/users/manthey/orgs","repos_url":"https://api.github.com/users/manthey/repos","events_url":"https://api.github.com/users/manthey/events{/privacy}","received_events_url":"https://api.github.com/users/manthey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-09T15:14:06Z","updated_at":"2016-11-21T18:44:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenGeoscience/geojs/pulls/644","html_url":"https://github.com/OpenGeoscience/geojs/pull/644","diff_url":"https://github.com/OpenGeoscience/geojs/pull/644.diff","patch_url":"https://github.com/OpenGeoscience/geojs/pull/644.patch"},"body":"Pedantically, this wasn't a lag, but rather missed frames.\r\n\r\nA variety of actions can trigger rerendering.  We want to perform animations before other updates.  To ensure that renderings are well ordered and not called too often, we were removing an animation frame request and then creating a new one to ensure that the callback happened at the end of the animation frame cycle.  However, sometimes this would defer the animation frame callback until a later cycle rather than just at the end of the next cycle.\r\n\r\nBy using a single animation queue, we ensure that get all of the callbacks we want in the animation cycle.  This has the fringe benefit that it has less overhead in Chrome.  Furthermore, by using a shared array for the animation queue, two map instances can be synchronized, whereas, before, there was likely to be a lag between them.\r\n\r\nA few other minor optimizations have been made: vgl textures are built in the _build step not in the animation frame.  The vgl camera is only updated just as needed, so if two pan events happen in a single frame, only one update will occur.\r\n\r\nResolves issue #526."},"comment":{"url":"https://api.github.com/repos/OpenGeoscience/geojs/issues/comments/262028826","html_url":"https://github.com/OpenGeoscience/geojs/pull/644#issuecomment-262028826","issue_url":"https://api.github.com/repos/OpenGeoscience/geojs/issues/644","id":262028826,"user":{"login":"aashish24","id":146527,"avatar_url":"https://avatars.githubusercontent.com/u/146527?v=3","gravatar_id":"","url":"https://api.github.com/users/aashish24","html_url":"https://github.com/aashish24","followers_url":"https://api.github.com/users/aashish24/followers","following_url":"https://api.github.com/users/aashish24/following{/other_user}","gists_url":"https://api.github.com/users/aashish24/gists{/gist_id}","starred_url":"https://api.github.com/users/aashish24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aashish24/subscriptions","organizations_url":"https://api.github.com/users/aashish24/orgs","repos_url":"https://api.github.com/users/aashish24/repos","events_url":"https://api.github.com/users/aashish24/events{/privacy}","received_events_url":"https://api.github.com/users/aashish24/received_events","type":"User","site_admin":false},"created_at":"2016-11-21T18:44:04Z","updated_at":"2016-11-21T18:44:04Z","body":"looks reasonable to me; I thought we merged this already but I didn't +1 it. "}}
{"actor":{"display_login":"aashish24"}}