{"action":"created","issue":{"url":"https://api.github.com/repos/suda/tool-bar/issues/163","repository_url":"https://api.github.com/repos/suda/tool-bar","labels_url":"https://api.github.com/repos/suda/tool-bar/issues/163/labels{/name}","comments_url":"https://api.github.com/repos/suda/tool-bar/issues/163/comments","events_url":"https://api.github.com/repos/suda/tool-bar/issues/163/events","html_url":"https://github.com/suda/tool-bar/pull/163","id":177009005,"number":163,"title":"✨ Plugin Manager","user":{"login":"jerone","id":55841,"avatar_url":"https://avatars.githubusercontent.com/u/55841?v=3","gravatar_id":"","url":"https://api.github.com/users/jerone","html_url":"https://github.com/jerone","followers_url":"https://api.github.com/users/jerone/followers","following_url":"https://api.github.com/users/jerone/following{/other_user}","gists_url":"https://api.github.com/users/jerone/gists{/gist_id}","starred_url":"https://api.github.com/users/jerone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerone/subscriptions","organizations_url":"https://api.github.com/users/jerone/orgs","repos_url":"https://api.github.com/users/jerone/repos","events_url":"https://api.github.com/users/jerone/events{/privacy}","received_events_url":"https://api.github.com/users/jerone/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/suda/tool-bar/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/suda/tool-bar/labels/needs%20update","name":"needs update","color":"006b75"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-09-14T20:15:59Z","updated_at":"2016-10-03T04:51:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/suda/tool-bar/pulls/163","html_url":"https://github.com/suda/tool-bar/pull/163","diff_url":"https://github.com/suda/tool-bar/pull/163.diff","patch_url":"https://github.com/suda/tool-bar/pull/163.patch"},"body":"Closes #49\r\n\r\n![Tool Bar plugins](https://cloud.githubusercontent.com/assets/55841/18816833/c0fe5e0c-8351-11e6-99d0-a52e53cc1654.gif)\r\n\r\nSome comments:\r\n* Config settings are set programmatically.\r\n* New config setting (by installing package) require an Atom restart (Settings Views cache needs to be cleared for the setting to appear).\r\n* By default all plugins are enabled (backwards compatible).\r\n* Disabling & enabling works instantly (see screenie).\r\n* All plugins settings in the Settings View are grouped in a section named \"Plugins\".\r\n* Groups can't have description, but I think the plugin setting descriptions are sufficient.\r\n* I don't think we can remove the config setting when plugin is uninstalled (needs confirmation).\r\n* Ideas \"borrowed\" from [Minimap](https://github.com/atom-minimap/minimap/blob/master/lib/mixins/plugin-management.js) package.\r\n* This opens support for [custom button types](https://github.com/suda/tool-bar/issues/43).\r\n\r\nTODO:\r\n* [x] Implement plugin manager.\r\n* [x] Figure out why plugin setting description don't show up anymore.\r\n* [x] Specs.\r\n* [x] Documentation.\r\n* [x] Remove `console`-messages.\r\n* [ ] Test, test, test."},"comment":{"url":"https://api.github.com/repos/suda/tool-bar/issues/comments/251026244","html_url":"https://github.com/suda/tool-bar/pull/163#issuecomment-251026244","issue_url":"https://api.github.com/repos/suda/tool-bar/issues/163","id":251026244,"user":{"login":"zertosh","id":830952,"avatar_url":"https://avatars.githubusercontent.com/u/830952?v=3","gravatar_id":"","url":"https://api.github.com/users/zertosh","html_url":"https://github.com/zertosh","followers_url":"https://api.github.com/users/zertosh/followers","following_url":"https://api.github.com/users/zertosh/following{/other_user}","gists_url":"https://api.github.com/users/zertosh/gists{/gist_id}","starred_url":"https://api.github.com/users/zertosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zertosh/subscriptions","organizations_url":"https://api.github.com/users/zertosh/orgs","repos_url":"https://api.github.com/users/zertosh/repos","events_url":"https://api.github.com/users/zertosh/events{/privacy}","received_events_url":"https://api.github.com/users/zertosh/received_events","type":"User","site_admin":false},"created_at":"2016-10-03T04:51:37Z","updated_at":"2016-10-03T04:51:37Z","body":"Ok so I was thinking about this, and I really do think it makes sense to merge the functionality from `tool-bar-plugin-manager.js` into `tool-bar-view.js`. The two are so tightly coupled that they really should be one and the same."}}
{"actor":{"display_login":"zertosh"}}