{"action":"created","comment":{"url":"https://api.github.com/repos/kaltura/server/pulls/comments/75593457","id":75593457,"diff_hunk":"@@ -549,27 +530,68 @@ protected function initPlaylistFlavorAssetArray()\n \t\t\n \t\t$this->duration = array_sum($durations) / 1000;\n \n-\t\t$flavorAssets = array();\n-\t\t\n-\t\tif ($this->flavorIds)\n+\t\t$flavorAssets = assetPeer::retrieveReadyFlavorsByEntryId($mediaEntry->getId());\n+\t\t$filteredFlavorAssets = $this->filterFlavorsByIdOrParamsIds($flavorAssets);\n+\n+\t\tif (!$filteredFlavorAssets || !count($filteredFlavorAssets))\n \t\t{\n-\t\t\t$flavorAssets = assetPeer::retrieveReadyByEntryId($mediaEntry->getId(), $this->flavorIds);\n-\t\t\t$flavorAssets = $this->removeNotAllowedFlavors($flavorAssets);\n-\t\t\t$flavorAssets = $this->removeMaxBitrateFlavors($flavorAssets);\n+\t\t\t$filteredFlavorAssets = $this->removeNotAllowedFlavors($flavorAssets);\n+\t\t\t$filteredFlavorAssets = $this->removeMaxBitrateFlavors($filteredFlavorAssets);\n+\t\t\t$filteredFlavorAssets = $this->filterByTagsAndAltAudio($filteredFlavorAssets);\n \t\t}\n-\t\t\n-\t\tif (!$flavorAssets)\n+\n+\t\t$this->deliveryAttributes->setStorageId(null);\n+\t\t$this->deliveryAttributes->setFlavorAssets($filteredFlavorAssets);\n+\t}\n+\n+\tprivate function filterByTagsAndAltAudio($flavorAssets)","path":"alpha/apps/kaltura/modules/extwidget/actions/playManifestAction.class.php","position":101,"original_position":101,"commit_id":"7450a55abf1c71efad736d9e2ac4053805459173","original_commit_id":"7450a55abf1c71efad736d9e2ac4053805459173","user":{"login":"MosheMaorKaltura","id":10695851,"avatar_url":"https://avatars.githubusercontent.com/u/10695851?v=3","gravatar_id":"","url":"https://api.github.com/users/MosheMaorKaltura","html_url":"https://github.com/MosheMaorKaltura","followers_url":"https://api.github.com/users/MosheMaorKaltura/followers","following_url":"https://api.github.com/users/MosheMaorKaltura/following{/other_user}","gists_url":"https://api.github.com/users/MosheMaorKaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/MosheMaorKaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MosheMaorKaltura/subscriptions","organizations_url":"https://api.github.com/users/MosheMaorKaltura/orgs","repos_url":"https://api.github.com/users/MosheMaorKaltura/repos","events_url":"https://api.github.com/users/MosheMaorKaltura/events{/privacy}","received_events_url":"https://api.github.com/users/MosheMaorKaltura/received_events","type":"User","site_admin":false},"body":"No need to wrap filterFlavorsByTags, just add addAltAudioTag to the tag list.","created_at":"2016-08-21T11:08:50Z","updated_at":"2016-08-21T11:08:50Z","html_url":"https://github.com/kaltura/server/pull/4624#discussion_r75593457","pull_request_url":"https://api.github.com/repos/kaltura/server/pulls/4624","_links":{"self":{"href":"https://api.github.com/repos/kaltura/server/pulls/comments/75593457"},"html":{"href":"https://github.com/kaltura/server/pull/4624#discussion_r75593457"},"pull_request":{"href":"https://api.github.com/repos/kaltura/server/pulls/4624"}}},"pull_request":{"url":"https://api.github.com/repos/kaltura/server/pulls/4624","id":81793975,"html_url":"https://github.com/kaltura/server/pull/4624","diff_url":"https://github.com/kaltura/server/pull/4624.diff","patch_url":"https://github.com/kaltura/server/pull/4624.patch","issue_url":"https://api.github.com/repos/kaltura/server/issues/4624","number":4624,"state":"open","locked":false,"title":"Lynx 12.0.0 plat 5950","user":{"login":"NadavHarnik","id":19182892,"avatar_url":"https://avatars.githubusercontent.com/u/19182892?v=3","gravatar_id":"","url":"https://api.github.com/users/NadavHarnik","html_url":"https://github.com/NadavHarnik","followers_url":"https://api.github.com/users/NadavHarnik/followers","following_url":"https://api.github.com/users/NadavHarnik/following{/other_user}","gists_url":"https://api.github.com/users/NadavHarnik/gists{/gist_id}","starred_url":"https://api.github.com/users/NadavHarnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NadavHarnik/subscriptions","organizations_url":"https://api.github.com/users/NadavHarnik/orgs","repos_url":"https://api.github.com/users/NadavHarnik/repos","events_url":"https://api.github.com/users/NadavHarnik/events{/privacy}","received_events_url":"https://api.github.com/users/NadavHarnik/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-18T10:40:26Z","updated_at":"2016-08-21T11:08:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a38eccd76e5759a48185189899f593a370d7a5a","assignee":{"login":"erankor","id":4777488,"avatar_url":"https://avatars.githubusercontent.com/u/4777488?v=3","gravatar_id":"","url":"https://api.github.com/users/erankor","html_url":"https://github.com/erankor","followers_url":"https://api.github.com/users/erankor/followers","following_url":"https://api.github.com/users/erankor/following{/other_user}","gists_url":"https://api.github.com/users/erankor/gists{/gist_id}","starred_url":"https://api.github.com/users/erankor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erankor/subscriptions","organizations_url":"https://api.github.com/users/erankor/orgs","repos_url":"https://api.github.com/users/erankor/repos","events_url":"https://api.github.com/users/erankor/events{/privacy}","received_events_url":"https://api.github.com/users/erankor/received_events","type":"User","site_admin":false},"assignees":[{"login":"erankor","id":4777488,"avatar_url":"https://avatars.githubusercontent.com/u/4777488?v=3","gravatar_id":"","url":"https://api.github.com/users/erankor","html_url":"https://github.com/erankor","followers_url":"https://api.github.com/users/erankor/followers","following_url":"https://api.github.com/users/erankor/following{/other_user}","gists_url":"https://api.github.com/users/erankor/gists{/gist_id}","starred_url":"https://api.github.com/users/erankor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erankor/subscriptions","organizations_url":"https://api.github.com/users/erankor/orgs","repos_url":"https://api.github.com/users/erankor/repos","events_url":"https://api.github.com/users/erankor/events{/privacy}","received_events_url":"https://api.github.com/users/erankor/received_events","type":"User","site_admin":false},{"login":"yossipapi","id":4889668,"avatar_url":"https://avatars.githubusercontent.com/u/4889668?v=3","gravatar_id":"","url":"https://api.github.com/users/yossipapi","html_url":"https://github.com/yossipapi","followers_url":"https://api.github.com/users/yossipapi/followers","following_url":"https://api.github.com/users/yossipapi/following{/other_user}","gists_url":"https://api.github.com/users/yossipapi/gists{/gist_id}","starred_url":"https://api.github.com/users/yossipapi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yossipapi/subscriptions","organizations_url":"https://api.github.com/users/yossipapi/orgs","repos_url":"https://api.github.com/users/yossipapi/repos","events_url":"https://api.github.com/users/yossipapi/events{/privacy}","received_events_url":"https://api.github.com/users/yossipapi/received_events","type":"User","site_admin":false},{"login":"MosheMaorKaltura","id":10695851,"avatar_url":"https://avatars.githubusercontent.com/u/10695851?v=3","gravatar_id":"","url":"https://api.github.com/users/MosheMaorKaltura","html_url":"https://github.com/MosheMaorKaltura","followers_url":"https://api.github.com/users/MosheMaorKaltura/followers","following_url":"https://api.github.com/users/MosheMaorKaltura/following{/other_user}","gists_url":"https://api.github.com/users/MosheMaorKaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/MosheMaorKaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MosheMaorKaltura/subscriptions","organizations_url":"https://api.github.com/users/MosheMaorKaltura/orgs","repos_url":"https://api.github.com/users/MosheMaorKaltura/repos","events_url":"https://api.github.com/users/MosheMaorKaltura/events{/privacy}","received_events_url":"https://api.github.com/users/MosheMaorKaltura/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kaltura/server/pulls/4624/commits","review_comments_url":"https://api.github.com/repos/kaltura/server/pulls/4624/comments","review_comment_url":"https://api.github.com/repos/kaltura/server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaltura/server/issues/4624/comments","statuses_url":"https://api.github.com/repos/kaltura/server/statuses/7450a55abf1c71efad736d9e2ac4053805459173","head":{"label":"kaltura:Lynx-12.0.0-PLAT-5950","ref":"Lynx-12.0.0-PLAT-5950","sha":"7450a55abf1c71efad736d9e2ac4053805459173","user":{"login":"kaltura","id":319096,"avatar_url":"https://avatars.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":11364783,"name":"server","full_name":"kaltura/server","owner":{"login":"kaltura","id":319096,"avatar_url":"https://avatars.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaltura/server","description":"The official Kaltura server. ","fork":false,"url":"https://api.github.com/repos/kaltura/server","forks_url":"https://api.github.com/repos/kaltura/server/forks","keys_url":"https://api.github.com/repos/kaltura/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/server/teams","hooks_url":"https://api.github.com/repos/kaltura/server/hooks","issue_events_url":"https://api.github.com/repos/kaltura/server/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/server/events","assignees_url":"https://api.github.com/repos/kaltura/server/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/server/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/server/tags","blobs_url":"https://api.github.com/repos/kaltura/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/server/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/server/languages","stargazers_url":"https://api.github.com/repos/kaltura/server/stargazers","contributors_url":"https://api.github.com/repos/kaltura/server/contributors","subscribers_url":"https://api.github.com/repos/kaltura/server/subscribers","subscription_url":"https://api.github.com/repos/kaltura/server/subscription","commits_url":"https://api.github.com/repos/kaltura/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/server/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/server/merges","archive_url":"https://api.github.com/repos/kaltura/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/server/downloads","issues_url":"https://api.github.com/repos/kaltura/server/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/server/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/server/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/server/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/server/releases{/id}","deployments_url":"https://api.github.com/repos/kaltura/server/deployments","created_at":"2013-07-12T08:59:26Z","updated_at":"2016-08-12T07:53:13Z","pushed_at":"2016-08-21T10:08:33Z","git_url":"git://github.com/kaltura/server.git","ssh_url":"git@github.com:kaltura/server.git","clone_url":"https://github.com/kaltura/server.git","svn_url":"https://github.com/kaltura/server","homepage":"http://www.kaltura.org","size":244913,"stargazers_count":102,"watchers_count":102,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":91,"forks":99,"open_issues":91,"watchers":102,"default_branch":"Lynx-12.0.0"}},"base":{"label":"kaltura:Lynx-12.0.0","ref":"Lynx-12.0.0","sha":"7ac9ecc97a371525a4e193ab85e158a2a76106f7","user":{"login":"kaltura","id":319096,"avatar_url":"https://avatars.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":11364783,"name":"server","full_name":"kaltura/server","owner":{"login":"kaltura","id":319096,"avatar_url":"https://avatars.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaltura/server","description":"The official Kaltura server. ","fork":false,"url":"https://api.github.com/repos/kaltura/server","forks_url":"https://api.github.com/repos/kaltura/server/forks","keys_url":"https://api.github.com/repos/kaltura/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/server/teams","hooks_url":"https://api.github.com/repos/kaltura/server/hooks","issue_events_url":"https://api.github.com/repos/kaltura/server/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/server/events","assignees_url":"https://api.github.com/repos/kaltura/server/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/server/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/server/tags","blobs_url":"https://api.github.com/repos/kaltura/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/server/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/server/languages","stargazers_url":"https://api.github.com/repos/kaltura/server/stargazers","contributors_url":"https://api.github.com/repos/kaltura/server/contributors","subscribers_url":"https://api.github.com/repos/kaltura/server/subscribers","subscription_url":"https://api.github.com/repos/kaltura/server/subscription","commits_url":"https://api.github.com/repos/kaltura/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/server/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/server/merges","archive_url":"https://api.github.com/repos/kaltura/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/server/downloads","issues_url":"https://api.github.com/repos/kaltura/server/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/server/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/server/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/server/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/server/releases{/id}","deployments_url":"https://api.github.com/repos/kaltura/server/deployments","created_at":"2013-07-12T08:59:26Z","updated_at":"2016-08-12T07:53:13Z","pushed_at":"2016-08-21T10:08:33Z","git_url":"git://github.com/kaltura/server.git","ssh_url":"git@github.com:kaltura/server.git","clone_url":"https://github.com/kaltura/server.git","svn_url":"https://github.com/kaltura/server","homepage":"http://www.kaltura.org","size":244913,"stargazers_count":102,"watchers_count":102,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":91,"forks":99,"open_issues":91,"watchers":102,"default_branch":"Lynx-12.0.0"}},"_links":{"self":{"href":"https://api.github.com/repos/kaltura/server/pulls/4624"},"html":{"href":"https://github.com/kaltura/server/pull/4624"},"issue":{"href":"https://api.github.com/repos/kaltura/server/issues/4624"},"comments":{"href":"https://api.github.com/repos/kaltura/server/issues/4624/comments"},"review_comments":{"href":"https://api.github.com/repos/kaltura/server/pulls/4624/comments"},"review_comment":{"href":"https://api.github.com/repos/kaltura/server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaltura/server/pulls/4624/commits"},"statuses":{"href":"https://api.github.com/repos/kaltura/server/statuses/7450a55abf1c71efad736d9e2ac4053805459173"}}}}
{"actor":{"display_login":"MosheMaorKaltura"}}