{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1961","repository_url":"https://api.github.com/repos/ansible/ansible-modules-extras","labels_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1961/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1961/comments","events_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1961/events","html_url":"https://github.com/ansible/ansible-modules-extras/pull/1961","id":145778620,"number":1961,"title":"Pulp repo","user":{"login":"sysadmind","id":2531691,"avatar_url":"https://avatars.githubusercontent.com/u/2531691?v=3","gravatar_id":"","url":"https://api.github.com/users/sysadmind","html_url":"https://github.com/sysadmind","followers_url":"https://api.github.com/users/sysadmind/followers","following_url":"https://api.github.com/users/sysadmind/following{/other_user}","gists_url":"https://api.github.com/users/sysadmind/gists{/gist_id}","starred_url":"https://api.github.com/users/sysadmind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sysadmind/subscriptions","organizations_url":"https://api.github.com/users/sysadmind/orgs","repos_url":"https://api.github.com/users/sysadmind/repos","events_url":"https://api.github.com/users/sysadmind/events{/privacy}","received_events_url":"https://api.github.com/users/sysadmind/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/community_review","name":"community_review","color":"fad8c7"},{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/new_plugin","name":"new_plugin","color":"bfe5bf"},{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/labels/pending_action","name":"pending_action","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2016-04-04T19:18:38Z","updated_at":"2016-06-30T16:42:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/pulls/1961","html_url":"https://github.com/ansible/ansible-modules-extras/pull/1961","diff_url":"https://github.com/ansible/ansible-modules-extras/pull/1961.diff","patch_url":"https://github.com/ansible/ansible-modules-extras/pull/1961.patch"},"body":"##### ISSUE TYPE\r\n - New Module Pull Request\r\n\r\n##### COMPONENT NAME\r\npulp_repo\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.0.1.0\r\n  config file = /etc/ansible/ansible.cfg\r\n  configured module search path = Default w/o overrides\r\n\r\n```\r\n\r\n##### SUMMARY\r\nThis adds a module for working with pulp repos. http://www.pulpproject.org/. I added this under packaging/os because it seemed like the most relevant location for this module although it is not explicitly an os packaging module like others in this directory.\r\n\r\nI created a class that lines up with a pulp server and added methods for getting and setting repo properties. I chose this design because it closely resembles the actual design of pulp and keeps the code logically separated into small methods. \r\n\r\n```\r\nok: [L-Pulp101.localdomain]\r\n\r\n```"},"comment":{"url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/comments/229716593","html_url":"https://github.com/ansible/ansible-modules-extras/pull/1961#issuecomment-229716593","issue_url":"https://api.github.com/repos/ansible/ansible-modules-extras/issues/1961","id":229716593,"user":{"login":"sysadmind","id":2531691,"avatar_url":"https://avatars.githubusercontent.com/u/2531691?v=3","gravatar_id":"","url":"https://api.github.com/users/sysadmind","html_url":"https://github.com/sysadmind","followers_url":"https://api.github.com/users/sysadmind/followers","following_url":"https://api.github.com/users/sysadmind/following{/other_user}","gists_url":"https://api.github.com/users/sysadmind/gists{/gist_id}","starred_url":"https://api.github.com/users/sysadmind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sysadmind/subscriptions","organizations_url":"https://api.github.com/users/sysadmind/orgs","repos_url":"https://api.github.com/users/sysadmind/repos","events_url":"https://api.github.com/users/sysadmind/events{/privacy}","received_events_url":"https://api.github.com/users/sysadmind/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T16:42:53Z","updated_at":"2016-06-30T16:42:53Z","body":"I reordered the arguments and the variables after the arguments. I did change one more line in terms of line length, but the remaining lines are all just over 80 characters and I believe that changing them will just make the code harder to read so I'm going to leave them like they are. The contributing docs explicitly say that it's not a hard limit and that line length limits can actually hurt readability. \r\n\r\nAs far as quoting values in the documentation, I'm going to leave the quotes. Looking through other modules in the repo, they are fairly consistently quoted. I want to keep the styling similar to the rest of the repo for easier readability and consistency. "}}
{"actor":{"display_login":"sysadmind"}}