{"action":"created","issue":{"url":"https://api.github.com/repos/spring-projects/spring-boot/issues/7659","repository_url":"https://api.github.com/repos/spring-projects/spring-boot","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/7659/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/7659/comments","events_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/7659/events","html_url":"https://github.com/spring-projects/spring-boot/issues/7659","id":195886596,"number":7659,"title":"Allow spring-boot-maven-plugin RepackageMojo to use a source classifer","user":{"login":"tuliogomesbarbosa","id":1828978,"avatar_url":"https://avatars.githubusercontent.com/u/1828978?v=3","gravatar_id":"","url":"https://api.github.com/users/tuliogomesbarbosa","html_url":"https://github.com/tuliogomesbarbosa","followers_url":"https://api.github.com/users/tuliogomesbarbosa/followers","following_url":"https://api.github.com/users/tuliogomesbarbosa/following{/other_user}","gists_url":"https://api.github.com/users/tuliogomesbarbosa/gists{/gist_id}","starred_url":"https://api.github.com/users/tuliogomesbarbosa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuliogomesbarbosa/subscriptions","organizations_url":"https://api.github.com/users/tuliogomesbarbosa/orgs","repos_url":"https://api.github.com/users/tuliogomesbarbosa/repos","events_url":"https://api.github.com/users/tuliogomesbarbosa/events{/privacy}","received_events_url":"https://api.github.com/users/tuliogomesbarbosa/received_events","type":"User","site_admin":false},"labels":[{"id":16916893,"url":"https://api.github.com/repos/spring-projects/spring-boot/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":131737420,"url":"https://api.github.com/repos/spring-projects/spring-boot/labels/ideal-for-contribution","name":"ideal-for-contribution","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-12-15T19:00:19Z","updated_at":"2016-12-16T18:53:33Z","closed_at":null,"body":"<!--\r\nThanks for raising a Spring Boot issue. What sort of issue are you raising?\r\n\r\nQuestion\r\n\r\nPlease ask questions about how to use something, or to understand why something isn't\r\nworking as you expect it to, on Stack Overflow using the spring-boot tag.\r\n\r\nBug report\r\n\r\nPlease provide details of the problem, including the version of Spring Boot that you\r\nare using. If possible, please provide a test case or sample application that reproduces\r\nthe problem. This makes it much easier for us to diagnose the problem and to verify that\r\nwe have fixed it.\r\n\r\nEnhancement\r\n\r\nPlease start by describing the problem that you are trying to solve. There may already\r\nbe a solution, or there may be a way to solve it that you hadn't considered.\r\n-->\r\n\r\nHi,\r\ni'm using spring-boot-maven-plugin to generate a fat jar that have jars (bouncycastle family) inside it .\r\n\r\nI'm also using maven profiles to customize my generated jar with classifiers. Thus i have a maven-jar-plugin configured this way:\r\n\r\n```xml\r\n\t<plugin>\r\n\t\t<groupId>org.apache.maven.plugins</groupId>\r\n\t\t<artifactId>maven-jar-plugin</artifactId>\r\n\t\t<version>3.0.2</version>\r\n\t\t<executions>\r\n\t\t\t<execution>\r\n\t\t\t\t<id>hom</id>\r\n\t\t\t\t<goals>\r\n\t\t\t\t\t<goal>jar</goal>\r\n\t\t\t\t</goals>\r\n\t\t\t\t<phase>package</phase>\r\n\t\t\t\t<configuration>\r\n\t\t\t\t\t<classifier>hom</classifier>\r\n\t\t\t\t\t<archive>\r\n\t\t\t\t\t\t<index>true</index>\r\n\t\t\t\t\t\t<manifestEntries>\r\n\t\t\t\t\t\t\t<Application-Name>My Applet</Application-Name>\r\n\t\t\t\t\t\t\t<Permissions>all-permissions</Permissions>\r\n\t\t\t\t\t\t\t<Codebase>*</Codebase>\r\n\t\t\t\t\t\t\t<Application-Library-Allowable-Codebase>*</Application-Library-Allowable-Codebase>\r\n\t\t\t\t\t\t\t<Caller-Allowable-Codebase>*</Caller-Allowable-Codebase>\r\n\t\t\t\t\t\t\t<Trusted-Only>true</Trusted-Only>\r\n\t\t\t\t\t\t\t<Trusted-Library>true</Trusted-Library>\r\n\t\t\t\t\t\t\t<Built-By>My Company</Built-By>\r\n\t\t\t\t\t\t</manifestEntries>\r\n\t\t\t\t\t</archive>\r\n\t\t\t\t</configuration>\r\n\t\t\t</execution>\r\n\t\t</executions>\r\n\t</plugin>\r\n```\r\n\r\nDebugging the spring-boot-maven-plugin i could see that the method _Repackager.repackage_ (line 150, tag 1.4.2.RELEASE) does not consider the classified jar generated previously by maven-jar-plugin as a input. \r\n\r\nMy spring boot plugin configuration is as follow:\r\n\r\n```xml\r\n<plugin>\r\n\t\t\t\t\t\t<groupId>org.springframework.boot</groupId>\r\n\t\t\t\t\t\t<artifactId>spring-boot-maven-plugin</artifactId>\r\n\t\t\t\t\t\t<executions>\r\n\t\t\t\t\t\t\t<execution>\r\n\t\t\t\t\t\t\t\t<goals>\r\n\t\t\t\t\t\t\t\t\t<goal>repackage</goal>\r\n\t\t\t\t\t\t\t\t</goals>\r\n\t\t\t\t\t\t\t\t<configuration>\r\n\t\t\t\t\t\t\t\t    <attach>true</attach>\r\n\t\t\t\t\t\t\t\t\t<layout>NONE</layout>\r\n\t\t\t\t\t\t\t\t\t<classifier>hom</classifier>\r\n\t\t\t\t\t\t\t\t\t<requiresUnpack>\r\n\t\t\t\t\t\t\t\t\t\t<requiresUnpack>\r\n\t\t\t\t\t\t\t\t\t\t\t<groupId>org.bouncycastle</groupId>\r\n\t\t\t\t\t\t\t\t\t\t\t<artifactId>bcprov-jdk15</artifactId>\r\n\t\t\t\t\t\t\t\t\t\t\t<version>1.45</version>\r\n\t\t\t\t\t\t\t\t\t\t</requiresUnpack>\r\n\t\t\t\t\t\t\t\t\t</requiresUnpack>\r\n\t\t\t\t\t\t\t\t</configuration>\r\n\t\t\t\t\t\t\t</execution>\r\n\t\t\t\t\t\t</executions>\r\n\t\t\t\t\t</plugin>\r\n```\r\nIn short, after the build i got something like this:\r\n\r\n>  **myjar-hom.jar** without my manifest entries configured in maven-jar-plugin because the spring boot plugin considers the raw myjar.jar generated along with the classified myjar-hom.jar\r\n\r\nPS: the raw jar doesn't have these manifest entries\r\n\r\nIs this a bug or i'm missing some configuration?\r\n\r\nThanks in advance"},"comment":{"url":"https://api.github.com/repos/spring-projects/spring-boot/issues/comments/267668365","html_url":"https://github.com/spring-projects/spring-boot/issues/7659#issuecomment-267668365","issue_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/7659","id":267668365,"user":{"login":"philwebb","id":519772,"avatar_url":"https://avatars.githubusercontent.com/u/519772?v=3","gravatar_id":"","url":"https://api.github.com/users/philwebb","html_url":"https://github.com/philwebb","followers_url":"https://api.github.com/users/philwebb/followers","following_url":"https://api.github.com/users/philwebb/following{/other_user}","gists_url":"https://api.github.com/users/philwebb/gists{/gist_id}","starred_url":"https://api.github.com/users/philwebb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwebb/subscriptions","organizations_url":"https://api.github.com/users/philwebb/orgs","repos_url":"https://api.github.com/users/philwebb/repos","events_url":"https://api.github.com/users/philwebb/events{/privacy}","received_events_url":"https://api.github.com/users/philwebb/received_events","type":"User","site_admin":false},"created_at":"2016-12-16T18:53:33Z","updated_at":"2016-12-16T18:53:33Z","body":"@snicoll Do you mean use the `classifier` property that we already have? We could use that but then we couldn't support repacking from one classifier to a different one. Perhaps that's not an issue."}}
{"actor":{"display_login":"philwebb"}}