{"action":"created","issue":{"url":"https://api.github.com/repos/LiskHQ/lisk/issues/247","repository_url":"https://api.github.com/repos/LiskHQ/lisk","labels_url":"https://api.github.com/repos/LiskHQ/lisk/issues/247/labels{/name}","comments_url":"https://api.github.com/repos/LiskHQ/lisk/issues/247/comments","events_url":"https://api.github.com/repos/LiskHQ/lisk/issues/247/events","html_url":"https://github.com/LiskHQ/lisk/pull/247","id":170397234,"number":247,"title":"add api for cold wallet","user":{"login":"34ro","id":2033895,"avatar_url":"https://avatars.githubusercontent.com/u/2033895?v=3","gravatar_id":"","url":"https://api.github.com/users/34ro","html_url":"https://github.com/34ro","followers_url":"https://api.github.com/users/34ro/followers","following_url":"https://api.github.com/users/34ro/following{/other_user}","gists_url":"https://api.github.com/users/34ro/gists{/gist_id}","starred_url":"https://api.github.com/users/34ro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/34ro/subscriptions","organizations_url":"https://api.github.com/users/34ro/orgs","repos_url":"https://api.github.com/users/34ro/repos","events_url":"https://api.github.com/users/34ro/events{/privacy}","received_events_url":"https://api.github.com/users/34ro/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/LiskHQ/lisk/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"karmacoma","id":8068,"avatar_url":"https://avatars.githubusercontent.com/u/8068?v=3","gravatar_id":"","url":"https://api.github.com/users/karmacoma","html_url":"https://github.com/karmacoma","followers_url":"https://api.github.com/users/karmacoma/followers","following_url":"https://api.github.com/users/karmacoma/following{/other_user}","gists_url":"https://api.github.com/users/karmacoma/gists{/gist_id}","starred_url":"https://api.github.com/users/karmacoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karmacoma/subscriptions","organizations_url":"https://api.github.com/users/karmacoma/orgs","repos_url":"https://api.github.com/users/karmacoma/repos","events_url":"https://api.github.com/users/karmacoma/events{/privacy}","received_events_url":"https://api.github.com/users/karmacoma/received_events","type":"User","site_admin":false},"assignees":[{"login":"karmacoma","id":8068,"avatar_url":"https://avatars.githubusercontent.com/u/8068?v=3","gravatar_id":"","url":"https://api.github.com/users/karmacoma","html_url":"https://github.com/karmacoma","followers_url":"https://api.github.com/users/karmacoma/followers","following_url":"https://api.github.com/users/karmacoma/following{/other_user}","gists_url":"https://api.github.com/users/karmacoma/gists{/gist_id}","starred_url":"https://api.github.com/users/karmacoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karmacoma/subscriptions","organizations_url":"https://api.github.com/users/karmacoma/orgs","repos_url":"https://api.github.com/users/karmacoma/repos","events_url":"https://api.github.com/users/karmacoma/events{/privacy}","received_events_url":"https://api.github.com/users/karmacoma/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-08-10T11:44:26Z","updated_at":"2016-08-11T11:21:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/LiskHQ/lisk/pulls/247","html_url":"https://github.com/LiskHQ/lisk/pull/247","diff_url":"https://github.com/LiskHQ/lisk/pull/247.diff","patch_url":"https://github.com/LiskHQ/lisk/pull/247.patch"},"body":"This PR try to enable cold wallet that keep secret phrase just under offline server.\r\n\r\n### motivation\r\nCurrent lisk client is just for online.\r\nSecret was included in request for create transaction.\r\nSo account which has huge amount of blance is not safe.\r\nIf keep secret in offline server at all time, this problem will improve.\r\n\r\n### use scenario\r\n* 1. create signed transaction in offline node  \r\n```\r\n$ curl -XPUT 'http://localhost/api/transactions/signed' -H \"Content-type: application/json\" -d '{\"secret\":\"xxxx\",\"amount\": xxxx,\"recipientId\": \"xxxxL\"}'\r\n{\"success\":true,\"id\":\"8382130011750128797\",\"type\":0,\"timestamp\":6703979,\"recipientId\":\"xxxxL\",\"amount\":xxxx,\"asset\":{},\"senderPublicKey\":\"xxxx\",\"signature\":\"xxxx\"}\r\n```\r\n\r\n* 2. convey result to online server and put transaction to online node\r\n```\r\ncurl -XPUT 'http://online.node/api/transactions/unconfirmed' -H \"Content-type: application/json\" -d '{\"success\":true,\"id\":\"xxxx\",\"type\":0,\"timestamp\":xxxx,\"recipientId\":\"xxxx\",\"amount\":1000000000,\"asset\":{},\"senderPublicKey\":\"xxxx\",\"signature\":\"xxxx\"}'\r\n{\"success\":true,\"transactionId\":\"xxxx\"}\r\n```\r\n\r\n* 3. after that, the transaction will be broadcast and put into block\r\n\r\n### coping plan\r\nCreate 2 entry point, to sign transaction and to create new transaction with signed transaction.\r\n2nd passphase is not supported for now."},"comment":{"url":"https://api.github.com/repos/LiskHQ/lisk/issues/comments/239134319","html_url":"https://github.com/LiskHQ/lisk/pull/247#issuecomment-239134319","issue_url":"https://api.github.com/repos/LiskHQ/lisk/issues/247","id":239134319,"user":{"login":"karmacoma","id":8068,"avatar_url":"https://avatars.githubusercontent.com/u/8068?v=3","gravatar_id":"","url":"https://api.github.com/users/karmacoma","html_url":"https://github.com/karmacoma","followers_url":"https://api.github.com/users/karmacoma/followers","following_url":"https://api.github.com/users/karmacoma/following{/other_user}","gists_url":"https://api.github.com/users/karmacoma/gists{/gist_id}","starred_url":"https://api.github.com/users/karmacoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karmacoma/subscriptions","organizations_url":"https://api.github.com/users/karmacoma/orgs","repos_url":"https://api.github.com/users/karmacoma/repos","events_url":"https://api.github.com/users/karmacoma/events{/privacy}","received_events_url":"https://api.github.com/users/karmacoma/received_events","type":"User","site_admin":false},"created_at":"2016-08-11T11:21:23Z","updated_at":"2016-08-11T11:21:23Z","body":"@34ro Thanks for your contribution 👍 We will review your PR asap."}}
{"actor":{"display_login":"karmacoma"}}