{"action":"opened","issue":{"url":"https://api.github.com/repos/grindhold/libgtkflow/issues/41","repository_url":"https://api.github.com/repos/grindhold/libgtkflow","labels_url":"https://api.github.com/repos/grindhold/libgtkflow/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/grindhold/libgtkflow/issues/41/comments","events_url":"https://api.github.com/repos/grindhold/libgtkflow/issues/41/events","html_url":"https://github.com/grindhold/libgtkflow/issues/41","id":158255715,"number":41,"title":"NodeView: Use GtkFlow.Node instead GFlow.Node","user":{"login":"esodan","id":8839360,"avatar_url":"https://avatars.githubusercontent.com/u/8839360?v=3","gravatar_id":"","url":"https://api.github.com/users/esodan","html_url":"https://github.com/esodan","followers_url":"https://api.github.com/users/esodan/followers","following_url":"https://api.github.com/users/esodan/following{/other_user}","gists_url":"https://api.github.com/users/esodan/gists{/gist_id}","starred_url":"https://api.github.com/users/esodan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esodan/subscriptions","organizations_url":"https://api.github.com/users/esodan/orgs","repos_url":"https://api.github.com/users/esodan/repos","events_url":"https://api.github.com/users/esodan/events{/privacy}","received_events_url":"https://api.github.com/users/esodan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-06-02T22:40:11Z","updated_at":"2016-06-02T22:40:11Z","closed_at":null,"body":"Checking GtkFlow.NodeView implementation, I can see it relays to hold a set of GFlow.Node objects to show, then create on demand GtkFlow.NodeRenderer in order to draw in.\r\n\r\nMy suggestion is to use directly GtkFlow.NodeRenderer objects. They hold a GFlow.Node reference and you can always redraw by calling each added to a NodeView and no add extra steps, to find a node, create a new GtkFlow.NodeRenderer when required and then redraw.\r\n\r\nI'm sure, may I wrong here, but the point is to abstract Data Model, from GUI applications as far as possible, and in this case is to make high level widgets like NodeView, to hold just Gtk widgets, this custom widgets will hold references to data model (GFlow objects), to get data from to draw its self.\r\n\r\nI discover this, while in my local branch, I tried to move GUI properties from GFlow.Dock to GtkFlow.Dock one. When I start, think: \"I will fine any reference in NodeView to this properties and replace to get them directly from GtkFlow.Dock\"; my issues is that you are using GFlow.Node directly, no a set of GtkFlow.Node objects."}}
{"actor":{"display_login":"esodan"}}