{"action":"created","issue":{"url":"https://api.github.com/repos/fgpv-vpgf/rcs/issues/46","repository_url":"https://api.github.com/repos/fgpv-vpgf/rcs","labels_url":"https://api.github.com/repos/fgpv-vpgf/rcs/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/fgpv-vpgf/rcs/issues/46/comments","events_url":"https://api.github.com/repos/fgpv-vpgf/rcs/issues/46/events","html_url":"https://github.com/fgpv-vpgf/rcs/pull/46","id":162717129,"number":46,"title":"Added support for recursive scraping of Esri and OGC services","user":{"login":"dan-bowerman","id":5294596,"avatar_url":"https://avatars.githubusercontent.com/u/5294596?v=3","gravatar_id":"","url":"https://api.github.com/users/dan-bowerman","html_url":"https://github.com/dan-bowerman","followers_url":"https://api.github.com/users/dan-bowerman/followers","following_url":"https://api.github.com/users/dan-bowerman/following{/other_user}","gists_url":"https://api.github.com/users/dan-bowerman/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-bowerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-bowerman/subscriptions","organizations_url":"https://api.github.com/users/dan-bowerman/orgs","repos_url":"https://api.github.com/users/dan-bowerman/repos","events_url":"https://api.github.com/users/dan-bowerman/events{/privacy}","received_events_url":"https://api.github.com/users/dan-bowerman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-28T15:36:31Z","updated_at":"2016-06-28T19:15:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fgpv-vpgf/rcs/pulls/46","html_url":"https://github.com/fgpv-vpgf/rcs/pull/46","diff_url":"https://github.com/fgpv-vpgf/rcs/pull/46.diff","patch_url":"https://github.com/fgpv-vpgf/rcs/pull/46.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/fgpv-vpgf/rcs/46)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/fgpv-vpgf/rcs/issues/comments/229152606","html_url":"https://github.com/fgpv-vpgf/rcs/pull/46#issuecomment-229152606","issue_url":"https://api.github.com/repos/fgpv-vpgf/rcs/issues/46","id":229152606,"user":{"login":"dan-bowerman","id":5294596,"avatar_url":"https://avatars.githubusercontent.com/u/5294596?v=3","gravatar_id":"","url":"https://api.github.com/users/dan-bowerman","html_url":"https://github.com/dan-bowerman","followers_url":"https://api.github.com/users/dan-bowerman/followers","following_url":"https://api.github.com/users/dan-bowerman/following{/other_user}","gists_url":"https://api.github.com/users/dan-bowerman/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-bowerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-bowerman/subscriptions","organizations_url":"https://api.github.com/users/dan-bowerman/orgs","repos_url":"https://api.github.com/users/dan-bowerman/repos","events_url":"https://api.github.com/users/dan-bowerman/events{/privacy}","received_events_url":"https://api.github.com/users/dan-bowerman/received_events","type":"User","site_admin":false},"created_at":"2016-06-28T19:15:03Z","updated_at":"2016-06-28T19:15:03Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 5 unresolved discussions.\n\n---\n\n*[services/v2.py, line 1 \\[r1\\]](https://reviewable.io:443/reviews/fgpv-vpgf/rcs/46#-KLMzxiKy3-a4IczM7AQ:-KLN5DpCmcjMfspWvWKT:-1025215359) ([raw file](https://github.com/fgpv-vpgf/rcs/blob/23a5273ad0eaffca3df1c2dcc3cede33503e8804/services/v2.py#L1)):*\n<details><summary><i>Previously, alyec (Aly Merchant) wrote…</i></summary>\n> This adds update, but I don't see any changes in registration.py .  Was this an extra file in the commit?\n</details>\nYes, not much else has been done with update thus far.\n\n---\n\n*[services/regparse/esri.py, line 233 \\[r1\\]](https://reviewable.io:443/reviews/fgpv-vpgf/rcs/46#-KLMwTA7JA5Lti-4a3Zc:-KLNQisViyXdftHV3gcu:-499146009) ([raw file](https://github.com/fgpv-vpgf/rcs/blob/23a5273ad0eaffca3df1c2dcc3cede33503e8804/services/regparse/esri.py#L233)):*\n<details><summary><i>Previously, alyec (Aly Merchant) wrote…</i></summary>\n> It's generally better to use `requests` instead of urllib.  This will not work with the feature service proxies and there's a bunch of boilerplate code that can be avoided.  See https://github.com/fgpv-vpgf/rcs/blob/master/services/regparse/esri.py#L190 for an example.\n</details>\nDone.\n\n---\n\n*[services/regparse/esri.py, line 238 \\[r1\\]](https://reviewable.io:443/reviews/fgpv-vpgf/rcs/46#-KLMyG9vz61FlHKRKYi3:-KLNO0lUwx5r-oCIJ5Ey:1065186326) ([raw file](https://github.com/fgpv-vpgf/rcs/blob/23a5273ad0eaffca3df1c2dcc3cede33503e8804/services/regparse/esri.py#L238)):*\n<details><summary><i>Previously, alyec (Aly Merchant) wrote…</i></summary>\n> Is the `[:-1]` to remove the last digit from the URL?  If so this will only work for single digits and it will fail if someone passes a URL ending with `/MapServer`\n</details>\nYes, but the code is only doing this on Group Layers, which in my experience always end in an integer. You do raise a point that this will be ineffective on double digit layers though, I've modified the way this is handled (`.rstrip('1234567890')`)\n\n---\n\n*[services/regparse/esri.py, line 242 \\[r1\\]](https://reviewable.io:443/reviews/fgpv-vpgf/rcs/46#-KLMwtQxBAJSc3Vggpkf:-KLNQdjOlCQ72fHSg1bw:-499146009) ([raw file](https://github.com/fgpv-vpgf/rcs/blob/23a5273ad0eaffca3df1c2dcc3cede33503e8804/services/regparse/esri.py#L242)):*\n<details><summary><i>Previously, alyec (Aly Merchant) wrote…</i></summary>\n> I think `result['layerEntries'] = [{'index': sl['id'] for sl in sublayer_json]` will work, I don't think there's a need to copy everything into `sub_layers` first.\n</details>\nDone.\n\n---\n\n*[services/regparse/ogc.py, line 73 \\[r1\\]](https://reviewable.io:443/reviews/fgpv-vpgf/rcs/46#-KLMzJi9JRM6ROhEgnfV:-KLNNiM1TvKy-xf4jDbu:-890564855) ([raw file](https://github.com/fgpv-vpgf/rcs/blob/23a5273ad0eaffca3df1c2dcc3cede33503e8804/services/regparse/ogc.py#L73)):*\n<details><summary><i>Previously, alyec (Aly Merchant) wrote…</i></summary>\n> Use `requests` here as well if possible.\n</details>\nRequests seems to work only with JSON?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/fgpv-vpgf/rcs/46)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"dan-bowerman"}}