{"action":"closed","number":119,"pull_request":{"url":"https://api.github.com/repos/calcinai/xero-php/pulls/119","id":52648639,"html_url":"https://github.com/calcinai/xero-php/pull/119","diff_url":"https://github.com/calcinai/xero-php/pull/119.diff","patch_url":"https://github.com/calcinai/xero-php/pull/119.patch","issue_url":"https://api.github.com/repos/calcinai/xero-php/issues/119","number":119,"state":"closed","locked":false,"title":"Change DateTime to DateTimeInterface","user":{"login":"M1ke","id":1226123,"avatar_url":"https://avatars.githubusercontent.com/u/1226123?v=3","gravatar_id":"","url":"https://api.github.com/users/M1ke","html_url":"https://github.com/M1ke","followers_url":"https://api.github.com/users/M1ke/followers","following_url":"https://api.github.com/users/M1ke/following{/other_user}","gists_url":"https://api.github.com/users/M1ke/gists{/gist_id}","starred_url":"https://api.github.com/users/M1ke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/M1ke/subscriptions","organizations_url":"https://api.github.com/users/M1ke/orgs","repos_url":"https://api.github.com/users/M1ke/repos","events_url":"https://api.github.com/users/M1ke/events{/privacy}","received_events_url":"https://api.github.com/users/M1ke/received_events","type":"User","site_admin":false},"body":"The ability to choose to use the older `\\DateTime` object or the newer `\\DateTimeImmutable`, or even any other date library which doesn't extend `\\DateTime` but uses `\\DateTimeInterface` improves the flexibility of this library.\r\n\r\nThis PR alters:\r\n\r\n* `\\DateTime` typehints to `\\DateTimeInterface`\r\n* `@return` phpDoc comments\r\n* `@property` phpDoc comments\r\n* `@param` phpDoc comments\r\n* `@var` phpDoc comments\r\n* Object generator strings from \"\\\\DateTime\" to \"\\\\DateTimeInterface\"\r\n\r\nAll tests are passing. No new tests have been added.","created_at":"2015-12-04T09:50:38Z","updated_at":"2016-03-04T12:33:40Z","closed_at":"2016-03-04T12:33:40Z","merged_at":null,"merge_commit_sha":"3afdc0583b95db77caea71f36531ef6680784716","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/calcinai/xero-php/pulls/119/commits","review_comments_url":"https://api.github.com/repos/calcinai/xero-php/pulls/119/comments","review_comment_url":"https://api.github.com/repos/calcinai/xero-php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/calcinai/xero-php/issues/119/comments","statuses_url":"https://api.github.com/repos/calcinai/xero-php/statuses/bd5ca4b34bd52b3db8764933cc237861ffb5a2dd","head":{"label":"sturents:master","ref":"master","sha":"bd5ca4b34bd52b3db8764933cc237861ffb5a2dd","user":{"login":"sturents","id":12842492,"avatar_url":"https://avatars.githubusercontent.com/u/12842492?v=3","gravatar_id":"","url":"https://api.github.com/users/sturents","html_url":"https://github.com/sturents","followers_url":"https://api.github.com/users/sturents/followers","following_url":"https://api.github.com/users/sturents/following{/other_user}","gists_url":"https://api.github.com/users/sturents/gists{/gist_id}","starred_url":"https://api.github.com/users/sturents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sturents/subscriptions","organizations_url":"https://api.github.com/users/sturents/orgs","repos_url":"https://api.github.com/users/sturents/repos","events_url":"https://api.github.com/users/sturents/events{/privacy}","received_events_url":"https://api.github.com/users/sturents/received_events","type":"Organization","site_admin":false},"repo":{"id":46060426,"name":"xero-php","full_name":"sturents/xero-php","owner":{"login":"sturents","id":12842492,"avatar_url":"https://avatars.githubusercontent.com/u/12842492?v=3","gravatar_id":"","url":"https://api.github.com/users/sturents","html_url":"https://github.com/sturents","followers_url":"https://api.github.com/users/sturents/followers","following_url":"https://api.github.com/users/sturents/following{/other_user}","gists_url":"https://api.github.com/users/sturents/gists{/gist_id}","starred_url":"https://api.github.com/users/sturents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sturents/subscriptions","organizations_url":"https://api.github.com/users/sturents/orgs","repos_url":"https://api.github.com/users/sturents/repos","events_url":"https://api.github.com/users/sturents/events{/privacy}","received_events_url":"https://api.github.com/users/sturents/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sturents/xero-php","description":"A php library for the Xero API, with a cleaner OAuth interface and ORM-like abstraction.","fork":true,"url":"https://api.github.com/repos/sturents/xero-php","forks_url":"https://api.github.com/repos/sturents/xero-php/forks","keys_url":"https://api.github.com/repos/sturents/xero-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sturents/xero-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sturents/xero-php/teams","hooks_url":"https://api.github.com/repos/sturents/xero-php/hooks","issue_events_url":"https://api.github.com/repos/sturents/xero-php/issues/events{/number}","events_url":"https://api.github.com/repos/sturents/xero-php/events","assignees_url":"https://api.github.com/repos/sturents/xero-php/assignees{/user}","branches_url":"https://api.github.com/repos/sturents/xero-php/branches{/branch}","tags_url":"https://api.github.com/repos/sturents/xero-php/tags","blobs_url":"https://api.github.com/repos/sturents/xero-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sturents/xero-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sturents/xero-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/sturents/xero-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sturents/xero-php/statuses/{sha}","languages_url":"https://api.github.com/repos/sturents/xero-php/languages","stargazers_url":"https://api.github.com/repos/sturents/xero-php/stargazers","contributors_url":"https://api.github.com/repos/sturents/xero-php/contributors","subscribers_url":"https://api.github.com/repos/sturents/xero-php/subscribers","subscription_url":"https://api.github.com/repos/sturents/xero-php/subscription","commits_url":"https://api.github.com/repos/sturents/xero-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/sturents/xero-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/sturents/xero-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/sturents/xero-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/sturents/xero-php/contents/{+path}","compare_url":"https://api.github.com/repos/sturents/xero-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sturents/xero-php/merges","archive_url":"https://api.github.com/repos/sturents/xero-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sturents/xero-php/downloads","issues_url":"https://api.github.com/repos/sturents/xero-php/issues{/number}","pulls_url":"https://api.github.com/repos/sturents/xero-php/pulls{/number}","milestones_url":"https://api.github.com/repos/sturents/xero-php/milestones{/number}","notifications_url":"https://api.github.com/repos/sturents/xero-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sturents/xero-php/labels{/name}","releases_url":"https://api.github.com/repos/sturents/xero-php/releases{/id}","deployments_url":"https://api.github.com/repos/sturents/xero-php/deployments","created_at":"2015-11-12T15:04:11Z","updated_at":"2015-11-12T15:04:12Z","pushed_at":"2015-12-04T12:46:00Z","git_url":"git://github.com/sturents/xero-php.git","ssh_url":"git@github.com:sturents/xero-php.git","clone_url":"https://github.com/sturents/xero-php.git","svn_url":"https://github.com/sturents/xero-php","homepage":"","size":1190,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"calcinai:master","ref":"master","sha":"08a0ab1ba880e526251214bf671c40b3be87745a","user":{"login":"calcinai","id":2415868,"avatar_url":"https://avatars.githubusercontent.com/u/2415868?v=3","gravatar_id":"","url":"https://api.github.com/users/calcinai","html_url":"https://github.com/calcinai","followers_url":"https://api.github.com/users/calcinai/followers","following_url":"https://api.github.com/users/calcinai/following{/other_user}","gists_url":"https://api.github.com/users/calcinai/gists{/gist_id}","starred_url":"https://api.github.com/users/calcinai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calcinai/subscriptions","organizations_url":"https://api.github.com/users/calcinai/orgs","repos_url":"https://api.github.com/users/calcinai/repos","events_url":"https://api.github.com/users/calcinai/events{/privacy}","received_events_url":"https://api.github.com/users/calcinai/received_events","type":"User","site_admin":false},"repo":{"id":27155380,"name":"xero-php","full_name":"calcinai/xero-php","owner":{"login":"calcinai","id":2415868,"avatar_url":"https://avatars.githubusercontent.com/u/2415868?v=3","gravatar_id":"","url":"https://api.github.com/users/calcinai","html_url":"https://github.com/calcinai","followers_url":"https://api.github.com/users/calcinai/followers","following_url":"https://api.github.com/users/calcinai/following{/other_user}","gists_url":"https://api.github.com/users/calcinai/gists{/gist_id}","starred_url":"https://api.github.com/users/calcinai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calcinai/subscriptions","organizations_url":"https://api.github.com/users/calcinai/orgs","repos_url":"https://api.github.com/users/calcinai/repos","events_url":"https://api.github.com/users/calcinai/events{/privacy}","received_events_url":"https://api.github.com/users/calcinai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/calcinai/xero-php","description":"A php library for the Xero API, with a cleaner OAuth interface and ORM-like abstraction.","fork":false,"url":"https://api.github.com/repos/calcinai/xero-php","forks_url":"https://api.github.com/repos/calcinai/xero-php/forks","keys_url":"https://api.github.com/repos/calcinai/xero-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/calcinai/xero-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/calcinai/xero-php/teams","hooks_url":"https://api.github.com/repos/calcinai/xero-php/hooks","issue_events_url":"https://api.github.com/repos/calcinai/xero-php/issues/events{/number}","events_url":"https://api.github.com/repos/calcinai/xero-php/events","assignees_url":"https://api.github.com/repos/calcinai/xero-php/assignees{/user}","branches_url":"https://api.github.com/repos/calcinai/xero-php/branches{/branch}","tags_url":"https://api.github.com/repos/calcinai/xero-php/tags","blobs_url":"https://api.github.com/repos/calcinai/xero-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/calcinai/xero-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/calcinai/xero-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/calcinai/xero-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/calcinai/xero-php/statuses/{sha}","languages_url":"https://api.github.com/repos/calcinai/xero-php/languages","stargazers_url":"https://api.github.com/repos/calcinai/xero-php/stargazers","contributors_url":"https://api.github.com/repos/calcinai/xero-php/contributors","subscribers_url":"https://api.github.com/repos/calcinai/xero-php/subscribers","subscription_url":"https://api.github.com/repos/calcinai/xero-php/subscription","commits_url":"https://api.github.com/repos/calcinai/xero-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/calcinai/xero-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/calcinai/xero-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/calcinai/xero-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/calcinai/xero-php/contents/{+path}","compare_url":"https://api.github.com/repos/calcinai/xero-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/calcinai/xero-php/merges","archive_url":"https://api.github.com/repos/calcinai/xero-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/calcinai/xero-php/downloads","issues_url":"https://api.github.com/repos/calcinai/xero-php/issues{/number}","pulls_url":"https://api.github.com/repos/calcinai/xero-php/pulls{/number}","milestones_url":"https://api.github.com/repos/calcinai/xero-php/milestones{/number}","notifications_url":"https://api.github.com/repos/calcinai/xero-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/calcinai/xero-php/labels{/name}","releases_url":"https://api.github.com/repos/calcinai/xero-php/releases{/id}","deployments_url":"https://api.github.com/repos/calcinai/xero-php/deployments","created_at":"2014-11-26T02:06:16Z","updated_at":"2016-02-23T20:04:53Z","pushed_at":"2016-03-04T12:26:14Z","git_url":"git://github.com/calcinai/xero-php.git","ssh_url":"git@github.com:calcinai/xero-php.git","clone_url":"https://github.com/calcinai/xero-php.git","svn_url":"https://github.com/calcinai/xero-php","homepage":"","size":1385,"stargazers_count":47,"watchers_count":47,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":19,"forks":29,"open_issues":19,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/calcinai/xero-php/pulls/119"},"html":{"href":"https://github.com/calcinai/xero-php/pull/119"},"issue":{"href":"https://api.github.com/repos/calcinai/xero-php/issues/119"},"comments":{"href":"https://api.github.com/repos/calcinai/xero-php/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/calcinai/xero-php/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/calcinai/xero-php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/calcinai/xero-php/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/calcinai/xero-php/statuses/bd5ca4b34bd52b3db8764933cc237861ffb5a2dd"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":1,"commits":9,"additions":356,"deletions":356,"changed_files":42}}