{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/79501247","id":79501247,"diff_hunk":"@@ -57,16 +57,33 @@ function getConfig() {\n   return extend(obj, karmaConfig.default);\n }\n \n-function getAdExtensions() {\n-  const adNetworks = [];\n+function getAdTypes() {","path":"build-system/tasks/runtime-test.js","position":6,"original_position":6,"commit_id":"d2491a96ea8e0ddef04b7db7e0a38faa82926cb3","original_commit_id":"d2491a96ea8e0ddef04b7db7e0a38faa82926cb3","user":{"login":"zhouyx","id":5419904,"avatar_url":"https://avatars.githubusercontent.com/u/5419904?v=3","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},"body":"looks good. Just one thing that confused me at first glance. I thought adType should have included all ad types. But then I realized it doesn't include `doubleclick` and `adsense`. Can we still call it `adExtensions`? ","created_at":"2016-09-19T22:14:01Z","updated_at":"2016-09-19T22:17:44Z","html_url":"https://github.com/ampproject/amphtml/pull/5084#discussion_r79501247","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/5084","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/79501247"},"html":{"href":"https://github.com/ampproject/amphtml/pull/5084#discussion_r79501247"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/5084"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/5084","id":85845931,"html_url":"https://github.com/ampproject/amphtml/pull/5084","diff_url":"https://github.com/ampproject/amphtml/pull/5084.diff","patch_url":"https://github.com/ampproject/amphtml/pull/5084.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/5084","number":5084,"state":"open","locked":false,"title":"Makes ads/_config.js contain full list of ad networks","user":{"login":"lannka","id":8496897,"avatar_url":"https://avatars.githubusercontent.com/u/8496897?v=3","gravatar_id":"","url":"https://api.github.com/users/lannka","html_url":"https://github.com/lannka","followers_url":"https://api.github.com/users/lannka/followers","following_url":"https://api.github.com/users/lannka/following{/other_user}","gists_url":"https://api.github.com/users/lannka/gists{/gist_id}","starred_url":"https://api.github.com/users/lannka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lannka/subscriptions","organizations_url":"https://api.github.com/users/lannka/orgs","repos_url":"https://api.github.com/users/lannka/repos","events_url":"https://api.github.com/users/lannka/events{/privacy}","received_events_url":"https://api.github.com/users/lannka/received_events","type":"User","site_admin":false},"body":"Added test to enforce it.\r\nBenefits:\r\n\r\n- Force all ad network to take a look at the config file to see if they can take advantage of features like preconnect and render-start API.\r\n- So we can print user error if publisher has mis-used an unknown `type` in `amp-ad`.\r\n- Simplifies code a little bit (avoid null check in multiple places).\r\n\r\nThis is a follow up work to #5068","created_at":"2016-09-19T18:35:41Z","updated_at":"2016-09-19T22:17:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bed17d104ea6f40458108ed8ebb5b7edb2120dce","assignee":{"login":"zhouyx","id":5419904,"avatar_url":"https://avatars.githubusercontent.com/u/5419904?v=3","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},"assignees":[{"login":"zhouyx","id":5419904,"avatar_url":"https://avatars.githubusercontent.com/u/5419904?v=3","gravatar_id":"","url":"https://api.github.com/users/zhouyx","html_url":"https://github.com/zhouyx","followers_url":"https://api.github.com/users/zhouyx/followers","following_url":"https://api.github.com/users/zhouyx/following{/other_user}","gists_url":"https://api.github.com/users/zhouyx/gists{/gist_id}","starred_url":"https://api.github.com/users/zhouyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhouyx/subscriptions","organizations_url":"https://api.github.com/users/zhouyx/orgs","repos_url":"https://api.github.com/users/zhouyx/repos","events_url":"https://api.github.com/users/zhouyx/events{/privacy}","received_events_url":"https://api.github.com/users/zhouyx/received_events","type":"User","site_admin":false},{"login":"tdrl","id":17705064,"avatar_url":"https://avatars.githubusercontent.com/u/17705064?v=3","gravatar_id":"","url":"https://api.github.com/users/tdrl","html_url":"https://github.com/tdrl","followers_url":"https://api.github.com/users/tdrl/followers","following_url":"https://api.github.com/users/tdrl/following{/other_user}","gists_url":"https://api.github.com/users/tdrl/gists{/gist_id}","starred_url":"https://api.github.com/users/tdrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdrl/subscriptions","organizations_url":"https://api.github.com/users/tdrl/orgs","repos_url":"https://api.github.com/users/tdrl/repos","events_url":"https://api.github.com/users/tdrl/events{/privacy}","received_events_url":"https://api.github.com/users/tdrl/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/5084/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/5084/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/5084/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/d2491a96ea8e0ddef04b7db7e0a38faa82926cb3","head":{"label":"lannka:ad_config_2","ref":"ad_config_2","sha":"d2491a96ea8e0ddef04b7db7e0a38faa82926cb3","user":{"login":"lannka","id":8496897,"avatar_url":"https://avatars.githubusercontent.com/u/8496897?v=3","gravatar_id":"","url":"https://api.github.com/users/lannka","html_url":"https://github.com/lannka","followers_url":"https://api.github.com/users/lannka/followers","following_url":"https://api.github.com/users/lannka/following{/other_user}","gists_url":"https://api.github.com/users/lannka/gists{/gist_id}","starred_url":"https://api.github.com/users/lannka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lannka/subscriptions","organizations_url":"https://api.github.com/users/lannka/orgs","repos_url":"https://api.github.com/users/lannka/repos","events_url":"https://api.github.com/users/lannka/events{/privacy}","received_events_url":"https://api.github.com/users/lannka/received_events","type":"User","site_admin":false},"repo":{"id":60651806,"name":"amphtml","full_name":"lannka/amphtml","owner":{"login":"lannka","id":8496897,"avatar_url":"https://avatars.githubusercontent.com/u/8496897?v=3","gravatar_id":"","url":"https://api.github.com/users/lannka","html_url":"https://github.com/lannka","followers_url":"https://api.github.com/users/lannka/followers","following_url":"https://api.github.com/users/lannka/following{/other_user}","gists_url":"https://api.github.com/users/lannka/gists{/gist_id}","starred_url":"https://api.github.com/users/lannka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lannka/subscriptions","organizations_url":"https://api.github.com/users/lannka/orgs","repos_url":"https://api.github.com/users/lannka/repos","events_url":"https://api.github.com/users/lannka/events{/privacy}","received_events_url":"https://api.github.com/users/lannka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lannka/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/lannka/amphtml","forks_url":"https://api.github.com/repos/lannka/amphtml/forks","keys_url":"https://api.github.com/repos/lannka/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lannka/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lannka/amphtml/teams","hooks_url":"https://api.github.com/repos/lannka/amphtml/hooks","issue_events_url":"https://api.github.com/repos/lannka/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/lannka/amphtml/events","assignees_url":"https://api.github.com/repos/lannka/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/lannka/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/lannka/amphtml/tags","blobs_url":"https://api.github.com/repos/lannka/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lannka/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lannka/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/lannka/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lannka/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/lannka/amphtml/languages","stargazers_url":"https://api.github.com/repos/lannka/amphtml/stargazers","contributors_url":"https://api.github.com/repos/lannka/amphtml/contributors","subscribers_url":"https://api.github.com/repos/lannka/amphtml/subscribers","subscription_url":"https://api.github.com/repos/lannka/amphtml/subscription","commits_url":"https://api.github.com/repos/lannka/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/lannka/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/lannka/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/lannka/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/lannka/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/lannka/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lannka/amphtml/merges","archive_url":"https://api.github.com/repos/lannka/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lannka/amphtml/downloads","issues_url":"https://api.github.com/repos/lannka/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/lannka/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/lannka/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/lannka/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lannka/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/lannka/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/lannka/amphtml/deployments","created_at":"2016-06-07T22:50:13Z","updated_at":"2016-06-07T22:50:18Z","pushed_at":"2016-09-19T21:59:25Z","git_url":"git://github.com/lannka/amphtml.git","ssh_url":"git@github.com:lannka/amphtml.git","clone_url":"https://github.com/lannka/amphtml.git","svn_url":"https://github.com/lannka/amphtml","homepage":"https://ampproject.org","size":162368,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"82aab221ec95136d040a6bdb0afd619c7a17b0ef","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2016-09-19T18:38:33Z","pushed_at":"2016-09-19T21:59:22Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":201666,"stargazers_count":8488,"watchers_count":8488,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1257,"mirror_url":null,"open_issues_count":762,"forks":1257,"open_issues":762,"watchers":8488,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/5084"},"html":{"href":"https://github.com/ampproject/amphtml/pull/5084"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/5084"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/5084/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/5084/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/5084/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/d2491a96ea8e0ddef04b7db7e0a38faa82926cb3"}}}}
{"actor":{"display_login":"zhouyx"}}