{"action":"created","issue":{"url":"https://api.github.com/repos/getk2/k2/issues/319","repository_url":"https://api.github.com/repos/getk2/k2","labels_url":"https://api.github.com/repos/getk2/k2/issues/319/labels{/name}","comments_url":"https://api.github.com/repos/getk2/k2/issues/319/comments","events_url":"https://api.github.com/repos/getk2/k2/issues/319/events","html_url":"https://github.com/getk2/k2/pull/319","id":153285350,"number":319,"title":"Approve ordering url parameter in K2ControllerItemlist","user":{"login":"WooDzu","id":2228236,"avatar_url":"https://avatars.githubusercontent.com/u/2228236?v=3","gravatar_id":"","url":"https://api.github.com/users/WooDzu","html_url":"https://github.com/WooDzu","followers_url":"https://api.github.com/users/WooDzu/followers","following_url":"https://api.github.com/users/WooDzu/following{/other_user}","gists_url":"https://api.github.com/users/WooDzu/gists{/gist_id}","starred_url":"https://api.github.com/users/WooDzu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WooDzu/subscriptions","organizations_url":"https://api.github.com/users/WooDzu/orgs","repos_url":"https://api.github.com/users/WooDzu/repos","events_url":"https://api.github.com/users/WooDzu/events{/privacy}","received_events_url":"https://api.github.com/users/WooDzu/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-05-05T17:49:24Z","updated_at":"2016-08-05T08:57:20Z","closed_at":"2016-08-05T08:55:43Z","pull_request":{"url":"https://api.github.com/repos/getk2/k2/pulls/319","html_url":"https://github.com/getk2/k2/pull/319","diff_url":"https://github.com/getk2/k2/pull/319.diff","patch_url":"https://github.com/getk2/k2/pull/319.patch"},"body":"Since 'ordering' is a parameter used by K2ModelItemlist to sort records it makes sense to let caching know about it.\r\n\r\nOtherwise requests such as:\r\n/component/k2/itemlist?format=json&ordering=hits&limit=10\r\n/component/k2/itemlist?format=json&ordering=date&limit=10\r\nwould return the same results since the 2nd request is a cache hit as 'ordering' is not distinguished."},"comment":{"url":"https://api.github.com/repos/getk2/k2/issues/comments/237796354","html_url":"https://github.com/getk2/k2/pull/319#issuecomment-237796354","issue_url":"https://api.github.com/repos/getk2/k2/issues/319","id":237796354,"user":{"login":"fevangelou","id":1301787,"avatar_url":"https://avatars.githubusercontent.com/u/1301787?v=3","gravatar_id":"","url":"https://api.github.com/users/fevangelou","html_url":"https://github.com/fevangelou","followers_url":"https://api.github.com/users/fevangelou/followers","following_url":"https://api.github.com/users/fevangelou/following{/other_user}","gists_url":"https://api.github.com/users/fevangelou/gists{/gist_id}","starred_url":"https://api.github.com/users/fevangelou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fevangelou/subscriptions","organizations_url":"https://api.github.com/users/fevangelou/orgs","repos_url":"https://api.github.com/users/fevangelou/repos","events_url":"https://api.github.com/users/fevangelou/events{/privacy}","received_events_url":"https://api.github.com/users/fevangelou/received_events","type":"User","site_admin":false},"created_at":"2016-08-05T08:57:20Z","updated_at":"2016-08-05T08:57:20Z","body":"BTW, I would recommend you make a list of proposed additions or changes (in a separate issue) so we can discuss them first and then make PRs individually. I'm respecting YOUR time first and foremost :)"}}
{"actor":{"display_login":"fevangelou"}}