{"action":"created","comment":{"url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/pulls/comments/93634027","pull_request_review_id":14165690,"id":93634027,"diff_hunk":"@@ -1132,9 +1132,12 @@ public function getInvoicingFromOrder(\n             }\n             $params['no'] = $position->getQuantity(); // ordered quantity\n             $params['de'] = substr($position->getArticleName(), 0, 100); // description\n+            \n+            // Check if article is a AboCommerce Discount\n+            $isAboCommerceDiscount = (strpos($position->getArticlename(), 'ABO_DISCOUNT') == false) ? false : true;","path":"Frontend/MoptPaymentPayone/Components/Classes/PayoneParamBuilder.php","position":6,"original_position":6,"commit_id":"3bc761b36af232ec211fcea556b41b9efe89bdac","original_commit_id":"3bc761b36af232ec211fcea556b41b9efe89bdac","user":{"login":"fjbender","id":7370694,"avatar_url":"https://avatars.githubusercontent.com/u/7370694?v=3","gravatar_id":"","url":"https://api.github.com/users/fjbender","html_url":"https://github.com/fjbender","followers_url":"https://api.github.com/users/fjbender/followers","following_url":"https://api.github.com/users/fjbender/following{/other_user}","gists_url":"https://api.github.com/users/fjbender/gists{/gist_id}","starred_url":"https://api.github.com/users/fjbender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjbender/subscriptions","organizations_url":"https://api.github.com/users/fjbender/orgs","repos_url":"https://api.github.com/users/fjbender/repos","events_url":"https://api.github.com/users/fjbender/events{/privacy}","received_events_url":"https://api.github.com/users/fjbender/received_events","type":"User","site_admin":false},"body":"Shouldn't we use strict comparison `===` here?","created_at":"2016-12-22T14:41:48Z","updated_at":"2016-12-22T14:41:56Z","html_url":"https://github.com/PAYONE-GmbH/shopware-5/pull/50#discussion_r93634027","pull_request_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/pulls/comments/93634027"},"html":{"href":"https://github.com/PAYONE-GmbH/shopware-5/pull/50#discussion_r93634027"},"pull_request":{"href":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/pulls/50","id":99109737,"html_url":"https://github.com/PAYONE-GmbH/shopware-5/pull/50","diff_url":"https://github.com/PAYONE-GmbH/shopware-5/pull/50.diff","patch_url":"https://github.com/PAYONE-GmbH/shopware-5/pull/50.patch","issue_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/issues/50","number":50,"state":"open","locked":false,"title":"- buildAndCallPayment now uses getInvoicingfromOrder() to obtain orde…","user":{"login":"Fatchip-Support","id":19286591,"avatar_url":"https://avatars.githubusercontent.com/u/19286591?v=3","gravatar_id":"","url":"https://api.github.com/users/Fatchip-Support","html_url":"https://github.com/Fatchip-Support","followers_url":"https://api.github.com/users/Fatchip-Support/followers","following_url":"https://api.github.com/users/Fatchip-Support/following{/other_user}","gists_url":"https://api.github.com/users/Fatchip-Support/gists{/gist_id}","starred_url":"https://api.github.com/users/Fatchip-Support/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fatchip-Support/subscriptions","organizations_url":"https://api.github.com/users/Fatchip-Support/orgs","repos_url":"https://api.github.com/users/Fatchip-Support/repos","events_url":"https://api.github.com/users/Fatchip-Support/events{/privacy}","received_events_url":"https://api.github.com/users/Fatchip-Support/received_events","type":"User","site_admin":false},"body":"…r positions in case the order was created in the SW Backend (Abocommerce Plugin)\r\n\r\n- fixed tax handling for Abocommerce Discount positions\r\n- fixed exception when using payolution invoice and payolution debit payment methods with Abocommerce Plugin","created_at":"2016-12-22T14:07:19Z","updated_at":"2016-12-22T14:41:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e30e5999794d3a53f6bbc66039731124dd1be177","assignee":{"login":"fjbender","id":7370694,"avatar_url":"https://avatars.githubusercontent.com/u/7370694?v=3","gravatar_id":"","url":"https://api.github.com/users/fjbender","html_url":"https://github.com/fjbender","followers_url":"https://api.github.com/users/fjbender/followers","following_url":"https://api.github.com/users/fjbender/following{/other_user}","gists_url":"https://api.github.com/users/fjbender/gists{/gist_id}","starred_url":"https://api.github.com/users/fjbender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjbender/subscriptions","organizations_url":"https://api.github.com/users/fjbender/orgs","repos_url":"https://api.github.com/users/fjbender/repos","events_url":"https://api.github.com/users/fjbender/events{/privacy}","received_events_url":"https://api.github.com/users/fjbender/received_events","type":"User","site_admin":false},"assignees":[{"login":"fjbender","id":7370694,"avatar_url":"https://avatars.githubusercontent.com/u/7370694?v=3","gravatar_id":"","url":"https://api.github.com/users/fjbender","html_url":"https://github.com/fjbender","followers_url":"https://api.github.com/users/fjbender/followers","following_url":"https://api.github.com/users/fjbender/following{/other_user}","gists_url":"https://api.github.com/users/fjbender/gists{/gist_id}","starred_url":"https://api.github.com/users/fjbender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjbender/subscriptions","organizations_url":"https://api.github.com/users/fjbender/orgs","repos_url":"https://api.github.com/users/fjbender/repos","events_url":"https://api.github.com/users/fjbender/events{/privacy}","received_events_url":"https://api.github.com/users/fjbender/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/pulls/50/commits","review_comments_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/pulls/50/comments","review_comment_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/issues/50/comments","statuses_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/statuses/3bc761b36af232ec211fcea556b41b9efe89bdac","head":{"label":"PAYONE-GmbH:AboCommerce-recurringAction-compatibility","ref":"AboCommerce-recurringAction-compatibility","sha":"3bc761b36af232ec211fcea556b41b9efe89bdac","user":{"login":"PAYONE-GmbH","id":19286286,"avatar_url":"https://avatars.githubusercontent.com/u/19286286?v=3","gravatar_id":"","url":"https://api.github.com/users/PAYONE-GmbH","html_url":"https://github.com/PAYONE-GmbH","followers_url":"https://api.github.com/users/PAYONE-GmbH/followers","following_url":"https://api.github.com/users/PAYONE-GmbH/following{/other_user}","gists_url":"https://api.github.com/users/PAYONE-GmbH/gists{/gist_id}","starred_url":"https://api.github.com/users/PAYONE-GmbH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PAYONE-GmbH/subscriptions","organizations_url":"https://api.github.com/users/PAYONE-GmbH/orgs","repos_url":"https://api.github.com/users/PAYONE-GmbH/repos","events_url":"https://api.github.com/users/PAYONE-GmbH/events{/privacy}","received_events_url":"https://api.github.com/users/PAYONE-GmbH/received_events","type":"Organization","site_admin":false},"repo":{"id":58461391,"name":"shopware-5","full_name":"PAYONE-GmbH/shopware-5","owner":{"login":"PAYONE-GmbH","id":19286286,"avatar_url":"https://avatars.githubusercontent.com/u/19286286?v=3","gravatar_id":"","url":"https://api.github.com/users/PAYONE-GmbH","html_url":"https://github.com/PAYONE-GmbH","followers_url":"https://api.github.com/users/PAYONE-GmbH/followers","following_url":"https://api.github.com/users/PAYONE-GmbH/following{/other_user}","gists_url":"https://api.github.com/users/PAYONE-GmbH/gists{/gist_id}","starred_url":"https://api.github.com/users/PAYONE-GmbH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PAYONE-GmbH/subscriptions","organizations_url":"https://api.github.com/users/PAYONE-GmbH/orgs","repos_url":"https://api.github.com/users/PAYONE-GmbH/repos","events_url":"https://api.github.com/users/PAYONE-GmbH/events{/privacy}","received_events_url":"https://api.github.com/users/PAYONE-GmbH/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PAYONE-GmbH/shopware-5","description":"PAYONE Payment Plugin for shopware 5","fork":false,"url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5","forks_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/forks","keys_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/teams","hooks_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/hooks","issue_events_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/issues/events{/number}","events_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/events","assignees_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/assignees{/user}","branches_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/branches{/branch}","tags_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/tags","blobs_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/git/refs{/sha}","trees_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/statuses/{sha}","languages_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/languages","stargazers_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/stargazers","contributors_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/contributors","subscribers_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/subscribers","subscription_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/subscription","commits_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/commits{/sha}","git_commits_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/git/commits{/sha}","comments_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/comments{/number}","issue_comment_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/issues/comments{/number}","contents_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/contents/{+path}","compare_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/merges","archive_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/downloads","issues_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/issues{/number}","pulls_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/pulls{/number}","milestones_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/milestones{/number}","notifications_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/labels{/name}","releases_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/releases{/id}","deployments_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/deployments","created_at":"2016-05-10T12:56:58Z","updated_at":"2016-12-08T12:27:06Z","pushed_at":"2016-12-22T14:07:20Z","git_url":"git://github.com/PAYONE-GmbH/shopware-5.git","ssh_url":"git@github.com:PAYONE-GmbH/shopware-5.git","clone_url":"https://github.com/PAYONE-GmbH/shopware-5.git","svn_url":"https://github.com/PAYONE-GmbH/shopware-5","homepage":null,"size":7147,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":2,"default_branch":"master"}},"base":{"label":"PAYONE-GmbH:master","ref":"master","sha":"1f29f1c063ea65e2f3962cf4e255f0d92fb076b3","user":{"login":"PAYONE-GmbH","id":19286286,"avatar_url":"https://avatars.githubusercontent.com/u/19286286?v=3","gravatar_id":"","url":"https://api.github.com/users/PAYONE-GmbH","html_url":"https://github.com/PAYONE-GmbH","followers_url":"https://api.github.com/users/PAYONE-GmbH/followers","following_url":"https://api.github.com/users/PAYONE-GmbH/following{/other_user}","gists_url":"https://api.github.com/users/PAYONE-GmbH/gists{/gist_id}","starred_url":"https://api.github.com/users/PAYONE-GmbH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PAYONE-GmbH/subscriptions","organizations_url":"https://api.github.com/users/PAYONE-GmbH/orgs","repos_url":"https://api.github.com/users/PAYONE-GmbH/repos","events_url":"https://api.github.com/users/PAYONE-GmbH/events{/privacy}","received_events_url":"https://api.github.com/users/PAYONE-GmbH/received_events","type":"Organization","site_admin":false},"repo":{"id":58461391,"name":"shopware-5","full_name":"PAYONE-GmbH/shopware-5","owner":{"login":"PAYONE-GmbH","id":19286286,"avatar_url":"https://avatars.githubusercontent.com/u/19286286?v=3","gravatar_id":"","url":"https://api.github.com/users/PAYONE-GmbH","html_url":"https://github.com/PAYONE-GmbH","followers_url":"https://api.github.com/users/PAYONE-GmbH/followers","following_url":"https://api.github.com/users/PAYONE-GmbH/following{/other_user}","gists_url":"https://api.github.com/users/PAYONE-GmbH/gists{/gist_id}","starred_url":"https://api.github.com/users/PAYONE-GmbH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PAYONE-GmbH/subscriptions","organizations_url":"https://api.github.com/users/PAYONE-GmbH/orgs","repos_url":"https://api.github.com/users/PAYONE-GmbH/repos","events_url":"https://api.github.com/users/PAYONE-GmbH/events{/privacy}","received_events_url":"https://api.github.com/users/PAYONE-GmbH/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PAYONE-GmbH/shopware-5","description":"PAYONE Payment Plugin for shopware 5","fork":false,"url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5","forks_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/forks","keys_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/teams","hooks_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/hooks","issue_events_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/issues/events{/number}","events_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/events","assignees_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/assignees{/user}","branches_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/branches{/branch}","tags_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/tags","blobs_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/git/refs{/sha}","trees_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/statuses/{sha}","languages_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/languages","stargazers_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/stargazers","contributors_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/contributors","subscribers_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/subscribers","subscription_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/subscription","commits_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/commits{/sha}","git_commits_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/git/commits{/sha}","comments_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/comments{/number}","issue_comment_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/issues/comments{/number}","contents_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/contents/{+path}","compare_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/merges","archive_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/downloads","issues_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/issues{/number}","pulls_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/pulls{/number}","milestones_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/milestones{/number}","notifications_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/labels{/name}","releases_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/releases{/id}","deployments_url":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/deployments","created_at":"2016-05-10T12:56:58Z","updated_at":"2016-12-08T12:27:06Z","pushed_at":"2016-12-22T14:07:20Z","git_url":"git://github.com/PAYONE-GmbH/shopware-5.git","ssh_url":"git@github.com:PAYONE-GmbH/shopware-5.git","clone_url":"https://github.com/PAYONE-GmbH/shopware-5.git","svn_url":"https://github.com/PAYONE-GmbH/shopware-5","homepage":null,"size":7147,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/pulls/50"},"html":{"href":"https://github.com/PAYONE-GmbH/shopware-5/pull/50"},"issue":{"href":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/issues/50"},"comments":{"href":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/PAYONE-GmbH/shopware-5/statuses/3bc761b36af232ec211fcea556b41b9efe89bdac"}}}}
{"actor":{"display_login":"fjbender"}}