{"action":"created","issue":{"url":"https://api.github.com/repos/frctl/mandelbrot/issues/38","repository_url":"https://api.github.com/repos/frctl/mandelbrot","labels_url":"https://api.github.com/repos/frctl/mandelbrot/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/frctl/mandelbrot/issues/38/comments","events_url":"https://api.github.com/repos/frctl/mandelbrot/issues/38/events","html_url":"https://github.com/frctl/mandelbrot/issues/38","id":171620065,"number":38,"title":"Mixing variants and components in navigation can cause 😜🤕","user":{"login":"paulrobertlloyd","id":813383,"avatar_url":"https://avatars.githubusercontent.com/u/813383?v=3","gravatar_id":"","url":"https://api.github.com/users/paulrobertlloyd","html_url":"https://github.com/paulrobertlloyd","followers_url":"https://api.github.com/users/paulrobertlloyd/followers","following_url":"https://api.github.com/users/paulrobertlloyd/following{/other_user}","gists_url":"https://api.github.com/users/paulrobertlloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/paulrobertlloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulrobertlloyd/subscriptions","organizations_url":"https://api.github.com/users/paulrobertlloyd/orgs","repos_url":"https://api.github.com/users/paulrobertlloyd/repos","events_url":"https://api.github.com/users/paulrobertlloyd/events{/privacy}","received_events_url":"https://api.github.com/users/paulrobertlloyd/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/frctl/mandelbrot/labels/feature%20request","name":"feature request","color":"006b75"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-17T10:02:47Z","updated_at":"2016-08-26T22:16:15Z","closed_at":null,"body":"First, some background. I’m working on a project which is using React components, each with an associated test for its different states (e.g. menu hidden, menu shown). These states have been configured as variants. With each component having a series of states/variants, the navigation has become overly complex, essentially because it is serving multiple purposes.\r\n\r\n* * *\r\n\r\nBy default, a component’s variants appear in the navigation as a nested list. For smaller components (i.e. our good friend the button), we can use the `collated` config option, and show them together on the same page. This provides a single link in the navigation: perfect!\r\n\r\nFor larger components—and those that use absolute positioning—showing them together on the same page is not desirable. Thus, each variant is shown in the navigation. With a lot of components, each with a series of variants, the navigation soon becomes overloaded, with no distinction between a collection of components and a component with variants.\r\n\r\n**Proposal 1**: The smallest possible change. Style variants slightly differently from components, perhaps italicised, to aid the distinction between these different types.\r\n\r\n**Proposal 2**: A larger, more effective change. Leave the navigation purely as a means of traversing different components, docs and assets. Within the component ‘pen’, add a second menu that allows a user to view different variants.\r\n\r\nThe current design is well suited to smaller projects, but for larger systems, it starts to break down. At which point, @allmarkedup will tell me that I should create a bespoke theme… 😉"},"comment":{"url":"https://api.github.com/repos/frctl/mandelbrot/issues/comments/242865125","html_url":"https://github.com/frctl/mandelbrot/issues/38#issuecomment-242865125","issue_url":"https://api.github.com/repos/frctl/mandelbrot/issues/38","id":242865125,"user":{"login":"ixley","id":160662,"avatar_url":"https://avatars.githubusercontent.com/u/160662?v=3","gravatar_id":"","url":"https://api.github.com/users/ixley","html_url":"https://github.com/ixley","followers_url":"https://api.github.com/users/ixley/followers","following_url":"https://api.github.com/users/ixley/following{/other_user}","gists_url":"https://api.github.com/users/ixley/gists{/gist_id}","starred_url":"https://api.github.com/users/ixley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixley/subscriptions","organizations_url":"https://api.github.com/users/ixley/orgs","repos_url":"https://api.github.com/users/ixley/repos","events_url":"https://api.github.com/users/ixley/events{/privacy}","received_events_url":"https://api.github.com/users/ixley/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T22:16:14Z","updated_at":"2016-08-26T22:16:14Z","body":"I'm not familiar what all would be involved in supporting better navigation for variants, but also agree that this is a logical next step for Fractal's growth and that it should be incorporated into the default theme."}}
{"actor":{"display_login":"ixley"}}