{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/comments/68452992","id":68452992,"diff_hunk":"@@ -22,13 +22,17 @@\n  * Zipkin settings\n  *\n  * @author Spencer Gibb\n+ * @author Brock Overcash\n  * @since 1.0.0\n  */\n @ConfigurationProperties(\"spring.zipkin\")\n public class ZipkinProperties {\n \t/** URL of the zipkin query server instance. */\n \tprivate String baseUrl = \"http://localhost:9411/\";\n \tprivate boolean enabled = true;\n+\tprivate boolean basicAuthenticated = false;\n+\tprivate String username = \"admin\";","path":"spring-cloud-sleuth-zipkin/src/main/java/org/springframework/cloud/sleuth/zipkin/ZipkinProperties.java","position":13,"original_position":13,"commit_id":"3a878cdab405ca3ae0fb183ed905b41be0cb4a9b","original_commit_id":"3a878cdab405ca3ae0fb183ed905b41be0cb4a9b","user":{"login":"brockovercash","id":2043845,"avatar_url":"https://avatars.githubusercontent.com/u/2043845?v=3","gravatar_id":"","url":"https://api.github.com/users/brockovercash","html_url":"https://github.com/brockovercash","followers_url":"https://api.github.com/users/brockovercash/followers","following_url":"https://api.github.com/users/brockovercash/following{/other_user}","gists_url":"https://api.github.com/users/brockovercash/gists{/gist_id}","starred_url":"https://api.github.com/users/brockovercash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brockovercash/subscriptions","organizations_url":"https://api.github.com/users/brockovercash/orgs","repos_url":"https://api.github.com/users/brockovercash/repos","events_url":"https://api.github.com/users/brockovercash/events{/privacy}","received_events_url":"https://api.github.com/users/brockovercash/received_events","type":"User","site_admin":false},"body":"Which lines specifically? I think basicAuthenticated should default to false, but I agree username and password don't need defaults. I included them because all of the others had defaults.  ","created_at":"2016-06-24T19:50:48Z","updated_at":"2016-06-24T19:50:48Z","html_url":"https://github.com/spring-cloud/spring-cloud-sleuth/pull/314#discussion_r68452992","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/314","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/comments/68452992"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-sleuth/pull/314#discussion_r68452992"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/314"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/314","id":75162767,"html_url":"https://github.com/spring-cloud/spring-cloud-sleuth/pull/314","diff_url":"https://github.com/spring-cloud/spring-cloud-sleuth/pull/314.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-sleuth/pull/314.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/314","number":314,"state":"open","locked":false,"title":"Add basic auth support to HttpZipkinSpanReporter","user":{"login":"brockovercash","id":2043845,"avatar_url":"https://avatars.githubusercontent.com/u/2043845?v=3","gravatar_id":"","url":"https://api.github.com/users/brockovercash","html_url":"https://github.com/brockovercash","followers_url":"https://api.github.com/users/brockovercash/followers","following_url":"https://api.github.com/users/brockovercash/following{/other_user}","gists_url":"https://api.github.com/users/brockovercash/gists{/gist_id}","starred_url":"https://api.github.com/users/brockovercash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brockovercash/subscriptions","organizations_url":"https://api.github.com/users/brockovercash/orgs","repos_url":"https://api.github.com/users/brockovercash/repos","events_url":"https://api.github.com/users/brockovercash/events{/privacy}","received_events_url":"https://api.github.com/users/brockovercash/received_events","type":"User","site_admin":false},"body":"I would like to use Basic Auth to make my Zipkin server a little more secure and needed to implement this into the SpanReporter. This is definitely a simple solution and I see some potential for refactoring the Auth element into a class so that things like \" Basic b64token\" string only has to be created once. I'll update the PR if I do that.","created_at":"2016-06-24T19:35:40Z","updated_at":"2016-06-24T19:50:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1456a996784ab463fd92a1e2fa472395bee86ccf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/314/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/314/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/314/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/statuses/3a878cdab405ca3ae0fb183ed905b41be0cb4a9b","head":{"label":"brockovercash:master","ref":"master","sha":"3a878cdab405ca3ae0fb183ed905b41be0cb4a9b","user":{"login":"brockovercash","id":2043845,"avatar_url":"https://avatars.githubusercontent.com/u/2043845?v=3","gravatar_id":"","url":"https://api.github.com/users/brockovercash","html_url":"https://github.com/brockovercash","followers_url":"https://api.github.com/users/brockovercash/followers","following_url":"https://api.github.com/users/brockovercash/following{/other_user}","gists_url":"https://api.github.com/users/brockovercash/gists{/gist_id}","starred_url":"https://api.github.com/users/brockovercash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brockovercash/subscriptions","organizations_url":"https://api.github.com/users/brockovercash/orgs","repos_url":"https://api.github.com/users/brockovercash/repos","events_url":"https://api.github.com/users/brockovercash/events{/privacy}","received_events_url":"https://api.github.com/users/brockovercash/received_events","type":"User","site_admin":false},"repo":{"id":61907523,"name":"spring-cloud-sleuth","full_name":"brockovercash/spring-cloud-sleuth","owner":{"login":"brockovercash","id":2043845,"avatar_url":"https://avatars.githubusercontent.com/u/2043845?v=3","gravatar_id":"","url":"https://api.github.com/users/brockovercash","html_url":"https://github.com/brockovercash","followers_url":"https://api.github.com/users/brockovercash/followers","following_url":"https://api.github.com/users/brockovercash/following{/other_user}","gists_url":"https://api.github.com/users/brockovercash/gists{/gist_id}","starred_url":"https://api.github.com/users/brockovercash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brockovercash/subscriptions","organizations_url":"https://api.github.com/users/brockovercash/orgs","repos_url":"https://api.github.com/users/brockovercash/repos","events_url":"https://api.github.com/users/brockovercash/events{/privacy}","received_events_url":"https://api.github.com/users/brockovercash/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brockovercash/spring-cloud-sleuth","description":"Distributed tracing for spring cloud","fork":true,"url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth","forks_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/forks","keys_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/teams","hooks_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/hooks","issue_events_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/issues/events{/number}","events_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/events","assignees_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/assignees{/user}","branches_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/branches{/branch}","tags_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/tags","blobs_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/git/refs{/sha}","trees_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/statuses/{sha}","languages_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/languages","stargazers_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/stargazers","contributors_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/contributors","subscribers_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/subscribers","subscription_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/subscription","commits_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/commits{/sha}","git_commits_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/git/commits{/sha}","comments_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/comments{/number}","issue_comment_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/issues/comments{/number}","contents_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/contents/{+path}","compare_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/merges","archive_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/downloads","issues_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/issues{/number}","pulls_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/pulls{/number}","milestones_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/milestones{/number}","notifications_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/labels{/name}","releases_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/releases{/id}","deployments_url":"https://api.github.com/repos/brockovercash/spring-cloud-sleuth/deployments","created_at":"2016-06-24T19:26:12Z","updated_at":"2016-06-24T19:26:14Z","pushed_at":"2016-06-24T19:31:24Z","git_url":"git://github.com/brockovercash/spring-cloud-sleuth.git","ssh_url":"git@github.com:brockovercash/spring-cloud-sleuth.git","clone_url":"https://github.com/brockovercash/spring-cloud-sleuth.git","svn_url":"https://github.com/brockovercash/spring-cloud-sleuth","homepage":"http://cloud.spring.io","size":4680,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"e4e36d42b7e7173a759ff1f10a055bc722d280e4","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":31788540,"name":"spring-cloud-sleuth","full_name":"spring-cloud/spring-cloud-sleuth","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-sleuth","description":"Distributed tracing for spring cloud","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/deployments","created_at":"2015-03-06T20:51:47Z","updated_at":"2016-06-22T06:12:46Z","pushed_at":"2016-06-24T19:35:41Z","git_url":"git://github.com/spring-cloud/spring-cloud-sleuth.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-sleuth.git","clone_url":"https://github.com/spring-cloud/spring-cloud-sleuth.git","svn_url":"https://github.com/spring-cloud/spring-cloud-sleuth","homepage":"http://cloud.spring.io","size":4680,"stargazers_count":122,"watchers_count":122,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":58,"mirror_url":null,"open_issues_count":21,"forks":58,"open_issues":21,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/314"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-sleuth/pull/314"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/314"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/issues/314/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/314/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/pulls/314/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-sleuth/statuses/3a878cdab405ca3ae0fb183ed905b41be0cb4a9b"}}}}
{"actor":{"display_login":"brockovercash"}}