{"action":"closed","issue":{"url":"https://api.github.com/repos/getsentry/raven-go/issues/90","repository_url":"https://api.github.com/repos/getsentry/raven-go","labels_url":"https://api.github.com/repos/getsentry/raven-go/issues/90/labels{/name}","comments_url":"https://api.github.com/repos/getsentry/raven-go/issues/90/comments","events_url":"https://api.github.com/repos/getsentry/raven-go/issues/90/events","html_url":"https://github.com/getsentry/raven-go/issues/90","id":164633934,"number":90,"title":"Leaking goroutines.","user":{"login":"malandrew","id":141789,"avatar_url":"https://avatars.githubusercontent.com/u/141789?v=3","gravatar_id":"","url":"https://api.github.com/users/malandrew","html_url":"https://github.com/malandrew","followers_url":"https://api.github.com/users/malandrew/followers","following_url":"https://api.github.com/users/malandrew/following{/other_user}","gists_url":"https://api.github.com/users/malandrew/gists{/gist_id}","starred_url":"https://api.github.com/users/malandrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malandrew/subscriptions","organizations_url":"https://api.github.com/users/malandrew/orgs","repos_url":"https://api.github.com/users/malandrew/repos","events_url":"https://api.github.com/users/malandrew/events{/privacy}","received_events_url":"https://api.github.com/users/malandrew/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"mattrobenolt","id":375744,"avatar_url":"https://avatars.githubusercontent.com/u/375744?v=3","gravatar_id":"","url":"https://api.github.com/users/mattrobenolt","html_url":"https://github.com/mattrobenolt","followers_url":"https://api.github.com/users/mattrobenolt/followers","following_url":"https://api.github.com/users/mattrobenolt/following{/other_user}","gists_url":"https://api.github.com/users/mattrobenolt/gists{/gist_id}","starred_url":"https://api.github.com/users/mattrobenolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattrobenolt/subscriptions","organizations_url":"https://api.github.com/users/mattrobenolt/orgs","repos_url":"https://api.github.com/users/mattrobenolt/repos","events_url":"https://api.github.com/users/mattrobenolt/events{/privacy}","received_events_url":"https://api.github.com/users/mattrobenolt/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattrobenolt","id":375744,"avatar_url":"https://avatars.githubusercontent.com/u/375744?v=3","gravatar_id":"","url":"https://api.github.com/users/mattrobenolt","html_url":"https://github.com/mattrobenolt","followers_url":"https://api.github.com/users/mattrobenolt/followers","following_url":"https://api.github.com/users/mattrobenolt/following{/other_user}","gists_url":"https://api.github.com/users/mattrobenolt/gists{/gist_id}","starred_url":"https://api.github.com/users/mattrobenolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattrobenolt/subscriptions","organizations_url":"https://api.github.com/users/mattrobenolt/orgs","repos_url":"https://api.github.com/users/mattrobenolt/repos","events_url":"https://api.github.com/users/mattrobenolt/events{/privacy}","received_events_url":"https://api.github.com/users/mattrobenolt/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2016-07-08T23:18:17Z","updated_at":"2016-11-15T13:54:12Z","closed_at":"2016-11-15T13:54:11Z","body":"Merely including raven-go results in leaking goroutines. The culprit is this line:\n\nhttps://github.com/getsentry/raven-go/blob/master/client.go#L307\n\nmain.go\n\n```\npackage main\n```\n\nmain_test.go\n\n```\npackage main\n\nimport (\n    \"fmt\"\n    \"os\"\n    \"testing\"\n\n    _ \"github.com/getsentry/raven-go\"\n\n    \"github.com/uber/tchannel-go/testutils/goroutines\"\n)\n\nfunc TestMain(m *testing.M) {\n    exitCode := m.Run()\n    if err := goroutines.IdentifyLeaks(nil); err != nil && exitCode == 0 {\n        fmt.Fprintf(os.Stderr, \"Found goroutine leaks on successful test run: %v\", err)\n        exitCode = 1\n    }\n    os.Exit(exitCode)\n}\n```\n\n```\n$ go test\nPASS\nFound goroutine leaks on successful test run: found unexpected goroutines:\n[Goroutine 5 in state chan receive, with vendor/github.com/getsentry/raven-go.(*Client).worker on top of the stack:\ngoroutine 5 [chan receive]:\nvendor/github.com/getsentry/raven-go.(*Client).worker(0xc8200be210)\n    vendor/github.com/getsentry/raven-go/client.go:418 +0x60\ncreated by vendor/github.com/getsentry/raven-go.newClient\n    vendor/github.com/getsentry/raven-go/client.go:307 +0x193\n]FAIL   test    0.913s\n```\n"}}
{"actor":{"display_login":"mattrobenolt"}}