{"action":"opened","issue":{"url":"https://api.github.com/repos/sot/correct_periscope_drift/issues/21","repository_url":"https://api.github.com/repos/sot/correct_periscope_drift","labels_url":"https://api.github.com/repos/sot/correct_periscope_drift/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/sot/correct_periscope_drift/issues/21/comments","events_url":"https://api.github.com/repos/sot/correct_periscope_drift/issues/21/events","html_url":"https://github.com/sot/correct_periscope_drift/issues/21","id":188325506,"number":21,"title":"Python 3.5 support","user":{"login":"kglotfelty","id":6662179,"avatar_url":"https://avatars.githubusercontent.com/u/6662179?v=3","gravatar_id":"","url":"https://api.github.com/users/kglotfelty","html_url":"https://github.com/kglotfelty","followers_url":"https://api.github.com/users/kglotfelty/followers","following_url":"https://api.github.com/users/kglotfelty/following{/other_user}","gists_url":"https://api.github.com/users/kglotfelty/gists{/gist_id}","starred_url":"https://api.github.com/users/kglotfelty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kglotfelty/subscriptions","organizations_url":"https://api.github.com/users/kglotfelty/orgs","repos_url":"https://api.github.com/users/kglotfelty/repos","events_url":"https://api.github.com/users/kglotfelty/events{/privacy}","received_events_url":"https://api.github.com/users/kglotfelty/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-09T19:02:14Z","updated_at":"2016-11-09T19:02:14Z","closed_at":null,"body":"\r\nFor CIAO 4.9 we are going to have separate Python 2.7 and 3.5 builds of CIAO available for users (knock on wood).  For the contrib code we are working to have a single code base support both builds.\r\n\r\nDoing a test I came across only one problem (in the code I suggested you add in the first place).  Since in 3.5 `zip` now returns an iterator instead of a list, we need to do something like:\r\n\r\n```diff\r\n\r\ndiff --git a/correct_periscope_drift.py b/correct_periscope_drift.py\r\nindex 65c687c..c5e01aa 100755\r\n--- a/correct_periscope_drift.py\r\n+++ b/correct_periscope_drift.py\r\n@@ -370,7 +370,7 @@ def main(opt):\r\n     wcs = events.get_transform(\"eqpos\")\r\n     evt_x = events.get_column(\"x\").values\r\n     evt_y = events.get_column(\"y\").values\r\n-    rd = wcs.apply(zip(evt_x, evt_y))\r\n+    rd = wcs.apply(list(zip(evt_x, evt_y)))\r\n     evt_ra = rd[:, 0]\r\n     evt_dec = rd[:, 1]\r\n     evt_times = events.get_column('Time').values\r\n```\r\n\r\nThis works with both python2.7 and 3.5 (and with CIAO 4.8 as well as CIAO4.9).\r\n\r\n\r\n\r\n\r\n"}}
{"actor":{"display_login":"kglotfelty"}}