{"action":"created","comment":{"url":"https://api.github.com/repos/Nexmo/nexmo-cli/pulls/comments/70165288","id":70165288,"diff_hunk":"@@ -225,6 +225,23 @@ class Request {\n       this.client.instance().numberInsight.get({level: 'standard', number: number}, this.response.insightStandard.bind(this.response));\n     });\n   }\n+\n+  // sending messages\n+\n+  sendSms(first, second, third, command) {","path":"src/request.js","position":16,"original_position":16,"commit_id":"6bae5055039663fa66782101fcf495f4b48a1977","original_commit_id":"6bae5055039663fa66782101fcf495f4b48a1977","user":{"login":"leggetter","id":328367,"avatar_url":"https://avatars.githubusercontent.com/u/328367?v=3","gravatar_id":"","url":"https://api.github.com/users/leggetter","html_url":"https://github.com/leggetter","followers_url":"https://api.github.com/users/leggetter/followers","following_url":"https://api.github.com/users/leggetter/following{/other_user}","gists_url":"https://api.github.com/users/leggetter/gists{/gist_id}","starred_url":"https://api.github.com/users/leggetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leggetter/subscriptions","organizations_url":"https://api.github.com/users/leggetter/orgs","repos_url":"https://api.github.com/users/leggetter/repos","events_url":"https://api.github.com/users/leggetter/events{/privacy}","received_events_url":"https://api.github.com/users/leggetter/received_events","type":"User","site_admin":false},"body":"When the number of arguments isn't set you normally see `arguments` used, so I found that a bit confusing.\r\n\r\nIn ES2015 there's `...` which is used for the \"Rest of the arguments\". See https://babeljs.io/docs/learn-es2015/#default--rest--spread\r\n\r\nThe parameter names - to me - are a little unclear right now. But this is just a nitpick.","created_at":"2016-07-09T10:10:03Z","updated_at":"2016-07-09T10:10:03Z","html_url":"https://github.com/Nexmo/nexmo-cli/pull/78#discussion_r70165288","pull_request_url":"https://api.github.com/repos/Nexmo/nexmo-cli/pulls/78","_links":{"self":{"href":"https://api.github.com/repos/Nexmo/nexmo-cli/pulls/comments/70165288"},"html":{"href":"https://github.com/Nexmo/nexmo-cli/pull/78#discussion_r70165288"},"pull_request":{"href":"https://api.github.com/repos/Nexmo/nexmo-cli/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/Nexmo/nexmo-cli/pulls/78","id":76622193,"html_url":"https://github.com/Nexmo/nexmo-cli/pull/78","diff_url":"https://github.com/Nexmo/nexmo-cli/pull/78.diff","patch_url":"https://github.com/Nexmo/nexmo-cli/pull/78.patch","issue_url":"https://api.github.com/repos/Nexmo/nexmo-cli/issues/78","number":78,"state":"open","locked":false,"title":"Add SMS sending","user":{"login":"cbetta","id":7718,"avatar_url":"https://avatars.githubusercontent.com/u/7718?v=3","gravatar_id":"","url":"https://api.github.com/users/cbetta","html_url":"https://github.com/cbetta","followers_url":"https://api.github.com/users/cbetta/followers","following_url":"https://api.github.com/users/cbetta/following{/other_user}","gists_url":"https://api.github.com/users/cbetta/gists{/gist_id}","starred_url":"https://api.github.com/users/cbetta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbetta/subscriptions","organizations_url":"https://api.github.com/users/cbetta/orgs","repos_url":"https://api.github.com/users/cbetta/repos","events_url":"https://api.github.com/users/cbetta/events{/privacy}","received_events_url":"https://api.github.com/users/cbetta/received_events","type":"User","site_admin":false},"body":"Adds sending of an SMS. Only implements the basics to keep things simple. It auto detects if a `from` sender has been given and if not uses `Nexmo CLI` as the from field.\r\n\r\n```\r\n> nexmo sms <destination_number> \"Hello world!\" --confirm\r\nMessage sent to:   <destination_number>\r\nRemaining balance: 26.80110000 EUR\r\nMessage price:     0.03330000 EUR\r\n\r\n> nexmo sms <from_name_or_number> <destination_number> \"Hello world!\" --confirm\r\nMessage sent to:   <destination_number>\r\nRemaining balance: 26.80110000 EUR\r\nMessage price:     0.03330000 EUR\r\n```\r\n\r\nCloses #17 ","created_at":"2016-07-07T16:04:46Z","updated_at":"2016-07-09T10:10:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10b1e1d9d1ac7cea1606c01943e68fe196e3bdb5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Nexmo/nexmo-cli/pulls/78/commits","review_comments_url":"https://api.github.com/repos/Nexmo/nexmo-cli/pulls/78/comments","review_comment_url":"https://api.github.com/repos/Nexmo/nexmo-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Nexmo/nexmo-cli/issues/78/comments","statuses_url":"https://api.github.com/repos/Nexmo/nexmo-cli/statuses/6bae5055039663fa66782101fcf495f4b48a1977","head":{"label":"Nexmo:17-send-sms","ref":"17-send-sms","sha":"6bae5055039663fa66782101fcf495f4b48a1977","user":{"login":"Nexmo","id":551057,"avatar_url":"https://avatars.githubusercontent.com/u/551057?v=3","gravatar_id":"","url":"https://api.github.com/users/Nexmo","html_url":"https://github.com/Nexmo","followers_url":"https://api.github.com/users/Nexmo/followers","following_url":"https://api.github.com/users/Nexmo/following{/other_user}","gists_url":"https://api.github.com/users/Nexmo/gists{/gist_id}","starred_url":"https://api.github.com/users/Nexmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nexmo/subscriptions","organizations_url":"https://api.github.com/users/Nexmo/orgs","repos_url":"https://api.github.com/users/Nexmo/repos","events_url":"https://api.github.com/users/Nexmo/events{/privacy}","received_events_url":"https://api.github.com/users/Nexmo/received_events","type":"Organization","site_admin":false},"repo":{"id":57385121,"name":"nexmo-cli","full_name":"Nexmo/nexmo-cli","owner":{"login":"Nexmo","id":551057,"avatar_url":"https://avatars.githubusercontent.com/u/551057?v=3","gravatar_id":"","url":"https://api.github.com/users/Nexmo","html_url":"https://github.com/Nexmo","followers_url":"https://api.github.com/users/Nexmo/followers","following_url":"https://api.github.com/users/Nexmo/following{/other_user}","gists_url":"https://api.github.com/users/Nexmo/gists{/gist_id}","starred_url":"https://api.github.com/users/Nexmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nexmo/subscriptions","organizations_url":"https://api.github.com/users/Nexmo/orgs","repos_url":"https://api.github.com/users/Nexmo/repos","events_url":"https://api.github.com/users/Nexmo/events{/privacy}","received_events_url":"https://api.github.com/users/Nexmo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Nexmo/nexmo-cli","description":"Nexmo CLI (Command Line Interface)","fork":false,"url":"https://api.github.com/repos/Nexmo/nexmo-cli","forks_url":"https://api.github.com/repos/Nexmo/nexmo-cli/forks","keys_url":"https://api.github.com/repos/Nexmo/nexmo-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nexmo/nexmo-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nexmo/nexmo-cli/teams","hooks_url":"https://api.github.com/repos/Nexmo/nexmo-cli/hooks","issue_events_url":"https://api.github.com/repos/Nexmo/nexmo-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Nexmo/nexmo-cli/events","assignees_url":"https://api.github.com/repos/Nexmo/nexmo-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Nexmo/nexmo-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Nexmo/nexmo-cli/tags","blobs_url":"https://api.github.com/repos/Nexmo/nexmo-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nexmo/nexmo-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nexmo/nexmo-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nexmo/nexmo-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nexmo/nexmo-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Nexmo/nexmo-cli/languages","stargazers_url":"https://api.github.com/repos/Nexmo/nexmo-cli/stargazers","contributors_url":"https://api.github.com/repos/Nexmo/nexmo-cli/contributors","subscribers_url":"https://api.github.com/repos/Nexmo/nexmo-cli/subscribers","subscription_url":"https://api.github.com/repos/Nexmo/nexmo-cli/subscription","commits_url":"https://api.github.com/repos/Nexmo/nexmo-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nexmo/nexmo-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nexmo/nexmo-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nexmo/nexmo-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nexmo/nexmo-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Nexmo/nexmo-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nexmo/nexmo-cli/merges","archive_url":"https://api.github.com/repos/Nexmo/nexmo-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nexmo/nexmo-cli/downloads","issues_url":"https://api.github.com/repos/Nexmo/nexmo-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Nexmo/nexmo-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Nexmo/nexmo-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Nexmo/nexmo-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nexmo/nexmo-cli/labels{/name}","releases_url":"https://api.github.com/repos/Nexmo/nexmo-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Nexmo/nexmo-cli/deployments","created_at":"2016-04-29T13:15:49Z","updated_at":"2016-06-29T15:54:02Z","pushed_at":"2016-07-08T08:03:05Z","git_url":"git://github.com/Nexmo/nexmo-cli.git","ssh_url":"git@github.com:Nexmo/nexmo-cli.git","clone_url":"https://github.com/Nexmo/nexmo-cli.git","svn_url":"https://github.com/Nexmo/nexmo-cli","homepage":"https://nexmo.com","size":162,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":20,"forks":0,"open_issues":20,"watchers":5,"default_branch":"master"}},"base":{"label":"Nexmo:master","ref":"master","sha":"24ac70e5e6e2b7bdb4cd6e4c8129269c1d27f2a5","user":{"login":"Nexmo","id":551057,"avatar_url":"https://avatars.githubusercontent.com/u/551057?v=3","gravatar_id":"","url":"https://api.github.com/users/Nexmo","html_url":"https://github.com/Nexmo","followers_url":"https://api.github.com/users/Nexmo/followers","following_url":"https://api.github.com/users/Nexmo/following{/other_user}","gists_url":"https://api.github.com/users/Nexmo/gists{/gist_id}","starred_url":"https://api.github.com/users/Nexmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nexmo/subscriptions","organizations_url":"https://api.github.com/users/Nexmo/orgs","repos_url":"https://api.github.com/users/Nexmo/repos","events_url":"https://api.github.com/users/Nexmo/events{/privacy}","received_events_url":"https://api.github.com/users/Nexmo/received_events","type":"Organization","site_admin":false},"repo":{"id":57385121,"name":"nexmo-cli","full_name":"Nexmo/nexmo-cli","owner":{"login":"Nexmo","id":551057,"avatar_url":"https://avatars.githubusercontent.com/u/551057?v=3","gravatar_id":"","url":"https://api.github.com/users/Nexmo","html_url":"https://github.com/Nexmo","followers_url":"https://api.github.com/users/Nexmo/followers","following_url":"https://api.github.com/users/Nexmo/following{/other_user}","gists_url":"https://api.github.com/users/Nexmo/gists{/gist_id}","starred_url":"https://api.github.com/users/Nexmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nexmo/subscriptions","organizations_url":"https://api.github.com/users/Nexmo/orgs","repos_url":"https://api.github.com/users/Nexmo/repos","events_url":"https://api.github.com/users/Nexmo/events{/privacy}","received_events_url":"https://api.github.com/users/Nexmo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Nexmo/nexmo-cli","description":"Nexmo CLI (Command Line Interface)","fork":false,"url":"https://api.github.com/repos/Nexmo/nexmo-cli","forks_url":"https://api.github.com/repos/Nexmo/nexmo-cli/forks","keys_url":"https://api.github.com/repos/Nexmo/nexmo-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nexmo/nexmo-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nexmo/nexmo-cli/teams","hooks_url":"https://api.github.com/repos/Nexmo/nexmo-cli/hooks","issue_events_url":"https://api.github.com/repos/Nexmo/nexmo-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Nexmo/nexmo-cli/events","assignees_url":"https://api.github.com/repos/Nexmo/nexmo-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Nexmo/nexmo-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Nexmo/nexmo-cli/tags","blobs_url":"https://api.github.com/repos/Nexmo/nexmo-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nexmo/nexmo-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nexmo/nexmo-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nexmo/nexmo-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nexmo/nexmo-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Nexmo/nexmo-cli/languages","stargazers_url":"https://api.github.com/repos/Nexmo/nexmo-cli/stargazers","contributors_url":"https://api.github.com/repos/Nexmo/nexmo-cli/contributors","subscribers_url":"https://api.github.com/repos/Nexmo/nexmo-cli/subscribers","subscription_url":"https://api.github.com/repos/Nexmo/nexmo-cli/subscription","commits_url":"https://api.github.com/repos/Nexmo/nexmo-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nexmo/nexmo-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nexmo/nexmo-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nexmo/nexmo-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nexmo/nexmo-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Nexmo/nexmo-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nexmo/nexmo-cli/merges","archive_url":"https://api.github.com/repos/Nexmo/nexmo-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nexmo/nexmo-cli/downloads","issues_url":"https://api.github.com/repos/Nexmo/nexmo-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Nexmo/nexmo-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Nexmo/nexmo-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Nexmo/nexmo-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nexmo/nexmo-cli/labels{/name}","releases_url":"https://api.github.com/repos/Nexmo/nexmo-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Nexmo/nexmo-cli/deployments","created_at":"2016-04-29T13:15:49Z","updated_at":"2016-06-29T15:54:02Z","pushed_at":"2016-07-08T08:03:05Z","git_url":"git://github.com/Nexmo/nexmo-cli.git","ssh_url":"git@github.com:Nexmo/nexmo-cli.git","clone_url":"https://github.com/Nexmo/nexmo-cli.git","svn_url":"https://github.com/Nexmo/nexmo-cli","homepage":"https://nexmo.com","size":162,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":20,"forks":0,"open_issues":20,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Nexmo/nexmo-cli/pulls/78"},"html":{"href":"https://github.com/Nexmo/nexmo-cli/pull/78"},"issue":{"href":"https://api.github.com/repos/Nexmo/nexmo-cli/issues/78"},"comments":{"href":"https://api.github.com/repos/Nexmo/nexmo-cli/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/Nexmo/nexmo-cli/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/Nexmo/nexmo-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Nexmo/nexmo-cli/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/Nexmo/nexmo-cli/statuses/6bae5055039663fa66782101fcf495f4b48a1977"}}}}
{"actor":{"display_login":"leggetter"}}