{"action":"created","issue":{"url":"https://api.github.com/repos/martynsmith/node-irc/issues/452","repository_url":"https://api.github.com/repos/martynsmith/node-irc","labels_url":"https://api.github.com/repos/martynsmith/node-irc/issues/452/labels{/name}","comments_url":"https://api.github.com/repos/martynsmith/node-irc/issues/452/comments","events_url":"https://api.github.com/repos/martynsmith/node-irc/issues/452/events","html_url":"https://github.com/martynsmith/node-irc/pull/452","id":139826576,"number":452,"title":"fix(ping timeouts): When a ping timeout is detected properly destroy …","user":{"login":"jirwin","id":61822,"avatar_url":"https://avatars.githubusercontent.com/u/61822?v=3","gravatar_id":"","url":"https://api.github.com/users/jirwin","html_url":"https://github.com/jirwin","followers_url":"https://api.github.com/users/jirwin/followers","following_url":"https://api.github.com/users/jirwin/following{/other_user}","gists_url":"https://api.github.com/users/jirwin/gists{/gist_id}","starred_url":"https://api.github.com/users/jirwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jirwin/subscriptions","organizations_url":"https://api.github.com/users/jirwin/orgs","repos_url":"https://api.github.com/users/jirwin/repos","events_url":"https://api.github.com/users/jirwin/events{/privacy}","received_events_url":"https://api.github.com/users/jirwin/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-10T08:59:33Z","updated_at":"2016-04-16T01:57:03Z","closed_at":"2016-03-24T17:48:14Z","pull_request":{"url":"https://api.github.com/repos/martynsmith/node-irc/pulls/452","html_url":"https://github.com/martynsmith/node-irc/pull/452","diff_url":"https://github.com/martynsmith/node-irc/pull/452.diff","patch_url":"https://github.com/martynsmith/node-irc/pull/452.patch"},"body":"…the existing connection before making a new one.\r\n\r\nPreviously the connection wasn't being closed properly as the the `close` event on the socket was just being emitted instead of actually closing the connection. This caused the client to open a new, duplicate connection on reconnect, instead of replacing the existing connection."},"comment":{"url":"https://api.github.com/repos/martynsmith/node-irc/issues/comments/210710903","html_url":"https://github.com/martynsmith/node-irc/pull/452#issuecomment-210710903","issue_url":"https://api.github.com/repos/martynsmith/node-irc/issues/452","id":210710903,"user":{"login":"Zamiell","id":5511220,"avatar_url":"https://avatars.githubusercontent.com/u/5511220?v=3","gravatar_id":"","url":"https://api.github.com/users/Zamiell","html_url":"https://github.com/Zamiell","followers_url":"https://api.github.com/users/Zamiell/followers","following_url":"https://api.github.com/users/Zamiell/following{/other_user}","gists_url":"https://api.github.com/users/Zamiell/gists{/gist_id}","starred_url":"https://api.github.com/users/Zamiell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zamiell/subscriptions","organizations_url":"https://api.github.com/users/Zamiell/orgs","repos_url":"https://api.github.com/users/Zamiell/repos","events_url":"https://api.github.com/users/Zamiell/events{/privacy}","received_events_url":"https://api.github.com/users/Zamiell/received_events","type":"User","site_admin":false},"created_at":"2016-04-16T01:57:03Z","updated_at":"2016-04-16T01:57:03Z","body":"Not sure this is fixed - when running the latest version of master, my error-0.log was filled with:\r\n\r\n```\r\nCyclingPingTimer 3: server silent for too long, let's send a PING\r\nCyclingPingTimer 0: ping timeout!\r\nCyclingPingTimer 4: server silent for too long, let's send a PING\r\nCyclingPingTimer 1: ping timeout!\r\nCyclingPingTimer 5: server silent for too long, let's send a PING\r\nCyclingPingTimer 2: ping timeout!\r\nCyclingPingTimer 6: server silent for too long, let's send a PING\r\nCyclingPingTimer 3: ping timeout!\r\nCyclingPingTimer 7: server silent for too long, let's send a PING\r\nCyclingPingTimer 4: ping timeout!\r\nCyclingPingTimer 8: server silent for too long, let's send a PING\r\nCyclingPingTimer 5: ping timeout!\r\nCyclingPingTimer 9: server silent for too long, let's send a PING\r\nCyclingPingTimer 6: ping timeout!\r\nCyclingPingTimer 7: ping timeout!\r\nCyclingPingTimer 8: ping timeout!\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 9: ping timeout!\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\nCyclingPingTimer 10: server silent for too long, let's send a PING\r\n```\r\n"}}