{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift-package-manager/pulls/comments/70914539","id":70914539,"diff_hunk":"@@ -15,7 +15,7 @@ import class Utility.Git\n import struct Utility.Path\n \n public func generateVersionData(_ rootDir: AbsolutePath, rootPackage: Package, externalPackages: [Package]) throws {\n-    let dirPath = rootDir.appending(\".build/versionData\")\n+    let dirPath = rootDir.appending(components: \".build\", \"versionData\")","path":"Sources/Build/PackageVersion.swift","position":5,"original_position":5,"commit_id":"e6c36475b4753444b3bfe5352e194cc968315488","original_commit_id":"e6c36475b4753444b3bfe5352e194cc968315488","user":{"login":"ddunbar","id":106625,"avatar_url":"https://avatars.githubusercontent.com/u/106625?v=3","gravatar_id":"","url":"https://api.github.com/users/ddunbar","html_url":"https://github.com/ddunbar","followers_url":"https://api.github.com/users/ddunbar/followers","following_url":"https://api.github.com/users/ddunbar/following{/other_user}","gists_url":"https://api.github.com/users/ddunbar/gists{/gist_id}","starred_url":"https://api.github.com/users/ddunbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddunbar/subscriptions","organizations_url":"https://api.github.com/users/ddunbar/orgs","repos_url":"https://api.github.com/users/ddunbar/repos","events_url":"https://api.github.com/users/ddunbar/events{/privacy}","received_events_url":"https://api.github.com/users/ddunbar/received_events","type":"User","site_admin":false},"body":"It should, but it didn't have any to start with so left that out of this PR.","created_at":"2016-07-15T02:39:29Z","updated_at":"2016-07-15T02:39:29Z","html_url":"https://github.com/apple/swift-package-manager/pull/499#discussion_r70914539","pull_request_url":"https://api.github.com/repos/apple/swift-package-manager/pulls/499","_links":{"self":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/comments/70914539"},"html":{"href":"https://github.com/apple/swift-package-manager/pull/499#discussion_r70914539"},"pull_request":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/499"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift-package-manager/pulls/499","id":77537701,"html_url":"https://github.com/apple/swift-package-manager/pull/499","diff_url":"https://github.com/apple/swift-package-manager/pull/499.diff","patch_url":"https://github.com/apple/swift-package-manager/pull/499.patch","issue_url":"https://api.github.com/repos/apple/swift-package-manager/issues/499","number":499,"state":"open","locked":false,"title":"Add AbsolutePath.appending(component[s]:) methods","user":{"login":"ddunbar","id":106625,"avatar_url":"https://avatars.githubusercontent.com/u/106625?v=3","gravatar_id":"","url":"https://api.github.com/users/ddunbar","html_url":"https://github.com/ddunbar","followers_url":"https://api.github.com/users/ddunbar/followers","following_url":"https://api.github.com/users/ddunbar/following{/other_user}","gists_url":"https://api.github.com/users/ddunbar/gists{/gist_id}","starred_url":"https://api.github.com/users/ddunbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddunbar/subscriptions","organizations_url":"https://api.github.com/users/ddunbar/orgs","repos_url":"https://api.github.com/users/ddunbar/repos","events_url":"https://api.github.com/users/ddunbar/events{/privacy}","received_events_url":"https://api.github.com/users/ddunbar/received_events","type":"User","site_admin":false},"body":"[Basic] Add AbsolutePath.appending(component[s]:) methods.  …\r\n - These are used to append literal components, not subpaths. This is a common\r\n   operation and helps make explicit at the call sites when the expectation is\r\n   that the append is not a full subpath.\r\n\r\n[Basic] Eliminate AbsolutePath.appending(_:String)  …\r\n - It turns out that almost all clients of this method were in places where the\r\n   individual components were well known. The result is a little more verbose,\r\n   but it makes it much more explicit when the only thing being appended is a\r\n   component (which can have semantic implications on the calling code, and so\r\n   is useful to know).","created_at":"2016-07-14T22:37:40Z","updated_at":"2016-07-15T02:39:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4a21f41ada9f91bfef817fded8a042226d741dc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift-package-manager/pulls/499/commits","review_comments_url":"https://api.github.com/repos/apple/swift-package-manager/pulls/499/comments","review_comment_url":"https://api.github.com/repos/apple/swift-package-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-package-manager/issues/499/comments","statuses_url":"https://api.github.com/repos/apple/swift-package-manager/statuses/e6c36475b4753444b3bfe5352e194cc968315488","head":{"label":"ddunbar:appending-component","ref":"appending-component","sha":"e6c36475b4753444b3bfe5352e194cc968315488","user":{"login":"ddunbar","id":106625,"avatar_url":"https://avatars.githubusercontent.com/u/106625?v=3","gravatar_id":"","url":"https://api.github.com/users/ddunbar","html_url":"https://github.com/ddunbar","followers_url":"https://api.github.com/users/ddunbar/followers","following_url":"https://api.github.com/users/ddunbar/following{/other_user}","gists_url":"https://api.github.com/users/ddunbar/gists{/gist_id}","starred_url":"https://api.github.com/users/ddunbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddunbar/subscriptions","organizations_url":"https://api.github.com/users/ddunbar/orgs","repos_url":"https://api.github.com/users/ddunbar/repos","events_url":"https://api.github.com/users/ddunbar/events{/privacy}","received_events_url":"https://api.github.com/users/ddunbar/received_events","type":"User","site_admin":false},"repo":{"id":56016890,"name":"swift-package-manager","full_name":"ddunbar/swift-package-manager","owner":{"login":"ddunbar","id":106625,"avatar_url":"https://avatars.githubusercontent.com/u/106625?v=3","gravatar_id":"","url":"https://api.github.com/users/ddunbar","html_url":"https://github.com/ddunbar","followers_url":"https://api.github.com/users/ddunbar/followers","following_url":"https://api.github.com/users/ddunbar/following{/other_user}","gists_url":"https://api.github.com/users/ddunbar/gists{/gist_id}","starred_url":"https://api.github.com/users/ddunbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddunbar/subscriptions","organizations_url":"https://api.github.com/users/ddunbar/orgs","repos_url":"https://api.github.com/users/ddunbar/repos","events_url":"https://api.github.com/users/ddunbar/events{/privacy}","received_events_url":"https://api.github.com/users/ddunbar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ddunbar/swift-package-manager","description":"The Package Manager for the Swift Programming Language","fork":true,"url":"https://api.github.com/repos/ddunbar/swift-package-manager","forks_url":"https://api.github.com/repos/ddunbar/swift-package-manager/forks","keys_url":"https://api.github.com/repos/ddunbar/swift-package-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ddunbar/swift-package-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ddunbar/swift-package-manager/teams","hooks_url":"https://api.github.com/repos/ddunbar/swift-package-manager/hooks","issue_events_url":"https://api.github.com/repos/ddunbar/swift-package-manager/issues/events{/number}","events_url":"https://api.github.com/repos/ddunbar/swift-package-manager/events","assignees_url":"https://api.github.com/repos/ddunbar/swift-package-manager/assignees{/user}","branches_url":"https://api.github.com/repos/ddunbar/swift-package-manager/branches{/branch}","tags_url":"https://api.github.com/repos/ddunbar/swift-package-manager/tags","blobs_url":"https://api.github.com/repos/ddunbar/swift-package-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ddunbar/swift-package-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ddunbar/swift-package-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/ddunbar/swift-package-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ddunbar/swift-package-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/ddunbar/swift-package-manager/languages","stargazers_url":"https://api.github.com/repos/ddunbar/swift-package-manager/stargazers","contributors_url":"https://api.github.com/repos/ddunbar/swift-package-manager/contributors","subscribers_url":"https://api.github.com/repos/ddunbar/swift-package-manager/subscribers","subscription_url":"https://api.github.com/repos/ddunbar/swift-package-manager/subscription","commits_url":"https://api.github.com/repos/ddunbar/swift-package-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/ddunbar/swift-package-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/ddunbar/swift-package-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/ddunbar/swift-package-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/ddunbar/swift-package-manager/contents/{+path}","compare_url":"https://api.github.com/repos/ddunbar/swift-package-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ddunbar/swift-package-manager/merges","archive_url":"https://api.github.com/repos/ddunbar/swift-package-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ddunbar/swift-package-manager/downloads","issues_url":"https://api.github.com/repos/ddunbar/swift-package-manager/issues{/number}","pulls_url":"https://api.github.com/repos/ddunbar/swift-package-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/ddunbar/swift-package-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/ddunbar/swift-package-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ddunbar/swift-package-manager/labels{/name}","releases_url":"https://api.github.com/repos/ddunbar/swift-package-manager/releases{/id}","deployments_url":"https://api.github.com/repos/ddunbar/swift-package-manager/deployments","created_at":"2016-04-12T00:07:21Z","updated_at":"2016-05-18T13:25:27Z","pushed_at":"2016-07-15T00:21:13Z","git_url":"git://github.com/ddunbar/swift-package-manager.git","ssh_url":"git@github.com:ddunbar/swift-package-manager.git","clone_url":"https://github.com/ddunbar/swift-package-manager.git","svn_url":"https://github.com/ddunbar/swift-package-manager","homepage":"","size":2277,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"579ce3d3ff3d938436cb45d02c00e86833f4faa4","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44840041,"name":"swift-package-manager","full_name":"apple/swift-package-manager","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift-package-manager","description":"The Package Manager for the Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift-package-manager","forks_url":"https://api.github.com/repos/apple/swift-package-manager/forks","keys_url":"https://api.github.com/repos/apple/swift-package-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-package-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-package-manager/teams","hooks_url":"https://api.github.com/repos/apple/swift-package-manager/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-package-manager/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-package-manager/events","assignees_url":"https://api.github.com/repos/apple/swift-package-manager/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-package-manager/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-package-manager/tags","blobs_url":"https://api.github.com/repos/apple/swift-package-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-package-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-package-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-package-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-package-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-package-manager/languages","stargazers_url":"https://api.github.com/repos/apple/swift-package-manager/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-package-manager/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-package-manager/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-package-manager/subscription","commits_url":"https://api.github.com/repos/apple/swift-package-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-package-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-package-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-package-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-package-manager/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-package-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-package-manager/merges","archive_url":"https://api.github.com/repos/apple/swift-package-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-package-manager/downloads","issues_url":"https://api.github.com/repos/apple/swift-package-manager/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-package-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-package-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-package-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-package-manager/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-package-manager/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift-package-manager/deployments","created_at":"2015-10-23T21:41:12Z","updated_at":"2016-07-14T19:24:36Z","pushed_at":"2016-07-15T01:53:18Z","git_url":"git://github.com/apple/swift-package-manager.git","ssh_url":"git@github.com:apple/swift-package-manager.git","clone_url":"https://github.com/apple/swift-package-manager.git","svn_url":"https://github.com/apple/swift-package-manager","homepage":"","size":3126,"stargazers_count":4365,"watchers_count":4365,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":385,"mirror_url":null,"open_issues_count":10,"forks":385,"open_issues":10,"watchers":4365,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/499"},"html":{"href":"https://github.com/apple/swift-package-manager/pull/499"},"issue":{"href":"https://api.github.com/repos/apple/swift-package-manager/issues/499"},"comments":{"href":"https://api.github.com/repos/apple/swift-package-manager/issues/499/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/499/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-package-manager/pulls/499/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-package-manager/statuses/e6c36475b4753444b3bfe5352e194cc968315488"}}}}
{"actor":{"display_login":"ddunbar"}}