{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/5846","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/5846/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/5846/comments","events_url":"https://api.github.com/repos/apple/swift/issues/5846/events","html_url":"https://github.com/apple/swift/pull/5846","id":190185747,"number":5846,"title":"Runtime: Refactor platform-dependent image inspection code.","user":{"login":"jckarter","id":147281,"avatar_url":"https://avatars.githubusercontent.com/u/147281?v=3","gravatar_id":"","url":"https://api.github.com/users/jckarter","html_url":"https://github.com/jckarter","followers_url":"https://api.github.com/users/jckarter/followers","following_url":"https://api.github.com/users/jckarter/following{/other_user}","gists_url":"https://api.github.com/users/jckarter/gists{/gist_id}","starred_url":"https://api.github.com/users/jckarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jckarter/subscriptions","organizations_url":"https://api.github.com/users/jckarter/orgs","repos_url":"https://api.github.com/users/jckarter/repos","events_url":"https://api.github.com/users/jckarter/events{/privacy}","received_events_url":"https://api.github.com/users/jckarter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-17T22:41:49Z","updated_at":"2016-11-17T22:46:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/5846","html_url":"https://github.com/apple/swift/pull/5846","diff_url":"https://github.com/apple/swift/pull/5846.diff","patch_url":"https://github.com/apple/swift/pull/5846.patch"},"body":"The code we use to interface with the platform dynamic linker is turning into a rat's nest of conditionals that's hard to maintain and extend. Since ELF, Mach-O, and PE platforms have pretty fundamentally different dynamic linker interfaces and capabilities, it makes sense to factor that code into a separate file per-platform, instead of trying to conditionalize the logic in-line. This patch factors out a much simpler portable interface for lazily kicking off the protocol conformance and type metadata lookup caches, and factors the guts out into separate MachO, ELF, and Win32 backends. This should also be a much cleaner interface to interface static binary behavior into, assisting #5349."},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/261394243","html_url":"https://github.com/apple/swift/pull/5846#issuecomment-261394243","issue_url":"https://api.github.com/repos/apple/swift/issues/5846","id":261394243,"user":{"login":"jckarter","id":147281,"avatar_url":"https://avatars.githubusercontent.com/u/147281?v=3","gravatar_id":"","url":"https://api.github.com/users/jckarter","html_url":"https://github.com/jckarter","followers_url":"https://api.github.com/users/jckarter/followers","following_url":"https://api.github.com/users/jckarter/following{/other_user}","gists_url":"https://api.github.com/users/jckarter/gists{/gist_id}","starred_url":"https://api.github.com/users/jckarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jckarter/subscriptions","organizations_url":"https://api.github.com/users/jckarter/orgs","repos_url":"https://api.github.com/users/jckarter/repos","events_url":"https://api.github.com/users/jckarter/events{/privacy}","received_events_url":"https://api.github.com/users/jckarter/received_events","type":"User","site_admin":false},"created_at":"2016-11-17T22:46:17Z","updated_at":"2016-11-17T22:46:17Z","body":"@compnerd I had to eyeball the Cygwin and MSVC stuff since I don't have a Windows build environment set up. Would you be able to take a look and ensure this works?"}}
{"actor":{"display_login":"jckarter"}}