{"action":"created","comment":{"url":"https://api.github.com/repos/weld/core/pulls/comments/93184000","pull_request_review_id":13705253,"id":93184000,"diff_hunk":"@@ -108,6 +108,7 @@ public T createInterceptedInstance(T instance) {\n                 .getInterceptionFactoryData(configurator != null ? configurator.complete() : annotatedType);\n \n         if (!cached.isPresent()) {\n+            used = true;","path":"impl/src/main/java/org/jboss/weld/injection/InterceptionFactoryImpl.java","position":4,"original_position":4,"commit_id":"1c11f55cb4624987c6dfa2f16a7a13bc072fae3a","original_commit_id":"1c11f55cb4624987c6dfa2f16a7a13bc072fae3a","user":{"login":"mkouba","id":913004,"avatar_url":"https://avatars.githubusercontent.com/u/913004?v=3","gravatar_id":"","url":"https://api.github.com/users/mkouba","html_url":"https://github.com/mkouba","followers_url":"https://api.github.com/users/mkouba/followers","following_url":"https://api.github.com/users/mkouba/following{/other_user}","gists_url":"https://api.github.com/users/mkouba/gists{/gist_id}","starred_url":"https://api.github.com/users/mkouba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkouba/subscriptions","organizations_url":"https://api.github.com/users/mkouba/orgs","repos_url":"https://api.github.com/users/mkouba/repos","events_url":"https://api.github.com/users/mkouba/events{/privacy}","received_events_url":"https://api.github.com/users/mkouba/received_events","type":"User","site_admin":false},"body":"I think we should move `used = true;` right after `throw InterceptorLogger.LOG.interceptionFactoryNotReusable()` and also remove L125.","created_at":"2016-12-20T07:38:35Z","updated_at":"2016-12-20T07:38:35Z","html_url":"https://github.com/weld/core/pull/1536#discussion_r93184000","pull_request_url":"https://api.github.com/repos/weld/core/pulls/1536","_links":{"self":{"href":"https://api.github.com/repos/weld/core/pulls/comments/93184000"},"html":{"href":"https://github.com/weld/core/pull/1536#discussion_r93184000"},"pull_request":{"href":"https://api.github.com/repos/weld/core/pulls/1536"}}},"pull_request":{"url":"https://api.github.com/repos/weld/core/pulls/1536","id":98698566,"html_url":"https://github.com/weld/core/pull/1536","diff_url":"https://github.com/weld/core/pull/1536.diff","patch_url":"https://github.com/weld/core/pull/1536.patch","issue_url":"https://api.github.com/repos/weld/core/issues/1536","number":1536,"state":"open","locked":false,"title":"WELD-2291 throw ISE also when data for InterceptionFactory are cached.","user":{"login":"tremes","id":924640,"avatar_url":"https://avatars.githubusercontent.com/u/924640?v=3","gravatar_id":"","url":"https://api.github.com/users/tremes","html_url":"https://github.com/tremes","followers_url":"https://api.github.com/users/tremes/followers","following_url":"https://api.github.com/users/tremes/following{/other_user}","gists_url":"https://api.github.com/users/tremes/gists{/gist_id}","starred_url":"https://api.github.com/users/tremes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tremes/subscriptions","organizations_url":"https://api.github.com/users/tremes/orgs","repos_url":"https://api.github.com/users/tremes/repos","events_url":"https://api.github.com/users/tremes/events{/privacy}","received_events_url":"https://api.github.com/users/tremes/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-20T07:24:38Z","updated_at":"2016-12-20T07:38:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fabff184ab474bb3d2c21c87e519e56e99f8a1b9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/weld/core/pulls/1536/commits","review_comments_url":"https://api.github.com/repos/weld/core/pulls/1536/comments","review_comment_url":"https://api.github.com/repos/weld/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weld/core/issues/1536/comments","statuses_url":"https://api.github.com/repos/weld/core/statuses/1c11f55cb4624987c6dfa2f16a7a13bc072fae3a","head":{"label":"tremes:WELD-2291","ref":"WELD-2291","sha":"1c11f55cb4624987c6dfa2f16a7a13bc072fae3a","user":{"login":"tremes","id":924640,"avatar_url":"https://avatars.githubusercontent.com/u/924640?v=3","gravatar_id":"","url":"https://api.github.com/users/tremes","html_url":"https://github.com/tremes","followers_url":"https://api.github.com/users/tremes/followers","following_url":"https://api.github.com/users/tremes/following{/other_user}","gists_url":"https://api.github.com/users/tremes/gists{/gist_id}","starred_url":"https://api.github.com/users/tremes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tremes/subscriptions","organizations_url":"https://api.github.com/users/tremes/orgs","repos_url":"https://api.github.com/users/tremes/repos","events_url":"https://api.github.com/users/tremes/events{/privacy}","received_events_url":"https://api.github.com/users/tremes/received_events","type":"User","site_admin":false},"repo":{"id":4212527,"name":"core","full_name":"tremes/core","owner":{"login":"tremes","id":924640,"avatar_url":"https://avatars.githubusercontent.com/u/924640?v=3","gravatar_id":"","url":"https://api.github.com/users/tremes","html_url":"https://github.com/tremes","followers_url":"https://api.github.com/users/tremes/followers","following_url":"https://api.github.com/users/tremes/following{/other_user}","gists_url":"https://api.github.com/users/tremes/gists{/gist_id}","starred_url":"https://api.github.com/users/tremes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tremes/subscriptions","organizations_url":"https://api.github.com/users/tremes/orgs","repos_url":"https://api.github.com/users/tremes/repos","events_url":"https://api.github.com/users/tremes/events{/privacy}","received_events_url":"https://api.github.com/users/tremes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tremes/core","description":"Weld, including integrations for Servlet containers and Java SE, examples and documentation","fork":true,"url":"https://api.github.com/repos/tremes/core","forks_url":"https://api.github.com/repos/tremes/core/forks","keys_url":"https://api.github.com/repos/tremes/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tremes/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tremes/core/teams","hooks_url":"https://api.github.com/repos/tremes/core/hooks","issue_events_url":"https://api.github.com/repos/tremes/core/issues/events{/number}","events_url":"https://api.github.com/repos/tremes/core/events","assignees_url":"https://api.github.com/repos/tremes/core/assignees{/user}","branches_url":"https://api.github.com/repos/tremes/core/branches{/branch}","tags_url":"https://api.github.com/repos/tremes/core/tags","blobs_url":"https://api.github.com/repos/tremes/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tremes/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tremes/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/tremes/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tremes/core/statuses/{sha}","languages_url":"https://api.github.com/repos/tremes/core/languages","stargazers_url":"https://api.github.com/repos/tremes/core/stargazers","contributors_url":"https://api.github.com/repos/tremes/core/contributors","subscribers_url":"https://api.github.com/repos/tremes/core/subscribers","subscription_url":"https://api.github.com/repos/tremes/core/subscription","commits_url":"https://api.github.com/repos/tremes/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/tremes/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/tremes/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/tremes/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/tremes/core/contents/{+path}","compare_url":"https://api.github.com/repos/tremes/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tremes/core/merges","archive_url":"https://api.github.com/repos/tremes/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tremes/core/downloads","issues_url":"https://api.github.com/repos/tremes/core/issues{/number}","pulls_url":"https://api.github.com/repos/tremes/core/pulls{/number}","milestones_url":"https://api.github.com/repos/tremes/core/milestones{/number}","notifications_url":"https://api.github.com/repos/tremes/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tremes/core/labels{/name}","releases_url":"https://api.github.com/repos/tremes/core/releases{/id}","deployments_url":"https://api.github.com/repos/tremes/core/deployments","created_at":"2012-05-03T09:39:05Z","updated_at":"2016-06-13T09:43:12Z","pushed_at":"2016-12-20T07:24:18Z","git_url":"git://github.com/tremes/core.git","ssh_url":"git@github.com:tremes/core.git","clone_url":"https://github.com/tremes/core.git","svn_url":"https://github.com/tremes/core","homepage":"http://www.seamframework.org/Weld","size":45434,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"weld:master","ref":"master","sha":"8b01ec86e7152d9d4a9ed135737f371a54d3db03","user":{"login":"weld","id":331033,"avatar_url":"https://avatars.githubusercontent.com/u/331033?v=3","gravatar_id":"","url":"https://api.github.com/users/weld","html_url":"https://github.com/weld","followers_url":"https://api.github.com/users/weld/followers","following_url":"https://api.github.com/users/weld/following{/other_user}","gists_url":"https://api.github.com/users/weld/gists{/gist_id}","starred_url":"https://api.github.com/users/weld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weld/subscriptions","organizations_url":"https://api.github.com/users/weld/orgs","repos_url":"https://api.github.com/users/weld/repos","events_url":"https://api.github.com/users/weld/events{/privacy}","received_events_url":"https://api.github.com/users/weld/received_events","type":"Organization","site_admin":false},"repo":{"id":819907,"name":"core","full_name":"weld/core","owner":{"login":"weld","id":331033,"avatar_url":"https://avatars.githubusercontent.com/u/331033?v=3","gravatar_id":"","url":"https://api.github.com/users/weld","html_url":"https://github.com/weld","followers_url":"https://api.github.com/users/weld/followers","following_url":"https://api.github.com/users/weld/following{/other_user}","gists_url":"https://api.github.com/users/weld/gists{/gist_id}","starred_url":"https://api.github.com/users/weld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weld/subscriptions","organizations_url":"https://api.github.com/users/weld/orgs","repos_url":"https://api.github.com/users/weld/repos","events_url":"https://api.github.com/users/weld/events{/privacy}","received_events_url":"https://api.github.com/users/weld/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weld/core","description":"Weld, including integrations for Servlet containers and Java SE, examples and documentation","fork":false,"url":"https://api.github.com/repos/weld/core","forks_url":"https://api.github.com/repos/weld/core/forks","keys_url":"https://api.github.com/repos/weld/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weld/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weld/core/teams","hooks_url":"https://api.github.com/repos/weld/core/hooks","issue_events_url":"https://api.github.com/repos/weld/core/issues/events{/number}","events_url":"https://api.github.com/repos/weld/core/events","assignees_url":"https://api.github.com/repos/weld/core/assignees{/user}","branches_url":"https://api.github.com/repos/weld/core/branches{/branch}","tags_url":"https://api.github.com/repos/weld/core/tags","blobs_url":"https://api.github.com/repos/weld/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weld/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weld/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/weld/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weld/core/statuses/{sha}","languages_url":"https://api.github.com/repos/weld/core/languages","stargazers_url":"https://api.github.com/repos/weld/core/stargazers","contributors_url":"https://api.github.com/repos/weld/core/contributors","subscribers_url":"https://api.github.com/repos/weld/core/subscribers","subscription_url":"https://api.github.com/repos/weld/core/subscription","commits_url":"https://api.github.com/repos/weld/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/weld/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/weld/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/weld/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/weld/core/contents/{+path}","compare_url":"https://api.github.com/repos/weld/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weld/core/merges","archive_url":"https://api.github.com/repos/weld/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weld/core/downloads","issues_url":"https://api.github.com/repos/weld/core/issues{/number}","pulls_url":"https://api.github.com/repos/weld/core/pulls{/number}","milestones_url":"https://api.github.com/repos/weld/core/milestones{/number}","notifications_url":"https://api.github.com/repos/weld/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weld/core/labels{/name}","releases_url":"https://api.github.com/repos/weld/core/releases{/id}","deployments_url":"https://api.github.com/repos/weld/core/deployments","created_at":"2010-08-05T19:41:31Z","updated_at":"2016-12-13T07:31:42Z","pushed_at":"2016-12-20T07:24:39Z","git_url":"git://github.com/weld/core.git","ssh_url":"git@github.com:weld/core.git","clone_url":"https://github.com/weld/core.git","svn_url":"https://github.com/weld/core","homepage":"http://weld.cdi-spec.org/","size":48397,"stargazers_count":246,"watchers_count":246,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":211,"mirror_url":null,"open_issues_count":8,"forks":211,"open_issues":8,"watchers":246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weld/core/pulls/1536"},"html":{"href":"https://github.com/weld/core/pull/1536"},"issue":{"href":"https://api.github.com/repos/weld/core/issues/1536"},"comments":{"href":"https://api.github.com/repos/weld/core/issues/1536/comments"},"review_comments":{"href":"https://api.github.com/repos/weld/core/pulls/1536/comments"},"review_comment":{"href":"https://api.github.com/repos/weld/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weld/core/pulls/1536/commits"},"statuses":{"href":"https://api.github.com/repos/weld/core/statuses/1c11f55cb4624987c6dfa2f16a7a13bc072fae3a"}}}}
{"actor":{"display_login":"mkouba"}}