{"action":"created","comment":{"url":"https://api.github.com/repos/opentracing/opentracing-python/pulls/comments/53209504","id":53209504,"diff_hunk":"@@ -60,18 +59,15 @@ Somewhere in your server's request handler code:\n         \n     \n     def before_request(request, tracer):\n-        context = tracer.trace_context_from_text(\n-            trace_context_id=request.headers, \n-            trace_attributes=request.headers\n+        text_carrier = opentracing.SplitTextCarrier(\n+            request.headers, request.headers)\n+        span = tracer.extractor(Format.SPLIT_TEXT).join_trace(\n+            operation_name=request.operation,\n+            carrier=text_carrier\n         )\n-        operation = request.operation\n-        if context is None:\n-            span = tracer.start_trace(operation_name=operation)\n-        else:\n-            span = tracer.join_trace(operation_name=operation,\n-                                     parent_trace_context=context)\n-    \n-        span.set_tag('client.http.url', request.full_url)\n+        if span is None:\n+            span = tracer.start_span(operation_name=request.operation)\n+        span.set_tag('http.url', request.full_url)","path":"README.md","position":62,"original_position":62,"commit_id":"62d49f20229ac8f46876d828f13cc987fb27c988","original_commit_id":"62d49f20229ac8f46876d828f13cc987fb27c988","user":{"login":"bensigelman","id":2251553,"avatar_url":"https://avatars.githubusercontent.com/u/2251553?v=3","gravatar_id":"","url":"https://api.github.com/users/bensigelman","html_url":"https://github.com/bensigelman","followers_url":"https://api.github.com/users/bensigelman/followers","following_url":"https://api.github.com/users/bensigelman/following{/other_user}","gists_url":"https://api.github.com/users/bensigelman/gists{/gist_id}","starred_url":"https://api.github.com/users/bensigelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bensigelman/subscriptions","organizations_url":"https://api.github.com/users/bensigelman/orgs","repos_url":"https://api.github.com/users/bensigelman/repos","events_url":"https://api.github.com/users/bensigelman/events{/privacy}","received_events_url":"https://api.github.com/users/bensigelman/received_events","type":"User","site_admin":false},"body":"(done)","created_at":"2016-02-17T18:38:54Z","updated_at":"2016-02-17T18:38:54Z","html_url":"https://github.com/opentracing/opentracing-python/pull/17#discussion_r53209504","pull_request_url":"https://api.github.com/repos/opentracing/opentracing-python/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/opentracing/opentracing-python/pulls/comments/53209504"},"html":{"href":"https://github.com/opentracing/opentracing-python/pull/17#discussion_r53209504"},"pull_request":{"href":"https://api.github.com/repos/opentracing/opentracing-python/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/opentracing/opentracing-python/pulls/17","id":59447981,"html_url":"https://github.com/opentracing/opentracing-python/pull/17","diff_url":"https://github.com/opentracing/opentracing-python/pull/17.diff","patch_url":"https://github.com/opentracing/opentracing-python/pull/17.patch","issue_url":"https://api.github.com/repos/opentracing/opentracing-python/issues/17","number":17,"state":"open","locked":false,"title":"parity with the latest OT spec","user":{"login":"bensigelman","id":2251553,"avatar_url":"https://avatars.githubusercontent.com/u/2251553?v=3","gravatar_id":"","url":"https://api.github.com/users/bensigelman","html_url":"https://github.com/bensigelman","followers_url":"https://api.github.com/users/bensigelman/followers","following_url":"https://api.github.com/users/bensigelman/following{/other_user}","gists_url":"https://api.github.com/users/bensigelman/gists{/gist_id}","starred_url":"https://api.github.com/users/bensigelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bensigelman/subscriptions","organizations_url":"https://api.github.com/users/bensigelman/orgs","repos_url":"https://api.github.com/users/bensigelman/repos","events_url":"https://api.github.com/users/bensigelman/events{/privacy}","received_events_url":"https://api.github.com/users/bensigelman/received_events","type":"User","site_admin":false},"body":"Per https://github.com/opentracing/opentracing.github.io/issues/44#issuecomment-183697552\r\n\r\n@yurishkuro PTAL... I will update the various tests and dependencies tomorrow but wanted to get any feedback about the naming/etc ahead of time if possible.","created_at":"2016-02-16T06:16:44Z","updated_at":"2016-02-17T18:38:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f319e7c571de833fb4eae1f949a01b36cd185f6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opentracing/opentracing-python/pulls/17/commits","review_comments_url":"https://api.github.com/repos/opentracing/opentracing-python/pulls/17/comments","review_comment_url":"https://api.github.com/repos/opentracing/opentracing-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentracing/opentracing-python/issues/17/comments","statuses_url":"https://api.github.com/repos/opentracing/opentracing-python/statuses/62d49f20229ac8f46876d828f13cc987fb27c988","head":{"label":"opentracing:golang_parity","ref":"golang_parity","sha":"62d49f20229ac8f46876d828f13cc987fb27c988","user":{"login":"opentracing","id":15482765,"avatar_url":"https://avatars.githubusercontent.com/u/15482765?v=3","gravatar_id":"","url":"https://api.github.com/users/opentracing","html_url":"https://github.com/opentracing","followers_url":"https://api.github.com/users/opentracing/followers","following_url":"https://api.github.com/users/opentracing/following{/other_user}","gists_url":"https://api.github.com/users/opentracing/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing/subscriptions","organizations_url":"https://api.github.com/users/opentracing/orgs","repos_url":"https://api.github.com/users/opentracing/repos","events_url":"https://api.github.com/users/opentracing/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing/received_events","type":"Organization","site_admin":false},"repo":{"id":49166869,"name":"opentracing-python","full_name":"opentracing/opentracing-python","owner":{"login":"opentracing","id":15482765,"avatar_url":"https://avatars.githubusercontent.com/u/15482765?v=3","gravatar_id":"","url":"https://api.github.com/users/opentracing","html_url":"https://github.com/opentracing","followers_url":"https://api.github.com/users/opentracing/followers","following_url":"https://api.github.com/users/opentracing/following{/other_user}","gists_url":"https://api.github.com/users/opentracing/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing/subscriptions","organizations_url":"https://api.github.com/users/opentracing/orgs","repos_url":"https://api.github.com/users/opentracing/repos","events_url":"https://api.github.com/users/opentracing/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentracing/opentracing-python","description":"Python implementation of Open Tracing API","fork":false,"url":"https://api.github.com/repos/opentracing/opentracing-python","forks_url":"https://api.github.com/repos/opentracing/opentracing-python/forks","keys_url":"https://api.github.com/repos/opentracing/opentracing-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentracing/opentracing-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentracing/opentracing-python/teams","hooks_url":"https://api.github.com/repos/opentracing/opentracing-python/hooks","issue_events_url":"https://api.github.com/repos/opentracing/opentracing-python/issues/events{/number}","events_url":"https://api.github.com/repos/opentracing/opentracing-python/events","assignees_url":"https://api.github.com/repos/opentracing/opentracing-python/assignees{/user}","branches_url":"https://api.github.com/repos/opentracing/opentracing-python/branches{/branch}","tags_url":"https://api.github.com/repos/opentracing/opentracing-python/tags","blobs_url":"https://api.github.com/repos/opentracing/opentracing-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentracing/opentracing-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentracing/opentracing-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentracing/opentracing-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentracing/opentracing-python/statuses/{sha}","languages_url":"https://api.github.com/repos/opentracing/opentracing-python/languages","stargazers_url":"https://api.github.com/repos/opentracing/opentracing-python/stargazers","contributors_url":"https://api.github.com/repos/opentracing/opentracing-python/contributors","subscribers_url":"https://api.github.com/repos/opentracing/opentracing-python/subscribers","subscription_url":"https://api.github.com/repos/opentracing/opentracing-python/subscription","commits_url":"https://api.github.com/repos/opentracing/opentracing-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentracing/opentracing-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentracing/opentracing-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentracing/opentracing-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentracing/opentracing-python/contents/{+path}","compare_url":"https://api.github.com/repos/opentracing/opentracing-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentracing/opentracing-python/merges","archive_url":"https://api.github.com/repos/opentracing/opentracing-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentracing/opentracing-python/downloads","issues_url":"https://api.github.com/repos/opentracing/opentracing-python/issues{/number}","pulls_url":"https://api.github.com/repos/opentracing/opentracing-python/pulls{/number}","milestones_url":"https://api.github.com/repos/opentracing/opentracing-python/milestones{/number}","notifications_url":"https://api.github.com/repos/opentracing/opentracing-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentracing/opentracing-python/labels{/name}","releases_url":"https://api.github.com/repos/opentracing/opentracing-python/releases{/id}","deployments_url":"https://api.github.com/repos/opentracing/opentracing-python/deployments","created_at":"2016-01-06T22:57:00Z","updated_at":"2016-02-14T20:54:46Z","pushed_at":"2016-02-17T18:38:08Z","git_url":"git://github.com/opentracing/opentracing-python.git","ssh_url":"git@github.com:opentracing/opentracing-python.git","clone_url":"https://github.com/opentracing/opentracing-python.git","svn_url":"https://github.com/opentracing/opentracing-python","homepage":"","size":120,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":19,"default_branch":"master"}},"base":{"label":"opentracing:master","ref":"master","sha":"fc9a6a39303a8a0d4c5f4f31454be381c12a4a21","user":{"login":"opentracing","id":15482765,"avatar_url":"https://avatars.githubusercontent.com/u/15482765?v=3","gravatar_id":"","url":"https://api.github.com/users/opentracing","html_url":"https://github.com/opentracing","followers_url":"https://api.github.com/users/opentracing/followers","following_url":"https://api.github.com/users/opentracing/following{/other_user}","gists_url":"https://api.github.com/users/opentracing/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing/subscriptions","organizations_url":"https://api.github.com/users/opentracing/orgs","repos_url":"https://api.github.com/users/opentracing/repos","events_url":"https://api.github.com/users/opentracing/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing/received_events","type":"Organization","site_admin":false},"repo":{"id":49166869,"name":"opentracing-python","full_name":"opentracing/opentracing-python","owner":{"login":"opentracing","id":15482765,"avatar_url":"https://avatars.githubusercontent.com/u/15482765?v=3","gravatar_id":"","url":"https://api.github.com/users/opentracing","html_url":"https://github.com/opentracing","followers_url":"https://api.github.com/users/opentracing/followers","following_url":"https://api.github.com/users/opentracing/following{/other_user}","gists_url":"https://api.github.com/users/opentracing/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing/subscriptions","organizations_url":"https://api.github.com/users/opentracing/orgs","repos_url":"https://api.github.com/users/opentracing/repos","events_url":"https://api.github.com/users/opentracing/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentracing/opentracing-python","description":"Python implementation of Open Tracing API","fork":false,"url":"https://api.github.com/repos/opentracing/opentracing-python","forks_url":"https://api.github.com/repos/opentracing/opentracing-python/forks","keys_url":"https://api.github.com/repos/opentracing/opentracing-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentracing/opentracing-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentracing/opentracing-python/teams","hooks_url":"https://api.github.com/repos/opentracing/opentracing-python/hooks","issue_events_url":"https://api.github.com/repos/opentracing/opentracing-python/issues/events{/number}","events_url":"https://api.github.com/repos/opentracing/opentracing-python/events","assignees_url":"https://api.github.com/repos/opentracing/opentracing-python/assignees{/user}","branches_url":"https://api.github.com/repos/opentracing/opentracing-python/branches{/branch}","tags_url":"https://api.github.com/repos/opentracing/opentracing-python/tags","blobs_url":"https://api.github.com/repos/opentracing/opentracing-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentracing/opentracing-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentracing/opentracing-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentracing/opentracing-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentracing/opentracing-python/statuses/{sha}","languages_url":"https://api.github.com/repos/opentracing/opentracing-python/languages","stargazers_url":"https://api.github.com/repos/opentracing/opentracing-python/stargazers","contributors_url":"https://api.github.com/repos/opentracing/opentracing-python/contributors","subscribers_url":"https://api.github.com/repos/opentracing/opentracing-python/subscribers","subscription_url":"https://api.github.com/repos/opentracing/opentracing-python/subscription","commits_url":"https://api.github.com/repos/opentracing/opentracing-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentracing/opentracing-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentracing/opentracing-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentracing/opentracing-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentracing/opentracing-python/contents/{+path}","compare_url":"https://api.github.com/repos/opentracing/opentracing-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentracing/opentracing-python/merges","archive_url":"https://api.github.com/repos/opentracing/opentracing-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentracing/opentracing-python/downloads","issues_url":"https://api.github.com/repos/opentracing/opentracing-python/issues{/number}","pulls_url":"https://api.github.com/repos/opentracing/opentracing-python/pulls{/number}","milestones_url":"https://api.github.com/repos/opentracing/opentracing-python/milestones{/number}","notifications_url":"https://api.github.com/repos/opentracing/opentracing-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentracing/opentracing-python/labels{/name}","releases_url":"https://api.github.com/repos/opentracing/opentracing-python/releases{/id}","deployments_url":"https://api.github.com/repos/opentracing/opentracing-python/deployments","created_at":"2016-01-06T22:57:00Z","updated_at":"2016-02-14T20:54:46Z","pushed_at":"2016-02-17T18:38:08Z","git_url":"git://github.com/opentracing/opentracing-python.git","ssh_url":"git@github.com:opentracing/opentracing-python.git","clone_url":"https://github.com/opentracing/opentracing-python.git","svn_url":"https://github.com/opentracing/opentracing-python","homepage":"","size":120,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opentracing/opentracing-python/pulls/17"},"html":{"href":"https://github.com/opentracing/opentracing-python/pull/17"},"issue":{"href":"https://api.github.com/repos/opentracing/opentracing-python/issues/17"},"comments":{"href":"https://api.github.com/repos/opentracing/opentracing-python/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/opentracing/opentracing-python/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/opentracing/opentracing-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentracing/opentracing-python/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/opentracing/opentracing-python/statuses/62d49f20229ac8f46876d828f13cc987fb27c988"}}}}