{"action":"created","comment":{"url":"https://api.github.com/repos/PyCQA/pylint/pulls/comments/83864878","pull_request_review_id":4678800,"id":83864878,"diff_hunk":"@@ -59,7 +59,7 @@ disable=invalid-name,protected-access,fixme,too-many-branches,\n         import-error,too-many-lines,too-many-instance-attributes,\n         too-many-public-methods,duplicate-code,broad-except,\n         redefined-builtin,anomalous-backslash-in-string,\n-        missing-docstring,no-member,\n+        missing-docstring,no-member,overlapping-except,","path":"pylintrc","position":5,"original_position":5,"commit_id":"e638509f5cb241968d295d66b0b3ac86a0574180","original_commit_id":"e638509f5cb241968d295d66b0b3ac86a0574180","user":{"login":"PCManticore","id":448166,"avatar_url":"https://avatars.githubusercontent.com/u/448166?v=3","gravatar_id":"","url":"https://api.github.com/users/PCManticore","html_url":"https://github.com/PCManticore","followers_url":"https://api.github.com/users/PCManticore/followers","following_url":"https://api.github.com/users/PCManticore/following{/other_user}","gists_url":"https://api.github.com/users/PCManticore/gists{/gist_id}","starred_url":"https://api.github.com/users/PCManticore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCManticore/subscriptions","organizations_url":"https://api.github.com/users/PCManticore/orgs","repos_url":"https://api.github.com/users/PCManticore/repos","events_url":"https://api.github.com/users/PCManticore/events{/privacy}","received_events_url":"https://api.github.com/users/PCManticore/received_events","type":"User","site_admin":false},"body":"This file is for testing pylint itself on CI. Ideally, any occurence of this new error should be fixed in the code base, instead of ignoring it.","created_at":"2016-10-18T14:22:18Z","updated_at":"2016-10-18T14:22:18Z","html_url":"https://github.com/PyCQA/pylint/pull/1134#discussion_r83864878","pull_request_url":"https://api.github.com/repos/PyCQA/pylint/pulls/1134","_links":{"self":{"href":"https://api.github.com/repos/PyCQA/pylint/pulls/comments/83864878"},"html":{"href":"https://github.com/PyCQA/pylint/pull/1134#discussion_r83864878"},"pull_request":{"href":"https://api.github.com/repos/PyCQA/pylint/pulls/1134"}}},"pull_request":{"url":"https://api.github.com/repos/PyCQA/pylint/pulls/1134","id":89423292,"html_url":"https://github.com/PyCQA/pylint/pull/1134","diff_url":"https://github.com/PyCQA/pylint/pull/1134.diff","patch_url":"https://github.com/PyCQA/pylint/pull/1134.patch","issue_url":"https://api.github.com/repos/PyCQA/pylint/issues/1134","number":1134,"state":"open","locked":false,"title":"Implemented support to warn when overlappling exceptions in same handler","user":{"login":"molobrakos","id":8228319,"avatar_url":"https://avatars.githubusercontent.com/u/8228319?v=3","gravatar_id":"","url":"https://api.github.com/users/molobrakos","html_url":"https://github.com/molobrakos","followers_url":"https://api.github.com/users/molobrakos/followers","following_url":"https://api.github.com/users/molobrakos/following{/other_user}","gists_url":"https://api.github.com/users/molobrakos/gists{/gist_id}","starred_url":"https://api.github.com/users/molobrakos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molobrakos/subscriptions","organizations_url":"https://api.github.com/users/molobrakos/orgs","repos_url":"https://api.github.com/users/molobrakos/repos","events_url":"https://api.github.com/users/molobrakos/events{/privacy}","received_events_url":"https://api.github.com/users/molobrakos/received_events","type":"User","site_admin":false},"body":"The use case is being able to catch exception handling clauses where overlapping or redundant exceptions are caught in the same handler. Comments welcome.\r\n\r\nExample: In Python ver >3.3 (https://www.python.org/dev/peps/pep-3151/), IOError is an alias for OSError. In addition, socket.error is an alias for OSError. The intention is to find cases like the following:\r\n\r\n```\r\n\"\"\"doc\"\"\"\r\nimport socket\r\ntry:\r\n    pass  # do some socket operation\r\nexcept (ConnectionError, IOError, OSError, socket.error):  # too lazy to read doc. patches etc.\r\n    pass\r\n```\r\n\r\n```\r\nIn [1]: import socket\r\n\r\nIn [2]: OSError\r\nOut[2]: builtins.OSError\r\n\r\nIn [3]: socket.error\r\nOut[3]: builtins.OSError\r\n\r\nIn [4]: IOError\r\nOut[4]: builtins.OSError\r\n\r\nIn [5]: ConnectionError, ConnectionError.__bases__\r\nOut[5]: (builtins.ConnectionError, (builtins.OSError,))\r\n```\r\n\r\nOutput when enabling this check for the source code above would be:\r\n```\r\nW:  5, 8: Overlapping exceptions (IOError is an ancestor class of ConnectionError) (overlapping-except)\r\nW:  5, 8: Overlapping exceptions (OSError is an ancestor class of ConnectionError) (overlapping-except)\r\nW:  5, 8: Overlapping exceptions (IOError and OSError are the same) (overlapping-except)\r\nW:  5, 8: Overlapping exceptions (socket.error is an ancestor class of ConnectionError) (overlapping-except)\r\nW:  5, 8: Overlapping exceptions (IOError and socket.error are the same) (overlapping-except)\r\nW:  5, 8: Overlapping exceptions (OSError and socket.error are the same) (overlapping-except)\r\n```\r\n\r\nThe check is disabled by default and one caveat is when using on code intended to run with different versions of Python, where the exception hierarchy has changed between versions (such as in the example above). The check will currently emit two warnings when enabled when linting the pylint sources.","created_at":"2016-10-14T17:30:33Z","updated_at":"2016-10-18T14:22:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11015132058e3aeca023f31edd6bb4ccdc8abe31","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PyCQA/pylint/pulls/1134/commits","review_comments_url":"https://api.github.com/repos/PyCQA/pylint/pulls/1134/comments","review_comment_url":"https://api.github.com/repos/PyCQA/pylint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PyCQA/pylint/issues/1134/comments","statuses_url":"https://api.github.com/repos/PyCQA/pylint/statuses/e638509f5cb241968d295d66b0b3ac86a0574180","head":{"label":"molobrakos:master","ref":"master","sha":"e638509f5cb241968d295d66b0b3ac86a0574180","user":{"login":"molobrakos","id":8228319,"avatar_url":"https://avatars.githubusercontent.com/u/8228319?v=3","gravatar_id":"","url":"https://api.github.com/users/molobrakos","html_url":"https://github.com/molobrakos","followers_url":"https://api.github.com/users/molobrakos/followers","following_url":"https://api.github.com/users/molobrakos/following{/other_user}","gists_url":"https://api.github.com/users/molobrakos/gists{/gist_id}","starred_url":"https://api.github.com/users/molobrakos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molobrakos/subscriptions","organizations_url":"https://api.github.com/users/molobrakos/orgs","repos_url":"https://api.github.com/users/molobrakos/repos","events_url":"https://api.github.com/users/molobrakos/events{/privacy}","received_events_url":"https://api.github.com/users/molobrakos/received_events","type":"User","site_admin":false},"repo":{"id":70688013,"name":"pylint","full_name":"molobrakos/pylint","owner":{"login":"molobrakos","id":8228319,"avatar_url":"https://avatars.githubusercontent.com/u/8228319?v=3","gravatar_id":"","url":"https://api.github.com/users/molobrakos","html_url":"https://github.com/molobrakos","followers_url":"https://api.github.com/users/molobrakos/followers","following_url":"https://api.github.com/users/molobrakos/following{/other_user}","gists_url":"https://api.github.com/users/molobrakos/gists{/gist_id}","starred_url":"https://api.github.com/users/molobrakos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molobrakos/subscriptions","organizations_url":"https://api.github.com/users/molobrakos/orgs","repos_url":"https://api.github.com/users/molobrakos/repos","events_url":"https://api.github.com/users/molobrakos/events{/privacy}","received_events_url":"https://api.github.com/users/molobrakos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/molobrakos/pylint","description":"A Python source code analyzer which looks for programming errors, helps enforcing a coding standard and sniffs for some code smells","fork":true,"url":"https://api.github.com/repos/molobrakos/pylint","forks_url":"https://api.github.com/repos/molobrakos/pylint/forks","keys_url":"https://api.github.com/repos/molobrakos/pylint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/molobrakos/pylint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/molobrakos/pylint/teams","hooks_url":"https://api.github.com/repos/molobrakos/pylint/hooks","issue_events_url":"https://api.github.com/repos/molobrakos/pylint/issues/events{/number}","events_url":"https://api.github.com/repos/molobrakos/pylint/events","assignees_url":"https://api.github.com/repos/molobrakos/pylint/assignees{/user}","branches_url":"https://api.github.com/repos/molobrakos/pylint/branches{/branch}","tags_url":"https://api.github.com/repos/molobrakos/pylint/tags","blobs_url":"https://api.github.com/repos/molobrakos/pylint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/molobrakos/pylint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/molobrakos/pylint/git/refs{/sha}","trees_url":"https://api.github.com/repos/molobrakos/pylint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/molobrakos/pylint/statuses/{sha}","languages_url":"https://api.github.com/repos/molobrakos/pylint/languages","stargazers_url":"https://api.github.com/repos/molobrakos/pylint/stargazers","contributors_url":"https://api.github.com/repos/molobrakos/pylint/contributors","subscribers_url":"https://api.github.com/repos/molobrakos/pylint/subscribers","subscription_url":"https://api.github.com/repos/molobrakos/pylint/subscription","commits_url":"https://api.github.com/repos/molobrakos/pylint/commits{/sha}","git_commits_url":"https://api.github.com/repos/molobrakos/pylint/git/commits{/sha}","comments_url":"https://api.github.com/repos/molobrakos/pylint/comments{/number}","issue_comment_url":"https://api.github.com/repos/molobrakos/pylint/issues/comments{/number}","contents_url":"https://api.github.com/repos/molobrakos/pylint/contents/{+path}","compare_url":"https://api.github.com/repos/molobrakos/pylint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/molobrakos/pylint/merges","archive_url":"https://api.github.com/repos/molobrakos/pylint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/molobrakos/pylint/downloads","issues_url":"https://api.github.com/repos/molobrakos/pylint/issues{/number}","pulls_url":"https://api.github.com/repos/molobrakos/pylint/pulls{/number}","milestones_url":"https://api.github.com/repos/molobrakos/pylint/milestones{/number}","notifications_url":"https://api.github.com/repos/molobrakos/pylint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/molobrakos/pylint/labels{/name}","releases_url":"https://api.github.com/repos/molobrakos/pylint/releases{/id}","deployments_url":"https://api.github.com/repos/molobrakos/pylint/deployments","created_at":"2016-10-12T10:13:02Z","updated_at":"2016-10-12T10:13:04Z","pushed_at":"2016-10-14T17:08:00Z","git_url":"git://github.com/molobrakos/pylint.git","ssh_url":"git@github.com:molobrakos/pylint.git","clone_url":"https://github.com/molobrakos/pylint.git","svn_url":"https://github.com/molobrakos/pylint","homepage":null,"size":20646,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PyCQA:master","ref":"master","sha":"ad717acd4fb594b57aa893ecb30304604f650955","user":{"login":"PyCQA","id":8749848,"avatar_url":"https://avatars.githubusercontent.com/u/8749848?v=3","gravatar_id":"","url":"https://api.github.com/users/PyCQA","html_url":"https://github.com/PyCQA","followers_url":"https://api.github.com/users/PyCQA/followers","following_url":"https://api.github.com/users/PyCQA/following{/other_user}","gists_url":"https://api.github.com/users/PyCQA/gists{/gist_id}","starred_url":"https://api.github.com/users/PyCQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PyCQA/subscriptions","organizations_url":"https://api.github.com/users/PyCQA/orgs","repos_url":"https://api.github.com/users/PyCQA/repos","events_url":"https://api.github.com/users/PyCQA/events{/privacy}","received_events_url":"https://api.github.com/users/PyCQA/received_events","type":"Organization","site_admin":false},"repo":{"id":47671127,"name":"pylint","full_name":"PyCQA/pylint","owner":{"login":"PyCQA","id":8749848,"avatar_url":"https://avatars.githubusercontent.com/u/8749848?v=3","gravatar_id":"","url":"https://api.github.com/users/PyCQA","html_url":"https://github.com/PyCQA","followers_url":"https://api.github.com/users/PyCQA/followers","following_url":"https://api.github.com/users/PyCQA/following{/other_user}","gists_url":"https://api.github.com/users/PyCQA/gists{/gist_id}","starred_url":"https://api.github.com/users/PyCQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PyCQA/subscriptions","organizations_url":"https://api.github.com/users/PyCQA/orgs","repos_url":"https://api.github.com/users/PyCQA/repos","events_url":"https://api.github.com/users/PyCQA/events{/privacy}","received_events_url":"https://api.github.com/users/PyCQA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PyCQA/pylint","description":"A Python source code analyzer which looks for programming errors, helps enforcing a coding standard and sniffs for some code smells","fork":false,"url":"https://api.github.com/repos/PyCQA/pylint","forks_url":"https://api.github.com/repos/PyCQA/pylint/forks","keys_url":"https://api.github.com/repos/PyCQA/pylint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PyCQA/pylint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PyCQA/pylint/teams","hooks_url":"https://api.github.com/repos/PyCQA/pylint/hooks","issue_events_url":"https://api.github.com/repos/PyCQA/pylint/issues/events{/number}","events_url":"https://api.github.com/repos/PyCQA/pylint/events","assignees_url":"https://api.github.com/repos/PyCQA/pylint/assignees{/user}","branches_url":"https://api.github.com/repos/PyCQA/pylint/branches{/branch}","tags_url":"https://api.github.com/repos/PyCQA/pylint/tags","blobs_url":"https://api.github.com/repos/PyCQA/pylint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PyCQA/pylint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PyCQA/pylint/git/refs{/sha}","trees_url":"https://api.github.com/repos/PyCQA/pylint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PyCQA/pylint/statuses/{sha}","languages_url":"https://api.github.com/repos/PyCQA/pylint/languages","stargazers_url":"https://api.github.com/repos/PyCQA/pylint/stargazers","contributors_url":"https://api.github.com/repos/PyCQA/pylint/contributors","subscribers_url":"https://api.github.com/repos/PyCQA/pylint/subscribers","subscription_url":"https://api.github.com/repos/PyCQA/pylint/subscription","commits_url":"https://api.github.com/repos/PyCQA/pylint/commits{/sha}","git_commits_url":"https://api.github.com/repos/PyCQA/pylint/git/commits{/sha}","comments_url":"https://api.github.com/repos/PyCQA/pylint/comments{/number}","issue_comment_url":"https://api.github.com/repos/PyCQA/pylint/issues/comments{/number}","contents_url":"https://api.github.com/repos/PyCQA/pylint/contents/{+path}","compare_url":"https://api.github.com/repos/PyCQA/pylint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PyCQA/pylint/merges","archive_url":"https://api.github.com/repos/PyCQA/pylint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PyCQA/pylint/downloads","issues_url":"https://api.github.com/repos/PyCQA/pylint/issues{/number}","pulls_url":"https://api.github.com/repos/PyCQA/pylint/pulls{/number}","milestones_url":"https://api.github.com/repos/PyCQA/pylint/milestones{/number}","notifications_url":"https://api.github.com/repos/PyCQA/pylint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PyCQA/pylint/labels{/name}","releases_url":"https://api.github.com/repos/PyCQA/pylint/releases{/id}","deployments_url":"https://api.github.com/repos/PyCQA/pylint/deployments","created_at":"2015-12-09T05:40:02Z","updated_at":"2016-10-16T08:18:06Z","pushed_at":"2016-10-18T14:17:47Z","git_url":"git://github.com/PyCQA/pylint.git","ssh_url":"git@github.com:PyCQA/pylint.git","clone_url":"https://github.com/PyCQA/pylint.git","svn_url":"https://github.com/PyCQA/pylint","homepage":null,"size":20822,"stargazers_count":369,"watchers_count":369,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"open_issues_count":271,"forks":83,"open_issues":271,"watchers":369,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PyCQA/pylint/pulls/1134"},"html":{"href":"https://github.com/PyCQA/pylint/pull/1134"},"issue":{"href":"https://api.github.com/repos/PyCQA/pylint/issues/1134"},"comments":{"href":"https://api.github.com/repos/PyCQA/pylint/issues/1134/comments"},"review_comments":{"href":"https://api.github.com/repos/PyCQA/pylint/pulls/1134/comments"},"review_comment":{"href":"https://api.github.com/repos/PyCQA/pylint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PyCQA/pylint/pulls/1134/commits"},"statuses":{"href":"https://api.github.com/repos/PyCQA/pylint/statuses/e638509f5cb241968d295d66b0b3ac86a0574180"}}}}
{"actor":{"display_login":"PCManticore"}}