{"action":"created","issue":{"url":"https://api.github.com/repos/DataDog/dd-agent/issues/2136","labels_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2136/labels{/name}","comments_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2136/comments","events_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2136/events","html_url":"https://github.com/DataDog/dd-agent/pull/2136","id":121126656,"number":2136,"title":"[WMI] Switching IIS and Win Service Checks and Win32EventLog check to win32com. WMI refactor.","user":{"login":"truthbk","id":448216,"avatar_url":"https://avatars.githubusercontent.com/u/448216?v=3","gravatar_id":"","url":"https://api.github.com/users/truthbk","html_url":"https://github.com/truthbk","followers_url":"https://api.github.com/users/truthbk/followers","following_url":"https://api.github.com/users/truthbk/following{/other_user}","gists_url":"https://api.github.com/users/truthbk/gists{/gist_id}","starred_url":"https://api.github.com/users/truthbk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/truthbk/subscriptions","organizations_url":"https://api.github.com/users/truthbk/orgs","repos_url":"https://api.github.com/users/truthbk/repos","events_url":"https://api.github.com/users/truthbk/events{/privacy}","received_events_url":"https://api.github.com/users/truthbk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"yannmh","id":5708089,"avatar_url":"https://avatars.githubusercontent.com/u/5708089?v=3","gravatar_id":"","url":"https://api.github.com/users/yannmh","html_url":"https://github.com/yannmh","followers_url":"https://api.github.com/users/yannmh/followers","following_url":"https://api.github.com/users/yannmh/following{/other_user}","gists_url":"https://api.github.com/users/yannmh/gists{/gist_id}","starred_url":"https://api.github.com/users/yannmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannmh/subscriptions","organizations_url":"https://api.github.com/users/yannmh/orgs","repos_url":"https://api.github.com/users/yannmh/repos","events_url":"https://api.github.com/users/yannmh/events{/privacy}","received_events_url":"https://api.github.com/users/yannmh/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/DataDog/dd-agent/milestones/54","html_url":"https://github.com/DataDog/dd-agent/milestones/5.7.0","labels_url":"https://api.github.com/repos/DataDog/dd-agent/milestones/54/labels","id":1360063,"number":54,"title":"5.7.0","description":null,"creator":{"login":"remh","id":1311477,"avatar_url":"https://avatars.githubusercontent.com/u/1311477?v=3","gravatar_id":"","url":"https://api.github.com/users/remh","html_url":"https://github.com/remh","followers_url":"https://api.github.com/users/remh/followers","following_url":"https://api.github.com/users/remh/following{/other_user}","gists_url":"https://api.github.com/users/remh/gists{/gist_id}","starred_url":"https://api.github.com/users/remh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remh/subscriptions","organizations_url":"https://api.github.com/users/remh/orgs","repos_url":"https://api.github.com/users/remh/repos","events_url":"https://api.github.com/users/remh/events{/privacy}","received_events_url":"https://api.github.com/users/remh/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":91,"state":"open","created_at":"2015-10-16T19:06:06Z","updated_at":"2016-01-25T21:58:08Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2015-12-08T23:40:23Z","updated_at":"2016-01-26T20:57:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DataDog/dd-agent/pulls/2136","html_url":"https://github.com/DataDog/dd-agent/pull/2136","diff_url":"https://github.com/DataDog/dd-agent/pull/2136.diff","patch_url":"https://github.com/DataDog/dd-agent/pull/2136.patch"},"body":"# WMI via `win32com` for IIS, Service Checks and Win32EventLog\r\nThis PR aims to replace the older wmi module and use the WMI sampler based off `win32com` provided by @yann and @TheCloudlessSky in #2011 .\r\nBecause there is plenty of common code a new `WinWMICheck` class was introduced that is a parent to all our `wmi`related checks:\r\n* System\r\n* IIS\r\n* Windows Service\r\n* Windows Event Log\r\n\r\nTests have been re-written to support the new current code layout and behavior, and a totally new test has been introduced for the windows event log check."},"comment":{"url":"https://api.github.com/repos/DataDog/dd-agent/issues/comments/175226632","html_url":"https://github.com/DataDog/dd-agent/pull/2136#issuecomment-175226632","issue_url":"https://api.github.com/repos/DataDog/dd-agent/issues/2136","id":175226632,"user":{"login":"truthbk","id":448216,"avatar_url":"https://avatars.githubusercontent.com/u/448216?v=3","gravatar_id":"","url":"https://api.github.com/users/truthbk","html_url":"https://github.com/truthbk","followers_url":"https://api.github.com/users/truthbk/followers","following_url":"https://api.github.com/users/truthbk/following{/other_user}","gists_url":"https://api.github.com/users/truthbk/gists{/gist_id}","starred_url":"https://api.github.com/users/truthbk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/truthbk/subscriptions","organizations_url":"https://api.github.com/users/truthbk/orgs","repos_url":"https://api.github.com/users/truthbk/repos","events_url":"https://api.github.com/users/truthbk/events{/privacy}","received_events_url":"https://api.github.com/users/truthbk/received_events","type":"User","site_admin":false},"created_at":"2016-01-26T20:57:49Z","updated_at":"2016-01-26T20:57:49Z","body":"## TODO\r\n\r\n@yannmh: \r\n   - Raise `WMITimeoutException` when timeout\r\n   - Cache connections in `list` instead of `set`\r\n   - Gracefully handle `WMITimeoutException`\r\n\r\n@truthbk:\r\n   - Remove HashableConnection\r\n   - Get rid of `done()`\r\n   - Handle use-case where we're still sampling for service-checks (handle `WMITimeoutException`)."}}