{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-cli/pulls/comments/77398939","id":77398939,"diff_hunk":"@@ -335,7 +358,7 @@ def register_content_settings_argument(scope, settings_class):\n register_cli_argument('storage metrics update', 'api', help='Specify whether to include API in metrics. Applies to both hour and minute metrics if both are specified. Must be specified if hour or minute metrics are enabled and being updated.', choices=['enable', 'disable'])\n register_cli_argument('storage metrics update', 'retention', type=int, help='Number of days for which to retain metrics. 0 to disable. Applies to both hour and minute metrics if both are specified.')\n \n-register_cli_argument('storage cors', 'max_age', type=int, help='The number of seconds the client/browser should cache a preflight response.')\n+register_cli_argument('storage cors', 'max_age', type=int, help='The number of seconds the client/browser should cache a preflight response.', default=\"0\")","path":"src/command_modules/azure-cli-storage/azure/cli/command_modules/storage/_params.py","position":180,"original_position":180,"commit_id":"7613387add9b08a222a30eb71504992a50c806a5","original_commit_id":"bd399be6ae9dd2a86f0dccde8b5c8fd5345719e3","user":{"login":"tjprescott","id":5723682,"avatar_url":"https://avatars.githubusercontent.com/u/5723682?v=3","gravatar_id":"","url":"https://api.github.com/users/tjprescott","html_url":"https://github.com/tjprescott","followers_url":"https://api.github.com/users/tjprescott/followers","following_url":"https://api.github.com/users/tjprescott/following{/other_user}","gists_url":"https://api.github.com/users/tjprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/tjprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjprescott/subscriptions","organizations_url":"https://api.github.com/users/tjprescott/orgs","repos_url":"https://api.github.com/users/tjprescott/repos","events_url":"https://api.github.com/users/tjprescott/events{/privacy}","received_events_url":"https://api.github.com/users/tjprescott/received_events","type":"User","site_admin":false},"body":"The help does say what it means. \"The number of seconds...\" So 0 means 0 seconds.\r\n\r\nOn the other point, yes it does NEED to be \"0\". Just 0 results in argparse not printing anything for the default. \r\n\r\n---\r\nIn reply to: [77392503](https://github.com/Azure/azure-cli/pull/804#discussion_r77392503) [](ancestors = 77392503)","created_at":"2016-09-02T19:17:58Z","updated_at":"2016-09-02T19:17:58Z","html_url":"https://github.com/Azure/azure-cli/pull/804#discussion_r77398939","pull_request_url":"https://api.github.com/repos/Azure/azure-cli/pulls/804","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/comments/77398939"},"html":{"href":"https://github.com/Azure/azure-cli/pull/804#discussion_r77398939"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/804"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-cli/pulls/804","id":83530224,"html_url":"https://github.com/Azure/azure-cli/pull/804","diff_url":"https://github.com/Azure/azure-cli/pull/804.diff","patch_url":"https://github.com/Azure/azure-cli/pull/804.patch","issue_url":"https://api.github.com/repos/Azure/azure-cli/issues/804","number":804,"state":"open","locked":false,"title":"[Storage] Service Team Feeback Fixes Part 1","user":{"login":"tjprescott","id":5723682,"avatar_url":"https://avatars.githubusercontent.com/u/5723682?v=3","gravatar_id":"","url":"https://api.github.com/users/tjprescott","html_url":"https://github.com/tjprescott","followers_url":"https://api.github.com/users/tjprescott/followers","following_url":"https://api.github.com/users/tjprescott/following{/other_user}","gists_url":"https://api.github.com/users/tjprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/tjprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjprescott/subscriptions","organizations_url":"https://api.github.com/users/tjprescott/orgs","repos_url":"https://api.github.com/users/tjprescott/repos","events_url":"https://api.github.com/users/tjprescott/events{/privacy}","received_events_url":"https://api.github.com/users/tjprescott/received_events","type":"User","site_admin":false},"body":"This PR address numerous feedback items from the storage service team's review, including:\r\n- help text adjusted\r\n- `az storage blob/file update` now operate in a patch fashion\r\n- `az storage blob/file copy start` now expose extra convenience parameters to specify the source uri through mutliple option flags. This behavior is carried over from Xplat-CLI.\r\n\r\nNote that the `storage_help.txt` and `storage_group_help.txt` files are only in the PR for the service team's convenience and will be removed prior to merging the PR.","created_at":"2016-08-31T21:10:26Z","updated_at":"2016-09-02T19:17:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e31c409e4665dd5b311ab5ae7ad8d13da0b3666e","assignee":{"login":"BurtBiel","id":10136041,"avatar_url":"https://avatars.githubusercontent.com/u/10136041?v=3","gravatar_id":"","url":"https://api.github.com/users/BurtBiel","html_url":"https://github.com/BurtBiel","followers_url":"https://api.github.com/users/BurtBiel/followers","following_url":"https://api.github.com/users/BurtBiel/following{/other_user}","gists_url":"https://api.github.com/users/BurtBiel/gists{/gist_id}","starred_url":"https://api.github.com/users/BurtBiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BurtBiel/subscriptions","organizations_url":"https://api.github.com/users/BurtBiel/orgs","repos_url":"https://api.github.com/users/BurtBiel/repos","events_url":"https://api.github.com/users/BurtBiel/events{/privacy}","received_events_url":"https://api.github.com/users/BurtBiel/received_events","type":"User","site_admin":false},"assignees":[{"login":"BurtBiel","id":10136041,"avatar_url":"https://avatars.githubusercontent.com/u/10136041?v=3","gravatar_id":"","url":"https://api.github.com/users/BurtBiel","html_url":"https://github.com/BurtBiel","followers_url":"https://api.github.com/users/BurtBiel/followers","following_url":"https://api.github.com/users/BurtBiel/following{/other_user}","gists_url":"https://api.github.com/users/BurtBiel/gists{/gist_id}","starred_url":"https://api.github.com/users/BurtBiel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BurtBiel/subscriptions","organizations_url":"https://api.github.com/users/BurtBiel/orgs","repos_url":"https://api.github.com/users/BurtBiel/repos","events_url":"https://api.github.com/users/BurtBiel/events{/privacy}","received_events_url":"https://api.github.com/users/BurtBiel/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-cli/pulls/804/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-cli/pulls/804/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-cli/issues/804/comments","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/7613387add9b08a222a30eb71504992a50c806a5","head":{"label":"tjprescott:StorageCodeReview","ref":"StorageCodeReview","sha":"7613387add9b08a222a30eb71504992a50c806a5","user":{"login":"tjprescott","id":5723682,"avatar_url":"https://avatars.githubusercontent.com/u/5723682?v=3","gravatar_id":"","url":"https://api.github.com/users/tjprescott","html_url":"https://github.com/tjprescott","followers_url":"https://api.github.com/users/tjprescott/followers","following_url":"https://api.github.com/users/tjprescott/following{/other_user}","gists_url":"https://api.github.com/users/tjprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/tjprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjprescott/subscriptions","organizations_url":"https://api.github.com/users/tjprescott/orgs","repos_url":"https://api.github.com/users/tjprescott/repos","events_url":"https://api.github.com/users/tjprescott/events{/privacy}","received_events_url":"https://api.github.com/users/tjprescott/received_events","type":"User","site_admin":false},"repo":{"id":64678451,"name":"azure-cli","full_name":"tjprescott/azure-cli","owner":{"login":"tjprescott","id":5723682,"avatar_url":"https://avatars.githubusercontent.com/u/5723682?v=3","gravatar_id":"","url":"https://api.github.com/users/tjprescott","html_url":"https://github.com/tjprescott","followers_url":"https://api.github.com/users/tjprescott/followers","following_url":"https://api.github.com/users/tjprescott/following{/other_user}","gists_url":"https://api.github.com/users/tjprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/tjprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjprescott/subscriptions","organizations_url":"https://api.github.com/users/tjprescott/orgs","repos_url":"https://api.github.com/users/tjprescott/repos","events_url":"https://api.github.com/users/tjprescott/events{/privacy}","received_events_url":"https://api.github.com/users/tjprescott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tjprescott/azure-cli","description":"Command-line tools for Azure.","fork":true,"url":"https://api.github.com/repos/tjprescott/azure-cli","forks_url":"https://api.github.com/repos/tjprescott/azure-cli/forks","keys_url":"https://api.github.com/repos/tjprescott/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tjprescott/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tjprescott/azure-cli/teams","hooks_url":"https://api.github.com/repos/tjprescott/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/tjprescott/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/tjprescott/azure-cli/events","assignees_url":"https://api.github.com/repos/tjprescott/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/tjprescott/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/tjprescott/azure-cli/tags","blobs_url":"https://api.github.com/repos/tjprescott/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tjprescott/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tjprescott/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/tjprescott/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tjprescott/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/tjprescott/azure-cli/languages","stargazers_url":"https://api.github.com/repos/tjprescott/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/tjprescott/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/tjprescott/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/tjprescott/azure-cli/subscription","commits_url":"https://api.github.com/repos/tjprescott/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/tjprescott/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/tjprescott/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/tjprescott/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/tjprescott/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/tjprescott/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tjprescott/azure-cli/merges","archive_url":"https://api.github.com/repos/tjprescott/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tjprescott/azure-cli/downloads","issues_url":"https://api.github.com/repos/tjprescott/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/tjprescott/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/tjprescott/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/tjprescott/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tjprescott/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/tjprescott/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/tjprescott/azure-cli/deployments","created_at":"2016-08-01T15:24:25Z","updated_at":"2016-08-01T15:24:28Z","pushed_at":"2016-09-02T19:10:59Z","git_url":"git://github.com/tjprescott/azure-cli.git","ssh_url":"git@github.com:tjprescott/azure-cli.git","clone_url":"https://github.com/tjprescott/azure-cli.git","svn_url":"https://github.com/tjprescott/azure-cli","homepage":null,"size":6458,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"d353e4339f1f6443064ccbb53792d8554efa4ecb","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":51040886,"name":"azure-cli","full_name":"Azure/azure-cli","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-cli","description":"Command-line tools for Azure.","fork":false,"url":"https://api.github.com/repos/Azure/azure-cli","forks_url":"https://api.github.com/repos/Azure/azure-cli/forks","keys_url":"https://api.github.com/repos/Azure/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-cli/teams","hooks_url":"https://api.github.com/repos/Azure/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-cli/events","assignees_url":"https://api.github.com/repos/Azure/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-cli/tags","blobs_url":"https://api.github.com/repos/Azure/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-cli/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-cli/subscription","commits_url":"https://api.github.com/repos/Azure/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-cli/merges","archive_url":"https://api.github.com/repos/Azure/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-cli/downloads","issues_url":"https://api.github.com/repos/Azure/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-cli/deployments","created_at":"2016-02-04T00:21:51Z","updated_at":"2016-08-24T17:26:49Z","pushed_at":"2016-09-02T19:12:45Z","git_url":"git://github.com/Azure/azure-cli.git","ssh_url":"git@github.com:Azure/azure-cli.git","clone_url":"https://github.com/Azure/azure-cli.git","svn_url":"https://github.com/Azure/azure-cli","homepage":null,"size":9453,"stargazers_count":32,"watchers_count":32,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":128,"forks":18,"open_issues":128,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/804"},"html":{"href":"https://github.com/Azure/azure-cli/pull/804"},"issue":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/804"},"comments":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/804/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/804/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/804/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-cli/statuses/7613387add9b08a222a30eb71504992a50c806a5"}}}}
{"actor":{"display_login":"tjprescott"}}