{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/86497178","pull_request_review_id":7153514,"id":86497178,"diff_hunk":"@@ -583,30 +583,89 @@ def test_get_html_with_mocked_edx_video_id(self):\n         )\n \n     def test_get_html_with_existing_edx_video_id(self):\n-        # create test profiles and their encodings\n+        \"\"\"\n+        Tests the VideoModule get_html where a edx_video_id is given and related video is found\n+        \"\"\"\n+        edx_video_id = 'thundercats'\n+        encoded_videos = self.encode_and_create_video(edx_video_id)","path":"lms/djangoapps/courseware/tests/test_video_mongo.py","position":9,"original_position":9,"commit_id":"8a0477efa4e0b5c782ba8d38968719eaba01755c","original_commit_id":"8a0477efa4e0b5c782ba8d38968719eaba01755c","user":{"login":"awaisdar001","id":4252738,"avatar_url":"https://avatars.githubusercontent.com/u/4252738?v=3","gravatar_id":"","url":"https://api.github.com/users/awaisdar001","html_url":"https://github.com/awaisdar001","followers_url":"https://api.github.com/users/awaisdar001/followers","following_url":"https://api.github.com/users/awaisdar001/following{/other_user}","gists_url":"https://api.github.com/users/awaisdar001/gists{/gist_id}","starred_url":"https://api.github.com/users/awaisdar001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awaisdar001/subscriptions","organizations_url":"https://api.github.com/users/awaisdar001/orgs","repos_url":"https://api.github.com/users/awaisdar001/repos","events_url":"https://api.github.com/users/awaisdar001/events{/privacy}","received_events_url":"https://api.github.com/users/awaisdar001/received_events","type":"User","site_admin":false},"body":"`encoded_videos` or `encoded_video`? ","created_at":"2016-11-04T07:15:12Z","updated_at":"2016-11-04T07:15:12Z","html_url":"https://github.com/edx/edx-platform/pull/13878#discussion_r86497178","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/13878","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/86497178"},"html":{"href":"https://github.com/edx/edx-platform/pull/13878#discussion_r86497178"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13878"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/13878","id":91781892,"html_url":"https://github.com/edx/edx-platform/pull/13878","diff_url":"https://github.com/edx/edx-platform/pull/13878.diff","patch_url":"https://github.com/edx/edx-platform/pull/13878.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/13878","number":13878,"state":"open","locked":false,"title":"Video download button does not appear in course (TNL-5769)","user":{"login":"noraiz-anwar","id":22347092,"avatar_url":"https://avatars.githubusercontent.com/u/22347092?v=3","gravatar_id":"","url":"https://api.github.com/users/noraiz-anwar","html_url":"https://github.com/noraiz-anwar","followers_url":"https://api.github.com/users/noraiz-anwar/followers","following_url":"https://api.github.com/users/noraiz-anwar/following{/other_user}","gists_url":"https://api.github.com/users/noraiz-anwar/gists{/gist_id}","starred_url":"https://api.github.com/users/noraiz-anwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noraiz-anwar/subscriptions","organizations_url":"https://api.github.com/users/noraiz-anwar/orgs","repos_url":"https://api.github.com/users/noraiz-anwar/repos","events_url":"https://api.github.com/users/noraiz-anwar/events{/privacy}","received_events_url":"https://api.github.com/users/noraiz-anwar/received_events","type":"User","site_admin":false},"body":"This PR is made in effort to resolve this [issue](https://openedx.atlassian.net/browse/TNL-5769)\r\n\r\nA brief summary and attempted solution is as follows:\r\n\r\n- Despite having the Video Download Allowed set to True, the download button was not appearing for the video.\r\n- Video ID was extended by '\\t'(tab). This extra tab was causing problem while fetching video by edxval api so download link was not rendering.\r\n- Problem is resolved by stripping Video ID before sending it to edxval api method which fetch video from database.\r\n- Test is written to ensure any valid Video ID having unwanted space(s) before or after it should not cause any problem.","created_at":"2016-11-01T13:22:04Z","updated_at":"2016-11-04T07:15:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e64075d0377311207af2352d469361e5bb7ddb8d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/13878/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/13878/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/13878/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/8a0477efa4e0b5c782ba8d38968719eaba01755c","head":{"label":"edx:TNL-5769","ref":"TNL-5769","sha":"8a0477efa4e0b5c782ba8d38968719eaba01755c","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-11-04T04:27:28Z","pushed_at":"2016-11-04T07:13:47Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":855318,"stargazers_count":2846,"watchers_count":2846,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1694,"mirror_url":null,"open_issues_count":154,"forks":1694,"open_issues":154,"watchers":2846,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"dc8d020e3080098394a88366c5c16e14906e9a2d","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2016-11-04T04:27:28Z","pushed_at":"2016-11-04T07:13:47Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":855318,"stargazers_count":2846,"watchers_count":2846,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1694,"mirror_url":null,"open_issues_count":154,"forks":1694,"open_issues":154,"watchers":2846,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13878"},"html":{"href":"https://github.com/edx/edx-platform/pull/13878"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/13878"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/13878/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13878/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/13878/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/8a0477efa4e0b5c782ba8d38968719eaba01755c"}}}}
{"actor":{"display_login":"awaisdar001"}}