{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/sonic-swss-common/pulls/comments/59594918","id":59594918,"diff_hunk":"@@ -8,17 +10,28 @@ using namespace std;\n \n namespace swss {\n \n-void Select::addSelectable(Selectable *c)\n+void Select::addSelectable(_in_ Selectable *selectable)\n {\n-    m_objects.push_back(c);\n+    if(std::find(m_objects.begin(), m_objects.end(), selectable) != m_objects.end()) {\n+        SWSS_LOG_WARN(\"Selectable:%p already been added to the list, ignoring\\n.\");","path":"common/select.cpp","position":16,"original_position":16,"commit_id":"fb3bc8e00f740c6a2d585f00326866a3b29a1927","original_commit_id":"fb3bc8e00f740c6a2d585f00326866a3b29a1927","user":{"login":"kcudnik","id":17052279,"avatar_url":"https://avatars.githubusercontent.com/u/17052279?v=3","gravatar_id":"","url":"https://api.github.com/users/kcudnik","html_url":"https://github.com/kcudnik","followers_url":"https://api.github.com/users/kcudnik/followers","following_url":"https://api.github.com/users/kcudnik/following{/other_user}","gists_url":"https://api.github.com/users/kcudnik/gists{/gist_id}","starred_url":"https://api.github.com/users/kcudnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcudnik/subscriptions","organizations_url":"https://api.github.com/users/kcudnik/orgs","repos_url":"https://api.github.com/users/kcudnik/repos","events_url":"https://api.github.com/users/kcudnik/events{/privacy}","received_events_url":"https://api.github.com/users/kcudnik/received_events","type":"User","site_admin":false},"body":"\"\\n.\" is not needed, we can enforce in logs to add \\n at the end but currently it goes to syslog so no need","created_at":"2016-04-13T17:58:27Z","updated_at":"2016-04-13T17:58:27Z","html_url":"https://github.com/Azure/sonic-swss-common/pull/4#discussion_r59594918","pull_request_url":"https://api.github.com/repos/Azure/sonic-swss-common/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/Azure/sonic-swss-common/pulls/comments/59594918"},"html":{"href":"https://github.com/Azure/sonic-swss-common/pull/4#discussion_r59594918"},"pull_request":{"href":"https://api.github.com/repos/Azure/sonic-swss-common/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/sonic-swss-common/pulls/4","id":66077885,"html_url":"https://github.com/Azure/sonic-swss-common/pull/4","diff_url":"https://github.com/Azure/sonic-swss-common/pull/4.diff","patch_url":"https://github.com/Azure/sonic-swss-common/pull/4.patch","issue_url":"https://api.github.com/repos/Azure/sonic-swss-common/issues/4","number":4,"state":"open","locked":false,"title":"Swss.common.multi.consumer","user":{"login":"hrachya-mellanox","id":12867186,"avatar_url":"https://avatars.githubusercontent.com/u/12867186?v=3","gravatar_id":"","url":"https://api.github.com/users/hrachya-mellanox","html_url":"https://github.com/hrachya-mellanox","followers_url":"https://api.github.com/users/hrachya-mellanox/followers","following_url":"https://api.github.com/users/hrachya-mellanox/following{/other_user}","gists_url":"https://api.github.com/users/hrachya-mellanox/gists{/gist_id}","starred_url":"https://api.github.com/users/hrachya-mellanox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrachya-mellanox/subscriptions","organizations_url":"https://api.github.com/users/hrachya-mellanox/orgs","repos_url":"https://api.github.com/users/hrachya-mellanox/repos","events_url":"https://api.github.com/users/hrachya-mellanox/events{/privacy}","received_events_url":"https://api.github.com/users/hrachya-mellanox/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-11T23:14:41Z","updated_at":"2016-04-13T17:58:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a43355beae26aa541a3a571a765d1715c85f9a4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Azure/sonic-swss-common/pulls/4/commits","review_comments_url":"https://api.github.com/repos/Azure/sonic-swss-common/pulls/4/comments","review_comment_url":"https://api.github.com/repos/Azure/sonic-swss-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/sonic-swss-common/issues/4/comments","statuses_url":"https://api.github.com/repos/Azure/sonic-swss-common/statuses/fb3bc8e00f740c6a2d585f00326866a3b29a1927","head":{"label":"hrachya-mellanox:swss.common.multi.consumer","ref":"swss.common.multi.consumer","sha":"fb3bc8e00f740c6a2d585f00326866a3b29a1927","user":{"login":"hrachya-mellanox","id":12867186,"avatar_url":"https://avatars.githubusercontent.com/u/12867186?v=3","gravatar_id":"","url":"https://api.github.com/users/hrachya-mellanox","html_url":"https://github.com/hrachya-mellanox","followers_url":"https://api.github.com/users/hrachya-mellanox/followers","following_url":"https://api.github.com/users/hrachya-mellanox/following{/other_user}","gists_url":"https://api.github.com/users/hrachya-mellanox/gists{/gist_id}","starred_url":"https://api.github.com/users/hrachya-mellanox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrachya-mellanox/subscriptions","organizations_url":"https://api.github.com/users/hrachya-mellanox/orgs","repos_url":"https://api.github.com/users/hrachya-mellanox/repos","events_url":"https://api.github.com/users/hrachya-mellanox/events{/privacy}","received_events_url":"https://api.github.com/users/hrachya-mellanox/received_events","type":"User","site_admin":false},"repo":{"id":55181627,"name":"sonic-swss-common","full_name":"hrachya-mellanox/sonic-swss-common","owner":{"login":"hrachya-mellanox","id":12867186,"avatar_url":"https://avatars.githubusercontent.com/u/12867186?v=3","gravatar_id":"","url":"https://api.github.com/users/hrachya-mellanox","html_url":"https://github.com/hrachya-mellanox","followers_url":"https://api.github.com/users/hrachya-mellanox/followers","following_url":"https://api.github.com/users/hrachya-mellanox/following{/other_user}","gists_url":"https://api.github.com/users/hrachya-mellanox/gists{/gist_id}","starred_url":"https://api.github.com/users/hrachya-mellanox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrachya-mellanox/subscriptions","organizations_url":"https://api.github.com/users/hrachya-mellanox/orgs","repos_url":"https://api.github.com/users/hrachya-mellanox/repos","events_url":"https://api.github.com/users/hrachya-mellanox/events{/privacy}","received_events_url":"https://api.github.com/users/hrachya-mellanox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hrachya-mellanox/sonic-swss-common","description":"Common components for SONiC switch state service","fork":true,"url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common","forks_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/forks","keys_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/teams","hooks_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/hooks","issue_events_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/issues/events{/number}","events_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/events","assignees_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/assignees{/user}","branches_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/branches{/branch}","tags_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/tags","blobs_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/statuses/{sha}","languages_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/languages","stargazers_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/stargazers","contributors_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/contributors","subscribers_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/subscribers","subscription_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/subscription","commits_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/contents/{+path}","compare_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/merges","archive_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/downloads","issues_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/issues{/number}","pulls_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/pulls{/number}","milestones_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/milestones{/number}","notifications_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/labels{/name}","releases_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/releases{/id}","deployments_url":"https://api.github.com/repos/hrachya-mellanox/sonic-swss-common/deployments","created_at":"2016-03-31T20:42:06Z","updated_at":"2016-03-31T20:42:07Z","pushed_at":"2016-04-13T01:19:48Z","git_url":"git://github.com/hrachya-mellanox/sonic-swss-common.git","ssh_url":"git@github.com:hrachya-mellanox/sonic-swss-common.git","clone_url":"https://github.com/hrachya-mellanox/sonic-swss-common.git","svn_url":"https://github.com/hrachya-mellanox/sonic-swss-common","homepage":null,"size":453,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"d162c369f5cd90a5b9cf0238b9509ba0aa6c8031","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":54597875,"name":"sonic-swss-common","full_name":"Azure/sonic-swss-common","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/sonic-swss-common","description":"Common components for SONiC switch state service","fork":false,"url":"https://api.github.com/repos/Azure/sonic-swss-common","forks_url":"https://api.github.com/repos/Azure/sonic-swss-common/forks","keys_url":"https://api.github.com/repos/Azure/sonic-swss-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/sonic-swss-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/sonic-swss-common/teams","hooks_url":"https://api.github.com/repos/Azure/sonic-swss-common/hooks","issue_events_url":"https://api.github.com/repos/Azure/sonic-swss-common/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/sonic-swss-common/events","assignees_url":"https://api.github.com/repos/Azure/sonic-swss-common/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/sonic-swss-common/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/sonic-swss-common/tags","blobs_url":"https://api.github.com/repos/Azure/sonic-swss-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/sonic-swss-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/sonic-swss-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/sonic-swss-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/sonic-swss-common/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/sonic-swss-common/languages","stargazers_url":"https://api.github.com/repos/Azure/sonic-swss-common/stargazers","contributors_url":"https://api.github.com/repos/Azure/sonic-swss-common/contributors","subscribers_url":"https://api.github.com/repos/Azure/sonic-swss-common/subscribers","subscription_url":"https://api.github.com/repos/Azure/sonic-swss-common/subscription","commits_url":"https://api.github.com/repos/Azure/sonic-swss-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/sonic-swss-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/sonic-swss-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/sonic-swss-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/sonic-swss-common/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/sonic-swss-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/sonic-swss-common/merges","archive_url":"https://api.github.com/repos/Azure/sonic-swss-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/sonic-swss-common/downloads","issues_url":"https://api.github.com/repos/Azure/sonic-swss-common/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/sonic-swss-common/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/sonic-swss-common/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/sonic-swss-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/sonic-swss-common/labels{/name}","releases_url":"https://api.github.com/repos/Azure/sonic-swss-common/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/sonic-swss-common/deployments","created_at":"2016-03-23T22:39:26Z","updated_at":"2016-04-08T22:46:20Z","pushed_at":"2016-04-13T01:19:49Z","git_url":"git://github.com/Azure/sonic-swss-common.git","ssh_url":"git@github.com:Azure/sonic-swss-common.git","clone_url":"https://github.com/Azure/sonic-swss-common.git","svn_url":"https://github.com/Azure/sonic-swss-common","homepage":null,"size":457,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/sonic-swss-common/pulls/4"},"html":{"href":"https://github.com/Azure/sonic-swss-common/pull/4"},"issue":{"href":"https://api.github.com/repos/Azure/sonic-swss-common/issues/4"},"comments":{"href":"https://api.github.com/repos/Azure/sonic-swss-common/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/sonic-swss-common/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/sonic-swss-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/sonic-swss-common/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/sonic-swss-common/statuses/fb3bc8e00f740c6a2d585f00326866a3b29a1927"}}}}