{"action":"created","comment":{"url":"https://api.github.com/repos/DoSomething/longshot/pulls/comments/60472327","id":60472327,"diff_hunk":"@@ -9,26 +9,34 @@\n use App\\Models\\User;\n use App\\Models\\Email;\n \n-\n class RecommendationController extends \\Controller\n {\n     protected $settings;\n \n     protected $rules = [\n-    'rank_character'  => 'required',\n-    'rank_additional' => 'required',\n-    'essay1'          => 'required',\n+      'rank_character'  => 'required',\n+      'rank_additional' => 'required',\n+      'essay1'          => 'required',\n+    ];\n+\n+    protected $applicant_rules = [","path":"app/Http/Controllers/RecommendationController.php","position":18,"original_position":18,"commit_id":"a1fc612b6a22a7bbca7c17a1feab204b027f615e","original_commit_id":"a1fc612b6a22a7bbca7c17a1feab204b027f615e","user":{"login":"katiecrane","id":4240292,"avatar_url":"https://avatars.githubusercontent.com/u/4240292?v=3","gravatar_id":"","url":"https://api.github.com/users/katiecrane","html_url":"https://github.com/katiecrane","followers_url":"https://api.github.com/users/katiecrane/followers","following_url":"https://api.github.com/users/katiecrane/following{/other_user}","gists_url":"https://api.github.com/users/katiecrane/gists{/gist_id}","starred_url":"https://api.github.com/users/katiecrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katiecrane/subscriptions","organizations_url":"https://api.github.com/users/katiecrane/orgs","repos_url":"https://api.github.com/users/katiecrane/repos","events_url":"https://api.github.com/users/katiecrane/events{/privacy}","received_events_url":"https://api.github.com/users/katiecrane/received_events","type":"User","site_admin":false},"body":"Okay yeah this is probably the most confusing part. So the normal rules get checked [here](https://github.com/DoSomething/longshot/pull/764/files#diff-4f2c714c5841af863b7dbb3b575ff548R186) and last I checked that was working for recommenders. I do think where that gets called is confusing though, so I'll try moving it into the `updateAdmin` function which makes way more sense to me. \r\n\r\nI'll double check that all the recommender stuff validates correctly and use both arrays.","created_at":"2016-04-20T19:28:52Z","updated_at":"2016-04-20T19:28:52Z","html_url":"https://github.com/DoSomething/longshot/pull/764#discussion_r60472327","pull_request_url":"https://api.github.com/repos/DoSomething/longshot/pulls/764","_links":{"self":{"href":"https://api.github.com/repos/DoSomething/longshot/pulls/comments/60472327"},"html":{"href":"https://github.com/DoSomething/longshot/pull/764#discussion_r60472327"},"pull_request":{"href":"https://api.github.com/repos/DoSomething/longshot/pulls/764"}}},"pull_request":{"url":"https://api.github.com/repos/DoSomething/longshot/pulls/764","id":67073527,"html_url":"https://github.com/DoSomething/longshot/pull/764","diff_url":"https://github.com/DoSomething/longshot/pull/764.diff","patch_url":"https://github.com/DoSomething/longshot/pull/764.patch","issue_url":"https://api.github.com/repos/DoSomething/longshot/issues/764","number":764,"state":"open","locked":false,"title":"users can edit rec info","user":{"login":"katiecrane","id":4240292,"avatar_url":"https://avatars.githubusercontent.com/u/4240292?v=3","gravatar_id":"","url":"https://api.github.com/users/katiecrane","html_url":"https://github.com/katiecrane","followers_url":"https://api.github.com/users/katiecrane/followers","following_url":"https://api.github.com/users/katiecrane/following{/other_user}","gists_url":"https://api.github.com/users/katiecrane/gists{/gist_id}","starred_url":"https://api.github.com/users/katiecrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katiecrane/subscriptions","organizations_url":"https://api.github.com/users/katiecrane/orgs","repos_url":"https://api.github.com/users/katiecrane/repos","events_url":"https://api.github.com/users/katiecrane/events{/privacy}","received_events_url":"https://api.github.com/users/katiecrane/received_events","type":"User","site_admin":false},"body":"Enter the joyous world of recommendations!\r\n\r\nStyleCI fix PR to follow after I wrap up my branches in progress, otherwise there will be one million conflicts\r\n\r\nImportant changes:\r\n- \"Add a rec\" button on status page is now \"add or edit a rec\"\r\n- Applicant rec edit page allows them to edit existing recs that have not been completed and request new recs\r\n- If an applicant edits an existing rec request email address, a new email is sent. Otherwise, no new email is sent.\r\n- Recommenders can edit their name, email, and phone number on the recommendation page\r\n\r\n### Issues:\r\nFixes #745\r\nFixes #750","created_at":"2016-04-19T19:15:33Z","updated_at":"2016-04-20T19:28:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b32cda9322ee597b6e95d295c2ade291ae922d3","assignee":{"login":"angaither","id":645205,"avatar_url":"https://avatars.githubusercontent.com/u/645205?v=3","gravatar_id":"","url":"https://api.github.com/users/angaither","html_url":"https://github.com/angaither","followers_url":"https://api.github.com/users/angaither/followers","following_url":"https://api.github.com/users/angaither/following{/other_user}","gists_url":"https://api.github.com/users/angaither/gists{/gist_id}","starred_url":"https://api.github.com/users/angaither/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angaither/subscriptions","organizations_url":"https://api.github.com/users/angaither/orgs","repos_url":"https://api.github.com/users/angaither/repos","events_url":"https://api.github.com/users/angaither/events{/privacy}","received_events_url":"https://api.github.com/users/angaither/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/DoSomething/longshot/pulls/764/commits","review_comments_url":"https://api.github.com/repos/DoSomething/longshot/pulls/764/comments","review_comment_url":"https://api.github.com/repos/DoSomething/longshot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DoSomething/longshot/issues/764/comments","statuses_url":"https://api.github.com/repos/DoSomething/longshot/statuses/a1fc612b6a22a7bbca7c17a1feab204b027f615e","head":{"label":"DoSomething:edit-rec-info","ref":"edit-rec-info","sha":"a1fc612b6a22a7bbca7c17a1feab204b027f615e","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":22072648,"name":"longshot","full_name":"DoSomething/longshot","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/longshot","description":"Scholarship Applications stand-alone web app.","fork":false,"url":"https://api.github.com/repos/DoSomething/longshot","forks_url":"https://api.github.com/repos/DoSomething/longshot/forks","keys_url":"https://api.github.com/repos/DoSomething/longshot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/longshot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/longshot/teams","hooks_url":"https://api.github.com/repos/DoSomething/longshot/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/longshot/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/longshot/events","assignees_url":"https://api.github.com/repos/DoSomething/longshot/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/longshot/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/longshot/tags","blobs_url":"https://api.github.com/repos/DoSomething/longshot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/longshot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/longshot/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/longshot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/longshot/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/longshot/languages","stargazers_url":"https://api.github.com/repos/DoSomething/longshot/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/longshot/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/longshot/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/longshot/subscription","commits_url":"https://api.github.com/repos/DoSomething/longshot/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/longshot/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/longshot/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/longshot/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/longshot/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/longshot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/longshot/merges","archive_url":"https://api.github.com/repos/DoSomething/longshot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/longshot/downloads","issues_url":"https://api.github.com/repos/DoSomething/longshot/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/longshot/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/longshot/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/longshot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/longshot/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/longshot/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/longshot/deployments","created_at":"2014-07-21T17:03:06Z","updated_at":"2016-01-14T15:05:20Z","pushed_at":"2016-04-20T18:13:40Z","git_url":"git://github.com/DoSomething/longshot.git","ssh_url":"git@github.com:DoSomething/longshot.git","clone_url":"https://github.com/DoSomething/longshot.git","svn_url":"https://github.com/DoSomething/longshot","homepage":null,"size":14610,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":34,"forks":3,"open_issues":34,"watchers":5,"default_branch":"master"}},"base":{"label":"DoSomething:master","ref":"master","sha":"658472c1ccccd21c01d0d0144f5cb1db6358578a","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":22072648,"name":"longshot","full_name":"DoSomething/longshot","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/longshot","description":"Scholarship Applications stand-alone web app.","fork":false,"url":"https://api.github.com/repos/DoSomething/longshot","forks_url":"https://api.github.com/repos/DoSomething/longshot/forks","keys_url":"https://api.github.com/repos/DoSomething/longshot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/longshot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/longshot/teams","hooks_url":"https://api.github.com/repos/DoSomething/longshot/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/longshot/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/longshot/events","assignees_url":"https://api.github.com/repos/DoSomething/longshot/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/longshot/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/longshot/tags","blobs_url":"https://api.github.com/repos/DoSomething/longshot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/longshot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/longshot/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/longshot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/longshot/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/longshot/languages","stargazers_url":"https://api.github.com/repos/DoSomething/longshot/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/longshot/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/longshot/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/longshot/subscription","commits_url":"https://api.github.com/repos/DoSomething/longshot/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/longshot/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/longshot/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/longshot/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/longshot/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/longshot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/longshot/merges","archive_url":"https://api.github.com/repos/DoSomething/longshot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/longshot/downloads","issues_url":"https://api.github.com/repos/DoSomething/longshot/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/longshot/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/longshot/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/longshot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/longshot/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/longshot/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/longshot/deployments","created_at":"2014-07-21T17:03:06Z","updated_at":"2016-01-14T15:05:20Z","pushed_at":"2016-04-20T18:13:40Z","git_url":"git://github.com/DoSomething/longshot.git","ssh_url":"git@github.com:DoSomething/longshot.git","clone_url":"https://github.com/DoSomething/longshot.git","svn_url":"https://github.com/DoSomething/longshot","homepage":null,"size":14610,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":34,"forks":3,"open_issues":34,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DoSomething/longshot/pulls/764"},"html":{"href":"https://github.com/DoSomething/longshot/pull/764"},"issue":{"href":"https://api.github.com/repos/DoSomething/longshot/issues/764"},"comments":{"href":"https://api.github.com/repos/DoSomething/longshot/issues/764/comments"},"review_comments":{"href":"https://api.github.com/repos/DoSomething/longshot/pulls/764/comments"},"review_comment":{"href":"https://api.github.com/repos/DoSomething/longshot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DoSomething/longshot/pulls/764/commits"},"statuses":{"href":"https://api.github.com/repos/DoSomething/longshot/statuses/a1fc612b6a22a7bbca7c17a1feab204b027f615e"}}}}