{"action":"created","comment":{"url":"https://api.github.com/repos/metabase/metabase/pulls/comments/59309223","id":59309223,"diff_hunk":"@@ -92,6 +92,12 @@\n                                                   msg)))\n                                             explanation))))\n \n+\n+;; +-------------------------------------------------------------------------------------------------------------------+","path":"src/metabase/driver/query_processor.clj","position":14,"original_position":14,"commit_id":"7fef2d3ca1cb456c461624416c9136f91c6a747e","original_commit_id":"7fef2d3ca1cb456c461624416c9136f91c6a747e","user":{"login":"agilliland","id":1987787,"avatar_url":"https://avatars.githubusercontent.com/u/1987787?v=3","gravatar_id":"","url":"https://api.github.com/users/agilliland","html_url":"https://github.com/agilliland","followers_url":"https://api.github.com/users/agilliland/followers","following_url":"https://api.github.com/users/agilliland/following{/other_user}","gists_url":"https://api.github.com/users/agilliland/gists{/gist_id}","starred_url":"https://api.github.com/users/agilliland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agilliland/subscriptions","organizations_url":"https://api.github.com/users/agilliland/orgs","repos_url":"https://api.github.com/users/agilliland/repos","events_url":"https://api.github.com/users/agilliland/events{/privacy}","received_events_url":"https://api.github.com/users/agilliland/received_events","type":"User","site_admin":false},"body":"sure, i'm happy to do that.  i literally copied that from other places in the code such as https://github.com/metabase/metabase/blob/master/src/metabase/driver/query_processor.clj","created_at":"2016-04-12T01:29:44Z","updated_at":"2016-04-12T01:29:44Z","html_url":"https://github.com/metabase/metabase/pull/2353#discussion_r59309223","pull_request_url":"https://api.github.com/repos/metabase/metabase/pulls/2353","_links":{"self":{"href":"https://api.github.com/repos/metabase/metabase/pulls/comments/59309223"},"html":{"href":"https://github.com/metabase/metabase/pull/2353#discussion_r59309223"},"pull_request":{"href":"https://api.github.com/repos/metabase/metabase/pulls/2353"}}},"pull_request":{"url":"https://api.github.com/repos/metabase/metabase/pulls/2353","id":66033301,"html_url":"https://github.com/metabase/metabase/pull/2353","diff_url":"https://github.com/metabase/metabase/pull/2353.diff","patch_url":"https://github.com/metabase/metabase/pull/2353.patch","issue_url":"https://api.github.com/repos/metabase/metabase/issues/2353","number":2353,"state":"open","locked":false,"title":"QP tweaks + some tests","user":{"login":"agilliland","id":1987787,"avatar_url":"https://avatars.githubusercontent.com/u/1987787?v=3","gravatar_id":"","url":"https://api.github.com/users/agilliland","html_url":"https://github.com/agilliland","followers_url":"https://api.github.com/users/agilliland/followers","following_url":"https://api.github.com/users/agilliland/following{/other_user}","gists_url":"https://api.github.com/users/agilliland/gists{/gist_id}","starred_url":"https://api.github.com/users/agilliland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agilliland/subscriptions","organizations_url":"https://api.github.com/users/agilliland/orgs","repos_url":"https://api.github.com/users/agilliland/repos","events_url":"https://api.github.com/users/agilliland/events{/privacy}","received_events_url":"https://api.github.com/users/agilliland/received_events","type":"User","site_admin":false},"body":"These are not functional changes, just some tweaks to code style and function definitions to be more consistent, along with some added docstrings and unit tests.","created_at":"2016-04-11T17:43:58Z","updated_at":"2016-04-12T01:29:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61fa4fd883c2a6385ea6965991883e95fceed0e3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/metabase/metabase/pulls/2353/commits","review_comments_url":"https://api.github.com/repos/metabase/metabase/pulls/2353/comments","review_comment_url":"https://api.github.com/repos/metabase/metabase/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metabase/metabase/issues/2353/comments","statuses_url":"https://api.github.com/repos/metabase/metabase/statuses/7fef2d3ca1cb456c461624416c9136f91c6a747e","head":{"label":"metabase:qp-tweaks-and-tests","ref":"qp-tweaks-and-tests","sha":"7fef2d3ca1cb456c461624416c9136f91c6a747e","user":{"login":"metabase","id":10520629,"avatar_url":"https://avatars.githubusercontent.com/u/10520629?v=3","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"repo":{"id":30203935,"name":"metabase","full_name":"metabase/metabase","owner":{"login":"metabase","id":10520629,"avatar_url":"https://avatars.githubusercontent.com/u/10520629?v=3","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metabase/metabase","description":"The simplest, fastest way to get business intelligence and analytics  to everyone in your company :yum:","fork":false,"url":"https://api.github.com/repos/metabase/metabase","forks_url":"https://api.github.com/repos/metabase/metabase/forks","keys_url":"https://api.github.com/repos/metabase/metabase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metabase/metabase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metabase/metabase/teams","hooks_url":"https://api.github.com/repos/metabase/metabase/hooks","issue_events_url":"https://api.github.com/repos/metabase/metabase/issues/events{/number}","events_url":"https://api.github.com/repos/metabase/metabase/events","assignees_url":"https://api.github.com/repos/metabase/metabase/assignees{/user}","branches_url":"https://api.github.com/repos/metabase/metabase/branches{/branch}","tags_url":"https://api.github.com/repos/metabase/metabase/tags","blobs_url":"https://api.github.com/repos/metabase/metabase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metabase/metabase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metabase/metabase/git/refs{/sha}","trees_url":"https://api.github.com/repos/metabase/metabase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metabase/metabase/statuses/{sha}","languages_url":"https://api.github.com/repos/metabase/metabase/languages","stargazers_url":"https://api.github.com/repos/metabase/metabase/stargazers","contributors_url":"https://api.github.com/repos/metabase/metabase/contributors","subscribers_url":"https://api.github.com/repos/metabase/metabase/subscribers","subscription_url":"https://api.github.com/repos/metabase/metabase/subscription","commits_url":"https://api.github.com/repos/metabase/metabase/commits{/sha}","git_commits_url":"https://api.github.com/repos/metabase/metabase/git/commits{/sha}","comments_url":"https://api.github.com/repos/metabase/metabase/comments{/number}","issue_comment_url":"https://api.github.com/repos/metabase/metabase/issues/comments{/number}","contents_url":"https://api.github.com/repos/metabase/metabase/contents/{+path}","compare_url":"https://api.github.com/repos/metabase/metabase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metabase/metabase/merges","archive_url":"https://api.github.com/repos/metabase/metabase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metabase/metabase/downloads","issues_url":"https://api.github.com/repos/metabase/metabase/issues{/number}","pulls_url":"https://api.github.com/repos/metabase/metabase/pulls{/number}","milestones_url":"https://api.github.com/repos/metabase/metabase/milestones{/number}","notifications_url":"https://api.github.com/repos/metabase/metabase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metabase/metabase/labels{/name}","releases_url":"https://api.github.com/repos/metabase/metabase/releases{/id}","deployments_url":"https://api.github.com/repos/metabase/metabase/deployments","created_at":"2015-02-02T19:25:47Z","updated_at":"2016-04-12T00:13:13Z","pushed_at":"2016-04-12T01:16:26Z","git_url":"git://github.com/metabase/metabase.git","ssh_url":"git@github.com:metabase/metabase.git","clone_url":"https://github.com/metabase/metabase.git","svn_url":"https://github.com/metabase/metabase","homepage":"http://metabase.com","size":35420,"stargazers_count":2480,"watchers_count":2480,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":133,"mirror_url":null,"open_issues_count":303,"forks":133,"open_issues":303,"watchers":2480,"default_branch":"master"}},"base":{"label":"metabase:master","ref":"master","sha":"3c7de662b17b017d5d75d79bd8b22f0fdb6d4f00","user":{"login":"metabase","id":10520629,"avatar_url":"https://avatars.githubusercontent.com/u/10520629?v=3","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"repo":{"id":30203935,"name":"metabase","full_name":"metabase/metabase","owner":{"login":"metabase","id":10520629,"avatar_url":"https://avatars.githubusercontent.com/u/10520629?v=3","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metabase/metabase","description":"The simplest, fastest way to get business intelligence and analytics  to everyone in your company :yum:","fork":false,"url":"https://api.github.com/repos/metabase/metabase","forks_url":"https://api.github.com/repos/metabase/metabase/forks","keys_url":"https://api.github.com/repos/metabase/metabase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metabase/metabase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metabase/metabase/teams","hooks_url":"https://api.github.com/repos/metabase/metabase/hooks","issue_events_url":"https://api.github.com/repos/metabase/metabase/issues/events{/number}","events_url":"https://api.github.com/repos/metabase/metabase/events","assignees_url":"https://api.github.com/repos/metabase/metabase/assignees{/user}","branches_url":"https://api.github.com/repos/metabase/metabase/branches{/branch}","tags_url":"https://api.github.com/repos/metabase/metabase/tags","blobs_url":"https://api.github.com/repos/metabase/metabase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metabase/metabase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metabase/metabase/git/refs{/sha}","trees_url":"https://api.github.com/repos/metabase/metabase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metabase/metabase/statuses/{sha}","languages_url":"https://api.github.com/repos/metabase/metabase/languages","stargazers_url":"https://api.github.com/repos/metabase/metabase/stargazers","contributors_url":"https://api.github.com/repos/metabase/metabase/contributors","subscribers_url":"https://api.github.com/repos/metabase/metabase/subscribers","subscription_url":"https://api.github.com/repos/metabase/metabase/subscription","commits_url":"https://api.github.com/repos/metabase/metabase/commits{/sha}","git_commits_url":"https://api.github.com/repos/metabase/metabase/git/commits{/sha}","comments_url":"https://api.github.com/repos/metabase/metabase/comments{/number}","issue_comment_url":"https://api.github.com/repos/metabase/metabase/issues/comments{/number}","contents_url":"https://api.github.com/repos/metabase/metabase/contents/{+path}","compare_url":"https://api.github.com/repos/metabase/metabase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metabase/metabase/merges","archive_url":"https://api.github.com/repos/metabase/metabase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metabase/metabase/downloads","issues_url":"https://api.github.com/repos/metabase/metabase/issues{/number}","pulls_url":"https://api.github.com/repos/metabase/metabase/pulls{/number}","milestones_url":"https://api.github.com/repos/metabase/metabase/milestones{/number}","notifications_url":"https://api.github.com/repos/metabase/metabase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metabase/metabase/labels{/name}","releases_url":"https://api.github.com/repos/metabase/metabase/releases{/id}","deployments_url":"https://api.github.com/repos/metabase/metabase/deployments","created_at":"2015-02-02T19:25:47Z","updated_at":"2016-04-12T00:13:13Z","pushed_at":"2016-04-12T01:16:26Z","git_url":"git://github.com/metabase/metabase.git","ssh_url":"git@github.com:metabase/metabase.git","clone_url":"https://github.com/metabase/metabase.git","svn_url":"https://github.com/metabase/metabase","homepage":"http://metabase.com","size":35420,"stargazers_count":2480,"watchers_count":2480,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":133,"mirror_url":null,"open_issues_count":303,"forks":133,"open_issues":303,"watchers":2480,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metabase/metabase/pulls/2353"},"html":{"href":"https://github.com/metabase/metabase/pull/2353"},"issue":{"href":"https://api.github.com/repos/metabase/metabase/issues/2353"},"comments":{"href":"https://api.github.com/repos/metabase/metabase/issues/2353/comments"},"review_comments":{"href":"https://api.github.com/repos/metabase/metabase/pulls/2353/comments"},"review_comment":{"href":"https://api.github.com/repos/metabase/metabase/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metabase/metabase/pulls/2353/commits"},"statuses":{"href":"https://api.github.com/repos/metabase/metabase/statuses/7fef2d3ca1cb456c461624416c9136f91c6a747e"}}}}