{"action":"created","issue":{"url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/issues/1679","repository_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition","labels_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/issues/1679/labels{/name}","comments_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/issues/1679/comments","events_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/issues/1679/events","html_url":"https://github.com/jsk-ros-pkg/jsk_recognition/pull/1679","id":155923511,"number":1679,"title":"[jsk_pcl_ros] add approximate_sync parameter to depth_error.launch ","user":{"login":"kochigami","id":7259671,"avatar_url":"https://avatars.githubusercontent.com/u/7259671?v=3","gravatar_id":"","url":"https://api.github.com/users/kochigami","html_url":"https://github.com/kochigami","followers_url":"https://api.github.com/users/kochigami/followers","following_url":"https://api.github.com/users/kochigami/following{/other_user}","gists_url":"https://api.github.com/users/kochigami/gists{/gist_id}","starred_url":"https://api.github.com/users/kochigami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kochigami/subscriptions","organizations_url":"https://api.github.com/users/kochigami/orgs","repos_url":"https://api.github.com/users/kochigami/repos","events_url":"https://api.github.com/users/kochigami/events{/privacy}","received_events_url":"https://api.github.com/users/kochigami/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/labels/pkg/jsk_pcl_ros","name":"pkg/jsk_pcl_ros","color":"1d76db"},{"url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/labels/PR/DoNotMergeYet","name":"PR/DoNotMergeYet","color":"e99695"}],"state":"closed","locked":false,"assignee":{"login":"kochigami","id":7259671,"avatar_url":"https://avatars.githubusercontent.com/u/7259671?v=3","gravatar_id":"","url":"https://api.github.com/users/kochigami","html_url":"https://github.com/kochigami","followers_url":"https://api.github.com/users/kochigami/followers","following_url":"https://api.github.com/users/kochigami/following{/other_user}","gists_url":"https://api.github.com/users/kochigami/gists{/gist_id}","starred_url":"https://api.github.com/users/kochigami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kochigami/subscriptions","organizations_url":"https://api.github.com/users/kochigami/orgs","repos_url":"https://api.github.com/users/kochigami/repos","events_url":"https://api.github.com/users/kochigami/events{/privacy}","received_events_url":"https://api.github.com/users/kochigami/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-05-20T09:34:31Z","updated_at":"2016-06-03T03:11:02Z","closed_at":"2016-06-03T03:11:02Z","pull_request":{"url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/pulls/1679","html_url":"https://github.com/jsk-ros-pkg/jsk_recognition/pull/1679","diff_url":"https://github.com/jsk-ros-pkg/jsk_recognition/pull/1679.diff","patch_url":"https://github.com/jsk-ros-pkg/jsk_recognition/pull/1679.patch"},"body":"If I set approximate_sync parameter to true, ```/depth_error_image/output``` is published.\r\nI tried it with xtion pro (ID 1d27:0601 ASUS), ubuntu 14.04, ros indigo.\r\nI followed [this tutorial](https://jsk-recognition.readthedocs.io/en/latest/jsk_pcl_ros/calibration.html) to try this program .\r\n\r\nI don't know whether setting parameter on roslaunch is better or adding information on doc is better.\r\nIf there is any problem, please let me know."},"comment":{"url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/issues/comments/223480562","html_url":"https://github.com/jsk-ros-pkg/jsk_recognition/pull/1679#issuecomment-223480562","issue_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/issues/1679","id":223480562,"user":{"login":"kochigami","id":7259671,"avatar_url":"https://avatars.githubusercontent.com/u/7259671?v=3","gravatar_id":"","url":"https://api.github.com/users/kochigami","html_url":"https://github.com/kochigami","followers_url":"https://api.github.com/users/kochigami/followers","following_url":"https://api.github.com/users/kochigami/following{/other_user}","gists_url":"https://api.github.com/users/kochigami/gists{/gist_id}","starred_url":"https://api.github.com/users/kochigami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kochigami/subscriptions","organizations_url":"https://api.github.com/users/kochigami/orgs","repos_url":"https://api.github.com/users/kochigami/repos","events_url":"https://api.github.com/users/kochigami/events{/privacy}","received_events_url":"https://api.github.com/users/kochigami/received_events","type":"User","site_admin":false},"created_at":"2016-06-03T03:11:02Z","updated_at":"2016-06-03T03:11:02Z","body":"Sorry for my late response, but I confirmed that setting ```approcimate_sync``` to true has an effect.\r\nI added it like this:\r\n```\r\n    <rosparam>\r\n      approximate_sync: true\r\n    </rosparam>\r\n```\r\n\r\n- set ```approximate_sync``` to false ,or writing nothing about ```approximate_sync``` to depth_error.launch:\r\n\r\n```rosrun jsk_pcl_ros depth_error_calibration.py --model quadratic-uv-quadratic-abs``` returned only the background image of graph and did nothing\r\n```rosrun image_view image_view image:=/depth_error_logistic_regression/frequency_image``` shows nothing\r\n\r\n- set ```approximate_sync```  to true:\r\n\r\n```rosrun jsk_pcl_ros depth_error_calibration.py --model quadratic-uv-quadratic-abs``` returns plot graph according to checkerboard detector input\r\n```rosrun image_view image_view image:=/depth_error_logistic_regression/frequency_image``` returns plot graph\r\n\r\nHowever, I don't know whether this situation is compatible for another PC.\r\nI'll close this pull request and add information to tutorial.   "}}
{"actor":{"display_login":"kochigami"}}