{"action":"created","comment":{"url":"https://api.github.com/repos/babel/babel/pulls/comments/70923665","id":70923665,"diff_hunk":"@@ -47,17 +47,17 @@ export default class Buffer {\n \n   append(str: string): void {\n     this._flush();\n-    this._append(str, this._sourcePosition.line, this._sourcePosition.column,\n-      this._sourcePosition.filename);\n+    const { line, column, filename } = this._sourcePosition;","path":"packages/babel-generator/src/buffer.js","position":24,"original_position":24,"commit_id":"a70755d0e6d99476d3e1024d7f2a986682fa09dc","original_commit_id":"a70755d0e6d99476d3e1024d7f2a986682fa09dc","user":{"login":"loganfsmyth","id":132260,"avatar_url":"https://avatars.githubusercontent.com/u/132260?v=3","gravatar_id":"","url":"https://api.github.com/users/loganfsmyth","html_url":"https://github.com/loganfsmyth","followers_url":"https://api.github.com/users/loganfsmyth/followers","following_url":"https://api.github.com/users/loganfsmyth/following{/other_user}","gists_url":"https://api.github.com/users/loganfsmyth/gists{/gist_id}","starred_url":"https://api.github.com/users/loganfsmyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loganfsmyth/subscriptions","organizations_url":"https://api.github.com/users/loganfsmyth/orgs","repos_url":"https://api.github.com/users/loganfsmyth/repos","events_url":"https://api.github.com/users/loganfsmyth/events{/privacy}","received_events_url":"https://api.github.com/users/loganfsmyth/received_events","type":"User","site_admin":false},"body":"Good call, I was probably overly worried about perf when I skipped the temp variables.","created_at":"2016-07-15T05:33:58Z","updated_at":"2016-07-15T05:33:58Z","html_url":"https://github.com/babel/babel/pull/3580#discussion_r70923665","pull_request_url":"https://api.github.com/repos/babel/babel/pulls/3580","_links":{"self":{"href":"https://api.github.com/repos/babel/babel/pulls/comments/70923665"},"html":{"href":"https://github.com/babel/babel/pull/3580#discussion_r70923665"},"pull_request":{"href":"https://api.github.com/repos/babel/babel/pulls/3580"}}},"pull_request":{"url":"https://api.github.com/repos/babel/babel/pulls/3580","id":77565431,"html_url":"https://github.com/babel/babel/pull/3580","diff_url":"https://github.com/babel/babel/pull/3580.diff","patch_url":"https://github.com/babel/babel/pull/3580.patch","issue_url":"https://api.github.com/repos/babel/babel/issues/3580","number":3580,"state":"open","locked":false,"title":"Further optimize babel-generator Buffer","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"body":"We can eek out a bit more speed from Babel generator by turning the buffer into an array as well.\r\nRe: #3565\r\n\r\n```\r\nItems: 2 , time: 4 length: 114\r\nItems: 4 , time: 3 length: 218\r\nItems: 8 , time: 3 length: 426\r\nItems: 16 , time: 2 length: 861\r\nItems: 32 , time: 5 length: 1741\r\nItems: 64 , time: 2 length: 3501\r\nItems: 128 , time: 4 length: 7106\r\nItems: 256 , time: 8 length: 14530\r\nItems: 512 , time: 12 length: 29378\r\nItems: 1024 , time: 24 length: 59147\r\nItems: 2048 , time: 38 length: 121611\r\nItems: 4096 , time: 71 length: 246539\r\nItems: 8192 , time: 131 length: 496395\r\nItems: 16384 , time: 350 length: 1015260\r\nItems: 32768 , time: 573 length: 2063836\r\nItems: 65536 , time: 1263 length: 4160988\r\nItems: 131072 , time: 2143 length: 8448509\r\nItems: 262144 , time: 4859 length: 17230333\r\n```\r\n\r\nto\r\n\r\n```\r\nItems: 2 , time: 4 length: 114\r\nItems: 4 , time: 3 length: 218\r\nItems: 8 , time: 9 length: 426\r\nItems: 16 , time: 1 length: 861\r\nItems: 32 , time: 5 length: 1741\r\nItems: 64 , time: 1 length: 3501\r\nItems: 128 , time: 3 length: 7106\r\nItems: 256 , time: 7 length: 14530\r\nItems: 512 , time: 9 length: 29378\r\nItems: 1024 , time: 17 length: 59147\r\nItems: 2048 , time: 30 length: 121611\r\nItems: 4096 , time: 61 length: 246539\r\nItems: 8192 , time: 113 length: 496395\r\nItems: 16384 , time: 307 length: 1015260\r\nItems: 32768 , time: 443 length: 2063836\r\nItems: 65536 , time: 1065 length: 4160988\r\nItems: 131072 , time: 1799 length: 8448509\r\nItems: 262144 , time: 4217 length: 17230333\r\n```","created_at":"2016-07-15T05:28:43Z","updated_at":"2016-07-15T05:33:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"013eb9721472ca5893eb8c988e9a2099806ac3e1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/babel/babel/pulls/3580/commits","review_comments_url":"https://api.github.com/repos/babel/babel/pulls/3580/comments","review_comment_url":"https://api.github.com/repos/babel/babel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/babel/babel/issues/3580/comments","statuses_url":"https://api.github.com/repos/babel/babel/statuses/a70755d0e6d99476d3e1024d7f2a986682fa09dc","head":{"label":"jridgewell:babel-generator","ref":"babel-generator","sha":"a70755d0e6d99476d3e1024d7f2a986682fa09dc","user":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"repo":{"id":43450298,"name":"babel","full_name":"jridgewell/babel","owner":{"login":"jridgewell","id":112982,"avatar_url":"https://avatars.githubusercontent.com/u/112982?v=3","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jridgewell/babel","description":"Babel is a compiler for writing next generation JavaScript.","fork":true,"url":"https://api.github.com/repos/jridgewell/babel","forks_url":"https://api.github.com/repos/jridgewell/babel/forks","keys_url":"https://api.github.com/repos/jridgewell/babel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jridgewell/babel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jridgewell/babel/teams","hooks_url":"https://api.github.com/repos/jridgewell/babel/hooks","issue_events_url":"https://api.github.com/repos/jridgewell/babel/issues/events{/number}","events_url":"https://api.github.com/repos/jridgewell/babel/events","assignees_url":"https://api.github.com/repos/jridgewell/babel/assignees{/user}","branches_url":"https://api.github.com/repos/jridgewell/babel/branches{/branch}","tags_url":"https://api.github.com/repos/jridgewell/babel/tags","blobs_url":"https://api.github.com/repos/jridgewell/babel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jridgewell/babel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jridgewell/babel/git/refs{/sha}","trees_url":"https://api.github.com/repos/jridgewell/babel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jridgewell/babel/statuses/{sha}","languages_url":"https://api.github.com/repos/jridgewell/babel/languages","stargazers_url":"https://api.github.com/repos/jridgewell/babel/stargazers","contributors_url":"https://api.github.com/repos/jridgewell/babel/contributors","subscribers_url":"https://api.github.com/repos/jridgewell/babel/subscribers","subscription_url":"https://api.github.com/repos/jridgewell/babel/subscription","commits_url":"https://api.github.com/repos/jridgewell/babel/commits{/sha}","git_commits_url":"https://api.github.com/repos/jridgewell/babel/git/commits{/sha}","comments_url":"https://api.github.com/repos/jridgewell/babel/comments{/number}","issue_comment_url":"https://api.github.com/repos/jridgewell/babel/issues/comments{/number}","contents_url":"https://api.github.com/repos/jridgewell/babel/contents/{+path}","compare_url":"https://api.github.com/repos/jridgewell/babel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jridgewell/babel/merges","archive_url":"https://api.github.com/repos/jridgewell/babel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jridgewell/babel/downloads","issues_url":"https://api.github.com/repos/jridgewell/babel/issues{/number}","pulls_url":"https://api.github.com/repos/jridgewell/babel/pulls{/number}","milestones_url":"https://api.github.com/repos/jridgewell/babel/milestones{/number}","notifications_url":"https://api.github.com/repos/jridgewell/babel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jridgewell/babel/labels{/name}","releases_url":"https://api.github.com/repos/jridgewell/babel/releases{/id}","deployments_url":"https://api.github.com/repos/jridgewell/babel/deployments","created_at":"2015-09-30T18:12:49Z","updated_at":"2016-06-10T01:59:24Z","pushed_at":"2016-07-15T05:28:07Z","git_url":"git://github.com/jridgewell/babel.git","ssh_url":"git@github.com:jridgewell/babel.git","clone_url":"https://github.com/jridgewell/babel.git","svn_url":"https://github.com/jridgewell/babel","homepage":"https://babeljs.io/","size":14162,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"babel:master","ref":"master","sha":"3073c63e5890d3e28b2d2d86d1707d200ba8d9e8","user":{"login":"babel","id":9637642,"avatar_url":"https://avatars.githubusercontent.com/u/9637642?v=3","gravatar_id":"","url":"https://api.github.com/users/babel","html_url":"https://github.com/babel","followers_url":"https://api.github.com/users/babel/followers","following_url":"https://api.github.com/users/babel/following{/other_user}","gists_url":"https://api.github.com/users/babel/gists{/gist_id}","starred_url":"https://api.github.com/users/babel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babel/subscriptions","organizations_url":"https://api.github.com/users/babel/orgs","repos_url":"https://api.github.com/users/babel/repos","events_url":"https://api.github.com/users/babel/events{/privacy}","received_events_url":"https://api.github.com/users/babel/received_events","type":"Organization","site_admin":false},"repo":{"id":24560307,"name":"babel","full_name":"babel/babel","owner":{"login":"babel","id":9637642,"avatar_url":"https://avatars.githubusercontent.com/u/9637642?v=3","gravatar_id":"","url":"https://api.github.com/users/babel","html_url":"https://github.com/babel","followers_url":"https://api.github.com/users/babel/followers","following_url":"https://api.github.com/users/babel/following{/other_user}","gists_url":"https://api.github.com/users/babel/gists{/gist_id}","starred_url":"https://api.github.com/users/babel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babel/subscriptions","organizations_url":"https://api.github.com/users/babel/orgs","repos_url":"https://api.github.com/users/babel/repos","events_url":"https://api.github.com/users/babel/events{/privacy}","received_events_url":"https://api.github.com/users/babel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/babel/babel","description":":tropical_fish: Babel is a compiler for writing next generation JavaScript.","fork":false,"url":"https://api.github.com/repos/babel/babel","forks_url":"https://api.github.com/repos/babel/babel/forks","keys_url":"https://api.github.com/repos/babel/babel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/babel/babel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/babel/babel/teams","hooks_url":"https://api.github.com/repos/babel/babel/hooks","issue_events_url":"https://api.github.com/repos/babel/babel/issues/events{/number}","events_url":"https://api.github.com/repos/babel/babel/events","assignees_url":"https://api.github.com/repos/babel/babel/assignees{/user}","branches_url":"https://api.github.com/repos/babel/babel/branches{/branch}","tags_url":"https://api.github.com/repos/babel/babel/tags","blobs_url":"https://api.github.com/repos/babel/babel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/babel/babel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/babel/babel/git/refs{/sha}","trees_url":"https://api.github.com/repos/babel/babel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/babel/babel/statuses/{sha}","languages_url":"https://api.github.com/repos/babel/babel/languages","stargazers_url":"https://api.github.com/repos/babel/babel/stargazers","contributors_url":"https://api.github.com/repos/babel/babel/contributors","subscribers_url":"https://api.github.com/repos/babel/babel/subscribers","subscription_url":"https://api.github.com/repos/babel/babel/subscription","commits_url":"https://api.github.com/repos/babel/babel/commits{/sha}","git_commits_url":"https://api.github.com/repos/babel/babel/git/commits{/sha}","comments_url":"https://api.github.com/repos/babel/babel/comments{/number}","issue_comment_url":"https://api.github.com/repos/babel/babel/issues/comments{/number}","contents_url":"https://api.github.com/repos/babel/babel/contents/{+path}","compare_url":"https://api.github.com/repos/babel/babel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/babel/babel/merges","archive_url":"https://api.github.com/repos/babel/babel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/babel/babel/downloads","issues_url":"https://api.github.com/repos/babel/babel/issues{/number}","pulls_url":"https://api.github.com/repos/babel/babel/pulls{/number}","milestones_url":"https://api.github.com/repos/babel/babel/milestones{/number}","notifications_url":"https://api.github.com/repos/babel/babel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/babel/babel/labels{/name}","releases_url":"https://api.github.com/repos/babel/babel/releases{/id}","deployments_url":"https://api.github.com/repos/babel/babel/deployments","created_at":"2014-09-28T13:38:23Z","updated_at":"2016-07-15T02:19:07Z","pushed_at":"2016-07-15T05:30:28Z","git_url":"git://github.com/babel/babel.git","ssh_url":"git@github.com:babel/babel.git","clone_url":"https://github.com/babel/babel.git","svn_url":"https://github.com/babel/babel","homepage":"https://babeljs.io/","size":19023,"stargazers_count":16551,"watchers_count":16551,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1211,"mirror_url":null,"open_issues_count":226,"forks":1211,"open_issues":226,"watchers":16551,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/babel/babel/pulls/3580"},"html":{"href":"https://github.com/babel/babel/pull/3580"},"issue":{"href":"https://api.github.com/repos/babel/babel/issues/3580"},"comments":{"href":"https://api.github.com/repos/babel/babel/issues/3580/comments"},"review_comments":{"href":"https://api.github.com/repos/babel/babel/pulls/3580/comments"},"review_comment":{"href":"https://api.github.com/repos/babel/babel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/babel/babel/pulls/3580/commits"},"statuses":{"href":"https://api.github.com/repos/babel/babel/statuses/a70755d0e6d99476d3e1024d7f2a986682fa09dc"}}}}
{"actor":{"display_login":"loganfsmyth"}}