{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments/53700124","id":53700124,"diff_hunk":"@@ -325,101 +354,226 @@ INSTANTIATE_TEST_CASE_P(ExecutionMode, ValidateCapability,\n                         Combine(\n                             ValuesIn(AllCapabilities()),\n                             Values(\n-make_pair(\"OpExecutionMode %func Invocations 42\",          GeometryDependencies()),\n-make_pair(\"OpExecutionMode %func SpacingEqual\",            TessellationDependencies()),\n-make_pair(\"OpExecutionMode %func SpacingFractionalEven\",   TessellationDependencies()),\n-make_pair(\"OpExecutionMode %func SpacingFractionalOdd\",    TessellationDependencies()),\n-make_pair(\"OpExecutionMode %func VertexOrderCw\",           TessellationDependencies()),\n-make_pair(\"OpExecutionMode %func VertexOrderCcw\",          TessellationDependencies()),\n-make_pair(\"OpExecutionMode %func PixelCenterInteger\",      ShaderDependencies()),\n-make_pair(\"OpExecutionMode %func OriginUpperLeft\",         ShaderDependencies()),\n-make_pair(\"OpExecutionMode %func OriginLowerLeft\",         ShaderDependencies()),\n-make_pair(\"OpExecutionMode %func EarlyFragmentTests\",      ShaderDependencies()),\n-make_pair(\"OpExecutionMode %func PointMode\",               TessellationDependencies()),\n-make_pair(\"OpExecutionMode %func Xfb\",                     vector<string>{\"TransformFeedback\"}),\n-make_pair(\"OpExecutionMode %func DepthReplacing\",          ShaderDependencies()),\n-make_pair(\"OpExecutionMode %func DepthGreater\",            ShaderDependencies()),\n-make_pair(\"OpExecutionMode %func DepthLess\",               ShaderDependencies()),\n-make_pair(\"OpExecutionMode %func DepthUnchanged\",          ShaderDependencies()),\n-make_pair(\"OpExecutionMode %func LocalSize 42 42 42\",      AllCapabilities()),\n-make_pair(\"OpExecutionMode %func LocalSizeHint 42 42 42\",  KernelDependencies()),\n-make_pair(\"OpExecutionMode %func InputPoints\",             GeometryDependencies()),\n-make_pair(\"OpExecutionMode %func InputLines\",              GeometryDependencies()),\n-make_pair(\"OpExecutionMode %func InputLinesAdjacency\",     GeometryDependencies()),\n-make_pair(\"OpExecutionMode %func Triangles\",               GeometryTessellationDependencies()),\n-make_pair(\"OpExecutionMode %func InputTrianglesAdjacency\", GeometryDependencies()),\n-make_pair(\"OpExecutionMode %func Quads\",                   TessellationDependencies()),\n-make_pair(\"OpExecutionMode %func Isolines\",                TessellationDependencies()),\n-make_pair(\"OpExecutionMode %func OutputVertices 42\",       GeometryTessellationDependencies()),\n-make_pair(\"OpExecutionMode %func OutputPoints\",            GeometryDependencies()),\n-make_pair(\"OpExecutionMode %func OutputLineStrip\",         GeometryDependencies()),\n-make_pair(\"OpExecutionMode %func OutputTriangleStrip\",     GeometryDependencies()),\n-make_pair(\"OpExecutionMode %func VecTypeHint 2\",           KernelDependencies()),\n-make_pair(\"OpExecutionMode %func ContractionOff\",          KernelDependencies())\n+make_pair(string(kOpenCLMemoryModel) +","path":"test/Validate.Capability.cpp","position":102,"original_position":102,"commit_id":"c6de23368efdec272526970f347e53667e37b5f9","original_commit_id":"c6de23368efdec272526970f347e53667e37b5f9","user":{"login":"dneto0","id":13054574,"avatar_url":"https://avatars.githubusercontent.com/u/13054574?v=3","gravatar_id":"","url":"https://api.github.com/users/dneto0","html_url":"https://github.com/dneto0","followers_url":"https://api.github.com/users/dneto0/followers","following_url":"https://api.github.com/users/dneto0/following{/other_user}","gists_url":"https://api.github.com/users/dneto0/gists{/gist_id}","starred_url":"https://api.github.com/users/dneto0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneto0/subscriptions","organizations_url":"https://api.github.com/users/dneto0/orgs","repos_url":"https://api.github.com/users/dneto0/repos","events_url":"https://api.github.com/users/dneto0/events{/privacy}","received_events_url":"https://api.github.com/users/dneto0/received_events","type":"User","site_admin":false},"body":"Similarly here.","created_at":"2016-02-22T21:57:58Z","updated_at":"2016-02-22T21:57:58Z","html_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/128#discussion_r53700124","pull_request_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments/53700124"},"html":{"href":"https://github.com/KhronosGroup/SPIRV-Tools/pull/128#discussion_r53700124"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/128","id":60235907,"html_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/128","diff_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/128.diff","patch_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/128.patch","issue_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/128","number":128,"state":"open","locked":false,"title":"Remove spv_validate_options_t and change tests accrodingly.","user":{"login":"antiagainst","id":487928,"avatar_url":"https://avatars.githubusercontent.com/u/487928?v=3","gravatar_id":"","url":"https://api.github.com/users/antiagainst","html_url":"https://github.com/antiagainst","followers_url":"https://api.github.com/users/antiagainst/followers","following_url":"https://api.github.com/users/antiagainst/following{/other_user}","gists_url":"https://api.github.com/users/antiagainst/gists{/gist_id}","starred_url":"https://api.github.com/users/antiagainst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiagainst/subscriptions","organizations_url":"https://api.github.com/users/antiagainst/orgs","repos_url":"https://api.github.com/users/antiagainst/repos","events_url":"https://api.github.com/users/antiagainst/events{/privacy}","received_events_url":"https://api.github.com/users/antiagainst/received_events","type":"User","site_admin":false},"body":"Users always want to run all the checks. The `spv_validate_options_t`\r\nmechanism, which provides little benefits to users, complicates the\r\ninternal implementation and also makes the tests exercise different\r\npaths as users do.\r\n\r\nRight now the tests are more like integration tests instead of\r\nunit tests, which should be our next refactoring aim.\r\n\r\nAddresses #89.","created_at":"2016-02-22T20:33:20Z","updated_at":"2016-02-22T21:57:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a71e374c53cad1f5286e4d496aaabff4c5fdc964","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/128/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/128/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/128/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/c6de23368efdec272526970f347e53667e37b5f9","head":{"label":"antiagainst:validate","ref":"validate","sha":"c6de23368efdec272526970f347e53667e37b5f9","user":{"login":"antiagainst","id":487928,"avatar_url":"https://avatars.githubusercontent.com/u/487928?v=3","gravatar_id":"","url":"https://api.github.com/users/antiagainst","html_url":"https://github.com/antiagainst","followers_url":"https://api.github.com/users/antiagainst/followers","following_url":"https://api.github.com/users/antiagainst/following{/other_user}","gists_url":"https://api.github.com/users/antiagainst/gists{/gist_id}","starred_url":"https://api.github.com/users/antiagainst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiagainst/subscriptions","organizations_url":"https://api.github.com/users/antiagainst/orgs","repos_url":"https://api.github.com/users/antiagainst/repos","events_url":"https://api.github.com/users/antiagainst/events{/privacy}","received_events_url":"https://api.github.com/users/antiagainst/received_events","type":"User","site_admin":false},"repo":{"id":46284705,"name":"SPIRV-Tools","full_name":"antiagainst/SPIRV-Tools","owner":{"login":"antiagainst","id":487928,"avatar_url":"https://avatars.githubusercontent.com/u/487928?v=3","gravatar_id":"","url":"https://api.github.com/users/antiagainst","html_url":"https://github.com/antiagainst","followers_url":"https://api.github.com/users/antiagainst/followers","following_url":"https://api.github.com/users/antiagainst/following{/other_user}","gists_url":"https://api.github.com/users/antiagainst/gists{/gist_id}","starred_url":"https://api.github.com/users/antiagainst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiagainst/subscriptions","organizations_url":"https://api.github.com/users/antiagainst/orgs","repos_url":"https://api.github.com/users/antiagainst/repos","events_url":"https://api.github.com/users/antiagainst/events{/privacy}","received_events_url":"https://api.github.com/users/antiagainst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antiagainst/SPIRV-Tools","description":"","fork":true,"url":"https://api.github.com/repos/antiagainst/SPIRV-Tools","forks_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/forks","keys_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/teams","hooks_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/hooks","issue_events_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/issues/events{/number}","events_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/events","assignees_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/assignees{/user}","branches_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/branches{/branch}","tags_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/tags","blobs_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/statuses/{sha}","languages_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/languages","stargazers_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/stargazers","contributors_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/contributors","subscribers_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/subscribers","subscription_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/subscription","commits_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/contents/{+path}","compare_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/merges","archive_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/downloads","issues_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/issues{/number}","pulls_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/pulls{/number}","milestones_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/milestones{/number}","notifications_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/labels{/name}","releases_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/releases{/id}","deployments_url":"https://api.github.com/repos/antiagainst/SPIRV-Tools/deployments","created_at":"2015-11-16T15:47:34Z","updated_at":"2016-01-26T23:12:38Z","pushed_at":"2016-02-22T20:33:01Z","git_url":"git://github.com/antiagainst/SPIRV-Tools.git","ssh_url":"git@github.com:antiagainst/SPIRV-Tools.git","clone_url":"https://github.com/antiagainst/SPIRV-Tools.git","svn_url":"https://github.com/antiagainst/SPIRV-Tools","homepage":null,"size":1243,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"c9783ded752c86ae431ece1eef687d4ae45d8a1d","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":45981801,"name":"SPIRV-Tools","full_name":"KhronosGroup/SPIRV-Tools","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/SPIRV-Tools","description":"","fork":false,"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools","forks_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/forks","keys_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/events","assignees_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/merges","archive_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/deployments","created_at":"2015-11-11T12:56:25Z","updated_at":"2016-02-22T14:35:37Z","pushed_at":"2016-02-22T21:57:57Z","git_url":"git://github.com/KhronosGroup/SPIRV-Tools.git","ssh_url":"git@github.com:KhronosGroup/SPIRV-Tools.git","clone_url":"https://github.com/KhronosGroup/SPIRV-Tools.git","svn_url":"https://github.com/KhronosGroup/SPIRV-Tools","homepage":null,"size":1342,"stargazers_count":96,"watchers_count":96,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":11,"forks":16,"open_issues":11,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/128"},"html":{"href":"https://github.com/KhronosGroup/SPIRV-Tools/pull/128"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/128"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/c6de23368efdec272526970f347e53667e37b5f9"}}}}