{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/52991243","id":52991243,"diff_hunk":"@@ -403,6 +403,7 @@ def make_zone(zone)\n   command \"nscd -i hosts\"\n   action :nothing\n   subscribes :run, \"template[/etc/bind/db.#{node[:dns][:domain]}]\"\n+  only_if { File.exist?(\"/var/run/nscd/nscd.pid\") }","path":"chef/cookbooks/bind9/recipes/default.rb","position":4,"original_position":4,"commit_id":"2739fd489fdf23e90ee7e7d6fdbf34f7cede8c4f","original_commit_id":"2739fd489fdf23e90ee7e7d6fdbf34f7cede8c4f","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"body":"Are we sure that path is correct for all systems? Or would `only_if \"which nscd > /dev/null\"` be better?","created_at":"2016-02-16T10:16:24Z","updated_at":"2016-02-16T10:16:24Z","html_url":"https://github.com/crowbar/crowbar-core/pull/346#discussion_r52991243","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/346","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/52991243"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/346#discussion_r52991243"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/346"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/346","id":59466898,"html_url":"https://github.com/crowbar/crowbar-core/pull/346","diff_url":"https://github.com/crowbar/crowbar-core/pull/346.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/346.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/346","number":346,"state":"open","locked":false,"title":"dont require nscd","user":{"login":"bmwiedemann","id":637990,"avatar_url":"https://avatars.githubusercontent.com/u/637990?v=3","gravatar_id":"","url":"https://api.github.com/users/bmwiedemann","html_url":"https://github.com/bmwiedemann","followers_url":"https://api.github.com/users/bmwiedemann/followers","following_url":"https://api.github.com/users/bmwiedemann/following{/other_user}","gists_url":"https://api.github.com/users/bmwiedemann/gists{/gist_id}","starred_url":"https://api.github.com/users/bmwiedemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmwiedemann/subscriptions","organizations_url":"https://api.github.com/users/bmwiedemann/orgs","repos_url":"https://api.github.com/users/bmwiedemann/repos","events_url":"https://api.github.com/users/bmwiedemann/events{/privacy}","received_events_url":"https://api.github.com/users/bmwiedemann/received_events","type":"User","site_admin":false},"body":"install-suse-cloud was failing\r\nwhen nscd was not installed or not running.\r\nAnd since there is nothing needing it,\r\nwe make this part optional\r\n\r\nnote: also affects Cloud5, so needs backport.","created_at":"2016-02-16T09:58:48Z","updated_at":"2016-02-16T10:16:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"113a69ab6434c89fceb3027f153c2194fc8af603","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/346/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/346/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/346/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/2739fd489fdf23e90ee7e7d6fdbf34f7cede8c4f","head":{"label":"SUSE-Cloud:nscd","ref":"nscd","sha":"2739fd489fdf23e90ee7e7d6fdbf34f7cede8c4f","user":{"login":"SUSE-Cloud","id":1553906,"avatar_url":"https://avatars.githubusercontent.com/u/1553906?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE-Cloud","html_url":"https://github.com/SUSE-Cloud","followers_url":"https://api.github.com/users/SUSE-Cloud/followers","following_url":"https://api.github.com/users/SUSE-Cloud/following{/other_user}","gists_url":"https://api.github.com/users/SUSE-Cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE-Cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE-Cloud/subscriptions","organizations_url":"https://api.github.com/users/SUSE-Cloud/orgs","repos_url":"https://api.github.com/users/SUSE-Cloud/repos","events_url":"https://api.github.com/users/SUSE-Cloud/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE-Cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":40903364,"name":"crowbar-core","full_name":"SUSE-Cloud/crowbar-core","owner":{"login":"SUSE-Cloud","id":1553906,"avatar_url":"https://avatars.githubusercontent.com/u/1553906?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE-Cloud","html_url":"https://github.com/SUSE-Cloud","followers_url":"https://api.github.com/users/SUSE-Cloud/followers","following_url":"https://api.github.com/users/SUSE-Cloud/following{/other_user}","gists_url":"https://api.github.com/users/SUSE-Cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE-Cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE-Cloud/subscriptions","organizations_url":"https://api.github.com/users/SUSE-Cloud/orgs","repos_url":"https://api.github.com/users/SUSE-Cloud/repos","events_url":"https://api.github.com/users/SUSE-Cloud/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE-Cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE-Cloud/crowbar-core","description":"Core deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core","forks_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/forks","keys_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/teams","hooks_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/events","assignees_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/tags","blobs_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/subscription","commits_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/merges","archive_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/downloads","issues_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE-Cloud/crowbar-core/deployments","created_at":"2015-08-17T14:54:48Z","updated_at":"2016-01-15T09:17:52Z","pushed_at":"2016-02-16T09:58:41Z","git_url":"git://github.com/SUSE-Cloud/crowbar-core.git","ssh_url":"git@github.com:SUSE-Cloud/crowbar-core.git","clone_url":"https://github.com/SUSE-Cloud/crowbar-core.git","svn_url":"https://github.com/SUSE-Cloud/crowbar-core","homepage":null,"size":104743,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"ada1d096c156d2f1435461e650f0913fcf47c462","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39003227,"name":"crowbar-core","full_name":"crowbar/crowbar-core","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-core","description":"Core deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-core","forks_url":"https://api.github.com/repos/crowbar/crowbar-core/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-core/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-core/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-core/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-core/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-core/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-core/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-core/deployments","created_at":"2015-07-13T09:31:28Z","updated_at":"2016-01-12T12:38:58Z","pushed_at":"2016-02-16T10:13:51Z","git_url":"git://github.com/crowbar/crowbar-core.git","ssh_url":"git@github.com:crowbar/crowbar-core.git","clone_url":"https://github.com/crowbar/crowbar-core.git","svn_url":"https://github.com/crowbar/crowbar-core","homepage":null,"size":119581,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":30,"forks":23,"open_issues":30,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/346"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/346"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/346"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/346/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/346/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/346/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-core/statuses/2739fd489fdf23e90ee7e7d6fdbf34f7cede8c4f"}}}}