{"action":"created","comment":{"url":"https://api.github.com/repos/WebAssembly/waterfall/pulls/comments/81394778","pull_request_review_id":2379858,"id":81394778,"diff_hunk":"@@ -202,33 +202,44 @@ def execute(tester, inputs, fails):\n   sys.stdout.write('\\nResults:\\n')\n   for result in results:\n     sys.stdout.write(str(result) + '\\n\\n')\n+\n   cutoff = 0.9\n-  similar_expected_failures = similarity(expected_failures, cutoff)\n-  for s in similar_expected_failures:\n-    tests = ' '.join(s.tests)\n-    if s.average >= cutoff * 100.:\n-      sys.stdout.write(('\\nSimilar expected failures, '\n-                        'average %s%% similarity with stddev %s: '\n-                        '%s\\n') % (s.average, s.stddev, tests))\n-      sample = [f for f in expected_failures if f.test == s.tests[0]][0]\n-      sys.stdout.write('Sample failure: %s\\n' % sample)\n-    else:\n-      sys.stdout.write(('\\nUngrouped expected failures, '\n-                        'average %s%% similarity with stddev %s: '\n-                        '%s\\n') % (s.average, s.stddev, tests))\n-  similar_unexpected_failures = similarity(unexpected_failures, cutoff)\n-  for s in similar_unexpected_failures:\n-    tests = ' '.join(s.tests)\n-    if s.average >= cutoff * 100.:\n-      sys.stdout.write(('\\nSimilar unexpected failures, '\n-                        'average %s%% similarity with stddev %s: '\n-                        '%s\\n') % (s.average, s.stddev, tests))\n-      sample = [f for f in unexpected_failures if f.test == s.tests[0]][0]\n-      sys.stdout.write('Sample failure: %s\\n' % sample)\n-    else:\n-      sys.stdout.write(('\\nUngrouped unexpected failures, '\n-                        'average %s%% similarity with stddev %s: '\n-                        '%s\\n') % (s.average, s.stddev, tests))\n+  # Calculating similarity is pretty expensive. If more than half the tests are\n+  # failing, it can take minutes, and most of them are probably failing for the\n+  # same fundamental reason. Skip in that case.\n+  too_many_failures = int(len(inputs) * 0.5)","path":"src/testing.py","position":35,"original_position":35,"commit_id":"47c68277907845bcb7e8955105db8f7b4dae9a23","original_commit_id":"47c68277907845bcb7e8955105db8f7b4dae9a23","user":{"login":"dschuff","id":1122856,"avatar_url":"https://avatars.githubusercontent.com/u/1122856?v=3","gravatar_id":"","url":"https://api.github.com/users/dschuff","html_url":"https://github.com/dschuff","followers_url":"https://api.github.com/users/dschuff/followers","following_url":"https://api.github.com/users/dschuff/following{/other_user}","gists_url":"https://api.github.com/users/dschuff/gists{/gist_id}","starred_url":"https://api.github.com/users/dschuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschuff/subscriptions","organizations_url":"https://api.github.com/users/dschuff/orgs","repos_url":"https://api.github.com/users/dschuff/repos","events_url":"https://api.github.com/users/dschuff/events{/privacy}","received_events_url":"https://api.github.com/users/dschuff/received_events","type":"User","site_admin":false},"body":"Re: future division: https://www.python.org/dev/peps/pep-0238","created_at":"2016-09-30T18:37:04Z","updated_at":"2016-09-30T18:37:04Z","html_url":"https://github.com/WebAssembly/waterfall/pull/109#discussion_r81394778","pull_request_url":"https://api.github.com/repos/WebAssembly/waterfall/pulls/109","_links":{"self":{"href":"https://api.github.com/repos/WebAssembly/waterfall/pulls/comments/81394778"},"html":{"href":"https://github.com/WebAssembly/waterfall/pull/109#discussion_r81394778"},"pull_request":{"href":"https://api.github.com/repos/WebAssembly/waterfall/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/WebAssembly/waterfall/pulls/109","id":87406728,"html_url":"https://github.com/WebAssembly/waterfall/pull/109","diff_url":"https://github.com/WebAssembly/waterfall/pull/109.diff","patch_url":"https://github.com/WebAssembly/waterfall/pull/109.patch","issue_url":"https://api.github.com/repos/WebAssembly/waterfall/issues/109","number":109,"state":"closed","locked":false,"title":"Skip similarity testing","user":{"login":"jgravelle-google","id":20847303,"avatar_url":"https://avatars.githubusercontent.com/u/20847303?v=3","gravatar_id":"","url":"https://api.github.com/users/jgravelle-google","html_url":"https://github.com/jgravelle-google","followers_url":"https://api.github.com/users/jgravelle-google/followers","following_url":"https://api.github.com/users/jgravelle-google/following{/other_user}","gists_url":"https://api.github.com/users/jgravelle-google/gists{/gist_id}","starred_url":"https://api.github.com/users/jgravelle-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgravelle-google/subscriptions","organizations_url":"https://api.github.com/users/jgravelle-google/orgs","repos_url":"https://api.github.com/users/jgravelle-google/repos","events_url":"https://api.github.com/users/jgravelle-google/events{/privacy}","received_events_url":"https://api.github.com/users/jgravelle-google/received_events","type":"User","site_admin":false},"body":"When >1,000 tests fail, calculating similarity on them takes ~3minutes on my machine.\r\nIf >50% of tests are failing, they probably have one overarching failure, and any arbitrary test case's output should be sufficient. Either that or we have bigger problems.","created_at":"2016-09-29T22:36:46Z","updated_at":"2016-09-30T18:37:04Z","closed_at":"2016-09-29T22:58:11Z","merged_at":"2016-09-29T22:58:11Z","merge_commit_sha":"012388d13fda9ec6bdedcfec10cecbcb2b71cfc3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/WebAssembly/waterfall/pulls/109/commits","review_comments_url":"https://api.github.com/repos/WebAssembly/waterfall/pulls/109/comments","review_comment_url":"https://api.github.com/repos/WebAssembly/waterfall/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WebAssembly/waterfall/issues/109/comments","statuses_url":"https://api.github.com/repos/WebAssembly/waterfall/statuses/47c68277907845bcb7e8955105db8f7b4dae9a23","head":{"label":"WebAssembly:skip_similarity","ref":"skip_similarity","sha":"47c68277907845bcb7e8955105db8f7b4dae9a23","user":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"repo":{"id":49115003,"name":"waterfall","full_name":"WebAssembly/waterfall","owner":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebAssembly/waterfall","description":"Build and test bots","fork":false,"url":"https://api.github.com/repos/WebAssembly/waterfall","forks_url":"https://api.github.com/repos/WebAssembly/waterfall/forks","keys_url":"https://api.github.com/repos/WebAssembly/waterfall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebAssembly/waterfall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebAssembly/waterfall/teams","hooks_url":"https://api.github.com/repos/WebAssembly/waterfall/hooks","issue_events_url":"https://api.github.com/repos/WebAssembly/waterfall/issues/events{/number}","events_url":"https://api.github.com/repos/WebAssembly/waterfall/events","assignees_url":"https://api.github.com/repos/WebAssembly/waterfall/assignees{/user}","branches_url":"https://api.github.com/repos/WebAssembly/waterfall/branches{/branch}","tags_url":"https://api.github.com/repos/WebAssembly/waterfall/tags","blobs_url":"https://api.github.com/repos/WebAssembly/waterfall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebAssembly/waterfall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebAssembly/waterfall/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebAssembly/waterfall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebAssembly/waterfall/statuses/{sha}","languages_url":"https://api.github.com/repos/WebAssembly/waterfall/languages","stargazers_url":"https://api.github.com/repos/WebAssembly/waterfall/stargazers","contributors_url":"https://api.github.com/repos/WebAssembly/waterfall/contributors","subscribers_url":"https://api.github.com/repos/WebAssembly/waterfall/subscribers","subscription_url":"https://api.github.com/repos/WebAssembly/waterfall/subscription","commits_url":"https://api.github.com/repos/WebAssembly/waterfall/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebAssembly/waterfall/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebAssembly/waterfall/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebAssembly/waterfall/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebAssembly/waterfall/contents/{+path}","compare_url":"https://api.github.com/repos/WebAssembly/waterfall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebAssembly/waterfall/merges","archive_url":"https://api.github.com/repos/WebAssembly/waterfall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebAssembly/waterfall/downloads","issues_url":"https://api.github.com/repos/WebAssembly/waterfall/issues{/number}","pulls_url":"https://api.github.com/repos/WebAssembly/waterfall/pulls{/number}","milestones_url":"https://api.github.com/repos/WebAssembly/waterfall/milestones{/number}","notifications_url":"https://api.github.com/repos/WebAssembly/waterfall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebAssembly/waterfall/labels{/name}","releases_url":"https://api.github.com/repos/WebAssembly/waterfall/releases{/id}","deployments_url":"https://api.github.com/repos/WebAssembly/waterfall/deployments","created_at":"2016-01-06T05:37:09Z","updated_at":"2016-09-23T11:50:37Z","pushed_at":"2016-09-30T17:33:40Z","git_url":"git://github.com/WebAssembly/waterfall.git","ssh_url":"git@github.com:WebAssembly/waterfall.git","clone_url":"https://github.com/WebAssembly/waterfall.git","svn_url":"https://github.com/WebAssembly/waterfall","homepage":null,"size":425,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":8,"default_branch":"master"}},"base":{"label":"WebAssembly:master","ref":"master","sha":"7ca7bb8264b1fd897958892f8a50273bdd7eb122","user":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"repo":{"id":49115003,"name":"waterfall","full_name":"WebAssembly/waterfall","owner":{"login":"WebAssembly","id":11578470,"avatar_url":"https://avatars.githubusercontent.com/u/11578470?v=3","gravatar_id":"","url":"https://api.github.com/users/WebAssembly","html_url":"https://github.com/WebAssembly","followers_url":"https://api.github.com/users/WebAssembly/followers","following_url":"https://api.github.com/users/WebAssembly/following{/other_user}","gists_url":"https://api.github.com/users/WebAssembly/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAssembly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAssembly/subscriptions","organizations_url":"https://api.github.com/users/WebAssembly/orgs","repos_url":"https://api.github.com/users/WebAssembly/repos","events_url":"https://api.github.com/users/WebAssembly/events{/privacy}","received_events_url":"https://api.github.com/users/WebAssembly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebAssembly/waterfall","description":"Build and test bots","fork":false,"url":"https://api.github.com/repos/WebAssembly/waterfall","forks_url":"https://api.github.com/repos/WebAssembly/waterfall/forks","keys_url":"https://api.github.com/repos/WebAssembly/waterfall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebAssembly/waterfall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebAssembly/waterfall/teams","hooks_url":"https://api.github.com/repos/WebAssembly/waterfall/hooks","issue_events_url":"https://api.github.com/repos/WebAssembly/waterfall/issues/events{/number}","events_url":"https://api.github.com/repos/WebAssembly/waterfall/events","assignees_url":"https://api.github.com/repos/WebAssembly/waterfall/assignees{/user}","branches_url":"https://api.github.com/repos/WebAssembly/waterfall/branches{/branch}","tags_url":"https://api.github.com/repos/WebAssembly/waterfall/tags","blobs_url":"https://api.github.com/repos/WebAssembly/waterfall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebAssembly/waterfall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebAssembly/waterfall/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebAssembly/waterfall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebAssembly/waterfall/statuses/{sha}","languages_url":"https://api.github.com/repos/WebAssembly/waterfall/languages","stargazers_url":"https://api.github.com/repos/WebAssembly/waterfall/stargazers","contributors_url":"https://api.github.com/repos/WebAssembly/waterfall/contributors","subscribers_url":"https://api.github.com/repos/WebAssembly/waterfall/subscribers","subscription_url":"https://api.github.com/repos/WebAssembly/waterfall/subscription","commits_url":"https://api.github.com/repos/WebAssembly/waterfall/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebAssembly/waterfall/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebAssembly/waterfall/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebAssembly/waterfall/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebAssembly/waterfall/contents/{+path}","compare_url":"https://api.github.com/repos/WebAssembly/waterfall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebAssembly/waterfall/merges","archive_url":"https://api.github.com/repos/WebAssembly/waterfall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebAssembly/waterfall/downloads","issues_url":"https://api.github.com/repos/WebAssembly/waterfall/issues{/number}","pulls_url":"https://api.github.com/repos/WebAssembly/waterfall/pulls{/number}","milestones_url":"https://api.github.com/repos/WebAssembly/waterfall/milestones{/number}","notifications_url":"https://api.github.com/repos/WebAssembly/waterfall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebAssembly/waterfall/labels{/name}","releases_url":"https://api.github.com/repos/WebAssembly/waterfall/releases{/id}","deployments_url":"https://api.github.com/repos/WebAssembly/waterfall/deployments","created_at":"2016-01-06T05:37:09Z","updated_at":"2016-09-23T11:50:37Z","pushed_at":"2016-09-30T17:33:40Z","git_url":"git://github.com/WebAssembly/waterfall.git","ssh_url":"git@github.com:WebAssembly/waterfall.git","clone_url":"https://github.com/WebAssembly/waterfall.git","svn_url":"https://github.com/WebAssembly/waterfall","homepage":null,"size":425,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WebAssembly/waterfall/pulls/109"},"html":{"href":"https://github.com/WebAssembly/waterfall/pull/109"},"issue":{"href":"https://api.github.com/repos/WebAssembly/waterfall/issues/109"},"comments":{"href":"https://api.github.com/repos/WebAssembly/waterfall/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/WebAssembly/waterfall/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/WebAssembly/waterfall/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WebAssembly/waterfall/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/WebAssembly/waterfall/statuses/47c68277907845bcb7e8955105db8f7b4dae9a23"}}}}
{"actor":{"display_login":"dschuff"}}