{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10765","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10765/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10765/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10765/events","html_url":"https://github.com/cockroachdb/cockroach/pull/10765","id":190099774,"number":10765,"title":"RFC: active draining of nodes","user":{"login":"asubiotto","id":10560359,"avatar_url":"https://avatars.githubusercontent.com/u/10560359?v=3","gravatar_id":"","url":"https://api.github.com/users/asubiotto","html_url":"https://github.com/asubiotto","followers_url":"https://api.github.com/users/asubiotto/followers","following_url":"https://api.github.com/users/asubiotto/following{/other_user}","gists_url":"https://api.github.com/users/asubiotto/gists{/gist_id}","starred_url":"https://api.github.com/users/asubiotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asubiotto/subscriptions","organizations_url":"https://api.github.com/users/asubiotto/orgs","repos_url":"https://api.github.com/users/asubiotto/repos","events_url":"https://api.github.com/users/asubiotto/events{/privacy}","received_events_url":"https://api.github.com/users/asubiotto/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"andreimatei","id":377201,"avatar_url":"https://avatars.githubusercontent.com/u/377201?v=3","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false},"assignees":[{"login":"andreimatei","id":377201,"avatar_url":"https://avatars.githubusercontent.com/u/377201?v=3","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false}],"milestone":null,"comments":22,"created_at":"2016-11-17T16:44:27Z","updated_at":"2016-12-01T18:14:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/10765","html_url":"https://github.com/cockroachdb/cockroach/pull/10765","diff_url":"https://github.com/cockroachdb/cockroach/pull/10765.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/10765.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/10765)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/264249397","html_url":"https://github.com/cockroachdb/cockroach/pull/10765#issuecomment-264249397","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/10765","id":264249397,"user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T18:14:16Z","updated_at":"2016-12-01T18:14:16Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 43 unresolved discussions, all commit checks successful.\n\n---\n\n*[docs/RFCS/drain_modes.md, line 165 at r4](https://reviewable.io:443/reviews/cockroachdb/cockroach/10765#-KXsa3bRbkV2Pb5z4Eul:-KXv_cHExZUEugr264EW:b-8bq28e) ([raw file](https://github.com/cockroachdb/cockroach/blob/5313f269d83ea2ea2ed75f3e1d28638ff765d330/docs/RFCS/drain_modes.md#L165)):*\n<details><summary><i>Previously, andreimatei (Andrei Matei) wrote…</i></summary><blockquote>\n\nyou want to extend the `StoreDescriptor` *proto*? Did new draining field sounds to me like ephemeral, in-memory state. You probably don't want to save it to disk, and so probably also doesn't belong in the proto. I think we should find a different way of gossiping it.\nOr... did you want to save the field to disk, and reset it on next boot?\n</blockquote></details>\n\nThe `StoreDescriptor` proto is both saved to disk and sent over the network via gossip. I believe @asubiotto is suggesting adding a `draining` field that is only populated when being sent via gossip. We have other fields in `StoreDescriptor`, namely `Capacity`, that are only ever sent over gossip and not persisted to disk. \n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/10765)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"petermattis"}}