{"action":"created","issue":{"url":"https://api.github.com/repos/blargity/toolkit-for-ynab/issues/209","repository_url":"https://api.github.com/repos/blargity/toolkit-for-ynab","labels_url":"https://api.github.com/repos/blargity/toolkit-for-ynab/issues/209/labels{/name}","comments_url":"https://api.github.com/repos/blargity/toolkit-for-ynab/issues/209/comments","events_url":"https://api.github.com/repos/blargity/toolkit-for-ynab/issues/209/events","html_url":"https://github.com/blargity/toolkit-for-ynab/pull/209","id":134100609,"number":209,"title":"EditorConfig changes","user":{"login":"StephenBrown2","id":1148665,"avatar_url":"https://avatars.githubusercontent.com/u/1148665?v=3","gravatar_id":"","url":"https://api.github.com/users/StephenBrown2","html_url":"https://github.com/StephenBrown2","followers_url":"https://api.github.com/users/StephenBrown2/followers","following_url":"https://api.github.com/users/StephenBrown2/following{/other_user}","gists_url":"https://api.github.com/users/StephenBrown2/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenBrown2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenBrown2/subscriptions","organizations_url":"https://api.github.com/users/StephenBrown2/orgs","repos_url":"https://api.github.com/users/StephenBrown2/repos","events_url":"https://api.github.com/users/StephenBrown2/events{/privacy}","received_events_url":"https://api.github.com/users/StephenBrown2/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/blargity/toolkit-for-ynab/labels/needs%20work%20before%20merge","name":"needs work before merge","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2016-02-16T21:23:43Z","updated_at":"2016-02-18T16:26:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/blargity/toolkit-for-ynab/pulls/209","html_url":"https://github.com/blargity/toolkit-for-ynab/pull/209","diff_url":"https://github.com/blargity/toolkit-for-ynab/pull/209.diff","patch_url":"https://github.com/blargity/toolkit-for-ynab/pull/209.patch"},"body":"Based on this comment here: https://github.com/blargity/toolkit-for-ynab/pull/175#issuecomment-181308886\r\n\r\nI thought it might be nice to set a standard for formatting using [EditorConfig](http://editorconfig.org/), a cross-editor way of enforcing particular formatting preferences for a project.\r\n\r\nThe .editorconfig file is in the src tree, and the file match pattern `common/res/features/*/*.{js,css}` should match only user-created files one dir down, avoiding vendored files in subdirectories.\r\n\r\nI then ran [eclint](https://www.npmjs.com/package/eclint) from the src dir with the same parameters:\r\n`eclint fix -c utf-8 -e lf -n -w -i space -s 2 common/res/features/*/*.{js,css}`\r\n\r\nI'd rather make it universal, but figured since this conservative change affected quite a few files already, I'd leave it as is and wait for comment."},"comment":{"url":"https://api.github.com/repos/blargity/toolkit-for-ynab/issues/comments/185801485","html_url":"https://github.com/blargity/toolkit-for-ynab/pull/209#issuecomment-185801485","issue_url":"https://api.github.com/repos/blargity/toolkit-for-ynab/issues/209","id":185801485,"user":{"login":"StephenBrown2","id":1148665,"avatar_url":"https://avatars.githubusercontent.com/u/1148665?v=3","gravatar_id":"","url":"https://api.github.com/users/StephenBrown2","html_url":"https://github.com/StephenBrown2","followers_url":"https://api.github.com/users/StephenBrown2/followers","following_url":"https://api.github.com/users/StephenBrown2/following{/other_user}","gists_url":"https://api.github.com/users/StephenBrown2/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenBrown2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenBrown2/subscriptions","organizations_url":"https://api.github.com/users/StephenBrown2/orgs","repos_url":"https://api.github.com/users/StephenBrown2/repos","events_url":"https://api.github.com/users/StephenBrown2/events{/privacy}","received_events_url":"https://api.github.com/users/StephenBrown2/received_events","type":"User","site_admin":false},"created_at":"2016-02-18T16:26:25Z","updated_at":"2016-02-18T16:26:25Z","body":"js-beautify also handles css and html, which is absolutely fine by me, I was more suggesting the time of the check being pre-commit rather than on build."}}