{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefxlab/issues/820","repository_url":"https://api.github.com/repos/dotnet/corefxlab","labels_url":"https://api.github.com/repos/dotnet/corefxlab/issues/820/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefxlab/issues/820/comments","events_url":"https://api.github.com/repos/dotnet/corefxlab/issues/820/events","html_url":"https://github.com/dotnet/corefxlab/issues/820","id":177379907,"number":820,"title":"Broken pool due to error in UVBuffer","user":{"login":"Nomad1","id":3510066,"avatar_url":"https://avatars.githubusercontent.com/u/3510066?v=3","gravatar_id":"","url":"https://api.github.com/users/Nomad1","html_url":"https://github.com/Nomad1","followers_url":"https://api.github.com/users/Nomad1/followers","following_url":"https://api.github.com/users/Nomad1/following{/other_user}","gists_url":"https://api.github.com/users/Nomad1/gists{/gist_id}","starred_url":"https://api.github.com/users/Nomad1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nomad1/subscriptions","organizations_url":"https://api.github.com/users/Nomad1/orgs","repos_url":"https://api.github.com/users/Nomad1/repos","events_url":"https://api.github.com/users/Nomad1/events{/privacy}","received_events_url":"https://api.github.com/users/Nomad1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-16T09:22:02Z","updated_at":"2016-09-16T15:20:44Z","closed_at":null,"body":"@KrzysztofCwalina \r\nI took a look at [Buffer.cs](\r\nhttps://github.com/dotnet/corefxlab/blob/master/src/System.Net.Libuv/System/Net/Libuv/Buffer.cs) and pretty sure below code does not work and even more, it is tempering BufferPool and memory usage:\r\n```\r\n            internal void Dispose()\r\n            {\r\n                unsafe\r\n                {\r\n                    Length = 0;\r\n                    Buffer = IntPtr.Zero;\r\n                    FreeBuffer(new Bytes((byte*)Buffer.ToPointer(), (int)Length));\r\n                }\r\n            }\r\n```\r\nYou are always submitting zeroes to FreeBuffer method. I'd suggest you to call it in the first place :)"},"comment":{"url":"https://api.github.com/repos/dotnet/corefxlab/issues/comments/247628707","html_url":"https://github.com/dotnet/corefxlab/issues/820#issuecomment-247628707","issue_url":"https://api.github.com/repos/dotnet/corefxlab/issues/820","id":247628707,"user":{"login":"KrzysztofCwalina","id":9724236,"avatar_url":"https://avatars.githubusercontent.com/u/9724236?v=3","gravatar_id":"","url":"https://api.github.com/users/KrzysztofCwalina","html_url":"https://github.com/KrzysztofCwalina","followers_url":"https://api.github.com/users/KrzysztofCwalina/followers","following_url":"https://api.github.com/users/KrzysztofCwalina/following{/other_user}","gists_url":"https://api.github.com/users/KrzysztofCwalina/gists{/gist_id}","starred_url":"https://api.github.com/users/KrzysztofCwalina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrzysztofCwalina/subscriptions","organizations_url":"https://api.github.com/users/KrzysztofCwalina/orgs","repos_url":"https://api.github.com/users/KrzysztofCwalina/repos","events_url":"https://api.github.com/users/KrzysztofCwalina/events{/privacy}","received_events_url":"https://api.github.com/users/KrzysztofCwalina/received_events","type":"User","site_admin":false},"created_at":"2016-09-16T15:20:44Z","updated_at":"2016-09-16T15:20:44Z","body":"Yeah, this is what happens when you (I) merge code without having test coverage. \r\n\r\nThanks for pointing this out. I filed an issue (#822) to add proper tests."}}
{"actor":{"display_login":"KrzysztofCwalina"}}