{"action":"created","issue":{"url":"https://api.github.com/repos/freedomjs/freedom/issues/308","repository_url":"https://api.github.com/repos/freedomjs/freedom","labels_url":"https://api.github.com/repos/freedomjs/freedom/issues/308/labels{/name}","comments_url":"https://api.github.com/repos/freedomjs/freedom/issues/308/comments","events_url":"https://api.github.com/repos/freedomjs/freedom/issues/308/events","html_url":"https://github.com/freedomjs/freedom/pull/308","id":149887752,"number":308,"title":"disabling cross-instance storage test, node tcp pause/resume test","user":{"login":"soycode","id":587921,"avatar_url":"https://avatars.githubusercontent.com/u/587921?v=3","gravatar_id":"","url":"https://api.github.com/users/soycode","html_url":"https://github.com/soycode","followers_url":"https://api.github.com/users/soycode/followers","following_url":"https://api.github.com/users/soycode/following{/other_user}","gists_url":"https://api.github.com/users/soycode/gists{/gist_id}","starred_url":"https://api.github.com/users/soycode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soycode/subscriptions","organizations_url":"https://api.github.com/users/soycode/orgs","repos_url":"https://api.github.com/users/soycode/repos","events_url":"https://api.github.com/users/soycode/events{/privacy}","received_events_url":"https://api.github.com/users/soycode/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/freedomjs/freedom/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-04-20T21:14:21Z","updated_at":"2016-04-21T16:16:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/freedomjs/freedom/pulls/308","html_url":"https://github.com/freedomjs/freedom/pull/308","diff_url":"https://github.com/freedomjs/freedom/pull/308.diff","patch_url":"https://github.com/freedomjs/freedom/pull/308.patch"},"body":"@ryscheng @willscott \r\n\r\nNot high priority, but I'm re-disabling this test - I had enabled it because it was passing in freedom(-for-firefox, -for-chrome), but I'm now revisiting freedom-for-node for the first time in awhile (https://github.com/freedomjs/freedom-for-node/tree/soycode-cleanup) and have found that this test does *not* pass in it.\r\n\r\nThat, combined with the good question raised by the TODO of whether this behavior is even desired, suggests I should disable the test. However if either of you think this test should be desired behavior (since it is what freedom does in most environments) then I can leave it enabled and focus on getting the node flavor to pass it."},"comment":{"url":"https://api.github.com/repos/freedomjs/freedom/issues/comments/212991533","html_url":"https://github.com/freedomjs/freedom/pull/308#issuecomment-212991533","issue_url":"https://api.github.com/repos/freedomjs/freedom/issues/308","id":212991533,"user":{"login":"soycode","id":587921,"avatar_url":"https://avatars.githubusercontent.com/u/587921?v=3","gravatar_id":"","url":"https://api.github.com/users/soycode","html_url":"https://github.com/soycode","followers_url":"https://api.github.com/users/soycode/followers","following_url":"https://api.github.com/users/soycode/following{/other_user}","gists_url":"https://api.github.com/users/soycode/gists{/gist_id}","starred_url":"https://api.github.com/users/soycode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soycode/subscriptions","organizations_url":"https://api.github.com/users/soycode/orgs","repos_url":"https://api.github.com/users/soycode/repos","events_url":"https://api.github.com/users/soycode/events{/privacy}","received_events_url":"https://api.github.com/users/soycode/received_events","type":"User","site_admin":false},"created_at":"2016-04-21T16:16:12Z","updated_at":"2016-04-21T16:16:12Z","body":"Agreed pause/resume should work in node, and it seems to - the bug is that later tests fail, which may have more to do with the test than the implementation (or at least some node-specific quirk with how it runs the test). I'll see if I can debug it but if I can't fix it I'd still be tempted to disable it in node just so the Shippable/Travis alerts become more meaningful."}}