{"action":"reopened","issue":{"url":"https://api.github.com/repos/revivek/oy/issues/21","labels_url":"https://api.github.com/repos/revivek/oy/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/revivek/oy/issues/21/comments","events_url":"https://api.github.com/repos/revivek/oy/issues/21/events","html_url":"https://github.com/revivek/oy/issues/21","id":127364590,"number":21,"title":"Remove HTML4 data-* attributes, and replace with `is`","user":{"login":"revivek","id":719821,"avatar_url":"https://avatars.githubusercontent.com/u/719821?v=3","gravatar_id":"","url":"https://api.github.com/users/revivek","html_url":"https://github.com/revivek","followers_url":"https://api.github.com/users/revivek/followers","following_url":"https://api.github.com/users/revivek/following{/other_user}","gists_url":"https://api.github.com/users/revivek/gists{/gist_id}","starred_url":"https://api.github.com/users/revivek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revivek/subscriptions","organizations_url":"https://api.github.com/users/revivek/orgs","repos_url":"https://api.github.com/users/revivek/repos","events_url":"https://api.github.com/users/revivek/events{/privacy}","received_events_url":"https://api.github.com/users/revivek/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/revivek/oy/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/revivek/oy/labels/cleanup","name":"cleanup","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-01-19T04:41:51Z","updated_at":"2016-01-31T22:34:15Z","closed_at":null,"body":"As of June 10, 2015, we can remove the `data-*` attributes that get search and replaced (`data-bgcolor`, `data-align`, etc.) to the HTML4 variants. We can use the `is` property. This should also fix an unlikely but still possible bug resulting from the current search and replace strategy: since we operate on the raw string, _all_ of data-background and its cousins would be replaced. This means an HTML5 newsletter writing about how \"AlignerFoo.js uses data-align to align your elements\" would turn into \"AlignerFoo.js uses align to align your elements.\" \r\n\r\nhttps://github.com/facebook/react/issues/140#issuecomment-114290163\r\nhttps://github.com/facebook/react/pull/3752\r\n\r\nTo do:\r\n- Remove `data-*` attributes from `OyTable`, `OyImg`, etc.\r\n- Place `is` attribute before those removed `data-*` attributes.\r\n- Remove current find and replacing of `data-*` attributes in `utils/HTML4.js`\r\n- Add a test to make sure that case above doesn't occur."}}