{"action":"created","issue":{"url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/732","repository_url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map","labels_url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/732/labels{/name}","comments_url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/732/comments","events_url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/732/events","html_url":"https://github.com/AHAAAAAAA/PokemonGo-Map/pull/732","id":166730128,"number":732,"title":"fix for Gone! pokemon not being removed from map","user":{"login":"bwalendz","id":6239158,"avatar_url":"https://avatars.githubusercontent.com/u/6239158?v=3","gravatar_id":"","url":"https://api.github.com/users/bwalendz","html_url":"https://github.com/bwalendz","followers_url":"https://api.github.com/users/bwalendz/followers","following_url":"https://api.github.com/users/bwalendz/following{/other_user}","gists_url":"https://api.github.com/users/bwalendz/gists{/gist_id}","starred_url":"https://api.github.com/users/bwalendz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwalendz/subscriptions","organizations_url":"https://api.github.com/users/bwalendz/orgs","repos_url":"https://api.github.com/users/bwalendz/repos","events_url":"https://api.github.com/users/bwalendz/events{/privacy}","received_events_url":"https://api.github.com/users/bwalendz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-21T03:31:28Z","updated_at":"2016-07-21T03:53:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/pulls/732","html_url":"https://github.com/AHAAAAAAA/PokemonGo-Map/pull/732","diff_url":"https://github.com/AHAAAAAAA/PokemonGo-Map/pull/732.diff","patch_url":"https://github.com/AHAAAAAAA/PokemonGo-Map/pull/732.patch"},"body":"This pull request includes a\r\n\r\n- [X] Bug fix\r\n- [ ] New feature\r\n- [ ] Translation\r\n\r\nThe following changes were made\r\n\r\n- No longer need the timezone correction when checking for disappeared pokemon to remove from map. All times are now UTC.\r\n\r\nhttps://github.com/AHAAAAAAA/PokemonGo-Map/issues/700\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/comments/234150115","html_url":"https://github.com/AHAAAAAAA/PokemonGo-Map/pull/732#issuecomment-234150115","issue_url":"https://api.github.com/repos/AHAAAAAAA/PokemonGo-Map/issues/732","id":234150115,"user":{"login":"invisiblek","id":328840,"avatar_url":"https://avatars.githubusercontent.com/u/328840?v=3","gravatar_id":"","url":"https://api.github.com/users/invisiblek","html_url":"https://github.com/invisiblek","followers_url":"https://api.github.com/users/invisiblek/followers","following_url":"https://api.github.com/users/invisiblek/following{/other_user}","gists_url":"https://api.github.com/users/invisiblek/gists{/gist_id}","starred_url":"https://api.github.com/users/invisiblek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invisiblek/subscriptions","organizations_url":"https://api.github.com/users/invisiblek/orgs","repos_url":"https://api.github.com/users/invisiblek/repos","events_url":"https://api.github.com/users/invisiblek/events{/privacy}","received_events_url":"https://api.github.com/users/invisiblek/received_events","type":"User","site_admin":false},"created_at":"2016-07-21T03:53:34Z","updated_at":"2016-07-21T03:53:34Z","body":"Well, it fixes the cleanup portion of this whole thing, but another (bigger) issue here is with each iteration of the loop, its dropping down another duplicate marker. sure this cleans them all up later (for pokemon at least, not gyms or pokestops), but it definitely likes to chew up memory before it gets to that point\r\n\r\nMy patch, although maybe a bit long-handed, ensures that only one instance of a particular marker will exist, ever. I also, if I encountered the same pokemon_id/gym_id/pokestop_id, threw a bit of logic together to determine if it was worth deleting the old marker and putting a new on in its place.\r\n\r\nI think with that approach, we could actually strip out a lot of this messy timestamp business.\r\n\r\nhttps://github.com/AHAAAAAAA/PokemonGo-Map/pull/736"}}
{"actor":{"display_login":"invisiblek"}}