{"action":"created","comment":{"url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/pulls/comments/51656234","id":51656234,"diff_hunk":"@@ -75,16 +100,11 @@ func main() {\n \t\tglog.Infof(\"Found %d DNS services in all namespaces with selector %q\", len(services.Items), selector)\n \t\tfor i := range services.Items {\n \t\t\ts := &services.Items[i]\n-\t\t\tingress := s.Status.LoadBalancer.Ingress\n-\t\t\tif len(ingress) < 1 {\n-\t\t\t\tglog.Warningf(\"No ingress defined for ELB\")\n-\t\t\t\tcontinue\n-\t\t\t}\n-\t\t\tif len(ingress) < 1 {\n-\t\t\t\tglog.Warningf(\"Multiple ingress points found for ELB, not supported\")\n+\t\t\thn, err := serviceHostname(s)\n+\t\t\tif err != nil {\n+\t\t\t\tglog.Warningf(\"Couldn't find hostname: %s\", err)","path":"service_listener.go","position":100,"original_position":100,"commit_id":"de7b49fcccdae8d79712a2566354cbf36bcfc1c6","original_commit_id":"de7b49fcccdae8d79712a2566354cbf36bcfc1c6","user":{"login":"knittingdev","id":1946327,"avatar_url":"https://avatars.githubusercontent.com/u/1946327?v=3","gravatar_id":"","url":"https://api.github.com/users/knittingdev","html_url":"https://github.com/knittingdev","followers_url":"https://api.github.com/users/knittingdev/followers","following_url":"https://api.github.com/users/knittingdev/following{/other_user}","gists_url":"https://api.github.com/users/knittingdev/gists{/gist_id}","starred_url":"https://api.github.com/users/knittingdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knittingdev/subscriptions","organizations_url":"https://api.github.com/users/knittingdev/orgs","repos_url":"https://api.github.com/users/knittingdev/repos","events_url":"https://api.github.com/users/knittingdev/events{/privacy}","received_events_url":"https://api.github.com/users/knittingdev/received_events","type":"User","site_admin":false},"body":"Ok, beginning to think this is intentional. Whats the difference between `[Warning|Fata|]f` and just `[Warning|Fatal]`?","created_at":"2016-02-02T23:41:51Z","updated_at":"2016-02-02T23:41:51Z","html_url":"https://github.com/wearemolecule/route53-kubernetes/pull/2#discussion_r51656234","pull_request_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/wearemolecule/route53-kubernetes/pulls/comments/51656234"},"html":{"href":"https://github.com/wearemolecule/route53-kubernetes/pull/2#discussion_r51656234"},"pull_request":{"href":"https://api.github.com/repos/wearemolecule/route53-kubernetes/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/pulls/2","id":58068418,"html_url":"https://github.com/wearemolecule/route53-kubernetes/pull/2","diff_url":"https://github.com/wearemolecule/route53-kubernetes/pull/2.diff","patch_url":"https://github.com/wearemolecule/route53-kubernetes/pull/2.patch","issue_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/issues/2","number":2,"state":"open","locked":false,"title":"Update for new cluster","user":{"login":"iterion","id":145272,"avatar_url":"https://avatars.githubusercontent.com/u/145272?v=3","gravatar_id":"","url":"https://api.github.com/users/iterion","html_url":"https://github.com/iterion","followers_url":"https://api.github.com/users/iterion/followers","following_url":"https://api.github.com/users/iterion/following{/other_user}","gists_url":"https://api.github.com/users/iterion/gists{/gist_id}","starred_url":"https://api.github.com/users/iterion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iterion/subscriptions","organizations_url":"https://api.github.com/users/iterion/orgs","repos_url":"https://api.github.com/users/iterion/repos","events_url":"https://api.github.com/users/iterion/events{/privacy}","received_events_url":"https://api.github.com/users/iterion/received_events","type":"User","site_admin":false},"body":"Update to support latest version of Kubernetes.","created_at":"2016-02-02T23:33:19Z","updated_at":"2016-02-02T23:41:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb1a059dde806e8cb4474cf59a1f3323ee9de642","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/pulls/2/commits","review_comments_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/pulls/2/comments","review_comment_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/issues/2/comments","statuses_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/statuses/de7b49fcccdae8d79712a2566354cbf36bcfc1c6","head":{"label":"wearemolecule:topic/refactor-and-update","ref":"topic/refactor-and-update","sha":"de7b49fcccdae8d79712a2566354cbf36bcfc1c6","user":{"login":"wearemolecule","id":2736908,"avatar_url":"https://avatars.githubusercontent.com/u/2736908?v=3","gravatar_id":"","url":"https://api.github.com/users/wearemolecule","html_url":"https://github.com/wearemolecule","followers_url":"https://api.github.com/users/wearemolecule/followers","following_url":"https://api.github.com/users/wearemolecule/following{/other_user}","gists_url":"https://api.github.com/users/wearemolecule/gists{/gist_id}","starred_url":"https://api.github.com/users/wearemolecule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wearemolecule/subscriptions","organizations_url":"https://api.github.com/users/wearemolecule/orgs","repos_url":"https://api.github.com/users/wearemolecule/repos","events_url":"https://api.github.com/users/wearemolecule/events{/privacy}","received_events_url":"https://api.github.com/users/wearemolecule/received_events","type":"Organization","site_admin":false},"repo":{"id":37739288,"name":"route53-kubernetes","full_name":"wearemolecule/route53-kubernetes","owner":{"login":"wearemolecule","id":2736908,"avatar_url":"https://avatars.githubusercontent.com/u/2736908?v=3","gravatar_id":"","url":"https://api.github.com/users/wearemolecule","html_url":"https://github.com/wearemolecule","followers_url":"https://api.github.com/users/wearemolecule/followers","following_url":"https://api.github.com/users/wearemolecule/following{/other_user}","gists_url":"https://api.github.com/users/wearemolecule/gists{/gist_id}","starred_url":"https://api.github.com/users/wearemolecule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wearemolecule/subscriptions","organizations_url":"https://api.github.com/users/wearemolecule/orgs","repos_url":"https://api.github.com/users/wearemolecule/repos","events_url":"https://api.github.com/users/wearemolecule/events{/privacy}","received_events_url":"https://api.github.com/users/wearemolecule/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wearemolecule/route53-kubernetes","description":"Sync Kubernetes Services with AWS Route53","fork":false,"url":"https://api.github.com/repos/wearemolecule/route53-kubernetes","forks_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/forks","keys_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/teams","hooks_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/events","assignees_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/tags","blobs_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/languages","stargazers_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/subscription","commits_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/merges","archive_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/downloads","issues_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/deployments","created_at":"2015-06-19T18:35:23Z","updated_at":"2016-01-20T03:48:04Z","pushed_at":"2016-02-02T23:33:20Z","git_url":"git://github.com/wearemolecule/route53-kubernetes.git","ssh_url":"git@github.com:wearemolecule/route53-kubernetes.git","clone_url":"https://github.com/wearemolecule/route53-kubernetes.git","svn_url":"https://github.com/wearemolecule/route53-kubernetes","homepage":null,"size":2474,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":4,"default_branch":"master"}},"base":{"label":"wearemolecule:master","ref":"master","sha":"2cb1a987376275775c01d13606e052be04c02dfe","user":{"login":"wearemolecule","id":2736908,"avatar_url":"https://avatars.githubusercontent.com/u/2736908?v=3","gravatar_id":"","url":"https://api.github.com/users/wearemolecule","html_url":"https://github.com/wearemolecule","followers_url":"https://api.github.com/users/wearemolecule/followers","following_url":"https://api.github.com/users/wearemolecule/following{/other_user}","gists_url":"https://api.github.com/users/wearemolecule/gists{/gist_id}","starred_url":"https://api.github.com/users/wearemolecule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wearemolecule/subscriptions","organizations_url":"https://api.github.com/users/wearemolecule/orgs","repos_url":"https://api.github.com/users/wearemolecule/repos","events_url":"https://api.github.com/users/wearemolecule/events{/privacy}","received_events_url":"https://api.github.com/users/wearemolecule/received_events","type":"Organization","site_admin":false},"repo":{"id":37739288,"name":"route53-kubernetes","full_name":"wearemolecule/route53-kubernetes","owner":{"login":"wearemolecule","id":2736908,"avatar_url":"https://avatars.githubusercontent.com/u/2736908?v=3","gravatar_id":"","url":"https://api.github.com/users/wearemolecule","html_url":"https://github.com/wearemolecule","followers_url":"https://api.github.com/users/wearemolecule/followers","following_url":"https://api.github.com/users/wearemolecule/following{/other_user}","gists_url":"https://api.github.com/users/wearemolecule/gists{/gist_id}","starred_url":"https://api.github.com/users/wearemolecule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wearemolecule/subscriptions","organizations_url":"https://api.github.com/users/wearemolecule/orgs","repos_url":"https://api.github.com/users/wearemolecule/repos","events_url":"https://api.github.com/users/wearemolecule/events{/privacy}","received_events_url":"https://api.github.com/users/wearemolecule/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wearemolecule/route53-kubernetes","description":"Sync Kubernetes Services with AWS Route53","fork":false,"url":"https://api.github.com/repos/wearemolecule/route53-kubernetes","forks_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/forks","keys_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/teams","hooks_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/events","assignees_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/tags","blobs_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/languages","stargazers_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/subscription","commits_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/merges","archive_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/downloads","issues_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/wearemolecule/route53-kubernetes/deployments","created_at":"2015-06-19T18:35:23Z","updated_at":"2016-01-20T03:48:04Z","pushed_at":"2016-02-02T23:33:20Z","git_url":"git://github.com/wearemolecule/route53-kubernetes.git","ssh_url":"git@github.com:wearemolecule/route53-kubernetes.git","clone_url":"https://github.com/wearemolecule/route53-kubernetes.git","svn_url":"https://github.com/wearemolecule/route53-kubernetes","homepage":null,"size":2474,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wearemolecule/route53-kubernetes/pulls/2"},"html":{"href":"https://github.com/wearemolecule/route53-kubernetes/pull/2"},"issue":{"href":"https://api.github.com/repos/wearemolecule/route53-kubernetes/issues/2"},"comments":{"href":"https://api.github.com/repos/wearemolecule/route53-kubernetes/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/wearemolecule/route53-kubernetes/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/wearemolecule/route53-kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wearemolecule/route53-kubernetes/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/wearemolecule/route53-kubernetes/statuses/de7b49fcccdae8d79712a2566354cbf36bcfc1c6"}}}}