{"action":"created","comment":{"url":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/comments/71274270","id":71274270,"diff_hunk":"@@ -265,16 +379,25 @@ gen(JitBlock &block)\n          a.bind(targetIter->second.label);\n       }\n \n-      if (JIT_DEBUG) {\n-         a.mov(a.niaMem, lclCia + 4);\n-      }\n-\n       auto instr = mem::read<espresso::Instruction>(lclCia);\n       auto data = espresso::decodeInstruction(instr);\n       auto genSuccess = false;\n \n       a.genCia = lclCia;\n \n+      // Don't attempt to verify non-repeatable instructions\n+      bool canVerify = (data->id != espresso::InstructionID::kc","path":"src/libcpu/src/jit/jit.cpp","position":193,"original_position":193,"commit_id":"bad23cb16ad008fcd821b6be9dce8d25d42fcf8d","original_commit_id":"51a0afe185d05346d5a79139afc03a233b86ffb2","user":{"login":"achurch","id":6619925,"avatar_url":"https://avatars.githubusercontent.com/u/6619925?v=3","gravatar_id":"","url":"https://api.github.com/users/achurch","html_url":"https://github.com/achurch","followers_url":"https://api.github.com/users/achurch/followers","following_url":"https://api.github.com/users/achurch/following{/other_user}","gists_url":"https://api.github.com/users/achurch/gists{/gist_id}","starred_url":"https://api.github.com/users/achurch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achurch/subscriptions","organizations_url":"https://api.github.com/users/achurch/orgs","repos_url":"https://api.github.com/users/achurch/repos","events_url":"https://api.github.com/users/achurch/events{/privacy}","received_events_url":"https://api.github.com/users/achurch/received_events","type":"User","site_admin":false},"body":"I'd presume the compiler can optimize out the tests, but I can rearrange them.","created_at":"2016-07-19T05:25:14Z","updated_at":"2016-07-19T05:25:14Z","html_url":"https://github.com/decaf-emu/decaf-emu/pull/200#discussion_r71274270","pull_request_url":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/200","_links":{"self":{"href":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/comments/71274270"},"html":{"href":"https://github.com/decaf-emu/decaf-emu/pull/200#discussion_r71274270"},"pull_request":{"href":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/200"}}},"pull_request":{"url":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/200","id":77918202,"html_url":"https://github.com/decaf-emu/decaf-emu/pull/200","diff_url":"https://github.com/decaf-emu/decaf-emu/pull/200.diff","patch_url":"https://github.com/decaf-emu/decaf-emu/pull/200.patch","issue_url":"https://api.github.com/repos/decaf-emu/decaf-emu/issues/200","number":200,"state":"open","locked":false,"title":"Fix JIT bugs.","user":{"login":"achurch","id":6619925,"avatar_url":"https://avatars.githubusercontent.com/u/6619925?v=3","gravatar_id":"","url":"https://api.github.com/users/achurch","html_url":"https://github.com/achurch","followers_url":"https://api.github.com/users/achurch/followers","following_url":"https://api.github.com/users/achurch/following{/other_user}","gists_url":"https://api.github.com/users/achurch/gists{/gist_id}","starred_url":"https://api.github.com/users/achurch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achurch/subscriptions","organizations_url":"https://api.github.com/users/achurch/orgs","repos_url":"https://api.github.com/users/achurch/repos","events_url":"https://api.github.com/users/achurch/events{/privacy}","received_events_url":"https://api.github.com/users/achurch/received_events","type":"User","site_admin":false},"body":"The --jit-debug option didn't actually do anything, so I wrote a JIT verifier based on what the option said it should do. That turned up a number of JIT bugs, so I've fixed those.","created_at":"2016-07-19T05:03:43Z","updated_at":"2016-07-19T05:25:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c920e15c8576adbea27433a54c0d9fa118ff41bd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/200/commits","review_comments_url":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/200/comments","review_comment_url":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/decaf-emu/decaf-emu/issues/200/comments","statuses_url":"https://api.github.com/repos/decaf-emu/decaf-emu/statuses/bad23cb16ad008fcd821b6be9dce8d25d42fcf8d","head":{"label":"achurch:jit-fixes","ref":"jit-fixes","sha":"bad23cb16ad008fcd821b6be9dce8d25d42fcf8d","user":{"login":"achurch","id":6619925,"avatar_url":"https://avatars.githubusercontent.com/u/6619925?v=3","gravatar_id":"","url":"https://api.github.com/users/achurch","html_url":"https://github.com/achurch","followers_url":"https://api.github.com/users/achurch/followers","following_url":"https://api.github.com/users/achurch/following{/other_user}","gists_url":"https://api.github.com/users/achurch/gists{/gist_id}","starred_url":"https://api.github.com/users/achurch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achurch/subscriptions","organizations_url":"https://api.github.com/users/achurch/orgs","repos_url":"https://api.github.com/users/achurch/repos","events_url":"https://api.github.com/users/achurch/events{/privacy}","received_events_url":"https://api.github.com/users/achurch/received_events","type":"User","site_admin":false},"repo":{"id":47096572,"name":"decaf-emu","full_name":"achurch/decaf-emu","owner":{"login":"achurch","id":6619925,"avatar_url":"https://avatars.githubusercontent.com/u/6619925?v=3","gravatar_id":"","url":"https://api.github.com/users/achurch","html_url":"https://github.com/achurch","followers_url":"https://api.github.com/users/achurch/followers","following_url":"https://api.github.com/users/achurch/following{/other_user}","gists_url":"https://api.github.com/users/achurch/gists{/gist_id}","starred_url":"https://api.github.com/users/achurch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achurch/subscriptions","organizations_url":"https://api.github.com/users/achurch/orgs","repos_url":"https://api.github.com/users/achurch/repos","events_url":"https://api.github.com/users/achurch/events{/privacy}","received_events_url":"https://api.github.com/users/achurch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/achurch/decaf-emu","description":"Researching Wii U emulation.","fork":true,"url":"https://api.github.com/repos/achurch/decaf-emu","forks_url":"https://api.github.com/repos/achurch/decaf-emu/forks","keys_url":"https://api.github.com/repos/achurch/decaf-emu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/achurch/decaf-emu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/achurch/decaf-emu/teams","hooks_url":"https://api.github.com/repos/achurch/decaf-emu/hooks","issue_events_url":"https://api.github.com/repos/achurch/decaf-emu/issues/events{/number}","events_url":"https://api.github.com/repos/achurch/decaf-emu/events","assignees_url":"https://api.github.com/repos/achurch/decaf-emu/assignees{/user}","branches_url":"https://api.github.com/repos/achurch/decaf-emu/branches{/branch}","tags_url":"https://api.github.com/repos/achurch/decaf-emu/tags","blobs_url":"https://api.github.com/repos/achurch/decaf-emu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/achurch/decaf-emu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/achurch/decaf-emu/git/refs{/sha}","trees_url":"https://api.github.com/repos/achurch/decaf-emu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/achurch/decaf-emu/statuses/{sha}","languages_url":"https://api.github.com/repos/achurch/decaf-emu/languages","stargazers_url":"https://api.github.com/repos/achurch/decaf-emu/stargazers","contributors_url":"https://api.github.com/repos/achurch/decaf-emu/contributors","subscribers_url":"https://api.github.com/repos/achurch/decaf-emu/subscribers","subscription_url":"https://api.github.com/repos/achurch/decaf-emu/subscription","commits_url":"https://api.github.com/repos/achurch/decaf-emu/commits{/sha}","git_commits_url":"https://api.github.com/repos/achurch/decaf-emu/git/commits{/sha}","comments_url":"https://api.github.com/repos/achurch/decaf-emu/comments{/number}","issue_comment_url":"https://api.github.com/repos/achurch/decaf-emu/issues/comments{/number}","contents_url":"https://api.github.com/repos/achurch/decaf-emu/contents/{+path}","compare_url":"https://api.github.com/repos/achurch/decaf-emu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/achurch/decaf-emu/merges","archive_url":"https://api.github.com/repos/achurch/decaf-emu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/achurch/decaf-emu/downloads","issues_url":"https://api.github.com/repos/achurch/decaf-emu/issues{/number}","pulls_url":"https://api.github.com/repos/achurch/decaf-emu/pulls{/number}","milestones_url":"https://api.github.com/repos/achurch/decaf-emu/milestones{/number}","notifications_url":"https://api.github.com/repos/achurch/decaf-emu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/achurch/decaf-emu/labels{/name}","releases_url":"https://api.github.com/repos/achurch/decaf-emu/releases{/id}","deployments_url":"https://api.github.com/repos/achurch/decaf-emu/deployments","created_at":"2015-11-30T05:09:05Z","updated_at":"2016-07-14T17:57:49Z","pushed_at":"2016-07-19T04:58:58Z","git_url":"git://github.com/achurch/decaf-emu.git","ssh_url":"git@github.com:achurch/decaf-emu.git","clone_url":"https://github.com/achurch/decaf-emu.git","svn_url":"https://github.com/achurch/decaf-emu","homepage":null,"size":5911,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"decaf-emu:master","ref":"master","sha":"66dc5600df910a9e3679f9862358b9eef7f891ab","user":{"login":"decaf-emu","id":15236850,"avatar_url":"https://avatars.githubusercontent.com/u/15236850?v=3","gravatar_id":"","url":"https://api.github.com/users/decaf-emu","html_url":"https://github.com/decaf-emu","followers_url":"https://api.github.com/users/decaf-emu/followers","following_url":"https://api.github.com/users/decaf-emu/following{/other_user}","gists_url":"https://api.github.com/users/decaf-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/decaf-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decaf-emu/subscriptions","organizations_url":"https://api.github.com/users/decaf-emu/orgs","repos_url":"https://api.github.com/users/decaf-emu/repos","events_url":"https://api.github.com/users/decaf-emu/events{/privacy}","received_events_url":"https://api.github.com/users/decaf-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":35845931,"name":"decaf-emu","full_name":"decaf-emu/decaf-emu","owner":{"login":"decaf-emu","id":15236850,"avatar_url":"https://avatars.githubusercontent.com/u/15236850?v=3","gravatar_id":"","url":"https://api.github.com/users/decaf-emu","html_url":"https://github.com/decaf-emu","followers_url":"https://api.github.com/users/decaf-emu/followers","following_url":"https://api.github.com/users/decaf-emu/following{/other_user}","gists_url":"https://api.github.com/users/decaf-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/decaf-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decaf-emu/subscriptions","organizations_url":"https://api.github.com/users/decaf-emu/orgs","repos_url":"https://api.github.com/users/decaf-emu/repos","events_url":"https://api.github.com/users/decaf-emu/events{/privacy}","received_events_url":"https://api.github.com/users/decaf-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/decaf-emu/decaf-emu","description":"Researching Wii U emulation.","fork":false,"url":"https://api.github.com/repos/decaf-emu/decaf-emu","forks_url":"https://api.github.com/repos/decaf-emu/decaf-emu/forks","keys_url":"https://api.github.com/repos/decaf-emu/decaf-emu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decaf-emu/decaf-emu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decaf-emu/decaf-emu/teams","hooks_url":"https://api.github.com/repos/decaf-emu/decaf-emu/hooks","issue_events_url":"https://api.github.com/repos/decaf-emu/decaf-emu/issues/events{/number}","events_url":"https://api.github.com/repos/decaf-emu/decaf-emu/events","assignees_url":"https://api.github.com/repos/decaf-emu/decaf-emu/assignees{/user}","branches_url":"https://api.github.com/repos/decaf-emu/decaf-emu/branches{/branch}","tags_url":"https://api.github.com/repos/decaf-emu/decaf-emu/tags","blobs_url":"https://api.github.com/repos/decaf-emu/decaf-emu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decaf-emu/decaf-emu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decaf-emu/decaf-emu/git/refs{/sha}","trees_url":"https://api.github.com/repos/decaf-emu/decaf-emu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decaf-emu/decaf-emu/statuses/{sha}","languages_url":"https://api.github.com/repos/decaf-emu/decaf-emu/languages","stargazers_url":"https://api.github.com/repos/decaf-emu/decaf-emu/stargazers","contributors_url":"https://api.github.com/repos/decaf-emu/decaf-emu/contributors","subscribers_url":"https://api.github.com/repos/decaf-emu/decaf-emu/subscribers","subscription_url":"https://api.github.com/repos/decaf-emu/decaf-emu/subscription","commits_url":"https://api.github.com/repos/decaf-emu/decaf-emu/commits{/sha}","git_commits_url":"https://api.github.com/repos/decaf-emu/decaf-emu/git/commits{/sha}","comments_url":"https://api.github.com/repos/decaf-emu/decaf-emu/comments{/number}","issue_comment_url":"https://api.github.com/repos/decaf-emu/decaf-emu/issues/comments{/number}","contents_url":"https://api.github.com/repos/decaf-emu/decaf-emu/contents/{+path}","compare_url":"https://api.github.com/repos/decaf-emu/decaf-emu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decaf-emu/decaf-emu/merges","archive_url":"https://api.github.com/repos/decaf-emu/decaf-emu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decaf-emu/decaf-emu/downloads","issues_url":"https://api.github.com/repos/decaf-emu/decaf-emu/issues{/number}","pulls_url":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls{/number}","milestones_url":"https://api.github.com/repos/decaf-emu/decaf-emu/milestones{/number}","notifications_url":"https://api.github.com/repos/decaf-emu/decaf-emu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decaf-emu/decaf-emu/labels{/name}","releases_url":"https://api.github.com/repos/decaf-emu/decaf-emu/releases{/id}","deployments_url":"https://api.github.com/repos/decaf-emu/decaf-emu/deployments","created_at":"2015-05-18T22:29:19Z","updated_at":"2016-07-18T18:03:03Z","pushed_at":"2016-07-19T05:03:43Z","git_url":"git://github.com/decaf-emu/decaf-emu.git","ssh_url":"git@github.com:decaf-emu/decaf-emu.git","clone_url":"https://github.com/decaf-emu/decaf-emu.git","svn_url":"https://github.com/decaf-emu/decaf-emu","homepage":null,"size":6205,"stargazers_count":330,"watchers_count":330,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":15,"forks":46,"open_issues":15,"watchers":330,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/200"},"html":{"href":"https://github.com/decaf-emu/decaf-emu/pull/200"},"issue":{"href":"https://api.github.com/repos/decaf-emu/decaf-emu/issues/200"},"comments":{"href":"https://api.github.com/repos/decaf-emu/decaf-emu/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/decaf-emu/decaf-emu/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/decaf-emu/decaf-emu/statuses/bad23cb16ad008fcd821b6be9dce8d25d42fcf8d"}}}}
{"actor":{"display_login":"achurch"}}