{"action":"created","comment":{"url":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/comments/68554741","id":68554741,"diff_hunk":"@@ -12,25 +15,30 @@ function dest(outFolder, opt) {\n     opt = {};\n   }\n \n+  var options = assign({}, opt, {","path":"lib/dest/index.js","position":16,"original_position":16,"commit_id":"7da06ba73378fef98443c0e1bfaa91cee5e7c245","original_commit_id":"7da06ba73378fef98443c0e1bfaa91cee5e7c245","user":{"login":"hgwood","id":1656170,"avatar_url":"https://avatars.githubusercontent.com/u/1656170?v=3","gravatar_id":"","url":"https://api.github.com/users/hgwood","html_url":"https://github.com/hgwood","followers_url":"https://api.github.com/users/hgwood/followers","following_url":"https://api.github.com/users/hgwood/following{/other_user}","gists_url":"https://api.github.com/users/hgwood/gists{/gist_id}","starred_url":"https://api.github.com/users/hgwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgwood/subscriptions","organizations_url":"https://api.github.com/users/hgwood/orgs","repos_url":"https://api.github.com/users/hgwood/repos","events_url":"https://api.github.com/users/hgwood/events{/privacy}","received_events_url":"https://api.github.com/users/hgwood/received_events","type":"User","site_admin":false},"body":"OK","created_at":"2016-06-27T10:33:33Z","updated_at":"2016-06-27T10:33:33Z","html_url":"https://github.com/gulpjs/vinyl-fs/pull/168#discussion_r68554741","pull_request_url":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/168","_links":{"self":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/comments/68554741"},"html":{"href":"https://github.com/gulpjs/vinyl-fs/pull/168#discussion_r68554741"},"pull_request":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/168"}}},"pull_request":{"url":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/168","id":68555315,"html_url":"https://github.com/gulpjs/vinyl-fs/pull/168","diff_url":"https://github.com/gulpjs/vinyl-fs/pull/168.diff","patch_url":"https://github.com/gulpjs/vinyl-fs/pull/168.patch","issue_url":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/168","number":168,"state":"open","locked":false,"title":"Support functions for all src options (fix #139)","user":{"login":"hgwood","id":1656170,"avatar_url":"https://avatars.githubusercontent.com/u/1656170?v=3","gravatar_id":"","url":"https://api.github.com/users/hgwood","html_url":"https://github.com/hgwood","followers_url":"https://api.github.com/users/hgwood/followers","following_url":"https://api.github.com/users/hgwood/following{/other_user}","gists_url":"https://api.github.com/users/hgwood/gists{/gist_id}","starred_url":"https://api.github.com/users/hgwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgwood/subscriptions","organizations_url":"https://api.github.com/users/hgwood/orgs","repos_url":"https://api.github.com/users/hgwood/repos","events_url":"https://api.github.com/users/hgwood/events{/privacy}","received_events_url":"https://api.github.com/users/hgwood/received_events","type":"User","site_admin":false},"body":"It is not entirely clear from the issue if it is only about `src` or if `dest` is also in scope. Anyway, here it is for `src`. I can replicate the behavior for `dest` very simply.\r\n\r\nA few notes:\r\n- I think mixing vinyl-fs options and through2 options in the option object can be error-prone (https://github.com/gulpjs/vinyl-fs/issues/153) and can complexify the implementation (see how I need to avoid calling through2 options that are functions?). May I suggest moving through2 options to a through2 property in vinyl-fs options? I believe that would be simpler and clearer, both for the caller and the callee. It would be a breaking change.\r\n- I did not use `value-or-function` because I did not see the benefit of checking the types of the options. Also I saw defaulting to `null` as a bit dangerous and surprising for users of vinyl-fs.\r\n- What about jumping to Node 4 LTS compatibility for vinyl-fs 3? That would enable a bunch of ES6 features.","created_at":"2016-05-02T12:46:51Z","updated_at":"2016-06-27T10:33:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80fb027360af04c7a9e39e9ba30ccec90e2baf46","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/168/commits","review_comments_url":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/168/comments","review_comment_url":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/168/comments","statuses_url":"https://api.github.com/repos/gulpjs/vinyl-fs/statuses/7da06ba73378fef98443c0e1bfaa91cee5e7c245","head":{"label":"hgwood:feat/issue139","ref":"feat/issue139","sha":"7da06ba73378fef98443c0e1bfaa91cee5e7c245","user":{"login":"hgwood","id":1656170,"avatar_url":"https://avatars.githubusercontent.com/u/1656170?v=3","gravatar_id":"","url":"https://api.github.com/users/hgwood","html_url":"https://github.com/hgwood","followers_url":"https://api.github.com/users/hgwood/followers","following_url":"https://api.github.com/users/hgwood/following{/other_user}","gists_url":"https://api.github.com/users/hgwood/gists{/gist_id}","starred_url":"https://api.github.com/users/hgwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgwood/subscriptions","organizations_url":"https://api.github.com/users/hgwood/orgs","repos_url":"https://api.github.com/users/hgwood/repos","events_url":"https://api.github.com/users/hgwood/events{/privacy}","received_events_url":"https://api.github.com/users/hgwood/received_events","type":"User","site_admin":false},"repo":{"id":56717573,"name":"vinyl-fs","full_name":"hgwood/vinyl-fs","owner":{"login":"hgwood","id":1656170,"avatar_url":"https://avatars.githubusercontent.com/u/1656170?v=3","gravatar_id":"","url":"https://api.github.com/users/hgwood","html_url":"https://github.com/hgwood","followers_url":"https://api.github.com/users/hgwood/followers","following_url":"https://api.github.com/users/hgwood/following{/other_user}","gists_url":"https://api.github.com/users/hgwood/gists{/gist_id}","starred_url":"https://api.github.com/users/hgwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgwood/subscriptions","organizations_url":"https://api.github.com/users/hgwood/orgs","repos_url":"https://api.github.com/users/hgwood/repos","events_url":"https://api.github.com/users/hgwood/events{/privacy}","received_events_url":"https://api.github.com/users/hgwood/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hgwood/vinyl-fs","description":"Vinyl adapter for the file system","fork":true,"url":"https://api.github.com/repos/hgwood/vinyl-fs","forks_url":"https://api.github.com/repos/hgwood/vinyl-fs/forks","keys_url":"https://api.github.com/repos/hgwood/vinyl-fs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hgwood/vinyl-fs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hgwood/vinyl-fs/teams","hooks_url":"https://api.github.com/repos/hgwood/vinyl-fs/hooks","issue_events_url":"https://api.github.com/repos/hgwood/vinyl-fs/issues/events{/number}","events_url":"https://api.github.com/repos/hgwood/vinyl-fs/events","assignees_url":"https://api.github.com/repos/hgwood/vinyl-fs/assignees{/user}","branches_url":"https://api.github.com/repos/hgwood/vinyl-fs/branches{/branch}","tags_url":"https://api.github.com/repos/hgwood/vinyl-fs/tags","blobs_url":"https://api.github.com/repos/hgwood/vinyl-fs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hgwood/vinyl-fs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hgwood/vinyl-fs/git/refs{/sha}","trees_url":"https://api.github.com/repos/hgwood/vinyl-fs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hgwood/vinyl-fs/statuses/{sha}","languages_url":"https://api.github.com/repos/hgwood/vinyl-fs/languages","stargazers_url":"https://api.github.com/repos/hgwood/vinyl-fs/stargazers","contributors_url":"https://api.github.com/repos/hgwood/vinyl-fs/contributors","subscribers_url":"https://api.github.com/repos/hgwood/vinyl-fs/subscribers","subscription_url":"https://api.github.com/repos/hgwood/vinyl-fs/subscription","commits_url":"https://api.github.com/repos/hgwood/vinyl-fs/commits{/sha}","git_commits_url":"https://api.github.com/repos/hgwood/vinyl-fs/git/commits{/sha}","comments_url":"https://api.github.com/repos/hgwood/vinyl-fs/comments{/number}","issue_comment_url":"https://api.github.com/repos/hgwood/vinyl-fs/issues/comments{/number}","contents_url":"https://api.github.com/repos/hgwood/vinyl-fs/contents/{+path}","compare_url":"https://api.github.com/repos/hgwood/vinyl-fs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hgwood/vinyl-fs/merges","archive_url":"https://api.github.com/repos/hgwood/vinyl-fs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hgwood/vinyl-fs/downloads","issues_url":"https://api.github.com/repos/hgwood/vinyl-fs/issues{/number}","pulls_url":"https://api.github.com/repos/hgwood/vinyl-fs/pulls{/number}","milestones_url":"https://api.github.com/repos/hgwood/vinyl-fs/milestones{/number}","notifications_url":"https://api.github.com/repos/hgwood/vinyl-fs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hgwood/vinyl-fs/labels{/name}","releases_url":"https://api.github.com/repos/hgwood/vinyl-fs/releases{/id}","deployments_url":"https://api.github.com/repos/hgwood/vinyl-fs/deployments","created_at":"2016-04-20T20:06:54Z","updated_at":"2016-04-20T20:06:56Z","pushed_at":"2016-06-20T12:04:00Z","git_url":"git://github.com/hgwood/vinyl-fs.git","ssh_url":"git@github.com:hgwood/vinyl-fs.git","clone_url":"https://github.com/hgwood/vinyl-fs.git","svn_url":"https://github.com/hgwood/vinyl-fs","homepage":null,"size":314,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gulpjs:master","ref":"master","sha":"c847cd91154a290d972e48fdf8dc96a52dc7925b","user":{"login":"gulpjs","id":6200624,"avatar_url":"https://avatars.githubusercontent.com/u/6200624?v=3","gravatar_id":"","url":"https://api.github.com/users/gulpjs","html_url":"https://github.com/gulpjs","followers_url":"https://api.github.com/users/gulpjs/followers","following_url":"https://api.github.com/users/gulpjs/following{/other_user}","gists_url":"https://api.github.com/users/gulpjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gulpjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gulpjs/subscriptions","organizations_url":"https://api.github.com/users/gulpjs/orgs","repos_url":"https://api.github.com/users/gulpjs/repos","events_url":"https://api.github.com/users/gulpjs/events{/privacy}","received_events_url":"https://api.github.com/users/gulpjs/received_events","type":"Organization","site_admin":false},"repo":{"id":15355019,"name":"vinyl-fs","full_name":"gulpjs/vinyl-fs","owner":{"login":"gulpjs","id":6200624,"avatar_url":"https://avatars.githubusercontent.com/u/6200624?v=3","gravatar_id":"","url":"https://api.github.com/users/gulpjs","html_url":"https://github.com/gulpjs","followers_url":"https://api.github.com/users/gulpjs/followers","following_url":"https://api.github.com/users/gulpjs/following{/other_user}","gists_url":"https://api.github.com/users/gulpjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gulpjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gulpjs/subscriptions","organizations_url":"https://api.github.com/users/gulpjs/orgs","repos_url":"https://api.github.com/users/gulpjs/repos","events_url":"https://api.github.com/users/gulpjs/events{/privacy}","received_events_url":"https://api.github.com/users/gulpjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gulpjs/vinyl-fs","description":"Vinyl adapter for the file system","fork":false,"url":"https://api.github.com/repos/gulpjs/vinyl-fs","forks_url":"https://api.github.com/repos/gulpjs/vinyl-fs/forks","keys_url":"https://api.github.com/repos/gulpjs/vinyl-fs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gulpjs/vinyl-fs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gulpjs/vinyl-fs/teams","hooks_url":"https://api.github.com/repos/gulpjs/vinyl-fs/hooks","issue_events_url":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/events{/number}","events_url":"https://api.github.com/repos/gulpjs/vinyl-fs/events","assignees_url":"https://api.github.com/repos/gulpjs/vinyl-fs/assignees{/user}","branches_url":"https://api.github.com/repos/gulpjs/vinyl-fs/branches{/branch}","tags_url":"https://api.github.com/repos/gulpjs/vinyl-fs/tags","blobs_url":"https://api.github.com/repos/gulpjs/vinyl-fs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gulpjs/vinyl-fs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gulpjs/vinyl-fs/git/refs{/sha}","trees_url":"https://api.github.com/repos/gulpjs/vinyl-fs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gulpjs/vinyl-fs/statuses/{sha}","languages_url":"https://api.github.com/repos/gulpjs/vinyl-fs/languages","stargazers_url":"https://api.github.com/repos/gulpjs/vinyl-fs/stargazers","contributors_url":"https://api.github.com/repos/gulpjs/vinyl-fs/contributors","subscribers_url":"https://api.github.com/repos/gulpjs/vinyl-fs/subscribers","subscription_url":"https://api.github.com/repos/gulpjs/vinyl-fs/subscription","commits_url":"https://api.github.com/repos/gulpjs/vinyl-fs/commits{/sha}","git_commits_url":"https://api.github.com/repos/gulpjs/vinyl-fs/git/commits{/sha}","comments_url":"https://api.github.com/repos/gulpjs/vinyl-fs/comments{/number}","issue_comment_url":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/comments{/number}","contents_url":"https://api.github.com/repos/gulpjs/vinyl-fs/contents/{+path}","compare_url":"https://api.github.com/repos/gulpjs/vinyl-fs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gulpjs/vinyl-fs/merges","archive_url":"https://api.github.com/repos/gulpjs/vinyl-fs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gulpjs/vinyl-fs/downloads","issues_url":"https://api.github.com/repos/gulpjs/vinyl-fs/issues{/number}","pulls_url":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls{/number}","milestones_url":"https://api.github.com/repos/gulpjs/vinyl-fs/milestones{/number}","notifications_url":"https://api.github.com/repos/gulpjs/vinyl-fs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gulpjs/vinyl-fs/labels{/name}","releases_url":"https://api.github.com/repos/gulpjs/vinyl-fs/releases{/id}","deployments_url":"https://api.github.com/repos/gulpjs/vinyl-fs/deployments","created_at":"2013-12-21T06:40:44Z","updated_at":"2016-06-25T22:03:26Z","pushed_at":"2016-06-27T02:55:11Z","git_url":"git://github.com/gulpjs/vinyl-fs.git","ssh_url":"git@github.com:gulpjs/vinyl-fs.git","clone_url":"https://github.com/gulpjs/vinyl-fs.git","svn_url":"https://github.com/gulpjs/vinyl-fs","homepage":null,"size":396,"stargazers_count":507,"watchers_count":507,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":82,"mirror_url":null,"open_issues_count":17,"forks":82,"open_issues":17,"watchers":507,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/168"},"html":{"href":"https://github.com/gulpjs/vinyl-fs/pull/168"},"issue":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/168"},"comments":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/gulpjs/vinyl-fs/statuses/7da06ba73378fef98443c0e1bfaa91cee5e7c245"}}}}
{"actor":{"display_login":"hgwood"}}