{"action":"created","issue":{"url":"https://api.github.com/repos/neomake/neomake/issues/795","repository_url":"https://api.github.com/repos/neomake/neomake","labels_url":"https://api.github.com/repos/neomake/neomake/issues/795/labels{/name}","comments_url":"https://api.github.com/repos/neomake/neomake/issues/795/comments","events_url":"https://api.github.com/repos/neomake/neomake/issues/795/events","html_url":"https://github.com/neomake/neomake/pull/795","id":190893718,"number":795,"title":"WIP Go: add gometalinter","user":{"login":"bradleyfalzon","id":1834577,"avatar_url":"https://avatars.githubusercontent.com/u/1834577?v=3","gravatar_id":"","url":"https://api.github.com/users/bradleyfalzon","html_url":"https://github.com/bradleyfalzon","followers_url":"https://api.github.com/users/bradleyfalzon/followers","following_url":"https://api.github.com/users/bradleyfalzon/following{/other_user}","gists_url":"https://api.github.com/users/bradleyfalzon/gists{/gist_id}","starred_url":"https://api.github.com/users/bradleyfalzon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradleyfalzon/subscriptions","organizations_url":"https://api.github.com/users/bradleyfalzon/orgs","repos_url":"https://api.github.com/users/bradleyfalzon/repos","events_url":"https://api.github.com/users/bradleyfalzon/events{/privacy}","received_events_url":"https://api.github.com/users/bradleyfalzon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-22T02:47:27Z","updated_at":"2016-12-20T22:33:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/neomake/neomake/pulls/795","html_url":"https://github.com/neomake/neomake/pull/795","diff_url":"https://github.com/neomake/neomake/pull/795.diff","patch_url":"https://github.com/neomake/neomake/pull/795.patch"},"body":"Go has a quite a number of static analysis tools outside of the standard compiler, lint and vet checks.\r\n\r\nGometalinter help manage (install and update) and standardise the output of the checks to a single format.\r\n\r\nI've added gometalinter support because a user can then use this intermediate tool to enable or disable various checkers/linters themselves without having to further customise neomake.\r\n\r\nWIP:\r\n\r\n- ~I'd like users to be able to adjust the `args` as they see fit, the ones I've proposed show few false positives and usually refer to issues that really do need to be fixed (or have left dead code around and can be safely removed).~ Fixed in ad531ac7473a732b8a7c39b3e02e2e8b88b026ab\r\n- ~Can users disable the gometalinter if they do not want to use it, even though it is installed?~ Yes they can by doing something like `let g:neomake_go_enabled_makers = ['go', 'golint']`\r\n- ~What happens if gometalinter isn't installed, does neomake handle this gracefully?~ Yes it does\r\n- Can someone show me an example commit with a basic test that I could use to help ensure these are tested?\r\n\r\nCurrently the arguments are just my opinion as to what should \r\n\r\nRelates to #235 which also tried to implement the same functionality."},"comment":{"url":"https://api.github.com/repos/neomake/neomake/issues/comments/268378926","html_url":"https://github.com/neomake/neomake/pull/795#issuecomment-268378926","issue_url":"https://api.github.com/repos/neomake/neomake/issues/795","id":268378926,"user":{"login":"tweekmonster","id":111942,"avatar_url":"https://avatars.githubusercontent.com/u/111942?v=3","gravatar_id":"","url":"https://api.github.com/users/tweekmonster","html_url":"https://github.com/tweekmonster","followers_url":"https://api.github.com/users/tweekmonster/followers","following_url":"https://api.github.com/users/tweekmonster/following{/other_user}","gists_url":"https://api.github.com/users/tweekmonster/gists{/gist_id}","starred_url":"https://api.github.com/users/tweekmonster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweekmonster/subscriptions","organizations_url":"https://api.github.com/users/tweekmonster/orgs","repos_url":"https://api.github.com/users/tweekmonster/repos","events_url":"https://api.github.com/users/tweekmonster/events{/privacy}","received_events_url":"https://api.github.com/users/tweekmonster/received_events","type":"User","site_admin":false},"created_at":"2016-12-20T22:33:57Z","updated_at":"2016-12-20T22:33:57Z","body":"> Is there somewhere appropriate I can write some docs about customising these options\r\n\r\nIt might be reasonable to add a section for maker-specific configs just above the FAQ.  Though, Neomake has a lot of configs on its own, so it'll probably get a little long if that section grows.  A new doc file just for maker-specific configs is another option.\r\n\r\nIn either case, it'll be a good idea to add links to that section (or file) at the top of certain sections (`neomake-configuration`, `neomake-options`, etc.) for people still figuring things out.\r\n\r\nThere's a couple makers that probably should have documentation (I'm just mentioning it for posterity, not saying it should be done in this PR).  From a quick grep, it looks like `java`, `d`, `sh`, and `php` have non-standard configs that should be documented as well.  I can't figure out the `sh` variables though.  `g:is_sh` are a strange choice.\r\n\r\n...and after I typed that I find `runtime/filetype.vim` and `runtime/syntax/sh.vim`\r\n\r\n<sup>*`@tweekmonster shakes his fist at the screen`*</sup>"}}
{"actor":{"display_login":"tweekmonster"}}