{"action":"created","issue":{"url":"https://api.github.com/repos/kripken/emscripten/issues/4135","repository_url":"https://api.github.com/repos/kripken/emscripten","labels_url":"https://api.github.com/repos/kripken/emscripten/issues/4135/labels{/name}","comments_url":"https://api.github.com/repos/kripken/emscripten/issues/4135/comments","events_url":"https://api.github.com/repos/kripken/emscripten/issues/4135/events","html_url":"https://github.com/kripken/emscripten/pull/4135","id":137739061,"number":4135,"title":"Make BINARYEN_ROOT a config file setting","user":{"login":"dschuff","id":1122856,"avatar_url":"https://avatars.githubusercontent.com/u/1122856?v=3","gravatar_id":"","url":"https://api.github.com/users/dschuff","html_url":"https://github.com/dschuff","followers_url":"https://api.github.com/users/dschuff/followers","following_url":"https://api.github.com/users/dschuff/following{/other_user}","gists_url":"https://api.github.com/users/dschuff/gists{/gist_id}","starred_url":"https://api.github.com/users/dschuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschuff/subscriptions","organizations_url":"https://api.github.com/users/dschuff/orgs","repos_url":"https://api.github.com/users/dschuff/repos","events_url":"https://api.github.com/users/dschuff/events{/privacy}","received_events_url":"https://api.github.com/users/dschuff/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-03-02T00:57:57Z","updated_at":"2016-03-02T01:41:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/4135","html_url":"https://github.com/kripken/emscripten/pull/4135","diff_url":"https://github.com/kripken/emscripten/pull/4135.diff","patch_url":"https://github.com/kripken/emscripten/pull/4135.patch"},"body":"Currently the BINARYEN -s setting is used both as a flag to enable wasm\r\ncreation with binaryen, and to specify the path. This change keeps -s\r\nBINARYEN=1 to enable binaryen, but moves the path to a setting called\r\nBINARYEN_ROOT in the config file, alongside LLVM_ROOT and\r\nEMSCRIPTEN_ROOT. It also makes the path include the 'bin' directory for\r\nconsistency with those directories."},"comment":{"url":"https://api.github.com/repos/kripken/emscripten/issues/comments/191013024","html_url":"https://github.com/kripken/emscripten/pull/4135#issuecomment-191013024","issue_url":"https://api.github.com/repos/kripken/emscripten/issues/4135","id":191013024,"user":{"login":"dschuff","id":1122856,"avatar_url":"https://avatars.githubusercontent.com/u/1122856?v=3","gravatar_id":"","url":"https://api.github.com/users/dschuff","html_url":"https://github.com/dschuff","followers_url":"https://api.github.com/users/dschuff/followers","following_url":"https://api.github.com/users/dschuff/following{/other_user}","gists_url":"https://api.github.com/users/dschuff/gists{/gist_id}","starred_url":"https://api.github.com/users/dschuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschuff/subscriptions","organizations_url":"https://api.github.com/users/dschuff/orgs","repos_url":"https://api.github.com/users/dschuff/repos","events_url":"https://api.github.com/users/dschuff/events{/privacy}","received_events_url":"https://api.github.com/users/dschuff/received_events","type":"User","site_admin":false},"created_at":"2016-03-02T01:41:13Z","updated_at":"2016-03-02T01:41:13Z","body":"Squashed, and created https://github.com/WebAssembly/binaryen/pull/216"}}