{"action":"created","comment":{"url":"https://api.github.com/repos/ciena-frost/ember-frost-core/pulls/comments/71584261","id":71584261,"diff_hunk":"@@ -1,51 +1,105 @@\n-import Ember from 'ember'\n-import FrostEvents from '../mixins/frost-events'\n import computed from 'ember-computed-decorators'\n+import Ember from 'ember'\n+const {\n+  Component,\n+  isPresent,\n+  on\n+} = Ember\n+import {\n+  task,\n+  timeout\n+} from 'ember-concurrency'\n+import FrostEventsProxy from '../mixins/frost-events-proxy'\n+import layout from '../templates/components/frost-text'\n \n-const {TextField} = Ember\n-const {next, schedule} = Ember.run\n-\n-const svgNs = 'http://www.w3.org/2000/svg'\n-const clearSvg = `\n-  <svg class='frost-text-clear' fill=\"#000000\" height=\"24\" viewBox=\"0 0 24 24\" width=\"24\" xmlns=\"${svgNs}\">\n-    <path d=\"M19 6.41L17.59 5 12 10.59 6.41 5 5 6.41 10.59 12 5 17.59 6.41 19 12 13.41 17.59 19 19 17.59 13.41 12z\"/>\n-    <path d=\"M0 0h24v24H0z\" fill=\"none\"/>\n-  </svg>\n-`\n+export default Component.extend(FrostEventsProxy, {\n \n-export default TextField.extend(FrostEvents, {\n   // == Properties =============================================================\n-  attributeBindings: [\n-    'style'\n-  ],\n+\n+  align: 'left', // TODO PropTypes\n   classNames: [\n     'frost-text'\n   ],\n+  classNameBindings: [\n+    'isClearVisible',\n+    'isClearEnabled'\n+  ],\n+  eventVersion: null, // TODO Deprecation message\n+  isClearEnabled: false, // TODO PropTypes\n+  isClearVisible: false, // TODO PropTypes\n+  layout,\n+  tabindex: 0, // TODO PropTypes\n+  type: 'text', // TODO PropTypes\n+\n+  // == Computed properties  ===================================================\n \n-  // == Computed properties ====================================================\n-  @computed('align')\n-  style (align) {\n-    return Ember.String.htmlSafe(`text-align: ${CSS.escape(align)}`)\n+  @computed('value', '_focused')\n+  isFocusedWithValue (value, _focused) {\n+    return this._focused && isPresent(this.value)\n   },\n \n-  // == Event hooks ============================================================\n+  // == Events =================================================================\n \n-  didInsertElement () {\n-    schedule('render', this, function () {\n-      this.$().after(clearSvg)\n-      next(this, function () {\n-        this.$().next().click(() => {\n-          this.onClear()\n-        })\n+  _focusIn: on('focusIn', function () {\n+    this.set('_focused', true)\n+    this.get('_toggleClear').perform(this.get('isFocusedWithValue'))\n+  }),\n+\n+  _focusOut: on('focusOut', function (event) {\n+    this.set('_focused', false)\n+    this.get('_toggleClear').perform(this.get('isFocusedWithValue'))\n+  }),\n+\n+  _input: on('input', function (event) {\n+    this.get('_toggleClear').perform(this.get('isFocusedWithValue'))\n+  }),\n+\n+  // == Tasks ==================================================================\n+\n+  _toggleClear: task(function * (isVisible) {\n+    if (isVisible) {\n+      this.setProperties({\n+        isClearEnabled: true,\n+        isClearVisible: true\n       })\n-    })\n-  },\n+    } else {\n+      this.set('isClearVisible', false)\n+      yield timeout(200)\n+      this.set('isClearEnabled', false)","path":"addon/components/frost-text.js","position":98,"original_position":98,"commit_id":"46f6db2289f2fce539eb3889161f064ef29d3971","original_commit_id":"46f6db2289f2fce539eb3889161f064ef29d3971","user":{"login":"sandersky","id":422902,"avatar_url":"https://avatars.githubusercontent.com/u/422902?v=3","gravatar_id":"","url":"https://api.github.com/users/sandersky","html_url":"https://github.com/sandersky","followers_url":"https://api.github.com/users/sandersky/followers","following_url":"https://api.github.com/users/sandersky/following{/other_user}","gists_url":"https://api.github.com/users/sandersky/gists{/gist_id}","starred_url":"https://api.github.com/users/sandersky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandersky/subscriptions","organizations_url":"https://api.github.com/users/sandersky/orgs","repos_url":"https://api.github.com/users/sandersky/repos","events_url":"https://api.github.com/users/sandersky/events{/privacy}","received_events_url":"https://api.github.com/users/sandersky/received_events","type":"User","site_admin":false},"body":"What is going on here exactly? Are we hiding the clear button then .2s later we are disabling it?","created_at":"2016-07-20T18:49:50Z","updated_at":"2016-07-20T18:49:50Z","html_url":"https://github.com/ciena-frost/ember-frost-core/pull/147#discussion_r71584261","pull_request_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/pulls/147","_links":{"self":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-core/pulls/comments/71584261"},"html":{"href":"https://github.com/ciena-frost/ember-frost-core/pull/147#discussion_r71584261"},"pull_request":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-core/pulls/147"}}},"pull_request":{"url":"https://api.github.com/repos/ciena-frost/ember-frost-core/pulls/147","id":78183933,"html_url":"https://github.com/ciena-frost/ember-frost-core/pull/147","diff_url":"https://github.com/ciena-frost/ember-frost-core/pull/147.diff","patch_url":"https://github.com/ciena-frost/ember-frost-core/pull/147.patch","issue_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/issues/147","number":147,"state":"open","locked":false,"title":"Updated behavior/events for text/password","user":{"login":"sglanzer","id":9026198,"avatar_url":"https://avatars.githubusercontent.com/u/9026198?v=3","gravatar_id":"","url":"https://api.github.com/users/sglanzer","html_url":"https://github.com/sglanzer","followers_url":"https://api.github.com/users/sglanzer/followers","following_url":"https://api.github.com/users/sglanzer/following{/other_user}","gists_url":"https://api.github.com/users/sglanzer/gists{/gist_id}","starred_url":"https://api.github.com/users/sglanzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sglanzer/subscriptions","organizations_url":"https://api.github.com/users/sglanzer/orgs","repos_url":"https://api.github.com/users/sglanzer/repos","events_url":"https://api.github.com/users/sglanzer/events{/privacy}","received_events_url":"https://api.github.com/users/sglanzer/received_events","type":"User","site_admin":false},"body":"#minor#\r\n\r\nNeeds automated tests, but I wanted to get eyes on and discuss `eventVersion`\r\n\r\nHad to push this up quickly, I'll add a changelog soon","created_at":"2016-07-20T17:07:03Z","updated_at":"2016-07-20T18:49:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96c122a708f55ee7bdad1e522a077133728e01ca","assignee":{"login":"job13er","id":411788,"avatar_url":"https://avatars.githubusercontent.com/u/411788?v=3","gravatar_id":"","url":"https://api.github.com/users/job13er","html_url":"https://github.com/job13er","followers_url":"https://api.github.com/users/job13er/followers","following_url":"https://api.github.com/users/job13er/following{/other_user}","gists_url":"https://api.github.com/users/job13er/gists{/gist_id}","starred_url":"https://api.github.com/users/job13er/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/job13er/subscriptions","organizations_url":"https://api.github.com/users/job13er/orgs","repos_url":"https://api.github.com/users/job13er/repos","events_url":"https://api.github.com/users/job13er/events{/privacy}","received_events_url":"https://api.github.com/users/job13er/received_events","type":"User","site_admin":false},"assignees":[{"login":"job13er","id":411788,"avatar_url":"https://avatars.githubusercontent.com/u/411788?v=3","gravatar_id":"","url":"https://api.github.com/users/job13er","html_url":"https://github.com/job13er","followers_url":"https://api.github.com/users/job13er/followers","following_url":"https://api.github.com/users/job13er/following{/other_user}","gists_url":"https://api.github.com/users/job13er/gists{/gist_id}","starred_url":"https://api.github.com/users/job13er/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/job13er/subscriptions","organizations_url":"https://api.github.com/users/job13er/orgs","repos_url":"https://api.github.com/users/job13er/repos","events_url":"https://api.github.com/users/job13er/events{/privacy}","received_events_url":"https://api.github.com/users/job13er/received_events","type":"User","site_admin":false},{"login":"sandersky","id":422902,"avatar_url":"https://avatars.githubusercontent.com/u/422902?v=3","gravatar_id":"","url":"https://api.github.com/users/sandersky","html_url":"https://github.com/sandersky","followers_url":"https://api.github.com/users/sandersky/followers","following_url":"https://api.github.com/users/sandersky/following{/other_user}","gists_url":"https://api.github.com/users/sandersky/gists{/gist_id}","starred_url":"https://api.github.com/users/sandersky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandersky/subscriptions","organizations_url":"https://api.github.com/users/sandersky/orgs","repos_url":"https://api.github.com/users/sandersky/repos","events_url":"https://api.github.com/users/sandersky/events{/privacy}","received_events_url":"https://api.github.com/users/sandersky/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/pulls/147/commits","review_comments_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/pulls/147/comments","review_comment_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/issues/147/comments","statuses_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/statuses/46f6db2289f2fce539eb3889161f064ef29d3971","head":{"label":"sglanzer:master","ref":"master","sha":"46f6db2289f2fce539eb3889161f064ef29d3971","user":{"login":"sglanzer","id":9026198,"avatar_url":"https://avatars.githubusercontent.com/u/9026198?v=3","gravatar_id":"","url":"https://api.github.com/users/sglanzer","html_url":"https://github.com/sglanzer","followers_url":"https://api.github.com/users/sglanzer/followers","following_url":"https://api.github.com/users/sglanzer/following{/other_user}","gists_url":"https://api.github.com/users/sglanzer/gists{/gist_id}","starred_url":"https://api.github.com/users/sglanzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sglanzer/subscriptions","organizations_url":"https://api.github.com/users/sglanzer/orgs","repos_url":"https://api.github.com/users/sglanzer/repos","events_url":"https://api.github.com/users/sglanzer/events{/privacy}","received_events_url":"https://api.github.com/users/sglanzer/received_events","type":"User","site_admin":false},"repo":{"id":63080107,"name":"ember-frost-core","full_name":"sglanzer/ember-frost-core","owner":{"login":"sglanzer","id":9026198,"avatar_url":"https://avatars.githubusercontent.com/u/9026198?v=3","gravatar_id":"","url":"https://api.github.com/users/sglanzer","html_url":"https://github.com/sglanzer","followers_url":"https://api.github.com/users/sglanzer/followers","following_url":"https://api.github.com/users/sglanzer/following{/other_user}","gists_url":"https://api.github.com/users/sglanzer/gists{/gist_id}","starred_url":"https://api.github.com/users/sglanzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sglanzer/subscriptions","organizations_url":"https://api.github.com/users/sglanzer/orgs","repos_url":"https://api.github.com/users/sglanzer/repos","events_url":"https://api.github.com/users/sglanzer/events{/privacy}","received_events_url":"https://api.github.com/users/sglanzer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sglanzer/ember-frost-core","description":null,"fork":true,"url":"https://api.github.com/repos/sglanzer/ember-frost-core","forks_url":"https://api.github.com/repos/sglanzer/ember-frost-core/forks","keys_url":"https://api.github.com/repos/sglanzer/ember-frost-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sglanzer/ember-frost-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sglanzer/ember-frost-core/teams","hooks_url":"https://api.github.com/repos/sglanzer/ember-frost-core/hooks","issue_events_url":"https://api.github.com/repos/sglanzer/ember-frost-core/issues/events{/number}","events_url":"https://api.github.com/repos/sglanzer/ember-frost-core/events","assignees_url":"https://api.github.com/repos/sglanzer/ember-frost-core/assignees{/user}","branches_url":"https://api.github.com/repos/sglanzer/ember-frost-core/branches{/branch}","tags_url":"https://api.github.com/repos/sglanzer/ember-frost-core/tags","blobs_url":"https://api.github.com/repos/sglanzer/ember-frost-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sglanzer/ember-frost-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sglanzer/ember-frost-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/sglanzer/ember-frost-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sglanzer/ember-frost-core/statuses/{sha}","languages_url":"https://api.github.com/repos/sglanzer/ember-frost-core/languages","stargazers_url":"https://api.github.com/repos/sglanzer/ember-frost-core/stargazers","contributors_url":"https://api.github.com/repos/sglanzer/ember-frost-core/contributors","subscribers_url":"https://api.github.com/repos/sglanzer/ember-frost-core/subscribers","subscription_url":"https://api.github.com/repos/sglanzer/ember-frost-core/subscription","commits_url":"https://api.github.com/repos/sglanzer/ember-frost-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/sglanzer/ember-frost-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/sglanzer/ember-frost-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/sglanzer/ember-frost-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/sglanzer/ember-frost-core/contents/{+path}","compare_url":"https://api.github.com/repos/sglanzer/ember-frost-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sglanzer/ember-frost-core/merges","archive_url":"https://api.github.com/repos/sglanzer/ember-frost-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sglanzer/ember-frost-core/downloads","issues_url":"https://api.github.com/repos/sglanzer/ember-frost-core/issues{/number}","pulls_url":"https://api.github.com/repos/sglanzer/ember-frost-core/pulls{/number}","milestones_url":"https://api.github.com/repos/sglanzer/ember-frost-core/milestones{/number}","notifications_url":"https://api.github.com/repos/sglanzer/ember-frost-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sglanzer/ember-frost-core/labels{/name}","releases_url":"https://api.github.com/repos/sglanzer/ember-frost-core/releases{/id}","deployments_url":"https://api.github.com/repos/sglanzer/ember-frost-core/deployments","created_at":"2016-07-11T15:34:20Z","updated_at":"2016-07-11T15:34:21Z","pushed_at":"2016-07-20T17:22:10Z","git_url":"git://github.com/sglanzer/ember-frost-core.git","ssh_url":"git@github.com:sglanzer/ember-frost-core.git","clone_url":"https://github.com/sglanzer/ember-frost-core.git","svn_url":"https://github.com/sglanzer/ember-frost-core","homepage":"http://ciena-frost.github.io/ember-frost-core/","size":5646,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ciena-frost:master","ref":"master","sha":"c61384c93a889810b10b4e36825a2942438de1d1","user":{"login":"ciena-frost","id":16601148,"avatar_url":"https://avatars.githubusercontent.com/u/16601148?v=3","gravatar_id":"","url":"https://api.github.com/users/ciena-frost","html_url":"https://github.com/ciena-frost","followers_url":"https://api.github.com/users/ciena-frost/followers","following_url":"https://api.github.com/users/ciena-frost/following{/other_user}","gists_url":"https://api.github.com/users/ciena-frost/gists{/gist_id}","starred_url":"https://api.github.com/users/ciena-frost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciena-frost/subscriptions","organizations_url":"https://api.github.com/users/ciena-frost/orgs","repos_url":"https://api.github.com/users/ciena-frost/repos","events_url":"https://api.github.com/users/ciena-frost/events{/privacy}","received_events_url":"https://api.github.com/users/ciena-frost/received_events","type":"Organization","site_admin":false},"repo":{"id":54404273,"name":"ember-frost-core","full_name":"ciena-frost/ember-frost-core","owner":{"login":"ciena-frost","id":16601148,"avatar_url":"https://avatars.githubusercontent.com/u/16601148?v=3","gravatar_id":"","url":"https://api.github.com/users/ciena-frost","html_url":"https://github.com/ciena-frost","followers_url":"https://api.github.com/users/ciena-frost/followers","following_url":"https://api.github.com/users/ciena-frost/following{/other_user}","gists_url":"https://api.github.com/users/ciena-frost/gists{/gist_id}","starred_url":"https://api.github.com/users/ciena-frost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciena-frost/subscriptions","organizations_url":"https://api.github.com/users/ciena-frost/orgs","repos_url":"https://api.github.com/users/ciena-frost/repos","events_url":"https://api.github.com/users/ciena-frost/events{/privacy}","received_events_url":"https://api.github.com/users/ciena-frost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ciena-frost/ember-frost-core","description":"","fork":false,"url":"https://api.github.com/repos/ciena-frost/ember-frost-core","forks_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/forks","keys_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/teams","hooks_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/hooks","issue_events_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/issues/events{/number}","events_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/events","assignees_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/assignees{/user}","branches_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/branches{/branch}","tags_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/tags","blobs_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/statuses/{sha}","languages_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/languages","stargazers_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/stargazers","contributors_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/contributors","subscribers_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/subscribers","subscription_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/subscription","commits_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/contents/{+path}","compare_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/merges","archive_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/downloads","issues_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/issues{/number}","pulls_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/pulls{/number}","milestones_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/milestones{/number}","notifications_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/labels{/name}","releases_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/releases{/id}","deployments_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/deployments","created_at":"2016-03-21T16:15:34Z","updated_at":"2016-07-09T17:41:58Z","pushed_at":"2016-07-20T17:58:20Z","git_url":"git://github.com/ciena-frost/ember-frost-core.git","ssh_url":"git@github.com:ciena-frost/ember-frost-core.git","clone_url":"https://github.com/ciena-frost/ember-frost-core.git","svn_url":"https://github.com/ciena-frost/ember-frost-core","homepage":"http://ciena-frost.github.io/ember-frost-core/","size":6701,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":27,"forks":19,"open_issues":27,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-core/pulls/147"},"html":{"href":"https://github.com/ciena-frost/ember-frost-core/pull/147"},"issue":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-core/issues/147"},"comments":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-core/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-core/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-core/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-core/statuses/46f6db2289f2fce539eb3889161f064ef29d3971"}}}}
{"actor":{"display_login":"sandersky"}}