{"action":"created","comment":{"url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/pulls/comments/86509951","pull_request_review_id":7165484,"id":86509951,"diff_hunk":"@@ -1,100 +0,0 @@\n-/*\n- * Copyright 2016 Red Hat, Inc. and/or its affiliates.\n- *\n- * Licensed under the Apache License, Version 2.0 (the \"License\");\n- * you may not use this file except in compliance with the License.\n- * You may obtain a copy of the License at\n- *\n- *       http://www.apache.org/licenses/LICENSE-2.0\n- *\n- * Unless required by applicable law or agreed to in writing, software\n- * distributed under the License is distributed on an \"AS IS\" BASIS,\n- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n- * See the License for the specific language governing permissions and\n- * limitations under the License.\n- */\n-\n-package org.kie.workbench.common.workbench.client.authz;\n-\n-import javax.enterprise.context.ApplicationScoped;\n-import javax.inject.Inject;\n-\n-import org.guvnor.common.services.project.client.security.ProjectTreeProvider;\n-import org.guvnor.structure.client.security.OrganizationalUnitTreeProvider;\n-import org.guvnor.structure.client.security.RepositoryTreeProvider;\n-import org.kie.workbench.common.workbench.client.resources.i18n.DefaultWorkbenchConstants;\n-import org.uberfire.client.authz.PerspectiveTreeProvider;\n-\n-import static org.kie.workbench.common.workbench.client.PerspectiveIds.*;\n-\n-/**\n- * This is an example of how to customize some of the permission tree nodes.\n- */\n-@ApplicationScoped\n-public class PermissionTreeSetup {\n-\n-    private WorkbenchTreeProvider workbenchTreeProvider;\n-    private PerspectiveTreeProvider perspectiveTreeProvider;\n-    private OrganizationalUnitTreeProvider orgUnitTreeProvider;\n-    private RepositoryTreeProvider repositoryTreeProvider;\n-    private ProjectTreeProvider projectTreeProvider;\n-    private DefaultWorkbenchConstants i18n = DefaultWorkbenchConstants.INSTANCE;\n-\n-    public PermissionTreeSetup() {\n-    }\n-\n-    @Inject\n-    public PermissionTreeSetup(WorkbenchTreeProvider workbenchTreeProvider,\n-                               PerspectiveTreeProvider perspectiveTreeProvider,\n-                               OrganizationalUnitTreeProvider orgUnitTreeProvider,\n-                               RepositoryTreeProvider repositoryTreeProvider,\n-                               ProjectTreeProvider projectTreeProvider) {\n-        this.workbenchTreeProvider = workbenchTreeProvider;\n-        this.perspectiveTreeProvider = perspectiveTreeProvider;\n-        this.orgUnitTreeProvider = orgUnitTreeProvider;\n-        this.repositoryTreeProvider = repositoryTreeProvider;\n-        this.projectTreeProvider = projectTreeProvider;\n-\n-    }\n-\n-    public void configureTree() {\n-        perspectiveTreeProvider.setPerspectiveName(HOME, i18n.HomePage());","path":"kie-wb-common-screens/kie-wb-common-workbench/kie-wb-common-workbench-client/src/main/java/org/kie/workbench/common/workbench/client/authz/PermissionTreeSetup.java","position":61,"original_position":61,"commit_id":"95e9c6571138fe263a718524f264af4e38097299","original_commit_id":"95e9c6571138fe263a718524f264af4e38097299","user":{"login":"wmedvede","id":2431454,"avatar_url":"https://avatars.githubusercontent.com/u/2431454?v=3","gravatar_id":"","url":"https://api.github.com/users/wmedvede","html_url":"https://github.com/wmedvede","followers_url":"https://api.github.com/users/wmedvede/followers","following_url":"https://api.github.com/users/wmedvede/following{/other_user}","gists_url":"https://api.github.com/users/wmedvede/gists{/gist_id}","starred_url":"https://api.github.com/users/wmedvede/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmedvede/subscriptions","organizations_url":"https://api.github.com/users/wmedvede/orgs","repos_url":"https://api.github.com/users/wmedvede/repos","events_url":"https://api.github.com/users/wmedvede/events{/privacy}","received_events_url":"https://api.github.com/users/wmedvede/received_events","type":"User","site_admin":false},"body":"Hello @mcimbora , sorry I haven't seen that you moved this permissions setup to kie-wb-distributions.\r\nI believe that I can make sense, but I see that introduces a duplication of the Permissions setup both in kie-wb, and kie-drools-wb. I'm not saying this is wrong, but I'd prefer that @manstis and @dgutierr takes a look at it.","created_at":"2016-11-04T09:23:25Z","updated_at":"2016-11-04T09:23:25Z","html_url":"https://github.com/droolsjbpm/kie-wb-common/pull/540#discussion_r86509951","pull_request_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/pulls/540","_links":{"self":{"href":"https://api.github.com/repos/droolsjbpm/kie-wb-common/pulls/comments/86509951"},"html":{"href":"https://github.com/droolsjbpm/kie-wb-common/pull/540#discussion_r86509951"},"pull_request":{"href":"https://api.github.com/repos/droolsjbpm/kie-wb-common/pulls/540"}}},"pull_request":{"url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/pulls/540","id":92162315,"html_url":"https://github.com/droolsjbpm/kie-wb-common/pull/540","diff_url":"https://github.com/droolsjbpm/kie-wb-common/pull/540.diff","patch_url":"https://github.com/droolsjbpm/kie-wb-common/pull/540.patch","issue_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/issues/540","number":540,"state":"open","locked":false,"title":"PLANNER-686: Workbench: Move Planner-specific code from kie-wb-common to optaplanner-wb","user":{"login":"mcimbora","id":4274233,"avatar_url":"https://avatars.githubusercontent.com/u/4274233?v=3","gravatar_id":"","url":"https://api.github.com/users/mcimbora","html_url":"https://github.com/mcimbora","followers_url":"https://api.github.com/users/mcimbora/followers","following_url":"https://api.github.com/users/mcimbora/following{/other_user}","gists_url":"https://api.github.com/users/mcimbora/gists{/gist_id}","starred_url":"https://api.github.com/users/mcimbora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcimbora/subscriptions","organizations_url":"https://api.github.com/users/mcimbora/orgs","repos_url":"https://api.github.com/users/mcimbora/repos","events_url":"https://api.github.com/users/mcimbora/events{/privacy}","received_events_url":"https://api.github.com/users/mcimbora/received_events","type":"User","site_admin":false},"body":"Move PermissionTreeSetup & WorkbenchTreeProvider classes to kie-wb, as they directly reference downstream content (Planner).","created_at":"2016-11-03T14:19:17Z","updated_at":"2016-11-04T09:23:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a115b56568131766ad496fc5753f5093b54e792","assignee":{"login":"ederign","id":531351,"avatar_url":"https://avatars.githubusercontent.com/u/531351?v=3","gravatar_id":"","url":"https://api.github.com/users/ederign","html_url":"https://github.com/ederign","followers_url":"https://api.github.com/users/ederign/followers","following_url":"https://api.github.com/users/ederign/following{/other_user}","gists_url":"https://api.github.com/users/ederign/gists{/gist_id}","starred_url":"https://api.github.com/users/ederign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ederign/subscriptions","organizations_url":"https://api.github.com/users/ederign/orgs","repos_url":"https://api.github.com/users/ederign/repos","events_url":"https://api.github.com/users/ederign/events{/privacy}","received_events_url":"https://api.github.com/users/ederign/received_events","type":"User","site_admin":false},"assignees":[{"login":"ederign","id":531351,"avatar_url":"https://avatars.githubusercontent.com/u/531351?v=3","gravatar_id":"","url":"https://api.github.com/users/ederign","html_url":"https://github.com/ederign","followers_url":"https://api.github.com/users/ederign/followers","following_url":"https://api.github.com/users/ederign/following{/other_user}","gists_url":"https://api.github.com/users/ederign/gists{/gist_id}","starred_url":"https://api.github.com/users/ederign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ederign/subscriptions","organizations_url":"https://api.github.com/users/ederign/orgs","repos_url":"https://api.github.com/users/ederign/repos","events_url":"https://api.github.com/users/ederign/events{/privacy}","received_events_url":"https://api.github.com/users/ederign/received_events","type":"User","site_admin":false},{"login":"wmedvede","id":2431454,"avatar_url":"https://avatars.githubusercontent.com/u/2431454?v=3","gravatar_id":"","url":"https://api.github.com/users/wmedvede","html_url":"https://github.com/wmedvede","followers_url":"https://api.github.com/users/wmedvede/followers","following_url":"https://api.github.com/users/wmedvede/following{/other_user}","gists_url":"https://api.github.com/users/wmedvede/gists{/gist_id}","starred_url":"https://api.github.com/users/wmedvede/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmedvede/subscriptions","organizations_url":"https://api.github.com/users/wmedvede/orgs","repos_url":"https://api.github.com/users/wmedvede/repos","events_url":"https://api.github.com/users/wmedvede/events{/privacy}","received_events_url":"https://api.github.com/users/wmedvede/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/pulls/540/commits","review_comments_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/pulls/540/comments","review_comment_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/issues/540/comments","statuses_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/statuses/95e9c6571138fe263a718524f264af4e38097299","head":{"label":"mcimbora:PLANNER-686","ref":"PLANNER-686","sha":"95e9c6571138fe263a718524f264af4e38097299","user":{"login":"mcimbora","id":4274233,"avatar_url":"https://avatars.githubusercontent.com/u/4274233?v=3","gravatar_id":"","url":"https://api.github.com/users/mcimbora","html_url":"https://github.com/mcimbora","followers_url":"https://api.github.com/users/mcimbora/followers","following_url":"https://api.github.com/users/mcimbora/following{/other_user}","gists_url":"https://api.github.com/users/mcimbora/gists{/gist_id}","starred_url":"https://api.github.com/users/mcimbora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcimbora/subscriptions","organizations_url":"https://api.github.com/users/mcimbora/orgs","repos_url":"https://api.github.com/users/mcimbora/repos","events_url":"https://api.github.com/users/mcimbora/events{/privacy}","received_events_url":"https://api.github.com/users/mcimbora/received_events","type":"User","site_admin":false},"repo":{"id":63786253,"name":"kie-wb-common","full_name":"mcimbora/kie-wb-common","owner":{"login":"mcimbora","id":4274233,"avatar_url":"https://avatars.githubusercontent.com/u/4274233?v=3","gravatar_id":"","url":"https://api.github.com/users/mcimbora","html_url":"https://github.com/mcimbora","followers_url":"https://api.github.com/users/mcimbora/followers","following_url":"https://api.github.com/users/mcimbora/following{/other_user}","gists_url":"https://api.github.com/users/mcimbora/gists{/gist_id}","starred_url":"https://api.github.com/users/mcimbora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcimbora/subscriptions","organizations_url":"https://api.github.com/users/mcimbora/orgs","repos_url":"https://api.github.com/users/mcimbora/repos","events_url":"https://api.github.com/users/mcimbora/events{/privacy}","received_events_url":"https://api.github.com/users/mcimbora/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcimbora/kie-wb-common","description":"Shared screens, widgets and services for KIE workbenches.","fork":true,"url":"https://api.github.com/repos/mcimbora/kie-wb-common","forks_url":"https://api.github.com/repos/mcimbora/kie-wb-common/forks","keys_url":"https://api.github.com/repos/mcimbora/kie-wb-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcimbora/kie-wb-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcimbora/kie-wb-common/teams","hooks_url":"https://api.github.com/repos/mcimbora/kie-wb-common/hooks","issue_events_url":"https://api.github.com/repos/mcimbora/kie-wb-common/issues/events{/number}","events_url":"https://api.github.com/repos/mcimbora/kie-wb-common/events","assignees_url":"https://api.github.com/repos/mcimbora/kie-wb-common/assignees{/user}","branches_url":"https://api.github.com/repos/mcimbora/kie-wb-common/branches{/branch}","tags_url":"https://api.github.com/repos/mcimbora/kie-wb-common/tags","blobs_url":"https://api.github.com/repos/mcimbora/kie-wb-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcimbora/kie-wb-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcimbora/kie-wb-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcimbora/kie-wb-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcimbora/kie-wb-common/statuses/{sha}","languages_url":"https://api.github.com/repos/mcimbora/kie-wb-common/languages","stargazers_url":"https://api.github.com/repos/mcimbora/kie-wb-common/stargazers","contributors_url":"https://api.github.com/repos/mcimbora/kie-wb-common/contributors","subscribers_url":"https://api.github.com/repos/mcimbora/kie-wb-common/subscribers","subscription_url":"https://api.github.com/repos/mcimbora/kie-wb-common/subscription","commits_url":"https://api.github.com/repos/mcimbora/kie-wb-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcimbora/kie-wb-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcimbora/kie-wb-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcimbora/kie-wb-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcimbora/kie-wb-common/contents/{+path}","compare_url":"https://api.github.com/repos/mcimbora/kie-wb-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcimbora/kie-wb-common/merges","archive_url":"https://api.github.com/repos/mcimbora/kie-wb-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcimbora/kie-wb-common/downloads","issues_url":"https://api.github.com/repos/mcimbora/kie-wb-common/issues{/number}","pulls_url":"https://api.github.com/repos/mcimbora/kie-wb-common/pulls{/number}","milestones_url":"https://api.github.com/repos/mcimbora/kie-wb-common/milestones{/number}","notifications_url":"https://api.github.com/repos/mcimbora/kie-wb-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcimbora/kie-wb-common/labels{/name}","releases_url":"https://api.github.com/repos/mcimbora/kie-wb-common/releases{/id}","deployments_url":"https://api.github.com/repos/mcimbora/kie-wb-common/deployments","created_at":"2016-07-20T14:04:09Z","updated_at":"2016-07-20T14:04:18Z","pushed_at":"2016-11-03T14:54:49Z","git_url":"git://github.com/mcimbora/kie-wb-common.git","ssh_url":"git@github.com:mcimbora/kie-wb-common.git","clone_url":"https://github.com/mcimbora/kie-wb-common.git","svn_url":"https://github.com/mcimbora/kie-wb-common","homepage":"","size":17436,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"droolsjbpm:master","ref":"master","sha":"910e8a3a07ebcdcab28c0f245e6a7ff91e1c5532","user":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"repo":{"id":10522120,"name":"kie-wb-common","full_name":"droolsjbpm/kie-wb-common","owner":{"login":"droolsjbpm","id":517980,"avatar_url":"https://avatars.githubusercontent.com/u/517980?v=3","gravatar_id":"","url":"https://api.github.com/users/droolsjbpm","html_url":"https://github.com/droolsjbpm","followers_url":"https://api.github.com/users/droolsjbpm/followers","following_url":"https://api.github.com/users/droolsjbpm/following{/other_user}","gists_url":"https://api.github.com/users/droolsjbpm/gists{/gist_id}","starred_url":"https://api.github.com/users/droolsjbpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droolsjbpm/subscriptions","organizations_url":"https://api.github.com/users/droolsjbpm/orgs","repos_url":"https://api.github.com/users/droolsjbpm/repos","events_url":"https://api.github.com/users/droolsjbpm/events{/privacy}","received_events_url":"https://api.github.com/users/droolsjbpm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/droolsjbpm/kie-wb-common","description":"Shared screens, widgets and services for KIE workbenches.","fork":false,"url":"https://api.github.com/repos/droolsjbpm/kie-wb-common","forks_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/forks","keys_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/teams","hooks_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/hooks","issue_events_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/issues/events{/number}","events_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/events","assignees_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/assignees{/user}","branches_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/branches{/branch}","tags_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/tags","blobs_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/statuses/{sha}","languages_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/languages","stargazers_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/stargazers","contributors_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/contributors","subscribers_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/subscribers","subscription_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/subscription","commits_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/contents/{+path}","compare_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/merges","archive_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/downloads","issues_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/issues{/number}","pulls_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/pulls{/number}","milestones_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/milestones{/number}","notifications_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/labels{/name}","releases_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/releases{/id}","deployments_url":"https://api.github.com/repos/droolsjbpm/kie-wb-common/deployments","created_at":"2013-06-06T08:32:03Z","updated_at":"2016-10-24T14:30:36Z","pushed_at":"2016-11-04T06:28:38Z","git_url":"git://github.com/droolsjbpm/kie-wb-common.git","ssh_url":"git@github.com:droolsjbpm/kie-wb-common.git","clone_url":"https://github.com/droolsjbpm/kie-wb-common.git","svn_url":"https://github.com/droolsjbpm/kie-wb-common","homepage":"","size":19502,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":4,"forks":99,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/droolsjbpm/kie-wb-common/pulls/540"},"html":{"href":"https://github.com/droolsjbpm/kie-wb-common/pull/540"},"issue":{"href":"https://api.github.com/repos/droolsjbpm/kie-wb-common/issues/540"},"comments":{"href":"https://api.github.com/repos/droolsjbpm/kie-wb-common/issues/540/comments"},"review_comments":{"href":"https://api.github.com/repos/droolsjbpm/kie-wb-common/pulls/540/comments"},"review_comment":{"href":"https://api.github.com/repos/droolsjbpm/kie-wb-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/droolsjbpm/kie-wb-common/pulls/540/commits"},"statuses":{"href":"https://api.github.com/repos/droolsjbpm/kie-wb-common/statuses/95e9c6571138fe263a718524f264af4e38097299"}}}}
{"actor":{"display_login":"wmedvede"}}