{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/shineware/aho-corasick/pulls/4","id":95855476,"html_url":"https://github.com/shineware/aho-corasick/pull/4","diff_url":"https://github.com/shineware/aho-corasick/pull/4.diff","patch_url":"https://github.com/shineware/aho-corasick/pull/4.patch","issue_url":"https://api.github.com/repos/shineware/aho-corasick/issues/4","number":4,"state":"closed","locked":false,"title":"Avoid returning nulls when the result is not found","user":{"login":"jihoonson","id":2322288,"avatar_url":"https://avatars.githubusercontent.com/u/2322288?v=3","gravatar_id":"","url":"https://api.github.com/users/jihoonson","html_url":"https://github.com/jihoonson","followers_url":"https://api.github.com/users/jihoonson/followers","following_url":"https://api.github.com/users/jihoonson/following{/other_user}","gists_url":"https://api.github.com/users/jihoonson/gists{/gist_id}","starred_url":"https://api.github.com/users/jihoonson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihoonson/subscriptions","organizations_url":"https://api.github.com/users/jihoonson/orgs","repos_url":"https://api.github.com/users/jihoonson/repos","events_url":"https://api.github.com/users/jihoonson/events{/privacy}","received_events_url":"https://api.github.com/users/jihoonson/received_events","type":"User","site_admin":false},"body":"get() 함수에서 결과를 찾지 못하였을 때 null을 리턴하는 것을 빈 map을 리턴하도록 수정하였습니다. 그 이유는 다음과 같습니다.\r\n\r\n* 내부 에러가 발생했을 때 null을, 결과가 없을 때 빈 map을 리턴함으로써 에러가 발생한 케이스와 정상적으로 동작하였지만 결과가 없는 경우를 구분할 수 있습니다.\r\n* null은 실수로 NullPointerException을 일으키기 쉽기 때문에 사용하지 않는 편이 좋다고 생각합니다.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/shineware/aho-corasick/4)\n<!-- Reviewable:end -->\n","created_at":"2016-11-30T09:30:16Z","updated_at":"2016-12-19T16:01:32Z","closed_at":"2016-12-19T16:01:32Z","merged_at":"2016-12-19T16:01:32Z","merge_commit_sha":"60fd6d6a01b5b8b08f72e34f751e8f77f34b13cc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/shineware/aho-corasick/pulls/4/commits","review_comments_url":"https://api.github.com/repos/shineware/aho-corasick/pulls/4/comments","review_comment_url":"https://api.github.com/repos/shineware/aho-corasick/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shineware/aho-corasick/issues/4/comments","statuses_url":"https://api.github.com/repos/shineware/aho-corasick/statuses/cb6aa9afd01991af8813a27294332ebf5cc8e00a","head":{"label":"jihoonson:feature/avoid_null","ref":"feature/avoid_null","sha":"cb6aa9afd01991af8813a27294332ebf5cc8e00a","user":{"login":"jihoonson","id":2322288,"avatar_url":"https://avatars.githubusercontent.com/u/2322288?v=3","gravatar_id":"","url":"https://api.github.com/users/jihoonson","html_url":"https://github.com/jihoonson","followers_url":"https://api.github.com/users/jihoonson/followers","following_url":"https://api.github.com/users/jihoonson/following{/other_user}","gists_url":"https://api.github.com/users/jihoonson/gists{/gist_id}","starred_url":"https://api.github.com/users/jihoonson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihoonson/subscriptions","organizations_url":"https://api.github.com/users/jihoonson/orgs","repos_url":"https://api.github.com/users/jihoonson/repos","events_url":"https://api.github.com/users/jihoonson/events{/privacy}","received_events_url":"https://api.github.com/users/jihoonson/received_events","type":"User","site_admin":false},"repo":{"id":74326754,"name":"aho-corasick","full_name":"jihoonson/aho-corasick","owner":{"login":"jihoonson","id":2322288,"avatar_url":"https://avatars.githubusercontent.com/u/2322288?v=3","gravatar_id":"","url":"https://api.github.com/users/jihoonson","html_url":"https://github.com/jihoonson","followers_url":"https://api.github.com/users/jihoonson/followers","following_url":"https://api.github.com/users/jihoonson/following{/other_user}","gists_url":"https://api.github.com/users/jihoonson/gists{/gist_id}","starred_url":"https://api.github.com/users/jihoonson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihoonson/subscriptions","organizations_url":"https://api.github.com/users/jihoonson/orgs","repos_url":"https://api.github.com/users/jihoonson/repos","events_url":"https://api.github.com/users/jihoonson/events{/privacy}","received_events_url":"https://api.github.com/users/jihoonson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jihoonson/aho-corasick","description":null,"fork":true,"url":"https://api.github.com/repos/jihoonson/aho-corasick","forks_url":"https://api.github.com/repos/jihoonson/aho-corasick/forks","keys_url":"https://api.github.com/repos/jihoonson/aho-corasick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jihoonson/aho-corasick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jihoonson/aho-corasick/teams","hooks_url":"https://api.github.com/repos/jihoonson/aho-corasick/hooks","issue_events_url":"https://api.github.com/repos/jihoonson/aho-corasick/issues/events{/number}","events_url":"https://api.github.com/repos/jihoonson/aho-corasick/events","assignees_url":"https://api.github.com/repos/jihoonson/aho-corasick/assignees{/user}","branches_url":"https://api.github.com/repos/jihoonson/aho-corasick/branches{/branch}","tags_url":"https://api.github.com/repos/jihoonson/aho-corasick/tags","blobs_url":"https://api.github.com/repos/jihoonson/aho-corasick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jihoonson/aho-corasick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jihoonson/aho-corasick/git/refs{/sha}","trees_url":"https://api.github.com/repos/jihoonson/aho-corasick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jihoonson/aho-corasick/statuses/{sha}","languages_url":"https://api.github.com/repos/jihoonson/aho-corasick/languages","stargazers_url":"https://api.github.com/repos/jihoonson/aho-corasick/stargazers","contributors_url":"https://api.github.com/repos/jihoonson/aho-corasick/contributors","subscribers_url":"https://api.github.com/repos/jihoonson/aho-corasick/subscribers","subscription_url":"https://api.github.com/repos/jihoonson/aho-corasick/subscription","commits_url":"https://api.github.com/repos/jihoonson/aho-corasick/commits{/sha}","git_commits_url":"https://api.github.com/repos/jihoonson/aho-corasick/git/commits{/sha}","comments_url":"https://api.github.com/repos/jihoonson/aho-corasick/comments{/number}","issue_comment_url":"https://api.github.com/repos/jihoonson/aho-corasick/issues/comments{/number}","contents_url":"https://api.github.com/repos/jihoonson/aho-corasick/contents/{+path}","compare_url":"https://api.github.com/repos/jihoonson/aho-corasick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jihoonson/aho-corasick/merges","archive_url":"https://api.github.com/repos/jihoonson/aho-corasick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jihoonson/aho-corasick/downloads","issues_url":"https://api.github.com/repos/jihoonson/aho-corasick/issues{/number}","pulls_url":"https://api.github.com/repos/jihoonson/aho-corasick/pulls{/number}","milestones_url":"https://api.github.com/repos/jihoonson/aho-corasick/milestones{/number}","notifications_url":"https://api.github.com/repos/jihoonson/aho-corasick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jihoonson/aho-corasick/labels{/name}","releases_url":"https://api.github.com/repos/jihoonson/aho-corasick/releases{/id}","deployments_url":"https://api.github.com/repos/jihoonson/aho-corasick/deployments","created_at":"2016-11-21T04:41:13Z","updated_at":"2016-11-21T04:41:14Z","pushed_at":"2016-11-30T09:27:07Z","git_url":"git://github.com/jihoonson/aho-corasick.git","ssh_url":"git@github.com:jihoonson/aho-corasick.git","clone_url":"https://github.com/jihoonson/aho-corasick.git","svn_url":"https://github.com/jihoonson/aho-corasick","homepage":null,"size":71,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"shineware:master","ref":"master","sha":"74c1fab9ecef7baa77dd8a76e959cc5fe620c03e","user":{"login":"shineware","id":8969216,"avatar_url":"https://avatars.githubusercontent.com/u/8969216?v=3","gravatar_id":"","url":"https://api.github.com/users/shineware","html_url":"https://github.com/shineware","followers_url":"https://api.github.com/users/shineware/followers","following_url":"https://api.github.com/users/shineware/following{/other_user}","gists_url":"https://api.github.com/users/shineware/gists{/gist_id}","starred_url":"https://api.github.com/users/shineware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shineware/subscriptions","organizations_url":"https://api.github.com/users/shineware/orgs","repos_url":"https://api.github.com/users/shineware/repos","events_url":"https://api.github.com/users/shineware/events{/privacy}","received_events_url":"https://api.github.com/users/shineware/received_events","type":"Organization","site_admin":false},"repo":{"id":56250688,"name":"aho-corasick","full_name":"shineware/aho-corasick","owner":{"login":"shineware","id":8969216,"avatar_url":"https://avatars.githubusercontent.com/u/8969216?v=3","gravatar_id":"","url":"https://api.github.com/users/shineware","html_url":"https://github.com/shineware","followers_url":"https://api.github.com/users/shineware/followers","following_url":"https://api.github.com/users/shineware/following{/other_user}","gists_url":"https://api.github.com/users/shineware/gists{/gist_id}","starred_url":"https://api.github.com/users/shineware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shineware/subscriptions","organizations_url":"https://api.github.com/users/shineware/orgs","repos_url":"https://api.github.com/users/shineware/repos","events_url":"https://api.github.com/users/shineware/events{/privacy}","received_events_url":"https://api.github.com/users/shineware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shineware/aho-corasick","description":null,"fork":false,"url":"https://api.github.com/repos/shineware/aho-corasick","forks_url":"https://api.github.com/repos/shineware/aho-corasick/forks","keys_url":"https://api.github.com/repos/shineware/aho-corasick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shineware/aho-corasick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shineware/aho-corasick/teams","hooks_url":"https://api.github.com/repos/shineware/aho-corasick/hooks","issue_events_url":"https://api.github.com/repos/shineware/aho-corasick/issues/events{/number}","events_url":"https://api.github.com/repos/shineware/aho-corasick/events","assignees_url":"https://api.github.com/repos/shineware/aho-corasick/assignees{/user}","branches_url":"https://api.github.com/repos/shineware/aho-corasick/branches{/branch}","tags_url":"https://api.github.com/repos/shineware/aho-corasick/tags","blobs_url":"https://api.github.com/repos/shineware/aho-corasick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shineware/aho-corasick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shineware/aho-corasick/git/refs{/sha}","trees_url":"https://api.github.com/repos/shineware/aho-corasick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shineware/aho-corasick/statuses/{sha}","languages_url":"https://api.github.com/repos/shineware/aho-corasick/languages","stargazers_url":"https://api.github.com/repos/shineware/aho-corasick/stargazers","contributors_url":"https://api.github.com/repos/shineware/aho-corasick/contributors","subscribers_url":"https://api.github.com/repos/shineware/aho-corasick/subscribers","subscription_url":"https://api.github.com/repos/shineware/aho-corasick/subscription","commits_url":"https://api.github.com/repos/shineware/aho-corasick/commits{/sha}","git_commits_url":"https://api.github.com/repos/shineware/aho-corasick/git/commits{/sha}","comments_url":"https://api.github.com/repos/shineware/aho-corasick/comments{/number}","issue_comment_url":"https://api.github.com/repos/shineware/aho-corasick/issues/comments{/number}","contents_url":"https://api.github.com/repos/shineware/aho-corasick/contents/{+path}","compare_url":"https://api.github.com/repos/shineware/aho-corasick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shineware/aho-corasick/merges","archive_url":"https://api.github.com/repos/shineware/aho-corasick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shineware/aho-corasick/downloads","issues_url":"https://api.github.com/repos/shineware/aho-corasick/issues{/number}","pulls_url":"https://api.github.com/repos/shineware/aho-corasick/pulls{/number}","milestones_url":"https://api.github.com/repos/shineware/aho-corasick/milestones{/number}","notifications_url":"https://api.github.com/repos/shineware/aho-corasick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shineware/aho-corasick/labels{/name}","releases_url":"https://api.github.com/repos/shineware/aho-corasick/releases{/id}","deployments_url":"https://api.github.com/repos/shineware/aho-corasick/deployments","created_at":"2016-04-14T15:53:46Z","updated_at":"2016-11-22T05:11:01Z","pushed_at":"2016-12-19T16:01:32Z","git_url":"git://github.com/shineware/aho-corasick.git","ssh_url":"git@github.com:shineware/aho-corasick.git","clone_url":"https://github.com/shineware/aho-corasick.git","svn_url":"https://github.com/shineware/aho-corasick","homepage":null,"size":70,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shineware/aho-corasick/pulls/4"},"html":{"href":"https://github.com/shineware/aho-corasick/pull/4"},"issue":{"href":"https://api.github.com/repos/shineware/aho-corasick/issues/4"},"comments":{"href":"https://api.github.com/repos/shineware/aho-corasick/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/shineware/aho-corasick/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/shineware/aho-corasick/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shineware/aho-corasick/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/shineware/aho-corasick/statuses/cb6aa9afd01991af8813a27294332ebf5cc8e00a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"shin285","id":8907756,"avatar_url":"https://avatars.githubusercontent.com/u/8907756?v=3","gravatar_id":"","url":"https://api.github.com/users/shin285","html_url":"https://github.com/shin285","followers_url":"https://api.github.com/users/shin285/followers","following_url":"https://api.github.com/users/shin285/following{/other_user}","gists_url":"https://api.github.com/users/shin285/gists{/gist_id}","starred_url":"https://api.github.com/users/shin285/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shin285/subscriptions","organizations_url":"https://api.github.com/users/shin285/orgs","repos_url":"https://api.github.com/users/shin285/repos","events_url":"https://api.github.com/users/shin285/events{/privacy}","received_events_url":"https://api.github.com/users/shin285/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":99,"deletions":65,"changed_files":3}}
{"actor":{"display_login":"shin285"}}