{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/comments/76683108","id":76683108,"diff_hunk":"@@ -198,7 +198,7 @@ export abstract class Filter {\n     this.target = target;\n   }\n \n-  toJSON(): IFilter {\n+  toJSON(): any {","path":"src/models.ts","position":41,"original_position":41,"commit_id":"158de0fccb526902b96bbee5fc552d8ecc1434ad","original_commit_id":"158de0fccb526902b96bbee5fc552d8ecc1434ad","user":{"login":"wbreza","id":6540159,"avatar_url":"https://avatars.githubusercontent.com/u/6540159?v=3","gravatar_id":"","url":"https://api.github.com/users/wbreza","html_url":"https://github.com/wbreza","followers_url":"https://api.github.com/users/wbreza/followers","following_url":"https://api.github.com/users/wbreza/following{/other_user}","gists_url":"https://api.github.com/users/wbreza/gists{/gist_id}","starred_url":"https://api.github.com/users/wbreza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbreza/subscriptions","organizations_url":"https://api.github.com/users/wbreza/orgs","repos_url":"https://api.github.com/users/wbreza/repos","events_url":"https://api.github.com/users/wbreza/events{/privacy}","received_events_url":"https://api.github.com/users/wbreza/received_events","type":"User","site_admin":false},"body":"Thoughts on this change?  You can't return a type.  Looks like this is only used internally by the implementations of basic filters & advanced filter so should be OK.","created_at":"2016-08-29T20:42:49Z","updated_at":"2016-08-29T20:42:49Z","html_url":"https://github.com/Microsoft/powerbi-models/pull/11#discussion_r76683108","pull_request_url":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/comments/76683108"},"html":{"href":"https://github.com/Microsoft/powerbi-models/pull/11#discussion_r76683108"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/11","id":83164023,"html_url":"https://github.com/Microsoft/powerbi-models/pull/11","diff_url":"https://github.com/Microsoft/powerbi-models/pull/11.diff","patch_url":"https://github.com/Microsoft/powerbi-models/pull/11.patch","issue_url":"https://api.github.com/repos/Microsoft/powerbi-models/issues/11","number":11,"state":"open","locked":false,"title":"Migrated IFilter to a type vs an interface","user":{"login":"wbreza","id":6540159,"avatar_url":"https://avatars.githubusercontent.com/u/6540159?v=3","gravatar_id":"","url":"https://api.github.com/users/wbreza","html_url":"https://github.com/wbreza","followers_url":"https://api.github.com/users/wbreza/followers","following_url":"https://api.github.com/users/wbreza/following{/other_user}","gists_url":"https://api.github.com/users/wbreza/gists{/gist_id}","starred_url":"https://api.github.com/users/wbreza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbreza/subscriptions","organizations_url":"https://api.github.com/users/wbreza/orgs","repos_url":"https://api.github.com/users/wbreza/repos","events_url":"https://api.github.com/users/wbreza/events{/privacy}","received_events_url":"https://api.github.com/users/wbreza/received_events","type":"User","site_admin":false},"body":"Moved IFilter to a declared type vs an interface.","created_at":"2016-08-29T20:42:04Z","updated_at":"2016-08-29T20:42:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44077485c5f56be95f4440db378b2679beba4ae0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/11/commits","review_comments_url":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/11/comments","review_comment_url":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/powerbi-models/issues/11/comments","statuses_url":"https://api.github.com/repos/Microsoft/powerbi-models/statuses/158de0fccb526902b96bbee5fc552d8ecc1434ad","head":{"label":"Microsoft:wabreza/ifilter-updates","ref":"wabreza/ifilter-updates","sha":"158de0fccb526902b96bbee5fc552d8ecc1434ad","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":61827494,"name":"powerbi-models","full_name":"Microsoft/powerbi-models","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/powerbi-models","description":"Contains JavaScript & TypeScript object models for Microsoft Power BI JavaScript SDK","fork":false,"url":"https://api.github.com/repos/Microsoft/powerbi-models","forks_url":"https://api.github.com/repos/Microsoft/powerbi-models/forks","keys_url":"https://api.github.com/repos/Microsoft/powerbi-models/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/powerbi-models/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/powerbi-models/teams","hooks_url":"https://api.github.com/repos/Microsoft/powerbi-models/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/powerbi-models/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/powerbi-models/events","assignees_url":"https://api.github.com/repos/Microsoft/powerbi-models/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/powerbi-models/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/powerbi-models/tags","blobs_url":"https://api.github.com/repos/Microsoft/powerbi-models/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/powerbi-models/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/powerbi-models/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/powerbi-models/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/powerbi-models/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/powerbi-models/languages","stargazers_url":"https://api.github.com/repos/Microsoft/powerbi-models/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/powerbi-models/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/powerbi-models/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/powerbi-models/subscription","commits_url":"https://api.github.com/repos/Microsoft/powerbi-models/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/powerbi-models/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/powerbi-models/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/powerbi-models/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/powerbi-models/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/powerbi-models/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/powerbi-models/merges","archive_url":"https://api.github.com/repos/Microsoft/powerbi-models/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/powerbi-models/downloads","issues_url":"https://api.github.com/repos/Microsoft/powerbi-models/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/powerbi-models/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/powerbi-models/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/powerbi-models/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/powerbi-models/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/powerbi-models/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/powerbi-models/deployments","created_at":"2016-06-23T18:25:47Z","updated_at":"2016-08-27T23:56:01Z","pushed_at":"2016-08-29T20:42:05Z","git_url":"git://github.com/Microsoft/powerbi-models.git","ssh_url":"git@github.com:Microsoft/powerbi-models.git","clone_url":"https://github.com/Microsoft/powerbi-models.git","svn_url":"https://github.com/Microsoft/powerbi-models","homepage":"https://microsoft.github.io/powerbi-models/","size":233,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"141fdfa96198b92937d439579eab2ee56b631853","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":61827494,"name":"powerbi-models","full_name":"Microsoft/powerbi-models","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/powerbi-models","description":"Contains JavaScript & TypeScript object models for Microsoft Power BI JavaScript SDK","fork":false,"url":"https://api.github.com/repos/Microsoft/powerbi-models","forks_url":"https://api.github.com/repos/Microsoft/powerbi-models/forks","keys_url":"https://api.github.com/repos/Microsoft/powerbi-models/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/powerbi-models/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/powerbi-models/teams","hooks_url":"https://api.github.com/repos/Microsoft/powerbi-models/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/powerbi-models/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/powerbi-models/events","assignees_url":"https://api.github.com/repos/Microsoft/powerbi-models/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/powerbi-models/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/powerbi-models/tags","blobs_url":"https://api.github.com/repos/Microsoft/powerbi-models/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/powerbi-models/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/powerbi-models/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/powerbi-models/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/powerbi-models/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/powerbi-models/languages","stargazers_url":"https://api.github.com/repos/Microsoft/powerbi-models/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/powerbi-models/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/powerbi-models/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/powerbi-models/subscription","commits_url":"https://api.github.com/repos/Microsoft/powerbi-models/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/powerbi-models/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/powerbi-models/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/powerbi-models/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/powerbi-models/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/powerbi-models/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/powerbi-models/merges","archive_url":"https://api.github.com/repos/Microsoft/powerbi-models/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/powerbi-models/downloads","issues_url":"https://api.github.com/repos/Microsoft/powerbi-models/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/powerbi-models/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/powerbi-models/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/powerbi-models/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/powerbi-models/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/powerbi-models/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/powerbi-models/deployments","created_at":"2016-06-23T18:25:47Z","updated_at":"2016-08-27T23:56:01Z","pushed_at":"2016-08-29T20:42:05Z","git_url":"git://github.com/Microsoft/powerbi-models.git","ssh_url":"git@github.com:Microsoft/powerbi-models.git","clone_url":"https://github.com/Microsoft/powerbi-models.git","svn_url":"https://github.com/Microsoft/powerbi-models","homepage":"https://microsoft.github.io/powerbi-models/","size":233,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/11"},"html":{"href":"https://github.com/Microsoft/powerbi-models/pull/11"},"issue":{"href":"https://api.github.com/repos/Microsoft/powerbi-models/issues/11"},"comments":{"href":"https://api.github.com/repos/Microsoft/powerbi-models/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/powerbi-models/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/powerbi-models/statuses/158de0fccb526902b96bbee5fc552d8ecc1434ad"}}}}
{"actor":{"display_login":"wbreza"}}