{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37315","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37315/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37315/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37315/events","html_url":"https://github.com/kubernetes/kubernetes/issues/37315","id":191132748,"number":37315,"title":"[CRI] Decide what to do with traffic shaping in kubenet","user":{"login":"freehan","id":1332699,"avatar_url":"https://avatars.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"labels":[{"id":116712108,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/networking","name":"area/networking","color":"006b75","default":false},{"id":173493827,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/team/cluster","name":"team/cluster","color":"d2b48c","default":false},{"id":173493665,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/team/node","name":"team/node","color":"d2b48c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/17","html_url":"https://github.com/kubernetes/kubernetes/milestones/next-candidate","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/17/labels","id":1510379,"number":17,"title":"next-candidate","description":"Candidates for the next milestone","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":287,"closed_issues":204,"state":"open","created_at":"2016-01-16T17:58:20Z","updated_at":"2016-11-23T18:56:30Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-11-22T21:46:16Z","updated_at":"2016-11-24T06:38:36Z","closed_at":null,"body":"Traffic shaping is currently disabled in kubenet when running with CRI. We can enable it by passing pod sandbox annotation into network plugin.\r\n\r\nThe current traffic shaping happens per pod per node, lack of global coordination. Hence @dchen1107 suggest to remove it and pursue a better design. \r\n\r\n@kubernetes/sig-network @kubernetes/sig-node \r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/262701421","html_url":"https://github.com/kubernetes/kubernetes/issues/37315#issuecomment-262701421","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37315","id":262701421,"user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"created_at":"2016-11-24T06:38:36Z","updated_at":"2016-11-24T06:38:36Z","body":"Maybe we need a CNI developers summit in early Q1?  There are a lot of\nideas on the table, we should be careful here...\n\nOn Wed, Nov 23, 2016 at 7:28 AM, Casey Callendrello <\nnotifications@github.com> wrote:\n\n> We're currently working on a convention within the CNI to facilitate\n> post-interface-creation \"tuning\" plugins. One of the motivating examples\n> is, of course, traffic shaping.\n>\n> There are a few subtleties, including the fact that traffic shaping is a\n> per-container consideration, rather than a per-network configuration.\n>\n> The design I'm leaning towards is a separate call to libcni after the\n> interface is created by the runtime / kubelet. This means that the traffic\n> shaping parameters still need to be a distinct parameter set, rather than\n> just the network config file. Consequently, the kubelet + runtime will\n> still need to be able to pass them around.\n>\n> —\n> You are receiving this because you are on a team that was mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/kubernetes/kubernetes/issues/37315#issuecomment-262546161>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AFVgVA1uq52fWOq9C72rjm1wwihAbJD-ks5rBFu0gaJpZM4K5-l2>\n> .\n>\n"}}
{"actor":{"display_login":"thockin"}}