{"action":"created","issue":{"url":"https://api.github.com/repos/MRtrix3/mrtrix3/issues/422","repository_url":"https://api.github.com/repos/MRtrix3/mrtrix3","labels_url":"https://api.github.com/repos/MRtrix3/mrtrix3/issues/422/labels{/name}","comments_url":"https://api.github.com/repos/MRtrix3/mrtrix3/issues/422/comments","events_url":"https://api.github.com/repos/MRtrix3/mrtrix3/issues/422/events","html_url":"https://github.com/MRtrix3/mrtrix3/issues/422","id":122171035,"number":422,"title":"(ms)dwi2response & sh2response: Resolving naming before release","user":{"login":"Lestropie","id":5637955,"avatar_url":"https://avatars.githubusercontent.com/u/5637955?v=3","gravatar_id":"","url":"https://api.github.com/users/Lestropie","html_url":"https://github.com/Lestropie","followers_url":"https://api.github.com/users/Lestropie/followers","following_url":"https://api.github.com/users/Lestropie/following{/other_user}","gists_url":"https://api.github.com/users/Lestropie/gists{/gist_id}","starred_url":"https://api.github.com/users/Lestropie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lestropie/subscriptions","organizations_url":"https://api.github.com/users/Lestropie/orgs","repos_url":"https://api.github.com/users/Lestropie/repos","events_url":"https://api.github.com/users/Lestropie/events{/privacy}","received_events_url":"https://api.github.com/users/Lestropie/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/MRtrix3/mrtrix3/labels/help%20wanted","name":"help wanted","color":"159818"},{"url":"https://api.github.com/repos/MRtrix3/mrtrix3/labels/question","name":"question","color":"cc317c"},{"url":"https://api.github.com/repos/MRtrix3/mrtrix3/labels/scripts","name":"scripts","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/MRtrix3/mrtrix3/milestones/1","html_url":"https://github.com/MRtrix3/mrtrix3/milestones/MRtrix3%203.0%20release%20","labels_url":"https://api.github.com/repos/MRtrix3/mrtrix3/milestones/1/labels","id":1036648,"number":1,"title":"MRtrix3 3.0 release ","description":"","creator":{"login":"jdtournier","id":3221000,"avatar_url":"https://avatars.githubusercontent.com/u/3221000?v=3","gravatar_id":"","url":"https://api.github.com/users/jdtournier","html_url":"https://github.com/jdtournier","followers_url":"https://api.github.com/users/jdtournier/followers","following_url":"https://api.github.com/users/jdtournier/following{/other_user}","gists_url":"https://api.github.com/users/jdtournier/gists{/gist_id}","starred_url":"https://api.github.com/users/jdtournier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdtournier/subscriptions","organizations_url":"https://api.github.com/users/jdtournier/orgs","repos_url":"https://api.github.com/users/jdtournier/repos","events_url":"https://api.github.com/users/jdtournier/events{/privacy}","received_events_url":"https://api.github.com/users/jdtournier/received_events","type":"User","site_admin":false},"open_issues":34,"closed_issues":71,"state":"open","created_at":"2015-03-24T16:09:24Z","updated_at":"2016-02-05T06:03:08Z","due_on":"2016-01-01T00:00:00Z","closed_at":null},"comments":22,"created_at":"2015-12-15T01:26:57Z","updated_at":"2016-02-06T07:02:02Z","closed_at":null,"body":"We need to decide what to do about these before we release. Supersedes #105.\r\n\r\nHere's my current thinking, feel free to modify or suggest complete alternatives:\r\n\r\n* Keep `dwi2response`, but rename it to `dwi2sf`, and output the single-fibre voxel mask by default; only give the final response function if explicitly requested by the user.\r\n\r\n* Rename `sh2response` to `sf2response`, and receive as primary input a DWI rather than SH; this will additionally allow for selecting the shell(s) for which response(s) should be estimated (which should simplify `msdwi2response`).\r\n\r\nHopefully that makes it clear that there are in fact two steps: single-fibre voxel selection, and response function estimation based on those voxels. Just using the (optional) response function output from `dwi2sf` is a shortcut that will probably satisfy most users, but hopefully the fact that the SF voxel mask is the default output will make people question that and look into alternative ways to get the SF mask rather than just reporting that they can't get a response function.\r\n\r\nHopefully it also separates `msdwi2response` from what is currently `dwi2response`, as their operations are actually quite different currently."},"comment":{"url":"https://api.github.com/repos/MRtrix3/mrtrix3/issues/comments/180708573","html_url":"https://github.com/MRtrix3/mrtrix3/issues/422#issuecomment-180708573","issue_url":"https://api.github.com/repos/MRtrix3/mrtrix3/issues/422","id":180708573,"user":{"login":"jdtournier","id":3221000,"avatar_url":"https://avatars.githubusercontent.com/u/3221000?v=3","gravatar_id":"","url":"https://api.github.com/users/jdtournier","html_url":"https://github.com/jdtournier","followers_url":"https://api.github.com/users/jdtournier/followers","following_url":"https://api.github.com/users/jdtournier/following{/other_user}","gists_url":"https://api.github.com/users/jdtournier/gists{/gist_id}","starred_url":"https://api.github.com/users/jdtournier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdtournier/subscriptions","organizations_url":"https://api.github.com/users/jdtournier/orgs","repos_url":"https://api.github.com/users/jdtournier/repos","events_url":"https://api.github.com/users/jdtournier/events{/privacy}","received_events_url":"https://api.github.com/users/jdtournier/received_events","type":"User","site_admin":false},"created_at":"2016-02-06T07:02:02Z","updated_at":"2016-02-06T07:02:02Z","body":"Yeah, I figured...\r\n\r\nI guess at the very least some hefty wiki documentation will be needed to cover this. I vote we recommend my approach (obviously) on the wiki for single-shell unless anyone has any objections...? And obviously, recommend the `msmt_5tt` approach for MSMT-CSD. We could also make these recommendations in the script's help page (there is one, right?), but I agree, I  don't think we should have a default as such, seen as it can be used for various purposes.\r\n\r\nThoughts?"}}