{"action":"created","issue":{"url":"https://api.github.com/repos/uber/ringpop-go/issues/164","repository_url":"https://api.github.com/repos/uber/ringpop-go","labels_url":"https://api.github.com/repos/uber/ringpop-go/issues/164/labels{/name}","comments_url":"https://api.github.com/repos/uber/ringpop-go/issues/164/comments","events_url":"https://api.github.com/repos/uber/ringpop-go/issues/164/events","html_url":"https://github.com/uber/ringpop-go/pull/164","id":169371679,"number":164,"title":"increase waiting time for snapshot of stats to be updated.","user":{"login":"thanodnl","id":273145,"avatar_url":"https://avatars.githubusercontent.com/u/273145?v=3","gravatar_id":"","url":"https://api.github.com/users/thanodnl","html_url":"https://github.com/thanodnl","followers_url":"https://api.github.com/users/thanodnl/followers","following_url":"https://api.github.com/users/thanodnl/following{/other_user}","gists_url":"https://api.github.com/users/thanodnl/gists{/gist_id}","starred_url":"https://api.github.com/users/thanodnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thanodnl/subscriptions","organizations_url":"https://api.github.com/users/thanodnl/orgs","repos_url":"https://api.github.com/users/thanodnl/repos","events_url":"https://api.github.com/users/thanodnl/events{/privacy}","received_events_url":"https://api.github.com/users/thanodnl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-04T13:16:26Z","updated_at":"2016-08-04T13:24:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uber/ringpop-go/pulls/164","html_url":"https://github.com/uber/ringpop-go/pull/164","diff_url":"https://github.com/uber/ringpop-go/pull/164.diff","patch_url":"https://github.com/uber/ringpop-go/pull/164.patch"},"body":"This PR is in the hope to fix a flappy test that happens more often than not:\r\n\r\n```\r\n--- FAIL: TestProtocolStats (5.09s)\r\n    Error Trace:    stats_test.go:89\r\n    Error:      Should not be zero, but was 0\r\n\r\n    Error Trace:    stats_test.go:90\r\n    Error:      Should not be zero, but was 0\r\n\r\n--- FAIL: TestStatsTestSuite (5.21s)\r\nFAIL\r\nFAIL    github.com/uber/ringpop-go/swim 9.984s\r\n```\r\n\r\nThe reasoning behind the change is that `metrics.Meter` mentioned in the comments above is snapshotted every 5 seconds and made available to read from. By exactly waiting 5 seconds we might still read the values just before the snapshot is actually populated with information. By waiting an additional second the hope is that we read less 0's."},"comment":{"url":"https://api.github.com/repos/uber/ringpop-go/issues/comments/237551541","html_url":"https://github.com/uber/ringpop-go/pull/164#issuecomment-237551541","issue_url":"https://api.github.com/repos/uber/ringpop-go/issues/164","id":237551541,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-08-04T13:24:52Z","updated_at":"2016-08-04T13:24:52Z","body":"\n[![Coverage Status](https://coveralls.io/builds/7305239/badge)](https://coveralls.io/builds/7305239)\n\nCoverage decreased (-0.09%) to 94.574% when pulling **a492b9a2d3efd5ceaed068ff26c301ee218417cc on test/flappy-stats-test** into **19ff2e65a88aa24bab0e490ee355972d70d8f7bb on dev**.\n"}}
{"actor":{"display_login":"coveralls"}}