{"action":"created","issue":{"url":"https://api.github.com/repos/18F/identity-idp/issues/650","repository_url":"https://api.github.com/repos/18F/identity-idp","labels_url":"https://api.github.com/repos/18F/identity-idp/issues/650/labels{/name}","comments_url":"https://api.github.com/repos/18F/identity-idp/issues/650/comments","events_url":"https://api.github.com/repos/18F/identity-idp/issues/650/events","html_url":"https://github.com/18F/identity-idp/pull/650","id":186605902,"number":650,"title":"Implement NIST encryption model","user":{"login":"pkarman","id":1205061,"avatar_url":"https://avatars.githubusercontent.com/u/1205061?v=3","gravatar_id":"","url":"https://api.github.com/users/pkarman","html_url":"https://github.com/pkarman","followers_url":"https://api.github.com/users/pkarman/followers","following_url":"https://api.github.com/users/pkarman/following{/other_user}","gists_url":"https://api.github.com/users/pkarman/gists{/gist_id}","starred_url":"https://api.github.com/users/pkarman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkarman/subscriptions","organizations_url":"https://api.github.com/users/pkarman/orgs","repos_url":"https://api.github.com/users/pkarman/repos","events_url":"https://api.github.com/users/pkarman/events{/privacy}","received_events_url":"https://api.github.com/users/pkarman/received_events","type":"User","site_admin":false},"labels":[{"id":355011342,"url":"https://api.github.com/repos/18F/identity-idp/labels/ready%20for%20review","name":"ready for review","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":{"login":"pkarman","id":1205061,"avatar_url":"https://avatars.githubusercontent.com/u/1205061?v=3","gravatar_id":"","url":"https://api.github.com/users/pkarman","html_url":"https://github.com/pkarman","followers_url":"https://api.github.com/users/pkarman/followers","following_url":"https://api.github.com/users/pkarman/following{/other_user}","gists_url":"https://api.github.com/users/pkarman/gists{/gist_id}","starred_url":"https://api.github.com/users/pkarman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkarman/subscriptions","organizations_url":"https://api.github.com/users/pkarman/orgs","repos_url":"https://api.github.com/users/pkarman/repos","events_url":"https://api.github.com/users/pkarman/events{/privacy}","received_events_url":"https://api.github.com/users/pkarman/received_events","type":"User","site_admin":false},"assignees":[{"login":"pkarman","id":1205061,"avatar_url":"https://avatars.githubusercontent.com/u/1205061?v=3","gravatar_id":"","url":"https://api.github.com/users/pkarman","html_url":"https://github.com/pkarman","followers_url":"https://api.github.com/users/pkarman/followers","following_url":"https://api.github.com/users/pkarman/following{/other_user}","gists_url":"https://api.github.com/users/pkarman/gists{/gist_id}","starred_url":"https://api.github.com/users/pkarman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkarman/subscriptions","organizations_url":"https://api.github.com/users/pkarman/orgs","repos_url":"https://api.github.com/users/pkarman/repos","events_url":"https://api.github.com/users/pkarman/events{/privacy}","received_events_url":"https://api.github.com/users/pkarman/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-11-01T18:13:07Z","updated_at":"2016-11-03T15:07:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/18F/identity-idp/pulls/650","html_url":"https://github.com/18F/identity-idp/pull/650","diff_url":"https://github.com/18F/identity-idp/pull/650.diff","patch_url":"https://github.com/18F/identity-idp/pull/650.patch"},"body":"**Why**: NIST encryption model leverages hardware security module (HSM) for better password and PII\r\nsecurity.\r\n\r\n**How**:\r\n\r\n* Password is hashed with SCrypt and encrypted with HSM encryption key\r\n* An encrypted CEK (Content Encryption Key) using AWS KMS. The `use_kms` feature can be toggled\r\non/off for development when AWS KMS is not available.\r\n* PII is encrypted with the same salt and encryption key as password, to reduce processing overhead.\r\n\r\nSee `spec/services/pii/nist_encryption_spec.rb`\r\nfor full description and tests of the NIST encryption\r\nmodel."},"comment":{"url":"https://api.github.com/repos/18F/identity-idp/issues/comments/258169877","html_url":"https://github.com/18F/identity-idp/pull/650#issuecomment-258169877","issue_url":"https://api.github.com/repos/18F/identity-idp/issues/650","id":258169877,"user":{"login":"pkarman","id":1205061,"avatar_url":"https://avatars.githubusercontent.com/u/1205061?v=3","gravatar_id":"","url":"https://api.github.com/users/pkarman","html_url":"https://github.com/pkarman","followers_url":"https://api.github.com/users/pkarman/followers","following_url":"https://api.github.com/users/pkarman/following{/other_user}","gists_url":"https://api.github.com/users/pkarman/gists{/gist_id}","starred_url":"https://api.github.com/users/pkarman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkarman/subscriptions","organizations_url":"https://api.github.com/users/pkarman/orgs","repos_url":"https://api.github.com/users/pkarman/repos","events_url":"https://api.github.com/users/pkarman/events{/privacy}","received_events_url":"https://api.github.com/users/pkarman/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T15:07:13Z","updated_at":"2016-11-03T15:07:13Z","body":"@dogweather this comment confuses me:\r\n\r\n> Could you describe the System Under Test explicitly in the describe blocks?\r\n\r\nIs there any new spec where that is not the case?\r\n\r\nThe `spec/services/pii/nist_encryption_spec.rb` does not test any one class. It is a demonstration of the encryption model intended for NIST and other crypto reviewers. It's like a feature test for an algorithm."}}
{"actor":{"display_login":"pkarman"}}