{"action":"created","comment":{"url":"https://api.github.com/repos/influxdata/telegraf/pulls/comments/75057733","id":75057733,"diff_hunk":"@@ -252,7 +252,14 @@ func (j *Jolokia) Gather(acc telegraf.Accumulator) error {\n \t\t\t\t\t\t\tswitch t2 := v.(type) {\n \t\t\t\t\t\t\tcase map[string]interface{}:\n \t\t\t\t\t\t\t\tfor k2, v2 := range t2 {\n-\t\t\t\t\t\t\t\t\tfields[measurement+\"_\"+k+\"_\"+k2] = v2\n+\t\t\t\t\t\t\t\t\tswitch t3 := v2.(type) {\n+\t\t\t\t\t\t\t\t\tcase map[string]interface{}:\n+\t\t\t\t\t\t\t\t\t\tfor k3, v3 := range t3 {\n+\t\t\t\t\t\t\t\t\t\t\tfields[measurement+\"_\"+k+\"_\"+k2+\"_\"+k3] = v3\n+\t\t\t\t\t\t\t\t\t\t}","path":"plugins/inputs/jolokia/jolokia.go","position":9,"original_position":9,"commit_id":"9ecc82bf0f657779869de5ec71cbb2b54c9fa5be","original_commit_id":"9ecc82bf0f657779869de5ec71cbb2b54c9fa5be","user":{"login":"phemmer","id":1826947,"avatar_url":"https://avatars.githubusercontent.com/u/1826947?v=3","gravatar_id":"","url":"https://api.github.com/users/phemmer","html_url":"https://github.com/phemmer","followers_url":"https://api.github.com/users/phemmer/followers","following_url":"https://api.github.com/users/phemmer/following{/other_user}","gists_url":"https://api.github.com/users/phemmer/gists{/gist_id}","starred_url":"https://api.github.com/users/phemmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phemmer/subscriptions","organizations_url":"https://api.github.com/users/phemmer/orgs","repos_url":"https://api.github.com/users/phemmer/repos","events_url":"https://api.github.com/users/phemmer/events{/privacy}","received_events_url":"https://api.github.com/users/phemmer/received_events","type":"User","site_admin":false},"body":"Well we're unmarshalling json, so cyclical structures aren't possible, so there's no risk of infinite recursion. You'd have to get thousands of levels deep before it would become an issue.\r\nI guess what I'm saying is that I don't see the need for a depth limit. But the code complexity to add it is pretty minor, so I'm not really opposed to it either.","created_at":"2016-08-17T03:27:06Z","updated_at":"2016-08-17T03:27:06Z","html_url":"https://github.com/influxdata/telegraf/pull/1639#discussion_r75057733","pull_request_url":"https://api.github.com/repos/influxdata/telegraf/pulls/1639","_links":{"self":{"href":"https://api.github.com/repos/influxdata/telegraf/pulls/comments/75057733"},"html":{"href":"https://github.com/influxdata/telegraf/pull/1639#discussion_r75057733"},"pull_request":{"href":"https://api.github.com/repos/influxdata/telegraf/pulls/1639"}}},"pull_request":{"url":"https://api.github.com/repos/influxdata/telegraf/pulls/1639","id":81541013,"html_url":"https://github.com/influxdata/telegraf/pull/1639","diff_url":"https://github.com/influxdata/telegraf/pull/1639.diff","patch_url":"https://github.com/influxdata/telegraf/pull/1639.patch","issue_url":"https://api.github.com/repos/influxdata/telegraf/issues/1639","number":1639,"state":"open","locked":false,"title":"Update jolokia.go","user":{"login":"InfiniteCode","id":1863464,"avatar_url":"https://avatars.githubusercontent.com/u/1863464?v=3","gravatar_id":"","url":"https://api.github.com/users/InfiniteCode","html_url":"https://github.com/InfiniteCode","followers_url":"https://api.github.com/users/InfiniteCode/followers","following_url":"https://api.github.com/users/InfiniteCode/following{/other_user}","gists_url":"https://api.github.com/users/InfiniteCode/gists{/gist_id}","starred_url":"https://api.github.com/users/InfiniteCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InfiniteCode/subscriptions","organizations_url":"https://api.github.com/users/InfiniteCode/orgs","repos_url":"https://api.github.com/users/InfiniteCode/repos","events_url":"https://api.github.com/users/InfiniteCode/events{/privacy}","received_events_url":"https://api.github.com/users/InfiniteCode/received_events","type":"User","site_admin":false},"body":"### Required for all PRs:\r\n\r\n- [ ] CHANGELOG.md updated\r\n- [ ] Sign [CLA](https://influxdata.com/community/cla/) (if not already signed)\r\n- [ ] README.md updated (if adding a new plugin)\r\n\r\nSome of the values returned from jolokia have three levels of nesting. This fixes the issue of maps being returned instead of values.","created_at":"2016-08-16T20:42:43Z","updated_at":"2016-08-17T03:27:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8589f41d74c1b634f2d1741859af85a33b9587b3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/influxdata/telegraf/pulls/1639/commits","review_comments_url":"https://api.github.com/repos/influxdata/telegraf/pulls/1639/comments","review_comment_url":"https://api.github.com/repos/influxdata/telegraf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/influxdata/telegraf/issues/1639/comments","statuses_url":"https://api.github.com/repos/influxdata/telegraf/statuses/9ecc82bf0f657779869de5ec71cbb2b54c9fa5be","head":{"label":"InfiniteCode:patch-1","ref":"patch-1","sha":"9ecc82bf0f657779869de5ec71cbb2b54c9fa5be","user":{"login":"InfiniteCode","id":1863464,"avatar_url":"https://avatars.githubusercontent.com/u/1863464?v=3","gravatar_id":"","url":"https://api.github.com/users/InfiniteCode","html_url":"https://github.com/InfiniteCode","followers_url":"https://api.github.com/users/InfiniteCode/followers","following_url":"https://api.github.com/users/InfiniteCode/following{/other_user}","gists_url":"https://api.github.com/users/InfiniteCode/gists{/gist_id}","starred_url":"https://api.github.com/users/InfiniteCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InfiniteCode/subscriptions","organizations_url":"https://api.github.com/users/InfiniteCode/orgs","repos_url":"https://api.github.com/users/InfiniteCode/repos","events_url":"https://api.github.com/users/InfiniteCode/events{/privacy}","received_events_url":"https://api.github.com/users/InfiniteCode/received_events","type":"User","site_admin":false},"repo":{"id":65852033,"name":"telegraf","full_name":"InfiniteCode/telegraf","owner":{"login":"InfiniteCode","id":1863464,"avatar_url":"https://avatars.githubusercontent.com/u/1863464?v=3","gravatar_id":"","url":"https://api.github.com/users/InfiniteCode","html_url":"https://github.com/InfiniteCode","followers_url":"https://api.github.com/users/InfiniteCode/followers","following_url":"https://api.github.com/users/InfiniteCode/following{/other_user}","gists_url":"https://api.github.com/users/InfiniteCode/gists{/gist_id}","starred_url":"https://api.github.com/users/InfiniteCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InfiniteCode/subscriptions","organizations_url":"https://api.github.com/users/InfiniteCode/orgs","repos_url":"https://api.github.com/users/InfiniteCode/repos","events_url":"https://api.github.com/users/InfiniteCode/events{/privacy}","received_events_url":"https://api.github.com/users/InfiniteCode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/InfiniteCode/telegraf","description":"The plugin-driven server agent for collecting & reporting metrics.","fork":true,"url":"https://api.github.com/repos/InfiniteCode/telegraf","forks_url":"https://api.github.com/repos/InfiniteCode/telegraf/forks","keys_url":"https://api.github.com/repos/InfiniteCode/telegraf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/InfiniteCode/telegraf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/InfiniteCode/telegraf/teams","hooks_url":"https://api.github.com/repos/InfiniteCode/telegraf/hooks","issue_events_url":"https://api.github.com/repos/InfiniteCode/telegraf/issues/events{/number}","events_url":"https://api.github.com/repos/InfiniteCode/telegraf/events","assignees_url":"https://api.github.com/repos/InfiniteCode/telegraf/assignees{/user}","branches_url":"https://api.github.com/repos/InfiniteCode/telegraf/branches{/branch}","tags_url":"https://api.github.com/repos/InfiniteCode/telegraf/tags","blobs_url":"https://api.github.com/repos/InfiniteCode/telegraf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/InfiniteCode/telegraf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/InfiniteCode/telegraf/git/refs{/sha}","trees_url":"https://api.github.com/repos/InfiniteCode/telegraf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/InfiniteCode/telegraf/statuses/{sha}","languages_url":"https://api.github.com/repos/InfiniteCode/telegraf/languages","stargazers_url":"https://api.github.com/repos/InfiniteCode/telegraf/stargazers","contributors_url":"https://api.github.com/repos/InfiniteCode/telegraf/contributors","subscribers_url":"https://api.github.com/repos/InfiniteCode/telegraf/subscribers","subscription_url":"https://api.github.com/repos/InfiniteCode/telegraf/subscription","commits_url":"https://api.github.com/repos/InfiniteCode/telegraf/commits{/sha}","git_commits_url":"https://api.github.com/repos/InfiniteCode/telegraf/git/commits{/sha}","comments_url":"https://api.github.com/repos/InfiniteCode/telegraf/comments{/number}","issue_comment_url":"https://api.github.com/repos/InfiniteCode/telegraf/issues/comments{/number}","contents_url":"https://api.github.com/repos/InfiniteCode/telegraf/contents/{+path}","compare_url":"https://api.github.com/repos/InfiniteCode/telegraf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/InfiniteCode/telegraf/merges","archive_url":"https://api.github.com/repos/InfiniteCode/telegraf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/InfiniteCode/telegraf/downloads","issues_url":"https://api.github.com/repos/InfiniteCode/telegraf/issues{/number}","pulls_url":"https://api.github.com/repos/InfiniteCode/telegraf/pulls{/number}","milestones_url":"https://api.github.com/repos/InfiniteCode/telegraf/milestones{/number}","notifications_url":"https://api.github.com/repos/InfiniteCode/telegraf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/InfiniteCode/telegraf/labels{/name}","releases_url":"https://api.github.com/repos/InfiniteCode/telegraf/releases{/id}","deployments_url":"https://api.github.com/repos/InfiniteCode/telegraf/deployments","created_at":"2016-08-16T20:38:45Z","updated_at":"2016-08-16T20:38:48Z","pushed_at":"2016-08-16T20:42:18Z","git_url":"git://github.com/InfiniteCode/telegraf.git","ssh_url":"git@github.com:InfiniteCode/telegraf.git","clone_url":"https://github.com/InfiniteCode/telegraf.git","svn_url":"https://github.com/InfiniteCode/telegraf","homepage":"","size":11030,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"influxdata:master","ref":"master","sha":"7600757f167af3ee21f32d413337dcbcf07128ce","user":{"login":"influxdata","id":5713248,"avatar_url":"https://avatars.githubusercontent.com/u/5713248?v=3","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"repo":{"id":33258973,"name":"telegraf","full_name":"influxdata/telegraf","owner":{"login":"influxdata","id":5713248,"avatar_url":"https://avatars.githubusercontent.com/u/5713248?v=3","gravatar_id":"","url":"https://api.github.com/users/influxdata","html_url":"https://github.com/influxdata","followers_url":"https://api.github.com/users/influxdata/followers","following_url":"https://api.github.com/users/influxdata/following{/other_user}","gists_url":"https://api.github.com/users/influxdata/gists{/gist_id}","starred_url":"https://api.github.com/users/influxdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influxdata/subscriptions","organizations_url":"https://api.github.com/users/influxdata/orgs","repos_url":"https://api.github.com/users/influxdata/repos","events_url":"https://api.github.com/users/influxdata/events{/privacy}","received_events_url":"https://api.github.com/users/influxdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/influxdata/telegraf","description":"The plugin-driven server agent for collecting & reporting metrics.","fork":false,"url":"https://api.github.com/repos/influxdata/telegraf","forks_url":"https://api.github.com/repos/influxdata/telegraf/forks","keys_url":"https://api.github.com/repos/influxdata/telegraf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/influxdata/telegraf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/influxdata/telegraf/teams","hooks_url":"https://api.github.com/repos/influxdata/telegraf/hooks","issue_events_url":"https://api.github.com/repos/influxdata/telegraf/issues/events{/number}","events_url":"https://api.github.com/repos/influxdata/telegraf/events","assignees_url":"https://api.github.com/repos/influxdata/telegraf/assignees{/user}","branches_url":"https://api.github.com/repos/influxdata/telegraf/branches{/branch}","tags_url":"https://api.github.com/repos/influxdata/telegraf/tags","blobs_url":"https://api.github.com/repos/influxdata/telegraf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/influxdata/telegraf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/influxdata/telegraf/git/refs{/sha}","trees_url":"https://api.github.com/repos/influxdata/telegraf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/influxdata/telegraf/statuses/{sha}","languages_url":"https://api.github.com/repos/influxdata/telegraf/languages","stargazers_url":"https://api.github.com/repos/influxdata/telegraf/stargazers","contributors_url":"https://api.github.com/repos/influxdata/telegraf/contributors","subscribers_url":"https://api.github.com/repos/influxdata/telegraf/subscribers","subscription_url":"https://api.github.com/repos/influxdata/telegraf/subscription","commits_url":"https://api.github.com/repos/influxdata/telegraf/commits{/sha}","git_commits_url":"https://api.github.com/repos/influxdata/telegraf/git/commits{/sha}","comments_url":"https://api.github.com/repos/influxdata/telegraf/comments{/number}","issue_comment_url":"https://api.github.com/repos/influxdata/telegraf/issues/comments{/number}","contents_url":"https://api.github.com/repos/influxdata/telegraf/contents/{+path}","compare_url":"https://api.github.com/repos/influxdata/telegraf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/influxdata/telegraf/merges","archive_url":"https://api.github.com/repos/influxdata/telegraf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/influxdata/telegraf/downloads","issues_url":"https://api.github.com/repos/influxdata/telegraf/issues{/number}","pulls_url":"https://api.github.com/repos/influxdata/telegraf/pulls{/number}","milestones_url":"https://api.github.com/repos/influxdata/telegraf/milestones{/number}","notifications_url":"https://api.github.com/repos/influxdata/telegraf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/influxdata/telegraf/labels{/name}","releases_url":"https://api.github.com/repos/influxdata/telegraf/releases{/id}","deployments_url":"https://api.github.com/repos/influxdata/telegraf/deployments","created_at":"2015-04-01T16:28:44Z","updated_at":"2016-08-16T20:20:40Z","pushed_at":"2016-08-16T20:42:43Z","git_url":"git://github.com/influxdata/telegraf.git","ssh_url":"git@github.com:influxdata/telegraf.git","clone_url":"https://github.com/influxdata/telegraf.git","svn_url":"https://github.com/influxdata/telegraf","homepage":"","size":25881,"stargazers_count":1665,"watchers_count":1665,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":558,"mirror_url":null,"open_issues_count":199,"forks":558,"open_issues":199,"watchers":1665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/influxdata/telegraf/pulls/1639"},"html":{"href":"https://github.com/influxdata/telegraf/pull/1639"},"issue":{"href":"https://api.github.com/repos/influxdata/telegraf/issues/1639"},"comments":{"href":"https://api.github.com/repos/influxdata/telegraf/issues/1639/comments"},"review_comments":{"href":"https://api.github.com/repos/influxdata/telegraf/pulls/1639/comments"},"review_comment":{"href":"https://api.github.com/repos/influxdata/telegraf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/influxdata/telegraf/pulls/1639/commits"},"statuses":{"href":"https://api.github.com/repos/influxdata/telegraf/statuses/9ecc82bf0f657779869de5ec71cbb2b54c9fa5be"}}}}
{"actor":{"display_login":"phemmer"}}