{"action":"created","comment":{"url":"https://api.github.com/repos/nest/nest-simulator/pulls/comments/85091221","pull_request_review_id":5825860,"id":85091221,"diff_hunk":"@@ -240,6 +246,12 @@ class AllToAllBuilder : public ConnBuilder\n   {\n   }\n \n+  bool\n+  is_symmetric() const\n+  {\n+    return true;\n+  }","path":"nestkernel/conn_builder.h","position":21,"original_position":21,"commit_id":"cfe0f3e6aed75a76732620948101f2c1f4c2c549","original_commit_id":"cfe0f3e6aed75a76732620948101f2c1f4c2c549","user":{"login":"janhahne","id":13448785,"avatar_url":"https://avatars.githubusercontent.com/u/13448785?v=3","gravatar_id":"","url":"https://api.github.com/users/janhahne","html_url":"https://github.com/janhahne","followers_url":"https://api.github.com/users/janhahne/followers","following_url":"https://api.github.com/users/janhahne/following{/other_user}","gists_url":"https://api.github.com/users/janhahne/gists{/gist_id}","starred_url":"https://api.github.com/users/janhahne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janhahne/subscriptions","organizations_url":"https://api.github.com/users/janhahne/orgs","repos_url":"https://api.github.com/users/janhahne/repos","events_url":"https://api.github.com/users/janhahne/events{/privacy}","received_events_url":"https://api.github.com/users/janhahne/received_events","type":"User","site_admin":false},"body":"@heplesser Good catch, I did not think of that. Is there any easy way to determine if all-to-all uses randomized synapse parameters? I am thinking of a solution where this functions first checks if there are any randomized parameters involved (if so throws an `BadProperty`) and (otherwise) then returns `true`.","created_at":"2016-10-26T10:17:56Z","updated_at":"2016-10-26T10:17:56Z","html_url":"https://github.com/nest/nest-simulator/pull/524#discussion_r85091221","pull_request_url":"https://api.github.com/repos/nest/nest-simulator/pulls/524","_links":{"self":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/comments/85091221"},"html":{"href":"https://github.com/nest/nest-simulator/pull/524#discussion_r85091221"},"pull_request":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/524"}}},"pull_request":{"url":"https://api.github.com/repos/nest/nest-simulator/pulls/524","id":90009625,"html_url":"https://github.com/nest/nest-simulator/pull/524","diff_url":"https://github.com/nest/nest-simulator/pull/524.diff","patch_url":"https://github.com/nest/nest-simulator/pull/524.patch","issue_url":"https://api.github.com/repos/nest/nest-simulator/issues/524","number":524,"state":"open","locked":false,"title":"Implemented requires_symmetric flag for synapse models","user":{"login":"janhahne","id":13448785,"avatar_url":"https://avatars.githubusercontent.com/u/13448785?v=3","gravatar_id":"","url":"https://api.github.com/users/janhahne","html_url":"https://github.com/janhahne","followers_url":"https://api.github.com/users/janhahne/followers","following_url":"https://api.github.com/users/janhahne/following{/other_user}","gists_url":"https://api.github.com/users/janhahne/gists{/gist_id}","starred_url":"https://api.github.com/users/janhahne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janhahne/subscriptions","organizations_url":"https://api.github.com/users/janhahne/orgs","repos_url":"https://api.github.com/users/janhahne/repos","events_url":"https://api.github.com/users/janhahne/events{/privacy}","received_events_url":"https://api.github.com/users/janhahne/received_events","type":"User","site_admin":false},"body":"This PR is an addition to PR #315 and fixes issue #440. It adds an `requires_symmetric` flag to the ConnetorModel class. This way synapse models can be registered as two-way connections that require symmetric connections (1->2 and 2->1). If a connection of such a synapse model is created without setting the `symmetric` flag of the connection dicitonary to `true` an exception is thrown. All-to-all connections can be created without setting `symmetric` to `true` as they are symmetric by definition (and we anyway do not allow symmetric all-to-all connections for good reasons).\r\n\r\nSo far gap junctions are the only two-way connections that use this new flag.","created_at":"2016-10-19T13:31:01Z","updated_at":"2016-10-26T10:17:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1fe985aaaf32691eab10b13c151561f701787696","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nest/nest-simulator/pulls/524/commits","review_comments_url":"https://api.github.com/repos/nest/nest-simulator/pulls/524/comments","review_comment_url":"https://api.github.com/repos/nest/nest-simulator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nest/nest-simulator/issues/524/comments","statuses_url":"https://api.github.com/repos/nest/nest-simulator/statuses/cfe0f3e6aed75a76732620948101f2c1f4c2c549","head":{"label":"janhahne:symmetric_warning","ref":"symmetric_warning","sha":"cfe0f3e6aed75a76732620948101f2c1f4c2c549","user":{"login":"janhahne","id":13448785,"avatar_url":"https://avatars.githubusercontent.com/u/13448785?v=3","gravatar_id":"","url":"https://api.github.com/users/janhahne","html_url":"https://github.com/janhahne","followers_url":"https://api.github.com/users/janhahne/followers","following_url":"https://api.github.com/users/janhahne/following{/other_user}","gists_url":"https://api.github.com/users/janhahne/gists{/gist_id}","starred_url":"https://api.github.com/users/janhahne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janhahne/subscriptions","organizations_url":"https://api.github.com/users/janhahne/orgs","repos_url":"https://api.github.com/users/janhahne/repos","events_url":"https://api.github.com/users/janhahne/events{/privacy}","received_events_url":"https://api.github.com/users/janhahne/received_events","type":"User","site_admin":false},"repo":{"id":42115100,"name":"nest-simulator","full_name":"janhahne/nest-simulator","owner":{"login":"janhahne","id":13448785,"avatar_url":"https://avatars.githubusercontent.com/u/13448785?v=3","gravatar_id":"","url":"https://api.github.com/users/janhahne","html_url":"https://github.com/janhahne","followers_url":"https://api.github.com/users/janhahne/followers","following_url":"https://api.github.com/users/janhahne/following{/other_user}","gists_url":"https://api.github.com/users/janhahne/gists{/gist_id}","starred_url":"https://api.github.com/users/janhahne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janhahne/subscriptions","organizations_url":"https://api.github.com/users/janhahne/orgs","repos_url":"https://api.github.com/users/janhahne/repos","events_url":"https://api.github.com/users/janhahne/events{/privacy}","received_events_url":"https://api.github.com/users/janhahne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janhahne/nest-simulator","description":"The NEST simulator","fork":true,"url":"https://api.github.com/repos/janhahne/nest-simulator","forks_url":"https://api.github.com/repos/janhahne/nest-simulator/forks","keys_url":"https://api.github.com/repos/janhahne/nest-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janhahne/nest-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janhahne/nest-simulator/teams","hooks_url":"https://api.github.com/repos/janhahne/nest-simulator/hooks","issue_events_url":"https://api.github.com/repos/janhahne/nest-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/janhahne/nest-simulator/events","assignees_url":"https://api.github.com/repos/janhahne/nest-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/janhahne/nest-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/janhahne/nest-simulator/tags","blobs_url":"https://api.github.com/repos/janhahne/nest-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janhahne/nest-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janhahne/nest-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/janhahne/nest-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janhahne/nest-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/janhahne/nest-simulator/languages","stargazers_url":"https://api.github.com/repos/janhahne/nest-simulator/stargazers","contributors_url":"https://api.github.com/repos/janhahne/nest-simulator/contributors","subscribers_url":"https://api.github.com/repos/janhahne/nest-simulator/subscribers","subscription_url":"https://api.github.com/repos/janhahne/nest-simulator/subscription","commits_url":"https://api.github.com/repos/janhahne/nest-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/janhahne/nest-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/janhahne/nest-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/janhahne/nest-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/janhahne/nest-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/janhahne/nest-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janhahne/nest-simulator/merges","archive_url":"https://api.github.com/repos/janhahne/nest-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janhahne/nest-simulator/downloads","issues_url":"https://api.github.com/repos/janhahne/nest-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/janhahne/nest-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/janhahne/nest-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/janhahne/nest-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janhahne/nest-simulator/labels{/name}","releases_url":"https://api.github.com/repos/janhahne/nest-simulator/releases{/id}","deployments_url":"https://api.github.com/repos/janhahne/nest-simulator/deployments","created_at":"2015-09-08T13:50:05Z","updated_at":"2016-01-14T11:42:18Z","pushed_at":"2016-10-20T14:37:27Z","git_url":"git://github.com/janhahne/nest-simulator.git","ssh_url":"git@github.com:janhahne/nest-simulator.git","clone_url":"https://github.com/janhahne/nest-simulator.git","svn_url":"https://github.com/janhahne/nest-simulator","homepage":null,"size":18182,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nest:master","ref":"master","sha":"249fc8de9f53bbd88b3a8614d1a16ab5d0ef8b22","user":{"login":"nest","id":2377019,"avatar_url":"https://avatars.githubusercontent.com/u/2377019?v=3","gravatar_id":"","url":"https://api.github.com/users/nest","html_url":"https://github.com/nest","followers_url":"https://api.github.com/users/nest/followers","following_url":"https://api.github.com/users/nest/following{/other_user}","gists_url":"https://api.github.com/users/nest/gists{/gist_id}","starred_url":"https://api.github.com/users/nest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nest/subscriptions","organizations_url":"https://api.github.com/users/nest/orgs","repos_url":"https://api.github.com/users/nest/repos","events_url":"https://api.github.com/users/nest/events{/privacy}","received_events_url":"https://api.github.com/users/nest/received_events","type":"Organization","site_admin":false},"repo":{"id":33933892,"name":"nest-simulator","full_name":"nest/nest-simulator","owner":{"login":"nest","id":2377019,"avatar_url":"https://avatars.githubusercontent.com/u/2377019?v=3","gravatar_id":"","url":"https://api.github.com/users/nest","html_url":"https://github.com/nest","followers_url":"https://api.github.com/users/nest/followers","following_url":"https://api.github.com/users/nest/following{/other_user}","gists_url":"https://api.github.com/users/nest/gists{/gist_id}","starred_url":"https://api.github.com/users/nest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nest/subscriptions","organizations_url":"https://api.github.com/users/nest/orgs","repos_url":"https://api.github.com/users/nest/repos","events_url":"https://api.github.com/users/nest/events{/privacy}","received_events_url":"https://api.github.com/users/nest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nest/nest-simulator","description":"The NEST simulator","fork":false,"url":"https://api.github.com/repos/nest/nest-simulator","forks_url":"https://api.github.com/repos/nest/nest-simulator/forks","keys_url":"https://api.github.com/repos/nest/nest-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nest/nest-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nest/nest-simulator/teams","hooks_url":"https://api.github.com/repos/nest/nest-simulator/hooks","issue_events_url":"https://api.github.com/repos/nest/nest-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/nest/nest-simulator/events","assignees_url":"https://api.github.com/repos/nest/nest-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/nest/nest-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/nest/nest-simulator/tags","blobs_url":"https://api.github.com/repos/nest/nest-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nest/nest-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nest/nest-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/nest/nest-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nest/nest-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/nest/nest-simulator/languages","stargazers_url":"https://api.github.com/repos/nest/nest-simulator/stargazers","contributors_url":"https://api.github.com/repos/nest/nest-simulator/contributors","subscribers_url":"https://api.github.com/repos/nest/nest-simulator/subscribers","subscription_url":"https://api.github.com/repos/nest/nest-simulator/subscription","commits_url":"https://api.github.com/repos/nest/nest-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/nest/nest-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/nest/nest-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/nest/nest-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/nest/nest-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/nest/nest-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nest/nest-simulator/merges","archive_url":"https://api.github.com/repos/nest/nest-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nest/nest-simulator/downloads","issues_url":"https://api.github.com/repos/nest/nest-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/nest/nest-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/nest/nest-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/nest/nest-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nest/nest-simulator/labels{/name}","releases_url":"https://api.github.com/repos/nest/nest-simulator/releases{/id}","deployments_url":"https://api.github.com/repos/nest/nest-simulator/deployments","created_at":"2015-04-14T13:39:12Z","updated_at":"2016-10-25T16:43:30Z","pushed_at":"2016-10-26T07:11:45Z","git_url":"git://github.com/nest/nest-simulator.git","ssh_url":"git@github.com:nest/nest-simulator.git","clone_url":"https://github.com/nest/nest-simulator.git","svn_url":"https://github.com/nest/nest-simulator","homepage":null,"size":35595,"stargazers_count":88,"watchers_count":88,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":90,"mirror_url":null,"open_issues_count":166,"forks":90,"open_issues":166,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/524"},"html":{"href":"https://github.com/nest/nest-simulator/pull/524"},"issue":{"href":"https://api.github.com/repos/nest/nest-simulator/issues/524"},"comments":{"href":"https://api.github.com/repos/nest/nest-simulator/issues/524/comments"},"review_comments":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/524/comments"},"review_comment":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/524/commits"},"statuses":{"href":"https://api.github.com/repos/nest/nest-simulator/statuses/cfe0f3e6aed75a76732620948101f2c1f4c2c549"}}}}
{"actor":{"display_login":"janhahne"}}