{"action":"created","comment":{"url":"https://api.github.com/repos/esl/escalus/pulls/comments/62051999","id":62051999,"diff_hunk":"@@ -642,6 +643,12 @@ is_compressed(#xmlel{name = <<\"compressed\">>} = Stanza) ->\n is_compressed(_) ->\n     false.\n \n+is_bind_result(#xmlel{} = Stanza) ->","path":"src/escalus_pred.erl","position":14,"original_position":14,"commit_id":"450e2e4c8593ee9382a08df7d046951d4a93178d","original_commit_id":"450e2e4c8593ee9382a08df7d046951d4a93178d","user":{"login":"gadgetci","id":10134338,"avatar_url":"https://avatars.githubusercontent.com/u/10134338?v=3","gravatar_id":"","url":"https://api.github.com/users/gadgetci","html_url":"https://github.com/gadgetci","followers_url":"https://api.github.com/users/gadgetci/followers","following_url":"https://api.github.com/users/gadgetci/following{/other_user}","gists_url":"https://api.github.com/users/gadgetci/gists{/gist_id}","starred_url":"https://api.github.com/users/gadgetci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gadgetci/subscriptions","organizations_url":"https://api.github.com/users/gadgetci/orgs","repos_url":"https://api.github.com/users/gadgetci/repos","events_url":"https://api.github.com/users/gadgetci/events{/privacy}","received_events_url":"https://api.github.com/users/gadgetci/received_events","type":"User","site_admin":false},"body":"According to **Compiler**:\n> Warning: missing specification for function is_bind_result/1","created_at":"2016-05-04T14:46:54Z","updated_at":"2016-05-04T14:46:54Z","html_url":"https://github.com/esl/escalus/pull/108#discussion_r62051999","pull_request_url":"https://api.github.com/repos/esl/escalus/pulls/108","_links":{"self":{"href":"https://api.github.com/repos/esl/escalus/pulls/comments/62051999"},"html":{"href":"https://github.com/esl/escalus/pull/108#discussion_r62051999"},"pull_request":{"href":"https://api.github.com/repos/esl/escalus/pulls/108"}}},"pull_request":{"url":"https://api.github.com/repos/esl/escalus/pulls/108","id":68874254,"html_url":"https://github.com/esl/escalus/pull/108","diff_url":"https://github.com/esl/escalus/pull/108.diff","patch_url":"https://github.com/esl/escalus/pull/108.patch","issue_url":"https://api.github.com/repos/esl/escalus/issues/108","number":108,"state":"open","locked":false,"title":"Improve flexibility and correctness","user":{"login":"erszcz","id":112145,"avatar_url":"https://avatars.githubusercontent.com/u/112145?v=3","gravatar_id":"","url":"https://api.github.com/users/erszcz","html_url":"https://github.com/erszcz","followers_url":"https://api.github.com/users/erszcz/followers","following_url":"https://api.github.com/users/erszcz/following{/other_user}","gists_url":"https://api.github.com/users/erszcz/gists{/gist_id}","starred_url":"https://api.github.com/users/erszcz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erszcz/subscriptions","organizations_url":"https://api.github.com/users/erszcz/orgs","repos_url":"https://api.github.com/users/erszcz/repos","events_url":"https://api.github.com/users/erszcz/events{/privacy}","received_events_url":"https://api.github.com/users/erszcz/received_events","type":"User","site_admin":false},"body":"Be more flexible in terms of extensions, but more strict with regard to correctness of use:\r\n\r\n- allow for specifying `connection_steps` from the user spec\r\n\r\n- require passing connection module as is, not a shorthand form (i.e. `escalus_tcp` not just `tcp`) - such modules can now be developed outside Escalus and treated equally to the provided implementations\r\n\r\n- complain when an atom is passed as a stanza Recipient, as it's not clear in such a case whether the atom should be translated to a bare or a full JID - _explicit is better than implicit_\r\n\r\n- escalus_tcp: allow to override `parser_opts` from the user spec\r\n\r\nNone of the changes is breaking current API, but some new warnings will be generated. Old code is marked with `TODO`s for future removal.","created_at":"2016-05-04T14:46:21Z","updated_at":"2016-05-04T14:46:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c690be0c179053b118bdef2343ba7364bf6358e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/esl/escalus/pulls/108/commits","review_comments_url":"https://api.github.com/repos/esl/escalus/pulls/108/comments","review_comment_url":"https://api.github.com/repos/esl/escalus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/esl/escalus/issues/108/comments","statuses_url":"https://api.github.com/repos/esl/escalus/statuses/450e2e4c8593ee9382a08df7d046951d4a93178d","head":{"label":"esl:2.6.3-spec-extensions-rebase","ref":"2.6.3-spec-extensions-rebase","sha":"450e2e4c8593ee9382a08df7d046951d4a93178d","user":{"login":"esl","id":283412,"avatar_url":"https://avatars.githubusercontent.com/u/283412?v=3","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"repo":{"id":1934832,"name":"escalus","full_name":"esl/escalus","owner":{"login":"esl","id":283412,"avatar_url":"https://avatars.githubusercontent.com/u/283412?v=3","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/esl/escalus","description":"An XMPP client library in Erlang for conveniently testing XMPP servers","fork":false,"url":"https://api.github.com/repos/esl/escalus","forks_url":"https://api.github.com/repos/esl/escalus/forks","keys_url":"https://api.github.com/repos/esl/escalus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esl/escalus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esl/escalus/teams","hooks_url":"https://api.github.com/repos/esl/escalus/hooks","issue_events_url":"https://api.github.com/repos/esl/escalus/issues/events{/number}","events_url":"https://api.github.com/repos/esl/escalus/events","assignees_url":"https://api.github.com/repos/esl/escalus/assignees{/user}","branches_url":"https://api.github.com/repos/esl/escalus/branches{/branch}","tags_url":"https://api.github.com/repos/esl/escalus/tags","blobs_url":"https://api.github.com/repos/esl/escalus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esl/escalus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esl/escalus/git/refs{/sha}","trees_url":"https://api.github.com/repos/esl/escalus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esl/escalus/statuses/{sha}","languages_url":"https://api.github.com/repos/esl/escalus/languages","stargazers_url":"https://api.github.com/repos/esl/escalus/stargazers","contributors_url":"https://api.github.com/repos/esl/escalus/contributors","subscribers_url":"https://api.github.com/repos/esl/escalus/subscribers","subscription_url":"https://api.github.com/repos/esl/escalus/subscription","commits_url":"https://api.github.com/repos/esl/escalus/commits{/sha}","git_commits_url":"https://api.github.com/repos/esl/escalus/git/commits{/sha}","comments_url":"https://api.github.com/repos/esl/escalus/comments{/number}","issue_comment_url":"https://api.github.com/repos/esl/escalus/issues/comments{/number}","contents_url":"https://api.github.com/repos/esl/escalus/contents/{+path}","compare_url":"https://api.github.com/repos/esl/escalus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esl/escalus/merges","archive_url":"https://api.github.com/repos/esl/escalus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esl/escalus/downloads","issues_url":"https://api.github.com/repos/esl/escalus/issues{/number}","pulls_url":"https://api.github.com/repos/esl/escalus/pulls{/number}","milestones_url":"https://api.github.com/repos/esl/escalus/milestones{/number}","notifications_url":"https://api.github.com/repos/esl/escalus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esl/escalus/labels{/name}","releases_url":"https://api.github.com/repos/esl/escalus/releases{/id}","deployments_url":"https://api.github.com/repos/esl/escalus/deployments","created_at":"2011-06-22T13:03:44Z","updated_at":"2016-04-20T09:21:33Z","pushed_at":"2016-05-04T14:46:22Z","git_url":"git://github.com/esl/escalus.git","ssh_url":"git@github.com:esl/escalus.git","clone_url":"https://github.com/esl/escalus.git","svn_url":"https://github.com/esl/escalus","homepage":"","size":2326,"stargazers_count":70,"watchers_count":70,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":13,"forks":40,"open_issues":13,"watchers":70,"default_branch":"master"}},"base":{"label":"esl:master","ref":"master","sha":"ff7a2242f02f309b805f54145d7fda9aa756f841","user":{"login":"esl","id":283412,"avatar_url":"https://avatars.githubusercontent.com/u/283412?v=3","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"repo":{"id":1934832,"name":"escalus","full_name":"esl/escalus","owner":{"login":"esl","id":283412,"avatar_url":"https://avatars.githubusercontent.com/u/283412?v=3","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/esl/escalus","description":"An XMPP client library in Erlang for conveniently testing XMPP servers","fork":false,"url":"https://api.github.com/repos/esl/escalus","forks_url":"https://api.github.com/repos/esl/escalus/forks","keys_url":"https://api.github.com/repos/esl/escalus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esl/escalus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esl/escalus/teams","hooks_url":"https://api.github.com/repos/esl/escalus/hooks","issue_events_url":"https://api.github.com/repos/esl/escalus/issues/events{/number}","events_url":"https://api.github.com/repos/esl/escalus/events","assignees_url":"https://api.github.com/repos/esl/escalus/assignees{/user}","branches_url":"https://api.github.com/repos/esl/escalus/branches{/branch}","tags_url":"https://api.github.com/repos/esl/escalus/tags","blobs_url":"https://api.github.com/repos/esl/escalus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esl/escalus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esl/escalus/git/refs{/sha}","trees_url":"https://api.github.com/repos/esl/escalus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esl/escalus/statuses/{sha}","languages_url":"https://api.github.com/repos/esl/escalus/languages","stargazers_url":"https://api.github.com/repos/esl/escalus/stargazers","contributors_url":"https://api.github.com/repos/esl/escalus/contributors","subscribers_url":"https://api.github.com/repos/esl/escalus/subscribers","subscription_url":"https://api.github.com/repos/esl/escalus/subscription","commits_url":"https://api.github.com/repos/esl/escalus/commits{/sha}","git_commits_url":"https://api.github.com/repos/esl/escalus/git/commits{/sha}","comments_url":"https://api.github.com/repos/esl/escalus/comments{/number}","issue_comment_url":"https://api.github.com/repos/esl/escalus/issues/comments{/number}","contents_url":"https://api.github.com/repos/esl/escalus/contents/{+path}","compare_url":"https://api.github.com/repos/esl/escalus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esl/escalus/merges","archive_url":"https://api.github.com/repos/esl/escalus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esl/escalus/downloads","issues_url":"https://api.github.com/repos/esl/escalus/issues{/number}","pulls_url":"https://api.github.com/repos/esl/escalus/pulls{/number}","milestones_url":"https://api.github.com/repos/esl/escalus/milestones{/number}","notifications_url":"https://api.github.com/repos/esl/escalus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esl/escalus/labels{/name}","releases_url":"https://api.github.com/repos/esl/escalus/releases{/id}","deployments_url":"https://api.github.com/repos/esl/escalus/deployments","created_at":"2011-06-22T13:03:44Z","updated_at":"2016-04-20T09:21:33Z","pushed_at":"2016-05-04T14:46:22Z","git_url":"git://github.com/esl/escalus.git","ssh_url":"git@github.com:esl/escalus.git","clone_url":"https://github.com/esl/escalus.git","svn_url":"https://github.com/esl/escalus","homepage":"","size":2326,"stargazers_count":70,"watchers_count":70,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":13,"forks":40,"open_issues":13,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/esl/escalus/pulls/108"},"html":{"href":"https://github.com/esl/escalus/pull/108"},"issue":{"href":"https://api.github.com/repos/esl/escalus/issues/108"},"comments":{"href":"https://api.github.com/repos/esl/escalus/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/esl/escalus/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/esl/escalus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/esl/escalus/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/esl/escalus/statuses/450e2e4c8593ee9382a08df7d046951d4a93178d"}}}}