{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/19225","repository_url":"https://api.github.com/repos/elastic/elasticsearch","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/19225/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/19225/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/19225/events","html_url":"https://github.com/elastic/elasticsearch/pull/19225","id":163488889,"number":19225,"title":"Internal: Remove generics from LifecycleComponent","user":{"login":"rjernst","id":289412,"avatar_url":"https://avatars.githubusercontent.com/u/289412?v=3","gravatar_id":"","url":"https://api.github.com/users/rjernst","html_url":"https://github.com/rjernst","followers_url":"https://api.github.com/users/rjernst/followers","following_url":"https://api.github.com/users/rjernst/following{/other_user}","gists_url":"https://api.github.com/users/rjernst/gists{/gist_id}","starred_url":"https://api.github.com/users/rjernst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjernst/subscriptions","organizations_url":"https://api.github.com/users/rjernst/orgs","repos_url":"https://api.github.com/users/rjernst/repos","events_url":"https://api.github.com/users/rjernst/events{/privacy}","received_events_url":"https://api.github.com/users/rjernst/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Internal","name":":Internal","color":"009800"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v5.0.0","name":"v5.0.0","color":"dddddd"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-01T23:20:24Z","updated_at":"2016-07-01T23:22:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/19225","html_url":"https://github.com/elastic/elasticsearch/pull/19225","diff_url":"https://github.com/elastic/elasticsearch/pull/19225.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/19225.patch"},"body":"The only reason for LifecycleComponent taking a generic type was so that\r\nit could return that type on its start and stop methods. However, this\r\nchaining has no practical necessity. Instead, start and stop can be\r\nvoid, and a whole bunch of confusing generics disappear."},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/230067100","html_url":"https://github.com/elastic/elasticsearch/pull/19225#issuecomment-230067100","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/19225","id":230067100,"user":{"login":"dakrone","id":19060,"avatar_url":"https://avatars.githubusercontent.com/u/19060?v=3","gravatar_id":"","url":"https://api.github.com/users/dakrone","html_url":"https://github.com/dakrone","followers_url":"https://api.github.com/users/dakrone/followers","following_url":"https://api.github.com/users/dakrone/following{/other_user}","gists_url":"https://api.github.com/users/dakrone/gists{/gist_id}","starred_url":"https://api.github.com/users/dakrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dakrone/subscriptions","organizations_url":"https://api.github.com/users/dakrone/orgs","repos_url":"https://api.github.com/users/dakrone/repos","events_url":"https://api.github.com/users/dakrone/events{/privacy}","received_events_url":"https://api.github.com/users/dakrone/received_events","type":"User","site_admin":false},"created_at":"2016-07-01T23:22:26Z","updated_at":"2016-07-01T23:22:26Z","body":"LGTM"}}
{"actor":{"display_login":"dakrone"}}