{"action":"created","issue":{"url":"https://api.github.com/repos/qorelanguage/module-oracle/issues/41","repository_url":"https://api.github.com/repos/qorelanguage/module-oracle","labels_url":"https://api.github.com/repos/qorelanguage/module-oracle/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/qorelanguage/module-oracle/issues/41/comments","events_url":"https://api.github.com/repos/qorelanguage/module-oracle/issues/41/events","html_url":"https://github.com/qorelanguage/module-oracle/pull/41","id":190804954,"number":41,"title":"Rewrote tests to QUnit + added a new test","user":{"login":"omusil24","id":14920839,"avatar_url":"https://avatars.githubusercontent.com/u/14920839?v=3","gravatar_id":"","url":"https://api.github.com/users/omusil24","html_url":"https://github.com/omusil24","followers_url":"https://api.github.com/users/omusil24/followers","following_url":"https://api.github.com/users/omusil24/following{/other_user}","gists_url":"https://api.github.com/users/omusil24/gists{/gist_id}","starred_url":"https://api.github.com/users/omusil24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omusil24/subscriptions","organizations_url":"https://api.github.com/users/omusil24/orgs","repos_url":"https://api.github.com/users/omusil24/repos","events_url":"https://api.github.com/users/omusil24/events{/privacy}","received_events_url":"https://api.github.com/users/omusil24/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"davidnich","id":13432105,"avatar_url":"https://avatars.githubusercontent.com/u/13432105?v=3","gravatar_id":"","url":"https://api.github.com/users/davidnich","html_url":"https://github.com/davidnich","followers_url":"https://api.github.com/users/davidnich/followers","following_url":"https://api.github.com/users/davidnich/following{/other_user}","gists_url":"https://api.github.com/users/davidnich/gists{/gist_id}","starred_url":"https://api.github.com/users/davidnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidnich/subscriptions","organizations_url":"https://api.github.com/users/davidnich/orgs","repos_url":"https://api.github.com/users/davidnich/repos","events_url":"https://api.github.com/users/davidnich/events{/privacy}","received_events_url":"https://api.github.com/users/davidnich/received_events","type":"User","site_admin":false},"assignees":[{"login":"davidnich","id":13432105,"avatar_url":"https://avatars.githubusercontent.com/u/13432105?v=3","gravatar_id":"","url":"https://api.github.com/users/davidnich","html_url":"https://github.com/davidnich","followers_url":"https://api.github.com/users/davidnich/followers","following_url":"https://api.github.com/users/davidnich/following{/other_user}","gists_url":"https://api.github.com/users/davidnich/gists{/gist_id}","starred_url":"https://api.github.com/users/davidnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidnich/subscriptions","organizations_url":"https://api.github.com/users/davidnich/orgs","repos_url":"https://api.github.com/users/davidnich/repos","events_url":"https://api.github.com/users/davidnich/events{/privacy}","received_events_url":"https://api.github.com/users/davidnich/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-11-21T18:55:37Z","updated_at":"2016-11-22T11:47:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/qorelanguage/module-oracle/pulls/41","html_url":"https://github.com/qorelanguage/module-oracle/pull/41","diff_url":"https://github.com/qorelanguage/module-oracle/pull/41.diff","patch_url":"https://github.com/qorelanguage/module-oracle/pull/41.patch"},"body":"refs qorelanguage/qore#66"},"comment":{"url":"https://api.github.com/repos/qorelanguage/module-oracle/issues/comments/262220891","html_url":"https://github.com/qorelanguage/module-oracle/pull/41#issuecomment-262220891","issue_url":"https://api.github.com/repos/qorelanguage/module-oracle/issues/41","id":262220891,"user":{"login":"omusil24","id":14920839,"avatar_url":"https://avatars.githubusercontent.com/u/14920839?v=3","gravatar_id":"","url":"https://api.github.com/users/omusil24","html_url":"https://github.com/omusil24","followers_url":"https://api.github.com/users/omusil24/followers","following_url":"https://api.github.com/users/omusil24/following{/other_user}","gists_url":"https://api.github.com/users/omusil24/gists{/gist_id}","starred_url":"https://api.github.com/users/omusil24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omusil24/subscriptions","organizations_url":"https://api.github.com/users/omusil24/orgs","repos_url":"https://api.github.com/users/omusil24/repos","events_url":"https://api.github.com/users/omusil24/events{/privacy}","received_events_url":"https://api.github.com/users/omusil24/received_events","type":"User","site_admin":false},"created_at":"2016-11-22T11:47:39Z","updated_at":"2016-11-22T11:47:39Z","body":"I deleted the old tests. Regarding aq-test, it's not an independent test AFAIK - it reads data from the user, so it cannot be easily rewritten to QUnit (it doesn't even make sense IMO).\r\nAh, the CHAR column isn't actually an encoding issue - it's just because Oracle is padding short CHAR values with spaces, unlike MySQL or PGSQL which pad it with '\\0', so I thought that testing with VARCHAR and VARCHAR2 should be enough. But I just added/fixed this anyway...\r\n\r\nRegarding the NCHAR and NVARCHAR2 columns - there it's an UTF-16 problem: https://gist.github.com/omusil24/25d1eb7686e25d491927a576eb8f367d\r\n\r\nWith NCLOB column, there's a different problem but in my opinion connected to encoding too:\r\nhttps://gist.github.com/omusil24/718efa27f6fbec706d529da5ba4dbc32\r\n\r\nI was thinking that this should be fixed separately."}}
{"actor":{"display_login":"omusil24"}}