{"action":"created","issue":{"url":"https://api.github.com/repos/svaarala/duktape/issues/742","repository_url":"https://api.github.com/repos/svaarala/duktape","labels_url":"https://api.github.com/repos/svaarala/duktape/issues/742/labels{/name}","comments_url":"https://api.github.com/repos/svaarala/duktape/issues/742/comments","events_url":"https://api.github.com/repos/svaarala/duktape/issues/742/events","html_url":"https://github.com/svaarala/duktape/pull/742","id":153125621,"number":742,"title":"Merge duk_debugger_attach_custom() and duk_debugger_attach() API calls","user":{"login":"svaarala","id":6377415,"avatar_url":"https://avatars.githubusercontent.com/u/6377415?v=3","gravatar_id":"","url":"https://api.github.com/users/svaarala","html_url":"https://github.com/svaarala","followers_url":"https://api.github.com/users/svaarala/followers","following_url":"https://api.github.com/users/svaarala/following{/other_user}","gists_url":"https://api.github.com/users/svaarala/gists{/gist_id}","starred_url":"https://api.github.com/users/svaarala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svaarala/subscriptions","organizations_url":"https://api.github.com/users/svaarala/orgs","repos_url":"https://api.github.com/users/svaarala/repos","events_url":"https://api.github.com/users/svaarala/events{/privacy}","received_events_url":"https://api.github.com/users/svaarala/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/svaarala/duktape/labels/api","name":"api","color":"bfd4f2"},{"url":"https://api.github.com/repos/svaarala/duktape/labels/debugger","name":"debugger","color":"bfdadc"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/svaarala/duktape/milestones/5","html_url":"https://github.com/svaarala/duktape/milestones/v2.0.0","labels_url":"https://api.github.com/repos/svaarala/duktape/milestones/5/labels","id":840957,"number":5,"title":"v2.0.0","description":"","creator":{"login":"svaarala","id":6377415,"avatar_url":"https://avatars.githubusercontent.com/u/6377415?v=3","gravatar_id":"","url":"https://api.github.com/users/svaarala","html_url":"https://github.com/svaarala","followers_url":"https://api.github.com/users/svaarala/followers","following_url":"https://api.github.com/users/svaarala/following{/other_user}","gists_url":"https://api.github.com/users/svaarala/gists{/gist_id}","starred_url":"https://api.github.com/users/svaarala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svaarala/subscriptions","organizations_url":"https://api.github.com/users/svaarala/orgs","repos_url":"https://api.github.com/users/svaarala/repos","events_url":"https://api.github.com/users/svaarala/events{/privacy}","received_events_url":"https://api.github.com/users/svaarala/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":2,"state":"open","created_at":"2014-10-26T15:05:37Z","updated_at":"2016-05-04T22:12:21Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-05-04T22:04:11Z","updated_at":"2016-05-04T23:38:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/svaarala/duktape/pulls/742","html_url":"https://github.com/svaarala/duktape/pull/742","diff_url":"https://github.com/svaarala/duktape/pull/742.diff","patch_url":"https://github.com/svaarala/duktape/pull/742.patch"},"body":"Rename `duk_debugger_attach_custom()` to `duk_debugger_attach()` to remove an unnecessary API call variant. The variant was added in 1.x when AppRequest was implemented and API compatibility couldn't be broken by adding the necessary AppRequest callback to `duk_debugger_attach()`.\r\n\r\nFixes #735."},"comment":{"url":"https://api.github.com/repos/svaarala/duktape/issues/comments/217039526","html_url":"https://github.com/svaarala/duktape/pull/742#issuecomment-217039526","issue_url":"https://api.github.com/repos/svaarala/duktape/issues/742","id":217039526,"user":{"login":"fatcerberus","id":4097841,"avatar_url":"https://avatars.githubusercontent.com/u/4097841?v=3","gravatar_id":"","url":"https://api.github.com/users/fatcerberus","html_url":"https://github.com/fatcerberus","followers_url":"https://api.github.com/users/fatcerberus/followers","following_url":"https://api.github.com/users/fatcerberus/following{/other_user}","gists_url":"https://api.github.com/users/fatcerberus/gists{/gist_id}","starred_url":"https://api.github.com/users/fatcerberus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatcerberus/subscriptions","organizations_url":"https://api.github.com/users/fatcerberus/orgs","repos_url":"https://api.github.com/users/fatcerberus/repos","events_url":"https://api.github.com/users/fatcerberus/events{/privacy}","received_events_url":"https://api.github.com/users/fatcerberus/received_events","type":"User","site_admin":false},"created_at":"2016-05-04T23:38:31Z","updated_at":"2016-05-04T23:38:31Z","body":"While this is open, maybe add a clarification somewhere in the documentation that the request callback should avoid blocking, since the client is waiting for a reply and might time out."}}