{"action":"opened","issue":{"url":"https://api.github.com/repos/leobalter/proposal-setmap-offrom/issues/4","repository_url":"https://api.github.com/repos/leobalter/proposal-setmap-offrom","labels_url":"https://api.github.com/repos/leobalter/proposal-setmap-offrom/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/leobalter/proposal-setmap-offrom/issues/4/comments","events_url":"https://api.github.com/repos/leobalter/proposal-setmap-offrom/issues/4/events","html_url":"https://github.com/leobalter/proposal-setmap-offrom/issues/4","id":175135599,"number":4,"title":"Get rid of GetCollectionAddMethod","user":{"login":"allenwb","id":505435,"avatar_url":"https://avatars.githubusercontent.com/u/505435?v=3","gravatar_id":"","url":"https://api.github.com/users/allenwb","html_url":"https://github.com/allenwb","followers_url":"https://api.github.com/users/allenwb/followers","following_url":"https://api.github.com/users/allenwb/following{/other_user}","gists_url":"https://api.github.com/users/allenwb/gists{/gist_id}","starred_url":"https://api.github.com/users/allenwb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenwb/subscriptions","organizations_url":"https://api.github.com/users/allenwb/orgs","repos_url":"https://api.github.com/users/allenwb/repos","events_url":"https://api.github.com/users/allenwb/events{/privacy}","received_events_url":"https://api.github.com/users/allenwb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-05T23:15:28Z","updated_at":"2016-09-05T23:15:28Z","closed_at":null,"body":"As written, GetCollectionAddMethod won't work with a subclass of Map/Set/etc.  \r\n\r\nI suggest that you get rid of it and replace it with an additional parameter to CollectionCreateFrom.\r\n\r\nThe the call from Map.from/WeakMap.from would look like:\r\nCollectionCreateFropm(_C_, _source_, \"set\",  _mapFn_, _thisArg_)\r\n\r\nand the call from Set.from/WeakSetFrom would look like\r\nCollectionCreateFropm(_C_, _source_, \"add\",  _mapFn_, _thisArg_)"}}
{"actor":{"display_login":"allenwb"}}