{"action":"created","comment":{"url":"https://api.github.com/repos/pivotal-cf/om/pulls/comments/85995160","pull_request_review_id":6676645,"id":85995160,"diff_hunk":"@@ -39,9 +40,7 @@ func NewOAuthClient(target, username, password string, insecureSkipVerify bool)\n \t\t\t\tTimeout:   5 * time.Second,\n \t\t\t\tKeepAlive: 30 * time.Second,\n \t\t\t}).Dial,\n-\t\t\tResponseHeaderTimeout: 15 * time.Minute,","path":"network/oauth_client.go","position":23,"original_position":16,"commit_id":"63267a576be660b2af9b7072e067806820e0f6ab","original_commit_id":"c39e5975b964330107c820ff5c982067fd975a4e","user":{"login":"aditya87","id":770739,"avatar_url":"https://avatars.githubusercontent.com/u/770739?v=3","gravatar_id":"","url":"https://api.github.com/users/aditya87","html_url":"https://github.com/aditya87","followers_url":"https://api.github.com/users/aditya87/followers","following_url":"https://api.github.com/users/aditya87/following{/other_user}","gists_url":"https://api.github.com/users/aditya87/gists{/gist_id}","starred_url":"https://api.github.com/users/aditya87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aditya87/subscriptions","organizations_url":"https://api.github.com/users/aditya87/orgs","repos_url":"https://api.github.com/users/aditya87/repos","events_url":"https://api.github.com/users/aditya87/events{/privacy}","received_events_url":"https://api.github.com/users/aditya87/received_events","type":"User","site_admin":false},"body":"We added the ResponseHeaderTimeout because we wanted to make sure that we also enforced that. This is separate from the overall timeout, which, as replied below, we believe is respected. We are OK with removing it since we agree that it should cover the entire lifecycle of the connection, but if we see issues related to this we may add it back.\r\nhttps://blog.cloudflare.com/the-complete-guide-to-golang-net-http-timeouts/","created_at":"2016-11-01T18:36:44Z","updated_at":"2016-11-01T18:36:44Z","html_url":"https://github.com/pivotal-cf/om/pull/10#discussion_r85995160","pull_request_url":"https://api.github.com/repos/pivotal-cf/om/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/pivotal-cf/om/pulls/comments/85995160"},"html":{"href":"https://github.com/pivotal-cf/om/pull/10#discussion_r85995160"},"pull_request":{"href":"https://api.github.com/repos/pivotal-cf/om/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/pivotal-cf/om/pulls/10","id":91813962,"html_url":"https://github.com/pivotal-cf/om/pull/10","diff_url":"https://github.com/pivotal-cf/om/pull/10.diff","patch_url":"https://github.com/pivotal-cf/om/pull/10.patch","issue_url":"https://api.github.com/repos/pivotal-cf/om/issues/10","number":10,"state":"open","locked":false,"title":"Adding support for configurable timeouts on requests","user":{"login":"adi-mishra","id":5606011,"avatar_url":"https://avatars.githubusercontent.com/u/5606011?v=3","gravatar_id":"","url":"https://api.github.com/users/adi-mishra","html_url":"https://github.com/adi-mishra","followers_url":"https://api.github.com/users/adi-mishra/followers","following_url":"https://api.github.com/users/adi-mishra/following{/other_user}","gists_url":"https://api.github.com/users/adi-mishra/gists{/gist_id}","starred_url":"https://api.github.com/users/adi-mishra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adi-mishra/subscriptions","organizations_url":"https://api.github.com/users/adi-mishra/orgs","repos_url":"https://api.github.com/users/adi-mishra/repos","events_url":"https://api.github.com/users/adi-mishra/events{/privacy}","received_events_url":"https://api.github.com/users/adi-mishra/received_events","type":"User","site_admin":false},"body":"Moved the timeouts from oauth_client.NewOAuthClient.httpclient because the Timeout variable at http.Client level won't take effect due to the way oauth2 constructs the client. And didn't want to set 'ResponseHeaderTimeout' in Transport layer because it doesn't seem to be the expected behaviour of the option provided in cli.","created_at":"2016-11-01T16:18:00Z","updated_at":"2016-11-01T18:36:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bd8c051cca87c0dab18cf55e7ba7736354bfec2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pivotal-cf/om/pulls/10/commits","review_comments_url":"https://api.github.com/repos/pivotal-cf/om/pulls/10/comments","review_comment_url":"https://api.github.com/repos/pivotal-cf/om/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pivotal-cf/om/issues/10/comments","statuses_url":"https://api.github.com/repos/pivotal-cf/om/statuses/63267a576be660b2af9b7072e067806820e0f6ab","head":{"label":"adi-mishra:master","ref":"master","sha":"63267a576be660b2af9b7072e067806820e0f6ab","user":{"login":"adi-mishra","id":5606011,"avatar_url":"https://avatars.githubusercontent.com/u/5606011?v=3","gravatar_id":"","url":"https://api.github.com/users/adi-mishra","html_url":"https://github.com/adi-mishra","followers_url":"https://api.github.com/users/adi-mishra/followers","following_url":"https://api.github.com/users/adi-mishra/following{/other_user}","gists_url":"https://api.github.com/users/adi-mishra/gists{/gist_id}","starred_url":"https://api.github.com/users/adi-mishra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adi-mishra/subscriptions","organizations_url":"https://api.github.com/users/adi-mishra/orgs","repos_url":"https://api.github.com/users/adi-mishra/repos","events_url":"https://api.github.com/users/adi-mishra/events{/privacy}","received_events_url":"https://api.github.com/users/adi-mishra/received_events","type":"User","site_admin":false},"repo":{"id":72552970,"name":"om","full_name":"adi-mishra/om","owner":{"login":"adi-mishra","id":5606011,"avatar_url":"https://avatars.githubusercontent.com/u/5606011?v=3","gravatar_id":"","url":"https://api.github.com/users/adi-mishra","html_url":"https://github.com/adi-mishra","followers_url":"https://api.github.com/users/adi-mishra/followers","following_url":"https://api.github.com/users/adi-mishra/following{/other_user}","gists_url":"https://api.github.com/users/adi-mishra/gists{/gist_id}","starred_url":"https://api.github.com/users/adi-mishra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adi-mishra/subscriptions","organizations_url":"https://api.github.com/users/adi-mishra/orgs","repos_url":"https://api.github.com/users/adi-mishra/repos","events_url":"https://api.github.com/users/adi-mishra/events{/privacy}","received_events_url":"https://api.github.com/users/adi-mishra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adi-mishra/om","description":"small sharp tool for deploying products to ops-manager","fork":true,"url":"https://api.github.com/repos/adi-mishra/om","forks_url":"https://api.github.com/repos/adi-mishra/om/forks","keys_url":"https://api.github.com/repos/adi-mishra/om/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adi-mishra/om/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adi-mishra/om/teams","hooks_url":"https://api.github.com/repos/adi-mishra/om/hooks","issue_events_url":"https://api.github.com/repos/adi-mishra/om/issues/events{/number}","events_url":"https://api.github.com/repos/adi-mishra/om/events","assignees_url":"https://api.github.com/repos/adi-mishra/om/assignees{/user}","branches_url":"https://api.github.com/repos/adi-mishra/om/branches{/branch}","tags_url":"https://api.github.com/repos/adi-mishra/om/tags","blobs_url":"https://api.github.com/repos/adi-mishra/om/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adi-mishra/om/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adi-mishra/om/git/refs{/sha}","trees_url":"https://api.github.com/repos/adi-mishra/om/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adi-mishra/om/statuses/{sha}","languages_url":"https://api.github.com/repos/adi-mishra/om/languages","stargazers_url":"https://api.github.com/repos/adi-mishra/om/stargazers","contributors_url":"https://api.github.com/repos/adi-mishra/om/contributors","subscribers_url":"https://api.github.com/repos/adi-mishra/om/subscribers","subscription_url":"https://api.github.com/repos/adi-mishra/om/subscription","commits_url":"https://api.github.com/repos/adi-mishra/om/commits{/sha}","git_commits_url":"https://api.github.com/repos/adi-mishra/om/git/commits{/sha}","comments_url":"https://api.github.com/repos/adi-mishra/om/comments{/number}","issue_comment_url":"https://api.github.com/repos/adi-mishra/om/issues/comments{/number}","contents_url":"https://api.github.com/repos/adi-mishra/om/contents/{+path}","compare_url":"https://api.github.com/repos/adi-mishra/om/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adi-mishra/om/merges","archive_url":"https://api.github.com/repos/adi-mishra/om/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adi-mishra/om/downloads","issues_url":"https://api.github.com/repos/adi-mishra/om/issues{/number}","pulls_url":"https://api.github.com/repos/adi-mishra/om/pulls{/number}","milestones_url":"https://api.github.com/repos/adi-mishra/om/milestones{/number}","notifications_url":"https://api.github.com/repos/adi-mishra/om/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adi-mishra/om/labels{/name}","releases_url":"https://api.github.com/repos/adi-mishra/om/releases{/id}","deployments_url":"https://api.github.com/repos/adi-mishra/om/deployments","created_at":"2016-11-01T16:07:36Z","updated_at":"2016-11-01T16:07:37Z","pushed_at":"2016-11-01T18:06:56Z","git_url":"git://github.com/adi-mishra/om.git","ssh_url":"git@github.com:adi-mishra/om.git","clone_url":"https://github.com/adi-mishra/om.git","svn_url":"https://github.com/adi-mishra/om","homepage":"","size":1666,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pivotal-cf:master","ref":"master","sha":"edb95433e1b03e1330d744eafb7c4fea3b6a0050","user":{"login":"pivotal-cf","id":5497370,"avatar_url":"https://avatars.githubusercontent.com/u/5497370?v=3","gravatar_id":"","url":"https://api.github.com/users/pivotal-cf","html_url":"https://github.com/pivotal-cf","followers_url":"https://api.github.com/users/pivotal-cf/followers","following_url":"https://api.github.com/users/pivotal-cf/following{/other_user}","gists_url":"https://api.github.com/users/pivotal-cf/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotal-cf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotal-cf/subscriptions","organizations_url":"https://api.github.com/users/pivotal-cf/orgs","repos_url":"https://api.github.com/users/pivotal-cf/repos","events_url":"https://api.github.com/users/pivotal-cf/events{/privacy}","received_events_url":"https://api.github.com/users/pivotal-cf/received_events","type":"Organization","site_admin":false},"repo":{"id":68121501,"name":"om","full_name":"pivotal-cf/om","owner":{"login":"pivotal-cf","id":5497370,"avatar_url":"https://avatars.githubusercontent.com/u/5497370?v=3","gravatar_id":"","url":"https://api.github.com/users/pivotal-cf","html_url":"https://github.com/pivotal-cf","followers_url":"https://api.github.com/users/pivotal-cf/followers","following_url":"https://api.github.com/users/pivotal-cf/following{/other_user}","gists_url":"https://api.github.com/users/pivotal-cf/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotal-cf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotal-cf/subscriptions","organizations_url":"https://api.github.com/users/pivotal-cf/orgs","repos_url":"https://api.github.com/users/pivotal-cf/repos","events_url":"https://api.github.com/users/pivotal-cf/events{/privacy}","received_events_url":"https://api.github.com/users/pivotal-cf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pivotal-cf/om","description":"small sharp tool for deploying products to ops-manager","fork":false,"url":"https://api.github.com/repos/pivotal-cf/om","forks_url":"https://api.github.com/repos/pivotal-cf/om/forks","keys_url":"https://api.github.com/repos/pivotal-cf/om/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pivotal-cf/om/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pivotal-cf/om/teams","hooks_url":"https://api.github.com/repos/pivotal-cf/om/hooks","issue_events_url":"https://api.github.com/repos/pivotal-cf/om/issues/events{/number}","events_url":"https://api.github.com/repos/pivotal-cf/om/events","assignees_url":"https://api.github.com/repos/pivotal-cf/om/assignees{/user}","branches_url":"https://api.github.com/repos/pivotal-cf/om/branches{/branch}","tags_url":"https://api.github.com/repos/pivotal-cf/om/tags","blobs_url":"https://api.github.com/repos/pivotal-cf/om/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pivotal-cf/om/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pivotal-cf/om/git/refs{/sha}","trees_url":"https://api.github.com/repos/pivotal-cf/om/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pivotal-cf/om/statuses/{sha}","languages_url":"https://api.github.com/repos/pivotal-cf/om/languages","stargazers_url":"https://api.github.com/repos/pivotal-cf/om/stargazers","contributors_url":"https://api.github.com/repos/pivotal-cf/om/contributors","subscribers_url":"https://api.github.com/repos/pivotal-cf/om/subscribers","subscription_url":"https://api.github.com/repos/pivotal-cf/om/subscription","commits_url":"https://api.github.com/repos/pivotal-cf/om/commits{/sha}","git_commits_url":"https://api.github.com/repos/pivotal-cf/om/git/commits{/sha}","comments_url":"https://api.github.com/repos/pivotal-cf/om/comments{/number}","issue_comment_url":"https://api.github.com/repos/pivotal-cf/om/issues/comments{/number}","contents_url":"https://api.github.com/repos/pivotal-cf/om/contents/{+path}","compare_url":"https://api.github.com/repos/pivotal-cf/om/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pivotal-cf/om/merges","archive_url":"https://api.github.com/repos/pivotal-cf/om/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pivotal-cf/om/downloads","issues_url":"https://api.github.com/repos/pivotal-cf/om/issues{/number}","pulls_url":"https://api.github.com/repos/pivotal-cf/om/pulls{/number}","milestones_url":"https://api.github.com/repos/pivotal-cf/om/milestones{/number}","notifications_url":"https://api.github.com/repos/pivotal-cf/om/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pivotal-cf/om/labels{/name}","releases_url":"https://api.github.com/repos/pivotal-cf/om/releases{/id}","deployments_url":"https://api.github.com/repos/pivotal-cf/om/deployments","created_at":"2016-09-13T15:30:05Z","updated_at":"2016-10-26T13:44:42Z","pushed_at":"2016-11-01T18:09:34Z","git_url":"git://github.com/pivotal-cf/om.git","ssh_url":"git@github.com:pivotal-cf/om.git","clone_url":"https://github.com/pivotal-cf/om.git","svn_url":"https://github.com/pivotal-cf/om","homepage":"","size":1682,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pivotal-cf/om/pulls/10"},"html":{"href":"https://github.com/pivotal-cf/om/pull/10"},"issue":{"href":"https://api.github.com/repos/pivotal-cf/om/issues/10"},"comments":{"href":"https://api.github.com/repos/pivotal-cf/om/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/pivotal-cf/om/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/pivotal-cf/om/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pivotal-cf/om/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/pivotal-cf/om/statuses/63267a576be660b2af9b7072e067806820e0f6ab"}}}}
{"actor":{"display_login":"aditya87"}}