{"action":"opened","number":20,"pull_request":{"url":"https://api.github.com/repos/deseretbook/classy_hash/pulls/20","id":89328352,"html_url":"https://github.com/deseretbook/classy_hash/pull/20","diff_url":"https://github.com/deseretbook/classy_hash/pull/20.diff","patch_url":"https://github.com/deseretbook/classy_hash/pull/20.patch","issue_url":"https://api.github.com/repos/deseretbook/classy_hash/issues/20","number":20,"state":"open","locked":false,"title":"Use a specific custom Exception subclass","user":{"login":"jackcasey","id":45890,"avatar_url":"https://avatars.githubusercontent.com/u/45890?v=3","gravatar_id":"","url":"https://api.github.com/users/jackcasey","html_url":"https://github.com/jackcasey","followers_url":"https://api.github.com/users/jackcasey/followers","following_url":"https://api.github.com/users/jackcasey/following{/other_user}","gists_url":"https://api.github.com/users/jackcasey/gists{/gist_id}","starred_url":"https://api.github.com/users/jackcasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackcasey/subscriptions","organizations_url":"https://api.github.com/users/jackcasey/orgs","repos_url":"https://api.github.com/users/jackcasey/repos","events_url":"https://api.github.com/users/jackcasey/events{/privacy}","received_events_url":"https://api.github.com/users/jackcasey/received_events","type":"User","site_admin":false},"body":"I think this makes implementation of the library cleaner. I can rescue a specific exception isntead of having a blanket rescue. \r\n\r\nIt's also safer both for codebases using this library and this library's tests themselves as other exceptions (NilMethodError, etc) might otherwise get hidden and turned into false positives if you are not checking for a particular subclass of StandardError.\r\n\r\nNote that RSpec suggests this also for tests for that reason.","created_at":"2016-10-14T05:55:54Z","updated_at":"2016-10-14T05:55:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/deseretbook/classy_hash/pulls/20/commits","review_comments_url":"https://api.github.com/repos/deseretbook/classy_hash/pulls/20/comments","review_comment_url":"https://api.github.com/repos/deseretbook/classy_hash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deseretbook/classy_hash/issues/20/comments","statuses_url":"https://api.github.com/repos/deseretbook/classy_hash/statuses/cfc165dd7b7e9c38499e21676cce2215e544ea25","head":{"label":"jackcasey:master","ref":"master","sha":"cfc165dd7b7e9c38499e21676cce2215e544ea25","user":{"login":"jackcasey","id":45890,"avatar_url":"https://avatars.githubusercontent.com/u/45890?v=3","gravatar_id":"","url":"https://api.github.com/users/jackcasey","html_url":"https://github.com/jackcasey","followers_url":"https://api.github.com/users/jackcasey/followers","following_url":"https://api.github.com/users/jackcasey/following{/other_user}","gists_url":"https://api.github.com/users/jackcasey/gists{/gist_id}","starred_url":"https://api.github.com/users/jackcasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackcasey/subscriptions","organizations_url":"https://api.github.com/users/jackcasey/orgs","repos_url":"https://api.github.com/users/jackcasey/repos","events_url":"https://api.github.com/users/jackcasey/events{/privacy}","received_events_url":"https://api.github.com/users/jackcasey/received_events","type":"User","site_admin":false},"repo":{"id":70876518,"name":"classy_hash","full_name":"jackcasey/classy_hash","owner":{"login":"jackcasey","id":45890,"avatar_url":"https://avatars.githubusercontent.com/u/45890?v=3","gravatar_id":"","url":"https://api.github.com/users/jackcasey","html_url":"https://github.com/jackcasey","followers_url":"https://api.github.com/users/jackcasey/followers","following_url":"https://api.github.com/users/jackcasey/following{/other_user}","gists_url":"https://api.github.com/users/jackcasey/gists{/gist_id}","starred_url":"https://api.github.com/users/jackcasey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackcasey/subscriptions","organizations_url":"https://api.github.com/users/jackcasey/orgs","repos_url":"https://api.github.com/users/jackcasey/repos","events_url":"https://api.github.com/users/jackcasey/events{/privacy}","received_events_url":"https://api.github.com/users/jackcasey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jackcasey/classy_hash","description":"Keep Your Hashes Classy (a lightweight Hash validation gem)","fork":true,"url":"https://api.github.com/repos/jackcasey/classy_hash","forks_url":"https://api.github.com/repos/jackcasey/classy_hash/forks","keys_url":"https://api.github.com/repos/jackcasey/classy_hash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jackcasey/classy_hash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jackcasey/classy_hash/teams","hooks_url":"https://api.github.com/repos/jackcasey/classy_hash/hooks","issue_events_url":"https://api.github.com/repos/jackcasey/classy_hash/issues/events{/number}","events_url":"https://api.github.com/repos/jackcasey/classy_hash/events","assignees_url":"https://api.github.com/repos/jackcasey/classy_hash/assignees{/user}","branches_url":"https://api.github.com/repos/jackcasey/classy_hash/branches{/branch}","tags_url":"https://api.github.com/repos/jackcasey/classy_hash/tags","blobs_url":"https://api.github.com/repos/jackcasey/classy_hash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jackcasey/classy_hash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jackcasey/classy_hash/git/refs{/sha}","trees_url":"https://api.github.com/repos/jackcasey/classy_hash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jackcasey/classy_hash/statuses/{sha}","languages_url":"https://api.github.com/repos/jackcasey/classy_hash/languages","stargazers_url":"https://api.github.com/repos/jackcasey/classy_hash/stargazers","contributors_url":"https://api.github.com/repos/jackcasey/classy_hash/contributors","subscribers_url":"https://api.github.com/repos/jackcasey/classy_hash/subscribers","subscription_url":"https://api.github.com/repos/jackcasey/classy_hash/subscription","commits_url":"https://api.github.com/repos/jackcasey/classy_hash/commits{/sha}","git_commits_url":"https://api.github.com/repos/jackcasey/classy_hash/git/commits{/sha}","comments_url":"https://api.github.com/repos/jackcasey/classy_hash/comments{/number}","issue_comment_url":"https://api.github.com/repos/jackcasey/classy_hash/issues/comments{/number}","contents_url":"https://api.github.com/repos/jackcasey/classy_hash/contents/{+path}","compare_url":"https://api.github.com/repos/jackcasey/classy_hash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jackcasey/classy_hash/merges","archive_url":"https://api.github.com/repos/jackcasey/classy_hash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jackcasey/classy_hash/downloads","issues_url":"https://api.github.com/repos/jackcasey/classy_hash/issues{/number}","pulls_url":"https://api.github.com/repos/jackcasey/classy_hash/pulls{/number}","milestones_url":"https://api.github.com/repos/jackcasey/classy_hash/milestones{/number}","notifications_url":"https://api.github.com/repos/jackcasey/classy_hash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jackcasey/classy_hash/labels{/name}","releases_url":"https://api.github.com/repos/jackcasey/classy_hash/releases{/id}","deployments_url":"https://api.github.com/repos/jackcasey/classy_hash/deployments","created_at":"2016-10-14T05:19:46Z","updated_at":"2016-10-14T05:19:47Z","pushed_at":"2016-10-14T05:52:26Z","git_url":"git://github.com/jackcasey/classy_hash.git","ssh_url":"git@github.com:jackcasey/classy_hash.git","clone_url":"https://github.com/jackcasey/classy_hash.git","svn_url":"https://github.com/jackcasey/classy_hash","homepage":"","size":127,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deseretbook:master","ref":"master","sha":"40d4e27f44a2d5d087a34c94e881b8c3f37b89f4","user":{"login":"deseretbook","id":1626271,"avatar_url":"https://avatars.githubusercontent.com/u/1626271?v=3","gravatar_id":"","url":"https://api.github.com/users/deseretbook","html_url":"https://github.com/deseretbook","followers_url":"https://api.github.com/users/deseretbook/followers","following_url":"https://api.github.com/users/deseretbook/following{/other_user}","gists_url":"https://api.github.com/users/deseretbook/gists{/gist_id}","starred_url":"https://api.github.com/users/deseretbook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deseretbook/subscriptions","organizations_url":"https://api.github.com/users/deseretbook/orgs","repos_url":"https://api.github.com/users/deseretbook/repos","events_url":"https://api.github.com/users/deseretbook/events{/privacy}","received_events_url":"https://api.github.com/users/deseretbook/received_events","type":"Organization","site_admin":false},"repo":{"id":20279910,"name":"classy_hash","full_name":"deseretbook/classy_hash","owner":{"login":"deseretbook","id":1626271,"avatar_url":"https://avatars.githubusercontent.com/u/1626271?v=3","gravatar_id":"","url":"https://api.github.com/users/deseretbook","html_url":"https://github.com/deseretbook","followers_url":"https://api.github.com/users/deseretbook/followers","following_url":"https://api.github.com/users/deseretbook/following{/other_user}","gists_url":"https://api.github.com/users/deseretbook/gists{/gist_id}","starred_url":"https://api.github.com/users/deseretbook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deseretbook/subscriptions","organizations_url":"https://api.github.com/users/deseretbook/orgs","repos_url":"https://api.github.com/users/deseretbook/repos","events_url":"https://api.github.com/users/deseretbook/events{/privacy}","received_events_url":"https://api.github.com/users/deseretbook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deseretbook/classy_hash","description":"Keep Your Hashes Classy (a lightweight Hash validation gem)","fork":false,"url":"https://api.github.com/repos/deseretbook/classy_hash","forks_url":"https://api.github.com/repos/deseretbook/classy_hash/forks","keys_url":"https://api.github.com/repos/deseretbook/classy_hash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deseretbook/classy_hash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deseretbook/classy_hash/teams","hooks_url":"https://api.github.com/repos/deseretbook/classy_hash/hooks","issue_events_url":"https://api.github.com/repos/deseretbook/classy_hash/issues/events{/number}","events_url":"https://api.github.com/repos/deseretbook/classy_hash/events","assignees_url":"https://api.github.com/repos/deseretbook/classy_hash/assignees{/user}","branches_url":"https://api.github.com/repos/deseretbook/classy_hash/branches{/branch}","tags_url":"https://api.github.com/repos/deseretbook/classy_hash/tags","blobs_url":"https://api.github.com/repos/deseretbook/classy_hash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deseretbook/classy_hash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deseretbook/classy_hash/git/refs{/sha}","trees_url":"https://api.github.com/repos/deseretbook/classy_hash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deseretbook/classy_hash/statuses/{sha}","languages_url":"https://api.github.com/repos/deseretbook/classy_hash/languages","stargazers_url":"https://api.github.com/repos/deseretbook/classy_hash/stargazers","contributors_url":"https://api.github.com/repos/deseretbook/classy_hash/contributors","subscribers_url":"https://api.github.com/repos/deseretbook/classy_hash/subscribers","subscription_url":"https://api.github.com/repos/deseretbook/classy_hash/subscription","commits_url":"https://api.github.com/repos/deseretbook/classy_hash/commits{/sha}","git_commits_url":"https://api.github.com/repos/deseretbook/classy_hash/git/commits{/sha}","comments_url":"https://api.github.com/repos/deseretbook/classy_hash/comments{/number}","issue_comment_url":"https://api.github.com/repos/deseretbook/classy_hash/issues/comments{/number}","contents_url":"https://api.github.com/repos/deseretbook/classy_hash/contents/{+path}","compare_url":"https://api.github.com/repos/deseretbook/classy_hash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deseretbook/classy_hash/merges","archive_url":"https://api.github.com/repos/deseretbook/classy_hash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deseretbook/classy_hash/downloads","issues_url":"https://api.github.com/repos/deseretbook/classy_hash/issues{/number}","pulls_url":"https://api.github.com/repos/deseretbook/classy_hash/pulls{/number}","milestones_url":"https://api.github.com/repos/deseretbook/classy_hash/milestones{/number}","notifications_url":"https://api.github.com/repos/deseretbook/classy_hash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deseretbook/classy_hash/labels{/name}","releases_url":"https://api.github.com/repos/deseretbook/classy_hash/releases{/id}","deployments_url":"https://api.github.com/repos/deseretbook/classy_hash/deployments","created_at":"2014-05-29T02:32:47Z","updated_at":"2016-10-13T17:01:34Z","pushed_at":"2016-09-28T10:28:11Z","git_url":"git://github.com/deseretbook/classy_hash.git","ssh_url":"git@github.com:deseretbook/classy_hash.git","clone_url":"https://github.com/deseretbook/classy_hash.git","svn_url":"https://github.com/deseretbook/classy_hash","homepage":"","size":127,"stargazers_count":32,"watchers_count":32,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":10,"forks":6,"open_issues":10,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deseretbook/classy_hash/pulls/20"},"html":{"href":"https://github.com/deseretbook/classy_hash/pull/20"},"issue":{"href":"https://api.github.com/repos/deseretbook/classy_hash/issues/20"},"comments":{"href":"https://api.github.com/repos/deseretbook/classy_hash/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/deseretbook/classy_hash/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/deseretbook/classy_hash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deseretbook/classy_hash/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/deseretbook/classy_hash/statuses/cfc165dd7b7e9c38499e21676cce2215e544ea25"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":82,"deletions":75,"changed_files":4}}
{"actor":{"display_login":"jackcasey"}}