{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/8114","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/8114/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/8114/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/8114/events","html_url":"https://github.com/dotnet/corefx/issues/8114","id":151357000,"number":8114,"title":"System.Text.Encoding and System.Text.Encoding.Extensions test duplication","user":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars.githubusercontent.com/u/1275900?v=3","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dotnet/corefx/labels/grabbed%20by%20community","name":"grabbed by community","color":"009800"},{"url":"https://api.github.com/repos/dotnet/corefx/labels/System.Text.Encoding","name":"System.Text.Encoding","color":"d4c5f9"},{"url":"https://api.github.com/repos/dotnet/corefx/labels/test%20bug","name":"test bug","color":"207de5"}],"state":"open","locked":false,"assignee":{"login":"tarekgh","id":10833894,"avatar_url":"https://avatars.githubusercontent.com/u/10833894?v=3","gravatar_id":"","url":"https://api.github.com/users/tarekgh","html_url":"https://github.com/tarekgh","followers_url":"https://api.github.com/users/tarekgh/followers","following_url":"https://api.github.com/users/tarekgh/following{/other_user}","gists_url":"https://api.github.com/users/tarekgh/gists{/gist_id}","starred_url":"https://api.github.com/users/tarekgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarekgh/subscriptions","organizations_url":"https://api.github.com/users/tarekgh/orgs","repos_url":"https://api.github.com/users/tarekgh/repos","events_url":"https://api.github.com/users/tarekgh/events{/privacy}","received_events_url":"https://api.github.com/users/tarekgh/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/5","html_url":"https://github.com/dotnet/corefx/milestones/Future","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/5/labels","id":1328080,"number":5,"title":"Future","description":"Milestone tracking the issues triaged for an unspecified future release","creator":{"login":"joshfree","id":1302850,"avatar_url":"https://avatars.githubusercontent.com/u/1302850?v=3","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"open_issues":562,"closed_issues":138,"state":"open","created_at":"2015-09-29T00:25:45Z","updated_at":"2016-04-27T16:23:35Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2016-04-27T10:53:52Z","updated_at":"2016-04-27T16:25:31Z","closed_at":null,"body":"Currently, the System.Text.Encoding and System.Text.Encoding.Extensions test projects test the same things for the same classes - I.e. ASCIIEncoding, UT7Encoding, UTF32Encoding, UTD8Encoding and UnicodeEncoding. For Latin1Encoding, System.Text.Encoding.Extensions is the only one testing this class \r\n\r\nThis means that there is lots of duplication between the test projects. Ideally, this should be fixed.\r\n\r\nThere are some solutions:\r\n- Remove/combine the tests in System.Text.Encoding.Extensions to the new more modern System.Text.Encoding.Tests\r\n- Extract the current tests in System.Text.Encoding.Tests and System.Text.Encoding.Extensions to src/common/tests and reference the files in both projects\r\n- keep as is, and duplicate tests (not an ideal solution IMO)\r\n\r\nMy preferred solution is to migrate the existing non-duplicated tests to System.Text.Encoding.Tests as that project is more modern. In terms of coverage loss, there wouldn't really be any, as the code is in mscorlib anyway. In fact, this could consolidate coverage even more by having he tests in one place. \r\n\r\n@tarekgh let me know what approach you think is the best and I'll work on it"},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/215138348","html_url":"https://github.com/dotnet/corefx/issues/8114#issuecomment-215138348","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/8114","id":215138348,"user":{"login":"joshfree","id":1302850,"avatar_url":"https://avatars.githubusercontent.com/u/1302850?v=3","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"created_at":"2016-04-27T16:25:31Z","updated_at":"2016-04-27T16:25:31Z","body":"tagging this with `grabbed by community`; @hughbe let me know if you weren't intending to pick this one up 😄 "}}