{"action":"created","comment":{"url":"https://api.github.com/repos/ParsePlatform/parse-server/pulls/comments/63626390","id":63626390,"diff_hunk":"@@ -462,20 +462,33 @@ function untransformACL(mongoObject) {\n // cannot perform a transformation\n function CannotTransform() {}\n \n+const transformInteriorAtom = atom => {\n+  // TODO: check validity harder for the __type-defined types\n+  if (typeof atom === 'object' && atom && !(atom instanceof Date) && atom.__type === 'Pointer') {","path":"src/Adapters/Storage/Mongo/MongoTransform.js","position":234,"original_position":234,"commit_id":"fa95f05f1f37edd162734b49142e7a43a6325905","original_commit_id":"fa95f05f1f37edd162734b49142e7a43a6325905","user":{"login":"drew-gross","id":558242,"avatar_url":"https://avatars.githubusercontent.com/u/558242?v=3","gravatar_id":"","url":"https://api.github.com/users/drew-gross","html_url":"https://github.com/drew-gross","followers_url":"https://api.github.com/users/drew-gross/followers","following_url":"https://api.github.com/users/drew-gross/following{/other_user}","gists_url":"https://api.github.com/users/drew-gross/gists{/gist_id}","starred_url":"https://api.github.com/users/drew-gross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drew-gross/subscriptions","organizations_url":"https://api.github.com/users/drew-gross/orgs","repos_url":"https://api.github.com/users/drew-gross/repos","events_url":"https://api.github.com/users/drew-gross/events{/privacy}","received_events_url":"https://api.github.com/users/drew-gross/received_events","type":"User","site_admin":false},"body":"With that change then every caller of `transformInteriorAtom` would have to be changed to check for `CannotTransform`. If tests still pass after removing the throw completely, I would rather just do that, as I'm pretty sure there is no way for that value to be a function or symbol anyway.","created_at":"2016-05-18T00:09:27Z","updated_at":"2016-05-18T00:09:27Z","html_url":"https://github.com/ParsePlatform/parse-server/pull/1823#discussion_r63626390","pull_request_url":"https://api.github.com/repos/ParsePlatform/parse-server/pulls/1823","_links":{"self":{"href":"https://api.github.com/repos/ParsePlatform/parse-server/pulls/comments/63626390"},"html":{"href":"https://github.com/ParsePlatform/parse-server/pull/1823#discussion_r63626390"},"pull_request":{"href":"https://api.github.com/repos/ParsePlatform/parse-server/pulls/1823"}}},"pull_request":{"url":"https://api.github.com/repos/ParsePlatform/parse-server/pulls/1823","id":70446097,"html_url":"https://github.com/ParsePlatform/parse-server/pull/1823","diff_url":"https://github.com/ParsePlatform/parse-server/pull/1823.diff","patch_url":"https://github.com/ParsePlatform/parse-server/pull/1823.patch","issue_url":"https://api.github.com/repos/ParsePlatform/parse-server/issues/1823","number":1823,"state":"open","locked":false,"title":"Refactor MongoTransform.js","user":{"login":"drew-gross","id":558242,"avatar_url":"https://avatars.githubusercontent.com/u/558242?v=3","gravatar_id":"","url":"https://api.github.com/users/drew-gross","html_url":"https://github.com/drew-gross","followers_url":"https://api.github.com/users/drew-gross/followers","following_url":"https://api.github.com/users/drew-gross/following{/other_user}","gists_url":"https://api.github.com/users/drew-gross/gists{/gist_id}","starred_url":"https://api.github.com/users/drew-gross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drew-gross/subscriptions","organizations_url":"https://api.github.com/users/drew-gross/orgs","repos_url":"https://api.github.com/users/drew-gross/repos","events_url":"https://api.github.com/users/drew-gross/events{/privacy}","received_events_url":"https://api.github.com/users/drew-gross/received_events","type":"User","site_admin":false},"body":"- Partially breaks dependency of MongoTransform on schemaController\r\n\r\n- Lifts a lots of validation higher in the call tree. Ideally all validation would happen very early in the request.\r\n\r\n- Fixes a lot of bugs involving keys in nested objects with names like \"createdAt\"\r\n\r\n- Reduce the number of bool parameters in transform functions that do minor tweaks to how the function works.","created_at":"2016-05-17T23:11:11Z","updated_at":"2016-05-18T00:09:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4c8327d0b1c575a01944f26453c48c16ad0db45","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ParsePlatform/parse-server/pulls/1823/commits","review_comments_url":"https://api.github.com/repos/ParsePlatform/parse-server/pulls/1823/comments","review_comment_url":"https://api.github.com/repos/ParsePlatform/parse-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ParsePlatform/parse-server/issues/1823/comments","statuses_url":"https://api.github.com/repos/ParsePlatform/parse-server/statuses/fa95f05f1f37edd162734b49142e7a43a6325905","head":{"label":"drew-gross:tidy-transforms","ref":"tidy-transforms","sha":"fa95f05f1f37edd162734b49142e7a43a6325905","user":{"login":"drew-gross","id":558242,"avatar_url":"https://avatars.githubusercontent.com/u/558242?v=3","gravatar_id":"","url":"https://api.github.com/users/drew-gross","html_url":"https://github.com/drew-gross","followers_url":"https://api.github.com/users/drew-gross/followers","following_url":"https://api.github.com/users/drew-gross/following{/other_user}","gists_url":"https://api.github.com/users/drew-gross/gists{/gist_id}","starred_url":"https://api.github.com/users/drew-gross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drew-gross/subscriptions","organizations_url":"https://api.github.com/users/drew-gross/orgs","repos_url":"https://api.github.com/users/drew-gross/repos","events_url":"https://api.github.com/users/drew-gross/events{/privacy}","received_events_url":"https://api.github.com/users/drew-gross/received_events","type":"User","site_admin":false},"repo":{"id":51231720,"name":"parse-server","full_name":"drew-gross/parse-server","owner":{"login":"drew-gross","id":558242,"avatar_url":"https://avatars.githubusercontent.com/u/558242?v=3","gravatar_id":"","url":"https://api.github.com/users/drew-gross","html_url":"https://github.com/drew-gross","followers_url":"https://api.github.com/users/drew-gross/followers","following_url":"https://api.github.com/users/drew-gross/following{/other_user}","gists_url":"https://api.github.com/users/drew-gross/gists{/gist_id}","starred_url":"https://api.github.com/users/drew-gross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drew-gross/subscriptions","organizations_url":"https://api.github.com/users/drew-gross/orgs","repos_url":"https://api.github.com/users/drew-gross/repos","events_url":"https://api.github.com/users/drew-gross/events{/privacy}","received_events_url":"https://api.github.com/users/drew-gross/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drew-gross/parse-server","description":"Parse-compatible API server module for Node/Express","fork":true,"url":"https://api.github.com/repos/drew-gross/parse-server","forks_url":"https://api.github.com/repos/drew-gross/parse-server/forks","keys_url":"https://api.github.com/repos/drew-gross/parse-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drew-gross/parse-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drew-gross/parse-server/teams","hooks_url":"https://api.github.com/repos/drew-gross/parse-server/hooks","issue_events_url":"https://api.github.com/repos/drew-gross/parse-server/issues/events{/number}","events_url":"https://api.github.com/repos/drew-gross/parse-server/events","assignees_url":"https://api.github.com/repos/drew-gross/parse-server/assignees{/user}","branches_url":"https://api.github.com/repos/drew-gross/parse-server/branches{/branch}","tags_url":"https://api.github.com/repos/drew-gross/parse-server/tags","blobs_url":"https://api.github.com/repos/drew-gross/parse-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drew-gross/parse-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drew-gross/parse-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/drew-gross/parse-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drew-gross/parse-server/statuses/{sha}","languages_url":"https://api.github.com/repos/drew-gross/parse-server/languages","stargazers_url":"https://api.github.com/repos/drew-gross/parse-server/stargazers","contributors_url":"https://api.github.com/repos/drew-gross/parse-server/contributors","subscribers_url":"https://api.github.com/repos/drew-gross/parse-server/subscribers","subscription_url":"https://api.github.com/repos/drew-gross/parse-server/subscription","commits_url":"https://api.github.com/repos/drew-gross/parse-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/drew-gross/parse-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/drew-gross/parse-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/drew-gross/parse-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/drew-gross/parse-server/contents/{+path}","compare_url":"https://api.github.com/repos/drew-gross/parse-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drew-gross/parse-server/merges","archive_url":"https://api.github.com/repos/drew-gross/parse-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drew-gross/parse-server/downloads","issues_url":"https://api.github.com/repos/drew-gross/parse-server/issues{/number}","pulls_url":"https://api.github.com/repos/drew-gross/parse-server/pulls{/number}","milestones_url":"https://api.github.com/repos/drew-gross/parse-server/milestones{/number}","notifications_url":"https://api.github.com/repos/drew-gross/parse-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drew-gross/parse-server/labels{/name}","releases_url":"https://api.github.com/repos/drew-gross/parse-server/releases{/id}","deployments_url":"https://api.github.com/repos/drew-gross/parse-server/deployments","created_at":"2016-02-07T01:58:26Z","updated_at":"2016-02-07T01:58:27Z","pushed_at":"2016-05-17T22:57:38Z","git_url":"git://github.com/drew-gross/parse-server.git","ssh_url":"git@github.com:drew-gross/parse-server.git","clone_url":"https://github.com/drew-gross/parse-server.git","svn_url":"https://github.com/drew-gross/parse-server","homepage":null,"size":1814,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ParsePlatform:master","ref":"master","sha":"40965186c05015c337b6be6e4beca8790fee6189","user":{"login":"ParsePlatform","id":1294580,"avatar_url":"https://avatars.githubusercontent.com/u/1294580?v=3","gravatar_id":"","url":"https://api.github.com/users/ParsePlatform","html_url":"https://github.com/ParsePlatform","followers_url":"https://api.github.com/users/ParsePlatform/followers","following_url":"https://api.github.com/users/ParsePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ParsePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ParsePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParsePlatform/subscriptions","organizations_url":"https://api.github.com/users/ParsePlatform/orgs","repos_url":"https://api.github.com/users/ParsePlatform/repos","events_url":"https://api.github.com/users/ParsePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ParsePlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":50603846,"name":"parse-server","full_name":"ParsePlatform/parse-server","owner":{"login":"ParsePlatform","id":1294580,"avatar_url":"https://avatars.githubusercontent.com/u/1294580?v=3","gravatar_id":"","url":"https://api.github.com/users/ParsePlatform","html_url":"https://github.com/ParsePlatform","followers_url":"https://api.github.com/users/ParsePlatform/followers","following_url":"https://api.github.com/users/ParsePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ParsePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ParsePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParsePlatform/subscriptions","organizations_url":"https://api.github.com/users/ParsePlatform/orgs","repos_url":"https://api.github.com/users/ParsePlatform/repos","events_url":"https://api.github.com/users/ParsePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ParsePlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ParsePlatform/parse-server","description":"Parse-compatible API server module for Node/Express","fork":false,"url":"https://api.github.com/repos/ParsePlatform/parse-server","forks_url":"https://api.github.com/repos/ParsePlatform/parse-server/forks","keys_url":"https://api.github.com/repos/ParsePlatform/parse-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParsePlatform/parse-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParsePlatform/parse-server/teams","hooks_url":"https://api.github.com/repos/ParsePlatform/parse-server/hooks","issue_events_url":"https://api.github.com/repos/ParsePlatform/parse-server/issues/events{/number}","events_url":"https://api.github.com/repos/ParsePlatform/parse-server/events","assignees_url":"https://api.github.com/repos/ParsePlatform/parse-server/assignees{/user}","branches_url":"https://api.github.com/repos/ParsePlatform/parse-server/branches{/branch}","tags_url":"https://api.github.com/repos/ParsePlatform/parse-server/tags","blobs_url":"https://api.github.com/repos/ParsePlatform/parse-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParsePlatform/parse-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParsePlatform/parse-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParsePlatform/parse-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParsePlatform/parse-server/statuses/{sha}","languages_url":"https://api.github.com/repos/ParsePlatform/parse-server/languages","stargazers_url":"https://api.github.com/repos/ParsePlatform/parse-server/stargazers","contributors_url":"https://api.github.com/repos/ParsePlatform/parse-server/contributors","subscribers_url":"https://api.github.com/repos/ParsePlatform/parse-server/subscribers","subscription_url":"https://api.github.com/repos/ParsePlatform/parse-server/subscription","commits_url":"https://api.github.com/repos/ParsePlatform/parse-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParsePlatform/parse-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParsePlatform/parse-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParsePlatform/parse-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParsePlatform/parse-server/contents/{+path}","compare_url":"https://api.github.com/repos/ParsePlatform/parse-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParsePlatform/parse-server/merges","archive_url":"https://api.github.com/repos/ParsePlatform/parse-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParsePlatform/parse-server/downloads","issues_url":"https://api.github.com/repos/ParsePlatform/parse-server/issues{/number}","pulls_url":"https://api.github.com/repos/ParsePlatform/parse-server/pulls{/number}","milestones_url":"https://api.github.com/repos/ParsePlatform/parse-server/milestones{/number}","notifications_url":"https://api.github.com/repos/ParsePlatform/parse-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParsePlatform/parse-server/labels{/name}","releases_url":"https://api.github.com/repos/ParsePlatform/parse-server/releases{/id}","deployments_url":"https://api.github.com/repos/ParsePlatform/parse-server/deployments","created_at":"2016-01-28T18:29:14Z","updated_at":"2016-05-17T23:57:02Z","pushed_at":"2016-05-18T00:02:30Z","git_url":"git://github.com/ParsePlatform/parse-server.git","ssh_url":"git@github.com:ParsePlatform/parse-server.git","clone_url":"https://github.com/ParsePlatform/parse-server.git","svn_url":"https://github.com/ParsePlatform/parse-server","homepage":"https://parse.com","size":3544,"stargazers_count":9297,"watchers_count":9297,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2275,"mirror_url":null,"open_issues_count":119,"forks":2275,"open_issues":119,"watchers":9297,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ParsePlatform/parse-server/pulls/1823"},"html":{"href":"https://github.com/ParsePlatform/parse-server/pull/1823"},"issue":{"href":"https://api.github.com/repos/ParsePlatform/parse-server/issues/1823"},"comments":{"href":"https://api.github.com/repos/ParsePlatform/parse-server/issues/1823/comments"},"review_comments":{"href":"https://api.github.com/repos/ParsePlatform/parse-server/pulls/1823/comments"},"review_comment":{"href":"https://api.github.com/repos/ParsePlatform/parse-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ParsePlatform/parse-server/pulls/1823/commits"},"statuses":{"href":"https://api.github.com/repos/ParsePlatform/parse-server/statuses/fa95f05f1f37edd162734b49142e7a43a6325905"}}}}