{"action":"created","comment":{"url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments/86824925","pull_request_review_id":7463297,"id":86824925,"diff_hunk":"@@ -137,6 +137,10 @@\n       <artifactId>spark-core_${scala.version.prefix}</artifactId>\n     </dependency>\n     <dependency>\n+      <groupId>org.apache.spark</groupId>\n+      <artifactId>spark-streaming_2.10</artifactId>","path":"adam-core/pom.xml","position":5,"original_position":5,"commit_id":"56dee61d57d5af1b23f1d958ea26ffb2d45f8841","original_commit_id":"56dee61d57d5af1b23f1d958ea26ffb2d45f8841","user":{"login":"heuermh","id":35293,"avatar_url":"https://avatars.githubusercontent.com/u/35293?v=3","gravatar_id":"","url":"https://api.github.com/users/heuermh","html_url":"https://github.com/heuermh","followers_url":"https://api.github.com/users/heuermh/followers","following_url":"https://api.github.com/users/heuermh/following{/other_user}","gists_url":"https://api.github.com/users/heuermh/gists{/gist_id}","starred_url":"https://api.github.com/users/heuermh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heuermh/subscriptions","organizations_url":"https://api.github.com/users/heuermh/orgs","repos_url":"https://api.github.com/users/heuermh/repos","events_url":"https://api.github.com/users/heuermh/events{/privacy}","received_events_url":"https://api.github.com/users/heuermh/received_events","type":"User","site_admin":false},"body":"use `${scala.version.prefix}`","created_at":"2016-11-07T17:29:19Z","updated_at":"2016-11-07T17:29:19Z","html_url":"https://github.com/bigdatagenomics/adam/pull/1246#discussion_r86824925","pull_request_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1246","_links":{"self":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments/86824925"},"html":{"href":"https://github.com/bigdatagenomics/adam/pull/1246#discussion_r86824925"},"pull_request":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1246"}}},"pull_request":{"url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1246","id":92626703,"html_url":"https://github.com/bigdatagenomics/adam/pull/1246","diff_url":"https://github.com/bigdatagenomics/adam/pull/1246.diff","patch_url":"https://github.com/bigdatagenomics/adam/pull/1246.patch","issue_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/1246","number":1246,"state":"open","locked":false,"title":"HBase backend for Genotypes","user":{"login":"jpdna","id":7423296,"avatar_url":"https://avatars.githubusercontent.com/u/7423296?v=3","gravatar_id":"","url":"https://api.github.com/users/jpdna","html_url":"https://github.com/jpdna","followers_url":"https://api.github.com/users/jpdna/followers","following_url":"https://api.github.com/users/jpdna/following{/other_user}","gists_url":"https://api.github.com/users/jpdna/gists{/gist_id}","starred_url":"https://api.github.com/users/jpdna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpdna/subscriptions","organizations_url":"https://api.github.com/users/jpdna/orgs","repos_url":"https://api.github.com/users/jpdna/repos","events_url":"https://api.github.com/users/jpdna/events{/privacy}","received_events_url":"https://api.github.com/users/jpdna/received_events","type":"User","site_admin":false},"body":"Requesting here a first pass review for the integration of HBase input and output functions into Master.\r\n\r\nThe code in this PR excludes the \"custom encoding\" options for clarity and thus sticks with saving the full Avro schema of a Genotype as the values stored in HBase.\r\n\r\nTodo:\r\n- [ ] Add Unit tests using an embedded mini-hbase cluster\r\n- [ ] Add more parameter checking and informative error messages, such as if database table doesn't exist\r\n- [ ] Integrate and rebase against upcoming changes to Genotype schemas when available\r\n\r\nQuestions:\r\n- This PR has a new hbase/HBaseFunctions.scala module parallel to RDD in the package structure in adam-core, is this OK, or other suggestions?\r\n\r\n- For the first round of HBase code integration I suggest we target CDH HBase only as that is where we are doing testing and deployment.  In future we can add a profile for POM for  Apache Hbase 2.0, though this  would seem to require use of HBase 2.0 snapshot as Spark support doesn't exist in the last official non-cloudera apache release.\r\n\r\n\r\n\r\n","created_at":"2016-11-07T17:24:02Z","updated_at":"2016-11-07T18:02:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8aac4ff958d24d171e0a7edf3fe9bc92d6589b7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1246/commits","review_comments_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1246/comments","review_comment_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/1246/comments","statuses_url":"https://api.github.com/repos/bigdatagenomics/adam/statuses/56dee61d57d5af1b23f1d958ea26ffb2d45f8841","head":{"label":"jpdna:dev/hbase/b3","ref":"dev/hbase/b3","sha":"56dee61d57d5af1b23f1d958ea26ffb2d45f8841","user":{"login":"jpdna","id":7423296,"avatar_url":"https://avatars.githubusercontent.com/u/7423296?v=3","gravatar_id":"","url":"https://api.github.com/users/jpdna","html_url":"https://github.com/jpdna","followers_url":"https://api.github.com/users/jpdna/followers","following_url":"https://api.github.com/users/jpdna/following{/other_user}","gists_url":"https://api.github.com/users/jpdna/gists{/gist_id}","starred_url":"https://api.github.com/users/jpdna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpdna/subscriptions","organizations_url":"https://api.github.com/users/jpdna/orgs","repos_url":"https://api.github.com/users/jpdna/repos","events_url":"https://api.github.com/users/jpdna/events{/privacy}","received_events_url":"https://api.github.com/users/jpdna/received_events","type":"User","site_admin":false},"repo":{"id":31505326,"name":"adam","full_name":"jpdna/adam","owner":{"login":"jpdna","id":7423296,"avatar_url":"https://avatars.githubusercontent.com/u/7423296?v=3","gravatar_id":"","url":"https://api.github.com/users/jpdna","html_url":"https://github.com/jpdna","followers_url":"https://api.github.com/users/jpdna/followers","following_url":"https://api.github.com/users/jpdna/following{/other_user}","gists_url":"https://api.github.com/users/jpdna/gists{/gist_id}","starred_url":"https://api.github.com/users/jpdna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpdna/subscriptions","organizations_url":"https://api.github.com/users/jpdna/orgs","repos_url":"https://api.github.com/users/jpdna/repos","events_url":"https://api.github.com/users/jpdna/events{/privacy}","received_events_url":"https://api.github.com/users/jpdna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jpdna/adam","description":"A genomics processing engine and specialized file format built using Apache Avro, Apache Spark and Parquet. Apache 2 licensed.","fork":true,"url":"https://api.github.com/repos/jpdna/adam","forks_url":"https://api.github.com/repos/jpdna/adam/forks","keys_url":"https://api.github.com/repos/jpdna/adam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpdna/adam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpdna/adam/teams","hooks_url":"https://api.github.com/repos/jpdna/adam/hooks","issue_events_url":"https://api.github.com/repos/jpdna/adam/issues/events{/number}","events_url":"https://api.github.com/repos/jpdna/adam/events","assignees_url":"https://api.github.com/repos/jpdna/adam/assignees{/user}","branches_url":"https://api.github.com/repos/jpdna/adam/branches{/branch}","tags_url":"https://api.github.com/repos/jpdna/adam/tags","blobs_url":"https://api.github.com/repos/jpdna/adam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpdna/adam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpdna/adam/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpdna/adam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpdna/adam/statuses/{sha}","languages_url":"https://api.github.com/repos/jpdna/adam/languages","stargazers_url":"https://api.github.com/repos/jpdna/adam/stargazers","contributors_url":"https://api.github.com/repos/jpdna/adam/contributors","subscribers_url":"https://api.github.com/repos/jpdna/adam/subscribers","subscription_url":"https://api.github.com/repos/jpdna/adam/subscription","commits_url":"https://api.github.com/repos/jpdna/adam/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpdna/adam/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpdna/adam/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpdna/adam/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpdna/adam/contents/{+path}","compare_url":"https://api.github.com/repos/jpdna/adam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpdna/adam/merges","archive_url":"https://api.github.com/repos/jpdna/adam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpdna/adam/downloads","issues_url":"https://api.github.com/repos/jpdna/adam/issues{/number}","pulls_url":"https://api.github.com/repos/jpdna/adam/pulls{/number}","milestones_url":"https://api.github.com/repos/jpdna/adam/milestones{/number}","notifications_url":"https://api.github.com/repos/jpdna/adam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpdna/adam/labels{/name}","releases_url":"https://api.github.com/repos/jpdna/adam/releases{/id}","deployments_url":"https://api.github.com/repos/jpdna/adam/deployments","created_at":"2015-03-01T18:08:13Z","updated_at":"2016-02-21T02:26:10Z","pushed_at":"2016-11-07T17:06:36Z","git_url":"git://github.com/jpdna/adam.git","ssh_url":"git@github.com:jpdna/adam.git","clone_url":"https://github.com/jpdna/adam.git","svn_url":"https://github.com/jpdna/adam","homepage":"http://bdgenomics.org/","size":6012,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bigdatagenomics:master","ref":"master","sha":"9222c3edd7b24c9f9e859f10223dd29d515b4903","user":{"login":"bigdatagenomics","id":5839438,"avatar_url":"https://avatars.githubusercontent.com/u/5839438?v=3","gravatar_id":"","url":"https://api.github.com/users/bigdatagenomics","html_url":"https://github.com/bigdatagenomics","followers_url":"https://api.github.com/users/bigdatagenomics/followers","following_url":"https://api.github.com/users/bigdatagenomics/following{/other_user}","gists_url":"https://api.github.com/users/bigdatagenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/bigdatagenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigdatagenomics/subscriptions","organizations_url":"https://api.github.com/users/bigdatagenomics/orgs","repos_url":"https://api.github.com/users/bigdatagenomics/repos","events_url":"https://api.github.com/users/bigdatagenomics/events{/privacy}","received_events_url":"https://api.github.com/users/bigdatagenomics/received_events","type":"Organization","site_admin":false},"repo":{"id":14541530,"name":"adam","full_name":"bigdatagenomics/adam","owner":{"login":"bigdatagenomics","id":5839438,"avatar_url":"https://avatars.githubusercontent.com/u/5839438?v=3","gravatar_id":"","url":"https://api.github.com/users/bigdatagenomics","html_url":"https://github.com/bigdatagenomics","followers_url":"https://api.github.com/users/bigdatagenomics/followers","following_url":"https://api.github.com/users/bigdatagenomics/following{/other_user}","gists_url":"https://api.github.com/users/bigdatagenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/bigdatagenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigdatagenomics/subscriptions","organizations_url":"https://api.github.com/users/bigdatagenomics/orgs","repos_url":"https://api.github.com/users/bigdatagenomics/repos","events_url":"https://api.github.com/users/bigdatagenomics/events{/privacy}","received_events_url":"https://api.github.com/users/bigdatagenomics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigdatagenomics/adam","description":"ADAM is a genomics analysis platform with specialized file formats built using Apache Avro, Apache Spark and Parquet. Apache 2 licensed.","fork":false,"url":"https://api.github.com/repos/bigdatagenomics/adam","forks_url":"https://api.github.com/repos/bigdatagenomics/adam/forks","keys_url":"https://api.github.com/repos/bigdatagenomics/adam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigdatagenomics/adam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigdatagenomics/adam/teams","hooks_url":"https://api.github.com/repos/bigdatagenomics/adam/hooks","issue_events_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/events{/number}","events_url":"https://api.github.com/repos/bigdatagenomics/adam/events","assignees_url":"https://api.github.com/repos/bigdatagenomics/adam/assignees{/user}","branches_url":"https://api.github.com/repos/bigdatagenomics/adam/branches{/branch}","tags_url":"https://api.github.com/repos/bigdatagenomics/adam/tags","blobs_url":"https://api.github.com/repos/bigdatagenomics/adam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigdatagenomics/adam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigdatagenomics/adam/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigdatagenomics/adam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigdatagenomics/adam/statuses/{sha}","languages_url":"https://api.github.com/repos/bigdatagenomics/adam/languages","stargazers_url":"https://api.github.com/repos/bigdatagenomics/adam/stargazers","contributors_url":"https://api.github.com/repos/bigdatagenomics/adam/contributors","subscribers_url":"https://api.github.com/repos/bigdatagenomics/adam/subscribers","subscription_url":"https://api.github.com/repos/bigdatagenomics/adam/subscription","commits_url":"https://api.github.com/repos/bigdatagenomics/adam/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigdatagenomics/adam/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigdatagenomics/adam/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigdatagenomics/adam/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigdatagenomics/adam/contents/{+path}","compare_url":"https://api.github.com/repos/bigdatagenomics/adam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigdatagenomics/adam/merges","archive_url":"https://api.github.com/repos/bigdatagenomics/adam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigdatagenomics/adam/downloads","issues_url":"https://api.github.com/repos/bigdatagenomics/adam/issues{/number}","pulls_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls{/number}","milestones_url":"https://api.github.com/repos/bigdatagenomics/adam/milestones{/number}","notifications_url":"https://api.github.com/repos/bigdatagenomics/adam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigdatagenomics/adam/labels{/name}","releases_url":"https://api.github.com/repos/bigdatagenomics/adam/releases{/id}","deployments_url":"https://api.github.com/repos/bigdatagenomics/adam/deployments","created_at":"2013-11-19T23:47:57Z","updated_at":"2016-11-07T09:48:08Z","pushed_at":"2016-11-07T17:24:02Z","git_url":"git://github.com/bigdatagenomics/adam.git","ssh_url":"git@github.com:bigdatagenomics/adam.git","clone_url":"https://github.com/bigdatagenomics/adam.git","svn_url":"https://github.com/bigdatagenomics/adam","homepage":"http://bdgenomics.org/","size":54193,"stargazers_count":542,"watchers_count":542,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":198,"mirror_url":null,"open_issues_count":100,"forks":198,"open_issues":100,"watchers":542,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1246"},"html":{"href":"https://github.com/bigdatagenomics/adam/pull/1246"},"issue":{"href":"https://api.github.com/repos/bigdatagenomics/adam/issues/1246"},"comments":{"href":"https://api.github.com/repos/bigdatagenomics/adam/issues/1246/comments"},"review_comments":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1246/comments"},"review_comment":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/1246/commits"},"statuses":{"href":"https://api.github.com/repos/bigdatagenomics/adam/statuses/56dee61d57d5af1b23f1d958ea26ffb2d45f8841"}}}}
{"actor":{"display_login":"heuermh"}}