{"action":"created","issue":{"url":"https://api.github.com/repos/LMFDB/lmfdb/issues/1546","repository_url":"https://api.github.com/repos/LMFDB/lmfdb","labels_url":"https://api.github.com/repos/LMFDB/lmfdb/issues/1546/labels{/name}","comments_url":"https://api.github.com/repos/LMFDB/lmfdb/issues/1546/comments","events_url":"https://api.github.com/repos/LMFDB/lmfdb/issues/1546/events","html_url":"https://github.com/LMFDB/lmfdb/pull/1546","id":159938791,"number":1546,"title":"Genus2 cleanup","user":{"login":"AndrewVSutherland","id":11425002,"avatar_url":"https://avatars.githubusercontent.com/u/11425002?v=3","gravatar_id":"","url":"https://api.github.com/users/AndrewVSutherland","html_url":"https://github.com/AndrewVSutherland","followers_url":"https://api.github.com/users/AndrewVSutherland/followers","following_url":"https://api.github.com/users/AndrewVSutherland/following{/other_user}","gists_url":"https://api.github.com/users/AndrewVSutherland/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewVSutherland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewVSutherland/subscriptions","organizations_url":"https://api.github.com/users/AndrewVSutherland/orgs","repos_url":"https://api.github.com/users/AndrewVSutherland/repos","events_url":"https://api.github.com/users/AndrewVSutherland/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewVSutherland/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-06-13T12:28:39Z","updated_at":"2016-06-13T13:42:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/LMFDB/lmfdb/pulls/1546","html_url":"https://github.com/LMFDB/lmfdb/pull/1546","diff_url":"https://github.com/LMFDB/lmfdb/pull/1546.diff","patch_url":"https://github.com/LMFDB/lmfdb/pull/1546.patch"},"body":"This PR cleans up a bunch of minor issues in the genus2 code/data and is in preparation for uploading a much larger set of genus2 curves with 5-smooth discriminants planned for later this month.\r\n\r\nThere are a lot of code changes (but the total amount of code is now significantly smaller), but the only visible changes should be:\r\n\r\n* fixed a few small cosmetic/wording issues (e.g. tildeS_4 ->\\tilde{S}_4)\r\n* removed number of curves from isogeny classes properties box (this only counts elements of the isogeny class that happen to be Jacobians of curves that happen to currently be in the database, not very meaningful and not invariant)\r\n* related objects are now consistent between curves and their isogeny classes and include some objects that were previously missing (this addresses part of #433).\r\n\r\nNon-visible code changes include:\r\n\r\n* isogeny_classes.py is now gone (this functionality is now included in web_g2c.py and much simpler), and all references to the isogeny_classes collection have been removed.  Once this PR is pushed to beta and prod the isogeny_classes collection can be completely removed (the fields root_number and bad_lfactors were the only ones not already present in curves and these have been moved there).\r\n* modified versions of several array fields have been added to the genus2_curves collection that encode these arrays as strings for faster lookup (the documentation in LMFDB/inventory has been modified to reflect this -- this includes the fields: torsion_subgroup, g2_inv, igusa_inv, igusa_clebsch_inv, and eqn).\r\n* a new collection Lfunctions.instances has been added for listing automorphic friends (related objects with the same L-function).  These records will eventually all move to the instances collection in the Lfunctions database (at which point I will change the code and this collection can be removed), but it makes sense to wait until #433 has been addressed before doing this).\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/LMFDB/lmfdb/issues/comments/225584010","html_url":"https://github.com/LMFDB/lmfdb/pull/1546#issuecomment-225584010","issue_url":"https://api.github.com/repos/LMFDB/lmfdb/issues/1546","id":225584010,"user":{"login":"AndrewVSutherland","id":11425002,"avatar_url":"https://avatars.githubusercontent.com/u/11425002?v=3","gravatar_id":"","url":"https://api.github.com/users/AndrewVSutherland","html_url":"https://github.com/AndrewVSutherland","followers_url":"https://api.github.com/users/AndrewVSutherland/followers","following_url":"https://api.github.com/users/AndrewVSutherland/following{/other_user}","gists_url":"https://api.github.com/users/AndrewVSutherland/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewVSutherland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewVSutherland/subscriptions","organizations_url":"https://api.github.com/users/AndrewVSutherland/orgs","repos_url":"https://api.github.com/users/AndrewVSutherland/repos","events_url":"https://api.github.com/users/AndrewVSutherland/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewVSutherland/received_events","type":"User","site_admin":false},"created_at":"2016-06-13T13:42:12Z","updated_at":"2016-06-13T13:42:12Z","body":"Agreed, I will fix this (and respond to your other points) later today (I'm currently attending Rubin 60).  Thanks for the feedback!\n\n> On Jun 13, 2016, at 9:26 AM, John Cremona <notifications@github.com> wrote:\n> \n> (continuing)\n> http://localhost:37777/Genus2Curve/Q/336/a/ has 2 elliptic curves as related objects, though they are not mentioned on the page itself -- more importantly, the links do not work! The url_for function should be used, rather than whatever the function lfunction_friend_from_url is currently doing.\n> \n> This last point is the only one which I think must be fixed before merging -- and I know that it is not an issue claused by the PR, I just think it better to fix now if possible.\n> \n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n> \n"}}
{"actor":{"display_login":"AndrewVSutherland"}}