{"action":"created","comment":{"url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/pulls/comments/89688243","pull_request_review_id":10229174,"id":89688243,"diff_hunk":"@@ -0,0 +1,54 @@\n+---\n+name: ElementButton\n+---\n+<style scoped>\n+.button {\n+\tdisplay: inline-block;\n+\tmin-width: 175px;\n+\tpadding: 12px 24px;\n+\tborder: 2px solid currentColor;\n+\tfont-weight: bold;\n+\tline-height: 40px;\n+\ttext-align: center;\n+\tcolor: var(--s2-black);\n+}\n+.button:hover {\n+\tcolor: var(--s2-white);\n+\tbackground: var(--s2-black);\n+}\n+\n+.button-bg {\n+\tbackground-color: var(--s2-white);\n+}\n+\n+.invert {\n+\tcolor: var(--s2-white);\n+}\n+.invert:hover {\n+\tbackground: var(--s2-white-fade);\n+}\n+\n+.button[data-theme=white]:hover {\n+\tbackground-color: var(--s2-white);\n+\tborder-color: var(--s2-white);\n+}\n+.button[data-theme=green]:hover {\n+\tbackground-color: var(--s2-green);\n+\tborder-color: var(--s2-green);\n+}\n+.button[data-theme=blue]:hover {\n+\tbackground-color: var(--s2-blue);\n+\tborder-color: var(--s2-blue);\n+}\n+.button[data-theme=red]:hover {\n+\tbackground-color: var(--s2-red);\n+\tborder-color: var(--s2-red);\n+}\n+</style>\n+<a\n+\t\thref={props.href}\n+\t\tclassName={helpers.classNames({[style.button]: true, [style.buttonBg]: props.buttonBg, [style.invert]: props.invert})}","path":"src/templates/element_button.html","position":50,"original_position":50,"commit_id":"750305fd4ef9cf4061d52205a64189d3b82dd2c6","original_commit_id":"750305fd4ef9cf4061d52205a64189d3b82dd2c6","user":{"login":"KnisterPeter","id":327445,"avatar_url":"https://avatars.githubusercontent.com/u/327445?v=3","gravatar_id":"","url":"https://api.github.com/users/KnisterPeter","html_url":"https://github.com/KnisterPeter","followers_url":"https://api.github.com/users/KnisterPeter/followers","following_url":"https://api.github.com/users/KnisterPeter/following{/other_user}","gists_url":"https://api.github.com/users/KnisterPeter/gists{/gist_id}","starred_url":"https://api.github.com/users/KnisterPeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnisterPeter/subscriptions","organizations_url":"https://api.github.com/users/KnisterPeter/orgs","repos_url":"https://api.github.com/users/KnisterPeter/repos","events_url":"https://api.github.com/users/KnisterPeter/events{/privacy}","received_events_url":"https://api.github.com/users/KnisterPeter/received_events","type":"User","site_admin":false},"body":"Nope: `helpers.classNames(style.button, {[style.buttonBg]: props.buttonBg, [style.invert]: props.invert})`\r\nThe style and props are different objects, so shortcut notation does not work here and you missed the invert class.\r\n","created_at":"2016-11-27T11:42:36Z","updated_at":"2016-11-27T11:42:36Z","html_url":"https://github.com/sinnerschrader/sinnerschrader-website/pull/81#discussion_r89688243","pull_request_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/pulls/81","_links":{"self":{"href":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/pulls/comments/89688243"},"html":{"href":"https://github.com/sinnerschrader/sinnerschrader-website/pull/81#discussion_r89688243"},"pull_request":{"href":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/pulls/81"}}},"pull_request":{"url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/pulls/81","id":95365035,"html_url":"https://github.com/sinnerschrader/sinnerschrader-website/pull/81","diff_url":"https://github.com/sinnerschrader/sinnerschrader-website/pull/81.diff","patch_url":"https://github.com/sinnerschrader/sinnerschrader-website/pull/81.patch","issue_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/issues/81","number":81,"state":"open","locked":false,"title":"refactor: element-button using scoped style","user":{"login":"KnisterPeter","id":327445,"avatar_url":"https://avatars.githubusercontent.com/u/327445?v=3","gravatar_id":"","url":"https://api.github.com/users/KnisterPeter","html_url":"https://github.com/KnisterPeter","followers_url":"https://api.github.com/users/KnisterPeter/followers","following_url":"https://api.github.com/users/KnisterPeter/following{/other_user}","gists_url":"https://api.github.com/users/KnisterPeter/gists{/gist_id}","starred_url":"https://api.github.com/users/KnisterPeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KnisterPeter/subscriptions","organizations_url":"https://api.github.com/users/KnisterPeter/orgs","repos_url":"https://api.github.com/users/KnisterPeter/repos","events_url":"https://api.github.com/users/KnisterPeter/events{/privacy}","received_events_url":"https://api.github.com/users/KnisterPeter/received_events","type":"User","site_admin":false},"body":"The element-button is refactored to used scoped styling.\r\nThe inverting of the button is moved to the position where the invertion\r\nis required. It is delegated to the button using css-vars.","created_at":"2016-11-26T08:19:49Z","updated_at":"2016-11-27T11:42:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49d7d31e820c5d76b93d34c1ee4c17f06c6c179d","assignee":{"login":"kotzendekrabbe","id":731399,"avatar_url":"https://avatars.githubusercontent.com/u/731399?v=3","gravatar_id":"","url":"https://api.github.com/users/kotzendekrabbe","html_url":"https://github.com/kotzendekrabbe","followers_url":"https://api.github.com/users/kotzendekrabbe/followers","following_url":"https://api.github.com/users/kotzendekrabbe/following{/other_user}","gists_url":"https://api.github.com/users/kotzendekrabbe/gists{/gist_id}","starred_url":"https://api.github.com/users/kotzendekrabbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kotzendekrabbe/subscriptions","organizations_url":"https://api.github.com/users/kotzendekrabbe/orgs","repos_url":"https://api.github.com/users/kotzendekrabbe/repos","events_url":"https://api.github.com/users/kotzendekrabbe/events{/privacy}","received_events_url":"https://api.github.com/users/kotzendekrabbe/received_events","type":"User","site_admin":false},"assignees":[{"login":"kotzendekrabbe","id":731399,"avatar_url":"https://avatars.githubusercontent.com/u/731399?v=3","gravatar_id":"","url":"https://api.github.com/users/kotzendekrabbe","html_url":"https://github.com/kotzendekrabbe","followers_url":"https://api.github.com/users/kotzendekrabbe/followers","following_url":"https://api.github.com/users/kotzendekrabbe/following{/other_user}","gists_url":"https://api.github.com/users/kotzendekrabbe/gists{/gist_id}","starred_url":"https://api.github.com/users/kotzendekrabbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kotzendekrabbe/subscriptions","organizations_url":"https://api.github.com/users/kotzendekrabbe/orgs","repos_url":"https://api.github.com/users/kotzendekrabbe/repos","events_url":"https://api.github.com/users/kotzendekrabbe/events{/privacy}","received_events_url":"https://api.github.com/users/kotzendekrabbe/received_events","type":"User","site_admin":false},{"login":"marionebl","id":4248851,"avatar_url":"https://avatars.githubusercontent.com/u/4248851?v=3","gravatar_id":"","url":"https://api.github.com/users/marionebl","html_url":"https://github.com/marionebl","followers_url":"https://api.github.com/users/marionebl/followers","following_url":"https://api.github.com/users/marionebl/following{/other_user}","gists_url":"https://api.github.com/users/marionebl/gists{/gist_id}","starred_url":"https://api.github.com/users/marionebl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marionebl/subscriptions","organizations_url":"https://api.github.com/users/marionebl/orgs","repos_url":"https://api.github.com/users/marionebl/repos","events_url":"https://api.github.com/users/marionebl/events{/privacy}","received_events_url":"https://api.github.com/users/marionebl/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/pulls/81/commits","review_comments_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/pulls/81/comments","review_comment_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/issues/81/comments","statuses_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/statuses/750305fd4ef9cf4061d52205a64189d3b82dd2c6","head":{"label":"sinnerschrader:scoped-button-style","ref":"scoped-button-style","sha":"750305fd4ef9cf4061d52205a64189d3b82dd2c6","user":{"login":"sinnerschrader","id":787835,"avatar_url":"https://avatars.githubusercontent.com/u/787835?v=3","gravatar_id":"","url":"https://api.github.com/users/sinnerschrader","html_url":"https://github.com/sinnerschrader","followers_url":"https://api.github.com/users/sinnerschrader/followers","following_url":"https://api.github.com/users/sinnerschrader/following{/other_user}","gists_url":"https://api.github.com/users/sinnerschrader/gists{/gist_id}","starred_url":"https://api.github.com/users/sinnerschrader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinnerschrader/subscriptions","organizations_url":"https://api.github.com/users/sinnerschrader/orgs","repos_url":"https://api.github.com/users/sinnerschrader/repos","events_url":"https://api.github.com/users/sinnerschrader/events{/privacy}","received_events_url":"https://api.github.com/users/sinnerschrader/received_events","type":"Organization","site_admin":false},"repo":{"id":71262946,"name":"sinnerschrader-website","full_name":"sinnerschrader/sinnerschrader-website","owner":{"login":"sinnerschrader","id":787835,"avatar_url":"https://avatars.githubusercontent.com/u/787835?v=3","gravatar_id":"","url":"https://api.github.com/users/sinnerschrader","html_url":"https://github.com/sinnerschrader","followers_url":"https://api.github.com/users/sinnerschrader/followers","following_url":"https://api.github.com/users/sinnerschrader/following{/other_user}","gists_url":"https://api.github.com/users/sinnerschrader/gists{/gist_id}","starred_url":"https://api.github.com/users/sinnerschrader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinnerschrader/subscriptions","organizations_url":"https://api.github.com/users/sinnerschrader/orgs","repos_url":"https://api.github.com/users/sinnerschrader/repos","events_url":"https://api.github.com/users/sinnerschrader/events{/privacy}","received_events_url":"https://api.github.com/users/sinnerschrader/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sinnerschrader/sinnerschrader-website","description":":earth_africa: Source project for sinnerschrader.com","fork":false,"url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website","forks_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/forks","keys_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/teams","hooks_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/hooks","issue_events_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/issues/events{/number}","events_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/events","assignees_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/assignees{/user}","branches_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/branches{/branch}","tags_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/tags","blobs_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/statuses/{sha}","languages_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/languages","stargazers_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/stargazers","contributors_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/contributors","subscribers_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/subscribers","subscription_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/subscription","commits_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/contents/{+path}","compare_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/merges","archive_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/downloads","issues_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/issues{/number}","pulls_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/pulls{/number}","milestones_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/milestones{/number}","notifications_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/labels{/name}","releases_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/releases{/id}","deployments_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/deployments","created_at":"2016-10-18T15:30:21Z","updated_at":"2016-11-22T16:05:04Z","pushed_at":"2016-11-27T08:11:48Z","git_url":"git://github.com/sinnerschrader/sinnerschrader-website.git","ssh_url":"git@github.com:sinnerschrader/sinnerschrader-website.git","clone_url":"https://github.com/sinnerschrader/sinnerschrader-website.git","svn_url":"https://github.com/sinnerschrader/sinnerschrader-website","homepage":"http://www.sinnerschrader.com","size":199600,"stargazers_count":20,"watchers_count":20,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":11,"forks":7,"open_issues":11,"watchers":20,"default_branch":"master"}},"base":{"label":"sinnerschrader:master","ref":"master","sha":"beaa7f166b8355f2e230a62f5fba8fa2bbb74b0e","user":{"login":"sinnerschrader","id":787835,"avatar_url":"https://avatars.githubusercontent.com/u/787835?v=3","gravatar_id":"","url":"https://api.github.com/users/sinnerschrader","html_url":"https://github.com/sinnerschrader","followers_url":"https://api.github.com/users/sinnerschrader/followers","following_url":"https://api.github.com/users/sinnerschrader/following{/other_user}","gists_url":"https://api.github.com/users/sinnerschrader/gists{/gist_id}","starred_url":"https://api.github.com/users/sinnerschrader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinnerschrader/subscriptions","organizations_url":"https://api.github.com/users/sinnerschrader/orgs","repos_url":"https://api.github.com/users/sinnerschrader/repos","events_url":"https://api.github.com/users/sinnerschrader/events{/privacy}","received_events_url":"https://api.github.com/users/sinnerschrader/received_events","type":"Organization","site_admin":false},"repo":{"id":71262946,"name":"sinnerschrader-website","full_name":"sinnerschrader/sinnerschrader-website","owner":{"login":"sinnerschrader","id":787835,"avatar_url":"https://avatars.githubusercontent.com/u/787835?v=3","gravatar_id":"","url":"https://api.github.com/users/sinnerschrader","html_url":"https://github.com/sinnerschrader","followers_url":"https://api.github.com/users/sinnerschrader/followers","following_url":"https://api.github.com/users/sinnerschrader/following{/other_user}","gists_url":"https://api.github.com/users/sinnerschrader/gists{/gist_id}","starred_url":"https://api.github.com/users/sinnerschrader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinnerschrader/subscriptions","organizations_url":"https://api.github.com/users/sinnerschrader/orgs","repos_url":"https://api.github.com/users/sinnerschrader/repos","events_url":"https://api.github.com/users/sinnerschrader/events{/privacy}","received_events_url":"https://api.github.com/users/sinnerschrader/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sinnerschrader/sinnerschrader-website","description":":earth_africa: Source project for sinnerschrader.com","fork":false,"url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website","forks_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/forks","keys_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/teams","hooks_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/hooks","issue_events_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/issues/events{/number}","events_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/events","assignees_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/assignees{/user}","branches_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/branches{/branch}","tags_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/tags","blobs_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/statuses/{sha}","languages_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/languages","stargazers_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/stargazers","contributors_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/contributors","subscribers_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/subscribers","subscription_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/subscription","commits_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/contents/{+path}","compare_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/merges","archive_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/downloads","issues_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/issues{/number}","pulls_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/pulls{/number}","milestones_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/milestones{/number}","notifications_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/labels{/name}","releases_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/releases{/id}","deployments_url":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/deployments","created_at":"2016-10-18T15:30:21Z","updated_at":"2016-11-22T16:05:04Z","pushed_at":"2016-11-27T08:11:48Z","git_url":"git://github.com/sinnerschrader/sinnerschrader-website.git","ssh_url":"git@github.com:sinnerschrader/sinnerschrader-website.git","clone_url":"https://github.com/sinnerschrader/sinnerschrader-website.git","svn_url":"https://github.com/sinnerschrader/sinnerschrader-website","homepage":"http://www.sinnerschrader.com","size":199600,"stargazers_count":20,"watchers_count":20,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":11,"forks":7,"open_issues":11,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/pulls/81"},"html":{"href":"https://github.com/sinnerschrader/sinnerschrader-website/pull/81"},"issue":{"href":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/issues/81"},"comments":{"href":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/sinnerschrader/sinnerschrader-website/statuses/750305fd4ef9cf4061d52205a64189d3b82dd2c6"}}}}
{"actor":{"display_login":"KnisterPeter"}}