{"action":"created","issue":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/4732","labels_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/4732/labels{/name}","comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/4732/comments","events_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/4732/events","html_url":"https://github.com/syl20bnr/spacemacs/pull/4732","id":128014248,"number":4732,"title":"golang: fix regex that searches tests","user":{"login":"bogdanteleaga","id":6207800,"avatar_url":"https://avatars.githubusercontent.com/u/6207800?v=3","gravatar_id":"","url":"https://api.github.com/users/bogdanteleaga","html_url":"https://github.com/bogdanteleaga","followers_url":"https://api.github.com/users/bogdanteleaga/followers","following_url":"https://api.github.com/users/bogdanteleaga/following{/other_user}","gists_url":"https://api.github.com/users/bogdanteleaga/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdanteleaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdanteleaga/subscriptions","organizations_url":"https://api.github.com/users/bogdanteleaga/orgs","repos_url":"https://api.github.com/users/bogdanteleaga/repos","events_url":"https://api.github.com/users/bogdanteleaga/events{/privacy}","received_events_url":"https://api.github.com/users/bogdanteleaga/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/syl20bnr/spacemacs/labels/Bug%20fix","name":"Bug fix","color":"207de5"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-21T20:37:25Z","updated_at":"2016-01-22T14:51:02Z","closed_at":"2016-01-22T14:51:02Z","pull_request":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/4732","html_url":"https://github.com/syl20bnr/spacemacs/pull/4732","diff_url":"https://github.com/syl20bnr/spacemacs/pull/4732.diff","patch_url":"https://github.com/syl20bnr/spacemacs/pull/4732.patch"},"body":"Related to https://github.com/syl20bnr/spacemacs/issues/4715\r\n\r\nBasically what happened here is that I didn't account for tests without suites and thus did not escape parantheses(even though I'm pretty sure I had that in an earlier version of the regex).\r\n\r\nSo \r\n```go\r\nfunc (s *suite) TestRandom(blabla) {\r\n}\r\n```\r\nwould work, but\r\n```go\r\nfunc TestRandom(blabla) {\r\n}\r\n```\r\nwouldn't. The patch makes the whole suite part an optional group.\r\n\r\nI did test it once, but I'd love to hear from the guys who responded on the issue."},"comment":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/comments/173940206","html_url":"https://github.com/syl20bnr/spacemacs/pull/4732#issuecomment-173940206","issue_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/4732","id":173940206,"user":{"login":"TheBB","id":619375,"avatar_url":"https://avatars.githubusercontent.com/u/619375?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBB","html_url":"https://github.com/TheBB","followers_url":"https://api.github.com/users/TheBB/followers","following_url":"https://api.github.com/users/TheBB/following{/other_user}","gists_url":"https://api.github.com/users/TheBB/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBB/subscriptions","organizations_url":"https://api.github.com/users/TheBB/orgs","repos_url":"https://api.github.com/users/TheBB/repos","events_url":"https://api.github.com/users/TheBB/events{/privacy}","received_events_url":"https://api.github.com/users/TheBB/received_events","type":"User","site_admin":false},"created_at":"2016-01-22T14:51:02Z","updated_at":"2016-01-22T14:51:02Z","body":"Thanks! Cherry-picked in develop. You can safely delete your branch."}}