{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/comments/52373641","id":52373641,"diff_hunk":"@@ -0,0 +1,69 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<project xmlns=\"http://maven.apache.org/POM/4.0.0\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd\">\n+    <modelVersion>4.0.0</modelVersion>\n+\n+    <artifactId>kafka-source</artifactId>\n+    <packaging>jar</packaging>\n+    <name>kafka-source</name>\n+    <description>Kafka Source stream module</description>\n+\n+    <parent>\n+        <groupId>org.springframework.cloud.stream.module</groupId>\n+        <artifactId>spring-cloud-stream-modules</artifactId>\n+        <version>1.0.0.BUILD-SNAPSHOT</version>\n+    </parent>\n+\n+    <properties>\n+        <start-class>org.springframework.cloud.stream.module.kafka.source.KafkaSourceApplication</start-class>\n+    </properties>\n+\n+    <dependencies>\n+        <dependency>\n+            <groupId>org.springframework.cloud.stream.module</groupId>\n+            <artifactId>spring-cloud-stream-modules-common-configuration</artifactId>\n+        </dependency>\n+        <dependency>\n+            <groupId>org.springframework.integration</groupId>\n+            <artifactId>spring-integration-java-dsl</artifactId>\n+        </dependency>\n+        <dependency>\n+            <groupId>org.springframework.integration</groupId>\n+            <artifactId>spring-integration-kafka</artifactId>\n+            <version>1.3.0.RELEASE</version>\n+            <exclusions>\n+                <exclusion>\n+                    <groupId>log4j</groupId>\n+                    <artifactId>log4j</artifactId>\n+                </exclusion>\n+                <exclusion>\n+                    <groupId>org.slf4j</groupId>\n+                    <artifactId>slf4j-log4j12</artifactId>\n+                </exclusion>\n+            </exclusions>\n+        </dependency>\n+        <dependency>\n+            <groupId>org.apache.kafka</groupId>\n+            <artifactId>kafka_2.10</artifactId>\n+            <classifier>test</classifier>\n+            <version>0.8.2.2</version>\n+            <optional>true</optional>\n+            <exclusions>\n+                <exclusion>\n+                    <groupId>log4j</groupId>\n+                    <artifactId>log4j</artifactId>\n+                </exclusion>\n+                <exclusion>\n+                    <groupId>org.slf4j</groupId>\n+                    <artifactId>slf4j-log4j12</artifactId>\n+                </exclusion>\n+            </exclusions>\n+        </dependency>\n+        <dependency>\n+            <groupId>org.springframework.cloud.stream.module</groupId>\n+            <artifactId>spring-cloud-stream-modules-test-support</artifactId>\n+            <version>1.0.0.BUILD-SNAPSHOT</version>","path":"kafka-source/pom.xml","position":64,"original_position":64,"commit_id":"99874014d03eab4bf9ec03d32b89fb1b27d60e56","original_commit_id":"99874014d03eab4bf9ec03d32b89fb1b27d60e56","user":{"login":"artembilan","id":1071590,"avatar_url":"https://avatars.githubusercontent.com/u/1071590?v=3","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"body":"The `version` is redundant here.\r\nWe are in the same project with its modules.\r\n\r\nI wonder if we even can avoid explicit `1.0.0.BUILD-SNAPSHOT` in the `<parent>` definition.\r\nFor example use some external `properties`, like we have with Gradle...","created_at":"2016-02-09T21:07:45Z","updated_at":"2016-02-09T21:07:45Z","html_url":"https://github.com/spring-cloud/spring-cloud-stream-modules/pull/170#discussion_r52373641","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/170","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/comments/52373641"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream-modules/pull/170#discussion_r52373641"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/170"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/170","id":57714187,"html_url":"https://github.com/spring-cloud/spring-cloud-stream-modules/pull/170","diff_url":"https://github.com/spring-cloud/spring-cloud-stream-modules/pull/170.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-stream-modules/pull/170.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/issues/170","number":170,"state":"open","locked":false,"title":"Kafka source #90","user":{"login":"sobychacko","id":827682,"avatar_url":"https://avatars.githubusercontent.com/u/827682?v=3","gravatar_id":"","url":"https://api.github.com/users/sobychacko","html_url":"https://github.com/sobychacko","followers_url":"https://api.github.com/users/sobychacko/followers","following_url":"https://api.github.com/users/sobychacko/following{/other_user}","gists_url":"https://api.github.com/users/sobychacko/gists{/gist_id}","starred_url":"https://api.github.com/users/sobychacko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sobychacko/subscriptions","organizations_url":"https://api.github.com/users/sobychacko/orgs","repos_url":"https://api.github.com/users/sobychacko/repos","events_url":"https://api.github.com/users/sobychacko/events{/privacy}","received_events_url":"https://api.github.com/users/sobychacko/received_events","type":"User","site_admin":false},"body":"resolves #90 ","created_at":"2016-01-29T22:51:34Z","updated_at":"2016-02-09T21:07:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df9b044f9c877c69367d5102107aaab9b9b00d2c","assignee":{"login":"mbogoevici","id":159684,"avatar_url":"https://avatars.githubusercontent.com/u/159684?v=3","gravatar_id":"","url":"https://api.github.com/users/mbogoevici","html_url":"https://github.com/mbogoevici","followers_url":"https://api.github.com/users/mbogoevici/followers","following_url":"https://api.github.com/users/mbogoevici/following{/other_user}","gists_url":"https://api.github.com/users/mbogoevici/gists{/gist_id}","starred_url":"https://api.github.com/users/mbogoevici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbogoevici/subscriptions","organizations_url":"https://api.github.com/users/mbogoevici/orgs","repos_url":"https://api.github.com/users/mbogoevici/repos","events_url":"https://api.github.com/users/mbogoevici/events{/privacy}","received_events_url":"https://api.github.com/users/mbogoevici/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/170/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/170/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/issues/170/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/statuses/99874014d03eab4bf9ec03d32b89fb1b27d60e56","head":{"label":"sobychacko:kafka-source-#90","ref":"kafka-source-#90","sha":"99874014d03eab4bf9ec03d32b89fb1b27d60e56","user":{"login":"sobychacko","id":827682,"avatar_url":"https://avatars.githubusercontent.com/u/827682?v=3","gravatar_id":"","url":"https://api.github.com/users/sobychacko","html_url":"https://github.com/sobychacko","followers_url":"https://api.github.com/users/sobychacko/followers","following_url":"https://api.github.com/users/sobychacko/following{/other_user}","gists_url":"https://api.github.com/users/sobychacko/gists{/gist_id}","starred_url":"https://api.github.com/users/sobychacko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sobychacko/subscriptions","organizations_url":"https://api.github.com/users/sobychacko/orgs","repos_url":"https://api.github.com/users/sobychacko/repos","events_url":"https://api.github.com/users/sobychacko/events{/privacy}","received_events_url":"https://api.github.com/users/sobychacko/received_events","type":"User","site_admin":false},"repo":{"id":46378506,"name":"spring-cloud-stream-modules","full_name":"sobychacko/spring-cloud-stream-modules","owner":{"login":"sobychacko","id":827682,"avatar_url":"https://avatars.githubusercontent.com/u/827682?v=3","gravatar_id":"","url":"https://api.github.com/users/sobychacko","html_url":"https://github.com/sobychacko","followers_url":"https://api.github.com/users/sobychacko/followers","following_url":"https://api.github.com/users/sobychacko/following{/other_user}","gists_url":"https://api.github.com/users/sobychacko/gists{/gist_id}","starred_url":"https://api.github.com/users/sobychacko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sobychacko/subscriptions","organizations_url":"https://api.github.com/users/sobychacko/orgs","repos_url":"https://api.github.com/users/sobychacko/repos","events_url":"https://api.github.com/users/sobychacko/events{/privacy}","received_events_url":"https://api.github.com/users/sobychacko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sobychacko/spring-cloud-stream-modules","description":"","fork":true,"url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules","forks_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/forks","keys_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/teams","hooks_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/hooks","issue_events_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/issues/events{/number}","events_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/events","assignees_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/assignees{/user}","branches_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/branches{/branch}","tags_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/tags","blobs_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/statuses/{sha}","languages_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/languages","stargazers_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/stargazers","contributors_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/contributors","subscribers_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/subscribers","subscription_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/subscription","commits_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/contents/{+path}","compare_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/merges","archive_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/downloads","issues_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/issues{/number}","pulls_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/pulls{/number}","milestones_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/milestones{/number}","notifications_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/labels{/name}","releases_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/releases{/id}","deployments_url":"https://api.github.com/repos/sobychacko/spring-cloud-stream-modules/deployments","created_at":"2015-11-17T22:07:38Z","updated_at":"2016-01-20T22:22:58Z","pushed_at":"2016-02-09T20:52:26Z","git_url":"git://github.com/sobychacko/spring-cloud-stream-modules.git","ssh_url":"git@github.com:sobychacko/spring-cloud-stream-modules.git","clone_url":"https://github.com/sobychacko/spring-cloud-stream-modules.git","svn_url":"https://github.com/sobychacko/spring-cloud-stream-modules","homepage":null,"size":1451,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"31ab8137433401de9a66a0937acd73d5c16b0004","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":40096018,"name":"spring-cloud-stream-modules","full_name":"spring-cloud/spring-cloud-stream-modules","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-stream-modules","description":"Spring Boot based enterprise integration applications that provide integration with external systems","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/deployments","created_at":"2015-08-02T23:22:20Z","updated_at":"2016-01-22T01:09:59Z","pushed_at":"2016-02-09T20:52:27Z","git_url":"git://github.com/spring-cloud/spring-cloud-stream-modules.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-stream-modules.git","clone_url":"https://github.com/spring-cloud/spring-cloud-stream-modules.git","svn_url":"https://github.com/spring-cloud/spring-cloud-stream-modules","homepage":"http://cloud.spring.io/spring-cloud-stream-modules/","size":2015,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"open_issues_count":57,"forks":30,"open_issues":57,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/170"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream-modules/pull/170"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/issues/170"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/issues/170/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/170/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/170/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/statuses/99874014d03eab4bf9ec03d32b89fb1b27d60e56"}}}}