{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/52702164","id":52702164,"diff_hunk":"@@ -0,0 +1,193 @@\n+// Licensed to the .NET Foundation under one or more agreements.","path":"src/jit/jitconfigvalues.h","position":1,"original_position":1,"commit_id":"19dce3795be19785b1e1bac534a919c4d9b01fbf","original_commit_id":"19dce3795be19785b1e1bac534a919c4d9b01fbf","user":{"login":"sivarv","id":11184808,"avatar_url":"https://avatars.githubusercontent.com/u/11184808?v=3","gravatar_id":"","url":"https://api.github.com/users/sivarv","html_url":"https://github.com/sivarv","followers_url":"https://api.github.com/users/sivarv/followers","following_url":"https://api.github.com/users/sivarv/following{/other_user}","gists_url":"https://api.github.com/users/sivarv/gists{/gist_id}","starred_url":"https://api.github.com/users/sivarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivarv/subscriptions","organizations_url":"https://api.github.com/users/sivarv/orgs","repos_url":"https://api.github.com/users/sivarv/repos","events_url":"https://api.github.com/users/sivarv/events{/privacy}","received_events_url":"https://api.github.com/users/sivarv/received_events","type":"User","site_admin":false},"body":"The fundamental issue here is that Jit-EE call getIntConfigValue()/getStringConfigValue() has hardcoded config options disregarding the ones specified in clrconfigvalues.h.  We need to parameterize these routines and also allow config options to be specified against a config setting.  This would essentially mean copying config options from clrconfigvalues.h to jitconfigvalues.h.  Rather i would suggest to strive for a single copy for jit config values.","created_at":"2016-02-12T03:21:59Z","updated_at":"2016-02-12T03:21:59Z","html_url":"https://github.com/dotnet/coreclr/pull/3117#discussion_r52702164","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/3117","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/52702164"},"html":{"href":"https://github.com/dotnet/coreclr/pull/3117#discussion_r52702164"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/3117"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/3117","id":58960651,"html_url":"https://github.com/dotnet/coreclr/pull/3117","diff_url":"https://github.com/dotnet/coreclr/pull/3117.diff","patch_url":"https://github.com/dotnet/coreclr/pull/3117.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/3117","number":3117,"state":"open","locked":false,"title":"Add a new set of APIs for JIT configuration.","user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"body":"These APIs accommodate the retrieval of config values using the JIT\r\ninterface rather than the utilcode library. All configuration options\r\nare now initialized upon the first call to compileMethod. The values\r\nof configuration options are available off of an ambient JitConfig\r\nobject.","created_at":"2016-02-10T22:00:00Z","updated_at":"2016-02-12T03:21:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9bc5c0c44994ccaa6969fedda5e30c62f6615ba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/3117/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/3117/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/3117/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/19dce3795be19785b1e1bac534a919c4d9b01fbf","head":{"label":"pgavlin:RyuJitConfigAPIs2","ref":"RyuJitConfigAPIs2","sha":"19dce3795be19785b1e1bac534a919c4d9b01fbf","user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"repo":{"id":30321049,"name":"coreclr","full_name":"pgavlin/coreclr","owner":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pgavlin/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/pgavlin/coreclr","forks_url":"https://api.github.com/repos/pgavlin/coreclr/forks","keys_url":"https://api.github.com/repos/pgavlin/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pgavlin/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pgavlin/coreclr/teams","hooks_url":"https://api.github.com/repos/pgavlin/coreclr/hooks","issue_events_url":"https://api.github.com/repos/pgavlin/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/pgavlin/coreclr/events","assignees_url":"https://api.github.com/repos/pgavlin/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/pgavlin/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/pgavlin/coreclr/tags","blobs_url":"https://api.github.com/repos/pgavlin/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pgavlin/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pgavlin/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/pgavlin/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pgavlin/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/pgavlin/coreclr/languages","stargazers_url":"https://api.github.com/repos/pgavlin/coreclr/stargazers","contributors_url":"https://api.github.com/repos/pgavlin/coreclr/contributors","subscribers_url":"https://api.github.com/repos/pgavlin/coreclr/subscribers","subscription_url":"https://api.github.com/repos/pgavlin/coreclr/subscription","commits_url":"https://api.github.com/repos/pgavlin/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/pgavlin/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/pgavlin/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/pgavlin/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/pgavlin/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/pgavlin/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pgavlin/coreclr/merges","archive_url":"https://api.github.com/repos/pgavlin/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pgavlin/coreclr/downloads","issues_url":"https://api.github.com/repos/pgavlin/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/pgavlin/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/pgavlin/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/pgavlin/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pgavlin/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/pgavlin/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/pgavlin/coreclr/deployments","created_at":"2015-02-04T21:04:39Z","updated_at":"2015-04-29T15:22:25Z","pushed_at":"2016-02-12T01:19:00Z","git_url":"git://github.com/pgavlin/coreclr.git","ssh_url":"git@github.com:pgavlin/coreclr.git","clone_url":"https://github.com/pgavlin/coreclr.git","svn_url":"https://github.com/pgavlin/coreclr","homepage":"","size":59136,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"c39ac0e98bc69889192f1614203d6858de502472","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-02-11T22:12:06Z","pushed_at":"2016-02-12T03:18:07Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"http://dotnet.github.io/","size":64035,"stargazers_count":5852,"watchers_count":5852,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1286,"mirror_url":null,"open_issues_count":527,"forks":1286,"open_issues":527,"watchers":5852,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/3117"},"html":{"href":"https://github.com/dotnet/coreclr/pull/3117"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/3117"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/3117/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/3117/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/3117/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/19dce3795be19785b1e1bac534a919c4d9b01fbf"}}}}