{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/59918299","id":59918299,"diff_hunk":"@@ -305,21 +303,27 @@ public override int GetHashCode()\n \n     internal class TempAssemblyCache\n     {\n-        private Hashtable _cache = new Hashtable();\n+        private Dictionary<TempAssemblyCacheKey, TempAssembly> _cache = new Dictionary<TempAssemblyCacheKey, TempAssembly>();","path":"src/System.Xml.XmlSerializer/src/System/Xml/Serialization/Compilation.cs","position":36,"original_position":36,"commit_id":"0da6ea3341cd8c5925a475059a2a33d598056fdd","original_commit_id":"0da6ea3341cd8c5925a475059a2a33d598056fdd","user":{"login":"khdang","id":10590707,"avatar_url":"https://avatars.githubusercontent.com/u/10590707?v=3","gravatar_id":"","url":"https://api.github.com/users/khdang","html_url":"https://github.com/khdang","followers_url":"https://api.github.com/users/khdang/followers","following_url":"https://api.github.com/users/khdang/following{/other_user}","gists_url":"https://api.github.com/users/khdang/gists{/gist_id}","starred_url":"https://api.github.com/users/khdang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khdang/subscriptions","organizations_url":"https://api.github.com/users/khdang/orgs","repos_url":"https://api.github.com/users/khdang/repos","events_url":"https://api.github.com/users/khdang/events{/privacy}","received_events_url":"https://api.github.com/users/khdang/received_events","type":"User","site_admin":false},"body":"Thanks for the insight. This means that this part could have issue with concurrent reading and writing to ```_cache```. Let me investigate this further to see if it needs to be fixed. Ref #7778","created_at":"2016-04-15T18:23:00Z","updated_at":"2016-04-15T18:23:00Z","html_url":"https://github.com/dotnet/corefx/pull/7765#discussion_r59918299","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/7765","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/59918299"},"html":{"href":"https://github.com/dotnet/corefx/pull/7765#discussion_r59918299"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7765"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/7765","id":66574247,"html_url":"https://github.com/dotnet/corefx/pull/7765","diff_url":"https://github.com/dotnet/corefx/pull/7765.diff","patch_url":"https://github.com/dotnet/corefx/pull/7765.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/7765","number":7765,"state":"open","locked":false,"title":"Remove nongeneric collections shim from serialization","user":{"login":"khdang","id":10590707,"avatar_url":"https://avatars.githubusercontent.com/u/10590707?v=3","gravatar_id":"","url":"https://api.github.com/users/khdang","html_url":"https://github.com/khdang","followers_url":"https://api.github.com/users/khdang/followers","following_url":"https://api.github.com/users/khdang/following{/other_user}","gists_url":"https://api.github.com/users/khdang/gists{/gist_id}","starred_url":"https://api.github.com/users/khdang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khdang/subscriptions","organizations_url":"https://api.github.com/users/khdang/orgs","repos_url":"https://api.github.com/users/khdang/repos","events_url":"https://api.github.com/users/khdang/events{/privacy}","received_events_url":"https://api.github.com/users/khdang/received_events","type":"User","site_admin":false},"body":"Remove non-generic collections ```ArrayList``` and ```InternalHashtable``` and use ArrayList and generic dictionary instead. There should be no change in behavior.\r\n\r\ncc: @shmao @zhenlan @SGuyGe\r\n\r\nFix #7699 ","created_at":"2016-04-15T00:21:41Z","updated_at":"2016-04-15T18:23:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"551719d512dcc8159ffaabafcd39699a06cfcf27","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/7765/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/7765/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/7765/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/0da6ea3341cd8c5925a475059a2a33d598056fdd","head":{"label":"khdang:remove_collections_shim_serialization","ref":"remove_collections_shim_serialization","sha":"0da6ea3341cd8c5925a475059a2a33d598056fdd","user":{"login":"khdang","id":10590707,"avatar_url":"https://avatars.githubusercontent.com/u/10590707?v=3","gravatar_id":"","url":"https://api.github.com/users/khdang","html_url":"https://github.com/khdang","followers_url":"https://api.github.com/users/khdang/followers","following_url":"https://api.github.com/users/khdang/following{/other_user}","gists_url":"https://api.github.com/users/khdang/gists{/gist_id}","starred_url":"https://api.github.com/users/khdang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khdang/subscriptions","organizations_url":"https://api.github.com/users/khdang/orgs","repos_url":"https://api.github.com/users/khdang/repos","events_url":"https://api.github.com/users/khdang/events{/privacy}","received_events_url":"https://api.github.com/users/khdang/received_events","type":"User","site_admin":false},"repo":{"id":33624190,"name":"corefx","full_name":"khdang/corefx","owner":{"login":"khdang","id":10590707,"avatar_url":"https://avatars.githubusercontent.com/u/10590707?v=3","gravatar_id":"","url":"https://api.github.com/users/khdang","html_url":"https://github.com/khdang","followers_url":"https://api.github.com/users/khdang/followers","following_url":"https://api.github.com/users/khdang/following{/other_user}","gists_url":"https://api.github.com/users/khdang/gists{/gist_id}","starred_url":"https://api.github.com/users/khdang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khdang/subscriptions","organizations_url":"https://api.github.com/users/khdang/orgs","repos_url":"https://api.github.com/users/khdang/repos","events_url":"https://api.github.com/users/khdang/events{/privacy}","received_events_url":"https://api.github.com/users/khdang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/khdang/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/khdang/corefx","forks_url":"https://api.github.com/repos/khdang/corefx/forks","keys_url":"https://api.github.com/repos/khdang/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/khdang/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/khdang/corefx/teams","hooks_url":"https://api.github.com/repos/khdang/corefx/hooks","issue_events_url":"https://api.github.com/repos/khdang/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/khdang/corefx/events","assignees_url":"https://api.github.com/repos/khdang/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/khdang/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/khdang/corefx/tags","blobs_url":"https://api.github.com/repos/khdang/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/khdang/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/khdang/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/khdang/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/khdang/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/khdang/corefx/languages","stargazers_url":"https://api.github.com/repos/khdang/corefx/stargazers","contributors_url":"https://api.github.com/repos/khdang/corefx/contributors","subscribers_url":"https://api.github.com/repos/khdang/corefx/subscribers","subscription_url":"https://api.github.com/repos/khdang/corefx/subscription","commits_url":"https://api.github.com/repos/khdang/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/khdang/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/khdang/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/khdang/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/khdang/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/khdang/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/khdang/corefx/merges","archive_url":"https://api.github.com/repos/khdang/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/khdang/corefx/downloads","issues_url":"https://api.github.com/repos/khdang/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/khdang/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/khdang/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/khdang/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/khdang/corefx/labels{/name}","releases_url":"https://api.github.com/repos/khdang/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/khdang/corefx/deployments","created_at":"2015-04-08T18:20:35Z","updated_at":"2016-02-10T22:31:56Z","pushed_at":"2016-04-15T00:19:09Z","git_url":"git://github.com/khdang/corefx.git","ssh_url":"git@github.com:khdang/corefx.git","clone_url":"https://github.com/khdang/corefx.git","svn_url":"https://github.com/khdang/corefx","homepage":"","size":63971,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"7f20bf7a59a48b07d27fcd1aa2cd43cf814fac4b","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-04-15T16:11:00Z","pushed_at":"2016-04-15T18:10:31Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":86954,"stargazers_count":9500,"watchers_count":9500,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2256,"mirror_url":null,"open_issues_count":933,"forks":2256,"open_issues":933,"watchers":9500,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7765"},"html":{"href":"https://github.com/dotnet/corefx/pull/7765"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/7765"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/7765/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7765/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/7765/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/0da6ea3341cd8c5925a475059a2a33d598056fdd"}}}}