{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/comments/49370164","id":49370164,"diff_hunk":"@@ -41,16 +66,21 @@\n   end\n \n   pkg.build do\n-    [\"#{platform[:make]} -j$(shell expr $(shell #{platform[:num_cores]}) + 1)\"]\n+    [\"#{make} -j$(shell expr $(shell #{platform[:num_cores]}) + 1)\"]\n   end\n \n   pkg.install do\n-    [\"#{platform[:make]} -j$(shell expr $(shell #{platform[:num_cores]}) + 1) install\"]\n+    [\"#{make} -j$(shell expr $(shell #{platform[:num_cores]}) + 1) install\"]\n   end\n \n+  # Due to windows, when we run the configure, we need this variable to be set\n+  # in accordance with windows pathing. However, when we create the directory\n+  # below, we need it in accordance with cygwin pathing.\n+  install_root = settings[:prefix] if platform.is_windows?","path":"configs/components/pxp-agent.rb","position":74,"original_position":74,"commit_id":"e2ddbb6922fe8df8082576355cfa32580bbf533f","original_commit_id":"e2ddbb6922fe8df8082576355cfa32580bbf533f","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"Why does it use `settings[:prefix]` here? I'm not sure I understand what's happening.","created_at":"2016-01-11T19:59:34Z","updated_at":"2016-01-11T19:59:34Z","html_url":"https://github.com/puppetlabs/puppet-agent/pull/474#discussion_r49370164","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/474","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/comments/49370164"},"html":{"href":"https://github.com/puppetlabs/puppet-agent/pull/474#discussion_r49370164"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/474"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/474","id":55135577,"html_url":"https://github.com/puppetlabs/puppet-agent/pull/474","diff_url":"https://github.com/puppetlabs/puppet-agent/pull/474.diff","patch_url":"https://github.com/puppetlabs/puppet-agent/pull/474.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/474","number":474,"state":"open","locked":false,"title":"(RE-6013) Ensure native projects build on windows","user":{"login":"melissa","id":4473089,"avatar_url":"https://avatars.githubusercontent.com/u/4473089?v=3","gravatar_id":"","url":"https://api.github.com/users/melissa","html_url":"https://github.com/melissa","followers_url":"https://api.github.com/users/melissa/followers","following_url":"https://api.github.com/users/melissa/following{/other_user}","gists_url":"https://api.github.com/users/melissa/gists{/gist_id}","starred_url":"https://api.github.com/users/melissa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melissa/subscriptions","organizations_url":"https://api.github.com/users/melissa/orgs","repos_url":"https://api.github.com/users/melissa/repos","events_url":"https://api.github.com/users/melissa/events{/privacy}","received_events_url":"https://api.github.com/users/melissa/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-01-05T20:00:25Z","updated_at":"2016-01-11T19:59:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a343776b4eee1e1ed5b402630eddd54a80270873","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/474/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/474/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/474/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-agent/statuses/e2ddbb6922fe8df8082576355cfa32580bbf533f","head":{"label":"melissa:ticket/vanagon_for_the_win/native-projects","ref":"ticket/vanagon_for_the_win/native-projects","sha":"e2ddbb6922fe8df8082576355cfa32580bbf533f","user":{"login":"melissa","id":4473089,"avatar_url":"https://avatars.githubusercontent.com/u/4473089?v=3","gravatar_id":"","url":"https://api.github.com/users/melissa","html_url":"https://github.com/melissa","followers_url":"https://api.github.com/users/melissa/followers","following_url":"https://api.github.com/users/melissa/following{/other_user}","gists_url":"https://api.github.com/users/melissa/gists{/gist_id}","starred_url":"https://api.github.com/users/melissa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melissa/subscriptions","organizations_url":"https://api.github.com/users/melissa/orgs","repos_url":"https://api.github.com/users/melissa/repos","events_url":"https://api.github.com/users/melissa/events{/privacy}","received_events_url":"https://api.github.com/users/melissa/received_events","type":"User","site_admin":false},"repo":{"id":48144163,"name":"puppet-agent","full_name":"melissa/puppet-agent","owner":{"login":"melissa","id":4473089,"avatar_url":"https://avatars.githubusercontent.com/u/4473089?v=3","gravatar_id":"","url":"https://api.github.com/users/melissa","html_url":"https://github.com/melissa","followers_url":"https://api.github.com/users/melissa/followers","following_url":"https://api.github.com/users/melissa/following{/other_user}","gists_url":"https://api.github.com/users/melissa/gists{/gist_id}","starred_url":"https://api.github.com/users/melissa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melissa/subscriptions","organizations_url":"https://api.github.com/users/melissa/orgs","repos_url":"https://api.github.com/users/melissa/repos","events_url":"https://api.github.com/users/melissa/events{/privacy}","received_events_url":"https://api.github.com/users/melissa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/melissa/puppet-agent","description":"All of the directions for building a puppet agent package.","fork":true,"url":"https://api.github.com/repos/melissa/puppet-agent","forks_url":"https://api.github.com/repos/melissa/puppet-agent/forks","keys_url":"https://api.github.com/repos/melissa/puppet-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/melissa/puppet-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/melissa/puppet-agent/teams","hooks_url":"https://api.github.com/repos/melissa/puppet-agent/hooks","issue_events_url":"https://api.github.com/repos/melissa/puppet-agent/issues/events{/number}","events_url":"https://api.github.com/repos/melissa/puppet-agent/events","assignees_url":"https://api.github.com/repos/melissa/puppet-agent/assignees{/user}","branches_url":"https://api.github.com/repos/melissa/puppet-agent/branches{/branch}","tags_url":"https://api.github.com/repos/melissa/puppet-agent/tags","blobs_url":"https://api.github.com/repos/melissa/puppet-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/melissa/puppet-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/melissa/puppet-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/melissa/puppet-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/melissa/puppet-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/melissa/puppet-agent/languages","stargazers_url":"https://api.github.com/repos/melissa/puppet-agent/stargazers","contributors_url":"https://api.github.com/repos/melissa/puppet-agent/contributors","subscribers_url":"https://api.github.com/repos/melissa/puppet-agent/subscribers","subscription_url":"https://api.github.com/repos/melissa/puppet-agent/subscription","commits_url":"https://api.github.com/repos/melissa/puppet-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/melissa/puppet-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/melissa/puppet-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/melissa/puppet-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/melissa/puppet-agent/contents/{+path}","compare_url":"https://api.github.com/repos/melissa/puppet-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/melissa/puppet-agent/merges","archive_url":"https://api.github.com/repos/melissa/puppet-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/melissa/puppet-agent/downloads","issues_url":"https://api.github.com/repos/melissa/puppet-agent/issues{/number}","pulls_url":"https://api.github.com/repos/melissa/puppet-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/melissa/puppet-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/melissa/puppet-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/melissa/puppet-agent/labels{/name}","releases_url":"https://api.github.com/repos/melissa/puppet-agent/releases{/id}","created_at":"2015-12-17T01:07:40Z","updated_at":"2015-12-17T01:07:41Z","pushed_at":"2016-01-08T17:50:31Z","git_url":"git://github.com/melissa/puppet-agent.git","ssh_url":"git@github.com:melissa/puppet-agent.git","clone_url":"https://github.com/melissa/puppet-agent.git","svn_url":"https://github.com/melissa/puppet-agent","homepage":null,"size":3240,"stargazers_count":0,"watchers_count":0,"language":"Groff","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:feature/master/windows-vanagon-development","ref":"feature/master/windows-vanagon-development","sha":"3447613963a5bd70b7f4d1b77d5591309f1ad0d0","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":26777895,"name":"puppet-agent","full_name":"puppetlabs/puppet-agent","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet-agent","description":"All of the directions for building a puppet agent package.","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet-agent","forks_url":"https://api.github.com/repos/puppetlabs/puppet-agent/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet-agent/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet-agent/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet-agent/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet-agent/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet-agent/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet-agent/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet-agent/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet-agent/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet-agent/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet-agent/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet-agent/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet-agent/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet-agent/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet-agent/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet-agent/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet-agent/releases{/id}","created_at":"2014-11-17T21:23:08Z","updated_at":"2016-01-11T19:35:10Z","pushed_at":"2016-01-11T19:35:09Z","git_url":"git://github.com/puppetlabs/puppet-agent.git","ssh_url":"git@github.com:puppetlabs/puppet-agent.git","clone_url":"https://github.com/puppetlabs/puppet-agent.git","svn_url":"https://github.com/puppetlabs/puppet-agent","homepage":null,"size":3397,"stargazers_count":3,"watchers_count":3,"language":"Groff","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":8,"forks":19,"open_issues":8,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/474"},"html":{"href":"https://github.com/puppetlabs/puppet-agent/pull/474"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/474"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/474/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/474/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/474/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/statuses/e2ddbb6922fe8df8082576355cfa32580bbf533f"}}}}