{"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/fullerite/pulls/comments/67863324","id":67863324,"diff_hunk":"@@ -151,3 +164,12 @@ func reportCollector(collector collector.Collector) {\n \tmetric.AddDimension(\"interval\", fmt.Sprintf(\"%d\", collector.Interval()))\n \tcollector.Channel() <- metric\n }\n+\n+func stringInSlice(metricName string, collectorName string, list []string) bool {\n+\tfor _, v := range list {","path":"src/fullerite/collectors.go","position":51,"original_position":51,"commit_id":"175a3cf8745d88a8b91edcd2e2895bed37a0d99f","original_commit_id":"175a3cf8745d88a8b91edcd2e2895bed37a0d99f","user":{"login":"gnufied","id":278,"avatar_url":"https://avatars.githubusercontent.com/u/278?v=3","gravatar_id":"","url":"https://api.github.com/users/gnufied","html_url":"https://github.com/gnufied","followers_url":"https://api.github.com/users/gnufied/followers","following_url":"https://api.github.com/users/gnufied/following{/other_user}","gists_url":"https://api.github.com/users/gnufied/gists{/gist_id}","starred_url":"https://api.github.com/users/gnufied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnufied/subscriptions","organizations_url":"https://api.github.com/users/gnufied/orgs","repos_url":"https://api.github.com/users/gnufied/repos","events_url":"https://api.github.com/users/gnufied/events{/privacy}","received_events_url":"https://api.github.com/users/gnufied/received_events","type":"User","site_admin":false},"body":"Usually collector properties like these become part of `Collector` interface, so that we can simply say `collector.Blacklist()` . Is there any reason you are trying to avoid making this part of the Collector interface?","created_at":"2016-06-21T13:05:00Z","updated_at":"2016-06-21T13:05:00Z","html_url":"https://github.com/Yelp/fullerite/pull/272#discussion_r67863324","pull_request_url":"https://api.github.com/repos/Yelp/fullerite/pulls/272","_links":{"self":{"href":"https://api.github.com/repos/Yelp/fullerite/pulls/comments/67863324"},"html":{"href":"https://github.com/Yelp/fullerite/pull/272#discussion_r67863324"},"pull_request":{"href":"https://api.github.com/repos/Yelp/fullerite/pulls/272"}}},"pull_request":{"url":"https://api.github.com/repos/Yelp/fullerite/pulls/272","id":74478306,"html_url":"https://github.com/Yelp/fullerite/pull/272","diff_url":"https://github.com/Yelp/fullerite/pull/272.diff","patch_url":"https://github.com/Yelp/fullerite/pull/272.patch","issue_url":"https://api.github.com/repos/Yelp/fullerite/issues/272","number":272,"state":"open","locked":false,"title":"Implement blacklist for go collectors at core level","user":{"login":"dichiarafrancesco","id":10674587,"avatar_url":"https://avatars.githubusercontent.com/u/10674587?v=3","gravatar_id":"","url":"https://api.github.com/users/dichiarafrancesco","html_url":"https://github.com/dichiarafrancesco","followers_url":"https://api.github.com/users/dichiarafrancesco/followers","following_url":"https://api.github.com/users/dichiarafrancesco/following{/other_user}","gists_url":"https://api.github.com/users/dichiarafrancesco/gists{/gist_id}","starred_url":"https://api.github.com/users/dichiarafrancesco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dichiarafrancesco/subscriptions","organizations_url":"https://api.github.com/users/dichiarafrancesco/orgs","repos_url":"https://api.github.com/users/dichiarafrancesco/repos","events_url":"https://api.github.com/users/dichiarafrancesco/events{/privacy}","received_events_url":"https://api.github.com/users/dichiarafrancesco/received_events","type":"User","site_admin":false},"body":"So we dont need to do the same work inside each collector.","created_at":"2016-06-20T17:07:25Z","updated_at":"2016-06-21T13:05:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8aa1cb951403773da3e81d0dff51a07a18382d66","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/fullerite/pulls/272/commits","review_comments_url":"https://api.github.com/repos/Yelp/fullerite/pulls/272/comments","review_comment_url":"https://api.github.com/repos/Yelp/fullerite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/fullerite/issues/272/comments","statuses_url":"https://api.github.com/repos/Yelp/fullerite/statuses/175a3cf8745d88a8b91edcd2e2895bed37a0d99f","head":{"label":"Yelp:METRICS-491_fdc_implement-blacklist-at-core-level","ref":"METRICS-491_fdc_implement-blacklist-at-core-level","sha":"175a3cf8745d88a8b91edcd2e2895bed37a0d99f","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":39368384,"name":"fullerite","full_name":"Yelp/fullerite","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/fullerite","description":"Fullerite is a daemon which collect metrics periodically from various sources and sends them to different metric stores","fork":false,"url":"https://api.github.com/repos/Yelp/fullerite","forks_url":"https://api.github.com/repos/Yelp/fullerite/forks","keys_url":"https://api.github.com/repos/Yelp/fullerite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/fullerite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/fullerite/teams","hooks_url":"https://api.github.com/repos/Yelp/fullerite/hooks","issue_events_url":"https://api.github.com/repos/Yelp/fullerite/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/fullerite/events","assignees_url":"https://api.github.com/repos/Yelp/fullerite/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/fullerite/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/fullerite/tags","blobs_url":"https://api.github.com/repos/Yelp/fullerite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/fullerite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/fullerite/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/fullerite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/fullerite/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/fullerite/languages","stargazers_url":"https://api.github.com/repos/Yelp/fullerite/stargazers","contributors_url":"https://api.github.com/repos/Yelp/fullerite/contributors","subscribers_url":"https://api.github.com/repos/Yelp/fullerite/subscribers","subscription_url":"https://api.github.com/repos/Yelp/fullerite/subscription","commits_url":"https://api.github.com/repos/Yelp/fullerite/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/fullerite/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/fullerite/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/fullerite/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/fullerite/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/fullerite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/fullerite/merges","archive_url":"https://api.github.com/repos/Yelp/fullerite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/fullerite/downloads","issues_url":"https://api.github.com/repos/Yelp/fullerite/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/fullerite/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/fullerite/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/fullerite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/fullerite/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/fullerite/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/fullerite/deployments","created_at":"2015-07-20T07:01:49Z","updated_at":"2016-06-02T02:54:26Z","pushed_at":"2016-06-20T17:07:25Z","git_url":"git://github.com/Yelp/fullerite.git","ssh_url":"git@github.com:Yelp/fullerite.git","clone_url":"https://github.com/Yelp/fullerite.git","svn_url":"https://github.com/Yelp/fullerite","homepage":"","size":8020,"stargazers_count":129,"watchers_count":129,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":23,"forks":29,"open_issues":23,"watchers":129,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"874995704a6b6983ba150bb5db0ce8878d7dbaec","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":39368384,"name":"fullerite","full_name":"Yelp/fullerite","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/fullerite","description":"Fullerite is a daemon which collect metrics periodically from various sources and sends them to different metric stores","fork":false,"url":"https://api.github.com/repos/Yelp/fullerite","forks_url":"https://api.github.com/repos/Yelp/fullerite/forks","keys_url":"https://api.github.com/repos/Yelp/fullerite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/fullerite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/fullerite/teams","hooks_url":"https://api.github.com/repos/Yelp/fullerite/hooks","issue_events_url":"https://api.github.com/repos/Yelp/fullerite/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/fullerite/events","assignees_url":"https://api.github.com/repos/Yelp/fullerite/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/fullerite/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/fullerite/tags","blobs_url":"https://api.github.com/repos/Yelp/fullerite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/fullerite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/fullerite/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/fullerite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/fullerite/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/fullerite/languages","stargazers_url":"https://api.github.com/repos/Yelp/fullerite/stargazers","contributors_url":"https://api.github.com/repos/Yelp/fullerite/contributors","subscribers_url":"https://api.github.com/repos/Yelp/fullerite/subscribers","subscription_url":"https://api.github.com/repos/Yelp/fullerite/subscription","commits_url":"https://api.github.com/repos/Yelp/fullerite/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/fullerite/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/fullerite/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/fullerite/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/fullerite/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/fullerite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/fullerite/merges","archive_url":"https://api.github.com/repos/Yelp/fullerite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/fullerite/downloads","issues_url":"https://api.github.com/repos/Yelp/fullerite/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/fullerite/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/fullerite/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/fullerite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/fullerite/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/fullerite/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/fullerite/deployments","created_at":"2015-07-20T07:01:49Z","updated_at":"2016-06-02T02:54:26Z","pushed_at":"2016-06-20T17:07:25Z","git_url":"git://github.com/Yelp/fullerite.git","ssh_url":"git@github.com:Yelp/fullerite.git","clone_url":"https://github.com/Yelp/fullerite.git","svn_url":"https://github.com/Yelp/fullerite","homepage":"","size":8020,"stargazers_count":129,"watchers_count":129,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":23,"forks":29,"open_issues":23,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/fullerite/pulls/272"},"html":{"href":"https://github.com/Yelp/fullerite/pull/272"},"issue":{"href":"https://api.github.com/repos/Yelp/fullerite/issues/272"},"comments":{"href":"https://api.github.com/repos/Yelp/fullerite/issues/272/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/fullerite/pulls/272/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/fullerite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/fullerite/pulls/272/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/fullerite/statuses/175a3cf8745d88a8b91edcd2e2895bed37a0d99f"}}}}
{"actor":{"display_login":"gnufied"}}