{"action":"created","comment":{"url":"https://api.github.com/repos/twitter/rpc-perf/pulls/comments/59652049","id":59652049,"diff_hunk":"@@ -0,0 +1,217 @@\n+\n+#[cfg(feature = \"unstable\")]\n+extern crate test;\n+\n+#[macro_use]\n+extern crate log;\n+extern crate pad;\n+extern crate rpcperf_cfgtypes as cfgtypes;\n+extern crate toml;\n+extern crate getopts;\n+\n+mod gen;\n+mod memcache;\n+\n+use cfgtypes::{BenchmarkConfig, BenchmarkWorkload, CResult, ParsedResponse, ProtocolGen,\n+               ProtocolParse, ProtocolParseFactory, Style, tools};\n+use getopts::Matches;\n+use pad::{PadStr, Alignment};\n+use std::collections::BTreeMap;\n+use std::str;\n+use std::sync::Arc;\n+use toml::Value;\n+use toml::Value::*;\n+\n+#[derive(Clone, Debug)]\n+enum MemcacheCommand {\n+    Get(Parameter),\n+    Gets(Parameter),\n+    Add(Parameter, Parameter),\n+    Set(Parameter, Parameter),","path":"lib/memcache/src/lib.rs","position":30,"original_position":30,"commit_id":"8426306607047467c688a723c8ea8a4669553580","original_commit_id":"8426306607047467c688a723c8ea8a4669553580","user":{"login":"brayniac","id":10478487,"avatar_url":"https://avatars.githubusercontent.com/u/10478487?v=3","gravatar_id":"","url":"https://api.github.com/users/brayniac","html_url":"https://github.com/brayniac","followers_url":"https://api.github.com/users/brayniac/followers","following_url":"https://api.github.com/users/brayniac/following{/other_user}","gists_url":"https://api.github.com/users/brayniac/gists{/gist_id}","starred_url":"https://api.github.com/users/brayniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brayniac/subscriptions","organizations_url":"https://api.github.com/users/brayniac/orgs","repos_url":"https://api.github.com/users/brayniac/repos","events_url":"https://api.github.com/users/brayniac/events{/privacy}","received_events_url":"https://api.github.com/users/brayniac/received_events","type":"User","site_admin":false},"body":"What's the plan to support setting with TTL here?","created_at":"2016-04-14T01:13:07Z","updated_at":"2016-04-14T01:13:07Z","html_url":"https://github.com/twitter/rpc-perf/pull/85#discussion_r59652049","pull_request_url":"https://api.github.com/repos/twitter/rpc-perf/pulls/85","_links":{"self":{"href":"https://api.github.com/repos/twitter/rpc-perf/pulls/comments/59652049"},"html":{"href":"https://github.com/twitter/rpc-perf/pull/85#discussion_r59652049"},"pull_request":{"href":"https://api.github.com/repos/twitter/rpc-perf/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/rpc-perf/pulls/85","id":66253985,"html_url":"https://github.com/twitter/rpc-perf/pull/85","diff_url":"https://github.com/twitter/rpc-perf/pull/85.diff","patch_url":"https://github.com/twitter/rpc-perf/pull/85.patch","issue_url":"https://api.github.com/repos/twitter/rpc-perf/issues/85","number":85,"state":"open","locked":false,"title":"WIP: modularize protocol implementations","user":{"login":"bryce-anderson","id":2948506,"avatar_url":"https://avatars.githubusercontent.com/u/2948506?v=3","gravatar_id":"","url":"https://api.github.com/users/bryce-anderson","html_url":"https://github.com/bryce-anderson","followers_url":"https://api.github.com/users/bryce-anderson/followers","following_url":"https://api.github.com/users/bryce-anderson/following{/other_user}","gists_url":"https://api.github.com/users/bryce-anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/bryce-anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryce-anderson/subscriptions","organizations_url":"https://api.github.com/users/bryce-anderson/orgs","repos_url":"https://api.github.com/users/bryce-anderson/repos","events_url":"https://api.github.com/users/bryce-anderson/events{/privacy}","received_events_url":"https://api.github.com/users/bryce-anderson/received_events","type":"User","site_admin":false},"body":"This is nowhere close to finished. I will continue to push commits and edit the title of the PR when its getting to be time for review. Right now its more or less a disaster zone.\r\n\r\ncloses #78\r\n\r\nThis PR modularizes the notion of a 'protocol'. the current way of choosing the protocol is through an `enum` and match statements. This PR moves to a `trait` based approach. The result is that the idea of a 'protocol' is now open and it only has to satisfy the requisite `trait`s. Instead of a `match` we can use dynamic dispatch.","created_at":"2016-04-13T01:34:45Z","updated_at":"2016-04-14T01:13:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"445c3aacefe4210fd2dd93af8feed17d7fbba328","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/rpc-perf/pulls/85/commits","review_comments_url":"https://api.github.com/repos/twitter/rpc-perf/pulls/85/comments","review_comment_url":"https://api.github.com/repos/twitter/rpc-perf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/rpc-perf/issues/85/comments","statuses_url":"https://api.github.com/repos/twitter/rpc-perf/statuses/8426306607047467c688a723c8ea8a4669553580","head":{"label":"bryce-anderson:wip/protocol","ref":"wip/protocol","sha":"8426306607047467c688a723c8ea8a4669553580","user":{"login":"bryce-anderson","id":2948506,"avatar_url":"https://avatars.githubusercontent.com/u/2948506?v=3","gravatar_id":"","url":"https://api.github.com/users/bryce-anderson","html_url":"https://github.com/bryce-anderson","followers_url":"https://api.github.com/users/bryce-anderson/followers","following_url":"https://api.github.com/users/bryce-anderson/following{/other_user}","gists_url":"https://api.github.com/users/bryce-anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/bryce-anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryce-anderson/subscriptions","organizations_url":"https://api.github.com/users/bryce-anderson/orgs","repos_url":"https://api.github.com/users/bryce-anderson/repos","events_url":"https://api.github.com/users/bryce-anderson/events{/privacy}","received_events_url":"https://api.github.com/users/bryce-anderson/received_events","type":"User","site_admin":false},"repo":{"id":51156515,"name":"rpc-perf","full_name":"bryce-anderson/rpc-perf","owner":{"login":"bryce-anderson","id":2948506,"avatar_url":"https://avatars.githubusercontent.com/u/2948506?v=3","gravatar_id":"","url":"https://api.github.com/users/bryce-anderson","html_url":"https://github.com/bryce-anderson","followers_url":"https://api.github.com/users/bryce-anderson/followers","following_url":"https://api.github.com/users/bryce-anderson/following{/other_user}","gists_url":"https://api.github.com/users/bryce-anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/bryce-anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryce-anderson/subscriptions","organizations_url":"https://api.github.com/users/bryce-anderson/orgs","repos_url":"https://api.github.com/users/bryce-anderson/repos","events_url":"https://api.github.com/users/bryce-anderson/events{/privacy}","received_events_url":"https://api.github.com/users/bryce-anderson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bryce-anderson/rpc-perf","description":"A tool for benchmarking RPC services","fork":true,"url":"https://api.github.com/repos/bryce-anderson/rpc-perf","forks_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/forks","keys_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/teams","hooks_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/hooks","issue_events_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/issues/events{/number}","events_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/events","assignees_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/assignees{/user}","branches_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/branches{/branch}","tags_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/tags","blobs_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/git/refs{/sha}","trees_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/statuses/{sha}","languages_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/languages","stargazers_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/stargazers","contributors_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/contributors","subscribers_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/subscribers","subscription_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/subscription","commits_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/commits{/sha}","git_commits_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/git/commits{/sha}","comments_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/comments{/number}","issue_comment_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/issues/comments{/number}","contents_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/contents/{+path}","compare_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/merges","archive_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/downloads","issues_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/issues{/number}","pulls_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/pulls{/number}","milestones_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/milestones{/number}","notifications_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/labels{/name}","releases_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/releases{/id}","deployments_url":"https://api.github.com/repos/bryce-anderson/rpc-perf/deployments","created_at":"2016-02-05T15:55:50Z","updated_at":"2016-02-05T15:55:51Z","pushed_at":"2016-04-14T01:06:17Z","git_url":"git://github.com/bryce-anderson/rpc-perf.git","ssh_url":"git@github.com:bryce-anderson/rpc-perf.git","clone_url":"https://github.com/bryce-anderson/rpc-perf.git","svn_url":"https://github.com/bryce-anderson/rpc-perf","homepage":null,"size":230,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"10a3af9ff7a6c3c73e1a884840725a387998557a","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":46767238,"name":"rpc-perf","full_name":"twitter/rpc-perf","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/rpc-perf","description":"A tool for benchmarking RPC services","fork":false,"url":"https://api.github.com/repos/twitter/rpc-perf","forks_url":"https://api.github.com/repos/twitter/rpc-perf/forks","keys_url":"https://api.github.com/repos/twitter/rpc-perf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/rpc-perf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/rpc-perf/teams","hooks_url":"https://api.github.com/repos/twitter/rpc-perf/hooks","issue_events_url":"https://api.github.com/repos/twitter/rpc-perf/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/rpc-perf/events","assignees_url":"https://api.github.com/repos/twitter/rpc-perf/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/rpc-perf/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/rpc-perf/tags","blobs_url":"https://api.github.com/repos/twitter/rpc-perf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/rpc-perf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/rpc-perf/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/rpc-perf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/rpc-perf/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/rpc-perf/languages","stargazers_url":"https://api.github.com/repos/twitter/rpc-perf/stargazers","contributors_url":"https://api.github.com/repos/twitter/rpc-perf/contributors","subscribers_url":"https://api.github.com/repos/twitter/rpc-perf/subscribers","subscription_url":"https://api.github.com/repos/twitter/rpc-perf/subscription","commits_url":"https://api.github.com/repos/twitter/rpc-perf/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/rpc-perf/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/rpc-perf/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/rpc-perf/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/rpc-perf/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/rpc-perf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/rpc-perf/merges","archive_url":"https://api.github.com/repos/twitter/rpc-perf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/rpc-perf/downloads","issues_url":"https://api.github.com/repos/twitter/rpc-perf/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/rpc-perf/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/rpc-perf/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/rpc-perf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/rpc-perf/labels{/name}","releases_url":"https://api.github.com/repos/twitter/rpc-perf/releases{/id}","deployments_url":"https://api.github.com/repos/twitter/rpc-perf/deployments","created_at":"2015-11-24T04:39:03Z","updated_at":"2016-04-12T04:15:51Z","pushed_at":"2016-04-14T01:06:18Z","git_url":"git://github.com/twitter/rpc-perf.git","ssh_url":"git@github.com:twitter/rpc-perf.git","clone_url":"https://github.com/twitter/rpc-perf.git","svn_url":"https://github.com/twitter/rpc-perf","homepage":null,"size":227,"stargazers_count":140,"watchers_count":140,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":5,"forks":8,"open_issues":5,"watchers":140,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/rpc-perf/pulls/85"},"html":{"href":"https://github.com/twitter/rpc-perf/pull/85"},"issue":{"href":"https://api.github.com/repos/twitter/rpc-perf/issues/85"},"comments":{"href":"https://api.github.com/repos/twitter/rpc-perf/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/rpc-perf/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/rpc-perf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/rpc-perf/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/rpc-perf/statuses/8426306607047467c688a723c8ea8a4669553580"}}}}