{"action":"created","comment":{"url":"https://api.github.com/repos/Financial-Times/next-stream-page/pulls/comments/57729626","id":57729626,"diff_hunk":"@@ -53,6 +53,7 @@ module.exports = (req, res, next) => {\n \n \t\tres.templateData = {\n \t\t\tstream: { items, total: items.total, name: tag.prefLabel },\n+\t\t\tpath: `/stream/${tag.taxonomy}Id/${tag.idV1}`,","path":"server/controllers/stream.js","position":4,"original_position":4,"commit_id":"c00d06349b05ce5d4b13955aa662300e16c15802","original_commit_id":"c00d06349b05ce5d4b13955aa662300e16c15802","user":{"login":"wheresrhys","id":447559,"avatar_url":"https://avatars.githubusercontent.com/u/447559?v=3","gravatar_id":"","url":"https://api.github.com/users/wheresrhys","html_url":"https://github.com/wheresrhys","followers_url":"https://api.github.com/users/wheresrhys/followers","following_url":"https://api.github.com/users/wheresrhys/following{/other_user}","gists_url":"https://api.github.com/users/wheresrhys/gists{/gist_id}","starred_url":"https://api.github.com/users/wheresrhys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wheresrhys/subscriptions","organizations_url":"https://api.github.com/users/wheresrhys/orgs","repos_url":"https://api.github.com/users/wheresrhys/repos","events_url":"https://api.github.com/users/wheresrhys/events{/privacy}","received_events_url":"https://api.github.com/users/wheresrhys/received_events","type":"User","site_admin":false},"body":"something bit more descriptive maybe? Not sure what. `internalUrl`, `streamPath`?","created_at":"2016-03-29T14:13:15Z","updated_at":"2016-03-29T14:13:15Z","html_url":"https://github.com/Financial-Times/next-stream-page/pull/974#discussion_r57729626","pull_request_url":"https://api.github.com/repos/Financial-Times/next-stream-page/pulls/974","_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/next-stream-page/pulls/comments/57729626"},"html":{"href":"https://github.com/Financial-Times/next-stream-page/pull/974#discussion_r57729626"},"pull_request":{"href":"https://api.github.com/repos/Financial-Times/next-stream-page/pulls/974"}}},"pull_request":{"url":"https://api.github.com/repos/Financial-Times/next-stream-page/pulls/974","id":64470737,"html_url":"https://github.com/Financial-Times/next-stream-page/pull/974","diff_url":"https://github.com/Financial-Times/next-stream-page/pull/974.diff","patch_url":"https://github.com/Financial-Times/next-stream-page/pull/974.patch","issue_url":"https://api.github.com/repos/Financial-Times/next-stream-page/issues/974","number":974,"state":"open","locked":false,"title":"Fix paths","user":{"login":"i-like-robots","id":271645,"avatar_url":"https://avatars.githubusercontent.com/u/271645?v=3","gravatar_id":"","url":"https://api.github.com/users/i-like-robots","html_url":"https://github.com/i-like-robots","followers_url":"https://api.github.com/users/i-like-robots/followers","following_url":"https://api.github.com/users/i-like-robots/following{/other_user}","gists_url":"https://api.github.com/users/i-like-robots/gists{/gist_id}","starred_url":"https://api.github.com/users/i-like-robots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i-like-robots/subscriptions","organizations_url":"https://api.github.com/users/i-like-robots/orgs","repos_url":"https://api.github.com/users/i-like-robots/repos","events_url":"https://api.github.com/users/i-like-robots/events{/privacy}","received_events_url":"https://api.github.com/users/i-like-robots/received_events","type":"User","site_admin":false},"body":"1. RSS link was not specified for new stream pages.\r\n2. We cannot rely on the pathname when pages have a vanity URL. Currently live streams and filters are broken as they require a non-existent `.json` vanity also. This should be considered a temporary work around while an approach is decided for dealing with this long term.","created_at":"2016-03-29T14:06:31Z","updated_at":"2016-03-29T14:13:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3abeb335fa9ba9f00338a54ead9b518b489722e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Financial-Times/next-stream-page/pulls/974/commits","review_comments_url":"https://api.github.com/repos/Financial-Times/next-stream-page/pulls/974/comments","review_comment_url":"https://api.github.com/repos/Financial-Times/next-stream-page/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Financial-Times/next-stream-page/issues/974/comments","statuses_url":"https://api.github.com/repos/Financial-Times/next-stream-page/statuses/c00d06349b05ce5d4b13955aa662300e16c15802","head":{"label":"Financial-Times:matth/fix-paths","ref":"matth/fix-paths","sha":"c00d06349b05ce5d4b13955aa662300e16c15802","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":24595604,"name":"next-stream-page","full_name":"Financial-Times/next-stream-page","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/next-stream-page","description":"Streams","fork":false,"url":"https://api.github.com/repos/Financial-Times/next-stream-page","forks_url":"https://api.github.com/repos/Financial-Times/next-stream-page/forks","keys_url":"https://api.github.com/repos/Financial-Times/next-stream-page/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/next-stream-page/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/next-stream-page/teams","hooks_url":"https://api.github.com/repos/Financial-Times/next-stream-page/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/next-stream-page/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/next-stream-page/events","assignees_url":"https://api.github.com/repos/Financial-Times/next-stream-page/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/next-stream-page/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/next-stream-page/tags","blobs_url":"https://api.github.com/repos/Financial-Times/next-stream-page/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/next-stream-page/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/next-stream-page/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/next-stream-page/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/next-stream-page/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/next-stream-page/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/next-stream-page/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/next-stream-page/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/next-stream-page/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/next-stream-page/subscription","commits_url":"https://api.github.com/repos/Financial-Times/next-stream-page/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/next-stream-page/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/next-stream-page/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/next-stream-page/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/next-stream-page/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/next-stream-page/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/next-stream-page/merges","archive_url":"https://api.github.com/repos/Financial-Times/next-stream-page/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/next-stream-page/downloads","issues_url":"https://api.github.com/repos/Financial-Times/next-stream-page/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/next-stream-page/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/next-stream-page/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/next-stream-page/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/next-stream-page/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/next-stream-page/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/next-stream-page/deployments","created_at":"2014-09-29T13:09:59Z","updated_at":"2016-01-12T12:35:16Z","pushed_at":"2016-03-29T14:06:31Z","git_url":"git://github.com/Financial-Times/next-stream-page.git","ssh_url":"git@github.com:Financial-Times/next-stream-page.git","clone_url":"https://github.com/Financial-Times/next-stream-page.git","svn_url":"https://github.com/Financial-Times/next-stream-page","homepage":"","size":6944,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":14,"forks":2,"open_issues":14,"watchers":1,"default_branch":"master"}},"base":{"label":"Financial-Times:master","ref":"master","sha":"ab8acc26bb79df69feb6b038f8a649dea631a2ce","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":24595604,"name":"next-stream-page","full_name":"Financial-Times/next-stream-page","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/next-stream-page","description":"Streams","fork":false,"url":"https://api.github.com/repos/Financial-Times/next-stream-page","forks_url":"https://api.github.com/repos/Financial-Times/next-stream-page/forks","keys_url":"https://api.github.com/repos/Financial-Times/next-stream-page/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/next-stream-page/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/next-stream-page/teams","hooks_url":"https://api.github.com/repos/Financial-Times/next-stream-page/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/next-stream-page/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/next-stream-page/events","assignees_url":"https://api.github.com/repos/Financial-Times/next-stream-page/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/next-stream-page/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/next-stream-page/tags","blobs_url":"https://api.github.com/repos/Financial-Times/next-stream-page/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/next-stream-page/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/next-stream-page/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/next-stream-page/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/next-stream-page/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/next-stream-page/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/next-stream-page/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/next-stream-page/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/next-stream-page/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/next-stream-page/subscription","commits_url":"https://api.github.com/repos/Financial-Times/next-stream-page/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/next-stream-page/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/next-stream-page/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/next-stream-page/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/next-stream-page/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/next-stream-page/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/next-stream-page/merges","archive_url":"https://api.github.com/repos/Financial-Times/next-stream-page/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/next-stream-page/downloads","issues_url":"https://api.github.com/repos/Financial-Times/next-stream-page/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/next-stream-page/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/next-stream-page/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/next-stream-page/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/next-stream-page/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/next-stream-page/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/next-stream-page/deployments","created_at":"2014-09-29T13:09:59Z","updated_at":"2016-01-12T12:35:16Z","pushed_at":"2016-03-29T14:06:31Z","git_url":"git://github.com/Financial-Times/next-stream-page.git","ssh_url":"git@github.com:Financial-Times/next-stream-page.git","clone_url":"https://github.com/Financial-Times/next-stream-page.git","svn_url":"https://github.com/Financial-Times/next-stream-page","homepage":"","size":6944,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":14,"forks":2,"open_issues":14,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/next-stream-page/pulls/974"},"html":{"href":"https://github.com/Financial-Times/next-stream-page/pull/974"},"issue":{"href":"https://api.github.com/repos/Financial-Times/next-stream-page/issues/974"},"comments":{"href":"https://api.github.com/repos/Financial-Times/next-stream-page/issues/974/comments"},"review_comments":{"href":"https://api.github.com/repos/Financial-Times/next-stream-page/pulls/974/comments"},"review_comment":{"href":"https://api.github.com/repos/Financial-Times/next-stream-page/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Financial-Times/next-stream-page/pulls/974/commits"},"statuses":{"href":"https://api.github.com/repos/Financial-Times/next-stream-page/statuses/c00d06349b05ce5d4b13955aa662300e16c15802"}}}}