{"action":"opened","number":210,"pull_request":{"url":"https://api.github.com/repos/ashleydw/lightbox/pulls/210","id":84639339,"html_url":"https://github.com/ashleydw/lightbox/pull/210","diff_url":"https://github.com/ashleydw/lightbox/pull/210.diff","patch_url":"https://github.com/ashleydw/lightbox/pull/210.patch","issue_url":"https://api.github.com/repos/ashleydw/lightbox/issues/210","number":210,"state":"open","locked":false,"title":"Identify arrows independently of user-defined classes","user":{"login":"Altreus","id":74533,"avatar_url":"https://avatars.githubusercontent.com/u/74533?v=3","gravatar_id":"","url":"https://api.github.com/users/Altreus","html_url":"https://github.com/Altreus","followers_url":"https://api.github.com/users/Altreus/followers","following_url":"https://api.github.com/users/Altreus/following{/other_user}","gists_url":"https://api.github.com/users/Altreus/gists{/gist_id}","starred_url":"https://api.github.com/users/Altreus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Altreus/subscriptions","organizations_url":"https://api.github.com/users/Altreus/orgs","repos_url":"https://api.github.com/users/Altreus/repos","events_url":"https://api.github.com/users/Altreus/events{/privacy}","received_events_url":"https://api.github.com/users/Altreus/received_events","type":"User","site_admin":false},"body":"We're using fontawesome for all of our icons, not glyphicons, so I set the left and right arrow classes accordingly:\r\n\r\n\t$.fn.ekkoLightbox.defaults.left_arrow_class = \".fa .fa-chevron-left\";\r\n\t$.fn.ekkoLightbox.defaults.right_arrow_class = \".fa .fa-chevron-right\";\r\n\r\nThe CSS, however, assumes that the arrows' classes are not changed:\r\n\r\nhttps://github.com/ashleydw/lightbox/blob/master/dist/ekko-lightbox.css#L46\r\n\r\nThis means that the right arrow is not visible because the styling is not applied. You can see me pointing at the right-arrow in the element inspector, and where Chromium is rendering it.\r\n\r\n![ekkolightbox-arrow](https://cloud.githubusercontent.com/assets/74533/18386192/3369f392-768d-11e6-9bd3-c7407093bdf7.png)\r\n\r\nI've solved this by always adding ekko-specific classes to the arrows, and referencing those from the CSS.","created_at":"2016-09-09T12:04:42Z","updated_at":"2016-09-09T12:04:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ashleydw/lightbox/pulls/210/commits","review_comments_url":"https://api.github.com/repos/ashleydw/lightbox/pulls/210/comments","review_comment_url":"https://api.github.com/repos/ashleydw/lightbox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ashleydw/lightbox/issues/210/comments","statuses_url":"https://api.github.com/repos/ashleydw/lightbox/statuses/091cbcbb460bb0824678fb66cac1a779f4e02f67","head":{"label":"Altreus:master","ref":"master","sha":"091cbcbb460bb0824678fb66cac1a779f4e02f67","user":{"login":"Altreus","id":74533,"avatar_url":"https://avatars.githubusercontent.com/u/74533?v=3","gravatar_id":"","url":"https://api.github.com/users/Altreus","html_url":"https://github.com/Altreus","followers_url":"https://api.github.com/users/Altreus/followers","following_url":"https://api.github.com/users/Altreus/following{/other_user}","gists_url":"https://api.github.com/users/Altreus/gists{/gist_id}","starred_url":"https://api.github.com/users/Altreus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Altreus/subscriptions","organizations_url":"https://api.github.com/users/Altreus/orgs","repos_url":"https://api.github.com/users/Altreus/repos","events_url":"https://api.github.com/users/Altreus/events{/privacy}","received_events_url":"https://api.github.com/users/Altreus/received_events","type":"User","site_admin":false},"repo":{"id":67795337,"name":"lightbox","full_name":"Altreus/lightbox","owner":{"login":"Altreus","id":74533,"avatar_url":"https://avatars.githubusercontent.com/u/74533?v=3","gravatar_id":"","url":"https://api.github.com/users/Altreus","html_url":"https://github.com/Altreus","followers_url":"https://api.github.com/users/Altreus/followers","following_url":"https://api.github.com/users/Altreus/following{/other_user}","gists_url":"https://api.github.com/users/Altreus/gists{/gist_id}","starred_url":"https://api.github.com/users/Altreus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Altreus/subscriptions","organizations_url":"https://api.github.com/users/Altreus/orgs","repos_url":"https://api.github.com/users/Altreus/repos","events_url":"https://api.github.com/users/Altreus/events{/privacy}","received_events_url":"https://api.github.com/users/Altreus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Altreus/lightbox","description":"A lightbox gallery plugin for Bootstrap 3 based on the modal plugin","fork":true,"url":"https://api.github.com/repos/Altreus/lightbox","forks_url":"https://api.github.com/repos/Altreus/lightbox/forks","keys_url":"https://api.github.com/repos/Altreus/lightbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Altreus/lightbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Altreus/lightbox/teams","hooks_url":"https://api.github.com/repos/Altreus/lightbox/hooks","issue_events_url":"https://api.github.com/repos/Altreus/lightbox/issues/events{/number}","events_url":"https://api.github.com/repos/Altreus/lightbox/events","assignees_url":"https://api.github.com/repos/Altreus/lightbox/assignees{/user}","branches_url":"https://api.github.com/repos/Altreus/lightbox/branches{/branch}","tags_url":"https://api.github.com/repos/Altreus/lightbox/tags","blobs_url":"https://api.github.com/repos/Altreus/lightbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Altreus/lightbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Altreus/lightbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/Altreus/lightbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Altreus/lightbox/statuses/{sha}","languages_url":"https://api.github.com/repos/Altreus/lightbox/languages","stargazers_url":"https://api.github.com/repos/Altreus/lightbox/stargazers","contributors_url":"https://api.github.com/repos/Altreus/lightbox/contributors","subscribers_url":"https://api.github.com/repos/Altreus/lightbox/subscribers","subscription_url":"https://api.github.com/repos/Altreus/lightbox/subscription","commits_url":"https://api.github.com/repos/Altreus/lightbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/Altreus/lightbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/Altreus/lightbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/Altreus/lightbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/Altreus/lightbox/contents/{+path}","compare_url":"https://api.github.com/repos/Altreus/lightbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Altreus/lightbox/merges","archive_url":"https://api.github.com/repos/Altreus/lightbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Altreus/lightbox/downloads","issues_url":"https://api.github.com/repos/Altreus/lightbox/issues{/number}","pulls_url":"https://api.github.com/repos/Altreus/lightbox/pulls{/number}","milestones_url":"https://api.github.com/repos/Altreus/lightbox/milestones{/number}","notifications_url":"https://api.github.com/repos/Altreus/lightbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Altreus/lightbox/labels{/name}","releases_url":"https://api.github.com/repos/Altreus/lightbox/releases{/id}","deployments_url":"https://api.github.com/repos/Altreus/lightbox/deployments","created_at":"2016-09-09T11:59:57Z","updated_at":"2016-09-09T11:59:59Z","pushed_at":"2016-09-09T12:03:48Z","git_url":"git://github.com/Altreus/lightbox.git","ssh_url":"git@github.com:Altreus/lightbox.git","clone_url":"https://github.com/Altreus/lightbox.git","svn_url":"https://github.com/Altreus/lightbox","homepage":"http://ashleydw.github.io/lightbox","size":683,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ashleydw:master","ref":"master","sha":"ecdb79e7392b8972cff1beb17971b865509b1713","user":{"login":"ashleydw","id":844437,"avatar_url":"https://avatars.githubusercontent.com/u/844437?v=3","gravatar_id":"","url":"https://api.github.com/users/ashleydw","html_url":"https://github.com/ashleydw","followers_url":"https://api.github.com/users/ashleydw/followers","following_url":"https://api.github.com/users/ashleydw/following{/other_user}","gists_url":"https://api.github.com/users/ashleydw/gists{/gist_id}","starred_url":"https://api.github.com/users/ashleydw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashleydw/subscriptions","organizations_url":"https://api.github.com/users/ashleydw/orgs","repos_url":"https://api.github.com/users/ashleydw/repos","events_url":"https://api.github.com/users/ashleydw/events{/privacy}","received_events_url":"https://api.github.com/users/ashleydw/received_events","type":"User","site_admin":false},"repo":{"id":12194665,"name":"lightbox","full_name":"ashleydw/lightbox","owner":{"login":"ashleydw","id":844437,"avatar_url":"https://avatars.githubusercontent.com/u/844437?v=3","gravatar_id":"","url":"https://api.github.com/users/ashleydw","html_url":"https://github.com/ashleydw","followers_url":"https://api.github.com/users/ashleydw/followers","following_url":"https://api.github.com/users/ashleydw/following{/other_user}","gists_url":"https://api.github.com/users/ashleydw/gists{/gist_id}","starred_url":"https://api.github.com/users/ashleydw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashleydw/subscriptions","organizations_url":"https://api.github.com/users/ashleydw/orgs","repos_url":"https://api.github.com/users/ashleydw/repos","events_url":"https://api.github.com/users/ashleydw/events{/privacy}","received_events_url":"https://api.github.com/users/ashleydw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashleydw/lightbox","description":"A lightbox gallery plugin for Bootstrap 3 based on the modal plugin","fork":false,"url":"https://api.github.com/repos/ashleydw/lightbox","forks_url":"https://api.github.com/repos/ashleydw/lightbox/forks","keys_url":"https://api.github.com/repos/ashleydw/lightbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashleydw/lightbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashleydw/lightbox/teams","hooks_url":"https://api.github.com/repos/ashleydw/lightbox/hooks","issue_events_url":"https://api.github.com/repos/ashleydw/lightbox/issues/events{/number}","events_url":"https://api.github.com/repos/ashleydw/lightbox/events","assignees_url":"https://api.github.com/repos/ashleydw/lightbox/assignees{/user}","branches_url":"https://api.github.com/repos/ashleydw/lightbox/branches{/branch}","tags_url":"https://api.github.com/repos/ashleydw/lightbox/tags","blobs_url":"https://api.github.com/repos/ashleydw/lightbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashleydw/lightbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashleydw/lightbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashleydw/lightbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashleydw/lightbox/statuses/{sha}","languages_url":"https://api.github.com/repos/ashleydw/lightbox/languages","stargazers_url":"https://api.github.com/repos/ashleydw/lightbox/stargazers","contributors_url":"https://api.github.com/repos/ashleydw/lightbox/contributors","subscribers_url":"https://api.github.com/repos/ashleydw/lightbox/subscribers","subscription_url":"https://api.github.com/repos/ashleydw/lightbox/subscription","commits_url":"https://api.github.com/repos/ashleydw/lightbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashleydw/lightbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashleydw/lightbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashleydw/lightbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashleydw/lightbox/contents/{+path}","compare_url":"https://api.github.com/repos/ashleydw/lightbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashleydw/lightbox/merges","archive_url":"https://api.github.com/repos/ashleydw/lightbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashleydw/lightbox/downloads","issues_url":"https://api.github.com/repos/ashleydw/lightbox/issues{/number}","pulls_url":"https://api.github.com/repos/ashleydw/lightbox/pulls{/number}","milestones_url":"https://api.github.com/repos/ashleydw/lightbox/milestones{/number}","notifications_url":"https://api.github.com/repos/ashleydw/lightbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashleydw/lightbox/labels{/name}","releases_url":"https://api.github.com/repos/ashleydw/lightbox/releases{/id}","deployments_url":"https://api.github.com/repos/ashleydw/lightbox/deployments","created_at":"2013-08-18T11:57:18Z","updated_at":"2016-09-09T10:03:21Z","pushed_at":"2016-09-09T12:04:43Z","git_url":"git://github.com/ashleydw/lightbox.git","ssh_url":"git@github.com:ashleydw/lightbox.git","clone_url":"https://github.com/ashleydw/lightbox.git","svn_url":"https://github.com/ashleydw/lightbox","homepage":"http://ashleydw.github.io/lightbox","size":683,"stargazers_count":900,"watchers_count":900,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":474,"mirror_url":null,"open_issues_count":6,"forks":474,"open_issues":6,"watchers":900,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ashleydw/lightbox/pulls/210"},"html":{"href":"https://github.com/ashleydw/lightbox/pull/210"},"issue":{"href":"https://api.github.com/repos/ashleydw/lightbox/issues/210"},"comments":{"href":"https://api.github.com/repos/ashleydw/lightbox/issues/210/comments"},"review_comments":{"href":"https://api.github.com/repos/ashleydw/lightbox/pulls/210/comments"},"review_comment":{"href":"https://api.github.com/repos/ashleydw/lightbox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ashleydw/lightbox/pulls/210/commits"},"statuses":{"href":"https://api.github.com/repos/ashleydw/lightbox/statuses/091cbcbb460bb0824678fb66cac1a779f4e02f67"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"Altreus"}}