{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-services/autopush/pulls/comments/74664956","id":74664956,"diff_hunk":"@@ -65,6 +65,39 @@ You may also want to enable human readable logs in the shared config file:\n     ; Uncomment to provide stdout logging in a more human readable format.\n     #human_logs\n \n+Configuring SSL/TLS\n+-------------------\n+\n+The Push protocol mandates use of SSL/TLS connections to ensure the integrity\n+of push subscription data. This rule can be ignored for testing purposes\n+only. This requires a valid, trusted TLS certificate (for example, from `Let's\n+Encrypt`_).\n+\n+The ``ssl_key`` and ``ssl_cert`` options configure a TLS certificate for both\n+the endpoint's HTTPS and connection node's WebSocket Secure (WSS) connections:\n+\n+.. code-block:: ini\n+\n+    ; TLS private key and certificate file paths, used for the main\n+    ; connection and endpoint listeners. If omitted, TLS will not be\n+    ; used.\n+    ssl_key = /etc/letsencrypt/live/EXAMPLE.COM/privkey.pem\n+    ssl_cert = /etc/letsencrypt/live/EXAMPLE.COM/cert.pem\n+    ; Path to file containing any additional parameters for the Ephemeral\n+    ; Diffie-Hellman\n+    #ssl_dh_param =\n+\n+The connection between the endpoint and connection nodes should not be exposed","path":"docs/running.rst","position":26,"original_position":26,"commit_id":"c236e4644abb92493e1c26a36e68b989ba5c349e","original_commit_id":"c236e4644abb92493e1c26a36e68b989ba5c349e","user":{"login":"jrconlin","id":35755,"avatar_url":"https://avatars.githubusercontent.com/u/35755?v=3","gravatar_id":"","url":"https://api.github.com/users/jrconlin","html_url":"https://github.com/jrconlin","followers_url":"https://api.github.com/users/jrconlin/followers","following_url":"https://api.github.com/users/jrconlin/following{/other_user}","gists_url":"https://api.github.com/users/jrconlin/gists{/gist_id}","starred_url":"https://api.github.com/users/jrconlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrconlin/subscriptions","organizations_url":"https://api.github.com/users/jrconlin/orgs","repos_url":"https://api.github.com/users/jrconlin/repos","events_url":"https://api.github.com/users/jrconlin/events{/privacy}","received_events_url":"https://api.github.com/users/jrconlin/received_events","type":"User","site_admin":false},"body":"\"exposed\" or \"accessible\"? Really, it should be locked to only other push server machines, but that might be more complicated than necessary.  ","created_at":"2016-08-12T21:43:16Z","updated_at":"2016-08-12T21:43:16Z","html_url":"https://github.com/mozilla-services/autopush/pull/601#discussion_r74664956","pull_request_url":"https://api.github.com/repos/mozilla-services/autopush/pulls/601","_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/autopush/pulls/comments/74664956"},"html":{"href":"https://github.com/mozilla-services/autopush/pull/601#discussion_r74664956"},"pull_request":{"href":"https://api.github.com/repos/mozilla-services/autopush/pulls/601"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-services/autopush/pulls/601","id":81186691,"html_url":"https://github.com/mozilla-services/autopush/pull/601","diff_url":"https://github.com/mozilla-services/autopush/pull/601.diff","patch_url":"https://github.com/mozilla-services/autopush/pull/601.patch","issue_url":"https://api.github.com/repos/mozilla-services/autopush/issues/601","number":601,"state":"open","locked":false,"title":"docs: describe configuration of SSL/TLS","user":{"login":"pjenvey","id":14639,"avatar_url":"https://avatars.githubusercontent.com/u/14639?v=3","gravatar_id":"","url":"https://api.github.com/users/pjenvey","html_url":"https://github.com/pjenvey","followers_url":"https://api.github.com/users/pjenvey/followers","following_url":"https://api.github.com/users/pjenvey/following{/other_user}","gists_url":"https://api.github.com/users/pjenvey/gists{/gist_id}","starred_url":"https://api.github.com/users/pjenvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjenvey/subscriptions","organizations_url":"https://api.github.com/users/pjenvey/orgs","repos_url":"https://api.github.com/users/pjenvey/repos","events_url":"https://api.github.com/users/pjenvey/events{/privacy}","received_events_url":"https://api.github.com/users/pjenvey/received_events","type":"User","site_admin":false},"body":"This is probably enough for #565, for now\r\n\r\nr? @jrconlin ","created_at":"2016-08-12T21:37:04Z","updated_at":"2016-08-12T21:43:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6996f26955a9f8f53267ada11c30d8c599f0647","assignee":{"login":"jrconlin","id":35755,"avatar_url":"https://avatars.githubusercontent.com/u/35755?v=3","gravatar_id":"","url":"https://api.github.com/users/jrconlin","html_url":"https://github.com/jrconlin","followers_url":"https://api.github.com/users/jrconlin/followers","following_url":"https://api.github.com/users/jrconlin/following{/other_user}","gists_url":"https://api.github.com/users/jrconlin/gists{/gist_id}","starred_url":"https://api.github.com/users/jrconlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrconlin/subscriptions","organizations_url":"https://api.github.com/users/jrconlin/orgs","repos_url":"https://api.github.com/users/jrconlin/repos","events_url":"https://api.github.com/users/jrconlin/events{/privacy}","received_events_url":"https://api.github.com/users/jrconlin/received_events","type":"User","site_admin":false},"assignees":[{"login":"jrconlin","id":35755,"avatar_url":"https://avatars.githubusercontent.com/u/35755?v=3","gravatar_id":"","url":"https://api.github.com/users/jrconlin","html_url":"https://github.com/jrconlin","followers_url":"https://api.github.com/users/jrconlin/followers","following_url":"https://api.github.com/users/jrconlin/following{/other_user}","gists_url":"https://api.github.com/users/jrconlin/gists{/gist_id}","starred_url":"https://api.github.com/users/jrconlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrconlin/subscriptions","organizations_url":"https://api.github.com/users/jrconlin/orgs","repos_url":"https://api.github.com/users/jrconlin/repos","events_url":"https://api.github.com/users/jrconlin/events{/privacy}","received_events_url":"https://api.github.com/users/jrconlin/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-services/autopush/pulls/601/commits","review_comments_url":"https://api.github.com/repos/mozilla-services/autopush/pulls/601/comments","review_comment_url":"https://api.github.com/repos/mozilla-services/autopush/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-services/autopush/issues/601/comments","statuses_url":"https://api.github.com/repos/mozilla-services/autopush/statuses/c236e4644abb92493e1c26a36e68b989ba5c349e","head":{"label":"mozilla-services:docs/565","ref":"docs/565","sha":"c236e4644abb92493e1c26a36e68b989ba5c349e","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":31746003,"name":"autopush","full_name":"mozilla-services/autopush","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/autopush","description":"Python Web Push Server used by Mozilla","fork":false,"url":"https://api.github.com/repos/mozilla-services/autopush","forks_url":"https://api.github.com/repos/mozilla-services/autopush/forks","keys_url":"https://api.github.com/repos/mozilla-services/autopush/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/autopush/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/autopush/teams","hooks_url":"https://api.github.com/repos/mozilla-services/autopush/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/autopush/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/autopush/events","assignees_url":"https://api.github.com/repos/mozilla-services/autopush/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/autopush/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/autopush/tags","blobs_url":"https://api.github.com/repos/mozilla-services/autopush/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/autopush/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/autopush/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/autopush/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/autopush/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/autopush/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/autopush/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/autopush/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/autopush/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/autopush/subscription","commits_url":"https://api.github.com/repos/mozilla-services/autopush/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/autopush/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/autopush/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/autopush/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/autopush/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/autopush/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/autopush/merges","archive_url":"https://api.github.com/repos/mozilla-services/autopush/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/autopush/downloads","issues_url":"https://api.github.com/repos/mozilla-services/autopush/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/autopush/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/autopush/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/autopush/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/autopush/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/autopush/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-services/autopush/deployments","created_at":"2015-03-06T01:19:24Z","updated_at":"2016-08-06T16:53:59Z","pushed_at":"2016-08-12T21:37:04Z","git_url":"git://github.com/mozilla-services/autopush.git","ssh_url":"git@github.com:mozilla-services/autopush.git","clone_url":"https://github.com/mozilla-services/autopush.git","svn_url":"https://github.com/mozilla-services/autopush","homepage":"https://autopush.readthedocs.io/","size":2254,"stargazers_count":57,"watchers_count":57,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":35,"forks":14,"open_issues":35,"watchers":57,"default_branch":"master"}},"base":{"label":"mozilla-services:master","ref":"master","sha":"4c78da48adc3f004114481b508c7f2f2fed1bef8","user":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":31746003,"name":"autopush","full_name":"mozilla-services/autopush","owner":{"login":"mozilla-services","id":1066228,"avatar_url":"https://avatars.githubusercontent.com/u/1066228?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/autopush","description":"Python Web Push Server used by Mozilla","fork":false,"url":"https://api.github.com/repos/mozilla-services/autopush","forks_url":"https://api.github.com/repos/mozilla-services/autopush/forks","keys_url":"https://api.github.com/repos/mozilla-services/autopush/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/autopush/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/autopush/teams","hooks_url":"https://api.github.com/repos/mozilla-services/autopush/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/autopush/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/autopush/events","assignees_url":"https://api.github.com/repos/mozilla-services/autopush/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/autopush/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/autopush/tags","blobs_url":"https://api.github.com/repos/mozilla-services/autopush/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/autopush/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/autopush/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/autopush/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/autopush/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/autopush/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/autopush/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/autopush/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/autopush/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/autopush/subscription","commits_url":"https://api.github.com/repos/mozilla-services/autopush/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/autopush/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/autopush/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/autopush/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/autopush/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/autopush/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/autopush/merges","archive_url":"https://api.github.com/repos/mozilla-services/autopush/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/autopush/downloads","issues_url":"https://api.github.com/repos/mozilla-services/autopush/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/autopush/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/autopush/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/autopush/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/autopush/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/autopush/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-services/autopush/deployments","created_at":"2015-03-06T01:19:24Z","updated_at":"2016-08-06T16:53:59Z","pushed_at":"2016-08-12T21:37:04Z","git_url":"git://github.com/mozilla-services/autopush.git","ssh_url":"git@github.com:mozilla-services/autopush.git","clone_url":"https://github.com/mozilla-services/autopush.git","svn_url":"https://github.com/mozilla-services/autopush","homepage":"https://autopush.readthedocs.io/","size":2254,"stargazers_count":57,"watchers_count":57,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":35,"forks":14,"open_issues":35,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/autopush/pulls/601"},"html":{"href":"https://github.com/mozilla-services/autopush/pull/601"},"issue":{"href":"https://api.github.com/repos/mozilla-services/autopush/issues/601"},"comments":{"href":"https://api.github.com/repos/mozilla-services/autopush/issues/601/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-services/autopush/pulls/601/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-services/autopush/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-services/autopush/pulls/601/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-services/autopush/statuses/c236e4644abb92493e1c26a36e68b989ba5c349e"}}}}
{"actor":{"display_login":"jrconlin"}}