{"action":"created","issue":{"url":"https://api.github.com/repos/AliSoftware/SwiftGen/issues/233","repository_url":"https://api.github.com/repos/AliSoftware/SwiftGen","labels_url":"https://api.github.com/repos/AliSoftware/SwiftGen/issues/233/labels{/name}","comments_url":"https://api.github.com/repos/AliSoftware/SwiftGen/issues/233/comments","events_url":"https://api.github.com/repos/AliSoftware/SwiftGen/issues/233/events","html_url":"https://github.com/AliSoftware/SwiftGen/pull/233","id":194111978,"number":233,"title":"Reworked camelCase logic (via snake_case)","user":{"login":"Dschee","id":6942160,"avatar_url":"https://avatars.githubusercontent.com/u/6942160?v=3","gravatar_id":"","url":"https://api.github.com/users/Dschee","html_url":"https://github.com/Dschee","followers_url":"https://api.github.com/users/Dschee/followers","following_url":"https://api.github.com/users/Dschee/following{/other_user}","gists_url":"https://api.github.com/users/Dschee/gists{/gist_id}","starred_url":"https://api.github.com/users/Dschee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dschee/subscriptions","organizations_url":"https://api.github.com/users/Dschee/orgs","repos_url":"https://api.github.com/users/Dschee/repos","events_url":"https://api.github.com/users/Dschee/events{/privacy}","received_events_url":"https://api.github.com/users/Dschee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/AliSoftware/SwiftGen/milestones/13","html_url":"https://github.com/AliSoftware/SwiftGen/milestone/13","labels_url":"https://api.github.com/repos/AliSoftware/SwiftGen/milestones/13/labels","id":2146791,"number":13,"title":"Next Major (5.0.0)","description":"Anything goes.","creator":{"login":"djbe","id":641356,"avatar_url":"https://avatars.githubusercontent.com/u/641356?v=3","gravatar_id":"","url":"https://api.github.com/users/djbe","html_url":"https://github.com/djbe","followers_url":"https://api.github.com/users/djbe/followers","following_url":"https://api.github.com/users/djbe/following{/other_user}","gists_url":"https://api.github.com/users/djbe/gists{/gist_id}","starred_url":"https://api.github.com/users/djbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djbe/subscriptions","organizations_url":"https://api.github.com/users/djbe/orgs","repos_url":"https://api.github.com/users/djbe/repos","events_url":"https://api.github.com/users/djbe/events{/privacy}","received_events_url":"https://api.github.com/users/djbe/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2016-11-20T18:33:47Z","updated_at":"2016-12-15T16:11:15Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2016-12-07T17:21:55Z","updated_at":"2016-12-21T15:26:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AliSoftware/SwiftGen/pulls/233","html_url":"https://github.com/AliSoftware/SwiftGen/pull/233","diff_url":"https://github.com/AliSoftware/SwiftGen/pull/233.diff","patch_url":"https://github.com/AliSoftware/SwiftGen/pull/233.patch"},"body":"This attempts to fix #226 by lowercasing the tails on the `lowercase` method – without breaking already camel-cased strings. Please see the full commit messages for details on the rationale.\r\n\r\nNote that strictly speaking this is a \"breaking\" change as it will change the structure of some cases, e.g. `acceptCGUScene` now becomes `acceptCguScene`. The latter was always what I was expecting from a camel-cased string though, so I think with the auto-completion help of Xcode which nowadays has automatic correction suggestions implemented for wrong cased names this should be acceptable for a minor version update and imho doesn't need to be changed long term."},"comment":{"url":"https://api.github.com/repos/AliSoftware/SwiftGen/issues/comments/268550063","html_url":"https://github.com/AliSoftware/SwiftGen/pull/233#issuecomment-268550063","issue_url":"https://api.github.com/repos/AliSoftware/SwiftGen/issues/233","id":268550063,"user":{"login":"djbe","id":641356,"avatar_url":"https://avatars.githubusercontent.com/u/641356?v=3","gravatar_id":"","url":"https://api.github.com/users/djbe","html_url":"https://github.com/djbe","followers_url":"https://api.github.com/users/djbe/followers","following_url":"https://api.github.com/users/djbe/following{/other_user}","gists_url":"https://api.github.com/users/djbe/gists{/gist_id}","starred_url":"https://api.github.com/users/djbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djbe/subscriptions","organizations_url":"https://api.github.com/users/djbe/orgs","repos_url":"https://api.github.com/users/djbe/repos","events_url":"https://api.github.com/users/djbe/events{/privacy}","received_events_url":"https://api.github.com/users/djbe/received_events","type":"User","site_admin":false},"created_at":"2016-12-21T15:26:36Z","updated_at":"2016-12-21T15:26:36Z","body":"Merged master, the tests will currently fail. We should check what we actually want as result, and work from there on how to implement it.\r\n\r\nAs it is, the tests both fail for both `titlecase` and `camelCase`, which definitely shouldn't happen.\r\nIs `titlecase` meant to be capitalised? I think it should maintain uppercase letters inside the string, such as `SomeCapString` should remain `SomeCapString`."}}
{"actor":{"display_login":"djbe"}}