{"action":"created","issue":{"url":"https://api.github.com/repos/liferay/com-liferay-journal/issues/14","repository_url":"https://api.github.com/repos/liferay/com-liferay-journal","labels_url":"https://api.github.com/repos/liferay/com-liferay-journal/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/liferay/com-liferay-journal/issues/14/comments","events_url":"https://api.github.com/repos/liferay/com-liferay-journal/issues/14/events","html_url":"https://github.com/liferay/com-liferay-journal/pull/14","id":179392446,"number":14,"title":"LPS-58672 Fix regression caused by eaeafb5ba18da8d4ee5b8278627ba7b221…","user":{"login":"shuyangzhou","id":173369,"avatar_url":"https://avatars.githubusercontent.com/u/173369?v=3","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-09-27T04:01:12Z","updated_at":"2016-10-03T14:57:15Z","closed_at":"2016-09-28T20:47:07Z","pull_request":{"url":"https://api.github.com/repos/liferay/com-liferay-journal/pulls/14","html_url":"https://github.com/liferay/com-liferay-journal/pull/14","diff_url":"https://github.com/liferay/com-liferay-journal/pull/14.diff","patch_url":"https://github.com/liferay/com-liferay-journal/pull/14.patch"},"body":"…929d77, PortalPreference has a logic unique index on ownerId and owenType, you can not add a new PortalPreferences here, because there is already an exist PortalPreferences with the same values on ownerId and owerType, this must be an update. This is causing a stable failure when you run JournalArticleSearchTest and StagingLocalizationTest in a row.\r\n\r\n@brianchandotcom this fixes the stable CI failures for StagingLocalizationTest on modules-integration-hypersonic, which was caused by eaeafb5ba18da8d4ee5b8278627ba7b221929d77 from https://github.com/brianchandotcom/liferay-portal/pull/42466\r\n\r\nCC @pavel-savinov that was your pull, and you can see modules-integration-hypersonic started failing from your pull.\r\n\r\nThe changes in eaeafb5ba18da8d4ee5b8278627ba7b221929d77 creates PortalPreferences with duplicated ownerId + ownerType, which violates the logic unique index on it. Causing the following up StagingLocalizationTest fails to update and see the correct PortalPreferences. It only happens on hypersonic, because when doing a select without order by, there suppose to have no order guarantee about the returning result set. However different DBs have their own default sorting logic, it just happens to be Hypersonic's default logic is different from other DBs, making him the only one suffering from this issue. And we should actually thank him for doing this, otherwise we would not even notice this regression.\r\n\r\nThis pull only contains the minimal required parts on journal side to make the test pass, there will be more portal side changes coming in after this is merge, to prevent future regressions like this. And to ensure different DBs can have consistent results.\r\n\r\n@juliocamarero please give this higher priority for review, as CI is failing on StagingLocalizationTest."},"comment":{"url":"https://api.github.com/repos/liferay/com-liferay-journal/issues/comments/251129311","html_url":"https://github.com/liferay/com-liferay-journal/pull/14#issuecomment-251129311","issue_url":"https://api.github.com/repos/liferay/com-liferay-journal/issues/14","id":251129311,"user":{"login":"juliocamarero","id":203395,"avatar_url":"https://avatars.githubusercontent.com/u/203395?v=3","gravatar_id":"","url":"https://api.github.com/users/juliocamarero","html_url":"https://github.com/juliocamarero","followers_url":"https://api.github.com/users/juliocamarero/followers","following_url":"https://api.github.com/users/juliocamarero/following{/other_user}","gists_url":"https://api.github.com/users/juliocamarero/gists{/gist_id}","starred_url":"https://api.github.com/users/juliocamarero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliocamarero/subscriptions","organizations_url":"https://api.github.com/users/juliocamarero/orgs","repos_url":"https://api.github.com/users/juliocamarero/repos","events_url":"https://api.github.com/users/juliocamarero/events{/privacy}","received_events_url":"https://api.github.com/users/juliocamarero/received_events","type":"User","site_admin":false},"created_at":"2016-10-03T14:57:15Z","updated_at":"2016-10-03T14:57:15Z","body":"Just started reviewing :) <br><br>:octocat: *Sent from [GH](http://nodegh.io).*"}}
{"actor":{"display_login":"juliocamarero"}}