{"action":"created","issue":{"url":"https://api.github.com/repos/owtf/owtf/issues/634","repository_url":"https://api.github.com/repos/owtf/owtf","labels_url":"https://api.github.com/repos/owtf/owtf/issues/634/labels{/name}","comments_url":"https://api.github.com/repos/owtf/owtf/issues/634/comments","events_url":"https://api.github.com/repos/owtf/owtf/issues/634/events","html_url":"https://github.com/owtf/owtf/pull/634","id":143662692,"number":634,"title":"Prevents session manager from closing without a value","user":{"login":"sachinkamath","id":9546091,"avatar_url":"https://avatars.githubusercontent.com/u/9546091?v=3","gravatar_id":"","url":"https://api.github.com/users/sachinkamath","html_url":"https://github.com/sachinkamath","followers_url":"https://api.github.com/users/sachinkamath/followers","following_url":"https://api.github.com/users/sachinkamath/following{/other_user}","gists_url":"https://api.github.com/users/sachinkamath/gists{/gist_id}","starred_url":"https://api.github.com/users/sachinkamath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachinkamath/subscriptions","organizations_url":"https://api.github.com/users/sachinkamath/orgs","repos_url":"https://api.github.com/users/sachinkamath/repos","events_url":"https://api.github.com/users/sachinkamath/events{/privacy}","received_events_url":"https://api.github.com/users/sachinkamath/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-03-26T04:36:26Z","updated_at":"2016-03-27T00:59:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owtf/owtf/pulls/634","html_url":"https://github.com/owtf/owtf/pull/634","diff_url":"https://github.com/owtf/owtf/pull/634.diff","patch_url":"https://github.com/owtf/owtf/pull/634.patch"},"body":"<!--- Provide a general, concise summary of your changes in the Title above -->\r\nThis PR prevents the `SessionModal` from closing unless a session is selected.\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nA couple of parameters were introduced into the HTML code that prevented mouse-click outside of the modal and Escape key from closing the modal\r\n## Related Issue\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- If suggesting a new feature or change, please discuss it in an issue first -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here: -->\r\nThis is a fix for Issue #608 \r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n\r\n## Reviewers\r\n<!--- @mentions of the person/people responsible for reviewing proposed changes. -->\r\n@delta24 \r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nThis was tested on IceWeasel, Firefox and Chromium and works as intended on all the three browsers. The `SessionModal` does not close unless a session is selected by the user.\r\n\r\n<!--- Before the change and after the change. -->\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] Other (<!--- mention here -->)\r\n\r\n### Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] My code follows the code style (modified PEP8) of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/owtf/owtf/issues/comments/201965000","html_url":"https://github.com/owtf/owtf/pull/634#issuecomment-201965000","issue_url":"https://api.github.com/repos/owtf/owtf/issues/634","id":201965000,"user":{"login":"sachinkamath","id":9546091,"avatar_url":"https://avatars.githubusercontent.com/u/9546091?v=3","gravatar_id":"","url":"https://api.github.com/users/sachinkamath","html_url":"https://github.com/sachinkamath","followers_url":"https://api.github.com/users/sachinkamath/followers","following_url":"https://api.github.com/users/sachinkamath/following{/other_user}","gists_url":"https://api.github.com/users/sachinkamath/gists{/gist_id}","starred_url":"https://api.github.com/users/sachinkamath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachinkamath/subscriptions","organizations_url":"https://api.github.com/users/sachinkamath/orgs","repos_url":"https://api.github.com/users/sachinkamath/repos","events_url":"https://api.github.com/users/sachinkamath/events{/privacy}","received_events_url":"https://api.github.com/users/sachinkamath/received_events","type":"User","site_admin":false},"created_at":"2016-03-27T00:59:09Z","updated_at":"2016-03-27T00:59:09Z","body":"@delta24 not allowing the modal to close when the user had not made a selection seems to be a bad idea (Please check IRC regarding this) . Instead, I'll add a function that will warn the user that a session is not selected when he exits the modal without selecting a session and enforce the same when the user tries to add target without a valid session. The best way to do this is probably by using  `/api/sessions` "}}