{"action":"created","comment":{"url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/pulls/comments/87233421","pull_request_review_id":7853469,"id":87233421,"diff_hunk":"@@ -6,19 +6,51 @@ all: jsrun\n LLVM_CONFIG ?= llvm-config\n #CFLAGS+=-O1\n #CFLAGS+=-O3 -DNDEBUG\n+#CFLAGS+=-O2\n #CXXFLAGS+=-O0 -g\n #CFLAGS+=-Werror\n+CFLAGS+=-DDUK_OPT_NO_ASSERTIONS=1\n CFLAGS+=-DDUK_OPT_UNDERSCORE_SETJMP=1\n CFLAGS+=-DDUK_OPT_FORCE_ALIGN=32\n CFLAGS+=-DDUK_OPT_DEBUG=3\n #CFLAGS+=-DDUK_OPT_DDDPRINT=1 -DDUK_OPT_DDPRINT=1 -DDUK_OPT_DPRINT=1\n \n-CC=~/sdk/bin/clang\n-CFLAGS+=-msoft-float -mabi=sandbox -cheri-linker\n+CHERI_SDK?=~/sdk\n+\n+VERSION?=x86\n+\n+.if $(VERSION) == cheri128 || $(VERSION) == cheri256\n+CC=$(CHERI_SDK)/bin/cheri-unknown-freebsd-clang\n+CFLAGS+=-msoft-float\n+CFLAGS+=-mabi=sandbox -cheri-linker","path":"Makefile","position":22,"original_position":22,"commit_id":"55d1cd9a0468169ab9f79424846702bca869c682","original_commit_id":"55d1cd9a0468169ab9f79424846702bca869c682","user":{"login":"gameboo","id":1440666,"avatar_url":"https://avatars.githubusercontent.com/u/1440666?v=3","gravatar_id":"","url":"https://api.github.com/users/gameboo","html_url":"https://github.com/gameboo","followers_url":"https://api.github.com/users/gameboo/followers","following_url":"https://api.github.com/users/gameboo/following{/other_user}","gists_url":"https://api.github.com/users/gameboo/gists{/gist_id}","starred_url":"https://api.github.com/users/gameboo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gameboo/subscriptions","organizations_url":"https://api.github.com/users/gameboo/orgs","repos_url":"https://api.github.com/users/gameboo/repos","events_url":"https://api.github.com/users/gameboo/events{/privacy}","received_events_url":"https://api.github.com/users/gameboo/received_events","type":"User","site_admin":false},"body":"well I guess we can get rid of it then","created_at":"2016-11-09T16:59:40Z","updated_at":"2016-11-09T16:59:40Z","html_url":"https://github.com/CTSRD-CHERI/jsrun/pull/1#discussion_r87233421","pull_request_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/CTSRD-CHERI/jsrun/pulls/comments/87233421"},"html":{"href":"https://github.com/CTSRD-CHERI/jsrun/pull/1#discussion_r87233421"},"pull_request":{"href":"https://api.github.com/repos/CTSRD-CHERI/jsrun/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/pulls/1","id":92949925,"html_url":"https://github.com/CTSRD-CHERI/jsrun/pull/1","diff_url":"https://github.com/CTSRD-CHERI/jsrun/pull/1.diff","patch_url":"https://github.com/CTSRD-CHERI/jsrun/pull/1.patch","issue_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/issues/1","number":1,"state":"open","locked":false,"title":"Added a CHERI_SDK variable to the Makefile for building on jenkins","user":{"login":"gameboo","id":1440666,"avatar_url":"https://avatars.githubusercontent.com/u/1440666?v=3","gravatar_id":"","url":"https://api.github.com/users/gameboo","html_url":"https://github.com/gameboo","followers_url":"https://api.github.com/users/gameboo/followers","following_url":"https://api.github.com/users/gameboo/following{/other_user}","gists_url":"https://api.github.com/users/gameboo/gists{/gist_id}","starred_url":"https://api.github.com/users/gameboo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gameboo/subscriptions","organizations_url":"https://api.github.com/users/gameboo/orgs","repos_url":"https://api.github.com/users/gameboo/repos","events_url":"https://api.github.com/users/gameboo/events{/privacy}","received_events_url":"https://api.github.com/users/gameboo/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-09T11:51:46Z","updated_at":"2016-11-09T16:59:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b4f623eb812893a5bb33aa7822696e8714565af","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/pulls/1/commits","review_comments_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/pulls/1/comments","review_comment_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/issues/1/comments","statuses_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/statuses/55d1cd9a0468169ab9f79424846702bca869c682","head":{"label":"gameboo:master","ref":"master","sha":"55d1cd9a0468169ab9f79424846702bca869c682","user":{"login":"gameboo","id":1440666,"avatar_url":"https://avatars.githubusercontent.com/u/1440666?v=3","gravatar_id":"","url":"https://api.github.com/users/gameboo","html_url":"https://github.com/gameboo","followers_url":"https://api.github.com/users/gameboo/followers","following_url":"https://api.github.com/users/gameboo/following{/other_user}","gists_url":"https://api.github.com/users/gameboo/gists{/gist_id}","starred_url":"https://api.github.com/users/gameboo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gameboo/subscriptions","organizations_url":"https://api.github.com/users/gameboo/orgs","repos_url":"https://api.github.com/users/gameboo/repos","events_url":"https://api.github.com/users/gameboo/events{/privacy}","received_events_url":"https://api.github.com/users/gameboo/received_events","type":"User","site_admin":false},"repo":{"id":73279178,"name":"jsrun","full_name":"gameboo/jsrun","owner":{"login":"gameboo","id":1440666,"avatar_url":"https://avatars.githubusercontent.com/u/1440666?v=3","gravatar_id":"","url":"https://api.github.com/users/gameboo","html_url":"https://github.com/gameboo","followers_url":"https://api.github.com/users/gameboo/followers","following_url":"https://api.github.com/users/gameboo/following{/other_user}","gists_url":"https://api.github.com/users/gameboo/gists{/gist_id}","starred_url":"https://api.github.com/users/gameboo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gameboo/subscriptions","organizations_url":"https://api.github.com/users/gameboo/orgs","repos_url":"https://api.github.com/users/gameboo/repos","events_url":"https://api.github.com/users/gameboo/events{/privacy}","received_events_url":"https://api.github.com/users/gameboo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gameboo/jsrun","description":"Experimental JavaScript interpreter for FreeBSD","fork":true,"url":"https://api.github.com/repos/gameboo/jsrun","forks_url":"https://api.github.com/repos/gameboo/jsrun/forks","keys_url":"https://api.github.com/repos/gameboo/jsrun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gameboo/jsrun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gameboo/jsrun/teams","hooks_url":"https://api.github.com/repos/gameboo/jsrun/hooks","issue_events_url":"https://api.github.com/repos/gameboo/jsrun/issues/events{/number}","events_url":"https://api.github.com/repos/gameboo/jsrun/events","assignees_url":"https://api.github.com/repos/gameboo/jsrun/assignees{/user}","branches_url":"https://api.github.com/repos/gameboo/jsrun/branches{/branch}","tags_url":"https://api.github.com/repos/gameboo/jsrun/tags","blobs_url":"https://api.github.com/repos/gameboo/jsrun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gameboo/jsrun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gameboo/jsrun/git/refs{/sha}","trees_url":"https://api.github.com/repos/gameboo/jsrun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gameboo/jsrun/statuses/{sha}","languages_url":"https://api.github.com/repos/gameboo/jsrun/languages","stargazers_url":"https://api.github.com/repos/gameboo/jsrun/stargazers","contributors_url":"https://api.github.com/repos/gameboo/jsrun/contributors","subscribers_url":"https://api.github.com/repos/gameboo/jsrun/subscribers","subscription_url":"https://api.github.com/repos/gameboo/jsrun/subscription","commits_url":"https://api.github.com/repos/gameboo/jsrun/commits{/sha}","git_commits_url":"https://api.github.com/repos/gameboo/jsrun/git/commits{/sha}","comments_url":"https://api.github.com/repos/gameboo/jsrun/comments{/number}","issue_comment_url":"https://api.github.com/repos/gameboo/jsrun/issues/comments{/number}","contents_url":"https://api.github.com/repos/gameboo/jsrun/contents/{+path}","compare_url":"https://api.github.com/repos/gameboo/jsrun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gameboo/jsrun/merges","archive_url":"https://api.github.com/repos/gameboo/jsrun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gameboo/jsrun/downloads","issues_url":"https://api.github.com/repos/gameboo/jsrun/issues{/number}","pulls_url":"https://api.github.com/repos/gameboo/jsrun/pulls{/number}","milestones_url":"https://api.github.com/repos/gameboo/jsrun/milestones{/number}","notifications_url":"https://api.github.com/repos/gameboo/jsrun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gameboo/jsrun/labels{/name}","releases_url":"https://api.github.com/repos/gameboo/jsrun/releases{/id}","deployments_url":"https://api.github.com/repos/gameboo/jsrun/deployments","created_at":"2016-11-09T11:42:21Z","updated_at":"2016-11-09T11:42:22Z","pushed_at":"2016-11-09T11:46:59Z","git_url":"git://github.com/gameboo/jsrun.git","ssh_url":"git@github.com:gameboo/jsrun.git","clone_url":"https://github.com/gameboo/jsrun.git","svn_url":"https://github.com/gameboo/jsrun","homepage":null,"size":1208,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CTSRD-CHERI:master","ref":"master","sha":"191af6073a4b768292fac454c5ad9d0d3f9dc1b5","user":{"login":"CTSRD-CHERI","id":810768,"avatar_url":"https://avatars.githubusercontent.com/u/810768?v=3","gravatar_id":"","url":"https://api.github.com/users/CTSRD-CHERI","html_url":"https://github.com/CTSRD-CHERI","followers_url":"https://api.github.com/users/CTSRD-CHERI/followers","following_url":"https://api.github.com/users/CTSRD-CHERI/following{/other_user}","gists_url":"https://api.github.com/users/CTSRD-CHERI/gists{/gist_id}","starred_url":"https://api.github.com/users/CTSRD-CHERI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CTSRD-CHERI/subscriptions","organizations_url":"https://api.github.com/users/CTSRD-CHERI/orgs","repos_url":"https://api.github.com/users/CTSRD-CHERI/repos","events_url":"https://api.github.com/users/CTSRD-CHERI/events{/privacy}","received_events_url":"https://api.github.com/users/CTSRD-CHERI/received_events","type":"Organization","site_admin":false},"repo":{"id":50349585,"name":"jsrun","full_name":"CTSRD-CHERI/jsrun","owner":{"login":"CTSRD-CHERI","id":810768,"avatar_url":"https://avatars.githubusercontent.com/u/810768?v=3","gravatar_id":"","url":"https://api.github.com/users/CTSRD-CHERI","html_url":"https://github.com/CTSRD-CHERI","followers_url":"https://api.github.com/users/CTSRD-CHERI/followers","following_url":"https://api.github.com/users/CTSRD-CHERI/following{/other_user}","gists_url":"https://api.github.com/users/CTSRD-CHERI/gists{/gist_id}","starred_url":"https://api.github.com/users/CTSRD-CHERI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CTSRD-CHERI/subscriptions","organizations_url":"https://api.github.com/users/CTSRD-CHERI/orgs","repos_url":"https://api.github.com/users/CTSRD-CHERI/repos","events_url":"https://api.github.com/users/CTSRD-CHERI/events{/privacy}","received_events_url":"https://api.github.com/users/CTSRD-CHERI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CTSRD-CHERI/jsrun","description":"Experimental JavaScript interpreter for FreeBSD","fork":true,"url":"https://api.github.com/repos/CTSRD-CHERI/jsrun","forks_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/forks","keys_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/teams","hooks_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/hooks","issue_events_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/issues/events{/number}","events_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/events","assignees_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/assignees{/user}","branches_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/branches{/branch}","tags_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/tags","blobs_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/git/refs{/sha}","trees_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/statuses/{sha}","languages_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/languages","stargazers_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/stargazers","contributors_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/contributors","subscribers_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/subscribers","subscription_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/subscription","commits_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/commits{/sha}","git_commits_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/git/commits{/sha}","comments_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/comments{/number}","issue_comment_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/issues/comments{/number}","contents_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/contents/{+path}","compare_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/merges","archive_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/downloads","issues_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/issues{/number}","pulls_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/pulls{/number}","milestones_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/milestones{/number}","notifications_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/labels{/name}","releases_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/releases{/id}","deployments_url":"https://api.github.com/repos/CTSRD-CHERI/jsrun/deployments","created_at":"2016-01-25T12:36:07Z","updated_at":"2016-01-25T12:36:08Z","pushed_at":"2016-11-09T11:51:46Z","git_url":"git://github.com/CTSRD-CHERI/jsrun.git","ssh_url":"git@github.com:CTSRD-CHERI/jsrun.git","clone_url":"https://github.com/CTSRD-CHERI/jsrun.git","svn_url":"https://github.com/CTSRD-CHERI/jsrun","homepage":null,"size":1217,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CTSRD-CHERI/jsrun/pulls/1"},"html":{"href":"https://github.com/CTSRD-CHERI/jsrun/pull/1"},"issue":{"href":"https://api.github.com/repos/CTSRD-CHERI/jsrun/issues/1"},"comments":{"href":"https://api.github.com/repos/CTSRD-CHERI/jsrun/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/CTSRD-CHERI/jsrun/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/CTSRD-CHERI/jsrun/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CTSRD-CHERI/jsrun/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/CTSRD-CHERI/jsrun/statuses/55d1cd9a0468169ab9f79424846702bca869c682"}}}}
{"actor":{"display_login":"gameboo"}}