{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/90563729","pull_request_review_id":11082766,"id":90563729,"diff_hunk":"@@ -22,13 +26,22 @@\n \n using namespace swift;\n \n+// After approx. this many elements, it's faster to use append(contentsOf:)\n+const unsigned APPEND_CONTENTSOF_REPLACEMENT_VALUES_MAX = 6;","path":"lib/SILOptimizer/Transforms/ArrayElementValuePropagation.cpp","position":18,"original_position":18,"commit_id":"6247ad699a6287dfedda6f419f6c0d93da1f7b85","original_commit_id":"6247ad699a6287dfedda6f419f6c0d93da1f7b85","user":{"login":"gottesmm","id":499423,"avatar_url":"https://avatars.githubusercontent.com/u/499423?v=3","gravatar_id":"","url":"https://api.github.com/users/gottesmm","html_url":"https://github.com/gottesmm","followers_url":"https://api.github.com/users/gottesmm/followers","following_url":"https://api.github.com/users/gottesmm/following{/other_user}","gists_url":"https://api.github.com/users/gottesmm/gists{/gist_id}","starred_url":"https://api.github.com/users/gottesmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gottesmm/subscriptions","organizations_url":"https://api.github.com/users/gottesmm/orgs","repos_url":"https://api.github.com/users/gottesmm/repos","events_url":"https://api.github.com/users/gottesmm/events{/privacy}","received_events_url":"https://api.github.com/users/gottesmm/received_events","type":"User","site_admin":false},"body":"This can be a constexpr, no?","created_at":"2016-12-01T23:57:36Z","updated_at":"2016-12-01T23:57:36Z","html_url":"https://github.com/apple/swift/pull/5978#discussion_r90563729","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/5978","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/90563729"},"html":{"href":"https://github.com/apple/swift/pull/5978#discussion_r90563729"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/5978"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/5978","id":95828316,"html_url":"https://github.com/apple/swift/pull/5978","diff_url":"https://github.com/apple/swift/pull/5978.diff","patch_url":"https://github.com/apple/swift/pull/5978.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/5978","number":5978,"state":"open","locked":false,"title":"SILOptimizer: Replace Array.append(contentsOf: with Array.append(elem…","user":{"login":"ben-ng","id":543312,"avatar_url":"https://avatars.githubusercontent.com/u/543312?v=3","gravatar_id":"","url":"https://api.github.com/users/ben-ng","html_url":"https://github.com/ben-ng","followers_url":"https://api.github.com/users/ben-ng/followers","following_url":"https://api.github.com/users/ben-ng/following{/other_user}","gists_url":"https://api.github.com/users/ben-ng/gists{/gist_id}","starred_url":"https://api.github.com/users/ben-ng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben-ng/subscriptions","organizations_url":"https://api.github.com/users/ben-ng/orgs","repos_url":"https://api.github.com/users/ben-ng/repos","events_url":"https://api.github.com/users/ben-ng/events{/privacy}","received_events_url":"https://api.github.com/users/ben-ng/received_events","type":"User","site_admin":false},"body":"<!-- What's in this pull request? -->\r\nThis makes `myArray += [42]` equivalent to `myArray.append(42)`, which results in a 6x speedup.\r\n\r\nIt does this by modifying the ArrayElementValuePropagation pass, replacing calls to `Array.append(contentsOf:` with calls to `Array.append(element:`.\r\n\r\n@slavapestov I figured that it'd be easier to discuss the problems in this diff on Github than on the mailing list.","created_at":"2016-11-30T05:03:36Z","updated_at":"2016-12-02T00:04:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81bd5416043cc12e924306a640a31ecfc3991ca4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/5978/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/5978/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/5978/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/6247ad699a6287dfedda6f419f6c0d93da1f7b85","head":{"label":"ben-ng:redundant-array-init-removal","ref":"redundant-array-init-removal","sha":"6247ad699a6287dfedda6f419f6c0d93da1f7b85","user":{"login":"ben-ng","id":543312,"avatar_url":"https://avatars.githubusercontent.com/u/543312?v=3","gravatar_id":"","url":"https://api.github.com/users/ben-ng","html_url":"https://github.com/ben-ng","followers_url":"https://api.github.com/users/ben-ng/followers","following_url":"https://api.github.com/users/ben-ng/following{/other_user}","gists_url":"https://api.github.com/users/ben-ng/gists{/gist_id}","starred_url":"https://api.github.com/users/ben-ng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben-ng/subscriptions","organizations_url":"https://api.github.com/users/ben-ng/orgs","repos_url":"https://api.github.com/users/ben-ng/repos","events_url":"https://api.github.com/users/ben-ng/events{/privacy}","received_events_url":"https://api.github.com/users/ben-ng/received_events","type":"User","site_admin":false},"repo":{"id":72596883,"name":"swift","full_name":"ben-ng/swift","owner":{"login":"ben-ng","id":543312,"avatar_url":"https://avatars.githubusercontent.com/u/543312?v=3","gravatar_id":"","url":"https://api.github.com/users/ben-ng","html_url":"https://github.com/ben-ng","followers_url":"https://api.github.com/users/ben-ng/followers","following_url":"https://api.github.com/users/ben-ng/following{/other_user}","gists_url":"https://api.github.com/users/ben-ng/gists{/gist_id}","starred_url":"https://api.github.com/users/ben-ng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben-ng/subscriptions","organizations_url":"https://api.github.com/users/ben-ng/orgs","repos_url":"https://api.github.com/users/ben-ng/repos","events_url":"https://api.github.com/users/ben-ng/events{/privacy}","received_events_url":"https://api.github.com/users/ben-ng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ben-ng/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/ben-ng/swift","forks_url":"https://api.github.com/repos/ben-ng/swift/forks","keys_url":"https://api.github.com/repos/ben-ng/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ben-ng/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ben-ng/swift/teams","hooks_url":"https://api.github.com/repos/ben-ng/swift/hooks","issue_events_url":"https://api.github.com/repos/ben-ng/swift/issues/events{/number}","events_url":"https://api.github.com/repos/ben-ng/swift/events","assignees_url":"https://api.github.com/repos/ben-ng/swift/assignees{/user}","branches_url":"https://api.github.com/repos/ben-ng/swift/branches{/branch}","tags_url":"https://api.github.com/repos/ben-ng/swift/tags","blobs_url":"https://api.github.com/repos/ben-ng/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ben-ng/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ben-ng/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/ben-ng/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ben-ng/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/ben-ng/swift/languages","stargazers_url":"https://api.github.com/repos/ben-ng/swift/stargazers","contributors_url":"https://api.github.com/repos/ben-ng/swift/contributors","subscribers_url":"https://api.github.com/repos/ben-ng/swift/subscribers","subscription_url":"https://api.github.com/repos/ben-ng/swift/subscription","commits_url":"https://api.github.com/repos/ben-ng/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/ben-ng/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/ben-ng/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/ben-ng/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/ben-ng/swift/contents/{+path}","compare_url":"https://api.github.com/repos/ben-ng/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ben-ng/swift/merges","archive_url":"https://api.github.com/repos/ben-ng/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ben-ng/swift/downloads","issues_url":"https://api.github.com/repos/ben-ng/swift/issues{/number}","pulls_url":"https://api.github.com/repos/ben-ng/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/ben-ng/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/ben-ng/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ben-ng/swift/labels{/name}","releases_url":"https://api.github.com/repos/ben-ng/swift/releases{/id}","deployments_url":"https://api.github.com/repos/ben-ng/swift/deployments","created_at":"2016-11-02T02:35:31Z","updated_at":"2016-11-02T02:35:55Z","pushed_at":"2016-12-01T22:48:16Z","git_url":"git://github.com/ben-ng/swift.git","ssh_url":"git@github.com:ben-ng/swift.git","clone_url":"https://github.com/ben-ng/swift.git","svn_url":"https://github.com/ben-ng/swift","homepage":"https://swift.org/","size":129788,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"e41a29a11cbdb9c45fdb1c515c8cb5d19ab79f6a","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-12-01T23:34:46Z","pushed_at":"2016-12-01T23:56:39Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":206233,"stargazers_count":35381,"watchers_count":35381,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5134,"mirror_url":null,"open_issues_count":131,"forks":5134,"open_issues":131,"watchers":35381,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/5978"},"html":{"href":"https://github.com/apple/swift/pull/5978"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/5978"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/5978/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/5978/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/5978/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/6247ad699a6287dfedda6f419f6c0d93da1f7b85"}}}}
{"actor":{"display_login":"gottesmm"}}