{"action":"closed","number":1724,"pull_request":{"url":"https://api.github.com/repos/xcat2/xcat-core/pulls/1724","id":81668514,"html_url":"https://github.com/xcat2/xcat-core/pull/1724","diff_url":"https://github.com/xcat2/xcat-core/pull/1724.diff","patch_url":"https://github.com/xcat2/xcat-core/pull/1724.patch","issue_url":"https://api.github.com/repos/xcat2/xcat-core/issues/1724","number":1724,"state":"closed","locked":false,"title":"Protect umount_chroot from running with rootimage_dir undefined","user":{"login":"mattaezell","id":797013,"avatar_url":"https://avatars.githubusercontent.com/u/797013?v=3","gravatar_id":"","url":"https://api.github.com/users/mattaezell","html_url":"https://github.com/mattaezell","followers_url":"https://api.github.com/users/mattaezell/followers","following_url":"https://api.github.com/users/mattaezell/following{/other_user}","gists_url":"https://api.github.com/users/mattaezell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattaezell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattaezell/subscriptions","organizations_url":"https://api.github.com/users/mattaezell/orgs","repos_url":"https://api.github.com/users/mattaezell/repos","events_url":"https://api.github.com/users/mattaezell/events{/privacy}","received_events_url":"https://api.github.com/users/mattaezell/received_events","type":"User","site_admin":false},"body":"We had an issue with our kernel version, so xCAT called xdie.  There's a typo in the RHEL 7.2 xdie, so it called umount_chroot with a blank rootimage_dir, which tried to unmount the xCAT server's /proc, /sys, and delete its device files.  Fix the typo and add some logic to umount_chroot to prevent this in the future","created_at":"2016-08-17T15:51:39Z","updated_at":"2016-09-28T06:24:24Z","closed_at":"2016-09-28T06:24:24Z","merged_at":"2016-09-28T06:24:24Z","merge_commit_sha":"d46d34f8b80ffab7261355de75b5f98aaf7a9aa7","assignee":{"login":"hu-weihua","id":7370626,"avatar_url":"https://avatars.githubusercontent.com/u/7370626?v=3","gravatar_id":"","url":"https://api.github.com/users/hu-weihua","html_url":"https://github.com/hu-weihua","followers_url":"https://api.github.com/users/hu-weihua/followers","following_url":"https://api.github.com/users/hu-weihua/following{/other_user}","gists_url":"https://api.github.com/users/hu-weihua/gists{/gist_id}","starred_url":"https://api.github.com/users/hu-weihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hu-weihua/subscriptions","organizations_url":"https://api.github.com/users/hu-weihua/orgs","repos_url":"https://api.github.com/users/hu-weihua/repos","events_url":"https://api.github.com/users/hu-weihua/events{/privacy}","received_events_url":"https://api.github.com/users/hu-weihua/received_events","type":"User","site_admin":false},"assignees":[{"login":"hu-weihua","id":7370626,"avatar_url":"https://avatars.githubusercontent.com/u/7370626?v=3","gravatar_id":"","url":"https://api.github.com/users/hu-weihua","html_url":"https://github.com/hu-weihua","followers_url":"https://api.github.com/users/hu-weihua/followers","following_url":"https://api.github.com/users/hu-weihua/following{/other_user}","gists_url":"https://api.github.com/users/hu-weihua/gists{/gist_id}","starred_url":"https://api.github.com/users/hu-weihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hu-weihua/subscriptions","organizations_url":"https://api.github.com/users/hu-weihua/orgs","repos_url":"https://api.github.com/users/hu-weihua/repos","events_url":"https://api.github.com/users/hu-weihua/events{/privacy}","received_events_url":"https://api.github.com/users/hu-weihua/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/xcat2/xcat-core/milestones/19","html_url":"https://github.com/xcat2/xcat-core/milestones/2.12.4","labels_url":"https://api.github.com/repos/xcat2/xcat-core/milestones/19/labels","id":1963591,"number":19,"title":"2.12.4","description":"","creator":{"login":"whowutwut","id":10049070,"avatar_url":"https://avatars.githubusercontent.com/u/10049070?v=3","gravatar_id":"","url":"https://api.github.com/users/whowutwut","html_url":"https://github.com/whowutwut","followers_url":"https://api.github.com/users/whowutwut/followers","following_url":"https://api.github.com/users/whowutwut/following{/other_user}","gists_url":"https://api.github.com/users/whowutwut/gists{/gist_id}","starred_url":"https://api.github.com/users/whowutwut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whowutwut/subscriptions","organizations_url":"https://api.github.com/users/whowutwut/orgs","repos_url":"https://api.github.com/users/whowutwut/repos","events_url":"https://api.github.com/users/whowutwut/events{/privacy}","received_events_url":"https://api.github.com/users/whowutwut/received_events","type":"User","site_admin":false},"open_issues":60,"closed_issues":3,"state":"open","created_at":"2016-08-25T18:08:59Z","updated_at":"2016-09-28T06:24:24Z","due_on":"2016-11-11T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/1724/commits","review_comments_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/1724/comments","review_comment_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xcat2/xcat-core/issues/1724/comments","statuses_url":"https://api.github.com/repos/xcat2/xcat-core/statuses/7225f2e5866b53300375c84b126d9a45967021b6","head":{"label":"mattaezell:xdie_rootimgdir","ref":"xdie_rootimgdir","sha":"7225f2e5866b53300375c84b126d9a45967021b6","user":{"login":"mattaezell","id":797013,"avatar_url":"https://avatars.githubusercontent.com/u/797013?v=3","gravatar_id":"","url":"https://api.github.com/users/mattaezell","html_url":"https://github.com/mattaezell","followers_url":"https://api.github.com/users/mattaezell/followers","following_url":"https://api.github.com/users/mattaezell/following{/other_user}","gists_url":"https://api.github.com/users/mattaezell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattaezell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattaezell/subscriptions","organizations_url":"https://api.github.com/users/mattaezell/orgs","repos_url":"https://api.github.com/users/mattaezell/repos","events_url":"https://api.github.com/users/mattaezell/events{/privacy}","received_events_url":"https://api.github.com/users/mattaezell/received_events","type":"User","site_admin":false},"repo":{"id":40379117,"name":"xcat-core","full_name":"mattaezell/xcat-core","owner":{"login":"mattaezell","id":797013,"avatar_url":"https://avatars.githubusercontent.com/u/797013?v=3","gravatar_id":"","url":"https://api.github.com/users/mattaezell","html_url":"https://github.com/mattaezell","followers_url":"https://api.github.com/users/mattaezell/followers","following_url":"https://api.github.com/users/mattaezell/following{/other_user}","gists_url":"https://api.github.com/users/mattaezell/gists{/gist_id}","starred_url":"https://api.github.com/users/mattaezell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattaezell/subscriptions","organizations_url":"https://api.github.com/users/mattaezell/orgs","repos_url":"https://api.github.com/users/mattaezell/repos","events_url":"https://api.github.com/users/mattaezell/events{/privacy}","received_events_url":"https://api.github.com/users/mattaezell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattaezell/xcat-core","description":"Code repo for xCAT core packages","fork":true,"url":"https://api.github.com/repos/mattaezell/xcat-core","forks_url":"https://api.github.com/repos/mattaezell/xcat-core/forks","keys_url":"https://api.github.com/repos/mattaezell/xcat-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattaezell/xcat-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattaezell/xcat-core/teams","hooks_url":"https://api.github.com/repos/mattaezell/xcat-core/hooks","issue_events_url":"https://api.github.com/repos/mattaezell/xcat-core/issues/events{/number}","events_url":"https://api.github.com/repos/mattaezell/xcat-core/events","assignees_url":"https://api.github.com/repos/mattaezell/xcat-core/assignees{/user}","branches_url":"https://api.github.com/repos/mattaezell/xcat-core/branches{/branch}","tags_url":"https://api.github.com/repos/mattaezell/xcat-core/tags","blobs_url":"https://api.github.com/repos/mattaezell/xcat-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattaezell/xcat-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattaezell/xcat-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattaezell/xcat-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattaezell/xcat-core/statuses/{sha}","languages_url":"https://api.github.com/repos/mattaezell/xcat-core/languages","stargazers_url":"https://api.github.com/repos/mattaezell/xcat-core/stargazers","contributors_url":"https://api.github.com/repos/mattaezell/xcat-core/contributors","subscribers_url":"https://api.github.com/repos/mattaezell/xcat-core/subscribers","subscription_url":"https://api.github.com/repos/mattaezell/xcat-core/subscription","commits_url":"https://api.github.com/repos/mattaezell/xcat-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattaezell/xcat-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattaezell/xcat-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattaezell/xcat-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattaezell/xcat-core/contents/{+path}","compare_url":"https://api.github.com/repos/mattaezell/xcat-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattaezell/xcat-core/merges","archive_url":"https://api.github.com/repos/mattaezell/xcat-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattaezell/xcat-core/downloads","issues_url":"https://api.github.com/repos/mattaezell/xcat-core/issues{/number}","pulls_url":"https://api.github.com/repos/mattaezell/xcat-core/pulls{/number}","milestones_url":"https://api.github.com/repos/mattaezell/xcat-core/milestones{/number}","notifications_url":"https://api.github.com/repos/mattaezell/xcat-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattaezell/xcat-core/labels{/name}","releases_url":"https://api.github.com/repos/mattaezell/xcat-core/releases{/id}","deployments_url":"https://api.github.com/repos/mattaezell/xcat-core/deployments","created_at":"2015-08-07T20:11:53Z","updated_at":"2016-01-12T14:47:49Z","pushed_at":"2016-09-26T18:21:45Z","git_url":"git://github.com/mattaezell/xcat-core.git","ssh_url":"git@github.com:mattaezell/xcat-core.git","clone_url":"https://github.com/mattaezell/xcat-core.git","svn_url":"https://github.com/mattaezell/xcat-core","homepage":null,"size":187435,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xcat2:master","ref":"master","sha":"2a4b5744683a0ce0a3f2c1f991e8959c0946f508","user":{"login":"xcat2","id":10124414,"avatar_url":"https://avatars.githubusercontent.com/u/10124414?v=3","gravatar_id":"","url":"https://api.github.com/users/xcat2","html_url":"https://github.com/xcat2","followers_url":"https://api.github.com/users/xcat2/followers","following_url":"https://api.github.com/users/xcat2/following{/other_user}","gists_url":"https://api.github.com/users/xcat2/gists{/gist_id}","starred_url":"https://api.github.com/users/xcat2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcat2/subscriptions","organizations_url":"https://api.github.com/users/xcat2/orgs","repos_url":"https://api.github.com/users/xcat2/repos","events_url":"https://api.github.com/users/xcat2/events{/privacy}","received_events_url":"https://api.github.com/users/xcat2/received_events","type":"Organization","site_admin":false},"repo":{"id":27747508,"name":"xcat-core","full_name":"xcat2/xcat-core","owner":{"login":"xcat2","id":10124414,"avatar_url":"https://avatars.githubusercontent.com/u/10124414?v=3","gravatar_id":"","url":"https://api.github.com/users/xcat2","html_url":"https://github.com/xcat2","followers_url":"https://api.github.com/users/xcat2/followers","following_url":"https://api.github.com/users/xcat2/following{/other_user}","gists_url":"https://api.github.com/users/xcat2/gists{/gist_id}","starred_url":"https://api.github.com/users/xcat2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcat2/subscriptions","organizations_url":"https://api.github.com/users/xcat2/orgs","repos_url":"https://api.github.com/users/xcat2/repos","events_url":"https://api.github.com/users/xcat2/events{/privacy}","received_events_url":"https://api.github.com/users/xcat2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xcat2/xcat-core","description":"Code repo for xCAT core packages","fork":false,"url":"https://api.github.com/repos/xcat2/xcat-core","forks_url":"https://api.github.com/repos/xcat2/xcat-core/forks","keys_url":"https://api.github.com/repos/xcat2/xcat-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xcat2/xcat-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xcat2/xcat-core/teams","hooks_url":"https://api.github.com/repos/xcat2/xcat-core/hooks","issue_events_url":"https://api.github.com/repos/xcat2/xcat-core/issues/events{/number}","events_url":"https://api.github.com/repos/xcat2/xcat-core/events","assignees_url":"https://api.github.com/repos/xcat2/xcat-core/assignees{/user}","branches_url":"https://api.github.com/repos/xcat2/xcat-core/branches{/branch}","tags_url":"https://api.github.com/repos/xcat2/xcat-core/tags","blobs_url":"https://api.github.com/repos/xcat2/xcat-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xcat2/xcat-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xcat2/xcat-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/xcat2/xcat-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xcat2/xcat-core/statuses/{sha}","languages_url":"https://api.github.com/repos/xcat2/xcat-core/languages","stargazers_url":"https://api.github.com/repos/xcat2/xcat-core/stargazers","contributors_url":"https://api.github.com/repos/xcat2/xcat-core/contributors","subscribers_url":"https://api.github.com/repos/xcat2/xcat-core/subscribers","subscription_url":"https://api.github.com/repos/xcat2/xcat-core/subscription","commits_url":"https://api.github.com/repos/xcat2/xcat-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/xcat2/xcat-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/xcat2/xcat-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/xcat2/xcat-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/xcat2/xcat-core/contents/{+path}","compare_url":"https://api.github.com/repos/xcat2/xcat-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xcat2/xcat-core/merges","archive_url":"https://api.github.com/repos/xcat2/xcat-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xcat2/xcat-core/downloads","issues_url":"https://api.github.com/repos/xcat2/xcat-core/issues{/number}","pulls_url":"https://api.github.com/repos/xcat2/xcat-core/pulls{/number}","milestones_url":"https://api.github.com/repos/xcat2/xcat-core/milestones{/number}","notifications_url":"https://api.github.com/repos/xcat2/xcat-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xcat2/xcat-core/labels{/name}","releases_url":"https://api.github.com/repos/xcat2/xcat-core/releases{/id}","deployments_url":"https://api.github.com/repos/xcat2/xcat-core/deployments","created_at":"2014-12-09T03:21:50Z","updated_at":"2016-09-23T08:20:09Z","pushed_at":"2016-09-28T06:24:24Z","git_url":"git://github.com/xcat2/xcat-core.git","ssh_url":"git@github.com:xcat2/xcat-core.git","clone_url":"https://github.com/xcat2/xcat-core.git","svn_url":"https://github.com/xcat2/xcat-core","homepage":null,"size":188207,"stargazers_count":55,"watchers_count":55,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":158,"forks":62,"open_issues":158,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/1724"},"html":{"href":"https://github.com/xcat2/xcat-core/pull/1724"},"issue":{"href":"https://api.github.com/repos/xcat2/xcat-core/issues/1724"},"comments":{"href":"https://api.github.com/repos/xcat2/xcat-core/issues/1724/comments"},"review_comments":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/1724/comments"},"review_comment":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/1724/commits"},"statuses":{"href":"https://api.github.com/repos/xcat2/xcat-core/statuses/7225f2e5866b53300375c84b126d9a45967021b6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hu-weihua","id":7370626,"avatar_url":"https://avatars.githubusercontent.com/u/7370626?v=3","gravatar_id":"","url":"https://api.github.com/users/hu-weihua","html_url":"https://github.com/hu-weihua","followers_url":"https://api.github.com/users/hu-weihua/followers","following_url":"https://api.github.com/users/hu-weihua/following{/other_user}","gists_url":"https://api.github.com/users/hu-weihua/gists{/gist_id}","starred_url":"https://api.github.com/users/hu-weihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hu-weihua/subscriptions","organizations_url":"https://api.github.com/users/hu-weihua/orgs","repos_url":"https://api.github.com/users/hu-weihua/repos","events_url":"https://api.github.com/users/hu-weihua/events{/privacy}","received_events_url":"https://api.github.com/users/hu-weihua/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":10,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"hu-weihua"}}