{"action":"closed","number":1055,"pull_request":{"url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1055","id":96002802,"html_url":"https://github.com/os-autoinst/openQA/pull/1055","diff_url":"https://github.com/os-autoinst/openQA/pull/1055.diff","patch_url":"https://github.com/os-autoinst/openQA/pull/1055.patch","issue_url":"https://api.github.com/repos/os-autoinst/openQA/issues/1055","number":1055,"state":"closed","locked":false,"title":"Fix various issues with fedmsg comment events","user":{"login":"AdamWill","id":916551,"avatar_url":"https://avatars.githubusercontent.com/u/916551?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamWill","html_url":"https://github.com/AdamWill","followers_url":"https://api.github.com/users/AdamWill/followers","following_url":"https://api.github.com/users/AdamWill/following{/other_user}","gists_url":"https://api.github.com/users/AdamWill/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamWill/subscriptions","organizations_url":"https://api.github.com/users/AdamWill/orgs","repos_url":"https://api.github.com/users/AdamWill/repos","events_url":"https://api.github.com/users/AdamWill/events{/privacy}","received_events_url":"https://api.github.com/users/AdamWill/received_events","type":"User","site_admin":false},"body":"Now I got around to checking on the comment events that were\r\nadded to the Fedmsg plugin, there are several problems. This\r\nshould fix most of them.\r\n\r\nThe modname for the comment events was entirely wrong, because\r\nthe modifications done for job events weren't being done for\r\ncomment events, so we got a modname with the useless 'openqa'\r\non the front and still with underscore separators instead of\r\ndots. As a bonus, we now replace *all* underscores with dots,\r\nnot just the first (so `job_update_result` was actually also\r\nbroken before, I just didn't notice because we never much used\r\nit).\r\n\r\nWe would never actually emit a message for comment deletion,\r\nbecause `on_comment_event` tries to find the comment and bails\r\nif it can't; obviously it won't find a comment that was just\r\ndeleted. For now, just send out a very bare message in this\r\ncase that includes only the comment ID; we could make this\r\nbetter, I think, but it would make more sense as a separate\r\ncommit.\r\n\r\n`on_comment_event` also lied about what its args were. The\r\nfirst arg is the user ID, not the comment ID.\r\n\r\nNo tests were included in the initial commit. If it had had any,\r\nthese errors would've been much more obvious. I wrote some.","created_at":"2016-12-01T00:27:41Z","updated_at":"2016-12-01T12:15:02Z","closed_at":"2016-12-01T12:15:01Z","merged_at":"2016-12-01T12:15:01Z","merge_commit_sha":"b3e4a0cae654be8191ab8283416df1358ef4191f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1055/commits","review_comments_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1055/comments","review_comment_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/os-autoinst/openQA/issues/1055/comments","statuses_url":"https://api.github.com/repos/os-autoinst/openQA/statuses/6f501450e300312b4fadfec969d2d052e9b09a4b","head":{"label":"AdamWill:fedmsg-comment-fix","ref":"fedmsg-comment-fix","sha":"6f501450e300312b4fadfec969d2d052e9b09a4b","user":{"login":"AdamWill","id":916551,"avatar_url":"https://avatars.githubusercontent.com/u/916551?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamWill","html_url":"https://github.com/AdamWill","followers_url":"https://api.github.com/users/AdamWill/followers","following_url":"https://api.github.com/users/AdamWill/following{/other_user}","gists_url":"https://api.github.com/users/AdamWill/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamWill/subscriptions","organizations_url":"https://api.github.com/users/AdamWill/orgs","repos_url":"https://api.github.com/users/AdamWill/repos","events_url":"https://api.github.com/users/AdamWill/events{/privacy}","received_events_url":"https://api.github.com/users/AdamWill/received_events","type":"User","site_admin":false},"repo":{"id":31450875,"name":"openQA","full_name":"AdamWill/openQA","owner":{"login":"AdamWill","id":916551,"avatar_url":"https://avatars.githubusercontent.com/u/916551?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamWill","html_url":"https://github.com/AdamWill","followers_url":"https://api.github.com/users/AdamWill/followers","following_url":"https://api.github.com/users/AdamWill/following{/other_user}","gists_url":"https://api.github.com/users/AdamWill/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamWill/subscriptions","organizations_url":"https://api.github.com/users/AdamWill/orgs","repos_url":"https://api.github.com/users/AdamWill/repos","events_url":"https://api.github.com/users/AdamWill/events{/privacy}","received_events_url":"https://api.github.com/users/AdamWill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AdamWill/openQA","description":"openQA web-frontend, scheduler and tools","fork":true,"url":"https://api.github.com/repos/AdamWill/openQA","forks_url":"https://api.github.com/repos/AdamWill/openQA/forks","keys_url":"https://api.github.com/repos/AdamWill/openQA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AdamWill/openQA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AdamWill/openQA/teams","hooks_url":"https://api.github.com/repos/AdamWill/openQA/hooks","issue_events_url":"https://api.github.com/repos/AdamWill/openQA/issues/events{/number}","events_url":"https://api.github.com/repos/AdamWill/openQA/events","assignees_url":"https://api.github.com/repos/AdamWill/openQA/assignees{/user}","branches_url":"https://api.github.com/repos/AdamWill/openQA/branches{/branch}","tags_url":"https://api.github.com/repos/AdamWill/openQA/tags","blobs_url":"https://api.github.com/repos/AdamWill/openQA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AdamWill/openQA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AdamWill/openQA/git/refs{/sha}","trees_url":"https://api.github.com/repos/AdamWill/openQA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AdamWill/openQA/statuses/{sha}","languages_url":"https://api.github.com/repos/AdamWill/openQA/languages","stargazers_url":"https://api.github.com/repos/AdamWill/openQA/stargazers","contributors_url":"https://api.github.com/repos/AdamWill/openQA/contributors","subscribers_url":"https://api.github.com/repos/AdamWill/openQA/subscribers","subscription_url":"https://api.github.com/repos/AdamWill/openQA/subscription","commits_url":"https://api.github.com/repos/AdamWill/openQA/commits{/sha}","git_commits_url":"https://api.github.com/repos/AdamWill/openQA/git/commits{/sha}","comments_url":"https://api.github.com/repos/AdamWill/openQA/comments{/number}","issue_comment_url":"https://api.github.com/repos/AdamWill/openQA/issues/comments{/number}","contents_url":"https://api.github.com/repos/AdamWill/openQA/contents/{+path}","compare_url":"https://api.github.com/repos/AdamWill/openQA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AdamWill/openQA/merges","archive_url":"https://api.github.com/repos/AdamWill/openQA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AdamWill/openQA/downloads","issues_url":"https://api.github.com/repos/AdamWill/openQA/issues{/number}","pulls_url":"https://api.github.com/repos/AdamWill/openQA/pulls{/number}","milestones_url":"https://api.github.com/repos/AdamWill/openQA/milestones{/number}","notifications_url":"https://api.github.com/repos/AdamWill/openQA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AdamWill/openQA/labels{/name}","releases_url":"https://api.github.com/repos/AdamWill/openQA/releases{/id}","deployments_url":"https://api.github.com/repos/AdamWill/openQA/deployments","created_at":"2015-02-28T04:25:25Z","updated_at":"2016-06-27T23:27:30Z","pushed_at":"2016-12-01T00:26:14Z","git_url":"git://github.com/AdamWill/openQA.git","ssh_url":"git@github.com:AdamWill/openQA.git","clone_url":"https://github.com/AdamWill/openQA.git","svn_url":"https://github.com/AdamWill/openQA","homepage":"http://openqa.opensuse.org/","size":16047,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"os-autoinst:master","ref":"master","sha":"3f62038654b1767e3cf1f3da5ec9617552978e92","user":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars.githubusercontent.com/u/6918706?v=3","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"repo":{"id":20883829,"name":"openQA","full_name":"os-autoinst/openQA","owner":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars.githubusercontent.com/u/6918706?v=3","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/os-autoinst/openQA","description":"openQA web-frontend, scheduler and tools","fork":false,"url":"https://api.github.com/repos/os-autoinst/openQA","forks_url":"https://api.github.com/repos/os-autoinst/openQA/forks","keys_url":"https://api.github.com/repos/os-autoinst/openQA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/os-autoinst/openQA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/os-autoinst/openQA/teams","hooks_url":"https://api.github.com/repos/os-autoinst/openQA/hooks","issue_events_url":"https://api.github.com/repos/os-autoinst/openQA/issues/events{/number}","events_url":"https://api.github.com/repos/os-autoinst/openQA/events","assignees_url":"https://api.github.com/repos/os-autoinst/openQA/assignees{/user}","branches_url":"https://api.github.com/repos/os-autoinst/openQA/branches{/branch}","tags_url":"https://api.github.com/repos/os-autoinst/openQA/tags","blobs_url":"https://api.github.com/repos/os-autoinst/openQA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/os-autoinst/openQA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/os-autoinst/openQA/git/refs{/sha}","trees_url":"https://api.github.com/repos/os-autoinst/openQA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/os-autoinst/openQA/statuses/{sha}","languages_url":"https://api.github.com/repos/os-autoinst/openQA/languages","stargazers_url":"https://api.github.com/repos/os-autoinst/openQA/stargazers","contributors_url":"https://api.github.com/repos/os-autoinst/openQA/contributors","subscribers_url":"https://api.github.com/repos/os-autoinst/openQA/subscribers","subscription_url":"https://api.github.com/repos/os-autoinst/openQA/subscription","commits_url":"https://api.github.com/repos/os-autoinst/openQA/commits{/sha}","git_commits_url":"https://api.github.com/repos/os-autoinst/openQA/git/commits{/sha}","comments_url":"https://api.github.com/repos/os-autoinst/openQA/comments{/number}","issue_comment_url":"https://api.github.com/repos/os-autoinst/openQA/issues/comments{/number}","contents_url":"https://api.github.com/repos/os-autoinst/openQA/contents/{+path}","compare_url":"https://api.github.com/repos/os-autoinst/openQA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/os-autoinst/openQA/merges","archive_url":"https://api.github.com/repos/os-autoinst/openQA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/os-autoinst/openQA/downloads","issues_url":"https://api.github.com/repos/os-autoinst/openQA/issues{/number}","pulls_url":"https://api.github.com/repos/os-autoinst/openQA/pulls{/number}","milestones_url":"https://api.github.com/repos/os-autoinst/openQA/milestones{/number}","notifications_url":"https://api.github.com/repos/os-autoinst/openQA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/os-autoinst/openQA/labels{/name}","releases_url":"https://api.github.com/repos/os-autoinst/openQA/releases{/id}","deployments_url":"https://api.github.com/repos/os-autoinst/openQA/deployments","created_at":"2014-06-16T12:23:22Z","updated_at":"2016-11-21T15:58:06Z","pushed_at":"2016-12-01T12:15:01Z","git_url":"git://github.com/os-autoinst/openQA.git","ssh_url":"git@github.com:os-autoinst/openQA.git","clone_url":"https://github.com/os-autoinst/openQA.git","svn_url":"https://github.com/os-autoinst/openQA","homepage":"http://openqa.opensuse.org/","size":17531,"stargazers_count":72,"watchers_count":72,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":58,"mirror_url":null,"open_issues_count":26,"forks":58,"open_issues":26,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1055"},"html":{"href":"https://github.com/os-autoinst/openQA/pull/1055"},"issue":{"href":"https://api.github.com/repos/os-autoinst/openQA/issues/1055"},"comments":{"href":"https://api.github.com/repos/os-autoinst/openQA/issues/1055/comments"},"review_comments":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1055/comments"},"review_comment":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1055/commits"},"statuses":{"href":"https://api.github.com/repos/os-autoinst/openQA/statuses/6f501450e300312b4fadfec969d2d052e9b09a4b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"coolo","id":1067203,"avatar_url":"https://avatars.githubusercontent.com/u/1067203?v=3","gravatar_id":"","url":"https://api.github.com/users/coolo","html_url":"https://github.com/coolo","followers_url":"https://api.github.com/users/coolo/followers","following_url":"https://api.github.com/users/coolo/following{/other_user}","gists_url":"https://api.github.com/users/coolo/gists{/gist_id}","starred_url":"https://api.github.com/users/coolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coolo/subscriptions","organizations_url":"https://api.github.com/users/coolo/orgs","repos_url":"https://api.github.com/users/coolo/repos","events_url":"https://api.github.com/users/coolo/events{/privacy}","received_events_url":"https://api.github.com/users/coolo/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":1,"additions":76,"deletions":14,"changed_files":2}}
{"actor":{"display_login":"coolo"}}