{"action":"closed","number":165,"pull_request":{"url":"https://api.github.com/repos/JuliaOpt/Optim.jl/pulls/165","id":57845002,"html_url":"https://github.com/JuliaOpt/Optim.jl/pull/165","diff_url":"https://github.com/JuliaOpt/Optim.jl/pull/165.diff","patch_url":"https://github.com/JuliaOpt/Optim.jl/pull/165.patch","issue_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/issues/165","number":165,"state":"closed","locked":false,"title":"Getting the API train running","user":{"login":"pkofod","id":8431156,"avatar_url":"https://avatars.githubusercontent.com/u/8431156?v=3","gravatar_id":"","url":"https://api.github.com/users/pkofod","html_url":"https://github.com/pkofod","followers_url":"https://api.github.com/users/pkofod/followers","following_url":"https://api.github.com/users/pkofod/following{/other_user}","gists_url":"https://api.github.com/users/pkofod/gists{/gist_id}","starred_url":"https://api.github.com/users/pkofod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkofod/subscriptions","organizations_url":"https://api.github.com/users/pkofod/orgs","repos_url":"https://api.github.com/users/pkofod/repos","events_url":"https://api.github.com/users/pkofod/events{/privacy}","received_events_url":"https://api.github.com/users/pkofod/received_events","type":"User","site_admin":false},"body":"So I figured that these changes / additions were way over due, and starting a PR would be a good motivational factor.\r\n\r\nMost of it is based of off @johnmyleswhite 's branch.\r\n\r\n- Renamed `it` to `iterations`\r\n- Added `iteration_converged` to UnivariateOptimizationResults\r\n- Added API methods for accessing fields of OptimizationResults\r\n\r\nI have a small though, and you may not agree with it. Is there a reason why we define the \"exceeded iterations\" convergence criterion opposite of the others, such that \"false\" is good and \"true\" is bad? \r\n\r\nPlease add comments or ideas about improvements to the API. \r\n\r\nFixes #76 \r\n\r\n**Update**\r\nSince #149 was merged, it's probably worth it to continue with this. Please comment and discuss. ","created_at":"2016-02-01T14:19:15Z","updated_at":"2016-03-25T11:42:07Z","closed_at":"2016-03-25T11:42:07Z","merged_at":"2016-03-25T11:42:07Z","merge_commit_sha":"94b18f07b7534b1c94f4aa8a1c5a0cc84268d13b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/pulls/165/commits","review_comments_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/pulls/165/comments","review_comment_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/issues/165/comments","statuses_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/statuses/87c07b7c6028da101d8f59685ccd62bbb97e4a94","head":{"label":"pkofod:master","ref":"master","sha":"87c07b7c6028da101d8f59685ccd62bbb97e4a94","user":{"login":"pkofod","id":8431156,"avatar_url":"https://avatars.githubusercontent.com/u/8431156?v=3","gravatar_id":"","url":"https://api.github.com/users/pkofod","html_url":"https://github.com/pkofod","followers_url":"https://api.github.com/users/pkofod/followers","following_url":"https://api.github.com/users/pkofod/following{/other_user}","gists_url":"https://api.github.com/users/pkofod/gists{/gist_id}","starred_url":"https://api.github.com/users/pkofod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkofod/subscriptions","organizations_url":"https://api.github.com/users/pkofod/orgs","repos_url":"https://api.github.com/users/pkofod/repos","events_url":"https://api.github.com/users/pkofod/events{/privacy}","received_events_url":"https://api.github.com/users/pkofod/received_events","type":"User","site_admin":false},"repo":{"id":50837247,"name":"Optim.jl","full_name":"pkofod/Optim.jl","owner":{"login":"pkofod","id":8431156,"avatar_url":"https://avatars.githubusercontent.com/u/8431156?v=3","gravatar_id":"","url":"https://api.github.com/users/pkofod","html_url":"https://github.com/pkofod","followers_url":"https://api.github.com/users/pkofod/followers","following_url":"https://api.github.com/users/pkofod/following{/other_user}","gists_url":"https://api.github.com/users/pkofod/gists{/gist_id}","starred_url":"https://api.github.com/users/pkofod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkofod/subscriptions","organizations_url":"https://api.github.com/users/pkofod/orgs","repos_url":"https://api.github.com/users/pkofod/repos","events_url":"https://api.github.com/users/pkofod/events{/privacy}","received_events_url":"https://api.github.com/users/pkofod/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pkofod/Optim.jl","description":"Optimization functions for Julia","fork":true,"url":"https://api.github.com/repos/pkofod/Optim.jl","forks_url":"https://api.github.com/repos/pkofod/Optim.jl/forks","keys_url":"https://api.github.com/repos/pkofod/Optim.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkofod/Optim.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkofod/Optim.jl/teams","hooks_url":"https://api.github.com/repos/pkofod/Optim.jl/hooks","issue_events_url":"https://api.github.com/repos/pkofod/Optim.jl/issues/events{/number}","events_url":"https://api.github.com/repos/pkofod/Optim.jl/events","assignees_url":"https://api.github.com/repos/pkofod/Optim.jl/assignees{/user}","branches_url":"https://api.github.com/repos/pkofod/Optim.jl/branches{/branch}","tags_url":"https://api.github.com/repos/pkofod/Optim.jl/tags","blobs_url":"https://api.github.com/repos/pkofod/Optim.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkofod/Optim.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkofod/Optim.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkofod/Optim.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkofod/Optim.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/pkofod/Optim.jl/languages","stargazers_url":"https://api.github.com/repos/pkofod/Optim.jl/stargazers","contributors_url":"https://api.github.com/repos/pkofod/Optim.jl/contributors","subscribers_url":"https://api.github.com/repos/pkofod/Optim.jl/subscribers","subscription_url":"https://api.github.com/repos/pkofod/Optim.jl/subscription","commits_url":"https://api.github.com/repos/pkofod/Optim.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkofod/Optim.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkofod/Optim.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkofod/Optim.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkofod/Optim.jl/contents/{+path}","compare_url":"https://api.github.com/repos/pkofod/Optim.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkofod/Optim.jl/merges","archive_url":"https://api.github.com/repos/pkofod/Optim.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkofod/Optim.jl/downloads","issues_url":"https://api.github.com/repos/pkofod/Optim.jl/issues{/number}","pulls_url":"https://api.github.com/repos/pkofod/Optim.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/pkofod/Optim.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/pkofod/Optim.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkofod/Optim.jl/labels{/name}","releases_url":"https://api.github.com/repos/pkofod/Optim.jl/releases{/id}","deployments_url":"https://api.github.com/repos/pkofod/Optim.jl/deployments","created_at":"2016-02-01T12:14:38Z","updated_at":"2016-02-01T12:14:39Z","pushed_at":"2016-03-25T10:27:59Z","git_url":"git://github.com/pkofod/Optim.jl.git","ssh_url":"git@github.com:pkofod/Optim.jl.git","clone_url":"https://github.com/pkofod/Optim.jl.git","svn_url":"https://github.com/pkofod/Optim.jl","homepage":"","size":618,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaOpt:master","ref":"master","sha":"1c8cf200dcd49c43888cdd67dc4ccd30dc1f3f4d","user":{"login":"JuliaOpt","id":5667382,"avatar_url":"https://avatars.githubusercontent.com/u/5667382?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaOpt","html_url":"https://github.com/JuliaOpt","followers_url":"https://api.github.com/users/JuliaOpt/followers","following_url":"https://api.github.com/users/JuliaOpt/following{/other_user}","gists_url":"https://api.github.com/users/JuliaOpt/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaOpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaOpt/subscriptions","organizations_url":"https://api.github.com/users/JuliaOpt/orgs","repos_url":"https://api.github.com/users/JuliaOpt/repos","events_url":"https://api.github.com/users/JuliaOpt/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaOpt/received_events","type":"Organization","site_admin":false},"repo":{"id":3933868,"name":"Optim.jl","full_name":"JuliaOpt/Optim.jl","owner":{"login":"JuliaOpt","id":5667382,"avatar_url":"https://avatars.githubusercontent.com/u/5667382?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaOpt","html_url":"https://github.com/JuliaOpt","followers_url":"https://api.github.com/users/JuliaOpt/followers","following_url":"https://api.github.com/users/JuliaOpt/following{/other_user}","gists_url":"https://api.github.com/users/JuliaOpt/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaOpt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaOpt/subscriptions","organizations_url":"https://api.github.com/users/JuliaOpt/orgs","repos_url":"https://api.github.com/users/JuliaOpt/repos","events_url":"https://api.github.com/users/JuliaOpt/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaOpt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaOpt/Optim.jl","description":"Optimization functions for Julia","fork":false,"url":"https://api.github.com/repos/JuliaOpt/Optim.jl","forks_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/forks","keys_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/teams","hooks_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/events","assignees_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/tags","blobs_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/subscription","commits_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/merges","archive_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/downloads","issues_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaOpt/Optim.jl/deployments","created_at":"2012-04-04T22:19:35Z","updated_at":"2016-03-20T13:19:48Z","pushed_at":"2016-03-25T11:42:07Z","git_url":"git://github.com/JuliaOpt/Optim.jl.git","ssh_url":"git@github.com:JuliaOpt/Optim.jl.git","clone_url":"https://github.com/JuliaOpt/Optim.jl.git","svn_url":"https://github.com/JuliaOpt/Optim.jl","homepage":"","size":717,"stargazers_count":162,"watchers_count":162,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":24,"forks":57,"open_issues":24,"watchers":162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaOpt/Optim.jl/pulls/165"},"html":{"href":"https://github.com/JuliaOpt/Optim.jl/pull/165"},"issue":{"href":"https://api.github.com/repos/JuliaOpt/Optim.jl/issues/165"},"comments":{"href":"https://api.github.com/repos/JuliaOpt/Optim.jl/issues/165/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaOpt/Optim.jl/pulls/165/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaOpt/Optim.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaOpt/Optim.jl/pulls/165/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaOpt/Optim.jl/statuses/87c07b7c6028da101d8f59685ccd62bbb97e4a94"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pkofod","id":8431156,"avatar_url":"https://avatars.githubusercontent.com/u/8431156?v=3","gravatar_id":"","url":"https://api.github.com/users/pkofod","html_url":"https://github.com/pkofod","followers_url":"https://api.github.com/users/pkofod/followers","following_url":"https://api.github.com/users/pkofod/following{/other_user}","gists_url":"https://api.github.com/users/pkofod/gists{/gist_id}","starred_url":"https://api.github.com/users/pkofod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkofod/subscriptions","organizations_url":"https://api.github.com/users/pkofod/orgs","repos_url":"https://api.github.com/users/pkofod/repos","events_url":"https://api.github.com/users/pkofod/events{/privacy}","received_events_url":"https://api.github.com/users/pkofod/received_events","type":"User","site_admin":false},"comments":27,"review_comments":9,"commits":3,"additions":285,"deletions":107,"changed_files":22}}