{"action":"created","comment":{"url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/72925247","id":72925247,"diff_hunk":"@@ -646,7 +646,7 @@ turf/simulated/floor/update_icon()\n \tif((icon_state != \"cult\")&&(icon_state != \"cult-narsie\"))\n \t\tname = \"engraved floor\"\n \t\ticon_state = \"cult\"\n-\t\tturf_animation('icons/effects/effects.dmi',\"cultfloor\",0,0,MOB_LAYER-1,anim_plane = PLANE_OBJ)\n+\t\tturf_animation('icons/effects/effects.dmi',\"cultfloor\",0,0,MOB_LAYER-1,anim_plane = OBJ_PLANE)\n \treturn","path":"code/game/turfs/simulated/floor.dm","position":6,"original_position":6,"commit_id":"d8db8170e1b7680be8e91088caa9648169953843","original_commit_id":"d8db8170e1b7680be8e91088caa9648169953843","user":{"login":"DrCelt","id":7193289,"avatar_url":"https://avatars.githubusercontent.com/u/7193289?v=3","gravatar_id":"","url":"https://api.github.com/users/DrCelt","html_url":"https://github.com/DrCelt","followers_url":"https://api.github.com/users/DrCelt/followers","following_url":"https://api.github.com/users/DrCelt/following{/other_user}","gists_url":"https://api.github.com/users/DrCelt/gists{/gist_id}","starred_url":"https://api.github.com/users/DrCelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrCelt/subscriptions","organizations_url":"https://api.github.com/users/DrCelt/orgs","repos_url":"https://api.github.com/users/DrCelt/repos","events_url":"https://api.github.com/users/DrCelt/events{/privacy}","received_events_url":"https://api.github.com/users/DrCelt/received_events","type":"User","site_admin":false},"body":"Trailing return, remove.","created_at":"2016-08-01T05:22:56Z","updated_at":"2016-08-01T05:22:56Z","html_url":"https://github.com/d3athrow/vgstation13/pull/11183#discussion_r72925247","pull_request_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/11183","_links":{"self":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments/72925247"},"html":{"href":"https://github.com/d3athrow/vgstation13/pull/11183#discussion_r72925247"},"pull_request":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/11183"}}},"pull_request":{"url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/11183","id":79304162,"html_url":"https://github.com/d3athrow/vgstation13/pull/11183","diff_url":"https://github.com/d3athrow/vgstation13/pull/11183.diff","patch_url":"https://github.com/d3athrow/vgstation13/pull/11183.patch","issue_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/11183","number":11183,"state":"open","locked":false,"title":"NO MORE HALF MEASURES, CLUSTER","user":{"login":"DrCelt","id":7193289,"avatar_url":"https://avatars.githubusercontent.com/u/7193289?v=3","gravatar_id":"","url":"https://api.github.com/users/DrCelt","html_url":"https://github.com/DrCelt","followers_url":"https://api.github.com/users/DrCelt/followers","following_url":"https://api.github.com/users/DrCelt/following{/other_user}","gists_url":"https://api.github.com/users/DrCelt/gists{/gist_id}","starred_url":"https://api.github.com/users/DrCelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrCelt/subscriptions","organizations_url":"https://api.github.com/users/DrCelt/orgs","repos_url":"https://api.github.com/users/DrCelt/repos","events_url":"https://api.github.com/users/DrCelt/events{/privacy}","received_events_url":"https://api.github.com/users/DrCelt/received_events","type":"User","site_admin":false},"body":"this is my largest PR to date in terms of files changed, and sum of lines changed.\r\n\r\nI hate all of you.\r\nThis has not been tested,\r\nThis will most likely conflict.\r\nI'll work on that later\r\nI'm using tethered mobile data to push this, as I don't have access to wifi.\r\nwhy did I agree to do planes\r\n\r\nADDS: \r\n- layers are now defines (this is a big deal)\r\n- added some documentation to _planes+layers to help people I guess\r\n\r\nTESTING THE FIX FOR:\r\n(not having an X doesn't mean I haven't fixed it, just means I haven't yet tested without a doubt whether or not it IS fixed)\r\n\r\n- [X] DISPOSAL PIPES VERSUS AIR PIPES - fixes #10756\r\n- [X] CABLES VERSUS TERMINAL \r\n- [X] PLAYER VERSUS ITEMS IN HAND - fixes #10804\r\n- [x] POINTER VERSUS OTHER THINGS - fixes #10694\r\n- [x] FORCEFIELDS INVISIBLE (you guys did realise this isn't a planes issue right)\r\n\r\nNEW BUGS FOUND:\r\n\r\n(if box is checked, the bug has been fixed.) \r\n\r\n- [x] /obj/screen/inventory used the wrong layer, layer = 19.\r\n- [x] all hud objects appear less responsive  (probably to do with using my laptop trackpad, actually.)\r\n- [x] if you slip on the clown's PDA, you will appear underneath it, rather than on top. - will need to re-evaluate the object plane. (never mind, I just gave blankets their own plane and bumped up lying humans. should work fine)\r\n- [x] damage overlays are above the HUD, rather than below. Should give them their own plane, I think. (done)\r\n- [x] cables are on the wrong plane.\r\n- [x] pipes are on the wrong plane. \r\n- [x] Privacy shutters are on the wrong plane.\r\n- [x] Forgot to put humans on the lying human plane when they are lying.\r\n- [x] Forgot to put humans on the human plane when they are not.\r\n- [x] Status Displays are on the wrong plane\r\n- [x] MoMMIs appear blind when hiding\r\n- [x] Door layering is wacky.\r\n- [x] MoMMIs cannot unhide.\r\n- [x] density of poddoors New() wrong way around\r\n- [x] side windows appeared above poddoors\r\n- [x] UNFIXABLE: North facing chairs appear above objects that they shouldn't. (This is unfixable. - You cannot have them appear above humans and below objects which appear below humans. - I imagine that this was already a bug.)\r\n- [x] Cryocells were on the wrong layer.\r\n- [x] Catwalks were on the wrong plane.\r\n- [x] Showers & Curtains behaved oddly when combined. Fixed.\r\n\r\n100% TESTED:\r\n\r\n- [X] SECURITY CAMERAS AND LIGHTBULBS APPEAR ABOVE HUMANS\r\n- [X] NOTHING APPEARS ABSOLUTELY FUBAR SO FAR\r\n- [X] Comfy Chairs, Secways, Janicarts & Chairs appear normal\r\n- [X] Turrets seem normal\r\n- [X] Labcoats work\r\n- [X] Bags work\r\n- [X] Pockets work\r\n- [X] MoMMIs hats still work, their eyes still appear above darkness, and dropping from them layers correctly.\r\n- [X] The Holomap renders appropriately. This should be turned into a plane.\r\n- [X] Mesons still work\r\n- [X] In-hand cyborgs work as intended.\r\n- [X] oh wow the engineering borg sprite has spooky eyes\r\n- [X] People can still hide behind plants\r\n- [X] Blobs seem to still layer correctly.\r\n\r\n\r\nTODO:\r\n- [x] will need to rethink the OBJ_PLANE, it's too big and all encompassing, see the clown-PDA bug (never mind, I just gave blankets their own plane and bumped up lying humans. should work fine)\r\n- [x] Expand the tested list...?\r\n- [x] Doors handled layers really weirdly, DOOR_MOD and such. Make it use var/open_layer & var/closed_layer instead.\r\n- [ ] Read through my changes and try and catch out mistakes, such as putting OBJ_PLANE where I meant OBJ_LAYER. I'm almost certain I've done this somewhere.\r\n- [X] I don't trust turrets, they had really funky layers when I was looking at them, let's take a look if I did it correctly. (Seem okay.)\r\n- [x] Look at every single department on Box station and check if anything is amiss.\r\n- [x] Do the same with Defficiency.\r\n\r\nThis was all done by hand, I don't know fancy replace code","created_at":"2016-07-29T04:07:33Z","updated_at":"2016-08-01T05:22:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5aab4e2afd24a6a59b031051a05564235632601","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/d3athrow/vgstation13/milestones/13","html_url":"https://github.com/d3athrow/vgstation13/milestones/PLANES%20%E2%9C%88","labels_url":"https://api.github.com/repos/d3athrow/vgstation13/milestones/13/labels","id":1902653,"number":13,"title":"PLANES ✈","description":"Celt invented airplanes. 9/11 happened. Now he has 3 days to fix the WTC.","creator":{"login":"PJB3005","id":8107459,"avatar_url":"https://avatars.githubusercontent.com/u/8107459?v=3","gravatar_id":"","url":"https://api.github.com/users/PJB3005","html_url":"https://github.com/PJB3005","followers_url":"https://api.github.com/users/PJB3005/followers","following_url":"https://api.github.com/users/PJB3005/following{/other_user}","gists_url":"https://api.github.com/users/PJB3005/gists{/gist_id}","starred_url":"https://api.github.com/users/PJB3005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PJB3005/subscriptions","organizations_url":"https://api.github.com/users/PJB3005/orgs","repos_url":"https://api.github.com/users/PJB3005/repos","events_url":"https://api.github.com/users/PJB3005/events{/privacy}","received_events_url":"https://api.github.com/users/PJB3005/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":0,"state":"open","created_at":"2016-07-25T14:39:05Z","updated_at":"2016-07-29T10:06:54Z","due_on":"2016-07-27T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/11183/commits","review_comments_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/11183/comments","review_comment_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments{/number}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/11183/comments","statuses_url":"https://api.github.com/repos/d3athrow/vgstation13/statuses/d8db8170e1b7680be8e91088caa9648169953843","head":{"label":"DrCelt:NO_MORE_HALF_MEASURES_CLUSTER","ref":"NO_MORE_HALF_MEASURES_CLUSTER","sha":"d8db8170e1b7680be8e91088caa9648169953843","user":{"login":"DrCelt","id":7193289,"avatar_url":"https://avatars.githubusercontent.com/u/7193289?v=3","gravatar_id":"","url":"https://api.github.com/users/DrCelt","html_url":"https://github.com/DrCelt","followers_url":"https://api.github.com/users/DrCelt/followers","following_url":"https://api.github.com/users/DrCelt/following{/other_user}","gists_url":"https://api.github.com/users/DrCelt/gists{/gist_id}","starred_url":"https://api.github.com/users/DrCelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrCelt/subscriptions","organizations_url":"https://api.github.com/users/DrCelt/orgs","repos_url":"https://api.github.com/users/DrCelt/repos","events_url":"https://api.github.com/users/DrCelt/events{/privacy}","received_events_url":"https://api.github.com/users/DrCelt/received_events","type":"User","site_admin":false},"repo":{"id":60774209,"name":"vgstation13","full_name":"DrCelt/vgstation13","owner":{"login":"DrCelt","id":7193289,"avatar_url":"https://avatars.githubusercontent.com/u/7193289?v=3","gravatar_id":"","url":"https://api.github.com/users/DrCelt","html_url":"https://github.com/DrCelt","followers_url":"https://api.github.com/users/DrCelt/followers","following_url":"https://api.github.com/users/DrCelt/following{/other_user}","gists_url":"https://api.github.com/users/DrCelt/gists{/gist_id}","starred_url":"https://api.github.com/users/DrCelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrCelt/subscriptions","organizations_url":"https://api.github.com/users/DrCelt/orgs","repos_url":"https://api.github.com/users/DrCelt/repos","events_url":"https://api.github.com/users/DrCelt/events{/privacy}","received_events_url":"https://api.github.com/users/DrCelt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DrCelt/vgstation13","description":"Butts","fork":true,"url":"https://api.github.com/repos/DrCelt/vgstation13","forks_url":"https://api.github.com/repos/DrCelt/vgstation13/forks","keys_url":"https://api.github.com/repos/DrCelt/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DrCelt/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DrCelt/vgstation13/teams","hooks_url":"https://api.github.com/repos/DrCelt/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/DrCelt/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/DrCelt/vgstation13/events","assignees_url":"https://api.github.com/repos/DrCelt/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/DrCelt/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/DrCelt/vgstation13/tags","blobs_url":"https://api.github.com/repos/DrCelt/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DrCelt/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DrCelt/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/DrCelt/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DrCelt/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/DrCelt/vgstation13/languages","stargazers_url":"https://api.github.com/repos/DrCelt/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/DrCelt/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/DrCelt/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/DrCelt/vgstation13/subscription","commits_url":"https://api.github.com/repos/DrCelt/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/DrCelt/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/DrCelt/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/DrCelt/vgstation13/issues/comments{/number}","contents_url":"https://api.github.com/repos/DrCelt/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/DrCelt/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DrCelt/vgstation13/merges","archive_url":"https://api.github.com/repos/DrCelt/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DrCelt/vgstation13/downloads","issues_url":"https://api.github.com/repos/DrCelt/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/DrCelt/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/DrCelt/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/DrCelt/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DrCelt/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/DrCelt/vgstation13/releases{/id}","deployments_url":"https://api.github.com/repos/DrCelt/vgstation13/deployments","created_at":"2016-06-09T12:47:34Z","updated_at":"2016-07-07T15:47:26Z","pushed_at":"2016-07-31T23:14:47Z","git_url":"git://github.com/DrCelt/vgstation13.git","ssh_url":"git@github.com:DrCelt/vgstation13.git","clone_url":"https://github.com/DrCelt/vgstation13.git","svn_url":"https://github.com/DrCelt/vgstation13","homepage":"","size":895792,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"Bleeding-Edge"}},"base":{"label":"d3athrow:Bleeding-Edge","ref":"Bleeding-Edge","sha":"c231395bbf2ae38f8a995d7c69cd4a89720595e6","user":{"login":"d3athrow","id":706947,"avatar_url":"https://avatars.githubusercontent.com/u/706947?v=3","gravatar_id":"","url":"https://api.github.com/users/d3athrow","html_url":"https://github.com/d3athrow","followers_url":"https://api.github.com/users/d3athrow/followers","following_url":"https://api.github.com/users/d3athrow/following{/other_user}","gists_url":"https://api.github.com/users/d3athrow/gists{/gist_id}","starred_url":"https://api.github.com/users/d3athrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3athrow/subscriptions","organizations_url":"https://api.github.com/users/d3athrow/orgs","repos_url":"https://api.github.com/users/d3athrow/repos","events_url":"https://api.github.com/users/d3athrow/events{/privacy}","received_events_url":"https://api.github.com/users/d3athrow/received_events","type":"User","site_admin":false},"repo":{"id":10441188,"name":"vgstation13","full_name":"d3athrow/vgstation13","owner":{"login":"d3athrow","id":706947,"avatar_url":"https://avatars.githubusercontent.com/u/706947?v=3","gravatar_id":"","url":"https://api.github.com/users/d3athrow","html_url":"https://github.com/d3athrow","followers_url":"https://api.github.com/users/d3athrow/followers","following_url":"https://api.github.com/users/d3athrow/following{/other_user}","gists_url":"https://api.github.com/users/d3athrow/gists{/gist_id}","starred_url":"https://api.github.com/users/d3athrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3athrow/subscriptions","organizations_url":"https://api.github.com/users/d3athrow/orgs","repos_url":"https://api.github.com/users/d3athrow/repos","events_url":"https://api.github.com/users/d3athrow/events{/privacy}","received_events_url":"https://api.github.com/users/d3athrow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d3athrow/vgstation13","description":"Butts","fork":false,"url":"https://api.github.com/repos/d3athrow/vgstation13","forks_url":"https://api.github.com/repos/d3athrow/vgstation13/forks","keys_url":"https://api.github.com/repos/d3athrow/vgstation13/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3athrow/vgstation13/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3athrow/vgstation13/teams","hooks_url":"https://api.github.com/repos/d3athrow/vgstation13/hooks","issue_events_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/events{/number}","events_url":"https://api.github.com/repos/d3athrow/vgstation13/events","assignees_url":"https://api.github.com/repos/d3athrow/vgstation13/assignees{/user}","branches_url":"https://api.github.com/repos/d3athrow/vgstation13/branches{/branch}","tags_url":"https://api.github.com/repos/d3athrow/vgstation13/tags","blobs_url":"https://api.github.com/repos/d3athrow/vgstation13/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3athrow/vgstation13/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3athrow/vgstation13/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3athrow/vgstation13/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3athrow/vgstation13/statuses/{sha}","languages_url":"https://api.github.com/repos/d3athrow/vgstation13/languages","stargazers_url":"https://api.github.com/repos/d3athrow/vgstation13/stargazers","contributors_url":"https://api.github.com/repos/d3athrow/vgstation13/contributors","subscribers_url":"https://api.github.com/repos/d3athrow/vgstation13/subscribers","subscription_url":"https://api.github.com/repos/d3athrow/vgstation13/subscription","commits_url":"https://api.github.com/repos/d3athrow/vgstation13/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3athrow/vgstation13/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3athrow/vgstation13/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3athrow/vgstation13/issues/comments{/number}","contents_url":"https://api.github.com/repos/d3athrow/vgstation13/contents/{+path}","compare_url":"https://api.github.com/repos/d3athrow/vgstation13/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3athrow/vgstation13/merges","archive_url":"https://api.github.com/repos/d3athrow/vgstation13/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3athrow/vgstation13/downloads","issues_url":"https://api.github.com/repos/d3athrow/vgstation13/issues{/number}","pulls_url":"https://api.github.com/repos/d3athrow/vgstation13/pulls{/number}","milestones_url":"https://api.github.com/repos/d3athrow/vgstation13/milestones{/number}","notifications_url":"https://api.github.com/repos/d3athrow/vgstation13/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3athrow/vgstation13/labels{/name}","releases_url":"https://api.github.com/repos/d3athrow/vgstation13/releases{/id}","deployments_url":"https://api.github.com/repos/d3athrow/vgstation13/deployments","created_at":"2013-06-02T19:39:54Z","updated_at":"2016-07-29T17:17:12Z","pushed_at":"2016-08-01T00:59:08Z","git_url":"git://github.com/d3athrow/vgstation13.git","ssh_url":"git@github.com:d3athrow/vgstation13.git","clone_url":"https://github.com/d3athrow/vgstation13.git","svn_url":"https://github.com/d3athrow/vgstation13","homepage":"","size":1200044,"stargazers_count":86,"watchers_count":86,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":276,"mirror_url":null,"open_issues_count":1793,"forks":276,"open_issues":1793,"watchers":86,"default_branch":"Bleeding-Edge"}},"_links":{"self":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/11183"},"html":{"href":"https://github.com/d3athrow/vgstation13/pull/11183"},"issue":{"href":"https://api.github.com/repos/d3athrow/vgstation13/issues/11183"},"comments":{"href":"https://api.github.com/repos/d3athrow/vgstation13/issues/11183/comments"},"review_comments":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/11183/comments"},"review_comment":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/d3athrow/vgstation13/pulls/11183/commits"},"statuses":{"href":"https://api.github.com/repos/d3athrow/vgstation13/statuses/d8db8170e1b7680be8e91088caa9648169953843"}}}}
{"actor":{"display_login":"DrCelt"}}