{"action":"created","comment":{"url":"https://api.github.com/repos/lancaster-university/microbit-dal/pulls/comments/59868531","id":59868531,"diff_hunk":"@@ -33,6 +33,9 @@ DEALINGS IN THE SOFTWARE.\n #define MICROBIT_ID_BLE             1000\n #define MICROBIT_ID_BLE_UART        1001\n \n+#define MICROBIT_BLE_CONNECTED      1","path":"inc/bluetooth/ExternalEvents.h","position":4,"original_position":4,"commit_id":"87f7233a844f7aee2fced653e6ad5ca7a4f95388","original_commit_id":"87f7233a844f7aee2fced653e6ad5ca7a4f95388","user":{"login":"jamesadevine","id":4742697,"avatar_url":"https://avatars.githubusercontent.com/u/4742697?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesadevine","html_url":"https://github.com/jamesadevine","followers_url":"https://api.github.com/users/jamesadevine/followers","following_url":"https://api.github.com/users/jamesadevine/following{/other_user}","gists_url":"https://api.github.com/users/jamesadevine/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesadevine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesadevine/subscriptions","organizations_url":"https://api.github.com/users/jamesadevine/orgs","repos_url":"https://api.github.com/users/jamesadevine/repos","events_url":"https://api.github.com/users/jamesadevine/events{/privacy}","received_events_url":"https://api.github.com/users/jamesadevine/received_events","type":"User","site_admin":false},"body":"Hi @bluetooth-mdw,\r\n\r\nGreat PR, just a few minor things\r\n\r\nWe have an unofficial connection in terms of event codes, for example:\r\n`MICROBIT_COMPASS_EVT_CAL_END`\r\n\r\nIf both `MICROBIT_BLE_CONNECTED` and `MICROBIT_BLE_DISCONNECTED ` could be renamed that would be great!","created_at":"2016-04-15T12:48:05Z","updated_at":"2016-04-15T12:48:05Z","html_url":"https://github.com/lancaster-university/microbit-dal/pull/120#discussion_r59868531","pull_request_url":"https://api.github.com/repos/lancaster-university/microbit-dal/pulls/120","_links":{"self":{"href":"https://api.github.com/repos/lancaster-university/microbit-dal/pulls/comments/59868531"},"html":{"href":"https://github.com/lancaster-university/microbit-dal/pull/120#discussion_r59868531"},"pull_request":{"href":"https://api.github.com/repos/lancaster-university/microbit-dal/pulls/120"}}},"pull_request":{"url":"https://api.github.com/repos/lancaster-university/microbit-dal/pulls/120","id":66635999,"html_url":"https://github.com/lancaster-university/microbit-dal/pull/120","diff_url":"https://github.com/lancaster-university/microbit-dal/pull/120.diff","patch_url":"https://github.com/lancaster-university/microbit-dal/pull/120.patch","issue_url":"https://api.github.com/repos/lancaster-university/microbit-dal/issues/120","number":120,"state":"open","locked":false,"title":"Added BLE connect/disconnect events and fixed bug in MagnetometerServ…","user":{"login":"bluetooth-mdw","id":8341666,"avatar_url":"https://avatars.githubusercontent.com/u/8341666?v=3","gravatar_id":"","url":"https://api.github.com/users/bluetooth-mdw","html_url":"https://github.com/bluetooth-mdw","followers_url":"https://api.github.com/users/bluetooth-mdw/followers","following_url":"https://api.github.com/users/bluetooth-mdw/following{/other_user}","gists_url":"https://api.github.com/users/bluetooth-mdw/gists{/gist_id}","starred_url":"https://api.github.com/users/bluetooth-mdw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluetooth-mdw/subscriptions","organizations_url":"https://api.github.com/users/bluetooth-mdw/orgs","repos_url":"https://api.github.com/users/bluetooth-mdw/repos","events_url":"https://api.github.com/users/bluetooth-mdw/events{/privacy}","received_events_url":"https://api.github.com/users/bluetooth-mdw/received_events","type":"User","site_admin":false},"body":"…ice re: bearing characteristic\r\n\r\nSee https://drive.google.com/file/d/0B9Z54U0dfwbFN0Y0RVVROS1DQWM/view?usp=sharing for testing of BLE connection events.","created_at":"2016-04-15T12:40:58Z","updated_at":"2016-04-15T12:48:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"467a857d325c155d7163039ebbf42f8031186c05","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lancaster-university/microbit-dal/pulls/120/commits","review_comments_url":"https://api.github.com/repos/lancaster-university/microbit-dal/pulls/120/comments","review_comment_url":"https://api.github.com/repos/lancaster-university/microbit-dal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lancaster-university/microbit-dal/issues/120/comments","statuses_url":"https://api.github.com/repos/lancaster-university/microbit-dal/statuses/87f7233a844f7aee2fced653e6ad5ca7a4f95388","head":{"label":"bluetooth-mdw:master","ref":"master","sha":"87f7233a844f7aee2fced653e6ad5ca7a4f95388","user":{"login":"bluetooth-mdw","id":8341666,"avatar_url":"https://avatars.githubusercontent.com/u/8341666?v=3","gravatar_id":"","url":"https://api.github.com/users/bluetooth-mdw","html_url":"https://github.com/bluetooth-mdw","followers_url":"https://api.github.com/users/bluetooth-mdw/followers","following_url":"https://api.github.com/users/bluetooth-mdw/following{/other_user}","gists_url":"https://api.github.com/users/bluetooth-mdw/gists{/gist_id}","starred_url":"https://api.github.com/users/bluetooth-mdw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluetooth-mdw/subscriptions","organizations_url":"https://api.github.com/users/bluetooth-mdw/orgs","repos_url":"https://api.github.com/users/bluetooth-mdw/repos","events_url":"https://api.github.com/users/bluetooth-mdw/events{/privacy}","received_events_url":"https://api.github.com/users/bluetooth-mdw/received_events","type":"User","site_admin":false},"repo":{"id":56308882,"name":"microbit-dal","full_name":"bluetooth-mdw/microbit-dal","owner":{"login":"bluetooth-mdw","id":8341666,"avatar_url":"https://avatars.githubusercontent.com/u/8341666?v=3","gravatar_id":"","url":"https://api.github.com/users/bluetooth-mdw","html_url":"https://github.com/bluetooth-mdw","followers_url":"https://api.github.com/users/bluetooth-mdw/followers","following_url":"https://api.github.com/users/bluetooth-mdw/following{/other_user}","gists_url":"https://api.github.com/users/bluetooth-mdw/gists{/gist_id}","starred_url":"https://api.github.com/users/bluetooth-mdw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluetooth-mdw/subscriptions","organizations_url":"https://api.github.com/users/bluetooth-mdw/orgs","repos_url":"https://api.github.com/users/bluetooth-mdw/repos","events_url":"https://api.github.com/users/bluetooth-mdw/events{/privacy}","received_events_url":"https://api.github.com/users/bluetooth-mdw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bluetooth-mdw/microbit-dal","description":"","fork":true,"url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal","forks_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/forks","keys_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/teams","hooks_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/hooks","issue_events_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/issues/events{/number}","events_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/events","assignees_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/assignees{/user}","branches_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/branches{/branch}","tags_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/tags","blobs_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/git/refs{/sha}","trees_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/statuses/{sha}","languages_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/languages","stargazers_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/stargazers","contributors_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/contributors","subscribers_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/subscribers","subscription_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/subscription","commits_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/commits{/sha}","git_commits_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/git/commits{/sha}","comments_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/comments{/number}","issue_comment_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/issues/comments{/number}","contents_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/contents/{+path}","compare_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/merges","archive_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/downloads","issues_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/issues{/number}","pulls_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/pulls{/number}","milestones_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/milestones{/number}","notifications_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/labels{/name}","releases_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/releases{/id}","deployments_url":"https://api.github.com/repos/bluetooth-mdw/microbit-dal/deployments","created_at":"2016-04-15T09:37:01Z","updated_at":"2016-04-15T09:37:02Z","pushed_at":"2016-04-15T12:39:04Z","git_url":"git://github.com/bluetooth-mdw/microbit-dal.git","ssh_url":"git@github.com:bluetooth-mdw/microbit-dal.git","clone_url":"https://github.com/bluetooth-mdw/microbit-dal.git","svn_url":"https://github.com/bluetooth-mdw/microbit-dal","homepage":"http://lancaster-university.github.io/microbit-docs","size":1840,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lancaster-university:master","ref":"master","sha":"7cf98c2290f5fb1d0e86726e9141f6f1ff4e0994","user":{"login":"lancaster-university","id":13766084,"avatar_url":"https://avatars.githubusercontent.com/u/13766084?v=3","gravatar_id":"","url":"https://api.github.com/users/lancaster-university","html_url":"https://github.com/lancaster-university","followers_url":"https://api.github.com/users/lancaster-university/followers","following_url":"https://api.github.com/users/lancaster-university/following{/other_user}","gists_url":"https://api.github.com/users/lancaster-university/gists{/gist_id}","starred_url":"https://api.github.com/users/lancaster-university/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lancaster-university/subscriptions","organizations_url":"https://api.github.com/users/lancaster-university/orgs","repos_url":"https://api.github.com/users/lancaster-university/repos","events_url":"https://api.github.com/users/lancaster-university/events{/privacy}","received_events_url":"https://api.github.com/users/lancaster-university/received_events","type":"Organization","site_admin":false},"repo":{"id":40015241,"name":"microbit-dal","full_name":"lancaster-university/microbit-dal","owner":{"login":"lancaster-university","id":13766084,"avatar_url":"https://avatars.githubusercontent.com/u/13766084?v=3","gravatar_id":"","url":"https://api.github.com/users/lancaster-university","html_url":"https://github.com/lancaster-university","followers_url":"https://api.github.com/users/lancaster-university/followers","following_url":"https://api.github.com/users/lancaster-university/following{/other_user}","gists_url":"https://api.github.com/users/lancaster-university/gists{/gist_id}","starred_url":"https://api.github.com/users/lancaster-university/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lancaster-university/subscriptions","organizations_url":"https://api.github.com/users/lancaster-university/orgs","repos_url":"https://api.github.com/users/lancaster-university/repos","events_url":"https://api.github.com/users/lancaster-university/events{/privacy}","received_events_url":"https://api.github.com/users/lancaster-university/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lancaster-university/microbit-dal","description":"","fork":false,"url":"https://api.github.com/repos/lancaster-university/microbit-dal","forks_url":"https://api.github.com/repos/lancaster-university/microbit-dal/forks","keys_url":"https://api.github.com/repos/lancaster-university/microbit-dal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lancaster-university/microbit-dal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lancaster-university/microbit-dal/teams","hooks_url":"https://api.github.com/repos/lancaster-university/microbit-dal/hooks","issue_events_url":"https://api.github.com/repos/lancaster-university/microbit-dal/issues/events{/number}","events_url":"https://api.github.com/repos/lancaster-university/microbit-dal/events","assignees_url":"https://api.github.com/repos/lancaster-university/microbit-dal/assignees{/user}","branches_url":"https://api.github.com/repos/lancaster-university/microbit-dal/branches{/branch}","tags_url":"https://api.github.com/repos/lancaster-university/microbit-dal/tags","blobs_url":"https://api.github.com/repos/lancaster-university/microbit-dal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lancaster-university/microbit-dal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lancaster-university/microbit-dal/git/refs{/sha}","trees_url":"https://api.github.com/repos/lancaster-university/microbit-dal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lancaster-university/microbit-dal/statuses/{sha}","languages_url":"https://api.github.com/repos/lancaster-university/microbit-dal/languages","stargazers_url":"https://api.github.com/repos/lancaster-university/microbit-dal/stargazers","contributors_url":"https://api.github.com/repos/lancaster-university/microbit-dal/contributors","subscribers_url":"https://api.github.com/repos/lancaster-university/microbit-dal/subscribers","subscription_url":"https://api.github.com/repos/lancaster-university/microbit-dal/subscription","commits_url":"https://api.github.com/repos/lancaster-university/microbit-dal/commits{/sha}","git_commits_url":"https://api.github.com/repos/lancaster-university/microbit-dal/git/commits{/sha}","comments_url":"https://api.github.com/repos/lancaster-university/microbit-dal/comments{/number}","issue_comment_url":"https://api.github.com/repos/lancaster-university/microbit-dal/issues/comments{/number}","contents_url":"https://api.github.com/repos/lancaster-university/microbit-dal/contents/{+path}","compare_url":"https://api.github.com/repos/lancaster-university/microbit-dal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lancaster-university/microbit-dal/merges","archive_url":"https://api.github.com/repos/lancaster-university/microbit-dal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lancaster-university/microbit-dal/downloads","issues_url":"https://api.github.com/repos/lancaster-university/microbit-dal/issues{/number}","pulls_url":"https://api.github.com/repos/lancaster-university/microbit-dal/pulls{/number}","milestones_url":"https://api.github.com/repos/lancaster-university/microbit-dal/milestones{/number}","notifications_url":"https://api.github.com/repos/lancaster-university/microbit-dal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lancaster-university/microbit-dal/labels{/name}","releases_url":"https://api.github.com/repos/lancaster-university/microbit-dal/releases{/id}","deployments_url":"https://api.github.com/repos/lancaster-university/microbit-dal/deployments","created_at":"2015-07-31T16:50:04Z","updated_at":"2016-04-13T17:51:44Z","pushed_at":"2016-04-15T12:40:58Z","git_url":"git://github.com/lancaster-university/microbit-dal.git","ssh_url":"git@github.com:lancaster-university/microbit-dal.git","clone_url":"https://github.com/lancaster-university/microbit-dal.git","svn_url":"https://github.com/lancaster-university/microbit-dal","homepage":"http://lancaster-university.github.io/microbit-docs","size":3218,"stargazers_count":13,"watchers_count":13,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":33,"forks":2,"open_issues":33,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lancaster-university/microbit-dal/pulls/120"},"html":{"href":"https://github.com/lancaster-university/microbit-dal/pull/120"},"issue":{"href":"https://api.github.com/repos/lancaster-university/microbit-dal/issues/120"},"comments":{"href":"https://api.github.com/repos/lancaster-university/microbit-dal/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/lancaster-university/microbit-dal/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/lancaster-university/microbit-dal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lancaster-university/microbit-dal/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/lancaster-university/microbit-dal/statuses/87f7233a844f7aee2fced653e6ad5ca7a4f95388"}}}}