{"action":"created","issue":{"url":"https://api.github.com/repos/Leaflet/Leaflet/issues/5051","repository_url":"https://api.github.com/repos/Leaflet/Leaflet","labels_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/5051/labels{/name}","comments_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/5051/comments","events_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/5051/events","html_url":"https://github.com/Leaflet/Leaflet/issues/5051","id":185249745,"number":5051,"title":"L.geoJSON layer attribution not shown on map control","user":{"login":"matthew-shaw","id":2802973,"avatar_url":"https://avatars.githubusercontent.com/u/2802973?v=3","gravatar_id":"","url":"https://api.github.com/users/matthew-shaw","html_url":"https://github.com/matthew-shaw","followers_url":"https://api.github.com/users/matthew-shaw/followers","following_url":"https://api.github.com/users/matthew-shaw/following{/other_user}","gists_url":"https://api.github.com/users/matthew-shaw/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-shaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-shaw/subscriptions","organizations_url":"https://api.github.com/users/matthew-shaw/orgs","repos_url":"https://api.github.com/users/matthew-shaw/repos","events_url":"https://api.github.com/users/matthew-shaw/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-shaw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-25T22:22:16Z","updated_at":"2016-10-26T07:23:29Z","closed_at":null,"body":"## How to reproduce\r\n\r\n- Leaflet version I'm using: 1.0.0\r\n- Browser (with version) I'm using: Chrome 54\r\n- OS/Platform (with version) I'm using: OS X 10.11.6\r\n- Add L.geoJSON layer with an attribution option to a map\r\n\r\n## What behaviour I'm expecting and which behaviour I'm seeing\r\nAttribution statement not added to attribution control on map, in the same way that `L.tileLayer` is.\r\n\r\n## Minimal example reproducing the issue\r\n\r\nhttps://github.com/MashSoftware/place/blob/master/mash_place/templates/counties.html#L65\r\n"},"comment":{"url":"https://api.github.com/repos/Leaflet/Leaflet/issues/comments/256269332","html_url":"https://github.com/Leaflet/Leaflet/issues/5051#issuecomment-256269332","issue_url":"https://api.github.com/repos/Leaflet/Leaflet/issues/5051","id":256269332,"user":{"login":"IvanSanchez","id":1125786,"avatar_url":"https://avatars.githubusercontent.com/u/1125786?v=3","gravatar_id":"","url":"https://api.github.com/users/IvanSanchez","html_url":"https://github.com/IvanSanchez","followers_url":"https://api.github.com/users/IvanSanchez/followers","following_url":"https://api.github.com/users/IvanSanchez/following{/other_user}","gists_url":"https://api.github.com/users/IvanSanchez/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanSanchez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanSanchez/subscriptions","organizations_url":"https://api.github.com/users/IvanSanchez/orgs","repos_url":"https://api.github.com/users/IvanSanchez/repos","events_url":"https://api.github.com/users/IvanSanchez/events{/privacy}","received_events_url":"https://api.github.com/users/IvanSanchez/received_events","type":"User","site_admin":false},"created_at":"2016-10-26T07:23:29Z","updated_at":"2016-10-26T07:23:29Z","body":"Even more minimal example at https://playground-leaflet.rhcloud.com/zuta/edit?html,output\r\n\r\nOne could argue that this behaviour as documented, as [the docs do not mention an `attribution` option for `L.GeoJSON`](http://leafletjs.com/reference-1.0.0.html#geojson-option). In this way, this is similar to #4277 and #4279.\r\n\r\nThe workaround, as in those cases, is to make sure that the layers created by `pointToLayer` and `style` callback options create leaflet layers with attribution (or the right pane or whatever).\r\n\r\nI can see a use case for this. The question is whether we want an `attribution` option in `L.GeoJSON` or `L.LayerGroup`."}}
{"actor":{"display_login":"IvanSanchez"}}