{"action":"created","comment":{"url":"https://api.github.com/repos/dask/fastparquet/pulls/comments/89929615","pull_request_review_id":10455828,"id":89929615,"diff_hunk":"@@ -432,3 +432,54 @@ def test_text_convert(tempdir):\n     assert pf.statistics['max']['a'] == ['a']\n     df2 = pf.to_pandas()\n     tm.assert_frame_equal(df, df2)\n+\n+\n+def test_null_time(tempdir):\n+    \"\"\"Test reading a file that contains null records.\"\"\"\n+    tmp = str(tempdir)\n+    expected = pd.DataFrame({\"t\": [np.timedelta64(), np.timedelta64('NaT')]})\n+    fn = os.path.join(tmp, \"test-time-null.parquet\")\n+\n+    # with NaT\n+    write(fn, expected, has_nulls=False)\n+    p = ParquetFile(fn)\n+    data = p.to_pandas()\n+    assert (data['t'] == expected['t'])[~expected['t'].isnull()].all()\n+    assert sum(data['t'].isnull()) == sum(expected['t'].isnull())","path":"fastparquet/test/test_writer.py","position":35,"original_position":35,"commit_id":"c869062cfa3fd94fe74ee4483477bad53e29aaa1","original_commit_id":"c869062cfa3fd94fe74ee4483477bad53e29aaa1","user":{"login":"mrocklin","id":306380,"avatar_url":"https://avatars.githubusercontent.com/u/306380?v=3","gravatar_id":"","url":"https://api.github.com/users/mrocklin","html_url":"https://github.com/mrocklin","followers_url":"https://api.github.com/users/mrocklin/followers","following_url":"https://api.github.com/users/mrocklin/following{/other_user}","gists_url":"https://api.github.com/users/mrocklin/gists{/gist_id}","starred_url":"https://api.github.com/users/mrocklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrocklin/subscriptions","organizations_url":"https://api.github.com/users/mrocklin/orgs","repos_url":"https://api.github.com/users/mrocklin/repos","events_url":"https://api.github.com/users/mrocklin/events{/privacy}","received_events_url":"https://api.github.com/users/mrocklin/received_events","type":"User","site_admin":false},"body":"What do we actually write here?  What does Spark perceive this to be?  ","created_at":"2016-11-29T02:23:56Z","updated_at":"2016-11-29T02:23:56Z","html_url":"https://github.com/dask/fastparquet/pull/33#discussion_r89929615","pull_request_url":"https://api.github.com/repos/dask/fastparquet/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/dask/fastparquet/pulls/comments/89929615"},"html":{"href":"https://github.com/dask/fastparquet/pull/33#discussion_r89929615"},"pull_request":{"href":"https://api.github.com/repos/dask/fastparquet/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/dask/fastparquet/pulls/33","id":95350803,"html_url":"https://github.com/dask/fastparquet/pull/33","diff_url":"https://github.com/dask/fastparquet/pull/33.diff","patch_url":"https://github.com/dask/fastparquet/pull/33.patch","issue_url":"https://api.github.com/repos/dask/fastparquet/issues/33","number":33,"state":"open","locked":false,"title":"Convert on numpy arrays, convert to series later","user":{"login":"martindurant","id":6042212,"avatar_url":"https://avatars.githubusercontent.com/u/6042212?v=3","gravatar_id":"","url":"https://api.github.com/users/martindurant","html_url":"https://github.com/martindurant","followers_url":"https://api.github.com/users/martindurant/followers","following_url":"https://api.github.com/users/martindurant/following{/other_user}","gists_url":"https://api.github.com/users/martindurant/gists{/gist_id}","starred_url":"https://api.github.com/users/martindurant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martindurant/subscriptions","organizations_url":"https://api.github.com/users/martindurant/orgs","repos_url":"https://api.github.com/users/martindurant/repos","events_url":"https://api.github.com/users/martindurant/events{/privacy}","received_events_url":"https://api.github.com/users/martindurant/received_events","type":"User","site_admin":false},"body":"The things coming out of read_col are now arrays, unless they are to be categoricals.","created_at":"2016-11-25T22:16:27Z","updated_at":"2016-11-29T02:31:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"728f8df17388b017eb607a47e6a6bb07c7aabaf5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dask/fastparquet/pulls/33/commits","review_comments_url":"https://api.github.com/repos/dask/fastparquet/pulls/33/comments","review_comment_url":"https://api.github.com/repos/dask/fastparquet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dask/fastparquet/issues/33/comments","statuses_url":"https://api.github.com/repos/dask/fastparquet/statuses/c869062cfa3fd94fe74ee4483477bad53e29aaa1","head":{"label":"martindurant:read_as_arrays","ref":"read_as_arrays","sha":"c869062cfa3fd94fe74ee4483477bad53e29aaa1","user":{"login":"martindurant","id":6042212,"avatar_url":"https://avatars.githubusercontent.com/u/6042212?v=3","gravatar_id":"","url":"https://api.github.com/users/martindurant","html_url":"https://github.com/martindurant","followers_url":"https://api.github.com/users/martindurant/followers","following_url":"https://api.github.com/users/martindurant/following{/other_user}","gists_url":"https://api.github.com/users/martindurant/gists{/gist_id}","starred_url":"https://api.github.com/users/martindurant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martindurant/subscriptions","organizations_url":"https://api.github.com/users/martindurant/orgs","repos_url":"https://api.github.com/users/martindurant/repos","events_url":"https://api.github.com/users/martindurant/events{/privacy}","received_events_url":"https://api.github.com/users/martindurant/received_events","type":"User","site_admin":false},"repo":{"id":73724259,"name":"fastparquet","full_name":"martindurant/fastparquet","owner":{"login":"martindurant","id":6042212,"avatar_url":"https://avatars.githubusercontent.com/u/6042212?v=3","gravatar_id":"","url":"https://api.github.com/users/martindurant","html_url":"https://github.com/martindurant","followers_url":"https://api.github.com/users/martindurant/followers","following_url":"https://api.github.com/users/martindurant/following{/other_user}","gists_url":"https://api.github.com/users/martindurant/gists{/gist_id}","starred_url":"https://api.github.com/users/martindurant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martindurant/subscriptions","organizations_url":"https://api.github.com/users/martindurant/orgs","repos_url":"https://api.github.com/users/martindurant/repos","events_url":"https://api.github.com/users/martindurant/events{/privacy}","received_events_url":"https://api.github.com/users/martindurant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martindurant/fastparquet","description":"python implementation of the parquet columnar file format.","fork":true,"url":"https://api.github.com/repos/martindurant/fastparquet","forks_url":"https://api.github.com/repos/martindurant/fastparquet/forks","keys_url":"https://api.github.com/repos/martindurant/fastparquet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martindurant/fastparquet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martindurant/fastparquet/teams","hooks_url":"https://api.github.com/repos/martindurant/fastparquet/hooks","issue_events_url":"https://api.github.com/repos/martindurant/fastparquet/issues/events{/number}","events_url":"https://api.github.com/repos/martindurant/fastparquet/events","assignees_url":"https://api.github.com/repos/martindurant/fastparquet/assignees{/user}","branches_url":"https://api.github.com/repos/martindurant/fastparquet/branches{/branch}","tags_url":"https://api.github.com/repos/martindurant/fastparquet/tags","blobs_url":"https://api.github.com/repos/martindurant/fastparquet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martindurant/fastparquet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martindurant/fastparquet/git/refs{/sha}","trees_url":"https://api.github.com/repos/martindurant/fastparquet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martindurant/fastparquet/statuses/{sha}","languages_url":"https://api.github.com/repos/martindurant/fastparquet/languages","stargazers_url":"https://api.github.com/repos/martindurant/fastparquet/stargazers","contributors_url":"https://api.github.com/repos/martindurant/fastparquet/contributors","subscribers_url":"https://api.github.com/repos/martindurant/fastparquet/subscribers","subscription_url":"https://api.github.com/repos/martindurant/fastparquet/subscription","commits_url":"https://api.github.com/repos/martindurant/fastparquet/commits{/sha}","git_commits_url":"https://api.github.com/repos/martindurant/fastparquet/git/commits{/sha}","comments_url":"https://api.github.com/repos/martindurant/fastparquet/comments{/number}","issue_comment_url":"https://api.github.com/repos/martindurant/fastparquet/issues/comments{/number}","contents_url":"https://api.github.com/repos/martindurant/fastparquet/contents/{+path}","compare_url":"https://api.github.com/repos/martindurant/fastparquet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martindurant/fastparquet/merges","archive_url":"https://api.github.com/repos/martindurant/fastparquet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martindurant/fastparquet/downloads","issues_url":"https://api.github.com/repos/martindurant/fastparquet/issues{/number}","pulls_url":"https://api.github.com/repos/martindurant/fastparquet/pulls{/number}","milestones_url":"https://api.github.com/repos/martindurant/fastparquet/milestones{/number}","notifications_url":"https://api.github.com/repos/martindurant/fastparquet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martindurant/fastparquet/labels{/name}","releases_url":"https://api.github.com/repos/martindurant/fastparquet/releases{/id}","deployments_url":"https://api.github.com/repos/martindurant/fastparquet/deployments","created_at":"2016-11-14T16:24:18Z","updated_at":"2016-11-14T16:24:20Z","pushed_at":"2016-11-28T22:38:26Z","git_url":"git://github.com/martindurant/fastparquet.git","ssh_url":"git@github.com:martindurant/fastparquet.git","clone_url":"https://github.com/martindurant/fastparquet.git","svn_url":"https://github.com/martindurant/fastparquet","homepage":null,"size":27628,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dask:master","ref":"master","sha":"f8a8cea3414fe3b455157d17a8cc492e588d2f14","user":{"login":"dask","id":17131925,"avatar_url":"https://avatars.githubusercontent.com/u/17131925?v=3","gravatar_id":"","url":"https://api.github.com/users/dask","html_url":"https://github.com/dask","followers_url":"https://api.github.com/users/dask/followers","following_url":"https://api.github.com/users/dask/following{/other_user}","gists_url":"https://api.github.com/users/dask/gists{/gist_id}","starred_url":"https://api.github.com/users/dask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dask/subscriptions","organizations_url":"https://api.github.com/users/dask/orgs","repos_url":"https://api.github.com/users/dask/repos","events_url":"https://api.github.com/users/dask/events{/privacy}","received_events_url":"https://api.github.com/users/dask/received_events","type":"Organization","site_admin":false},"repo":{"id":45694060,"name":"fastparquet","full_name":"dask/fastparquet","owner":{"login":"dask","id":17131925,"avatar_url":"https://avatars.githubusercontent.com/u/17131925?v=3","gravatar_id":"","url":"https://api.github.com/users/dask","html_url":"https://github.com/dask","followers_url":"https://api.github.com/users/dask/followers","following_url":"https://api.github.com/users/dask/following{/other_user}","gists_url":"https://api.github.com/users/dask/gists{/gist_id}","starred_url":"https://api.github.com/users/dask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dask/subscriptions","organizations_url":"https://api.github.com/users/dask/orgs","repos_url":"https://api.github.com/users/dask/repos","events_url":"https://api.github.com/users/dask/events{/privacy}","received_events_url":"https://api.github.com/users/dask/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dask/fastparquet","description":"python implementation of the parquet columnar file format.","fork":true,"url":"https://api.github.com/repos/dask/fastparquet","forks_url":"https://api.github.com/repos/dask/fastparquet/forks","keys_url":"https://api.github.com/repos/dask/fastparquet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dask/fastparquet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dask/fastparquet/teams","hooks_url":"https://api.github.com/repos/dask/fastparquet/hooks","issue_events_url":"https://api.github.com/repos/dask/fastparquet/issues/events{/number}","events_url":"https://api.github.com/repos/dask/fastparquet/events","assignees_url":"https://api.github.com/repos/dask/fastparquet/assignees{/user}","branches_url":"https://api.github.com/repos/dask/fastparquet/branches{/branch}","tags_url":"https://api.github.com/repos/dask/fastparquet/tags","blobs_url":"https://api.github.com/repos/dask/fastparquet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dask/fastparquet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dask/fastparquet/git/refs{/sha}","trees_url":"https://api.github.com/repos/dask/fastparquet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dask/fastparquet/statuses/{sha}","languages_url":"https://api.github.com/repos/dask/fastparquet/languages","stargazers_url":"https://api.github.com/repos/dask/fastparquet/stargazers","contributors_url":"https://api.github.com/repos/dask/fastparquet/contributors","subscribers_url":"https://api.github.com/repos/dask/fastparquet/subscribers","subscription_url":"https://api.github.com/repos/dask/fastparquet/subscription","commits_url":"https://api.github.com/repos/dask/fastparquet/commits{/sha}","git_commits_url":"https://api.github.com/repos/dask/fastparquet/git/commits{/sha}","comments_url":"https://api.github.com/repos/dask/fastparquet/comments{/number}","issue_comment_url":"https://api.github.com/repos/dask/fastparquet/issues/comments{/number}","contents_url":"https://api.github.com/repos/dask/fastparquet/contents/{+path}","compare_url":"https://api.github.com/repos/dask/fastparquet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dask/fastparquet/merges","archive_url":"https://api.github.com/repos/dask/fastparquet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dask/fastparquet/downloads","issues_url":"https://api.github.com/repos/dask/fastparquet/issues{/number}","pulls_url":"https://api.github.com/repos/dask/fastparquet/pulls{/number}","milestones_url":"https://api.github.com/repos/dask/fastparquet/milestones{/number}","notifications_url":"https://api.github.com/repos/dask/fastparquet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dask/fastparquet/labels{/name}","releases_url":"https://api.github.com/repos/dask/fastparquet/releases{/id}","deployments_url":"https://api.github.com/repos/dask/fastparquet/deployments","created_at":"2015-11-06T16:42:17Z","updated_at":"2016-11-25T00:48:47Z","pushed_at":"2016-11-28T22:38:27Z","git_url":"git://github.com/dask/fastparquet.git","ssh_url":"git@github.com:dask/fastparquet.git","clone_url":"https://github.com/dask/fastparquet.git","svn_url":"https://github.com/dask/fastparquet","homepage":null,"size":27772,"stargazers_count":12,"watchers_count":12,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":5,"forks":6,"open_issues":5,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dask/fastparquet/pulls/33"},"html":{"href":"https://github.com/dask/fastparquet/pull/33"},"issue":{"href":"https://api.github.com/repos/dask/fastparquet/issues/33"},"comments":{"href":"https://api.github.com/repos/dask/fastparquet/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/dask/fastparquet/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/dask/fastparquet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dask/fastparquet/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/dask/fastparquet/statuses/c869062cfa3fd94fe74ee4483477bad53e29aaa1"}}}}
{"actor":{"display_login":"mrocklin"}}