{"action":"created","issue":{"url":"https://api.github.com/repos/hpi-swa/smalltalkCI/issues/48","repository_url":"https://api.github.com/repos/hpi-swa/smalltalkCI","labels_url":"https://api.github.com/repos/hpi-swa/smalltalkCI/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/hpi-swa/smalltalkCI/issues/48/comments","events_url":"https://api.github.com/repos/hpi-swa/smalltalkCI/issues/48/events","html_url":"https://github.com/hpi-swa/smalltalkCI/issues/48","id":131445989,"number":48,"title":"SmalltalkCI>>readSTONSpec: is not portable to GemStone","user":{"login":"dalehenrich","id":623951,"avatar_url":"https://avatars.githubusercontent.com/u/623951?v=3","gravatar_id":"","url":"https://api.github.com/users/dalehenrich","html_url":"https://github.com/dalehenrich","followers_url":"https://api.github.com/users/dalehenrich/followers","following_url":"https://api.github.com/users/dalehenrich/following{/other_user}","gists_url":"https://api.github.com/users/dalehenrich/gists{/gist_id}","starred_url":"https://api.github.com/users/dalehenrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalehenrich/subscriptions","organizations_url":"https://api.github.com/users/dalehenrich/orgs","repos_url":"https://api.github.com/users/dalehenrich/repos","events_url":"https://api.github.com/users/dalehenrich/events{/privacy}","received_events_url":"https://api.github.com/users/dalehenrich/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-02-04T19:08:59Z","updated_at":"2016-02-04T22:06:59Z","closed_at":null,"body":"The classes StandardFileStream and MultiByteFileStream used in [SmalltalkCI>>readSTONSpec:](https://github.com/dalehenrich/smalltalkCI/blob/master/src/SmalltalkCI-Core.st#L280) are not present in GemStone and the method probably should be made abstract and the current implementation moved to Squeak, as it appears that SmalltalkCI>>readSTONSpec: is implemented differently for Pharo as well ...\r\n\r\nNow is a good time for me to look into this as well as fleshing out the rest of the GemSTone implementation.\r\n\r\nBTW, I thought that I saw a FileTree repo for the SmalltalkCI code ... should I wait until that code is merged before making changes .... I haven't had to work with chunk format files since the 1980's:)\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/hpi-swa/smalltalkCI/issues/comments/180072805","html_url":"https://github.com/hpi-swa/smalltalkCI/issues/48#issuecomment-180072805","issue_url":"https://api.github.com/repos/hpi-swa/smalltalkCI/issues/48","id":180072805,"user":{"login":"fniephaus","id":2368856,"avatar_url":"https://avatars.githubusercontent.com/u/2368856?v=3","gravatar_id":"","url":"https://api.github.com/users/fniephaus","html_url":"https://github.com/fniephaus","followers_url":"https://api.github.com/users/fniephaus/followers","following_url":"https://api.github.com/users/fniephaus/following{/other_user}","gists_url":"https://api.github.com/users/fniephaus/gists{/gist_id}","starred_url":"https://api.github.com/users/fniephaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fniephaus/subscriptions","organizations_url":"https://api.github.com/users/fniephaus/orgs","repos_url":"https://api.github.com/users/fniephaus/repos","events_url":"https://api.github.com/users/fniephaus/events{/privacy}","received_events_url":"https://api.github.com/users/fniephaus/received_events","type":"User","site_admin":false},"created_at":"2016-02-04T22:06:59Z","updated_at":"2016-02-04T22:06:59Z","body":"The loading and testing is specified in the [`.smalltalk.ston`](https://github.com/hpi-swa/smalltalkCI/blob/master/.smalltalk.ston) and yes, they do [pass on Squeak](https://travis-ci.org/hpi-swa/smalltalkCI/builds/106706709). However, it totally makes sense to have platform-specific tests as well to test platform-specific code!"}}