{"action":"created","comment":{"url":"https://api.github.com/repos/zalando-stups/fullstop/pulls/comments/52487253","id":52487253,"diff_hunk":"@@ -0,0 +1,17 @@\n+package org.zalando.stups.fullstop.rule.service;\n+\n+import org.zalando.stups.fullstop.rule.entity.RuleDTO;\n+import org.zalando.stups.fullstop.rule.entity.RuleEntity;\n+\n+import java.util.List;\n+\n+public interface RuleEntityService {\n+\n+    RuleEntity save(RuleDTO ruleDTO);\n+\n+    RuleEntity update(RuleDTO ruleDTO, Long id);","path":"fullstop-violation/fullstop-violation-jpa/src/main/java/org/zalando/stups/fullstop/rule/service/RuleEntityService.java","position":12,"original_position":12,"commit_id":"9c7d58ecf24298ffcc4707db7058203092e34495","original_commit_id":"9c7d58ecf24298ffcc4707db7058203092e34495","user":{"login":"harti2006","id":6928004,"avatar_url":"https://avatars.githubusercontent.com/u/6928004?v=3","gravatar_id":"","url":"https://api.github.com/users/harti2006","html_url":"https://github.com/harti2006","followers_url":"https://api.github.com/users/harti2006/followers","following_url":"https://api.github.com/users/harti2006/following{/other_user}","gists_url":"https://api.github.com/users/harti2006/gists{/gist_id}","starred_url":"https://api.github.com/users/harti2006/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harti2006/subscriptions","organizations_url":"https://api.github.com/users/harti2006/orgs","repos_url":"https://api.github.com/users/harti2006/repos","events_url":"https://api.github.com/users/harti2006/events{/privacy}","received_events_url":"https://api.github.com/users/harti2006/received_events","type":"User","site_admin":false},"body":"interesting point from Jan: should we really \"update\" existing Rules, or should we better replace them (set expiryDate to yesterday and create a new one)\r\nThis way we would have a clean history -> Especially when we put the matched rule into the violation, it would be weird to allow later changes on the rule.","created_at":"2016-02-10T16:55:33Z","updated_at":"2016-02-10T16:55:33Z","html_url":"https://github.com/zalando-stups/fullstop/pull/356#discussion_r52487253","pull_request_url":"https://api.github.com/repos/zalando-stups/fullstop/pulls/356","_links":{"self":{"href":"https://api.github.com/repos/zalando-stups/fullstop/pulls/comments/52487253"},"html":{"href":"https://github.com/zalando-stups/fullstop/pull/356#discussion_r52487253"},"pull_request":{"href":"https://api.github.com/repos/zalando-stups/fullstop/pulls/356"}}},"pull_request":{"url":"https://api.github.com/repos/zalando-stups/fullstop/pulls/356","id":58914027,"html_url":"https://github.com/zalando-stups/fullstop/pull/356","diff_url":"https://github.com/zalando-stups/fullstop/pull/356.diff","patch_url":"https://github.com/zalando-stups/fullstop/pull/356.patch","issue_url":"https://api.github.com/repos/zalando-stups/fullstop/issues/356","number":356,"state":"open","locked":false,"title":"#348 complex whitelisting","user":{"login":"mrandi","id":4638986,"avatar_url":"https://avatars.githubusercontent.com/u/4638986?v=3","gravatar_id":"","url":"https://api.github.com/users/mrandi","html_url":"https://github.com/mrandi","followers_url":"https://api.github.com/users/mrandi/followers","following_url":"https://api.github.com/users/mrandi/following{/other_user}","gists_url":"https://api.github.com/users/mrandi/gists{/gist_id}","starred_url":"https://api.github.com/users/mrandi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrandi/subscriptions","organizations_url":"https://api.github.com/users/mrandi/orgs","repos_url":"https://api.github.com/users/mrandi/repos","events_url":"https://api.github.com/users/mrandi/events{/privacy}","received_events_url":"https://api.github.com/users/mrandi/received_events","type":"User","site_admin":false},"body":"fixes #348 ","created_at":"2016-02-10T16:20:38Z","updated_at":"2016-02-10T16:55:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0aacb233505a6f4a1c8dfd326cf46b76f933430c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zalando-stups/fullstop/pulls/356/commits","review_comments_url":"https://api.github.com/repos/zalando-stups/fullstop/pulls/356/comments","review_comment_url":"https://api.github.com/repos/zalando-stups/fullstop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando-stups/fullstop/issues/356/comments","statuses_url":"https://api.github.com/repos/zalando-stups/fullstop/statuses/9c7d58ecf24298ffcc4707db7058203092e34495","head":{"label":"zalando-stups:#348-complex-whitelisting","ref":"#348-complex-whitelisting","sha":"9c7d58ecf24298ffcc4707db7058203092e34495","user":{"login":"zalando-stups","id":11431876,"avatar_url":"https://avatars.githubusercontent.com/u/11431876?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-stups","html_url":"https://github.com/zalando-stups","followers_url":"https://api.github.com/users/zalando-stups/followers","following_url":"https://api.github.com/users/zalando-stups/following{/other_user}","gists_url":"https://api.github.com/users/zalando-stups/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-stups/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-stups/subscriptions","organizations_url":"https://api.github.com/users/zalando-stups/orgs","repos_url":"https://api.github.com/users/zalando-stups/repos","events_url":"https://api.github.com/users/zalando-stups/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-stups/received_events","type":"Organization","site_admin":false},"repo":{"id":32521417,"name":"fullstop","full_name":"zalando-stups/fullstop","owner":{"login":"zalando-stups","id":11431876,"avatar_url":"https://avatars.githubusercontent.com/u/11431876?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-stups","html_url":"https://github.com/zalando-stups","followers_url":"https://api.github.com/users/zalando-stups/followers","following_url":"https://api.github.com/users/zalando-stups/following{/other_user}","gists_url":"https://api.github.com/users/zalando-stups/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-stups/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-stups/subscriptions","organizations_url":"https://api.github.com/users/zalando-stups/orgs","repos_url":"https://api.github.com/users/zalando-stups/repos","events_url":"https://api.github.com/users/zalando-stups/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-stups/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-stups/fullstop","description":"Audit reporting: collect violations across all AWS accounts","fork":false,"url":"https://api.github.com/repos/zalando-stups/fullstop","forks_url":"https://api.github.com/repos/zalando-stups/fullstop/forks","keys_url":"https://api.github.com/repos/zalando-stups/fullstop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-stups/fullstop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-stups/fullstop/teams","hooks_url":"https://api.github.com/repos/zalando-stups/fullstop/hooks","issue_events_url":"https://api.github.com/repos/zalando-stups/fullstop/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-stups/fullstop/events","assignees_url":"https://api.github.com/repos/zalando-stups/fullstop/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-stups/fullstop/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-stups/fullstop/tags","blobs_url":"https://api.github.com/repos/zalando-stups/fullstop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-stups/fullstop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-stups/fullstop/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-stups/fullstop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-stups/fullstop/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-stups/fullstop/languages","stargazers_url":"https://api.github.com/repos/zalando-stups/fullstop/stargazers","contributors_url":"https://api.github.com/repos/zalando-stups/fullstop/contributors","subscribers_url":"https://api.github.com/repos/zalando-stups/fullstop/subscribers","subscription_url":"https://api.github.com/repos/zalando-stups/fullstop/subscription","commits_url":"https://api.github.com/repos/zalando-stups/fullstop/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-stups/fullstop/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-stups/fullstop/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-stups/fullstop/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-stups/fullstop/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-stups/fullstop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-stups/fullstop/merges","archive_url":"https://api.github.com/repos/zalando-stups/fullstop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-stups/fullstop/downloads","issues_url":"https://api.github.com/repos/zalando-stups/fullstop/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-stups/fullstop/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-stups/fullstop/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-stups/fullstop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-stups/fullstop/labels{/name}","releases_url":"https://api.github.com/repos/zalando-stups/fullstop/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-stups/fullstop/deployments","created_at":"2015-03-19T12:59:49Z","updated_at":"2016-02-08T21:20:50Z","pushed_at":"2016-02-10T16:33:55Z","git_url":"git://github.com/zalando-stups/fullstop.git","ssh_url":"git@github.com:zalando-stups/fullstop.git","clone_url":"https://github.com/zalando-stups/fullstop.git","svn_url":"https://github.com/zalando-stups/fullstop","homepage":"https://docs.stups.io/en/latest/components/fullstop.html","size":3432,"stargazers_count":18,"watchers_count":18,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":16,"forks":6,"open_issues":16,"watchers":18,"default_branch":"master"}},"base":{"label":"zalando-stups:master","ref":"master","sha":"fd3b01cb4d19490a924e01866acb31507b742e88","user":{"login":"zalando-stups","id":11431876,"avatar_url":"https://avatars.githubusercontent.com/u/11431876?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-stups","html_url":"https://github.com/zalando-stups","followers_url":"https://api.github.com/users/zalando-stups/followers","following_url":"https://api.github.com/users/zalando-stups/following{/other_user}","gists_url":"https://api.github.com/users/zalando-stups/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-stups/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-stups/subscriptions","organizations_url":"https://api.github.com/users/zalando-stups/orgs","repos_url":"https://api.github.com/users/zalando-stups/repos","events_url":"https://api.github.com/users/zalando-stups/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-stups/received_events","type":"Organization","site_admin":false},"repo":{"id":32521417,"name":"fullstop","full_name":"zalando-stups/fullstop","owner":{"login":"zalando-stups","id":11431876,"avatar_url":"https://avatars.githubusercontent.com/u/11431876?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-stups","html_url":"https://github.com/zalando-stups","followers_url":"https://api.github.com/users/zalando-stups/followers","following_url":"https://api.github.com/users/zalando-stups/following{/other_user}","gists_url":"https://api.github.com/users/zalando-stups/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-stups/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-stups/subscriptions","organizations_url":"https://api.github.com/users/zalando-stups/orgs","repos_url":"https://api.github.com/users/zalando-stups/repos","events_url":"https://api.github.com/users/zalando-stups/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-stups/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-stups/fullstop","description":"Audit reporting: collect violations across all AWS accounts","fork":false,"url":"https://api.github.com/repos/zalando-stups/fullstop","forks_url":"https://api.github.com/repos/zalando-stups/fullstop/forks","keys_url":"https://api.github.com/repos/zalando-stups/fullstop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-stups/fullstop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-stups/fullstop/teams","hooks_url":"https://api.github.com/repos/zalando-stups/fullstop/hooks","issue_events_url":"https://api.github.com/repos/zalando-stups/fullstop/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-stups/fullstop/events","assignees_url":"https://api.github.com/repos/zalando-stups/fullstop/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-stups/fullstop/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-stups/fullstop/tags","blobs_url":"https://api.github.com/repos/zalando-stups/fullstop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-stups/fullstop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-stups/fullstop/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-stups/fullstop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-stups/fullstop/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-stups/fullstop/languages","stargazers_url":"https://api.github.com/repos/zalando-stups/fullstop/stargazers","contributors_url":"https://api.github.com/repos/zalando-stups/fullstop/contributors","subscribers_url":"https://api.github.com/repos/zalando-stups/fullstop/subscribers","subscription_url":"https://api.github.com/repos/zalando-stups/fullstop/subscription","commits_url":"https://api.github.com/repos/zalando-stups/fullstop/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-stups/fullstop/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-stups/fullstop/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-stups/fullstop/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-stups/fullstop/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-stups/fullstop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-stups/fullstop/merges","archive_url":"https://api.github.com/repos/zalando-stups/fullstop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-stups/fullstop/downloads","issues_url":"https://api.github.com/repos/zalando-stups/fullstop/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-stups/fullstop/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-stups/fullstop/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-stups/fullstop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-stups/fullstop/labels{/name}","releases_url":"https://api.github.com/repos/zalando-stups/fullstop/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-stups/fullstop/deployments","created_at":"2015-03-19T12:59:49Z","updated_at":"2016-02-08T21:20:50Z","pushed_at":"2016-02-10T16:33:55Z","git_url":"git://github.com/zalando-stups/fullstop.git","ssh_url":"git@github.com:zalando-stups/fullstop.git","clone_url":"https://github.com/zalando-stups/fullstop.git","svn_url":"https://github.com/zalando-stups/fullstop","homepage":"https://docs.stups.io/en/latest/components/fullstop.html","size":3432,"stargazers_count":18,"watchers_count":18,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":16,"forks":6,"open_issues":16,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando-stups/fullstop/pulls/356"},"html":{"href":"https://github.com/zalando-stups/fullstop/pull/356"},"issue":{"href":"https://api.github.com/repos/zalando-stups/fullstop/issues/356"},"comments":{"href":"https://api.github.com/repos/zalando-stups/fullstop/issues/356/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando-stups/fullstop/pulls/356/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando-stups/fullstop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando-stups/fullstop/pulls/356/commits"},"statuses":{"href":"https://api.github.com/repos/zalando-stups/fullstop/statuses/9c7d58ecf24298ffcc4707db7058203092e34495"}}}}