{"action":"created","comment":{"url":"https://api.github.com/repos/junit-team/junit4/pulls/comments/64484523","id":64484523,"diff_hunk":"@@ -37,72 +37,73 @@\n  * @since 4.5\n  */\n public abstract class RunnerBuilder {\n-    private final Set<Class<?>> parents = new HashSet<Class<?>>();\n+  private final Set<Class<?>> parents = new HashSet<Class<?>>();\n \n-    /**\n-     * Override to calculate the correct runner for a test class at runtime.\n-     *\n-     * @param testClass class to be run\n-     * @return a Runner\n-     * @throws Throwable if a runner cannot be constructed\n-     */\n-    public abstract Runner runnerForClass(Class<?> testClass) throws Throwable;\n+  /**\n+   * Override to calculate the correct runner for a test class at runtime.\n+   *\n+   * @param testClass class to be run\n+   * @return a Runner\n+   * @throws Throwable if a runner cannot be constructed\n+   */\n+  public abstract Runner runnerForClass(Class<?> testClass) throws Throwable;\n \n-    /**\n-     * Always returns a runner, even if it is just one that prints an error instead of running tests.\n-     *\n-     * @param testClass class to be run\n-     * @return a Runner\n-     */\n-    public Runner safeRunnerForClass(Class<?> testClass) {\n-        try {\n-            return runnerForClass(testClass);\n-        } catch (Throwable e) {\n-            return new ErrorReportingRunner(testClass, e);\n-        }\n+  /**\n+   * Always returns a runner or null.","path":"src/main/java/org/junit/runners/model/RunnerBuilder.java","position":null,"original_position":52,"commit_id":"4485580a051849407d9bea347785e51fdc8586fd","original_commit_id":"1e79ade142be8de39f9d83d01049975bbaacf6f4","user":{"login":"PeterWippermann","id":12392888,"avatar_url":"https://avatars.githubusercontent.com/u/12392888?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterWippermann","html_url":"https://github.com/PeterWippermann","followers_url":"https://api.github.com/users/PeterWippermann/followers","following_url":"https://api.github.com/users/PeterWippermann/following{/other_user}","gists_url":"https://api.github.com/users/PeterWippermann/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterWippermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterWippermann/subscriptions","organizations_url":"https://api.github.com/users/PeterWippermann/orgs","repos_url":"https://api.github.com/users/PeterWippermann/repos","events_url":"https://api.github.com/users/PeterWippermann/events{/privacy}","received_events_url":"https://api.github.com/users/PeterWippermann/received_events","type":"User","site_admin":false},"body":"@kcooney \r\nWhile debugging the code I saw `null` values.\r\nThis explains the null check in [AllDefaultPossibilitiesBuilder](https://github.com/junit-team/junit4/blob/24b8ee0bec2f2761b479bdd989275f19597955a3/src/main/java/org/junit/internal/builders/AllDefaultPossibilitiesBuilder.java#L25-L30)","created_at":"2016-05-24T22:14:51Z","updated_at":"2016-05-24T22:14:51Z","html_url":"https://github.com/junit-team/junit4/pull/1306#discussion_r64484523","pull_request_url":"https://api.github.com/repos/junit-team/junit4/pulls/1306","_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/comments/64484523"},"html":{"href":"https://github.com/junit-team/junit4/pull/1306#discussion_r64484523"},"pull_request":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/1306"}}},"pull_request":{"url":"https://api.github.com/repos/junit-team/junit4/pulls/1306","id":71168106,"html_url":"https://github.com/junit-team/junit4/pull/1306","diff_url":"https://github.com/junit-team/junit4/pull/1306.diff","patch_url":"https://github.com/junit-team/junit4/pull/1306.patch","issue_url":"https://api.github.com/repos/junit-team/junit4/issues/1306","number":1306,"state":"open","locked":false,"title":"Improve JavaDoc of RunnerBuilder; Update reference to Google's code style","user":{"login":"PeterWippermann","id":12392888,"avatar_url":"https://avatars.githubusercontent.com/u/12392888?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterWippermann","html_url":"https://github.com/PeterWippermann","followers_url":"https://api.github.com/users/PeterWippermann/followers","following_url":"https://api.github.com/users/PeterWippermann/following{/other_user}","gists_url":"https://api.github.com/users/PeterWippermann/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterWippermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterWippermann/subscriptions","organizations_url":"https://api.github.com/users/PeterWippermann/orgs","repos_url":"https://api.github.com/users/PeterWippermann/repos","events_url":"https://api.github.com/users/PeterWippermann/events{/privacy}","received_events_url":"https://api.github.com/users/PeterWippermann/received_events","type":"User","site_admin":false},"body":"Clarified the JavaDoc in RunnerBuilder that I found a bit confusing while debugging the code.\r\nIn the course of that change I also found that the URL to Google's code style was out-of-date.","created_at":"2016-05-24T07:12:46Z","updated_at":"2016-05-24T22:14:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa2841c3f4388fcb29cade9fcc8c5bc91d1f9440","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/junit-team/junit4/pulls/1306/commits","review_comments_url":"https://api.github.com/repos/junit-team/junit4/pulls/1306/comments","review_comment_url":"https://api.github.com/repos/junit-team/junit4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/junit-team/junit4/issues/1306/comments","statuses_url":"https://api.github.com/repos/junit-team/junit4/statuses/4485580a051849407d9bea347785e51fdc8586fd","head":{"label":"PeterWippermann:improve_javadoc","ref":"improve_javadoc","sha":"4485580a051849407d9bea347785e51fdc8586fd","user":{"login":"PeterWippermann","id":12392888,"avatar_url":"https://avatars.githubusercontent.com/u/12392888?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterWippermann","html_url":"https://github.com/PeterWippermann","followers_url":"https://api.github.com/users/PeterWippermann/followers","following_url":"https://api.github.com/users/PeterWippermann/following{/other_user}","gists_url":"https://api.github.com/users/PeterWippermann/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterWippermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterWippermann/subscriptions","organizations_url":"https://api.github.com/users/PeterWippermann/orgs","repos_url":"https://api.github.com/users/PeterWippermann/repos","events_url":"https://api.github.com/users/PeterWippermann/events{/privacy}","received_events_url":"https://api.github.com/users/PeterWippermann/received_events","type":"User","site_admin":false},"repo":{"id":59547042,"name":"junit4","full_name":"PeterWippermann/junit4","owner":{"login":"PeterWippermann","id":12392888,"avatar_url":"https://avatars.githubusercontent.com/u/12392888?v=3","gravatar_id":"","url":"https://api.github.com/users/PeterWippermann","html_url":"https://github.com/PeterWippermann","followers_url":"https://api.github.com/users/PeterWippermann/followers","following_url":"https://api.github.com/users/PeterWippermann/following{/other_user}","gists_url":"https://api.github.com/users/PeterWippermann/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterWippermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterWippermann/subscriptions","organizations_url":"https://api.github.com/users/PeterWippermann/orgs","repos_url":"https://api.github.com/users/PeterWippermann/repos","events_url":"https://api.github.com/users/PeterWippermann/events{/privacy}","received_events_url":"https://api.github.com/users/PeterWippermann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PeterWippermann/junit4","description":"A programmer-oriented testing framework for Java.","fork":true,"url":"https://api.github.com/repos/PeterWippermann/junit4","forks_url":"https://api.github.com/repos/PeterWippermann/junit4/forks","keys_url":"https://api.github.com/repos/PeterWippermann/junit4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PeterWippermann/junit4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PeterWippermann/junit4/teams","hooks_url":"https://api.github.com/repos/PeterWippermann/junit4/hooks","issue_events_url":"https://api.github.com/repos/PeterWippermann/junit4/issues/events{/number}","events_url":"https://api.github.com/repos/PeterWippermann/junit4/events","assignees_url":"https://api.github.com/repos/PeterWippermann/junit4/assignees{/user}","branches_url":"https://api.github.com/repos/PeterWippermann/junit4/branches{/branch}","tags_url":"https://api.github.com/repos/PeterWippermann/junit4/tags","blobs_url":"https://api.github.com/repos/PeterWippermann/junit4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PeterWippermann/junit4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PeterWippermann/junit4/git/refs{/sha}","trees_url":"https://api.github.com/repos/PeterWippermann/junit4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PeterWippermann/junit4/statuses/{sha}","languages_url":"https://api.github.com/repos/PeterWippermann/junit4/languages","stargazers_url":"https://api.github.com/repos/PeterWippermann/junit4/stargazers","contributors_url":"https://api.github.com/repos/PeterWippermann/junit4/contributors","subscribers_url":"https://api.github.com/repos/PeterWippermann/junit4/subscribers","subscription_url":"https://api.github.com/repos/PeterWippermann/junit4/subscription","commits_url":"https://api.github.com/repos/PeterWippermann/junit4/commits{/sha}","git_commits_url":"https://api.github.com/repos/PeterWippermann/junit4/git/commits{/sha}","comments_url":"https://api.github.com/repos/PeterWippermann/junit4/comments{/number}","issue_comment_url":"https://api.github.com/repos/PeterWippermann/junit4/issues/comments{/number}","contents_url":"https://api.github.com/repos/PeterWippermann/junit4/contents/{+path}","compare_url":"https://api.github.com/repos/PeterWippermann/junit4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PeterWippermann/junit4/merges","archive_url":"https://api.github.com/repos/PeterWippermann/junit4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PeterWippermann/junit4/downloads","issues_url":"https://api.github.com/repos/PeterWippermann/junit4/issues{/number}","pulls_url":"https://api.github.com/repos/PeterWippermann/junit4/pulls{/number}","milestones_url":"https://api.github.com/repos/PeterWippermann/junit4/milestones{/number}","notifications_url":"https://api.github.com/repos/PeterWippermann/junit4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PeterWippermann/junit4/labels{/name}","releases_url":"https://api.github.com/repos/PeterWippermann/junit4/releases{/id}","deployments_url":"https://api.github.com/repos/PeterWippermann/junit4/deployments","created_at":"2016-05-24T06:38:22Z","updated_at":"2016-05-24T06:38:24Z","pushed_at":"2016-05-24T22:03:55Z","git_url":"git://github.com/PeterWippermann/junit4.git","ssh_url":"git@github.com:PeterWippermann/junit4.git","clone_url":"https://github.com/PeterWippermann/junit4.git","svn_url":"https://github.com/PeterWippermann/junit4","homepage":"http://junit.org/junit4/","size":21744,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"junit-team:master","ref":"master","sha":"24b8ee0bec2f2761b479bdd989275f19597955a3","user":{"login":"junit-team","id":874086,"avatar_url":"https://avatars.githubusercontent.com/u/874086?v=3","gravatar_id":"","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"repo":{"id":106310,"name":"junit4","full_name":"junit-team/junit4","owner":{"login":"junit-team","id":874086,"avatar_url":"https://avatars.githubusercontent.com/u/874086?v=3","gravatar_id":"","url":"https://api.github.com/users/junit-team","html_url":"https://github.com/junit-team","followers_url":"https://api.github.com/users/junit-team/followers","following_url":"https://api.github.com/users/junit-team/following{/other_user}","gists_url":"https://api.github.com/users/junit-team/gists{/gist_id}","starred_url":"https://api.github.com/users/junit-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junit-team/subscriptions","organizations_url":"https://api.github.com/users/junit-team/orgs","repos_url":"https://api.github.com/users/junit-team/repos","events_url":"https://api.github.com/users/junit-team/events{/privacy}","received_events_url":"https://api.github.com/users/junit-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/junit-team/junit4","description":"A programmer-oriented testing framework for Java.","fork":false,"url":"https://api.github.com/repos/junit-team/junit4","forks_url":"https://api.github.com/repos/junit-team/junit4/forks","keys_url":"https://api.github.com/repos/junit-team/junit4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junit-team/junit4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junit-team/junit4/teams","hooks_url":"https://api.github.com/repos/junit-team/junit4/hooks","issue_events_url":"https://api.github.com/repos/junit-team/junit4/issues/events{/number}","events_url":"https://api.github.com/repos/junit-team/junit4/events","assignees_url":"https://api.github.com/repos/junit-team/junit4/assignees{/user}","branches_url":"https://api.github.com/repos/junit-team/junit4/branches{/branch}","tags_url":"https://api.github.com/repos/junit-team/junit4/tags","blobs_url":"https://api.github.com/repos/junit-team/junit4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junit-team/junit4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junit-team/junit4/git/refs{/sha}","trees_url":"https://api.github.com/repos/junit-team/junit4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junit-team/junit4/statuses/{sha}","languages_url":"https://api.github.com/repos/junit-team/junit4/languages","stargazers_url":"https://api.github.com/repos/junit-team/junit4/stargazers","contributors_url":"https://api.github.com/repos/junit-team/junit4/contributors","subscribers_url":"https://api.github.com/repos/junit-team/junit4/subscribers","subscription_url":"https://api.github.com/repos/junit-team/junit4/subscription","commits_url":"https://api.github.com/repos/junit-team/junit4/commits{/sha}","git_commits_url":"https://api.github.com/repos/junit-team/junit4/git/commits{/sha}","comments_url":"https://api.github.com/repos/junit-team/junit4/comments{/number}","issue_comment_url":"https://api.github.com/repos/junit-team/junit4/issues/comments{/number}","contents_url":"https://api.github.com/repos/junit-team/junit4/contents/{+path}","compare_url":"https://api.github.com/repos/junit-team/junit4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junit-team/junit4/merges","archive_url":"https://api.github.com/repos/junit-team/junit4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junit-team/junit4/downloads","issues_url":"https://api.github.com/repos/junit-team/junit4/issues{/number}","pulls_url":"https://api.github.com/repos/junit-team/junit4/pulls{/number}","milestones_url":"https://api.github.com/repos/junit-team/junit4/milestones{/number}","notifications_url":"https://api.github.com/repos/junit-team/junit4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junit-team/junit4/labels{/name}","releases_url":"https://api.github.com/repos/junit-team/junit4/releases{/id}","deployments_url":"https://api.github.com/repos/junit-team/junit4/deployments","created_at":"2009-01-13T03:41:26Z","updated_at":"2016-05-24T12:53:14Z","pushed_at":"2016-05-24T22:03:55Z","git_url":"git://github.com/junit-team/junit4.git","ssh_url":"git@github.com:junit-team/junit4.git","clone_url":"https://github.com/junit-team/junit4.git","svn_url":"https://github.com/junit-team/junit4","homepage":"http://junit.org/junit4/","size":36687,"stargazers_count":4879,"watchers_count":4879,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1917,"mirror_url":null,"open_issues_count":178,"forks":1917,"open_issues":178,"watchers":4879,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/1306"},"html":{"href":"https://github.com/junit-team/junit4/pull/1306"},"issue":{"href":"https://api.github.com/repos/junit-team/junit4/issues/1306"},"comments":{"href":"https://api.github.com/repos/junit-team/junit4/issues/1306/comments"},"review_comments":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/1306/comments"},"review_comment":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/junit-team/junit4/pulls/1306/commits"},"statuses":{"href":"https://api.github.com/repos/junit-team/junit4/statuses/4485580a051849407d9bea347785e51fdc8586fd"}}}}
{"actor":{"display_login":"PeterWippermann"}}