{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/7525","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/7525/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/7525/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/7525/events","html_url":"https://github.com/openshift/origin/pull/7525","id":135452510,"number":7525,"title":"[WIP] Submit forms on enter","user":{"login":"jhadvig","id":1668218,"avatar_url":"https://avatars.githubusercontent.com/u/1668218?v=3","gravatar_id":"","url":"https://api.github.com/users/jhadvig","html_url":"https://github.com/jhadvig","followers_url":"https://api.github.com/users/jhadvig/followers","following_url":"https://api.github.com/users/jhadvig/following{/other_user}","gists_url":"https://api.github.com/users/jhadvig/gists{/gist_id}","starred_url":"https://api.github.com/users/jhadvig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhadvig/subscriptions","organizations_url":"https://api.github.com/users/jhadvig/orgs","repos_url":"https://api.github.com/users/jhadvig/repos","events_url":"https://api.github.com/users/jhadvig/events{/privacy}","received_events_url":"https://api.github.com/users/jhadvig/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-02-22T15:33:05Z","updated_at":"2016-02-22T15:57:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/7525","html_url":"https://github.com/openshift/origin/pull/7525","diff_url":"https://github.com/openshift/origin/pull/7525.diff","patch_url":"https://github.com/openshift/origin/pull/7525.patch"},"body":"Adding possibility to submit forms by hitting Enter. For this I had to create a standalone `on-enter` directive which will check if the form is valid and then calls the action that will submit the form. \r\nHad to update the osc-key-values.html with it since when running multiple instances of oscKeyValues form the data are added to the first one, not the one the data are submitted to (eg. imageSource directories && envVars in bc editor).\r\nUnfortunately the new directive has to be added to every `input` field on which we want the form submission to occur when hitting Enter.\r\nI will also update the `fromImage` page form once we decide we wanna go this direction, or some other one(thats why WIP ...)\r\nWas trying to us the `ng-submit` directive but that work well only in case of single `input` field\r\n\r\n@spadgett PTAL"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/187243308","html_url":"https://github.com/openshift/origin/pull/7525#issuecomment-187243308","issue_url":"https://api.github.com/repos/openshift/origin/issues/7525","id":187243308,"user":{"login":"jhadvig","id":1668218,"avatar_url":"https://avatars.githubusercontent.com/u/1668218?v=3","gravatar_id":"","url":"https://api.github.com/users/jhadvig","html_url":"https://github.com/jhadvig","followers_url":"https://api.github.com/users/jhadvig/followers","following_url":"https://api.github.com/users/jhadvig/following{/other_user}","gists_url":"https://api.github.com/users/jhadvig/gists{/gist_id}","starred_url":"https://api.github.com/users/jhadvig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhadvig/subscriptions","organizations_url":"https://api.github.com/users/jhadvig/orgs","repos_url":"https://api.github.com/users/jhadvig/repos","events_url":"https://api.github.com/users/jhadvig/events{/privacy}","received_events_url":"https://api.github.com/users/jhadvig/received_events","type":"User","site_admin":false},"created_at":"2016-02-22T15:57:55Z","updated_at":"2016-02-22T15:57:55Z","body":"@liggitt I've tried that but that didnt help."}}