{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/14760","repository_url":"https://api.github.com/repos/dotnet/roslyn","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/14760/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/14760/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/14760/events","html_url":"https://github.com/dotnet/roslyn/issues/14760","id":185530521,"number":14760,"title":"\"strict mode\" compare-struct-to-null doesn't seem to be working.","user":{"login":"CyrusNajmabadi","id":4564579,"avatar_url":"https://avatars.githubusercontent.com/u/4564579?v=3","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-10-26T22:46:51Z","updated_at":"2016-10-27T19:24:37Z","closed_at":null,"body":"I've made the mistake in Roslyn several times of comparing a struct to null.  Specifically, I've compared ImmutableArray's to null. This often happens when refactoring existing code to move from a reference-collection to ImmutableArray.  These weren't caught in Roslyn even though @gafter believes they should have.\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/256743930","html_url":"https://github.com/dotnet/roslyn/issues/14760#issuecomment-256743930","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/14760","id":256743930,"user":{"login":"gafter","id":3804346,"avatar_url":"https://avatars.githubusercontent.com/u/3804346?v=3","gravatar_id":"","url":"https://api.github.com/users/gafter","html_url":"https://github.com/gafter","followers_url":"https://api.github.com/users/gafter/followers","following_url":"https://api.github.com/users/gafter/following{/other_user}","gists_url":"https://api.github.com/users/gafter/gists{/gist_id}","starred_url":"https://api.github.com/users/gafter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gafter/subscriptions","organizations_url":"https://api.github.com/users/gafter/orgs","repos_url":"https://api.github.com/users/gafter/repos","events_url":"https://api.github.com/users/gafter/events{/privacy}","received_events_url":"https://api.github.com/users/gafter/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T19:24:37Z","updated_at":"2016-10-27T19:24:37Z","body":"@CyrusNajmabadi Code such as\r\n```cs\r\nif (1 == null) {}\r\n```\r\nis legal C# because the language specification allows it (by virtue of the spec-required `operator ==(int?, int?)`, thereby requiring a conforming implementation to compile that code. But we certainly can give a warning."}}
{"actor":{"display_login":"gafter"}}