{"action":"closed","number":2694,"pull_request":{"url":"https://api.github.com/repos/laravel/docs/pulls/2694","id":86246893,"html_url":"https://github.com/laravel/docs/pull/2694","diff_url":"https://github.com/laravel/docs/pull/2694.diff","patch_url":"https://github.com/laravel/docs/pull/2694.patch","issue_url":"https://api.github.com/repos/laravel/docs/issues/2694","number":2694,"state":"closed","locked":false,"title":"PhpRedis Support","user":{"login":"tillkruss","id":665029,"avatar_url":"https://avatars.githubusercontent.com/u/665029?v=3","gravatar_id":"","url":"https://api.github.com/users/tillkruss","html_url":"https://github.com/tillkruss","followers_url":"https://api.github.com/users/tillkruss/followers","following_url":"https://api.github.com/users/tillkruss/following{/other_user}","gists_url":"https://api.github.com/users/tillkruss/gists{/gist_id}","starred_url":"https://api.github.com/users/tillkruss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillkruss/subscriptions","organizations_url":"https://api.github.com/users/tillkruss/orgs","repos_url":"https://api.github.com/users/tillkruss/repos","events_url":"https://api.github.com/users/tillkruss/events{/privacy}","received_events_url":"https://api.github.com/users/tillkruss/received_events","type":"User","site_admin":false},"body":"What's still missing from the documentation is the difference in connection parameters.\r\n\r\nPredis and PhpRedis both support:\r\n\r\n- `host`\r\n- `password`\r\n- `port`\r\n- `database`\r\n- `timeout`\r\n- `persistent`\r\n\r\nPredis supports these:\r\n\r\n- `scheme`\r\n- `path`\r\n- `async`\r\n- `read_write_timeout`\r\n- `alias`\r\n- `weight`\r\n- `iterable_multibulk`\r\n- `throw_errors`\r\n\r\nPhpRedis supports these:\r\n\r\n- `read_timeout`\r\n- `prefix`\r\n\r\nEspecially the `read_write_timeout` and `read_timeout` is noticeable. I tried to prevent that, but https://github.com/laravel/framework/commit/bae60487cd2749eb57d2e2eeb7bf8c3ce71ef3ec#diff-dbfdb06f6a76b9f93f18f77fa7f4b298 reverted my attempt.\r\n\r\nI'm not quite sure how to mention that without adding new sections. Any suggestions?","created_at":"2016-09-21T21:43:06Z","updated_at":"2016-09-27T16:20:22Z","closed_at":"2016-09-27T16:20:22Z","merged_at":"2016-09-27T16:20:22Z","merge_commit_sha":"4e05103afa21abe81b4611d791145d0c88fe7334","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/laravel/docs/pulls/2694/commits","review_comments_url":"https://api.github.com/repos/laravel/docs/pulls/2694/comments","review_comment_url":"https://api.github.com/repos/laravel/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/docs/issues/2694/comments","statuses_url":"https://api.github.com/repos/laravel/docs/statuses/4e05103afa21abe81b4611d791145d0c88fe7334","head":{"label":"tillkruss:patch-1","ref":"patch-1","sha":"4e05103afa21abe81b4611d791145d0c88fe7334","user":{"login":"tillkruss","id":665029,"avatar_url":"https://avatars.githubusercontent.com/u/665029?v=3","gravatar_id":"","url":"https://api.github.com/users/tillkruss","html_url":"https://github.com/tillkruss","followers_url":"https://api.github.com/users/tillkruss/followers","following_url":"https://api.github.com/users/tillkruss/following{/other_user}","gists_url":"https://api.github.com/users/tillkruss/gists{/gist_id}","starred_url":"https://api.github.com/users/tillkruss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillkruss/subscriptions","organizations_url":"https://api.github.com/users/tillkruss/orgs","repos_url":"https://api.github.com/users/tillkruss/repos","events_url":"https://api.github.com/users/tillkruss/events{/privacy}","received_events_url":"https://api.github.com/users/tillkruss/received_events","type":"User","site_admin":false},"repo":{"id":60659414,"name":"docs","full_name":"tillkruss/docs","owner":{"login":"tillkruss","id":665029,"avatar_url":"https://avatars.githubusercontent.com/u/665029?v=3","gravatar_id":"","url":"https://api.github.com/users/tillkruss","html_url":"https://github.com/tillkruss","followers_url":"https://api.github.com/users/tillkruss/followers","following_url":"https://api.github.com/users/tillkruss/following{/other_user}","gists_url":"https://api.github.com/users/tillkruss/gists{/gist_id}","starred_url":"https://api.github.com/users/tillkruss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tillkruss/subscriptions","organizations_url":"https://api.github.com/users/tillkruss/orgs","repos_url":"https://api.github.com/users/tillkruss/repos","events_url":"https://api.github.com/users/tillkruss/events{/privacy}","received_events_url":"https://api.github.com/users/tillkruss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tillkruss/docs","description":"","fork":true,"url":"https://api.github.com/repos/tillkruss/docs","forks_url":"https://api.github.com/repos/tillkruss/docs/forks","keys_url":"https://api.github.com/repos/tillkruss/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tillkruss/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tillkruss/docs/teams","hooks_url":"https://api.github.com/repos/tillkruss/docs/hooks","issue_events_url":"https://api.github.com/repos/tillkruss/docs/issues/events{/number}","events_url":"https://api.github.com/repos/tillkruss/docs/events","assignees_url":"https://api.github.com/repos/tillkruss/docs/assignees{/user}","branches_url":"https://api.github.com/repos/tillkruss/docs/branches{/branch}","tags_url":"https://api.github.com/repos/tillkruss/docs/tags","blobs_url":"https://api.github.com/repos/tillkruss/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tillkruss/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tillkruss/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tillkruss/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tillkruss/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/tillkruss/docs/languages","stargazers_url":"https://api.github.com/repos/tillkruss/docs/stargazers","contributors_url":"https://api.github.com/repos/tillkruss/docs/contributors","subscribers_url":"https://api.github.com/repos/tillkruss/docs/subscribers","subscription_url":"https://api.github.com/repos/tillkruss/docs/subscription","commits_url":"https://api.github.com/repos/tillkruss/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tillkruss/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tillkruss/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tillkruss/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tillkruss/docs/contents/{+path}","compare_url":"https://api.github.com/repos/tillkruss/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tillkruss/docs/merges","archive_url":"https://api.github.com/repos/tillkruss/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tillkruss/docs/downloads","issues_url":"https://api.github.com/repos/tillkruss/docs/issues{/number}","pulls_url":"https://api.github.com/repos/tillkruss/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/tillkruss/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/tillkruss/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tillkruss/docs/labels{/name}","releases_url":"https://api.github.com/repos/tillkruss/docs/releases{/id}","deployments_url":"https://api.github.com/repos/tillkruss/docs/deployments","created_at":"2016-06-08T01:39:55Z","updated_at":"2016-06-07T13:42:15Z","pushed_at":"2016-09-22T18:56:42Z","git_url":"git://github.com/tillkruss/docs.git","ssh_url":"git@github.com:tillkruss/docs.git","clone_url":"https://github.com/tillkruss/docs.git","svn_url":"https://github.com/tillkruss/docs","homepage":"","size":5270,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.2"}},"base":{"label":"laravel:master","ref":"master","sha":"6546bf1878b3c465ceefbfc7423aaa776ffe5a7b","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7546847,"name":"docs","full_name":"laravel/docs","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/docs","description":"","fork":false,"url":"https://api.github.com/repos/laravel/docs","forks_url":"https://api.github.com/repos/laravel/docs/forks","keys_url":"https://api.github.com/repos/laravel/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/docs/teams","hooks_url":"https://api.github.com/repos/laravel/docs/hooks","issue_events_url":"https://api.github.com/repos/laravel/docs/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/docs/events","assignees_url":"https://api.github.com/repos/laravel/docs/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/docs/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/docs/tags","blobs_url":"https://api.github.com/repos/laravel/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/docs/languages","stargazers_url":"https://api.github.com/repos/laravel/docs/stargazers","contributors_url":"https://api.github.com/repos/laravel/docs/contributors","subscribers_url":"https://api.github.com/repos/laravel/docs/subscribers","subscription_url":"https://api.github.com/repos/laravel/docs/subscription","commits_url":"https://api.github.com/repos/laravel/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/docs/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/docs/merges","archive_url":"https://api.github.com/repos/laravel/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/docs/downloads","issues_url":"https://api.github.com/repos/laravel/docs/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/docs/labels{/name}","releases_url":"https://api.github.com/repos/laravel/docs/releases{/id}","deployments_url":"https://api.github.com/repos/laravel/docs/deployments","created_at":"2013-01-10T19:08:45Z","updated_at":"2016-09-27T14:45:01Z","pushed_at":"2016-09-27T16:20:21Z","git_url":"git://github.com/laravel/docs.git","ssh_url":"git@github.com:laravel/docs.git","clone_url":"https://github.com/laravel/docs.git","svn_url":"https://github.com/laravel/docs","homepage":"","size":17418,"stargazers_count":791,"watchers_count":791,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1947,"mirror_url":null,"open_issues_count":36,"forks":1947,"open_issues":36,"watchers":791,"default_branch":"5.3"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/docs/pulls/2694"},"html":{"href":"https://github.com/laravel/docs/pull/2694"},"issue":{"href":"https://api.github.com/repos/laravel/docs/issues/2694"},"comments":{"href":"https://api.github.com/repos/laravel/docs/issues/2694/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/docs/pulls/2694/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/docs/pulls/2694/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/docs/statuses/4e05103afa21abe81b4611d791145d0c88fe7334"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"taylorotwell","id":463230,"avatar_url":"https://avatars.githubusercontent.com/u/463230?v=3","gravatar_id":"","url":"https://api.github.com/users/taylorotwell","html_url":"https://github.com/taylorotwell","followers_url":"https://api.github.com/users/taylorotwell/followers","following_url":"https://api.github.com/users/taylorotwell/following{/other_user}","gists_url":"https://api.github.com/users/taylorotwell/gists{/gist_id}","starred_url":"https://api.github.com/users/taylorotwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylorotwell/subscriptions","organizations_url":"https://api.github.com/users/taylorotwell/orgs","repos_url":"https://api.github.com/users/taylorotwell/repos","events_url":"https://api.github.com/users/taylorotwell/events{/privacy}","received_events_url":"https://api.github.com/users/taylorotwell/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":5,"additions":24,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"taylorotwell"}}