{"action":"created","comment":{"url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments/78211107","id":78211107,"diff_hunk":"@@ -139,4 +147,138 @@ protected void stopClient() {\n     // ... and convert it.\n     return target.convertFromBase64Png(base64);\n   }\n+\n+  @Override\n+  public TargetLocator switchTo() {\n+    if (this.getCommandExecutor() instanceof SafariDriverCommandExecutor) {\n+      return new LegacyRemoteTargetLocator();\n+    }\n+\n+    return super.switchTo();\n+  }\n+\n+  @Override\n+  public Options manage() {\n+    if (this.getCommandExecutor() instanceof SafariDriverCommandExecutor) {\n+      return new LegacyRemoteWebDriverOptions();\n+    }\n+\n+    return super.manage();\n+  }\n+\n+\n+  protected class LegacyRemoteTargetLocator extends RemoteTargetLocator {","path":"java/client/src/org/openqa/selenium/safari/SafariDriver.java","position":109,"original_position":109,"commit_id":"16f3e9e2098b563d88f7ddf4c2631837465d78a4","original_commit_id":"16f3e9e2098b563d88f7ddf4c2631837465d78a4","user":{"login":"jleyba","id":254985,"avatar_url":"https://avatars.githubusercontent.com/u/254985?v=3","gravatar_id":"","url":"https://api.github.com/users/jleyba","html_url":"https://github.com/jleyba","followers_url":"https://api.github.com/users/jleyba/followers","following_url":"https://api.github.com/users/jleyba/following{/other_user}","gists_url":"https://api.github.com/users/jleyba/gists{/gist_id}","starred_url":"https://api.github.com/users/jleyba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jleyba/subscriptions","organizations_url":"https://api.github.com/users/jleyba/orgs","repos_url":"https://api.github.com/users/jleyba/repos","events_url":"https://api.github.com/users/jleyba/events{/privacy}","received_events_url":"https://api.github.com/users/jleyba/received_events","type":"User","site_admin":false},"body":"Same for the other Legacy* classes.","created_at":"2016-09-09T16:42:27Z","updated_at":"2016-09-09T16:42:27Z","html_url":"https://github.com/SeleniumHQ/selenium/pull/2733#discussion_r78211107","pull_request_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/2733","_links":{"self":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments/78211107"},"html":{"href":"https://github.com/SeleniumHQ/selenium/pull/2733#discussion_r78211107"},"pull_request":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/2733"}}},"pull_request":{"url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/2733","id":84282801,"html_url":"https://github.com/SeleniumHQ/selenium/pull/2733","diff_url":"https://github.com/SeleniumHQ/selenium/pull/2733.diff","patch_url":"https://github.com/SeleniumHQ/selenium/pull/2733.patch","issue_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/2733","number":2733,"state":"open","locked":false,"title":"Fix legacy mode in SafariDriver","user":{"login":"pbi-qfs","id":14976238,"avatar_url":"https://avatars.githubusercontent.com/u/14976238?v=3","gravatar_id":"","url":"https://api.github.com/users/pbi-qfs","html_url":"https://github.com/pbi-qfs","followers_url":"https://api.github.com/users/pbi-qfs/followers","following_url":"https://api.github.com/users/pbi-qfs/following{/other_user}","gists_url":"https://api.github.com/users/pbi-qfs/gists{/gist_id}","starred_url":"https://api.github.com/users/pbi-qfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbi-qfs/subscriptions","organizations_url":"https://api.github.com/users/pbi-qfs/orgs","repos_url":"https://api.github.com/users/pbi-qfs/repos","events_url":"https://api.github.com/users/pbi-qfs/events{/privacy}","received_events_url":"https://api.github.com/users/pbi-qfs/received_events","type":"User","site_admin":false},"body":"- [x] By placing an `X` in the preceding checkbox, I verify that I have signed the [Contributor License Agreement](https://github.com/SeleniumHQ/selenium/blob/master/CONTRIBUTING.md#step-6-sign-the-cla)\r\n","created_at":"2016-09-07T11:27:46Z","updated_at":"2016-09-09T16:42:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddb591eb9a22e8d240a02004e4df21f18a39054d","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/SeleniumHQ/selenium/milestones/1","html_url":"https://github.com/SeleniumHQ/selenium/milestones/3.0","labels_url":"https://api.github.com/repos/SeleniumHQ/selenium/milestones/1/labels","id":1635032,"number":1,"title":"3.0","description":"","creator":{"login":"lukeis","id":926454,"avatar_url":"https://avatars.githubusercontent.com/u/926454?v=3","gravatar_id":"","url":"https://api.github.com/users/lukeis","html_url":"https://github.com/lukeis","followers_url":"https://api.github.com/users/lukeis/followers","following_url":"https://api.github.com/users/lukeis/following{/other_user}","gists_url":"https://api.github.com/users/lukeis/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeis/subscriptions","organizations_url":"https://api.github.com/users/lukeis/orgs","repos_url":"https://api.github.com/users/lukeis/repos","events_url":"https://api.github.com/users/lukeis/events{/privacy}","received_events_url":"https://api.github.com/users/lukeis/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":11,"state":"open","created_at":"2016-03-09T19:09:26Z","updated_at":"2016-09-09T16:21:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/2733/commits","review_comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/2733/comments","review_comment_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/2733/comments","statuses_url":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/16f3e9e2098b563d88f7ddf4c2631837465d78a4","head":{"label":"pbi-qfs:fix-legacy-safari","ref":"fix-legacy-safari","sha":"16f3e9e2098b563d88f7ddf4c2631837465d78a4","user":{"login":"pbi-qfs","id":14976238,"avatar_url":"https://avatars.githubusercontent.com/u/14976238?v=3","gravatar_id":"","url":"https://api.github.com/users/pbi-qfs","html_url":"https://github.com/pbi-qfs","followers_url":"https://api.github.com/users/pbi-qfs/followers","following_url":"https://api.github.com/users/pbi-qfs/following{/other_user}","gists_url":"https://api.github.com/users/pbi-qfs/gists{/gist_id}","starred_url":"https://api.github.com/users/pbi-qfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbi-qfs/subscriptions","organizations_url":"https://api.github.com/users/pbi-qfs/orgs","repos_url":"https://api.github.com/users/pbi-qfs/repos","events_url":"https://api.github.com/users/pbi-qfs/events{/privacy}","received_events_url":"https://api.github.com/users/pbi-qfs/received_events","type":"User","site_admin":false},"repo":{"id":67529016,"name":"selenium","full_name":"pbi-qfs/selenium","owner":{"login":"pbi-qfs","id":14976238,"avatar_url":"https://avatars.githubusercontent.com/u/14976238?v=3","gravatar_id":"","url":"https://api.github.com/users/pbi-qfs","html_url":"https://github.com/pbi-qfs","followers_url":"https://api.github.com/users/pbi-qfs/followers","following_url":"https://api.github.com/users/pbi-qfs/following{/other_user}","gists_url":"https://api.github.com/users/pbi-qfs/gists{/gist_id}","starred_url":"https://api.github.com/users/pbi-qfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbi-qfs/subscriptions","organizations_url":"https://api.github.com/users/pbi-qfs/orgs","repos_url":"https://api.github.com/users/pbi-qfs/repos","events_url":"https://api.github.com/users/pbi-qfs/events{/privacy}","received_events_url":"https://api.github.com/users/pbi-qfs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pbi-qfs/selenium","description":"A browser automation framework and ecosystem.","fork":true,"url":"https://api.github.com/repos/pbi-qfs/selenium","forks_url":"https://api.github.com/repos/pbi-qfs/selenium/forks","keys_url":"https://api.github.com/repos/pbi-qfs/selenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pbi-qfs/selenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pbi-qfs/selenium/teams","hooks_url":"https://api.github.com/repos/pbi-qfs/selenium/hooks","issue_events_url":"https://api.github.com/repos/pbi-qfs/selenium/issues/events{/number}","events_url":"https://api.github.com/repos/pbi-qfs/selenium/events","assignees_url":"https://api.github.com/repos/pbi-qfs/selenium/assignees{/user}","branches_url":"https://api.github.com/repos/pbi-qfs/selenium/branches{/branch}","tags_url":"https://api.github.com/repos/pbi-qfs/selenium/tags","blobs_url":"https://api.github.com/repos/pbi-qfs/selenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pbi-qfs/selenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pbi-qfs/selenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/pbi-qfs/selenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pbi-qfs/selenium/statuses/{sha}","languages_url":"https://api.github.com/repos/pbi-qfs/selenium/languages","stargazers_url":"https://api.github.com/repos/pbi-qfs/selenium/stargazers","contributors_url":"https://api.github.com/repos/pbi-qfs/selenium/contributors","subscribers_url":"https://api.github.com/repos/pbi-qfs/selenium/subscribers","subscription_url":"https://api.github.com/repos/pbi-qfs/selenium/subscription","commits_url":"https://api.github.com/repos/pbi-qfs/selenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/pbi-qfs/selenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/pbi-qfs/selenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/pbi-qfs/selenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/pbi-qfs/selenium/contents/{+path}","compare_url":"https://api.github.com/repos/pbi-qfs/selenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pbi-qfs/selenium/merges","archive_url":"https://api.github.com/repos/pbi-qfs/selenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pbi-qfs/selenium/downloads","issues_url":"https://api.github.com/repos/pbi-qfs/selenium/issues{/number}","pulls_url":"https://api.github.com/repos/pbi-qfs/selenium/pulls{/number}","milestones_url":"https://api.github.com/repos/pbi-qfs/selenium/milestones{/number}","notifications_url":"https://api.github.com/repos/pbi-qfs/selenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pbi-qfs/selenium/labels{/name}","releases_url":"https://api.github.com/repos/pbi-qfs/selenium/releases{/id}","deployments_url":"https://api.github.com/repos/pbi-qfs/selenium/deployments","created_at":"2016-09-06T17:01:49Z","updated_at":"2016-09-06T17:02:02Z","pushed_at":"2016-09-07T11:22:54Z","git_url":"git://github.com/pbi-qfs/selenium.git","ssh_url":"git@github.com:pbi-qfs/selenium.git","clone_url":"https://github.com/pbi-qfs/selenium.git","svn_url":"https://github.com/pbi-qfs/selenium","homepage":"http://seleniumhq.org/","size":1400666,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SeleniumHQ:master","ref":"master","sha":"4d79679d2150cf7a7dc3ac8eec7b653c50a5f055","user":{"login":"SeleniumHQ","id":983927,"avatar_url":"https://avatars.githubusercontent.com/u/983927?v=3","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":7613257,"name":"selenium","full_name":"SeleniumHQ/selenium","owner":{"login":"SeleniumHQ","id":983927,"avatar_url":"https://avatars.githubusercontent.com/u/983927?v=3","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SeleniumHQ/selenium","description":"A browser automation framework and ecosystem.","fork":false,"url":"https://api.github.com/repos/SeleniumHQ/selenium","forks_url":"https://api.github.com/repos/SeleniumHQ/selenium/forks","keys_url":"https://api.github.com/repos/SeleniumHQ/selenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeleniumHQ/selenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeleniumHQ/selenium/teams","hooks_url":"https://api.github.com/repos/SeleniumHQ/selenium/hooks","issue_events_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/events{/number}","events_url":"https://api.github.com/repos/SeleniumHQ/selenium/events","assignees_url":"https://api.github.com/repos/SeleniumHQ/selenium/assignees{/user}","branches_url":"https://api.github.com/repos/SeleniumHQ/selenium/branches{/branch}","tags_url":"https://api.github.com/repos/SeleniumHQ/selenium/tags","blobs_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/{sha}","languages_url":"https://api.github.com/repos/SeleniumHQ/selenium/languages","stargazers_url":"https://api.github.com/repos/SeleniumHQ/selenium/stargazers","contributors_url":"https://api.github.com/repos/SeleniumHQ/selenium/contributors","subscribers_url":"https://api.github.com/repos/SeleniumHQ/selenium/subscribers","subscription_url":"https://api.github.com/repos/SeleniumHQ/selenium/subscription","commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/SeleniumHQ/selenium/contents/{+path}","compare_url":"https://api.github.com/repos/SeleniumHQ/selenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeleniumHQ/selenium/merges","archive_url":"https://api.github.com/repos/SeleniumHQ/selenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeleniumHQ/selenium/downloads","issues_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues{/number}","pulls_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls{/number}","milestones_url":"https://api.github.com/repos/SeleniumHQ/selenium/milestones{/number}","notifications_url":"https://api.github.com/repos/SeleniumHQ/selenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeleniumHQ/selenium/labels{/name}","releases_url":"https://api.github.com/repos/SeleniumHQ/selenium/releases{/id}","deployments_url":"https://api.github.com/repos/SeleniumHQ/selenium/deployments","created_at":"2013-01-14T21:40:56Z","updated_at":"2016-09-09T14:52:07Z","pushed_at":"2016-09-09T16:20:37Z","git_url":"git://github.com/SeleniumHQ/selenium.git","ssh_url":"git@github.com:SeleniumHQ/selenium.git","clone_url":"https://github.com/SeleniumHQ/selenium.git","svn_url":"https://github.com/SeleniumHQ/selenium","homepage":"http://seleniumhq.org/","size":1416348,"stargazers_count":4318,"watchers_count":4318,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2136,"mirror_url":null,"open_issues_count":503,"forks":2136,"open_issues":503,"watchers":4318,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/2733"},"html":{"href":"https://github.com/SeleniumHQ/selenium/pull/2733"},"issue":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/issues/2733"},"comments":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/issues/2733/comments"},"review_comments":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/2733/comments"},"review_comment":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/2733/commits"},"statuses":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/16f3e9e2098b563d88f7ddf4c2631837465d78a4"}}}}
{"actor":{"display_login":"jleyba"}}