{"action":"created","comment":{"url":"https://api.github.com/repos/javierforero/meltedradio/pulls/comments/88824925","pull_request_review_id":9385576,"id":88824925,"diff_hunk":"@@ -0,0 +1,36 @@\n+require 'rails_helper'\n+\n+RSpec.describe UsersController, type: :controller do\n+\n+  let!(:my_user) {User.create(name: \"James\")}\n+\n+  it \"GET index returns success\" do\n+    get :index\n+    expect(response).to have_http_status(:success)\n+  end\n+\n+  describe \"POST create user\" do\n+\n+      it \"creates a new user successfully\" do\n+        post :create, user: {name: \"james\"}\n+        expect(response).to have_http_status(201)\n+      end\n+  end\n+\n+  describe \"UPDATE user\" do\n+\n+     it \"updates user attributes\" do\n+       put :update, id: my_user.id, user: {name: \"pablo\"}\n+       expect(response).to have_http_status(200)\n+       expect(User.find(my_user.id).name).to eq(\"pablo\")\n+     end\n+  end\n+\n+  describe \"DELETE user\" do\n+    it \"deletes especified user\" do","path":"spec/controllers/users_controller_spec.rb","position":30,"original_position":30,"commit_id":"eaa785791ae153b535bfeefe81e08e53c0efbfb5","original_commit_id":"eaa785791ae153b535bfeefe81e08e53c0efbfb5","user":{"login":"javierforero","id":9144379,"avatar_url":"https://avatars.githubusercontent.com/u/9144379?v=3","gravatar_id":"","url":"https://api.github.com/users/javierforero","html_url":"https://github.com/javierforero","followers_url":"https://api.github.com/users/javierforero/followers","following_url":"https://api.github.com/users/javierforero/following{/other_user}","gists_url":"https://api.github.com/users/javierforero/gists{/gist_id}","starred_url":"https://api.github.com/users/javierforero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierforero/subscriptions","organizations_url":"https://api.github.com/users/javierforero/orgs","repos_url":"https://api.github.com/users/javierforero/repos","events_url":"https://api.github.com/users/javierforero/events{/privacy}","received_events_url":"https://api.github.com/users/javierforero/received_events","type":"User","site_admin":false},"body":"good point. How about? \r\n\r\n```\r\n  describe \"DELETE user\" do\r\n    it \"deletes especified user\" do\r\n      delete :destroy, id: my_user\r\n      expect(response).to have_http_status(200)\r\n      expect {my_user.reload}.to raise_exception(ActiveRecord::RecordNotFound)\r\n    end\r\n```","created_at":"2016-11-21T03:35:30Z","updated_at":"2016-11-21T03:35:30Z","html_url":"https://github.com/javierforero/meltedradio/pull/2#discussion_r88824925","pull_request_url":"https://api.github.com/repos/javierforero/meltedradio/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/javierforero/meltedradio/pulls/comments/88824925"},"html":{"href":"https://github.com/javierforero/meltedradio/pull/2#discussion_r88824925"},"pull_request":{"href":"https://api.github.com/repos/javierforero/meltedradio/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/javierforero/meltedradio/pulls/2","id":94489020,"html_url":"https://github.com/javierforero/meltedradio/pull/2","diff_url":"https://github.com/javierforero/meltedradio/pull/2.diff","patch_url":"https://github.com/javierforero/meltedradio/pull/2.patch","issue_url":"https://api.github.com/repos/javierforero/meltedradio/issues/2","number":2,"state":"open","locked":false,"title":"Api","user":{"login":"javierforero","id":9144379,"avatar_url":"https://avatars.githubusercontent.com/u/9144379?v=3","gravatar_id":"","url":"https://api.github.com/users/javierforero","html_url":"https://github.com/javierforero","followers_url":"https://api.github.com/users/javierforero/followers","following_url":"https://api.github.com/users/javierforero/following{/other_user}","gists_url":"https://api.github.com/users/javierforero/gists{/gist_id}","starred_url":"https://api.github.com/users/javierforero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierforero/subscriptions","organizations_url":"https://api.github.com/users/javierforero/orgs","repos_url":"https://api.github.com/users/javierforero/repos","events_url":"https://api.github.com/users/javierforero/events{/privacy}","received_events_url":"https://api.github.com/users/javierforero/received_events","type":"User","site_admin":false},"body":"@droberts84\r\n\r\nHi, \r\n\r\nSo I just finished the basic CRUD for Users API with some basic rspec. I am really rusty on the rspec so see what you think. I left the email field out of this because i believe those are fields that the authentication will cover? Let's talk about this on Monday cause I have no idea how to go about it. ","created_at":"2016-11-19T17:44:38Z","updated_at":"2016-11-21T03:35:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdbe67649fc7a773f496ac4ed8fcd1aa2bd756d2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/javierforero/meltedradio/pulls/2/commits","review_comments_url":"https://api.github.com/repos/javierforero/meltedradio/pulls/2/comments","review_comment_url":"https://api.github.com/repos/javierforero/meltedradio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/javierforero/meltedradio/issues/2/comments","statuses_url":"https://api.github.com/repos/javierforero/meltedradio/statuses/eaa785791ae153b535bfeefe81e08e53c0efbfb5","head":{"label":"javierforero:api","ref":"api","sha":"eaa785791ae153b535bfeefe81e08e53c0efbfb5","user":{"login":"javierforero","id":9144379,"avatar_url":"https://avatars.githubusercontent.com/u/9144379?v=3","gravatar_id":"","url":"https://api.github.com/users/javierforero","html_url":"https://github.com/javierforero","followers_url":"https://api.github.com/users/javierforero/followers","following_url":"https://api.github.com/users/javierforero/following{/other_user}","gists_url":"https://api.github.com/users/javierforero/gists{/gist_id}","starred_url":"https://api.github.com/users/javierforero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierforero/subscriptions","organizations_url":"https://api.github.com/users/javierforero/orgs","repos_url":"https://api.github.com/users/javierforero/repos","events_url":"https://api.github.com/users/javierforero/events{/privacy}","received_events_url":"https://api.github.com/users/javierforero/received_events","type":"User","site_admin":false},"repo":{"id":72888633,"name":"meltedradio","full_name":"javierforero/meltedradio","owner":{"login":"javierforero","id":9144379,"avatar_url":"https://avatars.githubusercontent.com/u/9144379?v=3","gravatar_id":"","url":"https://api.github.com/users/javierforero","html_url":"https://github.com/javierforero","followers_url":"https://api.github.com/users/javierforero/followers","following_url":"https://api.github.com/users/javierforero/following{/other_user}","gists_url":"https://api.github.com/users/javierforero/gists{/gist_id}","starred_url":"https://api.github.com/users/javierforero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierforero/subscriptions","organizations_url":"https://api.github.com/users/javierforero/orgs","repos_url":"https://api.github.com/users/javierforero/repos","events_url":"https://api.github.com/users/javierforero/events{/privacy}","received_events_url":"https://api.github.com/users/javierforero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/javierforero/meltedradio","description":null,"fork":false,"url":"https://api.github.com/repos/javierforero/meltedradio","forks_url":"https://api.github.com/repos/javierforero/meltedradio/forks","keys_url":"https://api.github.com/repos/javierforero/meltedradio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javierforero/meltedradio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javierforero/meltedradio/teams","hooks_url":"https://api.github.com/repos/javierforero/meltedradio/hooks","issue_events_url":"https://api.github.com/repos/javierforero/meltedradio/issues/events{/number}","events_url":"https://api.github.com/repos/javierforero/meltedradio/events","assignees_url":"https://api.github.com/repos/javierforero/meltedradio/assignees{/user}","branches_url":"https://api.github.com/repos/javierforero/meltedradio/branches{/branch}","tags_url":"https://api.github.com/repos/javierforero/meltedradio/tags","blobs_url":"https://api.github.com/repos/javierforero/meltedradio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javierforero/meltedradio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javierforero/meltedradio/git/refs{/sha}","trees_url":"https://api.github.com/repos/javierforero/meltedradio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javierforero/meltedradio/statuses/{sha}","languages_url":"https://api.github.com/repos/javierforero/meltedradio/languages","stargazers_url":"https://api.github.com/repos/javierforero/meltedradio/stargazers","contributors_url":"https://api.github.com/repos/javierforero/meltedradio/contributors","subscribers_url":"https://api.github.com/repos/javierforero/meltedradio/subscribers","subscription_url":"https://api.github.com/repos/javierforero/meltedradio/subscription","commits_url":"https://api.github.com/repos/javierforero/meltedradio/commits{/sha}","git_commits_url":"https://api.github.com/repos/javierforero/meltedradio/git/commits{/sha}","comments_url":"https://api.github.com/repos/javierforero/meltedradio/comments{/number}","issue_comment_url":"https://api.github.com/repos/javierforero/meltedradio/issues/comments{/number}","contents_url":"https://api.github.com/repos/javierforero/meltedradio/contents/{+path}","compare_url":"https://api.github.com/repos/javierforero/meltedradio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javierforero/meltedradio/merges","archive_url":"https://api.github.com/repos/javierforero/meltedradio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javierforero/meltedradio/downloads","issues_url":"https://api.github.com/repos/javierforero/meltedradio/issues{/number}","pulls_url":"https://api.github.com/repos/javierforero/meltedradio/pulls{/number}","milestones_url":"https://api.github.com/repos/javierforero/meltedradio/milestones{/number}","notifications_url":"https://api.github.com/repos/javierforero/meltedradio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javierforero/meltedradio/labels{/name}","releases_url":"https://api.github.com/repos/javierforero/meltedradio/releases{/id}","deployments_url":"https://api.github.com/repos/javierforero/meltedradio/deployments","created_at":"2016-11-04T22:02:02Z","updated_at":"2016-11-04T22:02:47Z","pushed_at":"2016-11-19T17:44:38Z","git_url":"git://github.com/javierforero/meltedradio.git","ssh_url":"git@github.com:javierforero/meltedradio.git","clone_url":"https://github.com/javierforero/meltedradio.git","svn_url":"https://github.com/javierforero/meltedradio","homepage":null,"size":35,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"javierforero:master","ref":"master","sha":"e0c23edfb9287cea2f7bebb6ce54d75ebaed0f91","user":{"login":"javierforero","id":9144379,"avatar_url":"https://avatars.githubusercontent.com/u/9144379?v=3","gravatar_id":"","url":"https://api.github.com/users/javierforero","html_url":"https://github.com/javierforero","followers_url":"https://api.github.com/users/javierforero/followers","following_url":"https://api.github.com/users/javierforero/following{/other_user}","gists_url":"https://api.github.com/users/javierforero/gists{/gist_id}","starred_url":"https://api.github.com/users/javierforero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierforero/subscriptions","organizations_url":"https://api.github.com/users/javierforero/orgs","repos_url":"https://api.github.com/users/javierforero/repos","events_url":"https://api.github.com/users/javierforero/events{/privacy}","received_events_url":"https://api.github.com/users/javierforero/received_events","type":"User","site_admin":false},"repo":{"id":72888633,"name":"meltedradio","full_name":"javierforero/meltedradio","owner":{"login":"javierforero","id":9144379,"avatar_url":"https://avatars.githubusercontent.com/u/9144379?v=3","gravatar_id":"","url":"https://api.github.com/users/javierforero","html_url":"https://github.com/javierforero","followers_url":"https://api.github.com/users/javierforero/followers","following_url":"https://api.github.com/users/javierforero/following{/other_user}","gists_url":"https://api.github.com/users/javierforero/gists{/gist_id}","starred_url":"https://api.github.com/users/javierforero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierforero/subscriptions","organizations_url":"https://api.github.com/users/javierforero/orgs","repos_url":"https://api.github.com/users/javierforero/repos","events_url":"https://api.github.com/users/javierforero/events{/privacy}","received_events_url":"https://api.github.com/users/javierforero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/javierforero/meltedradio","description":null,"fork":false,"url":"https://api.github.com/repos/javierforero/meltedradio","forks_url":"https://api.github.com/repos/javierforero/meltedradio/forks","keys_url":"https://api.github.com/repos/javierforero/meltedradio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javierforero/meltedradio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javierforero/meltedradio/teams","hooks_url":"https://api.github.com/repos/javierforero/meltedradio/hooks","issue_events_url":"https://api.github.com/repos/javierforero/meltedradio/issues/events{/number}","events_url":"https://api.github.com/repos/javierforero/meltedradio/events","assignees_url":"https://api.github.com/repos/javierforero/meltedradio/assignees{/user}","branches_url":"https://api.github.com/repos/javierforero/meltedradio/branches{/branch}","tags_url":"https://api.github.com/repos/javierforero/meltedradio/tags","blobs_url":"https://api.github.com/repos/javierforero/meltedradio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javierforero/meltedradio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javierforero/meltedradio/git/refs{/sha}","trees_url":"https://api.github.com/repos/javierforero/meltedradio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javierforero/meltedradio/statuses/{sha}","languages_url":"https://api.github.com/repos/javierforero/meltedradio/languages","stargazers_url":"https://api.github.com/repos/javierforero/meltedradio/stargazers","contributors_url":"https://api.github.com/repos/javierforero/meltedradio/contributors","subscribers_url":"https://api.github.com/repos/javierforero/meltedradio/subscribers","subscription_url":"https://api.github.com/repos/javierforero/meltedradio/subscription","commits_url":"https://api.github.com/repos/javierforero/meltedradio/commits{/sha}","git_commits_url":"https://api.github.com/repos/javierforero/meltedradio/git/commits{/sha}","comments_url":"https://api.github.com/repos/javierforero/meltedradio/comments{/number}","issue_comment_url":"https://api.github.com/repos/javierforero/meltedradio/issues/comments{/number}","contents_url":"https://api.github.com/repos/javierforero/meltedradio/contents/{+path}","compare_url":"https://api.github.com/repos/javierforero/meltedradio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javierforero/meltedradio/merges","archive_url":"https://api.github.com/repos/javierforero/meltedradio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javierforero/meltedradio/downloads","issues_url":"https://api.github.com/repos/javierforero/meltedradio/issues{/number}","pulls_url":"https://api.github.com/repos/javierforero/meltedradio/pulls{/number}","milestones_url":"https://api.github.com/repos/javierforero/meltedradio/milestones{/number}","notifications_url":"https://api.github.com/repos/javierforero/meltedradio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javierforero/meltedradio/labels{/name}","releases_url":"https://api.github.com/repos/javierforero/meltedradio/releases{/id}","deployments_url":"https://api.github.com/repos/javierforero/meltedradio/deployments","created_at":"2016-11-04T22:02:02Z","updated_at":"2016-11-04T22:02:47Z","pushed_at":"2016-11-19T17:44:38Z","git_url":"git://github.com/javierforero/meltedradio.git","ssh_url":"git@github.com:javierforero/meltedradio.git","clone_url":"https://github.com/javierforero/meltedradio.git","svn_url":"https://github.com/javierforero/meltedradio","homepage":null,"size":35,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/javierforero/meltedradio/pulls/2"},"html":{"href":"https://github.com/javierforero/meltedradio/pull/2"},"issue":{"href":"https://api.github.com/repos/javierforero/meltedradio/issues/2"},"comments":{"href":"https://api.github.com/repos/javierforero/meltedradio/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/javierforero/meltedradio/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/javierforero/meltedradio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/javierforero/meltedradio/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/javierforero/meltedradio/statuses/eaa785791ae153b535bfeefe81e08e53c0efbfb5"}}}}
{"actor":{"display_login":"javierforero"}}