{"action":"created","comment":{"url":"https://api.github.com/repos/apache/drill/pulls/comments/82293808","pull_request_review_id":3212456,"id":82293808,"diff_hunk":"@@ -160,10 +160,9 @@ private static void appendByte(StringBuilder result, byte b) {\n    *\r\n    * @return Index in the byte buffer just after the last written byte.\r\n    */\r\n-  public static int parseBinaryString(ByteBuf str, int strStart, int strEnd) {\r\n-    int length = (strEnd - strStart);\r\n-    int dstEnd = strStart;\r\n-    for (int i = strStart; i < strStart+length ; i++) {\r\n+  public static int parseBinaryString(ByteBuf str, int strStart, int strEnd, ByteBuf out) {\r\n+    int dstEnd = 0;\r\n+    for (int i = strStart; i < strEnd ; i++) {\r","path":"common/src/main/java/org/apache/drill/common/util/DrillStringUtils.java","position":10,"original_position":10,"commit_id":"1a6ae051eaa11d507e53ddd6912995e7aa6f7111","original_commit_id":"1a6ae051eaa11d507e53ddd6912995e7aa6f7111","user":{"login":"gparai","id":19275160,"avatar_url":"https://avatars.githubusercontent.com/u/19275160?v=3","gravatar_id":"","url":"https://api.github.com/users/gparai","html_url":"https://github.com/gparai","followers_url":"https://api.github.com/users/gparai/followers","following_url":"https://api.github.com/users/gparai/following{/other_user}","gists_url":"https://api.github.com/users/gparai/gists{/gist_id}","starred_url":"https://api.github.com/users/gparai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gparai/subscriptions","organizations_url":"https://api.github.com/users/gparai/orgs","repos_url":"https://api.github.com/users/gparai/repos","events_url":"https://api.github.com/users/gparai/events{/privacy}","received_events_url":"https://api.github.com/users/gparai/received_events","type":"User","site_admin":false},"body":"Please change to `strEnd;`","created_at":"2016-10-06T21:52:47Z","updated_at":"2016-10-06T22:02:10Z","html_url":"https://github.com/apache/drill/pull/604#discussion_r82293808","pull_request_url":"https://api.github.com/repos/apache/drill/pulls/604","_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/comments/82293808"},"html":{"href":"https://github.com/apache/drill/pull/604#discussion_r82293808"},"pull_request":{"href":"https://api.github.com/repos/apache/drill/pulls/604"}}},"pull_request":{"url":"https://api.github.com/repos/apache/drill/pulls/604","id":88212608,"html_url":"https://github.com/apache/drill/pull/604","diff_url":"https://github.com/apache/drill/pull/604.diff","patch_url":"https://github.com/apache/drill/pull/604.patch","issue_url":"https://api.github.com/repos/apache/drill/issues/604","number":604,"state":"open","locked":false,"title":"DRILL-4862: binary_string should use another buffer as out buffer to …","user":{"login":"chunhui-shi","id":9878787,"avatar_url":"https://avatars.githubusercontent.com/u/9878787?v=3","gravatar_id":"","url":"https://api.github.com/users/chunhui-shi","html_url":"https://github.com/chunhui-shi","followers_url":"https://api.github.com/users/chunhui-shi/followers","following_url":"https://api.github.com/users/chunhui-shi/following{/other_user}","gists_url":"https://api.github.com/users/chunhui-shi/gists{/gist_id}","starred_url":"https://api.github.com/users/chunhui-shi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chunhui-shi/subscriptions","organizations_url":"https://api.github.com/users/chunhui-shi/orgs","repos_url":"https://api.github.com/users/chunhui-shi/repos","events_url":"https://api.github.com/users/chunhui-shi/events{/privacy}","received_events_url":"https://api.github.com/users/chunhui-shi/received_events","type":"User","site_admin":false},"body":"…be used in more generic usage.","created_at":"2016-10-06T07:43:58Z","updated_at":"2016-10-06T22:02:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aeb8223ed4a7799cfb44177d5e28ac8a193831f7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/drill/pulls/604/commits","review_comments_url":"https://api.github.com/repos/apache/drill/pulls/604/comments","review_comment_url":"https://api.github.com/repos/apache/drill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/drill/issues/604/comments","statuses_url":"https://api.github.com/repos/apache/drill/statuses/1a6ae051eaa11d507e53ddd6912995e7aa6f7111","head":{"label":"chunhui-shi:DRILL-4862-string","ref":"DRILL-4862-string","sha":"1a6ae051eaa11d507e53ddd6912995e7aa6f7111","user":{"login":"chunhui-shi","id":9878787,"avatar_url":"https://avatars.githubusercontent.com/u/9878787?v=3","gravatar_id":"","url":"https://api.github.com/users/chunhui-shi","html_url":"https://github.com/chunhui-shi","followers_url":"https://api.github.com/users/chunhui-shi/followers","following_url":"https://api.github.com/users/chunhui-shi/following{/other_user}","gists_url":"https://api.github.com/users/chunhui-shi/gists{/gist_id}","starred_url":"https://api.github.com/users/chunhui-shi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chunhui-shi/subscriptions","organizations_url":"https://api.github.com/users/chunhui-shi/orgs","repos_url":"https://api.github.com/users/chunhui-shi/repos","events_url":"https://api.github.com/users/chunhui-shi/events{/privacy}","received_events_url":"https://api.github.com/users/chunhui-shi/received_events","type":"User","site_admin":false},"repo":{"id":53957525,"name":"drill","full_name":"chunhui-shi/drill","owner":{"login":"chunhui-shi","id":9878787,"avatar_url":"https://avatars.githubusercontent.com/u/9878787?v=3","gravatar_id":"","url":"https://api.github.com/users/chunhui-shi","html_url":"https://github.com/chunhui-shi","followers_url":"https://api.github.com/users/chunhui-shi/followers","following_url":"https://api.github.com/users/chunhui-shi/following{/other_user}","gists_url":"https://api.github.com/users/chunhui-shi/gists{/gist_id}","starred_url":"https://api.github.com/users/chunhui-shi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chunhui-shi/subscriptions","organizations_url":"https://api.github.com/users/chunhui-shi/orgs","repos_url":"https://api.github.com/users/chunhui-shi/repos","events_url":"https://api.github.com/users/chunhui-shi/events{/privacy}","received_events_url":"https://api.github.com/users/chunhui-shi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chunhui-shi/drill","description":"Mirror of Apache Drill","fork":true,"url":"https://api.github.com/repos/chunhui-shi/drill","forks_url":"https://api.github.com/repos/chunhui-shi/drill/forks","keys_url":"https://api.github.com/repos/chunhui-shi/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chunhui-shi/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chunhui-shi/drill/teams","hooks_url":"https://api.github.com/repos/chunhui-shi/drill/hooks","issue_events_url":"https://api.github.com/repos/chunhui-shi/drill/issues/events{/number}","events_url":"https://api.github.com/repos/chunhui-shi/drill/events","assignees_url":"https://api.github.com/repos/chunhui-shi/drill/assignees{/user}","branches_url":"https://api.github.com/repos/chunhui-shi/drill/branches{/branch}","tags_url":"https://api.github.com/repos/chunhui-shi/drill/tags","blobs_url":"https://api.github.com/repos/chunhui-shi/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chunhui-shi/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chunhui-shi/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/chunhui-shi/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chunhui-shi/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/chunhui-shi/drill/languages","stargazers_url":"https://api.github.com/repos/chunhui-shi/drill/stargazers","contributors_url":"https://api.github.com/repos/chunhui-shi/drill/contributors","subscribers_url":"https://api.github.com/repos/chunhui-shi/drill/subscribers","subscription_url":"https://api.github.com/repos/chunhui-shi/drill/subscription","commits_url":"https://api.github.com/repos/chunhui-shi/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/chunhui-shi/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/chunhui-shi/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/chunhui-shi/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/chunhui-shi/drill/contents/{+path}","compare_url":"https://api.github.com/repos/chunhui-shi/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chunhui-shi/drill/merges","archive_url":"https://api.github.com/repos/chunhui-shi/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chunhui-shi/drill/downloads","issues_url":"https://api.github.com/repos/chunhui-shi/drill/issues{/number}","pulls_url":"https://api.github.com/repos/chunhui-shi/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/chunhui-shi/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/chunhui-shi/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chunhui-shi/drill/labels{/name}","releases_url":"https://api.github.com/repos/chunhui-shi/drill/releases{/id}","deployments_url":"https://api.github.com/repos/chunhui-shi/drill/deployments","created_at":"2016-03-15T15:45:33Z","updated_at":"2016-03-15T15:45:42Z","pushed_at":"2016-10-06T06:26:16Z","git_url":"git://github.com/chunhui-shi/drill.git","ssh_url":"git@github.com:chunhui-shi/drill.git","clone_url":"https://github.com/chunhui-shi/drill.git","svn_url":"https://github.com/chunhui-shi/drill","homepage":"","size":41993,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"4edabe7a392f38b0f7a9c8af51a74bf6932a821d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":5683653,"name":"drill","full_name":"apache/drill","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/drill","description":"Mirror of Apache Drill","fork":false,"url":"https://api.github.com/repos/apache/drill","forks_url":"https://api.github.com/repos/apache/drill/forks","keys_url":"https://api.github.com/repos/apache/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/drill/teams","hooks_url":"https://api.github.com/repos/apache/drill/hooks","issue_events_url":"https://api.github.com/repos/apache/drill/issues/events{/number}","events_url":"https://api.github.com/repos/apache/drill/events","assignees_url":"https://api.github.com/repos/apache/drill/assignees{/user}","branches_url":"https://api.github.com/repos/apache/drill/branches{/branch}","tags_url":"https://api.github.com/repos/apache/drill/tags","blobs_url":"https://api.github.com/repos/apache/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/drill/languages","stargazers_url":"https://api.github.com/repos/apache/drill/stargazers","contributors_url":"https://api.github.com/repos/apache/drill/contributors","subscribers_url":"https://api.github.com/repos/apache/drill/subscribers","subscription_url":"https://api.github.com/repos/apache/drill/subscription","commits_url":"https://api.github.com/repos/apache/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/drill/contents/{+path}","compare_url":"https://api.github.com/repos/apache/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/drill/merges","archive_url":"https://api.github.com/repos/apache/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/drill/downloads","issues_url":"https://api.github.com/repos/apache/drill/issues{/number}","pulls_url":"https://api.github.com/repos/apache/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/drill/labels{/name}","releases_url":"https://api.github.com/repos/apache/drill/releases{/id}","deployments_url":"https://api.github.com/repos/apache/drill/deployments","created_at":"2012-09-05T07:00:26Z","updated_at":"2016-10-06T20:01:29Z","pushed_at":"2016-10-06T21:57:08Z","git_url":"git://github.com/apache/drill.git","ssh_url":"git@github.com:apache/drill.git","clone_url":"https://github.com/apache/drill.git","svn_url":"https://github.com/apache/drill","homepage":"","size":51267,"stargazers_count":695,"watchers_count":695,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":485,"mirror_url":"git://git.apache.org/drill.git","open_issues_count":122,"forks":485,"open_issues":122,"watchers":695,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/604"},"html":{"href":"https://github.com/apache/drill/pull/604"},"issue":{"href":"https://api.github.com/repos/apache/drill/issues/604"},"comments":{"href":"https://api.github.com/repos/apache/drill/issues/604/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/drill/pulls/604/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/drill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/drill/pulls/604/commits"},"statuses":{"href":"https://api.github.com/repos/apache/drill/statuses/1a6ae051eaa11d507e53ddd6912995e7aa6f7111"}}}}
{"actor":{"display_login":"gparai"}}