{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28991","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28991/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28991/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28991/events","html_url":"https://github.com/kubernetes/kubernetes/pull/28991","id":165727477,"number":28991,"title":"optimize conditions of ServiceReplenishmentUpdateFunc to replenish service","user":{"login":"249043822","id":18046309,"avatar_url":"https://avatars.githubusercontent.com/u/18046309?v=3","gravatar_id":"","url":"https://api.github.com/users/249043822","html_url":"https://github.com/249043822","followers_url":"https://api.github.com/users/249043822/followers","following_url":"https://api.github.com/users/249043822/following{/other_user}","gists_url":"https://api.github.com/users/249043822/gists{/gist_id}","starred_url":"https://api.github.com/users/249043822/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/249043822/subscriptions","organizations_url":"https://api.github.com/users/249043822/orgs","repos_url":"https://api.github.com/users/249043822/repos","events_url":"https://api.github.com/users/249043822/events{/privacy}","received_events_url":"https://api.github.com/users/249043822/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00"}],"state":"open","locked":false,"assignee":{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars.githubusercontent.com/u/6233452?v=3","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},"assignees":[{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars.githubusercontent.com/u/6233452?v=3","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/22","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.4","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/22/labels","id":1777384,"number":22,"title":"v1.4","description":"","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":169,"closed_issues":133,"state":"open","created_at":"2016-05-19T18:50:19Z","updated_at":"2016-08-05T19:08:49Z","due_on":null,"closed_at":null},"comments":13,"created_at":"2016-07-15T07:28:39Z","updated_at":"2016-08-05T19:31:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28991","html_url":"https://github.com/kubernetes/kubernetes/pull/28991","diff_url":"https://github.com/kubernetes/kubernetes/pull/28991.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/28991.patch"},"body":"Originally, the  replenishQuota method didn't focus on the third parameter object even if others transfered to it, i think the function is not efficient and perfect. then i use the third param to get MatchResources, it will be more exact. for example, if the old pod was quota tracked and the new was not, the replenishQuota only focus on usage resource of the old pod, still if  the third parameter object is nil, the process will be same as before"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/237942054","html_url":"https://github.com/kubernetes/kubernetes/pull/28991#issuecomment-237942054","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28991","id":237942054,"user":{"login":"k8s-bot","id":12551979,"avatar_url":"https://avatars.githubusercontent.com/u/12551979?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-bot","html_url":"https://github.com/k8s-bot","followers_url":"https://api.github.com/users/k8s-bot/followers","following_url":"https://api.github.com/users/k8s-bot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-bot/subscriptions","organizations_url":"https://api.github.com/users/k8s-bot/orgs","repos_url":"https://api.github.com/users/k8s-bot/repos","events_url":"https://api.github.com/users/k8s-bot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-bot/received_events","type":"User","site_admin":false},"created_at":"2016-08-05T19:31:23Z","updated_at":"2016-08-05T19:31:23Z","body":"GCE e2e build/test **passed** for commit 3973856ac2910a29aaf3ae1d7eb39f13e1d898c7.\n* [Test Results](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/28991/kubernetes-pull-build-test-e2e-gce/52136)\n* [Build Log](http://pr-test.k8s.io/28991/kubernetes-pull-build-test-e2e-gce/52136/build-log.txt)\n* [Test Artifacts](https://console.developers.google.com/storage/browser/kubernetes-jenkins/pr-logs/pull/28991/kubernetes-pull-build-test-e2e-gce/52136/artifacts/)\n* [Internal Jenkins Results](http://goto.google.com/prkubekins/job/kubernetes-pull-build-test-e2e-gce//52136)\n\n"}}
{"actor":{"display_login":"k8s-bot"}}