{"action":"created","comment":{"url":"https://api.github.com/repos/scala/pickling/pulls/comments/59261327","id":59261327,"diff_hunk":"@@ -15,7 +15,7 @@ trait DatePicklers extends PrimitivePicklers {\n     }\n     private def dateFormat = dateFormatTemplate.clone.asInstanceOf[SimpleDateFormat]\n \n-    def tag = FastTypeTag[Date]\n+    def tag = FastTypeTag[Date](\"java.util.Date\")","path":"core/src/main/scala/scala/pickling/pickler/Date.scala","position":5,"original_position":5,"commit_id":"6a4b27189d69b7830a554454466bc43a5a61ccc4","original_commit_id":"6a4b27189d69b7830a554454466bc43a5a61ccc4","user":{"login":"phaller","id":289943,"avatar_url":"https://avatars.githubusercontent.com/u/289943?v=3","gravatar_id":"","url":"https://api.github.com/users/phaller","html_url":"https://github.com/phaller","followers_url":"https://api.github.com/users/phaller/followers","following_url":"https://api.github.com/users/phaller/following{/other_user}","gists_url":"https://api.github.com/users/phaller/gists{/gist_id}","starred_url":"https://api.github.com/users/phaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phaller/subscriptions","organizations_url":"https://api.github.com/users/phaller/orgs","repos_url":"https://api.github.com/users/phaller/repos","events_url":"https://api.github.com/users/phaller/events{/privacy}","received_events_url":"https://api.github.com/users/phaller/received_events","type":"User","site_admin":false},"body":"Why is this string argument needed?","created_at":"2016-04-11T18:59:50Z","updated_at":"2016-04-11T18:59:50Z","html_url":"https://github.com/scala/pickling/pull/400#discussion_r59261327","pull_request_url":"https://api.github.com/repos/scala/pickling/pulls/400","_links":{"self":{"href":"https://api.github.com/repos/scala/pickling/pulls/comments/59261327"},"html":{"href":"https://github.com/scala/pickling/pull/400#discussion_r59261327"},"pull_request":{"href":"https://api.github.com/repos/scala/pickling/pulls/400"}}},"pull_request":{"url":"https://api.github.com/repos/scala/pickling/pulls/400","id":65559819,"html_url":"https://github.com/scala/pickling/pull/400","diff_url":"https://github.com/scala/pickling/pull/400.diff","patch_url":"https://github.com/scala/pickling/pull/400.patch","issue_url":"https://api.github.com/repos/scala/pickling/issues/400","number":400,"state":"open","locked":false,"title":"FastTypeTag - AppliedType blender","user":{"login":"jsuereth","id":29006,"avatar_url":"https://avatars.githubusercontent.com/u/29006?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuereth","html_url":"https://github.com/jsuereth","followers_url":"https://api.github.com/users/jsuereth/followers","following_url":"https://api.github.com/users/jsuereth/following{/other_user}","gists_url":"https://api.github.com/users/jsuereth/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuereth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuereth/subscriptions","organizations_url":"https://api.github.com/users/jsuereth/orgs","repos_url":"https://api.github.com/users/jsuereth/repos","events_url":"https://api.github.com/users/jsuereth/events{/privacy}","received_events_url":"https://api.github.com/users/jsuereth/received_events","type":"User","site_admin":false},"body":"FastTypeTag now replaces AppliedType and its previous incarnation.  It is now meant to be solely responsible for:\r\n\r\n* Adapting runtime `Class[_]` into a \"tag string\" we can use to lookup picklers\r\n* Adapting compile time `Type` into a \"tag string\" we can use to mark ADT types in picklers for deserialization.\r\n* Bridging/Fixing the issues that arise from `Class[_]` and `Type` supporting differing things.\r\n\r\nOf primary importance, we no longer will see non-parameterized types at runtime.  All types will have their parameters reflected off the `Class[_]`, albeit we \"punt\" to `scala.Any` for their Type.\r\n\r\nThere's still a bit of follow on work I plan to do, but wanted to get this out for review since it's a big 'un.\r\n\r\ncc @eed3si9n @phaller @heathermiller @havocp","created_at":"2016-04-07T01:02:56Z","updated_at":"2016-04-11T18:59:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"123912ef5641ed7f9003c4d6ba333a92369731d3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scala/pickling/pulls/400/commits","review_comments_url":"https://api.github.com/repos/scala/pickling/pulls/400/comments","review_comment_url":"https://api.github.com/repos/scala/pickling/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scala/pickling/issues/400/comments","statuses_url":"https://api.github.com/repos/scala/pickling/statuses/6a4b27189d69b7830a554454466bc43a5a61ccc4","head":{"label":"scala:wip/fast-tags-cleanup","ref":"wip/fast-tags-cleanup","sha":"6a4b27189d69b7830a554454466bc43a5a61ccc4","user":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"repo":{"id":10566713,"name":"pickling","full_name":"scala/pickling","owner":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala/pickling","description":"Fast, customizable, boilerplate-free pickling support for Scala","fork":false,"url":"https://api.github.com/repos/scala/pickling","forks_url":"https://api.github.com/repos/scala/pickling/forks","keys_url":"https://api.github.com/repos/scala/pickling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala/pickling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala/pickling/teams","hooks_url":"https://api.github.com/repos/scala/pickling/hooks","issue_events_url":"https://api.github.com/repos/scala/pickling/issues/events{/number}","events_url":"https://api.github.com/repos/scala/pickling/events","assignees_url":"https://api.github.com/repos/scala/pickling/assignees{/user}","branches_url":"https://api.github.com/repos/scala/pickling/branches{/branch}","tags_url":"https://api.github.com/repos/scala/pickling/tags","blobs_url":"https://api.github.com/repos/scala/pickling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala/pickling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala/pickling/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala/pickling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala/pickling/statuses/{sha}","languages_url":"https://api.github.com/repos/scala/pickling/languages","stargazers_url":"https://api.github.com/repos/scala/pickling/stargazers","contributors_url":"https://api.github.com/repos/scala/pickling/contributors","subscribers_url":"https://api.github.com/repos/scala/pickling/subscribers","subscription_url":"https://api.github.com/repos/scala/pickling/subscription","commits_url":"https://api.github.com/repos/scala/pickling/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala/pickling/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala/pickling/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala/pickling/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala/pickling/contents/{+path}","compare_url":"https://api.github.com/repos/scala/pickling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala/pickling/merges","archive_url":"https://api.github.com/repos/scala/pickling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala/pickling/downloads","issues_url":"https://api.github.com/repos/scala/pickling/issues{/number}","pulls_url":"https://api.github.com/repos/scala/pickling/pulls{/number}","milestones_url":"https://api.github.com/repos/scala/pickling/milestones{/number}","notifications_url":"https://api.github.com/repos/scala/pickling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala/pickling/labels{/name}","releases_url":"https://api.github.com/repos/scala/pickling/releases{/id}","deployments_url":"https://api.github.com/repos/scala/pickling/deployments","created_at":"2013-06-08T09:37:07Z","updated_at":"2016-04-11T00:43:49Z","pushed_at":"2016-04-11T18:27:06Z","git_url":"git://github.com/scala/pickling.git","ssh_url":"git@github.com:scala/pickling.git","clone_url":"https://github.com/scala/pickling.git","svn_url":"https://github.com/scala/pickling","homepage":"lampwww.epfl.ch/~hmiller/pickling","size":54807,"stargazers_count":730,"watchers_count":730,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":107,"forks":69,"open_issues":107,"watchers":730,"default_branch":"0.11.x"}},"base":{"label":"scala:0.11.x","ref":"0.11.x","sha":"980455234f920708d1c488a098d9f0551baaa2d4","user":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"repo":{"id":10566713,"name":"pickling","full_name":"scala/pickling","owner":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala/pickling","description":"Fast, customizable, boilerplate-free pickling support for Scala","fork":false,"url":"https://api.github.com/repos/scala/pickling","forks_url":"https://api.github.com/repos/scala/pickling/forks","keys_url":"https://api.github.com/repos/scala/pickling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala/pickling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala/pickling/teams","hooks_url":"https://api.github.com/repos/scala/pickling/hooks","issue_events_url":"https://api.github.com/repos/scala/pickling/issues/events{/number}","events_url":"https://api.github.com/repos/scala/pickling/events","assignees_url":"https://api.github.com/repos/scala/pickling/assignees{/user}","branches_url":"https://api.github.com/repos/scala/pickling/branches{/branch}","tags_url":"https://api.github.com/repos/scala/pickling/tags","blobs_url":"https://api.github.com/repos/scala/pickling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala/pickling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala/pickling/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala/pickling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala/pickling/statuses/{sha}","languages_url":"https://api.github.com/repos/scala/pickling/languages","stargazers_url":"https://api.github.com/repos/scala/pickling/stargazers","contributors_url":"https://api.github.com/repos/scala/pickling/contributors","subscribers_url":"https://api.github.com/repos/scala/pickling/subscribers","subscription_url":"https://api.github.com/repos/scala/pickling/subscription","commits_url":"https://api.github.com/repos/scala/pickling/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala/pickling/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala/pickling/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala/pickling/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala/pickling/contents/{+path}","compare_url":"https://api.github.com/repos/scala/pickling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala/pickling/merges","archive_url":"https://api.github.com/repos/scala/pickling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala/pickling/downloads","issues_url":"https://api.github.com/repos/scala/pickling/issues{/number}","pulls_url":"https://api.github.com/repos/scala/pickling/pulls{/number}","milestones_url":"https://api.github.com/repos/scala/pickling/milestones{/number}","notifications_url":"https://api.github.com/repos/scala/pickling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala/pickling/labels{/name}","releases_url":"https://api.github.com/repos/scala/pickling/releases{/id}","deployments_url":"https://api.github.com/repos/scala/pickling/deployments","created_at":"2013-06-08T09:37:07Z","updated_at":"2016-04-11T00:43:49Z","pushed_at":"2016-04-11T18:27:06Z","git_url":"git://github.com/scala/pickling.git","ssh_url":"git@github.com:scala/pickling.git","clone_url":"https://github.com/scala/pickling.git","svn_url":"https://github.com/scala/pickling","homepage":"lampwww.epfl.ch/~hmiller/pickling","size":54807,"stargazers_count":730,"watchers_count":730,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":107,"forks":69,"open_issues":107,"watchers":730,"default_branch":"0.11.x"}},"_links":{"self":{"href":"https://api.github.com/repos/scala/pickling/pulls/400"},"html":{"href":"https://github.com/scala/pickling/pull/400"},"issue":{"href":"https://api.github.com/repos/scala/pickling/issues/400"},"comments":{"href":"https://api.github.com/repos/scala/pickling/issues/400/comments"},"review_comments":{"href":"https://api.github.com/repos/scala/pickling/pulls/400/comments"},"review_comment":{"href":"https://api.github.com/repos/scala/pickling/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scala/pickling/pulls/400/commits"},"statuses":{"href":"https://api.github.com/repos/scala/pickling/statuses/6a4b27189d69b7830a554454466bc43a5a61ccc4"}}}}