{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments/82466377","pull_request_review_id":3375409,"id":82466377,"diff_hunk":"@@ -89,7 +89,7 @@ internal abstract class BrokerClient : IBrokerClient {\n             await TaskUtilities.SwitchToBackgroundThread();\n \n             try {\n-                bool sessionExists = await IsSessionRunningAsync(name, cancellationToken);\n+                bool sessionExists = false; //await IsSessionRunningAsync(name, cancellationToken);","path":"src/Host/Client/Impl/Host/BrokerClient.cs","position":5,"original_position":5,"commit_id":"a45f519cc1aaa8ba64120dfe531d82c09bfa25ac","original_commit_id":"a45f519cc1aaa8ba64120dfe531d82c09bfa25ac","user":{"login":"int19h","id":1175142,"avatar_url":"https://avatars.githubusercontent.com/u/1175142?v=3","gravatar_id":"","url":"https://api.github.com/users/int19h","html_url":"https://github.com/int19h","followers_url":"https://api.github.com/users/int19h/followers","following_url":"https://api.github.com/users/int19h/following{/other_user}","gists_url":"https://api.github.com/users/int19h/gists{/gist_id}","starred_url":"https://api.github.com/users/int19h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/int19h/subscriptions","organizations_url":"https://api.github.com/users/int19h/orgs","repos_url":"https://api.github.com/users/int19h/repos","events_url":"https://api.github.com/users/int19h/events{/privacy}","received_events_url":"https://api.github.com/users/int19h/received_events","type":"User","site_admin":false},"body":"Yes, that is the intent (since we decided to not go with reconnection in RTM). Comment is just so that it's readily obvious how to revert this later, when we get to it.","created_at":"2016-10-07T20:43:13Z","updated_at":"2016-10-07T20:43:13Z","html_url":"https://github.com/Microsoft/RTVS/pull/2465#discussion_r82466377","pull_request_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/2465","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments/82466377"},"html":{"href":"https://github.com/Microsoft/RTVS/pull/2465#discussion_r82466377"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/2465"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/RTVS/pulls/2465","id":88492769,"html_url":"https://github.com/Microsoft/RTVS/pull/2465","diff_url":"https://github.com/Microsoft/RTVS/pull/2465.diff","patch_url":"https://github.com/Microsoft/RTVS/pull/2465.patch","issue_url":"https://api.github.com/repos/Microsoft/RTVS/issues/2465","number":2465,"state":"open","locked":false,"title":"#2425, #2427 (autosaving and restoring session state)","user":{"login":"int19h","id":1175142,"avatar_url":"https://avatars.githubusercontent.com/u/1175142?v=3","gravatar_id":"","url":"https://api.github.com/users/int19h","html_url":"https://github.com/int19h","followers_url":"https://api.github.com/users/int19h/followers","following_url":"https://api.github.com/users/int19h/following{/other_user}","gists_url":"https://api.github.com/users/int19h/gists{/gist_id}","starred_url":"https://api.github.com/users/int19h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/int19h/subscriptions","organizations_url":"https://api.github.com/users/int19h/orgs","repos_url":"https://api.github.com/users/int19h/repos","events_url":"https://api.github.com/users/int19h/events{/privacy}","received_events_url":"https://api.github.com/users/int19h/received_events","type":"User","site_admin":false},"body":"Resolve #2425: Automatically save host state when connection to client is lost\r\nResolve #2427: Prompt to reload saved session state\r\n\r\nDisable reconnecting to live sessions.\r\n\r\nWhen client disconnects from a websocket connection to broker, have broker disconnect from the host, so that the latter can shut down.\r\n\r\nWhen shutting down host due to disconnect, save workspace image.\r\n\r\nWhen starting a new session, check for autosaved workspace image, and prompt user to reload it.\r\n\r\nWhen VS is closed, gracefully terminate any running hosts instead of just disconnecting from them.\r\n\r\nWhen switching from one connection to another, gracefully terminate the old host once the switch is successful.\r\n\r\nExpose session state in /sessions endpoint in the broker.","created_at":"2016-10-07T19:16:29Z","updated_at":"2016-10-07T20:43:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f171013c0e23d8645ee89ea957c3ff5d53fcfc71","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/2465/commits","review_comments_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/2465/comments","review_comment_url":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/RTVS/issues/2465/comments","statuses_url":"https://api.github.com/repos/Microsoft/RTVS/statuses/a45f519cc1aaa8ba64120dfe531d82c09bfa25ac","head":{"label":"int19h:autosave","ref":"autosave","sha":"a45f519cc1aaa8ba64120dfe531d82c09bfa25ac","user":{"login":"int19h","id":1175142,"avatar_url":"https://avatars.githubusercontent.com/u/1175142?v=3","gravatar_id":"","url":"https://api.github.com/users/int19h","html_url":"https://github.com/int19h","followers_url":"https://api.github.com/users/int19h/followers","following_url":"https://api.github.com/users/int19h/following{/other_user}","gists_url":"https://api.github.com/users/int19h/gists{/gist_id}","starred_url":"https://api.github.com/users/int19h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/int19h/subscriptions","organizations_url":"https://api.github.com/users/int19h/orgs","repos_url":"https://api.github.com/users/int19h/repos","events_url":"https://api.github.com/users/int19h/events{/privacy}","received_events_url":"https://api.github.com/users/int19h/received_events","type":"User","site_admin":false},"repo":{"id":53513140,"name":"RTVS","full_name":"int19h/RTVS","owner":{"login":"int19h","id":1175142,"avatar_url":"https://avatars.githubusercontent.com/u/1175142?v=3","gravatar_id":"","url":"https://api.github.com/users/int19h","html_url":"https://github.com/int19h","followers_url":"https://api.github.com/users/int19h/followers","following_url":"https://api.github.com/users/int19h/following{/other_user}","gists_url":"https://api.github.com/users/int19h/gists{/gist_id}","starred_url":"https://api.github.com/users/int19h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/int19h/subscriptions","organizations_url":"https://api.github.com/users/int19h/orgs","repos_url":"https://api.github.com/users/int19h/repos","events_url":"https://api.github.com/users/int19h/events{/privacy}","received_events_url":"https://api.github.com/users/int19h/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/int19h/RTVS","description":"R Tools for Visual Studio.","fork":true,"url":"https://api.github.com/repos/int19h/RTVS","forks_url":"https://api.github.com/repos/int19h/RTVS/forks","keys_url":"https://api.github.com/repos/int19h/RTVS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/int19h/RTVS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/int19h/RTVS/teams","hooks_url":"https://api.github.com/repos/int19h/RTVS/hooks","issue_events_url":"https://api.github.com/repos/int19h/RTVS/issues/events{/number}","events_url":"https://api.github.com/repos/int19h/RTVS/events","assignees_url":"https://api.github.com/repos/int19h/RTVS/assignees{/user}","branches_url":"https://api.github.com/repos/int19h/RTVS/branches{/branch}","tags_url":"https://api.github.com/repos/int19h/RTVS/tags","blobs_url":"https://api.github.com/repos/int19h/RTVS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/int19h/RTVS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/int19h/RTVS/git/refs{/sha}","trees_url":"https://api.github.com/repos/int19h/RTVS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/int19h/RTVS/statuses/{sha}","languages_url":"https://api.github.com/repos/int19h/RTVS/languages","stargazers_url":"https://api.github.com/repos/int19h/RTVS/stargazers","contributors_url":"https://api.github.com/repos/int19h/RTVS/contributors","subscribers_url":"https://api.github.com/repos/int19h/RTVS/subscribers","subscription_url":"https://api.github.com/repos/int19h/RTVS/subscription","commits_url":"https://api.github.com/repos/int19h/RTVS/commits{/sha}","git_commits_url":"https://api.github.com/repos/int19h/RTVS/git/commits{/sha}","comments_url":"https://api.github.com/repos/int19h/RTVS/comments{/number}","issue_comment_url":"https://api.github.com/repos/int19h/RTVS/issues/comments{/number}","contents_url":"https://api.github.com/repos/int19h/RTVS/contents/{+path}","compare_url":"https://api.github.com/repos/int19h/RTVS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/int19h/RTVS/merges","archive_url":"https://api.github.com/repos/int19h/RTVS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/int19h/RTVS/downloads","issues_url":"https://api.github.com/repos/int19h/RTVS/issues{/number}","pulls_url":"https://api.github.com/repos/int19h/RTVS/pulls{/number}","milestones_url":"https://api.github.com/repos/int19h/RTVS/milestones{/number}","notifications_url":"https://api.github.com/repos/int19h/RTVS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/int19h/RTVS/labels{/name}","releases_url":"https://api.github.com/repos/int19h/RTVS/releases{/id}","deployments_url":"https://api.github.com/repos/int19h/RTVS/deployments","created_at":"2016-03-09T16:28:28Z","updated_at":"2016-03-09T16:28:34Z","pushed_at":"2016-10-07T19:15:39Z","git_url":"git://github.com/int19h/RTVS.git","ssh_url":"git@github.com:int19h/RTVS.git","clone_url":"https://github.com/int19h/RTVS.git","svn_url":"https://github.com/int19h/RTVS","homepage":null,"size":51383,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"d1cbc02a5994016637a516eba1aeed67e5a4ac23","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":38640473,"name":"RTVS","full_name":"Microsoft/RTVS","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/RTVS","description":"R Tools for Visual Studio.","fork":false,"url":"https://api.github.com/repos/Microsoft/RTVS","forks_url":"https://api.github.com/repos/Microsoft/RTVS/forks","keys_url":"https://api.github.com/repos/Microsoft/RTVS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/RTVS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/RTVS/teams","hooks_url":"https://api.github.com/repos/Microsoft/RTVS/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/RTVS/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/RTVS/events","assignees_url":"https://api.github.com/repos/Microsoft/RTVS/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/RTVS/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/RTVS/tags","blobs_url":"https://api.github.com/repos/Microsoft/RTVS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/RTVS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/RTVS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/RTVS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/RTVS/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/RTVS/languages","stargazers_url":"https://api.github.com/repos/Microsoft/RTVS/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/RTVS/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/RTVS/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/RTVS/subscription","commits_url":"https://api.github.com/repos/Microsoft/RTVS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/RTVS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/RTVS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/RTVS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/RTVS/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/RTVS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/RTVS/merges","archive_url":"https://api.github.com/repos/Microsoft/RTVS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/RTVS/downloads","issues_url":"https://api.github.com/repos/Microsoft/RTVS/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/RTVS/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/RTVS/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/RTVS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/RTVS/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/RTVS/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/RTVS/deployments","created_at":"2015-07-06T19:14:09Z","updated_at":"2016-10-01T21:28:20Z","pushed_at":"2016-10-07T19:16:29Z","git_url":"git://github.com/Microsoft/RTVS.git","ssh_url":"git@github.com:Microsoft/RTVS.git","clone_url":"https://github.com/Microsoft/RTVS.git","svn_url":"https://github.com/Microsoft/RTVS","homepage":null,"size":52606,"stargazers_count":200,"watchers_count":200,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":337,"forks":54,"open_issues":337,"watchers":200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/2465"},"html":{"href":"https://github.com/Microsoft/RTVS/pull/2465"},"issue":{"href":"https://api.github.com/repos/Microsoft/RTVS/issues/2465"},"comments":{"href":"https://api.github.com/repos/Microsoft/RTVS/issues/2465/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/2465/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/RTVS/pulls/2465/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/RTVS/statuses/a45f519cc1aaa8ba64120dfe531d82c09bfa25ac"}}}}
{"actor":{"display_login":"int19h"}}