{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/73889013","id":73889013,"diff_hunk":"@@ -0,0 +1,107 @@\n+<?php\n+\n+/*\n+ * This file is part of the Sonata Project package.\n+ *\n+ * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace Sonata\\AdminBundle\\Tests\\Twig;\n+\n+use Sonata\\AdminBundle\\Twig\\GlobalVariables;\n+\n+/**\n+ * @author Ahmet Akbana <ahmetakbana@gmail.com>\n+ */\n+final class GlobalVariablesTest extends \\PHPUnit_Framework_TestCase","path":"Tests/Twig/GlobalVariablesTest.php","position":19,"original_position":19,"commit_id":"db44bf86750ff12ffb5261f114bc555b4cd50938","original_commit_id":"db44bf86750ff12ffb5261f114bc555b4cd50938","user":{"login":"ahmetakbn","id":10575905,"avatar_url":"https://avatars.githubusercontent.com/u/10575905?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetakbn","html_url":"https://github.com/ahmetakbn","followers_url":"https://api.github.com/users/ahmetakbn/followers","following_url":"https://api.github.com/users/ahmetakbn/following{/other_user}","gists_url":"https://api.github.com/users/ahmetakbn/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetakbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetakbn/subscriptions","organizations_url":"https://api.github.com/users/ahmetakbn/orgs","repos_url":"https://api.github.com/users/ahmetakbn/repos","events_url":"https://api.github.com/users/ahmetakbn/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetakbn/received_events","type":"User","site_admin":false},"body":"This was always told by @Soullivaneuh in my previous test PRs. Why shouldn't?","created_at":"2016-08-08T14:50:26Z","updated_at":"2016-08-08T14:50:26Z","html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4043#discussion_r73889013","pull_request_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4043","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments/73889013"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/4043#discussion_r73889013"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4043"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4043","id":80269228,"html_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4043","diff_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4043.diff","patch_url":"https://github.com/sonata-project/SonataAdminBundle/pull/4043.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4043","number":4043,"state":"open","locked":false,"title":"changed injection of container to injection of pool","user":{"login":"ahmetakbn","id":10575905,"avatar_url":"https://avatars.githubusercontent.com/u/10575905?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetakbn","html_url":"https://github.com/ahmetakbn","followers_url":"https://api.github.com/users/ahmetakbn/followers","following_url":"https://api.github.com/users/ahmetakbn/following{/other_user}","gists_url":"https://api.github.com/users/ahmetakbn/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetakbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetakbn/subscriptions","organizations_url":"https://api.github.com/users/ahmetakbn/orgs","repos_url":"https://api.github.com/users/ahmetakbn/repos","events_url":"https://api.github.com/users/ahmetakbn/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetakbn/received_events","type":"User","site_admin":false},"body":"<!-- THE PR TEMPLATE IS NOT AN OPTION. DO NOT DELETE IT! -->\r\n\r\n<!--\r\n    Show us you choose the right branch.\r\n    Different branches are used for different things :\r\n    - 3.x is for everything backwards compatible, like patches, features and deprecation notices\r\n    - master is for deprecation removals and other changes that cannot be done without a BC-break\r\n    More details here: https://github.com/sonata-project/SonataAdminBundle/blob/3.x/CONTRIBUTING.md#the-base-branch\r\n-->\r\nI am targetting this branch, because I would like to improve code and test coverage\r\n\r\n<!--\r\n    Specify which issues will be fixed/closed.\r\n    Remove it if this is not related.\r\n-->\r\n\r\n## Changelog\r\n\r\n<!-- MANDATORY\r\n    Fill the changelog part inside the code block.\r\n    Follow this schema: http://keepachangelog.com/\r\n-->\r\n\r\n<!-- REMOVE EMPTY SECTIONS -->\r\n```markdown\r\n\r\n### Changed\r\n- Changed injection of `$container` to `$adminPool` in `Twig/GlobalVariables`\r\n\r\n### Deprecated\r\n- `$container` property in `Twig/GlobalVariables`\r\n```\r\n\r\n## To do\r\n\r\n<!--\r\n    If this is a work in progress, COMPLETE and ADD needed tasks.\r\n    You can add as many tasks as you want.\r\n    If some are not relevant, just REMOVE them.\r\n-->\r\n\r\n- [x] Add test for the class\r\n\r\n## Subject\r\n\r\nImproving code and test coverage\r\n<!-- Describe your Pull Request content here -->\r\n","created_at":"2016-08-05T16:17:11Z","updated_at":"2016-08-08T14:50:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95e6839e0cb712d5105b508372d41a58d3f62927","assignee":{"login":"OskarStark","id":995707,"avatar_url":"https://avatars.githubusercontent.com/u/995707?v=3","gravatar_id":"","url":"https://api.github.com/users/OskarStark","html_url":"https://github.com/OskarStark","followers_url":"https://api.github.com/users/OskarStark/followers","following_url":"https://api.github.com/users/OskarStark/following{/other_user}","gists_url":"https://api.github.com/users/OskarStark/gists{/gist_id}","starred_url":"https://api.github.com/users/OskarStark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OskarStark/subscriptions","organizations_url":"https://api.github.com/users/OskarStark/orgs","repos_url":"https://api.github.com/users/OskarStark/repos","events_url":"https://api.github.com/users/OskarStark/events{/privacy}","received_events_url":"https://api.github.com/users/OskarStark/received_events","type":"User","site_admin":false},"assignees":[{"login":"OskarStark","id":995707,"avatar_url":"https://avatars.githubusercontent.com/u/995707?v=3","gravatar_id":"","url":"https://api.github.com/users/OskarStark","html_url":"https://github.com/OskarStark","followers_url":"https://api.github.com/users/OskarStark/followers","following_url":"https://api.github.com/users/OskarStark/following{/other_user}","gists_url":"https://api.github.com/users/OskarStark/gists{/gist_id}","starred_url":"https://api.github.com/users/OskarStark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OskarStark/subscriptions","organizations_url":"https://api.github.com/users/OskarStark/orgs","repos_url":"https://api.github.com/users/OskarStark/repos","events_url":"https://api.github.com/users/OskarStark/events{/privacy}","received_events_url":"https://api.github.com/users/OskarStark/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4043/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4043/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4043/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/db44bf86750ff12ffb5261f114bc555b4cd50938","head":{"label":"ahmetakbn:code-improve","ref":"code-improve","sha":"db44bf86750ff12ffb5261f114bc555b4cd50938","user":{"login":"ahmetakbn","id":10575905,"avatar_url":"https://avatars.githubusercontent.com/u/10575905?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetakbn","html_url":"https://github.com/ahmetakbn","followers_url":"https://api.github.com/users/ahmetakbn/followers","following_url":"https://api.github.com/users/ahmetakbn/following{/other_user}","gists_url":"https://api.github.com/users/ahmetakbn/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetakbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetakbn/subscriptions","organizations_url":"https://api.github.com/users/ahmetakbn/orgs","repos_url":"https://api.github.com/users/ahmetakbn/repos","events_url":"https://api.github.com/users/ahmetakbn/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetakbn/received_events","type":"User","site_admin":false},"repo":{"id":64850537,"name":"SonataAdminBundle","full_name":"ahmetakbn/SonataAdminBundle","owner":{"login":"ahmetakbn","id":10575905,"avatar_url":"https://avatars.githubusercontent.com/u/10575905?v=3","gravatar_id":"","url":"https://api.github.com/users/ahmetakbn","html_url":"https://github.com/ahmetakbn","followers_url":"https://api.github.com/users/ahmetakbn/followers","following_url":"https://api.github.com/users/ahmetakbn/following{/other_user}","gists_url":"https://api.github.com/users/ahmetakbn/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetakbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetakbn/subscriptions","organizations_url":"https://api.github.com/users/ahmetakbn/orgs","repos_url":"https://api.github.com/users/ahmetakbn/repos","events_url":"https://api.github.com/users/ahmetakbn/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetakbn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahmetakbn/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":true,"url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle","forks_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/ahmetakbn/SonataAdminBundle/deployments","created_at":"2016-08-03T14:00:48Z","updated_at":"2016-08-03T14:00:51Z","pushed_at":"2016-08-08T13:32:33Z","git_url":"git://github.com/ahmetakbn/SonataAdminBundle.git","ssh_url":"git@github.com:ahmetakbn/SonataAdminBundle.git","clone_url":"https://github.com/ahmetakbn/SonataAdminBundle.git","svn_url":"https://github.com/ahmetakbn/SonataAdminBundle","homepage":"http://sonata-project.org/bundles/admin","size":17797,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.x"}},"base":{"label":"sonata-project:3.x","ref":"3.x","sha":"1065722ce4256f8e5c7dd9aacdd1567aefd89480","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1095228,"name":"SonataAdminBundle","full_name":"sonata-project/SonataAdminBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars.githubusercontent.com/u/404157?v=3","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataAdminBundle","description":"AdminBundle - The missing Symfony2 Admin Generator","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataAdminBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/SonataAdminBundle/deployments","created_at":"2010-11-19T17:08:52Z","updated_at":"2016-08-04T18:24:05Z","pushed_at":"2016-08-08T14:20:33Z","git_url":"git://github.com/sonata-project/SonataAdminBundle.git","ssh_url":"git@github.com:sonata-project/SonataAdminBundle.git","clone_url":"https://github.com/sonata-project/SonataAdminBundle.git","svn_url":"https://github.com/sonata-project/SonataAdminBundle","homepage":"http://sonata-project.org/bundles/admin","size":22021,"stargazers_count":1407,"watchers_count":1407,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1005,"mirror_url":null,"open_issues_count":311,"forks":1005,"open_issues":311,"watchers":1407,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4043"},"html":{"href":"https://github.com/sonata-project/SonataAdminBundle/pull/4043"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4043"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/issues/4043/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4043/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/pulls/4043/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataAdminBundle/statuses/db44bf86750ff12ffb5261f114bc555b4cd50938"}}}}
{"actor":{"display_login":"ahmetakbn"}}