{"action":"created","comment":{"url":"https://api.github.com/repos/baidu/tera/pulls/comments/76043071","id":76043071,"diff_hunk":"@@ -21,79 +21,88 @@ namespace tera {\n \n class Client {\n public:\n-    /// 使用glog的用户必须调用此接口，避免glog被重复初始化\n+    // Users who use glog in their own program should call this method to prevent cnofilict.\n     static void SetGlogIsInitialized();\n \n+    // Create a new client\n+    // User should delete Client* if it is no longer needed.\n+    // A Client can be deleted iff all the tables it opened have been deleted.\n     static Client* NewClient(const std::string& confpath,\n                              const std::string& log_prefix,\n                              ErrorCode* err = NULL);\n \n     static Client* NewClient(const std::string& confpath,\n                              ErrorCode* err = NULL);\n-\n     static Client* NewClient();\n \n-    /// 创建表格\n+    // Create a new table with specified descriptor.\n     virtual bool CreateTable(const TableDescriptor& desc, ErrorCode* err) = 0;\n+    // Create a new table with multiple tablets pre-assigned by tablet_delim.\n     virtual bool CreateTable(const TableDescriptor& desc,\n                              const std::vector<std::string>& tablet_delim,\n                              ErrorCode* err) = 0;\n-    /// 更新表格Schema\n+    // Update tablet schema. User should call UpdateCheck to check if the update operation is complete.\n     virtual bool UpdateTable(const TableDescriptor& desc, ErrorCode* err) = 0;\n     virtual bool UpdateCheck(const std::string& table_name, bool* done, ErrorCode* err) = 0;\n-    /// 删除表格\n+    // Delete a table by name. Only a disabled table can be deleted.\n     virtual bool DeleteTable(const std::string& name, ErrorCode* err) = 0;","path":"include/tera/client.h","position":33,"original_position":33,"commit_id":"19205df3593cd42ce65ab3ea24676549ae545c88","original_commit_id":"19205df3593cd42ce65ab3ea24676549ae545c88","user":{"login":"xupeilin","id":11419707,"avatar_url":"https://avatars.githubusercontent.com/u/11419707?v=3","gravatar_id":"","url":"https://api.github.com/users/xupeilin","html_url":"https://github.com/xupeilin","followers_url":"https://api.github.com/users/xupeilin/followers","following_url":"https://api.github.com/users/xupeilin/following{/other_user}","gists_url":"https://api.github.com/users/xupeilin/gists{/gist_id}","starred_url":"https://api.github.com/users/xupeilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xupeilin/subscriptions","organizations_url":"https://api.github.com/users/xupeilin/orgs","repos_url":"https://api.github.com/users/xupeilin/repos","events_url":"https://api.github.com/users/xupeilin/events{/privacy}","received_events_url":"https://api.github.com/users/xupeilin/received_events","type":"User","site_admin":false},"body":"改个名吧，DropTable，和sql看齐","created_at":"2016-08-24T11:59:45Z","updated_at":"2016-08-24T11:59:45Z","html_url":"https://github.com/baidu/tera/pull/984#discussion_r76043071","pull_request_url":"https://api.github.com/repos/baidu/tera/pulls/984","_links":{"self":{"href":"https://api.github.com/repos/baidu/tera/pulls/comments/76043071"},"html":{"href":"https://github.com/baidu/tera/pull/984#discussion_r76043071"},"pull_request":{"href":"https://api.github.com/repos/baidu/tera/pulls/984"}}},"pull_request":{"url":"https://api.github.com/repos/baidu/tera/pulls/984","id":82521509,"html_url":"https://github.com/baidu/tera/pull/984","diff_url":"https://github.com/baidu/tera/pull/984.diff","patch_url":"https://github.com/baidu/tera/pull/984.patch","issue_url":"https://api.github.com/repos/baidu/tera/issues/984","number":984,"state":"open","locked":false,"title":"modify client.h #964","user":{"login":"lylei","id":2767333,"avatar_url":"https://avatars.githubusercontent.com/u/2767333?v=3","gravatar_id":"","url":"https://api.github.com/users/lylei","html_url":"https://github.com/lylei","followers_url":"https://api.github.com/users/lylei/followers","following_url":"https://api.github.com/users/lylei/following{/other_user}","gists_url":"https://api.github.com/users/lylei/gists{/gist_id}","starred_url":"https://api.github.com/users/lylei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lylei/subscriptions","organizations_url":"https://api.github.com/users/lylei/orgs","repos_url":"https://api.github.com/users/lylei/repos","events_url":"https://api.github.com/users/lylei/events{/privacy}","received_events_url":"https://api.github.com/users/lylei/received_events","type":"User","site_admin":false},"body":"#964","created_at":"2016-08-24T10:56:40Z","updated_at":"2016-08-24T11:59:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52ac0153b2963321155acebb1544eec7dfaa7d20","assignee":{"login":"caijieming-baidu","id":13461134,"avatar_url":"https://avatars.githubusercontent.com/u/13461134?v=3","gravatar_id":"","url":"https://api.github.com/users/caijieming-baidu","html_url":"https://github.com/caijieming-baidu","followers_url":"https://api.github.com/users/caijieming-baidu/followers","following_url":"https://api.github.com/users/caijieming-baidu/following{/other_user}","gists_url":"https://api.github.com/users/caijieming-baidu/gists{/gist_id}","starred_url":"https://api.github.com/users/caijieming-baidu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caijieming-baidu/subscriptions","organizations_url":"https://api.github.com/users/caijieming-baidu/orgs","repos_url":"https://api.github.com/users/caijieming-baidu/repos","events_url":"https://api.github.com/users/caijieming-baidu/events{/privacy}","received_events_url":"https://api.github.com/users/caijieming-baidu/received_events","type":"User","site_admin":false},"assignees":[{"login":"caijieming-baidu","id":13461134,"avatar_url":"https://avatars.githubusercontent.com/u/13461134?v=3","gravatar_id":"","url":"https://api.github.com/users/caijieming-baidu","html_url":"https://github.com/caijieming-baidu","followers_url":"https://api.github.com/users/caijieming-baidu/followers","following_url":"https://api.github.com/users/caijieming-baidu/following{/other_user}","gists_url":"https://api.github.com/users/caijieming-baidu/gists{/gist_id}","starred_url":"https://api.github.com/users/caijieming-baidu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caijieming-baidu/subscriptions","organizations_url":"https://api.github.com/users/caijieming-baidu/orgs","repos_url":"https://api.github.com/users/caijieming-baidu/repos","events_url":"https://api.github.com/users/caijieming-baidu/events{/privacy}","received_events_url":"https://api.github.com/users/caijieming-baidu/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/baidu/tera/pulls/984/commits","review_comments_url":"https://api.github.com/repos/baidu/tera/pulls/984/comments","review_comment_url":"https://api.github.com/repos/baidu/tera/pulls/comments{/number}","comments_url":"https://api.github.com/repos/baidu/tera/issues/984/comments","statuses_url":"https://api.github.com/repos/baidu/tera/statuses/19205df3593cd42ce65ab3ea24676549ae545c88","head":{"label":"lylei:master","ref":"master","sha":"19205df3593cd42ce65ab3ea24676549ae545c88","user":{"login":"lylei","id":2767333,"avatar_url":"https://avatars.githubusercontent.com/u/2767333?v=3","gravatar_id":"","url":"https://api.github.com/users/lylei","html_url":"https://github.com/lylei","followers_url":"https://api.github.com/users/lylei/followers","following_url":"https://api.github.com/users/lylei/following{/other_user}","gists_url":"https://api.github.com/users/lylei/gists{/gist_id}","starred_url":"https://api.github.com/users/lylei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lylei/subscriptions","organizations_url":"https://api.github.com/users/lylei/orgs","repos_url":"https://api.github.com/users/lylei/repos","events_url":"https://api.github.com/users/lylei/events{/privacy}","received_events_url":"https://api.github.com/users/lylei/received_events","type":"User","site_admin":false},"repo":{"id":38722702,"name":"tera","full_name":"lylei/tera","owner":{"login":"lylei","id":2767333,"avatar_url":"https://avatars.githubusercontent.com/u/2767333?v=3","gravatar_id":"","url":"https://api.github.com/users/lylei","html_url":"https://github.com/lylei","followers_url":"https://api.github.com/users/lylei/followers","following_url":"https://api.github.com/users/lylei/following{/other_user}","gists_url":"https://api.github.com/users/lylei/gists{/gist_id}","starred_url":"https://api.github.com/users/lylei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lylei/subscriptions","organizations_url":"https://api.github.com/users/lylei/orgs","repos_url":"https://api.github.com/users/lylei/repos","events_url":"https://api.github.com/users/lylei/events{/privacy}","received_events_url":"https://api.github.com/users/lylei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lylei/tera","description":"A distributed table storage system.","fork":true,"url":"https://api.github.com/repos/lylei/tera","forks_url":"https://api.github.com/repos/lylei/tera/forks","keys_url":"https://api.github.com/repos/lylei/tera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lylei/tera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lylei/tera/teams","hooks_url":"https://api.github.com/repos/lylei/tera/hooks","issue_events_url":"https://api.github.com/repos/lylei/tera/issues/events{/number}","events_url":"https://api.github.com/repos/lylei/tera/events","assignees_url":"https://api.github.com/repos/lylei/tera/assignees{/user}","branches_url":"https://api.github.com/repos/lylei/tera/branches{/branch}","tags_url":"https://api.github.com/repos/lylei/tera/tags","blobs_url":"https://api.github.com/repos/lylei/tera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lylei/tera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lylei/tera/git/refs{/sha}","trees_url":"https://api.github.com/repos/lylei/tera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lylei/tera/statuses/{sha}","languages_url":"https://api.github.com/repos/lylei/tera/languages","stargazers_url":"https://api.github.com/repos/lylei/tera/stargazers","contributors_url":"https://api.github.com/repos/lylei/tera/contributors","subscribers_url":"https://api.github.com/repos/lylei/tera/subscribers","subscription_url":"https://api.github.com/repos/lylei/tera/subscription","commits_url":"https://api.github.com/repos/lylei/tera/commits{/sha}","git_commits_url":"https://api.github.com/repos/lylei/tera/git/commits{/sha}","comments_url":"https://api.github.com/repos/lylei/tera/comments{/number}","issue_comment_url":"https://api.github.com/repos/lylei/tera/issues/comments{/number}","contents_url":"https://api.github.com/repos/lylei/tera/contents/{+path}","compare_url":"https://api.github.com/repos/lylei/tera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lylei/tera/merges","archive_url":"https://api.github.com/repos/lylei/tera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lylei/tera/downloads","issues_url":"https://api.github.com/repos/lylei/tera/issues{/number}","pulls_url":"https://api.github.com/repos/lylei/tera/pulls{/number}","milestones_url":"https://api.github.com/repos/lylei/tera/milestones{/number}","notifications_url":"https://api.github.com/repos/lylei/tera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lylei/tera/labels{/name}","releases_url":"https://api.github.com/repos/lylei/tera/releases{/id}","deployments_url":"https://api.github.com/repos/lylei/tera/deployments","created_at":"2015-07-08T00:38:56Z","updated_at":"2016-04-14T07:25:35Z","pushed_at":"2016-08-24T10:56:15Z","git_url":"git://github.com/lylei/tera.git","ssh_url":"git@github.com:lylei/tera.git","clone_url":"https://github.com/lylei/tera.git","svn_url":"https://github.com/lylei/tera","homepage":"","size":13704,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"baidu:master","ref":"master","sha":"0594712d4bb08b46c0c2c83199939003eadf289a","user":{"login":"baidu","id":13245940,"avatar_url":"https://avatars.githubusercontent.com/u/13245940?v=3","gravatar_id":"","url":"https://api.github.com/users/baidu","html_url":"https://github.com/baidu","followers_url":"https://api.github.com/users/baidu/followers","following_url":"https://api.github.com/users/baidu/following{/other_user}","gists_url":"https://api.github.com/users/baidu/gists{/gist_id}","starred_url":"https://api.github.com/users/baidu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baidu/subscriptions","organizations_url":"https://api.github.com/users/baidu/orgs","repos_url":"https://api.github.com/users/baidu/repos","events_url":"https://api.github.com/users/baidu/events{/privacy}","received_events_url":"https://api.github.com/users/baidu/received_events","type":"Organization","site_admin":false},"repo":{"id":18129915,"name":"tera","full_name":"baidu/tera","owner":{"login":"baidu","id":13245940,"avatar_url":"https://avatars.githubusercontent.com/u/13245940?v=3","gravatar_id":"","url":"https://api.github.com/users/baidu","html_url":"https://github.com/baidu","followers_url":"https://api.github.com/users/baidu/followers","following_url":"https://api.github.com/users/baidu/following{/other_user}","gists_url":"https://api.github.com/users/baidu/gists{/gist_id}","starred_url":"https://api.github.com/users/baidu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baidu/subscriptions","organizations_url":"https://api.github.com/users/baidu/orgs","repos_url":"https://api.github.com/users/baidu/repos","events_url":"https://api.github.com/users/baidu/events{/privacy}","received_events_url":"https://api.github.com/users/baidu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/baidu/tera","description":"A distributed, elastic, structured database.","fork":false,"url":"https://api.github.com/repos/baidu/tera","forks_url":"https://api.github.com/repos/baidu/tera/forks","keys_url":"https://api.github.com/repos/baidu/tera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baidu/tera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baidu/tera/teams","hooks_url":"https://api.github.com/repos/baidu/tera/hooks","issue_events_url":"https://api.github.com/repos/baidu/tera/issues/events{/number}","events_url":"https://api.github.com/repos/baidu/tera/events","assignees_url":"https://api.github.com/repos/baidu/tera/assignees{/user}","branches_url":"https://api.github.com/repos/baidu/tera/branches{/branch}","tags_url":"https://api.github.com/repos/baidu/tera/tags","blobs_url":"https://api.github.com/repos/baidu/tera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baidu/tera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baidu/tera/git/refs{/sha}","trees_url":"https://api.github.com/repos/baidu/tera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baidu/tera/statuses/{sha}","languages_url":"https://api.github.com/repos/baidu/tera/languages","stargazers_url":"https://api.github.com/repos/baidu/tera/stargazers","contributors_url":"https://api.github.com/repos/baidu/tera/contributors","subscribers_url":"https://api.github.com/repos/baidu/tera/subscribers","subscription_url":"https://api.github.com/repos/baidu/tera/subscription","commits_url":"https://api.github.com/repos/baidu/tera/commits{/sha}","git_commits_url":"https://api.github.com/repos/baidu/tera/git/commits{/sha}","comments_url":"https://api.github.com/repos/baidu/tera/comments{/number}","issue_comment_url":"https://api.github.com/repos/baidu/tera/issues/comments{/number}","contents_url":"https://api.github.com/repos/baidu/tera/contents/{+path}","compare_url":"https://api.github.com/repos/baidu/tera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baidu/tera/merges","archive_url":"https://api.github.com/repos/baidu/tera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baidu/tera/downloads","issues_url":"https://api.github.com/repos/baidu/tera/issues{/number}","pulls_url":"https://api.github.com/repos/baidu/tera/pulls{/number}","milestones_url":"https://api.github.com/repos/baidu/tera/milestones{/number}","notifications_url":"https://api.github.com/repos/baidu/tera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baidu/tera/labels{/name}","releases_url":"https://api.github.com/repos/baidu/tera/releases{/id}","deployments_url":"https://api.github.com/repos/baidu/tera/deployments","created_at":"2014-03-26T07:22:05Z","updated_at":"2016-08-23T10:06:45Z","pushed_at":"2016-08-24T11:55:18Z","git_url":"git://github.com/baidu/tera.git","ssh_url":"git@github.com:baidu/tera.git","clone_url":"https://github.com/baidu/tera.git","svn_url":"https://github.com/baidu/tera","homepage":"","size":17569,"stargazers_count":412,"watchers_count":412,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":149,"mirror_url":null,"open_issues_count":160,"forks":149,"open_issues":160,"watchers":412,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/baidu/tera/pulls/984"},"html":{"href":"https://github.com/baidu/tera/pull/984"},"issue":{"href":"https://api.github.com/repos/baidu/tera/issues/984"},"comments":{"href":"https://api.github.com/repos/baidu/tera/issues/984/comments"},"review_comments":{"href":"https://api.github.com/repos/baidu/tera/pulls/984/comments"},"review_comment":{"href":"https://api.github.com/repos/baidu/tera/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/baidu/tera/pulls/984/commits"},"statuses":{"href":"https://api.github.com/repos/baidu/tera/statuses/19205df3593cd42ce65ab3ea24676549ae545c88"}}}}
{"actor":{"display_login":"xupeilin"}}