{"action":"created","issue":{"url":"https://api.github.com/repos/samg/timetrap/issues/116","repository_url":"https://api.github.com/repos/samg/timetrap","labels_url":"https://api.github.com/repos/samg/timetrap/issues/116/labels{/name}","comments_url":"https://api.github.com/repos/samg/timetrap/issues/116/comments","events_url":"https://api.github.com/repos/samg/timetrap/issues/116/events","html_url":"https://github.com/samg/timetrap/pull/116","id":111745048,"number":116,"title":"Update the resume action to allow resuming by id, removes some old functionality","user":{"login":"marcaddeo","id":199649,"avatar_url":"https://avatars.githubusercontent.com/u/199649?v=3","gravatar_id":"","url":"https://api.github.com/users/marcaddeo","html_url":"https://github.com/marcaddeo","followers_url":"https://api.github.com/users/marcaddeo/followers","following_url":"https://api.github.com/users/marcaddeo/following{/other_user}","gists_url":"https://api.github.com/users/marcaddeo/gists{/gist_id}","starred_url":"https://api.github.com/users/marcaddeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcaddeo/subscriptions","organizations_url":"https://api.github.com/users/marcaddeo/orgs","repos_url":"https://api.github.com/users/marcaddeo/repos","events_url":"https://api.github.com/users/marcaddeo/events{/privacy}","received_events_url":"https://api.github.com/users/marcaddeo/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2015-10-16T02:22:05Z","updated_at":"2016-08-11T21:33:28Z","closed_at":"2015-10-25T03:49:02Z","pull_request":{"url":"https://api.github.com/repos/samg/timetrap/pulls/116","html_url":"https://github.com/samg/timetrap/pull/116","diff_url":"https://github.com/samg/timetrap/pull/116.diff","patch_url":"https://github.com/samg/timetrap/pull/116.patch"},"body":"This changes the resume action to allow you to either resume by an id,\r\nor resume the last checked out entry.\r\n\r\nThis removes the functionality that allowed you to change the note on\r\nthe last entry, or start a new entry with the new note. IMO the former\r\nshould just be accomplished by using the edit action, and the latter\r\nwith the in action. I don't think there's any need to duplicate the\r\nfunctionality of those actions within the resume action.\r\n\r\nAddresses #114 \r\n\r\n@samg definitely want to open a discussion on this change, as I'm removing some functionality of the resume action. Let me know your thoughts!"},"comment":{"url":"https://api.github.com/repos/samg/timetrap/issues/comments/239299768","html_url":"https://github.com/samg/timetrap/pull/116#issuecomment-239299768","issue_url":"https://api.github.com/repos/samg/timetrap/issues/116","id":239299768,"user":{"login":"samg","id":22148,"avatar_url":"https://avatars.githubusercontent.com/u/22148?v=3","gravatar_id":"","url":"https://api.github.com/users/samg","html_url":"https://github.com/samg","followers_url":"https://api.github.com/users/samg/followers","following_url":"https://api.github.com/users/samg/following{/other_user}","gists_url":"https://api.github.com/users/samg/gists{/gist_id}","starred_url":"https://api.github.com/users/samg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samg/subscriptions","organizations_url":"https://api.github.com/users/samg/orgs","repos_url":"https://api.github.com/users/samg/repos","events_url":"https://api.github.com/users/samg/events{/privacy}","received_events_url":"https://api.github.com/users/samg/received_events","type":"User","site_admin":false},"created_at":"2016-08-11T21:33:28Z","updated_at":"2016-08-11T21:33:28Z","body":"@hansdez this does seem to me like a regression.  Seems that `resume` should default to the last entry on the current sheet, since otherwise we end up with the counterintuitive pulling entries across sheets which seems like it's usually the wrong thing.\r\n\r\n@marcaddeo let me know if you disagree, or think the current behavior is more desirable for other use cases. \r\n\r\nI'd also be easy to make this configurable, though that seems like it'd probably be better to avoid that."}}
{"actor":{"display_login":"samg"}}