{"action":"created","issue":{"url":"https://api.github.com/repos/BluSunrize/ImmersiveEngineering/issues/1621","repository_url":"https://api.github.com/repos/BluSunrize/ImmersiveEngineering","labels_url":"https://api.github.com/repos/BluSunrize/ImmersiveEngineering/issues/1621/labels{/name}","comments_url":"https://api.github.com/repos/BluSunrize/ImmersiveEngineering/issues/1621/comments","events_url":"https://api.github.com/repos/BluSunrize/ImmersiveEngineering/issues/1621/events","html_url":"https://github.com/BluSunrize/ImmersiveEngineering/issues/1621","id":184389437,"number":1621,"title":"0.47 Pipes are causing extreme performance loss","user":{"login":"StarvingPoet","id":22769341,"avatar_url":"https://avatars.githubusercontent.com/u/22769341?v=3","gravatar_id":"","url":"https://api.github.com/users/StarvingPoet","html_url":"https://github.com/StarvingPoet","followers_url":"https://api.github.com/users/StarvingPoet/followers","following_url":"https://api.github.com/users/StarvingPoet/following{/other_user}","gists_url":"https://api.github.com/users/StarvingPoet/gists{/gist_id}","starred_url":"https://api.github.com/users/StarvingPoet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StarvingPoet/subscriptions","organizations_url":"https://api.github.com/users/StarvingPoet/orgs","repos_url":"https://api.github.com/users/StarvingPoet/repos","events_url":"https://api.github.com/users/StarvingPoet/events{/privacy}","received_events_url":"https://api.github.com/users/StarvingPoet/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-21T03:05:33Z","updated_at":"2016-10-21T16:22:59Z","closed_at":null,"body":"Only mod IE 0.47\r\nsuperflat test world\r\n6x30 section of pipes.\r\n\r\n(Behavior does not persist in 0.44)\r\n\r\nWhen a large number of pipes are loaded, they cause substantial drop in fps when placing or removing blocks with block lag that increases with the number of pipes in immediate area (150 fps -> 20).   \r\n\r\nMight be related to this commit: https://github.com/BluSunrize/ImmersiveEngineering/commit/41fe8090fc9da4d617ee16653f9a1a1d006ad8e9\r\n\r\nIf using optifine / shaders, it can cause client to CTD with the following error - usually only occurs if trying to log into server in an area with pipes.\r\n```\r\n -- Block being tesselated --\r\n[B#347] 2016/10/20 21:33:07 [INFO]  Details:\r\n[B#347] 2016/10/20 21:33:07 [INFO]  \tBlock type: ID #404 (tile.immersiveengineering.metalDevice1 // blusunrize.immersiveengineering.common.blocks.metal.BlockMetalDevice1)\r\n[B#347] 2016/10/20 21:33:07 [INFO]  \tBlock data value: 6 / 0x6 / 0b0110\r\n[B#347] 2016/10/20 21:33:07 [INFO]  \tBlock location: World: (-446,27,278), Chunk: (at 2,1,6 in -28,17; contains blocks -448,0,272 to -433,255,287), Region: (-1,0; contains chunks -32,0 to -1,31, blocks -512,0,0 to -1,255,511)\r\n[B#347] 2016/10/20 21:33:07 [INFO]  Stacktrace:\r\n[B#347] 2016/10/20 21:33:07 [INFO]  \tat net.minecraft.client.renderer.BlockRendererDispatcher.func_175018_a(BlockRendererDispatcher.java:81)\r\n[B#347] 2016/10/20 21:33:07 [INFO]  \tat mods.betterfoliage.client.Hooks.renderWorldBlock(Hooks.kt:97)\r\n```"},"comment":{"url":"https://api.github.com/repos/BluSunrize/ImmersiveEngineering/issues/comments/255420712","html_url":"https://github.com/BluSunrize/ImmersiveEngineering/issues/1621#issuecomment-255420712","issue_url":"https://api.github.com/repos/BluSunrize/ImmersiveEngineering/issues/1621","id":255420712,"user":{"login":"malte0811","id":10406104,"avatar_url":"https://avatars.githubusercontent.com/u/10406104?v=3","gravatar_id":"","url":"https://api.github.com/users/malte0811","html_url":"https://github.com/malte0811","followers_url":"https://api.github.com/users/malte0811/followers","following_url":"https://api.github.com/users/malte0811/following{/other_user}","gists_url":"https://api.github.com/users/malte0811/gists{/gist_id}","starred_url":"https://api.github.com/users/malte0811/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malte0811/subscriptions","organizations_url":"https://api.github.com/users/malte0811/orgs","repos_url":"https://api.github.com/users/malte0811/repos","events_url":"https://api.github.com/users/malte0811/events{/privacy}","received_events_url":"https://api.github.com/users/malte0811/received_events","type":"User","site_admin":false},"created_at":"2016-10-21T16:22:59Z","updated_at":"2016-10-21T16:22:59Z","body":"Ok, I take back everything I said, I had VisualVM configured to only profile IE classes. It is my fault, but I messed up in 80d5d88e69c9785b0720a803f50090cfb707ec12, not 41fe8090fc9da4d617ee16653f9a1a1d006ad8e9. This commit caused the value of the IOBJModelCallback property to be compared, and since that is the TE the values didn't match even when the hash values matched. This caused a lot of new models to be generated, which obviously caused lag. This was amplified by the time-expensive cache key calculation for the pipes, but they are not the root cause of this."}}
{"actor":{"display_login":"malte0811"}}