{"action":"closed","number":816,"pull_request":{"url":"https://api.github.com/repos/gionkunz/chartist-js/pulls/816","id":90003362,"html_url":"https://github.com/gionkunz/chartist-js/pull/816","diff_url":"https://github.com/gionkunz/chartist-js/pull/816.diff","patch_url":"https://github.com/gionkunz/chartist-js/pull/816.patch","issue_url":"https://api.github.com/repos/gionkunz/chartist-js/issues/816","number":816,"state":"closed","locked":false,"title":"Fix handling of holes in interpolation for multi-value series","user":{"login":"ammojamo","id":89878,"avatar_url":"https://avatars.githubusercontent.com/u/89878?v=3","gravatar_id":"","url":"https://api.github.com/users/ammojamo","html_url":"https://github.com/ammojamo","followers_url":"https://api.github.com/users/ammojamo/followers","following_url":"https://api.github.com/users/ammojamo/following{/other_user}","gists_url":"https://api.github.com/users/ammojamo/gists{/gist_id}","starred_url":"https://api.github.com/users/ammojamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ammojamo/subscriptions","organizations_url":"https://api.github.com/users/ammojamo/orgs","repos_url":"https://api.github.com/users/ammojamo/repos","events_url":"https://api.github.com/users/ammojamo/events{/privacy}","received_events_url":"https://api.github.com/users/ammojamo/received_events","type":"User","site_admin":false},"body":"This PR fixes issue https://github.com/gionkunz/chartist-js/issues/633\r\n\r\nI haven't added any new tests, but all existing tests pass. I've added a multi value series to the holes in data examples which demonstrates the fix.\r\n\r\nI had to change some logic in core functions `Chartist.isNum` and `Chartist.getNumberOrUndefined` and `Chartist.getMultiValue` because these functions did not handle `null` properly.","created_at":"2016-10-19T12:55:24Z","updated_at":"2016-10-19T13:22:29Z","closed_at":"2016-10-19T13:22:29Z","merged_at":"2016-10-19T13:22:29Z","merge_commit_sha":"e9a2e1ebc8204abd5d733f0a3789f58dfcae3124","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gionkunz/chartist-js/pulls/816/commits","review_comments_url":"https://api.github.com/repos/gionkunz/chartist-js/pulls/816/comments","review_comment_url":"https://api.github.com/repos/gionkunz/chartist-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gionkunz/chartist-js/issues/816/comments","statuses_url":"https://api.github.com/repos/gionkunz/chartist-js/statuses/0fc6f9f48c70c4c76927601f9b547ee454a29843","head":{"label":"ammojamo:develop","ref":"develop","sha":"0fc6f9f48c70c4c76927601f9b547ee454a29843","user":{"login":"ammojamo","id":89878,"avatar_url":"https://avatars.githubusercontent.com/u/89878?v=3","gravatar_id":"","url":"https://api.github.com/users/ammojamo","html_url":"https://github.com/ammojamo","followers_url":"https://api.github.com/users/ammojamo/followers","following_url":"https://api.github.com/users/ammojamo/following{/other_user}","gists_url":"https://api.github.com/users/ammojamo/gists{/gist_id}","starred_url":"https://api.github.com/users/ammojamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ammojamo/subscriptions","organizations_url":"https://api.github.com/users/ammojamo/orgs","repos_url":"https://api.github.com/users/ammojamo/repos","events_url":"https://api.github.com/users/ammojamo/events{/privacy}","received_events_url":"https://api.github.com/users/ammojamo/received_events","type":"User","site_admin":false},"repo":{"id":52767535,"name":"chartist-js","full_name":"ammojamo/chartist-js","owner":{"login":"ammojamo","id":89878,"avatar_url":"https://avatars.githubusercontent.com/u/89878?v=3","gravatar_id":"","url":"https://api.github.com/users/ammojamo","html_url":"https://github.com/ammojamo","followers_url":"https://api.github.com/users/ammojamo/followers","following_url":"https://api.github.com/users/ammojamo/following{/other_user}","gists_url":"https://api.github.com/users/ammojamo/gists{/gist_id}","starred_url":"https://api.github.com/users/ammojamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ammojamo/subscriptions","organizations_url":"https://api.github.com/users/ammojamo/orgs","repos_url":"https://api.github.com/users/ammojamo/repos","events_url":"https://api.github.com/users/ammojamo/events{/privacy}","received_events_url":"https://api.github.com/users/ammojamo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ammojamo/chartist-js","description":"Simple responsive charts","fork":true,"url":"https://api.github.com/repos/ammojamo/chartist-js","forks_url":"https://api.github.com/repos/ammojamo/chartist-js/forks","keys_url":"https://api.github.com/repos/ammojamo/chartist-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ammojamo/chartist-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ammojamo/chartist-js/teams","hooks_url":"https://api.github.com/repos/ammojamo/chartist-js/hooks","issue_events_url":"https://api.github.com/repos/ammojamo/chartist-js/issues/events{/number}","events_url":"https://api.github.com/repos/ammojamo/chartist-js/events","assignees_url":"https://api.github.com/repos/ammojamo/chartist-js/assignees{/user}","branches_url":"https://api.github.com/repos/ammojamo/chartist-js/branches{/branch}","tags_url":"https://api.github.com/repos/ammojamo/chartist-js/tags","blobs_url":"https://api.github.com/repos/ammojamo/chartist-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ammojamo/chartist-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ammojamo/chartist-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/ammojamo/chartist-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ammojamo/chartist-js/statuses/{sha}","languages_url":"https://api.github.com/repos/ammojamo/chartist-js/languages","stargazers_url":"https://api.github.com/repos/ammojamo/chartist-js/stargazers","contributors_url":"https://api.github.com/repos/ammojamo/chartist-js/contributors","subscribers_url":"https://api.github.com/repos/ammojamo/chartist-js/subscribers","subscription_url":"https://api.github.com/repos/ammojamo/chartist-js/subscription","commits_url":"https://api.github.com/repos/ammojamo/chartist-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/ammojamo/chartist-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/ammojamo/chartist-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/ammojamo/chartist-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/ammojamo/chartist-js/contents/{+path}","compare_url":"https://api.github.com/repos/ammojamo/chartist-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ammojamo/chartist-js/merges","archive_url":"https://api.github.com/repos/ammojamo/chartist-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ammojamo/chartist-js/downloads","issues_url":"https://api.github.com/repos/ammojamo/chartist-js/issues{/number}","pulls_url":"https://api.github.com/repos/ammojamo/chartist-js/pulls{/number}","milestones_url":"https://api.github.com/repos/ammojamo/chartist-js/milestones{/number}","notifications_url":"https://api.github.com/repos/ammojamo/chartist-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ammojamo/chartist-js/labels{/name}","releases_url":"https://api.github.com/repos/ammojamo/chartist-js/releases{/id}","deployments_url":"https://api.github.com/repos/ammojamo/chartist-js/deployments","created_at":"2016-02-29T05:51:38Z","updated_at":"2016-02-29T05:51:41Z","pushed_at":"2016-10-19T12:39:26Z","git_url":"git://github.com/ammojamo/chartist-js.git","ssh_url":"git@github.com:ammojamo/chartist-js.git","clone_url":"https://github.com/ammojamo/chartist-js.git","svn_url":"https://github.com/ammojamo/chartist-js","homepage":"","size":10952,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"gionkunz:develop","ref":"develop","sha":"b25cd55ebe28b788fb3b47051728e75e9bfaed09","user":{"login":"gionkunz","id":2203704,"avatar_url":"https://avatars.githubusercontent.com/u/2203704?v=3","gravatar_id":"","url":"https://api.github.com/users/gionkunz","html_url":"https://github.com/gionkunz","followers_url":"https://api.github.com/users/gionkunz/followers","following_url":"https://api.github.com/users/gionkunz/following{/other_user}","gists_url":"https://api.github.com/users/gionkunz/gists{/gist_id}","starred_url":"https://api.github.com/users/gionkunz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gionkunz/subscriptions","organizations_url":"https://api.github.com/users/gionkunz/orgs","repos_url":"https://api.github.com/users/gionkunz/repos","events_url":"https://api.github.com/users/gionkunz/events{/privacy}","received_events_url":"https://api.github.com/users/gionkunz/received_events","type":"User","site_admin":false},"repo":{"id":17575535,"name":"chartist-js","full_name":"gionkunz/chartist-js","owner":{"login":"gionkunz","id":2203704,"avatar_url":"https://avatars.githubusercontent.com/u/2203704?v=3","gravatar_id":"","url":"https://api.github.com/users/gionkunz","html_url":"https://github.com/gionkunz","followers_url":"https://api.github.com/users/gionkunz/followers","following_url":"https://api.github.com/users/gionkunz/following{/other_user}","gists_url":"https://api.github.com/users/gionkunz/gists{/gist_id}","starred_url":"https://api.github.com/users/gionkunz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gionkunz/subscriptions","organizations_url":"https://api.github.com/users/gionkunz/orgs","repos_url":"https://api.github.com/users/gionkunz/repos","events_url":"https://api.github.com/users/gionkunz/events{/privacy}","received_events_url":"https://api.github.com/users/gionkunz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gionkunz/chartist-js","description":"Simple responsive charts","fork":false,"url":"https://api.github.com/repos/gionkunz/chartist-js","forks_url":"https://api.github.com/repos/gionkunz/chartist-js/forks","keys_url":"https://api.github.com/repos/gionkunz/chartist-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gionkunz/chartist-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gionkunz/chartist-js/teams","hooks_url":"https://api.github.com/repos/gionkunz/chartist-js/hooks","issue_events_url":"https://api.github.com/repos/gionkunz/chartist-js/issues/events{/number}","events_url":"https://api.github.com/repos/gionkunz/chartist-js/events","assignees_url":"https://api.github.com/repos/gionkunz/chartist-js/assignees{/user}","branches_url":"https://api.github.com/repos/gionkunz/chartist-js/branches{/branch}","tags_url":"https://api.github.com/repos/gionkunz/chartist-js/tags","blobs_url":"https://api.github.com/repos/gionkunz/chartist-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gionkunz/chartist-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gionkunz/chartist-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/gionkunz/chartist-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gionkunz/chartist-js/statuses/{sha}","languages_url":"https://api.github.com/repos/gionkunz/chartist-js/languages","stargazers_url":"https://api.github.com/repos/gionkunz/chartist-js/stargazers","contributors_url":"https://api.github.com/repos/gionkunz/chartist-js/contributors","subscribers_url":"https://api.github.com/repos/gionkunz/chartist-js/subscribers","subscription_url":"https://api.github.com/repos/gionkunz/chartist-js/subscription","commits_url":"https://api.github.com/repos/gionkunz/chartist-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/gionkunz/chartist-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/gionkunz/chartist-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/gionkunz/chartist-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/gionkunz/chartist-js/contents/{+path}","compare_url":"https://api.github.com/repos/gionkunz/chartist-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gionkunz/chartist-js/merges","archive_url":"https://api.github.com/repos/gionkunz/chartist-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gionkunz/chartist-js/downloads","issues_url":"https://api.github.com/repos/gionkunz/chartist-js/issues{/number}","pulls_url":"https://api.github.com/repos/gionkunz/chartist-js/pulls{/number}","milestones_url":"https://api.github.com/repos/gionkunz/chartist-js/milestones{/number}","notifications_url":"https://api.github.com/repos/gionkunz/chartist-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gionkunz/chartist-js/labels{/name}","releases_url":"https://api.github.com/repos/gionkunz/chartist-js/releases{/id}","deployments_url":"https://api.github.com/repos/gionkunz/chartist-js/deployments","created_at":"2014-03-09T22:40:07Z","updated_at":"2016-10-19T11:46:29Z","pushed_at":"2016-10-19T13:22:29Z","git_url":"git://github.com/gionkunz/chartist-js.git","ssh_url":"git@github.com:gionkunz/chartist-js.git","clone_url":"https://github.com/gionkunz/chartist-js.git","svn_url":"https://github.com/gionkunz/chartist-js","homepage":"","size":12425,"stargazers_count":8676,"watchers_count":8676,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1367,"mirror_url":null,"open_issues_count":84,"forks":1367,"open_issues":84,"watchers":8676,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gionkunz/chartist-js/pulls/816"},"html":{"href":"https://github.com/gionkunz/chartist-js/pull/816"},"issue":{"href":"https://api.github.com/repos/gionkunz/chartist-js/issues/816"},"comments":{"href":"https://api.github.com/repos/gionkunz/chartist-js/issues/816/comments"},"review_comments":{"href":"https://api.github.com/repos/gionkunz/chartist-js/pulls/816/comments"},"review_comment":{"href":"https://api.github.com/repos/gionkunz/chartist-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gionkunz/chartist-js/pulls/816/commits"},"statuses":{"href":"https://api.github.com/repos/gionkunz/chartist-js/statuses/0fc6f9f48c70c4c76927601f9b547ee454a29843"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gionkunz","id":2203704,"avatar_url":"https://avatars.githubusercontent.com/u/2203704?v=3","gravatar_id":"","url":"https://api.github.com/users/gionkunz","html_url":"https://github.com/gionkunz","followers_url":"https://api.github.com/users/gionkunz/followers","following_url":"https://api.github.com/users/gionkunz/following{/other_user}","gists_url":"https://api.github.com/users/gionkunz/gists{/gist_id}","starred_url":"https://api.github.com/users/gionkunz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gionkunz/subscriptions","organizations_url":"https://api.github.com/users/gionkunz/orgs","repos_url":"https://api.github.com/users/gionkunz/repos","events_url":"https://api.github.com/users/gionkunz/events{/privacy}","received_events_url":"https://api.github.com/users/gionkunz/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":16,"deletions":12,"changed_files":6}}
{"actor":{"display_login":"gionkunz"}}