{"action":"opened","number":15575,"pull_request":{"url":"https://api.github.com/repos/everypolitician/viewer-sinatra/pulls/15575","id":86762420,"html_url":"https://github.com/everypolitician/viewer-sinatra/pull/15575","diff_url":"https://github.com/everypolitician/viewer-sinatra/pull/15575.diff","patch_url":"https://github.com/everypolitician/viewer-sinatra/pull/15575.patch","issue_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/issues/15575","number":15575,"state":"open","locked":false,"title":"Check for supported version of html-tidy in tests","user":{"login":"chrismytton","id":22996,"avatar_url":"https://avatars.githubusercontent.com/u/22996?v=3","gravatar_id":"","url":"https://api.github.com/users/chrismytton","html_url":"https://github.com/chrismytton","followers_url":"https://api.github.com/users/chrismytton/followers","following_url":"https://api.github.com/users/chrismytton/following{/other_user}","gists_url":"https://api.github.com/users/chrismytton/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismytton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismytton/subscriptions","organizations_url":"https://api.github.com/users/chrismytton/orgs","repos_url":"https://api.github.com/users/chrismytton/repos","events_url":"https://api.github.com/users/chrismytton/events{/privacy}","received_events_url":"https://api.github.com/users/chrismytton/received_events","type":"User","site_admin":false},"body":"# What does this do?\r\n\r\nThis change adds a more robust check for a supported version of html-tidy.\r\n\r\n# Why was this needed?\r\n\r\n\r\nPreviously we were only checking that html-tidy was installed, however this meant that the user might have a very old version of html-tidy installed, which doesn't support HTML5. This new check now ensures that the user's version of html-tidy actually supports HTML5.\r\n\r\n# Relevant Issue(s)\r\n\r\nCloses https://github.com/everypolitician/viewer-sinatra/issues/15573\r\n\r\n# Implementation notes\r\n\r\nI've extracted the check for a supported version of html-tidy into it's own helper method to make it clearer what the check is actually doing.","created_at":"2016-09-26T15:16:21Z","updated_at":"2016-09-26T15:16:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/pulls/15575/commits","review_comments_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/pulls/15575/comments","review_comment_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/issues/15575/comments","statuses_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/statuses/8b3c6f5d576f755d184795445881e19110d1425c","head":{"label":"everypolitician:more-robust-html-tidy-check","ref":"more-robust-html-tidy-check","sha":"8b3c6f5d576f755d184795445881e19110d1425c","user":{"login":"everypolitician","id":12497298,"avatar_url":"https://avatars.githubusercontent.com/u/12497298?v=3","gravatar_id":"","url":"https://api.github.com/users/everypolitician","html_url":"https://github.com/everypolitician","followers_url":"https://api.github.com/users/everypolitician/followers","following_url":"https://api.github.com/users/everypolitician/following{/other_user}","gists_url":"https://api.github.com/users/everypolitician/gists{/gist_id}","starred_url":"https://api.github.com/users/everypolitician/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everypolitician/subscriptions","organizations_url":"https://api.github.com/users/everypolitician/orgs","repos_url":"https://api.github.com/users/everypolitician/repos","events_url":"https://api.github.com/users/everypolitician/events{/privacy}","received_events_url":"https://api.github.com/users/everypolitician/received_events","type":"Organization","site_admin":false},"repo":{"id":33254196,"name":"viewer-sinatra","full_name":"everypolitician/viewer-sinatra","owner":{"login":"everypolitician","id":12497298,"avatar_url":"https://avatars.githubusercontent.com/u/12497298?v=3","gravatar_id":"","url":"https://api.github.com/users/everypolitician","html_url":"https://github.com/everypolitician","followers_url":"https://api.github.com/users/everypolitician/followers","following_url":"https://api.github.com/users/everypolitician/following{/other_user}","gists_url":"https://api.github.com/users/everypolitician/gists{/gist_id}","starred_url":"https://api.github.com/users/everypolitician/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everypolitician/subscriptions","organizations_url":"https://api.github.com/users/everypolitician/orgs","repos_url":"https://api.github.com/users/everypolitician/repos","events_url":"https://api.github.com/users/everypolitician/events{/privacy}","received_events_url":"https://api.github.com/users/everypolitician/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/everypolitician/viewer-sinatra","description":"Sinatra app for (pre)viewing EveryPolitician website dynamically","fork":false,"url":"https://api.github.com/repos/everypolitician/viewer-sinatra","forks_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/forks","keys_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/teams","hooks_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/hooks","issue_events_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/issues/events{/number}","events_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/events","assignees_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/assignees{/user}","branches_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/branches{/branch}","tags_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/tags","blobs_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/git/refs{/sha}","trees_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/statuses/{sha}","languages_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/languages","stargazers_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/stargazers","contributors_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/contributors","subscribers_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/subscribers","subscription_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/subscription","commits_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/commits{/sha}","git_commits_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/git/commits{/sha}","comments_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/comments{/number}","issue_comment_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/issues/comments{/number}","contents_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/contents/{+path}","compare_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/merges","archive_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/downloads","issues_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/issues{/number}","pulls_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/pulls{/number}","milestones_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/milestones{/number}","notifications_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/labels{/name}","releases_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/releases{/id}","deployments_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/deployments","created_at":"2015-04-01T15:02:20Z","updated_at":"2016-09-02T15:20:19Z","pushed_at":"2016-09-26T15:16:21Z","git_url":"git://github.com/everypolitician/viewer-sinatra.git","ssh_url":"git@github.com:everypolitician/viewer-sinatra.git","clone_url":"https://github.com/everypolitician/viewer-sinatra.git","svn_url":"https://github.com/everypolitician/viewer-sinatra","homepage":"http://everypolitician.org/","size":22485,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":132,"forks":4,"open_issues":132,"watchers":3,"default_branch":"master"}},"base":{"label":"everypolitician:master","ref":"master","sha":"88da5d464279271d224cd166308305aa45d60d31","user":{"login":"everypolitician","id":12497298,"avatar_url":"https://avatars.githubusercontent.com/u/12497298?v=3","gravatar_id":"","url":"https://api.github.com/users/everypolitician","html_url":"https://github.com/everypolitician","followers_url":"https://api.github.com/users/everypolitician/followers","following_url":"https://api.github.com/users/everypolitician/following{/other_user}","gists_url":"https://api.github.com/users/everypolitician/gists{/gist_id}","starred_url":"https://api.github.com/users/everypolitician/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everypolitician/subscriptions","organizations_url":"https://api.github.com/users/everypolitician/orgs","repos_url":"https://api.github.com/users/everypolitician/repos","events_url":"https://api.github.com/users/everypolitician/events{/privacy}","received_events_url":"https://api.github.com/users/everypolitician/received_events","type":"Organization","site_admin":false},"repo":{"id":33254196,"name":"viewer-sinatra","full_name":"everypolitician/viewer-sinatra","owner":{"login":"everypolitician","id":12497298,"avatar_url":"https://avatars.githubusercontent.com/u/12497298?v=3","gravatar_id":"","url":"https://api.github.com/users/everypolitician","html_url":"https://github.com/everypolitician","followers_url":"https://api.github.com/users/everypolitician/followers","following_url":"https://api.github.com/users/everypolitician/following{/other_user}","gists_url":"https://api.github.com/users/everypolitician/gists{/gist_id}","starred_url":"https://api.github.com/users/everypolitician/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everypolitician/subscriptions","organizations_url":"https://api.github.com/users/everypolitician/orgs","repos_url":"https://api.github.com/users/everypolitician/repos","events_url":"https://api.github.com/users/everypolitician/events{/privacy}","received_events_url":"https://api.github.com/users/everypolitician/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/everypolitician/viewer-sinatra","description":"Sinatra app for (pre)viewing EveryPolitician website dynamically","fork":false,"url":"https://api.github.com/repos/everypolitician/viewer-sinatra","forks_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/forks","keys_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/teams","hooks_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/hooks","issue_events_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/issues/events{/number}","events_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/events","assignees_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/assignees{/user}","branches_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/branches{/branch}","tags_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/tags","blobs_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/git/refs{/sha}","trees_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/statuses/{sha}","languages_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/languages","stargazers_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/stargazers","contributors_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/contributors","subscribers_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/subscribers","subscription_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/subscription","commits_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/commits{/sha}","git_commits_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/git/commits{/sha}","comments_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/comments{/number}","issue_comment_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/issues/comments{/number}","contents_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/contents/{+path}","compare_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/merges","archive_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/downloads","issues_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/issues{/number}","pulls_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/pulls{/number}","milestones_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/milestones{/number}","notifications_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/labels{/name}","releases_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/releases{/id}","deployments_url":"https://api.github.com/repos/everypolitician/viewer-sinatra/deployments","created_at":"2015-04-01T15:02:20Z","updated_at":"2016-09-02T15:20:19Z","pushed_at":"2016-09-26T15:16:21Z","git_url":"git://github.com/everypolitician/viewer-sinatra.git","ssh_url":"git@github.com:everypolitician/viewer-sinatra.git","clone_url":"https://github.com/everypolitician/viewer-sinatra.git","svn_url":"https://github.com/everypolitician/viewer-sinatra","homepage":"http://everypolitician.org/","size":22485,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":132,"forks":4,"open_issues":132,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/everypolitician/viewer-sinatra/pulls/15575"},"html":{"href":"https://github.com/everypolitician/viewer-sinatra/pull/15575"},"issue":{"href":"https://api.github.com/repos/everypolitician/viewer-sinatra/issues/15575"},"comments":{"href":"https://api.github.com/repos/everypolitician/viewer-sinatra/issues/15575/comments"},"review_comments":{"href":"https://api.github.com/repos/everypolitician/viewer-sinatra/pulls/15575/comments"},"review_comment":{"href":"https://api.github.com/repos/everypolitician/viewer-sinatra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/everypolitician/viewer-sinatra/pulls/15575/commits"},"statuses":{"href":"https://api.github.com/repos/everypolitician/viewer-sinatra/statuses/8b3c6f5d576f755d184795445881e19110d1425c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"chrismytton"}}