{"action":"opened","number":274,"pull_request":{"url":"https://api.github.com/repos/dimagi/javarosa/pulls/274","id":62700657,"html_url":"https://github.com/dimagi/javarosa/pull/274","diff_url":"https://github.com/dimagi/javarosa/pull/274.diff","patch_url":"https://github.com/dimagi/javarosa/pull/274.patch","issue_url":"https://api.github.com/repos/dimagi/javarosa/issues/274","number":274,"state":"open","locked":false,"title":"Don't allow ActionController to be null: form loading might crash","user":{"login":"phillipm","id":94817,"avatar_url":"https://avatars.githubusercontent.com/u/94817?v=3","gravatar_id":"","url":"https://api.github.com/users/phillipm","html_url":"https://github.com/phillipm","followers_url":"https://api.github.com/users/phillipm/followers","following_url":"https://api.github.com/users/phillipm/following{/other_user}","gists_url":"https://api.github.com/users/phillipm/gists{/gist_id}","starred_url":"https://api.github.com/users/phillipm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillipm/subscriptions","organizations_url":"https://api.github.com/users/phillipm/orgs","repos_url":"https://api.github.com/users/phillipm/repos","events_url":"https://api.github.com/users/phillipm/events{/privacy}","received_events_url":"https://api.github.com/users/phillipm/received_events","type":"User","site_admin":false},"body":"I've been coming against residual NPE crashes where form loading fails because the `FormDef`'s `ActionController` doesn't fail hard when deserialization fails, but rather to deserializes to `null`.\r\n\r\nThis PR makes form deserialization fail when the `ActionController` can't be deserialized. This forces the form to be re-read from xml and re-serialized.\r\n\r\nTo reproduce, load a form using an intent on master, then build https://github.com/dimagi/commcare-odk/pull/1128 and load the same form. The change in how `IntentCallout` is serialized somehow causes the `FormDef` deserialization to not load the `ActionController` correctly.\r\n\r\nThis change makes it so that if we change the serialization scheme of `ActionController`, or I guess other things as seen in the reproduction steps above, then we won't cause user level crashes when CommCare is updated on their devices and the load a form that had previously been loaded on older version of CommCare.","created_at":"2016-03-14T05:00:18Z","updated_at":"2016-03-14T05:00:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c156fce7291d3a14e6fa1be3bcbcc6d20f0f9b6f","assignee":{"login":"amstone326","id":3723143,"avatar_url":"https://avatars.githubusercontent.com/u/3723143?v=3","gravatar_id":"","url":"https://api.github.com/users/amstone326","html_url":"https://github.com/amstone326","followers_url":"https://api.github.com/users/amstone326/followers","following_url":"https://api.github.com/users/amstone326/following{/other_user}","gists_url":"https://api.github.com/users/amstone326/gists{/gist_id}","starred_url":"https://api.github.com/users/amstone326/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amstone326/subscriptions","organizations_url":"https://api.github.com/users/amstone326/orgs","repos_url":"https://api.github.com/users/amstone326/repos","events_url":"https://api.github.com/users/amstone326/events{/privacy}","received_events_url":"https://api.github.com/users/amstone326/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/dimagi/javarosa/milestones/6","html_url":"https://github.com/dimagi/javarosa/milestones/commcare_2.27","labels_url":"https://api.github.com/repos/dimagi/javarosa/milestones/6/labels","id":1544103,"number":6,"title":"commcare_2.27","description":null,"creator":{"login":"phillipm","id":94817,"avatar_url":"https://avatars.githubusercontent.com/u/94817?v=3","gravatar_id":"","url":"https://api.github.com/users/phillipm","html_url":"https://github.com/phillipm","followers_url":"https://api.github.com/users/phillipm/followers","following_url":"https://api.github.com/users/phillipm/following{/other_user}","gists_url":"https://api.github.com/users/phillipm/gists{/gist_id}","starred_url":"https://api.github.com/users/phillipm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillipm/subscriptions","organizations_url":"https://api.github.com/users/phillipm/orgs","repos_url":"https://api.github.com/users/phillipm/repos","events_url":"https://api.github.com/users/phillipm/events{/privacy}","received_events_url":"https://api.github.com/users/phillipm/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":31,"state":"open","created_at":"2016-01-26T14:12:16Z","updated_at":"2016-03-14T05:00:19Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dimagi/javarosa/pulls/274/commits","review_comments_url":"https://api.github.com/repos/dimagi/javarosa/pulls/274/comments","review_comment_url":"https://api.github.com/repos/dimagi/javarosa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dimagi/javarosa/issues/274/comments","statuses_url":"https://api.github.com/repos/dimagi/javarosa/statuses/1fae12457db7b5d71abcd5093fd163ba51837adc","head":{"label":"dimagi:bug/force-reserialization-w-action-controler","ref":"bug/force-reserialization-w-action-controler","sha":"1fae12457db7b5d71abcd5093fd163ba51837adc","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":20938963,"name":"javarosa","full_name":"dimagi/javarosa","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/javarosa","description":"J2ME-compatible XForms engine used by CommCare ","fork":false,"url":"https://api.github.com/repos/dimagi/javarosa","forks_url":"https://api.github.com/repos/dimagi/javarosa/forks","keys_url":"https://api.github.com/repos/dimagi/javarosa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/javarosa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/javarosa/teams","hooks_url":"https://api.github.com/repos/dimagi/javarosa/hooks","issue_events_url":"https://api.github.com/repos/dimagi/javarosa/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/javarosa/events","assignees_url":"https://api.github.com/repos/dimagi/javarosa/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/javarosa/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/javarosa/tags","blobs_url":"https://api.github.com/repos/dimagi/javarosa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/javarosa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/javarosa/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/javarosa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/javarosa/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/javarosa/languages","stargazers_url":"https://api.github.com/repos/dimagi/javarosa/stargazers","contributors_url":"https://api.github.com/repos/dimagi/javarosa/contributors","subscribers_url":"https://api.github.com/repos/dimagi/javarosa/subscribers","subscription_url":"https://api.github.com/repos/dimagi/javarosa/subscription","commits_url":"https://api.github.com/repos/dimagi/javarosa/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/javarosa/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/javarosa/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/javarosa/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/javarosa/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/javarosa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/javarosa/merges","archive_url":"https://api.github.com/repos/dimagi/javarosa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/javarosa/downloads","issues_url":"https://api.github.com/repos/dimagi/javarosa/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/javarosa/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/javarosa/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/javarosa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/javarosa/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/javarosa/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/javarosa/deployments","created_at":"2014-06-17T20:46:39Z","updated_at":"2016-03-12T12:12:01Z","pushed_at":"2016-03-14T05:00:19Z","git_url":"git://github.com/dimagi/javarosa.git","ssh_url":"git@github.com:dimagi/javarosa.git","clone_url":"https://github.com/dimagi/javarosa.git","svn_url":"https://github.com/dimagi/javarosa","homepage":"","size":38785,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":5,"default_branch":"master"}},"base":{"label":"dimagi:master","ref":"master","sha":"5fa7ae3ee50ef31393c6d701c36e1cb502fe5fef","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":20938963,"name":"javarosa","full_name":"dimagi/javarosa","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars.githubusercontent.com/u/94514?v=3","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/javarosa","description":"J2ME-compatible XForms engine used by CommCare ","fork":false,"url":"https://api.github.com/repos/dimagi/javarosa","forks_url":"https://api.github.com/repos/dimagi/javarosa/forks","keys_url":"https://api.github.com/repos/dimagi/javarosa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/javarosa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/javarosa/teams","hooks_url":"https://api.github.com/repos/dimagi/javarosa/hooks","issue_events_url":"https://api.github.com/repos/dimagi/javarosa/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/javarosa/events","assignees_url":"https://api.github.com/repos/dimagi/javarosa/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/javarosa/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/javarosa/tags","blobs_url":"https://api.github.com/repos/dimagi/javarosa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/javarosa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/javarosa/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/javarosa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/javarosa/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/javarosa/languages","stargazers_url":"https://api.github.com/repos/dimagi/javarosa/stargazers","contributors_url":"https://api.github.com/repos/dimagi/javarosa/contributors","subscribers_url":"https://api.github.com/repos/dimagi/javarosa/subscribers","subscription_url":"https://api.github.com/repos/dimagi/javarosa/subscription","commits_url":"https://api.github.com/repos/dimagi/javarosa/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/javarosa/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/javarosa/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/javarosa/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/javarosa/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/javarosa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/javarosa/merges","archive_url":"https://api.github.com/repos/dimagi/javarosa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/javarosa/downloads","issues_url":"https://api.github.com/repos/dimagi/javarosa/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/javarosa/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/javarosa/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/javarosa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/javarosa/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/javarosa/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/javarosa/deployments","created_at":"2014-06-17T20:46:39Z","updated_at":"2016-03-12T12:12:01Z","pushed_at":"2016-03-14T05:00:19Z","git_url":"git://github.com/dimagi/javarosa.git","ssh_url":"git@github.com:dimagi/javarosa.git","clone_url":"https://github.com/dimagi/javarosa.git","svn_url":"https://github.com/dimagi/javarosa","homepage":"","size":38785,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dimagi/javarosa/pulls/274"},"html":{"href":"https://github.com/dimagi/javarosa/pull/274"},"issue":{"href":"https://api.github.com/repos/dimagi/javarosa/issues/274"},"comments":{"href":"https://api.github.com/repos/dimagi/javarosa/issues/274/comments"},"review_comments":{"href":"https://api.github.com/repos/dimagi/javarosa/pulls/274/comments"},"review_comment":{"href":"https://api.github.com/repos/dimagi/javarosa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dimagi/javarosa/pulls/274/commits"},"statuses":{"href":"https://api.github.com/repos/dimagi/javarosa/statuses/1fae12457db7b5d71abcd5093fd163ba51837adc"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}