{"action":"closed","number":198,"pull_request":{"url":"https://api.github.com/repos/ServUO/ServUO/pulls/198","id":54886183,"html_url":"https://github.com/ServUO/ServUO/pull/198","diff_url":"https://github.com/ServUO/ServUO/pull/198.diff","patch_url":"https://github.com/ServUO/ServUO/pull/198.patch","issue_url":"https://api.github.com/repos/ServUO/ServUO/issues/198","number":198,"state":"closed","locked":false,"title":"Fame titles on makers mark","user":{"login":"qbradq","id":581393,"avatar_url":"https://avatars.githubusercontent.com/u/581393?v=3","gravatar_id":"","url":"https://api.github.com/users/qbradq","html_url":"https://github.com/qbradq","followers_url":"https://api.github.com/users/qbradq/followers","following_url":"https://api.github.com/users/qbradq/following{/other_user}","gists_url":"https://api.github.com/users/qbradq/gists{/gist_id}","starred_url":"https://api.github.com/users/qbradq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qbradq/subscriptions","organizations_url":"https://api.github.com/users/qbradq/orgs","repos_url":"https://api.github.com/users/qbradq/repos","events_url":"https://api.github.com/users/qbradq/events{/privacy}","received_events_url":"https://api.github.com/users/qbradq/received_events","type":"User","site_admin":false},"body":"Fixes #194. Tested with hover menus and single-click. This required some deserialization trickery to get furniture to work right without copy-and-pasting code everywhere. Basically I made all the player-craftable furniture inherit from CraftableFurniture instead of directly from Item. Due to this there is now an extra deserialize() call in their desierialization chain. To compensate for this I had to add a PeekInt() method to the GenericReader interface and do some version numbering shekanery. But it will now load a save with legacy items just fine.\r\n\r\nThe only thing I could not figure out is Clippers in single-click mode. They still open a menu and do not seem to invoke OnSingleClick(). This item was never intended for pre-AoS era clients anyway, so I'm not sure it is a problem right now.","created_at":"2016-01-01T01:51:28Z","updated_at":"2016-01-01T06:37:22Z","closed_at":"2016-01-01T06:37:22Z","merged_at":"2016-01-01T06:37:22Z","merge_commit_sha":"0ca2cee72121f6845e98b745ee499be1837470f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ServUO/ServUO/pulls/198/commits","review_comments_url":"https://api.github.com/repos/ServUO/ServUO/pulls/198/comments","review_comment_url":"https://api.github.com/repos/ServUO/ServUO/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ServUO/ServUO/issues/198/comments","statuses_url":"https://api.github.com/repos/ServUO/ServUO/statuses/7c9d5ad20b0f4770cc399dc8a79acc6e1f715c9c","head":{"label":"qbradq:Fame-Titles-on-Makers-Mark","ref":"Fame-Titles-on-Makers-Mark","sha":"7c9d5ad20b0f4770cc399dc8a79acc6e1f715c9c","user":{"login":"qbradq","id":581393,"avatar_url":"https://avatars.githubusercontent.com/u/581393?v=3","gravatar_id":"","url":"https://api.github.com/users/qbradq","html_url":"https://github.com/qbradq","followers_url":"https://api.github.com/users/qbradq/followers","following_url":"https://api.github.com/users/qbradq/following{/other_user}","gists_url":"https://api.github.com/users/qbradq/gists{/gist_id}","starred_url":"https://api.github.com/users/qbradq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qbradq/subscriptions","organizations_url":"https://api.github.com/users/qbradq/orgs","repos_url":"https://api.github.com/users/qbradq/repos","events_url":"https://api.github.com/users/qbradq/events{/privacy}","received_events_url":"https://api.github.com/users/qbradq/received_events","type":"User","site_admin":false},"repo":{"id":48703992,"name":"ServUO","full_name":"qbradq/ServUO","owner":{"login":"qbradq","id":581393,"avatar_url":"https://avatars.githubusercontent.com/u/581393?v=3","gravatar_id":"","url":"https://api.github.com/users/qbradq","html_url":"https://github.com/qbradq","followers_url":"https://api.github.com/users/qbradq/followers","following_url":"https://api.github.com/users/qbradq/following{/other_user}","gists_url":"https://api.github.com/users/qbradq/gists{/gist_id}","starred_url":"https://api.github.com/users/qbradq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qbradq/subscriptions","organizations_url":"https://api.github.com/users/qbradq/orgs","repos_url":"https://api.github.com/users/qbradq/repos","events_url":"https://api.github.com/users/qbradq/events{/privacy}","received_events_url":"https://api.github.com/users/qbradq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qbradq/ServUO","description":"An Ultima Online server emulator written in c#","fork":true,"url":"https://api.github.com/repos/qbradq/ServUO","forks_url":"https://api.github.com/repos/qbradq/ServUO/forks","keys_url":"https://api.github.com/repos/qbradq/ServUO/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qbradq/ServUO/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qbradq/ServUO/teams","hooks_url":"https://api.github.com/repos/qbradq/ServUO/hooks","issue_events_url":"https://api.github.com/repos/qbradq/ServUO/issues/events{/number}","events_url":"https://api.github.com/repos/qbradq/ServUO/events","assignees_url":"https://api.github.com/repos/qbradq/ServUO/assignees{/user}","branches_url":"https://api.github.com/repos/qbradq/ServUO/branches{/branch}","tags_url":"https://api.github.com/repos/qbradq/ServUO/tags","blobs_url":"https://api.github.com/repos/qbradq/ServUO/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qbradq/ServUO/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qbradq/ServUO/git/refs{/sha}","trees_url":"https://api.github.com/repos/qbradq/ServUO/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qbradq/ServUO/statuses/{sha}","languages_url":"https://api.github.com/repos/qbradq/ServUO/languages","stargazers_url":"https://api.github.com/repos/qbradq/ServUO/stargazers","contributors_url":"https://api.github.com/repos/qbradq/ServUO/contributors","subscribers_url":"https://api.github.com/repos/qbradq/ServUO/subscribers","subscription_url":"https://api.github.com/repos/qbradq/ServUO/subscription","commits_url":"https://api.github.com/repos/qbradq/ServUO/commits{/sha}","git_commits_url":"https://api.github.com/repos/qbradq/ServUO/git/commits{/sha}","comments_url":"https://api.github.com/repos/qbradq/ServUO/comments{/number}","issue_comment_url":"https://api.github.com/repos/qbradq/ServUO/issues/comments{/number}","contents_url":"https://api.github.com/repos/qbradq/ServUO/contents/{+path}","compare_url":"https://api.github.com/repos/qbradq/ServUO/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qbradq/ServUO/merges","archive_url":"https://api.github.com/repos/qbradq/ServUO/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qbradq/ServUO/downloads","issues_url":"https://api.github.com/repos/qbradq/ServUO/issues{/number}","pulls_url":"https://api.github.com/repos/qbradq/ServUO/pulls{/number}","milestones_url":"https://api.github.com/repos/qbradq/ServUO/milestones{/number}","notifications_url":"https://api.github.com/repos/qbradq/ServUO/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qbradq/ServUO/labels{/name}","releases_url":"https://api.github.com/repos/qbradq/ServUO/releases{/id}","created_at":"2015-12-28T17:26:25Z","updated_at":"2015-12-28T17:26:36Z","pushed_at":"2016-01-01T04:06:26Z","git_url":"git://github.com/qbradq/ServUO.git","ssh_url":"git@github.com:qbradq/ServUO.git","clone_url":"https://github.com/qbradq/ServUO.git","svn_url":"https://github.com/qbradq/ServUO","homepage":"http://ServUO.com","size":10061,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ServUO:master","ref":"master","sha":"8583172bfe4f0eb948963af9ed091dc39c14bd5b","user":{"login":"ServUO","id":3516645,"avatar_url":"https://avatars.githubusercontent.com/u/3516645?v=3","gravatar_id":"","url":"https://api.github.com/users/ServUO","html_url":"https://github.com/ServUO","followers_url":"https://api.github.com/users/ServUO/followers","following_url":"https://api.github.com/users/ServUO/following{/other_user}","gists_url":"https://api.github.com/users/ServUO/gists{/gist_id}","starred_url":"https://api.github.com/users/ServUO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ServUO/subscriptions","organizations_url":"https://api.github.com/users/ServUO/orgs","repos_url":"https://api.github.com/users/ServUO/repos","events_url":"https://api.github.com/users/ServUO/events{/privacy}","received_events_url":"https://api.github.com/users/ServUO/received_events","type":"Organization","site_admin":false},"repo":{"id":13901613,"name":"ServUO","full_name":"ServUO/ServUO","owner":{"login":"ServUO","id":3516645,"avatar_url":"https://avatars.githubusercontent.com/u/3516645?v=3","gravatar_id":"","url":"https://api.github.com/users/ServUO","html_url":"https://github.com/ServUO","followers_url":"https://api.github.com/users/ServUO/followers","following_url":"https://api.github.com/users/ServUO/following{/other_user}","gists_url":"https://api.github.com/users/ServUO/gists{/gist_id}","starred_url":"https://api.github.com/users/ServUO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ServUO/subscriptions","organizations_url":"https://api.github.com/users/ServUO/orgs","repos_url":"https://api.github.com/users/ServUO/repos","events_url":"https://api.github.com/users/ServUO/events{/privacy}","received_events_url":"https://api.github.com/users/ServUO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ServUO/ServUO","description":"An Ultima Online server emulator written in c#","fork":false,"url":"https://api.github.com/repos/ServUO/ServUO","forks_url":"https://api.github.com/repos/ServUO/ServUO/forks","keys_url":"https://api.github.com/repos/ServUO/ServUO/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ServUO/ServUO/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ServUO/ServUO/teams","hooks_url":"https://api.github.com/repos/ServUO/ServUO/hooks","issue_events_url":"https://api.github.com/repos/ServUO/ServUO/issues/events{/number}","events_url":"https://api.github.com/repos/ServUO/ServUO/events","assignees_url":"https://api.github.com/repos/ServUO/ServUO/assignees{/user}","branches_url":"https://api.github.com/repos/ServUO/ServUO/branches{/branch}","tags_url":"https://api.github.com/repos/ServUO/ServUO/tags","blobs_url":"https://api.github.com/repos/ServUO/ServUO/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ServUO/ServUO/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ServUO/ServUO/git/refs{/sha}","trees_url":"https://api.github.com/repos/ServUO/ServUO/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ServUO/ServUO/statuses/{sha}","languages_url":"https://api.github.com/repos/ServUO/ServUO/languages","stargazers_url":"https://api.github.com/repos/ServUO/ServUO/stargazers","contributors_url":"https://api.github.com/repos/ServUO/ServUO/contributors","subscribers_url":"https://api.github.com/repos/ServUO/ServUO/subscribers","subscription_url":"https://api.github.com/repos/ServUO/ServUO/subscription","commits_url":"https://api.github.com/repos/ServUO/ServUO/commits{/sha}","git_commits_url":"https://api.github.com/repos/ServUO/ServUO/git/commits{/sha}","comments_url":"https://api.github.com/repos/ServUO/ServUO/comments{/number}","issue_comment_url":"https://api.github.com/repos/ServUO/ServUO/issues/comments{/number}","contents_url":"https://api.github.com/repos/ServUO/ServUO/contents/{+path}","compare_url":"https://api.github.com/repos/ServUO/ServUO/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ServUO/ServUO/merges","archive_url":"https://api.github.com/repos/ServUO/ServUO/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ServUO/ServUO/downloads","issues_url":"https://api.github.com/repos/ServUO/ServUO/issues{/number}","pulls_url":"https://api.github.com/repos/ServUO/ServUO/pulls{/number}","milestones_url":"https://api.github.com/repos/ServUO/ServUO/milestones{/number}","notifications_url":"https://api.github.com/repos/ServUO/ServUO/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ServUO/ServUO/labels{/name}","releases_url":"https://api.github.com/repos/ServUO/ServUO/releases{/id}","created_at":"2013-10-27T13:32:32Z","updated_at":"2015-12-31T21:07:10Z","pushed_at":"2016-01-01T06:37:22Z","git_url":"git://github.com/ServUO/ServUO.git","ssh_url":"git@github.com:ServUO/ServUO.git","clone_url":"https://github.com/ServUO/ServUO.git","svn_url":"https://github.com/ServUO/ServUO","homepage":"http://ServUO.com","size":10419,"stargazers_count":38,"watchers_count":38,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":22,"forks":56,"open_issues":22,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ServUO/ServUO/pulls/198"},"html":{"href":"https://github.com/ServUO/ServUO/pull/198"},"issue":{"href":"https://api.github.com/repos/ServUO/ServUO/issues/198"},"comments":{"href":"https://api.github.com/repos/ServUO/ServUO/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/ServUO/ServUO/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/ServUO/ServUO/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ServUO/ServUO/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/ServUO/ServUO/statuses/7c9d5ad20b0f4770cc399dc8a79acc6e1f715c9c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dmurphy22","id":6827863,"avatar_url":"https://avatars.githubusercontent.com/u/6827863?v=3","gravatar_id":"","url":"https://api.github.com/users/dmurphy22","html_url":"https://github.com/dmurphy22","followers_url":"https://api.github.com/users/dmurphy22/followers","following_url":"https://api.github.com/users/dmurphy22/following{/other_user}","gists_url":"https://api.github.com/users/dmurphy22/gists{/gist_id}","starred_url":"https://api.github.com/users/dmurphy22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmurphy22/subscriptions","organizations_url":"https://api.github.com/users/dmurphy22/orgs","repos_url":"https://api.github.com/users/dmurphy22/repos","events_url":"https://api.github.com/users/dmurphy22/events{/privacy}","received_events_url":"https://api.github.com/users/dmurphy22/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":7,"additions":201,"deletions":79,"changed_files":26}}