{"action":"created","issue":{"url":"https://api.github.com/repos/karalabe/hive/issues/20","repository_url":"https://api.github.com/repos/karalabe/hive","labels_url":"https://api.github.com/repos/karalabe/hive/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/karalabe/hive/issues/20/comments","events_url":"https://api.github.com/repos/karalabe/hive/issues/20/events","html_url":"https://github.com/karalabe/hive/pull/20","id":185066153,"number":20,"title":"Refactored the Dockerfiles","user":{"login":"holiman","id":142290,"avatar_url":"https://avatars.githubusercontent.com/u/142290?v=3","gravatar_id":"","url":"https://api.github.com/users/holiman","html_url":"https://github.com/holiman","followers_url":"https://api.github.com/users/holiman/followers","following_url":"https://api.github.com/users/holiman/following{/other_user}","gists_url":"https://api.github.com/users/holiman/gists{/gist_id}","starred_url":"https://api.github.com/users/holiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holiman/subscriptions","organizations_url":"https://api.github.com/users/holiman/orgs","repos_url":"https://api.github.com/users/holiman/repos","events_url":"https://api.github.com/users/holiman/events{/privacy}","received_events_url":"https://api.github.com/users/holiman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-25T09:36:15Z","updated_at":"2016-10-25T09:53:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/karalabe/hive/pulls/20","html_url":"https://github.com/karalabe/hive/pull/20","diff_url":"https://github.com/karalabe/hive/pull/20.diff","patch_url":"https://github.com/karalabe/hive/pull/20.patch"},"body":"This PR organises the Dockerfiles so that the docker cache is better reused between clients. Basically: \r\n\r\n* Fetch all general utilities and update package repositories \r\n* Check out the relevant github repo\r\n* For parity: `cargo fetch` to download most of the dependencies\r\n\r\nThe steps above are cached by docker after the first client has been built. Afterwards, the remaining non-cached steps are\r\n\r\n* Check out correct branch\r\n* Build\r\n\r\nThis shaves a lot of times off the build times for the docker images\r\nSee https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/#/build-cache"},"comment":{"url":"https://api.github.com/repos/karalabe/hive/issues/comments/255990426","html_url":"https://github.com/karalabe/hive/pull/20#issuecomment-255990426","issue_url":"https://api.github.com/repos/karalabe/hive/issues/20","id":255990426,"user":{"login":"holiman","id":142290,"avatar_url":"https://avatars.githubusercontent.com/u/142290?v=3","gravatar_id":"","url":"https://api.github.com/users/holiman","html_url":"https://github.com/holiman","followers_url":"https://api.github.com/users/holiman/followers","following_url":"https://api.github.com/users/holiman/following{/other_user}","gists_url":"https://api.github.com/users/holiman/gists{/gist_id}","starred_url":"https://api.github.com/users/holiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holiman/subscriptions","organizations_url":"https://api.github.com/users/holiman/orgs","repos_url":"https://api.github.com/users/holiman/repos","events_url":"https://api.github.com/users/holiman/events{/privacy}","received_events_url":"https://api.github.com/users/holiman/received_events","type":"User","site_admin":false},"created_at":"2016-10-25T09:53:56Z","updated_at":"2016-10-25T09:53:56Z","body":"Ah, that's a valid concern. Personally, or maybe for my use-case while testing locally, I'd rather have larger images and shorter build-times. And I'm aware about the `--depth 1`, I removed it to enable a shared base image. Primarily for parity, to be able to download dependencies. "}}
{"actor":{"display_login":"holiman"}}