{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/72609496","id":72609496,"diff_hunk":"@@ -241,25 +245,38 @@ def build_metric_id(type, resource, metric_id)\n     # by ems_ref, which in Hawkular terms is the\n     # fully qualified resource path from Hawkular inventory\n     def run_generic_operation(operation, ems_ref, parameters = {})\n-      with_provider_connection do |connection|\n         the_operation = {\n           :operationName => operation,\n           :resourcePath  => ems_ref.to_s,\n           :parameters    => parameters\n         }\n+        run_operation(the_operation)\n+    end\n \n+    def run_specific_operation(operation_name, ems_ref, parameters = {})\n+      parameters[:resourcePath] = ems_ref.to_s\n+      run_operation(parameters, operation_name)\n+    end\n+\n+    def run_operation(parameters, operation_name = nil)\n+      with_provider_connection do |connection|\n         actual_data = {}\n-        connection.operations(true).invoke_generic_operation(the_operation) do |on|\n+        callback = proc do |on|\n           on.success do |data|\n             _log.debug \"Success on websocket-operation #{data}\"\n             actual_data[:data] = data\n           end\n           on.failure do |error|\n-            actual_data[:data]  = {}\n             actual_data[:error] = error\n             _log.error 'error callback was called, reason: ' + error.to_s","path":"app/models/manageiq/providers/hawkular/middleware_manager.rb","position":41,"original_position":41,"commit_id":"5b26f97900590a9b8b679607d61bb6c7bedf2993","original_commit_id":"5b26f97900590a9b8b679607d61bb6c7bedf2993","user":{"login":"abonas","id":6277245,"avatar_url":"https://avatars.githubusercontent.com/u/6277245?v=3","gravatar_id":"","url":"https://api.github.com/users/abonas","html_url":"https://github.com/abonas","followers_url":"https://api.github.com/users/abonas/followers","following_url":"https://api.github.com/users/abonas/following{/other_user}","gists_url":"https://api.github.com/users/abonas/gists{/gist_id}","starred_url":"https://api.github.com/users/abonas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abonas/subscriptions","organizations_url":"https://api.github.com/users/abonas/orgs","repos_url":"https://api.github.com/users/abonas/repos","events_url":"https://api.github.com/users/abonas/events{/privacy}","received_events_url":"https://api.github.com/users/abonas/received_events","type":"User","site_admin":false},"body":"will the user be able to understand what exact operation failed from this log message?","created_at":"2016-07-28T12:06:16Z","updated_at":"2016-07-28T12:06:16Z","html_url":"https://github.com/ManageIQ/manageiq/pull/9994#discussion_r72609496","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9994","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/72609496"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/9994#discussion_r72609496"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9994"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9994","id":78396663,"html_url":"https://github.com/ManageIQ/manageiq/pull/9994","diff_url":"https://github.com/ManageIQ/manageiq/pull/9994.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/9994.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9994","number":9994,"state":"open","locked":false,"title":"Delete a datasource definition in an EAP 7 standalone server","user":{"login":"rubenvp8510","id":3799716,"avatar_url":"https://avatars.githubusercontent.com/u/3799716?v=3","gravatar_id":"","url":"https://api.github.com/users/rubenvp8510","html_url":"https://github.com/rubenvp8510","followers_url":"https://api.github.com/users/rubenvp8510/followers","following_url":"https://api.github.com/users/rubenvp8510/following{/other_user}","gists_url":"https://api.github.com/users/rubenvp8510/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenvp8510/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenvp8510/subscriptions","organizations_url":"https://api.github.com/users/rubenvp8510/orgs","repos_url":"https://api.github.com/users/rubenvp8510/repos","events_url":"https://api.github.com/users/rubenvp8510/events{/privacy}","received_events_url":"https://api.github.com/users/rubenvp8510/received_events","type":"User","site_admin":false},"body":"\r\n![remove-1](https://cloud.githubusercontent.com/assets/3799716/17040601/3586d35a-4f66-11e6-8b80-edc033a67b58.png)\r\n\r\n![remove-2](https://cloud.githubusercontent.com/assets/3799716/17040603/39b1cf98-4f66-11e6-86be-113475dc9afb.png)\r\n\r\nAdds Remove operation to Datasources.\r\n\r\n\r\n\r\n@miq-bot add_label providers/hawkular\r\n@miq-bot add_label wip","created_at":"2016-07-21T22:14:20Z","updated_at":"2016-07-28T12:06:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2542c04d4577e663467deabf90bd06c5d92dbac9","assignee":{"login":"abonas","id":6277245,"avatar_url":"https://avatars.githubusercontent.com/u/6277245?v=3","gravatar_id":"","url":"https://api.github.com/users/abonas","html_url":"https://github.com/abonas","followers_url":"https://api.github.com/users/abonas/followers","following_url":"https://api.github.com/users/abonas/following{/other_user}","gists_url":"https://api.github.com/users/abonas/gists{/gist_id}","starred_url":"https://api.github.com/users/abonas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abonas/subscriptions","organizations_url":"https://api.github.com/users/abonas/orgs","repos_url":"https://api.github.com/users/abonas/repos","events_url":"https://api.github.com/users/abonas/events{/privacy}","received_events_url":"https://api.github.com/users/abonas/received_events","type":"User","site_admin":false},"assignees":[{"login":"abonas","id":6277245,"avatar_url":"https://avatars.githubusercontent.com/u/6277245?v=3","gravatar_id":"","url":"https://api.github.com/users/abonas","html_url":"https://github.com/abonas","followers_url":"https://api.github.com/users/abonas/followers","following_url":"https://api.github.com/users/abonas/following{/other_user}","gists_url":"https://api.github.com/users/abonas/gists{/gist_id}","starred_url":"https://api.github.com/users/abonas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abonas/subscriptions","organizations_url":"https://api.github.com/users/abonas/orgs","repos_url":"https://api.github.com/users/abonas/repos","events_url":"https://api.github.com/users/abonas/events{/privacy}","received_events_url":"https://api.github.com/users/abonas/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9994/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9994/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9994/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/5b26f97900590a9b8b679607d61bb6c7bedf2993","head":{"label":"rubenvp8510:OPR-036A","ref":"OPR-036A","sha":"5b26f97900590a9b8b679607d61bb6c7bedf2993","user":{"login":"rubenvp8510","id":3799716,"avatar_url":"https://avatars.githubusercontent.com/u/3799716?v=3","gravatar_id":"","url":"https://api.github.com/users/rubenvp8510","html_url":"https://github.com/rubenvp8510","followers_url":"https://api.github.com/users/rubenvp8510/followers","following_url":"https://api.github.com/users/rubenvp8510/following{/other_user}","gists_url":"https://api.github.com/users/rubenvp8510/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenvp8510/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenvp8510/subscriptions","organizations_url":"https://api.github.com/users/rubenvp8510/orgs","repos_url":"https://api.github.com/users/rubenvp8510/repos","events_url":"https://api.github.com/users/rubenvp8510/events{/privacy}","received_events_url":"https://api.github.com/users/rubenvp8510/received_events","type":"User","site_admin":false},"repo":{"id":62083794,"name":"manageiq","full_name":"rubenvp8510/manageiq","owner":{"login":"rubenvp8510","id":3799716,"avatar_url":"https://avatars.githubusercontent.com/u/3799716?v=3","gravatar_id":"","url":"https://api.github.com/users/rubenvp8510","html_url":"https://github.com/rubenvp8510","followers_url":"https://api.github.com/users/rubenvp8510/followers","following_url":"https://api.github.com/users/rubenvp8510/following{/other_user}","gists_url":"https://api.github.com/users/rubenvp8510/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenvp8510/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenvp8510/subscriptions","organizations_url":"https://api.github.com/users/rubenvp8510/orgs","repos_url":"https://api.github.com/users/rubenvp8510/repos","events_url":"https://api.github.com/users/rubenvp8510/events{/privacy}","received_events_url":"https://api.github.com/users/rubenvp8510/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rubenvp8510/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/rubenvp8510/manageiq","forks_url":"https://api.github.com/repos/rubenvp8510/manageiq/forks","keys_url":"https://api.github.com/repos/rubenvp8510/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubenvp8510/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubenvp8510/manageiq/teams","hooks_url":"https://api.github.com/repos/rubenvp8510/manageiq/hooks","issue_events_url":"https://api.github.com/repos/rubenvp8510/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/rubenvp8510/manageiq/events","assignees_url":"https://api.github.com/repos/rubenvp8510/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/rubenvp8510/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/rubenvp8510/manageiq/tags","blobs_url":"https://api.github.com/repos/rubenvp8510/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubenvp8510/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubenvp8510/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubenvp8510/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubenvp8510/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/rubenvp8510/manageiq/languages","stargazers_url":"https://api.github.com/repos/rubenvp8510/manageiq/stargazers","contributors_url":"https://api.github.com/repos/rubenvp8510/manageiq/contributors","subscribers_url":"https://api.github.com/repos/rubenvp8510/manageiq/subscribers","subscription_url":"https://api.github.com/repos/rubenvp8510/manageiq/subscription","commits_url":"https://api.github.com/repos/rubenvp8510/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubenvp8510/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubenvp8510/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubenvp8510/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubenvp8510/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/rubenvp8510/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubenvp8510/manageiq/merges","archive_url":"https://api.github.com/repos/rubenvp8510/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubenvp8510/manageiq/downloads","issues_url":"https://api.github.com/repos/rubenvp8510/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/rubenvp8510/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/rubenvp8510/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/rubenvp8510/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubenvp8510/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/rubenvp8510/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/rubenvp8510/manageiq/deployments","created_at":"2016-06-27T19:54:51Z","updated_at":"2016-06-27T19:55:12Z","pushed_at":"2016-07-28T00:34:30Z","git_url":"git://github.com/rubenvp8510/manageiq.git","ssh_url":"git@github.com:rubenvp8510/manageiq.git","clone_url":"https://github.com/rubenvp8510/manageiq.git","svn_url":"https://github.com/rubenvp8510/manageiq","homepage":"manageiq.org","size":140408,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"74acdde4ee7c3583de737cb8778a9da9942dedb5","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-07-13T16:26:10Z","pushed_at":"2016-07-28T12:03:14Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":183692,"stargazers_count":299,"watchers_count":299,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":330,"mirror_url":null,"open_issues_count":762,"forks":330,"open_issues":762,"watchers":299,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9994"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/9994"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/9994"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/9994/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9994/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9994/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/5b26f97900590a9b8b679607d61bb6c7bedf2993"}}}}
{"actor":{"display_login":"abonas"}}