{"action":"created","comment":{"url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments/84183709","pull_request_review_id":4976916,"id":84183709,"diff_hunk":"@@ -42,8 +42,16 @@ const AppMain = props => {\n   } = props;\n \n   if (statusCode !== 200) {\n+    // NOTE: this has manually renders TopNav, see below for an explanation","path":"src/app/pages/AppMain.jsx","position":4,"original_position":4,"commit_id":"d0609990e964bd0e64a9090cd7a720c21a155072","original_commit_id":"d0609990e964bd0e64a9090cd7a720c21a155072","user":{"login":"uzi","id":25475,"avatar_url":"https://avatars.githubusercontent.com/u/25475?v=3","gravatar_id":"","url":"https://api.github.com/users/uzi","html_url":"https://github.com/uzi","followers_url":"https://api.github.com/users/uzi/followers","following_url":"https://api.github.com/users/uzi/following{/other_user}","gists_url":"https://api.github.com/users/uzi/gists{/gist_id}","starred_url":"https://api.github.com/users/uzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uzi/subscriptions","organizations_url":"https://api.github.com/users/uzi/orgs","repos_url":"https://api.github.com/users/uzi/repos","events_url":"https://api.github.com/users/uzi/events{/privacy}","received_events_url":"https://api.github.com/users/uzi/received_events","type":"User","site_admin":false},"body":"\"this has\"","created_at":"2016-10-19T22:45:53Z","updated_at":"2016-10-19T22:45:54Z","html_url":"https://github.com/reddit/reddit-mobile/pull/838#discussion_r84183709","pull_request_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/838","_links":{"self":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments/84183709"},"html":{"href":"https://github.com/reddit/reddit-mobile/pull/838#discussion_r84183709"},"pull_request":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/838"}}},"pull_request":{"url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/838","id":90104471,"html_url":"https://github.com/reddit/reddit-mobile/pull/838","diff_url":"https://github.com/reddit/reddit-mobile/pull/838.diff","patch_url":"https://github.com/reddit/reddit-mobile/pull/838.patch","issue_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/838","number":838,"state":"open","locked":false,"title":"2 x fixups","user":{"login":"schwers","id":307983,"avatar_url":"https://avatars.githubusercontent.com/u/307983?v=3","gravatar_id":"","url":"https://api.github.com/users/schwers","html_url":"https://github.com/schwers","followers_url":"https://api.github.com/users/schwers/followers","following_url":"https://api.github.com/users/schwers/following{/other_user}","gists_url":"https://api.github.com/users/schwers/gists{/gist_id}","starred_url":"https://api.github.com/users/schwers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwers/subscriptions","organizations_url":"https://api.github.com/users/schwers/orgs","repos_url":"https://api.github.com/users/schwers/repos","events_url":"https://api.github.com/users/schwers/events{/privacy}","received_events_url":"https://api.github.com/users/schwers/received_events","type":"User","site_admin":false},"body":"Just some quick fixups:\r\n\r\n1) GTM is proxies its event tracking through an iframe via `postMessage`, seeing some errors in the logs where `gtmIFrame.contentWindow` is undefined. I think this is either because the frame times out or the browser isn't letting us access the iframe. The latter might require more work so this is intended to be a stopgap for now so the logs are cleaner\r\n\r\n2) The AppMain refactor made ErrorPages _not_ have a TopNav, second commit adds it back in.\r\n\r\n👓  @uzi @phil303 ","created_at":"2016-10-19T22:43:16Z","updated_at":"2016-10-19T22:45:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ada9c3f8f322c34a2d38d69506fc20a1e655b6f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/838/commits","review_comments_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/838/comments","review_comment_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/838/comments","statuses_url":"https://api.github.com/repos/reddit/reddit-mobile/statuses/d0609990e964bd0e64a9090cd7a720c21a155072","head":{"label":"schwers:2X-Fixups","ref":"2X-Fixups","sha":"d0609990e964bd0e64a9090cd7a720c21a155072","user":{"login":"schwers","id":307983,"avatar_url":"https://avatars.githubusercontent.com/u/307983?v=3","gravatar_id":"","url":"https://api.github.com/users/schwers","html_url":"https://github.com/schwers","followers_url":"https://api.github.com/users/schwers/followers","following_url":"https://api.github.com/users/schwers/following{/other_user}","gists_url":"https://api.github.com/users/schwers/gists{/gist_id}","starred_url":"https://api.github.com/users/schwers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwers/subscriptions","organizations_url":"https://api.github.com/users/schwers/orgs","repos_url":"https://api.github.com/users/schwers/repos","events_url":"https://api.github.com/users/schwers/events{/privacy}","received_events_url":"https://api.github.com/users/schwers/received_events","type":"User","site_admin":false},"repo":{"id":46595984,"name":"reddit-mobile","full_name":"schwers/reddit-mobile","owner":{"login":"schwers","id":307983,"avatar_url":"https://avatars.githubusercontent.com/u/307983?v=3","gravatar_id":"","url":"https://api.github.com/users/schwers","html_url":"https://github.com/schwers","followers_url":"https://api.github.com/users/schwers/followers","following_url":"https://api.github.com/users/schwers/following{/other_user}","gists_url":"https://api.github.com/users/schwers/gists{/gist_id}","starred_url":"https://api.github.com/users/schwers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schwers/subscriptions","organizations_url":"https://api.github.com/users/schwers/orgs","repos_url":"https://api.github.com/users/schwers/repos","events_url":"https://api.github.com/users/schwers/events{/privacy}","received_events_url":"https://api.github.com/users/schwers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schwers/reddit-mobile","description":null,"fork":true,"url":"https://api.github.com/repos/schwers/reddit-mobile","forks_url":"https://api.github.com/repos/schwers/reddit-mobile/forks","keys_url":"https://api.github.com/repos/schwers/reddit-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schwers/reddit-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schwers/reddit-mobile/teams","hooks_url":"https://api.github.com/repos/schwers/reddit-mobile/hooks","issue_events_url":"https://api.github.com/repos/schwers/reddit-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/schwers/reddit-mobile/events","assignees_url":"https://api.github.com/repos/schwers/reddit-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/schwers/reddit-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/schwers/reddit-mobile/tags","blobs_url":"https://api.github.com/repos/schwers/reddit-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schwers/reddit-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schwers/reddit-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/schwers/reddit-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schwers/reddit-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/schwers/reddit-mobile/languages","stargazers_url":"https://api.github.com/repos/schwers/reddit-mobile/stargazers","contributors_url":"https://api.github.com/repos/schwers/reddit-mobile/contributors","subscribers_url":"https://api.github.com/repos/schwers/reddit-mobile/subscribers","subscription_url":"https://api.github.com/repos/schwers/reddit-mobile/subscription","commits_url":"https://api.github.com/repos/schwers/reddit-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/schwers/reddit-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/schwers/reddit-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/schwers/reddit-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/schwers/reddit-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/schwers/reddit-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schwers/reddit-mobile/merges","archive_url":"https://api.github.com/repos/schwers/reddit-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schwers/reddit-mobile/downloads","issues_url":"https://api.github.com/repos/schwers/reddit-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/schwers/reddit-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/schwers/reddit-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/schwers/reddit-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schwers/reddit-mobile/labels{/name}","releases_url":"https://api.github.com/repos/schwers/reddit-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/schwers/reddit-mobile/deployments","created_at":"2015-11-21T01:25:16Z","updated_at":"2016-01-11T22:32:21Z","pushed_at":"2016-10-19T22:29:31Z","git_url":"git://github.com/schwers/reddit-mobile.git","ssh_url":"git@github.com:schwers/reddit-mobile.git","clone_url":"https://github.com/schwers/reddit-mobile.git","svn_url":"https://github.com/schwers/reddit-mobile","homepage":null,"size":7327,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reddit:2X","ref":"2X","sha":"8757fc33233fb897a1084ee0ea3310945594c6d8","user":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"repo":{"id":23087554,"name":"reddit-mobile","full_name":"reddit/reddit-mobile","owner":{"login":"reddit","id":14248,"avatar_url":"https://avatars.githubusercontent.com/u/14248?v=3","gravatar_id":"","url":"https://api.github.com/users/reddit","html_url":"https://github.com/reddit","followers_url":"https://api.github.com/users/reddit/followers","following_url":"https://api.github.com/users/reddit/following{/other_user}","gists_url":"https://api.github.com/users/reddit/gists{/gist_id}","starred_url":"https://api.github.com/users/reddit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddit/subscriptions","organizations_url":"https://api.github.com/users/reddit/orgs","repos_url":"https://api.github.com/users/reddit/repos","events_url":"https://api.github.com/users/reddit/events{/privacy}","received_events_url":"https://api.github.com/users/reddit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reddit/reddit-mobile","description":null,"fork":false,"url":"https://api.github.com/repos/reddit/reddit-mobile","forks_url":"https://api.github.com/repos/reddit/reddit-mobile/forks","keys_url":"https://api.github.com/repos/reddit/reddit-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reddit/reddit-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reddit/reddit-mobile/teams","hooks_url":"https://api.github.com/repos/reddit/reddit-mobile/hooks","issue_events_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/reddit/reddit-mobile/events","assignees_url":"https://api.github.com/repos/reddit/reddit-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/reddit/reddit-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/reddit/reddit-mobile/tags","blobs_url":"https://api.github.com/repos/reddit/reddit-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reddit/reddit-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reddit/reddit-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/reddit/reddit-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reddit/reddit-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/reddit/reddit-mobile/languages","stargazers_url":"https://api.github.com/repos/reddit/reddit-mobile/stargazers","contributors_url":"https://api.github.com/repos/reddit/reddit-mobile/contributors","subscribers_url":"https://api.github.com/repos/reddit/reddit-mobile/subscribers","subscription_url":"https://api.github.com/repos/reddit/reddit-mobile/subscription","commits_url":"https://api.github.com/repos/reddit/reddit-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/reddit/reddit-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/reddit/reddit-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/reddit/reddit-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/reddit/reddit-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/reddit/reddit-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reddit/reddit-mobile/merges","archive_url":"https://api.github.com/repos/reddit/reddit-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reddit/reddit-mobile/downloads","issues_url":"https://api.github.com/repos/reddit/reddit-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/reddit/reddit-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/reddit/reddit-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/reddit/reddit-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reddit/reddit-mobile/labels{/name}","releases_url":"https://api.github.com/repos/reddit/reddit-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/reddit/reddit-mobile/deployments","created_at":"2014-08-18T21:42:05Z","updated_at":"2016-10-15T22:28:54Z","pushed_at":"2016-10-19T22:44:14Z","git_url":"git://github.com/reddit/reddit-mobile.git","ssh_url":"git@github.com:reddit/reddit-mobile.git","clone_url":"https://github.com/reddit/reddit-mobile.git","svn_url":"https://github.com/reddit/reddit-mobile","homepage":null,"size":10743,"stargazers_count":859,"watchers_count":859,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":148,"mirror_url":null,"open_issues_count":25,"forks":148,"open_issues":25,"watchers":859,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/838"},"html":{"href":"https://github.com/reddit/reddit-mobile/pull/838"},"issue":{"href":"https://api.github.com/repos/reddit/reddit-mobile/issues/838"},"comments":{"href":"https://api.github.com/repos/reddit/reddit-mobile/issues/838/comments"},"review_comments":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/838/comments"},"review_comment":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reddit/reddit-mobile/pulls/838/commits"},"statuses":{"href":"https://api.github.com/repos/reddit/reddit-mobile/statuses/d0609990e964bd0e64a9090cd7a720c21a155072"}}}}
{"actor":{"display_login":"uzi"}}