{"action":"created","issue":{"url":"https://api.github.com/repos/driftyco/ionic/issues/9012","repository_url":"https://api.github.com/repos/driftyco/ionic","labels_url":"https://api.github.com/repos/driftyco/ionic/issues/9012/labels{/name}","comments_url":"https://api.github.com/repos/driftyco/ionic/issues/9012/comments","events_url":"https://api.github.com/repos/driftyco/ionic/issues/9012/events","html_url":"https://github.com/driftyco/ionic/issues/9012","id":187123582,"number":9012,"title":"DeepLinker generated URL names with tabbed pages causes double /","user":{"login":"morrisonbrett","id":1159718,"avatar_url":"https://avatars.githubusercontent.com/u/1159718?v=3","gravatar_id":"","url":"https://api.github.com/users/morrisonbrett","html_url":"https://github.com/morrisonbrett","followers_url":"https://api.github.com/users/morrisonbrett/followers","following_url":"https://api.github.com/users/morrisonbrett/following{/other_user}","gists_url":"https://api.github.com/users/morrisonbrett/gists{/gist_id}","starred_url":"https://api.github.com/users/morrisonbrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morrisonbrett/subscriptions","organizations_url":"https://api.github.com/users/morrisonbrett/orgs","repos_url":"https://api.github.com/users/morrisonbrett/repos","events_url":"https://api.github.com/users/morrisonbrett/events{/privacy}","received_events_url":"https://api.github.com/users/morrisonbrett/received_events","type":"User","site_admin":false},"labels":[{"id":311009737,"url":"https://api.github.com/repos/driftyco/ionic/labels/v2","name":"v2","color":"313744","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-03T16:38:42Z","updated_at":"2016-11-07T17:55:59Z","closed_at":null,"body":"Starting to use DeepLinker.  Ran into this issue.  Details simplified for brevity's sake:\r\n\r\nI have a tab called 'users'.  Here it is:\r\n\r\n```\r\n<ion-tabs class=\"tabs\" [selectedIndex]=\"selectedTabIndex\" tabsHighlight=\"true\" tabsPlacement=\"top\">\r\n  <ion-tab [root]=\"UsersPageRoot\" (ionSelect)=\"selectTab(0, UsersPageRoot)\" tabUrlPath=\"\" tabIcon=\"desktop\"></ion-tab>\r\n</ion-tabs>\r\n\r\n```\r\nI want the URL via DeepLinker to be `localhost:8100/#/users`\r\n\r\nHowever, the DeepLinker will take that, inspect the `tabUrlPath` value, and add an extra `/`\r\n\r\nThe URL will be: `localhost:8100/#//users`\r\n\r\nI can put a word in the tabUrlPath - let's try the word 'account'.\r\n\r\n```\r\n<ion-tabs class=\"tabs\" [selectedIndex]=\"selectedTabIndex\" tabsHighlight=\"true\" tabsPlacement=\"top\">\r\n  <ion-tab [root]=\"UsersPageRoot\" (ionSelect)=\"selectTab(0, UsersPageRoot)\" tabUrlPath=\"account\" tabIcon=\"desktop\"></ion-tab>\r\n</ion-tabs>\r\n\r\n```\r\n\r\nThe URL will be: `localhost:8100/#/account/users`\r\n\r\nSo the problem is, if I put an empty string in `tabUrlPath`, the DeepLinker code should factor that in when generating the URL slug.  The same problem happens when using the `tabTitle` attribute.  A blank title yields an extra slash.\r\n\r\nI hope someone can fix this. I'm pretty sure the code fix will be somewhere in here: https://github.com/driftyco/ionic/blob/504e6e0440032d5813566def22a57f0e410bc2c6/src/navigation/deep-linker.ts"},"comment":{"url":"https://api.github.com/repos/driftyco/ionic/issues/comments/258910162","html_url":"https://github.com/driftyco/ionic/issues/9012#issuecomment-258910162","issue_url":"https://api.github.com/repos/driftyco/ionic/issues/9012","id":258910162,"user":{"login":"mhartington","id":2835826,"avatar_url":"https://avatars.githubusercontent.com/u/2835826?v=3","gravatar_id":"","url":"https://api.github.com/users/mhartington","html_url":"https://github.com/mhartington","followers_url":"https://api.github.com/users/mhartington/followers","following_url":"https://api.github.com/users/mhartington/following{/other_user}","gists_url":"https://api.github.com/users/mhartington/gists{/gist_id}","starred_url":"https://api.github.com/users/mhartington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhartington/subscriptions","organizations_url":"https://api.github.com/users/mhartington/orgs","repos_url":"https://api.github.com/users/mhartington/repos","events_url":"https://api.github.com/users/mhartington/events{/privacy}","received_events_url":"https://api.github.com/users/mhartington/received_events","type":"User","site_admin":false},"created_at":"2016-11-07T17:55:59Z","updated_at":"2016-11-07T17:55:59Z","body":"This is to be expected. Since the tabs act as their own sub nav, with it's own navController instance, it gets it's own url segment. This is by design. "}}
{"actor":{"display_login":"mhartington"}}