{"action":"created","issue":{"url":"https://api.github.com/repos/lift/framework/issues/1751","labels_url":"https://api.github.com/repos/lift/framework/issues/1751/labels{/name}","comments_url":"https://api.github.com/repos/lift/framework/issues/1751/comments","events_url":"https://api.github.com/repos/lift/framework/issues/1751/events","html_url":"https://github.com/lift/framework/pull/1751","id":124158848,"number":1751,"title":"Ajax Event Extraction: Allow event extraction in AJAX responses","user":{"login":"Shadowfiend","id":8245,"avatar_url":"https://avatars.githubusercontent.com/u/8245?v=3","gravatar_id":"","url":"https://api.github.com/users/Shadowfiend","html_url":"https://github.com/Shadowfiend","followers_url":"https://api.github.com/users/Shadowfiend/followers","following_url":"https://api.github.com/users/Shadowfiend/following{/other_user}","gists_url":"https://api.github.com/users/Shadowfiend/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadowfiend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadowfiend/subscriptions","organizations_url":"https://api.github.com/users/Shadowfiend/orgs","repos_url":"https://api.github.com/users/Shadowfiend/repos","events_url":"https://api.github.com/users/Shadowfiend/events{/privacy}","received_events_url":"https://api.github.com/users/Shadowfiend/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-29T03:44:48Z","updated_at":"2016-01-05T13:56:31Z","closed_at":"2016-01-05T13:56:31Z","pull_request":{"url":"https://api.github.com/repos/lift/framework/pulls/1751","html_url":"https://github.com/lift/framework/pull/1751","diff_url":"https://github.com/lift/framework/pull/1751.diff","patch_url":"https://github.com/lift/framework/pull/1751.patch"},"body":"Abstract out extraction of HTML event attributes into JS via\r\na common `HtmlNormalizer` singleton that also handles URL\r\nnormalization (prefixing of context path, rewriting, etc). This\r\nextracts some functionality that was mostly in `LiftMerge`, and\r\nallows for extensible invocations that let `LiftMerge` do the\r\nadditional things it needs to do to properly render a full page\r\n(like HTML head and tail merging).\r\n\r\nThe current code is decent but not final, and there are currently\r\nno tests. I'll be going back and writing tests for `LiftMerge`'s\r\noriginal behavior to confirm that there were no regressions, though\r\nof course that's always hard to do after the fact.\r\n\r\nWould appreciate a first pass at what's here now—I've improved\r\nverbiage throughout and things should hopefully be easier to follow\r\nthan they were before.\r\n\r\nThis fixes #1700."},"comment":{"url":"https://api.github.com/repos/lift/framework/issues/comments/169007923","html_url":"https://github.com/lift/framework/pull/1751#issuecomment-169007923","issue_url":"https://api.github.com/repos/lift/framework/issues/1751","id":169007923,"user":{"login":"Shadowfiend","id":8245,"avatar_url":"https://avatars.githubusercontent.com/u/8245?v=3","gravatar_id":"","url":"https://api.github.com/users/Shadowfiend","html_url":"https://github.com/Shadowfiend","followers_url":"https://api.github.com/users/Shadowfiend/followers","following_url":"https://api.github.com/users/Shadowfiend/following{/other_user}","gists_url":"https://api.github.com/users/Shadowfiend/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadowfiend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadowfiend/subscriptions","organizations_url":"https://api.github.com/users/Shadowfiend/orgs","repos_url":"https://api.github.com/users/Shadowfiend/repos","events_url":"https://api.github.com/users/Shadowfiend/events{/privacy}","received_events_url":"https://api.github.com/users/Shadowfiend/received_events","type":"User","site_admin":false},"created_at":"2016-01-05T13:56:31Z","updated_at":"2016-01-05T13:56:31Z","body":"Sadly the current solution completely breaks `LiftMerge`. Fortunately, I now have specs for `LiftMerge`. Will open a separate PR for this."}}