{"action":"created","comment":{"url":"https://api.github.com/repos/apache/apex-core/pulls/comments/91479367","pull_request_review_id":11986908,"id":91479367,"diff_hunk":"@@ -50,6 +50,12 @@\n       </includes>\n     </fileSet>\n     <fileSet filtered=\"true\" encoding=\"UTF-8\">\n+      <directory>src/main/resources</directory>\n+      <includes>\n+        <include>**/apexlog4j.properties</include>","path":"apex-app-archetype/src/main/resources/META-INF/maven/archetype-metadata.xml","position":6,"original_position":6,"commit_id":"d80bc12b4eb05975a8ac40ee4eeb22241389cf40","original_commit_id":"d80bc12b4eb05975a8ac40ee4eeb22241389cf40","user":{"login":"DT-Priyanka","id":8776018,"avatar_url":"https://avatars.githubusercontent.com/u/8776018?v=3","gravatar_id":"","url":"https://api.github.com/users/DT-Priyanka","html_url":"https://github.com/DT-Priyanka","followers_url":"https://api.github.com/users/DT-Priyanka/followers","following_url":"https://api.github.com/users/DT-Priyanka/following{/other_user}","gists_url":"https://api.github.com/users/DT-Priyanka/gists{/gist_id}","starred_url":"https://api.github.com/users/DT-Priyanka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DT-Priyanka/subscriptions","organizations_url":"https://api.github.com/users/DT-Priyanka/orgs","repos_url":"https://api.github.com/users/DT-Priyanka/repos","events_url":"https://api.github.com/users/DT-Priyanka/events{/privacy}","received_events_url":"https://api.github.com/users/DT-Priyanka/received_events","type":"User","site_admin":false},"body":"After revisiting here are my findings:\r\nI would prefer to name this file differently so that for users it's clear that a custom logger cong file is used. As hadoop and other logger config files are likely to have name log4j.properties, sometimes it could be confusing to figure out which one is getting loaded currently.\r\nTechnically, it's little tricky as \"/home/hduser/datatorrent/releases/3.7.0-SNAPSHOT/conf\" is in classpath when ApexCli is launched and if we have file named log4j.properties there, it will be picked and the ApexCli will try to use to use our logger configuration and hence will redirect logs to a file rather than console. Even if I manage to fix this place, I am sure it will create such confusions at some place or other.\r\nThat's why I feel it's good to give it distinct name so we can selectively use it, when we really want to. And we don't end up loading it accidently.","created_at":"2016-12-08T09:49:04Z","updated_at":"2016-12-08T09:49:04Z","html_url":"https://github.com/apache/apex-core/pull/421#discussion_r91479367","pull_request_url":"https://api.github.com/repos/apache/apex-core/pulls/421","_links":{"self":{"href":"https://api.github.com/repos/apache/apex-core/pulls/comments/91479367"},"html":{"href":"https://github.com/apache/apex-core/pull/421#discussion_r91479367"},"pull_request":{"href":"https://api.github.com/repos/apache/apex-core/pulls/421"}}},"pull_request":{"url":"https://api.github.com/repos/apache/apex-core/pulls/421","id":94994330,"html_url":"https://github.com/apache/apex-core/pull/421","diff_url":"https://github.com/apache/apex-core/pull/421.diff","patch_url":"https://github.com/apache/apex-core/pull/421.patch","issue_url":"https://api.github.com/repos/apache/apex-core/issues/421","number":421,"state":"open","locked":false,"title":"APEXCORE-563: Adding APEXRFA appender to roll log files without renam…","user":{"login":"DT-Priyanka","id":8776018,"avatar_url":"https://avatars.githubusercontent.com/u/8776018?v=3","gravatar_id":"","url":"https://api.github.com/users/DT-Priyanka","html_url":"https://github.com/DT-Priyanka","followers_url":"https://api.github.com/users/DT-Priyanka/followers","following_url":"https://api.github.com/users/DT-Priyanka/following{/other_user}","gists_url":"https://api.github.com/users/DT-Priyanka/gists{/gist_id}","starred_url":"https://api.github.com/users/DT-Priyanka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DT-Priyanka/subscriptions","organizations_url":"https://api.github.com/users/DT-Priyanka/orgs","repos_url":"https://api.github.com/users/DT-Priyanka/repos","events_url":"https://api.github.com/users/DT-Priyanka/events{/privacy}","received_events_url":"https://api.github.com/users/DT-Priyanka/received_events","type":"User","site_admin":false},"body":"…ing them, also adding log file name and offset in events","created_at":"2016-11-23T12:31:09Z","updated_at":"2016-12-08T09:49:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"981d49fe85a9f54c7e5c490dac473d6e1019ec73","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/apex-core/pulls/421/commits","review_comments_url":"https://api.github.com/repos/apache/apex-core/pulls/421/comments","review_comment_url":"https://api.github.com/repos/apache/apex-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/apex-core/issues/421/comments","statuses_url":"https://api.github.com/repos/apache/apex-core/statuses/d80bc12b4eb05975a8ac40ee4eeb22241389cf40","head":{"label":"DT-Priyanka:APEXCORE-563-log-appender","ref":"APEXCORE-563-log-appender","sha":"d80bc12b4eb05975a8ac40ee4eeb22241389cf40","user":{"login":"DT-Priyanka","id":8776018,"avatar_url":"https://avatars.githubusercontent.com/u/8776018?v=3","gravatar_id":"","url":"https://api.github.com/users/DT-Priyanka","html_url":"https://github.com/DT-Priyanka","followers_url":"https://api.github.com/users/DT-Priyanka/followers","following_url":"https://api.github.com/users/DT-Priyanka/following{/other_user}","gists_url":"https://api.github.com/users/DT-Priyanka/gists{/gist_id}","starred_url":"https://api.github.com/users/DT-Priyanka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DT-Priyanka/subscriptions","organizations_url":"https://api.github.com/users/DT-Priyanka/orgs","repos_url":"https://api.github.com/users/DT-Priyanka/repos","events_url":"https://api.github.com/users/DT-Priyanka/events{/privacy}","received_events_url":"https://api.github.com/users/DT-Priyanka/received_events","type":"User","site_admin":false},"repo":{"id":42163015,"name":"incubator-apex-core","full_name":"DT-Priyanka/incubator-apex-core","owner":{"login":"DT-Priyanka","id":8776018,"avatar_url":"https://avatars.githubusercontent.com/u/8776018?v=3","gravatar_id":"","url":"https://api.github.com/users/DT-Priyanka","html_url":"https://github.com/DT-Priyanka","followers_url":"https://api.github.com/users/DT-Priyanka/followers","following_url":"https://api.github.com/users/DT-Priyanka/following{/other_user}","gists_url":"https://api.github.com/users/DT-Priyanka/gists{/gist_id}","starred_url":"https://api.github.com/users/DT-Priyanka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DT-Priyanka/subscriptions","organizations_url":"https://api.github.com/users/DT-Priyanka/orgs","repos_url":"https://api.github.com/users/DT-Priyanka/repos","events_url":"https://api.github.com/users/DT-Priyanka/events{/privacy}","received_events_url":"https://api.github.com/users/DT-Priyanka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DT-Priyanka/incubator-apex-core","description":"Mirror of Apache Apex core (Incubating)","fork":true,"url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core","forks_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/forks","keys_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/teams","hooks_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/hooks","issue_events_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/issues/events{/number}","events_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/events","assignees_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/assignees{/user}","branches_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/branches{/branch}","tags_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/tags","blobs_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/statuses/{sha}","languages_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/languages","stargazers_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/stargazers","contributors_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/contributors","subscribers_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/subscribers","subscription_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/subscription","commits_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/contents/{+path}","compare_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/merges","archive_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/downloads","issues_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/issues{/number}","pulls_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/pulls{/number}","milestones_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/milestones{/number}","notifications_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/labels{/name}","releases_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/releases{/id}","deployments_url":"https://api.github.com/repos/DT-Priyanka/incubator-apex-core/deployments","created_at":"2015-09-09T07:27:17Z","updated_at":"2015-09-09T07:27:22Z","pushed_at":"2016-12-06T06:43:51Z","git_url":"git://github.com/DT-Priyanka/incubator-apex-core.git","ssh_url":"git@github.com:DT-Priyanka/incubator-apex-core.git","clone_url":"https://github.com/DT-Priyanka/incubator-apex-core.git","svn_url":"https://github.com/DT-Priyanka/incubator-apex-core","homepage":null,"size":13660,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d514859a8d51464a8a849286444ea9863ea7077f","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":41348333,"name":"apex-core","full_name":"apache/apex-core","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/apex-core","description":"Mirror of Apache Apex core","fork":false,"url":"https://api.github.com/repos/apache/apex-core","forks_url":"https://api.github.com/repos/apache/apex-core/forks","keys_url":"https://api.github.com/repos/apache/apex-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/apex-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/apex-core/teams","hooks_url":"https://api.github.com/repos/apache/apex-core/hooks","issue_events_url":"https://api.github.com/repos/apache/apex-core/issues/events{/number}","events_url":"https://api.github.com/repos/apache/apex-core/events","assignees_url":"https://api.github.com/repos/apache/apex-core/assignees{/user}","branches_url":"https://api.github.com/repos/apache/apex-core/branches{/branch}","tags_url":"https://api.github.com/repos/apache/apex-core/tags","blobs_url":"https://api.github.com/repos/apache/apex-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/apex-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/apex-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/apex-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/apex-core/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/apex-core/languages","stargazers_url":"https://api.github.com/repos/apache/apex-core/stargazers","contributors_url":"https://api.github.com/repos/apache/apex-core/contributors","subscribers_url":"https://api.github.com/repos/apache/apex-core/subscribers","subscription_url":"https://api.github.com/repos/apache/apex-core/subscription","commits_url":"https://api.github.com/repos/apache/apex-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/apex-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/apex-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/apex-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/apex-core/contents/{+path}","compare_url":"https://api.github.com/repos/apache/apex-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/apex-core/merges","archive_url":"https://api.github.com/repos/apache/apex-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/apex-core/downloads","issues_url":"https://api.github.com/repos/apache/apex-core/issues{/number}","pulls_url":"https://api.github.com/repos/apache/apex-core/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/apex-core/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/apex-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/apex-core/labels{/name}","releases_url":"https://api.github.com/repos/apache/apex-core/releases{/id}","deployments_url":"https://api.github.com/repos/apache/apex-core/deployments","created_at":"2015-08-25T07:00:05Z","updated_at":"2016-12-07T07:10:12Z","pushed_at":"2016-12-08T01:58:27Z","git_url":"git://github.com/apache/apex-core.git","ssh_url":"git@github.com:apache/apex-core.git","clone_url":"https://github.com/apache/apex-core.git","svn_url":"https://github.com/apache/apex-core","homepage":"","size":21327,"stargazers_count":190,"watchers_count":190,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":125,"mirror_url":"git://git.apache.org/incubator-apex-core.git","open_issues_count":12,"forks":125,"open_issues":12,"watchers":190,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/apex-core/pulls/421"},"html":{"href":"https://github.com/apache/apex-core/pull/421"},"issue":{"href":"https://api.github.com/repos/apache/apex-core/issues/421"},"comments":{"href":"https://api.github.com/repos/apache/apex-core/issues/421/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/apex-core/pulls/421/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/apex-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/apex-core/pulls/421/commits"},"statuses":{"href":"https://api.github.com/repos/apache/apex-core/statuses/d80bc12b4eb05975a8ac40ee4eeb22241389cf40"}}}}
{"actor":{"display_login":"DT-Priyanka"}}