{"action":"created","comment":{"url":"https://api.github.com/repos/OPM/opm-core/pulls/comments/65027266","id":65027266,"diff_hunk":"@@ -224,7 +226,7 @@ namespace Opm {\n                 // write data if outputWriter was provided\n                 if( outputWriter ) {\n                     bool substep = true;\n-                    outputWriter->writeTimeStep( substepTimer, state, well_state, substep);\n+                    outputWriter->writeTimeStep( substepTimer, state, well_state, wells, substep);","path":"opm/core/simulator/AdaptiveTimeStepping_impl.hpp","position":33,"original_position":33,"commit_id":"75cdd761b141a1c759ee0c22f77ee632fd5db239","original_commit_id":"75cdd761b141a1c759ee0c22f77ee632fd5db239","user":{"login":"atgeirr","id":1876621,"avatar_url":"https://avatars.githubusercontent.com/u/1876621?v=3","gravatar_id":"","url":"https://api.github.com/users/atgeirr","html_url":"https://github.com/atgeirr","followers_url":"https://api.github.com/users/atgeirr/followers","following_url":"https://api.github.com/users/atgeirr/following{/other_user}","gists_url":"https://api.github.com/users/atgeirr/gists{/gist_id}","starred_url":"https://api.github.com/users/atgeirr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atgeirr/subscriptions","organizations_url":"https://api.github.com/users/atgeirr/orgs","repos_url":"https://api.github.com/users/atgeirr/repos","events_url":"https://api.github.com/users/atgeirr/events{/privacy}","received_events_url":"https://api.github.com/users/atgeirr/received_events","type":"User","site_admin":false},"body":"Looking again I am still confused... as @joakim-hove pointed out there seems to be a mismatch between the argument of the call (opm-core's struct Wells) and the parameters of the function (opm-output's class data::Wells). Also, if required in the API of opm-output, then opm-output must depend on opm-core for it, unless you use it through a template argument. What is going on here?\r\n\r\n(I stand by my original points, although I'm willing to make temporary compromises for things that need to be done quickly. I cannot merge something I don't understand at all though!)","created_at":"2016-05-30T06:12:21Z","updated_at":"2016-05-30T06:12:21Z","html_url":"https://github.com/OPM/opm-core/pull/1016#discussion_r65027266","pull_request_url":"https://api.github.com/repos/OPM/opm-core/pulls/1016","_links":{"self":{"href":"https://api.github.com/repos/OPM/opm-core/pulls/comments/65027266"},"html":{"href":"https://github.com/OPM/opm-core/pull/1016#discussion_r65027266"},"pull_request":{"href":"https://api.github.com/repos/OPM/opm-core/pulls/1016"}}},"pull_request":{"url":"https://api.github.com/repos/OPM/opm-core/pulls/1016","id":69809121,"html_url":"https://github.com/OPM/opm-core/pull/1016","diff_url":"https://github.com/OPM/opm-core/pull/1016.diff","patch_url":"https://github.com/OPM/opm-core/pull/1016.patch","issue_url":"https://api.github.com/repos/OPM/opm-core/issues/1016","number":1016,"state":"open","locked":false,"title":"Breaking opm-core dependency in opm-output; new summary implementation","user":{"login":"jokva","id":8667957,"avatar_url":"https://avatars.githubusercontent.com/u/8667957?v=3","gravatar_id":"","url":"https://api.github.com/users/jokva","html_url":"https://github.com/jokva","followers_url":"https://api.github.com/users/jokva/followers","following_url":"https://api.github.com/users/jokva/following{/other_user}","gists_url":"https://api.github.com/users/jokva/gists{/gist_id}","starred_url":"https://api.github.com/users/jokva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jokva/subscriptions","organizations_url":"https://api.github.com/users/jokva/orgs","repos_url":"https://api.github.com/users/jokva/repos","events_url":"https://api.github.com/users/jokva/events{/privacy}","received_events_url":"https://api.github.com/users/jokva/received_events","type":"User","site_admin":false},"body":"See https://github.com/OPM/opm-output/pull/30","created_at":"2016-05-12T09:58:19Z","updated_at":"2016-05-30T06:12:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b79349d531085e1832cc771d168193259a1384a0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OPM/opm-core/pulls/1016/commits","review_comments_url":"https://api.github.com/repos/OPM/opm-core/pulls/1016/comments","review_comment_url":"https://api.github.com/repos/OPM/opm-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OPM/opm-core/issues/1016/comments","statuses_url":"https://api.github.com/repos/OPM/opm-core/statuses/75cdd761b141a1c759ee0c22f77ee632fd5db239","head":{"label":"jokva:refactor-output-restart","ref":"refactor-output-restart","sha":"75cdd761b141a1c759ee0c22f77ee632fd5db239","user":{"login":"jokva","id":8667957,"avatar_url":"https://avatars.githubusercontent.com/u/8667957?v=3","gravatar_id":"","url":"https://api.github.com/users/jokva","html_url":"https://github.com/jokva","followers_url":"https://api.github.com/users/jokva/followers","following_url":"https://api.github.com/users/jokva/following{/other_user}","gists_url":"https://api.github.com/users/jokva/gists{/gist_id}","starred_url":"https://api.github.com/users/jokva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jokva/subscriptions","organizations_url":"https://api.github.com/users/jokva/orgs","repos_url":"https://api.github.com/users/jokva/repos","events_url":"https://api.github.com/users/jokva/events{/privacy}","received_events_url":"https://api.github.com/users/jokva/received_events","type":"User","site_admin":false},"repo":{"id":24096364,"name":"opm-core","full_name":"jokva/opm-core","owner":{"login":"jokva","id":8667957,"avatar_url":"https://avatars.githubusercontent.com/u/8667957?v=3","gravatar_id":"","url":"https://api.github.com/users/jokva","html_url":"https://github.com/jokva","followers_url":"https://api.github.com/users/jokva/followers","following_url":"https://api.github.com/users/jokva/following{/other_user}","gists_url":"https://api.github.com/users/jokva/gists{/gist_id}","starred_url":"https://api.github.com/users/jokva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jokva/subscriptions","organizations_url":"https://api.github.com/users/jokva/orgs","repos_url":"https://api.github.com/users/jokva/repos","events_url":"https://api.github.com/users/jokva/events{/privacy}","received_events_url":"https://api.github.com/users/jokva/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jokva/opm-core","description":"Open Porous Media Core Library","fork":true,"url":"https://api.github.com/repos/jokva/opm-core","forks_url":"https://api.github.com/repos/jokva/opm-core/forks","keys_url":"https://api.github.com/repos/jokva/opm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jokva/opm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jokva/opm-core/teams","hooks_url":"https://api.github.com/repos/jokva/opm-core/hooks","issue_events_url":"https://api.github.com/repos/jokva/opm-core/issues/events{/number}","events_url":"https://api.github.com/repos/jokva/opm-core/events","assignees_url":"https://api.github.com/repos/jokva/opm-core/assignees{/user}","branches_url":"https://api.github.com/repos/jokva/opm-core/branches{/branch}","tags_url":"https://api.github.com/repos/jokva/opm-core/tags","blobs_url":"https://api.github.com/repos/jokva/opm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jokva/opm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jokva/opm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/jokva/opm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jokva/opm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/jokva/opm-core/languages","stargazers_url":"https://api.github.com/repos/jokva/opm-core/stargazers","contributors_url":"https://api.github.com/repos/jokva/opm-core/contributors","subscribers_url":"https://api.github.com/repos/jokva/opm-core/subscribers","subscription_url":"https://api.github.com/repos/jokva/opm-core/subscription","commits_url":"https://api.github.com/repos/jokva/opm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/jokva/opm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/jokva/opm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/jokva/opm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/jokva/opm-core/contents/{+path}","compare_url":"https://api.github.com/repos/jokva/opm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jokva/opm-core/merges","archive_url":"https://api.github.com/repos/jokva/opm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jokva/opm-core/downloads","issues_url":"https://api.github.com/repos/jokva/opm-core/issues{/number}","pulls_url":"https://api.github.com/repos/jokva/opm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/jokva/opm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/jokva/opm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jokva/opm-core/labels{/name}","releases_url":"https://api.github.com/repos/jokva/opm-core/releases{/id}","deployments_url":"https://api.github.com/repos/jokva/opm-core/deployments","created_at":"2014-09-16T11:10:31Z","updated_at":"2016-01-20T08:05:46Z","pushed_at":"2016-05-20T14:40:11Z","git_url":"git://github.com/jokva/opm-core.git","ssh_url":"git@github.com:jokva/opm-core.git","clone_url":"https://github.com/jokva/opm-core.git","svn_url":"https://github.com/jokva/opm-core","homepage":"http://www.opm-project.org","size":12290,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OPM:master","ref":"master","sha":"537c4dd730b0f1e5aec0397eac072cfbdbbe6286","user":{"login":"OPM","id":1827197,"avatar_url":"https://avatars.githubusercontent.com/u/1827197?v=3","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"repo":{"id":4787500,"name":"opm-core","full_name":"OPM/opm-core","owner":{"login":"OPM","id":1827197,"avatar_url":"https://avatars.githubusercontent.com/u/1827197?v=3","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OPM/opm-core","description":"Collection of utilities, solvers and other components.","fork":false,"url":"https://api.github.com/repos/OPM/opm-core","forks_url":"https://api.github.com/repos/OPM/opm-core/forks","keys_url":"https://api.github.com/repos/OPM/opm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OPM/opm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OPM/opm-core/teams","hooks_url":"https://api.github.com/repos/OPM/opm-core/hooks","issue_events_url":"https://api.github.com/repos/OPM/opm-core/issues/events{/number}","events_url":"https://api.github.com/repos/OPM/opm-core/events","assignees_url":"https://api.github.com/repos/OPM/opm-core/assignees{/user}","branches_url":"https://api.github.com/repos/OPM/opm-core/branches{/branch}","tags_url":"https://api.github.com/repos/OPM/opm-core/tags","blobs_url":"https://api.github.com/repos/OPM/opm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OPM/opm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OPM/opm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/OPM/opm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OPM/opm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/OPM/opm-core/languages","stargazers_url":"https://api.github.com/repos/OPM/opm-core/stargazers","contributors_url":"https://api.github.com/repos/OPM/opm-core/contributors","subscribers_url":"https://api.github.com/repos/OPM/opm-core/subscribers","subscription_url":"https://api.github.com/repos/OPM/opm-core/subscription","commits_url":"https://api.github.com/repos/OPM/opm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/OPM/opm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/OPM/opm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/OPM/opm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/OPM/opm-core/contents/{+path}","compare_url":"https://api.github.com/repos/OPM/opm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OPM/opm-core/merges","archive_url":"https://api.github.com/repos/OPM/opm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OPM/opm-core/downloads","issues_url":"https://api.github.com/repos/OPM/opm-core/issues{/number}","pulls_url":"https://api.github.com/repos/OPM/opm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/OPM/opm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/OPM/opm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OPM/opm-core/labels{/name}","releases_url":"https://api.github.com/repos/OPM/opm-core/releases{/id}","deployments_url":"https://api.github.com/repos/OPM/opm-core/deployments","created_at":"2012-06-25T21:14:06Z","updated_at":"2016-04-11T07:18:01Z","pushed_at":"2016-05-27T09:15:33Z","git_url":"git://github.com/OPM/opm-core.git","ssh_url":"git@github.com:OPM/opm-core.git","clone_url":"https://github.com/OPM/opm-core.git","svn_url":"https://github.com/OPM/opm-core","homepage":"http://www.opm-project.org","size":15310,"stargazers_count":22,"watchers_count":22,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":12,"forks":46,"open_issues":12,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OPM/opm-core/pulls/1016"},"html":{"href":"https://github.com/OPM/opm-core/pull/1016"},"issue":{"href":"https://api.github.com/repos/OPM/opm-core/issues/1016"},"comments":{"href":"https://api.github.com/repos/OPM/opm-core/issues/1016/comments"},"review_comments":{"href":"https://api.github.com/repos/OPM/opm-core/pulls/1016/comments"},"review_comment":{"href":"https://api.github.com/repos/OPM/opm-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OPM/opm-core/pulls/1016/commits"},"statuses":{"href":"https://api.github.com/repos/OPM/opm-core/statuses/75cdd761b141a1c759ee0c22f77ee632fd5db239"}}}}
{"actor":{"display_login":"atgeirr"}}