{"action":"created","comment":{"url":"https://api.github.com/repos/meteor/data/pulls/comments/52393580","id":52393580,"diff_hunk":"@@ -151,12 +184,22 @@ The rest of the document talks in terms of polling a dependency server for updat\n 1. The invalidation server could accept websocket connections, and let the client subscribe to the dependency keys it cares about - this would mean the invalidation is pushed immediately, and then there is one roundtrip to fetch the actual data.\n 2. The application server could subscribe to the invalidations, and do the GraphQL queries _on the server_, and then diff that against the current state of the client and send a patch. This would make the system work almost exactly like Meteor today, and could be a good option for applications with fewer users and a great need for low latency.\n \n+// I think it's better to go with Just the 1. We could optimize on top of that. It's not a good idea to maintain two different things.","path":"design/high-level-reactivity.md","position":64,"original_position":64,"commit_id":"c78f9a65f10acda126d57e387ab58604cf8419ea","original_commit_id":"c78f9a65f10acda126d57e387ab58604cf8419ea","user":{"login":"stubailo","id":448783,"avatar_url":"https://avatars.githubusercontent.com/u/448783?v=3","gravatar_id":"","url":"https://api.github.com/users/stubailo","html_url":"https://github.com/stubailo","followers_url":"https://api.github.com/users/stubailo/followers","following_url":"https://api.github.com/users/stubailo/following{/other_user}","gists_url":"https://api.github.com/users/stubailo/gists{/gist_id}","starred_url":"https://api.github.com/users/stubailo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stubailo/subscriptions","organizations_url":"https://api.github.com/users/stubailo/orgs","repos_url":"https://api.github.com/users/stubailo/repos","events_url":"https://api.github.com/users/stubailo/events{/privacy}","received_events_url":"https://api.github.com/users/stubailo/received_events","type":"User","site_admin":false},"body":"I just want to emphasize that this design doesn't _stop_ you from implementing 2. I agree we shouldn't have it in the core implementation.","created_at":"2016-02-09T23:37:53Z","updated_at":"2016-02-09T23:37:53Z","html_url":"https://github.com/meteor/data/pull/9#discussion_r52393580","pull_request_url":"https://api.github.com/repos/meteor/data/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/meteor/data/pulls/comments/52393580"},"html":{"href":"https://github.com/meteor/data/pull/9#discussion_r52393580"},"pull_request":{"href":"https://api.github.com/repos/meteor/data/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/meteor/data/pulls/9","id":58821010,"html_url":"https://github.com/meteor/data/pull/9","diff_url":"https://github.com/meteor/data/pull/9.diff","patch_url":"https://github.com/meteor/data/pull/9.patch","issue_url":"https://api.github.com/repos/meteor/data/issues/9","number":9,"state":"open","locked":false,"title":"Comment PR: Add comments for the design overview","user":{"login":"arunoda","id":50838,"avatar_url":"https://avatars.githubusercontent.com/u/50838?v=3","gravatar_id":"","url":"https://api.github.com/users/arunoda","html_url":"https://github.com/arunoda","followers_url":"https://api.github.com/users/arunoda/followers","following_url":"https://api.github.com/users/arunoda/following{/other_user}","gists_url":"https://api.github.com/users/arunoda/gists{/gist_id}","starred_url":"https://api.github.com/users/arunoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arunoda/subscriptions","organizations_url":"https://api.github.com/users/arunoda/orgs","repos_url":"https://api.github.com/users/arunoda/repos","events_url":"https://api.github.com/users/arunoda/events{/privacy}","received_events_url":"https://api.github.com/users/arunoda/received_events","type":"User","site_admin":false},"body":"Overall this is just great!\r\n\r\nIn my design, I was thinking to get invalidations to the client side (if needed) and decide to fetch or not).\r\nBut this is far better.\r\n\r\nI add some more comments close to each section.\r\nSee `Files changed` tab","created_at":"2016-02-09T22:44:03Z","updated_at":"2016-02-09T23:37:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3699f1196c433932042deb151588aca22d6be52","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/meteor/data/pulls/9/commits","review_comments_url":"https://api.github.com/repos/meteor/data/pulls/9/comments","review_comment_url":"https://api.github.com/repos/meteor/data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meteor/data/issues/9/comments","statuses_url":"https://api.github.com/repos/meteor/data/statuses/c78f9a65f10acda126d57e387ab58604cf8419ea","head":{"label":"arunoda:patch-1","ref":"patch-1","sha":"c78f9a65f10acda126d57e387ab58604cf8419ea","user":{"login":"arunoda","id":50838,"avatar_url":"https://avatars.githubusercontent.com/u/50838?v=3","gravatar_id":"","url":"https://api.github.com/users/arunoda","html_url":"https://github.com/arunoda","followers_url":"https://api.github.com/users/arunoda/followers","following_url":"https://api.github.com/users/arunoda/following{/other_user}","gists_url":"https://api.github.com/users/arunoda/gists{/gist_id}","starred_url":"https://api.github.com/users/arunoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arunoda/subscriptions","organizations_url":"https://api.github.com/users/arunoda/orgs","repos_url":"https://api.github.com/users/arunoda/repos","events_url":"https://api.github.com/users/arunoda/events{/privacy}","received_events_url":"https://api.github.com/users/arunoda/received_events","type":"User","site_admin":false},"repo":{"id":51403995,"name":"data","full_name":"arunoda/data","owner":{"login":"arunoda","id":50838,"avatar_url":"https://avatars.githubusercontent.com/u/50838?v=3","gravatar_id":"","url":"https://api.github.com/users/arunoda","html_url":"https://github.com/arunoda","followers_url":"https://api.github.com/users/arunoda/followers","following_url":"https://api.github.com/users/arunoda/following{/other_user}","gists_url":"https://api.github.com/users/arunoda/gists{/gist_id}","starred_url":"https://api.github.com/users/arunoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arunoda/subscriptions","organizations_url":"https://api.github.com/users/arunoda/orgs","repos_url":"https://api.github.com/users/arunoda/repos","events_url":"https://api.github.com/users/arunoda/events{/privacy}","received_events_url":"https://api.github.com/users/arunoda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arunoda/data","description":"The central repository for the new GraphQL-based Meteor data platform.","fork":true,"url":"https://api.github.com/repos/arunoda/data","forks_url":"https://api.github.com/repos/arunoda/data/forks","keys_url":"https://api.github.com/repos/arunoda/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arunoda/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arunoda/data/teams","hooks_url":"https://api.github.com/repos/arunoda/data/hooks","issue_events_url":"https://api.github.com/repos/arunoda/data/issues/events{/number}","events_url":"https://api.github.com/repos/arunoda/data/events","assignees_url":"https://api.github.com/repos/arunoda/data/assignees{/user}","branches_url":"https://api.github.com/repos/arunoda/data/branches{/branch}","tags_url":"https://api.github.com/repos/arunoda/data/tags","blobs_url":"https://api.github.com/repos/arunoda/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arunoda/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arunoda/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/arunoda/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arunoda/data/statuses/{sha}","languages_url":"https://api.github.com/repos/arunoda/data/languages","stargazers_url":"https://api.github.com/repos/arunoda/data/stargazers","contributors_url":"https://api.github.com/repos/arunoda/data/contributors","subscribers_url":"https://api.github.com/repos/arunoda/data/subscribers","subscription_url":"https://api.github.com/repos/arunoda/data/subscription","commits_url":"https://api.github.com/repos/arunoda/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/arunoda/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/arunoda/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/arunoda/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/arunoda/data/contents/{+path}","compare_url":"https://api.github.com/repos/arunoda/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arunoda/data/merges","archive_url":"https://api.github.com/repos/arunoda/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arunoda/data/downloads","issues_url":"https://api.github.com/repos/arunoda/data/issues{/number}","pulls_url":"https://api.github.com/repos/arunoda/data/pulls{/number}","milestones_url":"https://api.github.com/repos/arunoda/data/milestones{/number}","notifications_url":"https://api.github.com/repos/arunoda/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arunoda/data/labels{/name}","releases_url":"https://api.github.com/repos/arunoda/data/releases{/id}","deployments_url":"https://api.github.com/repos/arunoda/data/deployments","created_at":"2016-02-09T22:10:06Z","updated_at":"2016-02-09T22:08:17Z","pushed_at":"2016-02-09T22:50:19Z","git_url":"git://github.com/arunoda/data.git","ssh_url":"git@github.com:arunoda/data.git","clone_url":"https://github.com/arunoda/data.git","svn_url":"https://github.com/arunoda/data","homepage":"","size":733,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"meteor:design-overview","ref":"design-overview","sha":"27808de42b0905c2bb0359d4169d118c66cc0a60","user":{"login":"meteor","id":789528,"avatar_url":"https://avatars.githubusercontent.com/u/789528?v=3","gravatar_id":"","url":"https://api.github.com/users/meteor","html_url":"https://github.com/meteor","followers_url":"https://api.github.com/users/meteor/followers","following_url":"https://api.github.com/users/meteor/following{/other_user}","gists_url":"https://api.github.com/users/meteor/gists{/gist_id}","starred_url":"https://api.github.com/users/meteor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteor/subscriptions","organizations_url":"https://api.github.com/users/meteor/orgs","repos_url":"https://api.github.com/users/meteor/repos","events_url":"https://api.github.com/users/meteor/events{/privacy}","received_events_url":"https://api.github.com/users/meteor/received_events","type":"Organization","site_admin":false},"repo":{"id":50384229,"name":"data","full_name":"meteor/data","owner":{"login":"meteor","id":789528,"avatar_url":"https://avatars.githubusercontent.com/u/789528?v=3","gravatar_id":"","url":"https://api.github.com/users/meteor","html_url":"https://github.com/meteor","followers_url":"https://api.github.com/users/meteor/followers","following_url":"https://api.github.com/users/meteor/following{/other_user}","gists_url":"https://api.github.com/users/meteor/gists{/gist_id}","starred_url":"https://api.github.com/users/meteor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteor/subscriptions","organizations_url":"https://api.github.com/users/meteor/orgs","repos_url":"https://api.github.com/users/meteor/repos","events_url":"https://api.github.com/users/meteor/events{/privacy}","received_events_url":"https://api.github.com/users/meteor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meteor/data","description":"The central repository for the new GraphQL-based Meteor data platform.","fork":false,"url":"https://api.github.com/repos/meteor/data","forks_url":"https://api.github.com/repos/meteor/data/forks","keys_url":"https://api.github.com/repos/meteor/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meteor/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meteor/data/teams","hooks_url":"https://api.github.com/repos/meteor/data/hooks","issue_events_url":"https://api.github.com/repos/meteor/data/issues/events{/number}","events_url":"https://api.github.com/repos/meteor/data/events","assignees_url":"https://api.github.com/repos/meteor/data/assignees{/user}","branches_url":"https://api.github.com/repos/meteor/data/branches{/branch}","tags_url":"https://api.github.com/repos/meteor/data/tags","blobs_url":"https://api.github.com/repos/meteor/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meteor/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meteor/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/meteor/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meteor/data/statuses/{sha}","languages_url":"https://api.github.com/repos/meteor/data/languages","stargazers_url":"https://api.github.com/repos/meteor/data/stargazers","contributors_url":"https://api.github.com/repos/meteor/data/contributors","subscribers_url":"https://api.github.com/repos/meteor/data/subscribers","subscription_url":"https://api.github.com/repos/meteor/data/subscription","commits_url":"https://api.github.com/repos/meteor/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/meteor/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/meteor/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/meteor/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/meteor/data/contents/{+path}","compare_url":"https://api.github.com/repos/meteor/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meteor/data/merges","archive_url":"https://api.github.com/repos/meteor/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meteor/data/downloads","issues_url":"https://api.github.com/repos/meteor/data/issues{/number}","pulls_url":"https://api.github.com/repos/meteor/data/pulls{/number}","milestones_url":"https://api.github.com/repos/meteor/data/milestones{/number}","notifications_url":"https://api.github.com/repos/meteor/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meteor/data/labels{/name}","releases_url":"https://api.github.com/repos/meteor/data/releases{/id}","deployments_url":"https://api.github.com/repos/meteor/data/deployments","created_at":"2016-01-25T22:03:43Z","updated_at":"2016-02-09T22:27:32Z","pushed_at":"2016-02-09T22:50:19Z","git_url":"git://github.com/meteor/data.git","ssh_url":"git@github.com:meteor/data.git","clone_url":"https://github.com/meteor/data.git","svn_url":"https://github.com/meteor/data","homepage":"","size":723,"stargazers_count":189,"watchers_count":189,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":8,"forks":2,"open_issues":8,"watchers":189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meteor/data/pulls/9"},"html":{"href":"https://github.com/meteor/data/pull/9"},"issue":{"href":"https://api.github.com/repos/meteor/data/issues/9"},"comments":{"href":"https://api.github.com/repos/meteor/data/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/meteor/data/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/meteor/data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meteor/data/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/meteor/data/statuses/c78f9a65f10acda126d57e387ab58604cf8419ea"}}}}