{"action":"created","issue":{"url":"https://api.github.com/repos/angular-ui/ui-select/issues/1715","repository_url":"https://api.github.com/repos/angular-ui/ui-select","labels_url":"https://api.github.com/repos/angular-ui/ui-select/issues/1715/labels{/name}","comments_url":"https://api.github.com/repos/angular-ui/ui-select/issues/1715/comments","events_url":"https://api.github.com/repos/angular-ui/ui-select/issues/1715/events","html_url":"https://github.com/angular-ui/ui-select/pull/1715","id":164688253,"number":1715,"title":"feat(groupBy): Define group by expression in repeat","user":{"login":"user378230","id":16818823,"avatar_url":"https://avatars.githubusercontent.com/u/16818823?v=3","gravatar_id":"","url":"https://api.github.com/users/user378230","html_url":"https://github.com/user378230","followers_url":"https://api.github.com/users/user378230/followers","following_url":"https://api.github.com/users/user378230/following{/other_user}","gists_url":"https://api.github.com/users/user378230/gists{/gist_id}","starred_url":"https://api.github.com/users/user378230/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/user378230/subscriptions","organizations_url":"https://api.github.com/users/user378230/orgs","repos_url":"https://api.github.com/users/user378230/repos","events_url":"https://api.github.com/users/user378230/events{/privacy}","received_events_url":"https://api.github.com/users/user378230/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular-ui/ui-select/labels/needs:%20breaking%20change","name":"needs: breaking change","color":"e11d21"},{"url":"https://api.github.com/repos/angular-ui/ui-select/labels/needs:%20review","name":"needs: review","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/angular-ui/ui-select/milestones/23","html_url":"https://github.com/angular-ui/ui-select/milestones/v0.19.0","labels_url":"https://api.github.com/repos/angular-ui/ui-select/milestones/23/labels","id":1874604,"number":23,"title":"v0.19.0","description":null,"creator":{"login":"user378230","id":16818823,"avatar_url":"https://avatars.githubusercontent.com/u/16818823?v=3","gravatar_id":"","url":"https://api.github.com/users/user378230","html_url":"https://github.com/user378230","followers_url":"https://api.github.com/users/user378230/followers","following_url":"https://api.github.com/users/user378230/following{/other_user}","gists_url":"https://api.github.com/users/user378230/gists{/gist_id}","starred_url":"https://api.github.com/users/user378230/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/user378230/subscriptions","organizations_url":"https://api.github.com/users/user378230/orgs","repos_url":"https://api.github.com/users/user378230/repos","events_url":"https://api.github.com/users/user378230/events{/privacy}","received_events_url":"https://api.github.com/users/user378230/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":1,"state":"open","created_at":"2016-07-10T22:27:48Z","updated_at":"2016-08-07T23:04:36Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-07-09T22:16:55Z","updated_at":"2016-08-07T23:20:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular-ui/ui-select/pulls/1715","html_url":"https://github.com/angular-ui/ui-select/pull/1715","diff_url":"https://github.com/angular-ui/ui-select/pull/1715.diff","patch_url":"https://github.com/angular-ui/ui-select/pull/1715.patch"},"body":"Changes the method for defining group by to simplify the codebase,\r\nimprove performance and better support changes going forward.\r\n\r\nBREAKING CHANGE:\r\n\r\nRemoves support for group-by and group-filter attributes. Instead you\r\nshould now use an `ng-repeat` *like* syntax: `... group by x | ...`\r\n\r\nFor example:\r\n```\r\n<ui-select-choices group-by=\"'country'\" group-filter=\"['USA']\"\r\n  repeat=\"person in ctrl.people\">\r\n```\r\nNow becomes:\r\n```\r\n<ui-select-choices\r\n  repeat=\"person in ctrl.people group by person.country | filter:{name: 'USA'}\">\r\n```\r\nNote that in order support filter groups based on an array with more\r\nthan one value (eg.`group-filter=\"['A', 'B'...]\"`) you will need to\r\nuse the new `uisGroupFilter` filter.\r\n\r\nExample:\r\n```\r\n<ui-select-choices\r\n  repeat=\"person in ctrl.people group by person.country | uisGroupFilter:['USA','Canada']\">\r\n```"},"comment":{"url":"https://api.github.com/repos/angular-ui/ui-select/issues/comments/238115228","html_url":"https://github.com/angular-ui/ui-select/pull/1715#issuecomment-238115228","issue_url":"https://api.github.com/repos/angular-ui/ui-select/issues/1715","id":238115228,"user":{"login":"aaronroberson","id":440189,"avatar_url":"https://avatars.githubusercontent.com/u/440189?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronroberson","html_url":"https://github.com/aaronroberson","followers_url":"https://api.github.com/users/aaronroberson/followers","following_url":"https://api.github.com/users/aaronroberson/following{/other_user}","gists_url":"https://api.github.com/users/aaronroberson/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronroberson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronroberson/subscriptions","organizations_url":"https://api.github.com/users/aaronroberson/orgs","repos_url":"https://api.github.com/users/aaronroberson/repos","events_url":"https://api.github.com/users/aaronroberson/events{/privacy}","received_events_url":"https://api.github.com/users/aaronroberson/received_events","type":"User","site_admin":false},"created_at":"2016-08-07T23:20:40Z","updated_at":"2016-08-07T23:20:40Z","body":"@user378230 This is exactly the direction I would like the project to go in. I'd like to discourage contributors from trying to add an endless amount of new attributes/options to support every conceivable use-case. Instead, a good use of filters and config objects like you've done here is in the spirit of this project, makes the code base more easily maintainable and configuration and use of the component much, much more sane!"}}
{"actor":{"display_login":"aaronroberson"}}