{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/93442972","pull_request_review_id":13970294,"id":93442972,"diff_hunk":"@@ -52,25 +63,60 @@ let\n         }\n       ];\n \n-    xenPatches = [ ./0001-libxl-Spice-image-compression-setting-support-for-up.patch\n-                   ./0002-libxl-Spice-streaming-video-setting-support-for-upst.patch\n-                   ./0003-Add-qxl-vga-interface-support-for-upstream-qem.patch\n-                   (fetchpatch {\n-                     url = \"https://bugzilla.redhat.com/attachment.cgi?id=1218547\";\n-                     name = \"CVE-2016-9385.patch\";\n-                     sha256 = \"0k9mykhrpm4rbjkhv067f6s05lqmgnldcyb3vi8cl0ndlyh66lvr\";\n-                   })\n-                   (fetchpatch {\n-                     url = \"https://bugzilla.redhat.com/attachment.cgi?id=1218536\";\n-                     name = \"CVE-2016-9377-CVE-2016-9378-part1.patch\";\n-                     sha256 = \"0z53nzrjvc745y26z1qc8jlg3blxp7brawvji1hx3s74n346ssl6\";\n-                   })\n-                   (fetchpatch {\n-                     url = \"https://bugzilla.redhat.com/attachment.cgi?id=1218537\";\n-                     name = \"CVE-2016-9377-CVE-2016-9378-part2.patch\";\n-                     sha256 = \"11cqvr5jn2s92wsshpilx9qnfczrd9hnyb5aim6qwmz3fq3hrrkz\";\n-                   })\n-                 ];\n+      # Note this lacks patches for:\n+      # XSA-201\n+      # XSA-199\n+      # XSA-197\n+      # they didn't apply, and there are plenty of other patches here\n+      # to get this deployed as-is.\n+      xenPatches = [ ./0001-libxl-Spice-image-compression-setting-support-for-up.patch","path":"pkgs/applications/virtualization/xen/4.5.nix","position":49,"original_position":49,"commit_id":"de7f1658bbc6ce61615decf9e1f54bea6b353e03","original_commit_id":"de7f1658bbc6ce61615decf9e1f54bea6b353e03","user":{"login":"grahamc","id":76716,"avatar_url":"https://avatars.githubusercontent.com/u/76716?v=3","gravatar_id":"","url":"https://api.github.com/users/grahamc","html_url":"https://github.com/grahamc","followers_url":"https://api.github.com/users/grahamc/followers","following_url":"https://api.github.com/users/grahamc/following{/other_user}","gists_url":"https://api.github.com/users/grahamc/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamc/subscriptions","organizations_url":"https://api.github.com/users/grahamc/orgs","repos_url":"https://api.github.com/users/grahamc/repos","events_url":"https://api.github.com/users/grahamc/events{/privacy}","received_events_url":"https://api.github.com/users/grahamc/received_events","type":"User","site_admin":false},"body":"@NeQuissimus I found surprises today :P I've been missing these for ages.","created_at":"2016-12-21T14:07:08Z","updated_at":"2016-12-21T14:07:08Z","html_url":"https://github.com/NixOS/nixpkgs/pull/21335#discussion_r93442972","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/21335","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/93442972"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/21335#discussion_r93442972"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/21335"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/21335","id":98938010,"html_url":"https://github.com/NixOS/nixpkgs/pull/21335","diff_url":"https://github.com/NixOS/nixpkgs/pull/21335.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/21335.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/21335","number":21335,"state":"open","locked":false,"title":"WIP: Roundup 14","user":{"login":"grahamc","id":76716,"avatar_url":"https://avatars.githubusercontent.com/u/76716?v=3","gravatar_id":"","url":"https://api.github.com/users/grahamc","html_url":"https://github.com/grahamc","followers_url":"https://api.github.com/users/grahamc/followers","following_url":"https://api.github.com/users/grahamc/following{/other_user}","gists_url":"https://api.github.com/users/grahamc/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamc/subscriptions","organizations_url":"https://api.github.com/users/grahamc/orgs","repos_url":"https://api.github.com/users/grahamc/repos","events_url":"https://api.github.com/users/grahamc/events{/privacy}","received_events_url":"https://api.github.com/users/grahamc/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nhttps://github.com/NixOS/nixpkgs/issues/21289\r\n\r\n###### Things done\r\n\r\n- [ ] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] macOS\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2016-12-21T14:03:35Z","updated_at":"2016-12-21T14:07:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9793388fd9ff6bbef6a497db799c3c1acdfc669","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/21335/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/21335/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/21335/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/de7f1658bbc6ce61615decf9e1f54bea6b353e03","head":{"label":"grahamc:roundup-14","ref":"roundup-14","sha":"de7f1658bbc6ce61615decf9e1f54bea6b353e03","user":{"login":"grahamc","id":76716,"avatar_url":"https://avatars.githubusercontent.com/u/76716?v=3","gravatar_id":"","url":"https://api.github.com/users/grahamc","html_url":"https://github.com/grahamc","followers_url":"https://api.github.com/users/grahamc/followers","following_url":"https://api.github.com/users/grahamc/following{/other_user}","gists_url":"https://api.github.com/users/grahamc/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamc/subscriptions","organizations_url":"https://api.github.com/users/grahamc/orgs","repos_url":"https://api.github.com/users/grahamc/repos","events_url":"https://api.github.com/users/grahamc/events{/privacy}","received_events_url":"https://api.github.com/users/grahamc/received_events","type":"User","site_admin":false},"repo":{"id":52226505,"name":"nixpkgs","full_name":"grahamc/nixpkgs","owner":{"login":"grahamc","id":76716,"avatar_url":"https://avatars.githubusercontent.com/u/76716?v=3","gravatar_id":"","url":"https://api.github.com/users/grahamc","html_url":"https://github.com/grahamc","followers_url":"https://api.github.com/users/grahamc/followers","following_url":"https://api.github.com/users/grahamc/following{/other_user}","gists_url":"https://api.github.com/users/grahamc/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamc/subscriptions","organizations_url":"https://api.github.com/users/grahamc/orgs","repos_url":"https://api.github.com/users/grahamc/repos","events_url":"https://api.github.com/users/grahamc/events{/privacy}","received_events_url":"https://api.github.com/users/grahamc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grahamc/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/grahamc/nixpkgs","forks_url":"https://api.github.com/repos/grahamc/nixpkgs/forks","keys_url":"https://api.github.com/repos/grahamc/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grahamc/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grahamc/nixpkgs/teams","hooks_url":"https://api.github.com/repos/grahamc/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/grahamc/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/grahamc/nixpkgs/events","assignees_url":"https://api.github.com/repos/grahamc/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/grahamc/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/grahamc/nixpkgs/tags","blobs_url":"https://api.github.com/repos/grahamc/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grahamc/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grahamc/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/grahamc/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grahamc/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/grahamc/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/grahamc/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/grahamc/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/grahamc/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/grahamc/nixpkgs/subscription","commits_url":"https://api.github.com/repos/grahamc/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/grahamc/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/grahamc/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/grahamc/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/grahamc/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/grahamc/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grahamc/nixpkgs/merges","archive_url":"https://api.github.com/repos/grahamc/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grahamc/nixpkgs/downloads","issues_url":"https://api.github.com/repos/grahamc/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/grahamc/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/grahamc/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/grahamc/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grahamc/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/grahamc/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/grahamc/nixpkgs/deployments","created_at":"2016-02-21T20:31:54Z","updated_at":"2016-07-22T23:42:01Z","pushed_at":"2016-12-21T14:02:13Z","git_url":"git://github.com/grahamc/nixpkgs.git","ssh_url":"git@github.com:grahamc/nixpkgs.git","clone_url":"https://github.com/grahamc/nixpkgs.git","svn_url":"https://github.com/grahamc/nixpkgs","homepage":null,"size":377423,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"4a795afdbce7f20bdc1d902637439a04a66ffdad","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2016-12-21T08:58:16Z","pushed_at":"2016-12-21T14:03:36Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":396042,"stargazers_count":1431,"watchers_count":1431,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1763,"mirror_url":null,"open_issues_count":1684,"forks":1763,"open_issues":1684,"watchers":1431,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/21335"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/21335"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/21335"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/21335/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/21335/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/21335/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/de7f1658bbc6ce61615decf9e1f54bea6b353e03"}}}}
{"actor":{"display_login":"grahamc"}}