{"action":"created","comment":{"url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/pulls/comments/55025932","id":55025932,"diff_hunk":"@@ -51,24 +55,30 @@\n (defn a-click\n   \"Element-agnostic. Runs either (taxi/click) or (click-anything).\"\n   [& el-spec]\n-  (let [el (apply $ el-spec)]\n-    (case (.getTagName (:webelement el))\n-      (\"a\" \"button\") (retry #(click el))\n-      (retry #(click-non-clickable el)))))\n+  (retrying\n+   (let [el (apply $ el-spec)]\n+     (case (.getTagName (:webelement el))\n+       (\"a\" \"button\") (click el)\n+       (click-non-clickable el)))))\n \n (defn a-text\n   \"For non-form elements such as <div> works like (taxi/text).\n   For <input> works like (taxi/value).\"\n   [el]\n-  (case (.getTagName (:webelement el))\n-    (\"input\") (retry #(value el))\n-    (retry #(text el))))\n+  ;; TODO: this one is sometimes used as a checker in smart-wait/wait-until\n+  ;; and sometimes as a standalone operation. The retrying here is not needed\n+  ;; in case of smart-wait\n+  (retrying","path":"src/io/aviso/taxi_toolkit/ui.clj","position":35,"original_position":35,"commit_id":"b9f93c88e6963e4d84385b7ae4df9cd4036c154f","original_commit_id":"b9f93c88e6963e4d84385b7ae4df9cd4036c154f","user":{"login":"BartAdv","id":722564,"avatar_url":"https://avatars.githubusercontent.com/u/722564?v=3","gravatar_id":"","url":"https://api.github.com/users/BartAdv","html_url":"https://github.com/BartAdv","followers_url":"https://api.github.com/users/BartAdv/followers","following_url":"https://api.github.com/users/BartAdv/following{/other_user}","gists_url":"https://api.github.com/users/BartAdv/gists{/gist_id}","starred_url":"https://api.github.com/users/BartAdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BartAdv/subscriptions","organizations_url":"https://api.github.com/users/BartAdv/orgs","repos_url":"https://api.github.com/users/BartAdv/repos","events_url":"https://api.github.com/users/BartAdv/events{/privacy}","received_events_url":"https://api.github.com/users/BartAdv/received_events","type":"User","site_admin":false},"body":"Yup, every call that uses it does something like `(tt/a-text (tt/$ ....))` so I guess we could change it for spec. It's just that would be breaking change:)","created_at":"2016-03-04T12:52:56Z","updated_at":"2016-03-04T12:52:56Z","html_url":"https://github.com/AvisoNovate/taxi-toolkit/pull/30#discussion_r55025932","pull_request_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/pulls/comments/55025932"},"html":{"href":"https://github.com/AvisoNovate/taxi-toolkit/pull/30#discussion_r55025932"},"pull_request":{"href":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/pulls/30","id":61402107,"html_url":"https://github.com/AvisoNovate/taxi-toolkit/pull/30","diff_url":"https://github.com/AvisoNovate/taxi-toolkit/pull/30.diff","patch_url":"https://github.com/AvisoNovate/taxi-toolkit/pull/30.patch","issue_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/issues/30","number":30,"state":"open","locked":false,"title":"Retrying for actions + fixes","user":{"login":"BartAdv","id":722564,"avatar_url":"https://avatars.githubusercontent.com/u/722564?v=3","gravatar_id":"","url":"https://api.github.com/users/BartAdv","html_url":"https://github.com/BartAdv","followers_url":"https://api.github.com/users/BartAdv/followers","following_url":"https://api.github.com/users/BartAdv/following{/other_user}","gists_url":"https://api.github.com/users/BartAdv/gists{/gist_id}","starred_url":"https://api.github.com/users/BartAdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BartAdv/subscriptions","organizations_url":"https://api.github.com/users/BartAdv/orgs","repos_url":"https://api.github.com/users/BartAdv/repos","events_url":"https://api.github.com/users/BartAdv/events{/privacy}","received_events_url":"https://api.github.com/users/BartAdv/received_events","type":"User","site_admin":false},"body":"* Uses same mechanics as retrying assertions\r\n* Favours retrying whole action than just parts of it, as it may\r\n  protects from StaleElementReference exceptions as well\r\n* Fix for wait-and-click that waits for element to be enabled\r\n* Unified retrying mechanics for smart-wait and other retries\r\n* Fix assert-ui to use thread-local binding and timeout per assert-ui","created_at":"2016-03-02T13:48:55Z","updated_at":"2016-03-04T12:52:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b52c4a12effe9e665cac69379d40e2900e3dcaac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/pulls/30/commits","review_comments_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/pulls/30/comments","review_comment_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/issues/30/comments","statuses_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/statuses/b9f93c88e6963e4d84385b7ae4df9cd4036c154f","head":{"label":"BartAdv:retrying","ref":"retrying","sha":"b9f93c88e6963e4d84385b7ae4df9cd4036c154f","user":{"login":"BartAdv","id":722564,"avatar_url":"https://avatars.githubusercontent.com/u/722564?v=3","gravatar_id":"","url":"https://api.github.com/users/BartAdv","html_url":"https://github.com/BartAdv","followers_url":"https://api.github.com/users/BartAdv/followers","following_url":"https://api.github.com/users/BartAdv/following{/other_user}","gists_url":"https://api.github.com/users/BartAdv/gists{/gist_id}","starred_url":"https://api.github.com/users/BartAdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BartAdv/subscriptions","organizations_url":"https://api.github.com/users/BartAdv/orgs","repos_url":"https://api.github.com/users/BartAdv/repos","events_url":"https://api.github.com/users/BartAdv/events{/privacy}","received_events_url":"https://api.github.com/users/BartAdv/received_events","type":"User","site_admin":false},"repo":{"id":49053795,"name":"taxi-toolkit","full_name":"BartAdv/taxi-toolkit","owner":{"login":"BartAdv","id":722564,"avatar_url":"https://avatars.githubusercontent.com/u/722564?v=3","gravatar_id":"","url":"https://api.github.com/users/BartAdv","html_url":"https://github.com/BartAdv","followers_url":"https://api.github.com/users/BartAdv/followers","following_url":"https://api.github.com/users/BartAdv/following{/other_user}","gists_url":"https://api.github.com/users/BartAdv/gists{/gist_id}","starred_url":"https://api.github.com/users/BartAdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BartAdv/subscriptions","organizations_url":"https://api.github.com/users/BartAdv/orgs","repos_url":"https://api.github.com/users/BartAdv/repos","events_url":"https://api.github.com/users/BartAdv/events{/privacy}","received_events_url":"https://api.github.com/users/BartAdv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BartAdv/taxi-toolkit","description":"A Clojure library designed to help with writing integration tests using clj-webdriver.","fork":true,"url":"https://api.github.com/repos/BartAdv/taxi-toolkit","forks_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/forks","keys_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/teams","hooks_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/hooks","issue_events_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/events","assignees_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/tags","blobs_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/languages","stargazers_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/stargazers","contributors_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/contributors","subscribers_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/subscribers","subscription_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/subscription","commits_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/merges","archive_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/downloads","issues_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/BartAdv/taxi-toolkit/deployments","created_at":"2016-01-05T08:51:30Z","updated_at":"2016-01-11T10:02:58Z","pushed_at":"2016-03-02T13:46:08Z","git_url":"git://github.com/BartAdv/taxi-toolkit.git","ssh_url":"git@github.com:BartAdv/taxi-toolkit.git","clone_url":"https://github.com/BartAdv/taxi-toolkit.git","svn_url":"https://github.com/BartAdv/taxi-toolkit","homepage":null,"size":88,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AvisoNovate:master","ref":"master","sha":"8e995c8c308568d2241e06f0743b434a71eb520a","user":{"login":"AvisoNovate","id":5172205,"avatar_url":"https://avatars.githubusercontent.com/u/5172205?v=3","gravatar_id":"","url":"https://api.github.com/users/AvisoNovate","html_url":"https://github.com/AvisoNovate","followers_url":"https://api.github.com/users/AvisoNovate/followers","following_url":"https://api.github.com/users/AvisoNovate/following{/other_user}","gists_url":"https://api.github.com/users/AvisoNovate/gists{/gist_id}","starred_url":"https://api.github.com/users/AvisoNovate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AvisoNovate/subscriptions","organizations_url":"https://api.github.com/users/AvisoNovate/orgs","repos_url":"https://api.github.com/users/AvisoNovate/repos","events_url":"https://api.github.com/users/AvisoNovate/events{/privacy}","received_events_url":"https://api.github.com/users/AvisoNovate/received_events","type":"Organization","site_admin":false},"repo":{"id":33246851,"name":"taxi-toolkit","full_name":"AvisoNovate/taxi-toolkit","owner":{"login":"AvisoNovate","id":5172205,"avatar_url":"https://avatars.githubusercontent.com/u/5172205?v=3","gravatar_id":"","url":"https://api.github.com/users/AvisoNovate","html_url":"https://github.com/AvisoNovate","followers_url":"https://api.github.com/users/AvisoNovate/followers","following_url":"https://api.github.com/users/AvisoNovate/following{/other_user}","gists_url":"https://api.github.com/users/AvisoNovate/gists{/gist_id}","starred_url":"https://api.github.com/users/AvisoNovate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AvisoNovate/subscriptions","organizations_url":"https://api.github.com/users/AvisoNovate/orgs","repos_url":"https://api.github.com/users/AvisoNovate/repos","events_url":"https://api.github.com/users/AvisoNovate/events{/privacy}","received_events_url":"https://api.github.com/users/AvisoNovate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AvisoNovate/taxi-toolkit","description":"A Clojure library designed to help with writing integration tests using clj-webdriver.","fork":false,"url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit","forks_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/forks","keys_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/teams","hooks_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/hooks","issue_events_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/events","assignees_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/tags","blobs_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/languages","stargazers_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/stargazers","contributors_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/contributors","subscribers_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/subscribers","subscription_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/subscription","commits_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/merges","archive_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/downloads","issues_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/labels{/name}","releases_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/deployments","created_at":"2015-04-01T12:43:40Z","updated_at":"2016-02-27T03:56:09Z","pushed_at":"2016-03-02T13:48:55Z","git_url":"git://github.com/AvisoNovate/taxi-toolkit.git","ssh_url":"git@github.com:AvisoNovate/taxi-toolkit.git","clone_url":"https://github.com/AvisoNovate/taxi-toolkit.git","svn_url":"https://github.com/AvisoNovate/taxi-toolkit","homepage":null,"size":90,"stargazers_count":10,"watchers_count":10,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/pulls/30"},"html":{"href":"https://github.com/AvisoNovate/taxi-toolkit/pull/30"},"issue":{"href":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/issues/30"},"comments":{"href":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/AvisoNovate/taxi-toolkit/statuses/b9f93c88e6963e4d84385b7ae4df9cd4036c154f"}}}}