{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/36373","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/36373/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/36373/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/36373/events","html_url":"https://github.com/saltstack/salt/issues/36373","id":177475824,"number":36373,"title":"Salt-API does not validate input properly","user":{"login":"frioux","id":8163,"avatar_url":"https://avatars.githubusercontent.com/u/8163?v=3","gravatar_id":"","url":"https://api.github.com/users/frioux","html_url":"https://github.com/frioux","followers_url":"https://api.github.com/users/frioux/followers","following_url":"https://api.github.com/users/frioux/following{/other_user}","gists_url":"https://api.github.com/users/frioux/gists{/gist_id}","starred_url":"https://api.github.com/users/frioux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frioux/subscriptions","organizations_url":"https://api.github.com/users/frioux/orgs","repos_url":"https://api.github.com/users/frioux/repos","events_url":"https://api.github.com/users/frioux/events{/privacy}","received_events_url":"https://api.github.com/users/frioux/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/saltstack/salt/labels/Bug","name":"Bug","color":"e11d21"},{"url":"https://api.github.com/repos/saltstack/salt/labels/Medium%20Severity","name":"Medium Severity","color":"fad8c7"},{"url":"https://api.github.com/repos/saltstack/salt/labels/P3","name":"P3","color":"0a3d77"},{"url":"https://api.github.com/repos/saltstack/salt/labels/RIoT","name":"RIoT","color":"fef2c0"},{"url":"https://api.github.com/repos/saltstack/salt/labels/Salt-API","name":"Salt-API","color":"006b75"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/saltstack/salt/milestones/13","html_url":"https://github.com/saltstack/salt/milestones/Approved","labels_url":"https://api.github.com/repos/saltstack/salt/milestones/13/labels","id":9265,"number":13,"title":"Approved","description":"All issues that are ready to be worked on, both bugs and features.","creator":{"login":"thatch45","id":507599,"avatar_url":"https://avatars.githubusercontent.com/u/507599?v=3","gravatar_id":"","url":"https://api.github.com/users/thatch45","html_url":"https://github.com/thatch45","followers_url":"https://api.github.com/users/thatch45/followers","following_url":"https://api.github.com/users/thatch45/following{/other_user}","gists_url":"https://api.github.com/users/thatch45/gists{/gist_id}","starred_url":"https://api.github.com/users/thatch45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thatch45/subscriptions","organizations_url":"https://api.github.com/users/thatch45/orgs","repos_url":"https://api.github.com/users/thatch45/repos","events_url":"https://api.github.com/users/thatch45/events{/privacy}","received_events_url":"https://api.github.com/users/thatch45/received_events","type":"User","site_admin":false},"open_issues":3189,"closed_issues":4002,"state":"open","created_at":"2011-05-14T04:00:56Z","updated_at":"2016-09-19T21:51:59Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-09-16T17:13:33Z","updated_at":"2016-09-19T22:56:21Z","closed_at":null,"body":"### Description of Issue/Question\r\n\r\nIf you try to hit the API endpoint with invalid JSON, you get a 400 error *but* if the json is, for example `true` you get a 500 error.\r\n\r\n### Setup\r\n\r\nn/a\r\n\r\n### Steps to Reproduce Issue\r\n\r\n`echo true | curl -k https://localhost:8080/hook/foo -XPOST -H 'Content-Type: application/json' -d @-`\r\n\r\n### Versions Report\r\n\r\n```\r\nSalt Version:\r\n           Salt: 2016.3.3\r\n \r\nDependency Versions:\r\n           cffi: Not Installed\r\n       cherrypy: 3.2.2\r\n       dateutil: 2.5.3\r\n          gitdb: 0.5.4\r\n      gitpython: 0.3.2 RC1\r\n          ioflo: Not Installed\r\n         Jinja2: 2.7.2\r\n        libgit2: Not Installed\r\n        libnacl: 1.4.3\r\n       M2Crypto: 0.21.1\r\n           Mako: 0.9.1\r\n   msgpack-pure: Not Installed\r\n msgpack-python: 0.4.6\r\n   mysql-python: 1.2.5\r\n      pycparser: Not Installed\r\n       pycrypto: 2.6.1\r\n         pygit2: Not Installed\r\n         Python: 2.7.6 (default, Jun 22 2015, 17:58:13)\r\n   python-gnupg: Not Installed\r\n         PyYAML: 3.11\r\n          PyZMQ: 14.0.1\r\n           RAET: Not Installed\r\n          smmap: 0.8.2\r\n        timelib: Not Installed\r\n        Tornado: 4.2.1\r\n            ZMQ: 4.0.5\r\n \r\nSystem Versions:\r\n           dist: Ubuntu 14.04 trusty\r\n        machine: x86_64\r\n        release: 3.13.0-87-generic\r\n         system: Linux\r\n        version: Ubuntu 14.04 trusty\r\n```"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/248152937","html_url":"https://github.com/saltstack/salt/issues/36373#issuecomment-248152937","issue_url":"https://api.github.com/repos/saltstack/salt/issues/36373","id":248152937,"user":{"login":"whiteinge","id":91293,"avatar_url":"https://avatars.githubusercontent.com/u/91293?v=3","gravatar_id":"","url":"https://api.github.com/users/whiteinge","html_url":"https://github.com/whiteinge","followers_url":"https://api.github.com/users/whiteinge/followers","following_url":"https://api.github.com/users/whiteinge/following{/other_user}","gists_url":"https://api.github.com/users/whiteinge/gists{/gist_id}","starred_url":"https://api.github.com/users/whiteinge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whiteinge/subscriptions","organizations_url":"https://api.github.com/users/whiteinge/orgs","repos_url":"https://api.github.com/users/whiteinge/repos","events_url":"https://api.github.com/users/whiteinge/events{/privacy}","received_events_url":"https://api.github.com/users/whiteinge/received_events","type":"User","site_admin":false},"created_at":"2016-09-19T22:56:21Z","updated_at":"2016-09-19T22:56:21Z","body":"Thanks for the report @frioux. PR above should fix it. Note, if you want to send any data along with the event you are creating, it must be sent as a dictionary."}}
{"actor":{"display_login":"whiteinge"}}