{"action":"created","issue":{"url":"https://api.github.com/repos/coreos/rkt/issues/2964","repository_url":"https://api.github.com/repos/coreos/rkt","labels_url":"https://api.github.com/repos/coreos/rkt/issues/2964/labels{/name}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/2964/comments","events_url":"https://api.github.com/repos/coreos/rkt/issues/2964/events","html_url":"https://github.com/coreos/rkt/pull/2964","id":166983998,"number":2964,"title":"proposal: Fetchers refactor","user":{"login":"sgotti","id":1690273,"avatar_url":"https://avatars.githubusercontent.com/u/1690273?v=3","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-07-22T07:11:34Z","updated_at":"2016-07-22T22:25:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/2964","html_url":"https://github.com/coreos/rkt/pull/2964","diff_url":"https://github.com/coreos/rkt/pull/2964.diff","patch_url":"https://github.com/coreos/rkt/pull/2964.patch"},"body":"This proposal, starts from the distribution concept in #2953, to provide a\r\nfetchers refactors to adapt to the above concept.\r\n\r\nAdditionally it also provides a complete workflow and ideas for\r\ntransport level caching to fit different needs:\r\n\r\n* Distribution handlers\r\n* Transport plugin handler\r\n* Transport plugins\r\n* Transport level caching\r\n* Complete separation between image store and transport level caching\r\n\r\n@dgonyeo I opened this trying to define my view starting will all the various requirements that came to my mind and trying find a common denominator. This is obviously my view and I'd like to hear your thoughts on it and see how it'll fit with your proposed \"fetcher\" plugins in #2830.\r\n"},"comment":{"url":"https://api.github.com/repos/coreos/rkt/issues/comments/234671803","html_url":"https://github.com/coreos/rkt/pull/2964#issuecomment-234671803","issue_url":"https://api.github.com/repos/coreos/rkt/issues/2964","id":234671803,"user":{"login":"dgonyeo","id":2439413,"avatar_url":"https://avatars.githubusercontent.com/u/2439413?v=3","gravatar_id":"","url":"https://api.github.com/users/dgonyeo","html_url":"https://github.com/dgonyeo","followers_url":"https://api.github.com/users/dgonyeo/followers","following_url":"https://api.github.com/users/dgonyeo/following{/other_user}","gists_url":"https://api.github.com/users/dgonyeo/gists{/gist_id}","starred_url":"https://api.github.com/users/dgonyeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgonyeo/subscriptions","organizations_url":"https://api.github.com/users/dgonyeo/orgs","repos_url":"https://api.github.com/users/dgonyeo/repos","events_url":"https://api.github.com/users/dgonyeo/events{/privacy}","received_events_url":"https://api.github.com/users/dgonyeo/received_events","type":"User","site_admin":false},"created_at":"2016-07-22T22:25:08Z","updated_at":"2016-07-22T22:25:08Z","body":"Aaaaand nevermind that question too. Now after reading more I see that the docker/OCI distribution may call them directly.\r\n\r\nAt first my opinion was that distributions should always call the transport handler directly, as otherwise things seemed a little murkier to me (for AppC, which distribution would do the image import?) but after dwelling on it a bit I think the way you outlined it here is best. After all the AppC distribution is the exact same as the archive distribution, just with 1-2 additional steps it needs to do first (perform discovery, maybe fetch/trust public keys).\r\n\r\nI'd be happy to start refactoring my plugins PR to align with this, once the others here have a little more time for feedback on this."}}
{"actor":{"display_login":"dgonyeo"}}