{"action":"created","comment":{"url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/comments/69509616","id":69509616,"diff_hunk":"@@ -210,6 +211,20 @@ def invalid_type_error(manifest)\n         def missing_keys_validation_error(missing_keys)\n           ValidationError.new('manifest_keys.missing', missing_keys: missing_keys.join(', '), count: missing_keys.length)\n         end\n+\n+        def framework_version_iframe_only(manifest)\n+          is_iframe_app = manifest['location'].any? do |host, locations|","path":"lib/zendesk_apps_support/validations/manifest.rb","position":14,"original_position":14,"commit_id":"c601679636e676209a2d98c122f42c8d27363780","original_commit_id":"c601679636e676209a2d98c122f42c8d27363780","user":{"login":"danielbreves","id":2517811,"avatar_url":"https://avatars.githubusercontent.com/u/2517811?v=3","gravatar_id":"","url":"https://api.github.com/users/danielbreves","html_url":"https://github.com/danielbreves","followers_url":"https://api.github.com/users/danielbreves/followers","following_url":"https://api.github.com/users/danielbreves/following{/other_user}","gists_url":"https://api.github.com/users/danielbreves/gists{/gist_id}","starred_url":"https://api.github.com/users/danielbreves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielbreves/subscriptions","organizations_url":"https://api.github.com/users/danielbreves/orgs","repos_url":"https://api.github.com/users/danielbreves/repos","events_url":"https://api.github.com/users/danielbreves/events{/privacy}","received_events_url":"https://api.github.com/users/danielbreves/received_events","type":"User","site_admin":false},"body":"Can we somehow reuse the code [here](https://github.com/zendesk/zendesk_apps_support/blob/master/lib/zendesk_apps_support/package.rb#L223-L232)?","created_at":"2016-07-05T05:39:04Z","updated_at":"2016-07-05T05:39:04Z","html_url":"https://github.com/zendesk/zendesk_apps_support/pull/123#discussion_r69509616","pull_request_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/123","_links":{"self":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/comments/69509616"},"html":{"href":"https://github.com/zendesk/zendesk_apps_support/pull/123#discussion_r69509616"},"pull_request":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/123","id":76218922,"html_url":"https://github.com/zendesk/zendesk_apps_support/pull/123","diff_url":"https://github.com/zendesk/zendesk_apps_support/pull/123.diff","patch_url":"https://github.com/zendesk/zendesk_apps_support/pull/123.patch","issue_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/123","number":123,"state":"open","locked":false,"title":"[AF-371] framworkVersion < 2.0 error","user":{"login":"ocke","id":5171412,"avatar_url":"https://avatars.githubusercontent.com/u/5171412?v=3","gravatar_id":"","url":"https://api.github.com/users/ocke","html_url":"https://github.com/ocke","followers_url":"https://api.github.com/users/ocke/followers","following_url":"https://api.github.com/users/ocke/following{/other_user}","gists_url":"https://api.github.com/users/ocke/gists{/gist_id}","starred_url":"https://api.github.com/users/ocke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocke/subscriptions","organizations_url":"https://api.github.com/users/ocke/orgs","repos_url":"https://api.github.com/users/ocke/repos","events_url":"https://api.github.com/users/ocke/events{/privacy}","received_events_url":"https://api.github.com/users/ocke/received_events","type":"User","site_admin":false},"body":":v:\r\n\r\n/cc @zendesk/vegemite\r\n\r\n### Description\r\nError when using iframe apps and framework version < 2.0\r\n\r\n### References\r\n* JIRA: \r\n\r\n### Risks","created_at":"2016-07-05T05:11:46Z","updated_at":"2016-07-05T05:39:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d97046a60fb49d3b36be3beae97a7ee1e9b4c815","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/123/commits","review_comments_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/123/comments","review_comment_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/123/comments","statuses_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/statuses/c601679636e676209a2d98c122f42c8d27363780","head":{"label":"zendesk:olaf/2.0_iframe","ref":"olaf/2.0_iframe","sha":"c601679636e676209a2d98c122f42c8d27363780","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":6622163,"name":"zendesk_apps_support","full_name":"zendesk/zendesk_apps_support","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/zendesk_apps_support","description":"","fork":false,"url":"https://api.github.com/repos/zendesk/zendesk_apps_support","forks_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/forks","keys_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/teams","hooks_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/hooks","issue_events_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/events","assignees_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/tags","blobs_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/languages","stargazers_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/stargazers","contributors_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/contributors","subscribers_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/subscribers","subscription_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/subscription","commits_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/merges","archive_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/downloads","issues_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/releases{/id}","deployments_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/deployments","created_at":"2012-11-09T23:29:16Z","updated_at":"2016-02-05T19:10:18Z","pushed_at":"2016-07-05T05:11:46Z","git_url":"git://github.com/zendesk/zendesk_apps_support.git","ssh_url":"git@github.com:zendesk/zendesk_apps_support.git","clone_url":"https://github.com/zendesk/zendesk_apps_support.git","svn_url":"https://github.com/zendesk/zendesk_apps_support","homepage":null,"size":664,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":3,"default_branch":"master"}},"base":{"label":"zendesk:master","ref":"master","sha":"c03663183719fc1a17525388c0cda7330af7168a","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":6622163,"name":"zendesk_apps_support","full_name":"zendesk/zendesk_apps_support","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/zendesk_apps_support","description":"","fork":false,"url":"https://api.github.com/repos/zendesk/zendesk_apps_support","forks_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/forks","keys_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/teams","hooks_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/hooks","issue_events_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/events","assignees_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/tags","blobs_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/languages","stargazers_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/stargazers","contributors_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/contributors","subscribers_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/subscribers","subscription_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/subscription","commits_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/merges","archive_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/downloads","issues_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/releases{/id}","deployments_url":"https://api.github.com/repos/zendesk/zendesk_apps_support/deployments","created_at":"2012-11-09T23:29:16Z","updated_at":"2016-02-05T19:10:18Z","pushed_at":"2016-07-05T05:11:46Z","git_url":"git://github.com/zendesk/zendesk_apps_support.git","ssh_url":"git@github.com:zendesk/zendesk_apps_support.git","clone_url":"https://github.com/zendesk/zendesk_apps_support.git","svn_url":"https://github.com/zendesk/zendesk_apps_support","homepage":null,"size":664,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/123"},"html":{"href":"https://github.com/zendesk/zendesk_apps_support/pull/123"},"issue":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/123"},"comments":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/zendesk/zendesk_apps_support/statuses/c601679636e676209a2d98c122f42c8d27363780"}}}}
{"actor":{"display_login":"danielbreves"}}