{"action":"created","issue":{"url":"https://api.github.com/repos/btraceio/btrace/issues/221","repository_url":"https://api.github.com/repos/btraceio/btrace","labels_url":"https://api.github.com/repos/btraceio/btrace/issues/221/labels{/name}","comments_url":"https://api.github.com/repos/btraceio/btrace/issues/221/comments","events_url":"https://api.github.com/repos/btraceio/btrace/issues/221/events","html_url":"https://github.com/btraceio/btrace/pull/221","id":151898595,"number":221,"title":"Fixing fileRollMaxRolls and fileRollMilliseconds","user":{"login":"joachimhs","id":453373,"avatar_url":"https://avatars.githubusercontent.com/u/453373?v=3","gravatar_id":"","url":"https://api.github.com/users/joachimhs","html_url":"https://github.com/joachimhs","followers_url":"https://api.github.com/users/joachimhs/followers","following_url":"https://api.github.com/users/joachimhs/following{/other_user}","gists_url":"https://api.github.com/users/joachimhs/gists{/gist_id}","starred_url":"https://api.github.com/users/joachimhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joachimhs/subscriptions","organizations_url":"https://api.github.com/users/joachimhs/orgs","repos_url":"https://api.github.com/users/joachimhs/repos","events_url":"https://api.github.com/users/joachimhs/events{/privacy}","received_events_url":"https://api.github.com/users/joachimhs/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/btraceio/btrace/labels/BTRACE","name":"BTRACE","color":"46e08b"},{"url":"https://api.github.com/repos/btraceio/btrace/labels/Core","name":"Core","color":"b62938"}],"state":"open","locked":false,"assignee":{"login":"joachimhs","id":453373,"avatar_url":"https://avatars.githubusercontent.com/u/453373?v=3","gravatar_id":"","url":"https://api.github.com/users/joachimhs","html_url":"https://github.com/joachimhs","followers_url":"https://api.github.com/users/joachimhs/followers","following_url":"https://api.github.com/users/joachimhs/following{/other_user}","gists_url":"https://api.github.com/users/joachimhs/gists{/gist_id}","starred_url":"https://api.github.com/users/joachimhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joachimhs/subscriptions","organizations_url":"https://api.github.com/users/joachimhs/orgs","repos_url":"https://api.github.com/users/joachimhs/repos","events_url":"https://api.github.com/users/joachimhs/events{/privacy}","received_events_url":"https://api.github.com/users/joachimhs/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/btraceio/btrace/milestones/21","html_url":"https://github.com/btraceio/btrace/milestones/1.3.7","labels_url":"https://api.github.com/repos/btraceio/btrace/milestones/21/labels","id":1740538,"number":21,"title":"1.3.7","description":"","creator":{"login":"jbachorik","id":738413,"avatar_url":"https://avatars.githubusercontent.com/u/738413?v=3","gravatar_id":"","url":"https://api.github.com/users/jbachorik","html_url":"https://github.com/jbachorik","followers_url":"https://api.github.com/users/jbachorik/followers","following_url":"https://api.github.com/users/jbachorik/following{/other_user}","gists_url":"https://api.github.com/users/jbachorik/gists{/gist_id}","starred_url":"https://api.github.com/users/jbachorik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbachorik/subscriptions","organizations_url":"https://api.github.com/users/jbachorik/orgs","repos_url":"https://api.github.com/users/jbachorik/repos","events_url":"https://api.github.com/users/jbachorik/events{/privacy}","received_events_url":"https://api.github.com/users/jbachorik/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2016-05-01T09:11:17Z","updated_at":"2016-05-01T09:50:04Z","due_on":"2016-05-14T22:00:00Z","closed_at":null},"comments":2,"created_at":"2016-04-29T15:39:49Z","updated_at":"2016-05-01T17:50:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/btraceio/btrace/pulls/221","html_url":"https://github.com/btraceio/btrace/pull/221","diff_url":"https://github.com/btraceio/btrace/pull/221.diff","patch_url":"https://github.com/btraceio/btrace/pull/221.patch"},"body":"- Fixing fileRollMaxRolls, reading in from command-line args\r\n- Fixing fileRollMilliseconds, adding to settings and using from settings (instead of GLOBAL)\r\n- Fixing naming of the file-rolled filenames to make them easier to read in systematically\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/btraceio/btrace/221)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/btraceio/btrace/issues/comments/216058520","html_url":"https://github.com/btraceio/btrace/pull/221#issuecomment-216058520","issue_url":"https://api.github.com/repos/btraceio/btrace/issues/221","id":216058520,"user":{"login":"jbachorik","id":738413,"avatar_url":"https://avatars.githubusercontent.com/u/738413?v=3","gravatar_id":"","url":"https://api.github.com/users/jbachorik","html_url":"https://github.com/jbachorik","followers_url":"https://api.github.com/users/jbachorik/followers","following_url":"https://api.github.com/users/jbachorik/following{/other_user}","gists_url":"https://api.github.com/users/jbachorik/gists{/gist_id}","starred_url":"https://api.github.com/users/jbachorik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbachorik/subscriptions","organizations_url":"https://api.github.com/users/jbachorik/orgs","repos_url":"https://api.github.com/users/jbachorik/repos","events_url":"https://api.github.com/users/jbachorik/events{/privacy}","received_events_url":"https://api.github.com/users/jbachorik/received_events","type":"User","site_admin":false},"created_at":"2016-05-01T17:50:49Z","updated_at":"2016-05-01T17:50:49Z","body":"\n\n\n\nReview status: 1 of 3 files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[src/share/classes/com/sun/btrace/agent/TraceOutputWriter.java, line 152 \\[r1\\]](https://reviewable.io:443/reviews/btraceio/btrace/221#-KGfbHRbMp76Os9dp-xp-r1-152:-KGhRE7Rl9h33Y_Tf-wa:-94709915) ([raw file](https://github.com/btraceio/btrace/blob/ba69b3ea9adcce9413a6cea59ecff5fece3eb040/src/share/classes/com/sun/btrace/agent/TraceOutputWriter.java#L152)):*\nIt has probably something to do with the otuput file name templates. \n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/btraceio/btrace/221)*\n<!-- Sent from Reviewable.io -->\n"}}