{"action":"closed","number":4084,"pull_request":{"url":"https://api.github.com/repos/mozilla/bedrock/pulls/4084","id":67522022,"html_url":"https://github.com/mozilla/bedrock/pull/4084","diff_url":"https://github.com/mozilla/bedrock/pull/4084.diff","patch_url":"https://github.com/mozilla/bedrock/pull/4084.patch","issue_url":"https://api.github.com/repos/mozilla/bedrock/issues/4084","number":4084,"state":"closed","locked":false,"title":"[fix bug 1261017] Issues with Mozilla.Modal in Firefox 47 at small viewports","user":{"login":"alexgibson","id":400117,"avatar_url":"https://avatars.githubusercontent.com/u/400117?v=3","gravatar_id":"","url":"https://api.github.com/users/alexgibson","html_url":"https://github.com/alexgibson","followers_url":"https://api.github.com/users/alexgibson/followers","following_url":"https://api.github.com/users/alexgibson/following{/other_user}","gists_url":"https://api.github.com/users/alexgibson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexgibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexgibson/subscriptions","organizations_url":"https://api.github.com/users/alexgibson/orgs","repos_url":"https://api.github.com/users/alexgibson/repos","events_url":"https://api.github.com/users/alexgibson/events{/privacy}","received_events_url":"https://api.github.com/users/alexgibson/received_events","type":"User","site_admin":false},"body":"## Description\r\n- Removes the `noscroll` option that is currently used on smaller viewports from `Mozilla.Modal`, as it causes issues in newer versions of Firefox (see bug link below for STR).\r\n\r\n## Bugzilla\r\nhttps://bugzilla.mozilla.org/show_bug.cgi?id=1261017\r\n\r\n## Testing\r\nIf memory serves me correctly, I think the `noscroll` option was added as a hack for early versions of Firefox OS due to some viewport bug. But honestly, I'm not quite sure. I think most browsers we care about today should be up to handling `position: fixed;`.\r\n\r\n## Checklist\r\n- [ ] Requires l10n changes.\r\n- [ ] Related functional & integration tests passing.","created_at":"2016-04-22T14:39:28Z","updated_at":"2016-04-25T09:16:35Z","closed_at":"2016-04-25T09:16:34Z","merged_at":null,"merge_commit_sha":"178fbb7fc30f376837acbcc01fa40b2e861d6ace","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/bedrock/pulls/4084/commits","review_comments_url":"https://api.github.com/repos/mozilla/bedrock/pulls/4084/comments","review_comment_url":"https://api.github.com/repos/mozilla/bedrock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/bedrock/issues/4084/comments","statuses_url":"https://api.github.com/repos/mozilla/bedrock/statuses/b40a2e2dc58637865bf1697c779198a00270972d","head":{"label":"alexgibson:bug-1261017-mozilla-modal-issues-ff-47","ref":"bug-1261017-mozilla-modal-issues-ff-47","sha":"b40a2e2dc58637865bf1697c779198a00270972d","user":{"login":"alexgibson","id":400117,"avatar_url":"https://avatars.githubusercontent.com/u/400117?v=3","gravatar_id":"","url":"https://api.github.com/users/alexgibson","html_url":"https://github.com/alexgibson","followers_url":"https://api.github.com/users/alexgibson/followers","following_url":"https://api.github.com/users/alexgibson/following{/other_user}","gists_url":"https://api.github.com/users/alexgibson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexgibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexgibson/subscriptions","organizations_url":"https://api.github.com/users/alexgibson/orgs","repos_url":"https://api.github.com/users/alexgibson/repos","events_url":"https://api.github.com/users/alexgibson/events{/privacy}","received_events_url":"https://api.github.com/users/alexgibson/received_events","type":"User","site_admin":false},"repo":{"id":9545146,"name":"bedrock","full_name":"alexgibson/bedrock","owner":{"login":"alexgibson","id":400117,"avatar_url":"https://avatars.githubusercontent.com/u/400117?v=3","gravatar_id":"","url":"https://api.github.com/users/alexgibson","html_url":"https://github.com/alexgibson","followers_url":"https://api.github.com/users/alexgibson/followers","following_url":"https://api.github.com/users/alexgibson/following{/other_user}","gists_url":"https://api.github.com/users/alexgibson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexgibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexgibson/subscriptions","organizations_url":"https://api.github.com/users/alexgibson/orgs","repos_url":"https://api.github.com/users/alexgibson/repos","events_url":"https://api.github.com/users/alexgibson/events{/privacy}","received_events_url":"https://api.github.com/users/alexgibson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexgibson/bedrock","description":"Making mozilla.org awesome, one pebble at a time","fork":true,"url":"https://api.github.com/repos/alexgibson/bedrock","forks_url":"https://api.github.com/repos/alexgibson/bedrock/forks","keys_url":"https://api.github.com/repos/alexgibson/bedrock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexgibson/bedrock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexgibson/bedrock/teams","hooks_url":"https://api.github.com/repos/alexgibson/bedrock/hooks","issue_events_url":"https://api.github.com/repos/alexgibson/bedrock/issues/events{/number}","events_url":"https://api.github.com/repos/alexgibson/bedrock/events","assignees_url":"https://api.github.com/repos/alexgibson/bedrock/assignees{/user}","branches_url":"https://api.github.com/repos/alexgibson/bedrock/branches{/branch}","tags_url":"https://api.github.com/repos/alexgibson/bedrock/tags","blobs_url":"https://api.github.com/repos/alexgibson/bedrock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexgibson/bedrock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexgibson/bedrock/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexgibson/bedrock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexgibson/bedrock/statuses/{sha}","languages_url":"https://api.github.com/repos/alexgibson/bedrock/languages","stargazers_url":"https://api.github.com/repos/alexgibson/bedrock/stargazers","contributors_url":"https://api.github.com/repos/alexgibson/bedrock/contributors","subscribers_url":"https://api.github.com/repos/alexgibson/bedrock/subscribers","subscription_url":"https://api.github.com/repos/alexgibson/bedrock/subscription","commits_url":"https://api.github.com/repos/alexgibson/bedrock/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexgibson/bedrock/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexgibson/bedrock/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexgibson/bedrock/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexgibson/bedrock/contents/{+path}","compare_url":"https://api.github.com/repos/alexgibson/bedrock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexgibson/bedrock/merges","archive_url":"https://api.github.com/repos/alexgibson/bedrock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexgibson/bedrock/downloads","issues_url":"https://api.github.com/repos/alexgibson/bedrock/issues{/number}","pulls_url":"https://api.github.com/repos/alexgibson/bedrock/pulls{/number}","milestones_url":"https://api.github.com/repos/alexgibson/bedrock/milestones{/number}","notifications_url":"https://api.github.com/repos/alexgibson/bedrock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexgibson/bedrock/labels{/name}","releases_url":"https://api.github.com/repos/alexgibson/bedrock/releases{/id}","deployments_url":"https://api.github.com/repos/alexgibson/bedrock/deployments","created_at":"2013-04-19T12:36:05Z","updated_at":"2015-05-08T13:28:28Z","pushed_at":"2016-04-25T09:14:25Z","git_url":"git://github.com/alexgibson/bedrock.git","ssh_url":"git@github.com:alexgibson/bedrock.git","clone_url":"https://github.com/alexgibson/bedrock.git","svn_url":"https://github.com/alexgibson/bedrock","homepage":"http://mozilla.org","size":360384,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"d90d2e2ef2ee36ad0ed514f63005a7874f4319ff","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1616665,"name":"bedrock","full_name":"mozilla/bedrock","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/bedrock","description":"Making mozilla.org awesome, one pebble at a time","fork":false,"url":"https://api.github.com/repos/mozilla/bedrock","forks_url":"https://api.github.com/repos/mozilla/bedrock/forks","keys_url":"https://api.github.com/repos/mozilla/bedrock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/bedrock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/bedrock/teams","hooks_url":"https://api.github.com/repos/mozilla/bedrock/hooks","issue_events_url":"https://api.github.com/repos/mozilla/bedrock/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/bedrock/events","assignees_url":"https://api.github.com/repos/mozilla/bedrock/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/bedrock/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/bedrock/tags","blobs_url":"https://api.github.com/repos/mozilla/bedrock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/bedrock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/bedrock/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/bedrock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/bedrock/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/bedrock/languages","stargazers_url":"https://api.github.com/repos/mozilla/bedrock/stargazers","contributors_url":"https://api.github.com/repos/mozilla/bedrock/contributors","subscribers_url":"https://api.github.com/repos/mozilla/bedrock/subscribers","subscription_url":"https://api.github.com/repos/mozilla/bedrock/subscription","commits_url":"https://api.github.com/repos/mozilla/bedrock/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/bedrock/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/bedrock/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/bedrock/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/bedrock/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/bedrock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/bedrock/merges","archive_url":"https://api.github.com/repos/mozilla/bedrock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/bedrock/downloads","issues_url":"https://api.github.com/repos/mozilla/bedrock/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/bedrock/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/bedrock/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/bedrock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/bedrock/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/bedrock/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/bedrock/deployments","created_at":"2011-04-14T22:57:57Z","updated_at":"2016-04-22T16:14:15Z","pushed_at":"2016-04-23T01:30:21Z","git_url":"git://github.com/mozilla/bedrock.git","ssh_url":"git@github.com:mozilla/bedrock.git","clone_url":"https://github.com/mozilla/bedrock.git","svn_url":"https://github.com/mozilla/bedrock","homepage":"https://www.mozilla.org","size":381799,"stargazers_count":288,"watchers_count":288,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":406,"mirror_url":null,"open_issues_count":22,"forks":406,"open_issues":22,"watchers":288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/4084"},"html":{"href":"https://github.com/mozilla/bedrock/pull/4084"},"issue":{"href":"https://api.github.com/repos/mozilla/bedrock/issues/4084"},"comments":{"href":"https://api.github.com/repos/mozilla/bedrock/issues/4084/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/4084/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/4084/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/bedrock/statuses/b40a2e2dc58637865bf1697c779198a00270972d"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":8,"review_comments":0,"commits":1,"additions":14,"deletions":33,"changed_files":5}}