{"push_id":1266873351,"size":23,"distinct_size":1,"ref":"refs/heads/feature/MON-9553-categorize-dashboard-menu-s-items","head":"48fb582aa0c0dc2bc09ac93e74550ba91ddba323","before":"530df9dcd3ae29a0ded3f3d2f1c124708a7b5df7","commits":[{"sha":"270161bd65cc8d1c07446c30cd9fb7cab7003bb0","author":{"name":"Carl Helmertz","email":"2347e23dac081a34c7f519606e45ce84387cd73c@op5.com"},"message":"report_options: Remove inline tabs\n\nIt was annoying to read in my editor, and it's just silly to try to\nmaintain tabbed data when not in the beginning of a line.\n\nSigned-off-by: Carl Helmertz <chelmertz@op5.com>","distinct":false,"url":"https://api.github.com/repos/op5/ninja/commits/270161bd65cc8d1c07446c30cd9fb7cab7003bb0"},{"sha":"253a66acb1e3071acf66105b817985c4c21da66c","author":{"name":"Carl Helmertz","email":"2347e23dac081a34c7f519606e45ce84387cd73c@op5.com"},"message":"report_options: Actually make use of the test provided fixture\n\nNow the tests we write can actually fail, to confirm the current\nbehaviour for MON-7264.\n\nSigned-off-by: Carl Helmertz <chelmertz@op5.com>","distinct":false,"url":"https://api.github.com/repos/op5/ninja/commits/253a66acb1e3071acf66105b817985c4c21da66c"},{"sha":"ae8fc05fd22b5934da3187e62e7e34de87e7ae68","author":{"name":"Carl Helmertz","email":"2347e23dac081a34c7f519606e45ce84387cd73c@op5.com"},"message":"report_options: Failing tests for report_period = lastweek\n\nThis confirms MON-7264\n\nSigned-off-by: Carl Helmertz <chelmertz@op5.com>","distinct":false,"url":"https://api.github.com/repos/op5/ninja/commits/ae8fc05fd22b5934da3187e62e7e34de87e7ae68"},{"sha":"b39bfd8c67baea418b1e854e7421babb8c7ca8f6","author":{"name":"Carl Helmertz","email":"2347e23dac081a34c7f519606e45ce84387cd73c@op5.com"},"message":"report_options: \"Last week\" represented the date one week too early\n\nInstead of trying to make php's strtotime() work everything out by\ngiving it a complicated first argument, we adjust the date by giving it\na second argument so that the relativeness is correct.\n\nI stole this solution from Philip Eklöf, whose research is displayed on\nthe page of the associated issue.\n\nThis fixes MON-7264\n\nSigned-off-by: Carl Helmertz <chelmertz@op5.com>","distinct":false,"url":"https://api.github.com/repos/op5/ninja/commits/b39bfd8c67baea418b1e854e7421babb8c7ca8f6"},{"sha":"a6673cf4fa06b86004baa2d399984af7d4be942c","author":{"name":"Carl Helmertz","email":"2347e23dac081a34c7f519606e45ce84387cd73c@op5.com"},"message":"test: Test report periods last{week,month,year,{3,6,12}months,quarter}\n\nWe also prettify the previous tests we wrote for MON-7264.\n\nSigned-off-by: Carl Helmertz <chelmertz@op5.com>","distinct":false,"url":"https://api.github.com/repos/op5/ninja/commits/a6673cf4fa06b86004baa2d399984af7d4be942c"},{"sha":"de1b841e47712be92e24181139c0f6c608c4aa4a","author":{"name":"Anton Löfgren","email":"fef670276cc8f0b6c2eeea11fe9b5a7a47b55ccd@op5.com"},"message":"Merge pull request #116 in MONITOR/ninja from bugfix/MON-7264-report-period-last-week-translates to master\n\n* commit 'a6673cf4fa06b86004baa2d399984af7d4be942c':\n  test: Test report periods last{week,month,year,{3,6,12}months,quarter}\n  report_options: \"Last week\" represented the date one week too early\n  report_options: Failing tests for report_period = lastweek\n  report_options: Actually make use of the test provided fixture\n  report_options: Remove inline tabs","distinct":false,"url":"https://api.github.com/repos/op5/ninja/commits/de1b841e47712be92e24181139c0f6c608c4aa4a"},{"sha":"9ff0cbccfafd20d2c1d02ecf79d3675bde4827ea","author":{"name":"Max Sikstrom","email":"43dfbca96699eaeac51f7e6cefab45fad71aa1eb@op5.com"},"message":"Merge pull request #117 in MONITOR/ninja from feature/MON-9540-permissions-for-dashboards to master\n\n* commit '6fd0cf0bf0ad859be331350de7d169559c3180a6':\n  Dashboard: Multiple and sharable, no manage gui\n  Permission quarks: First implementaiton","distinct":false,"url":"https://api.github.com/repos/op5/ninja/commits/9ff0cbccfafd20d2c1d02ecf79d3675bde4827ea"},{"sha":"53fed8654d84590794403c5c8b2c8a0d2585ea2d","author":{"name":"Carl Helmertz","email":"2347e23dac081a34c7f519606e45ce84387cd73c@op5.com"},"message":"report: Correct thisweek, test last{7,31}days, make tests more robust\n\nRobin Hagman noticed that 'thisweek' would probably not work on a\nSunday, and he was correct! The tests proves me right.\n\nAdditionally, I switched out 2016 in all test fixtures to 2015, which\ncaught some untestable code that needed to be testable.\n\nI added exceptions that are never thrown, but I will remove them in the\nfollowing commit, just to make sure that the signature of\n`Report_options::calculate_time()` is unchanged. I will actually take\nout the meaty parts of it and put it into a helper, since it is unit\ntestable instead of having to know the inner workings of\n`Report_options`.\n\nThis fixes MON-9558\n\nSigned-off-by: Carl Helmertz <chelmertz@op5.com>","distinct":false,"url":"https://api.github.com/repos/op5/ninja/commits/53fed8654d84590794403c5c8b2c8a0d2585ea2d"},{"sha":"19400a2a912539ed5287f303c09115cc84a5b387","author":{"name":"Carl Helmertz","email":"2347e23dac081a34c7f519606e45ce84387cd73c@op5.com"},"message":"time: Fix whitespaces\n\nSomeones editor must have been configured weirdly in order to display\nthis file nicely. You cannot count on every dev having the same tab\nwidth.\n\nSigned-off-by: Carl Helmertz <chelmertz@op5.com>","distinct":false,"url":"https://api.github.com/repos/op5/ninja/commits/19400a2a912539ed5287f303c09115cc84a5b387"},{"sha":"3876fbb68f7b16085ce6a47030b5e42bbf001d87","author":{"name":"Carl Helmertz","email":"2347e23dac081a34c7f519606e45ce84387cd73c@op5.com"},"message":"Rep_opts::calculate_time() -> time::start_and_end_of_report_period()\n\nThis is a refactoring that doesn't require any logic to be changed in\nthe relevant test cases, to still pass.\n\nThe following commit will adapt the test code in order to fit with the\nsentiment of this refactoring.\n\nSigned-off-by: Carl Helmertz <chelmertz@op5.com>","distinct":false,"url":"https://api.github.com/repos/op5/ninja/commits/3876fbb68f7b16085ce6a47030b5e42bbf001d87"},{"sha":"225a37d28da4ff364583d31abdc0912917ae0a53","author":{"name":"Carl Helmertz","email":"2347e23dac081a34c7f519606e45ce84387cd73c@op5.com"},"message":"test: Rewrite test of Report_options to unit test helper\n\nThis removes the need to know anything about the `Report_options` when\nit is the actual 'textual representation of timeperiod' -> 'timestamps'\ntransformation.\n\nSigned-off-by: Carl Helmertz <chelmertz@op5.com>","distinct":false,"url":"https://api.github.com/repos/op5/ninja/commits/225a37d28da4ff364583d31abdc0912917ae0a53"},{"sha":"5481d561dbd486f97b8b33549b7e10b74bcf716f","author":{"name":"Carl Helmertz","email":"2347e23dac081a34c7f519606e45ce84387cd73c@op5.com"},"message":"Rename time::start_and_end_of_report_period() to time::get_limits()\n\nSince we extracted the method from `Report_options` and generalized it,\nwe no longer have to mention report options.\n\nSigned-off-by: Carl Helmertz <chelmertz@op5.com>","distinct":false,"url":"https://api.github.com/repos/op5/ninja/commits/5481d561dbd486f97b8b33549b7e10b74bcf716f"},{"sha":"24e59c9b8109706073c03daaa7c823985776774a","author":{"name":"Carl Helmertz","email":"2347e23dac081a34c7f519606e45ce84387cd73c@op5.com"},"message":"test: Remove spammy LDAP calls from test output\n\nThe following is not useful in any way, and confuses at least one\ndeveloper (me):\n\n......................../srv/repos/monitor/ninja/test/env/ldap /srv/repos/monitor/ninja\n/srv/repos/monitor/ninja\n.......................................  63 / 478 ( 13%)\n............................................................... 126 / 478 ( 26%)\n.........SSS................................................... 189 / 478 ( 39%)\n............................................................... 252 / 478 ( 52%)\n............................................................... 315 / 478 ( 65%)\n............................................................... 378 / 478 ( 79%)\n\nWe squelch the `pushd` and `popd` calls, and also add some safety checks\n(`set -e` in the bash scripts and asserting the exit code from the php\nunit test side of things).\n\nSigned-off-by: Carl Helmertz <chelmertz@op5.com>","distinct":false,"url":"https://api.github.com/repos/op5/ninja/commits/24e59c9b8109706073c03daaa7c823985776774a"},{"sha":"3ff5d0466943e4d7333827d1ff223b42f9e42044","author":{"name":"Carl Helmertz","email":"2347e23dac081a34c7f519606e45ce84387cd73c@op5.com"},"message":"Merge pull request #119 in MONITOR/ninja from bugfix/report-options to master\n\n* commit '5481d561dbd486f97b8b33549b7e10b74bcf716f':\n  Rename time::start_and_end_of_report_period() to time::get_limits()\n  test: Rewrite test of Report_options to unit test helper\n  Rep_opts::calculate_time() -> time::start_and_end_of_report_period()\n  time: Fix whitespaces\n  report: Correct thisweek, test last{7,31}days, make tests more robust","distinct":false,"url":"https://api.github.com/repos/op5/ninja/commits/3ff5d0466943e4d7333827d1ff223b42f9e42044"},{"sha":"b97de7e98034f1bcfed82e6a3174b5668365ff89","author":{"name":"Max Sikstrom","email":"43dfbca96699eaeac51f7e6cefab45fad71aa1eb@op5.com"},"message":"Merge pull request #120 in MONITOR/ninja from bugfix/spammy-ldap-tests to master\n\n* commit '24e59c9b8109706073c03daaa7c823985776774a':\n  test: Remove spammy LDAP calls from test output","distinct":false,"url":"https://api.github.com/repos/op5/ninja/commits/b97de7e98034f1bcfed82e6a3174b5668365ff89"},{"sha":"5ae4cc2c2524ba0e2c63f9c5066de69d5255e11f","author":{"name":"Anton Lofgren","email":"fef670276cc8f0b6c2eeea11fe9b5a7a47b55ccd@op5.com"},"message":"LSFilterVisual: Remove unreachable code\n\nSigned-off-by: Anton Lofgren <alofgren@op5.com>","distinct":false,"url":"https://api.github.com/repos/op5/ninja/commits/5ae4cc2c2524ba0e2c63f9c5066de69d5255e11f"},{"sha":"0f81acefe0eabfa28ee62a49934ee2b8deff6115","author":{"name":"Max Sikstrom","email":"43dfbca96699eaeac51f7e6cefab45fad71aa1eb@op5.com"},"message":"Merge pull request #121 in MONITOR/ninja from bugfix/remove-unreachable-code to master\n\n* commit '5ae4cc2c2524ba0e2c63f9c5066de69d5255e11f':\n  LSFilterVisual: Remove unreachable code","distinct":false,"url":"https://api.github.com/repos/op5/ninja/commits/0f81acefe0eabfa28ee62a49934ee2b8deff6115"},{"sha":"bb9fdbf548b8852378a11676428fb1d6c3819f50","author":{"name":"Tobias Sjöndin","email":"175d2b13e5aa88b95499e6e0b6c2f116c1c3ebfe@op5.com"},"message":"Prepare new object details page with c3 and d3 libraries\n\nAs they will be used for charts within the view.\n\nThis is part of MON-9356\n\nSigned-off-by: Tobias Sjöndin <tsjondin@op5.com>","distinct":false,"url":"https://api.github.com/repos/op5/ninja/commits/bb9fdbf548b8852378a11676428fb1d6c3819f50"},{"sha":"9db14fcc9f62e680760ab6c0dc860a09c71ca816","author":{"name":"Tobias Sjöndin","email":"175d2b13e5aa88b95499e6e0b6c2f116c1c3ebfe@op5.com"},"message":"Remove and tweak general CSS\n\nIn preparation of MON-9356\n\nSigned-off-by: Tobias Sjöndin <tsjondin@op5.com>","distinct":false,"url":"https://api.github.com/repos/op5/ninja/commits/9db14fcc9f62e680760ab6c0dc860a09c71ca816"},{"sha":"55fd8ca1fff371ad13b4beea707c88c91287d2f9","author":{"name":"Tobias Sjöndin","email":"175d2b13e5aa88b95499e6e0b6c2f116c1c3ebfe@op5.com"},"message":"Add new vector/font icons and load them\n\nIn preparation of MON-9356\n\nSigned-off-by: Tobias Sjöndin <tsjondin@op5.com>","distinct":false,"url":"https://api.github.com/repos/op5/ninja/commits/55fd8ca1fff371ad13b4beea707c88c91287d2f9"}]}
{"actor":{"display_login":"op5-ci-user"}}