{"action":"created","comment":{"url":"https://api.github.com/repos/osuosl/timesync-node/pulls/comments/50448072","id":50448072,"diff_hunk":"@@ -8,8 +8,14 @@ const tokens = {};\n const MAX_AGE = 30 * 60 * 1000;\n \n module.exports = function(app) {\n+  const log = app.get('log');\n   let authType;\n \n+  if (!process.env.INSTANCE_NAME || !process.env.SECRET_KEY) {\n+    log.error('login.js', 'INSTANCE_NAME or SECRET_KEY not set!');\n+    process.exit(1);\n+  }","path":"src/login.js","position":10,"original_position":10,"commit_id":"fa9ee1554ea6885035c7a25045ccd2410663c142","original_commit_id":"fa9ee1554ea6885035c7a25045ccd2410663c142","user":{"login":"Kennric","id":1696096,"avatar_url":"https://avatars.githubusercontent.com/u/1696096?v=3","gravatar_id":"","url":"https://api.github.com/users/Kennric","html_url":"https://github.com/Kennric","followers_url":"https://api.github.com/users/Kennric/followers","following_url":"https://api.github.com/users/Kennric/following{/other_user}","gists_url":"https://api.github.com/users/Kennric/gists{/gist_id}","starred_url":"https://api.github.com/users/Kennric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kennric/subscriptions","organizations_url":"https://api.github.com/users/Kennric/orgs","repos_url":"https://api.github.com/users/Kennric/repos","events_url":"https://api.github.com/users/Kennric/events{/privacy}","received_events_url":"https://api.github.com/users/Kennric/received_events","type":"User","site_admin":false},"body":"I have questions about this test. \r\nFirst, I think any configuration options that are required by the application should be checked when the instance starts, I am not sure login is the place for that test.\r\n\r\nSecond, if the application is configured by file (i.e. not by setting environment variables), will these variables be in the process.env at all?","created_at":"2016-01-21T19:16:19Z","updated_at":"2016-01-21T19:16:19Z","html_url":"https://github.com/osuosl/timesync-node/pull/230#discussion_r50448072","pull_request_url":"https://api.github.com/repos/osuosl/timesync-node/pulls/230","_links":{"self":{"href":"https://api.github.com/repos/osuosl/timesync-node/pulls/comments/50448072"},"html":{"href":"https://github.com/osuosl/timesync-node/pull/230#discussion_r50448072"},"pull_request":{"href":"https://api.github.com/repos/osuosl/timesync-node/pulls/230"}}},"pull_request":{"url":"https://api.github.com/repos/osuosl/timesync-node/pulls/230","id":56544308,"html_url":"https://github.com/osuosl/timesync-node/pull/230","diff_url":"https://github.com/osuosl/timesync-node/pull/230.diff","patch_url":"https://github.com/osuosl/timesync-node/pull/230.patch","issue_url":"https://api.github.com/repos/osuosl/timesync-node/issues/230","number":230,"state":"open","locked":false,"title":"Add console and file logging.","user":{"login":"LyonesGamer","id":2058985,"avatar_url":"https://avatars.githubusercontent.com/u/2058985?v=3","gravatar_id":"","url":"https://api.github.com/users/LyonesGamer","html_url":"https://github.com/LyonesGamer","followers_url":"https://api.github.com/users/LyonesGamer/followers","following_url":"https://api.github.com/users/LyonesGamer/following{/other_user}","gists_url":"https://api.github.com/users/LyonesGamer/gists{/gist_id}","starred_url":"https://api.github.com/users/LyonesGamer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LyonesGamer/subscriptions","organizations_url":"https://api.github.com/users/LyonesGamer/orgs","repos_url":"https://api.github.com/users/LyonesGamer/repos","events_url":"https://api.github.com/users/LyonesGamer/events{/privacy}","received_events_url":"https://api.github.com/users/LyonesGamer/received_events","type":"User","site_admin":false},"body":"This will prevent failures to solve problems on the staging (and, in the future, production!) instance by providing full access and error logging on the application, including timestamps, etc.","created_at":"2016-01-19T23:49:19Z","updated_at":"2016-01-21T19:16:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d61f366ff32b4b69e9502b36468a0cc2cb71192c","assignee":{"login":"LyonesGamer","id":2058985,"avatar_url":"https://avatars.githubusercontent.com/u/2058985?v=3","gravatar_id":"","url":"https://api.github.com/users/LyonesGamer","html_url":"https://github.com/LyonesGamer","followers_url":"https://api.github.com/users/LyonesGamer/followers","following_url":"https://api.github.com/users/LyonesGamer/following{/other_user}","gists_url":"https://api.github.com/users/LyonesGamer/gists{/gist_id}","starred_url":"https://api.github.com/users/LyonesGamer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LyonesGamer/subscriptions","organizations_url":"https://api.github.com/users/LyonesGamer/orgs","repos_url":"https://api.github.com/users/LyonesGamer/repos","events_url":"https://api.github.com/users/LyonesGamer/events{/privacy}","received_events_url":"https://api.github.com/users/LyonesGamer/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/osuosl/timesync-node/pulls/230/commits","review_comments_url":"https://api.github.com/repos/osuosl/timesync-node/pulls/230/comments","review_comment_url":"https://api.github.com/repos/osuosl/timesync-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/osuosl/timesync-node/issues/230/comments","statuses_url":"https://api.github.com/repos/osuosl/timesync-node/statuses/fa9ee1554ea6885035c7a25045ccd2410663c142","head":{"label":"osuosl:tristan/logging","ref":"tristan/logging","sha":"fa9ee1554ea6885035c7a25045ccd2410663c142","user":{"login":"osuosl","id":1380625,"avatar_url":"https://avatars.githubusercontent.com/u/1380625?v=3","gravatar_id":"","url":"https://api.github.com/users/osuosl","html_url":"https://github.com/osuosl","followers_url":"https://api.github.com/users/osuosl/followers","following_url":"https://api.github.com/users/osuosl/following{/other_user}","gists_url":"https://api.github.com/users/osuosl/gists{/gist_id}","starred_url":"https://api.github.com/users/osuosl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osuosl/subscriptions","organizations_url":"https://api.github.com/users/osuosl/orgs","repos_url":"https://api.github.com/users/osuosl/repos","events_url":"https://api.github.com/users/osuosl/events{/privacy}","received_events_url":"https://api.github.com/users/osuosl/received_events","type":"Organization","site_admin":false},"repo":{"id":33685026,"name":"timesync-node","full_name":"osuosl/timesync-node","owner":{"login":"osuosl","id":1380625,"avatar_url":"https://avatars.githubusercontent.com/u/1380625?v=3","gravatar_id":"","url":"https://api.github.com/users/osuosl","html_url":"https://github.com/osuosl","followers_url":"https://api.github.com/users/osuosl/followers","following_url":"https://api.github.com/users/osuosl/following{/other_user}","gists_url":"https://api.github.com/users/osuosl/gists{/gist_id}","starred_url":"https://api.github.com/users/osuosl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osuosl/subscriptions","organizations_url":"https://api.github.com/users/osuosl/orgs","repos_url":"https://api.github.com/users/osuosl/repos","events_url":"https://api.github.com/users/osuosl/events{/privacy}","received_events_url":"https://api.github.com/users/osuosl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osuosl/timesync-node","description":"Time Tracking API","fork":false,"url":"https://api.github.com/repos/osuosl/timesync-node","forks_url":"https://api.github.com/repos/osuosl/timesync-node/forks","keys_url":"https://api.github.com/repos/osuosl/timesync-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osuosl/timesync-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osuosl/timesync-node/teams","hooks_url":"https://api.github.com/repos/osuosl/timesync-node/hooks","issue_events_url":"https://api.github.com/repos/osuosl/timesync-node/issues/events{/number}","events_url":"https://api.github.com/repos/osuosl/timesync-node/events","assignees_url":"https://api.github.com/repos/osuosl/timesync-node/assignees{/user}","branches_url":"https://api.github.com/repos/osuosl/timesync-node/branches{/branch}","tags_url":"https://api.github.com/repos/osuosl/timesync-node/tags","blobs_url":"https://api.github.com/repos/osuosl/timesync-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osuosl/timesync-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osuosl/timesync-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/osuosl/timesync-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osuosl/timesync-node/statuses/{sha}","languages_url":"https://api.github.com/repos/osuosl/timesync-node/languages","stargazers_url":"https://api.github.com/repos/osuosl/timesync-node/stargazers","contributors_url":"https://api.github.com/repos/osuosl/timesync-node/contributors","subscribers_url":"https://api.github.com/repos/osuosl/timesync-node/subscribers","subscription_url":"https://api.github.com/repos/osuosl/timesync-node/subscription","commits_url":"https://api.github.com/repos/osuosl/timesync-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/osuosl/timesync-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/osuosl/timesync-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/osuosl/timesync-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/osuosl/timesync-node/contents/{+path}","compare_url":"https://api.github.com/repos/osuosl/timesync-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osuosl/timesync-node/merges","archive_url":"https://api.github.com/repos/osuosl/timesync-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osuosl/timesync-node/downloads","issues_url":"https://api.github.com/repos/osuosl/timesync-node/issues{/number}","pulls_url":"https://api.github.com/repos/osuosl/timesync-node/pulls{/number}","milestones_url":"https://api.github.com/repos/osuosl/timesync-node/milestones{/number}","notifications_url":"https://api.github.com/repos/osuosl/timesync-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osuosl/timesync-node/labels{/name}","releases_url":"https://api.github.com/repos/osuosl/timesync-node/releases{/id}","created_at":"2015-04-09T18:20:54Z","updated_at":"2016-01-19T23:42:37Z","pushed_at":"2016-01-20T00:12:38Z","git_url":"git://github.com/osuosl/timesync-node.git","ssh_url":"git@github.com:osuosl/timesync-node.git","clone_url":"https://github.com/osuosl/timesync-node.git","svn_url":"https://github.com/osuosl/timesync-node","homepage":null,"size":919,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":17,"forks":3,"open_issues":17,"watchers":2,"default_branch":"develop"}},"base":{"label":"osuosl:develop","ref":"develop","sha":"b448f0fcf171d414f300d00de8000abc82ca3a5e","user":{"login":"osuosl","id":1380625,"avatar_url":"https://avatars.githubusercontent.com/u/1380625?v=3","gravatar_id":"","url":"https://api.github.com/users/osuosl","html_url":"https://github.com/osuosl","followers_url":"https://api.github.com/users/osuosl/followers","following_url":"https://api.github.com/users/osuosl/following{/other_user}","gists_url":"https://api.github.com/users/osuosl/gists{/gist_id}","starred_url":"https://api.github.com/users/osuosl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osuosl/subscriptions","organizations_url":"https://api.github.com/users/osuosl/orgs","repos_url":"https://api.github.com/users/osuosl/repos","events_url":"https://api.github.com/users/osuosl/events{/privacy}","received_events_url":"https://api.github.com/users/osuosl/received_events","type":"Organization","site_admin":false},"repo":{"id":33685026,"name":"timesync-node","full_name":"osuosl/timesync-node","owner":{"login":"osuosl","id":1380625,"avatar_url":"https://avatars.githubusercontent.com/u/1380625?v=3","gravatar_id":"","url":"https://api.github.com/users/osuosl","html_url":"https://github.com/osuosl","followers_url":"https://api.github.com/users/osuosl/followers","following_url":"https://api.github.com/users/osuosl/following{/other_user}","gists_url":"https://api.github.com/users/osuosl/gists{/gist_id}","starred_url":"https://api.github.com/users/osuosl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osuosl/subscriptions","organizations_url":"https://api.github.com/users/osuosl/orgs","repos_url":"https://api.github.com/users/osuosl/repos","events_url":"https://api.github.com/users/osuosl/events{/privacy}","received_events_url":"https://api.github.com/users/osuosl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osuosl/timesync-node","description":"Time Tracking API","fork":false,"url":"https://api.github.com/repos/osuosl/timesync-node","forks_url":"https://api.github.com/repos/osuosl/timesync-node/forks","keys_url":"https://api.github.com/repos/osuosl/timesync-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osuosl/timesync-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osuosl/timesync-node/teams","hooks_url":"https://api.github.com/repos/osuosl/timesync-node/hooks","issue_events_url":"https://api.github.com/repos/osuosl/timesync-node/issues/events{/number}","events_url":"https://api.github.com/repos/osuosl/timesync-node/events","assignees_url":"https://api.github.com/repos/osuosl/timesync-node/assignees{/user}","branches_url":"https://api.github.com/repos/osuosl/timesync-node/branches{/branch}","tags_url":"https://api.github.com/repos/osuosl/timesync-node/tags","blobs_url":"https://api.github.com/repos/osuosl/timesync-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osuosl/timesync-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osuosl/timesync-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/osuosl/timesync-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osuosl/timesync-node/statuses/{sha}","languages_url":"https://api.github.com/repos/osuosl/timesync-node/languages","stargazers_url":"https://api.github.com/repos/osuosl/timesync-node/stargazers","contributors_url":"https://api.github.com/repos/osuosl/timesync-node/contributors","subscribers_url":"https://api.github.com/repos/osuosl/timesync-node/subscribers","subscription_url":"https://api.github.com/repos/osuosl/timesync-node/subscription","commits_url":"https://api.github.com/repos/osuosl/timesync-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/osuosl/timesync-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/osuosl/timesync-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/osuosl/timesync-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/osuosl/timesync-node/contents/{+path}","compare_url":"https://api.github.com/repos/osuosl/timesync-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osuosl/timesync-node/merges","archive_url":"https://api.github.com/repos/osuosl/timesync-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osuosl/timesync-node/downloads","issues_url":"https://api.github.com/repos/osuosl/timesync-node/issues{/number}","pulls_url":"https://api.github.com/repos/osuosl/timesync-node/pulls{/number}","milestones_url":"https://api.github.com/repos/osuosl/timesync-node/milestones{/number}","notifications_url":"https://api.github.com/repos/osuosl/timesync-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osuosl/timesync-node/labels{/name}","releases_url":"https://api.github.com/repos/osuosl/timesync-node/releases{/id}","created_at":"2015-04-09T18:20:54Z","updated_at":"2016-01-19T23:42:37Z","pushed_at":"2016-01-20T00:12:38Z","git_url":"git://github.com/osuosl/timesync-node.git","ssh_url":"git@github.com:osuosl/timesync-node.git","clone_url":"https://github.com/osuosl/timesync-node.git","svn_url":"https://github.com/osuosl/timesync-node","homepage":null,"size":919,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":17,"forks":3,"open_issues":17,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/osuosl/timesync-node/pulls/230"},"html":{"href":"https://github.com/osuosl/timesync-node/pull/230"},"issue":{"href":"https://api.github.com/repos/osuosl/timesync-node/issues/230"},"comments":{"href":"https://api.github.com/repos/osuosl/timesync-node/issues/230/comments"},"review_comments":{"href":"https://api.github.com/repos/osuosl/timesync-node/pulls/230/comments"},"review_comment":{"href":"https://api.github.com/repos/osuosl/timesync-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/osuosl/timesync-node/pulls/230/commits"},"statuses":{"href":"https://api.github.com/repos/osuosl/timesync-node/statuses/fa9ee1554ea6885035c7a25045ccd2410663c142"}}}}