{"action":"created","issue":{"url":"https://api.github.com/repos/substance/substance/issues/900","repository_url":"https://api.github.com/repos/substance/substance","labels_url":"https://api.github.com/repos/substance/substance/issues/900/labels{/name}","comments_url":"https://api.github.com/repos/substance/substance/issues/900/comments","events_url":"https://api.github.com/repos/substance/substance/issues/900/events","html_url":"https://github.com/substance/substance/issues/900","id":192833680,"number":900,"title":"Remove or redo quickstart.md, EditorSession state","user":{"login":"Neur0mante","id":2531480,"avatar_url":"https://avatars.githubusercontent.com/u/2531480?v=3","gravatar_id":"","url":"https://api.github.com/users/Neur0mante","html_url":"https://github.com/Neur0mante","followers_url":"https://api.github.com/users/Neur0mante/followers","following_url":"https://api.github.com/users/Neur0mante/following{/other_user}","gists_url":"https://api.github.com/users/Neur0mante/gists{/gist_id}","starred_url":"https://api.github.com/users/Neur0mante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neur0mante/subscriptions","organizations_url":"https://api.github.com/users/Neur0mante/orgs","repos_url":"https://api.github.com/users/Neur0mante/repos","events_url":"https://api.github.com/users/Neur0mante/events{/privacy}","received_events_url":"https://api.github.com/users/Neur0mante/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-01T12:29:23Z","updated_at":"2016-12-01T20:29:18Z","closed_at":null,"body":"the [substance/doc/quickstart.md](https://github.com/substance/substance/blob/develop/doc/quickstart.md) example is pretty broken. \r\nIt doesn't import _EditorSession_, it erroneously call `cfg.import(SuperscriptPackage) ` when _SuperscriptPackage_ is already packaged into _ProseEditorPackage_, it uses _configurator_ in place of _cfg_  \r\n```\r\nconst cfg = new Configurator()\r\n...\r\nlet doc = configurator.createArticle(fixture)\r\n  let editorSession = new EditorSession(doc, {\r\n    configurator: configurator\r\n  })\r\n```\r\nand even when you fix all of that the result is kind of a mess.\r\nAlso, it appears to me that _EditorSession_ is only present on the current dev branch obtainable by using ` \"substance\": \"substance/substance#develop\"` in the package.json, and then building the project. If I just use `npm install --save substance` I get the older branch with documentSession instead."},"comment":{"url":"https://api.github.com/repos/substance/substance/issues/comments/264285651","html_url":"https://github.com/substance/substance/issues/900#issuecomment-264285651","issue_url":"https://api.github.com/repos/substance/substance/issues/900","id":264285651,"user":{"login":"rquast","id":1103891,"avatar_url":"https://avatars.githubusercontent.com/u/1103891?v=3","gravatar_id":"","url":"https://api.github.com/users/rquast","html_url":"https://github.com/rquast","followers_url":"https://api.github.com/users/rquast/followers","following_url":"https://api.github.com/users/rquast/following{/other_user}","gists_url":"https://api.github.com/users/rquast/gists{/gist_id}","starred_url":"https://api.github.com/users/rquast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rquast/subscriptions","organizations_url":"https://api.github.com/users/rquast/orgs","repos_url":"https://api.github.com/users/rquast/repos","events_url":"https://api.github.com/users/rquast/events{/privacy}","received_events_url":"https://api.github.com/users/rquast/received_events","type":"User","site_admin":false},"created_at":"2016-12-01T20:29:18Z","updated_at":"2016-12-01T20:29:18Z","body":"I noticed all this (and more) too. Looks like they're in the middle of some huge refactoring. I do like the way they've structured everything.. very extensible. Most of the recent commits are tidying things up a lot, but I suspect they're going to change a lot more.\r\n\r\nYesterday I had to figure out how to configure webpack to do the postcss stuff they do with their bundler. Finally figured that out.. how have to figure out how to rework their reset.css because it mucks around too much with my css."}}
{"actor":{"display_login":"rquast"}}