{"action":"created","comment":{"url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/pulls/comments/73792413","id":73792413,"diff_hunk":"@@ -24,15 +24,15 @@ exports.create = function(name, chatBot, options) {\n };\n \n MessageIntervalTrigger.prototype._onLoad = function() {\n-\tsetInterval(this._send, this.options.interval);\n+\tsetInterval(function(){this._send(this)}, this.options.interval);\n }\n \n-MessageIntervalTrigger.prototype._send = function() {\n-\ttry {\n-\t\tif(this.options.destination && this.options.message && this.chatBot.connected) {\n-\t\t\tthis._sendMessageAfterDelay(this.options.destination, this.options.message);\n+MessageIntervalTrigger.prototype._send = function(that) {\n+\t\ttry {","path":"lib/triggers/messageIntervalTrigger.js","position":13,"original_position":13,"commit_id":"1a39f473b87e6409d6e6b29f943bacb5fbdba294","original_commit_id":"1a39f473b87e6409d6e6b29f943bacb5fbdba294","user":{"login":"Efreak","id":749751,"avatar_url":"https://avatars.githubusercontent.com/u/749751?v=3","gravatar_id":"","url":"https://api.github.com/users/Efreak","html_url":"https://github.com/Efreak","followers_url":"https://api.github.com/users/Efreak/followers","following_url":"https://api.github.com/users/Efreak/following{/other_user}","gists_url":"https://api.github.com/users/Efreak/gists{/gist_id}","starred_url":"https://api.github.com/users/Efreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Efreak/subscriptions","organizations_url":"https://api.github.com/users/Efreak/orgs","repos_url":"https://api.github.com/users/Efreak/repos","events_url":"https://api.github.com/users/Efreak/events{/privacy}","received_events_url":"https://api.github.com/users/Efreak/received_events","type":"User","site_admin":false},"body":"Can you remember why we needed to do this? I can't, and I can't think of a reason why these lines should be removed. I recall this function causing the bot to crash when people had triggers sending messages as soon as the bot was started (ie, before it was connected, hence the check for `this.chatBot.connected`). The try block should deal with it, but it would also cause unnecessary errors in the log/console. I should definitely be logging *something* rather than letting the messages go nowhere, but dropping the check entirely seems the wrong way to do it.","created_at":"2016-08-06T21:44:01Z","updated_at":"2016-08-06T21:44:01Z","html_url":"https://github.com/Steam-Chat-Bot/node-steam-chat-bot/pull/128#discussion_r73792413","pull_request_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/pulls/comments/73792413"},"html":{"href":"https://github.com/Steam-Chat-Bot/node-steam-chat-bot/pull/128#discussion_r73792413"},"pull_request":{"href":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/pulls/128","id":74324850,"html_url":"https://github.com/Steam-Chat-Bot/node-steam-chat-bot/pull/128","diff_url":"https://github.com/Steam-Chat-Bot/node-steam-chat-bot/pull/128.diff","patch_url":"https://github.com/Steam-Chat-Bot/node-steam-chat-bot/pull/128.patch","issue_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/issues/128","number":128,"state":"open","locked":false,"title":"Development","user":{"login":"irmandos","id":5756234,"avatar_url":"https://avatars.githubusercontent.com/u/5756234?v=3","gravatar_id":"","url":"https://api.github.com/users/irmandos","html_url":"https://github.com/irmandos","followers_url":"https://api.github.com/users/irmandos/followers","following_url":"https://api.github.com/users/irmandos/following{/other_user}","gists_url":"https://api.github.com/users/irmandos/gists{/gist_id}","starred_url":"https://api.github.com/users/irmandos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irmandos/subscriptions","organizations_url":"https://api.github.com/users/irmandos/orgs","repos_url":"https://api.github.com/users/irmandos/repos","events_url":"https://api.github.com/users/irmandos/events{/privacy}","received_events_url":"https://api.github.com/users/irmandos/received_events","type":"User","site_admin":false},"body":"Updates that were done for the ir_bot","created_at":"2016-06-18T02:15:54Z","updated_at":"2016-08-06T21:44:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1acd1488c0d5a76df7a27bc9c9a869955d1aeca","assignee":{"login":"Efreak","id":749751,"avatar_url":"https://avatars.githubusercontent.com/u/749751?v=3","gravatar_id":"","url":"https://api.github.com/users/Efreak","html_url":"https://github.com/Efreak","followers_url":"https://api.github.com/users/Efreak/followers","following_url":"https://api.github.com/users/Efreak/following{/other_user}","gists_url":"https://api.github.com/users/Efreak/gists{/gist_id}","starred_url":"https://api.github.com/users/Efreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Efreak/subscriptions","organizations_url":"https://api.github.com/users/Efreak/orgs","repos_url":"https://api.github.com/users/Efreak/repos","events_url":"https://api.github.com/users/Efreak/events{/privacy}","received_events_url":"https://api.github.com/users/Efreak/received_events","type":"User","site_admin":false},"assignees":[{"login":"Efreak","id":749751,"avatar_url":"https://avatars.githubusercontent.com/u/749751?v=3","gravatar_id":"","url":"https://api.github.com/users/Efreak","html_url":"https://github.com/Efreak","followers_url":"https://api.github.com/users/Efreak/followers","following_url":"https://api.github.com/users/Efreak/following{/other_user}","gists_url":"https://api.github.com/users/Efreak/gists{/gist_id}","starred_url":"https://api.github.com/users/Efreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Efreak/subscriptions","organizations_url":"https://api.github.com/users/Efreak/orgs","repos_url":"https://api.github.com/users/Efreak/repos","events_url":"https://api.github.com/users/Efreak/events{/privacy}","received_events_url":"https://api.github.com/users/Efreak/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/pulls/128/commits","review_comments_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/pulls/128/comments","review_comment_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/issues/128/comments","statuses_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/statuses/1a39f473b87e6409d6e6b29f943bacb5fbdba294","head":{"label":"irmandos:development","ref":"development","sha":"1a39f473b87e6409d6e6b29f943bacb5fbdba294","user":{"login":"irmandos","id":5756234,"avatar_url":"https://avatars.githubusercontent.com/u/5756234?v=3","gravatar_id":"","url":"https://api.github.com/users/irmandos","html_url":"https://github.com/irmandos","followers_url":"https://api.github.com/users/irmandos/followers","following_url":"https://api.github.com/users/irmandos/following{/other_user}","gists_url":"https://api.github.com/users/irmandos/gists{/gist_id}","starred_url":"https://api.github.com/users/irmandos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irmandos/subscriptions","organizations_url":"https://api.github.com/users/irmandos/orgs","repos_url":"https://api.github.com/users/irmandos/repos","events_url":"https://api.github.com/users/irmandos/events{/privacy}","received_events_url":"https://api.github.com/users/irmandos/received_events","type":"User","site_admin":false},"repo":{"id":61412393,"name":"node-steam-chat-bot","full_name":"irmandos/node-steam-chat-bot","owner":{"login":"irmandos","id":5756234,"avatar_url":"https://avatars.githubusercontent.com/u/5756234?v=3","gravatar_id":"","url":"https://api.github.com/users/irmandos","html_url":"https://github.com/irmandos","followers_url":"https://api.github.com/users/irmandos/followers","following_url":"https://api.github.com/users/irmandos/following{/other_user}","gists_url":"https://api.github.com/users/irmandos/gists{/gist_id}","starred_url":"https://api.github.com/users/irmandos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irmandos/subscriptions","organizations_url":"https://api.github.com/users/irmandos/orgs","repos_url":"https://api.github.com/users/irmandos/repos","events_url":"https://api.github.com/users/irmandos/events{/privacy}","received_events_url":"https://api.github.com/users/irmandos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/irmandos/node-steam-chat-bot","description":"Simplified interface for a steam chat bot","fork":true,"url":"https://api.github.com/repos/irmandos/node-steam-chat-bot","forks_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/forks","keys_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/teams","hooks_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/hooks","issue_events_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/issues/events{/number}","events_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/events","assignees_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/assignees{/user}","branches_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/branches{/branch}","tags_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/tags","blobs_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/git/refs{/sha}","trees_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/statuses/{sha}","languages_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/languages","stargazers_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/stargazers","contributors_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/contributors","subscribers_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/subscribers","subscription_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/subscription","commits_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/commits{/sha}","git_commits_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/git/commits{/sha}","comments_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/comments{/number}","issue_comment_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/issues/comments{/number}","contents_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/contents/{+path}","compare_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/merges","archive_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/downloads","issues_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/issues{/number}","pulls_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/pulls{/number}","milestones_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/milestones{/number}","notifications_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/labels{/name}","releases_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/releases{/id}","deployments_url":"https://api.github.com/repos/irmandos/node-steam-chat-bot/deployments","created_at":"2016-06-18T02:04:41Z","updated_at":"2016-06-18T02:04:43Z","pushed_at":"2016-06-30T13:08:19Z","git_url":"git://github.com/irmandos/node-steam-chat-bot.git","ssh_url":"git@github.com:irmandos/node-steam-chat-bot.git","clone_url":"https://github.com/irmandos/node-steam-chat-bot.git","svn_url":"https://github.com/irmandos/node-steam-chat-bot","homepage":"","size":3392,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Steam-Chat-Bot:development","ref":"development","sha":"88137aee50caad511543641885168013be5dc9d4","user":{"login":"Steam-Chat-Bot","id":14515824,"avatar_url":"https://avatars.githubusercontent.com/u/14515824?v=3","gravatar_id":"","url":"https://api.github.com/users/Steam-Chat-Bot","html_url":"https://github.com/Steam-Chat-Bot","followers_url":"https://api.github.com/users/Steam-Chat-Bot/followers","following_url":"https://api.github.com/users/Steam-Chat-Bot/following{/other_user}","gists_url":"https://api.github.com/users/Steam-Chat-Bot/gists{/gist_id}","starred_url":"https://api.github.com/users/Steam-Chat-Bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Steam-Chat-Bot/subscriptions","organizations_url":"https://api.github.com/users/Steam-Chat-Bot/orgs","repos_url":"https://api.github.com/users/Steam-Chat-Bot/repos","events_url":"https://api.github.com/users/Steam-Chat-Bot/events{/privacy}","received_events_url":"https://api.github.com/users/Steam-Chat-Bot/received_events","type":"Organization","site_admin":false},"repo":{"id":11993347,"name":"node-steam-chat-bot","full_name":"Steam-Chat-Bot/node-steam-chat-bot","owner":{"login":"Steam-Chat-Bot","id":14515824,"avatar_url":"https://avatars.githubusercontent.com/u/14515824?v=3","gravatar_id":"","url":"https://api.github.com/users/Steam-Chat-Bot","html_url":"https://github.com/Steam-Chat-Bot","followers_url":"https://api.github.com/users/Steam-Chat-Bot/followers","following_url":"https://api.github.com/users/Steam-Chat-Bot/following{/other_user}","gists_url":"https://api.github.com/users/Steam-Chat-Bot/gists{/gist_id}","starred_url":"https://api.github.com/users/Steam-Chat-Bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Steam-Chat-Bot/subscriptions","organizations_url":"https://api.github.com/users/Steam-Chat-Bot/orgs","repos_url":"https://api.github.com/users/Steam-Chat-Bot/repos","events_url":"https://api.github.com/users/Steam-Chat-Bot/events{/privacy}","received_events_url":"https://api.github.com/users/Steam-Chat-Bot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Steam-Chat-Bot/node-steam-chat-bot","description":"Simplified interface for a steam chat bot","fork":false,"url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot","forks_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/forks","keys_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/teams","hooks_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/hooks","issue_events_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/issues/events{/number}","events_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/events","assignees_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/assignees{/user}","branches_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/branches{/branch}","tags_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/tags","blobs_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/git/refs{/sha}","trees_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/statuses/{sha}","languages_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/languages","stargazers_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/stargazers","contributors_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/contributors","subscribers_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/subscribers","subscription_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/subscription","commits_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/commits{/sha}","git_commits_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/git/commits{/sha}","comments_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/comments{/number}","issue_comment_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/issues/comments{/number}","contents_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/contents/{+path}","compare_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/merges","archive_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/downloads","issues_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/issues{/number}","pulls_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/pulls{/number}","milestones_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/milestones{/number}","notifications_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/labels{/name}","releases_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/releases{/id}","deployments_url":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/deployments","created_at":"2013-08-09T04:50:23Z","updated_at":"2016-08-04T10:19:54Z","pushed_at":"2016-06-18T02:20:28Z","git_url":"git://github.com/Steam-Chat-Bot/node-steam-chat-bot.git","ssh_url":"git@github.com:Steam-Chat-Bot/node-steam-chat-bot.git","clone_url":"https://github.com/Steam-Chat-Bot/node-steam-chat-bot.git","svn_url":"https://github.com/Steam-Chat-Bot/node-steam-chat-bot","homepage":"","size":4087,"stargazers_count":67,"watchers_count":67,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"open_issues_count":15,"forks":30,"open_issues":15,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/pulls/128"},"html":{"href":"https://github.com/Steam-Chat-Bot/node-steam-chat-bot/pull/128"},"issue":{"href":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/issues/128"},"comments":{"href":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/Steam-Chat-Bot/node-steam-chat-bot/statuses/1a39f473b87e6409d6e6b29f943bacb5fbdba294"}}}}
{"actor":{"display_login":"Efreak"}}