{"action":"created","issue":{"url":"https://api.github.com/repos/kylemcdonald/ofxFft/issues/9","repository_url":"https://api.github.com/repos/kylemcdonald/ofxFft","labels_url":"https://api.github.com/repos/kylemcdonald/ofxFft/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/kylemcdonald/ofxFft/issues/9/comments","events_url":"https://api.github.com/repos/kylemcdonald/ofxFft/issues/9/events","html_url":"https://github.com/kylemcdonald/ofxFft/pull/9","id":68732178,"number":9,"title":"replace ALLOW_FFTW with OFX_FFT_USE_FFTW & bufferSize fallback","user":{"login":"danomatika","id":480637,"avatar_url":"https://avatars.githubusercontent.com/u/480637?v=3","gravatar_id":"","url":"https://api.github.com/users/danomatika","html_url":"https://github.com/danomatika","followers_url":"https://api.github.com/users/danomatika/followers","following_url":"https://api.github.com/users/danomatika/following{/other_user}","gists_url":"https://api.github.com/users/danomatika/gists{/gist_id}","starred_url":"https://api.github.com/users/danomatika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danomatika/subscriptions","organizations_url":"https://api.github.com/users/danomatika/orgs","repos_url":"https://api.github.com/users/danomatika/repos","events_url":"https://api.github.com/users/danomatika/events{/privacy}","received_events_url":"https://api.github.com/users/danomatika/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-15T16:41:42Z","updated_at":"2016-04-14T16:22:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kylemcdonald/ofxFft/pulls/9","html_url":"https://github.com/kylemcdonald/ofxFft/pull/9","diff_url":"https://github.com/kylemcdonald/ofxFft/pull/9.diff","patch_url":"https://github.com/kylemcdonald/ofxFft/pull/9.patch"},"body":"Some updates after using ofxFft in a project:\r\n\r\n* Having to comment a define in addon source code is icky (ALLOW_FFTW was defined in the last commit). I removed the #define line, renamed it to OFX_FFT_USE_FFTW, and added info on how to set it in Makefiles/IDEs.\r\n\r\n* Logging a fatal error when the bufferSize is wrong didn't help much. Nicer to fallback to a correct size with a warning so at least everything works.\r\n\r\n* I think 44100 is a better default samplerate across the board."},"comment":{"url":"https://api.github.com/repos/kylemcdonald/ofxFft/issues/comments/210033053","html_url":"https://github.com/kylemcdonald/ofxFft/pull/9#issuecomment-210033053","issue_url":"https://api.github.com/repos/kylemcdonald/ofxFft/issues/9","id":210033053,"user":{"login":"danomatika","id":480637,"avatar_url":"https://avatars.githubusercontent.com/u/480637?v=3","gravatar_id":"","url":"https://api.github.com/users/danomatika","html_url":"https://github.com/danomatika","followers_url":"https://api.github.com/users/danomatika/followers","following_url":"https://api.github.com/users/danomatika/following{/other_user}","gists_url":"https://api.github.com/users/danomatika/gists{/gist_id}","starred_url":"https://api.github.com/users/danomatika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danomatika/subscriptions","organizations_url":"https://api.github.com/users/danomatika/orgs","repos_url":"https://api.github.com/users/danomatika/repos","events_url":"https://api.github.com/users/danomatika/events{/privacy}","received_events_url":"https://api.github.com/users/danomatika/received_events","type":"User","site_admin":false},"created_at":"2016-04-14T16:22:21Z","updated_at":"2016-04-14T16:22:21Z","body":"still working, do not merge yet"}}