{"action":"created","comment":{"url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/pulls/comments/79375366","id":79375366,"diff_hunk":"@@ -0,0 +1,85 @@\n+// List Grid\n+@mixin vf-p-matrix {\n+\n+  .p-matrix {\n+    list-style: none;\n+    margin: 0;\n+    padding: 0;\n+\n+    &__item {\n+      @extend %clearfix;","path":"scss/_patterns_matrix.scss","position":10,"original_position":10,"commit_id":"0576965e01552cb1262287c38e7409c92b2188b3","original_commit_id":"569b97a1ea25e3b66ea132df8b33aa84e7b7d069","user":{"login":"barrymcgee","id":505570,"avatar_url":"https://avatars.githubusercontent.com/u/505570?v=3","gravatar_id":"","url":"https://api.github.com/users/barrymcgee","html_url":"https://github.com/barrymcgee","followers_url":"https://api.github.com/users/barrymcgee/followers","following_url":"https://api.github.com/users/barrymcgee/following{/other_user}","gists_url":"https://api.github.com/users/barrymcgee/gists{/gist_id}","starred_url":"https://api.github.com/users/barrymcgee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barrymcgee/subscriptions","organizations_url":"https://api.github.com/users/barrymcgee/orgs","repos_url":"https://api.github.com/users/barrymcgee/repos","events_url":"https://api.github.com/users/barrymcgee/events{/privacy}","received_events_url":"https://api.github.com/users/barrymcgee/received_events","type":"User","site_admin":false},"body":"No, using extend here negates the need to add it onto the element directly?","created_at":"2016-09-19T11:59:48Z","updated_at":"2016-09-19T11:59:48Z","html_url":"https://github.com/ubuntudesign/vanilla-framework/pull/668#discussion_r79375366","pull_request_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/pulls/668","_links":{"self":{"href":"https://api.github.com/repos/ubuntudesign/vanilla-framework/pulls/comments/79375366"},"html":{"href":"https://github.com/ubuntudesign/vanilla-framework/pull/668#discussion_r79375366"},"pull_request":{"href":"https://api.github.com/repos/ubuntudesign/vanilla-framework/pulls/668"}}},"pull_request":{"url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/pulls/668","id":85606562,"html_url":"https://github.com/ubuntudesign/vanilla-framework/pull/668","diff_url":"https://github.com/ubuntudesign/vanilla-framework/pull/668.diff","patch_url":"https://github.com/ubuntudesign/vanilla-framework/pull/668.patch","issue_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/issues/668","number":668,"state":"open","locked":false,"title":"Rename Grid list to Matrix","user":{"login":"barrymcgee","id":505570,"avatar_url":"https://avatars.githubusercontent.com/u/505570?v=3","gravatar_id":"","url":"https://api.github.com/users/barrymcgee","html_url":"https://github.com/barrymcgee","followers_url":"https://api.github.com/users/barrymcgee/followers","following_url":"https://api.github.com/users/barrymcgee/following{/other_user}","gists_url":"https://api.github.com/users/barrymcgee/gists{/gist_id}","starred_url":"https://api.github.com/users/barrymcgee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barrymcgee/subscriptions","organizations_url":"https://api.github.com/users/barrymcgee/orgs","repos_url":"https://api.github.com/users/barrymcgee/repos","events_url":"https://api.github.com/users/barrymcgee/events{/privacy}","received_events_url":"https://api.github.com/users/barrymcgee/received_events","type":"User","site_admin":false},"body":"## Done\r\n\r\n- Rename `.p-grid-list` to matrix\r\n- Rewrote all styling to make it responsive and ensure the pattern no longer relies on grid classes or `.last-row / .last-col` classes\r\n- Amended grid to remove margin-bottom of directly descendant children of `.row` and `.col-*` to prevent double bottom margin bug\r\n\r\n## QA\r\n\r\n- Check code\r\n- Sync with vf.io and check pattern/matrix across breakpoints\r\n- Check against demo - https://vf-io-7e29b.firebaseapp.com/patterns/matrix/\r\n\r\n## Details\r\n\r\nFixes #631 #625\r\n","created_at":"2016-09-16T17:00:24Z","updated_at":"2016-09-19T11:59:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7c0c5da7b4a328b116f9acf92a4d8fff5207bdb","assignee":{"login":"anthonydillon","id":1413534,"avatar_url":"https://avatars.githubusercontent.com/u/1413534?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonydillon","html_url":"https://github.com/anthonydillon","followers_url":"https://api.github.com/users/anthonydillon/followers","following_url":"https://api.github.com/users/anthonydillon/following{/other_user}","gists_url":"https://api.github.com/users/anthonydillon/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonydillon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonydillon/subscriptions","organizations_url":"https://api.github.com/users/anthonydillon/orgs","repos_url":"https://api.github.com/users/anthonydillon/repos","events_url":"https://api.github.com/users/anthonydillon/events{/privacy}","received_events_url":"https://api.github.com/users/anthonydillon/received_events","type":"User","site_admin":false},"assignees":[{"login":"anthonydillon","id":1413534,"avatar_url":"https://avatars.githubusercontent.com/u/1413534?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonydillon","html_url":"https://github.com/anthonydillon","followers_url":"https://api.github.com/users/anthonydillon/followers","following_url":"https://api.github.com/users/anthonydillon/following{/other_user}","gists_url":"https://api.github.com/users/anthonydillon/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonydillon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonydillon/subscriptions","organizations_url":"https://api.github.com/users/anthonydillon/orgs","repos_url":"https://api.github.com/users/anthonydillon/repos","events_url":"https://api.github.com/users/anthonydillon/events{/privacy}","received_events_url":"https://api.github.com/users/anthonydillon/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/milestones/1","html_url":"https://github.com/ubuntudesign/vanilla-framework/milestones/v1.0","labels_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/milestones/1/labels","id":1813794,"number":1,"title":"v1.0","description":"","creator":{"login":"barrymcgee","id":505570,"avatar_url":"https://avatars.githubusercontent.com/u/505570?v=3","gravatar_id":"","url":"https://api.github.com/users/barrymcgee","html_url":"https://github.com/barrymcgee","followers_url":"https://api.github.com/users/barrymcgee/followers","following_url":"https://api.github.com/users/barrymcgee/following{/other_user}","gists_url":"https://api.github.com/users/barrymcgee/gists{/gist_id}","starred_url":"https://api.github.com/users/barrymcgee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barrymcgee/subscriptions","organizations_url":"https://api.github.com/users/barrymcgee/orgs","repos_url":"https://api.github.com/users/barrymcgee/repos","events_url":"https://api.github.com/users/barrymcgee/events{/privacy}","received_events_url":"https://api.github.com/users/barrymcgee/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":192,"state":"open","created_at":"2016-06-07T16:00:20Z","updated_at":"2016-09-19T11:21:37Z","due_on":"2016-09-20T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/pulls/668/commits","review_comments_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/pulls/668/comments","review_comment_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/issues/668/comments","statuses_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/statuses/0576965e01552cb1262287c38e7409c92b2188b3","head":{"label":"barrymcgee:625-grid-list-matrix","ref":"625-grid-list-matrix","sha":"0576965e01552cb1262287c38e7409c92b2188b3","user":{"login":"barrymcgee","id":505570,"avatar_url":"https://avatars.githubusercontent.com/u/505570?v=3","gravatar_id":"","url":"https://api.github.com/users/barrymcgee","html_url":"https://github.com/barrymcgee","followers_url":"https://api.github.com/users/barrymcgee/followers","following_url":"https://api.github.com/users/barrymcgee/following{/other_user}","gists_url":"https://api.github.com/users/barrymcgee/gists{/gist_id}","starred_url":"https://api.github.com/users/barrymcgee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barrymcgee/subscriptions","organizations_url":"https://api.github.com/users/barrymcgee/orgs","repos_url":"https://api.github.com/users/barrymcgee/repos","events_url":"https://api.github.com/users/barrymcgee/events{/privacy}","received_events_url":"https://api.github.com/users/barrymcgee/received_events","type":"User","site_admin":false},"repo":{"id":49716768,"name":"vanilla-framework","full_name":"barrymcgee/vanilla-framework","owner":{"login":"barrymcgee","id":505570,"avatar_url":"https://avatars.githubusercontent.com/u/505570?v=3","gravatar_id":"","url":"https://api.github.com/users/barrymcgee","html_url":"https://github.com/barrymcgee","followers_url":"https://api.github.com/users/barrymcgee/followers","following_url":"https://api.github.com/users/barrymcgee/following{/other_user}","gists_url":"https://api.github.com/users/barrymcgee/gists{/gist_id}","starred_url":"https://api.github.com/users/barrymcgee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barrymcgee/subscriptions","organizations_url":"https://api.github.com/users/barrymcgee/orgs","repos_url":"https://api.github.com/users/barrymcgee/repos","events_url":"https://api.github.com/users/barrymcgee/events{/privacy}","received_events_url":"https://api.github.com/users/barrymcgee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/barrymcgee/vanilla-framework","description":"From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.","fork":true,"url":"https://api.github.com/repos/barrymcgee/vanilla-framework","forks_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/forks","keys_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/teams","hooks_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/hooks","issue_events_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/issues/events{/number}","events_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/events","assignees_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/assignees{/user}","branches_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/branches{/branch}","tags_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/tags","blobs_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/languages","stargazers_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/stargazers","contributors_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/contributors","subscribers_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/subscribers","subscription_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/subscription","commits_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/contents/{+path}","compare_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/merges","archive_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/downloads","issues_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/issues{/number}","pulls_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/labels{/name}","releases_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/releases{/id}","deployments_url":"https://api.github.com/repos/barrymcgee/vanilla-framework/deployments","created_at":"2016-01-15T12:10:02Z","updated_at":"2016-01-15T12:10:03Z","pushed_at":"2016-09-19T11:56:39Z","git_url":"git://github.com/barrymcgee/vanilla-framework.git","ssh_url":"git@github.com:barrymcgee/vanilla-framework.git","clone_url":"https://github.com/barrymcgee/vanilla-framework.git","svn_url":"https://github.com/barrymcgee/vanilla-framework","homepage":"http://ubuntudesign.github.io/vanilla-framework","size":1117,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ubuntudesign:master","ref":"master","sha":"24f08f41b66bc0a464893362d6269c1bbcfa6447","user":{"login":"ubuntudesign","id":8777739,"avatar_url":"https://avatars.githubusercontent.com/u/8777739?v=3","gravatar_id":"","url":"https://api.github.com/users/ubuntudesign","html_url":"https://github.com/ubuntudesign","followers_url":"https://api.github.com/users/ubuntudesign/followers","following_url":"https://api.github.com/users/ubuntudesign/following{/other_user}","gists_url":"https://api.github.com/users/ubuntudesign/gists{/gist_id}","starred_url":"https://api.github.com/users/ubuntudesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubuntudesign/subscriptions","organizations_url":"https://api.github.com/users/ubuntudesign/orgs","repos_url":"https://api.github.com/users/ubuntudesign/repos","events_url":"https://api.github.com/users/ubuntudesign/events{/privacy}","received_events_url":"https://api.github.com/users/ubuntudesign/received_events","type":"Organization","site_admin":false},"repo":{"id":31207344,"name":"vanilla-framework","full_name":"ubuntudesign/vanilla-framework","owner":{"login":"ubuntudesign","id":8777739,"avatar_url":"https://avatars.githubusercontent.com/u/8777739?v=3","gravatar_id":"","url":"https://api.github.com/users/ubuntudesign","html_url":"https://github.com/ubuntudesign","followers_url":"https://api.github.com/users/ubuntudesign/followers","following_url":"https://api.github.com/users/ubuntudesign/following{/other_user}","gists_url":"https://api.github.com/users/ubuntudesign/gists{/gist_id}","starred_url":"https://api.github.com/users/ubuntudesign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubuntudesign/subscriptions","organizations_url":"https://api.github.com/users/ubuntudesign/orgs","repos_url":"https://api.github.com/users/ubuntudesign/repos","events_url":"https://api.github.com/users/ubuntudesign/events{/privacy}","received_events_url":"https://api.github.com/users/ubuntudesign/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubuntudesign/vanilla-framework","description":"From community websites to web applications, this CSS framework will help you achieve a consistent look and feel.","fork":false,"url":"https://api.github.com/repos/ubuntudesign/vanilla-framework","forks_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/forks","keys_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/teams","hooks_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/hooks","issue_events_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/issues/events{/number}","events_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/events","assignees_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/assignees{/user}","branches_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/branches{/branch}","tags_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/tags","blobs_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/languages","stargazers_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/stargazers","contributors_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/contributors","subscribers_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/subscribers","subscription_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/subscription","commits_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/contents/{+path}","compare_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/merges","archive_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/downloads","issues_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/issues{/number}","pulls_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/labels{/name}","releases_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/releases{/id}","deployments_url":"https://api.github.com/repos/ubuntudesign/vanilla-framework/deployments","created_at":"2015-02-23T12:34:16Z","updated_at":"2016-09-14T19:52:56Z","pushed_at":"2016-09-19T11:56:39Z","git_url":"git://github.com/ubuntudesign/vanilla-framework.git","ssh_url":"git@github.com:ubuntudesign/vanilla-framework.git","clone_url":"https://github.com/ubuntudesign/vanilla-framework.git","svn_url":"https://github.com/ubuntudesign/vanilla-framework","homepage":"http://ubuntudesign.github.io/vanilla-framework","size":1554,"stargazers_count":89,"watchers_count":89,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":34,"forks":19,"open_issues":34,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ubuntudesign/vanilla-framework/pulls/668"},"html":{"href":"https://github.com/ubuntudesign/vanilla-framework/pull/668"},"issue":{"href":"https://api.github.com/repos/ubuntudesign/vanilla-framework/issues/668"},"comments":{"href":"https://api.github.com/repos/ubuntudesign/vanilla-framework/issues/668/comments"},"review_comments":{"href":"https://api.github.com/repos/ubuntudesign/vanilla-framework/pulls/668/comments"},"review_comment":{"href":"https://api.github.com/repos/ubuntudesign/vanilla-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ubuntudesign/vanilla-framework/pulls/668/commits"},"statuses":{"href":"https://api.github.com/repos/ubuntudesign/vanilla-framework/statuses/0576965e01552cb1262287c38e7409c92b2188b3"}}}}
{"actor":{"display_login":"barrymcgee"}}