{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/79818752","id":79818752,"diff_hunk":"@@ -337,18 +346,64 @@ func (c Config) New() (*GenericAPIServer, error) {\n \t\t})\n \t}\n \n+\tif len(c.AuditLogPath) != 0 {","path":"pkg/genericapiserver/config.go","position":51,"original_position":51,"commit_id":"7da57ea2ba928defac65e3ec36967b16c60dbd54","original_commit_id":"7da57ea2ba928defac65e3ec36967b16c60dbd54","user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"body":"Let's add to our running issue.  I think all the audit stuff should be gathered up into a pointer to a struct.","created_at":"2016-09-21T12:14:20Z","updated_at":"2016-09-21T12:14:20Z","html_url":"https://github.com/kubernetes/kubernetes/pull/33164#discussion_r79818752","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33164","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/79818752"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/33164#discussion_r79818752"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33164"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33164","id":86129165,"html_url":"https://github.com/kubernetes/kubernetes/pull/33164","diff_url":"https://github.com/kubernetes/kubernetes/pull/33164.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/33164.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/33164","number":33164,"state":"open","locked":false,"title":"WIP: Cleanup genericapiserver handler chain","user":{"login":"sttts","id":730123,"avatar_url":"https://avatars.githubusercontent.com/u/730123?v=3","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"body":"- move generic (api independent) handler filters to `pkg/genericapiserver/filters`\r\n- entangle `genericapiserver.New()`\r\n- unify signature of all handler filters (also those in `pkg/apiserver`)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/33164)\n<!-- Reviewable:end -->\n","created_at":"2016-09-21T09:42:44Z","updated_at":"2016-09-21T12:14:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8eb3c23fbb69049d568c0419b434dfe8b4c0f17d","assignee":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"assignees":[{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33164/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33164/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/33164/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/7da57ea2ba928defac65e3ec36967b16c60dbd54","head":{"label":"sttts:sttts-handler-chain-cleanup","ref":"sttts-handler-chain-cleanup","sha":"7da57ea2ba928defac65e3ec36967b16c60dbd54","user":{"login":"sttts","id":730123,"avatar_url":"https://avatars.githubusercontent.com/u/730123?v=3","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"repo":{"id":36099048,"name":"kubernetes","full_name":"sttts/kubernetes","owner":{"login":"sttts","id":730123,"avatar_url":"https://avatars.githubusercontent.com/u/730123?v=3","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sttts/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/sttts/kubernetes","forks_url":"https://api.github.com/repos/sttts/kubernetes/forks","keys_url":"https://api.github.com/repos/sttts/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sttts/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sttts/kubernetes/teams","hooks_url":"https://api.github.com/repos/sttts/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/sttts/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/sttts/kubernetes/events","assignees_url":"https://api.github.com/repos/sttts/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/sttts/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/sttts/kubernetes/tags","blobs_url":"https://api.github.com/repos/sttts/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sttts/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sttts/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/sttts/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sttts/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/sttts/kubernetes/languages","stargazers_url":"https://api.github.com/repos/sttts/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/sttts/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/sttts/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/sttts/kubernetes/subscription","commits_url":"https://api.github.com/repos/sttts/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/sttts/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/sttts/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/sttts/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/sttts/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/sttts/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sttts/kubernetes/merges","archive_url":"https://api.github.com/repos/sttts/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sttts/kubernetes/downloads","issues_url":"https://api.github.com/repos/sttts/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/sttts/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/sttts/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/sttts/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sttts/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/sttts/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/sttts/kubernetes/deployments","created_at":"2015-05-22T23:09:55Z","updated_at":"2015-05-22T23:10:00Z","pushed_at":"2016-09-21T11:59:01Z","git_url":"git://github.com/sttts/kubernetes.git","ssh_url":"git@github.com:sttts/kubernetes.git","clone_url":"https://github.com/sttts/kubernetes.git","svn_url":"https://github.com/sttts/kubernetes","homepage":null,"size":318697,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"4099a5cc98e357e10aff90c845faede838e26064","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-09-21T12:09:24Z","pushed_at":"2016-09-21T12:13:39Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":567433,"stargazers_count":16955,"watchers_count":16955,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5479,"mirror_url":null,"open_issues_count":4534,"forks":5479,"open_issues":4534,"watchers":16955,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33164"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/33164"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/33164"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/33164/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33164/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33164/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/7da57ea2ba928defac65e3ec36967b16c60dbd54"}}}}
{"actor":{"display_login":"deads2k"}}