{"action":"opened","number":8327,"pull_request":{"url":"https://api.github.com/repos/openscholar/openscholar/pulls/8327","id":67264417,"html_url":"https://github.com/openscholar/openscholar/pull/8327","diff_url":"https://github.com/openscholar/openscholar/pull/8327.diff","patch_url":"https://github.com/openscholar/openscholar/pull/8327.patch","issue_url":"https://api.github.com/repos/openscholar/openscholar/issues/8327","number":8327,"state":"open","locked":false,"title":"fix: expression always true","user":{"login":"AppChecker","id":15096165,"avatar_url":"https://avatars.githubusercontent.com/u/15096165?v=3","gravatar_id":"","url":"https://api.github.com/users/AppChecker","html_url":"https://github.com/AppChecker","followers_url":"https://api.github.com/users/AppChecker/followers","following_url":"https://api.github.com/users/AppChecker/following{/other_user}","gists_url":"https://api.github.com/users/AppChecker/gists{/gist_id}","starred_url":"https://api.github.com/users/AppChecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppChecker/subscriptions","organizations_url":"https://api.github.com/users/AppChecker/orgs","repos_url":"https://api.github.com/users/AppChecker/repos","events_url":"https://api.github.com/users/AppChecker/events{/privacy}","received_events_url":"https://api.github.com/users/AppChecker/received_events","type":"User","site_admin":false},"body":"Expression\r\n`($twitkey[0] != '@' || $twitkey[0] != '#')`\r\nis always true.\r\n\r\n1. if $twitkey[0]  is '@' then ($twitkey[0] != '#') is true -> whole expression is true \r\n2. if $twitkey[0]  is '#' then ($twitkey[0] != '@') is true -> whole expression is true \r\n3. if $twitkey[0]  is 'some_other_symbol' then ($twitkey[0] != '@') is true -> whole expression is true \r\n\r\n\r\nThis possible defect found by [Static code analyzer AppСhecker](cnpo.ru/en/solutions/appchecker.php)","created_at":"2016-04-20T21:49:50Z","updated_at":"2016-04-20T21:49:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openscholar/openscholar/pulls/8327/commits","review_comments_url":"https://api.github.com/repos/openscholar/openscholar/pulls/8327/comments","review_comment_url":"https://api.github.com/repos/openscholar/openscholar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openscholar/openscholar/issues/8327/comments","statuses_url":"https://api.github.com/repos/openscholar/openscholar/statuses/5f800a0dea68e6b7732f05fd4eb1d1c26cb2fb80","head":{"label":"AppChecker:SCHOLAR-3.x","ref":"SCHOLAR-3.x","sha":"5f800a0dea68e6b7732f05fd4eb1d1c26cb2fb80","user":{"login":"AppChecker","id":15096165,"avatar_url":"https://avatars.githubusercontent.com/u/15096165?v=3","gravatar_id":"","url":"https://api.github.com/users/AppChecker","html_url":"https://github.com/AppChecker","followers_url":"https://api.github.com/users/AppChecker/followers","following_url":"https://api.github.com/users/AppChecker/following{/other_user}","gists_url":"https://api.github.com/users/AppChecker/gists{/gist_id}","starred_url":"https://api.github.com/users/AppChecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppChecker/subscriptions","organizations_url":"https://api.github.com/users/AppChecker/orgs","repos_url":"https://api.github.com/users/AppChecker/repos","events_url":"https://api.github.com/users/AppChecker/events{/privacy}","received_events_url":"https://api.github.com/users/AppChecker/received_events","type":"User","site_admin":false},"repo":{"id":56723091,"name":"openscholar","full_name":"AppChecker/openscholar","owner":{"login":"AppChecker","id":15096165,"avatar_url":"https://avatars.githubusercontent.com/u/15096165?v=3","gravatar_id":"","url":"https://api.github.com/users/AppChecker","html_url":"https://github.com/AppChecker","followers_url":"https://api.github.com/users/AppChecker/followers","following_url":"https://api.github.com/users/AppChecker/following{/other_user}","gists_url":"https://api.github.com/users/AppChecker/gists{/gist_id}","starred_url":"https://api.github.com/users/AppChecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppChecker/subscriptions","organizations_url":"https://api.github.com/users/AppChecker/orgs","repos_url":"https://api.github.com/users/AppChecker/repos","events_url":"https://api.github.com/users/AppChecker/events{/privacy}","received_events_url":"https://api.github.com/users/AppChecker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AppChecker/openscholar","description":"OpenScholar project ","fork":true,"url":"https://api.github.com/repos/AppChecker/openscholar","forks_url":"https://api.github.com/repos/AppChecker/openscholar/forks","keys_url":"https://api.github.com/repos/AppChecker/openscholar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppChecker/openscholar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppChecker/openscholar/teams","hooks_url":"https://api.github.com/repos/AppChecker/openscholar/hooks","issue_events_url":"https://api.github.com/repos/AppChecker/openscholar/issues/events{/number}","events_url":"https://api.github.com/repos/AppChecker/openscholar/events","assignees_url":"https://api.github.com/repos/AppChecker/openscholar/assignees{/user}","branches_url":"https://api.github.com/repos/AppChecker/openscholar/branches{/branch}","tags_url":"https://api.github.com/repos/AppChecker/openscholar/tags","blobs_url":"https://api.github.com/repos/AppChecker/openscholar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppChecker/openscholar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppChecker/openscholar/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppChecker/openscholar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppChecker/openscholar/statuses/{sha}","languages_url":"https://api.github.com/repos/AppChecker/openscholar/languages","stargazers_url":"https://api.github.com/repos/AppChecker/openscholar/stargazers","contributors_url":"https://api.github.com/repos/AppChecker/openscholar/contributors","subscribers_url":"https://api.github.com/repos/AppChecker/openscholar/subscribers","subscription_url":"https://api.github.com/repos/AppChecker/openscholar/subscription","commits_url":"https://api.github.com/repos/AppChecker/openscholar/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppChecker/openscholar/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppChecker/openscholar/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppChecker/openscholar/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppChecker/openscholar/contents/{+path}","compare_url":"https://api.github.com/repos/AppChecker/openscholar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppChecker/openscholar/merges","archive_url":"https://api.github.com/repos/AppChecker/openscholar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppChecker/openscholar/downloads","issues_url":"https://api.github.com/repos/AppChecker/openscholar/issues{/number}","pulls_url":"https://api.github.com/repos/AppChecker/openscholar/pulls{/number}","milestones_url":"https://api.github.com/repos/AppChecker/openscholar/milestones{/number}","notifications_url":"https://api.github.com/repos/AppChecker/openscholar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppChecker/openscholar/labels{/name}","releases_url":"https://api.github.com/repos/AppChecker/openscholar/releases{/id}","deployments_url":"https://api.github.com/repos/AppChecker/openscholar/deployments","created_at":"2016-04-20T21:45:17Z","updated_at":"2016-04-20T21:45:27Z","pushed_at":"2016-04-20T21:46:51Z","git_url":"git://github.com/AppChecker/openscholar.git","ssh_url":"git@github.com:AppChecker/openscholar.git","clone_url":"https://github.com/AppChecker/openscholar.git","svn_url":"https://github.com/AppChecker/openscholar","homepage":"http://theopenscholar.org","size":146758,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"SCHOLAR-3.x"}},"base":{"label":"openscholar:SCHOLAR-3.x","ref":"SCHOLAR-3.x","sha":"cab42cafc6aa8df795e2379fde3cf7bf83d3c8a0","user":{"login":"openscholar","id":611073,"avatar_url":"https://avatars.githubusercontent.com/u/611073?v=3","gravatar_id":"","url":"https://api.github.com/users/openscholar","html_url":"https://github.com/openscholar","followers_url":"https://api.github.com/users/openscholar/followers","following_url":"https://api.github.com/users/openscholar/following{/other_user}","gists_url":"https://api.github.com/users/openscholar/gists{/gist_id}","starred_url":"https://api.github.com/users/openscholar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openscholar/subscriptions","organizations_url":"https://api.github.com/users/openscholar/orgs","repos_url":"https://api.github.com/users/openscholar/repos","events_url":"https://api.github.com/users/openscholar/events{/privacy}","received_events_url":"https://api.github.com/users/openscholar/received_events","type":"Organization","site_admin":false},"repo":{"id":1440092,"name":"openscholar","full_name":"openscholar/openscholar","owner":{"login":"openscholar","id":611073,"avatar_url":"https://avatars.githubusercontent.com/u/611073?v=3","gravatar_id":"","url":"https://api.github.com/users/openscholar","html_url":"https://github.com/openscholar","followers_url":"https://api.github.com/users/openscholar/followers","following_url":"https://api.github.com/users/openscholar/following{/other_user}","gists_url":"https://api.github.com/users/openscholar/gists{/gist_id}","starred_url":"https://api.github.com/users/openscholar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openscholar/subscriptions","organizations_url":"https://api.github.com/users/openscholar/orgs","repos_url":"https://api.github.com/users/openscholar/repos","events_url":"https://api.github.com/users/openscholar/events{/privacy}","received_events_url":"https://api.github.com/users/openscholar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openscholar/openscholar","description":"OpenScholar project ","fork":false,"url":"https://api.github.com/repos/openscholar/openscholar","forks_url":"https://api.github.com/repos/openscholar/openscholar/forks","keys_url":"https://api.github.com/repos/openscholar/openscholar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openscholar/openscholar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openscholar/openscholar/teams","hooks_url":"https://api.github.com/repos/openscholar/openscholar/hooks","issue_events_url":"https://api.github.com/repos/openscholar/openscholar/issues/events{/number}","events_url":"https://api.github.com/repos/openscholar/openscholar/events","assignees_url":"https://api.github.com/repos/openscholar/openscholar/assignees{/user}","branches_url":"https://api.github.com/repos/openscholar/openscholar/branches{/branch}","tags_url":"https://api.github.com/repos/openscholar/openscholar/tags","blobs_url":"https://api.github.com/repos/openscholar/openscholar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openscholar/openscholar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openscholar/openscholar/git/refs{/sha}","trees_url":"https://api.github.com/repos/openscholar/openscholar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openscholar/openscholar/statuses/{sha}","languages_url":"https://api.github.com/repos/openscholar/openscholar/languages","stargazers_url":"https://api.github.com/repos/openscholar/openscholar/stargazers","contributors_url":"https://api.github.com/repos/openscholar/openscholar/contributors","subscribers_url":"https://api.github.com/repos/openscholar/openscholar/subscribers","subscription_url":"https://api.github.com/repos/openscholar/openscholar/subscription","commits_url":"https://api.github.com/repos/openscholar/openscholar/commits{/sha}","git_commits_url":"https://api.github.com/repos/openscholar/openscholar/git/commits{/sha}","comments_url":"https://api.github.com/repos/openscholar/openscholar/comments{/number}","issue_comment_url":"https://api.github.com/repos/openscholar/openscholar/issues/comments{/number}","contents_url":"https://api.github.com/repos/openscholar/openscholar/contents/{+path}","compare_url":"https://api.github.com/repos/openscholar/openscholar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openscholar/openscholar/merges","archive_url":"https://api.github.com/repos/openscholar/openscholar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openscholar/openscholar/downloads","issues_url":"https://api.github.com/repos/openscholar/openscholar/issues{/number}","pulls_url":"https://api.github.com/repos/openscholar/openscholar/pulls{/number}","milestones_url":"https://api.github.com/repos/openscholar/openscholar/milestones{/number}","notifications_url":"https://api.github.com/repos/openscholar/openscholar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openscholar/openscholar/labels{/name}","releases_url":"https://api.github.com/repos/openscholar/openscholar/releases{/id}","deployments_url":"https://api.github.com/repos/openscholar/openscholar/deployments","created_at":"2011-03-04T16:39:08Z","updated_at":"2016-04-16T10:03:51Z","pushed_at":"2016-04-20T20:57:22Z","git_url":"git://github.com/openscholar/openscholar.git","ssh_url":"git@github.com:openscholar/openscholar.git","clone_url":"https://github.com/openscholar/openscholar.git","svn_url":"https://github.com/openscholar/openscholar","homepage":"http://theopenscholar.org","size":189213,"stargazers_count":157,"watchers_count":157,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":421,"forks":80,"open_issues":421,"watchers":157,"default_branch":"SCHOLAR-3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/openscholar/openscholar/pulls/8327"},"html":{"href":"https://github.com/openscholar/openscholar/pull/8327"},"issue":{"href":"https://api.github.com/repos/openscholar/openscholar/issues/8327"},"comments":{"href":"https://api.github.com/repos/openscholar/openscholar/issues/8327/comments"},"review_comments":{"href":"https://api.github.com/repos/openscholar/openscholar/pulls/8327/comments"},"review_comment":{"href":"https://api.github.com/repos/openscholar/openscholar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openscholar/openscholar/pulls/8327/commits"},"statuses":{"href":"https://api.github.com/repos/openscholar/openscholar/statuses/5f800a0dea68e6b7732f05fd4eb1d1c26cb2fb80"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}