{"action":"created","issue":{"url":"https://api.github.com/repos/jeske/SimpleHttpServer/issues/5","repository_url":"https://api.github.com/repos/jeske/SimpleHttpServer","labels_url":"https://api.github.com/repos/jeske/SimpleHttpServer/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/jeske/SimpleHttpServer/issues/5/comments","events_url":"https://api.github.com/repos/jeske/SimpleHttpServer/issues/5/events","html_url":"https://github.com/jeske/SimpleHttpServer/pull/5","id":162891096,"number":5,"title":"Tests, Refactoring, Project Structure","user":{"login":"developersworkspace","id":17405891,"avatar_url":"https://avatars.githubusercontent.com/u/17405891?v=3","gravatar_id":"","url":"https://api.github.com/users/developersworkspace","html_url":"https://github.com/developersworkspace","followers_url":"https://api.github.com/users/developersworkspace/followers","following_url":"https://api.github.com/users/developersworkspace/following{/other_user}","gists_url":"https://api.github.com/users/developersworkspace/gists{/gist_id}","starred_url":"https://api.github.com/users/developersworkspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/developersworkspace/subscriptions","organizations_url":"https://api.github.com/users/developersworkspace/orgs","repos_url":"https://api.github.com/users/developersworkspace/repos","events_url":"https://api.github.com/users/developersworkspace/events{/privacy}","received_events_url":"https://api.github.com/users/developersworkspace/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-06-29T10:21:37Z","updated_at":"2016-06-30T19:02:11Z","closed_at":"2016-06-30T15:43:45Z","pull_request":{"url":"https://api.github.com/repos/jeske/SimpleHttpServer/pulls/5","html_url":"https://github.com/jeske/SimpleHttpServer/pull/5","diff_url":"https://github.com/jeske/SimpleHttpServer/pull/5.diff","patch_url":"https://github.com/jeske/SimpleHttpServer/pull/5.patch"},"body":"Added the first unit test.\r\nChanged the project structure.\r\nRefactoring."},"comment":{"url":"https://api.github.com/repos/jeske/SimpleHttpServer/issues/comments/229756662","html_url":"https://github.com/jeske/SimpleHttpServer/pull/5#issuecomment-229756662","issue_url":"https://api.github.com/repos/jeske/SimpleHttpServer/issues/5","id":229756662,"user":{"login":"jeske","id":15093,"avatar_url":"https://avatars.githubusercontent.com/u/15093?v=3","gravatar_id":"","url":"https://api.github.com/users/jeske","html_url":"https://github.com/jeske","followers_url":"https://api.github.com/users/jeske/followers","following_url":"https://api.github.com/users/jeske/following{/other_user}","gists_url":"https://api.github.com/users/jeske/gists{/gist_id}","starred_url":"https://api.github.com/users/jeske/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeske/subscriptions","organizations_url":"https://api.github.com/users/jeske/orgs","repos_url":"https://api.github.com/users/jeske/repos","events_url":"https://api.github.com/users/jeske/events{/privacy}","received_events_url":"https://api.github.com/users/jeske/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T19:02:11Z","updated_at":"2016-06-30T19:02:11Z","body":"FYI, looking more closely at this code I've noticed some bugs. I'm fixing these bugs in my tree, and I just want you to be aware of them in case you are using your code. \r\n\r\n(1) FileSystemRouteHandler doesn't sanitize paths, which is a security problem\r\n\r\n(2) The concept of using a .NET unicode \"string\" for the response content is problematic. For example, FileSystemRouteHandler is not \"8bit clean\" for sending files. File.ReadAllText() uses the system default encoding to read file contents. This means it can't be used to send binary image data properly.\r\n\r\n(3) FileSystemRouteHandler does not set a proper Content-Type header for the file, which will cause browsers to handle different file types badly"}}
{"actor":{"display_login":"jeske"}}