{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/34059","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/34059/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/34059/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/34059/events","html_url":"https://github.com/saltstack/salt/pull/34059","id":160619842,"number":34059,"title":"Vmware common gh","user":{"login":"alexbleotu","id":17009281,"avatar_url":"https://avatars.githubusercontent.com/u/17009281?v=3","gravatar_id":"","url":"https://api.github.com/users/alexbleotu","html_url":"https://github.com/alexbleotu","followers_url":"https://api.github.com/users/alexbleotu/followers","following_url":"https://api.github.com/users/alexbleotu/following{/other_user}","gists_url":"https://api.github.com/users/alexbleotu/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbleotu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbleotu/subscriptions","organizations_url":"https://api.github.com/users/alexbleotu/orgs","repos_url":"https://api.github.com/users/alexbleotu/repos","events_url":"https://api.github.com/users/alexbleotu/events{/privacy}","received_events_url":"https://api.github.com/users/alexbleotu/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/saltstack/salt/labels/Pending%20Discussion","name":"Pending Discussion","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2016-06-16T09:41:13Z","updated_at":"2016-06-17T12:31:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/34059","html_url":"https://github.com/saltstack/salt/pull/34059","diff_url":"https://github.com/saltstack/salt/pull/34059.diff","patch_url":"https://github.com/saltstack/salt/pull/34059.patch"},"body":"### What does this PR do?\r\nImproved salt.utils.vmware.get_content, get_mors_with_properties\r\n    \r\n- added optional traversal_spec parameter to both methods, allowing the user to specify a different TraversalSpec object to search for content (if not specified, the behaviour is that all a traverse all search is done)\r\n- the traversal_spec is destroyed only if is created in the method\r\n- added tests for the 2 functions\r\n\r\nImproved salt.utils.vmware.wait_for_task\r\n    \r\n- improved logging/description\r\n- on success the method returns the result and on error it raises the exception it got from vmware\r\n- added unit tests\r\n\r\nImproved connection to a VMware vCenter Server or ESXi host\r\n    \r\n- added support for passthrough connections via SSPI\r\n- added function to specify if a connection is made to a vCenter or ESXi host\r\n- added function to disconnect from a vCenter or ESXi host\r\n- added tests for changed/new functions\r\n\r\n### What issues does this PR fix or reference?\r\n\r\n### Tests written?\r\n\r\nYes"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/226756868","html_url":"https://github.com/saltstack/salt/pull/34059#issuecomment-226756868","issue_url":"https://api.github.com/repos/saltstack/salt/issues/34059","id":226756868,"user":{"login":"alexbleotu","id":17009281,"avatar_url":"https://avatars.githubusercontent.com/u/17009281?v=3","gravatar_id":"","url":"https://api.github.com/users/alexbleotu","html_url":"https://github.com/alexbleotu","followers_url":"https://api.github.com/users/alexbleotu/followers","following_url":"https://api.github.com/users/alexbleotu/following{/other_user}","gists_url":"https://api.github.com/users/alexbleotu/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbleotu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbleotu/subscriptions","organizations_url":"https://api.github.com/users/alexbleotu/orgs","repos_url":"https://api.github.com/users/alexbleotu/repos","events_url":"https://api.github.com/users/alexbleotu/events{/privacy}","received_events_url":"https://api.github.com/users/alexbleotu/received_events","type":"User","site_admin":false},"created_at":"2016-06-17T12:31:40Z","updated_at":"2016-06-17T12:31:40Z","body":"I am open to taking the VMware specific exceptions out. Why is having them a bad approach? Should I just handle the pyVmomi exceptions where the functions get called (i.e. in the execution module functions)?"}}
{"actor":{"display_login":"alexbleotu"}}