{"action":"created","comment":{"url":"https://api.github.com/repos/ytv/simon/pulls/comments/64141230","id":64141230,"diff_hunk":"@@ -0,0 +1,201 @@\n+App.controller('App.Ctrl', function($scope, $timeout, AppService) {\n+    const colorCode = {1:\"green\", 2: \"red\", 3: \"yellow\", 4: \"blue\"};","path":"public/js/app.Ctrl.js","position":2,"original_position":2,"commit_id":"2f0b84495e9cb4792835c7087271839bbab261bf","original_commit_id":"2f0b84495e9cb4792835c7087271839bbab261bf","user":{"login":"pandaexpress","id":4051837,"avatar_url":"https://avatars.githubusercontent.com/u/4051837?v=3","gravatar_id":"","url":"https://api.github.com/users/pandaexpress","html_url":"https://github.com/pandaexpress","followers_url":"https://api.github.com/users/pandaexpress/followers","following_url":"https://api.github.com/users/pandaexpress/following{/other_user}","gists_url":"https://api.github.com/users/pandaexpress/gists{/gist_id}","starred_url":"https://api.github.com/users/pandaexpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandaexpress/subscriptions","organizations_url":"https://api.github.com/users/pandaexpress/orgs","repos_url":"https://api.github.com/users/pandaexpress/repos","events_url":"https://api.github.com/users/pandaexpress/events{/privacy}","received_events_url":"https://api.github.com/users/pandaexpress/received_events","type":"User","site_admin":false},"body":"This is a personal preference for me, but I find it makes your code easier to navigate.  Any constants that won't change I usually name them with all aps and underscore styling.  Like COLOR_CODE, so its crystal clear anywhere in the code that this is a constant.  Also, I think its better to use COLOR_CODE.GREEN = 'green' instead of COLOR_CODE[1] = green since green should be green regardless of positioning.  Try to find a way to not bind your color constants with your app logic.","created_at":"2016-05-21T22:26:33Z","updated_at":"2016-05-21T22:26:33Z","html_url":"https://github.com/ytv/simon/pull/1#discussion_r64141230","pull_request_url":"https://api.github.com/repos/ytv/simon/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/ytv/simon/pulls/comments/64141230"},"html":{"href":"https://github.com/ytv/simon/pull/1#discussion_r64141230"},"pull_request":{"href":"https://api.github.com/repos/ytv/simon/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ytv/simon/pulls/1","id":70729610,"html_url":"https://github.com/ytv/simon/pull/1","diff_url":"https://github.com/ytv/simon/pull/1.diff","patch_url":"https://github.com/ytv/simon/pull/1.patch","issue_url":"https://api.github.com/repos/ytv/simon/issues/1","number":1,"state":"open","locked":false,"title":"initial commit","user":{"login":"ytv","id":14367962,"avatar_url":"https://avatars.githubusercontent.com/u/14367962?v=3","gravatar_id":"","url":"https://api.github.com/users/ytv","html_url":"https://github.com/ytv","followers_url":"https://api.github.com/users/ytv/followers","following_url":"https://api.github.com/users/ytv/following{/other_user}","gists_url":"https://api.github.com/users/ytv/gists{/gist_id}","starred_url":"https://api.github.com/users/ytv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ytv/subscriptions","organizations_url":"https://api.github.com/users/ytv/orgs","repos_url":"https://api.github.com/users/ytv/repos","events_url":"https://api.github.com/users/ytv/events{/privacy}","received_events_url":"https://api.github.com/users/ytv/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-19T16:59:58Z","updated_at":"2016-05-21T22:26:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd99784ab8d048cdb521a385081ca3d0c7e77363","assignee":{"login":"pandaexpress","id":4051837,"avatar_url":"https://avatars.githubusercontent.com/u/4051837?v=3","gravatar_id":"","url":"https://api.github.com/users/pandaexpress","html_url":"https://github.com/pandaexpress","followers_url":"https://api.github.com/users/pandaexpress/followers","following_url":"https://api.github.com/users/pandaexpress/following{/other_user}","gists_url":"https://api.github.com/users/pandaexpress/gists{/gist_id}","starred_url":"https://api.github.com/users/pandaexpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandaexpress/subscriptions","organizations_url":"https://api.github.com/users/pandaexpress/orgs","repos_url":"https://api.github.com/users/pandaexpress/repos","events_url":"https://api.github.com/users/pandaexpress/events{/privacy}","received_events_url":"https://api.github.com/users/pandaexpress/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ytv/simon/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ytv/simon/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ytv/simon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ytv/simon/issues/1/comments","statuses_url":"https://api.github.com/repos/ytv/simon/statuses/2f0b84495e9cb4792835c7087271839bbab261bf","head":{"label":"ytv:firstCommit","ref":"firstCommit","sha":"2f0b84495e9cb4792835c7087271839bbab261bf","user":{"login":"ytv","id":14367962,"avatar_url":"https://avatars.githubusercontent.com/u/14367962?v=3","gravatar_id":"","url":"https://api.github.com/users/ytv","html_url":"https://github.com/ytv","followers_url":"https://api.github.com/users/ytv/followers","following_url":"https://api.github.com/users/ytv/following{/other_user}","gists_url":"https://api.github.com/users/ytv/gists{/gist_id}","starred_url":"https://api.github.com/users/ytv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ytv/subscriptions","organizations_url":"https://api.github.com/users/ytv/orgs","repos_url":"https://api.github.com/users/ytv/repos","events_url":"https://api.github.com/users/ytv/events{/privacy}","received_events_url":"https://api.github.com/users/ytv/received_events","type":"User","site_admin":false},"repo":{"id":59178373,"name":"simon","full_name":"ytv/simon","owner":{"login":"ytv","id":14367962,"avatar_url":"https://avatars.githubusercontent.com/u/14367962?v=3","gravatar_id":"","url":"https://api.github.com/users/ytv","html_url":"https://github.com/ytv","followers_url":"https://api.github.com/users/ytv/followers","following_url":"https://api.github.com/users/ytv/following{/other_user}","gists_url":"https://api.github.com/users/ytv/gists{/gist_id}","starred_url":"https://api.github.com/users/ytv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ytv/subscriptions","organizations_url":"https://api.github.com/users/ytv/orgs","repos_url":"https://api.github.com/users/ytv/repos","events_url":"https://api.github.com/users/ytv/events{/privacy}","received_events_url":"https://api.github.com/users/ytv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ytv/simon","description":"This is a web app of the old simon game","fork":false,"url":"https://api.github.com/repos/ytv/simon","forks_url":"https://api.github.com/repos/ytv/simon/forks","keys_url":"https://api.github.com/repos/ytv/simon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ytv/simon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ytv/simon/teams","hooks_url":"https://api.github.com/repos/ytv/simon/hooks","issue_events_url":"https://api.github.com/repos/ytv/simon/issues/events{/number}","events_url":"https://api.github.com/repos/ytv/simon/events","assignees_url":"https://api.github.com/repos/ytv/simon/assignees{/user}","branches_url":"https://api.github.com/repos/ytv/simon/branches{/branch}","tags_url":"https://api.github.com/repos/ytv/simon/tags","blobs_url":"https://api.github.com/repos/ytv/simon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ytv/simon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ytv/simon/git/refs{/sha}","trees_url":"https://api.github.com/repos/ytv/simon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ytv/simon/statuses/{sha}","languages_url":"https://api.github.com/repos/ytv/simon/languages","stargazers_url":"https://api.github.com/repos/ytv/simon/stargazers","contributors_url":"https://api.github.com/repos/ytv/simon/contributors","subscribers_url":"https://api.github.com/repos/ytv/simon/subscribers","subscription_url":"https://api.github.com/repos/ytv/simon/subscription","commits_url":"https://api.github.com/repos/ytv/simon/commits{/sha}","git_commits_url":"https://api.github.com/repos/ytv/simon/git/commits{/sha}","comments_url":"https://api.github.com/repos/ytv/simon/comments{/number}","issue_comment_url":"https://api.github.com/repos/ytv/simon/issues/comments{/number}","contents_url":"https://api.github.com/repos/ytv/simon/contents/{+path}","compare_url":"https://api.github.com/repos/ytv/simon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ytv/simon/merges","archive_url":"https://api.github.com/repos/ytv/simon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ytv/simon/downloads","issues_url":"https://api.github.com/repos/ytv/simon/issues{/number}","pulls_url":"https://api.github.com/repos/ytv/simon/pulls{/number}","milestones_url":"https://api.github.com/repos/ytv/simon/milestones{/number}","notifications_url":"https://api.github.com/repos/ytv/simon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ytv/simon/labels{/name}","releases_url":"https://api.github.com/repos/ytv/simon/releases{/id}","deployments_url":"https://api.github.com/repos/ytv/simon/deployments","created_at":"2016-05-19T06:05:11Z","updated_at":"2016-05-19T06:05:11Z","pushed_at":"2016-05-19T16:59:58Z","git_url":"git://github.com/ytv/simon.git","ssh_url":"git@github.com:ytv/simon.git","clone_url":"https://github.com/ytv/simon.git","svn_url":"https://github.com/ytv/simon","homepage":null,"size":4,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ytv:master","ref":"master","sha":"50090fe719b826d30d891ec17a8f1cb8a10fdab5","user":{"login":"ytv","id":14367962,"avatar_url":"https://avatars.githubusercontent.com/u/14367962?v=3","gravatar_id":"","url":"https://api.github.com/users/ytv","html_url":"https://github.com/ytv","followers_url":"https://api.github.com/users/ytv/followers","following_url":"https://api.github.com/users/ytv/following{/other_user}","gists_url":"https://api.github.com/users/ytv/gists{/gist_id}","starred_url":"https://api.github.com/users/ytv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ytv/subscriptions","organizations_url":"https://api.github.com/users/ytv/orgs","repos_url":"https://api.github.com/users/ytv/repos","events_url":"https://api.github.com/users/ytv/events{/privacy}","received_events_url":"https://api.github.com/users/ytv/received_events","type":"User","site_admin":false},"repo":{"id":59178373,"name":"simon","full_name":"ytv/simon","owner":{"login":"ytv","id":14367962,"avatar_url":"https://avatars.githubusercontent.com/u/14367962?v=3","gravatar_id":"","url":"https://api.github.com/users/ytv","html_url":"https://github.com/ytv","followers_url":"https://api.github.com/users/ytv/followers","following_url":"https://api.github.com/users/ytv/following{/other_user}","gists_url":"https://api.github.com/users/ytv/gists{/gist_id}","starred_url":"https://api.github.com/users/ytv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ytv/subscriptions","organizations_url":"https://api.github.com/users/ytv/orgs","repos_url":"https://api.github.com/users/ytv/repos","events_url":"https://api.github.com/users/ytv/events{/privacy}","received_events_url":"https://api.github.com/users/ytv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ytv/simon","description":"This is a web app of the old simon game","fork":false,"url":"https://api.github.com/repos/ytv/simon","forks_url":"https://api.github.com/repos/ytv/simon/forks","keys_url":"https://api.github.com/repos/ytv/simon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ytv/simon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ytv/simon/teams","hooks_url":"https://api.github.com/repos/ytv/simon/hooks","issue_events_url":"https://api.github.com/repos/ytv/simon/issues/events{/number}","events_url":"https://api.github.com/repos/ytv/simon/events","assignees_url":"https://api.github.com/repos/ytv/simon/assignees{/user}","branches_url":"https://api.github.com/repos/ytv/simon/branches{/branch}","tags_url":"https://api.github.com/repos/ytv/simon/tags","blobs_url":"https://api.github.com/repos/ytv/simon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ytv/simon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ytv/simon/git/refs{/sha}","trees_url":"https://api.github.com/repos/ytv/simon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ytv/simon/statuses/{sha}","languages_url":"https://api.github.com/repos/ytv/simon/languages","stargazers_url":"https://api.github.com/repos/ytv/simon/stargazers","contributors_url":"https://api.github.com/repos/ytv/simon/contributors","subscribers_url":"https://api.github.com/repos/ytv/simon/subscribers","subscription_url":"https://api.github.com/repos/ytv/simon/subscription","commits_url":"https://api.github.com/repos/ytv/simon/commits{/sha}","git_commits_url":"https://api.github.com/repos/ytv/simon/git/commits{/sha}","comments_url":"https://api.github.com/repos/ytv/simon/comments{/number}","issue_comment_url":"https://api.github.com/repos/ytv/simon/issues/comments{/number}","contents_url":"https://api.github.com/repos/ytv/simon/contents/{+path}","compare_url":"https://api.github.com/repos/ytv/simon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ytv/simon/merges","archive_url":"https://api.github.com/repos/ytv/simon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ytv/simon/downloads","issues_url":"https://api.github.com/repos/ytv/simon/issues{/number}","pulls_url":"https://api.github.com/repos/ytv/simon/pulls{/number}","milestones_url":"https://api.github.com/repos/ytv/simon/milestones{/number}","notifications_url":"https://api.github.com/repos/ytv/simon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ytv/simon/labels{/name}","releases_url":"https://api.github.com/repos/ytv/simon/releases{/id}","deployments_url":"https://api.github.com/repos/ytv/simon/deployments","created_at":"2016-05-19T06:05:11Z","updated_at":"2016-05-19T06:05:11Z","pushed_at":"2016-05-19T16:59:58Z","git_url":"git://github.com/ytv/simon.git","ssh_url":"git@github.com:ytv/simon.git","clone_url":"https://github.com/ytv/simon.git","svn_url":"https://github.com/ytv/simon","homepage":null,"size":4,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ytv/simon/pulls/1"},"html":{"href":"https://github.com/ytv/simon/pull/1"},"issue":{"href":"https://api.github.com/repos/ytv/simon/issues/1"},"comments":{"href":"https://api.github.com/repos/ytv/simon/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ytv/simon/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ytv/simon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ytv/simon/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ytv/simon/statuses/2f0b84495e9cb4792835c7087271839bbab261bf"}}}}
{"actor":{"display_login":"pandaexpress"}}