{"action":"created","comment":{"url":"https://api.github.com/repos/zulip/zulip/pulls/comments/68493434","id":68493434,"diff_hunk":"@@ -1415,7 +1415,7 @@ def do_add_subscription(user_profile, stream, no_log=False):\n         event = dict(type=\"subscription\", op=\"peer_add\",\n                      subscriptions=[stream.name],\n                      user_email=user_profile.email)\n-        send_event(event, user_ids)\n+        send_event(event, active_user_ids(user_profile.realm))","path":"zerver/lib/actions.py","position":31,"original_position":5,"commit_id":"c3e93506eddda5c9ce6b08d918a7a85182ea392b","original_commit_id":"c3e93506eddda5c9ce6b08d918a7a85182ea392b","user":{"login":"timabbott","id":2746074,"avatar_url":"https://avatars.githubusercontent.com/u/2746074?v=3","gravatar_id":"","url":"https://api.github.com/users/timabbott","html_url":"https://github.com/timabbott","followers_url":"https://api.github.com/users/timabbott/followers","following_url":"https://api.github.com/users/timabbott/following{/other_user}","gists_url":"https://api.github.com/users/timabbott/gists{/gist_id}","starred_url":"https://api.github.com/users/timabbott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timabbott/subscriptions","organizations_url":"https://api.github.com/users/timabbott/orgs","repos_url":"https://api.github.com/users/timabbott/repos","events_url":"https://api.github.com/users/timabbott/events{/privacy}","received_events_url":"https://api.github.com/users/timabbott/received_events","type":"User","site_admin":false},"body":"Yep!\n\n-Tim Abbott (mobile)\nOn Jun 25, 2016 13:21, \"Kartik Maji\" <notifications@github.com> wrote:\n\n> In zerver/lib/actions.py\n> <https://github.com/zulip/zulip/pull/749#discussion_r68493400>:\n>\n> > @@ -1415,7 +1415,7 @@ def do_add_subscription(user_profile, stream, no_log=False):\n> >          event = dict(type=\"subscription\", op=\"peer_add\",\n> >                       subscriptions=[stream.name],\n> >                       user_email=user_profile.email)\n> > -        send_event(event, user_ids)\n> > +        send_event(event, active_user_ids(user_profile.realm))\n>\n> Cool. There are few more tests that are failing. I will fix those and\n> update this PR. Sounds okay?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/zulip/zulip/pull/749/files/b8588740a9e6b01d69fc546ff5b65f339c186687..c3e93506eddda5c9ce6b08d918a7a85182ea392b#r68493400>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe/ACnm2pbfb29Pb-doEiDWtxNIXfbS4snHks5qPY2_gaJpZM4IWfUx>\n> .\n>\n","created_at":"2016-06-25T20:22:24Z","updated_at":"2016-06-25T20:22:24Z","html_url":"https://github.com/zulip/zulip/pull/749#discussion_r68493434","pull_request_url":"https://api.github.com/repos/zulip/zulip/pulls/749","_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip/pulls/comments/68493434"},"html":{"href":"https://github.com/zulip/zulip/pull/749#discussion_r68493434"},"pull_request":{"href":"https://api.github.com/repos/zulip/zulip/pulls/749"}}},"pull_request":{"url":"https://api.github.com/repos/zulip/zulip/pulls/749","id":68751831,"html_url":"https://github.com/zulip/zulip/pull/749","diff_url":"https://github.com/zulip/zulip/pull/749.diff","patch_url":"https://github.com/zulip/zulip/pull/749.patch","issue_url":"https://api.github.com/repos/zulip/zulip/issues/749","number":749,"state":"open","locked":false,"title":"Narrowing to non existing stream gives error message.","user":{"login":"krtkmj","id":6594924,"avatar_url":"https://avatars.githubusercontent.com/u/6594924?v=3","gravatar_id":"","url":"https://api.github.com/users/krtkmj","html_url":"https://github.com/krtkmj","followers_url":"https://api.github.com/users/krtkmj/followers","following_url":"https://api.github.com/users/krtkmj/following{/other_user}","gists_url":"https://api.github.com/users/krtkmj/gists{/gist_id}","starred_url":"https://api.github.com/users/krtkmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krtkmj/subscriptions","organizations_url":"https://api.github.com/users/krtkmj/orgs","repos_url":"https://api.github.com/users/krtkmj/repos","events_url":"https://api.github.com/users/krtkmj/events{/privacy}","received_events_url":"https://api.github.com/users/krtkmj/received_events","type":"User","site_admin":false},"body":"Solves #740 ","created_at":"2016-05-03T18:25:19Z","updated_at":"2016-06-25T20:22:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d8b334b8f09234006409d5d657494ba667a8cf8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/zulip/zulip/pulls/749/commits","review_comments_url":"https://api.github.com/repos/zulip/zulip/pulls/749/comments","review_comment_url":"https://api.github.com/repos/zulip/zulip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zulip/zulip/issues/749/comments","statuses_url":"https://api.github.com/repos/zulip/zulip/statuses/c3e93506eddda5c9ce6b08d918a7a85182ea392b","head":{"label":"krtkmj:non-existing-stream-message","ref":"non-existing-stream-message","sha":"c3e93506eddda5c9ce6b08d918a7a85182ea392b","user":{"login":"krtkmj","id":6594924,"avatar_url":"https://avatars.githubusercontent.com/u/6594924?v=3","gravatar_id":"","url":"https://api.github.com/users/krtkmj","html_url":"https://github.com/krtkmj","followers_url":"https://api.github.com/users/krtkmj/followers","following_url":"https://api.github.com/users/krtkmj/following{/other_user}","gists_url":"https://api.github.com/users/krtkmj/gists{/gist_id}","starred_url":"https://api.github.com/users/krtkmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krtkmj/subscriptions","organizations_url":"https://api.github.com/users/krtkmj/orgs","repos_url":"https://api.github.com/users/krtkmj/repos","events_url":"https://api.github.com/users/krtkmj/events{/privacy}","received_events_url":"https://api.github.com/users/krtkmj/received_events","type":"User","site_admin":false},"repo":{"id":53250007,"name":"zulip","full_name":"krtkmj/zulip","owner":{"login":"krtkmj","id":6594924,"avatar_url":"https://avatars.githubusercontent.com/u/6594924?v=3","gravatar_id":"","url":"https://api.github.com/users/krtkmj","html_url":"https://github.com/krtkmj","followers_url":"https://api.github.com/users/krtkmj/followers","following_url":"https://api.github.com/users/krtkmj/following{/other_user}","gists_url":"https://api.github.com/users/krtkmj/gists{/gist_id}","starred_url":"https://api.github.com/users/krtkmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krtkmj/subscriptions","organizations_url":"https://api.github.com/users/krtkmj/orgs","repos_url":"https://api.github.com/users/krtkmj/repos","events_url":"https://api.github.com/users/krtkmj/events{/privacy}","received_events_url":"https://api.github.com/users/krtkmj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krtkmj/zulip","description":"Zulip server - powerful open source group chat","fork":true,"url":"https://api.github.com/repos/krtkmj/zulip","forks_url":"https://api.github.com/repos/krtkmj/zulip/forks","keys_url":"https://api.github.com/repos/krtkmj/zulip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krtkmj/zulip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krtkmj/zulip/teams","hooks_url":"https://api.github.com/repos/krtkmj/zulip/hooks","issue_events_url":"https://api.github.com/repos/krtkmj/zulip/issues/events{/number}","events_url":"https://api.github.com/repos/krtkmj/zulip/events","assignees_url":"https://api.github.com/repos/krtkmj/zulip/assignees{/user}","branches_url":"https://api.github.com/repos/krtkmj/zulip/branches{/branch}","tags_url":"https://api.github.com/repos/krtkmj/zulip/tags","blobs_url":"https://api.github.com/repos/krtkmj/zulip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krtkmj/zulip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krtkmj/zulip/git/refs{/sha}","trees_url":"https://api.github.com/repos/krtkmj/zulip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krtkmj/zulip/statuses/{sha}","languages_url":"https://api.github.com/repos/krtkmj/zulip/languages","stargazers_url":"https://api.github.com/repos/krtkmj/zulip/stargazers","contributors_url":"https://api.github.com/repos/krtkmj/zulip/contributors","subscribers_url":"https://api.github.com/repos/krtkmj/zulip/subscribers","subscription_url":"https://api.github.com/repos/krtkmj/zulip/subscription","commits_url":"https://api.github.com/repos/krtkmj/zulip/commits{/sha}","git_commits_url":"https://api.github.com/repos/krtkmj/zulip/git/commits{/sha}","comments_url":"https://api.github.com/repos/krtkmj/zulip/comments{/number}","issue_comment_url":"https://api.github.com/repos/krtkmj/zulip/issues/comments{/number}","contents_url":"https://api.github.com/repos/krtkmj/zulip/contents/{+path}","compare_url":"https://api.github.com/repos/krtkmj/zulip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krtkmj/zulip/merges","archive_url":"https://api.github.com/repos/krtkmj/zulip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krtkmj/zulip/downloads","issues_url":"https://api.github.com/repos/krtkmj/zulip/issues{/number}","pulls_url":"https://api.github.com/repos/krtkmj/zulip/pulls{/number}","milestones_url":"https://api.github.com/repos/krtkmj/zulip/milestones{/number}","notifications_url":"https://api.github.com/repos/krtkmj/zulip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krtkmj/zulip/labels{/name}","releases_url":"https://api.github.com/repos/krtkmj/zulip/releases{/id}","deployments_url":"https://api.github.com/repos/krtkmj/zulip/deployments","created_at":"2016-03-06T10:49:22Z","updated_at":"2016-03-06T10:49:26Z","pushed_at":"2016-06-25T20:10:03Z","git_url":"git://github.com/krtkmj/zulip.git","ssh_url":"git@github.com:krtkmj/zulip.git","clone_url":"https://github.com/krtkmj/zulip.git","svn_url":"https://github.com/krtkmj/zulip","homepage":"","size":112306,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zulip:master","ref":"master","sha":"28b6f1d85049988d1d05db79794c4dcc0a899b6b","user":{"login":"zulip","id":4921959,"avatar_url":"https://avatars.githubusercontent.com/u/4921959?v=3","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"repo":{"id":43160685,"name":"zulip","full_name":"zulip/zulip","owner":{"login":"zulip","id":4921959,"avatar_url":"https://avatars.githubusercontent.com/u/4921959?v=3","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zulip/zulip","description":"Zulip server - powerful open source group chat","fork":false,"url":"https://api.github.com/repos/zulip/zulip","forks_url":"https://api.github.com/repos/zulip/zulip/forks","keys_url":"https://api.github.com/repos/zulip/zulip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zulip/zulip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zulip/zulip/teams","hooks_url":"https://api.github.com/repos/zulip/zulip/hooks","issue_events_url":"https://api.github.com/repos/zulip/zulip/issues/events{/number}","events_url":"https://api.github.com/repos/zulip/zulip/events","assignees_url":"https://api.github.com/repos/zulip/zulip/assignees{/user}","branches_url":"https://api.github.com/repos/zulip/zulip/branches{/branch}","tags_url":"https://api.github.com/repos/zulip/zulip/tags","blobs_url":"https://api.github.com/repos/zulip/zulip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zulip/zulip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zulip/zulip/git/refs{/sha}","trees_url":"https://api.github.com/repos/zulip/zulip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zulip/zulip/statuses/{sha}","languages_url":"https://api.github.com/repos/zulip/zulip/languages","stargazers_url":"https://api.github.com/repos/zulip/zulip/stargazers","contributors_url":"https://api.github.com/repos/zulip/zulip/contributors","subscribers_url":"https://api.github.com/repos/zulip/zulip/subscribers","subscription_url":"https://api.github.com/repos/zulip/zulip/subscription","commits_url":"https://api.github.com/repos/zulip/zulip/commits{/sha}","git_commits_url":"https://api.github.com/repos/zulip/zulip/git/commits{/sha}","comments_url":"https://api.github.com/repos/zulip/zulip/comments{/number}","issue_comment_url":"https://api.github.com/repos/zulip/zulip/issues/comments{/number}","contents_url":"https://api.github.com/repos/zulip/zulip/contents/{+path}","compare_url":"https://api.github.com/repos/zulip/zulip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zulip/zulip/merges","archive_url":"https://api.github.com/repos/zulip/zulip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zulip/zulip/downloads","issues_url":"https://api.github.com/repos/zulip/zulip/issues{/number}","pulls_url":"https://api.github.com/repos/zulip/zulip/pulls{/number}","milestones_url":"https://api.github.com/repos/zulip/zulip/milestones{/number}","notifications_url":"https://api.github.com/repos/zulip/zulip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zulip/zulip/labels{/name}","releases_url":"https://api.github.com/repos/zulip/zulip/releases{/id}","deployments_url":"https://api.github.com/repos/zulip/zulip/deployments","created_at":"2015-09-25T16:37:25Z","updated_at":"2016-06-25T18:47:12Z","pushed_at":"2016-06-25T20:12:56Z","git_url":"git://github.com/zulip/zulip.git","ssh_url":"git@github.com:zulip/zulip.git","clone_url":"https://github.com/zulip/zulip.git","svn_url":"https://github.com/zulip/zulip","homepage":"","size":117853,"stargazers_count":3897,"watchers_count":3897,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":606,"mirror_url":null,"open_issues_count":356,"forks":606,"open_issues":356,"watchers":3897,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip/pulls/749"},"html":{"href":"https://github.com/zulip/zulip/pull/749"},"issue":{"href":"https://api.github.com/repos/zulip/zulip/issues/749"},"comments":{"href":"https://api.github.com/repos/zulip/zulip/issues/749/comments"},"review_comments":{"href":"https://api.github.com/repos/zulip/zulip/pulls/749/comments"},"review_comment":{"href":"https://api.github.com/repos/zulip/zulip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zulip/zulip/pulls/749/commits"},"statuses":{"href":"https://api.github.com/repos/zulip/zulip/statuses/c3e93506eddda5c9ce6b08d918a7a85182ea392b"}}}}
{"actor":{"display_login":"timabbott"}}