{"action":"created","comment":{"url":"https://api.github.com/repos/yelouafi/redux-saga/pulls/comments/78925306","id":78925306,"diff_hunk":"@@ -29,36 +54,32 @@ function ringBuffer(limit = 10, overflowAction) {\n             pushIndex = (pushIndex + 1) % limit\n             popIndex = pushIndex\n             break\n+          case ON_OVERFLOW_EXPAND:\n+            doubledLimit = 2 * limit\n+\n+            flushedItems = flush()\n+            arr = [].concat(flushedItems)","path":"src/internal/buffers.js","position":60,"original_position":60,"commit_id":"c0a8ec0429dc21e6d9c09ca77580f17740e36bf4","original_commit_id":"c0a8ec0429dc21e6d9c09ca77580f17740e36bf4","user":{"login":"yelouafi","id":5453835,"avatar_url":"https://avatars.githubusercontent.com/u/5453835?v=3","gravatar_id":"","url":"https://api.github.com/users/yelouafi","html_url":"https://github.com/yelouafi","followers_url":"https://api.github.com/users/yelouafi/followers","following_url":"https://api.github.com/users/yelouafi/following{/other_user}","gists_url":"https://api.github.com/users/yelouafi/gists{/gist_id}","starred_url":"https://api.github.com/users/yelouafi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yelouafi/subscriptions","organizations_url":"https://api.github.com/users/yelouafi/orgs","repos_url":"https://api.github.com/users/yelouafi/repos","events_url":"https://api.github.com/users/yelouafi/events{/privacy}","received_events_url":"https://api.github.com/users/yelouafi/received_events","type":"User","site_admin":false},"body":"Do we need to create a new Array here? `flush` already returns a new array","created_at":"2016-09-15T09:43:38Z","updated_at":"2016-09-15T09:43:38Z","html_url":"https://github.com/yelouafi/redux-saga/pull/530#discussion_r78925306","pull_request_url":"https://api.github.com/repos/yelouafi/redux-saga/pulls/530","_links":{"self":{"href":"https://api.github.com/repos/yelouafi/redux-saga/pulls/comments/78925306"},"html":{"href":"https://github.com/yelouafi/redux-saga/pull/530#discussion_r78925306"},"pull_request":{"href":"https://api.github.com/repos/yelouafi/redux-saga/pulls/530"}}},"pull_request":{"url":"https://api.github.com/repos/yelouafi/redux-saga/pulls/530","id":84006892,"html_url":"https://github.com/yelouafi/redux-saga/pull/530","diff_url":"https://github.com/yelouafi/redux-saga/pull/530.diff","patch_url":"https://github.com/yelouafi/redux-saga/pull/530.patch","issue_url":"https://api.github.com/repos/yelouafi/redux-saga/issues/530","number":530,"state":"open","locked":false,"title":"Implemented new type of buffer - infinity, which will expand itself a…","user":{"login":"Andarist","id":9800850,"avatar_url":"https://avatars.githubusercontent.com/u/9800850?v=3","gravatar_id":"","url":"https://api.github.com/users/Andarist","html_url":"https://github.com/Andarist","followers_url":"https://api.github.com/users/Andarist/followers","following_url":"https://api.github.com/users/Andarist/following{/other_user}","gists_url":"https://api.github.com/users/Andarist/gists{/gist_id}","starred_url":"https://api.github.com/users/Andarist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andarist/subscriptions","organizations_url":"https://api.github.com/users/Andarist/orgs","repos_url":"https://api.github.com/users/Andarist/repos","events_url":"https://api.github.com/users/Andarist/events{/privacy}","received_events_url":"https://api.github.com/users/Andarist/received_events","type":"User","site_admin":false},"body":"…utomatically in case of overflow\r\n\r\nWould give people new type of self-expanding buffer as alternative (for example here - https://github.com/yelouafi/redux-saga/issues/511), more close to old (non ring) implementations, which got recently introduced as breaking change. ","created_at":"2016-09-05T14:02:28Z","updated_at":"2016-09-15T09:43:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a7e7f25b52f1ef29cdda56099d917f5cebb772f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yelouafi/redux-saga/pulls/530/commits","review_comments_url":"https://api.github.com/repos/yelouafi/redux-saga/pulls/530/comments","review_comment_url":"https://api.github.com/repos/yelouafi/redux-saga/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yelouafi/redux-saga/issues/530/comments","statuses_url":"https://api.github.com/repos/yelouafi/redux-saga/statuses/c0a8ec0429dc21e6d9c09ca77580f17740e36bf4","head":{"label":"Andarist:infinity-buffer","ref":"infinity-buffer","sha":"c0a8ec0429dc21e6d9c09ca77580f17740e36bf4","user":{"login":"Andarist","id":9800850,"avatar_url":"https://avatars.githubusercontent.com/u/9800850?v=3","gravatar_id":"","url":"https://api.github.com/users/Andarist","html_url":"https://github.com/Andarist","followers_url":"https://api.github.com/users/Andarist/followers","following_url":"https://api.github.com/users/Andarist/following{/other_user}","gists_url":"https://api.github.com/users/Andarist/gists{/gist_id}","starred_url":"https://api.github.com/users/Andarist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andarist/subscriptions","organizations_url":"https://api.github.com/users/Andarist/orgs","repos_url":"https://api.github.com/users/Andarist/repos","events_url":"https://api.github.com/users/Andarist/events{/privacy}","received_events_url":"https://api.github.com/users/Andarist/received_events","type":"User","site_admin":false},"repo":{"id":64166830,"name":"redux-saga","full_name":"Andarist/redux-saga","owner":{"login":"Andarist","id":9800850,"avatar_url":"https://avatars.githubusercontent.com/u/9800850?v=3","gravatar_id":"","url":"https://api.github.com/users/Andarist","html_url":"https://github.com/Andarist","followers_url":"https://api.github.com/users/Andarist/followers","following_url":"https://api.github.com/users/Andarist/following{/other_user}","gists_url":"https://api.github.com/users/Andarist/gists{/gist_id}","starred_url":"https://api.github.com/users/Andarist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andarist/subscriptions","organizations_url":"https://api.github.com/users/Andarist/orgs","repos_url":"https://api.github.com/users/Andarist/repos","events_url":"https://api.github.com/users/Andarist/events{/privacy}","received_events_url":"https://api.github.com/users/Andarist/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Andarist/redux-saga","description":"An alternative side effect model for Redux apps","fork":true,"url":"https://api.github.com/repos/Andarist/redux-saga","forks_url":"https://api.github.com/repos/Andarist/redux-saga/forks","keys_url":"https://api.github.com/repos/Andarist/redux-saga/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Andarist/redux-saga/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Andarist/redux-saga/teams","hooks_url":"https://api.github.com/repos/Andarist/redux-saga/hooks","issue_events_url":"https://api.github.com/repos/Andarist/redux-saga/issues/events{/number}","events_url":"https://api.github.com/repos/Andarist/redux-saga/events","assignees_url":"https://api.github.com/repos/Andarist/redux-saga/assignees{/user}","branches_url":"https://api.github.com/repos/Andarist/redux-saga/branches{/branch}","tags_url":"https://api.github.com/repos/Andarist/redux-saga/tags","blobs_url":"https://api.github.com/repos/Andarist/redux-saga/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Andarist/redux-saga/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Andarist/redux-saga/git/refs{/sha}","trees_url":"https://api.github.com/repos/Andarist/redux-saga/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Andarist/redux-saga/statuses/{sha}","languages_url":"https://api.github.com/repos/Andarist/redux-saga/languages","stargazers_url":"https://api.github.com/repos/Andarist/redux-saga/stargazers","contributors_url":"https://api.github.com/repos/Andarist/redux-saga/contributors","subscribers_url":"https://api.github.com/repos/Andarist/redux-saga/subscribers","subscription_url":"https://api.github.com/repos/Andarist/redux-saga/subscription","commits_url":"https://api.github.com/repos/Andarist/redux-saga/commits{/sha}","git_commits_url":"https://api.github.com/repos/Andarist/redux-saga/git/commits{/sha}","comments_url":"https://api.github.com/repos/Andarist/redux-saga/comments{/number}","issue_comment_url":"https://api.github.com/repos/Andarist/redux-saga/issues/comments{/number}","contents_url":"https://api.github.com/repos/Andarist/redux-saga/contents/{+path}","compare_url":"https://api.github.com/repos/Andarist/redux-saga/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Andarist/redux-saga/merges","archive_url":"https://api.github.com/repos/Andarist/redux-saga/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Andarist/redux-saga/downloads","issues_url":"https://api.github.com/repos/Andarist/redux-saga/issues{/number}","pulls_url":"https://api.github.com/repos/Andarist/redux-saga/pulls{/number}","milestones_url":"https://api.github.com/repos/Andarist/redux-saga/milestones{/number}","notifications_url":"https://api.github.com/repos/Andarist/redux-saga/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Andarist/redux-saga/labels{/name}","releases_url":"https://api.github.com/repos/Andarist/redux-saga/releases{/id}","deployments_url":"https://api.github.com/repos/Andarist/redux-saga/deployments","created_at":"2016-07-25T20:46:44Z","updated_at":"2016-07-25T20:46:45Z","pushed_at":"2016-09-15T07:20:53Z","git_url":"git://github.com/Andarist/redux-saga.git","ssh_url":"git@github.com:Andarist/redux-saga.git","clone_url":"https://github.com/Andarist/redux-saga.git","svn_url":"https://github.com/Andarist/redux-saga","homepage":"http://yelouafi.github.io/redux-saga/","size":3802,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yelouafi:master","ref":"master","sha":"339ea9a8753d0a60dd006f2d8b2b26e88d75505e","user":{"login":"yelouafi","id":5453835,"avatar_url":"https://avatars.githubusercontent.com/u/5453835?v=3","gravatar_id":"","url":"https://api.github.com/users/yelouafi","html_url":"https://github.com/yelouafi","followers_url":"https://api.github.com/users/yelouafi/followers","following_url":"https://api.github.com/users/yelouafi/following{/other_user}","gists_url":"https://api.github.com/users/yelouafi/gists{/gist_id}","starred_url":"https://api.github.com/users/yelouafi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yelouafi/subscriptions","organizations_url":"https://api.github.com/users/yelouafi/orgs","repos_url":"https://api.github.com/users/yelouafi/repos","events_url":"https://api.github.com/users/yelouafi/events{/privacy}","received_events_url":"https://api.github.com/users/yelouafi/received_events","type":"User","site_admin":false},"repo":{"id":47071941,"name":"redux-saga","full_name":"yelouafi/redux-saga","owner":{"login":"yelouafi","id":5453835,"avatar_url":"https://avatars.githubusercontent.com/u/5453835?v=3","gravatar_id":"","url":"https://api.github.com/users/yelouafi","html_url":"https://github.com/yelouafi","followers_url":"https://api.github.com/users/yelouafi/followers","following_url":"https://api.github.com/users/yelouafi/following{/other_user}","gists_url":"https://api.github.com/users/yelouafi/gists{/gist_id}","starred_url":"https://api.github.com/users/yelouafi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yelouafi/subscriptions","organizations_url":"https://api.github.com/users/yelouafi/orgs","repos_url":"https://api.github.com/users/yelouafi/repos","events_url":"https://api.github.com/users/yelouafi/events{/privacy}","received_events_url":"https://api.github.com/users/yelouafi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yelouafi/redux-saga","description":"An alternative side effect model for Redux apps","fork":false,"url":"https://api.github.com/repos/yelouafi/redux-saga","forks_url":"https://api.github.com/repos/yelouafi/redux-saga/forks","keys_url":"https://api.github.com/repos/yelouafi/redux-saga/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yelouafi/redux-saga/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yelouafi/redux-saga/teams","hooks_url":"https://api.github.com/repos/yelouafi/redux-saga/hooks","issue_events_url":"https://api.github.com/repos/yelouafi/redux-saga/issues/events{/number}","events_url":"https://api.github.com/repos/yelouafi/redux-saga/events","assignees_url":"https://api.github.com/repos/yelouafi/redux-saga/assignees{/user}","branches_url":"https://api.github.com/repos/yelouafi/redux-saga/branches{/branch}","tags_url":"https://api.github.com/repos/yelouafi/redux-saga/tags","blobs_url":"https://api.github.com/repos/yelouafi/redux-saga/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yelouafi/redux-saga/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yelouafi/redux-saga/git/refs{/sha}","trees_url":"https://api.github.com/repos/yelouafi/redux-saga/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yelouafi/redux-saga/statuses/{sha}","languages_url":"https://api.github.com/repos/yelouafi/redux-saga/languages","stargazers_url":"https://api.github.com/repos/yelouafi/redux-saga/stargazers","contributors_url":"https://api.github.com/repos/yelouafi/redux-saga/contributors","subscribers_url":"https://api.github.com/repos/yelouafi/redux-saga/subscribers","subscription_url":"https://api.github.com/repos/yelouafi/redux-saga/subscription","commits_url":"https://api.github.com/repos/yelouafi/redux-saga/commits{/sha}","git_commits_url":"https://api.github.com/repos/yelouafi/redux-saga/git/commits{/sha}","comments_url":"https://api.github.com/repos/yelouafi/redux-saga/comments{/number}","issue_comment_url":"https://api.github.com/repos/yelouafi/redux-saga/issues/comments{/number}","contents_url":"https://api.github.com/repos/yelouafi/redux-saga/contents/{+path}","compare_url":"https://api.github.com/repos/yelouafi/redux-saga/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yelouafi/redux-saga/merges","archive_url":"https://api.github.com/repos/yelouafi/redux-saga/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yelouafi/redux-saga/downloads","issues_url":"https://api.github.com/repos/yelouafi/redux-saga/issues{/number}","pulls_url":"https://api.github.com/repos/yelouafi/redux-saga/pulls{/number}","milestones_url":"https://api.github.com/repos/yelouafi/redux-saga/milestones{/number}","notifications_url":"https://api.github.com/repos/yelouafi/redux-saga/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yelouafi/redux-saga/labels{/name}","releases_url":"https://api.github.com/repos/yelouafi/redux-saga/releases{/id}","deployments_url":"https://api.github.com/repos/yelouafi/redux-saga/deployments","created_at":"2015-11-29T16:58:12Z","updated_at":"2016-09-15T05:13:05Z","pushed_at":"2016-09-15T09:34:26Z","git_url":"git://github.com/yelouafi/redux-saga.git","ssh_url":"git@github.com:yelouafi/redux-saga.git","clone_url":"https://github.com/yelouafi/redux-saga.git","svn_url":"https://github.com/yelouafi/redux-saga","homepage":"http://yelouafi.github.io/redux-saga/","size":4292,"stargazers_count":4147,"watchers_count":4147,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":276,"mirror_url":null,"open_issues_count":34,"forks":276,"open_issues":34,"watchers":4147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yelouafi/redux-saga/pulls/530"},"html":{"href":"https://github.com/yelouafi/redux-saga/pull/530"},"issue":{"href":"https://api.github.com/repos/yelouafi/redux-saga/issues/530"},"comments":{"href":"https://api.github.com/repos/yelouafi/redux-saga/issues/530/comments"},"review_comments":{"href":"https://api.github.com/repos/yelouafi/redux-saga/pulls/530/comments"},"review_comment":{"href":"https://api.github.com/repos/yelouafi/redux-saga/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yelouafi/redux-saga/pulls/530/commits"},"statuses":{"href":"https://api.github.com/repos/yelouafi/redux-saga/statuses/c0a8ec0429dc21e6d9c09ca77580f17740e36bf4"}}}}
{"actor":{"display_login":"yelouafi"}}