{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/62132842","id":62132842,"diff_hunk":"@@ -59,7 +59,7 @@\n     - restart kubelet\n \n - name: Enable kubelet\n-  service: name=kubelet enabled=yes \n+  service: name=kubelet enabled=yes state=started ","path":"ansible/roles/node/tasks/main.yml","position":5,"original_position":5,"commit_id":"5f1b42c7adf8556bcd1ff2dbe8d129dac22fab53","original_commit_id":"5f1b42c7adf8556bcd1ff2dbe8d129dac22fab53","user":{"login":"gouyang","id":1418734,"avatar_url":"https://avatars.githubusercontent.com/u/1418734?v=3","gravatar_id":"","url":"https://api.github.com/users/gouyang","html_url":"https://github.com/gouyang","followers_url":"https://api.github.com/users/gouyang/followers","following_url":"https://api.github.com/users/gouyang/following{/other_user}","gists_url":"https://api.github.com/users/gouyang/gists{/gist_id}","starred_url":"https://api.github.com/users/gouyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gouyang/subscriptions","organizations_url":"https://api.github.com/users/gouyang/orgs","repos_url":"https://api.github.com/users/gouyang/repos","events_url":"https://api.github.com/users/gouyang/events{/privacy}","received_events_url":"https://api.github.com/users/gouyang/received_events","type":"User","site_admin":false},"body":"`restart kubelet` should only be invoked when changes happen.\r\nSometimes I stop the kube cluster and not delete the config files, re-run the playbook, only kubelet service is not running.\r\n\r\n```\r\nTASK [node : Set token facts] **************************************************\r\nok: [...]\r\n\r\nTASK [node : Create the kubelet working directory] *****************************\r\nok: [...]\r\n\r\nTASK [node : write the config files for kubelet] *******************************\r\nok: [...]\r\n\r\nTASK [node : write the kubecfg (auth) file for kubelet] ************************\r\nok: [...]\r\n\r\nTASK [node : Enable kubelet] ***************************************************\r\nok: [...]\r\n\r\nTASK [node : write the config files for proxy] *********************************\r\nok: [...]\r\n\r\nTASK [node : write the kubecfg (auth) file for kube-proxy] *********************\r\nok: [...]\r\n\r\nTASK [node : Enable proxy] *****************************************************\r\nchanged: [...]\r\n\r\nTASK [node : write the delay-node-services target] *****************************\r\nok: [...]\r\n\r\nTASK [node : Enable delay-node-services] ***************************************\r\nok: [...]\r\n```\r\n\r\nCould see kubelet notify is not happened because no changes happen, however kube-proxy is changed because the service is stopped and `state=started` make sure it should be running. \r\n\r\nAnd I seems `state=started` only miss for kubelet.","created_at":"2016-05-04T23:44:15Z","updated_at":"2016-05-04T23:44:15Z","html_url":"https://github.com/kubernetes/contrib/pull/895#discussion_r62132842","pull_request_url":"https://api.github.com/repos/kubernetes/contrib/pulls/895","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments/62132842"},"html":{"href":"https://github.com/kubernetes/contrib/pull/895#discussion_r62132842"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/895"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/895","id":68806923,"html_url":"https://github.com/kubernetes/contrib/pull/895","diff_url":"https://github.com/kubernetes/contrib/pull/895.diff","patch_url":"https://github.com/kubernetes/contrib/pull/895.patch","issue_url":"https://api.github.com/repos/kubernetes/contrib/issues/895","number":895,"state":"open","locked":false,"title":"[ansible] Make sure kubelet service is up.","user":{"login":"gouyang","id":1418734,"avatar_url":"https://avatars.githubusercontent.com/u/1418734?v=3","gravatar_id":"","url":"https://api.github.com/users/gouyang","html_url":"https://github.com/gouyang","followers_url":"https://api.github.com/users/gouyang/followers","following_url":"https://api.github.com/users/gouyang/following{/other_user}","gists_url":"https://api.github.com/users/gouyang/gists{/gist_id}","starred_url":"https://api.github.com/users/gouyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gouyang/subscriptions","organizations_url":"https://api.github.com/users/gouyang/orgs","repos_url":"https://api.github.com/users/gouyang/repos","events_url":"https://api.github.com/users/gouyang/events{/privacy}","received_events_url":"https://api.github.com/users/gouyang/received_events","type":"User","site_admin":false},"body":"When kubelet service is stopped, run the playbook does not get the\r\nservice up.","created_at":"2016-05-04T03:32:02Z","updated_at":"2016-05-04T23:44:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1bd263105a26e07cfda7e31fcd20a93ca1f658b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/contrib/pulls/895/commits","review_comments_url":"https://api.github.com/repos/kubernetes/contrib/pulls/895/comments","review_comment_url":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/contrib/issues/895/comments","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/5f1b42c7adf8556bcd1ff2dbe8d129dac22fab53","head":{"label":"gouyang:make_sure_kubelet_up","ref":"make_sure_kubelet_up","sha":"5f1b42c7adf8556bcd1ff2dbe8d129dac22fab53","user":{"login":"gouyang","id":1418734,"avatar_url":"https://avatars.githubusercontent.com/u/1418734?v=3","gravatar_id":"","url":"https://api.github.com/users/gouyang","html_url":"https://github.com/gouyang","followers_url":"https://api.github.com/users/gouyang/followers","following_url":"https://api.github.com/users/gouyang/following{/other_user}","gists_url":"https://api.github.com/users/gouyang/gists{/gist_id}","starred_url":"https://api.github.com/users/gouyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gouyang/subscriptions","organizations_url":"https://api.github.com/users/gouyang/orgs","repos_url":"https://api.github.com/users/gouyang/repos","events_url":"https://api.github.com/users/gouyang/events{/privacy}","received_events_url":"https://api.github.com/users/gouyang/received_events","type":"User","site_admin":false},"repo":{"id":58019782,"name":"contrib","full_name":"gouyang/contrib","owner":{"login":"gouyang","id":1418734,"avatar_url":"https://avatars.githubusercontent.com/u/1418734?v=3","gravatar_id":"","url":"https://api.github.com/users/gouyang","html_url":"https://github.com/gouyang","followers_url":"https://api.github.com/users/gouyang/followers","following_url":"https://api.github.com/users/gouyang/following{/other_user}","gists_url":"https://api.github.com/users/gouyang/gists{/gist_id}","starred_url":"https://api.github.com/users/gouyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gouyang/subscriptions","organizations_url":"https://api.github.com/users/gouyang/orgs","repos_url":"https://api.github.com/users/gouyang/repos","events_url":"https://api.github.com/users/gouyang/events{/privacy}","received_events_url":"https://api.github.com/users/gouyang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gouyang/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.","fork":true,"url":"https://api.github.com/repos/gouyang/contrib","forks_url":"https://api.github.com/repos/gouyang/contrib/forks","keys_url":"https://api.github.com/repos/gouyang/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gouyang/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gouyang/contrib/teams","hooks_url":"https://api.github.com/repos/gouyang/contrib/hooks","issue_events_url":"https://api.github.com/repos/gouyang/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/gouyang/contrib/events","assignees_url":"https://api.github.com/repos/gouyang/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/gouyang/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/gouyang/contrib/tags","blobs_url":"https://api.github.com/repos/gouyang/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gouyang/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gouyang/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/gouyang/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gouyang/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/gouyang/contrib/languages","stargazers_url":"https://api.github.com/repos/gouyang/contrib/stargazers","contributors_url":"https://api.github.com/repos/gouyang/contrib/contributors","subscribers_url":"https://api.github.com/repos/gouyang/contrib/subscribers","subscription_url":"https://api.github.com/repos/gouyang/contrib/subscription","commits_url":"https://api.github.com/repos/gouyang/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/gouyang/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/gouyang/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/gouyang/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/gouyang/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/gouyang/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gouyang/contrib/merges","archive_url":"https://api.github.com/repos/gouyang/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gouyang/contrib/downloads","issues_url":"https://api.github.com/repos/gouyang/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/gouyang/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/gouyang/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/gouyang/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gouyang/contrib/labels{/name}","releases_url":"https://api.github.com/repos/gouyang/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/gouyang/contrib/deployments","created_at":"2016-05-04T03:23:53Z","updated_at":"2016-05-04T03:23:57Z","pushed_at":"2016-05-04T03:31:36Z","git_url":"git://github.com/gouyang/contrib.git","ssh_url":"git@github.com:gouyang/contrib.git","clone_url":"https://github.com/gouyang/contrib.git","svn_url":"https://github.com/gouyang/contrib","homepage":"","size":24014,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"a8b2ceb16fdbbd73661ab4066b573f21a84e1e70","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":40686014,"name":"contrib","full_name":"kubernetes/contrib","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/contrib","description":"This is a place for various components in the Kubernetes ecosystem that aren't part of the Kubernetes core.","fork":false,"url":"https://api.github.com/repos/kubernetes/contrib","forks_url":"https://api.github.com/repos/kubernetes/contrib/forks","keys_url":"https://api.github.com/repos/kubernetes/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/contrib/teams","hooks_url":"https://api.github.com/repos/kubernetes/contrib/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/contrib/events","assignees_url":"https://api.github.com/repos/kubernetes/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/contrib/tags","blobs_url":"https://api.github.com/repos/kubernetes/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/contrib/languages","stargazers_url":"https://api.github.com/repos/kubernetes/contrib/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/contrib/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/contrib/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/contrib/subscription","commits_url":"https://api.github.com/repos/kubernetes/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/contrib/merges","archive_url":"https://api.github.com/repos/kubernetes/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/contrib/downloads","issues_url":"https://api.github.com/repos/kubernetes/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/contrib/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/contrib/deployments","created_at":"2015-08-13T23:18:26Z","updated_at":"2016-05-04T09:10:28Z","pushed_at":"2016-05-04T19:20:16Z","git_url":"git://github.com/kubernetes/contrib.git","ssh_url":"git@github.com:kubernetes/contrib.git","clone_url":"https://github.com/kubernetes/contrib.git","svn_url":"https://github.com/kubernetes/contrib","homepage":"","size":45910,"stargazers_count":268,"watchers_count":268,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":238,"mirror_url":null,"open_issues_count":190,"forks":238,"open_issues":190,"watchers":268,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/895"},"html":{"href":"https://github.com/kubernetes/contrib/pull/895"},"issue":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/895"},"comments":{"href":"https://api.github.com/repos/kubernetes/contrib/issues/895/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/895/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/contrib/pulls/895/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/contrib/statuses/5f1b42c7adf8556bcd1ff2dbe8d129dac22fab53"}}}}