{"push_id":1305105863,"size":32,"distinct_size":32,"ref":"refs/heads/task-unreachable-latest","head":"03dd692cdf653833ccb328e18a6b84ab106eec91","before":"27eeeb94dc55abd5278946f139d6051973918033","commits":[{"sha":"66e0c5bdf0fb07d6d2d345501b35cd4ceec06d5f","author":{"name":"Neil Conway","email":"4f41ed19fc3accf446ec9111a93682686fd4d3d9@gmail.com"},"message":"Avoided passing large object by value in CNI isolator.\n\nReview: https://reviews.apache.org/r/51983/","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/66e0c5bdf0fb07d6d2d345501b35cd4ceec06d5f"},{"sha":"63004cc49644e229adf9581794ee21f89f66b898","author":{"name":"Kevin Klues","email":"6afa7d19d5bbf119e8125b3659d829a3f7e07e62@gmail.com"},"message":"Updated 'cgroups' isolator 'watch' to be properly nested aware.\n\nIn a previous iteration of attempting to make this isolator nested\naware, we (incorrectly) decided to return a 'Failure()' in 'watch()'\nfor nested containers. However, we shouldn't just blindly fail this\ncall for nested containers. Instead we should just return a 'Future'\nthat will never be satisfied. This way it is safe to call 'watch()'\nfor nested containers, without any unwanted side effects.\n\nThis commit fixes this issue.\n\nReview: https://reviews.apache.org/r/51988/","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/63004cc49644e229adf9581794ee21f89f66b898"},{"sha":"8221021580ff1968b2b44d878e8c523bf77d5d6d","author":{"name":"Jie Yu","email":"f7222f05d12e3ba12bb04fd30f9be9baa697b227@gmail.com"},"message":"Marked the pid namespace isolator as nesting aware.\n\nReview: https://reviews.apache.org/r/51981","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/8221021580ff1968b2b44d878e8c523bf77d5d6d"},{"sha":"a4fd86bce2d2b6b53bce2ea95e3b69c5ab011ff8","author":{"name":"Jie Yu","email":"f7222f05d12e3ba12bb04fd30f9be9baa697b227@gmail.com"},"message":"Made the 'disk/du' isolator nesting aware.\n\nThe disk space check will be done at the top container level. All\nnested container will not have separate disk space check for now.\n\nIn theory, this change is not necessary for now as we can simply mark\nthe isolator as nesting unaware. However, in the future, we might want\nto do separate disk check for each nested container and report\nlimitations for them. Therefore, we include this patch as a starting\npoint.\n\nReview: https://reviews.apache.org/r/51989","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/a4fd86bce2d2b6b53bce2ea95e3b69c5ab011ff8"},{"sha":"be81a924a9e9414ec98f8c9a87a5391dad865146","author":{"name":"Jie Yu","email":"f7222f05d12e3ba12bb04fd30f9be9baa697b227@gmail.com"},"message":"Fixed a bug in getRootContainerId due to protobuf copying issue.\n\nIt looks like protobuf is not so great dealing with nesting messages\nwhen doing merge or copy. This patch uses an extra copy to bypass that\nissue in the protobuf.\n\nReview: https://reviews.apache.org/r/51992","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/be81a924a9e9414ec98f8c9a87a5391dad865146"},{"sha":"6ecd364304d9ddb10f6460a41a8a6d0d5a12d698","author":{"name":"Neil Conway","email":"4f41ed19fc3accf446ec9111a93682686fd4d3d9@gmail.com"},"message":"Changed master to allow partitioned slaves to reregister.\n\nThe previous behavior was to shutdown partitioned agents that attempt to\nreregister---unless the master has failed over, in which case the\nreregistration is allowed (when running in \"non-strict\" mode).\n\nThe new behavior is always to allow partitioned agents to reregister.\nThis is part of a longer-term project to allow frameworks to define\ntheir own policies for handling tasks running on partitioned agents.\n\nIn particular, if a framework has the PARTITION_AWARE capability, any\ntasks running on the partitioned agent will continue to run after\nreregistration. If the framework is not PARTITION_AWARE, any tasks that\nwere running on such an agent will be killed after the agent reregisters\n(unless the master has failed over). This is for backward compatibility\nwith the previous (\"non-strict\") behavior. Note that regardless of the\nPARTITION_AWARE capability, the agent will not be shutdown, which is a\nchange from the previous Mesos behavior.\n\nThis commit also changes the master so that if an agent is removed and\nthen the master receives a message from that agent, the master will no\nlonger attempt to shutdown the agent. This is consistent with the goal\nof getting the master out of the business of shutting down agents that\nwe suspect are unhealthy. Such an agent will eventually realize it is\nnot registered with the master (e.g., because it won't receive any pings\nfrom the master), which will cause it to reregister.\n\nReview: https://reviews.apache.org/r/50705","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/6ecd364304d9ddb10f6460a41a8a6d0d5a12d698"},{"sha":"9db1d946b4a51b2d0444f45fd1f866c641e352c8","author":{"name":"Neil Conway","email":"4f41ed19fc3accf446ec9111a93682686fd4d3d9@gmail.com"},"message":"Added test cases for PARTITION_AWARE behavior.\n\nReview: https://reviews.apache.org/r/50706","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/9db1d946b4a51b2d0444f45fd1f866c641e352c8"},{"sha":"963ca5d21fa63916db36734f253326563e454df8","author":{"name":"Neil Conway","email":"4f41ed19fc3accf446ec9111a93682686fd4d3d9@gmail.com"},"message":"Added test for race between health checks and agent unregistration.\n\nThis test tries to simulate a race between marking an agent unhealthy\nand receiving an `UnregisterSlaveMessage` for that agent.\n\nUnfortunately, this test is a little fragile (we need to manually\ndispatch an event to the master process to simulate the action that\nwould be taken by the slave observer).\n\nReview: https://reviews.apache.org/r/50707","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/963ca5d21fa63916db36734f253326563e454df8"},{"sha":"64892c5da52191d531ea5df606642f84769da794","author":{"name":"Neil Conway","email":"4f41ed19fc3accf446ec9111a93682686fd4d3d9@gmail.com"},"message":"Fixed outdated comment.\n\nReview: https://reviews.apache.org/r/50844","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/64892c5da52191d531ea5df606642f84769da794"},{"sha":"394716aa703eef6f0f67723fa474812af850cb53","author":{"name":"Neil Conway","email":"4f41ed19fc3accf446ec9111a93682686fd4d3d9@gmail.com"},"message":"Added `unreachable_time` to TaskStatus.\n\nThis field contains the time at which the master marked an agent as\nunreachable. It will only be set for status updates (including\nreconciliation updates) that describe tasks running on unreachable\n(e.g., partitioned) agents.\n\nThe intent is to help frameworks decide how to handle tasks running on\npartitioned agents: since the framework might have missed the initial\nTASK_LOST/TASK_UNREACHABLE status update (e.g., due to framework\ndowntime/failover), it might otherwise be difficult for frameworks to\ndetermine how long an agent has been partitioned.\n\nThis unreachable timestamp is stored in the registry and loaded as part\nof master recovery.\n\nReview: https://reviews.apache.org/r/50845","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/394716aa703eef6f0f67723fa474812af850cb53"},{"sha":"473dfab37cd3f030ad507046a1d43edf36780b21","author":{"name":"Neil Conway","email":"4f41ed19fc3accf446ec9111a93682686fd4d3d9@gmail.com"},"message":"Added more assertions to the master.\n\nReview: https://reviews.apache.org/r/50846","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/473dfab37cd3f030ad507046a1d43edf36780b21"},{"sha":"f796494d2ed372d050533dbffa8f04b500e3f22c","author":{"name":"Neil Conway","email":"4f41ed19fc3accf446ec9111a93682686fd4d3d9@gmail.com"},"message":"Clarified a log message.\n\nReview: https://reviews.apache.org/r/51020","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/f796494d2ed372d050533dbffa8f04b500e3f22c"},{"sha":"2a6a1ef5216893ce66428cbbcdc83f62c99ef07d","author":{"name":"Neil Conway","email":"4f41ed19fc3accf446ec9111a93682686fd4d3d9@gmail.com"},"message":"Fixed flakiness in MasterAuthorizationTest.SlaveDisconnected.\n\nThe goal of this test is to check this interleaving:\n\n  task launch: block on authorization\n  slave terminates gracefully: removed by master\n  auth succeeds: we expect the task launch to fail\n\nHowever, the test neglected to ensure that slave removal was completed\nbefore allowing authorization to succeed.\n\nReview: https://reviews.apache.org/r/51371","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/2a6a1ef5216893ce66428cbbcdc83f62c99ef07d"},{"sha":"79296e1009957646c444f5c8e272c2ee60e7c547","author":{"name":"Neil Conway","email":"4f41ed19fc3accf446ec9111a93682686fd4d3d9@gmail.com"},"message":"Change registry update order on removal, mark-unreachable.\n\nThis commit changes the master so that we always update the registry\nfor an important change (e.g., removing an agent or marking an agent\nunreachable), before updating the important parts of the master's\nin-memory state (e.g., the in-memory list of registered agents).\nPreviously, the registry was updated first for registration and\nreregistration, but second for removal and marking unreachable.\nUpdating the registry first is simpler, and also avoids possibly\nleaking inaccurate information (e.g., via HTTP endpoints) if the\nregistry operation fails.\n\nReview: https://reviews.apache.org/r/51374","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/79296e1009957646c444f5c8e272c2ee60e7c547"},{"sha":"12bece86a1405756c8c325af41e3e06bc1161c7f","author":{"name":"Neil Conway","email":"4f41ed19fc3accf446ec9111a93682686fd4d3d9@gmail.com"},"message":"Introduced MockRegistrar.\n\nThis allows test cases to inspect how the master interacts with\nthe registry.\n\nThis commit changes `tests::cluster::Master` to use `MockRegistrar`\nexclusively, even for test cases that aren't interested in mocking\naspects of the master <-> registrar interaction. However, this should be\nharmless, since by default `MockRegistrar` behaves identically to the\nnormal registrar.\n\nReview: https://reviews.apache.org/r/51375","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/12bece86a1405756c8c325af41e3e06bc1161c7f"},{"sha":"503ff3bae97e28194f4bdb40f8252a21591020a5","author":{"name":"Neil Conway","email":"4f41ed19fc3accf446ec9111a93682686fd4d3d9@gmail.com"},"message":"Adjusted existing tests to use MockRegistrar.\n\nThis means that `Master::_reregisterSlave` can be made private.\n\nReview: https://reviews.apache.org/r/51376","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/503ff3bae97e28194f4bdb40f8252a21591020a5"},{"sha":"7782686ad68b224636a1e430dcdf72fab2f2f149","author":{"name":"Neil Conway","email":"4f41ed19fc3accf446ec9111a93682686fd4d3d9@gmail.com"},"message":"Added test for HTTP endpoints during slave removal.\n\nWhen a slave is being removed but before the registry operation to\nremove it has completed, querying the HTTP endpoints at the master\nshould not indicate that the slave has been removed yet. This is\nimportant because the registry update might fail; if the master\nfails over, the new master will not have removed the slave.\n\nReview: https://reviews.apache.org/r/51377","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/7782686ad68b224636a1e430dcdf72fab2f2f149"},{"sha":"4805ba6a8541c073b2db7d7ca3072f15fc4866b5","author":{"name":"Neil Conway","email":"4f41ed19fc3accf446ec9111a93682686fd4d3d9@gmail.com"},"message":"Added GC of unreachable agent metadata from the registry.\n\nInformation about agents that have been marked unreachable is stored\nin the registry. Since the number of unreachable agents can grow without\nbound, this commit implements a garbage collection scheme. The current\nleading master will periodically examine the registry and discard\ninformation about unreachable agents according to two criteria:\n`registry_max_agent_age` and `registry_max_agent_count`. The frequency\nwith which the master examines the registry is controlled by a third\nparameter, `registry_gc_interval`.\n\nReview: https://reviews.apache.org/r/51021","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/4805ba6a8541c073b2db7d7ca3072f15fc4866b5"},{"sha":"664560f4528561610b033faf21e76a78a1814387","author":{"name":"Neil Conway","email":"4f41ed19fc3accf446ec9111a93682686fd4d3d9@gmail.com"},"message":"Tweaked logging for UnregisterSlaveMessage handler.\n\nRemove a redundant log line: rather than logging when we receive\nan UnregisterSlaveMessage, it is sufficient to log how we handle\nthat message. Also ensure that we log when ignoring an agent\nunregister message for an unknown agent, and do some minor code\ncleanup.\n\nReview: https://reviews.apache.org/r/51706","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/664560f4528561610b033faf21e76a78a1814387"},{"sha":"f63c15a867d97b8b9c4946de55338ffd5b32131f","author":{"name":"Neil Conway","email":"4f41ed19fc3accf446ec9111a93682686fd4d3d9@gmail.com"},"message":"Handled agents failing health checks multiple times.\n\nNow that we wait for the agent to be removed from the registry before\nstopping the SlaveObserver, it is possible for an agent to fail health\nchecks multiple times if the registry operation takes longer than\n`agent_ping_timeout`.\n\nThis commit updates the master logic to handle this by ignoring health\ncheck failures while the registry operation to mark the agent\nunreachable is still in progress.\n\nReview: https://reviews.apache.org/r/51653","distinct":true,"url":"https://api.github.com/repos/neilconway/mesos/commits/f63c15a867d97b8b9c4946de55338ffd5b32131f"}]}
{"actor":{"display_login":"neilconway"}}