{"action":"created","comment":{"url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/pulls/comments/77793426","id":77793426,"diff_hunk":"@@ -29,22 +30,28 @@ class Issues extends React.Component {\n       sort: \"created\",\n       labels: \"\",\n       assignee: \"\"\n-    }\n+    },\n+    initialized: false,\n+    isLoading: false\n   };\n \n   componentWillMount() {\n-    this.props.readContributors();\n+    this.props.readContributors()\n+      .then(() => this.setState({initialized: true}));\n   };\n \n   updateFilter = (key, value) => {\n+    this.setState({isLoading: true});\n     const newFilter = Object.assign(this.state.filter, { [key] : value });\n     if(!value) delete newFilter[key];\n     this.setState({ filter: newFilter });\n-    this.props.readIssues(newFilter);\n+    this.props.readIssues(newFilter)\n+      .then(() => this.setState({isLoading: false}));\n   };\n \n   render() {\n-    if(!this.props.contributors.length) return (<div>LOADING</div>);\n+    const loading = (<div style={{textAlign:`center`, width:`100%`}}> <CircularProgress /> </div>);","path":"src/containers/About/Issues.js","position":36,"original_position":36,"commit_id":"4b6515461d273aafbdd90e2e27f550a4d05728a2","original_commit_id":"4b6515461d273aafbdd90e2e27f550a4d05728a2","user":{"login":"pjhjohn","id":2541685,"avatar_url":"https://avatars.githubusercontent.com/u/2541685?v=3","gravatar_id":"","url":"https://api.github.com/users/pjhjohn","html_url":"https://github.com/pjhjohn","followers_url":"https://api.github.com/users/pjhjohn/followers","following_url":"https://api.github.com/users/pjhjohn/following{/other_user}","gists_url":"https://api.github.com/users/pjhjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/pjhjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjhjohn/subscriptions","organizations_url":"https://api.github.com/users/pjhjohn/orgs","repos_url":"https://api.github.com/users/pjhjohn/repos","events_url":"https://api.github.com/users/pjhjohn/events{/privacy}","received_events_url":"https://api.github.com/users/pjhjohn/received_events","type":"User","site_admin":false},"body":"`CircularProgress` 자체가 `<div><svg/></div>` 처럼 구현되는데, 그냥\r\n`<CircularProgress style={{marginLeft: 'auto', marginRight: 'auto'}} />` 같은건 안되나요?","created_at":"2016-09-07T09:58:58Z","updated_at":"2016-09-07T09:58:58Z","html_url":"https://github.com/pjhjohn/jsonplaceholder-client/pull/58#discussion_r77793426","pull_request_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/pulls/58","_links":{"self":{"href":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/pulls/comments/77793426"},"html":{"href":"https://github.com/pjhjohn/jsonplaceholder-client/pull/58#discussion_r77793426"},"pull_request":{"href":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/pulls/58","id":84240340,"html_url":"https://github.com/pjhjohn/jsonplaceholder-client/pull/58","diff_url":"https://github.com/pjhjohn/jsonplaceholder-client/pull/58.diff","patch_url":"https://github.com/pjhjohn/jsonplaceholder-client/pull/58.patch","issue_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/issues/58","number":58,"state":"open","locked":false,"title":"Apply loading indicator","user":{"login":"lanieerts","id":20319253,"avatar_url":"https://avatars.githubusercontent.com/u/20319253?v=3","gravatar_id":"","url":"https://api.github.com/users/lanieerts","html_url":"https://github.com/lanieerts","followers_url":"https://api.github.com/users/lanieerts/followers","following_url":"https://api.github.com/users/lanieerts/following{/other_user}","gists_url":"https://api.github.com/users/lanieerts/gists{/gist_id}","starred_url":"https://api.github.com/users/lanieerts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanieerts/subscriptions","organizations_url":"https://api.github.com/users/lanieerts/orgs","repos_url":"https://api.github.com/users/lanieerts/repos","events_url":"https://api.github.com/users/lanieerts/events{/privacy}","received_events_url":"https://api.github.com/users/lanieerts/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-09-07T05:50:48Z","updated_at":"2016-09-07T09:58:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5ff766391fda8ee6a2c12debbf1f25943c993e4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/pulls/58/commits","review_comments_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/pulls/58/comments","review_comment_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/issues/58/comments","statuses_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/statuses/4b6515461d273aafbdd90e2e27f550a4d05728a2","head":{"label":"lanieerts:apply-loading-indicator","ref":"apply-loading-indicator","sha":"4b6515461d273aafbdd90e2e27f550a4d05728a2","user":{"login":"lanieerts","id":20319253,"avatar_url":"https://avatars.githubusercontent.com/u/20319253?v=3","gravatar_id":"","url":"https://api.github.com/users/lanieerts","html_url":"https://github.com/lanieerts","followers_url":"https://api.github.com/users/lanieerts/followers","following_url":"https://api.github.com/users/lanieerts/following{/other_user}","gists_url":"https://api.github.com/users/lanieerts/gists{/gist_id}","starred_url":"https://api.github.com/users/lanieerts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanieerts/subscriptions","organizations_url":"https://api.github.com/users/lanieerts/orgs","repos_url":"https://api.github.com/users/lanieerts/repos","events_url":"https://api.github.com/users/lanieerts/events{/privacy}","received_events_url":"https://api.github.com/users/lanieerts/received_events","type":"User","site_admin":false},"repo":{"id":66535854,"name":"jsonplaceholder-client","full_name":"lanieerts/jsonplaceholder-client","owner":{"login":"lanieerts","id":20319253,"avatar_url":"https://avatars.githubusercontent.com/u/20319253?v=3","gravatar_id":"","url":"https://api.github.com/users/lanieerts","html_url":"https://github.com/lanieerts","followers_url":"https://api.github.com/users/lanieerts/followers","following_url":"https://api.github.com/users/lanieerts/following{/other_user}","gists_url":"https://api.github.com/users/lanieerts/gists{/gist_id}","starred_url":"https://api.github.com/users/lanieerts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanieerts/subscriptions","organizations_url":"https://api.github.com/users/lanieerts/orgs","repos_url":"https://api.github.com/users/lanieerts/repos","events_url":"https://api.github.com/users/lanieerts/events{/privacy}","received_events_url":"https://api.github.com/users/lanieerts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lanieerts/jsonplaceholder-client","description":null,"fork":true,"url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client","forks_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/forks","keys_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/teams","hooks_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/hooks","issue_events_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/issues/events{/number}","events_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/events","assignees_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/assignees{/user}","branches_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/branches{/branch}","tags_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/tags","blobs_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/statuses/{sha}","languages_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/languages","stargazers_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/stargazers","contributors_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/contributors","subscribers_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/subscribers","subscription_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/subscription","commits_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/contents/{+path}","compare_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/merges","archive_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/downloads","issues_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/issues{/number}","pulls_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/pulls{/number}","milestones_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/milestones{/number}","notifications_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/labels{/name}","releases_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/releases{/id}","deployments_url":"https://api.github.com/repos/lanieerts/jsonplaceholder-client/deployments","created_at":"2016-08-25T07:33:38Z","updated_at":"2016-08-25T07:33:39Z","pushed_at":"2016-09-07T09:39:29Z","git_url":"git://github.com/lanieerts/jsonplaceholder-client.git","ssh_url":"git@github.com:lanieerts/jsonplaceholder-client.git","clone_url":"https://github.com/lanieerts/jsonplaceholder-client.git","svn_url":"https://github.com/lanieerts/jsonplaceholder-client","homepage":null,"size":196,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pjhjohn:master","ref":"master","sha":"a9bbf75daf71c7ce5a64a6cd77f37f79ec55bc05","user":{"login":"pjhjohn","id":2541685,"avatar_url":"https://avatars.githubusercontent.com/u/2541685?v=3","gravatar_id":"","url":"https://api.github.com/users/pjhjohn","html_url":"https://github.com/pjhjohn","followers_url":"https://api.github.com/users/pjhjohn/followers","following_url":"https://api.github.com/users/pjhjohn/following{/other_user}","gists_url":"https://api.github.com/users/pjhjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/pjhjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjhjohn/subscriptions","organizations_url":"https://api.github.com/users/pjhjohn/orgs","repos_url":"https://api.github.com/users/pjhjohn/repos","events_url":"https://api.github.com/users/pjhjohn/events{/privacy}","received_events_url":"https://api.github.com/users/pjhjohn/received_events","type":"User","site_admin":false},"repo":{"id":64640303,"name":"jsonplaceholder-client","full_name":"pjhjohn/jsonplaceholder-client","owner":{"login":"pjhjohn","id":2541685,"avatar_url":"https://avatars.githubusercontent.com/u/2541685?v=3","gravatar_id":"","url":"https://api.github.com/users/pjhjohn","html_url":"https://github.com/pjhjohn","followers_url":"https://api.github.com/users/pjhjohn/followers","following_url":"https://api.github.com/users/pjhjohn/following{/other_user}","gists_url":"https://api.github.com/users/pjhjohn/gists{/gist_id}","starred_url":"https://api.github.com/users/pjhjohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjhjohn/subscriptions","organizations_url":"https://api.github.com/users/pjhjohn/orgs","repos_url":"https://api.github.com/users/pjhjohn/repos","events_url":"https://api.github.com/users/pjhjohn/events{/privacy}","received_events_url":"https://api.github.com/users/pjhjohn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pjhjohn/jsonplaceholder-client","description":null,"fork":false,"url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client","forks_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/forks","keys_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/teams","hooks_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/hooks","issue_events_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/issues/events{/number}","events_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/events","assignees_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/assignees{/user}","branches_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/branches{/branch}","tags_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/tags","blobs_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/statuses/{sha}","languages_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/languages","stargazers_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/stargazers","contributors_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/contributors","subscribers_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/subscribers","subscription_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/subscription","commits_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/contents/{+path}","compare_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/merges","archive_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/downloads","issues_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/issues{/number}","pulls_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/pulls{/number}","milestones_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/milestones{/number}","notifications_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/labels{/name}","releases_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/releases{/id}","deployments_url":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/deployments","created_at":"2016-08-01T06:05:35Z","updated_at":"2016-08-28T13:43:58Z","pushed_at":"2016-09-07T09:39:30Z","git_url":"git://github.com/pjhjohn/jsonplaceholder-client.git","ssh_url":"git@github.com:pjhjohn/jsonplaceholder-client.git","clone_url":"https://github.com/pjhjohn/jsonplaceholder-client.git","svn_url":"https://github.com/pjhjohn/jsonplaceholder-client","homepage":null,"size":306,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":6,"forks":4,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/pulls/58"},"html":{"href":"https://github.com/pjhjohn/jsonplaceholder-client/pull/58"},"issue":{"href":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/issues/58"},"comments":{"href":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/pjhjohn/jsonplaceholder-client/statuses/4b6515461d273aafbdd90e2e27f550a4d05728a2"}}}}
{"actor":{"display_login":"pjhjohn"}}