{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments/70921219","id":70921219,"diff_hunk":"@@ -1114,26 +1117,61 @@ - (void)__layout\n   ASDisplayNodeAssertMainThread();\n   ASDN::MutexLocker l(_propertyLock);\n   CGRect bounds = self.bounds;\n+\n+  [self measureNodeWithBoundsIfNecessary:bounds];\n+\n   if (CGRectEqualToRect(bounds, CGRectZero)) {\n     // Performing layout on a zero-bounds view often results in frame calculations\n     // with negative sizes after applying margins, which will cause\n     // measureWithSizeRange: on subnodes to assert.\n     return;\n   }\n-\n+  \n   // Handle placeholder layer creation in case the size of the node changed after the initial placeholder layer\n   // was created\n   if ([self _shouldHavePlaceholderLayer]) {\n     [self _setupPlaceholderLayerIfNeeded];\n   }\n   _placeholderLayer.frame = bounds;\n-\n+  \n   [self layout];\n   [self layoutDidFinish];\n }\n \n+- (void)measureNodeWithBoundsIfNecessary:(CGRect)bounds\n+{\n+  // Normally measure will be called before layout occurs. If this doesn't happen, nothing is going to call it at all.\n+  // We simply call measureWithSizeRange: using a size range equal to whatever bounds were provided to that element\n+  if (self.supernode == nil && !self.supportsRangeManagedInterfaceState && [self _hasDirtyLayout]) {","path":"AsyncDisplayKit/ASDisplayNode.mm","position":54,"original_position":54,"commit_id":"923b3b80b3de9ec90259b6b6b3444a640ab5b8d4","original_commit_id":"923b3b80b3de9ec90259b6b6b3444a640ab5b8d4","user":{"login":"appleguy","id":565251,"avatar_url":"https://avatars.githubusercontent.com/u/565251?v=3","gravatar_id":"","url":"https://api.github.com/users/appleguy","html_url":"https://github.com/appleguy","followers_url":"https://api.github.com/users/appleguy/followers","following_url":"https://api.github.com/users/appleguy/following{/other_user}","gists_url":"https://api.github.com/users/appleguy/gists{/gist_id}","starred_url":"https://api.github.com/users/appleguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleguy/subscriptions","organizations_url":"https://api.github.com/users/appleguy/orgs","repos_url":"https://api.github.com/users/appleguy/repos","events_url":"https://api.github.com/users/appleguy/events{/privacy}","received_events_url":"https://api.github.com/users/appleguy/received_events","type":"User","site_admin":false},"body":"@maicki what about ASViewController?  I think there is a way to override the constrainedSize, but the .node has no supernode, is not range managed, etc.  This may be handled by _hasDirtyLayout, not sure.","created_at":"2016-07-15T04:47:53Z","updated_at":"2016-07-15T04:47:53Z","html_url":"https://github.com/facebook/AsyncDisplayKit/pull/1725#discussion_r70921219","pull_request_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1725","_links":{"self":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments/70921219"},"html":{"href":"https://github.com/facebook/AsyncDisplayKit/pull/1725#discussion_r70921219"},"pull_request":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1725"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1725","id":73095926,"html_url":"https://github.com/facebook/AsyncDisplayKit/pull/1725","diff_url":"https://github.com/facebook/AsyncDisplayKit/pull/1725.diff","patch_url":"https://github.com/facebook/AsyncDisplayKit/pull/1725.patch","issue_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1725","number":1725,"state":"open","locked":false,"title":"[ASDisplayNode] Add automatic measurement before layout","user":{"login":"maicki","id":25288,"avatar_url":"https://avatars.githubusercontent.com/u/25288?v=3","gravatar_id":"","url":"https://api.github.com/users/maicki","html_url":"https://github.com/maicki","followers_url":"https://api.github.com/users/maicki/followers","following_url":"https://api.github.com/users/maicki/following{/other_user}","gists_url":"https://api.github.com/users/maicki/gists{/gist_id}","starred_url":"https://api.github.com/users/maicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maicki/subscriptions","organizations_url":"https://api.github.com/users/maicki/orgs","repos_url":"https://api.github.com/users/maicki/repos","events_url":"https://api.github.com/users/maicki/events{/privacy}","received_events_url":"https://api.github.com/users/maicki/received_events","type":"User","site_admin":false},"body":"Fix original PR ( #1673 ) that was reverted (#1717)\r\n\r\n- Layout should happen with size as large as possible\r\n- Fix wrong logic around layout `_hasDirtyLayout` check","created_at":"2016-06-08T18:24:12Z","updated_at":"2016-07-15T04:47:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d52110977f52df0d3cff6d46fc7f108f98e3aecc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1725/commits","review_comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1725/comments","review_comment_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1725/comments","statuses_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/923b3b80b3de9ec90259b6b6b3444a640ab5b8d4","head":{"label":"maicki:AutomaticMeasurementOnLayout","ref":"AutomaticMeasurementOnLayout","sha":"923b3b80b3de9ec90259b6b6b3444a640ab5b8d4","user":{"login":"maicki","id":25288,"avatar_url":"https://avatars.githubusercontent.com/u/25288?v=3","gravatar_id":"","url":"https://api.github.com/users/maicki","html_url":"https://github.com/maicki","followers_url":"https://api.github.com/users/maicki/followers","following_url":"https://api.github.com/users/maicki/following{/other_user}","gists_url":"https://api.github.com/users/maicki/gists{/gist_id}","starred_url":"https://api.github.com/users/maicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maicki/subscriptions","organizations_url":"https://api.github.com/users/maicki/orgs","repos_url":"https://api.github.com/users/maicki/repos","events_url":"https://api.github.com/users/maicki/events{/privacy}","received_events_url":"https://api.github.com/users/maicki/received_events","type":"User","site_admin":false},"repo":{"id":50892794,"name":"AsyncDisplayKit","full_name":"maicki/AsyncDisplayKit","owner":{"login":"maicki","id":25288,"avatar_url":"https://avatars.githubusercontent.com/u/25288?v=3","gravatar_id":"","url":"https://api.github.com/users/maicki","html_url":"https://github.com/maicki","followers_url":"https://api.github.com/users/maicki/followers","following_url":"https://api.github.com/users/maicki/following{/other_user}","gists_url":"https://api.github.com/users/maicki/gists{/gist_id}","starred_url":"https://api.github.com/users/maicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maicki/subscriptions","organizations_url":"https://api.github.com/users/maicki/orgs","repos_url":"https://api.github.com/users/maicki/repos","events_url":"https://api.github.com/users/maicki/events{/privacy}","received_events_url":"https://api.github.com/users/maicki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maicki/AsyncDisplayKit","description":"Smooth asynchronous user interfaces for iOS apps.","fork":true,"url":"https://api.github.com/repos/maicki/AsyncDisplayKit","forks_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/forks","keys_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/teams","hooks_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/hooks","issue_events_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/issues/events{/number}","events_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/events","assignees_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/assignees{/user}","branches_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/branches{/branch}","tags_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/tags","blobs_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/statuses/{sha}","languages_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/languages","stargazers_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/stargazers","contributors_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/contributors","subscribers_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/subscribers","subscription_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/subscription","commits_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/contents/{+path}","compare_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/merges","archive_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/downloads","issues_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/issues{/number}","pulls_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/pulls{/number}","milestones_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/milestones{/number}","notifications_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/labels{/name}","releases_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/releases{/id}","deployments_url":"https://api.github.com/repos/maicki/AsyncDisplayKit/deployments","created_at":"2016-02-02T03:59:55Z","updated_at":"2016-04-23T02:52:21Z","pushed_at":"2016-07-15T03:44:45Z","git_url":"git://github.com/maicki/AsyncDisplayKit.git","ssh_url":"git@github.com:maicki/AsyncDisplayKit.git","clone_url":"https://github.com/maicki/AsyncDisplayKit.git","svn_url":"https://github.com/maicki/AsyncDisplayKit","homepage":"http://asyncdisplaykit.org","size":46920,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"f95790f280a81e8b455328e52f171bb01d05be68","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":21265042,"name":"AsyncDisplayKit","full_name":"facebook/AsyncDisplayKit","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/AsyncDisplayKit","description":"Smooth asynchronous user interfaces for iOS apps.","fork":false,"url":"https://api.github.com/repos/facebook/AsyncDisplayKit","forks_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/forks","keys_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/teams","hooks_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/hooks","issue_events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/events","assignees_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/tags","blobs_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/languages","stargazers_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/stargazers","contributors_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/contributors","subscribers_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/subscribers","subscription_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/subscription","commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/merges","archive_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/downloads","issues_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/labels{/name}","releases_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/AsyncDisplayKit/deployments","created_at":"2014-06-27T05:29:02Z","updated_at":"2016-07-15T02:59:49Z","pushed_at":"2016-07-15T04:35:59Z","git_url":"git://github.com/facebook/AsyncDisplayKit.git","ssh_url":"git@github.com:facebook/AsyncDisplayKit.git","clone_url":"https://github.com/facebook/AsyncDisplayKit.git","svn_url":"https://github.com/facebook/AsyncDisplayKit","homepage":"http://asyncdisplaykit.org","size":71972,"stargazers_count":8659,"watchers_count":8659,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1462,"mirror_url":null,"open_issues_count":114,"forks":1462,"open_issues":114,"watchers":8659,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1725"},"html":{"href":"https://github.com/facebook/AsyncDisplayKit/pull/1725"},"issue":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1725"},"comments":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/issues/1725/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1725/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/pulls/1725/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/AsyncDisplayKit/statuses/923b3b80b3de9ec90259b6b6b3444a640ab5b8d4"}}}}
{"actor":{"display_login":"appleguy"}}