{"action":"created","comment":{"url":"https://api.github.com/repos/attic-labs/noms/pulls/comments/77712524","id":77712524,"diff_hunk":"@@ -126,19 +126,19 @@ func (s Struct) Set(n string, v Value) Struct {\n \treturn Struct{values, s.t, &hash.Hash{}}\n }\n \n-func (s1 Struct) Diff(s2 Struct, changes chan<- ValueChanged, closeChan <-chan struct{}) {\n-\tif s1.Equals(s2) {\n+func (s Struct) Diff(last Struct, changes chan<- ValueChanged, closeChan <-chan struct{}) {\n+\tif s.Equals(last) {","path":"go/types/struct.go","position":7,"original_position":7,"commit_id":"aef6672d81b5b8566bbcf8e893ccfdd7dc315c22","original_commit_id":"aef6672d81b5b8566bbcf8e893ccfdd7dc315c22","user":{"login":"willhite","id":487362,"avatar_url":"https://avatars.githubusercontent.com/u/487362?v=3","gravatar_id":"","url":"https://api.github.com/users/willhite","html_url":"https://github.com/willhite","followers_url":"https://api.github.com/users/willhite/followers","following_url":"https://api.github.com/users/willhite/following{/other_user}","gists_url":"https://api.github.com/users/willhite/gists{/gist_id}","starred_url":"https://api.github.com/users/willhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willhite/subscriptions","organizations_url":"https://api.github.com/users/willhite/orgs","repos_url":"https://api.github.com/users/willhite/repos","events_url":"https://api.github.com/users/willhite/events{/privacy}","received_events_url":"https://api.github.com/users/willhite/received_events","type":"User","site_admin":false},"body":"Just a suggestion, would \"other\" be a better variable name than \"last\"?","created_at":"2016-09-06T20:30:28Z","updated_at":"2016-09-06T20:30:28Z","html_url":"https://github.com/attic-labs/noms/pull/2521#discussion_r77712524","pull_request_url":"https://api.github.com/repos/attic-labs/noms/pulls/2521","_links":{"self":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/comments/77712524"},"html":{"href":"https://github.com/attic-labs/noms/pull/2521#discussion_r77712524"},"pull_request":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/2521"}}},"pull_request":{"url":"https://api.github.com/repos/attic-labs/noms/pulls/2521","id":84183386,"html_url":"https://github.com/attic-labs/noms/pull/2521","diff_url":"https://github.com/attic-labs/noms/pull/2521.diff","patch_url":"https://github.com/attic-labs/noms/pull/2521.patch","issue_url":"https://api.github.com/repos/attic-labs/noms/issues/2521","number":2521,"state":"open","locked":false,"title":"Improve code based on tool analysis feeback","user":{"login":"mikegray","id":17547,"avatar_url":"https://avatars.githubusercontent.com/u/17547?v=3","gravatar_id":"","url":"https://api.github.com/users/mikegray","html_url":"https://github.com/mikegray","followers_url":"https://api.github.com/users/mikegray/followers","following_url":"https://api.github.com/users/mikegray/following{/other_user}","gists_url":"https://api.github.com/users/mikegray/gists{/gist_id}","starred_url":"https://api.github.com/users/mikegray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikegray/subscriptions","organizations_url":"https://api.github.com/users/mikegray/orgs","repos_url":"https://api.github.com/users/mikegray/repos","events_url":"https://api.github.com/users/mikegray/events{/privacy}","received_events_url":"https://api.github.com/users/mikegray/received_events","type":"User","site_admin":false},"body":"\r\nFixes are based on Go report card output:\r\n- `gofmt -s` eliminates some duplication in struct/slice initialization\r\n- `golint` found some issues like: `warning: should drop = nil from declaration of var XXX; it is the zero value`\r\n- `golint` found some issues like: `warning: receiver name XXX should be consistent with previous receiver name YYY for ZZZ`\r\n- `golint` says not to use underscores for function/variable names\r\n- `golint` found several issues like: `warning: if block ends with a return statement, so drop this else and outdent its block`\r\n\r\nNo functional changes are included - just source code quality improvements.","created_at":"2016-09-06T19:41:36Z","updated_at":"2016-09-06T20:30:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e6e5beb9e0165786e1028c1959801d6dae64fd0","assignee":{"login":"willhite","id":487362,"avatar_url":"https://avatars.githubusercontent.com/u/487362?v=3","gravatar_id":"","url":"https://api.github.com/users/willhite","html_url":"https://github.com/willhite","followers_url":"https://api.github.com/users/willhite/followers","following_url":"https://api.github.com/users/willhite/following{/other_user}","gists_url":"https://api.github.com/users/willhite/gists{/gist_id}","starred_url":"https://api.github.com/users/willhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willhite/subscriptions","organizations_url":"https://api.github.com/users/willhite/orgs","repos_url":"https://api.github.com/users/willhite/repos","events_url":"https://api.github.com/users/willhite/events{/privacy}","received_events_url":"https://api.github.com/users/willhite/received_events","type":"User","site_admin":false},"assignees":[{"login":"willhite","id":487362,"avatar_url":"https://avatars.githubusercontent.com/u/487362?v=3","gravatar_id":"","url":"https://api.github.com/users/willhite","html_url":"https://github.com/willhite","followers_url":"https://api.github.com/users/willhite/followers","following_url":"https://api.github.com/users/willhite/following{/other_user}","gists_url":"https://api.github.com/users/willhite/gists{/gist_id}","starred_url":"https://api.github.com/users/willhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willhite/subscriptions","organizations_url":"https://api.github.com/users/willhite/orgs","repos_url":"https://api.github.com/users/willhite/repos","events_url":"https://api.github.com/users/willhite/events{/privacy}","received_events_url":"https://api.github.com/users/willhite/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/attic-labs/noms/pulls/2521/commits","review_comments_url":"https://api.github.com/repos/attic-labs/noms/pulls/2521/comments","review_comment_url":"https://api.github.com/repos/attic-labs/noms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/attic-labs/noms/issues/2521/comments","statuses_url":"https://api.github.com/repos/attic-labs/noms/statuses/aef6672d81b5b8566bbcf8e893ccfdd7dc315c22","head":{"label":"mikegray:bld","ref":"bld","sha":"aef6672d81b5b8566bbcf8e893ccfdd7dc315c22","user":{"login":"mikegray","id":17547,"avatar_url":"https://avatars.githubusercontent.com/u/17547?v=3","gravatar_id":"","url":"https://api.github.com/users/mikegray","html_url":"https://github.com/mikegray","followers_url":"https://api.github.com/users/mikegray/followers","following_url":"https://api.github.com/users/mikegray/following{/other_user}","gists_url":"https://api.github.com/users/mikegray/gists{/gist_id}","starred_url":"https://api.github.com/users/mikegray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikegray/subscriptions","organizations_url":"https://api.github.com/users/mikegray/orgs","repos_url":"https://api.github.com/users/mikegray/repos","events_url":"https://api.github.com/users/mikegray/events{/privacy}","received_events_url":"https://api.github.com/users/mikegray/received_events","type":"User","site_admin":false},"repo":{"id":64779122,"name":"noms","full_name":"mikegray/noms","owner":{"login":"mikegray","id":17547,"avatar_url":"https://avatars.githubusercontent.com/u/17547?v=3","gravatar_id":"","url":"https://api.github.com/users/mikegray","html_url":"https://github.com/mikegray","followers_url":"https://api.github.com/users/mikegray/followers","following_url":"https://api.github.com/users/mikegray/following{/other_user}","gists_url":"https://api.github.com/users/mikegray/gists{/gist_id}","starred_url":"https://api.github.com/users/mikegray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikegray/subscriptions","organizations_url":"https://api.github.com/users/mikegray/orgs","repos_url":"https://api.github.com/users/mikegray/repos","events_url":"https://api.github.com/users/mikegray/events{/privacy}","received_events_url":"https://api.github.com/users/mikegray/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikegray/noms","description":"The versioned, forkable, syncable database","fork":true,"url":"https://api.github.com/repos/mikegray/noms","forks_url":"https://api.github.com/repos/mikegray/noms/forks","keys_url":"https://api.github.com/repos/mikegray/noms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikegray/noms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikegray/noms/teams","hooks_url":"https://api.github.com/repos/mikegray/noms/hooks","issue_events_url":"https://api.github.com/repos/mikegray/noms/issues/events{/number}","events_url":"https://api.github.com/repos/mikegray/noms/events","assignees_url":"https://api.github.com/repos/mikegray/noms/assignees{/user}","branches_url":"https://api.github.com/repos/mikegray/noms/branches{/branch}","tags_url":"https://api.github.com/repos/mikegray/noms/tags","blobs_url":"https://api.github.com/repos/mikegray/noms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikegray/noms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikegray/noms/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikegray/noms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikegray/noms/statuses/{sha}","languages_url":"https://api.github.com/repos/mikegray/noms/languages","stargazers_url":"https://api.github.com/repos/mikegray/noms/stargazers","contributors_url":"https://api.github.com/repos/mikegray/noms/contributors","subscribers_url":"https://api.github.com/repos/mikegray/noms/subscribers","subscription_url":"https://api.github.com/repos/mikegray/noms/subscription","commits_url":"https://api.github.com/repos/mikegray/noms/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikegray/noms/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikegray/noms/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikegray/noms/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikegray/noms/contents/{+path}","compare_url":"https://api.github.com/repos/mikegray/noms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikegray/noms/merges","archive_url":"https://api.github.com/repos/mikegray/noms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikegray/noms/downloads","issues_url":"https://api.github.com/repos/mikegray/noms/issues{/number}","pulls_url":"https://api.github.com/repos/mikegray/noms/pulls{/number}","milestones_url":"https://api.github.com/repos/mikegray/noms/milestones{/number}","notifications_url":"https://api.github.com/repos/mikegray/noms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikegray/noms/labels{/name}","releases_url":"https://api.github.com/repos/mikegray/noms/releases{/id}","deployments_url":"https://api.github.com/repos/mikegray/noms/deployments","created_at":"2016-08-02T17:48:56Z","updated_at":"2016-08-02T17:48:58Z","pushed_at":"2016-09-06T19:43:35Z","git_url":"git://github.com/mikegray/noms.git","ssh_url":"git@github.com:mikegray/noms.git","clone_url":"https://github.com/mikegray/noms.git","svn_url":"https://github.com/mikegray/noms","homepage":"","size":25563,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"attic-labs:master","ref":"master","sha":"3cdebb7e771effae10a93bc3c8fc7542d7fc7c8e","user":{"login":"attic-labs","id":12534679,"avatar_url":"https://avatars.githubusercontent.com/u/12534679?v=3","gravatar_id":"","url":"https://api.github.com/users/attic-labs","html_url":"https://github.com/attic-labs","followers_url":"https://api.github.com/users/attic-labs/followers","following_url":"https://api.github.com/users/attic-labs/following{/other_user}","gists_url":"https://api.github.com/users/attic-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/attic-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/attic-labs/subscriptions","organizations_url":"https://api.github.com/users/attic-labs/orgs","repos_url":"https://api.github.com/users/attic-labs/repos","events_url":"https://api.github.com/users/attic-labs/events{/privacy}","received_events_url":"https://api.github.com/users/attic-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":36778364,"name":"noms","full_name":"attic-labs/noms","owner":{"login":"attic-labs","id":12534679,"avatar_url":"https://avatars.githubusercontent.com/u/12534679?v=3","gravatar_id":"","url":"https://api.github.com/users/attic-labs","html_url":"https://github.com/attic-labs","followers_url":"https://api.github.com/users/attic-labs/followers","following_url":"https://api.github.com/users/attic-labs/following{/other_user}","gists_url":"https://api.github.com/users/attic-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/attic-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/attic-labs/subscriptions","organizations_url":"https://api.github.com/users/attic-labs/orgs","repos_url":"https://api.github.com/users/attic-labs/repos","events_url":"https://api.github.com/users/attic-labs/events{/privacy}","received_events_url":"https://api.github.com/users/attic-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/attic-labs/noms","description":"The versioned, forkable, syncable database","fork":false,"url":"https://api.github.com/repos/attic-labs/noms","forks_url":"https://api.github.com/repos/attic-labs/noms/forks","keys_url":"https://api.github.com/repos/attic-labs/noms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/attic-labs/noms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/attic-labs/noms/teams","hooks_url":"https://api.github.com/repos/attic-labs/noms/hooks","issue_events_url":"https://api.github.com/repos/attic-labs/noms/issues/events{/number}","events_url":"https://api.github.com/repos/attic-labs/noms/events","assignees_url":"https://api.github.com/repos/attic-labs/noms/assignees{/user}","branches_url":"https://api.github.com/repos/attic-labs/noms/branches{/branch}","tags_url":"https://api.github.com/repos/attic-labs/noms/tags","blobs_url":"https://api.github.com/repos/attic-labs/noms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/attic-labs/noms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/attic-labs/noms/git/refs{/sha}","trees_url":"https://api.github.com/repos/attic-labs/noms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/attic-labs/noms/statuses/{sha}","languages_url":"https://api.github.com/repos/attic-labs/noms/languages","stargazers_url":"https://api.github.com/repos/attic-labs/noms/stargazers","contributors_url":"https://api.github.com/repos/attic-labs/noms/contributors","subscribers_url":"https://api.github.com/repos/attic-labs/noms/subscribers","subscription_url":"https://api.github.com/repos/attic-labs/noms/subscription","commits_url":"https://api.github.com/repos/attic-labs/noms/commits{/sha}","git_commits_url":"https://api.github.com/repos/attic-labs/noms/git/commits{/sha}","comments_url":"https://api.github.com/repos/attic-labs/noms/comments{/number}","issue_comment_url":"https://api.github.com/repos/attic-labs/noms/issues/comments{/number}","contents_url":"https://api.github.com/repos/attic-labs/noms/contents/{+path}","compare_url":"https://api.github.com/repos/attic-labs/noms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/attic-labs/noms/merges","archive_url":"https://api.github.com/repos/attic-labs/noms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/attic-labs/noms/downloads","issues_url":"https://api.github.com/repos/attic-labs/noms/issues{/number}","pulls_url":"https://api.github.com/repos/attic-labs/noms/pulls{/number}","milestones_url":"https://api.github.com/repos/attic-labs/noms/milestones{/number}","notifications_url":"https://api.github.com/repos/attic-labs/noms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/attic-labs/noms/labels{/name}","releases_url":"https://api.github.com/repos/attic-labs/noms/releases{/id}","deployments_url":"https://api.github.com/repos/attic-labs/noms/deployments","created_at":"2015-06-03T03:44:49Z","updated_at":"2016-09-06T14:23:22Z","pushed_at":"2016-09-06T20:23:53Z","git_url":"git://github.com/attic-labs/noms.git","ssh_url":"git@github.com:attic-labs/noms.git","clone_url":"https://github.com/attic-labs/noms.git","svn_url":"https://github.com/attic-labs/noms","homepage":"","size":28991,"stargazers_count":4217,"watchers_count":4217,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":107,"mirror_url":null,"open_issues_count":217,"forks":107,"open_issues":217,"watchers":4217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/2521"},"html":{"href":"https://github.com/attic-labs/noms/pull/2521"},"issue":{"href":"https://api.github.com/repos/attic-labs/noms/issues/2521"},"comments":{"href":"https://api.github.com/repos/attic-labs/noms/issues/2521/comments"},"review_comments":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/2521/comments"},"review_comment":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/attic-labs/noms/pulls/2521/commits"},"statuses":{"href":"https://api.github.com/repos/attic-labs/noms/statuses/aef6672d81b5b8566bbcf8e893ccfdd7dc315c22"}}}}
{"actor":{"display_login":"willhite"}}