{"action":"created","comment":{"url":"https://api.github.com/repos/enthought/pyface/pulls/comments/70737041","id":70737041,"diff_hunk":"@@ -0,0 +1,72 @@\n+import unittest\n+\n+from traits.testing.unittest_tools import UnittestTools\n+from pyface.tasks.api import Task\n+from ..task_window import TaskWindow\n+\n+\n+class TestTaskWindow(unittest.TestCase, UnittestTools):\n+\n+    def test_title(self):\n+        task_1 = Task(name='Test Task')\n+        task_2 = Task(name='Test Task 2')\n+        task_window = TaskWindow(tasks=[task_1, task_2])\n+\n+        # initially nothing","path":"pyface/tasks/tests/test_task_window.py","position":15,"original_position":15,"commit_id":"9c88f40885d8b2838a10ffc0ef10f8b7e04d718c","original_commit_id":"9c88f40885d8b2838a10ffc0ef10f8b7e04d718c","user":{"login":"jonathanrocher","id":593945,"avatar_url":"https://avatars.githubusercontent.com/u/593945?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanrocher","html_url":"https://github.com/jonathanrocher","followers_url":"https://api.github.com/users/jonathanrocher/followers","following_url":"https://api.github.com/users/jonathanrocher/following{/other_user}","gists_url":"https://api.github.com/users/jonathanrocher/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanrocher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanrocher/subscriptions","organizations_url":"https://api.github.com/users/jonathanrocher/orgs","repos_url":"https://api.github.com/users/jonathanrocher/repos","events_url":"https://api.github.com/users/jonathanrocher/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanrocher/received_events","type":"User","site_admin":false},"body":"I would recommend to break each of these sections to a separate test to make them more granular.","created_at":"2016-07-14T01:37:14Z","updated_at":"2016-07-14T01:37:14Z","html_url":"https://github.com/enthought/pyface/pull/225#discussion_r70737041","pull_request_url":"https://api.github.com/repos/enthought/pyface/pulls/225","_links":{"self":{"href":"https://api.github.com/repos/enthought/pyface/pulls/comments/70737041"},"html":{"href":"https://github.com/enthought/pyface/pull/225#discussion_r70737041"},"pull_request":{"href":"https://api.github.com/repos/enthought/pyface/pulls/225"}}},"pull_request":{"url":"https://api.github.com/repos/enthought/pyface/pulls/225","id":77251155,"html_url":"https://github.com/enthought/pyface/pull/225","diff_url":"https://github.com/enthought/pyface/pull/225.diff","patch_url":"https://github.com/enthought/pyface/pull/225.patch","issue_url":"https://api.github.com/repos/enthought/pyface/issues/225","number":225,"state":"open","locked":false,"title":"Fix task window title","user":{"login":"corranwebster","id":600761,"avatar_url":"https://avatars.githubusercontent.com/u/600761?v=3","gravatar_id":"","url":"https://api.github.com/users/corranwebster","html_url":"https://github.com/corranwebster","followers_url":"https://api.github.com/users/corranwebster/followers","following_url":"https://api.github.com/users/corranwebster/following{/other_user}","gists_url":"https://api.github.com/users/corranwebster/gists{/gist_id}","starred_url":"https://api.github.com/users/corranwebster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corranwebster/subscriptions","organizations_url":"https://api.github.com/users/corranwebster/orgs","repos_url":"https://api.github.com/users/corranwebster/repos","events_url":"https://api.github.com/users/corranwebster/events{/privacy}","received_events_url":"https://api.github.com/users/corranwebster/received_events","type":"User","site_admin":false},"body":"Fixes #218.  Includes tests.  We now listen to `active_task.name` instead of just `active_task`.","created_at":"2016-07-13T08:46:37Z","updated_at":"2016-07-14T01:37:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"866602b4b1232e23f3bf66a9220448497397cb89","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/enthought/pyface/pulls/225/commits","review_comments_url":"https://api.github.com/repos/enthought/pyface/pulls/225/comments","review_comment_url":"https://api.github.com/repos/enthought/pyface/pulls/comments{/number}","comments_url":"https://api.github.com/repos/enthought/pyface/issues/225/comments","statuses_url":"https://api.github.com/repos/enthought/pyface/statuses/9c88f40885d8b2838a10ffc0ef10f8b7e04d718c","head":{"label":"enthought:fix/task-window-title","ref":"fix/task-window-title","sha":"9c88f40885d8b2838a10ffc0ef10f8b7e04d718c","user":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=3","gravatar_id":"","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"repo":{"id":1632976,"name":"pyface","full_name":"enthought/pyface","owner":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=3","gravatar_id":"","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enthought/pyface","description":"pyface: traits-capable windowing framework","fork":false,"url":"https://api.github.com/repos/enthought/pyface","forks_url":"https://api.github.com/repos/enthought/pyface/forks","keys_url":"https://api.github.com/repos/enthought/pyface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enthought/pyface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enthought/pyface/teams","hooks_url":"https://api.github.com/repos/enthought/pyface/hooks","issue_events_url":"https://api.github.com/repos/enthought/pyface/issues/events{/number}","events_url":"https://api.github.com/repos/enthought/pyface/events","assignees_url":"https://api.github.com/repos/enthought/pyface/assignees{/user}","branches_url":"https://api.github.com/repos/enthought/pyface/branches{/branch}","tags_url":"https://api.github.com/repos/enthought/pyface/tags","blobs_url":"https://api.github.com/repos/enthought/pyface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enthought/pyface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enthought/pyface/git/refs{/sha}","trees_url":"https://api.github.com/repos/enthought/pyface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enthought/pyface/statuses/{sha}","languages_url":"https://api.github.com/repos/enthought/pyface/languages","stargazers_url":"https://api.github.com/repos/enthought/pyface/stargazers","contributors_url":"https://api.github.com/repos/enthought/pyface/contributors","subscribers_url":"https://api.github.com/repos/enthought/pyface/subscribers","subscription_url":"https://api.github.com/repos/enthought/pyface/subscription","commits_url":"https://api.github.com/repos/enthought/pyface/commits{/sha}","git_commits_url":"https://api.github.com/repos/enthought/pyface/git/commits{/sha}","comments_url":"https://api.github.com/repos/enthought/pyface/comments{/number}","issue_comment_url":"https://api.github.com/repos/enthought/pyface/issues/comments{/number}","contents_url":"https://api.github.com/repos/enthought/pyface/contents/{+path}","compare_url":"https://api.github.com/repos/enthought/pyface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enthought/pyface/merges","archive_url":"https://api.github.com/repos/enthought/pyface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enthought/pyface/downloads","issues_url":"https://api.github.com/repos/enthought/pyface/issues{/number}","pulls_url":"https://api.github.com/repos/enthought/pyface/pulls{/number}","milestones_url":"https://api.github.com/repos/enthought/pyface/milestones{/number}","notifications_url":"https://api.github.com/repos/enthought/pyface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enthought/pyface/labels{/name}","releases_url":"https://api.github.com/repos/enthought/pyface/releases{/id}","deployments_url":"https://api.github.com/repos/enthought/pyface/deployments","created_at":"2011-04-18T22:32:06Z","updated_at":"2016-06-23T14:36:22Z","pushed_at":"2016-07-13T15:22:31Z","git_url":"git://github.com/enthought/pyface.git","ssh_url":"git@github.com:enthought/pyface.git","clone_url":"https://github.com/enthought/pyface.git","svn_url":"https://github.com/enthought/pyface","homepage":"","size":16101,"stargazers_count":33,"watchers_count":33,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"open_issues_count":39,"forks":24,"open_issues":39,"watchers":33,"default_branch":"master"}},"base":{"label":"enthought:master","ref":"master","sha":"c1b5cd65918b91ed248cb10340e15662ed476dc7","user":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=3","gravatar_id":"","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"repo":{"id":1632976,"name":"pyface","full_name":"enthought/pyface","owner":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=3","gravatar_id":"","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enthought/pyface","description":"pyface: traits-capable windowing framework","fork":false,"url":"https://api.github.com/repos/enthought/pyface","forks_url":"https://api.github.com/repos/enthought/pyface/forks","keys_url":"https://api.github.com/repos/enthought/pyface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enthought/pyface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enthought/pyface/teams","hooks_url":"https://api.github.com/repos/enthought/pyface/hooks","issue_events_url":"https://api.github.com/repos/enthought/pyface/issues/events{/number}","events_url":"https://api.github.com/repos/enthought/pyface/events","assignees_url":"https://api.github.com/repos/enthought/pyface/assignees{/user}","branches_url":"https://api.github.com/repos/enthought/pyface/branches{/branch}","tags_url":"https://api.github.com/repos/enthought/pyface/tags","blobs_url":"https://api.github.com/repos/enthought/pyface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enthought/pyface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enthought/pyface/git/refs{/sha}","trees_url":"https://api.github.com/repos/enthought/pyface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enthought/pyface/statuses/{sha}","languages_url":"https://api.github.com/repos/enthought/pyface/languages","stargazers_url":"https://api.github.com/repos/enthought/pyface/stargazers","contributors_url":"https://api.github.com/repos/enthought/pyface/contributors","subscribers_url":"https://api.github.com/repos/enthought/pyface/subscribers","subscription_url":"https://api.github.com/repos/enthought/pyface/subscription","commits_url":"https://api.github.com/repos/enthought/pyface/commits{/sha}","git_commits_url":"https://api.github.com/repos/enthought/pyface/git/commits{/sha}","comments_url":"https://api.github.com/repos/enthought/pyface/comments{/number}","issue_comment_url":"https://api.github.com/repos/enthought/pyface/issues/comments{/number}","contents_url":"https://api.github.com/repos/enthought/pyface/contents/{+path}","compare_url":"https://api.github.com/repos/enthought/pyface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enthought/pyface/merges","archive_url":"https://api.github.com/repos/enthought/pyface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enthought/pyface/downloads","issues_url":"https://api.github.com/repos/enthought/pyface/issues{/number}","pulls_url":"https://api.github.com/repos/enthought/pyface/pulls{/number}","milestones_url":"https://api.github.com/repos/enthought/pyface/milestones{/number}","notifications_url":"https://api.github.com/repos/enthought/pyface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enthought/pyface/labels{/name}","releases_url":"https://api.github.com/repos/enthought/pyface/releases{/id}","deployments_url":"https://api.github.com/repos/enthought/pyface/deployments","created_at":"2011-04-18T22:32:06Z","updated_at":"2016-06-23T14:36:22Z","pushed_at":"2016-07-13T15:22:31Z","git_url":"git://github.com/enthought/pyface.git","ssh_url":"git@github.com:enthought/pyface.git","clone_url":"https://github.com/enthought/pyface.git","svn_url":"https://github.com/enthought/pyface","homepage":"","size":16101,"stargazers_count":33,"watchers_count":33,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"open_issues_count":39,"forks":24,"open_issues":39,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enthought/pyface/pulls/225"},"html":{"href":"https://github.com/enthought/pyface/pull/225"},"issue":{"href":"https://api.github.com/repos/enthought/pyface/issues/225"},"comments":{"href":"https://api.github.com/repos/enthought/pyface/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/enthought/pyface/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/enthought/pyface/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/enthought/pyface/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/enthought/pyface/statuses/9c88f40885d8b2838a10ffc0ef10f8b7e04d718c"}}}}
{"actor":{"display_login":"jonathanrocher"}}