{"action":"created","comment":{"url":"https://api.github.com/repos/AbsInt/CompCert/pulls/comments/76940272","id":76940272,"diff_hunk":"@@ -1439,9 +1470,8 @@ let elab_expr vararg loc env a =\n       let ty = match b3.edesc with ESizeof ty -> ty | _ -> assert false in\n       let ty' = default_argument_conversion env ty in\n       if not (compatible_types AttrIgnoreTop env ty ty') then\n-        warning \"'%a' is promoted to '%a' when passed through '...'.@ You should pass '%a', not '%a', to 'va_arg'\"\n-                Cprint.typ ty Cprint.typ ty'\n-                Cprint.typ ty' Cprint.typ ty;\n+        warning Varargs \"second argument to 'va_arg' is of promotable type %a; this va_arg has undefined behavior because arguments will be promoted to %a\"\n+          (print_typ env) ty (print_typ env) ty';","path":"cparser/Elab.ml","position":514,"original_position":514,"commit_id":"4a27ac909430e949c4ee0c155fd90ecd5709fda7","original_commit_id":"4a27ac909430e949c4ee0c155fd90ecd5709fda7","user":{"login":"xavierleroy","id":3845810,"avatar_url":"https://avatars.githubusercontent.com/u/3845810?v=3","gravatar_id":"","url":"https://api.github.com/users/xavierleroy","html_url":"https://github.com/xavierleroy","followers_url":"https://api.github.com/users/xavierleroy/followers","following_url":"https://api.github.com/users/xavierleroy/following{/other_user}","gists_url":"https://api.github.com/users/xavierleroy/gists{/gist_id}","starred_url":"https://api.github.com/users/xavierleroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavierleroy/subscriptions","organizations_url":"https://api.github.com/users/xavierleroy/orgs","repos_url":"https://api.github.com/users/xavierleroy/repos","events_url":"https://api.github.com/users/xavierleroy/events{/privacy}","received_events_url":"https://api.github.com/users/xavierleroy/received_events","type":"User","site_admin":false},"body":"I prefer the original message here.  It is essentially GCC's:\r\n```\r\ngee.c:12:17: warning: ‘float’ is promoted to ‘double’ when passed through ‘...’\r\n   x = va_arg(v, float);\r\n                 ^\r\ngee.c:12:17: note: (so you should pass ‘double’ not ‘float’ to ‘va_arg’)\r\n```\r\n","created_at":"2016-08-31T07:55:36Z","updated_at":"2016-08-31T07:55:36Z","html_url":"https://github.com/AbsInt/CompCert/pull/139#discussion_r76940272","pull_request_url":"https://api.github.com/repos/AbsInt/CompCert/pulls/139","_links":{"self":{"href":"https://api.github.com/repos/AbsInt/CompCert/pulls/comments/76940272"},"html":{"href":"https://github.com/AbsInt/CompCert/pull/139#discussion_r76940272"},"pull_request":{"href":"https://api.github.com/repos/AbsInt/CompCert/pulls/139"}}},"pull_request":{"url":"https://api.github.com/repos/AbsInt/CompCert/pulls/139","id":83247864,"html_url":"https://github.com/AbsInt/CompCert/pull/139","diff_url":"https://github.com/AbsInt/CompCert/pull/139.diff","patch_url":"https://github.com/AbsInt/CompCert/pull/139.patch","issue_url":"https://api.github.com/repos/AbsInt/CompCert/issues/139","number":139,"state":"open","locked":false,"title":"Advanced diagnostics","user":{"login":"bschommer","id":6874733,"avatar_url":"https://avatars.githubusercontent.com/u/6874733?v=3","gravatar_id":"","url":"https://api.github.com/users/bschommer","html_url":"https://github.com/bschommer","followers_url":"https://api.github.com/users/bschommer/followers","following_url":"https://api.github.com/users/bschommer/following{/other_user}","gists_url":"https://api.github.com/users/bschommer/gists{/gist_id}","starred_url":"https://api.github.com/users/bschommer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bschommer/subscriptions","organizations_url":"https://api.github.com/users/bschommer/orgs","repos_url":"https://api.github.com/users/bschommer/repos","events_url":"https://api.github.com/users/bschommer/events{/privacy}","received_events_url":"https://api.github.com/users/bschommer/received_events","type":"User","site_admin":false},"body":"This PR implements a consistent naming scheme for all warnings that can be enabled/disabled as well as colored diagnostics message. Furthermore the error messages are now all one-line and the wording has been adjusted to the one of gcc/clang.","created_at":"2016-08-30T10:43:11Z","updated_at":"2016-08-31T07:55:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a2ee4afdbfb9e5f8d234dc02b7573f5611603b2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AbsInt/CompCert/pulls/139/commits","review_comments_url":"https://api.github.com/repos/AbsInt/CompCert/pulls/139/comments","review_comment_url":"https://api.github.com/repos/AbsInt/CompCert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AbsInt/CompCert/issues/139/comments","statuses_url":"https://api.github.com/repos/AbsInt/CompCert/statuses/4a27ac909430e949c4ee0c155fd90ecd5709fda7","head":{"label":"AbsInt:advanced-diagnostics","ref":"advanced-diagnostics","sha":"4a27ac909430e949c4ee0c155fd90ecd5709fda7","user":{"login":"AbsInt","id":8820208,"avatar_url":"https://avatars.githubusercontent.com/u/8820208?v=3","gravatar_id":"","url":"https://api.github.com/users/AbsInt","html_url":"https://github.com/AbsInt","followers_url":"https://api.github.com/users/AbsInt/followers","following_url":"https://api.github.com/users/AbsInt/following{/other_user}","gists_url":"https://api.github.com/users/AbsInt/gists{/gist_id}","starred_url":"https://api.github.com/users/AbsInt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbsInt/subscriptions","organizations_url":"https://api.github.com/users/AbsInt/orgs","repos_url":"https://api.github.com/users/AbsInt/repos","events_url":"https://api.github.com/users/AbsInt/events{/privacy}","received_events_url":"https://api.github.com/users/AbsInt/received_events","type":"Organization","site_admin":false},"repo":{"id":24187206,"name":"CompCert","full_name":"AbsInt/CompCert","owner":{"login":"AbsInt","id":8820208,"avatar_url":"https://avatars.githubusercontent.com/u/8820208?v=3","gravatar_id":"","url":"https://api.github.com/users/AbsInt","html_url":"https://github.com/AbsInt","followers_url":"https://api.github.com/users/AbsInt/followers","following_url":"https://api.github.com/users/AbsInt/following{/other_user}","gists_url":"https://api.github.com/users/AbsInt/gists{/gist_id}","starred_url":"https://api.github.com/users/AbsInt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbsInt/subscriptions","organizations_url":"https://api.github.com/users/AbsInt/orgs","repos_url":"https://api.github.com/users/AbsInt/repos","events_url":"https://api.github.com/users/AbsInt/events{/privacy}","received_events_url":"https://api.github.com/users/AbsInt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AbsInt/CompCert","description":"The CompCert C verified compiler","fork":false,"url":"https://api.github.com/repos/AbsInt/CompCert","forks_url":"https://api.github.com/repos/AbsInt/CompCert/forks","keys_url":"https://api.github.com/repos/AbsInt/CompCert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AbsInt/CompCert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AbsInt/CompCert/teams","hooks_url":"https://api.github.com/repos/AbsInt/CompCert/hooks","issue_events_url":"https://api.github.com/repos/AbsInt/CompCert/issues/events{/number}","events_url":"https://api.github.com/repos/AbsInt/CompCert/events","assignees_url":"https://api.github.com/repos/AbsInt/CompCert/assignees{/user}","branches_url":"https://api.github.com/repos/AbsInt/CompCert/branches{/branch}","tags_url":"https://api.github.com/repos/AbsInt/CompCert/tags","blobs_url":"https://api.github.com/repos/AbsInt/CompCert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AbsInt/CompCert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AbsInt/CompCert/git/refs{/sha}","trees_url":"https://api.github.com/repos/AbsInt/CompCert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AbsInt/CompCert/statuses/{sha}","languages_url":"https://api.github.com/repos/AbsInt/CompCert/languages","stargazers_url":"https://api.github.com/repos/AbsInt/CompCert/stargazers","contributors_url":"https://api.github.com/repos/AbsInt/CompCert/contributors","subscribers_url":"https://api.github.com/repos/AbsInt/CompCert/subscribers","subscription_url":"https://api.github.com/repos/AbsInt/CompCert/subscription","commits_url":"https://api.github.com/repos/AbsInt/CompCert/commits{/sha}","git_commits_url":"https://api.github.com/repos/AbsInt/CompCert/git/commits{/sha}","comments_url":"https://api.github.com/repos/AbsInt/CompCert/comments{/number}","issue_comment_url":"https://api.github.com/repos/AbsInt/CompCert/issues/comments{/number}","contents_url":"https://api.github.com/repos/AbsInt/CompCert/contents/{+path}","compare_url":"https://api.github.com/repos/AbsInt/CompCert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AbsInt/CompCert/merges","archive_url":"https://api.github.com/repos/AbsInt/CompCert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AbsInt/CompCert/downloads","issues_url":"https://api.github.com/repos/AbsInt/CompCert/issues{/number}","pulls_url":"https://api.github.com/repos/AbsInt/CompCert/pulls{/number}","milestones_url":"https://api.github.com/repos/AbsInt/CompCert/milestones{/number}","notifications_url":"https://api.github.com/repos/AbsInt/CompCert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AbsInt/CompCert/labels{/name}","releases_url":"https://api.github.com/repos/AbsInt/CompCert/releases{/id}","deployments_url":"https://api.github.com/repos/AbsInt/CompCert/deployments","created_at":"2014-09-18T12:27:33Z","updated_at":"2016-08-31T03:15:06Z","pushed_at":"2016-08-30T10:43:11Z","git_url":"git://github.com/AbsInt/CompCert.git","ssh_url":"git@github.com:AbsInt/CompCert.git","clone_url":"https://github.com/AbsInt/CompCert.git","svn_url":"https://github.com/AbsInt/CompCert","homepage":"http://compcert.inria.fr/","size":14682,"stargazers_count":222,"watchers_count":222,"language":"Coq","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":7,"forks":33,"open_issues":7,"watchers":222,"default_branch":"master"}},"base":{"label":"AbsInt:master","ref":"master","sha":"64a1e734dfe24194bafd33cff1fbe4d9e1cfdf14","user":{"login":"AbsInt","id":8820208,"avatar_url":"https://avatars.githubusercontent.com/u/8820208?v=3","gravatar_id":"","url":"https://api.github.com/users/AbsInt","html_url":"https://github.com/AbsInt","followers_url":"https://api.github.com/users/AbsInt/followers","following_url":"https://api.github.com/users/AbsInt/following{/other_user}","gists_url":"https://api.github.com/users/AbsInt/gists{/gist_id}","starred_url":"https://api.github.com/users/AbsInt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbsInt/subscriptions","organizations_url":"https://api.github.com/users/AbsInt/orgs","repos_url":"https://api.github.com/users/AbsInt/repos","events_url":"https://api.github.com/users/AbsInt/events{/privacy}","received_events_url":"https://api.github.com/users/AbsInt/received_events","type":"Organization","site_admin":false},"repo":{"id":24187206,"name":"CompCert","full_name":"AbsInt/CompCert","owner":{"login":"AbsInt","id":8820208,"avatar_url":"https://avatars.githubusercontent.com/u/8820208?v=3","gravatar_id":"","url":"https://api.github.com/users/AbsInt","html_url":"https://github.com/AbsInt","followers_url":"https://api.github.com/users/AbsInt/followers","following_url":"https://api.github.com/users/AbsInt/following{/other_user}","gists_url":"https://api.github.com/users/AbsInt/gists{/gist_id}","starred_url":"https://api.github.com/users/AbsInt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AbsInt/subscriptions","organizations_url":"https://api.github.com/users/AbsInt/orgs","repos_url":"https://api.github.com/users/AbsInt/repos","events_url":"https://api.github.com/users/AbsInt/events{/privacy}","received_events_url":"https://api.github.com/users/AbsInt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AbsInt/CompCert","description":"The CompCert C verified compiler","fork":false,"url":"https://api.github.com/repos/AbsInt/CompCert","forks_url":"https://api.github.com/repos/AbsInt/CompCert/forks","keys_url":"https://api.github.com/repos/AbsInt/CompCert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AbsInt/CompCert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AbsInt/CompCert/teams","hooks_url":"https://api.github.com/repos/AbsInt/CompCert/hooks","issue_events_url":"https://api.github.com/repos/AbsInt/CompCert/issues/events{/number}","events_url":"https://api.github.com/repos/AbsInt/CompCert/events","assignees_url":"https://api.github.com/repos/AbsInt/CompCert/assignees{/user}","branches_url":"https://api.github.com/repos/AbsInt/CompCert/branches{/branch}","tags_url":"https://api.github.com/repos/AbsInt/CompCert/tags","blobs_url":"https://api.github.com/repos/AbsInt/CompCert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AbsInt/CompCert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AbsInt/CompCert/git/refs{/sha}","trees_url":"https://api.github.com/repos/AbsInt/CompCert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AbsInt/CompCert/statuses/{sha}","languages_url":"https://api.github.com/repos/AbsInt/CompCert/languages","stargazers_url":"https://api.github.com/repos/AbsInt/CompCert/stargazers","contributors_url":"https://api.github.com/repos/AbsInt/CompCert/contributors","subscribers_url":"https://api.github.com/repos/AbsInt/CompCert/subscribers","subscription_url":"https://api.github.com/repos/AbsInt/CompCert/subscription","commits_url":"https://api.github.com/repos/AbsInt/CompCert/commits{/sha}","git_commits_url":"https://api.github.com/repos/AbsInt/CompCert/git/commits{/sha}","comments_url":"https://api.github.com/repos/AbsInt/CompCert/comments{/number}","issue_comment_url":"https://api.github.com/repos/AbsInt/CompCert/issues/comments{/number}","contents_url":"https://api.github.com/repos/AbsInt/CompCert/contents/{+path}","compare_url":"https://api.github.com/repos/AbsInt/CompCert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AbsInt/CompCert/merges","archive_url":"https://api.github.com/repos/AbsInt/CompCert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AbsInt/CompCert/downloads","issues_url":"https://api.github.com/repos/AbsInt/CompCert/issues{/number}","pulls_url":"https://api.github.com/repos/AbsInt/CompCert/pulls{/number}","milestones_url":"https://api.github.com/repos/AbsInt/CompCert/milestones{/number}","notifications_url":"https://api.github.com/repos/AbsInt/CompCert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AbsInt/CompCert/labels{/name}","releases_url":"https://api.github.com/repos/AbsInt/CompCert/releases{/id}","deployments_url":"https://api.github.com/repos/AbsInt/CompCert/deployments","created_at":"2014-09-18T12:27:33Z","updated_at":"2016-08-31T03:15:06Z","pushed_at":"2016-08-30T10:43:11Z","git_url":"git://github.com/AbsInt/CompCert.git","ssh_url":"git@github.com:AbsInt/CompCert.git","clone_url":"https://github.com/AbsInt/CompCert.git","svn_url":"https://github.com/AbsInt/CompCert","homepage":"http://compcert.inria.fr/","size":14682,"stargazers_count":222,"watchers_count":222,"language":"Coq","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":7,"forks":33,"open_issues":7,"watchers":222,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AbsInt/CompCert/pulls/139"},"html":{"href":"https://github.com/AbsInt/CompCert/pull/139"},"issue":{"href":"https://api.github.com/repos/AbsInt/CompCert/issues/139"},"comments":{"href":"https://api.github.com/repos/AbsInt/CompCert/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/AbsInt/CompCert/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/AbsInt/CompCert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AbsInt/CompCert/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/AbsInt/CompCert/statuses/4a27ac909430e949c4ee0c155fd90ecd5709fda7"}}}}
{"actor":{"display_login":"xavierleroy"}}