{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/75942533","id":75942533,"diff_hunk":"@@ -151,27 +141,22 @@ void HcalDeterministicFit::apply(const CaloSamples & cs, const std::vector<int>\n         double invG = invGpar[0]+invGpar[1]*std::sqrt(2*std::log(invGpar[2]/ratio));\n         float iG=0;\n         getLandauFrac(-invG,-invG+tsWidth,iG);\n-        ch4=(corrCharge[4]-ch3*n3)/(iG);\n-        ch5=negThresh[0];\n-        tsShift4=invG;\n+        if (iG != 0 ) {\n+\t  ch4=(corrCharge[4]-ch3*n3)/(iG);\n+\t  ch5=negThresh[0];","path":"RecoLocalCalo/HcalRecAlgos/interface/HcalDeterministicFit.h","position":94,"original_position":94,"commit_id":"d9753fe9773664ca960cbb405419f342e77e4471","original_commit_id":"d9753fe9773664ca960cbb405419f342e77e4471","user":{"login":"cvuosalo","id":5736159,"avatar_url":"https://avatars.githubusercontent.com/u/5736159?v=3","gravatar_id":"","url":"https://api.github.com/users/cvuosalo","html_url":"https://github.com/cvuosalo","followers_url":"https://api.github.com/users/cvuosalo/followers","following_url":"https://api.github.com/users/cvuosalo/following{/other_user}","gists_url":"https://api.github.com/users/cvuosalo/gists{/gist_id}","starred_url":"https://api.github.com/users/cvuosalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvuosalo/subscriptions","organizations_url":"https://api.github.com/users/cvuosalo/orgs","repos_url":"https://api.github.com/users/cvuosalo/repos","events_url":"https://api.github.com/users/cvuosalo/events{/privacy}","received_events_url":"https://api.github.com/users/cvuosalo/received_events","type":"User","site_admin":false},"body":"ch5 is not referenced again, so this assignment is dead. Please delete it.","created_at":"2016-08-23T20:18:14Z","updated_at":"2016-08-23T20:18:14Z","html_url":"https://github.com/cms-sw/cmssw/pull/15499#discussion_r75942533","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15499","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/75942533"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/15499#discussion_r75942533"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15499"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15499","id":81655561,"html_url":"https://github.com/cms-sw/cmssw/pull/15499","diff_url":"https://github.com/cms-sw/cmssw/pull/15499.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/15499.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15499","number":15499,"state":"open","locked":false,"title":"HE- energy reconstruction - phase1","user":{"login":"mariadalfonso","id":5656714,"avatar_url":"https://avatars.githubusercontent.com/u/5656714?v=3","gravatar_id":"","url":"https://api.github.com/users/mariadalfonso","html_url":"https://github.com/mariadalfonso","followers_url":"https://api.github.com/users/mariadalfonso/followers","following_url":"https://api.github.com/users/mariadalfonso/following{/other_user}","gists_url":"https://api.github.com/users/mariadalfonso/gists{/gist_id}","starred_url":"https://api.github.com/users/mariadalfonso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariadalfonso/subscriptions","organizations_url":"https://api.github.com/users/mariadalfonso/orgs","repos_url":"https://api.github.com/users/mariadalfonso/repos","events_url":"https://api.github.com/users/mariadalfonso/events{/privacy}","received_events_url":"https://api.github.com/users/mariadalfonso/received_events","type":"User","site_admin":false},"body":"This PR implement the phase1 M2/M0 method and add some general cleanup in some code common to the run2 version.\r\n\r\nThings to note:\r\n1) removed unused inputTags/enum\r\n2) re-arranged Pset to handle the M2 paramters for the siPM             \r\n3) from Salvat's fixed M0 energy ( see commit d67ef34 )\r\n4) memory heap std::vector<double> & Output --> float*, (see commit 3551190) Slava/Igor's request\r\n5) from Slava's various double -> float to speed time ( see commit a3fb0c6)\r\n\r\nSlides w/ descriptions/tests include up to commit 6bc3caa https://indico.cern.ch/event/563410/contributions/2277004/attachments/1324249/1988640/PR15499.pdf\r\n\r\nTo be considered for the 80X backport (pure sw changes):\r\na3fb0c6: from Slava this improve the CPU timing of 20% on ttbar events\r\n4359dac: from Carl this protect for potential division by zero\r\n3551190: from Slava/Igor this improve the memory","created_at":"2016-08-17T14:42:44Z","updated_at":"2016-08-23T20:18:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"366183a144bcba072d4f05d27f94760b0d74b748","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":66,"closed_issues":1251,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-08-23T19:14:13Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15499/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15499/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15499/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/d9753fe9773664ca960cbb405419f342e77e4471","head":{"label":"mariadalfonso:M2","ref":"M2","sha":"d9753fe9773664ca960cbb405419f342e77e4471","user":{"login":"mariadalfonso","id":5656714,"avatar_url":"https://avatars.githubusercontent.com/u/5656714?v=3","gravatar_id":"","url":"https://api.github.com/users/mariadalfonso","html_url":"https://github.com/mariadalfonso","followers_url":"https://api.github.com/users/mariadalfonso/followers","following_url":"https://api.github.com/users/mariadalfonso/following{/other_user}","gists_url":"https://api.github.com/users/mariadalfonso/gists{/gist_id}","starred_url":"https://api.github.com/users/mariadalfonso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariadalfonso/subscriptions","organizations_url":"https://api.github.com/users/mariadalfonso/orgs","repos_url":"https://api.github.com/users/mariadalfonso/repos","events_url":"https://api.github.com/users/mariadalfonso/events{/privacy}","received_events_url":"https://api.github.com/users/mariadalfonso/received_events","type":"User","site_admin":false},"repo":{"id":18758083,"name":"cmssw","full_name":"mariadalfonso/cmssw","owner":{"login":"mariadalfonso","id":5656714,"avatar_url":"https://avatars.githubusercontent.com/u/5656714?v=3","gravatar_id":"","url":"https://api.github.com/users/mariadalfonso","html_url":"https://github.com/mariadalfonso","followers_url":"https://api.github.com/users/mariadalfonso/followers","following_url":"https://api.github.com/users/mariadalfonso/following{/other_user}","gists_url":"https://api.github.com/users/mariadalfonso/gists{/gist_id}","starred_url":"https://api.github.com/users/mariadalfonso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariadalfonso/subscriptions","organizations_url":"https://api.github.com/users/mariadalfonso/orgs","repos_url":"https://api.github.com/users/mariadalfonso/repos","events_url":"https://api.github.com/users/mariadalfonso/events{/privacy}","received_events_url":"https://api.github.com/users/mariadalfonso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mariadalfonso/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/mariadalfonso/cmssw","forks_url":"https://api.github.com/repos/mariadalfonso/cmssw/forks","keys_url":"https://api.github.com/repos/mariadalfonso/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mariadalfonso/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mariadalfonso/cmssw/teams","hooks_url":"https://api.github.com/repos/mariadalfonso/cmssw/hooks","issue_events_url":"https://api.github.com/repos/mariadalfonso/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/mariadalfonso/cmssw/events","assignees_url":"https://api.github.com/repos/mariadalfonso/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/mariadalfonso/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/mariadalfonso/cmssw/tags","blobs_url":"https://api.github.com/repos/mariadalfonso/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mariadalfonso/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mariadalfonso/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/mariadalfonso/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mariadalfonso/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/mariadalfonso/cmssw/languages","stargazers_url":"https://api.github.com/repos/mariadalfonso/cmssw/stargazers","contributors_url":"https://api.github.com/repos/mariadalfonso/cmssw/contributors","subscribers_url":"https://api.github.com/repos/mariadalfonso/cmssw/subscribers","subscription_url":"https://api.github.com/repos/mariadalfonso/cmssw/subscription","commits_url":"https://api.github.com/repos/mariadalfonso/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/mariadalfonso/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/mariadalfonso/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/mariadalfonso/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/mariadalfonso/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/mariadalfonso/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mariadalfonso/cmssw/merges","archive_url":"https://api.github.com/repos/mariadalfonso/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mariadalfonso/cmssw/downloads","issues_url":"https://api.github.com/repos/mariadalfonso/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/mariadalfonso/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/mariadalfonso/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/mariadalfonso/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mariadalfonso/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/mariadalfonso/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/mariadalfonso/cmssw/deployments","created_at":"2014-04-14T11:20:12Z","updated_at":"2014-04-14T11:22:34Z","pushed_at":"2016-08-23T18:02:25Z","git_url":"git://github.com/mariadalfonso/cmssw.git","ssh_url":"git@github.com:mariadalfonso/cmssw.git","clone_url":"https://github.com/mariadalfonso/cmssw.git","svn_url":"https://github.com/mariadalfonso/cmssw","homepage":"cms-sw.github.io/cmssw","size":864233,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_1_X"}},"base":{"label":"cms-sw:CMSSW_8_1_X","ref":"CMSSW_8_1_X","sha":"d7dbf49aff4eb0ad598becf9fb60d7a35ca514b7","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2016-08-23T15:56:06Z","pushed_at":"2016-08-23T19:32:53Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1101328,"stargazers_count":335,"watchers_count":335,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1959,"mirror_url":null,"open_issues_count":368,"forks":1959,"open_issues":368,"watchers":335,"default_branch":"CMSSW_8_1_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15499"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/15499"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/15499"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/15499/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15499/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15499/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/d9753fe9773664ca960cbb405419f342e77e4471"}}}}
{"actor":{"display_login":"cvuosalo"}}