{"action":"opened","issue":{"url":"https://api.github.com/repos/christopho/solarus/issues/926","repository_url":"https://api.github.com/repos/christopho/solarus","labels_url":"https://api.github.com/repos/christopho/solarus/issues/926/labels{/name}","comments_url":"https://api.github.com/repos/christopho/solarus/issues/926/comments","events_url":"https://api.github.com/repos/christopho/solarus/issues/926/events","html_url":"https://github.com/christopho/solarus/issues/926","id":163435792,"number":926,"title":"Make swim speed configurable from the Lua API","user":{"login":"alexander-b","id":1010385,"avatar_url":"https://avatars.githubusercontent.com/u/1010385?v=3","gravatar_id":"","url":"https://api.github.com/users/alexander-b","html_url":"https://github.com/alexander-b","followers_url":"https://api.github.com/users/alexander-b/followers","following_url":"https://api.github.com/users/alexander-b/following{/other_user}","gists_url":"https://api.github.com/users/alexander-b/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-b/subscriptions","organizations_url":"https://api.github.com/users/alexander-b/orgs","repos_url":"https://api.github.com/users/alexander-b/repos","events_url":"https://api.github.com/users/alexander-b/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-b/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-07-01T16:59:08Z","updated_at":"2016-07-01T16:59:08Z","closed_at":null,"body":"Filing a bug report since I'm not entirely sure how to handle this.\r\n\r\nThere's a fast and a slow swimming speed. The latter is merely ½ the former. Ideally I'd like to be able to manipulate both. Which would, near as I can tell, mean adding set_slow/fast_swimming_speed() to the Lua context, and rewriting the SwimmingState stuff to behave appropriately. This would also mean adding the corresponding C++ code to Hero.\r\n\r\nThere should probably be a get_swimming_speed() similar to get_walking_speed(), which is quite trivial (just query the SwimmingState and return the appropriate of fast/slow_swimming_speed).\r\n\r\nBut for consistency, shouldn't there then also be a get_slow/fast_swimming_speed(), corresponding to get_normal_walking_speed()? I don't particularly need or want this myself, but then again I don't need or want get_normal_walking_speed() either.\r\n\r\nSo I'm just looking for some input on the design decisions, before I hack away. It seems reasonably simple to implement this stuff either way."}}
{"actor":{"display_login":"alexander-b"}}