{"action":"created","issue":{"url":"https://api.github.com/repos/php-http/react-adapter/issues/18","repository_url":"https://api.github.com/repos/php-http/react-adapter","labels_url":"https://api.github.com/repos/php-http/react-adapter/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/php-http/react-adapter/issues/18/comments","events_url":"https://api.github.com/repos/php-http/react-adapter/issues/18/events","html_url":"https://github.com/php-http/react-adapter/pull/18","id":184850490,"number":18,"title":"Fix react/http-client 0.4.13 response body issue","user":{"login":"shulard","id":482993,"avatar_url":"https://avatars.githubusercontent.com/u/482993?v=3","gravatar_id":"","url":"https://api.github.com/users/shulard","html_url":"https://github.com/shulard","followers_url":"https://api.github.com/users/shulard/followers","following_url":"https://api.github.com/users/shulard/following{/other_user}","gists_url":"https://api.github.com/users/shulard/gists{/gist_id}","starred_url":"https://api.github.com/users/shulard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shulard/subscriptions","organizations_url":"https://api.github.com/users/shulard/orgs","repos_url":"https://api.github.com/users/shulard/repos","events_url":"https://api.github.com/users/shulard/events{/privacy}","received_events_url":"https://api.github.com/users/shulard/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-24T14:06:10Z","updated_at":"2016-10-25T09:05:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/php-http/react-adapter/pulls/18","html_url":"https://github.com/php-http/react-adapter/pull/18","diff_url":"https://github.com/php-http/react-adapter/pull/18.diff","patch_url":"https://github.com/php-http/react-adapter/pull/18.patch"},"body":"| Q               | A\r\n| --------------- | ---\r\n| Bug fix?        | yes\r\n| New feature?    | no\r\n| BC breaks?      | yes\r\n| Deprecations?   | no\r\n| Related tickets | fixes #17\r\n| Documentation   | \r\n| License         | MIT\r\n\r\n\r\n#### What's in this PR?\r\n\r\nThis PR has been pushed to fixed the compatibility error with `react/http-client` v0.4.13.\r\n\r\n#### Why?\r\n\r\nThere was a break change published in v0.4.13 around response body type. Before the first response body was sent as a `StreamInterface` instance, now it's \"just\" string.\r\n\r\nBefore we are using that `StreamInterface` instance as `$bodyStream`... Now it has been updated to use the `Http\\Message\\StreamFactory` to build a valid StreamInterface instance.\r\n\r\nIf a BC Break because I've introduced a new constructor parameter to be able to inject `StreamFactory` instance...\r\n\r\nOf course the `Http\\Discovery\\StreamFactoryDiscovery` object is used when parameter is empty.\r\n\r\nWith this change, I've tested on lowest dependencies and it works too.\r\n\r\n#### Checklist\r\n\r\n- [ ] Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix\r\n\r\n\r\n#### To Do\r\n\r\n- [ ] Validate PR approach...\r\n- [ ] Create a release with a composer update to disallow react/http-client > 0.4.12 ?"},"comment":{"url":"https://api.github.com/repos/php-http/react-adapter/issues/comments/255979405","html_url":"https://github.com/php-http/react-adapter/pull/18#issuecomment-255979405","issue_url":"https://api.github.com/repos/php-http/react-adapter/issues/18","id":255979405,"user":{"login":"shulard","id":482993,"avatar_url":"https://avatars.githubusercontent.com/u/482993?v=3","gravatar_id":"","url":"https://api.github.com/users/shulard","html_url":"https://github.com/shulard","followers_url":"https://api.github.com/users/shulard/followers","following_url":"https://api.github.com/users/shulard/following{/other_user}","gists_url":"https://api.github.com/users/shulard/gists{/gist_id}","starred_url":"https://api.github.com/users/shulard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shulard/subscriptions","organizations_url":"https://api.github.com/users/shulard/orgs","repos_url":"https://api.github.com/users/shulard/repos","events_url":"https://api.github.com/users/shulard/events{/privacy}","received_events_url":"https://api.github.com/users/shulard/received_events","type":"User","site_admin":false},"created_at":"2016-10-25T09:05:48Z","updated_at":"2016-10-25T09:05:48Z","body":"I've updated the code with string cast, much simpler 😄."}}
{"actor":{"display_login":"shulard"}}