{"action":"created","issue":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst/issues/399","labels_url":"https://api.github.com/repos/os-autoinst/os-autoinst/issues/399/labels{/name}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst/issues/399/comments","events_url":"https://api.github.com/repos/os-autoinst/os-autoinst/issues/399/events","html_url":"https://github.com/os-autoinst/os-autoinst/issues/399","id":127980197,"number":399,"title":"HDDMODEL is insufficiently flexible, cannot add buses","user":{"login":"AdamWill","id":916551,"avatar_url":"https://avatars.githubusercontent.com/u/916551?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamWill","html_url":"https://github.com/AdamWill","followers_url":"https://api.github.com/users/AdamWill/followers","following_url":"https://api.github.com/users/AdamWill/following{/other_user}","gists_url":"https://api.github.com/users/AdamWill/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamWill/subscriptions","organizations_url":"https://api.github.com/users/AdamWill/orgs","repos_url":"https://api.github.com/users/AdamWill/repos","events_url":"https://api.github.com/users/AdamWill/events{/privacy}","received_events_url":"https://api.github.com/users/AdamWill/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-21T17:42:49Z","updated_at":"2016-01-25T18:09:51Z","closed_at":null,"body":"In Fedora, we were trying to use the `HDDMODEL` variable for a SATA test. Long story short, it turns out that doesn't work. In os-autoinst 4.2, there was a bit of code that sneakily turned the SATA disk we were trying to add into a PATA disk. In os-autoinst 4.3, that's gone, but there's simply no way you can cause os-autoinst to construct a qemu invocation which will successfully include a SATA disk, because you can't add a SATA bus. The way HDDMODEL is set up, it's only capable of attaching a disk to a bus that the VM would have otherwise; you can't use HDDMODEL or any other variable I can find to *add* a bus to the VM, and nothing else causes os-autoinst VMs to have a SATA bus, so this just doesn't seem possible at present.\r\n\r\nThere's more details on this at https://phab.qadevel.cloud.fedoraproject.org/T691 . It would be good if we could fix this somehow, I don't know how much abstraction we want to put in; the low-abstraction way would just be to have numbered variables (DEVICE1, DEVICE2...) for constructing `-device` arguments, a high level way might be to have variables like `SATA` or `SCSI` which cause os-autoinst to add an appropriate `-device` argument to add the specified bus."},"comment":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst/issues/comments/174606642","html_url":"https://github.com/os-autoinst/os-autoinst/issues/399#issuecomment-174606642","issue_url":"https://api.github.com/repos/os-autoinst/os-autoinst/issues/399","id":174606642,"user":{"login":"sysrich","id":1197728,"avatar_url":"https://avatars.githubusercontent.com/u/1197728?v=3","gravatar_id":"","url":"https://api.github.com/users/sysrich","html_url":"https://github.com/sysrich","followers_url":"https://api.github.com/users/sysrich/followers","following_url":"https://api.github.com/users/sysrich/following{/other_user}","gists_url":"https://api.github.com/users/sysrich/gists{/gist_id}","starred_url":"https://api.github.com/users/sysrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sysrich/subscriptions","organizations_url":"https://api.github.com/users/sysrich/orgs","repos_url":"https://api.github.com/users/sysrich/repos","events_url":"https://api.github.com/users/sysrich/events{/privacy}","received_events_url":"https://api.github.com/users/sysrich/received_events","type":"User","site_admin":false},"created_at":"2016-01-25T18:09:51Z","updated_at":"2016-01-25T18:09:51Z","body":"typing off the top of my head (ie. I consider the opinion I am about to share as open to persuasion)\r\n\r\nI am nervous about an \"add any qemu parameter you like\" variable as it would be too easy to create very easily broken combinations\r\n\r\nI like the idea of adding specific `-device` arguments, and I think @AdamWill is right, we need to add a bus, and there is nothing 'HDD' about it - Maybe we need to rename/replace the HDDMODEL variable\r\n\r\nA very abstracted 'add a specific bus' variable might be nice, but I dont think it'll be flexible enough"}}