{"action":"created","comment":{"url":"https://api.github.com/repos/fsnotify/fsnotify/pulls/comments/81890952","pull_request_review_id":2837564,"id":81890952,"diff_hunk":"@@ -157,92 +156,105 @@ func TestInotifyCloseCreate(t *testing.T) {\n func TestInotifyStress(t *testing.T) {\n \ttestDir := tempMkdir(t)\n \tdefer os.RemoveAll(testDir)\n-\ttestFile := filepath.Join(testDir, \"testfile\")\n+\ttestFilePrefix := filepath.Join(testDir, \"testfile\")\n \n \tw, err := NewWatcher()\n \tif err != nil {\n \t\tt.Fatalf(\"Failed to create watcher: %v\", err)\n \t}\n \tdefer w.Close()\n \n-\tkillchan := make(chan struct{})\n-\tdefer close(killchan)\n-\n \terr = w.Add(testDir)\n \tif err != nil {\n \t\tt.Fatalf(\"Failed to add testDir: %v\", err)\n \t}\n \n-\tproc, err := os.FindProcess(os.Getpid())\n-\tif err != nil {\n-\t\tt.Fatalf(\"Error finding process: %v\", err)\n-\t}\n+\tkillChan := make(chan struct{})\n+\tdefer close(killChan)\n \n-\tgo func() {\n-\t\tfor {\n-\t\t\tselect {\n-\t\t\tcase <-time.After(5 * time.Millisecond):\n-\t\t\t\terr := proc.Signal(unix.SIGUSR1)\n-\t\t\t\tif err != nil {\n-\t\t\t\t\tt.Fatalf(\"Signal failed: %v\", err)\n-\t\t\t\t}\n-\t\t\tcase <-killchan:\n-\t\t\t\treturn\n-\t\t\t}\n-\t\t}\n-\t}()\n+\tdoneChan := make(chan struct{})\n+\terrChan := make(chan error, 1000)","path":"inotify_test.go","position":54,"original_position":54,"commit_id":"3e9e138b2ebaf7480698fd6f14011d28d6250f38","original_commit_id":"3e9e138b2ebaf7480698fd6f14011d28d6250f38","user":{"login":"nathany","id":4566,"avatar_url":"https://avatars.githubusercontent.com/u/4566?v=3","gravatar_id":"","url":"https://api.github.com/users/nathany","html_url":"https://github.com/nathany","followers_url":"https://api.github.com/users/nathany/followers","following_url":"https://api.github.com/users/nathany/following{/other_user}","gists_url":"https://api.github.com/users/nathany/gists{/gist_id}","starred_url":"https://api.github.com/users/nathany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathany/subscriptions","organizations_url":"https://api.github.com/users/nathany/orgs","repos_url":"https://api.github.com/users/nathany/repos","events_url":"https://api.github.com/users/nathany/events{/privacy}","received_events_url":"https://api.github.com/users/nathany/received_events","type":"User","site_admin":false},"body":"does this channel need to be buffered?","created_at":"2016-10-05T02:18:01Z","updated_at":"2016-10-05T02:27:08Z","html_url":"https://github.com/fsnotify/fsnotify/pull/174#discussion_r81890952","pull_request_url":"https://api.github.com/repos/fsnotify/fsnotify/pulls/174","_links":{"self":{"href":"https://api.github.com/repos/fsnotify/fsnotify/pulls/comments/81890952"},"html":{"href":"https://github.com/fsnotify/fsnotify/pull/174#discussion_r81890952"},"pull_request":{"href":"https://api.github.com/repos/fsnotify/fsnotify/pulls/174"}}},"pull_request":{"url":"https://api.github.com/repos/fsnotify/fsnotify/pulls/174","id":87997549,"html_url":"https://github.com/fsnotify/fsnotify/pull/174","diff_url":"https://github.com/fsnotify/fsnotify/pull/174.diff","patch_url":"https://github.com/fsnotify/fsnotify/pull/174.patch","issue_url":"https://api.github.com/repos/fsnotify/fsnotify/issues/174","number":174,"state":"closed","locked":false,"title":"create inotify fd with close-on-exec + deflake inotify stress test","user":{"login":"pattyshack","id":6808940,"avatar_url":"https://avatars.githubusercontent.com/u/6808940?v=3","gravatar_id":"","url":"https://api.github.com/users/pattyshack","html_url":"https://github.com/pattyshack","followers_url":"https://api.github.com/users/pattyshack/followers","following_url":"https://api.github.com/users/pattyshack/following{/other_user}","gists_url":"https://api.github.com/users/pattyshack/gists{/gist_id}","starred_url":"https://api.github.com/users/pattyshack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pattyshack/subscriptions","organizations_url":"https://api.github.com/users/pattyshack/orgs","repos_url":"https://api.github.com/users/pattyshack/repos","events_url":"https://api.github.com/users/pattyshack/events{/privacy}","received_events_url":"https://api.github.com/users/pattyshack/received_events","type":"User","site_admin":false},"body":"(on behalf of @msolo) inotify fd should not leak to children processes (this matches the kqueue implementation behavior).","created_at":"2016-10-05T00:14:31Z","updated_at":"2016-10-05T02:27:08Z","closed_at":"2016-10-05T02:25:06Z","merged_at":null,"merge_commit_sha":"69b5dd9866f16432ba3ed3a676711cf97561af23","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fsnotify/fsnotify/pulls/174/commits","review_comments_url":"https://api.github.com/repos/fsnotify/fsnotify/pulls/174/comments","review_comment_url":"https://api.github.com/repos/fsnotify/fsnotify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fsnotify/fsnotify/issues/174/comments","statuses_url":"https://api.github.com/repos/fsnotify/fsnotify/statuses/3e9e138b2ebaf7480698fd6f14011d28d6250f38","head":{"label":"pattyshack:close-on-exec","ref":"close-on-exec","sha":"3e9e138b2ebaf7480698fd6f14011d28d6250f38","user":{"login":"pattyshack","id":6808940,"avatar_url":"https://avatars.githubusercontent.com/u/6808940?v=3","gravatar_id":"","url":"https://api.github.com/users/pattyshack","html_url":"https://github.com/pattyshack","followers_url":"https://api.github.com/users/pattyshack/followers","following_url":"https://api.github.com/users/pattyshack/following{/other_user}","gists_url":"https://api.github.com/users/pattyshack/gists{/gist_id}","starred_url":"https://api.github.com/users/pattyshack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pattyshack/subscriptions","organizations_url":"https://api.github.com/users/pattyshack/orgs","repos_url":"https://api.github.com/users/pattyshack/repos","events_url":"https://api.github.com/users/pattyshack/events{/privacy}","received_events_url":"https://api.github.com/users/pattyshack/received_events","type":"User","site_admin":false},"repo":{"id":70012539,"name":"fsnotify","full_name":"pattyshack/fsnotify","owner":{"login":"pattyshack","id":6808940,"avatar_url":"https://avatars.githubusercontent.com/u/6808940?v=3","gravatar_id":"","url":"https://api.github.com/users/pattyshack","html_url":"https://github.com/pattyshack","followers_url":"https://api.github.com/users/pattyshack/followers","following_url":"https://api.github.com/users/pattyshack/following{/other_user}","gists_url":"https://api.github.com/users/pattyshack/gists{/gist_id}","starred_url":"https://api.github.com/users/pattyshack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pattyshack/subscriptions","organizations_url":"https://api.github.com/users/pattyshack/orgs","repos_url":"https://api.github.com/users/pattyshack/repos","events_url":"https://api.github.com/users/pattyshack/events{/privacy}","received_events_url":"https://api.github.com/users/pattyshack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pattyshack/fsnotify","description":"File system notifications for Go.","fork":true,"url":"https://api.github.com/repos/pattyshack/fsnotify","forks_url":"https://api.github.com/repos/pattyshack/fsnotify/forks","keys_url":"https://api.github.com/repos/pattyshack/fsnotify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pattyshack/fsnotify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pattyshack/fsnotify/teams","hooks_url":"https://api.github.com/repos/pattyshack/fsnotify/hooks","issue_events_url":"https://api.github.com/repos/pattyshack/fsnotify/issues/events{/number}","events_url":"https://api.github.com/repos/pattyshack/fsnotify/events","assignees_url":"https://api.github.com/repos/pattyshack/fsnotify/assignees{/user}","branches_url":"https://api.github.com/repos/pattyshack/fsnotify/branches{/branch}","tags_url":"https://api.github.com/repos/pattyshack/fsnotify/tags","blobs_url":"https://api.github.com/repos/pattyshack/fsnotify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pattyshack/fsnotify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pattyshack/fsnotify/git/refs{/sha}","trees_url":"https://api.github.com/repos/pattyshack/fsnotify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pattyshack/fsnotify/statuses/{sha}","languages_url":"https://api.github.com/repos/pattyshack/fsnotify/languages","stargazers_url":"https://api.github.com/repos/pattyshack/fsnotify/stargazers","contributors_url":"https://api.github.com/repos/pattyshack/fsnotify/contributors","subscribers_url":"https://api.github.com/repos/pattyshack/fsnotify/subscribers","subscription_url":"https://api.github.com/repos/pattyshack/fsnotify/subscription","commits_url":"https://api.github.com/repos/pattyshack/fsnotify/commits{/sha}","git_commits_url":"https://api.github.com/repos/pattyshack/fsnotify/git/commits{/sha}","comments_url":"https://api.github.com/repos/pattyshack/fsnotify/comments{/number}","issue_comment_url":"https://api.github.com/repos/pattyshack/fsnotify/issues/comments{/number}","contents_url":"https://api.github.com/repos/pattyshack/fsnotify/contents/{+path}","compare_url":"https://api.github.com/repos/pattyshack/fsnotify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pattyshack/fsnotify/merges","archive_url":"https://api.github.com/repos/pattyshack/fsnotify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pattyshack/fsnotify/downloads","issues_url":"https://api.github.com/repos/pattyshack/fsnotify/issues{/number}","pulls_url":"https://api.github.com/repos/pattyshack/fsnotify/pulls{/number}","milestones_url":"https://api.github.com/repos/pattyshack/fsnotify/milestones{/number}","notifications_url":"https://api.github.com/repos/pattyshack/fsnotify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pattyshack/fsnotify/labels{/name}","releases_url":"https://api.github.com/repos/pattyshack/fsnotify/releases{/id}","deployments_url":"https://api.github.com/repos/pattyshack/fsnotify/deployments","created_at":"2016-10-04T22:44:31Z","updated_at":"2016-10-04T22:44:32Z","pushed_at":"2016-10-05T02:25:29Z","git_url":"git://github.com/pattyshack/fsnotify.git","ssh_url":"git@github.com:pattyshack/fsnotify.git","clone_url":"https://github.com/pattyshack/fsnotify.git","svn_url":"https://github.com/pattyshack/fsnotify","homepage":"https://fsnotify.org","size":320,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fsnotify:master","ref":"master","sha":"c07fd863aee264025aa0ef438bf9d2046c803493","user":{"login":"fsnotify","id":8013877,"avatar_url":"https://avatars.githubusercontent.com/u/8013877?v=3","gravatar_id":"","url":"https://api.github.com/users/fsnotify","html_url":"https://github.com/fsnotify","followers_url":"https://api.github.com/users/fsnotify/followers","following_url":"https://api.github.com/users/fsnotify/following{/other_user}","gists_url":"https://api.github.com/users/fsnotify/gists{/gist_id}","starred_url":"https://api.github.com/users/fsnotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsnotify/subscriptions","organizations_url":"https://api.github.com/users/fsnotify/orgs","repos_url":"https://api.github.com/users/fsnotify/repos","events_url":"https://api.github.com/users/fsnotify/events{/privacy}","received_events_url":"https://api.github.com/users/fsnotify/received_events","type":"Organization","site_admin":false},"repo":{"id":21306961,"name":"fsnotify","full_name":"fsnotify/fsnotify","owner":{"login":"fsnotify","id":8013877,"avatar_url":"https://avatars.githubusercontent.com/u/8013877?v=3","gravatar_id":"","url":"https://api.github.com/users/fsnotify","html_url":"https://github.com/fsnotify","followers_url":"https://api.github.com/users/fsnotify/followers","following_url":"https://api.github.com/users/fsnotify/following{/other_user}","gists_url":"https://api.github.com/users/fsnotify/gists{/gist_id}","starred_url":"https://api.github.com/users/fsnotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsnotify/subscriptions","organizations_url":"https://api.github.com/users/fsnotify/orgs","repos_url":"https://api.github.com/users/fsnotify/repos","events_url":"https://api.github.com/users/fsnotify/events{/privacy}","received_events_url":"https://api.github.com/users/fsnotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fsnotify/fsnotify","description":"File system notifications for Go.","fork":false,"url":"https://api.github.com/repos/fsnotify/fsnotify","forks_url":"https://api.github.com/repos/fsnotify/fsnotify/forks","keys_url":"https://api.github.com/repos/fsnotify/fsnotify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fsnotify/fsnotify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fsnotify/fsnotify/teams","hooks_url":"https://api.github.com/repos/fsnotify/fsnotify/hooks","issue_events_url":"https://api.github.com/repos/fsnotify/fsnotify/issues/events{/number}","events_url":"https://api.github.com/repos/fsnotify/fsnotify/events","assignees_url":"https://api.github.com/repos/fsnotify/fsnotify/assignees{/user}","branches_url":"https://api.github.com/repos/fsnotify/fsnotify/branches{/branch}","tags_url":"https://api.github.com/repos/fsnotify/fsnotify/tags","blobs_url":"https://api.github.com/repos/fsnotify/fsnotify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fsnotify/fsnotify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fsnotify/fsnotify/git/refs{/sha}","trees_url":"https://api.github.com/repos/fsnotify/fsnotify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fsnotify/fsnotify/statuses/{sha}","languages_url":"https://api.github.com/repos/fsnotify/fsnotify/languages","stargazers_url":"https://api.github.com/repos/fsnotify/fsnotify/stargazers","contributors_url":"https://api.github.com/repos/fsnotify/fsnotify/contributors","subscribers_url":"https://api.github.com/repos/fsnotify/fsnotify/subscribers","subscription_url":"https://api.github.com/repos/fsnotify/fsnotify/subscription","commits_url":"https://api.github.com/repos/fsnotify/fsnotify/commits{/sha}","git_commits_url":"https://api.github.com/repos/fsnotify/fsnotify/git/commits{/sha}","comments_url":"https://api.github.com/repos/fsnotify/fsnotify/comments{/number}","issue_comment_url":"https://api.github.com/repos/fsnotify/fsnotify/issues/comments{/number}","contents_url":"https://api.github.com/repos/fsnotify/fsnotify/contents/{+path}","compare_url":"https://api.github.com/repos/fsnotify/fsnotify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fsnotify/fsnotify/merges","archive_url":"https://api.github.com/repos/fsnotify/fsnotify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fsnotify/fsnotify/downloads","issues_url":"https://api.github.com/repos/fsnotify/fsnotify/issues{/number}","pulls_url":"https://api.github.com/repos/fsnotify/fsnotify/pulls{/number}","milestones_url":"https://api.github.com/repos/fsnotify/fsnotify/milestones{/number}","notifications_url":"https://api.github.com/repos/fsnotify/fsnotify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fsnotify/fsnotify/labels{/name}","releases_url":"https://api.github.com/repos/fsnotify/fsnotify/releases{/id}","deployments_url":"https://api.github.com/repos/fsnotify/fsnotify/deployments","created_at":"2014-06-28T16:47:01Z","updated_at":"2016-10-04T21:22:54Z","pushed_at":"2016-10-05T02:09:41Z","git_url":"git://github.com/fsnotify/fsnotify.git","ssh_url":"git@github.com:fsnotify/fsnotify.git","clone_url":"https://github.com/fsnotify/fsnotify.git","svn_url":"https://github.com/fsnotify/fsnotify","homepage":"https://fsnotify.org","size":539,"stargazers_count":1078,"watchers_count":1078,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":139,"mirror_url":null,"open_issues_count":87,"forks":139,"open_issues":87,"watchers":1078,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fsnotify/fsnotify/pulls/174"},"html":{"href":"https://github.com/fsnotify/fsnotify/pull/174"},"issue":{"href":"https://api.github.com/repos/fsnotify/fsnotify/issues/174"},"comments":{"href":"https://api.github.com/repos/fsnotify/fsnotify/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/fsnotify/fsnotify/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/fsnotify/fsnotify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fsnotify/fsnotify/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/fsnotify/fsnotify/statuses/3e9e138b2ebaf7480698fd6f14011d28d6250f38"}}}}
{"actor":{"display_login":"nathany"}}