{"action":"created","issue":{"url":"https://api.github.com/repos/codice/ddf/issues/1292","repository_url":"https://api.github.com/repos/codice/ddf","labels_url":"https://api.github.com/repos/codice/ddf/issues/1292/labels{/name}","comments_url":"https://api.github.com/repos/codice/ddf/issues/1292/comments","events_url":"https://api.github.com/repos/codice/ddf/issues/1292/events","html_url":"https://github.com/codice/ddf/pull/1292","id":178202454,"number":1292,"title":"DDF-2478 Add service to convert country codes from FIPS 10-4 (or others) into ISO 3166-1 alpha 3 and vice versa","user":{"login":"roelens8","id":5935039,"avatar_url":"https://avatars.githubusercontent.com/u/5935039?v=3","gravatar_id":"","url":"https://api.github.com/users/roelens8","html_url":"https://github.com/roelens8","followers_url":"https://api.github.com/users/roelens8/followers","following_url":"https://api.github.com/users/roelens8/following{/other_user}","gists_url":"https://api.github.com/users/roelens8/gists{/gist_id}","starred_url":"https://api.github.com/users/roelens8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roelens8/subscriptions","organizations_url":"https://api.github.com/users/roelens8/orgs","repos_url":"https://api.github.com/users/roelens8/repos","events_url":"https://api.github.com/users/roelens8/events{/privacy}","received_events_url":"https://api.github.com/users/roelens8/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"pklinef","id":700518,"avatar_url":"https://avatars.githubusercontent.com/u/700518?v=3","gravatar_id":"","url":"https://api.github.com/users/pklinef","html_url":"https://github.com/pklinef","followers_url":"https://api.github.com/users/pklinef/followers","following_url":"https://api.github.com/users/pklinef/following{/other_user}","gists_url":"https://api.github.com/users/pklinef/gists{/gist_id}","starred_url":"https://api.github.com/users/pklinef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pklinef/subscriptions","organizations_url":"https://api.github.com/users/pklinef/orgs","repos_url":"https://api.github.com/users/pklinef/repos","events_url":"https://api.github.com/users/pklinef/events{/privacy}","received_events_url":"https://api.github.com/users/pklinef/received_events","type":"User","site_admin":false},"assignees":[{"login":"pklinef","id":700518,"avatar_url":"https://avatars.githubusercontent.com/u/700518?v=3","gravatar_id":"","url":"https://api.github.com/users/pklinef","html_url":"https://github.com/pklinef","followers_url":"https://api.github.com/users/pklinef/followers","following_url":"https://api.github.com/users/pklinef/following{/other_user}","gists_url":"https://api.github.com/users/pklinef/gists{/gist_id}","starred_url":"https://api.github.com/users/pklinef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pklinef/subscriptions","organizations_url":"https://api.github.com/users/pklinef/orgs","repos_url":"https://api.github.com/users/pklinef/repos","events_url":"https://api.github.com/users/pklinef/events{/privacy}","received_events_url":"https://api.github.com/users/pklinef/received_events","type":"User","site_admin":false},{"login":"jaymcnallie","id":4419383,"avatar_url":"https://avatars.githubusercontent.com/u/4419383?v=3","gravatar_id":"","url":"https://api.github.com/users/jaymcnallie","html_url":"https://github.com/jaymcnallie","followers_url":"https://api.github.com/users/jaymcnallie/followers","following_url":"https://api.github.com/users/jaymcnallie/following{/other_user}","gists_url":"https://api.github.com/users/jaymcnallie/gists{/gist_id}","starred_url":"https://api.github.com/users/jaymcnallie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaymcnallie/subscriptions","organizations_url":"https://api.github.com/users/jaymcnallie/orgs","repos_url":"https://api.github.com/users/jaymcnallie/repos","events_url":"https://api.github.com/users/jaymcnallie/events{/privacy}","received_events_url":"https://api.github.com/users/jaymcnallie/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2016-09-20T22:59:20Z","updated_at":"2016-10-31T20:32:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/1292","html_url":"https://github.com/codice/ddf/pull/1292","diff_url":"https://github.com/codice/ddf/pull/1292.diff","patch_url":"https://github.com/codice/ddf/pull/1292.patch"},"body":"#### What does this PR do?\n\n-Adds an OSGi service to convert country codes from FIPS 10-4 (or others) into ISO 3166-1 alpha and vice versa.\n-LocalCountryCodeConverter.java: loads in a static file (fips_10_4.properties) containing the country code mappings, builds MultiMaps from the mappings to perform the conversions. Other mapping files can be dynamically added to feature and are automatically used to create other mappings for different country code formats.\n\n-Removes the ISOCountryFormatConverter.java.\n\nThis DDF API is designed to be expanded to support not only converting country codes using a local static file, but also converting country codes via external services when available in the future.\n#### Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged; if a component team is listed, at least one of its members needs to approve)?\n\n@dcruver \n@ryeats \n@jlcsmith \n@harrison-tarr \n@peterhuffer \n#### Choose 2 committers to review/merge the PR (please choose ONLY two committers from below, delete the rest).\n\n@jaymcnallie\n@pklinef\n#### How should this be tested?\n\nRun a full build. Make sure integration and unit tests pass. Verify the service install correctly.\n\nVerify the country mappings from this link are the same as the mappings from the country codes mapping file from this PR. I did not include the countries that did not have a FIPS 10-4 to ISO 3166-1 alpha 3 mapping. http://www.opengeocode.org/download/fips2iso.txt\n\nAlso, run the `migration:export` admin command and make sure the `fips_10_4.properties` file gets exported to the `$DDF_HOME/etc/exported/etc` directory.\n#### Any background context you want to provide?\n\nThere needs to be a way to normalize country codes from inputs eg. NITFs, that contain a 2 letter country code (FIPS 10-4), into a common format DDF uses (ISO 3166-1 alpha 3) so that when a user wants to query a metacard by country, he would search by the normalized country code and still retrieve metacards from inputs that have a country code in FIPS 10-4. This service will provide the ability to normalize those country codes.\n#### What are the relevant tickets?\n\nDDF-2478\n#### Screenshots (if appropriate)\n#### Checklist:\n- [X] Documentation Updated\n- [X] Update / Add Unit Tests\n- [ ] Update / Add Integration Tests\n"},"comment":{"url":"https://api.github.com/repos/codice/ddf/issues/comments/257412108","html_url":"https://github.com/codice/ddf/pull/1292#issuecomment-257412108","issue_url":"https://api.github.com/repos/codice/ddf/issues/1292","id":257412108,"user":{"login":"roelens8","id":5935039,"avatar_url":"https://avatars.githubusercontent.com/u/5935039?v=3","gravatar_id":"","url":"https://api.github.com/users/roelens8","html_url":"https://github.com/roelens8","followers_url":"https://api.github.com/users/roelens8/followers","following_url":"https://api.github.com/users/roelens8/following{/other_user}","gists_url":"https://api.github.com/users/roelens8/gists{/gist_id}","starred_url":"https://api.github.com/users/roelens8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roelens8/subscriptions","organizations_url":"https://api.github.com/users/roelens8/orgs","repos_url":"https://api.github.com/users/roelens8/repos","events_url":"https://api.github.com/users/roelens8/events{/privacy}","received_events_url":"https://api.github.com/users/roelens8/received_events","type":"User","site_admin":false},"created_at":"2016-10-31T20:32:26Z","updated_at":"2016-10-31T20:32:26Z","body":"After further discussion, it was concluded the best approach for now is to revert the PR back to the state when the interface was specific to ISO and FIPS."}}
{"actor":{"display_login":"roelens8"}}