{"action":"created","issue":{"url":"https://api.github.com/repos/eddelbuettel/rquantlib/issues/50","repository_url":"https://api.github.com/repos/eddelbuettel/rquantlib","labels_url":"https://api.github.com/repos/eddelbuettel/rquantlib/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/eddelbuettel/rquantlib/issues/50/comments","events_url":"https://api.github.com/repos/eddelbuettel/rquantlib/issues/50/events","html_url":"https://github.com/eddelbuettel/rquantlib/pull/50","id":155087012,"number":50,"title":"Cleanup enums","user":{"login":"thrasibule","id":494248,"avatar_url":"https://avatars.githubusercontent.com/u/494248?v=3","gravatar_id":"","url":"https://api.github.com/users/thrasibule","html_url":"https://github.com/thrasibule","followers_url":"https://api.github.com/users/thrasibule/followers","following_url":"https://api.github.com/users/thrasibule/following{/other_user}","gists_url":"https://api.github.com/users/thrasibule/gists{/gist_id}","starred_url":"https://api.github.com/users/thrasibule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thrasibule/subscriptions","organizations_url":"https://api.github.com/users/thrasibule/orgs","repos_url":"https://api.github.com/users/thrasibule/repos","events_url":"https://api.github.com/users/thrasibule/events{/privacy}","received_events_url":"https://api.github.com/users/thrasibule/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-05-16T18:12:58Z","updated_at":"2016-05-29T15:03:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eddelbuettel/rquantlib/pulls/50","html_url":"https://github.com/eddelbuettel/rquantlib/pull/50","diff_url":"https://github.com/eddelbuettel/rquantlib/pull/50.diff","patch_url":"https://github.com/eddelbuettel/rquantlib/pull/50.patch"},"body":"I think it makes more sense to have all these enums as ``int`` instead of ``double``. I also use a static_cast instead of a giant switch. It's simpler, and also more futureproof in case QuantLib adds more cases to these.\r\n\r\nI've also updated the Rcpp generated files. Some of the changes reflect changes to the functions that @tleitch did recently. I can try to disentangle his commits from mine if it's an issue."},"comment":{"url":"https://api.github.com/repos/eddelbuettel/rquantlib/issues/comments/222365286","html_url":"https://github.com/eddelbuettel/rquantlib/pull/50#issuecomment-222365286","issue_url":"https://api.github.com/repos/eddelbuettel/rquantlib/issues/50","id":222365286,"user":{"login":"eddelbuettel","id":673121,"avatar_url":"https://avatars.githubusercontent.com/u/673121?v=3","gravatar_id":"","url":"https://api.github.com/users/eddelbuettel","html_url":"https://github.com/eddelbuettel","followers_url":"https://api.github.com/users/eddelbuettel/followers","following_url":"https://api.github.com/users/eddelbuettel/following{/other_user}","gists_url":"https://api.github.com/users/eddelbuettel/gists{/gist_id}","starred_url":"https://api.github.com/users/eddelbuettel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddelbuettel/subscriptions","organizations_url":"https://api.github.com/users/eddelbuettel/orgs","repos_url":"https://api.github.com/users/eddelbuettel/repos","events_url":"https://api.github.com/users/eddelbuettel/events{/privacy}","received_events_url":"https://api.github.com/users/eddelbuettel/received_events","type":"User","site_admin":false},"created_at":"2016-05-29T15:03:33Z","updated_at":"2016-05-29T15:03:33Z","body":"I like how #53 was cleaner/simpler/easier to assess.  May I propose we close this one and start over with more well-defined tasks, preferably with tests and documentation too?"}}
{"actor":{"display_login":"eddelbuettel"}}