{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/74109649","id":74109649,"diff_hunk":"@@ -140,6 +139,13 @@ func NewClientStream(ctx context.Context, desc *StreamDesc, cc *ClientConn, meth\n \t\tcs.trInfo.tr.LazyLog(&cs.trInfo.firstLine, false)\n \t\tctx = trace.NewContext(ctx, cs.trInfo.tr)\n \t}\n+\tdefer func() {\n+\t\tif err != nil {\n+\t\t\t// Need to call cs.finish() if error is returned.\n+\t\t\t// Because cs will not be returned to caller.\n+\t\t\tcs.finish(err)","path":"stream.go","position":21,"original_position":21,"commit_id":"43cdc3c81c108b39d48c27224d4347028a9fb6f3","original_commit_id":"43cdc3c81c108b39d48c27224d4347028a9fb6f3","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"body":"`cs` is not even used until way down below after the for loop. Why does it need to be allocated way up here?","created_at":"2016-08-09T17:52:48Z","updated_at":"2016-08-09T17:52:48Z","html_url":"https://github.com/grpc/grpc-go/pull/817#discussion_r74109649","pull_request_url":"https://api.github.com/repos/grpc/grpc-go/pulls/817","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/74109649"},"html":{"href":"https://github.com/grpc/grpc-go/pull/817#discussion_r74109649"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/817"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/817","id":80664615,"html_url":"https://github.com/grpc/grpc-go/pull/817","diff_url":"https://github.com/grpc/grpc-go/pull/817.diff","patch_url":"https://github.com/grpc/grpc-go/pull/817.patch","issue_url":"https://api.github.com/repos/grpc/grpc-go/issues/817","number":817,"state":"open","locked":false,"title":"Finish clientstream when newclientsteram returns error","user":{"login":"menghanl","id":960845,"avatar_url":"https://avatars.githubusercontent.com/u/960845?v=3","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false},"body":"fixes #812","created_at":"2016-08-09T17:50:10Z","updated_at":"2016-08-09T17:52:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a306cfc723c0a787e2fdcbfdbbe0ef1da8f25dae","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-go/pulls/817/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-go/pulls/817/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-go/issues/817/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/43cdc3c81c108b39d48c27224d4347028a9fb6f3","head":{"label":"menghanl:finish_clientstream_on_error","ref":"finish_clientstream_on_error","sha":"43cdc3c81c108b39d48c27224d4347028a9fb6f3","user":{"login":"menghanl","id":960845,"avatar_url":"https://avatars.githubusercontent.com/u/960845?v=3","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false},"repo":{"id":54156883,"name":"grpc-go","full_name":"menghanl/grpc-go","owner":{"login":"menghanl","id":960845,"avatar_url":"https://avatars.githubusercontent.com/u/960845?v=3","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/menghanl/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/menghanl/grpc-go","forks_url":"https://api.github.com/repos/menghanl/grpc-go/forks","keys_url":"https://api.github.com/repos/menghanl/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/menghanl/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/menghanl/grpc-go/teams","hooks_url":"https://api.github.com/repos/menghanl/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/menghanl/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/menghanl/grpc-go/events","assignees_url":"https://api.github.com/repos/menghanl/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/menghanl/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/menghanl/grpc-go/tags","blobs_url":"https://api.github.com/repos/menghanl/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/menghanl/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/menghanl/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/menghanl/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/menghanl/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/menghanl/grpc-go/languages","stargazers_url":"https://api.github.com/repos/menghanl/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/menghanl/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/menghanl/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/menghanl/grpc-go/subscription","commits_url":"https://api.github.com/repos/menghanl/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/menghanl/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/menghanl/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/menghanl/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/menghanl/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/menghanl/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/menghanl/grpc-go/merges","archive_url":"https://api.github.com/repos/menghanl/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/menghanl/grpc-go/downloads","issues_url":"https://api.github.com/repos/menghanl/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/menghanl/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/menghanl/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/menghanl/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/menghanl/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/menghanl/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/menghanl/grpc-go/deployments","created_at":"2016-03-17T22:55:39Z","updated_at":"2016-03-17T22:55:40Z","pushed_at":"2016-08-09T17:48:33Z","git_url":"git://github.com/menghanl/grpc-go.git","ssh_url":"git@github.com:menghanl/grpc-go.git","clone_url":"https://github.com/menghanl/grpc-go.git","svn_url":"https://github.com/menghanl/grpc-go","homepage":"","size":2353,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"35896af9ad39c1fb1b1cd925fe3621be361e3d81","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729907,"name":"grpc-go","full_name":"grpc/grpc-go","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-go","forks_url":"https://api.github.com/repos/grpc/grpc-go/forks","keys_url":"https://api.github.com/repos/grpc/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-go/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-go/events","assignees_url":"https://api.github.com/repos/grpc/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-go/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-go/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-go/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-go/merges","archive_url":"https://api.github.com/repos/grpc/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-go/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-go/deployments","created_at":"2014-12-08T18:59:34Z","updated_at":"2016-08-09T13:15:09Z","pushed_at":"2016-08-09T17:50:10Z","git_url":"git://github.com/grpc/grpc-go.git","ssh_url":"git@github.com:grpc/grpc-go.git","clone_url":"https://github.com/grpc/grpc-go.git","svn_url":"https://github.com/grpc/grpc-go","homepage":"","size":3172,"stargazers_count":2030,"watchers_count":2030,"language":"Go","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":317,"mirror_url":null,"open_issues_count":79,"forks":317,"open_issues":79,"watchers":2030,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/817"},"html":{"href":"https://github.com/grpc/grpc-go/pull/817"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/817"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/817/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/817/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/817/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-go/statuses/43cdc3c81c108b39d48c27224d4347028a9fb6f3"}}}}
{"actor":{"display_login":"tamird"}}