{"action":"created","comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/64987505","id":64987505,"diff_hunk":"@@ -10584,14 +10592,15 @@ bool game::handle_liquid( item &liquid, item * const source, const int radius,\n     }\n \n     menu.query();\n+    refresh_all();\n     const size_t chosen = static_cast<size_t>( menu.ret );\n     if( chosen >= actions.size() ) {\n         add_msg( _( \"Never mind.\" ) );\n         // Explicitly canceled all options (container, drink, pour).\n         return false;\n     }\n-    actions[chosen]();\n-    return true;\n+\n+    return actions[chosen]();","path":"src/game.cpp","position":165,"original_position":165,"commit_id":"c7f7f506ae4ea0316e43da0f70bdcff4c60ec162","original_commit_id":"c7f7f506ae4ea0316e43da0f70bdcff4c60ec162","user":{"login":"BevapDin","id":5095435,"avatar_url":"https://avatars.githubusercontent.com/u/5095435?v=3","gravatar_id":"","url":"https://api.github.com/users/BevapDin","html_url":"https://github.com/BevapDin","followers_url":"https://api.github.com/users/BevapDin/followers","following_url":"https://api.github.com/users/BevapDin/following{/other_user}","gists_url":"https://api.github.com/users/BevapDin/gists{/gist_id}","starred_url":"https://api.github.com/users/BevapDin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BevapDin/subscriptions","organizations_url":"https://api.github.com/users/BevapDin/orgs","repos_url":"https://api.github.com/users/BevapDin/repos","events_url":"https://api.github.com/users/BevapDin/events{/privacy}","received_events_url":"https://api.github.com/users/BevapDin/received_events","type":"User","site_admin":false},"body":"This kind of changes the meaning of the return value, please make sure it still fits the documented eaning (see game.h).\r\n\r\nReturning true means the player wanted to handle the liquid, but may have failed to actually do anything with it (e.g. choose to pour it into a container, but could not find a suitable one, or choose to pour into a keg on the ground, but that was already full). It should return `false` when the player explicitly canceled.","created_at":"2016-05-28T11:00:15Z","updated_at":"2016-05-28T11:00:15Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16901#discussion_r64987505","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16901","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/64987505"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16901#discussion_r64987505"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16901"}}},"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16901","id":71781567,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16901","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16901.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16901.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16901","number":16901,"state":"open","locked":false,"title":"Some tweaks to liquid handling","user":{"login":"codemime","id":11905613,"avatar_url":"https://avatars.githubusercontent.com/u/11905613?v=3","gravatar_id":"","url":"https://api.github.com/users/codemime","html_url":"https://github.com/codemime","followers_url":"https://api.github.com/users/codemime/followers","following_url":"https://api.github.com/users/codemime/following{/other_user}","gists_url":"https://api.github.com/users/codemime/gists{/gist_id}","starred_url":"https://api.github.com/users/codemime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemime/subscriptions","organizations_url":"https://api.github.com/users/codemime/orgs","repos_url":"https://api.github.com/users/codemime/repos","events_url":"https://api.github.com/users/codemime/events{/privacy}","received_events_url":"https://api.github.com/users/codemime/received_events","type":"User","site_admin":false},"body":"Determination of infinite sources of liquid is broken. Some item charges are `int`s and some others are `long`s. It causes a couple of observable bugs:\r\n\r\n**Minor (note the number of charges):**\r\n![screenshot_2016-05-28_01-06-05](https://cloud.githubusercontent.com/assets/11905613/15622699/69ff485c-247c-11e6-9f32-739e0fca6408.png)\r\n\r\n**Major:**\r\n1. Go to an infinite source of water (rivers, lakes etc)\r\n2. Examine it and select \"Pour on the ground\"\r\n3. Behold a labour of Sisyphus in an infinite loop (finite actually).\r\n\r\nThe game won't warn you that you can't drink an ocean. It won't ask you where do you prefer to pour it either. Also, pouring liquid into a container is in the menu now:\r\n\r\n![screenshot_2016-05-28_01-04-12](https://cloud.githubusercontent.com/assets/11905613/15622760/473e7e54-247d-11e6-9225-5f74e1f999cc.png)\r\n","created_at":"2016-05-27T22:45:10Z","updated_at":"2016-05-28T11:00:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11eef2739e83bb5513e6514b1c55be54feede44b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16901/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16901/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16901/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/c7f7f506ae4ea0316e43da0f70bdcff4c60ec162","head":{"label":"codemime:liquid_tweaks","ref":"liquid_tweaks","sha":"c7f7f506ae4ea0316e43da0f70bdcff4c60ec162","user":{"login":"codemime","id":11905613,"avatar_url":"https://avatars.githubusercontent.com/u/11905613?v=3","gravatar_id":"","url":"https://api.github.com/users/codemime","html_url":"https://github.com/codemime","followers_url":"https://api.github.com/users/codemime/followers","following_url":"https://api.github.com/users/codemime/following{/other_user}","gists_url":"https://api.github.com/users/codemime/gists{/gist_id}","starred_url":"https://api.github.com/users/codemime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemime/subscriptions","organizations_url":"https://api.github.com/users/codemime/orgs","repos_url":"https://api.github.com/users/codemime/repos","events_url":"https://api.github.com/users/codemime/events{/privacy}","received_events_url":"https://api.github.com/users/codemime/received_events","type":"User","site_admin":false},"repo":{"id":50468318,"name":"Cataclysm-DDA","full_name":"codemime/Cataclysm-DDA","owner":{"login":"codemime","id":11905613,"avatar_url":"https://avatars.githubusercontent.com/u/11905613?v=3","gravatar_id":"","url":"https://api.github.com/users/codemime","html_url":"https://github.com/codemime","followers_url":"https://api.github.com/users/codemime/followers","following_url":"https://api.github.com/users/codemime/following{/other_user}","gists_url":"https://api.github.com/users/codemime/gists{/gist_id}","starred_url":"https://api.github.com/users/codemime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemime/subscriptions","organizations_url":"https://api.github.com/users/codemime/orgs","repos_url":"https://api.github.com/users/codemime/repos","events_url":"https://api.github.com/users/codemime/events{/privacy}","received_events_url":"https://api.github.com/users/codemime/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/codemime/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/codemime/Cataclysm-DDA","forks_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/codemime/Cataclysm-DDA/deployments","created_at":"2016-01-27T00:03:47Z","updated_at":"2016-01-27T00:03:54Z","pushed_at":"2016-05-27T22:29:16Z","git_url":"git://github.com/codemime/Cataclysm-DDA.git","ssh_url":"git@github.com:codemime/Cataclysm-DDA.git","clone_url":"https://github.com/codemime/Cataclysm-DDA.git","svn_url":"https://github.com/codemime/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":767827,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"0d0aabaac434638a064601d731283217cff82eb4","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/deployments","created_at":"2012-09-26T22:57:43Z","updated_at":"2016-05-26T09:55:35Z","pushed_at":"2016-05-28T10:30:28Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":1032664,"stargazers_count":959,"watchers_count":959,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":886,"mirror_url":null,"open_issues_count":1258,"forks":886,"open_issues":1258,"watchers":959,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16901"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/16901"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16901"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/16901/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16901/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/16901/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/c7f7f506ae4ea0316e43da0f70bdcff4c60ec162"}}}}
{"actor":{"display_login":"BevapDin"}}