{"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/93475337","pull_request_review_id":14003860,"id":93475337,"diff_hunk":"@@ -164,7 +164,13 @@ Active Support provides `duplicable?` to programmatically query an object about\n false.duplicable? # => false\n ```\n \n-By definition all objects are `duplicable?` except `nil`, `false`, `true`, symbols, numbers, class, module, and method objects.\n+<<<<<<< HEAD\n+By definition all objects are `duplicable?` excepting method objects, numbers as well as `nil`, `false`, `true`, symbols, class, and module.\n+\n+As of Ruby version 2.4.0 numbers, `nil`, `false`, `true`, symbols, class and module objects are also `duplicable?`.\n+=======\n+By definition all objects are `duplicable?` including BigDecimals, but excepting all other numbers as well as `nil`, `false`, `true`, symbols, class, module, and method objects. As of Ruby 2.4.0 even class and module objects are `duplicable?`.\n+>>>>>>> d738fd8... Update list of `duplicable?` objects in AS core_ext guide [ci skip]","path":"guides/source/active_support_core_extensions.md","position":11,"original_position":11,"commit_id":"4d39bfd880bec4fc5cdd3d0ffb3a05db893fe06f","original_commit_id":"4d39bfd880bec4fc5cdd3d0ffb3a05db893fe06f","user":{"login":"utilum","id":6261109,"avatar_url":"https://avatars.githubusercontent.com/u/6261109?v=3","gravatar_id":"","url":"https://api.github.com/users/utilum","html_url":"https://github.com/utilum","followers_url":"https://api.github.com/users/utilum/followers","following_url":"https://api.github.com/users/utilum/following{/other_user}","gists_url":"https://api.github.com/users/utilum/gists{/gist_id}","starred_url":"https://api.github.com/users/utilum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utilum/subscriptions","organizations_url":"https://api.github.com/users/utilum/orgs","repos_url":"https://api.github.com/users/utilum/repos","events_url":"https://api.github.com/users/utilum/events{/privacy}","received_events_url":"https://api.github.com/users/utilum/received_events","type":"User","site_admin":false},"body":"Thank you @kaspth , pleasure to dig in a little more.\r\n\r\nI've learned that the above *immediate*s still can't be properly duplicated, 2.4 just quietly returns the original object. But I doubt that the core extensions guide is the place to go into this, so I think I'd remove the bit about the general logic of why singletons can not be duplicated.\r\n\r\n`Complex` and `Rational` still won't `dup` even in 2.4.0-rc1, but return true on `duplicable?` So I'm putting this on hold for #27424 to be resolved.","created_at":"2016-12-21T16:48:25Z","updated_at":"2016-12-21T16:48:25Z","html_url":"https://github.com/rails/rails/pull/27346#discussion_r93475337","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/27346","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/93475337"},"html":{"href":"https://github.com/rails/rails/pull/27346#discussion_r93475337"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/27346"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/27346","id":97774210,"html_url":"https://github.com/rails/rails/pull/27346","diff_url":"https://github.com/rails/rails/pull/27346.diff","patch_url":"https://github.com/rails/rails/pull/27346.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/27346","number":27346,"state":"open","locked":false,"title":"Update list of `duplicable?` objects in AS core_ext guide [ci skip]","user":{"login":"utilum","id":6261109,"avatar_url":"https://avatars.githubusercontent.com/u/6261109?v=3","gravatar_id":"","url":"https://api.github.com/users/utilum","html_url":"https://github.com/utilum","followers_url":"https://api.github.com/users/utilum/followers","following_url":"https://api.github.com/users/utilum/following{/other_user}","gists_url":"https://api.github.com/users/utilum/gists{/gist_id}","starred_url":"https://api.github.com/users/utilum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utilum/subscriptions","organizations_url":"https://api.github.com/users/utilum/orgs","repos_url":"https://api.github.com/users/utilum/repos","events_url":"https://api.github.com/users/utilum/events{/privacy}","received_events_url":"https://api.github.com/users/utilum/received_events","type":"User","site_admin":false},"body":"BigDecimal has been duplicable? since 440559f.","created_at":"2016-12-13T15:35:57Z","updated_at":"2016-12-21T16:48:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6164de2c2a64be4157d87666682e3c684a647a9d","assignee":{"login":"schneems","id":59744,"avatar_url":"https://avatars.githubusercontent.com/u/59744?v=3","gravatar_id":"","url":"https://api.github.com/users/schneems","html_url":"https://github.com/schneems","followers_url":"https://api.github.com/users/schneems/followers","following_url":"https://api.github.com/users/schneems/following{/other_user}","gists_url":"https://api.github.com/users/schneems/gists{/gist_id}","starred_url":"https://api.github.com/users/schneems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneems/subscriptions","organizations_url":"https://api.github.com/users/schneems/orgs","repos_url":"https://api.github.com/users/schneems/repos","events_url":"https://api.github.com/users/schneems/events{/privacy}","received_events_url":"https://api.github.com/users/schneems/received_events","type":"User","site_admin":false},"assignees":[{"login":"schneems","id":59744,"avatar_url":"https://avatars.githubusercontent.com/u/59744?v=3","gravatar_id":"","url":"https://api.github.com/users/schneems","html_url":"https://github.com/schneems","followers_url":"https://api.github.com/users/schneems/followers","following_url":"https://api.github.com/users/schneems/following{/other_user}","gists_url":"https://api.github.com/users/schneems/gists{/gist_id}","starred_url":"https://api.github.com/users/schneems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneems/subscriptions","organizations_url":"https://api.github.com/users/schneems/orgs","repos_url":"https://api.github.com/users/schneems/repos","events_url":"https://api.github.com/users/schneems/events{/privacy}","received_events_url":"https://api.github.com/users/schneems/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/27346/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/27346/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/27346/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/4d39bfd880bec4fc5cdd3d0ffb3a05db893fe06f","head":{"label":"utilum:core_ext_guide_duplicable","ref":"core_ext_guide_duplicable","sha":"4d39bfd880bec4fc5cdd3d0ffb3a05db893fe06f","user":{"login":"utilum","id":6261109,"avatar_url":"https://avatars.githubusercontent.com/u/6261109?v=3","gravatar_id":"","url":"https://api.github.com/users/utilum","html_url":"https://github.com/utilum","followers_url":"https://api.github.com/users/utilum/followers","following_url":"https://api.github.com/users/utilum/following{/other_user}","gists_url":"https://api.github.com/users/utilum/gists{/gist_id}","starred_url":"https://api.github.com/users/utilum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utilum/subscriptions","organizations_url":"https://api.github.com/users/utilum/orgs","repos_url":"https://api.github.com/users/utilum/repos","events_url":"https://api.github.com/users/utilum/events{/privacy}","received_events_url":"https://api.github.com/users/utilum/received_events","type":"User","site_admin":false},"repo":{"id":55279812,"name":"rails","full_name":"utilum/rails","owner":{"login":"utilum","id":6261109,"avatar_url":"https://avatars.githubusercontent.com/u/6261109?v=3","gravatar_id":"","url":"https://api.github.com/users/utilum","html_url":"https://github.com/utilum","followers_url":"https://api.github.com/users/utilum/followers","following_url":"https://api.github.com/users/utilum/following{/other_user}","gists_url":"https://api.github.com/users/utilum/gists{/gist_id}","starred_url":"https://api.github.com/users/utilum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utilum/subscriptions","organizations_url":"https://api.github.com/users/utilum/orgs","repos_url":"https://api.github.com/users/utilum/repos","events_url":"https://api.github.com/users/utilum/events{/privacy}","received_events_url":"https://api.github.com/users/utilum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/utilum/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/utilum/rails","forks_url":"https://api.github.com/repos/utilum/rails/forks","keys_url":"https://api.github.com/repos/utilum/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/utilum/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/utilum/rails/teams","hooks_url":"https://api.github.com/repos/utilum/rails/hooks","issue_events_url":"https://api.github.com/repos/utilum/rails/issues/events{/number}","events_url":"https://api.github.com/repos/utilum/rails/events","assignees_url":"https://api.github.com/repos/utilum/rails/assignees{/user}","branches_url":"https://api.github.com/repos/utilum/rails/branches{/branch}","tags_url":"https://api.github.com/repos/utilum/rails/tags","blobs_url":"https://api.github.com/repos/utilum/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/utilum/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/utilum/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/utilum/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/utilum/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/utilum/rails/languages","stargazers_url":"https://api.github.com/repos/utilum/rails/stargazers","contributors_url":"https://api.github.com/repos/utilum/rails/contributors","subscribers_url":"https://api.github.com/repos/utilum/rails/subscribers","subscription_url":"https://api.github.com/repos/utilum/rails/subscription","commits_url":"https://api.github.com/repos/utilum/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/utilum/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/utilum/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/utilum/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/utilum/rails/contents/{+path}","compare_url":"https://api.github.com/repos/utilum/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/utilum/rails/merges","archive_url":"https://api.github.com/repos/utilum/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/utilum/rails/downloads","issues_url":"https://api.github.com/repos/utilum/rails/issues{/number}","pulls_url":"https://api.github.com/repos/utilum/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/utilum/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/utilum/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/utilum/rails/labels{/name}","releases_url":"https://api.github.com/repos/utilum/rails/releases{/id}","deployments_url":"https://api.github.com/repos/utilum/rails/deployments","created_at":"2016-04-02T05:42:21Z","updated_at":"2016-04-02T05:43:26Z","pushed_at":"2016-12-21T16:43:37Z","git_url":"git://github.com/utilum/rails.git","ssh_url":"git@github.com:utilum/rails.git","clone_url":"https://github.com/utilum/rails.git","svn_url":"https://github.com/utilum/rails","homepage":"http://rubyonrails.org","size":140232,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"1f0fe334f577479ad524cb990bef4454585857c0","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","deployments_url":"https://api.github.com/repos/rails/rails/deployments","created_at":"2008-04-11T02:19:47Z","updated_at":"2016-12-21T16:45:39Z","pushed_at":"2016-12-21T16:47:47Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":140750,"stargazers_count":33840,"watchers_count":33840,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13770,"mirror_url":null,"open_issues_count":1237,"forks":13770,"open_issues":1237,"watchers":33840,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/27346"},"html":{"href":"https://github.com/rails/rails/pull/27346"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/27346"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/27346/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/27346/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/27346/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/4d39bfd880bec4fc5cdd3d0ffb3a05db893fe06f"}}}}
{"actor":{"display_login":"utilum"}}