{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/70188426","id":70188426,"diff_hunk":"@@ -0,0 +1,41 @@\n+{ stdenv, fetchurl, libpng\n+, docSupport ? true, doxygen ? null\n+}:\n+assert docSupport -> doxygen != null;\n+\n+stdenv.mkDerivation rec {\n+  name = \"pngpp-${version}\";\n+  version = \"0.2.9\";\n+\n+  src = fetchurl {\n+    url = \"mirror://savannah/pngpp/png++-${version}.tar.gz\";\n+    sha256 = \"14c74fsc3q8iawf60m74xkkawkqbhd8k8x315m06qaqjcl2nmg5b\";\n+  };\n+\n+  doCheck = true;\n+  checkTarget = \"test\";\n+  preCheck = ''\n+    patchShebangs test/test.sh\n+    substituteInPlace test/test.sh --replace \"exit 1\" \"exit 0\"\n+  '';\n+\n+  postCheck = \"cat test/test.log\";\n+\n+  buildInputs = [ ]\n+    ++ stdenv.lib.optional docSupport [ doxygen ];\n+\n+  propagatedBuildInputs = [ libpng ];\n+\n+  makeFlags = [ \"PREFIX=\\${out}\" ]\n+    ++ stdenv.lib.optional docSupport \"docs\";\n+\n+  enableParallelBuilding = true;\n+\n+  meta = with stdenv.lib; {\n+    homepage = http://www.nongnu.org/pngpp/;\n+    description = \"C++ wrapper for libpng library\";\n+    license = licenses.bsd3;\n+    platforms = platforms.linux;","path":"pkgs/development/libraries/png++/default.nix","position":38,"original_position":38,"commit_id":"f90c526a1c335f3aad64500dd4947dd7122f3fe1","original_commit_id":"f90c526a1c335f3aad64500dd4947dd7122f3fe1","user":{"login":"RamKromberg","id":14829269,"avatar_url":"https://avatars.githubusercontent.com/u/14829269?v=3","gravatar_id":"","url":"https://api.github.com/users/RamKromberg","html_url":"https://github.com/RamKromberg","followers_url":"https://api.github.com/users/RamKromberg/followers","following_url":"https://api.github.com/users/RamKromberg/following{/other_user}","gists_url":"https://api.github.com/users/RamKromberg/gists{/gist_id}","starred_url":"https://api.github.com/users/RamKromberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RamKromberg/subscriptions","organizations_url":"https://api.github.com/users/RamKromberg/orgs","repos_url":"https://api.github.com/users/RamKromberg/repos","events_url":"https://api.github.com/users/RamKromberg/events{/privacy}","received_events_url":"https://api.github.com/users/RamKromberg/received_events","type":"User","site_admin":false},"body":"None that I can think off. But I haven't tested it and the contribution guidelines seems pretty strict about it...\r\nWell, I guess I can switch it on since it's just a library and nothing depends on it right now.","created_at":"2016-07-10T21:14:59Z","updated_at":"2016-07-10T21:14:59Z","html_url":"https://github.com/NixOS/nixpkgs/pull/16782#discussion_r70188426","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/16782","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/70188426"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/16782#discussion_r70188426"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/16782"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/16782","id":76634454,"html_url":"https://github.com/NixOS/nixpkgs/pull/16782","diff_url":"https://github.com/NixOS/nixpkgs/pull/16782.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/16782.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/16782","number":16782,"state":"open","locked":false,"title":"pngpp: init at 0.2.9","user":{"login":"RamKromberg","id":14829269,"avatar_url":"https://avatars.githubusercontent.com/u/14829269?v=3","gravatar_id":"","url":"https://api.github.com/users/RamKromberg","html_url":"https://github.com/RamKromberg","followers_url":"https://api.github.com/users/RamKromberg/followers","following_url":"https://api.github.com/users/RamKromberg/following{/other_user}","gists_url":"https://api.github.com/users/RamKromberg/gists{/gist_id}","starred_url":"https://api.github.com/users/RamKromberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RamKromberg/subscriptions","organizations_url":"https://api.github.com/users/RamKromberg/orgs","repos_url":"https://api.github.com/users/RamKromberg/repos","events_url":"https://api.github.com/users/RamKromberg/events{/privacy}","received_events_url":"https://api.github.com/users/RamKromberg/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nA C++ libpng wrapper library. Not very common though pcsx2 & lenmus seem to use it. Optional for the former but mandatory for the latter.\r\n\r\nLow priority.\r\n\r\n###### Things done\r\n\r\n- [x] Tested using sandboxing\r\n  ([nix.useChroot](http://nixos.org/nixos/manual/options.html#opt-nix.useChroot) on NixOS,\r\n    or option `build-use-chroot` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] OS X\r\n   - [x] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n\r\n","created_at":"2016-07-07T17:28:55Z","updated_at":"2016-07-10T21:14:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a81bd8164721b9678bac93c9300f0ec3cb3ebebb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/16782/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/16782/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/16782/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/f90c526a1c335f3aad64500dd4947dd7122f3fe1","head":{"label":"RamKromberg:init/pngpp","ref":"init/pngpp","sha":"f90c526a1c335f3aad64500dd4947dd7122f3fe1","user":{"login":"RamKromberg","id":14829269,"avatar_url":"https://avatars.githubusercontent.com/u/14829269?v=3","gravatar_id":"","url":"https://api.github.com/users/RamKromberg","html_url":"https://github.com/RamKromberg","followers_url":"https://api.github.com/users/RamKromberg/followers","following_url":"https://api.github.com/users/RamKromberg/following{/other_user}","gists_url":"https://api.github.com/users/RamKromberg/gists{/gist_id}","starred_url":"https://api.github.com/users/RamKromberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RamKromberg/subscriptions","organizations_url":"https://api.github.com/users/RamKromberg/orgs","repos_url":"https://api.github.com/users/RamKromberg/repos","events_url":"https://api.github.com/users/RamKromberg/events{/privacy}","received_events_url":"https://api.github.com/users/RamKromberg/received_events","type":"User","site_admin":false},"repo":{"id":62384289,"name":"nixpkgs","full_name":"RamKromberg/nixpkgs","owner":{"login":"RamKromberg","id":14829269,"avatar_url":"https://avatars.githubusercontent.com/u/14829269?v=3","gravatar_id":"","url":"https://api.github.com/users/RamKromberg","html_url":"https://github.com/RamKromberg","followers_url":"https://api.github.com/users/RamKromberg/followers","following_url":"https://api.github.com/users/RamKromberg/following{/other_user}","gists_url":"https://api.github.com/users/RamKromberg/gists{/gist_id}","starred_url":"https://api.github.com/users/RamKromberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RamKromberg/subscriptions","organizations_url":"https://api.github.com/users/RamKromberg/orgs","repos_url":"https://api.github.com/users/RamKromberg/repos","events_url":"https://api.github.com/users/RamKromberg/events{/privacy}","received_events_url":"https://api.github.com/users/RamKromberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RamKromberg/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/RamKromberg/nixpkgs","forks_url":"https://api.github.com/repos/RamKromberg/nixpkgs/forks","keys_url":"https://api.github.com/repos/RamKromberg/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RamKromberg/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RamKromberg/nixpkgs/teams","hooks_url":"https://api.github.com/repos/RamKromberg/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/RamKromberg/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/RamKromberg/nixpkgs/events","assignees_url":"https://api.github.com/repos/RamKromberg/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/RamKromberg/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/RamKromberg/nixpkgs/tags","blobs_url":"https://api.github.com/repos/RamKromberg/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RamKromberg/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RamKromberg/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/RamKromberg/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RamKromberg/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/RamKromberg/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/RamKromberg/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/RamKromberg/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/RamKromberg/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/RamKromberg/nixpkgs/subscription","commits_url":"https://api.github.com/repos/RamKromberg/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/RamKromberg/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/RamKromberg/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/RamKromberg/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/RamKromberg/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/RamKromberg/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RamKromberg/nixpkgs/merges","archive_url":"https://api.github.com/repos/RamKromberg/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RamKromberg/nixpkgs/downloads","issues_url":"https://api.github.com/repos/RamKromberg/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/RamKromberg/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/RamKromberg/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/RamKromberg/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RamKromberg/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/RamKromberg/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/RamKromberg/nixpkgs/deployments","created_at":"2016-07-01T10:09:30Z","updated_at":"2016-07-01T10:09:54Z","pushed_at":"2016-07-09T13:45:57Z","git_url":"git://github.com/RamKromberg/nixpkgs.git","ssh_url":"git@github.com:RamKromberg/nixpkgs.git","clone_url":"https://github.com/RamKromberg/nixpkgs.git","svn_url":"https://github.com/RamKromberg/nixpkgs","homepage":null,"size":381490,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"599cf0fe504c6d46457f558468152994576661a7","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2016-07-10T18:54:26Z","pushed_at":"2016-07-10T19:57:39Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":584294,"stargazers_count":1182,"watchers_count":1182,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1494,"mirror_url":null,"open_issues_count":1556,"forks":1494,"open_issues":1556,"watchers":1182,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/16782"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/16782"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/16782"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/16782/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/16782/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/16782/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/f90c526a1c335f3aad64500dd4947dd7122f3fe1"}}}}
{"actor":{"display_login":"RamKromberg"}}