{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/12632","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/12632/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/12632/comments","events_url":"https://api.github.com/repos/apache/spark/issues/12632/events","html_url":"https://github.com/apache/spark/pull/12632","id":150521653,"number":12632,"title":"[SPARK-14868][BUILD] Enable NewLineAtEofChecker in checkstyle and fix lint-java errors","user":{"login":"dongjoon-hyun","id":9700541,"avatar_url":"https://avatars.githubusercontent.com/u/9700541?v=3","gravatar_id":"","url":"https://api.github.com/users/dongjoon-hyun","html_url":"https://github.com/dongjoon-hyun","followers_url":"https://api.github.com/users/dongjoon-hyun/followers","following_url":"https://api.github.com/users/dongjoon-hyun/following{/other_user}","gists_url":"https://api.github.com/users/dongjoon-hyun/gists{/gist_id}","starred_url":"https://api.github.com/users/dongjoon-hyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongjoon-hyun/subscriptions","organizations_url":"https://api.github.com/users/dongjoon-hyun/orgs","repos_url":"https://api.github.com/users/dongjoon-hyun/repos","events_url":"https://api.github.com/users/dongjoon-hyun/events{/privacy}","received_events_url":"https://api.github.com/users/dongjoon-hyun/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-04-23T06:03:24Z","updated_at":"2016-04-24T09:18:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/12632","html_url":"https://github.com/apache/spark/pull/12632","diff_url":"https://github.com/apache/spark/pull/12632.diff","patch_url":"https://github.com/apache/spark/pull/12632.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nSpark uses `NewLineAtEofChecker` rule in Scala by ScalaStyle. And, most Java code also comply with the rule. This PR aims to enforce the same rule `NewlineAtEndOfFile` by CheckStyle explicitly. Also, this fixes lint-java errors since SPARK-14465. The followings are the items.\r\n\r\n- Adds a new line at the end of the files (19 files)\r\n- Fixes 25 lint-java errors (12 RedundantModifier, 6 **ArrayTypeStyle**, 2 LineLength, 2 UnusedImports, 2 RegexpSingleline, 1 ModifierOrder)\r\n\r\n## How was this patch tested?\r\n\r\nAfter the Jenkins test succeeds, `dev/lint-java` should pass. (Currently, Jenkins dose not run lint-java.)\r\n```bash\r\n$ dev/lint-java \r\nUsing `mvn` from path: /usr/local/bin/mvn\r\nCheckstyle checks passed.\r\n```"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/213919100","html_url":"https://github.com/apache/spark/pull/12632#issuecomment-213919100","issue_url":"https://api.github.com/repos/apache/spark/issues/12632","id":213919100,"user":{"login":"SparkQA","id":8108735,"avatar_url":"https://avatars.githubusercontent.com/u/8108735?v=3","gravatar_id":"","url":"https://api.github.com/users/SparkQA","html_url":"https://github.com/SparkQA","followers_url":"https://api.github.com/users/SparkQA/followers","following_url":"https://api.github.com/users/SparkQA/following{/other_user}","gists_url":"https://api.github.com/users/SparkQA/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkQA/subscriptions","organizations_url":"https://api.github.com/users/SparkQA/orgs","repos_url":"https://api.github.com/users/SparkQA/repos","events_url":"https://api.github.com/users/SparkQA/events{/privacy}","received_events_url":"https://api.github.com/users/SparkQA/received_events","type":"User","site_admin":false},"created_at":"2016-04-24T09:18:21Z","updated_at":"2016-04-24T09:18:21Z","body":"**[Test build #56838 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56838/consoleFull)** for PR 12632 at commit [`a1747f3`](https://github.com/apache/spark/commit/a1747f3985c7f5871821e49d71d5fe94a0cf5c09).\n * This patch **fails Spark unit tests**.\n * This patch merges cleanly.\n * This patch adds no public classes."}}