{"action":"created","comment":{"url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/comments/65350402","id":65350402,"diff_hunk":"@@ -349,6 +350,19 @@ def check_unicode(self, warn):\n                      'characters; this can lead to Unicode errors occurring. '\n                      'Please use Unicode strings, e.g. %r.' % (name, u'Content'))\n \n+    def check_extension_blacklist(self, warn):","path":"sphinx/config.py","position":12,"original_position":12,"commit_id":"ab5f317f7f3640847ba62dbdbf5f6a30a8b3dcb9","original_commit_id":"ab5f317f7f3640847ba62dbdbf5f6a30a8b3dcb9","user":{"login":"tk0miya","id":748828,"avatar_url":"https://avatars.githubusercontent.com/u/748828?v=3","gravatar_id":"","url":"https://api.github.com/users/tk0miya","html_url":"https://github.com/tk0miya","followers_url":"https://api.github.com/users/tk0miya/followers","following_url":"https://api.github.com/users/tk0miya/following{/other_user}","gists_url":"https://api.github.com/users/tk0miya/gists{/gist_id}","starred_url":"https://api.github.com/users/tk0miya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tk0miya/subscriptions","organizations_url":"https://api.github.com/users/tk0miya/orgs","repos_url":"https://api.github.com/users/tk0miya/repos","events_url":"https://api.github.com/users/tk0miya/events{/privacy}","received_events_url":"https://api.github.com/users/tk0miya/received_events","type":"User","site_admin":false},"body":"I think this checker should move to `sphinx.application.Sphinx.setup_extension()`.\r\nSphinx allows to call `setup_extension()` to load an extension if the 3rd party extension depends on another extensions.\r\n\r\n>Load the extension given by the module name. Use this if your extension needs the features provided by another extension.\r\n\r\nhttp://www.sphinx-doc.org/en/stable/extdev/appapi.html#sphinx.application.Sphinx.setup_extension","created_at":"2016-06-01T12:30:42Z","updated_at":"2016-06-01T12:30:42Z","html_url":"https://github.com/sphinx-doc/sphinx/pull/2608#discussion_r65350402","pull_request_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/2608","_links":{"self":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/comments/65350402"},"html":{"href":"https://github.com/sphinx-doc/sphinx/pull/2608#discussion_r65350402"},"pull_request":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/2608"}}},"pull_request":{"url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/2608","id":72129562,"html_url":"https://github.com/sphinx-doc/sphinx/pull/2608","diff_url":"https://github.com/sphinx-doc/sphinx/pull/2608.diff","patch_url":"https://github.com/sphinx-doc/sphinx/pull/2608.patch","issue_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/2608","number":2608,"state":"open","locked":false,"title":"add extension blacklist to avoid error when loading deprecated extensions","user":{"login":"shibukawa","id":564612,"avatar_url":"https://avatars.githubusercontent.com/u/564612?v=3","gravatar_id":"","url":"https://api.github.com/users/shibukawa","html_url":"https://github.com/shibukawa","followers_url":"https://api.github.com/users/shibukawa/followers","following_url":"https://api.github.com/users/shibukawa/following{/other_user}","gists_url":"https://api.github.com/users/shibukawa/gists{/gist_id}","starred_url":"https://api.github.com/users/shibukawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shibukawa/subscriptions","organizations_url":"https://api.github.com/users/shibukawa/orgs","repos_url":"https://api.github.com/users/shibukawa/repos","events_url":"https://api.github.com/users/shibukawa/events{/privacy}","received_events_url":"https://api.github.com/users/shibukawa/received_events","type":"User","site_admin":false},"body":"\"sphinxjp.themecore\" is already merged into Sphinx, but some old document possibly uses this extension. It raises difficult error messages for novice users.\r\n\r\nThis PR prints warning instead of import error.","created_at":"2016-06-01T06:36:29Z","updated_at":"2016-06-01T12:30:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42c11a695982779523e3f33d5b42cb710ae59ee4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/2608/commits","review_comments_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/2608/comments","review_comment_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/2608/comments","statuses_url":"https://api.github.com/repos/sphinx-doc/sphinx/statuses/ab5f317f7f3640847ba62dbdbf5f6a30a8b3dcb9","head":{"label":"shibukawa:feature/extension-blacklist","ref":"feature/extension-blacklist","sha":"ab5f317f7f3640847ba62dbdbf5f6a30a8b3dcb9","user":{"login":"shibukawa","id":564612,"avatar_url":"https://avatars.githubusercontent.com/u/564612?v=3","gravatar_id":"","url":"https://api.github.com/users/shibukawa","html_url":"https://github.com/shibukawa","followers_url":"https://api.github.com/users/shibukawa/followers","following_url":"https://api.github.com/users/shibukawa/following{/other_user}","gists_url":"https://api.github.com/users/shibukawa/gists{/gist_id}","starred_url":"https://api.github.com/users/shibukawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shibukawa/subscriptions","organizations_url":"https://api.github.com/users/shibukawa/orgs","repos_url":"https://api.github.com/users/shibukawa/repos","events_url":"https://api.github.com/users/shibukawa/events{/privacy}","received_events_url":"https://api.github.com/users/shibukawa/received_events","type":"User","site_admin":false},"repo":{"id":54108672,"name":"sphinx","full_name":"shibukawa/sphinx","owner":{"login":"shibukawa","id":564612,"avatar_url":"https://avatars.githubusercontent.com/u/564612?v=3","gravatar_id":"","url":"https://api.github.com/users/shibukawa","html_url":"https://github.com/shibukawa","followers_url":"https://api.github.com/users/shibukawa/followers","following_url":"https://api.github.com/users/shibukawa/following{/other_user}","gists_url":"https://api.github.com/users/shibukawa/gists{/gist_id}","starred_url":"https://api.github.com/users/shibukawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shibukawa/subscriptions","organizations_url":"https://api.github.com/users/shibukawa/orgs","repos_url":"https://api.github.com/users/shibukawa/repos","events_url":"https://api.github.com/users/shibukawa/events{/privacy}","received_events_url":"https://api.github.com/users/shibukawa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shibukawa/sphinx","description":"Main repository for the Sphinx documentation builder","fork":true,"url":"https://api.github.com/repos/shibukawa/sphinx","forks_url":"https://api.github.com/repos/shibukawa/sphinx/forks","keys_url":"https://api.github.com/repos/shibukawa/sphinx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shibukawa/sphinx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shibukawa/sphinx/teams","hooks_url":"https://api.github.com/repos/shibukawa/sphinx/hooks","issue_events_url":"https://api.github.com/repos/shibukawa/sphinx/issues/events{/number}","events_url":"https://api.github.com/repos/shibukawa/sphinx/events","assignees_url":"https://api.github.com/repos/shibukawa/sphinx/assignees{/user}","branches_url":"https://api.github.com/repos/shibukawa/sphinx/branches{/branch}","tags_url":"https://api.github.com/repos/shibukawa/sphinx/tags","blobs_url":"https://api.github.com/repos/shibukawa/sphinx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shibukawa/sphinx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shibukawa/sphinx/git/refs{/sha}","trees_url":"https://api.github.com/repos/shibukawa/sphinx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shibukawa/sphinx/statuses/{sha}","languages_url":"https://api.github.com/repos/shibukawa/sphinx/languages","stargazers_url":"https://api.github.com/repos/shibukawa/sphinx/stargazers","contributors_url":"https://api.github.com/repos/shibukawa/sphinx/contributors","subscribers_url":"https://api.github.com/repos/shibukawa/sphinx/subscribers","subscription_url":"https://api.github.com/repos/shibukawa/sphinx/subscription","commits_url":"https://api.github.com/repos/shibukawa/sphinx/commits{/sha}","git_commits_url":"https://api.github.com/repos/shibukawa/sphinx/git/commits{/sha}","comments_url":"https://api.github.com/repos/shibukawa/sphinx/comments{/number}","issue_comment_url":"https://api.github.com/repos/shibukawa/sphinx/issues/comments{/number}","contents_url":"https://api.github.com/repos/shibukawa/sphinx/contents/{+path}","compare_url":"https://api.github.com/repos/shibukawa/sphinx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shibukawa/sphinx/merges","archive_url":"https://api.github.com/repos/shibukawa/sphinx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shibukawa/sphinx/downloads","issues_url":"https://api.github.com/repos/shibukawa/sphinx/issues{/number}","pulls_url":"https://api.github.com/repos/shibukawa/sphinx/pulls{/number}","milestones_url":"https://api.github.com/repos/shibukawa/sphinx/milestones{/number}","notifications_url":"https://api.github.com/repos/shibukawa/sphinx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shibukawa/sphinx/labels{/name}","releases_url":"https://api.github.com/repos/shibukawa/sphinx/releases{/id}","deployments_url":"https://api.github.com/repos/shibukawa/sphinx/deployments","created_at":"2016-03-17T10:19:03Z","updated_at":"2016-03-17T10:19:05Z","pushed_at":"2016-06-01T06:44:22Z","git_url":"git://github.com/shibukawa/sphinx.git","ssh_url":"git@github.com:shibukawa/sphinx.git","clone_url":"https://github.com/shibukawa/sphinx.git","svn_url":"https://github.com/shibukawa/sphinx","homepage":"http://sphinx-doc.org","size":15304,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sphinx-doc:master","ref":"master","sha":"dbdfc640c7c6647f34369efc90782f8eb86da76a","user":{"login":"sphinx-doc","id":9928167,"avatar_url":"https://avatars.githubusercontent.com/u/9928167?v=3","gravatar_id":"","url":"https://api.github.com/users/sphinx-doc","html_url":"https://github.com/sphinx-doc","followers_url":"https://api.github.com/users/sphinx-doc/followers","following_url":"https://api.github.com/users/sphinx-doc/following{/other_user}","gists_url":"https://api.github.com/users/sphinx-doc/gists{/gist_id}","starred_url":"https://api.github.com/users/sphinx-doc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphinx-doc/subscriptions","organizations_url":"https://api.github.com/users/sphinx-doc/orgs","repos_url":"https://api.github.com/users/sphinx-doc/repos","events_url":"https://api.github.com/users/sphinx-doc/events{/privacy}","received_events_url":"https://api.github.com/users/sphinx-doc/received_events","type":"Organization","site_admin":false},"repo":{"id":28710753,"name":"sphinx","full_name":"sphinx-doc/sphinx","owner":{"login":"sphinx-doc","id":9928167,"avatar_url":"https://avatars.githubusercontent.com/u/9928167?v=3","gravatar_id":"","url":"https://api.github.com/users/sphinx-doc","html_url":"https://github.com/sphinx-doc","followers_url":"https://api.github.com/users/sphinx-doc/followers","following_url":"https://api.github.com/users/sphinx-doc/following{/other_user}","gists_url":"https://api.github.com/users/sphinx-doc/gists{/gist_id}","starred_url":"https://api.github.com/users/sphinx-doc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphinx-doc/subscriptions","organizations_url":"https://api.github.com/users/sphinx-doc/orgs","repos_url":"https://api.github.com/users/sphinx-doc/repos","events_url":"https://api.github.com/users/sphinx-doc/events{/privacy}","received_events_url":"https://api.github.com/users/sphinx-doc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sphinx-doc/sphinx","description":"Main repository for the Sphinx documentation builder","fork":false,"url":"https://api.github.com/repos/sphinx-doc/sphinx","forks_url":"https://api.github.com/repos/sphinx-doc/sphinx/forks","keys_url":"https://api.github.com/repos/sphinx-doc/sphinx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sphinx-doc/sphinx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sphinx-doc/sphinx/teams","hooks_url":"https://api.github.com/repos/sphinx-doc/sphinx/hooks","issue_events_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/events{/number}","events_url":"https://api.github.com/repos/sphinx-doc/sphinx/events","assignees_url":"https://api.github.com/repos/sphinx-doc/sphinx/assignees{/user}","branches_url":"https://api.github.com/repos/sphinx-doc/sphinx/branches{/branch}","tags_url":"https://api.github.com/repos/sphinx-doc/sphinx/tags","blobs_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/refs{/sha}","trees_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sphinx-doc/sphinx/statuses/{sha}","languages_url":"https://api.github.com/repos/sphinx-doc/sphinx/languages","stargazers_url":"https://api.github.com/repos/sphinx-doc/sphinx/stargazers","contributors_url":"https://api.github.com/repos/sphinx-doc/sphinx/contributors","subscribers_url":"https://api.github.com/repos/sphinx-doc/sphinx/subscribers","subscription_url":"https://api.github.com/repos/sphinx-doc/sphinx/subscription","commits_url":"https://api.github.com/repos/sphinx-doc/sphinx/commits{/sha}","git_commits_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/commits{/sha}","comments_url":"https://api.github.com/repos/sphinx-doc/sphinx/comments{/number}","issue_comment_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/comments{/number}","contents_url":"https://api.github.com/repos/sphinx-doc/sphinx/contents/{+path}","compare_url":"https://api.github.com/repos/sphinx-doc/sphinx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sphinx-doc/sphinx/merges","archive_url":"https://api.github.com/repos/sphinx-doc/sphinx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sphinx-doc/sphinx/downloads","issues_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues{/number}","pulls_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls{/number}","milestones_url":"https://api.github.com/repos/sphinx-doc/sphinx/milestones{/number}","notifications_url":"https://api.github.com/repos/sphinx-doc/sphinx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sphinx-doc/sphinx/labels{/name}","releases_url":"https://api.github.com/repos/sphinx-doc/sphinx/releases{/id}","deployments_url":"https://api.github.com/repos/sphinx-doc/sphinx/deployments","created_at":"2015-01-02T10:53:28Z","updated_at":"2016-05-31T13:24:35Z","pushed_at":"2016-06-01T06:44:22Z","git_url":"git://github.com/sphinx-doc/sphinx.git","ssh_url":"git@github.com:sphinx-doc/sphinx.git","clone_url":"https://github.com/sphinx-doc/sphinx.git","svn_url":"https://github.com/sphinx-doc/sphinx","homepage":"http://sphinx-doc.org","size":21372,"stargazers_count":670,"watchers_count":670,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":328,"mirror_url":null,"open_issues_count":546,"forks":328,"open_issues":546,"watchers":670,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/2608"},"html":{"href":"https://github.com/sphinx-doc/sphinx/pull/2608"},"issue":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/issues/2608"},"comments":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/issues/2608/comments"},"review_comments":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/2608/comments"},"review_comment":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/2608/commits"},"statuses":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/statuses/ab5f317f7f3640847ba62dbdbf5f6a30a8b3dcb9"}}}}
{"actor":{"display_login":"tk0miya"}}