{"action":"created","comment":{"url":"https://api.github.com/repos/gonetz/GLideN64/pulls/comments/82966244","pull_request_review_id":3835740,"id":82966244,"diff_hunk":"@@ -361,24 +358,32 @@ ShaderCombiner::ShaderCombiner(Combiner & _color, Combiner & _alpha, const gDPCo\n \t\tif (usesTile(0)) {\n \t\t\tif (config.video.multisampling > 0) {\n \t\t\t\tstrFragmentShader.append(\"  lowp vec4 readtex0; \\n\");\n-\t\t\t\tstrFragmentShader.append(\"  if (uMSTexEnabled[0] == 0) readtex0 = readTex(uTex0, vTexCoord0, uFbMonochrome[0], uFbFixedAlpha[0]); \\n\");\n+\t\t\t\tstrFragmentShader.append(\"  if (uMSTexEnabled[0] == 0) READ_TEX(readtex0, uTex0, vTexCoord0, uFbMonochrome[0], uFbFixedAlpha[0]) \\n\");\n \t\t\t\tstrFragmentShader.append(\"  else readtex0 = readTexMS(uMSTex0, vTexCoord0, uFbMonochrome[0], uFbFixedAlpha[0]); \\n\");","path":"src/OGL3X/GLSLCombiner_ogl3x.cpp","position":41,"original_position":41,"commit_id":"6dbc700045809507971bee72e24adff34f702dff","original_commit_id":"6dbc700045809507971bee72e24adff34f702dff","user":{"login":"gonetz","id":8983092,"avatar_url":"https://avatars.githubusercontent.com/u/8983092?v=3","gravatar_id":"","url":"https://api.github.com/users/gonetz","html_url":"https://github.com/gonetz","followers_url":"https://api.github.com/users/gonetz/followers","following_url":"https://api.github.com/users/gonetz/following{/other_user}","gists_url":"https://api.github.com/users/gonetz/gists{/gist_id}","starred_url":"https://api.github.com/users/gonetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonetz/subscriptions","organizations_url":"https://api.github.com/users/gonetz/orgs","repos_url":"https://api.github.com/users/gonetz/repos","events_url":"https://api.github.com/users/gonetz/events{/privacy}","received_events_url":"https://api.github.com/users/gonetz/received_events","type":"User","site_admin":false},"body":"Why you did not change readTexMS the same way? It also uses sampler as input.","created_at":"2016-10-12T09:19:35Z","updated_at":"2016-10-12T09:19:35Z","html_url":"https://github.com/gonetz/GLideN64/pull/1166#discussion_r82966244","pull_request_url":"https://api.github.com/repos/gonetz/GLideN64/pulls/1166","_links":{"self":{"href":"https://api.github.com/repos/gonetz/GLideN64/pulls/comments/82966244"},"html":{"href":"https://github.com/gonetz/GLideN64/pull/1166#discussion_r82966244"},"pull_request":{"href":"https://api.github.com/repos/gonetz/GLideN64/pulls/1166"}}},"pull_request":{"url":"https://api.github.com/repos/gonetz/GLideN64/pulls/1166","id":88609507,"html_url":"https://github.com/gonetz/GLideN64/pull/1166","diff_url":"https://github.com/gonetz/GLideN64/pull/1166.diff","patch_url":"https://github.com/gonetz/GLideN64/pull/1166.patch","issue_url":"https://api.github.com/repos/gonetz/GLideN64/issues/1166","number":1166,"state":"open","locked":false,"title":"Fixes GLES 3.1 in Adreno devices","user":{"login":"fzurita","id":11581687,"avatar_url":"https://avatars.githubusercontent.com/u/11581687?v=3","gravatar_id":"","url":"https://api.github.com/users/fzurita","html_url":"https://github.com/fzurita","followers_url":"https://api.github.com/users/fzurita/followers","following_url":"https://api.github.com/users/fzurita/following{/other_user}","gists_url":"https://api.github.com/users/fzurita/gists{/gist_id}","starred_url":"https://api.github.com/users/fzurita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fzurita/subscriptions","organizations_url":"https://api.github.com/users/fzurita/orgs","repos_url":"https://api.github.com/users/fzurita/repos","events_url":"https://api.github.com/users/fzurita/events{/privacy}","received_events_url":"https://api.github.com/users/fzurita/received_events","type":"User","site_admin":false},"body":"See https://github.com/gonetz/GLideN64/issues/895\r\n\r\nI fixed this issue with this one specific driver by making any function (just readTex) that uses Sampler2D as argument into a macro instead.\r\n\r\nFor some reason the Adreno drivers don't like Sampler2D as an argument type. Using a macro forces the inlining of the code during pre-processing.\r\n\r\nTested in the following devices:\r\nNvidia Shield TV (Tegra X1) in Full GL and GLES 3.1 modes\r\nNexus Player (PowerVR)\r\nSamsung Galaxy S6 Active (Mali)\r\nZTE Axon 7 (Adreno)","created_at":"2016-10-10T04:36:12Z","updated_at":"2016-10-12T09:19:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd25de7c06788aa185122aa81abeed7f9c864bff","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gonetz/GLideN64/pulls/1166/commits","review_comments_url":"https://api.github.com/repos/gonetz/GLideN64/pulls/1166/comments","review_comment_url":"https://api.github.com/repos/gonetz/GLideN64/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gonetz/GLideN64/issues/1166/comments","statuses_url":"https://api.github.com/repos/gonetz/GLideN64/statuses/6dbc700045809507971bee72e24adff34f702dff","head":{"label":"fzurita:fix_adreno_gles31","ref":"fix_adreno_gles31","sha":"6dbc700045809507971bee72e24adff34f702dff","user":{"login":"fzurita","id":11581687,"avatar_url":"https://avatars.githubusercontent.com/u/11581687?v=3","gravatar_id":"","url":"https://api.github.com/users/fzurita","html_url":"https://github.com/fzurita","followers_url":"https://api.github.com/users/fzurita/followers","following_url":"https://api.github.com/users/fzurita/following{/other_user}","gists_url":"https://api.github.com/users/fzurita/gists{/gist_id}","starred_url":"https://api.github.com/users/fzurita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fzurita/subscriptions","organizations_url":"https://api.github.com/users/fzurita/orgs","repos_url":"https://api.github.com/users/fzurita/repos","events_url":"https://api.github.com/users/fzurita/events{/privacy}","received_events_url":"https://api.github.com/users/fzurita/received_events","type":"User","site_admin":false},"repo":{"id":39207234,"name":"GLideN64","full_name":"fzurita/GLideN64","owner":{"login":"fzurita","id":11581687,"avatar_url":"https://avatars.githubusercontent.com/u/11581687?v=3","gravatar_id":"","url":"https://api.github.com/users/fzurita","html_url":"https://github.com/fzurita","followers_url":"https://api.github.com/users/fzurita/followers","following_url":"https://api.github.com/users/fzurita/following{/other_user}","gists_url":"https://api.github.com/users/fzurita/gists{/gist_id}","starred_url":"https://api.github.com/users/fzurita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fzurita/subscriptions","organizations_url":"https://api.github.com/users/fzurita/orgs","repos_url":"https://api.github.com/users/fzurita/repos","events_url":"https://api.github.com/users/fzurita/events{/privacy}","received_events_url":"https://api.github.com/users/fzurita/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fzurita/GLideN64","description":"A new generation, open-source graphics plugin for N64 emulators.","fork":true,"url":"https://api.github.com/repos/fzurita/GLideN64","forks_url":"https://api.github.com/repos/fzurita/GLideN64/forks","keys_url":"https://api.github.com/repos/fzurita/GLideN64/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fzurita/GLideN64/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fzurita/GLideN64/teams","hooks_url":"https://api.github.com/repos/fzurita/GLideN64/hooks","issue_events_url":"https://api.github.com/repos/fzurita/GLideN64/issues/events{/number}","events_url":"https://api.github.com/repos/fzurita/GLideN64/events","assignees_url":"https://api.github.com/repos/fzurita/GLideN64/assignees{/user}","branches_url":"https://api.github.com/repos/fzurita/GLideN64/branches{/branch}","tags_url":"https://api.github.com/repos/fzurita/GLideN64/tags","blobs_url":"https://api.github.com/repos/fzurita/GLideN64/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fzurita/GLideN64/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fzurita/GLideN64/git/refs{/sha}","trees_url":"https://api.github.com/repos/fzurita/GLideN64/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fzurita/GLideN64/statuses/{sha}","languages_url":"https://api.github.com/repos/fzurita/GLideN64/languages","stargazers_url":"https://api.github.com/repos/fzurita/GLideN64/stargazers","contributors_url":"https://api.github.com/repos/fzurita/GLideN64/contributors","subscribers_url":"https://api.github.com/repos/fzurita/GLideN64/subscribers","subscription_url":"https://api.github.com/repos/fzurita/GLideN64/subscription","commits_url":"https://api.github.com/repos/fzurita/GLideN64/commits{/sha}","git_commits_url":"https://api.github.com/repos/fzurita/GLideN64/git/commits{/sha}","comments_url":"https://api.github.com/repos/fzurita/GLideN64/comments{/number}","issue_comment_url":"https://api.github.com/repos/fzurita/GLideN64/issues/comments{/number}","contents_url":"https://api.github.com/repos/fzurita/GLideN64/contents/{+path}","compare_url":"https://api.github.com/repos/fzurita/GLideN64/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fzurita/GLideN64/merges","archive_url":"https://api.github.com/repos/fzurita/GLideN64/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fzurita/GLideN64/downloads","issues_url":"https://api.github.com/repos/fzurita/GLideN64/issues{/number}","pulls_url":"https://api.github.com/repos/fzurita/GLideN64/pulls{/number}","milestones_url":"https://api.github.com/repos/fzurita/GLideN64/milestones{/number}","notifications_url":"https://api.github.com/repos/fzurita/GLideN64/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fzurita/GLideN64/labels{/name}","releases_url":"https://api.github.com/repos/fzurita/GLideN64/releases{/id}","deployments_url":"https://api.github.com/repos/fzurita/GLideN64/deployments","created_at":"2015-07-16T16:09:40Z","updated_at":"2016-03-10T05:23:28Z","pushed_at":"2016-10-10T05:04:02Z","git_url":"git://github.com/fzurita/GLideN64.git","ssh_url":"git@github.com:fzurita/GLideN64.git","clone_url":"https://github.com/fzurita/GLideN64.git","svn_url":"https://github.com/fzurita/GLideN64","homepage":null,"size":5593,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gonetz:master","ref":"master","sha":"b03e547b8ce11048667432b6b2199e24c86b7ff3","user":{"login":"gonetz","id":8983092,"avatar_url":"https://avatars.githubusercontent.com/u/8983092?v=3","gravatar_id":"","url":"https://api.github.com/users/gonetz","html_url":"https://github.com/gonetz","followers_url":"https://api.github.com/users/gonetz/followers","following_url":"https://api.github.com/users/gonetz/following{/other_user}","gists_url":"https://api.github.com/users/gonetz/gists{/gist_id}","starred_url":"https://api.github.com/users/gonetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonetz/subscriptions","organizations_url":"https://api.github.com/users/gonetz/orgs","repos_url":"https://api.github.com/users/gonetz/repos","events_url":"https://api.github.com/users/gonetz/events{/privacy}","received_events_url":"https://api.github.com/users/gonetz/received_events","type":"User","site_admin":false},"repo":{"id":24674411,"name":"GLideN64","full_name":"gonetz/GLideN64","owner":{"login":"gonetz","id":8983092,"avatar_url":"https://avatars.githubusercontent.com/u/8983092?v=3","gravatar_id":"","url":"https://api.github.com/users/gonetz","html_url":"https://github.com/gonetz","followers_url":"https://api.github.com/users/gonetz/followers","following_url":"https://api.github.com/users/gonetz/following{/other_user}","gists_url":"https://api.github.com/users/gonetz/gists{/gist_id}","starred_url":"https://api.github.com/users/gonetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonetz/subscriptions","organizations_url":"https://api.github.com/users/gonetz/orgs","repos_url":"https://api.github.com/users/gonetz/repos","events_url":"https://api.github.com/users/gonetz/events{/privacy}","received_events_url":"https://api.github.com/users/gonetz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gonetz/GLideN64","description":"A new generation, open-source graphics plugin for N64 emulators.","fork":false,"url":"https://api.github.com/repos/gonetz/GLideN64","forks_url":"https://api.github.com/repos/gonetz/GLideN64/forks","keys_url":"https://api.github.com/repos/gonetz/GLideN64/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gonetz/GLideN64/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gonetz/GLideN64/teams","hooks_url":"https://api.github.com/repos/gonetz/GLideN64/hooks","issue_events_url":"https://api.github.com/repos/gonetz/GLideN64/issues/events{/number}","events_url":"https://api.github.com/repos/gonetz/GLideN64/events","assignees_url":"https://api.github.com/repos/gonetz/GLideN64/assignees{/user}","branches_url":"https://api.github.com/repos/gonetz/GLideN64/branches{/branch}","tags_url":"https://api.github.com/repos/gonetz/GLideN64/tags","blobs_url":"https://api.github.com/repos/gonetz/GLideN64/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gonetz/GLideN64/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gonetz/GLideN64/git/refs{/sha}","trees_url":"https://api.github.com/repos/gonetz/GLideN64/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gonetz/GLideN64/statuses/{sha}","languages_url":"https://api.github.com/repos/gonetz/GLideN64/languages","stargazers_url":"https://api.github.com/repos/gonetz/GLideN64/stargazers","contributors_url":"https://api.github.com/repos/gonetz/GLideN64/contributors","subscribers_url":"https://api.github.com/repos/gonetz/GLideN64/subscribers","subscription_url":"https://api.github.com/repos/gonetz/GLideN64/subscription","commits_url":"https://api.github.com/repos/gonetz/GLideN64/commits{/sha}","git_commits_url":"https://api.github.com/repos/gonetz/GLideN64/git/commits{/sha}","comments_url":"https://api.github.com/repos/gonetz/GLideN64/comments{/number}","issue_comment_url":"https://api.github.com/repos/gonetz/GLideN64/issues/comments{/number}","contents_url":"https://api.github.com/repos/gonetz/GLideN64/contents/{+path}","compare_url":"https://api.github.com/repos/gonetz/GLideN64/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gonetz/GLideN64/merges","archive_url":"https://api.github.com/repos/gonetz/GLideN64/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gonetz/GLideN64/downloads","issues_url":"https://api.github.com/repos/gonetz/GLideN64/issues{/number}","pulls_url":"https://api.github.com/repos/gonetz/GLideN64/pulls{/number}","milestones_url":"https://api.github.com/repos/gonetz/GLideN64/milestones{/number}","notifications_url":"https://api.github.com/repos/gonetz/GLideN64/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gonetz/GLideN64/labels{/name}","releases_url":"https://api.github.com/repos/gonetz/GLideN64/releases{/id}","deployments_url":"https://api.github.com/repos/gonetz/GLideN64/deployments","created_at":"2014-10-01T10:31:41Z","updated_at":"2016-10-12T05:30:53Z","pushed_at":"2016-10-11T11:45:20Z","git_url":"git://github.com/gonetz/GLideN64.git","ssh_url":"git@github.com:gonetz/GLideN64.git","clone_url":"https://github.com/gonetz/GLideN64.git","svn_url":"https://github.com/gonetz/GLideN64","homepage":null,"size":6781,"stargazers_count":140,"watchers_count":140,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":229,"forks":48,"open_issues":229,"watchers":140,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gonetz/GLideN64/pulls/1166"},"html":{"href":"https://github.com/gonetz/GLideN64/pull/1166"},"issue":{"href":"https://api.github.com/repos/gonetz/GLideN64/issues/1166"},"comments":{"href":"https://api.github.com/repos/gonetz/GLideN64/issues/1166/comments"},"review_comments":{"href":"https://api.github.com/repos/gonetz/GLideN64/pulls/1166/comments"},"review_comment":{"href":"https://api.github.com/repos/gonetz/GLideN64/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gonetz/GLideN64/pulls/1166/commits"},"statuses":{"href":"https://api.github.com/repos/gonetz/GLideN64/statuses/6dbc700045809507971bee72e24adff34f702dff"}}}}
{"actor":{"display_login":"gonetz"}}