{"action":"created","comment":{"url":"https://api.github.com/repos/HubSpot/tether/pulls/comments/64285881","id":64285881,"diff_hunk":"@@ -1177,11 +1177,14 @@ var TetherClass = (function (_Evented) {\n         }\n       };\n \n+      var hasOptimizations = typeof this.options.optimizations !== 'undefined';\n+      var positionFixed = hasOptimizations ? this.options.optimizations.positionFixed : true;\n+\n       var moved = false;\n       if ((same.page.top || same.page.bottom) && (same.page.left || same.page.right)) {\n         css.position = 'absolute';\n         transcribe(same.page, pos.page);\n-      } else if ((same.viewport.top || same.viewport.bottom) && (same.viewport.left || same.viewport.right)) {\n+      } else if (positionFixed && (same.viewport.top || same.viewport.bottom) && (same.viewport.left || same.viewport.right)) {","path":"dist/js/tether.js","position":12,"original_position":12,"commit_id":"ebe4f93d9df56f0cfe06c77591da3425d88e9531","original_commit_id":"ebe4f93d9df56f0cfe06c77591da3425d88e9531","user":{"login":"zackbloom","id":55347,"avatar_url":"https://avatars.githubusercontent.com/u/55347?v=3","gravatar_id":"","url":"https://api.github.com/users/zackbloom","html_url":"https://github.com/zackbloom","followers_url":"https://api.github.com/users/zackbloom/followers","following_url":"https://api.github.com/users/zackbloom/following{/other_user}","gists_url":"https://api.github.com/users/zackbloom/gists{/gist_id}","starred_url":"https://api.github.com/users/zackbloom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zackbloom/subscriptions","organizations_url":"https://api.github.com/users/zackbloom/orgs","repos_url":"https://api.github.com/users/zackbloom/repos","events_url":"https://api.github.com/users/zackbloom/events{/privacy}","received_events_url":"https://api.github.com/users/zackbloom/received_events","type":"User","site_admin":false},"body":"I think the `positionFixed` var should be called `allowPositionFixed`, as it doesn't force position fixed, just makes it available. ","created_at":"2016-05-23T20:47:23Z","updated_at":"2016-05-23T20:47:23Z","html_url":"https://github.com/HubSpot/tether/pull/180#discussion_r64285881","pull_request_url":"https://api.github.com/repos/HubSpot/tether/pulls/180","_links":{"self":{"href":"https://api.github.com/repos/HubSpot/tether/pulls/comments/64285881"},"html":{"href":"https://github.com/HubSpot/tether/pull/180#discussion_r64285881"},"pull_request":{"href":"https://api.github.com/repos/HubSpot/tether/pulls/180"}}},"pull_request":{"url":"https://api.github.com/repos/HubSpot/tether/pulls/180","id":71116465,"html_url":"https://github.com/HubSpot/tether/pull/180","diff_url":"https://github.com/HubSpot/tether/pull/180.diff","patch_url":"https://github.com/HubSpot/tether/pull/180.patch","issue_url":"https://api.github.com/repos/HubSpot/tether/issues/180","number":180,"state":"open","locked":false,"title":"Introduce `positionFixed` optimization","user":{"login":"krasnoukhov","id":944286,"avatar_url":"https://avatars.githubusercontent.com/u/944286?v=3","gravatar_id":"","url":"https://api.github.com/users/krasnoukhov","html_url":"https://github.com/krasnoukhov","followers_url":"https://api.github.com/users/krasnoukhov/followers","following_url":"https://api.github.com/users/krasnoukhov/following{/other_user}","gists_url":"https://api.github.com/users/krasnoukhov/gists{/gist_id}","starred_url":"https://api.github.com/users/krasnoukhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krasnoukhov/subscriptions","organizations_url":"https://api.github.com/users/krasnoukhov/orgs","repos_url":"https://api.github.com/users/krasnoukhov/repos","events_url":"https://api.github.com/users/krasnoukhov/events{/privacy}","received_events_url":"https://api.github.com/users/krasnoukhov/received_events","type":"User","site_admin":false},"body":"Fixes #152\r\n\r\nI'm not sure if I should adjust the documentation accordingly, so any suggestions are welcome. Thanks!","created_at":"2016-05-23T20:36:33Z","updated_at":"2016-05-23T20:47:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71f9fb071afc32c64e5616196fc54d5be68ebf1e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HubSpot/tether/pulls/180/commits","review_comments_url":"https://api.github.com/repos/HubSpot/tether/pulls/180/comments","review_comment_url":"https://api.github.com/repos/HubSpot/tether/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HubSpot/tether/issues/180/comments","statuses_url":"https://api.github.com/repos/HubSpot/tether/statuses/ebe4f93d9df56f0cfe06c77591da3425d88e9531","head":{"label":"simplepractice:position-fixed","ref":"position-fixed","sha":"ebe4f93d9df56f0cfe06c77591da3425d88e9531","user":{"login":"simplepractice","id":1134456,"avatar_url":"https://avatars.githubusercontent.com/u/1134456?v=3","gravatar_id":"","url":"https://api.github.com/users/simplepractice","html_url":"https://github.com/simplepractice","followers_url":"https://api.github.com/users/simplepractice/followers","following_url":"https://api.github.com/users/simplepractice/following{/other_user}","gists_url":"https://api.github.com/users/simplepractice/gists{/gist_id}","starred_url":"https://api.github.com/users/simplepractice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplepractice/subscriptions","organizations_url":"https://api.github.com/users/simplepractice/orgs","repos_url":"https://api.github.com/users/simplepractice/repos","events_url":"https://api.github.com/users/simplepractice/events{/privacy}","received_events_url":"https://api.github.com/users/simplepractice/received_events","type":"Organization","site_admin":false},"repo":{"id":52974503,"name":"tether","full_name":"simplepractice/tether","owner":{"login":"simplepractice","id":1134456,"avatar_url":"https://avatars.githubusercontent.com/u/1134456?v=3","gravatar_id":"","url":"https://api.github.com/users/simplepractice","html_url":"https://github.com/simplepractice","followers_url":"https://api.github.com/users/simplepractice/followers","following_url":"https://api.github.com/users/simplepractice/following{/other_user}","gists_url":"https://api.github.com/users/simplepractice/gists{/gist_id}","starred_url":"https://api.github.com/users/simplepractice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplepractice/subscriptions","organizations_url":"https://api.github.com/users/simplepractice/orgs","repos_url":"https://api.github.com/users/simplepractice/repos","events_url":"https://api.github.com/users/simplepractice/events{/privacy}","received_events_url":"https://api.github.com/users/simplepractice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simplepractice/tether","description":" A positioning engine to make overlays, tooltips and dropdowns better #hubspot-open-source","fork":true,"url":"https://api.github.com/repos/simplepractice/tether","forks_url":"https://api.github.com/repos/simplepractice/tether/forks","keys_url":"https://api.github.com/repos/simplepractice/tether/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simplepractice/tether/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simplepractice/tether/teams","hooks_url":"https://api.github.com/repos/simplepractice/tether/hooks","issue_events_url":"https://api.github.com/repos/simplepractice/tether/issues/events{/number}","events_url":"https://api.github.com/repos/simplepractice/tether/events","assignees_url":"https://api.github.com/repos/simplepractice/tether/assignees{/user}","branches_url":"https://api.github.com/repos/simplepractice/tether/branches{/branch}","tags_url":"https://api.github.com/repos/simplepractice/tether/tags","blobs_url":"https://api.github.com/repos/simplepractice/tether/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simplepractice/tether/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simplepractice/tether/git/refs{/sha}","trees_url":"https://api.github.com/repos/simplepractice/tether/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simplepractice/tether/statuses/{sha}","languages_url":"https://api.github.com/repos/simplepractice/tether/languages","stargazers_url":"https://api.github.com/repos/simplepractice/tether/stargazers","contributors_url":"https://api.github.com/repos/simplepractice/tether/contributors","subscribers_url":"https://api.github.com/repos/simplepractice/tether/subscribers","subscription_url":"https://api.github.com/repos/simplepractice/tether/subscription","commits_url":"https://api.github.com/repos/simplepractice/tether/commits{/sha}","git_commits_url":"https://api.github.com/repos/simplepractice/tether/git/commits{/sha}","comments_url":"https://api.github.com/repos/simplepractice/tether/comments{/number}","issue_comment_url":"https://api.github.com/repos/simplepractice/tether/issues/comments{/number}","contents_url":"https://api.github.com/repos/simplepractice/tether/contents/{+path}","compare_url":"https://api.github.com/repos/simplepractice/tether/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simplepractice/tether/merges","archive_url":"https://api.github.com/repos/simplepractice/tether/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simplepractice/tether/downloads","issues_url":"https://api.github.com/repos/simplepractice/tether/issues{/number}","pulls_url":"https://api.github.com/repos/simplepractice/tether/pulls{/number}","milestones_url":"https://api.github.com/repos/simplepractice/tether/milestones{/number}","notifications_url":"https://api.github.com/repos/simplepractice/tether/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simplepractice/tether/labels{/name}","releases_url":"https://api.github.com/repos/simplepractice/tether/releases{/id}","deployments_url":"https://api.github.com/repos/simplepractice/tether/deployments","created_at":"2016-03-02T15:38:43Z","updated_at":"2016-03-02T15:38:44Z","pushed_at":"2016-05-23T20:33:53Z","git_url":"git://github.com/simplepractice/tether.git","ssh_url":"git@github.com:simplepractice/tether.git","clone_url":"https://github.com/simplepractice/tether.git","svn_url":"https://github.com/simplepractice/tether","homepage":"http://tether.io/docs/welcome","size":1897,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HubSpot:master","ref":"master","sha":"7151ff59c6090ea4e3e50ef0355aaf7e553b7fa9","user":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"repo":{"id":13597334,"name":"tether","full_name":"HubSpot/tether","owner":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HubSpot/tether","description":" A positioning engine to make overlays, tooltips and dropdowns better #hubspot-open-source","fork":false,"url":"https://api.github.com/repos/HubSpot/tether","forks_url":"https://api.github.com/repos/HubSpot/tether/forks","keys_url":"https://api.github.com/repos/HubSpot/tether/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HubSpot/tether/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HubSpot/tether/teams","hooks_url":"https://api.github.com/repos/HubSpot/tether/hooks","issue_events_url":"https://api.github.com/repos/HubSpot/tether/issues/events{/number}","events_url":"https://api.github.com/repos/HubSpot/tether/events","assignees_url":"https://api.github.com/repos/HubSpot/tether/assignees{/user}","branches_url":"https://api.github.com/repos/HubSpot/tether/branches{/branch}","tags_url":"https://api.github.com/repos/HubSpot/tether/tags","blobs_url":"https://api.github.com/repos/HubSpot/tether/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HubSpot/tether/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HubSpot/tether/git/refs{/sha}","trees_url":"https://api.github.com/repos/HubSpot/tether/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HubSpot/tether/statuses/{sha}","languages_url":"https://api.github.com/repos/HubSpot/tether/languages","stargazers_url":"https://api.github.com/repos/HubSpot/tether/stargazers","contributors_url":"https://api.github.com/repos/HubSpot/tether/contributors","subscribers_url":"https://api.github.com/repos/HubSpot/tether/subscribers","subscription_url":"https://api.github.com/repos/HubSpot/tether/subscription","commits_url":"https://api.github.com/repos/HubSpot/tether/commits{/sha}","git_commits_url":"https://api.github.com/repos/HubSpot/tether/git/commits{/sha}","comments_url":"https://api.github.com/repos/HubSpot/tether/comments{/number}","issue_comment_url":"https://api.github.com/repos/HubSpot/tether/issues/comments{/number}","contents_url":"https://api.github.com/repos/HubSpot/tether/contents/{+path}","compare_url":"https://api.github.com/repos/HubSpot/tether/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HubSpot/tether/merges","archive_url":"https://api.github.com/repos/HubSpot/tether/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HubSpot/tether/downloads","issues_url":"https://api.github.com/repos/HubSpot/tether/issues{/number}","pulls_url":"https://api.github.com/repos/HubSpot/tether/pulls{/number}","milestones_url":"https://api.github.com/repos/HubSpot/tether/milestones{/number}","notifications_url":"https://api.github.com/repos/HubSpot/tether/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HubSpot/tether/labels{/name}","releases_url":"https://api.github.com/repos/HubSpot/tether/releases{/id}","deployments_url":"https://api.github.com/repos/HubSpot/tether/deployments","created_at":"2013-10-15T17:47:11Z","updated_at":"2016-05-23T19:55:48Z","pushed_at":"2016-05-23T20:36:33Z","git_url":"git://github.com/HubSpot/tether.git","ssh_url":"git@github.com:HubSpot/tether.git","clone_url":"https://github.com/HubSpot/tether.git","svn_url":"https://github.com/HubSpot/tether","homepage":"http://tether.io/docs/welcome","size":2259,"stargazers_count":5418,"watchers_count":5418,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":314,"mirror_url":null,"open_issues_count":43,"forks":314,"open_issues":43,"watchers":5418,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HubSpot/tether/pulls/180"},"html":{"href":"https://github.com/HubSpot/tether/pull/180"},"issue":{"href":"https://api.github.com/repos/HubSpot/tether/issues/180"},"comments":{"href":"https://api.github.com/repos/HubSpot/tether/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/HubSpot/tether/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/HubSpot/tether/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HubSpot/tether/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/HubSpot/tether/statuses/ebe4f93d9df56f0cfe06c77591da3425d88e9531"}}}}
{"actor":{"display_login":"zackbloom"}}