{"action":"closed","number":1764,"pull_request":{"url":"https://api.github.com/repos/youtube/vitess/pulls/1764","id":72762873,"html_url":"https://github.com/youtube/vitess/pull/1764","diff_url":"https://github.com/youtube/vitess/pull/1764.diff","patch_url":"https://github.com/youtube/vitess/pull/1764.patch","issue_url":"https://api.github.com/repos/youtube/vitess/issues/1764","number":1764,"state":"closed","locked":false,"title":"Fix for Issue:1731, drop table if exists may not result in schema change","user":{"login":"ashudeep-sharma","id":12492010,"avatar_url":"https://avatars.githubusercontent.com/u/12492010?v=3","gravatar_id":"","url":"https://api.github.com/users/ashudeep-sharma","html_url":"https://github.com/ashudeep-sharma","followers_url":"https://api.github.com/users/ashudeep-sharma/followers","following_url":"https://api.github.com/users/ashudeep-sharma/following{/other_user}","gists_url":"https://api.github.com/users/ashudeep-sharma/gists{/gist_id}","starred_url":"https://api.github.com/users/ashudeep-sharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashudeep-sharma/subscriptions","organizations_url":"https://api.github.com/users/ashudeep-sharma/orgs","repos_url":"https://api.github.com/users/ashudeep-sharma/repos","events_url":"https://api.github.com/users/ashudeep-sharma/events{/privacy}","received_events_url":"https://api.github.com/users/ashudeep-sharma/received_events","type":"User","site_admin":false},"body":"This Pull Request covers the fix for issue #1731, \r\nCertain Statements like drop table if exists may not result in a schema change. This fix validates if the schema diff is zero and the query is dropStr, it shouldn;t throw an error in ApplySchema. \r\n\r\n@michael-berlin , @alainjobart .Please check and let me know in case of any concerns.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/youtube/vitess/1764)\n<!-- Reviewable:end -->\n","created_at":"2016-06-06T19:22:32Z","updated_at":"2016-06-09T06:18:50Z","closed_at":"2016-06-09T06:18:50Z","merged_at":"2016-06-09T06:18:50Z","merge_commit_sha":"0a135028feee673fafb03d6383d2549b0071b190","assignee":{"login":"michael-berlin","id":3919251,"avatar_url":"https://avatars.githubusercontent.com/u/3919251?v=3","gravatar_id":"","url":"https://api.github.com/users/michael-berlin","html_url":"https://github.com/michael-berlin","followers_url":"https://api.github.com/users/michael-berlin/followers","following_url":"https://api.github.com/users/michael-berlin/following{/other_user}","gists_url":"https://api.github.com/users/michael-berlin/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-berlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-berlin/subscriptions","organizations_url":"https://api.github.com/users/michael-berlin/orgs","repos_url":"https://api.github.com/users/michael-berlin/repos","events_url":"https://api.github.com/users/michael-berlin/events{/privacy}","received_events_url":"https://api.github.com/users/michael-berlin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/youtube/vitess/pulls/1764/commits","review_comments_url":"https://api.github.com/repos/youtube/vitess/pulls/1764/comments","review_comment_url":"https://api.github.com/repos/youtube/vitess/pulls/comments{/number}","comments_url":"https://api.github.com/repos/youtube/vitess/issues/1764/comments","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/7907dc41ed0c72043eb7855196cf44f2b830ec6a","head":{"label":"youtube:vitess_issue_1731","ref":"vitess_issue_1731","sha":"7907dc41ed0c72043eb7855196cf44f2b830ec6a","user":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"repo":{"id":11008207,"name":"vitess","full_name":"youtube/vitess","owner":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/youtube/vitess","description":"vitess provides servers and tools which facilitate scaling of MySQL databases for large scale web services.","fork":false,"url":"https://api.github.com/repos/youtube/vitess","forks_url":"https://api.github.com/repos/youtube/vitess/forks","keys_url":"https://api.github.com/repos/youtube/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/youtube/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/youtube/vitess/teams","hooks_url":"https://api.github.com/repos/youtube/vitess/hooks","issue_events_url":"https://api.github.com/repos/youtube/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/youtube/vitess/events","assignees_url":"https://api.github.com/repos/youtube/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/youtube/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/youtube/vitess/tags","blobs_url":"https://api.github.com/repos/youtube/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/youtube/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/youtube/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/youtube/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/youtube/vitess/languages","stargazers_url":"https://api.github.com/repos/youtube/vitess/stargazers","contributors_url":"https://api.github.com/repos/youtube/vitess/contributors","subscribers_url":"https://api.github.com/repos/youtube/vitess/subscribers","subscription_url":"https://api.github.com/repos/youtube/vitess/subscription","commits_url":"https://api.github.com/repos/youtube/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/youtube/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/youtube/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/youtube/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/youtube/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/youtube/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/youtube/vitess/merges","archive_url":"https://api.github.com/repos/youtube/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/youtube/vitess/downloads","issues_url":"https://api.github.com/repos/youtube/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/youtube/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/youtube/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/youtube/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/youtube/vitess/labels{/name}","releases_url":"https://api.github.com/repos/youtube/vitess/releases{/id}","deployments_url":"https://api.github.com/repos/youtube/vitess/deployments","created_at":"2013-06-27T21:20:28Z","updated_at":"2016-06-09T05:23:02Z","pushed_at":"2016-06-09T06:18:50Z","git_url":"git://github.com/youtube/vitess.git","ssh_url":"git@github.com:youtube/vitess.git","clone_url":"https://github.com/youtube/vitess.git","svn_url":"https://github.com/youtube/vitess","homepage":null,"size":88197,"stargazers_count":3511,"watchers_count":3511,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":452,"mirror_url":null,"open_issues_count":9,"forks":452,"open_issues":9,"watchers":3511,"default_branch":"master"}},"base":{"label":"youtube:master","ref":"master","sha":"85c13d78fea15ba7d3cab344debdcf2ea8d2bbf9","user":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"repo":{"id":11008207,"name":"vitess","full_name":"youtube/vitess","owner":{"login":"youtube","id":4052902,"avatar_url":"https://avatars.githubusercontent.com/u/4052902?v=3","gravatar_id":"","url":"https://api.github.com/users/youtube","html_url":"https://github.com/youtube","followers_url":"https://api.github.com/users/youtube/followers","following_url":"https://api.github.com/users/youtube/following{/other_user}","gists_url":"https://api.github.com/users/youtube/gists{/gist_id}","starred_url":"https://api.github.com/users/youtube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youtube/subscriptions","organizations_url":"https://api.github.com/users/youtube/orgs","repos_url":"https://api.github.com/users/youtube/repos","events_url":"https://api.github.com/users/youtube/events{/privacy}","received_events_url":"https://api.github.com/users/youtube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/youtube/vitess","description":"vitess provides servers and tools which facilitate scaling of MySQL databases for large scale web services.","fork":false,"url":"https://api.github.com/repos/youtube/vitess","forks_url":"https://api.github.com/repos/youtube/vitess/forks","keys_url":"https://api.github.com/repos/youtube/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/youtube/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/youtube/vitess/teams","hooks_url":"https://api.github.com/repos/youtube/vitess/hooks","issue_events_url":"https://api.github.com/repos/youtube/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/youtube/vitess/events","assignees_url":"https://api.github.com/repos/youtube/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/youtube/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/youtube/vitess/tags","blobs_url":"https://api.github.com/repos/youtube/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/youtube/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/youtube/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/youtube/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/youtube/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/youtube/vitess/languages","stargazers_url":"https://api.github.com/repos/youtube/vitess/stargazers","contributors_url":"https://api.github.com/repos/youtube/vitess/contributors","subscribers_url":"https://api.github.com/repos/youtube/vitess/subscribers","subscription_url":"https://api.github.com/repos/youtube/vitess/subscription","commits_url":"https://api.github.com/repos/youtube/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/youtube/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/youtube/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/youtube/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/youtube/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/youtube/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/youtube/vitess/merges","archive_url":"https://api.github.com/repos/youtube/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/youtube/vitess/downloads","issues_url":"https://api.github.com/repos/youtube/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/youtube/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/youtube/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/youtube/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/youtube/vitess/labels{/name}","releases_url":"https://api.github.com/repos/youtube/vitess/releases{/id}","deployments_url":"https://api.github.com/repos/youtube/vitess/deployments","created_at":"2013-06-27T21:20:28Z","updated_at":"2016-06-09T05:23:02Z","pushed_at":"2016-06-09T06:18:50Z","git_url":"git://github.com/youtube/vitess.git","ssh_url":"git@github.com:youtube/vitess.git","clone_url":"https://github.com/youtube/vitess.git","svn_url":"https://github.com/youtube/vitess","homepage":null,"size":88197,"stargazers_count":3511,"watchers_count":3511,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":452,"mirror_url":null,"open_issues_count":9,"forks":452,"open_issues":9,"watchers":3511,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/youtube/vitess/pulls/1764"},"html":{"href":"https://github.com/youtube/vitess/pull/1764"},"issue":{"href":"https://api.github.com/repos/youtube/vitess/issues/1764"},"comments":{"href":"https://api.github.com/repos/youtube/vitess/issues/1764/comments"},"review_comments":{"href":"https://api.github.com/repos/youtube/vitess/pulls/1764/comments"},"review_comment":{"href":"https://api.github.com/repos/youtube/vitess/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/youtube/vitess/pulls/1764/commits"},"statuses":{"href":"https://api.github.com/repos/youtube/vitess/statuses/7907dc41ed0c72043eb7855196cf44f2b830ec6a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"michael-berlin","id":3919251,"avatar_url":"https://avatars.githubusercontent.com/u/3919251?v=3","gravatar_id":"","url":"https://api.github.com/users/michael-berlin","html_url":"https://github.com/michael-berlin","followers_url":"https://api.github.com/users/michael-berlin/followers","following_url":"https://api.github.com/users/michael-berlin/following{/other_user}","gists_url":"https://api.github.com/users/michael-berlin/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-berlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-berlin/subscriptions","organizations_url":"https://api.github.com/users/michael-berlin/orgs","repos_url":"https://api.github.com/users/michael-berlin/repos","events_url":"https://api.github.com/users/michael-berlin/events{/privacy}","received_events_url":"https://api.github.com/users/michael-berlin/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":4,"additions":69,"deletions":19,"changed_files":3}}
{"actor":{"display_login":"michael-berlin"}}