{"action":"created","issue":{"url":"https://api.github.com/repos/Growstuff/growstuff/issues/1131","repository_url":"https://api.github.com/repos/Growstuff/growstuff","labels_url":"https://api.github.com/repos/Growstuff/growstuff/issues/1131/labels{/name}","comments_url":"https://api.github.com/repos/Growstuff/growstuff/issues/1131/comments","events_url":"https://api.github.com/repos/Growstuff/growstuff/issues/1131/events","html_url":"https://github.com/Growstuff/growstuff/pull/1131","id":196465368,"number":1131,"title":"Improve unit test coverage for models","user":{"login":"pozorvlak","id":225991,"avatar_url":"https://avatars.githubusercontent.com/u/225991?v=3","gravatar_id":"","url":"https://api.github.com/users/pozorvlak","html_url":"https://github.com/pozorvlak","followers_url":"https://api.github.com/users/pozorvlak/followers","following_url":"https://api.github.com/users/pozorvlak/following{/other_user}","gists_url":"https://api.github.com/users/pozorvlak/gists{/gist_id}","starred_url":"https://api.github.com/users/pozorvlak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pozorvlak/subscriptions","organizations_url":"https://api.github.com/users/pozorvlak/orgs","repos_url":"https://api.github.com/users/pozorvlak/repos","events_url":"https://api.github.com/users/pozorvlak/events{/privacy}","received_events_url":"https://api.github.com/users/pozorvlak/received_events","type":"User","site_admin":false},"labels":[{"id":387776518,"url":"https://api.github.com/repos/Growstuff/growstuff/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-12-19T16:52:29Z","updated_at":"2016-12-19T22:38:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Growstuff/growstuff/pulls/1131","html_url":"https://github.com/Growstuff/growstuff/pull/1131","diff_url":"https://github.com/Growstuff/growstuff/pull/1131.diff","patch_url":"https://github.com/Growstuff/growstuff/pull/1131.patch"},"body":"Adds some unit tests for posts and crops, and does some slight cleanup of the existing tests there. Also adds one feature test for \"sign-in using email address rather than username\", because that works by implementing a callback for Devise to use, and it didn't seem that unit-testing the callback was very worthwhile: the callback is trivial, the question is whether it matches Devise's expectations.\r\n\r\nThe two models with big coverage gaps are Member and Photo, because of the code to talk to Gibbon and Flickr. We could (and perhaps should) get those coverage numbers up with some judicious mocking. **Edit**: I've made a start at this.\r\n\r\nThe directory with the worst coverage is hands-down `app/controllers`, some of whose members have *dire* coverage. We deprecated controller tests a while back in favour of feature tests; in view of our problems with flaky CI, I think we should revisit that decision."},"comment":{"url":"https://api.github.com/repos/Growstuff/growstuff/issues/comments/268099441","html_url":"https://github.com/Growstuff/growstuff/pull/1131#issuecomment-268099441","issue_url":"https://api.github.com/repos/Growstuff/growstuff/issues/1131","id":268099441,"user":{"login":"Br3nda","id":12266,"avatar_url":"https://avatars.githubusercontent.com/u/12266?v=3","gravatar_id":"","url":"https://api.github.com/users/Br3nda","html_url":"https://github.com/Br3nda","followers_url":"https://api.github.com/users/Br3nda/followers","following_url":"https://api.github.com/users/Br3nda/following{/other_user}","gists_url":"https://api.github.com/users/Br3nda/gists{/gist_id}","starred_url":"https://api.github.com/users/Br3nda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Br3nda/subscriptions","organizations_url":"https://api.github.com/users/Br3nda/orgs","repos_url":"https://api.github.com/users/Br3nda/repos","events_url":"https://api.github.com/users/Br3nda/events{/privacy}","received_events_url":"https://api.github.com/users/Br3nda/received_events","type":"User","site_admin":false},"created_at":"2016-12-19T22:38:11Z","updated_at":"2016-12-19T22:38:11Z","body":"This is a fabulous PR. TEST ALL THE THINGS"}}
{"actor":{"display_login":"Br3nda"}}