{"action":"created","issue":{"url":"https://api.github.com/repos/dgraph-io/gru/issues/26","repository_url":"https://api.github.com/repos/dgraph-io/gru","labels_url":"https://api.github.com/repos/dgraph-io/gru/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/dgraph-io/gru/issues/26/comments","events_url":"https://api.github.com/repos/dgraph-io/gru/issues/26/events","html_url":"https://github.com/dgraph-io/gru/pull/26","id":164231727,"number":26,"title":"Refactoring to remove some code","user":{"login":"pawanrawal","id":7247941,"avatar_url":"https://avatars.githubusercontent.com/u/7247941?v=3","gravatar_id":"","url":"https://api.github.com/users/pawanrawal","html_url":"https://github.com/pawanrawal","followers_url":"https://api.github.com/users/pawanrawal/followers","following_url":"https://api.github.com/users/pawanrawal/following{/other_user}","gists_url":"https://api.github.com/users/pawanrawal/gists{/gist_id}","starred_url":"https://api.github.com/users/pawanrawal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawanrawal/subscriptions","organizations_url":"https://api.github.com/users/pawanrawal/orgs","repos_url":"https://api.github.com/users/pawanrawal/repos","events_url":"https://api.github.com/users/pawanrawal/events{/privacy}","received_events_url":"https://api.github.com/users/pawanrawal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ashwin95r","id":5701997,"avatar_url":"https://avatars.githubusercontent.com/u/5701997?v=3","gravatar_id":"","url":"https://api.github.com/users/ashwin95r","html_url":"https://github.com/ashwin95r","followers_url":"https://api.github.com/users/ashwin95r/followers","following_url":"https://api.github.com/users/ashwin95r/following{/other_user}","gists_url":"https://api.github.com/users/ashwin95r/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwin95r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwin95r/subscriptions","organizations_url":"https://api.github.com/users/ashwin95r/orgs","repos_url":"https://api.github.com/users/ashwin95r/repos","events_url":"https://api.github.com/users/ashwin95r/events{/privacy}","received_events_url":"https://api.github.com/users/ashwin95r/received_events","type":"User","site_admin":false},"assignees":[{"login":"ashwin95r","id":5701997,"avatar_url":"https://avatars.githubusercontent.com/u/5701997?v=3","gravatar_id":"","url":"https://api.github.com/users/ashwin95r","html_url":"https://github.com/ashwin95r","followers_url":"https://api.github.com/users/ashwin95r/followers","following_url":"https://api.github.com/users/ashwin95r/following{/other_user}","gists_url":"https://api.github.com/users/ashwin95r/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwin95r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwin95r/subscriptions","organizations_url":"https://api.github.com/users/ashwin95r/orgs","repos_url":"https://api.github.com/users/ashwin95r/repos","events_url":"https://api.github.com/users/ashwin95r/events{/privacy}","received_events_url":"https://api.github.com/users/ashwin95r/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-07-07T05:22:17Z","updated_at":"2016-07-07T05:52:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dgraph-io/gru/pulls/26","html_url":"https://github.com/dgraph-io/gru/pull/26","diff_url":"https://github.com/dgraph-io/gru/pull/26.diff","patch_url":"https://github.com/dgraph-io/gru/pull/26.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dgraph-io/gru/26)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/dgraph-io/gru/issues/comments/230985316","html_url":"https://github.com/dgraph-io/gru/pull/26#issuecomment-230985316","issue_url":"https://api.github.com/repos/dgraph-io/gru/issues/26","id":230985316,"user":{"login":"ashwin95r","id":5701997,"avatar_url":"https://avatars.githubusercontent.com/u/5701997?v=3","gravatar_id":"","url":"https://api.github.com/users/ashwin95r","html_url":"https://github.com/ashwin95r","followers_url":"https://api.github.com/users/ashwin95r/followers","following_url":"https://api.github.com/users/ashwin95r/following{/other_user}","gists_url":"https://api.github.com/users/ashwin95r/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwin95r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwin95r/subscriptions","organizations_url":"https://api.github.com/users/ashwin95r/orgs","repos_url":"https://api.github.com/users/ashwin95r/repos","events_url":"https://api.github.com/users/ashwin95r/events{/privacy}","received_events_url":"https://api.github.com/users/ashwin95r/received_events","type":"User","site_admin":false},"created_at":"2016-07-07T05:52:23Z","updated_at":"2016-07-07T05:52:23Z","body":"\n\n\n\nReviewed 2 of 2 files at r1.\nReview status: all files reviewed at latest revision, 4 unresolved discussions.\n\n---\n\n*[server/main.go, line 366 \\[r1\\]](https://reviewable.io:443/reviews/dgraph-io/gru/26#-KM2u4PUE-Yjg_nGQLpR:-KM2u4PUE-Yjg_nGQLpS:1838363216) ([raw file](https://github.com/dgraph-io/gru/blob/fa50da3101280b59606037472ab6b45299c7c456/server/main.go#L366)):*\n> ```Go\n> }\n> \n> func getQuestion(req *interact.Req, c Candidate) (*interact.Question, error) {\n> ```\n\nDo we have to pass candidate? we are reading it in the next line.\n\n---\n\n*[server/main.go, line 481 \\[r1\\]](https://reviewable.io:443/reviews/dgraph-io/gru/26#-KM2uGdb8aGfbCkYiZRi:-KM2uGdb8aGfbCkYiZRj:-962980877) ([raw file](https://github.com/dgraph-io/gru/blob/fa50da3101280b59606037472ab6b45299c7c456/server/main.go#L481)):*\n> ```Go\n> }\n> \n> func sendAnswer(resp *interact.Response, c Candidate) (*interact.Status, error) {\n> ```\n\nDo we have to pass candidate? we are reading it in the function.\n\n---\n\n*[server/main_test.go, line 154 \\[r1\\]](https://reviewable.io:443/reviews/dgraph-io/gru/26#-KM2sGIoQxarabPC9q3Y:-KM2sGIpTg31Of4FiX0q:1824336123) ([raw file](https://github.com/dgraph-io/gru/blob/fa50da3101280b59606037472ab6b45299c7c456/server/main_test.go#L154)):*\n> ```Go\n> \tc, _ = readMap(token)\n> \tq2, err := getQuestion(req, c)\n> \tfmt.Println(q1)\n> ```\n\nRequired?\n\n---\n\n*[server/main_test.go, line 356 \\[r1\\]](https://reviewable.io:443/reviews/dgraph-io/gru/26#-KM2sg7J1dyFbjhdNZr7:-KM2sg7KkLG3JaTZnovt:1482065930) ([raw file](https://github.com/dgraph-io/gru/blob/fa50da3101280b59606037472ab6b45299c7c456/server/main_test.go#L356)):*\n> ```Go\n> \tc.logFile = f\n> \tcmap = make(map[string]Candidate)\n> \tcmap[\"test_token\"] = c\n> ```\n\nSuch lines also have to be changes to updateMap() and readMap() \n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/dgraph-io/gru/26)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"ashwin95r"}}