{"action":"created","comment":{"url":"https://api.github.com/repos/juju/ansiterm/pulls/comments/77921658","id":77921658,"diff_hunk":"@@ -283,12 +285,24 @@ func (b *Writer) writeLines(pos0 int, line0, line1 int) (pos int) {\n \t\t\t} else {\n \t\t\t\t// non-empty cell\n \t\t\t\tuseTabs = false\n-\t\t\t\tif b.flags&AlignRight == 0 { // align left\n+\t\t\t\talignRight := b.alignment[j] == AlignRight","path":"tabwriter/tabwriter.go","position":33,"original_position":33,"commit_id":"c774b3c9b5b5318895bb20a95a0a7a08ff687b77","original_commit_id":"c774b3c9b5b5318895bb20a95a0a7a08ff687b77","user":{"login":"mjs","id":14993,"avatar_url":"https://avatars.githubusercontent.com/u/14993?v=3","gravatar_id":"","url":"https://api.github.com/users/mjs","html_url":"https://github.com/mjs","followers_url":"https://api.github.com/users/mjs/followers","following_url":"https://api.github.com/users/mjs/following{/other_user}","gists_url":"https://api.github.com/users/mjs/gists{/gist_id}","starred_url":"https://api.github.com/users/mjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjs/subscriptions","organizations_url":"https://api.github.com/users/mjs/orgs","repos_url":"https://api.github.com/users/mjs/repos","events_url":"https://api.github.com/users/mjs/events{/privacy}","received_events_url":"https://api.github.com/users/mjs/received_events","type":"User","site_admin":false},"body":"What if you want the table aligned right and override some columns to be aligned left?","created_at":"2016-09-07T23:15:39Z","updated_at":"2016-09-07T23:15:39Z","html_url":"https://github.com/juju/ansiterm/pull/4#discussion_r77921658","pull_request_url":"https://api.github.com/repos/juju/ansiterm/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/juju/ansiterm/pulls/comments/77921658"},"html":{"href":"https://github.com/juju/ansiterm/pull/4#discussion_r77921658"},"pull_request":{"href":"https://api.github.com/repos/juju/ansiterm/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/juju/ansiterm/pulls/4","id":84386704,"html_url":"https://github.com/juju/ansiterm/pull/4","diff_url":"https://github.com/juju/ansiterm/pull/4.diff","patch_url":"https://github.com/juju/ansiterm/pull/4.patch","issue_url":"https://api.github.com/repos/juju/ansiterm/issues/4","number":4,"state":"open","locked":false,"title":"Make individual columns able to be right aligned.","user":{"login":"howbazaar","id":1744247,"avatar_url":"https://avatars.githubusercontent.com/u/1744247?v=3","gravatar_id":"","url":"https://api.github.com/users/howbazaar","html_url":"https://github.com/howbazaar","followers_url":"https://api.github.com/users/howbazaar/followers","following_url":"https://api.github.com/users/howbazaar/following{/other_user}","gists_url":"https://api.github.com/users/howbazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/howbazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howbazaar/subscriptions","organizations_url":"https://api.github.com/users/howbazaar/orgs","repos_url":"https://api.github.com/users/howbazaar/repos","events_url":"https://api.github.com/users/howbazaar/events{/privacy}","received_events_url":"https://api.github.com/users/howbazaar/received_events","type":"User","site_admin":false},"body":"The interesting part here is that when the entire table is aligned right, the padding is on the left hand side of the column, not the right. So when an individual column is aligned right, we want the padding on the right hand side of the column.","created_at":"2016-09-07T22:43:05Z","updated_at":"2016-09-07T23:15:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8307ab6d210bac0fbeb5b5e4b6d7bdb1c822610","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/ansiterm/pulls/4/commits","review_comments_url":"https://api.github.com/repos/juju/ansiterm/pulls/4/comments","review_comment_url":"https://api.github.com/repos/juju/ansiterm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/ansiterm/issues/4/comments","statuses_url":"https://api.github.com/repos/juju/ansiterm/statuses/c774b3c9b5b5318895bb20a95a0a7a08ff687b77","head":{"label":"howbazaar:right-align-tabwriter-columns","ref":"right-align-tabwriter-columns","sha":"c774b3c9b5b5318895bb20a95a0a7a08ff687b77","user":{"login":"howbazaar","id":1744247,"avatar_url":"https://avatars.githubusercontent.com/u/1744247?v=3","gravatar_id":"","url":"https://api.github.com/users/howbazaar","html_url":"https://github.com/howbazaar","followers_url":"https://api.github.com/users/howbazaar/followers","following_url":"https://api.github.com/users/howbazaar/following{/other_user}","gists_url":"https://api.github.com/users/howbazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/howbazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howbazaar/subscriptions","organizations_url":"https://api.github.com/users/howbazaar/orgs","repos_url":"https://api.github.com/users/howbazaar/repos","events_url":"https://api.github.com/users/howbazaar/events{/privacy}","received_events_url":"https://api.github.com/users/howbazaar/received_events","type":"User","site_admin":false},"repo":{"id":65804442,"name":"ansiterm","full_name":"howbazaar/ansiterm","owner":{"login":"howbazaar","id":1744247,"avatar_url":"https://avatars.githubusercontent.com/u/1744247?v=3","gravatar_id":"","url":"https://api.github.com/users/howbazaar","html_url":"https://github.com/howbazaar","followers_url":"https://api.github.com/users/howbazaar/followers","following_url":"https://api.github.com/users/howbazaar/following{/other_user}","gists_url":"https://api.github.com/users/howbazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/howbazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howbazaar/subscriptions","organizations_url":"https://api.github.com/users/howbazaar/orgs","repos_url":"https://api.github.com/users/howbazaar/repos","events_url":"https://api.github.com/users/howbazaar/events{/privacy}","received_events_url":"https://api.github.com/users/howbazaar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/howbazaar/ansiterm","description":"Colored writers and tabwriters.","fork":true,"url":"https://api.github.com/repos/howbazaar/ansiterm","forks_url":"https://api.github.com/repos/howbazaar/ansiterm/forks","keys_url":"https://api.github.com/repos/howbazaar/ansiterm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/howbazaar/ansiterm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/howbazaar/ansiterm/teams","hooks_url":"https://api.github.com/repos/howbazaar/ansiterm/hooks","issue_events_url":"https://api.github.com/repos/howbazaar/ansiterm/issues/events{/number}","events_url":"https://api.github.com/repos/howbazaar/ansiterm/events","assignees_url":"https://api.github.com/repos/howbazaar/ansiterm/assignees{/user}","branches_url":"https://api.github.com/repos/howbazaar/ansiterm/branches{/branch}","tags_url":"https://api.github.com/repos/howbazaar/ansiterm/tags","blobs_url":"https://api.github.com/repos/howbazaar/ansiterm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/howbazaar/ansiterm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/howbazaar/ansiterm/git/refs{/sha}","trees_url":"https://api.github.com/repos/howbazaar/ansiterm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/howbazaar/ansiterm/statuses/{sha}","languages_url":"https://api.github.com/repos/howbazaar/ansiterm/languages","stargazers_url":"https://api.github.com/repos/howbazaar/ansiterm/stargazers","contributors_url":"https://api.github.com/repos/howbazaar/ansiterm/contributors","subscribers_url":"https://api.github.com/repos/howbazaar/ansiterm/subscribers","subscription_url":"https://api.github.com/repos/howbazaar/ansiterm/subscription","commits_url":"https://api.github.com/repos/howbazaar/ansiterm/commits{/sha}","git_commits_url":"https://api.github.com/repos/howbazaar/ansiterm/git/commits{/sha}","comments_url":"https://api.github.com/repos/howbazaar/ansiterm/comments{/number}","issue_comment_url":"https://api.github.com/repos/howbazaar/ansiterm/issues/comments{/number}","contents_url":"https://api.github.com/repos/howbazaar/ansiterm/contents/{+path}","compare_url":"https://api.github.com/repos/howbazaar/ansiterm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/howbazaar/ansiterm/merges","archive_url":"https://api.github.com/repos/howbazaar/ansiterm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/howbazaar/ansiterm/downloads","issues_url":"https://api.github.com/repos/howbazaar/ansiterm/issues{/number}","pulls_url":"https://api.github.com/repos/howbazaar/ansiterm/pulls{/number}","milestones_url":"https://api.github.com/repos/howbazaar/ansiterm/milestones{/number}","notifications_url":"https://api.github.com/repos/howbazaar/ansiterm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/howbazaar/ansiterm/labels{/name}","releases_url":"https://api.github.com/repos/howbazaar/ansiterm/releases{/id}","deployments_url":"https://api.github.com/repos/howbazaar/ansiterm/deployments","created_at":"2016-08-16T09:01:10Z","updated_at":"2016-08-16T08:58:11Z","pushed_at":"2016-09-07T06:49:08Z","git_url":"git://github.com/howbazaar/ansiterm.git","ssh_url":"git@github.com:howbazaar/ansiterm.git","clone_url":"https://github.com/howbazaar/ansiterm.git","svn_url":"https://github.com/howbazaar/ansiterm","homepage":null,"size":20,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:master","ref":"master","sha":"c4ce98b1cd3195b2d6a3069a2445bee608de04a2","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":65804228,"name":"ansiterm","full_name":"juju/ansiterm","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/ansiterm","description":"Colored writers and tabwriters.","fork":false,"url":"https://api.github.com/repos/juju/ansiterm","forks_url":"https://api.github.com/repos/juju/ansiterm/forks","keys_url":"https://api.github.com/repos/juju/ansiterm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/ansiterm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/ansiterm/teams","hooks_url":"https://api.github.com/repos/juju/ansiterm/hooks","issue_events_url":"https://api.github.com/repos/juju/ansiterm/issues/events{/number}","events_url":"https://api.github.com/repos/juju/ansiterm/events","assignees_url":"https://api.github.com/repos/juju/ansiterm/assignees{/user}","branches_url":"https://api.github.com/repos/juju/ansiterm/branches{/branch}","tags_url":"https://api.github.com/repos/juju/ansiterm/tags","blobs_url":"https://api.github.com/repos/juju/ansiterm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/ansiterm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/ansiterm/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/ansiterm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/ansiterm/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/ansiterm/languages","stargazers_url":"https://api.github.com/repos/juju/ansiterm/stargazers","contributors_url":"https://api.github.com/repos/juju/ansiterm/contributors","subscribers_url":"https://api.github.com/repos/juju/ansiterm/subscribers","subscription_url":"https://api.github.com/repos/juju/ansiterm/subscription","commits_url":"https://api.github.com/repos/juju/ansiterm/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/ansiterm/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/ansiterm/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/ansiterm/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/ansiterm/contents/{+path}","compare_url":"https://api.github.com/repos/juju/ansiterm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/ansiterm/merges","archive_url":"https://api.github.com/repos/juju/ansiterm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/ansiterm/downloads","issues_url":"https://api.github.com/repos/juju/ansiterm/issues{/number}","pulls_url":"https://api.github.com/repos/juju/ansiterm/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/ansiterm/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/ansiterm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/ansiterm/labels{/name}","releases_url":"https://api.github.com/repos/juju/ansiterm/releases{/id}","deployments_url":"https://api.github.com/repos/juju/ansiterm/deployments","created_at":"2016-08-16T08:58:11Z","updated_at":"2016-08-17T02:52:45Z","pushed_at":"2016-09-07T22:43:05Z","git_url":"git://github.com/juju/ansiterm.git","ssh_url":"git@github.com:juju/ansiterm.git","clone_url":"https://github.com/juju/ansiterm.git","svn_url":"https://github.com/juju/ansiterm","homepage":null,"size":21,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/ansiterm/pulls/4"},"html":{"href":"https://github.com/juju/ansiterm/pull/4"},"issue":{"href":"https://api.github.com/repos/juju/ansiterm/issues/4"},"comments":{"href":"https://api.github.com/repos/juju/ansiterm/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/ansiterm/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/ansiterm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/ansiterm/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/juju/ansiterm/statuses/c774b3c9b5b5318895bb20a95a0a7a08ff687b77"}}}}
{"actor":{"display_login":"mjs"}}