{"action":"created","issue":{"url":"https://api.github.com/repos/apache/cordova-plugin-inappbrowser/issues/197","repository_url":"https://api.github.com/repos/apache/cordova-plugin-inappbrowser","labels_url":"https://api.github.com/repos/apache/cordova-plugin-inappbrowser/issues/197/labels{/name}","comments_url":"https://api.github.com/repos/apache/cordova-plugin-inappbrowser/issues/197/comments","events_url":"https://api.github.com/repos/apache/cordova-plugin-inappbrowser/issues/197/events","html_url":"https://github.com/apache/cordova-plugin-inappbrowser/pull/197","id":188702626,"number":197,"title":"CB-12132: (android & ios) implement hidenotclose feature","user":{"login":"ghenry22","id":7463213,"avatar_url":"https://avatars.githubusercontent.com/u/7463213?v=3","gravatar_id":"","url":"https://api.github.com/users/ghenry22","html_url":"https://github.com/ghenry22","followers_url":"https://api.github.com/users/ghenry22/followers","following_url":"https://api.github.com/users/ghenry22/following{/other_user}","gists_url":"https://api.github.com/users/ghenry22/gists{/gist_id}","starred_url":"https://api.github.com/users/ghenry22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghenry22/subscriptions","organizations_url":"https://api.github.com/users/ghenry22/orgs","repos_url":"https://api.github.com/users/ghenry22/repos","events_url":"https://api.github.com/users/ghenry22/events{/privacy}","received_events_url":"https://api.github.com/users/ghenry22/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-11-11T07:41:41Z","updated_at":"2016-11-12T23:23:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/cordova-plugin-inappbrowser/pulls/197","html_url":"https://github.com/apache/cordova-plugin-inappbrowser/pull/197","diff_url":"https://github.com/apache/cordova-plugin-inappbrowser/pull/197.diff","patch_url":"https://github.com/apache/cordova-plugin-inappbrowser/pull/197.patch"},"body":"\r\n### Platforms affected\r\nandroid & ios\r\n\r\n### What does this PR do?\r\nThis adds a new option hidenotclose which can be passed to the\r\ninappbrowser.\r\n\r\nWhen set to yes the done button on iOS or the X button android will\r\nhide the web view instead of closing it.\r\n\r\nThis allows the user to show/hide the web view multiple times without\r\nhaving to reload the content and you can clean up when you know they\r\nare done by calling close once.\r\n\r\n### What testing has been done on this change?\r\nmanually tested on both android and ios with both enabled and disabled settings.\r\nwhen disabled (as by default) existing behaviour is maintained\r\n\r\n### Checklist\r\n- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database\r\n- [X] Commit message follows the format: \"CB-3232: (android) Fix bug with resolving file paths\", where CB-xxxx is the JIRA ID & \"android\" is the platform affected.\r\n- [O] Added automated test coverage as appropriate for this change.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apache/cordova-plugin-inappbrowser/issues/comments/260155350","html_url":"https://github.com/apache/cordova-plugin-inappbrowser/pull/197#issuecomment-260155350","issue_url":"https://api.github.com/repos/apache/cordova-plugin-inappbrowser/issues/197","id":260155350,"user":{"login":"jcesarmobile","id":1637892,"avatar_url":"https://avatars.githubusercontent.com/u/1637892?v=3","gravatar_id":"","url":"https://api.github.com/users/jcesarmobile","html_url":"https://github.com/jcesarmobile","followers_url":"https://api.github.com/users/jcesarmobile/followers","following_url":"https://api.github.com/users/jcesarmobile/following{/other_user}","gists_url":"https://api.github.com/users/jcesarmobile/gists{/gist_id}","starred_url":"https://api.github.com/users/jcesarmobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcesarmobile/subscriptions","organizations_url":"https://api.github.com/users/jcesarmobile/orgs","repos_url":"https://api.github.com/users/jcesarmobile/repos","events_url":"https://api.github.com/users/jcesarmobile/events{/privacy}","received_events_url":"https://api.github.com/users/jcesarmobile/received_events","type":"User","site_admin":false},"created_at":"2016-11-12T23:23:30Z","updated_at":"2016-11-12T23:23:30Z","body":"I didn't meant to reuse the existing hide, but make the old hide just call the new browserHide as browserHide has the exact same code\r\n\r\n```- (void)hide:(CDVInvokedUrlCommand*)command\r\n{\r\n    [self browserHide];\r\n}```\r\n"}}
{"actor":{"display_login":"jcesarmobile"}}