{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/engine/pulls/comments/49022714","id":49022714,"diff_hunk":"@@ -17,7 +17,10 @@ namespace blink {\n class DartArgIterator {\n  public:\n   explicit DartArgIterator(Dart_NativeArguments args)","path":"sky/engine/tonic/dart_args.h","position":null,"original_position":3,"commit_id":"443ba0759ec5bd9419c6ec4e3c0ca491703e039b","original_commit_id":"74cc5974b377b80a4ac0ea8c9a1955f6a77bf6af","user":{"login":"jason-simmons","id":14226037,"avatar_url":"https://avatars.githubusercontent.com/u/14226037?v=3","gravatar_id":"","url":"https://api.github.com/users/jason-simmons","html_url":"https://github.com/jason-simmons","followers_url":"https://api.github.com/users/jason-simmons/followers","following_url":"https://api.github.com/users/jason-simmons/following{/other_user}","gists_url":"https://api.github.com/users/jason-simmons/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-simmons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-simmons/subscriptions","organizations_url":"https://api.github.com/users/jason-simmons/orgs","repos_url":"https://api.github.com/users/jason-simmons/repos","events_url":"https://api.github.com/users/jason-simmons/events{/privacy}","received_events_url":"https://api.github.com/users/jason-simmons/received_events","type":"User","site_admin":false},"body":"done","created_at":"2016-01-06T23:08:08Z","updated_at":"2016-01-06T23:08:08Z","html_url":"https://github.com/flutter/engine/pull/2219#discussion_r49022714","pull_request_url":"https://api.github.com/repos/flutter/engine/pulls/2219","_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments/49022714"},"html":{"href":"https://github.com/flutter/engine/pull/2219#discussion_r49022714"},"pull_request":{"href":"https://api.github.com/repos/flutter/engine/pulls/2219"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/engine/pulls/2219","id":55277670,"html_url":"https://github.com/flutter/engine/pull/2219","diff_url":"https://github.com/flutter/engine/pull/2219.diff","patch_url":"https://github.com/flutter/engine/pull/2219.patch","issue_url":"https://api.github.com/repos/flutter/engine/issues/2219","number":2219,"state":"open","locked":false,"title":"Add Tonic macros for dispatching to static methods","user":{"login":"jason-simmons","id":14226037,"avatar_url":"https://avatars.githubusercontent.com/u/14226037?v=3","gravatar_id":"","url":"https://api.github.com/users/jason-simmons","html_url":"https://github.com/jason-simmons","followers_url":"https://api.github.com/users/jason-simmons/followers","following_url":"https://api.github.com/users/jason-simmons/following{/other_user}","gists_url":"https://api.github.com/users/jason-simmons/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-simmons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-simmons/subscriptions","organizations_url":"https://api.github.com/users/jason-simmons/orgs","repos_url":"https://api.github.com/users/jason-simmons/repos","events_url":"https://api.github.com/users/jason-simmons/events{/privacy}","received_events_url":"https://api.github.com/users/jason-simmons/received_events","type":"User","site_admin":false},"body":"DartArgIterator was starting at argument index 1 because it assumed that the\r\narguments include a pointer to the \"this\" object for an instance method.\r\nDART_REGISTER_NATIVE makes the same assumption in the argument count.\r\n\r\nThis change adds versions of the macros that are suitable for static methods\r\nwith no implicit arguments.","created_at":"2016-01-06T23:01:17Z","updated_at":"2016-01-06T23:08:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7efe7d2097548534e4397f2df1b193cf22679042","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flutter/engine/pulls/2219/commits","review_comments_url":"https://api.github.com/repos/flutter/engine/pulls/2219/comments","review_comment_url":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/engine/issues/2219/comments","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/443ba0759ec5bd9419c6ec4e3c0ca491703e039b","head":{"label":"jason-simmons:tonic_static_wrapper","ref":"tonic_static_wrapper","sha":"443ba0759ec5bd9419c6ec4e3c0ca491703e039b","user":{"login":"jason-simmons","id":14226037,"avatar_url":"https://avatars.githubusercontent.com/u/14226037?v=3","gravatar_id":"","url":"https://api.github.com/users/jason-simmons","html_url":"https://github.com/jason-simmons","followers_url":"https://api.github.com/users/jason-simmons/followers","following_url":"https://api.github.com/users/jason-simmons/following{/other_user}","gists_url":"https://api.github.com/users/jason-simmons/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-simmons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-simmons/subscriptions","organizations_url":"https://api.github.com/users/jason-simmons/orgs","repos_url":"https://api.github.com/users/jason-simmons/repos","events_url":"https://api.github.com/users/jason-simmons/events{/privacy}","received_events_url":"https://api.github.com/users/jason-simmons/received_events","type":"User","site_admin":false},"repo":{"id":42275405,"name":"flutter_engine","full_name":"jason-simmons/flutter_engine","owner":{"login":"jason-simmons","id":14226037,"avatar_url":"https://avatars.githubusercontent.com/u/14226037?v=3","gravatar_id":"","url":"https://api.github.com/users/jason-simmons","html_url":"https://github.com/jason-simmons","followers_url":"https://api.github.com/users/jason-simmons/followers","following_url":"https://api.github.com/users/jason-simmons/following{/other_user}","gists_url":"https://api.github.com/users/jason-simmons/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-simmons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-simmons/subscriptions","organizations_url":"https://api.github.com/users/jason-simmons/orgs","repos_url":"https://api.github.com/users/jason-simmons/repos","events_url":"https://api.github.com/users/jason-simmons/events{/privacy}","received_events_url":"https://api.github.com/users/jason-simmons/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jason-simmons/flutter_engine","description":"The Sky engine","fork":true,"url":"https://api.github.com/repos/jason-simmons/flutter_engine","forks_url":"https://api.github.com/repos/jason-simmons/flutter_engine/forks","keys_url":"https://api.github.com/repos/jason-simmons/flutter_engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jason-simmons/flutter_engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jason-simmons/flutter_engine/teams","hooks_url":"https://api.github.com/repos/jason-simmons/flutter_engine/hooks","issue_events_url":"https://api.github.com/repos/jason-simmons/flutter_engine/issues/events{/number}","events_url":"https://api.github.com/repos/jason-simmons/flutter_engine/events","assignees_url":"https://api.github.com/repos/jason-simmons/flutter_engine/assignees{/user}","branches_url":"https://api.github.com/repos/jason-simmons/flutter_engine/branches{/branch}","tags_url":"https://api.github.com/repos/jason-simmons/flutter_engine/tags","blobs_url":"https://api.github.com/repos/jason-simmons/flutter_engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jason-simmons/flutter_engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jason-simmons/flutter_engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/jason-simmons/flutter_engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jason-simmons/flutter_engine/statuses/{sha}","languages_url":"https://api.github.com/repos/jason-simmons/flutter_engine/languages","stargazers_url":"https://api.github.com/repos/jason-simmons/flutter_engine/stargazers","contributors_url":"https://api.github.com/repos/jason-simmons/flutter_engine/contributors","subscribers_url":"https://api.github.com/repos/jason-simmons/flutter_engine/subscribers","subscription_url":"https://api.github.com/repos/jason-simmons/flutter_engine/subscription","commits_url":"https://api.github.com/repos/jason-simmons/flutter_engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/jason-simmons/flutter_engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/jason-simmons/flutter_engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/jason-simmons/flutter_engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/jason-simmons/flutter_engine/contents/{+path}","compare_url":"https://api.github.com/repos/jason-simmons/flutter_engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jason-simmons/flutter_engine/merges","archive_url":"https://api.github.com/repos/jason-simmons/flutter_engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jason-simmons/flutter_engine/downloads","issues_url":"https://api.github.com/repos/jason-simmons/flutter_engine/issues{/number}","pulls_url":"https://api.github.com/repos/jason-simmons/flutter_engine/pulls{/number}","milestones_url":"https://api.github.com/repos/jason-simmons/flutter_engine/milestones{/number}","notifications_url":"https://api.github.com/repos/jason-simmons/flutter_engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jason-simmons/flutter_engine/labels{/name}","releases_url":"https://api.github.com/repos/jason-simmons/flutter_engine/releases{/id}","created_at":"2015-09-10T23:06:33Z","updated_at":"2015-11-09T18:41:58Z","pushed_at":"2016-01-06T23:08:05Z","git_url":"git://github.com/jason-simmons/flutter_engine.git","ssh_url":"git@github.com:jason-simmons/flutter_engine.git","clone_url":"https://github.com/jason-simmons/flutter_engine.git","svn_url":"https://github.com/jason-simmons/flutter_engine","homepage":null,"size":79766,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"367577081616f92d462e06139d4e3bf51c6a75e4","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":39211337,"name":"engine","full_name":"flutter/engine","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/engine","description":"The Flutter engine","fork":false,"url":"https://api.github.com/repos/flutter/engine","forks_url":"https://api.github.com/repos/flutter/engine/forks","keys_url":"https://api.github.com/repos/flutter/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/engine/teams","hooks_url":"https://api.github.com/repos/flutter/engine/hooks","issue_events_url":"https://api.github.com/repos/flutter/engine/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/engine/events","assignees_url":"https://api.github.com/repos/flutter/engine/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/engine/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/engine/tags","blobs_url":"https://api.github.com/repos/flutter/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/engine/languages","stargazers_url":"https://api.github.com/repos/flutter/engine/stargazers","contributors_url":"https://api.github.com/repos/flutter/engine/contributors","subscribers_url":"https://api.github.com/repos/flutter/engine/subscribers","subscription_url":"https://api.github.com/repos/flutter/engine/subscription","commits_url":"https://api.github.com/repos/flutter/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/engine/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/engine/merges","archive_url":"https://api.github.com/repos/flutter/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/engine/downloads","issues_url":"https://api.github.com/repos/flutter/engine/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/engine/labels{/name}","releases_url":"https://api.github.com/repos/flutter/engine/releases{/id}","created_at":"2015-07-16T17:39:56Z","updated_at":"2016-01-03T14:00:52Z","pushed_at":"2016-01-06T23:08:05Z","git_url":"git://github.com/flutter/engine.git","ssh_url":"git@github.com:flutter/engine.git","clone_url":"https://github.com/flutter/engine.git","svn_url":"https://github.com/flutter/engine","homepage":"http://flutter.io","size":101713,"stargazers_count":849,"watchers_count":849,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"open_issues_count":5,"forks":121,"open_issues":5,"watchers":849,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/engine/pulls/2219"},"html":{"href":"https://github.com/flutter/engine/pull/2219"},"issue":{"href":"https://api.github.com/repos/flutter/engine/issues/2219"},"comments":{"href":"https://api.github.com/repos/flutter/engine/issues/2219/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/engine/pulls/2219/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/engine/pulls/2219/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/engine/statuses/443ba0759ec5bd9419c6ec4e3c0ca491703e039b"}}}}