{"action":"created","comment":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/comments/51145840","id":51145840,"diff_hunk":"@@ -0,0 +1,32 @@\n+\"\"\"Add connected objects to revisions\n+\n+Revision ID: 4e989ef86619\n+Revises: 262bbe790f4c\n+Create Date: 2016-01-28 11:15:12.300329\n+\n+\"\"\"\n+\n+from alembic import op\n+import sqlalchemy as sa\n+\n+\n+# revision identifiers, used by Alembic.\n+revision = '4e989ef86619'\n+down_revision = '262bbe790f4c'\n+\n+\n+def upgrade():\n+    op.add_column('revisions',\n+                  sa.Column('connected_type_1', sa.String(length=250)))","path":"src/ggrc/migrations/versions/20160128111512_4e989ef86619_add_connected_objects_to_revisions.py","position":20,"original_position":20,"commit_id":"ef3ea93fe6474643f1318b60e28636cff40b55ea","original_commit_id":"ef3ea93fe6474643f1318b60e28636cff40b55ea","user":{"login":"Smotko","id":513444,"avatar_url":"https://avatars.githubusercontent.com/u/513444?v=3","gravatar_id":"","url":"https://api.github.com/users/Smotko","html_url":"https://github.com/Smotko","followers_url":"https://api.github.com/users/Smotko/followers","following_url":"https://api.github.com/users/Smotko/following{/other_user}","gists_url":"https://api.github.com/users/Smotko/gists{/gist_id}","starred_url":"https://api.github.com/users/Smotko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smotko/subscriptions","organizations_url":"https://api.github.com/users/Smotko/orgs","repos_url":"https://api.github.com/users/Smotko/repos","events_url":"https://api.github.com/users/Smotko/events{/privacy}","received_events_url":"https://api.github.com/users/Smotko/received_events","type":"User","site_admin":false},"body":"Maybe instead of `connected_type_1` we should use `connected_destination_type`, `connected_source_type` to reflect the columns in the revisions table? Maybe even ditch the connected part and just have destination/source?","created_at":"2016-01-28T16:27:18Z","updated_at":"2016-01-28T16:27:18Z","html_url":"https://github.com/google/ggrc-core/pull/3537#discussion_r51145840","pull_request_url":"https://api.github.com/repos/google/ggrc-core/pulls/3537","_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments/51145840"},"html":{"href":"https://github.com/google/ggrc-core/pull/3537#discussion_r51145840"},"pull_request":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/3537"}}},"pull_request":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/3537","id":57526041,"html_url":"https://github.com/google/ggrc-core/pull/3537","diff_url":"https://github.com/google/ggrc-core/pull/3537.diff","patch_url":"https://github.com/google/ggrc-core/pull/3537.patch","issue_url":"https://api.github.com/repos/google/ggrc-core/issues/3537","number":3537,"state":"open","locked":false,"title":"CORE-3074 CORE-3076 Search revisions of join objects","user":{"login":"edofic","id":597476,"avatar_url":"https://avatars.githubusercontent.com/u/597476?v=3","gravatar_id":"","url":"https://api.github.com/users/edofic","html_url":"https://github.com/edofic","followers_url":"https://api.github.com/users/edofic/followers","following_url":"https://api.github.com/users/edofic/following{/other_user}","gists_url":"https://api.github.com/users/edofic/gists{/gist_id}","starred_url":"https://api.github.com/users/edofic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edofic/subscriptions","organizations_url":"https://api.github.com/users/edofic/orgs","repos_url":"https://api.github.com/users/edofic/repos","events_url":"https://api.github.com/users/edofic/events{/privacy}","received_events_url":"https://api.github.com/users/edofic/received_events","type":"User","site_admin":false},"body":"This stores connected objects in revisions for join objects so you can fetch revisions of join objects given only object type and id.\r\n\r\nStill needs some work, but I'd like some feedback on naming and overall design.\r\n\r\nTODO:\r\n- [ ] indexes\r\n- [ ] finish linting revision model","created_at":"2016-01-28T16:24:21Z","updated_at":"2016-01-28T16:27:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38b9ef13cdf8f5549eac591c4d7bd87f100c20fd","assignee":null,"milestone":{"url":"https://api.github.com/repos/google/ggrc-core/milestones/16","html_url":"https://github.com/google/ggrc-core/milestones/0.9.6-Plum%20Jelly","labels_url":"https://api.github.com/repos/google/ggrc-core/milestones/16/labels","id":1058061,"number":16,"title":"0.9.6-Plum Jelly","description":"","creator":{"login":"Smotko","id":513444,"avatar_url":"https://avatars.githubusercontent.com/u/513444?v=3","gravatar_id":"","url":"https://api.github.com/users/Smotko","html_url":"https://github.com/Smotko","followers_url":"https://api.github.com/users/Smotko/followers","following_url":"https://api.github.com/users/Smotko/following{/other_user}","gists_url":"https://api.github.com/users/Smotko/gists{/gist_id}","starred_url":"https://api.github.com/users/Smotko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smotko/subscriptions","organizations_url":"https://api.github.com/users/Smotko/orgs","repos_url":"https://api.github.com/users/Smotko/repos","events_url":"https://api.github.com/users/Smotko/events{/privacy}","received_events_url":"https://api.github.com/users/Smotko/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":84,"state":"open","created_at":"2015-04-08T11:38:13Z","updated_at":"2016-01-28T16:24:21Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/google/ggrc-core/pulls/3537/commits","review_comments_url":"https://api.github.com/repos/google/ggrc-core/pulls/3537/comments","review_comment_url":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ggrc-core/issues/3537/comments","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/ef3ea93fe6474643f1318b60e28636cff40b55ea","head":{"label":"edofic:feature/CORE-3076-relevant-revisions","ref":"feature/CORE-3076-relevant-revisions","sha":"ef3ea93fe6474643f1318b60e28636cff40b55ea","user":{"login":"edofic","id":597476,"avatar_url":"https://avatars.githubusercontent.com/u/597476?v=3","gravatar_id":"","url":"https://api.github.com/users/edofic","html_url":"https://github.com/edofic","followers_url":"https://api.github.com/users/edofic/followers","following_url":"https://api.github.com/users/edofic/following{/other_user}","gists_url":"https://api.github.com/users/edofic/gists{/gist_id}","starred_url":"https://api.github.com/users/edofic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edofic/subscriptions","organizations_url":"https://api.github.com/users/edofic/orgs","repos_url":"https://api.github.com/users/edofic/repos","events_url":"https://api.github.com/users/edofic/events{/privacy}","received_events_url":"https://api.github.com/users/edofic/received_events","type":"User","site_admin":false},"repo":{"id":36659264,"name":"ggrc-core","full_name":"edofic/ggrc-core","owner":{"login":"edofic","id":597476,"avatar_url":"https://avatars.githubusercontent.com/u/597476?v=3","gravatar_id":"","url":"https://api.github.com/users/edofic","html_url":"https://github.com/edofic","followers_url":"https://api.github.com/users/edofic/followers","following_url":"https://api.github.com/users/edofic/following{/other_user}","gists_url":"https://api.github.com/users/edofic/gists{/gist_id}","starred_url":"https://api.github.com/users/edofic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edofic/subscriptions","organizations_url":"https://api.github.com/users/edofic/orgs","repos_url":"https://api.github.com/users/edofic/repos","events_url":"https://api.github.com/users/edofic/events{/privacy}","received_events_url":"https://api.github.com/users/edofic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edofic/ggrc-core","description":"GGRC Core","fork":true,"url":"https://api.github.com/repos/edofic/ggrc-core","forks_url":"https://api.github.com/repos/edofic/ggrc-core/forks","keys_url":"https://api.github.com/repos/edofic/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edofic/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edofic/ggrc-core/teams","hooks_url":"https://api.github.com/repos/edofic/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/edofic/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/edofic/ggrc-core/events","assignees_url":"https://api.github.com/repos/edofic/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/edofic/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/edofic/ggrc-core/tags","blobs_url":"https://api.github.com/repos/edofic/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edofic/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edofic/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/edofic/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edofic/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/edofic/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/edofic/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/edofic/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/edofic/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/edofic/ggrc-core/subscription","commits_url":"https://api.github.com/repos/edofic/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/edofic/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/edofic/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/edofic/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/edofic/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/edofic/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edofic/ggrc-core/merges","archive_url":"https://api.github.com/repos/edofic/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edofic/ggrc-core/downloads","issues_url":"https://api.github.com/repos/edofic/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/edofic/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/edofic/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/edofic/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edofic/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/edofic/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/edofic/ggrc-core/deployments","created_at":"2015-06-01T12:28:36Z","updated_at":"2016-01-12T09:58:54Z","pushed_at":"2016-01-28T16:19:39Z","git_url":"git://github.com/edofic/ggrc-core.git","ssh_url":"git@github.com:edofic/ggrc-core.git","clone_url":"https://github.com/edofic/ggrc-core.git","svn_url":"https://github.com/edofic/ggrc-core","homepage":null,"size":48514,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"google:develop","ref":"develop","sha":"bdfefbc6c6a66e67626aa1f58838aa8d5e64f7ff","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":9304637,"name":"ggrc-core","full_name":"google/ggrc-core","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/ggrc-core","description":"GGRC Core","fork":false,"url":"https://api.github.com/repos/google/ggrc-core","forks_url":"https://api.github.com/repos/google/ggrc-core/forks","keys_url":"https://api.github.com/repos/google/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ggrc-core/teams","hooks_url":"https://api.github.com/repos/google/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/google/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/google/ggrc-core/events","assignees_url":"https://api.github.com/repos/google/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/google/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/google/ggrc-core/tags","blobs_url":"https://api.github.com/repos/google/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/google/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/google/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/google/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/google/ggrc-core/subscription","commits_url":"https://api.github.com/repos/google/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/google/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ggrc-core/merges","archive_url":"https://api.github.com/repos/google/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ggrc-core/downloads","issues_url":"https://api.github.com/repos/google/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/google/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/google/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/google/ggrc-core/deployments","created_at":"2013-04-08T19:16:28Z","updated_at":"2016-01-28T04:43:18Z","pushed_at":"2016-01-28T16:24:21Z","git_url":"git://github.com/google/ggrc-core.git","ssh_url":"git@github.com:google/ggrc-core.git","clone_url":"https://github.com/google/ggrc-core.git","svn_url":"https://github.com/google/ggrc-core","homepage":null,"size":55671,"stargazers_count":64,"watchers_count":64,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":18,"forks":42,"open_issues":18,"watchers":64,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/3537"},"html":{"href":"https://github.com/google/ggrc-core/pull/3537"},"issue":{"href":"https://api.github.com/repos/google/ggrc-core/issues/3537"},"comments":{"href":"https://api.github.com/repos/google/ggrc-core/issues/3537/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/3537/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/3537/commits"},"statuses":{"href":"https://api.github.com/repos/google/ggrc-core/statuses/ef3ea93fe6474643f1318b60e28636cff40b55ea"}}}}