{"action":"created","issue":{"url":"https://api.github.com/repos/D-Programming-Language/druntime/issues/1526","repository_url":"https://api.github.com/repos/D-Programming-Language/druntime","labels_url":"https://api.github.com/repos/D-Programming-Language/druntime/issues/1526/labels{/name}","comments_url":"https://api.github.com/repos/D-Programming-Language/druntime/issues/1526/comments","events_url":"https://api.github.com/repos/D-Programming-Language/druntime/issues/1526/events","html_url":"https://github.com/D-Programming-Language/druntime/pull/1526","id":143961730,"number":1526,"title":"TraceInfo: add a frames property","user":{"login":"tomerfiliba","id":53122,"avatar_url":"https://avatars.githubusercontent.com/u/53122?v=3","gravatar_id":"","url":"https://api.github.com/users/tomerfiliba","html_url":"https://github.com/tomerfiliba","followers_url":"https://api.github.com/users/tomerfiliba/followers","following_url":"https://api.github.com/users/tomerfiliba/following{/other_user}","gists_url":"https://api.github.com/users/tomerfiliba/gists{/gist_id}","starred_url":"https://api.github.com/users/tomerfiliba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomerfiliba/subscriptions","organizations_url":"https://api.github.com/users/tomerfiliba/orgs","repos_url":"https://api.github.com/users/tomerfiliba/repos","events_url":"https://api.github.com/users/tomerfiliba/events{/privacy}","received_events_url":"https://api.github.com/users/tomerfiliba/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-28T12:10:17Z","updated_at":"2016-03-28T13:08:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/druntime/pulls/1526","html_url":"https://github.com/D-Programming-Language/druntime/pull/1526","diff_url":"https://github.com/D-Programming-Language/druntime/pull/1526.diff","patch_url":"https://github.com/D-Programming-Language/druntime/pull/1526.patch"},"body":"http://forum.dlang.org/post/rqwxzjcyrccgzkbaqgsc@forum.dlang.org"},"comment":{"url":"https://api.github.com/repos/D-Programming-Language/druntime/issues/comments/202384851","html_url":"https://github.com/D-Programming-Language/druntime/pull/1526#issuecomment-202384851","issue_url":"https://api.github.com/repos/D-Programming-Language/druntime/issues/1526","id":202384851,"user":{"login":"Geod24","id":2180215,"avatar_url":"https://avatars.githubusercontent.com/u/2180215?v=3","gravatar_id":"","url":"https://api.github.com/users/Geod24","html_url":"https://github.com/Geod24","followers_url":"https://api.github.com/users/Geod24/followers","following_url":"https://api.github.com/users/Geod24/following{/other_user}","gists_url":"https://api.github.com/users/Geod24/gists{/gist_id}","starred_url":"https://api.github.com/users/Geod24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geod24/subscriptions","organizations_url":"https://api.github.com/users/Geod24/orgs","repos_url":"https://api.github.com/users/Geod24/repos","events_url":"https://api.github.com/users/Geod24/events{/privacy}","received_events_url":"https://api.github.com/users/Geod24/received_events","type":"User","site_admin":false},"created_at":"2016-03-28T13:08:49Z","updated_at":"2016-03-28T13:08:49Z","body":"An overload of `opApply` that expose a `Frame` would be better suited / encapsulated IMO.\r\n\r\nAlso, please :\r\n- provide a clear explanation on why this is needed as part of the commit message: when reading the history, it might not obvious why this is needed, and one would have to jump through various hoops to understand this change (commit -> P.R. -> forum post). Some of those steps might also not be available (because the user is offline / the reference is gone).\r\n- Add documentation for the new function(s) you add (at least for the base class, we should have a way to inherit documentation).\r\n- Add a `static assert` after `else version (Windows)` so that folks working with more platform will get a clear and loud \"Fix this\" message.\r\n\r\nFinally, it could also be worth adding a test, at least to make sure the behaviour is the same on all `Posix` platform (Which platform did you test this on?)."}}