{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/cli/issues/5041","repository_url":"https://api.github.com/repos/dotnet/cli","labels_url":"https://api.github.com/repos/dotnet/cli/issues/5041/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/cli/issues/5041/comments","events_url":"https://api.github.com/repos/dotnet/cli/issues/5041/events","html_url":"https://github.com/dotnet/cli/issues/5041","id":195930680,"number":5041,"title":"When migrating projects with a single tfm, dotnet migrate should not need to add DefineConstants property ","user":{"login":"balachir","id":8246794,"avatar_url":"https://avatars.githubusercontent.com/u/8246794?v=3","gravatar_id":"","url":"https://api.github.com/users/balachir","html_url":"https://github.com/balachir","followers_url":"https://api.github.com/users/balachir/followers","following_url":"https://api.github.com/users/balachir/following{/other_user}","gists_url":"https://api.github.com/users/balachir/gists{/gist_id}","starred_url":"https://api.github.com/users/balachir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balachir/subscriptions","organizations_url":"https://api.github.com/users/balachir/orgs","repos_url":"https://api.github.com/users/balachir/repos","events_url":"https://api.github.com/users/balachir/events{/privacy}","received_events_url":"https://api.github.com/users/balachir/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-12-15T22:16:02Z","updated_at":"2016-12-16T20:32:34Z","closed_at":null,"body":"## Steps to reproduce\r\nUsing VS 2017 RC.2 (CLI 1.0.0-preview4-004233)\r\ngit clone https://github.com/balaTest/ProjectKTestProjects\r\ncd Dev14_K101/Tooling202/AspNetCoreWebApp_OnCore_Empty_1\r\ndotnet migrate\r\n\r\n## Actual behavior\r\nThis PropertyGroup gets added to the csproj\r\n\r\n```\r\n  <PropertyGroup Condition=\" '$(Configuration)' == 'Release' \">\r\n    <DefineConstants>$(DefineConstants);RELEASE</DefineConstants>\r\n  </PropertyGroup>\r\n```\r\n\r\n## Expected  behavior\r\nAbove PropertyGroup should not be needed when the project is targeting a single tfm\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/cli/issues/comments/267689294","html_url":"https://github.com/dotnet/cli/issues/5041#issuecomment-267689294","issue_url":"https://api.github.com/repos/dotnet/cli/issues/5041","id":267689294,"user":{"login":"livarcocc","id":367554,"avatar_url":"https://avatars.githubusercontent.com/u/367554?v=3","gravatar_id":"","url":"https://api.github.com/users/livarcocc","html_url":"https://github.com/livarcocc","followers_url":"https://api.github.com/users/livarcocc/followers","following_url":"https://api.github.com/users/livarcocc/following{/other_user}","gists_url":"https://api.github.com/users/livarcocc/gists{/gist_id}","starred_url":"https://api.github.com/users/livarcocc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livarcocc/subscriptions","organizations_url":"https://api.github.com/users/livarcocc/orgs","repos_url":"https://api.github.com/users/livarcocc/repos","events_url":"https://api.github.com/users/livarcocc/events{/privacy}","received_events_url":"https://api.github.com/users/livarcocc/received_events","type":"User","site_admin":false},"created_at":"2016-12-16T20:32:34Z","updated_at":"2016-12-16T20:32:34Z","body":"I have created https://github.com/dotnet/sdk/issues/521 in the SDK. If they emit it there, then we can remove it from migration."}}
{"actor":{"display_login":"livarcocc"}}