{"action":"created","issue":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/issues/96","repository_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/issues/96/labels{/name}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/issues/96/comments","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/issues/96/events","html_url":"https://github.com/spring-cloud/spring-cloud-stream-app-starters/issues/96","id":155746657,"number":96,"title":"In the generated application rely on the default @SpringBootApplication scanBasePackages","user":{"login":"artembilan","id":1071590,"avatar_url":"https://avatars.githubusercontent.com/u/1071590?v=3","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-05-19T14:12:15Z","updated_at":"2016-12-15T03:41:48Z","closed_at":"2016-12-15T03:41:48Z","body":"Since we develop here micro-services, that should not be secret that one `main` class just with `@SpringBootApplication` does the entire trick around the target protocol-specific adapter (service). \nTypically it is just a single `@Configuration` class.\n\nI don't see reason to add extra `@Import`  in the generated `main` class, since we can just move the last one to the application package and rely on the `@ComponentScan`. Fully similar like we do in the apps tests.\nIt doesn't matter that we generate applications for different binders, we will use only one at runtime. So, the generate jar must have `@SpringBootApplication` on the top-level package to be able to pick up the app configs automatically without any extra manipulations for the generator config.\nPlus we will be free with naming for app `@Configuration`s.\n\nLet me know what I have missed here around that led you to follow with the `@Import` solution.\n"},"comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/issues/comments/267230732","html_url":"https://github.com/spring-cloud/spring-cloud-stream-app-starters/issues/96#issuecomment-267230732","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-app-starters/issues/96","id":267230732,"user":{"login":"sabbyanandan","id":1562654,"avatar_url":"https://avatars.githubusercontent.com/u/1562654?v=3","gravatar_id":"","url":"https://api.github.com/users/sabbyanandan","html_url":"https://github.com/sabbyanandan","followers_url":"https://api.github.com/users/sabbyanandan/followers","following_url":"https://api.github.com/users/sabbyanandan/following{/other_user}","gists_url":"https://api.github.com/users/sabbyanandan/gists{/gist_id}","starred_url":"https://api.github.com/users/sabbyanandan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabbyanandan/subscriptions","organizations_url":"https://api.github.com/users/sabbyanandan/orgs","repos_url":"https://api.github.com/users/sabbyanandan/repos","events_url":"https://api.github.com/users/sabbyanandan/events{/privacy}","received_events_url":"https://api.github.com/users/sabbyanandan/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T03:41:48Z","updated_at":"2016-12-15T03:41:48Z","body":"The binder is not included in the aggregate applications anymore. @artembilan - if you've any specific issue that you'd like to bring up, please create a separate ticket in the [release-train](https://github.com/spring-cloud-stream-app-starters/app-starters-release) repo. "}}
{"actor":{"display_login":"sabbyanandan"}}