{"action":"created","comment":{"url":"https://api.github.com/repos/GGist/ssdp-rs/pulls/comments/62409786","id":62409786,"diff_hunk":"@@ -6,37 +6,36 @@ use hyper::header::{HeaderFormat, Header};\n const SEARCHPORT_HEADER_NAME: &'static str = \"SEARCHPORT.UPNP.ORG\";\n \n pub const SEARCHPORT_MIN_VALUE: u16 = 49152;\n-pub const SEARCHPORT_MAX_VALUE: u16 = 65535;\n \n /// Represents a header used to specify a unicast port to send search requests to.\n ///\n-/// If a SearchPort header is not included in a message then the device must\n+/// If a `SearchPort` header is not included in a message then the device must\n /// respond to unicast search requests on the standard port of 1900.\n #[derive(Copy, Clone, PartialEq, Eq, Hash, Debug)]\n pub struct SearchPort(pub u16);\n \n-unsafe impl Sync for SearchPort { }\n+unsafe impl Sync for SearchPort {}\n \n-unsafe impl Send for SearchPort { }\n+unsafe impl Send for SearchPort {}\n \n impl Header for SearchPort {\n     fn header_name() -> &'static str {\n         SEARCHPORT_HEADER_NAME\n     }\n-    \n+\n     fn parse_header(raw: &[Vec<u8>]) -> error::Result<Self> {\n         if raw.len() != 1 {\n-            return Err(Error::Header)\n+            return Err(Error::Header);\n         }\n-        \n+\n         let cow_str = String::from_utf8_lossy(&raw[0][..]);\n-        \n+\n         let value = match u16::from_str_radix(&*cow_str, 10) {\n             Ok(n) => n,\n-            Err(_) => return Err(Error::Header)\n+            Err(_) => return Err(Error::Header),\n         };\n-        \n-        if value <= SEARCHPORT_MAX_VALUE && value >= SEARCHPORT_MIN_VALUE {\n+\n+        if value >= SEARCHPORT_MIN_VALUE {","path":"src/header/searchport.rs","position":44,"original_position":44,"commit_id":"f7218738d13336a0e652ab83c030af2a5fe5509e","original_commit_id":"f7218738d13336a0e652ab83c030af2a5fe5509e","user":{"login":"GGist","id":5248583,"avatar_url":"https://avatars.githubusercontent.com/u/5248583?v=3","gravatar_id":"","url":"https://api.github.com/users/GGist","html_url":"https://github.com/GGist","followers_url":"https://api.github.com/users/GGist/followers","following_url":"https://api.github.com/users/GGist/following{/other_user}","gists_url":"https://api.github.com/users/GGist/gists{/gist_id}","starred_url":"https://api.github.com/users/GGist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GGist/subscriptions","organizations_url":"https://api.github.com/users/GGist/orgs","repos_url":"https://api.github.com/users/GGist/repos","events_url":"https://api.github.com/users/GGist/events{/privacy}","received_events_url":"https://api.github.com/users/GGist/received_events","type":"User","site_admin":false},"body":"Haha, that was a good catch.","created_at":"2016-05-07T02:16:15Z","updated_at":"2016-05-07T02:16:15Z","html_url":"https://github.com/GGist/ssdp-rs/pull/20#discussion_r62409786","pull_request_url":"https://api.github.com/repos/GGist/ssdp-rs/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/GGist/ssdp-rs/pulls/comments/62409786"},"html":{"href":"https://github.com/GGist/ssdp-rs/pull/20#discussion_r62409786"},"pull_request":{"href":"https://api.github.com/repos/GGist/ssdp-rs/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/GGist/ssdp-rs/pulls/20","id":69094950,"html_url":"https://github.com/GGist/ssdp-rs/pull/20","diff_url":"https://github.com/GGist/ssdp-rs/pull/20.diff","patch_url":"https://github.com/GGist/ssdp-rs/pull/20.patch","issue_url":"https://api.github.com/repos/GGist/ssdp-rs/issues/20","number":20,"state":"open","locked":false,"title":"feat: Add Ipv6 support (#18)","user":{"login":"icorderi","id":2915919,"avatar_url":"https://avatars.githubusercontent.com/u/2915919?v=3","gravatar_id":"","url":"https://api.github.com/users/icorderi","html_url":"https://github.com/icorderi","followers_url":"https://api.github.com/users/icorderi/followers","following_url":"https://api.github.com/users/icorderi/following{/other_user}","gists_url":"https://api.github.com/users/icorderi/gists{/gist_id}","starred_url":"https://api.github.com/users/icorderi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icorderi/subscriptions","organizations_url":"https://api.github.com/users/icorderi/orgs","repos_url":"https://api.github.com/users/icorderi/repos","events_url":"https://api.github.com/users/icorderi/events{/privacy}","received_events_url":"https://api.github.com/users/icorderi/received_events","type":"User","site_admin":false},"body":"- removed `libc` dependency\r\n- added `net2` dependency\r\n\r\ncc:  #18","created_at":"2016-05-06T01:35:20Z","updated_at":"2016-05-07T02:16:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e65fce681f904dd86c50c925da356f13c68d60dc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GGist/ssdp-rs/pulls/20/commits","review_comments_url":"https://api.github.com/repos/GGist/ssdp-rs/pulls/20/comments","review_comment_url":"https://api.github.com/repos/GGist/ssdp-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GGist/ssdp-rs/issues/20/comments","statuses_url":"https://api.github.com/repos/GGist/ssdp-rs/statuses/f7218738d13336a0e652ab83c030af2a5fe5509e","head":{"label":"icorderi:feature/ipv6","ref":"feature/ipv6","sha":"f7218738d13336a0e652ab83c030af2a5fe5509e","user":{"login":"icorderi","id":2915919,"avatar_url":"https://avatars.githubusercontent.com/u/2915919?v=3","gravatar_id":"","url":"https://api.github.com/users/icorderi","html_url":"https://github.com/icorderi","followers_url":"https://api.github.com/users/icorderi/followers","following_url":"https://api.github.com/users/icorderi/following{/other_user}","gists_url":"https://api.github.com/users/icorderi/gists{/gist_id}","starred_url":"https://api.github.com/users/icorderi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icorderi/subscriptions","organizations_url":"https://api.github.com/users/icorderi/orgs","repos_url":"https://api.github.com/users/icorderi/repos","events_url":"https://api.github.com/users/icorderi/events{/privacy}","received_events_url":"https://api.github.com/users/icorderi/received_events","type":"User","site_admin":false},"repo":{"id":57931269,"name":"ssdp-rs","full_name":"icorderi/ssdp-rs","owner":{"login":"icorderi","id":2915919,"avatar_url":"https://avatars.githubusercontent.com/u/2915919?v=3","gravatar_id":"","url":"https://api.github.com/users/icorderi","html_url":"https://github.com/icorderi","followers_url":"https://api.github.com/users/icorderi/followers","following_url":"https://api.github.com/users/icorderi/following{/other_user}","gists_url":"https://api.github.com/users/icorderi/gists{/gist_id}","starred_url":"https://api.github.com/users/icorderi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icorderi/subscriptions","organizations_url":"https://api.github.com/users/icorderi/orgs","repos_url":"https://api.github.com/users/icorderi/repos","events_url":"https://api.github.com/users/icorderi/events{/privacy}","received_events_url":"https://api.github.com/users/icorderi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/icorderi/ssdp-rs","description":"Simple Service Discovery Protocol In Rust","fork":true,"url":"https://api.github.com/repos/icorderi/ssdp-rs","forks_url":"https://api.github.com/repos/icorderi/ssdp-rs/forks","keys_url":"https://api.github.com/repos/icorderi/ssdp-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/icorderi/ssdp-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/icorderi/ssdp-rs/teams","hooks_url":"https://api.github.com/repos/icorderi/ssdp-rs/hooks","issue_events_url":"https://api.github.com/repos/icorderi/ssdp-rs/issues/events{/number}","events_url":"https://api.github.com/repos/icorderi/ssdp-rs/events","assignees_url":"https://api.github.com/repos/icorderi/ssdp-rs/assignees{/user}","branches_url":"https://api.github.com/repos/icorderi/ssdp-rs/branches{/branch}","tags_url":"https://api.github.com/repos/icorderi/ssdp-rs/tags","blobs_url":"https://api.github.com/repos/icorderi/ssdp-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/icorderi/ssdp-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/icorderi/ssdp-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/icorderi/ssdp-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/icorderi/ssdp-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/icorderi/ssdp-rs/languages","stargazers_url":"https://api.github.com/repos/icorderi/ssdp-rs/stargazers","contributors_url":"https://api.github.com/repos/icorderi/ssdp-rs/contributors","subscribers_url":"https://api.github.com/repos/icorderi/ssdp-rs/subscribers","subscription_url":"https://api.github.com/repos/icorderi/ssdp-rs/subscription","commits_url":"https://api.github.com/repos/icorderi/ssdp-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/icorderi/ssdp-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/icorderi/ssdp-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/icorderi/ssdp-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/icorderi/ssdp-rs/contents/{+path}","compare_url":"https://api.github.com/repos/icorderi/ssdp-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/icorderi/ssdp-rs/merges","archive_url":"https://api.github.com/repos/icorderi/ssdp-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/icorderi/ssdp-rs/downloads","issues_url":"https://api.github.com/repos/icorderi/ssdp-rs/issues{/number}","pulls_url":"https://api.github.com/repos/icorderi/ssdp-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/icorderi/ssdp-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/icorderi/ssdp-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/icorderi/ssdp-rs/labels{/name}","releases_url":"https://api.github.com/repos/icorderi/ssdp-rs/releases{/id}","deployments_url":"https://api.github.com/repos/icorderi/ssdp-rs/deployments","created_at":"2016-05-03T01:02:45Z","updated_at":"2016-05-03T01:02:46Z","pushed_at":"2016-05-07T01:48:40Z","git_url":"git://github.com/icorderi/ssdp-rs.git","ssh_url":"git@github.com:icorderi/ssdp-rs.git","clone_url":"https://github.com/icorderi/ssdp-rs.git","svn_url":"https://github.com/icorderi/ssdp-rs","homepage":null,"size":4168,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GGist:master","ref":"master","sha":"ea3ce7bac7895125f48ab23c15ed5bd44c5acf43","user":{"login":"GGist","id":5248583,"avatar_url":"https://avatars.githubusercontent.com/u/5248583?v=3","gravatar_id":"","url":"https://api.github.com/users/GGist","html_url":"https://github.com/GGist","followers_url":"https://api.github.com/users/GGist/followers","following_url":"https://api.github.com/users/GGist/following{/other_user}","gists_url":"https://api.github.com/users/GGist/gists{/gist_id}","starred_url":"https://api.github.com/users/GGist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GGist/subscriptions","organizations_url":"https://api.github.com/users/GGist/orgs","repos_url":"https://api.github.com/users/GGist/repos","events_url":"https://api.github.com/users/GGist/events{/privacy}","received_events_url":"https://api.github.com/users/GGist/received_events","type":"User","site_admin":false},"repo":{"id":34912078,"name":"ssdp-rs","full_name":"GGist/ssdp-rs","owner":{"login":"GGist","id":5248583,"avatar_url":"https://avatars.githubusercontent.com/u/5248583?v=3","gravatar_id":"","url":"https://api.github.com/users/GGist","html_url":"https://github.com/GGist","followers_url":"https://api.github.com/users/GGist/followers","following_url":"https://api.github.com/users/GGist/following{/other_user}","gists_url":"https://api.github.com/users/GGist/gists{/gist_id}","starred_url":"https://api.github.com/users/GGist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GGist/subscriptions","organizations_url":"https://api.github.com/users/GGist/orgs","repos_url":"https://api.github.com/users/GGist/repos","events_url":"https://api.github.com/users/GGist/events{/privacy}","received_events_url":"https://api.github.com/users/GGist/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GGist/ssdp-rs","description":"Simple Service Discovery Protocol In Rust","fork":false,"url":"https://api.github.com/repos/GGist/ssdp-rs","forks_url":"https://api.github.com/repos/GGist/ssdp-rs/forks","keys_url":"https://api.github.com/repos/GGist/ssdp-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GGist/ssdp-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GGist/ssdp-rs/teams","hooks_url":"https://api.github.com/repos/GGist/ssdp-rs/hooks","issue_events_url":"https://api.github.com/repos/GGist/ssdp-rs/issues/events{/number}","events_url":"https://api.github.com/repos/GGist/ssdp-rs/events","assignees_url":"https://api.github.com/repos/GGist/ssdp-rs/assignees{/user}","branches_url":"https://api.github.com/repos/GGist/ssdp-rs/branches{/branch}","tags_url":"https://api.github.com/repos/GGist/ssdp-rs/tags","blobs_url":"https://api.github.com/repos/GGist/ssdp-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GGist/ssdp-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GGist/ssdp-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/GGist/ssdp-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GGist/ssdp-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/GGist/ssdp-rs/languages","stargazers_url":"https://api.github.com/repos/GGist/ssdp-rs/stargazers","contributors_url":"https://api.github.com/repos/GGist/ssdp-rs/contributors","subscribers_url":"https://api.github.com/repos/GGist/ssdp-rs/subscribers","subscription_url":"https://api.github.com/repos/GGist/ssdp-rs/subscription","commits_url":"https://api.github.com/repos/GGist/ssdp-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/GGist/ssdp-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/GGist/ssdp-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/GGist/ssdp-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/GGist/ssdp-rs/contents/{+path}","compare_url":"https://api.github.com/repos/GGist/ssdp-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GGist/ssdp-rs/merges","archive_url":"https://api.github.com/repos/GGist/ssdp-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GGist/ssdp-rs/downloads","issues_url":"https://api.github.com/repos/GGist/ssdp-rs/issues{/number}","pulls_url":"https://api.github.com/repos/GGist/ssdp-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/GGist/ssdp-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/GGist/ssdp-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GGist/ssdp-rs/labels{/name}","releases_url":"https://api.github.com/repos/GGist/ssdp-rs/releases{/id}","deployments_url":"https://api.github.com/repos/GGist/ssdp-rs/deployments","created_at":"2015-05-01T16:29:08Z","updated_at":"2016-05-05T14:27:10Z","pushed_at":"2016-05-07T01:51:01Z","git_url":"git://github.com/GGist/ssdp-rs.git","ssh_url":"git@github.com:GGist/ssdp-rs.git","clone_url":"https://github.com/GGist/ssdp-rs.git","svn_url":"https://github.com/GGist/ssdp-rs","homepage":null,"size":5886,"stargazers_count":7,"watchers_count":7,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GGist/ssdp-rs/pulls/20"},"html":{"href":"https://github.com/GGist/ssdp-rs/pull/20"},"issue":{"href":"https://api.github.com/repos/GGist/ssdp-rs/issues/20"},"comments":{"href":"https://api.github.com/repos/GGist/ssdp-rs/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/GGist/ssdp-rs/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/GGist/ssdp-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GGist/ssdp-rs/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/GGist/ssdp-rs/statuses/f7218738d13336a0e652ab83c030af2a5fe5509e"}}}}