{"action":"created","issue":{"url":"https://api.github.com/repos/dart-lang/co19/issues/62","repository_url":"https://api.github.com/repos/dart-lang/co19","labels_url":"https://api.github.com/repos/dart-lang/co19/issues/62/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/co19/issues/62/comments","events_url":"https://api.github.com/repos/dart-lang/co19/issues/62/events","html_url":"https://github.com/dart-lang/co19/issues/62","id":158244186,"number":62,"title":"LayoutTests/fast/forms/input-maxlength_t01 is incorrect","user":{"login":"hterkelsen","id":1961493,"avatar_url":"https://avatars.githubusercontent.com/u/1961493?v=3","gravatar_id":"","url":"https://api.github.com/users/hterkelsen","html_url":"https://github.com/hterkelsen","followers_url":"https://api.github.com/users/hterkelsen/followers","following_url":"https://api.github.com/users/hterkelsen/following{/other_user}","gists_url":"https://api.github.com/users/hterkelsen/gists{/gist_id}","starred_url":"https://api.github.com/users/hterkelsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hterkelsen/subscriptions","organizations_url":"https://api.github.com/users/hterkelsen/orgs","repos_url":"https://api.github.com/users/hterkelsen/repos","events_url":"https://api.github.com/users/hterkelsen/events{/privacy}","received_events_url":"https://api.github.com/users/hterkelsen/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"sgrekhov","id":4627088,"avatar_url":"https://avatars.githubusercontent.com/u/4627088?v=3","gravatar_id":"","url":"https://api.github.com/users/sgrekhov","html_url":"https://github.com/sgrekhov","followers_url":"https://api.github.com/users/sgrekhov/followers","following_url":"https://api.github.com/users/sgrekhov/following{/other_user}","gists_url":"https://api.github.com/users/sgrekhov/gists{/gist_id}","starred_url":"https://api.github.com/users/sgrekhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgrekhov/subscriptions","organizations_url":"https://api.github.com/users/sgrekhov/orgs","repos_url":"https://api.github.com/users/sgrekhov/repos","events_url":"https://api.github.com/users/sgrekhov/events{/privacy}","received_events_url":"https://api.github.com/users/sgrekhov/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-06-02T21:29:33Z","updated_at":"2016-06-03T10:21:47Z","closed_at":"2016-06-03T10:21:46Z","body":"The test contains:\r\n```dart\r\n  var implicitMaxLength = 524288;\r\n  ...\r\n  input = document.createElement(\"input\");\r\n  shouldBe(input.maxLength, implicitMaxLength);\r\n```\r\n\r\nHowever, on Chrome the maxLength for a new <input> element is -1. You can try it by doing this in a chrome console:\r\n```js\r\n> var i = document.createElement('input')\r\nundefined\r\n> i.maxLength\r\n-1\r\n```"},"comment":{"url":"https://api.github.com/repos/dart-lang/co19/issues/comments/223544370","html_url":"https://github.com/dart-lang/co19/issues/62#issuecomment-223544370","issue_url":"https://api.github.com/repos/dart-lang/co19/issues/62","id":223544370,"user":{"login":"sgrekhov","id":4627088,"avatar_url":"https://avatars.githubusercontent.com/u/4627088?v=3","gravatar_id":"","url":"https://api.github.com/users/sgrekhov","html_url":"https://github.com/sgrekhov","followers_url":"https://api.github.com/users/sgrekhov/followers","following_url":"https://api.github.com/users/sgrekhov/following{/other_user}","gists_url":"https://api.github.com/users/sgrekhov/gists{/gist_id}","starred_url":"https://api.github.com/users/sgrekhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgrekhov/subscriptions","organizations_url":"https://api.github.com/users/sgrekhov/orgs","repos_url":"https://api.github.com/users/sgrekhov/repos","events_url":"https://api.github.com/users/sgrekhov/events{/privacy}","received_events_url":"https://api.github.com/users/sgrekhov/received_events","type":"User","site_admin":false},"created_at":"2016-06-03T10:21:46Z","updated_at":"2016-06-03T10:21:46Z","body":"I fixed it but I don't like the fix. I'd prefer to delete this test at all. The behaviuor is browser-specific. HTML specification (https://www.w3.org/TR/html401/interact/forms.html) reads\r\n\r\n> maxlength = number [CN]\r\n> When the type attribute has the value \"text\" or \"password\", this attribute specifies the maximum number of characters the user may enter. This number may exceed the specified size, in which case the user agent should offer a scrolling mechanism. The default value for this attribute is an unlimited number.\r\n\r\nIn fact if maxlength attribute not specified then Chrome and FF return -1, Dartium still returns 512K (524288). Then test checks different values of maxlength and different lengths of input value. Here behaviour again is browser specific. Chrome and Dartium cut input's value to be not longer than 512K, FF doesn't have this limitation.\r\n\r\nSo I removed check for default input maxlength value and check for stringl longer than 512K. This is not specified, so I believe it's ok to not to check it. Now test works in Dartium, FF and Chrome.\r\n\r\nIn general, this test was originally written as Webkit tests and then ported to Dart. It's not good to use Webkit-specific tests in multiple-browser test suite. That's why I'd prefer to delete it at all. But.. Let's leave it for now. \r\n\r\nSee 154ead3819e3756f4a0bc874e39935b3d02075b8 and 82e0b06cfa3bf88754e01e71bd993de9385eff5f"}}
{"actor":{"display_login":"sgrekhov"}}