{"push_id":1197122907,"size":1000,"distinct_size":2,"ref":"refs/heads/master","head":"fa2e969a15ad11d045d41a990f5c826abef13e97","before":"e330d7458326ebb71584f9d2daabc802ad5a21a4","commits":[{"sha":"43b8581d72525b2275395770a44b1e88e42a8bfc","author":{"name":"Chad Little","email":"309b338a702206971e2989de6d1d8db3503bf8c3@chadsdomain.com"},"message":"Fix some spelling errors in Icons\n\nSummary: Some minor spelling mistakes.\n\nTest Plan: Read\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15122","distinct":false,"url":"https://api.github.com/repos/abdul/phabricator/commits/43b8581d72525b2275395770a44b1e88e42a8bfc"},{"sha":"36158dbdc0810efd5e44135fea5b61840a332aad","author":{"name":"Chad Little","email":"309b338a702206971e2989de6d1d8db3503bf8c3@chadsdomain.com"},"message":"Convert all calls to 'IconFont' to just 'Icon'\n\nSummary: Mostly for consistency, we're not using other forms of icons and this makes all classes that use an icon call it in the same way.\n\nTest Plan: tested uiexamples, lots of other random pages.\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15125","distinct":false,"url":"https://api.github.com/repos/abdul/phabricator/commits/36158dbdc0810efd5e44135fea5b61840a332aad"},{"sha":"8900f363266ebbcba1c7e2cf32d409466fd866b2","author":{"name":"Chad Little","email":"309b338a702206971e2989de6d1d8db3503bf8c3@chadsdomain.com"},"message":"Fix backdrop color\n\nSummary: All our builtin images use #c4cde0 for the backdrop. This makes generation match the builtins.\n\nTest Plan:\nBuild a new bug icon in Maniphest\n\n{F1077934}\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15126","distinct":false,"url":"https://api.github.com/repos/abdul/phabricator/commits/8900f363266ebbcba1c7e2cf32d409466fd866b2"},{"sha":"c00cd5c2a31e22cfdbe8c39cce2242a1f0e0df94","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Make hidden and locked configuration even more explicit\n\nSummary:\nA user in IRC seemed very confused by this, and worked extremely hard to shoot themsevles in the foot by manually writing locked configuration to the database.\n\nTry to explain why configuration is locked better.\n\nTest Plan:\nMostly reading.\n\n{F1078905}\n\n{F1078906}\n\nReviewers: chad\n\nReviewed By: chad\n\nDifferential Revision: https://secure.phabricator.com/D15128","distinct":false,"url":"https://api.github.com/repos/abdul/phabricator/commits/c00cd5c2a31e22cfdbe8c39cce2242a1f0e0df94"},{"sha":"30473549acfbcaecb822d0d7fffb3d3ffd7c7a0e","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Add a basic pull event log for debugging repository cloning\n\nSummary:\nRef T10228. This is currently quite limited:\n\n  - No UI.\n  - No SSH support.\n\nMy primary goal is to debug the issue in T10228. In the long run we can expand this to be a bit fancier.\n\nTest Plan:\nMade various valid and invalid clones, got sucess responses and not-so-successful responses, viewed the log table for general corresponding messages and broad sanity.\n\nRan GC via `bin/phd debug trigger`, no issues.\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T10228\n\nDifferential Revision: https://secure.phabricator.com/D15127","distinct":false,"url":"https://api.github.com/repos/abdul/phabricator/commits/30473549acfbcaecb822d0d7fffb3d3ffd7c7a0e"},{"sha":"fe5cd4ca2c77ccd06de990dfb9056b3f5186fd79","author":{"name":"Chad Little","email":"309b338a702206971e2989de6d1d8db3503bf8c3@chadsdomain.com"},"message":"Move FontIcon calls to Icon\n\nSummary: Normalizes all `setFontIcon` calls to `setIcon`.\n\nTest Plan: UIExamples, Almanac, Apps list, etc.\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin, hach-que, yelirekim\n\nDifferential Revision: https://secure.phabricator.com/D15129","distinct":false,"url":"https://api.github.com/repos/abdul/phabricator/commits/fe5cd4ca2c77ccd06de990dfb9056b3f5186fd79"},{"sha":"8f0d9c329566fcbab6c2c911bfddb15fdfee53cc","author":{"name":"Aviv Eyal","email":"468b64370a58fd00f0fb5d8b9c2c2019cc6b7d79@gmail.com"},"message":"Remove email prefixes from doorkeeper titles\n\nSummary: Fixes T10176. The prefix is not useful in the JIRA context, and doubtfully useful in Asana.\n\nTest Plan: Load, make comment on revision, see link in JIRA is pretty.\n\nReviewers: #blessed_reviewers, epriestley\n\nReviewed By: #blessed_reviewers, epriestley\n\nSubscribers: Korvin\n\nManiphest Tasks: T10176\n\nDifferential Revision: https://secure.phabricator.com/D15119","distinct":false,"url":"https://api.github.com/repos/abdul/phabricator/commits/8f0d9c329566fcbab6c2c911bfddb15fdfee53cc"},{"sha":"a5f62235537d0fdf122f27b95f1318c26fe7fcf1","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Show blame colors on all lines, instead of only the first affected line\n\nSummary: Fixes T10226. I just made a mistake here when rewriting this recently.\n\nTest Plan: {F1079166}\n\nReviewers: chad, avivey\n\nReviewed By: avivey\n\nManiphest Tasks: T10226\n\nDifferential Revision: https://secure.phabricator.com/D15131","distinct":false,"url":"https://api.github.com/repos/abdul/phabricator/commits/a5f62235537d0fdf122f27b95f1318c26fe7fcf1"},{"sha":"5e639feab40e3581cab90608090e70eb717c458a","author":{"name":"Chad Little","email":"309b338a702206971e2989de6d1d8db3503bf8c3@chadsdomain.com"},"message":"Minor tweaks to Profile/Project\n\nSummary:\n- Redirect to profileview when new image is uploaded.\n- Add ProfileNav to EditPicture on Profile\n- Add ProfileNav to EditProfile on Profile\n\nTest Plan: Set new images on Profiles and Projects. See new redirect. See new navs.\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15132","distinct":false,"url":"https://api.github.com/repos/abdul/phabricator/commits/5e639feab40e3581cab90608090e70eb717c458a"},{"sha":"e4372e1276fddc5c19ae904062f86d625d10eaa4","author":{"name":"Chad Little","email":"309b338a702206971e2989de6d1d8db3503bf8c3@chadsdomain.com"},"message":"Add some additional padding before footer on profiles\n\nSummary: Spaces out the page a little better if there is no information on  it.\n\nTest Plan: review a profile and a project home\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15134","distinct":false,"url":"https://api.github.com/repos/abdul/phabricator/commits/e4372e1276fddc5c19ae904062f86d625d10eaa4"},{"sha":"dbf1d0d7210ff447264925af34a6215cc64701ea","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Improve reliability of detecting small devices when loading Differential changesets\n\nSummary: Ref T10229. Fixes T9969. We make a decision about 1up vs 2up pretty early, and sometimes the viewport size reads as larger than the device, so we incorrectly select 2up when the proper setting would be 1up.\n\nTest Plan:\nI can reproduce this by, e.g., reloading a lot on an iPhone 4s in iOS Simulator running iOS 9.2. Sometimes it picks 2-up. I added logging to show that the viewport dimension read was the issue.\n\nAfter this change, it always selects 1-up (`window.screen.availWidth` is defined and sensible on the device).\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T9969, T10229\n\nDifferential Revision: https://secure.phabricator.com/D15135","distinct":false,"url":"https://api.github.com/repos/abdul/phabricator/commits/dbf1d0d7210ff447264925af34a6215cc64701ea"},{"sha":"bf43d4cf2aa6c477da29a5de6a9bd78ee87683e2","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Don't mutate DOM on touch-originated cursor events in Differential\n\nSummary:\nFixes T10229. Broadly:\n\n  - When the user hovers over a line number or inline comment, we update the yellow reticle to highlight the relevant lines. Specifically, this is in response to a `mouseover` event.\n  - On touch devices, touches fire `mouseover` and if you mutate the DOM inside the event, the device aborts the touch.\n\nTo remedy this:\n\n  - Distingiush between mouse-originated and touch-originated cursor events.\n    - We do this, roughly, by setting a flag when we see \"touchstart\", and clearing it when we see the second copy of any unique cursor event.\n    - This method is complex, but should be robust to any implementation differences between devices (for example, it will work no matter which order the events are fired in).\n    - This method should also produce the correct results on weird devices that have both mouse-devices and touch-devices available for cursor input.\n  - When we see a touch-originated `mouseover` or `mouseout`, don't mutate the DOM.\n  - Put an extra DOM mutation into the `click` event to improve highlighting behavior on touch devices.\n\nTest Plan:\n  - In iOS Simulator (4s, iOS 9.2), clicked various inline actions (\"Reply\", \"Hide\", \"Done\", \"Cancel\", line numbers, etc). Got responses after a single touch.\n  - Verified hover + click behavior on a desktop.\n  - Logged and examined a bunch of events as a general sanity check.\n\nReviewers: chad\n\nReviewed By: chad\n\nSubscribers: aljungberg\n\nManiphest Tasks: T10229\n\nDifferential Revision: https://secure.phabricator.com/D15136","distinct":false,"url":"https://api.github.com/repos/abdul/phabricator/commits/bf43d4cf2aa6c477da29a5de6a9bd78ee87683e2"},{"sha":"4d498466c303d4e1083c532600e790e012ab9099","author":{"name":"Chad Little","email":"309b338a702206971e2989de6d1d8db3503bf8c3@chadsdomain.com"},"message":"Rework Workboard Cards, split up CSS\n\nSummary: Moves CSS into 3 files, Boards, Panels, Cards. Cleans up Workcards to present more info, hide edit until card hover.\n\nTest Plan:\nLots of photoshop. Verify links to edit still work.\n\n{F1081276}\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15137","distinct":false,"url":"https://api.github.com/repos/abdul/phabricator/commits/4d498466c303d4e1083c532600e790e012ab9099"},{"sha":"33e9033b99f3acf21f48ec39389f941df4abbf0d","author":{"name":"Chad Little","email":"309b338a702206971e2989de6d1d8db3503bf8c3@chadsdomain.com"},"message":"Fix white corner bleed on workcards\n\nSummary: There is a hair of #fff hanging out on the right side, round it a bit.\n\nTest Plan: ZOOOOM IN on a Workboard\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15138","distinct":false,"url":"https://api.github.com/repos/abdul/phabricator/commits/33e9033b99f3acf21f48ec39389f941df4abbf0d"},{"sha":"27e21b0107da69bd82cfbd50390824a6de8d0a6e","author":{"name":"Chad Little","email":"309b338a702206971e2989de6d1d8db3503bf8c3@chadsdomain.com"},"message":"Remove PHUITextView\n\nSummary: Never used.\n\nTest Plan: grep `PHUITextView`\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15139","distinct":false,"url":"https://api.github.com/repos/abdul/phabricator/commits/27e21b0107da69bd82cfbd50390824a6de8d0a6e"},{"sha":"b8139e6946eac71741a10e76cf2e5c27c757ff69","author":{"name":"Chad Little","email":"309b338a702206971e2989de6d1d8db3503bf8c3@chadsdomain.com"},"message":"Add basic fields back to Manage pages\n\nSummary: It feels wierd to edit a project or profile and not see the changes. For now add them back to the Manage page.\n\nTest Plan: Edit a Profile, Edit a Project. See updates on Manage page.\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15140","distinct":false,"url":"https://api.github.com/repos/abdul/phabricator/commits/b8139e6946eac71741a10e76cf2e5c27c757ff69"},{"sha":"8c3f355a95431acd424599407d0dba3d11449e67","author":{"name":"Chad Little","email":"309b338a702206971e2989de6d1d8db3503bf8c3@chadsdomain.com"},"message":"Move code examples in remarkup to grey backgrounds\n\nSummary: This should make code easier to read. Right now large blocks get a really bright treatment, and this should tone it down. Also upped the spacing a bit.\n\nTest Plan:\nReview Remarkup Examples from Diviner, also some test code blocks and counter examples.\n\n{F1081606}\n\n{F1081607}\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nDifferential Revision: https://secure.phabricator.com/D15141","distinct":false,"url":"https://api.github.com/repos/abdul/phabricator/commits/8c3f355a95431acd424599407d0dba3d11449e67"},{"sha":"41262150dfb5fb55ae822abdc194b3a13437d92f","author":{"name":"Chad Little","email":"309b338a702206971e2989de6d1d8db3503bf8c3@chadsdomain.com"},"message":"Remove unused call to phui-text\n\nSummary: I can't find any reference to these used. Fixes T10244\n\nTest Plan: Grep for \"phui-text\" and \"PHUI::TEXT\"\n\nReviewers: epriestley\n\nReviewed By: epriestley\n\nSubscribers: Korvin\n\nManiphest Tasks: T10244\n\nDifferential Revision: https://secure.phabricator.com/D15142","distinct":false,"url":"https://api.github.com/repos/abdul/phabricator/commits/41262150dfb5fb55ae822abdc194b3a13437d92f"},{"sha":"e5947e08d389acd41ee2046fef707cc02b04fe6a","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Apply phutil_utf8ize() to stderr output from VCS commands prior to logging\n\nSummary: Ref T10228. Commands like `git-http-backend` can emit errors with raw bytes in the output. Sanitize these if present so we can log them in JSON format.\n\nTest Plan: Edited this into production. >_> sneaky sneaky <_<\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T10228\n\nDifferential Revision: https://secure.phabricator.com/D15144","distinct":false,"url":"https://api.github.com/repos/abdul/phabricator/commits/e5947e08d389acd41ee2046fef707cc02b04fe6a"},{"sha":"8269fd6e6c1f8f03f1645215c5748e794cc8486c","author":{"name":"epriestley","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@epriestley.com"},"message":"Decode \"Content-Encoding: gzip\" content\n\nSummary:\nFixes T10228. When we receive a gzipped request (rare, but `git` may send them), decode it before providing it to the application.\n\nThis fixes the issue with proxying certain requests described in T10228.\n\nTest Plan:\n  - Applied this fix in production.\n  - Cloned a problem repository cleanly.\n\nReviewers: chad\n\nReviewed By: chad\n\nManiphest Tasks: T10228\n\nDifferential Revision: https://secure.phabricator.com/D15145","distinct":false,"url":"https://api.github.com/repos/abdul/phabricator/commits/8269fd6e6c1f8f03f1645215c5748e794cc8486c"}]}
{"actor":{"display_login":"abdul"}}