{"action":"created","issue":{"url":"https://api.github.com/repos/PHPOffice/PHPWord/issues/966","repository_url":"https://api.github.com/repos/PHPOffice/PHPWord","labels_url":"https://api.github.com/repos/PHPOffice/PHPWord/issues/966/labels{/name}","comments_url":"https://api.github.com/repos/PHPOffice/PHPWord/issues/966/comments","events_url":"https://api.github.com/repos/PHPOffice/PHPWord/issues/966/events","html_url":"https://github.com/PHPOffice/PHPWord/pull/966","id":196695425,"number":966,"title":"Add metadata for w:trackRevisions setting","user":{"login":"chris-fa","id":22173137,"avatar_url":"https://avatars.githubusercontent.com/u/22173137?v=3","gravatar_id":"","url":"https://api.github.com/users/chris-fa","html_url":"https://github.com/chris-fa","followers_url":"https://api.github.com/users/chris-fa/followers","following_url":"https://api.github.com/users/chris-fa/following{/other_user}","gists_url":"https://api.github.com/users/chris-fa/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-fa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-fa/subscriptions","organizations_url":"https://api.github.com/users/chris-fa/orgs","repos_url":"https://api.github.com/users/chris-fa/repos","events_url":"https://api.github.com/users/chris-fa/events{/privacy}","received_events_url":"https://api.github.com/users/chris-fa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-20T15:06:49Z","updated_at":"2016-12-20T15:13:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PHPOffice/PHPWord/pulls/966","html_url":"https://github.com/PHPOffice/PHPWord/pull/966","diff_url":"https://github.com/PHPOffice/PHPWord/pull/966.diff","patch_url":"https://github.com/PHPOffice/PHPWord/pull/966.patch"},"body":"### Description\r\nAdds a metadata class `Revisions` that let's the user enable `w:trackRevisions` on the `word/settings.xml` file\r\n\r\n### Reason\r\nThe settings writer didn't have a way to enable the setting for tracking revisions\r\n\r\n### Impact\r\nUsers can now enable track revisions option\r\n\r\n### Issue\r\nIssue #622 \r\n\r\n### Checklist\r\n[X] Did I write tests for this change?\r\n[ ] Is documentation complete?"},"comment":{"url":"https://api.github.com/repos/PHPOffice/PHPWord/issues/comments/268267954","html_url":"https://github.com/PHPOffice/PHPWord/pull/966#issuecomment-268267954","issue_url":"https://api.github.com/repos/PHPOffice/PHPWord/issues/966","id":268267954,"user":{"login":"rvanlaak","id":2707563,"avatar_url":"https://avatars.githubusercontent.com/u/2707563?v=3","gravatar_id":"","url":"https://api.github.com/users/rvanlaak","html_url":"https://github.com/rvanlaak","followers_url":"https://api.github.com/users/rvanlaak/followers","following_url":"https://api.github.com/users/rvanlaak/following{/other_user}","gists_url":"https://api.github.com/users/rvanlaak/gists{/gist_id}","starred_url":"https://api.github.com/users/rvanlaak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvanlaak/subscriptions","organizations_url":"https://api.github.com/users/rvanlaak/orgs","repos_url":"https://api.github.com/users/rvanlaak/repos","events_url":"https://api.github.com/users/rvanlaak/events{/privacy}","received_events_url":"https://api.github.com/users/rvanlaak/received_events","type":"User","site_admin":false},"created_at":"2016-12-20T15:13:33Z","updated_at":"2016-12-20T15:13:33Z","body":"Nice! Our use case was to actually write the settings, so did something like this:\r\n\r\n```php\r\npublic function setProofState(\\SimpleXMLElement $settings)\r\n{\r\n    $settings = $this->unsetByXpath($settings, 'w:proofState');\r\n\r\n    $proofState = $settings->addChild('w:proofState');\r\n    $proofState->addAttribute('w:spelling', 'dirty', self::NS);\r\n    $proofState->addAttribute('w:grammar', 'dirty', self::NS);\r\n\r\n    return $settings;\r\n}\r\n```\r\n\r\nUnfortunately I think making a writer is outside of the scope of this project (ping @Progi1984 )."}}
{"actor":{"display_login":"rvanlaak"}}