{"action":"created","issue":{"url":"https://api.github.com/repos/KartikTalwar/gmail.js/issues/337","repository_url":"https://api.github.com/repos/KartikTalwar/gmail.js","labels_url":"https://api.github.com/repos/KartikTalwar/gmail.js/issues/337/labels{/name}","comments_url":"https://api.github.com/repos/KartikTalwar/gmail.js/issues/337/comments","events_url":"https://api.github.com/repos/KartikTalwar/gmail.js/issues/337/events","html_url":"https://github.com/KartikTalwar/gmail.js/pull/337","id":191266880,"number":337,"title":"start parameter calculation change at visible_emails_pre function","user":{"login":"avzabr","id":17640566,"avatar_url":"https://avatars.githubusercontent.com/u/17640566?v=3","gravatar_id":"","url":"https://api.github.com/users/avzabr","html_url":"https://github.com/avzabr","followers_url":"https://api.github.com/users/avzabr/followers","following_url":"https://api.github.com/users/avzabr/following{/other_user}","gists_url":"https://api.github.com/users/avzabr/gists{/gist_id}","starred_url":"https://api.github.com/users/avzabr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avzabr/subscriptions","organizations_url":"https://api.github.com/users/avzabr/orgs","repos_url":"https://api.github.com/users/avzabr/repos","events_url":"https://api.github.com/users/avzabr/events{/privacy}","received_events_url":"https://api.github.com/users/avzabr/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-11-23T13:12:18Z","updated_at":"2016-11-24T08:54:09Z","closed_at":"2016-11-24T08:53:01Z","pull_request":{"url":"https://api.github.com/repos/KartikTalwar/gmail.js/pulls/337","html_url":"https://github.com/KartikTalwar/gmail.js/pull/337","diff_url":"https://github.com/KartikTalwar/gmail.js/pull/337.diff","patch_url":"https://github.com/KartikTalwar/gmail.js/pull/337.patch"},"body":"The markup for email's pagination has been changed at gmail recently:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/17640566/20562988/855ac42a-b197-11e6-8545-864c34f6ff5d.png)\r\n\r\nWas:\r\n`<span class=\"Dj\"><b>111</b>–<b>114</b> of <b>114</b></span>`\r\nNew:\r\n`<span class=\"Dj\"><span class=\"ts\">111</span>–<span class=\"ts\">114</span> of <span class=\"ts\">114</span></span>`\r\n\r\nAlso if there are more than 1000 emails the number may be \"1,234\". The ` .replace(\",\", \"\")` has been added to fix it. \r\n\r\nNote: i don't know why we need duplicated start parameter. "},"comment":{"url":"https://api.github.com/repos/KartikTalwar/gmail.js/issues/comments/262722137","html_url":"https://github.com/KartikTalwar/gmail.js/pull/337#issuecomment-262722137","issue_url":"https://api.github.com/repos/KartikTalwar/gmail.js/issues/337","id":262722137,"user":{"login":"Navega","id":16117077,"avatar_url":"https://avatars.githubusercontent.com/u/16117077?v=3","gravatar_id":"","url":"https://api.github.com/users/Navega","html_url":"https://github.com/Navega","followers_url":"https://api.github.com/users/Navega/followers","following_url":"https://api.github.com/users/Navega/following{/other_user}","gists_url":"https://api.github.com/users/Navega/gists{/gist_id}","starred_url":"https://api.github.com/users/Navega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Navega/subscriptions","organizations_url":"https://api.github.com/users/Navega/orgs","repos_url":"https://api.github.com/users/Navega/repos","events_url":"https://api.github.com/users/Navega/events{/privacy}","received_events_url":"https://api.github.com/users/Navega/received_events","type":"User","site_admin":false},"created_at":"2016-11-24T08:54:08Z","updated_at":"2016-11-24T08:54:08Z","body":"Hi guys,\r\n\r\nI have been debugging the problem. Gmail modifies its structure continuously. My commit does not work because Gmail replaces label \"<b>\" with \"<span>\" where number of offset page is positionated. I used 2 parameters: \"start\" and \"sstart\" because they depend of the used version. Older versions used the parameter **\"start\"**, but now the correct parameter is **\"sstart\"** to ask mails with offset.\r\n\r\nCertainly. good catch with offset > 1.000, thanks!\r\n\r\nDo you agree?"}}
{"actor":{"display_login":"Navega"}}