{"action":"created","comment":{"url":"https://api.github.com/repos/conda-forge/cmake-feedstock/pulls/comments/94081758","pull_request_review_id":14612442,"id":94081758,"diff_hunk":"@@ -1,4 +1,11 @@\n-move bin\\* %LIBRARY_BIN%\\\n+REM Move only desired files as the downloaded package contains even Qt5 dlls\n+move bin\\cmake.exe %LIBRARY_BIN%\\\n+move bin\\cmcldeps.exe %LIBRARY_BIN%\\\n+move bin\\cpack.exe %LIBRARY_BIN%\\\n+move bin\\ctest.exe %LIBRARY_BIN%\\\n+move bin\\msvcp120.dll %LIBRARY_BIN%\\","path":"recipe/bld.bat","position":null,"original_position":7,"commit_id":"e45a5daad8118f644850c7599f3a50abdf3039ce","original_commit_id":"a4e898e87b4d0290f25b2adceb6c6d166cc15ec4","user":{"login":"isuruf","id":5234427,"avatar_url":"https://avatars.githubusercontent.com/u/5234427?v=3","gravatar_id":"","url":"https://api.github.com/users/isuruf","html_url":"https://github.com/isuruf","followers_url":"https://api.github.com/users/isuruf/followers","following_url":"https://api.github.com/users/isuruf/following{/other_user}","gists_url":"https://api.github.com/users/isuruf/gists{/gist_id}","starred_url":"https://api.github.com/users/isuruf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isuruf/subscriptions","organizations_url":"https://api.github.com/users/isuruf/orgs","repos_url":"https://api.github.com/users/isuruf/repos","events_url":"https://api.github.com/users/isuruf/events{/privacy}","received_events_url":"https://api.github.com/users/isuruf/received_events","type":"User","site_admin":false},"body":"DLL mentioned is from MSVC 12.0 redistributable package. Are you sure these are there by default on systems without visual studio installed?","created_at":"2016-12-28T21:55:44Z","updated_at":"2016-12-28T21:55:44Z","html_url":"https://github.com/conda-forge/cmake-feedstock/pull/26#discussion_r94081758","pull_request_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/conda-forge/cmake-feedstock/pulls/comments/94081758"},"html":{"href":"https://github.com/conda-forge/cmake-feedstock/pull/26#discussion_r94081758"},"pull_request":{"href":"https://api.github.com/repos/conda-forge/cmake-feedstock/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/conda-forge/cmake-feedstock/pulls/26","id":99589458,"html_url":"https://github.com/conda-forge/cmake-feedstock/pull/26","diff_url":"https://github.com/conda-forge/cmake-feedstock/pull/26.diff","patch_url":"https://github.com/conda-forge/cmake-feedstock/pull/26.patch","issue_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/issues/26","number":26,"state":"closed","locked":false,"title":"Don't include Qt5 dlls on Windows","user":{"login":"gqmelo","id":12578273,"avatar_url":"https://avatars.githubusercontent.com/u/12578273?v=3","gravatar_id":"","url":"https://api.github.com/users/gqmelo","html_url":"https://github.com/gqmelo","followers_url":"https://api.github.com/users/gqmelo/followers","following_url":"https://api.github.com/users/gqmelo/following{/other_user}","gists_url":"https://api.github.com/users/gqmelo/gists{/gist_id}","starred_url":"https://api.github.com/users/gqmelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gqmelo/subscriptions","organizations_url":"https://api.github.com/users/gqmelo/orgs","repos_url":"https://api.github.com/users/gqmelo/repos","events_url":"https://api.github.com/users/gqmelo/events{/privacy}","received_events_url":"https://api.github.com/users/gqmelo/received_events","type":"User","site_admin":false},"body":"This was conflicting with Qt5 packages, essentially replacing\r\nthe files and causing crashes.","created_at":"2016-12-28T20:28:48Z","updated_at":"2016-12-28T21:55:44Z","closed_at":"2016-12-28T21:51:00Z","merged_at":"2016-12-28T21:51:00Z","merge_commit_sha":"0eb02f627a6859bce1647604b9f75c13b8ab53d9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/pulls/26/commits","review_comments_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/pulls/26/comments","review_comment_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/issues/26/comments","statuses_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/statuses/e45a5daad8118f644850c7599f3a50abdf3039ce","head":{"label":"gqmelo:no-qt5-dlls","ref":"no-qt5-dlls","sha":"e45a5daad8118f644850c7599f3a50abdf3039ce","user":{"login":"gqmelo","id":12578273,"avatar_url":"https://avatars.githubusercontent.com/u/12578273?v=3","gravatar_id":"","url":"https://api.github.com/users/gqmelo","html_url":"https://github.com/gqmelo","followers_url":"https://api.github.com/users/gqmelo/followers","following_url":"https://api.github.com/users/gqmelo/following{/other_user}","gists_url":"https://api.github.com/users/gqmelo/gists{/gist_id}","starred_url":"https://api.github.com/users/gqmelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gqmelo/subscriptions","organizations_url":"https://api.github.com/users/gqmelo/orgs","repos_url":"https://api.github.com/users/gqmelo/repos","events_url":"https://api.github.com/users/gqmelo/events{/privacy}","received_events_url":"https://api.github.com/users/gqmelo/received_events","type":"User","site_admin":false},"repo":{"id":77559126,"name":"cmake-feedstock","full_name":"gqmelo/cmake-feedstock","owner":{"login":"gqmelo","id":12578273,"avatar_url":"https://avatars.githubusercontent.com/u/12578273?v=3","gravatar_id":"","url":"https://api.github.com/users/gqmelo","html_url":"https://github.com/gqmelo","followers_url":"https://api.github.com/users/gqmelo/followers","following_url":"https://api.github.com/users/gqmelo/following{/other_user}","gists_url":"https://api.github.com/users/gqmelo/gists{/gist_id}","starred_url":"https://api.github.com/users/gqmelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gqmelo/subscriptions","organizations_url":"https://api.github.com/users/gqmelo/orgs","repos_url":"https://api.github.com/users/gqmelo/repos","events_url":"https://api.github.com/users/gqmelo/events{/privacy}","received_events_url":"https://api.github.com/users/gqmelo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gqmelo/cmake-feedstock","description":"A conda-smithy repository for cmake.","fork":true,"url":"https://api.github.com/repos/gqmelo/cmake-feedstock","forks_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/forks","keys_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/teams","hooks_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/hooks","issue_events_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/issues/events{/number}","events_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/events","assignees_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/assignees{/user}","branches_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/branches{/branch}","tags_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/tags","blobs_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/git/refs{/sha}","trees_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/statuses/{sha}","languages_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/languages","stargazers_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/stargazers","contributors_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/contributors","subscribers_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/subscribers","subscription_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/subscription","commits_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/commits{/sha}","git_commits_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/git/commits{/sha}","comments_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/comments{/number}","issue_comment_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/issues/comments{/number}","contents_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/contents/{+path}","compare_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/merges","archive_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/downloads","issues_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/issues{/number}","pulls_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/pulls{/number}","milestones_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/milestones{/number}","notifications_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/labels{/name}","releases_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/releases{/id}","deployments_url":"https://api.github.com/repos/gqmelo/cmake-feedstock/deployments","created_at":"2016-12-28T20:22:29Z","updated_at":"2016-12-28T20:22:31Z","pushed_at":"2016-12-28T21:10:55Z","git_url":"git://github.com/gqmelo/cmake-feedstock.git","ssh_url":"git@github.com:gqmelo/cmake-feedstock.git","clone_url":"https://github.com/gqmelo/cmake-feedstock.git","svn_url":"https://github.com/gqmelo/cmake-feedstock","homepage":null,"size":27,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"conda-forge:master","ref":"master","sha":"33ff247e597bd81f6d73b3aed2d4f2c5f0e534c5","user":{"login":"conda-forge","id":11897326,"avatar_url":"https://avatars.githubusercontent.com/u/11897326?v=3","gravatar_id":"","url":"https://api.github.com/users/conda-forge","html_url":"https://github.com/conda-forge","followers_url":"https://api.github.com/users/conda-forge/followers","following_url":"https://api.github.com/users/conda-forge/following{/other_user}","gists_url":"https://api.github.com/users/conda-forge/gists{/gist_id}","starred_url":"https://api.github.com/users/conda-forge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conda-forge/subscriptions","organizations_url":"https://api.github.com/users/conda-forge/orgs","repos_url":"https://api.github.com/users/conda-forge/repos","events_url":"https://api.github.com/users/conda-forge/events{/privacy}","received_events_url":"https://api.github.com/users/conda-forge/received_events","type":"Organization","site_admin":false},"repo":{"id":54054474,"name":"cmake-feedstock","full_name":"conda-forge/cmake-feedstock","owner":{"login":"conda-forge","id":11897326,"avatar_url":"https://avatars.githubusercontent.com/u/11897326?v=3","gravatar_id":"","url":"https://api.github.com/users/conda-forge","html_url":"https://github.com/conda-forge","followers_url":"https://api.github.com/users/conda-forge/followers","following_url":"https://api.github.com/users/conda-forge/following{/other_user}","gists_url":"https://api.github.com/users/conda-forge/gists{/gist_id}","starred_url":"https://api.github.com/users/conda-forge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conda-forge/subscriptions","organizations_url":"https://api.github.com/users/conda-forge/orgs","repos_url":"https://api.github.com/users/conda-forge/repos","events_url":"https://api.github.com/users/conda-forge/events{/privacy}","received_events_url":"https://api.github.com/users/conda-forge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conda-forge/cmake-feedstock","description":"A conda-smithy repository for cmake.","fork":false,"url":"https://api.github.com/repos/conda-forge/cmake-feedstock","forks_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/forks","keys_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/teams","hooks_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/hooks","issue_events_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/issues/events{/number}","events_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/events","assignees_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/assignees{/user}","branches_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/branches{/branch}","tags_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/tags","blobs_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/git/refs{/sha}","trees_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/statuses/{sha}","languages_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/languages","stargazers_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/stargazers","contributors_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/contributors","subscribers_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/subscribers","subscription_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/subscription","commits_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/commits{/sha}","git_commits_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/git/commits{/sha}","comments_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/comments{/number}","issue_comment_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/issues/comments{/number}","contents_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/contents/{+path}","compare_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/merges","archive_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/downloads","issues_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/issues{/number}","pulls_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/pulls{/number}","milestones_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/milestones{/number}","notifications_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/labels{/name}","releases_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/releases{/id}","deployments_url":"https://api.github.com/repos/conda-forge/cmake-feedstock/deployments","created_at":"2016-03-16T17:54:37Z","updated_at":"2016-10-22T01:27:42Z","pushed_at":"2016-12-28T21:51:00Z","git_url":"git://github.com/conda-forge/cmake-feedstock.git","ssh_url":"git@github.com:conda-forge/cmake-feedstock.git","clone_url":"https://github.com/conda-forge/cmake-feedstock.git","svn_url":"https://github.com/conda-forge/cmake-feedstock","homepage":null,"size":26,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":6,"forks":14,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/conda-forge/cmake-feedstock/pulls/26"},"html":{"href":"https://github.com/conda-forge/cmake-feedstock/pull/26"},"issue":{"href":"https://api.github.com/repos/conda-forge/cmake-feedstock/issues/26"},"comments":{"href":"https://api.github.com/repos/conda-forge/cmake-feedstock/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/conda-forge/cmake-feedstock/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/conda-forge/cmake-feedstock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conda-forge/cmake-feedstock/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/conda-forge/cmake-feedstock/statuses/e45a5daad8118f644850c7599f3a50abdf3039ce"}}}}
{"actor":{"display_login":"isuruf"}}