{"action":"created","comment":{"url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/pulls/comments/82354882","pull_request_review_id":3268582,"id":82354882,"diff_hunk":"@@ -80,7 +80,14 @@ public static ServerItem fromJsonString(String json) {\n         private String password;\n \n         public Builder(@NonNull String name, @NonNull String url) {\n-            this.name = name;\n+            this.name = name.trim();\n+\n+            if (!url.startsWith(\"http://\")) {\n+                url = \"http://\" + url;\n+            }\n+            if (!url.endsWith(\"/\")) {\n+                url += \"/\";\n+            }","path":"app/src/main/java/io/mstream/mstream/serverlist/ServerItem.java","position":12,"original_position":12,"commit_id":"2bf4eb9d05d898c6058a14f356619c52d859cb93","original_commit_id":"51f89dfa2a2ade2d717693cd1a77826358d320b9","user":{"login":"firekesti","id":599624,"avatar_url":"https://avatars.githubusercontent.com/u/599624?v=3","gravatar_id":"","url":"https://api.github.com/users/firekesti","html_url":"https://github.com/firekesti","followers_url":"https://api.github.com/users/firekesti/followers","following_url":"https://api.github.com/users/firekesti/following{/other_user}","gists_url":"https://api.github.com/users/firekesti/gists{/gist_id}","starred_url":"https://api.github.com/users/firekesti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firekesti/subscriptions","organizations_url":"https://api.github.com/users/firekesti/orgs","repos_url":"https://api.github.com/users/firekesti/repos","events_url":"https://api.github.com/users/firekesti/events{/privacy}","received_events_url":"https://api.github.com/users/firekesti/received_events","type":"User","site_admin":false},"body":"I figured we could validate the URL at item-build time - didn't realize you'd put in a different solution. ","created_at":"2016-10-07T09:16:55Z","updated_at":"2016-10-07T09:16:55Z","html_url":"https://github.com/IrosTheBeggar/mstream-android-app/pull/12#discussion_r82354882","pull_request_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/pulls/comments/82354882"},"html":{"href":"https://github.com/IrosTheBeggar/mstream-android-app/pull/12#discussion_r82354882"},"pull_request":{"href":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/pulls/12","id":88404675,"html_url":"https://github.com/IrosTheBeggar/mstream-android-app/pull/12","diff_url":"https://github.com/IrosTheBeggar/mstream-android-app/pull/12.diff","patch_url":"https://github.com/IrosTheBeggar/mstream-android-app/pull/12.patch","issue_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/issues/12","number":12,"state":"open","locked":false,"title":"Playlists","user":{"login":"firekesti","id":599624,"avatar_url":"https://avatars.githubusercontent.com/u/599624?v=3","gravatar_id":"","url":"https://api.github.com/users/firekesti","html_url":"https://github.com/firekesti","followers_url":"https://api.github.com/users/firekesti/followers","following_url":"https://api.github.com/users/firekesti/following{/other_user}","gists_url":"https://api.github.com/users/firekesti/gists{/gist_id}","starred_url":"https://api.github.com/users/firekesti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firekesti/subscriptions","organizations_url":"https://api.github.com/users/firekesti/orgs","repos_url":"https://api.github.com/users/firekesti/repos","events_url":"https://api.github.com/users/firekesti/events{/privacy}","received_events_url":"https://api.github.com/users/firekesti/received_events","type":"User","site_admin":false},"body":"This was harder than I expected...there's still a lot to do, but I basically have the MediaSession talking to the QueueManager talking to the Fragment that displays the data. Definitely some kinks to work out, and the currently-playing item isn't updating for some reason even though the other callback is working. I think I'll try to update testPlay (which will eventually be removed) with multiple items next, to see if they all populate.\r\n\r\n![device-2016-10-07-051009](https://cloud.githubusercontent.com/assets/599624/19184726/6b1d303c-8cb9-11e6-9a19-6daf136772f7.png)\r\n\r\nHere's the notification with just the title - I wonder what other text we should put in it?\r\n\"Playing from [server url]\"?\r\n\r\n<img width=\"900\" alt=\"screen shot 2016-10-07 at 6 10 28 pm\" src=\"https://cloud.githubusercontent.com/assets/599624/19184727/6cb9ec28-8cb9-11e6-8f28-9a91c12450e9.png\">\r\n","created_at":"2016-10-07T09:14:45Z","updated_at":"2016-10-07T09:16:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff50dd743cda9992e0f5d71ec982c38ab40e67ff","assignee":{"login":"IrosTheBeggar","id":1396994,"avatar_url":"https://avatars.githubusercontent.com/u/1396994?v=3","gravatar_id":"","url":"https://api.github.com/users/IrosTheBeggar","html_url":"https://github.com/IrosTheBeggar","followers_url":"https://api.github.com/users/IrosTheBeggar/followers","following_url":"https://api.github.com/users/IrosTheBeggar/following{/other_user}","gists_url":"https://api.github.com/users/IrosTheBeggar/gists{/gist_id}","starred_url":"https://api.github.com/users/IrosTheBeggar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IrosTheBeggar/subscriptions","organizations_url":"https://api.github.com/users/IrosTheBeggar/orgs","repos_url":"https://api.github.com/users/IrosTheBeggar/repos","events_url":"https://api.github.com/users/IrosTheBeggar/events{/privacy}","received_events_url":"https://api.github.com/users/IrosTheBeggar/received_events","type":"User","site_admin":false},"assignees":[{"login":"IrosTheBeggar","id":1396994,"avatar_url":"https://avatars.githubusercontent.com/u/1396994?v=3","gravatar_id":"","url":"https://api.github.com/users/IrosTheBeggar","html_url":"https://github.com/IrosTheBeggar","followers_url":"https://api.github.com/users/IrosTheBeggar/followers","following_url":"https://api.github.com/users/IrosTheBeggar/following{/other_user}","gists_url":"https://api.github.com/users/IrosTheBeggar/gists{/gist_id}","starred_url":"https://api.github.com/users/IrosTheBeggar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IrosTheBeggar/subscriptions","organizations_url":"https://api.github.com/users/IrosTheBeggar/orgs","repos_url":"https://api.github.com/users/IrosTheBeggar/repos","events_url":"https://api.github.com/users/IrosTheBeggar/events{/privacy}","received_events_url":"https://api.github.com/users/IrosTheBeggar/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/pulls/12/commits","review_comments_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/pulls/12/comments","review_comment_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/issues/12/comments","statuses_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/statuses/2bf4eb9d05d898c6058a14f356619c52d859cb93","head":{"label":"IrosTheBeggar:playlists","ref":"playlists","sha":"2bf4eb9d05d898c6058a14f356619c52d859cb93","user":{"login":"IrosTheBeggar","id":1396994,"avatar_url":"https://avatars.githubusercontent.com/u/1396994?v=3","gravatar_id":"","url":"https://api.github.com/users/IrosTheBeggar","html_url":"https://github.com/IrosTheBeggar","followers_url":"https://api.github.com/users/IrosTheBeggar/followers","following_url":"https://api.github.com/users/IrosTheBeggar/following{/other_user}","gists_url":"https://api.github.com/users/IrosTheBeggar/gists{/gist_id}","starred_url":"https://api.github.com/users/IrosTheBeggar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IrosTheBeggar/subscriptions","organizations_url":"https://api.github.com/users/IrosTheBeggar/orgs","repos_url":"https://api.github.com/users/IrosTheBeggar/repos","events_url":"https://api.github.com/users/IrosTheBeggar/events{/privacy}","received_events_url":"https://api.github.com/users/IrosTheBeggar/received_events","type":"User","site_admin":false},"repo":{"id":56995957,"name":"mstream-android-app","full_name":"IrosTheBeggar/mstream-android-app","owner":{"login":"IrosTheBeggar","id":1396994,"avatar_url":"https://avatars.githubusercontent.com/u/1396994?v=3","gravatar_id":"","url":"https://api.github.com/users/IrosTheBeggar","html_url":"https://github.com/IrosTheBeggar","followers_url":"https://api.github.com/users/IrosTheBeggar/followers","following_url":"https://api.github.com/users/IrosTheBeggar/following{/other_user}","gists_url":"https://api.github.com/users/IrosTheBeggar/gists{/gist_id}","starred_url":"https://api.github.com/users/IrosTheBeggar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IrosTheBeggar/subscriptions","organizations_url":"https://api.github.com/users/IrosTheBeggar/orgs","repos_url":"https://api.github.com/users/IrosTheBeggar/repos","events_url":"https://api.github.com/users/IrosTheBeggar/events{/privacy}","received_events_url":"https://api.github.com/users/IrosTheBeggar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/IrosTheBeggar/mstream-android-app","description":"Android client that connect to the mStream server","fork":false,"url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app","forks_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/forks","keys_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/teams","hooks_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/hooks","issue_events_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/issues/events{/number}","events_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/events","assignees_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/assignees{/user}","branches_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/branches{/branch}","tags_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/tags","blobs_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/statuses/{sha}","languages_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/languages","stargazers_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/stargazers","contributors_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/contributors","subscribers_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/subscribers","subscription_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/subscription","commits_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/contents/{+path}","compare_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/merges","archive_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/downloads","issues_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/issues{/number}","pulls_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/pulls{/number}","milestones_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/milestones{/number}","notifications_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/labels{/name}","releases_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/releases{/id}","deployments_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/deployments","created_at":"2016-04-24T21:47:31Z","updated_at":"2016-04-28T18:02:37Z","pushed_at":"2016-10-07T09:14:46Z","git_url":"git://github.com/IrosTheBeggar/mstream-android-app.git","ssh_url":"git@github.com:IrosTheBeggar/mstream-android-app.git","clone_url":"https://github.com/IrosTheBeggar/mstream-android-app.git","svn_url":"https://github.com/IrosTheBeggar/mstream-android-app","homepage":"","size":19652,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"IrosTheBeggar:master","ref":"master","sha":"8bc28d72028b65c98c6994641a3412c57f85fb30","user":{"login":"IrosTheBeggar","id":1396994,"avatar_url":"https://avatars.githubusercontent.com/u/1396994?v=3","gravatar_id":"","url":"https://api.github.com/users/IrosTheBeggar","html_url":"https://github.com/IrosTheBeggar","followers_url":"https://api.github.com/users/IrosTheBeggar/followers","following_url":"https://api.github.com/users/IrosTheBeggar/following{/other_user}","gists_url":"https://api.github.com/users/IrosTheBeggar/gists{/gist_id}","starred_url":"https://api.github.com/users/IrosTheBeggar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IrosTheBeggar/subscriptions","organizations_url":"https://api.github.com/users/IrosTheBeggar/orgs","repos_url":"https://api.github.com/users/IrosTheBeggar/repos","events_url":"https://api.github.com/users/IrosTheBeggar/events{/privacy}","received_events_url":"https://api.github.com/users/IrosTheBeggar/received_events","type":"User","site_admin":false},"repo":{"id":56995957,"name":"mstream-android-app","full_name":"IrosTheBeggar/mstream-android-app","owner":{"login":"IrosTheBeggar","id":1396994,"avatar_url":"https://avatars.githubusercontent.com/u/1396994?v=3","gravatar_id":"","url":"https://api.github.com/users/IrosTheBeggar","html_url":"https://github.com/IrosTheBeggar","followers_url":"https://api.github.com/users/IrosTheBeggar/followers","following_url":"https://api.github.com/users/IrosTheBeggar/following{/other_user}","gists_url":"https://api.github.com/users/IrosTheBeggar/gists{/gist_id}","starred_url":"https://api.github.com/users/IrosTheBeggar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IrosTheBeggar/subscriptions","organizations_url":"https://api.github.com/users/IrosTheBeggar/orgs","repos_url":"https://api.github.com/users/IrosTheBeggar/repos","events_url":"https://api.github.com/users/IrosTheBeggar/events{/privacy}","received_events_url":"https://api.github.com/users/IrosTheBeggar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/IrosTheBeggar/mstream-android-app","description":"Android client that connect to the mStream server","fork":false,"url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app","forks_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/forks","keys_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/teams","hooks_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/hooks","issue_events_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/issues/events{/number}","events_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/events","assignees_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/assignees{/user}","branches_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/branches{/branch}","tags_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/tags","blobs_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/statuses/{sha}","languages_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/languages","stargazers_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/stargazers","contributors_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/contributors","subscribers_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/subscribers","subscription_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/subscription","commits_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/contents/{+path}","compare_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/merges","archive_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/downloads","issues_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/issues{/number}","pulls_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/pulls{/number}","milestones_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/milestones{/number}","notifications_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/labels{/name}","releases_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/releases{/id}","deployments_url":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/deployments","created_at":"2016-04-24T21:47:31Z","updated_at":"2016-04-28T18:02:37Z","pushed_at":"2016-10-07T09:14:46Z","git_url":"git://github.com/IrosTheBeggar/mstream-android-app.git","ssh_url":"git@github.com:IrosTheBeggar/mstream-android-app.git","clone_url":"https://github.com/IrosTheBeggar/mstream-android-app.git","svn_url":"https://github.com/IrosTheBeggar/mstream-android-app","homepage":"","size":19652,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/pulls/12"},"html":{"href":"https://github.com/IrosTheBeggar/mstream-android-app/pull/12"},"issue":{"href":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/issues/12"},"comments":{"href":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/IrosTheBeggar/mstream-android-app/statuses/2bf4eb9d05d898c6058a14f356619c52d859cb93"}}}}
{"actor":{"display_login":"firekesti"}}