{"action":"created","comment":{"url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/pulls/comments/49904144","id":49904144,"diff_hunk":"@@ -0,0 +1,7 @@\n+[ClassVersion(\"0.1.0.0\"), FriendlyName(\"xAdcsOnlineResponder\")]\n+class MSFT_xAdcsOnlineResponder : OMI_BaseResource\n+{\n+    [Required, Description(\"If the Online Responder service is configured to use Standalone certification authority, then an account that is a member of the local Administrators on the CA is required. If the Online Responder service is configured to use an Enterprise CA, then an account that is a member of Domain Admins is required.\"), EmbeddedInstance(\"MSFT_Credential\")] String Credential;\n+    [Required, Description(\"Specifies whether the Online Responder feature should be installed or uninstalled.\"), ValueMap{\"Present\",\"Absent\"}, Values{\"Present\",\"Absent\"}] String Ensure;\n+    [Key] String Name;","path":"xCertificateServices/DSCResources/MSFT_xAdcsOnlineResponder/MSFT_xAdcsOnlineResponder.schema.mof","position":6,"original_position":6,"commit_id":"4c5b0c574c35c3a8f5e02f050079682b960c10bf","original_commit_id":"4c5b0c574c35c3a8f5e02f050079682b960c10bf","user":{"login":"PlagueHO","id":7589164,"avatar_url":"https://avatars.githubusercontent.com/u/7589164?v=3","gravatar_id":"","url":"https://api.github.com/users/PlagueHO","html_url":"https://github.com/PlagueHO","followers_url":"https://api.github.com/users/PlagueHO/followers","following_url":"https://api.github.com/users/PlagueHO/following{/other_user}","gists_url":"https://api.github.com/users/PlagueHO/gists{/gist_id}","starred_url":"https://api.github.com/users/PlagueHO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlagueHO/subscriptions","organizations_url":"https://api.github.com/users/PlagueHO/orgs","repos_url":"https://api.github.com/users/PlagueHO/repos","events_url":"https://api.github.com/users/PlagueHO/events{/privacy}","received_events_url":"https://api.github.com/users/PlagueHO/received_events","type":"User","site_admin":false},"body":"Excellent! I knew there must have been a proper way to do this :smile:\r\n\r\nI'll make the changes to xADCSOnlineResponder. Is it worth me submitting a separate PR to change this in the xADCSWebEnrollment resource as well? It would seem best to have these resources work in the same way.","created_at":"2016-01-15T20:56:52Z","updated_at":"2016-01-15T20:56:52Z","html_url":"https://github.com/PowerShell/xAdcsDeployment/pull/2#discussion_r49904144","pull_request_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/PowerShell/xAdcsDeployment/pulls/comments/49904144"},"html":{"href":"https://github.com/PowerShell/xAdcsDeployment/pull/2#discussion_r49904144"},"pull_request":{"href":"https://api.github.com/repos/PowerShell/xAdcsDeployment/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/pulls/2","id":44889772,"html_url":"https://github.com/PowerShell/xAdcsDeployment/pull/2","diff_url":"https://github.com/PowerShell/xAdcsDeployment/pull/2.diff","patch_url":"https://github.com/PowerShell/xAdcsDeployment/pull/2.patch","issue_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/issues/2","number":2,"state":"open","locked":false,"title":" \tAdded support for Installing the Online Responder Service in new xADCSOnlineResponder module","user":{"login":"PlagueHO","id":7589164,"avatar_url":"https://avatars.githubusercontent.com/u/7589164?v=3","gravatar_id":"","url":"https://api.github.com/users/PlagueHO","html_url":"https://github.com/PlagueHO","followers_url":"https://api.github.com/users/PlagueHO/followers","following_url":"https://api.github.com/users/PlagueHO/following{/other_user}","gists_url":"https://api.github.com/users/PlagueHO/gists{/gist_id}","starred_url":"https://api.github.com/users/PlagueHO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlagueHO/subscriptions","organizations_url":"https://api.github.com/users/PlagueHO/orgs","repos_url":"https://api.github.com/users/PlagueHO/repos","events_url":"https://api.github.com/users/PlagueHO/events{/privacy}","received_events_url":"https://api.github.com/users/PlagueHO/received_events","type":"User","site_admin":false},"body":"I also added OutputType() attributes to the Get-TargetResource and Test-TargetResource functions of MSFT_xAdcsCertificationAuthority.psm1 and MSFT_xAdcsWebEnrollment.psm1 to eliminate Warnings from DSCResource.tests.\r\n\r\nI included Pester tests for the new code I wrote, but I didn't add any for the existing resource modules.","created_at":"2015-09-14T03:19:22Z","updated_at":"2016-01-15T20:56:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c902244a4f98fc90c552cd91b27d06b4354af5ec","assignee":{"login":"TravisEz13","id":10873629,"avatar_url":"https://avatars.githubusercontent.com/u/10873629?v=3","gravatar_id":"","url":"https://api.github.com/users/TravisEz13","html_url":"https://github.com/TravisEz13","followers_url":"https://api.github.com/users/TravisEz13/followers","following_url":"https://api.github.com/users/TravisEz13/following{/other_user}","gists_url":"https://api.github.com/users/TravisEz13/gists{/gist_id}","starred_url":"https://api.github.com/users/TravisEz13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravisEz13/subscriptions","organizations_url":"https://api.github.com/users/TravisEz13/orgs","repos_url":"https://api.github.com/users/TravisEz13/repos","events_url":"https://api.github.com/users/TravisEz13/events{/privacy}","received_events_url":"https://api.github.com/users/TravisEz13/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/pulls/2/commits","review_comments_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/pulls/2/comments","review_comment_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/issues/2/comments","statuses_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/statuses/4c5b0c574c35c3a8f5e02f050079682b960c10bf","head":{"label":"PlagueHO:dev","ref":"dev","sha":"4c5b0c574c35c3a8f5e02f050079682b960c10bf","user":{"login":"PlagueHO","id":7589164,"avatar_url":"https://avatars.githubusercontent.com/u/7589164?v=3","gravatar_id":"","url":"https://api.github.com/users/PlagueHO","html_url":"https://github.com/PlagueHO","followers_url":"https://api.github.com/users/PlagueHO/followers","following_url":"https://api.github.com/users/PlagueHO/following{/other_user}","gists_url":"https://api.github.com/users/PlagueHO/gists{/gist_id}","starred_url":"https://api.github.com/users/PlagueHO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlagueHO/subscriptions","organizations_url":"https://api.github.com/users/PlagueHO/orgs","repos_url":"https://api.github.com/users/PlagueHO/repos","events_url":"https://api.github.com/users/PlagueHO/events{/privacy}","received_events_url":"https://api.github.com/users/PlagueHO/received_events","type":"User","site_admin":false},"repo":{"id":42392421,"name":"xAdcsDeployment","full_name":"PlagueHO/xAdcsDeployment","owner":{"login":"PlagueHO","id":7589164,"avatar_url":"https://avatars.githubusercontent.com/u/7589164?v=3","gravatar_id":"","url":"https://api.github.com/users/PlagueHO","html_url":"https://github.com/PlagueHO","followers_url":"https://api.github.com/users/PlagueHO/followers","following_url":"https://api.github.com/users/PlagueHO/following{/other_user}","gists_url":"https://api.github.com/users/PlagueHO/gists{/gist_id}","starred_url":"https://api.github.com/users/PlagueHO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlagueHO/subscriptions","organizations_url":"https://api.github.com/users/PlagueHO/orgs","repos_url":"https://api.github.com/users/PlagueHO/repos","events_url":"https://api.github.com/users/PlagueHO/events{/privacy}","received_events_url":"https://api.github.com/users/PlagueHO/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PlagueHO/xAdcsDeployment","description":"Add support for Initializing Online Responder","fork":true,"url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment","forks_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/forks","keys_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/teams","hooks_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/hooks","issue_events_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/issues/events{/number}","events_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/events","assignees_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/assignees{/user}","branches_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/branches{/branch}","tags_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/tags","blobs_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/git/refs{/sha}","trees_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/statuses/{sha}","languages_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/languages","stargazers_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/stargazers","contributors_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/contributors","subscribers_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/subscribers","subscription_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/subscription","commits_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/commits{/sha}","git_commits_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/git/commits{/sha}","comments_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/comments{/number}","issue_comment_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/issues/comments{/number}","contents_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/contents/{+path}","compare_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/merges","archive_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/downloads","issues_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/issues{/number}","pulls_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/pulls{/number}","milestones_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/milestones{/number}","notifications_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/labels{/name}","releases_url":"https://api.github.com/repos/PlagueHO/xAdcsDeployment/releases{/id}","created_at":"2015-09-13T10:50:01Z","updated_at":"2016-01-15T00:44:57Z","pushed_at":"2016-01-15T03:49:58Z","git_url":"git://github.com/PlagueHO/xAdcsDeployment.git","ssh_url":"git@github.com:PlagueHO/xAdcsDeployment.git","clone_url":"https://github.com/PlagueHO/xAdcsDeployment.git","svn_url":"https://github.com/PlagueHO/xAdcsDeployment","homepage":"","size":51,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"PowerShell:dev","ref":"dev","sha":"bacbc5a5a999f84e033829d38552e9abccd43dec","user":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars.githubusercontent.com/u/11524380?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"repo":{"id":33700514,"name":"xAdcsDeployment","full_name":"PowerShell/xAdcsDeployment","owner":{"login":"PowerShell","id":11524380,"avatar_url":"https://avatars.githubusercontent.com/u/11524380?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PowerShell/xAdcsDeployment","description":"","fork":false,"url":"https://api.github.com/repos/PowerShell/xAdcsDeployment","forks_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/forks","keys_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/teams","hooks_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/hooks","issue_events_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/issues/events{/number}","events_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/events","assignees_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/assignees{/user}","branches_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/branches{/branch}","tags_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/tags","blobs_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/languages","stargazers_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/stargazers","contributors_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/contributors","subscribers_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/subscribers","subscription_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/subscription","commits_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/contents/{+path}","compare_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/merges","archive_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/downloads","issues_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/issues{/number}","pulls_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/labels{/name}","releases_url":"https://api.github.com/repos/PowerShell/xAdcsDeployment/releases{/id}","created_at":"2015-04-10T00:56:34Z","updated_at":"2015-09-23T05:00:06Z","pushed_at":"2016-01-15T03:49:59Z","git_url":"git://github.com/PowerShell/xAdcsDeployment.git","ssh_url":"git@github.com:PowerShell/xAdcsDeployment.git","clone_url":"https://github.com/PowerShell/xAdcsDeployment.git","svn_url":"https://github.com/PowerShell/xAdcsDeployment","homepage":null,"size":39,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":4,"forks":7,"open_issues":4,"watchers":2,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerShell/xAdcsDeployment/pulls/2"},"html":{"href":"https://github.com/PowerShell/xAdcsDeployment/pull/2"},"issue":{"href":"https://api.github.com/repos/PowerShell/xAdcsDeployment/issues/2"},"comments":{"href":"https://api.github.com/repos/PowerShell/xAdcsDeployment/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerShell/xAdcsDeployment/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerShell/xAdcsDeployment/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerShell/xAdcsDeployment/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/PowerShell/xAdcsDeployment/statuses/4c5b0c574c35c3a8f5e02f050079682b960c10bf"}}}}