{"action":"created","comment":{"url":"https://api.github.com/repos/ddf-project/DDF/pulls/comments/67808338","id":67808338,"diff_hunk":"@@ -83,6 +85,20 @@ public void setIsDDFView(boolean isDDFView) {\n     this.mIsDDFView = isDDFView;\n   }\n \n+  public boolean isCache() {\n+    return this.isCache;\n+  }\n+\n+  public void cache() {\n+    this.isCache = true;\n+    this.getRepresentationHandler().cache(false);","path":"core/src/main/java/io/ddf/DDF.java","position":19,"original_position":19,"commit_id":"2b4d921936ca30faf95208e4fc4f010d30e88815","original_commit_id":"0a796e2e0077842c827cfe3ebf9cda27aaf42be0","user":{"login":"hai-adatao","id":14540303,"avatar_url":"https://avatars.githubusercontent.com/u/14540303?v=3","gravatar_id":"","url":"https://api.github.com/users/hai-adatao","html_url":"https://github.com/hai-adatao","followers_url":"https://api.github.com/users/hai-adatao/followers","following_url":"https://api.github.com/users/hai-adatao/following{/other_user}","gists_url":"https://api.github.com/users/hai-adatao/gists{/gist_id}","starred_url":"https://api.github.com/users/hai-adatao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hai-adatao/subscriptions","organizations_url":"https://api.github.com/users/hai-adatao/orgs","repos_url":"https://api.github.com/users/hai-adatao/repos","events_url":"https://api.github.com/users/hai-adatao/events{/privacy}","received_events_url":"https://api.github.com/users/hai-adatao/received_events","type":"User","site_admin":false},"body":"Also, in `cache` and `uncache` methods, the flag `isCached` always changes the value upon calling, should only change this after the operation finishes successfully?","created_at":"2016-06-21T05:01:05Z","updated_at":"2016-06-21T05:01:05Z","html_url":"https://github.com/ddf-project/DDF/pull/364#discussion_r67808338","pull_request_url":"https://api.github.com/repos/ddf-project/DDF/pulls/364","_links":{"self":{"href":"https://api.github.com/repos/ddf-project/DDF/pulls/comments/67808338"},"html":{"href":"https://github.com/ddf-project/DDF/pull/364#discussion_r67808338"},"pull_request":{"href":"https://api.github.com/repos/ddf-project/DDF/pulls/364"}}},"pull_request":{"url":"https://api.github.com/repos/ddf-project/DDF/pulls/364","id":74414625,"html_url":"https://github.com/ddf-project/DDF/pull/364","diff_url":"https://github.com/ddf-project/DDF/pull/364.diff","patch_url":"https://github.com/ddf-project/DDF/pull/364.patch","issue_url":"https://api.github.com/repos/ddf-project/DDF/issues/364","number":364,"state":"open","locked":false,"title":"[Feature] remove implicit cache function in DDF","user":{"login":"Huandao0812","id":4637802,"avatar_url":"https://avatars.githubusercontent.com/u/4637802?v=3","gravatar_id":"","url":"https://api.github.com/users/Huandao0812","html_url":"https://github.com/Huandao0812","followers_url":"https://api.github.com/users/Huandao0812/followers","following_url":"https://api.github.com/users/Huandao0812/following{/other_user}","gists_url":"https://api.github.com/users/Huandao0812/gists{/gist_id}","starred_url":"https://api.github.com/users/Huandao0812/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Huandao0812/subscriptions","organizations_url":"https://api.github.com/users/Huandao0812/orgs","repos_url":"https://api.github.com/users/Huandao0812/repos","events_url":"https://api.github.com/users/Huandao0812/events{/privacy}","received_events_url":"https://api.github.com/users/Huandao0812/received_events","type":"User","site_admin":false},"body":"### Description and related tickets, documents\r\nAdd DDF api to cache, uncache a DDF.\r\nif a DDF is cached, it'll also be cached after an in-place transformation.\r\nnew DDF will always be uncached.\r\n\r\nReviewers: \r\n- Main reviewer: @ubolonton \r\n- Optional reviewer: @lebinh @zkidkid \r\n- Observers: @hai-adatao\r\n\r\n\r\n### PR Progress\r\nMake sure all checkboxes below are checked before merged\r\n- [x] Merge check has no conflicts. PR checks passed.\r\n- [ ] Main reviewer approved\r\n- [ ] Optional reviewer approved\r\n","created_at":"2016-06-20T09:38:05Z","updated_at":"2016-06-21T05:01:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23b05fe454a3f8e6218325ffdad0e13c5967dad6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ddf-project/DDF/pulls/364/commits","review_comments_url":"https://api.github.com/repos/ddf-project/DDF/pulls/364/comments","review_comment_url":"https://api.github.com/repos/ddf-project/DDF/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ddf-project/DDF/issues/364/comments","statuses_url":"https://api.github.com/repos/ddf-project/DDF/statuses/2b4d921936ca30faf95208e4fc4f010d30e88815","head":{"label":"ddf-project:feature/cache-ddf","ref":"feature/cache-ddf","sha":"2b4d921936ca30faf95208e4fc4f010d30e88815","user":{"login":"ddf-project","id":8108779,"avatar_url":"https://avatars.githubusercontent.com/u/8108779?v=3","gravatar_id":"","url":"https://api.github.com/users/ddf-project","html_url":"https://github.com/ddf-project","followers_url":"https://api.github.com/users/ddf-project/followers","following_url":"https://api.github.com/users/ddf-project/following{/other_user}","gists_url":"https://api.github.com/users/ddf-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ddf-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddf-project/subscriptions","organizations_url":"https://api.github.com/users/ddf-project/orgs","repos_url":"https://api.github.com/users/ddf-project/repos","events_url":"https://api.github.com/users/ddf-project/events{/privacy}","received_events_url":"https://api.github.com/users/ddf-project/received_events","type":"Organization","site_admin":false},"repo":{"id":21636061,"name":"DDF","full_name":"ddf-project/DDF","owner":{"login":"ddf-project","id":8108779,"avatar_url":"https://avatars.githubusercontent.com/u/8108779?v=3","gravatar_id":"","url":"https://api.github.com/users/ddf-project","html_url":"https://github.com/ddf-project","followers_url":"https://api.github.com/users/ddf-project/followers","following_url":"https://api.github.com/users/ddf-project/following{/other_user}","gists_url":"https://api.github.com/users/ddf-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ddf-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddf-project/subscriptions","organizations_url":"https://api.github.com/users/ddf-project/orgs","repos_url":"https://api.github.com/users/ddf-project/repos","events_url":"https://api.github.com/users/ddf-project/events{/privacy}","received_events_url":"https://api.github.com/users/ddf-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ddf-project/DDF","description":"Distributed DataFrame: Productivity = Power x Simplicity For Scientists & Engineers, on any Data Engine","fork":false,"url":"https://api.github.com/repos/ddf-project/DDF","forks_url":"https://api.github.com/repos/ddf-project/DDF/forks","keys_url":"https://api.github.com/repos/ddf-project/DDF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ddf-project/DDF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ddf-project/DDF/teams","hooks_url":"https://api.github.com/repos/ddf-project/DDF/hooks","issue_events_url":"https://api.github.com/repos/ddf-project/DDF/issues/events{/number}","events_url":"https://api.github.com/repos/ddf-project/DDF/events","assignees_url":"https://api.github.com/repos/ddf-project/DDF/assignees{/user}","branches_url":"https://api.github.com/repos/ddf-project/DDF/branches{/branch}","tags_url":"https://api.github.com/repos/ddf-project/DDF/tags","blobs_url":"https://api.github.com/repos/ddf-project/DDF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ddf-project/DDF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ddf-project/DDF/git/refs{/sha}","trees_url":"https://api.github.com/repos/ddf-project/DDF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ddf-project/DDF/statuses/{sha}","languages_url":"https://api.github.com/repos/ddf-project/DDF/languages","stargazers_url":"https://api.github.com/repos/ddf-project/DDF/stargazers","contributors_url":"https://api.github.com/repos/ddf-project/DDF/contributors","subscribers_url":"https://api.github.com/repos/ddf-project/DDF/subscribers","subscription_url":"https://api.github.com/repos/ddf-project/DDF/subscription","commits_url":"https://api.github.com/repos/ddf-project/DDF/commits{/sha}","git_commits_url":"https://api.github.com/repos/ddf-project/DDF/git/commits{/sha}","comments_url":"https://api.github.com/repos/ddf-project/DDF/comments{/number}","issue_comment_url":"https://api.github.com/repos/ddf-project/DDF/issues/comments{/number}","contents_url":"https://api.github.com/repos/ddf-project/DDF/contents/{+path}","compare_url":"https://api.github.com/repos/ddf-project/DDF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ddf-project/DDF/merges","archive_url":"https://api.github.com/repos/ddf-project/DDF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ddf-project/DDF/downloads","issues_url":"https://api.github.com/repos/ddf-project/DDF/issues{/number}","pulls_url":"https://api.github.com/repos/ddf-project/DDF/pulls{/number}","milestones_url":"https://api.github.com/repos/ddf-project/DDF/milestones{/number}","notifications_url":"https://api.github.com/repos/ddf-project/DDF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ddf-project/DDF/labels{/name}","releases_url":"https://api.github.com/repos/ddf-project/DDF/releases{/id}","deployments_url":"https://api.github.com/repos/ddf-project/DDF/deployments","created_at":"2014-07-09T02:16:59Z","updated_at":"2016-06-17T02:58:08Z","pushed_at":"2016-06-21T03:03:33Z","git_url":"git://github.com/ddf-project/DDF.git","ssh_url":"git@github.com:ddf-project/DDF.git","clone_url":"https://github.com/ddf-project/DDF.git","svn_url":"https://github.com/ddf-project/DDF","homepage":"http://ddf.io","size":169116,"stargazers_count":134,"watchers_count":134,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":25,"forks":41,"open_issues":25,"watchers":134,"default_branch":"master"}},"base":{"label":"ddf-project:adatao","ref":"adatao","sha":"0346b2d75ff158696065d163a93091ab5398a886","user":{"login":"ddf-project","id":8108779,"avatar_url":"https://avatars.githubusercontent.com/u/8108779?v=3","gravatar_id":"","url":"https://api.github.com/users/ddf-project","html_url":"https://github.com/ddf-project","followers_url":"https://api.github.com/users/ddf-project/followers","following_url":"https://api.github.com/users/ddf-project/following{/other_user}","gists_url":"https://api.github.com/users/ddf-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ddf-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddf-project/subscriptions","organizations_url":"https://api.github.com/users/ddf-project/orgs","repos_url":"https://api.github.com/users/ddf-project/repos","events_url":"https://api.github.com/users/ddf-project/events{/privacy}","received_events_url":"https://api.github.com/users/ddf-project/received_events","type":"Organization","site_admin":false},"repo":{"id":21636061,"name":"DDF","full_name":"ddf-project/DDF","owner":{"login":"ddf-project","id":8108779,"avatar_url":"https://avatars.githubusercontent.com/u/8108779?v=3","gravatar_id":"","url":"https://api.github.com/users/ddf-project","html_url":"https://github.com/ddf-project","followers_url":"https://api.github.com/users/ddf-project/followers","following_url":"https://api.github.com/users/ddf-project/following{/other_user}","gists_url":"https://api.github.com/users/ddf-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ddf-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddf-project/subscriptions","organizations_url":"https://api.github.com/users/ddf-project/orgs","repos_url":"https://api.github.com/users/ddf-project/repos","events_url":"https://api.github.com/users/ddf-project/events{/privacy}","received_events_url":"https://api.github.com/users/ddf-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ddf-project/DDF","description":"Distributed DataFrame: Productivity = Power x Simplicity For Scientists & Engineers, on any Data Engine","fork":false,"url":"https://api.github.com/repos/ddf-project/DDF","forks_url":"https://api.github.com/repos/ddf-project/DDF/forks","keys_url":"https://api.github.com/repos/ddf-project/DDF/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ddf-project/DDF/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ddf-project/DDF/teams","hooks_url":"https://api.github.com/repos/ddf-project/DDF/hooks","issue_events_url":"https://api.github.com/repos/ddf-project/DDF/issues/events{/number}","events_url":"https://api.github.com/repos/ddf-project/DDF/events","assignees_url":"https://api.github.com/repos/ddf-project/DDF/assignees{/user}","branches_url":"https://api.github.com/repos/ddf-project/DDF/branches{/branch}","tags_url":"https://api.github.com/repos/ddf-project/DDF/tags","blobs_url":"https://api.github.com/repos/ddf-project/DDF/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ddf-project/DDF/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ddf-project/DDF/git/refs{/sha}","trees_url":"https://api.github.com/repos/ddf-project/DDF/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ddf-project/DDF/statuses/{sha}","languages_url":"https://api.github.com/repos/ddf-project/DDF/languages","stargazers_url":"https://api.github.com/repos/ddf-project/DDF/stargazers","contributors_url":"https://api.github.com/repos/ddf-project/DDF/contributors","subscribers_url":"https://api.github.com/repos/ddf-project/DDF/subscribers","subscription_url":"https://api.github.com/repos/ddf-project/DDF/subscription","commits_url":"https://api.github.com/repos/ddf-project/DDF/commits{/sha}","git_commits_url":"https://api.github.com/repos/ddf-project/DDF/git/commits{/sha}","comments_url":"https://api.github.com/repos/ddf-project/DDF/comments{/number}","issue_comment_url":"https://api.github.com/repos/ddf-project/DDF/issues/comments{/number}","contents_url":"https://api.github.com/repos/ddf-project/DDF/contents/{+path}","compare_url":"https://api.github.com/repos/ddf-project/DDF/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ddf-project/DDF/merges","archive_url":"https://api.github.com/repos/ddf-project/DDF/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ddf-project/DDF/downloads","issues_url":"https://api.github.com/repos/ddf-project/DDF/issues{/number}","pulls_url":"https://api.github.com/repos/ddf-project/DDF/pulls{/number}","milestones_url":"https://api.github.com/repos/ddf-project/DDF/milestones{/number}","notifications_url":"https://api.github.com/repos/ddf-project/DDF/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ddf-project/DDF/labels{/name}","releases_url":"https://api.github.com/repos/ddf-project/DDF/releases{/id}","deployments_url":"https://api.github.com/repos/ddf-project/DDF/deployments","created_at":"2014-07-09T02:16:59Z","updated_at":"2016-06-17T02:58:08Z","pushed_at":"2016-06-21T03:03:33Z","git_url":"git://github.com/ddf-project/DDF.git","ssh_url":"git@github.com:ddf-project/DDF.git","clone_url":"https://github.com/ddf-project/DDF.git","svn_url":"https://github.com/ddf-project/DDF","homepage":"http://ddf.io","size":169116,"stargazers_count":134,"watchers_count":134,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":25,"forks":41,"open_issues":25,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ddf-project/DDF/pulls/364"},"html":{"href":"https://github.com/ddf-project/DDF/pull/364"},"issue":{"href":"https://api.github.com/repos/ddf-project/DDF/issues/364"},"comments":{"href":"https://api.github.com/repos/ddf-project/DDF/issues/364/comments"},"review_comments":{"href":"https://api.github.com/repos/ddf-project/DDF/pulls/364/comments"},"review_comment":{"href":"https://api.github.com/repos/ddf-project/DDF/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ddf-project/DDF/pulls/364/commits"},"statuses":{"href":"https://api.github.com/repos/ddf-project/DDF/statuses/2b4d921936ca30faf95208e4fc4f010d30e88815"}}}}
{"actor":{"display_login":"hai-adatao"}}