{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments/61107626","id":61107626,"diff_hunk":"@@ -518,6 +518,19 @@ type OptionalArgInfo =\n         else \n             NotOptional\n \n+type CallerInfoInfo =\n+    | NoCallerInfo\n+    | CallerLineNumber\n+    | CallerMemberName\n+    | CallerFilePath\n+\n+    override x.ToString() =","path":"src/fsharp/infos.fs","position":10,"original_position":10,"commit_id":"4b2849f979114755493fc64204385c6e5913f375","original_commit_id":"4b2849f979114755493fc64204385c6e5913f375","user":{"login":"latkin","id":5943573,"avatar_url":"https://avatars.githubusercontent.com/u/5943573?v=3","gravatar_id":"","url":"https://api.github.com/users/latkin","html_url":"https://github.com/latkin","followers_url":"https://api.github.com/users/latkin/followers","following_url":"https://api.github.com/users/latkin/following{/other_user}","gists_url":"https://api.github.com/users/latkin/gists{/gist_id}","starred_url":"https://api.github.com/users/latkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latkin/subscriptions","organizations_url":"https://api.github.com/users/latkin/orgs","repos_url":"https://api.github.com/users/latkin/repos","events_url":"https://api.github.com/users/latkin/events{/privacy}","received_events_url":"https://api.github.com/users/latkin/received_events","type":"User","site_admin":false},"body":"In normal F# code `%A` nice-prints union types, but it seems that in the compiler this is not the case?  I forgot about `%+A`, will try that out.","created_at":"2016-04-26T15:30:01Z","updated_at":"2016-04-26T15:30:01Z","html_url":"https://github.com/Microsoft/visualfsharp/pull/1114#discussion_r61107626","pull_request_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1114","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments/61107626"},"html":{"href":"https://github.com/Microsoft/visualfsharp/pull/1114#discussion_r61107626"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1114"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1114","id":67740090,"html_url":"https://github.com/Microsoft/visualfsharp/pull/1114","diff_url":"https://github.com/Microsoft/visualfsharp/pull/1114.diff","patch_url":"https://github.com/Microsoft/visualfsharp/pull/1114.patch","issue_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1114","number":1114,"state":"open","locked":false,"title":"WIP - add support for caller info attributes","user":{"login":"latkin","id":5943573,"avatar_url":"https://avatars.githubusercontent.com/u/5943573?v=3","gravatar_id":"","url":"https://api.github.com/users/latkin","html_url":"https://github.com/latkin","followers_url":"https://api.github.com/users/latkin/followers","following_url":"https://api.github.com/users/latkin/following{/other_user}","gists_url":"https://api.github.com/users/latkin/gists{/gist_id}","starred_url":"https://api.github.com/users/latkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latkin/subscriptions","organizations_url":"https://api.github.com/users/latkin/orgs","repos_url":"https://api.github.com/users/latkin/repos","events_url":"https://api.github.com/users/latkin/events{/privacy}","received_events_url":"https://api.github.com/users/latkin/received_events","type":"User","site_admin":false},"body":"Paperwork:\r\n - [Uservoice](https://fslang.uservoice.com/forums/245727-f-language/suggestions/8899330-f-compiler-should-support-callerlinenumber-calle)\r\n - [RFC PR](https://github.com/fsharp/FSharpLangDesign/issues/85) (in progress)\r\n - [RFC issue](https://github.com/fsharp/FSharpLangDesign/issues/84) (in progress, though not sure what gets discussed there instead of in above PR)\r\n\r\nAdds support for emerging .NET standard [\"caller info\" attributes](https://msdn.microsoft.com/en-us/library/hh534540(v=vs.110).aspx).  Put this together with @AviAvni as part of the FSSF mentorship program.\r\n\r\nRight now this provides complete support (modulo feedback/bugs) for `CallerLineNumber` and `CallerFilePath`.\r\n\r\n`CallerMemberName` is not yet complete, as this information does not seem to be available in the right place, and we didn't see a simple way to add it in.  We are looking for suggestions/help from others with finishing that part. What part of the compilation would have this info, and how can we get access to it in a sensible place for this feature?\r\n","created_at":"2016-04-25T15:32:38Z","updated_at":"2016-04-26T15:30:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9ced6291a69d0dedb3e65716785bc1c05036f8c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1114/commits","review_comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1114/comments","review_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1114/comments","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/4b2849f979114755493fc64204385c6e5913f375","head":{"label":"latkin:latkin-caller-info-attrs","ref":"latkin-caller-info-attrs","sha":"4b2849f979114755493fc64204385c6e5913f375","user":{"login":"latkin","id":5943573,"avatar_url":"https://avatars.githubusercontent.com/u/5943573?v=3","gravatar_id":"","url":"https://api.github.com/users/latkin","html_url":"https://github.com/latkin","followers_url":"https://api.github.com/users/latkin/followers","following_url":"https://api.github.com/users/latkin/following{/other_user}","gists_url":"https://api.github.com/users/latkin/gists{/gist_id}","starred_url":"https://api.github.com/users/latkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latkin/subscriptions","organizations_url":"https://api.github.com/users/latkin/orgs","repos_url":"https://api.github.com/users/latkin/repos","events_url":"https://api.github.com/users/latkin/events{/privacy}","received_events_url":"https://api.github.com/users/latkin/received_events","type":"User","site_admin":false},"repo":{"id":29952040,"name":"visualfsharp","full_name":"latkin/visualfsharp","owner":{"login":"latkin","id":5943573,"avatar_url":"https://avatars.githubusercontent.com/u/5943573?v=3","gravatar_id":"","url":"https://api.github.com/users/latkin","html_url":"https://github.com/latkin","followers_url":"https://api.github.com/users/latkin/followers","following_url":"https://api.github.com/users/latkin/following{/other_user}","gists_url":"https://api.github.com/users/latkin/gists{/gist_id}","starred_url":"https://api.github.com/users/latkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latkin/subscriptions","organizations_url":"https://api.github.com/users/latkin/orgs","repos_url":"https://api.github.com/users/latkin/repos","events_url":"https://api.github.com/users/latkin/events{/privacy}","received_events_url":"https://api.github.com/users/latkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/latkin/visualfsharp","description":"The Visual F# compiler and tools","fork":true,"url":"https://api.github.com/repos/latkin/visualfsharp","forks_url":"https://api.github.com/repos/latkin/visualfsharp/forks","keys_url":"https://api.github.com/repos/latkin/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/latkin/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/latkin/visualfsharp/teams","hooks_url":"https://api.github.com/repos/latkin/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/latkin/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/latkin/visualfsharp/events","assignees_url":"https://api.github.com/repos/latkin/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/latkin/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/latkin/visualfsharp/tags","blobs_url":"https://api.github.com/repos/latkin/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/latkin/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/latkin/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/latkin/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/latkin/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/latkin/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/latkin/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/latkin/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/latkin/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/latkin/visualfsharp/subscription","commits_url":"https://api.github.com/repos/latkin/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/latkin/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/latkin/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/latkin/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/latkin/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/latkin/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/latkin/visualfsharp/merges","archive_url":"https://api.github.com/repos/latkin/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/latkin/visualfsharp/downloads","issues_url":"https://api.github.com/repos/latkin/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/latkin/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/latkin/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/latkin/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/latkin/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/latkin/visualfsharp/releases{/id}","deployments_url":"https://api.github.com/repos/latkin/visualfsharp/deployments","created_at":"2015-01-28T05:21:31Z","updated_at":"2015-05-05T23:51:10Z","pushed_at":"2016-04-25T15:18:30Z","git_url":"git://github.com/latkin/visualfsharp.git","ssh_url":"git@github.com:latkin/visualfsharp.git","clone_url":"https://github.com/latkin/visualfsharp.git","svn_url":"https://github.com/latkin/visualfsharp","homepage":null,"size":67157,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"fsharp4"}},"base":{"label":"Microsoft:master","ref":"master","sha":"a020a3ad26d173a3375553dfef4b8b4f15d0b56b","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":29048891,"name":"visualfsharp","full_name":"Microsoft/visualfsharp","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/visualfsharp","description":"The Visual F# compiler and tools","fork":false,"url":"https://api.github.com/repos/Microsoft/visualfsharp","forks_url":"https://api.github.com/repos/Microsoft/visualfsharp/forks","keys_url":"https://api.github.com/repos/Microsoft/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/visualfsharp/teams","hooks_url":"https://api.github.com/repos/Microsoft/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/visualfsharp/events","assignees_url":"https://api.github.com/repos/Microsoft/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/tags","blobs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/Microsoft/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscription","commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/visualfsharp/merges","archive_url":"https://api.github.com/repos/Microsoft/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/visualfsharp/downloads","issues_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/visualfsharp/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/visualfsharp/deployments","created_at":"2015-01-10T05:58:43Z","updated_at":"2016-04-25T09:16:08Z","pushed_at":"2016-04-26T08:45:51Z","git_url":"git://github.com/Microsoft/visualfsharp.git","ssh_url":"git@github.com:Microsoft/visualfsharp.git","clone_url":"https://github.com/Microsoft/visualfsharp.git","svn_url":"https://github.com/Microsoft/visualfsharp","homepage":null,"size":224317,"stargazers_count":704,"watchers_count":704,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":174,"mirror_url":null,"open_issues_count":290,"forks":174,"open_issues":290,"watchers":704,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1114"},"html":{"href":"https://github.com/Microsoft/visualfsharp/pull/1114"},"issue":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1114"},"comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/1114/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1114/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/1114/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/4b2849f979114755493fc64204385c6e5913f375"}}}}