{"action":"closed","number":1709,"pull_request":{"url":"https://api.github.com/repos/locaweb/locawebstyle/pulls/1709","id":81550801,"html_url":"https://github.com/locaweb/locawebstyle/pull/1709","diff_url":"https://github.com/locaweb/locawebstyle/pull/1709.diff","patch_url":"https://github.com/locaweb/locawebstyle/pull/1709.patch","issue_url":"https://api.github.com/repos/locaweb/locawebstyle/issues/1709","number":1709,"state":"closed","locked":false,"title":"Refatoração do Módulo Collapse","user":{"login":"itumoraes","id":5097397,"avatar_url":"https://avatars.githubusercontent.com/u/5097397?v=3","gravatar_id":"","url":"https://api.github.com/users/itumoraes","html_url":"https://github.com/itumoraes","followers_url":"https://api.github.com/users/itumoraes/followers","following_url":"https://api.github.com/users/itumoraes/following{/other_user}","gists_url":"https://api.github.com/users/itumoraes/gists{/gist_id}","starred_url":"https://api.github.com/users/itumoraes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itumoraes/subscriptions","organizations_url":"https://api.github.com/users/itumoraes/orgs","repos_url":"https://api.github.com/users/itumoraes/repos","events_url":"https://api.github.com/users/itumoraes/events{/privacy}","received_events_url":"https://api.github.com/users/itumoraes/received_events","type":"User","site_admin":false},"body":"Atualizando um projeto para o Locastyle V3, percebi que a forma como o collapse foi desenvolvido, estava prejudicando o funcionamento de alguns eventos do Rails e do CKEditor.\r\n\r\n1 - Os eventos ajax do Rails (remote) estavam sendo anulados pelo o `e.stopPropagation()` atribuído ao click no `ls-collapse-body`. Devido esse problema, modifiquei o trigger de acionamento do módulo para ser somente o `ls-collapse-header`, que já era o comportamento esperado pelo uso do stopPropagation.\r\n\r\n2 - A utilização do `display: none` para mostrar ou não o collapse, estava interferindo nos eventos do CKEditor que não estavam sendo inicializados de forma correta. A solução para esse problema foi utilizar uma abordagem, escondendo ou não o elemento, através das propriedades `opacity, visibility, overflow, e height`.\r\n\r\n3 - A documentação foi atualizada para explicar melhor a utilização de outros elementos para manipular um collapse.\r\n\r\n4 - A função `toggle` estava na documentação, mas não estava implementada no módulo.\r\n\r\n5 - Foram adicionados alguns testes que estavam faltando no módulo.","created_at":"2016-08-16T21:48:31Z","updated_at":"2016-08-17T12:53:03Z","closed_at":"2016-08-17T12:53:03Z","merged_at":"2016-08-17T12:53:03Z","merge_commit_sha":"991c268574c2dd0960d78dea3796410026ebfd0e","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/locaweb/locawebstyle/milestones/40","html_url":"https://github.com/locaweb/locawebstyle/milestones/3.8.6","labels_url":"https://api.github.com/repos/locaweb/locawebstyle/milestones/40/labels","id":1841742,"number":40,"title":"3.8.6","description":"","creator":{"login":"deividmarques","id":1235904,"avatar_url":"https://avatars.githubusercontent.com/u/1235904?v=3","gravatar_id":"","url":"https://api.github.com/users/deividmarques","html_url":"https://github.com/deividmarques","followers_url":"https://api.github.com/users/deividmarques/followers","following_url":"https://api.github.com/users/deividmarques/following{/other_user}","gists_url":"https://api.github.com/users/deividmarques/gists{/gist_id}","starred_url":"https://api.github.com/users/deividmarques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deividmarques/subscriptions","organizations_url":"https://api.github.com/users/deividmarques/orgs","repos_url":"https://api.github.com/users/deividmarques/repos","events_url":"https://api.github.com/users/deividmarques/events{/privacy}","received_events_url":"https://api.github.com/users/deividmarques/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":7,"state":"open","created_at":"2016-06-21T22:26:55Z","updated_at":"2016-08-17T12:53:03Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/locaweb/locawebstyle/pulls/1709/commits","review_comments_url":"https://api.github.com/repos/locaweb/locawebstyle/pulls/1709/comments","review_comment_url":"https://api.github.com/repos/locaweb/locawebstyle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/locaweb/locawebstyle/issues/1709/comments","statuses_url":"https://api.github.com/repos/locaweb/locawebstyle/statuses/76b78ed319f343b036ba577f12b44357bd16c38e","head":{"label":"locaweb:collapse-body-events","ref":"collapse-body-events","sha":"76b78ed319f343b036ba577f12b44357bd16c38e","user":{"login":"locaweb","id":39917,"avatar_url":"https://avatars.githubusercontent.com/u/39917?v=3","gravatar_id":"","url":"https://api.github.com/users/locaweb","html_url":"https://github.com/locaweb","followers_url":"https://api.github.com/users/locaweb/followers","following_url":"https://api.github.com/users/locaweb/following{/other_user}","gists_url":"https://api.github.com/users/locaweb/gists{/gist_id}","starred_url":"https://api.github.com/users/locaweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locaweb/subscriptions","organizations_url":"https://api.github.com/users/locaweb/orgs","repos_url":"https://api.github.com/users/locaweb/repos","events_url":"https://api.github.com/users/locaweb/events{/privacy}","received_events_url":"https://api.github.com/users/locaweb/received_events","type":"Organization","site_admin":false},"repo":{"id":7628687,"name":"locawebstyle","full_name":"locaweb/locawebstyle","owner":{"login":"locaweb","id":39917,"avatar_url":"https://avatars.githubusercontent.com/u/39917?v=3","gravatar_id":"","url":"https://api.github.com/users/locaweb","html_url":"https://github.com/locaweb","followers_url":"https://api.github.com/users/locaweb/followers","following_url":"https://api.github.com/users/locaweb/following{/other_user}","gists_url":"https://api.github.com/users/locaweb/gists{/gist_id}","starred_url":"https://api.github.com/users/locaweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locaweb/subscriptions","organizations_url":"https://api.github.com/users/locaweb/orgs","repos_url":"https://api.github.com/users/locaweb/repos","events_url":"https://api.github.com/users/locaweb/events{/privacy}","received_events_url":"https://api.github.com/users/locaweb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/locaweb/locawebstyle","description":"Locaweb Style - A framework with CSS and JS patterns to build products admin interface.","fork":false,"url":"https://api.github.com/repos/locaweb/locawebstyle","forks_url":"https://api.github.com/repos/locaweb/locawebstyle/forks","keys_url":"https://api.github.com/repos/locaweb/locawebstyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/locaweb/locawebstyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/locaweb/locawebstyle/teams","hooks_url":"https://api.github.com/repos/locaweb/locawebstyle/hooks","issue_events_url":"https://api.github.com/repos/locaweb/locawebstyle/issues/events{/number}","events_url":"https://api.github.com/repos/locaweb/locawebstyle/events","assignees_url":"https://api.github.com/repos/locaweb/locawebstyle/assignees{/user}","branches_url":"https://api.github.com/repos/locaweb/locawebstyle/branches{/branch}","tags_url":"https://api.github.com/repos/locaweb/locawebstyle/tags","blobs_url":"https://api.github.com/repos/locaweb/locawebstyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/locaweb/locawebstyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/locaweb/locawebstyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/locaweb/locawebstyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/locaweb/locawebstyle/statuses/{sha}","languages_url":"https://api.github.com/repos/locaweb/locawebstyle/languages","stargazers_url":"https://api.github.com/repos/locaweb/locawebstyle/stargazers","contributors_url":"https://api.github.com/repos/locaweb/locawebstyle/contributors","subscribers_url":"https://api.github.com/repos/locaweb/locawebstyle/subscribers","subscription_url":"https://api.github.com/repos/locaweb/locawebstyle/subscription","commits_url":"https://api.github.com/repos/locaweb/locawebstyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/locaweb/locawebstyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/locaweb/locawebstyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/locaweb/locawebstyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/locaweb/locawebstyle/contents/{+path}","compare_url":"https://api.github.com/repos/locaweb/locawebstyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/locaweb/locawebstyle/merges","archive_url":"https://api.github.com/repos/locaweb/locawebstyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/locaweb/locawebstyle/downloads","issues_url":"https://api.github.com/repos/locaweb/locawebstyle/issues{/number}","pulls_url":"https://api.github.com/repos/locaweb/locawebstyle/pulls{/number}","milestones_url":"https://api.github.com/repos/locaweb/locawebstyle/milestones{/number}","notifications_url":"https://api.github.com/repos/locaweb/locawebstyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/locaweb/locawebstyle/labels{/name}","releases_url":"https://api.github.com/repos/locaweb/locawebstyle/releases{/id}","deployments_url":"https://api.github.com/repos/locaweb/locawebstyle/deployments","created_at":"2013-01-15T16:39:08Z","updated_at":"2016-08-17T04:23:07Z","pushed_at":"2016-08-17T12:53:03Z","git_url":"git://github.com/locaweb/locawebstyle.git","ssh_url":"git@github.com:locaweb/locawebstyle.git","clone_url":"https://github.com/locaweb/locawebstyle.git","svn_url":"https://github.com/locaweb/locawebstyle","homepage":"http://locaweb.github.io/locawebstyle/","size":99079,"stargazers_count":280,"watchers_count":280,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":168,"mirror_url":null,"open_issues_count":13,"forks":168,"open_issues":13,"watchers":280,"default_branch":"master"}},"base":{"label":"locaweb:master","ref":"master","sha":"eaf49abf416ddf853abaa1e3a96ed6d399a308b7","user":{"login":"locaweb","id":39917,"avatar_url":"https://avatars.githubusercontent.com/u/39917?v=3","gravatar_id":"","url":"https://api.github.com/users/locaweb","html_url":"https://github.com/locaweb","followers_url":"https://api.github.com/users/locaweb/followers","following_url":"https://api.github.com/users/locaweb/following{/other_user}","gists_url":"https://api.github.com/users/locaweb/gists{/gist_id}","starred_url":"https://api.github.com/users/locaweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locaweb/subscriptions","organizations_url":"https://api.github.com/users/locaweb/orgs","repos_url":"https://api.github.com/users/locaweb/repos","events_url":"https://api.github.com/users/locaweb/events{/privacy}","received_events_url":"https://api.github.com/users/locaweb/received_events","type":"Organization","site_admin":false},"repo":{"id":7628687,"name":"locawebstyle","full_name":"locaweb/locawebstyle","owner":{"login":"locaweb","id":39917,"avatar_url":"https://avatars.githubusercontent.com/u/39917?v=3","gravatar_id":"","url":"https://api.github.com/users/locaweb","html_url":"https://github.com/locaweb","followers_url":"https://api.github.com/users/locaweb/followers","following_url":"https://api.github.com/users/locaweb/following{/other_user}","gists_url":"https://api.github.com/users/locaweb/gists{/gist_id}","starred_url":"https://api.github.com/users/locaweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locaweb/subscriptions","organizations_url":"https://api.github.com/users/locaweb/orgs","repos_url":"https://api.github.com/users/locaweb/repos","events_url":"https://api.github.com/users/locaweb/events{/privacy}","received_events_url":"https://api.github.com/users/locaweb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/locaweb/locawebstyle","description":"Locaweb Style - A framework with CSS and JS patterns to build products admin interface.","fork":false,"url":"https://api.github.com/repos/locaweb/locawebstyle","forks_url":"https://api.github.com/repos/locaweb/locawebstyle/forks","keys_url":"https://api.github.com/repos/locaweb/locawebstyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/locaweb/locawebstyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/locaweb/locawebstyle/teams","hooks_url":"https://api.github.com/repos/locaweb/locawebstyle/hooks","issue_events_url":"https://api.github.com/repos/locaweb/locawebstyle/issues/events{/number}","events_url":"https://api.github.com/repos/locaweb/locawebstyle/events","assignees_url":"https://api.github.com/repos/locaweb/locawebstyle/assignees{/user}","branches_url":"https://api.github.com/repos/locaweb/locawebstyle/branches{/branch}","tags_url":"https://api.github.com/repos/locaweb/locawebstyle/tags","blobs_url":"https://api.github.com/repos/locaweb/locawebstyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/locaweb/locawebstyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/locaweb/locawebstyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/locaweb/locawebstyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/locaweb/locawebstyle/statuses/{sha}","languages_url":"https://api.github.com/repos/locaweb/locawebstyle/languages","stargazers_url":"https://api.github.com/repos/locaweb/locawebstyle/stargazers","contributors_url":"https://api.github.com/repos/locaweb/locawebstyle/contributors","subscribers_url":"https://api.github.com/repos/locaweb/locawebstyle/subscribers","subscription_url":"https://api.github.com/repos/locaweb/locawebstyle/subscription","commits_url":"https://api.github.com/repos/locaweb/locawebstyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/locaweb/locawebstyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/locaweb/locawebstyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/locaweb/locawebstyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/locaweb/locawebstyle/contents/{+path}","compare_url":"https://api.github.com/repos/locaweb/locawebstyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/locaweb/locawebstyle/merges","archive_url":"https://api.github.com/repos/locaweb/locawebstyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/locaweb/locawebstyle/downloads","issues_url":"https://api.github.com/repos/locaweb/locawebstyle/issues{/number}","pulls_url":"https://api.github.com/repos/locaweb/locawebstyle/pulls{/number}","milestones_url":"https://api.github.com/repos/locaweb/locawebstyle/milestones{/number}","notifications_url":"https://api.github.com/repos/locaweb/locawebstyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/locaweb/locawebstyle/labels{/name}","releases_url":"https://api.github.com/repos/locaweb/locawebstyle/releases{/id}","deployments_url":"https://api.github.com/repos/locaweb/locawebstyle/deployments","created_at":"2013-01-15T16:39:08Z","updated_at":"2016-08-17T04:23:07Z","pushed_at":"2016-08-17T12:53:03Z","git_url":"git://github.com/locaweb/locawebstyle.git","ssh_url":"git@github.com:locaweb/locawebstyle.git","clone_url":"https://github.com/locaweb/locawebstyle.git","svn_url":"https://github.com/locaweb/locawebstyle","homepage":"http://locaweb.github.io/locawebstyle/","size":99079,"stargazers_count":280,"watchers_count":280,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":168,"mirror_url":null,"open_issues_count":13,"forks":168,"open_issues":13,"watchers":280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/locaweb/locawebstyle/pulls/1709"},"html":{"href":"https://github.com/locaweb/locawebstyle/pull/1709"},"issue":{"href":"https://api.github.com/repos/locaweb/locawebstyle/issues/1709"},"comments":{"href":"https://api.github.com/repos/locaweb/locawebstyle/issues/1709/comments"},"review_comments":{"href":"https://api.github.com/repos/locaweb/locawebstyle/pulls/1709/comments"},"review_comment":{"href":"https://api.github.com/repos/locaweb/locawebstyle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/locaweb/locawebstyle/pulls/1709/commits"},"statuses":{"href":"https://api.github.com/repos/locaweb/locawebstyle/statuses/76b78ed319f343b036ba577f12b44357bd16c38e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"itumoraes","id":5097397,"avatar_url":"https://avatars.githubusercontent.com/u/5097397?v=3","gravatar_id":"","url":"https://api.github.com/users/itumoraes","html_url":"https://github.com/itumoraes","followers_url":"https://api.github.com/users/itumoraes/followers","following_url":"https://api.github.com/users/itumoraes/following{/other_user}","gists_url":"https://api.github.com/users/itumoraes/gists{/gist_id}","starred_url":"https://api.github.com/users/itumoraes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itumoraes/subscriptions","organizations_url":"https://api.github.com/users/itumoraes/orgs","repos_url":"https://api.github.com/users/itumoraes/repos","events_url":"https://api.github.com/users/itumoraes/events{/privacy}","received_events_url":"https://api.github.com/users/itumoraes/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":4,"additions":141,"deletions":57,"changed_files":7}}
{"actor":{"display_login":"itumoraes"}}