{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/69462426","id":69462426,"diff_hunk":"@@ -28,7 +28,9 @@ import (\n \t\"k8s.io/kubernetes/pkg/api/unversioned\"\n \t\"k8s.io/kubernetes/pkg/apis/extensions\"\n \t\"k8s.io/kubernetes/pkg/controller\"\n-\tdeploymentutil \"k8s.io/kubernetes/pkg/util/deployment\"\n+\n+\tdeploymentutil \"k8s.io/kubernetes/pkg/controller/deployment/util\"\n+","path":"pkg/controller/deployment/sync.go","position":7,"original_position":7,"commit_id":"bb43edbe4cdca1971c4356d141017d2f174fd044","original_commit_id":"bb43edbe4cdca1971c4356d141017d2f174fd044","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"body":"No reason for these newlines","created_at":"2016-07-04T14:05:43Z","updated_at":"2016-07-04T14:05:43Z","html_url":"https://github.com/kubernetes/kubernetes/pull/28161#discussion_r69462426","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28161","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/69462426"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/28161#discussion_r69462426"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28161"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28161","id":75495783,"html_url":"https://github.com/kubernetes/kubernetes/pull/28161","diff_url":"https://github.com/kubernetes/kubernetes/pull/28161.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/28161.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28161","number":28161,"state":"open","locked":false,"title":"Move deployment functions to deployment/util.go not widely used","user":{"login":"asalkeld","id":420707,"avatar_url":"https://avatars.githubusercontent.com/u/420707?v=3","gravatar_id":"","url":"https://api.github.com/users/asalkeld","html_url":"https://github.com/asalkeld","followers_url":"https://api.github.com/users/asalkeld/followers","following_url":"https://api.github.com/users/asalkeld/following{/other_user}","gists_url":"https://api.github.com/users/asalkeld/gists{/gist_id}","starred_url":"https://api.github.com/users/asalkeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asalkeld/subscriptions","organizations_url":"https://api.github.com/users/asalkeld/orgs","repos_url":"https://api.github.com/users/asalkeld/repos","events_url":"https://api.github.com/users/asalkeld/events{/privacy}","received_events_url":"https://api.github.com/users/asalkeld/received_events","type":"User","site_admin":false},"body":"If the function is not used in multiple areas, move it to deployment/util.go\r\n\r\nfixes #26750\r\n","created_at":"2016-06-28T15:16:02Z","updated_at":"2016-07-04T14:05:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ece0c50edd97032c1779abda41c7382e1d98c5dc","assignee":{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false},"assignees":[{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28161/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28161/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28161/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/bb43edbe4cdca1971c4356d141017d2f174fd044","head":{"label":"asalkeld:util_deployment","ref":"util_deployment","sha":"bb43edbe4cdca1971c4356d141017d2f174fd044","user":{"login":"asalkeld","id":420707,"avatar_url":"https://avatars.githubusercontent.com/u/420707?v=3","gravatar_id":"","url":"https://api.github.com/users/asalkeld","html_url":"https://github.com/asalkeld","followers_url":"https://api.github.com/users/asalkeld/followers","following_url":"https://api.github.com/users/asalkeld/following{/other_user}","gists_url":"https://api.github.com/users/asalkeld/gists{/gist_id}","starred_url":"https://api.github.com/users/asalkeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asalkeld/subscriptions","organizations_url":"https://api.github.com/users/asalkeld/orgs","repos_url":"https://api.github.com/users/asalkeld/repos","events_url":"https://api.github.com/users/asalkeld/events{/privacy}","received_events_url":"https://api.github.com/users/asalkeld/received_events","type":"User","site_admin":false},"repo":{"id":58418755,"name":"kubernetes","full_name":"asalkeld/kubernetes","owner":{"login":"asalkeld","id":420707,"avatar_url":"https://avatars.githubusercontent.com/u/420707?v=3","gravatar_id":"","url":"https://api.github.com/users/asalkeld","html_url":"https://github.com/asalkeld","followers_url":"https://api.github.com/users/asalkeld/followers","following_url":"https://api.github.com/users/asalkeld/following{/other_user}","gists_url":"https://api.github.com/users/asalkeld/gists{/gist_id}","starred_url":"https://api.github.com/users/asalkeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asalkeld/subscriptions","organizations_url":"https://api.github.com/users/asalkeld/orgs","repos_url":"https://api.github.com/users/asalkeld/repos","events_url":"https://api.github.com/users/asalkeld/events{/privacy}","received_events_url":"https://api.github.com/users/asalkeld/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asalkeld/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/asalkeld/kubernetes","forks_url":"https://api.github.com/repos/asalkeld/kubernetes/forks","keys_url":"https://api.github.com/repos/asalkeld/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asalkeld/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asalkeld/kubernetes/teams","hooks_url":"https://api.github.com/repos/asalkeld/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/asalkeld/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/asalkeld/kubernetes/events","assignees_url":"https://api.github.com/repos/asalkeld/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/asalkeld/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/asalkeld/kubernetes/tags","blobs_url":"https://api.github.com/repos/asalkeld/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asalkeld/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asalkeld/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/asalkeld/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asalkeld/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/asalkeld/kubernetes/languages","stargazers_url":"https://api.github.com/repos/asalkeld/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/asalkeld/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/asalkeld/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/asalkeld/kubernetes/subscription","commits_url":"https://api.github.com/repos/asalkeld/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/asalkeld/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/asalkeld/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/asalkeld/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/asalkeld/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/asalkeld/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asalkeld/kubernetes/merges","archive_url":"https://api.github.com/repos/asalkeld/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asalkeld/kubernetes/downloads","issues_url":"https://api.github.com/repos/asalkeld/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/asalkeld/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/asalkeld/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/asalkeld/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asalkeld/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/asalkeld/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/asalkeld/kubernetes/deployments","created_at":"2016-05-10T01:04:58Z","updated_at":"2016-05-10T01:05:12Z","pushed_at":"2016-07-04T14:03:25Z","git_url":"git://github.com/asalkeld/kubernetes.git","ssh_url":"git@github.com:asalkeld/kubernetes.git","clone_url":"https://github.com/asalkeld/kubernetes.git","svn_url":"https://github.com/asalkeld/kubernetes","homepage":"http://kubernetes.io","size":278122,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"11211a49e3003b740d3772c1fc5330f577b3f3af","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-07-04T13:56:29Z","pushed_at":"2016-07-04T14:03:26Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":486674,"stargazers_count":15289,"watchers_count":15289,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4771,"mirror_url":null,"open_issues_count":3819,"forks":4771,"open_issues":3819,"watchers":15289,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28161"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/28161"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/28161"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/28161/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28161/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/28161/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/bb43edbe4cdca1971c4356d141017d2f174fd044"}}}}
{"actor":{"display_login":"kargakis"}}