{"action":"created","issue":{"url":"https://api.github.com/repos/d8-contrib-modules/field_encrypt/issues/26","repository_url":"https://api.github.com/repos/d8-contrib-modules/field_encrypt","labels_url":"https://api.github.com/repos/d8-contrib-modules/field_encrypt/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/d8-contrib-modules/field_encrypt/issues/26/comments","events_url":"https://api.github.com/repos/d8-contrib-modules/field_encrypt/issues/26/events","html_url":"https://github.com/d8-contrib-modules/field_encrypt/pull/26","id":139939495,"number":26,"title":"Update entities in batch when field encryption settings change","user":{"login":"svendecabooter","id":201144,"avatar_url":"https://avatars.githubusercontent.com/u/201144?v=3","gravatar_id":"","url":"https://api.github.com/users/svendecabooter","html_url":"https://github.com/svendecabooter","followers_url":"https://api.github.com/users/svendecabooter/followers","following_url":"https://api.github.com/users/svendecabooter/following{/other_user}","gists_url":"https://api.github.com/users/svendecabooter/gists{/gist_id}","starred_url":"https://api.github.com/users/svendecabooter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svendecabooter/subscriptions","organizations_url":"https://api.github.com/users/svendecabooter/orgs","repos_url":"https://api.github.com/users/svendecabooter/repos","events_url":"https://api.github.com/users/svendecabooter/events{/privacy}","received_events_url":"https://api.github.com/users/svendecabooter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-03-10T16:23:24Z","updated_at":"2016-03-12T15:30:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/d8-contrib-modules/field_encrypt/pulls/26","html_url":"https://github.com/d8-contrib-modules/field_encrypt/pull/26","diff_url":"https://github.com/d8-contrib-modules/field_encrypt/pull/26.diff","patch_url":"https://github.com/d8-contrib-modules/field_encrypt/pull/26.patch"},"body":"This PR fixes the following:\r\n\r\n* Re-enable the functionality to update fields when the encryption settings get changed, that was disabled in the last PR (https://github.com/d8-contrib-modules/field_encrypt/pull/25)\r\n* Implement Batch API to update the entities in groups of 5 after field storage settings are changed.\r\n\r\nThis has been tested with the following scenario's:\r\n\r\n* Non-encrypted field gets encryption --> plain text data gets encrypted\r\n* Encrypted field (with method X) settings get changed to use method Y --> encrypted data gets re-encrypted with the new encryption method\r\n* Encrypted field made unencrypted (checkbox unchecked) --> encrypted data gets stored as plain text"},"comment":{"url":"https://api.github.com/repos/d8-contrib-modules/field_encrypt/issues/comments/195761301","html_url":"https://github.com/d8-contrib-modules/field_encrypt/pull/26#issuecomment-195761301","issue_url":"https://api.github.com/repos/d8-contrib-modules/field_encrypt/issues/26","id":195761301,"user":{"login":"nerdstein","id":966547,"avatar_url":"https://avatars.githubusercontent.com/u/966547?v=3","gravatar_id":"","url":"https://api.github.com/users/nerdstein","html_url":"https://github.com/nerdstein","followers_url":"https://api.github.com/users/nerdstein/followers","following_url":"https://api.github.com/users/nerdstein/following{/other_user}","gists_url":"https://api.github.com/users/nerdstein/gists{/gist_id}","starred_url":"https://api.github.com/users/nerdstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerdstein/subscriptions","organizations_url":"https://api.github.com/users/nerdstein/orgs","repos_url":"https://api.github.com/users/nerdstein/repos","events_url":"https://api.github.com/users/nerdstein/events{/privacy}","received_events_url":"https://api.github.com/users/nerdstein/received_events","type":"User","site_admin":false},"created_at":"2016-03-12T15:30:23Z","updated_at":"2016-03-12T15:30:23Z","body":"Code reviewed and it looks really good. Minor comments.\r\n\r\nOne other potential black hole I thought of:\r\n\r\nAre we assuming field config changes happen only on production? These settings are in CMI …. would we possibly need the batch API to run if these config changes happen on another environment? E.g. someone updates a YML file w/ field encrypt settings that are then pushed up to another environment"}}