{"action":"created","issue":{"url":"https://api.github.com/repos/robertzk/s3mpi/issues/47","repository_url":"https://api.github.com/repos/robertzk/s3mpi","labels_url":"https://api.github.com/repos/robertzk/s3mpi/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/robertzk/s3mpi/issues/47/comments","events_url":"https://api.github.com/repos/robertzk/s3mpi/issues/47/events","html_url":"https://github.com/robertzk/s3mpi/pull/47","id":153295160,"number":47,"title":"Add put exists check","user":{"login":"davidboren","id":14277363,"avatar_url":"https://avatars.githubusercontent.com/u/14277363?v=3","gravatar_id":"","url":"https://api.github.com/users/davidboren","html_url":"https://github.com/davidboren","followers_url":"https://api.github.com/users/davidboren/followers","following_url":"https://api.github.com/users/davidboren/following{/other_user}","gists_url":"https://api.github.com/users/davidboren/gists{/gist_id}","starred_url":"https://api.github.com/users/davidboren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidboren/subscriptions","organizations_url":"https://api.github.com/users/davidboren/orgs","repos_url":"https://api.github.com/users/davidboren/repos","events_url":"https://api.github.com/users/davidboren/events{/privacy}","received_events_url":"https://api.github.com/users/davidboren/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-05-05T18:38:02Z","updated_at":"2016-05-05T18:58:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/robertzk/s3mpi/pulls/47","html_url":"https://github.com/robertzk/s3mpi/pull/47","diff_url":"https://github.com/robertzk/s3mpi/pull/47.diff","patch_url":"https://github.com/robertzk/s3mpi/pull/47.patch"},"body":"This is just a quick way of addressing https://github.com/robertzk/s3mpi/issues/46\r\n\r\nIt adds an existence check to s3.put to ensure that the object was correctly uploaded.  This could also be done by checking for the exit code of 2, but then that might change if people change their system s3cmd.  This doesn't seem too unreasonable.  Defaults to checking for existence, but obviously it doesn't have to.  Has a retry loop, but we could remove that and just error out on a bad put (or I could keep the retry logic and error out if the final put is unsuccessful).  Haven't tested it at all yet."},"comment":{"url":"https://api.github.com/repos/robertzk/s3mpi/issues/comments/217243230","html_url":"https://github.com/robertzk/s3mpi/pull/47#issuecomment-217243230","issue_url":"https://api.github.com/repos/robertzk/s3mpi/issues/47","id":217243230,"user":{"login":"davidboren","id":14277363,"avatar_url":"https://avatars.githubusercontent.com/u/14277363?v=3","gravatar_id":"","url":"https://api.github.com/users/davidboren","html_url":"https://github.com/davidboren","followers_url":"https://api.github.com/users/davidboren/followers","following_url":"https://api.github.com/users/davidboren/following{/other_user}","gists_url":"https://api.github.com/users/davidboren/gists{/gist_id}","starred_url":"https://api.github.com/users/davidboren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidboren/subscriptions","organizations_url":"https://api.github.com/users/davidboren/orgs","repos_url":"https://api.github.com/users/davidboren/repos","events_url":"https://api.github.com/users/davidboren/events{/privacy}","received_events_url":"https://api.github.com/users/davidboren/received_events","type":"User","site_admin":false},"created_at":"2016-05-05T18:58:19Z","updated_at":"2016-05-05T18:58:19Z","body":"Yeah, I was thinking we might have trouble there.  I mean, we can always error out. The problem right now is all we're getting is a warning."}}