{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/22489","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/22489/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/22489/comments","events_url":"https://api.github.com/repos/docker/docker/issues/22489/events","html_url":"https://github.com/docker/docker/pull/22489","id":152902358,"number":22489,"title":"Builder shell configuration","user":{"login":"jhowardmsft","id":10522484,"avatar_url":"https://avatars.githubusercontent.com/u/10522484?v=3","gravatar_id":"","url":"https://api.github.com/users/jhowardmsft","html_url":"https://github.com/jhowardmsft","followers_url":"https://api.github.com/users/jhowardmsft/followers","following_url":"https://api.github.com/users/jhowardmsft/following{/other_user}","gists_url":"https://api.github.com/users/jhowardmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jhowardmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhowardmsft/subscriptions","organizations_url":"https://api.github.com/users/jhowardmsft/orgs","repos_url":"https://api.github.com/users/jhowardmsft/repos","events_url":"https://api.github.com/users/jhowardmsft/events{/privacy}","received_events_url":"https://api.github.com/users/jhowardmsft/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/group/distribution","name":"group/distribution","color":"F6FBFF"},{"url":"https://api.github.com/repos/docker/docker/labels/group/windows","name":"group/windows","color":"F6FBFF"},{"url":"https://api.github.com/repos/docker/docker/labels/impact/changelog","name":"impact/changelog","color":"bfe5bf"},{"url":"https://api.github.com/repos/docker/docker/labels/impact/dockerfile","name":"impact/dockerfile","color":"bfe5bf"},{"url":"https://api.github.com/repos/docker/docker/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/53","html_url":"https://github.com/docker/docker/milestones/1.12.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/53/labels","id":1657301,"number":53,"title":"1.12.0","description":"feature/code freeze: June 14th, 2016","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":42,"closed_issues":104,"state":"open","created_at":"2016-03-21T13:47:53Z","updated_at":"2016-05-31T14:49:27Z","due_on":null,"closed_at":null},"comments":25,"created_at":"2016-05-04T00:05:37Z","updated_at":"2016-05-31T19:07:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/22489","html_url":"https://github.com/docker/docker/pull/22489","diff_url":"https://github.com/docker/docker/pull/22489.diff","patch_url":"https://github.com/docker/docker/pull/22489.patch"},"body":"Signed-off-by: John Howard <jhoward@microsoft.com>\r\n\r\nThis PR simplifies, particularly for Windows users, although this is *not* limited to Windows only, the ability to change the default shell when using the shell form for commands in a dockerfile. This alleviates (as put in the documentation update) the two inefficiencies being a) an extra command process (cmd) has been started on Windows and b) the frequent occurrence of `RUN powershell -command foo bar` in Dockerfiles.\r\n\r\nExample (also in doc update) below:\r\n\r\n```\r\nPS E:\\docker\\build\\shell> docker build -t shell  --no-cache=true .\r\nSending build context to Docker daemon 3.072 kB\r\nStep 1 : FROM windowsservercore\r\n ---> dbfee88ee9fd\r\nStep 2 : SHELL powershell -command\r\n ---> Running in 47e4e97b03b5\r\n ---> c7bd22f61e65\r\nRemoving intermediate container 47e4e97b03b5\r\nStep 3 : RUN New-Item -ItemType Directory C:\\\\Example\r\n ---> Running in 1cd80dd20c31\r\n\r\n\r\n    Directory: C:\\\r\n\r\n\r\nMode                LastWriteTime         Length Name\r\n----                -------------         ------ ----\r\nd-----         5/3/2016   5:01 PM                Example\r\n\r\n\r\n ---> 5bf91df219c6\r\nRemoving intermediate container 1cd80dd20c31\r\nStep 4 : WORKDIR C:\\\\Example\r\n ---> Running in 7c45f946effc\r\n ---> 98a52497e225\r\nRemoving intermediate container 7c45f946effc\r\nStep 5 : ADD Execute-MyCmdlet.ps1 .\r\n ---> 5363cf797edb\r\nRemoving intermediate container d8d0ecc4f532\r\nStep 6 : RUN .\\Execute-MyCmdlet -sample 'hello world'\r\n ---> Running in 00019129cfc3\r\nHello from Execute-MyCmdlet.ps1 - passed hello world\r\n ---> c7d63c58e196\r\nRemoving intermediate container 00019129cfc3\r\nSuccessfully built c7d63c58e196\r\nPS E:\\docker\\build\\shell>\r\n```\r\n\r\n\r\n@taylorb-microsoft\r\n"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/222788822","html_url":"https://github.com/docker/docker/pull/22489#issuecomment-222788822","issue_url":"https://api.github.com/repos/docker/docker/issues/22489","id":222788822,"user":{"login":"justincormack","id":482364,"avatar_url":"https://avatars.githubusercontent.com/u/482364?v=3","gravatar_id":"","url":"https://api.github.com/users/justincormack","html_url":"https://github.com/justincormack","followers_url":"https://api.github.com/users/justincormack/followers","following_url":"https://api.github.com/users/justincormack/following{/other_user}","gists_url":"https://api.github.com/users/justincormack/gists{/gist_id}","starred_url":"https://api.github.com/users/justincormack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justincormack/subscriptions","organizations_url":"https://api.github.com/users/justincormack/orgs","repos_url":"https://api.github.com/users/justincormack/repos","events_url":"https://api.github.com/users/justincormack/events{/privacy}","received_events_url":"https://api.github.com/users/justincormack/received_events","type":"User","site_admin":false},"created_at":"2016-05-31T19:07:19Z","updated_at":"2016-05-31T19:07:19Z","body":"1-3 all seem fine as per @jhowardmsft as far as I can see. I am not in favour of inheritance, it is useful to have an inherited output state at runtime, but this is not meaningful at runtime so it makes no sense inheriting it, it just makes it confusing. I see it as a modification of the meaning of the non-json specified commands in the Dockerfile, affecting their conversion to json, and much more like `ESCAPE`."}}
{"actor":{"display_login":"justincormack"}}