{"action":"created","comment":{"url":"https://api.github.com/repos/agentrickard/domain/pulls/comments/75388842","id":75388842,"diff_hunk":"@@ -160,7 +160,7 @@ protected function drupalUserIsLoggedIn($account) {\n    * @param string $field\n    *   The name of the domain field used to attach to the entity.\n    */\n-  public function addDomainToEntity($entity_type, $entity_id, $id, $field = DOMAIN_ACCESS_FIELD) {\n+  public function addDomainToEntity($entity_type, $entity_id, $id, $field = Constants::DOMAIN_ACCESS_FIELD) {","path":"domain/src/Tests/DomainTestBase.php","position":null,"original_position":5,"commit_id":"a5199ad531f36655f0594db56d5562d7db8d04a1","original_commit_id":"a1bc56b9b56be479cc67bf2bd883b9dbde3e5140","user":{"login":"agentrickard","id":360988,"avatar_url":"https://avatars.githubusercontent.com/u/360988?v=3","gravatar_id":"","url":"https://api.github.com/users/agentrickard","html_url":"https://github.com/agentrickard","followers_url":"https://api.github.com/users/agentrickard/followers","following_url":"https://api.github.com/users/agentrickard/following{/other_user}","gists_url":"https://api.github.com/users/agentrickard/gists{/gist_id}","starred_url":"https://api.github.com/users/agentrickard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agentrickard/subscriptions","organizations_url":"https://api.github.com/users/agentrickard/orgs","repos_url":"https://api.github.com/users/agentrickard/repos","events_url":"https://api.github.com/users/agentrickard/events{/privacy}","received_events_url":"https://api.github.com/users/agentrickard/received_events","type":"User","site_admin":false},"body":"This is still Constants::","created_at":"2016-08-18T21:03:31Z","updated_at":"2016-08-18T21:03:31Z","html_url":"https://github.com/agentrickard/domain/pull/261#discussion_r75388842","pull_request_url":"https://api.github.com/repos/agentrickard/domain/pulls/261","_links":{"self":{"href":"https://api.github.com/repos/agentrickard/domain/pulls/comments/75388842"},"html":{"href":"https://github.com/agentrickard/domain/pull/261#discussion_r75388842"},"pull_request":{"href":"https://api.github.com/repos/agentrickard/domain/pulls/261"}}},"pull_request":{"url":"https://api.github.com/repos/agentrickard/domain/pulls/261","id":81308441,"html_url":"https://github.com/agentrickard/domain/pull/261","diff_url":"https://github.com/agentrickard/domain/pull/261.diff","patch_url":"https://github.com/agentrickard/domain/pull/261.patch","issue_url":"https://api.github.com/repos/agentrickard/domain/issues/261","number":261,"state":"open","locked":false,"title":"defines are not loaded in all contexts","user":{"login":"kdebisschop","id":1213025,"avatar_url":"https://avatars.githubusercontent.com/u/1213025?v=3","gravatar_id":"","url":"https://api.github.com/users/kdebisschop","html_url":"https://github.com/kdebisschop","followers_url":"https://api.github.com/users/kdebisschop/followers","following_url":"https://api.github.com/users/kdebisschop/following{/other_user}","gists_url":"https://api.github.com/users/kdebisschop/gists{/gist_id}","starred_url":"https://api.github.com/users/kdebisschop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdebisschop/subscriptions","organizations_url":"https://api.github.com/users/kdebisschop/orgs","repos_url":"https://api.github.com/users/kdebisschop/repos","events_url":"https://api.github.com/users/kdebisschop/events{/privacy}","received_events_url":"https://api.github.com/users/kdebisschop/received_events","type":"User","site_admin":false},"body":"We are getting this error in our PHP error logs:\r\n\r\n> PHP Notice:  Use of undefined constant DOMAIN_MATCH_EXACT - assumed 'DOMAIN_MATCH_EXACT' in /mnt/www/html/fensitestg/docroot/modules/domain/domain/src/DomainNegotiator.php on line 72\r\n\r\nIn some requests, the defined constants in **domain.module** are not available under Drupal 8. I offer a single unified constants file as one way to ensure the constant is there across the various modules that are part of the **domain** repository. If you think this is not the best way to address the issue, I'd be glad to hear your thoughts and submit an alternate pull request.\r\n\r\nThe most obvious alternative to me was to create separate constant files for **domain** and **domain_access**. But since **domain_content** also relies on the `DOMAIN_ACCESS_*` constants, it seemed sensible to me to rely on the fact that the **domain_*** modules depend on the **domain** modules and just out them all in one file.","created_at":"2016-08-15T13:00:14Z","updated_at":"2016-08-18T21:03:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2daa27f0a5b59aca707f7ef0d59eb0efe3778e3f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/agentrickard/domain/pulls/261/commits","review_comments_url":"https://api.github.com/repos/agentrickard/domain/pulls/261/comments","review_comment_url":"https://api.github.com/repos/agentrickard/domain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/agentrickard/domain/issues/261/comments","statuses_url":"https://api.github.com/repos/agentrickard/domain/statuses/a5199ad531f36655f0594db56d5562d7db8d04a1","head":{"label":"kdebisschop:8.x-1.x","ref":"8.x-1.x","sha":"a5199ad531f36655f0594db56d5562d7db8d04a1","user":{"login":"kdebisschop","id":1213025,"avatar_url":"https://avatars.githubusercontent.com/u/1213025?v=3","gravatar_id":"","url":"https://api.github.com/users/kdebisschop","html_url":"https://github.com/kdebisschop","followers_url":"https://api.github.com/users/kdebisschop/followers","following_url":"https://api.github.com/users/kdebisschop/following{/other_user}","gists_url":"https://api.github.com/users/kdebisschop/gists{/gist_id}","starred_url":"https://api.github.com/users/kdebisschop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdebisschop/subscriptions","organizations_url":"https://api.github.com/users/kdebisschop/orgs","repos_url":"https://api.github.com/users/kdebisschop/repos","events_url":"https://api.github.com/users/kdebisschop/events{/privacy}","received_events_url":"https://api.github.com/users/kdebisschop/received_events","type":"User","site_admin":false},"repo":{"id":65617182,"name":"domain","full_name":"kdebisschop/domain","owner":{"login":"kdebisschop","id":1213025,"avatar_url":"https://avatars.githubusercontent.com/u/1213025?v=3","gravatar_id":"","url":"https://api.github.com/users/kdebisschop","html_url":"https://github.com/kdebisschop","followers_url":"https://api.github.com/users/kdebisschop/followers","following_url":"https://api.github.com/users/kdebisschop/following{/other_user}","gists_url":"https://api.github.com/users/kdebisschop/gists{/gist_id}","starred_url":"https://api.github.com/users/kdebisschop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdebisschop/subscriptions","organizations_url":"https://api.github.com/users/kdebisschop/orgs","repos_url":"https://api.github.com/users/kdebisschop/repos","events_url":"https://api.github.com/users/kdebisschop/events{/privacy}","received_events_url":"https://api.github.com/users/kdebisschop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kdebisschop/domain","description":"Domain module for Drupal port to Drupal 8.","fork":true,"url":"https://api.github.com/repos/kdebisschop/domain","forks_url":"https://api.github.com/repos/kdebisschop/domain/forks","keys_url":"https://api.github.com/repos/kdebisschop/domain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kdebisschop/domain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kdebisschop/domain/teams","hooks_url":"https://api.github.com/repos/kdebisschop/domain/hooks","issue_events_url":"https://api.github.com/repos/kdebisschop/domain/issues/events{/number}","events_url":"https://api.github.com/repos/kdebisschop/domain/events","assignees_url":"https://api.github.com/repos/kdebisschop/domain/assignees{/user}","branches_url":"https://api.github.com/repos/kdebisschop/domain/branches{/branch}","tags_url":"https://api.github.com/repos/kdebisschop/domain/tags","blobs_url":"https://api.github.com/repos/kdebisschop/domain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kdebisschop/domain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kdebisschop/domain/git/refs{/sha}","trees_url":"https://api.github.com/repos/kdebisschop/domain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kdebisschop/domain/statuses/{sha}","languages_url":"https://api.github.com/repos/kdebisschop/domain/languages","stargazers_url":"https://api.github.com/repos/kdebisschop/domain/stargazers","contributors_url":"https://api.github.com/repos/kdebisschop/domain/contributors","subscribers_url":"https://api.github.com/repos/kdebisschop/domain/subscribers","subscription_url":"https://api.github.com/repos/kdebisschop/domain/subscription","commits_url":"https://api.github.com/repos/kdebisschop/domain/commits{/sha}","git_commits_url":"https://api.github.com/repos/kdebisschop/domain/git/commits{/sha}","comments_url":"https://api.github.com/repos/kdebisschop/domain/comments{/number}","issue_comment_url":"https://api.github.com/repos/kdebisschop/domain/issues/comments{/number}","contents_url":"https://api.github.com/repos/kdebisschop/domain/contents/{+path}","compare_url":"https://api.github.com/repos/kdebisschop/domain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kdebisschop/domain/merges","archive_url":"https://api.github.com/repos/kdebisschop/domain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kdebisschop/domain/downloads","issues_url":"https://api.github.com/repos/kdebisschop/domain/issues{/number}","pulls_url":"https://api.github.com/repos/kdebisschop/domain/pulls{/number}","milestones_url":"https://api.github.com/repos/kdebisschop/domain/milestones{/number}","notifications_url":"https://api.github.com/repos/kdebisschop/domain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kdebisschop/domain/labels{/name}","releases_url":"https://api.github.com/repos/kdebisschop/domain/releases{/id}","deployments_url":"https://api.github.com/repos/kdebisschop/domain/deployments","created_at":"2016-08-13T12:56:45Z","updated_at":"2016-08-13T12:56:47Z","pushed_at":"2016-08-18T21:03:23Z","git_url":"git://github.com/kdebisschop/domain.git","ssh_url":"git@github.com:kdebisschop/domain.git","clone_url":"https://github.com/kdebisschop/domain.git","svn_url":"https://github.com/kdebisschop/domain","homepage":null,"size":1085,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"8.x-1.x"}},"base":{"label":"agentrickard:8.x-1.x","ref":"8.x-1.x","sha":"bcadcb2fe5aafc019cfe417f76ec37a63b4ed160","user":{"login":"agentrickard","id":360988,"avatar_url":"https://avatars.githubusercontent.com/u/360988?v=3","gravatar_id":"","url":"https://api.github.com/users/agentrickard","html_url":"https://github.com/agentrickard","followers_url":"https://api.github.com/users/agentrickard/followers","following_url":"https://api.github.com/users/agentrickard/following{/other_user}","gists_url":"https://api.github.com/users/agentrickard/gists{/gist_id}","starred_url":"https://api.github.com/users/agentrickard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agentrickard/subscriptions","organizations_url":"https://api.github.com/users/agentrickard/orgs","repos_url":"https://api.github.com/users/agentrickard/repos","events_url":"https://api.github.com/users/agentrickard/events{/privacy}","received_events_url":"https://api.github.com/users/agentrickard/received_events","type":"User","site_admin":false},"repo":{"id":12140101,"name":"domain","full_name":"agentrickard/domain","owner":{"login":"agentrickard","id":360988,"avatar_url":"https://avatars.githubusercontent.com/u/360988?v=3","gravatar_id":"","url":"https://api.github.com/users/agentrickard","html_url":"https://github.com/agentrickard","followers_url":"https://api.github.com/users/agentrickard/followers","following_url":"https://api.github.com/users/agentrickard/following{/other_user}","gists_url":"https://api.github.com/users/agentrickard/gists{/gist_id}","starred_url":"https://api.github.com/users/agentrickard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agentrickard/subscriptions","organizations_url":"https://api.github.com/users/agentrickard/orgs","repos_url":"https://api.github.com/users/agentrickard/repos","events_url":"https://api.github.com/users/agentrickard/events{/privacy}","received_events_url":"https://api.github.com/users/agentrickard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agentrickard/domain","description":"Domain module for Drupal port to Drupal 8.","fork":false,"url":"https://api.github.com/repos/agentrickard/domain","forks_url":"https://api.github.com/repos/agentrickard/domain/forks","keys_url":"https://api.github.com/repos/agentrickard/domain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agentrickard/domain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agentrickard/domain/teams","hooks_url":"https://api.github.com/repos/agentrickard/domain/hooks","issue_events_url":"https://api.github.com/repos/agentrickard/domain/issues/events{/number}","events_url":"https://api.github.com/repos/agentrickard/domain/events","assignees_url":"https://api.github.com/repos/agentrickard/domain/assignees{/user}","branches_url":"https://api.github.com/repos/agentrickard/domain/branches{/branch}","tags_url":"https://api.github.com/repos/agentrickard/domain/tags","blobs_url":"https://api.github.com/repos/agentrickard/domain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agentrickard/domain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agentrickard/domain/git/refs{/sha}","trees_url":"https://api.github.com/repos/agentrickard/domain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agentrickard/domain/statuses/{sha}","languages_url":"https://api.github.com/repos/agentrickard/domain/languages","stargazers_url":"https://api.github.com/repos/agentrickard/domain/stargazers","contributors_url":"https://api.github.com/repos/agentrickard/domain/contributors","subscribers_url":"https://api.github.com/repos/agentrickard/domain/subscribers","subscription_url":"https://api.github.com/repos/agentrickard/domain/subscription","commits_url":"https://api.github.com/repos/agentrickard/domain/commits{/sha}","git_commits_url":"https://api.github.com/repos/agentrickard/domain/git/commits{/sha}","comments_url":"https://api.github.com/repos/agentrickard/domain/comments{/number}","issue_comment_url":"https://api.github.com/repos/agentrickard/domain/issues/comments{/number}","contents_url":"https://api.github.com/repos/agentrickard/domain/contents/{+path}","compare_url":"https://api.github.com/repos/agentrickard/domain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agentrickard/domain/merges","archive_url":"https://api.github.com/repos/agentrickard/domain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agentrickard/domain/downloads","issues_url":"https://api.github.com/repos/agentrickard/domain/issues{/number}","pulls_url":"https://api.github.com/repos/agentrickard/domain/pulls{/number}","milestones_url":"https://api.github.com/repos/agentrickard/domain/milestones{/number}","notifications_url":"https://api.github.com/repos/agentrickard/domain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agentrickard/domain/labels{/name}","releases_url":"https://api.github.com/repos/agentrickard/domain/releases{/id}","deployments_url":"https://api.github.com/repos/agentrickard/domain/deployments","created_at":"2013-08-15T17:57:16Z","updated_at":"2016-08-09T15:13:05Z","pushed_at":"2016-08-18T21:03:24Z","git_url":"git://github.com/agentrickard/domain.git","ssh_url":"git@github.com:agentrickard/domain.git","clone_url":"https://github.com/agentrickard/domain.git","svn_url":"https://github.com/agentrickard/domain","homepage":null,"size":1148,"stargazers_count":42,"watchers_count":42,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":68,"forks":38,"open_issues":68,"watchers":42,"default_branch":"8.x-1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/agentrickard/domain/pulls/261"},"html":{"href":"https://github.com/agentrickard/domain/pull/261"},"issue":{"href":"https://api.github.com/repos/agentrickard/domain/issues/261"},"comments":{"href":"https://api.github.com/repos/agentrickard/domain/issues/261/comments"},"review_comments":{"href":"https://api.github.com/repos/agentrickard/domain/pulls/261/comments"},"review_comment":{"href":"https://api.github.com/repos/agentrickard/domain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/agentrickard/domain/pulls/261/commits"},"statuses":{"href":"https://api.github.com/repos/agentrickard/domain/statuses/a5199ad531f36655f0594db56d5562d7db8d04a1"}}}}
{"actor":{"display_login":"agentrickard"}}