{"action":"created","issue":{"url":"https://api.github.com/repos/mpv-player/mpv/issues/3002","repository_url":"https://api.github.com/repos/mpv-player/mpv","labels_url":"https://api.github.com/repos/mpv-player/mpv/issues/3002/labels{/name}","comments_url":"https://api.github.com/repos/mpv-player/mpv/issues/3002/comments","events_url":"https://api.github.com/repos/mpv-player/mpv/issues/3002/events","html_url":"https://github.com/mpv-player/mpv/pull/3002","id":144093771,"number":3002,"title":"vo_opengl: generate 3DLUT against source and use full BT.1886","user":{"login":"haasn","id":1149047,"avatar_url":"https://avatars.githubusercontent.com/u/1149047?v=3","gravatar_id":"","url":"https://api.github.com/users/haasn","html_url":"https://github.com/haasn","followers_url":"https://api.github.com/users/haasn/followers","following_url":"https://api.github.com/users/haasn/following{/other_user}","gists_url":"https://api.github.com/users/haasn/gists{/gist_id}","starred_url":"https://api.github.com/users/haasn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haasn/subscriptions","organizations_url":"https://api.github.com/users/haasn/orgs","repos_url":"https://api.github.com/users/haasn/repos","events_url":"https://api.github.com/users/haasn/events{/privacy}","received_events_url":"https://api.github.com/users/haasn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":28,"created_at":"2016-03-28T21:57:37Z","updated_at":"2016-03-30T22:29:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mpv-player/mpv/pulls/3002","html_url":"https://github.com/mpv-player/mpv/pull/3002","diff_url":"https://github.com/mpv-player/mpv/pull/3002.diff","patch_url":"https://github.com/mpv-player/mpv/pull/3002.patch"},"body":"This commit refactors the 3DLUT loading mechanism to build the 3DLUT\r\nagainst the original source characteristics of the file. This allows us,\r\namong other things, to use a real BT.1886 profile for the source. This\r\nalso allows us to actually use perceptual mappings. Finally, this\r\nreduces errors on standard gamut displays (where the previous 3DLUT\r\ntarget of BT.2020 was unreasonably wide).\r\n\r\nThis also improves the overall accuracy of the 3DLUT due to eliminating\r\nrounding errors where possible, and allows for more accurate use of\r\nLUT-based ICC profiles.\r\n\r\nThe current code is somewhat more ugly than necessary, because the idea\r\nwas to implement this commit in a working state first, and then maybe\r\nrefactor the profile loading mechanism in a later commit.\r\n\r\nFixes #2815."},"comment":{"url":"https://api.github.com/repos/mpv-player/mpv/issues/comments/203667649","html_url":"https://github.com/mpv-player/mpv/pull/3002#issuecomment-203667649","issue_url":"https://api.github.com/repos/mpv-player/mpv/issues/3002","id":203667649,"user":{"login":"UliZappe","id":6627065,"avatar_url":"https://avatars.githubusercontent.com/u/6627065?v=3","gravatar_id":"","url":"https://api.github.com/users/UliZappe","html_url":"https://github.com/UliZappe","followers_url":"https://api.github.com/users/UliZappe/followers","following_url":"https://api.github.com/users/UliZappe/following{/other_user}","gists_url":"https://api.github.com/users/UliZappe/gists{/gist_id}","starred_url":"https://api.github.com/users/UliZappe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UliZappe/subscriptions","organizations_url":"https://api.github.com/users/UliZappe/orgs","repos_url":"https://api.github.com/users/UliZappe/repos","events_url":"https://api.github.com/users/UliZappe/events{/privacy}","received_events_url":"https://api.github.com/users/UliZappe/received_events","type":"User","site_admin":false},"created_at":"2016-03-30T22:29:56Z","updated_at":"2016-03-30T22:29:56Z","body":">>I don't know of any CMMs that silently substitute a gamma 2.2 TRC for an sRGB TRC\r\n\r\n>Surely this sentence also goes both ways?\r\n\r\nUhm, nope, _substitute A **for** B_ unambiguously means _replace B with A_.\r\n\r\n(_substitute A **with** B_, OTOH, means _replace A with B_. Yeah, I know … :sunglasses:)\r\n\r\n>>Why should a CMM use the more complex sRGB TRC instead of a simple gamma 2.2?\r\n\r\n>And this sentence goes the other direction! We were talking about whether or not any CMM replaced a specified sRGB TRC by a gamma 2.2 TRC when doing the actual calculations. Not the other way around.\r\n\r\nI only expressed my amazement that Adobe obviously does this. There was no connection with our discussion."}}