{"action":"created","comment":{"url":"https://api.github.com/repos/gentoo/portage/pulls/comments/63743538","id":63743538,"diff_hunk":"@@ -33,6 +33,21 @@ openrc_check() {\n \t\t\tdone\n \t\tdone\n \tfi\n+\n+\t# Make sure deprecated #!/sbin/runscript isn't being used:\n+\tif [[ ! -d \"${ED}\"/etc/init.d ]] ; then","path":"bin/install-qa-check.d/60openrc","position":6,"original_position":6,"commit_id":"7e83e095b2af4f3e2d2b9469189105f001501a6b","original_commit_id":"7e83e095b2af4f3e2d2b9469189105f001501a6b","user":{"login":"austin987","id":464648,"avatar_url":"https://avatars.githubusercontent.com/u/464648?v=3","gravatar_id":"","url":"https://api.github.com/users/austin987","html_url":"https://github.com/austin987","followers_url":"https://api.github.com/users/austin987/followers","following_url":"https://api.github.com/users/austin987/following{/other_user}","gists_url":"https://api.github.com/users/austin987/gists{/gist_id}","starred_url":"https://api.github.com/users/austin987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austin987/subscriptions","organizations_url":"https://api.github.com/users/austin987/orgs","repos_url":"https://api.github.com/users/austin987/repos","events_url":"https://api.github.com/users/austin987/events{/privacy}","received_events_url":"https://api.github.com/users/austin987/received_events","type":"User","site_admin":false},"body":"Again, it's done earlier in the file (and more clear IMO to match other uses of the same variable).","created_at":"2016-05-18T17:10:54Z","updated_at":"2016-05-18T17:10:54Z","html_url":"https://github.com/gentoo/portage/pull/27#discussion_r63743538","pull_request_url":"https://api.github.com/repos/gentoo/portage/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/gentoo/portage/pulls/comments/63743538"},"html":{"href":"https://github.com/gentoo/portage/pull/27#discussion_r63743538"},"pull_request":{"href":"https://api.github.com/repos/gentoo/portage/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/gentoo/portage/pulls/27","id":70480846,"html_url":"https://github.com/gentoo/portage/pull/27","diff_url":"https://github.com/gentoo/portage/pull/27.diff","patch_url":"https://github.com/gentoo/portage/pull/27.patch","issue_url":"https://api.github.com/repos/gentoo/portage/issues/27","number":27,"state":"open","locked":false,"title":"install-qa-check.d/60openrc: make sure initscrips aren't using #!/sbin/runscript","user":{"login":"austin987","id":464648,"avatar_url":"https://avatars.githubusercontent.com/u/464648?v=3","gravatar_id":"","url":"https://api.github.com/users/austin987","html_url":"https://github.com/austin987","followers_url":"https://api.github.com/users/austin987/followers","following_url":"https://api.github.com/users/austin987/following{/other_user}","gists_url":"https://api.github.com/users/austin987/gists{/gist_id}","starred_url":"https://api.github.com/users/austin987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austin987/subscriptions","organizations_url":"https://api.github.com/users/austin987/orgs","repos_url":"https://api.github.com/users/austin987/repos","events_url":"https://api.github.com/users/austin987/events{/privacy}","received_events_url":"https://api.github.com/users/austin987/received_events","type":"User","site_admin":false},"body":"Now that everything in the tree uses openrc-run, block using runscript","created_at":"2016-05-18T07:34:17Z","updated_at":"2016-05-18T17:10:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"143257b2371f2165ed9cddb80ad8215265062ee5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gentoo/portage/pulls/27/commits","review_comments_url":"https://api.github.com/repos/gentoo/portage/pulls/27/comments","review_comment_url":"https://api.github.com/repos/gentoo/portage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gentoo/portage/issues/27/comments","statuses_url":"https://api.github.com/repos/gentoo/portage/statuses/7e83e095b2af4f3e2d2b9469189105f001501a6b","head":{"label":"austin987:deprecate-runscript","ref":"deprecate-runscript","sha":"7e83e095b2af4f3e2d2b9469189105f001501a6b","user":{"login":"austin987","id":464648,"avatar_url":"https://avatars.githubusercontent.com/u/464648?v=3","gravatar_id":"","url":"https://api.github.com/users/austin987","html_url":"https://github.com/austin987","followers_url":"https://api.github.com/users/austin987/followers","following_url":"https://api.github.com/users/austin987/following{/other_user}","gists_url":"https://api.github.com/users/austin987/gists{/gist_id}","starred_url":"https://api.github.com/users/austin987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austin987/subscriptions","organizations_url":"https://api.github.com/users/austin987/orgs","repos_url":"https://api.github.com/users/austin987/repos","events_url":"https://api.github.com/users/austin987/events{/privacy}","received_events_url":"https://api.github.com/users/austin987/received_events","type":"User","site_admin":false},"repo":{"id":59092408,"name":"portage","full_name":"austin987/portage","owner":{"login":"austin987","id":464648,"avatar_url":"https://avatars.githubusercontent.com/u/464648?v=3","gravatar_id":"","url":"https://api.github.com/users/austin987","html_url":"https://github.com/austin987","followers_url":"https://api.github.com/users/austin987/followers","following_url":"https://api.github.com/users/austin987/following{/other_user}","gists_url":"https://api.github.com/users/austin987/gists{/gist_id}","starred_url":"https://api.github.com/users/austin987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austin987/subscriptions","organizations_url":"https://api.github.com/users/austin987/orgs","repos_url":"https://api.github.com/users/austin987/repos","events_url":"https://api.github.com/users/austin987/events{/privacy}","received_events_url":"https://api.github.com/users/austin987/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/austin987/portage","description":"Portage Package Manager - this is just a mirror, send patches to <gentoo-portage-dev@lists.gentoo.org>","fork":true,"url":"https://api.github.com/repos/austin987/portage","forks_url":"https://api.github.com/repos/austin987/portage/forks","keys_url":"https://api.github.com/repos/austin987/portage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/austin987/portage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/austin987/portage/teams","hooks_url":"https://api.github.com/repos/austin987/portage/hooks","issue_events_url":"https://api.github.com/repos/austin987/portage/issues/events{/number}","events_url":"https://api.github.com/repos/austin987/portage/events","assignees_url":"https://api.github.com/repos/austin987/portage/assignees{/user}","branches_url":"https://api.github.com/repos/austin987/portage/branches{/branch}","tags_url":"https://api.github.com/repos/austin987/portage/tags","blobs_url":"https://api.github.com/repos/austin987/portage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/austin987/portage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/austin987/portage/git/refs{/sha}","trees_url":"https://api.github.com/repos/austin987/portage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/austin987/portage/statuses/{sha}","languages_url":"https://api.github.com/repos/austin987/portage/languages","stargazers_url":"https://api.github.com/repos/austin987/portage/stargazers","contributors_url":"https://api.github.com/repos/austin987/portage/contributors","subscribers_url":"https://api.github.com/repos/austin987/portage/subscribers","subscription_url":"https://api.github.com/repos/austin987/portage/subscription","commits_url":"https://api.github.com/repos/austin987/portage/commits{/sha}","git_commits_url":"https://api.github.com/repos/austin987/portage/git/commits{/sha}","comments_url":"https://api.github.com/repos/austin987/portage/comments{/number}","issue_comment_url":"https://api.github.com/repos/austin987/portage/issues/comments{/number}","contents_url":"https://api.github.com/repos/austin987/portage/contents/{+path}","compare_url":"https://api.github.com/repos/austin987/portage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/austin987/portage/merges","archive_url":"https://api.github.com/repos/austin987/portage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/austin987/portage/downloads","issues_url":"https://api.github.com/repos/austin987/portage/issues{/number}","pulls_url":"https://api.github.com/repos/austin987/portage/pulls{/number}","milestones_url":"https://api.github.com/repos/austin987/portage/milestones{/number}","notifications_url":"https://api.github.com/repos/austin987/portage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/austin987/portage/labels{/name}","releases_url":"https://api.github.com/repos/austin987/portage/releases{/id}","deployments_url":"https://api.github.com/repos/austin987/portage/deployments","created_at":"2016-05-18T07:31:14Z","updated_at":"2016-05-18T07:31:17Z","pushed_at":"2016-05-18T16:21:08Z","git_url":"git://github.com/austin987/portage.git","ssh_url":"git@github.com:austin987/portage.git","clone_url":"https://github.com/austin987/portage.git","svn_url":"https://github.com/austin987/portage","homepage":"","size":27226,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gentoo:master","ref":"master","sha":"363355277eca757af4c435a0592c1feedc31a097","user":{"login":"gentoo","id":52242,"avatar_url":"https://avatars.githubusercontent.com/u/52242?v=3","gravatar_id":"","url":"https://api.github.com/users/gentoo","html_url":"https://github.com/gentoo","followers_url":"https://api.github.com/users/gentoo/followers","following_url":"https://api.github.com/users/gentoo/following{/other_user}","gists_url":"https://api.github.com/users/gentoo/gists{/gist_id}","starred_url":"https://api.github.com/users/gentoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gentoo/subscriptions","organizations_url":"https://api.github.com/users/gentoo/orgs","repos_url":"https://api.github.com/users/gentoo/repos","events_url":"https://api.github.com/users/gentoo/events{/privacy}","received_events_url":"https://api.github.com/users/gentoo/received_events","type":"Organization","site_admin":false},"repo":{"id":15839027,"name":"portage","full_name":"gentoo/portage","owner":{"login":"gentoo","id":52242,"avatar_url":"https://avatars.githubusercontent.com/u/52242?v=3","gravatar_id":"","url":"https://api.github.com/users/gentoo","html_url":"https://github.com/gentoo","followers_url":"https://api.github.com/users/gentoo/followers","following_url":"https://api.github.com/users/gentoo/following{/other_user}","gists_url":"https://api.github.com/users/gentoo/gists{/gist_id}","starred_url":"https://api.github.com/users/gentoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gentoo/subscriptions","organizations_url":"https://api.github.com/users/gentoo/orgs","repos_url":"https://api.github.com/users/gentoo/repos","events_url":"https://api.github.com/users/gentoo/events{/privacy}","received_events_url":"https://api.github.com/users/gentoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gentoo/portage","description":"Portage Package Manager - this is just a mirror, send patches to <gentoo-portage-dev@lists.gentoo.org>","fork":false,"url":"https://api.github.com/repos/gentoo/portage","forks_url":"https://api.github.com/repos/gentoo/portage/forks","keys_url":"https://api.github.com/repos/gentoo/portage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gentoo/portage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gentoo/portage/teams","hooks_url":"https://api.github.com/repos/gentoo/portage/hooks","issue_events_url":"https://api.github.com/repos/gentoo/portage/issues/events{/number}","events_url":"https://api.github.com/repos/gentoo/portage/events","assignees_url":"https://api.github.com/repos/gentoo/portage/assignees{/user}","branches_url":"https://api.github.com/repos/gentoo/portage/branches{/branch}","tags_url":"https://api.github.com/repos/gentoo/portage/tags","blobs_url":"https://api.github.com/repos/gentoo/portage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gentoo/portage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gentoo/portage/git/refs{/sha}","trees_url":"https://api.github.com/repos/gentoo/portage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gentoo/portage/statuses/{sha}","languages_url":"https://api.github.com/repos/gentoo/portage/languages","stargazers_url":"https://api.github.com/repos/gentoo/portage/stargazers","contributors_url":"https://api.github.com/repos/gentoo/portage/contributors","subscribers_url":"https://api.github.com/repos/gentoo/portage/subscribers","subscription_url":"https://api.github.com/repos/gentoo/portage/subscription","commits_url":"https://api.github.com/repos/gentoo/portage/commits{/sha}","git_commits_url":"https://api.github.com/repos/gentoo/portage/git/commits{/sha}","comments_url":"https://api.github.com/repos/gentoo/portage/comments{/number}","issue_comment_url":"https://api.github.com/repos/gentoo/portage/issues/comments{/number}","contents_url":"https://api.github.com/repos/gentoo/portage/contents/{+path}","compare_url":"https://api.github.com/repos/gentoo/portage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gentoo/portage/merges","archive_url":"https://api.github.com/repos/gentoo/portage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gentoo/portage/downloads","issues_url":"https://api.github.com/repos/gentoo/portage/issues{/number}","pulls_url":"https://api.github.com/repos/gentoo/portage/pulls{/number}","milestones_url":"https://api.github.com/repos/gentoo/portage/milestones{/number}","notifications_url":"https://api.github.com/repos/gentoo/portage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gentoo/portage/labels{/name}","releases_url":"https://api.github.com/repos/gentoo/portage/releases{/id}","deployments_url":"https://api.github.com/repos/gentoo/portage/deployments","created_at":"2014-01-12T08:30:47Z","updated_at":"2016-04-25T10:19:05Z","pushed_at":"2016-05-18T16:49:26Z","git_url":"git://github.com/gentoo/portage.git","ssh_url":"git@github.com:gentoo/portage.git","clone_url":"https://github.com/gentoo/portage.git","svn_url":"https://github.com/gentoo/portage","homepage":"","size":37849,"stargazers_count":105,"watchers_count":105,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":4,"forks":42,"open_issues":4,"watchers":105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gentoo/portage/pulls/27"},"html":{"href":"https://github.com/gentoo/portage/pull/27"},"issue":{"href":"https://api.github.com/repos/gentoo/portage/issues/27"},"comments":{"href":"https://api.github.com/repos/gentoo/portage/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/gentoo/portage/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/gentoo/portage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gentoo/portage/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/gentoo/portage/statuses/7e83e095b2af4f3e2d2b9469189105f001501a6b"}}}}