{"action":"created","issue":{"url":"https://api.github.com/repos/procore/ruby-style-guide/issues/4","repository_url":"https://api.github.com/repos/procore/ruby-style-guide","labels_url":"https://api.github.com/repos/procore/ruby-style-guide/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/procore/ruby-style-guide/issues/4/comments","events_url":"https://api.github.com/repos/procore/ruby-style-guide/issues/4/events","html_url":"https://github.com/procore/ruby-style-guide/pull/4","id":151735005,"number":4,"title":"Communicate intention with block styles","user":{"login":"adkron","id":4253,"avatar_url":"https://avatars.githubusercontent.com/u/4253?v=3","gravatar_id":"","url":"https://api.github.com/users/adkron","html_url":"https://github.com/adkron","followers_url":"https://api.github.com/users/adkron/followers","following_url":"https://api.github.com/users/adkron/following{/other_user}","gists_url":"https://api.github.com/users/adkron/gists{/gist_id}","starred_url":"https://api.github.com/users/adkron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adkron/subscriptions","organizations_url":"https://api.github.com/users/adkron/orgs","repos_url":"https://api.github.com/users/adkron/repos","events_url":"https://api.github.com/users/adkron/events{/privacy}","received_events_url":"https://api.github.com/users/adkron/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-04-28T20:25:15Z","updated_at":"2016-05-12T21:35:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/procore/ruby-style-guide/pulls/4","html_url":"https://github.com/procore/ruby-style-guide/pull/4","diff_url":"https://github.com/procore/ruby-style-guide/pull/4.diff","patch_url":"https://github.com/procore/ruby-style-guide/pull/4.patch"},"body":"Styles should be based on communication and not just esthetics. The multiline vs singleline style introduces incidental changes when you need to add or remove a line. It also has some exceptions to the rule in the other style with chaining. In this style there are no exceptions to the rule.\r\nI can clearly see when a block in multi vs single line. It isn't clear what is intended in the block use without digging into the inside of the block. Many times at a top level I may not care what is actually happening inside the block as much as if the return is used or dropped. This is very effective when communicating when a method ends in a block. If the block has `{}` then we know, when refactoring or adding functionality, that that is expected to have the block value returned. If it is using `do...end` this is not an issue.\r\n\r\nAmos King @adkron <amos@binarynoggin.com>"},"comment":{"url":"https://api.github.com/repos/procore/ruby-style-guide/issues/comments/218893080","html_url":"https://github.com/procore/ruby-style-guide/pull/4#issuecomment-218893080","issue_url":"https://api.github.com/repos/procore/ruby-style-guide/issues/4","id":218893080,"user":{"login":"melch","id":1075406,"avatar_url":"https://avatars.githubusercontent.com/u/1075406?v=3","gravatar_id":"","url":"https://api.github.com/users/melch","html_url":"https://github.com/melch","followers_url":"https://api.github.com/users/melch/followers","following_url":"https://api.github.com/users/melch/following{/other_user}","gists_url":"https://api.github.com/users/melch/gists{/gist_id}","starred_url":"https://api.github.com/users/melch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melch/subscriptions","organizations_url":"https://api.github.com/users/melch/orgs","repos_url":"https://api.github.com/users/melch/repos","events_url":"https://api.github.com/users/melch/events{/privacy}","received_events_url":"https://api.github.com/users/melch/received_events","type":"User","site_admin":false},"created_at":"2016-05-12T21:35:29Z","updated_at":"2016-05-12T21:35:29Z","body":"What are the next steps to move this idea along? Vote? L&L then vote? Branch styleguide for a particular team or area of code o.O?"}}