{"action":"created","issue":{"url":"https://api.github.com/repos/josegallegos07/aceR/issues/1","repository_url":"https://api.github.com/repos/josegallegos07/aceR","labels_url":"https://api.github.com/repos/josegallegos07/aceR/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/josegallegos07/aceR/issues/1/comments","events_url":"https://api.github.com/repos/josegallegos07/aceR/issues/1/events","html_url":"https://github.com/josegallegos07/aceR/pull/1","id":166928350,"number":1,"title":"Remove scripts","user":{"login":"duanmua","id":2281610,"avatar_url":"https://avatars.githubusercontent.com/u/2281610?v=3","gravatar_id":"","url":"https://api.github.com/users/duanmua","html_url":"https://github.com/duanmua","followers_url":"https://api.github.com/users/duanmua/followers","following_url":"https://api.github.com/users/duanmua/following{/other_user}","gists_url":"https://api.github.com/users/duanmua/gists{/gist_id}","starred_url":"https://api.github.com/users/duanmua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duanmua/subscriptions","organizations_url":"https://api.github.com/users/duanmua/orgs","repos_url":"https://api.github.com/users/duanmua/repos","events_url":"https://api.github.com/users/duanmua/events{/privacy}","received_events_url":"https://api.github.com/users/duanmua/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-21T22:02:50Z","updated_at":"2016-07-22T00:59:06Z","closed_at":"2016-07-22T00:48:06Z","pull_request":{"url":"https://api.github.com/repos/josegallegos07/aceR/pulls/1","html_url":"https://github.com/josegallegos07/aceR/pull/1","diff_url":"https://github.com/josegallegos07/aceR/pull/1.diff","patch_url":"https://github.com/josegallegos07/aceR/pull/1.patch"},"body":"\tdeleted:    R/plots-box.R\r\n\tdeleted:    R/plots-generate.R\r\n\tdeleted:    R/zzz-seacrest-standardize.R\r\n\tdeleted:    R/zzz-woodcock-transform.R\r\n\tdeleted:    scripts/proc_all.R\r\n\tdeleted:    scripts/proc_all_demographs.R\r\n\tdeleted:    scripts/proc_study_all_firstblock.R\r\n\tdeleted:    scripts/proc_study_brighten.R\r\n\tdeleted:    scripts/seacrest/first_block.R\r\n\tdeleted:    scripts/seacrest/make_plots.Rmd\r\n\tdeleted:    scripts/seacrest/make_plots_edits.Rmd\r\n\r\nThe new repo lives here: https://github.com/gazzlab/AceScripts\r\n\r\nWhat do you think of leaving plotting to be the responsibility of the end users of the aceR library @josegallegos07 ? From our experience so far, we've had to tweak it to fit whatever particular analysis we're doing (often)\r\n\r\nEdit: Or alternatively, should we keep make_box_plot and any adjustments we want to make script-side, add it on to what's returned?"},"comment":{"url":"https://api.github.com/repos/josegallegos07/aceR/issues/comments/234427520","html_url":"https://github.com/josegallegos07/aceR/pull/1#issuecomment-234427520","issue_url":"https://api.github.com/repos/josegallegos07/aceR/issues/1","id":234427520,"user":{"login":"josegallegos07","id":1521538,"avatar_url":"https://avatars.githubusercontent.com/u/1521538?v=3","gravatar_id":"","url":"https://api.github.com/users/josegallegos07","html_url":"https://github.com/josegallegos07","followers_url":"https://api.github.com/users/josegallegos07/followers","following_url":"https://api.github.com/users/josegallegos07/following{/other_user}","gists_url":"https://api.github.com/users/josegallegos07/gists{/gist_id}","starred_url":"https://api.github.com/users/josegallegos07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josegallegos07/subscriptions","organizations_url":"https://api.github.com/users/josegallegos07/orgs","repos_url":"https://api.github.com/users/josegallegos07/repos","events_url":"https://api.github.com/users/josegallegos07/events{/privacy}","received_events_url":"https://api.github.com/users/josegallegos07/received_events","type":"User","site_admin":false},"created_at":"2016-07-22T00:59:06Z","updated_at":"2016-07-22T00:59:06Z","body":"I think its a good a idea to keep the plotting on the script-side. `make_box_plot` and `make_box_plot_bulk` were really just (limited) wrapper functions. "}}
{"actor":{"display_login":"josegallegos07"}}