{"action":"created","comment":{"url":"https://api.github.com/repos/pytest-dev/pytest/pulls/comments/56762798","id":56762798,"diff_hunk":"@@ -494,9 +494,12 @@ def importorskip(modname, minversion=None):\n     \"\"\"\n     __tracebackhide__ = True\n     compile(modname, '', 'eval') # to catch syntaxerrors\n+    should_skip = False\n     try:\n         __import__(modname)\n     except ImportError:\n+        should_skip = True\n+    if should_skip:","path":"_pytest/runner.py","position":9,"original_position":9,"commit_id":"52bc2f8616002a5afb7a58e9599b9f70890425cf","original_commit_id":"52bc2f8616002a5afb7a58e9599b9f70890425cf","user":{"login":"roolebo","id":189619,"avatar_url":"https://avatars.githubusercontent.com/u/189619?v=3","gravatar_id":"","url":"https://api.github.com/users/roolebo","html_url":"https://github.com/roolebo","followers_url":"https://api.github.com/users/roolebo/followers","following_url":"https://api.github.com/users/roolebo/following{/other_user}","gists_url":"https://api.github.com/users/roolebo/gists{/gist_id}","starred_url":"https://api.github.com/users/roolebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roolebo/subscriptions","organizations_url":"https://api.github.com/users/roolebo/orgs","repos_url":"https://api.github.com/users/roolebo/repos","events_url":"https://api.github.com/users/roolebo/events{/privacy}","received_events_url":"https://api.github.com/users/roolebo/received_events","type":"User","site_admin":false},"body":"A chained exception with __context__ set was raised there. Prior to the changes it was ignored, but when I added processing of exception chain it caused a test failure. IIRC the test failed because the trace back of original exception (ImportError) was filtered and no traceback entries were in the entry list.","created_at":"2016-03-20T11:33:32Z","updated_at":"2016-03-20T11:33:32Z","html_url":"https://github.com/pytest-dev/pytest/pull/1467#discussion_r56762798","pull_request_url":"https://api.github.com/repos/pytest-dev/pytest/pulls/1467","_links":{"self":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/comments/56762798"},"html":{"href":"https://github.com/pytest-dev/pytest/pull/1467#discussion_r56762798"},"pull_request":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/1467"}}},"pull_request":{"url":"https://api.github.com/repos/pytest-dev/pytest/pulls/1467","id":63480551,"html_url":"https://github.com/pytest-dev/pytest/pull/1467","diff_url":"https://github.com/pytest-dev/pytest/pull/1467.diff","patch_url":"https://github.com/pytest-dev/pytest/pull/1467.patch","issue_url":"https://api.github.com/repos/pytest-dev/pytest/issues/1467","number":1467,"state":"open","locked":false,"title":"Close #138","user":{"login":"roolebo","id":189619,"avatar_url":"https://avatars.githubusercontent.com/u/189619?v=3","gravatar_id":"","url":"https://api.github.com/users/roolebo","html_url":"https://github.com/roolebo","followers_url":"https://api.github.com/users/roolebo/followers","following_url":"https://api.github.com/users/roolebo/following{/other_user}","gists_url":"https://api.github.com/users/roolebo/gists{/gist_id}","starred_url":"https://api.github.com/users/roolebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roolebo/subscriptions","organizations_url":"https://api.github.com/users/roolebo/orgs","repos_url":"https://api.github.com/users/roolebo/repos","events_url":"https://api.github.com/users/roolebo/events{/privacy}","received_events_url":"https://api.github.com/users/roolebo/received_events","type":"User","site_admin":false},"body":"The change fixes #138. Exception chain is printed according to [PEP-3134](https://www.python.org/dev/peps/pep-3134/).  \r\nThe tracebacks of each exception in the chain are the same as tracebacks of non-chained exceptions in py.test. The tracebacks are delimited by `The above exception was the direct cause of the following exception:` or `During handling of the above exception, another exception occurred:` messages, depending on `__cause__` or `__context__` respectively.  If an exception has both `__cause__` and `__context__`, `__cause__` takes priority. The messages are yellow-colored as it looks better than cyan delimiters:\r\n![yellow-exc-sep](https://cloud.githubusercontent.com/assets/189619/13901585/45b2bd6e-ee42-11e5-9c0f-78b312a8c49a.png)\r\n![cyan-exc-sep](https://cloud.githubusercontent.com/assets/189619/13901586/47ef63d4-ee42-11e5-9756-6df39ff95012.png)\r\n\r\n","created_at":"2016-03-19T22:22:59Z","updated_at":"2016-03-20T11:33:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b29f886f66aa38291007795be9df55f429c62352","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pytest-dev/pytest/pulls/1467/commits","review_comments_url":"https://api.github.com/repos/pytest-dev/pytest/pulls/1467/comments","review_comment_url":"https://api.github.com/repos/pytest-dev/pytest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytest-dev/pytest/issues/1467/comments","statuses_url":"https://api.github.com/repos/pytest-dev/pytest/statuses/52bc2f8616002a5afb7a58e9599b9f70890425cf","head":{"label":"roolebo:fix-issue-138","ref":"fix-issue-138","sha":"52bc2f8616002a5afb7a58e9599b9f70890425cf","user":{"login":"roolebo","id":189619,"avatar_url":"https://avatars.githubusercontent.com/u/189619?v=3","gravatar_id":"","url":"https://api.github.com/users/roolebo","html_url":"https://github.com/roolebo","followers_url":"https://api.github.com/users/roolebo/followers","following_url":"https://api.github.com/users/roolebo/following{/other_user}","gists_url":"https://api.github.com/users/roolebo/gists{/gist_id}","starred_url":"https://api.github.com/users/roolebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roolebo/subscriptions","organizations_url":"https://api.github.com/users/roolebo/orgs","repos_url":"https://api.github.com/users/roolebo/repos","events_url":"https://api.github.com/users/roolebo/events{/privacy}","received_events_url":"https://api.github.com/users/roolebo/received_events","type":"User","site_admin":false},"repo":{"id":53203266,"name":"pytest","full_name":"roolebo/pytest","owner":{"login":"roolebo","id":189619,"avatar_url":"https://avatars.githubusercontent.com/u/189619?v=3","gravatar_id":"","url":"https://api.github.com/users/roolebo","html_url":"https://github.com/roolebo","followers_url":"https://api.github.com/users/roolebo/followers","following_url":"https://api.github.com/users/roolebo/following{/other_user}","gists_url":"https://api.github.com/users/roolebo/gists{/gist_id}","starred_url":"https://api.github.com/users/roolebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roolebo/subscriptions","organizations_url":"https://api.github.com/users/roolebo/orgs","repos_url":"https://api.github.com/users/roolebo/repos","events_url":"https://api.github.com/users/roolebo/events{/privacy}","received_events_url":"https://api.github.com/users/roolebo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roolebo/pytest","description":"The pytest framework makes it easy to write small tests, yet scales to support complex functional testing","fork":true,"url":"https://api.github.com/repos/roolebo/pytest","forks_url":"https://api.github.com/repos/roolebo/pytest/forks","keys_url":"https://api.github.com/repos/roolebo/pytest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roolebo/pytest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roolebo/pytest/teams","hooks_url":"https://api.github.com/repos/roolebo/pytest/hooks","issue_events_url":"https://api.github.com/repos/roolebo/pytest/issues/events{/number}","events_url":"https://api.github.com/repos/roolebo/pytest/events","assignees_url":"https://api.github.com/repos/roolebo/pytest/assignees{/user}","branches_url":"https://api.github.com/repos/roolebo/pytest/branches{/branch}","tags_url":"https://api.github.com/repos/roolebo/pytest/tags","blobs_url":"https://api.github.com/repos/roolebo/pytest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roolebo/pytest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roolebo/pytest/git/refs{/sha}","trees_url":"https://api.github.com/repos/roolebo/pytest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roolebo/pytest/statuses/{sha}","languages_url":"https://api.github.com/repos/roolebo/pytest/languages","stargazers_url":"https://api.github.com/repos/roolebo/pytest/stargazers","contributors_url":"https://api.github.com/repos/roolebo/pytest/contributors","subscribers_url":"https://api.github.com/repos/roolebo/pytest/subscribers","subscription_url":"https://api.github.com/repos/roolebo/pytest/subscription","commits_url":"https://api.github.com/repos/roolebo/pytest/commits{/sha}","git_commits_url":"https://api.github.com/repos/roolebo/pytest/git/commits{/sha}","comments_url":"https://api.github.com/repos/roolebo/pytest/comments{/number}","issue_comment_url":"https://api.github.com/repos/roolebo/pytest/issues/comments{/number}","contents_url":"https://api.github.com/repos/roolebo/pytest/contents/{+path}","compare_url":"https://api.github.com/repos/roolebo/pytest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roolebo/pytest/merges","archive_url":"https://api.github.com/repos/roolebo/pytest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roolebo/pytest/downloads","issues_url":"https://api.github.com/repos/roolebo/pytest/issues{/number}","pulls_url":"https://api.github.com/repos/roolebo/pytest/pulls{/number}","milestones_url":"https://api.github.com/repos/roolebo/pytest/milestones{/number}","notifications_url":"https://api.github.com/repos/roolebo/pytest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roolebo/pytest/labels{/name}","releases_url":"https://api.github.com/repos/roolebo/pytest/releases{/id}","deployments_url":"https://api.github.com/repos/roolebo/pytest/deployments","created_at":"2016-03-05T13:45:08Z","updated_at":"2016-03-05T13:45:09Z","pushed_at":"2016-03-19T22:07:20Z","git_url":"git://github.com/roolebo/pytest.git","ssh_url":"git@github.com:roolebo/pytest.git","clone_url":"https://github.com/roolebo/pytest.git","svn_url":"https://github.com/roolebo/pytest","homepage":"http://pytest.org/","size":7430,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytest-dev:master","ref":"master","sha":"a70e92777f9e1a5c20e75903ba165c240f1e54ff","user":{"login":"pytest-dev","id":8897583,"avatar_url":"https://avatars.githubusercontent.com/u/8897583?v=3","gravatar_id":"","url":"https://api.github.com/users/pytest-dev","html_url":"https://github.com/pytest-dev","followers_url":"https://api.github.com/users/pytest-dev/followers","following_url":"https://api.github.com/users/pytest-dev/following{/other_user}","gists_url":"https://api.github.com/users/pytest-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pytest-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytest-dev/subscriptions","organizations_url":"https://api.github.com/users/pytest-dev/orgs","repos_url":"https://api.github.com/users/pytest-dev/repos","events_url":"https://api.github.com/users/pytest-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pytest-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":37489525,"name":"pytest","full_name":"pytest-dev/pytest","owner":{"login":"pytest-dev","id":8897583,"avatar_url":"https://avatars.githubusercontent.com/u/8897583?v=3","gravatar_id":"","url":"https://api.github.com/users/pytest-dev","html_url":"https://github.com/pytest-dev","followers_url":"https://api.github.com/users/pytest-dev/followers","following_url":"https://api.github.com/users/pytest-dev/following{/other_user}","gists_url":"https://api.github.com/users/pytest-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pytest-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytest-dev/subscriptions","organizations_url":"https://api.github.com/users/pytest-dev/orgs","repos_url":"https://api.github.com/users/pytest-dev/repos","events_url":"https://api.github.com/users/pytest-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pytest-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytest-dev/pytest","description":"The pytest framework makes it easy to write small tests, yet scales to support complex functional testing","fork":false,"url":"https://api.github.com/repos/pytest-dev/pytest","forks_url":"https://api.github.com/repos/pytest-dev/pytest/forks","keys_url":"https://api.github.com/repos/pytest-dev/pytest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytest-dev/pytest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytest-dev/pytest/teams","hooks_url":"https://api.github.com/repos/pytest-dev/pytest/hooks","issue_events_url":"https://api.github.com/repos/pytest-dev/pytest/issues/events{/number}","events_url":"https://api.github.com/repos/pytest-dev/pytest/events","assignees_url":"https://api.github.com/repos/pytest-dev/pytest/assignees{/user}","branches_url":"https://api.github.com/repos/pytest-dev/pytest/branches{/branch}","tags_url":"https://api.github.com/repos/pytest-dev/pytest/tags","blobs_url":"https://api.github.com/repos/pytest-dev/pytest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytest-dev/pytest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytest-dev/pytest/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytest-dev/pytest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytest-dev/pytest/statuses/{sha}","languages_url":"https://api.github.com/repos/pytest-dev/pytest/languages","stargazers_url":"https://api.github.com/repos/pytest-dev/pytest/stargazers","contributors_url":"https://api.github.com/repos/pytest-dev/pytest/contributors","subscribers_url":"https://api.github.com/repos/pytest-dev/pytest/subscribers","subscription_url":"https://api.github.com/repos/pytest-dev/pytest/subscription","commits_url":"https://api.github.com/repos/pytest-dev/pytest/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytest-dev/pytest/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytest-dev/pytest/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytest-dev/pytest/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytest-dev/pytest/contents/{+path}","compare_url":"https://api.github.com/repos/pytest-dev/pytest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytest-dev/pytest/merges","archive_url":"https://api.github.com/repos/pytest-dev/pytest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytest-dev/pytest/downloads","issues_url":"https://api.github.com/repos/pytest-dev/pytest/issues{/number}","pulls_url":"https://api.github.com/repos/pytest-dev/pytest/pulls{/number}","milestones_url":"https://api.github.com/repos/pytest-dev/pytest/milestones{/number}","notifications_url":"https://api.github.com/repos/pytest-dev/pytest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytest-dev/pytest/labels{/name}","releases_url":"https://api.github.com/repos/pytest-dev/pytest/releases{/id}","deployments_url":"https://api.github.com/repos/pytest-dev/pytest/deployments","created_at":"2015-06-15T20:28:27Z","updated_at":"2016-03-20T06:20:04Z","pushed_at":"2016-03-19T22:22:59Z","git_url":"git://github.com/pytest-dev/pytest.git","ssh_url":"git@github.com:pytest-dev/pytest.git","clone_url":"https://github.com/pytest-dev/pytest.git","svn_url":"https://github.com/pytest-dev/pytest","homepage":"http://pytest.org/","size":9347,"stargazers_count":593,"watchers_count":593,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":155,"mirror_url":null,"open_issues_count":278,"forks":155,"open_issues":278,"watchers":593,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/1467"},"html":{"href":"https://github.com/pytest-dev/pytest/pull/1467"},"issue":{"href":"https://api.github.com/repos/pytest-dev/pytest/issues/1467"},"comments":{"href":"https://api.github.com/repos/pytest-dev/pytest/issues/1467/comments"},"review_comments":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/1467/comments"},"review_comment":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/1467/commits"},"statuses":{"href":"https://api.github.com/repos/pytest-dev/pytest/statuses/52bc2f8616002a5afb7a58e9599b9f70890425cf"}}}}