{"action":"created","issue":{"url":"https://api.github.com/repos/rOpenGov/rwfs/issues/5","repository_url":"https://api.github.com/repos/rOpenGov/rwfs","labels_url":"https://api.github.com/repos/rOpenGov/rwfs/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/rOpenGov/rwfs/issues/5/comments","events_url":"https://api.github.com/repos/rOpenGov/rwfs/issues/5/events","html_url":"https://github.com/rOpenGov/rwfs/issues/5","id":182271006,"number":5,"title":"Remove need for ogr2ogr translation","user":{"login":"jlehtoma","id":525495,"avatar_url":"https://avatars.githubusercontent.com/u/525495?v=3","gravatar_id":"","url":"https://api.github.com/users/jlehtoma","html_url":"https://github.com/jlehtoma","followers_url":"https://api.github.com/users/jlehtoma/followers","following_url":"https://api.github.com/users/jlehtoma/following{/other_user}","gists_url":"https://api.github.com/users/jlehtoma/gists{/gist_id}","starred_url":"https://api.github.com/users/jlehtoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlehtoma/subscriptions","organizations_url":"https://api.github.com/users/jlehtoma/orgs","repos_url":"https://api.github.com/users/jlehtoma/repos","events_url":"https://api.github.com/users/jlehtoma/events{/privacy}","received_events_url":"https://api.github.com/users/jlehtoma/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"jlehtoma","id":525495,"avatar_url":"https://avatars.githubusercontent.com/u/525495?v=3","gravatar_id":"","url":"https://api.github.com/users/jlehtoma","html_url":"https://github.com/jlehtoma","followers_url":"https://api.github.com/users/jlehtoma/followers","following_url":"https://api.github.com/users/jlehtoma/following{/other_user}","gists_url":"https://api.github.com/users/jlehtoma/gists{/gist_id}","starred_url":"https://api.github.com/users/jlehtoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlehtoma/subscriptions","organizations_url":"https://api.github.com/users/jlehtoma/orgs","repos_url":"https://api.github.com/users/jlehtoma/repos","events_url":"https://api.github.com/users/jlehtoma/events{/privacy}","received_events_url":"https://api.github.com/users/jlehtoma/received_events","type":"User","site_admin":false},"assignees":[{"login":"jlehtoma","id":525495,"avatar_url":"https://avatars.githubusercontent.com/u/525495?v=3","gravatar_id":"","url":"https://api.github.com/users/jlehtoma","html_url":"https://github.com/jlehtoma","followers_url":"https://api.github.com/users/jlehtoma/followers","following_url":"https://api.github.com/users/jlehtoma/following{/other_user}","gists_url":"https://api.github.com/users/jlehtoma/gists{/gist_id}","starred_url":"https://api.github.com/users/jlehtoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlehtoma/subscriptions","organizations_url":"https://api.github.com/users/jlehtoma/orgs","repos_url":"https://api.github.com/users/jlehtoma/repos","events_url":"https://api.github.com/users/jlehtoma/events{/privacy}","received_events_url":"https://api.github.com/users/jlehtoma/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/rOpenGov/rwfs/milestones/1","html_url":"https://github.com/rOpenGov/rwfs/milestones/0.2.0","labels_url":"https://api.github.com/repos/rOpenGov/rwfs/milestones/1/labels","id":2057627,"number":1,"title":"0.2.0","description":null,"creator":{"login":"jlehtoma","id":525495,"avatar_url":"https://avatars.githubusercontent.com/u/525495?v=3","gravatar_id":"","url":"https://api.github.com/users/jlehtoma","html_url":"https://github.com/jlehtoma","followers_url":"https://api.github.com/users/jlehtoma/followers","following_url":"https://api.github.com/users/jlehtoma/following{/other_user}","gists_url":"https://api.github.com/users/jlehtoma/gists{/gist_id}","starred_url":"https://api.github.com/users/jlehtoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlehtoma/subscriptions","organizations_url":"https://api.github.com/users/jlehtoma/orgs","repos_url":"https://api.github.com/users/jlehtoma/repos","events_url":"https://api.github.com/users/jlehtoma/events{/privacy}","received_events_url":"https://api.github.com/users/jlehtoma/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":3,"state":"open","created_at":"2016-10-09T18:28:56Z","updated_at":"2016-10-26T18:47:35Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2016-10-11T13:57:39Z","updated_at":"2016-10-27T11:04:52Z","closed_at":"2016-10-26T18:07:19Z","body":"Currently, there are two ways getting the data from the data source:\r\n\r\n1. Create a class inheriting from `rwfs::WFSStreamingRequest`, implement method `getDataSource()` and read data directly from data source using `rgdal::readOGR()` (actually twice: first for reading the layers, then the actual data). No caching is possible.\r\n1. Create a class inheriting from `rwfs::WFSCachingRequest` or instantiate it directly. Read (download) data only once from the data source and save to a temp directory. Use `ogr2ogr -explodecollections` to locally translate the (GML) data. Read the translated data in using `rgdal::readOGR()`. Within the lifetime of an instance (object), the responses are cached.\r\n\r\n### Original problem\r\n\r\nThe original reason for having the extra `ogr2ogr`-step is the following:\r\n\r\n> Due to limited support for WFS 2.x in the rgdal package, which the rwfs package depends on, data in > WFS 2.x is accessible only via downloading the data first and thus no streaming can be used (at least > in some services).\r\n\r\nThis has (hopefully) changed with more recent (>= 2.0.0) versions of `GDAL`, meaning that the  `ogr2ogr`-step could in theory be removed. Many users, particularly on Windows, have had trouble in getting `ogr2ogr` to work. \r\n\r\n### Making ogr2ogr optional\r\n\r\nIf the `ogr2ogr` step is not required (now in [`rwfs::WFSCachingClient$getLayer()`](https://github.com/rOpenGov/rwfs/blob/master/R/WFSClient.R#L241)), then effectively modifying `rwfs::WFSCachingClient` should be enough. Instead of completely removing the step, the functionality should be retained for cases where it is still needed. For caching, it is always necessary to download the data. Downloading the data also removes the need the get the data twice as in streaming. "},"comment":{"url":"https://api.github.com/repos/rOpenGov/rwfs/issues/comments/256611894","html_url":"https://github.com/rOpenGov/rwfs/issues/5#issuecomment-256611894","issue_url":"https://api.github.com/repos/rOpenGov/rwfs/issues/5","id":256611894,"user":{"login":"ouzor","id":1228426,"avatar_url":"https://avatars.githubusercontent.com/u/1228426?v=3","gravatar_id":"","url":"https://api.github.com/users/ouzor","html_url":"https://github.com/ouzor","followers_url":"https://api.github.com/users/ouzor/followers","following_url":"https://api.github.com/users/ouzor/following{/other_user}","gists_url":"https://api.github.com/users/ouzor/gists{/gist_id}","starred_url":"https://api.github.com/users/ouzor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ouzor/subscriptions","organizations_url":"https://api.github.com/users/ouzor/orgs","repos_url":"https://api.github.com/users/ouzor/repos","events_url":"https://api.github.com/users/ouzor/events{/privacy}","received_events_url":"https://api.github.com/users/ouzor/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T11:04:51Z","updated_at":"2016-10-27T11:04:51Z","body":"Sorry I missed the request. Discussion continuing here: https://github.com/rOpenGov/gisfin/issues/33"}}
{"actor":{"display_login":"ouzor"}}