{"action":"created","comment":{"url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments/59067531","id":59067531,"diff_hunk":"@@ -100,9 +100,9 @@ func PutNode(r *Root, path string, nd *dag.Node) error {\n \n // Mkdir creates a directory at 'path' under the directory 'd', creating\n // intermediary directories as needed if 'mkparents' is set to true\n-func Mkdir(r *Root, pth string, mkparents bool, flush bool) error {\n+func Mkdir(r *Root, pth string, mkparents bool, flush bool) (*Directory, error) {\n \tif pth == \"\" {\n-\t\treturn nil\n+\t\treturn nil, nil","path":"mfs/ops.go","position":8,"original_position":8,"commit_id":"312aef9d99bc2f0cc57ea806b93a90e9dc94fd33","original_commit_id":"312aef9d99bc2f0cc57ea806b93a90e9dc94fd33","user":{"login":"whyrusleeping","id":1243164,"avatar_url":"https://avatars.githubusercontent.com/u/1243164?v=3","gravatar_id":"","url":"https://api.github.com/users/whyrusleeping","html_url":"https://github.com/whyrusleeping","followers_url":"https://api.github.com/users/whyrusleeping/followers","following_url":"https://api.github.com/users/whyrusleeping/following{/other_user}","gists_url":"https://api.github.com/users/whyrusleeping/gists{/gist_id}","starred_url":"https://api.github.com/users/whyrusleeping/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whyrusleeping/subscriptions","organizations_url":"https://api.github.com/users/whyrusleeping/orgs","repos_url":"https://api.github.com/users/whyrusleeping/repos","events_url":"https://api.github.com/users/whyrusleeping/events{/privacy}","received_events_url":"https://api.github.com/users/whyrusleeping/received_events","type":"User","site_admin":false},"body":"returning nil and nil feels weird to me... code might assume that no error means you get back a valid directory.","created_at":"2016-04-08T18:17:02Z","updated_at":"2016-04-08T18:17:02Z","html_url":"https://github.com/ipfs/go-ipfs/pull/2531#discussion_r59067531","pull_request_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/2531","_links":{"self":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments/59067531"},"html":{"href":"https://github.com/ipfs/go-ipfs/pull/2531#discussion_r59067531"},"pull_request":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/2531"}}},"pull_request":{"url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/2531","id":65523063,"html_url":"https://github.com/ipfs/go-ipfs/pull/2531","diff_url":"https://github.com/ipfs/go-ipfs/pull/2531.diff","patch_url":"https://github.com/ipfs/go-ipfs/pull/2531.patch","issue_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/2531","number":2531,"state":"open","locked":false,"title":"Outputs added directories as they are traversed.","user":{"login":"noffle","id":489362,"avatar_url":"https://avatars.githubusercontent.com/u/489362?v=3","gravatar_id":"","url":"https://api.github.com/users/noffle","html_url":"https://github.com/noffle","followers_url":"https://api.github.com/users/noffle/followers","following_url":"https://api.github.com/users/noffle/following{/other_user}","gists_url":"https://api.github.com/users/noffle/gists{/gist_id}","starred_url":"https://api.github.com/users/noffle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noffle/subscriptions","organizations_url":"https://api.github.com/users/noffle/orgs","repos_url":"https://api.github.com/users/noffle/repos","events_url":"https://api.github.com/users/noffle/events{/privacy}","received_events_url":"https://api.github.com/users/noffle/received_events","type":"User","site_admin":false},"body":"This also fixes a bug where adding with -n would prevent directories from\r\nbeing outputted. Addresses https://github.com/ipfs/go-ipfs/issues/2530.\r\n\r\nBonus: directories no longer appear at the end of the list for `ipfs add` --\r\nthey're in order! :dancers:  ","created_at":"2016-04-06T19:34:42Z","updated_at":"2016-04-08T18:17:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2d0a8f02364f56cf0c46fad3d91347694cc61d2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/2531/commits","review_comments_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/2531/comments","review_comment_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/2531/comments","statuses_url":"https://api.github.com/repos/ipfs/go-ipfs/statuses/312aef9d99bc2f0cc57ea806b93a90e9dc94fd33","head":{"label":"noffle:output-dirs-on-add","ref":"output-dirs-on-add","sha":"312aef9d99bc2f0cc57ea806b93a90e9dc94fd33","user":{"login":"noffle","id":489362,"avatar_url":"https://avatars.githubusercontent.com/u/489362?v=3","gravatar_id":"","url":"https://api.github.com/users/noffle","html_url":"https://github.com/noffle","followers_url":"https://api.github.com/users/noffle/followers","following_url":"https://api.github.com/users/noffle/following{/other_user}","gists_url":"https://api.github.com/users/noffle/gists{/gist_id}","starred_url":"https://api.github.com/users/noffle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noffle/subscriptions","organizations_url":"https://api.github.com/users/noffle/orgs","repos_url":"https://api.github.com/users/noffle/repos","events_url":"https://api.github.com/users/noffle/events{/privacy}","received_events_url":"https://api.github.com/users/noffle/received_events","type":"User","site_admin":false},"repo":{"id":49666404,"name":"go-ipfs","full_name":"noffle/go-ipfs","owner":{"login":"noffle","id":489362,"avatar_url":"https://avatars.githubusercontent.com/u/489362?v=3","gravatar_id":"","url":"https://api.github.com/users/noffle","html_url":"https://github.com/noffle","followers_url":"https://api.github.com/users/noffle/followers","following_url":"https://api.github.com/users/noffle/following{/other_user}","gists_url":"https://api.github.com/users/noffle/gists{/gist_id}","starred_url":"https://api.github.com/users/noffle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noffle/subscriptions","organizations_url":"https://api.github.com/users/noffle/orgs","repos_url":"https://api.github.com/users/noffle/repos","events_url":"https://api.github.com/users/noffle/events{/privacy}","received_events_url":"https://api.github.com/users/noffle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/noffle/go-ipfs","description":"ipfs implementation in go","fork":true,"url":"https://api.github.com/repos/noffle/go-ipfs","forks_url":"https://api.github.com/repos/noffle/go-ipfs/forks","keys_url":"https://api.github.com/repos/noffle/go-ipfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noffle/go-ipfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noffle/go-ipfs/teams","hooks_url":"https://api.github.com/repos/noffle/go-ipfs/hooks","issue_events_url":"https://api.github.com/repos/noffle/go-ipfs/issues/events{/number}","events_url":"https://api.github.com/repos/noffle/go-ipfs/events","assignees_url":"https://api.github.com/repos/noffle/go-ipfs/assignees{/user}","branches_url":"https://api.github.com/repos/noffle/go-ipfs/branches{/branch}","tags_url":"https://api.github.com/repos/noffle/go-ipfs/tags","blobs_url":"https://api.github.com/repos/noffle/go-ipfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noffle/go-ipfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noffle/go-ipfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/noffle/go-ipfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noffle/go-ipfs/statuses/{sha}","languages_url":"https://api.github.com/repos/noffle/go-ipfs/languages","stargazers_url":"https://api.github.com/repos/noffle/go-ipfs/stargazers","contributors_url":"https://api.github.com/repos/noffle/go-ipfs/contributors","subscribers_url":"https://api.github.com/repos/noffle/go-ipfs/subscribers","subscription_url":"https://api.github.com/repos/noffle/go-ipfs/subscription","commits_url":"https://api.github.com/repos/noffle/go-ipfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/noffle/go-ipfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/noffle/go-ipfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/noffle/go-ipfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/noffle/go-ipfs/contents/{+path}","compare_url":"https://api.github.com/repos/noffle/go-ipfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noffle/go-ipfs/merges","archive_url":"https://api.github.com/repos/noffle/go-ipfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noffle/go-ipfs/downloads","issues_url":"https://api.github.com/repos/noffle/go-ipfs/issues{/number}","pulls_url":"https://api.github.com/repos/noffle/go-ipfs/pulls{/number}","milestones_url":"https://api.github.com/repos/noffle/go-ipfs/milestones{/number}","notifications_url":"https://api.github.com/repos/noffle/go-ipfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noffle/go-ipfs/labels{/name}","releases_url":"https://api.github.com/repos/noffle/go-ipfs/releases{/id}","deployments_url":"https://api.github.com/repos/noffle/go-ipfs/deployments","created_at":"2016-01-14T18:27:02Z","updated_at":"2016-01-14T18:27:04Z","pushed_at":"2016-04-08T04:10:00Z","git_url":"git://github.com/noffle/go-ipfs.git","ssh_url":"git@github.com:noffle/go-ipfs.git","clone_url":"https://github.com/noffle/go-ipfs.git","svn_url":"https://github.com/noffle/go-ipfs","homepage":"https://github.com/ipfs/ipfs","size":22526,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ipfs:master","ref":"master","sha":"600c95eb53e576530d73afe856bf11ae219b3acb","user":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars.githubusercontent.com/u/10536621?v=3","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":21233191,"name":"go-ipfs","full_name":"ipfs/go-ipfs","owner":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars.githubusercontent.com/u/10536621?v=3","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipfs/go-ipfs","description":"IPFS implementation in go","fork":false,"url":"https://api.github.com/repos/ipfs/go-ipfs","forks_url":"https://api.github.com/repos/ipfs/go-ipfs/forks","keys_url":"https://api.github.com/repos/ipfs/go-ipfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/go-ipfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/go-ipfs/teams","hooks_url":"https://api.github.com/repos/ipfs/go-ipfs/hooks","issue_events_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/go-ipfs/events","assignees_url":"https://api.github.com/repos/ipfs/go-ipfs/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/go-ipfs/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/go-ipfs/tags","blobs_url":"https://api.github.com/repos/ipfs/go-ipfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/go-ipfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/go-ipfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/go-ipfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/go-ipfs/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/go-ipfs/languages","stargazers_url":"https://api.github.com/repos/ipfs/go-ipfs/stargazers","contributors_url":"https://api.github.com/repos/ipfs/go-ipfs/contributors","subscribers_url":"https://api.github.com/repos/ipfs/go-ipfs/subscribers","subscription_url":"https://api.github.com/repos/ipfs/go-ipfs/subscription","commits_url":"https://api.github.com/repos/ipfs/go-ipfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/go-ipfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/go-ipfs/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/go-ipfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/go-ipfs/merges","archive_url":"https://api.github.com/repos/ipfs/go-ipfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/go-ipfs/downloads","issues_url":"https://api.github.com/repos/ipfs/go-ipfs/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/go-ipfs/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/go-ipfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/go-ipfs/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/go-ipfs/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/go-ipfs/deployments","created_at":"2014-06-26T08:14:34Z","updated_at":"2016-04-07T14:01:01Z","pushed_at":"2016-04-08T16:09:32Z","git_url":"git://github.com/ipfs/go-ipfs.git","ssh_url":"git@github.com:ipfs/go-ipfs.git","clone_url":"https://github.com/ipfs/go-ipfs.git","svn_url":"https://github.com/ipfs/go-ipfs","homepage":"https://github.com/ipfs/ipfs","size":31639,"stargazers_count":1775,"watchers_count":1775,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":290,"mirror_url":null,"open_issues_count":501,"forks":290,"open_issues":501,"watchers":1775,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/2531"},"html":{"href":"https://github.com/ipfs/go-ipfs/pull/2531"},"issue":{"href":"https://api.github.com/repos/ipfs/go-ipfs/issues/2531"},"comments":{"href":"https://api.github.com/repos/ipfs/go-ipfs/issues/2531/comments"},"review_comments":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/2531/comments"},"review_comment":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/2531/commits"},"statuses":{"href":"https://api.github.com/repos/ipfs/go-ipfs/statuses/312aef9d99bc2f0cc57ea806b93a90e9dc94fd33"}}}}