{"action":"created","issue":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/5452","repository_url":"https://api.github.com/repos/MarlinFirmware/Marlin","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/5452/labels{/name}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/5452/comments","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/5452/events","html_url":"https://github.com/MarlinFirmware/Marlin/pull/5452","id":194762620,"number":5452,"title":"Save Bilinear Grid to EEPROM","user":{"login":"thinkyhead","id":698003,"avatar_url":"https://avatars.githubusercontent.com/u/698003?v=3","gravatar_id":"","url":"https://api.github.com/users/thinkyhead","html_url":"https://github.com/thinkyhead","followers_url":"https://api.github.com/users/thinkyhead/followers","following_url":"https://api.github.com/users/thinkyhead/following{/other_user}","gists_url":"https://api.github.com/users/thinkyhead/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkyhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkyhead/subscriptions","organizations_url":"https://api.github.com/users/thinkyhead/orgs","repos_url":"https://api.github.com/users/thinkyhead/repos","events_url":"https://api.github.com/users/thinkyhead/events{/privacy}","received_events_url":"https://api.github.com/users/thinkyhead/received_events","type":"User","site_admin":false},"labels":[{"id":196933231,"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/PR:%20New%20Feature","name":"PR: New Feature","color":"bfe5bf","default":false},{"id":366367082,"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/Support:%20Homing%20&%20Leveling","name":"Support: Homing & Leveling","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2016-12-10T11:43:43Z","updated_at":"2016-12-14T08:02:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/5452","html_url":"https://github.com/MarlinFirmware/Marlin/pull/5452","diff_url":"https://github.com/MarlinFirmware/Marlin/pull/5452.diff","patch_url":"https://github.com/MarlinFirmware/Marlin/pull/5452.patch"},"body":"To save the current Bilinear Grid to EEPROM use `M500`.\r\n(Only the changed parts of EEPROM are overwritten.)\r\nUse `M501` to load the last-saved grid from EEPROM. Follow with `M420 S1` to enable.\r\nUse `M502` to reset the bilinear grid to empty and disabled.\r\n\r\nCommits:\r\n- `ABL_GRID_POINTS_*` => `ABL_GRID_MAX_POINTS_*`\r\n- Fixup `reset_bed_level()` to disable leveling up front\r\n- Minor tweak to `G29` grid points\r\n- Re-enable MBL/ABL after `M48`\r\n- Save Bilinear Grid to EEPROM\r\n- Print an error in `M420` if it can't enable leveling\r\n- Better handling of `G29` dryrun, esp. with bilinear\r\n- Use `set_bed_leveling_enabled(false)` in `G29`"},"comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments/266968518","html_url":"https://github.com/MarlinFirmware/Marlin/pull/5452#issuecomment-266968518","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/5452","id":266968518,"user":{"login":"thinkyhead","id":698003,"avatar_url":"https://avatars.githubusercontent.com/u/698003?v=3","gravatar_id":"","url":"https://api.github.com/users/thinkyhead","html_url":"https://github.com/thinkyhead","followers_url":"https://api.github.com/users/thinkyhead/followers","following_url":"https://api.github.com/users/thinkyhead/following{/other_user}","gists_url":"https://api.github.com/users/thinkyhead/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkyhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkyhead/subscriptions","organizations_url":"https://api.github.com/users/thinkyhead/orgs","repos_url":"https://api.github.com/users/thinkyhead/repos","events_url":"https://api.github.com/users/thinkyhead/events{/privacy}","received_events_url":"https://api.github.com/users/thinkyhead/received_events","type":"User","site_admin":false},"created_at":"2016-12-14T08:02:54Z","updated_at":"2016-12-14T08:02:54Z","body":"In answer to @boelle's request I've added code to support saving the bed matrix for 3-point and grid leveling. I didn't mess with other code (very much) this time around. A full EEPROM re-write with `M502`, `M500` is recommended, of course.\r\n\r\n> And at the end of G29 I receive\r\n    `Recv: G29 uncorrected Z:10.17`\r\n    `Recv:  bilinear_z_offset:0.00`\r\n    `Recv:  corrected Z:0.00`\r\n```\r\nIt almost looks like your code ought to have a typo, like this:\r\n```cpp\r\ncurrent_position[Z_AXIS] = bilinear_z_offset(current_position);\r\n```\r\nIt makes no sense for 10.17 - 0.0 to come out to 0.0."}}
{"actor":{"display_login":"thinkyhead"}}