{"action":"created","issue":{"url":"https://api.github.com/repos/readium/readium-js-viewer/issues/467","labels_url":"https://api.github.com/repos/readium/readium-js-viewer/issues/467/labels{/name}","comments_url":"https://api.github.com/repos/readium/readium-js-viewer/issues/467/comments","events_url":"https://api.github.com/repos/readium/readium-js-viewer/issues/467/events","html_url":"https://github.com/readium/readium-js-viewer/issues/467","id":127760238,"number":467,"title":"Some browsers do not support <?xml version=\"1.1\"?> tag","user":{"login":"kimtuck","id":3791539,"avatar_url":"https://avatars.githubusercontent.com/u/3791539?v=3","gravatar_id":"","url":"https://api.github.com/users/kimtuck","html_url":"https://github.com/kimtuck","followers_url":"https://api.github.com/users/kimtuck/followers","following_url":"https://api.github.com/users/kimtuck/following{/other_user}","gists_url":"https://api.github.com/users/kimtuck/gists{/gist_id}","starred_url":"https://api.github.com/users/kimtuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimtuck/subscriptions","organizations_url":"https://api.github.com/users/kimtuck/orgs","repos_url":"https://api.github.com/users/kimtuck/repos","events_url":"https://api.github.com/users/kimtuck/events{/privacy}","received_events_url":"https://api.github.com/users/kimtuck/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-01-20T19:04:54Z","updated_at":"2016-02-01T15:59:52Z","closed_at":null,"body":"I have some books which contain xml tags specified like this:\r\n```\r\n<?xml version=\"1.1\"?>\r\n```\r\n\r\nAt the present, I'm getting around this by patching the code to replace \"1.1\" with \"1.0\".  I think eventually we'll deal with this at the time we acquire the books from the publishers, either by asking them to package them with strictly \"1.0\", or by replacing the version number before we process the books and put them online.\r\n\r\nSo, I'm not sure whether you want to patch readium to make this change, or leave it as an issue for content providers.  If you're leaving it to content providers, you may want to trap the error and log it to the console, so that users will better understand what is going on.  I think that, without some sort of patch, the code simply fails without any diagnostics.\r\n"},"comment":{"url":"https://api.github.com/repos/readium/readium-js-viewer/issues/comments/178042124","html_url":"https://github.com/readium/readium-js-viewer/issues/467#issuecomment-178042124","issue_url":"https://api.github.com/repos/readium/readium-js-viewer/issues/467","id":178042124,"user":{"login":"da70","id":5719179,"avatar_url":"https://avatars.githubusercontent.com/u/5719179?v=3","gravatar_id":"","url":"https://api.github.com/users/da70","html_url":"https://github.com/da70","followers_url":"https://api.github.com/users/da70/followers","following_url":"https://api.github.com/users/da70/following{/other_user}","gists_url":"https://api.github.com/users/da70/gists{/gist_id}","starred_url":"https://api.github.com/users/da70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/da70/subscriptions","organizations_url":"https://api.github.com/users/da70/orgs","repos_url":"https://api.github.com/users/da70/repos","events_url":"https://api.github.com/users/da70/events{/privacy}","received_events_url":"https://api.github.com/users/da70/received_events","type":"User","site_admin":false},"created_at":"2016-02-01T15:59:52Z","updated_at":"2016-02-01T15:59:52Z","body":"Yes I would like to see the code, just to learn more about Readium.  We don't actually need it, though, because we fixed the declarations in our EPUBs.  Maybe this is an option for you as well?  That way you won't need to deal with patches that would be overwritten or even possibly invalidated when updating Readium from upstream.\r\nIt turned out to be very easy.  First unzip, then edit, then re-package.  Here's what I wrote in our internal wiki about re-packaging:\r\n\r\n-----\r\n\r\n[Zip 3.0](http://www.info-zip.org/Zip.html) by Info-ZIP is available on Mac OS X on the command-line.\r\n\r\nFollowing instructions from [Epub Format Construction Guide - HXA7241 - 2007](http://www.hxa.name/articles/content/epub-guide_hxa7241_2007.html):\r\n\r\n```\r\n    zip -X0 EpubGuide-hxa7241.epub mimetype\r\n    zip -Xur9D EpubGuide-hxa7241.epub *\r\n```\r\n\r\nThe flags being used (see http://www.info-zip.org/mans/zip.html):\r\n\r\n-     -9: maximum compression\r\n-     -D | --no-dir-entries: do not create entries in the zip archive for directories.\r\n-     -u | --update: replace (update) an existing entry in the zip archive if it had been modified more recently.\r\n-     -r | --recurse-paths: travel the directory structure recursively.\r\n-     -X | --no-extra: do not save extra file attributes.\r\n\r\n-----\r\n\r\nWe tested the correctness of this method in various ways:\r\n\r\n-     Round-trip zipping and unzipping an exploded EPUB from our website and checking that files/directories are binary identical.\r\n-     Opening the resulting EPUB file in Adobe Digital Editions and testing page turning, font size change, TOC, bookmarking, and full-screen mode.\r\n-     Validating EPUB file using [epubcheck](https://github.com/IDPF/epubcheck).  No errors were introduced by the zipping process.\r\n\r\nSo that's an option you might want to consider.\r\nPlease do feel free to post the code though, as I would be curious to see it.\r\n\r\n"}}