{"action":"created","comment":{"url":"https://api.github.com/repos/ModeShape/modeshape/pulls/comments/74434435","id":74434435,"diff_hunk":"@@ -0,0 +1,451 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<project xmlns=\"http://maven.apache.org/POM/4.0.0\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\n+         xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd\">\n+    <modelVersion>4.0.0</modelVersion>\n+\n+    <parent>\n+        <groupId>org.modeshape</groupId>\n+        <artifactId>modeshape-parent</artifactId>\n+        <version>5.2-SNAPSHOT</version>\n+        <relativePath>../modeshape-parent</relativePath>\n+    </parent>\n+\n+    <!-- The groupId and version values are inherited from parent -->\n+    <artifactId>modeshape-persistence-tests</artifactId>\n+    <packaging>jar</packaging>\n+    <name>ModeShape Persistence Tests</name>\n+    <description>ModeShape persistence tests</description>\n+    <url>http://www.modeshape.org</url>\n+    \n+    <properties>\n+        <database.name>modeshape_db</database.name>\n+        <database.user>system</database.user>\n+        <database.password>oracle</database.password>\n+        \n+        <version.mysql.server>5.7</version.mysql.server>\n+    </properties>\n+    <!--\n+      Define the dependencies. Note that all version and scopes default to those defined in the dependencyManagement section of the\n+      parent pom.\n+    -->\n+    <dependencies>\n+        <!-- Public API (beyond JCR 2.0) -->\n+        <dependency>\n+            <groupId>org.modeshape</groupId>\n+            <artifactId>modeshape-jcr-api</artifactId>\n+        </dependency>\n+        <!-- ModeShape JCR -->\n+        <dependency>\n+            <groupId>org.modeshape</groupId>\n+            <artifactId>modeshape-jcr</artifactId>\n+        </dependency>\n+        <dependency>\n+            <groupId>org.modeshape</groupId>\n+            <artifactId>modeshape-jcr</artifactId>\n+            <type>test-jar</type>\n+            <scope>test</scope>\n+        </dependency>\n+        <!-- This should eventually get refactored into this project -->\n+        <dependency>\n+            <groupId>org.modeshape</groupId>\n+            <artifactId>modeshape-common</artifactId>\n+        </dependency>\n+        <dependency>\n+            <groupId>org.modeshape</groupId>\n+            <artifactId>modeshape-common</artifactId>\n+            <type>test-jar</type>\n+            <scope>test</scope>\n+        </dependency>\n+        <dependency>\n+            <groupId>org.modeshape</groupId>\n+            <artifactId>modeshape-schematic</artifactId>\n+        </dependency>\n+        <!--  Used in tests -->\n+        <dependency>\n+            <groupId>org.modeshape</groupId>\n+            <artifactId>modeshape-schematic</artifactId>\n+            <type>test-jar</type>\n+            <scope>test</scope>\n+        </dependency>\n+        \n+        <dependency>\n+            <groupId>mysql</groupId>\n+            <artifactId>mysql-connector-java</artifactId>\n+            <version>5.1.18</version>\n+        </dependency>\n+\n+        <dependency>\n+            <!--Must be JDBC 4 (Java 6) compliant-->\n+            <groupId>postgresql</groupId>\n+            <artifactId>postgresql</artifactId>\n+            <version>${version.postgresql.9}</version>\n+        </dependency>\n+\n+        <dependency>\n+            <groupId>com.oracle</groupId>\n+            <artifactId>ojdbc6</artifactId>\n+            <version>11.2.0.1.0</version>","path":"modeshape-persistence-tests/pom.xml","position":87,"original_position":87,"commit_id":"caad57f96cf76529d7e5fd4d49f6c6f4caf73d3b","original_commit_id":"caad57f96cf76529d7e5fd4d49f6c6f4caf73d3b","user":{"login":"rhauch","id":84732,"avatar_url":"https://avatars.githubusercontent.com/u/84732?v=3","gravatar_id":"","url":"https://api.github.com/users/rhauch","html_url":"https://github.com/rhauch","followers_url":"https://api.github.com/users/rhauch/followers","following_url":"https://api.github.com/users/rhauch/following{/other_user}","gists_url":"https://api.github.com/users/rhauch/gists{/gist_id}","starred_url":"https://api.github.com/users/rhauch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhauch/subscriptions","organizations_url":"https://api.github.com/users/rhauch/orgs","repos_url":"https://api.github.com/users/rhauch/repos","events_url":"https://api.github.com/users/rhauch/events{/privacy}","received_events_url":"https://api.github.com/users/rhauch/received_events","type":"User","site_admin":false},"body":"Again, shouldn't this be in the parent POM? Perhaps use a property name that signifies its for integration tests, but I still think it needs to be in the parent POM for consistency.","created_at":"2016-08-11T14:39:17Z","updated_at":"2016-08-11T14:39:17Z","html_url":"https://github.com/ModeShape/modeshape/pull/1580#discussion_r74434435","pull_request_url":"https://api.github.com/repos/ModeShape/modeshape/pulls/1580","_links":{"self":{"href":"https://api.github.com/repos/ModeShape/modeshape/pulls/comments/74434435"},"html":{"href":"https://github.com/ModeShape/modeshape/pull/1580#discussion_r74434435"},"pull_request":{"href":"https://api.github.com/repos/ModeShape/modeshape/pulls/1580"}}},"pull_request":{"url":"https://api.github.com/repos/ModeShape/modeshape/pulls/1580","id":76760305,"html_url":"https://github.com/ModeShape/modeshape/pull/1580","diff_url":"https://github.com/ModeShape/modeshape/pull/1580.diff","patch_url":"https://github.com/ModeShape/modeshape/pull/1580.patch","issue_url":"https://api.github.com/repos/ModeShape/modeshape/issues/1580","number":1580,"state":"open","locked":false,"title":"Mode 2613 : Modeshape persistence test","user":{"login":"okulikov","id":1327431,"avatar_url":"https://avatars.githubusercontent.com/u/1327431?v=3","gravatar_id":"","url":"https://api.github.com/users/okulikov","html_url":"https://github.com/okulikov","followers_url":"https://api.github.com/users/okulikov/followers","following_url":"https://api.github.com/users/okulikov/following{/other_user}","gists_url":"https://api.github.com/users/okulikov/gists{/gist_id}","starred_url":"https://api.github.com/users/okulikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okulikov/subscriptions","organizations_url":"https://api.github.com/users/okulikov/orgs","repos_url":"https://api.github.com/users/okulikov/repos","events_url":"https://api.github.com/users/okulikov/events{/privacy}","received_events_url":"https://api.github.com/users/okulikov/received_events","type":"User","site_admin":false},"body":"This PR for provides module skeleton:\r\n- builds docker images for MySQL, Postgres and Oracle databases;\r\n- runs \"dummy\" test multiple times against each database.\r\n\r\nIf this skeleton looks good then I will start to add concrete tests.","created_at":"2016-07-08T14:21:31Z","updated_at":"2016-08-11T14:39:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdbfa7e99ed4d7e98b0333e0608fac9225433929","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ModeShape/modeshape/pulls/1580/commits","review_comments_url":"https://api.github.com/repos/ModeShape/modeshape/pulls/1580/comments","review_comment_url":"https://api.github.com/repos/ModeShape/modeshape/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ModeShape/modeshape/issues/1580/comments","statuses_url":"https://api.github.com/repos/ModeShape/modeshape/statuses/caad57f96cf76529d7e5fd4d49f6c6f4caf73d3b","head":{"label":"okulikov:MODE-2613","ref":"MODE-2613","sha":"caad57f96cf76529d7e5fd4d49f6c6f4caf73d3b","user":{"login":"okulikov","id":1327431,"avatar_url":"https://avatars.githubusercontent.com/u/1327431?v=3","gravatar_id":"","url":"https://api.github.com/users/okulikov","html_url":"https://github.com/okulikov","followers_url":"https://api.github.com/users/okulikov/followers","following_url":"https://api.github.com/users/okulikov/following{/other_user}","gists_url":"https://api.github.com/users/okulikov/gists{/gist_id}","starred_url":"https://api.github.com/users/okulikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okulikov/subscriptions","organizations_url":"https://api.github.com/users/okulikov/orgs","repos_url":"https://api.github.com/users/okulikov/repos","events_url":"https://api.github.com/users/okulikov/events{/privacy}","received_events_url":"https://api.github.com/users/okulikov/received_events","type":"User","site_admin":false},"repo":{"id":4805993,"name":"modeshape","full_name":"okulikov/modeshape","owner":{"login":"okulikov","id":1327431,"avatar_url":"https://avatars.githubusercontent.com/u/1327431?v=3","gravatar_id":"","url":"https://api.github.com/users/okulikov","html_url":"https://github.com/okulikov","followers_url":"https://api.github.com/users/okulikov/followers","following_url":"https://api.github.com/users/okulikov/following{/other_user}","gists_url":"https://api.github.com/users/okulikov/gists{/gist_id}","starred_url":"https://api.github.com/users/okulikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okulikov/subscriptions","organizations_url":"https://api.github.com/users/okulikov/orgs","repos_url":"https://api.github.com/users/okulikov/repos","events_url":"https://api.github.com/users/okulikov/events{/privacy}","received_events_url":"https://api.github.com/users/okulikov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/okulikov/modeshape","description":"ModeShape is a lightweight, fast, pluggable, open-source, federating JCR implementation that can unify content from multiple systems, including files systems, databases, data grids, other repositories, etc.  This is the official source code repository for ModeShape.","fork":true,"url":"https://api.github.com/repos/okulikov/modeshape","forks_url":"https://api.github.com/repos/okulikov/modeshape/forks","keys_url":"https://api.github.com/repos/okulikov/modeshape/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okulikov/modeshape/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okulikov/modeshape/teams","hooks_url":"https://api.github.com/repos/okulikov/modeshape/hooks","issue_events_url":"https://api.github.com/repos/okulikov/modeshape/issues/events{/number}","events_url":"https://api.github.com/repos/okulikov/modeshape/events","assignees_url":"https://api.github.com/repos/okulikov/modeshape/assignees{/user}","branches_url":"https://api.github.com/repos/okulikov/modeshape/branches{/branch}","tags_url":"https://api.github.com/repos/okulikov/modeshape/tags","blobs_url":"https://api.github.com/repos/okulikov/modeshape/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okulikov/modeshape/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okulikov/modeshape/git/refs{/sha}","trees_url":"https://api.github.com/repos/okulikov/modeshape/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okulikov/modeshape/statuses/{sha}","languages_url":"https://api.github.com/repos/okulikov/modeshape/languages","stargazers_url":"https://api.github.com/repos/okulikov/modeshape/stargazers","contributors_url":"https://api.github.com/repos/okulikov/modeshape/contributors","subscribers_url":"https://api.github.com/repos/okulikov/modeshape/subscribers","subscription_url":"https://api.github.com/repos/okulikov/modeshape/subscription","commits_url":"https://api.github.com/repos/okulikov/modeshape/commits{/sha}","git_commits_url":"https://api.github.com/repos/okulikov/modeshape/git/commits{/sha}","comments_url":"https://api.github.com/repos/okulikov/modeshape/comments{/number}","issue_comment_url":"https://api.github.com/repos/okulikov/modeshape/issues/comments{/number}","contents_url":"https://api.github.com/repos/okulikov/modeshape/contents/{+path}","compare_url":"https://api.github.com/repos/okulikov/modeshape/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okulikov/modeshape/merges","archive_url":"https://api.github.com/repos/okulikov/modeshape/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okulikov/modeshape/downloads","issues_url":"https://api.github.com/repos/okulikov/modeshape/issues{/number}","pulls_url":"https://api.github.com/repos/okulikov/modeshape/pulls{/number}","milestones_url":"https://api.github.com/repos/okulikov/modeshape/milestones{/number}","notifications_url":"https://api.github.com/repos/okulikov/modeshape/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okulikov/modeshape/labels{/name}","releases_url":"https://api.github.com/repos/okulikov/modeshape/releases{/id}","deployments_url":"https://api.github.com/repos/okulikov/modeshape/deployments","created_at":"2012-06-27T08:31:39Z","updated_at":"2016-06-18T12:06:04Z","pushed_at":"2016-08-11T13:05:33Z","git_url":"git://github.com/okulikov/modeshape.git","ssh_url":"git@github.com:okulikov/modeshape.git","clone_url":"https://github.com/okulikov/modeshape.git","svn_url":"https://github.com/okulikov/modeshape","homepage":"http://www.modeshape.org","size":132826,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ModeShape:master","ref":"master","sha":"a79ea8b81d121131cd7c0358c3907c1a19067850","user":{"login":"ModeShape","id":148023,"avatar_url":"https://avatars.githubusercontent.com/u/148023?v=3","gravatar_id":"","url":"https://api.github.com/users/ModeShape","html_url":"https://github.com/ModeShape","followers_url":"https://api.github.com/users/ModeShape/followers","following_url":"https://api.github.com/users/ModeShape/following{/other_user}","gists_url":"https://api.github.com/users/ModeShape/gists{/gist_id}","starred_url":"https://api.github.com/users/ModeShape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ModeShape/subscriptions","organizations_url":"https://api.github.com/users/ModeShape/orgs","repos_url":"https://api.github.com/users/ModeShape/repos","events_url":"https://api.github.com/users/ModeShape/events{/privacy}","received_events_url":"https://api.github.com/users/ModeShape/received_events","type":"Organization","site_admin":false},"repo":{"id":1244027,"name":"modeshape","full_name":"ModeShape/modeshape","owner":{"login":"ModeShape","id":148023,"avatar_url":"https://avatars.githubusercontent.com/u/148023?v=3","gravatar_id":"","url":"https://api.github.com/users/ModeShape","html_url":"https://github.com/ModeShape","followers_url":"https://api.github.com/users/ModeShape/followers","following_url":"https://api.github.com/users/ModeShape/following{/other_user}","gists_url":"https://api.github.com/users/ModeShape/gists{/gist_id}","starred_url":"https://api.github.com/users/ModeShape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ModeShape/subscriptions","organizations_url":"https://api.github.com/users/ModeShape/orgs","repos_url":"https://api.github.com/users/ModeShape/repos","events_url":"https://api.github.com/users/ModeShape/events{/privacy}","received_events_url":"https://api.github.com/users/ModeShape/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ModeShape/modeshape","description":"ModeShape is a distributed, hierarchical, transactional, and consistent data store with support for queries, full-text search, events, versioning, references, and flexible and dynamic schemas. It is very fast, highly available, extremely scalable, and it is 100% open source and written in Java. Clients use the JSR-283 standard Java API for content repositories (aka, JCR) or ModeShape's REST API, and can query content through JDBC and SQL.","fork":false,"url":"https://api.github.com/repos/ModeShape/modeshape","forks_url":"https://api.github.com/repos/ModeShape/modeshape/forks","keys_url":"https://api.github.com/repos/ModeShape/modeshape/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ModeShape/modeshape/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ModeShape/modeshape/teams","hooks_url":"https://api.github.com/repos/ModeShape/modeshape/hooks","issue_events_url":"https://api.github.com/repos/ModeShape/modeshape/issues/events{/number}","events_url":"https://api.github.com/repos/ModeShape/modeshape/events","assignees_url":"https://api.github.com/repos/ModeShape/modeshape/assignees{/user}","branches_url":"https://api.github.com/repos/ModeShape/modeshape/branches{/branch}","tags_url":"https://api.github.com/repos/ModeShape/modeshape/tags","blobs_url":"https://api.github.com/repos/ModeShape/modeshape/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ModeShape/modeshape/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ModeShape/modeshape/git/refs{/sha}","trees_url":"https://api.github.com/repos/ModeShape/modeshape/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ModeShape/modeshape/statuses/{sha}","languages_url":"https://api.github.com/repos/ModeShape/modeshape/languages","stargazers_url":"https://api.github.com/repos/ModeShape/modeshape/stargazers","contributors_url":"https://api.github.com/repos/ModeShape/modeshape/contributors","subscribers_url":"https://api.github.com/repos/ModeShape/modeshape/subscribers","subscription_url":"https://api.github.com/repos/ModeShape/modeshape/subscription","commits_url":"https://api.github.com/repos/ModeShape/modeshape/commits{/sha}","git_commits_url":"https://api.github.com/repos/ModeShape/modeshape/git/commits{/sha}","comments_url":"https://api.github.com/repos/ModeShape/modeshape/comments{/number}","issue_comment_url":"https://api.github.com/repos/ModeShape/modeshape/issues/comments{/number}","contents_url":"https://api.github.com/repos/ModeShape/modeshape/contents/{+path}","compare_url":"https://api.github.com/repos/ModeShape/modeshape/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ModeShape/modeshape/merges","archive_url":"https://api.github.com/repos/ModeShape/modeshape/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ModeShape/modeshape/downloads","issues_url":"https://api.github.com/repos/ModeShape/modeshape/issues{/number}","pulls_url":"https://api.github.com/repos/ModeShape/modeshape/pulls{/number}","milestones_url":"https://api.github.com/repos/ModeShape/modeshape/milestones{/number}","notifications_url":"https://api.github.com/repos/ModeShape/modeshape/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ModeShape/modeshape/labels{/name}","releases_url":"https://api.github.com/repos/ModeShape/modeshape/releases{/id}","deployments_url":"https://api.github.com/repos/ModeShape/modeshape/deployments","created_at":"2011-01-12T02:30:46Z","updated_at":"2016-08-06T06:04:20Z","pushed_at":"2016-08-11T13:05:34Z","git_url":"git://github.com/ModeShape/modeshape.git","ssh_url":"git@github.com:ModeShape/modeshape.git","clone_url":"https://github.com/ModeShape/modeshape.git","svn_url":"https://github.com/ModeShape/modeshape","homepage":"http://www.modeshape.org","size":137744,"stargazers_count":161,"watchers_count":161,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":169,"mirror_url":null,"open_issues_count":1,"forks":169,"open_issues":1,"watchers":161,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ModeShape/modeshape/pulls/1580"},"html":{"href":"https://github.com/ModeShape/modeshape/pull/1580"},"issue":{"href":"https://api.github.com/repos/ModeShape/modeshape/issues/1580"},"comments":{"href":"https://api.github.com/repos/ModeShape/modeshape/issues/1580/comments"},"review_comments":{"href":"https://api.github.com/repos/ModeShape/modeshape/pulls/1580/comments"},"review_comment":{"href":"https://api.github.com/repos/ModeShape/modeshape/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ModeShape/modeshape/pulls/1580/commits"},"statuses":{"href":"https://api.github.com/repos/ModeShape/modeshape/statuses/caad57f96cf76529d7e5fd4d49f6c6f4caf73d3b"}}}}
{"actor":{"display_login":"rhauch"}}