{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/68397056","id":68397056,"diff_hunk":"@@ -206,7 +206,7 @@ def self.create_balancer_config(opts = {})\n     def self.create_redirects_config(opts = {})\n       opts[:redirects].to_miq_a.each_with_object(\"\") do |redirect, content|\n         if redirect == \"/\"\n-          content << \"RewriteRule ^/self_service(?!/(assets|images|img|styles|js|fonts)) /self_service/index.html [L]\\n\"\n+          content << \"RewriteRule ^/self_service(?!/(assets|images|img|styles|js|fonts|bower_components|gettext)) /self_service/index.html [L]\\n\"","path":"gems/pending/util/miq_apache/miq_apache.rb","position":5,"original_position":5,"commit_id":"16771e0f0b845b077a76c068d0a1c2841121ac46","original_commit_id":"16771e0f0b845b077a76c068d0a1c2841121ac46","user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"body":"Note, this is getting really complicated... we should probably try to understand if we can fix this in code via clearer routes so we don't need such a complicated rewrite rule.  For example, why are many of these redirecting but not all?","created_at":"2016-06-24T13:25:53Z","updated_at":"2016-06-24T13:25:53Z","html_url":"https://github.com/ManageIQ/manageiq/pull/9432#discussion_r68397056","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9432","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/68397056"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/9432#discussion_r68397056"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9432"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9432","id":75086123,"html_url":"https://github.com/ManageIQ/manageiq/pull/9432","diff_url":"https://github.com/ManageIQ/manageiq/pull/9432.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/9432.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9432","number":9432,"state":"open","locked":false,"title":"MiqApache::Conf - update SSUI redirects to allow bower_components/ and gettext/","user":{"login":"himdel","id":289743,"avatar_url":"https://avatars.githubusercontent.com/u/289743?v=3","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false},"body":"SSUI needs html files under `bower_components` for the consoles to work, and json translations under `gettext/` for translations to work.\r\n\r\nThese files are there since https://github.com/ManageIQ/manageiq-ui-self_service/pull/65 , but the `RewriteRule` in `/etc/httpd/conf.d/manageiq-redirects-ui` always rewrites those URLs to `/self_service/index.html` => this PR makes `bower_components/` and `gettext/` *not* get redirected to `index.html`\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1347319\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1347312","created_at":"2016-06-24T09:19:29Z","updated_at":"2016-06-24T13:25:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a728f7e05e1208562137b21f0c911869f8d4a5fc","assignee":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"assignees":[{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9432/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9432/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/9432/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/16771e0f0b845b077a76c068d0a1c2841121ac46","head":{"label":"himdel:bz1347319,1347312","ref":"bz1347319,1347312","sha":"16771e0f0b845b077a76c068d0a1c2841121ac46","user":{"login":"himdel","id":289743,"avatar_url":"https://avatars.githubusercontent.com/u/289743?v=3","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false},"repo":{"id":30235491,"name":"manageiq","full_name":"himdel/manageiq","owner":{"login":"himdel","id":289743,"avatar_url":"https://avatars.githubusercontent.com/u/289743?v=3","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/himdel/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/himdel/manageiq","forks_url":"https://api.github.com/repos/himdel/manageiq/forks","keys_url":"https://api.github.com/repos/himdel/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/himdel/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/himdel/manageiq/teams","hooks_url":"https://api.github.com/repos/himdel/manageiq/hooks","issue_events_url":"https://api.github.com/repos/himdel/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/himdel/manageiq/events","assignees_url":"https://api.github.com/repos/himdel/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/himdel/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/himdel/manageiq/tags","blobs_url":"https://api.github.com/repos/himdel/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/himdel/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/himdel/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/himdel/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/himdel/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/himdel/manageiq/languages","stargazers_url":"https://api.github.com/repos/himdel/manageiq/stargazers","contributors_url":"https://api.github.com/repos/himdel/manageiq/contributors","subscribers_url":"https://api.github.com/repos/himdel/manageiq/subscribers","subscription_url":"https://api.github.com/repos/himdel/manageiq/subscription","commits_url":"https://api.github.com/repos/himdel/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/himdel/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/himdel/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/himdel/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/himdel/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/himdel/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/himdel/manageiq/merges","archive_url":"https://api.github.com/repos/himdel/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/himdel/manageiq/downloads","issues_url":"https://api.github.com/repos/himdel/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/himdel/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/himdel/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/himdel/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/himdel/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/himdel/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/himdel/manageiq/deployments","created_at":"2015-02-03T09:36:54Z","updated_at":"2016-01-12T17:18:36Z","pushed_at":"2016-06-24T12:43:40Z","git_url":"git://github.com/himdel/manageiq.git","ssh_url":"git@github.com:himdel/manageiq.git","clone_url":"https://github.com/himdel/manageiq.git","svn_url":"https://github.com/himdel/manageiq","homepage":"manageiq.org","size":131206,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"c4ea76f176543992b75411f78d1b8c37aeb78c38","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2016-06-24T12:38:06Z","pushed_at":"2016-06-24T13:25:13Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":172697,"stargazers_count":286,"watchers_count":286,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":311,"mirror_url":null,"open_issues_count":744,"forks":311,"open_issues":744,"watchers":286,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9432"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/9432"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/9432"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/9432/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9432/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/9432/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/16771e0f0b845b077a76c068d0a1c2841121ac46"}}}}
{"actor":{"display_login":"jrafanie"}}