{"action":"closed","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-go/issues/452","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-go","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-go/issues/452/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-go/issues/452/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-go/issues/452/events","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-go/issues/452","id":194194897,"number":452,"title":"pubsub: the maxPayload size used in splitAckIDs is larger than allowed by gRPC. ","user":{"login":"epsniff","id":2811550,"avatar_url":"https://avatars.githubusercontent.com/u/2811550?v=3","gravatar_id":"","url":"https://api.github.com/users/epsniff","html_url":"https://github.com/epsniff","followers_url":"https://api.github.com/users/epsniff/followers","following_url":"https://api.github.com/users/epsniff/following{/other_user}","gists_url":"https://api.github.com/users/epsniff/gists{/gist_id}","starred_url":"https://api.github.com/users/epsniff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epsniff/subscriptions","organizations_url":"https://api.github.com/users/epsniff/orgs","repos_url":"https://api.github.com/users/epsniff/repos","events_url":"https://api.github.com/users/epsniff/events{/privacy}","received_events_url":"https://api.github.com/users/epsniff/received_events","type":"User","site_admin":false},"labels":[{"id":98312214,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-go/labels/bug","name":"bug","color":"fc2929","default":true},{"id":217652843,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-go/labels/pubsub","name":"pubsub","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":{"login":"jba","id":18483045,"avatar_url":"https://avatars.githubusercontent.com/u/18483045?v=3","gravatar_id":"","url":"https://api.github.com/users/jba","html_url":"https://github.com/jba","followers_url":"https://api.github.com/users/jba/followers","following_url":"https://api.github.com/users/jba/following{/other_user}","gists_url":"https://api.github.com/users/jba/gists{/gist_id}","starred_url":"https://api.github.com/users/jba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jba/subscriptions","organizations_url":"https://api.github.com/users/jba/orgs","repos_url":"https://api.github.com/users/jba/repos","events_url":"https://api.github.com/users/jba/events{/privacy}","received_events_url":"https://api.github.com/users/jba/received_events","type":"User","site_admin":false},"assignees":[{"login":"jba","id":18483045,"avatar_url":"https://avatars.githubusercontent.com/u/18483045?v=3","gravatar_id":"","url":"https://api.github.com/users/jba","html_url":"https://github.com/jba","followers_url":"https://api.github.com/users/jba/followers","following_url":"https://api.github.com/users/jba/following{/other_user}","gists_url":"https://api.github.com/users/jba/gists{/gist_id}","starred_url":"https://api.github.com/users/jba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jba/subscriptions","organizations_url":"https://api.github.com/users/jba/orgs","repos_url":"https://api.github.com/users/jba/repos","events_url":"https://api.github.com/users/jba/events{/privacy}","received_events_url":"https://api.github.com/users/jba/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-12-07T22:46:17Z","updated_at":"2016-12-09T14:32:55Z","closed_at":"2016-12-09T14:32:55Z","body":"After upgrading our pubsub client from the http based client to the gRPC client we noticed a huge drop in our ack rate for high volume subscriptions.   But at the same time our pull rate and processing rates remained the same. \r\n\r\nBy adding error logging to [acker.go](https://github.com/GoogleCloudPlatform/google-cloud-go/blob/master/pubsub/acker.go#L147), I discovered these consumers were dropping all of the acks with this error.\r\n```\r\n2016/12/07 22:14:41.421964 acker.go:162: ack dropping 6151 msgs: error:rpc error: code = 3 desc = Request payload size exceeds the limit: 524288 bytes.\r\n```\r\n\r\nAfter lowering the [maxPayload](https://github.com/GoogleCloudPlatform/google-cloud-go/blob/master/pubsub/service.go#L223) const to be 512k, the errors stopped and my ack rate returned to normal.\r\n```\r\nmaxPayload       = 1 * 1024 * 1024\r\n```\r\nShould be:\r\n```\r\nmaxPayload       = 512 * 1024\r\n```"}}
{"actor":{"display_login":"jba"}}