{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/comments/88228186","pull_request_review_id":8806503,"id":88228186,"diff_hunk":"@@ -16,84 +16,55 @@ module DiffEqBase\n   abstract AbstractSDEProblem <: DEProblem\n   abstract AbstractDAEProblem <: DEProblem\n   abstract AbstractDDEProblem <: DEProblem\n-  abstract AbstractPoissonProblem <: DEProblem\n-  abstract AbstractHeatProblem <: DEProblem\n-  \"`PdeSolution`: Wrapper for the objects obtained from a solver\"\n+  abstract AbstractPDEProblem <: DEProblem\n+  \"`DSolution`: type to hold the objects obtained from a solver\"\n   abstract DESolution\n   abstract AbstractODESolution <: DESolution\n   abstract AbstractSDESolution <: AbstractODESolution # Needed for plot recipes\n   abstract AbstractDDESolution <: AbstractODESolution # Needed for plot recipes\n   abstract AbstractFEMSolution <: DESolution\n   abstract AbstractSensitivitySolution\n-  \"`Mesh`: An abstract type which holds a (node,elem) pair and other information for a mesh\"\n-  abstract Mesh\n-  \"`Tableau`: Holds the information for a Runge-Kutta Tableau\"\n+\n+\"`Tableau`: Holds the information for a Runge-Kutta Tableau\"\n   abstract Tableau\n \n   \"`ODERKTableau`: A Runge-Kutta Tableau for an ODE integrator\"\n   abstract ODERKTableau <: Tableau\n \n-  \"`DEIntegrator`: A DifferentialEquations Integrator type, used to initiate a solver.\"\n-  abstract DEIntegrator","path":"src/DiffEqBase.jl","position":35,"original_position":35,"commit_id":"0a2896490762a8392e81d6559e087556510edbab","original_commit_id":"0a2896490762a8392e81d6559e087556510edbab","user":{"login":"mauro3","id":4098145,"avatar_url":"https://avatars.githubusercontent.com/u/4098145?v=3","gravatar_id":"","url":"https://api.github.com/users/mauro3","html_url":"https://github.com/mauro3","followers_url":"https://api.github.com/users/mauro3/followers","following_url":"https://api.github.com/users/mauro3/following{/other_user}","gists_url":"https://api.github.com/users/mauro3/gists{/gist_id}","starred_url":"https://api.github.com/users/mauro3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauro3/subscriptions","organizations_url":"https://api.github.com/users/mauro3/orgs","repos_url":"https://api.github.com/users/mauro3/repos","events_url":"https://api.github.com/users/mauro3/events{/privacy}","received_events_url":"https://api.github.com/users/mauro3/received_events","type":"User","site_admin":false},"body":"Don't know what this does.","created_at":"2016-11-16T12:41:25Z","updated_at":"2016-11-16T12:41:25Z","html_url":"https://github.com/JuliaDiffEq/DiffEqBase.jl/pull/5#discussion_r88228186","pull_request_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/comments/88228186"},"html":{"href":"https://github.com/JuliaDiffEq/DiffEqBase.jl/pull/5#discussion_r88228186"},"pull_request":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/5","id":93958191,"html_url":"https://github.com/JuliaDiffEq/DiffEqBase.jl/pull/5","diff_url":"https://github.com/JuliaDiffEq/DiffEqBase.jl/pull/5.diff","patch_url":"https://github.com/JuliaDiffEq/DiffEqBase.jl/pull/5.patch","issue_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/issues/5","number":5,"state":"open","locked":false,"title":"WIP: removing bits which should go into packages","user":{"login":"mauro3","id":4098145,"avatar_url":"https://avatars.githubusercontent.com/u/4098145?v=3","gravatar_id":"","url":"https://api.github.com/users/mauro3","html_url":"https://github.com/mauro3","followers_url":"https://api.github.com/users/mauro3/followers","following_url":"https://api.github.com/users/mauro3/following{/other_user}","gists_url":"https://api.github.com/users/mauro3/gists{/gist_id}","starred_url":"https://api.github.com/users/mauro3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauro3/subscriptions","organizations_url":"https://api.github.com/users/mauro3/orgs","repos_url":"https://api.github.com/users/mauro3/repos","events_url":"https://api.github.com/users/mauro3/events{/privacy}","received_events_url":"https://api.github.com/users/mauro3/received_events","type":"User","site_admin":false},"body":"This PR removes bits which I think should be in packages.  In particular the all the algorithms needen't and shouldn't be defined here.  If I understood correctly, this is my answer to https://github.com/JuliaDiffEq/Roadmap/issues/9.\r\n\r\nNote that this of course also necessitates changes in downstream pkgs.","created_at":"2016-11-16T12:39:21Z","updated_at":"2016-11-16T12:44:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0cda204229f89238672fcce4d9055b5d1282a000","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/5/commits","review_comments_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/5/comments","review_comment_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/issues/5/comments","statuses_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/statuses/0a2896490762a8392e81d6559e087556510edbab","head":{"label":"JuliaDiffEq:m3/rm","ref":"m3/rm","sha":"0a2896490762a8392e81d6559e087556510edbab","user":{"login":"JuliaDiffEq","id":21238080,"avatar_url":"https://avatars.githubusercontent.com/u/21238080?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaDiffEq","html_url":"https://github.com/JuliaDiffEq","followers_url":"https://api.github.com/users/JuliaDiffEq/followers","following_url":"https://api.github.com/users/JuliaDiffEq/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiffEq/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiffEq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiffEq/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiffEq/orgs","repos_url":"https://api.github.com/users/JuliaDiffEq/repos","events_url":"https://api.github.com/users/JuliaDiffEq/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiffEq/received_events","type":"Organization","site_admin":false},"repo":{"id":71509444,"name":"DiffEqBase.jl","full_name":"JuliaDiffEq/DiffEqBase.jl","owner":{"login":"JuliaDiffEq","id":21238080,"avatar_url":"https://avatars.githubusercontent.com/u/21238080?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaDiffEq","html_url":"https://github.com/JuliaDiffEq","followers_url":"https://api.github.com/users/JuliaDiffEq/followers","following_url":"https://api.github.com/users/JuliaDiffEq/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiffEq/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiffEq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiffEq/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiffEq/orgs","repos_url":"https://api.github.com/users/JuliaDiffEq/repos","events_url":"https://api.github.com/users/JuliaDiffEq/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiffEq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaDiffEq/DiffEqBase.jl","description":"The lightweight Base library for shared types and functionality.","fork":false,"url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl","forks_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/forks","keys_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/teams","hooks_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/events","assignees_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/tags","blobs_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/subscription","commits_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/merges","archive_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/downloads","issues_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/deployments","created_at":"2016-10-20T22:28:36Z","updated_at":"2016-10-22T06:45:34Z","pushed_at":"2016-11-16T12:39:21Z","git_url":"git://github.com/JuliaDiffEq/DiffEqBase.jl.git","ssh_url":"git@github.com:JuliaDiffEq/DiffEqBase.jl.git","clone_url":"https://github.com/JuliaDiffEq/DiffEqBase.jl.git","svn_url":"https://github.com/JuliaDiffEq/DiffEqBase.jl","homepage":null,"size":62,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaDiffEq:master","ref":"master","sha":"6138427e79da426912d29f297ab3232ea4309b66","user":{"login":"JuliaDiffEq","id":21238080,"avatar_url":"https://avatars.githubusercontent.com/u/21238080?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaDiffEq","html_url":"https://github.com/JuliaDiffEq","followers_url":"https://api.github.com/users/JuliaDiffEq/followers","following_url":"https://api.github.com/users/JuliaDiffEq/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiffEq/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiffEq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiffEq/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiffEq/orgs","repos_url":"https://api.github.com/users/JuliaDiffEq/repos","events_url":"https://api.github.com/users/JuliaDiffEq/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiffEq/received_events","type":"Organization","site_admin":false},"repo":{"id":71509444,"name":"DiffEqBase.jl","full_name":"JuliaDiffEq/DiffEqBase.jl","owner":{"login":"JuliaDiffEq","id":21238080,"avatar_url":"https://avatars.githubusercontent.com/u/21238080?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaDiffEq","html_url":"https://github.com/JuliaDiffEq","followers_url":"https://api.github.com/users/JuliaDiffEq/followers","following_url":"https://api.github.com/users/JuliaDiffEq/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiffEq/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiffEq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiffEq/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiffEq/orgs","repos_url":"https://api.github.com/users/JuliaDiffEq/repos","events_url":"https://api.github.com/users/JuliaDiffEq/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiffEq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaDiffEq/DiffEqBase.jl","description":"The lightweight Base library for shared types and functionality.","fork":false,"url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl","forks_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/forks","keys_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/teams","hooks_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/events","assignees_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/tags","blobs_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/subscription","commits_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/merges","archive_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/downloads","issues_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/deployments","created_at":"2016-10-20T22:28:36Z","updated_at":"2016-10-22T06:45:34Z","pushed_at":"2016-11-16T12:39:21Z","git_url":"git://github.com/JuliaDiffEq/DiffEqBase.jl.git","ssh_url":"git@github.com:JuliaDiffEq/DiffEqBase.jl.git","clone_url":"https://github.com/JuliaDiffEq/DiffEqBase.jl.git","svn_url":"https://github.com/JuliaDiffEq/DiffEqBase.jl","homepage":null,"size":62,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/5"},"html":{"href":"https://github.com/JuliaDiffEq/DiffEqBase.jl/pull/5"},"issue":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/issues/5"},"comments":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaDiffEq/DiffEqBase.jl/statuses/0a2896490762a8392e81d6559e087556510edbab"}}}}
{"actor":{"display_login":"mauro3"}}