{"action":"created","comment":{"url":"https://api.github.com/repos/OfflineIMAP/offlineimap/pulls/comments/67434006","id":67434006,"diff_hunk":"@@ -198,7 +198,7 @@ def __md5handler(self, response):\n         challenge = response.strip()\n         self.ui.debug('imap', '__md5handler: got challenge %s'% challenge)\n \n-        passwd = self.__getpassword()\n+        passwd = self.__getpassword().encode('ascii')","path":"offlineimap/imapserver.py","position":5,"original_position":5,"commit_id":"cedc8eb020f5868299bb9e0420635d3ef8446065","original_commit_id":"cedc8eb020f5868299bb9e0420635d3ef8446065","user":{"login":"dolohow","id":1408564,"avatar_url":"https://avatars.githubusercontent.com/u/1408564?v=3","gravatar_id":"","url":"https://api.github.com/users/dolohow","html_url":"https://github.com/dolohow","followers_url":"https://api.github.com/users/dolohow/followers","following_url":"https://api.github.com/users/dolohow/following{/other_user}","gists_url":"https://api.github.com/users/dolohow/gists{/gist_id}","starred_url":"https://api.github.com/users/dolohow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolohow/subscriptions","organizations_url":"https://api.github.com/users/dolohow/orgs","repos_url":"https://api.github.com/users/dolohow/repos","events_url":"https://api.github.com/users/dolohow/events{/privacy}","received_events_url":"https://api.github.com/users/dolohow/received_events","type":"User","site_admin":false},"body":"I think it could be annoying to people to prefix their string values with \"u\" character.  Not everyone needs to know what unicode is and it is pretty obvious that this makes the configuration ugly.  One could ask why we do not prefix everything with \"u\" only some fields and the answer could be, because it makes our job easier sounds like a cheap excuse.  Yet this is my point of view and I encourage a discussion here.","created_at":"2016-06-16T22:14:33Z","updated_at":"2016-06-16T22:14:33Z","html_url":"https://github.com/OfflineIMAP/offlineimap/pull/341#discussion_r67434006","pull_request_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/pulls/341","_links":{"self":{"href":"https://api.github.com/repos/OfflineIMAP/offlineimap/pulls/comments/67434006"},"html":{"href":"https://github.com/OfflineIMAP/offlineimap/pull/341#discussion_r67434006"},"pull_request":{"href":"https://api.github.com/repos/OfflineIMAP/offlineimap/pulls/341"}}},"pull_request":{"url":"https://api.github.com/repos/OfflineIMAP/offlineimap/pulls/341","id":73780853,"html_url":"https://github.com/OfflineIMAP/offlineimap/pull/341","diff_url":"https://github.com/OfflineIMAP/offlineimap/pull/341.diff","patch_url":"https://github.com/OfflineIMAP/offlineimap/pull/341.patch","issue_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/issues/341","number":341,"state":"open","locked":false,"title":"hmac requires bytes as key","user":{"login":"jimdigriz","id":2567406,"avatar_url":"https://avatars.githubusercontent.com/u/2567406?v=3","gravatar_id":"","url":"https://api.github.com/users/jimdigriz","html_url":"https://github.com/jimdigriz","followers_url":"https://api.github.com/users/jimdigriz/followers","following_url":"https://api.github.com/users/jimdigriz/following{/other_user}","gists_url":"https://api.github.com/users/jimdigriz/gists{/gist_id}","starred_url":"https://api.github.com/users/jimdigriz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimdigriz/subscriptions","organizations_url":"https://api.github.com/users/jimdigriz/orgs","repos_url":"https://api.github.com/users/jimdigriz/repos","events_url":"https://api.github.com/users/jimdigriz/events{/privacy}","received_events_url":"https://api.github.com/users/jimdigriz/received_events","type":"User","site_admin":false},"body":"### This PR\r\n\r\n- [x] I've read the [DCO](http://www.offlineimap.org/doc/dco.html).\r\n- [X] I've read the [Coding Guidelines](http://www.offlineimap.org/doc/CodingGuidelines.html)\r\n- [X] The relevant informations about the changes stands in the commit message, not here in the message of the pull request.\r\n- [X] Code changes follow the style of the files they change.\r\n- [X] Code is tested (provide details). - fixes this bug and authenticates\r\n\r\n### References\r\n\r\n- Issue #339 \r\n\r\n### Additional information\r\nhttps://bugs.python.org/issue18240","created_at":"2016-06-14T17:29:46Z","updated_at":"2016-06-16T22:14:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"307b1bc699aa4ed426939e6cca82aa3c16782626","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/pulls/341/commits","review_comments_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/pulls/341/comments","review_comment_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/issues/341/comments","statuses_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/statuses/cedc8eb020f5868299bb9e0420635d3ef8446065","head":{"label":"jimdigriz:hmac-needs-to-be-bytes","ref":"hmac-needs-to-be-bytes","sha":"cedc8eb020f5868299bb9e0420635d3ef8446065","user":{"login":"jimdigriz","id":2567406,"avatar_url":"https://avatars.githubusercontent.com/u/2567406?v=3","gravatar_id":"","url":"https://api.github.com/users/jimdigriz","html_url":"https://github.com/jimdigriz","followers_url":"https://api.github.com/users/jimdigriz/followers","following_url":"https://api.github.com/users/jimdigriz/following{/other_user}","gists_url":"https://api.github.com/users/jimdigriz/gists{/gist_id}","starred_url":"https://api.github.com/users/jimdigriz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimdigriz/subscriptions","organizations_url":"https://api.github.com/users/jimdigriz/orgs","repos_url":"https://api.github.com/users/jimdigriz/repos","events_url":"https://api.github.com/users/jimdigriz/events{/privacy}","received_events_url":"https://api.github.com/users/jimdigriz/received_events","type":"User","site_admin":false},"repo":{"id":61137941,"name":"offlineimap","full_name":"jimdigriz/offlineimap","owner":{"login":"jimdigriz","id":2567406,"avatar_url":"https://avatars.githubusercontent.com/u/2567406?v=3","gravatar_id":"","url":"https://api.github.com/users/jimdigriz","html_url":"https://github.com/jimdigriz","followers_url":"https://api.github.com/users/jimdigriz/followers","following_url":"https://api.github.com/users/jimdigriz/following{/other_user}","gists_url":"https://api.github.com/users/jimdigriz/gists{/gist_id}","starred_url":"https://api.github.com/users/jimdigriz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimdigriz/subscriptions","organizations_url":"https://api.github.com/users/jimdigriz/orgs","repos_url":"https://api.github.com/users/jimdigriz/repos","events_url":"https://api.github.com/users/jimdigriz/events{/privacy}","received_events_url":"https://api.github.com/users/jimdigriz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimdigriz/offlineimap","description":"Read/sync your IMAP mailboxes [Python]","fork":true,"url":"https://api.github.com/repos/jimdigriz/offlineimap","forks_url":"https://api.github.com/repos/jimdigriz/offlineimap/forks","keys_url":"https://api.github.com/repos/jimdigriz/offlineimap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimdigriz/offlineimap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimdigriz/offlineimap/teams","hooks_url":"https://api.github.com/repos/jimdigriz/offlineimap/hooks","issue_events_url":"https://api.github.com/repos/jimdigriz/offlineimap/issues/events{/number}","events_url":"https://api.github.com/repos/jimdigriz/offlineimap/events","assignees_url":"https://api.github.com/repos/jimdigriz/offlineimap/assignees{/user}","branches_url":"https://api.github.com/repos/jimdigriz/offlineimap/branches{/branch}","tags_url":"https://api.github.com/repos/jimdigriz/offlineimap/tags","blobs_url":"https://api.github.com/repos/jimdigriz/offlineimap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimdigriz/offlineimap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimdigriz/offlineimap/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimdigriz/offlineimap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimdigriz/offlineimap/statuses/{sha}","languages_url":"https://api.github.com/repos/jimdigriz/offlineimap/languages","stargazers_url":"https://api.github.com/repos/jimdigriz/offlineimap/stargazers","contributors_url":"https://api.github.com/repos/jimdigriz/offlineimap/contributors","subscribers_url":"https://api.github.com/repos/jimdigriz/offlineimap/subscribers","subscription_url":"https://api.github.com/repos/jimdigriz/offlineimap/subscription","commits_url":"https://api.github.com/repos/jimdigriz/offlineimap/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimdigriz/offlineimap/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimdigriz/offlineimap/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimdigriz/offlineimap/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimdigriz/offlineimap/contents/{+path}","compare_url":"https://api.github.com/repos/jimdigriz/offlineimap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimdigriz/offlineimap/merges","archive_url":"https://api.github.com/repos/jimdigriz/offlineimap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimdigriz/offlineimap/downloads","issues_url":"https://api.github.com/repos/jimdigriz/offlineimap/issues{/number}","pulls_url":"https://api.github.com/repos/jimdigriz/offlineimap/pulls{/number}","milestones_url":"https://api.github.com/repos/jimdigriz/offlineimap/milestones{/number}","notifications_url":"https://api.github.com/repos/jimdigriz/offlineimap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimdigriz/offlineimap/labels{/name}","releases_url":"https://api.github.com/repos/jimdigriz/offlineimap/releases{/id}","deployments_url":"https://api.github.com/repos/jimdigriz/offlineimap/deployments","created_at":"2016-06-14T16:20:12Z","updated_at":"2016-06-14T16:20:14Z","pushed_at":"2016-06-14T17:27:35Z","git_url":"git://github.com/jimdigriz/offlineimap.git","ssh_url":"git@github.com:jimdigriz/offlineimap.git","clone_url":"https://github.com/jimdigriz/offlineimap.git","svn_url":"https://github.com/jimdigriz/offlineimap","homepage":"http://www.offlineimap.org","size":6602,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OfflineIMAP:next","ref":"next","sha":"3a5becf6a75f58fa43d396164561739e86bcb34e","user":{"login":"OfflineIMAP","id":2027973,"avatar_url":"https://avatars.githubusercontent.com/u/2027973?v=3","gravatar_id":"","url":"https://api.github.com/users/OfflineIMAP","html_url":"https://github.com/OfflineIMAP","followers_url":"https://api.github.com/users/OfflineIMAP/followers","following_url":"https://api.github.com/users/OfflineIMAP/following{/other_user}","gists_url":"https://api.github.com/users/OfflineIMAP/gists{/gist_id}","starred_url":"https://api.github.com/users/OfflineIMAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfflineIMAP/subscriptions","organizations_url":"https://api.github.com/users/OfflineIMAP/orgs","repos_url":"https://api.github.com/users/OfflineIMAP/repos","events_url":"https://api.github.com/users/OfflineIMAP/events{/privacy}","received_events_url":"https://api.github.com/users/OfflineIMAP/received_events","type":"Organization","site_admin":false},"repo":{"id":5153654,"name":"offlineimap","full_name":"OfflineIMAP/offlineimap","owner":{"login":"OfflineIMAP","id":2027973,"avatar_url":"https://avatars.githubusercontent.com/u/2027973?v=3","gravatar_id":"","url":"https://api.github.com/users/OfflineIMAP","html_url":"https://github.com/OfflineIMAP","followers_url":"https://api.github.com/users/OfflineIMAP/followers","following_url":"https://api.github.com/users/OfflineIMAP/following{/other_user}","gists_url":"https://api.github.com/users/OfflineIMAP/gists{/gist_id}","starred_url":"https://api.github.com/users/OfflineIMAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfflineIMAP/subscriptions","organizations_url":"https://api.github.com/users/OfflineIMAP/orgs","repos_url":"https://api.github.com/users/OfflineIMAP/repos","events_url":"https://api.github.com/users/OfflineIMAP/events{/privacy}","received_events_url":"https://api.github.com/users/OfflineIMAP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OfflineIMAP/offlineimap","description":"Read/sync your IMAP mailboxes [Python]","fork":false,"url":"https://api.github.com/repos/OfflineIMAP/offlineimap","forks_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/forks","keys_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/teams","hooks_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/hooks","issue_events_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/issues/events{/number}","events_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/events","assignees_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/assignees{/user}","branches_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/branches{/branch}","tags_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/tags","blobs_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/statuses/{sha}","languages_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/languages","stargazers_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/stargazers","contributors_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/contributors","subscribers_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/subscribers","subscription_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/subscription","commits_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/contents/{+path}","compare_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/merges","archive_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/downloads","issues_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/issues{/number}","pulls_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/pulls{/number}","milestones_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/milestones{/number}","notifications_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/labels{/name}","releases_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/releases{/id}","deployments_url":"https://api.github.com/repos/OfflineIMAP/offlineimap/deployments","created_at":"2012-07-23T15:28:58Z","updated_at":"2016-06-16T08:15:11Z","pushed_at":"2016-06-14T17:29:46Z","git_url":"git://github.com/OfflineIMAP/offlineimap.git","ssh_url":"git@github.com:OfflineIMAP/offlineimap.git","clone_url":"https://github.com/OfflineIMAP/offlineimap.git","svn_url":"https://github.com/OfflineIMAP/offlineimap","homepage":"http://www.offlineimap.org","size":7623,"stargazers_count":584,"watchers_count":584,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":225,"mirror_url":null,"open_issues_count":52,"forks":225,"open_issues":52,"watchers":584,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OfflineIMAP/offlineimap/pulls/341"},"html":{"href":"https://github.com/OfflineIMAP/offlineimap/pull/341"},"issue":{"href":"https://api.github.com/repos/OfflineIMAP/offlineimap/issues/341"},"comments":{"href":"https://api.github.com/repos/OfflineIMAP/offlineimap/issues/341/comments"},"review_comments":{"href":"https://api.github.com/repos/OfflineIMAP/offlineimap/pulls/341/comments"},"review_comment":{"href":"https://api.github.com/repos/OfflineIMAP/offlineimap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OfflineIMAP/offlineimap/pulls/341/commits"},"statuses":{"href":"https://api.github.com/repos/OfflineIMAP/offlineimap/statuses/cedc8eb020f5868299bb9e0420635d3ef8446065"}}}}
{"actor":{"display_login":"dolohow"}}