{"action":"created","comment":{"url":"https://api.github.com/repos/gtk-rs/gir/pulls/comments/51918364","id":51918364,"diff_hunk":"@@ -91,14 +112,22 @@ fn rust_type_full(env: &Env, type_id: library::TypeId, nullable: Nullable, ref_m\n \n     if type_id.ns_id != library::MAIN_NAMESPACE && type_id.ns_id != library::INTERNAL_NAMESPACE\n         && !implemented_in_main_namespace(&env.library, type_id) {\n-        let rust_type_with_prefix = rust_type.map(|s| format!(\"{}::{}\",\n-            crate_name(&env.library.namespace(type_id.ns_id).name), s));\n         if env.type_status(&type_id.full_name(&env.library)).ignored() {\n-            rust_type = Err(rust_type_with_prefix.as_str().into());\n-        } else {\n-            rust_type = rust_type_with_prefix;\n+            rust_type = Err(rust_type.as_str().to_owned());\n+        }\n+        rust_type = rust_type.map_any(|s| format!(\"{}::{}\",\n+            crate_name(&env.library.namespace(type_id.ns_id).name), s));\n+    }\n+\n+    if let Err(s) = rust_type {","path":"src/analysis/rust_type.rs","position":50,"original_position":50,"commit_id":"4232e06c980c88797297de31b355fbe8eeab6374","original_commit_id":"4232e06c980c88797297de31b355fbe8eeab6374","user":{"login":"EPashkin","id":584258,"avatar_url":"https://avatars.githubusercontent.com/u/584258?v=3","gravatar_id":"","url":"https://api.github.com/users/EPashkin","html_url":"https://github.com/EPashkin","followers_url":"https://api.github.com/users/EPashkin/followers","following_url":"https://api.github.com/users/EPashkin/following{/other_user}","gists_url":"https://api.github.com/users/EPashkin/gists{/gist_id}","starred_url":"https://api.github.com/users/EPashkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EPashkin/subscriptions","organizations_url":"https://api.github.com/users/EPashkin/orgs","repos_url":"https://api.github.com/users/EPashkin/repos","events_url":"https://api.github.com/users/EPashkin/events{/privacy}","received_events_url":"https://api.github.com/users/EPashkin/received_events","type":"User","site_admin":false},"body":"Not better just add `check_for_ignored: bool` and check it here?\r\nThen also functions will not needed.","created_at":"2016-02-04T18:49:57Z","updated_at":"2016-02-04T18:49:57Z","html_url":"https://github.com/gtk-rs/gir/pull/205#discussion_r51918364","pull_request_url":"https://api.github.com/repos/gtk-rs/gir/pulls/205","_links":{"self":{"href":"https://api.github.com/repos/gtk-rs/gir/pulls/comments/51918364"},"html":{"href":"https://github.com/gtk-rs/gir/pull/205#discussion_r51918364"},"pull_request":{"href":"https://api.github.com/repos/gtk-rs/gir/pulls/205"}}},"pull_request":{"url":"https://api.github.com/repos/gtk-rs/gir/pulls/205","id":58324796,"html_url":"https://github.com/gtk-rs/gir/pull/205","diff_url":"https://github.com/gtk-rs/gir/pull/205.diff","patch_url":"https://github.com/gtk-rs/gir/pull/205.patch","issue_url":"https://api.github.com/repos/gtk-rs/gir/issues/205","number":205,"state":"open","locked":false,"title":"Make \"ignored\" classes, interfaces or records ignored rust types as well","user":{"login":"gkoz","id":4260361,"avatar_url":"https://avatars.githubusercontent.com/u/4260361?v=3","gravatar_id":"","url":"https://api.github.com/users/gkoz","html_url":"https://github.com/gkoz","followers_url":"https://api.github.com/users/gkoz/followers","following_url":"https://api.github.com/users/gkoz/following{/other_user}","gists_url":"https://api.github.com/users/gkoz/gists{/gist_id}","starred_url":"https://api.github.com/users/gkoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkoz/subscriptions","organizations_url":"https://api.github.com/users/gkoz/orgs","repos_url":"https://api.github.com/users/gkoz/repos","events_url":"https://api.github.com/users/gkoz/events{/privacy}","received_events_url":"https://api.github.com/users/gkoz/received_events","type":"User","site_admin":false},"body":"Fix #201","created_at":"2016-02-04T18:02:54Z","updated_at":"2016-02-04T18:49:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"faf405999caf0ae95efd0f19da189ea1de7a1450","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gtk-rs/gir/pulls/205/commits","review_comments_url":"https://api.github.com/repos/gtk-rs/gir/pulls/205/comments","review_comment_url":"https://api.github.com/repos/gtk-rs/gir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gtk-rs/gir/issues/205/comments","statuses_url":"https://api.github.com/repos/gtk-rs/gir/statuses/4232e06c980c88797297de31b355fbe8eeab6374","head":{"label":"gkoz:ignores","ref":"ignores","sha":"4232e06c980c88797297de31b355fbe8eeab6374","user":{"login":"gkoz","id":4260361,"avatar_url":"https://avatars.githubusercontent.com/u/4260361?v=3","gravatar_id":"","url":"https://api.github.com/users/gkoz","html_url":"https://github.com/gkoz","followers_url":"https://api.github.com/users/gkoz/followers","following_url":"https://api.github.com/users/gkoz/following{/other_user}","gists_url":"https://api.github.com/users/gkoz/gists{/gist_id}","starred_url":"https://api.github.com/users/gkoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkoz/subscriptions","organizations_url":"https://api.github.com/users/gkoz/orgs","repos_url":"https://api.github.com/users/gkoz/repos","events_url":"https://api.github.com/users/gkoz/events{/privacy}","received_events_url":"https://api.github.com/users/gkoz/received_events","type":"User","site_admin":false},"repo":{"id":49890198,"name":"gir","full_name":"gkoz/gir","owner":{"login":"gkoz","id":4260361,"avatar_url":"https://avatars.githubusercontent.com/u/4260361?v=3","gravatar_id":"","url":"https://api.github.com/users/gkoz","html_url":"https://github.com/gkoz","followers_url":"https://api.github.com/users/gkoz/followers","following_url":"https://api.github.com/users/gkoz/following{/other_user}","gists_url":"https://api.github.com/users/gkoz/gists{/gist_id}","starred_url":"https://api.github.com/users/gkoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkoz/subscriptions","organizations_url":"https://api.github.com/users/gkoz/orgs","repos_url":"https://api.github.com/users/gkoz/repos","events_url":"https://api.github.com/users/gkoz/events{/privacy}","received_events_url":"https://api.github.com/users/gkoz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gkoz/gir","description":"","fork":true,"url":"https://api.github.com/repos/gkoz/gir","forks_url":"https://api.github.com/repos/gkoz/gir/forks","keys_url":"https://api.github.com/repos/gkoz/gir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gkoz/gir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gkoz/gir/teams","hooks_url":"https://api.github.com/repos/gkoz/gir/hooks","issue_events_url":"https://api.github.com/repos/gkoz/gir/issues/events{/number}","events_url":"https://api.github.com/repos/gkoz/gir/events","assignees_url":"https://api.github.com/repos/gkoz/gir/assignees{/user}","branches_url":"https://api.github.com/repos/gkoz/gir/branches{/branch}","tags_url":"https://api.github.com/repos/gkoz/gir/tags","blobs_url":"https://api.github.com/repos/gkoz/gir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gkoz/gir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gkoz/gir/git/refs{/sha}","trees_url":"https://api.github.com/repos/gkoz/gir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gkoz/gir/statuses/{sha}","languages_url":"https://api.github.com/repos/gkoz/gir/languages","stargazers_url":"https://api.github.com/repos/gkoz/gir/stargazers","contributors_url":"https://api.github.com/repos/gkoz/gir/contributors","subscribers_url":"https://api.github.com/repos/gkoz/gir/subscribers","subscription_url":"https://api.github.com/repos/gkoz/gir/subscription","commits_url":"https://api.github.com/repos/gkoz/gir/commits{/sha}","git_commits_url":"https://api.github.com/repos/gkoz/gir/git/commits{/sha}","comments_url":"https://api.github.com/repos/gkoz/gir/comments{/number}","issue_comment_url":"https://api.github.com/repos/gkoz/gir/issues/comments{/number}","contents_url":"https://api.github.com/repos/gkoz/gir/contents/{+path}","compare_url":"https://api.github.com/repos/gkoz/gir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gkoz/gir/merges","archive_url":"https://api.github.com/repos/gkoz/gir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gkoz/gir/downloads","issues_url":"https://api.github.com/repos/gkoz/gir/issues{/number}","pulls_url":"https://api.github.com/repos/gkoz/gir/pulls{/number}","milestones_url":"https://api.github.com/repos/gkoz/gir/milestones{/number}","notifications_url":"https://api.github.com/repos/gkoz/gir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gkoz/gir/labels{/name}","releases_url":"https://api.github.com/repos/gkoz/gir/releases{/id}","deployments_url":"https://api.github.com/repos/gkoz/gir/deployments","created_at":"2016-01-18T16:46:07Z","updated_at":"2016-01-18T16:46:07Z","pushed_at":"2016-02-04T18:02:20Z","git_url":"git://github.com/gkoz/gir.git","ssh_url":"git@github.com:gkoz/gir.git","clone_url":"https://github.com/gkoz/gir.git","svn_url":"https://github.com/gkoz/gir","homepage":null,"size":546,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gtk-rs:master","ref":"master","sha":"f6001117542a1b7aa92972cd4fe3495dd81db67f","user":{"login":"gtk-rs","id":11757045,"avatar_url":"https://avatars.githubusercontent.com/u/11757045?v=3","gravatar_id":"","url":"https://api.github.com/users/gtk-rs","html_url":"https://github.com/gtk-rs","followers_url":"https://api.github.com/users/gtk-rs/followers","following_url":"https://api.github.com/users/gtk-rs/following{/other_user}","gists_url":"https://api.github.com/users/gtk-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gtk-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtk-rs/subscriptions","organizations_url":"https://api.github.com/users/gtk-rs/orgs","repos_url":"https://api.github.com/users/gtk-rs/repos","events_url":"https://api.github.com/users/gtk-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gtk-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":37824715,"name":"gir","full_name":"gtk-rs/gir","owner":{"login":"gtk-rs","id":11757045,"avatar_url":"https://avatars.githubusercontent.com/u/11757045?v=3","gravatar_id":"","url":"https://api.github.com/users/gtk-rs","html_url":"https://github.com/gtk-rs","followers_url":"https://api.github.com/users/gtk-rs/followers","following_url":"https://api.github.com/users/gtk-rs/following{/other_user}","gists_url":"https://api.github.com/users/gtk-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gtk-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtk-rs/subscriptions","organizations_url":"https://api.github.com/users/gtk-rs/orgs","repos_url":"https://api.github.com/users/gtk-rs/repos","events_url":"https://api.github.com/users/gtk-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gtk-rs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gtk-rs/gir","description":"","fork":false,"url":"https://api.github.com/repos/gtk-rs/gir","forks_url":"https://api.github.com/repos/gtk-rs/gir/forks","keys_url":"https://api.github.com/repos/gtk-rs/gir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gtk-rs/gir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gtk-rs/gir/teams","hooks_url":"https://api.github.com/repos/gtk-rs/gir/hooks","issue_events_url":"https://api.github.com/repos/gtk-rs/gir/issues/events{/number}","events_url":"https://api.github.com/repos/gtk-rs/gir/events","assignees_url":"https://api.github.com/repos/gtk-rs/gir/assignees{/user}","branches_url":"https://api.github.com/repos/gtk-rs/gir/branches{/branch}","tags_url":"https://api.github.com/repos/gtk-rs/gir/tags","blobs_url":"https://api.github.com/repos/gtk-rs/gir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gtk-rs/gir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gtk-rs/gir/git/refs{/sha}","trees_url":"https://api.github.com/repos/gtk-rs/gir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gtk-rs/gir/statuses/{sha}","languages_url":"https://api.github.com/repos/gtk-rs/gir/languages","stargazers_url":"https://api.github.com/repos/gtk-rs/gir/stargazers","contributors_url":"https://api.github.com/repos/gtk-rs/gir/contributors","subscribers_url":"https://api.github.com/repos/gtk-rs/gir/subscribers","subscription_url":"https://api.github.com/repos/gtk-rs/gir/subscription","commits_url":"https://api.github.com/repos/gtk-rs/gir/commits{/sha}","git_commits_url":"https://api.github.com/repos/gtk-rs/gir/git/commits{/sha}","comments_url":"https://api.github.com/repos/gtk-rs/gir/comments{/number}","issue_comment_url":"https://api.github.com/repos/gtk-rs/gir/issues/comments{/number}","contents_url":"https://api.github.com/repos/gtk-rs/gir/contents/{+path}","compare_url":"https://api.github.com/repos/gtk-rs/gir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gtk-rs/gir/merges","archive_url":"https://api.github.com/repos/gtk-rs/gir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gtk-rs/gir/downloads","issues_url":"https://api.github.com/repos/gtk-rs/gir/issues{/number}","pulls_url":"https://api.github.com/repos/gtk-rs/gir/pulls{/number}","milestones_url":"https://api.github.com/repos/gtk-rs/gir/milestones{/number}","notifications_url":"https://api.github.com/repos/gtk-rs/gir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gtk-rs/gir/labels{/name}","releases_url":"https://api.github.com/repos/gtk-rs/gir/releases{/id}","deployments_url":"https://api.github.com/repos/gtk-rs/gir/deployments","created_at":"2015-06-21T20:29:55Z","updated_at":"2016-01-14T12:15:50Z","pushed_at":"2016-02-04T18:02:55Z","git_url":"git://github.com/gtk-rs/gir.git","ssh_url":"git@github.com:gtk-rs/gir.git","clone_url":"https://github.com/gtk-rs/gir.git","svn_url":"https://github.com/gtk-rs/gir","homepage":null,"size":566,"stargazers_count":4,"watchers_count":4,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":19,"forks":4,"open_issues":19,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gtk-rs/gir/pulls/205"},"html":{"href":"https://github.com/gtk-rs/gir/pull/205"},"issue":{"href":"https://api.github.com/repos/gtk-rs/gir/issues/205"},"comments":{"href":"https://api.github.com/repos/gtk-rs/gir/issues/205/comments"},"review_comments":{"href":"https://api.github.com/repos/gtk-rs/gir/pulls/205/comments"},"review_comment":{"href":"https://api.github.com/repos/gtk-rs/gir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gtk-rs/gir/pulls/205/commits"},"statuses":{"href":"https://api.github.com/repos/gtk-rs/gir/statuses/4232e06c980c88797297de31b355fbe8eeab6374"}}}}