{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/cordova-simulate/issues/7","repository_url":"https://api.github.com/repos/Microsoft/cordova-simulate","labels_url":"https://api.github.com/repos/Microsoft/cordova-simulate/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/cordova-simulate/issues/7/comments","events_url":"https://api.github.com/repos/Microsoft/cordova-simulate/issues/7/events","html_url":"https://github.com/Microsoft/cordova-simulate/pull/7","id":142126540,"number":7,"title":"Updating geolocation and globalization plugins simulation support","user":{"login":"albertinad","id":2309921,"avatar_url":"https://avatars.githubusercontent.com/u/2309921?v=3","gravatar_id":"","url":"https://api.github.com/users/albertinad","html_url":"https://github.com/albertinad","followers_url":"https://api.github.com/users/albertinad/followers","following_url":"https://api.github.com/users/albertinad/following{/other_user}","gists_url":"https://api.github.com/users/albertinad/gists{/gist_id}","starred_url":"https://api.github.com/users/albertinad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertinad/subscriptions","organizations_url":"https://api.github.com/users/albertinad/orgs","repos_url":"https://api.github.com/users/albertinad/repos","events_url":"https://api.github.com/users/albertinad/events{/privacy}","received_events_url":"https://api.github.com/users/albertinad/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Microsoft/cordova-simulate/labels/cla-already-signed","name":"cla-already-signed","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-20T04:01:05Z","updated_at":"2016-05-09T20:18:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/cordova-simulate/pulls/7","html_url":"https://github.com/Microsoft/cordova-simulate/pull/7","diff_url":"https://github.com/Microsoft/cordova-simulate/pull/7.diff","patch_url":"https://github.com/Microsoft/cordova-simulate/pull/7.patch"},"body":"Hi @TimBarham , this PR is for updating the simulation support for geolocation and globalization support:\r\ngeolocation:\r\n- Updating `PositionError` object to include the error constants as part of the object instance (based on the plugin definition)\r\n\r\nglobalization:\r\n- Completing not supported functions by using accounting.js library\r\n- Returning formatting pattern when it is available\r\n- Updating `getFirstDayOfTheWeek` to return the index of the first day instead of the name, by following the plugin definition\r\n\r\nFor testing these changes, I've used the cordova mobilespec app with only the tests that are related to the geolocation and globalization plugins, see the results below:\r\n\r\nBefore these changes:\r\n\r\n![tests-before](https://cloud.githubusercontent.com/assets/2309921/13902775/fc773090-ee36-11e5-875a-800ae40ad417.png)\r\n*Specs: 56 - failures: 14*\r\n\r\nAfter these changes:\r\n\r\n![tests-after](https://cloud.githubusercontent.com/assets/2309921/13902776/0145aa5c-ee37-11e5-8467-3b08a39a7a30.png)\r\n*Specs: 56 - 0 failures*\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/Microsoft/cordova-simulate/issues/comments/217976973","html_url":"https://github.com/Microsoft/cordova-simulate/pull/7#issuecomment-217976973","issue_url":"https://api.github.com/repos/Microsoft/cordova-simulate/issues/7","id":217976973,"user":{"login":"guillaumejenkins","id":14299377,"avatar_url":"https://avatars.githubusercontent.com/u/14299377?v=3","gravatar_id":"","url":"https://api.github.com/users/guillaumejenkins","html_url":"https://github.com/guillaumejenkins","followers_url":"https://api.github.com/users/guillaumejenkins/followers","following_url":"https://api.github.com/users/guillaumejenkins/following{/other_user}","gists_url":"https://api.github.com/users/guillaumejenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/guillaumejenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guillaumejenkins/subscriptions","organizations_url":"https://api.github.com/users/guillaumejenkins/orgs","repos_url":"https://api.github.com/users/guillaumejenkins/repos","events_url":"https://api.github.com/users/guillaumejenkins/events{/privacy}","received_events_url":"https://api.github.com/users/guillaumejenkins/received_events","type":"User","site_admin":false},"created_at":"2016-05-09T20:18:36Z","updated_at":"2016-05-09T20:18:36Z","body":"Looks good to me as well"}}