{"action":"created","comment":{"url":"https://api.github.com/repos/twisted/twisted/pulls/comments/75803022","id":75803022,"diff_hunk":"@@ -326,26 +329,20 @@ def test_find_package_modules(self):\n                 \"twisted.test.mock_win32process\",\n                 ],\n             )\n-        # We are in _trial_temp which can be at PWD/_trial_temp when executed\n-        # outside of tox or some tox temporary folder.\n-        # When running under tox we use TOX_INI_DIR to find where the source\n-        # code is located.\n-        basePath = os.environ.get('PWD', '../')\n-        # Overwrite the path if we are running with tox.\n-        basePath = os.environ.get('TOX_INI_DIR', basePath)\n-        packageDir = os.path.join(basePath, 'src', 'twisted', 'test')\n+        twistedPackageDir = filepath.FilePath(twisted.__file__).parent()","path":"src/twisted/python/test/test_setup.py","position":35,"original_position":35,"commit_id":"655afddee4b22a163579d814d8e5e8e640a09ab1","original_commit_id":"655afddee4b22a163579d814d8e5e8e640a09ab1","user":{"login":"markrwilliams","id":704247,"avatar_url":"https://avatars.githubusercontent.com/u/704247?v=3","gravatar_id":"","url":"https://api.github.com/users/markrwilliams","html_url":"https://github.com/markrwilliams","followers_url":"https://api.github.com/users/markrwilliams/followers","following_url":"https://api.github.com/users/markrwilliams/following{/other_user}","gists_url":"https://api.github.com/users/markrwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/markrwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markrwilliams/subscriptions","organizations_url":"https://api.github.com/users/markrwilliams/orgs","repos_url":"https://api.github.com/users/markrwilliams/repos","events_url":"https://api.github.com/users/markrwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/markrwilliams/received_events","type":"User","site_admin":false},"body":"I thought we set `zip_safe=False` in setup.py?","created_at":"2016-08-23T05:03:33Z","updated_at":"2016-08-23T05:03:33Z","html_url":"https://github.com/twisted/twisted/pull/519#discussion_r75803022","pull_request_url":"https://api.github.com/repos/twisted/twisted/pulls/519","_links":{"self":{"href":"https://api.github.com/repos/twisted/twisted/pulls/comments/75803022"},"html":{"href":"https://github.com/twisted/twisted/pull/519#discussion_r75803022"},"pull_request":{"href":"https://api.github.com/repos/twisted/twisted/pulls/519"}}},"pull_request":{"url":"https://api.github.com/repos/twisted/twisted/pulls/519","id":82293430,"html_url":"https://github.com/twisted/twisted/pull/519","diff_url":"https://github.com/twisted/twisted/pull/519.diff","patch_url":"https://github.com/twisted/twisted/pull/519.patch","issue_url":"https://api.github.com/repos/twisted/twisted/issues/519","number":519,"state":"open","locked":false,"title":"8779 buildpy test dir and skip","user":{"login":"markrwilliams","id":704247,"avatar_url":"https://avatars.githubusercontent.com/u/704247?v=3","gravatar_id":"","url":"https://api.github.com/users/markrwilliams","html_url":"https://github.com/markrwilliams","followers_url":"https://api.github.com/users/markrwilliams/followers","following_url":"https://api.github.com/users/markrwilliams/following{/other_user}","gists_url":"https://api.github.com/users/markrwilliams/gists{/gist_id}","starred_url":"https://api.github.com/users/markrwilliams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markrwilliams/subscriptions","organizations_url":"https://api.github.com/users/markrwilliams/orgs","repos_url":"https://api.github.com/users/markrwilliams/repos","events_url":"https://api.github.com/users/markrwilliams/events{/privacy}","received_events_url":"https://api.github.com/users/markrwilliams/received_events","type":"User","site_admin":false},"body":"See https://twistedmatrix.com/trac/ticket/8779","created_at":"2016-08-23T02:15:54Z","updated_at":"2016-08-23T05:03:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73d6531d6a97e2fe5bb8001b20c4f16e404fbf69","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/twisted/twisted/pulls/519/commits","review_comments_url":"https://api.github.com/repos/twisted/twisted/pulls/519/comments","review_comment_url":"https://api.github.com/repos/twisted/twisted/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twisted/twisted/issues/519/comments","statuses_url":"https://api.github.com/repos/twisted/twisted/statuses/655afddee4b22a163579d814d8e5e8e640a09ab1","head":{"label":"twisted:8779-buildpy-test-dir-and-skip","ref":"8779-buildpy-test-dir-and-skip","sha":"655afddee4b22a163579d814d8e5e8e640a09ab1","user":{"login":"twisted","id":716546,"avatar_url":"https://avatars.githubusercontent.com/u/716546?v=3","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"repo":{"id":1985358,"name":"twisted","full_name":"twisted/twisted","owner":{"login":"twisted","id":716546,"avatar_url":"https://avatars.githubusercontent.com/u/716546?v=3","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twisted/twisted","description":"Event-driven networking engine written in Python.","fork":false,"url":"https://api.github.com/repos/twisted/twisted","forks_url":"https://api.github.com/repos/twisted/twisted/forks","keys_url":"https://api.github.com/repos/twisted/twisted/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twisted/twisted/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twisted/twisted/teams","hooks_url":"https://api.github.com/repos/twisted/twisted/hooks","issue_events_url":"https://api.github.com/repos/twisted/twisted/issues/events{/number}","events_url":"https://api.github.com/repos/twisted/twisted/events","assignees_url":"https://api.github.com/repos/twisted/twisted/assignees{/user}","branches_url":"https://api.github.com/repos/twisted/twisted/branches{/branch}","tags_url":"https://api.github.com/repos/twisted/twisted/tags","blobs_url":"https://api.github.com/repos/twisted/twisted/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twisted/twisted/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twisted/twisted/git/refs{/sha}","trees_url":"https://api.github.com/repos/twisted/twisted/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twisted/twisted/statuses/{sha}","languages_url":"https://api.github.com/repos/twisted/twisted/languages","stargazers_url":"https://api.github.com/repos/twisted/twisted/stargazers","contributors_url":"https://api.github.com/repos/twisted/twisted/contributors","subscribers_url":"https://api.github.com/repos/twisted/twisted/subscribers","subscription_url":"https://api.github.com/repos/twisted/twisted/subscription","commits_url":"https://api.github.com/repos/twisted/twisted/commits{/sha}","git_commits_url":"https://api.github.com/repos/twisted/twisted/git/commits{/sha}","comments_url":"https://api.github.com/repos/twisted/twisted/comments{/number}","issue_comment_url":"https://api.github.com/repos/twisted/twisted/issues/comments{/number}","contents_url":"https://api.github.com/repos/twisted/twisted/contents/{+path}","compare_url":"https://api.github.com/repos/twisted/twisted/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twisted/twisted/merges","archive_url":"https://api.github.com/repos/twisted/twisted/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twisted/twisted/downloads","issues_url":"https://api.github.com/repos/twisted/twisted/issues{/number}","pulls_url":"https://api.github.com/repos/twisted/twisted/pulls{/number}","milestones_url":"https://api.github.com/repos/twisted/twisted/milestones{/number}","notifications_url":"https://api.github.com/repos/twisted/twisted/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twisted/twisted/labels{/name}","releases_url":"https://api.github.com/repos/twisted/twisted/releases{/id}","deployments_url":"https://api.github.com/repos/twisted/twisted/deployments","created_at":"2011-07-01T20:40:42Z","updated_at":"2016-08-22T12:20:30Z","pushed_at":"2016-08-23T04:51:17Z","git_url":"git://github.com/twisted/twisted.git","ssh_url":"git@github.com:twisted/twisted.git","clone_url":"https://github.com/twisted/twisted.git","svn_url":"https://github.com/twisted/twisted","homepage":"https://www.twistedmatrix.com","size":86708,"stargazers_count":1435,"watchers_count":1435,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":450,"mirror_url":null,"open_issues_count":30,"forks":450,"open_issues":30,"watchers":1435,"default_branch":"trunk"}},"base":{"label":"twisted:trunk","ref":"trunk","sha":"defe32ce6ed4b89beb8bff10c465782019813d9b","user":{"login":"twisted","id":716546,"avatar_url":"https://avatars.githubusercontent.com/u/716546?v=3","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"repo":{"id":1985358,"name":"twisted","full_name":"twisted/twisted","owner":{"login":"twisted","id":716546,"avatar_url":"https://avatars.githubusercontent.com/u/716546?v=3","gravatar_id":"","url":"https://api.github.com/users/twisted","html_url":"https://github.com/twisted","followers_url":"https://api.github.com/users/twisted/followers","following_url":"https://api.github.com/users/twisted/following{/other_user}","gists_url":"https://api.github.com/users/twisted/gists{/gist_id}","starred_url":"https://api.github.com/users/twisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twisted/subscriptions","organizations_url":"https://api.github.com/users/twisted/orgs","repos_url":"https://api.github.com/users/twisted/repos","events_url":"https://api.github.com/users/twisted/events{/privacy}","received_events_url":"https://api.github.com/users/twisted/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twisted/twisted","description":"Event-driven networking engine written in Python.","fork":false,"url":"https://api.github.com/repos/twisted/twisted","forks_url":"https://api.github.com/repos/twisted/twisted/forks","keys_url":"https://api.github.com/repos/twisted/twisted/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twisted/twisted/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twisted/twisted/teams","hooks_url":"https://api.github.com/repos/twisted/twisted/hooks","issue_events_url":"https://api.github.com/repos/twisted/twisted/issues/events{/number}","events_url":"https://api.github.com/repos/twisted/twisted/events","assignees_url":"https://api.github.com/repos/twisted/twisted/assignees{/user}","branches_url":"https://api.github.com/repos/twisted/twisted/branches{/branch}","tags_url":"https://api.github.com/repos/twisted/twisted/tags","blobs_url":"https://api.github.com/repos/twisted/twisted/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twisted/twisted/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twisted/twisted/git/refs{/sha}","trees_url":"https://api.github.com/repos/twisted/twisted/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twisted/twisted/statuses/{sha}","languages_url":"https://api.github.com/repos/twisted/twisted/languages","stargazers_url":"https://api.github.com/repos/twisted/twisted/stargazers","contributors_url":"https://api.github.com/repos/twisted/twisted/contributors","subscribers_url":"https://api.github.com/repos/twisted/twisted/subscribers","subscription_url":"https://api.github.com/repos/twisted/twisted/subscription","commits_url":"https://api.github.com/repos/twisted/twisted/commits{/sha}","git_commits_url":"https://api.github.com/repos/twisted/twisted/git/commits{/sha}","comments_url":"https://api.github.com/repos/twisted/twisted/comments{/number}","issue_comment_url":"https://api.github.com/repos/twisted/twisted/issues/comments{/number}","contents_url":"https://api.github.com/repos/twisted/twisted/contents/{+path}","compare_url":"https://api.github.com/repos/twisted/twisted/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twisted/twisted/merges","archive_url":"https://api.github.com/repos/twisted/twisted/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twisted/twisted/downloads","issues_url":"https://api.github.com/repos/twisted/twisted/issues{/number}","pulls_url":"https://api.github.com/repos/twisted/twisted/pulls{/number}","milestones_url":"https://api.github.com/repos/twisted/twisted/milestones{/number}","notifications_url":"https://api.github.com/repos/twisted/twisted/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twisted/twisted/labels{/name}","releases_url":"https://api.github.com/repos/twisted/twisted/releases{/id}","deployments_url":"https://api.github.com/repos/twisted/twisted/deployments","created_at":"2011-07-01T20:40:42Z","updated_at":"2016-08-22T12:20:30Z","pushed_at":"2016-08-23T04:51:17Z","git_url":"git://github.com/twisted/twisted.git","ssh_url":"git@github.com:twisted/twisted.git","clone_url":"https://github.com/twisted/twisted.git","svn_url":"https://github.com/twisted/twisted","homepage":"https://www.twistedmatrix.com","size":86708,"stargazers_count":1435,"watchers_count":1435,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":450,"mirror_url":null,"open_issues_count":30,"forks":450,"open_issues":30,"watchers":1435,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/twisted/twisted/pulls/519"},"html":{"href":"https://github.com/twisted/twisted/pull/519"},"issue":{"href":"https://api.github.com/repos/twisted/twisted/issues/519"},"comments":{"href":"https://api.github.com/repos/twisted/twisted/issues/519/comments"},"review_comments":{"href":"https://api.github.com/repos/twisted/twisted/pulls/519/comments"},"review_comment":{"href":"https://api.github.com/repos/twisted/twisted/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twisted/twisted/pulls/519/commits"},"statuses":{"href":"https://api.github.com/repos/twisted/twisted/statuses/655afddee4b22a163579d814d8e5e8e640a09ab1"}}}}
{"actor":{"display_login":"markrwilliams"}}