{"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/60840781","id":60840781,"diff_hunk":"@@ -74,11 +75,47 @@ http://www.cockroachlabs.com/docs/\n `)\n }\n \n+// handleSet handles the \\set command and changes client-side flags.\n+func handleSet(cmd []string, confirm *bool) int {\n+\tif len(cmd) != 2 {\n+\t\tfmt.Fprintf(os.Stderr, \"Usage:\\n \\\\set <option>\\n\")\n+\t\treturn cliNextLine\n+\t}\n+\n+\tswitch cmd[1] {\n+\tcase `confirm`:\n+\t\t*confirm = true\n+\tcase `noconfirm`:\n+\t\t*confirm = false\n+\tdefault:\n+\t\tfmt.Fprintf(os.Stderr, \"unrecognized \\\\set option: %s\\n\", cmd[1])\n+\t}\n+\treturn cliNextLine\n+}\n+\n+// confirmStatement checks whether the statement string contains\n+// \"dangerous\" statements and asks a confirmation to the user if\n+// necessary.\n+func confirmStatement(confirm bool, stmt string) bool {\n+\tstmt = strings.ToUpper(stmt)\n+\tif confirm && (strings.Contains(stmt, \"DROP \")) {","path":"cli/sql.go","position":null,"original_position":41,"commit_id":"1a1d9a4bb65ee0875ba14b14dbacc1c57d523d85","original_commit_id":"c54ab5803edca43753604f5f69576b63ed1f171c","user":{"login":"knz","id":642886,"avatar_url":"https://avatars.githubusercontent.com/u/642886?v=3","gravatar_id":"","url":"https://api.github.com/users/knz","html_url":"https://github.com/knz","followers_url":"https://api.github.com/users/knz/followers","following_url":"https://api.github.com/users/knz/following{/other_user}","gists_url":"https://api.github.com/users/knz/gists{/gist_id}","starred_url":"https://api.github.com/users/knz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knz/subscriptions","organizations_url":"https://api.github.com/users/knz/orgs","repos_url":"https://api.github.com/users/knz/repos","events_url":"https://api.github.com/users/knz/events{/privacy}","received_events_url":"https://api.github.com/users/knz/received_events","type":"User","site_admin":false},"body":"Since you can disable the confirmation prompt with \"\\set confirm off\" I do not see the opportunity for excessive annoyance. I also just changed the code to use a more conservative regex, so there will be even less false positives.","created_at":"2016-04-24T08:13:31Z","updated_at":"2016-04-24T08:13:31Z","html_url":"https://github.com/cockroachdb/cockroach/pull/6257#discussion_r60840781","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6257","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/60840781"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/6257#discussion_r60840781"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6257"}}},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6257","id":67600733,"html_url":"https://github.com/cockroachdb/cockroach/pull/6257","diff_url":"https://github.com/cockroachdb/cockroach/pull/6257.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/6257.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6257","number":6257,"state":"open","locked":false,"title":"Ask for confirmation when using DROP in the CLI SQL client.","user":{"login":"knz","id":642886,"avatar_url":"https://avatars.githubusercontent.com/u/642886?v=3","gravatar_id":"","url":"https://api.github.com/users/knz","html_url":"https://github.com/knz","followers_url":"https://api.github.com/users/knz/followers","following_url":"https://api.github.com/users/knz/following{/other_user}","gists_url":"https://api.github.com/users/knz/gists{/gist_id}","starred_url":"https://api.github.com/users/knz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knz/subscriptions","organizations_url":"https://api.github.com/users/knz/orgs","repos_url":"https://api.github.com/users/knz/repos","events_url":"https://api.github.com/users/knz/events{/privacy}","received_events_url":"https://api.github.com/users/knz/received_events","type":"User","site_admin":false},"body":"Users who use the CLI SQL client to tinker / experiment are likely to\r\nmake mistakes, and may appreciate an extra confirmation before running\r\nDROP which could permanently destroy data.\r\n\r\nThis patch introduces such a check and confirmation for when\r\nstatements are entered from a terminal, ie. statements are not checked\r\nwhen entered via `sql -e` or read from a file using a redirection.\r\n\r\nAlso this patch introduces a new interactive command `\\set` to set\r\nclient-side flags. For now this is restricted to `\\set\r\nconfirm/noconfirm` to override the check & confirmation behavior.\r\n\r\nFixes #3943.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/6257)\n<!-- Reviewable:end -->\n","created_at":"2016-04-23T08:39:42Z","updated_at":"2016-04-24T08:13:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45ceb12fb284debbc508ca51faea03975816543f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6257/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6257/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/6257/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/1a1d9a4bb65ee0875ba14b14dbacc1c57d523d85","head":{"label":"knz:confirm-drop","ref":"confirm-drop","sha":"1a1d9a4bb65ee0875ba14b14dbacc1c57d523d85","user":{"login":"knz","id":642886,"avatar_url":"https://avatars.githubusercontent.com/u/642886?v=3","gravatar_id":"","url":"https://api.github.com/users/knz","html_url":"https://github.com/knz","followers_url":"https://api.github.com/users/knz/followers","following_url":"https://api.github.com/users/knz/following{/other_user}","gists_url":"https://api.github.com/users/knz/gists{/gist_id}","starred_url":"https://api.github.com/users/knz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knz/subscriptions","organizations_url":"https://api.github.com/users/knz/orgs","repos_url":"https://api.github.com/users/knz/repos","events_url":"https://api.github.com/users/knz/events{/privacy}","received_events_url":"https://api.github.com/users/knz/received_events","type":"User","site_admin":false},"repo":{"id":49441405,"name":"cockroach","full_name":"knz/cockroach","owner":{"login":"knz","id":642886,"avatar_url":"https://avatars.githubusercontent.com/u/642886?v=3","gravatar_id":"","url":"https://api.github.com/users/knz","html_url":"https://github.com/knz","followers_url":"https://api.github.com/users/knz/followers","following_url":"https://api.github.com/users/knz/following{/other_user}","gists_url":"https://api.github.com/users/knz/gists{/gist_id}","starred_url":"https://api.github.com/users/knz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knz/subscriptions","organizations_url":"https://api.github.com/users/knz/orgs","repos_url":"https://api.github.com/users/knz/repos","events_url":"https://api.github.com/users/knz/events{/privacy}","received_events_url":"https://api.github.com/users/knz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/knz/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":true,"url":"https://api.github.com/repos/knz/cockroach","forks_url":"https://api.github.com/repos/knz/cockroach/forks","keys_url":"https://api.github.com/repos/knz/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knz/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knz/cockroach/teams","hooks_url":"https://api.github.com/repos/knz/cockroach/hooks","issue_events_url":"https://api.github.com/repos/knz/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/knz/cockroach/events","assignees_url":"https://api.github.com/repos/knz/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/knz/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/knz/cockroach/tags","blobs_url":"https://api.github.com/repos/knz/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knz/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knz/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/knz/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knz/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/knz/cockroach/languages","stargazers_url":"https://api.github.com/repos/knz/cockroach/stargazers","contributors_url":"https://api.github.com/repos/knz/cockroach/contributors","subscribers_url":"https://api.github.com/repos/knz/cockroach/subscribers","subscription_url":"https://api.github.com/repos/knz/cockroach/subscription","commits_url":"https://api.github.com/repos/knz/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/knz/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/knz/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/knz/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/knz/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/knz/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knz/cockroach/merges","archive_url":"https://api.github.com/repos/knz/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knz/cockroach/downloads","issues_url":"https://api.github.com/repos/knz/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/knz/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/knz/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/knz/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knz/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/knz/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/knz/cockroach/deployments","created_at":"2016-01-11T17:11:07Z","updated_at":"2016-01-11T17:11:10Z","pushed_at":"2016-04-24T08:13:20Z","git_url":"git://github.com/knz/cockroach.git","ssh_url":"git@github.com:knz/cockroach.git","clone_url":"https://github.com/knz/cockroach.git","svn_url":"https://github.com/knz/cockroach","homepage":"http://www.cockroachlabs.com","size":152779,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"fbb1243f55df4aa02f59c57d4133ec85460748e7","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2016-04-24T07:17:42Z","pushed_at":"2016-04-24T08:13:24Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":198421,"stargazers_count":6741,"watchers_count":6741,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":641,"mirror_url":null,"open_issues_count":417,"forks":641,"open_issues":417,"watchers":6741,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6257"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/6257"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/6257"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/6257/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6257/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/6257/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/1a1d9a4bb65ee0875ba14b14dbacc1c57d523d85"}}}}