{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/pulls/comments/69603355","id":69603355,"diff_hunk":"@@ -32,14 +32,25 @@\n public interface AppDeployer {\n \n \t/**\n+\t * Common prefix used for deployment properties.\n+\t */\n+\tstatic final String PREFIX = \"spring.cloud.deployer.\";\n+\n+\t/**\n \t * The deployment property for the count (number of app instances).\n \t */\n-\tpublic static String COUNT_PROPERTY_KEY = \"spring.cloud.deployer.count\";\n+\tstatic final String COUNT_PROPERTY_KEY = PREFIX + \"count\";\n \n \t/**\n \t * The deployment property for the group to which an app belongs.\n \t */\n-\tpublic static String GROUP_PROPERTY_KEY = \"spring.cloud.deployer.group\";\n+\tstatic final String GROUP_PROPERTY_KEY = PREFIX + \"group\";\n+\n+\t/**\n+\t * The deployment property that indicates if each app instance should have an index value\n+\t * within a sequence from 0 to {@value #COUNT_PROPERTY_KEY} - 1.","path":"spring-cloud-deployer-spi/src/main/java/org/springframework/cloud/deployer/spi/app/AppDeployer.java","position":22,"original_position":22,"commit_id":"3262ea65ea996dc2c1ee9ca21c10296c2a568573","original_commit_id":"3262ea65ea996dc2c1ee9ca21c10296c2a568573","user":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"body":"May be we can say `number of app instances (specified via the property {@value #COUNT_PROPERTY_KEY}) - 1`","created_at":"2016-07-05T17:24:25Z","updated_at":"2016-07-05T17:24:25Z","html_url":"https://github.com/spring-cloud/spring-cloud-deployer/pull/88#discussion_r69603355","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/pulls/88","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/pulls/comments/69603355"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-deployer/pull/88#discussion_r69603355"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/pulls/88","id":76309737,"html_url":"https://github.com/spring-cloud/spring-cloud-deployer/pull/88","diff_url":"https://github.com/spring-cloud/spring-cloud-deployer/pull/88.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-deployer/pull/88.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/issues/88","number":88,"state":"open","locked":false,"title":"added indexed property (for app instances)","user":{"login":"markfisher","id":140784,"avatar_url":"https://avatars.githubusercontent.com/u/140784?v=3","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"body":"resolves #87 ","created_at":"2016-07-05T17:12:51Z","updated_at":"2016-07-05T17:24:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a547fee3364b4dacdb02c093b3385f276abd2431","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/pulls/88/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/pulls/88/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/issues/88/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/statuses/3262ea65ea996dc2c1ee9ca21c10296c2a568573","head":{"label":"markfisher:gh87","ref":"gh87","sha":"3262ea65ea996dc2c1ee9ca21c10296c2a568573","user":{"login":"markfisher","id":140784,"avatar_url":"https://avatars.githubusercontent.com/u/140784?v=3","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"repo":{"id":52805227,"name":"spring-cloud-deployer","full_name":"markfisher/spring-cloud-deployer","owner":{"login":"markfisher","id":140784,"avatar_url":"https://avatars.githubusercontent.com/u/140784?v=3","gravatar_id":"","url":"https://api.github.com/users/markfisher","html_url":"https://github.com/markfisher","followers_url":"https://api.github.com/users/markfisher/followers","following_url":"https://api.github.com/users/markfisher/following{/other_user}","gists_url":"https://api.github.com/users/markfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/markfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markfisher/subscriptions","organizations_url":"https://api.github.com/users/markfisher/orgs","repos_url":"https://api.github.com/users/markfisher/repos","events_url":"https://api.github.com/users/markfisher/events{/privacy}","received_events_url":"https://api.github.com/users/markfisher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markfisher/spring-cloud-deployer","description":"","fork":true,"url":"https://api.github.com/repos/markfisher/spring-cloud-deployer","forks_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/forks","keys_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/teams","hooks_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/hooks","issue_events_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/issues/events{/number}","events_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/events","assignees_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/assignees{/user}","branches_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/branches{/branch}","tags_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/tags","blobs_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/git/refs{/sha}","trees_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/statuses/{sha}","languages_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/languages","stargazers_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/stargazers","contributors_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/contributors","subscribers_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/subscribers","subscription_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/subscription","commits_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/commits{/sha}","git_commits_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/git/commits{/sha}","comments_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/comments{/number}","issue_comment_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/issues/comments{/number}","contents_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/contents/{+path}","compare_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/merges","archive_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/downloads","issues_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/issues{/number}","pulls_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/pulls{/number}","milestones_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/milestones{/number}","notifications_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/labels{/name}","releases_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/releases{/id}","deployments_url":"https://api.github.com/repos/markfisher/spring-cloud-deployer/deployments","created_at":"2016-02-29T16:20:38Z","updated_at":"2016-02-29T16:20:39Z","pushed_at":"2016-07-05T17:06:43Z","git_url":"git://github.com/markfisher/spring-cloud-deployer.git","ssh_url":"git@github.com:markfisher/spring-cloud-deployer.git","clone_url":"https://github.com/markfisher/spring-cloud-deployer.git","svn_url":"https://github.com/markfisher/spring-cloud-deployer","homepage":null,"size":302,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"cba875b243c9feff86f0176a117f852ed1600343","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":52803867,"name":"spring-cloud-deployer","full_name":"spring-cloud/spring-cloud-deployer","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-deployer","description":"The Spring Cloud Deployer project defines an SPI for deploying long lived applications and short lived tasks","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/deployments","created_at":"2016-02-29T16:00:00Z","updated_at":"2016-05-29T14:16:53Z","pushed_at":"2016-07-05T17:12:51Z","git_url":"git://github.com/spring-cloud/spring-cloud-deployer.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-deployer.git","clone_url":"https://github.com/spring-cloud/spring-cloud-deployer.git","svn_url":"https://github.com/spring-cloud/spring-cloud-deployer","homepage":"","size":342,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":19,"forks":14,"open_issues":19,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/pulls/88"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-deployer/pull/88"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/issues/88"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-deployer/statuses/3262ea65ea996dc2c1ee9ca21c10296c2a568573"}}}}
{"actor":{"display_login":"ilayaperumalg"}}