{"action":"created","issue":{"url":"https://api.github.com/repos/flexible-collision-library/fcl/issues/110","repository_url":"https://api.github.com/repos/flexible-collision-library/fcl","labels_url":"https://api.github.com/repos/flexible-collision-library/fcl/issues/110/labels{/name}","comments_url":"https://api.github.com/repos/flexible-collision-library/fcl/issues/110/comments","events_url":"https://api.github.com/repos/flexible-collision-library/fcl/issues/110/events","html_url":"https://github.com/flexible-collision-library/fcl/pull/110","id":143880311,"number":110,"title":"Fixes a nasty bug in propagateBVHFrontListCollisionRecurse()","user":{"login":"sherm1","id":4088016,"avatar_url":"https://avatars.githubusercontent.com/u/4088016?v=3","gravatar_id":"","url":"https://api.github.com/users/sherm1","html_url":"https://github.com/sherm1","followers_url":"https://api.github.com/users/sherm1/followers","following_url":"https://api.github.com/users/sherm1/following{/other_user}","gists_url":"https://api.github.com/users/sherm1/gists{/gist_id}","starred_url":"https://api.github.com/users/sherm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherm1/subscriptions","organizations_url":"https://api.github.com/users/sherm1/orgs","repos_url":"https://api.github.com/users/sherm1/repos","events_url":"https://api.github.com/users/sherm1/events{/privacy}","received_events_url":"https://api.github.com/users/sherm1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-28T03:01:24Z","updated_at":"2016-03-28T03:05:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/flexible-collision-library/fcl/pulls/110","html_url":"https://github.com/flexible-collision-library/fcl/pull/110","diff_url":"https://github.com/flexible-collision-library/fcl/pull/110.diff","patch_url":"https://github.com/flexible-collision-library/fcl/pull/110.patch"},"body":"This was causing `test_fcl_frontlist` to seg fault on Windows. The bug is platform independent though so it definitely wasn't working right anywhere. Windows happened to access unreadable memory; probably it picked up garbage elsewhere. Apparently the test case isn't too fussy!\r\n\r\nAlso did some minor code cleanup (std::fabs -> std::abs, fix a typo).\r\n\r\n@panjia1983, do you know how the test case could be improved so that it would have noticed this?"},"comment":{"url":"https://api.github.com/repos/flexible-collision-library/fcl/issues/comments/202211680","html_url":"https://github.com/flexible-collision-library/fcl/pull/110#issuecomment-202211680","issue_url":"https://api.github.com/repos/flexible-collision-library/fcl/issues/110","id":202211680,"user":{"login":"sherm1","id":4088016,"avatar_url":"https://avatars.githubusercontent.com/u/4088016?v=3","gravatar_id":"","url":"https://api.github.com/users/sherm1","html_url":"https://github.com/sherm1","followers_url":"https://api.github.com/users/sherm1/followers","following_url":"https://api.github.com/users/sherm1/following{/other_user}","gists_url":"https://api.github.com/users/sherm1/gists{/gist_id}","starred_url":"https://api.github.com/users/sherm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherm1/subscriptions","organizations_url":"https://api.github.com/users/sherm1/orgs","repos_url":"https://api.github.com/users/sherm1/repos","events_url":"https://api.github.com/users/sherm1/events{/privacy}","received_events_url":"https://api.github.com/users/sherm1/received_events","type":"User","site_admin":false},"created_at":"2016-03-28T03:05:29Z","updated_at":"2016-03-28T03:05:29Z","body":"With this merged there are only two remaining test failures on windows:\r\n- test_fcl_geometric_shapes has a tolerance issue (changing a 1e-5 to 1e-4 makes it pass)\r\n- test_fcl_broadphase fails (no diagnosis yet)"}}