{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/verify-frontend/pulls/comments/58368927","id":58368927,"diff_hunk":"@@ -22,7 +22,8 @@\n                                    type: \"submit\",\n                                    value: identity_provider.display_name\n                     %>\n-                    <input name=\"selected-idp\" type=\"hidden\" value=\"<%= identity_provider.entity_id %>\" />\n+                    <input name=\"selected-idp-entity-id\" type=\"hidden\" value=\"<%= identity_provider.entity_id %>\" />\n+                    <input name=\"selected-idp-display-name\" type=\"hidden\" value=\"<%= identity_provider.display_name %>\" />","path":"app/views/sign_in/index.html.erb","position":6,"original_position":6,"commit_id":"be81635aff1c7b1eaa218092e8037e7b5e979a0a","original_commit_id":"be81635aff1c7b1eaa218092e8037e7b5e979a0a","user":{"login":"chrisholmes","id":799295,"avatar_url":"https://avatars.githubusercontent.com/u/799295?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisholmes","html_url":"https://github.com/chrisholmes","followers_url":"https://api.github.com/users/chrisholmes/followers","following_url":"https://api.github.com/users/chrisholmes/following{/other_user}","gists_url":"https://api.github.com/users/chrisholmes/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisholmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisholmes/subscriptions","organizations_url":"https://api.github.com/users/chrisholmes/orgs","repos_url":"https://api.github.com/users/chrisholmes/repos","events_url":"https://api.github.com/users/chrisholmes/events{/privacy}","received_events_url":"https://api.github.com/users/chrisholmes/received_events","type":"User","site_admin":false},"body":"Can we replace these with a hidden_field_tag?","created_at":"2016-04-04T12:40:10Z","updated_at":"2016-04-04T12:40:10Z","html_url":"https://github.com/alphagov/verify-frontend/pull/43#discussion_r58368927","pull_request_url":"https://api.github.com/repos/alphagov/verify-frontend/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/alphagov/verify-frontend/pulls/comments/58368927"},"html":{"href":"https://github.com/alphagov/verify-frontend/pull/43#discussion_r58368927"},"pull_request":{"href":"https://api.github.com/repos/alphagov/verify-frontend/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/verify-frontend/pulls/43","id":65127650,"html_url":"https://github.com/alphagov/verify-frontend/pull/43","diff_url":"https://github.com/alphagov/verify-frontend/pull/43.diff","patch_url":"https://github.com/alphagov/verify-frontend/pull/43.patch","issue_url":"https://api.github.com/repos/alphagov/verify-frontend/issues/43","number":43,"state":"open","locked":false,"title":"3495 report custom variables with friendly names","user":{"login":"lloydnye","id":11163083,"avatar_url":"https://avatars.githubusercontent.com/u/11163083?v=3","gravatar_id":"","url":"https://api.github.com/users/lloydnye","html_url":"https://github.com/lloydnye","followers_url":"https://api.github.com/users/lloydnye/followers","following_url":"https://api.github.com/users/lloydnye/following{/other_user}","gists_url":"https://api.github.com/users/lloydnye/gists{/gist_id}","starred_url":"https://api.github.com/users/lloydnye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lloydnye/subscriptions","organizations_url":"https://api.github.com/users/lloydnye/orgs","repos_url":"https://api.github.com/users/lloydnye/repos","events_url":"https://api.github.com/users/lloydnye/events{/privacy}","received_events_url":"https://api.github.com/users/lloydnye/received_events","type":"User","site_admin":false},"body":"Adds friendly names when reporting custom variables. \r\n\r\nWork was paired, but have since rebased solo to include latest master changes, hence PR. ","created_at":"2016-04-04T11:02:22Z","updated_at":"2016-04-04T12:40:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86631ef9f73b20070cf08539adcb43332b542fe9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/verify-frontend/pulls/43/commits","review_comments_url":"https://api.github.com/repos/alphagov/verify-frontend/pulls/43/comments","review_comment_url":"https://api.github.com/repos/alphagov/verify-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/verify-frontend/issues/43/comments","statuses_url":"https://api.github.com/repos/alphagov/verify-frontend/statuses/be81635aff1c7b1eaa218092e8037e7b5e979a0a","head":{"label":"alphagov:3495-report-custom-variables-with-friendly-names","ref":"3495-report-custom-variables-with-friendly-names","sha":"be81635aff1c7b1eaa218092e8037e7b5e979a0a","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":51139585,"name":"verify-frontend","full_name":"alphagov/verify-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/verify-frontend","description":"A new frontend for GOV.UK Verify","fork":false,"url":"https://api.github.com/repos/alphagov/verify-frontend","forks_url":"https://api.github.com/repos/alphagov/verify-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/verify-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/verify-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/verify-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/verify-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/verify-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/verify-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/verify-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/verify-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/verify-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/verify-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/verify-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/verify-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/verify-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/verify-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/verify-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/verify-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/verify-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/verify-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/verify-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/verify-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/verify-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/verify-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/verify-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/verify-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/verify-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/verify-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/verify-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/verify-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/verify-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/verify-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/verify-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/verify-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/verify-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/verify-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/verify-frontend/deployments","created_at":"2016-02-05T10:13:50Z","updated_at":"2016-03-23T05:43:34Z","pushed_at":"2016-04-04T11:27:44Z","git_url":"git://github.com/alphagov/verify-frontend.git","ssh_url":"git@github.com:alphagov/verify-frontend.git","clone_url":"https://github.com/alphagov/verify-frontend.git","svn_url":"https://github.com/alphagov/verify-frontend","homepage":null,"size":576,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":5,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"c21bcb7d5ab6dadfcdb6c344873aa0bdb1bad5e1","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":51139585,"name":"verify-frontend","full_name":"alphagov/verify-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/verify-frontend","description":"A new frontend for GOV.UK Verify","fork":false,"url":"https://api.github.com/repos/alphagov/verify-frontend","forks_url":"https://api.github.com/repos/alphagov/verify-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/verify-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/verify-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/verify-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/verify-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/verify-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/verify-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/verify-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/verify-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/verify-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/verify-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/verify-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/verify-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/verify-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/verify-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/verify-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/verify-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/verify-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/verify-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/verify-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/verify-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/verify-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/verify-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/verify-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/verify-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/verify-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/verify-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/verify-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/verify-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/verify-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/verify-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/verify-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/verify-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/verify-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/verify-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/verify-frontend/deployments","created_at":"2016-02-05T10:13:50Z","updated_at":"2016-03-23T05:43:34Z","pushed_at":"2016-04-04T11:27:44Z","git_url":"git://github.com/alphagov/verify-frontend.git","ssh_url":"git@github.com:alphagov/verify-frontend.git","clone_url":"https://github.com/alphagov/verify-frontend.git","svn_url":"https://github.com/alphagov/verify-frontend","homepage":null,"size":576,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/verify-frontend/pulls/43"},"html":{"href":"https://github.com/alphagov/verify-frontend/pull/43"},"issue":{"href":"https://api.github.com/repos/alphagov/verify-frontend/issues/43"},"comments":{"href":"https://api.github.com/repos/alphagov/verify-frontend/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/verify-frontend/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/verify-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/verify-frontend/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/verify-frontend/statuses/be81635aff1c7b1eaa218092e8037e7b5e979a0a"}}}}