{"action":"created","comment":{"url":"https://api.github.com/repos/CUBRID/cubrid-testtools/pulls/comments/83359277","pull_request_review_id":4208529,"id":83359277,"diff_hunk":"@@ -282,22 +280,22 @@ public boolean needCleanTestCase()\n \t\n \tpublic String getTestCaseTimeout()\n \t{\n-\t\treturn getProperty(\"main.testcase.timeout\", \"-1\");\n+\t\treturn getProperty(ConfigParameterConstants.TESTCASE_TIMEOUT_IN_SECS, \"-1\");\n \t}\n \t\n \tpublic boolean needEnableMonitorTrace()\n \t{\n-\t\treturn com.navercorp.cubridqa.common.CommonUtils.convertBoolean(getProperty(\"main.monitor.enable_tracing\", \"false\"));\n+\t\treturn com.navercorp.cubridqa.common.CommonUtils.convertBoolean(getProperty(ConfigParameterConstants.ENABLE_STATUS_TRACE_YES_OR_NO, \"false\"));\n \t}\n \t\n \tpublic String getExcludedCoresByAssertLine()\n \t{\n-\t\treturn getProperty(\"main.testing.excluded_cores_by_assert_line\");\n+\t\treturn getProperty(ConfigParameterConstants.IGNORE_CORE_BY_KEYWORDS);\n \t}\n \t\n \tpublic boolean needDeleteTestCaseAfterTest()\n \t{\n-\t\treturn getProperty(\"main.testing.delete_test_case_after_execution\", \"false\").trim().toLowerCase().equals(\"true\");\n+\t\treturn getProperty(ConfigParameterConstants.DELETE_TESTCASE_AFTER_EACH_EXECUTION_YES_OR_NO, \"false\").trim().toLowerCase().equals(\"true\");","path":"CTP/shell/src/com/navercorp/cubridqa/shell/main/Context.java","position":160,"original_position":160,"commit_id":"ca70c44e56a5da7222ed4627bcd8f35dc184dded","original_commit_id":"ca70c44e56a5da7222ed4627bcd8f35dc184dded","user":{"login":"fanzaiqiang","id":17305252,"avatar_url":"https://avatars.githubusercontent.com/u/17305252?v=3","gravatar_id":"","url":"https://api.github.com/users/fanzaiqiang","html_url":"https://github.com/fanzaiqiang","followers_url":"https://api.github.com/users/fanzaiqiang/followers","following_url":"https://api.github.com/users/fanzaiqiang/following{/other_user}","gists_url":"https://api.github.com/users/fanzaiqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/fanzaiqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanzaiqiang/subscriptions","organizations_url":"https://api.github.com/users/fanzaiqiang/orgs","repos_url":"https://api.github.com/users/fanzaiqiang/repos","events_url":"https://api.github.com/users/fanzaiqiang/events{/privacy}","received_events_url":"https://api.github.com/users/fanzaiqiang/received_events","type":"User","site_admin":false},"body":"Please use convertBoolean to convert ConfigParameterConstants.DELETE_TESTCASE_AFTER_EACH_EXECUTION_YES_OR_NO","created_at":"2016-10-14T05:20:13Z","updated_at":"2016-10-14T05:26:40Z","html_url":"https://github.com/CUBRID/cubrid-testtools/pull/239#discussion_r83359277","pull_request_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/pulls/239","_links":{"self":{"href":"https://api.github.com/repos/CUBRID/cubrid-testtools/pulls/comments/83359277"},"html":{"href":"https://github.com/CUBRID/cubrid-testtools/pull/239#discussion_r83359277"},"pull_request":{"href":"https://api.github.com/repos/CUBRID/cubrid-testtools/pulls/239"}}},"pull_request":{"url":"https://api.github.com/repos/CUBRID/cubrid-testtools/pulls/239","id":88975069,"html_url":"https://github.com/CUBRID/cubrid-testtools/pull/239","diff_url":"https://github.com/CUBRID/cubrid-testtools/pull/239.diff","patch_url":"https://github.com/CUBRID/cubrid-testtools/pull/239.patch","issue_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/issues/239","number":239,"state":"open","locked":false,"title":"[CUBRIDQA-70] refine all parameter for CTP shell component","user":{"login":"supler","id":17423117,"avatar_url":"https://avatars.githubusercontent.com/u/17423117?v=3","gravatar_id":"","url":"https://api.github.com/users/supler","html_url":"https://github.com/supler","followers_url":"https://api.github.com/users/supler/followers","following_url":"https://api.github.com/users/supler/following{/other_user}","gists_url":"https://api.github.com/users/supler/gists{/gist_id}","starred_url":"https://api.github.com/users/supler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supler/subscriptions","organizations_url":"https://api.github.com/users/supler/orgs","repos_url":"https://api.github.com/users/supler/repos","events_url":"https://api.github.com/users/supler/events{/privacy}","received_events_url":"https://api.github.com/users/supler/received_events","type":"User","site_admin":false},"body":"@fanzaiqiang \r\n\r\nI updated codes according to the rule of CUBRIDQA-70, please review it. thanks\r\n\r\nNote: \r\nJust do parameter enhancement, I didn't do refactor for some parameters initialization\r\n\r\n\r\n","created_at":"2016-10-12T08:42:24Z","updated_at":"2016-10-14T05:26:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e93036246ce1e5e885c039618c9c8542da1e874d","assignee":{"login":"fanzaiqiang","id":17305252,"avatar_url":"https://avatars.githubusercontent.com/u/17305252?v=3","gravatar_id":"","url":"https://api.github.com/users/fanzaiqiang","html_url":"https://github.com/fanzaiqiang","followers_url":"https://api.github.com/users/fanzaiqiang/followers","following_url":"https://api.github.com/users/fanzaiqiang/following{/other_user}","gists_url":"https://api.github.com/users/fanzaiqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/fanzaiqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanzaiqiang/subscriptions","organizations_url":"https://api.github.com/users/fanzaiqiang/orgs","repos_url":"https://api.github.com/users/fanzaiqiang/repos","events_url":"https://api.github.com/users/fanzaiqiang/events{/privacy}","received_events_url":"https://api.github.com/users/fanzaiqiang/received_events","type":"User","site_admin":false},"assignees":[{"login":"fanzaiqiang","id":17305252,"avatar_url":"https://avatars.githubusercontent.com/u/17305252?v=3","gravatar_id":"","url":"https://api.github.com/users/fanzaiqiang","html_url":"https://github.com/fanzaiqiang","followers_url":"https://api.github.com/users/fanzaiqiang/followers","following_url":"https://api.github.com/users/fanzaiqiang/following{/other_user}","gists_url":"https://api.github.com/users/fanzaiqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/fanzaiqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanzaiqiang/subscriptions","organizations_url":"https://api.github.com/users/fanzaiqiang/orgs","repos_url":"https://api.github.com/users/fanzaiqiang/repos","events_url":"https://api.github.com/users/fanzaiqiang/events{/privacy}","received_events_url":"https://api.github.com/users/fanzaiqiang/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/pulls/239/commits","review_comments_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/pulls/239/comments","review_comment_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/issues/239/comments","statuses_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/statuses/ca70c44e56a5da7222ed4627bcd8f35dc184dded","head":{"label":"supler:refine_ctp_parameters_v1","ref":"refine_ctp_parameters_v1","sha":"ca70c44e56a5da7222ed4627bcd8f35dc184dded","user":{"login":"supler","id":17423117,"avatar_url":"https://avatars.githubusercontent.com/u/17423117?v=3","gravatar_id":"","url":"https://api.github.com/users/supler","html_url":"https://github.com/supler","followers_url":"https://api.github.com/users/supler/followers","following_url":"https://api.github.com/users/supler/following{/other_user}","gists_url":"https://api.github.com/users/supler/gists{/gist_id}","starred_url":"https://api.github.com/users/supler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supler/subscriptions","organizations_url":"https://api.github.com/users/supler/orgs","repos_url":"https://api.github.com/users/supler/repos","events_url":"https://api.github.com/users/supler/events{/privacy}","received_events_url":"https://api.github.com/users/supler/received_events","type":"User","site_admin":false},"repo":{"id":54935763,"name":"cubrid-testtools","full_name":"supler/cubrid-testtools","owner":{"login":"supler","id":17423117,"avatar_url":"https://avatars.githubusercontent.com/u/17423117?v=3","gravatar_id":"","url":"https://api.github.com/users/supler","html_url":"https://github.com/supler","followers_url":"https://api.github.com/users/supler/followers","following_url":"https://api.github.com/users/supler/following{/other_user}","gists_url":"https://api.github.com/users/supler/gists{/gist_id}","starred_url":"https://api.github.com/users/supler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supler/subscriptions","organizations_url":"https://api.github.com/users/supler/orgs","repos_url":"https://api.github.com/users/supler/repos","events_url":"https://api.github.com/users/supler/events{/privacy}","received_events_url":"https://api.github.com/users/supler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/supler/cubrid-testtools","description":"Scripts and utilities that automated testing for CUBRID QA","fork":true,"url":"https://api.github.com/repos/supler/cubrid-testtools","forks_url":"https://api.github.com/repos/supler/cubrid-testtools/forks","keys_url":"https://api.github.com/repos/supler/cubrid-testtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/supler/cubrid-testtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/supler/cubrid-testtools/teams","hooks_url":"https://api.github.com/repos/supler/cubrid-testtools/hooks","issue_events_url":"https://api.github.com/repos/supler/cubrid-testtools/issues/events{/number}","events_url":"https://api.github.com/repos/supler/cubrid-testtools/events","assignees_url":"https://api.github.com/repos/supler/cubrid-testtools/assignees{/user}","branches_url":"https://api.github.com/repos/supler/cubrid-testtools/branches{/branch}","tags_url":"https://api.github.com/repos/supler/cubrid-testtools/tags","blobs_url":"https://api.github.com/repos/supler/cubrid-testtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/supler/cubrid-testtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/supler/cubrid-testtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/supler/cubrid-testtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/supler/cubrid-testtools/statuses/{sha}","languages_url":"https://api.github.com/repos/supler/cubrid-testtools/languages","stargazers_url":"https://api.github.com/repos/supler/cubrid-testtools/stargazers","contributors_url":"https://api.github.com/repos/supler/cubrid-testtools/contributors","subscribers_url":"https://api.github.com/repos/supler/cubrid-testtools/subscribers","subscription_url":"https://api.github.com/repos/supler/cubrid-testtools/subscription","commits_url":"https://api.github.com/repos/supler/cubrid-testtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/supler/cubrid-testtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/supler/cubrid-testtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/supler/cubrid-testtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/supler/cubrid-testtools/contents/{+path}","compare_url":"https://api.github.com/repos/supler/cubrid-testtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/supler/cubrid-testtools/merges","archive_url":"https://api.github.com/repos/supler/cubrid-testtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/supler/cubrid-testtools/downloads","issues_url":"https://api.github.com/repos/supler/cubrid-testtools/issues{/number}","pulls_url":"https://api.github.com/repos/supler/cubrid-testtools/pulls{/number}","milestones_url":"https://api.github.com/repos/supler/cubrid-testtools/milestones{/number}","notifications_url":"https://api.github.com/repos/supler/cubrid-testtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/supler/cubrid-testtools/labels{/name}","releases_url":"https://api.github.com/repos/supler/cubrid-testtools/releases{/id}","deployments_url":"https://api.github.com/repos/supler/cubrid-testtools/deployments","created_at":"2016-03-29T01:21:59Z","updated_at":"2016-03-29T01:22:03Z","pushed_at":"2016-10-14T03:47:06Z","git_url":"git://github.com/supler/cubrid-testtools.git","ssh_url":"git@github.com:supler/cubrid-testtools.git","clone_url":"https://github.com/supler/cubrid-testtools.git","svn_url":"https://github.com/supler/cubrid-testtools","homepage":null,"size":17969,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CUBRID:refine_ctp_parameters","ref":"refine_ctp_parameters","sha":"98f62131e7e5e1fe874e19fedd19cc84cbde3e8f","user":{"login":"CUBRID","id":358322,"avatar_url":"https://avatars.githubusercontent.com/u/358322?v=3","gravatar_id":"","url":"https://api.github.com/users/CUBRID","html_url":"https://github.com/CUBRID","followers_url":"https://api.github.com/users/CUBRID/followers","following_url":"https://api.github.com/users/CUBRID/following{/other_user}","gists_url":"https://api.github.com/users/CUBRID/gists{/gist_id}","starred_url":"https://api.github.com/users/CUBRID/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CUBRID/subscriptions","organizations_url":"https://api.github.com/users/CUBRID/orgs","repos_url":"https://api.github.com/users/CUBRID/repos","events_url":"https://api.github.com/users/CUBRID/events{/privacy}","received_events_url":"https://api.github.com/users/CUBRID/received_events","type":"Organization","site_admin":false},"repo":{"id":52327283,"name":"cubrid-testtools","full_name":"CUBRID/cubrid-testtools","owner":{"login":"CUBRID","id":358322,"avatar_url":"https://avatars.githubusercontent.com/u/358322?v=3","gravatar_id":"","url":"https://api.github.com/users/CUBRID","html_url":"https://github.com/CUBRID","followers_url":"https://api.github.com/users/CUBRID/followers","following_url":"https://api.github.com/users/CUBRID/following{/other_user}","gists_url":"https://api.github.com/users/CUBRID/gists{/gist_id}","starred_url":"https://api.github.com/users/CUBRID/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CUBRID/subscriptions","organizations_url":"https://api.github.com/users/CUBRID/orgs","repos_url":"https://api.github.com/users/CUBRID/repos","events_url":"https://api.github.com/users/CUBRID/events{/privacy}","received_events_url":"https://api.github.com/users/CUBRID/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CUBRID/cubrid-testtools","description":"Scripts and utilities that automated testing for CUBRID QA","fork":false,"url":"https://api.github.com/repos/CUBRID/cubrid-testtools","forks_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/forks","keys_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/teams","hooks_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/hooks","issue_events_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/issues/events{/number}","events_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/events","assignees_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/assignees{/user}","branches_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/branches{/branch}","tags_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/tags","blobs_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/statuses/{sha}","languages_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/languages","stargazers_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/stargazers","contributors_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/contributors","subscribers_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/subscribers","subscription_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/subscription","commits_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/contents/{+path}","compare_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/merges","archive_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/downloads","issues_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/issues{/number}","pulls_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/pulls{/number}","milestones_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/milestones{/number}","notifications_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/labels{/name}","releases_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/releases{/id}","deployments_url":"https://api.github.com/repos/CUBRID/cubrid-testtools/deployments","created_at":"2016-02-23T03:35:11Z","updated_at":"2016-03-28T09:01:05Z","pushed_at":"2016-10-14T03:47:08Z","git_url":"git://github.com/CUBRID/cubrid-testtools.git","ssh_url":"git@github.com:CUBRID/cubrid-testtools.git","clone_url":"https://github.com/CUBRID/cubrid-testtools.git","svn_url":"https://github.com/CUBRID/cubrid-testtools","homepage":null,"size":24234,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CUBRID/cubrid-testtools/pulls/239"},"html":{"href":"https://github.com/CUBRID/cubrid-testtools/pull/239"},"issue":{"href":"https://api.github.com/repos/CUBRID/cubrid-testtools/issues/239"},"comments":{"href":"https://api.github.com/repos/CUBRID/cubrid-testtools/issues/239/comments"},"review_comments":{"href":"https://api.github.com/repos/CUBRID/cubrid-testtools/pulls/239/comments"},"review_comment":{"href":"https://api.github.com/repos/CUBRID/cubrid-testtools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CUBRID/cubrid-testtools/pulls/239/commits"},"statuses":{"href":"https://api.github.com/repos/CUBRID/cubrid-testtools/statuses/ca70c44e56a5da7222ed4627bcd8f35dc184dded"}}}}
{"actor":{"display_login":"fanzaiqiang"}}