{"action":"created","comment":{"url":"https://api.github.com/repos/hmrc/http-verbs/pulls/comments/72956516","id":72956516,"diff_hunk":"@@ -33,12 +34,14 @@ case class HeaderCarrier(authorization: Option[Authorization] = None,\n                          requestId: Option[RequestId] = None,\n                          requestChain: RequestChain = RequestChain.init,\n                          nsStamp: Long = System.nanoTime(),\n-                         extraHeaders: Seq[(String, String)] = Seq(), \n+                         extraHeaders: Seq[(String, String)] = Seq(),","path":"src/main/scala/uk/gov/hmrc/play/http/HeaderCarrier.scala","position":13,"original_position":13,"commit_id":"e1ffb116882b83b86798fa20c4637b45d6df114a","original_commit_id":"e1ffb116882b83b86798fa20c4637b45d6df114a","user":{"login":"beyond-code-github","id":795965,"avatar_url":"https://avatars.githubusercontent.com/u/795965?v=3","gravatar_id":"","url":"https://api.github.com/users/beyond-code-github","html_url":"https://github.com/beyond-code-github","followers_url":"https://api.github.com/users/beyond-code-github/followers","following_url":"https://api.github.com/users/beyond-code-github/following{/other_user}","gists_url":"https://api.github.com/users/beyond-code-github/gists{/gist_id}","starred_url":"https://api.github.com/users/beyond-code-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beyond-code-github/subscriptions","organizations_url":"https://api.github.com/users/beyond-code-github/orgs","repos_url":"https://api.github.com/users/beyond-code-github/repos","events_url":"https://api.github.com/users/beyond-code-github/events{/privacy}","received_events_url":"https://api.github.com/users/beyond-code-github/received_events","type":"User","site_admin":false},"body":"Hmmm tricky. I'd like to clarify the name 'extraHeaders' but I'm wary of introducing a breaking change. The only other thing I can think of is to rename 'otherHeaders' to something like 'headersNotPresentInBlacklist' which is a bit wordy","created_at":"2016-08-01T10:35:06Z","updated_at":"2016-08-01T10:35:06Z","html_url":"https://github.com/hmrc/http-verbs/pull/50#discussion_r72956516","pull_request_url":"https://api.github.com/repos/hmrc/http-verbs/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/hmrc/http-verbs/pulls/comments/72956516"},"html":{"href":"https://github.com/hmrc/http-verbs/pull/50#discussion_r72956516"},"pull_request":{"href":"https://api.github.com/repos/hmrc/http-verbs/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/hmrc/http-verbs/pulls/50","id":77409630,"html_url":"https://github.com/hmrc/http-verbs/pull/50","diff_url":"https://github.com/hmrc/http-verbs/pull/50.diff","patch_url":"https://github.com/hmrc/http-verbs/pull/50.patch","issue_url":"https://api.github.com/repos/hmrc/http-verbs/issues/50","number":50,"state":"open","locked":false,"title":"TXM-1154 ensure Akamai-Reputation header in HC by including all non-b…","user":{"login":"iteratoruk","id":461513,"avatar_url":"https://avatars.githubusercontent.com/u/461513?v=3","gravatar_id":"","url":"https://api.github.com/users/iteratoruk","html_url":"https://github.com/iteratoruk","followers_url":"https://api.github.com/users/iteratoruk/followers","following_url":"https://api.github.com/users/iteratoruk/following{/other_user}","gists_url":"https://api.github.com/users/iteratoruk/gists{/gist_id}","starred_url":"https://api.github.com/users/iteratoruk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iteratoruk/subscriptions","organizations_url":"https://api.github.com/users/iteratoruk/orgs","repos_url":"https://api.github.com/users/iteratoruk/repos","events_url":"https://api.github.com/users/iteratoruk/events{/privacy}","received_events_url":"https://api.github.com/users/iteratoruk/received_events","type":"User","site_admin":false},"body":"…lacklisted headers\r\n\r\nFurther to recent discussion on #team-platops around extracting addition of headers to header carrier from code, this change set introduces forwarding of all headers with a configurable blacklist via Play config.","created_at":"2016-07-14T07:12:42Z","updated_at":"2016-08-01T10:35:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff43f09aca39491a5352b256b084e779fdbcb760","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/http-verbs/pulls/50/commits","review_comments_url":"https://api.github.com/repos/hmrc/http-verbs/pulls/50/comments","review_comment_url":"https://api.github.com/repos/hmrc/http-verbs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/http-verbs/issues/50/comments","statuses_url":"https://api.github.com/repos/hmrc/http-verbs/statuses/e1ffb116882b83b86798fa20c4637b45d6df114a","head":{"label":"iteratoruk:master","ref":"master","sha":"e1ffb116882b83b86798fa20c4637b45d6df114a","user":{"login":"iteratoruk","id":461513,"avatar_url":"https://avatars.githubusercontent.com/u/461513?v=3","gravatar_id":"","url":"https://api.github.com/users/iteratoruk","html_url":"https://github.com/iteratoruk","followers_url":"https://api.github.com/users/iteratoruk/followers","following_url":"https://api.github.com/users/iteratoruk/following{/other_user}","gists_url":"https://api.github.com/users/iteratoruk/gists{/gist_id}","starred_url":"https://api.github.com/users/iteratoruk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iteratoruk/subscriptions","organizations_url":"https://api.github.com/users/iteratoruk/orgs","repos_url":"https://api.github.com/users/iteratoruk/repos","events_url":"https://api.github.com/users/iteratoruk/events{/privacy}","received_events_url":"https://api.github.com/users/iteratoruk/received_events","type":"User","site_admin":false},"repo":{"id":63148821,"name":"http-verbs","full_name":"iteratoruk/http-verbs","owner":{"login":"iteratoruk","id":461513,"avatar_url":"https://avatars.githubusercontent.com/u/461513?v=3","gravatar_id":"","url":"https://api.github.com/users/iteratoruk","html_url":"https://github.com/iteratoruk","followers_url":"https://api.github.com/users/iteratoruk/followers","following_url":"https://api.github.com/users/iteratoruk/following{/other_user}","gists_url":"https://api.github.com/users/iteratoruk/gists{/gist_id}","starred_url":"https://api.github.com/users/iteratoruk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iteratoruk/subscriptions","organizations_url":"https://api.github.com/users/iteratoruk/orgs","repos_url":"https://api.github.com/users/iteratoruk/repos","events_url":"https://api.github.com/users/iteratoruk/events{/privacy}","received_events_url":"https://api.github.com/users/iteratoruk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iteratoruk/http-verbs","description":"Library which encapsulates common concerns for calling other HTTP services","fork":true,"url":"https://api.github.com/repos/iteratoruk/http-verbs","forks_url":"https://api.github.com/repos/iteratoruk/http-verbs/forks","keys_url":"https://api.github.com/repos/iteratoruk/http-verbs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iteratoruk/http-verbs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iteratoruk/http-verbs/teams","hooks_url":"https://api.github.com/repos/iteratoruk/http-verbs/hooks","issue_events_url":"https://api.github.com/repos/iteratoruk/http-verbs/issues/events{/number}","events_url":"https://api.github.com/repos/iteratoruk/http-verbs/events","assignees_url":"https://api.github.com/repos/iteratoruk/http-verbs/assignees{/user}","branches_url":"https://api.github.com/repos/iteratoruk/http-verbs/branches{/branch}","tags_url":"https://api.github.com/repos/iteratoruk/http-verbs/tags","blobs_url":"https://api.github.com/repos/iteratoruk/http-verbs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iteratoruk/http-verbs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iteratoruk/http-verbs/git/refs{/sha}","trees_url":"https://api.github.com/repos/iteratoruk/http-verbs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iteratoruk/http-verbs/statuses/{sha}","languages_url":"https://api.github.com/repos/iteratoruk/http-verbs/languages","stargazers_url":"https://api.github.com/repos/iteratoruk/http-verbs/stargazers","contributors_url":"https://api.github.com/repos/iteratoruk/http-verbs/contributors","subscribers_url":"https://api.github.com/repos/iteratoruk/http-verbs/subscribers","subscription_url":"https://api.github.com/repos/iteratoruk/http-verbs/subscription","commits_url":"https://api.github.com/repos/iteratoruk/http-verbs/commits{/sha}","git_commits_url":"https://api.github.com/repos/iteratoruk/http-verbs/git/commits{/sha}","comments_url":"https://api.github.com/repos/iteratoruk/http-verbs/comments{/number}","issue_comment_url":"https://api.github.com/repos/iteratoruk/http-verbs/issues/comments{/number}","contents_url":"https://api.github.com/repos/iteratoruk/http-verbs/contents/{+path}","compare_url":"https://api.github.com/repos/iteratoruk/http-verbs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iteratoruk/http-verbs/merges","archive_url":"https://api.github.com/repos/iteratoruk/http-verbs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iteratoruk/http-verbs/downloads","issues_url":"https://api.github.com/repos/iteratoruk/http-verbs/issues{/number}","pulls_url":"https://api.github.com/repos/iteratoruk/http-verbs/pulls{/number}","milestones_url":"https://api.github.com/repos/iteratoruk/http-verbs/milestones{/number}","notifications_url":"https://api.github.com/repos/iteratoruk/http-verbs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iteratoruk/http-verbs/labels{/name}","releases_url":"https://api.github.com/repos/iteratoruk/http-verbs/releases{/id}","deployments_url":"https://api.github.com/repos/iteratoruk/http-verbs/deployments","created_at":"2016-07-12T10:23:29Z","updated_at":"2016-07-12T10:23:30Z","pushed_at":"2016-07-20T10:19:26Z","git_url":"git://github.com/iteratoruk/http-verbs.git","ssh_url":"git@github.com:iteratoruk/http-verbs.git","clone_url":"https://github.com/iteratoruk/http-verbs.git","svn_url":"https://github.com/iteratoruk/http-verbs","homepage":null,"size":338,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"69bf0d324d78ccf891c1f55e7c7156d1c0c3c620","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":31609171,"name":"http-verbs","full_name":"hmrc/http-verbs","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars.githubusercontent.com/u/5755339?v=3","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/http-verbs","description":"Library which encapsulates common concerns for calling other HTTP services","fork":false,"url":"https://api.github.com/repos/hmrc/http-verbs","forks_url":"https://api.github.com/repos/hmrc/http-verbs/forks","keys_url":"https://api.github.com/repos/hmrc/http-verbs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/http-verbs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/http-verbs/teams","hooks_url":"https://api.github.com/repos/hmrc/http-verbs/hooks","issue_events_url":"https://api.github.com/repos/hmrc/http-verbs/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/http-verbs/events","assignees_url":"https://api.github.com/repos/hmrc/http-verbs/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/http-verbs/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/http-verbs/tags","blobs_url":"https://api.github.com/repos/hmrc/http-verbs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/http-verbs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/http-verbs/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/http-verbs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/http-verbs/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/http-verbs/languages","stargazers_url":"https://api.github.com/repos/hmrc/http-verbs/stargazers","contributors_url":"https://api.github.com/repos/hmrc/http-verbs/contributors","subscribers_url":"https://api.github.com/repos/hmrc/http-verbs/subscribers","subscription_url":"https://api.github.com/repos/hmrc/http-verbs/subscription","commits_url":"https://api.github.com/repos/hmrc/http-verbs/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/http-verbs/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/http-verbs/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/http-verbs/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/http-verbs/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/http-verbs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/http-verbs/merges","archive_url":"https://api.github.com/repos/hmrc/http-verbs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/http-verbs/downloads","issues_url":"https://api.github.com/repos/hmrc/http-verbs/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/http-verbs/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/http-verbs/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/http-verbs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/http-verbs/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/http-verbs/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/http-verbs/deployments","created_at":"2015-03-03T16:41:53Z","updated_at":"2016-01-27T10:55:52Z","pushed_at":"2016-07-25T15:05:22Z","git_url":"git://github.com/hmrc/http-verbs.git","ssh_url":"git@github.com:hmrc/http-verbs.git","clone_url":"https://github.com/hmrc/http-verbs.git","svn_url":"https://github.com/hmrc/http-verbs","homepage":null,"size":447,"stargazers_count":5,"watchers_count":5,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":8,"forks":32,"open_issues":8,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/http-verbs/pulls/50"},"html":{"href":"https://github.com/hmrc/http-verbs/pull/50"},"issue":{"href":"https://api.github.com/repos/hmrc/http-verbs/issues/50"},"comments":{"href":"https://api.github.com/repos/hmrc/http-verbs/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/http-verbs/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/http-verbs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/http-verbs/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/http-verbs/statuses/e1ffb116882b83b86798fa20c4637b45d6df114a"}}}}
{"actor":{"display_login":"beyond-code-github"}}