{"action":"created","comment":{"url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/pulls/comments/50638775","id":50638775,"diff_hunk":"@@ -141,7 +141,7 @@ batadv_gw_get_best_gw_node(struct batadv_priv *bat_priv)\n \t\t\tbatadv_gw_bandwidth_to_kbit(orig_node->gw_flags,\n \t\t\t\t\t\t    &down, &up);\n \n-\t\t\ttmp_gw_factor = tq_avg * tq_avg * down * 100 * 100;\n+\t\t\ttmp_gw_factor = (uint64_t)(tq_avg) * tq_avg * down * 100 * 100;","path":"gateway_client.c","position":5,"original_position":5,"commit_id":"29e0a0606107939cdc0e6540d76b88292c1ceefc","original_commit_id":"29e0a0606107939cdc0e6540d76b88292c1ceefc","user":{"login":"NeoRaider","id":419139,"avatar_url":"https://avatars.githubusercontent.com/u/419139?v=3","gravatar_id":"","url":"https://api.github.com/users/NeoRaider","html_url":"https://github.com/NeoRaider","followers_url":"https://api.github.com/users/NeoRaider/followers","following_url":"https://api.github.com/users/NeoRaider/following{/other_user}","gists_url":"https://api.github.com/users/NeoRaider/gists{/gist_id}","starred_url":"https://api.github.com/users/NeoRaider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NeoRaider/subscriptions","organizations_url":"https://api.github.com/users/NeoRaider/orgs","repos_url":"https://api.github.com/users/NeoRaider/repos","events_url":"https://api.github.com/users/NeoRaider/events{/privacy}","received_events_url":"https://api.github.com/users/NeoRaider/received_events","type":"User","site_admin":false},"body":"The pair of parentheses added around `tq_avg` is unnecessary.","created_at":"2016-01-24T17:36:27Z","updated_at":"2016-01-24T17:36:27Z","html_url":"https://github.com/freifunk-gluon/batman-adv-legacy/pull/4#discussion_r50638775","pull_request_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/pulls/comments/50638775"},"html":{"href":"https://github.com/freifunk-gluon/batman-adv-legacy/pull/4#discussion_r50638775"},"pull_request":{"href":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/pulls/4","id":57007795,"html_url":"https://github.com/freifunk-gluon/batman-adv-legacy/pull/4","diff_url":"https://github.com/freifunk-gluon/batman-adv-legacy/pull/4.diff","patch_url":"https://github.com/freifunk-gluon/batman-adv-legacy/pull/4.patch","issue_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/issues/4","number":4,"state":"open","locked":false,"title":"batman-adv: Fix overflow in gateway select calculation","user":{"login":"RedDog99","id":990633,"avatar_url":"https://avatars.githubusercontent.com/u/990633?v=3","gravatar_id":"","url":"https://api.github.com/users/RedDog99","html_url":"https://github.com/RedDog99","followers_url":"https://api.github.com/users/RedDog99/followers","following_url":"https://api.github.com/users/RedDog99/following{/other_user}","gists_url":"https://api.github.com/users/RedDog99/gists{/gist_id}","starred_url":"https://api.github.com/users/RedDog99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedDog99/subscriptions","organizations_url":"https://api.github.com/users/RedDog99/orgs","repos_url":"https://api.github.com/users/RedDog99/repos","events_url":"https://api.github.com/users/RedDog99/events{/privacy}","received_events_url":"https://api.github.com/users/RedDog99/received_events","type":"User","site_admin":false},"body":"Casting one component of the addition is necessary to avoid an integer\r\noverflow.\r\n\r\nSigned-off-by: Tim Niemeyer <tim.niemeyer@mastersword.de>","created_at":"2016-01-24T16:59:53Z","updated_at":"2016-01-24T17:36:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7678ef2fb06da20481e552f272800a32fa54cb1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/pulls/4/commits","review_comments_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/pulls/4/comments","review_comment_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/issues/4/comments","statuses_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/statuses/29e0a0606107939cdc0e6540d76b88292c1ceefc","head":{"label":"RedDog99:master","ref":"master","sha":"29e0a0606107939cdc0e6540d76b88292c1ceefc","user":{"login":"RedDog99","id":990633,"avatar_url":"https://avatars.githubusercontent.com/u/990633?v=3","gravatar_id":"","url":"https://api.github.com/users/RedDog99","html_url":"https://github.com/RedDog99","followers_url":"https://api.github.com/users/RedDog99/followers","following_url":"https://api.github.com/users/RedDog99/following{/other_user}","gists_url":"https://api.github.com/users/RedDog99/gists{/gist_id}","starred_url":"https://api.github.com/users/RedDog99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedDog99/subscriptions","organizations_url":"https://api.github.com/users/RedDog99/orgs","repos_url":"https://api.github.com/users/RedDog99/repos","events_url":"https://api.github.com/users/RedDog99/events{/privacy}","received_events_url":"https://api.github.com/users/RedDog99/received_events","type":"User","site_admin":false},"repo":{"id":50294129,"name":"batman-adv-legacy","full_name":"RedDog99/batman-adv-legacy","owner":{"login":"RedDog99","id":990633,"avatar_url":"https://avatars.githubusercontent.com/u/990633?v=3","gravatar_id":"","url":"https://api.github.com/users/RedDog99","html_url":"https://github.com/RedDog99","followers_url":"https://api.github.com/users/RedDog99/followers","following_url":"https://api.github.com/users/RedDog99/following{/other_user}","gists_url":"https://api.github.com/users/RedDog99/gists{/gist_id}","starred_url":"https://api.github.com/users/RedDog99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedDog99/subscriptions","organizations_url":"https://api.github.com/users/RedDog99/orgs","repos_url":"https://api.github.com/users/RedDog99/repos","events_url":"https://api.github.com/users/RedDog99/events{/privacy}","received_events_url":"https://api.github.com/users/RedDog99/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RedDog99/batman-adv-legacy","description":"batman-adv compat 14, with a few extra patches on top of 2013.4","fork":true,"url":"https://api.github.com/repos/RedDog99/batman-adv-legacy","forks_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/forks","keys_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/teams","hooks_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/hooks","issue_events_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/issues/events{/number}","events_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/events","assignees_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/assignees{/user}","branches_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/branches{/branch}","tags_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/tags","blobs_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/git/refs{/sha}","trees_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/statuses/{sha}","languages_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/languages","stargazers_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/stargazers","contributors_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/contributors","subscribers_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/subscribers","subscription_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/subscription","commits_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/commits{/sha}","git_commits_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/git/commits{/sha}","comments_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/comments{/number}","issue_comment_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/issues/comments{/number}","contents_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/contents/{+path}","compare_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/merges","archive_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/downloads","issues_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/issues{/number}","pulls_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/pulls{/number}","milestones_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/milestones{/number}","notifications_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/labels{/name}","releases_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/releases{/id}","deployments_url":"https://api.github.com/repos/RedDog99/batman-adv-legacy/deployments","created_at":"2016-01-24T15:34:37Z","updated_at":"2016-01-24T15:34:38Z","pushed_at":"2016-01-24T15:39:42Z","git_url":"git://github.com/RedDog99/batman-adv-legacy.git","ssh_url":"git@github.com:RedDog99/batman-adv-legacy.git","clone_url":"https://github.com/RedDog99/batman-adv-legacy.git","svn_url":"https://github.com/RedDog99/batman-adv-legacy","homepage":null,"size":1629,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freifunk-gluon:master","ref":"master","sha":"a85427747b93164876c8e9a8c6630b8848d1bfa2","user":{"login":"freifunk-gluon","id":3431254,"avatar_url":"https://avatars.githubusercontent.com/u/3431254?v=3","gravatar_id":"","url":"https://api.github.com/users/freifunk-gluon","html_url":"https://github.com/freifunk-gluon","followers_url":"https://api.github.com/users/freifunk-gluon/followers","following_url":"https://api.github.com/users/freifunk-gluon/following{/other_user}","gists_url":"https://api.github.com/users/freifunk-gluon/gists{/gist_id}","starred_url":"https://api.github.com/users/freifunk-gluon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freifunk-gluon/subscriptions","organizations_url":"https://api.github.com/users/freifunk-gluon/orgs","repos_url":"https://api.github.com/users/freifunk-gluon/repos","events_url":"https://api.github.com/users/freifunk-gluon/events{/privacy}","received_events_url":"https://api.github.com/users/freifunk-gluon/received_events","type":"Organization","site_admin":false},"repo":{"id":16194128,"name":"batman-adv-legacy","full_name":"freifunk-gluon/batman-adv-legacy","owner":{"login":"freifunk-gluon","id":3431254,"avatar_url":"https://avatars.githubusercontent.com/u/3431254?v=3","gravatar_id":"","url":"https://api.github.com/users/freifunk-gluon","html_url":"https://github.com/freifunk-gluon","followers_url":"https://api.github.com/users/freifunk-gluon/followers","following_url":"https://api.github.com/users/freifunk-gluon/following{/other_user}","gists_url":"https://api.github.com/users/freifunk-gluon/gists{/gist_id}","starred_url":"https://api.github.com/users/freifunk-gluon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freifunk-gluon/subscriptions","organizations_url":"https://api.github.com/users/freifunk-gluon/orgs","repos_url":"https://api.github.com/users/freifunk-gluon/repos","events_url":"https://api.github.com/users/freifunk-gluon/events{/privacy}","received_events_url":"https://api.github.com/users/freifunk-gluon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freifunk-gluon/batman-adv-legacy","description":"batman-adv compat 14, with a few extra patches on top of 2013.4","fork":false,"url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy","forks_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/forks","keys_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/teams","hooks_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/hooks","issue_events_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/issues/events{/number}","events_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/events","assignees_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/assignees{/user}","branches_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/branches{/branch}","tags_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/tags","blobs_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/git/refs{/sha}","trees_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/statuses/{sha}","languages_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/languages","stargazers_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/stargazers","contributors_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/contributors","subscribers_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/subscribers","subscription_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/subscription","commits_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/commits{/sha}","git_commits_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/git/commits{/sha}","comments_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/comments{/number}","issue_comment_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/issues/comments{/number}","contents_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/contents/{+path}","compare_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/merges","archive_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/downloads","issues_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/issues{/number}","pulls_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/pulls{/number}","milestones_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/milestones{/number}","notifications_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/labels{/name}","releases_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/releases{/id}","deployments_url":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/deployments","created_at":"2014-01-24T03:38:55Z","updated_at":"2015-04-25T16:56:24Z","pushed_at":"2016-01-24T16:59:53Z","git_url":"git://github.com/freifunk-gluon/batman-adv-legacy.git","ssh_url":"git@github.com:freifunk-gluon/batman-adv-legacy.git","clone_url":"https://github.com/freifunk-gluon/batman-adv-legacy.git","svn_url":"https://github.com/freifunk-gluon/batman-adv-legacy","homepage":null,"size":1899,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/pulls/4"},"html":{"href":"https://github.com/freifunk-gluon/batman-adv-legacy/pull/4"},"issue":{"href":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/issues/4"},"comments":{"href":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/freifunk-gluon/batman-adv-legacy/statuses/29e0a0606107939cdc0e6540d76b88292c1ceefc"}}}}