{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/20471","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/20471/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/20471/comments","events_url":"https://api.github.com/repos/docker/docker/issues/20471/events","html_url":"https://github.com/docker/docker/pull/20471","id":134743131,"number":20471,"title":"Avoid setting default truthy values from flags that are not set.","user":{"login":"calavera","id":1050,"avatar_url":"https://avatars.githubusercontent.com/u/1050?v=3","gravatar_id":"","url":"https://api.github.com/users/calavera","html_url":"https://github.com/calavera","followers_url":"https://api.github.com/users/calavera/followers","following_url":"https://api.github.com/users/calavera/following{/other_user}","gists_url":"https://api.github.com/users/calavera/gists{/gist_id}","starred_url":"https://api.github.com/users/calavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calavera/subscriptions","organizations_url":"https://api.github.com/users/calavera/orgs","repos_url":"https://api.github.com/users/calavera/repos","events_url":"https://api.github.com/users/calavera/events{/privacy}","received_events_url":"https://api.github.com/users/calavera/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-19T01:04:11Z","updated_at":"2016-02-19T01:21:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/20471","html_url":"https://github.com/docker/docker/pull/20471","diff_url":"https://github.com/docker/docker/pull/20471.diff","patch_url":"https://github.com/docker/docker/pull/20471.patch"},"body":"When the value for a configuration option in the file is `false`,\nand the default value for a flag is `true`, we should not\ntake the value from the later as final value for the option,\nbecause the user explicitly set `false`.\n\nThis change overrides the default value in the flagSet with\nthe value in the configuration file so we get the correct\nresult when we merge the two configurations together.\n\nFixes #20289.\n\nSigned-off-by: David Calavera <david.calavera@gmail.com>"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/186003291","html_url":"https://github.com/docker/docker/pull/20471#issuecomment-186003291","issue_url":"https://api.github.com/repos/docker/docker/issues/20471","id":186003291,"user":{"login":"GordonTheTurtle","id":10620046,"avatar_url":"https://avatars.githubusercontent.com/u/10620046?v=3","gravatar_id":"","url":"https://api.github.com/users/GordonTheTurtle","html_url":"https://github.com/GordonTheTurtle","followers_url":"https://api.github.com/users/GordonTheTurtle/followers","following_url":"https://api.github.com/users/GordonTheTurtle/following{/other_user}","gists_url":"https://api.github.com/users/GordonTheTurtle/gists{/gist_id}","starred_url":"https://api.github.com/users/GordonTheTurtle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordonTheTurtle/subscriptions","organizations_url":"https://api.github.com/users/GordonTheTurtle/orgs","repos_url":"https://api.github.com/users/GordonTheTurtle/repos","events_url":"https://api.github.com/users/GordonTheTurtle/events{/privacy}","received_events_url":"https://api.github.com/users/GordonTheTurtle/received_events","type":"User","site_admin":false},"created_at":"2016-02-19T01:21:23Z","updated_at":"2016-02-19T01:21:23Z","body":"Job: Docker-PRs-Win2Lin [FAILED](https://jenkins.dockerproject.org/job/Docker-PRs-Win2Lin/21946/console):\n\n~~~console\n\n---\n\n\r\nPing statistics for 10.0.0.14:\r\n    Packets: Sent = 4, Received = 4, Lost = 0 (0% loss),\r\nApproximate round trip times in milli-seconds:\r\n    Minimum = 0ms, Maximum = 0ms, Average = 0ms\r\nERROR: Failed with exitcode 1 at Fri Feb 19 01:21:14 CUT 2016.\nBuild step 'Execute shell' marked build as failure\nPerforming Post build task...\nCould not match :Build timed out  : False\nLogical operation result is FALSE\nSkipping script  : cd c:\\scripts\r\nsh timeout-post-build.sh\r\n\nEND OF POST BUILD TASK \t: 0\n[PostBuildScript] - Execution post build scripts.\n[docker] $ sh -xe C:\\Users\\Jenkins\\AppData\\Local\\Temp\\hudson8617338853554931636.sh\r\n+ set +x\n\n\n---\n\n~~~"}}