{"action":"closed","number":1246,"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/1246","id":73373072,"html_url":"https://github.com/ufz/ogs/pull/1246","diff_url":"https://github.com/ufz/ogs/pull/1246.diff","patch_url":"https://github.com/ufz/ogs/pull/1246.patch","issue_url":"https://api.github.com/repos/ufz/ogs/issues/1246","number":1246,"state":"closed","locked":false,"title":"Remove std::unique_ptr for PETSc vec mat","user":{"login":"norihiro-w","id":800408,"avatar_url":"https://avatars.githubusercontent.com/u/800408?v=3","gravatar_id":"","url":"https://api.github.com/users/norihiro-w","html_url":"https://github.com/norihiro-w","followers_url":"https://api.github.com/users/norihiro-w/followers","following_url":"https://api.github.com/users/norihiro-w/following{/other_user}","gists_url":"https://api.github.com/users/norihiro-w/gists{/gist_id}","starred_url":"https://api.github.com/users/norihiro-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norihiro-w/subscriptions","organizations_url":"https://api.github.com/users/norihiro-w/orgs","repos_url":"https://api.github.com/users/norihiro-w/repos","events_url":"https://api.github.com/users/norihiro-w/events{/privacy}","received_events_url":"https://api.github.com/users/norihiro-w/received_events","type":"User","site_admin":false},"body":"It doesn't make sense to use std::unique_ptr for PETSc vec mat objects because Vec and Mat types are actually pointers, i.e. `typedef struct _p_Mat* Mat`. \r\n\r\nand it can mislead people that std::unique_ptr can delete a PETSc Mat object, which is not true.\r\n","created_at":"2016-06-10T13:25:56Z","updated_at":"2016-06-13T09:49:58Z","closed_at":"2016-06-13T09:49:58Z","merged_at":"2016-06-13T09:49:58Z","merge_commit_sha":"7e866bb4c87d2c602d8827a923fff98cddd68b67","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ufz/ogs/pulls/1246/commits","review_comments_url":"https://api.github.com/repos/ufz/ogs/pulls/1246/comments","review_comment_url":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/1246/comments","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/2feceb743d6a697e77020e42f94c4e210659ae8a","head":{"label":"norihiro-w:rm-unq-petsc","ref":"rm-unq-petsc","sha":"2feceb743d6a697e77020e42f94c4e210659ae8a","user":{"login":"norihiro-w","id":800408,"avatar_url":"https://avatars.githubusercontent.com/u/800408?v=3","gravatar_id":"","url":"https://api.github.com/users/norihiro-w","html_url":"https://github.com/norihiro-w","followers_url":"https://api.github.com/users/norihiro-w/followers","following_url":"https://api.github.com/users/norihiro-w/following{/other_user}","gists_url":"https://api.github.com/users/norihiro-w/gists{/gist_id}","starred_url":"https://api.github.com/users/norihiro-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norihiro-w/subscriptions","organizations_url":"https://api.github.com/users/norihiro-w/orgs","repos_url":"https://api.github.com/users/norihiro-w/repos","events_url":"https://api.github.com/users/norihiro-w/events{/privacy}","received_events_url":"https://api.github.com/users/norihiro-w/received_events","type":"User","site_admin":false},"repo":{"id":2612310,"name":"ogs","full_name":"norihiro-w/ogs","owner":{"login":"norihiro-w","id":800408,"avatar_url":"https://avatars.githubusercontent.com/u/800408?v=3","gravatar_id":"","url":"https://api.github.com/users/norihiro-w","html_url":"https://github.com/norihiro-w","followers_url":"https://api.github.com/users/norihiro-w/followers","following_url":"https://api.github.com/users/norihiro-w/following{/other_user}","gists_url":"https://api.github.com/users/norihiro-w/gists{/gist_id}","starred_url":"https://api.github.com/users/norihiro-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norihiro-w/subscriptions","organizations_url":"https://api.github.com/users/norihiro-w/orgs","repos_url":"https://api.github.com/users/norihiro-w/repos","events_url":"https://api.github.com/users/norihiro-w/events{/privacy}","received_events_url":"https://api.github.com/users/norihiro-w/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/norihiro-w/ogs","description":"OGS source code","fork":true,"url":"https://api.github.com/repos/norihiro-w/ogs","forks_url":"https://api.github.com/repos/norihiro-w/ogs/forks","keys_url":"https://api.github.com/repos/norihiro-w/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/norihiro-w/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/norihiro-w/ogs/teams","hooks_url":"https://api.github.com/repos/norihiro-w/ogs/hooks","issue_events_url":"https://api.github.com/repos/norihiro-w/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/norihiro-w/ogs/events","assignees_url":"https://api.github.com/repos/norihiro-w/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/norihiro-w/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/norihiro-w/ogs/tags","blobs_url":"https://api.github.com/repos/norihiro-w/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/norihiro-w/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/norihiro-w/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/norihiro-w/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/norihiro-w/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/norihiro-w/ogs/languages","stargazers_url":"https://api.github.com/repos/norihiro-w/ogs/stargazers","contributors_url":"https://api.github.com/repos/norihiro-w/ogs/contributors","subscribers_url":"https://api.github.com/repos/norihiro-w/ogs/subscribers","subscription_url":"https://api.github.com/repos/norihiro-w/ogs/subscription","commits_url":"https://api.github.com/repos/norihiro-w/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/norihiro-w/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/norihiro-w/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/norihiro-w/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/norihiro-w/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/norihiro-w/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/norihiro-w/ogs/merges","archive_url":"https://api.github.com/repos/norihiro-w/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/norihiro-w/ogs/downloads","issues_url":"https://api.github.com/repos/norihiro-w/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/norihiro-w/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/norihiro-w/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/norihiro-w/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/norihiro-w/ogs/labels{/name}","releases_url":"https://api.github.com/repos/norihiro-w/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/norihiro-w/ogs/deployments","created_at":"2011-10-20T10:16:18Z","updated_at":"2015-03-17T09:09:07Z","pushed_at":"2016-06-10T14:40:42Z","git_url":"git://github.com/norihiro-w/ogs.git","ssh_url":"git@github.com:norihiro-w/ogs.git","clone_url":"https://github.com/norihiro-w/ogs.git","svn_url":"https://github.com/norihiro-w/ogs","homepage":"www.opengeosys.org","size":35514,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"ufz:master","ref":"master","sha":"44ec38a4956f2e2a88f01ab540a7c792adb09854","user":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"repo":{"id":1701384,"name":"ogs","full_name":"ufz/ogs","owner":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufz/ogs","description":"Experimental OGS-6 source code","fork":false,"url":"https://api.github.com/repos/ufz/ogs","forks_url":"https://api.github.com/repos/ufz/ogs/forks","keys_url":"https://api.github.com/repos/ufz/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufz/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufz/ogs/teams","hooks_url":"https://api.github.com/repos/ufz/ogs/hooks","issue_events_url":"https://api.github.com/repos/ufz/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/ufz/ogs/events","assignees_url":"https://api.github.com/repos/ufz/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/ufz/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/ufz/ogs/tags","blobs_url":"https://api.github.com/repos/ufz/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufz/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufz/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufz/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ufz/ogs/languages","stargazers_url":"https://api.github.com/repos/ufz/ogs/stargazers","contributors_url":"https://api.github.com/repos/ufz/ogs/contributors","subscribers_url":"https://api.github.com/repos/ufz/ogs/subscribers","subscription_url":"https://api.github.com/repos/ufz/ogs/subscription","commits_url":"https://api.github.com/repos/ufz/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufz/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufz/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufz/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufz/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/ufz/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufz/ogs/merges","archive_url":"https://api.github.com/repos/ufz/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufz/ogs/downloads","issues_url":"https://api.github.com/repos/ufz/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/ufz/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ufz/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ufz/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufz/ogs/labels{/name}","releases_url":"https://api.github.com/repos/ufz/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/ufz/ogs/deployments","created_at":"2011-05-04T14:09:57Z","updated_at":"2016-04-10T21:29:50Z","pushed_at":"2016-06-13T09:49:58Z","git_url":"git://github.com/ufz/ogs.git","ssh_url":"git@github.com:ufz/ogs.git","clone_url":"https://github.com/ufz/ogs.git","svn_url":"https://github.com/ufz/ogs","homepage":"www.opengeosys.org","size":17682,"stargazers_count":19,"watchers_count":19,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":122,"forks":45,"open_issues":122,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1246"},"html":{"href":"https://github.com/ufz/ogs/pull/1246"},"issue":{"href":"https://api.github.com/repos/ufz/ogs/issues/1246"},"comments":{"href":"https://api.github.com/repos/ufz/ogs/issues/1246/comments"},"review_comments":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1246/comments"},"review_comment":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufz/ogs/pulls/1246/commits"},"statuses":{"href":"https://api.github.com/repos/ufz/ogs/statuses/2feceb743d6a697e77020e42f94c4e210659ae8a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"norihiro-w","id":800408,"avatar_url":"https://avatars.githubusercontent.com/u/800408?v=3","gravatar_id":"","url":"https://api.github.com/users/norihiro-w","html_url":"https://github.com/norihiro-w","followers_url":"https://api.github.com/users/norihiro-w/followers","following_url":"https://api.github.com/users/norihiro-w/following{/other_user}","gists_url":"https://api.github.com/users/norihiro-w/gists{/gist_id}","starred_url":"https://api.github.com/users/norihiro-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norihiro-w/subscriptions","organizations_url":"https://api.github.com/users/norihiro-w/orgs","repos_url":"https://api.github.com/users/norihiro-w/repos","events_url":"https://api.github.com/users/norihiro-w/events{/privacy}","received_events_url":"https://api.github.com/users/norihiro-w/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":87,"deletions":100,"changed_files":5}}
{"actor":{"display_login":"norihiro-w"}}