{"action":"created","issue":{"url":"https://api.github.com/repos/havard/node-openid/issues/162","repository_url":"https://api.github.com/repos/havard/node-openid","labels_url":"https://api.github.com/repos/havard/node-openid/issues/162/labels{/name}","comments_url":"https://api.github.com/repos/havard/node-openid/issues/162/comments","events_url":"https://api.github.com/repos/havard/node-openid/issues/162/events","html_url":"https://github.com/havard/node-openid/pull/162","id":177566159,"number":162,"title":"Fixes ReferenceError: crypto is not defined, Initiates Variables","user":{"login":"Kondax","id":16869626,"avatar_url":"https://avatars.githubusercontent.com/u/16869626?v=3","gravatar_id":"","url":"https://api.github.com/users/Kondax","html_url":"https://github.com/Kondax","followers_url":"https://api.github.com/users/Kondax/followers","following_url":"https://api.github.com/users/Kondax/following{/other_user}","gists_url":"https://api.github.com/users/Kondax/gists{/gist_id}","starred_url":"https://api.github.com/users/Kondax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kondax/subscriptions","organizations_url":"https://api.github.com/users/Kondax/orgs","repos_url":"https://api.github.com/users/Kondax/repos","events_url":"https://api.github.com/users/Kondax/events{/privacy}","received_events_url":"https://api.github.com/users/Kondax/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-17T09:29:33Z","updated_at":"2016-09-20T18:58:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/havard/node-openid/pulls/162","html_url":"https://github.com/havard/node-openid/pull/162","diff_url":"https://github.com/havard/node-openid/pull/162.diff","patch_url":"https://github.com/havard/node-openid/pull/162.patch"},"body":"The initial variables `crypto`, `request`, `querystring`, `url`, and `xrds` are never initiated. This can cause a `ReferenceError: crypto is not defined`, as seen:\r\n\r\n    ReferenceError: crypto is not defined\r\n    at Object.<anonymous> (C:\\Node\\xxxxx\\node_modules\\openid\\openid.js:30:12)\r\n    at Module._compile (module.js:541:32)\r\n    at Object.Module._extensions..js (module.js:550:10)\r\n    at Module.load (module.js:456:32)\r\n    at tryModuleLoad (module.js:415:12)\r\n    at Function.Module._load (module.js:407:3)\r\n    at Module.require (module.js:466:17)\r\n    at require (internal/module.js:20:19)\r\n    at Object.<anonymous> (C:\\Node\\xxxxx\\node_modules\\passport-openid-node6support\\lib\\passport-openid\\ind\r\n    at Module._compile (module.js:541:32)\r\n\r\nI have changed line 29 from `var Buffer = require('buffer').Buffer;` to `var Buffer = require('buffer').Buffer,` - this allows the variables following it to be initiated using `var` from the buffer initialization. \r\n\r\nI have also updated the version to `2.0.6.`"},"comment":{"url":"https://api.github.com/repos/havard/node-openid/issues/comments/248398750","html_url":"https://github.com/havard/node-openid/pull/162#issuecomment-248398750","issue_url":"https://api.github.com/repos/havard/node-openid/issues/162","id":248398750,"user":{"login":"havard","id":45829,"avatar_url":"https://avatars.githubusercontent.com/u/45829?v=3","gravatar_id":"","url":"https://api.github.com/users/havard","html_url":"https://github.com/havard","followers_url":"https://api.github.com/users/havard/followers","following_url":"https://api.github.com/users/havard/following{/other_user}","gists_url":"https://api.github.com/users/havard/gists{/gist_id}","starred_url":"https://api.github.com/users/havard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/havard/subscriptions","organizations_url":"https://api.github.com/users/havard/orgs","repos_url":"https://api.github.com/users/havard/repos","events_url":"https://api.github.com/users/havard/events{/privacy}","received_events_url":"https://api.github.com/users/havard/received_events","type":"User","site_admin":false},"created_at":"2016-09-20T18:58:54Z","updated_at":"2016-09-20T18:58:54Z","body":"Um, this got messy quickly. :)\r\n\r\nThe simplest thing to do now is to just withdraw this PR and issue a new one with just the original commit (or a new version of it from upstream).\r\n\r\nOtherwise, you could rebase to remove the package.json commit and the revert commit, and then force push.\r\n\r\nEither way, it's just a simple comma switch..."}}
{"actor":{"display_login":"havard"}}