{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/20216","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/20216/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/20216/comments","events_url":"https://api.github.com/repos/docker/docker/issues/20216/events","html_url":"https://github.com/docker/docker/pull/20216","id":132878509,"number":20216,"title":"Windows CI: test-unit on pkg\\plugins","user":{"login":"jhowardmsft","id":10522484,"avatar_url":"https://avatars.githubusercontent.com/u/10522484?v=3","gravatar_id":"","url":"https://api.github.com/users/jhowardmsft","html_url":"https://github.com/jhowardmsft","followers_url":"https://api.github.com/users/jhowardmsft/followers","following_url":"https://api.github.com/users/jhowardmsft/following{/other_user}","gists_url":"https://api.github.com/users/jhowardmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jhowardmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhowardmsft/subscriptions","organizations_url":"https://api.github.com/users/jhowardmsft/orgs","repos_url":"https://api.github.com/users/jhowardmsft/repos","events_url":"https://api.github.com/users/jhowardmsft/events{/privacy}","received_events_url":"https://api.github.com/users/jhowardmsft/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/group/windows","name":"group/windows","color":"F6FBFF"},{"url":"https://api.github.com/repos/docker/docker/labels/status/0-triage","name":"status/0-triage","color":"EEEEEE"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-02-11T03:21:04Z","updated_at":"2016-02-11T03:28:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/20216","html_url":"https://github.com/docker/docker/pull/20216","diff_url":"https://github.com/docker/docker/pull/20216.diff","patch_url":"https://github.com/docker/docker/pull/20216.patch"},"body":"Signed-off-by: John Howard <jhoward@microsoft.com>\r\n\r\n(Dup of https://github.com/docker/docker/pull/20215 which was failing in Jenkins horrendously)\r\n\r\nFixes up the failing unit tests for the WindowsTP4 context for pkg\\plugins. It moves the unix:// socket specific test \"TestLocalSocket\" to a unix file. It also annotates where more work needs to be done in the future. However, this does at least mean that we are closer to turning off the \"ignore test-unit failures on WindowsTP4\" flag.\r\n\r\nPreviously failing chunk of output:\r\n```\r\n00:04:43.532 --- FAIL: TestLocalSocket (0.00s)\r\n00:04:43.532 \tdiscovery_test.go:44: listen unix C:\\Windows\\TEMP\\docker-test763715871\\echo.sock: socket: An address incompatible with the requested protocol was used.\r\n00:04:43.532 FAIL\r\n00:04:43.532 coverage: 34.6% of statements\r\n00:04:43.532 FAIL\tgithub.com/docker/docker/pkg/plugins\t1.067s\r\n```\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/182685594","html_url":"https://github.com/docker/docker/pull/20216#issuecomment-182685594","issue_url":"https://api.github.com/repos/docker/docker/issues/20216","id":182685594,"user":{"login":"GordonTheTurtle","id":10620046,"avatar_url":"https://avatars.githubusercontent.com/u/10620046?v=3","gravatar_id":"","url":"https://api.github.com/users/GordonTheTurtle","html_url":"https://github.com/GordonTheTurtle","followers_url":"https://api.github.com/users/GordonTheTurtle/followers","following_url":"https://api.github.com/users/GordonTheTurtle/following{/other_user}","gists_url":"https://api.github.com/users/GordonTheTurtle/gists{/gist_id}","starred_url":"https://api.github.com/users/GordonTheTurtle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordonTheTurtle/subscriptions","organizations_url":"https://api.github.com/users/GordonTheTurtle/orgs","repos_url":"https://api.github.com/users/GordonTheTurtle/repos","events_url":"https://api.github.com/users/GordonTheTurtle/events{/privacy}","received_events_url":"https://api.github.com/users/GordonTheTurtle/received_events","type":"User","site_admin":false},"created_at":"2016-02-11T03:28:09Z","updated_at":"2016-02-11T03:28:09Z","body":"Job: Docker-PRs [FAILED](https://jenkins.dockerproject.org/job/Docker-PRs/23672/console):\n\n~~~console\n\n---\ns]\r\nok  \tgithub.com/docker/docker/pkg/parsers\t0.003s\tcoverage: 100.0% of statements\r\nok  \tgithub.com/docker/docker/pkg/parsers/kernel\t0.003s\tcoverage: 56.8% of statements\r\nok  \tgithub.com/docker/docker/pkg/parsers/operatingsystem\t0.010s\tcoverage: 90.0% of statements\r\n# github.com/docker/docker/pkg/plugins\r\npkg/plugins/discovery_test.go:76: undefined: setup\r\nok  \tgithub.com/docker/docker/pkg/pidfile\t0.003s\tcoverage: 57.1% of statements\r\n?   \tgithub.com/docker/docker/pkg/platform\t[no test files]\r\nFAIL\tgithub.com/docker/docker/pkg/plugins [build failed]\r\nok  \tgithub.com/docker/docker/pkg/plugins/pluginrpc-gen\t0.005s\tcoverage: 50.4% of statements\r\n?   \tgithub.com/docker/docker/pkg/plugins/pluginrpc-gen/fixtures\t[no test files]\r\nok  \tgithub.com/docker/docker/pkg/pools\t0.010s\tcoverage: 87.9% of statements\r\nok  \tgithub.com/docker/docker/pkg/progress\t0.003s\tcoverage: 79.2% of statements\r\n?   \tgithub.com/docker/docker/pkg/promise\t[no test files]\r\nok  \tgithub.com/docker/docker/pkg/proxy\t0.006s\tcoverage: 78.3% of statements\r\nok  \tgithub.com/docker/dock\n---\n\n~~~"}}