{"action":"created","issue":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1093","repository_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit","labels_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1093/labels{/name}","comments_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1093/comments","events_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1093/events","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1093","id":173319857,"number":1093,"title":"CB ADF return type","user":{"login":"jmorra","id":117275,"avatar_url":"https://avatars.githubusercontent.com/u/117275?v=3","gravatar_id":"","url":"https://api.github.com/users/jmorra","html_url":"https://github.com/jmorra","followers_url":"https://api.github.com/users/jmorra/followers","following_url":"https://api.github.com/users/jmorra/following{/other_user}","gists_url":"https://api.github.com/users/jmorra/gists{/gist_id}","starred_url":"https://api.github.com/users/jmorra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmorra/subscriptions","organizations_url":"https://api.github.com/users/jmorra/orgs","repos_url":"https://api.github.com/users/jmorra/repos","events_url":"https://api.github.com/users/jmorra/events{/privacy}","received_events_url":"https://api.github.com/users/jmorra/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":23,"created_at":"2016-08-25T21:54:45Z","updated_at":"2016-09-12T20:08:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/pulls/1093","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1093","diff_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1093.diff","patch_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1093.patch"},"body":"While working with the recent changes within the JNI layer a problem arose.  We wanted to feed the output of a CB model to the [generic decision service](https://github.com/Microsoft/mwt-ds-explore-java/blob/master/src/main/java/com/mwt/explorers/GenericExplorer.java) within Java.  We noticed that the return type of a CB model was `VWMulticlassLearner` just as we would expect and the output of CB explore and CB ADF explore were both `VWActionScoresLearner` as we would expect.  The problem is that the output of CB ADF is also `VWActionScoresLearner`.  This poses a problem because in the case of CB ADF we only want the one best action (unless `--rank_all` is supplied).\r\n\r\nThis pull request addresses this issue by making the `prediction_type` `multiclass` for CB ADF models and keeps is `action_scores` for CB ADF with `--rank_all` and both explore learners.\r\n\r\n@JohnLangford can you please review the C side to make sure I didn't break anything.  @deaktator can you please review the Java side to make sure the tests look good."},"comment":{"url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/comments/246475059","html_url":"https://github.com/JohnLangford/vowpal_wabbit/pull/1093#issuecomment-246475059","issue_url":"https://api.github.com/repos/JohnLangford/vowpal_wabbit/issues/1093","id":246475059,"user":{"login":"jmorra","id":117275,"avatar_url":"https://avatars.githubusercontent.com/u/117275?v=3","gravatar_id":"","url":"https://api.github.com/users/jmorra","html_url":"https://github.com/jmorra","followers_url":"https://api.github.com/users/jmorra/followers","following_url":"https://api.github.com/users/jmorra/following{/other_user}","gists_url":"https://api.github.com/users/jmorra/gists{/gist_id}","starred_url":"https://api.github.com/users/jmorra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmorra/subscriptions","organizations_url":"https://api.github.com/users/jmorra/orgs","repos_url":"https://api.github.com/users/jmorra/repos","events_url":"https://api.github.com/users/jmorra/events{/privacy}","received_events_url":"https://api.github.com/users/jmorra/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T20:08:35Z","updated_at":"2016-09-12T20:08:35Z","body":"I think it's good.  I made some of the changes @deaktator requested and responded to all of them."}}
{"actor":{"display_login":"jmorra"}}