{"action":"created","issue":{"url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/784","repository_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React","labels_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/784/labels{/name}","comments_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/784/comments","events_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/784/events","html_url":"https://github.com/Semantic-Org/Semantic-UI-React/pull/784","id":186851423,"number":784,"title":"feat(Image): Render children appropriately","user":{"login":"jcarbo","id":847027,"avatar_url":"https://avatars.githubusercontent.com/u/847027?v=3","gravatar_id":"","url":"https://api.github.com/users/jcarbo","html_url":"https://github.com/jcarbo","followers_url":"https://api.github.com/users/jcarbo/followers","following_url":"https://api.github.com/users/jcarbo/following{/other_user}","gists_url":"https://api.github.com/users/jcarbo/gists{/gist_id}","starred_url":"https://api.github.com/users/jcarbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcarbo/subscriptions","organizations_url":"https://api.github.com/users/jcarbo/orgs","repos_url":"https://api.github.com/users/jcarbo/repos","events_url":"https://api.github.com/users/jcarbo/events{/privacy}","received_events_url":"https://api.github.com/users/jcarbo/received_events","type":"User","site_admin":false},"labels":[{"id":432565724,"url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/labels/ready%20for%20review","name":"ready for review","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-02T16:29:27Z","updated_at":"2016-11-04T05:01:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/pulls/784","html_url":"https://github.com/Semantic-Org/Semantic-UI-React/pull/784","diff_url":"https://github.com/Semantic-Org/Semantic-UI-React/pull/784.diff","patch_url":"https://github.com/Semantic-Org/Semantic-UI-React/pull/784.patch"},"body":"Previously you could render `<Image>` with children but they  #would be passed to the `<img>`, which is not technically valid markup.\r\n\r\nHere's debug output from the `rendersChildren` test:\r\n```js\r\n<img className=\"ui image\">\r\n  Children are rendered here :|\r\n</img>\r\n```\r\n\r\nThis updates the `Image` component to render the `.ui.image` wrapper if children are present, which brings this more inline with the `Input` component. Both are wrapping elements around an HTML element which technically can't take children. However, since there could be other elements inside the wrapper this gives the user more control over how it renders."},"comment":{"url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/comments/258345487","html_url":"https://github.com/Semantic-Org/Semantic-UI-React/pull/784#issuecomment-258345487","issue_url":"https://api.github.com/repos/Semantic-Org/Semantic-UI-React/issues/784","id":258345487,"user":{"login":"jcarbo","id":847027,"avatar_url":"https://avatars.githubusercontent.com/u/847027?v=3","gravatar_id":"","url":"https://api.github.com/users/jcarbo","html_url":"https://github.com/jcarbo","followers_url":"https://api.github.com/users/jcarbo/followers","following_url":"https://api.github.com/users/jcarbo/following{/other_user}","gists_url":"https://api.github.com/users/jcarbo/gists{/gist_id}","starred_url":"https://api.github.com/users/jcarbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcarbo/subscriptions","organizations_url":"https://api.github.com/users/jcarbo/orgs","repos_url":"https://api.github.com/users/jcarbo/repos","events_url":"https://api.github.com/users/jcarbo/events{/privacy}","received_events_url":"https://api.github.com/users/jcarbo/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T05:01:32Z","updated_at":"2016-11-04T05:01:32Z","body":"@levithomason - I added the message about circular images back as requested. This should be g2g I think 👍 "}}
{"actor":{"display_login":"jcarbo"}}