{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/addons-server/issues/4147","repository_url":"https://api.github.com/repos/mozilla/addons-server","labels_url":"https://api.github.com/repos/mozilla/addons-server/issues/4147/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/addons-server/issues/4147/comments","events_url":"https://api.github.com/repos/mozilla/addons-server/issues/4147/events","html_url":"https://github.com/mozilla/addons-server/issues/4147","id":195832414,"number":4147,"title":"Fileviewer highlighting breaks with certain regexes","user":{"login":"kewisch","id":607198,"avatar_url":"https://avatars.githubusercontent.com/u/607198?v=3","gravatar_id":"","url":"https://api.github.com/users/kewisch","html_url":"https://github.com/kewisch","followers_url":"https://api.github.com/users/kewisch/followers","following_url":"https://api.github.com/users/kewisch/following{/other_user}","gists_url":"https://api.github.com/users/kewisch/gists{/gist_id}","starred_url":"https://api.github.com/users/kewisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kewisch/subscriptions","organizations_url":"https://api.github.com/users/kewisch/orgs","repos_url":"https://api.github.com/users/kewisch/repos","events_url":"https://api.github.com/users/kewisch/events{/privacy}","received_events_url":"https://api.github.com/users/kewisch/received_events","type":"User","site_admin":false},"labels":[{"id":373925957,"url":"https://api.github.com/repos/mozilla/addons-server/labels/reviewer%20tools","name":"reviewer tools","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-15T15:20:58Z","updated_at":"2016-12-15T16:23:01Z","closed_at":null,"body":"### Describe the problem and steps to reproduce it:\r\nVisit https://addons.mozilla.org/en-US/firefox/files/browse/546862/file/data/content_script/youtube.js#L286\r\n\r\n### What happened?\r\nUnnecessarily escaped \" causes highlighting to break (using `/\\\"video_id\\\":\\s*\\\"([^\\\"]+)\\\"/`)\r\n\r\n### What did you expect to happen?\r\nCorrect Highlighting\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mozilla/addons-server/issues/comments/267371123","html_url":"https://github.com/mozilla/addons-server/issues/4147#issuecomment-267371123","issue_url":"https://api.github.com/repos/mozilla/addons-server/issues/4147","id":267371123,"user":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?v=3","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"created_at":"2016-12-15T16:23:01Z","updated_at":"2016-12-15T16:23:01Z","body":"There's been a bunch of issues recently with the syntax highlighting code and when @wagnerand looked at it recently it became clear that the way it works is fundamentally flawed. Some patches were applied to attempt to fix that but quote matching had some issues which required additional patches and this sounds like a related problem.\r\n\r\nThere's a complication with the diffing but the first thing that should be looked at is seeing if highlight.js can wholesale replace the current syntax highlighting. If the diffing parts will work applied separately that might be a viable alternative to continuing to hack the minimally maintained lib we're currently using."}}
{"actor":{"display_login":"muffinresearch"}}