{"push_id":1393256752,"size":26,"distinct_size":26,"ref":"refs/heads/master","head":"80c80ca683217455221e15e0c24a81d5e60e49e0","before":"674d3875c81af122eb7f925845fe73cc4d817db4","commits":[{"sha":"b286868ec99341102dd78eaffea832a8d6b635ab","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 17537: Fix valid-templates.t for some include files\n\n3 include files do not pass the template validation tests:\n - koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc\n - koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc\n - koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc\n\nThis is because they process a block which has not been declared before.\nAs they are include files, they cannot stand on their own.\nWe could have added them to the exclude file list of xt/author/valid-templates.t\nbut I think it's better to keep them into the validation loop.\n\nTest plan:\n  prove xt/author/valid-templates.t\nshould return green\nAnd the library dropdown list should be correctly populated on the pages these files are included\n(opac-topissues for instance)\n\nSigned-off-by: Claire Gravely <claire_gravely@hotmail.com>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@theke.io>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/b286868ec99341102dd78eaffea832a8d6b635ab"},{"sha":"be9a609870445d5d4a2cc24f78eca2d3c4c7c1f2","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 17538: (Bug 17216 follow-up) Fix t/db_dependent/Upload.t\n\nThe insert into authorised_values failed because of the missing FK\n\nTest plan:\n  prove t/db_dependent/Upload.t\nshould return green\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@theke.io>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/be9a609870445d5d4a2cc24f78eca2d3c4c7c1f2"},{"sha":"96fec3a16d66ffa30da9682e91069195f6eb831e","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 17540: (Bug 7216 followup) Fix tests for auth_values_input_www.t\n\nThis is caused by bug 17216 which modified the structure of the AV admin\npage\n\nTest plan:\n  prove t/db_dependent/www/auth_values_input_www.t\nshould return green\n\nSigned-off-by: Josef Moravec <josef.moravec@gmail.com>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@theke.io>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/96fec3a16d66ffa30da9682e91069195f6eb831e"},{"sha":"4a85117160b4afd7d12d9ae9ca3ec0ddc009c2da","author":{"name":"Tomas Cohen Arazi","email":"3994b2d5d879a5e517634211ed0f177149c452a1@theke.io"},"message":"Bug 17544 - : Remove t::lib::Mocks dependency from populate_db.pl\n\nSigned-off-by: Tomas Cohen Arazi <tomascohen@theke.io>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@biblibre.com>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/4a85117160b4afd7d12d9ae9ca3ec0ddc009c2da"},{"sha":"27596ca2e4de7ad57c095c45f1ef6c9ad35f4848","author":{"name":"Hector Castro","email":"3c00ee462893fa264def03034184479f59817734@gmail.com"},"message":"Bug 16792: Add Font Awesome Icon and mini button to Keyword to MARC mapping section\n\nImprove Admin > Keyword to MARC mapping to fit with others interfaces in Koha.\nThis bug change \"Delete\" link with a mini-button and introduce the trash icon.\n\nTo test:\n-Apply patch\n-Goto Admin > Keyword to MARC mapping\n-Select one framework\n-Add some mappings\n-Notice about the new button with trash icon\n\nSigned-off-by: Marc Véron <veron@veron.ch>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/27596ca2e4de7ad57c095c45f1ef6c9ad35f4848"},{"sha":"e0e88806fae409e6ec6e360f5e82f55a45ca0e96","author":{"name":"Lari Taskula","email":"9dbff05c49d9fabd97cbf6655e2328500f0db0b8@jns.fi"},"message":"Bug 17539: Fix Undefined subroutine &C4::Circulation::GetItem error\n\nperl t/db_dependent/Reserves.t\n\n1..72\nok 1 - use C4::Reserves;\nok 2 - CheckReserves Test 1\nok 3 - CheckReserves() include reserve_id in its response\nok 4 - CheckReserves Test 2\nok 5 - CheckReserves Test 3\nok 6 - GetReservesControlBranch returns item home branch when set to ItemHomeLibrary\nok 7 - GetReservesControlBranch returns patron home branch when set to PatronLibrary\nok 8 - Item is correctly waiting\nok 9 - Item is correctly priority 1\nok 10 - Item is correctly priority 2\nok 11 - GetWaiting got only the waiting reserve\nok 12 - GetWaiting got the reserve for the correct borrower\nUndefined subroutine &C4::Circulation::GetItem called at /home/ubuntu/kohaclone/C4/Circulation.pm line 1853.\n\nThis patch fixes this error. The solution was to use C4::Reserves before C4::Items.\nAlso due to this edit, change use_ok to require_ok\n\nSigned-off-by: Tomas Cohen Arazi <tomascohen@theke.io>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/e0e88806fae409e6ec6e360f5e82f55a45ca0e96"},{"sha":"c414e7608956ca04648aed1a15b79c5cd281fb3c","author":{"name":"Lari Taskula","email":"9dbff05c49d9fabd97cbf6655e2328500f0db0b8@jns.fi"},"message":"Bug 17539: Fix Already in a transaction error\n\nperl t/db_dependent/Reserves.t\n\n1..72\nok 1 - use C4::Reserves;\nok 2 - CheckReserves Test 1\n...\nok 52 - Reserve in waiting status cant be canceled\nok 53 - Reserving an ageRestricted Biblio without a borrower dateofbirth succeeds\nDBD::mysql::db begin_work failed: Already in a transaction at\n/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1489.\nDBD::mysql::db begin_work failed: Already in a transaction at\n/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1489.\nat /usr/share/perl5/DBIx/Class/Schema.pm line 1080.\n...\nKoha::Object::store('Koha::Patron=HASH(0x9e43b20)') called at\n/home/ubuntu/kohaclone/C4/Members.pm line 542\nC4::Members::ModMember('borrowernumber', 658535, 'dateofbirth', '2001-11-02')\ncalled at t/db_dependent/Reserves.t line 516\n\nThis patch fixes this issue by replacing dbh autocommit=0 with\ntxn_begin.\n\nSigned-off-by: Tomas Cohen Arazi <tomascohen@theke.io>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/c414e7608956ca04648aed1a15b79c5cd281fb3c"},{"sha":"246bca4a67b2ca177d4defb39284a3ede2a0703a","author":{"name":"Lari Taskula","email":"9dbff05c49d9fabd97cbf6655e2328500f0db0b8@jns.fi"},"message":"Bug 17539: Fix failing Reserves.t tests if category enrolmentfee > 0\n\nTo test:\n1. Set patron category \"S\" with enrolmentfee 1\n2. perl t/db_dependent/Reserves.t\n3. Observe following errors:\n\nnot ok 59 - Bug 14464 - No fines at beginning\nok 60 - Bug 14464 - 1st reserve correctly created\nok 61 - Bug 14968 - Keep found column from reserve\nnot ok 62 - Bug 14464 - No fines after cancelling reserve with no charge configured\nok 63 - Bug 14464 - 2nd reserve correctly created\nnot ok 64 - Bug 14464 - No fines after cancelling reserve with no charge desired\nok 65 - Bug 14464 - 1st reserve correctly created\nnot ok 66 - Bug 14464 - Fine applied after cancelling reserve with charge desired and configured\n\n4. Apply patch\n5. perl t/db_dependent/Reserves.t\n6. Observe test pass\n\nSigned-off-by: Tomas Cohen Arazi <tomascohen@theke.io>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/246bca4a67b2ca177d4defb39284a3ede2a0703a"},{"sha":"91774fcf15cf8e3c2c6142d5ee646c1e8a06a7a2","author":{"name":"Tomas Cohen Arazi","email":"3994b2d5d879a5e517634211ed0f177149c452a1@theke.io"},"message":"Bug 17539: (QA followup) Silence warnings\n\nSigned-off-by: Tomas Cohen Arazi <tomascohen@theke.io>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/91774fcf15cf8e3c2c6142d5ee646c1e8a06a7a2"},{"sha":"4fd1f3e48ea103d1656adebe70d9c9672f7217f7","author":{"name":"Marcel de Rooy","email":"7eab020898e2d4d9802958d4ce1ff45d78acfe54@rijksmuseum.nl"},"message":"Bug 17539: [QA Follow-up] Move handle after schema\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/4fd1f3e48ea103d1656adebe70d9c9672f7217f7"},{"sha":"ed932be618da24b226cd6404eb2f526886dbd781","author":{"name":"Kyle M Hall","email":"d0ff38e6f73256704c61d16b0f8fbefe41e0c8dc@bywatersolutions.com"},"message":"Bug 16493: acq matching on title and author\n\nWhen you order from a staged file you're getting duplicate warnings that\nare inaccurate.  For example, when you order a file of 50 DVDs for\nexample and they don't have ISBNs they're matching on the books. And\nthen you have to order them one by one.\n\nThis patch replaces the use of FindDuplicates with Koha's match point\nsystem. This means you can select from the same match points defined\nand used in the batch record importer, or you can opt to skip matching\naltogether!\n\nTest Plan:\n1) Import a record with a title, isbn and author.\n2) Delete the from the record and stage it again\n3) Attempt to add it to a basket via the staged record\n4) You should note the gives you the \"No records imported\" message\n5) Apply this patch\n6) Create a matcher for ISBN\n7) Create a matcher for Author/Title\n8) Attempt to add the record to your basket using the ISBN matcher\n8) Koha should find no match and import the record to the basket\n9) Stage the record again\n10) Attempt to add the record to your basket using the Title/Author matcher\n11) You should recieve the \"No records imported\" message.\n\nSigned-off-by: Barbara Fondren <bfondren@roundrocktexas.gov>\n\nSigned-off-by: Nicole C Engard <nengard@bywatersolutions.com>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@theke.io>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/ed932be618da24b226cd6404eb2f526886dbd781"},{"sha":"43c6850269d7bc28ec339ccab780592fb306ac4d","author":{"name":"Kyle M Hall","email":"d0ff38e6f73256704c61d16b0f8fbefe41e0c8dc@bywatersolutions.com"},"message":"Bug 16493: [QA Followup] Restore title and author match as an option, make it the default\n\nSigned-off-by: Tomas Cohen Arazi <tomascohen@theke.io>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/43c6850269d7bc28ec339ccab780592fb306ac4d"},{"sha":"df3a9105e843d8f41abb85b7a1416f538f2896e2","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 17494: Make sure the same verification token won't be generated twice\n\nWell, this patch does not enforce the unique constraint but mimic what\nis already done in C4::ImportExportFramework and Koha::Upload where\nmd5_hex is used.\n\nTest plan:\nHave a look at the code and confirm that it adds more randomness to the\nhashed string\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@biblibre.com>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@theke.io>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/df3a9105e843d8f41abb85b7a1416f538f2896e2"},{"sha":"f6148ab777b2231cb047f54677d8d716954b062a","author":{"name":"Kyle M Hall","email":"d0ff38e6f73256704c61d16b0f8fbefe41e0c8dc@bywatersolutions.com"},"message":"Bug 17494: Prevent duplicate tokens from getting stored\n\nSigned-off-by: Jonathan Druart <jonathan.druart@biblibre.com>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@theke.io>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/f6148ab777b2231cb047f54677d8d716954b062a"},{"sha":"9427edc2f6ae268f2af65c21b6b7850b31f35358","author":{"name":"Tomas Cohen Arazi","email":"3994b2d5d879a5e517634211ed0f177149c452a1@theke.io"},"message":"Bug 17494: (QA followup) Fix exception name\n\nThis patch changes the exception name to match the package name. And\nalso adds a test for the thrown exception message.\n\nAlso creates a general Koha::Exception::Patron::Modification exception\nto make the new one inherit from it, following the common use in the codebase.\n\nSigned-off-by: Tomas Cohen Arazi <tomascohen@theke.io>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/9427edc2f6ae268f2af65c21b6b7850b31f35358"},{"sha":"22770166205401f030b2feeafae2e8f9f6189339","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 12633: Remove export line\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/22770166205401f030b2feeafae2e8f9f6189339"},{"sha":"b2c59c7ff248597aefc9043bc2aa4547938c82b5","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 16908: Remove non-desired export line\n\nGetTitles has been removed by bug 16847 and reintroduced it by bug\n16908, caused by a bad merge conflict.\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/b2c59c7ff248597aefc9043bc2aa4547938c82b5"},{"sha":"9e82c921a6a5d43323535393d1b5006c12535eba","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 17548: Fix step 1 of memberentry\n\nThis bug has been highlighted by bug 15407.\n\nThe date limit check on the category code did not work on step 1. But\nafter bug 15407 the script crashes with\n  Can't call method \"dateofbirthrequired\" on an undefined value at\n  /home/vagrant/kohaclone/members/memberentry.pl line 311.\n\nTest plan:\n- Edit \"step 1\" information of a patron (first 'Edit' on a patron detail\npage).\n- Save\n=> Without this patch it BOOMs\n=> With this patch, the info should be correctly saved\n\nSigned-off-by: Josef Moravec <josef.moravec@gmail.com>\n\nSigned-off-by: Katrin Fischer  <katrin.fischer@bsz-bw.de>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/9e82c921a6a5d43323535393d1b5006c12535eba"},{"sha":"7e0f372b6c63778ad7a234e467d30303094f07e4","author":{"name":"Matthias Meusburger","email":"8a97f0753d52a3d469975456a208e3e97d219eac@biblibre.com"},"message":"Bug 17481: Fix incorrect merge of bug 11048 (logout redirection for CAS authentication)\n\nSigned-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/7e0f372b6c63778ad7a234e467d30303094f07e4"},{"sha":"8eec57d605b379694927ef344f9a8c302a7b05d7","author":{"name":"Jonathan Druart","email":"b8e3b888c23b54255e26fdc644fc18f5231e8886@bugs.koha-community.org"},"message":"Bug 17476: Add a way to bypass dt_from_string processing time for slow servers\n\nWe already change this value from 1 to 2 but apparently it's not enough\nSo let's switch it back to on and add a flag (env var SLOW_SERVER) and skip these tests\nif set\n\nTest plan:\n  prove t/DateUtils.t\nand\n  SLOW_SERVER=1 prove t/DateUtils.t\n\nshould return green\n\nSigned-off-by: Mirko Tietgen <mirko@abunchofthings.net>\n\nSigned-off-by: Katrin Fischer  <katrin.fischer@bsz-bw.de>\n\nSigned-off-by: Kyle M Hall <kyle@bywatersolutions.com>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/8eec57d605b379694927ef344f9a8c302a7b05d7"}]}
{"actor":{"display_login":"fredericd"}}