{"action":"closed","number":21,"pull_request":{"url":"https://api.github.com/repos/googleapis/gax-ruby/pulls/21","id":71267441,"html_url":"https://github.com/googleapis/gax-ruby/pull/21","diff_url":"https://github.com/googleapis/gax-ruby/pull/21.diff","patch_url":"https://github.com/googleapis/gax-ruby/pull/21.patch","issue_url":"https://api.github.com/repos/googleapis/gax-ruby/issues/21","number":21,"state":"closed","locked":false,"title":"Update handling of errors.","user":{"login":"jmuk","id":816093,"avatar_url":"https://avatars.githubusercontent.com/u/816093?v=3","gravatar_id":"","url":"https://api.github.com/users/jmuk","html_url":"https://github.com/jmuk","followers_url":"https://api.github.com/users/jmuk/followers","following_url":"https://api.github.com/users/jmuk/following{/other_user}","gists_url":"https://api.github.com/users/jmuk/gists{/gist_id}","starred_url":"https://api.github.com/users/jmuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmuk/subscriptions","organizations_url":"https://api.github.com/users/jmuk/orgs","repos_url":"https://api.github.com/users/jmuk/repos","events_url":"https://api.github.com/users/jmuk/events{/privacy}","received_events_url":"https://api.github.com/users/jmuk/received_events","type":"User","site_admin":false},"body":"The core part of this patch is to remove 'cause' attribute\r\nfrom GaxError. Actually Ruby Exception already has such method\r\nfrom 2.1.0, and $ERROR_INFO contains the previous exception\r\n(or cause) for an exception.\r\n\r\nAs the consequence of this redesign, we will have to raise the\r\nRetryError inside of rescue clause (otherwise $ERROR_INFO is\r\nnot set), and therefore retryable is now an infinite loop.\r\n\r\nAlso removed an unnecessary if-clause for catching errors,\r\ninstead bringing them into the matcher of rescue clause.\r\n\r\nAnd fix some other lint errors:\r\n- raise Error.new(msg) => raise Error, msg -- recommended\r\n  style from rubocop.\r\n- avoid using raise msg -- from internal feedback\r\n- fix some typos\r\n\r\nfixes #16","created_at":"2016-05-24T18:14:22Z","updated_at":"2016-05-24T22:39:44Z","closed_at":"2016-05-24T22:39:44Z","merged_at":"2016-05-24T22:39:44Z","merge_commit_sha":"df861d03fd14483342937baffaee791aa2244750","assignee":{"login":"geigerj","id":14222439,"avatar_url":"https://avatars.githubusercontent.com/u/14222439?v=3","gravatar_id":"","url":"https://api.github.com/users/geigerj","html_url":"https://github.com/geigerj","followers_url":"https://api.github.com/users/geigerj/followers","following_url":"https://api.github.com/users/geigerj/following{/other_user}","gists_url":"https://api.github.com/users/geigerj/gists{/gist_id}","starred_url":"https://api.github.com/users/geigerj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geigerj/subscriptions","organizations_url":"https://api.github.com/users/geigerj/orgs","repos_url":"https://api.github.com/users/geigerj/repos","events_url":"https://api.github.com/users/geigerj/events{/privacy}","received_events_url":"https://api.github.com/users/geigerj/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/gax-ruby/pulls/21/commits","review_comments_url":"https://api.github.com/repos/googleapis/gax-ruby/pulls/21/comments","review_comment_url":"https://api.github.com/repos/googleapis/gax-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/gax-ruby/issues/21/comments","statuses_url":"https://api.github.com/repos/googleapis/gax-ruby/statuses/4d7bcbbd418f6479e4599c9b9883c44cad4daad8","head":{"label":"jmuk:errors","ref":"errors","sha":"4d7bcbbd418f6479e4599c9b9883c44cad4daad8","user":{"login":"jmuk","id":816093,"avatar_url":"https://avatars.githubusercontent.com/u/816093?v=3","gravatar_id":"","url":"https://api.github.com/users/jmuk","html_url":"https://github.com/jmuk","followers_url":"https://api.github.com/users/jmuk/followers","following_url":"https://api.github.com/users/jmuk/following{/other_user}","gists_url":"https://api.github.com/users/jmuk/gists{/gist_id}","starred_url":"https://api.github.com/users/jmuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmuk/subscriptions","organizations_url":"https://api.github.com/users/jmuk/orgs","repos_url":"https://api.github.com/users/jmuk/repos","events_url":"https://api.github.com/users/jmuk/events{/privacy}","received_events_url":"https://api.github.com/users/jmuk/received_events","type":"User","site_admin":false},"repo":{"id":57165899,"name":"gax-ruby","full_name":"jmuk/gax-ruby","owner":{"login":"jmuk","id":816093,"avatar_url":"https://avatars.githubusercontent.com/u/816093?v=3","gravatar_id":"","url":"https://api.github.com/users/jmuk","html_url":"https://github.com/jmuk","followers_url":"https://api.github.com/users/jmuk/followers","following_url":"https://api.github.com/users/jmuk/following{/other_user}","gists_url":"https://api.github.com/users/jmuk/gists{/gist_id}","starred_url":"https://api.github.com/users/jmuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmuk/subscriptions","organizations_url":"https://api.github.com/users/jmuk/orgs","repos_url":"https://api.github.com/users/jmuk/repos","events_url":"https://api.github.com/users/jmuk/events{/privacy}","received_events_url":"https://api.github.com/users/jmuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmuk/gax-ruby","description":"","fork":true,"url":"https://api.github.com/repos/jmuk/gax-ruby","forks_url":"https://api.github.com/repos/jmuk/gax-ruby/forks","keys_url":"https://api.github.com/repos/jmuk/gax-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmuk/gax-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmuk/gax-ruby/teams","hooks_url":"https://api.github.com/repos/jmuk/gax-ruby/hooks","issue_events_url":"https://api.github.com/repos/jmuk/gax-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/jmuk/gax-ruby/events","assignees_url":"https://api.github.com/repos/jmuk/gax-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/jmuk/gax-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/jmuk/gax-ruby/tags","blobs_url":"https://api.github.com/repos/jmuk/gax-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmuk/gax-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmuk/gax-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmuk/gax-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmuk/gax-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/jmuk/gax-ruby/languages","stargazers_url":"https://api.github.com/repos/jmuk/gax-ruby/stargazers","contributors_url":"https://api.github.com/repos/jmuk/gax-ruby/contributors","subscribers_url":"https://api.github.com/repos/jmuk/gax-ruby/subscribers","subscription_url":"https://api.github.com/repos/jmuk/gax-ruby/subscription","commits_url":"https://api.github.com/repos/jmuk/gax-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmuk/gax-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmuk/gax-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmuk/gax-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmuk/gax-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/jmuk/gax-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmuk/gax-ruby/merges","archive_url":"https://api.github.com/repos/jmuk/gax-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmuk/gax-ruby/downloads","issues_url":"https://api.github.com/repos/jmuk/gax-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/jmuk/gax-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/jmuk/gax-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/jmuk/gax-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmuk/gax-ruby/labels{/name}","releases_url":"https://api.github.com/repos/jmuk/gax-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/jmuk/gax-ruby/deployments","created_at":"2016-04-26T22:22:22Z","updated_at":"2016-04-26T22:22:24Z","pushed_at":"2016-05-24T22:18:24Z","git_url":"git://github.com/jmuk/gax-ruby.git","ssh_url":"git@github.com:jmuk/gax-ruby.git","clone_url":"https://github.com/jmuk/gax-ruby.git","svn_url":"https://github.com/jmuk/gax-ruby","homepage":null,"size":90,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"b89c4e867bcc23cdd4583318cd3b66f30a7db887","user":{"login":"googleapis","id":16785467,"avatar_url":"https://avatars.githubusercontent.com/u/16785467?v=3","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":57153681,"name":"gax-ruby","full_name":"googleapis/gax-ruby","owner":{"login":"googleapis","id":16785467,"avatar_url":"https://avatars.githubusercontent.com/u/16785467?v=3","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googleapis/gax-ruby","description":"Google API Extensions for Ruby","fork":false,"url":"https://api.github.com/repos/googleapis/gax-ruby","forks_url":"https://api.github.com/repos/googleapis/gax-ruby/forks","keys_url":"https://api.github.com/repos/googleapis/gax-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/gax-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/gax-ruby/teams","hooks_url":"https://api.github.com/repos/googleapis/gax-ruby/hooks","issue_events_url":"https://api.github.com/repos/googleapis/gax-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/gax-ruby/events","assignees_url":"https://api.github.com/repos/googleapis/gax-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/gax-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/gax-ruby/tags","blobs_url":"https://api.github.com/repos/googleapis/gax-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/gax-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/gax-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/gax-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/gax-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/gax-ruby/languages","stargazers_url":"https://api.github.com/repos/googleapis/gax-ruby/stargazers","contributors_url":"https://api.github.com/repos/googleapis/gax-ruby/contributors","subscribers_url":"https://api.github.com/repos/googleapis/gax-ruby/subscribers","subscription_url":"https://api.github.com/repos/googleapis/gax-ruby/subscription","commits_url":"https://api.github.com/repos/googleapis/gax-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/gax-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/gax-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/gax-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/gax-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/gax-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/gax-ruby/merges","archive_url":"https://api.github.com/repos/googleapis/gax-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/gax-ruby/downloads","issues_url":"https://api.github.com/repos/googleapis/gax-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/gax-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/gax-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/gax-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/gax-ruby/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/gax-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/gax-ruby/deployments","created_at":"2016-04-26T18:50:48Z","updated_at":"2016-05-11T00:05:50Z","pushed_at":"2016-05-24T22:39:44Z","git_url":"git://github.com/googleapis/gax-ruby.git","ssh_url":"git@github.com:googleapis/gax-ruby.git","clone_url":"https://github.com/googleapis/gax-ruby.git","svn_url":"https://github.com/googleapis/gax-ruby","homepage":"https://rubygems.org/gems/google-gax","size":84,"stargazers_count":11,"watchers_count":11,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/gax-ruby/pulls/21"},"html":{"href":"https://github.com/googleapis/gax-ruby/pull/21"},"issue":{"href":"https://api.github.com/repos/googleapis/gax-ruby/issues/21"},"comments":{"href":"https://api.github.com/repos/googleapis/gax-ruby/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/gax-ruby/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/gax-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/gax-ruby/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/gax-ruby/statuses/4d7bcbbd418f6479e4599c9b9883c44cad4daad8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jmuk","id":816093,"avatar_url":"https://avatars.githubusercontent.com/u/816093?v=3","gravatar_id":"","url":"https://api.github.com/users/jmuk","html_url":"https://github.com/jmuk","followers_url":"https://api.github.com/users/jmuk/followers","following_url":"https://api.github.com/users/jmuk/following{/other_user}","gists_url":"https://api.github.com/users/jmuk/gists{/gist_id}","starred_url":"https://api.github.com/users/jmuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmuk/subscriptions","organizations_url":"https://api.github.com/users/jmuk/orgs","repos_url":"https://api.github.com/users/jmuk/repos","events_url":"https://api.github.com/users/jmuk/events{/privacy}","received_events_url":"https://api.github.com/users/jmuk/received_events","type":"User","site_admin":false},"comments":2,"review_comments":2,"commits":3,"additions":73,"deletions":31,"changed_files":6}}
{"actor":{"display_login":"jmuk"}}