{"action":"created","issue":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/268","repository_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X","labels_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/268/labels{/name}","comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/268/comments","events_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/268/events","html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/issues/268","id":145982996,"number":268,"title":"Where should submit buttons be?","user":{"login":"jniles","id":896472,"avatar_url":"https://avatars.githubusercontent.com/u/896472?v=3","gravatar_id":"","url":"https://api.github.com/users/jniles","html_url":"https://github.com/jniles","followers_url":"https://api.github.com/users/jniles/followers","following_url":"https://api.github.com/users/jniles/following{/other_user}","gists_url":"https://api.github.com/users/jniles/gists{/gist_id}","starred_url":"https://api.github.com/users/jniles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jniles/subscriptions","organizations_url":"https://api.github.com/users/jniles/orgs","repos_url":"https://api.github.com/users/jniles/repos","events_url":"https://api.github.com/users/jniles/events{/privacy}","received_events_url":"https://api.github.com/users/jniles/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/labels/design","name":"design","color":"f7c6c7"},{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/labels/needs%20discussion","name":"needs discussion","color":"eb6420"},{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/milestones/1","html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/milestones/2.x%20Process","labels_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/milestones/1/labels","id":1661435,"number":1,"title":"2.x Process","description":"Any design or code referenced by the 2.x completion review process.","creator":{"login":"sfount","id":2844572,"avatar_url":"https://avatars.githubusercontent.com/u/2844572?v=3","gravatar_id":"","url":"https://api.github.com/users/sfount","html_url":"https://github.com/sfount","followers_url":"https://api.github.com/users/sfount/followers","following_url":"https://api.github.com/users/sfount/following{/other_user}","gists_url":"https://api.github.com/users/sfount/gists{/gist_id}","starred_url":"https://api.github.com/users/sfount/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfount/subscriptions","organizations_url":"https://api.github.com/users/sfount/orgs","repos_url":"https://api.github.com/users/sfount/repos","events_url":"https://api.github.com/users/sfount/events{/privacy}","received_events_url":"https://api.github.com/users/sfount/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":21,"state":"open","created_at":"2016-03-23T07:38:02Z","updated_at":"2016-04-05T14:40:05Z","due_on":"2016-04-23T23:00:00Z","closed_at":null},"comments":3,"created_at":"2016-04-05T13:08:07Z","updated_at":"2016-04-05T14:58:34Z","closed_at":null,"body":"In bhima-1.x, and so far in 2.x, we have unpredictable button placement.  Here are some sample forms/modals in 2.x.\r\n\r\n**Journal Vouchers**\r\n![rightsubmitbutton1](https://cloud.githubusercontent.com/assets/896472/14282541/bc3a0a7c-fb36-11e5-8a51-5b0b96f8fefc.png)\r\n**Patient Registration**\r\n![patientregistrationsubmitbuttons](https://cloud.githubusercontent.com/assets/896472/14282559/d33eb1c8-fb36-11e5-8dc7-b57533ff5c5a.png)\r\n**Cash Window**\r\n![cashsubmitbtn](https://cloud.githubusercontent.com/assets/896472/14282665/4b519d6a-fb37-11e5-9c49-5083518e7fce.png)\r\n**Confirm Modal**\r\n![modalsubmitbutton](https://cloud.githubusercontent.com/assets/896472/14282543/bc8bd582-fb36-11e5-8cf1-a5126a1fbcfb.png)\r\n**Location Modal**\r\n![locationmodalsubmitbuttons](https://cloud.githubusercontent.com/assets/896472/14282542/bc89560e-fb36-11e5-8ed4-484463eefdc4.png)\r\n**Transfer Modal**\r\n![transfermodalsubmitbtn](https://cloud.githubusercontent.com/assets/896472/14282678/5aacae8a-fb37-11e5-9084-0c6f39653ad7.png)\r\n\r\n##### Questions\r\n 1. Where should the submit buttons be placed?  On the right or the left hand side of the form?  What about for a modal?\r\n 2. Where should the \"Submit\" button be placed if there is a \"Cancel\" button as well?  On the left or the right hand side of the \"Cancel\" button?\r\n 3. Should the buttons be placed differently depending on where the form is on the page?  For example, if a form is on the left side of the module, should the buttons be on the right side of the form, but if the form is on the right, the buttons be placed on the left?  Or is that too confusing?\r\n 4.  Should submit/cancel buttons be placed in a `panel-footer` or the `panel-body`?\r\n\r\ncc/ @IMA-WorldHealth/local-contributors "},"comment":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/comments/205845792","html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/issues/268#issuecomment-205845792","issue_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/268","id":205845792,"user":{"login":"jniles","id":896472,"avatar_url":"https://avatars.githubusercontent.com/u/896472?v=3","gravatar_id":"","url":"https://api.github.com/users/jniles","html_url":"https://github.com/jniles","followers_url":"https://api.github.com/users/jniles/followers","following_url":"https://api.github.com/users/jniles/following{/other_user}","gists_url":"https://api.github.com/users/jniles/gists{/gist_id}","starred_url":"https://api.github.com/users/jniles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jniles/subscriptions","organizations_url":"https://api.github.com/users/jniles/orgs","repos_url":"https://api.github.com/users/jniles/repos","events_url":"https://api.github.com/users/jniles/events{/privacy}","received_events_url":"https://api.github.com/users/jniles/received_events","type":"User","site_admin":false},"created_at":"2016-04-05T14:58:34Z","updated_at":"2016-04-05T14:58:34Z","body":"@imawh, @sfount, thanks for the feedback!\r\n\r\nIt sounds like the consensus is this:\r\n 1. Buttons should be floated to the right of any container - form or modal.\r\n 2. The \"action\" button (submit, confirm, ok, etc) should be far right, and any other buttons (cancel, close. etc) can be stacked to the left of them.\r\n\r\nWith our new CSS application structure, we've been pretty good at getting things to render on the smallest screen we can emulate in the Chrome DevTools.  Should be fine there!"}}