{"action":"closed","number":29,"pull_request":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/29","id":37586382,"html_url":"https://github.com/ckeditor/ckeditor5-engine/pull/29","diff_url":"https://github.com/ckeditor/ckeditor5-engine/pull/29.diff","patch_url":"https://github.com/ckeditor/ckeditor5-engine/pull/29.patch","issue_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/29","number":29,"state":"closed","locked":false,"title":"t/21: Made fire() return a promise.","user":{"login":"fredck","id":630060,"avatar_url":"https://avatars.githubusercontent.com/u/630060?v=3","gravatar_id":"","url":"https://api.github.com/users/fredck","html_url":"https://github.com/fredck","followers_url":"https://api.github.com/users/fredck/followers","following_url":"https://api.github.com/users/fredck/following{/other_user}","gists_url":"https://api.github.com/users/fredck/gists{/gist_id}","starred_url":"https://api.github.com/users/fredck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredck/subscriptions","organizations_url":"https://api.github.com/users/fredck/orgs","repos_url":"https://api.github.com/users/fredck/repos","events_url":"https://api.github.com/users/fredck/events{/privacy}","received_events_url":"https://api.github.com/users/fredck/received_events","type":"User","site_admin":false},"body":"Fixes #21.\r\n\r\n`fire()`is now a synch/asynch hybrid. It is synchronous when all listeners are synchronous and asynchronous if any of them return a promise.","created_at":"2015-06-12T17:32:09Z","updated_at":"2016-04-08T14:10:48Z","closed_at":"2016-04-08T14:10:48Z","merged_at":null,"merge_commit_sha":"2c11a23c45cc33199c74d6a2c895d8a7b64a079b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/29/commits","review_comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/29/comments","review_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/29/comments","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/b1cd3f147eacc412128938e9bf3591e76617248f","head":{"label":"cksource:t/21","ref":"t/21","sha":"b1cd3f147eacc412128938e9bf3591e76617248f","user":{"login":"cksource","id":825698,"avatar_url":"https://avatars.githubusercontent.com/u/825698?v=3","gravatar_id":"","url":"https://api.github.com/users/cksource","html_url":"https://github.com/cksource","followers_url":"https://api.github.com/users/cksource/followers","following_url":"https://api.github.com/users/cksource/following{/other_user}","gists_url":"https://api.github.com/users/cksource/gists{/gist_id}","starred_url":"https://api.github.com/users/cksource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cksource/subscriptions","organizations_url":"https://api.github.com/users/cksource/orgs","repos_url":"https://api.github.com/users/cksource/repos","events_url":"https://api.github.com/users/cksource/events{/privacy}","received_events_url":"https://api.github.com/users/cksource/received_events","type":"Organization","site_admin":false},"repo":{"id":29292185,"name":"ckeditor5-core","full_name":"cksource/ckeditor5-core","owner":{"login":"cksource","id":825698,"avatar_url":"https://avatars.githubusercontent.com/u/825698?v=3","gravatar_id":"","url":"https://api.github.com/users/cksource","html_url":"https://github.com/cksource","followers_url":"https://api.github.com/users/cksource/followers","following_url":"https://api.github.com/users/cksource/following{/other_user}","gists_url":"https://api.github.com/users/cksource/gists{/gist_id}","starred_url":"https://api.github.com/users/cksource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cksource/subscriptions","organizations_url":"https://api.github.com/users/cksource/orgs","repos_url":"https://api.github.com/users/cksource/repos","events_url":"https://api.github.com/users/cksource/events{/privacy}","received_events_url":"https://api.github.com/users/cksource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cksource/ckeditor5-core","description":"CKEditor 5 Core Framework.","fork":true,"url":"https://api.github.com/repos/cksource/ckeditor5-core","forks_url":"https://api.github.com/repos/cksource/ckeditor5-core/forks","keys_url":"https://api.github.com/repos/cksource/ckeditor5-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cksource/ckeditor5-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cksource/ckeditor5-core/teams","hooks_url":"https://api.github.com/repos/cksource/ckeditor5-core/hooks","issue_events_url":"https://api.github.com/repos/cksource/ckeditor5-core/issues/events{/number}","events_url":"https://api.github.com/repos/cksource/ckeditor5-core/events","assignees_url":"https://api.github.com/repos/cksource/ckeditor5-core/assignees{/user}","branches_url":"https://api.github.com/repos/cksource/ckeditor5-core/branches{/branch}","tags_url":"https://api.github.com/repos/cksource/ckeditor5-core/tags","blobs_url":"https://api.github.com/repos/cksource/ckeditor5-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cksource/ckeditor5-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cksource/ckeditor5-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cksource/ckeditor5-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cksource/ckeditor5-core/statuses/{sha}","languages_url":"https://api.github.com/repos/cksource/ckeditor5-core/languages","stargazers_url":"https://api.github.com/repos/cksource/ckeditor5-core/stargazers","contributors_url":"https://api.github.com/repos/cksource/ckeditor5-core/contributors","subscribers_url":"https://api.github.com/repos/cksource/ckeditor5-core/subscribers","subscription_url":"https://api.github.com/repos/cksource/ckeditor5-core/subscription","commits_url":"https://api.github.com/repos/cksource/ckeditor5-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cksource/ckeditor5-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cksource/ckeditor5-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cksource/ckeditor5-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cksource/ckeditor5-core/contents/{+path}","compare_url":"https://api.github.com/repos/cksource/ckeditor5-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cksource/ckeditor5-core/merges","archive_url":"https://api.github.com/repos/cksource/ckeditor5-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cksource/ckeditor5-core/downloads","issues_url":"https://api.github.com/repos/cksource/ckeditor5-core/issues{/number}","pulls_url":"https://api.github.com/repos/cksource/ckeditor5-core/pulls{/number}","milestones_url":"https://api.github.com/repos/cksource/ckeditor5-core/milestones{/number}","notifications_url":"https://api.github.com/repos/cksource/ckeditor5-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cksource/ckeditor5-core/labels{/name}","releases_url":"https://api.github.com/repos/cksource/ckeditor5-core/releases{/id}","deployments_url":"https://api.github.com/repos/cksource/ckeditor5-core/deployments","created_at":"2015-01-15T10:25:18Z","updated_at":"2015-01-15T10:25:18Z","pushed_at":"2016-01-29T10:02:13Z","git_url":"git://github.com/cksource/ckeditor5-core.git","ssh_url":"git@github.com:cksource/ckeditor5-core.git","clone_url":"https://github.com/cksource/ckeditor5-core.git","svn_url":"https://github.com/cksource/ckeditor5-core","homepage":null,"size":577,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ckeditor:master","ref":"master","sha":"3c89722163ed3749c37f062b3d7cecdb0add9b78","user":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars.githubusercontent.com/u/825710?v=3","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":28972890,"name":"ckeditor5-engine","full_name":"ckeditor/ckeditor5-engine","owner":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars.githubusercontent.com/u/825710?v=3","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor5-engine","description":"CKEditor 5 Editing Engine","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor5-engine","forks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor5-engine/deployments","created_at":"2015-01-08T15:47:45Z","updated_at":"2016-03-25T14:21:19Z","pushed_at":"2016-04-08T13:58:35Z","git_url":"git://github.com/ckeditor/ckeditor5-engine.git","ssh_url":"git@github.com:ckeditor/ckeditor5-engine.git","clone_url":"https://github.com/ckeditor/ckeditor5-engine.git","svn_url":"https://github.com/ckeditor/ckeditor5-engine","homepage":"","size":2366,"stargazers_count":25,"watchers_count":25,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":48,"forks":16,"open_issues":48,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/29"},"html":{"href":"https://github.com/ckeditor/ckeditor5-engine/pull/29"},"issue":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/29"},"comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-engine/statuses/b1cd3f147eacc412128938e9bf3591e76617248f"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":80,"deletions":10,"changed_files":2}}