{"action":"created","issue":{"url":"https://api.github.com/repos/jonhoo/vast-vmap/issues/35","repository_url":"https://api.github.com/repos/jonhoo/vast-vmap","labels_url":"https://api.github.com/repos/jonhoo/vast-vmap/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/jonhoo/vast-vmap/issues/35/comments","events_url":"https://api.github.com/repos/jonhoo/vast-vmap/issues/35/events","html_url":"https://github.com/jonhoo/vast-vmap/pull/35","id":136986739,"number":35,"title":"Support aborting further VAST queries after unwrapping `X` wrappers.","user":{"login":"sterpe","id":678398,"avatar_url":"https://avatars.githubusercontent.com/u/678398?v=3","gravatar_id":"","url":"https://api.github.com/users/sterpe","html_url":"https://github.com/sterpe","followers_url":"https://api.github.com/users/sterpe/followers","following_url":"https://api.github.com/users/sterpe/following{/other_user}","gists_url":"https://api.github.com/users/sterpe/gists{/gist_id}","starred_url":"https://api.github.com/users/sterpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sterpe/subscriptions","organizations_url":"https://api.github.com/users/sterpe/orgs","repos_url":"https://api.github.com/users/sterpe/repos","events_url":"https://api.github.com/users/sterpe/events{/privacy}","received_events_url":"https://api.github.com/users/sterpe/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2016-02-28T00:37:04Z","updated_at":"2016-03-02T20:01:04Z","closed_at":"2016-03-02T20:00:46Z","pull_request":{"url":"https://api.github.com/repos/jonhoo/vast-vmap/pulls/35","html_url":"https://github.com/jonhoo/vast-vmap/pull/35","diff_url":"https://github.com/jonhoo/vast-vmap/pull/35.diff","patch_url":"https://github.com/jonhoo/vast-vmap/pull/35.patch"},"body":"Tried to avoid changing the existing API.  \r\n\r\nA `VASTAd` object now gets a property `abortLimit` which is always -1 of it's `parentAd`, if it has one.  `queryVAST` fn will cancel the next `fetchXML` call when the `parentAd`'s `abortLimit` is zero (`0`) and immediately call the `onError` callback.  The default abort limit is set in `VAST_VMAP_XHROptions.defaultVASTAbortLimit`.   Setting this limit to `-1`, the default, implies that there is no limit, the current behavior.  Don't set to `0` as weirdness may occur.\r\n\r\n++ Unit tests covering both cases -- 2 depth wrappers, with the limit set at -1, and 1, respectively.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/jonhoo/vast-vmap/issues/comments/191402259","html_url":"https://github.com/jonhoo/vast-vmap/pull/35#issuecomment-191402259","issue_url":"https://api.github.com/repos/jonhoo/vast-vmap/issues/35","id":191402259,"user":{"login":"jonhoo","id":176295,"avatar_url":"https://avatars.githubusercontent.com/u/176295?v=3","gravatar_id":"","url":"https://api.github.com/users/jonhoo","html_url":"https://github.com/jonhoo","followers_url":"https://api.github.com/users/jonhoo/followers","following_url":"https://api.github.com/users/jonhoo/following{/other_user}","gists_url":"https://api.github.com/users/jonhoo/gists{/gist_id}","starred_url":"https://api.github.com/users/jonhoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonhoo/subscriptions","organizations_url":"https://api.github.com/users/jonhoo/orgs","repos_url":"https://api.github.com/users/jonhoo/repos","events_url":"https://api.github.com/users/jonhoo/events{/privacy}","received_events_url":"https://api.github.com/users/jonhoo/received_events","type":"User","site_admin":false},"created_at":"2016-03-02T20:01:03Z","updated_at":"2016-03-02T20:01:03Z","body":"Fair enough. We don't really need the warnings in Buster anyway. Thanks for the PR!"}}