{"action":"created","comment":{"url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/pulls/comments/86986538","pull_request_review_id":7616041,"id":86986538,"diff_hunk":"@@ -0,0 +1,35 @@\n+import requests\n+import json\n+from ipersonclient import IPersonClient\n+\n+class PersonClient(IPersonClient):\n+    def get_all(self):\n+        response = self._get(self._build_url('people'))\n+        items = response.json()['data']\n+        return items\n+\n+\n+    def get_by_name(self, person_name):\n+        people = self.get_people()","path":"src/python/datapreprocessor/datapreprocessor/personclient.py","position":13,"original_position":13,"commit_id":"ea76dd2e09bebd10beea26e5329143ecdc79b92e","original_commit_id":"ea76dd2e09bebd10beea26e5329143ecdc79b92e","user":{"login":"jo-osborne","id":2361883,"avatar_url":"https://avatars.githubusercontent.com/u/2361883?v=3","gravatar_id":"","url":"https://api.github.com/users/jo-osborne","html_url":"https://github.com/jo-osborne","followers_url":"https://api.github.com/users/jo-osborne/followers","following_url":"https://api.github.com/users/jo-osborne/following{/other_user}","gists_url":"https://api.github.com/users/jo-osborne/gists{/gist_id}","starred_url":"https://api.github.com/users/jo-osborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jo-osborne/subscriptions","organizations_url":"https://api.github.com/users/jo-osborne/orgs","repos_url":"https://api.github.com/users/jo-osborne/repos","events_url":"https://api.github.com/users/jo-osborne/events{/privacy}","received_events_url":"https://api.github.com/users/jo-osborne/received_events","type":"User","site_admin":false},"body":"Argh renaming fail! Will fix and update shortly :)","created_at":"2016-11-08T13:24:24Z","updated_at":"2016-11-08T13:24:24Z","html_url":"https://github.com/HackBrexit/MinistersUnderTheInfluence/pull/75#discussion_r86986538","pull_request_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/pulls/75","_links":{"self":{"href":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/pulls/comments/86986538"},"html":{"href":"https://github.com/HackBrexit/MinistersUnderTheInfluence/pull/75#discussion_r86986538"},"pull_request":{"href":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/pulls/75","id":92492465,"html_url":"https://github.com/HackBrexit/MinistersUnderTheInfluence/pull/75","diff_url":"https://github.com/HackBrexit/MinistersUnderTheInfluence/pull/75.diff","patch_url":"https://github.com/HackBrexit/MinistersUnderTheInfluence/pull/75.patch","issue_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/issues/75","number":75,"state":"open","locked":false,"title":"add person client","user":{"login":"jo-osborne","id":2361883,"avatar_url":"https://avatars.githubusercontent.com/u/2361883?v=3","gravatar_id":"","url":"https://api.github.com/users/jo-osborne","html_url":"https://github.com/jo-osborne","followers_url":"https://api.github.com/users/jo-osborne/followers","following_url":"https://api.github.com/users/jo-osborne/following{/other_user}","gists_url":"https://api.github.com/users/jo-osborne/gists{/gist_id}","starred_url":"https://api.github.com/users/jo-osborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jo-osborne/subscriptions","organizations_url":"https://api.github.com/users/jo-osborne/orgs","repos_url":"https://api.github.com/users/jo-osborne/repos","events_url":"https://api.github.com/users/jo-osborne/events{/privacy}","received_events_url":"https://api.github.com/users/jo-osborne/received_events","type":"User","site_admin":false},"body":"Each **Pull Request** should relate to a single feature, therefore a single **Issue**. The smaller the **Pull Request** the faster it can be reviewed & merged. It should not be merged by the author.\r\n\r\n## Issues to close\r\n\r\nFixes #62 \r\n\r\n## Notes\r\nThis PR adds a PersonClient. There are integration tests which run against a local copy of the meetings api (details on how to run have been added to the README). The tests verify that using the client you can:\r\n- Get a person, if person exists\r\n- Add person\r\n- Delete person\r\n\r\nAt present adding a person only requires a name. In future we can expand this as and when we have more information, e.g. wikipedia links.\r\n\r\nThere is an abstract class, IPersonClient, which can be used to ensure that future logic can be tested without having to run the meetings api locally.\r\n\r\n## Tasks\r\n\r\n* [ x] Documentation (inc. diagrams) - create/update accordingly\r\n\r\n","created_at":"2016-11-06T16:12:28Z","updated_at":"2016-11-08T13:24:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffd5f51c1c46aa335462579b47775c3fff0b0a8c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/pulls/75/commits","review_comments_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/pulls/75/comments","review_comment_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/issues/75/comments","statuses_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/statuses/ea76dd2e09bebd10beea26e5329143ecdc79b92e","head":{"label":"jo-osborne:add-person-client","ref":"add-person-client","sha":"ea76dd2e09bebd10beea26e5329143ecdc79b92e","user":{"login":"jo-osborne","id":2361883,"avatar_url":"https://avatars.githubusercontent.com/u/2361883?v=3","gravatar_id":"","url":"https://api.github.com/users/jo-osborne","html_url":"https://github.com/jo-osborne","followers_url":"https://api.github.com/users/jo-osborne/followers","following_url":"https://api.github.com/users/jo-osborne/following{/other_user}","gists_url":"https://api.github.com/users/jo-osborne/gists{/gist_id}","starred_url":"https://api.github.com/users/jo-osborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jo-osborne/subscriptions","organizations_url":"https://api.github.com/users/jo-osborne/orgs","repos_url":"https://api.github.com/users/jo-osborne/repos","events_url":"https://api.github.com/users/jo-osborne/events{/privacy}","received_events_url":"https://api.github.com/users/jo-osborne/received_events","type":"User","site_admin":false},"repo":{"id":68847029,"name":"MinistersUnderTheInfluence","full_name":"jo-osborne/MinistersUnderTheInfluence","owner":{"login":"jo-osborne","id":2361883,"avatar_url":"https://avatars.githubusercontent.com/u/2361883?v=3","gravatar_id":"","url":"https://api.github.com/users/jo-osborne","html_url":"https://github.com/jo-osborne","followers_url":"https://api.github.com/users/jo-osborne/followers","following_url":"https://api.github.com/users/jo-osborne/following{/other_user}","gists_url":"https://api.github.com/users/jo-osborne/gists{/gist_id}","starred_url":"https://api.github.com/users/jo-osborne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jo-osborne/subscriptions","organizations_url":"https://api.github.com/users/jo-osborne/orgs","repos_url":"https://api.github.com/users/jo-osborne/repos","events_url":"https://api.github.com/users/jo-osborne/events{/privacy}","received_events_url":"https://api.github.com/users/jo-osborne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jo-osborne/MinistersUnderTheInfluence","description":null,"fork":true,"url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence","forks_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/forks","keys_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/teams","hooks_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/hooks","issue_events_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/issues/events{/number}","events_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/events","assignees_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/assignees{/user}","branches_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/branches{/branch}","tags_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/tags","blobs_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/git/refs{/sha}","trees_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/statuses/{sha}","languages_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/languages","stargazers_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/stargazers","contributors_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/contributors","subscribers_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/subscribers","subscription_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/subscription","commits_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/commits{/sha}","git_commits_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/git/commits{/sha}","comments_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/comments{/number}","issue_comment_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/issues/comments{/number}","contents_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/contents/{+path}","compare_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/merges","archive_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/downloads","issues_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/issues{/number}","pulls_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/pulls{/number}","milestones_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/milestones{/number}","notifications_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/labels{/name}","releases_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/releases{/id}","deployments_url":"https://api.github.com/repos/jo-osborne/MinistersUnderTheInfluence/deployments","created_at":"2016-09-21T18:39:12Z","updated_at":"2016-09-21T18:39:13Z","pushed_at":"2016-11-06T16:08:07Z","git_url":"git://github.com/jo-osborne/MinistersUnderTheInfluence.git","ssh_url":"git@github.com:jo-osborne/MinistersUnderTheInfluence.git","clone_url":"https://github.com/jo-osborne/MinistersUnderTheInfluence.git","svn_url":"https://github.com/jo-osborne/MinistersUnderTheInfluence","homepage":null,"size":1084,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HackBrexit:master","ref":"master","sha":"c4e39db05d93a06bffba2a785123f110ba82d2f5","user":{"login":"HackBrexit","id":20437526,"avatar_url":"https://avatars.githubusercontent.com/u/20437526?v=3","gravatar_id":"","url":"https://api.github.com/users/HackBrexit","html_url":"https://github.com/HackBrexit","followers_url":"https://api.github.com/users/HackBrexit/followers","following_url":"https://api.github.com/users/HackBrexit/following{/other_user}","gists_url":"https://api.github.com/users/HackBrexit/gists{/gist_id}","starred_url":"https://api.github.com/users/HackBrexit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HackBrexit/subscriptions","organizations_url":"https://api.github.com/users/HackBrexit/orgs","repos_url":"https://api.github.com/users/HackBrexit/repos","events_url":"https://api.github.com/users/HackBrexit/events{/privacy}","received_events_url":"https://api.github.com/users/HackBrexit/received_events","type":"Organization","site_admin":false},"repo":{"id":64018709,"name":"MinistersUnderTheInfluence","full_name":"HackBrexit/MinistersUnderTheInfluence","owner":{"login":"HackBrexit","id":20437526,"avatar_url":"https://avatars.githubusercontent.com/u/20437526?v=3","gravatar_id":"","url":"https://api.github.com/users/HackBrexit","html_url":"https://github.com/HackBrexit","followers_url":"https://api.github.com/users/HackBrexit/followers","following_url":"https://api.github.com/users/HackBrexit/following{/other_user}","gists_url":"https://api.github.com/users/HackBrexit/gists{/gist_id}","starred_url":"https://api.github.com/users/HackBrexit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HackBrexit/subscriptions","organizations_url":"https://api.github.com/users/HackBrexit/orgs","repos_url":"https://api.github.com/users/HackBrexit/repos","events_url":"https://api.github.com/users/HackBrexit/events{/privacy}","received_events_url":"https://api.github.com/users/HackBrexit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HackBrexit/MinistersUnderTheInfluence","description":null,"fork":false,"url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence","forks_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/forks","keys_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/teams","hooks_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/hooks","issue_events_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/issues/events{/number}","events_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/events","assignees_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/assignees{/user}","branches_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/branches{/branch}","tags_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/tags","blobs_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/git/refs{/sha}","trees_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/statuses/{sha}","languages_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/languages","stargazers_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/stargazers","contributors_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/contributors","subscribers_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/subscribers","subscription_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/subscription","commits_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/commits{/sha}","git_commits_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/git/commits{/sha}","comments_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/comments{/number}","issue_comment_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/issues/comments{/number}","contents_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/contents/{+path}","compare_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/merges","archive_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/downloads","issues_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/issues{/number}","pulls_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/pulls{/number}","milestones_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/milestones{/number}","notifications_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/labels{/name}","releases_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/releases{/id}","deployments_url":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/deployments","created_at":"2016-07-23T14:02:09Z","updated_at":"2016-10-25T08:37:40Z","pushed_at":"2016-11-08T13:13:13Z","git_url":"git://github.com/HackBrexit/MinistersUnderTheInfluence.git","ssh_url":"git@github.com:HackBrexit/MinistersUnderTheInfluence.git","clone_url":"https://github.com/HackBrexit/MinistersUnderTheInfluence.git","svn_url":"https://github.com/HackBrexit/MinistersUnderTheInfluence","homepage":null,"size":1125,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":23,"forks":8,"open_issues":23,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/pulls/75"},"html":{"href":"https://github.com/HackBrexit/MinistersUnderTheInfluence/pull/75"},"issue":{"href":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/issues/75"},"comments":{"href":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/HackBrexit/MinistersUnderTheInfluence/statuses/ea76dd2e09bebd10beea26e5329143ecdc79b92e"}}}}
{"actor":{"display_login":"jo-osborne"}}