{"action":"closed","number":4344,"pull_request":{"url":"https://api.github.com/repos/jashkenas/coffeescript/pulls/4344","id":90499483,"html_url":"https://github.com/jashkenas/coffeescript/pull/4344","diff_url":"https://github.com/jashkenas/coffeescript/pull/4344.diff","patch_url":"https://github.com/jashkenas/coffeescript/pull/4344.patch","issue_url":"https://api.github.com/repos/jashkenas/coffeescript/issues/4344","number":4344,"state":"closed","locked":false,"title":"Properly set location for string tokens ending in a newline","user":{"login":"alangpierce","id":211605,"avatar_url":"https://avatars.githubusercontent.com/u/211605?v=3","gravatar_id":"","url":"https://api.github.com/users/alangpierce","html_url":"https://github.com/alangpierce","followers_url":"https://api.github.com/users/alangpierce/followers","following_url":"https://api.github.com/users/alangpierce/following{/other_user}","gists_url":"https://api.github.com/users/alangpierce/gists{/gist_id}","starred_url":"https://api.github.com/users/alangpierce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alangpierce/subscriptions","organizations_url":"https://api.github.com/users/alangpierce/orgs","repos_url":"https://api.github.com/users/alangpierce/repos","events_url":"https://api.github.com/users/alangpierce/events{/privacy}","received_events_url":"https://api.github.com/users/alangpierce/received_events","type":"User","site_admin":false},"body":"This is an upstream port of https://github.com/decaffeinate/coffeescript/pull/9\r\n\r\nThe existing logic for computing the end location of a string was to take the\r\nend of the string contents, then add the delimiter length to last_column. For\r\nexample, `\"\"\"abc\"\"\"` would have an end position three characters after the `c`.\r\nHowever, if a string ended in a newline, then the end location for the string\r\ncontents would be one line above the end location for the string, so the proper\r\nfix is to move the end location to the next line, not just to shift it to the\r\nright.\r\n\r\nThis avoids a bug where the location data would sometimes reference a\r\nnon-existent location (one past the end of its line). It fixes the AST location\r\ndata, although as far as I know, it never has caused correctness issues in the\r\nCoffeeScript output.","created_at":"2016-10-22T23:46:34Z","updated_at":"2016-10-23T07:41:46Z","closed_at":"2016-10-23T07:41:46Z","merged_at":"2016-10-23T07:41:46Z","merge_commit_sha":"6087c2c8fc7bc9b46bf3f17bb4759f641756ca71","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jashkenas/coffeescript/pulls/4344/commits","review_comments_url":"https://api.github.com/repos/jashkenas/coffeescript/pulls/4344/comments","review_comment_url":"https://api.github.com/repos/jashkenas/coffeescript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jashkenas/coffeescript/issues/4344/comments","statuses_url":"https://api.github.com/repos/jashkenas/coffeescript/statuses/a42fb61cf378432d770142e7da3d23732b2490e9","head":{"label":"alangpierce:upstream-fix-multiline-string-location","ref":"upstream-fix-multiline-string-location","sha":"a42fb61cf378432d770142e7da3d23732b2490e9","user":{"login":"alangpierce","id":211605,"avatar_url":"https://avatars.githubusercontent.com/u/211605?v=3","gravatar_id":"","url":"https://api.github.com/users/alangpierce","html_url":"https://github.com/alangpierce","followers_url":"https://api.github.com/users/alangpierce/followers","following_url":"https://api.github.com/users/alangpierce/following{/other_user}","gists_url":"https://api.github.com/users/alangpierce/gists{/gist_id}","starred_url":"https://api.github.com/users/alangpierce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alangpierce/subscriptions","organizations_url":"https://api.github.com/users/alangpierce/orgs","repos_url":"https://api.github.com/users/alangpierce/repos","events_url":"https://api.github.com/users/alangpierce/events{/privacy}","received_events_url":"https://api.github.com/users/alangpierce/received_events","type":"User","site_admin":false},"repo":{"id":64524335,"name":"coffeescript","full_name":"alangpierce/coffeescript","owner":{"login":"alangpierce","id":211605,"avatar_url":"https://avatars.githubusercontent.com/u/211605?v=3","gravatar_id":"","url":"https://api.github.com/users/alangpierce","html_url":"https://github.com/alangpierce","followers_url":"https://api.github.com/users/alangpierce/followers","following_url":"https://api.github.com/users/alangpierce/following{/other_user}","gists_url":"https://api.github.com/users/alangpierce/gists{/gist_id}","starred_url":"https://api.github.com/users/alangpierce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alangpierce/subscriptions","organizations_url":"https://api.github.com/users/alangpierce/orgs","repos_url":"https://api.github.com/users/alangpierce/repos","events_url":"https://api.github.com/users/alangpierce/events{/privacy}","received_events_url":"https://api.github.com/users/alangpierce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alangpierce/coffeescript","description":"Unfancy JavaScript","fork":true,"url":"https://api.github.com/repos/alangpierce/coffeescript","forks_url":"https://api.github.com/repos/alangpierce/coffeescript/forks","keys_url":"https://api.github.com/repos/alangpierce/coffeescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alangpierce/coffeescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alangpierce/coffeescript/teams","hooks_url":"https://api.github.com/repos/alangpierce/coffeescript/hooks","issue_events_url":"https://api.github.com/repos/alangpierce/coffeescript/issues/events{/number}","events_url":"https://api.github.com/repos/alangpierce/coffeescript/events","assignees_url":"https://api.github.com/repos/alangpierce/coffeescript/assignees{/user}","branches_url":"https://api.github.com/repos/alangpierce/coffeescript/branches{/branch}","tags_url":"https://api.github.com/repos/alangpierce/coffeescript/tags","blobs_url":"https://api.github.com/repos/alangpierce/coffeescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alangpierce/coffeescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alangpierce/coffeescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/alangpierce/coffeescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alangpierce/coffeescript/statuses/{sha}","languages_url":"https://api.github.com/repos/alangpierce/coffeescript/languages","stargazers_url":"https://api.github.com/repos/alangpierce/coffeescript/stargazers","contributors_url":"https://api.github.com/repos/alangpierce/coffeescript/contributors","subscribers_url":"https://api.github.com/repos/alangpierce/coffeescript/subscribers","subscription_url":"https://api.github.com/repos/alangpierce/coffeescript/subscription","commits_url":"https://api.github.com/repos/alangpierce/coffeescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/alangpierce/coffeescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/alangpierce/coffeescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/alangpierce/coffeescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/alangpierce/coffeescript/contents/{+path}","compare_url":"https://api.github.com/repos/alangpierce/coffeescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alangpierce/coffeescript/merges","archive_url":"https://api.github.com/repos/alangpierce/coffeescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alangpierce/coffeescript/downloads","issues_url":"https://api.github.com/repos/alangpierce/coffeescript/issues{/number}","pulls_url":"https://api.github.com/repos/alangpierce/coffeescript/pulls{/number}","milestones_url":"https://api.github.com/repos/alangpierce/coffeescript/milestones{/number}","notifications_url":"https://api.github.com/repos/alangpierce/coffeescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alangpierce/coffeescript/labels{/name}","releases_url":"https://api.github.com/repos/alangpierce/coffeescript/releases{/id}","deployments_url":"https://api.github.com/repos/alangpierce/coffeescript/deployments","created_at":"2016-07-30T03:35:48Z","updated_at":"2016-07-30T03:35:50Z","pushed_at":"2016-10-23T03:46:49Z","git_url":"git://github.com/alangpierce/coffeescript.git","ssh_url":"git@github.com:alangpierce/coffeescript.git","clone_url":"https://github.com/alangpierce/coffeescript.git","svn_url":"https://github.com/alangpierce/coffeescript","homepage":"http://coffeescript.org/","size":16349,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jashkenas:master","ref":"master","sha":"3c42b400a13c6e255e5669e9b9ada2da49c526b8","user":{"login":"jashkenas","id":4732,"avatar_url":"https://avatars.githubusercontent.com/u/4732?v=3","gravatar_id":"","url":"https://api.github.com/users/jashkenas","html_url":"https://github.com/jashkenas","followers_url":"https://api.github.com/users/jashkenas/followers","following_url":"https://api.github.com/users/jashkenas/following{/other_user}","gists_url":"https://api.github.com/users/jashkenas/gists{/gist_id}","starred_url":"https://api.github.com/users/jashkenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jashkenas/subscriptions","organizations_url":"https://api.github.com/users/jashkenas/orgs","repos_url":"https://api.github.com/users/jashkenas/repos","events_url":"https://api.github.com/users/jashkenas/events{/privacy}","received_events_url":"https://api.github.com/users/jashkenas/received_events","type":"User","site_admin":false},"repo":{"id":441269,"name":"coffeescript","full_name":"jashkenas/coffeescript","owner":{"login":"jashkenas","id":4732,"avatar_url":"https://avatars.githubusercontent.com/u/4732?v=3","gravatar_id":"","url":"https://api.github.com/users/jashkenas","html_url":"https://github.com/jashkenas","followers_url":"https://api.github.com/users/jashkenas/followers","following_url":"https://api.github.com/users/jashkenas/following{/other_user}","gists_url":"https://api.github.com/users/jashkenas/gists{/gist_id}","starred_url":"https://api.github.com/users/jashkenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jashkenas/subscriptions","organizations_url":"https://api.github.com/users/jashkenas/orgs","repos_url":"https://api.github.com/users/jashkenas/repos","events_url":"https://api.github.com/users/jashkenas/events{/privacy}","received_events_url":"https://api.github.com/users/jashkenas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jashkenas/coffeescript","description":"Unfancy JavaScript","fork":false,"url":"https://api.github.com/repos/jashkenas/coffeescript","forks_url":"https://api.github.com/repos/jashkenas/coffeescript/forks","keys_url":"https://api.github.com/repos/jashkenas/coffeescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jashkenas/coffeescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jashkenas/coffeescript/teams","hooks_url":"https://api.github.com/repos/jashkenas/coffeescript/hooks","issue_events_url":"https://api.github.com/repos/jashkenas/coffeescript/issues/events{/number}","events_url":"https://api.github.com/repos/jashkenas/coffeescript/events","assignees_url":"https://api.github.com/repos/jashkenas/coffeescript/assignees{/user}","branches_url":"https://api.github.com/repos/jashkenas/coffeescript/branches{/branch}","tags_url":"https://api.github.com/repos/jashkenas/coffeescript/tags","blobs_url":"https://api.github.com/repos/jashkenas/coffeescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jashkenas/coffeescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jashkenas/coffeescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/jashkenas/coffeescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jashkenas/coffeescript/statuses/{sha}","languages_url":"https://api.github.com/repos/jashkenas/coffeescript/languages","stargazers_url":"https://api.github.com/repos/jashkenas/coffeescript/stargazers","contributors_url":"https://api.github.com/repos/jashkenas/coffeescript/contributors","subscribers_url":"https://api.github.com/repos/jashkenas/coffeescript/subscribers","subscription_url":"https://api.github.com/repos/jashkenas/coffeescript/subscription","commits_url":"https://api.github.com/repos/jashkenas/coffeescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/jashkenas/coffeescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/jashkenas/coffeescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/jashkenas/coffeescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/jashkenas/coffeescript/contents/{+path}","compare_url":"https://api.github.com/repos/jashkenas/coffeescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jashkenas/coffeescript/merges","archive_url":"https://api.github.com/repos/jashkenas/coffeescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jashkenas/coffeescript/downloads","issues_url":"https://api.github.com/repos/jashkenas/coffeescript/issues{/number}","pulls_url":"https://api.github.com/repos/jashkenas/coffeescript/pulls{/number}","milestones_url":"https://api.github.com/repos/jashkenas/coffeescript/milestones{/number}","notifications_url":"https://api.github.com/repos/jashkenas/coffeescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jashkenas/coffeescript/labels{/name}","releases_url":"https://api.github.com/repos/jashkenas/coffeescript/releases{/id}","deployments_url":"https://api.github.com/repos/jashkenas/coffeescript/deployments","created_at":"2009-12-18T01:39:53Z","updated_at":"2016-10-22T19:57:08Z","pushed_at":"2016-10-23T07:41:46Z","git_url":"git://github.com/jashkenas/coffeescript.git","ssh_url":"git@github.com:jashkenas/coffeescript.git","clone_url":"https://github.com/jashkenas/coffeescript.git","svn_url":"https://github.com/jashkenas/coffeescript","homepage":"http://coffeescript.org/","size":22110,"stargazers_count":13413,"watchers_count":13413,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1826,"mirror_url":null,"open_issues_count":347,"forks":1826,"open_issues":347,"watchers":13413,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jashkenas/coffeescript/pulls/4344"},"html":{"href":"https://github.com/jashkenas/coffeescript/pull/4344"},"issue":{"href":"https://api.github.com/repos/jashkenas/coffeescript/issues/4344"},"comments":{"href":"https://api.github.com/repos/jashkenas/coffeescript/issues/4344/comments"},"review_comments":{"href":"https://api.github.com/repos/jashkenas/coffeescript/pulls/4344/comments"},"review_comment":{"href":"https://api.github.com/repos/jashkenas/coffeescript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jashkenas/coffeescript/pulls/4344/commits"},"statuses":{"href":"https://api.github.com/repos/jashkenas/coffeescript/statuses/a42fb61cf378432d770142e7da3d23732b2490e9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lydell","id":2142817,"avatar_url":"https://avatars.githubusercontent.com/u/2142817?v=3","gravatar_id":"","url":"https://api.github.com/users/lydell","html_url":"https://github.com/lydell","followers_url":"https://api.github.com/users/lydell/followers","following_url":"https://api.github.com/users/lydell/following{/other_user}","gists_url":"https://api.github.com/users/lydell/gists{/gist_id}","starred_url":"https://api.github.com/users/lydell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lydell/subscriptions","organizations_url":"https://api.github.com/users/lydell/orgs","repos_url":"https://api.github.com/users/lydell/repos","events_url":"https://api.github.com/users/lydell/events{/privacy}","received_events_url":"https://api.github.com/users/lydell/received_events","type":"User","site_admin":false},"comments":3,"review_comments":2,"commits":2,"additions":47,"deletions":2,"changed_files":3}}
{"actor":{"display_login":"lydell"}}