{"action":"created","comment":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/comments/51002276","id":51002276,"diff_hunk":"@@ -83,10 +83,10 @@\n \n   function makeDateSerializer(type, key) {\n     var conversion = type === 'date' ? 'YYYY-MM-DD' : 'YYYY-MM-DD\\\\THH:mm:ss\\\\Z';\n-    return function(date) {\n+    return function (date) {\n       var retstr;\n       var retval;\n-      if (date === null) {\n+      if (date == null) {","path":"src/ggrc/assets/javascripts/models/cacheable.js","position":null,"original_position":9,"commit_id":"d0a08fddbdf64f5200cc2d450c6f23dd99b0dc03","original_commit_id":"97dbec31873690b891b3a0a63ed9c973037a2847","user":{"login":"plamut","id":1235663,"avatar_url":"https://avatars.githubusercontent.com/u/1235663?v=3","gravatar_id":"","url":"https://api.github.com/users/plamut","html_url":"https://github.com/plamut","followers_url":"https://api.github.com/users/plamut/followers","following_url":"https://api.github.com/users/plamut/following{/other_user}","gists_url":"https://api.github.com/users/plamut/gists{/gist_id}","starred_url":"https://api.github.com/users/plamut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plamut/subscriptions","organizations_url":"https://api.github.com/users/plamut/orgs","repos_url":"https://api.github.com/users/plamut/repos","events_url":"https://api.github.com/users/plamut/events{/privacy}","received_events_url":"https://api.github.com/users/plamut/received_events","type":"User","site_admin":false},"body":"The takeaway from here is that leaving `==` in the code is dangerous, because it's _very_ tempting for people to \"fix\" it. It's very likely that somebody would introduce the very same bug in the next couple of months. :laughing: ","created_at":"2016-01-27T15:49:05Z","updated_at":"2016-01-27T15:49:05Z","html_url":"https://github.com/google/ggrc-core/pull/3530#discussion_r51002276","pull_request_url":"https://api.github.com/repos/google/ggrc-core/pulls/3530","_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments/51002276"},"html":{"href":"https://github.com/google/ggrc-core/pull/3530#discussion_r51002276"},"pull_request":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/3530"}}},"pull_request":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/3530","id":57373316,"html_url":"https://github.com/google/ggrc-core/pull/3530","diff_url":"https://github.com/google/ggrc-core/pull/3530.diff","patch_url":"https://github.com/google/ggrc-core/pull/3530.patch","issue_url":"https://api.github.com/repos/google/ggrc-core/issues/3530","number":3530,"state":"open","locked":false,"title":"QUICK-FIX Fix Uncaught TypeError caused by wrong linting","user":{"login":"uskudnik","id":120451,"avatar_url":"https://avatars.githubusercontent.com/u/120451?v=3","gravatar_id":"","url":"https://api.github.com/users/uskudnik","html_url":"https://github.com/uskudnik","followers_url":"https://api.github.com/users/uskudnik/followers","following_url":"https://api.github.com/users/uskudnik/following{/other_user}","gists_url":"https://api.github.com/users/uskudnik/gists{/gist_id}","starred_url":"https://api.github.com/users/uskudnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uskudnik/subscriptions","organizations_url":"https://api.github.com/users/uskudnik/orgs","repos_url":"https://api.github.com/users/uskudnik/repos","events_url":"https://api.github.com/users/uskudnik/events{/privacy}","received_events_url":"https://api.github.com/users/uskudnik/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-01-27T15:15:47Z","updated_at":"2016-01-27T15:49:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66f094afeff0b7ba955f076d95708592dcee2630","assignee":{"login":"zidarsk8","id":566311,"avatar_url":"https://avatars.githubusercontent.com/u/566311?v=3","gravatar_id":"","url":"https://api.github.com/users/zidarsk8","html_url":"https://github.com/zidarsk8","followers_url":"https://api.github.com/users/zidarsk8/followers","following_url":"https://api.github.com/users/zidarsk8/following{/other_user}","gists_url":"https://api.github.com/users/zidarsk8/gists{/gist_id}","starred_url":"https://api.github.com/users/zidarsk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zidarsk8/subscriptions","organizations_url":"https://api.github.com/users/zidarsk8/orgs","repos_url":"https://api.github.com/users/zidarsk8/repos","events_url":"https://api.github.com/users/zidarsk8/events{/privacy}","received_events_url":"https://api.github.com/users/zidarsk8/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/google/ggrc-core/milestones/16","html_url":"https://github.com/google/ggrc-core/milestones/0.9.6-Plum%20Jelly","labels_url":"https://api.github.com/repos/google/ggrc-core/milestones/16/labels","id":1058061,"number":16,"title":"0.9.6-Plum Jelly","description":"","creator":{"login":"Smotko","id":513444,"avatar_url":"https://avatars.githubusercontent.com/u/513444?v=3","gravatar_id":"","url":"https://api.github.com/users/Smotko","html_url":"https://github.com/Smotko","followers_url":"https://api.github.com/users/Smotko/followers","following_url":"https://api.github.com/users/Smotko/following{/other_user}","gists_url":"https://api.github.com/users/Smotko/gists{/gist_id}","starred_url":"https://api.github.com/users/Smotko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Smotko/subscriptions","organizations_url":"https://api.github.com/users/Smotko/orgs","repos_url":"https://api.github.com/users/Smotko/repos","events_url":"https://api.github.com/users/Smotko/events{/privacy}","received_events_url":"https://api.github.com/users/Smotko/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":77,"state":"open","created_at":"2015-04-08T11:38:13Z","updated_at":"2016-01-27T15:25:13Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/google/ggrc-core/pulls/3530/commits","review_comments_url":"https://api.github.com/repos/google/ggrc-core/pulls/3530/comments","review_comment_url":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ggrc-core/issues/3530/comments","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/d0a08fddbdf64f5200cc2d450c6f23dd99b0dc03","head":{"label":"uskudnik:quickfix/zucchini-merge-linting-fix","ref":"quickfix/zucchini-merge-linting-fix","sha":"d0a08fddbdf64f5200cc2d450c6f23dd99b0dc03","user":{"login":"uskudnik","id":120451,"avatar_url":"https://avatars.githubusercontent.com/u/120451?v=3","gravatar_id":"","url":"https://api.github.com/users/uskudnik","html_url":"https://github.com/uskudnik","followers_url":"https://api.github.com/users/uskudnik/followers","following_url":"https://api.github.com/users/uskudnik/following{/other_user}","gists_url":"https://api.github.com/users/uskudnik/gists{/gist_id}","starred_url":"https://api.github.com/users/uskudnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uskudnik/subscriptions","organizations_url":"https://api.github.com/users/uskudnik/orgs","repos_url":"https://api.github.com/users/uskudnik/repos","events_url":"https://api.github.com/users/uskudnik/events{/privacy}","received_events_url":"https://api.github.com/users/uskudnik/received_events","type":"User","site_admin":false},"repo":{"id":36459094,"name":"ggrc-core","full_name":"uskudnik/ggrc-core","owner":{"login":"uskudnik","id":120451,"avatar_url":"https://avatars.githubusercontent.com/u/120451?v=3","gravatar_id":"","url":"https://api.github.com/users/uskudnik","html_url":"https://github.com/uskudnik","followers_url":"https://api.github.com/users/uskudnik/followers","following_url":"https://api.github.com/users/uskudnik/following{/other_user}","gists_url":"https://api.github.com/users/uskudnik/gists{/gist_id}","starred_url":"https://api.github.com/users/uskudnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uskudnik/subscriptions","organizations_url":"https://api.github.com/users/uskudnik/orgs","repos_url":"https://api.github.com/users/uskudnik/repos","events_url":"https://api.github.com/users/uskudnik/events{/privacy}","received_events_url":"https://api.github.com/users/uskudnik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/uskudnik/ggrc-core","description":"GGRC Core","fork":true,"url":"https://api.github.com/repos/uskudnik/ggrc-core","forks_url":"https://api.github.com/repos/uskudnik/ggrc-core/forks","keys_url":"https://api.github.com/repos/uskudnik/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uskudnik/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uskudnik/ggrc-core/teams","hooks_url":"https://api.github.com/repos/uskudnik/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/uskudnik/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/uskudnik/ggrc-core/events","assignees_url":"https://api.github.com/repos/uskudnik/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/uskudnik/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/uskudnik/ggrc-core/tags","blobs_url":"https://api.github.com/repos/uskudnik/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uskudnik/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uskudnik/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/uskudnik/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uskudnik/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/uskudnik/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/uskudnik/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/uskudnik/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/uskudnik/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/uskudnik/ggrc-core/subscription","commits_url":"https://api.github.com/repos/uskudnik/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/uskudnik/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/uskudnik/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/uskudnik/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/uskudnik/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/uskudnik/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uskudnik/ggrc-core/merges","archive_url":"https://api.github.com/repos/uskudnik/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uskudnik/ggrc-core/downloads","issues_url":"https://api.github.com/repos/uskudnik/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/uskudnik/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/uskudnik/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/uskudnik/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uskudnik/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/uskudnik/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/uskudnik/ggrc-core/deployments","created_at":"2015-05-28T18:50:16Z","updated_at":"2015-05-28T18:50:20Z","pushed_at":"2016-01-27T15:33:10Z","git_url":"git://github.com/uskudnik/ggrc-core.git","ssh_url":"git@github.com:uskudnik/ggrc-core.git","clone_url":"https://github.com/uskudnik/ggrc-core.git","svn_url":"https://github.com/uskudnik/ggrc-core","homepage":null,"size":48743,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"google:develop","ref":"develop","sha":"103bb2c9fa69754582e3cd25cae485260f87e643","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":9304637,"name":"ggrc-core","full_name":"google/ggrc-core","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/ggrc-core","description":"GGRC Core","fork":false,"url":"https://api.github.com/repos/google/ggrc-core","forks_url":"https://api.github.com/repos/google/ggrc-core/forks","keys_url":"https://api.github.com/repos/google/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ggrc-core/teams","hooks_url":"https://api.github.com/repos/google/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/google/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/google/ggrc-core/events","assignees_url":"https://api.github.com/repos/google/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/google/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/google/ggrc-core/tags","blobs_url":"https://api.github.com/repos/google/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/google/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/google/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/google/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/google/ggrc-core/subscription","commits_url":"https://api.github.com/repos/google/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/google/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ggrc-core/merges","archive_url":"https://api.github.com/repos/google/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ggrc-core/downloads","issues_url":"https://api.github.com/repos/google/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/google/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/google/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/google/ggrc-core/deployments","created_at":"2013-04-08T19:16:28Z","updated_at":"2016-01-23T01:53:37Z","pushed_at":"2016-01-27T15:41:06Z","git_url":"git://github.com/google/ggrc-core.git","ssh_url":"git@github.com:google/ggrc-core.git","clone_url":"https://github.com/google/ggrc-core.git","svn_url":"https://github.com/google/ggrc-core","homepage":null,"size":55684,"stargazers_count":63,"watchers_count":63,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":19,"forks":42,"open_issues":19,"watchers":63,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/3530"},"html":{"href":"https://github.com/google/ggrc-core/pull/3530"},"issue":{"href":"https://api.github.com/repos/google/ggrc-core/issues/3530"},"comments":{"href":"https://api.github.com/repos/google/ggrc-core/issues/3530/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/3530/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/3530/commits"},"statuses":{"href":"https://api.github.com/repos/google/ggrc-core/statuses/d0a08fddbdf64f5200cc2d450c6f23dd99b0dc03"}}}}