{"action":"created","issue":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/4428","repository_url":"https://api.github.com/repos/MarlinFirmware/Marlin","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/4428/labels{/name}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/4428/comments","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/4428/events","html_url":"https://github.com/MarlinFirmware/Marlin/issues/4428","id":167876217,"number":4428,"title":"SHOW_TEMP_ADC_VALUES errors","user":{"login":"repetier","id":933919,"avatar_url":"https://avatars.githubusercontent.com/u/933919?v=3","gravatar_id":"","url":"https://api.github.com/users/repetier","html_url":"https://github.com/repetier","followers_url":"https://api.github.com/users/repetier/followers","following_url":"https://api.github.com/users/repetier/following{/other_user}","gists_url":"https://api.github.com/users/repetier/gists{/gist_id}","starred_url":"https://api.github.com/users/repetier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/repetier/subscriptions","organizations_url":"https://api.github.com/users/repetier/orgs","repos_url":"https://api.github.com/users/repetier/repos","events_url":"https://api.github.com/users/repetier/events{/privacy}","received_events_url":"https://api.github.com/users/repetier/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/Bug:%20Verified%20!","name":"Bug: Verified !","color":"e11d21"},{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/PR:%20Bugfix","name":"PR: Bugfix","color":"bfe5bf"},{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/Support:%20Hosts%20&%20Protocols","name":"Support: Hosts & Protocols","color":"006b75"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-07-27T14:59:50Z","updated_at":"2016-07-28T06:40:56Z","closed_at":null,"body":"Just got a report from a user that with \r\n#define SHOW_TEMP_ADC_VALUES\r\nthe temperatures do not get read correctly. User said it was 1.1RC6 and his screenshot showed\r\n> 00:43:17.873 : ok T:24.8 /0.0 B:25.2 /0.0 B@:0 @:0    ADC B:25.2C->977  T0:24.8C->977\r\nwhile my tests with RC7 showed\r\n> 00:43:17.873 : ok T:24.8 /0.0 B:25.2 /0.0 B@:0 @:0    ADC B:25.2C->977  T :24.8C->977\r\nThe space after last T is a 0 - byte and was supposed to be a 0 for extruder number. Guess iterator is now a char so it is not converted into a number. So that is the least error you should fix. \r\n\r\nAlso I'm not so hot about adding C->977 after it. This breaks past host parsers as that is part from B: or T0: and belongs to the result and the result is no number any more, which is why host then shows 0 temperature instead. Not sure which other hosts will have similar problems. It only works if you parse next number neglecting non number chars afterwards, but as I saw at my example this assumption must not be true."},"comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments/235812143","html_url":"https://github.com/MarlinFirmware/Marlin/issues/4428#issuecomment-235812143","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/4428","id":235812143,"user":{"login":"thinkyhead","id":698003,"avatar_url":"https://avatars.githubusercontent.com/u/698003?v=3","gravatar_id":"","url":"https://api.github.com/users/thinkyhead","html_url":"https://github.com/thinkyhead","followers_url":"https://api.github.com/users/thinkyhead/followers","following_url":"https://api.github.com/users/thinkyhead/following{/other_user}","gists_url":"https://api.github.com/users/thinkyhead/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkyhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkyhead/subscriptions","organizations_url":"https://api.github.com/users/thinkyhead/orgs","repos_url":"https://api.github.com/users/thinkyhead/repos","events_url":"https://api.github.com/users/thinkyhead/events{/privacy}","received_events_url":"https://api.github.com/users/thinkyhead/received_events","type":"User","site_admin":false},"created_at":"2016-07-28T06:40:56Z","updated_at":"2016-07-28T06:40:56Z","body":"> This problem might also appear in other places\r\n\r\nI'll see if I can constrain it so it only treats actual `char` as `char` and treats `uint8_t` and `int8_t` as `int`. If I can't force that, then I will relent and get rid of the char version of `serial_echopair_P`. I'm sure it's only being used for debugging output anyway."}}
{"actor":{"display_login":"thinkyhead"}}