{"action":"created","issue":{"url":"https://api.github.com/repos/AppleWin/AppleWin/issues/304","repository_url":"https://api.github.com/repos/AppleWin/AppleWin","labels_url":"https://api.github.com/repos/AppleWin/AppleWin/issues/304/labels{/name}","comments_url":"https://api.github.com/repos/AppleWin/AppleWin/issues/304/comments","events_url":"https://api.github.com/repos/AppleWin/AppleWin/issues/304/events","html_url":"https://github.com/AppleWin/AppleWin/pull/304","id":102466993,"number":304,"title":"Save-state v2","user":{"login":"tomcw","id":6696896,"avatar_url":"https://avatars.githubusercontent.com/u/6696896?v=3","gravatar_id":"","url":"https://api.github.com/users/tomcw","html_url":"https://github.com/tomcw","followers_url":"https://api.github.com/users/tomcw/followers","following_url":"https://api.github.com/users/tomcw/following{/other_user}","gists_url":"https://api.github.com/users/tomcw/gists{/gist_id}","starred_url":"https://api.github.com/users/tomcw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomcw/subscriptions","organizations_url":"https://api.github.com/users/tomcw/orgs","repos_url":"https://api.github.com/users/tomcw/repos","events_url":"https://api.github.com/users/tomcw/events{/privacy}","received_events_url":"https://api.github.com/users/tomcw/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":19,"created_at":"2015-08-21T21:39:52Z","updated_at":"2016-02-09T21:21:07Z","closed_at":"2015-08-28T09:21:55Z","pull_request":{"url":"https://api.github.com/repos/AppleWin/AppleWin/pulls/304","html_url":"https://github.com/AppleWin/AppleWin/pull/304","diff_url":"https://github.com/AppleWin/AppleWin/pull/304.diff","patch_url":"https://github.com/AppleWin/AppleWin/pull/304.patch"},"body":"Hi - a mega pull-request, I'm afraid!\r\n\r\nThe short summary is that it addresses #260, with this new format being extensible and supporting all the AppleWin cards (except Uthernet). Additionally the old v1 format is still supported (for loading).\r\n\r\nI don't think it's worth anyone actually reviewing this pull-request. Maybe just give an opinion on the restoring of the configuration (see below).\r\n\r\nThis v2 format also saves/restores the configuration state. I'm in two minds about restoring the config though:\r\n. On the one hand, you can save a game's state: eg. where you want to use cursor keys (or auto-fire) etc. for joystick emulation.\r\n. But on the other hand, you don't know what state you'll be loading in. So it'll overwrite your current setup (eg. Apple II type, video mode, ConfirmReboot, ScrollLock toggle mode, volume settings, etc)\r\n  - arguably you don't know what h/w state you are loading in anyway, so your current card setup will switch to the newly loaded state's\r\n\r\nSo a quick solution is to just disable the restore config state routine for now.\r\nWhat do you think?\r\n\r\nIn terms of testing, I've got save-state files that test all cards. My plan is to put these into a separate git repo (eg. AppleWin-test). The reason for this is that they are binary files and if they get updated then all versions will accrue in the repo. OK, the size is only ~140K (or bigger for RAMworks saved state files), so perhaps having lots of these to download when you sync with a repo isn't such a big deal.\r\n\r\nOTOH, the advantage of putting them directly into the AppleWin repo is that they'll be in sync with the commits to that repo (making testing specific versions easier).\r\n\r\nAnyway, I think if it doesn't work having them in a separate git repo, then I can just move them across.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/AppleWin/AppleWin/issues/comments/182072221","html_url":"https://github.com/AppleWin/AppleWin/pull/304#issuecomment-182072221","issue_url":"https://api.github.com/repos/AppleWin/AppleWin/issues/304","id":182072221,"user":{"login":"sicklittlemonkey","id":4393005,"avatar_url":"https://avatars.githubusercontent.com/u/4393005?v=3","gravatar_id":"","url":"https://api.github.com/users/sicklittlemonkey","html_url":"https://github.com/sicklittlemonkey","followers_url":"https://api.github.com/users/sicklittlemonkey/followers","following_url":"https://api.github.com/users/sicklittlemonkey/following{/other_user}","gists_url":"https://api.github.com/users/sicklittlemonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/sicklittlemonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sicklittlemonkey/subscriptions","organizations_url":"https://api.github.com/users/sicklittlemonkey/orgs","repos_url":"https://api.github.com/users/sicklittlemonkey/repos","events_url":"https://api.github.com/users/sicklittlemonkey/events{/privacy}","received_events_url":"https://api.github.com/users/sicklittlemonkey/received_events","type":"User","site_admin":false},"created_at":"2016-02-09T21:21:07Z","updated_at":"2016-02-09T21:21:07Z","body":"I haven't looked at the code, but your answers to those points sound good!\n\nCheers,\nNick.\n"}}