{"action":"created","comment":{"url":"https://api.github.com/repos/kz8s/tack/pulls/comments/84814538","pull_request_review_id":5567959,"id":84814538,"diff_hunk":"@@ -1,3 +1,30 @@\n+resource \"aws_ebs_volume\" \"etcd\" {\n+  count = \"${ length( split(\",\", var.azs) ) }\"\n+\n+  availability_zone = \"${ element( split(\",\", var.azs), 0 ) }\"\n+\n+  type = \"gp2\"\n+  size = 100\n+\n+  tags {\n+    builtWith = \"terraform\"\n+    Cluster = \"${ var.name }\"\n+    depends-id = \"${ var.depends-id }\"\n+    KubernetesCluster = \"${ var.name }\"\n+    Name = \"etcd${ count.index + 1 }-${ var.name }\"\n+    role = \"etcd,apiserver\"\n+    version = \"${ var.coreos-hyperkube-tag }\"\n+  }\n+}\n+\n+resource \"aws_volume_attachment\" \"etcd\" {\n+  count = \"${ length( split(\",\", var.azs) ) }\"\n+\n+  device_name = \"/dev/xvdf\"","path":"modules/etcd/ec2.tf","position":23,"original_position":23,"commit_id":"0653e766dd995b86584999537426a118af518eed","original_commit_id":"adaa14e752c795fcb3303d7f058ed0d014441074","user":{"login":"wellsie","id":5160593,"avatar_url":"https://avatars.githubusercontent.com/u/5160593?v=3","gravatar_id":"","url":"https://api.github.com/users/wellsie","html_url":"https://github.com/wellsie","followers_url":"https://api.github.com/users/wellsie/followers","following_url":"https://api.github.com/users/wellsie/following{/other_user}","gists_url":"https://api.github.com/users/wellsie/gists{/gist_id}","starred_url":"https://api.github.com/users/wellsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellsie/subscriptions","organizations_url":"https://api.github.com/users/wellsie/orgs","repos_url":"https://api.github.com/users/wellsie/repos","events_url":"https://api.github.com/users/wellsie/events{/privacy}","received_events_url":"https://api.github.com/users/wellsie/received_events","type":"User","site_admin":false},"body":"Where are you mounting xvdf ? Or am I missing something ?","created_at":"2016-10-25T01:02:05Z","updated_at":"2016-10-25T01:02:05Z","html_url":"https://github.com/kz8s/tack/pull/98#discussion_r84814538","pull_request_url":"https://api.github.com/repos/kz8s/tack/pulls/98","_links":{"self":{"href":"https://api.github.com/repos/kz8s/tack/pulls/comments/84814538"},"html":{"href":"https://github.com/kz8s/tack/pull/98#discussion_r84814538"},"pull_request":{"href":"https://api.github.com/repos/kz8s/tack/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/kz8s/tack/pulls/98","id":90674217,"html_url":"https://github.com/kz8s/tack/pull/98","diff_url":"https://github.com/kz8s/tack/pull/98.diff","patch_url":"https://github.com/kz8s/tack/pull/98.patch","issue_url":"https://api.github.com/repos/kz8s/tack/issues/98","number":98,"state":"open","locked":false,"title":"Attach EBS volumes to etcd nodes for persistence","user":{"login":"adambom","id":294597,"avatar_url":"https://avatars.githubusercontent.com/u/294597?v=3","gravatar_id":"","url":"https://api.github.com/users/adambom","html_url":"https://github.com/adambom","followers_url":"https://api.github.com/users/adambom/followers","following_url":"https://api.github.com/users/adambom/following{/other_user}","gists_url":"https://api.github.com/users/adambom/gists{/gist_id}","starred_url":"https://api.github.com/users/adambom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adambom/subscriptions","organizations_url":"https://api.github.com/users/adambom/orgs","repos_url":"https://api.github.com/users/adambom/repos","events_url":"https://api.github.com/users/adambom/events{/privacy}","received_events_url":"https://api.github.com/users/adambom/received_events","type":"User","site_admin":false},"body":"If you ever lose your etcd cluster for whatever reason, or if you should ever need to restart it, you should be able to recover your state. Mentioned in this issue: https://github.com/kz8s/tack/issues/75\r\n\r\nI have a module that will automatically snapshot the drives. If that's at all of interest, happy to commit that as well.","created_at":"2016-10-24T19:13:09Z","updated_at":"2016-10-25T01:02:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86fa626bb651435c51d78e0f2795de70bb874aa2","assignee":{"login":"wellsie","id":5160593,"avatar_url":"https://avatars.githubusercontent.com/u/5160593?v=3","gravatar_id":"","url":"https://api.github.com/users/wellsie","html_url":"https://github.com/wellsie","followers_url":"https://api.github.com/users/wellsie/followers","following_url":"https://api.github.com/users/wellsie/following{/other_user}","gists_url":"https://api.github.com/users/wellsie/gists{/gist_id}","starred_url":"https://api.github.com/users/wellsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellsie/subscriptions","organizations_url":"https://api.github.com/users/wellsie/orgs","repos_url":"https://api.github.com/users/wellsie/repos","events_url":"https://api.github.com/users/wellsie/events{/privacy}","received_events_url":"https://api.github.com/users/wellsie/received_events","type":"User","site_admin":false},"assignees":[{"login":"wellsie","id":5160593,"avatar_url":"https://avatars.githubusercontent.com/u/5160593?v=3","gravatar_id":"","url":"https://api.github.com/users/wellsie","html_url":"https://github.com/wellsie","followers_url":"https://api.github.com/users/wellsie/followers","following_url":"https://api.github.com/users/wellsie/following{/other_user}","gists_url":"https://api.github.com/users/wellsie/gists{/gist_id}","starred_url":"https://api.github.com/users/wellsie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellsie/subscriptions","organizations_url":"https://api.github.com/users/wellsie/orgs","repos_url":"https://api.github.com/users/wellsie/repos","events_url":"https://api.github.com/users/wellsie/events{/privacy}","received_events_url":"https://api.github.com/users/wellsie/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kz8s/tack/pulls/98/commits","review_comments_url":"https://api.github.com/repos/kz8s/tack/pulls/98/comments","review_comment_url":"https://api.github.com/repos/kz8s/tack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kz8s/tack/issues/98/comments","statuses_url":"https://api.github.com/repos/kz8s/tack/statuses/0653e766dd995b86584999537426a118af518eed","head":{"label":"adambom:patch-1","ref":"patch-1","sha":"0653e766dd995b86584999537426a118af518eed","user":{"login":"adambom","id":294597,"avatar_url":"https://avatars.githubusercontent.com/u/294597?v=3","gravatar_id":"","url":"https://api.github.com/users/adambom","html_url":"https://github.com/adambom","followers_url":"https://api.github.com/users/adambom/followers","following_url":"https://api.github.com/users/adambom/following{/other_user}","gists_url":"https://api.github.com/users/adambom/gists{/gist_id}","starred_url":"https://api.github.com/users/adambom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adambom/subscriptions","organizations_url":"https://api.github.com/users/adambom/orgs","repos_url":"https://api.github.com/users/adambom/repos","events_url":"https://api.github.com/users/adambom/events{/privacy}","received_events_url":"https://api.github.com/users/adambom/received_events","type":"User","site_admin":false},"repo":{"id":71822673,"name":"tack","full_name":"adambom/tack","owner":{"login":"adambom","id":294597,"avatar_url":"https://avatars.githubusercontent.com/u/294597?v=3","gravatar_id":"","url":"https://api.github.com/users/adambom","html_url":"https://github.com/adambom","followers_url":"https://api.github.com/users/adambom/followers","following_url":"https://api.github.com/users/adambom/following{/other_user}","gists_url":"https://api.github.com/users/adambom/gists{/gist_id}","starred_url":"https://api.github.com/users/adambom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adambom/subscriptions","organizations_url":"https://api.github.com/users/adambom/orgs","repos_url":"https://api.github.com/users/adambom/repos","events_url":"https://api.github.com/users/adambom/events{/privacy}","received_events_url":"https://api.github.com/users/adambom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adambom/tack","description":"Terraform module for creating Kubernetes cluster running on CoreOS in an AWS VPC","fork":true,"url":"https://api.github.com/repos/adambom/tack","forks_url":"https://api.github.com/repos/adambom/tack/forks","keys_url":"https://api.github.com/repos/adambom/tack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adambom/tack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adambom/tack/teams","hooks_url":"https://api.github.com/repos/adambom/tack/hooks","issue_events_url":"https://api.github.com/repos/adambom/tack/issues/events{/number}","events_url":"https://api.github.com/repos/adambom/tack/events","assignees_url":"https://api.github.com/repos/adambom/tack/assignees{/user}","branches_url":"https://api.github.com/repos/adambom/tack/branches{/branch}","tags_url":"https://api.github.com/repos/adambom/tack/tags","blobs_url":"https://api.github.com/repos/adambom/tack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adambom/tack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adambom/tack/git/refs{/sha}","trees_url":"https://api.github.com/repos/adambom/tack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adambom/tack/statuses/{sha}","languages_url":"https://api.github.com/repos/adambom/tack/languages","stargazers_url":"https://api.github.com/repos/adambom/tack/stargazers","contributors_url":"https://api.github.com/repos/adambom/tack/contributors","subscribers_url":"https://api.github.com/repos/adambom/tack/subscribers","subscription_url":"https://api.github.com/repos/adambom/tack/subscription","commits_url":"https://api.github.com/repos/adambom/tack/commits{/sha}","git_commits_url":"https://api.github.com/repos/adambom/tack/git/commits{/sha}","comments_url":"https://api.github.com/repos/adambom/tack/comments{/number}","issue_comment_url":"https://api.github.com/repos/adambom/tack/issues/comments{/number}","contents_url":"https://api.github.com/repos/adambom/tack/contents/{+path}","compare_url":"https://api.github.com/repos/adambom/tack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adambom/tack/merges","archive_url":"https://api.github.com/repos/adambom/tack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adambom/tack/downloads","issues_url":"https://api.github.com/repos/adambom/tack/issues{/number}","pulls_url":"https://api.github.com/repos/adambom/tack/pulls{/number}","milestones_url":"https://api.github.com/repos/adambom/tack/milestones{/number}","notifications_url":"https://api.github.com/repos/adambom/tack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adambom/tack/labels{/name}","releases_url":"https://api.github.com/repos/adambom/tack/releases{/id}","deployments_url":"https://api.github.com/repos/adambom/tack/deployments","created_at":"2016-10-24T19:06:09Z","updated_at":"2016-10-24T19:06:10Z","pushed_at":"2016-10-24T21:57:40Z","git_url":"git://github.com/adambom/tack.git","ssh_url":"git@github.com:adambom/tack.git","clone_url":"https://github.com/adambom/tack.git","svn_url":"https://github.com/adambom/tack","homepage":"","size":2581,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kz8s:master","ref":"master","sha":"59c4cc4e889ac7933fc99960d0501044ff8ad334","user":{"login":"kz8s","id":16867606,"avatar_url":"https://avatars.githubusercontent.com/u/16867606?v=3","gravatar_id":"","url":"https://api.github.com/users/kz8s","html_url":"https://github.com/kz8s","followers_url":"https://api.github.com/users/kz8s/followers","following_url":"https://api.github.com/users/kz8s/following{/other_user}","gists_url":"https://api.github.com/users/kz8s/gists{/gist_id}","starred_url":"https://api.github.com/users/kz8s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kz8s/subscriptions","organizations_url":"https://api.github.com/users/kz8s/orgs","repos_url":"https://api.github.com/users/kz8s/repos","events_url":"https://api.github.com/users/kz8s/events{/privacy}","received_events_url":"https://api.github.com/users/kz8s/received_events","type":"Organization","site_admin":false},"repo":{"id":51404225,"name":"tack","full_name":"kz8s/tack","owner":{"login":"kz8s","id":16867606,"avatar_url":"https://avatars.githubusercontent.com/u/16867606?v=3","gravatar_id":"","url":"https://api.github.com/users/kz8s","html_url":"https://github.com/kz8s","followers_url":"https://api.github.com/users/kz8s/followers","following_url":"https://api.github.com/users/kz8s/following{/other_user}","gists_url":"https://api.github.com/users/kz8s/gists{/gist_id}","starred_url":"https://api.github.com/users/kz8s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kz8s/subscriptions","organizations_url":"https://api.github.com/users/kz8s/orgs","repos_url":"https://api.github.com/users/kz8s/repos","events_url":"https://api.github.com/users/kz8s/events{/privacy}","received_events_url":"https://api.github.com/users/kz8s/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kz8s/tack","description":"Terraform module for creating Kubernetes cluster running on CoreOS in an AWS VPC","fork":false,"url":"https://api.github.com/repos/kz8s/tack","forks_url":"https://api.github.com/repos/kz8s/tack/forks","keys_url":"https://api.github.com/repos/kz8s/tack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kz8s/tack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kz8s/tack/teams","hooks_url":"https://api.github.com/repos/kz8s/tack/hooks","issue_events_url":"https://api.github.com/repos/kz8s/tack/issues/events{/number}","events_url":"https://api.github.com/repos/kz8s/tack/events","assignees_url":"https://api.github.com/repos/kz8s/tack/assignees{/user}","branches_url":"https://api.github.com/repos/kz8s/tack/branches{/branch}","tags_url":"https://api.github.com/repos/kz8s/tack/tags","blobs_url":"https://api.github.com/repos/kz8s/tack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kz8s/tack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kz8s/tack/git/refs{/sha}","trees_url":"https://api.github.com/repos/kz8s/tack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kz8s/tack/statuses/{sha}","languages_url":"https://api.github.com/repos/kz8s/tack/languages","stargazers_url":"https://api.github.com/repos/kz8s/tack/stargazers","contributors_url":"https://api.github.com/repos/kz8s/tack/contributors","subscribers_url":"https://api.github.com/repos/kz8s/tack/subscribers","subscription_url":"https://api.github.com/repos/kz8s/tack/subscription","commits_url":"https://api.github.com/repos/kz8s/tack/commits{/sha}","git_commits_url":"https://api.github.com/repos/kz8s/tack/git/commits{/sha}","comments_url":"https://api.github.com/repos/kz8s/tack/comments{/number}","issue_comment_url":"https://api.github.com/repos/kz8s/tack/issues/comments{/number}","contents_url":"https://api.github.com/repos/kz8s/tack/contents/{+path}","compare_url":"https://api.github.com/repos/kz8s/tack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kz8s/tack/merges","archive_url":"https://api.github.com/repos/kz8s/tack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kz8s/tack/downloads","issues_url":"https://api.github.com/repos/kz8s/tack/issues{/number}","pulls_url":"https://api.github.com/repos/kz8s/tack/pulls{/number}","milestones_url":"https://api.github.com/repos/kz8s/tack/milestones{/number}","notifications_url":"https://api.github.com/repos/kz8s/tack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kz8s/tack/labels{/name}","releases_url":"https://api.github.com/repos/kz8s/tack/releases{/id}","deployments_url":"https://api.github.com/repos/kz8s/tack/deployments","created_at":"2016-02-09T22:14:00Z","updated_at":"2016-10-24T20:01:07Z","pushed_at":"2016-10-24T21:57:40Z","git_url":"git://github.com/kz8s/tack.git","ssh_url":"git@github.com:kz8s/tack.git","clone_url":"https://github.com/kz8s/tack.git","svn_url":"https://github.com/kz8s/tack","homepage":"","size":2608,"stargazers_count":140,"watchers_count":140,"language":"HCL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":19,"forks":39,"open_issues":19,"watchers":140,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kz8s/tack/pulls/98"},"html":{"href":"https://github.com/kz8s/tack/pull/98"},"issue":{"href":"https://api.github.com/repos/kz8s/tack/issues/98"},"comments":{"href":"https://api.github.com/repos/kz8s/tack/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/kz8s/tack/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/kz8s/tack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kz8s/tack/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/kz8s/tack/statuses/0653e766dd995b86584999537426a118af518eed"}}}}
{"actor":{"display_login":"wellsie"}}