{"action":"opened","number":13043,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13043","id":95467903,"html_url":"https://github.com/joomla/joomla-cms/pull/13043","diff_url":"https://github.com/joomla/joomla-cms/pull/13043.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/13043.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13043","number":13043,"state":"open","locked":false,"title":"Multilingual Managers: htmlspecialchars needed","user":{"login":"infograf768","id":869724,"avatar_url":"https://avatars.githubusercontent.com/u/869724?v=3","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"body":"### Summary of Changes\r\nPassing `$item->title` through `htmlspecialchars()`\r\n### Testing Instructions\r\nCreate a multilingual site (2 languages are enough).\r\nAssociate 2 articles.\r\nAssociate 2 categories.\r\nAssociate 2 menu items.\r\nAssociate 2 contacts.\r\nAssociate 2 newsfeeds.\r\n\r\nFor each of these **add double quotes** in the title of one of the items.\r\nExample: `mymenu \"Useful\"`, etc.\r\n\r\nDisplay the managers for each kind of item\r\nYou will get stuff like this in the associations column (here the title is `Poètes \"français\"`)\r\n\r\n![screen shot 2016-11-28 at 10 38 11](https://cloud.githubusercontent.com/assets/869724/20663669/a4f8a986-b558-11e6-8bb3-418493f702a6.png)\r\nor for `contact \"en\"`\r\n\r\n![screen shot 2016-11-28 at 10 33 53](https://cloud.githubusercontent.com/assets/869724/20663731/d2e7fb80-b558-11e6-8c46-0eed6b05de1b.png)\r\n\r\n and\r\n![screen shot 2016-11-28 at 10 35 50](https://cloud.githubusercontent.com/assets/869724/20663988/b9920418-b559-11e6-874f-60f8371075a1.png)\r\n\r\nsame for the other components.\r\nPatch, now you will correctly get:\r\n![screen shot 2016-11-28 at 10 56 06](https://cloud.githubusercontent.com/assets/869724/20663878/5a7d9f1e-b559-11e6-89bd-39b535b2834d.png)\r\n\r\n\r\n","created_at":"2016-11-28T10:00:11Z","updated_at":"2016-11-28T10:00:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13043/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13043/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13043/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/671d36dc65a64afa46e6e4af6846b0d355bf6703","head":{"label":"infograf768:assoc_htmlspecialchars","ref":"assoc_htmlspecialchars","sha":"671d36dc65a64afa46e6e4af6846b0d355bf6703","user":{"login":"infograf768","id":869724,"avatar_url":"https://avatars.githubusercontent.com/u/869724?v=3","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"repo":{"id":3025712,"name":"joomla-cms","full_name":"infograf768/joomla-cms","owner":{"login":"infograf768","id":869724,"avatar_url":"https://avatars.githubusercontent.com/u/869724?v=3","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/infograf768/joomla-cms","description":"Fork of the Joomla! CMS","fork":true,"url":"https://api.github.com/repos/infograf768/joomla-cms","forks_url":"https://api.github.com/repos/infograf768/joomla-cms/forks","keys_url":"https://api.github.com/repos/infograf768/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infograf768/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infograf768/joomla-cms/teams","hooks_url":"https://api.github.com/repos/infograf768/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/infograf768/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/infograf768/joomla-cms/events","assignees_url":"https://api.github.com/repos/infograf768/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/infograf768/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/infograf768/joomla-cms/tags","blobs_url":"https://api.github.com/repos/infograf768/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infograf768/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infograf768/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/infograf768/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infograf768/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/infograf768/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/infograf768/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/infograf768/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/infograf768/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/infograf768/joomla-cms/subscription","commits_url":"https://api.github.com/repos/infograf768/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/infograf768/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/infograf768/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/infograf768/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/infograf768/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/infograf768/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infograf768/joomla-cms/merges","archive_url":"https://api.github.com/repos/infograf768/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infograf768/joomla-cms/downloads","issues_url":"https://api.github.com/repos/infograf768/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/infograf768/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/infograf768/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/infograf768/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infograf768/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/infograf768/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/infograf768/joomla-cms/deployments","created_at":"2011-12-21T08:55:33Z","updated_at":"2016-02-15T02:03:35Z","pushed_at":"2016-11-28T09:43:28Z","git_url":"git://github.com/infograf768/joomla-cms.git","ssh_url":"git@github.com:infograf768/joomla-cms.git","clone_url":"https://github.com/infograf768/joomla-cms.git","svn_url":"https://github.com/infograf768/joomla-cms","homepage":"http://joomla.org","size":154808,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"joomla:staging","ref":"staging","sha":"8046e2e9c378f73f1055c197697b069d20cc36dc","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2016-11-28T08:06:08Z","pushed_at":"2016-11-28T09:58:21Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":311449,"stargazers_count":2199,"watchers_count":2199,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2353,"mirror_url":null,"open_issues_count":608,"forks":2353,"open_issues":608,"watchers":2199,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13043"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/13043"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/13043"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/13043/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13043/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13043/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/671d36dc65a64afa46e6e4af6846b0d355bf6703"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":5,"changed_files":5}}
{"actor":{"display_login":"infograf768"}}