{"action":"created","comment":{"url":"https://api.github.com/repos/wolox-training/mp-angular/pulls/comments/57606557","id":57606557,"diff_hunk":"@@ -0,0 +1,13 @@\n+angular.module('app').controller('BooksController', [\n+  '$state', '$stateParams', 'booksService',\n+  function ($state, $stateParams, booksService) {\n+    this.id = $stateParams.id;\n+\n+    const success = (response) => {","path":"src/app/components/books/booksController.js","position":null,"original_position":6,"commit_id":"e1648ca99d371f74731f08041e2fb2ced18088c7","original_commit_id":"37c7a224b91f635cda766683b180e6afc4c92cb5","user":{"login":"sbalay","id":1928544,"avatar_url":"https://avatars.githubusercontent.com/u/1928544?v=3","gravatar_id":"","url":"https://api.github.com/users/sbalay","html_url":"https://github.com/sbalay","followers_url":"https://api.github.com/users/sbalay/followers","following_url":"https://api.github.com/users/sbalay/following{/other_user}","gists_url":"https://api.github.com/users/sbalay/gists{/gist_id}","starred_url":"https://api.github.com/users/sbalay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbalay/subscriptions","organizations_url":"https://api.github.com/users/sbalay/orgs","repos_url":"https://api.github.com/users/sbalay/repos","events_url":"https://api.github.com/users/sbalay/events{/privacy}","received_events_url":"https://api.github.com/users/sbalay/received_events","type":"User","site_admin":false},"body":"In my opinion, declaring the callback as a variable in the controller makes sense if we are going to reuse that callback function for any other action in the controller.\r\nDon't need to change this, looks good.","created_at":"2016-03-28T18:04:20Z","updated_at":"2016-03-28T18:04:20Z","html_url":"https://github.com/wolox-training/mp-angular/pull/8#discussion_r57606557","pull_request_url":"https://api.github.com/repos/wolox-training/mp-angular/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/wolox-training/mp-angular/pulls/comments/57606557"},"html":{"href":"https://github.com/wolox-training/mp-angular/pull/8#discussion_r57606557"},"pull_request":{"href":"https://api.github.com/repos/wolox-training/mp-angular/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/wolox-training/mp-angular/pulls/8","id":62765363,"html_url":"https://github.com/wolox-training/mp-angular/pull/8","diff_url":"https://github.com/wolox-training/mp-angular/pull/8.diff","patch_url":"https://github.com/wolox-training/mp-angular/pull/8.patch","issue_url":"https://api.github.com/repos/wolox-training/mp-angular/issues/8","number":8,"state":"open","locked":false,"title":"Implemente book view.","user":{"login":"mpizzagalli","id":7007384,"avatar_url":"https://avatars.githubusercontent.com/u/7007384?v=3","gravatar_id":"","url":"https://api.github.com/users/mpizzagalli","html_url":"https://github.com/mpizzagalli","followers_url":"https://api.github.com/users/mpizzagalli/followers","following_url":"https://api.github.com/users/mpizzagalli/following{/other_user}","gists_url":"https://api.github.com/users/mpizzagalli/gists{/gist_id}","starred_url":"https://api.github.com/users/mpizzagalli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpizzagalli/subscriptions","organizations_url":"https://api.github.com/users/mpizzagalli/orgs","repos_url":"https://api.github.com/users/mpizzagalli/repos","events_url":"https://api.github.com/users/mpizzagalli/events{/privacy}","received_events_url":"https://api.github.com/users/mpizzagalli/received_events","type":"User","site_admin":false},"body":"# Summary\r\n* Added a link to the name of each book in the dashboard, that redirects us to a bigger view of the book details.\r\n\r\n# Trello Card\r\nhttps://trello.com/c/ovuU9yMQ/7-crear-vista-de-detalle-de-un-libro\r\n\r\n# Screenshots\r\n![dash_links](https://cloud.githubusercontent.com/assets/7007384/13749265/5926e8a0-e9df-11e5-9595-805121f54163.png)\r\n![book_view](https://cloud.githubusercontent.com/assets/7007384/13749278/63aa81ba-e9df-11e5-8392-db3b31747c12.png)\r\n","created_at":"2016-03-14T15:24:13Z","updated_at":"2016-03-28T18:04:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72a50a763cf71726a44962d6b70cb66a6a42f0d1","assignee":{"login":"sbalay","id":1928544,"avatar_url":"https://avatars.githubusercontent.com/u/1928544?v=3","gravatar_id":"","url":"https://api.github.com/users/sbalay","html_url":"https://github.com/sbalay","followers_url":"https://api.github.com/users/sbalay/followers","following_url":"https://api.github.com/users/sbalay/following{/other_user}","gists_url":"https://api.github.com/users/sbalay/gists{/gist_id}","starred_url":"https://api.github.com/users/sbalay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbalay/subscriptions","organizations_url":"https://api.github.com/users/sbalay/orgs","repos_url":"https://api.github.com/users/sbalay/repos","events_url":"https://api.github.com/users/sbalay/events{/privacy}","received_events_url":"https://api.github.com/users/sbalay/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/wolox-training/mp-angular/pulls/8/commits","review_comments_url":"https://api.github.com/repos/wolox-training/mp-angular/pulls/8/comments","review_comment_url":"https://api.github.com/repos/wolox-training/mp-angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wolox-training/mp-angular/issues/8/comments","statuses_url":"https://api.github.com/repos/wolox-training/mp-angular/statuses/e1648ca99d371f74731f08041e2fb2ced18088c7","head":{"label":"wolox-training:book-view","ref":"book-view","sha":"e1648ca99d371f74731f08041e2fb2ced18088c7","user":{"login":"wolox-training","id":14113351,"avatar_url":"https://avatars.githubusercontent.com/u/14113351?v=3","gravatar_id":"","url":"https://api.github.com/users/wolox-training","html_url":"https://github.com/wolox-training","followers_url":"https://api.github.com/users/wolox-training/followers","following_url":"https://api.github.com/users/wolox-training/following{/other_user}","gists_url":"https://api.github.com/users/wolox-training/gists{/gist_id}","starred_url":"https://api.github.com/users/wolox-training/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolox-training/subscriptions","organizations_url":"https://api.github.com/users/wolox-training/orgs","repos_url":"https://api.github.com/users/wolox-training/repos","events_url":"https://api.github.com/users/wolox-training/events{/privacy}","received_events_url":"https://api.github.com/users/wolox-training/received_events","type":"Organization","site_admin":false},"repo":{"id":47692205,"name":"mp-angular","full_name":"wolox-training/mp-angular","owner":{"login":"wolox-training","id":14113351,"avatar_url":"https://avatars.githubusercontent.com/u/14113351?v=3","gravatar_id":"","url":"https://api.github.com/users/wolox-training","html_url":"https://github.com/wolox-training","followers_url":"https://api.github.com/users/wolox-training/followers","following_url":"https://api.github.com/users/wolox-training/following{/other_user}","gists_url":"https://api.github.com/users/wolox-training/gists{/gist_id}","starred_url":"https://api.github.com/users/wolox-training/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolox-training/subscriptions","organizations_url":"https://api.github.com/users/wolox-training/orgs","repos_url":"https://api.github.com/users/wolox-training/repos","events_url":"https://api.github.com/users/wolox-training/events{/privacy}","received_events_url":"https://api.github.com/users/wolox-training/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wolox-training/mp-angular","description":"Mati Training Angular","fork":false,"url":"https://api.github.com/repos/wolox-training/mp-angular","forks_url":"https://api.github.com/repos/wolox-training/mp-angular/forks","keys_url":"https://api.github.com/repos/wolox-training/mp-angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wolox-training/mp-angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wolox-training/mp-angular/teams","hooks_url":"https://api.github.com/repos/wolox-training/mp-angular/hooks","issue_events_url":"https://api.github.com/repos/wolox-training/mp-angular/issues/events{/number}","events_url":"https://api.github.com/repos/wolox-training/mp-angular/events","assignees_url":"https://api.github.com/repos/wolox-training/mp-angular/assignees{/user}","branches_url":"https://api.github.com/repos/wolox-training/mp-angular/branches{/branch}","tags_url":"https://api.github.com/repos/wolox-training/mp-angular/tags","blobs_url":"https://api.github.com/repos/wolox-training/mp-angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wolox-training/mp-angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wolox-training/mp-angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/wolox-training/mp-angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wolox-training/mp-angular/statuses/{sha}","languages_url":"https://api.github.com/repos/wolox-training/mp-angular/languages","stargazers_url":"https://api.github.com/repos/wolox-training/mp-angular/stargazers","contributors_url":"https://api.github.com/repos/wolox-training/mp-angular/contributors","subscribers_url":"https://api.github.com/repos/wolox-training/mp-angular/subscribers","subscription_url":"https://api.github.com/repos/wolox-training/mp-angular/subscription","commits_url":"https://api.github.com/repos/wolox-training/mp-angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/wolox-training/mp-angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/wolox-training/mp-angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/wolox-training/mp-angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/wolox-training/mp-angular/contents/{+path}","compare_url":"https://api.github.com/repos/wolox-training/mp-angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wolox-training/mp-angular/merges","archive_url":"https://api.github.com/repos/wolox-training/mp-angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wolox-training/mp-angular/downloads","issues_url":"https://api.github.com/repos/wolox-training/mp-angular/issues{/number}","pulls_url":"https://api.github.com/repos/wolox-training/mp-angular/pulls{/number}","milestones_url":"https://api.github.com/repos/wolox-training/mp-angular/milestones{/number}","notifications_url":"https://api.github.com/repos/wolox-training/mp-angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wolox-training/mp-angular/labels{/name}","releases_url":"https://api.github.com/repos/wolox-training/mp-angular/releases{/id}","deployments_url":"https://api.github.com/repos/wolox-training/mp-angular/deployments","created_at":"2015-12-09T13:12:29Z","updated_at":"2016-03-01T19:34:24Z","pushed_at":"2016-03-28T00:46:49Z","git_url":"git://github.com/wolox-training/mp-angular.git","ssh_url":"git@github.com:wolox-training/mp-angular.git","clone_url":"https://github.com/wolox-training/mp-angular.git","svn_url":"https://github.com/wolox-training/mp-angular","homepage":"","size":339,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"wolox-training:dashboard","ref":"dashboard","sha":"2de06ec0f8b5baa8449fe9bf346ba763030d1bf1","user":{"login":"wolox-training","id":14113351,"avatar_url":"https://avatars.githubusercontent.com/u/14113351?v=3","gravatar_id":"","url":"https://api.github.com/users/wolox-training","html_url":"https://github.com/wolox-training","followers_url":"https://api.github.com/users/wolox-training/followers","following_url":"https://api.github.com/users/wolox-training/following{/other_user}","gists_url":"https://api.github.com/users/wolox-training/gists{/gist_id}","starred_url":"https://api.github.com/users/wolox-training/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolox-training/subscriptions","organizations_url":"https://api.github.com/users/wolox-training/orgs","repos_url":"https://api.github.com/users/wolox-training/repos","events_url":"https://api.github.com/users/wolox-training/events{/privacy}","received_events_url":"https://api.github.com/users/wolox-training/received_events","type":"Organization","site_admin":false},"repo":{"id":47692205,"name":"mp-angular","full_name":"wolox-training/mp-angular","owner":{"login":"wolox-training","id":14113351,"avatar_url":"https://avatars.githubusercontent.com/u/14113351?v=3","gravatar_id":"","url":"https://api.github.com/users/wolox-training","html_url":"https://github.com/wolox-training","followers_url":"https://api.github.com/users/wolox-training/followers","following_url":"https://api.github.com/users/wolox-training/following{/other_user}","gists_url":"https://api.github.com/users/wolox-training/gists{/gist_id}","starred_url":"https://api.github.com/users/wolox-training/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolox-training/subscriptions","organizations_url":"https://api.github.com/users/wolox-training/orgs","repos_url":"https://api.github.com/users/wolox-training/repos","events_url":"https://api.github.com/users/wolox-training/events{/privacy}","received_events_url":"https://api.github.com/users/wolox-training/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wolox-training/mp-angular","description":"Mati Training Angular","fork":false,"url":"https://api.github.com/repos/wolox-training/mp-angular","forks_url":"https://api.github.com/repos/wolox-training/mp-angular/forks","keys_url":"https://api.github.com/repos/wolox-training/mp-angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wolox-training/mp-angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wolox-training/mp-angular/teams","hooks_url":"https://api.github.com/repos/wolox-training/mp-angular/hooks","issue_events_url":"https://api.github.com/repos/wolox-training/mp-angular/issues/events{/number}","events_url":"https://api.github.com/repos/wolox-training/mp-angular/events","assignees_url":"https://api.github.com/repos/wolox-training/mp-angular/assignees{/user}","branches_url":"https://api.github.com/repos/wolox-training/mp-angular/branches{/branch}","tags_url":"https://api.github.com/repos/wolox-training/mp-angular/tags","blobs_url":"https://api.github.com/repos/wolox-training/mp-angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wolox-training/mp-angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wolox-training/mp-angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/wolox-training/mp-angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wolox-training/mp-angular/statuses/{sha}","languages_url":"https://api.github.com/repos/wolox-training/mp-angular/languages","stargazers_url":"https://api.github.com/repos/wolox-training/mp-angular/stargazers","contributors_url":"https://api.github.com/repos/wolox-training/mp-angular/contributors","subscribers_url":"https://api.github.com/repos/wolox-training/mp-angular/subscribers","subscription_url":"https://api.github.com/repos/wolox-training/mp-angular/subscription","commits_url":"https://api.github.com/repos/wolox-training/mp-angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/wolox-training/mp-angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/wolox-training/mp-angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/wolox-training/mp-angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/wolox-training/mp-angular/contents/{+path}","compare_url":"https://api.github.com/repos/wolox-training/mp-angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wolox-training/mp-angular/merges","archive_url":"https://api.github.com/repos/wolox-training/mp-angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wolox-training/mp-angular/downloads","issues_url":"https://api.github.com/repos/wolox-training/mp-angular/issues{/number}","pulls_url":"https://api.github.com/repos/wolox-training/mp-angular/pulls{/number}","milestones_url":"https://api.github.com/repos/wolox-training/mp-angular/milestones{/number}","notifications_url":"https://api.github.com/repos/wolox-training/mp-angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wolox-training/mp-angular/labels{/name}","releases_url":"https://api.github.com/repos/wolox-training/mp-angular/releases{/id}","deployments_url":"https://api.github.com/repos/wolox-training/mp-angular/deployments","created_at":"2015-12-09T13:12:29Z","updated_at":"2016-03-01T19:34:24Z","pushed_at":"2016-03-28T00:46:49Z","git_url":"git://github.com/wolox-training/mp-angular.git","ssh_url":"git@github.com:wolox-training/mp-angular.git","clone_url":"https://github.com/wolox-training/mp-angular.git","svn_url":"https://github.com/wolox-training/mp-angular","homepage":"","size":339,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wolox-training/mp-angular/pulls/8"},"html":{"href":"https://github.com/wolox-training/mp-angular/pull/8"},"issue":{"href":"https://api.github.com/repos/wolox-training/mp-angular/issues/8"},"comments":{"href":"https://api.github.com/repos/wolox-training/mp-angular/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/wolox-training/mp-angular/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/wolox-training/mp-angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wolox-training/mp-angular/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/wolox-training/mp-angular/statuses/e1648ca99d371f74731f08041e2fb2ced18088c7"}}}}