{"action":"closed","issue":{"url":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/146","repository_url":"https://api.github.com/repos/firebase/FirebaseUI-Android","labels_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/146/labels{/name}","comments_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/146/comments","events_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/146/events","html_url":"https://github.com/firebase/FirebaseUI-Android/issues/146","id":157262932,"number":146,"title":"Wrong result code after password reset flow","user":{"login":"itaihanski","id":1485548,"avatar_url":"https://avatars.githubusercontent.com/u/1485548?v=3","gravatar_id":"","url":"https://api.github.com/users/itaihanski","html_url":"https://github.com/itaihanski","followers_url":"https://api.github.com/users/itaihanski/followers","following_url":"https://api.github.com/users/itaihanski/following{/other_user}","gists_url":"https://api.github.com/users/itaihanski/gists{/gist_id}","starred_url":"https://api.github.com/users/itaihanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itaihanski/subscriptions","organizations_url":"https://api.github.com/users/itaihanski/orgs","repos_url":"https://api.github.com/users/itaihanski/repos","events_url":"https://api.github.com/users/itaihanski/events{/privacy}","received_events_url":"https://api.github.com/users/itaihanski/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/firebase/FirebaseUI-Android/labels/fix-implemented","name":"fix-implemented","color":"009800"}],"state":"closed","locked":false,"assignee":{"login":"amandle","id":879468,"avatar_url":"https://avatars.githubusercontent.com/u/879468?v=3","gravatar_id":"","url":"https://api.github.com/users/amandle","html_url":"https://github.com/amandle","followers_url":"https://api.github.com/users/amandle/followers","following_url":"https://api.github.com/users/amandle/following{/other_user}","gists_url":"https://api.github.com/users/amandle/gists{/gist_id}","starred_url":"https://api.github.com/users/amandle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amandle/subscriptions","organizations_url":"https://api.github.com/users/amandle/orgs","repos_url":"https://api.github.com/users/amandle/repos","events_url":"https://api.github.com/users/amandle/events{/privacy}","received_events_url":"https://api.github.com/users/amandle/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-05-27T18:15:15Z","updated_at":"2016-05-28T00:43:37Z","closed_at":"2016-05-28T00:43:37Z","body":"When returning from the password reset flow, whether after sending a reset email or pressing back, the return code received is `RESULT_OK` even though the user is not signed in at that point.\r\n\r\nThis renders this example code snippet false:\r\n\r\n    protected void onActivityResult(int requestCode, int resultCode, Intent data) {\r\n        super.onActivityResult(requestCode, resultCode, data);\r\n        if (requestCode == RC_SIGN_IN) {\r\n            if (resultCode == RESULT_OK) {\r\n                // user is signed in!    <-- Not true in this case\r\n            } else {\r\n                // user is not signed in. Maybe just wait for the user to press\r\n                // \"sign in\" again, or show a message\r\n            }\r\n        }\r\n    }\r\n\r\nRecreate:\r\n\r\n1. Sign in with an email and a password / create a user via the console.\r\n2. Sign out / clear data\r\n3. Click the \"sign in with email\" button and provide that email address\r\n4. Click on \"trouble signing in\"\r\n5. Press back / Reset the password\r\n6. `onActivityResult` is called with `RESULT_OK`\r\n"}}
{"actor":{"display_login":"amandle"}}