{"action":"closed","number":9501,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/9501","id":64666755,"html_url":"https://github.com/xbmc/xbmc/pull/9501","diff_url":"https://github.com/xbmc/xbmc/pull/9501.diff","patch_url":"https://github.com/xbmc/xbmc/pull/9501.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/9501","number":9501,"state":"closed","locked":false,"title":"[cmake][addons] Raise an error when ADDON_SRC_PREFIX is an relative path","user":{"login":"AchimTuran","id":6927011,"avatar_url":"https://avatars.githubusercontent.com/u/6927011?v=3","gravatar_id":"","url":"https://api.github.com/users/AchimTuran","html_url":"https://github.com/AchimTuran","followers_url":"https://api.github.com/users/AchimTuran/followers","following_url":"https://api.github.com/users/AchimTuran/following{/other_user}","gists_url":"https://api.github.com/users/AchimTuran/gists{/gist_id}","starred_url":"https://api.github.com/users/AchimTuran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AchimTuran/subscriptions","organizations_url":"https://api.github.com/users/AchimTuran/orgs","repos_url":"https://api.github.com/users/AchimTuran/repos","events_url":"https://api.github.com/users/AchimTuran/events{/privacy}","received_events_url":"https://api.github.com/users/AchimTuran/received_events","type":"User","site_admin":false},"body":"@wsnipex @ksooo @AlwinEsch @FernetMenta @Jalle19 @mapfau \r\n\r\nAfter having a chat with @FernetMenta we decided that `ADDON_SRC_PREFIX` has to be an absolute path, because relative paths can easily break and you can search the issue for hours.\r\n\r\nFurthermore I adapted the README to mention that we have to use absolute paths in the future.\r\n\r\nHopefully this will keep it simple and stop confusing our devs with relative paths. But we have to adapt our Travis CI and AppVeyor scripts.","created_at":"2016-03-30T17:36:24Z","updated_at":"2016-04-09T14:17:26Z","closed_at":"2016-04-09T14:17:26Z","merged_at":null,"merge_commit_sha":"562390d196ea4e04f22904edb689755bb150e1c7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/9501/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/9501/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/9501/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/f7f38685935a60a0d8c14bb7fee8998840735f99","head":{"label":"AchimTuran:fix-ADDON_SRC_PREFIX","ref":"fix-ADDON_SRC_PREFIX","sha":"f7f38685935a60a0d8c14bb7fee8998840735f99","user":{"login":"AchimTuran","id":6927011,"avatar_url":"https://avatars.githubusercontent.com/u/6927011?v=3","gravatar_id":"","url":"https://api.github.com/users/AchimTuran","html_url":"https://github.com/AchimTuran","followers_url":"https://api.github.com/users/AchimTuran/followers","following_url":"https://api.github.com/users/AchimTuran/following{/other_user}","gists_url":"https://api.github.com/users/AchimTuran/gists{/gist_id}","starred_url":"https://api.github.com/users/AchimTuran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AchimTuran/subscriptions","organizations_url":"https://api.github.com/users/AchimTuran/orgs","repos_url":"https://api.github.com/users/AchimTuran/repos","events_url":"https://api.github.com/users/AchimTuran/events{/privacy}","received_events_url":"https://api.github.com/users/AchimTuran/received_events","type":"User","site_admin":false},"repo":{"id":25041109,"name":"xbmc","full_name":"AchimTuran/xbmc","owner":{"login":"AchimTuran","id":6927011,"avatar_url":"https://avatars.githubusercontent.com/u/6927011?v=3","gravatar_id":"","url":"https://api.github.com/users/AchimTuran","html_url":"https://github.com/AchimTuran","followers_url":"https://api.github.com/users/AchimTuran/followers","following_url":"https://api.github.com/users/AchimTuran/following{/other_user}","gists_url":"https://api.github.com/users/AchimTuran/gists{/gist_id}","starred_url":"https://api.github.com/users/AchimTuran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AchimTuran/subscriptions","organizations_url":"https://api.github.com/users/AchimTuran/orgs","repos_url":"https://api.github.com/users/AchimTuran/repos","events_url":"https://api.github.com/users/AchimTuran/events{/privacy}","received_events_url":"https://api.github.com/users/AchimTuran/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AchimTuran/xbmc","description":"Kodi Main Repository","fork":true,"url":"https://api.github.com/repos/AchimTuran/xbmc","forks_url":"https://api.github.com/repos/AchimTuran/xbmc/forks","keys_url":"https://api.github.com/repos/AchimTuran/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AchimTuran/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AchimTuran/xbmc/teams","hooks_url":"https://api.github.com/repos/AchimTuran/xbmc/hooks","issue_events_url":"https://api.github.com/repos/AchimTuran/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/AchimTuran/xbmc/events","assignees_url":"https://api.github.com/repos/AchimTuran/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/AchimTuran/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/AchimTuran/xbmc/tags","blobs_url":"https://api.github.com/repos/AchimTuran/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AchimTuran/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AchimTuran/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/AchimTuran/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AchimTuran/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/AchimTuran/xbmc/languages","stargazers_url":"https://api.github.com/repos/AchimTuran/xbmc/stargazers","contributors_url":"https://api.github.com/repos/AchimTuran/xbmc/contributors","subscribers_url":"https://api.github.com/repos/AchimTuran/xbmc/subscribers","subscription_url":"https://api.github.com/repos/AchimTuran/xbmc/subscription","commits_url":"https://api.github.com/repos/AchimTuran/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/AchimTuran/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/AchimTuran/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/AchimTuran/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/AchimTuran/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/AchimTuran/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AchimTuran/xbmc/merges","archive_url":"https://api.github.com/repos/AchimTuran/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AchimTuran/xbmc/downloads","issues_url":"https://api.github.com/repos/AchimTuran/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/AchimTuran/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/AchimTuran/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/AchimTuran/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AchimTuran/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/AchimTuran/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/AchimTuran/xbmc/deployments","created_at":"2014-10-10T15:19:34Z","updated_at":"2016-01-25T19:44:26Z","pushed_at":"2016-03-31T18:48:00Z","git_url":"git://github.com/AchimTuran/xbmc.git","ssh_url":"git@github.com:AchimTuran/xbmc.git","clone_url":"https://github.com/AchimTuran/xbmc.git","svn_url":"https://github.com/AchimTuran/xbmc","homepage":"http://kodi.tv","size":555264,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"5b9b4b5d45b4752c371b856024237b19894615cb","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2016-04-09T09:42:16Z","pushed_at":"2016-04-09T14:06:27Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1746142,"stargazers_count":4661,"watchers_count":4661,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3432,"mirror_url":null,"open_issues_count":231,"forks":3432,"open_issues":231,"watchers":4661,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9501"},"html":{"href":"https://github.com/xbmc/xbmc/pull/9501"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/9501"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/9501/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9501/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/9501/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/f7f38685935a60a0d8c14bb7fee8998840735f99"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":11,"review_comments":6,"commits":2,"additions":7,"deletions":4,"changed_files":2}}