{"action":"created","comment":{"url":"https://api.github.com/repos/autotest/tp-qemu/pulls/comments/82544692","pull_request_review_id":3442363,"id":82544692,"diff_hunk":"@@ -0,0 +1,119 @@\n+import logging\n+\n+from autotest.client.shared import utils, error\n+\n+from virttest import utils_misc\n+\n+from virttest.qemu_devices import qcontainer\n+\n+\n+@error.context_aware\n+def run(test, params, env):\n+    \"\"\"\n+    slof_device_tree test:\n+    steps:\n+    1. Boot up a guest.\n+    2. Check the guest device tree information.\n+    3. Compare the value with expected result.\n+    :param test: Kvm test object\n+    :param params: Dictionary with the test parameters\n+    :param env: Dictionary with test environment.\n+    \"\"\"\n+\n+    def get_guest_system_id(vm_session):\n+        \"\"\"\n+        Get guest system id.\n+\n+        :param vm_session: session to checked vm.\n+        :return: [guest system id]\n+        \"\"\"\n+        (status, output) = vm_session.cmd_status_output(\n+            \"echo `cat /proc/device-tree/system-id`\")\n+        if status != 0:\n+            raise error.TestError(\"Failed to get guest system id\")\n+        return output.strip()\n+\n+    def get_guest_uuid(vm_session):\n+        \"\"\"\n+        Get guest uuid.\n+\n+        :param vm_session: session to checked vm.\n+        :return: [guest uuid]","path":"qemu/tests/slof_device_tree.py","position":41,"original_position":41,"commit_id":"d706245fc5c93377fd3c918255babd1d1ae0e2cd","original_commit_id":"d706245fc5c93377fd3c918255babd1d1ae0e2cd","user":{"login":"xutian","id":1871732,"avatar_url":"https://avatars.githubusercontent.com/u/1871732?v=3","gravatar_id":"","url":"https://api.github.com/users/xutian","html_url":"https://github.com/xutian","followers_url":"https://api.github.com/users/xutian/followers","following_url":"https://api.github.com/users/xutian/following{/other_user}","gists_url":"https://api.github.com/users/xutian/gists{/gist_id}","starred_url":"https://api.github.com/users/xutian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xutian/subscriptions","organizations_url":"https://api.github.com/users/xutian/orgs","repos_url":"https://api.github.com/users/xutian/repos","events_url":"https://api.github.com/users/xutian/events{/privacy}","received_events_url":"https://api.github.com/users/xutian/received_events","type":"User","site_admin":false},"body":"it looks your output is a string not list","created_at":"2016-10-10T05:16:24Z","updated_at":"2016-10-10T05:18:24Z","html_url":"https://github.com/autotest/tp-qemu/pull/719#discussion_r82544692","pull_request_url":"https://api.github.com/repos/autotest/tp-qemu/pulls/719","_links":{"self":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/comments/82544692"},"html":{"href":"https://github.com/autotest/tp-qemu/pull/719#discussion_r82544692"},"pull_request":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/719"}}},"pull_request":{"url":"https://api.github.com/repos/autotest/tp-qemu/pulls/719","id":79521382,"html_url":"https://github.com/autotest/tp-qemu/pull/719","diff_url":"https://github.com/autotest/tp-qemu/pull/719.diff","patch_url":"https://github.com/autotest/tp-qemu/pull/719.patch","issue_url":"https://api.github.com/repos/autotest/tp-qemu/issues/719","number":719,"state":"open","locked":false,"title":"tp-qemu: Add new test case \"slof_device_tree\" for SLOF feature (ppc only)","user":{"login":"qunfang","id":12948968,"avatar_url":"https://avatars.githubusercontent.com/u/12948968?v=3","gravatar_id":"","url":"https://api.github.com/users/qunfang","html_url":"https://github.com/qunfang","followers_url":"https://api.github.com/users/qunfang/followers","following_url":"https://api.github.com/users/qunfang/following{/other_user}","gists_url":"https://api.github.com/users/qunfang/gists{/gist_id}","starred_url":"https://api.github.com/users/qunfang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qunfang/subscriptions","organizations_url":"https://api.github.com/users/qunfang/orgs","repos_url":"https://api.github.com/users/qunfang/repos","events_url":"https://api.github.com/users/qunfang/events{/privacy}","received_events_url":"https://api.github.com/users/qunfang/received_events","type":"User","site_admin":false},"body":"Add new test case for SLOF feature, check guest device tree information, compare them with the expected value.\r\n\r\nID: 1324342\r\n\r\nSigned-off-by: Qunfang Zhang <qzhang@redhat.com>","created_at":"2016-08-01T06:53:10Z","updated_at":"2016-10-10T05:18:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe6bba6519c3bb5e9d0bfe8907727c106465c15f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/autotest/tp-qemu/pulls/719/commits","review_comments_url":"https://api.github.com/repos/autotest/tp-qemu/pulls/719/comments","review_comment_url":"https://api.github.com/repos/autotest/tp-qemu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/autotest/tp-qemu/issues/719/comments","statuses_url":"https://api.github.com/repos/autotest/tp-qemu/statuses/d706245fc5c93377fd3c918255babd1d1ae0e2cd","head":{"label":"qunfang:slof_device_tree","ref":"slof_device_tree","sha":"d706245fc5c93377fd3c918255babd1d1ae0e2cd","user":{"login":"qunfang","id":12948968,"avatar_url":"https://avatars.githubusercontent.com/u/12948968?v=3","gravatar_id":"","url":"https://api.github.com/users/qunfang","html_url":"https://github.com/qunfang","followers_url":"https://api.github.com/users/qunfang/followers","following_url":"https://api.github.com/users/qunfang/following{/other_user}","gists_url":"https://api.github.com/users/qunfang/gists{/gist_id}","starred_url":"https://api.github.com/users/qunfang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qunfang/subscriptions","organizations_url":"https://api.github.com/users/qunfang/orgs","repos_url":"https://api.github.com/users/qunfang/repos","events_url":"https://api.github.com/users/qunfang/events{/privacy}","received_events_url":"https://api.github.com/users/qunfang/received_events","type":"User","site_admin":false},"repo":{"id":48212747,"name":"tp-qemu","full_name":"qunfang/tp-qemu","owner":{"login":"qunfang","id":12948968,"avatar_url":"https://avatars.githubusercontent.com/u/12948968?v=3","gravatar_id":"","url":"https://api.github.com/users/qunfang","html_url":"https://github.com/qunfang","followers_url":"https://api.github.com/users/qunfang/followers","following_url":"https://api.github.com/users/qunfang/following{/other_user}","gists_url":"https://api.github.com/users/qunfang/gists{/gist_id}","starred_url":"https://api.github.com/users/qunfang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qunfang/subscriptions","organizations_url":"https://api.github.com/users/qunfang/orgs","repos_url":"https://api.github.com/users/qunfang/repos","events_url":"https://api.github.com/users/qunfang/events{/privacy}","received_events_url":"https://api.github.com/users/qunfang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qunfang/tp-qemu","description":"Virt Test Provider for qemu and other related virtualization backends","fork":true,"url":"https://api.github.com/repos/qunfang/tp-qemu","forks_url":"https://api.github.com/repos/qunfang/tp-qemu/forks","keys_url":"https://api.github.com/repos/qunfang/tp-qemu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qunfang/tp-qemu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qunfang/tp-qemu/teams","hooks_url":"https://api.github.com/repos/qunfang/tp-qemu/hooks","issue_events_url":"https://api.github.com/repos/qunfang/tp-qemu/issues/events{/number}","events_url":"https://api.github.com/repos/qunfang/tp-qemu/events","assignees_url":"https://api.github.com/repos/qunfang/tp-qemu/assignees{/user}","branches_url":"https://api.github.com/repos/qunfang/tp-qemu/branches{/branch}","tags_url":"https://api.github.com/repos/qunfang/tp-qemu/tags","blobs_url":"https://api.github.com/repos/qunfang/tp-qemu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qunfang/tp-qemu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qunfang/tp-qemu/git/refs{/sha}","trees_url":"https://api.github.com/repos/qunfang/tp-qemu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qunfang/tp-qemu/statuses/{sha}","languages_url":"https://api.github.com/repos/qunfang/tp-qemu/languages","stargazers_url":"https://api.github.com/repos/qunfang/tp-qemu/stargazers","contributors_url":"https://api.github.com/repos/qunfang/tp-qemu/contributors","subscribers_url":"https://api.github.com/repos/qunfang/tp-qemu/subscribers","subscription_url":"https://api.github.com/repos/qunfang/tp-qemu/subscription","commits_url":"https://api.github.com/repos/qunfang/tp-qemu/commits{/sha}","git_commits_url":"https://api.github.com/repos/qunfang/tp-qemu/git/commits{/sha}","comments_url":"https://api.github.com/repos/qunfang/tp-qemu/comments{/number}","issue_comment_url":"https://api.github.com/repos/qunfang/tp-qemu/issues/comments{/number}","contents_url":"https://api.github.com/repos/qunfang/tp-qemu/contents/{+path}","compare_url":"https://api.github.com/repos/qunfang/tp-qemu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qunfang/tp-qemu/merges","archive_url":"https://api.github.com/repos/qunfang/tp-qemu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qunfang/tp-qemu/downloads","issues_url":"https://api.github.com/repos/qunfang/tp-qemu/issues{/number}","pulls_url":"https://api.github.com/repos/qunfang/tp-qemu/pulls{/number}","milestones_url":"https://api.github.com/repos/qunfang/tp-qemu/milestones{/number}","notifications_url":"https://api.github.com/repos/qunfang/tp-qemu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qunfang/tp-qemu/labels{/name}","releases_url":"https://api.github.com/repos/qunfang/tp-qemu/releases{/id}","deployments_url":"https://api.github.com/repos/qunfang/tp-qemu/deployments","created_at":"2015-12-18T03:37:19Z","updated_at":"2015-12-18T03:37:22Z","pushed_at":"2016-08-10T06:21:58Z","git_url":"git://github.com/qunfang/tp-qemu.git","ssh_url":"git@github.com:qunfang/tp-qemu.git","clone_url":"https://github.com/qunfang/tp-qemu.git","svn_url":"https://github.com/qunfang/tp-qemu","homepage":null,"size":11494,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"autotest:master","ref":"master","sha":"a7f167a28463302a613b39aee6cb87ec3fe6e419","user":{"login":"autotest","id":472856,"avatar_url":"https://avatars.githubusercontent.com/u/472856?v=3","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"repo":{"id":16180304,"name":"tp-qemu","full_name":"autotest/tp-qemu","owner":{"login":"autotest","id":472856,"avatar_url":"https://avatars.githubusercontent.com/u/472856?v=3","gravatar_id":"","url":"https://api.github.com/users/autotest","html_url":"https://github.com/autotest","followers_url":"https://api.github.com/users/autotest/followers","following_url":"https://api.github.com/users/autotest/following{/other_user}","gists_url":"https://api.github.com/users/autotest/gists{/gist_id}","starred_url":"https://api.github.com/users/autotest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autotest/subscriptions","organizations_url":"https://api.github.com/users/autotest/orgs","repos_url":"https://api.github.com/users/autotest/repos","events_url":"https://api.github.com/users/autotest/events{/privacy}","received_events_url":"https://api.github.com/users/autotest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/autotest/tp-qemu","description":"Virt Test Provider for qemu and other related virtualization backends","fork":false,"url":"https://api.github.com/repos/autotest/tp-qemu","forks_url":"https://api.github.com/repos/autotest/tp-qemu/forks","keys_url":"https://api.github.com/repos/autotest/tp-qemu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/autotest/tp-qemu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/autotest/tp-qemu/teams","hooks_url":"https://api.github.com/repos/autotest/tp-qemu/hooks","issue_events_url":"https://api.github.com/repos/autotest/tp-qemu/issues/events{/number}","events_url":"https://api.github.com/repos/autotest/tp-qemu/events","assignees_url":"https://api.github.com/repos/autotest/tp-qemu/assignees{/user}","branches_url":"https://api.github.com/repos/autotest/tp-qemu/branches{/branch}","tags_url":"https://api.github.com/repos/autotest/tp-qemu/tags","blobs_url":"https://api.github.com/repos/autotest/tp-qemu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/autotest/tp-qemu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/autotest/tp-qemu/git/refs{/sha}","trees_url":"https://api.github.com/repos/autotest/tp-qemu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/autotest/tp-qemu/statuses/{sha}","languages_url":"https://api.github.com/repos/autotest/tp-qemu/languages","stargazers_url":"https://api.github.com/repos/autotest/tp-qemu/stargazers","contributors_url":"https://api.github.com/repos/autotest/tp-qemu/contributors","subscribers_url":"https://api.github.com/repos/autotest/tp-qemu/subscribers","subscription_url":"https://api.github.com/repos/autotest/tp-qemu/subscription","commits_url":"https://api.github.com/repos/autotest/tp-qemu/commits{/sha}","git_commits_url":"https://api.github.com/repos/autotest/tp-qemu/git/commits{/sha}","comments_url":"https://api.github.com/repos/autotest/tp-qemu/comments{/number}","issue_comment_url":"https://api.github.com/repos/autotest/tp-qemu/issues/comments{/number}","contents_url":"https://api.github.com/repos/autotest/tp-qemu/contents/{+path}","compare_url":"https://api.github.com/repos/autotest/tp-qemu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/autotest/tp-qemu/merges","archive_url":"https://api.github.com/repos/autotest/tp-qemu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/autotest/tp-qemu/downloads","issues_url":"https://api.github.com/repos/autotest/tp-qemu/issues{/number}","pulls_url":"https://api.github.com/repos/autotest/tp-qemu/pulls{/number}","milestones_url":"https://api.github.com/repos/autotest/tp-qemu/milestones{/number}","notifications_url":"https://api.github.com/repos/autotest/tp-qemu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/autotest/tp-qemu/labels{/name}","releases_url":"https://api.github.com/repos/autotest/tp-qemu/releases{/id}","deployments_url":"https://api.github.com/repos/autotest/tp-qemu/deployments","created_at":"2014-01-23T17:51:34Z","updated_at":"2016-08-25T01:57:00Z","pushed_at":"2016-10-10T03:36:10Z","git_url":"git://github.com/autotest/tp-qemu.git","ssh_url":"git@github.com:autotest/tp-qemu.git","clone_url":"https://github.com/autotest/tp-qemu.git","svn_url":"https://github.com/autotest/tp-qemu","homepage":null,"size":12034,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":34,"forks":73,"open_issues":34,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/719"},"html":{"href":"https://github.com/autotest/tp-qemu/pull/719"},"issue":{"href":"https://api.github.com/repos/autotest/tp-qemu/issues/719"},"comments":{"href":"https://api.github.com/repos/autotest/tp-qemu/issues/719/comments"},"review_comments":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/719/comments"},"review_comment":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/autotest/tp-qemu/pulls/719/commits"},"statuses":{"href":"https://api.github.com/repos/autotest/tp-qemu/statuses/d706245fc5c93377fd3c918255babd1d1ae0e2cd"}}}}
{"actor":{"display_login":"xutian"}}