{"action":"closed","number":777,"pull_request":{"url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/777","id":64629026,"html_url":"https://github.com/gnuradio/gnuradio/pull/777","diff_url":"https://github.com/gnuradio/gnuradio/pull/777.diff","patch_url":"https://github.com/gnuradio/gnuradio/pull/777.patch","issue_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/777","number":777,"state":"closed","locked":false,"title":"Issue #857 FM emphasis filters","user":{"login":"awalls-cx18","id":1452915,"avatar_url":"https://avatars.githubusercontent.com/u/1452915?v=3","gravatar_id":"","url":"https://api.github.com/users/awalls-cx18","html_url":"https://github.com/awalls-cx18","followers_url":"https://api.github.com/users/awalls-cx18/followers","following_url":"https://api.github.com/users/awalls-cx18/following{/other_user}","gists_url":"https://api.github.com/users/awalls-cx18/gists{/gist_id}","starred_url":"https://api.github.com/users/awalls-cx18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awalls-cx18/subscriptions","organizations_url":"https://api.github.com/users/awalls-cx18/orgs","repos_url":"https://api.github.com/users/awalls-cx18/repos","events_url":"https://api.github.com/users/awalls-cx18/events{/privacy}","received_events_url":"https://api.github.com/users/awalls-cx18/received_events","type":"User","site_admin":false},"body":"This change set reworks the FM deemphasis and and preemphasis IIR filters.  It should address Issue #857.\r\n\r\nI have examined the resulting filter curves in octave and gnuradio (using a noise source and QT freq sink) and the characteristics appear to be OK.  The demphasis exactly cancels the preemphasis, except at the very high frequencies at and above the high corner frequency fh of the preemphasis filter, as expected.\r\n\r\nI did not rigorously verify the +/- 6 dB/octave slopes, nor did I listen to actual FM audio through the filters.  There should be enough information in the comments for anyone to verify the bilinear transformation algebra.\r\n\r\nI have added new properties to GRC blocks that may break existing FM Tx flowgraphs (potentially undefined value for the fh property in a few blocks' XML files .  I have no qualms about this since the FM emphasis filter is going to gain things up and possibly cause FM spectrum usage to be wider.  People engineering FM transmitters need to check their spectral compliance with a change like this anyway.","created_at":"2016-03-30T13:42:37Z","updated_at":"2016-03-31T05:49:27Z","closed_at":"2016-03-31T05:49:27Z","merged_at":"2016-03-31T05:49:27Z","merge_commit_sha":"dd625eb88aa0df7894aaf8cc0840b8279e7a681e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/777/commits","review_comments_url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/777/comments","review_comment_url":"https://api.github.com/repos/gnuradio/gnuradio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/777/comments","statuses_url":"https://api.github.com/repos/gnuradio/gnuradio/statuses/dd625eb88aa0df7894aaf8cc0840b8279e7a681e","head":{"label":"awalls-cx18:fm_emphasis_filter","ref":"fm_emphasis_filter","sha":"dd625eb88aa0df7894aaf8cc0840b8279e7a681e","user":{"login":"awalls-cx18","id":1452915,"avatar_url":"https://avatars.githubusercontent.com/u/1452915?v=3","gravatar_id":"","url":"https://api.github.com/users/awalls-cx18","html_url":"https://github.com/awalls-cx18","followers_url":"https://api.github.com/users/awalls-cx18/followers","following_url":"https://api.github.com/users/awalls-cx18/following{/other_user}","gists_url":"https://api.github.com/users/awalls-cx18/gists{/gist_id}","starred_url":"https://api.github.com/users/awalls-cx18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awalls-cx18/subscriptions","organizations_url":"https://api.github.com/users/awalls-cx18/orgs","repos_url":"https://api.github.com/users/awalls-cx18/repos","events_url":"https://api.github.com/users/awalls-cx18/events{/privacy}","received_events_url":"https://api.github.com/users/awalls-cx18/received_events","type":"User","site_admin":false},"repo":{"id":29106745,"name":"gnuradio","full_name":"awalls-cx18/gnuradio","owner":{"login":"awalls-cx18","id":1452915,"avatar_url":"https://avatars.githubusercontent.com/u/1452915?v=3","gravatar_id":"","url":"https://api.github.com/users/awalls-cx18","html_url":"https://github.com/awalls-cx18","followers_url":"https://api.github.com/users/awalls-cx18/followers","following_url":"https://api.github.com/users/awalls-cx18/following{/other_user}","gists_url":"https://api.github.com/users/awalls-cx18/gists{/gist_id}","starred_url":"https://api.github.com/users/awalls-cx18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awalls-cx18/subscriptions","organizations_url":"https://api.github.com/users/awalls-cx18/orgs","repos_url":"https://api.github.com/users/awalls-cx18/repos","events_url":"https://api.github.com/users/awalls-cx18/events{/privacy}","received_events_url":"https://api.github.com/users/awalls-cx18/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/awalls-cx18/gnuradio","description":"GNU Radio","fork":true,"url":"https://api.github.com/repos/awalls-cx18/gnuradio","forks_url":"https://api.github.com/repos/awalls-cx18/gnuradio/forks","keys_url":"https://api.github.com/repos/awalls-cx18/gnuradio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awalls-cx18/gnuradio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awalls-cx18/gnuradio/teams","hooks_url":"https://api.github.com/repos/awalls-cx18/gnuradio/hooks","issue_events_url":"https://api.github.com/repos/awalls-cx18/gnuradio/issues/events{/number}","events_url":"https://api.github.com/repos/awalls-cx18/gnuradio/events","assignees_url":"https://api.github.com/repos/awalls-cx18/gnuradio/assignees{/user}","branches_url":"https://api.github.com/repos/awalls-cx18/gnuradio/branches{/branch}","tags_url":"https://api.github.com/repos/awalls-cx18/gnuradio/tags","blobs_url":"https://api.github.com/repos/awalls-cx18/gnuradio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awalls-cx18/gnuradio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awalls-cx18/gnuradio/git/refs{/sha}","trees_url":"https://api.github.com/repos/awalls-cx18/gnuradio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awalls-cx18/gnuradio/statuses/{sha}","languages_url":"https://api.github.com/repos/awalls-cx18/gnuradio/languages","stargazers_url":"https://api.github.com/repos/awalls-cx18/gnuradio/stargazers","contributors_url":"https://api.github.com/repos/awalls-cx18/gnuradio/contributors","subscribers_url":"https://api.github.com/repos/awalls-cx18/gnuradio/subscribers","subscription_url":"https://api.github.com/repos/awalls-cx18/gnuradio/subscription","commits_url":"https://api.github.com/repos/awalls-cx18/gnuradio/commits{/sha}","git_commits_url":"https://api.github.com/repos/awalls-cx18/gnuradio/git/commits{/sha}","comments_url":"https://api.github.com/repos/awalls-cx18/gnuradio/comments{/number}","issue_comment_url":"https://api.github.com/repos/awalls-cx18/gnuradio/issues/comments{/number}","contents_url":"https://api.github.com/repos/awalls-cx18/gnuradio/contents/{+path}","compare_url":"https://api.github.com/repos/awalls-cx18/gnuradio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awalls-cx18/gnuradio/merges","archive_url":"https://api.github.com/repos/awalls-cx18/gnuradio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awalls-cx18/gnuradio/downloads","issues_url":"https://api.github.com/repos/awalls-cx18/gnuradio/issues{/number}","pulls_url":"https://api.github.com/repos/awalls-cx18/gnuradio/pulls{/number}","milestones_url":"https://api.github.com/repos/awalls-cx18/gnuradio/milestones{/number}","notifications_url":"https://api.github.com/repos/awalls-cx18/gnuradio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awalls-cx18/gnuradio/labels{/name}","releases_url":"https://api.github.com/repos/awalls-cx18/gnuradio/releases{/id}","deployments_url":"https://api.github.com/repos/awalls-cx18/gnuradio/deployments","created_at":"2015-01-11T21:27:08Z","updated_at":"2016-02-27T14:55:20Z","pushed_at":"2016-03-30T15:06:44Z","git_url":"git://github.com/awalls-cx18/gnuradio.git","ssh_url":"git@github.com:awalls-cx18/gnuradio.git","clone_url":"https://github.com/awalls-cx18/gnuradio.git","svn_url":"https://github.com/awalls-cx18/gnuradio","homepage":"gnuradio.org","size":45374,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gnuradio:master","ref":"master","sha":"0a185537075ceb3a985f3a5cf198cb3b76c039a2","user":{"login":"gnuradio","id":1278659,"avatar_url":"https://avatars.githubusercontent.com/u/1278659?v=3","gravatar_id":"","url":"https://api.github.com/users/gnuradio","html_url":"https://github.com/gnuradio","followers_url":"https://api.github.com/users/gnuradio/followers","following_url":"https://api.github.com/users/gnuradio/following{/other_user}","gists_url":"https://api.github.com/users/gnuradio/gists{/gist_id}","starred_url":"https://api.github.com/users/gnuradio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnuradio/subscriptions","organizations_url":"https://api.github.com/users/gnuradio/orgs","repos_url":"https://api.github.com/users/gnuradio/repos","events_url":"https://api.github.com/users/gnuradio/events{/privacy}","received_events_url":"https://api.github.com/users/gnuradio/received_events","type":"Organization","site_admin":false},"repo":{"id":3030065,"name":"gnuradio","full_name":"gnuradio/gnuradio","owner":{"login":"gnuradio","id":1278659,"avatar_url":"https://avatars.githubusercontent.com/u/1278659?v=3","gravatar_id":"","url":"https://api.github.com/users/gnuradio","html_url":"https://github.com/gnuradio","followers_url":"https://api.github.com/users/gnuradio/followers","following_url":"https://api.github.com/users/gnuradio/following{/other_user}","gists_url":"https://api.github.com/users/gnuradio/gists{/gist_id}","starred_url":"https://api.github.com/users/gnuradio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnuradio/subscriptions","organizations_url":"https://api.github.com/users/gnuradio/orgs","repos_url":"https://api.github.com/users/gnuradio/repos","events_url":"https://api.github.com/users/gnuradio/events{/privacy}","received_events_url":"https://api.github.com/users/gnuradio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gnuradio/gnuradio","description":"GNU Radio","fork":false,"url":"https://api.github.com/repos/gnuradio/gnuradio","forks_url":"https://api.github.com/repos/gnuradio/gnuradio/forks","keys_url":"https://api.github.com/repos/gnuradio/gnuradio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnuradio/gnuradio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnuradio/gnuradio/teams","hooks_url":"https://api.github.com/repos/gnuradio/gnuradio/hooks","issue_events_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/events{/number}","events_url":"https://api.github.com/repos/gnuradio/gnuradio/events","assignees_url":"https://api.github.com/repos/gnuradio/gnuradio/assignees{/user}","branches_url":"https://api.github.com/repos/gnuradio/gnuradio/branches{/branch}","tags_url":"https://api.github.com/repos/gnuradio/gnuradio/tags","blobs_url":"https://api.github.com/repos/gnuradio/gnuradio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnuradio/gnuradio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnuradio/gnuradio/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnuradio/gnuradio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnuradio/gnuradio/statuses/{sha}","languages_url":"https://api.github.com/repos/gnuradio/gnuradio/languages","stargazers_url":"https://api.github.com/repos/gnuradio/gnuradio/stargazers","contributors_url":"https://api.github.com/repos/gnuradio/gnuradio/contributors","subscribers_url":"https://api.github.com/repos/gnuradio/gnuradio/subscribers","subscription_url":"https://api.github.com/repos/gnuradio/gnuradio/subscription","commits_url":"https://api.github.com/repos/gnuradio/gnuradio/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnuradio/gnuradio/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnuradio/gnuradio/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnuradio/gnuradio/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnuradio/gnuradio/contents/{+path}","compare_url":"https://api.github.com/repos/gnuradio/gnuradio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnuradio/gnuradio/merges","archive_url":"https://api.github.com/repos/gnuradio/gnuradio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnuradio/gnuradio/downloads","issues_url":"https://api.github.com/repos/gnuradio/gnuradio/issues{/number}","pulls_url":"https://api.github.com/repos/gnuradio/gnuradio/pulls{/number}","milestones_url":"https://api.github.com/repos/gnuradio/gnuradio/milestones{/number}","notifications_url":"https://api.github.com/repos/gnuradio/gnuradio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnuradio/gnuradio/labels{/name}","releases_url":"https://api.github.com/repos/gnuradio/gnuradio/releases{/id}","deployments_url":"https://api.github.com/repos/gnuradio/gnuradio/deployments","created_at":"2011-12-21T22:05:37Z","updated_at":"2016-03-25T11:49:32Z","pushed_at":"2016-03-31T05:49:25Z","git_url":"git://github.com/gnuradio/gnuradio.git","ssh_url":"git@github.com:gnuradio/gnuradio.git","clone_url":"https://github.com/gnuradio/gnuradio.git","svn_url":"https://github.com/gnuradio/gnuradio","homepage":"gnuradio.org","size":54207,"stargazers_count":436,"watchers_count":436,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":427,"mirror_url":null,"open_issues_count":9,"forks":427,"open_issues":9,"watchers":436,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/777"},"html":{"href":"https://github.com/gnuradio/gnuradio/pull/777"},"issue":{"href":"https://api.github.com/repos/gnuradio/gnuradio/issues/777"},"comments":{"href":"https://api.github.com/repos/gnuradio/gnuradio/issues/777/comments"},"review_comments":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/777/comments"},"review_comment":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gnuradio/gnuradio/pulls/777/commits"},"statuses":{"href":"https://api.github.com/repos/gnuradio/gnuradio/statuses/dd625eb88aa0df7894aaf8cc0840b8279e7a681e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jmcorgan","id":1492956,"avatar_url":"https://avatars.githubusercontent.com/u/1492956?v=3","gravatar_id":"","url":"https://api.github.com/users/jmcorgan","html_url":"https://github.com/jmcorgan","followers_url":"https://api.github.com/users/jmcorgan/followers","following_url":"https://api.github.com/users/jmcorgan/following{/other_user}","gists_url":"https://api.github.com/users/jmcorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcorgan/subscriptions","organizations_url":"https://api.github.com/users/jmcorgan/orgs","repos_url":"https://api.github.com/users/jmcorgan/repos","events_url":"https://api.github.com/users/jmcorgan/events{/privacy}","received_events_url":"https://api.github.com/users/jmcorgan/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":4,"additions":243,"deletions":56,"changed_files":10}}