{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7218","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7218/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7218/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7218/events","html_url":"https://github.com/cockroachdb/cockroach/pull/7218","id":160210418,"number":7218,"title":"sql: fix TestSchemaChangeReverseMutations","user":{"login":"vivekmenezes","id":11774212,"avatar_url":"https://avatars.githubusercontent.com/u/11774212?v=3","gravatar_id":"","url":"https://api.github.com/users/vivekmenezes","html_url":"https://github.com/vivekmenezes","followers_url":"https://api.github.com/users/vivekmenezes/followers","following_url":"https://api.github.com/users/vivekmenezes/following{/other_user}","gists_url":"https://api.github.com/users/vivekmenezes/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekmenezes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekmenezes/subscriptions","organizations_url":"https://api.github.com/users/vivekmenezes/orgs","repos_url":"https://api.github.com/users/vivekmenezes/repos","events_url":"https://api.github.com/users/vivekmenezes/events{/privacy}","received_events_url":"https://api.github.com/users/vivekmenezes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"andreimatei","id":377201,"avatar_url":"https://avatars.githubusercontent.com/u/377201?v=3","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2016-06-14T15:24:23Z","updated_at":"2016-06-14T19:27:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/7218","html_url":"https://github.com/cockroachdb/cockroach/pull/7218","diff_url":"https://github.com/cockroachdb/cockroach/pull/7218.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/7218.patch"},"body":"fixes #7210\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/7218)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/225989741","html_url":"https://github.com/cockroachdb/cockroach/pull/7218#issuecomment-225989741","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/7218","id":225989741,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2016-06-14T19:27:08Z","updated_at":"2016-06-14T19:27:08Z","body":"\n\n\n\nReviewed 1 of 1 files at r3.\nReview status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.\n\n---\n\n*[sql/schema_changer_test.go, line 995 \\[r2\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/7218#-KKF1Ptz4kUFwwjEY5jI:-KKFNG1HiyercQyrwRXb:2087597974) ([raw file](https://github.com/cockroachdb/cockroach/blob/3567f26e5d9a5a3ec08db509cdb3ef00d161819a/sql/schema_changer_test.go#L995)):*\n<details><summary><i>Previously, vivekmenezes wrote…</i></summary>\n> done\n</details>\nsorry, i meant for `expectedCols := []string{\"k\", \"b\"}` - currently you're still hardcoding `2`\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/7218)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"tamird"}}