{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/comments/81377934","pull_request_review_id":2363802,"id":81377934,"diff_hunk":"@@ -145,7 +145,10 @@ public static void InitializeForTesting(List<TypeInfo> serializationProviders =\n                 BufferPool.InitGlobalBufferPool(new MessagingConfiguration(false));\n                 RegisterSerializationProviders(serializationProviders);\n                 AssemblyProcessor.Initialize();\n+#if !NETSTANDARD_TODO\n+                 //blocked by Cannot use binary formatter as fallback serializer while running on .Net Core\n                 fallbackSerializer = GetFallbackSerializer();\n+#endif","path":"src/Orleans/Serialization/SerializationManager.cs","position":7,"original_position":7,"commit_id":"18723a9b3ca6498a38d868053c6eb2bcd93cfff0","original_commit_id":"18723a9b3ca6498a38d868053c6eb2bcd93cfff0","user":{"login":"jdom","id":1361686,"avatar_url":"https://avatars.githubusercontent.com/u/1361686?v=3","gravatar_id":"","url":"https://api.github.com/users/jdom","html_url":"https://github.com/jdom","followers_url":"https://api.github.com/users/jdom/followers","following_url":"https://api.github.com/users/jdom/following{/other_user}","gists_url":"https://api.github.com/users/jdom/gists{/gist_id}","starred_url":"https://api.github.com/users/jdom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdom/subscriptions","organizations_url":"https://api.github.com/users/jdom/orgs","repos_url":"https://api.github.com/users/jdom/repos","events_url":"https://api.github.com/users/jdom/events{/privacy}","received_events_url":"https://api.github.com/users/jdom/received_events","type":"User","site_admin":false},"body":"there's already an #if in the GetFallbackSerializer method itself, please change that to return null if that's what you want to do termporarily.","created_at":"2016-09-30T17:01:51Z","updated_at":"2016-09-30T17:01:51Z","html_url":"https://github.com/dotnet/orleans/pull/2234#discussion_r81377934","pull_request_url":"https://api.github.com/repos/dotnet/orleans/pulls/2234","_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments/81377934"},"html":{"href":"https://github.com/dotnet/orleans/pull/2234#discussion_r81377934"},"pull_request":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/2234"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/2234","id":87038669,"html_url":"https://github.com/dotnet/orleans/pull/2234","diff_url":"https://github.com/dotnet/orleans/pull/2234.diff","patch_url":"https://github.com/dotnet/orleans/pull/2234.patch","issue_url":"https://api.github.com/repos/dotnet/orleans/issues/2234","number":2234,"state":"open","locked":false,"title":"port SchedulerTests and SerializerTests and ConfigTests to vNext","user":{"login":"xiazen","id":20803801,"avatar_url":"https://avatars.githubusercontent.com/u/20803801?v=3","gravatar_id":"","url":"https://api.github.com/users/xiazen","html_url":"https://github.com/xiazen","followers_url":"https://api.github.com/users/xiazen/followers","following_url":"https://api.github.com/users/xiazen/following{/other_user}","gists_url":"https://api.github.com/users/xiazen/gists{/gist_id}","starred_url":"https://api.github.com/users/xiazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiazen/subscriptions","organizations_url":"https://api.github.com/users/xiazen/orgs","repos_url":"https://api.github.com/users/xiazen/repos","events_url":"https://api.github.com/users/xiazen/events{/privacy}","received_events_url":"https://api.github.com/users/xiazen/received_events","type":"User","site_admin":false},"body":"1. Tests not inside !NETSTANDARD_TODO builds and pass successfully\r\n2. For tests which failed , I marked it with !NETSTANDARD_TODO and also its blocker, based on my short investigation\r\n3. @ReubenBond  I port over more serialization tests, I think you will be interested to take a look  I saw your message on Gitter. \r\n","created_at":"2016-09-28T01:01:48Z","updated_at":"2016-09-30T17:01:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe810750dbf412bf5d6540e49cc525f3fb7ae7d6","assignee":{"login":"jdom","id":1361686,"avatar_url":"https://avatars.githubusercontent.com/u/1361686?v=3","gravatar_id":"","url":"https://api.github.com/users/jdom","html_url":"https://github.com/jdom","followers_url":"https://api.github.com/users/jdom/followers","following_url":"https://api.github.com/users/jdom/following{/other_user}","gists_url":"https://api.github.com/users/jdom/gists{/gist_id}","starred_url":"https://api.github.com/users/jdom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdom/subscriptions","organizations_url":"https://api.github.com/users/jdom/orgs","repos_url":"https://api.github.com/users/jdom/repos","events_url":"https://api.github.com/users/jdom/events{/privacy}","received_events_url":"https://api.github.com/users/jdom/received_events","type":"User","site_admin":false},"assignees":[{"login":"jdom","id":1361686,"avatar_url":"https://avatars.githubusercontent.com/u/1361686?v=3","gravatar_id":"","url":"https://api.github.com/users/jdom","html_url":"https://github.com/jdom","followers_url":"https://api.github.com/users/jdom/followers","following_url":"https://api.github.com/users/jdom/following{/other_user}","gists_url":"https://api.github.com/users/jdom/gists{/gist_id}","starred_url":"https://api.github.com/users/jdom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdom/subscriptions","organizations_url":"https://api.github.com/users/jdom/orgs","repos_url":"https://api.github.com/users/jdom/repos","events_url":"https://api.github.com/users/jdom/events{/privacy}","received_events_url":"https://api.github.com/users/jdom/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/orleans/pulls/2234/commits","review_comments_url":"https://api.github.com/repos/dotnet/orleans/pulls/2234/comments","review_comment_url":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/orleans/issues/2234/comments","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/18723a9b3ca6498a38d868053c6eb2bcd93cfff0","head":{"label":"xiazen:port-non-silo-tests-2","ref":"port-non-silo-tests-2","sha":"18723a9b3ca6498a38d868053c6eb2bcd93cfff0","user":{"login":"xiazen","id":20803801,"avatar_url":"https://avatars.githubusercontent.com/u/20803801?v=3","gravatar_id":"","url":"https://api.github.com/users/xiazen","html_url":"https://github.com/xiazen","followers_url":"https://api.github.com/users/xiazen/followers","following_url":"https://api.github.com/users/xiazen/following{/other_user}","gists_url":"https://api.github.com/users/xiazen/gists{/gist_id}","starred_url":"https://api.github.com/users/xiazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiazen/subscriptions","organizations_url":"https://api.github.com/users/xiazen/orgs","repos_url":"https://api.github.com/users/xiazen/repos","events_url":"https://api.github.com/users/xiazen/events{/privacy}","received_events_url":"https://api.github.com/users/xiazen/received_events","type":"User","site_admin":false},"repo":{"id":66402876,"name":"orleans-xiazen","full_name":"xiazen/orleans-xiazen","owner":{"login":"xiazen","id":20803801,"avatar_url":"https://avatars.githubusercontent.com/u/20803801?v=3","gravatar_id":"","url":"https://api.github.com/users/xiazen","html_url":"https://github.com/xiazen","followers_url":"https://api.github.com/users/xiazen/followers","following_url":"https://api.github.com/users/xiazen/following{/other_user}","gists_url":"https://api.github.com/users/xiazen/gists{/gist_id}","starred_url":"https://api.github.com/users/xiazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiazen/subscriptions","organizations_url":"https://api.github.com/users/xiazen/orgs","repos_url":"https://api.github.com/users/xiazen/repos","events_url":"https://api.github.com/users/xiazen/events{/privacy}","received_events_url":"https://api.github.com/users/xiazen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xiazen/orleans-xiazen","description":"Orleans - Distributed Virtual Actor Model","fork":true,"url":"https://api.github.com/repos/xiazen/orleans-xiazen","forks_url":"https://api.github.com/repos/xiazen/orleans-xiazen/forks","keys_url":"https://api.github.com/repos/xiazen/orleans-xiazen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiazen/orleans-xiazen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiazen/orleans-xiazen/teams","hooks_url":"https://api.github.com/repos/xiazen/orleans-xiazen/hooks","issue_events_url":"https://api.github.com/repos/xiazen/orleans-xiazen/issues/events{/number}","events_url":"https://api.github.com/repos/xiazen/orleans-xiazen/events","assignees_url":"https://api.github.com/repos/xiazen/orleans-xiazen/assignees{/user}","branches_url":"https://api.github.com/repos/xiazen/orleans-xiazen/branches{/branch}","tags_url":"https://api.github.com/repos/xiazen/orleans-xiazen/tags","blobs_url":"https://api.github.com/repos/xiazen/orleans-xiazen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiazen/orleans-xiazen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiazen/orleans-xiazen/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiazen/orleans-xiazen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiazen/orleans-xiazen/statuses/{sha}","languages_url":"https://api.github.com/repos/xiazen/orleans-xiazen/languages","stargazers_url":"https://api.github.com/repos/xiazen/orleans-xiazen/stargazers","contributors_url":"https://api.github.com/repos/xiazen/orleans-xiazen/contributors","subscribers_url":"https://api.github.com/repos/xiazen/orleans-xiazen/subscribers","subscription_url":"https://api.github.com/repos/xiazen/orleans-xiazen/subscription","commits_url":"https://api.github.com/repos/xiazen/orleans-xiazen/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiazen/orleans-xiazen/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiazen/orleans-xiazen/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiazen/orleans-xiazen/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiazen/orleans-xiazen/contents/{+path}","compare_url":"https://api.github.com/repos/xiazen/orleans-xiazen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiazen/orleans-xiazen/merges","archive_url":"https://api.github.com/repos/xiazen/orleans-xiazen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiazen/orleans-xiazen/downloads","issues_url":"https://api.github.com/repos/xiazen/orleans-xiazen/issues{/number}","pulls_url":"https://api.github.com/repos/xiazen/orleans-xiazen/pulls{/number}","milestones_url":"https://api.github.com/repos/xiazen/orleans-xiazen/milestones{/number}","notifications_url":"https://api.github.com/repos/xiazen/orleans-xiazen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiazen/orleans-xiazen/labels{/name}","releases_url":"https://api.github.com/repos/xiazen/orleans-xiazen/releases{/id}","deployments_url":"https://api.github.com/repos/xiazen/orleans-xiazen/deployments","created_at":"2016-08-23T20:59:50Z","updated_at":"2016-08-23T21:20:56Z","pushed_at":"2016-09-29T05:01:10Z","git_url":"git://github.com/xiazen/orleans-xiazen.git","ssh_url":"git@github.com:xiazen/orleans-xiazen.git","clone_url":"https://github.com/xiazen/orleans-xiazen.git","svn_url":"https://github.com/xiazen/orleans-xiazen","homepage":"http://dotnet.github.io/orleans","size":28542,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"8767f655206ec1c7afdf3aaef22ae4937089fe85","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":28232663,"name":"orleans","full_name":"dotnet/orleans","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":false,"url":"https://api.github.com/repos/dotnet/orleans","forks_url":"https://api.github.com/repos/dotnet/orleans/forks","keys_url":"https://api.github.com/repos/dotnet/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/orleans/teams","hooks_url":"https://api.github.com/repos/dotnet/orleans/hooks","issue_events_url":"https://api.github.com/repos/dotnet/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/orleans/events","assignees_url":"https://api.github.com/repos/dotnet/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/orleans/tags","blobs_url":"https://api.github.com/repos/dotnet/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/orleans/languages","stargazers_url":"https://api.github.com/repos/dotnet/orleans/stargazers","contributors_url":"https://api.github.com/repos/dotnet/orleans/contributors","subscribers_url":"https://api.github.com/repos/dotnet/orleans/subscribers","subscription_url":"https://api.github.com/repos/dotnet/orleans/subscription","commits_url":"https://api.github.com/repos/dotnet/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/orleans/merges","archive_url":"https://api.github.com/repos/dotnet/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/orleans/downloads","issues_url":"https://api.github.com/repos/dotnet/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/orleans/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/orleans/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/orleans/deployments","created_at":"2014-12-19T14:32:50Z","updated_at":"2016-09-30T08:29:31Z","pushed_at":"2016-09-30T15:02:19Z","git_url":"git://github.com/dotnet/orleans.git","ssh_url":"git@github.com:dotnet/orleans.git","clone_url":"https://github.com/dotnet/orleans.git","svn_url":"https://github.com/dotnet/orleans","homepage":"http://dotnet.github.io/orleans","size":50877,"stargazers_count":2258,"watchers_count":2258,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":553,"mirror_url":null,"open_issues_count":286,"forks":553,"open_issues":286,"watchers":2258,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/2234"},"html":{"href":"https://github.com/dotnet/orleans/pull/2234"},"issue":{"href":"https://api.github.com/repos/dotnet/orleans/issues/2234"},"comments":{"href":"https://api.github.com/repos/dotnet/orleans/issues/2234/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/2234/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/2234/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/orleans/statuses/18723a9b3ca6498a38d868053c6eb2bcd93cfff0"}}}}
{"actor":{"display_login":"jdom"}}