{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/82541750","pull_request_review_id":3442512,"id":82541750,"diff_hunk":"@@ -0,0 +1,91 @@\n+/*\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.apache.spark.io;\n+\n+import java.io.File;\n+import java.io.FileInputStream;\n+import java.io.IOException;\n+import java.io.InputStream;\n+import java.nio.ByteBuffer;\n+import java.nio.channels.FileChannel;\n+import java.nio.file.StandardOpenOption;\n+\n+/**\n+ * {@link InputStream} implementation which uses direct buffer\n+ * to read a file to avoid extra copy of data between Java and\n+ * native memory which happens when using {@link java.io.BufferedInputStream}.\n+ * Unfortunately, this is not something already available in JDK,\n+ * {@link sun.nio.ch.ChannelInputStream} supports reading a file using nio,\n+ * but does not support buffering.\n+ *\n+ */\n+public final class NioBasedBufferedFileInputStream extends InputStream {","path":"core/src/main/java/org/apache/spark/io/NioBasedBufferedFileInputStream.java","position":32,"original_position":33,"commit_id":"856593ac4d54c4981f79b7a4b09c94cc66b5c63b","original_commit_id":"12c9ded039be06e4fe5900051d89bfaaa75a54df","user":{"login":"sitalkedia","id":11507549,"avatar_url":"https://avatars.githubusercontent.com/u/11507549?v=3","gravatar_id":"","url":"https://api.github.com/users/sitalkedia","html_url":"https://github.com/sitalkedia","followers_url":"https://api.github.com/users/sitalkedia/followers","following_url":"https://api.github.com/users/sitalkedia/following{/other_user}","gists_url":"https://api.github.com/users/sitalkedia/gists{/gist_id}","starred_url":"https://api.github.com/users/sitalkedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sitalkedia/subscriptions","organizations_url":"https://api.github.com/users/sitalkedia/orgs","repos_url":"https://api.github.com/users/sitalkedia/repos","events_url":"https://api.github.com/users/sitalkedia/events{/privacy}","received_events_url":"https://api.github.com/users/sitalkedia/received_events","type":"User","site_admin":false},"body":"Added a test suite for this.","created_at":"2016-10-10T03:43:47Z","updated_at":"2016-10-10T03:43:47Z","html_url":"https://github.com/apache/spark/pull/15408#discussion_r82541750","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/15408","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/82541750"},"html":{"href":"https://github.com/apache/spark/pull/15408#discussion_r82541750"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/15408"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/15408","id":88588935,"html_url":"https://github.com/apache/spark/pull/15408","diff_url":"https://github.com/apache/spark/pull/15408.diff","patch_url":"https://github.com/apache/spark/pull/15408.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/15408","number":15408,"state":"open","locked":false,"title":"[SPARK-17839][CORE] UnsafeSorterSpillReader should use Nio's directbuffer to read the spill files in order to avoid additional copy","user":{"login":"sitalkedia","id":11507549,"avatar_url":"https://avatars.githubusercontent.com/u/11507549?v=3","gravatar_id":"","url":"https://api.github.com/users/sitalkedia","html_url":"https://github.com/sitalkedia","followers_url":"https://api.github.com/users/sitalkedia/followers","following_url":"https://api.github.com/users/sitalkedia/following{/other_user}","gists_url":"https://api.github.com/users/sitalkedia/gists{/gist_id}","starred_url":"https://api.github.com/users/sitalkedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sitalkedia/subscriptions","organizations_url":"https://api.github.com/users/sitalkedia/orgs","repos_url":"https://api.github.com/users/sitalkedia/repos","events_url":"https://api.github.com/users/sitalkedia/events{/privacy}","received_events_url":"https://api.github.com/users/sitalkedia/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nCurrently we use BufferedInputStream to read the shuffle file which copies the file content from os buffer cache to the user buffer. This adds additional latency in reading the spill files. We made a change to use java nio's direct buffer to read the spill files and for certain jobs spilling significant amount of data, we see up to 7% speedup.\r\n\r\n## How was this patch tested?\r\nTested by running the job in the cluster and observed up to 7% speedup.\r\n","created_at":"2016-10-09T18:06:51Z","updated_at":"2016-10-10T03:43:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cd92d5bb649d355dee83934da67063ba9b81fa2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/15408/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/15408/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/15408/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/856593ac4d54c4981f79b7a4b09c94cc66b5c63b","head":{"label":"sitalkedia:skedia/nio_spill_read","ref":"skedia/nio_spill_read","sha":"856593ac4d54c4981f79b7a4b09c94cc66b5c63b","user":{"login":"sitalkedia","id":11507549,"avatar_url":"https://avatars.githubusercontent.com/u/11507549?v=3","gravatar_id":"","url":"https://api.github.com/users/sitalkedia","html_url":"https://github.com/sitalkedia","followers_url":"https://api.github.com/users/sitalkedia/followers","following_url":"https://api.github.com/users/sitalkedia/following{/other_user}","gists_url":"https://api.github.com/users/sitalkedia/gists{/gist_id}","starred_url":"https://api.github.com/users/sitalkedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sitalkedia/subscriptions","organizations_url":"https://api.github.com/users/sitalkedia/orgs","repos_url":"https://api.github.com/users/sitalkedia/repos","events_url":"https://api.github.com/users/sitalkedia/events{/privacy}","received_events_url":"https://api.github.com/users/sitalkedia/received_events","type":"User","site_admin":false},"repo":{"id":51496876,"name":"spark","full_name":"sitalkedia/spark","owner":{"login":"sitalkedia","id":11507549,"avatar_url":"https://avatars.githubusercontent.com/u/11507549?v=3","gravatar_id":"","url":"https://api.github.com/users/sitalkedia","html_url":"https://github.com/sitalkedia","followers_url":"https://api.github.com/users/sitalkedia/followers","following_url":"https://api.github.com/users/sitalkedia/following{/other_user}","gists_url":"https://api.github.com/users/sitalkedia/gists{/gist_id}","starred_url":"https://api.github.com/users/sitalkedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sitalkedia/subscriptions","organizations_url":"https://api.github.com/users/sitalkedia/orgs","repos_url":"https://api.github.com/users/sitalkedia/repos","events_url":"https://api.github.com/users/sitalkedia/events{/privacy}","received_events_url":"https://api.github.com/users/sitalkedia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sitalkedia/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/sitalkedia/spark","forks_url":"https://api.github.com/repos/sitalkedia/spark/forks","keys_url":"https://api.github.com/repos/sitalkedia/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sitalkedia/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sitalkedia/spark/teams","hooks_url":"https://api.github.com/repos/sitalkedia/spark/hooks","issue_events_url":"https://api.github.com/repos/sitalkedia/spark/issues/events{/number}","events_url":"https://api.github.com/repos/sitalkedia/spark/events","assignees_url":"https://api.github.com/repos/sitalkedia/spark/assignees{/user}","branches_url":"https://api.github.com/repos/sitalkedia/spark/branches{/branch}","tags_url":"https://api.github.com/repos/sitalkedia/spark/tags","blobs_url":"https://api.github.com/repos/sitalkedia/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sitalkedia/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sitalkedia/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/sitalkedia/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sitalkedia/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/sitalkedia/spark/languages","stargazers_url":"https://api.github.com/repos/sitalkedia/spark/stargazers","contributors_url":"https://api.github.com/repos/sitalkedia/spark/contributors","subscribers_url":"https://api.github.com/repos/sitalkedia/spark/subscribers","subscription_url":"https://api.github.com/repos/sitalkedia/spark/subscription","commits_url":"https://api.github.com/repos/sitalkedia/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/sitalkedia/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/sitalkedia/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/sitalkedia/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/sitalkedia/spark/contents/{+path}","compare_url":"https://api.github.com/repos/sitalkedia/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sitalkedia/spark/merges","archive_url":"https://api.github.com/repos/sitalkedia/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sitalkedia/spark/downloads","issues_url":"https://api.github.com/repos/sitalkedia/spark/issues{/number}","pulls_url":"https://api.github.com/repos/sitalkedia/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/sitalkedia/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/sitalkedia/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sitalkedia/spark/labels{/name}","releases_url":"https://api.github.com/repos/sitalkedia/spark/releases{/id}","deployments_url":"https://api.github.com/repos/sitalkedia/spark/deployments","created_at":"2016-02-11T05:53:19Z","updated_at":"2016-02-11T05:53:45Z","pushed_at":"2016-10-10T03:43:14Z","git_url":"git://github.com/sitalkedia/spark.git","ssh_url":"git@github.com:sitalkedia/spark.git","clone_url":"https://github.com/sitalkedia/spark.git","svn_url":"https://github.com/sitalkedia/spark","homepage":null,"size":183306,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8a6bbe095b6a9aa33989c0deaa5ed0128d70320f","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2016-10-10T03:28:42Z","pushed_at":"2016-10-10T03:43:16Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":531516,"stargazers_count":10288,"watchers_count":10288,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9563,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":479,"forks":9563,"open_issues":479,"watchers":10288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/15408"},"html":{"href":"https://github.com/apache/spark/pull/15408"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/15408"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/15408/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/15408/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/15408/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/856593ac4d54c4981f79b7a4b09c94cc66b5c63b"}}}}
{"actor":{"display_login":"sitalkedia"}}