{"action":"created","comment":{"url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/comments/75032284","id":75032284,"diff_hunk":"@@ -162,17 +173,16 @@ class ThriftNamerClient(\n             Trace.record(\"namerd.client/addr.neg\")\n             loop(stamp1)\n \n-          case Return(thrift.Addr(stamp1, thrift.AddrVal.Bound(thrift.BoundAddr(taddrs, _)))) =>\n+          case Return(thrift.Addr(stamp1, thrift.AddrVal.Bound(thrift.BoundAddr(taddrs, boundMeta)))) =>\n             val addrs = taddrs.map { taddr =>\n-              val thrift.TransportAddress(ipbb, port, _) = taddr\n+              val thrift.TransportAddress(ipbb, port, addressMeta) = taddr\n               val ipBytes = Buf.ByteArray.Owned.extract(Buf.ByteBuffer.Owned(ipbb))\n               val ip = InetAddress.getByAddress(ipBytes)\n-              // TODO convert metadata\n-              Address(new InetSocketAddress(ip, port))\n+              Address.Inet(new InetSocketAddress(ip, port), convertMeta(addressMeta)).asInstanceOf[Address]","path":"namerd/iface/interpreter-thrift/src/main/scala/io/buoyant/namerd/iface/ThriftNamerClient.scala","position":31,"original_position":31,"commit_id":"3c91f2673190c0d6d2df050c1326c60a198e9833","original_commit_id":"3c91f2673190c0d6d2df050c1326c60a198e9833","user":{"login":"Ashald","id":397987,"avatar_url":"https://avatars.githubusercontent.com/u/397987?v=3","gravatar_id":"","url":"https://api.github.com/users/Ashald","html_url":"https://github.com/Ashald","followers_url":"https://api.github.com/users/Ashald/followers","following_url":"https://api.github.com/users/Ashald/following{/other_user}","gists_url":"https://api.github.com/users/Ashald/gists{/gist_id}","starred_url":"https://api.github.com/users/Ashald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ashald/subscriptions","organizations_url":"https://api.github.com/users/Ashald/orgs","repos_url":"https://api.github.com/users/Ashald/repos","events_url":"https://api.github.com/users/Ashald/events{/privacy}","received_events_url":"https://api.github.com/users/Ashald/received_events","type":"User","site_admin":false},"body":"It didn't compile without it. :( Is there is a better way around?","created_at":"2016-08-16T22:24:58Z","updated_at":"2016-08-16T22:24:58Z","html_url":"https://github.com/BuoyantIO/linkerd/pull/552#discussion_r75032284","pull_request_url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/552","_links":{"self":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/comments/75032284"},"html":{"href":"https://github.com/BuoyantIO/linkerd/pull/552#discussion_r75032284"},"pull_request":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/552"}}},"pull_request":{"url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/552","id":78400445,"html_url":"https://github.com/BuoyantIO/linkerd/pull/552","diff_url":"https://github.com/BuoyantIO/linkerd/pull/552.diff","patch_url":"https://github.com/BuoyantIO/linkerd/pull/552.patch","issue_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/552","number":552,"state":"open","locked":false,"title":"Add a Client Stack Module to rewrite HTTP Host Header/Consul integration for it","user":{"login":"Ashald","id":397987,"avatar_url":"https://avatars.githubusercontent.com/u/397987?v=3","gravatar_id":"","url":"https://api.github.com/users/Ashald","html_url":"https://github.com/Ashald","followers_url":"https://api.github.com/users/Ashald/followers","following_url":"https://api.github.com/users/Ashald/following{/other_user}","gists_url":"https://api.github.com/users/Ashald/gists{/gist_id}","starred_url":"https://api.github.com/users/Ashald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ashald/subscriptions","organizations_url":"https://api.github.com/users/Ashald/orgs","repos_url":"https://api.github.com/users/Ashald/repos","events_url":"https://api.github.com/users/Ashald/events{/privacy}","received_events_url":"https://api.github.com/users/Ashald/received_events","type":"User","site_admin":false},"body":"This PR introduces following features:\r\n1) Consul Catalog Namer now has an extra option `domain` - when set it makes it to embed `l5d-http-host` meta field with value `$name.service.$dc.$domain` into `Addr.Bound`\r\n2) Namerd Thrift Interface/Client now can pass around `Addr.Metadata` for `Addr.Bound` and `Addr.Inet` but only those with values of `String` type\r\n3) `clientStack` within `io.buoyant.linkerd.protocol.HttpInitializer#defaultRouter` now includes `RewriteHostHeader` module that rewrites outgoing request's `Host` header but only if `l5d-http-host` meta field is present within `Addr.Bound` metadata\r\n\r\nAll changes are covered with tests.","created_at":"2016-07-21T22:49:22Z","updated_at":"2016-08-16T22:24:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff0463ac00acc7707cba0fff63689c13f4524d54","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/552/commits","review_comments_url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/552/comments","review_comment_url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/552/comments","statuses_url":"https://api.github.com/repos/BuoyantIO/linkerd/statuses/3c91f2673190c0d6d2df050c1326c60a198e9833","head":{"label":"Ashald:feature/consul-rewrite-http-host","ref":"feature/consul-rewrite-http-host","sha":"3c91f2673190c0d6d2df050c1326c60a198e9833","user":{"login":"Ashald","id":397987,"avatar_url":"https://avatars.githubusercontent.com/u/397987?v=3","gravatar_id":"","url":"https://api.github.com/users/Ashald","html_url":"https://github.com/Ashald","followers_url":"https://api.github.com/users/Ashald/followers","following_url":"https://api.github.com/users/Ashald/following{/other_user}","gists_url":"https://api.github.com/users/Ashald/gists{/gist_id}","starred_url":"https://api.github.com/users/Ashald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ashald/subscriptions","organizations_url":"https://api.github.com/users/Ashald/orgs","repos_url":"https://api.github.com/users/Ashald/repos","events_url":"https://api.github.com/users/Ashald/events{/privacy}","received_events_url":"https://api.github.com/users/Ashald/received_events","type":"User","site_admin":false},"repo":{"id":62817214,"name":"linkerd","full_name":"Ashald/linkerd","owner":{"login":"Ashald","id":397987,"avatar_url":"https://avatars.githubusercontent.com/u/397987?v=3","gravatar_id":"","url":"https://api.github.com/users/Ashald","html_url":"https://github.com/Ashald","followers_url":"https://api.github.com/users/Ashald/followers","following_url":"https://api.github.com/users/Ashald/following{/other_user}","gists_url":"https://api.github.com/users/Ashald/gists{/gist_id}","starred_url":"https://api.github.com/users/Ashald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ashald/subscriptions","organizations_url":"https://api.github.com/users/Ashald/orgs","repos_url":"https://api.github.com/users/Ashald/repos","events_url":"https://api.github.com/users/Ashald/events{/privacy}","received_events_url":"https://api.github.com/users/Ashald/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ashald/linkerd","description":"A dynamic linker for microservices.","fork":true,"url":"https://api.github.com/repos/Ashald/linkerd","forks_url":"https://api.github.com/repos/Ashald/linkerd/forks","keys_url":"https://api.github.com/repos/Ashald/linkerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ashald/linkerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ashald/linkerd/teams","hooks_url":"https://api.github.com/repos/Ashald/linkerd/hooks","issue_events_url":"https://api.github.com/repos/Ashald/linkerd/issues/events{/number}","events_url":"https://api.github.com/repos/Ashald/linkerd/events","assignees_url":"https://api.github.com/repos/Ashald/linkerd/assignees{/user}","branches_url":"https://api.github.com/repos/Ashald/linkerd/branches{/branch}","tags_url":"https://api.github.com/repos/Ashald/linkerd/tags","blobs_url":"https://api.github.com/repos/Ashald/linkerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ashald/linkerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ashald/linkerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ashald/linkerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ashald/linkerd/statuses/{sha}","languages_url":"https://api.github.com/repos/Ashald/linkerd/languages","stargazers_url":"https://api.github.com/repos/Ashald/linkerd/stargazers","contributors_url":"https://api.github.com/repos/Ashald/linkerd/contributors","subscribers_url":"https://api.github.com/repos/Ashald/linkerd/subscribers","subscription_url":"https://api.github.com/repos/Ashald/linkerd/subscription","commits_url":"https://api.github.com/repos/Ashald/linkerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ashald/linkerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ashald/linkerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ashald/linkerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ashald/linkerd/contents/{+path}","compare_url":"https://api.github.com/repos/Ashald/linkerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ashald/linkerd/merges","archive_url":"https://api.github.com/repos/Ashald/linkerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ashald/linkerd/downloads","issues_url":"https://api.github.com/repos/Ashald/linkerd/issues{/number}","pulls_url":"https://api.github.com/repos/Ashald/linkerd/pulls{/number}","milestones_url":"https://api.github.com/repos/Ashald/linkerd/milestones{/number}","notifications_url":"https://api.github.com/repos/Ashald/linkerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ashald/linkerd/labels{/name}","releases_url":"https://api.github.com/repos/Ashald/linkerd/releases{/id}","deployments_url":"https://api.github.com/repos/Ashald/linkerd/deployments","created_at":"2016-07-07T15:20:38Z","updated_at":"2016-07-07T15:20:40Z","pushed_at":"2016-08-16T22:02:43Z","git_url":"git://github.com/Ashald/linkerd.git","ssh_url":"git@github.com:Ashald/linkerd.git","clone_url":"https://github.com/Ashald/linkerd.git","svn_url":"https://github.com/Ashald/linkerd","homepage":"https://linkerd.io","size":1886,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BuoyantIO:master","ref":"master","sha":"2dc28ce69f45e1f275a63c05745251269f234ee9","user":{"login":"BuoyantIO","id":10824329,"avatar_url":"https://avatars.githubusercontent.com/u/10824329?v=3","gravatar_id":"","url":"https://api.github.com/users/BuoyantIO","html_url":"https://github.com/BuoyantIO","followers_url":"https://api.github.com/users/BuoyantIO/followers","following_url":"https://api.github.com/users/BuoyantIO/following{/other_user}","gists_url":"https://api.github.com/users/BuoyantIO/gists{/gist_id}","starred_url":"https://api.github.com/users/BuoyantIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuoyantIO/subscriptions","organizations_url":"https://api.github.com/users/BuoyantIO/orgs","repos_url":"https://api.github.com/users/BuoyantIO/repos","events_url":"https://api.github.com/users/BuoyantIO/events{/privacy}","received_events_url":"https://api.github.com/users/BuoyantIO/received_events","type":"Organization","site_admin":false},"repo":{"id":49605596,"name":"linkerd","full_name":"BuoyantIO/linkerd","owner":{"login":"BuoyantIO","id":10824329,"avatar_url":"https://avatars.githubusercontent.com/u/10824329?v=3","gravatar_id":"","url":"https://api.github.com/users/BuoyantIO","html_url":"https://github.com/BuoyantIO","followers_url":"https://api.github.com/users/BuoyantIO/followers","following_url":"https://api.github.com/users/BuoyantIO/following{/other_user}","gists_url":"https://api.github.com/users/BuoyantIO/gists{/gist_id}","starred_url":"https://api.github.com/users/BuoyantIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuoyantIO/subscriptions","organizations_url":"https://api.github.com/users/BuoyantIO/orgs","repos_url":"https://api.github.com/users/BuoyantIO/repos","events_url":"https://api.github.com/users/BuoyantIO/events{/privacy}","received_events_url":"https://api.github.com/users/BuoyantIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BuoyantIO/linkerd","description":"A dynamic linker for microservices.","fork":false,"url":"https://api.github.com/repos/BuoyantIO/linkerd","forks_url":"https://api.github.com/repos/BuoyantIO/linkerd/forks","keys_url":"https://api.github.com/repos/BuoyantIO/linkerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BuoyantIO/linkerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BuoyantIO/linkerd/teams","hooks_url":"https://api.github.com/repos/BuoyantIO/linkerd/hooks","issue_events_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/events{/number}","events_url":"https://api.github.com/repos/BuoyantIO/linkerd/events","assignees_url":"https://api.github.com/repos/BuoyantIO/linkerd/assignees{/user}","branches_url":"https://api.github.com/repos/BuoyantIO/linkerd/branches{/branch}","tags_url":"https://api.github.com/repos/BuoyantIO/linkerd/tags","blobs_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BuoyantIO/linkerd/statuses/{sha}","languages_url":"https://api.github.com/repos/BuoyantIO/linkerd/languages","stargazers_url":"https://api.github.com/repos/BuoyantIO/linkerd/stargazers","contributors_url":"https://api.github.com/repos/BuoyantIO/linkerd/contributors","subscribers_url":"https://api.github.com/repos/BuoyantIO/linkerd/subscribers","subscription_url":"https://api.github.com/repos/BuoyantIO/linkerd/subscription","commits_url":"https://api.github.com/repos/BuoyantIO/linkerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/BuoyantIO/linkerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/BuoyantIO/linkerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/BuoyantIO/linkerd/contents/{+path}","compare_url":"https://api.github.com/repos/BuoyantIO/linkerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BuoyantIO/linkerd/merges","archive_url":"https://api.github.com/repos/BuoyantIO/linkerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BuoyantIO/linkerd/downloads","issues_url":"https://api.github.com/repos/BuoyantIO/linkerd/issues{/number}","pulls_url":"https://api.github.com/repos/BuoyantIO/linkerd/pulls{/number}","milestones_url":"https://api.github.com/repos/BuoyantIO/linkerd/milestones{/number}","notifications_url":"https://api.github.com/repos/BuoyantIO/linkerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BuoyantIO/linkerd/labels{/name}","releases_url":"https://api.github.com/repos/BuoyantIO/linkerd/releases{/id}","deployments_url":"https://api.github.com/repos/BuoyantIO/linkerd/deployments","created_at":"2016-01-13T22:14:52Z","updated_at":"2016-08-16T08:04:23Z","pushed_at":"2016-08-16T22:23:23Z","git_url":"git://github.com/BuoyantIO/linkerd.git","ssh_url":"git@github.com:BuoyantIO/linkerd.git","clone_url":"https://github.com/BuoyantIO/linkerd.git","svn_url":"https://github.com/BuoyantIO/linkerd","homepage":"https://linkerd.io","size":2421,"stargazers_count":891,"watchers_count":891,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":73,"forks":66,"open_issues":73,"watchers":891,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/552"},"html":{"href":"https://github.com/BuoyantIO/linkerd/pull/552"},"issue":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/issues/552"},"comments":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/issues/552/comments"},"review_comments":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/552/comments"},"review_comment":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/pulls/552/commits"},"statuses":{"href":"https://api.github.com/repos/BuoyantIO/linkerd/statuses/3c91f2673190c0d6d2df050c1326c60a198e9833"}}}}
{"actor":{"display_login":"Ashald"}}