{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls/10","id":64427193,"html_url":"https://github.com/ITsvetkoFF/Kv-013/pull/10","diff_url":"https://github.com/ITsvetkoFF/Kv-013/pull/10.diff","patch_url":"https://github.com/ITsvetkoFF/Kv-013/pull/10.patch","issue_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/issues/10","number":10,"state":"closed","locked":false,"title":"Unit tests","user":{"login":"ITsvetkoFF","id":7273003,"avatar_url":"https://avatars.githubusercontent.com/u/7273003?v=3","gravatar_id":"","url":"https://api.github.com/users/ITsvetkoFF","html_url":"https://github.com/ITsvetkoFF","followers_url":"https://api.github.com/users/ITsvetkoFF/followers","following_url":"https://api.github.com/users/ITsvetkoFF/following{/other_user}","gists_url":"https://api.github.com/users/ITsvetkoFF/gists{/gist_id}","starred_url":"https://api.github.com/users/ITsvetkoFF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ITsvetkoFF/subscriptions","organizations_url":"https://api.github.com/users/ITsvetkoFF/orgs","repos_url":"https://api.github.com/users/ITsvetkoFF/repos","events_url":"https://api.github.com/users/ITsvetkoFF/events{/privacy}","received_events_url":"https://api.github.com/users/ITsvetkoFF/received_events","type":"User","site_admin":false},"body":"<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r57688343%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r57688621%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r57688741%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r57689071%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r57689316%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r57689396%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r57690156%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r57690249%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r57690417%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r57690561%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r58096688%22%2C%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r58096857%22%5D%2C%20%22comments%22%3A%20%7B%22Pull%2064e161156cef478cb945bf4c2037d3d453960c4d%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestForControllers/TestGitHubExtensionSecurityWebApiAccountControllerAssignRolesToUser.cs%2083%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r57690561%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Function%20call%20and%20getting%20result%20should%20be%20in%20different%20unit%20test%20phases%2C%20respectively%20Act%20and%20Assert.%22%2C%20%22created_at%22%3A%20%222016-03-29T08%3A53%3A13Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestForControllers/TestGitHubExtensionSecurityWebApiAccountControllerAssignRolesToUser.cs%3AL1-182%22%7D%2C%20%22Pull%2064e161156cef478cb945bf4c2037d3d453960c4d%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestForControllers/TestGitHubExtensionSecurityWebApiAccountControllerAssignRolesToUser.cs%20113%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r57690249%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22You%20need%20this%20empty%20spaces%3F%22%2C%20%22created_at%22%3A%20%222016-03-29T08%3A50%3A34Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestForControllers/TestGitHubExtensionSecurityWebApiAccountControllerAssignRolesToUser.cs%3AL1-182%22%7D%2C%20%22Pull%2064e161156cef478cb945bf4c2037d3d453960c4d%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestForControllers/TestGitHubExtensionSecurityWebApiAccountControllerAssignRolesToUser.cs%2085%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r57689316%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22As%20I%20remember%20we%20agreed%20use%20http%3A//www.fluentassertions.com/%20in%20unit%20tests%20assertion%20phase.%22%2C%20%22created_at%22%3A%20%222016-03-29T08%3A43%3A08Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestForControllers/TestGitHubExtensionSecurityWebApiAccountControllerAssignRolesToUser.cs%3AL1-182%22%7D%2C%20%22Pull%2064e161156cef478cb945bf4c2037d3d453960c4d%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestExtensions/TestUserMapper.cs%2015%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r57688621%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Please%20revert%20class%20name%2C%20method%20conventions%20to%20using%20word%20%5C%22Test%5C%22%20in%20postfix%20form.%20For%20example%2C%20UserManager%2A%2ATests%2A%2A%2C%20or%20TestToUserReturnModel%20-%3E%20EntinyToUserReturnModelTest%20and%20etc...%22%2C%20%22created_at%22%3A%20%222016-03-29T08%3A37%3A28Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestExtensions/TestUserMapper.cs%3AL1-61%22%7D%2C%20%22Pull%2064e161156cef478cb945bf4c2037d3d453960c4d%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/Mocks/MockForEnumerableQuery.cs%2030%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r57688343%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Please%20don%27t%20collect%20garbage.%20Follow%20YAGNI%20principle...%22%2C%20%22created_at%22%3A%20%222016-03-29T08%3A35%3A00Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/Mocks/MockForEnumerableQuery.cs%3AL1-51%22%7D%2C%20%22Pull%2064e161156cef478cb945bf4c2037d3d453960c4d%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.WebApi.Library/Controllers/AccountController.cs%2019%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r57689396%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Remove%20garbage%22%2C%20%22created_at%22%3A%20%222016-03-29T08%3A43%3A53Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.WebApi.Library/Controllers/AccountController.cs%3AL75-89%22%7D%2C%20%22Pull%2064e161156cef478cb945bf4c2037d3d453960c4d%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestForControllers/TestGitHubExtensionSecurityWebApiAccountControllerAssignRolesToUser.cs%20123%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r57690417%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Is%27t%20not%20good%20practice%20to%20verify%20value%20by%20%5C%22magic%5C%22%20string.%20It%20should%20be%20moved%20to%20constant%20or%20transform%20to%20typed%20value.%20It%27s%20simplify%20next%20code%20refactoring.%22%2C%20%22created_at%22%3A%20%222016-03-29T08%3A52%3A01Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestForControllers/TestGitHubExtensionSecurityWebApiAccountControllerAssignRolesToUser.cs%3AL1-182%22%7D%2C%20%22Pull%2064e161156cef478cb945bf4c2037d3d453960c4d%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/Mocks/MockForEnumerableQuery.cs%2012%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r57690156%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Btw%2C%20can%20you%20verify%20this%20one%20class%20EnumerableQuery%28namespace%20System.Linq%29...May%20be%20it%20can%20replace%20this%20specific%20class%2C%20but%20I%20am%20not%20sure.%22%2C%20%22created_at%22%3A%20%222016-03-29T08%3A49%3A48Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/Mocks/MockForEnumerableQuery.cs%3AL1-51%22%7D%2C%20%22Pull%209cd74df5d5cc1e350b62872f2aebbf5055cd4a2e%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.WebApi/index.html%202%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r58096688%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22I%20don%27t%20understand%20what%20how%20this%20staff%20related%20to%20unit%20tests%3F%22%2C%20%22created_at%22%3A%20%222016-03-31T17%3A46%3A43Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.WebApi/index.html%3AL1-39%22%7D%2C%20%22Pull%209cd74df5d5cc1e350b62872f2aebbf5055cd4a2e%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.WebApi/FrontEnd/gulpfile.js%2017%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r58096857%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Please%20create%20separate%20merge%20request%20for%20that%20staff..%22%2C%20%22created_at%22%3A%20%222016-03-31T17%3A47%3A44Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.WebApi/FrontEnd/gulpfile.js%3AL29-52%22%7D%2C%20%22Pull%2064e161156cef478cb945bf4c2037d3d453960c4d%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestExtensions/TestUserMapper.cs%2020%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r57689071%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Move%20unit%20test%20arrange%20phase%20to%20xUnit%20MemberData%20attribute.%22%2C%20%22created_at%22%3A%20%222016-03-29T08%3A41%3A19Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestExtensions/TestUserMapper.cs%3AL1-61%22%7D%2C%20%22Pull%2064e161156cef478cb945bf4c2037d3d453960c4d%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestForControllers/TestGitHubExtensionSecurityWebApiAccountControllerAssignRolesToUser.cs%2030%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ITsvetkoFF/Kv-013/pull/10%23discussion_r57688741%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Unit%20tests%20must%20conform%20the%20AAA%20pattern%20and%20must%20be%20documented%20explicitly%20in%20each%20test.%20For%20example%2C%20see%20article%20http%3A//c2.com/cgi/wiki%3FArrangeActAssert.%22%2C%20%22created_at%22%3A%20%222016-03-29T08%3A38%3A21Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6068068%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/TerraVenil%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestForControllers/TestGitHubExtensionSecurityWebApiAccountControllerAssignRolesToUser.cs%3AL1-182%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [x] <a href='#crh-comment-Pull 64e161156cef478cb945bf4c2037d3d453960c4d DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/Mocks/MockForEnumerableQuery.cs 30'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/10#discussion_r57688343'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/Mocks/MockForEnumerableQuery.cs:L1-51</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> Please don't collect garbage. Follow YAGNI principle...\n- [x] <a href='#crh-comment-Pull 64e161156cef478cb945bf4c2037d3d453960c4d DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestExtensions/TestUserMapper.cs 15'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/10#discussion_r57688621'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestExtensions/TestUserMapper.cs:L1-61</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> Please revert class name, method conventions to using word \"Test\" in postfix form. For example, UserManager**Tests**, or TestToUserReturnModel -> EntinyToUserReturnModelTest and etc...\n- [x] <a href='#crh-comment-Pull 64e161156cef478cb945bf4c2037d3d453960c4d DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestForControllers/TestGitHubExtensionSecurityWebApiAccountControllerAssignRolesToUser.cs 30'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/10#discussion_r57688741'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestForControllers/TestGitHubExtensionSecurityWebApiAccountControllerAssignRolesToUser.cs:L1-182</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> Unit tests must conform the AAA pattern and must be documented explicitly in each test. For example, see article http://c2.com/cgi/wiki?ArrangeActAssert.\n- [x] <a href='#crh-comment-Pull 64e161156cef478cb945bf4c2037d3d453960c4d DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestExtensions/TestUserMapper.cs 20'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/10#discussion_r57689071'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestExtensions/TestUserMapper.cs:L1-61</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> Move unit test arrange phase to xUnit MemberData attribute.\n- [x] <a href='#crh-comment-Pull 64e161156cef478cb945bf4c2037d3d453960c4d DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestForControllers/TestGitHubExtensionSecurityWebApiAccountControllerAssignRolesToUser.cs 85'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/10#discussion_r57689316'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestForControllers/TestGitHubExtensionSecurityWebApiAccountControllerAssignRolesToUser.cs:L1-182</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> As I remember we agreed use http://www.fluentassertions.com/ in unit tests assertion phase.\n- [x] <a href='#crh-comment-Pull 64e161156cef478cb945bf4c2037d3d453960c4d DevelopGitHub/GitHubExtension/GitHubExtension.Security.WebApi.Library/Controllers/AccountController.cs 19'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/10#discussion_r57689396'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Security.WebApi.Library/Controllers/AccountController.cs:L75-89</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> Remove garbage\n- [x] <a href='#crh-comment-Pull 64e161156cef478cb945bf4c2037d3d453960c4d DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/Mocks/MockForEnumerableQuery.cs 12'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/10#discussion_r57690156'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/Mocks/MockForEnumerableQuery.cs:L1-51</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> Btw, can you verify this one class EnumerableQuery(namespace System.Linq)...May be it can replace this specific class, but I am not sure.\n- [x] <a href='#crh-comment-Pull 64e161156cef478cb945bf4c2037d3d453960c4d DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestForControllers/TestGitHubExtensionSecurityWebApiAccountControllerAssignRolesToUser.cs 113'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/10#discussion_r57690249'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestForControllers/TestGitHubExtensionSecurityWebApiAccountControllerAssignRolesToUser.cs:L1-182</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> You need this empty spaces?\n- [x] <a href='#crh-comment-Pull 64e161156cef478cb945bf4c2037d3d453960c4d DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestForControllers/TestGitHubExtensionSecurityWebApiAccountControllerAssignRolesToUser.cs 123'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/10#discussion_r57690417'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestForControllers/TestGitHubExtensionSecurityWebApiAccountControllerAssignRolesToUser.cs:L1-182</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> Is't not good practice to verify value by \"magic\" string. It should be moved to constant or transform to typed value. It's simplify next code refactoring.\n- [x] <a href='#crh-comment-Pull 64e161156cef478cb945bf4c2037d3d453960c4d DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestForControllers/TestGitHubExtensionSecurityWebApiAccountControllerAssignRolesToUser.cs 83'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/10#discussion_r57690561'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Security.Tests/TestForControllers/TestGitHubExtensionSecurityWebApiAccountControllerAssignRolesToUser.cs:L1-182</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> Function call and getting result should be in different unit test phases, respectively Act and Assert.\n- [ ] <a href='#crh-comment-Pull 9cd74df5d5cc1e350b62872f2aebbf5055cd4a2e DevelopGitHub/GitHubExtension/GitHubExtension.Security.WebApi/index.html 2'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/10#discussion_r58096688'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Security.WebApi/index.html:L1-39</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> I don't understand what how this staff related to unit tests?\n- [ ] <a href='#crh-comment-Pull 9cd74df5d5cc1e350b62872f2aebbf5055cd4a2e DevelopGitHub/GitHubExtension/GitHubExtension.Security.WebApi/FrontEnd/gulpfile.js 17'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ITsvetkoFF/Kv-013/pull/10#discussion_r58096857'>File: DevelopGitHub/GitHubExtension/GitHubExtension.Security.WebApi/FrontEnd/gulpfile.js:L29-52</a></b>\n- <a href='https://github.com/TerraVenil'><img border=0 src='https://avatars.githubusercontent.com/u/6068068?v=3' height=16 width=16'></a> Please create separate merge request for that staff..\n\n\n<a href='https://www.codereviewhub.com/ITsvetkoFF/Kv-013/pull/10?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/ITsvetkoFF/Kv-013/pull/10?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/ITsvetkoFF/Kv-013/pull/10'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2016-03-29T08:04:06Z","updated_at":"2016-04-02T10:27:53Z","closed_at":"2016-04-02T10:27:53Z","merged_at":null,"merge_commit_sha":"9e1b349fd9d53dbaa4b8bdbaec20131c7d0dd370","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls/10/commits","review_comments_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls/10/comments","review_comment_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/issues/10/comments","statuses_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/statuses/9cd74df5d5cc1e350b62872f2aebbf5055cd4a2e","head":{"label":"ITsvetkoFF:unit-tests","ref":"unit-tests","sha":"9cd74df5d5cc1e350b62872f2aebbf5055cd4a2e","user":{"login":"ITsvetkoFF","id":7273003,"avatar_url":"https://avatars.githubusercontent.com/u/7273003?v=3","gravatar_id":"","url":"https://api.github.com/users/ITsvetkoFF","html_url":"https://github.com/ITsvetkoFF","followers_url":"https://api.github.com/users/ITsvetkoFF/followers","following_url":"https://api.github.com/users/ITsvetkoFF/following{/other_user}","gists_url":"https://api.github.com/users/ITsvetkoFF/gists{/gist_id}","starred_url":"https://api.github.com/users/ITsvetkoFF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ITsvetkoFF/subscriptions","organizations_url":"https://api.github.com/users/ITsvetkoFF/orgs","repos_url":"https://api.github.com/users/ITsvetkoFF/repos","events_url":"https://api.github.com/users/ITsvetkoFF/events{/privacy}","received_events_url":"https://api.github.com/users/ITsvetkoFF/received_events","type":"User","site_admin":false},"repo":{"id":52432402,"name":"Kv-013","full_name":"ITsvetkoFF/Kv-013","owner":{"login":"ITsvetkoFF","id":7273003,"avatar_url":"https://avatars.githubusercontent.com/u/7273003?v=3","gravatar_id":"","url":"https://api.github.com/users/ITsvetkoFF","html_url":"https://github.com/ITsvetkoFF","followers_url":"https://api.github.com/users/ITsvetkoFF/followers","following_url":"https://api.github.com/users/ITsvetkoFF/following{/other_user}","gists_url":"https://api.github.com/users/ITsvetkoFF/gists{/gist_id}","starred_url":"https://api.github.com/users/ITsvetkoFF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ITsvetkoFF/subscriptions","organizations_url":"https://api.github.com/users/ITsvetkoFF/orgs","repos_url":"https://api.github.com/users/ITsvetkoFF/repos","events_url":"https://api.github.com/users/ITsvetkoFF/events{/privacy}","received_events_url":"https://api.github.com/users/ITsvetkoFF/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ITsvetkoFF/Kv-013","description":"","fork":false,"url":"https://api.github.com/repos/ITsvetkoFF/Kv-013","forks_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/forks","keys_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/teams","hooks_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/hooks","issue_events_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/issues/events{/number}","events_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/events","assignees_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/assignees{/user}","branches_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/branches{/branch}","tags_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/tags","blobs_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/git/refs{/sha}","trees_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/statuses/{sha}","languages_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/languages","stargazers_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/stargazers","contributors_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/contributors","subscribers_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/subscribers","subscription_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/subscription","commits_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/commits{/sha}","git_commits_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/git/commits{/sha}","comments_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/comments{/number}","issue_comment_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/issues/comments{/number}","contents_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/contents/{+path}","compare_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/merges","archive_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/downloads","issues_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/issues{/number}","pulls_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls{/number}","milestones_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/milestones{/number}","notifications_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/labels{/name}","releases_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/releases{/id}","deployments_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/deployments","created_at":"2016-02-24T10:00:53Z","updated_at":"2016-03-31T16:16:04Z","pushed_at":"2016-04-01T22:14:12Z","git_url":"git://github.com/ITsvetkoFF/Kv-013.git","ssh_url":"git@github.com:ITsvetkoFF/Kv-013.git","clone_url":"https://github.com/ITsvetkoFF/Kv-013.git","svn_url":"https://github.com/ITsvetkoFF/Kv-013","homepage":null,"size":3071,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"ITsvetkoFF:refactoring-after-merge","ref":"refactoring-after-merge","sha":"1488cf64254c620d4889d705d98b6ad47593c42c","user":{"login":"ITsvetkoFF","id":7273003,"avatar_url":"https://avatars.githubusercontent.com/u/7273003?v=3","gravatar_id":"","url":"https://api.github.com/users/ITsvetkoFF","html_url":"https://github.com/ITsvetkoFF","followers_url":"https://api.github.com/users/ITsvetkoFF/followers","following_url":"https://api.github.com/users/ITsvetkoFF/following{/other_user}","gists_url":"https://api.github.com/users/ITsvetkoFF/gists{/gist_id}","starred_url":"https://api.github.com/users/ITsvetkoFF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ITsvetkoFF/subscriptions","organizations_url":"https://api.github.com/users/ITsvetkoFF/orgs","repos_url":"https://api.github.com/users/ITsvetkoFF/repos","events_url":"https://api.github.com/users/ITsvetkoFF/events{/privacy}","received_events_url":"https://api.github.com/users/ITsvetkoFF/received_events","type":"User","site_admin":false},"repo":{"id":52432402,"name":"Kv-013","full_name":"ITsvetkoFF/Kv-013","owner":{"login":"ITsvetkoFF","id":7273003,"avatar_url":"https://avatars.githubusercontent.com/u/7273003?v=3","gravatar_id":"","url":"https://api.github.com/users/ITsvetkoFF","html_url":"https://github.com/ITsvetkoFF","followers_url":"https://api.github.com/users/ITsvetkoFF/followers","following_url":"https://api.github.com/users/ITsvetkoFF/following{/other_user}","gists_url":"https://api.github.com/users/ITsvetkoFF/gists{/gist_id}","starred_url":"https://api.github.com/users/ITsvetkoFF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ITsvetkoFF/subscriptions","organizations_url":"https://api.github.com/users/ITsvetkoFF/orgs","repos_url":"https://api.github.com/users/ITsvetkoFF/repos","events_url":"https://api.github.com/users/ITsvetkoFF/events{/privacy}","received_events_url":"https://api.github.com/users/ITsvetkoFF/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ITsvetkoFF/Kv-013","description":"","fork":false,"url":"https://api.github.com/repos/ITsvetkoFF/Kv-013","forks_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/forks","keys_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/teams","hooks_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/hooks","issue_events_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/issues/events{/number}","events_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/events","assignees_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/assignees{/user}","branches_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/branches{/branch}","tags_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/tags","blobs_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/git/refs{/sha}","trees_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/statuses/{sha}","languages_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/languages","stargazers_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/stargazers","contributors_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/contributors","subscribers_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/subscribers","subscription_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/subscription","commits_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/commits{/sha}","git_commits_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/git/commits{/sha}","comments_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/comments{/number}","issue_comment_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/issues/comments{/number}","contents_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/contents/{+path}","compare_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/merges","archive_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/downloads","issues_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/issues{/number}","pulls_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls{/number}","milestones_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/milestones{/number}","notifications_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/labels{/name}","releases_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/releases{/id}","deployments_url":"https://api.github.com/repos/ITsvetkoFF/Kv-013/deployments","created_at":"2016-02-24T10:00:53Z","updated_at":"2016-03-31T16:16:04Z","pushed_at":"2016-04-01T22:14:12Z","git_url":"git://github.com/ITsvetkoFF/Kv-013.git","ssh_url":"git@github.com:ITsvetkoFF/Kv-013.git","clone_url":"https://github.com/ITsvetkoFF/Kv-013.git","svn_url":"https://github.com/ITsvetkoFF/Kv-013","homepage":null,"size":3071,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls/10"},"html":{"href":"https://github.com/ITsvetkoFF/Kv-013/pull/10"},"issue":{"href":"https://api.github.com/repos/ITsvetkoFF/Kv-013/issues/10"},"comments":{"href":"https://api.github.com/repos/ITsvetkoFF/Kv-013/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ITsvetkoFF/Kv-013/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/ITsvetkoFF/Kv-013/statuses/9cd74df5d5cc1e350b62872f2aebbf5055cd4a2e"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":12,"commits":24,"additions":1435,"deletions":698,"changed_files":73}}