{"action":"created","issue":{"url":"https://api.github.com/repos/LMMS/lmms/issues/2748","repository_url":"https://api.github.com/repos/LMMS/lmms","labels_url":"https://api.github.com/repos/LMMS/lmms/issues/2748/labels{/name}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/2748/comments","events_url":"https://api.github.com/repos/LMMS/lmms/issues/2748/events","html_url":"https://github.com/LMMS/lmms/pull/2748","id":151983200,"number":2748,"title":"Fix ZynAddSubFxCore library issues","user":{"login":"jasp00","id":6378554,"avatar_url":"https://avatars.githubusercontent.com/u/6378554?v=3","gravatar_id":"","url":"https://api.github.com/users/jasp00","html_url":"https://github.com/jasp00","followers_url":"https://api.github.com/users/jasp00/followers","following_url":"https://api.github.com/users/jasp00/following{/other_user}","gists_url":"https://api.github.com/users/jasp00/gists{/gist_id}","starred_url":"https://api.github.com/users/jasp00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasp00/subscriptions","organizations_url":"https://api.github.com/users/jasp00/orgs","repos_url":"https://api.github.com/users/jasp00/repos","events_url":"https://api.github.com/users/jasp00/events{/privacy}","received_events_url":"https://api.github.com/users/jasp00/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2016-04-29T22:44:18Z","updated_at":"2016-05-02T19:48:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/2748","html_url":"https://github.com/LMMS/lmms/pull/2748","diff_url":"https://github.com/LMMS/lmms/pull/2748.diff","patch_url":"https://github.com/LMMS/lmms/pull/2748.patch"},"body":"This patch removes the SONAME from `libZynAddSubFxCore.so`, becoming a module like the other plugins. RUNPATH information is set for depending objects.\r\nThe issue about `libZynAddSubFxCore.so` being a shared library instead of a module is because there is no version information; it does not use names such as `libZynAddSubFxCore.so.0` or `libZynAddSubFxCore-0.so`."},"comment":{"url":"https://api.github.com/repos/LMMS/lmms/issues/comments/216342037","html_url":"https://github.com/LMMS/lmms/pull/2748#issuecomment-216342037","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/2748","id":216342037,"user":{"login":"jasp00","id":6378554,"avatar_url":"https://avatars.githubusercontent.com/u/6378554?v=3","gravatar_id":"","url":"https://api.github.com/users/jasp00","html_url":"https://github.com/jasp00","followers_url":"https://api.github.com/users/jasp00/followers","following_url":"https://api.github.com/users/jasp00/following{/other_user}","gists_url":"https://api.github.com/users/jasp00/gists{/gist_id}","starred_url":"https://api.github.com/users/jasp00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasp00/subscriptions","organizations_url":"https://api.github.com/users/jasp00/orgs","repos_url":"https://api.github.com/users/jasp00/repos","events_url":"https://api.github.com/users/jasp00/events{/privacy}","received_events_url":"https://api.github.com/users/jasp00/received_events","type":"User","site_admin":false},"created_at":"2016-05-02T19:48:26Z","updated_at":"2016-05-02T19:48:26Z","body":"> what's the reason for this change in the first place?\r\n\r\nWe have a tool in Debian, `dpkg-shlibdeps`, to calculate dependencies and detect some problems with libraries. One warning reported is:\r\n`can't extract name and version from library name 'libZynAddSubFxCore.so'`\r\n\r\nThe problem is that `libZynAddSubFxCore.so` has a SONAME without a version. The SONAME is used to provide backwards-compatibility information: a version should be present. But `libZynAddSubFxCore.so` is a private library, all depending objects are in sync, backwards-compatibility and SONAME are not needed. `libZynAddSubFxCore.so` must be `MODULE` instead of `SHARED` to remove the SONAME."}}