{"action":"closed","number":16585,"pull_request":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16585","id":85386225,"html_url":"https://github.com/cocos2d/cocos2d-x/pull/16585","diff_url":"https://github.com/cocos2d/cocos2d-x/pull/16585.diff","patch_url":"https://github.com/cocos2d/cocos2d-x/pull/16585.patch","issue_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/16585","number":16585,"state":"closed","locked":false,"title":"Move skipBOM function outside to prevent shadowing warning","user":{"login":"mogemimi","id":4461792,"avatar_url":"https://avatars.githubusercontent.com/u/4461792?v=3","gravatar_id":"","url":"https://api.github.com/users/mogemimi","html_url":"https://github.com/mogemimi","followers_url":"https://api.github.com/users/mogemimi/followers","following_url":"https://api.github.com/users/mogemimi/following{/other_user}","gists_url":"https://api.github.com/users/mogemimi/gists{/gist_id}","starred_url":"https://api.github.com/users/mogemimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mogemimi/subscriptions","organizations_url":"https://api.github.com/users/mogemimi/orgs","repos_url":"https://api.github.com/users/mogemimi/repos","events_url":"https://api.github.com/users/mogemimi/events{/privacy}","received_events_url":"https://api.github.com/users/mogemimi/received_events","type":"User","site_admin":false},"body":"I'm getting the following warning message when compiling libluacocos2d with Xcode 8.0:\r\n \r\n```\r\ncocos/scripting/lua-bindings/manual/CCLuaStack.cpp:851:36: declaration shadows a local variable [-Wshadow]\r\n\r\n    auto skipBOM = [](const char*& chunk, int& chunkSize){\r\n                  ^\r\n\r\ncocos/scripting/lua-bindings/manual/CCLuaStack.cpp:851:48: declaration shadows a local variable [-Wshadow]\r\n\r\n    auto skipBOM = [](const char*& chunk, int& chunkSize){\r\n                                                      ^\r\n```\r\n\r\nThis patch moves `skipBOM` function definition outside of `luaLoadBuffer` function to prevent those warnings.\r\nThanks!","created_at":"2016-09-15T11:22:34Z","updated_at":"2016-09-20T06:52:15Z","closed_at":"2016-09-20T06:52:15Z","merged_at":"2016-09-20T06:52:15Z","merge_commit_sha":"e8c308222923dc814997b7d24270bfc315d9f6b9","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/milestones/30","html_url":"https://github.com/cocos2d/cocos2d-x/milestones/3.14","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-x/milestones/30/labels","id":1869312,"number":30,"title":"3.14","description":"","creator":{"login":"minggo","id":488203,"avatar_url":"https://avatars.githubusercontent.com/u/488203?v=3","gravatar_id":"","url":"https://api.github.com/users/minggo","html_url":"https://github.com/minggo","followers_url":"https://api.github.com/users/minggo/followers","following_url":"https://api.github.com/users/minggo/following{/other_user}","gists_url":"https://api.github.com/users/minggo/gists{/gist_id}","starred_url":"https://api.github.com/users/minggo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minggo/subscriptions","organizations_url":"https://api.github.com/users/minggo/orgs","repos_url":"https://api.github.com/users/minggo/repos","events_url":"https://api.github.com/users/minggo/events{/privacy}","received_events_url":"https://api.github.com/users/minggo/received_events","type":"User","site_admin":false},"open_issues":33,"closed_issues":83,"state":"open","created_at":"2016-07-07T07:24:52Z","updated_at":"2016-09-20T06:52:15Z","due_on":"2016-10-18T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16585/commits","review_comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16585/comments","review_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/16585/comments","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/b43aa4a45ac64ce6ab4e19ef78f1ca6a471c446c","head":{"label":"mogemimi:fix-shadow-warning","ref":"fix-shadow-warning","sha":"b43aa4a45ac64ce6ab4e19ef78f1ca6a471c446c","user":{"login":"mogemimi","id":4461792,"avatar_url":"https://avatars.githubusercontent.com/u/4461792?v=3","gravatar_id":"","url":"https://api.github.com/users/mogemimi","html_url":"https://github.com/mogemimi","followers_url":"https://api.github.com/users/mogemimi/followers","following_url":"https://api.github.com/users/mogemimi/following{/other_user}","gists_url":"https://api.github.com/users/mogemimi/gists{/gist_id}","starred_url":"https://api.github.com/users/mogemimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mogemimi/subscriptions","organizations_url":"https://api.github.com/users/mogemimi/orgs","repos_url":"https://api.github.com/users/mogemimi/repos","events_url":"https://api.github.com/users/mogemimi/events{/privacy}","received_events_url":"https://api.github.com/users/mogemimi/received_events","type":"User","site_admin":false},"repo":{"id":44528954,"name":"cocos2d-x","full_name":"mogemimi/cocos2d-x","owner":{"login":"mogemimi","id":4461792,"avatar_url":"https://avatars.githubusercontent.com/u/4461792?v=3","gravatar_id":"","url":"https://api.github.com/users/mogemimi","html_url":"https://github.com/mogemimi","followers_url":"https://api.github.com/users/mogemimi/followers","following_url":"https://api.github.com/users/mogemimi/following{/other_user}","gists_url":"https://api.github.com/users/mogemimi/gists{/gist_id}","starred_url":"https://api.github.com/users/mogemimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mogemimi/subscriptions","organizations_url":"https://api.github.com/users/mogemimi/orgs","repos_url":"https://api.github.com/users/mogemimi/repos","events_url":"https://api.github.com/users/mogemimi/events{/privacy}","received_events_url":"https://api.github.com/users/mogemimi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mogemimi/cocos2d-x","description":"cocos2d-x for C++","fork":true,"url":"https://api.github.com/repos/mogemimi/cocos2d-x","forks_url":"https://api.github.com/repos/mogemimi/cocos2d-x/forks","keys_url":"https://api.github.com/repos/mogemimi/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mogemimi/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mogemimi/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/mogemimi/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/mogemimi/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/mogemimi/cocos2d-x/events","assignees_url":"https://api.github.com/repos/mogemimi/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/mogemimi/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/mogemimi/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/mogemimi/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mogemimi/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mogemimi/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/mogemimi/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mogemimi/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/mogemimi/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/mogemimi/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/mogemimi/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/mogemimi/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/mogemimi/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/mogemimi/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/mogemimi/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/mogemimi/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/mogemimi/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/mogemimi/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/mogemimi/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mogemimi/cocos2d-x/merges","archive_url":"https://api.github.com/repos/mogemimi/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mogemimi/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/mogemimi/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/mogemimi/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/mogemimi/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/mogemimi/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mogemimi/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/mogemimi/cocos2d-x/releases{/id}","deployments_url":"https://api.github.com/repos/mogemimi/cocos2d-x/deployments","created_at":"2015-10-19T11:04:24Z","updated_at":"2016-05-28T12:46:52Z","pushed_at":"2016-09-20T06:47:11Z","git_url":"git://github.com/mogemimi/cocos2d-x.git","ssh_url":"git@github.com:mogemimi/cocos2d-x.git","clone_url":"https://github.com/mogemimi/cocos2d-x.git","svn_url":"https://github.com/mogemimi/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":885055,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v3"}},"base":{"label":"cocos2d:v3","ref":"v3","sha":"91cdb3394b2d216fcfa7ecaa7b708a4ef98a37ef","user":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"repo":{"id":1093228,"name":"cocos2d-x","full_name":"cocos2d/cocos2d-x","owner":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos2d/cocos2d-x","description":"cocos2d-x for C++","fork":false,"url":"https://api.github.com/repos/cocos2d/cocos2d-x","forks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/forks","keys_url":"https://api.github.com/repos/cocos2d/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos2d/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos2d/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/events","assignees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/cocos2d/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos2d/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/cocos2d/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos2d/cocos2d-x/merges","archive_url":"https://api.github.com/repos/cocos2d/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos2d/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos2d/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos2d/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/cocos2d/cocos2d-x/releases{/id}","deployments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/deployments","created_at":"2010-11-18T23:17:00Z","updated_at":"2016-09-20T04:46:00Z","pushed_at":"2016-09-20T06:52:15Z","git_url":"git://github.com/cocos2d/cocos2d-x.git","ssh_url":"git@github.com:cocos2d/cocos2d-x.git","clone_url":"https://github.com/cocos2d/cocos2d-x.git","svn_url":"https://github.com/cocos2d/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":1523444,"stargazers_count":8766,"watchers_count":8766,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5672,"mirror_url":null,"open_issues_count":915,"forks":5672,"open_issues":915,"watchers":8766,"default_branch":"v3"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16585"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/16585"},"issue":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/16585"},"comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/16585/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16585/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/16585/commits"},"statuses":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/b43aa4a45ac64ce6ab4e19ef78f1ca6a471c446c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"minggo","id":488203,"avatar_url":"https://avatars.githubusercontent.com/u/488203?v=3","gravatar_id":"","url":"https://api.github.com/users/minggo","html_url":"https://github.com/minggo","followers_url":"https://api.github.com/users/minggo/followers","following_url":"https://api.github.com/users/minggo/following{/other_user}","gists_url":"https://api.github.com/users/minggo/gists{/gist_id}","starred_url":"https://api.github.com/users/minggo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minggo/subscriptions","organizations_url":"https://api.github.com/users/minggo/orgs","repos_url":"https://api.github.com/users/minggo/repos","events_url":"https://api.github.com/users/minggo/events{/privacy}","received_events_url":"https://api.github.com/users/minggo/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":16,"deletions":11,"changed_files":1}}
{"actor":{"display_login":"minggo"}}