{"action":"created","comment":{"url":"https://api.github.com/repos/cginternals/gloperate/pulls/comments/93208542","pull_request_review_id":13729851,"id":93208542,"diff_hunk":"@@ -67,30 +64,41 @@ void FramebufferStage::rebuildFBO()\n         }\n \n         for (auto input : this->inputs()) {\n-            if (auto slot = dynamic_cast<gloperate::InputSlot<globjects::Texture *> *>(input)) {\n-                // Get texture (if set)\n-                globjects::Texture * texture = slot->data();\n-                if (texture && i == 0) {\n-                    if (slot->name() != \"texDepth\") {\n-                        // Add color attachment\n-                        colorAttachments.push_back(index);\n-                        index = index + 1;\n-                    }\n-                } else if (texture && i == 1) {\n-                    if (slot->name() == \"texDepth\") {\n-                        // Add depth attachment\n-                        m_fbo->attachTexture(gl::GL_DEPTH_ATTACHMENT, texture);\n-                    } else {\n-                        // Add color attachment\n-                        m_fbo->attachTexture(index, texture);\n-                        index = index + 1;\n-                    }\n+            auto slot = dynamic_cast<Input<RenderTarget *> *>(input);\n+            if (!slot) {\n+                continue;\n+            }\n+            RenderTarget * texture = **slot;","path":"source/gloperate/source/stages/base/FramebufferStage.cpp","position":54,"original_position":54,"commit_id":"fb0a7afe5a545af5109c59e22ea785968ae5bb2d","original_commit_id":"fb0a7afe5a545af5109c59e22ea785968ae5bb2d","user":{"login":"Jopyth","id":564777,"avatar_url":"https://avatars.githubusercontent.com/u/564777?v=3","gravatar_id":"","url":"https://api.github.com/users/Jopyth","html_url":"https://github.com/Jopyth","followers_url":"https://api.github.com/users/Jopyth/followers","following_url":"https://api.github.com/users/Jopyth/following{/other_user}","gists_url":"https://api.github.com/users/Jopyth/gists{/gist_id}","starred_url":"https://api.github.com/users/Jopyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jopyth/subscriptions","organizations_url":"https://api.github.com/users/Jopyth/orgs","repos_url":"https://api.github.com/users/Jopyth/repos","events_url":"https://api.github.com/users/Jopyth/events{/privacy}","received_events_url":"https://api.github.com/users/Jopyth/received_events","type":"User","site_admin":false},"body":"That is only two stars though. ;)\r\n\r\nShould I make it clearer that the second \"dereferences\" a slots?","created_at":"2016-12-20T10:22:58Z","updated_at":"2016-12-20T10:22:58Z","html_url":"https://github.com/cginternals/gloperate/pull/239#discussion_r93208542","pull_request_url":"https://api.github.com/repos/cginternals/gloperate/pulls/239","_links":{"self":{"href":"https://api.github.com/repos/cginternals/gloperate/pulls/comments/93208542"},"html":{"href":"https://github.com/cginternals/gloperate/pull/239#discussion_r93208542"},"pull_request":{"href":"https://api.github.com/repos/cginternals/gloperate/pulls/239"}}},"pull_request":{"url":"https://api.github.com/repos/cginternals/gloperate/pulls/239","id":98364664,"html_url":"https://github.com/cginternals/gloperate/pull/239","diff_url":"https://github.com/cginternals/gloperate/pull/239.diff","patch_url":"https://github.com/cginternals/gloperate/pull/239.patch","issue_url":"https://api.github.com/repos/cginternals/gloperate/issues/239","number":239,"state":"open","locked":false,"title":"Base class for render target introduced","user":{"login":"Jopyth","id":564777,"avatar_url":"https://avatars.githubusercontent.com/u/564777?v=3","gravatar_id":"","url":"https://api.github.com/users/Jopyth","html_url":"https://github.com/Jopyth","followers_url":"https://api.github.com/users/Jopyth/followers","following_url":"https://api.github.com/users/Jopyth/following{/other_user}","gists_url":"https://api.github.com/users/Jopyth/gists{/gist_id}","starred_url":"https://api.github.com/users/Jopyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jopyth/subscriptions","organizations_url":"https://api.github.com/users/Jopyth/orgs","repos_url":"https://api.github.com/users/Jopyth/repos","events_url":"https://api.github.com/users/Jopyth/events{/privacy}","received_events_url":"https://api.github.com/users/Jopyth/received_events","type":"User","site_admin":false},"body":"Other changes combined with this:\r\n\r\n- `TextureStage` changed (#201):\r\n    - Uses `glm::vec4` now (i.e. viewport)\r\n    - New `RenderTarget` output, wraps output `Texture`\r\n- `FramebufferStage` adapted:\r\n    - Combines multiple `RenderTarget`s into an FBO\r\n    - Currently two default inputs for depth and color\r\n\r\nThis is only the very basic implementation, further methods for reading from a `RenderTarget` and a possible example case need to be done. ","created_at":"2016-12-16T16:36:28Z","updated_at":"2016-12-20T10:22:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc0b98cd3534c81bb43c0f31130cbea2d792c463","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cginternals/gloperate/milestones/4","html_url":"https://github.com/cginternals/gloperate/milestone/4","labels_url":"https://api.github.com/repos/cginternals/gloperate/milestones/4/labels","id":2183960,"number":4,"title":"2.0 - rendering","description":"Implement all basic rendering primitives for a generic gloperate rendering framework","creator":{"login":"sbusch42","id":4170982,"avatar_url":"https://avatars.githubusercontent.com/u/4170982?v=3","gravatar_id":"","url":"https://api.github.com/users/sbusch42","html_url":"https://github.com/sbusch42","followers_url":"https://api.github.com/users/sbusch42/followers","following_url":"https://api.github.com/users/sbusch42/following{/other_user}","gists_url":"https://api.github.com/users/sbusch42/gists{/gist_id}","starred_url":"https://api.github.com/users/sbusch42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbusch42/subscriptions","organizations_url":"https://api.github.com/users/sbusch42/orgs","repos_url":"https://api.github.com/users/sbusch42/repos","events_url":"https://api.github.com/users/sbusch42/events{/privacy}","received_events_url":"https://api.github.com/users/sbusch42/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":0,"state":"open","created_at":"2016-12-08T12:49:37Z","updated_at":"2016-12-16T17:02:41Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cginternals/gloperate/pulls/239/commits","review_comments_url":"https://api.github.com/repos/cginternals/gloperate/pulls/239/comments","review_comment_url":"https://api.github.com/repos/cginternals/gloperate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cginternals/gloperate/issues/239/comments","statuses_url":"https://api.github.com/repos/cginternals/gloperate/statuses/fb0a7afe5a545af5109c59e22ea785968ae5bb2d","head":{"label":"Jopyth:2.0_render_target","ref":"2.0_render_target","sha":"fb0a7afe5a545af5109c59e22ea785968ae5bb2d","user":{"login":"Jopyth","id":564777,"avatar_url":"https://avatars.githubusercontent.com/u/564777?v=3","gravatar_id":"","url":"https://api.github.com/users/Jopyth","html_url":"https://github.com/Jopyth","followers_url":"https://api.github.com/users/Jopyth/followers","following_url":"https://api.github.com/users/Jopyth/following{/other_user}","gists_url":"https://api.github.com/users/Jopyth/gists{/gist_id}","starred_url":"https://api.github.com/users/Jopyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jopyth/subscriptions","organizations_url":"https://api.github.com/users/Jopyth/orgs","repos_url":"https://api.github.com/users/Jopyth/repos","events_url":"https://api.github.com/users/Jopyth/events{/privacy}","received_events_url":"https://api.github.com/users/Jopyth/received_events","type":"User","site_admin":false},"repo":{"id":47197149,"name":"gloperate","full_name":"Jopyth/gloperate","owner":{"login":"Jopyth","id":564777,"avatar_url":"https://avatars.githubusercontent.com/u/564777?v=3","gravatar_id":"","url":"https://api.github.com/users/Jopyth","html_url":"https://github.com/Jopyth","followers_url":"https://api.github.com/users/Jopyth/followers","following_url":"https://api.github.com/users/Jopyth/following{/other_user}","gists_url":"https://api.github.com/users/Jopyth/gists{/gist_id}","starred_url":"https://api.github.com/users/Jopyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jopyth/subscriptions","organizations_url":"https://api.github.com/users/Jopyth/orgs","repos_url":"https://api.github.com/users/Jopyth/repos","events_url":"https://api.github.com/users/Jopyth/events{/privacy}","received_events_url":"https://api.github.com/users/Jopyth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jopyth/gloperate","description":"C++ library for defining and controlling modern GPU rendering/processing operations","fork":true,"url":"https://api.github.com/repos/Jopyth/gloperate","forks_url":"https://api.github.com/repos/Jopyth/gloperate/forks","keys_url":"https://api.github.com/repos/Jopyth/gloperate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jopyth/gloperate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jopyth/gloperate/teams","hooks_url":"https://api.github.com/repos/Jopyth/gloperate/hooks","issue_events_url":"https://api.github.com/repos/Jopyth/gloperate/issues/events{/number}","events_url":"https://api.github.com/repos/Jopyth/gloperate/events","assignees_url":"https://api.github.com/repos/Jopyth/gloperate/assignees{/user}","branches_url":"https://api.github.com/repos/Jopyth/gloperate/branches{/branch}","tags_url":"https://api.github.com/repos/Jopyth/gloperate/tags","blobs_url":"https://api.github.com/repos/Jopyth/gloperate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jopyth/gloperate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jopyth/gloperate/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jopyth/gloperate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jopyth/gloperate/statuses/{sha}","languages_url":"https://api.github.com/repos/Jopyth/gloperate/languages","stargazers_url":"https://api.github.com/repos/Jopyth/gloperate/stargazers","contributors_url":"https://api.github.com/repos/Jopyth/gloperate/contributors","subscribers_url":"https://api.github.com/repos/Jopyth/gloperate/subscribers","subscription_url":"https://api.github.com/repos/Jopyth/gloperate/subscription","commits_url":"https://api.github.com/repos/Jopyth/gloperate/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jopyth/gloperate/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jopyth/gloperate/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jopyth/gloperate/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jopyth/gloperate/contents/{+path}","compare_url":"https://api.github.com/repos/Jopyth/gloperate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jopyth/gloperate/merges","archive_url":"https://api.github.com/repos/Jopyth/gloperate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jopyth/gloperate/downloads","issues_url":"https://api.github.com/repos/Jopyth/gloperate/issues{/number}","pulls_url":"https://api.github.com/repos/Jopyth/gloperate/pulls{/number}","milestones_url":"https://api.github.com/repos/Jopyth/gloperate/milestones{/number}","notifications_url":"https://api.github.com/repos/Jopyth/gloperate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jopyth/gloperate/labels{/name}","releases_url":"https://api.github.com/repos/Jopyth/gloperate/releases{/id}","deployments_url":"https://api.github.com/repos/Jopyth/gloperate/deployments","created_at":"2015-12-01T15:08:57Z","updated_at":"2015-12-01T15:08:58Z","pushed_at":"2016-12-16T16:37:39Z","git_url":"git://github.com/Jopyth/gloperate.git","ssh_url":"git@github.com:Jopyth/gloperate.git","clone_url":"https://github.com/Jopyth/gloperate.git","svn_url":"https://github.com/Jopyth/gloperate","homepage":null,"size":5838,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cginternals:2.0","ref":"2.0","sha":"806c203d8f2f86f70139ccb945a269dade5278d7","user":{"login":"cginternals","id":13125552,"avatar_url":"https://avatars.githubusercontent.com/u/13125552?v=3","gravatar_id":"","url":"https://api.github.com/users/cginternals","html_url":"https://github.com/cginternals","followers_url":"https://api.github.com/users/cginternals/followers","following_url":"https://api.github.com/users/cginternals/following{/other_user}","gists_url":"https://api.github.com/users/cginternals/gists{/gist_id}","starred_url":"https://api.github.com/users/cginternals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cginternals/subscriptions","organizations_url":"https://api.github.com/users/cginternals/orgs","repos_url":"https://api.github.com/users/cginternals/repos","events_url":"https://api.github.com/users/cginternals/events{/privacy}","received_events_url":"https://api.github.com/users/cginternals/received_events","type":"Organization","site_admin":false},"repo":{"id":23700348,"name":"gloperate","full_name":"cginternals/gloperate","owner":{"login":"cginternals","id":13125552,"avatar_url":"https://avatars.githubusercontent.com/u/13125552?v=3","gravatar_id":"","url":"https://api.github.com/users/cginternals","html_url":"https://github.com/cginternals","followers_url":"https://api.github.com/users/cginternals/followers","following_url":"https://api.github.com/users/cginternals/following{/other_user}","gists_url":"https://api.github.com/users/cginternals/gists{/gist_id}","starred_url":"https://api.github.com/users/cginternals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cginternals/subscriptions","organizations_url":"https://api.github.com/users/cginternals/orgs","repos_url":"https://api.github.com/users/cginternals/repos","events_url":"https://api.github.com/users/cginternals/events{/privacy}","received_events_url":"https://api.github.com/users/cginternals/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cginternals/gloperate","description":"C++ library for defining and controlling modern GPU rendering/processing operations.","fork":false,"url":"https://api.github.com/repos/cginternals/gloperate","forks_url":"https://api.github.com/repos/cginternals/gloperate/forks","keys_url":"https://api.github.com/repos/cginternals/gloperate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cginternals/gloperate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cginternals/gloperate/teams","hooks_url":"https://api.github.com/repos/cginternals/gloperate/hooks","issue_events_url":"https://api.github.com/repos/cginternals/gloperate/issues/events{/number}","events_url":"https://api.github.com/repos/cginternals/gloperate/events","assignees_url":"https://api.github.com/repos/cginternals/gloperate/assignees{/user}","branches_url":"https://api.github.com/repos/cginternals/gloperate/branches{/branch}","tags_url":"https://api.github.com/repos/cginternals/gloperate/tags","blobs_url":"https://api.github.com/repos/cginternals/gloperate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cginternals/gloperate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cginternals/gloperate/git/refs{/sha}","trees_url":"https://api.github.com/repos/cginternals/gloperate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cginternals/gloperate/statuses/{sha}","languages_url":"https://api.github.com/repos/cginternals/gloperate/languages","stargazers_url":"https://api.github.com/repos/cginternals/gloperate/stargazers","contributors_url":"https://api.github.com/repos/cginternals/gloperate/contributors","subscribers_url":"https://api.github.com/repos/cginternals/gloperate/subscribers","subscription_url":"https://api.github.com/repos/cginternals/gloperate/subscription","commits_url":"https://api.github.com/repos/cginternals/gloperate/commits{/sha}","git_commits_url":"https://api.github.com/repos/cginternals/gloperate/git/commits{/sha}","comments_url":"https://api.github.com/repos/cginternals/gloperate/comments{/number}","issue_comment_url":"https://api.github.com/repos/cginternals/gloperate/issues/comments{/number}","contents_url":"https://api.github.com/repos/cginternals/gloperate/contents/{+path}","compare_url":"https://api.github.com/repos/cginternals/gloperate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cginternals/gloperate/merges","archive_url":"https://api.github.com/repos/cginternals/gloperate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cginternals/gloperate/downloads","issues_url":"https://api.github.com/repos/cginternals/gloperate/issues{/number}","pulls_url":"https://api.github.com/repos/cginternals/gloperate/pulls{/number}","milestones_url":"https://api.github.com/repos/cginternals/gloperate/milestones{/number}","notifications_url":"https://api.github.com/repos/cginternals/gloperate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cginternals/gloperate/labels{/name}","releases_url":"https://api.github.com/repos/cginternals/gloperate/releases{/id}","deployments_url":"https://api.github.com/repos/cginternals/gloperate/deployments","created_at":"2014-09-05T11:16:49Z","updated_at":"2016-11-27T05:15:08Z","pushed_at":"2016-12-16T16:37:39Z","git_url":"git://github.com/cginternals/gloperate.git","ssh_url":"git@github.com:cginternals/gloperate.git","clone_url":"https://github.com/cginternals/gloperate.git","svn_url":"https://github.com/cginternals/gloperate","homepage":"","size":5952,"stargazers_count":22,"watchers_count":22,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":65,"forks":26,"open_issues":65,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cginternals/gloperate/pulls/239"},"html":{"href":"https://github.com/cginternals/gloperate/pull/239"},"issue":{"href":"https://api.github.com/repos/cginternals/gloperate/issues/239"},"comments":{"href":"https://api.github.com/repos/cginternals/gloperate/issues/239/comments"},"review_comments":{"href":"https://api.github.com/repos/cginternals/gloperate/pulls/239/comments"},"review_comment":{"href":"https://api.github.com/repos/cginternals/gloperate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cginternals/gloperate/pulls/239/commits"},"statuses":{"href":"https://api.github.com/repos/cginternals/gloperate/statuses/fb0a7afe5a545af5109c59e22ea785968ae5bb2d"}}}}
{"actor":{"display_login":"Jopyth"}}