{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments/75508894","id":75508894,"diff_hunk":"@@ -163,13 +163,14 @@ function JSONtest(params) {\n               // accumulate the assertions - but only when level is 0\n               var list = [] ;\n \n+              var type = \"\";\n               if (assertions) {\n                 if (typeof assertions === \"object\" && assertions.hasOwnProperty('assertions')) {\n                   // this is a conditionObject\n                   if (level === 0) {\n                     list.push(assertContents[assertIdx]);\n                   }\n-                  var type = assertContents[assertIdx].hasOwnProperty('assertionType') ? assertContents[assertIdx].assertionType : \"must\" ;\n+                  type = assertContents[assertIdx].hasOwnProperty('assertionType') ? assertContents[assertIdx].assertionType : \"must\" ;","path":"annotation-model/scripts/JSONtest.js","position":12,"original_position":12,"commit_id":"37eef4e7c2bb3fc0d1be9395c9f2abc5fd34fc0a","original_commit_id":"37eef4e7c2bb3fc0d1be9395c9f2abc5fd34fc0a","user":{"login":"halindrome","id":520688,"avatar_url":"https://avatars.githubusercontent.com/u/520688?v=3","gravatar_id":"","url":"https://api.github.com/users/halindrome","html_url":"https://github.com/halindrome","followers_url":"https://api.github.com/users/halindrome/followers","following_url":"https://api.github.com/users/halindrome/following{/other_user}","gists_url":"https://api.github.com/users/halindrome/gists{/gist_id}","starred_url":"https://api.github.com/users/halindrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halindrome/subscriptions","organizations_url":"https://api.github.com/users/halindrome/orgs","repos_url":"https://api.github.com/users/halindrome/repos","events_url":"https://api.github.com/users/halindrome/events{/privacy}","received_events_url":"https://api.github.com/users/halindrome/received_events","type":"User","site_admin":false},"body":"yeah - you are right... I will adjust","created_at":"2016-08-19T16:10:16Z","updated_at":"2016-08-19T16:10:16Z","html_url":"https://github.com/w3c/web-platform-tests/pull/3489#discussion_r75508894","pull_request_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/3489","_links":{"self":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments/75508894"},"html":{"href":"https://github.com/w3c/web-platform-tests/pull/3489#discussion_r75508894"},"pull_request":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/3489"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/3489","id":81838191,"html_url":"https://github.com/w3c/web-platform-tests/pull/3489","diff_url":"https://github.com/w3c/web-platform-tests/pull/3489.diff","patch_url":"https://github.com/w3c/web-platform-tests/pull/3489.patch","issue_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/3489","number":3489,"state":"open","locked":false,"title":"Fixed handling of documentation for optionals","user":{"login":"halindrome","id":520688,"avatar_url":"https://avatars.githubusercontent.com/u/520688?v=3","gravatar_id":"","url":"https://api.github.com/users/halindrome","html_url":"https://github.com/halindrome","followers_url":"https://api.github.com/users/halindrome/followers","following_url":"https://api.github.com/users/halindrome/following{/other_user}","gists_url":"https://api.github.com/users/halindrome/gists{/gist_id}","starred_url":"https://api.github.com/users/halindrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halindrome/subscriptions","organizations_url":"https://api.github.com/users/halindrome/orgs","repos_url":"https://api.github.com/users/halindrome/repos","events_url":"https://api.github.com/users/halindrome/events{/privacy}","received_events_url":"https://api.github.com/users/halindrome/received_events","type":"User","site_admin":false},"body":"If an assertionType was may or should AND if the assertion was\r\na reference to an external file, then the type was not being\r\nmapped correctly to its documentation descriptor.\r\n\r\n@bigbluehat or @tcole3 r?","created_at":"2016-08-18T15:38:34Z","updated_at":"2016-08-19T16:10:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77c7ceb48c16e8e8b6965d51f8134bbeede5c6ae","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/3489/commits","review_comments_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/3489/comments","review_comment_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/3489/comments","statuses_url":"https://api.github.com/repos/w3c/web-platform-tests/statuses/37eef4e7c2bb3fc0d1be9395c9f2abc5fd34fc0a","head":{"label":"Spec-Ops:annotation-model-optionals","ref":"annotation-model-optionals","sha":"37eef4e7c2bb3fc0d1be9395c9f2abc5fd34fc0a","user":{"login":"Spec-Ops","id":12448423,"avatar_url":"https://avatars.githubusercontent.com/u/12448423?v=3","gravatar_id":"","url":"https://api.github.com/users/Spec-Ops","html_url":"https://github.com/Spec-Ops","followers_url":"https://api.github.com/users/Spec-Ops/followers","following_url":"https://api.github.com/users/Spec-Ops/following{/other_user}","gists_url":"https://api.github.com/users/Spec-Ops/gists{/gist_id}","starred_url":"https://api.github.com/users/Spec-Ops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spec-Ops/subscriptions","organizations_url":"https://api.github.com/users/Spec-Ops/orgs","repos_url":"https://api.github.com/users/Spec-Ops/repos","events_url":"https://api.github.com/users/Spec-Ops/events{/privacy}","received_events_url":"https://api.github.com/users/Spec-Ops/received_events","type":"Organization","site_admin":false},"repo":{"id":54023228,"name":"web-platform-tests","full_name":"Spec-Ops/web-platform-tests","owner":{"login":"Spec-Ops","id":12448423,"avatar_url":"https://avatars.githubusercontent.com/u/12448423?v=3","gravatar_id":"","url":"https://api.github.com/users/Spec-Ops","html_url":"https://github.com/Spec-Ops","followers_url":"https://api.github.com/users/Spec-Ops/followers","following_url":"https://api.github.com/users/Spec-Ops/following{/other_user}","gists_url":"https://api.github.com/users/Spec-Ops/gists{/gist_id}","starred_url":"https://api.github.com/users/Spec-Ops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spec-Ops/subscriptions","organizations_url":"https://api.github.com/users/Spec-Ops/orgs","repos_url":"https://api.github.com/users/Spec-Ops/repos","events_url":"https://api.github.com/users/Spec-Ops/events{/privacy}","received_events_url":"https://api.github.com/users/Spec-Ops/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Spec-Ops/web-platform-tests","description":"Test Suites for Web Platform specifications—including WHATWG, W3C and others","fork":true,"url":"https://api.github.com/repos/Spec-Ops/web-platform-tests","forks_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/forks","keys_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/teams","hooks_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/hooks","issue_events_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/issues/events{/number}","events_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/events","assignees_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/assignees{/user}","branches_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/branches{/branch}","tags_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/tags","blobs_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/languages","stargazers_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/stargazers","contributors_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/contributors","subscribers_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/subscribers","subscription_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/subscription","commits_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/contents/{+path}","compare_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/merges","archive_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/downloads","issues_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/issues{/number}","pulls_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/labels{/name}","releases_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/releases{/id}","deployments_url":"https://api.github.com/repos/Spec-Ops/web-platform-tests/deployments","created_at":"2016-03-16T10:39:23Z","updated_at":"2016-08-12T16:10:03Z","pushed_at":"2016-08-19T15:29:01Z","git_url":"git://github.com/Spec-Ops/web-platform-tests.git","ssh_url":"git@github.com:Spec-Ops/web-platform-tests.git","clone_url":"https://github.com/Spec-Ops/web-platform-tests.git","svn_url":"https://github.com/Spec-Ops/web-platform-tests","homepage":"http://irc.w3.org/?channels=testing","size":163732,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":2,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"5c4096432f0a1c8e672919efde89de5e9bed3ebe","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":3618133,"name":"web-platform-tests","full_name":"w3c/web-platform-tests","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/web-platform-tests","description":"Test Suites for Web Platform specifications—including WHATWG, W3C and others","fork":false,"url":"https://api.github.com/repos/w3c/web-platform-tests","forks_url":"https://api.github.com/repos/w3c/web-platform-tests/forks","keys_url":"https://api.github.com/repos/w3c/web-platform-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/web-platform-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/web-platform-tests/teams","hooks_url":"https://api.github.com/repos/w3c/web-platform-tests/hooks","issue_events_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/web-platform-tests/events","assignees_url":"https://api.github.com/repos/w3c/web-platform-tests/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/web-platform-tests/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/web-platform-tests/tags","blobs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/web-platform-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/web-platform-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/web-platform-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/web-platform-tests/languages","stargazers_url":"https://api.github.com/repos/w3c/web-platform-tests/stargazers","contributors_url":"https://api.github.com/repos/w3c/web-platform-tests/contributors","subscribers_url":"https://api.github.com/repos/w3c/web-platform-tests/subscribers","subscription_url":"https://api.github.com/repos/w3c/web-platform-tests/subscription","commits_url":"https://api.github.com/repos/w3c/web-platform-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/web-platform-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/web-platform-tests/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/web-platform-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/web-platform-tests/merges","archive_url":"https://api.github.com/repos/w3c/web-platform-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/web-platform-tests/downloads","issues_url":"https://api.github.com/repos/w3c/web-platform-tests/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/web-platform-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/web-platform-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/web-platform-tests/labels{/name}","releases_url":"https://api.github.com/repos/w3c/web-platform-tests/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/web-platform-tests/deployments","created_at":"2012-03-04T12:58:11Z","updated_at":"2016-08-19T08:46:42Z","pushed_at":"2016-08-19T14:12:54Z","git_url":"git://github.com/w3c/web-platform-tests.git","ssh_url":"git@github.com:w3c/web-platform-tests.git","clone_url":"https://github.com/w3c/web-platform-tests.git","svn_url":"https://github.com/w3c/web-platform-tests","homepage":"http://irc.w3.org/?channels=testing","size":330431,"stargazers_count":807,"watchers_count":807,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":907,"mirror_url":null,"open_issues_count":391,"forks":907,"open_issues":391,"watchers":807,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/3489"},"html":{"href":"https://github.com/w3c/web-platform-tests/pull/3489"},"issue":{"href":"https://api.github.com/repos/w3c/web-platform-tests/issues/3489"},"comments":{"href":"https://api.github.com/repos/w3c/web-platform-tests/issues/3489/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/3489/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/3489/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/web-platform-tests/statuses/37eef4e7c2bb3fc0d1be9395c9f2abc5fd34fc0a"}}}}
{"actor":{"display_login":"halindrome"}}