{"action":"created","comment":{"url":"https://api.github.com/repos/amco/dolly/pulls/comments/83121589","pull_request_review_id":3983591,"id":83121589,"diff_hunk":"@@ -12,19 +12,42 @@ def initialize opts = {}\n       @default = opts.delete(:default)\n       @default = @default.clone if @default && CANT_CLONE.none? { |klass| @default.is_a? klass }\n       @value = @default if @default\n+      @subproperties = {}\n       warn 'There are some unprocessed options!' if opts.present?\n     end\n \n     def value","path":"lib/dolly/property.rb","position":17,"original_position":17,"commit_id":"2bc602fcae6b8b4608b8e91d3512dbbaa0af525e","original_commit_id":"2bc602fcae6b8b4608b8e91d3512dbbaa0af525e","user":{"login":"neojin","id":5699,"avatar_url":"https://avatars.githubusercontent.com/u/5699?v=3","gravatar_id":"","url":"https://api.github.com/users/neojin","html_url":"https://github.com/neojin","followers_url":"https://api.github.com/users/neojin/followers","following_url":"https://api.github.com/users/neojin/following{/other_user}","gists_url":"https://api.github.com/users/neojin/gists{/gist_id}","starred_url":"https://api.github.com/users/neojin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neojin/subscriptions","organizations_url":"https://api.github.com/users/neojin/orgs","repos_url":"https://api.github.com/users/neojin/repos","events_url":"https://api.github.com/users/neojin/events{/privacy}","received_events_url":"https://api.github.com/users/neojin/received_events","type":"User","site_admin":false},"body":"in general it seems like this method is now doing a lot of work and wondering if it might be worth splitting up","created_at":"2016-10-12T23:45:22Z","updated_at":"2016-10-12T23:45:22Z","html_url":"https://github.com/amco/dolly/pull/124#discussion_r83121589","pull_request_url":"https://api.github.com/repos/amco/dolly/pulls/124","_links":{"self":{"href":"https://api.github.com/repos/amco/dolly/pulls/comments/83121589"},"html":{"href":"https://github.com/amco/dolly/pull/124#discussion_r83121589"},"pull_request":{"href":"https://api.github.com/repos/amco/dolly/pulls/124"}}},"pull_request":{"url":"https://api.github.com/repos/amco/dolly/pulls/124","id":88927524,"html_url":"https://github.com/amco/dolly/pull/124","diff_url":"https://github.com/amco/dolly/pull/124.diff","patch_url":"https://github.com/amco/dolly/pull/124.patch","issue_url":"https://api.github.com/repos/amco/dolly/issues/124","number":124,"state":"open","locked":false,"title":"Sub properties","user":{"login":"seancookr","id":3506743,"avatar_url":"https://avatars.githubusercontent.com/u/3506743?v=3","gravatar_id":"","url":"https://api.github.com/users/seancookr","html_url":"https://github.com/seancookr","followers_url":"https://api.github.com/users/seancookr/followers","following_url":"https://api.github.com/users/seancookr/following{/other_user}","gists_url":"https://api.github.com/users/seancookr/gists{/gist_id}","starred_url":"https://api.github.com/users/seancookr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seancookr/subscriptions","organizations_url":"https://api.github.com/users/seancookr/orgs","repos_url":"https://api.github.com/users/seancookr/repos","events_url":"https://api.github.com/users/seancookr/events{/privacy}","received_events_url":"https://api.github.com/users/seancookr/received_events","type":"User","site_admin":false},"body":"# DO NOT MERGE\r\n\r\nthis is just a concept I've been thinking about implementing, I would Like to get some feedback on the design approach.","created_at":"2016-10-11T23:10:00Z","updated_at":"2016-10-12T23:45:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f86297fa3b9ed0690e66d66ed63c45947ea4b382","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/amco/dolly/pulls/124/commits","review_comments_url":"https://api.github.com/repos/amco/dolly/pulls/124/comments","review_comment_url":"https://api.github.com/repos/amco/dolly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amco/dolly/issues/124/comments","statuses_url":"https://api.github.com/repos/amco/dolly/statuses/2bc602fcae6b8b4608b8e91d3512dbbaa0af525e","head":{"label":"amco:sub-properties","ref":"sub-properties","sha":"2bc602fcae6b8b4608b8e91d3512dbbaa0af525e","user":{"login":"amco","id":137698,"avatar_url":"https://avatars.githubusercontent.com/u/137698?v=3","gravatar_id":"","url":"https://api.github.com/users/amco","html_url":"https://github.com/amco","followers_url":"https://api.github.com/users/amco/followers","following_url":"https://api.github.com/users/amco/following{/other_user}","gists_url":"https://api.github.com/users/amco/gists{/gist_id}","starred_url":"https://api.github.com/users/amco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amco/subscriptions","organizations_url":"https://api.github.com/users/amco/orgs","repos_url":"https://api.github.com/users/amco/repos","events_url":"https://api.github.com/users/amco/events{/privacy}","received_events_url":"https://api.github.com/users/amco/received_events","type":"Organization","site_admin":false},"repo":{"id":13510618,"name":"dolly","full_name":"amco/dolly","owner":{"login":"amco","id":137698,"avatar_url":"https://avatars.githubusercontent.com/u/137698?v=3","gravatar_id":"","url":"https://api.github.com/users/amco","html_url":"https://github.com/amco","followers_url":"https://api.github.com/users/amco/followers","following_url":"https://api.github.com/users/amco/following{/other_user}","gists_url":"https://api.github.com/users/amco/gists{/gist_id}","starred_url":"https://api.github.com/users/amco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amco/subscriptions","organizations_url":"https://api.github.com/users/amco/orgs","repos_url":"https://api.github.com/users/amco/repos","events_url":"https://api.github.com/users/amco/events{/privacy}","received_events_url":"https://api.github.com/users/amco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amco/dolly","description":"Not an ORM for CouchDB in rails.","fork":false,"url":"https://api.github.com/repos/amco/dolly","forks_url":"https://api.github.com/repos/amco/dolly/forks","keys_url":"https://api.github.com/repos/amco/dolly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amco/dolly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amco/dolly/teams","hooks_url":"https://api.github.com/repos/amco/dolly/hooks","issue_events_url":"https://api.github.com/repos/amco/dolly/issues/events{/number}","events_url":"https://api.github.com/repos/amco/dolly/events","assignees_url":"https://api.github.com/repos/amco/dolly/assignees{/user}","branches_url":"https://api.github.com/repos/amco/dolly/branches{/branch}","tags_url":"https://api.github.com/repos/amco/dolly/tags","blobs_url":"https://api.github.com/repos/amco/dolly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amco/dolly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amco/dolly/git/refs{/sha}","trees_url":"https://api.github.com/repos/amco/dolly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amco/dolly/statuses/{sha}","languages_url":"https://api.github.com/repos/amco/dolly/languages","stargazers_url":"https://api.github.com/repos/amco/dolly/stargazers","contributors_url":"https://api.github.com/repos/amco/dolly/contributors","subscribers_url":"https://api.github.com/repos/amco/dolly/subscribers","subscription_url":"https://api.github.com/repos/amco/dolly/subscription","commits_url":"https://api.github.com/repos/amco/dolly/commits{/sha}","git_commits_url":"https://api.github.com/repos/amco/dolly/git/commits{/sha}","comments_url":"https://api.github.com/repos/amco/dolly/comments{/number}","issue_comment_url":"https://api.github.com/repos/amco/dolly/issues/comments{/number}","contents_url":"https://api.github.com/repos/amco/dolly/contents/{+path}","compare_url":"https://api.github.com/repos/amco/dolly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amco/dolly/merges","archive_url":"https://api.github.com/repos/amco/dolly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amco/dolly/downloads","issues_url":"https://api.github.com/repos/amco/dolly/issues{/number}","pulls_url":"https://api.github.com/repos/amco/dolly/pulls{/number}","milestones_url":"https://api.github.com/repos/amco/dolly/milestones{/number}","notifications_url":"https://api.github.com/repos/amco/dolly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amco/dolly/labels{/name}","releases_url":"https://api.github.com/repos/amco/dolly/releases{/id}","deployments_url":"https://api.github.com/repos/amco/dolly/deployments","created_at":"2013-10-11T21:54:52Z","updated_at":"2016-03-08T22:16:20Z","pushed_at":"2016-10-12T05:00:06Z","git_url":"git://github.com/amco/dolly.git","ssh_url":"git@github.com:amco/dolly.git","clone_url":"https://github.com/amco/dolly.git","svn_url":"https://github.com/amco/dolly","homepage":null,"size":311,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":25,"forks":2,"open_issues":25,"watchers":4,"default_branch":"1.0"}},"base":{"label":"amco:1.1","ref":"1.1","sha":"2e4e8abed87e0e1d20675aa559bc62ba190b699a","user":{"login":"amco","id":137698,"avatar_url":"https://avatars.githubusercontent.com/u/137698?v=3","gravatar_id":"","url":"https://api.github.com/users/amco","html_url":"https://github.com/amco","followers_url":"https://api.github.com/users/amco/followers","following_url":"https://api.github.com/users/amco/following{/other_user}","gists_url":"https://api.github.com/users/amco/gists{/gist_id}","starred_url":"https://api.github.com/users/amco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amco/subscriptions","organizations_url":"https://api.github.com/users/amco/orgs","repos_url":"https://api.github.com/users/amco/repos","events_url":"https://api.github.com/users/amco/events{/privacy}","received_events_url":"https://api.github.com/users/amco/received_events","type":"Organization","site_admin":false},"repo":{"id":13510618,"name":"dolly","full_name":"amco/dolly","owner":{"login":"amco","id":137698,"avatar_url":"https://avatars.githubusercontent.com/u/137698?v=3","gravatar_id":"","url":"https://api.github.com/users/amco","html_url":"https://github.com/amco","followers_url":"https://api.github.com/users/amco/followers","following_url":"https://api.github.com/users/amco/following{/other_user}","gists_url":"https://api.github.com/users/amco/gists{/gist_id}","starred_url":"https://api.github.com/users/amco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amco/subscriptions","organizations_url":"https://api.github.com/users/amco/orgs","repos_url":"https://api.github.com/users/amco/repos","events_url":"https://api.github.com/users/amco/events{/privacy}","received_events_url":"https://api.github.com/users/amco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amco/dolly","description":"Not an ORM for CouchDB in rails.","fork":false,"url":"https://api.github.com/repos/amco/dolly","forks_url":"https://api.github.com/repos/amco/dolly/forks","keys_url":"https://api.github.com/repos/amco/dolly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amco/dolly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amco/dolly/teams","hooks_url":"https://api.github.com/repos/amco/dolly/hooks","issue_events_url":"https://api.github.com/repos/amco/dolly/issues/events{/number}","events_url":"https://api.github.com/repos/amco/dolly/events","assignees_url":"https://api.github.com/repos/amco/dolly/assignees{/user}","branches_url":"https://api.github.com/repos/amco/dolly/branches{/branch}","tags_url":"https://api.github.com/repos/amco/dolly/tags","blobs_url":"https://api.github.com/repos/amco/dolly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amco/dolly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amco/dolly/git/refs{/sha}","trees_url":"https://api.github.com/repos/amco/dolly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amco/dolly/statuses/{sha}","languages_url":"https://api.github.com/repos/amco/dolly/languages","stargazers_url":"https://api.github.com/repos/amco/dolly/stargazers","contributors_url":"https://api.github.com/repos/amco/dolly/contributors","subscribers_url":"https://api.github.com/repos/amco/dolly/subscribers","subscription_url":"https://api.github.com/repos/amco/dolly/subscription","commits_url":"https://api.github.com/repos/amco/dolly/commits{/sha}","git_commits_url":"https://api.github.com/repos/amco/dolly/git/commits{/sha}","comments_url":"https://api.github.com/repos/amco/dolly/comments{/number}","issue_comment_url":"https://api.github.com/repos/amco/dolly/issues/comments{/number}","contents_url":"https://api.github.com/repos/amco/dolly/contents/{+path}","compare_url":"https://api.github.com/repos/amco/dolly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amco/dolly/merges","archive_url":"https://api.github.com/repos/amco/dolly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amco/dolly/downloads","issues_url":"https://api.github.com/repos/amco/dolly/issues{/number}","pulls_url":"https://api.github.com/repos/amco/dolly/pulls{/number}","milestones_url":"https://api.github.com/repos/amco/dolly/milestones{/number}","notifications_url":"https://api.github.com/repos/amco/dolly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amco/dolly/labels{/name}","releases_url":"https://api.github.com/repos/amco/dolly/releases{/id}","deployments_url":"https://api.github.com/repos/amco/dolly/deployments","created_at":"2013-10-11T21:54:52Z","updated_at":"2016-03-08T22:16:20Z","pushed_at":"2016-10-12T05:00:06Z","git_url":"git://github.com/amco/dolly.git","ssh_url":"git@github.com:amco/dolly.git","clone_url":"https://github.com/amco/dolly.git","svn_url":"https://github.com/amco/dolly","homepage":null,"size":311,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":25,"forks":2,"open_issues":25,"watchers":4,"default_branch":"1.0"}},"_links":{"self":{"href":"https://api.github.com/repos/amco/dolly/pulls/124"},"html":{"href":"https://github.com/amco/dolly/pull/124"},"issue":{"href":"https://api.github.com/repos/amco/dolly/issues/124"},"comments":{"href":"https://api.github.com/repos/amco/dolly/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/amco/dolly/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/amco/dolly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amco/dolly/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/amco/dolly/statuses/2bc602fcae6b8b4608b8e91d3512dbbaa0af525e"}}}}
{"actor":{"display_login":"neojin"}}