{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-firewall/issues/668","repository_url":"https://api.github.com/repos/puppetlabs/puppetlabs-firewall","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-firewall/issues/668/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-firewall/issues/668/comments","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-firewall/issues/668/events","html_url":"https://github.com/puppetlabs/puppetlabs-firewall/pull/668","id":195393578,"number":668,"title":"MODULES-1748 Handle negative physdev-is-bridged","user":{"login":"bmjen","id":5577705,"avatar_url":"https://avatars.githubusercontent.com/u/5577705?v=3","gravatar_id":"","url":"https://api.github.com/users/bmjen","html_url":"https://github.com/bmjen","followers_url":"https://api.github.com/users/bmjen/followers","following_url":"https://api.github.com/users/bmjen/following{/other_user}","gists_url":"https://api.github.com/users/bmjen/gists{/gist_id}","starred_url":"https://api.github.com/users/bmjen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmjen/subscriptions","organizations_url":"https://api.github.com/users/bmjen/orgs","repos_url":"https://api.github.com/users/bmjen/repos","events_url":"https://api.github.com/users/bmjen/events{/privacy}","received_events_url":"https://api.github.com/users/bmjen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-13T22:58:22Z","updated_at":"2016-12-13T22:58:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-firewall/pulls/668","html_url":"https://github.com/puppetlabs/puppetlabs-firewall/pull/668","diff_url":"https://github.com/puppetlabs/puppetlabs-firewall/pull/668.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-firewall/pull/668.patch"},"body":"With an iptables line like this:\r\n\r\n-A FORWARD -m physdev ! --physdev-is-bridged -j REJECT \\\r\n--reject-with icmp-host-prohibited\r\n\r\nYou'd get:\r\n\r\nParser error: physdev_is_bridged was meant to be a\r\nboolean but received value: REJECT.\r\n\r\n* The pre-cludge regex's were being over greedy and taking -j as\r\npart of the quoted value.\r\n* I allowed @known_booleans to also be \"!\" - perhaps this could\r\nbe done better tho.\r\n* I also added physdev_is_bridged to the rules that can be prefixed\r\nwith a \"!\".\r\n\r\nConflicts:\r\n\tspec/fixtures/iptables/conversion_hash.rb"},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-firewall/issues/comments/266889262","html_url":"https://github.com/puppetlabs/puppetlabs-firewall/pull/668#issuecomment-266889262","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-firewall/issues/668","id":266889262,"user":{"login":"bmjen","id":5577705,"avatar_url":"https://avatars.githubusercontent.com/u/5577705?v=3","gravatar_id":"","url":"https://api.github.com/users/bmjen","html_url":"https://github.com/bmjen","followers_url":"https://api.github.com/users/bmjen/followers","following_url":"https://api.github.com/users/bmjen/following{/other_user}","gists_url":"https://api.github.com/users/bmjen/gists{/gist_id}","starred_url":"https://api.github.com/users/bmjen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmjen/subscriptions","organizations_url":"https://api.github.com/users/bmjen/orgs","repos_url":"https://api.github.com/users/bmjen/repos","events_url":"https://api.github.com/users/bmjen/events{/privacy}","received_events_url":"https://api.github.com/users/bmjen/received_events","type":"User","site_admin":false},"created_at":"2016-12-13T22:58:41Z","updated_at":"2016-12-13T22:58:41Z","body":"Closes #618 "}}
{"actor":{"display_login":"bmjen"}}