{"action":"created","issue":{"url":"https://api.github.com/repos/nuttyartist/notes/issues/27","repository_url":"https://api.github.com/repos/nuttyartist/notes","labels_url":"https://api.github.com/repos/nuttyartist/notes/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/nuttyartist/notes/issues/27/comments","events_url":"https://api.github.com/repos/nuttyartist/notes/issues/27/events","html_url":"https://github.com/nuttyartist/notes/pull/27","id":141963072,"number":27,"title":"simplifying the app.","user":{"login":"theshadowx","id":976569,"avatar_url":"https://avatars.githubusercontent.com/u/976569?v=3","gravatar_id":"","url":"https://api.github.com/users/theshadowx","html_url":"https://github.com/theshadowx","followers_url":"https://api.github.com/users/theshadowx/followers","following_url":"https://api.github.com/users/theshadowx/following{/other_user}","gists_url":"https://api.github.com/users/theshadowx/gists{/gist_id}","starred_url":"https://api.github.com/users/theshadowx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theshadowx/subscriptions","organizations_url":"https://api.github.com/users/theshadowx/orgs","repos_url":"https://api.github.com/users/theshadowx/repos","events_url":"https://api.github.com/users/theshadowx/events{/privacy}","received_events_url":"https://api.github.com/users/theshadowx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/nuttyartist/notes/milestones/1","html_url":"https://github.com/nuttyartist/notes/milestones/Version%201.0.0","labels_url":"https://api.github.com/repos/nuttyartist/notes/milestones/1/labels","id":1474436,"number":1,"title":"Version 1.0.0","description":"","creator":{"login":"nuttyartist","id":16375940,"avatar_url":"https://avatars.githubusercontent.com/u/16375940?v=3","gravatar_id":"","url":"https://api.github.com/users/nuttyartist","html_url":"https://github.com/nuttyartist","followers_url":"https://api.github.com/users/nuttyartist/followers","following_url":"https://api.github.com/users/nuttyartist/following{/other_user}","gists_url":"https://api.github.com/users/nuttyartist/gists{/gist_id}","starred_url":"https://api.github.com/users/nuttyartist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuttyartist/subscriptions","organizations_url":"https://api.github.com/users/nuttyartist/orgs","repos_url":"https://api.github.com/users/nuttyartist/repos","events_url":"https://api.github.com/users/nuttyartist/events{/privacy}","received_events_url":"https://api.github.com/users/nuttyartist/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":4,"state":"open","created_at":"2015-12-25T23:12:57Z","updated_at":"2016-03-29T12:19:47Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2016-03-18T19:55:26Z","updated_at":"2016-03-29T13:08:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nuttyartist/notes/pulls/27","html_url":"https://github.com/nuttyartist/notes/pull/27","diff_url":"https://github.com/nuttyartist/notes/pull/27.diff","patch_url":"https://github.com/nuttyartist/notes/pull/27.patch"},"body":"The goal of these modifications is to make the app more efficient with minimum code and object/memory usage.\r\n\r\n--> NoteData has its own class\r\n     --> making members private\r\n     --> setters / getters\r\n     --> removing unnecessary layers\r\n     --> isolated class : handles its own events from inside\r\n\r\n--> Saving modification on text more efficiently\r\n      --> no saving after each character added/deleted in the text to the database\r\n      --> saving updated data locally\r\n      --> saving data to database when another note is clicked or text being  put in search or quitting the app\r\n     \r\n--> Resizing App from the edge (some minimal issues still there but works fine)\r\n--> Using Signal/slots instead of event filter\r\n--> Using C++ 11 features\r\n--> specifying a parent when creating an object so that no memory leak\r\n\r\nThis resolve #1, closes #7, closes #24 "},"comment":{"url":"https://api.github.com/repos/nuttyartist/notes/issues/comments/202883690","html_url":"https://github.com/nuttyartist/notes/pull/27#issuecomment-202883690","issue_url":"https://api.github.com/repos/nuttyartist/notes/issues/27","id":202883690,"user":{"login":"nuttyartist","id":16375940,"avatar_url":"https://avatars.githubusercontent.com/u/16375940?v=3","gravatar_id":"","url":"https://api.github.com/users/nuttyartist","html_url":"https://github.com/nuttyartist","followers_url":"https://api.github.com/users/nuttyartist/followers","following_url":"https://api.github.com/users/nuttyartist/following{/other_user}","gists_url":"https://api.github.com/users/nuttyartist/gists{/gist_id}","starred_url":"https://api.github.com/users/nuttyartist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuttyartist/subscriptions","organizations_url":"https://api.github.com/users/nuttyartist/orgs","repos_url":"https://api.github.com/users/nuttyartist/repos","events_url":"https://api.github.com/users/nuttyartist/events{/privacy}","received_events_url":"https://api.github.com/users/nuttyartist/received_events","type":"User","site_admin":false},"created_at":"2016-03-29T13:08:46Z","updated_at":"2016-03-29T13:08:46Z","body":"Great job.\r\n\r\nMoving the splitter is still very slow on a large number of notes, but I'm going to create a different issue for that, and let this pull request be merged to benefit the master with the awesome changes you've made.\r\n\r\nOnly one thing to resolve before I merge this: the modification animation should make the note 'climb' to the top, so it gives the user a sense of what's happening. So when the note 'comes' to the top, it should be created and placed from the bottom-to-the-top - sliding up from the bottom to the top (And not the other way like the current approach).\r\n\r\nWe are getting closer and closer to version 1.0.0. When we will get there, we are going to have a very polished app. We want people to have a place to write down their thoughts and express themselves in an easy and beautiful way. We achieve that by creating a simple yet powerful and elegant note-taking app. Upon that mantra, we gonna build the next versions of Notes with features that will continue to reflect our views about making just that."}}