{"action":"created","comment":{"url":"https://api.github.com/repos/appnexus/pyrobuf/pulls/comments/56695607","id":56695607,"diff_hunk":"@@ -103,4 +103,6 @@ def _pre_install(command):\n     long_description=open(os.path.join(HERE, 'README.md')).read(),\n     url='https://github.com/appnexus/pyrobuf',\n     author='AppNexus',\n+    setup_requires=['jinja2', 'cython'],\n+    install_requires=['jinja2', 'cython'],","path":"setup.py","position":30,"original_position":30,"commit_id":"12bc546642c6155c0fe4d0a70e0297e4d0a557a2","original_commit_id":"12bc546642c6155c0fe4d0a70e0297e4d0a557a2","user":{"login":"tburmeister","id":1802314,"avatar_url":"https://avatars.githubusercontent.com/u/1802314?v=3","gravatar_id":"","url":"https://api.github.com/users/tburmeister","html_url":"https://github.com/tburmeister","followers_url":"https://api.github.com/users/tburmeister/followers","following_url":"https://api.github.com/users/tburmeister/following{/other_user}","gists_url":"https://api.github.com/users/tburmeister/gists{/gist_id}","starred_url":"https://api.github.com/users/tburmeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tburmeister/subscriptions","organizations_url":"https://api.github.com/users/tburmeister/orgs","repos_url":"https://api.github.com/users/tburmeister/repos","events_url":"https://api.github.com/users/tburmeister/events{/privacy}","received_events_url":"https://api.github.com/users/tburmeister/received_events","type":"User","site_admin":false},"body":"Should change `'cython'` to `'cython>=0.23'`; IIRC, we are using some features of Cython that aren't present in earlier versions.","created_at":"2016-03-18T17:47:54Z","updated_at":"2016-03-18T17:47:54Z","html_url":"https://github.com/appnexus/pyrobuf/pull/21#discussion_r56695607","pull_request_url":"https://api.github.com/repos/appnexus/pyrobuf/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/appnexus/pyrobuf/pulls/comments/56695607"},"html":{"href":"https://github.com/appnexus/pyrobuf/pull/21#discussion_r56695607"},"pull_request":{"href":"https://api.github.com/repos/appnexus/pyrobuf/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/appnexus/pyrobuf/pulls/21","id":63366009,"html_url":"https://github.com/appnexus/pyrobuf/pull/21","diff_url":"https://github.com/appnexus/pyrobuf/pull/21.diff","patch_url":"https://github.com/appnexus/pyrobuf/pull/21.patch","issue_url":"https://api.github.com/repos/appnexus/pyrobuf/issues/21","number":21,"state":"open","locked":false,"title":"Use setup_requires for Jinja2 and Cython.","user":{"login":"Tinche","id":1909233,"avatar_url":"https://avatars.githubusercontent.com/u/1909233?v=3","gravatar_id":"","url":"https://api.github.com/users/Tinche","html_url":"https://github.com/Tinche","followers_url":"https://api.github.com/users/Tinche/followers","following_url":"https://api.github.com/users/Tinche/following{/other_user}","gists_url":"https://api.github.com/users/Tinche/gists{/gist_id}","starred_url":"https://api.github.com/users/Tinche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tinche/subscriptions","organizations_url":"https://api.github.com/users/Tinche/orgs","repos_url":"https://api.github.com/users/Tinche/repos","events_url":"https://api.github.com/users/Tinche/events{/privacy}","received_events_url":"https://api.github.com/users/Tinche/received_events","type":"User","site_admin":false},"body":"This should make it easier to install Pyrobuf. Currently, `pip install pyrobuf` will fail without the jinja2 and cython packages, with this change it seems to be succeeding for me in a clean virtualenv.\r\n\r\nJinja2 and Cython will be fetched automatically by setuptools; there are still gotchas with this approach (setuptools will use easy_install, which uses a different config file than pip, so people with private repos will need to be aware) but I think it's the best that can be done for now.","created_at":"2016-03-18T12:17:07Z","updated_at":"2016-03-18T17:47:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"404edaff2da7f98f7288eef60c015f599635bd20","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/appnexus/pyrobuf/pulls/21/commits","review_comments_url":"https://api.github.com/repos/appnexus/pyrobuf/pulls/21/comments","review_comment_url":"https://api.github.com/repos/appnexus/pyrobuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appnexus/pyrobuf/issues/21/comments","statuses_url":"https://api.github.com/repos/appnexus/pyrobuf/statuses/12bc546642c6155c0fe4d0a70e0297e4d0a557a2","head":{"label":"Tinche:master","ref":"master","sha":"12bc546642c6155c0fe4d0a70e0297e4d0a557a2","user":{"login":"Tinche","id":1909233,"avatar_url":"https://avatars.githubusercontent.com/u/1909233?v=3","gravatar_id":"","url":"https://api.github.com/users/Tinche","html_url":"https://github.com/Tinche","followers_url":"https://api.github.com/users/Tinche/followers","following_url":"https://api.github.com/users/Tinche/following{/other_user}","gists_url":"https://api.github.com/users/Tinche/gists{/gist_id}","starred_url":"https://api.github.com/users/Tinche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tinche/subscriptions","organizations_url":"https://api.github.com/users/Tinche/orgs","repos_url":"https://api.github.com/users/Tinche/repos","events_url":"https://api.github.com/users/Tinche/events{/privacy}","received_events_url":"https://api.github.com/users/Tinche/received_events","type":"User","site_admin":false},"repo":{"id":54198637,"name":"pyrobuf","full_name":"Tinche/pyrobuf","owner":{"login":"Tinche","id":1909233,"avatar_url":"https://avatars.githubusercontent.com/u/1909233?v=3","gravatar_id":"","url":"https://api.github.com/users/Tinche","html_url":"https://github.com/Tinche","followers_url":"https://api.github.com/users/Tinche/followers","following_url":"https://api.github.com/users/Tinche/following{/other_user}","gists_url":"https://api.github.com/users/Tinche/gists{/gist_id}","starred_url":"https://api.github.com/users/Tinche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tinche/subscriptions","organizations_url":"https://api.github.com/users/Tinche/orgs","repos_url":"https://api.github.com/users/Tinche/repos","events_url":"https://api.github.com/users/Tinche/events{/privacy}","received_events_url":"https://api.github.com/users/Tinche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tinche/pyrobuf","description":"A Cython alternative to Google's Python Protobuf library","fork":true,"url":"https://api.github.com/repos/Tinche/pyrobuf","forks_url":"https://api.github.com/repos/Tinche/pyrobuf/forks","keys_url":"https://api.github.com/repos/Tinche/pyrobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tinche/pyrobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tinche/pyrobuf/teams","hooks_url":"https://api.github.com/repos/Tinche/pyrobuf/hooks","issue_events_url":"https://api.github.com/repos/Tinche/pyrobuf/issues/events{/number}","events_url":"https://api.github.com/repos/Tinche/pyrobuf/events","assignees_url":"https://api.github.com/repos/Tinche/pyrobuf/assignees{/user}","branches_url":"https://api.github.com/repos/Tinche/pyrobuf/branches{/branch}","tags_url":"https://api.github.com/repos/Tinche/pyrobuf/tags","blobs_url":"https://api.github.com/repos/Tinche/pyrobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tinche/pyrobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tinche/pyrobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tinche/pyrobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tinche/pyrobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/Tinche/pyrobuf/languages","stargazers_url":"https://api.github.com/repos/Tinche/pyrobuf/stargazers","contributors_url":"https://api.github.com/repos/Tinche/pyrobuf/contributors","subscribers_url":"https://api.github.com/repos/Tinche/pyrobuf/subscribers","subscription_url":"https://api.github.com/repos/Tinche/pyrobuf/subscription","commits_url":"https://api.github.com/repos/Tinche/pyrobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tinche/pyrobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tinche/pyrobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tinche/pyrobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tinche/pyrobuf/contents/{+path}","compare_url":"https://api.github.com/repos/Tinche/pyrobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tinche/pyrobuf/merges","archive_url":"https://api.github.com/repos/Tinche/pyrobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tinche/pyrobuf/downloads","issues_url":"https://api.github.com/repos/Tinche/pyrobuf/issues{/number}","pulls_url":"https://api.github.com/repos/Tinche/pyrobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/Tinche/pyrobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/Tinche/pyrobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tinche/pyrobuf/labels{/name}","releases_url":"https://api.github.com/repos/Tinche/pyrobuf/releases{/id}","deployments_url":"https://api.github.com/repos/Tinche/pyrobuf/deployments","created_at":"2016-03-18T12:12:27Z","updated_at":"2016-03-18T12:12:28Z","pushed_at":"2016-03-18T12:25:29Z","git_url":"git://github.com/Tinche/pyrobuf.git","ssh_url":"git@github.com:Tinche/pyrobuf.git","clone_url":"https://github.com/Tinche/pyrobuf.git","svn_url":"https://github.com/Tinche/pyrobuf","homepage":"","size":109,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appnexus:master","ref":"master","sha":"4f07718d3d23986efad2501b797e74332d189abc","user":{"login":"appnexus","id":1664176,"avatar_url":"https://avatars.githubusercontent.com/u/1664176?v=3","gravatar_id":"","url":"https://api.github.com/users/appnexus","html_url":"https://github.com/appnexus","followers_url":"https://api.github.com/users/appnexus/followers","following_url":"https://api.github.com/users/appnexus/following{/other_user}","gists_url":"https://api.github.com/users/appnexus/gists{/gist_id}","starred_url":"https://api.github.com/users/appnexus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appnexus/subscriptions","organizations_url":"https://api.github.com/users/appnexus/orgs","repos_url":"https://api.github.com/users/appnexus/repos","events_url":"https://api.github.com/users/appnexus/events{/privacy}","received_events_url":"https://api.github.com/users/appnexus/received_events","type":"Organization","site_admin":false},"repo":{"id":48182096,"name":"pyrobuf","full_name":"appnexus/pyrobuf","owner":{"login":"appnexus","id":1664176,"avatar_url":"https://avatars.githubusercontent.com/u/1664176?v=3","gravatar_id":"","url":"https://api.github.com/users/appnexus","html_url":"https://github.com/appnexus","followers_url":"https://api.github.com/users/appnexus/followers","following_url":"https://api.github.com/users/appnexus/following{/other_user}","gists_url":"https://api.github.com/users/appnexus/gists{/gist_id}","starred_url":"https://api.github.com/users/appnexus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appnexus/subscriptions","organizations_url":"https://api.github.com/users/appnexus/orgs","repos_url":"https://api.github.com/users/appnexus/repos","events_url":"https://api.github.com/users/appnexus/events{/privacy}","received_events_url":"https://api.github.com/users/appnexus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appnexus/pyrobuf","description":"A Cython alternative to Google's Python Protobuf library","fork":false,"url":"https://api.github.com/repos/appnexus/pyrobuf","forks_url":"https://api.github.com/repos/appnexus/pyrobuf/forks","keys_url":"https://api.github.com/repos/appnexus/pyrobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appnexus/pyrobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appnexus/pyrobuf/teams","hooks_url":"https://api.github.com/repos/appnexus/pyrobuf/hooks","issue_events_url":"https://api.github.com/repos/appnexus/pyrobuf/issues/events{/number}","events_url":"https://api.github.com/repos/appnexus/pyrobuf/events","assignees_url":"https://api.github.com/repos/appnexus/pyrobuf/assignees{/user}","branches_url":"https://api.github.com/repos/appnexus/pyrobuf/branches{/branch}","tags_url":"https://api.github.com/repos/appnexus/pyrobuf/tags","blobs_url":"https://api.github.com/repos/appnexus/pyrobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appnexus/pyrobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appnexus/pyrobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/appnexus/pyrobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appnexus/pyrobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/appnexus/pyrobuf/languages","stargazers_url":"https://api.github.com/repos/appnexus/pyrobuf/stargazers","contributors_url":"https://api.github.com/repos/appnexus/pyrobuf/contributors","subscribers_url":"https://api.github.com/repos/appnexus/pyrobuf/subscribers","subscription_url":"https://api.github.com/repos/appnexus/pyrobuf/subscription","commits_url":"https://api.github.com/repos/appnexus/pyrobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/appnexus/pyrobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/appnexus/pyrobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/appnexus/pyrobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/appnexus/pyrobuf/contents/{+path}","compare_url":"https://api.github.com/repos/appnexus/pyrobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appnexus/pyrobuf/merges","archive_url":"https://api.github.com/repos/appnexus/pyrobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appnexus/pyrobuf/downloads","issues_url":"https://api.github.com/repos/appnexus/pyrobuf/issues{/number}","pulls_url":"https://api.github.com/repos/appnexus/pyrobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/appnexus/pyrobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/appnexus/pyrobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appnexus/pyrobuf/labels{/name}","releases_url":"https://api.github.com/repos/appnexus/pyrobuf/releases{/id}","deployments_url":"https://api.github.com/repos/appnexus/pyrobuf/deployments","created_at":"2015-12-17T15:24:33Z","updated_at":"2016-03-17T07:49:36Z","pushed_at":"2016-03-18T12:25:30Z","git_url":"git://github.com/appnexus/pyrobuf.git","ssh_url":"git@github.com:appnexus/pyrobuf.git","clone_url":"https://github.com/appnexus/pyrobuf.git","svn_url":"https://github.com/appnexus/pyrobuf","homepage":"","size":101,"stargazers_count":277,"watchers_count":277,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":9,"forks":26,"open_issues":9,"watchers":277,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appnexus/pyrobuf/pulls/21"},"html":{"href":"https://github.com/appnexus/pyrobuf/pull/21"},"issue":{"href":"https://api.github.com/repos/appnexus/pyrobuf/issues/21"},"comments":{"href":"https://api.github.com/repos/appnexus/pyrobuf/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/appnexus/pyrobuf/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/appnexus/pyrobuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appnexus/pyrobuf/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/appnexus/pyrobuf/statuses/12bc546642c6155c0fe4d0a70e0297e4d0a557a2"}}}}