{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/12923","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/12923/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/12923/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/12923/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/12923","id":191777283,"number":12923,"title":"[types-2.0] D3 Batch 2 with strictNullChecks, JSDoc and Fixes","user":{"login":"tomwanzek","id":16323903,"avatar_url":"https://avatars.githubusercontent.com/u/16323903?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwanzek","html_url":"https://github.com/tomwanzek","followers_url":"https://api.github.com/users/tomwanzek/followers","following_url":"https://api.github.com/users/tomwanzek/following{/other_user}","gists_url":"https://api.github.com/users/tomwanzek/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwanzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwanzek/subscriptions","organizations_url":"https://api.github.com/users/tomwanzek/orgs","repos_url":"https://api.github.com/users/tomwanzek/repos","events_url":"https://api.github.com/users/tomwanzek/events{/privacy}","received_events_url":"https://api.github.com/users/tomwanzek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-26T00:13:43Z","updated_at":"2016-11-28T17:03:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/12923","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/12923","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/12923.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/12923.patch"},"body":"Please fill in this template.\r\n\r\n- [x] Prefer to make your PR against the `types-2.0` branch.\r\n- [x] Test the change in your own code.\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped#common-mistakes).\r\n- [x] Run `npm run lint -- package-name` if a `tslint.json` is present.\r\n\r\nIf adding a new definition:\r\n- [ ] The package does not provide its own types, and you can not add them.\r\n- [ ] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.\r\n- [ ] Run `tsc` without errors.\r\n- [ ] Include the required [files](https://github.com/DefinitelyTyped/DefinitelyTyped#create-a-new-package) and header. Base these on the README, *not* on an existing project.\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>\r\n- [x] Increase the version number in the header if appropriate.\r\n\r\nRelated to issues: #11365 and #11366 \r\n\r\nChanges by Module included in this batch:\r\n* **(d3-path) [Chore]** Added complete JSDoc comments\r\n* **(d3-path) [Enhancement]** Validated and activated for use with `strictNullChecks`\r\n* **(d3-chord) [BREAKING FIX]** Added additional interfaces `Ribbon` and `RibbonSubgroup` to reflect the interfaces actually assumed by default by `RibbonGenerator`. While the API documentation refers to passing in a Chord object when invoking the `RibbonGenerator` by default, this actually means the default radius accessor returns undefined, which is then coerced to `NaN`. To avoid this \"silent\" fail, `Ribbon` and `RibbonSubgroup` are now used as the datum types returned by the default `ribbon()` factory without explicit generics. This is a purposely accepted breaking change, as it means that passing in a Chord object will now fail. The correct way, will be to use the generics of the `ribbon<...>()` factory to cast the datum type to work with Chord. This should serve as a mental cue to  ensure the accessors are customized accordingly. E.g. by setting a constant radius.\r\n* **(d3-chord) [Chore]**: Added JSDoc comments\r\n* **(d3-chord) [Enhancement]:** Validated, updated and activated for use with `strictNullChecks`. Note,in particular the updated signatures for invoking the `RibbonGenerator`. These are now overloaded with one returning `void` (canvas context), and the other returning `string | null`, where the rendering context is `null`. Note that the API suggests a string is returned in this case, however, it may actually return `null` as well as per source code. It is at the developers discretion to ensure return value expectations correspond to rendering context.\r\n* **(d3-chord) [Chore]** Updated tests and bumped patch version number to indicate which version was last fully reviewed."},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/263328851","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/12923#issuecomment-263328851","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/12923","id":263328851,"user":{"login":"gustavderdrache","id":194893,"avatar_url":"https://avatars.githubusercontent.com/u/194893?v=3","gravatar_id":"","url":"https://api.github.com/users/gustavderdrache","html_url":"https://github.com/gustavderdrache","followers_url":"https://api.github.com/users/gustavderdrache/followers","following_url":"https://api.github.com/users/gustavderdrache/following{/other_user}","gists_url":"https://api.github.com/users/gustavderdrache/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavderdrache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavderdrache/subscriptions","organizations_url":"https://api.github.com/users/gustavderdrache/orgs","repos_url":"https://api.github.com/users/gustavderdrache/repos","events_url":"https://api.github.com/users/gustavderdrache/events{/privacy}","received_events_url":"https://api.github.com/users/gustavderdrache/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T17:03:36Z","updated_at":"2016-11-28T17:03:36Z","body":"@tomwanzek I'm going to review these this evening. So sorry I've been out of reach, but I was busy last week what with the food coma holiday season here in the states ;)"}}
{"actor":{"display_login":"gustavderdrache"}}