{"action":"created","issue":{"url":"https://api.github.com/repos/snapcore/snapd/issues/2268","repository_url":"https://api.github.com/repos/snapcore/snapd","labels_url":"https://api.github.com/repos/snapcore/snapd/issues/2268/labels{/name}","comments_url":"https://api.github.com/repos/snapcore/snapd/issues/2268/comments","events_url":"https://api.github.com/repos/snapcore/snapd/issues/2268/events","html_url":"https://github.com/snapcore/snapd/pull/2268","id":187714452,"number":2268,"title":"many: merge snap-confine into snapd","user":{"login":"zyga","id":784262,"avatar_url":"https://avatars.githubusercontent.com/u/784262?v=3","gravatar_id":"","url":"https://api.github.com/users/zyga","html_url":"https://github.com/zyga","followers_url":"https://api.github.com/users/zyga/followers","following_url":"https://api.github.com/users/zyga/following{/other_user}","gists_url":"https://api.github.com/users/zyga/gists{/gist_id}","starred_url":"https://api.github.com/users/zyga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zyga/subscriptions","organizations_url":"https://api.github.com/users/zyga/orgs","repos_url":"https://api.github.com/users/zyga/repos","events_url":"https://api.github.com/users/zyga/events{/privacy}","received_events_url":"https://api.github.com/users/zyga/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-11-07T13:41:45Z","updated_at":"2016-11-29T17:33:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/2268","html_url":"https://github.com/snapcore/snapd/pull/2268","diff_url":"https://github.com/snapcore/snapd/pull/2268.diff","patch_url":"https://github.com/snapcore/snapd/pull/2268.patch"},"body":"This branch commences the process of merging snap-confine into snapd.\r\n\r\nSubsequent branches will make the code more in line with snapd. This includes support for merged packaging, for spread tests and for nice layout of cmd/* commands."},"comment":{"url":"https://api.github.com/repos/snapcore/snapd/issues/comments/263639804","html_url":"https://github.com/snapcore/snapd/pull/2268#issuecomment-263639804","issue_url":"https://api.github.com/repos/snapcore/snapd/issues/2268","id":263639804,"user":{"login":"jdstrand","id":1663079,"avatar_url":"https://avatars.githubusercontent.com/u/1663079?v=3","gravatar_id":"","url":"https://api.github.com/users/jdstrand","html_url":"https://github.com/jdstrand","followers_url":"https://api.github.com/users/jdstrand/followers","following_url":"https://api.github.com/users/jdstrand/following{/other_user}","gists_url":"https://api.github.com/users/jdstrand/gists{/gist_id}","starred_url":"https://api.github.com/users/jdstrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdstrand/subscriptions","organizations_url":"https://api.github.com/users/jdstrand/orgs","repos_url":"https://api.github.com/users/jdstrand/repos","events_url":"https://api.github.com/users/jdstrand/events{/privacy}","received_events_url":"https://api.github.com/users/jdstrand/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T17:33:00Z","updated_at":"2016-11-29T17:33:00Z","body":"\"@tyhicks this process can be maintained, e.g. by using labels for security reviews (I think more than just snap confine could use security reviews actually).\"\r\n\r\n@zyga, @tyhicks and I discussed this a bit today. My concern is that snap-confine as a separate project conveyed to developers that it was 'special' in some way (indeed, it is a setuid executable) and Tyler is right that it is easier to track changes. As Zygmunt said though, it should be possible to denote snap-confine after merging with snapd as 'special' and whatever process we do for snap-confine, we should extend to other parts of the tree (eg, interfaces/* which today is largely handled with people knowing they should ping me on IRC and/or in the PR).\r\n\r\nI'm not familiar enough with github to suggest a technical solution for this. In my mind, automatically adding a label to a PR (eg, via a bot or otherwise) that touches snap-confine (or interfaces/*) may be enough of a cue to snappy developers to not commit without pinging the security team. Can people subscribe to labels?\r\n\r\n+0 from me on this PR but if it goes forward, please lets define a process as @zyga suggested."}}
{"actor":{"display_login":"jdstrand"}}