{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/membership-frontend/pulls/comments/53299053","id":53299053,"diff_hunk":"@@ -69,10 +69,26 @@\n }\n // english heritage promo\n .hero-banner--eng-heritage {\n-    background: url(https://media.guim.co.uk/88f98c8706beafeae6dc32886ccd71da60e6e7d7/0_0_5212_3129/500.jpg) bottom;\n-    background-size: cover;\n-    @include mq(desktop) {\n-        background-image: url(https://media.guim.co.uk/88f98c8706beafeae6dc32886ccd71da60e6e7d7/0_0_5212_3129/1000.jpg);\n+\n+    overflow: hidden; // added for pseudo-element\n+    position: relative; // added for pseudo-element\n+\n+    // Fixed-position background image thanks to: http://fourkitchens.com/blog/article/fix-scrolling-performance-css-will-change-property\n+    &::before {\n+        content: ' ';\n+        position: fixed; // instead of background-attachment\n+        width: 100%;\n+        height: 100%;\n+        top: 0;\n+        left: 0;\n+        background-image: url(https://media.guim.co.uk/88f98c8706beafeae6dc32886ccd71da60e6e7d7/0_0_5212_3129/500.jpg);\n+        background-position: bottom;\n+        background-size: cover;\n+        @include mq(desktop) {","path":"frontend/assets/stylesheets/components/_hero-banner.scss","position":23,"original_position":23,"commit_id":"aabdc009c11f3ab92adf2edfa94353f8d85ddb25","original_commit_id":"aabdc009c11f3ab92adf2edfa94353f8d85ddb25","user":{"login":"paulbrown1982","id":1515970,"avatar_url":"https://avatars.githubusercontent.com/u/1515970?v=3","gravatar_id":"","url":"https://api.github.com/users/paulbrown1982","html_url":"https://github.com/paulbrown1982","followers_url":"https://api.github.com/users/paulbrown1982/followers","following_url":"https://api.github.com/users/paulbrown1982/following{/other_user}","gists_url":"https://api.github.com/users/paulbrown1982/gists{/gist_id}","starred_url":"https://api.github.com/users/paulbrown1982/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulbrown1982/subscriptions","organizations_url":"https://api.github.com/users/paulbrown1982/orgs","repos_url":"https://api.github.com/users/paulbrown1982/repos","events_url":"https://api.github.com/users/paulbrown1982/events{/privacy}","received_events_url":"https://api.github.com/users/paulbrown1982/received_events","type":"User","site_admin":false},"body":"Mixins should ideally go at end of class.","created_at":"2016-02-18T10:57:56Z","updated_at":"2016-02-18T10:57:56Z","html_url":"https://github.com/guardian/membership-frontend/pull/995#discussion_r53299053","pull_request_url":"https://api.github.com/repos/guardian/membership-frontend/pulls/995","_links":{"self":{"href":"https://api.github.com/repos/guardian/membership-frontend/pulls/comments/53299053"},"html":{"href":"https://github.com/guardian/membership-frontend/pull/995#discussion_r53299053"},"pull_request":{"href":"https://api.github.com/repos/guardian/membership-frontend/pulls/995"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/membership-frontend/pulls/995","id":59678660,"html_url":"https://github.com/guardian/membership-frontend/pull/995","diff_url":"https://github.com/guardian/membership-frontend/pull/995.diff","patch_url":"https://github.com/guardian/membership-frontend/pull/995.patch","issue_url":"https://api.github.com/repos/guardian/membership-frontend/issues/995","number":995,"state":"open","locked":false,"title":"Test new hero background scroll","user":{"login":"AWare","id":2670496,"avatar_url":"https://avatars.githubusercontent.com/u/2670496?v=3","gravatar_id":"","url":"https://api.github.com/users/AWare","html_url":"https://github.com/AWare","followers_url":"https://api.github.com/users/AWare/followers","following_url":"https://api.github.com/users/AWare/following{/other_user}","gists_url":"https://api.github.com/users/AWare/gists{/gist_id}","starred_url":"https://api.github.com/users/AWare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AWare/subscriptions","organizations_url":"https://api.github.com/users/AWare/orgs","repos_url":"https://api.github.com/users/AWare/repos","events_url":"https://api.github.com/users/AWare/events{/privacy}","received_events_url":"https://api.github.com/users/AWare/received_events","type":"User","site_admin":false},"body":"For merging after: https://github.com/guardian/membership-frontend/pull/994\r\n\r\nTest new method of setting position fixed backgrounds on heros- while we still have the EH landing page behind auth.  @joelochlann ","created_at":"2016-02-17T17:26:37Z","updated_at":"2016-02-18T10:57:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42420e0a2e3b4d5e4e023ceea275ceaf01d59865","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/membership-frontend/pulls/995/commits","review_comments_url":"https://api.github.com/repos/guardian/membership-frontend/pulls/995/comments","review_comment_url":"https://api.github.com/repos/guardian/membership-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/membership-frontend/issues/995/comments","statuses_url":"https://api.github.com/repos/guardian/membership-frontend/statuses/aabdc009c11f3ab92adf2edfa94353f8d85ddb25","head":{"label":"guardian:test-new-hero-background-scroll","ref":"test-new-hero-background-scroll","sha":"aabdc009c11f3ab92adf2edfa94353f8d85ddb25","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":28401521,"name":"membership-frontend","full_name":"guardian/membership-frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/membership-frontend","description":"Bringing the Guardian to life through live events and meet-ups","fork":false,"url":"https://api.github.com/repos/guardian/membership-frontend","forks_url":"https://api.github.com/repos/guardian/membership-frontend/forks","keys_url":"https://api.github.com/repos/guardian/membership-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/membership-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/membership-frontend/teams","hooks_url":"https://api.github.com/repos/guardian/membership-frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/membership-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/membership-frontend/events","assignees_url":"https://api.github.com/repos/guardian/membership-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/membership-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/membership-frontend/tags","blobs_url":"https://api.github.com/repos/guardian/membership-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/membership-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/membership-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/membership-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/membership-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/membership-frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/membership-frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/membership-frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/membership-frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/membership-frontend/subscription","commits_url":"https://api.github.com/repos/guardian/membership-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/membership-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/membership-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/membership-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/membership-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/membership-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/membership-frontend/merges","archive_url":"https://api.github.com/repos/guardian/membership-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/membership-frontend/downloads","issues_url":"https://api.github.com/repos/guardian/membership-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/membership-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/membership-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/membership-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/membership-frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/membership-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/membership-frontend/deployments","created_at":"2014-12-23T14:14:38Z","updated_at":"2016-02-01T04:31:23Z","pushed_at":"2016-02-18T10:55:27Z","git_url":"git://github.com/guardian/membership-frontend.git","ssh_url":"git@github.com:guardian/membership-frontend.git","clone_url":"https://github.com/guardian/membership-frontend.git","svn_url":"https://github.com/guardian/membership-frontend","homepage":"https://membership.theguardian.com/","size":44837,"stargazers_count":21,"watchers_count":21,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":4,"forks":12,"open_issues":4,"watchers":21,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"c3d105bf946d827ccf040c9f697fcc08663f6c1b","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":28401521,"name":"membership-frontend","full_name":"guardian/membership-frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/membership-frontend","description":"Bringing the Guardian to life through live events and meet-ups","fork":false,"url":"https://api.github.com/repos/guardian/membership-frontend","forks_url":"https://api.github.com/repos/guardian/membership-frontend/forks","keys_url":"https://api.github.com/repos/guardian/membership-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/membership-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/membership-frontend/teams","hooks_url":"https://api.github.com/repos/guardian/membership-frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/membership-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/membership-frontend/events","assignees_url":"https://api.github.com/repos/guardian/membership-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/membership-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/membership-frontend/tags","blobs_url":"https://api.github.com/repos/guardian/membership-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/membership-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/membership-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/membership-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/membership-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/membership-frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/membership-frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/membership-frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/membership-frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/membership-frontend/subscription","commits_url":"https://api.github.com/repos/guardian/membership-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/membership-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/membership-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/membership-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/membership-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/membership-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/membership-frontend/merges","archive_url":"https://api.github.com/repos/guardian/membership-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/membership-frontend/downloads","issues_url":"https://api.github.com/repos/guardian/membership-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/membership-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/membership-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/membership-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/membership-frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/membership-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/membership-frontend/deployments","created_at":"2014-12-23T14:14:38Z","updated_at":"2016-02-01T04:31:23Z","pushed_at":"2016-02-18T10:55:27Z","git_url":"git://github.com/guardian/membership-frontend.git","ssh_url":"git@github.com:guardian/membership-frontend.git","clone_url":"https://github.com/guardian/membership-frontend.git","svn_url":"https://github.com/guardian/membership-frontend","homepage":"https://membership.theguardian.com/","size":44837,"stargazers_count":21,"watchers_count":21,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":4,"forks":12,"open_issues":4,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/membership-frontend/pulls/995"},"html":{"href":"https://github.com/guardian/membership-frontend/pull/995"},"issue":{"href":"https://api.github.com/repos/guardian/membership-frontend/issues/995"},"comments":{"href":"https://api.github.com/repos/guardian/membership-frontend/issues/995/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/membership-frontend/pulls/995/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/membership-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/membership-frontend/pulls/995/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/membership-frontend/statuses/aabdc009c11f3ab92adf2edfa94353f8d85ddb25"}}}}