{"action":"created","comment":{"url":"https://api.github.com/repos/briansmith/ring/pulls/comments/93371443","pull_request_review_id":13896830,"id":93371443,"diff_hunk":"@@ -52,20 +54,30 @@ fn aes_gcm_seal(ctx: &[u64; aead::KEY_CTX_BUF_ELEMS],\n                 -> Result<(), error::Unspecified> {\n     let ctx = polyfill::slice::u64_as_u8(ctx);\n     bssl::map_result(unsafe {\n-        GFp_aes_gcm_seal(ctx.as_ptr(), in_out.as_mut_ptr(), in_out.len(), tag,\n-                         nonce, ad.as_ptr(), ad.len())\n+        GFp_aes_gcm_seal(ctx.as_ptr(),\n+                         in_out.as_mut_ptr(),\n+                         in_out.len(),\n+                         tag,\n+                         nonce,\n+                         ad.as_ptr(),\n+                         ad.len())","path":"src/aead/aes_gcm.rs","position":23,"original_position":23,"commit_id":"37ee113d81fca118b6b05d387b6d96162d503e63","original_commit_id":"37ee113d81fca118b6b05d387b6d96162d503e63","user":{"login":"briansmith","id":16816,"avatar_url":"https://avatars.githubusercontent.com/u/16816?v=3","gravatar_id":"","url":"https://api.github.com/users/briansmith","html_url":"https://github.com/briansmith","followers_url":"https://api.github.com/users/briansmith/followers","following_url":"https://api.github.com/users/briansmith/following{/other_user}","gists_url":"https://api.github.com/users/briansmith/gists{/gist_id}","starred_url":"https://api.github.com/users/briansmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansmith/subscriptions","organizations_url":"https://api.github.com/users/briansmith/orgs","repos_url":"https://api.github.com/users/briansmith/repos","events_url":"https://api.github.com/users/briansmith/events{/privacy}","received_events_url":"https://api.github.com/users/briansmith/received_events","type":"User","site_admin":false},"body":"This is most of the reason why we don't use rustfmt already. We need a formatting tool that it can format function calls in the compact format, and that generally optimizes for readability first and minimum number of lines second, like the Google clang-format style.\r\n\r\nAlternatively, we might be able to use the default rustfmt style after we've oxidized more of *ring* so that there aren't so many function calls that take a large number of arguments. But not yet.","created_at":"2016-12-21T04:04:22Z","updated_at":"2016-12-21T04:21:54Z","html_url":"https://github.com/briansmith/ring/pull/385#discussion_r93371443","pull_request_url":"https://api.github.com/repos/briansmith/ring/pulls/385","_links":{"self":{"href":"https://api.github.com/repos/briansmith/ring/pulls/comments/93371443"},"html":{"href":"https://github.com/briansmith/ring/pull/385#discussion_r93371443"},"pull_request":{"href":"https://api.github.com/repos/briansmith/ring/pulls/385"}}},"pull_request":{"url":"https://api.github.com/repos/briansmith/ring/pulls/385","id":98796616,"html_url":"https://github.com/briansmith/ring/pull/385","diff_url":"https://github.com/briansmith/ring/pull/385.diff","patch_url":"https://github.com/briansmith/ring/pull/385.patch","issue_url":"https://api.github.com/repos/briansmith/ring/issues/385","number":385,"state":"open","locked":false,"title":"Apply rustfmt.","user":{"login":"marshallpierce","id":575695,"avatar_url":"https://avatars.githubusercontent.com/u/575695?v=3","gravatar_id":"","url":"https://api.github.com/users/marshallpierce","html_url":"https://github.com/marshallpierce","followers_url":"https://api.github.com/users/marshallpierce/followers","following_url":"https://api.github.com/users/marshallpierce/following{/other_user}","gists_url":"https://api.github.com/users/marshallpierce/gists{/gist_id}","starred_url":"https://api.github.com/users/marshallpierce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marshallpierce/subscriptions","organizations_url":"https://api.github.com/users/marshallpierce/orgs","repos_url":"https://api.github.com/users/marshallpierce/repos","events_url":"https://api.github.com/users/marshallpierce/events{/privacy}","received_events_url":"https://api.github.com/users/marshallpierce/received_events","type":"User","site_admin":false},"body":"Various broken cases handled manually.\r\nAlso, add a Travis hook and a sample pre-commit hook.\r\n(Addresses #285)","created_at":"2016-12-20T17:59:07Z","updated_at":"2016-12-21T04:21:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88d48cfa7e3708d8ed98d4e3660629a527d3217b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/briansmith/ring/pulls/385/commits","review_comments_url":"https://api.github.com/repos/briansmith/ring/pulls/385/comments","review_comment_url":"https://api.github.com/repos/briansmith/ring/pulls/comments{/number}","comments_url":"https://api.github.com/repos/briansmith/ring/issues/385/comments","statuses_url":"https://api.github.com/repos/briansmith/ring/statuses/37ee113d81fca118b6b05d387b6d96162d503e63","head":{"label":"marshallpierce:rustfmt","ref":"rustfmt","sha":"37ee113d81fca118b6b05d387b6d96162d503e63","user":{"login":"marshallpierce","id":575695,"avatar_url":"https://avatars.githubusercontent.com/u/575695?v=3","gravatar_id":"","url":"https://api.github.com/users/marshallpierce","html_url":"https://github.com/marshallpierce","followers_url":"https://api.github.com/users/marshallpierce/followers","following_url":"https://api.github.com/users/marshallpierce/following{/other_user}","gists_url":"https://api.github.com/users/marshallpierce/gists{/gist_id}","starred_url":"https://api.github.com/users/marshallpierce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marshallpierce/subscriptions","organizations_url":"https://api.github.com/users/marshallpierce/orgs","repos_url":"https://api.github.com/users/marshallpierce/repos","events_url":"https://api.github.com/users/marshallpierce/events{/privacy}","received_events_url":"https://api.github.com/users/marshallpierce/received_events","type":"User","site_admin":false},"repo":{"id":75801076,"name":"ring","full_name":"marshallpierce/ring","owner":{"login":"marshallpierce","id":575695,"avatar_url":"https://avatars.githubusercontent.com/u/575695?v=3","gravatar_id":"","url":"https://api.github.com/users/marshallpierce","html_url":"https://github.com/marshallpierce","followers_url":"https://api.github.com/users/marshallpierce/followers","following_url":"https://api.github.com/users/marshallpierce/following{/other_user}","gists_url":"https://api.github.com/users/marshallpierce/gists{/gist_id}","starred_url":"https://api.github.com/users/marshallpierce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marshallpierce/subscriptions","organizations_url":"https://api.github.com/users/marshallpierce/orgs","repos_url":"https://api.github.com/users/marshallpierce/repos","events_url":"https://api.github.com/users/marshallpierce/events{/privacy}","received_events_url":"https://api.github.com/users/marshallpierce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marshallpierce/ring","description":"Safe, fast, small crypto using Rust","fork":true,"url":"https://api.github.com/repos/marshallpierce/ring","forks_url":"https://api.github.com/repos/marshallpierce/ring/forks","keys_url":"https://api.github.com/repos/marshallpierce/ring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marshallpierce/ring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marshallpierce/ring/teams","hooks_url":"https://api.github.com/repos/marshallpierce/ring/hooks","issue_events_url":"https://api.github.com/repos/marshallpierce/ring/issues/events{/number}","events_url":"https://api.github.com/repos/marshallpierce/ring/events","assignees_url":"https://api.github.com/repos/marshallpierce/ring/assignees{/user}","branches_url":"https://api.github.com/repos/marshallpierce/ring/branches{/branch}","tags_url":"https://api.github.com/repos/marshallpierce/ring/tags","blobs_url":"https://api.github.com/repos/marshallpierce/ring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marshallpierce/ring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marshallpierce/ring/git/refs{/sha}","trees_url":"https://api.github.com/repos/marshallpierce/ring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marshallpierce/ring/statuses/{sha}","languages_url":"https://api.github.com/repos/marshallpierce/ring/languages","stargazers_url":"https://api.github.com/repos/marshallpierce/ring/stargazers","contributors_url":"https://api.github.com/repos/marshallpierce/ring/contributors","subscribers_url":"https://api.github.com/repos/marshallpierce/ring/subscribers","subscription_url":"https://api.github.com/repos/marshallpierce/ring/subscription","commits_url":"https://api.github.com/repos/marshallpierce/ring/commits{/sha}","git_commits_url":"https://api.github.com/repos/marshallpierce/ring/git/commits{/sha}","comments_url":"https://api.github.com/repos/marshallpierce/ring/comments{/number}","issue_comment_url":"https://api.github.com/repos/marshallpierce/ring/issues/comments{/number}","contents_url":"https://api.github.com/repos/marshallpierce/ring/contents/{+path}","compare_url":"https://api.github.com/repos/marshallpierce/ring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marshallpierce/ring/merges","archive_url":"https://api.github.com/repos/marshallpierce/ring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marshallpierce/ring/downloads","issues_url":"https://api.github.com/repos/marshallpierce/ring/issues{/number}","pulls_url":"https://api.github.com/repos/marshallpierce/ring/pulls{/number}","milestones_url":"https://api.github.com/repos/marshallpierce/ring/milestones{/number}","notifications_url":"https://api.github.com/repos/marshallpierce/ring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marshallpierce/ring/labels{/name}","releases_url":"https://api.github.com/repos/marshallpierce/ring/releases{/id}","deployments_url":"https://api.github.com/repos/marshallpierce/ring/deployments","created_at":"2016-12-07T05:03:13Z","updated_at":"2016-12-07T05:03:15Z","pushed_at":"2016-12-20T18:12:29Z","git_url":"git://github.com/marshallpierce/ring.git","ssh_url":"git@github.com:marshallpierce/ring.git","clone_url":"https://github.com/marshallpierce/ring.git","svn_url":"https://github.com/marshallpierce/ring","homepage":"https://briansmith.org/rustdoc/ring/","size":25360,"stargazers_count":0,"watchers_count":0,"language":"Assembly","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"briansmith:master","ref":"master","sha":"53fd7f97b9f89ccc660748b60df30c7b4f7fcab7","user":{"login":"briansmith","id":16816,"avatar_url":"https://avatars.githubusercontent.com/u/16816?v=3","gravatar_id":"","url":"https://api.github.com/users/briansmith","html_url":"https://github.com/briansmith","followers_url":"https://api.github.com/users/briansmith/followers","following_url":"https://api.github.com/users/briansmith/following{/other_user}","gists_url":"https://api.github.com/users/briansmith/gists{/gist_id}","starred_url":"https://api.github.com/users/briansmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansmith/subscriptions","organizations_url":"https://api.github.com/users/briansmith/orgs","repos_url":"https://api.github.com/users/briansmith/repos","events_url":"https://api.github.com/users/briansmith/events{/privacy}","received_events_url":"https://api.github.com/users/briansmith/received_events","type":"User","site_admin":false},"repo":{"id":39527318,"name":"ring","full_name":"briansmith/ring","owner":{"login":"briansmith","id":16816,"avatar_url":"https://avatars.githubusercontent.com/u/16816?v=3","gravatar_id":"","url":"https://api.github.com/users/briansmith","html_url":"https://github.com/briansmith","followers_url":"https://api.github.com/users/briansmith/followers","following_url":"https://api.github.com/users/briansmith/following{/other_user}","gists_url":"https://api.github.com/users/briansmith/gists{/gist_id}","starred_url":"https://api.github.com/users/briansmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansmith/subscriptions","organizations_url":"https://api.github.com/users/briansmith/orgs","repos_url":"https://api.github.com/users/briansmith/repos","events_url":"https://api.github.com/users/briansmith/events{/privacy}","received_events_url":"https://api.github.com/users/briansmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/briansmith/ring","description":"Safe, fast, small crypto using Rust","fork":false,"url":"https://api.github.com/repos/briansmith/ring","forks_url":"https://api.github.com/repos/briansmith/ring/forks","keys_url":"https://api.github.com/repos/briansmith/ring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/briansmith/ring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/briansmith/ring/teams","hooks_url":"https://api.github.com/repos/briansmith/ring/hooks","issue_events_url":"https://api.github.com/repos/briansmith/ring/issues/events{/number}","events_url":"https://api.github.com/repos/briansmith/ring/events","assignees_url":"https://api.github.com/repos/briansmith/ring/assignees{/user}","branches_url":"https://api.github.com/repos/briansmith/ring/branches{/branch}","tags_url":"https://api.github.com/repos/briansmith/ring/tags","blobs_url":"https://api.github.com/repos/briansmith/ring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/briansmith/ring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/briansmith/ring/git/refs{/sha}","trees_url":"https://api.github.com/repos/briansmith/ring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/briansmith/ring/statuses/{sha}","languages_url":"https://api.github.com/repos/briansmith/ring/languages","stargazers_url":"https://api.github.com/repos/briansmith/ring/stargazers","contributors_url":"https://api.github.com/repos/briansmith/ring/contributors","subscribers_url":"https://api.github.com/repos/briansmith/ring/subscribers","subscription_url":"https://api.github.com/repos/briansmith/ring/subscription","commits_url":"https://api.github.com/repos/briansmith/ring/commits{/sha}","git_commits_url":"https://api.github.com/repos/briansmith/ring/git/commits{/sha}","comments_url":"https://api.github.com/repos/briansmith/ring/comments{/number}","issue_comment_url":"https://api.github.com/repos/briansmith/ring/issues/comments{/number}","contents_url":"https://api.github.com/repos/briansmith/ring/contents/{+path}","compare_url":"https://api.github.com/repos/briansmith/ring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/briansmith/ring/merges","archive_url":"https://api.github.com/repos/briansmith/ring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/briansmith/ring/downloads","issues_url":"https://api.github.com/repos/briansmith/ring/issues{/number}","pulls_url":"https://api.github.com/repos/briansmith/ring/pulls{/number}","milestones_url":"https://api.github.com/repos/briansmith/ring/milestones{/number}","notifications_url":"https://api.github.com/repos/briansmith/ring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/briansmith/ring/labels{/name}","releases_url":"https://api.github.com/repos/briansmith/ring/releases{/id}","deployments_url":"https://api.github.com/repos/briansmith/ring/deployments","created_at":"2015-07-22T19:57:40Z","updated_at":"2016-12-20T23:49:57Z","pushed_at":"2016-12-20T18:12:31Z","git_url":"git://github.com/briansmith/ring.git","ssh_url":"git@github.com:briansmith/ring.git","clone_url":"https://github.com/briansmith/ring.git","svn_url":"https://github.com/briansmith/ring","homepage":"https://briansmith.org/rustdoc/ring/","size":25137,"stargazers_count":390,"watchers_count":390,"language":"Assembly","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":171,"forks":55,"open_issues":171,"watchers":390,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/briansmith/ring/pulls/385"},"html":{"href":"https://github.com/briansmith/ring/pull/385"},"issue":{"href":"https://api.github.com/repos/briansmith/ring/issues/385"},"comments":{"href":"https://api.github.com/repos/briansmith/ring/issues/385/comments"},"review_comments":{"href":"https://api.github.com/repos/briansmith/ring/pulls/385/comments"},"review_comment":{"href":"https://api.github.com/repos/briansmith/ring/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/briansmith/ring/pulls/385/commits"},"statuses":{"href":"https://api.github.com/repos/briansmith/ring/statuses/37ee113d81fca118b6b05d387b6d96162d503e63"}}}}
{"actor":{"display_login":"briansmith"}}