{"action":"created","issue":{"url":"https://api.github.com/repos/conda-forge/gdal-feedstock/issues/87","repository_url":"https://api.github.com/repos/conda-forge/gdal-feedstock","labels_url":"https://api.github.com/repos/conda-forge/gdal-feedstock/issues/87/labels{/name}","comments_url":"https://api.github.com/repos/conda-forge/gdal-feedstock/issues/87/comments","events_url":"https://api.github.com/repos/conda-forge/gdal-feedstock/issues/87/events","html_url":"https://github.com/conda-forge/gdal-feedstock/pull/87","id":163510519,"number":87,"title":"WIP: DO NOT MERGE: demonstration of $CONFIG_SITE","user":{"login":"gillins","id":10858582,"avatar_url":"https://avatars.githubusercontent.com/u/10858582?v=3","gravatar_id":"","url":"https://api.github.com/users/gillins","html_url":"https://github.com/gillins","followers_url":"https://api.github.com/users/gillins/followers","following_url":"https://api.github.com/users/gillins/following{/other_user}","gists_url":"https://api.github.com/users/gillins/gists{/gist_id}","starred_url":"https://api.github.com/users/gillins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gillins/subscriptions","organizations_url":"https://api.github.com/users/gillins/orgs","repos_url":"https://api.github.com/users/gillins/repos","events_url":"https://api.github.com/users/gillins/events{/privacy}","received_events_url":"https://api.github.com/users/gillins/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-07-02T09:31:06Z","updated_at":"2016-07-07T11:36:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/conda-forge/gdal-feedstock/pulls/87","html_url":"https://github.com/conda-forge/gdal-feedstock/pull/87","diff_url":"https://github.com/conda-forge/gdal-feedstock/pull/87.diff","patch_url":"https://github.com/conda-forge/gdal-feedstock/pull/87.patch"},"body":"Do not merge.\r\n\r\nThis is a demonstration of using the site defaults feature of `configure` to get the right flags to the compiler without breaking `libtool`.\r\n\r\nXref: https://github.com/conda-forge/conda-forge.github.io/issues/183, https://github.com/conda-forge/gdal-feedstock/pull/85.\r\n\r\nBackground: `toolchain` sets CC, CFLAGS etc environment variables to control the flags passed to the compiler. This seems to break `libtool`. One option is to pass the variables on the command line like https://github.com/conda-forge/gdal-feedstock/pull/85 but this is error prone. Another possibility is to have our own `libtool`, but this seems likely to be a lot of work.\r\n\r\n`autoconf` has a “Site Defaults” feature (https://www.gnu.org/software/autoconf/manual/autoconf-2.68/html_node/Site-Defaults.html) and this PR demonstrates having a file with the flags and setting the `$CONFIG_SITE` environment variable to it. Ideally, this would be done by `toolchain`. None of the CC, CFLAGS environment variables need to be set.\r\n\r\nOne drawback of this approach is that `cmake` and other build systems won't have access to the environment variables – maybe they will need to `source $CONFIG_SITE` or something similar.\r\n\r\nApologies if this isn't clear. And sorry, some of my other changes seem to have ended up here too...\r\n\r\ncc @kmuehlbauer @ocefpaf @jakirkham "},"comment":{"url":"https://api.github.com/repos/conda-forge/gdal-feedstock/issues/comments/231053873","html_url":"https://github.com/conda-forge/gdal-feedstock/pull/87#issuecomment-231053873","issue_url":"https://api.github.com/repos/conda-forge/gdal-feedstock/issues/87","id":231053873,"user":{"login":"pelson","id":810663,"avatar_url":"https://avatars.githubusercontent.com/u/810663?v=3","gravatar_id":"","url":"https://api.github.com/users/pelson","html_url":"https://github.com/pelson","followers_url":"https://api.github.com/users/pelson/followers","following_url":"https://api.github.com/users/pelson/following{/other_user}","gists_url":"https://api.github.com/users/pelson/gists{/gist_id}","starred_url":"https://api.github.com/users/pelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelson/subscriptions","organizations_url":"https://api.github.com/users/pelson/orgs","repos_url":"https://api.github.com/users/pelson/repos","events_url":"https://api.github.com/users/pelson/events{/privacy}","received_events_url":"https://api.github.com/users/pelson/received_events","type":"User","site_admin":false},"created_at":"2016-07-07T11:36:42Z","updated_at":"2016-07-07T11:36:42Z","body":"I'd prefer to be doing this as a file, rather than as a patch, but this to me looks like a really healthy approach. The question then is, do we duplicate this file in all feedstocks that need it (redundancy, risk of being inconsistent, but fully encapsulates the build context), or do we ship it with `toolchain` and put the `.cfg` in place as part of the GDAL build script itself?"}}
{"actor":{"display_login":"pelson"}}