{"action":"created","issue":{"url":"https://api.github.com/repos/exercism/discussions/issues/10","repository_url":"https://api.github.com/repos/exercism/discussions","labels_url":"https://api.github.com/repos/exercism/discussions/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/exercism/discussions/issues/10/comments","events_url":"https://api.github.com/repos/exercism/discussions/issues/10/events","html_url":"https://github.com/exercism/discussions/issues/10","id":149018116,"number":10,"title":"Is the custom-set test set too long?","user":{"login":"IanWhitney","id":12144,"avatar_url":"https://avatars.githubusercontent.com/u/12144?v=3","gravatar_id":"","url":"https://api.github.com/users/IanWhitney","html_url":"https://github.com/IanWhitney","followers_url":"https://api.github.com/users/IanWhitney/followers","following_url":"https://api.github.com/users/IanWhitney/following{/other_user}","gists_url":"https://api.github.com/users/IanWhitney/gists{/gist_id}","starred_url":"https://api.github.com/users/IanWhitney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanWhitney/subscriptions","organizations_url":"https://api.github.com/users/IanWhitney/orgs","repos_url":"https://api.github.com/users/IanWhitney/repos","events_url":"https://api.github.com/users/IanWhitney/events{/privacy}","received_events_url":"https://api.github.com/users/IanWhitney/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-04-18T01:42:03Z","updated_at":"2016-04-19T03:56:13Z","closed_at":null,"body":"I'm working on re-working the Rust implementation so that it follows the [common test suite](https://github.com/exercism/x-common/blob/master/custom-set.json). I'm currently at 32 tests and I might be half-way through.\r\n\r\nThis seems long. It seems to be that a lot of these tests are repetitive. Or maybe they are trying to catch weird corner cases that simply aren't occurring to me.\r\n\r\nSome examples\r\n\r\n- Testing non-empty sets, why two tests? https://github.com/exercism/x-common/blob/master/custom-set.json#L134\r\n- Testing element presence, why four tests? https://github.com/exercism/x-common/blob/master/custom-set.json#L176\r\n- Subset testing appears to have lots of repetition https://github.com/exercism/x-common/blob/master/custom-set.json#L235\r\n- Eight tests of intersection: https://github.com/exercism/x-common/blob/master/custom-set.json#L289\r\n- And eight of Union: https://github.com/exercism/x-common/blob/master/custom-set.json#L342\r\n\r\nI'm not a Set Theory expert, so maybe these tests are catching useful bugs, but it does seem to me that there's a lot that could be trimmed.\r\n\r\nThoughts?"},"comment":{"url":"https://api.github.com/repos/exercism/discussions/issues/comments/211718234","html_url":"https://github.com/exercism/discussions/issues/10#issuecomment-211718234","issue_url":"https://api.github.com/repos/exercism/discussions/issues/10","id":211718234,"user":{"login":"petertseng","id":346181,"avatar_url":"https://avatars.githubusercontent.com/u/346181?v=3","gravatar_id":"","url":"https://api.github.com/users/petertseng","html_url":"https://github.com/petertseng","followers_url":"https://api.github.com/users/petertseng/followers","following_url":"https://api.github.com/users/petertseng/following{/other_user}","gists_url":"https://api.github.com/users/petertseng/gists{/gist_id}","starred_url":"https://api.github.com/users/petertseng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petertseng/subscriptions","organizations_url":"https://api.github.com/users/petertseng/orgs","repos_url":"https://api.github.com/users/petertseng/repos","events_url":"https://api.github.com/users/petertseng/events{/privacy}","received_events_url":"https://api.github.com/users/petertseng/received_events","type":"User","site_admin":false},"created_at":"2016-04-19T03:56:13Z","updated_at":"2016-04-19T03:56:13Z","body":"I suppose I don't have much to say about this specific issue since I haven't worked on the `custom-set` issue in any language,. What I can see, however, is something that seems useful in general. If someone make a test json file, it will probably be useful to explain what some of the corner cases are testing (what kinds of solutions might not pass this test? why?). Or at least in the commit message."}}