{"push_id":1286895199,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"60db3ea8151f715e5f982708aa5ce55c3a6baaf5","before":"98d5fb618cf9a6c8111c446d40adaf10b70aac66","commits":[{"sha":"60db3ea8151f715e5f982708aa5ce55c3a6baaf5","author":{"name":"Vincent Lang","email":"f64b7451417761ab8a8a3d9cdcebbdfb1b9c6aa3@plexapp.com"},"message":"RemoteComponent: fix a crash\n\nMerely opening http://127.0.0.1:32433/player/timeline/poll made PMP\ncrash. The reason is that in handleCommand(), the handleSubscription()\ncall above the code modified by this commit does not necessarily add the\nclient to the m_subscriberMap. As a consequence, the identifier lookup\nwill make the QMap insert and return a default-constructed item, which\nin this case is a 0-pointer. Other code does not expect 0-pointers in\nthe map, and checkSubscribers() is the thing that will crash next.\n\nFix this by explicitly checking whether the client as added to the map\nat all.\n\nAlso, the cast after the lookup should probably be a dynamic cast (it\nseems a C-style cast is never dynamic), and that's what the 0-pointer\ncheck is for. This might fix another crash/undefined behavior bug.","distinct":true,"url":"https://api.github.com/repos/plexinc/plex-media-player/commits/60db3ea8151f715e5f982708aa5ce55c3a6baaf5"}]}
{"actor":{"display_login":"wm4"}}