{"push_id":1471712762,"size":8,"distinct_size":0,"ref":"refs/heads/nightly-master","head":"f535cf3cd87178b06eb682358a6d19fd7d5ed7da","before":"2750a09bd2ed32fb705caa4368cd24e36fa37cf6","commits":[{"sha":"65915910f0c24d807be85314888086fd589c4384","author":{"name":"Francois Budin","email":"332ffb50a6d1b12b323fa0ce2dfd5390575d667d@gmail.com"},"message":"BUG: Missing ITK_TEMPLATE_EXPORT in itkOptimizerParametersHelper\n\nExploring the symbols available in the *dylib and *so files created when\ncompiling ITK on MacOS with BUILD_SHARED_LIBS=ON and WRAP_ITK_PYTHON=ON\nshows that without specifying ITK_TEMPLATE_EXPORT in\nitkOptimizerParametersHelper, symbols with different visibility are\ncreated in different translation units and by extension in the libraries\nthat are created:\nitk::OptimizerParametersHelper<double>\n_ITKReviewPython.so: weak external\n_ITKCommonPython.so: non-external (was signed char private external)\n\nChange-Id: I7c072e9049f72f00cf5526abb741292831f9c269","distinct":false,"url":"https://api.github.com/repos/Kitware/ITK/commits/65915910f0c24d807be85314888086fd589c4384"},{"sha":"26af7975ef7b109be6d677fa7121fa9037abb258","author":{"name":"Francois Budin","email":"332ffb50a6d1b12b323fa0ce2dfd5390575d667d@kitware.com"},"message":"Merge topic 'missing_ITK_TEMPLATE_EXPORT_OptimizerParametersHelper'\n\n65915910 BUG: Missing ITK_TEMPLATE_EXPORT in itkOptimizerParametersHelper","distinct":false,"url":"https://api.github.com/repos/Kitware/ITK/commits/26af7975ef7b109be6d677fa7121fa9037abb258"},{"sha":"ccc00c831f22dba157e054a0d9d114a4176e0a53","author":{"name":"Matt McCormick","email":"c588c59b494f7a0be6892a9d9b73420da40ad57c@kitware.com"},"message":"BUG: Set random number seed mutual information metric tests\n\nTo give consistent output.\n\nChange-Id: I0b7e8977df1716495b983302f3c1aeb9de933e7e","distinct":false,"url":"https://api.github.com/repos/Kitware/ITK/commits/ccc00c831f22dba157e054a0d9d114a4176e0a53"},{"sha":"4734d21b52114ce261588a0dfa718defee265bd7","author":{"name":"Francois Budin","email":"332ffb50a6d1b12b323fa0ce2dfd5390575d667d@gmail.com"},"message":"BUG: Remove linkage warnings on MacOS\n\nOn MacOS, when compiling ITK with BUILD_SHARED_LIBS=ON and ITK_WRAP_PYTHON,\ntypeinfo of the ITK types need to be visible outside of the\nlibrary and must be consistent across all translation units. In case of an\ninconsistency, the linker will print a warning message such as:\n\nld: warning: direct access in itk::SimpleDataObjectDecorator<std::__1::vector\\\n<unsigned long, std::__1::allocator<unsigned long> > >::PrintSelf(\\\nstd::__1::basic_ostream<char, std::__1::char_traits<char> >&, itk::Indent) \\\nconst to global weak symbol typeinfo name for std::__1::vector<unsigned long,\\\nstd::__1::allocator<unsigned long> > means the weak symbol cannot be overridden\\\nat runtime. This was likely caused by different translation units being\\\ncompiled with different visibility settings.\n\ntypeid should not have to worry about the typeinfo being defined multiple times,\nbut there is no easy way to remove this warning without remove the usage of\ntypeid on MacOS when BUILD_SHARED_LIBS=ON .\n\nChange-Id: I26c3027efa7c9024f4df3bee568e422bdd920aa9","distinct":false,"url":"https://api.github.com/repos/Kitware/ITK/commits/4734d21b52114ce261588a0dfa718defee265bd7"},{"sha":"2a07831312c255667c7fd64fa9b7661f9f03dc99","author":{"name":"Francois Budin","email":"332ffb50a6d1b12b323fa0ce2dfd5390575d667d@gmail.com"},"message":"BUG: HDF5 CMake installation directory variable had not been updated\n\nThis commit addresses this issue: https://issues.itk.org/jira/browse/ITK-3504\n\nWhen HDF5 was updated to its current version in ITK, some CMake variables\nused during HDF5 installation had not been updated [1].\nHDF5_INSTALL_LIBRARY_DIR is now called HDF5_INSTALL_LIB_DIR\nHDF5_INSTALL_ARCHIVE_DIR does not exist anymore\nHDF5_INSTALL_RUNTIME_DIR is now called HDF5_INSTALL_BIN_DIR\n\n[1] https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/\\\nThirdParty/HDF5/src/itkhdf5/src/CMakeLists.txt#L801-L803\n\nChange-Id: I062d9c56fa71a06e33b4913c9913939ed089c6b9","distinct":false,"url":"https://api.github.com/repos/Kitware/ITK/commits/2a07831312c255667c7fd64fa9b7661f9f03dc99"},{"sha":"17ce15e97a8bd2dcb6630c810dc7760297b4b13f","author":{"name":"Francois Budin","email":"332ffb50a6d1b12b323fa0ce2dfd5390575d667d@kitware.com"},"message":"Merge topic 'Set_random_number_seed_mutual_information_metric_tests'\n\nccc00c83 BUG: Set random number seed mutual information metric tests","distinct":false,"url":"https://api.github.com/repos/Kitware/ITK/commits/17ce15e97a8bd2dcb6630c810dc7760297b4b13f"},{"sha":"52fe29fc54544096f47bd6bd73e177c68baa243c","author":{"name":"Francois Budin","email":"332ffb50a6d1b12b323fa0ce2dfd5390575d667d@kitware.com"},"message":"Merge topic 'remove_typeid'\n\n4734d21b BUG: Remove linkage warnings on MacOS","distinct":false,"url":"https://api.github.com/repos/Kitware/ITK/commits/52fe29fc54544096f47bd6bd73e177c68baa243c"},{"sha":"f535cf3cd87178b06eb682358a6d19fd7d5ed7da","author":{"name":"Francois Budin","email":"332ffb50a6d1b12b323fa0ce2dfd5390575d667d@kitware.com"},"message":"Merge topic 'hdf5_packaging'\n\n2a078313 BUG: HDF5 CMake installation directory variable had not been updated","distinct":false,"url":"https://api.github.com/repos/Kitware/ITK/commits/f535cf3cd87178b06eb682358a6d19fd7d5ed7da"}]}
{"actor":{"display_login":"kwrobot"}}