{"action":"created","issue":{"url":"https://api.github.com/repos/caciviclab/disclosure-frontend/issues/141","repository_url":"https://api.github.com/repos/caciviclab/disclosure-frontend","labels_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/issues/141/labels{/name}","comments_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/issues/141/comments","events_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/issues/141/events","html_url":"https://github.com/caciviclab/disclosure-frontend/pull/141","id":173664663,"number":141,"title":"Update upcoming election views for fixed backend serialization","user":{"login":"adborden","id":509703,"avatar_url":"https://avatars.githubusercontent.com/u/509703?v=3","gravatar_id":"","url":"https://api.github.com/users/adborden","html_url":"https://github.com/adborden","followers_url":"https://api.github.com/users/adborden/followers","following_url":"https://api.github.com/users/adborden/following{/other_user}","gists_url":"https://api.github.com/users/adborden/gists{/gist_id}","starred_url":"https://api.github.com/users/adborden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adborden/subscriptions","organizations_url":"https://api.github.com/users/adborden/orgs","repos_url":"https://api.github.com/users/adborden/repos","events_url":"https://api.github.com/users/adborden/events{/privacy}","received_events_url":"https://api.github.com/users/adborden/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/caciviclab/disclosure-frontend/labels/DO%20NOT%20MERGE","name":"DO NOT MERGE","color":"eb6420"},{"url":"https://api.github.com/repos/caciviclab/disclosure-frontend/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-28T20:05:20Z","updated_at":"2016-08-31T01:34:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/caciviclab/disclosure-frontend/pulls/141","html_url":"https://github.com/caciviclab/disclosure-frontend/pull/141","diff_url":"https://github.com/caciviclab/disclosure-frontend/pull/141.diff","patch_url":"https://github.com/caciviclab/disclosure-frontend/pull/141.patch"},"body":"The [backend has fixed](https://github.com/caciviclab/disclosure-backend/pull/272) the ballot serialization, so the frontend needs to change a bit since these are breaking changes.\r\n\r\n- Use `name` for office contests, `number` and `title` for referendums (backend is still missing referendum data, so we still get `null`s).\r\n- Added test for disclosure api around error handling when calling a method that doesn't exist in the swagger spec.\r\n- Use the disclosureApi service so I can develop against a local backend.\r\n\r\nThis should be merged at the same time as https://github.com/caciviclab/disclosure-backend/pull/272"},"comment":{"url":"https://api.github.com/repos/caciviclab/disclosure-frontend/issues/comments/243633273","html_url":"https://github.com/caciviclab/disclosure-frontend/pull/141#issuecomment-243633273","issue_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/issues/141","id":243633273,"user":{"login":"jnmarcus","id":1439922,"avatar_url":"https://avatars.githubusercontent.com/u/1439922?v=3","gravatar_id":"","url":"https://api.github.com/users/jnmarcus","html_url":"https://github.com/jnmarcus","followers_url":"https://api.github.com/users/jnmarcus/followers","following_url":"https://api.github.com/users/jnmarcus/following{/other_user}","gists_url":"https://api.github.com/users/jnmarcus/gists{/gist_id}","starred_url":"https://api.github.com/users/jnmarcus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnmarcus/subscriptions","organizations_url":"https://api.github.com/users/jnmarcus/orgs","repos_url":"https://api.github.com/users/jnmarcus/repos","events_url":"https://api.github.com/users/jnmarcus/events{/privacy}","received_events_url":"https://api.github.com/users/jnmarcus/received_events","type":"User","site_admin":false},"created_at":"2016-08-31T01:34:55Z","updated_at":"2016-08-31T01:34:55Z","body":"It also didn't consistently return data, acted erratically when developing locally and included no comments or error messages for different endpoints. I get developing against a local backend, I've said that many times before, but we're working against an actual deadline, and there was no bug, and nothing that wasn't working.  Using this service just slowed down work significantly before, and I just don't think these types of changes are a priority right now.  \r\n\r\nAlso, if I'm not mistaken, it returned the entire api, with all of the endpoints? "}}
{"actor":{"display_login":"jnmarcus"}}