{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-client/pulls/comments/82769996","pull_request_review_id":3653341,"id":82769996,"diff_hunk":"@@ -50,7 +50,7 @@ def execute\n                 err request.parsed_response[\"error\"]\n               end\n \n-              response = JSON.parse(request.body)\n+              response = JSON.parse(request.body) unless request.body.nil?","path":"lib/crowbar/client/command/upgrade/database.rb","position":5,"original_position":5,"commit_id":"df6ce0b5c26c422c2c193d0ced04043f15e190f6","original_commit_id":"df6ce0b5c26c422c2c193d0ced04043f15e190f6","user":{"login":"nicolasbock","id":841385,"avatar_url":"https://avatars.githubusercontent.com/u/841385?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolasbock","html_url":"https://github.com/nicolasbock","followers_url":"https://api.github.com/users/nicolasbock/followers","following_url":"https://api.github.com/users/nicolasbock/following{/other_user}","gists_url":"https://api.github.com/users/nicolasbock/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasbock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasbock/subscriptions","organizations_url":"https://api.github.com/users/nicolasbock/orgs","repos_url":"https://api.github.com/users/nicolasbock/repos","events_url":"https://api.github.com/users/nicolasbock/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasbock/received_events","type":"User","site_admin":false},"body":"Thanks! Yes, you are right, https://github.com/crowbar/crowbar-client/commit/8358869e124b02c4c1c01f814f3c528d6344da4f should address this.\r\n\r\nWhile looking at https://bugzilla.suse.com/show_bug.cgi?id=1001278 I set up a develcloud6 yesterday and ran an upgrade job to develcloud7 and ran into this problem. The database did not respond and the upgrade just failed with an uncaught exception.\r\n\r\nI am surprised I didn't get your commit though. It was committed already 5 days ago. Shouldn't it have been included in the upgrade yesterday?","created_at":"2016-10-11T11:06:05Z","updated_at":"2016-10-11T11:06:05Z","html_url":"https://github.com/crowbar/crowbar-client/pull/112#discussion_r82769996","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-client/pulls/112","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-client/pulls/comments/82769996"},"html":{"href":"https://github.com/crowbar/crowbar-client/pull/112#discussion_r82769996"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-client/pulls/112"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-client/pulls/112","id":88735021,"html_url":"https://github.com/crowbar/crowbar-client/pull/112","diff_url":"https://github.com/crowbar/crowbar-client/pull/112.diff","patch_url":"https://github.com/crowbar/crowbar-client/pull/112.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-client/issues/112","number":112,"state":"open","locked":false,"title":"Catch potential nil body of response","user":{"login":"nicolasbock","id":841385,"avatar_url":"https://avatars.githubusercontent.com/u/841385?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolasbock","html_url":"https://github.com/nicolasbock","followers_url":"https://api.github.com/users/nicolasbock/followers","following_url":"https://api.github.com/users/nicolasbock/following{/other_user}","gists_url":"https://api.github.com/users/nicolasbock/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasbock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasbock/subscriptions","organizations_url":"https://api.github.com/users/nicolasbock/orgs","repos_url":"https://api.github.com/users/nicolasbock/repos","events_url":"https://api.github.com/users/nicolasbock/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasbock/received_events","type":"User","site_admin":false},"body":"Under error, the response.body is nil and should not be stuffed into the JSON\r\nparser.","created_at":"2016-10-10T21:34:26Z","updated_at":"2016-10-11T11:06:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fb784755db04e29f57c78f9c778742f37862f2f","assignee":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"assignees":[{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-client/pulls/112/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-client/pulls/112/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-client/issues/112/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-client/statuses/df6ce0b5c26c422c2c193d0ced04043f15e190f6","head":{"label":"nicolasbock:database_upgrade","ref":"database_upgrade","sha":"df6ce0b5c26c422c2c193d0ced04043f15e190f6","user":{"login":"nicolasbock","id":841385,"avatar_url":"https://avatars.githubusercontent.com/u/841385?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolasbock","html_url":"https://github.com/nicolasbock","followers_url":"https://api.github.com/users/nicolasbock/followers","following_url":"https://api.github.com/users/nicolasbock/following{/other_user}","gists_url":"https://api.github.com/users/nicolasbock/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasbock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasbock/subscriptions","organizations_url":"https://api.github.com/users/nicolasbock/orgs","repos_url":"https://api.github.com/users/nicolasbock/repos","events_url":"https://api.github.com/users/nicolasbock/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasbock/received_events","type":"User","site_admin":false},"repo":{"id":69097763,"name":"crowbar-client","full_name":"nicolasbock/crowbar-client","owner":{"login":"nicolasbock","id":841385,"avatar_url":"https://avatars.githubusercontent.com/u/841385?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolasbock","html_url":"https://github.com/nicolasbock","followers_url":"https://api.github.com/users/nicolasbock/followers","following_url":"https://api.github.com/users/nicolasbock/following{/other_user}","gists_url":"https://api.github.com/users/nicolasbock/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasbock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasbock/subscriptions","organizations_url":"https://api.github.com/users/nicolasbock/orgs","repos_url":"https://api.github.com/users/nicolasbock/repos","events_url":"https://api.github.com/users/nicolasbock/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasbock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nicolasbock/crowbar-client","description":"Command line client for Crowbar","fork":true,"url":"https://api.github.com/repos/nicolasbock/crowbar-client","forks_url":"https://api.github.com/repos/nicolasbock/crowbar-client/forks","keys_url":"https://api.github.com/repos/nicolasbock/crowbar-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicolasbock/crowbar-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicolasbock/crowbar-client/teams","hooks_url":"https://api.github.com/repos/nicolasbock/crowbar-client/hooks","issue_events_url":"https://api.github.com/repos/nicolasbock/crowbar-client/issues/events{/number}","events_url":"https://api.github.com/repos/nicolasbock/crowbar-client/events","assignees_url":"https://api.github.com/repos/nicolasbock/crowbar-client/assignees{/user}","branches_url":"https://api.github.com/repos/nicolasbock/crowbar-client/branches{/branch}","tags_url":"https://api.github.com/repos/nicolasbock/crowbar-client/tags","blobs_url":"https://api.github.com/repos/nicolasbock/crowbar-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicolasbock/crowbar-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicolasbock/crowbar-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicolasbock/crowbar-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicolasbock/crowbar-client/statuses/{sha}","languages_url":"https://api.github.com/repos/nicolasbock/crowbar-client/languages","stargazers_url":"https://api.github.com/repos/nicolasbock/crowbar-client/stargazers","contributors_url":"https://api.github.com/repos/nicolasbock/crowbar-client/contributors","subscribers_url":"https://api.github.com/repos/nicolasbock/crowbar-client/subscribers","subscription_url":"https://api.github.com/repos/nicolasbock/crowbar-client/subscription","commits_url":"https://api.github.com/repos/nicolasbock/crowbar-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicolasbock/crowbar-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicolasbock/crowbar-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicolasbock/crowbar-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/nicolasbock/crowbar-client/contents/{+path}","compare_url":"https://api.github.com/repos/nicolasbock/crowbar-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicolasbock/crowbar-client/merges","archive_url":"https://api.github.com/repos/nicolasbock/crowbar-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicolasbock/crowbar-client/downloads","issues_url":"https://api.github.com/repos/nicolasbock/crowbar-client/issues{/number}","pulls_url":"https://api.github.com/repos/nicolasbock/crowbar-client/pulls{/number}","milestones_url":"https://api.github.com/repos/nicolasbock/crowbar-client/milestones{/number}","notifications_url":"https://api.github.com/repos/nicolasbock/crowbar-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicolasbock/crowbar-client/labels{/name}","releases_url":"https://api.github.com/repos/nicolasbock/crowbar-client/releases{/id}","deployments_url":"https://api.github.com/repos/nicolasbock/crowbar-client/deployments","created_at":"2016-09-24T11:17:50Z","updated_at":"2016-09-24T11:17:52Z","pushed_at":"2016-10-10T21:34:09Z","git_url":"git://github.com/nicolasbock/crowbar-client.git","ssh_url":"git@github.com:nicolasbock/crowbar-client.git","clone_url":"https://github.com/nicolasbock/crowbar-client.git","svn_url":"https://github.com/nicolasbock/crowbar-client","homepage":"","size":458,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"65096417c959eeb521ebf800834ec65587ee79b5","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39223531,"name":"crowbar-client","full_name":"crowbar/crowbar-client","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-client","description":"Command line client for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-client","forks_url":"https://api.github.com/repos/crowbar/crowbar-client/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-client/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-client/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-client/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-client/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-client/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-client/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-client/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-client/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-client/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-client/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-client/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-client/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-client/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-client/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-client/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-client/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-client/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-client/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-client/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-client/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-client/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-client/deployments","created_at":"2015-07-16T22:29:43Z","updated_at":"2016-05-04T13:18:11Z","pushed_at":"2016-10-10T21:34:26Z","git_url":"git://github.com/crowbar/crowbar-client.git","ssh_url":"git@github.com:crowbar/crowbar-client.git","clone_url":"https://github.com/crowbar/crowbar-client.git","svn_url":"https://github.com/crowbar/crowbar-client","homepage":"","size":464,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":1,"forks":11,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-client/pulls/112"},"html":{"href":"https://github.com/crowbar/crowbar-client/pull/112"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-client/issues/112"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-client/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-client/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-client/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-client/statuses/df6ce0b5c26c422c2c193d0ced04043f15e190f6"}}}}
{"actor":{"display_login":"nicolasbock"}}