{"action":"created","comment":{"url":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/comments/57128643","id":57128643,"diff_hunk":"@@ -0,0 +1,40 @@\n+/**\n+ * Copyright 2015-2016 The OpenZipkin Authors\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except\n+ * in compliance with the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License\n+ * is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express\n+ * or implied. See the License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+package zipkin.async;\n+\n+import zipkin.internal.Nullable;","path":"zipkin/src/main/java/zipkin/async/Callback.java","position":16,"original_position":16,"commit_id":"16cea9a535b3e9cd48337fbae8d5a1c0b63d082a","original_commit_id":"16cea9a535b3e9cd48337fbae8d5a1c0b63d082a","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"body":"main thing is: runtime jars can conflict. Right now, we have no exposed\ndependencies of any sort in core.\n","created_at":"2016-03-23T09:19:46Z","updated_at":"2016-03-23T09:19:46Z","html_url":"https://github.com/openzipkin/zipkin-java/pull/122#discussion_r57128643","pull_request_url":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/122","_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/comments/57128643"},"html":{"href":"https://github.com/openzipkin/zipkin-java/pull/122#discussion_r57128643"},"pull_request":{"href":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/122"}}},"pull_request":{"url":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/122","id":63845034,"html_url":"https://github.com/openzipkin/zipkin-java/pull/122","diff_url":"https://github.com/openzipkin/zipkin-java/pull/122.diff","patch_url":"https://github.com/openzipkin/zipkin-java/pull/122.patch","issue_url":"https://api.github.com/repos/openzipkin/zipkin-java/issues/122","number":122,"state":"open","locked":false,"title":"Adds AsyncSpanStore: an SPI to adapt to async composition libraries","user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"body":"This adds a callback-driven AsyncSpanStore, which can be used to build\r\nfutures or other async constructs. This isn't intended to be used\r\ndirectly by users. Rather, it is an SPI used to intermediate between\r\nlibraries that can drift, such as Guava or RxJava.\r\n\r\nSee #111","created_at":"2016-03-23T08:14:20Z","updated_at":"2016-03-23T09:19:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"319c5efa0d968e0de43c8fcd488d791a017fce44","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/122/commits","review_comments_url":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/122/comments","review_comment_url":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-java/issues/122/comments","statuses_url":"https://api.github.com/repos/openzipkin/zipkin-java/statuses/16cea9a535b3e9cd48337fbae8d5a1c0b63d082a","head":{"label":"openzipkin:async-spanstore","ref":"async-spanstore","sha":"16cea9a535b3e9cd48337fbae8d5a1c0b63d082a","user":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":40143886,"name":"zipkin-java","full_name":"openzipkin/zipkin-java","owner":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzipkin/zipkin-java","description":"Experimental java zipkin backend","fork":false,"url":"https://api.github.com/repos/openzipkin/zipkin-java","forks_url":"https://api.github.com/repos/openzipkin/zipkin-java/forks","keys_url":"https://api.github.com/repos/openzipkin/zipkin-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/zipkin-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/zipkin-java/teams","hooks_url":"https://api.github.com/repos/openzipkin/zipkin-java/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/zipkin-java/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/zipkin-java/events","assignees_url":"https://api.github.com/repos/openzipkin/zipkin-java/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/zipkin-java/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/zipkin-java/tags","blobs_url":"https://api.github.com/repos/openzipkin/zipkin-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/zipkin-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/zipkin-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/zipkin-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/zipkin-java/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/zipkin-java/languages","stargazers_url":"https://api.github.com/repos/openzipkin/zipkin-java/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/zipkin-java/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/zipkin-java/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/zipkin-java/subscription","commits_url":"https://api.github.com/repos/openzipkin/zipkin-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/zipkin-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/zipkin-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/zipkin-java/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/zipkin-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/zipkin-java/merges","archive_url":"https://api.github.com/repos/openzipkin/zipkin-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/zipkin-java/downloads","issues_url":"https://api.github.com/repos/openzipkin/zipkin-java/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/zipkin-java/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/zipkin-java/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/zipkin-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/zipkin-java/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/zipkin-java/releases{/id}","deployments_url":"https://api.github.com/repos/openzipkin/zipkin-java/deployments","created_at":"2015-08-03T19:28:20Z","updated_at":"2016-03-22T20:20:04Z","pushed_at":"2016-03-23T08:19:50Z","git_url":"git://github.com/openzipkin/zipkin-java.git","ssh_url":"git@github.com:openzipkin/zipkin-java.git","clone_url":"https://github.com/openzipkin/zipkin-java.git","svn_url":"https://github.com/openzipkin/zipkin-java","homepage":null,"size":1036,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":11,"forks":15,"open_issues":11,"watchers":28,"default_branch":"master"}},"base":{"label":"openzipkin:master","ref":"master","sha":"7da5a5c9b0db60e047a88a4b504cc5a1364600a7","user":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":40143886,"name":"zipkin-java","full_name":"openzipkin/zipkin-java","owner":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars.githubusercontent.com/u/11860887?v=3","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzipkin/zipkin-java","description":"Experimental java zipkin backend","fork":false,"url":"https://api.github.com/repos/openzipkin/zipkin-java","forks_url":"https://api.github.com/repos/openzipkin/zipkin-java/forks","keys_url":"https://api.github.com/repos/openzipkin/zipkin-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/zipkin-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/zipkin-java/teams","hooks_url":"https://api.github.com/repos/openzipkin/zipkin-java/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/zipkin-java/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/zipkin-java/events","assignees_url":"https://api.github.com/repos/openzipkin/zipkin-java/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/zipkin-java/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/zipkin-java/tags","blobs_url":"https://api.github.com/repos/openzipkin/zipkin-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/zipkin-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/zipkin-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/zipkin-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/zipkin-java/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/zipkin-java/languages","stargazers_url":"https://api.github.com/repos/openzipkin/zipkin-java/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/zipkin-java/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/zipkin-java/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/zipkin-java/subscription","commits_url":"https://api.github.com/repos/openzipkin/zipkin-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/zipkin-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/zipkin-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/zipkin-java/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/zipkin-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/zipkin-java/merges","archive_url":"https://api.github.com/repos/openzipkin/zipkin-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/zipkin-java/downloads","issues_url":"https://api.github.com/repos/openzipkin/zipkin-java/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/zipkin-java/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/zipkin-java/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/zipkin-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/zipkin-java/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/zipkin-java/releases{/id}","deployments_url":"https://api.github.com/repos/openzipkin/zipkin-java/deployments","created_at":"2015-08-03T19:28:20Z","updated_at":"2016-03-22T20:20:04Z","pushed_at":"2016-03-23T08:19:50Z","git_url":"git://github.com/openzipkin/zipkin-java.git","ssh_url":"git@github.com:openzipkin/zipkin-java.git","clone_url":"https://github.com/openzipkin/zipkin-java.git","svn_url":"https://github.com/openzipkin/zipkin-java","homepage":null,"size":1036,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":11,"forks":15,"open_issues":11,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/122"},"html":{"href":"https://github.com/openzipkin/zipkin-java/pull/122"},"issue":{"href":"https://api.github.com/repos/openzipkin/zipkin-java/issues/122"},"comments":{"href":"https://api.github.com/repos/openzipkin/zipkin-java/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzipkin/zipkin-java/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/openzipkin/zipkin-java/statuses/16cea9a535b3e9cd48337fbae8d5a1c0b63d082a"}}}}