{"action":"created","issue":{"url":"https://api.github.com/repos/cfengine/masterfiles/issues/802","repository_url":"https://api.github.com/repos/cfengine/masterfiles","labels_url":"https://api.github.com/repos/cfengine/masterfiles/issues/802/labels{/name}","comments_url":"https://api.github.com/repos/cfengine/masterfiles/issues/802/comments","events_url":"https://api.github.com/repos/cfengine/masterfiles/issues/802/events","html_url":"https://github.com/cfengine/masterfiles/pull/802","id":176979232,"number":802,"title":"Pass package promise options to underlying apt-get call","user":{"login":"jpvlsmv","id":1010764,"avatar_url":"https://avatars.githubusercontent.com/u/1010764?v=3","gravatar_id":"","url":"https://api.github.com/users/jpvlsmv","html_url":"https://github.com/jpvlsmv","followers_url":"https://api.github.com/users/jpvlsmv/followers","following_url":"https://api.github.com/users/jpvlsmv/following{/other_user}","gists_url":"https://api.github.com/users/jpvlsmv/gists{/gist_id}","starred_url":"https://api.github.com/users/jpvlsmv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpvlsmv/subscriptions","organizations_url":"https://api.github.com/users/jpvlsmv/orgs","repos_url":"https://api.github.com/users/jpvlsmv/repos","events_url":"https://api.github.com/users/jpvlsmv/events{/privacy}","received_events_url":"https://api.github.com/users/jpvlsmv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-09-14T18:09:18Z","updated_at":"2016-09-15T18:52:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cfengine/masterfiles/pulls/802","html_url":"https://github.com/cfengine/masterfiles/pull/802","diff_url":"https://github.com/cfengine/masterfiles/pull/802.diff","patch_url":"https://github.com/cfengine/masterfiles/pull/802.patch"},"body":"Changelog: Title\r\n\r\nCommit can be cherry-picked cleanly into 3.7.x, 3.8.x, 3.9.x as well."},"comment":{"url":"https://api.github.com/repos/cfengine/masterfiles/issues/comments/247417710","html_url":"https://github.com/cfengine/masterfiles/pull/802#issuecomment-247417710","issue_url":"https://api.github.com/repos/cfengine/masterfiles/issues/802","id":247417710,"user":{"login":"jpvlsmv","id":1010764,"avatar_url":"https://avatars.githubusercontent.com/u/1010764?v=3","gravatar_id":"","url":"https://api.github.com/users/jpvlsmv","html_url":"https://github.com/jpvlsmv","followers_url":"https://api.github.com/users/jpvlsmv/followers","following_url":"https://api.github.com/users/jpvlsmv/following{/other_user}","gists_url":"https://api.github.com/users/jpvlsmv/gists{/gist_id}","starred_url":"https://api.github.com/users/jpvlsmv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpvlsmv/subscriptions","organizations_url":"https://api.github.com/users/jpvlsmv/orgs","repos_url":"https://api.github.com/users/jpvlsmv/repos","events_url":"https://api.github.com/users/jpvlsmv/events{/privacy}","received_events_url":"https://api.github.com/users/jpvlsmv/received_events","type":"User","site_admin":false},"created_at":"2016-09-15T18:52:31Z","updated_at":"2016-09-15T18:52:31Z","body":"I'm not sure that there is a security risk created by passing tokens from cfengine to one of its modules... But since Python calls `subprocess_Popen(cmd, stdout, stderr)` and the cmd parameter is an array, there is no subshell involved.  (Unless you explicitly pass shell=True, or are on Windows where the underlying CreateProcess() call only operates on strings)\r\n\r\nhttps://docs.python.org/2/library/subprocess.html#popen-constructor\r\n\r\nI don't mind the additional checks either way."}}
{"actor":{"display_login":"jpvlsmv"}}