{"action":"created","comment":{"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/comments/63557930","id":63557930,"diff_hunk":"@@ -324,10 +324,8 @@ - (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath\n \n - (void)presentThread:(TSThread *)thread keyboardOnViewAppearing:(BOOL)keyboardOnViewAppearing {\n     dispatch_async(dispatch_get_main_queue(), ^{\n-      if (!_mvc) {\n-          _mvc = [[UIStoryboard storyboardWithName:@\"Storyboard\" bundle:NULL]\n-              instantiateViewControllerWithIdentifier:@\"MessagesViewController\"];\n-      }\n+      _mvc = [[UIStoryboard storyboardWithName:@\"Storyboard\" bundle:NULL]\n+                instantiateViewControllerWithIdentifier:@\"MessagesViewController\"];","path":"Signal/src/view controllers/UITests/SignalsViewController.m","position":9,"original_position":9,"commit_id":"6252b4dcc30e752aa97460a8eb629c4828e69b43","original_commit_id":"256427b5480badf84eef1e4f4a9b2a7a07c7390b","user":{"login":"michaelkirk","id":217057,"avatar_url":"https://avatars.githubusercontent.com/u/217057?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelkirk","html_url":"https://github.com/michaelkirk","followers_url":"https://api.github.com/users/michaelkirk/followers","following_url":"https://api.github.com/users/michaelkirk/following{/other_user}","gists_url":"https://api.github.com/users/michaelkirk/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelkirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelkirk/subscriptions","organizations_url":"https://api.github.com/users/michaelkirk/orgs","repos_url":"https://api.github.com/users/michaelkirk/repos","events_url":"https://api.github.com/users/michaelkirk/events{/privacy}","received_events_url":"https://api.github.com/users/michaelkirk/received_events","type":"User","site_admin":false},"body":"Apart from this issue, it's caused a couple others (#1150, #1152), and it offers no measurable value to this release, while introducing the risk of other yet-to-be-discovered issues.\r\n\r\nI'm not opposed to reusing the MessageViewController in theory, and see how it paves the way for a split view iPad layout, but we don't have that in this release anyway. If you'd like to submit a PR with your work, it might be useful for a future iPad layout. \r\n\r\nThanks for looking into it @big-r81.","created_at":"2016-05-17T16:38:16Z","updated_at":"2016-05-17T16:38:16Z","html_url":"https://github.com/WhisperSystems/Signal-iOS/pull/1187#discussion_r63557930","pull_request_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/1187","_links":{"self":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/comments/63557930"},"html":{"href":"https://github.com/WhisperSystems/Signal-iOS/pull/1187#discussion_r63557930"},"pull_request":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/1187"}}},"pull_request":{"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/1187","id":70262775,"html_url":"https://github.com/WhisperSystems/Signal-iOS/pull/1187","diff_url":"https://github.com/WhisperSystems/Signal-iOS/pull/1187.diff","patch_url":"https://github.com/WhisperSystems/Signal-iOS/pull/1187.patch","issue_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/1187","number":1187,"state":"open","locked":false,"title":"Reset compose view on thread switch","user":{"login":"michaelkirk","id":217057,"avatar_url":"https://avatars.githubusercontent.com/u/217057?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelkirk","html_url":"https://github.com/michaelkirk","followers_url":"https://api.github.com/users/michaelkirk/followers","following_url":"https://api.github.com/users/michaelkirk/following{/other_user}","gists_url":"https://api.github.com/users/michaelkirk/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelkirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelkirk/subscriptions","organizations_url":"https://api.github.com/users/michaelkirk/orgs","repos_url":"https://api.github.com/users/michaelkirk/repos","events_url":"https://api.github.com/users/michaelkirk/events{/privacy}","received_events_url":"https://api.github.com/users/michaelkirk/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nFixes #1179 to make sure text box is proper size and makes sure to pop the keyboard when draft text is present.","created_at":"2016-05-16T21:15:00Z","updated_at":"2016-05-17T16:38:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba112171b2dfa4495eb976fca8a1e9e41faa1d58","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/1187/commits","review_comments_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/1187/comments","review_comment_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/1187/comments","statuses_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/statuses/6252b4dcc30e752aa97460a8eb629c4828e69b43","head":{"label":"WhisperSystems:reset-compose-view-on-thread-switch","ref":"reset-compose-view-on-thread-switch","sha":"6252b4dcc30e752aa97460a8eb629c4828e69b43","user":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars.githubusercontent.com/u/702459?v=3","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":19429698,"name":"Signal-iOS","full_name":"WhisperSystems/Signal-iOS","owner":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars.githubusercontent.com/u/702459?v=3","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WhisperSystems/Signal-iOS","description":"A private messenger for iOS","fork":false,"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS","forks_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/forks","keys_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/teams","hooks_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/hooks","issue_events_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/events","assignees_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/tags","blobs_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/languages","stargazers_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/stargazers","contributors_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/contributors","subscribers_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/subscribers","subscription_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/subscription","commits_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/merges","archive_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/downloads","issues_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/labels{/name}","releases_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/deployments","created_at":"2014-05-04T15:42:40Z","updated_at":"2016-05-17T09:01:39Z","pushed_at":"2016-05-16T22:54:17Z","git_url":"git://github.com/WhisperSystems/Signal-iOS.git","ssh_url":"git@github.com:WhisperSystems/Signal-iOS.git","clone_url":"https://github.com/WhisperSystems/Signal-iOS.git","svn_url":"https://github.com/WhisperSystems/Signal-iOS","homepage":"https://whispersystems.org/","size":33513,"stargazers_count":1843,"watchers_count":1843,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":407,"mirror_url":null,"open_issues_count":181,"forks":407,"open_issues":181,"watchers":1843,"default_branch":"master"}},"base":{"label":"WhisperSystems:master","ref":"master","sha":"da6597118ae8336aab0ce546fe431d8338013577","user":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars.githubusercontent.com/u/702459?v=3","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":19429698,"name":"Signal-iOS","full_name":"WhisperSystems/Signal-iOS","owner":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars.githubusercontent.com/u/702459?v=3","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WhisperSystems/Signal-iOS","description":"A private messenger for iOS","fork":false,"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS","forks_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/forks","keys_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/teams","hooks_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/hooks","issue_events_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/events","assignees_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/tags","blobs_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/languages","stargazers_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/stargazers","contributors_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/contributors","subscribers_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/subscribers","subscription_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/subscription","commits_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/merges","archive_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/downloads","issues_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/labels{/name}","releases_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/deployments","created_at":"2014-05-04T15:42:40Z","updated_at":"2016-05-17T09:01:39Z","pushed_at":"2016-05-16T22:54:17Z","git_url":"git://github.com/WhisperSystems/Signal-iOS.git","ssh_url":"git@github.com:WhisperSystems/Signal-iOS.git","clone_url":"https://github.com/WhisperSystems/Signal-iOS.git","svn_url":"https://github.com/WhisperSystems/Signal-iOS","homepage":"https://whispersystems.org/","size":33513,"stargazers_count":1843,"watchers_count":1843,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":407,"mirror_url":null,"open_issues_count":181,"forks":407,"open_issues":181,"watchers":1843,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/1187"},"html":{"href":"https://github.com/WhisperSystems/Signal-iOS/pull/1187"},"issue":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/1187"},"comments":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/1187/comments"},"review_comments":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/1187/comments"},"review_comment":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/1187/commits"},"statuses":{"href":"https://api.github.com/repos/WhisperSystems/Signal-iOS/statuses/6252b4dcc30e752aa97460a8eb629c4828e69b43"}}}}