{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/10677","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/10677/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/10677/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/10677/events","html_url":"https://github.com/openshift/origin/pull/10677","id":173499367,"number":10677,"title":"[BZ1365986] new-app: validate that EXPOSEd ports are numbers","user":{"login":"php-coder","id":87088,"avatar_url":"https://avatars.githubusercontent.com/u/87088?v=3","gravatar_id":"","url":"https://api.github.com/users/php-coder","html_url":"https://github.com/php-coder","followers_url":"https://api.github.com/users/php-coder/followers","following_url":"https://api.github.com/users/php-coder/following{/other_user}","gists_url":"https://api.github.com/users/php-coder/gists{/gist_id}","starred_url":"https://api.github.com/users/php-coder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-coder/subscriptions","organizations_url":"https://api.github.com/users/php-coder/orgs","repos_url":"https://api.github.com/users/php-coder/repos","events_url":"https://api.github.com/users/php-coder/events{/privacy}","received_events_url":"https://api.github.com/users/php-coder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/openshift/origin/milestones/16","html_url":"https://github.com/openshift/origin/milestones/1.3.1","labels_url":"https://api.github.com/repos/openshift/origin/milestones/16/labels","id":1948964,"number":16,"title":"1.3.1","description":null,"creator":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":17,"state":"open","created_at":"2016-08-18T08:14:38Z","updated_at":"2016-10-19T14:18:34Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2016-08-26T17:06:34Z","updated_at":"2016-10-24T17:43:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/10677","html_url":"https://github.com/openshift/origin/pull/10677","diff_url":"https://github.com/openshift/origin/pull/10677.diff","patch_url":"https://github.com/openshift/origin/pull/10677.patch"},"body":"Add validation to `oc new-app` to ensure that exposed ports from the `Dockerfile` in a user's repository are numbers.\r\n\r\nExample:\r\n```console\r\n$ oc new-app https://github.com/php-coder/s2i-test#use_arg_directive \r\nerror: the Dockerfile has an invalid EXPOSE instruction: could not parse \"$JETTY_PORT\": must be numerical\r\n```\r\nAt the same time `oc new-build` works as before:\r\n```console\r\n$ oc new-build https://github.com/php-coder/s2i-test#use_arg_directive \r\n--> Found Docker image 34a035d (2 days old) from Docker Hub for \"java:8\"\r\n\r\n\t* An image stream will be created as \"java:8\" that will track the source image\r\n\t* A Docker build using source code from https://github.com/php-coder/s2i-test#use_arg_directive will be created\r\n\t  * The resulting image will be pushed to image stream \"s2i-test:latest\"\r\n\t  * Every time \"java:8\" changes a new build will be triggered\r\n\r\n--> Creating resources with label build=s2i-test ...\r\n\timagestream \"java\" created\r\n\timagestream \"s2i-test\" created\r\n\tbuildconfig \"s2i-test\" created\r\n--> Success\r\n\tBuild configuration \"s2i-test\" created and build triggered.\r\n\tRun 'new-build logs -f bc/s2i-test' to stream the build progress.\r\n```\r\n\r\nPTAL @bparees \r\n\r\nBugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1365986"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/255812294","html_url":"https://github.com/openshift/origin/pull/10677#issuecomment-255812294","issue_url":"https://api.github.com/repos/openshift/origin/issues/10677","id":255812294,"user":{"login":"php-coder","id":87088,"avatar_url":"https://avatars.githubusercontent.com/u/87088?v=3","gravatar_id":"","url":"https://api.github.com/users/php-coder","html_url":"https://github.com/php-coder","followers_url":"https://api.github.com/users/php-coder/followers","following_url":"https://api.github.com/users/php-coder/following{/other_user}","gists_url":"https://api.github.com/users/php-coder/gists{/gist_id}","starred_url":"https://api.github.com/users/php-coder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-coder/subscriptions","organizations_url":"https://api.github.com/users/php-coder/orgs","repos_url":"https://api.github.com/users/php-coder/repos","events_url":"https://api.github.com/users/php-coder/events{/privacy}","received_events_url":"https://api.github.com/users/php-coder/received_events","type":"User","site_admin":false},"created_at":"2016-10-24T17:43:49Z","updated_at":"2016-10-24T17:43:49Z","body":"@bparees PTAL again. Because new-app and new-build both use `AppConfig.Run()` method, I have to add a special flag."}}
{"actor":{"display_login":"php-coder"}}