{"action":"closed","number":37296,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37296","id":94857515,"html_url":"https://github.com/kubernetes/kubernetes/pull/37296","diff_url":"https://github.com/kubernetes/kubernetes/pull/37296.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/37296.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37296","number":37296,"state":"closed","locked":false,"title":"Fix skipping - protobuf fields","user":{"login":"ncdc","id":354,"avatar_url":"https://avatars.githubusercontent.com/u/354?v=3","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md\r\n2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md\r\n3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes\r\n-->\r\n\r\n**What this PR does / why we need it**: fixes the protobuf generator to skip fields with a protobuf tag of `\"-\"`\r\n\r\nMatch changes in https://github.com/kubernetes/gengo/pull/19\r\n\r\nI couldn't get godeps to work to vendor this change in from gengo, so I made the same edits manually in cmd/libs/go2idl. A task for another day...\r\n\r\n@smarterclayton\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/37296)\n<!-- Reviewable:end -->\n","created_at":"2016-11-22T17:11:52Z","updated_at":"2016-12-23T03:36:26Z","closed_at":"2016-12-23T03:36:26Z","merged_at":"2016-12-23T03:36:25Z","merge_commit_sha":"9541c38f39dfc1e8453c7d22e9f4f7df1dfdf266","assignee":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"assignees":[{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37296/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37296/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37296/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/f0247ea595b2682ee4170cf201ef4efecb174b44","head":{"label":"ncdc:skip-dash-in-protobuf-tags","ref":"skip-dash-in-protobuf-tags","sha":"f0247ea595b2682ee4170cf201ef4efecb174b44","user":{"login":"ncdc","id":354,"avatar_url":"https://avatars.githubusercontent.com/u/354?v=3","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"repo":{"id":22116483,"name":"kubernetes","full_name":"ncdc/kubernetes","owner":{"login":"ncdc","id":354,"avatar_url":"https://avatars.githubusercontent.com/u/354?v=3","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ncdc/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/ncdc/kubernetes","forks_url":"https://api.github.com/repos/ncdc/kubernetes/forks","keys_url":"https://api.github.com/repos/ncdc/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ncdc/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ncdc/kubernetes/teams","hooks_url":"https://api.github.com/repos/ncdc/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/ncdc/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/ncdc/kubernetes/events","assignees_url":"https://api.github.com/repos/ncdc/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/ncdc/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/ncdc/kubernetes/tags","blobs_url":"https://api.github.com/repos/ncdc/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ncdc/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ncdc/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/ncdc/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ncdc/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/ncdc/kubernetes/languages","stargazers_url":"https://api.github.com/repos/ncdc/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/ncdc/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/ncdc/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/ncdc/kubernetes/subscription","commits_url":"https://api.github.com/repos/ncdc/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/ncdc/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/ncdc/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/ncdc/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/ncdc/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/ncdc/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ncdc/kubernetes/merges","archive_url":"https://api.github.com/repos/ncdc/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ncdc/kubernetes/downloads","issues_url":"https://api.github.com/repos/ncdc/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/ncdc/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/ncdc/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/ncdc/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ncdc/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/ncdc/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/ncdc/kubernetes/deployments","created_at":"2014-07-22T18:49:30Z","updated_at":"2016-04-18T17:04:57Z","pushed_at":"2016-12-23T01:45:38Z","git_url":"git://github.com/ncdc/kubernetes.git","ssh_url":"git@github.com:ncdc/kubernetes.git","clone_url":"https://github.com/ncdc/kubernetes.git","svn_url":"https://github.com/ncdc/kubernetes","homepage":null,"size":370511,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"dba16d052ccc04ddfbb4b0dd6c0bbd1d4c876729","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-12-23T03:10:06Z","pushed_at":"2016-12-23T03:36:26Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":480217,"stargazers_count":19431,"watchers_count":19431,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6512,"mirror_url":null,"open_issues_count":5442,"forks":6512,"open_issues":5442,"watchers":19431,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37296"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/37296"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/37296"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/37296/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37296/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37296/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/f0247ea595b2682ee4170cf201ef4efecb174b44"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars.githubusercontent.com/u/13653959?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"commits":1,"additions":6,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"k8s-merge-robot"}}