{"action":"created","comment":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/comments/79086137","id":79086137,"diff_hunk":"@@ -0,0 +1,213 @@\n+package store\n+\n+import (\n+\t\"strings\"\n+\n+\t\"github.com/docker/swarmkit/api\"\n+\t\"github.com/docker/swarmkit/manager/state\"\n+\tmemdb \"github.com/hashicorp/go-memdb\"\n+)\n+\n+const tableSecret = \"secret\"\n+\n+func init() {\n+\tregister(ObjectStoreConfig{\n+\t\tName: tableSecret,\n+\t\tTable: &memdb.TableSchema{\n+\t\t\tName: tableSecret,\n+\t\t\tIndexes: map[string]*memdb.IndexSchema{\n+\t\t\t\tindexID: {\n+\t\t\t\t\tName:    indexID,\n+\t\t\t\t\tUnique:  true,\n+\t\t\t\t\tIndexer: secretIndexerByID{},\n+\t\t\t\t},\n+\t\t\t\tindexName: {\n+\t\t\t\t\tName:    indexName,\n+\t\t\t\t\tUnique:  true,","path":"manager/state/store/secrets.go","position":null,"original_position":26,"commit_id":"d2028a9819e57ca144db33e1b859eb54352d4d80","original_commit_id":"08b109f80b2fd62dd283229bc88a9faab1705721","user":{"login":"cyli","id":223200,"avatar_url":"https://avatars.githubusercontent.com/u/223200?v=3","gravatar_id":"","url":"https://api.github.com/users/cyli","html_url":"https://github.com/cyli","followers_url":"https://api.github.com/users/cyli/followers","following_url":"https://api.github.com/users/cyli/following{/other_user}","gists_url":"https://api.github.com/users/cyli/gists{/gist_id}","starred_url":"https://api.github.com/users/cyli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyli/subscriptions","organizations_url":"https://api.github.com/users/cyli/orgs","repos_url":"https://api.github.com/users/cyli/repos","events_url":"https://api.github.com/users/cyli/events{/privacy}","received_events_url":"https://api.github.com/users/cyli/received_events","type":"User","site_admin":false},"body":"Removed","created_at":"2016-09-15T23:52:30Z","updated_at":"2016-09-15T23:52:30Z","html_url":"https://github.com/docker/swarmkit/pull/1544#discussion_r79086137","pull_request_url":"https://api.github.com/repos/docker/swarmkit/pulls/1544","_links":{"self":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/comments/79086137"},"html":{"href":"https://github.com/docker/swarmkit/pull/1544#discussion_r79086137"},"pull_request":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1544"}}},"pull_request":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/1544","id":85491842,"html_url":"https://github.com/docker/swarmkit/pull/1544","diff_url":"https://github.com/docker/swarmkit/pull/1544.diff","patch_url":"https://github.com/docker/swarmkit/pull/1544.patch","issue_url":"https://api.github.com/repos/docker/swarmkit/issues/1544","number":1544,"state":"open","locked":false,"title":"Deliver secrets using assignments","user":{"login":"cyli","id":223200,"avatar_url":"https://avatars.githubusercontent.com/u/223200?v=3","gravatar_id":"","url":"https://api.github.com/users/cyli","html_url":"https://github.com/cyli","followers_url":"https://api.github.com/users/cyli/followers","following_url":"https://api.github.com/users/cyli/following{/other_user}","gists_url":"https://api.github.com/users/cyli/gists{/gist_id}","starred_url":"https://api.github.com/users/cyli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyli/subscriptions","organizations_url":"https://api.github.com/users/cyli/orgs","repos_url":"https://api.github.com/users/cyli/repos","events_url":"https://api.github.com/users/cyli/events{/privacy}","received_events_url":"https://api.github.com/users/cyli/received_events","type":"User","site_admin":false},"body":"Depends on #1511 (as in, this is stacked on top of the changes in #1511)\r\n\r\nThis adds secrets to the raft store, and implements dispatching of secrets.","created_at":"2016-09-15T22:28:59Z","updated_at":"2016-09-15T23:52:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0f555e4fe5ccfb3b26050bbe9b28757ba3894a9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/swarmkit/pulls/1544/commits","review_comments_url":"https://api.github.com/repos/docker/swarmkit/pulls/1544/comments","review_comment_url":"https://api.github.com/repos/docker/swarmkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/swarmkit/issues/1544/comments","statuses_url":"https://api.github.com/repos/docker/swarmkit/statuses/d2028a9819e57ca144db33e1b859eb54352d4d80","head":{"label":"cyli:assignments-with-secrets","ref":"assignments-with-secrets","sha":"d2028a9819e57ca144db33e1b859eb54352d4d80","user":{"login":"cyli","id":223200,"avatar_url":"https://avatars.githubusercontent.com/u/223200?v=3","gravatar_id":"","url":"https://api.github.com/users/cyli","html_url":"https://github.com/cyli","followers_url":"https://api.github.com/users/cyli/followers","following_url":"https://api.github.com/users/cyli/following{/other_user}","gists_url":"https://api.github.com/users/cyli/gists{/gist_id}","starred_url":"https://api.github.com/users/cyli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyli/subscriptions","organizations_url":"https://api.github.com/users/cyli/orgs","repos_url":"https://api.github.com/users/cyli/repos","events_url":"https://api.github.com/users/cyli/events{/privacy}","received_events_url":"https://api.github.com/users/cyli/received_events","type":"User","site_admin":false},"repo":{"id":66887622,"name":"swarmkit","full_name":"cyli/swarmkit","owner":{"login":"cyli","id":223200,"avatar_url":"https://avatars.githubusercontent.com/u/223200?v=3","gravatar_id":"","url":"https://api.github.com/users/cyli","html_url":"https://github.com/cyli","followers_url":"https://api.github.com/users/cyli/followers","following_url":"https://api.github.com/users/cyli/following{/other_user}","gists_url":"https://api.github.com/users/cyli/gists{/gist_id}","starred_url":"https://api.github.com/users/cyli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyli/subscriptions","organizations_url":"https://api.github.com/users/cyli/orgs","repos_url":"https://api.github.com/users/cyli/repos","events_url":"https://api.github.com/users/cyli/events{/privacy}","received_events_url":"https://api.github.com/users/cyli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cyli/swarmkit","description":"A toolkit for orchestrating distributed systems at any scale. It includes primitives for node discovery, raft-based consensus, task scheduling and more.","fork":true,"url":"https://api.github.com/repos/cyli/swarmkit","forks_url":"https://api.github.com/repos/cyli/swarmkit/forks","keys_url":"https://api.github.com/repos/cyli/swarmkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyli/swarmkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyli/swarmkit/teams","hooks_url":"https://api.github.com/repos/cyli/swarmkit/hooks","issue_events_url":"https://api.github.com/repos/cyli/swarmkit/issues/events{/number}","events_url":"https://api.github.com/repos/cyli/swarmkit/events","assignees_url":"https://api.github.com/repos/cyli/swarmkit/assignees{/user}","branches_url":"https://api.github.com/repos/cyli/swarmkit/branches{/branch}","tags_url":"https://api.github.com/repos/cyli/swarmkit/tags","blobs_url":"https://api.github.com/repos/cyli/swarmkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyli/swarmkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyli/swarmkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyli/swarmkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyli/swarmkit/statuses/{sha}","languages_url":"https://api.github.com/repos/cyli/swarmkit/languages","stargazers_url":"https://api.github.com/repos/cyli/swarmkit/stargazers","contributors_url":"https://api.github.com/repos/cyli/swarmkit/contributors","subscribers_url":"https://api.github.com/repos/cyli/swarmkit/subscribers","subscription_url":"https://api.github.com/repos/cyli/swarmkit/subscription","commits_url":"https://api.github.com/repos/cyli/swarmkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyli/swarmkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyli/swarmkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyli/swarmkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyli/swarmkit/contents/{+path}","compare_url":"https://api.github.com/repos/cyli/swarmkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyli/swarmkit/merges","archive_url":"https://api.github.com/repos/cyli/swarmkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyli/swarmkit/downloads","issues_url":"https://api.github.com/repos/cyli/swarmkit/issues{/number}","pulls_url":"https://api.github.com/repos/cyli/swarmkit/pulls{/number}","milestones_url":"https://api.github.com/repos/cyli/swarmkit/milestones{/number}","notifications_url":"https://api.github.com/repos/cyli/swarmkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyli/swarmkit/labels{/name}","releases_url":"https://api.github.com/repos/cyli/swarmkit/releases{/id}","deployments_url":"https://api.github.com/repos/cyli/swarmkit/deployments","created_at":"2016-08-29T23:13:03Z","updated_at":"2016-08-29T23:13:05Z","pushed_at":"2016-09-15T23:48:54Z","git_url":"git://github.com/cyli/swarmkit.git","ssh_url":"git@github.com:cyli/swarmkit.git","clone_url":"https://github.com/cyli/swarmkit.git","svn_url":"https://github.com/cyli/swarmkit","homepage":"","size":10249,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"65af901871a9c1d80b5ccc81a62f6e9fee25d53e","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":51556828,"name":"swarmkit","full_name":"docker/swarmkit","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/swarmkit","description":"A toolkit for orchestrating distributed systems at any scale. It includes primitives for node discovery, raft-based consensus, task scheduling and more.","fork":false,"url":"https://api.github.com/repos/docker/swarmkit","forks_url":"https://api.github.com/repos/docker/swarmkit/forks","keys_url":"https://api.github.com/repos/docker/swarmkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/swarmkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/swarmkit/teams","hooks_url":"https://api.github.com/repos/docker/swarmkit/hooks","issue_events_url":"https://api.github.com/repos/docker/swarmkit/issues/events{/number}","events_url":"https://api.github.com/repos/docker/swarmkit/events","assignees_url":"https://api.github.com/repos/docker/swarmkit/assignees{/user}","branches_url":"https://api.github.com/repos/docker/swarmkit/branches{/branch}","tags_url":"https://api.github.com/repos/docker/swarmkit/tags","blobs_url":"https://api.github.com/repos/docker/swarmkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/swarmkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/swarmkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/swarmkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/swarmkit/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/swarmkit/languages","stargazers_url":"https://api.github.com/repos/docker/swarmkit/stargazers","contributors_url":"https://api.github.com/repos/docker/swarmkit/contributors","subscribers_url":"https://api.github.com/repos/docker/swarmkit/subscribers","subscription_url":"https://api.github.com/repos/docker/swarmkit/subscription","commits_url":"https://api.github.com/repos/docker/swarmkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/swarmkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/swarmkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/swarmkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/swarmkit/contents/{+path}","compare_url":"https://api.github.com/repos/docker/swarmkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/swarmkit/merges","archive_url":"https://api.github.com/repos/docker/swarmkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/swarmkit/downloads","issues_url":"https://api.github.com/repos/docker/swarmkit/issues{/number}","pulls_url":"https://api.github.com/repos/docker/swarmkit/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/swarmkit/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/swarmkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/swarmkit/labels{/name}","releases_url":"https://api.github.com/repos/docker/swarmkit/releases{/id}","deployments_url":"https://api.github.com/repos/docker/swarmkit/deployments","created_at":"2016-02-12T00:02:15Z","updated_at":"2016-09-14T06:42:31Z","pushed_at":"2016-09-15T23:48:55Z","git_url":"git://github.com/docker/swarmkit.git","ssh_url":"git@github.com:docker/swarmkit.git","clone_url":"https://github.com/docker/swarmkit.git","svn_url":"https://github.com/docker/swarmkit","homepage":"","size":21219,"stargazers_count":938,"watchers_count":938,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":177,"mirror_url":null,"open_issues_count":179,"forks":177,"open_issues":179,"watchers":938,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1544"},"html":{"href":"https://github.com/docker/swarmkit/pull/1544"},"issue":{"href":"https://api.github.com/repos/docker/swarmkit/issues/1544"},"comments":{"href":"https://api.github.com/repos/docker/swarmkit/issues/1544/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1544/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/1544/commits"},"statuses":{"href":"https://api.github.com/repos/docker/swarmkit/statuses/d2028a9819e57ca144db33e1b859eb54352d4d80"}}}}
{"actor":{"display_login":"cyli"}}