{"action":"created","issue":{"url":"https://api.github.com/repos/rstudio/rstudio/issues/764","repository_url":"https://api.github.com/repos/rstudio/rstudio","labels_url":"https://api.github.com/repos/rstudio/rstudio/issues/764/labels{/name}","comments_url":"https://api.github.com/repos/rstudio/rstudio/issues/764/comments","events_url":"https://api.github.com/repos/rstudio/rstudio/issues/764/events","html_url":"https://github.com/rstudio/rstudio/pull/764","id":173055250,"number":764,"title":"Enable implementors of .DollarNames to return types","user":{"login":"jjallaire","id":104391,"avatar_url":"https://avatars.githubusercontent.com/u/104391?v=3","gravatar_id":"","url":"https://api.github.com/users/jjallaire","html_url":"https://github.com/jjallaire","followers_url":"https://api.github.com/users/jjallaire/followers","following_url":"https://api.github.com/users/jjallaire/following{/other_user}","gists_url":"https://api.github.com/users/jjallaire/gists{/gist_id}","starred_url":"https://api.github.com/users/jjallaire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjallaire/subscriptions","organizations_url":"https://api.github.com/users/jjallaire/orgs","repos_url":"https://api.github.com/users/jjallaire/repos","events_url":"https://api.github.com/users/jjallaire/events{/privacy}","received_events_url":"https://api.github.com/users/jjallaire/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-08-24T20:52:14Z","updated_at":"2016-08-26T10:02:14Z","closed_at":"2016-08-25T01:21:57Z","pull_request":{"url":"https://api.github.com/repos/rstudio/rstudio/pulls/764","html_url":"https://github.com/rstudio/rstudio/pull/764","diff_url":"https://github.com/rstudio/rstudio/pull/764.diff","patch_url":"https://github.com/rstudio/rstudio/pull/764.patch"},"body":"This PR enables implementors of `.DollarNames` to provide an optional \"types\" attribute on the character vector containing the names. The types attribute should be of identical length as the names vector, and should include integer values indicating the type of each named object according to this schema: https://github.com/rstudio/rstudio/blob/master/src/cpp/session/modules/SessionRCompletions.R#L38-L69\r\n\r\nThe motivation for this PR is that by default RStudio eagerly evaluates the names returned to determine their type. However, for inter-language interfaces this isn't always ideal (i.e. evaluation could produce an expensive copy operation or evaluation might not be enough to determine the type if it's hidden behind an opaque handle of some kind).\r\n\r\n@kevinushey  @jeroenooms \r\n"},"comment":{"url":"https://api.github.com/repos/rstudio/rstudio/issues/comments/242687659","html_url":"https://github.com/rstudio/rstudio/pull/764#issuecomment-242687659","issue_url":"https://api.github.com/repos/rstudio/rstudio/issues/764","id":242687659,"user":{"login":"jeroenooms","id":216319,"avatar_url":"https://avatars.githubusercontent.com/u/216319?v=3","gravatar_id":"","url":"https://api.github.com/users/jeroenooms","html_url":"https://github.com/jeroenooms","followers_url":"https://api.github.com/users/jeroenooms/followers","following_url":"https://api.github.com/users/jeroenooms/following{/other_user}","gists_url":"https://api.github.com/users/jeroenooms/gists{/gist_id}","starred_url":"https://api.github.com/users/jeroenooms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeroenooms/subscriptions","organizations_url":"https://api.github.com/users/jeroenooms/orgs","repos_url":"https://api.github.com/users/jeroenooms/repos","events_url":"https://api.github.com/users/jeroenooms/events{/privacy}","received_events_url":"https://api.github.com/users/jeroenooms/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T10:02:14Z","updated_at":"2016-08-26T10:02:14Z","body":"The current version of `openssl` returns the `types` attribute as a string of `typeof(obj)` values. How should I convert those to integers? Do those integer values make any sense outside of Rstudio?\r\n\r\nRStudio only uses the type to pick a icon to display in the tab-complete menu, correct? What would be the value of knowing the specific S3/S4 class as Kevin proposes? Are there custom icons for particular classes?"}}
{"actor":{"display_login":"jeroenooms"}}