{"action":"created","issue":{"url":"https://api.github.com/repos/HaxeFlixel/flixel/issues/1954","repository_url":"https://api.github.com/repos/HaxeFlixel/flixel","labels_url":"https://api.github.com/repos/HaxeFlixel/flixel/issues/1954/labels{/name}","comments_url":"https://api.github.com/repos/HaxeFlixel/flixel/issues/1954/comments","events_url":"https://api.github.com/repos/HaxeFlixel/flixel/issues/1954/events","html_url":"https://github.com/HaxeFlixel/flixel/pull/1954","id":177661715,"number":1954,"title":"Another one try to fix issue #679","user":{"login":"Beeblerox","id":857406,"avatar_url":"https://avatars.githubusercontent.com/u/857406?v=3","gravatar_id":"","url":"https://api.github.com/users/Beeblerox","html_url":"https://github.com/Beeblerox","followers_url":"https://api.github.com/users/Beeblerox/followers","following_url":"https://api.github.com/users/Beeblerox/following{/other_user}","gists_url":"https://api.github.com/users/Beeblerox/gists{/gist_id}","starred_url":"https://api.github.com/users/Beeblerox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Beeblerox/subscriptions","organizations_url":"https://api.github.com/users/Beeblerox/orgs","repos_url":"https://api.github.com/users/Beeblerox/repos","events_url":"https://api.github.com/users/Beeblerox/events{/privacy}","received_events_url":"https://api.github.com/users/Beeblerox/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/HaxeFlixel/flixel/labels/Bug","name":"Bug","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/HaxeFlixel/flixel/milestones/9","html_url":"https://github.com/HaxeFlixel/flixel/milestones/4.2.0","labels_url":"https://api.github.com/repos/HaxeFlixel/flixel/milestones/9/labels","id":1725556,"number":9,"title":"4.2.0","description":"","creator":{"login":"Gama11","id":2620907,"avatar_url":"https://avatars.githubusercontent.com/u/2620907?v=3","gravatar_id":"","url":"https://api.github.com/users/Gama11","html_url":"https://github.com/Gama11","followers_url":"https://api.github.com/users/Gama11/followers","following_url":"https://api.github.com/users/Gama11/following{/other_user}","gists_url":"https://api.github.com/users/Gama11/gists{/gist_id}","starred_url":"https://api.github.com/users/Gama11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gama11/subscriptions","organizations_url":"https://api.github.com/users/Gama11/orgs","repos_url":"https://api.github.com/users/Gama11/repos","events_url":"https://api.github.com/users/Gama11/events{/privacy}","received_events_url":"https://api.github.com/users/Gama11/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":33,"state":"open","created_at":"2016-04-22T16:27:06Z","updated_at":"2016-09-18T16:42:52Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-09-18T16:35:46Z","updated_at":"2016-09-18T17:31:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/HaxeFlixel/flixel/pulls/1954","html_url":"https://github.com/HaxeFlixel/flixel/pull/1954","diff_url":"https://github.com/HaxeFlixel/flixel/pull/1954.diff","patch_url":"https://github.com/HaxeFlixel/flixel/pull/1954.patch"},"body":"I've made mistake in my previous PR (inserted while loop in wrong place).\r\nThis PR request also changes `completeAll()` method. Previous version of this method doesn't take into account the value of `active` property of timer. This could lead to infinite loop (maybe i'm wrong about this), because without check of `active` value it adds inactive timers to `timersToFinish` array, which won't finish (there is check in timer's update method).\r\nAnd thus i have a question: Do we need to activate paused timers and force them to finish or should we complete only active timers. I could add some parameter to `completeAll()` which will be responsible for this behavior, like `includeInactive:Bool = false`"},"comment":{"url":"https://api.github.com/repos/HaxeFlixel/flixel/issues/comments/247861236","html_url":"https://github.com/HaxeFlixel/flixel/pull/1954#issuecomment-247861236","issue_url":"https://api.github.com/repos/HaxeFlixel/flixel/issues/1954","id":247861236,"user":{"login":"Gama11","id":2620907,"avatar_url":"https://avatars.githubusercontent.com/u/2620907?v=3","gravatar_id":"","url":"https://api.github.com/users/Gama11","html_url":"https://github.com/Gama11","followers_url":"https://api.github.com/users/Gama11/followers","following_url":"https://api.github.com/users/Gama11/following{/other_user}","gists_url":"https://api.github.com/users/Gama11/gists{/gist_id}","starred_url":"https://api.github.com/users/Gama11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gama11/subscriptions","organizations_url":"https://api.github.com/users/Gama11/orgs","repos_url":"https://api.github.com/users/Gama11/repos","events_url":"https://api.github.com/users/Gama11/events{/privacy}","received_events_url":"https://api.github.com/users/Gama11/received_events","type":"User","site_admin":false},"created_at":"2016-09-18T17:31:51Z","updated_at":"2016-09-18T17:31:51Z","body":"`No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself.` - the unit tests are hanging again. Have you tried running them locally?"}}
{"actor":{"display_login":"Gama11"}}