{"action":"created","issue":{"url":"https://api.github.com/repos/dseuss/mpnum/issues/29","repository_url":"https://api.github.com/repos/dseuss/mpnum","labels_url":"https://api.github.com/repos/dseuss/mpnum/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/dseuss/mpnum/issues/29/comments","events_url":"https://api.github.com/repos/dseuss/mpnum/issues/29/events","html_url":"https://github.com/dseuss/mpnum/issues/29","id":195712019,"number":29,"title":"Unwanted canonical form in tests","user":{"login":"dseuss","id":5870291,"avatar_url":"https://avatars.githubusercontent.com/u/5870291?v=3","gravatar_id":"","url":"https://api.github.com/users/dseuss","html_url":"https://github.com/dseuss","followers_url":"https://api.github.com/users/dseuss/followers","following_url":"https://api.github.com/users/dseuss/following{/other_user}","gists_url":"https://api.github.com/users/dseuss/gists{/gist_id}","starred_url":"https://api.github.com/users/dseuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dseuss/subscriptions","organizations_url":"https://api.github.com/users/dseuss/orgs","repos_url":"https://api.github.com/users/dseuss/repos","events_url":"https://api.github.com/users/dseuss/events{/privacy}","received_events_url":"https://api.github.com/users/dseuss/received_events","type":"User","site_admin":false},"labels":[{"id":338852828,"url":"https://api.github.com/repos/dseuss/mpnum/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-15T04:02:04Z","updated_at":"2016-12-19T08:08:48Z","closed_at":"2016-12-19T08:08:48Z","body":"I just noticed that many tests still use s.th. like\r\n\r\n    mps = random_mpa(...)\r\n    mps /= mp.norm(mps)\r\n\r\nThis is a bad idea since the call to norm brings the mps into full left-canoncial form, which might be unintended. So the somewhat right call would be\r\n\r\n    mps /= mp.norm(mps.copy())\r\n\r\nHowever, the correct thing to do is to use the `normalized=True` argument provided by most factory functions. "},"comment":{"url":"https://api.github.com/repos/dseuss/mpnum/issues/comments/267904783","html_url":"https://github.com/dseuss/mpnum/issues/29#issuecomment-267904783","issue_url":"https://api.github.com/repos/dseuss/mpnum/issues/29","id":267904783,"user":{"login":"dseuss","id":5870291,"avatar_url":"https://avatars.githubusercontent.com/u/5870291?v=3","gravatar_id":"","url":"https://api.github.com/users/dseuss","html_url":"https://github.com/dseuss","followers_url":"https://api.github.com/users/dseuss/followers","following_url":"https://api.github.com/users/dseuss/following{/other_user}","gists_url":"https://api.github.com/users/dseuss/gists{/gist_id}","starred_url":"https://api.github.com/users/dseuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dseuss/subscriptions","organizations_url":"https://api.github.com/users/dseuss/orgs","repos_url":"https://api.github.com/users/dseuss/repos","events_url":"https://api.github.com/users/dseuss/events{/privacy}","received_events_url":"https://api.github.com/users/dseuss/received_events","type":"User","site_admin":false},"created_at":"2016-12-19T08:08:48Z","updated_at":"2016-12-19T08:08:48Z","body":"Fixed in ade14b6."}}
{"actor":{"display_login":"dseuss"}}