{"action":"created","issue":{"url":"https://api.github.com/repos/zopefoundation/persistent/issues/43","repository_url":"https://api.github.com/repos/zopefoundation/persistent","labels_url":"https://api.github.com/repos/zopefoundation/persistent/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/zopefoundation/persistent/issues/43/comments","events_url":"https://api.github.com/repos/zopefoundation/persistent/issues/43/events","html_url":"https://github.com/zopefoundation/persistent/issues/43","id":164599665,"number":43,"title":"Distribute the CFFI ring implementation in the wheels?","user":{"login":"jamadden","id":1256082,"avatar_url":"https://avatars.githubusercontent.com/u/1256082?v=3","gravatar_id":"","url":"https://api.github.com/users/jamadden","html_url":"https://github.com/jamadden","followers_url":"https://api.github.com/users/jamadden/followers","following_url":"https://api.github.com/users/jamadden/following{/other_user}","gists_url":"https://api.github.com/users/jamadden/gists{/gist_id}","starred_url":"https://api.github.com/users/jamadden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamadden/subscriptions","organizations_url":"https://api.github.com/users/jamadden/orgs","repos_url":"https://api.github.com/users/jamadden/repos","events_url":"https://api.github.com/users/jamadden/events{/privacy}","received_events_url":"https://api.github.com/users/jamadden/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/zopefoundation/persistent/labels/question","name":"question","color":"cc317c"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-08T19:25:57Z","updated_at":"2016-08-10T17:27:12Z","closed_at":null,"body":"This is mostly a problem for PyPy users on Windows (who probably don't have compilers).\r\n\r\nWe should be able to do this with this snippet in `setup.py` (having made sure to install CFFI and zope.interface first; the zope.interface requirement could be dropped with some refactoring):\r\n\r\n```\r\ntry:\r\n    import cffi\r\n    import persistent.ring\r\nexcept ImportError:\r\n    pass\r\nelse:\r\n    ext_modules.append(persistent.ring.ffi.verifier.get_extension())\r\n```\r\nThat should work back to PyPy 2.5.1 or so, which is the version on Travis.\r\n\r\nNow the second half of this is that we don't distribute PyPy wheels, so to meet the stated purpose we'd also need to do that (at least on Windows)\r\n"},"comment":{"url":"https://api.github.com/repos/zopefoundation/persistent/issues/comments/238940367","html_url":"https://github.com/zopefoundation/persistent/issues/43#issuecomment-238940367","issue_url":"https://api.github.com/repos/zopefoundation/persistent/issues/43","id":238940367,"user":{"login":"tseaver","id":242750,"avatar_url":"https://avatars.githubusercontent.com/u/242750?v=3","gravatar_id":"","url":"https://api.github.com/users/tseaver","html_url":"https://github.com/tseaver","followers_url":"https://api.github.com/users/tseaver/followers","following_url":"https://api.github.com/users/tseaver/following{/other_user}","gists_url":"https://api.github.com/users/tseaver/gists{/gist_id}","starred_url":"https://api.github.com/users/tseaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tseaver/subscriptions","organizations_url":"https://api.github.com/users/tseaver/orgs","repos_url":"https://api.github.com/users/tseaver/repos","events_url":"https://api.github.com/users/tseaver/events{/privacy}","received_events_url":"https://api.github.com/users/tseaver/received_events","type":"User","site_admin":false},"created_at":"2016-08-10T17:27:12Z","updated_at":"2016-08-10T17:27:12Z","body":"Importing the module-to-be-installed in `setup.py` feels icky to me.  Can we use something from @dstufft's [CFFI blog post](https://caremad.io/2015/06/distributing-a-cffi-project-redux/)?\r\n\r\nAlso, for Windows PyPy users, why would they want the CFFI ring, if the deque version is only faster for CPython?"}}
{"actor":{"display_login":"tseaver"}}