{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/core/pulls/comments/55714864","id":55714864,"diff_hunk":"@@ -11,12 +11,13 @@\n \n   <IfModule mod_env.c>\n     # Add security and privacy related headers\n-    Header set X-Content-Type-Options \"nosniff\"\n-    Header set X-XSS-Protection \"1; mode=block\"\n-    Header set X-Robots-Tag \"none\"\n-    Header set X-Frame-Options \"SAMEORIGIN\"\n-    Header set X-Download-Options \"noopen\"\n-    Header set X-Permitted-Cross-Domain-Policies \"none\"\n+    Header always set X-Content-Type-Options \"nosniff\"","path":".htaccess","position":10,"original_position":10,"commit_id":"167ca4e922dcbe68fccc7db05d9656b48a980473","original_commit_id":"167ca4e922dcbe68fccc7db05d9656b48a980473","user":{"login":"RealRancor","id":2248459,"avatar_url":"https://avatars.githubusercontent.com/u/2248459?v=3","gravatar_id":"","url":"https://api.github.com/users/RealRancor","html_url":"https://github.com/RealRancor","followers_url":"https://api.github.com/users/RealRancor/followers","following_url":"https://api.github.com/users/RealRancor/following{/other_user}","gists_url":"https://api.github.com/users/RealRancor/gists{/gist_id}","starred_url":"https://api.github.com/users/RealRancor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RealRancor/subscriptions","organizations_url":"https://api.github.com/users/RealRancor/orgs","repos_url":"https://api.github.com/users/RealRancor/repos","events_url":"https://api.github.com/users/RealRancor/events{/privacy}","received_events_url":"https://api.github.com/users/RealRancor/received_events","type":"User","site_admin":false},"body":"IIRC a \"Header always set\" will duplicate the headers if they are also set in the main apache config.","created_at":"2016-03-10T17:20:25Z","updated_at":"2016-03-10T17:20:25Z","html_url":"https://github.com/owncloud/core/pull/23115#discussion_r55714864","pull_request_url":"https://api.github.com/repos/owncloud/core/pulls/23115","_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/55714864"},"html":{"href":"https://github.com/owncloud/core/pull/23115#discussion_r55714864"},"pull_request":{"href":"https://api.github.com/repos/owncloud/core/pulls/23115"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/23115","id":62421915,"html_url":"https://github.com/owncloud/core/pull/23115","diff_url":"https://github.com/owncloud/core/pull/23115.diff","patch_url":"https://github.com/owncloud/core/pull/23115.patch","issue_url":"https://api.github.com/repos/owncloud/core/issues/23115","number":23115,"state":"open","locked":false,"title":"Update security headers in .htaccess","user":{"login":"wagnerand","id":873258,"avatar_url":"https://avatars.githubusercontent.com/u/873258?v=3","gravatar_id":"","url":"https://api.github.com/users/wagnerand","html_url":"https://github.com/wagnerand","followers_url":"https://api.github.com/users/wagnerand/followers","following_url":"https://api.github.com/users/wagnerand/following{/other_user}","gists_url":"https://api.github.com/users/wagnerand/gists{/gist_id}","starred_url":"https://api.github.com/users/wagnerand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wagnerand/subscriptions","organizations_url":"https://api.github.com/users/wagnerand/orgs","repos_url":"https://api.github.com/users/wagnerand/repos","events_url":"https://api.github.com/users/wagnerand/events{/privacy}","received_events_url":"https://api.github.com/users/wagnerand/received_events","type":"User","site_admin":false},"body":"I'd like to propose the following change to .htaccess:\r\n\r\n* use `always` so they are set in even in shared environments where you don't have access to the apache host config.\r\n* Add `Strict-Transport-Security` header as recommended in the docs: https://doc.owncloud.org/server/9.0/admin_manual/configuration_server/harden_server.html","created_at":"2016-03-10T17:02:21Z","updated_at":"2016-03-10T17:20:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8afbd5bc3fe6796d3d49bb16c0ff8b78a46cef20","assignee":{"login":"LukasReschke","id":878997,"avatar_url":"https://avatars.githubusercontent.com/u/878997?v=3","gravatar_id":"","url":"https://api.github.com/users/LukasReschke","html_url":"https://github.com/LukasReschke","followers_url":"https://api.github.com/users/LukasReschke/followers","following_url":"https://api.github.com/users/LukasReschke/following{/other_user}","gists_url":"https://api.github.com/users/LukasReschke/gists{/gist_id}","starred_url":"https://api.github.com/users/LukasReschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukasReschke/subscriptions","organizations_url":"https://api.github.com/users/LukasReschke/orgs","repos_url":"https://api.github.com/users/LukasReschke/repos","events_url":"https://api.github.com/users/LukasReschke/events{/privacy}","received_events_url":"https://api.github.com/users/LukasReschke/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/core/pulls/23115/commits","review_comments_url":"https://api.github.com/repos/owncloud/core/pulls/23115/comments","review_comment_url":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/core/issues/23115/comments","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/167ca4e922dcbe68fccc7db05d9656b48a980473","head":{"label":"wagnerand:patch-1","ref":"patch-1","sha":"167ca4e922dcbe68fccc7db05d9656b48a980473","user":{"login":"wagnerand","id":873258,"avatar_url":"https://avatars.githubusercontent.com/u/873258?v=3","gravatar_id":"","url":"https://api.github.com/users/wagnerand","html_url":"https://github.com/wagnerand","followers_url":"https://api.github.com/users/wagnerand/followers","following_url":"https://api.github.com/users/wagnerand/following{/other_user}","gists_url":"https://api.github.com/users/wagnerand/gists{/gist_id}","starred_url":"https://api.github.com/users/wagnerand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wagnerand/subscriptions","organizations_url":"https://api.github.com/users/wagnerand/orgs","repos_url":"https://api.github.com/users/wagnerand/repos","events_url":"https://api.github.com/users/wagnerand/events{/privacy}","received_events_url":"https://api.github.com/users/wagnerand/received_events","type":"User","site_admin":false},"repo":{"id":53601752,"name":"core","full_name":"wagnerand/core","owner":{"login":"wagnerand","id":873258,"avatar_url":"https://avatars.githubusercontent.com/u/873258?v=3","gravatar_id":"","url":"https://api.github.com/users/wagnerand","html_url":"https://github.com/wagnerand","followers_url":"https://api.github.com/users/wagnerand/followers","following_url":"https://api.github.com/users/wagnerand/following{/other_user}","gists_url":"https://api.github.com/users/wagnerand/gists{/gist_id}","starred_url":"https://api.github.com/users/wagnerand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wagnerand/subscriptions","organizations_url":"https://api.github.com/users/wagnerand/orgs","repos_url":"https://api.github.com/users/wagnerand/repos","events_url":"https://api.github.com/users/wagnerand/events{/privacy}","received_events_url":"https://api.github.com/users/wagnerand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wagnerand/core","description":"The ownCloud core","fork":true,"url":"https://api.github.com/repos/wagnerand/core","forks_url":"https://api.github.com/repos/wagnerand/core/forks","keys_url":"https://api.github.com/repos/wagnerand/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wagnerand/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wagnerand/core/teams","hooks_url":"https://api.github.com/repos/wagnerand/core/hooks","issue_events_url":"https://api.github.com/repos/wagnerand/core/issues/events{/number}","events_url":"https://api.github.com/repos/wagnerand/core/events","assignees_url":"https://api.github.com/repos/wagnerand/core/assignees{/user}","branches_url":"https://api.github.com/repos/wagnerand/core/branches{/branch}","tags_url":"https://api.github.com/repos/wagnerand/core/tags","blobs_url":"https://api.github.com/repos/wagnerand/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wagnerand/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wagnerand/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wagnerand/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wagnerand/core/statuses/{sha}","languages_url":"https://api.github.com/repos/wagnerand/core/languages","stargazers_url":"https://api.github.com/repos/wagnerand/core/stargazers","contributors_url":"https://api.github.com/repos/wagnerand/core/contributors","subscribers_url":"https://api.github.com/repos/wagnerand/core/subscribers","subscription_url":"https://api.github.com/repos/wagnerand/core/subscription","commits_url":"https://api.github.com/repos/wagnerand/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wagnerand/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wagnerand/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wagnerand/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/wagnerand/core/contents/{+path}","compare_url":"https://api.github.com/repos/wagnerand/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wagnerand/core/merges","archive_url":"https://api.github.com/repos/wagnerand/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wagnerand/core/downloads","issues_url":"https://api.github.com/repos/wagnerand/core/issues{/number}","pulls_url":"https://api.github.com/repos/wagnerand/core/pulls{/number}","milestones_url":"https://api.github.com/repos/wagnerand/core/milestones{/number}","notifications_url":"https://api.github.com/repos/wagnerand/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wagnerand/core/labels{/name}","releases_url":"https://api.github.com/repos/wagnerand/core/releases{/id}","deployments_url":"https://api.github.com/repos/wagnerand/core/deployments","created_at":"2016-03-10T16:56:32Z","updated_at":"2016-03-10T16:56:46Z","pushed_at":"2016-03-10T17:02:15Z","git_url":"git://github.com/wagnerand/core.git","ssh_url":"git@github.com:wagnerand/core.git","clone_url":"https://github.com/wagnerand/core.git","svn_url":"https://github.com/wagnerand/core","homepage":"https://owncloud.org/","size":203282,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"7f16aaefc8ea52ce258742f02b0bbe70753eecb9","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":"The ownCloud core","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/core/deployments","created_at":"2012-08-25T10:32:48Z","updated_at":"2016-03-10T15:09:11Z","pushed_at":"2016-03-10T17:02:22Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":"https://owncloud.org/","size":295385,"stargazers_count":4247,"watchers_count":4247,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1385,"mirror_url":null,"open_issues_count":1727,"forks":1385,"open_issues":1727,"watchers":4247,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/23115"},"html":{"href":"https://github.com/owncloud/core/pull/23115"},"issue":{"href":"https://api.github.com/repos/owncloud/core/issues/23115"},"comments":{"href":"https://api.github.com/repos/owncloud/core/issues/23115/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/core/pulls/23115/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/core/pulls/23115/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/core/statuses/167ca4e922dcbe68fccc7db05d9656b48a980473"}}}}