{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/pinot/pulls/comments/78874669","id":78874669,"diff_hunk":"@@ -57,7 +57,7 @@\n   private final SelectionColumnIterator[] selectionColumnIterators;\n \n   public SelectionFetcher(Block[] blocks, DataSchema dataSchema) {\n-    this.length = blocks.length;\n+    this.length = dataSchema.size();","path":"pinot-core/src/main/java/com/linkedin/pinot/core/query/selection/SelectionFetcher.java","position":null,"original_position":5,"commit_id":"f3ad96996a1756234bd6fe586837e0348620f960","original_commit_id":"4b69128dd41edff7740be9e4e8d50a9897ad54ee","user":{"login":"victor2100","id":1632918,"avatar_url":"https://avatars.githubusercontent.com/u/1632918?v=3","gravatar_id":"","url":"https://api.github.com/users/victor2100","html_url":"https://github.com/victor2100","followers_url":"https://api.github.com/users/victor2100/followers","following_url":"https://api.github.com/users/victor2100/following{/other_user}","gists_url":"https://api.github.com/users/victor2100/gists{/gist_id}","starred_url":"https://api.github.com/users/victor2100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victor2100/subscriptions","organizations_url":"https://api.github.com/users/victor2100/orgs","repos_url":"https://api.github.com/users/victor2100/repos","events_url":"https://api.github.com/users/victor2100/events{/privacy}","received_events_url":"https://api.github.com/users/victor2100/received_events","type":"User","site_admin":false},"body":"Yes, this should not be changed. From the logic we assume  blocks.length == dataschema.size(). I updated the code and you can take a look at it.","created_at":"2016-09-15T01:20:18Z","updated_at":"2016-09-15T01:20:18Z","html_url":"https://github.com/linkedin/pinot/pull/546#discussion_r78874669","pull_request_url":"https://api.github.com/repos/linkedin/pinot/pulls/546","_links":{"self":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/comments/78874669"},"html":{"href":"https://github.com/linkedin/pinot/pull/546#discussion_r78874669"},"pull_request":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/546"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/pinot/pulls/546","id":85327977,"html_url":"https://github.com/linkedin/pinot/pull/546","diff_url":"https://github.com/linkedin/pinot/pull/546.diff","patch_url":"https://github.com/linkedin/pinot/pull/546.patch","issue_url":"https://api.github.com/repos/linkedin/pinot/issues/546","number":546,"state":"open","locked":false,"title":"make select star not show hll derived columns","user":{"login":"victor2100","id":1632918,"avatar_url":"https://avatars.githubusercontent.com/u/1632918?v=3","gravatar_id":"","url":"https://api.github.com/users/victor2100","html_url":"https://github.com/victor2100","followers_url":"https://api.github.com/users/victor2100/followers","following_url":"https://api.github.com/users/victor2100/following{/other_user}","gists_url":"https://api.github.com/users/victor2100/gists{/gist_id}","starred_url":"https://api.github.com/users/victor2100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victor2100/subscriptions","organizations_url":"https://api.github.com/users/victor2100/orgs","repos_url":"https://api.github.com/users/victor2100/repos","events_url":"https://api.github.com/users/victor2100/events{/privacy}","received_events_url":"https://api.github.com/users/victor2100/received_events","type":"User","site_admin":false},"body":"make select star not show hll derived columns","created_at":"2016-09-15T00:18:11Z","updated_at":"2016-09-15T01:20:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aaf978246c0a56649ce2b16f6c0ee8f9469efb15","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/pinot/pulls/546/commits","review_comments_url":"https://api.github.com/repos/linkedin/pinot/pulls/546/comments","review_comment_url":"https://api.github.com/repos/linkedin/pinot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/pinot/issues/546/comments","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/f3ad96996a1756234bd6fe586837e0348620f960","head":{"label":"victor2100:star_logic","ref":"star_logic","sha":"f3ad96996a1756234bd6fe586837e0348620f960","user":{"login":"victor2100","id":1632918,"avatar_url":"https://avatars.githubusercontent.com/u/1632918?v=3","gravatar_id":"","url":"https://api.github.com/users/victor2100","html_url":"https://github.com/victor2100","followers_url":"https://api.github.com/users/victor2100/followers","following_url":"https://api.github.com/users/victor2100/following{/other_user}","gists_url":"https://api.github.com/users/victor2100/gists{/gist_id}","starred_url":"https://api.github.com/users/victor2100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victor2100/subscriptions","organizations_url":"https://api.github.com/users/victor2100/orgs","repos_url":"https://api.github.com/users/victor2100/repos","events_url":"https://api.github.com/users/victor2100/events{/privacy}","received_events_url":"https://api.github.com/users/victor2100/received_events","type":"User","site_admin":false},"repo":{"id":64504291,"name":"pinot","full_name":"victor2100/pinot","owner":{"login":"victor2100","id":1632918,"avatar_url":"https://avatars.githubusercontent.com/u/1632918?v=3","gravatar_id":"","url":"https://api.github.com/users/victor2100","html_url":"https://github.com/victor2100","followers_url":"https://api.github.com/users/victor2100/followers","following_url":"https://api.github.com/users/victor2100/following{/other_user}","gists_url":"https://api.github.com/users/victor2100/gists{/gist_id}","starred_url":"https://api.github.com/users/victor2100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victor2100/subscriptions","organizations_url":"https://api.github.com/users/victor2100/orgs","repos_url":"https://api.github.com/users/victor2100/repos","events_url":"https://api.github.com/users/victor2100/events{/privacy}","received_events_url":"https://api.github.com/users/victor2100/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/victor2100/pinot","description":"A realtime distributed OLAP datastore","fork":true,"url":"https://api.github.com/repos/victor2100/pinot","forks_url":"https://api.github.com/repos/victor2100/pinot/forks","keys_url":"https://api.github.com/repos/victor2100/pinot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/victor2100/pinot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/victor2100/pinot/teams","hooks_url":"https://api.github.com/repos/victor2100/pinot/hooks","issue_events_url":"https://api.github.com/repos/victor2100/pinot/issues/events{/number}","events_url":"https://api.github.com/repos/victor2100/pinot/events","assignees_url":"https://api.github.com/repos/victor2100/pinot/assignees{/user}","branches_url":"https://api.github.com/repos/victor2100/pinot/branches{/branch}","tags_url":"https://api.github.com/repos/victor2100/pinot/tags","blobs_url":"https://api.github.com/repos/victor2100/pinot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/victor2100/pinot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/victor2100/pinot/git/refs{/sha}","trees_url":"https://api.github.com/repos/victor2100/pinot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/victor2100/pinot/statuses/{sha}","languages_url":"https://api.github.com/repos/victor2100/pinot/languages","stargazers_url":"https://api.github.com/repos/victor2100/pinot/stargazers","contributors_url":"https://api.github.com/repos/victor2100/pinot/contributors","subscribers_url":"https://api.github.com/repos/victor2100/pinot/subscribers","subscription_url":"https://api.github.com/repos/victor2100/pinot/subscription","commits_url":"https://api.github.com/repos/victor2100/pinot/commits{/sha}","git_commits_url":"https://api.github.com/repos/victor2100/pinot/git/commits{/sha}","comments_url":"https://api.github.com/repos/victor2100/pinot/comments{/number}","issue_comment_url":"https://api.github.com/repos/victor2100/pinot/issues/comments{/number}","contents_url":"https://api.github.com/repos/victor2100/pinot/contents/{+path}","compare_url":"https://api.github.com/repos/victor2100/pinot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/victor2100/pinot/merges","archive_url":"https://api.github.com/repos/victor2100/pinot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/victor2100/pinot/downloads","issues_url":"https://api.github.com/repos/victor2100/pinot/issues{/number}","pulls_url":"https://api.github.com/repos/victor2100/pinot/pulls{/number}","milestones_url":"https://api.github.com/repos/victor2100/pinot/milestones{/number}","notifications_url":"https://api.github.com/repos/victor2100/pinot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/victor2100/pinot/labels{/name}","releases_url":"https://api.github.com/repos/victor2100/pinot/releases{/id}","deployments_url":"https://api.github.com/repos/victor2100/pinot/deployments","created_at":"2016-07-29T19:06:22Z","updated_at":"2016-07-29T19:06:30Z","pushed_at":"2016-09-15T01:17:41Z","git_url":"git://github.com/victor2100/pinot.git","ssh_url":"git@github.com:victor2100/pinot.git","clone_url":"https://github.com/victor2100/pinot.git","svn_url":"https://github.com/victor2100/pinot","homepage":"https://github.com/linkedin/pinot/wiki","size":140968,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"dad58892b191d3bd25d6e1122c87aa30b6a0fff4","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":19961085,"name":"pinot","full_name":"linkedin/pinot","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/pinot","description":"A realtime distributed OLAP datastore","fork":false,"url":"https://api.github.com/repos/linkedin/pinot","forks_url":"https://api.github.com/repos/linkedin/pinot/forks","keys_url":"https://api.github.com/repos/linkedin/pinot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/pinot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/pinot/teams","hooks_url":"https://api.github.com/repos/linkedin/pinot/hooks","issue_events_url":"https://api.github.com/repos/linkedin/pinot/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/pinot/events","assignees_url":"https://api.github.com/repos/linkedin/pinot/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/pinot/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/pinot/tags","blobs_url":"https://api.github.com/repos/linkedin/pinot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/pinot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/pinot/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/pinot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/pinot/languages","stargazers_url":"https://api.github.com/repos/linkedin/pinot/stargazers","contributors_url":"https://api.github.com/repos/linkedin/pinot/contributors","subscribers_url":"https://api.github.com/repos/linkedin/pinot/subscribers","subscription_url":"https://api.github.com/repos/linkedin/pinot/subscription","commits_url":"https://api.github.com/repos/linkedin/pinot/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/pinot/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/pinot/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/pinot/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/pinot/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/pinot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/pinot/merges","archive_url":"https://api.github.com/repos/linkedin/pinot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/pinot/downloads","issues_url":"https://api.github.com/repos/linkedin/pinot/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/pinot/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/pinot/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/pinot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/pinot/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/pinot/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/pinot/deployments","created_at":"2014-05-19T23:27:48Z","updated_at":"2016-09-14T03:33:26Z","pushed_at":"2016-09-15T01:17:42Z","git_url":"git://github.com/linkedin/pinot.git","ssh_url":"git@github.com:linkedin/pinot.git","clone_url":"https://github.com/linkedin/pinot.git","svn_url":"https://github.com/linkedin/pinot","homepage":"https://github.com/linkedin/pinot/wiki","size":143872,"stargazers_count":1343,"watchers_count":1343,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":222,"mirror_url":null,"open_issues_count":82,"forks":222,"open_issues":82,"watchers":1343,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/546"},"html":{"href":"https://github.com/linkedin/pinot/pull/546"},"issue":{"href":"https://api.github.com/repos/linkedin/pinot/issues/546"},"comments":{"href":"https://api.github.com/repos/linkedin/pinot/issues/546/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/546/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/546/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/pinot/statuses/f3ad96996a1756234bd6fe586837e0348620f960"}}}}
{"actor":{"display_login":"victor2100"}}