{"action":"created","comment":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/comments/82815827","pull_request_review_id":3696453,"id":82815827,"diff_hunk":"@@ -0,0 +1,318 @@\n+# Copyright (C) 2013 Ian Harry","path":"pycbc/injcutter.py","position":1,"original_position":1,"commit_id":"cd27b991f3dff3950d24c7079b190db3fac09ff9","original_commit_id":"cd27b991f3dff3950d24c7079b190db3fac09ff9","user":{"login":"spxiwh","id":11438929,"avatar_url":"https://avatars.githubusercontent.com/u/11438929?v=3","gravatar_id":"","url":"https://api.github.com/users/spxiwh","html_url":"https://github.com/spxiwh","followers_url":"https://api.github.com/users/spxiwh/followers","following_url":"https://api.github.com/users/spxiwh/following{/other_user}","gists_url":"https://api.github.com/users/spxiwh/gists{/gist_id}","starred_url":"https://api.github.com/users/spxiwh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spxiwh/subscriptions","organizations_url":"https://api.github.com/users/spxiwh/orgs","repos_url":"https://api.github.com/users/spxiwh/repos","events_url":"https://api.github.com/users/spxiwh/events{/privacy}","received_events_url":"https://api.github.com/users/spxiwh/received_events","type":"User","site_admin":false},"body":"So to understand. Suggestion is to create an injection package and then move injcutter.py and inject.py into that package?\r\n\r\nThis will require editing all codes that use inject.py, but okay ... Just want to be sure of the suggestion first.","created_at":"2016-10-11T15:12:38Z","updated_at":"2016-10-11T15:12:39Z","html_url":"https://github.com/ligo-cbc/pycbc/pull/1109#discussion_r82815827","pull_request_url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/1109","_links":{"self":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/comments/82815827"},"html":{"href":"https://github.com/ligo-cbc/pycbc/pull/1109#discussion_r82815827"},"pull_request":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/1109"}}},"pull_request":{"url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/1109","id":86941632,"html_url":"https://github.com/ligo-cbc/pycbc/pull/1109","diff_url":"https://github.com/ligo-cbc/pycbc/pull/1109.diff","patch_url":"https://github.com/ligo-cbc/pycbc/pull/1109.patch","issue_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/1109","number":1109,"state":"open","locked":false,"title":"Implementing injcutter in PyCBC","user":{"login":"spxiwh","id":11438929,"avatar_url":"https://avatars.githubusercontent.com/u/11438929?v=3","gravatar_id":"","url":"https://api.github.com/users/spxiwh","html_url":"https://github.com/spxiwh","followers_url":"https://api.github.com/users/spxiwh/followers","following_url":"https://api.github.com/users/spxiwh/following{/other_user}","gists_url":"https://api.github.com/users/spxiwh/gists{/gist_id}","starred_url":"https://api.github.com/users/spxiwh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spxiwh/subscriptions","organizations_url":"https://api.github.com/users/spxiwh/orgs","repos_url":"https://api.github.com/users/spxiwh/repos","events_url":"https://api.github.com/users/spxiwh/events{/privacy}","received_events_url":"https://api.github.com/users/spxiwh/received_events","type":"User","site_admin":false},"body":"These are the changes to implement injcutter in PyCBC. The basic idea is that 'injcutter' is used to determine whether to filter a segment against a template based on the parameters of the template and any injections made into the segment.\r\n\r\nThere are currently two tests in injcutter (though one could add more). A chirp-time test, as previously implemented, and a coarse-match test. Using both together speeds up injection runs by over an order of magnitude in tests I've done.\r\n\r\nI'm running through some final checks with this version of the code now, to compare with and without injcutter, but I wanted to post the PR now to deal with any comments or code-quality issues. By default injcutter is not enabled, and if no injections are present it does nothing. Therefore to use this in O2 would require a few additional options ... But the resulting speedup might suggest that we would want to tune a few more settings to decrease start-up cost relative to cost doing matched-filtering.","created_at":"2016-09-27T14:30:26Z","updated_at":"2016-10-11T15:12:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84de7e5d5b8a6f692a787f819d80b59a1831ba9d","assignee":{"login":"ahnitz","id":2206534,"avatar_url":"https://avatars.githubusercontent.com/u/2206534?v=3","gravatar_id":"","url":"https://api.github.com/users/ahnitz","html_url":"https://github.com/ahnitz","followers_url":"https://api.github.com/users/ahnitz/followers","following_url":"https://api.github.com/users/ahnitz/following{/other_user}","gists_url":"https://api.github.com/users/ahnitz/gists{/gist_id}","starred_url":"https://api.github.com/users/ahnitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahnitz/subscriptions","organizations_url":"https://api.github.com/users/ahnitz/orgs","repos_url":"https://api.github.com/users/ahnitz/repos","events_url":"https://api.github.com/users/ahnitz/events{/privacy}","received_events_url":"https://api.github.com/users/ahnitz/received_events","type":"User","site_admin":false},"assignees":[{"login":"ahnitz","id":2206534,"avatar_url":"https://avatars.githubusercontent.com/u/2206534?v=3","gravatar_id":"","url":"https://api.github.com/users/ahnitz","html_url":"https://github.com/ahnitz","followers_url":"https://api.github.com/users/ahnitz/followers","following_url":"https://api.github.com/users/ahnitz/following{/other_user}","gists_url":"https://api.github.com/users/ahnitz/gists{/gist_id}","starred_url":"https://api.github.com/users/ahnitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahnitz/subscriptions","organizations_url":"https://api.github.com/users/ahnitz/orgs","repos_url":"https://api.github.com/users/ahnitz/repos","events_url":"https://api.github.com/users/ahnitz/events{/privacy}","received_events_url":"https://api.github.com/users/ahnitz/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/1109/commits","review_comments_url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/1109/comments","review_comment_url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/1109/comments","statuses_url":"https://api.github.com/repos/ligo-cbc/pycbc/statuses/cd27b991f3dff3950d24c7079b190db3fac09ff9","head":{"label":"spxiwh:injcutter","ref":"injcutter","sha":"cd27b991f3dff3950d24c7079b190db3fac09ff9","user":{"login":"spxiwh","id":11438929,"avatar_url":"https://avatars.githubusercontent.com/u/11438929?v=3","gravatar_id":"","url":"https://api.github.com/users/spxiwh","html_url":"https://github.com/spxiwh","followers_url":"https://api.github.com/users/spxiwh/followers","following_url":"https://api.github.com/users/spxiwh/following{/other_user}","gists_url":"https://api.github.com/users/spxiwh/gists{/gist_id}","starred_url":"https://api.github.com/users/spxiwh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spxiwh/subscriptions","organizations_url":"https://api.github.com/users/spxiwh/orgs","repos_url":"https://api.github.com/users/spxiwh/repos","events_url":"https://api.github.com/users/spxiwh/events{/privacy}","received_events_url":"https://api.github.com/users/spxiwh/received_events","type":"User","site_admin":false},"repo":{"id":36366656,"name":"pycbc","full_name":"spxiwh/pycbc","owner":{"login":"spxiwh","id":11438929,"avatar_url":"https://avatars.githubusercontent.com/u/11438929?v=3","gravatar_id":"","url":"https://api.github.com/users/spxiwh","html_url":"https://github.com/spxiwh","followers_url":"https://api.github.com/users/spxiwh/followers","following_url":"https://api.github.com/users/spxiwh/following{/other_user}","gists_url":"https://api.github.com/users/spxiwh/gists{/gist_id}","starred_url":"https://api.github.com/users/spxiwh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spxiwh/subscriptions","organizations_url":"https://api.github.com/users/spxiwh/orgs","repos_url":"https://api.github.com/users/spxiwh/repos","events_url":"https://api.github.com/users/spxiwh/events{/privacy}","received_events_url":"https://api.github.com/users/spxiwh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spxiwh/pycbc","description":"Python CBC Tools","fork":true,"url":"https://api.github.com/repos/spxiwh/pycbc","forks_url":"https://api.github.com/repos/spxiwh/pycbc/forks","keys_url":"https://api.github.com/repos/spxiwh/pycbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spxiwh/pycbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spxiwh/pycbc/teams","hooks_url":"https://api.github.com/repos/spxiwh/pycbc/hooks","issue_events_url":"https://api.github.com/repos/spxiwh/pycbc/issues/events{/number}","events_url":"https://api.github.com/repos/spxiwh/pycbc/events","assignees_url":"https://api.github.com/repos/spxiwh/pycbc/assignees{/user}","branches_url":"https://api.github.com/repos/spxiwh/pycbc/branches{/branch}","tags_url":"https://api.github.com/repos/spxiwh/pycbc/tags","blobs_url":"https://api.github.com/repos/spxiwh/pycbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spxiwh/pycbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spxiwh/pycbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/spxiwh/pycbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spxiwh/pycbc/statuses/{sha}","languages_url":"https://api.github.com/repos/spxiwh/pycbc/languages","stargazers_url":"https://api.github.com/repos/spxiwh/pycbc/stargazers","contributors_url":"https://api.github.com/repos/spxiwh/pycbc/contributors","subscribers_url":"https://api.github.com/repos/spxiwh/pycbc/subscribers","subscription_url":"https://api.github.com/repos/spxiwh/pycbc/subscription","commits_url":"https://api.github.com/repos/spxiwh/pycbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/spxiwh/pycbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/spxiwh/pycbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/spxiwh/pycbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/spxiwh/pycbc/contents/{+path}","compare_url":"https://api.github.com/repos/spxiwh/pycbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spxiwh/pycbc/merges","archive_url":"https://api.github.com/repos/spxiwh/pycbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spxiwh/pycbc/downloads","issues_url":"https://api.github.com/repos/spxiwh/pycbc/issues{/number}","pulls_url":"https://api.github.com/repos/spxiwh/pycbc/pulls{/number}","milestones_url":"https://api.github.com/repos/spxiwh/pycbc/milestones{/number}","notifications_url":"https://api.github.com/repos/spxiwh/pycbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spxiwh/pycbc/labels{/name}","releases_url":"https://api.github.com/repos/spxiwh/pycbc/releases{/id}","deployments_url":"https://api.github.com/repos/spxiwh/pycbc/deployments","created_at":"2015-05-27T12:53:55Z","updated_at":"2016-03-03T18:20:21Z","pushed_at":"2016-10-10T13:20:11Z","git_url":"git://github.com/spxiwh/pycbc.git","ssh_url":"git@github.com:spxiwh/pycbc.git","clone_url":"https://github.com/spxiwh/pycbc.git","svn_url":"https://github.com/spxiwh/pycbc","homepage":null,"size":27539,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"nr_precessing_devel"}},"base":{"label":"ligo-cbc:master","ref":"master","sha":"7c792d94822a7c2cc5fbccc5f50d7444167b1fde","user":{"login":"ligo-cbc","id":11262917,"avatar_url":"https://avatars.githubusercontent.com/u/11262917?v=3","gravatar_id":"","url":"https://api.github.com/users/ligo-cbc","html_url":"https://github.com/ligo-cbc","followers_url":"https://api.github.com/users/ligo-cbc/followers","following_url":"https://api.github.com/users/ligo-cbc/following{/other_user}","gists_url":"https://api.github.com/users/ligo-cbc/gists{/gist_id}","starred_url":"https://api.github.com/users/ligo-cbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligo-cbc/subscriptions","organizations_url":"https://api.github.com/users/ligo-cbc/orgs","repos_url":"https://api.github.com/users/ligo-cbc/repos","events_url":"https://api.github.com/users/ligo-cbc/events{/privacy}","received_events_url":"https://api.github.com/users/ligo-cbc/received_events","type":"Organization","site_admin":false},"repo":{"id":31596861,"name":"pycbc","full_name":"ligo-cbc/pycbc","owner":{"login":"ligo-cbc","id":11262917,"avatar_url":"https://avatars.githubusercontent.com/u/11262917?v=3","gravatar_id":"","url":"https://api.github.com/users/ligo-cbc","html_url":"https://github.com/ligo-cbc","followers_url":"https://api.github.com/users/ligo-cbc/followers","following_url":"https://api.github.com/users/ligo-cbc/following{/other_user}","gists_url":"https://api.github.com/users/ligo-cbc/gists{/gist_id}","starred_url":"https://api.github.com/users/ligo-cbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligo-cbc/subscriptions","organizations_url":"https://api.github.com/users/ligo-cbc/orgs","repos_url":"https://api.github.com/users/ligo-cbc/repos","events_url":"https://api.github.com/users/ligo-cbc/events{/privacy}","received_events_url":"https://api.github.com/users/ligo-cbc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ligo-cbc/pycbc","description":"Python CBC Tools","fork":false,"url":"https://api.github.com/repos/ligo-cbc/pycbc","forks_url":"https://api.github.com/repos/ligo-cbc/pycbc/forks","keys_url":"https://api.github.com/repos/ligo-cbc/pycbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ligo-cbc/pycbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ligo-cbc/pycbc/teams","hooks_url":"https://api.github.com/repos/ligo-cbc/pycbc/hooks","issue_events_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/events{/number}","events_url":"https://api.github.com/repos/ligo-cbc/pycbc/events","assignees_url":"https://api.github.com/repos/ligo-cbc/pycbc/assignees{/user}","branches_url":"https://api.github.com/repos/ligo-cbc/pycbc/branches{/branch}","tags_url":"https://api.github.com/repos/ligo-cbc/pycbc/tags","blobs_url":"https://api.github.com/repos/ligo-cbc/pycbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ligo-cbc/pycbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ligo-cbc/pycbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ligo-cbc/pycbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ligo-cbc/pycbc/statuses/{sha}","languages_url":"https://api.github.com/repos/ligo-cbc/pycbc/languages","stargazers_url":"https://api.github.com/repos/ligo-cbc/pycbc/stargazers","contributors_url":"https://api.github.com/repos/ligo-cbc/pycbc/contributors","subscribers_url":"https://api.github.com/repos/ligo-cbc/pycbc/subscribers","subscription_url":"https://api.github.com/repos/ligo-cbc/pycbc/subscription","commits_url":"https://api.github.com/repos/ligo-cbc/pycbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ligo-cbc/pycbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ligo-cbc/pycbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ligo-cbc/pycbc/contents/{+path}","compare_url":"https://api.github.com/repos/ligo-cbc/pycbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ligo-cbc/pycbc/merges","archive_url":"https://api.github.com/repos/ligo-cbc/pycbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ligo-cbc/pycbc/downloads","issues_url":"https://api.github.com/repos/ligo-cbc/pycbc/issues{/number}","pulls_url":"https://api.github.com/repos/ligo-cbc/pycbc/pulls{/number}","milestones_url":"https://api.github.com/repos/ligo-cbc/pycbc/milestones{/number}","notifications_url":"https://api.github.com/repos/ligo-cbc/pycbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ligo-cbc/pycbc/labels{/name}","releases_url":"https://api.github.com/repos/ligo-cbc/pycbc/releases{/id}","deployments_url":"https://api.github.com/repos/ligo-cbc/pycbc/deployments","created_at":"2015-03-03T12:19:19Z","updated_at":"2016-10-08T10:07:10Z","pushed_at":"2016-10-11T15:11:41Z","git_url":"git://github.com/ligo-cbc/pycbc.git","ssh_url":"git@github.com:ligo-cbc/pycbc.git","clone_url":"https://github.com/ligo-cbc/pycbc.git","svn_url":"https://github.com/ligo-cbc/pycbc","homepage":null,"size":183982,"stargazers_count":45,"watchers_count":45,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":86,"mirror_url":null,"open_issues_count":31,"forks":86,"open_issues":31,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/1109"},"html":{"href":"https://github.com/ligo-cbc/pycbc/pull/1109"},"issue":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/issues/1109"},"comments":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/issues/1109/comments"},"review_comments":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/1109/comments"},"review_comment":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/pulls/1109/commits"},"statuses":{"href":"https://api.github.com/repos/ligo-cbc/pycbc/statuses/cd27b991f3dff3950d24c7079b190db3fac09ff9"}}}}
{"actor":{"display_login":"spxiwh"}}