{"action":"closed","issue":{"url":"https://api.github.com/repos/kubernetes-incubator/bootkube/issues/150","repository_url":"https://api.github.com/repos/kubernetes-incubator/bootkube","labels_url":"https://api.github.com/repos/kubernetes-incubator/bootkube/issues/150/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-incubator/bootkube/issues/150/comments","events_url":"https://api.github.com/repos/kubernetes-incubator/bootkube/issues/150/events","html_url":"https://github.com/kubernetes-incubator/bootkube/issues/150","id":182462911,"number":150,"title":"Build guidelines to avoid missing P224","user":{"login":"dghubble","id":2253428,"avatar_url":"https://avatars.githubusercontent.com/u/2253428?v=3","gravatar_id":"","url":"https://api.github.com/users/dghubble","html_url":"https://github.com/dghubble","followers_url":"https://api.github.com/users/dghubble/followers","following_url":"https://api.github.com/users/dghubble/following{/other_user}","gists_url":"https://api.github.com/users/dghubble/gists{/gist_id}","starred_url":"https://api.github.com/users/dghubble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dghubble/subscriptions","organizations_url":"https://api.github.com/users/dghubble/orgs","repos_url":"https://api.github.com/users/dghubble/repos","events_url":"https://api.github.com/users/dghubble/events{/privacy}","received_events_url":"https://api.github.com/users/dghubble/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-12T08:18:50Z","updated_at":"2016-12-30T20:13:19Z","closed_at":"2016-12-30T20:13:19Z","body":"Kubernetes build issues such as https://github.com/kubernetes/kubernetes/issues/29534 propagate into bootkube since kubernetes is a vendored component. RHEL/Fedora don't include P224 for some license reasons and builds in this environment fail\n\n```\nName        : golang\nVersion     : 1.6.3\nRelease     : 2.fc24\nArchitecture: x86_64\n```\n\n```\nmake install\nmkdir -p _output/bin/linux/\nGOOS=linux go build -ldflags \"-X github.com/kubernetes-incubator/bootkube/pkg/version.Version=v0.2.0\" -o _output/bin/linux/bootkube github.com/kubernetes-incubator/bootkube/cmd/bootkube\n# github.com/kubernetes-incubator/bootkube/vendor/k8s.io/kubernetes/pkg/util/certificates\nvendor/k8s.io/kubernetes/pkg/util/certificates/csr.go:96: undefined: elliptic.P224\n# github.com/kubernetes-incubator/bootkube/vendor/github.com/google/certificate-transparency/go/x509\nvendor/github.com/google/certificate-transparency/go/x509/x509.go:342: undefined: elliptic.P224\nvendor/github.com/google/certificate-transparency/go/x509/x509.go:355: undefined: elliptic.P224\nvendor/github.com/google/certificate-transparency/go/x509/x509.go:1461: undefined: elliptic.P224\nMakefile:27: recipe for target '_output/bin/linux/bootkube' failed\nmake: *** [_output/bin/linux/bootkube] Error 2\n```\n\nUsing the binary from the go1.7.1 linux/amd64 tarball does seem to allow builds to succeed as reported upstream. It doesn't appear much could be done within bootkube to address this except re-vendoring when upstream reaches a conclusion.\n\nPerhaps I'll add a Go version note to the README for now?\n\ncc @gtank\n"}}
{"actor":{"display_login":"aaronlevy"}}