{"action":"created","issue":{"url":"https://api.github.com/repos/Netflix/zuul/issues/221","repository_url":"https://api.github.com/repos/Netflix/zuul","labels_url":"https://api.github.com/repos/Netflix/zuul/issues/221/labels{/name}","comments_url":"https://api.github.com/repos/Netflix/zuul/issues/221/comments","events_url":"https://api.github.com/repos/Netflix/zuul/issues/221/events","html_url":"https://github.com/Netflix/zuul/issues/221","id":153943581,"number":221,"title":"UnitTests in Java sources","user":{"login":"ArturSkowronski","id":395778,"avatar_url":"https://avatars.githubusercontent.com/u/395778?v=3","gravatar_id":"","url":"https://api.github.com/users/ArturSkowronski","html_url":"https://github.com/ArturSkowronski","followers_url":"https://api.github.com/users/ArturSkowronski/followers","following_url":"https://api.github.com/users/ArturSkowronski/following{/other_user}","gists_url":"https://api.github.com/users/ArturSkowronski/gists{/gist_id}","starred_url":"https://api.github.com/users/ArturSkowronski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArturSkowronski/subscriptions","organizations_url":"https://api.github.com/users/ArturSkowronski/orgs","repos_url":"https://api.github.com/users/ArturSkowronski/repos","events_url":"https://api.github.com/users/ArturSkowronski/events{/privacy}","received_events_url":"https://api.github.com/users/ArturSkowronski/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-10T07:47:52Z","updated_at":"2016-05-10T16:25:39Z","closed_at":null,"body":"Hello,\r\nI have a question - why are you putting Unit Tests in Java Source like in: https://github.com/Netflix/zuul/blob/1.x/zuul-core/src/main/java/com/netflix/zuul/FilterFileManager.java\r\n\r\nIt is a common pattern in repository. What are a reasons behind this decision? Pros, Cons?\r\n\r\nMaybe it shouldn't be in Issue section but you really made me curious about that :) "},"comment":{"url":"https://api.github.com/repos/Netflix/zuul/issues/comments/218212742","html_url":"https://github.com/Netflix/zuul/issues/221#issuecomment-218212742","issue_url":"https://api.github.com/repos/Netflix/zuul/issues/221","id":218212742,"user":{"login":"ausmith","id":6078539,"avatar_url":"https://avatars.githubusercontent.com/u/6078539?v=3","gravatar_id":"","url":"https://api.github.com/users/ausmith","html_url":"https://github.com/ausmith","followers_url":"https://api.github.com/users/ausmith/followers","following_url":"https://api.github.com/users/ausmith/following{/other_user}","gists_url":"https://api.github.com/users/ausmith/gists{/gist_id}","starred_url":"https://api.github.com/users/ausmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ausmith/subscriptions","organizations_url":"https://api.github.com/users/ausmith/orgs","repos_url":"https://api.github.com/users/ausmith/repos","events_url":"https://api.github.com/users/ausmith/events{/privacy}","received_events_url":"https://api.github.com/users/ausmith/received_events","type":"User","site_admin":false},"created_at":"2016-05-10T16:25:39Z","updated_at":"2016-05-10T16:25:39Z","body":"It looks like the group just rejected a PR that was attempting to move the tests out of the source code. #220 The reasoning from @mikeycohen was \"This keeps logic and testing close.\" \r\n\r\nMy team's implementation of zuul has our tests separated from the source files as our own style preference (I am not at Netflix so this is a completely independent opinion)."}}