{"action":"created","issue":{"url":"https://api.github.com/repos/humanmade/backupwordpress/issues/833","labels_url":"https://api.github.com/repos/humanmade/backupwordpress/issues/833/labels{/name}","comments_url":"https://api.github.com/repos/humanmade/backupwordpress/issues/833/comments","events_url":"https://api.github.com/repos/humanmade/backupwordpress/issues/833/events","html_url":"https://github.com/humanmade/backupwordpress/pull/833","id":95382539,"number":833,"title":"Remove folder permissions notices","user":{"login":"pdewouters","id":30460,"avatar_url":"https://avatars.githubusercontent.com/u/30460?v=3","gravatar_id":"","url":"https://api.github.com/users/pdewouters","html_url":"https://github.com/pdewouters","followers_url":"https://api.github.com/users/pdewouters/followers","following_url":"https://api.github.com/users/pdewouters/following{/other_user}","gists_url":"https://api.github.com/users/pdewouters/gists{/gist_id}","starred_url":"https://api.github.com/users/pdewouters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdewouters/subscriptions","organizations_url":"https://api.github.com/users/pdewouters/orgs","repos_url":"https://api.github.com/users/pdewouters/repos","events_url":"https://api.github.com/users/pdewouters/events{/privacy}","received_events_url":"https://api.github.com/users/pdewouters/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/humanmade/backupwordpress/labels/Do%20Not%20Merge","name":"Do Not Merge","color":"f7c6c7"},{"url":"https://api.github.com/repos/humanmade/backupwordpress/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":{"login":"pdewouters","id":30460,"avatar_url":"https://avatars.githubusercontent.com/u/30460?v=3","gravatar_id":"","url":"https://api.github.com/users/pdewouters","html_url":"https://github.com/pdewouters","followers_url":"https://api.github.com/users/pdewouters/followers","following_url":"https://api.github.com/users/pdewouters/following{/other_user}","gists_url":"https://api.github.com/users/pdewouters/gists{/gist_id}","starred_url":"https://api.github.com/users/pdewouters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdewouters/subscriptions","organizations_url":"https://api.github.com/users/pdewouters/orgs","repos_url":"https://api.github.com/users/pdewouters/repos","events_url":"https://api.github.com/users/pdewouters/events{/privacy}","received_events_url":"https://api.github.com/users/pdewouters/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/humanmade/backupwordpress/milestones/3","html_url":"https://github.com/humanmade/backupwordpress/milestones/Future%20Release","labels_url":"https://api.github.com/repos/humanmade/backupwordpress/milestones/3/labels","id":52671,"number":3,"title":"Future Release","description":"Anything in the Future Release milestone is up for grabs.","creator":{"login":"willmot","id":308507,"avatar_url":"https://avatars.githubusercontent.com/u/308507?v=3","gravatar_id":"","url":"https://api.github.com/users/willmot","html_url":"https://github.com/willmot","followers_url":"https://api.github.com/users/willmot/followers","following_url":"https://api.github.com/users/willmot/following{/other_user}","gists_url":"https://api.github.com/users/willmot/gists{/gist_id}","starred_url":"https://api.github.com/users/willmot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willmot/subscriptions","organizations_url":"https://api.github.com/users/willmot/orgs","repos_url":"https://api.github.com/users/willmot/repos","events_url":"https://api.github.com/users/willmot/events{/privacy}","received_events_url":"https://api.github.com/users/willmot/received_events","type":"User","site_admin":false},"open_issues":78,"closed_issues":132,"state":"open","created_at":"2011-11-04T10:36:37Z","updated_at":"2016-01-20T12:17:19Z","due_on":null,"closed_at":null},"comments":15,"created_at":"2015-07-16T08:47:39Z","updated_at":"2016-01-20T12:52:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/humanmade/backupwordpress/pulls/833","html_url":"https://github.com/humanmade/backupwordpress/pull/833","diff_url":"https://github.com/humanmade/backupwordpress/pull/833.diff","patch_url":"https://github.com/humanmade/backupwordpress/pull/833.patch"},"body":"The newly added Path class is smart enough to create the backups folder either under `wp-content` or under the `uploads` folder which will always be writable by WordPress.\r\n\r\nThe `whoami` command is sometimes disabled on shared hosts. This can cause unnecessary errors for users.\r\n\r\nI don't think we should use `WP_Filesystem` to create folders / files as the backup functionality is mostly run without user interaction, so displaying a login form doesn't help.\r\n\r\n`wp_mkdir_p` should suffice, we should probably throw an error and bubble it up to UI if it is unsuccessful though.\r\n\r\nhttps://github.com/humanmade/backupwordpress/blob/master/classes/class-path.php#L211"},"comment":{"url":"https://api.github.com/repos/humanmade/backupwordpress/issues/comments/173195371","html_url":"https://github.com/humanmade/backupwordpress/pull/833#issuecomment-173195371","issue_url":"https://api.github.com/repos/humanmade/backupwordpress/issues/833","id":173195371,"user":{"login":"willmot","id":308507,"avatar_url":"https://avatars.githubusercontent.com/u/308507?v=3","gravatar_id":"","url":"https://api.github.com/users/willmot","html_url":"https://github.com/willmot","followers_url":"https://api.github.com/users/willmot/followers","following_url":"https://api.github.com/users/willmot/following{/other_user}","gists_url":"https://api.github.com/users/willmot/gists{/gist_id}","starred_url":"https://api.github.com/users/willmot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willmot/subscriptions","organizations_url":"https://api.github.com/users/willmot/orgs","repos_url":"https://api.github.com/users/willmot/repos","events_url":"https://api.github.com/users/willmot/events{/privacy}","received_events_url":"https://api.github.com/users/willmot/received_events","type":"User","site_admin":false},"created_at":"2016-01-20T12:52:29Z","updated_at":"2016-01-20T12:52:29Z","body":"Just noting, here's what we get on hmn.md:\r\n\r\n<img width=\"1334\" alt=\"screen shot 2016-01-20 at 12 50 31\" src=\"https://cloud.githubusercontent.com/assets/308507/12449352/89f25d92-bf74-11e5-8e02-21ead20437c8.png\">\r\n\r\nThis is both this issue and https://github.com/humanmade/backupwordpress/issues/538"}}