{"action":"closed","number":8032,"pull_request":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/8032","id":57487533,"html_url":"https://github.com/mrdoob/three.js/pull/8032","diff_url":"https://github.com/mrdoob/three.js/pull/8032.diff","patch_url":"https://github.com/mrdoob/three.js/pull/8032.patch","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/8032","number":8032,"state":"closed","locked":false,"title":"Adds blender exporter option to toggle compact separators output","user":{"login":"jorgenfb","id":983859,"avatar_url":"https://avatars.githubusercontent.com/u/983859?v=3","gravatar_id":"","url":"https://api.github.com/users/jorgenfb","html_url":"https://github.com/jorgenfb","followers_url":"https://api.github.com/users/jorgenfb/followers","following_url":"https://api.github.com/users/jorgenfb/following{/other_user}","gists_url":"https://api.github.com/users/jorgenfb/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgenfb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgenfb/subscriptions","organizations_url":"https://api.github.com/users/jorgenfb/orgs","repos_url":"https://api.github.com/users/jorgenfb/repos","events_url":"https://api.github.com/users/jorgenfb/events{/privacy}","received_events_url":"https://api.github.com/users/jorgenfb/received_events","type":"User","site_admin":false},"body":"This change will enable smaller file size for exported models from blender, which of course matters on the web.\r\n\r\nIt adds the option to use compact separators in the exported JSON output. When enabled it will set JSON key separator to ```': '``` and JSON value separator to ```','```. When disabled the default separators (```': '``` and ```', '```) is used. Example output:\r\n\r\nOld / default output:\r\n```\r\n{\"matrix\": [1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1]}\r\n```\r\n\r\nNew output (when enabled):\r\n```\r\n{\"matrix\":[1,0,0,0,0,1,0,0,0,0,1,0,0,0,0,1]}\r\n```\r\n\r\nThe compact option reduces the generated file size considerably. I tested three models:\r\n\r\n4888757 bytes => 4090855 bytes, a 16 % reduction, 3 % when zipped\r\n3883955 bytes => 4644569 bytes, a 16 % reduction, 3 % when zipped\r\n3295633 bytes => 3940764 bytes, a 16 % reduction, 3 % when zipped\r\n\r\nI also tried lowering the precision of the output, and was able to get around 20 % reduction. Still around 3 % when compressed.\r\n\r\nThe default value is to disable this feature. Includes both a graphical interface and api option to toggle this feature.","created_at":"2016-01-28T11:13:34Z","updated_at":"2016-02-07T12:45:15Z","closed_at":"2016-02-07T12:45:15Z","merged_at":"2016-02-07T12:45:15Z","merge_commit_sha":"091ce15f6bb3540dced219944b5115aeb1ad2673","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mrdoob/three.js/pulls/8032/commits","review_comments_url":"https://api.github.com/repos/mrdoob/three.js/pulls/8032/comments","review_comment_url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/8032/comments","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/bc784fd2b27a31897ab506b5940949f72965fa4c","head":{"label":"jorgenfb:blender_exporter_compact_json","ref":"blender_exporter_compact_json","sha":"bc784fd2b27a31897ab506b5940949f72965fa4c","user":{"login":"jorgenfb","id":983859,"avatar_url":"https://avatars.githubusercontent.com/u/983859?v=3","gravatar_id":"","url":"https://api.github.com/users/jorgenfb","html_url":"https://github.com/jorgenfb","followers_url":"https://api.github.com/users/jorgenfb/followers","following_url":"https://api.github.com/users/jorgenfb/following{/other_user}","gists_url":"https://api.github.com/users/jorgenfb/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgenfb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgenfb/subscriptions","organizations_url":"https://api.github.com/users/jorgenfb/orgs","repos_url":"https://api.github.com/users/jorgenfb/repos","events_url":"https://api.github.com/users/jorgenfb/events{/privacy}","received_events_url":"https://api.github.com/users/jorgenfb/received_events","type":"User","site_admin":false},"repo":{"id":50568969,"name":"three.js","full_name":"jorgenfb/three.js","owner":{"login":"jorgenfb","id":983859,"avatar_url":"https://avatars.githubusercontent.com/u/983859?v=3","gravatar_id":"","url":"https://api.github.com/users/jorgenfb","html_url":"https://github.com/jorgenfb","followers_url":"https://api.github.com/users/jorgenfb/followers","following_url":"https://api.github.com/users/jorgenfb/following{/other_user}","gists_url":"https://api.github.com/users/jorgenfb/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgenfb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgenfb/subscriptions","organizations_url":"https://api.github.com/users/jorgenfb/orgs","repos_url":"https://api.github.com/users/jorgenfb/repos","events_url":"https://api.github.com/users/jorgenfb/events{/privacy}","received_events_url":"https://api.github.com/users/jorgenfb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jorgenfb/three.js","description":"JavaScript 3D library.","fork":true,"url":"https://api.github.com/repos/jorgenfb/three.js","forks_url":"https://api.github.com/repos/jorgenfb/three.js/forks","keys_url":"https://api.github.com/repos/jorgenfb/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jorgenfb/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jorgenfb/three.js/teams","hooks_url":"https://api.github.com/repos/jorgenfb/three.js/hooks","issue_events_url":"https://api.github.com/repos/jorgenfb/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/jorgenfb/three.js/events","assignees_url":"https://api.github.com/repos/jorgenfb/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/jorgenfb/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/jorgenfb/three.js/tags","blobs_url":"https://api.github.com/repos/jorgenfb/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jorgenfb/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jorgenfb/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/jorgenfb/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jorgenfb/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/jorgenfb/three.js/languages","stargazers_url":"https://api.github.com/repos/jorgenfb/three.js/stargazers","contributors_url":"https://api.github.com/repos/jorgenfb/three.js/contributors","subscribers_url":"https://api.github.com/repos/jorgenfb/three.js/subscribers","subscription_url":"https://api.github.com/repos/jorgenfb/three.js/subscription","commits_url":"https://api.github.com/repos/jorgenfb/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/jorgenfb/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/jorgenfb/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/jorgenfb/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/jorgenfb/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/jorgenfb/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jorgenfb/three.js/merges","archive_url":"https://api.github.com/repos/jorgenfb/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jorgenfb/three.js/downloads","issues_url":"https://api.github.com/repos/jorgenfb/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/jorgenfb/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/jorgenfb/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/jorgenfb/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jorgenfb/three.js/labels{/name}","releases_url":"https://api.github.com/repos/jorgenfb/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/jorgenfb/three.js/deployments","created_at":"2016-01-28T08:42:04Z","updated_at":"2016-01-28T08:42:10Z","pushed_at":"2016-02-07T11:36:09Z","git_url":"git://github.com/jorgenfb/three.js.git","ssh_url":"git@github.com:jorgenfb/three.js.git","clone_url":"https://github.com/jorgenfb/three.js.git","svn_url":"https://github.com/jorgenfb/three.js","homepage":"http://threejs.org/","size":356894,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mrdoob:dev","ref":"dev","sha":"6295c939392a5fc6033d9e5e28877dd48618275c","user":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"repo":{"id":576201,"name":"three.js","full_name":"mrdoob/three.js","owner":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrdoob/three.js","description":"JavaScript 3D library.","fork":false,"url":"https://api.github.com/repos/mrdoob/three.js","forks_url":"https://api.github.com/repos/mrdoob/three.js/forks","keys_url":"https://api.github.com/repos/mrdoob/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrdoob/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrdoob/three.js/teams","hooks_url":"https://api.github.com/repos/mrdoob/three.js/hooks","issue_events_url":"https://api.github.com/repos/mrdoob/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/mrdoob/three.js/events","assignees_url":"https://api.github.com/repos/mrdoob/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/mrdoob/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/mrdoob/three.js/tags","blobs_url":"https://api.github.com/repos/mrdoob/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrdoob/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrdoob/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrdoob/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mrdoob/three.js/languages","stargazers_url":"https://api.github.com/repos/mrdoob/three.js/stargazers","contributors_url":"https://api.github.com/repos/mrdoob/three.js/contributors","subscribers_url":"https://api.github.com/repos/mrdoob/three.js/subscribers","subscription_url":"https://api.github.com/repos/mrdoob/three.js/subscription","commits_url":"https://api.github.com/repos/mrdoob/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrdoob/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrdoob/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrdoob/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrdoob/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/mrdoob/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrdoob/three.js/merges","archive_url":"https://api.github.com/repos/mrdoob/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrdoob/three.js/downloads","issues_url":"https://api.github.com/repos/mrdoob/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/mrdoob/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mrdoob/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mrdoob/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrdoob/three.js/labels{/name}","releases_url":"https://api.github.com/repos/mrdoob/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/mrdoob/three.js/deployments","created_at":"2010-03-23T18:58:01Z","updated_at":"2016-02-07T09:55:08Z","pushed_at":"2016-02-07T12:45:15Z","git_url":"git://github.com/mrdoob/three.js.git","ssh_url":"git@github.com:mrdoob/three.js.git","clone_url":"https://github.com/mrdoob/three.js.git","svn_url":"https://github.com/mrdoob/three.js","homepage":"http://threejs.org/","size":437739,"stargazers_count":23183,"watchers_count":23183,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":7378,"mirror_url":null,"open_issues_count":578,"forks":7378,"open_issues":578,"watchers":23183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/8032"},"html":{"href":"https://github.com/mrdoob/three.js/pull/8032"},"issue":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/8032"},"comments":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/8032/comments"},"review_comments":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/8032/comments"},"review_comment":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/8032/commits"},"statuses":{"href":"https://api.github.com/repos/mrdoob/three.js/statuses/bc784fd2b27a31897ab506b5940949f72965fa4c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":2,"additions":3,"deletions":2,"changed_files":2}}