{"action":"created","issue":{"url":"https://api.github.com/repos/mitls/mitls-fstar/issues/87","repository_url":"https://api.github.com/repos/mitls/mitls-fstar","labels_url":"https://api.github.com/repos/mitls/mitls-fstar/issues/87/labels{/name}","comments_url":"https://api.github.com/repos/mitls/mitls-fstar/issues/87/comments","events_url":"https://api.github.com/repos/mitls/mitls-fstar/issues/87/events","html_url":"https://github.com/mitls/mitls-fstar/pull/87","id":164748801,"number":87,"title":"FFI for miTLS - ready for a pull to main","user":{"login":"BarryBo","id":19733405,"avatar_url":"https://avatars.githubusercontent.com/u/19733405?v=3","gravatar_id":"","url":"https://api.github.com/users/BarryBo","html_url":"https://github.com/BarryBo","followers_url":"https://api.github.com/users/BarryBo/followers","following_url":"https://api.github.com/users/BarryBo/following{/other_user}","gists_url":"https://api.github.com/users/BarryBo/gists{/gist_id}","starred_url":"https://api.github.com/users/BarryBo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BarryBo/subscriptions","organizations_url":"https://api.github.com/users/BarryBo/orgs","repos_url":"https://api.github.com/users/BarryBo/repos","events_url":"https://api.github.com/users/BarryBo/events{/privacy}","received_events_url":"https://api.github.com/users/BarryBo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-07-11T02:23:42Z","updated_at":"2016-07-12T23:26:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mitls/mitls-fstar/pulls/87","html_url":"https://github.com/mitls/mitls-fstar/pull/87","diff_url":"https://github.com/mitls/mitls-fstar/pull/87.diff","patch_url":"https://github.com/mitls/mitls-fstar/pull/87.patch"},"body":"OK, I am finally satisfied with the FFI code, and it is ready to move into main.\r\n\r\nChanges since last pull request:\r\n1.  I did a pull from main to ffi, to bring the ffi codebase into sync with changes in main.\r\n2.  Refactored the FFI wrapper code, to get rid of all of the ffiState* structures.  Now the ffiConnect12 and ffiConnect13 calls return closures which know how to encrypt and decrypt packets, and the C part of the FFI layer knows how to call into those closers.  This shrinks the FFI size and complexity considerably.\r\n"},"comment":{"url":"https://api.github.com/repos/mitls/mitls-fstar/issues/comments/232211839","html_url":"https://github.com/mitls/mitls-fstar/pull/87#issuecomment-232211839","issue_url":"https://api.github.com/repos/mitls/mitls-fstar/issues/87","id":232211839,"user":{"login":"msprotz","id":10673049,"avatar_url":"https://avatars.githubusercontent.com/u/10673049?v=3","gravatar_id":"","url":"https://api.github.com/users/msprotz","html_url":"https://github.com/msprotz","followers_url":"https://api.github.com/users/msprotz/followers","following_url":"https://api.github.com/users/msprotz/following{/other_user}","gists_url":"https://api.github.com/users/msprotz/gists{/gist_id}","starred_url":"https://api.github.com/users/msprotz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msprotz/subscriptions","organizations_url":"https://api.github.com/users/msprotz/orgs","repos_url":"https://api.github.com/users/msprotz/repos","events_url":"https://api.github.com/users/msprotz/events{/privacy}","received_events_url":"https://api.github.com/users/msprotz/received_events","type":"User","site_admin":false},"created_at":"2016-07-12T23:26:04Z","updated_at":"2016-07-12T23:26:04Z","body":"perhaps `-ccopt -Wall` would help when calling `ocamlopt` on C files; it compiles on my windows machine, indeed, but there's probably a bunch of disabled-by-default warnings"}}
{"actor":{"display_login":"msprotz"}}