{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/64728189","id":64728189,"diff_hunk":"@@ -347,14 +347,22 @@ def ca_cert_store(cert)\n       raise _(\"Failed to create X509 certificate, error: %s\" % e.message)\n     end\n \n-    def ca_cert\n+    def fetch_unverified(path, query = '')\n       ca_url = URI.parse(url)\n-      ca_url.path = \"/ca.crt\"\n+      ca_url.path = path\n+      ca_url.query = query\n       http = Net::HTTP.new(ca_url.host, ca_url.port)\n       http.use_ssl = (ca_url.scheme == 'https')\n       http.verify_mode = OpenSSL::SSL::VERIFY_NONE\n-      request = Net::HTTP::Get.new(ca_url.path)\n+      request = Net::HTTP::Get.new(ca_url)\n       http.request(request).body\n+    rescue Exception => e","path":"app/models/compute_resources/foreman/model/ovirt.rb","position":16,"original_position":16,"commit_id":"7e6b24bd93f0f10e0f6504736e38ca0d18e11600","original_commit_id":"dcf20838c0e9a60c0733713a070997e6cff5aa8c","user":{"login":"ares","id":109773,"avatar_url":"https://avatars.githubusercontent.com/u/109773?v=3","gravatar_id":"","url":"https://api.github.com/users/ares","html_url":"https://github.com/ares","followers_url":"https://api.github.com/users/ares/followers","following_url":"https://api.github.com/users/ares/following{/other_user}","gists_url":"https://api.github.com/users/ares/gists{/gist_id}","starred_url":"https://api.github.com/users/ares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ares/subscriptions","organizations_url":"https://api.github.com/users/ares/orgs","repos_url":"https://api.github.com/users/ares/repos","events_url":"https://api.github.com/users/ares/events{/privacy}","received_events_url":"https://api.github.com/users/ares/received_events","type":"User","site_admin":false},"body":"because this catches also exceptions like SyntaxError, SystemExit, NoMemoryError etc... you probably wanted to rescue StandardError or just do `rescue => e` which is equivalent","created_at":"2016-05-26T11:09:26Z","updated_at":"2016-05-26T11:09:26Z","html_url":"https://github.com/theforeman/foreman/pull/3548#discussion_r64728189","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/3548","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/64728189"},"html":{"href":"https://github.com/theforeman/foreman/pull/3548#discussion_r64728189"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3548"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/3548","id":71228370,"html_url":"https://github.com/theforeman/foreman/pull/3548","diff_url":"https://github.com/theforeman/foreman/pull/3548.diff","patch_url":"https://github.com/theforeman/foreman/pull/3548.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/3548","number":3548,"state":"open","locked":false,"title":"Fixes #15163 - use new oVirt CA cert endpoint","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"body":"oVirt 3.4 - 3.6 provide both, from 4.0 only the new endpoint will be available.","created_at":"2016-05-24T14:18:17Z","updated_at":"2016-05-26T11:09:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"043f4a22a500513532d6ff57b01c28504c03961c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/3548/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/3548/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/3548/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/7e6b24bd93f0f10e0f6504736e38ca0d18e11600","head":{"label":"lzap:ovirt-cacert-15163","ref":"ovirt-cacert-15163","sha":"7e6b24bd93f0f10e0f6504736e38ca0d18e11600","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"repo":{"id":1410439,"name":"foreman","full_name":"lzap/foreman","owner":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lzap/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/lzap/foreman","forks_url":"https://api.github.com/repos/lzap/foreman/forks","keys_url":"https://api.github.com/repos/lzap/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lzap/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lzap/foreman/teams","hooks_url":"https://api.github.com/repos/lzap/foreman/hooks","issue_events_url":"https://api.github.com/repos/lzap/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/lzap/foreman/events","assignees_url":"https://api.github.com/repos/lzap/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/lzap/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/lzap/foreman/tags","blobs_url":"https://api.github.com/repos/lzap/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lzap/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lzap/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/lzap/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lzap/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/lzap/foreman/languages","stargazers_url":"https://api.github.com/repos/lzap/foreman/stargazers","contributors_url":"https://api.github.com/repos/lzap/foreman/contributors","subscribers_url":"https://api.github.com/repos/lzap/foreman/subscribers","subscription_url":"https://api.github.com/repos/lzap/foreman/subscription","commits_url":"https://api.github.com/repos/lzap/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/lzap/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/lzap/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/lzap/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/lzap/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/lzap/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lzap/foreman/merges","archive_url":"https://api.github.com/repos/lzap/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lzap/foreman/downloads","issues_url":"https://api.github.com/repos/lzap/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/lzap/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/lzap/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/lzap/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lzap/foreman/labels{/name}","releases_url":"https://api.github.com/repos/lzap/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/lzap/foreman/deployments","created_at":"2011-02-25T10:13:00Z","updated_at":"2014-06-19T15:16:06Z","pushed_at":"2016-05-26T10:50:10Z","git_url":"git://github.com/lzap/foreman.git","ssh_url":"git@github.com:lzap/foreman.git","clone_url":"https://github.com/lzap/foreman.git","svn_url":"https://github.com/lzap/foreman","homepage":"http://theforeman.org","size":34354,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"b9a3e39d0a62b1eda43b6ce8da54b636c1500e58","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman/deployments","created_at":"2009-07-23T15:07:00Z","updated_at":"2016-05-25T16:26:22Z","pushed_at":"2016-05-26T11:03:55Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":67782,"stargazers_count":1020,"watchers_count":1020,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":522,"mirror_url":null,"open_issues_count":73,"forks":522,"open_issues":73,"watchers":1020,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3548"},"html":{"href":"https://github.com/theforeman/foreman/pull/3548"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3548"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/3548/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3548/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/3548/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/7e6b24bd93f0f10e0f6504736e38ca0d18e11600"}}}}
{"actor":{"display_login":"ares"}}