{"action":"created","issue":{"url":"https://api.github.com/repos/assetgraph/assetgraph/issues/547","repository_url":"https://api.github.com/repos/assetgraph/assetgraph","labels_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/547/labels{/name}","comments_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/547/comments","events_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/547/events","html_url":"https://github.com/assetgraph/assetgraph/pull/547","id":159041640,"number":547,"title":"Rework require.js bundling support","user":{"login":"papandreou","id":373545,"avatar_url":"https://avatars.githubusercontent.com/u/373545?v=3","gravatar_id":"","url":"https://api.github.com/users/papandreou","html_url":"https://github.com/papandreou","followers_url":"https://api.github.com/users/papandreou/followers","following_url":"https://api.github.com/users/papandreou/following{/other_user}","gists_url":"https://api.github.com/users/papandreou/gists{/gist_id}","starred_url":"https://api.github.com/users/papandreou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papandreou/subscriptions","organizations_url":"https://api.github.com/users/papandreou/orgs","repos_url":"https://api.github.com/users/papandreou/repos","events_url":"https://api.github.com/users/papandreou/events{/privacy}","received_events_url":"https://api.github.com/users/papandreou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2016-06-07T22:43:36Z","updated_at":"2016-06-11T16:25:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/assetgraph/assetgraph/pulls/547","html_url":"https://github.com/assetgraph/assetgraph/pull/547","diff_url":"https://github.com/assetgraph/assetgraph/pull/547.diff","patch_url":"https://github.com/assetgraph/assetgraph/pull/547.patch"},"body":"This tears out the modelling of `require(...)`, `define(...)` etc. as first class relations and centralizes all the require.js bundling stuff in a single `bundleRequireJs` transform. Also, it simplifies the system.js support by moving all the code for figuring out the active config and adding polyfilling into the `bundleSystemJs` transform.\r\n\r\nRequiring css and less is now supported via https://github.com/guybedford/require-css and https://github.com/guybedford/require-less instead of having specific support hacked in.\r\n\r\n- [x] Promisify the `bundleRequireJs` transform\r\n- [x] Figure out how to pick up on .html and .ko templates loaded via a require.js plugin instead of utilizing the `inlineKnockoutTemplates` transform.\r\n- [x] Figure out why the removal of the `liftUpJavaScriptRequireJsCommonJsCompatibilityRequire` transform makes the \"should handle a test case with an HTML fragment that has bundleable scripts and stylesheets\" test fail in buildProduction. Probably a long standing bug that was somehow masked.\r\n\r\nGoes along with https://github.com/assetgraph/assetgraph-builder/tree/feature/reworkRequireJs (not complete yet)"},"comment":{"url":"https://api.github.com/repos/assetgraph/assetgraph/issues/comments/225372941","html_url":"https://github.com/assetgraph/assetgraph/pull/547#issuecomment-225372941","issue_url":"https://api.github.com/repos/assetgraph/assetgraph/issues/547","id":225372941,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-06-11T16:25:53Z","updated_at":"2016-06-11T16:25:53Z","body":"\n[![Coverage Status](https://coveralls.io/builds/6559202/badge)](https://coveralls.io/builds/6559202)\n\nCoverage decreased (-1.6%) to 78.748% when pulling **0f766f905b4f96a599861d9b739b0be35cdbd34b on feature/reworkRequireJs** into **d5df926846d75c818a2df89091c51515f5555ad0 on master**.\n"}}
{"actor":{"display_login":"coveralls"}}