{"action":"created","comment":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/65591183","id":65591183,"diff_hunk":"@@ -28,6 +32,57 @@ class DoctrinePHPCRDriver extends AbstractDoctrineDriver\n     /**\n      * {@inheritdoc}\n      */\n+    public function load(ContainerBuilder $container, MetadataInterface $metadata)\n+    {\n+        parent::load($container, $metadata);\n+        $this->addResourceListeners($container, $metadata);","path":"src/Sylius/Bundle/ResourceBundle/DependencyInjection/Driver/Doctrine/DoctrinePHPCRDriver.php","position":19,"original_position":18,"commit_id":"3fc5987487b2eeab13183d06548dd35874316761","original_commit_id":"de5e7b4b71d63119bf044f16e2db25932db29d3c","user":{"login":"pjedrzejewski","id":614970,"avatar_url":"https://avatars.githubusercontent.com/u/614970?v=3","gravatar_id":"","url":"https://api.github.com/users/pjedrzejewski","html_url":"https://github.com/pjedrzejewski","followers_url":"https://api.github.com/users/pjedrzejewski/followers","following_url":"https://api.github.com/users/pjedrzejewski/following{/other_user}","gists_url":"https://api.github.com/users/pjedrzejewski/gists{/gist_id}","starred_url":"https://api.github.com/users/pjedrzejewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjedrzejewski/subscriptions","organizations_url":"https://api.github.com/users/pjedrzejewski/orgs","repos_url":"https://api.github.com/users/pjedrzejewski/repos","events_url":"https://api.github.com/users/pjedrzejewski/events{/privacy}","received_events_url":"https://api.github.com/users/pjedrzejewski/received_events","type":"User","site_admin":false},"body":"It's ok for now! These driver abstractions are far from perfect, but I don't think we should bother with them too much at this point.","created_at":"2016-06-02T18:17:42Z","updated_at":"2016-06-02T18:17:42Z","html_url":"https://github.com/Sylius/Sylius/pull/5039#discussion_r65591183","pull_request_url":"https://api.github.com/repos/Sylius/Sylius/pulls/5039","_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/65591183"},"html":{"href":"https://github.com/Sylius/Sylius/pull/5039#discussion_r65591183"},"pull_request":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/5039"}}},"pull_request":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/5039","id":70176006,"html_url":"https://github.com/Sylius/Sylius/pull/5039","diff_url":"https://github.com/Sylius/Sylius/pull/5039.diff","patch_url":"https://github.com/Sylius/Sylius/pull/5039.patch","issue_url":"https://api.github.com/repos/Sylius/Sylius/issues/5039","number":5039,"state":"open","locked":false,"title":"[ResourceBundle] Default Form builder for PHPCR-ODM","user":{"login":"dantleech","id":530801,"avatar_url":"https://avatars.githubusercontent.com/u/530801?v=3","gravatar_id":"","url":"https://api.github.com/users/dantleech","html_url":"https://github.com/dantleech","followers_url":"https://api.github.com/users/dantleech/followers","following_url":"https://api.github.com/users/dantleech/following{/other_user}","gists_url":"https://api.github.com/users/dantleech/gists{/gist_id}","starred_url":"https://api.github.com/users/dantleech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dantleech/subscriptions","organizations_url":"https://api.github.com/users/dantleech/orgs","repos_url":"https://api.github.com/users/dantleech/repos","events_url":"https://api.github.com/users/dantleech/events{/privacy}","received_events_url":"https://api.github.com/users/dantleech/received_events","type":"User","site_admin":false},"body":"| Q               | A\r\n| --------------- | ---\r\n| Bug fix?        | no\r\n| New feature?    | yes\r\n| BC breaks?      | no\r\n| License         | MIT\r\n\r\nThis PR adds a `DefaultFormBuilder` for the PHPCR-ODM resource.\r\n\r\nIn addition, because of the tree nature of PHPCR I have added three event\r\nlisteners which: handle the default parent path, resolve name conflcits and\r\nremove invalid characters from the node name.\r\n\r\nThese are configured in the resource config:\r\n\r\n```yaml\r\n    resources:\r\n        acme.post: \r\n            driver: doctrine/phpcr-odm,\r\n            classes:\r\n                model: Acme\\Document\\Post\r\n            options:\r\n                default_parent_path: /cms/foobar # set the parent path if none is provided\r\n                autocreate: false                # autocreate non-existing parent paths\r\n                force: false                     # always set the parent path.\r\n                name_resolver: true              # resolve name conflcits\r\n                name_filter: true                # filter invalid characters\r\n```\r\n","created_at":"2016-05-16T10:14:30Z","updated_at":"2016-06-02T18:17:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abd336dd8e9d4bc5d73a70e59b051fe2749db918","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Sylius/Sylius/pulls/5039/commits","review_comments_url":"https://api.github.com/repos/Sylius/Sylius/pulls/5039/comments","review_comment_url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sylius/Sylius/issues/5039/comments","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/3fc5987487b2eeab13183d06548dd35874316761","head":{"label":"dantleech:phpcrodm_form_builder","ref":"phpcrodm_form_builder","sha":"3fc5987487b2eeab13183d06548dd35874316761","user":{"login":"dantleech","id":530801,"avatar_url":"https://avatars.githubusercontent.com/u/530801?v=3","gravatar_id":"","url":"https://api.github.com/users/dantleech","html_url":"https://github.com/dantleech","followers_url":"https://api.github.com/users/dantleech/followers","following_url":"https://api.github.com/users/dantleech/following{/other_user}","gists_url":"https://api.github.com/users/dantleech/gists{/gist_id}","starred_url":"https://api.github.com/users/dantleech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dantleech/subscriptions","organizations_url":"https://api.github.com/users/dantleech/orgs","repos_url":"https://api.github.com/users/dantleech/repos","events_url":"https://api.github.com/users/dantleech/events{/privacy}","received_events_url":"https://api.github.com/users/dantleech/received_events","type":"User","site_admin":false},"repo":{"id":56380500,"name":"Sylius","full_name":"dantleech/Sylius","owner":{"login":"dantleech","id":530801,"avatar_url":"https://avatars.githubusercontent.com/u/530801?v=3","gravatar_id":"","url":"https://api.github.com/users/dantleech","html_url":"https://github.com/dantleech","followers_url":"https://api.github.com/users/dantleech/followers","following_url":"https://api.github.com/users/dantleech/following{/other_user}","gists_url":"https://api.github.com/users/dantleech/gists{/gist_id}","starred_url":"https://api.github.com/users/dantleech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dantleech/subscriptions","organizations_url":"https://api.github.com/users/dantleech/orgs","repos_url":"https://api.github.com/users/dantleech/repos","events_url":"https://api.github.com/users/dantleech/events{/privacy}","received_events_url":"https://api.github.com/users/dantleech/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dantleech/Sylius","description":"eCommerce PHP framework built on top of Symfony with component-based architecture and format-agnostic rendering. (HTML/JSON/XML)","fork":true,"url":"https://api.github.com/repos/dantleech/Sylius","forks_url":"https://api.github.com/repos/dantleech/Sylius/forks","keys_url":"https://api.github.com/repos/dantleech/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dantleech/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dantleech/Sylius/teams","hooks_url":"https://api.github.com/repos/dantleech/Sylius/hooks","issue_events_url":"https://api.github.com/repos/dantleech/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/dantleech/Sylius/events","assignees_url":"https://api.github.com/repos/dantleech/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/dantleech/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/dantleech/Sylius/tags","blobs_url":"https://api.github.com/repos/dantleech/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dantleech/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dantleech/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/dantleech/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dantleech/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/dantleech/Sylius/languages","stargazers_url":"https://api.github.com/repos/dantleech/Sylius/stargazers","contributors_url":"https://api.github.com/repos/dantleech/Sylius/contributors","subscribers_url":"https://api.github.com/repos/dantleech/Sylius/subscribers","subscription_url":"https://api.github.com/repos/dantleech/Sylius/subscription","commits_url":"https://api.github.com/repos/dantleech/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/dantleech/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/dantleech/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/dantleech/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/dantleech/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/dantleech/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dantleech/Sylius/merges","archive_url":"https://api.github.com/repos/dantleech/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dantleech/Sylius/downloads","issues_url":"https://api.github.com/repos/dantleech/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/dantleech/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/dantleech/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/dantleech/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dantleech/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/dantleech/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/dantleech/Sylius/deployments","created_at":"2016-04-16T11:37:11Z","updated_at":"2016-04-16T11:37:21Z","pushed_at":"2016-05-29T14:23:26Z","git_url":"git://github.com/dantleech/Sylius.git","ssh_url":"git@github.com:dantleech/Sylius.git","clone_url":"https://github.com/dantleech/Sylius.git","svn_url":"https://github.com/dantleech/Sylius","homepage":"http://Sylius.org","size":33618,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sylius:master","ref":"master","sha":"f98a23b516ae8dbcf4b0c2dffb9ece64d585d785","user":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"repo":{"id":2717549,"name":"Sylius","full_name":"Sylius/Sylius","owner":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sylius/Sylius","description":"eCommerce PHP framework built on top of Symfony with component-based architecture and format-agnostic rendering. (HTML/JSON/XML)","fork":false,"url":"https://api.github.com/repos/Sylius/Sylius","forks_url":"https://api.github.com/repos/Sylius/Sylius/forks","keys_url":"https://api.github.com/repos/Sylius/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sylius/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sylius/Sylius/teams","hooks_url":"https://api.github.com/repos/Sylius/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Sylius/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Sylius/Sylius/events","assignees_url":"https://api.github.com/repos/Sylius/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Sylius/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Sylius/Sylius/tags","blobs_url":"https://api.github.com/repos/Sylius/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sylius/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sylius/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sylius/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Sylius/Sylius/languages","stargazers_url":"https://api.github.com/repos/Sylius/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Sylius/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Sylius/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Sylius/Sylius/subscription","commits_url":"https://api.github.com/repos/Sylius/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sylius/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sylius/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sylius/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sylius/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Sylius/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sylius/Sylius/merges","archive_url":"https://api.github.com/repos/Sylius/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sylius/Sylius/downloads","issues_url":"https://api.github.com/repos/Sylius/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Sylius/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Sylius/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Sylius/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sylius/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Sylius/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/Sylius/Sylius/deployments","created_at":"2011-11-05T22:05:52Z","updated_at":"2016-06-02T07:11:20Z","pushed_at":"2016-06-02T18:09:26Z","git_url":"git://github.com/Sylius/Sylius.git","ssh_url":"git@github.com:Sylius/Sylius.git","clone_url":"https://github.com/Sylius/Sylius.git","svn_url":"https://github.com/Sylius/Sylius","homepage":"http://Sylius.org","size":66006,"stargazers_count":2330,"watchers_count":2330,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":844,"mirror_url":null,"open_issues_count":651,"forks":844,"open_issues":651,"watchers":2330,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/5039"},"html":{"href":"https://github.com/Sylius/Sylius/pull/5039"},"issue":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/5039"},"comments":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/5039/comments"},"review_comments":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/5039/comments"},"review_comment":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/5039/commits"},"statuses":{"href":"https://api.github.com/repos/Sylius/Sylius/statuses/3fc5987487b2eeab13183d06548dd35874316761"}}}}
{"actor":{"display_login":"pjedrzejewski"}}