{"action":"created","comment":{"url":"https://api.github.com/repos/e-mission/e-mission-phone/pulls/comments/71082322","id":71082322,"diff_hunk":"@@ -11,14 +11,29 @@ angular.module('emission.main.common.trip-detail',['ui-leaflet',\n     $scope.tripId = $stateParams.tripId;\n     $scope.trip = CommonGraph.data.cTripId2ObjMap[$scope.tripId];\n     var distributionStartHour = $scope.trip.common_hour_distribution;\n-    var valsStartHour = [];\n+    var valsStartHour = []; \n+    var state = 1; // state machine","path":"www/js/common/trip-detail.js","position":6,"original_position":6,"commit_id":"8c8288aa3cedf61e88720ebd53481142f9366dc0","original_commit_id":"8c8288aa3cedf61e88720ebd53481142f9366dc0","user":{"login":"shankari","id":2423263,"avatar_url":"https://avatars.githubusercontent.com/u/2423263?v=3","gravatar_id":"","url":"https://api.github.com/users/shankari","html_url":"https://github.com/shankari","followers_url":"https://api.github.com/users/shankari/followers","following_url":"https://api.github.com/users/shankari/following{/other_user}","gists_url":"https://api.github.com/users/shankari/gists{/gist_id}","starred_url":"https://api.github.com/users/shankari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shankari/subscriptions","organizations_url":"https://api.github.com/users/shankari/orgs","repos_url":"https://api.github.com/users/shankari/repos","events_url":"https://api.github.com/users/shankari/events{/privacy}","received_events_url":"https://api.github.com/users/shankari/received_events","type":"User","site_admin":false},"body":"cool @state machine","created_at":"2016-07-17T13:25:29Z","updated_at":"2016-07-17T13:25:29Z","html_url":"https://github.com/e-mission/e-mission-phone/pull/74#discussion_r71082322","pull_request_url":"https://api.github.com/repos/e-mission/e-mission-phone/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/e-mission/e-mission-phone/pulls/comments/71082322"},"html":{"href":"https://github.com/e-mission/e-mission-phone/pull/74#discussion_r71082322"},"pull_request":{"href":"https://api.github.com/repos/e-mission/e-mission-phone/pulls/74"}}},"pull_request":{"url":"https://api.github.com/repos/e-mission/e-mission-phone/pulls/74","id":77734183,"html_url":"https://github.com/e-mission/e-mission-phone/pull/74","diff_url":"https://github.com/e-mission/e-mission-phone/pull/74.diff","patch_url":"https://github.com/e-mission/e-mission-phone/pull/74.patch","issue_url":"https://api.github.com/repos/e-mission/e-mission-phone/issues/74","number":74,"state":"open","locked":false,"title":"Chartspr","user":{"login":"krisma","id":6029441,"avatar_url":"https://avatars.githubusercontent.com/u/6029441?v=3","gravatar_id":"","url":"https://api.github.com/users/krisma","html_url":"https://github.com/krisma","followers_url":"https://api.github.com/users/krisma/followers","following_url":"https://api.github.com/users/krisma/following{/other_user}","gists_url":"https://api.github.com/users/krisma/gists{/gist_id}","starred_url":"https://api.github.com/users/krisma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krisma/subscriptions","organizations_url":"https://api.github.com/users/krisma/orgs","repos_url":"https://api.github.com/users/krisma/repos","events_url":"https://api.github.com/users/krisma/events{/privacy}","received_events_url":"https://api.github.com/users/krisma/received_events","type":"User","site_admin":false},"body":"Charts optimized.\r\n0. Overlap resolved.\r\n1. Now the bar width is constant. I estimate a linear function for bar height. d3 charts use transform:translate to control size so height and width are Nan. I have to estimate.\r\n2. Head and tail 0s are eliminated.\r\n![simulator screen shot jul 17 2016 5 14 18 am](https://cloud.githubusercontent.com/assets/6029441/16900622/a31c9034-4bde-11e6-9d4d-5854d3e946b4.png)\r\n![simulator screen shot jul 17 2016 5 14 12 am](https://cloud.githubusercontent.com/assets/6029441/16900620/a318d732-4bde-11e6-8ece-4d0f19381795.png)\r\n![simulator screen shot jul 17 2016 5 14 08 am](https://cloud.githubusercontent.com/assets/6029441/16900621/a31a2e84-4bde-11e6-8d9e-897bda988ead.png)\r\n","created_at":"2016-07-17T12:23:49Z","updated_at":"2016-07-17T13:25:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08429a811af98939a4eae6b4baefd8c931c824a6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/e-mission/e-mission-phone/pulls/74/commits","review_comments_url":"https://api.github.com/repos/e-mission/e-mission-phone/pulls/74/comments","review_comment_url":"https://api.github.com/repos/e-mission/e-mission-phone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/e-mission/e-mission-phone/issues/74/comments","statuses_url":"https://api.github.com/repos/e-mission/e-mission-phone/statuses/8c8288aa3cedf61e88720ebd53481142f9366dc0","head":{"label":"krisma:chartspr","ref":"chartspr","sha":"8c8288aa3cedf61e88720ebd53481142f9366dc0","user":{"login":"krisma","id":6029441,"avatar_url":"https://avatars.githubusercontent.com/u/6029441?v=3","gravatar_id":"","url":"https://api.github.com/users/krisma","html_url":"https://github.com/krisma","followers_url":"https://api.github.com/users/krisma/followers","following_url":"https://api.github.com/users/krisma/following{/other_user}","gists_url":"https://api.github.com/users/krisma/gists{/gist_id}","starred_url":"https://api.github.com/users/krisma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krisma/subscriptions","organizations_url":"https://api.github.com/users/krisma/orgs","repos_url":"https://api.github.com/users/krisma/repos","events_url":"https://api.github.com/users/krisma/events{/privacy}","received_events_url":"https://api.github.com/users/krisma/received_events","type":"User","site_admin":false},"repo":{"id":51182067,"name":"e-mission-phone","full_name":"krisma/e-mission-phone","owner":{"login":"krisma","id":6029441,"avatar_url":"https://avatars.githubusercontent.com/u/6029441?v=3","gravatar_id":"","url":"https://api.github.com/users/krisma","html_url":"https://github.com/krisma","followers_url":"https://api.github.com/users/krisma/followers","following_url":"https://api.github.com/users/krisma/following{/other_user}","gists_url":"https://api.github.com/users/krisma/gists{/gist_id}","starred_url":"https://api.github.com/users/krisma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krisma/subscriptions","organizations_url":"https://api.github.com/users/krisma/orgs","repos_url":"https://api.github.com/users/krisma/repos","events_url":"https://api.github.com/users/krisma/events{/privacy}","received_events_url":"https://api.github.com/users/krisma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krisma/e-mission-phone","description":"","fork":true,"url":"https://api.github.com/repos/krisma/e-mission-phone","forks_url":"https://api.github.com/repos/krisma/e-mission-phone/forks","keys_url":"https://api.github.com/repos/krisma/e-mission-phone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krisma/e-mission-phone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krisma/e-mission-phone/teams","hooks_url":"https://api.github.com/repos/krisma/e-mission-phone/hooks","issue_events_url":"https://api.github.com/repos/krisma/e-mission-phone/issues/events{/number}","events_url":"https://api.github.com/repos/krisma/e-mission-phone/events","assignees_url":"https://api.github.com/repos/krisma/e-mission-phone/assignees{/user}","branches_url":"https://api.github.com/repos/krisma/e-mission-phone/branches{/branch}","tags_url":"https://api.github.com/repos/krisma/e-mission-phone/tags","blobs_url":"https://api.github.com/repos/krisma/e-mission-phone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krisma/e-mission-phone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krisma/e-mission-phone/git/refs{/sha}","trees_url":"https://api.github.com/repos/krisma/e-mission-phone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krisma/e-mission-phone/statuses/{sha}","languages_url":"https://api.github.com/repos/krisma/e-mission-phone/languages","stargazers_url":"https://api.github.com/repos/krisma/e-mission-phone/stargazers","contributors_url":"https://api.github.com/repos/krisma/e-mission-phone/contributors","subscribers_url":"https://api.github.com/repos/krisma/e-mission-phone/subscribers","subscription_url":"https://api.github.com/repos/krisma/e-mission-phone/subscription","commits_url":"https://api.github.com/repos/krisma/e-mission-phone/commits{/sha}","git_commits_url":"https://api.github.com/repos/krisma/e-mission-phone/git/commits{/sha}","comments_url":"https://api.github.com/repos/krisma/e-mission-phone/comments{/number}","issue_comment_url":"https://api.github.com/repos/krisma/e-mission-phone/issues/comments{/number}","contents_url":"https://api.github.com/repos/krisma/e-mission-phone/contents/{+path}","compare_url":"https://api.github.com/repos/krisma/e-mission-phone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krisma/e-mission-phone/merges","archive_url":"https://api.github.com/repos/krisma/e-mission-phone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krisma/e-mission-phone/downloads","issues_url":"https://api.github.com/repos/krisma/e-mission-phone/issues{/number}","pulls_url":"https://api.github.com/repos/krisma/e-mission-phone/pulls{/number}","milestones_url":"https://api.github.com/repos/krisma/e-mission-phone/milestones{/number}","notifications_url":"https://api.github.com/repos/krisma/e-mission-phone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krisma/e-mission-phone/labels{/name}","releases_url":"https://api.github.com/repos/krisma/e-mission-phone/releases{/id}","deployments_url":"https://api.github.com/repos/krisma/e-mission-phone/deployments","created_at":"2016-02-06T00:07:11Z","updated_at":"2016-02-06T00:07:12Z","pushed_at":"2016-07-17T12:36:06Z","git_url":"git://github.com/krisma/e-mission-phone.git","ssh_url":"git@github.com:krisma/e-mission-phone.git","clone_url":"https://github.com/krisma/e-mission-phone.git","svn_url":"https://github.com/krisma/e-mission-phone","homepage":null,"size":18099,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"e-mission:master","ref":"master","sha":"5fa29fc920ed3d2491be3e271cd35c1a621d63a8","user":{"login":"e-mission","id":10713694,"avatar_url":"https://avatars.githubusercontent.com/u/10713694?v=3","gravatar_id":"","url":"https://api.github.com/users/e-mission","html_url":"https://github.com/e-mission","followers_url":"https://api.github.com/users/e-mission/followers","following_url":"https://api.github.com/users/e-mission/following{/other_user}","gists_url":"https://api.github.com/users/e-mission/gists{/gist_id}","starred_url":"https://api.github.com/users/e-mission/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-mission/subscriptions","organizations_url":"https://api.github.com/users/e-mission/orgs","repos_url":"https://api.github.com/users/e-mission/repos","events_url":"https://api.github.com/users/e-mission/events{/privacy}","received_events_url":"https://api.github.com/users/e-mission/received_events","type":"Organization","site_admin":false},"repo":{"id":50543793,"name":"e-mission-phone","full_name":"e-mission/e-mission-phone","owner":{"login":"e-mission","id":10713694,"avatar_url":"https://avatars.githubusercontent.com/u/10713694?v=3","gravatar_id":"","url":"https://api.github.com/users/e-mission","html_url":"https://github.com/e-mission","followers_url":"https://api.github.com/users/e-mission/followers","following_url":"https://api.github.com/users/e-mission/following{/other_user}","gists_url":"https://api.github.com/users/e-mission/gists{/gist_id}","starred_url":"https://api.github.com/users/e-mission/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/e-mission/subscriptions","organizations_url":"https://api.github.com/users/e-mission/orgs","repos_url":"https://api.github.com/users/e-mission/repos","events_url":"https://api.github.com/users/e-mission/events{/privacy}","received_events_url":"https://api.github.com/users/e-mission/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/e-mission/e-mission-phone","description":"","fork":false,"url":"https://api.github.com/repos/e-mission/e-mission-phone","forks_url":"https://api.github.com/repos/e-mission/e-mission-phone/forks","keys_url":"https://api.github.com/repos/e-mission/e-mission-phone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/e-mission/e-mission-phone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/e-mission/e-mission-phone/teams","hooks_url":"https://api.github.com/repos/e-mission/e-mission-phone/hooks","issue_events_url":"https://api.github.com/repos/e-mission/e-mission-phone/issues/events{/number}","events_url":"https://api.github.com/repos/e-mission/e-mission-phone/events","assignees_url":"https://api.github.com/repos/e-mission/e-mission-phone/assignees{/user}","branches_url":"https://api.github.com/repos/e-mission/e-mission-phone/branches{/branch}","tags_url":"https://api.github.com/repos/e-mission/e-mission-phone/tags","blobs_url":"https://api.github.com/repos/e-mission/e-mission-phone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/e-mission/e-mission-phone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/e-mission/e-mission-phone/git/refs{/sha}","trees_url":"https://api.github.com/repos/e-mission/e-mission-phone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/e-mission/e-mission-phone/statuses/{sha}","languages_url":"https://api.github.com/repos/e-mission/e-mission-phone/languages","stargazers_url":"https://api.github.com/repos/e-mission/e-mission-phone/stargazers","contributors_url":"https://api.github.com/repos/e-mission/e-mission-phone/contributors","subscribers_url":"https://api.github.com/repos/e-mission/e-mission-phone/subscribers","subscription_url":"https://api.github.com/repos/e-mission/e-mission-phone/subscription","commits_url":"https://api.github.com/repos/e-mission/e-mission-phone/commits{/sha}","git_commits_url":"https://api.github.com/repos/e-mission/e-mission-phone/git/commits{/sha}","comments_url":"https://api.github.com/repos/e-mission/e-mission-phone/comments{/number}","issue_comment_url":"https://api.github.com/repos/e-mission/e-mission-phone/issues/comments{/number}","contents_url":"https://api.github.com/repos/e-mission/e-mission-phone/contents/{+path}","compare_url":"https://api.github.com/repos/e-mission/e-mission-phone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/e-mission/e-mission-phone/merges","archive_url":"https://api.github.com/repos/e-mission/e-mission-phone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/e-mission/e-mission-phone/downloads","issues_url":"https://api.github.com/repos/e-mission/e-mission-phone/issues{/number}","pulls_url":"https://api.github.com/repos/e-mission/e-mission-phone/pulls{/number}","milestones_url":"https://api.github.com/repos/e-mission/e-mission-phone/milestones{/number}","notifications_url":"https://api.github.com/repos/e-mission/e-mission-phone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/e-mission/e-mission-phone/labels{/name}","releases_url":"https://api.github.com/repos/e-mission/e-mission-phone/releases{/id}","deployments_url":"https://api.github.com/repos/e-mission/e-mission-phone/deployments","created_at":"2016-01-27T22:53:08Z","updated_at":"2016-01-28T06:55:11Z","pushed_at":"2016-07-17T12:36:06Z","git_url":"git://github.com/e-mission/e-mission-phone.git","ssh_url":"git@github.com:e-mission/e-mission-phone.git","clone_url":"https://github.com/e-mission/e-mission-phone.git","svn_url":"https://github.com/e-mission/e-mission-phone","homepage":null,"size":18073,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":23,"forks":13,"open_issues":23,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/e-mission/e-mission-phone/pulls/74"},"html":{"href":"https://github.com/e-mission/e-mission-phone/pull/74"},"issue":{"href":"https://api.github.com/repos/e-mission/e-mission-phone/issues/74"},"comments":{"href":"https://api.github.com/repos/e-mission/e-mission-phone/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/e-mission/e-mission-phone/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/e-mission/e-mission-phone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/e-mission/e-mission-phone/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/e-mission/e-mission-phone/statuses/8c8288aa3cedf61e88720ebd53481142f9366dc0"}}}}
{"actor":{"display_login":"shankari"}}