{"action":"closed","number":150,"pull_request":{"url":"https://api.github.com/repos/mobify/astro-scaffold/pulls/150","id":96607668,"html_url":"https://github.com/mobify/astro-scaffold/pull/150","diff_url":"https://github.com/mobify/astro-scaffold/pull/150.diff","patch_url":"https://github.com/mobify/astro-scaffold/pull/150.patch","issue_url":"https://api.github.com/repos/mobify/astro-scaffold/issues/150","number":150,"state":"closed","locked":false,"title":"Side-by-Side install","user":{"login":"jeremywiebe","id":77138,"avatar_url":"https://avatars.githubusercontent.com/u/77138?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremywiebe","html_url":"https://github.com/jeremywiebe","followers_url":"https://api.github.com/users/jeremywiebe/followers","following_url":"https://api.github.com/users/jeremywiebe/following{/other_user}","gists_url":"https://api.github.com/users/jeremywiebe/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremywiebe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremywiebe/subscriptions","organizations_url":"https://api.github.com/users/jeremywiebe/orgs","repos_url":"https://api.github.com/users/jeremywiebe/repos","events_url":"https://api.github.com/users/jeremywiebe/events{/privacy}","received_events_url":"https://api.github.com/users/jeremywiebe/received_events","type":"User","site_admin":false},"body":"This PR enables side-by-side install of a Preview-enabled build and non-preview enabled. This makes it possible to install an App Store version and a preview version. \r\n\r\nJIRA: N/A\r\nLinked PRs: https://github.com/mobify/astro-scaffold/pull/148\r\n\r\n## Changes\r\n- Add \"Preview\" app icon and configure it to be used in the `PreviewEnabledRelease` build config\r\n- Use the `PRODUCT_BUNDLE_IDENTIFIER` for the `CFBundleIdentifier` in the Info.plist\r\n- Create a new user-defined build setting `BUNDLE_IDENTIFIER`\r\n- Use the new `BUNDLE_IDENTIFIER` for `CFBundleDisplayName` in the Info.plist \r\n\r\n## How to test-drive this PR\r\n- Run the app \r\n- Switch to use the `PreviewEnabledRelease` configuration and run again.\r\n- Note that there are two Scaffold apps (one that has a ` *P` suffix.. for \"preview\")\r\n\r\n## TODOS:\r\n- [x] Change works in both Android and iOS.\r\n- [x] CHANGELOG.md has been updated.\r\n- [ ] Run the generator to make sure it still functions correctly.\r\n- [x] +1 from an engineer on the Astro team.\r\n- [ ] Both tab layout and drawer layout are fully functional in ios. (Set `useTabLayout` in `baseConfig`)\r\n","created_at":"2016-12-05T20:57:21Z","updated_at":"2016-12-05T22:19:54Z","closed_at":"2016-12-05T22:19:54Z","merged_at":"2016-12-05T22:19:54Z","merge_commit_sha":"f89a65714af2f24f82d65414de144b32ea0d98ea","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mobify/astro-scaffold/pulls/150/commits","review_comments_url":"https://api.github.com/repos/mobify/astro-scaffold/pulls/150/comments","review_comment_url":"https://api.github.com/repos/mobify/astro-scaffold/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mobify/astro-scaffold/issues/150/comments","statuses_url":"https://api.github.com/repos/mobify/astro-scaffold/statuses/dd53e3926c60083e846016092a6fc126074c0c9a","head":{"label":"mobify:side-by-side-install","ref":"side-by-side-install","sha":"dd53e3926c60083e846016092a6fc126074c0c9a","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":34024647,"name":"astro-scaffold","full_name":"mobify/astro-scaffold","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/astro-scaffold","description":"🏗 Starting point for building Astro applications!","fork":false,"url":"https://api.github.com/repos/mobify/astro-scaffold","forks_url":"https://api.github.com/repos/mobify/astro-scaffold/forks","keys_url":"https://api.github.com/repos/mobify/astro-scaffold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/astro-scaffold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/astro-scaffold/teams","hooks_url":"https://api.github.com/repos/mobify/astro-scaffold/hooks","issue_events_url":"https://api.github.com/repos/mobify/astro-scaffold/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/astro-scaffold/events","assignees_url":"https://api.github.com/repos/mobify/astro-scaffold/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/astro-scaffold/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/astro-scaffold/tags","blobs_url":"https://api.github.com/repos/mobify/astro-scaffold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/astro-scaffold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/astro-scaffold/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/astro-scaffold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/astro-scaffold/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/astro-scaffold/languages","stargazers_url":"https://api.github.com/repos/mobify/astro-scaffold/stargazers","contributors_url":"https://api.github.com/repos/mobify/astro-scaffold/contributors","subscribers_url":"https://api.github.com/repos/mobify/astro-scaffold/subscribers","subscription_url":"https://api.github.com/repos/mobify/astro-scaffold/subscription","commits_url":"https://api.github.com/repos/mobify/astro-scaffold/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/astro-scaffold/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/astro-scaffold/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/astro-scaffold/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/astro-scaffold/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/astro-scaffold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/astro-scaffold/merges","archive_url":"https://api.github.com/repos/mobify/astro-scaffold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/astro-scaffold/downloads","issues_url":"https://api.github.com/repos/mobify/astro-scaffold/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/astro-scaffold/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/astro-scaffold/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/astro-scaffold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/astro-scaffold/labels{/name}","releases_url":"https://api.github.com/repos/mobify/astro-scaffold/releases{/id}","deployments_url":"https://api.github.com/repos/mobify/astro-scaffold/deployments","created_at":"2015-04-15T23:56:36Z","updated_at":"2016-10-26T16:27:42Z","pushed_at":"2016-12-05T22:19:54Z","git_url":"git://github.com/mobify/astro-scaffold.git","ssh_url":"git@github.com:mobify/astro-scaffold.git","clone_url":"https://github.com/mobify/astro-scaffold.git","svn_url":"https://github.com/mobify/astro-scaffold","homepage":"http://astro.mobify.com/","size":1348,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":4,"default_branch":"develop"}},"base":{"label":"mobify:develop","ref":"develop","sha":"185e809550d152ce52ebeee72c3bfd29c8136b47","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":34024647,"name":"astro-scaffold","full_name":"mobify/astro-scaffold","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/astro-scaffold","description":"🏗 Starting point for building Astro applications!","fork":false,"url":"https://api.github.com/repos/mobify/astro-scaffold","forks_url":"https://api.github.com/repos/mobify/astro-scaffold/forks","keys_url":"https://api.github.com/repos/mobify/astro-scaffold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/astro-scaffold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/astro-scaffold/teams","hooks_url":"https://api.github.com/repos/mobify/astro-scaffold/hooks","issue_events_url":"https://api.github.com/repos/mobify/astro-scaffold/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/astro-scaffold/events","assignees_url":"https://api.github.com/repos/mobify/astro-scaffold/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/astro-scaffold/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/astro-scaffold/tags","blobs_url":"https://api.github.com/repos/mobify/astro-scaffold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/astro-scaffold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/astro-scaffold/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/astro-scaffold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/astro-scaffold/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/astro-scaffold/languages","stargazers_url":"https://api.github.com/repos/mobify/astro-scaffold/stargazers","contributors_url":"https://api.github.com/repos/mobify/astro-scaffold/contributors","subscribers_url":"https://api.github.com/repos/mobify/astro-scaffold/subscribers","subscription_url":"https://api.github.com/repos/mobify/astro-scaffold/subscription","commits_url":"https://api.github.com/repos/mobify/astro-scaffold/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/astro-scaffold/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/astro-scaffold/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/astro-scaffold/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/astro-scaffold/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/astro-scaffold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/astro-scaffold/merges","archive_url":"https://api.github.com/repos/mobify/astro-scaffold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/astro-scaffold/downloads","issues_url":"https://api.github.com/repos/mobify/astro-scaffold/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/astro-scaffold/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/astro-scaffold/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/astro-scaffold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/astro-scaffold/labels{/name}","releases_url":"https://api.github.com/repos/mobify/astro-scaffold/releases{/id}","deployments_url":"https://api.github.com/repos/mobify/astro-scaffold/deployments","created_at":"2015-04-15T23:56:36Z","updated_at":"2016-10-26T16:27:42Z","pushed_at":"2016-12-05T22:19:54Z","git_url":"git://github.com/mobify/astro-scaffold.git","ssh_url":"git@github.com:mobify/astro-scaffold.git","clone_url":"https://github.com/mobify/astro-scaffold.git","svn_url":"https://github.com/mobify/astro-scaffold","homepage":"http://astro.mobify.com/","size":1348,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mobify/astro-scaffold/pulls/150"},"html":{"href":"https://github.com/mobify/astro-scaffold/pull/150"},"issue":{"href":"https://api.github.com/repos/mobify/astro-scaffold/issues/150"},"comments":{"href":"https://api.github.com/repos/mobify/astro-scaffold/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/mobify/astro-scaffold/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/mobify/astro-scaffold/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mobify/astro-scaffold/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/mobify/astro-scaffold/statuses/dd53e3926c60083e846016092a6fc126074c0c9a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jeremywiebe","id":77138,"avatar_url":"https://avatars.githubusercontent.com/u/77138?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremywiebe","html_url":"https://github.com/jeremywiebe","followers_url":"https://api.github.com/users/jeremywiebe/followers","following_url":"https://api.github.com/users/jeremywiebe/following{/other_user}","gists_url":"https://api.github.com/users/jeremywiebe/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremywiebe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremywiebe/subscriptions","organizations_url":"https://api.github.com/users/jeremywiebe/orgs","repos_url":"https://api.github.com/users/jeremywiebe/repos","events_url":"https://api.github.com/users/jeremywiebe/events{/privacy}","received_events_url":"https://api.github.com/users/jeremywiebe/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"commits":5,"additions":72,"deletions":68,"changed_files":6}}
{"actor":{"display_login":"jeremywiebe"}}