{"action":"created","comment":{"url":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/comments/56699836","id":56699836,"diff_hunk":"@@ -32,7 +34,8 @@\n     private static final String INVALID_FILTER_STYLE = \"-fx-control-inner-background: #EE8993\";\n \n     // Callback functions\n-    private Runnable cancel = () -> {};\n+    private Runnable onCancel = () -> {};\n+    private Runnable onHelp = () -> {};","path":"src/main/java/ui/components/FilterTextField.java","position":15,"original_position":15,"commit_id":"82d5037e5eec32ea9ec347c9923e519c815fb563","original_commit_id":"82d5037e5eec32ea9ec347c9923e519c815fb563","user":{"login":"dariusf","id":4328341,"avatar_url":"https://avatars.githubusercontent.com/u/4328341?v=3","gravatar_id":"","url":"https://api.github.com/users/dariusf","html_url":"https://github.com/dariusf","followers_url":"https://api.github.com/users/dariusf/followers","following_url":"https://api.github.com/users/dariusf/following{/other_user}","gists_url":"https://api.github.com/users/dariusf/gists{/gist_id}","starred_url":"https://api.github.com/users/dariusf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dariusf/subscriptions","organizations_url":"https://api.github.com/users/dariusf/orgs","repos_url":"https://api.github.com/users/dariusf/repos","events_url":"https://api.github.com/users/dariusf/events{/privacy}","received_events_url":"https://api.github.com/users/dariusf/received_events","type":"User","site_admin":false},"body":"This is a good change. Maybe also rename `confirm` while you're at it?","created_at":"2016-03-18T18:14:06Z","updated_at":"2016-03-18T18:14:06Z","html_url":"https://github.com/HubTurbo/HubTurbo/pull/1340#discussion_r56699836","pull_request_url":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/1340","_links":{"self":{"href":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/comments/56699836"},"html":{"href":"https://github.com/HubTurbo/HubTurbo/pull/1340#discussion_r56699836"},"pull_request":{"href":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/1340"}}},"pull_request":{"url":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/1340","id":62647840,"html_url":"https://github.com/HubTurbo/HubTurbo/pull/1340","diff_url":"https://github.com/HubTurbo/HubTurbo/pull/1340.diff","patch_url":"https://github.com/HubTurbo/HubTurbo/pull/1340.patch","issue_url":"https://api.github.com/repos/HubTurbo/HubTurbo/issues/1340","number":1340,"state":"open","locked":false,"title":"F1 key doesn't work when the focus is in a filter box #1167","user":{"login":"YijinL","id":7914712,"avatar_url":"https://avatars.githubusercontent.com/u/7914712?v=3","gravatar_id":"","url":"https://api.github.com/users/YijinL","html_url":"https://github.com/YijinL","followers_url":"https://api.github.com/users/YijinL/followers","following_url":"https://api.github.com/users/YijinL/following{/other_user}","gists_url":"https://api.github.com/users/YijinL/gists{/gist_id}","starred_url":"https://api.github.com/users/YijinL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YijinL/subscriptions","organizations_url":"https://api.github.com/users/YijinL/orgs","repos_url":"https://api.github.com/users/YijinL/repos","events_url":"https://api.github.com/users/YijinL/events{/privacy}","received_events_url":"https://api.github.com/users/YijinL/received_events","type":"User","site_admin":false},"body":"Fixes #1167.\r\n\r\n**REVIEW**\r\n\r\n**Current status**:\r\nWhen filter text box is in focus, pressing <kbd>F1</kbd> redirects the browser component to the filter docs page.\r\n\r\n**Work done**: \r\n- ~~`FilterPanel` now passes its `UI` reference to `FilterTextField`~~\r\n- ~~`FilterTextField` now maintains a final field to hold the `UI`reference~~\r\n- ~~`FilterTextField` setup method now includes handling for the `KeyboardShortcuts.SHOW_DOCS` key combination (<kbd>F1</kbd>), which calls UI's browser's`BrowserComponent.showDocs()` method.~~\r\n- ~~The above handling code is copied from a [slice](https://github.com/HubTurbo/HubTurbo/blob/880d65c081505c9e8a547c29d188293a56c5de24/src/main/java/ui/listpanel/ListPanel.java#L171-L173) of `ListPanel.setupKeyboardShorcuts()`~~\r\n- Make F1 link to 'filters' section of docs\r\n- Change implementation: expose help key press callback hook on FilterTextField to decouple from rest of app\r\n- All instantiations of FilterTextField now register the correct callback for help key press\r\n\r\n**Future**:\r\nnull","created_at":"2016-03-12T18:04:31Z","updated_at":"2016-03-18T18:14:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40508b5f5a45bcd7e0f4e365aafba86e2ef10854","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/1340/commits","review_comments_url":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/1340/comments","review_comment_url":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HubTurbo/HubTurbo/issues/1340/comments","statuses_url":"https://api.github.com/repos/HubTurbo/HubTurbo/statuses/82d5037e5eec32ea9ec347c9923e519c815fb563","head":{"label":"YijinL:#1167-F1-key-filter-box-focus","ref":"#1167-F1-key-filter-box-focus","sha":"82d5037e5eec32ea9ec347c9923e519c815fb563","user":{"login":"YijinL","id":7914712,"avatar_url":"https://avatars.githubusercontent.com/u/7914712?v=3","gravatar_id":"","url":"https://api.github.com/users/YijinL","html_url":"https://github.com/YijinL","followers_url":"https://api.github.com/users/YijinL/followers","following_url":"https://api.github.com/users/YijinL/following{/other_user}","gists_url":"https://api.github.com/users/YijinL/gists{/gist_id}","starred_url":"https://api.github.com/users/YijinL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YijinL/subscriptions","organizations_url":"https://api.github.com/users/YijinL/orgs","repos_url":"https://api.github.com/users/YijinL/repos","events_url":"https://api.github.com/users/YijinL/events{/privacy}","received_events_url":"https://api.github.com/users/YijinL/received_events","type":"User","site_admin":false},"repo":{"id":52203145,"name":"HubTurbo","full_name":"YijinL/HubTurbo","owner":{"login":"YijinL","id":7914712,"avatar_url":"https://avatars.githubusercontent.com/u/7914712?v=3","gravatar_id":"","url":"https://api.github.com/users/YijinL","html_url":"https://github.com/YijinL","followers_url":"https://api.github.com/users/YijinL/followers","following_url":"https://api.github.com/users/YijinL/following{/other_user}","gists_url":"https://api.github.com/users/YijinL/gists{/gist_id}","starred_url":"https://api.github.com/users/YijinL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YijinL/subscriptions","organizations_url":"https://api.github.com/users/YijinL/orgs","repos_url":"https://api.github.com/users/YijinL/repos","events_url":"https://api.github.com/users/YijinL/events{/privacy}","received_events_url":"https://api.github.com/users/YijinL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/YijinL/HubTurbo","description":"A companion to GitHub for your desktop","fork":true,"url":"https://api.github.com/repos/YijinL/HubTurbo","forks_url":"https://api.github.com/repos/YijinL/HubTurbo/forks","keys_url":"https://api.github.com/repos/YijinL/HubTurbo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YijinL/HubTurbo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YijinL/HubTurbo/teams","hooks_url":"https://api.github.com/repos/YijinL/HubTurbo/hooks","issue_events_url":"https://api.github.com/repos/YijinL/HubTurbo/issues/events{/number}","events_url":"https://api.github.com/repos/YijinL/HubTurbo/events","assignees_url":"https://api.github.com/repos/YijinL/HubTurbo/assignees{/user}","branches_url":"https://api.github.com/repos/YijinL/HubTurbo/branches{/branch}","tags_url":"https://api.github.com/repos/YijinL/HubTurbo/tags","blobs_url":"https://api.github.com/repos/YijinL/HubTurbo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YijinL/HubTurbo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YijinL/HubTurbo/git/refs{/sha}","trees_url":"https://api.github.com/repos/YijinL/HubTurbo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YijinL/HubTurbo/statuses/{sha}","languages_url":"https://api.github.com/repos/YijinL/HubTurbo/languages","stargazers_url":"https://api.github.com/repos/YijinL/HubTurbo/stargazers","contributors_url":"https://api.github.com/repos/YijinL/HubTurbo/contributors","subscribers_url":"https://api.github.com/repos/YijinL/HubTurbo/subscribers","subscription_url":"https://api.github.com/repos/YijinL/HubTurbo/subscription","commits_url":"https://api.github.com/repos/YijinL/HubTurbo/commits{/sha}","git_commits_url":"https://api.github.com/repos/YijinL/HubTurbo/git/commits{/sha}","comments_url":"https://api.github.com/repos/YijinL/HubTurbo/comments{/number}","issue_comment_url":"https://api.github.com/repos/YijinL/HubTurbo/issues/comments{/number}","contents_url":"https://api.github.com/repos/YijinL/HubTurbo/contents/{+path}","compare_url":"https://api.github.com/repos/YijinL/HubTurbo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YijinL/HubTurbo/merges","archive_url":"https://api.github.com/repos/YijinL/HubTurbo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YijinL/HubTurbo/downloads","issues_url":"https://api.github.com/repos/YijinL/HubTurbo/issues{/number}","pulls_url":"https://api.github.com/repos/YijinL/HubTurbo/pulls{/number}","milestones_url":"https://api.github.com/repos/YijinL/HubTurbo/milestones{/number}","notifications_url":"https://api.github.com/repos/YijinL/HubTurbo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YijinL/HubTurbo/labels{/name}","releases_url":"https://api.github.com/repos/YijinL/HubTurbo/releases{/id}","deployments_url":"https://api.github.com/repos/YijinL/HubTurbo/deployments","created_at":"2016-02-21T11:22:23Z","updated_at":"2016-03-18T15:22:16Z","pushed_at":"2016-03-18T07:27:18Z","git_url":"git://github.com/YijinL/HubTurbo.git","ssh_url":"git@github.com:YijinL/HubTurbo.git","clone_url":"https://github.com/YijinL/HubTurbo.git","svn_url":"https://github.com/YijinL/HubTurbo","homepage":"http://hubturbo.info","size":133479,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"HubTurbo:master","ref":"master","sha":"880d65c081505c9e8a547c29d188293a56c5de24","user":{"login":"HubTurbo","id":7955871,"avatar_url":"https://avatars.githubusercontent.com/u/7955871?v=3","gravatar_id":"","url":"https://api.github.com/users/HubTurbo","html_url":"https://github.com/HubTurbo","followers_url":"https://api.github.com/users/HubTurbo/followers","following_url":"https://api.github.com/users/HubTurbo/following{/other_user}","gists_url":"https://api.github.com/users/HubTurbo/gists{/gist_id}","starred_url":"https://api.github.com/users/HubTurbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubTurbo/subscriptions","organizations_url":"https://api.github.com/users/HubTurbo/orgs","repos_url":"https://api.github.com/users/HubTurbo/repos","events_url":"https://api.github.com/users/HubTurbo/events{/privacy}","received_events_url":"https://api.github.com/users/HubTurbo/received_events","type":"Organization","site_admin":false},"repo":{"id":20919534,"name":"HubTurbo","full_name":"HubTurbo/HubTurbo","owner":{"login":"HubTurbo","id":7955871,"avatar_url":"https://avatars.githubusercontent.com/u/7955871?v=3","gravatar_id":"","url":"https://api.github.com/users/HubTurbo","html_url":"https://github.com/HubTurbo","followers_url":"https://api.github.com/users/HubTurbo/followers","following_url":"https://api.github.com/users/HubTurbo/following{/other_user}","gists_url":"https://api.github.com/users/HubTurbo/gists{/gist_id}","starred_url":"https://api.github.com/users/HubTurbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubTurbo/subscriptions","organizations_url":"https://api.github.com/users/HubTurbo/orgs","repos_url":"https://api.github.com/users/HubTurbo/repos","events_url":"https://api.github.com/users/HubTurbo/events{/privacy}","received_events_url":"https://api.github.com/users/HubTurbo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HubTurbo/HubTurbo","description":"A companion to GitHub for your desktop","fork":false,"url":"https://api.github.com/repos/HubTurbo/HubTurbo","forks_url":"https://api.github.com/repos/HubTurbo/HubTurbo/forks","keys_url":"https://api.github.com/repos/HubTurbo/HubTurbo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HubTurbo/HubTurbo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HubTurbo/HubTurbo/teams","hooks_url":"https://api.github.com/repos/HubTurbo/HubTurbo/hooks","issue_events_url":"https://api.github.com/repos/HubTurbo/HubTurbo/issues/events{/number}","events_url":"https://api.github.com/repos/HubTurbo/HubTurbo/events","assignees_url":"https://api.github.com/repos/HubTurbo/HubTurbo/assignees{/user}","branches_url":"https://api.github.com/repos/HubTurbo/HubTurbo/branches{/branch}","tags_url":"https://api.github.com/repos/HubTurbo/HubTurbo/tags","blobs_url":"https://api.github.com/repos/HubTurbo/HubTurbo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HubTurbo/HubTurbo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HubTurbo/HubTurbo/git/refs{/sha}","trees_url":"https://api.github.com/repos/HubTurbo/HubTurbo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HubTurbo/HubTurbo/statuses/{sha}","languages_url":"https://api.github.com/repos/HubTurbo/HubTurbo/languages","stargazers_url":"https://api.github.com/repos/HubTurbo/HubTurbo/stargazers","contributors_url":"https://api.github.com/repos/HubTurbo/HubTurbo/contributors","subscribers_url":"https://api.github.com/repos/HubTurbo/HubTurbo/subscribers","subscription_url":"https://api.github.com/repos/HubTurbo/HubTurbo/subscription","commits_url":"https://api.github.com/repos/HubTurbo/HubTurbo/commits{/sha}","git_commits_url":"https://api.github.com/repos/HubTurbo/HubTurbo/git/commits{/sha}","comments_url":"https://api.github.com/repos/HubTurbo/HubTurbo/comments{/number}","issue_comment_url":"https://api.github.com/repos/HubTurbo/HubTurbo/issues/comments{/number}","contents_url":"https://api.github.com/repos/HubTurbo/HubTurbo/contents/{+path}","compare_url":"https://api.github.com/repos/HubTurbo/HubTurbo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HubTurbo/HubTurbo/merges","archive_url":"https://api.github.com/repos/HubTurbo/HubTurbo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HubTurbo/HubTurbo/downloads","issues_url":"https://api.github.com/repos/HubTurbo/HubTurbo/issues{/number}","pulls_url":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls{/number}","milestones_url":"https://api.github.com/repos/HubTurbo/HubTurbo/milestones{/number}","notifications_url":"https://api.github.com/repos/HubTurbo/HubTurbo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HubTurbo/HubTurbo/labels{/name}","releases_url":"https://api.github.com/repos/HubTurbo/HubTurbo/releases{/id}","deployments_url":"https://api.github.com/repos/HubTurbo/HubTurbo/deployments","created_at":"2014-06-17T10:35:39Z","updated_at":"2016-01-13T06:03:59Z","pushed_at":"2016-03-18T17:59:52Z","git_url":"git://github.com/HubTurbo/HubTurbo.git","ssh_url":"git@github.com:HubTurbo/HubTurbo.git","clone_url":"https://github.com/HubTurbo/HubTurbo.git","svn_url":"https://github.com/HubTurbo/HubTurbo","homepage":"http://hubturbo.info","size":135151,"stargazers_count":15,"watchers_count":15,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":187,"forks":33,"open_issues":187,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/1340"},"html":{"href":"https://github.com/HubTurbo/HubTurbo/pull/1340"},"issue":{"href":"https://api.github.com/repos/HubTurbo/HubTurbo/issues/1340"},"comments":{"href":"https://api.github.com/repos/HubTurbo/HubTurbo/issues/1340/comments"},"review_comments":{"href":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/1340/comments"},"review_comment":{"href":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HubTurbo/HubTurbo/pulls/1340/commits"},"statuses":{"href":"https://api.github.com/repos/HubTurbo/HubTurbo/statuses/82d5037e5eec32ea9ec347c9923e519c815fb563"}}}}