{"action":"created","issue":{"url":"https://api.github.com/repos/fenos/Notifynder/issues/105","repository_url":"https://api.github.com/repos/fenos/Notifynder","labels_url":"https://api.github.com/repos/fenos/Notifynder/issues/105/labels{/name}","comments_url":"https://api.github.com/repos/fenos/Notifynder/issues/105/comments","events_url":"https://api.github.com/repos/fenos/Notifynder/issues/105/events","html_url":"https://github.com/fenos/Notifynder/issues/105","id":149545758,"number":105,"title":"Allow Notifynder builder to add custom data","user":{"login":"fenos","id":4754064,"avatar_url":"https://avatars.githubusercontent.com/u/4754064?v=3","gravatar_id":"","url":"https://api.github.com/users/fenos","html_url":"https://github.com/fenos","followers_url":"https://api.github.com/users/fenos/followers","following_url":"https://api.github.com/users/fenos/following{/other_user}","gists_url":"https://api.github.com/users/fenos/gists{/gist_id}","starred_url":"https://api.github.com/users/fenos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fenos/subscriptions","organizations_url":"https://api.github.com/users/fenos/orgs","repos_url":"https://api.github.com/users/fenos/repos","events_url":"https://api.github.com/users/fenos/events{/privacy}","received_events_url":"https://api.github.com/users/fenos/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/fenos/Notifynder/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/fenos/Notifynder/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"Gummibeer","id":6187884,"avatar_url":"https://avatars.githubusercontent.com/u/6187884?v=3","gravatar_id":"","url":"https://api.github.com/users/Gummibeer","html_url":"https://github.com/Gummibeer","followers_url":"https://api.github.com/users/Gummibeer/followers","following_url":"https://api.github.com/users/Gummibeer/following{/other_user}","gists_url":"https://api.github.com/users/Gummibeer/gists{/gist_id}","starred_url":"https://api.github.com/users/Gummibeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gummibeer/subscriptions","organizations_url":"https://api.github.com/users/Gummibeer/orgs","repos_url":"https://api.github.com/users/Gummibeer/repos","events_url":"https://api.github.com/users/Gummibeer/events{/privacy}","received_events_url":"https://api.github.com/users/Gummibeer/received_events","type":"User","site_admin":false},"assignees":[{"login":"Gummibeer","id":6187884,"avatar_url":"https://avatars.githubusercontent.com/u/6187884?v=3","gravatar_id":"","url":"https://api.github.com/users/Gummibeer","html_url":"https://github.com/Gummibeer","followers_url":"https://api.github.com/users/Gummibeer/followers","following_url":"https://api.github.com/users/Gummibeer/following{/other_user}","gists_url":"https://api.github.com/users/Gummibeer/gists{/gist_id}","starred_url":"https://api.github.com/users/Gummibeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gummibeer/subscriptions","organizations_url":"https://api.github.com/users/Gummibeer/orgs","repos_url":"https://api.github.com/users/Gummibeer/repos","events_url":"https://api.github.com/users/Gummibeer/events{/privacy}","received_events_url":"https://api.github.com/users/Gummibeer/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2016-04-19T18:35:24Z","updated_at":"2016-07-20T16:11:02Z","closed_at":null,"body":"At this stage NotifynderBuilder doesn't allow easily to add custom values for custom columns into the `notifications` table. That is caused from the `setBuilderData` to be protected.\r\nOnce the function will be publicly usable, the developer will have the opportunity to extend the table (if needed).\r\n\r\nAnother move related to this issue, will be to have a minimal **required** validation on this new custom fields, so that the developer can define his custom fields to be globally required at any time."},"comment":{"url":"https://api.github.com/repos/fenos/Notifynder/issues/comments/233998643","html_url":"https://github.com/fenos/Notifynder/issues/105#issuecomment-233998643","issue_url":"https://api.github.com/repos/fenos/Notifynder/issues/105","id":233998643,"user":{"login":"Banandrew","id":6409354,"avatar_url":"https://avatars.githubusercontent.com/u/6409354?v=3","gravatar_id":"","url":"https://api.github.com/users/Banandrew","html_url":"https://github.com/Banandrew","followers_url":"https://api.github.com/users/Banandrew/followers","following_url":"https://api.github.com/users/Banandrew/following{/other_user}","gists_url":"https://api.github.com/users/Banandrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Banandrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Banandrew/subscriptions","organizations_url":"https://api.github.com/users/Banandrew/orgs","repos_url":"https://api.github.com/users/Banandrew/repos","events_url":"https://api.github.com/users/Banandrew/events{/privacy}","received_events_url":"https://api.github.com/users/Banandrew/received_events","type":"User","site_admin":false},"created_at":"2016-07-20T16:11:02Z","updated_at":"2016-07-20T16:11:02Z","body":"I can’t test it, somehow when I navigate to the package and run `../../bin/phpunit` symlink, it returns `PHP Fatal error:  Class 'TestCaseDB' not found in /home/vagrant/code/ecc/vendor/fenos/notifynder/tests/integration/Handler/NotifynderHandlerTest.php on line 13`. I’m not sure if I should be testing the package the same way I test Laravel, though.\r\n\r\n>Just to clearify: in your example the label is the name of your added column and test is the value!?\r\n\r\nYes.\r\n\r\nI tried doing a fresh Laravel install only with the package, thought maybe something else was interfering with the data loss, but it behaved the same way and didn’t set the value there as well—I don’t even know, maybe it’s a Homestead issue.\r\n\r\nIn any case, if I add the field to Notification model’s `$fillable` array, it sets the field correctly, so I guess I’ll just extend Notification class and overwrite `$fillable` for now, maybe it’ll start working at some point in the future. Since all the tests passed, I think this issue can now be closed; thanks for reaching out, Gummibeer, you’re the best! :+1: :heart: "}}
{"actor":{"display_login":"Banandrew"}}