{"action":"closed","number":78,"pull_request":{"url":"https://api.github.com/repos/premailer/css_parser/pulls/78","id":95575030,"html_url":"https://github.com/premailer/css_parser/pull/78","diff_url":"https://github.com/premailer/css_parser/pull/78.diff","patch_url":"https://github.com/premailer/css_parser/pull/78.patch","issue_url":"https://api.github.com/repos/premailer/css_parser/issues/78","number":78,"state":"closed","locked":false,"title":"Fix use of inital value for background-position in shorthand.","user":{"login":"ehlertij","id":174227,"avatar_url":"https://avatars.githubusercontent.com/u/174227?v=3","gravatar_id":"","url":"https://api.github.com/users/ehlertij","html_url":"https://github.com/ehlertij","followers_url":"https://api.github.com/users/ehlertij/followers","following_url":"https://api.github.com/users/ehlertij/following{/other_user}","gists_url":"https://api.github.com/users/ehlertij/gists{/gist_id}","starred_url":"https://api.github.com/users/ehlertij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehlertij/subscriptions","organizations_url":"https://api.github.com/users/ehlertij/orgs","repos_url":"https://api.github.com/users/ehlertij/repos","events_url":"https://api.github.com/users/ehlertij/events{/privacy}","received_events_url":"https://api.github.com/users/ehlertij/received_events","type":"User","site_admin":false},"body":"The use of the `initial` keyword as the value for the `background-position` in the background shorthand is causing the CSS to be invalid (at least in every browser I was able to test). Using the [stated default](http://www.w3schools.com/cssref/pr_background-position.asp) of `0% 0%` instead resolves the issue.\r\n\r\nYou can see the issue in action in this [Codepen](http://codepen.io/ehlertij/pen/bBoqBE). Open the inspector to see the broken CSS:\r\n\r\n<img width=\"608\" alt=\"screen shot 2016-11-28 at 12 54 19 pm\" src=\"https://cloud.githubusercontent.com/assets/174227/20685595/d2540298-b569-11e6-980a-4776702f7cd3.png\">\r\n\r\nMy company ran into the issue after upgrading to the latest version of the gem and had to roll it back to before this was introduced as a result. Issue was introduced in #65 and #66.\r\n\r\nLet me know if you need anything else from me on this one.\r\n\r\n**Update:**\r\n\r\nAccording to [this page on MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/background#Formal_syntax), it appears that `initial` is not a valid value for the shorthand:\r\n\r\n```\r\n<position> = [[ left | center | right | top | bottom | <length-percentage> ] | [ left | center | right | <length-percentage> ] [ top | center | bottom | <length-percentage> ] | [ center | [ left | right ] <length-percentage>? ] && [ center | [ top | bottom ] <length-percentage>? ]]\r\n```\r\n(notice how `initial` does not appear)","created_at":"2016-11-28T20:56:47Z","updated_at":"2016-11-29T16:15:24Z","closed_at":"2016-11-29T16:15:24Z","merged_at":"2016-11-29T16:15:24Z","merge_commit_sha":"210f151a0ff430df32032ab7c866706fe54f85e4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/premailer/css_parser/pulls/78/commits","review_comments_url":"https://api.github.com/repos/premailer/css_parser/pulls/78/comments","review_comment_url":"https://api.github.com/repos/premailer/css_parser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/premailer/css_parser/issues/78/comments","statuses_url":"https://api.github.com/repos/premailer/css_parser/statuses/a074aaa8941a1adb775808d8e8a51960c0597312","head":{"label":"ehlertij:background-position-shorthand-fix","ref":"background-position-shorthand-fix","sha":"a074aaa8941a1adb775808d8e8a51960c0597312","user":{"login":"ehlertij","id":174227,"avatar_url":"https://avatars.githubusercontent.com/u/174227?v=3","gravatar_id":"","url":"https://api.github.com/users/ehlertij","html_url":"https://github.com/ehlertij","followers_url":"https://api.github.com/users/ehlertij/followers","following_url":"https://api.github.com/users/ehlertij/following{/other_user}","gists_url":"https://api.github.com/users/ehlertij/gists{/gist_id}","starred_url":"https://api.github.com/users/ehlertij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehlertij/subscriptions","organizations_url":"https://api.github.com/users/ehlertij/orgs","repos_url":"https://api.github.com/users/ehlertij/repos","events_url":"https://api.github.com/users/ehlertij/events{/privacy}","received_events_url":"https://api.github.com/users/ehlertij/received_events","type":"User","site_admin":false},"repo":{"id":75011743,"name":"css_parser","full_name":"ehlertij/css_parser","owner":{"login":"ehlertij","id":174227,"avatar_url":"https://avatars.githubusercontent.com/u/174227?v=3","gravatar_id":"","url":"https://api.github.com/users/ehlertij","html_url":"https://github.com/ehlertij","followers_url":"https://api.github.com/users/ehlertij/followers","following_url":"https://api.github.com/users/ehlertij/following{/other_user}","gists_url":"https://api.github.com/users/ehlertij/gists{/gist_id}","starred_url":"https://api.github.com/users/ehlertij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehlertij/subscriptions","organizations_url":"https://api.github.com/users/ehlertij/orgs","repos_url":"https://api.github.com/users/ehlertij/repos","events_url":"https://api.github.com/users/ehlertij/events{/privacy}","received_events_url":"https://api.github.com/users/ehlertij/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ehlertij/css_parser","description":"Ruby CSS Parser","fork":true,"url":"https://api.github.com/repos/ehlertij/css_parser","forks_url":"https://api.github.com/repos/ehlertij/css_parser/forks","keys_url":"https://api.github.com/repos/ehlertij/css_parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ehlertij/css_parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ehlertij/css_parser/teams","hooks_url":"https://api.github.com/repos/ehlertij/css_parser/hooks","issue_events_url":"https://api.github.com/repos/ehlertij/css_parser/issues/events{/number}","events_url":"https://api.github.com/repos/ehlertij/css_parser/events","assignees_url":"https://api.github.com/repos/ehlertij/css_parser/assignees{/user}","branches_url":"https://api.github.com/repos/ehlertij/css_parser/branches{/branch}","tags_url":"https://api.github.com/repos/ehlertij/css_parser/tags","blobs_url":"https://api.github.com/repos/ehlertij/css_parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ehlertij/css_parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ehlertij/css_parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/ehlertij/css_parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ehlertij/css_parser/statuses/{sha}","languages_url":"https://api.github.com/repos/ehlertij/css_parser/languages","stargazers_url":"https://api.github.com/repos/ehlertij/css_parser/stargazers","contributors_url":"https://api.github.com/repos/ehlertij/css_parser/contributors","subscribers_url":"https://api.github.com/repos/ehlertij/css_parser/subscribers","subscription_url":"https://api.github.com/repos/ehlertij/css_parser/subscription","commits_url":"https://api.github.com/repos/ehlertij/css_parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/ehlertij/css_parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/ehlertij/css_parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/ehlertij/css_parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/ehlertij/css_parser/contents/{+path}","compare_url":"https://api.github.com/repos/ehlertij/css_parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ehlertij/css_parser/merges","archive_url":"https://api.github.com/repos/ehlertij/css_parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ehlertij/css_parser/downloads","issues_url":"https://api.github.com/repos/ehlertij/css_parser/issues{/number}","pulls_url":"https://api.github.com/repos/ehlertij/css_parser/pulls{/number}","milestones_url":"https://api.github.com/repos/ehlertij/css_parser/milestones{/number}","notifications_url":"https://api.github.com/repos/ehlertij/css_parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ehlertij/css_parser/labels{/name}","releases_url":"https://api.github.com/repos/ehlertij/css_parser/releases{/id}","deployments_url":"https://api.github.com/repos/ehlertij/css_parser/deployments","created_at":"2016-11-28T20:31:57Z","updated_at":"2016-11-28T20:31:58Z","pushed_at":"2016-11-28T20:49:10Z","git_url":"git://github.com/ehlertij/css_parser.git","ssh_url":"git@github.com:ehlertij/css_parser.git","clone_url":"https://github.com/ehlertij/css_parser.git","svn_url":"https://github.com/ehlertij/css_parser","homepage":"","size":311,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"premailer:master","ref":"master","sha":"fbb5f2a75e07c16f8a51b227276f66ecd11e02d3","user":{"login":"premailer","id":5750522,"avatar_url":"https://avatars.githubusercontent.com/u/5750522?v=3","gravatar_id":"","url":"https://api.github.com/users/premailer","html_url":"https://github.com/premailer","followers_url":"https://api.github.com/users/premailer/followers","following_url":"https://api.github.com/users/premailer/following{/other_user}","gists_url":"https://api.github.com/users/premailer/gists{/gist_id}","starred_url":"https://api.github.com/users/premailer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/premailer/subscriptions","organizations_url":"https://api.github.com/users/premailer/orgs","repos_url":"https://api.github.com/users/premailer/repos","events_url":"https://api.github.com/users/premailer/events{/privacy}","received_events_url":"https://api.github.com/users/premailer/received_events","type":"Organization","site_admin":false},"repo":{"id":408234,"name":"css_parser","full_name":"premailer/css_parser","owner":{"login":"premailer","id":5750522,"avatar_url":"https://avatars.githubusercontent.com/u/5750522?v=3","gravatar_id":"","url":"https://api.github.com/users/premailer","html_url":"https://github.com/premailer","followers_url":"https://api.github.com/users/premailer/followers","following_url":"https://api.github.com/users/premailer/following{/other_user}","gists_url":"https://api.github.com/users/premailer/gists{/gist_id}","starred_url":"https://api.github.com/users/premailer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/premailer/subscriptions","organizations_url":"https://api.github.com/users/premailer/orgs","repos_url":"https://api.github.com/users/premailer/repos","events_url":"https://api.github.com/users/premailer/events{/privacy}","received_events_url":"https://api.github.com/users/premailer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/premailer/css_parser","description":"Ruby CSS Parser","fork":false,"url":"https://api.github.com/repos/premailer/css_parser","forks_url":"https://api.github.com/repos/premailer/css_parser/forks","keys_url":"https://api.github.com/repos/premailer/css_parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/premailer/css_parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/premailer/css_parser/teams","hooks_url":"https://api.github.com/repos/premailer/css_parser/hooks","issue_events_url":"https://api.github.com/repos/premailer/css_parser/issues/events{/number}","events_url":"https://api.github.com/repos/premailer/css_parser/events","assignees_url":"https://api.github.com/repos/premailer/css_parser/assignees{/user}","branches_url":"https://api.github.com/repos/premailer/css_parser/branches{/branch}","tags_url":"https://api.github.com/repos/premailer/css_parser/tags","blobs_url":"https://api.github.com/repos/premailer/css_parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/premailer/css_parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/premailer/css_parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/premailer/css_parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/premailer/css_parser/statuses/{sha}","languages_url":"https://api.github.com/repos/premailer/css_parser/languages","stargazers_url":"https://api.github.com/repos/premailer/css_parser/stargazers","contributors_url":"https://api.github.com/repos/premailer/css_parser/contributors","subscribers_url":"https://api.github.com/repos/premailer/css_parser/subscribers","subscription_url":"https://api.github.com/repos/premailer/css_parser/subscription","commits_url":"https://api.github.com/repos/premailer/css_parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/premailer/css_parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/premailer/css_parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/premailer/css_parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/premailer/css_parser/contents/{+path}","compare_url":"https://api.github.com/repos/premailer/css_parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/premailer/css_parser/merges","archive_url":"https://api.github.com/repos/premailer/css_parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/premailer/css_parser/downloads","issues_url":"https://api.github.com/repos/premailer/css_parser/issues{/number}","pulls_url":"https://api.github.com/repos/premailer/css_parser/pulls{/number}","milestones_url":"https://api.github.com/repos/premailer/css_parser/milestones{/number}","notifications_url":"https://api.github.com/repos/premailer/css_parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/premailer/css_parser/labels{/name}","releases_url":"https://api.github.com/repos/premailer/css_parser/releases{/id}","deployments_url":"https://api.github.com/repos/premailer/css_parser/deployments","created_at":"2009-12-08T17:22:24Z","updated_at":"2016-11-28T09:24:20Z","pushed_at":"2016-11-29T16:15:24Z","git_url":"git://github.com/premailer/css_parser.git","ssh_url":"git@github.com:premailer/css_parser.git","clone_url":"https://github.com/premailer/css_parser.git","svn_url":"https://github.com/premailer/css_parser","homepage":"","size":343,"stargazers_count":170,"watchers_count":170,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":17,"forks":80,"open_issues":17,"watchers":170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/premailer/css_parser/pulls/78"},"html":{"href":"https://github.com/premailer/css_parser/pull/78"},"issue":{"href":"https://api.github.com/repos/premailer/css_parser/issues/78"},"comments":{"href":"https://api.github.com/repos/premailer/css_parser/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/premailer/css_parser/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/premailer/css_parser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/premailer/css_parser/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/premailer/css_parser/statuses/a074aaa8941a1adb775808d8e8a51960c0597312"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"grosser","id":11367,"avatar_url":"https://avatars.githubusercontent.com/u/11367?v=3","gravatar_id":"","url":"https://api.github.com/users/grosser","html_url":"https://github.com/grosser","followers_url":"https://api.github.com/users/grosser/followers","following_url":"https://api.github.com/users/grosser/following{/other_user}","gists_url":"https://api.github.com/users/grosser/gists{/gist_id}","starred_url":"https://api.github.com/users/grosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosser/subscriptions","organizations_url":"https://api.github.com/users/grosser/orgs","repos_url":"https://api.github.com/users/grosser/repos","events_url":"https://api.github.com/users/grosser/events{/privacy}","received_events_url":"https://api.github.com/users/grosser/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"grosser"}}