{"action":"created","comment":{"url":"https://api.github.com/repos/cmderdev/cmder/pulls/comments/65056686","id":65056686,"diff_hunk":"@@ -8,7 +8,7 @@\n \n :: Find root dir\n if not defined CMDER_ROOT (\n-    for /f \"delims=\" %%i in (\"%ConEmuDir%\\..\\..\") do set CMDER_ROOT=%%~fi\n+    for /f \"delims=\" %%i in (\"%ConEmuDir%\\..\\..\") do set \"CMDER_ROOT=%%~fi\"","path":"vendor/init.bat","position":5,"original_position":5,"commit_id":"055a974257efe088e8e899ef8463f88c01e15299","original_commit_id":"055a974257efe088e8e899ef8463f88c01e15299","user":{"login":"BrainCrumbz","id":3185573,"avatar_url":"https://avatars.githubusercontent.com/u/3185573?v=3","gravatar_id":"","url":"https://api.github.com/users/BrainCrumbz","html_url":"https://github.com/BrainCrumbz","followers_url":"https://api.github.com/users/BrainCrumbz/followers","following_url":"https://api.github.com/users/BrainCrumbz/following{/other_user}","gists_url":"https://api.github.com/users/BrainCrumbz/gists{/gist_id}","starred_url":"https://api.github.com/users/BrainCrumbz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrainCrumbz/subscriptions","organizations_url":"https://api.github.com/users/BrainCrumbz/orgs","repos_url":"https://api.github.com/users/BrainCrumbz/repos","events_url":"https://api.github.com/users/BrainCrumbz/events{/privacy}","received_events_url":"https://api.github.com/users/BrainCrumbz/received_events","type":"User","site_admin":false},"body":"Are you sure you want to wrap the whole assignment within double quotes? The left side of assignment is basically declaring the variable/identifier, and should not need quotes. The right side instead is what might be affected by double quotes. Just to be sure, have you checked if it works jut with `..... do set CMDER_ROOT=\"%%~fi\"`","created_at":"2016-05-30T11:03:24Z","updated_at":"2016-05-30T11:03:24Z","html_url":"https://github.com/cmderdev/cmder/pull/941#discussion_r65056686","pull_request_url":"https://api.github.com/repos/cmderdev/cmder/pulls/941","_links":{"self":{"href":"https://api.github.com/repos/cmderdev/cmder/pulls/comments/65056686"},"html":{"href":"https://github.com/cmderdev/cmder/pull/941#discussion_r65056686"},"pull_request":{"href":"https://api.github.com/repos/cmderdev/cmder/pulls/941"}}},"pull_request":{"url":"https://api.github.com/repos/cmderdev/cmder/pulls/941","id":69148281,"html_url":"https://github.com/cmderdev/cmder/pull/941","diff_url":"https://github.com/cmderdev/cmder/pull/941.diff","patch_url":"https://github.com/cmderdev/cmder/pull/941.patch","issue_url":"https://api.github.com/repos/cmderdev/cmder/issues/941","number":941,"state":"closed","locked":false,"title":"More variable quoting in init.bat","user":{"login":"janschulz","id":890156,"avatar_url":"https://avatars.githubusercontent.com/u/890156?v=3","gravatar_id":"","url":"https://api.github.com/users/janschulz","html_url":"https://github.com/janschulz","followers_url":"https://api.github.com/users/janschulz/followers","following_url":"https://api.github.com/users/janschulz/following{/other_user}","gists_url":"https://api.github.com/users/janschulz/gists{/gist_id}","starred_url":"https://api.github.com/users/janschulz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janschulz/subscriptions","organizations_url":"https://api.github.com/users/janschulz/orgs","repos_url":"https://api.github.com/users/janschulz/repos","events_url":"https://api.github.com/users/janschulz/events{/privacy}","received_events_url":"https://api.github.com/users/janschulz/received_events","type":"User","site_admin":false},"body":"There were problems when a path contained a parenthesis like `C:\\temp\\test (test)\\`\r\n\r\nAs a precaution, quote all variables when they are used in echo or set.","created_at":"2016-05-06T13:08:54Z","updated_at":"2016-05-30T11:03:24Z","closed_at":"2016-05-06T13:25:10Z","merged_at":"2016-05-06T13:25:10Z","merge_commit_sha":"d4339ae5262194d7970617bf270f54627b6c3242","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cmderdev/cmder/pulls/941/commits","review_comments_url":"https://api.github.com/repos/cmderdev/cmder/pulls/941/comments","review_comment_url":"https://api.github.com/repos/cmderdev/cmder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cmderdev/cmder/issues/941/comments","statuses_url":"https://api.github.com/repos/cmderdev/cmder/statuses/055a974257efe088e8e899ef8463f88c01e15299","head":{"label":"janschulz:init.bat","ref":"init.bat","sha":"055a974257efe088e8e899ef8463f88c01e15299","user":{"login":"janschulz","id":890156,"avatar_url":"https://avatars.githubusercontent.com/u/890156?v=3","gravatar_id":"","url":"https://api.github.com/users/janschulz","html_url":"https://github.com/janschulz","followers_url":"https://api.github.com/users/janschulz/followers","following_url":"https://api.github.com/users/janschulz/following{/other_user}","gists_url":"https://api.github.com/users/janschulz/gists{/gist_id}","starred_url":"https://api.github.com/users/janschulz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janschulz/subscriptions","organizations_url":"https://api.github.com/users/janschulz/orgs","repos_url":"https://api.github.com/users/janschulz/repos","events_url":"https://api.github.com/users/janschulz/events{/privacy}","received_events_url":"https://api.github.com/users/janschulz/received_events","type":"User","site_admin":false},"repo":{"id":41376797,"name":"cmder","full_name":"janschulz/cmder","owner":{"login":"janschulz","id":890156,"avatar_url":"https://avatars.githubusercontent.com/u/890156?v=3","gravatar_id":"","url":"https://api.github.com/users/janschulz","html_url":"https://github.com/janschulz","followers_url":"https://api.github.com/users/janschulz/followers","following_url":"https://api.github.com/users/janschulz/following{/other_user}","gists_url":"https://api.github.com/users/janschulz/gists{/gist_id}","starred_url":"https://api.github.com/users/janschulz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janschulz/subscriptions","organizations_url":"https://api.github.com/users/janschulz/orgs","repos_url":"https://api.github.com/users/janschulz/repos","events_url":"https://api.github.com/users/janschulz/events{/privacy}","received_events_url":"https://api.github.com/users/janschulz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janschulz/cmder","description":"Lovely console emulator package for Windows","fork":true,"url":"https://api.github.com/repos/janschulz/cmder","forks_url":"https://api.github.com/repos/janschulz/cmder/forks","keys_url":"https://api.github.com/repos/janschulz/cmder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janschulz/cmder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janschulz/cmder/teams","hooks_url":"https://api.github.com/repos/janschulz/cmder/hooks","issue_events_url":"https://api.github.com/repos/janschulz/cmder/issues/events{/number}","events_url":"https://api.github.com/repos/janschulz/cmder/events","assignees_url":"https://api.github.com/repos/janschulz/cmder/assignees{/user}","branches_url":"https://api.github.com/repos/janschulz/cmder/branches{/branch}","tags_url":"https://api.github.com/repos/janschulz/cmder/tags","blobs_url":"https://api.github.com/repos/janschulz/cmder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janschulz/cmder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janschulz/cmder/git/refs{/sha}","trees_url":"https://api.github.com/repos/janschulz/cmder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janschulz/cmder/statuses/{sha}","languages_url":"https://api.github.com/repos/janschulz/cmder/languages","stargazers_url":"https://api.github.com/repos/janschulz/cmder/stargazers","contributors_url":"https://api.github.com/repos/janschulz/cmder/contributors","subscribers_url":"https://api.github.com/repos/janschulz/cmder/subscribers","subscription_url":"https://api.github.com/repos/janschulz/cmder/subscription","commits_url":"https://api.github.com/repos/janschulz/cmder/commits{/sha}","git_commits_url":"https://api.github.com/repos/janschulz/cmder/git/commits{/sha}","comments_url":"https://api.github.com/repos/janschulz/cmder/comments{/number}","issue_comment_url":"https://api.github.com/repos/janschulz/cmder/issues/comments{/number}","contents_url":"https://api.github.com/repos/janschulz/cmder/contents/{+path}","compare_url":"https://api.github.com/repos/janschulz/cmder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janschulz/cmder/merges","archive_url":"https://api.github.com/repos/janschulz/cmder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janschulz/cmder/downloads","issues_url":"https://api.github.com/repos/janschulz/cmder/issues{/number}","pulls_url":"https://api.github.com/repos/janschulz/cmder/pulls{/number}","milestones_url":"https://api.github.com/repos/janschulz/cmder/milestones{/number}","notifications_url":"https://api.github.com/repos/janschulz/cmder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janschulz/cmder/labels{/name}","releases_url":"https://api.github.com/repos/janschulz/cmder/releases{/id}","deployments_url":"https://api.github.com/repos/janschulz/cmder/deployments","created_at":"2015-08-25T17:07:20Z","updated_at":"2015-08-25T17:07:21Z","pushed_at":"2016-05-24T12:32:36Z","git_url":"git://github.com/janschulz/cmder.git","ssh_url":"git@github.com:janschulz/cmder.git","clone_url":"https://github.com/janschulz/cmder.git","svn_url":"https://github.com/janschulz/cmder","homepage":"http://bliker.github.io/cmder/","size":2774,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cmderdev:development","ref":"development","sha":"05fb4368cc4473866e8d68948674bb42c870f477","user":{"login":"cmderdev","id":11646750,"avatar_url":"https://avatars.githubusercontent.com/u/11646750?v=3","gravatar_id":"","url":"https://api.github.com/users/cmderdev","html_url":"https://github.com/cmderdev","followers_url":"https://api.github.com/users/cmderdev/followers","following_url":"https://api.github.com/users/cmderdev/following{/other_user}","gists_url":"https://api.github.com/users/cmderdev/gists{/gist_id}","starred_url":"https://api.github.com/users/cmderdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmderdev/subscriptions","organizations_url":"https://api.github.com/users/cmderdev/orgs","repos_url":"https://api.github.com/users/cmderdev/repos","events_url":"https://api.github.com/users/cmderdev/events{/privacy}","received_events_url":"https://api.github.com/users/cmderdev/received_events","type":"Organization","site_admin":false},"repo":{"id":11276147,"name":"cmder","full_name":"cmderdev/cmder","owner":{"login":"cmderdev","id":11646750,"avatar_url":"https://avatars.githubusercontent.com/u/11646750?v=3","gravatar_id":"","url":"https://api.github.com/users/cmderdev","html_url":"https://github.com/cmderdev","followers_url":"https://api.github.com/users/cmderdev/followers","following_url":"https://api.github.com/users/cmderdev/following{/other_user}","gists_url":"https://api.github.com/users/cmderdev/gists{/gist_id}","starred_url":"https://api.github.com/users/cmderdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmderdev/subscriptions","organizations_url":"https://api.github.com/users/cmderdev/orgs","repos_url":"https://api.github.com/users/cmderdev/repos","events_url":"https://api.github.com/users/cmderdev/events{/privacy}","received_events_url":"https://api.github.com/users/cmderdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cmderdev/cmder","description":"Lovely console emulator package for Windows","fork":false,"url":"https://api.github.com/repos/cmderdev/cmder","forks_url":"https://api.github.com/repos/cmderdev/cmder/forks","keys_url":"https://api.github.com/repos/cmderdev/cmder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmderdev/cmder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmderdev/cmder/teams","hooks_url":"https://api.github.com/repos/cmderdev/cmder/hooks","issue_events_url":"https://api.github.com/repos/cmderdev/cmder/issues/events{/number}","events_url":"https://api.github.com/repos/cmderdev/cmder/events","assignees_url":"https://api.github.com/repos/cmderdev/cmder/assignees{/user}","branches_url":"https://api.github.com/repos/cmderdev/cmder/branches{/branch}","tags_url":"https://api.github.com/repos/cmderdev/cmder/tags","blobs_url":"https://api.github.com/repos/cmderdev/cmder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmderdev/cmder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmderdev/cmder/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmderdev/cmder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmderdev/cmder/statuses/{sha}","languages_url":"https://api.github.com/repos/cmderdev/cmder/languages","stargazers_url":"https://api.github.com/repos/cmderdev/cmder/stargazers","contributors_url":"https://api.github.com/repos/cmderdev/cmder/contributors","subscribers_url":"https://api.github.com/repos/cmderdev/cmder/subscribers","subscription_url":"https://api.github.com/repos/cmderdev/cmder/subscription","commits_url":"https://api.github.com/repos/cmderdev/cmder/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmderdev/cmder/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmderdev/cmder/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmderdev/cmder/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmderdev/cmder/contents/{+path}","compare_url":"https://api.github.com/repos/cmderdev/cmder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmderdev/cmder/merges","archive_url":"https://api.github.com/repos/cmderdev/cmder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmderdev/cmder/downloads","issues_url":"https://api.github.com/repos/cmderdev/cmder/issues{/number}","pulls_url":"https://api.github.com/repos/cmderdev/cmder/pulls{/number}","milestones_url":"https://api.github.com/repos/cmderdev/cmder/milestones{/number}","notifications_url":"https://api.github.com/repos/cmderdev/cmder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmderdev/cmder/labels{/name}","releases_url":"https://api.github.com/repos/cmderdev/cmder/releases{/id}","deployments_url":"https://api.github.com/repos/cmderdev/cmder/deployments","created_at":"2013-07-09T07:44:22Z","updated_at":"2016-05-30T08:01:37Z","pushed_at":"2016-05-27T08:50:26Z","git_url":"git://github.com/cmderdev/cmder.git","ssh_url":"git@github.com:cmderdev/cmder.git","clone_url":"https://github.com/cmderdev/cmder.git","svn_url":"https://github.com/cmderdev/cmder","homepage":"cmder.net","size":3678,"stargazers_count":7289,"watchers_count":7289,"language":"PowerShell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":516,"mirror_url":null,"open_issues_count":214,"forks":516,"open_issues":214,"watchers":7289,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cmderdev/cmder/pulls/941"},"html":{"href":"https://github.com/cmderdev/cmder/pull/941"},"issue":{"href":"https://api.github.com/repos/cmderdev/cmder/issues/941"},"comments":{"href":"https://api.github.com/repos/cmderdev/cmder/issues/941/comments"},"review_comments":{"href":"https://api.github.com/repos/cmderdev/cmder/pulls/941/comments"},"review_comment":{"href":"https://api.github.com/repos/cmderdev/cmder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cmderdev/cmder/pulls/941/commits"},"statuses":{"href":"https://api.github.com/repos/cmderdev/cmder/statuses/055a974257efe088e8e899ef8463f88c01e15299"}}}}
{"actor":{"display_login":"BrainCrumbz"}}