{"action":"created","comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/78036771","id":78036771,"diff_hunk":"@@ -66,37 +65,40 @@ IEnumerable<IRenderable> IRenderAboveShroudWhenSelected.RenderAboveShroud(Actor\n \t\t{\n \t\t\tvar force = Game.GetModifierKeys().HasModifier(Modifiers.Alt);\n \t\t\tif ((lifetime <= 0 || --lifetime <= 0) && !force)\n-\t\t\t\tyield break;\n+\t\t\t\treturn new IRenderable[0];\n \n \t\t\tif (!(force || Game.Settings.Game.DrawTargetLine))\n-\t\t\t\tyield break;\n+\t\t\t\treturn new IRenderable[0];\n \n-\t\t\tif (targets == null || targets.Count == 0)\n-\t\t\t\tyield break;\n+\t\t\tif (self.GetCurrentActivity() == null)\n+\t\t\t\treturn new IRenderable[0];\n \n-\t\t\tforeach (var target in targets)\n-\t\t\t{\n-\t\t\t\tif (target.Type == TargetType.Invalid)\n-\t\t\t\t\tcontinue;\n+\t\t\tif (self.GetCurrentActivity().GetTargets(self).Count() <= 0)","path":"OpenRA.Mods.Common/Traits/Render/DrawLineToTarget.cs","position":56,"original_position":56,"commit_id":"eb4b4ff140bb2d038466e992c73793f64526cdc8","original_commit_id":"eb4b4ff140bb2d038466e992c73793f64526cdc8","user":{"login":"WolfGaming","id":3696546,"avatar_url":"https://avatars.githubusercontent.com/u/3696546?v=3","gravatar_id":"","url":"https://api.github.com/users/WolfGaming","html_url":"https://github.com/WolfGaming","followers_url":"https://api.github.com/users/WolfGaming/followers","following_url":"https://api.github.com/users/WolfGaming/following{/other_user}","gists_url":"https://api.github.com/users/WolfGaming/gists{/gist_id}","starred_url":"https://api.github.com/users/WolfGaming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WolfGaming/subscriptions","organizations_url":"https://api.github.com/users/WolfGaming/orgs","repos_url":"https://api.github.com/users/WolfGaming/repos","events_url":"https://api.github.com/users/WolfGaming/events{/privacy}","received_events_url":"https://api.github.com/users/WolfGaming/received_events","type":"User","site_admin":false},"body":"You also do GetTargets(self) 2 times,put that into a variable too as it can become expensive depending on the implementation of the activity.","created_at":"2016-09-08T16:05:24Z","updated_at":"2016-09-08T16:05:24Z","html_url":"https://github.com/OpenRA/OpenRA/pull/11998#discussion_r78036771","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/11998","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/78036771"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/11998#discussion_r78036771"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/11998"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/11998","id":84340279,"html_url":"https://github.com/OpenRA/OpenRA/pull/11998","diff_url":"https://github.com/OpenRA/OpenRA/pull/11998.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/11998.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/11998","number":11998,"state":"open","locked":false,"title":"Visualising waypoints2","user":{"login":"Turupawn","id":707484,"avatar_url":"https://avatars.githubusercontent.com/u/707484?v=3","gravatar_id":"","url":"https://api.github.com/users/Turupawn","html_url":"https://github.com/Turupawn","followers_url":"https://api.github.com/users/Turupawn/followers","following_url":"https://api.github.com/users/Turupawn/following{/other_user}","gists_url":"https://api.github.com/users/Turupawn/gists{/gist_id}","starred_url":"https://api.github.com/users/Turupawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Turupawn/subscriptions","organizations_url":"https://api.github.com/users/Turupawn/orgs","repos_url":"https://api.github.com/users/Turupawn/repos","events_url":"https://api.github.com/users/Turupawn/events{/privacy}","received_events_url":"https://api.github.com/users/Turupawn/received_events","type":"User","site_admin":false},"body":"This solves #2598. It's a #11794 follow up which I had to do another branch because I wasn't able to merge the lastest changes (sorry about that). You guys work fast!\r\n\r\nI'm just concerned about `LineTargetExts::SetTargetLine()` because it looks like `LineTargetExts::SetTargetLines()` can do all the trick. Should we remove all SetTargetLine and use SetTargetLines only?\r\nsee:\r\nhttps://github.com/OpenRA/OpenRA/pull/11998/files#diff-d7a57eebc0a2b3d470e099590d38922eR95","created_at":"2016-09-07T17:19:00Z","updated_at":"2016-09-08T16:05:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f3c859bb4ae146f4ed4a842f0268042d47a2bfc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/11998/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/11998/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/11998/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/eb4b4ff140bb2d038466e992c73793f64526cdc8","head":{"label":"Turupawn:visualising_waypoints2","ref":"visualising_waypoints2","sha":"eb4b4ff140bb2d038466e992c73793f64526cdc8","user":{"login":"Turupawn","id":707484,"avatar_url":"https://avatars.githubusercontent.com/u/707484?v=3","gravatar_id":"","url":"https://api.github.com/users/Turupawn","html_url":"https://github.com/Turupawn","followers_url":"https://api.github.com/users/Turupawn/followers","following_url":"https://api.github.com/users/Turupawn/following{/other_user}","gists_url":"https://api.github.com/users/Turupawn/gists{/gist_id}","starred_url":"https://api.github.com/users/Turupawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Turupawn/subscriptions","organizations_url":"https://api.github.com/users/Turupawn/orgs","repos_url":"https://api.github.com/users/Turupawn/repos","events_url":"https://api.github.com/users/Turupawn/events{/privacy}","received_events_url":"https://api.github.com/users/Turupawn/received_events","type":"User","site_admin":false},"repo":{"id":65106534,"name":"OpenRA","full_name":"Turupawn/OpenRA","owner":{"login":"Turupawn","id":707484,"avatar_url":"https://avatars.githubusercontent.com/u/707484?v=3","gravatar_id":"","url":"https://api.github.com/users/Turupawn","html_url":"https://github.com/Turupawn","followers_url":"https://api.github.com/users/Turupawn/followers","following_url":"https://api.github.com/users/Turupawn/following{/other_user}","gists_url":"https://api.github.com/users/Turupawn/gists{/gist_id}","starred_url":"https://api.github.com/users/Turupawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Turupawn/subscriptions","organizations_url":"https://api.github.com/users/Turupawn/orgs","repos_url":"https://api.github.com/users/Turupawn/repos","events_url":"https://api.github.com/users/Turupawn/events{/privacy}","received_events_url":"https://api.github.com/users/Turupawn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Turupawn/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":true,"url":"https://api.github.com/repos/Turupawn/OpenRA","forks_url":"https://api.github.com/repos/Turupawn/OpenRA/forks","keys_url":"https://api.github.com/repos/Turupawn/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Turupawn/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Turupawn/OpenRA/teams","hooks_url":"https://api.github.com/repos/Turupawn/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/Turupawn/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/Turupawn/OpenRA/events","assignees_url":"https://api.github.com/repos/Turupawn/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/Turupawn/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/Turupawn/OpenRA/tags","blobs_url":"https://api.github.com/repos/Turupawn/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Turupawn/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Turupawn/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/Turupawn/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Turupawn/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/Turupawn/OpenRA/languages","stargazers_url":"https://api.github.com/repos/Turupawn/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/Turupawn/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/Turupawn/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/Turupawn/OpenRA/subscription","commits_url":"https://api.github.com/repos/Turupawn/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/Turupawn/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/Turupawn/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/Turupawn/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/Turupawn/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/Turupawn/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Turupawn/OpenRA/merges","archive_url":"https://api.github.com/repos/Turupawn/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Turupawn/OpenRA/downloads","issues_url":"https://api.github.com/repos/Turupawn/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/Turupawn/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/Turupawn/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/Turupawn/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Turupawn/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/Turupawn/OpenRA/releases{/id}","deployments_url":"https://api.github.com/repos/Turupawn/OpenRA/deployments","created_at":"2016-08-06T23:35:25Z","updated_at":"2016-08-06T23:35:34Z","pushed_at":"2016-09-07T21:50:47Z","git_url":"git://github.com/Turupawn/OpenRA.git","ssh_url":"git@github.com:Turupawn/OpenRA.git","clone_url":"https://github.com/Turupawn/OpenRA.git","svn_url":"https://github.com/Turupawn/OpenRA","homepage":"http://www.openra.net","size":108267,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"3849b91e8fac4a5037ecce88f4b4b2aaca332916","user":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"name":"OpenRA","full_name":"OpenRA/OpenRA","owner":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRA/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","deployments_url":"https://api.github.com/repos/OpenRA/OpenRA/deployments","created_at":"2010-10-04T07:38:05Z","updated_at":"2016-09-08T07:36:26Z","pushed_at":"2016-09-08T09:39:17Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":174606,"stargazers_count":3354,"watchers_count":3354,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1097,"mirror_url":null,"open_issues_count":1026,"forks":1097,"open_issues":1026,"watchers":3354,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/11998"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/11998"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/11998"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/11998/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/11998/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/11998/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/eb4b4ff140bb2d038466e992c73793f64526cdc8"}}}}
{"actor":{"display_login":"WolfGaming"}}