{"action":"created","comment":{"url":"https://api.github.com/repos/LLNL/spack/pulls/comments/93021928","pull_request_review_id":13541321,"id":93021928,"diff_hunk":"@@ -0,0 +1,43 @@\n+from spack import *\n+\n+class Gbenchmark(Package):\n+    \"\"\"A microbenchmark support library\"\"\"\n+\n+    homepage = \"https://github.com/google/benchmark\"\n+    url      = \"https://github.com/google/benchmark/archive/v1.0.0.tar.gz\"\n+\n+    version('1.1.0', '8c539bbe2a212618fa87b6c38fba087100b6e4ae',\n+            url='https://github.com/google/benchmark/archive/v1.1.0.tar.gz')\n+    version('1.0.0', '4f778985dce02d2e63262e6f388a24b595254a93')\n+    variant(\"debug\", default=False, description=\"Installs with debug options\")\n+\n+    def patch(self):","path":"var/spack/repos/builtin/packages/gbenchmark/package.py","position":14,"original_position":14,"commit_id":"22326e4a0f81138183b45d201c2c4f54d5c152e1","original_commit_id":"22326e4a0f81138183b45d201c2c4f54d5c152e1","user":{"login":"davydden","id":8023934,"avatar_url":"https://avatars.githubusercontent.com/u/8023934?v=3","gravatar_id":"","url":"https://api.github.com/users/davydden","html_url":"https://github.com/davydden","followers_url":"https://api.github.com/users/davydden/followers","following_url":"https://api.github.com/users/davydden/following{/other_user}","gists_url":"https://api.github.com/users/davydden/gists{/gist_id}","starred_url":"https://api.github.com/users/davydden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davydden/subscriptions","organizations_url":"https://api.github.com/users/davydden/orgs","repos_url":"https://api.github.com/users/davydden/repos","events_url":"https://api.github.com/users/davydden/events{/privacy}","received_events_url":"https://api.github.com/users/davydden/received_events","type":"User","site_admin":false},"body":"pre-patching should be possible with `CMakePackage`, right @alalazo ?","created_at":"2016-12-19T12:26:40Z","updated_at":"2016-12-19T12:27:57Z","html_url":"https://github.com/LLNL/spack/pull/2627#discussion_r93021928","pull_request_url":"https://api.github.com/repos/LLNL/spack/pulls/2627","_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments/93021928"},"html":{"href":"https://github.com/LLNL/spack/pull/2627#discussion_r93021928"},"pull_request":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2627"}}},"pull_request":{"url":"https://api.github.com/repos/LLNL/spack/pulls/2627","id":98555772,"html_url":"https://github.com/LLNL/spack/pull/2627","diff_url":"https://github.com/LLNL/spack/pull/2627.diff","patch_url":"https://github.com/LLNL/spack/pull/2627.patch","issue_url":"https://api.github.com/repos/LLNL/spack/issues/2627","number":2627,"state":"open","locked":false,"title":"Adds catch, cppunit, spdlog, tinyxml(1 and 2), google benchmark","user":{"login":"mdavezac","id":2745737,"avatar_url":"https://avatars.githubusercontent.com/u/2745737?v=3","gravatar_id":"","url":"https://api.github.com/users/mdavezac","html_url":"https://github.com/mdavezac","followers_url":"https://api.github.com/users/mdavezac/followers","following_url":"https://api.github.com/users/mdavezac/following{/other_user}","gists_url":"https://api.github.com/users/mdavezac/gists{/gist_id}","starred_url":"https://api.github.com/users/mdavezac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdavezac/subscriptions","organizations_url":"https://api.github.com/users/mdavezac/orgs","repos_url":"https://api.github.com/users/mdavezac/repos","events_url":"https://api.github.com/users/mdavezac/events{/privacy}","received_events_url":"https://api.github.com/users/mdavezac/received_events","type":"User","site_admin":false},"body":"Tinyxml comes in two flavors, 1 and 2. Each comes in several\r\nversions... So they cannot be easily united into a single package.","created_at":"2016-12-19T12:19:59Z","updated_at":"2016-12-19T12:27:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dba47f2f46ccfd7a5241196af6544b3edc4613b8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/spack/pulls/2627/commits","review_comments_url":"https://api.github.com/repos/LLNL/spack/pulls/2627/comments","review_comment_url":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/2627/comments","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/22326e4a0f81138183b45d201c2c4f54d5c152e1","head":{"label":"mdavezac:packages","ref":"packages","sha":"22326e4a0f81138183b45d201c2c4f54d5c152e1","user":{"login":"mdavezac","id":2745737,"avatar_url":"https://avatars.githubusercontent.com/u/2745737?v=3","gravatar_id":"","url":"https://api.github.com/users/mdavezac","html_url":"https://github.com/mdavezac","followers_url":"https://api.github.com/users/mdavezac/followers","following_url":"https://api.github.com/users/mdavezac/following{/other_user}","gists_url":"https://api.github.com/users/mdavezac/gists{/gist_id}","starred_url":"https://api.github.com/users/mdavezac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdavezac/subscriptions","organizations_url":"https://api.github.com/users/mdavezac/orgs","repos_url":"https://api.github.com/users/mdavezac/repos","events_url":"https://api.github.com/users/mdavezac/events{/privacy}","received_events_url":"https://api.github.com/users/mdavezac/received_events","type":"User","site_admin":false},"repo":{"id":47260920,"name":"spack","full_name":"mdavezac/spack","owner":{"login":"mdavezac","id":2745737,"avatar_url":"https://avatars.githubusercontent.com/u/2745737?v=3","gravatar_id":"","url":"https://api.github.com/users/mdavezac","html_url":"https://github.com/mdavezac","followers_url":"https://api.github.com/users/mdavezac/followers","following_url":"https://api.github.com/users/mdavezac/following{/other_user}","gists_url":"https://api.github.com/users/mdavezac/gists{/gist_id}","starred_url":"https://api.github.com/users/mdavezac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdavezac/subscriptions","organizations_url":"https://api.github.com/users/mdavezac/orgs","repos_url":"https://api.github.com/users/mdavezac/repos","events_url":"https://api.github.com/users/mdavezac/events{/privacy}","received_events_url":"https://api.github.com/users/mdavezac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mdavezac/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":true,"url":"https://api.github.com/repos/mdavezac/spack","forks_url":"https://api.github.com/repos/mdavezac/spack/forks","keys_url":"https://api.github.com/repos/mdavezac/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdavezac/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdavezac/spack/teams","hooks_url":"https://api.github.com/repos/mdavezac/spack/hooks","issue_events_url":"https://api.github.com/repos/mdavezac/spack/issues/events{/number}","events_url":"https://api.github.com/repos/mdavezac/spack/events","assignees_url":"https://api.github.com/repos/mdavezac/spack/assignees{/user}","branches_url":"https://api.github.com/repos/mdavezac/spack/branches{/branch}","tags_url":"https://api.github.com/repos/mdavezac/spack/tags","blobs_url":"https://api.github.com/repos/mdavezac/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdavezac/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdavezac/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdavezac/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdavezac/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/mdavezac/spack/languages","stargazers_url":"https://api.github.com/repos/mdavezac/spack/stargazers","contributors_url":"https://api.github.com/repos/mdavezac/spack/contributors","subscribers_url":"https://api.github.com/repos/mdavezac/spack/subscribers","subscription_url":"https://api.github.com/repos/mdavezac/spack/subscription","commits_url":"https://api.github.com/repos/mdavezac/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdavezac/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdavezac/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdavezac/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdavezac/spack/contents/{+path}","compare_url":"https://api.github.com/repos/mdavezac/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdavezac/spack/merges","archive_url":"https://api.github.com/repos/mdavezac/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdavezac/spack/downloads","issues_url":"https://api.github.com/repos/mdavezac/spack/issues{/number}","pulls_url":"https://api.github.com/repos/mdavezac/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/mdavezac/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/mdavezac/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdavezac/spack/labels{/name}","releases_url":"https://api.github.com/repos/mdavezac/spack/releases{/id}","deployments_url":"https://api.github.com/repos/mdavezac/spack/deployments","created_at":"2015-12-02T12:56:47Z","updated_at":"2015-12-02T12:56:49Z","pushed_at":"2016-12-19T12:17:09Z","git_url":"git://github.com/mdavezac/spack.git","ssh_url":"git@github.com:mdavezac/spack.git","clone_url":"https://github.com/mdavezac/spack.git","svn_url":"https://github.com/mdavezac/spack","homepage":"http://scalability-llnl.github.io/spack","size":3672,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"LLNL:develop","ref":"develop","sha":"b18738e03d0792bb6fa909cea8f626a28d99338c","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"LLNL/spack","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/LLNL/spack","forks_url":"https://api.github.com/repos/LLNL/spack/forks","keys_url":"https://api.github.com/repos/LLNL/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/spack/teams","hooks_url":"https://api.github.com/repos/LLNL/spack/hooks","issue_events_url":"https://api.github.com/repos/LLNL/spack/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/spack/events","assignees_url":"https://api.github.com/repos/LLNL/spack/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/spack/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/spack/tags","blobs_url":"https://api.github.com/repos/LLNL/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/spack/languages","stargazers_url":"https://api.github.com/repos/LLNL/spack/stargazers","contributors_url":"https://api.github.com/repos/LLNL/spack/contributors","subscribers_url":"https://api.github.com/repos/LLNL/spack/subscribers","subscription_url":"https://api.github.com/repos/LLNL/spack/subscription","commits_url":"https://api.github.com/repos/LLNL/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/spack/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/spack/merges","archive_url":"https://api.github.com/repos/LLNL/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/spack/downloads","issues_url":"https://api.github.com/repos/LLNL/spack/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/spack/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/spack/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2016-12-14T21:41:59Z","pushed_at":"2016-12-19T12:20:00Z","git_url":"git://github.com/LLNL/spack.git","ssh_url":"git@github.com:LLNL/spack.git","clone_url":"https://github.com/LLNL/spack.git","svn_url":"https://github.com/LLNL/spack","homepage":"http://llnl.github.io/spack","size":18750,"stargazers_count":194,"watchers_count":194,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":168,"mirror_url":null,"open_issues_count":457,"forks":168,"open_issues":457,"watchers":194,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2627"},"html":{"href":"https://github.com/LLNL/spack/pull/2627"},"issue":{"href":"https://api.github.com/repos/LLNL/spack/issues/2627"},"comments":{"href":"https://api.github.com/repos/LLNL/spack/issues/2627/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2627/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/spack/pulls/2627/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/spack/statuses/22326e4a0f81138183b45d201c2c4f54d5c152e1"}}}}
{"actor":{"display_login":"davydden"}}