{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/50119170","id":50119170,"diff_hunk":"@@ -0,0 +1,143 @@\n+<!-- BEGIN MUNGE: UNVERSIONED_WARNING -->\n+\n+<!-- BEGIN STRIP_FOR_RELEASE -->\n+\n+<img src=\"http://kubernetes.io/img/warning.png\" alt=\"WARNING\"\n+     width=\"25\" height=\"25\">\n+<img src=\"http://kubernetes.io/img/warning.png\" alt=\"WARNING\"\n+     width=\"25\" height=\"25\">\n+<img src=\"http://kubernetes.io/img/warning.png\" alt=\"WARNING\"\n+     width=\"25\" height=\"25\">\n+<img src=\"http://kubernetes.io/img/warning.png\" alt=\"WARNING\"\n+     width=\"25\" height=\"25\">\n+<img src=\"http://kubernetes.io/img/warning.png\" alt=\"WARNING\"\n+     width=\"25\" height=\"25\">\n+\n+<h2>PLEASE NOTE: This document applies to the HEAD of the source tree</h2>\n+\n+If you are using a released version of Kubernetes, you should\n+refer to the docs that go with that version.\n+\n+Documentation for other releases can be found at\n+[releases.k8s.io](http://releases.k8s.io).\n+</strong>\n+--\n+\n+<!-- END STRIP_FOR_RELEASE -->\n+\n+<!-- END MUNGE: UNVERSIONED_WARNING -->\n+\n+# Abstract\n+\n+This document proposes a model for the configuration and management of dynamically provisioned persistent volumes in Kubernetes.  Familiarity [Persistent Volumes](../user-guide/persistent-volumes/) is assumed.\n+\n+Administrators use ConfigMap in a namespace they control to configure many provisioners.  Users request volumes via a selector and/or storage class.\n+\n+## ConfigMap\n+\n+Provisioners will be configured using `ConfigMap`.  Configs will be held in a namespace controlled by the administrator.\n+\n+The admin configures kube-controller-manager with a CLI flag specifying the namespace containing the configs.\n+\n+`--pv-provisioner-namespace=foobar`\n+\n+\n+### Example Configuration\n+\n+\n+```\n+\tconfig := &api.ConfigMap {\n+\t\tObjectMeta: api.ObjectMeta{\n+\t\t\tName: \"gold\",\n+\t\t\tNamespace: \"foobar\",\n+\t\t\tLabels: {\n+\t\t\t\t\"storage-class\": \"gold\",\r\t\t\t}\n+\t\t},\n+\t\tData: map[string]string {\n+\t\t\t\"plugin-name\": \"kubernetes.io/gce-pd\",\n+\t\t\t\"service-account-name\": \"foo\",\n+\t\t\t\"params\": \"${OPAQUE-JSON-MAP}\",\r\t\t}\n+\t}\n+\t\t\n+\n+\tclaim := &api.PersistentVolumeClaim{\n+\t\tSpec: api.PersistentVolumeClaimSpec{\n+\t\t\t\tPersistentVolumeSelector:map[string]string{\n+\t\t\t\t\t\"storage-class\":\"gold\",\n+\t\t\t\t},\n+\t\t\t},\n+\t\t},\n+\t}\n+\t\n+```\n+\n+#### Design Consideration\n+\n+`StorageClass` has been proposed as a field on PersistentVolumeClaim.  An equivalent of that field is currently stewing as an annotation in the current version of dynamic provisioning.\n+\n+`PersistentVolumeSelector` on PersistentVolumeClaim has been proposed as a means to select specific volumes, akin to a pod's NodeSelector.\n+\n+Having both fields is confusing.  Consider this on-premise installation of Kube:\n+\n+> Admin Joe configures \"Gold\" to dynamically provision Ceph volumes.  Joe also creates \"Silver\" volumes by manually provisioning a large number of NFS exports on expensive hardware (SSDs, highly available, stringent backup policy).  Lastly, Joe creates \"Bronze\" NFS exports on older hardware with slower discs.\n+","path":"docs/design/provisioning.md","position":83,"original_position":83,"commit_id":"93a9643bed51219a53af36c6da31a0a58d227ee3","original_commit_id":"93a9643bed51219a53af36c6da31a0a58d227ee3","user":{"login":"wattsteve","id":3201484,"avatar_url":"https://avatars.githubusercontent.com/u/3201484?v=3","gravatar_id":"","url":"https://api.github.com/users/wattsteve","html_url":"https://github.com/wattsteve","followers_url":"https://api.github.com/users/wattsteve/followers","following_url":"https://api.github.com/users/wattsteve/following{/other_user}","gists_url":"https://api.github.com/users/wattsteve/gists{/gist_id}","starred_url":"https://api.github.com/users/wattsteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wattsteve/subscriptions","organizations_url":"https://api.github.com/users/wattsteve/orgs","repos_url":"https://api.github.com/users/wattsteve/repos","events_url":"https://api.github.com/users/wattsteve/events{/privacy}","received_events_url":"https://api.github.com/users/wattsteve/received_events","type":"User","site_admin":false},"body":"+1. We shouldn't force users to have to understand the difference. All they should care about is what VolumeSelector names (Gold, Silver, Bronze, etc.) they have access to.","created_at":"2016-01-19T14:42:14Z","updated_at":"2016-01-19T14:42:14Z","html_url":"https://github.com/kubernetes/kubernetes/pull/17056#discussion_r50119170","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17056","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/50119170"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/17056#discussion_r50119170"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17056"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17056","id":50257738,"html_url":"https://github.com/kubernetes/kubernetes/pull/17056","diff_url":"https://github.com/kubernetes/kubernetes/pull/17056.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/17056.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17056","number":17056,"state":"open","locked":false,"title":"PersistentVolume Config & Provisioning proposal","user":{"login":"markturansky","id":8001968,"avatar_url":"https://avatars.githubusercontent.com/u/8001968?v=3","gravatar_id":"","url":"https://api.github.com/users/markturansky","html_url":"https://github.com/markturansky","followers_url":"https://api.github.com/users/markturansky/followers","following_url":"https://api.github.com/users/markturansky/following{/other_user}","gists_url":"https://api.github.com/users/markturansky/gists{/gist_id}","starred_url":"https://api.github.com/users/markturansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markturansky/subscriptions","organizations_url":"https://api.github.com/users/markturansky/orgs","repos_url":"https://api.github.com/users/markturansky/repos","events_url":"https://api.github.com/users/markturansky/events{/privacy}","received_events_url":"https://api.github.com/users/markturansky/received_events","type":"User","site_admin":false},"body":"This proposal ties together several pieces of PersistentVolumes that are currently missing or sub-optimal.\r\n\r\nSee provisioning.md for details.\r\n\r\nSummary of proposed changes:\r\n\r\n1. Structured config data --  file config? extended API?\r\n2. Allow many recyclers and provisioners (we have 1 today) -- #13338\r\n3. Use selectors for everything (#14908)\r\n4. Refactor provisioning code from volumes plugin code (#14217)\r\n5. executable driver model for recyclers and provisioners\r\n\r\nTasks:\r\n\r\n1.  Add pvc.Spec.PersistentVolumeSelector\r\n2.  ~~Expose more volume attributes (e.g, EBS volumeType)~~ A map of arguments was added to config and plugins. Varying attribute types to be set there and to be used by the plugin.\r\n3.  Add config data and initialize controller w/ config\r\n4.  Controller consolidation: PRs #14537 and #16432 (issue #15632)\r\n5.  Make controllers work with selectors per the proposal.\r\n6. Refactor current binding/recycling behavior into plugins and use in default config \r\n7.  Bonus: executable drivers -- not required immediately\r\n\r\n@thockin @saad-ali @kubernetes/rh-storage\r\n\r\nA tech design session to discuss this would be helpful.  Many of the tasks will be parallelizable given enough review bandwidth.","created_at":"2015-11-10T14:11:10Z","updated_at":"2016-01-19T14:42:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ee4a56c6d6144786f915e9be2c7d0affde3ec8b","assignee":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17056/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17056/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17056/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/93a9643bed51219a53af36c6da31a0a58d227ee3","head":{"label":"markturansky:pv_config","ref":"pv_config","sha":"93a9643bed51219a53af36c6da31a0a58d227ee3","user":{"login":"markturansky","id":8001968,"avatar_url":"https://avatars.githubusercontent.com/u/8001968?v=3","gravatar_id":"","url":"https://api.github.com/users/markturansky","html_url":"https://github.com/markturansky","followers_url":"https://api.github.com/users/markturansky/followers","following_url":"https://api.github.com/users/markturansky/following{/other_user}","gists_url":"https://api.github.com/users/markturansky/gists{/gist_id}","starred_url":"https://api.github.com/users/markturansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markturansky/subscriptions","organizations_url":"https://api.github.com/users/markturansky/orgs","repos_url":"https://api.github.com/users/markturansky/repos","events_url":"https://api.github.com/users/markturansky/events{/privacy}","received_events_url":"https://api.github.com/users/markturansky/received_events","type":"User","site_admin":false},"repo":{"id":24423869,"name":"kubernetes","full_name":"markturansky/kubernetes","owner":{"login":"markturansky","id":8001968,"avatar_url":"https://avatars.githubusercontent.com/u/8001968?v=3","gravatar_id":"","url":"https://api.github.com/users/markturansky","html_url":"https://github.com/markturansky","followers_url":"https://api.github.com/users/markturansky/followers","following_url":"https://api.github.com/users/markturansky/following{/other_user}","gists_url":"https://api.github.com/users/markturansky/gists{/gist_id}","starred_url":"https://api.github.com/users/markturansky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markturansky/subscriptions","organizations_url":"https://api.github.com/users/markturansky/orgs","repos_url":"https://api.github.com/users/markturansky/repos","events_url":"https://api.github.com/users/markturansky/events{/privacy}","received_events_url":"https://api.github.com/users/markturansky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markturansky/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/markturansky/kubernetes","forks_url":"https://api.github.com/repos/markturansky/kubernetes/forks","keys_url":"https://api.github.com/repos/markturansky/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markturansky/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markturansky/kubernetes/teams","hooks_url":"https://api.github.com/repos/markturansky/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/markturansky/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/markturansky/kubernetes/events","assignees_url":"https://api.github.com/repos/markturansky/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/markturansky/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/markturansky/kubernetes/tags","blobs_url":"https://api.github.com/repos/markturansky/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markturansky/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markturansky/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/markturansky/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markturansky/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/markturansky/kubernetes/languages","stargazers_url":"https://api.github.com/repos/markturansky/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/markturansky/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/markturansky/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/markturansky/kubernetes/subscription","commits_url":"https://api.github.com/repos/markturansky/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/markturansky/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/markturansky/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/markturansky/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/markturansky/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/markturansky/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markturansky/kubernetes/merges","archive_url":"https://api.github.com/repos/markturansky/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markturansky/kubernetes/downloads","issues_url":"https://api.github.com/repos/markturansky/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/markturansky/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/markturansky/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/markturansky/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markturansky/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/markturansky/kubernetes/releases{/id}","created_at":"2014-09-24T16:55:04Z","updated_at":"2016-01-11T17:02:35Z","pushed_at":"2016-01-18T19:49:41Z","git_url":"git://github.com/markturansky/kubernetes.git","ssh_url":"git@github.com:markturansky/kubernetes.git","clone_url":"https://github.com/markturansky/kubernetes.git","svn_url":"https://github.com/markturansky/kubernetes","homepage":null,"size":147662,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"810544633e3c12f6105e89705e58530eec1bfbd4","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-01-19T14:23:21Z","pushed_at":"2016-01-19T14:36:52Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":305478,"stargazers_count":12218,"watchers_count":12218,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3440,"mirror_url":null,"open_issues_count":2825,"forks":3440,"open_issues":2825,"watchers":12218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17056"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/17056"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/17056"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/17056/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17056/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17056/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/93a9643bed51219a53af36c6da31a0a58d227ee3"}}}}