{"action":"opened","number":12,"pull_request":{"url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/pulls/12","id":67306207,"html_url":"https://github.com/yams-mqtt/yams_mqtt_lib/pull/12","diff_url":"https://github.com/yams-mqtt/yams_mqtt_lib/pull/12.diff","patch_url":"https://github.com/yams-mqtt/yams_mqtt_lib/pull/12.patch","issue_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/issues/12","number":12,"state":"open","locked":false,"title":"Bit flag QoS validation as described in Normative Statement Number # MQTT-3.3.1-4","user":{"login":"KuldeepSinh","id":1673637,"avatar_url":"https://avatars.githubusercontent.com/u/1673637?v=3","gravatar_id":"","url":"https://api.github.com/users/KuldeepSinh","html_url":"https://github.com/KuldeepSinh","followers_url":"https://api.github.com/users/KuldeepSinh/followers","following_url":"https://api.github.com/users/KuldeepSinh/following{/other_user}","gists_url":"https://api.github.com/users/KuldeepSinh/gists{/gist_id}","starred_url":"https://api.github.com/users/KuldeepSinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KuldeepSinh/subscriptions","organizations_url":"https://api.github.com/users/KuldeepSinh/orgs","repos_url":"https://api.github.com/users/KuldeepSinh/repos","events_url":"https://api.github.com/users/KuldeepSinh/events{/privacy}","received_events_url":"https://api.github.com/users/KuldeepSinh/received_events","type":"User","site_admin":false},"body":"To comply with the Normative Statement Number # MQTT-3.3.1-4, described in the Appendix B,page number 73 of the specification, I have added code to validate value of QoS bits for a message of type PUBLISH. Also updated tests, related to the same implementation. Note that its a partial implementation for the requirement. I am just validating the value of the QoS bits of PUBLISH message. If found invalid, the \"get_msg_type\" function will return error. The intended normative statement requires to close the Network Connection, which I have not addressed in this function.","created_at":"2016-04-21T07:05:15Z","updated_at":"2016-04-21T07:05:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/pulls/12/commits","review_comments_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/pulls/12/comments","review_comment_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/issues/12/comments","statuses_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/statuses/74fb47a706c186ea784ec0ff28ed55b4ba0a0de1","head":{"label":"KuldeepSinh:develop","ref":"develop","sha":"74fb47a706c186ea784ec0ff28ed55b4ba0a0de1","user":{"login":"KuldeepSinh","id":1673637,"avatar_url":"https://avatars.githubusercontent.com/u/1673637?v=3","gravatar_id":"","url":"https://api.github.com/users/KuldeepSinh","html_url":"https://github.com/KuldeepSinh","followers_url":"https://api.github.com/users/KuldeepSinh/followers","following_url":"https://api.github.com/users/KuldeepSinh/following{/other_user}","gists_url":"https://api.github.com/users/KuldeepSinh/gists{/gist_id}","starred_url":"https://api.github.com/users/KuldeepSinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KuldeepSinh/subscriptions","organizations_url":"https://api.github.com/users/KuldeepSinh/orgs","repos_url":"https://api.github.com/users/KuldeepSinh/repos","events_url":"https://api.github.com/users/KuldeepSinh/events{/privacy}","received_events_url":"https://api.github.com/users/KuldeepSinh/received_events","type":"User","site_admin":false},"repo":{"id":56365314,"name":"yams_mqtt_lib","full_name":"KuldeepSinh/yams_mqtt_lib","owner":{"login":"KuldeepSinh","id":1673637,"avatar_url":"https://avatars.githubusercontent.com/u/1673637?v=3","gravatar_id":"","url":"https://api.github.com/users/KuldeepSinh","html_url":"https://github.com/KuldeepSinh","followers_url":"https://api.github.com/users/KuldeepSinh/followers","following_url":"https://api.github.com/users/KuldeepSinh/following{/other_user}","gists_url":"https://api.github.com/users/KuldeepSinh/gists{/gist_id}","starred_url":"https://api.github.com/users/KuldeepSinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KuldeepSinh/subscriptions","organizations_url":"https://api.github.com/users/KuldeepSinh/orgs","repos_url":"https://api.github.com/users/KuldeepSinh/repos","events_url":"https://api.github.com/users/KuldeepSinh/events{/privacy}","received_events_url":"https://api.github.com/users/KuldeepSinh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KuldeepSinh/yams_mqtt_lib","description":"Yet Another MQTT Library - written in Erlang!","fork":true,"url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib","forks_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/forks","keys_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/teams","hooks_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/hooks","issue_events_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/issues/events{/number}","events_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/events","assignees_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/assignees{/user}","branches_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/branches{/branch}","tags_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/tags","blobs_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/statuses/{sha}","languages_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/languages","stargazers_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/stargazers","contributors_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/contributors","subscribers_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/subscribers","subscription_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/subscription","commits_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/contents/{+path}","compare_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/merges","archive_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/downloads","issues_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/issues{/number}","pulls_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/pulls{/number}","milestones_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/milestones{/number}","notifications_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/labels{/name}","releases_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/releases{/id}","deployments_url":"https://api.github.com/repos/KuldeepSinh/yams_mqtt_lib/deployments","created_at":"2016-04-16T04:20:58Z","updated_at":"2016-04-16T05:44:11Z","pushed_at":"2016-04-21T07:00:09Z","git_url":"git://github.com/KuldeepSinh/yams_mqtt_lib.git","ssh_url":"git@github.com:KuldeepSinh/yams_mqtt_lib.git","clone_url":"https://github.com/KuldeepSinh/yams_mqtt_lib.git","svn_url":"https://github.com/KuldeepSinh/yams_mqtt_lib","homepage":null,"size":22,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yams-mqtt:master","ref":"master","sha":"ec67764d0b27f75a1b7fba78e9c3c8be95624157","user":{"login":"yams-mqtt","id":18494407,"avatar_url":"https://avatars.githubusercontent.com/u/18494407?v=3","gravatar_id":"","url":"https://api.github.com/users/yams-mqtt","html_url":"https://github.com/yams-mqtt","followers_url":"https://api.github.com/users/yams-mqtt/followers","following_url":"https://api.github.com/users/yams-mqtt/following{/other_user}","gists_url":"https://api.github.com/users/yams-mqtt/gists{/gist_id}","starred_url":"https://api.github.com/users/yams-mqtt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yams-mqtt/subscriptions","organizations_url":"https://api.github.com/users/yams-mqtt/orgs","repos_url":"https://api.github.com/users/yams-mqtt/repos","events_url":"https://api.github.com/users/yams-mqtt/events{/privacy}","received_events_url":"https://api.github.com/users/yams-mqtt/received_events","type":"User","site_admin":false},"repo":{"id":56365199,"name":"yams_mqtt_lib","full_name":"yams-mqtt/yams_mqtt_lib","owner":{"login":"yams-mqtt","id":18494407,"avatar_url":"https://avatars.githubusercontent.com/u/18494407?v=3","gravatar_id":"","url":"https://api.github.com/users/yams-mqtt","html_url":"https://github.com/yams-mqtt","followers_url":"https://api.github.com/users/yams-mqtt/followers","following_url":"https://api.github.com/users/yams-mqtt/following{/other_user}","gists_url":"https://api.github.com/users/yams-mqtt/gists{/gist_id}","starred_url":"https://api.github.com/users/yams-mqtt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yams-mqtt/subscriptions","organizations_url":"https://api.github.com/users/yams-mqtt/orgs","repos_url":"https://api.github.com/users/yams-mqtt/repos","events_url":"https://api.github.com/users/yams-mqtt/events{/privacy}","received_events_url":"https://api.github.com/users/yams-mqtt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yams-mqtt/yams_mqtt_lib","description":"Yet Another MQTT Library - written in Erlang!","fork":false,"url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib","forks_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/forks","keys_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/teams","hooks_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/hooks","issue_events_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/issues/events{/number}","events_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/events","assignees_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/assignees{/user}","branches_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/branches{/branch}","tags_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/tags","blobs_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/statuses/{sha}","languages_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/languages","stargazers_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/stargazers","contributors_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/contributors","subscribers_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/subscribers","subscription_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/subscription","commits_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/contents/{+path}","compare_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/merges","archive_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/downloads","issues_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/issues{/number}","pulls_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/pulls{/number}","milestones_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/milestones{/number}","notifications_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/labels{/name}","releases_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/releases{/id}","deployments_url":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/deployments","created_at":"2016-04-16T04:16:27Z","updated_at":"2016-04-16T06:18:13Z","pushed_at":"2016-04-21T06:04:42Z","git_url":"git://github.com/yams-mqtt/yams_mqtt_lib.git","ssh_url":"git@github.com:yams-mqtt/yams_mqtt_lib.git","clone_url":"https://github.com/yams-mqtt/yams_mqtt_lib.git","svn_url":"https://github.com/yams-mqtt/yams_mqtt_lib","homepage":null,"size":21,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/pulls/12"},"html":{"href":"https://github.com/yams-mqtt/yams_mqtt_lib/pull/12"},"issue":{"href":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/issues/12"},"comments":{"href":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/yams-mqtt/yams_mqtt_lib/statuses/74fb47a706c186ea784ec0ff28ed55b4ba0a0de1"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":20,"deletions":16,"changed_files":2}}