{"action":"created","issue":{"url":"https://api.github.com/repos/raboof/notion/issues/31","repository_url":"https://api.github.com/repos/raboof/notion","labels_url":"https://api.github.com/repos/raboof/notion/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/raboof/notion/issues/31/comments","events_url":"https://api.github.com/repos/raboof/notion/issues/31/events","html_url":"https://github.com/raboof/notion/pull/31","id":189918021,"number":31,"title":"Fix buffer overrun reading WM_STATE","user":{"login":"ideasman42","id":1869379,"avatar_url":"https://avatars.githubusercontent.com/u/1869379?v=3","gravatar_id":"","url":"https://api.github.com/users/ideasman42","html_url":"https://github.com/ideasman42","followers_url":"https://api.github.com/users/ideasman42/followers","following_url":"https://api.github.com/users/ideasman42/following{/other_user}","gists_url":"https://api.github.com/users/ideasman42/gists{/gist_id}","starred_url":"https://api.github.com/users/ideasman42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ideasman42/subscriptions","organizations_url":"https://api.github.com/users/ideasman42/orgs","repos_url":"https://api.github.com/users/ideasman42/repos","events_url":"https://api.github.com/users/ideasman42/events{/privacy}","received_events_url":"https://api.github.com/users/ideasman42/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ideasman42","id":1869379,"avatar_url":"https://avatars.githubusercontent.com/u/1869379?v=3","gravatar_id":"","url":"https://api.github.com/users/ideasman42","html_url":"https://github.com/ideasman42","followers_url":"https://api.github.com/users/ideasman42/followers","following_url":"https://api.github.com/users/ideasman42/following{/other_user}","gists_url":"https://api.github.com/users/ideasman42/gists{/gist_id}","starred_url":"https://api.github.com/users/ideasman42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ideasman42/subscriptions","organizations_url":"https://api.github.com/users/ideasman42/orgs","repos_url":"https://api.github.com/users/ideasman42/repos","events_url":"https://api.github.com/users/ideasman42/events{/privacy}","received_events_url":"https://api.github.com/users/ideasman42/received_events","type":"User","site_admin":false},"assignees":[{"login":"ideasman42","id":1869379,"avatar_url":"https://avatars.githubusercontent.com/u/1869379?v=3","gravatar_id":"","url":"https://api.github.com/users/ideasman42","html_url":"https://github.com/ideasman42","followers_url":"https://api.github.com/users/ideasman42/followers","following_url":"https://api.github.com/users/ideasman42/following{/other_user}","gists_url":"https://api.github.com/users/ideasman42/gists{/gist_id}","starred_url":"https://api.github.com/users/ideasman42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ideasman42/subscriptions","organizations_url":"https://api.github.com/users/ideasman42/orgs","repos_url":"https://api.github.com/users/ideasman42/repos","events_url":"https://api.github.com/users/ideasman42/events{/privacy}","received_events_url":"https://api.github.com/users/ideasman42/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-11-17T02:37:04Z","updated_at":"2016-11-19T21:41:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/raboof/notion/pulls/31","html_url":"https://github.com/raboof/notion/pull/31","diff_url":"https://github.com/raboof/notion/pull/31.diff","patch_url":"https://github.com/raboof/notion/pull/31.patch"},"body":"While the first value is defined to be CARD32,\r\nthe actual array is Atom/long (openbox uses ulong, Blender uses Atom\r\nboth resolve to long.\r\n\r\nNote that this isn't mentioned in the docs, but most uses I could find\r\nuse either long or Atom.\r\n\r\nSee details:\r\n```\r\n==6703== Syscall param writev(vector[...]) points to uninitialised byte(s)\r\n==6703==    at 0x5DB2B60: __writev_nocancel (in /usr/lib/libc-2.24.so)\r\n==6703==    by 0x607CBAC: ??? (in /usr/lib/libxcb.so.1.1.0)\r\n==6703==    by 0x607CFAC: ??? (in /usr/lib/libxcb.so.1.1.0)\r\n==6703==    by 0x607D02C: xcb_writev (in /usr/lib/libxcb.so.1.1.0)\r\n==6703==    by 0x4E78F4D: _XSend (in /usr/lib/libX11.so.6.3.0)\r\n==6703==    by 0x4E79441: _XReply (in /usr/lib/libX11.so.6.3.0)\r\n==6703==    by 0x4E5F7AD: XGetWindowProperty (in /usr/lib/libX11.so.6.3.0)\r\n==6703==    by 0x41C0A9: xwindow_get_property_ (property.c:30)\r\n==6703==    by 0x41C187: xwindow_get_property (property.c:59)\r\n==6703==    by 0x41C2A9: xwindow_get_integer_property (property.c:106)\r\n==6703==    by 0x423D93: clientwin_load (clientwin.c:1438)\r\n==6703==    by 0x42D391: create_region_load (saveload.c:106)\r\n==6703==    by 0x4270A8: wrap_load (attach.c:133)\r\n==6703==    by 0x426E08: doit_new (attach.c:33)\r\n==6703==    by 0x42716F: doit_load (attach.c:163)\r\n==6703==    by 0x4271C2: region_attach_load_helper (attach.c:174)\r\n==6703==    by 0x440E3A: group_do_load (group.c:1354)\r\n==6703==    by 0x44206D: groupcw_load (group-cw.c:301)\r\n==6703==    by 0x42D391: create_region_load (saveload.c:106)\r\n==6703==    by 0x4270A8: wrap_load (attach.c:133)\r\n==6703==    by 0x426E08: doit_new (attach.c:33)\r\n==6703==    by 0x42716F: doit_load (attach.c:163)\r\n==6703==    by 0x4271C2: region_attach_load_helper (attach.c:174)\r\n==6703==    by 0x434D59: mplex_load_contents (mplex.c:2164)\r\n==6703==    by 0x42F330: frame_do_load (frame.c:911)\r\n==6703==    by 0x42F3D4: frame_load (frame.c:931)\r\n==6703==    by 0x42D391: create_region_load (saveload.c:106)\r\n==6703==    by 0x4270A8: wrap_load (attach.c:133)\r\n==6703==    by 0x426E08: doit_new (attach.c:33)\r\n==6703==    by 0x42716F: doit_load (attach.c:163)\r\n==6703==    by 0x427265: region_attach_helper (attach.c:187)\r\n==6703==    by 0x7916940: load_splitregion (tiling.c:1496)\r\n==6703==    by 0x7916D67: tiling_load_node_default (tiling.c:1609)\r\n==6703==    by 0x7916E7B: tiling_load_node (tiling.c:1628)\r\n==6703==    by 0x7916C17: load_splitsplit (tiling.c:1566)\r\n==6703==    by 0x7916D9D: tiling_load_node_default (tiling.c:1611)\r\n==6703==    by 0x7916E7B: tiling_load_node (tiling.c:1628)\r\n==6703==    by 0x7916B8C: load_splitsplit (tiling.c:1552)\r\n==6703==    by 0x7916D9D: tiling_load_node_default (tiling.c:1611)\r\n==6703==    by 0x7916E7B: tiling_load_node (tiling.c:1628)\r\n==6703==    by 0x7916F1E: tiling_load (tiling.c:1652)\r\n==6703==    by 0x42D391: create_region_load (saveload.c:106)\r\n==6703==    by 0x4270A8: wrap_load (attach.c:133)\r\n==6703==    by 0x426E08: doit_new (attach.c:33)\r\n==6703==    by 0x42716F: doit_load (attach.c:163)\r\n==6703==    by 0x4271C2: region_attach_load_helper (attach.c:174)\r\n==6703==    by 0x440E3A: group_do_load (group.c:1354)\r\n==6703==    by 0x44354B: groupws_load (group-ws.c:350)\r\n==6703==    by 0x42D391: create_region_load (saveload.c:106)\r\n==6703==    by 0x4270A8: wrap_load (attach.c:133)\r\n==6703==  Address 0x690ccb4 is 52 bytes inside a block of size 16,384 alloc'd\r\n==6703==    at 0x4C2CA40: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)\r\n==6703==    by 0x4E69395: XOpenDisplay (in /usr/lib/libX11.so.6.3.0)\r\n==6703==    by 0x41FBEA: ioncore_init_x (ioncore.c:506)\r\n==6703==    by 0x4200DC: ioncore_startup (ioncore.c:627)\r\n==6703==    by 0x41568F: main (notion.c:239)\r\n==6703==  Uninitialised value was created by a stack allocation\r\n==6703==    at 0x41C3A7: xwindow_set_state_property (property.c:150)\r\n==6703== \r\n```"},"comment":{"url":"https://api.github.com/repos/raboof/notion/issues/comments/261741493","html_url":"https://github.com/raboof/notion/pull/31#issuecomment-261741493","issue_url":"https://api.github.com/repos/raboof/notion/issues/31","id":261741493,"user":{"login":"raboof","id":131856,"avatar_url":"https://avatars.githubusercontent.com/u/131856?v=3","gravatar_id":"","url":"https://api.github.com/users/raboof","html_url":"https://github.com/raboof","followers_url":"https://api.github.com/users/raboof/followers","following_url":"https://api.github.com/users/raboof/following{/other_user}","gists_url":"https://api.github.com/users/raboof/gists{/gist_id}","starred_url":"https://api.github.com/users/raboof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raboof/subscriptions","organizations_url":"https://api.github.com/users/raboof/orgs","repos_url":"https://api.github.com/users/raboof/repos","events_url":"https://api.github.com/users/raboof/events{/privacy}","received_events_url":"https://api.github.com/users/raboof/received_events","type":"User","site_admin":false},"created_at":"2016-11-19T21:41:21Z","updated_at":"2016-11-19T21:41:21Z","body":"Great!! The new fix aligns much better to https://tronche.com/gui/x/icccm/sec-4.html#s-4.1.3.1, too :)"}}
{"actor":{"display_login":"raboof"}}