{"action":"created","comment":{"url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/comments/71072117","id":71072117,"diff_hunk":"@@ -45,45 +45,128 @@ var/list/event_last_fired = list()\n \t// Code/WorkInProgress/Cael_Aislinn/Economy/Economy_Events.dm\n \t// Code/WorkInProgress/Cael_Aislinn/Economy/Economy_Events_Mundane.dm\n \n+\n+\t//Rework by Nanako\n+\t//Based upon the standard listed above - aim for 100 weight for average.\n+\t//Assuming a crew containing four people in the primary roles of each department (sec, engineering, science, medical)\n+\t//Weights with that crew compliment are adapted to be more or less common, by being either side of 100,\n+\t\t//based on my idea of which ones are fun\n+\t\t//More people in those departments will increase the likelihood of those events. Especially combat oriented ones with lots of sec\n+\n+\n+\t//Mundane Events\n+\t//=====================================\n \tpossibleEvents[/datum/event/economic_event] = 300\n \tpossibleEvents[/datum/event/trivial_news] = 400\n \tpossibleEvents[/datum/event/mundane_news] = 300\n-\n \tpossibleEvents[/datum/event/pda_spam] = max(min(25, player_list.len) * 4, 200)\n-\tpossibleEvents[/datum/event/money_lotto] = max(min(5, player_list.len), 50)\n+\tpossibleEvents[/datum/event/money_lotto] = 10\n+\tpossibleEvents[/datum/event/brand_intelligence] = 10 + 10 * active_with_role[\"Janitor\"] +  5 * active_with_role[\"Engineer\"]\n \tif(account_hack_attempted)\n-\t\tpossibleEvents[/datum/event/money_hacker] = max(min(25, player_list.len) * 4, 200)\n+\t\t//Made account hack far rarer, reasoning provided in a forum thread on 2016-06-28\n+\t\t//In short, its meaningless, annoying, and it trains people to ignore request consoles\n+\t\t//Consider restoring it to commonality when economy is fleshed out and currency becomes meaningful\n+\t\tpossibleEvents[/datum/event/money_hacker] = 10\n \n+\tpossibleEvents[/datum/event/infestation] = 50 + 50 * active_with_role[\"Janitor\"]\n \n-\tpossibleEvents[/datum/event/carp_migration] = 20 + 10 * active_with_role[\"Engineer\"]\n-\tpossibleEvents[/datum/event/brand_intelligence] = 20 + 25 * active_with_role[\"Janitor\"]\n+\t//Wallrot made much less engineer-dependant, but more gardener-dependant.\n+\tpossibleEvents[/datum/event/wallrot] = 75 + 5 * active_with_role[\"Engineer\"] + 20 * active_with_role[\"Gardener\"]\n \n-\tpossibleEvents[/datum/event/rogue_drone] = 5 + 25 * active_with_role[\"Engineer\"] + 25 * active_with_role[\"Security\"]\n-\tpossibleEvents[/datum/event/infestation] = 100 + 100 * active_with_role[\"Janitor\"]\n \n-\tpossibleEvents[/datum/event/communications_blackout] = 50 + 25 * active_with_role[\"AI\"] + active_with_role[\"Scientist\"] * 25\n-\tpossibleEvents[/datum/event/ionstorm] = active_with_role[\"AI\"] * 25 + active_with_role[\"Cyborg\"] * 25 + active_with_role[\"Engineer\"] * 10 + active_with_role[\"Scientist\"] * 5\n-\tpossibleEvents[/datum/event/grid_check] = 25 + 10 * active_with_role[\"Engineer\"]\n-\tpossibleEvents[/datum/event/electrical_storm] = 15 * active_with_role[\"Janitor\"] + 5 * active_with_role[\"Engineer\"]\n-\tpossibleEvents[/datum/event/wallrot] = 30 * active_with_role[\"Engineer\"] + 50 * active_with_role[\"Gardener\"]\n \n-\tif(!spacevines_spawned)\n-\t\tpossibleEvents[/datum/event/spacevine] = 10 + 5 * active_with_role[\"Engineer\"]\n-\tif(minutes_passed >= 30) // Give engineers time to set up engine\n-\t\tpossibleEvents[/datum/event/meteor_wave] = 10 * active_with_role[\"Engineer\"]\n-\t\tpossibleEvents[/datum/event/meteor_shower] = 20 * active_with_role[\"Engineer\"]\n-\t\tpossibleEvents[/datum/event/blob] = 10 * active_with_role[\"Engineer\"]\n+\n+\n+\n+\t//Moderate Events\n+\t//================================================\n+\n+\t\t//Combat oriented events, more heavily weighted to number of sec officers\n+\tpossibleEvents[/datum/event/rogue_drone] = 50 + 25 * active_with_role[\"Security\"]\n+\tpossibleEvents[/datum/event/spider_infestation] = 50 + 25 * active_with_role[\"Security\"]\n+\tpossibleEvents[/datum/event/carp_migration] = 50 + 25 * active_with_role[\"Security\"]\n+\n+\tpossibleEvents[/datum/event/communications_blackout] = 40//Comms blackout is too common and annoying","path":"code/modules/events/event_dynamic.dm","position":63,"original_position":63,"commit_id":"5f02f52090273596f498738f31a6d550a74a0a4b","original_commit_id":"5f02f52090273596f498738f31a6d550a74a0a4b","user":{"login":"Bedshaped","id":2355516,"avatar_url":"https://avatars.githubusercontent.com/u/2355516?v=3","gravatar_id":"","url":"https://api.github.com/users/Bedshaped","html_url":"https://github.com/Bedshaped","followers_url":"https://api.github.com/users/Bedshaped/followers","following_url":"https://api.github.com/users/Bedshaped/following{/other_user}","gists_url":"https://api.github.com/users/Bedshaped/gists{/gist_id}","starred_url":"https://api.github.com/users/Bedshaped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bedshaped/subscriptions","organizations_url":"https://api.github.com/users/Bedshaped/orgs","repos_url":"https://api.github.com/users/Bedshaped/repos","events_url":"https://api.github.com/users/Bedshaped/events{/privacy}","received_events_url":"https://api.github.com/users/Bedshaped/received_events","type":"User","site_admin":false},"body":"Communication blackout is the least damaging of the random events and force people to use the not-often used wall radios. I'd say they don't happen enough actually.","created_at":"2016-07-16T21:26:07Z","updated_at":"2016-07-16T21:26:07Z","html_url":"https://github.com/Aurorastation/Aurora.3/pull/591#discussion_r71072117","pull_request_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/591","_links":{"self":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/comments/71072117"},"html":{"href":"https://github.com/Aurorastation/Aurora.3/pull/591#discussion_r71072117"},"pull_request":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/591"}}},"pull_request":{"url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/591","id":77713731,"html_url":"https://github.com/Aurorastation/Aurora.3/pull/591","diff_url":"https://github.com/Aurorastation/Aurora.3/pull/591.diff","patch_url":"https://github.com/Aurorastation/Aurora.3/pull/591.patch","issue_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/591","number":591,"state":"open","locked":false,"title":"Event Probabilities Rework","user":{"login":"NanakoAC","id":18094775,"avatar_url":"https://avatars.githubusercontent.com/u/18094775?v=3","gravatar_id":"","url":"https://api.github.com/users/NanakoAC","html_url":"https://github.com/NanakoAC","followers_url":"https://api.github.com/users/NanakoAC/followers","following_url":"https://api.github.com/users/NanakoAC/following{/other_user}","gists_url":"https://api.github.com/users/NanakoAC/gists{/gist_id}","starred_url":"https://api.github.com/users/NanakoAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NanakoAC/subscriptions","organizations_url":"https://api.github.com/users/NanakoAC/orgs","repos_url":"https://api.github.com/users/NanakoAC/repos","events_url":"https://api.github.com/users/NanakoAC/events{/privacy}","received_events_url":"https://api.github.com/users/NanakoAC/received_events","type":"User","site_admin":false},"body":"All event triggering weights re-evaluated, standardised, and set according to some semblance of logic.\r\nFor exact changes, look at the code, most decisions are explained in comments\r\n\r\nChangelog will be added later once i decide exactly how much to put in it, but leaning towards leaving things vague and mysterious\r\n\r\nThis was done with three design goals in mind:\r\n1. Making 'interesting' events more common, especially those that have a decent chance to affect the dynamic of a round, as well as making annoying/boring things a bit less common.\r\n2. Giving people stuff to do when a department is overstaffed. All the combat things are more weighted towards security staff, and destructive things more weighted towards engineering. Many other events have had staff requirements removed or reduced\r\n3. Evening out event selections, preventing certain things (like blobs and comms blackout) from being too common, and other things (like spiders, drones and meteors) from being so rare. Severe events especially should have a much more varied selection.","created_at":"2016-07-16T16:40:36Z","updated_at":"2016-07-16T21:26:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2051e88cbe1e36c54efefd7f921499d2f6261d9a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/591/commits","review_comments_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/591/comments","review_comment_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/591/comments","statuses_url":"https://api.github.com/repos/Aurorastation/Aurora.3/statuses/5f02f52090273596f498738f31a6d550a74a0a4b","head":{"label":"NanakoAC:EventSelection","ref":"EventSelection","sha":"5f02f52090273596f498738f31a6d550a74a0a4b","user":{"login":"NanakoAC","id":18094775,"avatar_url":"https://avatars.githubusercontent.com/u/18094775?v=3","gravatar_id":"","url":"https://api.github.com/users/NanakoAC","html_url":"https://github.com/NanakoAC","followers_url":"https://api.github.com/users/NanakoAC/followers","following_url":"https://api.github.com/users/NanakoAC/following{/other_user}","gists_url":"https://api.github.com/users/NanakoAC/gists{/gist_id}","starred_url":"https://api.github.com/users/NanakoAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NanakoAC/subscriptions","organizations_url":"https://api.github.com/users/NanakoAC/orgs","repos_url":"https://api.github.com/users/NanakoAC/repos","events_url":"https://api.github.com/users/NanakoAC/events{/privacy}","received_events_url":"https://api.github.com/users/NanakoAC/received_events","type":"User","site_admin":false},"repo":{"id":59347611,"name":"Aurora.3","full_name":"NanakoAC/Aurora.3","owner":{"login":"NanakoAC","id":18094775,"avatar_url":"https://avatars.githubusercontent.com/u/18094775?v=3","gravatar_id":"","url":"https://api.github.com/users/NanakoAC","html_url":"https://github.com/NanakoAC","followers_url":"https://api.github.com/users/NanakoAC/followers","following_url":"https://api.github.com/users/NanakoAC/following{/other_user}","gists_url":"https://api.github.com/users/NanakoAC/gists{/gist_id}","starred_url":"https://api.github.com/users/NanakoAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NanakoAC/subscriptions","organizations_url":"https://api.github.com/users/NanakoAC/orgs","repos_url":"https://api.github.com/users/NanakoAC/repos","events_url":"https://api.github.com/users/NanakoAC/events{/privacy}","received_events_url":"https://api.github.com/users/NanakoAC/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NanakoAC/Aurora.3","description":"The code for Aurorastation's new base, forked from Baystation12.","fork":true,"url":"https://api.github.com/repos/NanakoAC/Aurora.3","forks_url":"https://api.github.com/repos/NanakoAC/Aurora.3/forks","keys_url":"https://api.github.com/repos/NanakoAC/Aurora.3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NanakoAC/Aurora.3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NanakoAC/Aurora.3/teams","hooks_url":"https://api.github.com/repos/NanakoAC/Aurora.3/hooks","issue_events_url":"https://api.github.com/repos/NanakoAC/Aurora.3/issues/events{/number}","events_url":"https://api.github.com/repos/NanakoAC/Aurora.3/events","assignees_url":"https://api.github.com/repos/NanakoAC/Aurora.3/assignees{/user}","branches_url":"https://api.github.com/repos/NanakoAC/Aurora.3/branches{/branch}","tags_url":"https://api.github.com/repos/NanakoAC/Aurora.3/tags","blobs_url":"https://api.github.com/repos/NanakoAC/Aurora.3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NanakoAC/Aurora.3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NanakoAC/Aurora.3/git/refs{/sha}","trees_url":"https://api.github.com/repos/NanakoAC/Aurora.3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NanakoAC/Aurora.3/statuses/{sha}","languages_url":"https://api.github.com/repos/NanakoAC/Aurora.3/languages","stargazers_url":"https://api.github.com/repos/NanakoAC/Aurora.3/stargazers","contributors_url":"https://api.github.com/repos/NanakoAC/Aurora.3/contributors","subscribers_url":"https://api.github.com/repos/NanakoAC/Aurora.3/subscribers","subscription_url":"https://api.github.com/repos/NanakoAC/Aurora.3/subscription","commits_url":"https://api.github.com/repos/NanakoAC/Aurora.3/commits{/sha}","git_commits_url":"https://api.github.com/repos/NanakoAC/Aurora.3/git/commits{/sha}","comments_url":"https://api.github.com/repos/NanakoAC/Aurora.3/comments{/number}","issue_comment_url":"https://api.github.com/repos/NanakoAC/Aurora.3/issues/comments{/number}","contents_url":"https://api.github.com/repos/NanakoAC/Aurora.3/contents/{+path}","compare_url":"https://api.github.com/repos/NanakoAC/Aurora.3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NanakoAC/Aurora.3/merges","archive_url":"https://api.github.com/repos/NanakoAC/Aurora.3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NanakoAC/Aurora.3/downloads","issues_url":"https://api.github.com/repos/NanakoAC/Aurora.3/issues{/number}","pulls_url":"https://api.github.com/repos/NanakoAC/Aurora.3/pulls{/number}","milestones_url":"https://api.github.com/repos/NanakoAC/Aurora.3/milestones{/number}","notifications_url":"https://api.github.com/repos/NanakoAC/Aurora.3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NanakoAC/Aurora.3/labels{/name}","releases_url":"https://api.github.com/repos/NanakoAC/Aurora.3/releases{/id}","deployments_url":"https://api.github.com/repos/NanakoAC/Aurora.3/deployments","created_at":"2016-05-21T07:31:49Z","updated_at":"2016-05-21T07:31:59Z","pushed_at":"2016-07-16T16:38:51Z","git_url":"git://github.com/NanakoAC/Aurora.3.git","ssh_url":"git@github.com:NanakoAC/Aurora.3.git","clone_url":"https://github.com/NanakoAC/Aurora.3.git","svn_url":"https://github.com/NanakoAC/Aurora.3","homepage":"http://aurorastation.org/","size":541660,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Aurorastation:development","ref":"development","sha":"de4e73b105219e8db966cf0decbd0b2ea74c38d9","user":{"login":"Aurorastation","id":6915762,"avatar_url":"https://avatars.githubusercontent.com/u/6915762?v=3","gravatar_id":"","url":"https://api.github.com/users/Aurorastation","html_url":"https://github.com/Aurorastation","followers_url":"https://api.github.com/users/Aurorastation/followers","following_url":"https://api.github.com/users/Aurorastation/following{/other_user}","gists_url":"https://api.github.com/users/Aurorastation/gists{/gist_id}","starred_url":"https://api.github.com/users/Aurorastation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aurorastation/subscriptions","organizations_url":"https://api.github.com/users/Aurorastation/orgs","repos_url":"https://api.github.com/users/Aurorastation/repos","events_url":"https://api.github.com/users/Aurorastation/events{/privacy}","received_events_url":"https://api.github.com/users/Aurorastation/received_events","type":"Organization","site_admin":false},"repo":{"id":42579199,"name":"Aurora.3","full_name":"Aurorastation/Aurora.3","owner":{"login":"Aurorastation","id":6915762,"avatar_url":"https://avatars.githubusercontent.com/u/6915762?v=3","gravatar_id":"","url":"https://api.github.com/users/Aurorastation","html_url":"https://github.com/Aurorastation","followers_url":"https://api.github.com/users/Aurorastation/followers","following_url":"https://api.github.com/users/Aurorastation/following{/other_user}","gists_url":"https://api.github.com/users/Aurorastation/gists{/gist_id}","starred_url":"https://api.github.com/users/Aurorastation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aurorastation/subscriptions","organizations_url":"https://api.github.com/users/Aurorastation/orgs","repos_url":"https://api.github.com/users/Aurorastation/repos","events_url":"https://api.github.com/users/Aurorastation/events{/privacy}","received_events_url":"https://api.github.com/users/Aurorastation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Aurorastation/Aurora.3","description":"The code for Aurorastation's new base, forked from Baystation12.","fork":true,"url":"https://api.github.com/repos/Aurorastation/Aurora.3","forks_url":"https://api.github.com/repos/Aurorastation/Aurora.3/forks","keys_url":"https://api.github.com/repos/Aurorastation/Aurora.3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Aurorastation/Aurora.3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Aurorastation/Aurora.3/teams","hooks_url":"https://api.github.com/repos/Aurorastation/Aurora.3/hooks","issue_events_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/events{/number}","events_url":"https://api.github.com/repos/Aurorastation/Aurora.3/events","assignees_url":"https://api.github.com/repos/Aurorastation/Aurora.3/assignees{/user}","branches_url":"https://api.github.com/repos/Aurorastation/Aurora.3/branches{/branch}","tags_url":"https://api.github.com/repos/Aurorastation/Aurora.3/tags","blobs_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Aurorastation/Aurora.3/statuses/{sha}","languages_url":"https://api.github.com/repos/Aurorastation/Aurora.3/languages","stargazers_url":"https://api.github.com/repos/Aurorastation/Aurora.3/stargazers","contributors_url":"https://api.github.com/repos/Aurorastation/Aurora.3/contributors","subscribers_url":"https://api.github.com/repos/Aurorastation/Aurora.3/subscribers","subscription_url":"https://api.github.com/repos/Aurorastation/Aurora.3/subscription","commits_url":"https://api.github.com/repos/Aurorastation/Aurora.3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Aurorastation/Aurora.3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Aurorastation/Aurora.3/contents/{+path}","compare_url":"https://api.github.com/repos/Aurorastation/Aurora.3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Aurorastation/Aurora.3/merges","archive_url":"https://api.github.com/repos/Aurorastation/Aurora.3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Aurorastation/Aurora.3/downloads","issues_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues{/number}","pulls_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls{/number}","milestones_url":"https://api.github.com/repos/Aurorastation/Aurora.3/milestones{/number}","notifications_url":"https://api.github.com/repos/Aurorastation/Aurora.3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Aurorastation/Aurora.3/labels{/name}","releases_url":"https://api.github.com/repos/Aurorastation/Aurora.3/releases{/id}","deployments_url":"https://api.github.com/repos/Aurorastation/Aurora.3/deployments","created_at":"2015-09-16T09:56:37Z","updated_at":"2016-07-13T05:13:13Z","pushed_at":"2016-07-16T16:40:36Z","git_url":"git://github.com/Aurorastation/Aurora.3.git","ssh_url":"git@github.com:Aurorastation/Aurora.3.git","clone_url":"https://github.com/Aurorastation/Aurora.3.git","svn_url":"https://github.com/Aurorastation/Aurora.3","homepage":"http://aurorastation.org/","size":544016,"stargazers_count":6,"watchers_count":6,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":121,"forks":25,"open_issues":121,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/591"},"html":{"href":"https://github.com/Aurorastation/Aurora.3/pull/591"},"issue":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/591"},"comments":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/591/comments"},"review_comments":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/591/comments"},"review_comment":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/591/commits"},"statuses":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/statuses/5f02f52090273596f498738f31a6d550a74a0a4b"}}}}
{"actor":{"display_login":"Bedshaped"}}