{"action":"closed","number":178,"pull_request":{"url":"https://api.github.com/repos/sindresorhus/got/pulls/178","id":60607382,"html_url":"https://github.com/sindresorhus/got/pull/178","diff_url":"https://github.com/sindresorhus/got/pull/178.diff","patch_url":"https://github.com/sindresorhus/got/pull/178.patch","issue_url":"https://api.github.com/repos/sindresorhus/got/issues/178","number":178,"state":"closed","locked":false,"title":"Proxy support","user":{"login":"alexsantos","id":932219,"avatar_url":"https://avatars.githubusercontent.com/u/932219?v=3","gravatar_id":"","url":"https://api.github.com/users/alexsantos","html_url":"https://github.com/alexsantos","followers_url":"https://api.github.com/users/alexsantos/followers","following_url":"https://api.github.com/users/alexsantos/following{/other_user}","gists_url":"https://api.github.com/users/alexsantos/gists{/gist_id}","starred_url":"https://api.github.com/users/alexsantos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexsantos/subscriptions","organizations_url":"https://api.github.com/users/alexsantos/orgs","repos_url":"https://api.github.com/users/alexsantos/repos","events_url":"https://api.github.com/users/alexsantos/events{/privacy}","received_events_url":"https://api.github.com/users/alexsantos/received_events","type":"User","site_admin":false},"body":"This a PR for proxy support on got, using the environment variables:\r\n\r\n- HTTP_PROXY / http_proxy\r\n- HTTPS_PROXY / https_proxy\r\n- NO_PROXY / no_proxy\r\n\r\nFor now, it supports these no_proxy use cases:\r\n- hostame, hostname:port\r\n- ipv4, ipv4/range\r\n- ipv6 (no ipv6/range)\r\n- *\r\n\r\nTests\r\nThere are 13 tests on test/proxy.js, covering both http and https hostnames, ipv4, ipv6 and socks. The https proxy has problems with self signed certificates, so no tests on that.\r\n\r\nPlease comment on this.\r\n\r\nAlex","created_at":"2016-02-25T00:59:22Z","updated_at":"2016-02-25T11:04:17Z","closed_at":"2016-02-25T11:04:17Z","merged_at":null,"merge_commit_sha":"78f9517e7bea4cc55dcbc66e920378bd4ad32f36","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sindresorhus/got/pulls/178/commits","review_comments_url":"https://api.github.com/repos/sindresorhus/got/pulls/178/comments","review_comment_url":"https://api.github.com/repos/sindresorhus/got/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sindresorhus/got/issues/178/comments","statuses_url":"https://api.github.com/repos/sindresorhus/got/statuses/392a0ddabfd008c7253fa9c79aa910e600c78e93","head":{"label":"alexsantos:proxy-support","ref":"proxy-support","sha":"392a0ddabfd008c7253fa9c79aa910e600c78e93","user":{"login":"alexsantos","id":932219,"avatar_url":"https://avatars.githubusercontent.com/u/932219?v=3","gravatar_id":"","url":"https://api.github.com/users/alexsantos","html_url":"https://github.com/alexsantos","followers_url":"https://api.github.com/users/alexsantos/followers","following_url":"https://api.github.com/users/alexsantos/following{/other_user}","gists_url":"https://api.github.com/users/alexsantos/gists{/gist_id}","starred_url":"https://api.github.com/users/alexsantos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexsantos/subscriptions","organizations_url":"https://api.github.com/users/alexsantos/orgs","repos_url":"https://api.github.com/users/alexsantos/repos","events_url":"https://api.github.com/users/alexsantos/events{/privacy}","received_events_url":"https://api.github.com/users/alexsantos/received_events","type":"User","site_admin":false},"repo":{"id":52013141,"name":"got","full_name":"alexsantos/got","owner":{"login":"alexsantos","id":932219,"avatar_url":"https://avatars.githubusercontent.com/u/932219?v=3","gravatar_id":"","url":"https://api.github.com/users/alexsantos","html_url":"https://github.com/alexsantos","followers_url":"https://api.github.com/users/alexsantos/followers","following_url":"https://api.github.com/users/alexsantos/following{/other_user}","gists_url":"https://api.github.com/users/alexsantos/gists{/gist_id}","starred_url":"https://api.github.com/users/alexsantos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexsantos/subscriptions","organizations_url":"https://api.github.com/users/alexsantos/orgs","repos_url":"https://api.github.com/users/alexsantos/repos","events_url":"https://api.github.com/users/alexsantos/events{/privacy}","received_events_url":"https://api.github.com/users/alexsantos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexsantos/got","description":"Simplified HTTP/HTTPS requests","fork":true,"url":"https://api.github.com/repos/alexsantos/got","forks_url":"https://api.github.com/repos/alexsantos/got/forks","keys_url":"https://api.github.com/repos/alexsantos/got/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexsantos/got/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexsantos/got/teams","hooks_url":"https://api.github.com/repos/alexsantos/got/hooks","issue_events_url":"https://api.github.com/repos/alexsantos/got/issues/events{/number}","events_url":"https://api.github.com/repos/alexsantos/got/events","assignees_url":"https://api.github.com/repos/alexsantos/got/assignees{/user}","branches_url":"https://api.github.com/repos/alexsantos/got/branches{/branch}","tags_url":"https://api.github.com/repos/alexsantos/got/tags","blobs_url":"https://api.github.com/repos/alexsantos/got/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexsantos/got/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexsantos/got/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexsantos/got/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexsantos/got/statuses/{sha}","languages_url":"https://api.github.com/repos/alexsantos/got/languages","stargazers_url":"https://api.github.com/repos/alexsantos/got/stargazers","contributors_url":"https://api.github.com/repos/alexsantos/got/contributors","subscribers_url":"https://api.github.com/repos/alexsantos/got/subscribers","subscription_url":"https://api.github.com/repos/alexsantos/got/subscription","commits_url":"https://api.github.com/repos/alexsantos/got/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexsantos/got/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexsantos/got/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexsantos/got/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexsantos/got/contents/{+path}","compare_url":"https://api.github.com/repos/alexsantos/got/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexsantos/got/merges","archive_url":"https://api.github.com/repos/alexsantos/got/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexsantos/got/downloads","issues_url":"https://api.github.com/repos/alexsantos/got/issues{/number}","pulls_url":"https://api.github.com/repos/alexsantos/got/pulls{/number}","milestones_url":"https://api.github.com/repos/alexsantos/got/milestones{/number}","notifications_url":"https://api.github.com/repos/alexsantos/got/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexsantos/got/labels{/name}","releases_url":"https://api.github.com/repos/alexsantos/got/releases{/id}","deployments_url":"https://api.github.com/repos/alexsantos/got/deployments","created_at":"2016-02-18T14:29:45Z","updated_at":"2016-02-18T14:29:46Z","pushed_at":"2016-02-25T00:49:14Z","git_url":"git://github.com/alexsantos/got.git","ssh_url":"git@github.com:alexsantos/got.git","clone_url":"https://github.com/alexsantos/got.git","svn_url":"https://github.com/alexsantos/got","homepage":"","size":619,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sindresorhus:master","ref":"master","sha":"7717a7c8a6844c16c1840269b95597ebb0b756bf","user":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"repo":{"id":18193978,"name":"got","full_name":"sindresorhus/got","owner":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sindresorhus/got","description":"Simplified HTTP/HTTPS requests","fork":false,"url":"https://api.github.com/repos/sindresorhus/got","forks_url":"https://api.github.com/repos/sindresorhus/got/forks","keys_url":"https://api.github.com/repos/sindresorhus/got/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sindresorhus/got/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sindresorhus/got/teams","hooks_url":"https://api.github.com/repos/sindresorhus/got/hooks","issue_events_url":"https://api.github.com/repos/sindresorhus/got/issues/events{/number}","events_url":"https://api.github.com/repos/sindresorhus/got/events","assignees_url":"https://api.github.com/repos/sindresorhus/got/assignees{/user}","branches_url":"https://api.github.com/repos/sindresorhus/got/branches{/branch}","tags_url":"https://api.github.com/repos/sindresorhus/got/tags","blobs_url":"https://api.github.com/repos/sindresorhus/got/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sindresorhus/got/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sindresorhus/got/git/refs{/sha}","trees_url":"https://api.github.com/repos/sindresorhus/got/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sindresorhus/got/statuses/{sha}","languages_url":"https://api.github.com/repos/sindresorhus/got/languages","stargazers_url":"https://api.github.com/repos/sindresorhus/got/stargazers","contributors_url":"https://api.github.com/repos/sindresorhus/got/contributors","subscribers_url":"https://api.github.com/repos/sindresorhus/got/subscribers","subscription_url":"https://api.github.com/repos/sindresorhus/got/subscription","commits_url":"https://api.github.com/repos/sindresorhus/got/commits{/sha}","git_commits_url":"https://api.github.com/repos/sindresorhus/got/git/commits{/sha}","comments_url":"https://api.github.com/repos/sindresorhus/got/comments{/number}","issue_comment_url":"https://api.github.com/repos/sindresorhus/got/issues/comments{/number}","contents_url":"https://api.github.com/repos/sindresorhus/got/contents/{+path}","compare_url":"https://api.github.com/repos/sindresorhus/got/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sindresorhus/got/merges","archive_url":"https://api.github.com/repos/sindresorhus/got/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sindresorhus/got/downloads","issues_url":"https://api.github.com/repos/sindresorhus/got/issues{/number}","pulls_url":"https://api.github.com/repos/sindresorhus/got/pulls{/number}","milestones_url":"https://api.github.com/repos/sindresorhus/got/milestones{/number}","notifications_url":"https://api.github.com/repos/sindresorhus/got/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sindresorhus/got/labels{/name}","releases_url":"https://api.github.com/repos/sindresorhus/got/releases{/id}","deployments_url":"https://api.github.com/repos/sindresorhus/got/deployments","created_at":"2014-03-27T22:40:49Z","updated_at":"2016-02-25T09:32:54Z","pushed_at":"2016-02-25T09:32:03Z","git_url":"git://github.com/sindresorhus/got.git","ssh_url":"git@github.com:sindresorhus/got.git","clone_url":"https://github.com/sindresorhus/got.git","svn_url":"https://github.com/sindresorhus/got","homepage":"","size":659,"stargazers_count":872,"watchers_count":872,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":9,"forks":36,"open_issues":9,"watchers":872,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/got/pulls/178"},"html":{"href":"https://github.com/sindresorhus/got/pull/178"},"issue":{"href":"https://api.github.com/repos/sindresorhus/got/issues/178"},"comments":{"href":"https://api.github.com/repos/sindresorhus/got/issues/178/comments"},"review_comments":{"href":"https://api.github.com/repos/sindresorhus/got/pulls/178/comments"},"review_comment":{"href":"https://api.github.com/repos/sindresorhus/got/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sindresorhus/got/pulls/178/commits"},"statuses":{"href":"https://api.github.com/repos/sindresorhus/got/statuses/392a0ddabfd008c7253fa9c79aa910e600c78e93"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":8,"additions":297,"deletions":1,"changed_files":5}}