{"action":"closed","number":184,"pull_request":{"url":"https://api.github.com/repos/jgallagher/rusqlite/pulls/184","id":88474092,"html_url":"https://github.com/jgallagher/rusqlite/pull/184","diff_url":"https://github.com/jgallagher/rusqlite/pull/184.diff","patch_url":"https://github.com/jgallagher/rusqlite/pull/184.patch","issue_url":"https://api.github.com/repos/jgallagher/rusqlite/issues/184","number":184,"state":"closed","locked":false,"title":"change query_row* fns to take Row by reference instead of moving","user":{"login":"pfernie","id":1976913,"avatar_url":"https://avatars.githubusercontent.com/u/1976913?v=3","gravatar_id":"","url":"https://api.github.com/users/pfernie","html_url":"https://github.com/pfernie","followers_url":"https://api.github.com/users/pfernie/followers","following_url":"https://api.github.com/users/pfernie/following{/other_user}","gists_url":"https://api.github.com/users/pfernie/gists{/gist_id}","starred_url":"https://api.github.com/users/pfernie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfernie/subscriptions","organizations_url":"https://api.github.com/users/pfernie/orgs","repos_url":"https://api.github.com/users/pfernie/repos","events_url":"https://api.github.com/users/pfernie/events{/privacy}","received_events_url":"https://api.github.com/users/pfernie/received_events","type":"User","site_admin":false},"body":"This updates `query_row`, `query_row_and_then`, and `query_row_safe` (deprecated) to taking `Row` references instead of moving, bringing them in line with `query_and_then` and related fns.\n\nThis is a breaking change for uses of free functions, although should continue to work for most cases using closures:\n\n```\nstmt.query_row_and_then(&[], |r| r.get_checked(0)); // should continue to work\n```\n\nThe difference between `query_row_and_then` and `query_and_then` is unergonomic esp. when using free functions as builder methods:\n\n```\nfn make_foo(r: Row) -> Foo { ... }\nlet foo = single_foo_stmt.query_row_and_then(&[], make_foo);\nlet foos = multi_foo_stmt.query_and_then(&[], make_foo); // make_foo has wrong signature\n\n// requires duplicated impl:\nfn make_foo_ref(r: &Row) -> Foo { ... }\nlet foos = multi_foo_stmt.query_and_then(&[], make_foo_ref);\n```\n\nAlternatively, these could be implemented as new fns and the old marked as deprecated, but IMO this is more API-consistent and the fix for breakage is straightforward.\n","created_at":"2016-10-07T17:05:46Z","updated_at":"2016-12-31T04:54:50Z","closed_at":"2016-12-31T04:54:50Z","merged_at":"2016-12-31T04:54:50Z","merge_commit_sha":"ece7c041e85a215cfb9c7d15884d11dbf036c087","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jgallagher/rusqlite/pulls/184/commits","review_comments_url":"https://api.github.com/repos/jgallagher/rusqlite/pulls/184/comments","review_comment_url":"https://api.github.com/repos/jgallagher/rusqlite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jgallagher/rusqlite/issues/184/comments","statuses_url":"https://api.github.com/repos/jgallagher/rusqlite/statuses/ece7c041e85a215cfb9c7d15884d11dbf036c087","head":{"label":"pfernie:query_row","ref":"query_row","sha":"ece7c041e85a215cfb9c7d15884d11dbf036c087","user":{"login":"pfernie","id":1976913,"avatar_url":"https://avatars.githubusercontent.com/u/1976913?v=3","gravatar_id":"","url":"https://api.github.com/users/pfernie","html_url":"https://github.com/pfernie","followers_url":"https://api.github.com/users/pfernie/followers","following_url":"https://api.github.com/users/pfernie/following{/other_user}","gists_url":"https://api.github.com/users/pfernie/gists{/gist_id}","starred_url":"https://api.github.com/users/pfernie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfernie/subscriptions","organizations_url":"https://api.github.com/users/pfernie/orgs","repos_url":"https://api.github.com/users/pfernie/repos","events_url":"https://api.github.com/users/pfernie/events{/privacy}","received_events_url":"https://api.github.com/users/pfernie/received_events","type":"User","site_admin":false},"repo":{"id":41492391,"name":"rusqlite","full_name":"pfernie/rusqlite","owner":{"login":"pfernie","id":1976913,"avatar_url":"https://avatars.githubusercontent.com/u/1976913?v=3","gravatar_id":"","url":"https://api.github.com/users/pfernie","html_url":"https://github.com/pfernie","followers_url":"https://api.github.com/users/pfernie/followers","following_url":"https://api.github.com/users/pfernie/following{/other_user}","gists_url":"https://api.github.com/users/pfernie/gists{/gist_id}","starred_url":"https://api.github.com/users/pfernie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfernie/subscriptions","organizations_url":"https://api.github.com/users/pfernie/orgs","repos_url":"https://api.github.com/users/pfernie/repos","events_url":"https://api.github.com/users/pfernie/events{/privacy}","received_events_url":"https://api.github.com/users/pfernie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pfernie/rusqlite","description":"Ergonomic bindings to SQLite for Rust","fork":true,"url":"https://api.github.com/repos/pfernie/rusqlite","forks_url":"https://api.github.com/repos/pfernie/rusqlite/forks","keys_url":"https://api.github.com/repos/pfernie/rusqlite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfernie/rusqlite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfernie/rusqlite/teams","hooks_url":"https://api.github.com/repos/pfernie/rusqlite/hooks","issue_events_url":"https://api.github.com/repos/pfernie/rusqlite/issues/events{/number}","events_url":"https://api.github.com/repos/pfernie/rusqlite/events","assignees_url":"https://api.github.com/repos/pfernie/rusqlite/assignees{/user}","branches_url":"https://api.github.com/repos/pfernie/rusqlite/branches{/branch}","tags_url":"https://api.github.com/repos/pfernie/rusqlite/tags","blobs_url":"https://api.github.com/repos/pfernie/rusqlite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfernie/rusqlite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfernie/rusqlite/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfernie/rusqlite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfernie/rusqlite/statuses/{sha}","languages_url":"https://api.github.com/repos/pfernie/rusqlite/languages","stargazers_url":"https://api.github.com/repos/pfernie/rusqlite/stargazers","contributors_url":"https://api.github.com/repos/pfernie/rusqlite/contributors","subscribers_url":"https://api.github.com/repos/pfernie/rusqlite/subscribers","subscription_url":"https://api.github.com/repos/pfernie/rusqlite/subscription","commits_url":"https://api.github.com/repos/pfernie/rusqlite/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfernie/rusqlite/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfernie/rusqlite/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfernie/rusqlite/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfernie/rusqlite/contents/{+path}","compare_url":"https://api.github.com/repos/pfernie/rusqlite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfernie/rusqlite/merges","archive_url":"https://api.github.com/repos/pfernie/rusqlite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfernie/rusqlite/downloads","issues_url":"https://api.github.com/repos/pfernie/rusqlite/issues{/number}","pulls_url":"https://api.github.com/repos/pfernie/rusqlite/pulls{/number}","milestones_url":"https://api.github.com/repos/pfernie/rusqlite/milestones{/number}","notifications_url":"https://api.github.com/repos/pfernie/rusqlite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfernie/rusqlite/labels{/name}","releases_url":"https://api.github.com/repos/pfernie/rusqlite/releases{/id}","deployments_url":"https://api.github.com/repos/pfernie/rusqlite/deployments","created_at":"2015-08-27T14:43:41Z","updated_at":"2015-08-27T14:43:41Z","pushed_at":"2016-10-07T16:44:37Z","git_url":"git://github.com/pfernie/rusqlite.git","ssh_url":"git@github.com:pfernie/rusqlite.git","clone_url":"https://github.com/pfernie/rusqlite.git","svn_url":"https://github.com/pfernie/rusqlite","homepage":"","size":1185,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jgallagher:master","ref":"master","sha":"bf8c495b69859eea85a2e0b161b52dfe775a0641","user":{"login":"jgallagher","id":1435635,"avatar_url":"https://avatars.githubusercontent.com/u/1435635?v=3","gravatar_id":"","url":"https://api.github.com/users/jgallagher","html_url":"https://github.com/jgallagher","followers_url":"https://api.github.com/users/jgallagher/followers","following_url":"https://api.github.com/users/jgallagher/following{/other_user}","gists_url":"https://api.github.com/users/jgallagher/gists{/gist_id}","starred_url":"https://api.github.com/users/jgallagher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgallagher/subscriptions","organizations_url":"https://api.github.com/users/jgallagher/orgs","repos_url":"https://api.github.com/users/jgallagher/repos","events_url":"https://api.github.com/users/jgallagher/events{/privacy}","received_events_url":"https://api.github.com/users/jgallagher/received_events","type":"User","site_admin":false},"repo":{"id":26177824,"name":"rusqlite","full_name":"jgallagher/rusqlite","owner":{"login":"jgallagher","id":1435635,"avatar_url":"https://avatars.githubusercontent.com/u/1435635?v=3","gravatar_id":"","url":"https://api.github.com/users/jgallagher","html_url":"https://github.com/jgallagher","followers_url":"https://api.github.com/users/jgallagher/followers","following_url":"https://api.github.com/users/jgallagher/following{/other_user}","gists_url":"https://api.github.com/users/jgallagher/gists{/gist_id}","starred_url":"https://api.github.com/users/jgallagher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgallagher/subscriptions","organizations_url":"https://api.github.com/users/jgallagher/orgs","repos_url":"https://api.github.com/users/jgallagher/repos","events_url":"https://api.github.com/users/jgallagher/events{/privacy}","received_events_url":"https://api.github.com/users/jgallagher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgallagher/rusqlite","description":"Ergonomic bindings to SQLite for Rust","fork":false,"url":"https://api.github.com/repos/jgallagher/rusqlite","forks_url":"https://api.github.com/repos/jgallagher/rusqlite/forks","keys_url":"https://api.github.com/repos/jgallagher/rusqlite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgallagher/rusqlite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgallagher/rusqlite/teams","hooks_url":"https://api.github.com/repos/jgallagher/rusqlite/hooks","issue_events_url":"https://api.github.com/repos/jgallagher/rusqlite/issues/events{/number}","events_url":"https://api.github.com/repos/jgallagher/rusqlite/events","assignees_url":"https://api.github.com/repos/jgallagher/rusqlite/assignees{/user}","branches_url":"https://api.github.com/repos/jgallagher/rusqlite/branches{/branch}","tags_url":"https://api.github.com/repos/jgallagher/rusqlite/tags","blobs_url":"https://api.github.com/repos/jgallagher/rusqlite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgallagher/rusqlite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgallagher/rusqlite/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgallagher/rusqlite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgallagher/rusqlite/statuses/{sha}","languages_url":"https://api.github.com/repos/jgallagher/rusqlite/languages","stargazers_url":"https://api.github.com/repos/jgallagher/rusqlite/stargazers","contributors_url":"https://api.github.com/repos/jgallagher/rusqlite/contributors","subscribers_url":"https://api.github.com/repos/jgallagher/rusqlite/subscribers","subscription_url":"https://api.github.com/repos/jgallagher/rusqlite/subscription","commits_url":"https://api.github.com/repos/jgallagher/rusqlite/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgallagher/rusqlite/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgallagher/rusqlite/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgallagher/rusqlite/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgallagher/rusqlite/contents/{+path}","compare_url":"https://api.github.com/repos/jgallagher/rusqlite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgallagher/rusqlite/merges","archive_url":"https://api.github.com/repos/jgallagher/rusqlite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgallagher/rusqlite/downloads","issues_url":"https://api.github.com/repos/jgallagher/rusqlite/issues{/number}","pulls_url":"https://api.github.com/repos/jgallagher/rusqlite/pulls{/number}","milestones_url":"https://api.github.com/repos/jgallagher/rusqlite/milestones{/number}","notifications_url":"https://api.github.com/repos/jgallagher/rusqlite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgallagher/rusqlite/labels{/name}","releases_url":"https://api.github.com/repos/jgallagher/rusqlite/releases{/id}","deployments_url":"https://api.github.com/repos/jgallagher/rusqlite/deployments","created_at":"2014-11-04T16:32:36Z","updated_at":"2016-12-26T20:52:19Z","pushed_at":"2016-12-31T04:54:49Z","git_url":"git://github.com/jgallagher/rusqlite.git","ssh_url":"git@github.com:jgallagher/rusqlite.git","clone_url":"https://github.com/jgallagher/rusqlite.git","svn_url":"https://github.com/jgallagher/rusqlite","homepage":"","size":2160,"stargazers_count":128,"watchers_count":128,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"open_issues_count":19,"forks":26,"open_issues":19,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jgallagher/rusqlite/pulls/184"},"html":{"href":"https://github.com/jgallagher/rusqlite/pull/184"},"issue":{"href":"https://api.github.com/repos/jgallagher/rusqlite/issues/184"},"comments":{"href":"https://api.github.com/repos/jgallagher/rusqlite/issues/184/comments"},"review_comments":{"href":"https://api.github.com/repos/jgallagher/rusqlite/pulls/184/comments"},"review_comment":{"href":"https://api.github.com/repos/jgallagher/rusqlite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jgallagher/rusqlite/pulls/184/commits"},"statuses":{"href":"https://api.github.com/repos/jgallagher/rusqlite/statuses/ece7c041e85a215cfb9c7d15884d11dbf036c087"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jgallagher","id":1435635,"avatar_url":"https://avatars.githubusercontent.com/u/1435635?v=3","gravatar_id":"","url":"https://api.github.com/users/jgallagher","html_url":"https://github.com/jgallagher","followers_url":"https://api.github.com/users/jgallagher/followers","following_url":"https://api.github.com/users/jgallagher/following{/other_user}","gists_url":"https://api.github.com/users/jgallagher/gists{/gist_id}","starred_url":"https://api.github.com/users/jgallagher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgallagher/subscriptions","organizations_url":"https://api.github.com/users/jgallagher/orgs","repos_url":"https://api.github.com/users/jgallagher/repos","events_url":"https://api.github.com/users/jgallagher/events{/privacy}","received_events_url":"https://api.github.com/users/jgallagher/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"jgallagher"}}