{"action":"created","comment":{"url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments/74953357","id":74953357,"diff_hunk":"@@ -98,7 +99,12 @@ def file_config(filename=None):\n \n     logger.debug('file_config() will try to open `{}`'.format(filename))\n     with open(filename) as f:\n-        config = json.load(f)\n+        try:\n+            config = json.load(f)\n+        except ValueError as err:\n+            raise exceptions.ConfigurationError(\n+                'Failed to load configuration from `{}`, reason: {}'.format(filename, err)","path":"bigchaindb/config_utils.py","position":17,"original_position":17,"commit_id":"1b33a43b77638a27e68cbb5c2782adb1b9126f52","original_commit_id":"1b33a43b77638a27e68cbb5c2782adb1b9126f52","user":{"login":"vrde","id":134680,"avatar_url":"https://avatars.githubusercontent.com/u/134680?v=3","gravatar_id":"","url":"https://api.github.com/users/vrde","html_url":"https://github.com/vrde","followers_url":"https://api.github.com/users/vrde/followers","following_url":"https://api.github.com/users/vrde/following{/other_user}","gists_url":"https://api.github.com/users/vrde/gists{/gist_id}","starred_url":"https://api.github.com/users/vrde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrde/subscriptions","organizations_url":"https://api.github.com/users/vrde/orgs","repos_url":"https://api.github.com/users/vrde/repos","events_url":"https://api.github.com/users/vrde/events{/privacy}","received_events_url":"https://api.github.com/users/vrde/received_events","type":"User","site_admin":false},"body":"I tried your branch locally, and the error is like:\r\n```\r\nFailed to load configuration from `/home/vrde/.bigchaindb`, reason: Expecting value: line 1 column 59 (char 58)\r\n```\r\n\r\nA clearer wording would be:\r\n```\r\nFailed to parse the JSON configuration from `{}`. {}\r\n```\r\nin this way we highlight that the problem is on **parsing** a **JSON** file.","created_at":"2016-08-16T15:04:15Z","updated_at":"2016-08-16T15:04:15Z","html_url":"https://github.com/bigchaindb/bigchaindb/pull/531#discussion_r74953357","pull_request_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/531","_links":{"self":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments/74953357"},"html":{"href":"https://github.com/bigchaindb/bigchaindb/pull/531#discussion_r74953357"},"pull_request":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/531"}}},"pull_request":{"url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/531","id":80438940,"html_url":"https://github.com/bigchaindb/bigchaindb/pull/531","diff_url":"https://github.com/bigchaindb/bigchaindb/pull/531.diff","patch_url":"https://github.com/bigchaindb/bigchaindb/pull/531.patch","issue_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/531","number":531,"state":"open","locked":false,"title":"Bug/419/config syntax error handling","user":{"login":"d01phin","id":1186766,"avatar_url":"https://avatars.githubusercontent.com/u/1186766?v=3","gravatar_id":"","url":"https://api.github.com/users/d01phin","html_url":"https://github.com/d01phin","followers_url":"https://api.github.com/users/d01phin/followers","following_url":"https://api.github.com/users/d01phin/following{/other_user}","gists_url":"https://api.github.com/users/d01phin/gists{/gist_id}","starred_url":"https://api.github.com/users/d01phin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d01phin/subscriptions","organizations_url":"https://api.github.com/users/d01phin/orgs","repos_url":"https://api.github.com/users/d01phin/repos","events_url":"https://api.github.com/users/d01phin/events{/privacy}","received_events_url":"https://api.github.com/users/d01phin/received_events","type":"User","site_admin":false},"body":"This is a WIP for config file error handling, addressing the issue #419 ","created_at":"2016-08-08T11:59:14Z","updated_at":"2016-08-16T15:04:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"253106e1558cc35effae2249918cd63fe5bd5392","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/531/commits","review_comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/531/comments","review_comment_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/531/comments","statuses_url":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/1b33a43b77638a27e68cbb5c2782adb1b9126f52","head":{"label":"d01phin:bug/419/config-syntax-error-pretty-message","ref":"bug/419/config-syntax-error-pretty-message","sha":"1b33a43b77638a27e68cbb5c2782adb1b9126f52","user":{"login":"d01phin","id":1186766,"avatar_url":"https://avatars.githubusercontent.com/u/1186766?v=3","gravatar_id":"","url":"https://api.github.com/users/d01phin","html_url":"https://github.com/d01phin","followers_url":"https://api.github.com/users/d01phin/followers","following_url":"https://api.github.com/users/d01phin/following{/other_user}","gists_url":"https://api.github.com/users/d01phin/gists{/gist_id}","starred_url":"https://api.github.com/users/d01phin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d01phin/subscriptions","organizations_url":"https://api.github.com/users/d01phin/orgs","repos_url":"https://api.github.com/users/d01phin/repos","events_url":"https://api.github.com/users/d01phin/events{/privacy}","received_events_url":"https://api.github.com/users/d01phin/received_events","type":"User","site_admin":false},"repo":{"id":64954217,"name":"bigchaindb","full_name":"d01phin/bigchaindb","owner":{"login":"d01phin","id":1186766,"avatar_url":"https://avatars.githubusercontent.com/u/1186766?v=3","gravatar_id":"","url":"https://api.github.com/users/d01phin","html_url":"https://github.com/d01phin","followers_url":"https://api.github.com/users/d01phin/followers","following_url":"https://api.github.com/users/d01phin/following{/other_user}","gists_url":"https://api.github.com/users/d01phin/gists{/gist_id}","starred_url":"https://api.github.com/users/d01phin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d01phin/subscriptions","organizations_url":"https://api.github.com/users/d01phin/orgs","repos_url":"https://api.github.com/users/d01phin/repos","events_url":"https://api.github.com/users/d01phin/events{/privacy}","received_events_url":"https://api.github.com/users/d01phin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d01phin/bigchaindb","description":"A scalable blockchain database","fork":true,"url":"https://api.github.com/repos/d01phin/bigchaindb","forks_url":"https://api.github.com/repos/d01phin/bigchaindb/forks","keys_url":"https://api.github.com/repos/d01phin/bigchaindb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d01phin/bigchaindb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d01phin/bigchaindb/teams","hooks_url":"https://api.github.com/repos/d01phin/bigchaindb/hooks","issue_events_url":"https://api.github.com/repos/d01phin/bigchaindb/issues/events{/number}","events_url":"https://api.github.com/repos/d01phin/bigchaindb/events","assignees_url":"https://api.github.com/repos/d01phin/bigchaindb/assignees{/user}","branches_url":"https://api.github.com/repos/d01phin/bigchaindb/branches{/branch}","tags_url":"https://api.github.com/repos/d01phin/bigchaindb/tags","blobs_url":"https://api.github.com/repos/d01phin/bigchaindb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d01phin/bigchaindb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d01phin/bigchaindb/git/refs{/sha}","trees_url":"https://api.github.com/repos/d01phin/bigchaindb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d01phin/bigchaindb/statuses/{sha}","languages_url":"https://api.github.com/repos/d01phin/bigchaindb/languages","stargazers_url":"https://api.github.com/repos/d01phin/bigchaindb/stargazers","contributors_url":"https://api.github.com/repos/d01phin/bigchaindb/contributors","subscribers_url":"https://api.github.com/repos/d01phin/bigchaindb/subscribers","subscription_url":"https://api.github.com/repos/d01phin/bigchaindb/subscription","commits_url":"https://api.github.com/repos/d01phin/bigchaindb/commits{/sha}","git_commits_url":"https://api.github.com/repos/d01phin/bigchaindb/git/commits{/sha}","comments_url":"https://api.github.com/repos/d01phin/bigchaindb/comments{/number}","issue_comment_url":"https://api.github.com/repos/d01phin/bigchaindb/issues/comments{/number}","contents_url":"https://api.github.com/repos/d01phin/bigchaindb/contents/{+path}","compare_url":"https://api.github.com/repos/d01phin/bigchaindb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d01phin/bigchaindb/merges","archive_url":"https://api.github.com/repos/d01phin/bigchaindb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d01phin/bigchaindb/downloads","issues_url":"https://api.github.com/repos/d01phin/bigchaindb/issues{/number}","pulls_url":"https://api.github.com/repos/d01phin/bigchaindb/pulls{/number}","milestones_url":"https://api.github.com/repos/d01phin/bigchaindb/milestones{/number}","notifications_url":"https://api.github.com/repos/d01phin/bigchaindb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d01phin/bigchaindb/labels{/name}","releases_url":"https://api.github.com/repos/d01phin/bigchaindb/releases{/id}","deployments_url":"https://api.github.com/repos/d01phin/bigchaindb/deployments","created_at":"2016-08-04T17:28:55Z","updated_at":"2016-08-04T17:28:56Z","pushed_at":"2016-08-15T15:59:56Z","git_url":"git://github.com/d01phin/bigchaindb.git","ssh_url":"git@github.com:d01phin/bigchaindb.git","clone_url":"https://github.com/d01phin/bigchaindb.git","svn_url":"https://github.com/d01phin/bigchaindb","homepage":"https://www.bigchaindb.com/","size":3894,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bigchaindb:master","ref":"master","sha":"630906b4cdce39b45a4a32e2726f19ef9f84041d","user":{"login":"bigchaindb","id":17097586,"avatar_url":"https://avatars.githubusercontent.com/u/17097586?v=3","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"repo":{"id":51290852,"name":"bigchaindb","full_name":"bigchaindb/bigchaindb","owner":{"login":"bigchaindb","id":17097586,"avatar_url":"https://avatars.githubusercontent.com/u/17097586?v=3","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigchaindb/bigchaindb","description":"A scalable blockchain database","fork":false,"url":"https://api.github.com/repos/bigchaindb/bigchaindb","forks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/forks","keys_url":"https://api.github.com/repos/bigchaindb/bigchaindb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigchaindb/bigchaindb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigchaindb/bigchaindb/teams","hooks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/hooks","issue_events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/events{/number}","events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/events","assignees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/assignees{/user}","branches_url":"https://api.github.com/repos/bigchaindb/bigchaindb/branches{/branch}","tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/tags","blobs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/{sha}","languages_url":"https://api.github.com/repos/bigchaindb/bigchaindb/languages","stargazers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/stargazers","contributors_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contributors","subscribers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscribers","subscription_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscription","commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contents/{+path}","compare_url":"https://api.github.com/repos/bigchaindb/bigchaindb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigchaindb/bigchaindb/merges","archive_url":"https://api.github.com/repos/bigchaindb/bigchaindb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigchaindb/bigchaindb/downloads","issues_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues{/number}","pulls_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls{/number}","milestones_url":"https://api.github.com/repos/bigchaindb/bigchaindb/milestones{/number}","notifications_url":"https://api.github.com/repos/bigchaindb/bigchaindb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigchaindb/bigchaindb/labels{/name}","releases_url":"https://api.github.com/repos/bigchaindb/bigchaindb/releases{/id}","deployments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/deployments","created_at":"2016-02-08T10:12:58Z","updated_at":"2016-08-15T11:58:05Z","pushed_at":"2016-08-15T22:42:48Z","git_url":"git://github.com/bigchaindb/bigchaindb.git","ssh_url":"git@github.com:bigchaindb/bigchaindb.git","clone_url":"https://github.com/bigchaindb/bigchaindb.git","svn_url":"https://github.com/bigchaindb/bigchaindb","homepage":"https://www.bigchaindb.com/","size":4098,"stargazers_count":622,"watchers_count":622,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"open_issues_count":140,"forks":103,"open_issues":140,"watchers":622,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/531"},"html":{"href":"https://github.com/bigchaindb/bigchaindb/pull/531"},"issue":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/531"},"comments":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/531/comments"},"review_comments":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/531/comments"},"review_comment":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/531/commits"},"statuses":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/1b33a43b77638a27e68cbb5c2782adb1b9126f52"}}}}
{"actor":{"display_login":"vrde"}}