{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/76731306","id":76731306,"diff_hunk":"@@ -451,6 +451,7 @@ type VolumeCreateRequest struct {\n type NetworkResource struct {\n \tName       string                      // Name is the requested name of the network\n \tID         string                      `json:\"Id\"` // ID uniquely identifies a network on a single machine\n+\tCreated    string                      // String representation of the creation timestamp","path":"vendor/src/github.com/docker/engine-api/types/types.go","position":4,"original_position":4,"commit_id":"5eea3887873b5612287848b43668f4500d579ac6","original_commit_id":"5eea3887873b5612287848b43668f4500d579ac6","user":{"login":"AkihiroSuda","id":9248427,"avatar_url":"https://avatars.githubusercontent.com/u/9248427?v=3","gravatar_id":"","url":"https://api.github.com/users/AkihiroSuda","html_url":"https://github.com/AkihiroSuda","followers_url":"https://api.github.com/users/AkihiroSuda/followers","following_url":"https://api.github.com/users/AkihiroSuda/following{/other_user}","gists_url":"https://api.github.com/users/AkihiroSuda/gists{/gist_id}","starred_url":"https://api.github.com/users/AkihiroSuda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkihiroSuda/subscriptions","organizations_url":"https://api.github.com/users/AkihiroSuda/orgs","repos_url":"https://api.github.com/users/AkihiroSuda/repos","events_url":"https://api.github.com/users/AkihiroSuda/events{/privacy}","received_events_url":"https://api.github.com/users/AkihiroSuda/received_events","type":"User","site_admin":false},"body":"Note:\r\n- `Container.Created` is `int64`\r\n- `ContainerJSONBase.Created` is `string`\r\n- `Image.Created` is `int64`\r\n- `ImageHistory.Created` is `int64`\r\n- `ImageInspect.Created` is `string`\r\n- `swarm/Meta.CreatedAt` (not `Create`!) is `time.Time`\r\n\r\nhttps://godoc.org/github.com/docker/engine-api/types\r\nhttps://godoc.org/github.com/docker/engine-api/types/swarm","created_at":"2016-08-30T05:09:55Z","updated_at":"2016-08-30T05:09:55Z","html_url":"https://github.com/docker/docker/pull/26130#discussion_r76731306","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/26130","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/76731306"},"html":{"href":"https://github.com/docker/docker/pull/26130#discussion_r76731306"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/26130"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/26130","id":83208854,"html_url":"https://github.com/docker/docker/pull/26130","diff_url":"https://github.com/docker/docker/pull/26130.diff","patch_url":"https://github.com/docker/docker/pull/26130.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/26130","number":26130,"state":"open","locked":false,"title":"add creation timestamp to `docker network inspect`","user":{"login":"AkihiroSuda","id":9248427,"avatar_url":"https://avatars.githubusercontent.com/u/9248427?v=3","gravatar_id":"","url":"https://api.github.com/users/AkihiroSuda","html_url":"https://github.com/AkihiroSuda","followers_url":"https://api.github.com/users/AkihiroSuda/followers","following_url":"https://api.github.com/users/AkihiroSuda/following{/other_user}","gists_url":"https://api.github.com/users/AkihiroSuda/gists{/gist_id}","starred_url":"https://api.github.com/users/AkihiroSuda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkihiroSuda/subscriptions","organizations_url":"https://api.github.com/users/AkihiroSuda/orgs","repos_url":"https://api.github.com/users/AkihiroSuda/repos","events_url":"https://api.github.com/users/AkihiroSuda/events{/privacy}","received_events_url":"https://api.github.com/users/AkihiroSuda/received_events","type":"User","site_admin":false},"body":"**- What I did**\r\nAdd creation timestamp to `docker network inspect`\r\n\r\n**- How I did it**\r\n- Add a new field `Created` to `engine-api/types.NetworkResource`\r\n- Add a new method `Created()` to `libnetwork.NetworkInfo`\r\n\r\nI'll create corresponding PRs to `engine-api` and `libnetwork` after getting lgtms.\r\n\r\n**- How to verify it**\r\n```\r\n$ docker network create foo\r\n```\r\nThen apply this PR\r\n```\r\n$ docker network inspect foo | jq '.[0].Created'\r\n\"0001-01-01T00:00:00Z\"\r\n$ docker network create bar\r\n$ docker network inspect bar | jq '.[0].Created'\r\n\"2016-08-30T04:56:13.391974977Z\"\r\n```\r\n\r\nIt should also work with embedded networks (e.g. \"bridge\", \"host\", ..)\r\n\r\n**- Description for the changelog**\r\nadd creation timestamp to `docker network inspect`\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\nhttps://www.whoi.edu/cms/images/mediarelations/Adelie_750_342264.jpg\r\n\r\nSigned-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>","created_at":"2016-08-30T05:04:03Z","updated_at":"2016-08-30T05:09:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd8417f2a71a84cb6a02d5f72b2723740754c947","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/26130/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/26130/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/26130/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/5eea3887873b5612287848b43668f4500d579ac6","head":{"label":"AkihiroSuda:networkcreationtime","ref":"networkcreationtime","sha":"5eea3887873b5612287848b43668f4500d579ac6","user":{"login":"AkihiroSuda","id":9248427,"avatar_url":"https://avatars.githubusercontent.com/u/9248427?v=3","gravatar_id":"","url":"https://api.github.com/users/AkihiroSuda","html_url":"https://github.com/AkihiroSuda","followers_url":"https://api.github.com/users/AkihiroSuda/followers","following_url":"https://api.github.com/users/AkihiroSuda/following{/other_user}","gists_url":"https://api.github.com/users/AkihiroSuda/gists{/gist_id}","starred_url":"https://api.github.com/users/AkihiroSuda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkihiroSuda/subscriptions","organizations_url":"https://api.github.com/users/AkihiroSuda/orgs","repos_url":"https://api.github.com/users/AkihiroSuda/repos","events_url":"https://api.github.com/users/AkihiroSuda/events{/privacy}","received_events_url":"https://api.github.com/users/AkihiroSuda/received_events","type":"User","site_admin":false},"repo":{"id":51440731,"name":"docker","full_name":"AkihiroSuda/docker","owner":{"login":"AkihiroSuda","id":9248427,"avatar_url":"https://avatars.githubusercontent.com/u/9248427?v=3","gravatar_id":"","url":"https://api.github.com/users/AkihiroSuda","html_url":"https://github.com/AkihiroSuda","followers_url":"https://api.github.com/users/AkihiroSuda/followers","following_url":"https://api.github.com/users/AkihiroSuda/following{/other_user}","gists_url":"https://api.github.com/users/AkihiroSuda/gists{/gist_id}","starred_url":"https://api.github.com/users/AkihiroSuda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkihiroSuda/subscriptions","organizations_url":"https://api.github.com/users/AkihiroSuda/orgs","repos_url":"https://api.github.com/users/AkihiroSuda/repos","events_url":"https://api.github.com/users/AkihiroSuda/events{/privacy}","received_events_url":"https://api.github.com/users/AkihiroSuda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AkihiroSuda/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/AkihiroSuda/docker","forks_url":"https://api.github.com/repos/AkihiroSuda/docker/forks","keys_url":"https://api.github.com/repos/AkihiroSuda/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AkihiroSuda/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AkihiroSuda/docker/teams","hooks_url":"https://api.github.com/repos/AkihiroSuda/docker/hooks","issue_events_url":"https://api.github.com/repos/AkihiroSuda/docker/issues/events{/number}","events_url":"https://api.github.com/repos/AkihiroSuda/docker/events","assignees_url":"https://api.github.com/repos/AkihiroSuda/docker/assignees{/user}","branches_url":"https://api.github.com/repos/AkihiroSuda/docker/branches{/branch}","tags_url":"https://api.github.com/repos/AkihiroSuda/docker/tags","blobs_url":"https://api.github.com/repos/AkihiroSuda/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AkihiroSuda/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AkihiroSuda/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/AkihiroSuda/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AkihiroSuda/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/AkihiroSuda/docker/languages","stargazers_url":"https://api.github.com/repos/AkihiroSuda/docker/stargazers","contributors_url":"https://api.github.com/repos/AkihiroSuda/docker/contributors","subscribers_url":"https://api.github.com/repos/AkihiroSuda/docker/subscribers","subscription_url":"https://api.github.com/repos/AkihiroSuda/docker/subscription","commits_url":"https://api.github.com/repos/AkihiroSuda/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/AkihiroSuda/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/AkihiroSuda/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/AkihiroSuda/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/AkihiroSuda/docker/contents/{+path}","compare_url":"https://api.github.com/repos/AkihiroSuda/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AkihiroSuda/docker/merges","archive_url":"https://api.github.com/repos/AkihiroSuda/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AkihiroSuda/docker/downloads","issues_url":"https://api.github.com/repos/AkihiroSuda/docker/issues{/number}","pulls_url":"https://api.github.com/repos/AkihiroSuda/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/AkihiroSuda/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/AkihiroSuda/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AkihiroSuda/docker/labels{/name}","releases_url":"https://api.github.com/repos/AkihiroSuda/docker/releases{/id}","deployments_url":"https://api.github.com/repos/AkihiroSuda/docker/deployments","created_at":"2016-02-10T12:50:20Z","updated_at":"2016-02-10T12:50:30Z","pushed_at":"2016-08-30T04:53:37Z","git_url":"git://github.com/AkihiroSuda/docker.git","ssh_url":"git@github.com:AkihiroSuda/docker.git","clone_url":"https://github.com/AkihiroSuda/docker.git","svn_url":"https://github.com/AkihiroSuda/docker","homepage":"http://www.docker.com","size":98864,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"13094ffef91e52f1149f90718ae55833eee21b2d","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-08-30T04:55:11Z","pushed_at":"2016-08-30T05:04:03Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":206500,"stargazers_count":34462,"watchers_count":34462,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10102,"mirror_url":null,"open_issues_count":2185,"forks":10102,"open_issues":2185,"watchers":34462,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/26130"},"html":{"href":"https://github.com/docker/docker/pull/26130"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/26130"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/26130/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/26130/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/26130/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/5eea3887873b5612287848b43668f4500d579ac6"}}}}
{"actor":{"display_login":"AkihiroSuda"}}