{"action":"created","comment":{"url":"https://api.github.com/repos/SirCmpwn/sway/pulls/comments/71094126","id":71094126,"diff_hunk":"@@ -1009,19 +1009,35 @@ static struct cmd_results *cmd_move(int argc, char **argv) {\n \tif ((error = checkarg(argc, \"move\", EXPECTED_AT_LEAST, 1))) {\n \t\treturn error;\n \t}\n-\tconst char* expected_syntax = \"Expected 'move <left|right|up|down>' or \"\n+\tconst char* expected_syntax = \"Expected 'move <left|right|up|down> [<px> px]' or \"\n \t\t\"'move <container|window> to workspace <name>' or \"\n \t\t\"'move <container|window|workspace> to output <name|direction>'\";\n \tswayc_t *view = get_focused_container(&root_container);\n \n \tif (strcasecmp(argv[0], \"left\") == 0) {\n-\t\tmove_container(view, MOVE_LEFT);\n+\t\tif (argc == 3 && !strcasecmp(argv[2], \"px\")) {","path":"sway/commands.c","position":12,"original_position":12,"commit_id":"eb231a9e1ca19d486f79047c88d917626ff0b062","original_commit_id":"eb231a9e1ca19d486f79047c88d917626ff0b062","user":{"login":"SirCmpwn","id":1310872,"avatar_url":"https://avatars.githubusercontent.com/u/1310872?v=3","gravatar_id":"","url":"https://api.github.com/users/SirCmpwn","html_url":"https://github.com/SirCmpwn","followers_url":"https://api.github.com/users/SirCmpwn/followers","following_url":"https://api.github.com/users/SirCmpwn/following{/other_user}","gists_url":"https://api.github.com/users/SirCmpwn/gists{/gist_id}","starred_url":"https://api.github.com/users/SirCmpwn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirCmpwn/subscriptions","organizations_url":"https://api.github.com/users/SirCmpwn/orgs","repos_url":"https://api.github.com/users/SirCmpwn/repos","events_url":"https://api.github.com/users/SirCmpwn/events{/privacy}","received_events_url":"https://api.github.com/users/SirCmpwn/received_events","type":"User","site_admin":false},"body":"Yep.","created_at":"2016-07-18T01:24:12Z","updated_at":"2016-07-18T01:24:12Z","html_url":"https://github.com/SirCmpwn/sway/pull/762#discussion_r71094126","pull_request_url":"https://api.github.com/repos/SirCmpwn/sway/pulls/762","_links":{"self":{"href":"https://api.github.com/repos/SirCmpwn/sway/pulls/comments/71094126"},"html":{"href":"https://github.com/SirCmpwn/sway/pull/762#discussion_r71094126"},"pull_request":{"href":"https://api.github.com/repos/SirCmpwn/sway/pulls/762"}}},"pull_request":{"url":"https://api.github.com/repos/SirCmpwn/sway/pulls/762","id":77746919,"html_url":"https://github.com/SirCmpwn/sway/pull/762","diff_url":"https://github.com/SirCmpwn/sway/pull/762.diff","patch_url":"https://github.com/SirCmpwn/sway/pull/762.patch","issue_url":"https://api.github.com/repos/SirCmpwn/sway/issues/762","number":762,"state":"open","locked":false,"title":"Add support to move command to move floating containers","user":{"login":"deklov","id":1737914,"avatar_url":"https://avatars.githubusercontent.com/u/1737914?v=3","gravatar_id":"","url":"https://api.github.com/users/deklov","html_url":"https://github.com/deklov","followers_url":"https://api.github.com/users/deklov/followers","following_url":"https://api.github.com/users/deklov/following{/other_user}","gists_url":"https://api.github.com/users/deklov/gists{/gist_id}","starred_url":"https://api.github.com/users/deklov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deklov/subscriptions","organizations_url":"https://api.github.com/users/deklov/orgs","repos_url":"https://api.github.com/users/deklov/repos","events_url":"https://api.github.com/users/deklov/events{/privacy}","received_events_url":"https://api.github.com/users/deklov/received_events","type":"User","site_admin":false},"body":"This is an RFC review, not sure if I did this the right way.","created_at":"2016-07-17T21:39:16Z","updated_at":"2016-07-18T01:24:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1429d607858c958d1fdc05429eceea28684a67e7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SirCmpwn/sway/pulls/762/commits","review_comments_url":"https://api.github.com/repos/SirCmpwn/sway/pulls/762/comments","review_comment_url":"https://api.github.com/repos/SirCmpwn/sway/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SirCmpwn/sway/issues/762/comments","statuses_url":"https://api.github.com/repos/SirCmpwn/sway/statuses/eb231a9e1ca19d486f79047c88d917626ff0b062","head":{"label":"deklov:move-floating-01","ref":"move-floating-01","sha":"eb231a9e1ca19d486f79047c88d917626ff0b062","user":{"login":"deklov","id":1737914,"avatar_url":"https://avatars.githubusercontent.com/u/1737914?v=3","gravatar_id":"","url":"https://api.github.com/users/deklov","html_url":"https://github.com/deklov","followers_url":"https://api.github.com/users/deklov/followers","following_url":"https://api.github.com/users/deklov/following{/other_user}","gists_url":"https://api.github.com/users/deklov/gists{/gist_id}","starred_url":"https://api.github.com/users/deklov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deklov/subscriptions","organizations_url":"https://api.github.com/users/deklov/orgs","repos_url":"https://api.github.com/users/deklov/repos","events_url":"https://api.github.com/users/deklov/events{/privacy}","received_events_url":"https://api.github.com/users/deklov/received_events","type":"User","site_admin":false},"repo":{"id":62025238,"name":"sway","full_name":"deklov/sway","owner":{"login":"deklov","id":1737914,"avatar_url":"https://avatars.githubusercontent.com/u/1737914?v=3","gravatar_id":"","url":"https://api.github.com/users/deklov","html_url":"https://github.com/deklov","followers_url":"https://api.github.com/users/deklov/followers","following_url":"https://api.github.com/users/deklov/following{/other_user}","gists_url":"https://api.github.com/users/deklov/gists{/gist_id}","starred_url":"https://api.github.com/users/deklov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deklov/subscriptions","organizations_url":"https://api.github.com/users/deklov/orgs","repos_url":"https://api.github.com/users/deklov/repos","events_url":"https://api.github.com/users/deklov/events{/privacy}","received_events_url":"https://api.github.com/users/deklov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deklov/sway","description":"i3-compatible window manager for Wayland (WIP)","fork":true,"url":"https://api.github.com/repos/deklov/sway","forks_url":"https://api.github.com/repos/deklov/sway/forks","keys_url":"https://api.github.com/repos/deklov/sway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deklov/sway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deklov/sway/teams","hooks_url":"https://api.github.com/repos/deklov/sway/hooks","issue_events_url":"https://api.github.com/repos/deklov/sway/issues/events{/number}","events_url":"https://api.github.com/repos/deklov/sway/events","assignees_url":"https://api.github.com/repos/deklov/sway/assignees{/user}","branches_url":"https://api.github.com/repos/deklov/sway/branches{/branch}","tags_url":"https://api.github.com/repos/deklov/sway/tags","blobs_url":"https://api.github.com/repos/deklov/sway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deklov/sway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deklov/sway/git/refs{/sha}","trees_url":"https://api.github.com/repos/deklov/sway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deklov/sway/statuses/{sha}","languages_url":"https://api.github.com/repos/deklov/sway/languages","stargazers_url":"https://api.github.com/repos/deklov/sway/stargazers","contributors_url":"https://api.github.com/repos/deklov/sway/contributors","subscribers_url":"https://api.github.com/repos/deklov/sway/subscribers","subscription_url":"https://api.github.com/repos/deklov/sway/subscription","commits_url":"https://api.github.com/repos/deklov/sway/commits{/sha}","git_commits_url":"https://api.github.com/repos/deklov/sway/git/commits{/sha}","comments_url":"https://api.github.com/repos/deklov/sway/comments{/number}","issue_comment_url":"https://api.github.com/repos/deklov/sway/issues/comments{/number}","contents_url":"https://api.github.com/repos/deklov/sway/contents/{+path}","compare_url":"https://api.github.com/repos/deklov/sway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deklov/sway/merges","archive_url":"https://api.github.com/repos/deklov/sway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deklov/sway/downloads","issues_url":"https://api.github.com/repos/deklov/sway/issues{/number}","pulls_url":"https://api.github.com/repos/deklov/sway/pulls{/number}","milestones_url":"https://api.github.com/repos/deklov/sway/milestones{/number}","notifications_url":"https://api.github.com/repos/deklov/sway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deklov/sway/labels{/name}","releases_url":"https://api.github.com/repos/deklov/sway/releases{/id}","deployments_url":"https://api.github.com/repos/deklov/sway/deployments","created_at":"2016-06-27T04:23:04Z","updated_at":"2016-06-27T04:23:06Z","pushed_at":"2016-07-17T21:37:34Z","git_url":"git://github.com/deklov/sway.git","ssh_url":"git@github.com:deklov/sway.git","clone_url":"https://github.com/deklov/sway.git","svn_url":"https://github.com/deklov/sway","homepage":"http://swaywm.org/","size":15475,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SirCmpwn:master","ref":"master","sha":"2530f952c9cec4150f5ee44bdd764123ae09bd30","user":{"login":"SirCmpwn","id":1310872,"avatar_url":"https://avatars.githubusercontent.com/u/1310872?v=3","gravatar_id":"","url":"https://api.github.com/users/SirCmpwn","html_url":"https://github.com/SirCmpwn","followers_url":"https://api.github.com/users/SirCmpwn/followers","following_url":"https://api.github.com/users/SirCmpwn/following{/other_user}","gists_url":"https://api.github.com/users/SirCmpwn/gists{/gist_id}","starred_url":"https://api.github.com/users/SirCmpwn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirCmpwn/subscriptions","organizations_url":"https://api.github.com/users/SirCmpwn/orgs","repos_url":"https://api.github.com/users/SirCmpwn/repos","events_url":"https://api.github.com/users/SirCmpwn/events{/privacy}","received_events_url":"https://api.github.com/users/SirCmpwn/received_events","type":"User","site_admin":false},"repo":{"id":40217904,"name":"sway","full_name":"SirCmpwn/sway","owner":{"login":"SirCmpwn","id":1310872,"avatar_url":"https://avatars.githubusercontent.com/u/1310872?v=3","gravatar_id":"","url":"https://api.github.com/users/SirCmpwn","html_url":"https://github.com/SirCmpwn","followers_url":"https://api.github.com/users/SirCmpwn/followers","following_url":"https://api.github.com/users/SirCmpwn/following{/other_user}","gists_url":"https://api.github.com/users/SirCmpwn/gists{/gist_id}","starred_url":"https://api.github.com/users/SirCmpwn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirCmpwn/subscriptions","organizations_url":"https://api.github.com/users/SirCmpwn/orgs","repos_url":"https://api.github.com/users/SirCmpwn/repos","events_url":"https://api.github.com/users/SirCmpwn/events{/privacy}","received_events_url":"https://api.github.com/users/SirCmpwn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SirCmpwn/sway","description":"i3-compatible Wayland compositor","fork":false,"url":"https://api.github.com/repos/SirCmpwn/sway","forks_url":"https://api.github.com/repos/SirCmpwn/sway/forks","keys_url":"https://api.github.com/repos/SirCmpwn/sway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SirCmpwn/sway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SirCmpwn/sway/teams","hooks_url":"https://api.github.com/repos/SirCmpwn/sway/hooks","issue_events_url":"https://api.github.com/repos/SirCmpwn/sway/issues/events{/number}","events_url":"https://api.github.com/repos/SirCmpwn/sway/events","assignees_url":"https://api.github.com/repos/SirCmpwn/sway/assignees{/user}","branches_url":"https://api.github.com/repos/SirCmpwn/sway/branches{/branch}","tags_url":"https://api.github.com/repos/SirCmpwn/sway/tags","blobs_url":"https://api.github.com/repos/SirCmpwn/sway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SirCmpwn/sway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SirCmpwn/sway/git/refs{/sha}","trees_url":"https://api.github.com/repos/SirCmpwn/sway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SirCmpwn/sway/statuses/{sha}","languages_url":"https://api.github.com/repos/SirCmpwn/sway/languages","stargazers_url":"https://api.github.com/repos/SirCmpwn/sway/stargazers","contributors_url":"https://api.github.com/repos/SirCmpwn/sway/contributors","subscribers_url":"https://api.github.com/repos/SirCmpwn/sway/subscribers","subscription_url":"https://api.github.com/repos/SirCmpwn/sway/subscription","commits_url":"https://api.github.com/repos/SirCmpwn/sway/commits{/sha}","git_commits_url":"https://api.github.com/repos/SirCmpwn/sway/git/commits{/sha}","comments_url":"https://api.github.com/repos/SirCmpwn/sway/comments{/number}","issue_comment_url":"https://api.github.com/repos/SirCmpwn/sway/issues/comments{/number}","contents_url":"https://api.github.com/repos/SirCmpwn/sway/contents/{+path}","compare_url":"https://api.github.com/repos/SirCmpwn/sway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SirCmpwn/sway/merges","archive_url":"https://api.github.com/repos/SirCmpwn/sway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SirCmpwn/sway/downloads","issues_url":"https://api.github.com/repos/SirCmpwn/sway/issues{/number}","pulls_url":"https://api.github.com/repos/SirCmpwn/sway/pulls{/number}","milestones_url":"https://api.github.com/repos/SirCmpwn/sway/milestones{/number}","notifications_url":"https://api.github.com/repos/SirCmpwn/sway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SirCmpwn/sway/labels{/name}","releases_url":"https://api.github.com/repos/SirCmpwn/sway/releases{/id}","deployments_url":"https://api.github.com/repos/SirCmpwn/sway/deployments","created_at":"2015-08-05T01:31:45Z","updated_at":"2016-07-17T21:59:24Z","pushed_at":"2016-07-18T01:00:57Z","git_url":"git://github.com/SirCmpwn/sway.git","ssh_url":"git@github.com:SirCmpwn/sway.git","clone_url":"https://github.com/SirCmpwn/sway.git","svn_url":"https://github.com/SirCmpwn/sway","homepage":"http://swaywm.org/","size":15557,"stargazers_count":1504,"watchers_count":1504,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":90,"mirror_url":null,"open_issues_count":58,"forks":90,"open_issues":58,"watchers":1504,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SirCmpwn/sway/pulls/762"},"html":{"href":"https://github.com/SirCmpwn/sway/pull/762"},"issue":{"href":"https://api.github.com/repos/SirCmpwn/sway/issues/762"},"comments":{"href":"https://api.github.com/repos/SirCmpwn/sway/issues/762/comments"},"review_comments":{"href":"https://api.github.com/repos/SirCmpwn/sway/pulls/762/comments"},"review_comment":{"href":"https://api.github.com/repos/SirCmpwn/sway/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SirCmpwn/sway/pulls/762/commits"},"statuses":{"href":"https://api.github.com/repos/SirCmpwn/sway/statuses/eb231a9e1ca19d486f79047c88d917626ff0b062"}}}}
{"actor":{"display_login":"SirCmpwn"}}