{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments/74641881","id":74641881,"diff_hunk":"@@ -528,6 +528,36 @@ angular.module('openshiftConsole')\n       }\n       var uri = new URI(url);\n       var protocol = uri.protocol();\n-      return uri.is('absolute') && (protocol === 'http' || protocol === 'https');      \n+      return uri.is('absolute') && (protocol === 'http' || protocol === 'https');\n+    };\n+  })\n+  // currently used to set an alt text value for an env var that has a\n+  // valueFrom attribute instead of a value.\n+  .filter('altTextForValueFrom', function() {\n+    return function(envVar) {\n+      if(envVar.value) {\n+        return;\n+      }\n+      if(!envVar.valueFrom) {\n+        return;\n+      }\n+      envVar.valueIcon = 'pficon pficon-help';\n+      envVar.valueIconTooltip = 'This is a referenced value that will be generated when a container is created.  On running pods you can check the resolved values by going to the Terminal tab and echoing the environment variable.';\n+      _.each(envVar.valueFrom, function(from, refType) {\n+        switch(refType) {\n+          case 'configMapKeyRef':\n+            envVar.valueAlt = 'Set to the key ' + from.key + ' in config map ' + from.name;","path":"app/scripts/filters/util.js","position":23,"original_position":23,"commit_id":"26c80dd0a8c5d46c60834165a6d4e990a08f6bb7","original_commit_id":"26c80dd0a8c5d46c60834165a6d4e990a08f6bb7","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"We shouldn't send extra stuff to the server even if it's ignored today. What if a `valueAlt` field is added to the API in the future?","created_at":"2016-08-12T18:48:47Z","updated_at":"2016-08-12T18:48:47Z","html_url":"https://github.com/openshift/origin-web-console/pull/351#discussion_r74641881","pull_request_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/351","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments/74641881"},"html":{"href":"https://github.com/openshift/origin-web-console/pull/351#discussion_r74641881"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/351"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/351","id":81016633,"html_url":"https://github.com/openshift/origin-web-console/pull/351","diff_url":"https://github.com/openshift/origin-web-console/pull/351.diff","patch_url":"https://github.com/openshift/origin-web-console/pull/351.patch","issue_url":"https://api.github.com/repos/openshift/origin-web-console/issues/351","number":351,"state":"open","locked":false,"title":"Ensure DC,BC can display alt text for valueFrom in kve","user":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars.githubusercontent.com/u/280512?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"body":"Fix #292 \r\n\r\nEnsures that there is a readonly alt text available for BCs/DCs that have env vars with a `valueFrom` attribute.  Example:\r\n<img width=\"917\" alt=\"screen shot 2016-08-11 at 3 28 17 pm\" src=\"https://cloud.githubusercontent.com/assets/280512/17601892/44fb624c-5fd8-11e6-889b-70f85debb5b7.png\">\r\n\r\n\r\nThe `$filter` for this is using the same logic that exists in the `<environment>` directive.\r\n\r\n@jwforres @spadgett ","created_at":"2016-08-11T19:31:58Z","updated_at":"2016-08-12T18:48:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5988aa20e45ccd32162332b93aab6300b69cef93","assignee":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"assignees":[{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/351/commits","review_comments_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/351/comments","review_comment_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/issues/351/comments","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/26c80dd0a8c5d46c60834165a6d4e990a08f6bb7","head":{"label":"benjaminapetersen:issue-292-value-from","ref":"issue-292-value-from","sha":"26c80dd0a8c5d46c60834165a6d4e990a08f6bb7","user":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars.githubusercontent.com/u/280512?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"repo":{"id":58689425,"name":"origin-web-console","full_name":"benjaminapetersen/origin-web-console","owner":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars.githubusercontent.com/u/280512?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjaminapetersen/origin-web-console","description":"","fork":true,"url":"https://api.github.com/repos/benjaminapetersen/origin-web-console","forks_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/forks","keys_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/teams","hooks_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/events","assignees_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/tags","blobs_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/subscription","commits_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/merges","archive_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/downloads","issues_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/deployments","created_at":"2016-05-13T01:31:58Z","updated_at":"2016-05-13T01:31:59Z","pushed_at":"2016-08-12T17:50:12Z","git_url":"git://github.com/benjaminapetersen/origin-web-console.git","ssh_url":"git@github.com:benjaminapetersen/origin-web-console.git","clone_url":"https://github.com/benjaminapetersen/origin-web-console.git","svn_url":"https://github.com/benjaminapetersen/origin-web-console","homepage":null,"size":8866,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"fbddfbdd76bfe0d3dec840f7ca52fdba107a16af","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":58488264,"name":"origin-web-console","full_name":"openshift/origin-web-console","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin-web-console","description":"","fork":false,"url":"https://api.github.com/repos/openshift/origin-web-console","forks_url":"https://api.github.com/repos/openshift/origin-web-console/forks","keys_url":"https://api.github.com/repos/openshift/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin-web-console/teams","hooks_url":"https://api.github.com/repos/openshift/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin-web-console/events","assignees_url":"https://api.github.com/repos/openshift/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin-web-console/tags","blobs_url":"https://api.github.com/repos/openshift/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/openshift/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin-web-console/subscription","commits_url":"https://api.github.com/repos/openshift/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin-web-console/merges","archive_url":"https://api.github.com/repos/openshift/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin-web-console/downloads","issues_url":"https://api.github.com/repos/openshift/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin-web-console/deployments","created_at":"2016-05-10T19:31:50Z","updated_at":"2016-08-05T20:43:27Z","pushed_at":"2016-08-12T18:43:13Z","git_url":"git://github.com/openshift/origin-web-console.git","ssh_url":"git@github.com:openshift/origin-web-console.git","clone_url":"https://github.com/openshift/origin-web-console.git","svn_url":"https://github.com/openshift/origin-web-console","homepage":null,"size":10145,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":65,"forks":37,"open_issues":65,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/351"},"html":{"href":"https://github.com/openshift/origin-web-console/pull/351"},"issue":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/351"},"comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/351/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/351/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/351/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin-web-console/statuses/26c80dd0a8c5d46c60834165a6d4e990a08f6bb7"}}}}
{"actor":{"display_login":"spadgett"}}