{"action":"created","issue":{"url":"https://api.github.com/repos/Manishearth/rust-clippy/issues/727","repository_url":"https://api.github.com/repos/Manishearth/rust-clippy","labels_url":"https://api.github.com/repos/Manishearth/rust-clippy/issues/727/labels{/name}","comments_url":"https://api.github.com/repos/Manishearth/rust-clippy/issues/727/comments","events_url":"https://api.github.com/repos/Manishearth/rust-clippy/issues/727/events","html_url":"https://github.com/Manishearth/rust-clippy/pull/727","id":137256125,"number":727,"title":"WIP: lint on binding-names that are too similar","user":{"login":"oli-obk","id":332036,"avatar_url":"https://avatars.githubusercontent.com/u/332036?v=3","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-29T13:34:43Z","updated_at":"2016-02-29T13:59:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Manishearth/rust-clippy/pulls/727","html_url":"https://github.com/Manishearth/rust-clippy/pull/727","diff_url":"https://github.com/Manishearth/rust-clippy/pull/727.diff","patch_url":"https://github.com/Manishearth/rust-clippy/pull/727.patch"},"body":"This doesn't work, because out of some reason `in_macro` does not trigger for the for-loops in `for_loop_over_option_and_result` in `compile-fail/for_loops.rs`. My `visit_name` code might be wrong, because I'm not sure what happens when a `hir::Ident` is visited (are both the hygienic and non-hygienic name visited?), but even then should the span + `in_macro` prevent this.\r\n\r\nHelp? :sos: \r\n\r\ncc #644"},"comment":{"url":"https://api.github.com/repos/Manishearth/rust-clippy/issues/comments/190222907","html_url":"https://github.com/Manishearth/rust-clippy/pull/727#issuecomment-190222907","issue_url":"https://api.github.com/repos/Manishearth/rust-clippy/issues/727","id":190222907,"user":{"login":"mcarton","id":3751788,"avatar_url":"https://avatars.githubusercontent.com/u/3751788?v=3","gravatar_id":"","url":"https://api.github.com/users/mcarton","html_url":"https://github.com/mcarton","followers_url":"https://api.github.com/users/mcarton/followers","following_url":"https://api.github.com/users/mcarton/following{/other_user}","gists_url":"https://api.github.com/users/mcarton/gists{/gist_id}","starred_url":"https://api.github.com/users/mcarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcarton/subscriptions","organizations_url":"https://api.github.com/users/mcarton/orgs","repos_url":"https://api.github.com/users/mcarton/repos","events_url":"https://api.github.com/users/mcarton/events{/privacy}","received_events_url":"https://api.github.com/users/mcarton/received_events","type":"User","site_admin":false},"created_at":"2016-02-29T13:59:43Z","updated_at":"2016-02-29T13:59:43Z","body":"Also I’m not sure about that lint being Warn by default, it would lint `foo_x` and `foo_y` but not `x` and `y` and it would lint `for item in items`. Looks like a lot of false positive."}}