{"action":"created","comment":{"url":"https://api.github.com/repos/jarun/Buku/pulls/comments/88364116","pull_request_review_id":8940461,"id":88364116,"diff_hunk":"@@ -1492,6 +1492,31 @@ def get_page_title(resp):\n         return htmlparser.parsed_title\n \n \n+def create_poolmanager(url):","path":"buku.py","position":4,"original_position":4,"commit_id":"2f4b1cbf9ab8a9f086fc2071754e3b2daf4333cf","original_commit_id":"2f4b1cbf9ab8a9f086fc2071754e3b2daf4333cf","user":{"login":"denisfalqueto","id":118121,"avatar_url":"https://avatars.githubusercontent.com/u/118121?v=3","gravatar_id":"","url":"https://api.github.com/users/denisfalqueto","html_url":"https://github.com/denisfalqueto","followers_url":"https://api.github.com/users/denisfalqueto/followers","following_url":"https://api.github.com/users/denisfalqueto/following{/other_user}","gists_url":"https://api.github.com/users/denisfalqueto/gists{/gist_id}","starred_url":"https://api.github.com/users/denisfalqueto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denisfalqueto/subscriptions","organizations_url":"https://api.github.com/users/denisfalqueto/orgs","repos_url":"https://api.github.com/users/denisfalqueto/repos","events_url":"https://api.github.com/users/denisfalqueto/events{/privacy}","received_events_url":"https://api.github.com/users/denisfalqueto/received_events","type":"User","site_admin":false},"body":"I was trying to be general, but it's alright. Would you have any objections for using ProxyManager in place of PoolManager? And should I add a new parameter or just adapt to the environment variables?","created_at":"2016-11-17T00:37:46Z","updated_at":"2016-11-17T00:37:46Z","html_url":"https://github.com/jarun/Buku/pull/96#discussion_r88364116","pull_request_url":"https://api.github.com/repos/jarun/Buku/pulls/96","_links":{"self":{"href":"https://api.github.com/repos/jarun/Buku/pulls/comments/88364116"},"html":{"href":"https://github.com/jarun/Buku/pull/96#discussion_r88364116"},"pull_request":{"href":"https://api.github.com/repos/jarun/Buku/pulls/96"}}},"pull_request":{"url":"https://api.github.com/repos/jarun/Buku/pulls/96","id":94078320,"html_url":"https://github.com/jarun/Buku/pull/96","diff_url":"https://github.com/jarun/Buku/pull/96.diff","patch_url":"https://github.com/jarun/Buku/pull/96.patch","issue_url":"https://api.github.com/repos/jarun/Buku/issues/96","number":96,"state":"open","locked":false,"title":"Support http proxy environment variables","user":{"login":"denisfalqueto","id":118121,"avatar_url":"https://avatars.githubusercontent.com/u/118121?v=3","gravatar_id":"","url":"https://api.github.com/users/denisfalqueto","html_url":"https://github.com/denisfalqueto","followers_url":"https://api.github.com/users/denisfalqueto/followers","following_url":"https://api.github.com/users/denisfalqueto/following{/other_user}","gists_url":"https://api.github.com/users/denisfalqueto/gists{/gist_id}","starred_url":"https://api.github.com/users/denisfalqueto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denisfalqueto/subscriptions","organizations_url":"https://api.github.com/users/denisfalqueto/orgs","repos_url":"https://api.github.com/users/denisfalqueto/repos","events_url":"https://api.github.com/users/denisfalqueto/events{/privacy}","received_events_url":"https://api.github.com/users/denisfalqueto/received_events","type":"User","site_admin":false},"body":"Hi, I would like to be able to use Buku behind an enterprise proxy. urllib3 already has support for that, but need to be configured when creating an pool manager. This patch does that configuration. All that is needed is some environment variables (http_proxy, https_proxy, etc) that are already nsed by other tools, such as curl, wget, etc.","created_at":"2016-11-17T00:16:58Z","updated_at":"2016-11-17T00:37:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f8aa7390ebbed276090d975984dbfc16fd4270d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jarun/Buku/pulls/96/commits","review_comments_url":"https://api.github.com/repos/jarun/Buku/pulls/96/comments","review_comment_url":"https://api.github.com/repos/jarun/Buku/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jarun/Buku/issues/96/comments","statuses_url":"https://api.github.com/repos/jarun/Buku/statuses/2f4b1cbf9ab8a9f086fc2071754e3b2daf4333cf","head":{"label":"denisfalqueto:master","ref":"master","sha":"2f4b1cbf9ab8a9f086fc2071754e3b2daf4333cf","user":{"login":"denisfalqueto","id":118121,"avatar_url":"https://avatars.githubusercontent.com/u/118121?v=3","gravatar_id":"","url":"https://api.github.com/users/denisfalqueto","html_url":"https://github.com/denisfalqueto","followers_url":"https://api.github.com/users/denisfalqueto/followers","following_url":"https://api.github.com/users/denisfalqueto/following{/other_user}","gists_url":"https://api.github.com/users/denisfalqueto/gists{/gist_id}","starred_url":"https://api.github.com/users/denisfalqueto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denisfalqueto/subscriptions","organizations_url":"https://api.github.com/users/denisfalqueto/orgs","repos_url":"https://api.github.com/users/denisfalqueto/repos","events_url":"https://api.github.com/users/denisfalqueto/events{/privacy}","received_events_url":"https://api.github.com/users/denisfalqueto/received_events","type":"User","site_admin":false},"repo":{"id":73972805,"name":"Buku","full_name":"denisfalqueto/Buku","owner":{"login":"denisfalqueto","id":118121,"avatar_url":"https://avatars.githubusercontent.com/u/118121?v=3","gravatar_id":"","url":"https://api.github.com/users/denisfalqueto","html_url":"https://github.com/denisfalqueto","followers_url":"https://api.github.com/users/denisfalqueto/followers","following_url":"https://api.github.com/users/denisfalqueto/following{/other_user}","gists_url":"https://api.github.com/users/denisfalqueto/gists{/gist_id}","starred_url":"https://api.github.com/users/denisfalqueto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denisfalqueto/subscriptions","organizations_url":"https://api.github.com/users/denisfalqueto/orgs","repos_url":"https://api.github.com/users/denisfalqueto/repos","events_url":"https://api.github.com/users/denisfalqueto/events{/privacy}","received_events_url":"https://api.github.com/users/denisfalqueto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/denisfalqueto/Buku","description":"Powerful command-line bookmark manager. Your mini web!","fork":true,"url":"https://api.github.com/repos/denisfalqueto/Buku","forks_url":"https://api.github.com/repos/denisfalqueto/Buku/forks","keys_url":"https://api.github.com/repos/denisfalqueto/Buku/keys{/key_id}","collaborators_url":"https://api.github.com/repos/denisfalqueto/Buku/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/denisfalqueto/Buku/teams","hooks_url":"https://api.github.com/repos/denisfalqueto/Buku/hooks","issue_events_url":"https://api.github.com/repos/denisfalqueto/Buku/issues/events{/number}","events_url":"https://api.github.com/repos/denisfalqueto/Buku/events","assignees_url":"https://api.github.com/repos/denisfalqueto/Buku/assignees{/user}","branches_url":"https://api.github.com/repos/denisfalqueto/Buku/branches{/branch}","tags_url":"https://api.github.com/repos/denisfalqueto/Buku/tags","blobs_url":"https://api.github.com/repos/denisfalqueto/Buku/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/denisfalqueto/Buku/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/denisfalqueto/Buku/git/refs{/sha}","trees_url":"https://api.github.com/repos/denisfalqueto/Buku/git/trees{/sha}","statuses_url":"https://api.github.com/repos/denisfalqueto/Buku/statuses/{sha}","languages_url":"https://api.github.com/repos/denisfalqueto/Buku/languages","stargazers_url":"https://api.github.com/repos/denisfalqueto/Buku/stargazers","contributors_url":"https://api.github.com/repos/denisfalqueto/Buku/contributors","subscribers_url":"https://api.github.com/repos/denisfalqueto/Buku/subscribers","subscription_url":"https://api.github.com/repos/denisfalqueto/Buku/subscription","commits_url":"https://api.github.com/repos/denisfalqueto/Buku/commits{/sha}","git_commits_url":"https://api.github.com/repos/denisfalqueto/Buku/git/commits{/sha}","comments_url":"https://api.github.com/repos/denisfalqueto/Buku/comments{/number}","issue_comment_url":"https://api.github.com/repos/denisfalqueto/Buku/issues/comments{/number}","contents_url":"https://api.github.com/repos/denisfalqueto/Buku/contents/{+path}","compare_url":"https://api.github.com/repos/denisfalqueto/Buku/compare/{base}...{head}","merges_url":"https://api.github.com/repos/denisfalqueto/Buku/merges","archive_url":"https://api.github.com/repos/denisfalqueto/Buku/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/denisfalqueto/Buku/downloads","issues_url":"https://api.github.com/repos/denisfalqueto/Buku/issues{/number}","pulls_url":"https://api.github.com/repos/denisfalqueto/Buku/pulls{/number}","milestones_url":"https://api.github.com/repos/denisfalqueto/Buku/milestones{/number}","notifications_url":"https://api.github.com/repos/denisfalqueto/Buku/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/denisfalqueto/Buku/labels{/name}","releases_url":"https://api.github.com/repos/denisfalqueto/Buku/releases{/id}","deployments_url":"https://api.github.com/repos/denisfalqueto/Buku/deployments","created_at":"2016-11-17T00:07:45Z","updated_at":"2016-11-17T00:07:46Z","pushed_at":"2016-11-17T00:14:16Z","git_url":"git://github.com/denisfalqueto/Buku.git","ssh_url":"git@github.com:denisfalqueto/Buku.git","clone_url":"https://github.com/denisfalqueto/Buku.git","svn_url":"https://github.com/denisfalqueto/Buku","homepage":"","size":1802,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jarun:master","ref":"master","sha":"d4358e113ca3d30ee5e9be6dba112f5658c61d72","user":{"login":"jarun","id":5959286,"avatar_url":"https://avatars.githubusercontent.com/u/5959286?v=3","gravatar_id":"","url":"https://api.github.com/users/jarun","html_url":"https://github.com/jarun","followers_url":"https://api.github.com/users/jarun/followers","following_url":"https://api.github.com/users/jarun/following{/other_user}","gists_url":"https://api.github.com/users/jarun/gists{/gist_id}","starred_url":"https://api.github.com/users/jarun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarun/subscriptions","organizations_url":"https://api.github.com/users/jarun/orgs","repos_url":"https://api.github.com/users/jarun/repos","events_url":"https://api.github.com/users/jarun/events{/privacy}","received_events_url":"https://api.github.com/users/jarun/received_events","type":"User","site_admin":false},"repo":{"id":45355064,"name":"Buku","full_name":"jarun/Buku","owner":{"login":"jarun","id":5959286,"avatar_url":"https://avatars.githubusercontent.com/u/5959286?v=3","gravatar_id":"","url":"https://api.github.com/users/jarun","html_url":"https://github.com/jarun","followers_url":"https://api.github.com/users/jarun/followers","following_url":"https://api.github.com/users/jarun/following{/other_user}","gists_url":"https://api.github.com/users/jarun/gists{/gist_id}","starred_url":"https://api.github.com/users/jarun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarun/subscriptions","organizations_url":"https://api.github.com/users/jarun/orgs","repos_url":"https://api.github.com/users/jarun/repos","events_url":"https://api.github.com/users/jarun/events{/privacy}","received_events_url":"https://api.github.com/users/jarun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jarun/Buku","description":"Powerful command-line bookmark manager. Your mini web!","fork":false,"url":"https://api.github.com/repos/jarun/Buku","forks_url":"https://api.github.com/repos/jarun/Buku/forks","keys_url":"https://api.github.com/repos/jarun/Buku/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jarun/Buku/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jarun/Buku/teams","hooks_url":"https://api.github.com/repos/jarun/Buku/hooks","issue_events_url":"https://api.github.com/repos/jarun/Buku/issues/events{/number}","events_url":"https://api.github.com/repos/jarun/Buku/events","assignees_url":"https://api.github.com/repos/jarun/Buku/assignees{/user}","branches_url":"https://api.github.com/repos/jarun/Buku/branches{/branch}","tags_url":"https://api.github.com/repos/jarun/Buku/tags","blobs_url":"https://api.github.com/repos/jarun/Buku/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jarun/Buku/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jarun/Buku/git/refs{/sha}","trees_url":"https://api.github.com/repos/jarun/Buku/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jarun/Buku/statuses/{sha}","languages_url":"https://api.github.com/repos/jarun/Buku/languages","stargazers_url":"https://api.github.com/repos/jarun/Buku/stargazers","contributors_url":"https://api.github.com/repos/jarun/Buku/contributors","subscribers_url":"https://api.github.com/repos/jarun/Buku/subscribers","subscription_url":"https://api.github.com/repos/jarun/Buku/subscription","commits_url":"https://api.github.com/repos/jarun/Buku/commits{/sha}","git_commits_url":"https://api.github.com/repos/jarun/Buku/git/commits{/sha}","comments_url":"https://api.github.com/repos/jarun/Buku/comments{/number}","issue_comment_url":"https://api.github.com/repos/jarun/Buku/issues/comments{/number}","contents_url":"https://api.github.com/repos/jarun/Buku/contents/{+path}","compare_url":"https://api.github.com/repos/jarun/Buku/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jarun/Buku/merges","archive_url":"https://api.github.com/repos/jarun/Buku/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jarun/Buku/downloads","issues_url":"https://api.github.com/repos/jarun/Buku/issues{/number}","pulls_url":"https://api.github.com/repos/jarun/Buku/pulls{/number}","milestones_url":"https://api.github.com/repos/jarun/Buku/milestones{/number}","notifications_url":"https://api.github.com/repos/jarun/Buku/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jarun/Buku/labels{/name}","releases_url":"https://api.github.com/repos/jarun/Buku/releases{/id}","deployments_url":"https://api.github.com/repos/jarun/Buku/deployments","created_at":"2015-11-01T19:53:18Z","updated_at":"2016-11-15T09:33:39Z","pushed_at":"2016-11-17T00:16:58Z","git_url":"git://github.com/jarun/Buku.git","ssh_url":"git@github.com:jarun/Buku.git","clone_url":"https://github.com/jarun/Buku.git","svn_url":"https://github.com/jarun/Buku","homepage":"","size":1802,"stargazers_count":785,"watchers_count":785,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":2,"forks":55,"open_issues":2,"watchers":785,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jarun/Buku/pulls/96"},"html":{"href":"https://github.com/jarun/Buku/pull/96"},"issue":{"href":"https://api.github.com/repos/jarun/Buku/issues/96"},"comments":{"href":"https://api.github.com/repos/jarun/Buku/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/jarun/Buku/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/jarun/Buku/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jarun/Buku/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/jarun/Buku/statuses/2f4b1cbf9ab8a9f086fc2071754e3b2daf4333cf"}}}}
{"actor":{"display_login":"denisfalqueto"}}