{"action":"created","issue":{"url":"https://api.github.com/repos/idank/bashlex/issues/8","repository_url":"https://api.github.com/repos/idank/bashlex","labels_url":"https://api.github.com/repos/idank/bashlex/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/idank/bashlex/issues/8/comments","events_url":"https://api.github.com/repos/idank/bashlex/issues/8/events","html_url":"https://github.com/idank/bashlex/pull/8","id":135057517,"number":8,"title":"parse empty lines and comments","user":{"login":"blurrymoi","id":11298672,"avatar_url":"https://avatars.githubusercontent.com/u/11298672?v=3","gravatar_id":"","url":"https://api.github.com/users/blurrymoi","html_url":"https://github.com/blurrymoi","followers_url":"https://api.github.com/users/blurrymoi/followers","following_url":"https://api.github.com/users/blurrymoi/following{/other_user}","gists_url":"https://api.github.com/users/blurrymoi/gists{/gist_id}","starred_url":"https://api.github.com/users/blurrymoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blurrymoi/subscriptions","organizations_url":"https://api.github.com/users/blurrymoi/orgs","repos_url":"https://api.github.com/users/blurrymoi/repos","events_url":"https://api.github.com/users/blurrymoi/events{/privacy}","received_events_url":"https://api.github.com/users/blurrymoi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-02-20T10:12:52Z","updated_at":"2016-02-20T18:39:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/idank/bashlex/pulls/8","html_url":"https://github.com/idank/bashlex/pull/8","diff_url":"https://github.com/idank/bashlex/pull/8.diff","patch_url":"https://github.com/idank/bashlex/pull/8.patch"},"body":"Allows to parse whole files.\r\n\r\nThe idea is that I force-reduce on inputunit -> NEWLINE rule and accept by creating a dummy newline node that only retains position (needed for further parsing). These nodes are filtered in the end to prevent output such as:\r\nNewlineNode\r\nNewlineNode\r\nCommandNode\r\n...\r\n\r\nI handpicked the relevant changes, so I hope I didn't miss anything."},"comment":{"url":"https://api.github.com/repos/idank/bashlex/issues/comments/186664576","html_url":"https://github.com/idank/bashlex/pull/8#issuecomment-186664576","issue_url":"https://api.github.com/repos/idank/bashlex/issues/8","id":186664576,"user":{"login":"idank","id":1277636,"avatar_url":"https://avatars.githubusercontent.com/u/1277636?v=3","gravatar_id":"","url":"https://api.github.com/users/idank","html_url":"https://github.com/idank","followers_url":"https://api.github.com/users/idank/followers","following_url":"https://api.github.com/users/idank/following{/other_user}","gists_url":"https://api.github.com/users/idank/gists{/gist_id}","starred_url":"https://api.github.com/users/idank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idank/subscriptions","organizations_url":"https://api.github.com/users/idank/orgs","repos_url":"https://api.github.com/users/idank/repos","events_url":"https://api.github.com/users/idank/events{/privacy}","received_events_url":"https://api.github.com/users/idank/received_events","type":"User","site_admin":false},"created_at":"2016-02-20T18:39:15Z","updated_at":"2016-02-20T18:39:15Z","body":"Thanks for sending this. I'm curious how GNU bash handles new lines,\nideally we should do the same so we stay close to the source. Though if\nthis works, I guess I'm fine with taking it.\n\nCan you add some tests?\nOn Feb 20, 2016 02:12, \"blurrymoi\" <notifications@github.com> wrote:\n\n> Allows to parse whole files.\n>\n> The idea is that I force-reduce on inputunit -> NEWLINE rule and accept by\n> creating a dummy newline node that only retains position (needed for\n> further parsing). These nodes are filtered in the end to prevent output\n> such as:\n> NewlineNode\n> NewlineNode\n> CommandNode\n> ...\n>\n> I handpicked the relevant changes, so I hope I didn't miss anything.\n> ------------------------------\n> You can view, comment on, or merge this pull request online at:\n>\n>   https://github.com/idank/bashlex/pull/8\n> Commit Summary\n>\n>    - parse empty lines and comments\n>\n> File Changes\n>\n>    - *M* bashlex/ast.py\n>    <https://github.com/idank/bashlex/pull/8/files#diff-0> (4)\n>    - *M* bashlex/parser.py\n>    <https://github.com/idank/bashlex/pull/8/files#diff-1> (5)\n>\n> Patch Links:\n>\n>    - https://github.com/idank/bashlex/pull/8.patch\n>    - https://github.com/idank/bashlex/pull/8.diff\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/idank/bashlex/pull/8>.\n>\n"}}