{"action":"created","issue":{"url":"https://api.github.com/repos/dgraph-io/perf/issues/4","repository_url":"https://api.github.com/repos/dgraph-io/perf","labels_url":"https://api.github.com/repos/dgraph-io/perf/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/dgraph-io/perf/issues/4/comments","events_url":"https://api.github.com/repos/dgraph-io/perf/issues/4/events","html_url":"https://github.com/dgraph-io/perf/pull/4","id":178595105,"number":4,"title":"Feature added to scores","user":{"login":"adishap","id":6450219,"avatar_url":"https://avatars.githubusercontent.com/u/6450219?v=3","gravatar_id":"","url":"https://api.github.com/users/adishap","html_url":"https://github.com/adishap","followers_url":"https://api.github.com/users/adishap/followers","following_url":"https://api.github.com/users/adishap/following{/other_user}","gists_url":"https://api.github.com/users/adishap/gists{/gist_id}","starred_url":"https://api.github.com/users/adishap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adishap/subscriptions","organizations_url":"https://api.github.com/users/adishap/orgs","repos_url":"https://api.github.com/users/adishap/repos","events_url":"https://api.github.com/users/adishap/events{/privacy}","received_events_url":"https://api.github.com/users/adishap/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"pawanrawal","id":7247941,"avatar_url":"https://avatars.githubusercontent.com/u/7247941?v=3","gravatar_id":"","url":"https://api.github.com/users/pawanrawal","html_url":"https://github.com/pawanrawal","followers_url":"https://api.github.com/users/pawanrawal/followers","following_url":"https://api.github.com/users/pawanrawal/following{/other_user}","gists_url":"https://api.github.com/users/pawanrawal/gists{/gist_id}","starred_url":"https://api.github.com/users/pawanrawal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawanrawal/subscriptions","organizations_url":"https://api.github.com/users/pawanrawal/orgs","repos_url":"https://api.github.com/users/pawanrawal/repos","events_url":"https://api.github.com/users/pawanrawal/events{/privacy}","received_events_url":"https://api.github.com/users/pawanrawal/received_events","type":"User","site_admin":false},"assignees":[{"login":"pawanrawal","id":7247941,"avatar_url":"https://avatars.githubusercontent.com/u/7247941?v=3","gravatar_id":"","url":"https://api.github.com/users/pawanrawal","html_url":"https://github.com/pawanrawal","followers_url":"https://api.github.com/users/pawanrawal/followers","following_url":"https://api.github.com/users/pawanrawal/following{/other_user}","gists_url":"https://api.github.com/users/pawanrawal/gists{/gist_id}","starred_url":"https://api.github.com/users/pawanrawal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawanrawal/subscriptions","organizations_url":"https://api.github.com/users/pawanrawal/orgs","repos_url":"https://api.github.com/users/pawanrawal/repos","events_url":"https://api.github.com/users/pawanrawal/events{/privacy}","received_events_url":"https://api.github.com/users/pawanrawal/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-09-22T12:21:19Z","updated_at":"2016-09-28T08:42:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dgraph-io/perf/pulls/4","html_url":"https://github.com/dgraph-io/perf/pull/4","diff_url":"https://github.com/dgraph-io/perf/pull/4.diff","patch_url":"https://github.com/dgraph-io/perf/pull/4.patch"},"body":"features for review:\r\n1. Sorting scores.\r\n2. showing users tasks completed in recent week\r\n3. whitelisting some users\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dgraph-io/perf/4)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/dgraph-io/perf/issues/comments/250107438","html_url":"https://github.com/dgraph-io/perf/pull/4#issuecomment-250107438","issue_url":"https://api.github.com/repos/dgraph-io/perf/issues/4","id":250107438,"user":{"login":"adishap","id":6450219,"avatar_url":"https://avatars.githubusercontent.com/u/6450219?v=3","gravatar_id":"","url":"https://api.github.com/users/adishap","html_url":"https://github.com/adishap","followers_url":"https://api.github.com/users/adishap/followers","following_url":"https://api.github.com/users/adishap/following{/other_user}","gists_url":"https://api.github.com/users/adishap/gists{/gist_id}","starred_url":"https://api.github.com/users/adishap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adishap/subscriptions","organizations_url":"https://api.github.com/users/adishap/orgs","repos_url":"https://api.github.com/users/adishap/repos","events_url":"https://api.github.com/users/adishap/events{/privacy}","received_events_url":"https://api.github.com/users/adishap/received_events","type":"User","site_admin":false},"created_at":"2016-09-28T08:42:55Z","updated_at":"2016-09-28T08:42:55Z","body":"\n\n\n\nReview status: 0 of 6 files reviewed at latest revision, 13 unresolved discussions.\n\n---\n\n*[main.go, line 30 at r1](https://reviewable.io:443/reviews/dgraph-io/perf/4#-KSjdd0hHe8vZ2zcHMXv:-KSjn50NW70LzXuwwAsg:b-qbz2m5) ([raw file](https://github.com/dgraph-io/perf/blob/d61b58509a397d350acbc7c23f2b797524463ec6/main.go#L30)):*\n<details><summary><i>Previously, pawanrawal (Pawan Rawal) wrote…</i></summary>\n> Comma separated list of whitelisted users. Realized that there are no tests for your code. Please also add some on the weekend.\n</details>\nOk will add tests by weekend.\n\n---\n\n*[main.go, line 61 at r1](https://reviewable.io:443/reviews/dgraph-io/perf/4#-KSjdwbH7vuUH-RiSENk:-KSjnergqMDmJIqsyCin:b-896fix) ([raw file](https://github.com/dgraph-io/perf/blob/d61b58509a397d350acbc7c23f2b797524463ec6/main.go#L61)):*\n<details><summary><i>Previously, pawanrawal (Pawan Rawal) wrote…</i></summary>\n> Do a `log.Fatal` if len(*users) <=0 And then do this checking.\n</details>\nDone.\n\n---\n\n*[main.go, line 67 at r1](https://reviewable.io:443/reviews/dgraph-io/perf/4#-KSje8I7FraffQFkYKks:-KSjncrcAOekiKlIjD_F:b-896fix) ([raw file](https://github.com/dgraph-io/perf/blob/d61b58509a397d350acbc7c23f2b797524463ec6/main.go#L67)):*\n<details><summary><i>Previously, pawanrawal (Pawan Rawal) wrote…</i></summary>\n> Use Fatalf and output the username that is not valid.\n</details>\nDone.\n\n---\n\n*[main.go, line 73 at r1](https://reviewable.io:443/reviews/dgraph-io/perf/4#-KSjeGWMkb_RS3nflRpc:-KSjnbxWE_THpw9GtZnR:b-896fix) ([raw file](https://github.com/dgraph-io/perf/blob/d61b58509a397d350acbc7c23f2b797524463ec6/main.go#L73)):*\n<details><summary><i>Previously, pawanrawal (Pawan Rawal) wrote…</i></summary>\n> this would change and you'd just return whitelistedUsers\n</details>\nDone.\n\n---\n\n*[main.go, line 136 at r1](https://reviewable.io:443/reviews/dgraph-io/perf/4#-KSjec2s6FWO5MHZ0Cvr:-KSjoUOC1kBg2qQrIV1a:b-jfntq9) ([raw file](https://github.com/dgraph-io/perf/blob/d61b58509a397d350acbc7c23f2b797524463ec6/main.go#L136)):*\n<details><summary><i>Previously, pawanrawal (Pawan Rawal) wrote…</i></summary>\n> Dd we change the schema here?\n</details>\nYes. Earlier getScore() was returning map[string]Count now it returns []Count.\n\n---\n\n*[main.go, line 186 at r1](https://reviewable.io:443/reviews/dgraph-io/perf/4#-KSjfk9qZfpRn8JgIEnq:-KSjs3hbQVM_sqQ3sDM0:b-896fix) ([raw file](https://github.com/dgraph-io/perf/blob/d61b58509a397d350acbc7c23f2b797524463ec6/main.go#L186)):*\n<details><summary><i>Previously, pawanrawal (Pawan Rawal) wrote…</i></summary>\n> Let us define this close to where it is used.\n</details>\nDone.\n\n---\n\n*[main.go, line 188 at r1](https://reviewable.io:443/reviews/dgraph-io/perf/4#-KSjfxh-auyXJ0ekWtBT:-KSjs5BkNN3JbkBAL8Ql:b-896fix) ([raw file](https://github.com/dgraph-io/perf/blob/d61b58509a397d350acbc7c23f2b797524463ec6/main.go#L188)):*\n<details><summary><i>Previously, pawanrawal (Pawan Rawal) wrote…</i></summary>\n> sMap?\n</details>\nDone.\n\n---\n\n*[main.go, line 190 at r1](https://reviewable.io:443/reviews/dgraph-io/perf/4#-KSjfwCPT0XXSoq7Ooau:-KSjs6I6h3wpD0-OHpe6:b-896fix) ([raw file](https://github.com/dgraph-io/perf/blob/d61b58509a397d350acbc7c23f2b797524463ec6/main.go#L190)):*\n<details><summary><i>Previously, pawanrawal (Pawan Rawal) wrote…</i></summary>\n> lsMap?\n</details>\nDone.\n\n---\n\n*[main.go, line 286 at r1](https://reviewable.io:443/reviews/dgraph-io/perf/4#-KSjes_wxvFefpUywvDw:-KSjojYreAV_NeTmG3l9:b95c7s4) ([raw file](https://github.com/dgraph-io/perf/blob/d61b58509a397d350acbc7c23f2b797524463ec6/main.go#L286)):*\n<details><summary><i>Previously, pawanrawal (Pawan Rawal) wrote…</i></summary>\n> Can you check what is the convention for naming views and APIs in Go and their functions?\n</details>\nok will do and update according to naming convention.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/dgraph-io/perf/4)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"adishap"}}