{"action":"created","comment":{"url":"https://api.github.com/repos/SUSE/kiwi/pulls/comments/55035232","id":55035232,"diff_hunk":"@@ -271,12 +270,14 @@ def setup_disk_boot_images(self, boot_uuid, lookup_path=None):\n             by the distribution. The bios core image is created\n             when grub2-install is called\n         \"\"\"\n-        log.info('Creating grub bootloader images')\n+        self.__copy_theme_data_to_boot_directory(lookup_path)\n \n-        if self.firmware.efi_mode():\n-            self.efi_boot_path = self.create_efi_path()\n+        if not self.firmware.efi_mode():\n+            return\n \n-        self.__copy_theme_data_to_boot_directory(lookup_path)\n+        log.info('Creating grub bootloader images')\n+\n+        self.efi_boot_path = self.create_efi_path()\n ","path":"kiwi/bootloader/config/grub2.py","position":42,"original_position":42,"commit_id":"0af878bc3d75e058006013f65b08f1ef580ea971","original_commit_id":"0af878bc3d75e058006013f65b08f1ef580ea971","user":{"login":"schaefi","id":912234,"avatar_url":"https://avatars.githubusercontent.com/u/912234?v=3","gravatar_id":"","url":"https://api.github.com/users/schaefi","html_url":"https://github.com/schaefi","followers_url":"https://api.github.com/users/schaefi/followers","following_url":"https://api.github.com/users/schaefi/following{/other_user}","gists_url":"https://api.github.com/users/schaefi/gists{/gist_id}","starred_url":"https://api.github.com/users/schaefi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schaefi/subscriptions","organizations_url":"https://api.github.com/users/schaefi/orgs","repos_url":"https://api.github.com/users/schaefi/repos","events_url":"https://api.github.com/users/schaefi/events{/privacy}","received_events_url":"https://api.github.com/users/schaefi/received_events","type":"User","site_admin":false},"body":"ok so with the return you want to skip the creation of the efi image which is architecture specific, got that. But with ppc we set firmware to 'ofw' which means the efi part is not touched. I agree we have to make the creation of the efi module architecture dependant (for e.g arm this has to change) but for the ppc support there is no need to touch it now or am I mistaken ?\r\n\r\nI'd like to keep this changeset as clear and small and ppc focused as possible. This is because when I look at the old kiwi code things are so weird and unclear that I'd like to avoid it this time. Thanks","created_at":"2016-03-04T14:26:52Z","updated_at":"2016-03-04T14:26:52Z","html_url":"https://github.com/SUSE/kiwi/pull/35#discussion_r55035232","pull_request_url":"https://api.github.com/repos/SUSE/kiwi/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/SUSE/kiwi/pulls/comments/55035232"},"html":{"href":"https://github.com/SUSE/kiwi/pull/35#discussion_r55035232"},"pull_request":{"href":"https://api.github.com/repos/SUSE/kiwi/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/SUSE/kiwi/pulls/35","id":61162073,"html_url":"https://github.com/SUSE/kiwi/pull/35","diff_url":"https://github.com/SUSE/kiwi/pull/35.diff","patch_url":"https://github.com/SUSE/kiwi/pull/35.patch","issue_url":"https://api.github.com/repos/SUSE/kiwi/issues/35","number":35,"state":"open","locked":false,"title":"Power","user":{"login":"k0da","id":1101460,"avatar_url":"https://avatars.githubusercontent.com/u/1101460?v=3","gravatar_id":"","url":"https://api.github.com/users/k0da","html_url":"https://github.com/k0da","followers_url":"https://api.github.com/users/k0da/followers","following_url":"https://api.github.com/users/k0da/following{/other_user}","gists_url":"https://api.github.com/users/k0da/gists{/gist_id}","starred_url":"https://api.github.com/users/k0da/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k0da/subscriptions","organizations_url":"https://api.github.com/users/k0da/orgs","repos_url":"https://api.github.com/users/k0da/repos","events_url":"https://api.github.com/users/k0da/events{/privacy}","received_events_url":"https://api.github.com/users/k0da/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-02-29T23:03:20Z","updated_at":"2016-03-04T14:26:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98051fd16bee1c7c15cc92dabf3c2e93bf1894c0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SUSE/kiwi/pulls/35/commits","review_comments_url":"https://api.github.com/repos/SUSE/kiwi/pulls/35/comments","review_comment_url":"https://api.github.com/repos/SUSE/kiwi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE/kiwi/issues/35/comments","statuses_url":"https://api.github.com/repos/SUSE/kiwi/statuses/0af878bc3d75e058006013f65b08f1ef580ea971","head":{"label":"k0da:POWER","ref":"POWER","sha":"0af878bc3d75e058006013f65b08f1ef580ea971","user":{"login":"k0da","id":1101460,"avatar_url":"https://avatars.githubusercontent.com/u/1101460?v=3","gravatar_id":"","url":"https://api.github.com/users/k0da","html_url":"https://github.com/k0da","followers_url":"https://api.github.com/users/k0da/followers","following_url":"https://api.github.com/users/k0da/following{/other_user}","gists_url":"https://api.github.com/users/k0da/gists{/gist_id}","starred_url":"https://api.github.com/users/k0da/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k0da/subscriptions","organizations_url":"https://api.github.com/users/k0da/orgs","repos_url":"https://api.github.com/users/k0da/repos","events_url":"https://api.github.com/users/k0da/events{/privacy}","received_events_url":"https://api.github.com/users/k0da/received_events","type":"User","site_admin":false},"repo":{"id":51548327,"name":"kiwi-1","full_name":"k0da/kiwi-1","owner":{"login":"k0da","id":1101460,"avatar_url":"https://avatars.githubusercontent.com/u/1101460?v=3","gravatar_id":"","url":"https://api.github.com/users/k0da","html_url":"https://github.com/k0da","followers_url":"https://api.github.com/users/k0da/followers","following_url":"https://api.github.com/users/k0da/following{/other_user}","gists_url":"https://api.github.com/users/k0da/gists{/gist_id}","starred_url":"https://api.github.com/users/k0da/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k0da/subscriptions","organizations_url":"https://api.github.com/users/k0da/orgs","repos_url":"https://api.github.com/users/k0da/repos","events_url":"https://api.github.com/users/k0da/events{/privacy}","received_events_url":"https://api.github.com/users/k0da/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/k0da/kiwi-1","description":"KIWI - appliance builder next generation","fork":true,"url":"https://api.github.com/repos/k0da/kiwi-1","forks_url":"https://api.github.com/repos/k0da/kiwi-1/forks","keys_url":"https://api.github.com/repos/k0da/kiwi-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/k0da/kiwi-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/k0da/kiwi-1/teams","hooks_url":"https://api.github.com/repos/k0da/kiwi-1/hooks","issue_events_url":"https://api.github.com/repos/k0da/kiwi-1/issues/events{/number}","events_url":"https://api.github.com/repos/k0da/kiwi-1/events","assignees_url":"https://api.github.com/repos/k0da/kiwi-1/assignees{/user}","branches_url":"https://api.github.com/repos/k0da/kiwi-1/branches{/branch}","tags_url":"https://api.github.com/repos/k0da/kiwi-1/tags","blobs_url":"https://api.github.com/repos/k0da/kiwi-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/k0da/kiwi-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/k0da/kiwi-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/k0da/kiwi-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/k0da/kiwi-1/statuses/{sha}","languages_url":"https://api.github.com/repos/k0da/kiwi-1/languages","stargazers_url":"https://api.github.com/repos/k0da/kiwi-1/stargazers","contributors_url":"https://api.github.com/repos/k0da/kiwi-1/contributors","subscribers_url":"https://api.github.com/repos/k0da/kiwi-1/subscribers","subscription_url":"https://api.github.com/repos/k0da/kiwi-1/subscription","commits_url":"https://api.github.com/repos/k0da/kiwi-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/k0da/kiwi-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/k0da/kiwi-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/k0da/kiwi-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/k0da/kiwi-1/contents/{+path}","compare_url":"https://api.github.com/repos/k0da/kiwi-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/k0da/kiwi-1/merges","archive_url":"https://api.github.com/repos/k0da/kiwi-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/k0da/kiwi-1/downloads","issues_url":"https://api.github.com/repos/k0da/kiwi-1/issues{/number}","pulls_url":"https://api.github.com/repos/k0da/kiwi-1/pulls{/number}","milestones_url":"https://api.github.com/repos/k0da/kiwi-1/milestones{/number}","notifications_url":"https://api.github.com/repos/k0da/kiwi-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/k0da/kiwi-1/labels{/name}","releases_url":"https://api.github.com/repos/k0da/kiwi-1/releases{/id}","deployments_url":"https://api.github.com/repos/k0da/kiwi-1/deployments","created_at":"2016-02-11T21:29:05Z","updated_at":"2016-02-11T21:29:07Z","pushed_at":"2016-03-02T13:00:12Z","git_url":"git://github.com/k0da/kiwi-1.git","ssh_url":"git@github.com:k0da/kiwi-1.git","clone_url":"https://github.com/k0da/kiwi-1.git","svn_url":"https://github.com/k0da/kiwi-1","homepage":null,"size":3610,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SUSE:master","ref":"master","sha":"ecc351a6b9e1a87985820aac74974111d7419559","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":47460440,"name":"kiwi","full_name":"SUSE/kiwi","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars.githubusercontent.com/u/1067733?v=3","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/kiwi","description":"KIWI - appliance builder next generation","fork":false,"url":"https://api.github.com/repos/SUSE/kiwi","forks_url":"https://api.github.com/repos/SUSE/kiwi/forks","keys_url":"https://api.github.com/repos/SUSE/kiwi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/kiwi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/kiwi/teams","hooks_url":"https://api.github.com/repos/SUSE/kiwi/hooks","issue_events_url":"https://api.github.com/repos/SUSE/kiwi/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/kiwi/events","assignees_url":"https://api.github.com/repos/SUSE/kiwi/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/kiwi/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/kiwi/tags","blobs_url":"https://api.github.com/repos/SUSE/kiwi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/kiwi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/kiwi/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/kiwi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/kiwi/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/kiwi/languages","stargazers_url":"https://api.github.com/repos/SUSE/kiwi/stargazers","contributors_url":"https://api.github.com/repos/SUSE/kiwi/contributors","subscribers_url":"https://api.github.com/repos/SUSE/kiwi/subscribers","subscription_url":"https://api.github.com/repos/SUSE/kiwi/subscription","commits_url":"https://api.github.com/repos/SUSE/kiwi/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/kiwi/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/kiwi/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/kiwi/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/kiwi/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/kiwi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/kiwi/merges","archive_url":"https://api.github.com/repos/SUSE/kiwi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/kiwi/downloads","issues_url":"https://api.github.com/repos/SUSE/kiwi/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/kiwi/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/kiwi/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/kiwi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/kiwi/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/kiwi/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE/kiwi/deployments","created_at":"2015-12-05T15:11:01Z","updated_at":"2016-01-20T16:53:14Z","pushed_at":"2016-03-04T09:03:05Z","git_url":"git://github.com/SUSE/kiwi.git","ssh_url":"git@github.com:SUSE/kiwi.git","clone_url":"https://github.com/SUSE/kiwi.git","svn_url":"https://github.com/SUSE/kiwi","homepage":null,"size":3739,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":13,"forks":4,"open_issues":13,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE/kiwi/pulls/35"},"html":{"href":"https://github.com/SUSE/kiwi/pull/35"},"issue":{"href":"https://api.github.com/repos/SUSE/kiwi/issues/35"},"comments":{"href":"https://api.github.com/repos/SUSE/kiwi/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE/kiwi/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE/kiwi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE/kiwi/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE/kiwi/statuses/0af878bc3d75e058006013f65b08f1ef580ea971"}}}}