{"action":"created","comment":{"url":"https://api.github.com/repos/haskell/cabal/pulls/comments/77455571","id":77455571,"diff_hunk":"@@ -535,10 +535,19 @@ data ProjectPackageLocation =\n -- | Exception thrown by 'findProjectPackages'.\n --\n newtype BadPackageLocations = BadPackageLocations [BadPackageLocation]\n+#if MIN_VERSION_base(4,8,0)\n   deriving (Show, Typeable)\n+#else\n+  deriving (Typeable)\n \n-instance Exception BadPackageLocations\n---TODO: [required eventually] displayException for nice rendering\n+instance Show BadPackageLocations where","path":"cabal-install/Distribution/Client/ProjectConfig.hs","position":11,"original_position":11,"commit_id":"b2c587b20996b0b0a20d6ec875b43ee05b3192be","original_commit_id":"b2c587b20996b0b0a20d6ec875b43ee05b3192be","user":{"login":"ezyang","id":13564,"avatar_url":"https://avatars.githubusercontent.com/u/13564?v=3","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"body":"I don't like this Show instance; Show should print out a Haskell style message. Maybe we should add an Outputable type class for pretty-printable entities.","created_at":"2016-09-04T16:54:39Z","updated_at":"2016-09-04T16:54:39Z","html_url":"https://github.com/haskell/cabal/pull/3774#discussion_r77455571","pull_request_url":"https://api.github.com/repos/haskell/cabal/pulls/3774","_links":{"self":{"href":"https://api.github.com/repos/haskell/cabal/pulls/comments/77455571"},"html":{"href":"https://github.com/haskell/cabal/pull/3774#discussion_r77455571"},"pull_request":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3774"}}},"pull_request":{"url":"https://api.github.com/repos/haskell/cabal/pulls/3774","id":83909671,"html_url":"https://github.com/haskell/cabal/pull/3774","diff_url":"https://github.com/haskell/cabal/pull/3774.diff","patch_url":"https://github.com/haskell/cabal/pull/3774.patch","issue_url":"https://api.github.com/repos/haskell/cabal/issues/3774","number":3774,"state":"open","locked":false,"title":"Error messages for package locations","user":{"login":"dcoutts","id":1339423,"avatar_url":"https://avatars.githubusercontent.com/u/1339423?v=3","gravatar_id":"","url":"https://api.github.com/users/dcoutts","html_url":"https://github.com/dcoutts","followers_url":"https://api.github.com/users/dcoutts/followers","following_url":"https://api.github.com/users/dcoutts/following{/other_user}","gists_url":"https://api.github.com/users/dcoutts/gists{/gist_id}","starred_url":"https://api.github.com/users/dcoutts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcoutts/subscriptions","organizations_url":"https://api.github.com/users/dcoutts/orgs","repos_url":"https://api.github.com/users/dcoutts/repos","events_url":"https://api.github.com/users/dcoutts/events{/privacy}","received_events_url":"https://api.github.com/users/dcoutts/received_events","type":"User","site_admin":false},"body":"This is for the \"packages: blah/*/\" locations in cabal.project files, when they don't match anything or match crazy unrecognised stuff. Previously we just used the derived Show.\r\n\r\nAlso improve classification of project package problems in a couple cases so we get more accurate helpful error messages in those cases.\r\n\r\nShould improve #3636, but that one could be better since it's for the special case of an implicit project file.","created_at":"2016-09-04T00:22:55Z","updated_at":"2016-09-04T16:54:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0fc6f4753b773d68b245186b894533e0756fc51","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/haskell/cabal/pulls/3774/commits","review_comments_url":"https://api.github.com/repos/haskell/cabal/pulls/3774/comments","review_comment_url":"https://api.github.com/repos/haskell/cabal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haskell/cabal/issues/3774/comments","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/b2c587b20996b0b0a20d6ec875b43ee05b3192be","head":{"label":"dcoutts:error-messages-for-package-locations","ref":"error-messages-for-package-locations","sha":"b2c587b20996b0b0a20d6ec875b43ee05b3192be","user":{"login":"dcoutts","id":1339423,"avatar_url":"https://avatars.githubusercontent.com/u/1339423?v=3","gravatar_id":"","url":"https://api.github.com/users/dcoutts","html_url":"https://github.com/dcoutts","followers_url":"https://api.github.com/users/dcoutts/followers","following_url":"https://api.github.com/users/dcoutts/following{/other_user}","gists_url":"https://api.github.com/users/dcoutts/gists{/gist_id}","starred_url":"https://api.github.com/users/dcoutts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcoutts/subscriptions","organizations_url":"https://api.github.com/users/dcoutts/orgs","repos_url":"https://api.github.com/users/dcoutts/repos","events_url":"https://api.github.com/users/dcoutts/events{/privacy}","received_events_url":"https://api.github.com/users/dcoutts/received_events","type":"User","site_admin":false},"repo":{"id":10475196,"name":"cabal","full_name":"dcoutts/cabal","owner":{"login":"dcoutts","id":1339423,"avatar_url":"https://avatars.githubusercontent.com/u/1339423?v=3","gravatar_id":"","url":"https://api.github.com/users/dcoutts","html_url":"https://github.com/dcoutts","followers_url":"https://api.github.com/users/dcoutts/followers","following_url":"https://api.github.com/users/dcoutts/following{/other_user}","gists_url":"https://api.github.com/users/dcoutts/gists{/gist_id}","starred_url":"https://api.github.com/users/dcoutts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcoutts/subscriptions","organizations_url":"https://api.github.com/users/dcoutts/orgs","repos_url":"https://api.github.com/users/dcoutts/repos","events_url":"https://api.github.com/users/dcoutts/events{/privacy}","received_events_url":"https://api.github.com/users/dcoutts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcoutts/cabal","description":"Duncan's random Cabal hacking","fork":true,"url":"https://api.github.com/repos/dcoutts/cabal","forks_url":"https://api.github.com/repos/dcoutts/cabal/forks","keys_url":"https://api.github.com/repos/dcoutts/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcoutts/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcoutts/cabal/teams","hooks_url":"https://api.github.com/repos/dcoutts/cabal/hooks","issue_events_url":"https://api.github.com/repos/dcoutts/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/dcoutts/cabal/events","assignees_url":"https://api.github.com/repos/dcoutts/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/dcoutts/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/dcoutts/cabal/tags","blobs_url":"https://api.github.com/repos/dcoutts/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcoutts/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcoutts/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcoutts/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcoutts/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/dcoutts/cabal/languages","stargazers_url":"https://api.github.com/repos/dcoutts/cabal/stargazers","contributors_url":"https://api.github.com/repos/dcoutts/cabal/contributors","subscribers_url":"https://api.github.com/repos/dcoutts/cabal/subscribers","subscription_url":"https://api.github.com/repos/dcoutts/cabal/subscription","commits_url":"https://api.github.com/repos/dcoutts/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcoutts/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcoutts/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcoutts/cabal/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcoutts/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/dcoutts/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcoutts/cabal/merges","archive_url":"https://api.github.com/repos/dcoutts/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcoutts/cabal/downloads","issues_url":"https://api.github.com/repos/dcoutts/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/dcoutts/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/dcoutts/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/dcoutts/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcoutts/cabal/labels{/name}","releases_url":"https://api.github.com/repos/dcoutts/cabal/releases{/id}","deployments_url":"https://api.github.com/repos/dcoutts/cabal/deployments","created_at":"2013-06-04T09:31:49Z","updated_at":"2015-04-28T14:55:48Z","pushed_at":"2016-09-04T13:33:19Z","git_url":"git://github.com/dcoutts/cabal.git","ssh_url":"git@github.com:dcoutts/cabal.git","clone_url":"https://github.com/dcoutts/cabal.git","svn_url":"https://github.com/dcoutts/cabal","homepage":"http://haskell.org/cabal","size":27410,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"haskell:master","ref":"master","sha":"3cd4f0c41c41b7c3bfe46609840d0d3d1a12980f","user":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"repo":{"id":3728161,"name":"cabal","full_name":"haskell/cabal","owner":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell/cabal","description":"Official upstream development repository for Cabal and cabal-install","fork":false,"url":"https://api.github.com/repos/haskell/cabal","forks_url":"https://api.github.com/repos/haskell/cabal/forks","keys_url":"https://api.github.com/repos/haskell/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell/cabal/teams","hooks_url":"https://api.github.com/repos/haskell/cabal/hooks","issue_events_url":"https://api.github.com/repos/haskell/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/haskell/cabal/events","assignees_url":"https://api.github.com/repos/haskell/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/haskell/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/haskell/cabal/tags","blobs_url":"https://api.github.com/repos/haskell/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell/cabal/languages","stargazers_url":"https://api.github.com/repos/haskell/cabal/stargazers","contributors_url":"https://api.github.com/repos/haskell/cabal/contributors","subscribers_url":"https://api.github.com/repos/haskell/cabal/subscribers","subscription_url":"https://api.github.com/repos/haskell/cabal/subscription","commits_url":"https://api.github.com/repos/haskell/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell/cabal/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/haskell/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell/cabal/merges","archive_url":"https://api.github.com/repos/haskell/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell/cabal/downloads","issues_url":"https://api.github.com/repos/haskell/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/haskell/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell/cabal/labels{/name}","releases_url":"https://api.github.com/repos/haskell/cabal/releases{/id}","deployments_url":"https://api.github.com/repos/haskell/cabal/deployments","created_at":"2012-03-15T12:53:38Z","updated_at":"2016-09-02T19:35:18Z","pushed_at":"2016-09-04T16:05:49Z","git_url":"git://github.com/haskell/cabal.git","ssh_url":"git@github.com:haskell/cabal.git","clone_url":"https://github.com/haskell/cabal.git","svn_url":"https://github.com/haskell/cabal","homepage":"http://haskell.org/cabal","size":32241,"stargazers_count":635,"watchers_count":635,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":338,"mirror_url":null,"open_issues_count":740,"forks":338,"open_issues":740,"watchers":635,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3774"},"html":{"href":"https://github.com/haskell/cabal/pull/3774"},"issue":{"href":"https://api.github.com/repos/haskell/cabal/issues/3774"},"comments":{"href":"https://api.github.com/repos/haskell/cabal/issues/3774/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3774/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell/cabal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3774/commits"},"statuses":{"href":"https://api.github.com/repos/haskell/cabal/statuses/b2c587b20996b0b0a20d6ec875b43ee05b3192be"}}}}
{"actor":{"display_login":"ezyang"}}