{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/82766211","pull_request_review_id":3649809,"id":82766211,"diff_hunk":"@@ -76,155 +72,45 @@ func (h *HostHelper) EnsureVolumeShare() error {\n \treturn nil\n }\n \n-func catHostFile(hostFile string) string {\n-\tfile := path.Join(\"/rootfs\", hostFile)\n-\treturn fmt.Sprintf(\"cat %s\", file)\n-}\n-\n-// CopyFromHost copies a set of files from the Docker host to the local file system\n-func (h *HostHelper) CopyFromHost(sourceDir, destDir string) error {\n+// DownloadDirFromContainer copies a set of files from the Docker host to the local file system\n+func (h *HostHelper) DownloadDirFromContainer(sourceDir, destDir string) error {","path":"pkg/bootstrap/docker/host/host.go","position":31,"original_position":31,"commit_id":"b59a884de3b3e210e3c08575fa0759e3ecf884c8","original_commit_id":"b59a884de3b3e210e3c08575fa0759e3ecf884c8","user":{"login":"jim-minter","id":1038301,"avatar_url":"https://avatars.githubusercontent.com/u/1038301?v=3","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"body":"I was hoping to leave these names more broad to signpost a single path for down/uploading arbitrary files from the container, if required in the future for whatever reason.  If necessary this may entail adding in the other bind mounts up top, but I left those out for now.  What's best to do here?","created_at":"2016-10-11T10:36:53Z","updated_at":"2016-10-11T10:36:53Z","html_url":"https://github.com/openshift/origin/pull/11171#discussion_r82766211","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/11171","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/82766211"},"html":{"href":"https://github.com/openshift/origin/pull/11171#discussion_r82766211"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/11171"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/11171","id":87476149,"html_url":"https://github.com/openshift/origin/pull/11171","diff_url":"https://github.com/openshift/origin/pull/11171.diff","patch_url":"https://github.com/openshift/origin/pull/11171.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/11171","number":11171,"state":"open","locked":false,"title":"Implement cluster status command, fixes #9935","user":{"login":"jim-minter","id":1038301,"avatar_url":"https://avatars.githubusercontent.com/u/1038301?v=3","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"body":"Fixes #9935 ","created_at":"2016-09-30T11:18:03Z","updated_at":"2016-10-11T10:36:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"128b8010a2636ff304e1dbcddb43098c4ba91e6d","assignee":{"login":"csrwng","id":5834976,"avatar_url":"https://avatars.githubusercontent.com/u/5834976?v=3","gravatar_id":"","url":"https://api.github.com/users/csrwng","html_url":"https://github.com/csrwng","followers_url":"https://api.github.com/users/csrwng/followers","following_url":"https://api.github.com/users/csrwng/following{/other_user}","gists_url":"https://api.github.com/users/csrwng/gists{/gist_id}","starred_url":"https://api.github.com/users/csrwng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrwng/subscriptions","organizations_url":"https://api.github.com/users/csrwng/orgs","repos_url":"https://api.github.com/users/csrwng/repos","events_url":"https://api.github.com/users/csrwng/events{/privacy}","received_events_url":"https://api.github.com/users/csrwng/received_events","type":"User","site_admin":false},"assignees":[{"login":"csrwng","id":5834976,"avatar_url":"https://avatars.githubusercontent.com/u/5834976?v=3","gravatar_id":"","url":"https://api.github.com/users/csrwng","html_url":"https://github.com/csrwng","followers_url":"https://api.github.com/users/csrwng/followers","following_url":"https://api.github.com/users/csrwng/following{/other_user}","gists_url":"https://api.github.com/users/csrwng/gists{/gist_id}","starred_url":"https://api.github.com/users/csrwng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrwng/subscriptions","organizations_url":"https://api.github.com/users/csrwng/orgs","repos_url":"https://api.github.com/users/csrwng/repos","events_url":"https://api.github.com/users/csrwng/events{/privacy}","received_events_url":"https://api.github.com/users/csrwng/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/11171/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/11171/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/11171/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/b59a884de3b3e210e3c08575fa0759e3ecf884c8","head":{"label":"jim-minter:issue9935","ref":"issue9935","sha":"b59a884de3b3e210e3c08575fa0759e3ecf884c8","user":{"login":"jim-minter","id":1038301,"avatar_url":"https://avatars.githubusercontent.com/u/1038301?v=3","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"repo":{"id":63237830,"name":"origin","full_name":"jim-minter/origin","owner":{"login":"jim-minter","id":1038301,"avatar_url":"https://avatars.githubusercontent.com/u/1038301?v=3","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jim-minter/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":true,"url":"https://api.github.com/repos/jim-minter/origin","forks_url":"https://api.github.com/repos/jim-minter/origin/forks","keys_url":"https://api.github.com/repos/jim-minter/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jim-minter/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jim-minter/origin/teams","hooks_url":"https://api.github.com/repos/jim-minter/origin/hooks","issue_events_url":"https://api.github.com/repos/jim-minter/origin/issues/events{/number}","events_url":"https://api.github.com/repos/jim-minter/origin/events","assignees_url":"https://api.github.com/repos/jim-minter/origin/assignees{/user}","branches_url":"https://api.github.com/repos/jim-minter/origin/branches{/branch}","tags_url":"https://api.github.com/repos/jim-minter/origin/tags","blobs_url":"https://api.github.com/repos/jim-minter/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jim-minter/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jim-minter/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jim-minter/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jim-minter/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/jim-minter/origin/languages","stargazers_url":"https://api.github.com/repos/jim-minter/origin/stargazers","contributors_url":"https://api.github.com/repos/jim-minter/origin/contributors","subscribers_url":"https://api.github.com/repos/jim-minter/origin/subscribers","subscription_url":"https://api.github.com/repos/jim-minter/origin/subscription","commits_url":"https://api.github.com/repos/jim-minter/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jim-minter/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jim-minter/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jim-minter/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jim-minter/origin/contents/{+path}","compare_url":"https://api.github.com/repos/jim-minter/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jim-minter/origin/merges","archive_url":"https://api.github.com/repos/jim-minter/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jim-minter/origin/downloads","issues_url":"https://api.github.com/repos/jim-minter/origin/issues{/number}","pulls_url":"https://api.github.com/repos/jim-minter/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/jim-minter/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/jim-minter/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jim-minter/origin/labels{/name}","releases_url":"https://api.github.com/repos/jim-minter/origin/releases{/id}","deployments_url":"https://api.github.com/repos/jim-minter/origin/deployments","created_at":"2016-07-13T10:39:40Z","updated_at":"2016-07-13T10:39:49Z","pushed_at":"2016-10-11T10:27:52Z","git_url":"git://github.com/jim-minter/origin.git","ssh_url":"git@github.com:jim-minter/origin.git","clone_url":"https://github.com/jim-minter/origin.git","svn_url":"https://github.com/jim-minter/origin","homepage":"http://www.openshift.org","size":342654,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"6eafc1da61df6091597193b589e70c0e70274ad2","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2016-10-11T02:54:53Z","pushed_at":"2016-10-11T10:21:40Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":595146,"stargazers_count":1822,"watchers_count":1822,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1208,"mirror_url":null,"open_issues_count":1237,"forks":1208,"open_issues":1237,"watchers":1822,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/11171"},"html":{"href":"https://github.com/openshift/origin/pull/11171"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/11171"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/11171/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/11171/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/11171/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/b59a884de3b3e210e3c08575fa0759e3ecf884c8"}}}}
{"actor":{"display_login":"jim-minter"}}