{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/teach.mozilla.org/issues/1615","repository_url":"https://api.github.com/repos/mozilla/teach.mozilla.org","labels_url":"https://api.github.com/repos/mozilla/teach.mozilla.org/issues/1615/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/teach.mozilla.org/issues/1615/comments","events_url":"https://api.github.com/repos/mozilla/teach.mozilla.org/issues/1615/events","html_url":"https://github.com/mozilla/teach.mozilla.org/pull/1615","id":130594671,"number":1615,"title":"Preparing `router` context for migration","user":{"login":"Pomax","id":177243,"avatar_url":"https://avatars.githubusercontent.com/u/177243?v=3","gravatar_id":"","url":"https://api.github.com/users/Pomax","html_url":"https://github.com/Pomax","followers_url":"https://api.github.com/users/Pomax/followers","following_url":"https://api.github.com/users/Pomax/following{/other_user}","gists_url":"https://api.github.com/users/Pomax/gists{/gist_id}","starred_url":"https://api.github.com/users/Pomax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pomax/subscriptions","organizations_url":"https://api.github.com/users/Pomax/orgs","repos_url":"https://api.github.com/users/Pomax/repos","events_url":"https://api.github.com/users/Pomax/events{/privacy}","received_events_url":"https://api.github.com/users/Pomax/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/teach.mozilla.org/labels/build-system","name":"build-system","color":"fef2c0"},{"url":"https://api.github.com/repos/mozilla/teach.mozilla.org/labels/PR%20needs%20review","name":"PR needs review","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"mmmavis","id":2896608,"avatar_url":"https://avatars.githubusercontent.com/u/2896608?v=3","gravatar_id":"","url":"https://api.github.com/users/mmmavis","html_url":"https://github.com/mmmavis","followers_url":"https://api.github.com/users/mmmavis/followers","following_url":"https://api.github.com/users/mmmavis/following{/other_user}","gists_url":"https://api.github.com/users/mmmavis/gists{/gist_id}","starred_url":"https://api.github.com/users/mmmavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmmavis/subscriptions","organizations_url":"https://api.github.com/users/mmmavis/orgs","repos_url":"https://api.github.com/users/mmmavis/repos","events_url":"https://api.github.com/users/mmmavis/events{/privacy}","received_events_url":"https://api.github.com/users/mmmavis/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/mozilla/teach.mozilla.org/milestones/34","html_url":"https://github.com/mozilla/teach.mozilla.org/milestones/Feb%2012","labels_url":"https://api.github.com/repos/mozilla/teach.mozilla.org/milestones/34/labels","id":1470067,"number":34,"title":"Feb 12","description":"","creator":{"login":"hannahkane","id":8389648,"avatar_url":"https://avatars.githubusercontent.com/u/8389648?v=3","gravatar_id":"","url":"https://api.github.com/users/hannahkane","html_url":"https://github.com/hannahkane","followers_url":"https://api.github.com/users/hannahkane/followers","following_url":"https://api.github.com/users/hannahkane/following{/other_user}","gists_url":"https://api.github.com/users/hannahkane/gists{/gist_id}","starred_url":"https://api.github.com/users/hannahkane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannahkane/subscriptions","organizations_url":"https://api.github.com/users/hannahkane/orgs","repos_url":"https://api.github.com/users/hannahkane/repos","events_url":"https://api.github.com/users/hannahkane/events{/privacy}","received_events_url":"https://api.github.com/users/hannahkane/received_events","type":"User","site_admin":false},"open_issues":35,"closed_issues":11,"state":"open","created_at":"2015-12-21T18:51:35Z","updated_at":"2016-02-03T22:50:59Z","due_on":"2016-02-12T08:00:00Z","closed_at":null},"comments":1,"created_at":"2016-02-02T06:56:32Z","updated_at":"2016-02-03T23:50:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/teach.mozilla.org/pulls/1615","html_url":"https://github.com/mozilla/teach.mozilla.org/pull/1615","diff_url":"https://github.com/mozilla/teach.mozilla.org/pull/1615.diff","patch_url":"https://github.com/mozilla/teach.mozilla.org/pull/1615.patch"},"body":"Some cleanup around how the Page and current router are used in the code, and the router context (which is `this.props.router` in react-router 1.0)\r\n\r\nThese changes pass all tests, but there are warnings about setState() for the Select component being called while it's not mounted. This suggests that the modal for it expires during testing, but it also doesn't seem to affect testing, so something odd is going on here.\r\n\r\nNote that some files were touched in order to make the test log less polluted."},"comment":{"url":"https://api.github.com/repos/mozilla/teach.mozilla.org/issues/comments/179536301","html_url":"https://github.com/mozilla/teach.mozilla.org/pull/1615#issuecomment-179536301","issue_url":"https://api.github.com/repos/mozilla/teach.mozilla.org/issues/1615","id":179536301,"user":{"login":"mmmavis","id":2896608,"avatar_url":"https://avatars.githubusercontent.com/u/2896608?v=3","gravatar_id":"","url":"https://api.github.com/users/mmmavis","html_url":"https://github.com/mmmavis","followers_url":"https://api.github.com/users/mmmavis/followers","following_url":"https://api.github.com/users/mmmavis/following{/other_user}","gists_url":"https://api.github.com/users/mmmavis/gists{/gist_id}","starred_url":"https://api.github.com/users/mmmavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmmavis/subscriptions","organizations_url":"https://api.github.com/users/mmmavis/orgs","repos_url":"https://api.github.com/users/mmmavis/repos","events_url":"https://api.github.com/users/mmmavis/events{/privacy}","received_events_url":"https://api.github.com/users/mmmavis/received_events","type":"User","site_admin":false},"created_at":"2016-02-03T23:50:30Z","updated_at":"2016-02-03T23:50:30Z","body":"PR looks good to me. I wish there's some built-in router icon that I could attach here though. :stuck_out_tongue_winking_eye: "}}