{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/14718","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/14718/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/14718/comments","events_url":"https://api.github.com/repos/apache/spark/issues/14718/events","html_url":"https://github.com/apache/spark/pull/14718","id":172142775,"number":14718,"title":"[SPARK-16711] YarnShuffleService doesn't re-init properly on YARN rolling upgrade","user":{"login":"tgravescs","id":4563792,"avatar_url":"https://avatars.githubusercontent.com/u/4563792?v=3","gravatar_id":"","url":"https://api.github.com/users/tgravescs","html_url":"https://github.com/tgravescs","followers_url":"https://api.github.com/users/tgravescs/followers","following_url":"https://api.github.com/users/tgravescs/following{/other_user}","gists_url":"https://api.github.com/users/tgravescs/gists{/gist_id}","starred_url":"https://api.github.com/users/tgravescs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgravescs/subscriptions","organizations_url":"https://api.github.com/users/tgravescs/orgs","repos_url":"https://api.github.com/users/tgravescs/repos","events_url":"https://api.github.com/users/tgravescs/events{/privacy}","received_events_url":"https://api.github.com/users/tgravescs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2016-08-19T14:23:57Z","updated_at":"2016-08-30T23:05:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/14718","html_url":"https://github.com/apache/spark/pull/14718","diff_url":"https://github.com/apache/spark/pull/14718.diff","patch_url":"https://github.com/apache/spark/pull/14718.patch"},"body":"The Spark Yarn Shuffle Service doesn't re-initialize the application credentials early enough which causes any other spark executors trying to fetch from that node during a rolling upgrade to fail with \"java.lang.NullPointerException: Password cannot be null if SASL is enabled\".  Right now the spark shuffle service relies on the Yarn nodemanager to re-register the applications, unfortunately this is after we open the port for other executors to connect. If other executors connected before the re-register they get a null pointer exception which isn't a re-tryable exception and cause them to fail pretty quickly. To solve this I added another leveldb file so that it can save and re-initialize all the applications before opening the port for other executors to connect to it.  Adding another leveldb was simpler from the code structure point of view.\r\n\r\nMost of the code changes are moving things to common util class.\r\n\r\nPatch was tested manually on a Yarn cluster with rolling upgrade was happing while spark job was running. Without the patch I consistently get the NullPointerException, with the patch the job gets a few Connection refused exceptions but the retries kick in and the it succeeds."},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/243609417","html_url":"https://github.com/apache/spark/pull/14718#issuecomment-243609417","issue_url":"https://api.github.com/repos/apache/spark/issues/14718","id":243609417,"user":{"login":"AmplabJenkins","id":4031291,"avatar_url":"https://avatars.githubusercontent.com/u/4031291?v=3","gravatar_id":"","url":"https://api.github.com/users/AmplabJenkins","html_url":"https://github.com/AmplabJenkins","followers_url":"https://api.github.com/users/AmplabJenkins/followers","following_url":"https://api.github.com/users/AmplabJenkins/following{/other_user}","gists_url":"https://api.github.com/users/AmplabJenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/AmplabJenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmplabJenkins/subscriptions","organizations_url":"https://api.github.com/users/AmplabJenkins/orgs","repos_url":"https://api.github.com/users/AmplabJenkins/repos","events_url":"https://api.github.com/users/AmplabJenkins/events{/privacy}","received_events_url":"https://api.github.com/users/AmplabJenkins/received_events","type":"User","site_admin":false},"created_at":"2016-08-30T23:05:29Z","updated_at":"2016-08-30T23:05:29Z","body":"Test PASSed.\nRefer to this link for build results (access rights to CI server needed): \nhttps://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64674/\nTest PASSed."}}
{"actor":{"display_login":"AmplabJenkins"}}