{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/48725010","id":48725010,"diff_hunk":"@@ -504,13 +504,14 @@ boolean checkInvocationTimeout() {\n         long maxCallTimeout = invocationFuture.getMaxCallTimeout();\n         long expirationTime = op.getInvocationTime() + maxCallTimeout;\n \n+        boolean done = invocationFuture.isDone();\n         boolean hasResponse = pendingResponse != null;\n         boolean hasWaitingThreads = invocationFuture.getWaitingThreadsCount() > 0;\n         boolean notExpired = maxCallTimeout == Long.MAX_VALUE\n                 || expirationTime < 0\n                 || expirationTime >= Clock.currentTimeMillis();\n \n-        if (hasResponse || hasWaitingThreads || notExpired) {\n+        if (hasResponse || hasWaitingThreads || notExpired || done) {","path":"hazelcast/src/main/java/com/hazelcast/spi/impl/operationservice/impl/Invocation.java","position":12,"original_position":12,"commit_id":"ae65541dbc3c02a7a9569bb4e3c0fe4a1ba5bb03","original_commit_id":"070c04956f115cfffa7070af28e5382ad2c997c1","user":{"login":"eminn","id":378108,"avatar_url":"https://avatars.githubusercontent.com/u/378108?v=3","gravatar_id":"","url":"https://api.github.com/users/eminn","html_url":"https://github.com/eminn","followers_url":"https://api.github.com/users/eminn/followers","following_url":"https://api.github.com/users/eminn/following{/other_user}","gists_url":"https://api.github.com/users/eminn/gists{/gist_id}","starred_url":"https://api.github.com/users/eminn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eminn/subscriptions","organizations_url":"https://api.github.com/users/eminn/orgs","repos_url":"https://api.github.com/users/eminn/repos","events_url":"https://api.github.com/users/eminn/events{/privacy}","received_events_url":"https://api.github.com/users/eminn/received_events","type":"User","site_admin":false},"body":"It is checked in the context of `stuck` case in combination of callId matching. This is just for if the invocation is done, do not make any attempt to ask if it's still running. ","created_at":"2016-01-04T12:05:16Z","updated_at":"2016-01-04T12:05:16Z","html_url":"https://github.com/hazelcast/hazelcast/pull/7203#discussion_r48725010","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7203","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/48725010"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/7203#discussion_r48725010"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7203"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7203","id":54650605,"html_url":"https://github.com/hazelcast/hazelcast/pull/7203","diff_url":"https://github.com/hazelcast/hazelcast/pull/7203.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/7203.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/7203","number":7203,"state":"open","locked":false,"title":"Fixes repeatedly checks made from InvocationMonitor for timeout","user":{"login":"eminn","id":378108,"avatar_url":"https://avatars.githubusercontent.com/u/378108?v=3","gravatar_id":"","url":"https://api.github.com/users/eminn","html_url":"https://github.com/eminn","followers_url":"https://api.github.com/users/eminn/followers","following_url":"https://api.github.com/users/eminn/following{/other_user}","gists_url":"https://api.github.com/users/eminn/gists{/gist_id}","starred_url":"https://api.github.com/users/eminn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eminn/subscriptions","organizations_url":"https://api.github.com/users/eminn/orgs","repos_url":"https://api.github.com/users/eminn/repos","events_url":"https://api.github.com/users/eminn/events{/privacy}","received_events_url":"https://api.github.com/users/eminn/received_events","type":"User","site_admin":false},"body":"Fixes #7170","created_at":"2015-12-28T12:02:38Z","updated_at":"2016-01-04T12:05:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17e83fb6e37a6dff7a520508e172c3fb656b499b","assignee":null,"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/61","html_url":"https://github.com/hazelcast/hazelcast/milestones/3.6","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/61/labels","id":982584,"number":61,"title":"3.6","description":"","creator":{"login":"enesakar","id":234086,"avatar_url":"https://avatars.githubusercontent.com/u/234086?v=3","gravatar_id":"","url":"https://api.github.com/users/enesakar","html_url":"https://github.com/enesakar","followers_url":"https://api.github.com/users/enesakar/followers","following_url":"https://api.github.com/users/enesakar/following{/other_user}","gists_url":"https://api.github.com/users/enesakar/gists{/gist_id}","starred_url":"https://api.github.com/users/enesakar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enesakar/subscriptions","organizations_url":"https://api.github.com/users/enesakar/orgs","repos_url":"https://api.github.com/users/enesakar/repos","events_url":"https://api.github.com/users/enesakar/events{/privacy}","received_events_url":"https://api.github.com/users/enesakar/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":1190,"state":"open","created_at":"2015-02-17T09:27:09Z","updated_at":"2016-01-04T11:30:58Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7203/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7203/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/7203/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/ae65541dbc3c02a7a9569bb4e3c0fe4a1ba5bb03","head":{"label":"eminn:fix/invocation-retry","ref":"fix/invocation-retry","sha":"ae65541dbc3c02a7a9569bb4e3c0fe4a1ba5bb03","user":{"login":"eminn","id":378108,"avatar_url":"https://avatars.githubusercontent.com/u/378108?v=3","gravatar_id":"","url":"https://api.github.com/users/eminn","html_url":"https://github.com/eminn","followers_url":"https://api.github.com/users/eminn/followers","following_url":"https://api.github.com/users/eminn/following{/other_user}","gists_url":"https://api.github.com/users/eminn/gists{/gist_id}","starred_url":"https://api.github.com/users/eminn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eminn/subscriptions","organizations_url":"https://api.github.com/users/eminn/orgs","repos_url":"https://api.github.com/users/eminn/repos","events_url":"https://api.github.com/users/eminn/events{/privacy}","received_events_url":"https://api.github.com/users/eminn/received_events","type":"User","site_admin":false},"repo":{"id":6697413,"name":"hazelcast","full_name":"eminn/hazelcast","owner":{"login":"eminn","id":378108,"avatar_url":"https://avatars.githubusercontent.com/u/378108?v=3","gravatar_id":"","url":"https://api.github.com/users/eminn","html_url":"https://github.com/eminn","followers_url":"https://api.github.com/users/eminn/followers","following_url":"https://api.github.com/users/eminn/following{/other_user}","gists_url":"https://api.github.com/users/eminn/gists{/gist_id}","starred_url":"https://api.github.com/users/eminn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eminn/subscriptions","organizations_url":"https://api.github.com/users/eminn/orgs","repos_url":"https://api.github.com/users/eminn/repos","events_url":"https://api.github.com/users/eminn/events{/privacy}","received_events_url":"https://api.github.com/users/eminn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eminn/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/eminn/hazelcast","forks_url":"https://api.github.com/repos/eminn/hazelcast/forks","keys_url":"https://api.github.com/repos/eminn/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eminn/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eminn/hazelcast/teams","hooks_url":"https://api.github.com/repos/eminn/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/eminn/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/eminn/hazelcast/events","assignees_url":"https://api.github.com/repos/eminn/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/eminn/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/eminn/hazelcast/tags","blobs_url":"https://api.github.com/repos/eminn/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eminn/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eminn/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/eminn/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eminn/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/eminn/hazelcast/languages","stargazers_url":"https://api.github.com/repos/eminn/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/eminn/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/eminn/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/eminn/hazelcast/subscription","commits_url":"https://api.github.com/repos/eminn/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/eminn/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/eminn/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/eminn/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/eminn/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/eminn/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eminn/hazelcast/merges","archive_url":"https://api.github.com/repos/eminn/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eminn/hazelcast/downloads","issues_url":"https://api.github.com/repos/eminn/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/eminn/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/eminn/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/eminn/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eminn/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/eminn/hazelcast/releases{/id}","created_at":"2012-11-15T00:39:03Z","updated_at":"2015-11-19T21:10:34Z","pushed_at":"2015-12-31T11:25:55Z","git_url":"git://github.com/eminn/hazelcast.git","ssh_url":"git@github.com:eminn/hazelcast.git","clone_url":"https://github.com/eminn/hazelcast.git","svn_url":"https://github.com/eminn/hazelcast","homepage":"www.hazelcast.com","size":82588,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"48c3f0915b525edee144cecb234bbf77bb457a1d","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","created_at":"2012-03-21T12:25:18Z","updated_at":"2016-01-04T05:29:25Z","pushed_at":"2016-01-04T11:30:59Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":95072,"stargazers_count":1357,"watchers_count":1357,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":670,"mirror_url":null,"open_issues_count":498,"forks":670,"open_issues":498,"watchers":1357,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7203"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/7203"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/7203"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/7203/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7203/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/7203/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/ae65541dbc3c02a7a9569bb4e3c0fe4a1ba5bb03"}}}}