{"action":"created","comment":{"url":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/comments/91638640","pull_request_review_id":12149034,"id":91638640,"diff_hunk":"@@ -42,19 +42,19 @@\n     private BaseHelper mHelper;\n     @Nullable private SaveSmartLock mSmartLock;\n     private IdpResponse mResponse;\n-    private int mAccountLinkResultCode;\n+    private int mAccountLinkRequestCode;\n \n     public CredentialSignInHandler(\n             Activity activity,\n             BaseHelper helper,\n             @Nullable SaveSmartLock smartLock,\n-            int accountLinkResultCode,\n+            int accountLinkRequestCode,\n             IdpResponse response) {\n         mActivity = activity;\n         mHelper = helper;\n         mSmartLock = smartLock;\n         mResponse = response;\n-        mAccountLinkResultCode = accountLinkResultCode;\n+        mAccountLinkRequestCode = accountLinkRequestCode;","path":"auth/src/main/java/com/firebase/ui/auth/ui/idp/CredentialSignInHandler.java","position":19,"original_position":19,"commit_id":"3f79b339536844d674f369297db1d6a1bbd64922","original_commit_id":"52734c42f9d36ffcdd877212cf7e594311f6fbd3","user":{"login":"SUPERCILEX","id":9490724,"avatar_url":"https://avatars.githubusercontent.com/u/9490724?v=3","gravatar_id":"","url":"https://api.github.com/users/SUPERCILEX","html_url":"https://github.com/SUPERCILEX","followers_url":"https://api.github.com/users/SUPERCILEX/followers","following_url":"https://api.github.com/users/SUPERCILEX/following{/other_user}","gists_url":"https://api.github.com/users/SUPERCILEX/gists{/gist_id}","starred_url":"https://api.github.com/users/SUPERCILEX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUPERCILEX/subscriptions","organizations_url":"https://api.github.com/users/SUPERCILEX/orgs","repos_url":"https://api.github.com/users/SUPERCILEX/repos","events_url":"https://api.github.com/users/SUPERCILEX/events{/privacy}","received_events_url":"https://api.github.com/users/SUPERCILEX/received_events","type":"User","site_admin":false},"body":"Looks like a typo.","created_at":"2016-12-09T00:33:51Z","updated_at":"2016-12-09T00:41:02Z","html_url":"https://github.com/firebase/FirebaseUI-Android/pull/309#discussion_r91638640","pull_request_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/309","_links":{"self":{"href":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/comments/91638640"},"html":{"href":"https://github.com/firebase/FirebaseUI-Android/pull/309#discussion_r91638640"},"pull_request":{"href":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/309"}}},"pull_request":{"url":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/309","id":85685146,"html_url":"https://github.com/firebase/FirebaseUI-Android/pull/309","diff_url":"https://github.com/firebase/FirebaseUI-Android/pull/309.diff","patch_url":"https://github.com/firebase/FirebaseUI-Android/pull/309.patch","issue_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/309","number":309,"state":"open","locked":false,"title":"Support for linking accounts","user":{"login":"SUPERCILEX","id":9490724,"avatar_url":"https://avatars.githubusercontent.com/u/9490724?v=3","gravatar_id":"","url":"https://api.github.com/users/SUPERCILEX","html_url":"https://github.com/SUPERCILEX","followers_url":"https://api.github.com/users/SUPERCILEX/followers","following_url":"https://api.github.com/users/SUPERCILEX/following{/other_user}","gists_url":"https://api.github.com/users/SUPERCILEX/gists{/gist_id}","starred_url":"https://api.github.com/users/SUPERCILEX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUPERCILEX/subscriptions","organizations_url":"https://api.github.com/users/SUPERCILEX/orgs","repos_url":"https://api.github.com/users/SUPERCILEX/repos","events_url":"https://api.github.com/users/SUPERCILEX/events{/privacy}","received_events_url":"https://api.github.com/users/SUPERCILEX/received_events","type":"User","site_admin":false},"body":"If this has been discussed in an issue, make sure to mention the issue number here.  If not, go file an issue about this to make sure this is a desirable change.\r\n- https://github.com/firebase/FirebaseUI-Android/issues/123\r\n- https://github.com/firebase/FirebaseUI-Android/issues/228\r\n\r\nIf this is a new feature please co-ordinate with someone on [FirebaseUI-iOS](https://github.com/firebase/firebaseui-ios) to make sure that we can implement this on both platforms and maintain feature parity.\r\n- Anyone?\r\n\r\nTODO:\r\n- [x] Make sure linking non-anonymous accounts works\r\n- [x] Add documentation\r\n- [x] Update sample\r\n- [x] Wait for #254 to get merged\r\n- [x] Add tests\r\n- [x] Update documentation to `IdpResponse`\r\n- [x] Fix profile and name not being added (turns out this is also caused by #409)","created_at":"2016-09-17T19:50:01Z","updated_at":"2016-12-09T00:41:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c498da3323caa6926118c0655a366290545a262c","assignee":{"login":"amandle","id":879468,"avatar_url":"https://avatars.githubusercontent.com/u/879468?v=3","gravatar_id":"","url":"https://api.github.com/users/amandle","html_url":"https://github.com/amandle","followers_url":"https://api.github.com/users/amandle/followers","following_url":"https://api.github.com/users/amandle/following{/other_user}","gists_url":"https://api.github.com/users/amandle/gists{/gist_id}","starred_url":"https://api.github.com/users/amandle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amandle/subscriptions","organizations_url":"https://api.github.com/users/amandle/orgs","repos_url":"https://api.github.com/users/amandle/repos","events_url":"https://api.github.com/users/amandle/events{/privacy}","received_events_url":"https://api.github.com/users/amandle/received_events","type":"User","site_admin":false},"assignees":[{"login":"amandle","id":879468,"avatar_url":"https://avatars.githubusercontent.com/u/879468?v=3","gravatar_id":"","url":"https://api.github.com/users/amandle","html_url":"https://github.com/amandle","followers_url":"https://api.github.com/users/amandle/followers","following_url":"https://api.github.com/users/amandle/following{/other_user}","gists_url":"https://api.github.com/users/amandle/gists{/gist_id}","starred_url":"https://api.github.com/users/amandle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amandle/subscriptions","organizations_url":"https://api.github.com/users/amandle/orgs","repos_url":"https://api.github.com/users/amandle/repos","events_url":"https://api.github.com/users/amandle/events{/privacy}","received_events_url":"https://api.github.com/users/amandle/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/309/commits","review_comments_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/309/comments","review_comment_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/309/comments","statuses_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/statuses/3f79b339536844d674f369297db1d6a1bbd64922","head":{"label":"SUPERCILEX:anonymous-auth","ref":"anonymous-auth","sha":"3f79b339536844d674f369297db1d6a1bbd64922","user":{"login":"SUPERCILEX","id":9490724,"avatar_url":"https://avatars.githubusercontent.com/u/9490724?v=3","gravatar_id":"","url":"https://api.github.com/users/SUPERCILEX","html_url":"https://github.com/SUPERCILEX","followers_url":"https://api.github.com/users/SUPERCILEX/followers","following_url":"https://api.github.com/users/SUPERCILEX/following{/other_user}","gists_url":"https://api.github.com/users/SUPERCILEX/gists{/gist_id}","starred_url":"https://api.github.com/users/SUPERCILEX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUPERCILEX/subscriptions","organizations_url":"https://api.github.com/users/SUPERCILEX/orgs","repos_url":"https://api.github.com/users/SUPERCILEX/repos","events_url":"https://api.github.com/users/SUPERCILEX/events{/privacy}","received_events_url":"https://api.github.com/users/SUPERCILEX/received_events","type":"User","site_admin":false},"repo":{"id":67086210,"name":"FirebaseUI-Android","full_name":"SUPERCILEX/FirebaseUI-Android","owner":{"login":"SUPERCILEX","id":9490724,"avatar_url":"https://avatars.githubusercontent.com/u/9490724?v=3","gravatar_id":"","url":"https://api.github.com/users/SUPERCILEX","html_url":"https://github.com/SUPERCILEX","followers_url":"https://api.github.com/users/SUPERCILEX/followers","following_url":"https://api.github.com/users/SUPERCILEX/following{/other_user}","gists_url":"https://api.github.com/users/SUPERCILEX/gists{/gist_id}","starred_url":"https://api.github.com/users/SUPERCILEX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUPERCILEX/subscriptions","organizations_url":"https://api.github.com/users/SUPERCILEX/orgs","repos_url":"https://api.github.com/users/SUPERCILEX/repos","events_url":"https://api.github.com/users/SUPERCILEX/events{/privacy}","received_events_url":"https://api.github.com/users/SUPERCILEX/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SUPERCILEX/FirebaseUI-Android","description":null,"fork":true,"url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android","forks_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/forks","keys_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/teams","hooks_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/hooks","issue_events_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/issues/events{/number}","events_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/events","assignees_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/assignees{/user}","branches_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/branches{/branch}","tags_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/tags","blobs_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/languages","stargazers_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/stargazers","contributors_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/contributors","subscribers_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/subscribers","subscription_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/subscription","commits_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/contents/{+path}","compare_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/merges","archive_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/downloads","issues_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/issues{/number}","pulls_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/labels{/name}","releases_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/releases{/id}","deployments_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/deployments","created_at":"2016-09-01T01:14:01Z","updated_at":"2016-11-14T02:05:15Z","pushed_at":"2016-12-09T00:40:01Z","git_url":"git://github.com/SUPERCILEX/FirebaseUI-Android.git","ssh_url":"git@github.com:SUPERCILEX/FirebaseUI-Android.git","clone_url":"https://github.com/SUPERCILEX/FirebaseUI-Android.git","svn_url":"https://github.com/SUPERCILEX/FirebaseUI-Android","homepage":null,"size":17258,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"firebase:version-1.1.0-dev","ref":"version-1.1.0-dev","sha":"ff427d6b9c485bf7f4bbb7c85fa48e00b46086cb","user":{"login":"firebase","id":1335026,"avatar_url":"https://avatars.githubusercontent.com/u/1335026?v=3","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":38835213,"name":"FirebaseUI-Android","full_name":"firebase/FirebaseUI-Android","owner":{"login":"firebase","id":1335026,"avatar_url":"https://avatars.githubusercontent.com/u/1335026?v=3","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firebase/FirebaseUI-Android","description":"UI bindings for Firebase","fork":false,"url":"https://api.github.com/repos/firebase/FirebaseUI-Android","forks_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/forks","keys_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/teams","hooks_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/hooks","issue_events_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/events","assignees_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/tags","blobs_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/languages","stargazers_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/stargazers","contributors_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/contributors","subscribers_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/subscribers","subscription_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/subscription","commits_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/merges","archive_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/downloads","issues_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/labels{/name}","releases_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/deployments","created_at":"2015-07-09T17:31:09Z","updated_at":"2016-12-08T16:59:07Z","pushed_at":"2016-12-09T00:40:01Z","git_url":"git://github.com/firebase/FirebaseUI-Android.git","ssh_url":"git@github.com:firebase/FirebaseUI-Android.git","clone_url":"https://github.com/firebase/FirebaseUI-Android.git","svn_url":"https://github.com/firebase/FirebaseUI-Android","homepage":"","size":18401,"stargazers_count":1269,"watchers_count":1269,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":423,"mirror_url":null,"open_issues_count":40,"forks":423,"open_issues":40,"watchers":1269,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/309"},"html":{"href":"https://github.com/firebase/FirebaseUI-Android/pull/309"},"issue":{"href":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/309"},"comments":{"href":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/309/comments"},"review_comments":{"href":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/309/comments"},"review_comment":{"href":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/309/commits"},"statuses":{"href":"https://api.github.com/repos/firebase/FirebaseUI-Android/statuses/3f79b339536844d674f369297db1d6a1bbd64922"}}}}
{"actor":{"display_login":"SUPERCILEX"}}