{"action":"created","comment":{"url":"https://api.github.com/repos/scrapinghub/splash/pulls/comments/75668394","id":75668394,"diff_hunk":"@@ -1116,6 +1193,176 @@ def log(self, message, min_level=None):\n         log.msg(message, system='render')\n \n \n+class ElementsStorage(QObject):\n+    \"\"\"\n+    Object that allows to store JavaScript Node objects.\n+\n+    This creates a JavaScript-compatible object (can be added to `window`)\n+    that has `get_id()` function which can be called from JavaScript for\n+    retrieving a unique id for each Node object\n+    \"\"\"\n+    def __init__(self, parent):\n+        self.name = self.get_id()","path":"splash/browser_tab.py","position":185,"original_position":185,"commit_id":"3b56f5c9505ad1ae4effac91c5774442c3119775","original_commit_id":"3b56f5c9505ad1ae4effac91c5774442c3119775","user":{"login":"kmike","id":107893,"avatar_url":"https://avatars.githubusercontent.com/u/107893?v=3","gravatar_id":"","url":"https://api.github.com/users/kmike","html_url":"https://github.com/kmike","followers_url":"https://api.github.com/users/kmike/followers","following_url":"https://api.github.com/users/kmike/following{/other_user}","gists_url":"https://api.github.com/users/kmike/gists{/gist_id}","starred_url":"https://api.github.com/users/kmike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmike/subscriptions","organizations_url":"https://api.github.com/users/kmike/orgs","repos_url":"https://api.github.com/users/kmike/repos","events_url":"https://api.github.com/users/kmike/events{/privacy}","received_events_url":"https://api.github.com/users/kmike/received_events","type":"User","site_admin":false},"body":"imho just `get_id()` is more clear here, as the id is not related","created_at":"2016-08-22T12:32:38Z","updated_at":"2016-08-22T12:32:38Z","html_url":"https://github.com/scrapinghub/splash/pull/490#discussion_r75668394","pull_request_url":"https://api.github.com/repos/scrapinghub/splash/pulls/490","_links":{"self":{"href":"https://api.github.com/repos/scrapinghub/splash/pulls/comments/75668394"},"html":{"href":"https://github.com/scrapinghub/splash/pull/490#discussion_r75668394"},"pull_request":{"href":"https://api.github.com/repos/scrapinghub/splash/pulls/490"}}},"pull_request":{"url":"https://api.github.com/repos/scrapinghub/splash/pulls/490","id":79774522,"html_url":"https://github.com/scrapinghub/splash/pull/490","diff_url":"https://github.com/scrapinghub/splash/pull/490.diff","patch_url":"https://github.com/scrapinghub/splash/pull/490.patch","issue_url":"https://api.github.com/repos/scrapinghub/splash/issues/490","number":490,"state":"open","locked":false,"title":"[WIP] splash:select, DOM elements manipulating helpers","user":{"login":"mike1808","id":3942554,"avatar_url":"https://avatars.githubusercontent.com/u/3942554?v=3","gravatar_id":"","url":"https://api.github.com/users/mike1808","html_url":"https://github.com/mike1808","followers_url":"https://api.github.com/users/mike1808/followers","following_url":"https://api.github.com/users/mike1808/following{/other_user}","gists_url":"https://api.github.com/users/mike1808/gists{/gist_id}","starred_url":"https://api.github.com/users/mike1808/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike1808/subscriptions","organizations_url":"https://api.github.com/users/mike1808/orgs","repos_url":"https://api.github.com/users/mike1808/repos","events_url":"https://api.github.com/users/mike1808/events{/privacy}","received_events_url":"https://api.github.com/users/mike1808/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-02T17:21:55Z","updated_at":"2016-08-22T12:32:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2efc57731301e484a05eb5554ea7c999c2c23a44","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scrapinghub/splash/pulls/490/commits","review_comments_url":"https://api.github.com/repos/scrapinghub/splash/pulls/490/comments","review_comment_url":"https://api.github.com/repos/scrapinghub/splash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scrapinghub/splash/issues/490/comments","statuses_url":"https://api.github.com/repos/scrapinghub/splash/statuses/3b56f5c9505ad1ae4effac91c5774442c3119775","head":{"label":"mike1808:elements-event-handlers","ref":"elements-event-handlers","sha":"3b56f5c9505ad1ae4effac91c5774442c3119775","user":{"login":"mike1808","id":3942554,"avatar_url":"https://avatars.githubusercontent.com/u/3942554?v=3","gravatar_id":"","url":"https://api.github.com/users/mike1808","html_url":"https://github.com/mike1808","followers_url":"https://api.github.com/users/mike1808/followers","following_url":"https://api.github.com/users/mike1808/following{/other_user}","gists_url":"https://api.github.com/users/mike1808/gists{/gist_id}","starred_url":"https://api.github.com/users/mike1808/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike1808/subscriptions","organizations_url":"https://api.github.com/users/mike1808/orgs","repos_url":"https://api.github.com/users/mike1808/repos","events_url":"https://api.github.com/users/mike1808/events{/privacy}","received_events_url":"https://api.github.com/users/mike1808/received_events","type":"User","site_admin":false},"repo":{"id":54326662,"name":"splash","full_name":"mike1808/splash","owner":{"login":"mike1808","id":3942554,"avatar_url":"https://avatars.githubusercontent.com/u/3942554?v=3","gravatar_id":"","url":"https://api.github.com/users/mike1808","html_url":"https://github.com/mike1808","followers_url":"https://api.github.com/users/mike1808/followers","following_url":"https://api.github.com/users/mike1808/following{/other_user}","gists_url":"https://api.github.com/users/mike1808/gists{/gist_id}","starred_url":"https://api.github.com/users/mike1808/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike1808/subscriptions","organizations_url":"https://api.github.com/users/mike1808/orgs","repos_url":"https://api.github.com/users/mike1808/repos","events_url":"https://api.github.com/users/mike1808/events{/privacy}","received_events_url":"https://api.github.com/users/mike1808/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mike1808/splash","description":"Lightweight, scriptable browser as a service with an HTTP API","fork":true,"url":"https://api.github.com/repos/mike1808/splash","forks_url":"https://api.github.com/repos/mike1808/splash/forks","keys_url":"https://api.github.com/repos/mike1808/splash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mike1808/splash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mike1808/splash/teams","hooks_url":"https://api.github.com/repos/mike1808/splash/hooks","issue_events_url":"https://api.github.com/repos/mike1808/splash/issues/events{/number}","events_url":"https://api.github.com/repos/mike1808/splash/events","assignees_url":"https://api.github.com/repos/mike1808/splash/assignees{/user}","branches_url":"https://api.github.com/repos/mike1808/splash/branches{/branch}","tags_url":"https://api.github.com/repos/mike1808/splash/tags","blobs_url":"https://api.github.com/repos/mike1808/splash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mike1808/splash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mike1808/splash/git/refs{/sha}","trees_url":"https://api.github.com/repos/mike1808/splash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mike1808/splash/statuses/{sha}","languages_url":"https://api.github.com/repos/mike1808/splash/languages","stargazers_url":"https://api.github.com/repos/mike1808/splash/stargazers","contributors_url":"https://api.github.com/repos/mike1808/splash/contributors","subscribers_url":"https://api.github.com/repos/mike1808/splash/subscribers","subscription_url":"https://api.github.com/repos/mike1808/splash/subscription","commits_url":"https://api.github.com/repos/mike1808/splash/commits{/sha}","git_commits_url":"https://api.github.com/repos/mike1808/splash/git/commits{/sha}","comments_url":"https://api.github.com/repos/mike1808/splash/comments{/number}","issue_comment_url":"https://api.github.com/repos/mike1808/splash/issues/comments{/number}","contents_url":"https://api.github.com/repos/mike1808/splash/contents/{+path}","compare_url":"https://api.github.com/repos/mike1808/splash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mike1808/splash/merges","archive_url":"https://api.github.com/repos/mike1808/splash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mike1808/splash/downloads","issues_url":"https://api.github.com/repos/mike1808/splash/issues{/number}","pulls_url":"https://api.github.com/repos/mike1808/splash/pulls{/number}","milestones_url":"https://api.github.com/repos/mike1808/splash/milestones{/number}","notifications_url":"https://api.github.com/repos/mike1808/splash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mike1808/splash/labels{/name}","releases_url":"https://api.github.com/repos/mike1808/splash/releases{/id}","deployments_url":"https://api.github.com/repos/mike1808/splash/deployments","created_at":"2016-03-20T16:00:44Z","updated_at":"2016-03-20T16:00:45Z","pushed_at":"2016-08-22T12:12:14Z","git_url":"git://github.com/mike1808/splash.git","ssh_url":"git@github.com:mike1808/splash.git","clone_url":"https://github.com/mike1808/splash.git","svn_url":"https://github.com/mike1808/splash","homepage":"","size":3151,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scrapinghub:master","ref":"master","sha":"3caa40f1545c3cb3e70cd92ede044a185eac2623","user":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars.githubusercontent.com/u/699596?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"repo":{"id":10182205,"name":"splash","full_name":"scrapinghub/splash","owner":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars.githubusercontent.com/u/699596?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scrapinghub/splash","description":"Lightweight, scriptable browser as a service with an HTTP API","fork":false,"url":"https://api.github.com/repos/scrapinghub/splash","forks_url":"https://api.github.com/repos/scrapinghub/splash/forks","keys_url":"https://api.github.com/repos/scrapinghub/splash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrapinghub/splash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrapinghub/splash/teams","hooks_url":"https://api.github.com/repos/scrapinghub/splash/hooks","issue_events_url":"https://api.github.com/repos/scrapinghub/splash/issues/events{/number}","events_url":"https://api.github.com/repos/scrapinghub/splash/events","assignees_url":"https://api.github.com/repos/scrapinghub/splash/assignees{/user}","branches_url":"https://api.github.com/repos/scrapinghub/splash/branches{/branch}","tags_url":"https://api.github.com/repos/scrapinghub/splash/tags","blobs_url":"https://api.github.com/repos/scrapinghub/splash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrapinghub/splash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrapinghub/splash/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrapinghub/splash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrapinghub/splash/statuses/{sha}","languages_url":"https://api.github.com/repos/scrapinghub/splash/languages","stargazers_url":"https://api.github.com/repos/scrapinghub/splash/stargazers","contributors_url":"https://api.github.com/repos/scrapinghub/splash/contributors","subscribers_url":"https://api.github.com/repos/scrapinghub/splash/subscribers","subscription_url":"https://api.github.com/repos/scrapinghub/splash/subscription","commits_url":"https://api.github.com/repos/scrapinghub/splash/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrapinghub/splash/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrapinghub/splash/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrapinghub/splash/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrapinghub/splash/contents/{+path}","compare_url":"https://api.github.com/repos/scrapinghub/splash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrapinghub/splash/merges","archive_url":"https://api.github.com/repos/scrapinghub/splash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrapinghub/splash/downloads","issues_url":"https://api.github.com/repos/scrapinghub/splash/issues{/number}","pulls_url":"https://api.github.com/repos/scrapinghub/splash/pulls{/number}","milestones_url":"https://api.github.com/repos/scrapinghub/splash/milestones{/number}","notifications_url":"https://api.github.com/repos/scrapinghub/splash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrapinghub/splash/labels{/name}","releases_url":"https://api.github.com/repos/scrapinghub/splash/releases{/id}","deployments_url":"https://api.github.com/repos/scrapinghub/splash/deployments","created_at":"2013-05-20T21:20:33Z","updated_at":"2016-08-21T21:12:05Z","pushed_at":"2016-08-22T12:12:15Z","git_url":"git://github.com/scrapinghub/splash.git","ssh_url":"git@github.com:scrapinghub/splash.git","clone_url":"https://github.com/scrapinghub/splash.git","svn_url":"https://github.com/scrapinghub/splash","homepage":"","size":3811,"stargazers_count":823,"watchers_count":823,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":147,"mirror_url":null,"open_issues_count":102,"forks":147,"open_issues":102,"watchers":823,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scrapinghub/splash/pulls/490"},"html":{"href":"https://github.com/scrapinghub/splash/pull/490"},"issue":{"href":"https://api.github.com/repos/scrapinghub/splash/issues/490"},"comments":{"href":"https://api.github.com/repos/scrapinghub/splash/issues/490/comments"},"review_comments":{"href":"https://api.github.com/repos/scrapinghub/splash/pulls/490/comments"},"review_comment":{"href":"https://api.github.com/repos/scrapinghub/splash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scrapinghub/splash/pulls/490/commits"},"statuses":{"href":"https://api.github.com/repos/scrapinghub/splash/statuses/3b56f5c9505ad1ae4effac91c5774442c3119775"}}}}
{"actor":{"display_login":"kmike"}}