{"action":"created","comment":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/66200973","id":66200973,"diff_hunk":"@@ -7,7 +7,8 @@ <h4 class=\"show-for-small-only cc-text-light\" data-ng-bind=\"type.title\"></h4>\n     <div data-ng-if=\"item.values\">\n       <div data-ng-repeat=\"value in item.values track by $index\" class=\"cc-text-right\">\n         <div>\n-          <span data-ng-bind=\"'&nbsp;' + value.subvalue.join(' &bull; ')\"></span>\n+          <span data-ng-if=\"!value.isAmount\" data-ng-bind=\"'&nbsp;' + value.subvalue.join(' &bull; ')\"></span>","path":"src/assets/templates/widgets/finaid_awards_compare_summary.html","position":null,"original_position":5,"commit_id":"a578050ddf314275af2794d1efb19cdd4ccc77e9","original_commit_id":"405318f3e98a19ebaa4cb9837e74030fedb75e5d","user":{"login":"mDibyo","id":4902438,"avatar_url":"https://avatars.githubusercontent.com/u/4902438?v=3","gravatar_id":"","url":"https://api.github.com/users/mDibyo","html_url":"https://github.com/mDibyo","followers_url":"https://api.github.com/users/mDibyo/followers","following_url":"https://api.github.com/users/mDibyo/following{/other_user}","gists_url":"https://api.github.com/users/mDibyo/gists{/gist_id}","starred_url":"https://api.github.com/users/mDibyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mDibyo/subscriptions","organizations_url":"https://api.github.com/users/mDibyo/orgs","repos_url":"https://api.github.com/users/mDibyo/repos","events_url":"https://api.github.com/users/mDibyo/events{/privacy}","received_events_url":"https://api.github.com/users/mDibyo/received_events","type":"User","site_admin":false},"body":"@redconfetti @davidlimcheng I have addressed this. I am sorry for the delay.\r\n\r\nWhat you guys said makes sense. We want to be consistent. Directly making the change gave the following piece of code:\r\n```html\r\n<span data-ng-if=\"!value.isAmount\" data-ng-bind-template=\" {{ value.subvalue.join(' &bull; ') }}\"></span>\r\n```\r\nHere, the number of values being bound is still technically one. Since there can be a varying number of elements in the array `value.subvalue`, I couldn't think of a nice template to bind. I think this was the reason the previous version of the code had been written with the inconsistent ng-bind.\r\n\r\nSo I instead switched to what you see currently:\r\n```html\r\n<span data-ng-if=\"!value.isAmount\">\r\n  <span data-ng-repeat=\"subvalue in value.subvalue\">\r\n    <span data-ng-bind=\"subvalue\"></span>\r\n    <span data-ng-if=\"!$last\"> &bull; </span>\r\n  </span>\r\n</span>\r\n```\r\nI used ng-bind instead of ng-bind-template since now there's only one value. This seems to be a reasonably good solution. Let me know what you guys think.","created_at":"2016-06-08T06:56:25Z","updated_at":"2016-06-08T06:56:25Z","html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/5463#discussion_r66200973","pull_request_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5463","_links":{"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/66200973"},"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/5463#discussion_r66200973"},"pull_request":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5463"}}},"pull_request":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5463","id":71865577,"html_url":"https://github.com/ets-berkeley-edu/calcentral/pull/5463","diff_url":"https://github.com/ets-berkeley-edu/calcentral/pull/5463.diff","patch_url":"https://github.com/ets-berkeley-edu/calcentral/pull/5463.patch","issue_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/5463","number":5463,"state":"open","locked":false,"title":"SISRP-18680 FinAid Award Comparison Enrollment details unclear","user":{"login":"mDibyo","id":4902438,"avatar_url":"https://avatars.githubusercontent.com/u/4902438?v=3","gravatar_id":"","url":"https://api.github.com/users/mDibyo","html_url":"https://github.com/mDibyo","followers_url":"https://api.github.com/users/mDibyo/followers","following_url":"https://api.github.com/users/mDibyo/following{/other_user}","gists_url":"https://api.github.com/users/mDibyo/gists{/gist_id}","starred_url":"https://api.github.com/users/mDibyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mDibyo/subscriptions","organizations_url":"https://api.github.com/users/mDibyo/orgs","repos_url":"https://api.github.com/users/mDibyo/repos","events_url":"https://api.github.com/users/mDibyo/events{/privacy}","received_events_url":"https://api.github.com/users/mDibyo/received_events","type":"User","site_admin":false},"body":"https://jira.berkeley.edu/browse/SISRP-18680","created_at":"2016-05-30T07:58:40Z","updated_at":"2016-06-08T06:56:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86650139ced5603d4bc0c1707e65ff7954af2e7e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5463/commits","review_comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5463/comments","review_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/5463/comments","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/a578050ddf314275af2794d1efb19cdd4ccc77e9","head":{"label":"mDibyo:SISRP-18680","ref":"SISRP-18680","sha":"a578050ddf314275af2794d1efb19cdd4ccc77e9","user":{"login":"mDibyo","id":4902438,"avatar_url":"https://avatars.githubusercontent.com/u/4902438?v=3","gravatar_id":"","url":"https://api.github.com/users/mDibyo","html_url":"https://github.com/mDibyo","followers_url":"https://api.github.com/users/mDibyo/followers","following_url":"https://api.github.com/users/mDibyo/following{/other_user}","gists_url":"https://api.github.com/users/mDibyo/gists{/gist_id}","starred_url":"https://api.github.com/users/mDibyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mDibyo/subscriptions","organizations_url":"https://api.github.com/users/mDibyo/orgs","repos_url":"https://api.github.com/users/mDibyo/repos","events_url":"https://api.github.com/users/mDibyo/events{/privacy}","received_events_url":"https://api.github.com/users/mDibyo/received_events","type":"User","site_admin":false},"repo":{"id":35122515,"name":"calcentral","full_name":"mDibyo/calcentral","owner":{"login":"mDibyo","id":4902438,"avatar_url":"https://avatars.githubusercontent.com/u/4902438?v=3","gravatar_id":"","url":"https://api.github.com/users/mDibyo","html_url":"https://github.com/mDibyo","followers_url":"https://api.github.com/users/mDibyo/followers","following_url":"https://api.github.com/users/mDibyo/following{/other_user}","gists_url":"https://api.github.com/users/mDibyo/gists{/gist_id}","starred_url":"https://api.github.com/users/mDibyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mDibyo/subscriptions","organizations_url":"https://api.github.com/users/mDibyo/orgs","repos_url":"https://api.github.com/users/mDibyo/repos","events_url":"https://api.github.com/users/mDibyo/events{/privacy}","received_events_url":"https://api.github.com/users/mDibyo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mDibyo/calcentral","description":"","fork":true,"url":"https://api.github.com/repos/mDibyo/calcentral","forks_url":"https://api.github.com/repos/mDibyo/calcentral/forks","keys_url":"https://api.github.com/repos/mDibyo/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mDibyo/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mDibyo/calcentral/teams","hooks_url":"https://api.github.com/repos/mDibyo/calcentral/hooks","issue_events_url":"https://api.github.com/repos/mDibyo/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/mDibyo/calcentral/events","assignees_url":"https://api.github.com/repos/mDibyo/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/mDibyo/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/mDibyo/calcentral/tags","blobs_url":"https://api.github.com/repos/mDibyo/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mDibyo/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mDibyo/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/mDibyo/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mDibyo/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/mDibyo/calcentral/languages","stargazers_url":"https://api.github.com/repos/mDibyo/calcentral/stargazers","contributors_url":"https://api.github.com/repos/mDibyo/calcentral/contributors","subscribers_url":"https://api.github.com/repos/mDibyo/calcentral/subscribers","subscription_url":"https://api.github.com/repos/mDibyo/calcentral/subscription","commits_url":"https://api.github.com/repos/mDibyo/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/mDibyo/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/mDibyo/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/mDibyo/calcentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/mDibyo/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/mDibyo/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mDibyo/calcentral/merges","archive_url":"https://api.github.com/repos/mDibyo/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mDibyo/calcentral/downloads","issues_url":"https://api.github.com/repos/mDibyo/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/mDibyo/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/mDibyo/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/mDibyo/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mDibyo/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/mDibyo/calcentral/releases{/id}","deployments_url":"https://api.github.com/repos/mDibyo/calcentral/deployments","created_at":"2015-05-05T20:33:48Z","updated_at":"2016-05-23T00:56:37Z","pushed_at":"2016-06-08T06:49:29Z","git_url":"git://github.com/mDibyo/calcentral.git","ssh_url":"git@github.com:mDibyo/calcentral.git","clone_url":"https://github.com/mDibyo/calcentral.git","svn_url":"https://github.com/mDibyo/calcentral","homepage":"https://calcentral.berkeley.edu","size":24845,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ets-berkeley-edu:master","ref":"master","sha":"72352326b610cf4e28287ec6929772907b4f1915","user":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars.githubusercontent.com/u/283538?v=3","gravatar_id":"","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"repo":{"id":5483921,"name":"calcentral","full_name":"ets-berkeley-edu/calcentral","owner":{"login":"ets-berkeley-edu","id":283538,"avatar_url":"https://avatars.githubusercontent.com/u/283538?v=3","gravatar_id":"","url":"https://api.github.com/users/ets-berkeley-edu","html_url":"https://github.com/ets-berkeley-edu","followers_url":"https://api.github.com/users/ets-berkeley-edu/followers","following_url":"https://api.github.com/users/ets-berkeley-edu/following{/other_user}","gists_url":"https://api.github.com/users/ets-berkeley-edu/gists{/gist_id}","starred_url":"https://api.github.com/users/ets-berkeley-edu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ets-berkeley-edu/subscriptions","organizations_url":"https://api.github.com/users/ets-berkeley-edu/orgs","repos_url":"https://api.github.com/users/ets-berkeley-edu/repos","events_url":"https://api.github.com/users/ets-berkeley-edu/events{/privacy}","received_events_url":"https://api.github.com/users/ets-berkeley-edu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ets-berkeley-edu/calcentral","description":"","fork":false,"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral","forks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/forks","keys_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/teams","hooks_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/hooks","issue_events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/events{/number}","events_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/events","assignees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/assignees{/user}","branches_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/branches{/branch}","tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/tags","blobs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/refs{/sha}","trees_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/{sha}","languages_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/languages","stargazers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/stargazers","contributors_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contributors","subscribers_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscribers","subscription_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/subscription","commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/commits{/sha}","git_commits_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/git/commits{/sha}","comments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/comments{/number}","issue_comment_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/comments{/number}","contents_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/contents/{+path}","compare_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/merges","archive_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/downloads","issues_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues{/number}","pulls_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls{/number}","milestones_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/milestones{/number}","notifications_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/labels{/name}","releases_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/releases{/id}","deployments_url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/deployments","created_at":"2012-08-20T16:45:39Z","updated_at":"2016-05-12T08:33:52Z","pushed_at":"2016-06-08T06:49:30Z","git_url":"git://github.com/ets-berkeley-edu/calcentral.git","ssh_url":"git@github.com:ets-berkeley-edu/calcentral.git","clone_url":"https://github.com/ets-berkeley-edu/calcentral.git","svn_url":"https://github.com/ets-berkeley-edu/calcentral","homepage":"https://calcentral.berkeley.edu","size":28640,"stargazers_count":59,"watchers_count":59,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":2,"forks":60,"open_issues":2,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5463"},"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/5463"},"issue":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/5463"},"comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/issues/5463/comments"},"review_comments":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5463/comments"},"review_comment":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/5463/commits"},"statuses":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/statuses/a578050ddf314275af2794d1efb19cdd4ccc77e9"}}}}
{"actor":{"display_login":"mDibyo"}}