{"action":"opened","issue":{"url":"https://api.github.com/repos/MetaMask/provider-engine/issues/87","repository_url":"https://api.github.com/repos/MetaMask/provider-engine","labels_url":"https://api.github.com/repos/MetaMask/provider-engine/issues/87/labels{/name}","comments_url":"https://api.github.com/repos/MetaMask/provider-engine/issues/87/comments","events_url":"https://api.github.com/repos/MetaMask/provider-engine/issues/87/events","html_url":"https://github.com/MetaMask/provider-engine/issues/87","id":180519473,"number":87,"title":"Simplify hooked wallet subprovider","user":{"login":"flyswatter","id":542863,"avatar_url":"https://avatars.githubusercontent.com/u/542863?v=3","gravatar_id":"","url":"https://api.github.com/users/flyswatter","html_url":"https://github.com/flyswatter","followers_url":"https://api.github.com/users/flyswatter/followers","following_url":"https://api.github.com/users/flyswatter/following{/other_user}","gists_url":"https://api.github.com/users/flyswatter/gists{/gist_id}","starred_url":"https://api.github.com/users/flyswatter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flyswatter/subscriptions","organizations_url":"https://api.github.com/users/flyswatter/orgs","repos_url":"https://api.github.com/users/flyswatter/repos","events_url":"https://api.github.com/users/flyswatter/events{/privacy}","received_events_url":"https://api.github.com/users/flyswatter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-02T16:05:57Z","updated_at":"2016-10-02T16:05:57Z","closed_at":null,"body":"Right now the `hooked-wallet-subprovider` requires four methods to be implemented:\r\n\r\n- sendTransaction\r\n- sign\r\n- approveTx\r\n- approveMsg\r\n\r\nThe first two are pure equivalents of `web3.eth` methods, and the second two are used to prompt the user for confirmation, and call back with their responses.\r\n\r\nThis was confusing to a new user of provider-engine, and once I read it, it seemed strange to me, too.\r\n\r\nWhy not just provide the pure `web3` methods, and let the consumer deal with approving or throwing an error? It seems like this would make the module easier to understand for new users, while making it more flexible, too."}}
{"actor":{"display_login":"flyswatter"}}