{"action":"created","comment":{"url":"https://api.github.com/repos/fruux/sabre-dav/pulls/comments/69989074","id":69989074,"diff_hunk":"@@ -119,13 +119,15 @@ function getResponseProperties() {\n      */\n     function xmlSerialize(Writer $writer) {\n \n-        if ($status = $this->getHTTPStatus()) {\n+        $empty = true;\n+\n+        if ($status = $this->getHttpStatus()) {\n             $writer->writeElement('{DAV:}status', 'HTTP/1.1 ' . $status . ' ' . \\Sabre\\HTTP\\Response::$statusCodes[$status]);\n+            // in case of a 404 we simply don't expect any properties at all\n+            $empty = ($status !== 404);","path":"lib/DAV/Xml/Element/Response.php","position":19,"original_position":19,"commit_id":"583610af17e9f18001a9251a1eef889b1bf5ca81","original_commit_id":"583610af17e9f18001a9251a1eef889b1bf5ca81","user":{"login":"evert","id":178960,"avatar_url":"https://avatars.githubusercontent.com/u/178960?v=3","gravatar_id":"","url":"https://api.github.com/users/evert","html_url":"https://github.com/evert","followers_url":"https://api.github.com/users/evert/followers","following_url":"https://api.github.com/users/evert/following{/other_user}","gists_url":"https://api.github.com/users/evert/gists{/gist_id}","starred_url":"https://api.github.com/users/evert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evert/subscriptions","organizations_url":"https://api.github.com/users/evert/orgs","repos_url":"https://api.github.com/users/evert/repos","events_url":"https://api.github.com/users/evert/events{/privacy}","received_events_url":"https://api.github.com/users/evert/received_events","type":"User","site_admin":false},"body":"I think I don't like this line. Could it get removed?\r\n\r\nI don't think realistically that there might be a case where there's a resource-level 404 status, where we're returning properties anyway, but I don't really see a reason to special-case this.","created_at":"2016-07-07T21:18:39Z","updated_at":"2016-07-07T21:18:39Z","html_url":"https://github.com/fruux/sabre-dav/pull/830#discussion_r69989074","pull_request_url":"https://api.github.com/repos/fruux/sabre-dav/pulls/830","_links":{"self":{"href":"https://api.github.com/repos/fruux/sabre-dav/pulls/comments/69989074"},"html":{"href":"https://github.com/fruux/sabre-dav/pull/830#discussion_r69989074"},"pull_request":{"href":"https://api.github.com/repos/fruux/sabre-dav/pulls/830"}}},"pull_request":{"url":"https://api.github.com/repos/fruux/sabre-dav/pulls/830","id":68673048,"html_url":"https://github.com/fruux/sabre-dav/pull/830","diff_url":"https://github.com/fruux/sabre-dav/pull/830.diff","patch_url":"https://github.com/fruux/sabre-dav/pull/830.patch","issue_url":"https://api.github.com/repos/fruux/sabre-dav/issues/830","number":830,"state":"open","locked":false,"title":"Handle 404 in CardDAV multi get","user":{"login":"DeepDiver1975","id":1005065,"avatar_url":"https://avatars.githubusercontent.com/u/1005065?v=3","gravatar_id":"","url":"https://api.github.com/users/DeepDiver1975","html_url":"https://github.com/DeepDiver1975","followers_url":"https://api.github.com/users/DeepDiver1975/followers","following_url":"https://api.github.com/users/DeepDiver1975/following{/other_user}","gists_url":"https://api.github.com/users/DeepDiver1975/gists{/gist_id}","starred_url":"https://api.github.com/users/DeepDiver1975/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeepDiver1975/subscriptions","organizations_url":"https://api.github.com/users/DeepDiver1975/orgs","repos_url":"https://api.github.com/users/DeepDiver1975/repos","events_url":"https://api.github.com/users/DeepDiver1975/events{/privacy}","received_events_url":"https://api.github.com/users/DeepDiver1975/received_events","type":"User","site_admin":false},"body":" refs #829","created_at":"2016-05-03T08:32:01Z","updated_at":"2016-07-07T21:18:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"832409af03659a11ceacec5822e831760dc4ba0c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fruux/sabre-dav/pulls/830/commits","review_comments_url":"https://api.github.com/repos/fruux/sabre-dav/pulls/830/comments","review_comment_url":"https://api.github.com/repos/fruux/sabre-dav/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fruux/sabre-dav/issues/830/comments","statuses_url":"https://api.github.com/repos/fruux/sabre-dav/statuses/583610af17e9f18001a9251a1eef889b1bf5ca81","head":{"label":"DeepDiver1975:multiget-404","ref":"multiget-404","sha":"583610af17e9f18001a9251a1eef889b1bf5ca81","user":{"login":"DeepDiver1975","id":1005065,"avatar_url":"https://avatars.githubusercontent.com/u/1005065?v=3","gravatar_id":"","url":"https://api.github.com/users/DeepDiver1975","html_url":"https://github.com/DeepDiver1975","followers_url":"https://api.github.com/users/DeepDiver1975/followers","following_url":"https://api.github.com/users/DeepDiver1975/following{/other_user}","gists_url":"https://api.github.com/users/DeepDiver1975/gists{/gist_id}","starred_url":"https://api.github.com/users/DeepDiver1975/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeepDiver1975/subscriptions","organizations_url":"https://api.github.com/users/DeepDiver1975/orgs","repos_url":"https://api.github.com/users/DeepDiver1975/repos","events_url":"https://api.github.com/users/DeepDiver1975/events{/privacy}","received_events_url":"https://api.github.com/users/DeepDiver1975/received_events","type":"User","site_admin":false},"repo":{"id":15768058,"name":"sabre-dav","full_name":"DeepDiver1975/sabre-dav","owner":{"login":"DeepDiver1975","id":1005065,"avatar_url":"https://avatars.githubusercontent.com/u/1005065?v=3","gravatar_id":"","url":"https://api.github.com/users/DeepDiver1975","html_url":"https://github.com/DeepDiver1975","followers_url":"https://api.github.com/users/DeepDiver1975/followers","following_url":"https://api.github.com/users/DeepDiver1975/following{/other_user}","gists_url":"https://api.github.com/users/DeepDiver1975/gists{/gist_id}","starred_url":"https://api.github.com/users/DeepDiver1975/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeepDiver1975/subscriptions","organizations_url":"https://api.github.com/users/DeepDiver1975/orgs","repos_url":"https://api.github.com/users/DeepDiver1975/repos","events_url":"https://api.github.com/users/DeepDiver1975/events{/privacy}","received_events_url":"https://api.github.com/users/DeepDiver1975/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DeepDiver1975/sabre-dav","description":"SabreDAV is a WebDAV framework for PHP","fork":true,"url":"https://api.github.com/repos/DeepDiver1975/sabre-dav","forks_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/forks","keys_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/teams","hooks_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/hooks","issue_events_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/issues/events{/number}","events_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/events","assignees_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/assignees{/user}","branches_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/branches{/branch}","tags_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/tags","blobs_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/git/refs{/sha}","trees_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/statuses/{sha}","languages_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/languages","stargazers_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/stargazers","contributors_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/contributors","subscribers_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/subscribers","subscription_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/subscription","commits_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/commits{/sha}","git_commits_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/git/commits{/sha}","comments_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/comments{/number}","issue_comment_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/issues/comments{/number}","contents_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/contents/{+path}","compare_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/merges","archive_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/downloads","issues_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/issues{/number}","pulls_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/pulls{/number}","milestones_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/milestones{/number}","notifications_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/labels{/name}","releases_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/releases{/id}","deployments_url":"https://api.github.com/repos/DeepDiver1975/sabre-dav/deployments","created_at":"2014-01-09T13:55:18Z","updated_at":"2014-01-13T23:50:19Z","pushed_at":"2016-07-07T10:23:54Z","git_url":"git://github.com/DeepDiver1975/sabre-dav.git","ssh_url":"git@github.com:DeepDiver1975/sabre-dav.git","clone_url":"https://github.com/DeepDiver1975/sabre-dav.git","svn_url":"https://github.com/DeepDiver1975/sabre-dav","homepage":"http://code.google.com/p/sabredav/","size":13837,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fruux:master","ref":"master","sha":"5b9737cc2f0182e368d14c80df7f6b2d77dc1457","user":{"login":"fruux","id":1384629,"avatar_url":"https://avatars.githubusercontent.com/u/1384629?v=3","gravatar_id":"","url":"https://api.github.com/users/fruux","html_url":"https://github.com/fruux","followers_url":"https://api.github.com/users/fruux/followers","following_url":"https://api.github.com/users/fruux/following{/other_user}","gists_url":"https://api.github.com/users/fruux/gists{/gist_id}","starred_url":"https://api.github.com/users/fruux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fruux/subscriptions","organizations_url":"https://api.github.com/users/fruux/orgs","repos_url":"https://api.github.com/users/fruux/repos","events_url":"https://api.github.com/users/fruux/events{/privacy}","received_events_url":"https://api.github.com/users/fruux/received_events","type":"Organization","site_admin":false},"repo":{"id":2536145,"name":"sabre-dav","full_name":"fruux/sabre-dav","owner":{"login":"fruux","id":1384629,"avatar_url":"https://avatars.githubusercontent.com/u/1384629?v=3","gravatar_id":"","url":"https://api.github.com/users/fruux","html_url":"https://github.com/fruux","followers_url":"https://api.github.com/users/fruux/followers","following_url":"https://api.github.com/users/fruux/following{/other_user}","gists_url":"https://api.github.com/users/fruux/gists{/gist_id}","starred_url":"https://api.github.com/users/fruux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fruux/subscriptions","organizations_url":"https://api.github.com/users/fruux/orgs","repos_url":"https://api.github.com/users/fruux/repos","events_url":"https://api.github.com/users/fruux/events{/privacy}","received_events_url":"https://api.github.com/users/fruux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fruux/sabre-dav","description":"sabre/dav is a CalDAV, CardDAV and WebDAV framework for PHP","fork":false,"url":"https://api.github.com/repos/fruux/sabre-dav","forks_url":"https://api.github.com/repos/fruux/sabre-dav/forks","keys_url":"https://api.github.com/repos/fruux/sabre-dav/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fruux/sabre-dav/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fruux/sabre-dav/teams","hooks_url":"https://api.github.com/repos/fruux/sabre-dav/hooks","issue_events_url":"https://api.github.com/repos/fruux/sabre-dav/issues/events{/number}","events_url":"https://api.github.com/repos/fruux/sabre-dav/events","assignees_url":"https://api.github.com/repos/fruux/sabre-dav/assignees{/user}","branches_url":"https://api.github.com/repos/fruux/sabre-dav/branches{/branch}","tags_url":"https://api.github.com/repos/fruux/sabre-dav/tags","blobs_url":"https://api.github.com/repos/fruux/sabre-dav/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fruux/sabre-dav/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fruux/sabre-dav/git/refs{/sha}","trees_url":"https://api.github.com/repos/fruux/sabre-dav/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fruux/sabre-dav/statuses/{sha}","languages_url":"https://api.github.com/repos/fruux/sabre-dav/languages","stargazers_url":"https://api.github.com/repos/fruux/sabre-dav/stargazers","contributors_url":"https://api.github.com/repos/fruux/sabre-dav/contributors","subscribers_url":"https://api.github.com/repos/fruux/sabre-dav/subscribers","subscription_url":"https://api.github.com/repos/fruux/sabre-dav/subscription","commits_url":"https://api.github.com/repos/fruux/sabre-dav/commits{/sha}","git_commits_url":"https://api.github.com/repos/fruux/sabre-dav/git/commits{/sha}","comments_url":"https://api.github.com/repos/fruux/sabre-dav/comments{/number}","issue_comment_url":"https://api.github.com/repos/fruux/sabre-dav/issues/comments{/number}","contents_url":"https://api.github.com/repos/fruux/sabre-dav/contents/{+path}","compare_url":"https://api.github.com/repos/fruux/sabre-dav/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fruux/sabre-dav/merges","archive_url":"https://api.github.com/repos/fruux/sabre-dav/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fruux/sabre-dav/downloads","issues_url":"https://api.github.com/repos/fruux/sabre-dav/issues{/number}","pulls_url":"https://api.github.com/repos/fruux/sabre-dav/pulls{/number}","milestones_url":"https://api.github.com/repos/fruux/sabre-dav/milestones{/number}","notifications_url":"https://api.github.com/repos/fruux/sabre-dav/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fruux/sabre-dav/labels{/name}","releases_url":"https://api.github.com/repos/fruux/sabre-dav/releases{/id}","deployments_url":"https://api.github.com/repos/fruux/sabre-dav/deployments","created_at":"2011-10-08T00:38:42Z","updated_at":"2016-07-06T03:51:35Z","pushed_at":"2016-07-07T10:23:54Z","git_url":"git://github.com/fruux/sabre-dav.git","ssh_url":"git@github.com:fruux/sabre-dav.git","clone_url":"https://github.com/fruux/sabre-dav.git","svn_url":"https://github.com/fruux/sabre-dav","homepage":"http://sabre.io","size":23065,"stargazers_count":667,"watchers_count":667,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":183,"mirror_url":null,"open_issues_count":33,"forks":183,"open_issues":33,"watchers":667,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fruux/sabre-dav/pulls/830"},"html":{"href":"https://github.com/fruux/sabre-dav/pull/830"},"issue":{"href":"https://api.github.com/repos/fruux/sabre-dav/issues/830"},"comments":{"href":"https://api.github.com/repos/fruux/sabre-dav/issues/830/comments"},"review_comments":{"href":"https://api.github.com/repos/fruux/sabre-dav/pulls/830/comments"},"review_comment":{"href":"https://api.github.com/repos/fruux/sabre-dav/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fruux/sabre-dav/pulls/830/commits"},"statuses":{"href":"https://api.github.com/repos/fruux/sabre-dav/statuses/583610af17e9f18001a9251a1eef889b1bf5ca81"}}}}
{"actor":{"display_login":"evert"}}