{"action":"created","issue":{"url":"https://api.github.com/repos/DMSC-Instrument-Data/instrument-prototype/issues/37","repository_url":"https://api.github.com/repos/DMSC-Instrument-Data/instrument-prototype","labels_url":"https://api.github.com/repos/DMSC-Instrument-Data/instrument-prototype/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/DMSC-Instrument-Data/instrument-prototype/issues/37/comments","events_url":"https://api.github.com/repos/DMSC-Instrument-Data/instrument-prototype/issues/37/events","html_url":"https://github.com/DMSC-Instrument-Data/instrument-prototype/pull/37","id":189087973,"number":37,"title":"Immutable Instrument","user":{"login":"OwenArnold","id":1109536,"avatar_url":"https://avatars.githubusercontent.com/u/1109536?v=3","gravatar_id":"","url":"https://api.github.com/users/OwenArnold","html_url":"https://github.com/OwenArnold","followers_url":"https://api.github.com/users/OwenArnold/followers","following_url":"https://api.github.com/users/OwenArnold/following{/other_user}","gists_url":"https://api.github.com/users/OwenArnold/gists{/gist_id}","starred_url":"https://api.github.com/users/OwenArnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OwenArnold/subscriptions","organizations_url":"https://api.github.com/users/OwenArnold/orgs","repos_url":"https://api.github.com/users/OwenArnold/repos","events_url":"https://api.github.com/users/OwenArnold/events{/privacy}","received_events_url":"https://api.github.com/users/OwenArnold/received_events","type":"User","site_admin":false},"labels":[{"id":337483201,"url":"https://api.github.com/repos/DMSC-Instrument-Data/instrument-prototype/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"ianbush","id":7047413,"avatar_url":"https://avatars.githubusercontent.com/u/7047413?v=3","gravatar_id":"","url":"https://api.github.com/users/ianbush","html_url":"https://github.com/ianbush","followers_url":"https://api.github.com/users/ianbush/followers","following_url":"https://api.github.com/users/ianbush/following{/other_user}","gists_url":"https://api.github.com/users/ianbush/gists{/gist_id}","starred_url":"https://api.github.com/users/ianbush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianbush/subscriptions","organizations_url":"https://api.github.com/users/ianbush/orgs","repos_url":"https://api.github.com/users/ianbush/repos","events_url":"https://api.github.com/users/ianbush/events{/privacy}","received_events_url":"https://api.github.com/users/ianbush/received_events","type":"User","site_admin":false},"assignees":[{"login":"ianbush","id":7047413,"avatar_url":"https://avatars.githubusercontent.com/u/7047413?v=3","gravatar_id":"","url":"https://api.github.com/users/ianbush","html_url":"https://github.com/ianbush","followers_url":"https://api.github.com/users/ianbush/followers","following_url":"https://api.github.com/users/ianbush/following{/other_user}","gists_url":"https://api.github.com/users/ianbush/gists{/gist_id}","starred_url":"https://api.github.com/users/ianbush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianbush/subscriptions","organizations_url":"https://api.github.com/users/ianbush/orgs","repos_url":"https://api.github.com/users/ianbush/repos","events_url":"https://api.github.com/users/ianbush/events{/privacy}","received_events_url":"https://api.github.com/users/ianbush/received_events","type":"User","site_admin":false},{"login":"SimonHeybrock","id":12912489,"avatar_url":"https://avatars.githubusercontent.com/u/12912489?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonHeybrock","html_url":"https://github.com/SimonHeybrock","followers_url":"https://api.github.com/users/SimonHeybrock/followers","following_url":"https://api.github.com/users/SimonHeybrock/following{/other_user}","gists_url":"https://api.github.com/users/SimonHeybrock/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonHeybrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonHeybrock/subscriptions","organizations_url":"https://api.github.com/users/SimonHeybrock/orgs","repos_url":"https://api.github.com/users/SimonHeybrock/repos","events_url":"https://api.github.com/users/SimonHeybrock/events{/privacy}","received_events_url":"https://api.github.com/users/SimonHeybrock/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2016-11-14T11:20:48Z","updated_at":"2016-12-06T15:44:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DMSC-Instrument-Data/instrument-prototype/pulls/37","html_url":"https://github.com/DMSC-Instrument-Data/instrument-prototype/pull/37","diff_url":"https://github.com/DMSC-Instrument-Data/instrument-prototype/pull/37.diff","patch_url":"https://github.com/DMSC-Instrument-Data/instrument-prototype/pull/37.patch"},"body":"The purpose of this is to redefine the `Instrument` in such a way that mutable geometry information (positions/rotations) can live on the `DetectorInfo`. This is a pre-requisite for scanning where we may have multiple positions/rotations related to the same physical `Detector`. The consequence of this work is to make the `InstrumentTree` fully immutable. Old concepts such as `Nodes`, `Commands` and cascading modifications will be obsolete."},"comment":{"url":"https://api.github.com/repos/DMSC-Instrument-Data/instrument-prototype/issues/comments/265183891","html_url":"https://github.com/DMSC-Instrument-Data/instrument-prototype/pull/37#issuecomment-265183891","issue_url":"https://api.github.com/repos/DMSC-Instrument-Data/instrument-prototype/issues/37","id":265183891,"user":{"login":"OwenArnold","id":1109536,"avatar_url":"https://avatars.githubusercontent.com/u/1109536?v=3","gravatar_id":"","url":"https://api.github.com/users/OwenArnold","html_url":"https://github.com/OwenArnold","followers_url":"https://api.github.com/users/OwenArnold/followers","following_url":"https://api.github.com/users/OwenArnold/following{/other_user}","gists_url":"https://api.github.com/users/OwenArnold/gists{/gist_id}","starred_url":"https://api.github.com/users/OwenArnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OwenArnold/subscriptions","organizations_url":"https://api.github.com/users/OwenArnold/orgs","repos_url":"https://api.github.com/users/OwenArnold/repos","events_url":"https://api.github.com/users/OwenArnold/events{/privacy}","received_events_url":"https://api.github.com/users/OwenArnold/received_events","type":"User","site_admin":false},"created_at":"2016-12-06T15:44:25Z","updated_at":"2016-12-06T15:44:25Z","body":"@SimonHeybrock. I've made some changes to the `DetectorInfo` and `ComponentInfo` along the lines of your interfaces comment. I have not combined the `FlatTree` and `SOASource` together, as the changes here are already numerous and I want to think more about a nice way of having the two together."}}
{"actor":{"display_login":"OwenArnold"}}