{"action":"created","issue":{"url":"https://api.github.com/repos/brightcove/videojs-errors/issues/40","repository_url":"https://api.github.com/repos/brightcove/videojs-errors","labels_url":"https://api.github.com/repos/brightcove/videojs-errors/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/brightcove/videojs-errors/issues/40/comments","events_url":"https://api.github.com/repos/brightcove/videojs-errors/issues/40/events","html_url":"https://github.com/brightcove/videojs-errors/pull/40","id":167432810,"number":40,"title":"Close-button errors message accessible fix","user":{"login":"vdeshpande","id":1349170,"avatar_url":"https://avatars.githubusercontent.com/u/1349170?v=3","gravatar_id":"","url":"https://api.github.com/users/vdeshpande","html_url":"https://github.com/vdeshpande","followers_url":"https://api.github.com/users/vdeshpande/followers","following_url":"https://api.github.com/users/vdeshpande/following{/other_user}","gists_url":"https://api.github.com/users/vdeshpande/gists{/gist_id}","starred_url":"https://api.github.com/users/vdeshpande/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdeshpande/subscriptions","organizations_url":"https://api.github.com/users/vdeshpande/orgs","repos_url":"https://api.github.com/users/vdeshpande/repos","events_url":"https://api.github.com/users/vdeshpande/events{/privacy}","received_events_url":"https://api.github.com/users/vdeshpande/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2016-07-25T18:24:57Z","updated_at":"2016-08-10T17:11:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/brightcove/videojs-errors/pulls/40","html_url":"https://github.com/brightcove/videojs-errors/pull/40","diff_url":"https://github.com/brightcove/videojs-errors/pull/40.diff","patch_url":"https://github.com/brightcove/videojs-errors/pull/40.patch"},"body":"**Issue Description:**\r\nThe issue is that we do not have a close-button but just a visual indicator 'X' to tell the user that there is a close button on the modal. \r\n\r\n**Fix Description:**\r\nThis fix removes the visual \"X\" indicator and replaces it with a close button which is also accessible as it has a control text associated with it. The idea behind showing up the close-button is that we have made the `errorDisplay` closeable.\r\nMade some CSS changes so that the close button aligns with the `vjs-errors-dialog` top right edge always.\r\n\r\nAttaching screenshots of how it looks across various player sizes.\r\n\r\n<img width=\"671\" alt=\"screen shot 2016-07-25 at 12 10 27\" src=\"https://cloud.githubusercontent.com/assets/1349170/17109792/85e5007a-5267-11e6-9fdf-fab4a2061c4d.png\">\r\n<img width=\"895\" alt=\"screen shot 2016-07-25 at 12 11 16\" src=\"https://cloud.githubusercontent.com/assets/1349170/17109801/8b94b6be-5267-11e6-8e9e-234e7183d5bc.png\">\r\n<img width=\"448\" alt=\"screen shot 2016-07-25 at 12 12 44\" src=\"https://cloud.githubusercontent.com/assets/1349170/17109803/9002ce34-5267-11e6-8a80-771b64d0bf7e.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/brightcove/videojs-errors/issues/comments/238935725","html_url":"https://github.com/brightcove/videojs-errors/pull/40#issuecomment-238935725","issue_url":"https://api.github.com/repos/brightcove/videojs-errors/issues/40","id":238935725,"user":{"login":"misteroneill","id":214723,"avatar_url":"https://avatars.githubusercontent.com/u/214723?v=3","gravatar_id":"","url":"https://api.github.com/users/misteroneill","html_url":"https://github.com/misteroneill","followers_url":"https://api.github.com/users/misteroneill/followers","following_url":"https://api.github.com/users/misteroneill/following{/other_user}","gists_url":"https://api.github.com/users/misteroneill/gists{/gist_id}","starred_url":"https://api.github.com/users/misteroneill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misteroneill/subscriptions","organizations_url":"https://api.github.com/users/misteroneill/orgs","repos_url":"https://api.github.com/users/misteroneill/repos","events_url":"https://api.github.com/users/misteroneill/events{/privacy}","received_events_url":"https://api.github.com/users/misteroneill/received_events","type":"User","site_admin":false},"created_at":"2016-08-10T17:11:27Z","updated_at":"2016-08-10T17:11:27Z","body":"My LGTM still applies 😄"}}
{"actor":{"display_login":"misteroneill"}}