{"action":"created","comment":{"url":"https://api.github.com/repos/mldbai/mldb/pulls/comments/71910379","id":71910379,"diff_hunk":"@@ -38,28 +36,52 @@ TokenizeOptionsDescription()\n     addAuto(\"value\", &TokenizeOptions::value,\n             \"`value` (if not set to `null`) will be used instead of \"\n             \"token counts for the values of the columns in the output row.\");\n-    addAuto(\"min_token_length\", &TokenizeOptions::min_token_length,\n+    addAuto(\"minTokenLength\", &TokenizeOptions::minTokenLength,\n             \"Minimum number of characters in a token for it to be output or \"\n             \"included as part of an ngram\");\n-    addAuto(\"ngram_range\", &TokenizeOptions::ngram_range,\n+    addAuto(\"ngramRange\", &TokenizeOptions::ngramRange,\n             \"Specifies the complexity of n-grams to return, with the \"\n             \"first element corresponding to minimum length and the \"\n             \"second to maximum length.  \"\n             \"`[1, 1]` will return only unigrams, while `[2, 3]` will \"\n             \"return bigrams and trigrams, where tokens are joined by \"\n             \"underscores. For example, \"\n-            \"`tokenize('Good day world', {splitchars:' ', ngram_range:[2,3]})`\"\n+            \"`tokenize('Good day world', {splitChars:' ', ngramRange:[2,3]})`\"\n             \"will return the row `{'Good_day': 1, 'Good_day_world': 1, 'day_world': 1}`\");\n+\n+    onUnknownField = [] (TokenizeOptions * options,\n+                         JsonParsingContext & context)\n+    {\n+        if(context.fieldName() == \"min_token_length\") {\n+            context.exception(\"The 'min_token_length' argument has been \"\n+                    \"renamed to 'minTokenLength'\");\n+        }\n+        else if(context.fieldName() == \"ngram_range\") {\n+            context.exception(\"The 'ngram_range' argument has been \"\n+                    \"renamed to 'ngramRange'\");\n+        }\n+        else if(context.fieldName() == \"splitchars\") {\n+            context.exception(\"The 'splitchars' argument has been \"\n+                    \"renamed to 'splitChars'\");\n+        }\n+        else if(context.fieldName() == \"quotechar\") {\n+            context.exception(\"The 'quotechar' argument has been \"\n+                    \"renamed to 'quoteChar'\");\n+        }\n+        else {\n+            context.exception(\"Unknown field '\" + context.fieldName()\n+                    + \" parsing import.text configuration\");","path":"sql/tokenize.cc","position":67,"original_position":67,"commit_id":"0a345df394de431125c03531e76e672521af0b0f","original_commit_id":"0a345df394de431125c03531e76e672521af0b0f","user":{"login":"guyd","id":683788,"avatar_url":"https://avatars.githubusercontent.com/u/683788?v=3","gravatar_id":"","url":"https://api.github.com/users/guyd","html_url":"https://github.com/guyd","followers_url":"https://api.github.com/users/guyd/followers","following_url":"https://api.github.com/users/guyd/following{/other_user}","gists_url":"https://api.github.com/users/guyd/gists{/gist_id}","starred_url":"https://api.github.com/users/guyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyd/subscriptions","organizations_url":"https://api.github.com/users/guyd/orgs","repos_url":"https://api.github.com/users/guyd/repos","events_url":"https://api.github.com/users/guyd/events{/privacy}","received_events_url":"https://api.github.com/users/guyd/received_events","type":"User","site_admin":false},"body":"import.text -> Tokenize option","created_at":"2016-07-22T16:55:54Z","updated_at":"2016-07-22T16:55:54Z","html_url":"https://github.com/mldbai/mldb/pull/561#discussion_r71910379","pull_request_url":"https://api.github.com/repos/mldbai/mldb/pulls/561","_links":{"self":{"href":"https://api.github.com/repos/mldbai/mldb/pulls/comments/71910379"},"html":{"href":"https://github.com/mldbai/mldb/pull/561#discussion_r71910379"},"pull_request":{"href":"https://api.github.com/repos/mldbai/mldb/pulls/561"}}},"pull_request":{"url":"https://api.github.com/repos/mldbai/mldb/pulls/561","id":78500740,"html_url":"https://github.com/mldbai/mldb/pull/561","diff_url":"https://github.com/mldbai/mldb/pull/561.diff","patch_url":"https://github.com/mldbai/mldb/pull/561.patch","issue_url":"https://api.github.com/repos/mldbai/mldb/issues/561","number":561,"state":"open","locked":false,"title":"[MLDB-1844] Tokenize arguments are now camel case","user":{"login":"mailletf","id":569421,"avatar_url":"https://avatars.githubusercontent.com/u/569421?v=3","gravatar_id":"","url":"https://api.github.com/users/mailletf","html_url":"https://github.com/mailletf","followers_url":"https://api.github.com/users/mailletf/followers","following_url":"https://api.github.com/users/mailletf/following{/other_user}","gists_url":"https://api.github.com/users/mailletf/gists{/gist_id}","starred_url":"https://api.github.com/users/mailletf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mailletf/subscriptions","organizations_url":"https://api.github.com/users/mailletf/orgs","repos_url":"https://api.github.com/users/mailletf/repos","events_url":"https://api.github.com/users/mailletf/events{/privacy}","received_events_url":"https://api.github.com/users/mailletf/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-22T16:01:10Z","updated_at":"2016-07-22T16:55:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df9f073c6781e5dc4799c9ca5a2205ce36d1fdb3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mldbai/mldb/pulls/561/commits","review_comments_url":"https://api.github.com/repos/mldbai/mldb/pulls/561/comments","review_comment_url":"https://api.github.com/repos/mldbai/mldb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mldbai/mldb/issues/561/comments","statuses_url":"https://api.github.com/repos/mldbai/mldb/statuses/0a345df394de431125c03531e76e672521af0b0f","head":{"label":"mldbai:MLDB-1844_tokenize_camel","ref":"MLDB-1844_tokenize_camel","sha":"0a345df394de431125c03531e76e672521af0b0f","user":{"login":"mldbai","id":11510172,"avatar_url":"https://avatars.githubusercontent.com/u/11510172?v=3","gravatar_id":"","url":"https://api.github.com/users/mldbai","html_url":"https://github.com/mldbai","followers_url":"https://api.github.com/users/mldbai/followers","following_url":"https://api.github.com/users/mldbai/following{/other_user}","gists_url":"https://api.github.com/users/mldbai/gists{/gist_id}","starred_url":"https://api.github.com/users/mldbai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mldbai/subscriptions","organizations_url":"https://api.github.com/users/mldbai/orgs","repos_url":"https://api.github.com/users/mldbai/repos","events_url":"https://api.github.com/users/mldbai/events{/privacy}","received_events_url":"https://api.github.com/users/mldbai/received_events","type":"Organization","site_admin":false},"repo":{"id":47634692,"name":"mldb","full_name":"mldbai/mldb","owner":{"login":"mldbai","id":11510172,"avatar_url":"https://avatars.githubusercontent.com/u/11510172?v=3","gravatar_id":"","url":"https://api.github.com/users/mldbai","html_url":"https://github.com/mldbai","followers_url":"https://api.github.com/users/mldbai/followers","following_url":"https://api.github.com/users/mldbai/following{/other_user}","gists_url":"https://api.github.com/users/mldbai/gists{/gist_id}","starred_url":"https://api.github.com/users/mldbai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mldbai/subscriptions","organizations_url":"https://api.github.com/users/mldbai/orgs","repos_url":"https://api.github.com/users/mldbai/repos","events_url":"https://api.github.com/users/mldbai/events{/privacy}","received_events_url":"https://api.github.com/users/mldbai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mldbai/mldb","description":"MLDB is the Machine Learning Database","fork":false,"url":"https://api.github.com/repos/mldbai/mldb","forks_url":"https://api.github.com/repos/mldbai/mldb/forks","keys_url":"https://api.github.com/repos/mldbai/mldb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mldbai/mldb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mldbai/mldb/teams","hooks_url":"https://api.github.com/repos/mldbai/mldb/hooks","issue_events_url":"https://api.github.com/repos/mldbai/mldb/issues/events{/number}","events_url":"https://api.github.com/repos/mldbai/mldb/events","assignees_url":"https://api.github.com/repos/mldbai/mldb/assignees{/user}","branches_url":"https://api.github.com/repos/mldbai/mldb/branches{/branch}","tags_url":"https://api.github.com/repos/mldbai/mldb/tags","blobs_url":"https://api.github.com/repos/mldbai/mldb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mldbai/mldb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mldbai/mldb/git/refs{/sha}","trees_url":"https://api.github.com/repos/mldbai/mldb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mldbai/mldb/statuses/{sha}","languages_url":"https://api.github.com/repos/mldbai/mldb/languages","stargazers_url":"https://api.github.com/repos/mldbai/mldb/stargazers","contributors_url":"https://api.github.com/repos/mldbai/mldb/contributors","subscribers_url":"https://api.github.com/repos/mldbai/mldb/subscribers","subscription_url":"https://api.github.com/repos/mldbai/mldb/subscription","commits_url":"https://api.github.com/repos/mldbai/mldb/commits{/sha}","git_commits_url":"https://api.github.com/repos/mldbai/mldb/git/commits{/sha}","comments_url":"https://api.github.com/repos/mldbai/mldb/comments{/number}","issue_comment_url":"https://api.github.com/repos/mldbai/mldb/issues/comments{/number}","contents_url":"https://api.github.com/repos/mldbai/mldb/contents/{+path}","compare_url":"https://api.github.com/repos/mldbai/mldb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mldbai/mldb/merges","archive_url":"https://api.github.com/repos/mldbai/mldb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mldbai/mldb/downloads","issues_url":"https://api.github.com/repos/mldbai/mldb/issues{/number}","pulls_url":"https://api.github.com/repos/mldbai/mldb/pulls{/number}","milestones_url":"https://api.github.com/repos/mldbai/mldb/milestones{/number}","notifications_url":"https://api.github.com/repos/mldbai/mldb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mldbai/mldb/labels{/name}","releases_url":"https://api.github.com/repos/mldbai/mldb/releases{/id}","deployments_url":"https://api.github.com/repos/mldbai/mldb/deployments","created_at":"2015-12-08T16:34:16Z","updated_at":"2016-07-18T10:59:10Z","pushed_at":"2016-07-22T16:52:53Z","git_url":"git://github.com/mldbai/mldb.git","ssh_url":"git@github.com:mldbai/mldb.git","clone_url":"https://github.com/mldbai/mldb.git","svn_url":"https://github.com/mldbai/mldb","homepage":"http://mldb.ai","size":23518,"stargazers_count":178,"watchers_count":178,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":11,"forks":12,"open_issues":11,"watchers":178,"default_branch":"master"}},"base":{"label":"mldbai:master","ref":"master","sha":"2e4e77711cd559a3324bb98343853e94d873c77c","user":{"login":"mldbai","id":11510172,"avatar_url":"https://avatars.githubusercontent.com/u/11510172?v=3","gravatar_id":"","url":"https://api.github.com/users/mldbai","html_url":"https://github.com/mldbai","followers_url":"https://api.github.com/users/mldbai/followers","following_url":"https://api.github.com/users/mldbai/following{/other_user}","gists_url":"https://api.github.com/users/mldbai/gists{/gist_id}","starred_url":"https://api.github.com/users/mldbai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mldbai/subscriptions","organizations_url":"https://api.github.com/users/mldbai/orgs","repos_url":"https://api.github.com/users/mldbai/repos","events_url":"https://api.github.com/users/mldbai/events{/privacy}","received_events_url":"https://api.github.com/users/mldbai/received_events","type":"Organization","site_admin":false},"repo":{"id":47634692,"name":"mldb","full_name":"mldbai/mldb","owner":{"login":"mldbai","id":11510172,"avatar_url":"https://avatars.githubusercontent.com/u/11510172?v=3","gravatar_id":"","url":"https://api.github.com/users/mldbai","html_url":"https://github.com/mldbai","followers_url":"https://api.github.com/users/mldbai/followers","following_url":"https://api.github.com/users/mldbai/following{/other_user}","gists_url":"https://api.github.com/users/mldbai/gists{/gist_id}","starred_url":"https://api.github.com/users/mldbai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mldbai/subscriptions","organizations_url":"https://api.github.com/users/mldbai/orgs","repos_url":"https://api.github.com/users/mldbai/repos","events_url":"https://api.github.com/users/mldbai/events{/privacy}","received_events_url":"https://api.github.com/users/mldbai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mldbai/mldb","description":"MLDB is the Machine Learning Database","fork":false,"url":"https://api.github.com/repos/mldbai/mldb","forks_url":"https://api.github.com/repos/mldbai/mldb/forks","keys_url":"https://api.github.com/repos/mldbai/mldb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mldbai/mldb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mldbai/mldb/teams","hooks_url":"https://api.github.com/repos/mldbai/mldb/hooks","issue_events_url":"https://api.github.com/repos/mldbai/mldb/issues/events{/number}","events_url":"https://api.github.com/repos/mldbai/mldb/events","assignees_url":"https://api.github.com/repos/mldbai/mldb/assignees{/user}","branches_url":"https://api.github.com/repos/mldbai/mldb/branches{/branch}","tags_url":"https://api.github.com/repos/mldbai/mldb/tags","blobs_url":"https://api.github.com/repos/mldbai/mldb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mldbai/mldb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mldbai/mldb/git/refs{/sha}","trees_url":"https://api.github.com/repos/mldbai/mldb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mldbai/mldb/statuses/{sha}","languages_url":"https://api.github.com/repos/mldbai/mldb/languages","stargazers_url":"https://api.github.com/repos/mldbai/mldb/stargazers","contributors_url":"https://api.github.com/repos/mldbai/mldb/contributors","subscribers_url":"https://api.github.com/repos/mldbai/mldb/subscribers","subscription_url":"https://api.github.com/repos/mldbai/mldb/subscription","commits_url":"https://api.github.com/repos/mldbai/mldb/commits{/sha}","git_commits_url":"https://api.github.com/repos/mldbai/mldb/git/commits{/sha}","comments_url":"https://api.github.com/repos/mldbai/mldb/comments{/number}","issue_comment_url":"https://api.github.com/repos/mldbai/mldb/issues/comments{/number}","contents_url":"https://api.github.com/repos/mldbai/mldb/contents/{+path}","compare_url":"https://api.github.com/repos/mldbai/mldb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mldbai/mldb/merges","archive_url":"https://api.github.com/repos/mldbai/mldb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mldbai/mldb/downloads","issues_url":"https://api.github.com/repos/mldbai/mldb/issues{/number}","pulls_url":"https://api.github.com/repos/mldbai/mldb/pulls{/number}","milestones_url":"https://api.github.com/repos/mldbai/mldb/milestones{/number}","notifications_url":"https://api.github.com/repos/mldbai/mldb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mldbai/mldb/labels{/name}","releases_url":"https://api.github.com/repos/mldbai/mldb/releases{/id}","deployments_url":"https://api.github.com/repos/mldbai/mldb/deployments","created_at":"2015-12-08T16:34:16Z","updated_at":"2016-07-18T10:59:10Z","pushed_at":"2016-07-22T16:52:53Z","git_url":"git://github.com/mldbai/mldb.git","ssh_url":"git@github.com:mldbai/mldb.git","clone_url":"https://github.com/mldbai/mldb.git","svn_url":"https://github.com/mldbai/mldb","homepage":"http://mldb.ai","size":23518,"stargazers_count":178,"watchers_count":178,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":11,"forks":12,"open_issues":11,"watchers":178,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mldbai/mldb/pulls/561"},"html":{"href":"https://github.com/mldbai/mldb/pull/561"},"issue":{"href":"https://api.github.com/repos/mldbai/mldb/issues/561"},"comments":{"href":"https://api.github.com/repos/mldbai/mldb/issues/561/comments"},"review_comments":{"href":"https://api.github.com/repos/mldbai/mldb/pulls/561/comments"},"review_comment":{"href":"https://api.github.com/repos/mldbai/mldb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mldbai/mldb/pulls/561/commits"},"statuses":{"href":"https://api.github.com/repos/mldbai/mldb/statuses/0a345df394de431125c03531e76e672521af0b0f"}}}}
{"actor":{"display_login":"guyd"}}