{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j-ogm/pulls/comments/88440986","pull_request_review_id":9009501,"id":88440986,"diff_hunk":"@@ -253,21 +250,20 @@ public void shouldModifyStringArraysCorrectly() throws MalformedURLException {\n      */\n     @Test\n     public void shouldBeAbleToSetNodePropertiesToNull() throws MalformedURLException {\n-        Movie movie = new Movie();\n-        movie.setTitle(\"Zootopia\");\n+        Movie movie = new Movie(\"Zootopia\", 2016);\n         movie.setImdbUrl(new URL(\"http://www.imdb.com/title/tt2948356/\"));\n         session.save(movie);\n \n         movie.setTitle(null);\n         movie.setImdbUrl(null);\n         session.save(movie);\n \n-        movie = session.load(Movie.class, movie.getId());\n+        movie = session.load(Movie.class, movie.getUuid());","path":"core/src/test/java/org/neo4j/ogm/persistence/examples/cineasts/annotated/CineastsIntegrationTest.java","position":99,"original_position":99,"commit_id":"34e5951994139ca676780d6ff8e41c750a6b6458","original_commit_id":"34e5951994139ca676780d6ff8e41c750a6b6458","user":{"login":"vince-bickers","id":1481408,"avatar_url":"https://avatars.githubusercontent.com/u/1481408?v=3","gravatar_id":"","url":"https://api.github.com/users/vince-bickers","html_url":"https://github.com/vince-bickers","followers_url":"https://api.github.com/users/vince-bickers/followers","following_url":"https://api.github.com/users/vince-bickers/following{/other_user}","gists_url":"https://api.github.com/users/vince-bickers/gists{/gist_id}","starred_url":"https://api.github.com/users/vince-bickers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vince-bickers/subscriptions","organizations_url":"https://api.github.com/users/vince-bickers/orgs","repos_url":"https://api.github.com/users/vince-bickers/repos","events_url":"https://api.github.com/users/vince-bickers/events{/privacy}","received_events_url":"https://api.github.com/users/vince-bickers/received_events","type":"User","site_admin":false},"body":"A minor concern: by refactoring the Movie class to have a primary index, have we potentially obscured other issues relating to specific tests of id field elsewhere? (Presumably all tests that used `movie.getId()` now use `movie.getUuid()` instead)","created_at":"2016-11-17T12:19:49Z","updated_at":"2016-11-17T12:39:06Z","html_url":"https://github.com/neo4j/neo4j-ogm/pull/281#discussion_r88440986","pull_request_url":"https://api.github.com/repos/neo4j/neo4j-ogm/pulls/281","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j-ogm/pulls/comments/88440986"},"html":{"href":"https://github.com/neo4j/neo4j-ogm/pull/281#discussion_r88440986"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j-ogm/pulls/281"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j-ogm/pulls/281","id":94141497,"html_url":"https://github.com/neo4j/neo4j-ogm/pull/281","diff_url":"https://github.com/neo4j/neo4j-ogm/pull/281.diff","patch_url":"https://github.com/neo4j/neo4j-ogm/pull/281.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j-ogm/issues/281","number":281,"state":"open","locked":false,"title":"Support for lookup & merge via primary index.","user":{"login":"mangrish","id":2446948,"avatar_url":"https://avatars.githubusercontent.com/u/2446948?v=3","gravatar_id":"","url":"https://api.github.com/users/mangrish","html_url":"https://github.com/mangrish","followers_url":"https://api.github.com/users/mangrish/followers","following_url":"https://api.github.com/users/mangrish/following{/other_user}","gists_url":"https://api.github.com/users/mangrish/gists{/gist_id}","starred_url":"https://api.github.com/users/mangrish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mangrish/subscriptions","organizations_url":"https://api.github.com/users/mangrish/orgs","repos_url":"https://api.github.com/users/mangrish/repos","events_url":"https://api.github.com/users/mangrish/events{/privacy}","received_events_url":"https://api.github.com/users/mangrish/received_events","type":"User","site_admin":false},"body":"Allows users to specify their own property for use as a key when looking up or merging a node.\n\nPrevious version of SDN have had the ability to find unique Objects by property that was not it's internal Neo4J ID.  This is important when running Neo4J across restarts as this allows developers to query via business or synthetic (e.g. UUID) properties. In order to return a single value these properties must enforce uniqueness constraints.  On top of this, many users have the use case of wanting to save their objects via this same property and in effect have the OGM run the `MERGE` operation using the same property to identify the object.\n\nThis PR will allow developers to mark any properties they would like to use in unique lookup or save operations as well as API changes to the Session to support them.\n\n┆Issue is synchronized with this [Asana task](https://app.asana.com/0/160274761455938/214599643142305)\n","created_at":"2016-11-17T10:37:32Z","updated_at":"2016-11-17T12:39:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b512b59f3808b944a665e0f46c462f88c086b07a","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/neo4j/neo4j-ogm/milestones/2","html_url":"https://github.com/neo4j/neo4j-ogm/milestones/2.1.0","labels_url":"https://api.github.com/repos/neo4j/neo4j-ogm/milestones/2/labels","id":1908601,"number":2,"title":"2.1.0","description":"","creator":{"login":"mangrish","id":2446948,"avatar_url":"https://avatars.githubusercontent.com/u/2446948?v=3","gravatar_id":"","url":"https://api.github.com/users/mangrish","html_url":"https://github.com/mangrish","followers_url":"https://api.github.com/users/mangrish/followers","following_url":"https://api.github.com/users/mangrish/following{/other_user}","gists_url":"https://api.github.com/users/mangrish/gists{/gist_id}","starred_url":"https://api.github.com/users/mangrish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mangrish/subscriptions","organizations_url":"https://api.github.com/users/mangrish/orgs","repos_url":"https://api.github.com/users/mangrish/repos","events_url":"https://api.github.com/users/mangrish/events{/privacy}","received_events_url":"https://api.github.com/users/mangrish/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2016-07-28T02:46:16Z","updated_at":"2016-11-17T10:37:32Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/neo4j/neo4j-ogm/pulls/281/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j-ogm/pulls/281/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j-ogm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j-ogm/issues/281/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j-ogm/statuses/34e5951994139ca676780d6ff8e41c750a6b6458","head":{"label":"neo4j:feature/index-v2","ref":"feature/index-v2","sha":"34e5951994139ca676780d6ff8e41c750a6b6458","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":24224646,"name":"neo4j-ogm","full_name":"neo4j/neo4j-ogm","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j-ogm","description":"Object-Graph Mapping Library for Neo4j","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j-ogm","forks_url":"https://api.github.com/repos/neo4j/neo4j-ogm/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j-ogm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j-ogm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j-ogm/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j-ogm/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j-ogm/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j-ogm/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j-ogm/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j-ogm/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j-ogm/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j-ogm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j-ogm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j-ogm/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j-ogm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j-ogm/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j-ogm/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j-ogm/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j-ogm/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j-ogm/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j-ogm/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j-ogm/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j-ogm/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j-ogm/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j-ogm/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j-ogm/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j-ogm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j-ogm/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j-ogm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j-ogm/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j-ogm/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j-ogm/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j-ogm/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j-ogm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j-ogm/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j-ogm/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j-ogm/deployments","created_at":"2014-09-19T09:43:23Z","updated_at":"2016-11-14T18:30:01Z","pushed_at":"2016-11-17T10:58:04Z","git_url":"git://github.com/neo4j/neo4j-ogm.git","ssh_url":"git@github.com:neo4j/neo4j-ogm.git","clone_url":"https://github.com/neo4j/neo4j-ogm.git","svn_url":"https://github.com/neo4j/neo4j-ogm","homepage":null,"size":14615,"stargazers_count":105,"watchers_count":105,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":61,"forks":67,"open_issues":61,"watchers":105,"default_branch":"master"}},"base":{"label":"neo4j:master","ref":"master","sha":"c3a9d17c8bd351b2d908523522c5bf3ef2de05a7","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":24224646,"name":"neo4j-ogm","full_name":"neo4j/neo4j-ogm","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j-ogm","description":"Object-Graph Mapping Library for Neo4j","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j-ogm","forks_url":"https://api.github.com/repos/neo4j/neo4j-ogm/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j-ogm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j-ogm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j-ogm/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j-ogm/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j-ogm/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j-ogm/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j-ogm/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j-ogm/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j-ogm/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j-ogm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j-ogm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j-ogm/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j-ogm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j-ogm/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j-ogm/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j-ogm/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j-ogm/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j-ogm/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j-ogm/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j-ogm/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j-ogm/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j-ogm/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j-ogm/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j-ogm/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j-ogm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j-ogm/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j-ogm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j-ogm/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j-ogm/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j-ogm/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j-ogm/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j-ogm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j-ogm/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j-ogm/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j-ogm/deployments","created_at":"2014-09-19T09:43:23Z","updated_at":"2016-11-14T18:30:01Z","pushed_at":"2016-11-17T10:58:04Z","git_url":"git://github.com/neo4j/neo4j-ogm.git","ssh_url":"git@github.com:neo4j/neo4j-ogm.git","clone_url":"https://github.com/neo4j/neo4j-ogm.git","svn_url":"https://github.com/neo4j/neo4j-ogm","homepage":null,"size":14615,"stargazers_count":105,"watchers_count":105,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":61,"forks":67,"open_issues":61,"watchers":105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j-ogm/pulls/281"},"html":{"href":"https://github.com/neo4j/neo4j-ogm/pull/281"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j-ogm/issues/281"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j-ogm/issues/281/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j-ogm/pulls/281/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j-ogm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j-ogm/pulls/281/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j-ogm/statuses/34e5951994139ca676780d6ff8e41c750a6b6458"}}}}
{"actor":{"display_login":"vince-bickers"}}