{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/65092883","id":65092883,"diff_hunk":"@@ -1118,4 +1127,63 @@ if (isEnabled('ember-runtime-computed-uniq-by')) {\n   });\n }\n \n+if (isEnabled('ember-runtime-enumerable-includes')) {\n+  Enumerable.reopen({\n+    /**\n+      Returns `true` if the passed object can be found in the enumerable.\n+      ```javascript\n+      [1, 2, 3].includes(2);                     // true\n+      [1, 2, 3].includes(4);                     // false\n+      [1, 2, undefined].includes(undefined);     // true\n+      [1, 2, null].includes(null);               // true\n+      [1, 2, NaN].includes(NaN);                 // true\n+      ```\n+      @method includes\n+      @param {Object} obj The object to search for.\n+      @return {Boolean} `true` if object is found in the enumerable.\n+      @public\n+    */\n+    includes(obj) {\n+      assert('Enumerable#includes cannot accept a second argument \"startAt\" as enumerable items are unordered.', arguments.length === 1);\n+\n+      var len = get(this, 'length');\n+      var idx, next;\n+      var last = null;\n+      var found = false;\n+\n+      var context = popCtx();\n+\n+      for (idx = 0; idx < len && !found; idx++) {\n+        next = this.nextObject(idx, last, context);\n+\n+        found = obj === next || (obj !== obj && next !== next);\n+\n+        last = next;\n+      }\n+\n+      next = last = null;\n+      context = pushCtx(context);\n+\n+      return found;\n+    },\n+\n+    without(value) {","path":"packages/ember-runtime/lib/mixins/enumerable.js","position":67,"original_position":67,"commit_id":"c01984c82debc81c080591c22a9bf1ab10358ba2","original_commit_id":"c01984c82debc81c080591c22a9bf1ab10358ba2","user":{"login":"mixonic","id":8752,"avatar_url":"https://avatars.githubusercontent.com/u/8752?v=3","gravatar_id":"","url":"https://api.github.com/users/mixonic","html_url":"https://github.com/mixonic","followers_url":"https://api.github.com/users/mixonic/followers","following_url":"https://api.github.com/users/mixonic/following{/other_user}","gists_url":"https://api.github.com/users/mixonic/gists{/gist_id}","starred_url":"https://api.github.com/users/mixonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixonic/subscriptions","organizations_url":"https://api.github.com/users/mixonic/orgs","repos_url":"https://api.github.com/users/mixonic/repos","events_url":"https://api.github.com/users/mixonic/events{/privacy}","received_events_url":"https://api.github.com/users/mixonic/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2016-05-30T16:58:23Z","updated_at":"2016-05-30T16:58:23Z","html_url":"https://github.com/emberjs/ember.js/pull/13553#discussion_r65092883","pull_request_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13553","_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments/65092883"},"html":{"href":"https://github.com/emberjs/ember.js/pull/13553#discussion_r65092883"},"pull_request":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13553"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/13553","id":71265275,"html_url":"https://github.com/emberjs/ember.js/pull/13553","diff_url":"https://github.com/emberjs/ember.js/pull/13553.diff","patch_url":"https://github.com/emberjs/ember.js/pull/13553.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/13553","number":13553,"state":"open","locked":false,"title":"[FEATURE contains-to-includes] Implements Array.includes and deprecates Array.contains","user":{"login":"bmeurant","id":141720,"avatar_url":"https://avatars.githubusercontent.com/u/141720?v=3","gravatar_id":"","url":"https://api.github.com/users/bmeurant","html_url":"https://github.com/bmeurant","followers_url":"https://api.github.com/users/bmeurant/followers","following_url":"https://api.github.com/users/bmeurant/following{/other_user}","gists_url":"https://api.github.com/users/bmeurant/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeurant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeurant/subscriptions","organizations_url":"https://api.github.com/users/bmeurant/orgs","repos_url":"https://api.github.com/users/bmeurant/repos","events_url":"https://api.github.com/users/bmeurant/events{/privacy}","received_events_url":"https://api.github.com/users/bmeurant/received_events","type":"User","site_admin":false},"body":"Implementation of emberjs/rfcs#136\r\n\r\nTODO : \r\n\r\n- [x]  Implement `Enumerable.includes` \r\n- [x]  Implement `Array.includes`\r\n- [x]  Deprecate `contains` under feature flag\r\n- [x]  ~~Alias `contains` to `includes`~~\r\n- [x]  Replace usages of `contains` by `includes`\r\n- [x]  Update docs, guides (emberjs/guides#1439) & API. To be merged once feature enabled.\r\n- [x] Write deprecation guide (emberjs/website#2600) & add url in deprecate call\r\n- [ ] Rebase / squash","created_at":"2016-05-24T18:00:15Z","updated_at":"2016-05-30T16:58:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f6e754b083ae78e4a245c711af25c13ba4f464c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13553/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/13553/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/13553/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/c01984c82debc81c080591c22a9bf1ab10358ba2","head":{"label":"bmeurant:master","ref":"master","sha":"c01984c82debc81c080591c22a9bf1ab10358ba2","user":{"login":"bmeurant","id":141720,"avatar_url":"https://avatars.githubusercontent.com/u/141720?v=3","gravatar_id":"","url":"https://api.github.com/users/bmeurant","html_url":"https://github.com/bmeurant","followers_url":"https://api.github.com/users/bmeurant/followers","following_url":"https://api.github.com/users/bmeurant/following{/other_user}","gists_url":"https://api.github.com/users/bmeurant/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeurant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeurant/subscriptions","organizations_url":"https://api.github.com/users/bmeurant/orgs","repos_url":"https://api.github.com/users/bmeurant/repos","events_url":"https://api.github.com/users/bmeurant/events{/privacy}","received_events_url":"https://api.github.com/users/bmeurant/received_events","type":"User","site_admin":false},"repo":{"id":59526356,"name":"ember.js","full_name":"bmeurant/ember.js","owner":{"login":"bmeurant","id":141720,"avatar_url":"https://avatars.githubusercontent.com/u/141720?v=3","gravatar_id":"","url":"https://api.github.com/users/bmeurant","html_url":"https://github.com/bmeurant","followers_url":"https://api.github.com/users/bmeurant/followers","following_url":"https://api.github.com/users/bmeurant/following{/other_user}","gists_url":"https://api.github.com/users/bmeurant/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeurant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeurant/subscriptions","organizations_url":"https://api.github.com/users/bmeurant/orgs","repos_url":"https://api.github.com/users/bmeurant/repos","events_url":"https://api.github.com/users/bmeurant/events{/privacy}","received_events_url":"https://api.github.com/users/bmeurant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmeurant/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/bmeurant/ember.js","forks_url":"https://api.github.com/repos/bmeurant/ember.js/forks","keys_url":"https://api.github.com/repos/bmeurant/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmeurant/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmeurant/ember.js/teams","hooks_url":"https://api.github.com/repos/bmeurant/ember.js/hooks","issue_events_url":"https://api.github.com/repos/bmeurant/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/bmeurant/ember.js/events","assignees_url":"https://api.github.com/repos/bmeurant/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/bmeurant/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/bmeurant/ember.js/tags","blobs_url":"https://api.github.com/repos/bmeurant/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmeurant/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmeurant/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmeurant/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmeurant/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/bmeurant/ember.js/languages","stargazers_url":"https://api.github.com/repos/bmeurant/ember.js/stargazers","contributors_url":"https://api.github.com/repos/bmeurant/ember.js/contributors","subscribers_url":"https://api.github.com/repos/bmeurant/ember.js/subscribers","subscription_url":"https://api.github.com/repos/bmeurant/ember.js/subscription","commits_url":"https://api.github.com/repos/bmeurant/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmeurant/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmeurant/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmeurant/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmeurant/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/bmeurant/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmeurant/ember.js/merges","archive_url":"https://api.github.com/repos/bmeurant/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmeurant/ember.js/downloads","issues_url":"https://api.github.com/repos/bmeurant/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/bmeurant/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/bmeurant/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/bmeurant/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmeurant/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/bmeurant/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/bmeurant/ember.js/deployments","created_at":"2016-05-23T23:54:43Z","updated_at":"2016-05-23T23:54:49Z","pushed_at":"2016-05-27T20:40:34Z","git_url":"git://github.com/bmeurant/ember.js.git","ssh_url":"git@github.com:bmeurant/ember.js.git","clone_url":"https://github.com/bmeurant/ember.js.git","svn_url":"https://github.com/bmeurant/ember.js","homepage":"http://www.emberjs.com","size":33939,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"a116b363b59d1f8022912c6c63e2a11ba7fd72d0","user":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"avatar_url":"https://avatars.githubusercontent.com/u/1253363?v=3","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/ember.js/deployments","created_at":"2011-05-25T23:39:40Z","updated_at":"2016-05-30T16:33:15Z","pushed_at":"2016-05-30T12:01:19Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":68661,"stargazers_count":16281,"watchers_count":16281,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3484,"mirror_url":null,"open_issues_count":254,"forks":3484,"open_issues":254,"watchers":16281,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13553"},"html":{"href":"https://github.com/emberjs/ember.js/pull/13553"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/13553"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/13553/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13553/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/13553/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/c01984c82debc81c080591c22a9bf1ab10358ba2"}}}}
{"actor":{"display_login":"mixonic"}}