{"push_id":1105132422,"size":24,"distinct_size":20,"ref":"refs/heads/master","head":"44149cab163dc1dce78e2b99c425dddc8df46ad3","before":"9a8f55f37aff7b34a6d18e88702e04a3d1bc60cf","commits":[{"sha":"299375f7b164a6618c4708b605b4db0f17dc3d85","author":{"email":"640d9fe47775e6723f0355b7315e38f7d98d3539@gmail.com","name":"Gregory Haskins"},"message":"Use make to build the fabric\n\nThis patch adds a top-level makefile for managing builds and dependencies\n\nWhy?\n\nOur current environment relies heavily on vagrant performing a good deal of the\npreparation such that we can perform operations like \"cd peer; go build\".  One\nminor problem is that a common vagrant-based workflow is to subsequently update\nthe code and rebuild without necessarily rebuilding the vagrant environment\n(e.g. git pull && go build).  Any dependency changes in the underlying code\nmay not be properly satisfied with such a workflow.\n\nTo make matters more complicated, many other environments outside vagrant\nexist (e.g. TravisCI, non vagrant based development environments, production\ndeployments, etc).  These environments are even more adversely affected with\nextrinsic dependencies.  Work has been done (see the ./scripts/provisioning\narea for an example) to try to help unify the different environments to\na single source of truth.  Despite this, we still struggle to provide a smooth\nexperience because these mechanisms need to be understood by all and\nincorporated into the relevant workflows.  Often times, developers/users\ndon't even know these problems/mechanisms exist until they find things broken\nin typically non-obvious ways.\n\nWhats needed is an easy way to operate with a more self-contained approach\nsuch that we can support the \"git pull && do-it\" type workflow.  However,\nwe also need to observe that the \"go\" tooling is probably ill equiped for\nanything except the most basic of pure go development:  It intentionally\ndoesn't support external hooks, etc, as you would find in a general build\nframework like Make or Maven.  Once you have a polyglot and/or dependencies\non external facilities (e.g. docker, protobuf, etc) starts to feel more\ncloser to \"gcc\" than to \"make\".\n\nThis isn't necessarily a bad thing, but trying to centralize our tooling\non a \"go\" tool based workflow I suspect is a large part of the current pain\nbeing felt.  Instead, lets embrace it for what I believe it was intended\nto do really well (compile go code), and augment it with a tool that\nis better suited to managing a polyglot/external-dep universe, of which\ngolang is just one part.\n\nThere are many build frameworks to choose from, but Make is ubiquitous,\nwell understood, and well suited to the task.  I therefore think\nit makes a perfectly reasonable approach to serve as the centerpoint\nof our build system.\n\nThe intention is that developers/packagers/etc migrate to using make\nin conjunction with the targets listed above rather than the raw commands\nthat have been historically employed.  While the old methods should\ncontinue to work, the new workflow can incorporate more automation that\nwill help keep the build process running smoothly and adapting to future\nrequirements without users needing to be aware.  In this new model, the\ntypical workflow would become:\n\n     git pull && make clean peer\n\nThis should generally allow most things to either be:\n\n     a) automatically managed\n\n      OR\n\n     b) cleanly reported when automation cannot solve the problem (e.g.\n        external dependencies that need to be manually installed).\n\nI believe this should lay the groundwork for a vast improvement over the\ncurrent process.\n\nSigned-off-by: Greg Haskins <gregory.haskins@gmail.com>","distinct":true,"url":"https://api.github.com/repos/lehors/fabric/commits/299375f7b164a6618c4708b605b4db0f17dc3d85"},{"sha":"12991d20842977989bbdb19b939c162349ca353e","author":{"email":"640d9fe47775e6723f0355b7315e38f7d98d3539@gmail.com","name":"Gregory Haskins"},"message":"Ensure we run a peer for the unit-tests\n\nSigned-off-by: Greg Haskins <gregory.haskins@gmail.com>","distinct":true,"url":"https://api.github.com/repos/lehors/fabric/commits/12991d20842977989bbdb19b939c162349ca353e"},{"sha":"31b5a3d2dba3aac0551b20c714ed220b868e55d7","author":{"email":"640d9fe47775e6723f0355b7315e38f7d98d3539@gmail.com","name":"Gregory Haskins"},"message":"Create \"make behave-deps\" target\n\nBehave requires our docker images _and_ our executables.  We currently\nrely on the \"images\" target as a pre-requisite for running behave,\nbut this alone isnt enough.  We could just make the images target\ndepend on the executables, but that would be a hack. Lets express\nthe dependencies correctly\n\nSigned-off-by: Greg Haskins <gregory.haskins@gmail.com>","distinct":true,"url":"https://api.github.com/repos/lehors/fabric/commits/31b5a3d2dba3aac0551b20c714ed220b868e55d7"},{"sha":"05a8090253f9344a396c27d02304bfc5947fc1d2","author":{"email":"640d9fe47775e6723f0355b7315e38f7d98d3539@gmail.com","name":"Gregory Haskins"},"message":"Allow behave to be parameterized\n\nSigned-off-by: Greg Haskins <gregory.haskins@gmail.com>","distinct":true,"url":"https://api.github.com/repos/lehors/fabric/commits/05a8090253f9344a396c27d02304bfc5947fc1d2"},{"sha":"7a9805ae82d7c1efdb7ee83461a761cf9135f565","author":{"email":"640d9fe47775e6723f0355b7315e38f7d98d3539@gmail.com","name":"Gregory Haskins"},"message":"Rebrand our docker image under the hyperledger name\n\nSigned-off-by: Greg Haskins <gregory.haskins@gmail.com>","distinct":true,"url":"https://api.github.com/repos/lehors/fabric/commits/7a9805ae82d7c1efdb7ee83461a761cf9135f565"},{"sha":"71d113b0f6dbc474a51fe774110b5c8dbcd389ad","author":{"email":"640d9fe47775e6723f0355b7315e38f7d98d3539@gmail.com","name":"Gregory Haskins"},"message":"Makefile: default target should include running tests\n\nSigned-off-by: Greg Haskins <gregory.haskins@gmail.com>","distinct":true,"url":"https://api.github.com/repos/lehors/fabric/commits/71d113b0f6dbc474a51fe774110b5c8dbcd389ad"},{"sha":"334a114d10e947a16336766e5cbf48fbb5bdc9c4","author":{"email":"640d9fe47775e6723f0355b7315e38f7d98d3539@gmail.com","name":"Gregory Haskins"},"message":"Makefile: Fix \"proto\" target\n\nThis needs to be PHONY since there is a directory of the same name\n\nSigned-off-by: Greg Haskins <gregory.haskins@gmail.com>","distinct":true,"url":"https://api.github.com/repos/lehors/fabric/commits/334a114d10e947a16336766e5cbf48fbb5bdc9c4"},{"sha":"0ecdb140b30936e563c29b933abf34add4fca00f","author":{"email":"640d9fe47775e6723f0355b7315e38f7d98d3539@gmail.com","name":"Gregory Haskins"},"message":"Makefile: ensure .dummy artifacts are in .gitignore\n\nSigned-off-by: Greg Haskins <gregory.haskins@gmail.com>","distinct":true,"url":"https://api.github.com/repos/lehors/fabric/commits/0ecdb140b30936e563c29b933abf34add4fca00f"},{"sha":"b38173850556bd963b722d2bb5f94d370a12623a","author":{"email":"640d9fe47775e6723f0355b7315e38f7d98d3539@gmail.com","name":"Gregory Haskins"},"message":"Makefile: Add a placeholder for running code checkers\n\nSigned-off-by: Greg Haskins <gregory.haskins@gmail.com>","distinct":true,"url":"https://api.github.com/repos/lehors/fabric/commits/b38173850556bd963b722d2bb5f94d370a12623a"},{"sha":"2644796e2783f3bf2e33cb66a6cda4c1d13871cf","author":{"email":"0f42f29d35cbdec4971d8cbd40179b43b3a99c9c@us.ibm.com","name":"tdang"},"message":"on test fail, save log from chaincode container","distinct":true,"url":"https://api.github.com/repos/lehors/fabric/commits/2644796e2783f3bf2e33cb66a6cda4c1d13871cf"},{"sha":"2c3af309a711d3d83f6687e1722652eba5e1de81","author":{"email":"640d9fe47775e6723f0355b7315e38f7d98d3539@gmail.com","name":"Gregory Haskins"},"message":"Update install.md to use new makefile-based build for unit-tests\n\nSigned-off-by: Greg Haskins <gregory.haskins@gmail.com>","distinct":true,"url":"https://api.github.com/repos/lehors/fabric/commits/2c3af309a711d3d83f6687e1722652eba5e1de81"},{"sha":"965ce945f75e3a92b9d2b712bb31cf95006dff2e","author":{"email":"640d9fe47775e6723f0355b7315e38f7d98d3539@gmail.com","name":"Gregory Haskins"},"message":"Update install.md with proper .proto compilation instructions\n\nSigned-off-by: Greg Haskins <gregory.haskins@gmail.com>","distinct":true,"url":"https://api.github.com/repos/lehors/fabric/commits/965ce945f75e3a92b9d2b712bb31cf95006dff2e"},{"sha":"08ef50743c004b9d9da1ca997cd81fafaf401ef4","author":{"email":"336b2f4fb14e0a6aba0291ba81894e387297584e@us.ibm.com","name":"Arnaud J Le Hors"},"message":"Fixed broken links","distinct":false,"url":"https://api.github.com/repos/lehors/fabric/commits/08ef50743c004b9d9da1ca997cd81fafaf401ef4"},{"sha":"59c3dbce7b3458fb8294dce85bcabd0a7b57a84c","author":{"email":"336b2f4fb14e0a6aba0291ba81894e387297584e@us.ibm.com","name":"Arnaud J Le Hors"},"message":"Fixed broken links","distinct":false,"url":"https://api.github.com/repos/lehors/fabric/commits/59c3dbce7b3458fb8294dce85bcabd0a7b57a84c"},{"sha":"9428fd3c0f415fa36d67a3fc33bb8e6b52c86290","author":{"email":"336b2f4fb14e0a6aba0291ba81894e387297584e@us.ibm.com","name":"Arnaud J Le Hors"},"message":"revert unwanted mod change","distinct":false,"url":"https://api.github.com/repos/lehors/fabric/commits/9428fd3c0f415fa36d67a3fc33bb8e6b52c86290"},{"sha":"96bac65d44bea19b48fb85b545cbce705dbdf769","author":{"email":"336b2f4fb14e0a6aba0291ba81894e387297584e@us.ibm.com","name":"Arnaud J Le Hors"},"message":"[ci skip]","distinct":false,"url":"https://api.github.com/repos/lehors/fabric/commits/96bac65d44bea19b48fb85b545cbce705dbdf769"},{"sha":"78a09153b8f62fe2596996b35a0e2bf4a54ecf9d","author":{"email":"0f8d23b29bbdd001b628215e16a9924c573b94b4@gmail.com","name":"Sheehan Anderson"},"message":"Merge pull request #1390 from ghaskins/use-make-v3\n\nUse make to build fabric","distinct":true,"url":"https://api.github.com/repos/lehors/fabric/commits/78a09153b8f62fe2596996b35a0e2bf4a54ecf9d"},{"sha":"2db0b9bc94b26d578ed97f593e482461c767ea20","author":{"email":"0f8d23b29bbdd001b628215e16a9924c573b94b4@gmail.com","name":"Sheehan Anderson"},"message":"Merge pull request #1419 from tuand27613/behaveCClog\n\non behave test fail, save log from chaincode container","distinct":true,"url":"https://api.github.com/repos/lehors/fabric/commits/2db0b9bc94b26d578ed97f593e482461c767ea20"},{"sha":"f7b0b5c0a2fc98c898cd1972cc18c811d42c355e","author":{"email":"0f8d23b29bbdd001b628215e16a9924c573b94b4@gmail.com","name":"Sheehan Anderson"},"message":"Merge pull request #1420 from lehors/issue-1383\n\nFix Issue 1383 - broken links in docs/README.md","distinct":true,"url":"https://api.github.com/repos/lehors/fabric/commits/f7b0b5c0a2fc98c898cd1972cc18c811d42c355e"},{"sha":"f534337540f5b6e9def0cb387d28f49795ab5f91","author":{"email":"03e96c5567c34a0c8740d924ac0cf4021416c3b2@us.ibm.com","name":"bcbrock"},"message":"Change unofficial Docker port 4243 to official port 2375","distinct":true,"url":"https://api.github.com/repos/lehors/fabric/commits/f534337540f5b6e9def0cb387d28f49795ab5f91"}]}