{"action":"created","comment":{"url":"https://api.github.com/repos/google/shaderc/pulls/comments/60607848","id":60607848,"diff_hunk":"@@ -42,6 +43,46 @@ struct shaderc_compilation_result {\n       shaderc_compilation_status_null_result_object;\n };\n \n+// Compilation result class using a vector for holding the compilation\n+// output data.\n+class shaderc_compilation_result_vector : public shaderc_compilation_result {","path":"libshaderc/src/shaderc_private.h","position":28,"original_position":28,"commit_id":"c57ea47d1775e72d02414349f401ffebd583193a","original_commit_id":"c57ea47d1775e72d02414349f401ffebd583193a","user":{"login":"dekimir","id":1635074,"avatar_url":"https://avatars.githubusercontent.com/u/1635074?v=3","gravatar_id":"","url":"https://api.github.com/users/dekimir","html_url":"https://github.com/dekimir","followers_url":"https://api.github.com/users/dekimir/followers","following_url":"https://api.github.com/users/dekimir/following{/other_user}","gists_url":"https://api.github.com/users/dekimir/gists{/gist_id}","starred_url":"https://api.github.com/users/dekimir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dekimir/subscriptions","organizations_url":"https://api.github.com/users/dekimir/orgs","repos_url":"https://api.github.com/users/dekimir/repos","events_url":"https://api.github.com/users/dekimir/events{/privacy}","received_events_url":"https://api.github.com/users/dekimir/received_events","type":"User","site_admin":false},"body":"At this point, we should seriously consider having a third subclass that contains a text result.  It's weird to have two different compilation_results for SPIR-V words but only one compilation_result for two different outputs (text vs. SPIR-V).","created_at":"2016-04-21T15:59:47Z","updated_at":"2016-04-21T15:59:47Z","html_url":"https://github.com/google/shaderc/pull/206#discussion_r60607848","pull_request_url":"https://api.github.com/repos/google/shaderc/pulls/206","_links":{"self":{"href":"https://api.github.com/repos/google/shaderc/pulls/comments/60607848"},"html":{"href":"https://github.com/google/shaderc/pull/206#discussion_r60607848"},"pull_request":{"href":"https://api.github.com/repos/google/shaderc/pulls/206"}}},"pull_request":{"url":"https://api.github.com/repos/google/shaderc/pulls/206","id":67092181,"html_url":"https://github.com/google/shaderc/pull/206","diff_url":"https://github.com/google/shaderc/pull/206.diff","patch_url":"https://github.com/google/shaderc/pull/206.patch","issue_url":"https://api.github.com/repos/google/shaderc/issues/206","number":206,"state":"open","locked":false,"title":"Add assembling into shaderc.","user":{"login":"antiagainst","id":487928,"avatar_url":"https://avatars.githubusercontent.com/u/487928?v=3","gravatar_id":"","url":"https://api.github.com/users/antiagainst","html_url":"https://github.com/antiagainst","followers_url":"https://api.github.com/users/antiagainst/followers","following_url":"https://api.github.com/users/antiagainst/following{/other_user}","gists_url":"https://api.github.com/users/antiagainst/gists{/gist_id}","starred_url":"https://api.github.com/users/antiagainst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiagainst/subscriptions","organizations_url":"https://api.github.com/users/antiagainst/orgs","repos_url":"https://api.github.com/users/antiagainst/repos","events_url":"https://api.github.com/users/antiagainst/events{/privacy}","received_events_url":"https://api.github.com/users/antiagainst/received_events","type":"User","site_admin":false},"body":"Addresses #80.\r\n\r\nTODO: more tests for command-line.","created_at":"2016-04-19T21:22:29Z","updated_at":"2016-04-21T15:59:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1bad07f69e8c3fb36026f2b9eb18ec031cb094d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/shaderc/pulls/206/commits","review_comments_url":"https://api.github.com/repos/google/shaderc/pulls/206/comments","review_comment_url":"https://api.github.com/repos/google/shaderc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/shaderc/issues/206/comments","statuses_url":"https://api.github.com/repos/google/shaderc/statuses/c57ea47d1775e72d02414349f401ffebd583193a","head":{"label":"antiagainst:assemble-input","ref":"assemble-input","sha":"c57ea47d1775e72d02414349f401ffebd583193a","user":{"login":"antiagainst","id":487928,"avatar_url":"https://avatars.githubusercontent.com/u/487928?v=3","gravatar_id":"","url":"https://api.github.com/users/antiagainst","html_url":"https://github.com/antiagainst","followers_url":"https://api.github.com/users/antiagainst/followers","following_url":"https://api.github.com/users/antiagainst/following{/other_user}","gists_url":"https://api.github.com/users/antiagainst/gists{/gist_id}","starred_url":"https://api.github.com/users/antiagainst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiagainst/subscriptions","organizations_url":"https://api.github.com/users/antiagainst/orgs","repos_url":"https://api.github.com/users/antiagainst/repos","events_url":"https://api.github.com/users/antiagainst/events{/privacy}","received_events_url":"https://api.github.com/users/antiagainst/received_events","type":"User","site_admin":false},"repo":{"id":40363860,"name":"shaderc","full_name":"antiagainst/shaderc","owner":{"login":"antiagainst","id":487928,"avatar_url":"https://avatars.githubusercontent.com/u/487928?v=3","gravatar_id":"","url":"https://api.github.com/users/antiagainst","html_url":"https://github.com/antiagainst","followers_url":"https://api.github.com/users/antiagainst/followers","following_url":"https://api.github.com/users/antiagainst/following{/other_user}","gists_url":"https://api.github.com/users/antiagainst/gists{/gist_id}","starred_url":"https://api.github.com/users/antiagainst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiagainst/subscriptions","organizations_url":"https://api.github.com/users/antiagainst/orgs","repos_url":"https://api.github.com/users/antiagainst/repos","events_url":"https://api.github.com/users/antiagainst/events{/privacy}","received_events_url":"https://api.github.com/users/antiagainst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antiagainst/shaderc","description":"A collection of tools, libraries and tests for shader compilation.","fork":true,"url":"https://api.github.com/repos/antiagainst/shaderc","forks_url":"https://api.github.com/repos/antiagainst/shaderc/forks","keys_url":"https://api.github.com/repos/antiagainst/shaderc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antiagainst/shaderc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antiagainst/shaderc/teams","hooks_url":"https://api.github.com/repos/antiagainst/shaderc/hooks","issue_events_url":"https://api.github.com/repos/antiagainst/shaderc/issues/events{/number}","events_url":"https://api.github.com/repos/antiagainst/shaderc/events","assignees_url":"https://api.github.com/repos/antiagainst/shaderc/assignees{/user}","branches_url":"https://api.github.com/repos/antiagainst/shaderc/branches{/branch}","tags_url":"https://api.github.com/repos/antiagainst/shaderc/tags","blobs_url":"https://api.github.com/repos/antiagainst/shaderc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antiagainst/shaderc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antiagainst/shaderc/git/refs{/sha}","trees_url":"https://api.github.com/repos/antiagainst/shaderc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antiagainst/shaderc/statuses/{sha}","languages_url":"https://api.github.com/repos/antiagainst/shaderc/languages","stargazers_url":"https://api.github.com/repos/antiagainst/shaderc/stargazers","contributors_url":"https://api.github.com/repos/antiagainst/shaderc/contributors","subscribers_url":"https://api.github.com/repos/antiagainst/shaderc/subscribers","subscription_url":"https://api.github.com/repos/antiagainst/shaderc/subscription","commits_url":"https://api.github.com/repos/antiagainst/shaderc/commits{/sha}","git_commits_url":"https://api.github.com/repos/antiagainst/shaderc/git/commits{/sha}","comments_url":"https://api.github.com/repos/antiagainst/shaderc/comments{/number}","issue_comment_url":"https://api.github.com/repos/antiagainst/shaderc/issues/comments{/number}","contents_url":"https://api.github.com/repos/antiagainst/shaderc/contents/{+path}","compare_url":"https://api.github.com/repos/antiagainst/shaderc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antiagainst/shaderc/merges","archive_url":"https://api.github.com/repos/antiagainst/shaderc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antiagainst/shaderc/downloads","issues_url":"https://api.github.com/repos/antiagainst/shaderc/issues{/number}","pulls_url":"https://api.github.com/repos/antiagainst/shaderc/pulls{/number}","milestones_url":"https://api.github.com/repos/antiagainst/shaderc/milestones{/number}","notifications_url":"https://api.github.com/repos/antiagainst/shaderc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antiagainst/shaderc/labels{/name}","releases_url":"https://api.github.com/repos/antiagainst/shaderc/releases{/id}","deployments_url":"https://api.github.com/repos/antiagainst/shaderc/deployments","created_at":"2015-08-07T14:17:44Z","updated_at":"2016-04-13T17:39:12Z","pushed_at":"2016-04-21T13:19:57Z","git_url":"git://github.com/antiagainst/shaderc.git","ssh_url":"git@github.com:antiagainst/shaderc.git","clone_url":"https://github.com/antiagainst/shaderc.git","svn_url":"https://github.com/antiagainst/shaderc","homepage":"","size":597,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"c2dcb799e997779203da1207220cb1345582bcb7","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":40277133,"name":"shaderc","full_name":"google/shaderc","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/shaderc","description":"A collection of tools, libraries and tests for shader compilation.","fork":false,"url":"https://api.github.com/repos/google/shaderc","forks_url":"https://api.github.com/repos/google/shaderc/forks","keys_url":"https://api.github.com/repos/google/shaderc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/shaderc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/shaderc/teams","hooks_url":"https://api.github.com/repos/google/shaderc/hooks","issue_events_url":"https://api.github.com/repos/google/shaderc/issues/events{/number}","events_url":"https://api.github.com/repos/google/shaderc/events","assignees_url":"https://api.github.com/repos/google/shaderc/assignees{/user}","branches_url":"https://api.github.com/repos/google/shaderc/branches{/branch}","tags_url":"https://api.github.com/repos/google/shaderc/tags","blobs_url":"https://api.github.com/repos/google/shaderc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/shaderc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/shaderc/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/shaderc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/shaderc/statuses/{sha}","languages_url":"https://api.github.com/repos/google/shaderc/languages","stargazers_url":"https://api.github.com/repos/google/shaderc/stargazers","contributors_url":"https://api.github.com/repos/google/shaderc/contributors","subscribers_url":"https://api.github.com/repos/google/shaderc/subscribers","subscription_url":"https://api.github.com/repos/google/shaderc/subscription","commits_url":"https://api.github.com/repos/google/shaderc/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/shaderc/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/shaderc/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/shaderc/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/shaderc/contents/{+path}","compare_url":"https://api.github.com/repos/google/shaderc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/shaderc/merges","archive_url":"https://api.github.com/repos/google/shaderc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/shaderc/downloads","issues_url":"https://api.github.com/repos/google/shaderc/issues{/number}","pulls_url":"https://api.github.com/repos/google/shaderc/pulls{/number}","milestones_url":"https://api.github.com/repos/google/shaderc/milestones{/number}","notifications_url":"https://api.github.com/repos/google/shaderc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/shaderc/labels{/name}","releases_url":"https://api.github.com/repos/google/shaderc/releases{/id}","deployments_url":"https://api.github.com/repos/google/shaderc/deployments","created_at":"2015-08-06T01:17:42Z","updated_at":"2016-04-21T04:05:44Z","pushed_at":"2016-04-21T13:19:57Z","git_url":"git://github.com/google/shaderc.git","ssh_url":"git@github.com:google/shaderc.git","clone_url":"https://github.com/google/shaderc.git","svn_url":"https://github.com/google/shaderc","homepage":"","size":831,"stargazers_count":194,"watchers_count":194,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":8,"forks":22,"open_issues":8,"watchers":194,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/shaderc/pulls/206"},"html":{"href":"https://github.com/google/shaderc/pull/206"},"issue":{"href":"https://api.github.com/repos/google/shaderc/issues/206"},"comments":{"href":"https://api.github.com/repos/google/shaderc/issues/206/comments"},"review_comments":{"href":"https://api.github.com/repos/google/shaderc/pulls/206/comments"},"review_comment":{"href":"https://api.github.com/repos/google/shaderc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/shaderc/pulls/206/commits"},"statuses":{"href":"https://api.github.com/repos/google/shaderc/statuses/c57ea47d1775e72d02414349f401ffebd583193a"}}}}