{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-carbondata/pulls/comments/80176593","id":80176593,"diff_hunk":"@@ -124,6 +124,7 @@ struct TableSchema{\n \t1: required string table_id;  // ID used to\n \t2: required list<ColumnSchema> table_columns; // Columns in the table\n \t3: required SchemaEvolution schema_evolution; // History of schema evolution of this table\n+\t4: optional i32 block_size","path":"format/src/main/thrift/schema.thrift","position":4,"original_position":4,"commit_id":"ed40d0f8012297cc9e9cffb3812ef5d141e03879","original_commit_id":"ed40d0f8012297cc9e9cffb3812ef5d141e03879","user":{"login":"jackylk","id":6500698,"avatar_url":"https://avatars.githubusercontent.com/u/6500698?v=3","gravatar_id":"","url":"https://api.github.com/users/jackylk","html_url":"https://github.com/jackylk","followers_url":"https://api.github.com/users/jackylk/followers","following_url":"https://api.github.com/users/jackylk/following{/other_user}","gists_url":"https://api.github.com/users/jackylk/gists{/gist_id}","starred_url":"https://api.github.com/users/jackylk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackylk/subscriptions","organizations_url":"https://api.github.com/users/jackylk/orgs","repos_url":"https://api.github.com/users/jackylk/repos","events_url":"https://api.github.com/users/jackylk/events{/privacy}","received_events_url":"https://api.github.com/users/jackylk/received_events","type":"User","site_admin":false},"body":"Why save it to the file? It should be stored as a table level metadata.","created_at":"2016-09-23T03:27:56Z","updated_at":"2016-09-23T03:28:08Z","html_url":"https://github.com/apache/incubator-carbondata/pull/189#discussion_r80176593","pull_request_url":"https://api.github.com/repos/apache/incubator-carbondata/pulls/189","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-carbondata/pulls/comments/80176593"},"html":{"href":"https://github.com/apache/incubator-carbondata/pull/189#discussion_r80176593"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-carbondata/pulls/189"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-carbondata/pulls/189","id":86296735,"html_url":"https://github.com/apache/incubator-carbondata/pull/189","diff_url":"https://github.com/apache/incubator-carbondata/pull/189.diff","patch_url":"https://github.com/apache/incubator-carbondata/pull/189.patch","issue_url":"https://api.github.com/repos/apache/incubator-carbondata/issues/189","number":189,"state":"open","locked":false,"title":"[CARBONDATA-267] Set block_size for table on table level","user":{"login":"Zhangshunyu","id":13940237,"avatar_url":"https://avatars.githubusercontent.com/u/13940237?v=3","gravatar_id":"","url":"https://api.github.com/users/Zhangshunyu","html_url":"https://github.com/Zhangshunyu","followers_url":"https://api.github.com/users/Zhangshunyu/followers","following_url":"https://api.github.com/users/Zhangshunyu/following{/other_user}","gists_url":"https://api.github.com/users/Zhangshunyu/gists{/gist_id}","starred_url":"https://api.github.com/users/Zhangshunyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zhangshunyu/subscriptions","organizations_url":"https://api.github.com/users/Zhangshunyu/orgs","repos_url":"https://api.github.com/users/Zhangshunyu/repos","events_url":"https://api.github.com/users/Zhangshunyu/events{/privacy}","received_events_url":"https://api.github.com/users/Zhangshunyu/received_events","type":"User","site_admin":false},"body":"## Why raised this pr?\r\nTo configure block file size for each table on table level.\r\n## How to solve?\r\nAdd a new parameter in TableSchema, when create table, setting it in table properties and write this info into thrift file.\r\n## How to test?\r\nPass all the test cases and the new test case.","created_at":"2016-09-22T08:31:47Z","updated_at":"2016-09-23T03:28:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9999a60010633141de3bb5090c88829318a60e9f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-carbondata/pulls/189/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-carbondata/pulls/189/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-carbondata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-carbondata/issues/189/comments","statuses_url":"https://api.github.com/repos/apache/incubator-carbondata/statuses/ed40d0f8012297cc9e9cffb3812ef5d141e03879","head":{"label":"Zhangshunyu:blocksize922","ref":"blocksize922","sha":"ed40d0f8012297cc9e9cffb3812ef5d141e03879","user":{"login":"Zhangshunyu","id":13940237,"avatar_url":"https://avatars.githubusercontent.com/u/13940237?v=3","gravatar_id":"","url":"https://api.github.com/users/Zhangshunyu","html_url":"https://github.com/Zhangshunyu","followers_url":"https://api.github.com/users/Zhangshunyu/followers","following_url":"https://api.github.com/users/Zhangshunyu/following{/other_user}","gists_url":"https://api.github.com/users/Zhangshunyu/gists{/gist_id}","starred_url":"https://api.github.com/users/Zhangshunyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zhangshunyu/subscriptions","organizations_url":"https://api.github.com/users/Zhangshunyu/orgs","repos_url":"https://api.github.com/users/Zhangshunyu/repos","events_url":"https://api.github.com/users/Zhangshunyu/events{/privacy}","received_events_url":"https://api.github.com/users/Zhangshunyu/received_events","type":"User","site_admin":false},"repo":{"id":62268527,"name":"incubator-carbondata","full_name":"Zhangshunyu/incubator-carbondata","owner":{"login":"Zhangshunyu","id":13940237,"avatar_url":"https://avatars.githubusercontent.com/u/13940237?v=3","gravatar_id":"","url":"https://api.github.com/users/Zhangshunyu","html_url":"https://github.com/Zhangshunyu","followers_url":"https://api.github.com/users/Zhangshunyu/followers","following_url":"https://api.github.com/users/Zhangshunyu/following{/other_user}","gists_url":"https://api.github.com/users/Zhangshunyu/gists{/gist_id}","starred_url":"https://api.github.com/users/Zhangshunyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zhangshunyu/subscriptions","organizations_url":"https://api.github.com/users/Zhangshunyu/orgs","repos_url":"https://api.github.com/users/Zhangshunyu/repos","events_url":"https://api.github.com/users/Zhangshunyu/events{/privacy}","received_events_url":"https://api.github.com/users/Zhangshunyu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zhangshunyu/incubator-carbondata","description":"Mirror of Apache CarbonData (Incubating)","fork":true,"url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata","forks_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/forks","keys_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/teams","hooks_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/hooks","issue_events_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/events","assignees_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/tags","blobs_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/languages","stargazers_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/stargazers","contributors_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/contributors","subscribers_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/subscribers","subscription_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/subscription","commits_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/merges","archive_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/downloads","issues_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/labels{/name}","releases_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/Zhangshunyu/incubator-carbondata/deployments","created_at":"2016-06-30T01:11:53Z","updated_at":"2016-06-30T01:11:58Z","pushed_at":"2016-09-22T12:57:54Z","git_url":"git://github.com/Zhangshunyu/incubator-carbondata.git","ssh_url":"git@github.com:Zhangshunyu/incubator-carbondata.git","clone_url":"https://github.com/Zhangshunyu/incubator-carbondata.git","svn_url":"https://github.com/Zhangshunyu/incubator-carbondata","homepage":null,"size":37796,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"699d0a0505a31d440663c32cef82dbe5623c5d45","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117818,"name":"incubator-carbondata","full_name":"apache/incubator-carbondata","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-carbondata","description":"Mirror of Apache CarbonData (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-carbondata","forks_url":"https://api.github.com/repos/apache/incubator-carbondata/forks","keys_url":"https://api.github.com/repos/apache/incubator-carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-carbondata/teams","hooks_url":"https://api.github.com/repos/apache/incubator-carbondata/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-carbondata/events","assignees_url":"https://api.github.com/repos/apache/incubator-carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-carbondata/tags","blobs_url":"https://api.github.com/repos/apache/incubator-carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-carbondata/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-carbondata/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-carbondata/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-carbondata/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-carbondata/subscription","commits_url":"https://api.github.com/repos/apache/incubator-carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-carbondata/merges","archive_url":"https://api.github.com/repos/apache/incubator-carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-carbondata/downloads","issues_url":"https://api.github.com/repos/apache/incubator-carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-carbondata/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-carbondata/deployments","created_at":"2016-06-28T07:00:06Z","updated_at":"2016-09-23T01:30:51Z","pushed_at":"2016-09-22T22:31:54Z","git_url":"git://github.com/apache/incubator-carbondata.git","ssh_url":"git@github.com:apache/incubator-carbondata.git","clone_url":"https://github.com/apache/incubator-carbondata.git","svn_url":"https://github.com/apache/incubator-carbondata","homepage":null,"size":39370,"stargazers_count":118,"watchers_count":118,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":107,"mirror_url":"git://git.apache.org/incubator-carbondata.git","open_issues_count":22,"forks":107,"open_issues":22,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-carbondata/pulls/189"},"html":{"href":"https://github.com/apache/incubator-carbondata/pull/189"},"issue":{"href":"https://api.github.com/repos/apache/incubator-carbondata/issues/189"},"comments":{"href":"https://api.github.com/repos/apache/incubator-carbondata/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-carbondata/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-carbondata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-carbondata/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-carbondata/statuses/ed40d0f8012297cc9e9cffb3812ef5d141e03879"}}}}
{"actor":{"display_login":"jackylk"}}