{"action":"created","issue":{"url":"https://api.github.com/repos/geoext/geoext3/issues/147","repository_url":"https://api.github.com/repos/geoext/geoext3","labels_url":"https://api.github.com/repos/geoext/geoext3/issues/147/labels{/name}","comments_url":"https://api.github.com/repos/geoext/geoext3/issues/147/comments","events_url":"https://api.github.com/repos/geoext/geoext3/issues/147/events","html_url":"https://github.com/geoext/geoext3/pull/147","id":148165315,"number":147,"title":"Switch to more restrictive linter configuration","user":{"login":"bentrm","id":1186959,"avatar_url":"https://avatars.githubusercontent.com/u/1186959?v=3","gravatar_id":"","url":"https://api.github.com/users/bentrm","html_url":"https://github.com/bentrm","followers_url":"https://api.github.com/users/bentrm/followers","following_url":"https://api.github.com/users/bentrm/following{/other_user}","gists_url":"https://api.github.com/users/bentrm/gists{/gist_id}","starred_url":"https://api.github.com/users/bentrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bentrm/subscriptions","organizations_url":"https://api.github.com/users/bentrm/orgs","repos_url":"https://api.github.com/users/bentrm/repos","events_url":"https://api.github.com/users/bentrm/events{/privacy}","received_events_url":"https://api.github.com/users/bentrm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/geoext/geoext3/milestones/1","html_url":"https://github.com/geoext/geoext3/milestones/v3.0.0","labels_url":"https://api.github.com/repos/geoext/geoext3/milestones/1/labels","id":1675490,"number":1,"title":"v3.0.0","description":null,"creator":{"login":"bentrm","id":1186959,"avatar_url":"https://avatars.githubusercontent.com/u/1186959?v=3","gravatar_id":"","url":"https://api.github.com/users/bentrm","html_url":"https://github.com/bentrm","followers_url":"https://api.github.com/users/bentrm/followers","following_url":"https://api.github.com/users/bentrm/following{/other_user}","gists_url":"https://api.github.com/users/bentrm/gists{/gist_id}","starred_url":"https://api.github.com/users/bentrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bentrm/subscriptions","organizations_url":"https://api.github.com/users/bentrm/orgs","repos_url":"https://api.github.com/users/bentrm/repos","events_url":"https://api.github.com/users/bentrm/events{/privacy}","received_events_url":"https://api.github.com/users/bentrm/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":0,"state":"open","created_at":"2016-03-31T06:53:45Z","updated_at":"2016-04-15T06:59:04Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2016-04-13T19:48:55Z","updated_at":"2016-04-25T08:52:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/geoext/geoext3/pulls/147","html_url":"https://github.com/geoext/geoext3/pull/147","diff_url":"https://github.com/geoext/geoext3/pull/147.diff","patch_url":"https://github.com/geoext/geoext3/pull/147.patch"},"body":"This PR is WIP and meant to be a discussion starter offering some code example.\r\n\r\nESLint proves to be a valuable tool in the GeoExt3 setup. With further inspection I would like to suggest to use stricter linter options to improve code readability and make contributions easier for everyone.\r\n\r\nThis PR includes an extended `.eslintrc` that opts for more stringent code spacing and best practices throughout the code. The chosen options are my personal taste, so I'm open for discussion (Of course, I'm open for discussion if this is really necessary at all!). I will add some inline comments to the commits to show what the idea behind some of the more rigorous changes is.\r\n\r\nMost of the whitespace checks can be fixed automatically via ESLint, so I added a target `lint:fix` that takes care of that.\r\n\r\nThe new options are set to be warnings right now. If you accept this PR, I would start refactoring it to change each setting to be linter errors. Maybe one commit per setting is in order to see what has changed.\r\n\r\nAs an example, I adjusted the FeatureRenderer to the new options (This is not meant as critic, quite the opposite, this class is one of the more complex ons right now, so its perfect for demonstration.). To see existing warnings in the code base, please have a look at [the TravisCI build of this PR](https://travis-ci.org/geoext/geoext3/builds/122880734#L4217)."},"comment":{"url":"https://api.github.com/repos/geoext/geoext3/issues/comments/214213705","html_url":"https://github.com/geoext/geoext3/pull/147#issuecomment-214213705","issue_url":"https://api.github.com/repos/geoext/geoext3/issues/147","id":214213705,"user":{"login":"marcjansen","id":227934,"avatar_url":"https://avatars.githubusercontent.com/u/227934?v=3","gravatar_id":"","url":"https://api.github.com/users/marcjansen","html_url":"https://github.com/marcjansen","followers_url":"https://api.github.com/users/marcjansen/followers","following_url":"https://api.github.com/users/marcjansen/following{/other_user}","gists_url":"https://api.github.com/users/marcjansen/gists{/gist_id}","starred_url":"https://api.github.com/users/marcjansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcjansen/subscriptions","organizations_url":"https://api.github.com/users/marcjansen/orgs","repos_url":"https://api.github.com/users/marcjansen/repos","events_url":"https://api.github.com/users/marcjansen/events{/privacy}","received_events_url":"https://api.github.com/users/marcjansen/received_events","type":"User","site_admin":false},"created_at":"2016-04-25T08:52:10Z","updated_at":"2016-04-25T08:52:10Z","body":"Hey @bentrm, let's tackle the indentation in a follow-up PR. I am still :+1: once thsi cleanly applies again. So once you have rebased again, let's get this in!"}}