{"action":"created","issue":{"url":"https://api.github.com/repos/katspaugh/wavesurfer.js/issues/765","repository_url":"https://api.github.com/repos/katspaugh/wavesurfer.js","labels_url":"https://api.github.com/repos/katspaugh/wavesurfer.js/issues/765/labels{/name}","comments_url":"https://api.github.com/repos/katspaugh/wavesurfer.js/issues/765/comments","events_url":"https://api.github.com/repos/katspaugh/wavesurfer.js/issues/765/events","html_url":"https://github.com/katspaugh/wavesurfer.js/pull/765","id":164011902,"number":765,"title":"Enhance timeline plugin to support multi-canvas rendering","user":{"login":"chrisparton1991","id":13063119,"avatar_url":"https://avatars.githubusercontent.com/u/13063119?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisparton1991","html_url":"https://github.com/chrisparton1991","followers_url":"https://api.github.com/users/chrisparton1991/followers","following_url":"https://api.github.com/users/chrisparton1991/following{/other_user}","gists_url":"https://api.github.com/users/chrisparton1991/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisparton1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisparton1991/subscriptions","organizations_url":"https://api.github.com/users/chrisparton1991/orgs","repos_url":"https://api.github.com/users/chrisparton1991/repos","events_url":"https://api.github.com/users/chrisparton1991/events{/privacy}","received_events_url":"https://api.github.com/users/chrisparton1991/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/katspaugh/wavesurfer.js/labels/%E5%A4%A7%E4%B8%88%E5%A4%AB","name":"大丈夫","color":"009800"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-07-06T07:03:34Z","updated_at":"2016-07-06T22:13:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/katspaugh/wavesurfer.js/pulls/765","html_url":"https://github.com/katspaugh/wavesurfer.js/pull/765","diff_url":"https://github.com/katspaugh/wavesurfer.js/pull/765.diff","patch_url":"https://github.com/katspaugh/wavesurfer.js/pull/765.patch"},"body":"A merge request to cover #696. I have endeavoured to maintain backwards compatibility with the `Canvas` renderer. I have attached a [multicanvas-timeline-tests.zip](https://github.com/katspaugh/wavesurfer.js/files/349198/multicanvas-timeline-tests.zip) file containing my changes, along with a test html and js file in the `src` directory that can be run to visually observe the results.\r\n\r\nI don't personally use the timeline plugin, so there may be some edge cases that I'm not aware of. I've changed some function names, e.g. `drawTimeCanvas` -> `drawTimeCanvases`, so that's a potential breaking change.\r\n\r\n@chinshr and @jeremylach, it would be great if you could download the attached zip file and see if the changes meet your needs before the changes are merged (assuming they are ☺).\r\n"},"comment":{"url":"https://api.github.com/repos/katspaugh/wavesurfer.js/issues/comments/230923310","html_url":"https://github.com/katspaugh/wavesurfer.js/pull/765#issuecomment-230923310","issue_url":"https://api.github.com/repos/katspaugh/wavesurfer.js/issues/765","id":230923310,"user":{"login":"chrisparton1991","id":13063119,"avatar_url":"https://avatars.githubusercontent.com/u/13063119?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisparton1991","html_url":"https://github.com/chrisparton1991","followers_url":"https://api.github.com/users/chrisparton1991/followers","following_url":"https://api.github.com/users/chrisparton1991/following{/other_user}","gists_url":"https://api.github.com/users/chrisparton1991/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisparton1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisparton1991/subscriptions","organizations_url":"https://api.github.com/users/chrisparton1991/orgs","repos_url":"https://api.github.com/users/chrisparton1991/repos","events_url":"https://api.github.com/users/chrisparton1991/events{/privacy}","received_events_url":"https://api.github.com/users/chrisparton1991/received_events","type":"User","site_admin":false},"created_at":"2016-07-06T22:13:45Z","updated_at":"2016-07-06T22:13:45Z","body":"Thanks for your feedback @jeremylach. Did you test this using my test case, or with your own code? The timeline scrolls correctly for me in the `Multicanvas Timeline: Scrolling` test. See this [Youtube video](https://www.youtube.com/watch?v=XZqxA119DRs) of how it looks for me on Chrome.\r\n\r\nNote that the timeline doesn't start scrolling until the time indicator reaches the middle of the visible waveform (around 5 seconds in).\r\n\r\nQuestions:\r\n- Do you not see this behaviour, or is this behaviour incorrect?\r\n- What browser are you using?\r\n- Are you using a high DPI monitor (e.g. Retina display)?"}}
{"actor":{"display_login":"chrisparton1991"}}