{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/63359172","id":63359172,"diff_hunk":"@@ -934,3 +935,31 @@ func (checker *PodAffinityChecker) NodeMatchPodAffinityAntiAffinity(pod *api.Pod\n \t}\n \treturn true\n }\n+\n+// Determine if a pod is scheduled with best-effort QoS\n+func isPodBestEffort(pod *api.Pod) bool {\n+\treturn qosutil.GetPodQos(pod) == qosutil.BestEffort\n+}\n+\n+// MemoryPressurePredicate checks if a pod can be scheduled on a node","path":"plugin/pkg/scheduler/algorithm/predicates/predicates.go","position":18,"original_position":18,"commit_id":"63c1b1df0d080d40a384d8c14b3a045bcba7bf3e","original_commit_id":"d24a3ef983f6b7248b77cce850eb9a200c92dd04","user":{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars.githubusercontent.com/u/6233452?v=3","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},"body":"s/MemoryPressurePredicate/CheckNodeMemoryPressurePredicate","created_at":"2016-05-16T14:11:58Z","updated_at":"2016-05-16T14:11:58Z","html_url":"https://github.com/kubernetes/kubernetes/pull/25531#discussion_r63359172","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25531","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/63359172"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25531#discussion_r63359172"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25531"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25531","id":69824956,"html_url":"https://github.com/kubernetes/kubernetes/pull/25531","diff_url":"https://github.com/kubernetes/kubernetes/pull/25531.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/25531.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25531","number":25531,"state":"open","locked":false,"title":"WIP: Introduce node memory pressure condition to scheduler","user":{"login":"ingvagabund","id":8055242,"avatar_url":"https://avatars.githubusercontent.com/u/8055242?v=3","gravatar_id":"","url":"https://api.github.com/users/ingvagabund","html_url":"https://github.com/ingvagabund","followers_url":"https://api.github.com/users/ingvagabund/followers","following_url":"https://api.github.com/users/ingvagabund/following{/other_user}","gists_url":"https://api.github.com/users/ingvagabund/gists{/gist_id}","starred_url":"https://api.github.com/users/ingvagabund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingvagabund/subscriptions","organizations_url":"https://api.github.com/users/ingvagabund/orgs","repos_url":"https://api.github.com/users/ingvagabund/repos","events_url":"https://api.github.com/users/ingvagabund/events{/privacy}","received_events_url":"https://api.github.com/users/ingvagabund/received_events","type":"User","site_admin":false},"body":"Following the work done by @derekwaynecarr at https://github.com/kubernetes/kubernetes/pull/21274, introducing memory pressure predicate for scheduler.\r\n\r\nMissing:\r\n\r\n* write down unit-test\r\n* test the implementation\r\n\r\nAt the moment this is a heads up for further discussion how the new node's memory pressure condition should be handled in the generic scheduler.\r\n\r\n**Additional info**\r\n\r\n* Based on [1], only best effort pods are subject to filtering.\r\n* Based on [2], best effort pods are those pods \"iff requests & limits are not specified for any resource across all containers\".\r\n\r\n[1] https://github.com/derekwaynecarr/kubernetes/blob/542668cc7998fe0acb315a43731e1f45ecdcc85b/docs/proposals/kubelet-eviction.md#scheduler\r\n[2] https://github.com/kubernetes/kubernetes/pull/14943\r\n","created_at":"2016-05-12T12:07:37Z","updated_at":"2016-05-16T14:11:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6701b1819f18b5c126e544b364f6cec283f7dd2","assignee":{"login":"davidopp","id":8264113,"avatar_url":"https://avatars.githubusercontent.com/u/8264113?v=3","gravatar_id":"","url":"https://api.github.com/users/davidopp","html_url":"https://github.com/davidopp","followers_url":"https://api.github.com/users/davidopp/followers","following_url":"https://api.github.com/users/davidopp/following{/other_user}","gists_url":"https://api.github.com/users/davidopp/gists{/gist_id}","starred_url":"https://api.github.com/users/davidopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidopp/subscriptions","organizations_url":"https://api.github.com/users/davidopp/orgs","repos_url":"https://api.github.com/users/davidopp/repos","events_url":"https://api.github.com/users/davidopp/events{/privacy}","received_events_url":"https://api.github.com/users/davidopp/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25531/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25531/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25531/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/63c1b1df0d080d40a384d8c14b3a045bcba7bf3e","head":{"label":"ingvagabund:introduce-memory-pressure-to-scheduler","ref":"introduce-memory-pressure-to-scheduler","sha":"63c1b1df0d080d40a384d8c14b3a045bcba7bf3e","user":{"login":"ingvagabund","id":8055242,"avatar_url":"https://avatars.githubusercontent.com/u/8055242?v=3","gravatar_id":"","url":"https://api.github.com/users/ingvagabund","html_url":"https://github.com/ingvagabund","followers_url":"https://api.github.com/users/ingvagabund/followers","following_url":"https://api.github.com/users/ingvagabund/following{/other_user}","gists_url":"https://api.github.com/users/ingvagabund/gists{/gist_id}","starred_url":"https://api.github.com/users/ingvagabund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingvagabund/subscriptions","organizations_url":"https://api.github.com/users/ingvagabund/orgs","repos_url":"https://api.github.com/users/ingvagabund/repos","events_url":"https://api.github.com/users/ingvagabund/events{/privacy}","received_events_url":"https://api.github.com/users/ingvagabund/received_events","type":"User","site_admin":false},"repo":{"id":36929310,"name":"kubernetes","full_name":"ingvagabund/kubernetes","owner":{"login":"ingvagabund","id":8055242,"avatar_url":"https://avatars.githubusercontent.com/u/8055242?v=3","gravatar_id":"","url":"https://api.github.com/users/ingvagabund","html_url":"https://github.com/ingvagabund","followers_url":"https://api.github.com/users/ingvagabund/followers","following_url":"https://api.github.com/users/ingvagabund/following{/other_user}","gists_url":"https://api.github.com/users/ingvagabund/gists{/gist_id}","starred_url":"https://api.github.com/users/ingvagabund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingvagabund/subscriptions","organizations_url":"https://api.github.com/users/ingvagabund/orgs","repos_url":"https://api.github.com/users/ingvagabund/repos","events_url":"https://api.github.com/users/ingvagabund/events{/privacy}","received_events_url":"https://api.github.com/users/ingvagabund/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ingvagabund/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/ingvagabund/kubernetes","forks_url":"https://api.github.com/repos/ingvagabund/kubernetes/forks","keys_url":"https://api.github.com/repos/ingvagabund/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ingvagabund/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ingvagabund/kubernetes/teams","hooks_url":"https://api.github.com/repos/ingvagabund/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/ingvagabund/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/ingvagabund/kubernetes/events","assignees_url":"https://api.github.com/repos/ingvagabund/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/ingvagabund/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/ingvagabund/kubernetes/tags","blobs_url":"https://api.github.com/repos/ingvagabund/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ingvagabund/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ingvagabund/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/ingvagabund/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ingvagabund/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/ingvagabund/kubernetes/languages","stargazers_url":"https://api.github.com/repos/ingvagabund/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/ingvagabund/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/ingvagabund/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/ingvagabund/kubernetes/subscription","commits_url":"https://api.github.com/repos/ingvagabund/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/ingvagabund/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/ingvagabund/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/ingvagabund/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/ingvagabund/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/ingvagabund/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ingvagabund/kubernetes/merges","archive_url":"https://api.github.com/repos/ingvagabund/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ingvagabund/kubernetes/downloads","issues_url":"https://api.github.com/repos/ingvagabund/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/ingvagabund/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/ingvagabund/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/ingvagabund/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ingvagabund/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/ingvagabund/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/ingvagabund/kubernetes/deployments","created_at":"2015-06-05T11:30:51Z","updated_at":"2016-01-25T16:18:15Z","pushed_at":"2016-05-16T12:21:46Z","git_url":"git://github.com/ingvagabund/kubernetes.git","ssh_url":"git@github.com:ingvagabund/kubernetes.git","clone_url":"https://github.com/ingvagabund/kubernetes.git","svn_url":"https://github.com/ingvagabund/kubernetes","homepage":"http://kubernetes.io","size":192942,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"c20dcfc406599a1896d396b601776ac97c09a7fb","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-05-16T13:38:13Z","pushed_at":"2016-05-16T14:05:00Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":395112,"stargazers_count":14395,"watchers_count":14395,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4337,"mirror_url":null,"open_issues_count":3580,"forks":4337,"open_issues":3580,"watchers":14395,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25531"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25531"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25531"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25531/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25531/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25531/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/63c1b1df0d080d40a384d8c14b3a045bcba7bf3e"}}}}