{"action":"created","comment":{"url":"https://api.github.com/repos/maidsafe/safe_vault/pulls/comments/54558287","id":54558287,"diff_hunk":"@@ -98,11 +98,16 @@ impl Client {\n     }\n \n     /// Send a `Get` request to the network and return the received response.\n-    pub fn get(&mut self, request: DataRequest) -> Option<ResponseMessage> {\n-        unwrap_result!(self.routing_client\n-                           .send_get_request(Authority::NaeManager(request.name()),\n-                                             request.clone()));\n-        self.wait_for_response()\n+    pub fn get(&mut self, request: DataRequest, max_attempts: u32) -> Option<ResponseMessage> {\n+        for i in 0..max_attempts {\n+            unwrap_result!(self.routing_client\n+                               .send_get_request(Authority::NaeManager(request.name()),\n+                                                 request.clone()));\n+            if let Some(response) = self.wait_for_response() {","path":"tests/detail/client.rs","position":14,"original_position":14,"commit_id":"401c020ac774127ac54588d43d8053fa510951cb","original_commit_id":"401c020ac774127ac54588d43d8053fa510951cb","user":{"login":"maqi","id":568777,"avatar_url":"https://avatars.githubusercontent.com/u/568777?v=3","gravatar_id":"","url":"https://api.github.com/users/maqi","html_url":"https://github.com/maqi","followers_url":"https://api.github.com/users/maqi/followers","following_url":"https://api.github.com/users/maqi/following{/other_user}","gists_url":"https://api.github.com/users/maqi/gists{/gist_id}","starred_url":"https://api.github.com/users/maqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maqi/subscriptions","organizations_url":"https://api.github.com/users/maqi/orgs","repos_url":"https://api.github.com/users/maqi/repos","events_url":"https://api.github.com/users/maqi/events{/privacy}","received_events_url":"https://api.github.com/users/maqi/received_events","type":"User","site_admin":false},"body":"wait_for_response will return with both GetFailure and GetSuccess, which means this max_attempts only means:\r\nin case of time_out (no event from network), there will be max_attempts; if there is failure (get or put failure), immediately return (which may happen if PutSucess is sent from MM and we are trying to fetch from SDM/IDM immediately after).\r\nis this mean to be like this?","created_at":"2016-03-01T12:09:59Z","updated_at":"2016-03-01T12:09:59Z","html_url":"https://github.com/maidsafe/safe_vault/pull/343#discussion_r54558287","pull_request_url":"https://api.github.com/repos/maidsafe/safe_vault/pulls/343","_links":{"self":{"href":"https://api.github.com/repos/maidsafe/safe_vault/pulls/comments/54558287"},"html":{"href":"https://github.com/maidsafe/safe_vault/pull/343#discussion_r54558287"},"pull_request":{"href":"https://api.github.com/repos/maidsafe/safe_vault/pulls/343"}}},"pull_request":{"url":"https://api.github.com/repos/maidsafe/safe_vault/pulls/343","id":61226095,"html_url":"https://github.com/maidsafe/safe_vault/pull/343","diff_url":"https://github.com/maidsafe/safe_vault/pull/343.diff","patch_url":"https://github.com/maidsafe/safe_vault/pull/343.patch","issue_url":"https://api.github.com/repos/maidsafe/safe_vault/issues/343","number":343,"state":"open","locked":false,"title":"For Get requests in the CI tests, allow 2 failures where appropriate.","user":{"login":"Fraser999","id":190532,"avatar_url":"https://avatars.githubusercontent.com/u/190532?v=3","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false},"body":"\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.svg\" height=\"40\" alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/maidsafe/safe_vault/343)\n<!-- Reviewable:end -->\n","created_at":"2016-03-01T11:06:54Z","updated_at":"2016-03-01T12:09:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86796311aa2a888d9b48e22b36c7c68dc3975676","assignee":{"login":"maqi","id":568777,"avatar_url":"https://avatars.githubusercontent.com/u/568777?v=3","gravatar_id":"","url":"https://api.github.com/users/maqi","html_url":"https://github.com/maqi","followers_url":"https://api.github.com/users/maqi/followers","following_url":"https://api.github.com/users/maqi/following{/other_user}","gists_url":"https://api.github.com/users/maqi/gists{/gist_id}","starred_url":"https://api.github.com/users/maqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maqi/subscriptions","organizations_url":"https://api.github.com/users/maqi/orgs","repos_url":"https://api.github.com/users/maqi/repos","events_url":"https://api.github.com/users/maqi/events{/privacy}","received_events_url":"https://api.github.com/users/maqi/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/maidsafe/safe_vault/pulls/343/commits","review_comments_url":"https://api.github.com/repos/maidsafe/safe_vault/pulls/343/comments","review_comment_url":"https://api.github.com/repos/maidsafe/safe_vault/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maidsafe/safe_vault/issues/343/comments","statuses_url":"https://api.github.com/repos/maidsafe/safe_vault/statuses/401c020ac774127ac54588d43d8053fa510951cb","head":{"label":"Fraser999:ci_gets","ref":"ci_gets","sha":"401c020ac774127ac54588d43d8053fa510951cb","user":{"login":"Fraser999","id":190532,"avatar_url":"https://avatars.githubusercontent.com/u/190532?v=3","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false},"repo":{"id":33867413,"name":"safe_vault","full_name":"Fraser999/safe_vault","owner":{"login":"Fraser999","id":190532,"avatar_url":"https://avatars.githubusercontent.com/u/190532?v=3","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fraser999/safe_vault","description":"An Implementation of a SAFE Network Vault","fork":true,"url":"https://api.github.com/repos/Fraser999/safe_vault","forks_url":"https://api.github.com/repos/Fraser999/safe_vault/forks","keys_url":"https://api.github.com/repos/Fraser999/safe_vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fraser999/safe_vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fraser999/safe_vault/teams","hooks_url":"https://api.github.com/repos/Fraser999/safe_vault/hooks","issue_events_url":"https://api.github.com/repos/Fraser999/safe_vault/issues/events{/number}","events_url":"https://api.github.com/repos/Fraser999/safe_vault/events","assignees_url":"https://api.github.com/repos/Fraser999/safe_vault/assignees{/user}","branches_url":"https://api.github.com/repos/Fraser999/safe_vault/branches{/branch}","tags_url":"https://api.github.com/repos/Fraser999/safe_vault/tags","blobs_url":"https://api.github.com/repos/Fraser999/safe_vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fraser999/safe_vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fraser999/safe_vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fraser999/safe_vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fraser999/safe_vault/statuses/{sha}","languages_url":"https://api.github.com/repos/Fraser999/safe_vault/languages","stargazers_url":"https://api.github.com/repos/Fraser999/safe_vault/stargazers","contributors_url":"https://api.github.com/repos/Fraser999/safe_vault/contributors","subscribers_url":"https://api.github.com/repos/Fraser999/safe_vault/subscribers","subscription_url":"https://api.github.com/repos/Fraser999/safe_vault/subscription","commits_url":"https://api.github.com/repos/Fraser999/safe_vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fraser999/safe_vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fraser999/safe_vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fraser999/safe_vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fraser999/safe_vault/contents/{+path}","compare_url":"https://api.github.com/repos/Fraser999/safe_vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fraser999/safe_vault/merges","archive_url":"https://api.github.com/repos/Fraser999/safe_vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fraser999/safe_vault/downloads","issues_url":"https://api.github.com/repos/Fraser999/safe_vault/issues{/number}","pulls_url":"https://api.github.com/repos/Fraser999/safe_vault/pulls{/number}","milestones_url":"https://api.github.com/repos/Fraser999/safe_vault/milestones{/number}","notifications_url":"https://api.github.com/repos/Fraser999/safe_vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fraser999/safe_vault/labels{/name}","releases_url":"https://api.github.com/repos/Fraser999/safe_vault/releases{/id}","deployments_url":"https://api.github.com/repos/Fraser999/safe_vault/deployments","created_at":"2015-04-13T12:32:43Z","updated_at":"2016-01-12T15:29:58Z","pushed_at":"2016-03-01T11:07:01Z","git_url":"git://github.com/Fraser999/safe_vault.git","ssh_url":"git@github.com:Fraser999/safe_vault.git","clone_url":"https://github.com/Fraser999/safe_vault.git","svn_url":"https://github.com/Fraser999/safe_vault","homepage":"","size":2031,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"maidsafe:master","ref":"master","sha":"07f7fc886a89744c08571733a8dd81e268767750","user":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"repo":{"id":32022044,"name":"safe_vault","full_name":"maidsafe/safe_vault","owner":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/maidsafe/safe_vault","description":"An Implementation of a SAFE Network Vault","fork":false,"url":"https://api.github.com/repos/maidsafe/safe_vault","forks_url":"https://api.github.com/repos/maidsafe/safe_vault/forks","keys_url":"https://api.github.com/repos/maidsafe/safe_vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maidsafe/safe_vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maidsafe/safe_vault/teams","hooks_url":"https://api.github.com/repos/maidsafe/safe_vault/hooks","issue_events_url":"https://api.github.com/repos/maidsafe/safe_vault/issues/events{/number}","events_url":"https://api.github.com/repos/maidsafe/safe_vault/events","assignees_url":"https://api.github.com/repos/maidsafe/safe_vault/assignees{/user}","branches_url":"https://api.github.com/repos/maidsafe/safe_vault/branches{/branch}","tags_url":"https://api.github.com/repos/maidsafe/safe_vault/tags","blobs_url":"https://api.github.com/repos/maidsafe/safe_vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maidsafe/safe_vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maidsafe/safe_vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/maidsafe/safe_vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maidsafe/safe_vault/statuses/{sha}","languages_url":"https://api.github.com/repos/maidsafe/safe_vault/languages","stargazers_url":"https://api.github.com/repos/maidsafe/safe_vault/stargazers","contributors_url":"https://api.github.com/repos/maidsafe/safe_vault/contributors","subscribers_url":"https://api.github.com/repos/maidsafe/safe_vault/subscribers","subscription_url":"https://api.github.com/repos/maidsafe/safe_vault/subscription","commits_url":"https://api.github.com/repos/maidsafe/safe_vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/maidsafe/safe_vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/maidsafe/safe_vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/maidsafe/safe_vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/maidsafe/safe_vault/contents/{+path}","compare_url":"https://api.github.com/repos/maidsafe/safe_vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maidsafe/safe_vault/merges","archive_url":"https://api.github.com/repos/maidsafe/safe_vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maidsafe/safe_vault/downloads","issues_url":"https://api.github.com/repos/maidsafe/safe_vault/issues{/number}","pulls_url":"https://api.github.com/repos/maidsafe/safe_vault/pulls{/number}","milestones_url":"https://api.github.com/repos/maidsafe/safe_vault/milestones{/number}","notifications_url":"https://api.github.com/repos/maidsafe/safe_vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maidsafe/safe_vault/labels{/name}","releases_url":"https://api.github.com/repos/maidsafe/safe_vault/releases{/id}","deployments_url":"https://api.github.com/repos/maidsafe/safe_vault/deployments","created_at":"2015-03-11T14:27:31Z","updated_at":"2016-02-20T11:00:09Z","pushed_at":"2016-03-01T12:00:50Z","git_url":"git://github.com/maidsafe/safe_vault.git","ssh_url":"git@github.com:maidsafe/safe_vault.git","clone_url":"https://github.com/maidsafe/safe_vault.git","svn_url":"https://github.com/maidsafe/safe_vault","homepage":"","size":27848,"stargazers_count":31,"watchers_count":31,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"open_issues_count":3,"forks":30,"open_issues":3,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maidsafe/safe_vault/pulls/343"},"html":{"href":"https://github.com/maidsafe/safe_vault/pull/343"},"issue":{"href":"https://api.github.com/repos/maidsafe/safe_vault/issues/343"},"comments":{"href":"https://api.github.com/repos/maidsafe/safe_vault/issues/343/comments"},"review_comments":{"href":"https://api.github.com/repos/maidsafe/safe_vault/pulls/343/comments"},"review_comment":{"href":"https://api.github.com/repos/maidsafe/safe_vault/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maidsafe/safe_vault/pulls/343/commits"},"statuses":{"href":"https://api.github.com/repos/maidsafe/safe_vault/statuses/401c020ac774127ac54588d43d8053fa510951cb"}}}}