{"action":"created","comment":{"url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/comments/88052006","pull_request_review_id":8637453,"id":88052006,"diff_hunk":"@@ -9,12 +9,8 @@\n     %p= @membership_application.phone_number\n   %p= mail_to @membership_application.company_email, @membership_application.company_email\n   .wpcf7\n-    = form_for @membership_application, url: membership_application_path do |f|\n-      = f.select(:status, [['Pending', 'Pending'],\n-                           ['Accepted', 'Accepted'],\n-                           ['Rejected', 'Rejected']])\n-      = f.submit 'Update', class: 'wpcf7-submit'\n-      - if @membership_application.status == 'Accepted'\n-        %p Membership accepted at #{@membership_application.updated_at.strftime('%F')}\n-      - if @membership_application.status == 'Rejected'\n-        %p Membership rejected at #{@membership_application.updated_at.strftime('%F')}\n\\ No newline at end of file\n+    Application Status:\n+    - if policy(@membership_application).permitted_attributes_for_edit.include? :status","path":"app/views/membership_applications/show.html.haml","position":15,"original_position":15,"commit_id":"667f96c678889719ad6bf2fd91c93fe6f6432bb7","original_commit_id":"667f96c678889719ad6bf2fd91c93fe6f6432bb7","user":{"login":"weedySeaDragon","id":673794,"avatar_url":"https://avatars.githubusercontent.com/u/673794?v=3","gravatar_id":"","url":"https://api.github.com/users/weedySeaDragon","html_url":"https://github.com/weedySeaDragon","followers_url":"https://api.github.com/users/weedySeaDragon/followers","following_url":"https://api.github.com/users/weedySeaDragon/following{/other_user}","gists_url":"https://api.github.com/users/weedySeaDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/weedySeaDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weedySeaDragon/subscriptions","organizations_url":"https://api.github.com/users/weedySeaDragon/orgs","repos_url":"https://api.github.com/users/weedySeaDragon/repos","events_url":"https://api.github.com/users/weedySeaDragon/events{/privacy}","received_events_url":"https://api.github.com/users/weedySeaDragon/received_events","type":"User","site_admin":false},"body":"agreed.  The `- if...` seems much too heavy since it invokes the policy.","created_at":"2016-11-15T16:16:36Z","updated_at":"2016-11-15T16:16:36Z","html_url":"https://github.com/AgileVentures/shf-project/pull/24#discussion_r88052006","pull_request_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/comments/88052006"},"html":{"href":"https://github.com/AgileVentures/shf-project/pull/24#discussion_r88052006"},"pull_request":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/24","id":93716843,"html_url":"https://github.com/AgileVentures/shf-project/pull/24","diff_url":"https://github.com/AgileVentures/shf-project/pull/24.diff","patch_url":"https://github.com/AgileVentures/shf-project/pull/24.patch","issue_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/24","number":24,"state":"open","locked":false,"title":"161114 application status refactor to use policy","user":{"login":"weedySeaDragon","id":673794,"avatar_url":"https://avatars.githubusercontent.com/u/673794?v=3","gravatar_id":"","url":"https://api.github.com/users/weedySeaDragon","html_url":"https://github.com/weedySeaDragon","followers_url":"https://api.github.com/users/weedySeaDragon/followers","following_url":"https://api.github.com/users/weedySeaDragon/following{/other_user}","gists_url":"https://api.github.com/users/weedySeaDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/weedySeaDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weedySeaDragon/subscriptions","organizations_url":"https://api.github.com/users/weedySeaDragon/orgs","repos_url":"https://api.github.com/users/weedySeaDragon/repos","events_url":"https://api.github.com/users/weedySeaDragon/events{/privacy}","received_events_url":"https://api.github.com/users/weedySeaDragon/received_events","type":"User","site_admin":false},"body":"PT Story:  **refactor 'Admin reviews application' to use Pundit policy for status** \r\nhttps://www.pivotaltracker.com/story/show/134291433\r\n\r\n_This PR depends on PR #22  because it refactors/builds on it_ \r\n\r\nChanges proposed in this pull request:\r\n1.  Use the MembershipApplicationPolicy to control who can edit the status\r\n2. create a partial for editing the status (just pulled the existing form into a partial)\r\n3. Simplified the status and timestamp (just downcase the status and add on the timestamp)\r\n\r\n\r\nReady for review\r\n@thesuss & ??\r\n","created_at":"2016-11-15T07:55:39Z","updated_at":"2016-11-15T16:16:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5051023dbfec8a3117aa09a30067944e185db9d9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/24/commits","review_comments_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/24/comments","review_comment_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/24/comments","statuses_url":"https://api.github.com/repos/AgileVentures/shf-project/statuses/667f96c678889719ad6bf2fd91c93fe6f6432bb7","head":{"label":"weedySeaDragon:161114-application-status-refactor-to-use-policy","ref":"161114-application-status-refactor-to-use-policy","sha":"667f96c678889719ad6bf2fd91c93fe6f6432bb7","user":{"login":"weedySeaDragon","id":673794,"avatar_url":"https://avatars.githubusercontent.com/u/673794?v=3","gravatar_id":"","url":"https://api.github.com/users/weedySeaDragon","html_url":"https://github.com/weedySeaDragon","followers_url":"https://api.github.com/users/weedySeaDragon/followers","following_url":"https://api.github.com/users/weedySeaDragon/following{/other_user}","gists_url":"https://api.github.com/users/weedySeaDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/weedySeaDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weedySeaDragon/subscriptions","organizations_url":"https://api.github.com/users/weedySeaDragon/orgs","repos_url":"https://api.github.com/users/weedySeaDragon/repos","events_url":"https://api.github.com/users/weedySeaDragon/events{/privacy}","received_events_url":"https://api.github.com/users/weedySeaDragon/received_events","type":"User","site_admin":false},"repo":{"id":72142277,"name":"shf-project","full_name":"weedySeaDragon/shf-project","owner":{"login":"weedySeaDragon","id":673794,"avatar_url":"https://avatars.githubusercontent.com/u/673794?v=3","gravatar_id":"","url":"https://api.github.com/users/weedySeaDragon","html_url":"https://github.com/weedySeaDragon","followers_url":"https://api.github.com/users/weedySeaDragon/followers","following_url":"https://api.github.com/users/weedySeaDragon/following{/other_user}","gists_url":"https://api.github.com/users/weedySeaDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/weedySeaDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weedySeaDragon/subscriptions","organizations_url":"https://api.github.com/users/weedySeaDragon/orgs","repos_url":"https://api.github.com/users/weedySeaDragon/repos","events_url":"https://api.github.com/users/weedySeaDragon/events{/privacy}","received_events_url":"https://api.github.com/users/weedySeaDragon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/weedySeaDragon/shf-project","description":null,"fork":true,"url":"https://api.github.com/repos/weedySeaDragon/shf-project","forks_url":"https://api.github.com/repos/weedySeaDragon/shf-project/forks","keys_url":"https://api.github.com/repos/weedySeaDragon/shf-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weedySeaDragon/shf-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weedySeaDragon/shf-project/teams","hooks_url":"https://api.github.com/repos/weedySeaDragon/shf-project/hooks","issue_events_url":"https://api.github.com/repos/weedySeaDragon/shf-project/issues/events{/number}","events_url":"https://api.github.com/repos/weedySeaDragon/shf-project/events","assignees_url":"https://api.github.com/repos/weedySeaDragon/shf-project/assignees{/user}","branches_url":"https://api.github.com/repos/weedySeaDragon/shf-project/branches{/branch}","tags_url":"https://api.github.com/repos/weedySeaDragon/shf-project/tags","blobs_url":"https://api.github.com/repos/weedySeaDragon/shf-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weedySeaDragon/shf-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weedySeaDragon/shf-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/weedySeaDragon/shf-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weedySeaDragon/shf-project/statuses/{sha}","languages_url":"https://api.github.com/repos/weedySeaDragon/shf-project/languages","stargazers_url":"https://api.github.com/repos/weedySeaDragon/shf-project/stargazers","contributors_url":"https://api.github.com/repos/weedySeaDragon/shf-project/contributors","subscribers_url":"https://api.github.com/repos/weedySeaDragon/shf-project/subscribers","subscription_url":"https://api.github.com/repos/weedySeaDragon/shf-project/subscription","commits_url":"https://api.github.com/repos/weedySeaDragon/shf-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/weedySeaDragon/shf-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/weedySeaDragon/shf-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/weedySeaDragon/shf-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/weedySeaDragon/shf-project/contents/{+path}","compare_url":"https://api.github.com/repos/weedySeaDragon/shf-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weedySeaDragon/shf-project/merges","archive_url":"https://api.github.com/repos/weedySeaDragon/shf-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weedySeaDragon/shf-project/downloads","issues_url":"https://api.github.com/repos/weedySeaDragon/shf-project/issues{/number}","pulls_url":"https://api.github.com/repos/weedySeaDragon/shf-project/pulls{/number}","milestones_url":"https://api.github.com/repos/weedySeaDragon/shf-project/milestones{/number}","notifications_url":"https://api.github.com/repos/weedySeaDragon/shf-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weedySeaDragon/shf-project/labels{/name}","releases_url":"https://api.github.com/repos/weedySeaDragon/shf-project/releases{/id}","deployments_url":"https://api.github.com/repos/weedySeaDragon/shf-project/deployments","created_at":"2016-10-27T19:44:01Z","updated_at":"2016-10-21T07:42:18Z","pushed_at":"2016-11-15T08:38:57Z","git_url":"git://github.com/weedySeaDragon/shf-project.git","ssh_url":"git@github.com:weedySeaDragon/shf-project.git","clone_url":"https://github.com/weedySeaDragon/shf-project.git","svn_url":"https://github.com/weedySeaDragon/shf-project","homepage":null,"size":923,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AgileVentures:develop","ref":"develop","sha":"b664af842e9ed66b6414357a42083ed2766610d2","user":{"login":"AgileVentures","id":5116968,"avatar_url":"https://avatars.githubusercontent.com/u/5116968?v=3","gravatar_id":"","url":"https://api.github.com/users/AgileVentures","html_url":"https://github.com/AgileVentures","followers_url":"https://api.github.com/users/AgileVentures/followers","following_url":"https://api.github.com/users/AgileVentures/following{/other_user}","gists_url":"https://api.github.com/users/AgileVentures/gists{/gist_id}","starred_url":"https://api.github.com/users/AgileVentures/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgileVentures/subscriptions","organizations_url":"https://api.github.com/users/AgileVentures/orgs","repos_url":"https://api.github.com/users/AgileVentures/repos","events_url":"https://api.github.com/users/AgileVentures/events{/privacy}","received_events_url":"https://api.github.com/users/AgileVentures/received_events","type":"Organization","site_admin":false},"repo":{"id":71157737,"name":"shf-project","full_name":"AgileVentures/shf-project","owner":{"login":"AgileVentures","id":5116968,"avatar_url":"https://avatars.githubusercontent.com/u/5116968?v=3","gravatar_id":"","url":"https://api.github.com/users/AgileVentures","html_url":"https://github.com/AgileVentures","followers_url":"https://api.github.com/users/AgileVentures/followers","following_url":"https://api.github.com/users/AgileVentures/following{/other_user}","gists_url":"https://api.github.com/users/AgileVentures/gists{/gist_id}","starred_url":"https://api.github.com/users/AgileVentures/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgileVentures/subscriptions","organizations_url":"https://api.github.com/users/AgileVentures/orgs","repos_url":"https://api.github.com/users/AgileVentures/repos","events_url":"https://api.github.com/users/AgileVentures/events{/privacy}","received_events_url":"https://api.github.com/users/AgileVentures/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AgileVentures/shf-project","description":null,"fork":true,"url":"https://api.github.com/repos/AgileVentures/shf-project","forks_url":"https://api.github.com/repos/AgileVentures/shf-project/forks","keys_url":"https://api.github.com/repos/AgileVentures/shf-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AgileVentures/shf-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AgileVentures/shf-project/teams","hooks_url":"https://api.github.com/repos/AgileVentures/shf-project/hooks","issue_events_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/events{/number}","events_url":"https://api.github.com/repos/AgileVentures/shf-project/events","assignees_url":"https://api.github.com/repos/AgileVentures/shf-project/assignees{/user}","branches_url":"https://api.github.com/repos/AgileVentures/shf-project/branches{/branch}","tags_url":"https://api.github.com/repos/AgileVentures/shf-project/tags","blobs_url":"https://api.github.com/repos/AgileVentures/shf-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AgileVentures/shf-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AgileVentures/shf-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/AgileVentures/shf-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AgileVentures/shf-project/statuses/{sha}","languages_url":"https://api.github.com/repos/AgileVentures/shf-project/languages","stargazers_url":"https://api.github.com/repos/AgileVentures/shf-project/stargazers","contributors_url":"https://api.github.com/repos/AgileVentures/shf-project/contributors","subscribers_url":"https://api.github.com/repos/AgileVentures/shf-project/subscribers","subscription_url":"https://api.github.com/repos/AgileVentures/shf-project/subscription","commits_url":"https://api.github.com/repos/AgileVentures/shf-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/AgileVentures/shf-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/AgileVentures/shf-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/AgileVentures/shf-project/contents/{+path}","compare_url":"https://api.github.com/repos/AgileVentures/shf-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AgileVentures/shf-project/merges","archive_url":"https://api.github.com/repos/AgileVentures/shf-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AgileVentures/shf-project/downloads","issues_url":"https://api.github.com/repos/AgileVentures/shf-project/issues{/number}","pulls_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls{/number}","milestones_url":"https://api.github.com/repos/AgileVentures/shf-project/milestones{/number}","notifications_url":"https://api.github.com/repos/AgileVentures/shf-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AgileVentures/shf-project/labels{/name}","releases_url":"https://api.github.com/repos/AgileVentures/shf-project/releases{/id}","deployments_url":"https://api.github.com/repos/AgileVentures/shf-project/deployments","created_at":"2016-10-17T16:18:10Z","updated_at":"2016-11-07T19:30:07Z","pushed_at":"2016-11-15T08:38:57Z","git_url":"git://github.com/AgileVentures/shf-project.git","ssh_url":"git@github.com:AgileVentures/shf-project.git","clone_url":"https://github.com/AgileVentures/shf-project.git","svn_url":"https://github.com/AgileVentures/shf-project","homepage":null,"size":1056,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/24"},"html":{"href":"https://github.com/AgileVentures/shf-project/pull/24"},"issue":{"href":"https://api.github.com/repos/AgileVentures/shf-project/issues/24"},"comments":{"href":"https://api.github.com/repos/AgileVentures/shf-project/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/AgileVentures/shf-project/statuses/667f96c678889719ad6bf2fd91c93fe6f6432bb7"}}}}
{"actor":{"display_login":"weedySeaDragon"}}