{"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly/pulls/comments/85366250","pull_request_review_id":6087391,"id":85366250,"diff_hunk":"@@ -92,398 +41,4 @@ protected void populateModel(ModelNode operation, ModelNode model) throws Operat\n         }\n     }\n \n-    @Override\n-    protected void performRuntime(OperationContext context, ModelNode operation, ModelNode model) throws OperationFailedException {\n-        PathAddress address = PathAddress.pathAddress(operation.get(OP_ADDR));\n-        final String federationName = address.getLastElement().getValue();\n-        ModelNode partitionManager = Resource.Tools.readModel(context.readResource(EMPTY_ADDRESS));\n-        createPartitionManagerService(context, federationName, partitionManager, false);\n-    }\n-\n-    public void validateModel(final OperationContext context, String partitionManagerName, final ModelNode partitionManager) throws OperationFailedException {\n-        createPartitionManagerService(context, partitionManagerName, partitionManager, true);\n-    }\n-\n-    public void createPartitionManagerService(final OperationContext context, String partitionManagerName, final ModelNode partitionManager, boolean onlyValidate) throws OperationFailedException {\n-        String jndiName = PartitionManagerResourceDefinition.IDENTITY_MANAGEMENT_JNDI_URL\n-            .resolveModelAttribute(context, partitionManager).asString();\n-        IdentityConfigurationBuilder builder = new IdentityConfigurationBuilder();\n-        PartitionManagerService partitionManagerService = new PartitionManagerService(partitionManagerName, jndiName, builder);\n-        ServiceBuilder<PartitionManager> serviceBuilder = null;\n-\n-        if (!onlyValidate) {\n-            serviceBuilder = context.getServiceTarget()\n-                .addService(PartitionManagerService.createServiceName(partitionManagerName), partitionManagerService);\n-        }\n-\n-        ModelNode identityConfigurationNode = partitionManager.get(IDENTITY_CONFIGURATION.getName());\n-\n-        if (!identityConfigurationNode.isDefined()) {\n-            throw ROOT_LOGGER.idmNoIdentityConfigurationProvided();\n-        }\n-\n-        for (Property identityConfiguration : identityConfigurationNode.asPropertyList()) {\n-            String configurationName = identityConfiguration.getName();\n-            NamedIdentityConfigurationBuilder namedIdentityConfigurationBuilder = builder.named(configurationName);\n-\n-            if (!identityConfiguration.getValue().isDefined()) {\n-                throw ROOT_LOGGER.idmNoIdentityStoreProvided(configurationName);\n-            }\n-\n-            List<ModelNode> identityStores = identityConfiguration.getValue().asList();\n-\n-            for (ModelNode store : identityStores) {\n-                configureIdentityStore(context, serviceBuilder, partitionManagerService, configurationName, namedIdentityConfigurationBuilder, store);\n-            }\n-        }","path":"picketlink/src/main/java/org/wildfly/extension/picketlink/idm/model/PartitionManagerAddHandler.java","position":108,"original_position":108,"commit_id":"d13f6c4ce18bb391066394c91487406ce3a35bf6","original_commit_id":"d13f6c4ce18bb391066394c91487406ce3a35bf6","user":{"login":"ctomc","id":824084,"avatar_url":"https://avatars.githubusercontent.com/u/824084?v=3","gravatar_id":"","url":"https://api.github.com/users/ctomc","html_url":"https://github.com/ctomc","followers_url":"https://api.github.com/users/ctomc/followers","following_url":"https://api.github.com/users/ctomc/following{/other_user}","gists_url":"https://api.github.com/users/ctomc/gists{/gist_id}","starred_url":"https://api.github.com/users/ctomc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctomc/subscriptions","organizations_url":"https://api.github.com/users/ctomc/orgs","repos_url":"https://api.github.com/users/ctomc/repos","events_url":"https://api.github.com/users/ctomc/events{/privacy}","received_events_url":"https://api.github.com/users/ctomc/received_events","type":"User","site_admin":false},"body":"No, this is part of createPartitionManagerService() method, which does also some minor validation but 99% of time is used in RUNTIME stage.\r\nI've extracted the model validation part in method named validatePartitionManager() that is now used for model validation when needed.","created_at":"2016-10-27T15:44:33Z","updated_at":"2016-10-27T15:44:33Z","html_url":"https://github.com/wildfly/wildfly/pull/9286#discussion_r85366250","pull_request_url":"https://api.github.com/repos/wildfly/wildfly/pulls/9286","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/comments/85366250"},"html":{"href":"https://github.com/wildfly/wildfly/pull/9286#discussion_r85366250"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/9286"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly/pulls/9286","id":90410914,"html_url":"https://github.com/wildfly/wildfly/pull/9286","diff_url":"https://github.com/wildfly/wildfly/pull/9286.diff","patch_url":"https://github.com/wildfly/wildfly/pull/9286.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly/issues/9286","number":9286,"state":"open","locked":false,"title":"WFLY-7366 Remove PicketLink","user":{"login":"ctomc","id":824084,"avatar_url":"https://avatars.githubusercontent.com/u/824084?v=3","gravatar_id":"","url":"https://api.github.com/users/ctomc","html_url":"https://github.com/ctomc","followers_url":"https://api.github.com/users/ctomc/followers","following_url":"https://api.github.com/users/ctomc/following{/other_user}","gists_url":"https://api.github.com/users/ctomc/gists{/gist_id}","starred_url":"https://api.github.com/users/ctomc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctomc/subscriptions","organizations_url":"https://api.github.com/users/ctomc/orgs","repos_url":"https://api.github.com/users/ctomc/repos","events_url":"https://api.github.com/users/ctomc/events{/privacy}","received_events_url":"https://api.github.com/users/ctomc/received_events","type":"User","site_admin":false},"body":"only thing that stays are management stubs so we can still manage legacy HC from latest DC","created_at":"2016-10-21T16:08:04Z","updated_at":"2016-10-27T15:44:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d1bd01960db4d126a3bc06d4f8c435f067b8015","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly/pulls/9286/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly/pulls/9286/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly/wildfly/issues/9286/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly/statuses/d13f6c4ce18bb391066394c91487406ce3a35bf6","head":{"label":"ctomc:picketlink-remove","ref":"picketlink-remove","sha":"d13f6c4ce18bb391066394c91487406ce3a35bf6","user":{"login":"ctomc","id":824084,"avatar_url":"https://avatars.githubusercontent.com/u/824084?v=3","gravatar_id":"","url":"https://api.github.com/users/ctomc","html_url":"https://github.com/ctomc","followers_url":"https://api.github.com/users/ctomc/followers","following_url":"https://api.github.com/users/ctomc/following{/other_user}","gists_url":"https://api.github.com/users/ctomc/gists{/gist_id}","starred_url":"https://api.github.com/users/ctomc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctomc/subscriptions","organizations_url":"https://api.github.com/users/ctomc/orgs","repos_url":"https://api.github.com/users/ctomc/repos","events_url":"https://api.github.com/users/ctomc/events{/privacy}","received_events_url":"https://api.github.com/users/ctomc/received_events","type":"User","site_admin":false},"repo":{"id":1834378,"name":"wildfly","full_name":"ctomc/wildfly","owner":{"login":"ctomc","id":824084,"avatar_url":"https://avatars.githubusercontent.com/u/824084?v=3","gravatar_id":"","url":"https://api.github.com/users/ctomc","html_url":"https://github.com/ctomc","followers_url":"https://api.github.com/users/ctomc/followers","following_url":"https://api.github.com/users/ctomc/following{/other_user}","gists_url":"https://api.github.com/users/ctomc/gists{/gist_id}","starred_url":"https://api.github.com/users/ctomc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctomc/subscriptions","organizations_url":"https://api.github.com/users/ctomc/orgs","repos_url":"https://api.github.com/users/ctomc/repos","events_url":"https://api.github.com/users/ctomc/events{/privacy}","received_events_url":"https://api.github.com/users/ctomc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ctomc/wildfly","description":"WildFly application server","fork":true,"url":"https://api.github.com/repos/ctomc/wildfly","forks_url":"https://api.github.com/repos/ctomc/wildfly/forks","keys_url":"https://api.github.com/repos/ctomc/wildfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ctomc/wildfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ctomc/wildfly/teams","hooks_url":"https://api.github.com/repos/ctomc/wildfly/hooks","issue_events_url":"https://api.github.com/repos/ctomc/wildfly/issues/events{/number}","events_url":"https://api.github.com/repos/ctomc/wildfly/events","assignees_url":"https://api.github.com/repos/ctomc/wildfly/assignees{/user}","branches_url":"https://api.github.com/repos/ctomc/wildfly/branches{/branch}","tags_url":"https://api.github.com/repos/ctomc/wildfly/tags","blobs_url":"https://api.github.com/repos/ctomc/wildfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ctomc/wildfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ctomc/wildfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/ctomc/wildfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ctomc/wildfly/statuses/{sha}","languages_url":"https://api.github.com/repos/ctomc/wildfly/languages","stargazers_url":"https://api.github.com/repos/ctomc/wildfly/stargazers","contributors_url":"https://api.github.com/repos/ctomc/wildfly/contributors","subscribers_url":"https://api.github.com/repos/ctomc/wildfly/subscribers","subscription_url":"https://api.github.com/repos/ctomc/wildfly/subscription","commits_url":"https://api.github.com/repos/ctomc/wildfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/ctomc/wildfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/ctomc/wildfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/ctomc/wildfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/ctomc/wildfly/contents/{+path}","compare_url":"https://api.github.com/repos/ctomc/wildfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ctomc/wildfly/merges","archive_url":"https://api.github.com/repos/ctomc/wildfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ctomc/wildfly/downloads","issues_url":"https://api.github.com/repos/ctomc/wildfly/issues{/number}","pulls_url":"https://api.github.com/repos/ctomc/wildfly/pulls{/number}","milestones_url":"https://api.github.com/repos/ctomc/wildfly/milestones{/number}","notifications_url":"https://api.github.com/repos/ctomc/wildfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ctomc/wildfly/labels{/name}","releases_url":"https://api.github.com/repos/ctomc/wildfly/releases{/id}","deployments_url":"https://api.github.com/repos/ctomc/wildfly/deployments","created_at":"2011-06-01T22:00:14Z","updated_at":"2016-08-22T14:44:55Z","pushed_at":"2016-10-26T12:07:22Z","git_url":"git://github.com/ctomc/wildfly.git","ssh_url":"git@github.com:ctomc/wildfly.git","clone_url":"https://github.com/ctomc/wildfly.git","svn_url":"https://github.com/ctomc/wildfly","homepage":"www.wildfly.org","size":172969,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"195e9d98836a2535aefb661a967e04de45d5ad3c","user":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":764708,"name":"wildfly","full_name":"wildfly/wildfly","owner":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars.githubusercontent.com/u/3066274?v=3","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly","description":"WildFly Application Server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly","forks_url":"https://api.github.com/repos/wildfly/wildfly/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly/wildfly/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly/wildfly/deployments","created_at":"2010-07-08T20:46:07Z","updated_at":"2016-10-26T07:22:21Z","pushed_at":"2016-10-27T15:06:53Z","git_url":"git://github.com/wildfly/wildfly.git","ssh_url":"git@github.com:wildfly/wildfly.git","clone_url":"https://github.com/wildfly/wildfly.git","svn_url":"https://github.com/wildfly/wildfly","homepage":"http://wildfly.org","size":253325,"stargazers_count":1707,"watchers_count":1707,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1641,"mirror_url":null,"open_issues_count":80,"forks":1641,"open_issues":80,"watchers":1707,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/9286"},"html":{"href":"https://github.com/wildfly/wildfly/pull/9286"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly/issues/9286"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly/issues/9286/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/9286/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/9286/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly/statuses/d13f6c4ce18bb391066394c91487406ce3a35bf6"}}}}
{"actor":{"display_login":"ctomc"}}