{"action":"created","comment":{"url":"https://api.github.com/repos/humanmade/S3-Uploads/pulls/comments/74027915","id":74027915,"diff_hunk":"@@ -208,12 +209,42 @@ public function filter_editors( $editors ) {\n \t */\n \tpublic function filter_sideload_move_temp_file_to_s3( array $file ) {\n \t\t$upload_dir = wp_upload_dir();\n-\t\t$new_path = $upload_dir['basedir'] . '/tmp/' . basename( $file['tmp_name'] );\n+\t\t$new_path   = $upload_dir['basedir'] . '/tmp/' . basename( $file['tmp_name'] );\n \n \t\tcopy( $file['tmp_name'], $new_path );\n \t\tunlink( $file['tmp_name'] );\n \t\t$file['tmp_name'] = $new_path;\n \n \t\treturn $file;\n \t}\n+\n+\t/**\n+\t * Filters wp_read_image_metadata. exif_read_data() doesn't work on\n+\t * file streams so we need to make a temporary local copy to extract\n+\t * exif data from.\n+\t *\n+\t * @param array  $meta\n+\t * @param string $file\n+\t * @return array|bool\n+\t */\n+\tpublic function wp_filter_read_image_metadata( $meta, $file ) {\n+\t\tremove_filter( 'wp_read_image_metadata', array( $this, 'wp_filter_read_image_metadata' ), 10, 2 );\n+\t\t$temp_file = $this->copy_image_from_s3( $file );","path":"inc/class-s3-uploads.php","position":103,"original_position":103,"commit_id":"5b67eeb2dcaa9731f27fa99187fc4e16b716bb2d","original_commit_id":"5b67eeb2dcaa9731f27fa99187fc4e16b716bb2d","user":{"login":"joehoyle","id":161683,"avatar_url":"https://avatars.githubusercontent.com/u/161683?v=3","gravatar_id":"","url":"https://api.github.com/users/joehoyle","html_url":"https://github.com/joehoyle","followers_url":"https://api.github.com/users/joehoyle/followers","following_url":"https://api.github.com/users/joehoyle/following{/other_user}","gists_url":"https://api.github.com/users/joehoyle/gists{/gist_id}","starred_url":"https://api.github.com/users/joehoyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joehoyle/subscriptions","organizations_url":"https://api.github.com/users/joehoyle/orgs","repos_url":"https://api.github.com/users/joehoyle/repos","events_url":"https://api.github.com/users/joehoyle/events{/privacy}","received_events_url":"https://api.github.com/users/joehoyle/received_events","type":"User","site_admin":false},"body":"You seem to be missing the `callback` param, also see other warnings in https://travis-ci.org/humanmade/S3-Uploads/jobs/150781407","created_at":"2016-08-09T09:41:28Z","updated_at":"2016-08-09T09:41:28Z","html_url":"https://github.com/humanmade/S3-Uploads/pull/116#discussion_r74027915","pull_request_url":"https://api.github.com/repos/humanmade/S3-Uploads/pulls/116","_links":{"self":{"href":"https://api.github.com/repos/humanmade/S3-Uploads/pulls/comments/74027915"},"html":{"href":"https://github.com/humanmade/S3-Uploads/pull/116#discussion_r74027915"},"pull_request":{"href":"https://api.github.com/repos/humanmade/S3-Uploads/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/humanmade/S3-Uploads/pulls/116","id":80489505,"html_url":"https://github.com/humanmade/S3-Uploads/pull/116","diff_url":"https://github.com/humanmade/S3-Uploads/pull/116.diff","patch_url":"https://github.com/humanmade/S3-Uploads/pull/116.patch","issue_url":"https://api.github.com/repos/humanmade/S3-Uploads/issues/116","number":116,"state":"open","locked":false,"title":"Handle wp_read_image_metadata","user":{"login":"roborourke","id":23417,"avatar_url":"https://avatars.githubusercontent.com/u/23417?v=3","gravatar_id":"","url":"https://api.github.com/users/roborourke","html_url":"https://github.com/roborourke","followers_url":"https://api.github.com/users/roborourke/followers","following_url":"https://api.github.com/users/roborourke/following{/other_user}","gists_url":"https://api.github.com/users/roborourke/gists{/gist_id}","starred_url":"https://api.github.com/users/roborourke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roborourke/subscriptions","organizations_url":"https://api.github.com/users/roborourke/orgs","repos_url":"https://api.github.com/users/roborourke/repos","events_url":"https://api.github.com/users/roborourke/events{/privacy}","received_events_url":"https://api.github.com/users/roborourke/received_events","type":"User","site_admin":false},"body":"Fixes #115\n\nCould do with someone else running the tests first just to confirm for me. With and without the filter in `class-s3-uploads.php`.","created_at":"2016-08-08T17:26:32Z","updated_at":"2016-08-09T09:41:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45b747b5a8c4d8a5f17961d9c627f6dba037bb14","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/humanmade/S3-Uploads/pulls/116/commits","review_comments_url":"https://api.github.com/repos/humanmade/S3-Uploads/pulls/116/comments","review_comment_url":"https://api.github.com/repos/humanmade/S3-Uploads/pulls/comments{/number}","comments_url":"https://api.github.com/repos/humanmade/S3-Uploads/issues/116/comments","statuses_url":"https://api.github.com/repos/humanmade/S3-Uploads/statuses/5b67eeb2dcaa9731f27fa99187fc4e16b716bb2d","head":{"label":"humanmade:exif-data","ref":"exif-data","sha":"5b67eeb2dcaa9731f27fa99187fc4e16b716bb2d","user":{"login":"humanmade","id":644666,"avatar_url":"https://avatars.githubusercontent.com/u/644666?v=3","gravatar_id":"","url":"https://api.github.com/users/humanmade","html_url":"https://github.com/humanmade","followers_url":"https://api.github.com/users/humanmade/followers","following_url":"https://api.github.com/users/humanmade/following{/other_user}","gists_url":"https://api.github.com/users/humanmade/gists{/gist_id}","starred_url":"https://api.github.com/users/humanmade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humanmade/subscriptions","organizations_url":"https://api.github.com/users/humanmade/orgs","repos_url":"https://api.github.com/users/humanmade/repos","events_url":"https://api.github.com/users/humanmade/events{/privacy}","received_events_url":"https://api.github.com/users/humanmade/received_events","type":"Organization","site_admin":false},"repo":{"id":14574404,"name":"S3-Uploads","full_name":"humanmade/S3-Uploads","owner":{"login":"humanmade","id":644666,"avatar_url":"https://avatars.githubusercontent.com/u/644666?v=3","gravatar_id":"","url":"https://api.github.com/users/humanmade","html_url":"https://github.com/humanmade","followers_url":"https://api.github.com/users/humanmade/followers","following_url":"https://api.github.com/users/humanmade/following{/other_user}","gists_url":"https://api.github.com/users/humanmade/gists{/gist_id}","starred_url":"https://api.github.com/users/humanmade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humanmade/subscriptions","organizations_url":"https://api.github.com/users/humanmade/orgs","repos_url":"https://api.github.com/users/humanmade/repos","events_url":"https://api.github.com/users/humanmade/events{/privacy}","received_events_url":"https://api.github.com/users/humanmade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/humanmade/S3-Uploads","description":"The WordPress Plugin to Store Uploads on Amazon S3","fork":false,"url":"https://api.github.com/repos/humanmade/S3-Uploads","forks_url":"https://api.github.com/repos/humanmade/S3-Uploads/forks","keys_url":"https://api.github.com/repos/humanmade/S3-Uploads/keys{/key_id}","collaborators_url":"https://api.github.com/repos/humanmade/S3-Uploads/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/humanmade/S3-Uploads/teams","hooks_url":"https://api.github.com/repos/humanmade/S3-Uploads/hooks","issue_events_url":"https://api.github.com/repos/humanmade/S3-Uploads/issues/events{/number}","events_url":"https://api.github.com/repos/humanmade/S3-Uploads/events","assignees_url":"https://api.github.com/repos/humanmade/S3-Uploads/assignees{/user}","branches_url":"https://api.github.com/repos/humanmade/S3-Uploads/branches{/branch}","tags_url":"https://api.github.com/repos/humanmade/S3-Uploads/tags","blobs_url":"https://api.github.com/repos/humanmade/S3-Uploads/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/humanmade/S3-Uploads/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/humanmade/S3-Uploads/git/refs{/sha}","trees_url":"https://api.github.com/repos/humanmade/S3-Uploads/git/trees{/sha}","statuses_url":"https://api.github.com/repos/humanmade/S3-Uploads/statuses/{sha}","languages_url":"https://api.github.com/repos/humanmade/S3-Uploads/languages","stargazers_url":"https://api.github.com/repos/humanmade/S3-Uploads/stargazers","contributors_url":"https://api.github.com/repos/humanmade/S3-Uploads/contributors","subscribers_url":"https://api.github.com/repos/humanmade/S3-Uploads/subscribers","subscription_url":"https://api.github.com/repos/humanmade/S3-Uploads/subscription","commits_url":"https://api.github.com/repos/humanmade/S3-Uploads/commits{/sha}","git_commits_url":"https://api.github.com/repos/humanmade/S3-Uploads/git/commits{/sha}","comments_url":"https://api.github.com/repos/humanmade/S3-Uploads/comments{/number}","issue_comment_url":"https://api.github.com/repos/humanmade/S3-Uploads/issues/comments{/number}","contents_url":"https://api.github.com/repos/humanmade/S3-Uploads/contents/{+path}","compare_url":"https://api.github.com/repos/humanmade/S3-Uploads/compare/{base}...{head}","merges_url":"https://api.github.com/repos/humanmade/S3-Uploads/merges","archive_url":"https://api.github.com/repos/humanmade/S3-Uploads/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/humanmade/S3-Uploads/downloads","issues_url":"https://api.github.com/repos/humanmade/S3-Uploads/issues{/number}","pulls_url":"https://api.github.com/repos/humanmade/S3-Uploads/pulls{/number}","milestones_url":"https://api.github.com/repos/humanmade/S3-Uploads/milestones{/number}","notifications_url":"https://api.github.com/repos/humanmade/S3-Uploads/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/humanmade/S3-Uploads/labels{/name}","releases_url":"https://api.github.com/repos/humanmade/S3-Uploads/releases{/id}","deployments_url":"https://api.github.com/repos/humanmade/S3-Uploads/deployments","created_at":"2013-11-21T01:26:22Z","updated_at":"2016-08-08T17:53:37Z","pushed_at":"2016-08-08T22:44:47Z","git_url":"git://github.com/humanmade/S3-Uploads.git","ssh_url":"git@github.com:humanmade/S3-Uploads.git","clone_url":"https://github.com/humanmade/S3-Uploads.git","svn_url":"https://github.com/humanmade/S3-Uploads","homepage":"","size":4775,"stargazers_count":261,"watchers_count":261,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":43,"forks":46,"open_issues":43,"watchers":261,"default_branch":"master"}},"base":{"label":"humanmade:master","ref":"master","sha":"5badbcfb9341928060f586d35d8949c2c0e95ebb","user":{"login":"humanmade","id":644666,"avatar_url":"https://avatars.githubusercontent.com/u/644666?v=3","gravatar_id":"","url":"https://api.github.com/users/humanmade","html_url":"https://github.com/humanmade","followers_url":"https://api.github.com/users/humanmade/followers","following_url":"https://api.github.com/users/humanmade/following{/other_user}","gists_url":"https://api.github.com/users/humanmade/gists{/gist_id}","starred_url":"https://api.github.com/users/humanmade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humanmade/subscriptions","organizations_url":"https://api.github.com/users/humanmade/orgs","repos_url":"https://api.github.com/users/humanmade/repos","events_url":"https://api.github.com/users/humanmade/events{/privacy}","received_events_url":"https://api.github.com/users/humanmade/received_events","type":"Organization","site_admin":false},"repo":{"id":14574404,"name":"S3-Uploads","full_name":"humanmade/S3-Uploads","owner":{"login":"humanmade","id":644666,"avatar_url":"https://avatars.githubusercontent.com/u/644666?v=3","gravatar_id":"","url":"https://api.github.com/users/humanmade","html_url":"https://github.com/humanmade","followers_url":"https://api.github.com/users/humanmade/followers","following_url":"https://api.github.com/users/humanmade/following{/other_user}","gists_url":"https://api.github.com/users/humanmade/gists{/gist_id}","starred_url":"https://api.github.com/users/humanmade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humanmade/subscriptions","organizations_url":"https://api.github.com/users/humanmade/orgs","repos_url":"https://api.github.com/users/humanmade/repos","events_url":"https://api.github.com/users/humanmade/events{/privacy}","received_events_url":"https://api.github.com/users/humanmade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/humanmade/S3-Uploads","description":"The WordPress Plugin to Store Uploads on Amazon S3","fork":false,"url":"https://api.github.com/repos/humanmade/S3-Uploads","forks_url":"https://api.github.com/repos/humanmade/S3-Uploads/forks","keys_url":"https://api.github.com/repos/humanmade/S3-Uploads/keys{/key_id}","collaborators_url":"https://api.github.com/repos/humanmade/S3-Uploads/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/humanmade/S3-Uploads/teams","hooks_url":"https://api.github.com/repos/humanmade/S3-Uploads/hooks","issue_events_url":"https://api.github.com/repos/humanmade/S3-Uploads/issues/events{/number}","events_url":"https://api.github.com/repos/humanmade/S3-Uploads/events","assignees_url":"https://api.github.com/repos/humanmade/S3-Uploads/assignees{/user}","branches_url":"https://api.github.com/repos/humanmade/S3-Uploads/branches{/branch}","tags_url":"https://api.github.com/repos/humanmade/S3-Uploads/tags","blobs_url":"https://api.github.com/repos/humanmade/S3-Uploads/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/humanmade/S3-Uploads/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/humanmade/S3-Uploads/git/refs{/sha}","trees_url":"https://api.github.com/repos/humanmade/S3-Uploads/git/trees{/sha}","statuses_url":"https://api.github.com/repos/humanmade/S3-Uploads/statuses/{sha}","languages_url":"https://api.github.com/repos/humanmade/S3-Uploads/languages","stargazers_url":"https://api.github.com/repos/humanmade/S3-Uploads/stargazers","contributors_url":"https://api.github.com/repos/humanmade/S3-Uploads/contributors","subscribers_url":"https://api.github.com/repos/humanmade/S3-Uploads/subscribers","subscription_url":"https://api.github.com/repos/humanmade/S3-Uploads/subscription","commits_url":"https://api.github.com/repos/humanmade/S3-Uploads/commits{/sha}","git_commits_url":"https://api.github.com/repos/humanmade/S3-Uploads/git/commits{/sha}","comments_url":"https://api.github.com/repos/humanmade/S3-Uploads/comments{/number}","issue_comment_url":"https://api.github.com/repos/humanmade/S3-Uploads/issues/comments{/number}","contents_url":"https://api.github.com/repos/humanmade/S3-Uploads/contents/{+path}","compare_url":"https://api.github.com/repos/humanmade/S3-Uploads/compare/{base}...{head}","merges_url":"https://api.github.com/repos/humanmade/S3-Uploads/merges","archive_url":"https://api.github.com/repos/humanmade/S3-Uploads/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/humanmade/S3-Uploads/downloads","issues_url":"https://api.github.com/repos/humanmade/S3-Uploads/issues{/number}","pulls_url":"https://api.github.com/repos/humanmade/S3-Uploads/pulls{/number}","milestones_url":"https://api.github.com/repos/humanmade/S3-Uploads/milestones{/number}","notifications_url":"https://api.github.com/repos/humanmade/S3-Uploads/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/humanmade/S3-Uploads/labels{/name}","releases_url":"https://api.github.com/repos/humanmade/S3-Uploads/releases{/id}","deployments_url":"https://api.github.com/repos/humanmade/S3-Uploads/deployments","created_at":"2013-11-21T01:26:22Z","updated_at":"2016-08-08T17:53:37Z","pushed_at":"2016-08-08T22:44:47Z","git_url":"git://github.com/humanmade/S3-Uploads.git","ssh_url":"git@github.com:humanmade/S3-Uploads.git","clone_url":"https://github.com/humanmade/S3-Uploads.git","svn_url":"https://github.com/humanmade/S3-Uploads","homepage":"","size":4775,"stargazers_count":261,"watchers_count":261,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":43,"forks":46,"open_issues":43,"watchers":261,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/humanmade/S3-Uploads/pulls/116"},"html":{"href":"https://github.com/humanmade/S3-Uploads/pull/116"},"issue":{"href":"https://api.github.com/repos/humanmade/S3-Uploads/issues/116"},"comments":{"href":"https://api.github.com/repos/humanmade/S3-Uploads/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/humanmade/S3-Uploads/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/humanmade/S3-Uploads/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/humanmade/S3-Uploads/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/humanmade/S3-Uploads/statuses/5b67eeb2dcaa9731f27fa99187fc4e16b716bb2d"}}}}
{"actor":{"display_login":"joehoyle"}}