{"action":"created","issue":{"url":"https://api.github.com/repos/ARMmbed/oob-mbed-os-example-tls/issues/18","repository_url":"https://api.github.com/repos/ARMmbed/oob-mbed-os-example-tls","labels_url":"https://api.github.com/repos/ARMmbed/oob-mbed-os-example-tls/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/ARMmbed/oob-mbed-os-example-tls/issues/18/comments","events_url":"https://api.github.com/repos/ARMmbed/oob-mbed-os-example-tls/issues/18/events","html_url":"https://github.com/ARMmbed/oob-mbed-os-example-tls/pull/18","id":183583668,"number":18,"title":"Adjust size-speed trade-offs to save stack space","user":{"login":"c1728p9","id":2916772,"avatar_url":"https://avatars.githubusercontent.com/u/2916772?v=3","gravatar_id":"","url":"https://api.github.com/users/c1728p9","html_url":"https://github.com/c1728p9","followers_url":"https://api.github.com/users/c1728p9/followers","following_url":"https://api.github.com/users/c1728p9/following{/other_user}","gists_url":"https://api.github.com/users/c1728p9/gists{/gist_id}","starred_url":"https://api.github.com/users/c1728p9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c1728p9/subscriptions","organizations_url":"https://api.github.com/users/c1728p9/orgs","repos_url":"https://api.github.com/users/c1728p9/repos","events_url":"https://api.github.com/users/c1728p9/events{/privacy}","received_events_url":"https://api.github.com/users/c1728p9/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-10-18T03:46:57Z","updated_at":"2016-10-20T14:16:55Z","closed_at":"2016-10-18T11:44:15Z","pull_request":{"url":"https://api.github.com/repos/ARMmbed/oob-mbed-os-example-tls/pulls/18","html_url":"https://github.com/ARMmbed/oob-mbed-os-example-tls/pull/18","diff_url":"https://github.com/ARMmbed/oob-mbed-os-example-tls/pull/18.diff","patch_url":"https://github.com/ARMmbed/oob-mbed-os-example-tls/pull/18.patch"},"body":"Both the values MBEDTLS_MPI_MAX_SIZE and MBEDTLS_MPI_WINDOW_SIZE\r\ndeclare buffers on the stack. The default values of\r\nMBEDTLS_MPI_MAX_SIZE=1024 and MBEDTLS_MPI_WINDOW_SIZE=6 cause the\r\ntls-client example to just barely overflow the 4K main stack in some\r\nconfigurations. This patch sets both of those defines to smaller\r\nvalues to decrease stack size.\r\n\r\nWhen building ARMCC with the default profile this reduces stack usage\r\nof the tls-client example from ~4184 to ~2372 bytes."},"comment":{"url":"https://api.github.com/repos/ARMmbed/oob-mbed-os-example-tls/issues/comments/255118659","html_url":"https://github.com/ARMmbed/oob-mbed-os-example-tls/pull/18#issuecomment-255118659","issue_url":"https://api.github.com/repos/ARMmbed/oob-mbed-os-example-tls/issues/18","id":255118659,"user":{"login":"c1728p9","id":2916772,"avatar_url":"https://avatars.githubusercontent.com/u/2916772?v=3","gravatar_id":"","url":"https://api.github.com/users/c1728p9","html_url":"https://github.com/c1728p9","followers_url":"https://api.github.com/users/c1728p9/followers","following_url":"https://api.github.com/users/c1728p9/following{/other_user}","gists_url":"https://api.github.com/users/c1728p9/gists{/gist_id}","starred_url":"https://api.github.com/users/c1728p9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c1728p9/subscriptions","organizations_url":"https://api.github.com/users/c1728p9/orgs","repos_url":"https://api.github.com/users/c1728p9/repos","events_url":"https://api.github.com/users/c1728p9/events{/privacy}","received_events_url":"https://api.github.com/users/c1728p9/received_events","type":"User","site_admin":false},"created_at":"2016-10-20T14:16:55Z","updated_at":"2016-10-20T14:16:55Z","body":"@sbutcher-arm is changing MBEDTLS_MPI_MAX_SIZE to 256 in this PR acceptable? This buffer declared by MBEDTLS_MPI_MAX_SIZE is on the stack, and if this change is reverted then stack overflows will start occurring again."}}
{"actor":{"display_login":"c1728p9"}}