{"action":"created","issue":{"url":"https://api.github.com/repos/dvidelabs/flatcc/issues/10","repository_url":"https://api.github.com/repos/dvidelabs/flatcc","labels_url":"https://api.github.com/repos/dvidelabs/flatcc/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/dvidelabs/flatcc/issues/10/comments","events_url":"https://api.github.com/repos/dvidelabs/flatcc/issues/10/events","html_url":"https://github.com/dvidelabs/flatcc/issues/10","id":181704079,"number":10,"title":"CFLAGS setup assumes gcc compatible flags","user":{"login":"csstup","id":8303565,"avatar_url":"https://avatars.githubusercontent.com/u/8303565?v=3","gravatar_id":"","url":"https://api.github.com/users/csstup","html_url":"https://github.com/csstup","followers_url":"https://api.github.com/users/csstup/followers","following_url":"https://api.github.com/users/csstup/following{/other_user}","gists_url":"https://api.github.com/users/csstup/gists{/gist_id}","starred_url":"https://api.github.com/users/csstup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csstup/subscriptions","organizations_url":"https://api.github.com/users/csstup/orgs","repos_url":"https://api.github.com/users/csstup/repos","events_url":"https://api.github.com/users/csstup/events{/privacy}","received_events_url":"https://api.github.com/users/csstup/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/dvidelabs/flatcc/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"csstup","id":8303565,"avatar_url":"https://avatars.githubusercontent.com/u/8303565?v=3","gravatar_id":"","url":"https://api.github.com/users/csstup","html_url":"https://github.com/csstup","followers_url":"https://api.github.com/users/csstup/followers","following_url":"https://api.github.com/users/csstup/following{/other_user}","gists_url":"https://api.github.com/users/csstup/gists{/gist_id}","starred_url":"https://api.github.com/users/csstup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csstup/subscriptions","organizations_url":"https://api.github.com/users/csstup/orgs","repos_url":"https://api.github.com/users/csstup/repos","events_url":"https://api.github.com/users/csstup/events{/privacy}","received_events_url":"https://api.github.com/users/csstup/received_events","type":"User","site_admin":false},"assignees":[{"login":"csstup","id":8303565,"avatar_url":"https://avatars.githubusercontent.com/u/8303565?v=3","gravatar_id":"","url":"https://api.github.com/users/csstup","html_url":"https://github.com/csstup","followers_url":"https://api.github.com/users/csstup/followers","following_url":"https://api.github.com/users/csstup/following{/other_user}","gists_url":"https://api.github.com/users/csstup/gists{/gist_id}","starred_url":"https://api.github.com/users/csstup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csstup/subscriptions","organizations_url":"https://api.github.com/users/csstup/orgs","repos_url":"https://api.github.com/users/csstup/repos","events_url":"https://api.github.com/users/csstup/events{/privacy}","received_events_url":"https://api.github.com/users/csstup/received_events","type":"User","site_admin":false}],"milestone":null,"comments":29,"created_at":"2016-10-07T15:49:20Z","updated_at":"2016-10-26T16:36:30Z","closed_at":null,"body":"In CMakelists.txt, the section that sets up the compiler flags for the final else case assumes you're using GCC.\r\n\r\n```\r\nif (CMAKE_C_COMPILER_ID MATCHES \"Clang\")\r\n(snipped)\r\nelseif (CMAKE_C_COMPILER_ID STREQUAL \"GNU\")\r\n(snipped)\r\nelse()\r\n    # Best effort\r\n    set(CMAKE_C_FLAGS \"${CMAKE_C_FLAGS}\" -Wall)\r\n    set(FLATCC_PORTABLE true)\r\nendif()\r\n```\r\n\r\nIn my case, I'm using the system compiler, not GCC.  I fall into the best effort case.   But -Wall is a GCC flag, not a common compiler option.   Shouldn't the \"best effort\" case be pretty generic?    I removed -Wall for my testing as it fails otherwise.\r\n"},"comment":{"url":"https://api.github.com/repos/dvidelabs/flatcc/issues/comments/256405823","html_url":"https://github.com/dvidelabs/flatcc/issues/10#issuecomment-256405823","issue_url":"https://api.github.com/repos/dvidelabs/flatcc/issues/10","id":256405823,"user":{"login":"mikkelfj","id":193335,"avatar_url":"https://avatars.githubusercontent.com/u/193335?v=3","gravatar_id":"","url":"https://api.github.com/users/mikkelfj","html_url":"https://github.com/mikkelfj","followers_url":"https://api.github.com/users/mikkelfj/followers","following_url":"https://api.github.com/users/mikkelfj/following{/other_user}","gists_url":"https://api.github.com/users/mikkelfj/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkelfj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkelfj/subscriptions","organizations_url":"https://api.github.com/users/mikkelfj/orgs","repos_url":"https://api.github.com/users/mikkelfj/repos","events_url":"https://api.github.com/users/mikkelfj/events{/privacy}","received_events_url":"https://api.github.com/users/mikkelfj/received_events","type":"User","site_admin":false},"created_at":"2016-10-26T16:36:30Z","updated_at":"2016-10-26T16:36:30Z","body":"Reflection should work by now.\r\nBE test would also be nice.\r\n\r\nGood point about schema, but since the file names are derived directly from the schema basename you already have the information. The the full parth shouldn't be there anyway. Included files are designed to be the same regardless of how they work included, or generated directly, so it makes no sense to place information there either."}}
{"actor":{"display_login":"mikkelfj"}}