{"action":"created","comment":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/83175600","pull_request_review_id":4033559,"id":83175600,"diff_hunk":"@@ -190,3 +192,62 @@\n \tV.update_icon()\r\n \r\n \tqdel(src)\r\n+\r\n+\r\n+\r\n+///////////////////////\r\n+//One Tank Bombs, WOOOOOOO! -Luke\r\n+///////////////////////\r\n+\r\n+\r\n+/obj/effect/spawner/onetankbomb\r\n+\tname = \"Single-tank bomb\"\r\n+\ticon = 'icons/mob/screen1.dmi'\r\n+\ticon_state = \"x\"\r\n+\r\n+\tvar/assembly_type = /obj/item/device/assembly/signaler\r\n+\r\n+\t//Note that the maximum amount of gas you can put in a 70L air tank at 1013.25 kPa and 519K is 16.44 mol.\r\n+\tvar/phoron_amt = 10\r\n+\tvar/oxygen_amt = 15\r\n+\r\n+/obj/effect/spawner/onetankbomb/New(newloc)\r\n+\t..(newloc)\r\n+\r\n+\tvar/type = pick(/obj/item/weapon/tank/phoron, /obj/item/weapon/tank/oxygen)\r\n+\tvar/obj/item/weapon/tank/K = new type(src.loc)\r\n+\r\n+\tK.air_contents.temperature = PHORON_MINIMUM_BURN_TEMPERATURE+1\r\n+\tK.air_contents.gas[\"phoron\"] = phoron_amt\r\n+\tK.air_contents.gas[\"oxygen\"] = oxygen_amt\r\n+\tK.valve_welded = 1\r\n+\r\n+\tK.wired = 1\r\n+\r\n+\r\n+\tvar/obj/item/device/assembly_holder/H = new(K)\r\n+\tK.proxyassembly.assembly = H\r\n+\tH.master = K.proxyassembly\r\n+\r\n+\tvar/obj/item/device/assembly/igniter/ign = new(H)\r\n+\tH.a_left = ign\r\n+\r\n+\tvar/obj/item/device/assembly/assm = new assembly_type(H)\r\n+\tH.a_right = assm\r\n+\r\n+\tvar/tog = assm.toggle_secure()\r\n+\tif(!tog)\r\n+\t\tassm.toggle_secure()\r\n+\r\n+\r\n+\tH.update_icon()\r\n+\r\n+\r\n+\tK.overlays += \"bomb_assembly\"\r\n+\tvar/icon/test = getFlatIcon(K.proxyassembly.assembly)\r\n+\ttest.Shift(SOUTH,1)\r\n+\ttest.Shift(WEST,4)\r\n+\tK.overlays += test\r","path":"code/game/objects/effects/spawners/bombspawner.dm","position":110,"original_position":110,"commit_id":"cc78d95b98009b41b9821af8fdc264bc40a7d839","original_commit_id":"cc78d95b98009b41b9821af8fdc264bc40a7d839","user":{"login":"PsiOmegaDelta","id":496895,"avatar_url":"https://avatars.githubusercontent.com/u/496895?v=3","gravatar_id":"","url":"https://api.github.com/users/PsiOmegaDelta","html_url":"https://github.com/PsiOmegaDelta","followers_url":"https://api.github.com/users/PsiOmegaDelta/followers","following_url":"https://api.github.com/users/PsiOmegaDelta/following{/other_user}","gists_url":"https://api.github.com/users/PsiOmegaDelta/gists{/gist_id}","starred_url":"https://api.github.com/users/PsiOmegaDelta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PsiOmegaDelta/subscriptions","organizations_url":"https://api.github.com/users/PsiOmegaDelta/orgs","repos_url":"https://api.github.com/users/PsiOmegaDelta/repos","events_url":"https://api.github.com/users/PsiOmegaDelta/events{/privacy}","received_events_url":"https://api.github.com/users/PsiOmegaDelta/received_events","type":"User","site_admin":false},"body":"Just keep in mind that getFlatIcon() is one  of the most process heavy procs we have, and while it is only one icon in this particular case this proc has been known to lag the server.","created_at":"2016-10-13T09:25:47Z","updated_at":"2016-10-13T09:25:48Z","html_url":"https://github.com/Baystation12/Baystation12/pull/14404#discussion_r83175600","pull_request_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/14404","_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/83175600"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/14404#discussion_r83175600"},"pull_request":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/14404"}}},"pull_request":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/14404","id":89160907,"html_url":"https://github.com/Baystation12/Baystation12/pull/14404","diff_url":"https://github.com/Baystation12/Baystation12/pull/14404.diff","patch_url":"https://github.com/Baystation12/Baystation12/pull/14404.patch","issue_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/14404","number":14404,"state":"open","locked":false,"title":"Single Tank and TTV tweaks","user":{"login":"LorenLuke","id":6456096,"avatar_url":"https://avatars.githubusercontent.com/u/6456096?v=3","gravatar_id":"","url":"https://api.github.com/users/LorenLuke","html_url":"https://github.com/LorenLuke","followers_url":"https://api.github.com/users/LorenLuke/followers","following_url":"https://api.github.com/users/LorenLuke/following{/other_user}","gists_url":"https://api.github.com/users/LorenLuke/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenLuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenLuke/subscriptions","organizations_url":"https://api.github.com/users/LorenLuke/orgs","repos_url":"https://api.github.com/users/LorenLuke/repos","events_url":"https://api.github.com/users/LorenLuke/events{/privacy}","received_events_url":"https://api.github.com/users/LorenLuke/received_events","type":"User","site_admin":false},"body":"<!-- \r\nDo not forget to add a changelog when you have made admin/player facing changes that can alter gameplay.\r\nExamples which require a changelog entry include:\r\n* Adding/removing objects that players may interact with, or the way they function.\r\n* Adding/removing/altering admin tools.\r\n* Changing the map.\r\n\r\nExamples were changelog entries are optional/not typically required:\r\n* Cosmetic changes such as descriptions, sound effects, etc.\r\n* Optimizations and other changes to underlying systems which do not affect gameplay.\r\n* Minor bug fixes.\r\n\r\nYou find a README and example file in .\\html\\changelogs\\ for further instructions.\r\n-->\r\nRefactoring of Single Tank Tweaks. See Pull #13488.\r\n\r\n1. Adds pressure relief valves, spilling their contents at 173C, or over 30ATM pressure.\r\n2. Pressure valves can be welded to force tanks to rupture at higher pressure.\r\n3. Rupturing tanks generate shrapnel.\r\n4. Exploding tanks generate shrapnel.\r\n5. Tweaks how explosions are calculated, generating roughly the same effect as prior.\r\n6. Explosions now calculated based on pressure and gas volume.\r\n7. Single tank bombs can now be made from e-tanks as well.\r\n8. Gets rid of arbitrary singletank code.\r\n9. Changes how singletank bombs are built (add wire, add assembly device)\r\n10. Changes how singletank bombs are defused (wirecutters)\r\n11. Changes how singletank bombs function with an igniter (igniter adds 9kJ to gas mix, single use to prevent spamming heat).\r\n12. Singletank bombs no longer are smaller than the actual tank.\r\n13. TTVs change size to match their tank size when tanks are attached.\r\n\r\nStill changing. New PR opened due to versioning issues and travis check hanging with PR #13488","created_at":"2016-10-13T08:58:04Z","updated_at":"2016-10-13T09:25:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2bf2e64dd9f3cb8ab5e9705595a59efaf7a3f625","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/14404/commits","review_comments_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/14404/comments","review_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/14404/comments","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/cc78d95b98009b41b9821af8fdc264bc40a7d839","head":{"label":"LorenLuke:Bomb-Tweaks","ref":"Bomb-Tweaks","sha":"cc78d95b98009b41b9821af8fdc264bc40a7d839","user":{"login":"LorenLuke","id":6456096,"avatar_url":"https://avatars.githubusercontent.com/u/6456096?v=3","gravatar_id":"","url":"https://api.github.com/users/LorenLuke","html_url":"https://github.com/LorenLuke","followers_url":"https://api.github.com/users/LorenLuke/followers","following_url":"https://api.github.com/users/LorenLuke/following{/other_user}","gists_url":"https://api.github.com/users/LorenLuke/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenLuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenLuke/subscriptions","organizations_url":"https://api.github.com/users/LorenLuke/orgs","repos_url":"https://api.github.com/users/LorenLuke/repos","events_url":"https://api.github.com/users/LorenLuke/events{/privacy}","received_events_url":"https://api.github.com/users/LorenLuke/received_events","type":"User","site_admin":false},"repo":{"id":26836894,"name":"Baystation12","full_name":"LorenLuke/Baystation12","owner":{"login":"LorenLuke","id":6456096,"avatar_url":"https://avatars.githubusercontent.com/u/6456096?v=3","gravatar_id":"","url":"https://api.github.com/users/LorenLuke","html_url":"https://github.com/LorenLuke","followers_url":"https://api.github.com/users/LorenLuke/followers","following_url":"https://api.github.com/users/LorenLuke/following{/other_user}","gists_url":"https://api.github.com/users/LorenLuke/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenLuke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenLuke/subscriptions","organizations_url":"https://api.github.com/users/LorenLuke/orgs","repos_url":"https://api.github.com/users/LorenLuke/repos","events_url":"https://api.github.com/users/LorenLuke/events{/privacy}","received_events_url":"https://api.github.com/users/LorenLuke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LorenLuke/Baystation12","description":"The code for Baystation12's branch of SS13","fork":true,"url":"https://api.github.com/repos/LorenLuke/Baystation12","forks_url":"https://api.github.com/repos/LorenLuke/Baystation12/forks","keys_url":"https://api.github.com/repos/LorenLuke/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LorenLuke/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LorenLuke/Baystation12/teams","hooks_url":"https://api.github.com/repos/LorenLuke/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/LorenLuke/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/LorenLuke/Baystation12/events","assignees_url":"https://api.github.com/repos/LorenLuke/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/LorenLuke/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/LorenLuke/Baystation12/tags","blobs_url":"https://api.github.com/repos/LorenLuke/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LorenLuke/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LorenLuke/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/LorenLuke/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LorenLuke/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/LorenLuke/Baystation12/languages","stargazers_url":"https://api.github.com/repos/LorenLuke/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/LorenLuke/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/LorenLuke/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/LorenLuke/Baystation12/subscription","commits_url":"https://api.github.com/repos/LorenLuke/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/LorenLuke/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/LorenLuke/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/LorenLuke/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/LorenLuke/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/LorenLuke/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LorenLuke/Baystation12/merges","archive_url":"https://api.github.com/repos/LorenLuke/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LorenLuke/Baystation12/downloads","issues_url":"https://api.github.com/repos/LorenLuke/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/LorenLuke/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/LorenLuke/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/LorenLuke/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LorenLuke/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/LorenLuke/Baystation12/releases{/id}","deployments_url":"https://api.github.com/repos/LorenLuke/Baystation12/deployments","created_at":"2014-11-19T00:30:53Z","updated_at":"2014-11-19T00:31:03Z","pushed_at":"2016-10-13T09:03:47Z","git_url":"git://github.com/LorenLuke/Baystation12.git","ssh_url":"git@github.com:LorenLuke/Baystation12.git","clone_url":"https://github.com/LorenLuke/Baystation12.git","svn_url":"https://github.com/LorenLuke/Baystation12","homepage":"http://baystation12.net/","size":609501,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Baystation12:dev","ref":"dev","sha":"7cc084eb18796263d90a0cae5c1a098c12e02c94","user":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"repo":{"id":2715933,"name":"Baystation12","full_name":"Baystation12/Baystation12","owner":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Baystation12/Baystation12","description":"The code for Baystation12's branch of SS13","fork":false,"url":"https://api.github.com/repos/Baystation12/Baystation12","forks_url":"https://api.github.com/repos/Baystation12/Baystation12/forks","keys_url":"https://api.github.com/repos/Baystation12/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Baystation12/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Baystation12/Baystation12/teams","hooks_url":"https://api.github.com/repos/Baystation12/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/Baystation12/Baystation12/events","assignees_url":"https://api.github.com/repos/Baystation12/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/Baystation12/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/Baystation12/Baystation12/tags","blobs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Baystation12/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Baystation12/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/Baystation12/Baystation12/languages","stargazers_url":"https://api.github.com/repos/Baystation12/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/Baystation12/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/Baystation12/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/Baystation12/Baystation12/subscription","commits_url":"https://api.github.com/repos/Baystation12/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Baystation12/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/Baystation12/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/Baystation12/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Baystation12/Baystation12/merges","archive_url":"https://api.github.com/repos/Baystation12/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Baystation12/Baystation12/downloads","issues_url":"https://api.github.com/repos/Baystation12/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/Baystation12/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/Baystation12/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Baystation12/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/Baystation12/Baystation12/releases{/id}","deployments_url":"https://api.github.com/repos/Baystation12/Baystation12/deployments","created_at":"2011-11-05T16:12:41Z","updated_at":"2016-10-12T06:23:45Z","pushed_at":"2016-10-13T09:03:52Z","git_url":"git://github.com/Baystation12/Baystation12.git","ssh_url":"git@github.com:Baystation12/Baystation12.git","clone_url":"https://github.com/Baystation12/Baystation12.git","svn_url":"https://github.com/Baystation12/Baystation12","homepage":"http://baystation12.net/","size":1699558,"stargazers_count":231,"watchers_count":231,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":751,"mirror_url":null,"open_issues_count":499,"forks":751,"open_issues":499,"watchers":231,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/14404"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/14404"},"issue":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/14404"},"comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/14404/comments"},"review_comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/14404/comments"},"review_comment":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/14404/commits"},"statuses":{"href":"https://api.github.com/repos/Baystation12/Baystation12/statuses/cc78d95b98009b41b9821af8fdc264bc40a7d839"}}}}
{"actor":{"display_login":"PsiOmegaDelta"}}