{"action":"closed","number":23,"pull_request":{"url":"https://api.github.com/repos/yireo/pkg_scriptmerge/pulls/23","id":92150788,"html_url":"https://github.com/yireo/pkg_scriptmerge/pull/23","diff_url":"https://github.com/yireo/pkg_scriptmerge/pull/23.diff","patch_url":"https://github.com/yireo/pkg_scriptmerge/pull/23.patch","issue_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/issues/23","number":23,"state":"closed","locked":false,"title":"Additional newline between concatenated files","user":{"login":"piotr-cz","id":612953,"avatar_url":"https://avatars.githubusercontent.com/u/612953?v=3","gravatar_id":"","url":"https://api.github.com/users/piotr-cz","html_url":"https://github.com/piotr-cz","followers_url":"https://api.github.com/users/piotr-cz/followers","following_url":"https://api.github.com/users/piotr-cz/following{/other_user}","gists_url":"https://api.github.com/users/piotr-cz/gists{/gist_id}","starred_url":"https://api.github.com/users/piotr-cz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotr-cz/subscriptions","organizations_url":"https://api.github.com/users/piotr-cz/orgs","repos_url":"https://api.github.com/users/piotr-cz/repos","events_url":"https://api.github.com/users/piotr-cz/events{/privacy}","received_events_url":"https://api.github.com/users/piotr-cz/received_events","type":"User","site_admin":false},"body":"In cases when last line of concatenated file is ending by comment (especially when using files with attached sourcemaps) concatenated file makes javascript interpreter fail:\r\n\r\n`Uncaught SyntaxError: Unexpected token *`\r\n\r\nFor example when _file1.js_ has such end:\r\n```js\r\n(function() {\r\n}(jQuery));\r\n\r\n//# sourceMappingURL=maps/scripts.js.map\r\n```\r\n\r\nAnd _file2.js_ has such beginning:\r\n\r\n```js\r\n/**\r\n *  Comment\r\n */\r\n```\r\n\r\nIt's being concatenated into\r\n```\r\n(function() {\r\n}(jQuery));\r\n\r\n//# sourceMappingURL=maps/scripts.js.map/**\r\n *  Comment (Error triggered on this line)\r\n */\r\n```\r\n\r\nSuggested solution is to add newline between concatenated files.\r\n\r\n___\r\nWorkaround:  Plugin configuration > Compress options > Use comments: Yes","created_at":"2016-11-03T13:16:12Z","updated_at":"2016-11-03T16:17:02Z","closed_at":"2016-11-03T16:17:02Z","merged_at":"2016-11-03T16:17:02Z","merge_commit_sha":"f1bed72a9b3029e93eef7be6efe00228b71ed605","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/pulls/23/commits","review_comments_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/pulls/23/comments","review_comment_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/issues/23/comments","statuses_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/statuses/522da36089dbf80b1ee55bf6f5db249f2754d174","head":{"label":"piotr-cz:patch-1","ref":"patch-1","sha":"522da36089dbf80b1ee55bf6f5db249f2754d174","user":{"login":"piotr-cz","id":612953,"avatar_url":"https://avatars.githubusercontent.com/u/612953?v=3","gravatar_id":"","url":"https://api.github.com/users/piotr-cz","html_url":"https://github.com/piotr-cz","followers_url":"https://api.github.com/users/piotr-cz/followers","following_url":"https://api.github.com/users/piotr-cz/following{/other_user}","gists_url":"https://api.github.com/users/piotr-cz/gists{/gist_id}","starred_url":"https://api.github.com/users/piotr-cz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotr-cz/subscriptions","organizations_url":"https://api.github.com/users/piotr-cz/orgs","repos_url":"https://api.github.com/users/piotr-cz/repos","events_url":"https://api.github.com/users/piotr-cz/events{/privacy}","received_events_url":"https://api.github.com/users/piotr-cz/received_events","type":"User","site_admin":false},"repo":{"id":72745717,"name":"pkg_scriptmerge","full_name":"piotr-cz/pkg_scriptmerge","owner":{"login":"piotr-cz","id":612953,"avatar_url":"https://avatars.githubusercontent.com/u/612953?v=3","gravatar_id":"","url":"https://api.github.com/users/piotr-cz","html_url":"https://github.com/piotr-cz","followers_url":"https://api.github.com/users/piotr-cz/followers","following_url":"https://api.github.com/users/piotr-cz/following{/other_user}","gists_url":"https://api.github.com/users/piotr-cz/gists{/gist_id}","starred_url":"https://api.github.com/users/piotr-cz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotr-cz/subscriptions","organizations_url":"https://api.github.com/users/piotr-cz/orgs","repos_url":"https://api.github.com/users/piotr-cz/repos","events_url":"https://api.github.com/users/piotr-cz/events{/privacy}","received_events_url":"https://api.github.com/users/piotr-cz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/piotr-cz/pkg_scriptmerge","description":null,"fork":true,"url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge","forks_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/forks","keys_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/teams","hooks_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/hooks","issue_events_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/issues/events{/number}","events_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/events","assignees_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/assignees{/user}","branches_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/branches{/branch}","tags_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/tags","blobs_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/git/refs{/sha}","trees_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/statuses/{sha}","languages_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/languages","stargazers_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/stargazers","contributors_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/contributors","subscribers_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/subscribers","subscription_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/subscription","commits_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/commits{/sha}","git_commits_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/git/commits{/sha}","comments_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/comments{/number}","issue_comment_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/issues/comments{/number}","contents_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/contents/{+path}","compare_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/merges","archive_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/downloads","issues_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/issues{/number}","pulls_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/pulls{/number}","milestones_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/milestones{/number}","notifications_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/labels{/name}","releases_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/releases{/id}","deployments_url":"https://api.github.com/repos/piotr-cz/pkg_scriptmerge/deployments","created_at":"2016-11-03T13:01:29Z","updated_at":"2016-11-03T13:01:30Z","pushed_at":"2016-11-03T13:02:12Z","git_url":"git://github.com/piotr-cz/pkg_scriptmerge.git","ssh_url":"git@github.com:piotr-cz/pkg_scriptmerge.git","clone_url":"https://github.com/piotr-cz/pkg_scriptmerge.git","svn_url":"https://github.com/piotr-cz/pkg_scriptmerge","homepage":null,"size":366,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yireo:master","ref":"master","sha":"0ffc45421c4d7f682b0cae5a0097cb3b2eb1d49d","user":{"login":"yireo","id":1373981,"avatar_url":"https://avatars.githubusercontent.com/u/1373981?v=3","gravatar_id":"","url":"https://api.github.com/users/yireo","html_url":"https://github.com/yireo","followers_url":"https://api.github.com/users/yireo/followers","following_url":"https://api.github.com/users/yireo/following{/other_user}","gists_url":"https://api.github.com/users/yireo/gists{/gist_id}","starred_url":"https://api.github.com/users/yireo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yireo/subscriptions","organizations_url":"https://api.github.com/users/yireo/orgs","repos_url":"https://api.github.com/users/yireo/repos","events_url":"https://api.github.com/users/yireo/events{/privacy}","received_events_url":"https://api.github.com/users/yireo/received_events","type":"User","site_admin":false},"repo":{"id":19603255,"name":"pkg_scriptmerge","full_name":"yireo/pkg_scriptmerge","owner":{"login":"yireo","id":1373981,"avatar_url":"https://avatars.githubusercontent.com/u/1373981?v=3","gravatar_id":"","url":"https://api.github.com/users/yireo","html_url":"https://github.com/yireo","followers_url":"https://api.github.com/users/yireo/followers","following_url":"https://api.github.com/users/yireo/following{/other_user}","gists_url":"https://api.github.com/users/yireo/gists{/gist_id}","starred_url":"https://api.github.com/users/yireo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yireo/subscriptions","organizations_url":"https://api.github.com/users/yireo/orgs","repos_url":"https://api.github.com/users/yireo/repos","events_url":"https://api.github.com/users/yireo/events{/privacy}","received_events_url":"https://api.github.com/users/yireo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yireo/pkg_scriptmerge","description":null,"fork":false,"url":"https://api.github.com/repos/yireo/pkg_scriptmerge","forks_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/forks","keys_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/teams","hooks_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/hooks","issue_events_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/issues/events{/number}","events_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/events","assignees_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/assignees{/user}","branches_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/branches{/branch}","tags_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/tags","blobs_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/git/refs{/sha}","trees_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/statuses/{sha}","languages_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/languages","stargazers_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/stargazers","contributors_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/contributors","subscribers_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/subscribers","subscription_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/subscription","commits_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/commits{/sha}","git_commits_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/git/commits{/sha}","comments_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/comments{/number}","issue_comment_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/issues/comments{/number}","contents_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/contents/{+path}","compare_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/merges","archive_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/downloads","issues_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/issues{/number}","pulls_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/pulls{/number}","milestones_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/milestones{/number}","notifications_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/labels{/name}","releases_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/releases{/id}","deployments_url":"https://api.github.com/repos/yireo/pkg_scriptmerge/deployments","created_at":"2014-05-09T07:41:09Z","updated_at":"2016-01-12T14:18:03Z","pushed_at":"2016-11-03T16:17:02Z","git_url":"git://github.com/yireo/pkg_scriptmerge.git","ssh_url":"git@github.com:yireo/pkg_scriptmerge.git","clone_url":"https://github.com/yireo/pkg_scriptmerge.git","svn_url":"https://github.com/yireo/pkg_scriptmerge","homepage":null,"size":376,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":5,"forks":9,"open_issues":5,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yireo/pkg_scriptmerge/pulls/23"},"html":{"href":"https://github.com/yireo/pkg_scriptmerge/pull/23"},"issue":{"href":"https://api.github.com/repos/yireo/pkg_scriptmerge/issues/23"},"comments":{"href":"https://api.github.com/repos/yireo/pkg_scriptmerge/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/yireo/pkg_scriptmerge/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/yireo/pkg_scriptmerge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yireo/pkg_scriptmerge/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/yireo/pkg_scriptmerge/statuses/522da36089dbf80b1ee55bf6f5db249f2754d174"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jissereitsma","id":7670482,"avatar_url":"https://avatars.githubusercontent.com/u/7670482?v=3","gravatar_id":"","url":"https://api.github.com/users/jissereitsma","html_url":"https://github.com/jissereitsma","followers_url":"https://api.github.com/users/jissereitsma/followers","following_url":"https://api.github.com/users/jissereitsma/following{/other_user}","gists_url":"https://api.github.com/users/jissereitsma/gists{/gist_id}","starred_url":"https://api.github.com/users/jissereitsma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jissereitsma/subscriptions","organizations_url":"https://api.github.com/users/jissereitsma/orgs","repos_url":"https://api.github.com/users/jissereitsma/repos","events_url":"https://api.github.com/users/jissereitsma/events{/privacy}","received_events_url":"https://api.github.com/users/jissereitsma/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"jissereitsma"}}