{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/calendar/pulls/comments/71896561","id":71896561,"diff_hunk":"@@ -260,6 +296,61 @@ app.service('CalendarService', ['DavClient', 'Calendar', function(DavClient, Cal\n \t\t});\n \t};\n \n+\tthis.createSubscription = function(name, color, source) {","path":"js/app/service/calendarservice.js","position":123,"original_position":123,"commit_id":"f1758300e3d1f34a8ba90b177644d2996b75d8b8","original_commit_id":"f1758300e3d1f34a8ba90b177644d2996b75d8b8","user":{"login":"tcitworld","id":2197836,"avatar_url":"https://avatars.githubusercontent.com/u/2197836?v=3","gravatar_id":"","url":"https://api.github.com/users/tcitworld","html_url":"https://github.com/tcitworld","followers_url":"https://api.github.com/users/tcitworld/followers","following_url":"https://api.github.com/users/tcitworld/following{/other_user}","gists_url":"https://api.github.com/users/tcitworld/gists{/gist_id}","starred_url":"https://api.github.com/users/tcitworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcitworld/subscriptions","organizations_url":"https://api.github.com/users/tcitworld/orgs","repos_url":"https://api.github.com/users/tcitworld/repos","events_url":"https://api.github.com/users/tcitworld/events{/privacy}","received_events_url":"https://api.github.com/users/tcitworld/received_events","type":"User","site_admin":false},"body":"Makes more or less the same than `this.create`, just 2 little differences.","created_at":"2016-07-22T15:22:52Z","updated_at":"2016-07-22T15:22:52Z","html_url":"https://github.com/owncloud/calendar/pull/631#discussion_r71896561","pull_request_url":"https://api.github.com/repos/owncloud/calendar/pulls/631","_links":{"self":{"href":"https://api.github.com/repos/owncloud/calendar/pulls/comments/71896561"},"html":{"href":"https://github.com/owncloud/calendar/pull/631#discussion_r71896561"},"pull_request":{"href":"https://api.github.com/repos/owncloud/calendar/pulls/631"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/calendar/pulls/631","id":78487947,"html_url":"https://github.com/owncloud/calendar/pull/631","diff_url":"https://github.com/owncloud/calendar/pull/631.diff","patch_url":"https://github.com/owncloud/calendar/pull/631.patch","issue_url":"https://api.github.com/repos/owncloud/calendar/issues/631","number":631,"state":"open","locked":false,"title":"Webcal rebased","user":{"login":"tcitworld","id":2197836,"avatar_url":"https://avatars.githubusercontent.com/u/2197836?v=3","gravatar_id":"","url":"https://api.github.com/users/tcitworld","html_url":"https://github.com/tcitworld","followers_url":"https://api.github.com/users/tcitworld/followers","following_url":"https://api.github.com/users/tcitworld/following{/other_user}","gists_url":"https://api.github.com/users/tcitworld/gists{/gist_id}","starred_url":"https://api.github.com/users/tcitworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcitworld/subscriptions","organizations_url":"https://api.github.com/users/tcitworld/orgs","repos_url":"https://api.github.com/users/tcitworld/repos","events_url":"https://api.github.com/users/tcitworld/events{/privacy}","received_events_url":"https://api.github.com/users/tcitworld/received_events","type":"User","site_admin":false},"body":"Didn't want to pollute the webcal branch so here is my take on it.\r\nRemarks : \r\n* yes, there is an **awful lot** of common code in the Subscription and Calendar models. I need to find how to extend the Subscription model from Calendar properly. Sorry for not doing things properly from scratch.\r\n* subscription is not shown directly, calendar view is not reloaded, need to reload page\r\n* when added, a subscription shows at first with the calendars\r\n* Subscription events are editable\r\n* There's a proxy and cache system for calendar files, and these files are stored inside the user's personal storage. Can it be otherwise (temporary files somehow) ? Hidden files ? Also, the cache time should be a setting (3600 hardcoded for now). Finally, files are saved with `basename(url)` as name, the subscription name should be better.\r\n* No color choice for subscription (editable though)\r\n\r\nTODOs\r\n- [ ] Refactor calendar/subscription model\r\n- [ ] Fix display of subscriptions\r\n- [ ] Make cache time a setting\r\n- [ ] Make subscription events read-only\r\n- [ ] Add color picker on creation\r\n- [ ] Use subscription name instead of `basename(url)` for the cache files names.","created_at":"2016-07-22T14:40:50Z","updated_at":"2016-07-22T15:22:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f78b8e9f16ea38e5baa1d2ff7796d5cd5078073","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/calendar/pulls/631/commits","review_comments_url":"https://api.github.com/repos/owncloud/calendar/pulls/631/comments","review_comment_url":"https://api.github.com/repos/owncloud/calendar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/calendar/issues/631/comments","statuses_url":"https://api.github.com/repos/owncloud/calendar/statuses/f1758300e3d1f34a8ba90b177644d2996b75d8b8","head":{"label":"owncloud:webcal-rebased","ref":"webcal-rebased","sha":"f1758300e3d1f34a8ba90b177644d2996b75d8b8","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":41913731,"name":"calendar","full_name":"owncloud/calendar","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/calendar","description":":date: Calendar app for ownCloud 9+","fork":false,"url":"https://api.github.com/repos/owncloud/calendar","forks_url":"https://api.github.com/repos/owncloud/calendar/forks","keys_url":"https://api.github.com/repos/owncloud/calendar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/calendar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/calendar/teams","hooks_url":"https://api.github.com/repos/owncloud/calendar/hooks","issue_events_url":"https://api.github.com/repos/owncloud/calendar/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/calendar/events","assignees_url":"https://api.github.com/repos/owncloud/calendar/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/calendar/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/calendar/tags","blobs_url":"https://api.github.com/repos/owncloud/calendar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/calendar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/calendar/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/calendar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/calendar/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/calendar/languages","stargazers_url":"https://api.github.com/repos/owncloud/calendar/stargazers","contributors_url":"https://api.github.com/repos/owncloud/calendar/contributors","subscribers_url":"https://api.github.com/repos/owncloud/calendar/subscribers","subscription_url":"https://api.github.com/repos/owncloud/calendar/subscription","commits_url":"https://api.github.com/repos/owncloud/calendar/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/calendar/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/calendar/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/calendar/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/calendar/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/calendar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/calendar/merges","archive_url":"https://api.github.com/repos/owncloud/calendar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/calendar/downloads","issues_url":"https://api.github.com/repos/owncloud/calendar/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/calendar/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/calendar/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/calendar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/calendar/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/calendar/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/calendar/deployments","created_at":"2015-09-04T12:08:35Z","updated_at":"2016-07-22T00:02:45Z","pushed_at":"2016-07-22T14:47:51Z","git_url":"git://github.com/owncloud/calendar.git","ssh_url":"git@github.com:owncloud/calendar.git","clone_url":"https://github.com/owncloud/calendar.git","svn_url":"https://github.com/owncloud/calendar","homepage":"https://webchat.freenode.net/?channels=owncloud-calendar","size":15229,"stargazers_count":72,"watchers_count":72,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":104,"forks":29,"open_issues":104,"watchers":72,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"95a5d8c7b1754721d66613b425ddbc75afd2196c","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":41913731,"name":"calendar","full_name":"owncloud/calendar","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/calendar","description":":date: Calendar app for ownCloud 9+","fork":false,"url":"https://api.github.com/repos/owncloud/calendar","forks_url":"https://api.github.com/repos/owncloud/calendar/forks","keys_url":"https://api.github.com/repos/owncloud/calendar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/calendar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/calendar/teams","hooks_url":"https://api.github.com/repos/owncloud/calendar/hooks","issue_events_url":"https://api.github.com/repos/owncloud/calendar/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/calendar/events","assignees_url":"https://api.github.com/repos/owncloud/calendar/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/calendar/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/calendar/tags","blobs_url":"https://api.github.com/repos/owncloud/calendar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/calendar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/calendar/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/calendar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/calendar/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/calendar/languages","stargazers_url":"https://api.github.com/repos/owncloud/calendar/stargazers","contributors_url":"https://api.github.com/repos/owncloud/calendar/contributors","subscribers_url":"https://api.github.com/repos/owncloud/calendar/subscribers","subscription_url":"https://api.github.com/repos/owncloud/calendar/subscription","commits_url":"https://api.github.com/repos/owncloud/calendar/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/calendar/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/calendar/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/calendar/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/calendar/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/calendar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/calendar/merges","archive_url":"https://api.github.com/repos/owncloud/calendar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/calendar/downloads","issues_url":"https://api.github.com/repos/owncloud/calendar/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/calendar/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/calendar/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/calendar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/calendar/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/calendar/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/calendar/deployments","created_at":"2015-09-04T12:08:35Z","updated_at":"2016-07-22T00:02:45Z","pushed_at":"2016-07-22T14:47:51Z","git_url":"git://github.com/owncloud/calendar.git","ssh_url":"git@github.com:owncloud/calendar.git","clone_url":"https://github.com/owncloud/calendar.git","svn_url":"https://github.com/owncloud/calendar","homepage":"https://webchat.freenode.net/?channels=owncloud-calendar","size":15229,"stargazers_count":72,"watchers_count":72,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":104,"forks":29,"open_issues":104,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/calendar/pulls/631"},"html":{"href":"https://github.com/owncloud/calendar/pull/631"},"issue":{"href":"https://api.github.com/repos/owncloud/calendar/issues/631"},"comments":{"href":"https://api.github.com/repos/owncloud/calendar/issues/631/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/calendar/pulls/631/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/calendar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/calendar/pulls/631/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/calendar/statuses/f1758300e3d1f34a8ba90b177644d2996b75d8b8"}}}}
{"actor":{"display_login":"tcitworld"}}