{"action":"created","comment":{"url":"https://api.github.com/repos/cbm755/octsympy/pulls/comments/92918453","pull_request_review_id":13443721,"id":92918453,"diff_hunk":"@@ -66,12 +79,7 @@\n     end\n   end\n \n-  if (length(subs) == 1 && islogical(subs{1}))\n-    %% A(logical) = B\n-    z = mat_mask_asgn(A, subs{1}, b);\n-    return\n-\n-  elseif (length(subs) == 1 && strcmp(subs{1}, ':') && length(b) == 1)","path":"inst/@sym/private/mat_replace.m","position":35,"original_position":35,"commit_id":"151e63907764752a83b696152462658fdde934b2","original_commit_id":"151e63907764752a83b696152462658fdde934b2","user":{"login":"genuinelucifer","id":11402325,"avatar_url":"https://avatars.githubusercontent.com/u/11402325?v=3","gravatar_id":"","url":"https://api.github.com/users/genuinelucifer","html_url":"https://github.com/genuinelucifer","followers_url":"https://api.github.com/users/genuinelucifer/followers","following_url":"https://api.github.com/users/genuinelucifer/following{/other_user}","gists_url":"https://api.github.com/users/genuinelucifer/gists{/gist_id}","starred_url":"https://api.github.com/users/genuinelucifer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genuinelucifer/subscriptions","organizations_url":"https://api.github.com/users/genuinelucifer/orgs","repos_url":"https://api.github.com/users/genuinelucifer/repos","events_url":"https://api.github.com/users/genuinelucifer/events{/privacy}","received_events_url":"https://api.github.com/users/genuinelucifer/received_events","type":"User","site_admin":false},"body":"I have remove the first if as that condition is now taken care at the start of this method. ","created_at":"2016-12-17T09:10:35Z","updated_at":"2016-12-17T09:10:35Z","html_url":"https://github.com/cbm755/octsympy/pull/690#discussion_r92918453","pull_request_url":"https://api.github.com/repos/cbm755/octsympy/pulls/690","_links":{"self":{"href":"https://api.github.com/repos/cbm755/octsympy/pulls/comments/92918453"},"html":{"href":"https://github.com/cbm755/octsympy/pull/690#discussion_r92918453"},"pull_request":{"href":"https://api.github.com/repos/cbm755/octsympy/pulls/690"}}},"pull_request":{"url":"https://api.github.com/repos/cbm755/octsympy/pulls/690","id":93486792,"html_url":"https://github.com/cbm755/octsympy/pull/690","diff_url":"https://github.com/cbm755/octsympy/pull/690.diff","patch_url":"https://github.com/cbm755/octsympy/pull/690.patch","issue_url":"https://api.github.com/repos/cbm755/octsympy/issues/690","number":690,"state":"open","locked":false,"title":"Fix subsasgn behaviour when logical indices are used.","user":{"login":"genuinelucifer","id":11402325,"avatar_url":"https://avatars.githubusercontent.com/u/11402325?v=3","gravatar_id":"","url":"https://api.github.com/users/genuinelucifer","html_url":"https://github.com/genuinelucifer","followers_url":"https://api.github.com/users/genuinelucifer/followers","following_url":"https://api.github.com/users/genuinelucifer/following{/other_user}","gists_url":"https://api.github.com/users/genuinelucifer/gists{/gist_id}","starred_url":"https://api.github.com/users/genuinelucifer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genuinelucifer/subscriptions","organizations_url":"https://api.github.com/users/genuinelucifer/orgs","repos_url":"https://api.github.com/users/genuinelucifer/repos","events_url":"https://api.github.com/users/genuinelucifer/events{/privacy}","received_events_url":"https://api.github.com/users/genuinelucifer/received_events","type":"User","site_admin":false},"body":"Fixes issue #598\r\nWhen logical indices are used, pass the valid indices (if any). If there are\r\nno valid indices then return the input as is.","created_at":"2016-11-13T21:03:00Z","updated_at":"2016-12-17T09:11:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfc5c82774a19335c4f8d18eb3c7a96f3f52f2c9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cbm755/octsympy/pulls/690/commits","review_comments_url":"https://api.github.com/repos/cbm755/octsympy/pulls/690/comments","review_comment_url":"https://api.github.com/repos/cbm755/octsympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cbm755/octsympy/issues/690/comments","statuses_url":"https://api.github.com/repos/cbm755/octsympy/statuses/151e63907764752a83b696152462658fdde934b2","head":{"label":"genuinelucifer:subsasgn","ref":"subsasgn","sha":"151e63907764752a83b696152462658fdde934b2","user":{"login":"genuinelucifer","id":11402325,"avatar_url":"https://avatars.githubusercontent.com/u/11402325?v=3","gravatar_id":"","url":"https://api.github.com/users/genuinelucifer","html_url":"https://github.com/genuinelucifer","followers_url":"https://api.github.com/users/genuinelucifer/followers","following_url":"https://api.github.com/users/genuinelucifer/following{/other_user}","gists_url":"https://api.github.com/users/genuinelucifer/gists{/gist_id}","starred_url":"https://api.github.com/users/genuinelucifer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genuinelucifer/subscriptions","organizations_url":"https://api.github.com/users/genuinelucifer/orgs","repos_url":"https://api.github.com/users/genuinelucifer/repos","events_url":"https://api.github.com/users/genuinelucifer/events{/privacy}","received_events_url":"https://api.github.com/users/genuinelucifer/received_events","type":"User","site_admin":false},"repo":{"id":53196083,"name":"octsympy","full_name":"genuinelucifer/octsympy","owner":{"login":"genuinelucifer","id":11402325,"avatar_url":"https://avatars.githubusercontent.com/u/11402325?v=3","gravatar_id":"","url":"https://api.github.com/users/genuinelucifer","html_url":"https://github.com/genuinelucifer","followers_url":"https://api.github.com/users/genuinelucifer/followers","following_url":"https://api.github.com/users/genuinelucifer/following{/other_user}","gists_url":"https://api.github.com/users/genuinelucifer/gists{/gist_id}","starred_url":"https://api.github.com/users/genuinelucifer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genuinelucifer/subscriptions","organizations_url":"https://api.github.com/users/genuinelucifer/orgs","repos_url":"https://api.github.com/users/genuinelucifer/repos","events_url":"https://api.github.com/users/genuinelucifer/events{/privacy}","received_events_url":"https://api.github.com/users/genuinelucifer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/genuinelucifer/octsympy","description":"A Symbolic Package for Octave using SymPy","fork":true,"url":"https://api.github.com/repos/genuinelucifer/octsympy","forks_url":"https://api.github.com/repos/genuinelucifer/octsympy/forks","keys_url":"https://api.github.com/repos/genuinelucifer/octsympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/genuinelucifer/octsympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/genuinelucifer/octsympy/teams","hooks_url":"https://api.github.com/repos/genuinelucifer/octsympy/hooks","issue_events_url":"https://api.github.com/repos/genuinelucifer/octsympy/issues/events{/number}","events_url":"https://api.github.com/repos/genuinelucifer/octsympy/events","assignees_url":"https://api.github.com/repos/genuinelucifer/octsympy/assignees{/user}","branches_url":"https://api.github.com/repos/genuinelucifer/octsympy/branches{/branch}","tags_url":"https://api.github.com/repos/genuinelucifer/octsympy/tags","blobs_url":"https://api.github.com/repos/genuinelucifer/octsympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/genuinelucifer/octsympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/genuinelucifer/octsympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/genuinelucifer/octsympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/genuinelucifer/octsympy/statuses/{sha}","languages_url":"https://api.github.com/repos/genuinelucifer/octsympy/languages","stargazers_url":"https://api.github.com/repos/genuinelucifer/octsympy/stargazers","contributors_url":"https://api.github.com/repos/genuinelucifer/octsympy/contributors","subscribers_url":"https://api.github.com/repos/genuinelucifer/octsympy/subscribers","subscription_url":"https://api.github.com/repos/genuinelucifer/octsympy/subscription","commits_url":"https://api.github.com/repos/genuinelucifer/octsympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/genuinelucifer/octsympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/genuinelucifer/octsympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/genuinelucifer/octsympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/genuinelucifer/octsympy/contents/{+path}","compare_url":"https://api.github.com/repos/genuinelucifer/octsympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/genuinelucifer/octsympy/merges","archive_url":"https://api.github.com/repos/genuinelucifer/octsympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/genuinelucifer/octsympy/downloads","issues_url":"https://api.github.com/repos/genuinelucifer/octsympy/issues{/number}","pulls_url":"https://api.github.com/repos/genuinelucifer/octsympy/pulls{/number}","milestones_url":"https://api.github.com/repos/genuinelucifer/octsympy/milestones{/number}","notifications_url":"https://api.github.com/repos/genuinelucifer/octsympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/genuinelucifer/octsympy/labels{/name}","releases_url":"https://api.github.com/repos/genuinelucifer/octsympy/releases{/id}","deployments_url":"https://api.github.com/repos/genuinelucifer/octsympy/deployments","created_at":"2016-03-05T10:33:30Z","updated_at":"2016-03-05T10:33:31Z","pushed_at":"2016-12-17T09:02:25Z","git_url":"git://github.com/genuinelucifer/octsympy.git","ssh_url":"git@github.com:genuinelucifer/octsympy.git","clone_url":"https://github.com/genuinelucifer/octsympy.git","svn_url":"https://github.com/genuinelucifer/octsympy","homepage":"","size":3271,"stargazers_count":0,"watchers_count":0,"language":"Matlab","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cbm755:master","ref":"master","sha":"48531fc4d71842660cea7e2e6db4c93b00285d23","user":{"login":"cbm755","id":818622,"avatar_url":"https://avatars.githubusercontent.com/u/818622?v=3","gravatar_id":"","url":"https://api.github.com/users/cbm755","html_url":"https://github.com/cbm755","followers_url":"https://api.github.com/users/cbm755/followers","following_url":"https://api.github.com/users/cbm755/following{/other_user}","gists_url":"https://api.github.com/users/cbm755/gists{/gist_id}","starred_url":"https://api.github.com/users/cbm755/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbm755/subscriptions","organizations_url":"https://api.github.com/users/cbm755/orgs","repos_url":"https://api.github.com/users/cbm755/repos","events_url":"https://api.github.com/users/cbm755/events{/privacy}","received_events_url":"https://api.github.com/users/cbm755/received_events","type":"User","site_admin":false},"repo":{"id":18641463,"name":"octsympy","full_name":"cbm755/octsympy","owner":{"login":"cbm755","id":818622,"avatar_url":"https://avatars.githubusercontent.com/u/818622?v=3","gravatar_id":"","url":"https://api.github.com/users/cbm755","html_url":"https://github.com/cbm755","followers_url":"https://api.github.com/users/cbm755/followers","following_url":"https://api.github.com/users/cbm755/following{/other_user}","gists_url":"https://api.github.com/users/cbm755/gists{/gist_id}","starred_url":"https://api.github.com/users/cbm755/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbm755/subscriptions","organizations_url":"https://api.github.com/users/cbm755/orgs","repos_url":"https://api.github.com/users/cbm755/repos","events_url":"https://api.github.com/users/cbm755/events{/privacy}","received_events_url":"https://api.github.com/users/cbm755/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cbm755/octsympy","description":"A Symbolic Package for Octave using SymPy","fork":false,"url":"https://api.github.com/repos/cbm755/octsympy","forks_url":"https://api.github.com/repos/cbm755/octsympy/forks","keys_url":"https://api.github.com/repos/cbm755/octsympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbm755/octsympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbm755/octsympy/teams","hooks_url":"https://api.github.com/repos/cbm755/octsympy/hooks","issue_events_url":"https://api.github.com/repos/cbm755/octsympy/issues/events{/number}","events_url":"https://api.github.com/repos/cbm755/octsympy/events","assignees_url":"https://api.github.com/repos/cbm755/octsympy/assignees{/user}","branches_url":"https://api.github.com/repos/cbm755/octsympy/branches{/branch}","tags_url":"https://api.github.com/repos/cbm755/octsympy/tags","blobs_url":"https://api.github.com/repos/cbm755/octsympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbm755/octsympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbm755/octsympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbm755/octsympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbm755/octsympy/statuses/{sha}","languages_url":"https://api.github.com/repos/cbm755/octsympy/languages","stargazers_url":"https://api.github.com/repos/cbm755/octsympy/stargazers","contributors_url":"https://api.github.com/repos/cbm755/octsympy/contributors","subscribers_url":"https://api.github.com/repos/cbm755/octsympy/subscribers","subscription_url":"https://api.github.com/repos/cbm755/octsympy/subscription","commits_url":"https://api.github.com/repos/cbm755/octsympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbm755/octsympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbm755/octsympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbm755/octsympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbm755/octsympy/contents/{+path}","compare_url":"https://api.github.com/repos/cbm755/octsympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbm755/octsympy/merges","archive_url":"https://api.github.com/repos/cbm755/octsympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbm755/octsympy/downloads","issues_url":"https://api.github.com/repos/cbm755/octsympy/issues{/number}","pulls_url":"https://api.github.com/repos/cbm755/octsympy/pulls{/number}","milestones_url":"https://api.github.com/repos/cbm755/octsympy/milestones{/number}","notifications_url":"https://api.github.com/repos/cbm755/octsympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbm755/octsympy/labels{/name}","releases_url":"https://api.github.com/repos/cbm755/octsympy/releases{/id}","deployments_url":"https://api.github.com/repos/cbm755/octsympy/deployments","created_at":"2014-04-10T15:25:39Z","updated_at":"2016-11-27T13:32:15Z","pushed_at":"2016-12-17T09:02:25Z","git_url":"git://github.com/cbm755/octsympy.git","ssh_url":"git@github.com:cbm755/octsympy.git","clone_url":"https://github.com/cbm755/octsympy.git","svn_url":"https://github.com/cbm755/octsympy","homepage":"","size":3217,"stargazers_count":24,"watchers_count":24,"language":"Matlab","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":133,"forks":13,"open_issues":133,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cbm755/octsympy/pulls/690"},"html":{"href":"https://github.com/cbm755/octsympy/pull/690"},"issue":{"href":"https://api.github.com/repos/cbm755/octsympy/issues/690"},"comments":{"href":"https://api.github.com/repos/cbm755/octsympy/issues/690/comments"},"review_comments":{"href":"https://api.github.com/repos/cbm755/octsympy/pulls/690/comments"},"review_comment":{"href":"https://api.github.com/repos/cbm755/octsympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cbm755/octsympy/pulls/690/commits"},"statuses":{"href":"https://api.github.com/repos/cbm755/octsympy/statuses/151e63907764752a83b696152462658fdde934b2"}}}}
{"actor":{"display_login":"genuinelucifer"}}