{"action":"created","comment":{"url":"https://api.github.com/repos/tass-belgium/picotcp/pulls/comments/63673837","id":63673837,"diff_hunk":"@@ -807,8 +818,14 @@ pico_mdns_record_resolve_conflict( struct pico_mdns_record *record,\n \n     copy = pico_mdns_record_copy_with_new_name(record, new_name);\n     PICO_FREE(new_name);\n-    if (copy)\n-        pico_tree_insert(&new_records, copy);\n+    if (copy){\n+    \tif(pico_tree_insert(&new_records, copy) ){\n+\t\t\tif(pico_err != PICO_ERR_ENOMEM){\n+\t\t\t\tpico_err = PICO_ERR_EINVAL;\n+\t\t\t}\n+\t\t\treturn -1;\n+\t\t}\n+    }","path":"modules/pico_mdns.c","position":44,"original_position":44,"commit_id":"9ac35116fb2270fb1b77d88e5565dc2f4cb9e485","original_commit_id":"9ac35116fb2270fb1b77d88e5565dc2f4cb9e485","user":{"login":"frederikvs","id":3795966,"avatar_url":"https://avatars.githubusercontent.com/u/3795966?v=3","gravatar_id":"","url":"https://api.github.com/users/frederikvs","html_url":"https://github.com/frederikvs","followers_url":"https://api.github.com/users/frederikvs/followers","following_url":"https://api.github.com/users/frederikvs/following{/other_user}","gists_url":"https://api.github.com/users/frederikvs/gists{/gist_id}","starred_url":"https://api.github.com/users/frederikvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frederikvs/subscriptions","organizations_url":"https://api.github.com/users/frederikvs/orgs","repos_url":"https://api.github.com/users/frederikvs/repos","events_url":"https://api.github.com/users/frederikvs/events{/privacy}","received_events_url":"https://api.github.com/users/frederikvs/received_events","type":"User","site_admin":false},"body":"I think you need to delete the `copy` here as well.","created_at":"2016-05-18T09:42:33Z","updated_at":"2016-05-18T09:42:33Z","html_url":"https://github.com/tass-belgium/picotcp/pull/386#discussion_r63673837","pull_request_url":"https://api.github.com/repos/tass-belgium/picotcp/pulls/386","_links":{"self":{"href":"https://api.github.com/repos/tass-belgium/picotcp/pulls/comments/63673837"},"html":{"href":"https://github.com/tass-belgium/picotcp/pull/386#discussion_r63673837"},"pull_request":{"href":"https://api.github.com/repos/tass-belgium/picotcp/pulls/386"}}},"pull_request":{"url":"https://api.github.com/repos/tass-belgium/picotcp/pulls/386","id":70202500,"html_url":"https://github.com/tass-belgium/picotcp/pull/386","diff_url":"https://github.com/tass-belgium/picotcp/pull/386.diff","patch_url":"https://github.com/tass-belgium/picotcp/pull/386.patch","issue_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/386","number":386,"state":"open","locked":false,"title":"Fix for issue #380","user":{"login":"VincentDeHaen","id":14886522,"avatar_url":"https://avatars.githubusercontent.com/u/14886522?v=3","gravatar_id":"","url":"https://api.github.com/users/VincentDeHaen","html_url":"https://github.com/VincentDeHaen","followers_url":"https://api.github.com/users/VincentDeHaen/followers","following_url":"https://api.github.com/users/VincentDeHaen/following{/other_user}","gists_url":"https://api.github.com/users/VincentDeHaen/gists{/gist_id}","starred_url":"https://api.github.com/users/VincentDeHaen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VincentDeHaen/subscriptions","organizations_url":"https://api.github.com/users/VincentDeHaen/orgs","repos_url":"https://api.github.com/users/VincentDeHaen/repos","events_url":"https://api.github.com/users/VincentDeHaen/events{/privacy}","received_events_url":"https://api.github.com/users/VincentDeHaen/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-16T14:15:37Z","updated_at":"2016-05-18T09:42:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09d61c346a8d6b6a1c28c7c20abd37f619f2f496","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tass-belgium/picotcp/pulls/386/commits","review_comments_url":"https://api.github.com/repos/tass-belgium/picotcp/pulls/386/comments","review_comment_url":"https://api.github.com/repos/tass-belgium/picotcp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/386/comments","statuses_url":"https://api.github.com/repos/tass-belgium/picotcp/statuses/9ac35116fb2270fb1b77d88e5565dc2f4cb9e485","head":{"label":"tass-belgium:vince_dev","ref":"vince_dev","sha":"9ac35116fb2270fb1b77d88e5565dc2f4cb9e485","user":{"login":"tass-belgium","id":3645539,"avatar_url":"https://avatars.githubusercontent.com/u/3645539?v=3","gravatar_id":"","url":"https://api.github.com/users/tass-belgium","html_url":"https://github.com/tass-belgium","followers_url":"https://api.github.com/users/tass-belgium/followers","following_url":"https://api.github.com/users/tass-belgium/following{/other_user}","gists_url":"https://api.github.com/users/tass-belgium/gists{/gist_id}","starred_url":"https://api.github.com/users/tass-belgium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tass-belgium/subscriptions","organizations_url":"https://api.github.com/users/tass-belgium/orgs","repos_url":"https://api.github.com/users/tass-belgium/repos","events_url":"https://api.github.com/users/tass-belgium/events{/privacy}","received_events_url":"https://api.github.com/users/tass-belgium/received_events","type":"Organization","site_admin":false},"repo":{"id":8309253,"name":"picotcp","full_name":"tass-belgium/picotcp","owner":{"login":"tass-belgium","id":3645539,"avatar_url":"https://avatars.githubusercontent.com/u/3645539?v=3","gravatar_id":"","url":"https://api.github.com/users/tass-belgium","html_url":"https://github.com/tass-belgium","followers_url":"https://api.github.com/users/tass-belgium/followers","following_url":"https://api.github.com/users/tass-belgium/following{/other_user}","gists_url":"https://api.github.com/users/tass-belgium/gists{/gist_id}","starred_url":"https://api.github.com/users/tass-belgium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tass-belgium/subscriptions","organizations_url":"https://api.github.com/users/tass-belgium/orgs","repos_url":"https://api.github.com/users/tass-belgium/repos","events_url":"https://api.github.com/users/tass-belgium/events{/privacy}","received_events_url":"https://api.github.com/users/tass-belgium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tass-belgium/picotcp","description":"PicoTCP is a free TCP/IP stack implementation","fork":false,"url":"https://api.github.com/repos/tass-belgium/picotcp","forks_url":"https://api.github.com/repos/tass-belgium/picotcp/forks","keys_url":"https://api.github.com/repos/tass-belgium/picotcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tass-belgium/picotcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tass-belgium/picotcp/teams","hooks_url":"https://api.github.com/repos/tass-belgium/picotcp/hooks","issue_events_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/events{/number}","events_url":"https://api.github.com/repos/tass-belgium/picotcp/events","assignees_url":"https://api.github.com/repos/tass-belgium/picotcp/assignees{/user}","branches_url":"https://api.github.com/repos/tass-belgium/picotcp/branches{/branch}","tags_url":"https://api.github.com/repos/tass-belgium/picotcp/tags","blobs_url":"https://api.github.com/repos/tass-belgium/picotcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tass-belgium/picotcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tass-belgium/picotcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/tass-belgium/picotcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tass-belgium/picotcp/statuses/{sha}","languages_url":"https://api.github.com/repos/tass-belgium/picotcp/languages","stargazers_url":"https://api.github.com/repos/tass-belgium/picotcp/stargazers","contributors_url":"https://api.github.com/repos/tass-belgium/picotcp/contributors","subscribers_url":"https://api.github.com/repos/tass-belgium/picotcp/subscribers","subscription_url":"https://api.github.com/repos/tass-belgium/picotcp/subscription","commits_url":"https://api.github.com/repos/tass-belgium/picotcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/tass-belgium/picotcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/tass-belgium/picotcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/tass-belgium/picotcp/contents/{+path}","compare_url":"https://api.github.com/repos/tass-belgium/picotcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tass-belgium/picotcp/merges","archive_url":"https://api.github.com/repos/tass-belgium/picotcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tass-belgium/picotcp/downloads","issues_url":"https://api.github.com/repos/tass-belgium/picotcp/issues{/number}","pulls_url":"https://api.github.com/repos/tass-belgium/picotcp/pulls{/number}","milestones_url":"https://api.github.com/repos/tass-belgium/picotcp/milestones{/number}","notifications_url":"https://api.github.com/repos/tass-belgium/picotcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tass-belgium/picotcp/labels{/name}","releases_url":"https://api.github.com/repos/tass-belgium/picotcp/releases{/id}","deployments_url":"https://api.github.com/repos/tass-belgium/picotcp/deployments","created_at":"2013-02-20T08:43:50Z","updated_at":"2016-05-16T04:52:51Z","pushed_at":"2016-05-16T14:15:37Z","git_url":"git://github.com/tass-belgium/picotcp.git","ssh_url":"git@github.com:tass-belgium/picotcp.git","clone_url":"https://github.com/tass-belgium/picotcp.git","svn_url":"https://github.com/tass-belgium/picotcp","homepage":null,"size":12551,"stargazers_count":241,"watchers_count":241,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":74,"forks":42,"open_issues":74,"watchers":241,"default_branch":"master"}},"base":{"label":"tass-belgium:development","ref":"development","sha":"14421707822203878c98d889dece0d758748a397","user":{"login":"tass-belgium","id":3645539,"avatar_url":"https://avatars.githubusercontent.com/u/3645539?v=3","gravatar_id":"","url":"https://api.github.com/users/tass-belgium","html_url":"https://github.com/tass-belgium","followers_url":"https://api.github.com/users/tass-belgium/followers","following_url":"https://api.github.com/users/tass-belgium/following{/other_user}","gists_url":"https://api.github.com/users/tass-belgium/gists{/gist_id}","starred_url":"https://api.github.com/users/tass-belgium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tass-belgium/subscriptions","organizations_url":"https://api.github.com/users/tass-belgium/orgs","repos_url":"https://api.github.com/users/tass-belgium/repos","events_url":"https://api.github.com/users/tass-belgium/events{/privacy}","received_events_url":"https://api.github.com/users/tass-belgium/received_events","type":"Organization","site_admin":false},"repo":{"id":8309253,"name":"picotcp","full_name":"tass-belgium/picotcp","owner":{"login":"tass-belgium","id":3645539,"avatar_url":"https://avatars.githubusercontent.com/u/3645539?v=3","gravatar_id":"","url":"https://api.github.com/users/tass-belgium","html_url":"https://github.com/tass-belgium","followers_url":"https://api.github.com/users/tass-belgium/followers","following_url":"https://api.github.com/users/tass-belgium/following{/other_user}","gists_url":"https://api.github.com/users/tass-belgium/gists{/gist_id}","starred_url":"https://api.github.com/users/tass-belgium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tass-belgium/subscriptions","organizations_url":"https://api.github.com/users/tass-belgium/orgs","repos_url":"https://api.github.com/users/tass-belgium/repos","events_url":"https://api.github.com/users/tass-belgium/events{/privacy}","received_events_url":"https://api.github.com/users/tass-belgium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tass-belgium/picotcp","description":"PicoTCP is a free TCP/IP stack implementation","fork":false,"url":"https://api.github.com/repos/tass-belgium/picotcp","forks_url":"https://api.github.com/repos/tass-belgium/picotcp/forks","keys_url":"https://api.github.com/repos/tass-belgium/picotcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tass-belgium/picotcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tass-belgium/picotcp/teams","hooks_url":"https://api.github.com/repos/tass-belgium/picotcp/hooks","issue_events_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/events{/number}","events_url":"https://api.github.com/repos/tass-belgium/picotcp/events","assignees_url":"https://api.github.com/repos/tass-belgium/picotcp/assignees{/user}","branches_url":"https://api.github.com/repos/tass-belgium/picotcp/branches{/branch}","tags_url":"https://api.github.com/repos/tass-belgium/picotcp/tags","blobs_url":"https://api.github.com/repos/tass-belgium/picotcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tass-belgium/picotcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tass-belgium/picotcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/tass-belgium/picotcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tass-belgium/picotcp/statuses/{sha}","languages_url":"https://api.github.com/repos/tass-belgium/picotcp/languages","stargazers_url":"https://api.github.com/repos/tass-belgium/picotcp/stargazers","contributors_url":"https://api.github.com/repos/tass-belgium/picotcp/contributors","subscribers_url":"https://api.github.com/repos/tass-belgium/picotcp/subscribers","subscription_url":"https://api.github.com/repos/tass-belgium/picotcp/subscription","commits_url":"https://api.github.com/repos/tass-belgium/picotcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/tass-belgium/picotcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/tass-belgium/picotcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/tass-belgium/picotcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/tass-belgium/picotcp/contents/{+path}","compare_url":"https://api.github.com/repos/tass-belgium/picotcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tass-belgium/picotcp/merges","archive_url":"https://api.github.com/repos/tass-belgium/picotcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tass-belgium/picotcp/downloads","issues_url":"https://api.github.com/repos/tass-belgium/picotcp/issues{/number}","pulls_url":"https://api.github.com/repos/tass-belgium/picotcp/pulls{/number}","milestones_url":"https://api.github.com/repos/tass-belgium/picotcp/milestones{/number}","notifications_url":"https://api.github.com/repos/tass-belgium/picotcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tass-belgium/picotcp/labels{/name}","releases_url":"https://api.github.com/repos/tass-belgium/picotcp/releases{/id}","deployments_url":"https://api.github.com/repos/tass-belgium/picotcp/deployments","created_at":"2013-02-20T08:43:50Z","updated_at":"2016-05-16T04:52:51Z","pushed_at":"2016-05-16T14:15:37Z","git_url":"git://github.com/tass-belgium/picotcp.git","ssh_url":"git@github.com:tass-belgium/picotcp.git","clone_url":"https://github.com/tass-belgium/picotcp.git","svn_url":"https://github.com/tass-belgium/picotcp","homepage":null,"size":12551,"stargazers_count":241,"watchers_count":241,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":74,"forks":42,"open_issues":74,"watchers":241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tass-belgium/picotcp/pulls/386"},"html":{"href":"https://github.com/tass-belgium/picotcp/pull/386"},"issue":{"href":"https://api.github.com/repos/tass-belgium/picotcp/issues/386"},"comments":{"href":"https://api.github.com/repos/tass-belgium/picotcp/issues/386/comments"},"review_comments":{"href":"https://api.github.com/repos/tass-belgium/picotcp/pulls/386/comments"},"review_comment":{"href":"https://api.github.com/repos/tass-belgium/picotcp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tass-belgium/picotcp/pulls/386/commits"},"statuses":{"href":"https://api.github.com/repos/tass-belgium/picotcp/statuses/9ac35116fb2270fb1b77d88e5565dc2f4cb9e485"}}}}