{"action":"closed","number":164,"pull_request":{"url":"https://api.github.com/repos/san650/ember-cli-page-object/pulls/164","id":66928231,"html_url":"https://github.com/san650/ember-cli-page-object/pull/164","diff_url":"https://github.com/san650/ember-cli-page-object/pull/164.diff","patch_url":"https://github.com/san650/ember-cli-page-object/pull/164.patch","issue_url":"https://api.github.com/repos/san650/ember-cli-page-object/issues/164","number":164,"state":"closed","locked":false,"title":"Make collections easier to enumerate","user":{"login":"dfreeman","id":108688,"avatar_url":"https://avatars.githubusercontent.com/u/108688?v=3","gravatar_id":"","url":"https://api.github.com/users/dfreeman","html_url":"https://github.com/dfreeman","followers_url":"https://api.github.com/users/dfreeman/followers","following_url":"https://api.github.com/users/dfreeman/following{/other_user}","gists_url":"https://api.github.com/users/dfreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/dfreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfreeman/subscriptions","organizations_url":"https://api.github.com/users/dfreeman/orgs","repos_url":"https://api.github.com/users/dfreeman/repos","events_url":"https://api.github.com/users/dfreeman/events{/privacy}","received_events_url":"https://api.github.com/users/dfreeman/received_events","type":"User","site_admin":false},"body":"This PR implements the changes discussed in https://github.com/san650/ember-cli-page-object/issues/54. @san650 it also includes the delegation of array methods we talked about, since it was easy to add them while I was in there. If you'd prefer to have that addressed in a separate PR, I'm happy to pull them out.\r\n\r\nWith this change, the following properties are now added to collection objects on creation if they haven't already been defined:\r\n- a `toArray()` method that returns an array containing the elements of the collection\r\n- a `[Symbol.iterator]()` method which yields each item in the collection sequentially (only if `Symbol.iterator` is present in the current environment)\r\n- `map`, `mapBy`, `filter`, and `filterBy` methods, all of which just delegate to the methods of the same name on the result of `toArray()`.\r\n","created_at":"2016-04-18T21:51:31Z","updated_at":"2016-04-18T23:36:24Z","closed_at":"2016-04-18T23:36:24Z","merged_at":"2016-04-18T23:36:24Z","merge_commit_sha":"1fb1b7acc8a4aea2243959ea9147cb44ec8c70cf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/san650/ember-cli-page-object/pulls/164/commits","review_comments_url":"https://api.github.com/repos/san650/ember-cli-page-object/pulls/164/comments","review_comment_url":"https://api.github.com/repos/san650/ember-cli-page-object/pulls/comments{/number}","comments_url":"https://api.github.com/repos/san650/ember-cli-page-object/issues/164/comments","statuses_url":"https://api.github.com/repos/san650/ember-cli-page-object/statuses/07da427259402449deaa7dbf11442d3a4c6efb12","head":{"label":"dfreeman:collection-methods","ref":"collection-methods","sha":"07da427259402449deaa7dbf11442d3a4c6efb12","user":{"login":"dfreeman","id":108688,"avatar_url":"https://avatars.githubusercontent.com/u/108688?v=3","gravatar_id":"","url":"https://api.github.com/users/dfreeman","html_url":"https://github.com/dfreeman","followers_url":"https://api.github.com/users/dfreeman/followers","following_url":"https://api.github.com/users/dfreeman/following{/other_user}","gists_url":"https://api.github.com/users/dfreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/dfreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfreeman/subscriptions","organizations_url":"https://api.github.com/users/dfreeman/orgs","repos_url":"https://api.github.com/users/dfreeman/repos","events_url":"https://api.github.com/users/dfreeman/events{/privacy}","received_events_url":"https://api.github.com/users/dfreeman/received_events","type":"User","site_admin":false},"repo":{"id":56082339,"name":"ember-cli-page-object","full_name":"dfreeman/ember-cli-page-object","owner":{"login":"dfreeman","id":108688,"avatar_url":"https://avatars.githubusercontent.com/u/108688?v=3","gravatar_id":"","url":"https://api.github.com/users/dfreeman","html_url":"https://github.com/dfreeman","followers_url":"https://api.github.com/users/dfreeman/followers","following_url":"https://api.github.com/users/dfreeman/following{/other_user}","gists_url":"https://api.github.com/users/dfreeman/gists{/gist_id}","starred_url":"https://api.github.com/users/dfreeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfreeman/subscriptions","organizations_url":"https://api.github.com/users/dfreeman/orgs","repos_url":"https://api.github.com/users/dfreeman/repos","events_url":"https://api.github.com/users/dfreeman/events{/privacy}","received_events_url":"https://api.github.com/users/dfreeman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dfreeman/ember-cli-page-object","description":"Represent the screens of your web app as a series of objects. This ember-cli addon eases the construction of these objects on your acceptance tests.","fork":true,"url":"https://api.github.com/repos/dfreeman/ember-cli-page-object","forks_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/forks","keys_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/teams","hooks_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/hooks","issue_events_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/issues/events{/number}","events_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/events","assignees_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/assignees{/user}","branches_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/branches{/branch}","tags_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/tags","blobs_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/git/refs{/sha}","trees_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/statuses/{sha}","languages_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/languages","stargazers_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/stargazers","contributors_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/contributors","subscribers_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/subscribers","subscription_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/subscription","commits_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/commits{/sha}","git_commits_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/git/commits{/sha}","comments_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/comments{/number}","issue_comment_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/issues/comments{/number}","contents_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/contents/{+path}","compare_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/merges","archive_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/downloads","issues_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/issues{/number}","pulls_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/pulls{/number}","milestones_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/milestones{/number}","notifications_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/labels{/name}","releases_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/releases{/id}","deployments_url":"https://api.github.com/repos/dfreeman/ember-cli-page-object/deployments","created_at":"2016-04-12T17:05:39Z","updated_at":"2016-04-12T17:05:40Z","pushed_at":"2016-04-18T21:44:00Z","git_url":"git://github.com/dfreeman/ember-cli-page-object.git","ssh_url":"git@github.com:dfreeman/ember-cli-page-object.git","clone_url":"https://github.com/dfreeman/ember-cli-page-object.git","svn_url":"https://github.com/dfreeman/ember-cli-page-object","homepage":"http://ember-cli-page-object.js.org/","size":1107,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"san650:master","ref":"master","sha":"12dda77f689f566442480996cf53b0b0e547eadb","user":{"login":"san650","id":1234607,"avatar_url":"https://avatars.githubusercontent.com/u/1234607?v=3","gravatar_id":"","url":"https://api.github.com/users/san650","html_url":"https://github.com/san650","followers_url":"https://api.github.com/users/san650/followers","following_url":"https://api.github.com/users/san650/following{/other_user}","gists_url":"https://api.github.com/users/san650/gists{/gist_id}","starred_url":"https://api.github.com/users/san650/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/san650/subscriptions","organizations_url":"https://api.github.com/users/san650/orgs","repos_url":"https://api.github.com/users/san650/repos","events_url":"https://api.github.com/users/san650/events{/privacy}","received_events_url":"https://api.github.com/users/san650/received_events","type":"User","site_admin":false},"repo":{"id":34986469,"name":"ember-cli-page-object","full_name":"san650/ember-cli-page-object","owner":{"login":"san650","id":1234607,"avatar_url":"https://avatars.githubusercontent.com/u/1234607?v=3","gravatar_id":"","url":"https://api.github.com/users/san650","html_url":"https://github.com/san650","followers_url":"https://api.github.com/users/san650/followers","following_url":"https://api.github.com/users/san650/following{/other_user}","gists_url":"https://api.github.com/users/san650/gists{/gist_id}","starred_url":"https://api.github.com/users/san650/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/san650/subscriptions","organizations_url":"https://api.github.com/users/san650/orgs","repos_url":"https://api.github.com/users/san650/repos","events_url":"https://api.github.com/users/san650/events{/privacy}","received_events_url":"https://api.github.com/users/san650/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/san650/ember-cli-page-object","description":"Represent the screens of your web app as a series of objects. This ember-cli addon eases the construction of these objects on your acceptance tests.","fork":false,"url":"https://api.github.com/repos/san650/ember-cli-page-object","forks_url":"https://api.github.com/repos/san650/ember-cli-page-object/forks","keys_url":"https://api.github.com/repos/san650/ember-cli-page-object/keys{/key_id}","collaborators_url":"https://api.github.com/repos/san650/ember-cli-page-object/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/san650/ember-cli-page-object/teams","hooks_url":"https://api.github.com/repos/san650/ember-cli-page-object/hooks","issue_events_url":"https://api.github.com/repos/san650/ember-cli-page-object/issues/events{/number}","events_url":"https://api.github.com/repos/san650/ember-cli-page-object/events","assignees_url":"https://api.github.com/repos/san650/ember-cli-page-object/assignees{/user}","branches_url":"https://api.github.com/repos/san650/ember-cli-page-object/branches{/branch}","tags_url":"https://api.github.com/repos/san650/ember-cli-page-object/tags","blobs_url":"https://api.github.com/repos/san650/ember-cli-page-object/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/san650/ember-cli-page-object/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/san650/ember-cli-page-object/git/refs{/sha}","trees_url":"https://api.github.com/repos/san650/ember-cli-page-object/git/trees{/sha}","statuses_url":"https://api.github.com/repos/san650/ember-cli-page-object/statuses/{sha}","languages_url":"https://api.github.com/repos/san650/ember-cli-page-object/languages","stargazers_url":"https://api.github.com/repos/san650/ember-cli-page-object/stargazers","contributors_url":"https://api.github.com/repos/san650/ember-cli-page-object/contributors","subscribers_url":"https://api.github.com/repos/san650/ember-cli-page-object/subscribers","subscription_url":"https://api.github.com/repos/san650/ember-cli-page-object/subscription","commits_url":"https://api.github.com/repos/san650/ember-cli-page-object/commits{/sha}","git_commits_url":"https://api.github.com/repos/san650/ember-cli-page-object/git/commits{/sha}","comments_url":"https://api.github.com/repos/san650/ember-cli-page-object/comments{/number}","issue_comment_url":"https://api.github.com/repos/san650/ember-cli-page-object/issues/comments{/number}","contents_url":"https://api.github.com/repos/san650/ember-cli-page-object/contents/{+path}","compare_url":"https://api.github.com/repos/san650/ember-cli-page-object/compare/{base}...{head}","merges_url":"https://api.github.com/repos/san650/ember-cli-page-object/merges","archive_url":"https://api.github.com/repos/san650/ember-cli-page-object/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/san650/ember-cli-page-object/downloads","issues_url":"https://api.github.com/repos/san650/ember-cli-page-object/issues{/number}","pulls_url":"https://api.github.com/repos/san650/ember-cli-page-object/pulls{/number}","milestones_url":"https://api.github.com/repos/san650/ember-cli-page-object/milestones{/number}","notifications_url":"https://api.github.com/repos/san650/ember-cli-page-object/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/san650/ember-cli-page-object/labels{/name}","releases_url":"https://api.github.com/repos/san650/ember-cli-page-object/releases{/id}","deployments_url":"https://api.github.com/repos/san650/ember-cli-page-object/deployments","created_at":"2015-05-03T13:12:43Z","updated_at":"2016-04-18T11:04:22Z","pushed_at":"2016-04-18T23:36:24Z","git_url":"git://github.com/san650/ember-cli-page-object.git","ssh_url":"git@github.com:san650/ember-cli-page-object.git","clone_url":"https://github.com/san650/ember-cli-page-object.git","svn_url":"https://github.com/san650/ember-cli-page-object","homepage":"http://ember-cli-page-object.js.org/","size":1137,"stargazers_count":141,"watchers_count":141,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":32,"mirror_url":null,"open_issues_count":13,"forks":32,"open_issues":13,"watchers":141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/san650/ember-cli-page-object/pulls/164"},"html":{"href":"https://github.com/san650/ember-cli-page-object/pull/164"},"issue":{"href":"https://api.github.com/repos/san650/ember-cli-page-object/issues/164"},"comments":{"href":"https://api.github.com/repos/san650/ember-cli-page-object/issues/164/comments"},"review_comments":{"href":"https://api.github.com/repos/san650/ember-cli-page-object/pulls/164/comments"},"review_comment":{"href":"https://api.github.com/repos/san650/ember-cli-page-object/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/san650/ember-cli-page-object/pulls/164/commits"},"statuses":{"href":"https://api.github.com/repos/san650/ember-cli-page-object/statuses/07da427259402449deaa7dbf11442d3a4c6efb12"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"san650","id":1234607,"avatar_url":"https://avatars.githubusercontent.com/u/1234607?v=3","gravatar_id":"","url":"https://api.github.com/users/san650","html_url":"https://github.com/san650","followers_url":"https://api.github.com/users/san650/followers","following_url":"https://api.github.com/users/san650/following{/other_user}","gists_url":"https://api.github.com/users/san650/gists{/gist_id}","starred_url":"https://api.github.com/users/san650/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/san650/subscriptions","organizations_url":"https://api.github.com/users/san650/orgs","repos_url":"https://api.github.com/users/san650/repos","events_url":"https://api.github.com/users/san650/events{/privacy}","received_events_url":"https://api.github.com/users/san650/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":138,"deletions":6,"changed_files":3}}