{"action":"created","comment":{"url":"https://api.github.com/repos/projectatomic/adb-utils/pulls/comments/54215855","id":54215855,"diff_hunk":"@@ -68,7 +68,23 @@ function usage()\n \n function openshift()\n {\n+    # Default OpenShift Image and Tag\n+    dockerRegistry=${DOCKER_REGISTRY:-docker.io}\n+    imageName=${IMAGE_NAME:-openshift/origin}\n+    imageTag=${IMAGE_TAG:-v1.1.1}\n+\n     clean_setup\n+\n+    # Setup the systemd environment - desired image may have changed\n+    sudo sed -i.back \"/^IMAGE=*/cIMAGE=\\\"${imageName}\\:${imageTag}\\\"\" /etc/sysconfig/openshift_option\n+\n+    # ensure the docker containers are present\n+    docker pull ${dockerRegistry}/${imageName}:${imageTag}\n+    docker pull ${dockerRegistry}/${imageName}-haproxy-router:${imageTag}\n+    docker pull ${dockerRegistry}/${imageName}-deployer:${imageTag}\n+    docker pull ${dockerRegistry}/${imageName}-docker-registry:${imageTag}\n+    docker pull ${dockerRegistry}/${imageName}-sti-builder:${imageTag}\n+","path":"utils/sccli.sh","position":20,"original_position":20,"commit_id":"c715fdd48238a245230ad59a55a00ef1f54a5eaf","original_commit_id":"63f69fc8b5993f7c49ef99f67df83bfe150595b1","user":{"login":"praveenkumar","id":410007,"avatar_url":"https://avatars.githubusercontent.com/u/410007?v=3","gravatar_id":"","url":"https://api.github.com/users/praveenkumar","html_url":"https://github.com/praveenkumar","followers_url":"https://api.github.com/users/praveenkumar/followers","following_url":"https://api.github.com/users/praveenkumar/following{/other_user}","gists_url":"https://api.github.com/users/praveenkumar/gists{/gist_id}","starred_url":"https://api.github.com/users/praveenkumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveenkumar/subscriptions","organizations_url":"https://api.github.com/users/praveenkumar/orgs","repos_url":"https://api.github.com/users/praveenkumar/repos","events_url":"https://api.github.com/users/praveenkumar/events{/privacy}","received_events_url":"https://api.github.com/users/praveenkumar/received_events","type":"User","site_admin":false},"body":"> Also we should error out if docker pulls are failures\r\n\r\nAgreed","created_at":"2016-02-26T08:32:19Z","updated_at":"2016-02-26T08:32:19Z","html_url":"https://github.com/projectatomic/adb-utils/pull/45#discussion_r54215855","pull_request_url":"https://api.github.com/repos/projectatomic/adb-utils/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/projectatomic/adb-utils/pulls/comments/54215855"},"html":{"href":"https://github.com/projectatomic/adb-utils/pull/45#discussion_r54215855"},"pull_request":{"href":"https://api.github.com/repos/projectatomic/adb-utils/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/projectatomic/adb-utils/pulls/45","id":60672383,"html_url":"https://github.com/projectatomic/adb-utils/pull/45","diff_url":"https://github.com/projectatomic/adb-utils/pull/45.diff","patch_url":"https://github.com/projectatomic/adb-utils/pull/45.patch","issue_url":"https://api.github.com/repos/projectatomic/adb-utils/issues/45","number":45,"state":"open","locked":false,"title":"image information easily changed, adds docker pull","user":{"login":"bexelbie","id":7413661,"avatar_url":"https://avatars.githubusercontent.com/u/7413661?v=3","gravatar_id":"","url":"https://api.github.com/users/bexelbie","html_url":"https://github.com/bexelbie","followers_url":"https://api.github.com/users/bexelbie/followers","following_url":"https://api.github.com/users/bexelbie/following{/other_user}","gists_url":"https://api.github.com/users/bexelbie/gists{/gist_id}","starred_url":"https://api.github.com/users/bexelbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bexelbie/subscriptions","organizations_url":"https://api.github.com/users/bexelbie/orgs","repos_url":"https://api.github.com/users/bexelbie/repos","events_url":"https://api.github.com/users/bexelbie/events{/privacy}","received_events_url":"https://api.github.com/users/bexelbie/received_events","type":"User","site_admin":false},"body":"This allows changes in the openshift image to be used to be passed from\r\nthe Vagrantfile into the box.\r\n\r\ndocker pull is now done in sccli to ensure images for requested version\r\nare present.\r\n\r\nUses IMAGE_* variables so that sccli can use similar code for future\r\nservices.  Also this represents that not all versions of OpenShift are\r\nnamed Origin.\r\n\r\nThere is a second PR that makes changes to the Vagrant file in the ADB","created_at":"2016-02-25T12:41:16Z","updated_at":"2016-02-26T08:32:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76bb6cb79b80f32ae94fa85fb8a15a806868e79f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projectatomic/adb-utils/pulls/45/commits","review_comments_url":"https://api.github.com/repos/projectatomic/adb-utils/pulls/45/comments","review_comment_url":"https://api.github.com/repos/projectatomic/adb-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectatomic/adb-utils/issues/45/comments","statuses_url":"https://api.github.com/repos/projectatomic/adb-utils/statuses/c715fdd48238a245230ad59a55a00ef1f54a5eaf","head":{"label":"bexelbie:bexelbie_pass_image_info","ref":"bexelbie_pass_image_info","sha":"c715fdd48238a245230ad59a55a00ef1f54a5eaf","user":{"login":"bexelbie","id":7413661,"avatar_url":"https://avatars.githubusercontent.com/u/7413661?v=3","gravatar_id":"","url":"https://api.github.com/users/bexelbie","html_url":"https://github.com/bexelbie","followers_url":"https://api.github.com/users/bexelbie/followers","following_url":"https://api.github.com/users/bexelbie/following{/other_user}","gists_url":"https://api.github.com/users/bexelbie/gists{/gist_id}","starred_url":"https://api.github.com/users/bexelbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bexelbie/subscriptions","organizations_url":"https://api.github.com/users/bexelbie/orgs","repos_url":"https://api.github.com/users/bexelbie/repos","events_url":"https://api.github.com/users/bexelbie/events{/privacy}","received_events_url":"https://api.github.com/users/bexelbie/received_events","type":"User","site_admin":false},"repo":{"id":50718106,"name":"adb-utils","full_name":"bexelbie/adb-utils","owner":{"login":"bexelbie","id":7413661,"avatar_url":"https://avatars.githubusercontent.com/u/7413661?v=3","gravatar_id":"","url":"https://api.github.com/users/bexelbie","html_url":"https://github.com/bexelbie","followers_url":"https://api.github.com/users/bexelbie/followers","following_url":"https://api.github.com/users/bexelbie/following{/other_user}","gists_url":"https://api.github.com/users/bexelbie/gists{/gist_id}","starred_url":"https://api.github.com/users/bexelbie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bexelbie/subscriptions","organizations_url":"https://api.github.com/users/bexelbie/orgs","repos_url":"https://api.github.com/users/bexelbie/repos","events_url":"https://api.github.com/users/bexelbie/events{/privacy}","received_events_url":"https://api.github.com/users/bexelbie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bexelbie/adb-utils","description":"","fork":true,"url":"https://api.github.com/repos/bexelbie/adb-utils","forks_url":"https://api.github.com/repos/bexelbie/adb-utils/forks","keys_url":"https://api.github.com/repos/bexelbie/adb-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bexelbie/adb-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bexelbie/adb-utils/teams","hooks_url":"https://api.github.com/repos/bexelbie/adb-utils/hooks","issue_events_url":"https://api.github.com/repos/bexelbie/adb-utils/issues/events{/number}","events_url":"https://api.github.com/repos/bexelbie/adb-utils/events","assignees_url":"https://api.github.com/repos/bexelbie/adb-utils/assignees{/user}","branches_url":"https://api.github.com/repos/bexelbie/adb-utils/branches{/branch}","tags_url":"https://api.github.com/repos/bexelbie/adb-utils/tags","blobs_url":"https://api.github.com/repos/bexelbie/adb-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bexelbie/adb-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bexelbie/adb-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/bexelbie/adb-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bexelbie/adb-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/bexelbie/adb-utils/languages","stargazers_url":"https://api.github.com/repos/bexelbie/adb-utils/stargazers","contributors_url":"https://api.github.com/repos/bexelbie/adb-utils/contributors","subscribers_url":"https://api.github.com/repos/bexelbie/adb-utils/subscribers","subscription_url":"https://api.github.com/repos/bexelbie/adb-utils/subscription","commits_url":"https://api.github.com/repos/bexelbie/adb-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/bexelbie/adb-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/bexelbie/adb-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/bexelbie/adb-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/bexelbie/adb-utils/contents/{+path}","compare_url":"https://api.github.com/repos/bexelbie/adb-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bexelbie/adb-utils/merges","archive_url":"https://api.github.com/repos/bexelbie/adb-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bexelbie/adb-utils/downloads","issues_url":"https://api.github.com/repos/bexelbie/adb-utils/issues{/number}","pulls_url":"https://api.github.com/repos/bexelbie/adb-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/bexelbie/adb-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/bexelbie/adb-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bexelbie/adb-utils/labels{/name}","releases_url":"https://api.github.com/repos/bexelbie/adb-utils/releases{/id}","deployments_url":"https://api.github.com/repos/bexelbie/adb-utils/deployments","created_at":"2016-01-30T09:23:16Z","updated_at":"2016-01-30T09:23:17Z","pushed_at":"2016-02-26T07:16:52Z","git_url":"git://github.com/bexelbie/adb-utils.git","ssh_url":"git@github.com:bexelbie/adb-utils.git","clone_url":"https://github.com/bexelbie/adb-utils.git","svn_url":"https://github.com/bexelbie/adb-utils","homepage":null,"size":29,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectatomic:master","ref":"master","sha":"135e9fe4d1c1da0eb339a93a3d9febc9be8158b5","user":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":50361088,"name":"adb-utils","full_name":"projectatomic/adb-utils","owner":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectatomic/adb-utils","description":"","fork":false,"url":"https://api.github.com/repos/projectatomic/adb-utils","forks_url":"https://api.github.com/repos/projectatomic/adb-utils/forks","keys_url":"https://api.github.com/repos/projectatomic/adb-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectatomic/adb-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectatomic/adb-utils/teams","hooks_url":"https://api.github.com/repos/projectatomic/adb-utils/hooks","issue_events_url":"https://api.github.com/repos/projectatomic/adb-utils/issues/events{/number}","events_url":"https://api.github.com/repos/projectatomic/adb-utils/events","assignees_url":"https://api.github.com/repos/projectatomic/adb-utils/assignees{/user}","branches_url":"https://api.github.com/repos/projectatomic/adb-utils/branches{/branch}","tags_url":"https://api.github.com/repos/projectatomic/adb-utils/tags","blobs_url":"https://api.github.com/repos/projectatomic/adb-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectatomic/adb-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectatomic/adb-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectatomic/adb-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectatomic/adb-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/projectatomic/adb-utils/languages","stargazers_url":"https://api.github.com/repos/projectatomic/adb-utils/stargazers","contributors_url":"https://api.github.com/repos/projectatomic/adb-utils/contributors","subscribers_url":"https://api.github.com/repos/projectatomic/adb-utils/subscribers","subscription_url":"https://api.github.com/repos/projectatomic/adb-utils/subscription","commits_url":"https://api.github.com/repos/projectatomic/adb-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectatomic/adb-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectatomic/adb-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectatomic/adb-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectatomic/adb-utils/contents/{+path}","compare_url":"https://api.github.com/repos/projectatomic/adb-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectatomic/adb-utils/merges","archive_url":"https://api.github.com/repos/projectatomic/adb-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectatomic/adb-utils/downloads","issues_url":"https://api.github.com/repos/projectatomic/adb-utils/issues{/number}","pulls_url":"https://api.github.com/repos/projectatomic/adb-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/projectatomic/adb-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/projectatomic/adb-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectatomic/adb-utils/labels{/name}","releases_url":"https://api.github.com/repos/projectatomic/adb-utils/releases{/id}","deployments_url":"https://api.github.com/repos/projectatomic/adb-utils/deployments","created_at":"2016-01-25T15:45:07Z","updated_at":"2016-02-25T16:02:47Z","pushed_at":"2016-02-26T07:16:52Z","git_url":"git://github.com/projectatomic/adb-utils.git","ssh_url":"git@github.com:projectatomic/adb-utils.git","clone_url":"https://github.com/projectatomic/adb-utils.git","svn_url":"https://github.com/projectatomic/adb-utils","homepage":null,"size":30,"stargazers_count":3,"watchers_count":3,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":17,"forks":5,"open_issues":17,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectatomic/adb-utils/pulls/45"},"html":{"href":"https://github.com/projectatomic/adb-utils/pull/45"},"issue":{"href":"https://api.github.com/repos/projectatomic/adb-utils/issues/45"},"comments":{"href":"https://api.github.com/repos/projectatomic/adb-utils/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/projectatomic/adb-utils/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/projectatomic/adb-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectatomic/adb-utils/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/projectatomic/adb-utils/statuses/c715fdd48238a245230ad59a55a00ef1f54a5eaf"}}}}