{"action":"created","comment":{"url":"https://api.github.com/repos/HOST-Oman/scribus/pulls/comments/61337751","id":61337751,"diff_hunk":"@@ -110,3 +110,7 @@ void AlignSelect::languageChange()\n \tTextB->setToolTip( tr(\"Align Text Justified\"));\n \tTextF->setToolTip( tr(\"Align Text Forced Justified\"));\n }\n+void AlignSelect::changeIcon(QToolButton* button, QString iconName)\n+{\n+\tbutton->setIcon(IconManager::instance()->loadIcon(iconName));","path":"scribus/ui/alignselect.cpp","position":6,"original_position":6,"commit_id":"8fa7d73393fd49ee42de155debed070e2b63780a","original_commit_id":"8fa7d73393fd49ee42de155debed070e2b63780a","user":{"login":"khaledhosny","id":93914,"avatar_url":"https://avatars.githubusercontent.com/u/93914?v=3","gravatar_id":"","url":"https://api.github.com/users/khaledhosny","html_url":"https://github.com/khaledhosny","followers_url":"https://api.github.com/users/khaledhosny/followers","following_url":"https://api.github.com/users/khaledhosny/following{/other_user}","gists_url":"https://api.github.com/users/khaledhosny/gists{/gist_id}","starred_url":"https://api.github.com/users/khaledhosny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khaledhosny/subscriptions","organizations_url":"https://api.github.com/users/khaledhosny/orgs","repos_url":"https://api.github.com/users/khaledhosny/repos","events_url":"https://api.github.com/users/khaledhosny/events{/privacy}","received_events_url":"https://api.github.com/users/khaledhosny/received_events","type":"User","site_admin":false},"body":"Since this one line function is called only twice, why don’t you just call this line directly?","created_at":"2016-04-27T21:15:57Z","updated_at":"2016-04-27T21:15:58Z","html_url":"https://github.com/HOST-Oman/scribus/pull/168#discussion_r61337751","pull_request_url":"https://api.github.com/repos/HOST-Oman/scribus/pulls/168","_links":{"self":{"href":"https://api.github.com/repos/HOST-Oman/scribus/pulls/comments/61337751"},"html":{"href":"https://github.com/HOST-Oman/scribus/pull/168#discussion_r61337751"},"pull_request":{"href":"https://api.github.com/repos/HOST-Oman/scribus/pulls/168"}}},"pull_request":{"url":"https://api.github.com/repos/HOST-Oman/scribus/pulls/168","id":68032828,"html_url":"https://github.com/HOST-Oman/scribus/pull/168","diff_url":"https://github.com/HOST-Oman/scribus/pull/168.diff","patch_url":"https://github.com/HOST-Oman/scribus/pull/168.patch","issue_url":"https://api.github.com/repos/HOST-Oman/scribus/issues/168","number":168,"state":"open","locked":false,"title":"add format-justify-fill-block-right icon","user":{"login":"Fahad-Alsaidi","id":1632566,"avatar_url":"https://avatars.githubusercontent.com/u/1632566?v=3","gravatar_id":"","url":"https://api.github.com/users/Fahad-Alsaidi","html_url":"https://github.com/Fahad-Alsaidi","followers_url":"https://api.github.com/users/Fahad-Alsaidi/followers","following_url":"https://api.github.com/users/Fahad-Alsaidi/following{/other_user}","gists_url":"https://api.github.com/users/Fahad-Alsaidi/gists{/gist_id}","starred_url":"https://api.github.com/users/Fahad-Alsaidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fahad-Alsaidi/subscriptions","organizations_url":"https://api.github.com/users/Fahad-Alsaidi/orgs","repos_url":"https://api.github.com/users/Fahad-Alsaidi/repos","events_url":"https://api.github.com/users/Fahad-Alsaidi/events{/privacy}","received_events_url":"https://api.github.com/users/Fahad-Alsaidi/received_events","type":"User","site_admin":false},"body":"This to fix #161 by adding format-justify-fill-block-right icon and\r\nenable it when RTL icon clicked.","created_at":"2016-04-27T10:48:08Z","updated_at":"2016-04-27T21:15:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1639f4dccf2edaff3c9cacd07825bf9a03e9df3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HOST-Oman/scribus/pulls/168/commits","review_comments_url":"https://api.github.com/repos/HOST-Oman/scribus/pulls/168/comments","review_comment_url":"https://api.github.com/repos/HOST-Oman/scribus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HOST-Oman/scribus/issues/168/comments","statuses_url":"https://api.github.com/repos/HOST-Oman/scribus/statuses/8fa7d73393fd49ee42de155debed070e2b63780a","head":{"label":"Fahad-Alsaidi:jusitifuiedicon","ref":"jusitifuiedicon","sha":"8fa7d73393fd49ee42de155debed070e2b63780a","user":{"login":"Fahad-Alsaidi","id":1632566,"avatar_url":"https://avatars.githubusercontent.com/u/1632566?v=3","gravatar_id":"","url":"https://api.github.com/users/Fahad-Alsaidi","html_url":"https://github.com/Fahad-Alsaidi","followers_url":"https://api.github.com/users/Fahad-Alsaidi/followers","following_url":"https://api.github.com/users/Fahad-Alsaidi/following{/other_user}","gists_url":"https://api.github.com/users/Fahad-Alsaidi/gists{/gist_id}","starred_url":"https://api.github.com/users/Fahad-Alsaidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fahad-Alsaidi/subscriptions","organizations_url":"https://api.github.com/users/Fahad-Alsaidi/orgs","repos_url":"https://api.github.com/users/Fahad-Alsaidi/repos","events_url":"https://api.github.com/users/Fahad-Alsaidi/events{/privacy}","received_events_url":"https://api.github.com/users/Fahad-Alsaidi/received_events","type":"User","site_admin":false},"repo":{"id":54864217,"name":"scribus","full_name":"Fahad-Alsaidi/scribus","owner":{"login":"Fahad-Alsaidi","id":1632566,"avatar_url":"https://avatars.githubusercontent.com/u/1632566?v=3","gravatar_id":"","url":"https://api.github.com/users/Fahad-Alsaidi","html_url":"https://github.com/Fahad-Alsaidi","followers_url":"https://api.github.com/users/Fahad-Alsaidi/followers","following_url":"https://api.github.com/users/Fahad-Alsaidi/following{/other_user}","gists_url":"https://api.github.com/users/Fahad-Alsaidi/gists{/gist_id}","starred_url":"https://api.github.com/users/Fahad-Alsaidi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fahad-Alsaidi/subscriptions","organizations_url":"https://api.github.com/users/Fahad-Alsaidi/orgs","repos_url":"https://api.github.com/users/Fahad-Alsaidi/repos","events_url":"https://api.github.com/users/Fahad-Alsaidi/events{/privacy}","received_events_url":"https://api.github.com/users/Fahad-Alsaidi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fahad-Alsaidi/scribus","description":"Mirror of official Scribus SVN (http://bugs.scribus.net ← Submit PRs & Bugs)","fork":true,"url":"https://api.github.com/repos/Fahad-Alsaidi/scribus","forks_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/forks","keys_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/teams","hooks_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/hooks","issue_events_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/issues/events{/number}","events_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/events","assignees_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/assignees{/user}","branches_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/branches{/branch}","tags_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/tags","blobs_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/statuses/{sha}","languages_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/languages","stargazers_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/stargazers","contributors_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/contributors","subscribers_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/subscribers","subscription_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/subscription","commits_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/contents/{+path}","compare_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/merges","archive_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/downloads","issues_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/issues{/number}","pulls_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/pulls{/number}","milestones_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/milestones{/number}","notifications_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/labels{/name}","releases_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/releases{/id}","deployments_url":"https://api.github.com/repos/Fahad-Alsaidi/scribus/deployments","created_at":"2016-03-28T03:58:38Z","updated_at":"2016-03-28T03:58:48Z","pushed_at":"2016-04-27T10:47:16Z","git_url":"git://github.com/Fahad-Alsaidi/scribus.git","ssh_url":"git@github.com:Fahad-Alsaidi/scribus.git","clone_url":"https://github.com/Fahad-Alsaidi/scribus.git","svn_url":"https://github.com/Fahad-Alsaidi/scribus","homepage":"http://scribus.io","size":438688,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HOST-Oman:ctl","ref":"ctl","sha":"9fa2c569a76700cb0b7323bc835901a40bad3762","user":{"login":"HOST-Oman","id":16079338,"avatar_url":"https://avatars.githubusercontent.com/u/16079338?v=3","gravatar_id":"","url":"https://api.github.com/users/HOST-Oman","html_url":"https://github.com/HOST-Oman","followers_url":"https://api.github.com/users/HOST-Oman/followers","following_url":"https://api.github.com/users/HOST-Oman/following{/other_user}","gists_url":"https://api.github.com/users/HOST-Oman/gists{/gist_id}","starred_url":"https://api.github.com/users/HOST-Oman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HOST-Oman/subscriptions","organizations_url":"https://api.github.com/users/HOST-Oman/orgs","repos_url":"https://api.github.com/users/HOST-Oman/repos","events_url":"https://api.github.com/users/HOST-Oman/events{/privacy}","received_events_url":"https://api.github.com/users/HOST-Oman/received_events","type":"Organization","site_admin":false},"repo":{"id":52158961,"name":"scribus","full_name":"HOST-Oman/scribus","owner":{"login":"HOST-Oman","id":16079338,"avatar_url":"https://avatars.githubusercontent.com/u/16079338?v=3","gravatar_id":"","url":"https://api.github.com/users/HOST-Oman","html_url":"https://github.com/HOST-Oman","followers_url":"https://api.github.com/users/HOST-Oman/followers","following_url":"https://api.github.com/users/HOST-Oman/following{/other_user}","gists_url":"https://api.github.com/users/HOST-Oman/gists{/gist_id}","starred_url":"https://api.github.com/users/HOST-Oman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HOST-Oman/subscriptions","organizations_url":"https://api.github.com/users/HOST-Oman/orgs","repos_url":"https://api.github.com/users/HOST-Oman/repos","events_url":"https://api.github.com/users/HOST-Oman/events{/privacy}","received_events_url":"https://api.github.com/users/HOST-Oman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HOST-Oman/scribus","description":"Mirror of official Scribus SVN (http://bugs.scribus.net ← Submit PRs & Bugs)","fork":true,"url":"https://api.github.com/repos/HOST-Oman/scribus","forks_url":"https://api.github.com/repos/HOST-Oman/scribus/forks","keys_url":"https://api.github.com/repos/HOST-Oman/scribus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HOST-Oman/scribus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HOST-Oman/scribus/teams","hooks_url":"https://api.github.com/repos/HOST-Oman/scribus/hooks","issue_events_url":"https://api.github.com/repos/HOST-Oman/scribus/issues/events{/number}","events_url":"https://api.github.com/repos/HOST-Oman/scribus/events","assignees_url":"https://api.github.com/repos/HOST-Oman/scribus/assignees{/user}","branches_url":"https://api.github.com/repos/HOST-Oman/scribus/branches{/branch}","tags_url":"https://api.github.com/repos/HOST-Oman/scribus/tags","blobs_url":"https://api.github.com/repos/HOST-Oman/scribus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HOST-Oman/scribus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HOST-Oman/scribus/git/refs{/sha}","trees_url":"https://api.github.com/repos/HOST-Oman/scribus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HOST-Oman/scribus/statuses/{sha}","languages_url":"https://api.github.com/repos/HOST-Oman/scribus/languages","stargazers_url":"https://api.github.com/repos/HOST-Oman/scribus/stargazers","contributors_url":"https://api.github.com/repos/HOST-Oman/scribus/contributors","subscribers_url":"https://api.github.com/repos/HOST-Oman/scribus/subscribers","subscription_url":"https://api.github.com/repos/HOST-Oman/scribus/subscription","commits_url":"https://api.github.com/repos/HOST-Oman/scribus/commits{/sha}","git_commits_url":"https://api.github.com/repos/HOST-Oman/scribus/git/commits{/sha}","comments_url":"https://api.github.com/repos/HOST-Oman/scribus/comments{/number}","issue_comment_url":"https://api.github.com/repos/HOST-Oman/scribus/issues/comments{/number}","contents_url":"https://api.github.com/repos/HOST-Oman/scribus/contents/{+path}","compare_url":"https://api.github.com/repos/HOST-Oman/scribus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HOST-Oman/scribus/merges","archive_url":"https://api.github.com/repos/HOST-Oman/scribus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HOST-Oman/scribus/downloads","issues_url":"https://api.github.com/repos/HOST-Oman/scribus/issues{/number}","pulls_url":"https://api.github.com/repos/HOST-Oman/scribus/pulls{/number}","milestones_url":"https://api.github.com/repos/HOST-Oman/scribus/milestones{/number}","notifications_url":"https://api.github.com/repos/HOST-Oman/scribus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HOST-Oman/scribus/labels{/name}","releases_url":"https://api.github.com/repos/HOST-Oman/scribus/releases{/id}","deployments_url":"https://api.github.com/repos/HOST-Oman/scribus/deployments","created_at":"2016-02-20T15:05:04Z","updated_at":"2016-04-27T08:51:14Z","pushed_at":"2016-04-27T10:48:08Z","git_url":"git://github.com/HOST-Oman/scribus.git","ssh_url":"git@github.com:HOST-Oman/scribus.git","clone_url":"https://github.com/HOST-Oman/scribus.git","svn_url":"https://github.com/HOST-Oman/scribus","homepage":"http://scribus.io","size":439282,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":18,"forks":8,"open_issues":18,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HOST-Oman/scribus/pulls/168"},"html":{"href":"https://github.com/HOST-Oman/scribus/pull/168"},"issue":{"href":"https://api.github.com/repos/HOST-Oman/scribus/issues/168"},"comments":{"href":"https://api.github.com/repos/HOST-Oman/scribus/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/HOST-Oman/scribus/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/HOST-Oman/scribus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HOST-Oman/scribus/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/HOST-Oman/scribus/statuses/8fa7d73393fd49ee42de155debed070e2b63780a"}}}}