{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/59563685","id":59563685,"diff_hunk":"@@ -1451,6 +1451,32 @@ def disk_release!(device, owner)\n     disk_release(device, owner) and save\n   end\n \n+  def verify_claimed_disks\n+    unreferenced_disks = Array.new\n+    crowbar_wall[:claimed_disks].each do |disk, _claim|\n+      path, device_name = disk.split(\"/\")[-2..-1]\n+\n+      unless disk =~ /^\\/dev\\/disk\\//\n+        unreferenced_disks.push(disk) if node[:block_device][device_name].nil?\n+        next\n+      end\n+\n+      unless disk.include?(\"cciss\")\n+        ex = \"!\"\n+        unreferenced_disks.push(disk) if node[:block_device][path<<ex<<device_name].nil?","path":"crowbar_framework/app/models/node_object.rb","position":16,"original_position":16,"commit_id":"637ff384ae105deb57ff1810f87d60235592415c","original_commit_id":"637ff384ae105deb57ff1810f87d60235592415c","user":{"login":"rhafer","id":373399,"avatar_url":"https://avatars.githubusercontent.com/u/373399?v=3","gravatar_id":"","url":"https://api.github.com/users/rhafer","html_url":"https://github.com/rhafer","followers_url":"https://api.github.com/users/rhafer/followers","following_url":"https://api.github.com/users/rhafer/following{/other_user}","gists_url":"https://api.github.com/users/rhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhafer/subscriptions","organizations_url":"https://api.github.com/users/rhafer/orgs","repos_url":"https://api.github.com/users/rhafer/repos","events_url":"https://api.github.com/users/rhafer/events{/privacy}","received_events_url":"https://api.github.com/users/rhafer/received_events","type":"User","site_admin":false},"body":"I think I'd prefer ```.... node[:block_device][\"#{path}!#{device_name}\"].nil?```","created_at":"2016-04-13T14:57:34Z","updated_at":"2016-04-13T14:57:34Z","html_url":"https://github.com/crowbar/crowbar-core/pull/446#discussion_r59563685","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/446","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/59563685"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/446#discussion_r59563685"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/446"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/446","id":64064676,"html_url":"https://github.com/crowbar/crowbar-core/pull/446","diff_url":"https://github.com/crowbar/crowbar-core/pull/446.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/446.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/446","number":446,"state":"open","locked":false,"title":"Checks disk claims after upgrade","user":{"login":"sayalilunkad","id":2324148,"avatar_url":"https://avatars.githubusercontent.com/u/2324148?v=3","gravatar_id":"","url":"https://api.github.com/users/sayalilunkad","html_url":"https://github.com/sayalilunkad","followers_url":"https://api.github.com/users/sayalilunkad/followers","following_url":"https://api.github.com/users/sayalilunkad/following{/other_user}","gists_url":"https://api.github.com/users/sayalilunkad/gists{/gist_id}","starred_url":"https://api.github.com/users/sayalilunkad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayalilunkad/subscriptions","organizations_url":"https://api.github.com/users/sayalilunkad/orgs","repos_url":"https://api.github.com/users/sayalilunkad/repos","events_url":"https://api.github.com/users/sayalilunkad/events{/privacy}","received_events_url":"https://api.github.com/users/sayalilunkad/received_events","type":"User","site_admin":false},"body":"Checks existing disk claims against disks in ohai data and\r\nreturns list of unclaimed disks.\r\n\r\nCo-Authored-By: Rick Salevsky <rsalevsky@suse.com>","created_at":"2016-03-24T16:55:28Z","updated_at":"2016-04-13T14:57:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c8076600bf097cad4c5f113c69cc155fb276248","assignee":{"login":"rhafer","id":373399,"avatar_url":"https://avatars.githubusercontent.com/u/373399?v=3","gravatar_id":"","url":"https://api.github.com/users/rhafer","html_url":"https://github.com/rhafer","followers_url":"https://api.github.com/users/rhafer/followers","following_url":"https://api.github.com/users/rhafer/following{/other_user}","gists_url":"https://api.github.com/users/rhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhafer/subscriptions","organizations_url":"https://api.github.com/users/rhafer/orgs","repos_url":"https://api.github.com/users/rhafer/repos","events_url":"https://api.github.com/users/rhafer/events{/privacy}","received_events_url":"https://api.github.com/users/rhafer/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/446/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/446/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/446/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/637ff384ae105deb57ff1810f87d60235592415c","head":{"label":"sayalilunkad:disks","ref":"disks","sha":"637ff384ae105deb57ff1810f87d60235592415c","user":{"login":"sayalilunkad","id":2324148,"avatar_url":"https://avatars.githubusercontent.com/u/2324148?v=3","gravatar_id":"","url":"https://api.github.com/users/sayalilunkad","html_url":"https://github.com/sayalilunkad","followers_url":"https://api.github.com/users/sayalilunkad/followers","following_url":"https://api.github.com/users/sayalilunkad/following{/other_user}","gists_url":"https://api.github.com/users/sayalilunkad/gists{/gist_id}","starred_url":"https://api.github.com/users/sayalilunkad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayalilunkad/subscriptions","organizations_url":"https://api.github.com/users/sayalilunkad/orgs","repos_url":"https://api.github.com/users/sayalilunkad/repos","events_url":"https://api.github.com/users/sayalilunkad/events{/privacy}","received_events_url":"https://api.github.com/users/sayalilunkad/received_events","type":"User","site_admin":false},"repo":{"id":50849551,"name":"crowbar-core","full_name":"sayalilunkad/crowbar-core","owner":{"login":"sayalilunkad","id":2324148,"avatar_url":"https://avatars.githubusercontent.com/u/2324148?v=3","gravatar_id":"","url":"https://api.github.com/users/sayalilunkad","html_url":"https://github.com/sayalilunkad","followers_url":"https://api.github.com/users/sayalilunkad/followers","following_url":"https://api.github.com/users/sayalilunkad/following{/other_user}","gists_url":"https://api.github.com/users/sayalilunkad/gists{/gist_id}","starred_url":"https://api.github.com/users/sayalilunkad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sayalilunkad/subscriptions","organizations_url":"https://api.github.com/users/sayalilunkad/orgs","repos_url":"https://api.github.com/users/sayalilunkad/repos","events_url":"https://api.github.com/users/sayalilunkad/events{/privacy}","received_events_url":"https://api.github.com/users/sayalilunkad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sayalilunkad/crowbar-core","description":"Core deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/sayalilunkad/crowbar-core","forks_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/forks","keys_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/teams","hooks_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/events","assignees_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/tags","blobs_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/subscription","commits_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/merges","archive_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/downloads","issues_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/sayalilunkad/crowbar-core/deployments","created_at":"2016-02-01T15:42:44Z","updated_at":"2016-02-01T15:42:46Z","pushed_at":"2016-04-13T14:42:48Z","git_url":"git://github.com/sayalilunkad/crowbar-core.git","ssh_url":"git@github.com:sayalilunkad/crowbar-core.git","clone_url":"https://github.com/sayalilunkad/crowbar-core.git","svn_url":"https://github.com/sayalilunkad/crowbar-core","homepage":null,"size":104597,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"66abce35fc123352aef21d3b7510015c99d7307d","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39003227,"name":"crowbar-core","full_name":"crowbar/crowbar-core","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-core","description":"Core deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-core","forks_url":"https://api.github.com/repos/crowbar/crowbar-core/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-core/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-core/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-core/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-core/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-core/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-core/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-core/deployments","created_at":"2015-07-13T09:31:28Z","updated_at":"2016-04-10T12:47:20Z","pushed_at":"2016-04-13T14:42:48Z","git_url":"git://github.com/crowbar/crowbar-core.git","ssh_url":"git@github.com:crowbar/crowbar-core.git","clone_url":"https://github.com/crowbar/crowbar-core.git","svn_url":"https://github.com/crowbar/crowbar-core","homepage":null,"size":120374,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":33,"forks":23,"open_issues":33,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/446"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/446"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/446"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/446/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/446/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/446/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-core/statuses/637ff384ae105deb57ff1810f87d60235592415c"}}}}