{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/94233399","pull_request_review_id":14764412,"id":94233399,"diff_hunk":"@@ -18,10 +18,82 @@ ConfigureGraphics::ConfigureGraphics(QWidget* parent)\n \n ConfigureGraphics::~ConfigureGraphics() {}\n \n+enum class Resolution : int {\n+    Auto,\n+    Scale1x,\n+    Scale1_5x,\n+    Scale2x,\n+    Scale2_5x,\n+    Scale3x,\n+    Scale4x,\n+    Scale5x,\n+    Scale6x,\n+    Scale7x,\n+    Scale8x,\n+};\n+\n+float ToResolutionFactor(Resolution option) {\n+    switch (option) {\n+    case Resolution::Auto:\n+        return 0.0;\n+    case Resolution::Scale1x:\n+        return 1.0;\n+    case Resolution::Scale1_5x:\n+        return 1.5;\n+    case Resolution::Scale2x:\n+        return 2.0;\n+    case Resolution::Scale2_5x:\n+        return 2.5;\n+    case Resolution::Scale3x:\n+        return 3.0;\n+    case Resolution::Scale4x:\n+        return 4.0;\n+    case Resolution::Scale5x:\n+        return 5.0;\n+    case Resolution::Scale6x:\n+        return 6.0;\n+    case Resolution::Scale7x:\n+        return 7.0;\n+    case Resolution::Scale8x:\n+        return 8.0;\n+    }\n+    return 0.0;\n+}\n+\n+Resolution FromResolutionFactor(float factor) {","path":"src/citra_qt/configure_graphics.cpp","position":46,"original_position":46,"commit_id":"00b2f23e70bc79b2e4fa9aff3444a46d9a1baba2","original_commit_id":"00b2f23e70bc79b2e4fa9aff3444a46d9a1baba2","user":{"login":"Subv","id":357072,"avatar_url":"https://avatars.githubusercontent.com/u/357072?v=3","gravatar_id":"","url":"https://api.github.com/users/Subv","html_url":"https://github.com/Subv","followers_url":"https://api.github.com/users/Subv/followers","following_url":"https://api.github.com/users/Subv/following{/other_user}","gists_url":"https://api.github.com/users/Subv/gists{/gist_id}","starred_url":"https://api.github.com/users/Subv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subv/subscriptions","organizations_url":"https://api.github.com/users/Subv/orgs","repos_url":"https://api.github.com/users/Subv/repos","events_url":"https://api.github.com/users/Subv/events{/privacy}","received_events_url":"https://api.github.com/users/Subv/received_events","type":"User","site_admin":false},"body":"Comparing floats to doubles, does that not generate a warning?","created_at":"2016-12-30T15:01:49Z","updated_at":"2016-12-30T15:03:13Z","html_url":"https://github.com/citra-emu/citra/pull/2384#discussion_r94233399","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/2384","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/94233399"},"html":{"href":"https://github.com/citra-emu/citra/pull/2384#discussion_r94233399"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/2384"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/2384","id":99721883,"html_url":"https://github.com/citra-emu/citra/pull/2384","diff_url":"https://github.com/citra-emu/citra/pull/2384.diff","patch_url":"https://github.com/citra-emu/citra/pull/2384.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/2384","number":2384,"state":"open","locked":false,"title":"config: Add option for specifying screen resolution scale factor.","user":{"login":"bunnei","id":6956688,"avatar_url":"https://avatars.githubusercontent.com/u/6956688?v=3","gravatar_id":"","url":"https://api.github.com/users/bunnei","html_url":"https://github.com/bunnei","followers_url":"https://api.github.com/users/bunnei/followers","following_url":"https://api.github.com/users/bunnei/following{/other_user}","gists_url":"https://api.github.com/users/bunnei/gists{/gist_id}","starred_url":"https://api.github.com/users/bunnei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bunnei/subscriptions","organizations_url":"https://api.github.com/users/bunnei/orgs","repos_url":"https://api.github.com/users/bunnei/repos","events_url":"https://api.github.com/users/bunnei/events{/privacy}","received_events_url":"https://api.github.com/users/bunnei/received_events","type":"User","site_admin":false},"body":"For those of us with hardware fast enough to upscale, but not fast enough to upscale to our native resolutions...\r\n\r\nObligatory UI change screenshot:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/6956688/21559733/85e4abbe-ce1f-11e6-92e1-201ad9e81c34.png)\r\n","created_at":"2016-12-30T04:36:11Z","updated_at":"2016-12-30T15:03:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"962bb010e45f209d0527e215e4ba938a41c8faed","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/2384/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/2384/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/2384/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/00b2f23e70bc79b2e4fa9aff3444a46d9a1baba2","head":{"label":"bunnei:internal-res-option","ref":"internal-res-option","sha":"00b2f23e70bc79b2e4fa9aff3444a46d9a1baba2","user":{"login":"bunnei","id":6956688,"avatar_url":"https://avatars.githubusercontent.com/u/6956688?v=3","gravatar_id":"","url":"https://api.github.com/users/bunnei","html_url":"https://github.com/bunnei","followers_url":"https://api.github.com/users/bunnei/followers","following_url":"https://api.github.com/users/bunnei/following{/other_user}","gists_url":"https://api.github.com/users/bunnei/gists{/gist_id}","starred_url":"https://api.github.com/users/bunnei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bunnei/subscriptions","organizations_url":"https://api.github.com/users/bunnei/orgs","repos_url":"https://api.github.com/users/bunnei/repos","events_url":"https://api.github.com/users/bunnei/events{/privacy}","received_events_url":"https://api.github.com/users/bunnei/received_events","type":"User","site_admin":false},"repo":{"id":19964905,"name":"citra","full_name":"bunnei/citra","owner":{"login":"bunnei","id":6956688,"avatar_url":"https://avatars.githubusercontent.com/u/6956688?v=3","gravatar_id":"","url":"https://api.github.com/users/bunnei","html_url":"https://github.com/bunnei","followers_url":"https://api.github.com/users/bunnei/followers","following_url":"https://api.github.com/users/bunnei/following{/other_user}","gists_url":"https://api.github.com/users/bunnei/gists{/gist_id}","starred_url":"https://api.github.com/users/bunnei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bunnei/subscriptions","organizations_url":"https://api.github.com/users/bunnei/orgs","repos_url":"https://api.github.com/users/bunnei/repos","events_url":"https://api.github.com/users/bunnei/events{/privacy}","received_events_url":"https://api.github.com/users/bunnei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bunnei/citra","description":"Nintendo 3DS emulator/debugger","fork":true,"url":"https://api.github.com/repos/bunnei/citra","forks_url":"https://api.github.com/repos/bunnei/citra/forks","keys_url":"https://api.github.com/repos/bunnei/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bunnei/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bunnei/citra/teams","hooks_url":"https://api.github.com/repos/bunnei/citra/hooks","issue_events_url":"https://api.github.com/repos/bunnei/citra/issues/events{/number}","events_url":"https://api.github.com/repos/bunnei/citra/events","assignees_url":"https://api.github.com/repos/bunnei/citra/assignees{/user}","branches_url":"https://api.github.com/repos/bunnei/citra/branches{/branch}","tags_url":"https://api.github.com/repos/bunnei/citra/tags","blobs_url":"https://api.github.com/repos/bunnei/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bunnei/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bunnei/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/bunnei/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bunnei/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/bunnei/citra/languages","stargazers_url":"https://api.github.com/repos/bunnei/citra/stargazers","contributors_url":"https://api.github.com/repos/bunnei/citra/contributors","subscribers_url":"https://api.github.com/repos/bunnei/citra/subscribers","subscription_url":"https://api.github.com/repos/bunnei/citra/subscription","commits_url":"https://api.github.com/repos/bunnei/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/bunnei/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/bunnei/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/bunnei/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/bunnei/citra/contents/{+path}","compare_url":"https://api.github.com/repos/bunnei/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bunnei/citra/merges","archive_url":"https://api.github.com/repos/bunnei/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bunnei/citra/downloads","issues_url":"https://api.github.com/repos/bunnei/citra/issues{/number}","pulls_url":"https://api.github.com/repos/bunnei/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/bunnei/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/bunnei/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bunnei/citra/labels{/name}","releases_url":"https://api.github.com/repos/bunnei/citra/releases{/id}","deployments_url":"https://api.github.com/repos/bunnei/citra/deployments","created_at":"2014-05-20T02:28:14Z","updated_at":"2016-11-18T19:26:59Z","pushed_at":"2016-12-30T05:35:55Z","git_url":"git://github.com/bunnei/citra.git","ssh_url":"git@github.com:bunnei/citra.git","clone_url":"https://github.com/bunnei/citra.git","svn_url":"https://github.com/bunnei/citra","homepage":null,"size":14805,"stargazers_count":60,"watchers_count":60,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":1,"forks":15,"open_issues":1,"watchers":60,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"f556d6ee90aae2d81cd9770c0b3259ac88ae8fe4","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS Emulator","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","deployments_url":"https://api.github.com/repos/citra-emu/citra/deployments","created_at":"2014-05-16T18:33:15Z","updated_at":"2016-12-30T09:37:48Z","pushed_at":"2016-12-30T14:56:00Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":"https://citra-emu.org","size":14870,"stargazers_count":2650,"watchers_count":2650,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":678,"mirror_url":null,"open_issues_count":212,"forks":678,"open_issues":212,"watchers":2650,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/2384"},"html":{"href":"https://github.com/citra-emu/citra/pull/2384"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/2384"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/2384/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/2384/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/2384/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/00b2f23e70bc79b2e4fa9aff3444a46d9a1baba2"}}}}
{"actor":{"display_login":"Subv"}}