{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/75036822","id":75036822,"diff_hunk":"@@ -423,34 +416,24 @@\n     <WriteItemsToJson JsonFileName=\"%(TestListFile.BuildCompleteJson)\" Items=\"@(BuildComplete)\" />\n   </Target>\n \n-  <!-- send completion events -->\n+  <!-- Send completion event.  All start messages are now sent to Helix API; Event Hub direct sending is now deprecated. -->\n   <Target Name=\"SendCompletionEvent\"\n           AfterTargets=\"WriteCompletionEvent\"\n           Inputs=\"%(TestListFile.BuildCompleteJson)\"\n           Outputs=\"%(TestListFile.HelixJobUploadCompletePath)\"\n           Condition=\"'$(SkipNotifyEvent)' != 'true'\">\n-    <SendToEventHub Condition=\"'$(HelixApiAccessKey)' == ''\"\n-      EventHubPath=\"$(EventHubPath)\"\n-      EventData=\"%(TestListFile.BuildCompleteJson)\"\n-      EventHubSharedAccessKeyName=\"$(EventHubSharedAccessKeyName)\"\n-      EventHubSharedAccessKey=\"$(EventHubSharedAccessKey)\"/>\n+    \n+    <Error Condition=\"'$(HelixApiAccessKey)' == ''\" Text=\"Please provide a value for the 'HelixApiAccessKey' property.\" />","path":"src/Microsoft.DotNet.Build.CloudTestTasks/PackageFiles/CloudTest.targets","position":44,"original_position":44,"commit_id":"09d13d876ac669266e4d8532739922a0d733c178","original_commit_id":"09d13d876ac669266e4d8532739922a0d733c178","user":{"login":"jhendrixMSFT","id":10090263,"avatar_url":"https://avatars.githubusercontent.com/u/10090263?v=3","gravatar_id":"","url":"https://api.github.com/users/jhendrixMSFT","html_url":"https://github.com/jhendrixMSFT","followers_url":"https://api.github.com/users/jhendrixMSFT/followers","following_url":"https://api.github.com/users/jhendrixMSFT/following{/other_user}","gists_url":"https://api.github.com/users/jhendrixMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/jhendrixMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhendrixMSFT/subscriptions","organizations_url":"https://api.github.com/users/jhendrixMSFT/orgs","repos_url":"https://api.github.com/users/jhendrixMSFT/repos","events_url":"https://api.github.com/users/jhendrixMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/jhendrixMSFT/received_events","type":"User","site_admin":false},"body":"Shouldn't this be up in the VerifyInputs target?","created_at":"2016-08-16T23:01:27Z","updated_at":"2016-08-16T23:01:27Z","html_url":"https://github.com/dotnet/buildtools/pull/959#discussion_r75036822","pull_request_url":"https://api.github.com/repos/dotnet/buildtools/pulls/959","_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/75036822"},"html":{"href":"https://github.com/dotnet/buildtools/pull/959#discussion_r75036822"},"pull_request":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/959"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/959","id":81559148,"html_url":"https://github.com/dotnet/buildtools/pull/959","diff_url":"https://github.com/dotnet/buildtools/pull/959.diff","patch_url":"https://github.com/dotnet/buildtools/pull/959.patch","issue_url":"https://api.github.com/repos/dotnet/buildtools/issues/959","number":959,"state":"open","locked":false,"title":"Remove SendToEventHub task and usage of it","user":{"login":"MattGal","id":7862010,"avatar_url":"https://avatars.githubusercontent.com/u/7862010?v=3","gravatar_id":"","url":"https://api.github.com/users/MattGal","html_url":"https://github.com/MattGal","followers_url":"https://api.github.com/users/MattGal/followers","following_url":"https://api.github.com/users/MattGal/following{/other_user}","gists_url":"https://api.github.com/users/MattGal/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGal/subscriptions","organizations_url":"https://api.github.com/users/MattGal/orgs","repos_url":"https://api.github.com/users/MattGal/repos","events_url":"https://api.github.com/users/MattGal/events{/privacy}","received_events_url":"https://api.github.com/users/MattGal/received_events","type":"User","site_admin":false},"body":"*Please do not merge: Still testing*\r\n\r\nThis change make attempted usage of the EventHub properties either a warning or error (depending on whether API Key is also provided).\r\n\r\nAt some point in the recent past, we've broken the ability to send jobs directly to EventHub, by leaving out properties such as Creator and Correlation Id from the runs.  These are filled in by the Helix API endpoints, and are the preferred way to do it.\r\n\r\nInstead of fixing this, it's better to fully obsolete them so that users will get feedback that it's now time to switch over.  This will not affect current runs for CoreFX, CoreCLR, or WCF.\r\n\r\n@karajas @ChadNedzlek @jhendrixMSFT ","created_at":"2016-08-16T22:58:34Z","updated_at":"2016-08-16T23:01:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51ebfcfecc5b4693369eefb3393b10caf28c18ae","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/buildtools/pulls/959/commits","review_comments_url":"https://api.github.com/repos/dotnet/buildtools/pulls/959/comments","review_comment_url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/buildtools/issues/959/comments","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/09d13d876ac669266e4d8532739922a0d733c178","head":{"label":"MattGal:Remove_EventHub","ref":"Remove_EventHub","sha":"09d13d876ac669266e4d8532739922a0d733c178","user":{"login":"MattGal","id":7862010,"avatar_url":"https://avatars.githubusercontent.com/u/7862010?v=3","gravatar_id":"","url":"https://api.github.com/users/MattGal","html_url":"https://github.com/MattGal","followers_url":"https://api.github.com/users/MattGal/followers","following_url":"https://api.github.com/users/MattGal/following{/other_user}","gists_url":"https://api.github.com/users/MattGal/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGal/subscriptions","organizations_url":"https://api.github.com/users/MattGal/orgs","repos_url":"https://api.github.com/users/MattGal/repos","events_url":"https://api.github.com/users/MattGal/events{/privacy}","received_events_url":"https://api.github.com/users/MattGal/received_events","type":"User","site_admin":false},"repo":{"id":53159521,"name":"buildtools","full_name":"MattGal/buildtools","owner":{"login":"MattGal","id":7862010,"avatar_url":"https://avatars.githubusercontent.com/u/7862010?v=3","gravatar_id":"","url":"https://api.github.com/users/MattGal","html_url":"https://github.com/MattGal","followers_url":"https://api.github.com/users/MattGal/followers","following_url":"https://api.github.com/users/MattGal/following{/other_user}","gists_url":"https://api.github.com/users/MattGal/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGal/subscriptions","organizations_url":"https://api.github.com/users/MattGal/orgs","repos_url":"https://api.github.com/users/MattGal/repos","events_url":"https://api.github.com/users/MattGal/events{/privacy}","received_events_url":"https://api.github.com/users/MattGal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MattGal/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":true,"url":"https://api.github.com/repos/MattGal/buildtools","forks_url":"https://api.github.com/repos/MattGal/buildtools/forks","keys_url":"https://api.github.com/repos/MattGal/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MattGal/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MattGal/buildtools/teams","hooks_url":"https://api.github.com/repos/MattGal/buildtools/hooks","issue_events_url":"https://api.github.com/repos/MattGal/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/MattGal/buildtools/events","assignees_url":"https://api.github.com/repos/MattGal/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/MattGal/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/MattGal/buildtools/tags","blobs_url":"https://api.github.com/repos/MattGal/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MattGal/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MattGal/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/MattGal/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MattGal/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/MattGal/buildtools/languages","stargazers_url":"https://api.github.com/repos/MattGal/buildtools/stargazers","contributors_url":"https://api.github.com/repos/MattGal/buildtools/contributors","subscribers_url":"https://api.github.com/repos/MattGal/buildtools/subscribers","subscription_url":"https://api.github.com/repos/MattGal/buildtools/subscription","commits_url":"https://api.github.com/repos/MattGal/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/MattGal/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/MattGal/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/MattGal/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/MattGal/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/MattGal/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MattGal/buildtools/merges","archive_url":"https://api.github.com/repos/MattGal/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MattGal/buildtools/downloads","issues_url":"https://api.github.com/repos/MattGal/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/MattGal/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/MattGal/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/MattGal/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MattGal/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/MattGal/buildtools/releases{/id}","deployments_url":"https://api.github.com/repos/MattGal/buildtools/deployments","created_at":"2016-03-04T19:15:10Z","updated_at":"2016-03-04T19:15:12Z","pushed_at":"2016-08-16T22:55:08Z","git_url":"git://github.com/MattGal/buildtools.git","ssh_url":"git@github.com:MattGal/buildtools.git","clone_url":"https://github.com/MattGal/buildtools.git","svn_url":"https://github.com/MattGal/buildtools","homepage":"","size":3660,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"08d47f093a314aa346709dc325cb0762f170ef7d","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295349,"name":"buildtools","full_name":"dotnet/buildtools","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":false,"url":"https://api.github.com/repos/dotnet/buildtools","forks_url":"https://api.github.com/repos/dotnet/buildtools/forks","keys_url":"https://api.github.com/repos/dotnet/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/buildtools/teams","hooks_url":"https://api.github.com/repos/dotnet/buildtools/hooks","issue_events_url":"https://api.github.com/repos/dotnet/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/buildtools/events","assignees_url":"https://api.github.com/repos/dotnet/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/buildtools/tags","blobs_url":"https://api.github.com/repos/dotnet/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/buildtools/languages","stargazers_url":"https://api.github.com/repos/dotnet/buildtools/stargazers","contributors_url":"https://api.github.com/repos/dotnet/buildtools/contributors","subscribers_url":"https://api.github.com/repos/dotnet/buildtools/subscribers","subscription_url":"https://api.github.com/repos/dotnet/buildtools/subscription","commits_url":"https://api.github.com/repos/dotnet/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/buildtools/merges","archive_url":"https://api.github.com/repos/dotnet/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/buildtools/downloads","issues_url":"https://api.github.com/repos/dotnet/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/buildtools/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/buildtools/deployments","created_at":"2014-11-06T23:43:05Z","updated_at":"2016-08-12T14:28:49Z","pushed_at":"2016-08-16T22:58:35Z","git_url":"git://github.com/dotnet/buildtools.git","ssh_url":"git@github.com:dotnet/buildtools.git","clone_url":"https://github.com/dotnet/buildtools.git","svn_url":"https://github.com/dotnet/buildtools","homepage":"","size":4817,"stargazers_count":421,"watchers_count":421,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":202,"mirror_url":null,"open_issues_count":100,"forks":202,"open_issues":100,"watchers":421,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/959"},"html":{"href":"https://github.com/dotnet/buildtools/pull/959"},"issue":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/959"},"comments":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/959/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/959/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/959/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/buildtools/statuses/09d13d876ac669266e4d8532739922a0d733c178"}}}}
{"actor":{"display_login":"jhendrixMSFT"}}