{"action":"created","issue":{"url":"https://api.github.com/repos/hmrc/self-assessment-api/issues/249","repository_url":"https://api.github.com/repos/hmrc/self-assessment-api","labels_url":"https://api.github.com/repos/hmrc/self-assessment-api/issues/249/labels{/name}","comments_url":"https://api.github.com/repos/hmrc/self-assessment-api/issues/249/comments","events_url":"https://api.github.com/repos/hmrc/self-assessment-api/issues/249/events","html_url":"https://github.com/hmrc/self-assessment-api/pull/249","id":188278215,"number":249,"title":"MTDSA-696 self-employment periods","user":{"login":"alexec","id":1142830,"avatar_url":"https://avatars.githubusercontent.com/u/1142830?v=3","gravatar_id":"","url":"https://api.github.com/users/alexec","html_url":"https://github.com/alexec","followers_url":"https://api.github.com/users/alexec/followers","following_url":"https://api.github.com/users/alexec/following{/other_user}","gists_url":"https://api.github.com/users/alexec/gists{/gist_id}","starred_url":"https://api.github.com/users/alexec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexec/subscriptions","organizations_url":"https://api.github.com/users/alexec/orgs","repos_url":"https://api.github.com/users/alexec/repos","events_url":"https://api.github.com/users/alexec/events{/privacy}","received_events_url":"https://api.github.com/users/alexec/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-09T15:42:08Z","updated_at":"2016-11-11T09:10:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hmrc/self-assessment-api/pulls/249","html_url":"https://github.com/hmrc/self-assessment-api/pull/249","diff_url":"https://github.com/hmrc/self-assessment-api/pull/249.diff","patch_url":"https://github.com/hmrc/self-assessment-api/pull/249.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/hmrc/self-assessment-api/issues/comments/259913860","html_url":"https://github.com/hmrc/self-assessment-api/pull/249#issuecomment-259913860","issue_url":"https://api.github.com/repos/hmrc/self-assessment-api/issues/249","id":259913860,"user":{"login":"alexec","id":1142830,"avatar_url":"https://avatars.githubusercontent.com/u/1142830?v=3","gravatar_id":"","url":"https://api.github.com/users/alexec","html_url":"https://github.com/alexec","followers_url":"https://api.github.com/users/alexec/followers","following_url":"https://api.github.com/users/alexec/following{/other_user}","gists_url":"https://api.github.com/users/alexec/gists{/gist_id}","starred_url":"https://api.github.com/users/alexec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexec/subscriptions","organizations_url":"https://api.github.com/users/alexec/orgs","repos_url":"https://api.github.com/users/alexec/repos","events_url":"https://api.github.com/users/alexec/events{/privacy}","received_events_url":"https://api.github.com/users/alexec/received_events","type":"User","site_admin":false},"created_at":"2016-11-11T09:10:33Z","updated_at":"2016-11-11T09:10:33Z","body":"> POST /self-assessment/nino/{nino}/self-employments/periods 400 error response should include example and example values in the body should be in Pounds and Pence to make it look more realistic. \r\n\r\nInteresting. A JSON number does not need a .00 suffix as it does not have rounding issues you find in other languages. However, perhaps adding 25p to each amount will make it clearer.\r\n\r\n> GET /self-assessment/nino/{nino}/self-employments/periods/{periodId} 200 response doesn't have an example. \r\n\r\nWill fix.\r\n\r\n> PUT /self-assessment/nino/{nino}/self-employments/periods/{periodId} example values in the body should be in Pounds and Pence to make it look more realistic.\r\n\r\nSee above."}}
{"actor":{"display_login":"alexec"}}