{"action":"created","comment":{"url":"https://api.github.com/repos/fireflylearning/pattern-library/pulls/comments/54701277","id":54701277,"diff_hunk":"@@ -1,29 +1,36 @@\n-.ff_container-expandable__dropdown {\n-\tpadding: @ff_size_spacing_med;\n-\tborder: 1px solid @ff_colour_melody_int_blue;\n-\tcolor: @ff_colour_melody_int_blue;\n-\tcursor: pointer;\n-\tbackground: white;\n-}\n+.ff_container-expandable {\n+\t&__header {\n+\t\tpadding: @ff_size_spacing_med;\n+\t\tborder: 1px solid @ff_colour_melody_int_blue;\n+\t\tcolor: @ff_colour_melody_int_blue;\n+\t\tcursor: pointer;\n+\t\tbackground: white;\n+\t}\n \n-.ff_container-expandable__dropdown--small-screens {\n-\t@media all and (min-width: @ff_bp_medium) { \n-\t\tdisplay: none;\n+\t&__icon {\n+\t\twidth: 1.5em;\n+\t\theight: 1.5em;\n+\t\tfloat: right;\n \t}\n-}\n \n-.ff_container-expandable__icon  {\n-\twidth: 1.5em;\n-\theight: 1.5em;\n-\tfloat: right;\n-}\n+\t&__content {\n+\t\tmax-height: 1000px;\n+\t\toverflow: hidden;\n+\t\ttransition: max-height 0.25s ease-in-out;\n+\t}\n \n-.ff_container-expandable__content {\n-\tmax-height: 1000px;\n-\toverflow: hidden;\n-\ttransition: max-height 0.25s ease-in-out;\n-}\n+\t&--is-collapsed &__content {\n+\t\tmax-height: 0;\n+\t}\n \n-.ff_container-expandable__content--hidden {\n-\tmax-height: 0;\n-}\n+\t&--is-widescreen &__header {\n+\t\t@media all and (min-width: @ff_bp_wide) { \n+\t\t\tdisplay: none;\n+\t\t}\n+\t}\n+\t&--is-widescreen &__content {\n+\t\t@media all and (min-width: @ff_bp_wide) { \n+\t\t\tmax-height: 1000px;","path":"blocks/melody/ff_container/ff_container-expandable/ff_container-expandable.less","position":57,"original_position":57,"commit_id":"59136d7610393820b8ca72c823ce5af013b20f97","original_commit_id":"59136d7610393820b8ca72c823ce5af013b20f97","user":{"login":"simonedeluca-firefly","id":8876724,"avatar_url":"https://avatars.githubusercontent.com/u/8876724?v=3","gravatar_id":"","url":"https://api.github.com/users/simonedeluca-firefly","html_url":"https://github.com/simonedeluca-firefly","followers_url":"https://api.github.com/users/simonedeluca-firefly/followers","following_url":"https://api.github.com/users/simonedeluca-firefly/following{/other_user}","gists_url":"https://api.github.com/users/simonedeluca-firefly/gists{/gist_id}","starred_url":"https://api.github.com/users/simonedeluca-firefly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonedeluca-firefly/subscriptions","organizations_url":"https://api.github.com/users/simonedeluca-firefly/orgs","repos_url":"https://api.github.com/users/simonedeluca-firefly/repos","events_url":"https://api.github.com/users/simonedeluca-firefly/events{/privacy}","received_events_url":"https://api.github.com/users/simonedeluca-firefly/received_events","type":"User","site_admin":false},"body":"When It's `--is-widescreen` (which means content should show and heading should disappear on widescreen) the javascript will apply the class of `is-collapsed` regardless of it.  `is-collapsed` sets the max-height: 0 to hide the content. So I want to set the max-height of the content to make it visible on widescreens. This max-height thing is only for animation purposes.","created_at":"2016-03-02T09:53:34Z","updated_at":"2016-03-02T09:53:34Z","html_url":"https://github.com/fireflylearning/pattern-library/pull/94#discussion_r54701277","pull_request_url":"https://api.github.com/repos/fireflylearning/pattern-library/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/fireflylearning/pattern-library/pulls/comments/54701277"},"html":{"href":"https://github.com/fireflylearning/pattern-library/pull/94#discussion_r54701277"},"pull_request":{"href":"https://api.github.com/repos/fireflylearning/pattern-library/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/fireflylearning/pattern-library/pulls/94","id":61267614,"html_url":"https://github.com/fireflylearning/pattern-library/pull/94","diff_url":"https://github.com/fireflylearning/pattern-library/pull/94.diff","patch_url":"https://github.com/fireflylearning/pattern-library/pull/94.patch","issue_url":"https://api.github.com/repos/fireflylearning/pattern-library/issues/94","number":94,"state":"open","locked":false,"title":"Updates to the expandable container","user":{"login":"simonedeluca-firefly","id":8876724,"avatar_url":"https://avatars.githubusercontent.com/u/8876724?v=3","gravatar_id":"","url":"https://api.github.com/users/simonedeluca-firefly","html_url":"https://github.com/simonedeluca-firefly","followers_url":"https://api.github.com/users/simonedeluca-firefly/followers","following_url":"https://api.github.com/users/simonedeluca-firefly/following{/other_user}","gists_url":"https://api.github.com/users/simonedeluca-firefly/gists{/gist_id}","starred_url":"https://api.github.com/users/simonedeluca-firefly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonedeluca-firefly/subscriptions","organizations_url":"https://api.github.com/users/simonedeluca-firefly/orgs","repos_url":"https://api.github.com/users/simonedeluca-firefly/repos","events_url":"https://api.github.com/users/simonedeluca-firefly/events{/privacy}","received_events_url":"https://api.github.com/users/simonedeluca-firefly/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-01T16:22:58Z","updated_at":"2016-03-02T09:53:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c2dca0ea063d2c272f1c9020fae2bb2294794ce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fireflylearning/pattern-library/pulls/94/commits","review_comments_url":"https://api.github.com/repos/fireflylearning/pattern-library/pulls/94/comments","review_comment_url":"https://api.github.com/repos/fireflylearning/pattern-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fireflylearning/pattern-library/issues/94/comments","statuses_url":"https://api.github.com/repos/fireflylearning/pattern-library/statuses/59136d7610393820b8ca72c823ce5af013b20f97","head":{"label":"fireflylearning:sd-expandable-updates","ref":"sd-expandable-updates","sha":"59136d7610393820b8ca72c823ce5af013b20f97","user":{"login":"fireflylearning","id":8058586,"avatar_url":"https://avatars.githubusercontent.com/u/8058586?v=3","gravatar_id":"","url":"https://api.github.com/users/fireflylearning","html_url":"https://github.com/fireflylearning","followers_url":"https://api.github.com/users/fireflylearning/followers","following_url":"https://api.github.com/users/fireflylearning/following{/other_user}","gists_url":"https://api.github.com/users/fireflylearning/gists{/gist_id}","starred_url":"https://api.github.com/users/fireflylearning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fireflylearning/subscriptions","organizations_url":"https://api.github.com/users/fireflylearning/orgs","repos_url":"https://api.github.com/users/fireflylearning/repos","events_url":"https://api.github.com/users/fireflylearning/events{/privacy}","received_events_url":"https://api.github.com/users/fireflylearning/received_events","type":"Organization","site_admin":false},"repo":{"id":30962281,"name":"pattern-library","full_name":"fireflylearning/pattern-library","owner":{"login":"fireflylearning","id":8058586,"avatar_url":"https://avatars.githubusercontent.com/u/8058586?v=3","gravatar_id":"","url":"https://api.github.com/users/fireflylearning","html_url":"https://github.com/fireflylearning","followers_url":"https://api.github.com/users/fireflylearning/followers","following_url":"https://api.github.com/users/fireflylearning/following{/other_user}","gists_url":"https://api.github.com/users/fireflylearning/gists{/gist_id}","starred_url":"https://api.github.com/users/fireflylearning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fireflylearning/subscriptions","organizations_url":"https://api.github.com/users/fireflylearning/orgs","repos_url":"https://api.github.com/users/fireflylearning/repos","events_url":"https://api.github.com/users/fireflylearning/events{/privacy}","received_events_url":"https://api.github.com/users/fireflylearning/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fireflylearning/pattern-library","description":"A library of Firefly interface elements","fork":false,"url":"https://api.github.com/repos/fireflylearning/pattern-library","forks_url":"https://api.github.com/repos/fireflylearning/pattern-library/forks","keys_url":"https://api.github.com/repos/fireflylearning/pattern-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fireflylearning/pattern-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fireflylearning/pattern-library/teams","hooks_url":"https://api.github.com/repos/fireflylearning/pattern-library/hooks","issue_events_url":"https://api.github.com/repos/fireflylearning/pattern-library/issues/events{/number}","events_url":"https://api.github.com/repos/fireflylearning/pattern-library/events","assignees_url":"https://api.github.com/repos/fireflylearning/pattern-library/assignees{/user}","branches_url":"https://api.github.com/repos/fireflylearning/pattern-library/branches{/branch}","tags_url":"https://api.github.com/repos/fireflylearning/pattern-library/tags","blobs_url":"https://api.github.com/repos/fireflylearning/pattern-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fireflylearning/pattern-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fireflylearning/pattern-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/fireflylearning/pattern-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fireflylearning/pattern-library/statuses/{sha}","languages_url":"https://api.github.com/repos/fireflylearning/pattern-library/languages","stargazers_url":"https://api.github.com/repos/fireflylearning/pattern-library/stargazers","contributors_url":"https://api.github.com/repos/fireflylearning/pattern-library/contributors","subscribers_url":"https://api.github.com/repos/fireflylearning/pattern-library/subscribers","subscription_url":"https://api.github.com/repos/fireflylearning/pattern-library/subscription","commits_url":"https://api.github.com/repos/fireflylearning/pattern-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/fireflylearning/pattern-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/fireflylearning/pattern-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/fireflylearning/pattern-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/fireflylearning/pattern-library/contents/{+path}","compare_url":"https://api.github.com/repos/fireflylearning/pattern-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fireflylearning/pattern-library/merges","archive_url":"https://api.github.com/repos/fireflylearning/pattern-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fireflylearning/pattern-library/downloads","issues_url":"https://api.github.com/repos/fireflylearning/pattern-library/issues{/number}","pulls_url":"https://api.github.com/repos/fireflylearning/pattern-library/pulls{/number}","milestones_url":"https://api.github.com/repos/fireflylearning/pattern-library/milestones{/number}","notifications_url":"https://api.github.com/repos/fireflylearning/pattern-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fireflylearning/pattern-library/labels{/name}","releases_url":"https://api.github.com/repos/fireflylearning/pattern-library/releases{/id}","deployments_url":"https://api.github.com/repos/fireflylearning/pattern-library/deployments","created_at":"2015-02-18T11:08:08Z","updated_at":"2016-02-28T21:16:00Z","pushed_at":"2016-03-01T16:22:58Z","git_url":"git://github.com/fireflylearning/pattern-library.git","ssh_url":"git@github.com:fireflylearning/pattern-library.git","clone_url":"https://github.com/fireflylearning/pattern-library.git","svn_url":"https://github.com/fireflylearning/pattern-library","homepage":null,"size":11490,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":2,"default_branch":"dev"}},"base":{"label":"fireflylearning:dev","ref":"dev","sha":"e2d3fa722a726659ba5d969084c21727f23eb70c","user":{"login":"fireflylearning","id":8058586,"avatar_url":"https://avatars.githubusercontent.com/u/8058586?v=3","gravatar_id":"","url":"https://api.github.com/users/fireflylearning","html_url":"https://github.com/fireflylearning","followers_url":"https://api.github.com/users/fireflylearning/followers","following_url":"https://api.github.com/users/fireflylearning/following{/other_user}","gists_url":"https://api.github.com/users/fireflylearning/gists{/gist_id}","starred_url":"https://api.github.com/users/fireflylearning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fireflylearning/subscriptions","organizations_url":"https://api.github.com/users/fireflylearning/orgs","repos_url":"https://api.github.com/users/fireflylearning/repos","events_url":"https://api.github.com/users/fireflylearning/events{/privacy}","received_events_url":"https://api.github.com/users/fireflylearning/received_events","type":"Organization","site_admin":false},"repo":{"id":30962281,"name":"pattern-library","full_name":"fireflylearning/pattern-library","owner":{"login":"fireflylearning","id":8058586,"avatar_url":"https://avatars.githubusercontent.com/u/8058586?v=3","gravatar_id":"","url":"https://api.github.com/users/fireflylearning","html_url":"https://github.com/fireflylearning","followers_url":"https://api.github.com/users/fireflylearning/followers","following_url":"https://api.github.com/users/fireflylearning/following{/other_user}","gists_url":"https://api.github.com/users/fireflylearning/gists{/gist_id}","starred_url":"https://api.github.com/users/fireflylearning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fireflylearning/subscriptions","organizations_url":"https://api.github.com/users/fireflylearning/orgs","repos_url":"https://api.github.com/users/fireflylearning/repos","events_url":"https://api.github.com/users/fireflylearning/events{/privacy}","received_events_url":"https://api.github.com/users/fireflylearning/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fireflylearning/pattern-library","description":"A library of Firefly interface elements","fork":false,"url":"https://api.github.com/repos/fireflylearning/pattern-library","forks_url":"https://api.github.com/repos/fireflylearning/pattern-library/forks","keys_url":"https://api.github.com/repos/fireflylearning/pattern-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fireflylearning/pattern-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fireflylearning/pattern-library/teams","hooks_url":"https://api.github.com/repos/fireflylearning/pattern-library/hooks","issue_events_url":"https://api.github.com/repos/fireflylearning/pattern-library/issues/events{/number}","events_url":"https://api.github.com/repos/fireflylearning/pattern-library/events","assignees_url":"https://api.github.com/repos/fireflylearning/pattern-library/assignees{/user}","branches_url":"https://api.github.com/repos/fireflylearning/pattern-library/branches{/branch}","tags_url":"https://api.github.com/repos/fireflylearning/pattern-library/tags","blobs_url":"https://api.github.com/repos/fireflylearning/pattern-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fireflylearning/pattern-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fireflylearning/pattern-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/fireflylearning/pattern-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fireflylearning/pattern-library/statuses/{sha}","languages_url":"https://api.github.com/repos/fireflylearning/pattern-library/languages","stargazers_url":"https://api.github.com/repos/fireflylearning/pattern-library/stargazers","contributors_url":"https://api.github.com/repos/fireflylearning/pattern-library/contributors","subscribers_url":"https://api.github.com/repos/fireflylearning/pattern-library/subscribers","subscription_url":"https://api.github.com/repos/fireflylearning/pattern-library/subscription","commits_url":"https://api.github.com/repos/fireflylearning/pattern-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/fireflylearning/pattern-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/fireflylearning/pattern-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/fireflylearning/pattern-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/fireflylearning/pattern-library/contents/{+path}","compare_url":"https://api.github.com/repos/fireflylearning/pattern-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fireflylearning/pattern-library/merges","archive_url":"https://api.github.com/repos/fireflylearning/pattern-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fireflylearning/pattern-library/downloads","issues_url":"https://api.github.com/repos/fireflylearning/pattern-library/issues{/number}","pulls_url":"https://api.github.com/repos/fireflylearning/pattern-library/pulls{/number}","milestones_url":"https://api.github.com/repos/fireflylearning/pattern-library/milestones{/number}","notifications_url":"https://api.github.com/repos/fireflylearning/pattern-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fireflylearning/pattern-library/labels{/name}","releases_url":"https://api.github.com/repos/fireflylearning/pattern-library/releases{/id}","deployments_url":"https://api.github.com/repos/fireflylearning/pattern-library/deployments","created_at":"2015-02-18T11:08:08Z","updated_at":"2016-02-28T21:16:00Z","pushed_at":"2016-03-01T16:22:58Z","git_url":"git://github.com/fireflylearning/pattern-library.git","ssh_url":"git@github.com:fireflylearning/pattern-library.git","clone_url":"https://github.com/fireflylearning/pattern-library.git","svn_url":"https://github.com/fireflylearning/pattern-library","homepage":null,"size":11490,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":6,"forks":2,"open_issues":6,"watchers":2,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/fireflylearning/pattern-library/pulls/94"},"html":{"href":"https://github.com/fireflylearning/pattern-library/pull/94"},"issue":{"href":"https://api.github.com/repos/fireflylearning/pattern-library/issues/94"},"comments":{"href":"https://api.github.com/repos/fireflylearning/pattern-library/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/fireflylearning/pattern-library/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/fireflylearning/pattern-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fireflylearning/pattern-library/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/fireflylearning/pattern-library/statuses/59136d7610393820b8ca72c823ce5af013b20f97"}}}}