{"action":"created","comment":{"url":"https://api.github.com/repos/dato-code/SFrame/pulls/comments/50754928","id":50754928,"diff_hunk":"@@ -32,16 +34,36 @@ void sframe_rows::clear() {\n \n void sframe_rows::save(oarchive& oarc) const {\n   oarc << m_decoded_columns.size();\n-  for (auto& i : m_decoded_columns) oarc << *i;\n+  oarchive temp_inmemory_arc;\n+  for (auto& i : m_decoded_columns) {\n+    v2_block_impl::block_info info;","path":"oss_src/sframe/sframe_rows.cpp","position":16,"original_position":16,"commit_id":"9d6ea9678c9a50b3cd2cd31a886c5f08db2ba6b6","original_commit_id":"9d6ea9678c9a50b3cd2cd31a886c5f08db2ba6b6","user":{"login":"haijieg","id":818855,"avatar_url":"https://avatars.githubusercontent.com/u/818855?v=3","gravatar_id":"","url":"https://api.github.com/users/haijieg","html_url":"https://github.com/haijieg","followers_url":"https://api.github.com/users/haijieg/followers","following_url":"https://api.github.com/users/haijieg/following{/other_user}","gists_url":"https://api.github.com/users/haijieg/gists{/gist_id}","starred_url":"https://api.github.com/users/haijieg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haijieg/subscriptions","organizations_url":"https://api.github.com/users/haijieg/orgs","repos_url":"https://api.github.com/users/haijieg/repos","events_url":"https://api.github.com/users/haijieg/events{/privacy}","received_events_url":"https://api.github.com/users/haijieg/received_events","type":"User","site_admin":false},"body":"Does this only apply to sframe_rows.save()/load() or shall we move it into lower level sarray column save/load?","created_at":"2016-01-25T20:59:23Z","updated_at":"2016-01-25T20:59:23Z","html_url":"https://github.com/dato-code/SFrame/pull/110#discussion_r50754928","pull_request_url":"https://api.github.com/repos/dato-code/SFrame/pulls/110","_links":{"self":{"href":"https://api.github.com/repos/dato-code/SFrame/pulls/comments/50754928"},"html":{"href":"https://github.com/dato-code/SFrame/pull/110#discussion_r50754928"},"pull_request":{"href":"https://api.github.com/repos/dato-code/SFrame/pulls/110"}}},"pull_request":{"url":"https://api.github.com/repos/dato-code/SFrame/pulls/110","id":53752885,"html_url":"https://github.com/dato-code/SFrame/pull/110","diff_url":"https://github.com/dato-code/SFrame/pull/110.diff","patch_url":"https://github.com/dato-code/SFrame/pull/110.patch","issue_url":"https://api.github.com/repos/dato-code/SFrame/issues/110","number":110,"state":"open","locked":false,"title":"SFrame optimizations","user":{"login":"ylow","id":2740522,"avatar_url":"https://avatars.githubusercontent.com/u/2740522?v=3","gravatar_id":"","url":"https://api.github.com/users/ylow","html_url":"https://github.com/ylow","followers_url":"https://api.github.com/users/ylow/followers","following_url":"https://api.github.com/users/ylow/following{/other_user}","gists_url":"https://api.github.com/users/ylow/gists{/gist_id}","starred_url":"https://api.github.com/users/ylow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylow/subscriptions","organizations_url":"https://api.github.com/users/ylow/orgs","repos_url":"https://api.github.com/users/ylow/repos","events_url":"https://api.github.com/users/ylow/events{/privacy}","received_events_url":"https://api.github.com/users/ylow/received_events","type":"User","site_admin":false},"body":"This is a deep improvement to the SFrame query execution layer. Currently, we have a rate control issue: we can only lazily execute fully linear pipelines (i.e. every operator emits output at the same rate as its inputs, and must consume every input at the same rate. For instance, a numeric operator is linear, a filtering operator is not). \r\n\r\nTo execute non-linear pipelines requires potentially unbounded buffering at each operator node. This implements the unbounded buffer via a datastructure I am calling the \"broadcast queue\". \r\n\r\nThis allows arbitrary chains of logical filter to be completely lazy. \r\n\r\nIt became necessary to solve the following inconsistencies right now: \r\n```\r\n> gl.SArray([]).sum()\r\nNone\r\n> gl.SArray([None]).sum()\r\n0.0\r\n```\r\nSo we settled on the latter. i.e. \r\n```\r\n> gl.SArray([]).sum() \r\n0.0\r\n```\r\n\r\nOther changes:\r\ntest_io.py. /root is not a system folder on Mac. Changed it to /System\r\n\r\n\r\n### Behavioral Changes\r\n#### Sum of an empty array returns the \"0\" value for the array type.\r\n```\r\n> gl.SArray([], float).sum() \r\n0.0\r\n> gl.SArray([], int).sum() \r\n0\r\n> gl.SArray([], array.array).sum() \r\narray.array('d')\r\n```\r\n#### Logical filters are now *very* lazy. binary operators are also now *very* lazy.\r\n","created_at":"2015-12-15T19:51:21Z","updated_at":"2016-01-25T20:59:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a972919221d6084339f6fb4847cbbeb64444bdc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dato-code/SFrame/pulls/110/commits","review_comments_url":"https://api.github.com/repos/dato-code/SFrame/pulls/110/comments","review_comment_url":"https://api.github.com/repos/dato-code/SFrame/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dato-code/SFrame/issues/110/comments","statuses_url":"https://api.github.com/repos/dato-code/SFrame/statuses/9d6ea9678c9a50b3cd2cd31a886c5f08db2ba6b6","head":{"label":"ylow:sf_optimizations","ref":"sf_optimizations","sha":"9d6ea9678c9a50b3cd2cd31a886c5f08db2ba6b6","user":{"login":"ylow","id":2740522,"avatar_url":"https://avatars.githubusercontent.com/u/2740522?v=3","gravatar_id":"","url":"https://api.github.com/users/ylow","html_url":"https://github.com/ylow","followers_url":"https://api.github.com/users/ylow/followers","following_url":"https://api.github.com/users/ylow/following{/other_user}","gists_url":"https://api.github.com/users/ylow/gists{/gist_id}","starred_url":"https://api.github.com/users/ylow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylow/subscriptions","organizations_url":"https://api.github.com/users/ylow/orgs","repos_url":"https://api.github.com/users/ylow/repos","events_url":"https://api.github.com/users/ylow/events{/privacy}","received_events_url":"https://api.github.com/users/ylow/received_events","type":"User","site_admin":false},"repo":{"id":42703786,"name":"SFrame","full_name":"ylow/SFrame","owner":{"login":"ylow","id":2740522,"avatar_url":"https://avatars.githubusercontent.com/u/2740522?v=3","gravatar_id":"","url":"https://api.github.com/users/ylow","html_url":"https://github.com/ylow","followers_url":"https://api.github.com/users/ylow/followers","following_url":"https://api.github.com/users/ylow/following{/other_user}","gists_url":"https://api.github.com/users/ylow/gists{/gist_id}","starred_url":"https://api.github.com/users/ylow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ylow/subscriptions","organizations_url":"https://api.github.com/users/ylow/orgs","repos_url":"https://api.github.com/users/ylow/repos","events_url":"https://api.github.com/users/ylow/events{/privacy}","received_events_url":"https://api.github.com/users/ylow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ylow/SFrame","description":"SFrame, SArray, SGraph","fork":true,"url":"https://api.github.com/repos/ylow/SFrame","forks_url":"https://api.github.com/repos/ylow/SFrame/forks","keys_url":"https://api.github.com/repos/ylow/SFrame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ylow/SFrame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ylow/SFrame/teams","hooks_url":"https://api.github.com/repos/ylow/SFrame/hooks","issue_events_url":"https://api.github.com/repos/ylow/SFrame/issues/events{/number}","events_url":"https://api.github.com/repos/ylow/SFrame/events","assignees_url":"https://api.github.com/repos/ylow/SFrame/assignees{/user}","branches_url":"https://api.github.com/repos/ylow/SFrame/branches{/branch}","tags_url":"https://api.github.com/repos/ylow/SFrame/tags","blobs_url":"https://api.github.com/repos/ylow/SFrame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ylow/SFrame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ylow/SFrame/git/refs{/sha}","trees_url":"https://api.github.com/repos/ylow/SFrame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ylow/SFrame/statuses/{sha}","languages_url":"https://api.github.com/repos/ylow/SFrame/languages","stargazers_url":"https://api.github.com/repos/ylow/SFrame/stargazers","contributors_url":"https://api.github.com/repos/ylow/SFrame/contributors","subscribers_url":"https://api.github.com/repos/ylow/SFrame/subscribers","subscription_url":"https://api.github.com/repos/ylow/SFrame/subscription","commits_url":"https://api.github.com/repos/ylow/SFrame/commits{/sha}","git_commits_url":"https://api.github.com/repos/ylow/SFrame/git/commits{/sha}","comments_url":"https://api.github.com/repos/ylow/SFrame/comments{/number}","issue_comment_url":"https://api.github.com/repos/ylow/SFrame/issues/comments{/number}","contents_url":"https://api.github.com/repos/ylow/SFrame/contents/{+path}","compare_url":"https://api.github.com/repos/ylow/SFrame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ylow/SFrame/merges","archive_url":"https://api.github.com/repos/ylow/SFrame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ylow/SFrame/downloads","issues_url":"https://api.github.com/repos/ylow/SFrame/issues{/number}","pulls_url":"https://api.github.com/repos/ylow/SFrame/pulls{/number}","milestones_url":"https://api.github.com/repos/ylow/SFrame/milestones{/number}","notifications_url":"https://api.github.com/repos/ylow/SFrame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ylow/SFrame/labels{/name}","releases_url":"https://api.github.com/repos/ylow/SFrame/releases{/id}","deployments_url":"https://api.github.com/repos/ylow/SFrame/deployments","created_at":"2015-09-18T06:28:02Z","updated_at":"2016-01-12T00:03:22Z","pushed_at":"2016-01-15T23:52:42Z","git_url":"git://github.com/ylow/SFrame.git","ssh_url":"git@github.com:ylow/SFrame.git","clone_url":"https://github.com/ylow/SFrame.git","svn_url":"https://github.com/ylow/SFrame","homepage":null,"size":3871,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dato-code:master","ref":"master","sha":"697337d925aba538c78096a754cfbabe5081587e","user":{"login":"dato-code","id":10378005,"avatar_url":"https://avatars.githubusercontent.com/u/10378005?v=3","gravatar_id":"","url":"https://api.github.com/users/dato-code","html_url":"https://github.com/dato-code","followers_url":"https://api.github.com/users/dato-code/followers","following_url":"https://api.github.com/users/dato-code/following{/other_user}","gists_url":"https://api.github.com/users/dato-code/gists{/gist_id}","starred_url":"https://api.github.com/users/dato-code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dato-code/subscriptions","organizations_url":"https://api.github.com/users/dato-code/orgs","repos_url":"https://api.github.com/users/dato-code/repos","events_url":"https://api.github.com/users/dato-code/events{/privacy}","received_events_url":"https://api.github.com/users/dato-code/received_events","type":"Organization","site_admin":false},"repo":{"id":41886367,"name":"SFrame","full_name":"dato-code/SFrame","owner":{"login":"dato-code","id":10378005,"avatar_url":"https://avatars.githubusercontent.com/u/10378005?v=3","gravatar_id":"","url":"https://api.github.com/users/dato-code","html_url":"https://github.com/dato-code","followers_url":"https://api.github.com/users/dato-code/followers","following_url":"https://api.github.com/users/dato-code/following{/other_user}","gists_url":"https://api.github.com/users/dato-code/gists{/gist_id}","starred_url":"https://api.github.com/users/dato-code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dato-code/subscriptions","organizations_url":"https://api.github.com/users/dato-code/orgs","repos_url":"https://api.github.com/users/dato-code/repos","events_url":"https://api.github.com/users/dato-code/events{/privacy}","received_events_url":"https://api.github.com/users/dato-code/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dato-code/SFrame","description":"SFrame, SArray, SGraph","fork":false,"url":"https://api.github.com/repos/dato-code/SFrame","forks_url":"https://api.github.com/repos/dato-code/SFrame/forks","keys_url":"https://api.github.com/repos/dato-code/SFrame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dato-code/SFrame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dato-code/SFrame/teams","hooks_url":"https://api.github.com/repos/dato-code/SFrame/hooks","issue_events_url":"https://api.github.com/repos/dato-code/SFrame/issues/events{/number}","events_url":"https://api.github.com/repos/dato-code/SFrame/events","assignees_url":"https://api.github.com/repos/dato-code/SFrame/assignees{/user}","branches_url":"https://api.github.com/repos/dato-code/SFrame/branches{/branch}","tags_url":"https://api.github.com/repos/dato-code/SFrame/tags","blobs_url":"https://api.github.com/repos/dato-code/SFrame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dato-code/SFrame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dato-code/SFrame/git/refs{/sha}","trees_url":"https://api.github.com/repos/dato-code/SFrame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dato-code/SFrame/statuses/{sha}","languages_url":"https://api.github.com/repos/dato-code/SFrame/languages","stargazers_url":"https://api.github.com/repos/dato-code/SFrame/stargazers","contributors_url":"https://api.github.com/repos/dato-code/SFrame/contributors","subscribers_url":"https://api.github.com/repos/dato-code/SFrame/subscribers","subscription_url":"https://api.github.com/repos/dato-code/SFrame/subscription","commits_url":"https://api.github.com/repos/dato-code/SFrame/commits{/sha}","git_commits_url":"https://api.github.com/repos/dato-code/SFrame/git/commits{/sha}","comments_url":"https://api.github.com/repos/dato-code/SFrame/comments{/number}","issue_comment_url":"https://api.github.com/repos/dato-code/SFrame/issues/comments{/number}","contents_url":"https://api.github.com/repos/dato-code/SFrame/contents/{+path}","compare_url":"https://api.github.com/repos/dato-code/SFrame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dato-code/SFrame/merges","archive_url":"https://api.github.com/repos/dato-code/SFrame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dato-code/SFrame/downloads","issues_url":"https://api.github.com/repos/dato-code/SFrame/issues{/number}","pulls_url":"https://api.github.com/repos/dato-code/SFrame/pulls{/number}","milestones_url":"https://api.github.com/repos/dato-code/SFrame/milestones{/number}","notifications_url":"https://api.github.com/repos/dato-code/SFrame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dato-code/SFrame/labels{/name}","releases_url":"https://api.github.com/repos/dato-code/SFrame/releases{/id}","deployments_url":"https://api.github.com/repos/dato-code/SFrame/deployments","created_at":"2015-09-03T22:14:14Z","updated_at":"2016-01-25T14:25:31Z","pushed_at":"2016-01-25T18:27:19Z","git_url":"git://github.com/dato-code/SFrame.git","ssh_url":"git@github.com:dato-code/SFrame.git","clone_url":"https://github.com/dato-code/SFrame.git","svn_url":"https://github.com/dato-code/SFrame","homepage":null,"size":4138,"stargazers_count":243,"watchers_count":243,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":24,"forks":99,"open_issues":24,"watchers":243,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dato-code/SFrame/pulls/110"},"html":{"href":"https://github.com/dato-code/SFrame/pull/110"},"issue":{"href":"https://api.github.com/repos/dato-code/SFrame/issues/110"},"comments":{"href":"https://api.github.com/repos/dato-code/SFrame/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/dato-code/SFrame/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/dato-code/SFrame/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dato-code/SFrame/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/dato-code/SFrame/statuses/9d6ea9678c9a50b3cd2cd31a886c5f08db2ba6b6"}}}}