{"action":"created","comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls/comments/58861083","id":58861083,"diff_hunk":"@@ -0,0 +1,115 @@\n+'use strict';\r\n+var Cesium = require('cesium');\r\n+var defined = Cesium.defined;\r\n+var defaultValue = Cesium.defaultValue;\r\n+\r\n+module.exports = addPipelineExtras;\r\n+\r\n+//Add the pipeline extras object to each glTF object.\r\n+function addPipelineExtras(gltf) {\r\n+    var reference = {\r","path":"lib/addPipelineExtras.js","position":10,"original_position":10,"commit_id":"7d5c52ab2d47c5fa99d606c4e58ade5b695c6151","original_commit_id":"7d5c52ab2d47c5fa99d606c4e58ade5b695c6151","user":{"login":"pjcozzi","id":782098,"avatar_url":"https://avatars.githubusercontent.com/u/782098?v=3","gravatar_id":"","url":"https://api.github.com/users/pjcozzi","html_url":"https://github.com/pjcozzi","followers_url":"https://api.github.com/users/pjcozzi/followers","following_url":"https://api.github.com/users/pjcozzi/following{/other_user}","gists_url":"https://api.github.com/users/pjcozzi/gists{/gist_id}","starred_url":"https://api.github.com/users/pjcozzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjcozzi/subscriptions","organizations_url":"https://api.github.com/users/pjcozzi/orgs","repos_url":"https://api.github.com/users/pjcozzi/repos","events_url":"https://api.github.com/users/pjcozzi/events{/privacy}","received_events_url":"https://api.github.com/users/pjcozzi/received_events","type":"User","site_admin":false},"body":"Does the `reference` object need the `addPipelineExtra` properties?  My original - but perhaps too simplistic - thought was just having the glTF properties name would be enough, for example:\r\n```javascript\r\nvar reference = {\r\n    \"accessors\" : true,\r\n    \"animations\" : {  // implicitly true since all glTF object properties have an extras sub-property\r\n        \"channels\" : [ // same comment\r\n            {\r\n                \"target\" : true\r\n            }\r\n        ],\r\n        \"samplers\" : true\r\n    }\r\n    // ...\r\n}\r\n```\r\nDoes this make the algorithm harder (or impossible) to implement?","created_at":"2016-04-07T12:18:10Z","updated_at":"2016-04-07T12:18:10Z","html_url":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline/pull/41#discussion_r58861083","pull_request_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls/comments/58861083"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline/pull/41#discussion_r58861083"},"pull_request":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls/41","id":65576447,"html_url":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline/pull/41","diff_url":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline/pull/41.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline/pull/41.patch","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/issues/41","number":41,"state":"open","locked":false,"title":"Added addPipelineExtras stage","user":{"login":"leerichard42","id":4475130,"avatar_url":"https://avatars.githubusercontent.com/u/4475130?v=3","gravatar_id":"","url":"https://api.github.com/users/leerichard42","html_url":"https://github.com/leerichard42","followers_url":"https://api.github.com/users/leerichard42/followers","following_url":"https://api.github.com/users/leerichard42/following{/other_user}","gists_url":"https://api.github.com/users/leerichard42/gists{/gist_id}","starred_url":"https://api.github.com/users/leerichard42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leerichard42/subscriptions","organizations_url":"https://api.github.com/users/leerichard42/orgs","repos_url":"https://api.github.com/users/leerichard42/repos","events_url":"https://api.github.com/users/leerichard42/events{/privacy}","received_events_url":"https://api.github.com/users/leerichard42/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-04-07T05:37:56Z","updated_at":"2016-04-07T12:18:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"541d51d9a77fff2ef05bf9756b1fb08ad2baa5fd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls/41/commits","review_comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls/41/comments","review_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/issues/41/comments","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/statuses/7d5c52ab2d47c5fa99d606c4e58ade5b695c6151","head":{"label":"AnalyticalGraphicsInc:addPipelineExtras","ref":"addPipelineExtras","sha":"7d5c52ab2d47c5fa99d606c4e58ade5b695c6151","user":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"repo":{"id":46226879,"name":"gltf-pipeline","full_name":"AnalyticalGraphicsInc/gltf-pipeline","owner":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline","description":"Content pipeline tools for optimizing glTF assets","fork":false,"url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline","forks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/forks","keys_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/teams","hooks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/hooks","issue_events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/events","assignees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/tags","blobs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/languages","stargazers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/stargazers","contributors_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/contributors","subscribers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/subscribers","subscription_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/subscription","commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/merges","archive_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/downloads","issues_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/releases{/id}","deployments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/deployments","created_at":"2015-11-15T17:00:20Z","updated_at":"2016-02-16T01:02:22Z","pushed_at":"2016-04-07T05:37:57Z","git_url":"git://github.com/AnalyticalGraphicsInc/gltf-pipeline.git","ssh_url":"git@github.com:AnalyticalGraphicsInc/gltf-pipeline.git","clone_url":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline.git","svn_url":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline","homepage":null,"size":257,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":11,"default_branch":"master"}},"base":{"label":"AnalyticalGraphicsInc:master","ref":"master","sha":"8eea3f881456931bcdcf002b3a120967abde74ac","user":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"repo":{"id":46226879,"name":"gltf-pipeline","full_name":"AnalyticalGraphicsInc/gltf-pipeline","owner":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline","description":"Content pipeline tools for optimizing glTF assets","fork":false,"url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline","forks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/forks","keys_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/teams","hooks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/hooks","issue_events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/events","assignees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/tags","blobs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/languages","stargazers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/stargazers","contributors_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/contributors","subscribers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/subscribers","subscription_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/subscription","commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/merges","archive_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/downloads","issues_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/releases{/id}","deployments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/deployments","created_at":"2015-11-15T17:00:20Z","updated_at":"2016-02-16T01:02:22Z","pushed_at":"2016-04-07T05:37:57Z","git_url":"git://github.com/AnalyticalGraphicsInc/gltf-pipeline.git","ssh_url":"git@github.com:AnalyticalGraphicsInc/gltf-pipeline.git","clone_url":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline.git","svn_url":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline","homepage":null,"size":257,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":7,"forks":2,"open_issues":7,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls/41"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/gltf-pipeline/pull/41"},"issue":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/issues/41"},"comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/gltf-pipeline/statuses/7d5c52ab2d47c5fa99d606c4e58ade5b695c6151"}}}}