{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7691","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7691/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7691/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7691/events","html_url":"https://github.com/bitcoin/bitcoin/pull/7691","id":140921281,"number":7691,"title":"[Wallet] refactor wallet/init interaction","user":{"login":"jonasschnelli","id":178464,"avatar_url":"https://avatars.githubusercontent.com/u/178464?v=3","gravatar_id":"","url":"https://api.github.com/users/jonasschnelli","html_url":"https://github.com/jonasschnelli","followers_url":"https://api.github.com/users/jonasschnelli/followers","following_url":"https://api.github.com/users/jonasschnelli/following{/other_user}","gists_url":"https://api.github.com/users/jonasschnelli/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasschnelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasschnelli/subscriptions","organizations_url":"https://api.github.com/users/jonasschnelli/orgs","repos_url":"https://api.github.com/users/jonasschnelli/repos","events_url":"https://api.github.com/users/jonasschnelli/events{/privacy}","received_events_url":"https://api.github.com/users/jonasschnelli/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Refactoring","name":"Refactoring","color":"E6F6D6"},{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Wallet","name":"Wallet","color":"02d7e1"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-03-15T09:35:30Z","updated_at":"2016-03-22T13:58:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/7691","html_url":"https://github.com/bitcoin/bitcoin/pull/7691","diff_url":"https://github.com/bitcoin/bitcoin/pull/7691.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/7691.patch"},"body":"This is another step to move the wallet code from `init.cpp` to `wallet.cpp` while keeping the behavior identical. Behavior simplification can be done once all code is available in `wallet.cpp`.\r\n\r\nThis is also a basic step into the direction of cloning the wallet, add BIP32 & multi-wallet in the second wallet implementation without introducing bugs in the current wallet implementation."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/199827445","html_url":"https://github.com/bitcoin/bitcoin/pull/7691#issuecomment-199827445","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/7691","id":199827445,"user":{"login":"morcos","id":4360349,"avatar_url":"https://avatars.githubusercontent.com/u/4360349?v=3","gravatar_id":"","url":"https://api.github.com/users/morcos","html_url":"https://github.com/morcos","followers_url":"https://api.github.com/users/morcos/followers","following_url":"https://api.github.com/users/morcos/following{/other_user}","gists_url":"https://api.github.com/users/morcos/gists{/gist_id}","starred_url":"https://api.github.com/users/morcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morcos/subscriptions","organizations_url":"https://api.github.com/users/morcos/orgs","repos_url":"https://api.github.com/users/morcos/repos","events_url":"https://api.github.com/users/morcos/events{/privacy}","received_events_url":"https://api.github.com/users/morcos/received_events","type":"User","site_admin":false},"created_at":"2016-03-22T13:58:19Z","updated_at":"2016-03-22T13:58:19Z","body":"@jonasschnelli I don't necessarily object to this but it seems like if you're eventually going to change these from static functions to methods called on pWalletMain, that you might as well make all those changes now instead of having to review twice.\r\nIf you feel like its cleaner to break it up, perhaps it could be 2 commits in the same PR, but why not move closer to where you're trying to go.\r\n"}}