{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/comments/68166517","id":68166517,"diff_hunk":"@@ -47,16 +47,17 @@ def wait_for_page_to_load(self):\n \n     def select_field(self, field):\n         self.find_element(*self._input_locator).send_keys(field)\n-        self.find_element(*self._operator_test_locator).click()\n+        self.find_element(*self._highlighted_text_locator).click()\n \n-    def select_operator(self, operator):\n-        self.find_element(*self._second_input_locator).send_keys(operator)\n-        self.find_element(*self._operator_test_locator).click()\n+    def select_operator(self, line_id, operator):\n+        input_locator = (self._operator_field_locator[0], self._operator_field_locator[1] % line_id)","path":"pages/super_search_page.py","position":31,"original_position":31,"commit_id":"739379f66607445413d16742939d4e3cc7463168","original_commit_id":"739379f66607445413d16742939d4e3cc7463168","user":{"login":"stephendonner","id":387249,"avatar_url":"https://avatars.githubusercontent.com/u/387249?v=3","gravatar_id":"","url":"https://api.github.com/users/stephendonner","html_url":"https://github.com/stephendonner","followers_url":"https://api.github.com/users/stephendonner/followers","following_url":"https://api.github.com/users/stephendonner/following{/other_user}","gists_url":"https://api.github.com/users/stephendonner/gists{/gist_id}","starred_url":"https://api.github.com/users/stephendonner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephendonner/subscriptions","organizations_url":"https://api.github.com/users/stephendonner/orgs","repos_url":"https://api.github.com/users/stephendonner/repos","events_url":"https://api.github.com/users/stephendonner/events{/privacy}","received_events_url":"https://api.github.com/users/stephendonner/received_events","type":"User","site_admin":false},"body":"Should this input_locator be defined/set in the appropriate class, instead of here?","created_at":"2016-06-23T02:13:01Z","updated_at":"2016-06-23T02:13:01Z","html_url":"https://github.com/mozilla/Socorro-Tests/pull/382#discussion_r68166517","pull_request_url":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/382","_links":{"self":{"href":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/comments/68166517"},"html":{"href":"https://github.com/mozilla/Socorro-Tests/pull/382#discussion_r68166517"},"pull_request":{"href":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/382"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/382","id":74837090,"html_url":"https://github.com/mozilla/Socorro-Tests/pull/382","diff_url":"https://github.com/mozilla/Socorro-Tests/pull/382.diff","patch_url":"https://github.com/mozilla/Socorro-Tests/pull/382.patch","issue_url":"https://api.github.com/repos/mozilla/Socorro-Tests/issues/382","number":382,"state":"open","locked":false,"title":"fix POM and cleanup effected tests","user":{"login":"m8ttyB","id":63193,"avatar_url":"https://avatars.githubusercontent.com/u/63193?v=3","gravatar_id":"","url":"https://api.github.com/users/m8ttyB","html_url":"https://github.com/m8ttyB","followers_url":"https://api.github.com/users/m8ttyB/followers","following_url":"https://api.github.com/users/m8ttyB/following{/other_user}","gists_url":"https://api.github.com/users/m8ttyB/gists{/gist_id}","starred_url":"https://api.github.com/users/m8ttyB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m8ttyB/subscriptions","organizations_url":"https://api.github.com/users/m8ttyB/orgs","repos_url":"https://api.github.com/users/m8ttyB/repos","events_url":"https://api.github.com/users/m8ttyB/events{/privacy}","received_events_url":"https://api.github.com/users/m8ttyB/received_events","type":"User","site_admin":false},"body":"We had one failing test on stage -- `test_search_for_unrealistic_data` -- that was due to a timing issue. The original test was authored to directly visit a url vs navigating to the page under test. I've taken the liberty of updating similar search tests that use this POM.\r\n\r\nI've updated the test to navigate to the search page. I've also updated the locators to more explicitly identify which field to enter the search terms into.\r\n\r\n* updated testcase(s) to explicitly navigate to the search page\r\n* provide locators that are more explicit\r\n* rename locators to be more explicit\r\n* general test cleanup as well as explicit assertions","created_at":"2016-06-22T18:51:57Z","updated_at":"2016-06-23T02:13:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0d7087b1c194e10443130d6aab9b5c9069c8fa1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/382/commits","review_comments_url":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/382/comments","review_comment_url":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/Socorro-Tests/issues/382/comments","statuses_url":"https://api.github.com/repos/mozilla/Socorro-Tests/statuses/739379f66607445413d16742939d4e3cc7463168","head":{"label":"m8ttyB:search_test","ref":"search_test","sha":"739379f66607445413d16742939d4e3cc7463168","user":{"login":"m8ttyB","id":63193,"avatar_url":"https://avatars.githubusercontent.com/u/63193?v=3","gravatar_id":"","url":"https://api.github.com/users/m8ttyB","html_url":"https://github.com/m8ttyB","followers_url":"https://api.github.com/users/m8ttyB/followers","following_url":"https://api.github.com/users/m8ttyB/following{/other_user}","gists_url":"https://api.github.com/users/m8ttyB/gists{/gist_id}","starred_url":"https://api.github.com/users/m8ttyB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m8ttyB/subscriptions","organizations_url":"https://api.github.com/users/m8ttyB/orgs","repos_url":"https://api.github.com/users/m8ttyB/repos","events_url":"https://api.github.com/users/m8ttyB/events{/privacy}","received_events_url":"https://api.github.com/users/m8ttyB/received_events","type":"User","site_admin":false},"repo":{"id":4502278,"name":"Socorro-Tests","full_name":"m8ttyB/Socorro-Tests","owner":{"login":"m8ttyB","id":63193,"avatar_url":"https://avatars.githubusercontent.com/u/63193?v=3","gravatar_id":"","url":"https://api.github.com/users/m8ttyB","html_url":"https://github.com/m8ttyB","followers_url":"https://api.github.com/users/m8ttyB/followers","following_url":"https://api.github.com/users/m8ttyB/following{/other_user}","gists_url":"https://api.github.com/users/m8ttyB/gists{/gist_id}","starred_url":"https://api.github.com/users/m8ttyB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m8ttyB/subscriptions","organizations_url":"https://api.github.com/users/m8ttyB/orgs","repos_url":"https://api.github.com/users/m8ttyB/repos","events_url":"https://api.github.com/users/m8ttyB/events{/privacy}","received_events_url":"https://api.github.com/users/m8ttyB/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/m8ttyB/Socorro-Tests","description":"Selenium Tests for the Socorro ","fork":true,"url":"https://api.github.com/repos/m8ttyB/Socorro-Tests","forks_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/forks","keys_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/teams","hooks_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/hooks","issue_events_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/issues/events{/number}","events_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/events","assignees_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/assignees{/user}","branches_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/branches{/branch}","tags_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/tags","blobs_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/statuses/{sha}","languages_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/languages","stargazers_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/stargazers","contributors_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/contributors","subscribers_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/subscribers","subscription_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/subscription","commits_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/contents/{+path}","compare_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/merges","archive_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/downloads","issues_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/issues{/number}","pulls_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/pulls{/number}","milestones_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/milestones{/number}","notifications_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/labels{/name}","releases_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/releases{/id}","deployments_url":"https://api.github.com/repos/m8ttyB/Socorro-Tests/deployments","created_at":"2012-05-31T00:43:48Z","updated_at":"2015-04-30T22:16:52Z","pushed_at":"2016-06-22T19:10:26Z","git_url":"git://github.com/m8ttyB/Socorro-Tests.git","ssh_url":"git@github.com:m8ttyB/Socorro-Tests.git","clone_url":"https://github.com/m8ttyB/Socorro-Tests.git","svn_url":"https://github.com/m8ttyB/Socorro-Tests","homepage":"","size":699,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"21ae4bcf365433c235e283fc1a865772313b47d4","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1711997,"name":"Socorro-Tests","full_name":"mozilla/Socorro-Tests","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/Socorro-Tests","description":"Selenium Tests for the Socorro ","fork":false,"url":"https://api.github.com/repos/mozilla/Socorro-Tests","forks_url":"https://api.github.com/repos/mozilla/Socorro-Tests/forks","keys_url":"https://api.github.com/repos/mozilla/Socorro-Tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/Socorro-Tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/Socorro-Tests/teams","hooks_url":"https://api.github.com/repos/mozilla/Socorro-Tests/hooks","issue_events_url":"https://api.github.com/repos/mozilla/Socorro-Tests/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/Socorro-Tests/events","assignees_url":"https://api.github.com/repos/mozilla/Socorro-Tests/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/Socorro-Tests/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/Socorro-Tests/tags","blobs_url":"https://api.github.com/repos/mozilla/Socorro-Tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/Socorro-Tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/Socorro-Tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/Socorro-Tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/Socorro-Tests/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/Socorro-Tests/languages","stargazers_url":"https://api.github.com/repos/mozilla/Socorro-Tests/stargazers","contributors_url":"https://api.github.com/repos/mozilla/Socorro-Tests/contributors","subscribers_url":"https://api.github.com/repos/mozilla/Socorro-Tests/subscribers","subscription_url":"https://api.github.com/repos/mozilla/Socorro-Tests/subscription","commits_url":"https://api.github.com/repos/mozilla/Socorro-Tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/Socorro-Tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/Socorro-Tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/Socorro-Tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/Socorro-Tests/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/Socorro-Tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/Socorro-Tests/merges","archive_url":"https://api.github.com/repos/mozilla/Socorro-Tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/Socorro-Tests/downloads","issues_url":"https://api.github.com/repos/mozilla/Socorro-Tests/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/Socorro-Tests/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/Socorro-Tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/Socorro-Tests/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/Socorro-Tests/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/Socorro-Tests/deployments","created_at":"2011-05-06T15:56:47Z","updated_at":"2016-03-22T17:47:27Z","pushed_at":"2016-06-22T19:10:27Z","git_url":"git://github.com/mozilla/Socorro-Tests.git","ssh_url":"git@github.com:mozilla/Socorro-Tests.git","clone_url":"https://github.com/mozilla/Socorro-Tests.git","svn_url":"https://github.com/mozilla/Socorro-Tests","homepage":"","size":787,"stargazers_count":25,"watchers_count":25,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":2,"forks":40,"open_issues":2,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/382"},"html":{"href":"https://github.com/mozilla/Socorro-Tests/pull/382"},"issue":{"href":"https://api.github.com/repos/mozilla/Socorro-Tests/issues/382"},"comments":{"href":"https://api.github.com/repos/mozilla/Socorro-Tests/issues/382/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/382/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/Socorro-Tests/pulls/382/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/Socorro-Tests/statuses/739379f66607445413d16742939d4e3cc7463168"}}}}
{"actor":{"display_login":"stephendonner"}}