{"action":"created","comment":{"url":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/comments/72418375","id":72418375,"diff_hunk":"@@ -0,0 +1,124 @@\n+package org.arquillian.cube.docker.drone;\n+\n+import org.arquillian.cube.spi.Cube;\n+import org.arquillian.cube.spi.CubeRegistry;\n+import org.jboss.arquillian.core.api.annotation.Observes;\n+import org.jboss.arquillian.test.spi.TestResult;\n+import org.jboss.arquillian.test.spi.event.suite.After;\n+import org.jboss.arquillian.test.spi.event.suite.Before;\n+\n+import java.io.File;\n+import java.io.IOException;\n+import java.nio.file.Files;\n+import java.nio.file.Path;\n+import java.nio.file.Paths;\n+import java.nio.file.StandardCopyOption;\n+\n+/**\n+ * Vnc Cube is set to manual so we can start and stop before and after each test method.\n+ * Since recording is finished when container is stopped and we want to have one video per method, each time image is started and stopped.\n+ */\n+public class VncRecorderLifecycleManager {\n+\n+    private static final File DEFAULT_LOCATION_OUTPUT_MAVEN = new File(\"target\");\n+    private static final File DEFAULT_LOCATION_OUTPUT_GRADLE = new File(\"build\");\n+\n+    private static final File MAVEN_REPORT_DIR = new File(DEFAULT_LOCATION_OUTPUT_MAVEN, \"surefire-reports\");\n+    private static final File GRADLE_REPORT_DIR = new File(DEFAULT_LOCATION_OUTPUT_GRADLE, \"test-results\");\n+\n+    Cube vnc;","path":"docker/drone/src/main/java/org/arquillian/cube/docker/drone/VncRecorderLifecycleManager.java","position":29,"original_position":29,"commit_id":"006d8aabc4c57f416401e739269bc028ca0e1c25","original_commit_id":"006d8aabc4c57f416401e739269bc028ca0e1c25","user":{"login":"bartoszmajsak","id":719616,"avatar_url":"https://avatars.githubusercontent.com/u/719616?v=3","gravatar_id":"","url":"https://api.github.com/users/bartoszmajsak","html_url":"https://github.com/bartoszmajsak","followers_url":"https://api.github.com/users/bartoszmajsak/followers","following_url":"https://api.github.com/users/bartoszmajsak/following{/other_user}","gists_url":"https://api.github.com/users/bartoszmajsak/gists{/gist_id}","starred_url":"https://api.github.com/users/bartoszmajsak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartoszmajsak/subscriptions","organizations_url":"https://api.github.com/users/bartoszmajsak/orgs","repos_url":"https://api.github.com/users/bartoszmajsak/repos","events_url":"https://api.github.com/users/bartoszmajsak/events{/privacy}","received_events_url":"https://api.github.com/users/bartoszmajsak/received_events","type":"User","site_admin":false},"body":"I'm not sure if we should adjust anything in the code to facilitate testing needs to be honest. We could always improve design to make it testable instead of doing such a thing or `@VisibleForTesting` on some weird constructors which is quite often. Just my .2$","created_at":"2016-07-27T10:46:17Z","updated_at":"2016-07-27T10:46:17Z","html_url":"https://github.com/arquillian/arquillian-cube/pull/402#discussion_r72418375","pull_request_url":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/402","_links":{"self":{"href":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/comments/72418375"},"html":{"href":"https://github.com/arquillian/arquillian-cube/pull/402#discussion_r72418375"},"pull_request":{"href":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/402"}}},"pull_request":{"url":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/402","id":78979086,"html_url":"https://github.com/arquillian/arquillian-cube/pull/402","diff_url":"https://github.com/arquillian/arquillian-cube/pull/402.diff","patch_url":"https://github.com/arquillian/arquillian-cube/pull/402.patch","issue_url":"https://api.github.com/repos/arquillian/arquillian-cube/issues/402","number":402,"state":"open","locked":false,"title":"Adds cube-drone integration. Issue #385","user":{"login":"lordofthejars","id":1517153,"avatar_url":"https://avatars.githubusercontent.com/u/1517153?v=3","gravatar_id":"","url":"https://api.github.com/users/lordofthejars","html_url":"https://github.com/lordofthejars","followers_url":"https://api.github.com/users/lordofthejars/followers","following_url":"https://api.github.com/users/lordofthejars/following{/other_user}","gists_url":"https://api.github.com/users/lordofthejars/gists{/gist_id}","starred_url":"https://api.github.com/users/lordofthejars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lordofthejars/subscriptions","organizations_url":"https://api.github.com/users/lordofthejars/orgs","repos_url":"https://api.github.com/users/lordofthejars/repos","events_url":"https://api.github.com/users/lordofthejars/events{/privacy}","received_events_url":"https://api.github.com/users/lordofthejars/received_events","type":"User","site_admin":false},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/arquillian/arquillian-cube/402)\n<!-- Reviewable:end -->\n","created_at":"2016-07-27T07:46:57Z","updated_at":"2016-07-27T10:46:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c2e0e3eee838eb439ce4b488474938ce80caf05","assignee":{"login":"bartoszmajsak","id":719616,"avatar_url":"https://avatars.githubusercontent.com/u/719616?v=3","gravatar_id":"","url":"https://api.github.com/users/bartoszmajsak","html_url":"https://github.com/bartoszmajsak","followers_url":"https://api.github.com/users/bartoszmajsak/followers","following_url":"https://api.github.com/users/bartoszmajsak/following{/other_user}","gists_url":"https://api.github.com/users/bartoszmajsak/gists{/gist_id}","starred_url":"https://api.github.com/users/bartoszmajsak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartoszmajsak/subscriptions","organizations_url":"https://api.github.com/users/bartoszmajsak/orgs","repos_url":"https://api.github.com/users/bartoszmajsak/repos","events_url":"https://api.github.com/users/bartoszmajsak/events{/privacy}","received_events_url":"https://api.github.com/users/bartoszmajsak/received_events","type":"User","site_admin":false},"assignees":[{"login":"bartoszmajsak","id":719616,"avatar_url":"https://avatars.githubusercontent.com/u/719616?v=3","gravatar_id":"","url":"https://api.github.com/users/bartoszmajsak","html_url":"https://github.com/bartoszmajsak","followers_url":"https://api.github.com/users/bartoszmajsak/followers","following_url":"https://api.github.com/users/bartoszmajsak/following{/other_user}","gists_url":"https://api.github.com/users/bartoszmajsak/gists{/gist_id}","starred_url":"https://api.github.com/users/bartoszmajsak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartoszmajsak/subscriptions","organizations_url":"https://api.github.com/users/bartoszmajsak/orgs","repos_url":"https://api.github.com/users/bartoszmajsak/repos","events_url":"https://api.github.com/users/bartoszmajsak/events{/privacy}","received_events_url":"https://api.github.com/users/bartoszmajsak/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/402/commits","review_comments_url":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/402/comments","review_comment_url":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arquillian/arquillian-cube/issues/402/comments","statuses_url":"https://api.github.com/repos/arquillian/arquillian-cube/statuses/006d8aabc4c57f416401e739269bc028ca0e1c25","head":{"label":"lordofthejars:issue_385","ref":"issue_385","sha":"006d8aabc4c57f416401e739269bc028ca0e1c25","user":{"login":"lordofthejars","id":1517153,"avatar_url":"https://avatars.githubusercontent.com/u/1517153?v=3","gravatar_id":"","url":"https://api.github.com/users/lordofthejars","html_url":"https://github.com/lordofthejars","followers_url":"https://api.github.com/users/lordofthejars/followers","following_url":"https://api.github.com/users/lordofthejars/following{/other_user}","gists_url":"https://api.github.com/users/lordofthejars/gists{/gist_id}","starred_url":"https://api.github.com/users/lordofthejars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lordofthejars/subscriptions","organizations_url":"https://api.github.com/users/lordofthejars/orgs","repos_url":"https://api.github.com/users/lordofthejars/repos","events_url":"https://api.github.com/users/lordofthejars/events{/privacy}","received_events_url":"https://api.github.com/users/lordofthejars/received_events","type":"User","site_admin":false},"repo":{"id":49945362,"name":"arquillian-cube","full_name":"lordofthejars/arquillian-cube","owner":{"login":"lordofthejars","id":1517153,"avatar_url":"https://avatars.githubusercontent.com/u/1517153?v=3","gravatar_id":"","url":"https://api.github.com/users/lordofthejars","html_url":"https://github.com/lordofthejars","followers_url":"https://api.github.com/users/lordofthejars/followers","following_url":"https://api.github.com/users/lordofthejars/following{/other_user}","gists_url":"https://api.github.com/users/lordofthejars/gists{/gist_id}","starred_url":"https://api.github.com/users/lordofthejars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lordofthejars/subscriptions","organizations_url":"https://api.github.com/users/lordofthejars/orgs","repos_url":"https://api.github.com/users/lordofthejars/repos","events_url":"https://api.github.com/users/lordofthejars/events{/privacy}","received_events_url":"https://api.github.com/users/lordofthejars/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lordofthejars/arquillian-cube","description":"Arquillian Docker","fork":true,"url":"https://api.github.com/repos/lordofthejars/arquillian-cube","forks_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/forks","keys_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/teams","hooks_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/hooks","issue_events_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/issues/events{/number}","events_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/events","assignees_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/assignees{/user}","branches_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/branches{/branch}","tags_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/tags","blobs_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/git/refs{/sha}","trees_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/statuses/{sha}","languages_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/languages","stargazers_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/stargazers","contributors_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/contributors","subscribers_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/subscribers","subscription_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/subscription","commits_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/commits{/sha}","git_commits_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/git/commits{/sha}","comments_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/comments{/number}","issue_comment_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/issues/comments{/number}","contents_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/contents/{+path}","compare_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/merges","archive_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/downloads","issues_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/issues{/number}","pulls_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/pulls{/number}","milestones_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/milestones{/number}","notifications_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/labels{/name}","releases_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/releases{/id}","deployments_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/deployments","created_at":"2016-01-19T10:32:41Z","updated_at":"2016-01-19T10:32:42Z","pushed_at":"2016-07-27T07:46:34Z","git_url":"git://github.com/lordofthejars/arquillian-cube.git","ssh_url":"git@github.com:lordofthejars/arquillian-cube.git","clone_url":"https://github.com/lordofthejars/arquillian-cube.git","svn_url":"https://github.com/lordofthejars/arquillian-cube","homepage":null,"size":1293,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arquillian:master","ref":"master","sha":"6dae064f2907fd3347d75207141e6f258ee67ac4","user":{"login":"arquillian","id":330981,"avatar_url":"https://avatars.githubusercontent.com/u/330981?v=3","gravatar_id":"","url":"https://api.github.com/users/arquillian","html_url":"https://github.com/arquillian","followers_url":"https://api.github.com/users/arquillian/followers","following_url":"https://api.github.com/users/arquillian/following{/other_user}","gists_url":"https://api.github.com/users/arquillian/gists{/gist_id}","starred_url":"https://api.github.com/users/arquillian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arquillian/subscriptions","organizations_url":"https://api.github.com/users/arquillian/orgs","repos_url":"https://api.github.com/users/arquillian/repos","events_url":"https://api.github.com/users/arquillian/events{/privacy}","received_events_url":"https://api.github.com/users/arquillian/received_events","type":"Organization","site_admin":false},"repo":{"id":25573964,"name":"arquillian-cube","full_name":"arquillian/arquillian-cube","owner":{"login":"arquillian","id":330981,"avatar_url":"https://avatars.githubusercontent.com/u/330981?v=3","gravatar_id":"","url":"https://api.github.com/users/arquillian","html_url":"https://github.com/arquillian","followers_url":"https://api.github.com/users/arquillian/followers","following_url":"https://api.github.com/users/arquillian/following{/other_user}","gists_url":"https://api.github.com/users/arquillian/gists{/gist_id}","starred_url":"https://api.github.com/users/arquillian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arquillian/subscriptions","organizations_url":"https://api.github.com/users/arquillian/orgs","repos_url":"https://api.github.com/users/arquillian/repos","events_url":"https://api.github.com/users/arquillian/events{/privacy}","received_events_url":"https://api.github.com/users/arquillian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arquillian/arquillian-cube","description":"Arquillian Docker","fork":false,"url":"https://api.github.com/repos/arquillian/arquillian-cube","forks_url":"https://api.github.com/repos/arquillian/arquillian-cube/forks","keys_url":"https://api.github.com/repos/arquillian/arquillian-cube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arquillian/arquillian-cube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arquillian/arquillian-cube/teams","hooks_url":"https://api.github.com/repos/arquillian/arquillian-cube/hooks","issue_events_url":"https://api.github.com/repos/arquillian/arquillian-cube/issues/events{/number}","events_url":"https://api.github.com/repos/arquillian/arquillian-cube/events","assignees_url":"https://api.github.com/repos/arquillian/arquillian-cube/assignees{/user}","branches_url":"https://api.github.com/repos/arquillian/arquillian-cube/branches{/branch}","tags_url":"https://api.github.com/repos/arquillian/arquillian-cube/tags","blobs_url":"https://api.github.com/repos/arquillian/arquillian-cube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arquillian/arquillian-cube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arquillian/arquillian-cube/git/refs{/sha}","trees_url":"https://api.github.com/repos/arquillian/arquillian-cube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arquillian/arquillian-cube/statuses/{sha}","languages_url":"https://api.github.com/repos/arquillian/arquillian-cube/languages","stargazers_url":"https://api.github.com/repos/arquillian/arquillian-cube/stargazers","contributors_url":"https://api.github.com/repos/arquillian/arquillian-cube/contributors","subscribers_url":"https://api.github.com/repos/arquillian/arquillian-cube/subscribers","subscription_url":"https://api.github.com/repos/arquillian/arquillian-cube/subscription","commits_url":"https://api.github.com/repos/arquillian/arquillian-cube/commits{/sha}","git_commits_url":"https://api.github.com/repos/arquillian/arquillian-cube/git/commits{/sha}","comments_url":"https://api.github.com/repos/arquillian/arquillian-cube/comments{/number}","issue_comment_url":"https://api.github.com/repos/arquillian/arquillian-cube/issues/comments{/number}","contents_url":"https://api.github.com/repos/arquillian/arquillian-cube/contents/{+path}","compare_url":"https://api.github.com/repos/arquillian/arquillian-cube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arquillian/arquillian-cube/merges","archive_url":"https://api.github.com/repos/arquillian/arquillian-cube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arquillian/arquillian-cube/downloads","issues_url":"https://api.github.com/repos/arquillian/arquillian-cube/issues{/number}","pulls_url":"https://api.github.com/repos/arquillian/arquillian-cube/pulls{/number}","milestones_url":"https://api.github.com/repos/arquillian/arquillian-cube/milestones{/number}","notifications_url":"https://api.github.com/repos/arquillian/arquillian-cube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arquillian/arquillian-cube/labels{/name}","releases_url":"https://api.github.com/repos/arquillian/arquillian-cube/releases{/id}","deployments_url":"https://api.github.com/repos/arquillian/arquillian-cube/deployments","created_at":"2014-10-22T09:47:10Z","updated_at":"2016-06-30T12:38:55Z","pushed_at":"2016-07-27T07:47:00Z","git_url":"git://github.com/arquillian/arquillian-cube.git","ssh_url":"git@github.com:arquillian/arquillian-cube.git","clone_url":"https://github.com/arquillian/arquillian-cube.git","svn_url":"https://github.com/arquillian/arquillian-cube","homepage":null,"size":1358,"stargazers_count":45,"watchers_count":45,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":34,"forks":37,"open_issues":34,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/402"},"html":{"href":"https://github.com/arquillian/arquillian-cube/pull/402"},"issue":{"href":"https://api.github.com/repos/arquillian/arquillian-cube/issues/402"},"comments":{"href":"https://api.github.com/repos/arquillian/arquillian-cube/issues/402/comments"},"review_comments":{"href":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/402/comments"},"review_comment":{"href":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/402/commits"},"statuses":{"href":"https://api.github.com/repos/arquillian/arquillian-cube/statuses/006d8aabc4c57f416401e739269bc028ca0e1c25"}}}}
{"actor":{"display_login":"bartoszmajsak"}}