{"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/comments/80643516","pull_request_review_id":1680967,"id":80643516,"diff_hunk":"@@ -33,10 +33,9 @@ reset_classic() {\n \n reset_all_snap() {\n     # remove all leftover snaps\n-    . $TESTSLIB/gadget.sh\n-    gadget_name=$(get_gadget_name)\n+    . $TESTSLIB/names.sh\n     for snap in $(ls /snap); do\n-        if [ \"$snap\" = \"bin\" ] || [ \"$snap\" = \"$gadget_name\" ] ||  [ \"$snap\" = \"${gadget_name}-kernel\" ] || [ \"$snap\" = \"ubuntu-core\" ]; then\n+        if [ \"$snap\" = \"bin\" ] || [ \"$snap\" = \"$gadget_name\" ] ||  [ \"$snap\" = \"${kernel_name}\" ] || [ \"$snap\" = \"ubuntu-core\" ]; then","path":"tests/lib/reset.sh","position":null,"original_position":9,"commit_id":"ed17fbf6a6ee8b50fcb104e51b7332db0e512aad","original_commit_id":"898add2db23b56f1d92b95b41efa269fcc7c253c","user":{"login":"fgimenez","id":70376,"avatar_url":"https://avatars.githubusercontent.com/u/70376?v=3","gravatar_id":"","url":"https://api.github.com/users/fgimenez","html_url":"https://github.com/fgimenez","followers_url":"https://api.github.com/users/fgimenez/followers","following_url":"https://api.github.com/users/fgimenez/following{/other_user}","gists_url":"https://api.github.com/users/fgimenez/gists{/gist_id}","starred_url":"https://api.github.com/users/fgimenez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgimenez/subscriptions","organizations_url":"https://api.github.com/users/fgimenez/orgs","repos_url":"https://api.github.com/users/fgimenez/repos","events_url":"https://api.github.com/users/fgimenez/events{/privacy}","received_events_url":"https://api.github.com/users/fgimenez/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2016-09-27T08:34:09Z","updated_at":"2016-09-27T08:37:38Z","html_url":"https://github.com/snapcore/snapd/pull/1918#discussion_r80643516","pull_request_url":"https://api.github.com/repos/snapcore/snapd/pulls/1918","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments/80643516"},"html":{"href":"https://github.com/snapcore/snapd/pull/1918#discussion_r80643516"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/1918"}}},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/1918","id":85375081,"html_url":"https://github.com/snapcore/snapd/pull/1918","diff_url":"https://github.com/snapcore/snapd/pull/1918.diff","patch_url":"https://github.com/snapcore/snapd/pull/1918.patch","issue_url":"https://api.github.com/repos/snapcore/snapd/issues/1918","number":1918,"state":"open","locked":false,"title":"tests: add external-ubuntu-core spread backend","user":{"login":"fgimenez","id":70376,"avatar_url":"https://avatars.githubusercontent.com/u/70376?v=3","gravatar_id":"","url":"https://api.github.com/users/fgimenez","html_url":"https://github.com/fgimenez","followers_url":"https://api.github.com/users/fgimenez/followers","following_url":"https://api.github.com/users/fgimenez/following{/other_user}","gists_url":"https://api.github.com/users/fgimenez/gists{/gist_id}","starred_url":"https://api.github.com/users/fgimenez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgimenez/subscriptions","organizations_url":"https://api.github.com/users/fgimenez/orgs","repos_url":"https://api.github.com/users/fgimenez/repos","events_url":"https://api.github.com/users/fgimenez/events{/privacy}","received_events_url":"https://api.github.com/users/fgimenez/received_events","type":"User","site_admin":false},"body":"This backend will enable the execution of the spread suite on all-snap running instances, so that the image validation can be automated.\r\n\r\nWith the current image state, it relies on the previous setup of the default user and network on the instances through console-conf and the execution of `tests/lib/adhoc-ubuntu-core/prepare-instance.sh` script included in this changeset. It also needs the `SPREAD_ADHOC_UC_ADDRESS` environment variable set on the host with the address and port of the running instance, something like `localhost:8023`.\r\n\r\nCurrently, the backend includes two systems, `ubuntu-core-16-device-amd64` and `ubuntu-core-16-device-arm`, which encompasses the armhf and arm64 architectures.","created_at":"2016-09-15T09:56:34Z","updated_at":"2016-09-27T08:37:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b427bcc03966c55d143ca417d7cb6a1483e08729","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapd/pulls/1918/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapd/pulls/1918/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapd/issues/1918/comments","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/ed17fbf6a6ee8b50fcb104e51b7332db0e512aad","head":{"label":"fgimenez:spread-validate-image","ref":"spread-validate-image","sha":"ed17fbf6a6ee8b50fcb104e51b7332db0e512aad","user":{"login":"fgimenez","id":70376,"avatar_url":"https://avatars.githubusercontent.com/u/70376?v=3","gravatar_id":"","url":"https://api.github.com/users/fgimenez","html_url":"https://github.com/fgimenez","followers_url":"https://api.github.com/users/fgimenez/followers","following_url":"https://api.github.com/users/fgimenez/following{/other_user}","gists_url":"https://api.github.com/users/fgimenez/gists{/gist_id}","starred_url":"https://api.github.com/users/fgimenez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgimenez/subscriptions","organizations_url":"https://api.github.com/users/fgimenez/orgs","repos_url":"https://api.github.com/users/fgimenez/repos","events_url":"https://api.github.com/users/fgimenez/events{/privacy}","received_events_url":"https://api.github.com/users/fgimenez/received_events","type":"User","site_admin":false},"repo":{"id":45098487,"name":"snappy","full_name":"fgimenez/snappy","owner":{"login":"fgimenez","id":70376,"avatar_url":"https://avatars.githubusercontent.com/u/70376?v=3","gravatar_id":"","url":"https://api.github.com/users/fgimenez","html_url":"https://github.com/fgimenez","followers_url":"https://api.github.com/users/fgimenez/followers","following_url":"https://api.github.com/users/fgimenez/following{/other_user}","gists_url":"https://api.github.com/users/fgimenez/gists{/gist_id}","starred_url":"https://api.github.com/users/fgimenez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgimenez/subscriptions","organizations_url":"https://api.github.com/users/fgimenez/orgs","repos_url":"https://api.github.com/users/fgimenez/repos","events_url":"https://api.github.com/users/fgimenez/events{/privacy}","received_events_url":"https://api.github.com/users/fgimenez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fgimenez/snappy","description":"Snappy is the software at the heart of Ubuntu Core.","fork":true,"url":"https://api.github.com/repos/fgimenez/snappy","forks_url":"https://api.github.com/repos/fgimenez/snappy/forks","keys_url":"https://api.github.com/repos/fgimenez/snappy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fgimenez/snappy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fgimenez/snappy/teams","hooks_url":"https://api.github.com/repos/fgimenez/snappy/hooks","issue_events_url":"https://api.github.com/repos/fgimenez/snappy/issues/events{/number}","events_url":"https://api.github.com/repos/fgimenez/snappy/events","assignees_url":"https://api.github.com/repos/fgimenez/snappy/assignees{/user}","branches_url":"https://api.github.com/repos/fgimenez/snappy/branches{/branch}","tags_url":"https://api.github.com/repos/fgimenez/snappy/tags","blobs_url":"https://api.github.com/repos/fgimenez/snappy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fgimenez/snappy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fgimenez/snappy/git/refs{/sha}","trees_url":"https://api.github.com/repos/fgimenez/snappy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fgimenez/snappy/statuses/{sha}","languages_url":"https://api.github.com/repos/fgimenez/snappy/languages","stargazers_url":"https://api.github.com/repos/fgimenez/snappy/stargazers","contributors_url":"https://api.github.com/repos/fgimenez/snappy/contributors","subscribers_url":"https://api.github.com/repos/fgimenez/snappy/subscribers","subscription_url":"https://api.github.com/repos/fgimenez/snappy/subscription","commits_url":"https://api.github.com/repos/fgimenez/snappy/commits{/sha}","git_commits_url":"https://api.github.com/repos/fgimenez/snappy/git/commits{/sha}","comments_url":"https://api.github.com/repos/fgimenez/snappy/comments{/number}","issue_comment_url":"https://api.github.com/repos/fgimenez/snappy/issues/comments{/number}","contents_url":"https://api.github.com/repos/fgimenez/snappy/contents/{+path}","compare_url":"https://api.github.com/repos/fgimenez/snappy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fgimenez/snappy/merges","archive_url":"https://api.github.com/repos/fgimenez/snappy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fgimenez/snappy/downloads","issues_url":"https://api.github.com/repos/fgimenez/snappy/issues{/number}","pulls_url":"https://api.github.com/repos/fgimenez/snappy/pulls{/number}","milestones_url":"https://api.github.com/repos/fgimenez/snappy/milestones{/number}","notifications_url":"https://api.github.com/repos/fgimenez/snappy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fgimenez/snappy/labels{/name}","releases_url":"https://api.github.com/repos/fgimenez/snappy/releases{/id}","deployments_url":"https://api.github.com/repos/fgimenez/snappy/deployments","created_at":"2015-10-28T08:23:58Z","updated_at":"2016-01-14T08:49:44Z","pushed_at":"2016-09-27T08:37:26Z","git_url":"git://github.com/fgimenez/snappy.git","ssh_url":"git@github.com:fgimenez/snappy.git","clone_url":"https://github.com/fgimenez/snappy.git","svn_url":"https://github.com/fgimenez/snappy","homepage":null,"size":36340,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"9a3ad2937321aba8fb95b0d4f73ea37305e214c2","user":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars.githubusercontent.com/u/19532717?v=3","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":44672744,"name":"snapd","full_name":"snapcore/snapd","owner":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars.githubusercontent.com/u/19532717?v=3","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snapcore/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":false,"url":"https://api.github.com/repos/snapcore/snapd","forks_url":"https://api.github.com/repos/snapcore/snapd/forks","keys_url":"https://api.github.com/repos/snapcore/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapd/teams","hooks_url":"https://api.github.com/repos/snapcore/snapd/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapd/events","assignees_url":"https://api.github.com/repos/snapcore/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapd/tags","blobs_url":"https://api.github.com/repos/snapcore/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapd/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapd/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapd/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapd/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapd/subscription","commits_url":"https://api.github.com/repos/snapcore/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapd/merges","archive_url":"https://api.github.com/repos/snapcore/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapd/downloads","issues_url":"https://api.github.com/repos/snapcore/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapd/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapd/deployments","created_at":"2015-10-21T11:51:46Z","updated_at":"2016-09-26T15:46:44Z","pushed_at":"2016-09-27T08:37:27Z","git_url":"git://github.com/snapcore/snapd.git","ssh_url":"git@github.com:snapcore/snapd.git","clone_url":"https://github.com/snapcore/snapd.git","svn_url":"https://github.com/snapcore/snapd","homepage":"","size":38969,"stargazers_count":399,"watchers_count":399,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":106,"mirror_url":null,"open_issues_count":16,"forks":106,"open_issues":16,"watchers":399,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/1918"},"html":{"href":"https://github.com/snapcore/snapd/pull/1918"},"issue":{"href":"https://api.github.com/repos/snapcore/snapd/issues/1918"},"comments":{"href":"https://api.github.com/repos/snapcore/snapd/issues/1918/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/1918/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/1918/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapd/statuses/ed17fbf6a6ee8b50fcb104e51b7332db0e512aad"}}}}
{"actor":{"display_login":"fgimenez"}}