{"action":"created","comment":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments/53641984","id":53641984,"diff_hunk":"@@ -1,49 +1,51 @@\n-'use strict';\n+(function() {\n+  'use strict';","path":"generators/client/templates/src/main/webapp/app/_app.config.js","position":3,"original_position":3,"commit_id":"5d80978122cece145e985f2104bd83d87ad59194","original_commit_id":"5d80978122cece145e985f2104bd83d87ad59194","user":{"login":"deepu105","id":1107223,"avatar_url":"https://avatars.githubusercontent.com/u/1107223?v=3","gravatar_id":"","url":"https://api.github.com/users/deepu105","html_url":"https://github.com/deepu105","followers_url":"https://api.github.com/users/deepu105/followers","following_url":"https://api.github.com/users/deepu105/following{/other_user}","gists_url":"https://api.github.com/users/deepu105/gists{/gist_id}","starred_url":"https://api.github.com/users/deepu105/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepu105/subscriptions","organizations_url":"https://api.github.com/users/deepu105/orgs","repos_url":"https://api.github.com/users/deepu105/repos","events_url":"https://api.github.com/users/deepu105/events{/privacy}","received_events_url":"https://api.github.com/users/deepu105/received_events","type":"User","site_admin":false},"body":"@mraible since these are set on closure function for the whole file it should be fine as its similar to having at the file level IMO ofcourse we need not do for each function one closure per file would do. It will also avoid any issue when concatenating strict and non strict files","created_at":"2016-02-22T15:39:28Z","updated_at":"2016-02-22T15:39:28Z","html_url":"https://github.com/jhipster/generator-jhipster/pull/2959#discussion_r53641984","pull_request_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/2959","_links":{"self":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments/53641984"},"html":{"href":"https://github.com/jhipster/generator-jhipster/pull/2959#discussion_r53641984"},"pull_request":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/2959"}}},"pull_request":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/2959","id":60173505,"html_url":"https://github.com/jhipster/generator-jhipster/pull/2959","diff_url":"https://github.com/jhipster/generator-jhipster/pull/2959.diff","patch_url":"https://github.com/jhipster/generator-jhipster/pull/2959.patch","issue_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/2959","number":2959,"state":"open","locked":false,"title":"JohnPapa Style Guide : JavaScript Closures (IIFE)","user":{"login":"wmarques","id":1577727,"avatar_url":"https://avatars.githubusercontent.com/u/1577727?v=3","gravatar_id":"","url":"https://api.github.com/users/wmarques","html_url":"https://github.com/wmarques","followers_url":"https://api.github.com/users/wmarques/followers","following_url":"https://api.github.com/users/wmarques/following{/other_user}","gists_url":"https://api.github.com/users/wmarques/gists{/gist_id}","starred_url":"https://api.github.com/users/wmarques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmarques/subscriptions","organizations_url":"https://api.github.com/users/wmarques/orgs","repos_url":"https://api.github.com/users/wmarques/repos","events_url":"https://api.github.com/users/wmarques/events{/privacy}","received_events_url":"https://api.github.com/users/wmarques/received_events","type":"User","site_admin":false},"body":"I'm currently working on adapting JHipster with Johnpapa's Angular 1 styleguide as suggested in  #2271 .\r\nFirst rule I applied is wrapping all Angular components in IIFE functions, to prevent variables collisions : [Rule Y010](https://github.com/johnpapa/angular-styleguide/blob/master/a1/README.md#style-y010)","created_at":"2016-02-22T13:35:23Z","updated_at":"2016-02-22T15:39:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c9cdd9dea9add86f3aa020025dcea7a98cfae12","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/2959/commits","review_comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/2959/comments","review_comment_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/2959/comments","statuses_url":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/5d80978122cece145e985f2104bd83d87ad59194","head":{"label":"wmarques:johnpapa-IIFE","ref":"johnpapa-IIFE","sha":"5d80978122cece145e985f2104bd83d87ad59194","user":{"login":"wmarques","id":1577727,"avatar_url":"https://avatars.githubusercontent.com/u/1577727?v=3","gravatar_id":"","url":"https://api.github.com/users/wmarques","html_url":"https://github.com/wmarques","followers_url":"https://api.github.com/users/wmarques/followers","following_url":"https://api.github.com/users/wmarques/following{/other_user}","gists_url":"https://api.github.com/users/wmarques/gists{/gist_id}","starred_url":"https://api.github.com/users/wmarques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmarques/subscriptions","organizations_url":"https://api.github.com/users/wmarques/orgs","repos_url":"https://api.github.com/users/wmarques/repos","events_url":"https://api.github.com/users/wmarques/events{/privacy}","received_events_url":"https://api.github.com/users/wmarques/received_events","type":"User","site_admin":false},"repo":{"id":51754884,"name":"generator-jhipster","full_name":"wmarques/generator-jhipster","owner":{"login":"wmarques","id":1577727,"avatar_url":"https://avatars.githubusercontent.com/u/1577727?v=3","gravatar_id":"","url":"https://api.github.com/users/wmarques","html_url":"https://github.com/wmarques","followers_url":"https://api.github.com/users/wmarques/followers","following_url":"https://api.github.com/users/wmarques/following{/other_user}","gists_url":"https://api.github.com/users/wmarques/gists{/gist_id}","starred_url":"https://api.github.com/users/wmarques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmarques/subscriptions","organizations_url":"https://api.github.com/users/wmarques/orgs","repos_url":"https://api.github.com/users/wmarques/repos","events_url":"https://api.github.com/users/wmarques/events{/privacy}","received_events_url":"https://api.github.com/users/wmarques/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wmarques/generator-jhipster","description":"Hipster stack for Java developers. Yeoman + Maven + Spring + AngularJS in one handy generator.","fork":true,"url":"https://api.github.com/repos/wmarques/generator-jhipster","forks_url":"https://api.github.com/repos/wmarques/generator-jhipster/forks","keys_url":"https://api.github.com/repos/wmarques/generator-jhipster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmarques/generator-jhipster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmarques/generator-jhipster/teams","hooks_url":"https://api.github.com/repos/wmarques/generator-jhipster/hooks","issue_events_url":"https://api.github.com/repos/wmarques/generator-jhipster/issues/events{/number}","events_url":"https://api.github.com/repos/wmarques/generator-jhipster/events","assignees_url":"https://api.github.com/repos/wmarques/generator-jhipster/assignees{/user}","branches_url":"https://api.github.com/repos/wmarques/generator-jhipster/branches{/branch}","tags_url":"https://api.github.com/repos/wmarques/generator-jhipster/tags","blobs_url":"https://api.github.com/repos/wmarques/generator-jhipster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmarques/generator-jhipster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmarques/generator-jhipster/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmarques/generator-jhipster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmarques/generator-jhipster/statuses/{sha}","languages_url":"https://api.github.com/repos/wmarques/generator-jhipster/languages","stargazers_url":"https://api.github.com/repos/wmarques/generator-jhipster/stargazers","contributors_url":"https://api.github.com/repos/wmarques/generator-jhipster/contributors","subscribers_url":"https://api.github.com/repos/wmarques/generator-jhipster/subscribers","subscription_url":"https://api.github.com/repos/wmarques/generator-jhipster/subscription","commits_url":"https://api.github.com/repos/wmarques/generator-jhipster/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmarques/generator-jhipster/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmarques/generator-jhipster/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmarques/generator-jhipster/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmarques/generator-jhipster/contents/{+path}","compare_url":"https://api.github.com/repos/wmarques/generator-jhipster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmarques/generator-jhipster/merges","archive_url":"https://api.github.com/repos/wmarques/generator-jhipster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmarques/generator-jhipster/downloads","issues_url":"https://api.github.com/repos/wmarques/generator-jhipster/issues{/number}","pulls_url":"https://api.github.com/repos/wmarques/generator-jhipster/pulls{/number}","milestones_url":"https://api.github.com/repos/wmarques/generator-jhipster/milestones{/number}","notifications_url":"https://api.github.com/repos/wmarques/generator-jhipster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmarques/generator-jhipster/labels{/name}","releases_url":"https://api.github.com/repos/wmarques/generator-jhipster/releases{/id}","deployments_url":"https://api.github.com/repos/wmarques/generator-jhipster/deployments","created_at":"2016-02-15T12:45:40Z","updated_at":"2016-02-15T12:45:43Z","pushed_at":"2016-02-22T15:01:30Z","git_url":"git://github.com/wmarques/generator-jhipster.git","ssh_url":"git@github.com:wmarques/generator-jhipster.git","clone_url":"https://github.com/wmarques/generator-jhipster.git","svn_url":"https://github.com/wmarques/generator-jhipster","homepage":"http://jhipster.github.io","size":10168,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jhipster:master","ref":"master","sha":"9c256f0a2ca43f628e47738ef25a1a801ee80a98","user":{"login":"jhipster","id":6059488,"avatar_url":"https://avatars.githubusercontent.com/u/6059488?v=3","gravatar_id":"","url":"https://api.github.com/users/jhipster","html_url":"https://github.com/jhipster","followers_url":"https://api.github.com/users/jhipster/followers","following_url":"https://api.github.com/users/jhipster/following{/other_user}","gists_url":"https://api.github.com/users/jhipster/gists{/gist_id}","starred_url":"https://api.github.com/users/jhipster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhipster/subscriptions","organizations_url":"https://api.github.com/users/jhipster/orgs","repos_url":"https://api.github.com/users/jhipster/repos","events_url":"https://api.github.com/users/jhipster/events{/privacy}","received_events_url":"https://api.github.com/users/jhipster/received_events","type":"Organization","site_admin":false},"repo":{"id":13753636,"name":"generator-jhipster","full_name":"jhipster/generator-jhipster","owner":{"login":"jhipster","id":6059488,"avatar_url":"https://avatars.githubusercontent.com/u/6059488?v=3","gravatar_id":"","url":"https://api.github.com/users/jhipster","html_url":"https://github.com/jhipster","followers_url":"https://api.github.com/users/jhipster/followers","following_url":"https://api.github.com/users/jhipster/following{/other_user}","gists_url":"https://api.github.com/users/jhipster/gists{/gist_id}","starred_url":"https://api.github.com/users/jhipster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhipster/subscriptions","organizations_url":"https://api.github.com/users/jhipster/orgs","repos_url":"https://api.github.com/users/jhipster/repos","events_url":"https://api.github.com/users/jhipster/events{/privacy}","received_events_url":"https://api.github.com/users/jhipster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jhipster/generator-jhipster","description":"Hipster stack for Java developers. Yeoman + Maven + Spring + AngularJS in one handy generator.","fork":false,"url":"https://api.github.com/repos/jhipster/generator-jhipster","forks_url":"https://api.github.com/repos/jhipster/generator-jhipster/forks","keys_url":"https://api.github.com/repos/jhipster/generator-jhipster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhipster/generator-jhipster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhipster/generator-jhipster/teams","hooks_url":"https://api.github.com/repos/jhipster/generator-jhipster/hooks","issue_events_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/events{/number}","events_url":"https://api.github.com/repos/jhipster/generator-jhipster/events","assignees_url":"https://api.github.com/repos/jhipster/generator-jhipster/assignees{/user}","branches_url":"https://api.github.com/repos/jhipster/generator-jhipster/branches{/branch}","tags_url":"https://api.github.com/repos/jhipster/generator-jhipster/tags","blobs_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/{sha}","languages_url":"https://api.github.com/repos/jhipster/generator-jhipster/languages","stargazers_url":"https://api.github.com/repos/jhipster/generator-jhipster/stargazers","contributors_url":"https://api.github.com/repos/jhipster/generator-jhipster/contributors","subscribers_url":"https://api.github.com/repos/jhipster/generator-jhipster/subscribers","subscription_url":"https://api.github.com/repos/jhipster/generator-jhipster/subscription","commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhipster/generator-jhipster/contents/{+path}","compare_url":"https://api.github.com/repos/jhipster/generator-jhipster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhipster/generator-jhipster/merges","archive_url":"https://api.github.com/repos/jhipster/generator-jhipster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhipster/generator-jhipster/downloads","issues_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues{/number}","pulls_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls{/number}","milestones_url":"https://api.github.com/repos/jhipster/generator-jhipster/milestones{/number}","notifications_url":"https://api.github.com/repos/jhipster/generator-jhipster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhipster/generator-jhipster/labels{/name}","releases_url":"https://api.github.com/repos/jhipster/generator-jhipster/releases{/id}","deployments_url":"https://api.github.com/repos/jhipster/generator-jhipster/deployments","created_at":"2013-10-21T20:07:22Z","updated_at":"2016-02-22T11:40:30Z","pushed_at":"2016-02-22T15:03:05Z","git_url":"git://github.com/jhipster/generator-jhipster.git","ssh_url":"git@github.com:jhipster/generator-jhipster.git","clone_url":"https://github.com/jhipster/generator-jhipster.git","svn_url":"https://github.com/jhipster/generator-jhipster","homepage":"http://jhipster.github.io","size":12933,"stargazers_count":3474,"watchers_count":3474,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":786,"mirror_url":null,"open_issues_count":47,"forks":786,"open_issues":47,"watchers":3474,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/2959"},"html":{"href":"https://github.com/jhipster/generator-jhipster/pull/2959"},"issue":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/issues/2959"},"comments":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/issues/2959/comments"},"review_comments":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/2959/comments"},"review_comment":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/2959/commits"},"statuses":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/5d80978122cece145e985f2104bd83d87ad59194"}}}}