{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/frontend/issues/14110","repository_url":"https://api.github.com/repos/guardian/frontend","labels_url":"https://api.github.com/repos/guardian/frontend/issues/14110/labels{/name}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/14110/comments","events_url":"https://api.github.com/repos/guardian/frontend/issues/14110/events","html_url":"https://github.com/guardian/frontend/pull/14110","id":172975513,"number":14110,"title":"Enable email format for all LiveBlogs, including Minute pages","user":{"login":"katebee","id":8607683,"avatar_url":"https://avatars.githubusercontent.com/u/8607683?v=3","gravatar_id":"","url":"https://api.github.com/users/katebee","html_url":"https://github.com/katebee","followers_url":"https://api.github.com/users/katebee/followers","following_url":"https://api.github.com/users/katebee/following{/other_user}","gists_url":"https://api.github.com/users/katebee/gists{/gist_id}","starred_url":"https://api.github.com/users/katebee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katebee/subscriptions","organizations_url":"https://api.github.com/users/katebee/orgs","repos_url":"https://api.github.com/users/katebee/repos","events_url":"https://api.github.com/users/katebee/events{/privacy}","received_events_url":"https://api.github.com/users/katebee/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-08-24T14:59:23Z","updated_at":"2016-08-26T16:53:23Z","closed_at":"2016-08-26T16:50:30Z","pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/14110","html_url":"https://github.com/guardian/frontend/pull/14110","diff_url":"https://github.com/guardian/frontend/pull/14110.diff","patch_url":"https://github.com/guardian/frontend/pull/14110.patch"},"body":"Alternate name: 404NoMore\r\n\r\n## What does this change?\r\n\r\n`/email` for all! 🚀 (or at least, all LiveBlogs)\r\n\r\n**Changes some 404 pages to email formatted content**\r\nAffects requests to LiveBlog pages when requested with `/email` appended.\r\nAll articles (including LiveBlogs) can now also have `?format=email` as the query param, which will also return the email format\r\n\r\nThe US Minute currently has an email format: \r\nhttps://www.theguardian.com/us-news/live/2016/aug/23/magical-missing-trump-voters/email\r\n\r\nOther Minute pages do not have one; appending **/email** to the URL results in a 404:\r\nhttps://www.theguardian.com/sport/live/2016/aug/20/the-olympic-games-minute-2016-bolts-triple-treble-triumph\r\n\r\nThis PR makes it possible to receive a rendered email page for all LiveBlogs, based on the template built for the *US Campaign Minute*. (Minute pages are a subset of LiveBlogs, they don't have their own `isMinute` flag)\r\n\r\n## What is the value of this and can you measure success?\r\n\r\n- Able to email any Minute series, without giving the webpage all the *US Campaign Minute* specific stylings\r\n- Editors will be able to create Minute format emails (for scaping by ExactTarget)\r\n- Ever want to email someone the Olympic Games Minute 2016? Now you can\r\n- You can even email a whole LiveBlog, if you like long reads (e.g. this https://www.theguardian.com/world/live/2016/aug/24/italy-terremoto-earthquake-buildings-collapse-amatrice-rome-people-trapped/email)\r\n- `?format=email` will also work: \r\nhttps://www.theguardian.com/world/live/2016/aug/24/italy-terremoto-earthquake-buildings-collapse-amatrice-rome-people-trapped?format=email\r\n\r\n## Does this affect other platforms - Amp, Apps, etc?\r\n\r\nNope.\r\n\r\n## Screenshots\r\n\r\nThe Euro Minute (left) 🏆  Random football LiveBlog (middle) ⚽  The Olympics Minute (Right)🏅\r\n<img width=\"963\" alt=\"picture 199\" src=\"https://cloud.githubusercontent.com/assets/8607683/17934284/37c3409a-6a0f-11e6-87dc-0909fbc6170a.png\">\r\n\r\n\r\n## Request for comment\r\n\r\n@samdesborough @joelochlann \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/guardian/frontend/issues/comments/242789625","html_url":"https://github.com/guardian/frontend/pull/14110#issuecomment-242789625","issue_url":"https://api.github.com/repos/guardian/frontend/issues/14110","id":242789625,"user":{"login":"johnduffell","id":7304387,"avatar_url":"https://avatars.githubusercontent.com/u/7304387?v=3","gravatar_id":"","url":"https://api.github.com/users/johnduffell","html_url":"https://github.com/johnduffell","followers_url":"https://api.github.com/users/johnduffell/followers","following_url":"https://api.github.com/users/johnduffell/following{/other_user}","gists_url":"https://api.github.com/users/johnduffell/gists{/gist_id}","starred_url":"https://api.github.com/users/johnduffell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnduffell/subscriptions","organizations_url":"https://api.github.com/users/johnduffell/orgs","repos_url":"https://api.github.com/users/johnduffell/repos","events_url":"https://api.github.com/users/johnduffell/events{/privacy}","received_events_url":"https://api.github.com/users/johnduffell/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T16:53:23Z","updated_at":"2016-08-26T16:53:23Z","body":"looks good, but you might need to tweak the VCL in fastly a little.\r\nAt the moment it only lets params through if you have page in the params.  This is to strip campaign codes out so we don't split the cache.  If you never need campaign codes, you can just whitelist format as well, however if you need format and a campaign code (I guess not) then you'll have to be more clever.\r\nHowever, it's only a regex, so no biggie."}}
{"actor":{"display_login":"johnduffell"}}