{"action":"opened","number":17,"pull_request":{"url":"https://api.github.com/repos/N0NB/hamlib/pulls/17","id":66517948,"html_url":"https://github.com/N0NB/hamlib/pull/17","diff_url":"https://github.com/N0NB/hamlib/pull/17.diff","patch_url":"https://github.com/N0NB/hamlib/pull/17.patch","issue_url":"https://api.github.com/repos/N0NB/hamlib/issues/17","number":17,"state":"open","locked":false,"title":"Fix erroneous boolean logic","user":{"login":"mmcco","id":1668979,"avatar_url":"https://avatars.githubusercontent.com/u/1668979?v=3","gravatar_id":"","url":"https://api.github.com/users/mmcco","html_url":"https://github.com/mmcco","followers_url":"https://api.github.com/users/mmcco/followers","following_url":"https://api.github.com/users/mmcco/following{/other_user}","gists_url":"https://api.github.com/users/mmcco/gists{/gist_id}","starred_url":"https://api.github.com/users/mmcco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmcco/subscriptions","organizations_url":"https://api.github.com/users/mmcco/orgs","repos_url":"https://api.github.com/users/mmcco/repos","events_url":"https://api.github.com/users/mmcco/events{/privacy}","received_events_url":"https://api.github.com/users/mmcco/received_events","type":"User","site_admin":false},"body":"It seems like || was used where && was intended here. Currently, the\r\nconditions are always true, and there's no reason for them to be written\r\nthis way.\r\n\r\nFound with Coccinelle.","created_at":"2016-04-14T16:53:06Z","updated_at":"2016-04-14T16:53:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/N0NB/hamlib/pulls/17/commits","review_comments_url":"https://api.github.com/repos/N0NB/hamlib/pulls/17/comments","review_comment_url":"https://api.github.com/repos/N0NB/hamlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/N0NB/hamlib/issues/17/comments","statuses_url":"https://api.github.com/repos/N0NB/hamlib/statuses/875d0fcdfb2b107a29db7de294f82a1da523c862","head":{"label":"mmcco:master","ref":"master","sha":"875d0fcdfb2b107a29db7de294f82a1da523c862","user":{"login":"mmcco","id":1668979,"avatar_url":"https://avatars.githubusercontent.com/u/1668979?v=3","gravatar_id":"","url":"https://api.github.com/users/mmcco","html_url":"https://github.com/mmcco","followers_url":"https://api.github.com/users/mmcco/followers","following_url":"https://api.github.com/users/mmcco/following{/other_user}","gists_url":"https://api.github.com/users/mmcco/gists{/gist_id}","starred_url":"https://api.github.com/users/mmcco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmcco/subscriptions","organizations_url":"https://api.github.com/users/mmcco/orgs","repos_url":"https://api.github.com/users/mmcco/repos","events_url":"https://api.github.com/users/mmcco/events{/privacy}","received_events_url":"https://api.github.com/users/mmcco/received_events","type":"User","site_admin":false},"repo":{"id":56254026,"name":"hamlib","full_name":"mmcco/hamlib","owner":{"login":"mmcco","id":1668979,"avatar_url":"https://avatars.githubusercontent.com/u/1668979?v=3","gravatar_id":"","url":"https://api.github.com/users/mmcco","html_url":"https://github.com/mmcco","followers_url":"https://api.github.com/users/mmcco/followers","following_url":"https://api.github.com/users/mmcco/following{/other_user}","gists_url":"https://api.github.com/users/mmcco/gists{/gist_id}","starred_url":"https://api.github.com/users/mmcco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmcco/subscriptions","organizations_url":"https://api.github.com/users/mmcco/orgs","repos_url":"https://api.github.com/users/mmcco/repos","events_url":"https://api.github.com/users/mmcco/events{/privacy}","received_events_url":"https://api.github.com/users/mmcco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmcco/hamlib","description":"Ham radio control libraries","fork":true,"url":"https://api.github.com/repos/mmcco/hamlib","forks_url":"https://api.github.com/repos/mmcco/hamlib/forks","keys_url":"https://api.github.com/repos/mmcco/hamlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmcco/hamlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmcco/hamlib/teams","hooks_url":"https://api.github.com/repos/mmcco/hamlib/hooks","issue_events_url":"https://api.github.com/repos/mmcco/hamlib/issues/events{/number}","events_url":"https://api.github.com/repos/mmcco/hamlib/events","assignees_url":"https://api.github.com/repos/mmcco/hamlib/assignees{/user}","branches_url":"https://api.github.com/repos/mmcco/hamlib/branches{/branch}","tags_url":"https://api.github.com/repos/mmcco/hamlib/tags","blobs_url":"https://api.github.com/repos/mmcco/hamlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmcco/hamlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmcco/hamlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmcco/hamlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmcco/hamlib/statuses/{sha}","languages_url":"https://api.github.com/repos/mmcco/hamlib/languages","stargazers_url":"https://api.github.com/repos/mmcco/hamlib/stargazers","contributors_url":"https://api.github.com/repos/mmcco/hamlib/contributors","subscribers_url":"https://api.github.com/repos/mmcco/hamlib/subscribers","subscription_url":"https://api.github.com/repos/mmcco/hamlib/subscription","commits_url":"https://api.github.com/repos/mmcco/hamlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmcco/hamlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmcco/hamlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmcco/hamlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmcco/hamlib/contents/{+path}","compare_url":"https://api.github.com/repos/mmcco/hamlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmcco/hamlib/merges","archive_url":"https://api.github.com/repos/mmcco/hamlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmcco/hamlib/downloads","issues_url":"https://api.github.com/repos/mmcco/hamlib/issues{/number}","pulls_url":"https://api.github.com/repos/mmcco/hamlib/pulls{/number}","milestones_url":"https://api.github.com/repos/mmcco/hamlib/milestones{/number}","notifications_url":"https://api.github.com/repos/mmcco/hamlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmcco/hamlib/labels{/name}","releases_url":"https://api.github.com/repos/mmcco/hamlib/releases{/id}","deployments_url":"https://api.github.com/repos/mmcco/hamlib/deployments","created_at":"2016-04-14T16:44:15Z","updated_at":"2016-04-14T16:44:18Z","pushed_at":"2016-04-14T16:52:24Z","git_url":"git://github.com/mmcco/hamlib.git","ssh_url":"git@github.com:mmcco/hamlib.git","clone_url":"https://github.com/mmcco/hamlib.git","svn_url":"https://github.com/mmcco/hamlib","homepage":"http://www.hamlib.org","size":16871,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"N0NB:master","ref":"master","sha":"bd7510315ee446ee2d2d9d8aef5aef0c6f0925a8","user":{"login":"N0NB","id":555821,"avatar_url":"https://avatars.githubusercontent.com/u/555821?v=3","gravatar_id":"","url":"https://api.github.com/users/N0NB","html_url":"https://github.com/N0NB","followers_url":"https://api.github.com/users/N0NB/followers","following_url":"https://api.github.com/users/N0NB/following{/other_user}","gists_url":"https://api.github.com/users/N0NB/gists{/gist_id}","starred_url":"https://api.github.com/users/N0NB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/N0NB/subscriptions","organizations_url":"https://api.github.com/users/N0NB/orgs","repos_url":"https://api.github.com/users/N0NB/repos","events_url":"https://api.github.com/users/N0NB/events{/privacy}","received_events_url":"https://api.github.com/users/N0NB/received_events","type":"User","site_admin":false},"repo":{"id":7635130,"name":"hamlib","full_name":"N0NB/hamlib","owner":{"login":"N0NB","id":555821,"avatar_url":"https://avatars.githubusercontent.com/u/555821?v=3","gravatar_id":"","url":"https://api.github.com/users/N0NB","html_url":"https://github.com/N0NB","followers_url":"https://api.github.com/users/N0NB/followers","following_url":"https://api.github.com/users/N0NB/following{/other_user}","gists_url":"https://api.github.com/users/N0NB/gists{/gist_id}","starred_url":"https://api.github.com/users/N0NB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/N0NB/subscriptions","organizations_url":"https://api.github.com/users/N0NB/orgs","repos_url":"https://api.github.com/users/N0NB/repos","events_url":"https://api.github.com/users/N0NB/events{/privacy}","received_events_url":"https://api.github.com/users/N0NB/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/N0NB/hamlib","description":"Ham radio control libraries","fork":false,"url":"https://api.github.com/repos/N0NB/hamlib","forks_url":"https://api.github.com/repos/N0NB/hamlib/forks","keys_url":"https://api.github.com/repos/N0NB/hamlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/N0NB/hamlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/N0NB/hamlib/teams","hooks_url":"https://api.github.com/repos/N0NB/hamlib/hooks","issue_events_url":"https://api.github.com/repos/N0NB/hamlib/issues/events{/number}","events_url":"https://api.github.com/repos/N0NB/hamlib/events","assignees_url":"https://api.github.com/repos/N0NB/hamlib/assignees{/user}","branches_url":"https://api.github.com/repos/N0NB/hamlib/branches{/branch}","tags_url":"https://api.github.com/repos/N0NB/hamlib/tags","blobs_url":"https://api.github.com/repos/N0NB/hamlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/N0NB/hamlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/N0NB/hamlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/N0NB/hamlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/N0NB/hamlib/statuses/{sha}","languages_url":"https://api.github.com/repos/N0NB/hamlib/languages","stargazers_url":"https://api.github.com/repos/N0NB/hamlib/stargazers","contributors_url":"https://api.github.com/repos/N0NB/hamlib/contributors","subscribers_url":"https://api.github.com/repos/N0NB/hamlib/subscribers","subscription_url":"https://api.github.com/repos/N0NB/hamlib/subscription","commits_url":"https://api.github.com/repos/N0NB/hamlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/N0NB/hamlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/N0NB/hamlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/N0NB/hamlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/N0NB/hamlib/contents/{+path}","compare_url":"https://api.github.com/repos/N0NB/hamlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/N0NB/hamlib/merges","archive_url":"https://api.github.com/repos/N0NB/hamlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/N0NB/hamlib/downloads","issues_url":"https://api.github.com/repos/N0NB/hamlib/issues{/number}","pulls_url":"https://api.github.com/repos/N0NB/hamlib/pulls{/number}","milestones_url":"https://api.github.com/repos/N0NB/hamlib/milestones{/number}","notifications_url":"https://api.github.com/repos/N0NB/hamlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/N0NB/hamlib/labels{/name}","releases_url":"https://api.github.com/repos/N0NB/hamlib/releases{/id}","deployments_url":"https://api.github.com/repos/N0NB/hamlib/deployments","created_at":"2013-01-15T23:09:18Z","updated_at":"2016-04-12T13:12:03Z","pushed_at":"2016-04-09T11:59:56Z","git_url":"git://github.com/N0NB/hamlib.git","ssh_url":"git@github.com:N0NB/hamlib.git","clone_url":"https://github.com/N0NB/hamlib.git","svn_url":"https://github.com/N0NB/hamlib","homepage":"http://www.hamlib.org","size":18433,"stargazers_count":43,"watchers_count":43,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":5,"forks":28,"open_issues":5,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/N0NB/hamlib/pulls/17"},"html":{"href":"https://github.com/N0NB/hamlib/pull/17"},"issue":{"href":"https://api.github.com/repos/N0NB/hamlib/issues/17"},"comments":{"href":"https://api.github.com/repos/N0NB/hamlib/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/N0NB/hamlib/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/N0NB/hamlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/N0NB/hamlib/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/N0NB/hamlib/statuses/875d0fcdfb2b107a29db7de294f82a1da523c862"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":5,"deletions":5,"changed_files":4}}