{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/pulls/comments/75921955","id":75921955,"diff_hunk":"@@ -93,6 +93,7 @@ kversion=$(rpm -q kernel --qf '%{version}-%{release}.%{arch}\\n')\n ramfsfile=\"/boot/initramfs-$kversion.img\"\n /sbin/dracut --force --add-drivers \"mptbase mptscsih mptspi<%= \" hv_storvsc hid_hyperv hv_netvsc hv_vmbus\" if @target == \"hyperv\" || @target == \"azure\" %>\" $ramfsfile $kversion\n \n+<%= render_partial \"post/aws-ec2\" if @target == \"aws-ec2\" %>\n <%= render_partial \"post/azure\" if @target == \"azure\" %>\n <%= render_partial \"post/gce\" if @target == \"gce\" %>","path":"kickstarts/base.ks.erb","position":6,"original_position":6,"commit_id":"cb6abcb513e4eacbc5c0f6e985be13b425ce2dd0","original_commit_id":"cb6abcb513e4eacbc5c0f6e985be13b425ce2dd0","user":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars.githubusercontent.com/u/52120?v=3","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"body":"As we keep adding more of these I wonder if it's just cleaner to do the following:\r\n\r\n```erb\r\n<%= render_partial \"post/#{@target}\" %>\r\n```\r\n\r\nor something.  You might need a way to check if the file exists, or something, but it seems cleaner to just deal with it this way.","created_at":"2016-08-23T18:17:06Z","updated_at":"2016-08-23T18:17:06Z","html_url":"https://github.com/ManageIQ/manageiq-appliance-build/pull/150#discussion_r75921955","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/pulls/150","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/pulls/comments/75921955"},"html":{"href":"https://github.com/ManageIQ/manageiq-appliance-build/pull/150#discussion_r75921955"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/pulls/150"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/pulls/150","id":82370164,"html_url":"https://github.com/ManageIQ/manageiq-appliance-build/pull/150","diff_url":"https://github.com/ManageIQ/manageiq-appliance-build/pull/150.diff","patch_url":"https://github.com/ManageIQ/manageiq-appliance-build/pull/150.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/issues/150","number":150,"state":"open","locked":false,"title":"Add kickstart file changes for AWS EC2","user":{"login":"simaishi","id":12955530,"avatar_url":"https://avatars.githubusercontent.com/u/12955530?v=3","gravatar_id":"","url":"https://api.github.com/users/simaishi","html_url":"https://github.com/simaishi","followers_url":"https://api.github.com/users/simaishi/followers","following_url":"https://api.github.com/users/simaishi/following{/other_user}","gists_url":"https://api.github.com/users/simaishi/gists{/gist_id}","starred_url":"https://api.github.com/users/simaishi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simaishi/subscriptions","organizations_url":"https://api.github.com/users/simaishi/orgs","repos_url":"https://api.github.com/users/simaishi/repos","events_url":"https://api.github.com/users/simaishi/events{/privacy}","received_events_url":"https://api.github.com/users/simaishi/received_events","type":"User","site_admin":false},"body":"Undo cloud-init cfg settings that come from manageiq-appliance repo.\r\nFor AWS EC2, need to disable root/password login, and only allow ssh key access.\r\n\r\nThe default user cloud-init creates on CentOS is \"centos\".\r\n\r\nRequires https://github.com/ManageIQ/manageiq-appliance/pull/87\r\n\r\n@Fryguy @carbonin please review","created_at":"2016-08-23T14:00:10Z","updated_at":"2016-08-23T18:17:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a971befa788601736c618307c2cdb45c1a84ed75","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/pulls/150/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/pulls/150/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/issues/150/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/statuses/cb6abcb513e4eacbc5c0f6e985be13b425ce2dd0","head":{"label":"simaishi:add_aws_ec2_kickstart","ref":"add_aws_ec2_kickstart","sha":"cb6abcb513e4eacbc5c0f6e985be13b425ce2dd0","user":{"login":"simaishi","id":12955530,"avatar_url":"https://avatars.githubusercontent.com/u/12955530?v=3","gravatar_id":"","url":"https://api.github.com/users/simaishi","html_url":"https://github.com/simaishi","followers_url":"https://api.github.com/users/simaishi/followers","following_url":"https://api.github.com/users/simaishi/following{/other_user}","gists_url":"https://api.github.com/users/simaishi/gists{/gist_id}","starred_url":"https://api.github.com/users/simaishi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simaishi/subscriptions","organizations_url":"https://api.github.com/users/simaishi/orgs","repos_url":"https://api.github.com/users/simaishi/repos","events_url":"https://api.github.com/users/simaishi/events{/privacy}","received_events_url":"https://api.github.com/users/simaishi/received_events","type":"User","site_admin":false},"repo":{"id":42136506,"name":"manageiq-appliance-build","full_name":"simaishi/manageiq-appliance-build","owner":{"login":"simaishi","id":12955530,"avatar_url":"https://avatars.githubusercontent.com/u/12955530?v=3","gravatar_id":"","url":"https://api.github.com/users/simaishi","html_url":"https://github.com/simaishi","followers_url":"https://api.github.com/users/simaishi/followers","following_url":"https://api.github.com/users/simaishi/following{/other_user}","gists_url":"https://api.github.com/users/simaishi/gists{/gist_id}","starred_url":"https://api.github.com/users/simaishi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simaishi/subscriptions","organizations_url":"https://api.github.com/users/simaishi/orgs","repos_url":"https://api.github.com/users/simaishi/repos","events_url":"https://api.github.com/users/simaishi/events{/privacy}","received_events_url":"https://api.github.com/users/simaishi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simaishi/manageiq-appliance-build","description":"Scripts to build ManageIQ appliances","fork":true,"url":"https://api.github.com/repos/simaishi/manageiq-appliance-build","forks_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/forks","keys_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/teams","hooks_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/hooks","issue_events_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/issues/events{/number}","events_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/events","assignees_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/assignees{/user}","branches_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/branches{/branch}","tags_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/tags","blobs_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/statuses/{sha}","languages_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/languages","stargazers_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/stargazers","contributors_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/contributors","subscribers_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/subscribers","subscription_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/subscription","commits_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/contents/{+path}","compare_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/merges","archive_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/downloads","issues_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/issues{/number}","pulls_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/pulls{/number}","milestones_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/milestones{/number}","notifications_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/labels{/name}","releases_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/releases{/id}","deployments_url":"https://api.github.com/repos/simaishi/manageiq-appliance-build/deployments","created_at":"2015-09-08T20:13:14Z","updated_at":"2015-09-08T20:13:15Z","pushed_at":"2016-08-23T13:16:07Z","git_url":"git://github.com/simaishi/manageiq-appliance-build.git","ssh_url":"git@github.com:simaishi/manageiq-appliance-build.git","clone_url":"https://github.com/simaishi/manageiq-appliance-build.git","svn_url":"https://github.com/simaishi/manageiq-appliance-build","homepage":null,"size":279,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"d0f4d921daf92d60c48a08bd9ea722a9942f76a2","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":38112825,"name":"manageiq-appliance-build","full_name":"ManageIQ/manageiq-appliance-build","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-appliance-build","description":"Scripts to build ManageIQ appliances","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/deployments","created_at":"2015-06-26T13:32:44Z","updated_at":"2016-08-05T00:39:00Z","pushed_at":"2016-08-23T14:00:10Z","git_url":"git://github.com/ManageIQ/manageiq-appliance-build.git","ssh_url":"git@github.com:ManageIQ/manageiq-appliance-build.git","clone_url":"https://github.com/ManageIQ/manageiq-appliance-build.git","svn_url":"https://github.com/ManageIQ/manageiq-appliance-build","homepage":null,"size":310,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":16,"forks":17,"open_issues":16,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/pulls/150"},"html":{"href":"https://github.com/ManageIQ/manageiq-appliance-build/pull/150"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/issues/150"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-appliance-build/statuses/cb6abcb513e4eacbc5c0f6e985be13b425ce2dd0"}}}}
{"actor":{"display_login":"Fryguy"}}