{"action":"created","comment":{"url":"https://api.github.com/repos/ros-planning/moveit_ros/pulls/comments/70937800","id":70937800,"diff_hunk":"@@ -129,15 +137,28 @@ void MotionPlanningFrame::computePlanButtonClicked()\n void MotionPlanningFrame::computeExecuteButtonClicked()\n {\n   if (move_group_ && current_plan_)\n-    move_group_->execute(*current_plan_);","path":"visualization/motion_planning_rviz_plugin/src/motion_planning_frame_planning.cpp","position":33,"original_position":33,"commit_id":"5503fa925adbf5a795d4b5c7095117ccb1724f03","original_commit_id":"5503fa925adbf5a795d4b5c7095117ccb1724f03","user":{"login":"rhaschke","id":5376030,"avatar_url":"https://avatars.githubusercontent.com/u/5376030?v=3","gravatar_id":"","url":"https://api.github.com/users/rhaschke","html_url":"https://github.com/rhaschke","followers_url":"https://api.github.com/users/rhaschke/followers","following_url":"https://api.github.com/users/rhaschke/following{/other_user}","gists_url":"https://api.github.com/users/rhaschke/gists{/gist_id}","starred_url":"https://api.github.com/users/rhaschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhaschke/subscriptions","organizations_url":"https://api.github.com/users/rhaschke/orgs","repos_url":"https://api.github.com/users/rhaschke/repos","events_url":"https://api.github.com/users/rhaschke/events{/privacy}","received_events_url":"https://api.github.com/users/rhaschke/received_events","type":"User","site_admin":false},"body":"\n> Precisely speaking, for stopping of a trajectory, the service call \n> with |wait_for_execution:=false| and |stop()| method call is enough. \n> The reason I needed to change the |execute()| method to |move()| is to \n> get the trajectory execution server status to handle GUI button status \n> correctly in 5503fa9 \n> <https://github.com/ros-planning/moveit_ros/pull/709/commits/5503fa925adbf5a795d4b5c7095117ccb1724f03>.\n>\nThe service call doesn't have a stop() method, does it? I guess you are \nintermixing with the move action?\n","created_at":"2016-07-15T08:27:59Z","updated_at":"2016-07-15T08:27:59Z","html_url":"https://github.com/ros-planning/moveit_ros/pull/709#discussion_r70937800","pull_request_url":"https://api.github.com/repos/ros-planning/moveit_ros/pulls/709","_links":{"self":{"href":"https://api.github.com/repos/ros-planning/moveit_ros/pulls/comments/70937800"},"html":{"href":"https://github.com/ros-planning/moveit_ros/pull/709#discussion_r70937800"},"pull_request":{"href":"https://api.github.com/repos/ros-planning/moveit_ros/pulls/709"}}},"pull_request":{"url":"https://api.github.com/repos/ros-planning/moveit_ros/pulls/709","id":76867302,"html_url":"https://github.com/ros-planning/moveit_ros/pull/709","diff_url":"https://github.com/ros-planning/moveit_ros/pull/709.diff","patch_url":"https://github.com/ros-planning/moveit_ros/pull/709.patch","issue_url":"https://api.github.com/repos/ros-planning/moveit_ros/issues/709","number":709,"state":"open","locked":false,"title":"Stop execution on motion planning rviz plugin","user":{"login":"wkentaro","id":4310419,"avatar_url":"https://avatars.githubusercontent.com/u/4310419?v=3","gravatar_id":"","url":"https://api.github.com/users/wkentaro","html_url":"https://github.com/wkentaro","followers_url":"https://api.github.com/users/wkentaro/followers","following_url":"https://api.github.com/users/wkentaro/following{/other_user}","gists_url":"https://api.github.com/users/wkentaro/gists{/gist_id}","starred_url":"https://api.github.com/users/wkentaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkentaro/subscriptions","organizations_url":"https://api.github.com/users/wkentaro/orgs","repos_url":"https://api.github.com/users/wkentaro/repos","events_url":"https://api.github.com/users/wkentaro/events{/privacy}","received_events_url":"https://api.github.com/users/wkentaro/received_events","type":"User","site_admin":false},"body":"![moveit_motion_planning_rviz_plugin_stop_button](https://cloud.githubusercontent.com/assets/4310419/16715559/6dd2208e-471e-11e6-8289-58dc44f7ccff.gif)\r\n","created_at":"2016-07-10T08:05:24Z","updated_at":"2016-07-15T08:27:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d183cdb03c9957335b273bf2a02278c216d8dde","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros-planning/moveit_ros/pulls/709/commits","review_comments_url":"https://api.github.com/repos/ros-planning/moveit_ros/pulls/709/comments","review_comment_url":"https://api.github.com/repos/ros-planning/moveit_ros/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros-planning/moveit_ros/issues/709/comments","statuses_url":"https://api.github.com/repos/ros-planning/moveit_ros/statuses/5503fa925adbf5a795d4b5c7095117ccb1724f03","head":{"label":"wkentaro:stop-execution","ref":"stop-execution","sha":"5503fa925adbf5a795d4b5c7095117ccb1724f03","user":{"login":"wkentaro","id":4310419,"avatar_url":"https://avatars.githubusercontent.com/u/4310419?v=3","gravatar_id":"","url":"https://api.github.com/users/wkentaro","html_url":"https://github.com/wkentaro","followers_url":"https://api.github.com/users/wkentaro/followers","following_url":"https://api.github.com/users/wkentaro/following{/other_user}","gists_url":"https://api.github.com/users/wkentaro/gists{/gist_id}","starred_url":"https://api.github.com/users/wkentaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkentaro/subscriptions","organizations_url":"https://api.github.com/users/wkentaro/orgs","repos_url":"https://api.github.com/users/wkentaro/repos","events_url":"https://api.github.com/users/wkentaro/events{/privacy}","received_events_url":"https://api.github.com/users/wkentaro/received_events","type":"User","site_admin":false},"repo":{"id":56917979,"name":"moveit_ros","full_name":"wkentaro/moveit_ros","owner":{"login":"wkentaro","id":4310419,"avatar_url":"https://avatars.githubusercontent.com/u/4310419?v=3","gravatar_id":"","url":"https://api.github.com/users/wkentaro","html_url":"https://github.com/wkentaro","followers_url":"https://api.github.com/users/wkentaro/followers","following_url":"https://api.github.com/users/wkentaro/following{/other_user}","gists_url":"https://api.github.com/users/wkentaro/gists{/gist_id}","starred_url":"https://api.github.com/users/wkentaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkentaro/subscriptions","organizations_url":"https://api.github.com/users/wkentaro/orgs","repos_url":"https://api.github.com/users/wkentaro/repos","events_url":"https://api.github.com/users/wkentaro/events{/privacy}","received_events_url":"https://api.github.com/users/wkentaro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wkentaro/moveit_ros","description":"MoveIt! ROS","fork":true,"url":"https://api.github.com/repos/wkentaro/moveit_ros","forks_url":"https://api.github.com/repos/wkentaro/moveit_ros/forks","keys_url":"https://api.github.com/repos/wkentaro/moveit_ros/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wkentaro/moveit_ros/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wkentaro/moveit_ros/teams","hooks_url":"https://api.github.com/repos/wkentaro/moveit_ros/hooks","issue_events_url":"https://api.github.com/repos/wkentaro/moveit_ros/issues/events{/number}","events_url":"https://api.github.com/repos/wkentaro/moveit_ros/events","assignees_url":"https://api.github.com/repos/wkentaro/moveit_ros/assignees{/user}","branches_url":"https://api.github.com/repos/wkentaro/moveit_ros/branches{/branch}","tags_url":"https://api.github.com/repos/wkentaro/moveit_ros/tags","blobs_url":"https://api.github.com/repos/wkentaro/moveit_ros/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wkentaro/moveit_ros/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wkentaro/moveit_ros/git/refs{/sha}","trees_url":"https://api.github.com/repos/wkentaro/moveit_ros/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wkentaro/moveit_ros/statuses/{sha}","languages_url":"https://api.github.com/repos/wkentaro/moveit_ros/languages","stargazers_url":"https://api.github.com/repos/wkentaro/moveit_ros/stargazers","contributors_url":"https://api.github.com/repos/wkentaro/moveit_ros/contributors","subscribers_url":"https://api.github.com/repos/wkentaro/moveit_ros/subscribers","subscription_url":"https://api.github.com/repos/wkentaro/moveit_ros/subscription","commits_url":"https://api.github.com/repos/wkentaro/moveit_ros/commits{/sha}","git_commits_url":"https://api.github.com/repos/wkentaro/moveit_ros/git/commits{/sha}","comments_url":"https://api.github.com/repos/wkentaro/moveit_ros/comments{/number}","issue_comment_url":"https://api.github.com/repos/wkentaro/moveit_ros/issues/comments{/number}","contents_url":"https://api.github.com/repos/wkentaro/moveit_ros/contents/{+path}","compare_url":"https://api.github.com/repos/wkentaro/moveit_ros/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wkentaro/moveit_ros/merges","archive_url":"https://api.github.com/repos/wkentaro/moveit_ros/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wkentaro/moveit_ros/downloads","issues_url":"https://api.github.com/repos/wkentaro/moveit_ros/issues{/number}","pulls_url":"https://api.github.com/repos/wkentaro/moveit_ros/pulls{/number}","milestones_url":"https://api.github.com/repos/wkentaro/moveit_ros/milestones{/number}","notifications_url":"https://api.github.com/repos/wkentaro/moveit_ros/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wkentaro/moveit_ros/labels{/name}","releases_url":"https://api.github.com/repos/wkentaro/moveit_ros/releases{/id}","deployments_url":"https://api.github.com/repos/wkentaro/moveit_ros/deployments","created_at":"2016-04-23T12:25:40Z","updated_at":"2016-04-23T12:25:44Z","pushed_at":"2016-07-13T20:30:03Z","git_url":"git://github.com/wkentaro/moveit_ros.git","ssh_url":"git@github.com:wkentaro/moveit_ros.git","clone_url":"https://github.com/wkentaro/moveit_ros.git","svn_url":"https://github.com/wkentaro/moveit_ros","homepage":null,"size":13710,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"jade-devel"}},"base":{"label":"ros-planning:indigo-devel","ref":"indigo-devel","sha":"9479afcfd6bd05b3580d4bfb87cb773f29a905d4","user":{"login":"ros-planning","id":2328631,"avatar_url":"https://avatars.githubusercontent.com/u/2328631?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-planning","html_url":"https://github.com/ros-planning","followers_url":"https://api.github.com/users/ros-planning/followers","following_url":"https://api.github.com/users/ros-planning/following{/other_user}","gists_url":"https://api.github.com/users/ros-planning/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-planning/subscriptions","organizations_url":"https://api.github.com/users/ros-planning/orgs","repos_url":"https://api.github.com/users/ros-planning/repos","events_url":"https://api.github.com/users/ros-planning/events{/privacy}","received_events_url":"https://api.github.com/users/ros-planning/received_events","type":"Organization","site_admin":false},"repo":{"id":5806776,"name":"moveit_ros","full_name":"ros-planning/moveit_ros","owner":{"login":"ros-planning","id":2328631,"avatar_url":"https://avatars.githubusercontent.com/u/2328631?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-planning","html_url":"https://github.com/ros-planning","followers_url":"https://api.github.com/users/ros-planning/followers","following_url":"https://api.github.com/users/ros-planning/following{/other_user}","gists_url":"https://api.github.com/users/ros-planning/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-planning/subscriptions","organizations_url":"https://api.github.com/users/ros-planning/orgs","repos_url":"https://api.github.com/users/ros-planning/repos","events_url":"https://api.github.com/users/ros-planning/events{/privacy}","received_events_url":"https://api.github.com/users/ros-planning/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros-planning/moveit_ros","description":"MoveIt! ROS","fork":false,"url":"https://api.github.com/repos/ros-planning/moveit_ros","forks_url":"https://api.github.com/repos/ros-planning/moveit_ros/forks","keys_url":"https://api.github.com/repos/ros-planning/moveit_ros/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros-planning/moveit_ros/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros-planning/moveit_ros/teams","hooks_url":"https://api.github.com/repos/ros-planning/moveit_ros/hooks","issue_events_url":"https://api.github.com/repos/ros-planning/moveit_ros/issues/events{/number}","events_url":"https://api.github.com/repos/ros-planning/moveit_ros/events","assignees_url":"https://api.github.com/repos/ros-planning/moveit_ros/assignees{/user}","branches_url":"https://api.github.com/repos/ros-planning/moveit_ros/branches{/branch}","tags_url":"https://api.github.com/repos/ros-planning/moveit_ros/tags","blobs_url":"https://api.github.com/repos/ros-planning/moveit_ros/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros-planning/moveit_ros/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros-planning/moveit_ros/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros-planning/moveit_ros/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros-planning/moveit_ros/statuses/{sha}","languages_url":"https://api.github.com/repos/ros-planning/moveit_ros/languages","stargazers_url":"https://api.github.com/repos/ros-planning/moveit_ros/stargazers","contributors_url":"https://api.github.com/repos/ros-planning/moveit_ros/contributors","subscribers_url":"https://api.github.com/repos/ros-planning/moveit_ros/subscribers","subscription_url":"https://api.github.com/repos/ros-planning/moveit_ros/subscription","commits_url":"https://api.github.com/repos/ros-planning/moveit_ros/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros-planning/moveit_ros/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros-planning/moveit_ros/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros-planning/moveit_ros/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros-planning/moveit_ros/contents/{+path}","compare_url":"https://api.github.com/repos/ros-planning/moveit_ros/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros-planning/moveit_ros/merges","archive_url":"https://api.github.com/repos/ros-planning/moveit_ros/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros-planning/moveit_ros/downloads","issues_url":"https://api.github.com/repos/ros-planning/moveit_ros/issues{/number}","pulls_url":"https://api.github.com/repos/ros-planning/moveit_ros/pulls{/number}","milestones_url":"https://api.github.com/repos/ros-planning/moveit_ros/milestones{/number}","notifications_url":"https://api.github.com/repos/ros-planning/moveit_ros/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros-planning/moveit_ros/labels{/name}","releases_url":"https://api.github.com/repos/ros-planning/moveit_ros/releases{/id}","deployments_url":"https://api.github.com/repos/ros-planning/moveit_ros/deployments","created_at":"2012-09-14T08:47:50Z","updated_at":"2016-07-04T02:34:06Z","pushed_at":"2016-07-15T07:03:53Z","git_url":"git://github.com/ros-planning/moveit_ros.git","ssh_url":"git@github.com:ros-planning/moveit_ros.git","clone_url":"https://github.com/ros-planning/moveit_ros.git","svn_url":"https://github.com/ros-planning/moveit_ros","homepage":null,"size":20235,"stargazers_count":54,"watchers_count":54,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":127,"mirror_url":null,"open_issues_count":116,"forks":127,"open_issues":116,"watchers":54,"default_branch":"kinetic-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros-planning/moveit_ros/pulls/709"},"html":{"href":"https://github.com/ros-planning/moveit_ros/pull/709"},"issue":{"href":"https://api.github.com/repos/ros-planning/moveit_ros/issues/709"},"comments":{"href":"https://api.github.com/repos/ros-planning/moveit_ros/issues/709/comments"},"review_comments":{"href":"https://api.github.com/repos/ros-planning/moveit_ros/pulls/709/comments"},"review_comment":{"href":"https://api.github.com/repos/ros-planning/moveit_ros/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros-planning/moveit_ros/pulls/709/commits"},"statuses":{"href":"https://api.github.com/repos/ros-planning/moveit_ros/statuses/5503fa925adbf5a795d4b5c7095117ccb1724f03"}}}}
{"actor":{"display_login":"rhaschke"}}