{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/55280747","id":55280747,"diff_hunk":"@@ -37,5 +37,6 @@ case class CleanerConfig(numThreads: Int = 1,\n                          maxIoBytesPerSecond: Double = Double.MaxValue,\n                          backOffMs: Long = 15 * 1000,\n                          enableCleaner: Boolean = true,\n-                         hashAlgorithm: String = \"MD5\") {\n+                         hashAlgorithm: String = \"MD5\",\n+                         brokerCompressionType: String = \"uncompressed\") {","path":"core/src/main/scala/kafka/log/CleanerConfig.scala","position":6,"original_position":6,"commit_id":"94041c2247a234f0069f7b0426948ad203b79572","original_commit_id":"94041c2247a234f0069f7b0426948ad203b79572","user":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"body":"Thanks for the suggestion. I think CompressionCodec is more apt here though. Will change in next version.","created_at":"2016-03-07T22:03:38Z","updated_at":"2016-03-07T22:03:38Z","html_url":"https://github.com/apache/kafka/pull/1010#discussion_r55280747","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/1010","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/55280747"},"html":{"href":"https://github.com/apache/kafka/pull/1010#discussion_r55280747"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/1010"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/1010","id":61649334,"html_url":"https://github.com/apache/kafka/pull/1010","diff_url":"https://github.com/apache/kafka/pull/1010.diff","patch_url":"https://github.com/apache/kafka/pull/1010.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/1010","number":1010,"state":"open","locked":false,"title":"KAFKA-3252: Compression type from broker config should be used during log compaction.","user":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-03-04T00:28:01Z","updated_at":"2016-03-07T22:03:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e2ca00512098594fc86a5d89ad356a1beca3aa5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/1010/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/1010/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/1010/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/94041c2247a234f0069f7b0426948ad203b79572","head":{"label":"SinghAsDev:KAFKA-3252","ref":"KAFKA-3252","sha":"94041c2247a234f0069f7b0426948ad203b79572","user":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"repo":{"id":29443488,"name":"kafka","full_name":"SinghAsDev/kafka","owner":{"login":"SinghAsDev","id":4915557,"avatar_url":"https://avatars.githubusercontent.com/u/4915557?v=3","gravatar_id":"","url":"https://api.github.com/users/SinghAsDev","html_url":"https://github.com/SinghAsDev","followers_url":"https://api.github.com/users/SinghAsDev/followers","following_url":"https://api.github.com/users/SinghAsDev/following{/other_user}","gists_url":"https://api.github.com/users/SinghAsDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SinghAsDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SinghAsDev/subscriptions","organizations_url":"https://api.github.com/users/SinghAsDev/orgs","repos_url":"https://api.github.com/users/SinghAsDev/repos","events_url":"https://api.github.com/users/SinghAsDev/events{/privacy}","received_events_url":"https://api.github.com/users/SinghAsDev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SinghAsDev/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/SinghAsDev/kafka","forks_url":"https://api.github.com/repos/SinghAsDev/kafka/forks","keys_url":"https://api.github.com/repos/SinghAsDev/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SinghAsDev/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SinghAsDev/kafka/teams","hooks_url":"https://api.github.com/repos/SinghAsDev/kafka/hooks","issue_events_url":"https://api.github.com/repos/SinghAsDev/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/SinghAsDev/kafka/events","assignees_url":"https://api.github.com/repos/SinghAsDev/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/SinghAsDev/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/SinghAsDev/kafka/tags","blobs_url":"https://api.github.com/repos/SinghAsDev/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SinghAsDev/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SinghAsDev/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/SinghAsDev/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SinghAsDev/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/SinghAsDev/kafka/languages","stargazers_url":"https://api.github.com/repos/SinghAsDev/kafka/stargazers","contributors_url":"https://api.github.com/repos/SinghAsDev/kafka/contributors","subscribers_url":"https://api.github.com/repos/SinghAsDev/kafka/subscribers","subscription_url":"https://api.github.com/repos/SinghAsDev/kafka/subscription","commits_url":"https://api.github.com/repos/SinghAsDev/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/SinghAsDev/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/SinghAsDev/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/SinghAsDev/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/SinghAsDev/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/SinghAsDev/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SinghAsDev/kafka/merges","archive_url":"https://api.github.com/repos/SinghAsDev/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SinghAsDev/kafka/downloads","issues_url":"https://api.github.com/repos/SinghAsDev/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/SinghAsDev/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/SinghAsDev/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/SinghAsDev/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SinghAsDev/kafka/labels{/name}","releases_url":"https://api.github.com/repos/SinghAsDev/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/SinghAsDev/kafka/deployments","created_at":"2015-01-18T22:26:11Z","updated_at":"2015-01-18T22:26:13Z","pushed_at":"2016-03-07T21:09:16Z","git_url":"git://github.com/SinghAsDev/kafka.git","ssh_url":"git@github.com:SinghAsDev/kafka.git","clone_url":"https://github.com/SinghAsDev/kafka.git","svn_url":"https://github.com/SinghAsDev/kafka","homepage":null,"size":27201,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.8.1"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"5d893654489647e8be65c4d54864ab63b7285faa","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2016-03-07T14:54:02Z","pushed_at":"2016-03-07T21:56:42Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":35908,"stargazers_count":2718,"watchers_count":2718,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1641,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":146,"forks":1641,"open_issues":146,"watchers":2718,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/1010"},"html":{"href":"https://github.com/apache/kafka/pull/1010"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/1010"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/1010/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/1010/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/1010/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/94041c2247a234f0069f7b0426948ad203b79572"}}}}