{"action":"created","comment":{"url":"https://api.github.com/repos/alainfrisch/flexdll/pulls/comments/71493657","id":71493657,"diff_hunk":"@@ -118,10 +118,41 @@ build_cygwin64: flexdll_cygwin64.o flexdll_initer_cygwin64.o\n build_mingw: flexdll_mingw.o flexdll_initer_mingw.o\n build_mingw64: flexdll_mingw64.o flexdll_initer_mingw64.o\n \n-OBJS = version.ml coff.ml cmdline.ml create_dll.ml reloc.ml\n+OBJS = version.ml StringCompat.ml BytesCompat.ml coff.ml cmdline.ml create_dll.ml reloc.ml\n+\n+COMPILER-$(OCAML_VERSION):\n+\trm -f COMPILER-* cmdline.ml BytesCompat.ml StringCompat.ml\n+\ttouch COMPILER-$(OCAML_VERSION)\n+\n+test_ver = $(shell if [ $(OCAML_VERSION) -lt $(1) ] ; then echo lt ; else echo ge ; fi)\n+\n+# Enable StringCompat module for OCaml < 4.03.0\n+ifeq ($(call test_ver,4030),lt)\n+StringCompat.ml: StringCompat.ml.in COMPILER-$(OCAML_VERSION)\n+else\n+StringCompat.ml: COMPILER-$(OCAML_VERSION)\n+\ttouch $@\n+endif\n+\n+# Enable BytesCompat module for OCaml < 4.02.0\n+ifeq ($(call test_ver,4020),lt)\n+BytesCompat.ml: BytesCompat.ml.in COMPILER-$(OCAML_VERSION)\n+else\n+BytesCompat.ml: COMPILER-$(OCAML_VERSION)\n+\ttouch $@\n+endif\n+\n+cmdline.ml: cmdline.ml.in COMPILER-$(OCAML_VERSION)","path":"Makefile","position":47,"original_position":47,"commit_id":"d24d374d611044b1b8a04e4d4dd70f1461b471c9","original_commit_id":"d24d374d611044b1b8a04e4d4dd70f1461b471c9","user":{"login":"alainfrisch","id":3305274,"avatar_url":"https://avatars.githubusercontent.com/u/3305274?v=3","gravatar_id":"","url":"https://api.github.com/users/alainfrisch","html_url":"https://github.com/alainfrisch","followers_url":"https://api.github.com/users/alainfrisch/followers","following_url":"https://api.github.com/users/alainfrisch/following{/other_user}","gists_url":"https://api.github.com/users/alainfrisch/gists{/gist_id}","starred_url":"https://api.github.com/users/alainfrisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alainfrisch/subscriptions","organizations_url":"https://api.github.com/users/alainfrisch/orgs","repos_url":"https://api.github.com/users/alainfrisch/repos","events_url":"https://api.github.com/users/alainfrisch/events{/privacy}","received_events_url":"https://api.github.com/users/alainfrisch/received_events","type":"User","site_admin":false},"body":"Let's just use a regular string in cmdline.ml.","created_at":"2016-07-20T09:34:11Z","updated_at":"2016-07-20T09:34:11Z","html_url":"https://github.com/alainfrisch/flexdll/pull/21#discussion_r71493657","pull_request_url":"https://api.github.com/repos/alainfrisch/flexdll/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/alainfrisch/flexdll/pulls/comments/71493657"},"html":{"href":"https://github.com/alainfrisch/flexdll/pull/21#discussion_r71493657"},"pull_request":{"href":"https://api.github.com/repos/alainfrisch/flexdll/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/alainfrisch/flexdll/pulls/21","id":78114815,"html_url":"https://github.com/alainfrisch/flexdll/pull/21","diff_url":"https://github.com/alainfrisch/flexdll/pull/21.diff","patch_url":"https://github.com/alainfrisch/flexdll/pull/21.patch","issue_url":"https://api.github.com/repos/alainfrisch/flexdll/issues/21","number":21,"state":"open","locked":false,"title":"Add build compatibility for 3.11.0--4.02.3","user":{"login":"dra27","id":5250680,"avatar_url":"https://avatars.githubusercontent.com/u/5250680?v=3","gravatar_id":"","url":"https://api.github.com/users/dra27","html_url":"https://github.com/dra27","followers_url":"https://api.github.com/users/dra27/followers","following_url":"https://api.github.com/users/dra27/following{/other_user}","gists_url":"https://api.github.com/users/dra27/gists{/gist_id}","starred_url":"https://api.github.com/users/dra27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dra27/subscriptions","organizations_url":"https://api.github.com/users/dra27/orgs","repos_url":"https://api.github.com/users/dra27/repos","events_url":"https://api.github.com/users/dra27/events{/privacy}","received_events_url":"https://api.github.com/users/dra27/received_events","type":"User","site_admin":false},"body":"Apropos of #20, this commit adds complete build compatibility for 3.11.0 onwards. My opinion - which I expect matches yours - is that this can be kept until such point as a language feature is used where back-porting becomes non-trivial, and then it can be completely removed.\r\n\r\nThe code in `StringCompat.ml` is lifted straight out of OCaml 4.03.0 (I'm assuming licence compatibility/permission to do that?)\r\n\r\n`Makefile` tests ocamlopt -version each time and uses a cookie to detect changes in the compiler (for example, if using opam to switch between multiple compilers...) and regenerates the files.\r\n\r\nI've tested it with 3.11.0, 4.02.3 and 4.03.0 - it'll get a bit more battle testing shortly!","created_at":"2016-07-20T09:27:03Z","updated_at":"2016-07-20T09:34:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76fe7dd78ddf83952dbf6889b3cd74e74bc749ce","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alainfrisch/flexdll/pulls/21/commits","review_comments_url":"https://api.github.com/repos/alainfrisch/flexdll/pulls/21/comments","review_comment_url":"https://api.github.com/repos/alainfrisch/flexdll/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alainfrisch/flexdll/issues/21/comments","statuses_url":"https://api.github.com/repos/alainfrisch/flexdll/statuses/d24d374d611044b1b8a04e4d4dd70f1461b471c9","head":{"label":"dra27:compatibility","ref":"compatibility","sha":"d24d374d611044b1b8a04e4d4dd70f1461b471c9","user":{"login":"dra27","id":5250680,"avatar_url":"https://avatars.githubusercontent.com/u/5250680?v=3","gravatar_id":"","url":"https://api.github.com/users/dra27","html_url":"https://github.com/dra27","followers_url":"https://api.github.com/users/dra27/followers","following_url":"https://api.github.com/users/dra27/following{/other_user}","gists_url":"https://api.github.com/users/dra27/gists{/gist_id}","starred_url":"https://api.github.com/users/dra27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dra27/subscriptions","organizations_url":"https://api.github.com/users/dra27/orgs","repos_url":"https://api.github.com/users/dra27/repos","events_url":"https://api.github.com/users/dra27/events{/privacy}","received_events_url":"https://api.github.com/users/dra27/received_events","type":"User","site_admin":false},"repo":{"id":37911692,"name":"flexdll","full_name":"dra27/flexdll","owner":{"login":"dra27","id":5250680,"avatar_url":"https://avatars.githubusercontent.com/u/5250680?v=3","gravatar_id":"","url":"https://api.github.com/users/dra27","html_url":"https://github.com/dra27","followers_url":"https://api.github.com/users/dra27/followers","following_url":"https://api.github.com/users/dra27/following{/other_user}","gists_url":"https://api.github.com/users/dra27/gists{/gist_id}","starred_url":"https://api.github.com/users/dra27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dra27/subscriptions","organizations_url":"https://api.github.com/users/dra27/orgs","repos_url":"https://api.github.com/users/dra27/repos","events_url":"https://api.github.com/users/dra27/events{/privacy}","received_events_url":"https://api.github.com/users/dra27/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dra27/flexdll","description":"","fork":true,"url":"https://api.github.com/repos/dra27/flexdll","forks_url":"https://api.github.com/repos/dra27/flexdll/forks","keys_url":"https://api.github.com/repos/dra27/flexdll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dra27/flexdll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dra27/flexdll/teams","hooks_url":"https://api.github.com/repos/dra27/flexdll/hooks","issue_events_url":"https://api.github.com/repos/dra27/flexdll/issues/events{/number}","events_url":"https://api.github.com/repos/dra27/flexdll/events","assignees_url":"https://api.github.com/repos/dra27/flexdll/assignees{/user}","branches_url":"https://api.github.com/repos/dra27/flexdll/branches{/branch}","tags_url":"https://api.github.com/repos/dra27/flexdll/tags","blobs_url":"https://api.github.com/repos/dra27/flexdll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dra27/flexdll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dra27/flexdll/git/refs{/sha}","trees_url":"https://api.github.com/repos/dra27/flexdll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dra27/flexdll/statuses/{sha}","languages_url":"https://api.github.com/repos/dra27/flexdll/languages","stargazers_url":"https://api.github.com/repos/dra27/flexdll/stargazers","contributors_url":"https://api.github.com/repos/dra27/flexdll/contributors","subscribers_url":"https://api.github.com/repos/dra27/flexdll/subscribers","subscription_url":"https://api.github.com/repos/dra27/flexdll/subscription","commits_url":"https://api.github.com/repos/dra27/flexdll/commits{/sha}","git_commits_url":"https://api.github.com/repos/dra27/flexdll/git/commits{/sha}","comments_url":"https://api.github.com/repos/dra27/flexdll/comments{/number}","issue_comment_url":"https://api.github.com/repos/dra27/flexdll/issues/comments{/number}","contents_url":"https://api.github.com/repos/dra27/flexdll/contents/{+path}","compare_url":"https://api.github.com/repos/dra27/flexdll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dra27/flexdll/merges","archive_url":"https://api.github.com/repos/dra27/flexdll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dra27/flexdll/downloads","issues_url":"https://api.github.com/repos/dra27/flexdll/issues{/number}","pulls_url":"https://api.github.com/repos/dra27/flexdll/pulls{/number}","milestones_url":"https://api.github.com/repos/dra27/flexdll/milestones{/number}","notifications_url":"https://api.github.com/repos/dra27/flexdll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dra27/flexdll/labels{/name}","releases_url":"https://api.github.com/repos/dra27/flexdll/releases{/id}","deployments_url":"https://api.github.com/repos/dra27/flexdll/deployments","created_at":"2015-06-23T10:10:37Z","updated_at":"2016-01-15T17:06:37Z","pushed_at":"2016-07-20T09:21:25Z","git_url":"git://github.com/dra27/flexdll.git","ssh_url":"git@github.com:dra27/flexdll.git","clone_url":"https://github.com/dra27/flexdll.git","svn_url":"https://github.com/dra27/flexdll","homepage":"http://alain.frisch.fr/flexdll.html","size":344,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alainfrisch:master","ref":"master","sha":"83dc1fe7397176dfba24cb1d43bf6b9dd48bfb01","user":{"login":"alainfrisch","id":3305274,"avatar_url":"https://avatars.githubusercontent.com/u/3305274?v=3","gravatar_id":"","url":"https://api.github.com/users/alainfrisch","html_url":"https://github.com/alainfrisch","followers_url":"https://api.github.com/users/alainfrisch/followers","following_url":"https://api.github.com/users/alainfrisch/following{/other_user}","gists_url":"https://api.github.com/users/alainfrisch/gists{/gist_id}","starred_url":"https://api.github.com/users/alainfrisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alainfrisch/subscriptions","organizations_url":"https://api.github.com/users/alainfrisch/orgs","repos_url":"https://api.github.com/users/alainfrisch/repos","events_url":"https://api.github.com/users/alainfrisch/events{/privacy}","received_events_url":"https://api.github.com/users/alainfrisch/received_events","type":"User","site_admin":false},"repo":{"id":15137466,"name":"flexdll","full_name":"alainfrisch/flexdll","owner":{"login":"alainfrisch","id":3305274,"avatar_url":"https://avatars.githubusercontent.com/u/3305274?v=3","gravatar_id":"","url":"https://api.github.com/users/alainfrisch","html_url":"https://github.com/alainfrisch","followers_url":"https://api.github.com/users/alainfrisch/followers","following_url":"https://api.github.com/users/alainfrisch/following{/other_user}","gists_url":"https://api.github.com/users/alainfrisch/gists{/gist_id}","starred_url":"https://api.github.com/users/alainfrisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alainfrisch/subscriptions","organizations_url":"https://api.github.com/users/alainfrisch/orgs","repos_url":"https://api.github.com/users/alainfrisch/repos","events_url":"https://api.github.com/users/alainfrisch/events{/privacy}","received_events_url":"https://api.github.com/users/alainfrisch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alainfrisch/flexdll","description":"a dlopen-like API for Windows","fork":false,"url":"https://api.github.com/repos/alainfrisch/flexdll","forks_url":"https://api.github.com/repos/alainfrisch/flexdll/forks","keys_url":"https://api.github.com/repos/alainfrisch/flexdll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alainfrisch/flexdll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alainfrisch/flexdll/teams","hooks_url":"https://api.github.com/repos/alainfrisch/flexdll/hooks","issue_events_url":"https://api.github.com/repos/alainfrisch/flexdll/issues/events{/number}","events_url":"https://api.github.com/repos/alainfrisch/flexdll/events","assignees_url":"https://api.github.com/repos/alainfrisch/flexdll/assignees{/user}","branches_url":"https://api.github.com/repos/alainfrisch/flexdll/branches{/branch}","tags_url":"https://api.github.com/repos/alainfrisch/flexdll/tags","blobs_url":"https://api.github.com/repos/alainfrisch/flexdll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alainfrisch/flexdll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alainfrisch/flexdll/git/refs{/sha}","trees_url":"https://api.github.com/repos/alainfrisch/flexdll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alainfrisch/flexdll/statuses/{sha}","languages_url":"https://api.github.com/repos/alainfrisch/flexdll/languages","stargazers_url":"https://api.github.com/repos/alainfrisch/flexdll/stargazers","contributors_url":"https://api.github.com/repos/alainfrisch/flexdll/contributors","subscribers_url":"https://api.github.com/repos/alainfrisch/flexdll/subscribers","subscription_url":"https://api.github.com/repos/alainfrisch/flexdll/subscription","commits_url":"https://api.github.com/repos/alainfrisch/flexdll/commits{/sha}","git_commits_url":"https://api.github.com/repos/alainfrisch/flexdll/git/commits{/sha}","comments_url":"https://api.github.com/repos/alainfrisch/flexdll/comments{/number}","issue_comment_url":"https://api.github.com/repos/alainfrisch/flexdll/issues/comments{/number}","contents_url":"https://api.github.com/repos/alainfrisch/flexdll/contents/{+path}","compare_url":"https://api.github.com/repos/alainfrisch/flexdll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alainfrisch/flexdll/merges","archive_url":"https://api.github.com/repos/alainfrisch/flexdll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alainfrisch/flexdll/downloads","issues_url":"https://api.github.com/repos/alainfrisch/flexdll/issues{/number}","pulls_url":"https://api.github.com/repos/alainfrisch/flexdll/pulls{/number}","milestones_url":"https://api.github.com/repos/alainfrisch/flexdll/milestones{/number}","notifications_url":"https://api.github.com/repos/alainfrisch/flexdll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alainfrisch/flexdll/labels{/name}","releases_url":"https://api.github.com/repos/alainfrisch/flexdll/releases{/id}","deployments_url":"https://api.github.com/repos/alainfrisch/flexdll/deployments","created_at":"2013-12-12T14:04:07Z","updated_at":"2016-07-16T22:04:09Z","pushed_at":"2016-07-20T09:27:03Z","git_url":"git://github.com/alainfrisch/flexdll.git","ssh_url":"git@github.com:alainfrisch/flexdll.git","clone_url":"https://github.com/alainfrisch/flexdll.git","svn_url":"https://github.com/alainfrisch/flexdll","homepage":"","size":354,"stargazers_count":13,"watchers_count":13,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":8,"forks":9,"open_issues":8,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alainfrisch/flexdll/pulls/21"},"html":{"href":"https://github.com/alainfrisch/flexdll/pull/21"},"issue":{"href":"https://api.github.com/repos/alainfrisch/flexdll/issues/21"},"comments":{"href":"https://api.github.com/repos/alainfrisch/flexdll/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/alainfrisch/flexdll/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/alainfrisch/flexdll/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alainfrisch/flexdll/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/alainfrisch/flexdll/statuses/d24d374d611044b1b8a04e4d4dd70f1461b471c9"}}}}
{"actor":{"display_login":"alainfrisch"}}