{"action":"created","comment":{"url":"https://api.github.com/repos/Mellanox/libvma/pulls/comments/78911099","id":78911099,"diff_hunk":"@@ -604,8 +604,24 @@ void vma_stats_instance_create_epoll_block(int fd, iomux_func_stats_t* local_sta\n void vma_stats_instance_remove_epoll_block(iomux_func_stats_t* local_stats_addr)\n {\n \tg_lock_ep_stats.lock();\n-        epoll_stats_t* ep_stats = (epoll_stats_t*)g_p_stats_data_reader->pop_p_skt_stats(local_stats_addr);\n-        if (ep_stats)\n-                ep_stats->enabled = false;\n+\tiomux_func_stats_t* ep_func_stats = (iomux_func_stats_t*)g_p_stats_data_reader->pop_p_skt_stats(local_stats_addr);\n+\n+\tif (NULL == ep_func_stats) {\n+\t\tvlog_printf(VLOG_DEBUG, \"%s:%d: application vma_stats pointer is NULL\\n\", __func__, __LINE__);\n+\t\tg_lock_ep_stats.unlock();\n+\t\treturn;\n+\t}\n+\t// Search ep_mem block to release\n+\tfor (int i=0; i<NUM_OF_SUPPORTED_EPFDS; i++) {","path":"src/stats/stats_publisher.cpp","position":15,"original_position":15,"commit_id":"d1391a1fee7eb80545c9746e16e989cca9f1bde3","original_commit_id":"d1391a1fee7eb80545c9746e16e989cca9f1bde3","user":{"login":"igor-ivanov","id":9037172,"avatar_url":"https://avatars.githubusercontent.com/u/9037172?v=3","gravatar_id":"","url":"https://api.github.com/users/igor-ivanov","html_url":"https://github.com/igor-ivanov","followers_url":"https://api.github.com/users/igor-ivanov/followers","following_url":"https://api.github.com/users/igor-ivanov/following{/other_user}","gists_url":"https://api.github.com/users/igor-ivanov/gists{/gist_id}","starred_url":"https://api.github.com/users/igor-ivanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor-ivanov/subscriptions","organizations_url":"https://api.github.com/users/igor-ivanov/orgs","repos_url":"https://api.github.com/users/igor-ivanov/repos","events_url":"https://api.github.com/users/igor-ivanov/events{/privacy}","received_events_url":"https://api.github.com/users/igor-ivanov/received_events","type":"User","site_admin":false},"body":"@serglelv consider meeting to coding style as `for (int i = 0; i < NUM_OF_SUPPORTED_EPFDS; i++) {`","created_at":"2016-09-15T08:19:24Z","updated_at":"2016-09-15T08:19:24Z","html_url":"https://github.com/Mellanox/libvma/pull/209#discussion_r78911099","pull_request_url":"https://api.github.com/repos/Mellanox/libvma/pulls/209","_links":{"self":{"href":"https://api.github.com/repos/Mellanox/libvma/pulls/comments/78911099"},"html":{"href":"https://github.com/Mellanox/libvma/pull/209#discussion_r78911099"},"pull_request":{"href":"https://api.github.com/repos/Mellanox/libvma/pulls/209"}}},"pull_request":{"url":"https://api.github.com/repos/Mellanox/libvma/pulls/209","id":85001569,"html_url":"https://github.com/Mellanox/libvma/pull/209","diff_url":"https://github.com/Mellanox/libvma/pull/209.diff","patch_url":"https://github.com/Mellanox/libvma/pull/209.patch","issue_url":"https://api.github.com/repos/Mellanox/libvma/issues/209","number":209,"state":"open","locked":false,"title":"issue: 844121 Fixed bug in the stats epoll and split segment added","user":{"login":"serglelv","id":20067639,"avatar_url":"https://avatars.githubusercontent.com/u/20067639?v=3","gravatar_id":"","url":"https://api.github.com/users/serglelv","html_url":"https://github.com/serglelv","followers_url":"https://api.github.com/users/serglelv/followers","following_url":"https://api.github.com/users/serglelv/following{/other_user}","gists_url":"https://api.github.com/users/serglelv/gists{/gist_id}","starred_url":"https://api.github.com/users/serglelv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serglelv/subscriptions","organizations_url":"https://api.github.com/users/serglelv/orgs","repos_url":"https://api.github.com/users/serglelv/repos","events_url":"https://api.github.com/users/serglelv/events{/privacy}","received_events_url":"https://api.github.com/users/serglelv/received_events","type":"User","site_admin":false},"body":"Fixed bug in the stats remove epoll block. Added split the segment in case of a small window. Please review.\r\n@igor-ivanov @OphirMunk @NirNitzani @alexvm \r\n","created_at":"2016-09-13T08:01:46Z","updated_at":"2016-09-15T08:19:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7e7c004eca64bd14c7dcafc3ebcc68135ae6a98","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Mellanox/libvma/pulls/209/commits","review_comments_url":"https://api.github.com/repos/Mellanox/libvma/pulls/209/comments","review_comment_url":"https://api.github.com/repos/Mellanox/libvma/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Mellanox/libvma/issues/209/comments","statuses_url":"https://api.github.com/repos/Mellanox/libvma/statuses/d1391a1fee7eb80545c9746e16e989cca9f1bde3","head":{"label":"serglelv:pr/issue-844121","ref":"pr/issue-844121","sha":"d1391a1fee7eb80545c9746e16e989cca9f1bde3","user":{"login":"serglelv","id":20067639,"avatar_url":"https://avatars.githubusercontent.com/u/20067639?v=3","gravatar_id":"","url":"https://api.github.com/users/serglelv","html_url":"https://github.com/serglelv","followers_url":"https://api.github.com/users/serglelv/followers","following_url":"https://api.github.com/users/serglelv/following{/other_user}","gists_url":"https://api.github.com/users/serglelv/gists{/gist_id}","starred_url":"https://api.github.com/users/serglelv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serglelv/subscriptions","organizations_url":"https://api.github.com/users/serglelv/orgs","repos_url":"https://api.github.com/users/serglelv/repos","events_url":"https://api.github.com/users/serglelv/events{/privacy}","received_events_url":"https://api.github.com/users/serglelv/received_events","type":"User","site_admin":false},"repo":{"id":64386856,"name":"libvma","full_name":"serglelv/libvma","owner":{"login":"serglelv","id":20067639,"avatar_url":"https://avatars.githubusercontent.com/u/20067639?v=3","gravatar_id":"","url":"https://api.github.com/users/serglelv","html_url":"https://github.com/serglelv","followers_url":"https://api.github.com/users/serglelv/followers","following_url":"https://api.github.com/users/serglelv/following{/other_user}","gists_url":"https://api.github.com/users/serglelv/gists{/gist_id}","starred_url":"https://api.github.com/users/serglelv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serglelv/subscriptions","organizations_url":"https://api.github.com/users/serglelv/orgs","repos_url":"https://api.github.com/users/serglelv/repos","events_url":"https://api.github.com/users/serglelv/events{/privacy}","received_events_url":"https://api.github.com/users/serglelv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/serglelv/libvma","description":"Linux user space library for network socket acceleration based on RDMA compatible network adaptors","fork":true,"url":"https://api.github.com/repos/serglelv/libvma","forks_url":"https://api.github.com/repos/serglelv/libvma/forks","keys_url":"https://api.github.com/repos/serglelv/libvma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serglelv/libvma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serglelv/libvma/teams","hooks_url":"https://api.github.com/repos/serglelv/libvma/hooks","issue_events_url":"https://api.github.com/repos/serglelv/libvma/issues/events{/number}","events_url":"https://api.github.com/repos/serglelv/libvma/events","assignees_url":"https://api.github.com/repos/serglelv/libvma/assignees{/user}","branches_url":"https://api.github.com/repos/serglelv/libvma/branches{/branch}","tags_url":"https://api.github.com/repos/serglelv/libvma/tags","blobs_url":"https://api.github.com/repos/serglelv/libvma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serglelv/libvma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serglelv/libvma/git/refs{/sha}","trees_url":"https://api.github.com/repos/serglelv/libvma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serglelv/libvma/statuses/{sha}","languages_url":"https://api.github.com/repos/serglelv/libvma/languages","stargazers_url":"https://api.github.com/repos/serglelv/libvma/stargazers","contributors_url":"https://api.github.com/repos/serglelv/libvma/contributors","subscribers_url":"https://api.github.com/repos/serglelv/libvma/subscribers","subscription_url":"https://api.github.com/repos/serglelv/libvma/subscription","commits_url":"https://api.github.com/repos/serglelv/libvma/commits{/sha}","git_commits_url":"https://api.github.com/repos/serglelv/libvma/git/commits{/sha}","comments_url":"https://api.github.com/repos/serglelv/libvma/comments{/number}","issue_comment_url":"https://api.github.com/repos/serglelv/libvma/issues/comments{/number}","contents_url":"https://api.github.com/repos/serglelv/libvma/contents/{+path}","compare_url":"https://api.github.com/repos/serglelv/libvma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serglelv/libvma/merges","archive_url":"https://api.github.com/repos/serglelv/libvma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serglelv/libvma/downloads","issues_url":"https://api.github.com/repos/serglelv/libvma/issues{/number}","pulls_url":"https://api.github.com/repos/serglelv/libvma/pulls{/number}","milestones_url":"https://api.github.com/repos/serglelv/libvma/milestones{/number}","notifications_url":"https://api.github.com/repos/serglelv/libvma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serglelv/libvma/labels{/name}","releases_url":"https://api.github.com/repos/serglelv/libvma/releases{/id}","deployments_url":"https://api.github.com/repos/serglelv/libvma/deployments","created_at":"2016-07-28T10:35:26Z","updated_at":"2016-07-28T10:35:28Z","pushed_at":"2016-09-13T07:54:38Z","git_url":"git://github.com/serglelv/libvma.git","ssh_url":"git@github.com:serglelv/libvma.git","clone_url":"https://github.com/serglelv/libvma.git","svn_url":"https://github.com/serglelv/libvma","homepage":"http://www.mellanox.com/vma/","size":6137,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Mellanox:experimental_256B","ref":"experimental_256B","sha":"fad2e1d0fad53000824e8c7e367a36fe8cd33ffb","user":{"login":"Mellanox","id":5813145,"avatar_url":"https://avatars.githubusercontent.com/u/5813145?v=3","gravatar_id":"","url":"https://api.github.com/users/Mellanox","html_url":"https://github.com/Mellanox","followers_url":"https://api.github.com/users/Mellanox/followers","following_url":"https://api.github.com/users/Mellanox/following{/other_user}","gists_url":"https://api.github.com/users/Mellanox/gists{/gist_id}","starred_url":"https://api.github.com/users/Mellanox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mellanox/subscriptions","organizations_url":"https://api.github.com/users/Mellanox/orgs","repos_url":"https://api.github.com/users/Mellanox/repos","events_url":"https://api.github.com/users/Mellanox/events{/privacy}","received_events_url":"https://api.github.com/users/Mellanox/received_events","type":"Organization","site_admin":false},"repo":{"id":34852102,"name":"libvma","full_name":"Mellanox/libvma","owner":{"login":"Mellanox","id":5813145,"avatar_url":"https://avatars.githubusercontent.com/u/5813145?v=3","gravatar_id":"","url":"https://api.github.com/users/Mellanox","html_url":"https://github.com/Mellanox","followers_url":"https://api.github.com/users/Mellanox/followers","following_url":"https://api.github.com/users/Mellanox/following{/other_user}","gists_url":"https://api.github.com/users/Mellanox/gists{/gist_id}","starred_url":"https://api.github.com/users/Mellanox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mellanox/subscriptions","organizations_url":"https://api.github.com/users/Mellanox/orgs","repos_url":"https://api.github.com/users/Mellanox/repos","events_url":"https://api.github.com/users/Mellanox/events{/privacy}","received_events_url":"https://api.github.com/users/Mellanox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Mellanox/libvma","description":"Linux user space library for network socket acceleration based on RDMA compatible network adaptors","fork":false,"url":"https://api.github.com/repos/Mellanox/libvma","forks_url":"https://api.github.com/repos/Mellanox/libvma/forks","keys_url":"https://api.github.com/repos/Mellanox/libvma/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mellanox/libvma/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mellanox/libvma/teams","hooks_url":"https://api.github.com/repos/Mellanox/libvma/hooks","issue_events_url":"https://api.github.com/repos/Mellanox/libvma/issues/events{/number}","events_url":"https://api.github.com/repos/Mellanox/libvma/events","assignees_url":"https://api.github.com/repos/Mellanox/libvma/assignees{/user}","branches_url":"https://api.github.com/repos/Mellanox/libvma/branches{/branch}","tags_url":"https://api.github.com/repos/Mellanox/libvma/tags","blobs_url":"https://api.github.com/repos/Mellanox/libvma/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mellanox/libvma/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mellanox/libvma/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mellanox/libvma/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mellanox/libvma/statuses/{sha}","languages_url":"https://api.github.com/repos/Mellanox/libvma/languages","stargazers_url":"https://api.github.com/repos/Mellanox/libvma/stargazers","contributors_url":"https://api.github.com/repos/Mellanox/libvma/contributors","subscribers_url":"https://api.github.com/repos/Mellanox/libvma/subscribers","subscription_url":"https://api.github.com/repos/Mellanox/libvma/subscription","commits_url":"https://api.github.com/repos/Mellanox/libvma/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mellanox/libvma/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mellanox/libvma/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mellanox/libvma/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mellanox/libvma/contents/{+path}","compare_url":"https://api.github.com/repos/Mellanox/libvma/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mellanox/libvma/merges","archive_url":"https://api.github.com/repos/Mellanox/libvma/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mellanox/libvma/downloads","issues_url":"https://api.github.com/repos/Mellanox/libvma/issues{/number}","pulls_url":"https://api.github.com/repos/Mellanox/libvma/pulls{/number}","milestones_url":"https://api.github.com/repos/Mellanox/libvma/milestones{/number}","notifications_url":"https://api.github.com/repos/Mellanox/libvma/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mellanox/libvma/labels{/name}","releases_url":"https://api.github.com/repos/Mellanox/libvma/releases{/id}","deployments_url":"https://api.github.com/repos/Mellanox/libvma/deployments","created_at":"2015-04-30T11:58:19Z","updated_at":"2016-09-12T15:05:09Z","pushed_at":"2016-09-14T17:01:00Z","git_url":"git://github.com/Mellanox/libvma.git","ssh_url":"git@github.com:Mellanox/libvma.git","clone_url":"https://github.com/Mellanox/libvma.git","svn_url":"https://github.com/Mellanox/libvma","homepage":"http://www.mellanox.com/vma/","size":6867,"stargazers_count":52,"watchers_count":52,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":31,"forks":29,"open_issues":31,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Mellanox/libvma/pulls/209"},"html":{"href":"https://github.com/Mellanox/libvma/pull/209"},"issue":{"href":"https://api.github.com/repos/Mellanox/libvma/issues/209"},"comments":{"href":"https://api.github.com/repos/Mellanox/libvma/issues/209/comments"},"review_comments":{"href":"https://api.github.com/repos/Mellanox/libvma/pulls/209/comments"},"review_comment":{"href":"https://api.github.com/repos/Mellanox/libvma/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Mellanox/libvma/pulls/209/commits"},"statuses":{"href":"https://api.github.com/repos/Mellanox/libvma/statuses/d1391a1fee7eb80545c9746e16e989cca9f1bde3"}}}}
{"actor":{"display_login":"igor-ivanov"}}