{"action":"created","comment":{"url":"https://api.github.com/repos/DataValues/Number/pulls/comments/70244814","id":70244814,"diff_hunk":"@@ -473,14 +342,22 @@ public function getArrayValue() {\n \t * Constructs a new instance of the DataValue from the provided data.\n \t * This can round-trip with @see getArrayValue\n \t *\n+\t * @note: if the upperBound or lowerBound field is missing from $data,\n+\t * this returns an UnboundedQuantityValue, not a QuantityValue!\n+\t *\n \t * @since 0.1\n \t *\n \t * @param mixed $data\n \t *\n-\t * @return self\n+\t * @return UnboundedQuantityValue\n \t * @throws IllegalValueException\n \t */\n \tpublic static function newFromArray( $data ) {\n+\t\tif ( !isset( $data['upperBound'] ) || !isset( $data['lowerBound'] ) ) {","path":"src/DataValues/QuantityValue.php","position":254,"original_position":254,"commit_id":"4158750c3e97b2a6527ae1e862ffebb8ec243ddb","original_commit_id":"4158750c3e97b2a6527ae1e862ffebb8ec243ddb","user":{"login":"thiemowmde","id":6576639,"avatar_url":"https://avatars.githubusercontent.com/u/6576639?v=3","gravatar_id":"","url":"https://api.github.com/users/thiemowmde","html_url":"https://github.com/thiemowmde","followers_url":"https://api.github.com/users/thiemowmde/followers","following_url":"https://api.github.com/users/thiemowmde/following{/other_user}","gists_url":"https://api.github.com/users/thiemowmde/gists{/gist_id}","starred_url":"https://api.github.com/users/thiemowmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiemowmde/subscriptions","organizations_url":"https://api.github.com/users/thiemowmde/orgs","repos_url":"https://api.github.com/users/thiemowmde/repos","events_url":"https://api.github.com/users/thiemowmde/events{/privacy}","received_events_url":"https://api.github.com/users/thiemowmde/received_events","type":"User","site_admin":false},"body":"Must be `&&`. As far as I remember I said this before: Please add tests for at least one possible combination to cover this.","created_at":"2016-07-11T12:02:58Z","updated_at":"2016-07-11T12:02:58Z","html_url":"https://github.com/DataValues/Number/pull/66#discussion_r70244814","pull_request_url":"https://api.github.com/repos/DataValues/Number/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/DataValues/Number/pulls/comments/70244814"},"html":{"href":"https://github.com/DataValues/Number/pull/66#discussion_r70244814"},"pull_request":{"href":"https://api.github.com/repos/DataValues/Number/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/DataValues/Number/pulls/66","id":74974672,"html_url":"https://github.com/DataValues/Number/pull/66","diff_url":"https://github.com/DataValues/Number/pull/66.diff","patch_url":"https://github.com/DataValues/Number/pull/66.patch","issue_url":"https://api.github.com/repos/DataValues/Number/issues/66","number":66,"state":"open","locked":false,"title":"Factor UnboundedQuantityValue out of QuantityValue","user":{"login":"brightbyte","id":664717,"avatar_url":"https://avatars.githubusercontent.com/u/664717?v=3","gravatar_id":"","url":"https://api.github.com/users/brightbyte","html_url":"https://github.com/brightbyte","followers_url":"https://api.github.com/users/brightbyte/followers","following_url":"https://api.github.com/users/brightbyte/following{/other_user}","gists_url":"https://api.github.com/users/brightbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/brightbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brightbyte/subscriptions","organizations_url":"https://api.github.com/users/brightbyte/orgs","repos_url":"https://api.github.com/users/brightbyte/repos","events_url":"https://api.github.com/users/brightbyte/events{/privacy}","received_events_url":"https://api.github.com/users/brightbyte/received_events","type":"User","site_admin":false},"body":"Code experiment exploring the possibility to use subclassing to model unbounded vs bounded quantities.","created_at":"2016-06-23T15:23:48Z","updated_at":"2016-07-11T12:02:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc4d43c3595e94de82629f94ba5fd85bf1b7f514","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DataValues/Number/pulls/66/commits","review_comments_url":"https://api.github.com/repos/DataValues/Number/pulls/66/comments","review_comment_url":"https://api.github.com/repos/DataValues/Number/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataValues/Number/issues/66/comments","statuses_url":"https://api.github.com/repos/DataValues/Number/statuses/4158750c3e97b2a6527ae1e862ffebb8ec243ddb","head":{"label":"DataValues:BoundedQuantityValue","ref":"BoundedQuantityValue","sha":"4158750c3e97b2a6527ae1e862ffebb8ec243ddb","user":{"login":"DataValues","id":5956296,"avatar_url":"https://avatars.githubusercontent.com/u/5956296?v=3","gravatar_id":"","url":"https://api.github.com/users/DataValues","html_url":"https://github.com/DataValues","followers_url":"https://api.github.com/users/DataValues/followers","following_url":"https://api.github.com/users/DataValues/following{/other_user}","gists_url":"https://api.github.com/users/DataValues/gists{/gist_id}","starred_url":"https://api.github.com/users/DataValues/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataValues/subscriptions","organizations_url":"https://api.github.com/users/DataValues/orgs","repos_url":"https://api.github.com/users/DataValues/repos","events_url":"https://api.github.com/users/DataValues/events{/privacy}","received_events_url":"https://api.github.com/users/DataValues/received_events","type":"Organization","site_admin":false},"repo":{"id":14451549,"name":"Number","full_name":"DataValues/Number","owner":{"login":"DataValues","id":5956296,"avatar_url":"https://avatars.githubusercontent.com/u/5956296?v=3","gravatar_id":"","url":"https://api.github.com/users/DataValues","html_url":"https://github.com/DataValues","followers_url":"https://api.github.com/users/DataValues/followers","following_url":"https://api.github.com/users/DataValues/following{/other_user}","gists_url":"https://api.github.com/users/DataValues/gists{/gist_id}","starred_url":"https://api.github.com/users/DataValues/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataValues/subscriptions","organizations_url":"https://api.github.com/users/DataValues/orgs","repos_url":"https://api.github.com/users/DataValues/repos","events_url":"https://api.github.com/users/DataValues/events{/privacy}","received_events_url":"https://api.github.com/users/DataValues/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataValues/Number","description":"Numerical value objects, parsers and formatters","fork":false,"url":"https://api.github.com/repos/DataValues/Number","forks_url":"https://api.github.com/repos/DataValues/Number/forks","keys_url":"https://api.github.com/repos/DataValues/Number/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataValues/Number/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataValues/Number/teams","hooks_url":"https://api.github.com/repos/DataValues/Number/hooks","issue_events_url":"https://api.github.com/repos/DataValues/Number/issues/events{/number}","events_url":"https://api.github.com/repos/DataValues/Number/events","assignees_url":"https://api.github.com/repos/DataValues/Number/assignees{/user}","branches_url":"https://api.github.com/repos/DataValues/Number/branches{/branch}","tags_url":"https://api.github.com/repos/DataValues/Number/tags","blobs_url":"https://api.github.com/repos/DataValues/Number/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataValues/Number/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataValues/Number/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataValues/Number/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataValues/Number/statuses/{sha}","languages_url":"https://api.github.com/repos/DataValues/Number/languages","stargazers_url":"https://api.github.com/repos/DataValues/Number/stargazers","contributors_url":"https://api.github.com/repos/DataValues/Number/contributors","subscribers_url":"https://api.github.com/repos/DataValues/Number/subscribers","subscription_url":"https://api.github.com/repos/DataValues/Number/subscription","commits_url":"https://api.github.com/repos/DataValues/Number/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataValues/Number/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataValues/Number/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataValues/Number/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataValues/Number/contents/{+path}","compare_url":"https://api.github.com/repos/DataValues/Number/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataValues/Number/merges","archive_url":"https://api.github.com/repos/DataValues/Number/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataValues/Number/downloads","issues_url":"https://api.github.com/repos/DataValues/Number/issues{/number}","pulls_url":"https://api.github.com/repos/DataValues/Number/pulls{/number}","milestones_url":"https://api.github.com/repos/DataValues/Number/milestones{/number}","notifications_url":"https://api.github.com/repos/DataValues/Number/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataValues/Number/labels{/name}","releases_url":"https://api.github.com/repos/DataValues/Number/releases{/id}","deployments_url":"https://api.github.com/repos/DataValues/Number/deployments","created_at":"2013-11-16T17:47:13Z","updated_at":"2016-04-11T18:57:16Z","pushed_at":"2016-07-11T11:58:03Z","git_url":"git://github.com/DataValues/Number.git","ssh_url":"git@github.com:DataValues/Number.git","clone_url":"https://github.com/DataValues/Number.git","svn_url":"https://github.com/DataValues/Number","homepage":null,"size":220,"stargazers_count":10,"watchers_count":10,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":10,"forks":3,"open_issues":10,"watchers":10,"default_branch":"master"}},"base":{"label":"DataValues:master","ref":"master","sha":"49a5fbadc301cb4a9cde9dbfbad54c00a781ad90","user":{"login":"DataValues","id":5956296,"avatar_url":"https://avatars.githubusercontent.com/u/5956296?v=3","gravatar_id":"","url":"https://api.github.com/users/DataValues","html_url":"https://github.com/DataValues","followers_url":"https://api.github.com/users/DataValues/followers","following_url":"https://api.github.com/users/DataValues/following{/other_user}","gists_url":"https://api.github.com/users/DataValues/gists{/gist_id}","starred_url":"https://api.github.com/users/DataValues/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataValues/subscriptions","organizations_url":"https://api.github.com/users/DataValues/orgs","repos_url":"https://api.github.com/users/DataValues/repos","events_url":"https://api.github.com/users/DataValues/events{/privacy}","received_events_url":"https://api.github.com/users/DataValues/received_events","type":"Organization","site_admin":false},"repo":{"id":14451549,"name":"Number","full_name":"DataValues/Number","owner":{"login":"DataValues","id":5956296,"avatar_url":"https://avatars.githubusercontent.com/u/5956296?v=3","gravatar_id":"","url":"https://api.github.com/users/DataValues","html_url":"https://github.com/DataValues","followers_url":"https://api.github.com/users/DataValues/followers","following_url":"https://api.github.com/users/DataValues/following{/other_user}","gists_url":"https://api.github.com/users/DataValues/gists{/gist_id}","starred_url":"https://api.github.com/users/DataValues/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataValues/subscriptions","organizations_url":"https://api.github.com/users/DataValues/orgs","repos_url":"https://api.github.com/users/DataValues/repos","events_url":"https://api.github.com/users/DataValues/events{/privacy}","received_events_url":"https://api.github.com/users/DataValues/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataValues/Number","description":"Numerical value objects, parsers and formatters","fork":false,"url":"https://api.github.com/repos/DataValues/Number","forks_url":"https://api.github.com/repos/DataValues/Number/forks","keys_url":"https://api.github.com/repos/DataValues/Number/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataValues/Number/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataValues/Number/teams","hooks_url":"https://api.github.com/repos/DataValues/Number/hooks","issue_events_url":"https://api.github.com/repos/DataValues/Number/issues/events{/number}","events_url":"https://api.github.com/repos/DataValues/Number/events","assignees_url":"https://api.github.com/repos/DataValues/Number/assignees{/user}","branches_url":"https://api.github.com/repos/DataValues/Number/branches{/branch}","tags_url":"https://api.github.com/repos/DataValues/Number/tags","blobs_url":"https://api.github.com/repos/DataValues/Number/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataValues/Number/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataValues/Number/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataValues/Number/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataValues/Number/statuses/{sha}","languages_url":"https://api.github.com/repos/DataValues/Number/languages","stargazers_url":"https://api.github.com/repos/DataValues/Number/stargazers","contributors_url":"https://api.github.com/repos/DataValues/Number/contributors","subscribers_url":"https://api.github.com/repos/DataValues/Number/subscribers","subscription_url":"https://api.github.com/repos/DataValues/Number/subscription","commits_url":"https://api.github.com/repos/DataValues/Number/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataValues/Number/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataValues/Number/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataValues/Number/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataValues/Number/contents/{+path}","compare_url":"https://api.github.com/repos/DataValues/Number/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataValues/Number/merges","archive_url":"https://api.github.com/repos/DataValues/Number/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataValues/Number/downloads","issues_url":"https://api.github.com/repos/DataValues/Number/issues{/number}","pulls_url":"https://api.github.com/repos/DataValues/Number/pulls{/number}","milestones_url":"https://api.github.com/repos/DataValues/Number/milestones{/number}","notifications_url":"https://api.github.com/repos/DataValues/Number/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataValues/Number/labels{/name}","releases_url":"https://api.github.com/repos/DataValues/Number/releases{/id}","deployments_url":"https://api.github.com/repos/DataValues/Number/deployments","created_at":"2013-11-16T17:47:13Z","updated_at":"2016-04-11T18:57:16Z","pushed_at":"2016-07-11T11:58:03Z","git_url":"git://github.com/DataValues/Number.git","ssh_url":"git@github.com:DataValues/Number.git","clone_url":"https://github.com/DataValues/Number.git","svn_url":"https://github.com/DataValues/Number","homepage":null,"size":220,"stargazers_count":10,"watchers_count":10,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":10,"forks":3,"open_issues":10,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataValues/Number/pulls/66"},"html":{"href":"https://github.com/DataValues/Number/pull/66"},"issue":{"href":"https://api.github.com/repos/DataValues/Number/issues/66"},"comments":{"href":"https://api.github.com/repos/DataValues/Number/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/DataValues/Number/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/DataValues/Number/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataValues/Number/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/DataValues/Number/statuses/4158750c3e97b2a6527ae1e862ffebb8ec243ddb"}}}}
{"actor":{"display_login":"thiemowmde"}}