{"action":"created","comment":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/comments/64292137","id":64292137,"diff_hunk":"@@ -715,9 +715,19 @@ var LibraryGL = {\n     switch(name_) {\n       case 0x1F00 /* GL_VENDOR */:\n       case 0x1F01 /* GL_RENDERER */:\n-      case 0x1F02 /* GL_VERSION */:\n         ret = allocate(intArrayFromString(GLctx.getParameter(name_)), 'i8', ALLOC_NORMAL);\n         break;\n+      case 0x1F02 /* GL_VERSION */:\n+        var glVersion = GLctx.getParameter(GLctx.VERSION);\n+        // return GLES version string corresponding to the version of the WebGL context\n+#if USE_WEBGL2\n+        if (GLctx.canvas.GLctxObject.version >= 2)","path":"src/library_gl.js","position":11,"original_position":11,"commit_id":"3e460d1d199b113d89b4b86c7f5df81bd687922b","original_commit_id":"3e460d1d199b113d89b4b86c7f5df81bd687922b","user":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"body":"`{}` when if and else bodies etc. are on another line","created_at":"2016-05-23T21:26:33Z","updated_at":"2016-05-23T21:26:33Z","html_url":"https://github.com/kripken/emscripten/pull/4345#discussion_r64292137","pull_request_url":"https://api.github.com/repos/kripken/emscripten/pulls/4345","_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/comments/64292137"},"html":{"href":"https://github.com/kripken/emscripten/pull/4345#discussion_r64292137"},"pull_request":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/4345"}}},"pull_request":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/4345","id":70972306,"html_url":"https://github.com/kripken/emscripten/pull/4345","diff_url":"https://github.com/kripken/emscripten/pull/4345.diff","patch_url":"https://github.com/kripken/emscripten/pull/4345.patch","issue_url":"https://api.github.com/repos/kripken/emscripten/issues/4345","number":4345,"state":"open","locked":false,"title":"Use WebGL context version to construct GL_VERSION and GL_SHADING_LANGUAGE_VERSION","user":{"login":"rfeneon","id":12559029,"avatar_url":"https://avatars.githubusercontent.com/u/12559029?v=3","gravatar_id":"","url":"https://api.github.com/users/rfeneon","html_url":"https://github.com/rfeneon","followers_url":"https://api.github.com/users/rfeneon/followers","following_url":"https://api.github.com/users/rfeneon/following{/other_user}","gists_url":"https://api.github.com/users/rfeneon/gists{/gist_id}","starred_url":"https://api.github.com/users/rfeneon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfeneon/subscriptions","organizations_url":"https://api.github.com/users/rfeneon/orgs","repos_url":"https://api.github.com/users/rfeneon/repos","events_url":"https://api.github.com/users/rfeneon/events{/privacy}","received_events_url":"https://api.github.com/users/rfeneon/received_events","type":"User","site_admin":false},"body":"This actually fixes the GL_VERSION string that must be of the form \"OpenGL ES N.M ...\" (OpenGL ES 2 and 3 specifications sections 6.1.5/6.1.6 resp.).\r\nThis also fixes the GL_SHADING_LANGUAGE_VERSION string in the case where the WebGL version string is not valid, especially with Microsoft Edge which returns a version of 0.96 instead of 1.0.\r\nThe WebGL version information is returned in the vendor-specific information field.","created_at":"2016-05-22T09:26:34Z","updated_at":"2016-05-23T21:26:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c4b7d90dd77c7c66cab0e75a802a5acc69edac8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kripken/emscripten/pulls/4345/commits","review_comments_url":"https://api.github.com/repos/kripken/emscripten/pulls/4345/comments","review_comment_url":"https://api.github.com/repos/kripken/emscripten/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kripken/emscripten/issues/4345/comments","statuses_url":"https://api.github.com/repos/kripken/emscripten/statuses/3e460d1d199b113d89b4b86c7f5df81bd687922b","head":{"label":"rfeneon:gl_version","ref":"gl_version","sha":"3e460d1d199b113d89b4b86c7f5df81bd687922b","user":{"login":"rfeneon","id":12559029,"avatar_url":"https://avatars.githubusercontent.com/u/12559029?v=3","gravatar_id":"","url":"https://api.github.com/users/rfeneon","html_url":"https://github.com/rfeneon","followers_url":"https://api.github.com/users/rfeneon/followers","following_url":"https://api.github.com/users/rfeneon/following{/other_user}","gists_url":"https://api.github.com/users/rfeneon/gists{/gist_id}","starred_url":"https://api.github.com/users/rfeneon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfeneon/subscriptions","organizations_url":"https://api.github.com/users/rfeneon/orgs","repos_url":"https://api.github.com/users/rfeneon/repos","events_url":"https://api.github.com/users/rfeneon/events{/privacy}","received_events_url":"https://api.github.com/users/rfeneon/received_events","type":"User","site_admin":false},"repo":{"id":59401363,"name":"emscripten","full_name":"rfeneon/emscripten","owner":{"login":"rfeneon","id":12559029,"avatar_url":"https://avatars.githubusercontent.com/u/12559029?v=3","gravatar_id":"","url":"https://api.github.com/users/rfeneon","html_url":"https://github.com/rfeneon","followers_url":"https://api.github.com/users/rfeneon/followers","following_url":"https://api.github.com/users/rfeneon/following{/other_user}","gists_url":"https://api.github.com/users/rfeneon/gists{/gist_id}","starred_url":"https://api.github.com/users/rfeneon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfeneon/subscriptions","organizations_url":"https://api.github.com/users/rfeneon/orgs","repos_url":"https://api.github.com/users/rfeneon/repos","events_url":"https://api.github.com/users/rfeneon/events{/privacy}","received_events_url":"https://api.github.com/users/rfeneon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rfeneon/emscripten","description":"Emscripten: An LLVM-to-JavaScript Compiler","fork":true,"url":"https://api.github.com/repos/rfeneon/emscripten","forks_url":"https://api.github.com/repos/rfeneon/emscripten/forks","keys_url":"https://api.github.com/repos/rfeneon/emscripten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rfeneon/emscripten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rfeneon/emscripten/teams","hooks_url":"https://api.github.com/repos/rfeneon/emscripten/hooks","issue_events_url":"https://api.github.com/repos/rfeneon/emscripten/issues/events{/number}","events_url":"https://api.github.com/repos/rfeneon/emscripten/events","assignees_url":"https://api.github.com/repos/rfeneon/emscripten/assignees{/user}","branches_url":"https://api.github.com/repos/rfeneon/emscripten/branches{/branch}","tags_url":"https://api.github.com/repos/rfeneon/emscripten/tags","blobs_url":"https://api.github.com/repos/rfeneon/emscripten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rfeneon/emscripten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rfeneon/emscripten/git/refs{/sha}","trees_url":"https://api.github.com/repos/rfeneon/emscripten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rfeneon/emscripten/statuses/{sha}","languages_url":"https://api.github.com/repos/rfeneon/emscripten/languages","stargazers_url":"https://api.github.com/repos/rfeneon/emscripten/stargazers","contributors_url":"https://api.github.com/repos/rfeneon/emscripten/contributors","subscribers_url":"https://api.github.com/repos/rfeneon/emscripten/subscribers","subscription_url":"https://api.github.com/repos/rfeneon/emscripten/subscription","commits_url":"https://api.github.com/repos/rfeneon/emscripten/commits{/sha}","git_commits_url":"https://api.github.com/repos/rfeneon/emscripten/git/commits{/sha}","comments_url":"https://api.github.com/repos/rfeneon/emscripten/comments{/number}","issue_comment_url":"https://api.github.com/repos/rfeneon/emscripten/issues/comments{/number}","contents_url":"https://api.github.com/repos/rfeneon/emscripten/contents/{+path}","compare_url":"https://api.github.com/repos/rfeneon/emscripten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rfeneon/emscripten/merges","archive_url":"https://api.github.com/repos/rfeneon/emscripten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rfeneon/emscripten/downloads","issues_url":"https://api.github.com/repos/rfeneon/emscripten/issues{/number}","pulls_url":"https://api.github.com/repos/rfeneon/emscripten/pulls{/number}","milestones_url":"https://api.github.com/repos/rfeneon/emscripten/milestones{/number}","notifications_url":"https://api.github.com/repos/rfeneon/emscripten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rfeneon/emscripten/labels{/name}","releases_url":"https://api.github.com/repos/rfeneon/emscripten/releases{/id}","deployments_url":"https://api.github.com/repos/rfeneon/emscripten/deployments","created_at":"2016-05-22T08:02:31Z","updated_at":"2016-05-22T08:02:53Z","pushed_at":"2016-05-22T09:08:46Z","git_url":"git://github.com/rfeneon/emscripten.git","ssh_url":"git@github.com:rfeneon/emscripten.git","clone_url":"https://github.com/rfeneon/emscripten.git","svn_url":"https://github.com/rfeneon/emscripten","homepage":"","size":138871,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kripken:incoming","ref":"incoming","sha":"06db15f50e9277e4b3e62a0a95922feed3a67bbf","user":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"repo":{"id":1357796,"name":"emscripten","full_name":"kripken/emscripten","owner":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kripken/emscripten","description":"Emscripten: An LLVM-to-JavaScript Compiler","fork":false,"url":"https://api.github.com/repos/kripken/emscripten","forks_url":"https://api.github.com/repos/kripken/emscripten/forks","keys_url":"https://api.github.com/repos/kripken/emscripten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kripken/emscripten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kripken/emscripten/teams","hooks_url":"https://api.github.com/repos/kripken/emscripten/hooks","issue_events_url":"https://api.github.com/repos/kripken/emscripten/issues/events{/number}","events_url":"https://api.github.com/repos/kripken/emscripten/events","assignees_url":"https://api.github.com/repos/kripken/emscripten/assignees{/user}","branches_url":"https://api.github.com/repos/kripken/emscripten/branches{/branch}","tags_url":"https://api.github.com/repos/kripken/emscripten/tags","blobs_url":"https://api.github.com/repos/kripken/emscripten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kripken/emscripten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kripken/emscripten/git/refs{/sha}","trees_url":"https://api.github.com/repos/kripken/emscripten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kripken/emscripten/statuses/{sha}","languages_url":"https://api.github.com/repos/kripken/emscripten/languages","stargazers_url":"https://api.github.com/repos/kripken/emscripten/stargazers","contributors_url":"https://api.github.com/repos/kripken/emscripten/contributors","subscribers_url":"https://api.github.com/repos/kripken/emscripten/subscribers","subscription_url":"https://api.github.com/repos/kripken/emscripten/subscription","commits_url":"https://api.github.com/repos/kripken/emscripten/commits{/sha}","git_commits_url":"https://api.github.com/repos/kripken/emscripten/git/commits{/sha}","comments_url":"https://api.github.com/repos/kripken/emscripten/comments{/number}","issue_comment_url":"https://api.github.com/repos/kripken/emscripten/issues/comments{/number}","contents_url":"https://api.github.com/repos/kripken/emscripten/contents/{+path}","compare_url":"https://api.github.com/repos/kripken/emscripten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kripken/emscripten/merges","archive_url":"https://api.github.com/repos/kripken/emscripten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kripken/emscripten/downloads","issues_url":"https://api.github.com/repos/kripken/emscripten/issues{/number}","pulls_url":"https://api.github.com/repos/kripken/emscripten/pulls{/number}","milestones_url":"https://api.github.com/repos/kripken/emscripten/milestones{/number}","notifications_url":"https://api.github.com/repos/kripken/emscripten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kripken/emscripten/labels{/name}","releases_url":"https://api.github.com/repos/kripken/emscripten/releases{/id}","deployments_url":"https://api.github.com/repos/kripken/emscripten/deployments","created_at":"2011-02-12T05:23:30Z","updated_at":"2016-05-23T15:12:27Z","pushed_at":"2016-05-23T17:04:56Z","git_url":"git://github.com/kripken/emscripten.git","ssh_url":"git@github.com:kripken/emscripten.git","clone_url":"https://github.com/kripken/emscripten.git","svn_url":"https://github.com/kripken/emscripten","homepage":"","size":169127,"stargazers_count":10197,"watchers_count":10197,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1244,"mirror_url":null,"open_issues_count":798,"forks":1244,"open_issues":798,"watchers":10197,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/4345"},"html":{"href":"https://github.com/kripken/emscripten/pull/4345"},"issue":{"href":"https://api.github.com/repos/kripken/emscripten/issues/4345"},"comments":{"href":"https://api.github.com/repos/kripken/emscripten/issues/4345/comments"},"review_comments":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/4345/comments"},"review_comment":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/4345/commits"},"statuses":{"href":"https://api.github.com/repos/kripken/emscripten/statuses/3e460d1d199b113d89b4b86c7f5df81bd687922b"}}}}
{"actor":{"display_login":"kripken"}}