{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/19644","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/19644/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/19644/comments","events_url":"https://api.github.com/repos/docker/docker/issues/19644/events","html_url":"https://github.com/docker/docker/issues/19644","id":128418176,"number":19644,"title":"Improve docker build with messages when firing rules","user":{"login":"k3ck3c","id":3126227,"avatar_url":"https://avatars.githubusercontent.com/u/3126227?v=3","gravatar_id":"","url":"https://api.github.com/users/k3ck3c","html_url":"https://github.com/k3ck3c","followers_url":"https://api.github.com/users/k3ck3c/followers","following_url":"https://api.github.com/users/k3ck3c/following{/other_user}","gists_url":"https://api.github.com/users/k3ck3c/gists{/gist_id}","starred_url":"https://api.github.com/users/k3ck3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k3ck3c/subscriptions","organizations_url":"https://api.github.com/users/k3ck3c/orgs","repos_url":"https://api.github.com/users/k3ck3c/repos","events_url":"https://api.github.com/users/k3ck3c/events{/privacy}","received_events_url":"https://api.github.com/users/k3ck3c/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/area/builder","name":"area/builder","color":"0052cc"},{"url":"https://api.github.com/repos/docker/docker/labels/kind/feature","name":"kind/feature","color":"AAB3AB"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-01-24T19:11:03Z","updated_at":"2016-04-28T15:23:17Z","closed_at":null,"body":"As pylint for Python, we could improve docker build by integrating hadolint from Lukas martinelli\r\nhttps://github.com/lukasmartinelli/hadolint\r\nand his online checker\r\nhttp://hadolint.lukasmartinelli.ch/\r\n\r\ndocker build would still build an image, but the author could see the mistakes and immediately correct his Dockerfile"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/215464345","html_url":"https://github.com/docker/docker/issues/19644#issuecomment-215464345","issue_url":"https://api.github.com/repos/docker/docker/issues/19644","id":215464345,"user":{"login":"bamarni","id":1205386,"avatar_url":"https://avatars.githubusercontent.com/u/1205386?v=3","gravatar_id":"","url":"https://api.github.com/users/bamarni","html_url":"https://github.com/bamarni","followers_url":"https://api.github.com/users/bamarni/followers","following_url":"https://api.github.com/users/bamarni/following{/other_user}","gists_url":"https://api.github.com/users/bamarni/gists{/gist_id}","starred_url":"https://api.github.com/users/bamarni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bamarni/subscriptions","organizations_url":"https://api.github.com/users/bamarni/orgs","repos_url":"https://api.github.com/users/bamarni/repos","events_url":"https://api.github.com/users/bamarni/events{/privacy}","received_events_url":"https://api.github.com/users/bamarni/received_events","type":"User","site_admin":false},"created_at":"2016-04-28T15:23:17Z","updated_at":"2016-04-28T15:23:17Z","body":"> So, in my opinion; having functionality to check a Dockerfile for syntax errors could be considered\r\n\r\nWhat about also making it the default behaviour (not try to build in case of syntax errors)? It is mainly useful for blocks like this : https://github.com/docker-library/redis/blob/bc3ca850f4a2a2e9e5d4b3b8272e5536b4d21d24/3.0/Dockerfile#L28. Here it is very easy to miss a line continuation or make a typo, and time-consuming to restart (no cache layer can be used)."}}