{"action":"created","comment":{"url":"https://api.github.com/repos/lathiat/nss-mdns/pulls/comments/80302044","id":80302044,"diff_hunk":"@@ -51,18 +51,8 @@ lib_LTLIBRARIES += \\\n \tlibnss_mdns6_minimal.la\n endif\n \n-noinst_PROGRAMS = nss-test\n-sources = util.c util.h\n-\n-if ENABLE_AVAHI\n-sources += avahi.c avahi.h\n-noinst_PROGRAMS += avahi-test\n-endif\n-\n-if ENABLE_LEGACY\n-sources += query.c query.h dns.c dns.h\n-noinst_PROGRAMS += mdns-test\n-endif\n+noinst_PROGRAMS = nss-test avahi-test","path":"src/Makefile.am","position":null,"original_position":16,"commit_id":"cd4097ffd82ee3a0490aabd2b73a44b40540cf41","original_commit_id":"7b4cae25a5373116922b7a3161ea5ce169e24568","user":{"login":"agoode","id":59842,"avatar_url":"https://avatars.githubusercontent.com/u/59842?v=3","gravatar_id":"","url":"https://api.github.com/users/agoode","html_url":"https://github.com/agoode","followers_url":"https://api.github.com/users/agoode/followers","following_url":"https://api.github.com/users/agoode/following{/other_user}","gists_url":"https://api.github.com/users/agoode/gists{/gist_id}","starred_url":"https://api.github.com/users/agoode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agoode/subscriptions","organizations_url":"https://api.github.com/users/agoode/orgs","repos_url":"https://api.github.com/users/agoode/repos","events_url":"https://api.github.com/users/agoode/events{/privacy}","received_events_url":"https://api.github.com/users/agoode/received_events","type":"User","site_admin":false},"body":"Ah, I thought `make check` would run them. Thanks for that.","created_at":"2016-09-23T18:36:51Z","updated_at":"2016-09-23T18:36:51Z","html_url":"https://github.com/lathiat/nss-mdns/pull/1#discussion_r80302044","pull_request_url":"https://api.github.com/repos/lathiat/nss-mdns/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/lathiat/nss-mdns/pulls/comments/80302044"},"html":{"href":"https://github.com/lathiat/nss-mdns/pull/1#discussion_r80302044"},"pull_request":{"href":"https://api.github.com/repos/lathiat/nss-mdns/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/lathiat/nss-mdns/pulls/1","id":80779463,"html_url":"https://github.com/lathiat/nss-mdns/pull/1","diff_url":"https://github.com/lathiat/nss-mdns/pull/1.diff","patch_url":"https://github.com/lathiat/nss-mdns/pull/1.patch","issue_url":"https://api.github.com/repos/lathiat/nss-mdns/issues/1","number":1,"state":"open","locked":false,"title":"Remove long-deprecated LEGACY mode","user":{"login":"agoode","id":59842,"avatar_url":"https://avatars.githubusercontent.com/u/59842?v=3","gravatar_id":"","url":"https://api.github.com/users/agoode","html_url":"https://github.com/agoode","followers_url":"https://api.github.com/users/agoode/followers","following_url":"https://api.github.com/users/agoode/following{/other_user}","gists_url":"https://api.github.com/users/agoode/gists{/gist_id}","starred_url":"https://api.github.com/users/agoode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agoode/subscriptions","organizations_url":"https://api.github.com/users/agoode/orgs","repos_url":"https://api.github.com/users/agoode/repos","events_url":"https://api.github.com/users/agoode/events{/privacy}","received_events_url":"https://api.github.com/users/agoode/received_events","type":"User","site_admin":false},"body":"Removing this mode allows both `ENABLE_AVAHI` and `ENABLE_LEGACY` defines to be removed and eliminates a lot of code.","created_at":"2016-08-10T11:43:21Z","updated_at":"2016-09-23T18:36:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1a08e5eda3f11ec56daeb5840ace2d776fd9943","assignee":{"login":"lathiat","id":290673,"avatar_url":"https://avatars.githubusercontent.com/u/290673?v=3","gravatar_id":"","url":"https://api.github.com/users/lathiat","html_url":"https://github.com/lathiat","followers_url":"https://api.github.com/users/lathiat/followers","following_url":"https://api.github.com/users/lathiat/following{/other_user}","gists_url":"https://api.github.com/users/lathiat/gists{/gist_id}","starred_url":"https://api.github.com/users/lathiat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lathiat/subscriptions","organizations_url":"https://api.github.com/users/lathiat/orgs","repos_url":"https://api.github.com/users/lathiat/repos","events_url":"https://api.github.com/users/lathiat/events{/privacy}","received_events_url":"https://api.github.com/users/lathiat/received_events","type":"User","site_admin":false},"assignees":[{"login":"lathiat","id":290673,"avatar_url":"https://avatars.githubusercontent.com/u/290673?v=3","gravatar_id":"","url":"https://api.github.com/users/lathiat","html_url":"https://github.com/lathiat","followers_url":"https://api.github.com/users/lathiat/followers","following_url":"https://api.github.com/users/lathiat/following{/other_user}","gists_url":"https://api.github.com/users/lathiat/gists{/gist_id}","starred_url":"https://api.github.com/users/lathiat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lathiat/subscriptions","organizations_url":"https://api.github.com/users/lathiat/orgs","repos_url":"https://api.github.com/users/lathiat/repos","events_url":"https://api.github.com/users/lathiat/events{/privacy}","received_events_url":"https://api.github.com/users/lathiat/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/lathiat/nss-mdns/milestones/1","html_url":"https://github.com/lathiat/nss-mdns/milestones/0.11%20release","labels_url":"https://api.github.com/repos/lathiat/nss-mdns/milestones/1/labels","id":1980660,"number":1,"title":"0.11 release","description":"The first release in some time!","creator":{"login":"agoode","id":59842,"avatar_url":"https://avatars.githubusercontent.com/u/59842?v=3","gravatar_id":"","url":"https://api.github.com/users/agoode","html_url":"https://github.com/agoode","followers_url":"https://api.github.com/users/agoode/followers","following_url":"https://api.github.com/users/agoode/following{/other_user}","gists_url":"https://api.github.com/users/agoode/gists{/gist_id}","starred_url":"https://api.github.com/users/agoode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agoode/subscriptions","organizations_url":"https://api.github.com/users/agoode/orgs","repos_url":"https://api.github.com/users/agoode/repos","events_url":"https://api.github.com/users/agoode/events{/privacy}","received_events_url":"https://api.github.com/users/agoode/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":2,"state":"open","created_at":"2016-09-02T17:55:18Z","updated_at":"2016-09-02T17:57:33Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/lathiat/nss-mdns/pulls/1/commits","review_comments_url":"https://api.github.com/repos/lathiat/nss-mdns/pulls/1/comments","review_comment_url":"https://api.github.com/repos/lathiat/nss-mdns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lathiat/nss-mdns/issues/1/comments","statuses_url":"https://api.github.com/repos/lathiat/nss-mdns/statuses/cd4097ffd82ee3a0490aabd2b73a44b40540cf41","head":{"label":"agoode:legacy","ref":"legacy","sha":"cd4097ffd82ee3a0490aabd2b73a44b40540cf41","user":{"login":"agoode","id":59842,"avatar_url":"https://avatars.githubusercontent.com/u/59842?v=3","gravatar_id":"","url":"https://api.github.com/users/agoode","html_url":"https://github.com/agoode","followers_url":"https://api.github.com/users/agoode/followers","following_url":"https://api.github.com/users/agoode/following{/other_user}","gists_url":"https://api.github.com/users/agoode/gists{/gist_id}","starred_url":"https://api.github.com/users/agoode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agoode/subscriptions","organizations_url":"https://api.github.com/users/agoode/orgs","repos_url":"https://api.github.com/users/agoode/repos","events_url":"https://api.github.com/users/agoode/events{/privacy}","received_events_url":"https://api.github.com/users/agoode/received_events","type":"User","site_admin":false},"repo":{"id":65320528,"name":"nss-mdns","full_name":"agoode/nss-mdns","owner":{"login":"agoode","id":59842,"avatar_url":"https://avatars.githubusercontent.com/u/59842?v=3","gravatar_id":"","url":"https://api.github.com/users/agoode","html_url":"https://github.com/agoode","followers_url":"https://api.github.com/users/agoode/followers","following_url":"https://api.github.com/users/agoode/following{/other_user}","gists_url":"https://api.github.com/users/agoode/gists{/gist_id}","starred_url":"https://api.github.com/users/agoode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agoode/subscriptions","organizations_url":"https://api.github.com/users/agoode/orgs","repos_url":"https://api.github.com/users/agoode/repos","events_url":"https://api.github.com/users/agoode/events{/privacy}","received_events_url":"https://api.github.com/users/agoode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agoode/nss-mdns","description":null,"fork":true,"url":"https://api.github.com/repos/agoode/nss-mdns","forks_url":"https://api.github.com/repos/agoode/nss-mdns/forks","keys_url":"https://api.github.com/repos/agoode/nss-mdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agoode/nss-mdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agoode/nss-mdns/teams","hooks_url":"https://api.github.com/repos/agoode/nss-mdns/hooks","issue_events_url":"https://api.github.com/repos/agoode/nss-mdns/issues/events{/number}","events_url":"https://api.github.com/repos/agoode/nss-mdns/events","assignees_url":"https://api.github.com/repos/agoode/nss-mdns/assignees{/user}","branches_url":"https://api.github.com/repos/agoode/nss-mdns/branches{/branch}","tags_url":"https://api.github.com/repos/agoode/nss-mdns/tags","blobs_url":"https://api.github.com/repos/agoode/nss-mdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agoode/nss-mdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agoode/nss-mdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/agoode/nss-mdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agoode/nss-mdns/statuses/{sha}","languages_url":"https://api.github.com/repos/agoode/nss-mdns/languages","stargazers_url":"https://api.github.com/repos/agoode/nss-mdns/stargazers","contributors_url":"https://api.github.com/repos/agoode/nss-mdns/contributors","subscribers_url":"https://api.github.com/repos/agoode/nss-mdns/subscribers","subscription_url":"https://api.github.com/repos/agoode/nss-mdns/subscription","commits_url":"https://api.github.com/repos/agoode/nss-mdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/agoode/nss-mdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/agoode/nss-mdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/agoode/nss-mdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/agoode/nss-mdns/contents/{+path}","compare_url":"https://api.github.com/repos/agoode/nss-mdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agoode/nss-mdns/merges","archive_url":"https://api.github.com/repos/agoode/nss-mdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agoode/nss-mdns/downloads","issues_url":"https://api.github.com/repos/agoode/nss-mdns/issues{/number}","pulls_url":"https://api.github.com/repos/agoode/nss-mdns/pulls{/number}","milestones_url":"https://api.github.com/repos/agoode/nss-mdns/milestones{/number}","notifications_url":"https://api.github.com/repos/agoode/nss-mdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agoode/nss-mdns/labels{/name}","releases_url":"https://api.github.com/repos/agoode/nss-mdns/releases{/id}","deployments_url":"https://api.github.com/repos/agoode/nss-mdns/deployments","created_at":"2016-08-09T18:58:02Z","updated_at":"2016-08-09T18:58:03Z","pushed_at":"2016-09-23T18:36:48Z","git_url":"git://github.com/agoode/nss-mdns.git","ssh_url":"git@github.com:agoode/nss-mdns.git","clone_url":"https://github.com/agoode/nss-mdns.git","svn_url":"https://github.com/agoode/nss-mdns","homepage":null,"size":107,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lathiat:master","ref":"master","sha":"8c2abeb69f0ff717d7fc593dd7118fe2596b5425","user":{"login":"lathiat","id":290673,"avatar_url":"https://avatars.githubusercontent.com/u/290673?v=3","gravatar_id":"","url":"https://api.github.com/users/lathiat","html_url":"https://github.com/lathiat","followers_url":"https://api.github.com/users/lathiat/followers","following_url":"https://api.github.com/users/lathiat/following{/other_user}","gists_url":"https://api.github.com/users/lathiat/gists{/gist_id}","starred_url":"https://api.github.com/users/lathiat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lathiat/subscriptions","organizations_url":"https://api.github.com/users/lathiat/orgs","repos_url":"https://api.github.com/users/lathiat/repos","events_url":"https://api.github.com/users/lathiat/events{/privacy}","received_events_url":"https://api.github.com/users/lathiat/received_events","type":"User","site_admin":false},"repo":{"id":65299022,"name":"nss-mdns","full_name":"lathiat/nss-mdns","owner":{"login":"lathiat","id":290673,"avatar_url":"https://avatars.githubusercontent.com/u/290673?v=3","gravatar_id":"","url":"https://api.github.com/users/lathiat","html_url":"https://github.com/lathiat","followers_url":"https://api.github.com/users/lathiat/followers","following_url":"https://api.github.com/users/lathiat/following{/other_user}","gists_url":"https://api.github.com/users/lathiat/gists{/gist_id}","starred_url":"https://api.github.com/users/lathiat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lathiat/subscriptions","organizations_url":"https://api.github.com/users/lathiat/orgs","repos_url":"https://api.github.com/users/lathiat/repos","events_url":"https://api.github.com/users/lathiat/events{/privacy}","received_events_url":"https://api.github.com/users/lathiat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lathiat/nss-mdns","description":null,"fork":false,"url":"https://api.github.com/repos/lathiat/nss-mdns","forks_url":"https://api.github.com/repos/lathiat/nss-mdns/forks","keys_url":"https://api.github.com/repos/lathiat/nss-mdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lathiat/nss-mdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lathiat/nss-mdns/teams","hooks_url":"https://api.github.com/repos/lathiat/nss-mdns/hooks","issue_events_url":"https://api.github.com/repos/lathiat/nss-mdns/issues/events{/number}","events_url":"https://api.github.com/repos/lathiat/nss-mdns/events","assignees_url":"https://api.github.com/repos/lathiat/nss-mdns/assignees{/user}","branches_url":"https://api.github.com/repos/lathiat/nss-mdns/branches{/branch}","tags_url":"https://api.github.com/repos/lathiat/nss-mdns/tags","blobs_url":"https://api.github.com/repos/lathiat/nss-mdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lathiat/nss-mdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lathiat/nss-mdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/lathiat/nss-mdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lathiat/nss-mdns/statuses/{sha}","languages_url":"https://api.github.com/repos/lathiat/nss-mdns/languages","stargazers_url":"https://api.github.com/repos/lathiat/nss-mdns/stargazers","contributors_url":"https://api.github.com/repos/lathiat/nss-mdns/contributors","subscribers_url":"https://api.github.com/repos/lathiat/nss-mdns/subscribers","subscription_url":"https://api.github.com/repos/lathiat/nss-mdns/subscription","commits_url":"https://api.github.com/repos/lathiat/nss-mdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/lathiat/nss-mdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/lathiat/nss-mdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/lathiat/nss-mdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/lathiat/nss-mdns/contents/{+path}","compare_url":"https://api.github.com/repos/lathiat/nss-mdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lathiat/nss-mdns/merges","archive_url":"https://api.github.com/repos/lathiat/nss-mdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lathiat/nss-mdns/downloads","issues_url":"https://api.github.com/repos/lathiat/nss-mdns/issues{/number}","pulls_url":"https://api.github.com/repos/lathiat/nss-mdns/pulls{/number}","milestones_url":"https://api.github.com/repos/lathiat/nss-mdns/milestones{/number}","notifications_url":"https://api.github.com/repos/lathiat/nss-mdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lathiat/nss-mdns/labels{/name}","releases_url":"https://api.github.com/repos/lathiat/nss-mdns/releases{/id}","deployments_url":"https://api.github.com/repos/lathiat/nss-mdns/deployments","created_at":"2016-08-09T13:53:54Z","updated_at":"2016-08-15T06:47:17Z","pushed_at":"2016-09-23T18:36:48Z","git_url":"git://github.com/lathiat/nss-mdns.git","ssh_url":"git@github.com:lathiat/nss-mdns.git","clone_url":"https://github.com/lathiat/nss-mdns.git","svn_url":"https://github.com/lathiat/nss-mdns","homepage":null,"size":101,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":9,"forks":2,"open_issues":9,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lathiat/nss-mdns/pulls/1"},"html":{"href":"https://github.com/lathiat/nss-mdns/pull/1"},"issue":{"href":"https://api.github.com/repos/lathiat/nss-mdns/issues/1"},"comments":{"href":"https://api.github.com/repos/lathiat/nss-mdns/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/lathiat/nss-mdns/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/lathiat/nss-mdns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lathiat/nss-mdns/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/lathiat/nss-mdns/statuses/cd4097ffd82ee3a0490aabd2b73a44b40540cf41"}}}}
{"actor":{"display_login":"agoode"}}