{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/comments/72310176","id":72310176,"diff_hunk":"@@ -23,7 +23,8 @@ - (BOOL)fb_tapWithError:(NSError **)error\n   [self fb_waitUntilFrameIsStable];\n   __block BOOL didSucceed;\n   [FBRunLoopSpinner spinUntilCompletion:^(void(^completion)()){\n-    [[XCEventGenerator sharedGenerator] tapAtPoint:self.lastSnapshot.hitPoint orientation:self.interfaceOrientation handler:^(XCSynthesizedEventRecord *record, NSError *commandError) {\n+    CGPoint hitPoint = self.isHittable ? self.lastSnapshot.hitPoint : [self coordinateWithNormalizedOffset:CGVectorMake(0, 0)].screenPoint;","path":"WebDriverAgentLib/Categories/XCUIElement+FBTap.m","position":5,"original_position":5,"commit_id":"fd9bf23c12282bc126c2fb3a86ea53c14dec1f9f","original_commit_id":"fd9bf23c12282bc126c2fb3a86ea53c14dec1f9f","user":{"login":"rafael-chavez","id":7691924,"avatar_url":"https://avatars.githubusercontent.com/u/7691924?v=3","gravatar_id":"","url":"https://api.github.com/users/rafael-chavez","html_url":"https://github.com/rafael-chavez","followers_url":"https://api.github.com/users/rafael-chavez/followers","following_url":"https://api.github.com/users/rafael-chavez/following{/other_user}","gists_url":"https://api.github.com/users/rafael-chavez/gists{/gist_id}","starred_url":"https://api.github.com/users/rafael-chavez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafael-chavez/subscriptions","organizations_url":"https://api.github.com/users/rafael-chavez/orgs","repos_url":"https://api.github.com/users/rafael-chavez/repos","events_url":"https://api.github.com/users/rafael-chavez/events{/privacy}","received_events_url":"https://api.github.com/users/rafael-chavez/received_events","type":"User","site_admin":false},"body":"ah ok. I tested it and it worked but to avoid that issue if it regresses on Apple's side, lets tap on center. I'll update","created_at":"2016-07-26T18:34:38Z","updated_at":"2016-07-26T18:34:38Z","html_url":"https://github.com/facebook/WebDriverAgent/pull/217#discussion_r72310176","pull_request_url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/217","_links":{"self":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/comments/72310176"},"html":{"href":"https://github.com/facebook/WebDriverAgent/pull/217#discussion_r72310176"},"pull_request":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/217"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/217","id":78740468,"html_url":"https://github.com/facebook/WebDriverAgent/pull/217","diff_url":"https://github.com/facebook/WebDriverAgent/pull/217.diff","patch_url":"https://github.com/facebook/WebDriverAgent/pull/217.patch","issue_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/217","number":217,"state":"open","locked":false,"title":"Non hittable element returns successful","user":{"login":"rafael-chavez","id":7691924,"avatar_url":"https://avatars.githubusercontent.com/u/7691924?v=3","gravatar_id":"","url":"https://api.github.com/users/rafael-chavez","html_url":"https://github.com/rafael-chavez","followers_url":"https://api.github.com/users/rafael-chavez/followers","following_url":"https://api.github.com/users/rafael-chavez/following{/other_user}","gists_url":"https://api.github.com/users/rafael-chavez/gists{/gist_id}","starred_url":"https://api.github.com/users/rafael-chavez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafael-chavez/subscriptions","organizations_url":"https://api.github.com/users/rafael-chavez/orgs","repos_url":"https://api.github.com/users/rafael-chavez/repos","events_url":"https://api.github.com/users/rafael-chavez/events{/privacy}","received_events_url":"https://api.github.com/users/rafael-chavez/received_events","type":"User","site_admin":false},"body":"@marekcirkos ","created_at":"2016-07-25T19:49:36Z","updated_at":"2016-07-26T18:34:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acba5cadc8662fb670e0fb027600e747f31651eb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/217/commits","review_comments_url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/217/comments","review_comment_url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/217/comments","statuses_url":"https://api.github.com/repos/facebook/WebDriverAgent/statuses/fd9bf23c12282bc126c2fb3a86ea53c14dec1f9f","head":{"label":"rafael-chavez:master","ref":"master","sha":"fd9bf23c12282bc126c2fb3a86ea53c14dec1f9f","user":{"login":"rafael-chavez","id":7691924,"avatar_url":"https://avatars.githubusercontent.com/u/7691924?v=3","gravatar_id":"","url":"https://api.github.com/users/rafael-chavez","html_url":"https://github.com/rafael-chavez","followers_url":"https://api.github.com/users/rafael-chavez/followers","following_url":"https://api.github.com/users/rafael-chavez/following{/other_user}","gists_url":"https://api.github.com/users/rafael-chavez/gists{/gist_id}","starred_url":"https://api.github.com/users/rafael-chavez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafael-chavez/subscriptions","organizations_url":"https://api.github.com/users/rafael-chavez/orgs","repos_url":"https://api.github.com/users/rafael-chavez/repos","events_url":"https://api.github.com/users/rafael-chavez/events{/privacy}","received_events_url":"https://api.github.com/users/rafael-chavez/received_events","type":"User","site_admin":false},"repo":{"id":63627360,"name":"WebDriverAgent","full_name":"rafael-chavez/WebDriverAgent","owner":{"login":"rafael-chavez","id":7691924,"avatar_url":"https://avatars.githubusercontent.com/u/7691924?v=3","gravatar_id":"","url":"https://api.github.com/users/rafael-chavez","html_url":"https://github.com/rafael-chavez","followers_url":"https://api.github.com/users/rafael-chavez/followers","following_url":"https://api.github.com/users/rafael-chavez/following{/other_user}","gists_url":"https://api.github.com/users/rafael-chavez/gists{/gist_id}","starred_url":"https://api.github.com/users/rafael-chavez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafael-chavez/subscriptions","organizations_url":"https://api.github.com/users/rafael-chavez/orgs","repos_url":"https://api.github.com/users/rafael-chavez/repos","events_url":"https://api.github.com/users/rafael-chavez/events{/privacy}","received_events_url":"https://api.github.com/users/rafael-chavez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rafael-chavez/WebDriverAgent","description":"A WebDriver server for iOS that runs inside the Simulator.","fork":true,"url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent","forks_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/forks","keys_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/teams","hooks_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/hooks","issue_events_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/issues/events{/number}","events_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/events","assignees_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/assignees{/user}","branches_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/branches{/branch}","tags_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/tags","blobs_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/git/refs{/sha}","trees_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/statuses/{sha}","languages_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/languages","stargazers_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/stargazers","contributors_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/contributors","subscribers_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/subscribers","subscription_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/subscription","commits_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/commits{/sha}","git_commits_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/git/commits{/sha}","comments_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/comments{/number}","issue_comment_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/issues/comments{/number}","contents_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/contents/{+path}","compare_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/merges","archive_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/downloads","issues_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/issues{/number}","pulls_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/pulls{/number}","milestones_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/milestones{/number}","notifications_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/labels{/name}","releases_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/releases{/id}","deployments_url":"https://api.github.com/repos/rafael-chavez/WebDriverAgent/deployments","created_at":"2016-07-18T18:32:33Z","updated_at":"2016-07-18T18:32:35Z","pushed_at":"2016-07-26T17:13:06Z","git_url":"git://github.com/rafael-chavez/WebDriverAgent.git","ssh_url":"git@github.com:rafael-chavez/WebDriverAgent.git","clone_url":"https://github.com/rafael-chavez/WebDriverAgent.git","svn_url":"https://github.com/rafael-chavez/WebDriverAgent","homepage":null,"size":9783,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"8ac5608d1b317988f227a422a1cb3405914f8455","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":41855272,"name":"WebDriverAgent","full_name":"facebook/WebDriverAgent","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/WebDriverAgent","description":"A WebDriver server for iOS that runs inside the Simulator.","fork":false,"url":"https://api.github.com/repos/facebook/WebDriverAgent","forks_url":"https://api.github.com/repos/facebook/WebDriverAgent/forks","keys_url":"https://api.github.com/repos/facebook/WebDriverAgent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/WebDriverAgent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/WebDriverAgent/teams","hooks_url":"https://api.github.com/repos/facebook/WebDriverAgent/hooks","issue_events_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/WebDriverAgent/events","assignees_url":"https://api.github.com/repos/facebook/WebDriverAgent/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/WebDriverAgent/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/WebDriverAgent/tags","blobs_url":"https://api.github.com/repos/facebook/WebDriverAgent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/WebDriverAgent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/WebDriverAgent/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/WebDriverAgent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/WebDriverAgent/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/WebDriverAgent/languages","stargazers_url":"https://api.github.com/repos/facebook/WebDriverAgent/stargazers","contributors_url":"https://api.github.com/repos/facebook/WebDriverAgent/contributors","subscribers_url":"https://api.github.com/repos/facebook/WebDriverAgent/subscribers","subscription_url":"https://api.github.com/repos/facebook/WebDriverAgent/subscription","commits_url":"https://api.github.com/repos/facebook/WebDriverAgent/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/WebDriverAgent/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/WebDriverAgent/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/WebDriverAgent/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/WebDriverAgent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/WebDriverAgent/merges","archive_url":"https://api.github.com/repos/facebook/WebDriverAgent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/WebDriverAgent/downloads","issues_url":"https://api.github.com/repos/facebook/WebDriverAgent/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/WebDriverAgent/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/WebDriverAgent/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/WebDriverAgent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/WebDriverAgent/labels{/name}","releases_url":"https://api.github.com/repos/facebook/WebDriverAgent/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/WebDriverAgent/deployments","created_at":"2015-09-03T11:00:00Z","updated_at":"2016-07-25T12:09:53Z","pushed_at":"2016-07-26T17:13:06Z","git_url":"git://github.com/facebook/WebDriverAgent.git","ssh_url":"git@github.com:facebook/WebDriverAgent.git","clone_url":"https://github.com/facebook/WebDriverAgent.git","svn_url":"https://github.com/facebook/WebDriverAgent","homepage":null,"size":10472,"stargazers_count":373,"watchers_count":373,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":7,"forks":78,"open_issues":7,"watchers":373,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/217"},"html":{"href":"https://github.com/facebook/WebDriverAgent/pull/217"},"issue":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/issues/217"},"comments":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/WebDriverAgent/statuses/fd9bf23c12282bc126c2fb3a86ea53c14dec1f9f"}}}}
{"actor":{"display_login":"rafael-chavez"}}