{"action":"created","comment":{"url":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/comments/64029111","id":64029111,"diff_hunk":"@@ -1,7 +1,7 @@\n {\n   \"pollIntervalSeconds\": 60,\n-  \"ServerURL\": MENDER_SERVER,\n-  \"DeviceID\": DEVICE_ID,\n+  \"ServerURL\": \"MENDER_SERVER\",\n+  \"DeviceID\": \"DEVICE_ID\",","path":"recipes-mender/mender/files/mender.conf","position":6,"original_position":6,"commit_id":"bb125cfdbb21f692ec18cf4a124f8b1ebec2cc29","original_commit_id":"bb125cfdbb21f692ec18cf4a124f8b1ebec2cc29","user":{"login":"pasinskim","id":6329055,"avatar_url":"https://avatars.githubusercontent.com/u/6329055?v=3","gravatar_id":"","url":"https://api.github.com/users/pasinskim","html_url":"https://github.com/pasinskim","followers_url":"https://api.github.com/users/pasinskim/followers","following_url":"https://api.github.com/users/pasinskim/following{/other_user}","gists_url":"https://api.github.com/users/pasinskim/gists{/gist_id}","starred_url":"https://api.github.com/users/pasinskim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pasinskim/subscriptions","organizations_url":"https://api.github.com/users/pasinskim/orgs","repos_url":"https://api.github.com/users/pasinskim/repos","events_url":"https://api.github.com/users/pasinskim/events{/privacy}","received_events_url":"https://api.github.com/users/pasinskim/received_events","type":"User","site_admin":false},"body":"This was supposed to be hanged by the user before building image, but agree that having correct JSON makes sense here. ","created_at":"2016-05-20T11:49:12Z","updated_at":"2016-05-20T11:49:12Z","html_url":"https://github.com/mendersoftware/meta-mender/pull/43#discussion_r64029111","pull_request_url":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/comments/64029111"},"html":{"href":"https://github.com/mendersoftware/meta-mender/pull/43#discussion_r64029111"},"pull_request":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/43","id":70839610,"html_url":"https://github.com/mendersoftware/meta-mender/pull/43","diff_url":"https://github.com/mendersoftware/meta-mender/pull/43.diff","patch_url":"https://github.com/mendersoftware/meta-mender/pull/43.patch","issue_url":"https://api.github.com/repos/mendersoftware/meta-mender/issues/43","number":43,"state":"open","locked":false,"title":"cleanup  & device identity work","user":{"login":"bboozzoo","id":41870,"avatar_url":"https://avatars.githubusercontent.com/u/41870?v=3","gravatar_id":"","url":"https://api.github.com/users/bboozzoo","html_url":"https://github.com/bboozzoo","followers_url":"https://api.github.com/users/bboozzoo/followers","following_url":"https://api.github.com/users/bboozzoo/following{/other_user}","gists_url":"https://api.github.com/users/bboozzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/bboozzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboozzoo/subscriptions","organizations_url":"https://api.github.com/users/bboozzoo/orgs","repos_url":"https://api.github.com/users/bboozzoo/repos","events_url":"https://api.github.com/users/bboozzoo/events{/privacy}","received_events_url":"https://api.github.com/users/bboozzoo/received_events","type":"User","site_admin":false},"body":"A short series of patches for mender recipe.\r\n\r\nThe first 3 patches introduce cleanups (removing unnecessary quotations, slashes etc.).\r\n\r\nThe 4th patch ships `mender-device-identity` in mender package.\r\n\r\nThe last patch introduces a fix to `mender.conf` so that the default config is at least a valid JSON.\r\n\r\n@kacf @GregorioDiStefano @pasinskim ","created_at":"2016-05-20T11:23:32Z","updated_at":"2016-05-20T11:49:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85f266250e5c7c8597dad5da0706ea987f6224c8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/43/commits","review_comments_url":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/43/comments","review_comment_url":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mendersoftware/meta-mender/issues/43/comments","statuses_url":"https://api.github.com/repos/mendersoftware/meta-mender/statuses/bb125cfdbb21f692ec18cf4a124f8b1ebec2cc29","head":{"label":"bboozzoo:bboozzoo/device-identity","ref":"bboozzoo/device-identity","sha":"bb125cfdbb21f692ec18cf4a124f8b1ebec2cc29","user":{"login":"bboozzoo","id":41870,"avatar_url":"https://avatars.githubusercontent.com/u/41870?v=3","gravatar_id":"","url":"https://api.github.com/users/bboozzoo","html_url":"https://github.com/bboozzoo","followers_url":"https://api.github.com/users/bboozzoo/followers","following_url":"https://api.github.com/users/bboozzoo/following{/other_user}","gists_url":"https://api.github.com/users/bboozzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/bboozzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboozzoo/subscriptions","organizations_url":"https://api.github.com/users/bboozzoo/orgs","repos_url":"https://api.github.com/users/bboozzoo/repos","events_url":"https://api.github.com/users/bboozzoo/events{/privacy}","received_events_url":"https://api.github.com/users/bboozzoo/received_events","type":"User","site_admin":false},"repo":{"id":59284014,"name":"meta-mender","full_name":"bboozzoo/meta-mender","owner":{"login":"bboozzoo","id":41870,"avatar_url":"https://avatars.githubusercontent.com/u/41870?v=3","gravatar_id":"","url":"https://api.github.com/users/bboozzoo","html_url":"https://github.com/bboozzoo","followers_url":"https://api.github.com/users/bboozzoo/followers","following_url":"https://api.github.com/users/bboozzoo/following{/other_user}","gists_url":"https://api.github.com/users/bboozzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/bboozzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboozzoo/subscriptions","organizations_url":"https://api.github.com/users/bboozzoo/orgs","repos_url":"https://api.github.com/users/bboozzoo/repos","events_url":"https://api.github.com/users/bboozzoo/events{/privacy}","received_events_url":"https://api.github.com/users/bboozzoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bboozzoo/meta-mender","description":"Yocto meta layer","fork":true,"url":"https://api.github.com/repos/bboozzoo/meta-mender","forks_url":"https://api.github.com/repos/bboozzoo/meta-mender/forks","keys_url":"https://api.github.com/repos/bboozzoo/meta-mender/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bboozzoo/meta-mender/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bboozzoo/meta-mender/teams","hooks_url":"https://api.github.com/repos/bboozzoo/meta-mender/hooks","issue_events_url":"https://api.github.com/repos/bboozzoo/meta-mender/issues/events{/number}","events_url":"https://api.github.com/repos/bboozzoo/meta-mender/events","assignees_url":"https://api.github.com/repos/bboozzoo/meta-mender/assignees{/user}","branches_url":"https://api.github.com/repos/bboozzoo/meta-mender/branches{/branch}","tags_url":"https://api.github.com/repos/bboozzoo/meta-mender/tags","blobs_url":"https://api.github.com/repos/bboozzoo/meta-mender/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bboozzoo/meta-mender/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bboozzoo/meta-mender/git/refs{/sha}","trees_url":"https://api.github.com/repos/bboozzoo/meta-mender/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bboozzoo/meta-mender/statuses/{sha}","languages_url":"https://api.github.com/repos/bboozzoo/meta-mender/languages","stargazers_url":"https://api.github.com/repos/bboozzoo/meta-mender/stargazers","contributors_url":"https://api.github.com/repos/bboozzoo/meta-mender/contributors","subscribers_url":"https://api.github.com/repos/bboozzoo/meta-mender/subscribers","subscription_url":"https://api.github.com/repos/bboozzoo/meta-mender/subscription","commits_url":"https://api.github.com/repos/bboozzoo/meta-mender/commits{/sha}","git_commits_url":"https://api.github.com/repos/bboozzoo/meta-mender/git/commits{/sha}","comments_url":"https://api.github.com/repos/bboozzoo/meta-mender/comments{/number}","issue_comment_url":"https://api.github.com/repos/bboozzoo/meta-mender/issues/comments{/number}","contents_url":"https://api.github.com/repos/bboozzoo/meta-mender/contents/{+path}","compare_url":"https://api.github.com/repos/bboozzoo/meta-mender/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bboozzoo/meta-mender/merges","archive_url":"https://api.github.com/repos/bboozzoo/meta-mender/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bboozzoo/meta-mender/downloads","issues_url":"https://api.github.com/repos/bboozzoo/meta-mender/issues{/number}","pulls_url":"https://api.github.com/repos/bboozzoo/meta-mender/pulls{/number}","milestones_url":"https://api.github.com/repos/bboozzoo/meta-mender/milestones{/number}","notifications_url":"https://api.github.com/repos/bboozzoo/meta-mender/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bboozzoo/meta-mender/labels{/name}","releases_url":"https://api.github.com/repos/bboozzoo/meta-mender/releases{/id}","deployments_url":"https://api.github.com/repos/bboozzoo/meta-mender/deployments","created_at":"2016-05-20T09:55:05Z","updated_at":"2016-05-20T09:55:06Z","pushed_at":"2016-05-20T11:19:36Z","git_url":"git://github.com/bboozzoo/meta-mender.git","ssh_url":"git@github.com:bboozzoo/meta-mender.git","clone_url":"https://github.com/bboozzoo/meta-mender.git","svn_url":"https://github.com/bboozzoo/meta-mender","homepage":"https://mender.io","size":222,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mendersoftware:master","ref":"master","sha":"8cd0a0822fb79c60f82f99fa2c334684b3ae2336","user":{"login":"mendersoftware","id":15040539,"avatar_url":"https://avatars.githubusercontent.com/u/15040539?v=3","gravatar_id":"","url":"https://api.github.com/users/mendersoftware","html_url":"https://github.com/mendersoftware","followers_url":"https://api.github.com/users/mendersoftware/followers","following_url":"https://api.github.com/users/mendersoftware/following{/other_user}","gists_url":"https://api.github.com/users/mendersoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/mendersoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mendersoftware/subscriptions","organizations_url":"https://api.github.com/users/mendersoftware/orgs","repos_url":"https://api.github.com/users/mendersoftware/repos","events_url":"https://api.github.com/users/mendersoftware/events{/privacy}","received_events_url":"https://api.github.com/users/mendersoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":47542851,"name":"meta-mender","full_name":"mendersoftware/meta-mender","owner":{"login":"mendersoftware","id":15040539,"avatar_url":"https://avatars.githubusercontent.com/u/15040539?v=3","gravatar_id":"","url":"https://api.github.com/users/mendersoftware","html_url":"https://github.com/mendersoftware","followers_url":"https://api.github.com/users/mendersoftware/followers","following_url":"https://api.github.com/users/mendersoftware/following{/other_user}","gists_url":"https://api.github.com/users/mendersoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/mendersoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mendersoftware/subscriptions","organizations_url":"https://api.github.com/users/mendersoftware/orgs","repos_url":"https://api.github.com/users/mendersoftware/repos","events_url":"https://api.github.com/users/mendersoftware/events{/privacy}","received_events_url":"https://api.github.com/users/mendersoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mendersoftware/meta-mender","description":"Yocto meta layer","fork":false,"url":"https://api.github.com/repos/mendersoftware/meta-mender","forks_url":"https://api.github.com/repos/mendersoftware/meta-mender/forks","keys_url":"https://api.github.com/repos/mendersoftware/meta-mender/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mendersoftware/meta-mender/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mendersoftware/meta-mender/teams","hooks_url":"https://api.github.com/repos/mendersoftware/meta-mender/hooks","issue_events_url":"https://api.github.com/repos/mendersoftware/meta-mender/issues/events{/number}","events_url":"https://api.github.com/repos/mendersoftware/meta-mender/events","assignees_url":"https://api.github.com/repos/mendersoftware/meta-mender/assignees{/user}","branches_url":"https://api.github.com/repos/mendersoftware/meta-mender/branches{/branch}","tags_url":"https://api.github.com/repos/mendersoftware/meta-mender/tags","blobs_url":"https://api.github.com/repos/mendersoftware/meta-mender/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mendersoftware/meta-mender/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mendersoftware/meta-mender/git/refs{/sha}","trees_url":"https://api.github.com/repos/mendersoftware/meta-mender/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mendersoftware/meta-mender/statuses/{sha}","languages_url":"https://api.github.com/repos/mendersoftware/meta-mender/languages","stargazers_url":"https://api.github.com/repos/mendersoftware/meta-mender/stargazers","contributors_url":"https://api.github.com/repos/mendersoftware/meta-mender/contributors","subscribers_url":"https://api.github.com/repos/mendersoftware/meta-mender/subscribers","subscription_url":"https://api.github.com/repos/mendersoftware/meta-mender/subscription","commits_url":"https://api.github.com/repos/mendersoftware/meta-mender/commits{/sha}","git_commits_url":"https://api.github.com/repos/mendersoftware/meta-mender/git/commits{/sha}","comments_url":"https://api.github.com/repos/mendersoftware/meta-mender/comments{/number}","issue_comment_url":"https://api.github.com/repos/mendersoftware/meta-mender/issues/comments{/number}","contents_url":"https://api.github.com/repos/mendersoftware/meta-mender/contents/{+path}","compare_url":"https://api.github.com/repos/mendersoftware/meta-mender/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mendersoftware/meta-mender/merges","archive_url":"https://api.github.com/repos/mendersoftware/meta-mender/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mendersoftware/meta-mender/downloads","issues_url":"https://api.github.com/repos/mendersoftware/meta-mender/issues{/number}","pulls_url":"https://api.github.com/repos/mendersoftware/meta-mender/pulls{/number}","milestones_url":"https://api.github.com/repos/mendersoftware/meta-mender/milestones{/number}","notifications_url":"https://api.github.com/repos/mendersoftware/meta-mender/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mendersoftware/meta-mender/labels{/name}","releases_url":"https://api.github.com/repos/mendersoftware/meta-mender/releases{/id}","deployments_url":"https://api.github.com/repos/mendersoftware/meta-mender/deployments","created_at":"2015-12-07T09:37:44Z","updated_at":"2016-03-31T20:53:07Z","pushed_at":"2016-05-20T11:23:32Z","git_url":"git://github.com/mendersoftware/meta-mender.git","ssh_url":"git@github.com:mendersoftware/meta-mender.git","clone_url":"https://github.com/mendersoftware/meta-mender.git","svn_url":"https://github.com/mendersoftware/meta-mender","homepage":"https://mender.io","size":222,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/43"},"html":{"href":"https://github.com/mendersoftware/meta-mender/pull/43"},"issue":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/issues/43"},"comments":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/statuses/bb125cfdbb21f692ec18cf4a124f8b1ebec2cc29"}}}}
{"actor":{"display_login":"pasinskim"}}