{"action":"created","comment":{"url":"https://api.github.com/repos/Medium/dynamite/pulls/comments/75768302","id":75768302,"diff_hunk":"@@ -9,6 +9,7 @@ var DynamoResponse = require('./DynamoResponse')\n  */\n function Builder(options) {\n   this._options = options || {}\n+  this._retryHandler = this._options.retryHandler","path":"lib/Builder.js","position":4,"original_position":4,"commit_id":"c012d90aede072d87467bfbb40019c8cf94ab85b","original_commit_id":"c012d90aede072d87467bfbb40019c8cf94ab85b","user":{"login":"kylewm","id":950127,"avatar_url":"https://avatars.githubusercontent.com/u/950127?v=3","gravatar_id":"","url":"https://api.github.com/users/kylewm","html_url":"https://github.com/kylewm","followers_url":"https://api.github.com/users/kylewm/followers","following_url":"https://api.github.com/users/kylewm/following{/other_user}","gists_url":"https://api.github.com/users/kylewm/gists{/gist_id}","starred_url":"https://api.github.com/users/kylewm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylewm/subscriptions","organizations_url":"https://api.github.com/users/kylewm/orgs","repos_url":"https://api.github.com/users/kylewm/repos","events_url":"https://api.github.com/users/kylewm/events{/privacy}","received_events_url":"https://api.github.com/users/kylewm/received_events","type":"User","site_admin":false},"body":"I'm not 100% comfortable with this. We could let setRetryHandler overwrite options.retryHandler instead, but then we'd need to make a copy of the options object here (so that it wouldn't override options for ALL builders)","created_at":"2016-08-22T22:06:49Z","updated_at":"2016-08-22T22:06:49Z","html_url":"https://github.com/Medium/dynamite/pull/98#discussion_r75768302","pull_request_url":"https://api.github.com/repos/Medium/dynamite/pulls/98","_links":{"self":{"href":"https://api.github.com/repos/Medium/dynamite/pulls/comments/75768302"},"html":{"href":"https://github.com/Medium/dynamite/pull/98#discussion_r75768302"},"pull_request":{"href":"https://api.github.com/repos/Medium/dynamite/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/Medium/dynamite/pulls/98","id":82271586,"html_url":"https://github.com/Medium/dynamite/pull/98","diff_url":"https://github.com/Medium/dynamite/pull/98.diff","patch_url":"https://github.com/Medium/dynamite/pull/98.patch","issue_url":"https://api.github.com/repos/Medium/dynamite/issues/98","number":98,"state":"open","locked":false,"title":"Support overriding a Builder's default retryHandler","user":{"login":"kylewm","id":950127,"avatar_url":"https://avatars.githubusercontent.com/u/950127?v=3","gravatar_id":"","url":"https://api.github.com/users/kylewm","html_url":"https://github.com/kylewm","followers_url":"https://api.github.com/users/kylewm/followers","following_url":"https://api.github.com/users/kylewm/following{/other_user}","gists_url":"https://api.github.com/users/kylewm/gists{/gist_id}","starred_url":"https://api.github.com/users/kylewm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylewm/subscriptions","organizations_url":"https://api.github.com/users/kylewm/orgs","repos_url":"https://api.github.com/users/kylewm/repos","events_url":"https://api.github.com/users/kylewm/events{/privacy}","received_events_url":"https://api.github.com/users/kylewm/received_events","type":"User","site_admin":false},"body":"Hello @xiao, @nicks, \n\nPlease review the following commits I made in branch 'kylewm/retry'.\n\n3a7934d52b9d79a3c6ba600ca4bc092bf938d533 (2016-08-22 15:03:47 -0700)\nSupport overriding a Builder's default retryHandler\nAlso add  to the parameters we pass to the handler. Need\nthis to do any manipulation of the retry behavior (e.g., set response.error.retryable = false)\n\nR=@xiao\nR=@nicks","created_at":"2016-08-22T22:04:21Z","updated_at":"2016-08-22T22:06:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2993d5b3f2a16b98a96036ae90802cc10b897ea","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Medium/dynamite/pulls/98/commits","review_comments_url":"https://api.github.com/repos/Medium/dynamite/pulls/98/comments","review_comment_url":"https://api.github.com/repos/Medium/dynamite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Medium/dynamite/issues/98/comments","statuses_url":"https://api.github.com/repos/Medium/dynamite/statuses/c012d90aede072d87467bfbb40019c8cf94ab85b","head":{"label":"Medium:kylewm/retry","ref":"kylewm/retry","sha":"c012d90aede072d87467bfbb40019c8cf94ab85b","user":{"login":"Medium","id":923954,"avatar_url":"https://avatars.githubusercontent.com/u/923954?v=3","gravatar_id":"","url":"https://api.github.com/users/Medium","html_url":"https://github.com/Medium","followers_url":"https://api.github.com/users/Medium/followers","following_url":"https://api.github.com/users/Medium/following{/other_user}","gists_url":"https://api.github.com/users/Medium/gists{/gist_id}","starred_url":"https://api.github.com/users/Medium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Medium/subscriptions","organizations_url":"https://api.github.com/users/Medium/orgs","repos_url":"https://api.github.com/users/Medium/repos","events_url":"https://api.github.com/users/Medium/events{/privacy}","received_events_url":"https://api.github.com/users/Medium/received_events","type":"Organization","site_admin":false},"repo":{"id":12278795,"name":"dynamite","full_name":"Medium/dynamite","owner":{"login":"Medium","id":923954,"avatar_url":"https://avatars.githubusercontent.com/u/923954?v=3","gravatar_id":"","url":"https://api.github.com/users/Medium","html_url":"https://github.com/Medium","followers_url":"https://api.github.com/users/Medium/followers","following_url":"https://api.github.com/users/Medium/following{/other_user}","gists_url":"https://api.github.com/users/Medium/gists{/gist_id}","starred_url":"https://api.github.com/users/Medium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Medium/subscriptions","organizations_url":"https://api.github.com/users/Medium/orgs","repos_url":"https://api.github.com/users/Medium/repos","events_url":"https://api.github.com/users/Medium/events{/privacy}","received_events_url":"https://api.github.com/users/Medium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Medium/dynamite","description":"A promise-based DynamoDB client","fork":false,"url":"https://api.github.com/repos/Medium/dynamite","forks_url":"https://api.github.com/repos/Medium/dynamite/forks","keys_url":"https://api.github.com/repos/Medium/dynamite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Medium/dynamite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Medium/dynamite/teams","hooks_url":"https://api.github.com/repos/Medium/dynamite/hooks","issue_events_url":"https://api.github.com/repos/Medium/dynamite/issues/events{/number}","events_url":"https://api.github.com/repos/Medium/dynamite/events","assignees_url":"https://api.github.com/repos/Medium/dynamite/assignees{/user}","branches_url":"https://api.github.com/repos/Medium/dynamite/branches{/branch}","tags_url":"https://api.github.com/repos/Medium/dynamite/tags","blobs_url":"https://api.github.com/repos/Medium/dynamite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Medium/dynamite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Medium/dynamite/git/refs{/sha}","trees_url":"https://api.github.com/repos/Medium/dynamite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Medium/dynamite/statuses/{sha}","languages_url":"https://api.github.com/repos/Medium/dynamite/languages","stargazers_url":"https://api.github.com/repos/Medium/dynamite/stargazers","contributors_url":"https://api.github.com/repos/Medium/dynamite/contributors","subscribers_url":"https://api.github.com/repos/Medium/dynamite/subscribers","subscription_url":"https://api.github.com/repos/Medium/dynamite/subscription","commits_url":"https://api.github.com/repos/Medium/dynamite/commits{/sha}","git_commits_url":"https://api.github.com/repos/Medium/dynamite/git/commits{/sha}","comments_url":"https://api.github.com/repos/Medium/dynamite/comments{/number}","issue_comment_url":"https://api.github.com/repos/Medium/dynamite/issues/comments{/number}","contents_url":"https://api.github.com/repos/Medium/dynamite/contents/{+path}","compare_url":"https://api.github.com/repos/Medium/dynamite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Medium/dynamite/merges","archive_url":"https://api.github.com/repos/Medium/dynamite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Medium/dynamite/downloads","issues_url":"https://api.github.com/repos/Medium/dynamite/issues{/number}","pulls_url":"https://api.github.com/repos/Medium/dynamite/pulls{/number}","milestones_url":"https://api.github.com/repos/Medium/dynamite/milestones{/number}","notifications_url":"https://api.github.com/repos/Medium/dynamite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Medium/dynamite/labels{/name}","releases_url":"https://api.github.com/repos/Medium/dynamite/releases{/id}","deployments_url":"https://api.github.com/repos/Medium/dynamite/deployments","created_at":"2013-08-21T19:05:21Z","updated_at":"2016-07-05T19:15:47Z","pushed_at":"2016-08-22T22:05:13Z","git_url":"git://github.com/Medium/dynamite.git","ssh_url":"git@github.com:Medium/dynamite.git","clone_url":"https://github.com/Medium/dynamite.git","svn_url":"https://github.com/Medium/dynamite","homepage":null,"size":304,"stargazers_count":83,"watchers_count":83,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":3,"forks":14,"open_issues":3,"watchers":83,"default_branch":"master"}},"base":{"label":"Medium:master","ref":"master","sha":"20d3750254f7be01e881f1a42a9a5bee8573c096","user":{"login":"Medium","id":923954,"avatar_url":"https://avatars.githubusercontent.com/u/923954?v=3","gravatar_id":"","url":"https://api.github.com/users/Medium","html_url":"https://github.com/Medium","followers_url":"https://api.github.com/users/Medium/followers","following_url":"https://api.github.com/users/Medium/following{/other_user}","gists_url":"https://api.github.com/users/Medium/gists{/gist_id}","starred_url":"https://api.github.com/users/Medium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Medium/subscriptions","organizations_url":"https://api.github.com/users/Medium/orgs","repos_url":"https://api.github.com/users/Medium/repos","events_url":"https://api.github.com/users/Medium/events{/privacy}","received_events_url":"https://api.github.com/users/Medium/received_events","type":"Organization","site_admin":false},"repo":{"id":12278795,"name":"dynamite","full_name":"Medium/dynamite","owner":{"login":"Medium","id":923954,"avatar_url":"https://avatars.githubusercontent.com/u/923954?v=3","gravatar_id":"","url":"https://api.github.com/users/Medium","html_url":"https://github.com/Medium","followers_url":"https://api.github.com/users/Medium/followers","following_url":"https://api.github.com/users/Medium/following{/other_user}","gists_url":"https://api.github.com/users/Medium/gists{/gist_id}","starred_url":"https://api.github.com/users/Medium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Medium/subscriptions","organizations_url":"https://api.github.com/users/Medium/orgs","repos_url":"https://api.github.com/users/Medium/repos","events_url":"https://api.github.com/users/Medium/events{/privacy}","received_events_url":"https://api.github.com/users/Medium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Medium/dynamite","description":"A promise-based DynamoDB client","fork":false,"url":"https://api.github.com/repos/Medium/dynamite","forks_url":"https://api.github.com/repos/Medium/dynamite/forks","keys_url":"https://api.github.com/repos/Medium/dynamite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Medium/dynamite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Medium/dynamite/teams","hooks_url":"https://api.github.com/repos/Medium/dynamite/hooks","issue_events_url":"https://api.github.com/repos/Medium/dynamite/issues/events{/number}","events_url":"https://api.github.com/repos/Medium/dynamite/events","assignees_url":"https://api.github.com/repos/Medium/dynamite/assignees{/user}","branches_url":"https://api.github.com/repos/Medium/dynamite/branches{/branch}","tags_url":"https://api.github.com/repos/Medium/dynamite/tags","blobs_url":"https://api.github.com/repos/Medium/dynamite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Medium/dynamite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Medium/dynamite/git/refs{/sha}","trees_url":"https://api.github.com/repos/Medium/dynamite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Medium/dynamite/statuses/{sha}","languages_url":"https://api.github.com/repos/Medium/dynamite/languages","stargazers_url":"https://api.github.com/repos/Medium/dynamite/stargazers","contributors_url":"https://api.github.com/repos/Medium/dynamite/contributors","subscribers_url":"https://api.github.com/repos/Medium/dynamite/subscribers","subscription_url":"https://api.github.com/repos/Medium/dynamite/subscription","commits_url":"https://api.github.com/repos/Medium/dynamite/commits{/sha}","git_commits_url":"https://api.github.com/repos/Medium/dynamite/git/commits{/sha}","comments_url":"https://api.github.com/repos/Medium/dynamite/comments{/number}","issue_comment_url":"https://api.github.com/repos/Medium/dynamite/issues/comments{/number}","contents_url":"https://api.github.com/repos/Medium/dynamite/contents/{+path}","compare_url":"https://api.github.com/repos/Medium/dynamite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Medium/dynamite/merges","archive_url":"https://api.github.com/repos/Medium/dynamite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Medium/dynamite/downloads","issues_url":"https://api.github.com/repos/Medium/dynamite/issues{/number}","pulls_url":"https://api.github.com/repos/Medium/dynamite/pulls{/number}","milestones_url":"https://api.github.com/repos/Medium/dynamite/milestones{/number}","notifications_url":"https://api.github.com/repos/Medium/dynamite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Medium/dynamite/labels{/name}","releases_url":"https://api.github.com/repos/Medium/dynamite/releases{/id}","deployments_url":"https://api.github.com/repos/Medium/dynamite/deployments","created_at":"2013-08-21T19:05:21Z","updated_at":"2016-07-05T19:15:47Z","pushed_at":"2016-08-22T22:05:13Z","git_url":"git://github.com/Medium/dynamite.git","ssh_url":"git@github.com:Medium/dynamite.git","clone_url":"https://github.com/Medium/dynamite.git","svn_url":"https://github.com/Medium/dynamite","homepage":null,"size":304,"stargazers_count":83,"watchers_count":83,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":3,"forks":14,"open_issues":3,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Medium/dynamite/pulls/98"},"html":{"href":"https://github.com/Medium/dynamite/pull/98"},"issue":{"href":"https://api.github.com/repos/Medium/dynamite/issues/98"},"comments":{"href":"https://api.github.com/repos/Medium/dynamite/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/Medium/dynamite/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/Medium/dynamite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Medium/dynamite/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/Medium/dynamite/statuses/c012d90aede072d87467bfbb40019c8cf94ab85b"}}}}
{"actor":{"display_login":"kylewm"}}