{"action":"created","comment":{"url":"https://api.github.com/repos/ucsdlib/damspas/pulls/comments/49534188","id":49534188,"diff_hunk":"@@ -30,6 +30,17 @@ def show\n     # get metadata from solr\n     @document = get_single_doc_via_search(1, {:q => \"id:#{params[:id]}\"} )\n \n+    # generate facet collection list for collection page only\n+    if !@document.nil?","path":"app/controllers/dams_resource_controller.rb","position":5,"original_position":5,"commit_id":"6732b4a7aa0ff516de3cc1f7323fe6d8cf513245","original_commit_id":"6732b4a7aa0ff516de3cc1f7323fe6d8cf513245","user":{"login":"mcritchlow","id":67506,"avatar_url":"https://avatars.githubusercontent.com/u/67506?v=3","gravatar_id":"","url":"https://api.github.com/users/mcritchlow","html_url":"https://github.com/mcritchlow","followers_url":"https://api.github.com/users/mcritchlow/followers","following_url":"https://api.github.com/users/mcritchlow/following{/other_user}","gists_url":"https://api.github.com/users/mcritchlow/gists{/gist_id}","starred_url":"https://api.github.com/users/mcritchlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcritchlow/subscriptions","organizations_url":"https://api.github.com/users/mcritchlow/orgs","repos_url":"https://api.github.com/users/mcritchlow/repos","events_url":"https://api.github.com/users/mcritchlow/events{/privacy}","received_events_url":"https://api.github.com/users/mcritchlow/received_events","type":"User","site_admin":false},"body":"@lsitu we have a number of instances in the show method where we're checking whether @document is nil or not. what are your thoughts on checking @document immediately after the `get_single_soc_via_search` method and returning if it is nil at that point? then we could remove all the other nil checks in the method.","created_at":"2016-01-13T00:00:56Z","updated_at":"2016-01-13T00:00:56Z","html_url":"https://github.com/ucsdlib/damspas/pull/166#discussion_r49534188","pull_request_url":"https://api.github.com/repos/ucsdlib/damspas/pulls/166","_links":{"self":{"href":"https://api.github.com/repos/ucsdlib/damspas/pulls/comments/49534188"},"html":{"href":"https://github.com/ucsdlib/damspas/pull/166#discussion_r49534188"},"pull_request":{"href":"https://api.github.com/repos/ucsdlib/damspas/pulls/166"}}},"pull_request":{"url":"https://api.github.com/repos/ucsdlib/damspas/pulls/166","id":55835713,"html_url":"https://github.com/ucsdlib/damspas/pull/166","diff_url":"https://github.com/ucsdlib/damspas/pull/166.diff","patch_url":"https://github.com/ucsdlib/damspas/pull/166.patch","issue_url":"https://api.github.com/repos/ucsdlib/damspas/issues/166","number":166,"state":"open","locked":false,"title":"Replace subcollections list with Solr query for the collection landing page. DHH-770","user":{"login":"lsitu","id":2430784,"avatar_url":"https://avatars.githubusercontent.com/u/2430784?v=3","gravatar_id":"","url":"https://api.github.com/users/lsitu","html_url":"https://github.com/lsitu","followers_url":"https://api.github.com/users/lsitu/followers","following_url":"https://api.github.com/users/lsitu/following{/other_user}","gists_url":"https://api.github.com/users/lsitu/gists{/gist_id}","starred_url":"https://api.github.com/users/lsitu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsitu/subscriptions","organizations_url":"https://api.github.com/users/lsitu/orgs","repos_url":"https://api.github.com/users/lsitu/repos","events_url":"https://api.github.com/users/lsitu/events{/privacy}","received_events_url":"https://api.github.com/users/lsitu/received_events","type":"User","site_admin":false},"body":"https://lib-jira.ucsd.edu:8443/browse/DHH-770","created_at":"2016-01-12T23:52:30Z","updated_at":"2016-01-13T00:00:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"613a6ef8b8151d89d9fb89a40681b5407bd450b9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ucsdlib/damspas/pulls/166/commits","review_comments_url":"https://api.github.com/repos/ucsdlib/damspas/pulls/166/comments","review_comment_url":"https://api.github.com/repos/ucsdlib/damspas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ucsdlib/damspas/issues/166/comments","statuses_url":"https://api.github.com/repos/ucsdlib/damspas/statuses/6732b4a7aa0ff516de3cc1f7323fe6d8cf513245","head":{"label":"ucsdlib:feature/collections","ref":"feature/collections","sha":"6732b4a7aa0ff516de3cc1f7323fe6d8cf513245","user":{"login":"ucsdlib","id":2387725,"avatar_url":"https://avatars.githubusercontent.com/u/2387725?v=3","gravatar_id":"","url":"https://api.github.com/users/ucsdlib","html_url":"https://github.com/ucsdlib","followers_url":"https://api.github.com/users/ucsdlib/followers","following_url":"https://api.github.com/users/ucsdlib/following{/other_user}","gists_url":"https://api.github.com/users/ucsdlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ucsdlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucsdlib/subscriptions","organizations_url":"https://api.github.com/users/ucsdlib/orgs","repos_url":"https://api.github.com/users/ucsdlib/repos","events_url":"https://api.github.com/users/ucsdlib/events{/privacy}","received_events_url":"https://api.github.com/users/ucsdlib/received_events","type":"Organization","site_admin":false},"repo":{"id":17287926,"name":"damspas","full_name":"ucsdlib/damspas","owner":{"login":"ucsdlib","id":2387725,"avatar_url":"https://avatars.githubusercontent.com/u/2387725?v=3","gravatar_id":"","url":"https://api.github.com/users/ucsdlib","html_url":"https://github.com/ucsdlib","followers_url":"https://api.github.com/users/ucsdlib/followers","following_url":"https://api.github.com/users/ucsdlib/following{/other_user}","gists_url":"https://api.github.com/users/ucsdlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ucsdlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucsdlib/subscriptions","organizations_url":"https://api.github.com/users/ucsdlib/orgs","repos_url":"https://api.github.com/users/ucsdlib/repos","events_url":"https://api.github.com/users/ucsdlib/events{/privacy}","received_events_url":"https://api.github.com/users/ucsdlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ucsdlib/damspas","description":"UC San Diego DAMS Hydra Head","fork":false,"url":"https://api.github.com/repos/ucsdlib/damspas","forks_url":"https://api.github.com/repos/ucsdlib/damspas/forks","keys_url":"https://api.github.com/repos/ucsdlib/damspas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ucsdlib/damspas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ucsdlib/damspas/teams","hooks_url":"https://api.github.com/repos/ucsdlib/damspas/hooks","issue_events_url":"https://api.github.com/repos/ucsdlib/damspas/issues/events{/number}","events_url":"https://api.github.com/repos/ucsdlib/damspas/events","assignees_url":"https://api.github.com/repos/ucsdlib/damspas/assignees{/user}","branches_url":"https://api.github.com/repos/ucsdlib/damspas/branches{/branch}","tags_url":"https://api.github.com/repos/ucsdlib/damspas/tags","blobs_url":"https://api.github.com/repos/ucsdlib/damspas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ucsdlib/damspas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ucsdlib/damspas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ucsdlib/damspas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ucsdlib/damspas/statuses/{sha}","languages_url":"https://api.github.com/repos/ucsdlib/damspas/languages","stargazers_url":"https://api.github.com/repos/ucsdlib/damspas/stargazers","contributors_url":"https://api.github.com/repos/ucsdlib/damspas/contributors","subscribers_url":"https://api.github.com/repos/ucsdlib/damspas/subscribers","subscription_url":"https://api.github.com/repos/ucsdlib/damspas/subscription","commits_url":"https://api.github.com/repos/ucsdlib/damspas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ucsdlib/damspas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ucsdlib/damspas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ucsdlib/damspas/issues/comments{/number}","contents_url":"https://api.github.com/repos/ucsdlib/damspas/contents/{+path}","compare_url":"https://api.github.com/repos/ucsdlib/damspas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ucsdlib/damspas/merges","archive_url":"https://api.github.com/repos/ucsdlib/damspas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ucsdlib/damspas/downloads","issues_url":"https://api.github.com/repos/ucsdlib/damspas/issues{/number}","pulls_url":"https://api.github.com/repos/ucsdlib/damspas/pulls{/number}","milestones_url":"https://api.github.com/repos/ucsdlib/damspas/milestones{/number}","notifications_url":"https://api.github.com/repos/ucsdlib/damspas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ucsdlib/damspas/labels{/name}","releases_url":"https://api.github.com/repos/ucsdlib/damspas/releases{/id}","created_at":"2014-02-28T14:07:19Z","updated_at":"2015-05-08T20:32:58Z","pushed_at":"2016-01-12T23:52:30Z","git_url":"git://github.com/ucsdlib/damspas.git","ssh_url":"git@github.com:ucsdlib/damspas.git","clone_url":"https://github.com/ucsdlib/damspas.git","svn_url":"https://github.com/ucsdlib/damspas","homepage":null,"size":13159,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":2,"default_branch":"develop"}},"base":{"label":"ucsdlib:develop","ref":"develop","sha":"b9ec8194fe052db002f99bf55b58576679e59126","user":{"login":"ucsdlib","id":2387725,"avatar_url":"https://avatars.githubusercontent.com/u/2387725?v=3","gravatar_id":"","url":"https://api.github.com/users/ucsdlib","html_url":"https://github.com/ucsdlib","followers_url":"https://api.github.com/users/ucsdlib/followers","following_url":"https://api.github.com/users/ucsdlib/following{/other_user}","gists_url":"https://api.github.com/users/ucsdlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ucsdlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucsdlib/subscriptions","organizations_url":"https://api.github.com/users/ucsdlib/orgs","repos_url":"https://api.github.com/users/ucsdlib/repos","events_url":"https://api.github.com/users/ucsdlib/events{/privacy}","received_events_url":"https://api.github.com/users/ucsdlib/received_events","type":"Organization","site_admin":false},"repo":{"id":17287926,"name":"damspas","full_name":"ucsdlib/damspas","owner":{"login":"ucsdlib","id":2387725,"avatar_url":"https://avatars.githubusercontent.com/u/2387725?v=3","gravatar_id":"","url":"https://api.github.com/users/ucsdlib","html_url":"https://github.com/ucsdlib","followers_url":"https://api.github.com/users/ucsdlib/followers","following_url":"https://api.github.com/users/ucsdlib/following{/other_user}","gists_url":"https://api.github.com/users/ucsdlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ucsdlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ucsdlib/subscriptions","organizations_url":"https://api.github.com/users/ucsdlib/orgs","repos_url":"https://api.github.com/users/ucsdlib/repos","events_url":"https://api.github.com/users/ucsdlib/events{/privacy}","received_events_url":"https://api.github.com/users/ucsdlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ucsdlib/damspas","description":"UC San Diego DAMS Hydra Head","fork":false,"url":"https://api.github.com/repos/ucsdlib/damspas","forks_url":"https://api.github.com/repos/ucsdlib/damspas/forks","keys_url":"https://api.github.com/repos/ucsdlib/damspas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ucsdlib/damspas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ucsdlib/damspas/teams","hooks_url":"https://api.github.com/repos/ucsdlib/damspas/hooks","issue_events_url":"https://api.github.com/repos/ucsdlib/damspas/issues/events{/number}","events_url":"https://api.github.com/repos/ucsdlib/damspas/events","assignees_url":"https://api.github.com/repos/ucsdlib/damspas/assignees{/user}","branches_url":"https://api.github.com/repos/ucsdlib/damspas/branches{/branch}","tags_url":"https://api.github.com/repos/ucsdlib/damspas/tags","blobs_url":"https://api.github.com/repos/ucsdlib/damspas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ucsdlib/damspas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ucsdlib/damspas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ucsdlib/damspas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ucsdlib/damspas/statuses/{sha}","languages_url":"https://api.github.com/repos/ucsdlib/damspas/languages","stargazers_url":"https://api.github.com/repos/ucsdlib/damspas/stargazers","contributors_url":"https://api.github.com/repos/ucsdlib/damspas/contributors","subscribers_url":"https://api.github.com/repos/ucsdlib/damspas/subscribers","subscription_url":"https://api.github.com/repos/ucsdlib/damspas/subscription","commits_url":"https://api.github.com/repos/ucsdlib/damspas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ucsdlib/damspas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ucsdlib/damspas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ucsdlib/damspas/issues/comments{/number}","contents_url":"https://api.github.com/repos/ucsdlib/damspas/contents/{+path}","compare_url":"https://api.github.com/repos/ucsdlib/damspas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ucsdlib/damspas/merges","archive_url":"https://api.github.com/repos/ucsdlib/damspas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ucsdlib/damspas/downloads","issues_url":"https://api.github.com/repos/ucsdlib/damspas/issues{/number}","pulls_url":"https://api.github.com/repos/ucsdlib/damspas/pulls{/number}","milestones_url":"https://api.github.com/repos/ucsdlib/damspas/milestones{/number}","notifications_url":"https://api.github.com/repos/ucsdlib/damspas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ucsdlib/damspas/labels{/name}","releases_url":"https://api.github.com/repos/ucsdlib/damspas/releases{/id}","created_at":"2014-02-28T14:07:19Z","updated_at":"2015-05-08T20:32:58Z","pushed_at":"2016-01-12T23:52:30Z","git_url":"git://github.com/ucsdlib/damspas.git","ssh_url":"git@github.com:ucsdlib/damspas.git","clone_url":"https://github.com/ucsdlib/damspas.git","svn_url":"https://github.com/ucsdlib/damspas","homepage":null,"size":13159,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ucsdlib/damspas/pulls/166"},"html":{"href":"https://github.com/ucsdlib/damspas/pull/166"},"issue":{"href":"https://api.github.com/repos/ucsdlib/damspas/issues/166"},"comments":{"href":"https://api.github.com/repos/ucsdlib/damspas/issues/166/comments"},"review_comments":{"href":"https://api.github.com/repos/ucsdlib/damspas/pulls/166/comments"},"review_comment":{"href":"https://api.github.com/repos/ucsdlib/damspas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ucsdlib/damspas/pulls/166/commits"},"statuses":{"href":"https://api.github.com/repos/ucsdlib/damspas/statuses/6732b4a7aa0ff516de3cc1f7323fe6d8cf513245"}}}}