{"action":"created","issue":{"url":"https://api.github.com/repos/mate-desktop/mate-panel/issues/419","repository_url":"https://api.github.com/repos/mate-desktop/mate-panel","labels_url":"https://api.github.com/repos/mate-desktop/mate-panel/issues/419/labels{/name}","comments_url":"https://api.github.com/repos/mate-desktop/mate-panel/issues/419/comments","events_url":"https://api.github.com/repos/mate-desktop/mate-panel/issues/419/events","html_url":"https://github.com/mate-desktop/mate-panel/pull/419","id":142436870,"number":419,"title":"Gtk 3.18 &  3.20-move bg handling","user":{"login":"lukefromdc","id":14036792,"avatar_url":"https://avatars.githubusercontent.com/u/14036792?v=3","gravatar_id":"","url":"https://api.github.com/users/lukefromdc","html_url":"https://github.com/lukefromdc","followers_url":"https://api.github.com/users/lukefromdc/followers","following_url":"https://api.github.com/users/lukefromdc/following{/other_user}","gists_url":"https://api.github.com/users/lukefromdc/gists{/gist_id}","starred_url":"https://api.github.com/users/lukefromdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukefromdc/subscriptions","organizations_url":"https://api.github.com/users/lukefromdc/orgs","repos_url":"https://api.github.com/users/lukefromdc/repos","events_url":"https://api.github.com/users/lukefromdc/events{/privacy}","received_events_url":"https://api.github.com/users/lukefromdc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2016-03-21T18:48:12Z","updated_at":"2016-03-24T15:46:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mate-desktop/mate-panel/pulls/419","html_url":"https://github.com/mate-desktop/mate-panel/pull/419","diff_url":"https://github.com/mate-desktop/mate-panel/pull/419.diff","patch_url":"https://github.com/mate-desktop/mate-panel/pull/419.patch"},"body":"This branch fixes the temporary loss of custom panel backgrounds when changing GTK themes in GTK 3.20. Also stopped the applet crashes on theme change or loading the panel with a custom background applied, so applied it to GTK 3.18 as well. Do NOT apply it to GTK3.16 or earlier builds, as moving the panel background handling to the toplevel does not work with them.\r\nBased on gnome-panel's\r\nhttps://github.com/GNOME/gnome-panel/commit/47741777c3115b9700fd762ab7543a81d2ed92dc\r\n move background handling from PanelWidget to PanelToplevel \r\nand\r\nhttps://github.com/GNOME/gnome-panel/commit/08e2e24c21694fc835c98166ff1b0cf5bba42c1c\r\nset rgba visual on PanelToplevel not PanelWidget \r\n\r\nTested with gtk 3.14, 3.16, 3.18, and today's newly-released GTK 3.20. Needs testing in GTK 2 as I don't have a GTK 2 build environment set up\r\n\r\nNote that some early commits were named as gtk3.18/3.10 by mistake, those are GTK 3.18/3.20 commits. I cannot change the names from the website except by starting over with a new branch."},"comment":{"url":"https://api.github.com/repos/mate-desktop/mate-panel/issues/comments/200895505","html_url":"https://github.com/mate-desktop/mate-panel/pull/419#issuecomment-200895505","issue_url":"https://api.github.com/repos/mate-desktop/mate-panel/issues/419","id":200895505,"user":{"login":"raveit65","id":961604,"avatar_url":"https://avatars.githubusercontent.com/u/961604?v=3","gravatar_id":"","url":"https://api.github.com/users/raveit65","html_url":"https://github.com/raveit65","followers_url":"https://api.github.com/users/raveit65/followers","following_url":"https://api.github.com/users/raveit65/following{/other_user}","gists_url":"https://api.github.com/users/raveit65/gists{/gist_id}","starred_url":"https://api.github.com/users/raveit65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raveit65/subscriptions","organizations_url":"https://api.github.com/users/raveit65/orgs","repos_url":"https://api.github.com/users/raveit65/repos","events_url":"https://api.github.com/users/raveit65/events{/privacy}","received_events_url":"https://api.github.com/users/raveit65/received_events","type":"User","site_admin":false},"created_at":"2016-03-24T15:46:44Z","updated_at":"2016-03-24T15:46:44Z","body":"@monsta \r\nThe reason for the the different with themes is here.\r\nhttps://github.com/mate-desktop/mate-themes/blob/gtk3.18/desktop-themes/BlueMenta/gtk-3.0/mate-applications.css#L350\r\nWith most themes i make first every element transparent, to avoid unwanted settings from general themeing in gtk-widgets.css, before i start to style the panel.\r\nFor some reasons i didn't do that for TOK themes."}}