{"action":"created","comment":{"url":"https://api.github.com/repos/kamon-io/Kamon/pulls/comments/68241246","id":68241246,"diff_hunk":"@@ -34,7 +39,12 @@ trait MdcKeysSupport {\n \n   private[this] def copyToMdc(traceContext: TraceContext): Iterable[String] = traceContext match {\n     case ctx: MetricsOnlyContext ⇒\n-      ctx.traceLocalStorage.underlyingStorage.collect {\n+\n+      // Add the default key value pairs for the trace token and trace name.","path":"kamon-core/src/main/scala/kamon/trace/logging/MdcKeysSupport.scala","position":27,"original_position":27,"commit_id":"7b35d2a5048b42073db8172521aa5f9ecb6b0b2d","original_commit_id":"7b35d2a5048b42073db8172521aa5f9ecb6b0b2d","user":{"login":"dpsoft","id":2567525,"avatar_url":"https://avatars.githubusercontent.com/u/2567525?v=3","gravatar_id":"","url":"https://api.github.com/users/dpsoft","html_url":"https://github.com/dpsoft","followers_url":"https://api.github.com/users/dpsoft/followers","following_url":"https://api.github.com/users/dpsoft/following{/other_user}","gists_url":"https://api.github.com/users/dpsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/dpsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpsoft/subscriptions","organizations_url":"https://api.github.com/users/dpsoft/orgs","repos_url":"https://api.github.com/users/dpsoft/repos","events_url":"https://api.github.com/users/dpsoft/events{/privacy}","received_events_url":"https://api.github.com/users/dpsoft/received_events","type":"User","site_admin":false},"body":"I see your point, and I think that is a good point :). @ivantopo? ","created_at":"2016-06-23T14:11:24Z","updated_at":"2016-06-23T14:11:24Z","html_url":"https://github.com/kamon-io/Kamon/pull/363#discussion_r68241246","pull_request_url":"https://api.github.com/repos/kamon-io/Kamon/pulls/363","_links":{"self":{"href":"https://api.github.com/repos/kamon-io/Kamon/pulls/comments/68241246"},"html":{"href":"https://github.com/kamon-io/Kamon/pull/363#discussion_r68241246"},"pull_request":{"href":"https://api.github.com/repos/kamon-io/Kamon/pulls/363"}}},"pull_request":{"url":"https://api.github.com/repos/kamon-io/Kamon/pulls/363","id":74326729,"html_url":"https://github.com/kamon-io/Kamon/pull/363","diff_url":"https://github.com/kamon-io/Kamon/pull/363.diff","patch_url":"https://github.com/kamon-io/Kamon/pull/363.patch","issue_url":"https://api.github.com/repos/kamon-io/Kamon/issues/363","number":363,"state":"open","locked":false,"title":"= kamon-core: add context name and token to MDC","user":{"login":"dspasojevic","id":358318,"avatar_url":"https://avatars.githubusercontent.com/u/358318?v=3","gravatar_id":"","url":"https://api.github.com/users/dspasojevic","html_url":"https://github.com/dspasojevic","followers_url":"https://api.github.com/users/dspasojevic/followers","following_url":"https://api.github.com/users/dspasojevic/following{/other_user}","gists_url":"https://api.github.com/users/dspasojevic/gists{/gist_id}","starred_url":"https://api.github.com/users/dspasojevic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dspasojevic/subscriptions","organizations_url":"https://api.github.com/users/dspasojevic/orgs","repos_url":"https://api.github.com/users/dspasojevic/repos","events_url":"https://api.github.com/users/dspasojevic/events{/privacy}","received_events_url":"https://api.github.com/users/dspasojevic/received_events","type":"User","site_admin":false},"body":"This change pushes the trace name and token into the MDC. This means that they can be accessed in async appenders using the normal mechanism - without using the LogbackTraceTokenConverter.","created_at":"2016-06-18T03:49:27Z","updated_at":"2016-06-23T14:11:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f74f2ac32ef17111fbe957a6536552da8e42345","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kamon-io/Kamon/pulls/363/commits","review_comments_url":"https://api.github.com/repos/kamon-io/Kamon/pulls/363/comments","review_comment_url":"https://api.github.com/repos/kamon-io/Kamon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kamon-io/Kamon/issues/363/comments","statuses_url":"https://api.github.com/repos/kamon-io/Kamon/statuses/7b35d2a5048b42073db8172521aa5f9ecb6b0b2d","head":{"label":"dspasojevic:mdc","ref":"mdc","sha":"7b35d2a5048b42073db8172521aa5f9ecb6b0b2d","user":{"login":"dspasojevic","id":358318,"avatar_url":"https://avatars.githubusercontent.com/u/358318?v=3","gravatar_id":"","url":"https://api.github.com/users/dspasojevic","html_url":"https://github.com/dspasojevic","followers_url":"https://api.github.com/users/dspasojevic/followers","following_url":"https://api.github.com/users/dspasojevic/following{/other_user}","gists_url":"https://api.github.com/users/dspasojevic/gists{/gist_id}","starred_url":"https://api.github.com/users/dspasojevic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dspasojevic/subscriptions","organizations_url":"https://api.github.com/users/dspasojevic/orgs","repos_url":"https://api.github.com/users/dspasojevic/repos","events_url":"https://api.github.com/users/dspasojevic/events{/privacy}","received_events_url":"https://api.github.com/users/dspasojevic/received_events","type":"User","site_admin":false},"repo":{"id":61118241,"name":"Kamon","full_name":"dspasojevic/Kamon","owner":{"login":"dspasojevic","id":358318,"avatar_url":"https://avatars.githubusercontent.com/u/358318?v=3","gravatar_id":"","url":"https://api.github.com/users/dspasojevic","html_url":"https://github.com/dspasojevic","followers_url":"https://api.github.com/users/dspasojevic/followers","following_url":"https://api.github.com/users/dspasojevic/following{/other_user}","gists_url":"https://api.github.com/users/dspasojevic/gists{/gist_id}","starred_url":"https://api.github.com/users/dspasojevic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dspasojevic/subscriptions","organizations_url":"https://api.github.com/users/dspasojevic/orgs","repos_url":"https://api.github.com/users/dspasojevic/repos","events_url":"https://api.github.com/users/dspasojevic/events{/privacy}","received_events_url":"https://api.github.com/users/dspasojevic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dspasojevic/Kamon","description":"The Open Source tool for monitoring applications running on the JVM","fork":true,"url":"https://api.github.com/repos/dspasojevic/Kamon","forks_url":"https://api.github.com/repos/dspasojevic/Kamon/forks","keys_url":"https://api.github.com/repos/dspasojevic/Kamon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dspasojevic/Kamon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dspasojevic/Kamon/teams","hooks_url":"https://api.github.com/repos/dspasojevic/Kamon/hooks","issue_events_url":"https://api.github.com/repos/dspasojevic/Kamon/issues/events{/number}","events_url":"https://api.github.com/repos/dspasojevic/Kamon/events","assignees_url":"https://api.github.com/repos/dspasojevic/Kamon/assignees{/user}","branches_url":"https://api.github.com/repos/dspasojevic/Kamon/branches{/branch}","tags_url":"https://api.github.com/repos/dspasojevic/Kamon/tags","blobs_url":"https://api.github.com/repos/dspasojevic/Kamon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dspasojevic/Kamon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dspasojevic/Kamon/git/refs{/sha}","trees_url":"https://api.github.com/repos/dspasojevic/Kamon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dspasojevic/Kamon/statuses/{sha}","languages_url":"https://api.github.com/repos/dspasojevic/Kamon/languages","stargazers_url":"https://api.github.com/repos/dspasojevic/Kamon/stargazers","contributors_url":"https://api.github.com/repos/dspasojevic/Kamon/contributors","subscribers_url":"https://api.github.com/repos/dspasojevic/Kamon/subscribers","subscription_url":"https://api.github.com/repos/dspasojevic/Kamon/subscription","commits_url":"https://api.github.com/repos/dspasojevic/Kamon/commits{/sha}","git_commits_url":"https://api.github.com/repos/dspasojevic/Kamon/git/commits{/sha}","comments_url":"https://api.github.com/repos/dspasojevic/Kamon/comments{/number}","issue_comment_url":"https://api.github.com/repos/dspasojevic/Kamon/issues/comments{/number}","contents_url":"https://api.github.com/repos/dspasojevic/Kamon/contents/{+path}","compare_url":"https://api.github.com/repos/dspasojevic/Kamon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dspasojevic/Kamon/merges","archive_url":"https://api.github.com/repos/dspasojevic/Kamon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dspasojevic/Kamon/downloads","issues_url":"https://api.github.com/repos/dspasojevic/Kamon/issues{/number}","pulls_url":"https://api.github.com/repos/dspasojevic/Kamon/pulls{/number}","milestones_url":"https://api.github.com/repos/dspasojevic/Kamon/milestones{/number}","notifications_url":"https://api.github.com/repos/dspasojevic/Kamon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dspasojevic/Kamon/labels{/name}","releases_url":"https://api.github.com/repos/dspasojevic/Kamon/releases{/id}","deployments_url":"https://api.github.com/repos/dspasojevic/Kamon/deployments","created_at":"2016-06-14T11:43:26Z","updated_at":"2016-06-14T11:43:28Z","pushed_at":"2016-06-18T03:02:35Z","git_url":"git://github.com/dspasojevic/Kamon.git","ssh_url":"git@github.com:dspasojevic/Kamon.git","clone_url":"https://github.com/dspasojevic/Kamon.git","svn_url":"https://github.com/dspasojevic/Kamon","homepage":"http://kamon.io","size":7255,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kamon-io:master","ref":"master","sha":"314ecd45e6c89d7f188645c83a5d27064cb3abb5","user":{"login":"kamon-io","id":5789105,"avatar_url":"https://avatars.githubusercontent.com/u/5789105?v=3","gravatar_id":"","url":"https://api.github.com/users/kamon-io","html_url":"https://github.com/kamon-io","followers_url":"https://api.github.com/users/kamon-io/followers","following_url":"https://api.github.com/users/kamon-io/following{/other_user}","gists_url":"https://api.github.com/users/kamon-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kamon-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamon-io/subscriptions","organizations_url":"https://api.github.com/users/kamon-io/orgs","repos_url":"https://api.github.com/users/kamon-io/repos","events_url":"https://api.github.com/users/kamon-io/events{/privacy}","received_events_url":"https://api.github.com/users/kamon-io/received_events","type":"Organization","site_admin":false},"repo":{"id":9843572,"name":"Kamon","full_name":"kamon-io/Kamon","owner":{"login":"kamon-io","id":5789105,"avatar_url":"https://avatars.githubusercontent.com/u/5789105?v=3","gravatar_id":"","url":"https://api.github.com/users/kamon-io","html_url":"https://github.com/kamon-io","followers_url":"https://api.github.com/users/kamon-io/followers","following_url":"https://api.github.com/users/kamon-io/following{/other_user}","gists_url":"https://api.github.com/users/kamon-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kamon-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamon-io/subscriptions","organizations_url":"https://api.github.com/users/kamon-io/orgs","repos_url":"https://api.github.com/users/kamon-io/repos","events_url":"https://api.github.com/users/kamon-io/events{/privacy}","received_events_url":"https://api.github.com/users/kamon-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kamon-io/Kamon","description":"The Open Source tool for monitoring applications running on the JVM","fork":false,"url":"https://api.github.com/repos/kamon-io/Kamon","forks_url":"https://api.github.com/repos/kamon-io/Kamon/forks","keys_url":"https://api.github.com/repos/kamon-io/Kamon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kamon-io/Kamon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kamon-io/Kamon/teams","hooks_url":"https://api.github.com/repos/kamon-io/Kamon/hooks","issue_events_url":"https://api.github.com/repos/kamon-io/Kamon/issues/events{/number}","events_url":"https://api.github.com/repos/kamon-io/Kamon/events","assignees_url":"https://api.github.com/repos/kamon-io/Kamon/assignees{/user}","branches_url":"https://api.github.com/repos/kamon-io/Kamon/branches{/branch}","tags_url":"https://api.github.com/repos/kamon-io/Kamon/tags","blobs_url":"https://api.github.com/repos/kamon-io/Kamon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kamon-io/Kamon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kamon-io/Kamon/git/refs{/sha}","trees_url":"https://api.github.com/repos/kamon-io/Kamon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kamon-io/Kamon/statuses/{sha}","languages_url":"https://api.github.com/repos/kamon-io/Kamon/languages","stargazers_url":"https://api.github.com/repos/kamon-io/Kamon/stargazers","contributors_url":"https://api.github.com/repos/kamon-io/Kamon/contributors","subscribers_url":"https://api.github.com/repos/kamon-io/Kamon/subscribers","subscription_url":"https://api.github.com/repos/kamon-io/Kamon/subscription","commits_url":"https://api.github.com/repos/kamon-io/Kamon/commits{/sha}","git_commits_url":"https://api.github.com/repos/kamon-io/Kamon/git/commits{/sha}","comments_url":"https://api.github.com/repos/kamon-io/Kamon/comments{/number}","issue_comment_url":"https://api.github.com/repos/kamon-io/Kamon/issues/comments{/number}","contents_url":"https://api.github.com/repos/kamon-io/Kamon/contents/{+path}","compare_url":"https://api.github.com/repos/kamon-io/Kamon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kamon-io/Kamon/merges","archive_url":"https://api.github.com/repos/kamon-io/Kamon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kamon-io/Kamon/downloads","issues_url":"https://api.github.com/repos/kamon-io/Kamon/issues{/number}","pulls_url":"https://api.github.com/repos/kamon-io/Kamon/pulls{/number}","milestones_url":"https://api.github.com/repos/kamon-io/Kamon/milestones{/number}","notifications_url":"https://api.github.com/repos/kamon-io/Kamon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kamon-io/Kamon/labels{/name}","releases_url":"https://api.github.com/repos/kamon-io/Kamon/releases{/id}","deployments_url":"https://api.github.com/repos/kamon-io/Kamon/deployments","created_at":"2013-05-03T20:02:45Z","updated_at":"2016-06-22T21:57:24Z","pushed_at":"2016-06-22T18:42:34Z","git_url":"git://github.com/kamon-io/Kamon.git","ssh_url":"git@github.com:kamon-io/Kamon.git","clone_url":"https://github.com/kamon-io/Kamon.git","svn_url":"https://github.com/kamon-io/Kamon","homepage":"http://kamon.io","size":7928,"stargazers_count":653,"watchers_count":653,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":139,"mirror_url":null,"open_issues_count":73,"forks":139,"open_issues":73,"watchers":653,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kamon-io/Kamon/pulls/363"},"html":{"href":"https://github.com/kamon-io/Kamon/pull/363"},"issue":{"href":"https://api.github.com/repos/kamon-io/Kamon/issues/363"},"comments":{"href":"https://api.github.com/repos/kamon-io/Kamon/issues/363/comments"},"review_comments":{"href":"https://api.github.com/repos/kamon-io/Kamon/pulls/363/comments"},"review_comment":{"href":"https://api.github.com/repos/kamon-io/Kamon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kamon-io/Kamon/pulls/363/commits"},"statuses":{"href":"https://api.github.com/repos/kamon-io/Kamon/statuses/7b35d2a5048b42073db8172521aa5f9ecb6b0b2d"}}}}
{"actor":{"display_login":"dpsoft"}}