{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/20215","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/20215/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/20215/comments","events_url":"https://api.github.com/repos/docker/docker/issues/20215/events","html_url":"https://github.com/docker/docker/pull/20215","id":132873895,"number":20215,"title":"Windows CI: test-unit on pkg\\plugins","user":{"login":"jhowardmsft","id":10522484,"avatar_url":"https://avatars.githubusercontent.com/u/10522484?v=3","gravatar_id":"","url":"https://api.github.com/users/jhowardmsft","html_url":"https://github.com/jhowardmsft","followers_url":"https://api.github.com/users/jhowardmsft/followers","following_url":"https://api.github.com/users/jhowardmsft/following{/other_user}","gists_url":"https://api.github.com/users/jhowardmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jhowardmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhowardmsft/subscriptions","organizations_url":"https://api.github.com/users/jhowardmsft/orgs","repos_url":"https://api.github.com/users/jhowardmsft/repos","events_url":"https://api.github.com/users/jhowardmsft/events{/privacy}","received_events_url":"https://api.github.com/users/jhowardmsft/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/group/windows","name":"group/windows","color":"F6FBFF"},{"url":"https://api.github.com/repos/docker/docker/labels/status/0-triage","name":"status/0-triage","color":"EEEEEE"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2016-02-11T02:34:13Z","updated_at":"2016-02-11T02:40:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/20215","html_url":"https://github.com/docker/docker/pull/20215","diff_url":"https://github.com/docker/docker/pull/20215.diff","patch_url":"https://github.com/docker/docker/pull/20215.patch"},"body":"Signed-off-by: John Howard <jhoward@microsoft.com>\r\n\r\nFixes up the failing unit tests for the WindowsTP4 context for pkg\\plugins. It moves the unix:// socket specific test \"TestLocalSocket\" to a unix file. It also annotates where more work needs to be done in the future. However, this does at least mean that we are closer to turning off the \"ignore test-unit failures on WindowsTP4\" flag.\r\n\r\nPreviously failing chunk of output:\r\n```\r\n00:04:43.532 --- FAIL: TestLocalSocket (0.00s)\r\n00:04:43.532 \tdiscovery_test.go:44: listen unix C:\\Windows\\TEMP\\docker-test763715871\\echo.sock: socket: An address incompatible with the requested protocol was used.\r\n00:04:43.532 FAIL\r\n00:04:43.532 coverage: 34.6% of statements\r\n00:04:43.532 FAIL\tgithub.com/docker/docker/pkg/plugins\t1.067s\r\n```\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/182677693","html_url":"https://github.com/docker/docker/pull/20215#issuecomment-182677693","issue_url":"https://api.github.com/repos/docker/docker/issues/20215","id":182677693,"user":{"login":"GordonTheTurtle","id":10620046,"avatar_url":"https://avatars.githubusercontent.com/u/10620046?v=3","gravatar_id":"","url":"https://api.github.com/users/GordonTheTurtle","html_url":"https://github.com/GordonTheTurtle","followers_url":"https://api.github.com/users/GordonTheTurtle/followers","following_url":"https://api.github.com/users/GordonTheTurtle/following{/other_user}","gists_url":"https://api.github.com/users/GordonTheTurtle/gists{/gist_id}","starred_url":"https://api.github.com/users/GordonTheTurtle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordonTheTurtle/subscriptions","organizations_url":"https://api.github.com/users/GordonTheTurtle/orgs","repos_url":"https://api.github.com/users/GordonTheTurtle/repos","events_url":"https://api.github.com/users/GordonTheTurtle/events{/privacy}","received_events_url":"https://api.github.com/users/GordonTheTurtle/received_events","type":"User","site_admin":false},"created_at":"2016-02-11T02:40:37Z","updated_at":"2016-02-11T02:40:37Z","body":"Job: Docker-PRs-experimental [FAILED](https://jenkins.dockerproject.org/job/Docker-PRs-experimental/14878/console):\n\n~~~console\n\n---\nfault-seccomp)\r\n\r\n---> Making bundle: validate-gofmt (in bundles/1.11.0-dev/validate-gofmt)\r\nCongratulations!  All Go source files are properly formatted.\r\n\r\n---> Making bundle: validate-lint (in bundles/1.11.0-dev/validate-lint)\r\nErrors from golint:\r\npkg/plugins/discovery_test_unix.go:13:1: exported function TestLocalSocket should have comment or be unexported\r\n\r\nPlease fix the above errors. You can test via \"golint\" and commit the result.\r\n\r\nBuild step 'Execute shell' marked build as failure\n[PostBuildScript] - Execution post build scripts.\n[Docker-PRs-experimental] $ /bin/sh -xe /tmp/hudson8043801209311699110.sh\n+ set +x\n\n\n---\n\n~~~"}}