{"action":"created","issue":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1364","repository_url":"https://api.github.com/repos/cBioPortal/cbioportal","labels_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1364/labels{/name}","comments_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1364/comments","events_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1364/events","html_url":"https://github.com/cBioPortal/cbioportal/pull/1364","id":160263037,"number":1364,"title":"Stabilizing Maven packaging and deployment for overlays","user":{"login":"morungos","id":442090,"avatar_url":"https://avatars.githubusercontent.com/u/442090?v=3","gravatar_id":"","url":"https://api.github.com/users/morungos","html_url":"https://github.com/morungos","followers_url":"https://api.github.com/users/morungos/followers","following_url":"https://api.github.com/users/morungos/following{/other_user}","gists_url":"https://api.github.com/users/morungos/gists{/gist_id}","starred_url":"https://api.github.com/users/morungos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morungos/subscriptions","organizations_url":"https://api.github.com/users/morungos/orgs","repos_url":"https://api.github.com/users/morungos/repos","events_url":"https://api.github.com/users/morungos/events{/privacy}","received_events_url":"https://api.github.com/users/morungos/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cBioPortal/cbioportal/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-06-14T19:23:47Z","updated_at":"2016-06-15T19:59:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/pulls/1364","html_url":"https://github.com/cBioPortal/cbioportal/pull/1364","diff_url":"https://github.com/cBioPortal/cbioportal/pull/1364.diff","patch_url":"https://github.com/cBioPortal/cbioportal/pull/1364.patch"},"body":"# What? Why?\r\n\r\nChange the way we use Maven so that a standard core deployment will run with mvn compile test package, no need for `PORTAL_HOME`, and no baking in of package values. A stub `portal.properties` is packaged in, but can be replaced in a war overlay and/or at runtime. Maven is also now configured to use a `local.properties` (at top level) for Maven variables to override DB settings, etc. \r\n\r\nFix #1299, #1088, #938 (a bit).\r\n\r\nChanges proposed in this pull request:\r\n- Removing dependencies on `PORTAL_HOME` from build time\r\n- Adds a new `local.properties` Maven property source, used for DB settings, etc.\r\n- Removes the war filename fiddles, making it much easier to deploy and overlay\r\n- Changed the Maven DB settings key to be something other than the vanilla default\r\n- Runtime properties are now drawn from (a) classpath `default.properties`, classpath `portal.properties`, and `$PORTALHOME/portal.properties`, later values taking precedence, enabling both runtime configuration and easy overlays\r\n- Wired the DB version into Java code, because it shouldn't really be in a properties file, especially one that can be modified at runtime. \r\n- Added a range of Maven DB test settings so as not to conflict with the live ones\r\n\r\n# Checks\r\n- [ ] Runs on Heroku.\r\n- [ ] Single commit and [No merge commits](http://nathanleclaire.com/blog/2014/09/14/dont-be-scared-of-git-rebase/)\r\n- [ ] Make sure your commit messages end with a Signed-off-by string (this line\r\n  can be automatically added by git if you run the `git-commit` command with\r\n  the `-s` option)\r\n- [ ] If this is a feature, the PR is to rc. If this is a bug fix, the PR is to\r\n  hotfix.\r\n\r\n# Any screenshots or GIFs?\r\nIf this is a new visual feature please add a before/after screenshot or gif\r\nhere with e.g. [GifGrabber](http://www.gifgrabber.com/).\r\n\r\n# Notify reviewers\r\nIf your pull request involves changes to an existing file, one or more of the\r\npeople that edited before you might be good candidates to review it. Please use\r\n`git blame <filename>` to determine that and notify them here. Otherwise notify\r\neverybody in the core team:\r\n@cBioPortal/core-developers\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/comments/226302451","html_url":"https://github.com/cBioPortal/cbioportal/pull/1364#issuecomment-226302451","issue_url":"https://api.github.com/repos/cBioPortal/cbioportal/issues/1364","id":226302451,"user":{"login":"inodb","id":1334004,"avatar_url":"https://avatars.githubusercontent.com/u/1334004?v=3","gravatar_id":"","url":"https://api.github.com/users/inodb","html_url":"https://github.com/inodb","followers_url":"https://api.github.com/users/inodb/followers","following_url":"https://api.github.com/users/inodb/following{/other_user}","gists_url":"https://api.github.com/users/inodb/gists{/gist_id}","starred_url":"https://api.github.com/users/inodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inodb/subscriptions","organizations_url":"https://api.github.com/users/inodb/orgs","repos_url":"https://api.github.com/users/inodb/repos","events_url":"https://api.github.com/users/inodb/events{/privacy}","received_events_url":"https://api.github.com/users/inodb/received_events","type":"User","site_admin":false},"created_at":"2016-06-15T19:59:46Z","updated_at":"2016-06-15T19:59:46Z","body":":+1: Really great attempt at sorting all these issues. Thank you! Looks like we're getting somewhere.\r\n\r\nFor me it's a little hard to fully follow how some of this configuration would work. It would be great if you could update the `docs/` in the same PR so I can get a better idea of what you have in mind."}}
{"actor":{"display_login":"inodb"}}