{"action":"created","comment":{"url":"https://api.github.com/repos/etianen/html5media/pulls/comments/76207721","id":76207721,"diff_hunk":"@@ -313,10 +313,12 @@\n         replacement.style.cssText = element.style.cssText;\n         replacement.className = element.className;\n         replacement.title = element.title;\n-        replacement.style.display = \"block\";\n+        if (!element.style.display) {\n+            replacement.style.display = \"block\";\n+        }","path":"src/api/html5media.js","position":7,"original_position":7,"commit_id":"28ba7a675c99482514598ba3392a8d2120bcfe3c","original_commit_id":"28ba7a675c99482514598ba3392a8d2120bcfe3c","user":{"login":"etianen","id":148744,"avatar_url":"https://avatars.githubusercontent.com/u/148744?v=3","gravatar_id":"","url":"https://api.github.com/users/etianen","html_url":"https://github.com/etianen","followers_url":"https://api.github.com/users/etianen/followers","following_url":"https://api.github.com/users/etianen/following{/other_user}","gists_url":"https://api.github.com/users/etianen/gists{/gist_id}","starred_url":"https://api.github.com/users/etianen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etianen/subscriptions","organizations_url":"https://api.github.com/users/etianen/orgs","repos_url":"https://api.github.com/users/etianen/repos","events_url":"https://api.github.com/users/etianen/events{/privacy}","received_events_url":"https://api.github.com/users/etianen/received_events","type":"User","site_admin":false},"body":"A thought - could we copy all the style properties over? So the logic would be:\r\n\r\n1. `replacement.style = element.style`.\r\n2. For each \"default\" html5media style, set that style on the element if it's not already set.","created_at":"2016-08-25T09:15:15Z","updated_at":"2016-08-25T09:15:15Z","html_url":"https://github.com/etianen/html5media/pull/67#discussion_r76207721","pull_request_url":"https://api.github.com/repos/etianen/html5media/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/etianen/html5media/pulls/comments/76207721"},"html":{"href":"https://github.com/etianen/html5media/pull/67#discussion_r76207721"},"pull_request":{"href":"https://api.github.com/repos/etianen/html5media/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/etianen/html5media/pulls/67","id":82570181,"html_url":"https://github.com/etianen/html5media/pull/67","diff_url":"https://github.com/etianen/html5media/pull/67.diff","patch_url":"https://github.com/etianen/html5media/pull/67.patch","issue_url":"https://api.github.com/repos/etianen/html5media/issues/67","number":67,"state":"open","locked":false,"title":"Fix Styles If Already Assigned","user":{"login":"fanfavorite","id":668904,"avatar_url":"https://avatars.githubusercontent.com/u/668904?v=3","gravatar_id":"","url":"https://api.github.com/users/fanfavorite","html_url":"https://github.com/fanfavorite","followers_url":"https://api.github.com/users/fanfavorite/followers","following_url":"https://api.github.com/users/fanfavorite/following{/other_user}","gists_url":"https://api.github.com/users/fanfavorite/gists{/gist_id}","starred_url":"https://api.github.com/users/fanfavorite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanfavorite/subscriptions","organizations_url":"https://api.github.com/users/fanfavorite/orgs","repos_url":"https://api.github.com/users/fanfavorite/repos","events_url":"https://api.github.com/users/fanfavorite/events{/privacy}","received_events_url":"https://api.github.com/users/fanfavorite/received_events","type":"User","site_admin":false},"body":"The fallback element will always be set as a block element as it currently is. I needed the ability to set it as hidden on load, so I set the script to only set to block if it doesn't exist. The audio height also was set to always be 26px high. People may want to set this also, so I put through the getDimension function.","created_at":"2016-08-24T15:59:36Z","updated_at":"2016-08-25T09:15:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e6de0715403ce9e7eae32086dbaf4a1110e24b8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/etianen/html5media/pulls/67/commits","review_comments_url":"https://api.github.com/repos/etianen/html5media/pulls/67/comments","review_comment_url":"https://api.github.com/repos/etianen/html5media/pulls/comments{/number}","comments_url":"https://api.github.com/repos/etianen/html5media/issues/67/comments","statuses_url":"https://api.github.com/repos/etianen/html5media/statuses/28ba7a675c99482514598ba3392a8d2120bcfe3c","head":{"label":"fanfavorite:patch-6","ref":"patch-6","sha":"28ba7a675c99482514598ba3392a8d2120bcfe3c","user":{"login":"fanfavorite","id":668904,"avatar_url":"https://avatars.githubusercontent.com/u/668904?v=3","gravatar_id":"","url":"https://api.github.com/users/fanfavorite","html_url":"https://github.com/fanfavorite","followers_url":"https://api.github.com/users/fanfavorite/followers","following_url":"https://api.github.com/users/fanfavorite/following{/other_user}","gists_url":"https://api.github.com/users/fanfavorite/gists{/gist_id}","starred_url":"https://api.github.com/users/fanfavorite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanfavorite/subscriptions","organizations_url":"https://api.github.com/users/fanfavorite/orgs","repos_url":"https://api.github.com/users/fanfavorite/repos","events_url":"https://api.github.com/users/fanfavorite/events{/privacy}","received_events_url":"https://api.github.com/users/fanfavorite/received_events","type":"User","site_admin":false},"repo":{"id":12876136,"name":"html5media","full_name":"fanfavorite/html5media","owner":{"login":"fanfavorite","id":668904,"avatar_url":"https://avatars.githubusercontent.com/u/668904?v=3","gravatar_id":"","url":"https://api.github.com/users/fanfavorite","html_url":"https://github.com/fanfavorite","followers_url":"https://api.github.com/users/fanfavorite/followers","following_url":"https://api.github.com/users/fanfavorite/following{/other_user}","gists_url":"https://api.github.com/users/fanfavorite/gists{/gist_id}","starred_url":"https://api.github.com/users/fanfavorite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanfavorite/subscriptions","organizations_url":"https://api.github.com/users/fanfavorite/orgs","repos_url":"https://api.github.com/users/fanfavorite/repos","events_url":"https://api.github.com/users/fanfavorite/events{/privacy}","received_events_url":"https://api.github.com/users/fanfavorite/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fanfavorite/html5media","description":"Enables <video> and <audio> tags in all major browsers.","fork":true,"url":"https://api.github.com/repos/fanfavorite/html5media","forks_url":"https://api.github.com/repos/fanfavorite/html5media/forks","keys_url":"https://api.github.com/repos/fanfavorite/html5media/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fanfavorite/html5media/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fanfavorite/html5media/teams","hooks_url":"https://api.github.com/repos/fanfavorite/html5media/hooks","issue_events_url":"https://api.github.com/repos/fanfavorite/html5media/issues/events{/number}","events_url":"https://api.github.com/repos/fanfavorite/html5media/events","assignees_url":"https://api.github.com/repos/fanfavorite/html5media/assignees{/user}","branches_url":"https://api.github.com/repos/fanfavorite/html5media/branches{/branch}","tags_url":"https://api.github.com/repos/fanfavorite/html5media/tags","blobs_url":"https://api.github.com/repos/fanfavorite/html5media/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fanfavorite/html5media/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fanfavorite/html5media/git/refs{/sha}","trees_url":"https://api.github.com/repos/fanfavorite/html5media/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fanfavorite/html5media/statuses/{sha}","languages_url":"https://api.github.com/repos/fanfavorite/html5media/languages","stargazers_url":"https://api.github.com/repos/fanfavorite/html5media/stargazers","contributors_url":"https://api.github.com/repos/fanfavorite/html5media/contributors","subscribers_url":"https://api.github.com/repos/fanfavorite/html5media/subscribers","subscription_url":"https://api.github.com/repos/fanfavorite/html5media/subscription","commits_url":"https://api.github.com/repos/fanfavorite/html5media/commits{/sha}","git_commits_url":"https://api.github.com/repos/fanfavorite/html5media/git/commits{/sha}","comments_url":"https://api.github.com/repos/fanfavorite/html5media/comments{/number}","issue_comment_url":"https://api.github.com/repos/fanfavorite/html5media/issues/comments{/number}","contents_url":"https://api.github.com/repos/fanfavorite/html5media/contents/{+path}","compare_url":"https://api.github.com/repos/fanfavorite/html5media/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fanfavorite/html5media/merges","archive_url":"https://api.github.com/repos/fanfavorite/html5media/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fanfavorite/html5media/downloads","issues_url":"https://api.github.com/repos/fanfavorite/html5media/issues{/number}","pulls_url":"https://api.github.com/repos/fanfavorite/html5media/pulls{/number}","milestones_url":"https://api.github.com/repos/fanfavorite/html5media/milestones{/number}","notifications_url":"https://api.github.com/repos/fanfavorite/html5media/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fanfavorite/html5media/labels{/name}","releases_url":"https://api.github.com/repos/fanfavorite/html5media/releases{/id}","deployments_url":"https://api.github.com/repos/fanfavorite/html5media/deployments","created_at":"2013-09-16T19:12:49Z","updated_at":"2013-09-23T08:46:20Z","pushed_at":"2016-08-24T16:04:07Z","git_url":"git://github.com/fanfavorite/html5media.git","ssh_url":"git@github.com:fanfavorite/html5media.git","clone_url":"https://github.com/fanfavorite/html5media.git","svn_url":"https://github.com/fanfavorite/html5media","homepage":"http://html5media.info/","size":64986,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"etianen:master","ref":"master","sha":"351d1833844b6d154f8931c8d99fb7c1c269d01b","user":{"login":"etianen","id":148744,"avatar_url":"https://avatars.githubusercontent.com/u/148744?v=3","gravatar_id":"","url":"https://api.github.com/users/etianen","html_url":"https://github.com/etianen","followers_url":"https://api.github.com/users/etianen/followers","following_url":"https://api.github.com/users/etianen/following{/other_user}","gists_url":"https://api.github.com/users/etianen/gists{/gist_id}","starred_url":"https://api.github.com/users/etianen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etianen/subscriptions","organizations_url":"https://api.github.com/users/etianen/orgs","repos_url":"https://api.github.com/users/etianen/repos","events_url":"https://api.github.com/users/etianen/events{/privacy}","received_events_url":"https://api.github.com/users/etianen/received_events","type":"User","site_admin":false},"repo":{"id":709761,"name":"html5media","full_name":"etianen/html5media","owner":{"login":"etianen","id":148744,"avatar_url":"https://avatars.githubusercontent.com/u/148744?v=3","gravatar_id":"","url":"https://api.github.com/users/etianen","html_url":"https://github.com/etianen","followers_url":"https://api.github.com/users/etianen/followers","following_url":"https://api.github.com/users/etianen/following{/other_user}","gists_url":"https://api.github.com/users/etianen/gists{/gist_id}","starred_url":"https://api.github.com/users/etianen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etianen/subscriptions","organizations_url":"https://api.github.com/users/etianen/orgs","repos_url":"https://api.github.com/users/etianen/repos","events_url":"https://api.github.com/users/etianen/events{/privacy}","received_events_url":"https://api.github.com/users/etianen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/etianen/html5media","description":"Enables <video> and <audio> tags in all major browsers.","fork":false,"url":"https://api.github.com/repos/etianen/html5media","forks_url":"https://api.github.com/repos/etianen/html5media/forks","keys_url":"https://api.github.com/repos/etianen/html5media/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etianen/html5media/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etianen/html5media/teams","hooks_url":"https://api.github.com/repos/etianen/html5media/hooks","issue_events_url":"https://api.github.com/repos/etianen/html5media/issues/events{/number}","events_url":"https://api.github.com/repos/etianen/html5media/events","assignees_url":"https://api.github.com/repos/etianen/html5media/assignees{/user}","branches_url":"https://api.github.com/repos/etianen/html5media/branches{/branch}","tags_url":"https://api.github.com/repos/etianen/html5media/tags","blobs_url":"https://api.github.com/repos/etianen/html5media/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etianen/html5media/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etianen/html5media/git/refs{/sha}","trees_url":"https://api.github.com/repos/etianen/html5media/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etianen/html5media/statuses/{sha}","languages_url":"https://api.github.com/repos/etianen/html5media/languages","stargazers_url":"https://api.github.com/repos/etianen/html5media/stargazers","contributors_url":"https://api.github.com/repos/etianen/html5media/contributors","subscribers_url":"https://api.github.com/repos/etianen/html5media/subscribers","subscription_url":"https://api.github.com/repos/etianen/html5media/subscription","commits_url":"https://api.github.com/repos/etianen/html5media/commits{/sha}","git_commits_url":"https://api.github.com/repos/etianen/html5media/git/commits{/sha}","comments_url":"https://api.github.com/repos/etianen/html5media/comments{/number}","issue_comment_url":"https://api.github.com/repos/etianen/html5media/issues/comments{/number}","contents_url":"https://api.github.com/repos/etianen/html5media/contents/{+path}","compare_url":"https://api.github.com/repos/etianen/html5media/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etianen/html5media/merges","archive_url":"https://api.github.com/repos/etianen/html5media/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etianen/html5media/downloads","issues_url":"https://api.github.com/repos/etianen/html5media/issues{/number}","pulls_url":"https://api.github.com/repos/etianen/html5media/pulls{/number}","milestones_url":"https://api.github.com/repos/etianen/html5media/milestones{/number}","notifications_url":"https://api.github.com/repos/etianen/html5media/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etianen/html5media/labels{/name}","releases_url":"https://api.github.com/repos/etianen/html5media/releases{/id}","deployments_url":"https://api.github.com/repos/etianen/html5media/deployments","created_at":"2010-06-08T16:20:24Z","updated_at":"2016-08-23T06:34:49Z","pushed_at":"2016-08-25T09:10:02Z","git_url":"git://github.com/etianen/html5media.git","ssh_url":"git@github.com:etianen/html5media.git","clone_url":"https://github.com/etianen/html5media.git","svn_url":"https://github.com/etianen/html5media","homepage":"http://html5media.info/","size":65111,"stargazers_count":836,"watchers_count":836,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":183,"mirror_url":null,"open_issues_count":14,"forks":183,"open_issues":14,"watchers":836,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/etianen/html5media/pulls/67"},"html":{"href":"https://github.com/etianen/html5media/pull/67"},"issue":{"href":"https://api.github.com/repos/etianen/html5media/issues/67"},"comments":{"href":"https://api.github.com/repos/etianen/html5media/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/etianen/html5media/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/etianen/html5media/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/etianen/html5media/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/etianen/html5media/statuses/28ba7a675c99482514598ba3392a8d2120bcfe3c"}}}}
{"actor":{"display_login":"etianen"}}