{"action":"closed","number":100,"pull_request":{"url":"https://api.github.com/repos/atom/language-go/pulls/100","id":90514628,"html_url":"https://github.com/atom/language-go/pull/100","diff_url":"https://github.com/atom/language-go/pull/100.diff","patch_url":"https://github.com/atom/language-go/pull/100.patch","issue_url":"https://api.github.com/repos/atom/language-go/issues/100","number":100,"state":"closed","locked":false,"title":"fixed tab stop order for go snippet","user":{"login":"xh3b4sd","id":552769,"avatar_url":"https://avatars.githubusercontent.com/u/552769?v=3","gravatar_id":"","url":"https://api.github.com/users/xh3b4sd","html_url":"https://github.com/xh3b4sd","followers_url":"https://api.github.com/users/xh3b4sd/followers","following_url":"https://api.github.com/users/xh3b4sd/following{/other_user}","gists_url":"https://api.github.com/users/xh3b4sd/gists{/gist_id}","starred_url":"https://api.github.com/users/xh3b4sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xh3b4sd/subscriptions","organizations_url":"https://api.github.com/users/xh3b4sd/orgs","repos_url":"https://api.github.com/users/xh3b4sd/repos","events_url":"https://api.github.com/users/xh3b4sd/events{/privacy}","received_events_url":"https://api.github.com/users/xh3b4sd/received_events","type":"User","site_admin":false},"body":"This PR fixes the tab stop order in such a way that the first tab stops where arguments from the outer scopes are provided as arguments to the function which is executed within a new goroutine. The current behaviour stops the tab where you receive the arguments, which was counterintuitive for me. IMO the first thing you want to do is to provide something to a function. Then you can write the definitions to receive arguments. Further I am not sure why `$0` is used as tab stop identifier. This happens in several places of the language-go snippets. As far as I can see this does actually nothing to the order. According to the documentation there can also no reference to `$0` be found. What do you think? \n","created_at":"2016-10-23T13:00:47Z","updated_at":"2016-12-20T10:49:44Z","closed_at":"2016-12-20T10:49:44Z","merged_at":null,"merge_commit_sha":"0606de5d7166f05d38092744da186600c62580fc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/atom/language-go/pulls/100/commits","review_comments_url":"https://api.github.com/repos/atom/language-go/pulls/100/comments","review_comment_url":"https://api.github.com/repos/atom/language-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/language-go/issues/100/comments","statuses_url":"https://api.github.com/repos/atom/language-go/statuses/f23fdeb969a13f84ebc0bedf37146eef60b4b5be","head":{"label":"xh3b4sd:tab-stop-order","ref":"tab-stop-order","sha":"f23fdeb969a13f84ebc0bedf37146eef60b4b5be","user":{"login":"xh3b4sd","id":552769,"avatar_url":"https://avatars.githubusercontent.com/u/552769?v=3","gravatar_id":"","url":"https://api.github.com/users/xh3b4sd","html_url":"https://github.com/xh3b4sd","followers_url":"https://api.github.com/users/xh3b4sd/followers","following_url":"https://api.github.com/users/xh3b4sd/following{/other_user}","gists_url":"https://api.github.com/users/xh3b4sd/gists{/gist_id}","starred_url":"https://api.github.com/users/xh3b4sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xh3b4sd/subscriptions","organizations_url":"https://api.github.com/users/xh3b4sd/orgs","repos_url":"https://api.github.com/users/xh3b4sd/repos","events_url":"https://api.github.com/users/xh3b4sd/events{/privacy}","received_events_url":"https://api.github.com/users/xh3b4sd/received_events","type":"User","site_admin":false},"repo":{"id":71701774,"name":"language-go","full_name":"xh3b4sd/language-go","owner":{"login":"xh3b4sd","id":552769,"avatar_url":"https://avatars.githubusercontent.com/u/552769?v=3","gravatar_id":"","url":"https://api.github.com/users/xh3b4sd","html_url":"https://github.com/xh3b4sd","followers_url":"https://api.github.com/users/xh3b4sd/followers","following_url":"https://api.github.com/users/xh3b4sd/following{/other_user}","gists_url":"https://api.github.com/users/xh3b4sd/gists{/gist_id}","starred_url":"https://api.github.com/users/xh3b4sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xh3b4sd/subscriptions","organizations_url":"https://api.github.com/users/xh3b4sd/orgs","repos_url":"https://api.github.com/users/xh3b4sd/repos","events_url":"https://api.github.com/users/xh3b4sd/events{/privacy}","received_events_url":"https://api.github.com/users/xh3b4sd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xh3b4sd/language-go","description":"Go language package for Atom","fork":true,"url":"https://api.github.com/repos/xh3b4sd/language-go","forks_url":"https://api.github.com/repos/xh3b4sd/language-go/forks","keys_url":"https://api.github.com/repos/xh3b4sd/language-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xh3b4sd/language-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xh3b4sd/language-go/teams","hooks_url":"https://api.github.com/repos/xh3b4sd/language-go/hooks","issue_events_url":"https://api.github.com/repos/xh3b4sd/language-go/issues/events{/number}","events_url":"https://api.github.com/repos/xh3b4sd/language-go/events","assignees_url":"https://api.github.com/repos/xh3b4sd/language-go/assignees{/user}","branches_url":"https://api.github.com/repos/xh3b4sd/language-go/branches{/branch}","tags_url":"https://api.github.com/repos/xh3b4sd/language-go/tags","blobs_url":"https://api.github.com/repos/xh3b4sd/language-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xh3b4sd/language-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xh3b4sd/language-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/xh3b4sd/language-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xh3b4sd/language-go/statuses/{sha}","languages_url":"https://api.github.com/repos/xh3b4sd/language-go/languages","stargazers_url":"https://api.github.com/repos/xh3b4sd/language-go/stargazers","contributors_url":"https://api.github.com/repos/xh3b4sd/language-go/contributors","subscribers_url":"https://api.github.com/repos/xh3b4sd/language-go/subscribers","subscription_url":"https://api.github.com/repos/xh3b4sd/language-go/subscription","commits_url":"https://api.github.com/repos/xh3b4sd/language-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/xh3b4sd/language-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/xh3b4sd/language-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/xh3b4sd/language-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/xh3b4sd/language-go/contents/{+path}","compare_url":"https://api.github.com/repos/xh3b4sd/language-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xh3b4sd/language-go/merges","archive_url":"https://api.github.com/repos/xh3b4sd/language-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xh3b4sd/language-go/downloads","issues_url":"https://api.github.com/repos/xh3b4sd/language-go/issues{/number}","pulls_url":"https://api.github.com/repos/xh3b4sd/language-go/pulls{/number}","milestones_url":"https://api.github.com/repos/xh3b4sd/language-go/milestones{/number}","notifications_url":"https://api.github.com/repos/xh3b4sd/language-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xh3b4sd/language-go/labels{/name}","releases_url":"https://api.github.com/repos/xh3b4sd/language-go/releases{/id}","deployments_url":"https://api.github.com/repos/xh3b4sd/language-go/deployments","created_at":"2016-10-23T12:36:06Z","updated_at":"2016-10-23T12:36:07Z","pushed_at":"2016-10-23T12:55:31Z","git_url":"git://github.com/xh3b4sd/language-go.git","ssh_url":"git@github.com:xh3b4sd/language-go.git","clone_url":"https://github.com/xh3b4sd/language-go.git","svn_url":"https://github.com/xh3b4sd/language-go","homepage":null,"size":208,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"fb34e8f859707fb436d4bc1fe3d2a168383374a9","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":13711887,"name":"language-go","full_name":"atom/language-go","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/language-go","description":"Go language package for Atom","fork":false,"url":"https://api.github.com/repos/atom/language-go","forks_url":"https://api.github.com/repos/atom/language-go/forks","keys_url":"https://api.github.com/repos/atom/language-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/language-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/language-go/teams","hooks_url":"https://api.github.com/repos/atom/language-go/hooks","issue_events_url":"https://api.github.com/repos/atom/language-go/issues/events{/number}","events_url":"https://api.github.com/repos/atom/language-go/events","assignees_url":"https://api.github.com/repos/atom/language-go/assignees{/user}","branches_url":"https://api.github.com/repos/atom/language-go/branches{/branch}","tags_url":"https://api.github.com/repos/atom/language-go/tags","blobs_url":"https://api.github.com/repos/atom/language-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/language-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/language-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/language-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/language-go/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/language-go/languages","stargazers_url":"https://api.github.com/repos/atom/language-go/stargazers","contributors_url":"https://api.github.com/repos/atom/language-go/contributors","subscribers_url":"https://api.github.com/repos/atom/language-go/subscribers","subscription_url":"https://api.github.com/repos/atom/language-go/subscription","commits_url":"https://api.github.com/repos/atom/language-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/language-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/language-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/language-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/language-go/contents/{+path}","compare_url":"https://api.github.com/repos/atom/language-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/language-go/merges","archive_url":"https://api.github.com/repos/atom/language-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/language-go/downloads","issues_url":"https://api.github.com/repos/atom/language-go/issues{/number}","pulls_url":"https://api.github.com/repos/atom/language-go/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/language-go/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/language-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/language-go/labels{/name}","releases_url":"https://api.github.com/repos/atom/language-go/releases{/id}","deployments_url":"https://api.github.com/repos/atom/language-go/deployments","created_at":"2013-10-20T01:39:44Z","updated_at":"2016-10-06T00:34:00Z","pushed_at":"2016-10-23T13:00:48Z","git_url":"git://github.com/atom/language-go.git","ssh_url":"git@github.com:atom/language-go.git","clone_url":"https://github.com/atom/language-go.git","svn_url":"https://github.com/atom/language-go","homepage":null,"size":240,"stargazers_count":88,"watchers_count":88,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":12,"forks":37,"open_issues":12,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/language-go/pulls/100"},"html":{"href":"https://github.com/atom/language-go/pull/100"},"issue":{"href":"https://api.github.com/repos/atom/language-go/issues/100"},"comments":{"href":"https://api.github.com/repos/atom/language-go/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/language-go/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/language-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/language-go/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/atom/language-go/statuses/f23fdeb969a13f84ebc0bedf37146eef60b4b5be"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"xh3b4sd"}}