{"action":"created","comment":{"url":"https://api.github.com/repos/philss/floki/pulls/comments/73036787","id":73036787,"diff_hunk":"@@ -68,18 +68,7 @@ defmodule Floki.Finder do\n         case combinator do\n           nil -> [html_node|acc]\n           _ ->\n-            case combinator.match_type do\n-              :descendant ->\n-                traverse(children_nodes, sibling_nodes, combinator.selector, acc)\n-              :child ->\n-                traverse_child(children_nodes, sibling_nodes, combinator.selector, acc)\n-              :sibling ->\n-                traverse_sibling(children_nodes, sibling_nodes, combinator.selector, acc)\n-              :general_sibling ->\n-                traverse_general_sibling(children_nodes, sibling_nodes, combinator.selector, acc)\n-              other ->\n-                raise \"Combinator of type \\\"#{other}\\\" not implemented\"\n-            end\n+            traverse_using(combinator.match_type, children_nodes, sibling_nodes, combinator.selector, acc)","path":"lib/floki/finder.ex","position":null,"original_position":16,"commit_id":"76975f1173460433761a560736034c813cf4f7e3","original_commit_id":"d32d1fa6eebda6399091d24ad98cc30670bceef9","user":{"login":"gmile","id":207112,"avatar_url":"https://avatars.githubusercontent.com/u/207112?v=3","gravatar_id":"","url":"https://api.github.com/users/gmile","html_url":"https://github.com/gmile","followers_url":"https://api.github.com/users/gmile/followers","following_url":"https://api.github.com/users/gmile/following{/other_user}","gists_url":"https://api.github.com/users/gmile/gists{/gist_id}","starred_url":"https://api.github.com/users/gmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmile/subscriptions","organizations_url":"https://api.github.com/users/gmile/orgs","repos_url":"https://api.github.com/users/gmile/repos","events_url":"https://api.github.com/users/gmile/events{/privacy}","received_events_url":"https://api.github.com/users/gmile/received_events","type":"User","site_admin":false},"body":"@philss sure, I just pushed the change","created_at":"2016-08-01T19:22:04Z","updated_at":"2016-08-01T19:22:04Z","html_url":"https://github.com/philss/floki/pull/59#discussion_r73036787","pull_request_url":"https://api.github.com/repos/philss/floki/pulls/59","_links":{"self":{"href":"https://api.github.com/repos/philss/floki/pulls/comments/73036787"},"html":{"href":"https://github.com/philss/floki/pull/59#discussion_r73036787"},"pull_request":{"href":"https://api.github.com/repos/philss/floki/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/philss/floki/pulls/59","id":79534837,"html_url":"https://github.com/philss/floki/pull/59","diff_url":"https://github.com/philss/floki/pull/59.diff","patch_url":"https://github.com/philss/floki/pull/59.patch","issue_url":"https://api.github.com/repos/philss/floki/issues/59","number":59,"state":"open","locked":false,"title":"Extract traversal selection","user":{"login":"gmile","id":207112,"avatar_url":"https://avatars.githubusercontent.com/u/207112?v=3","gravatar_id":"","url":"https://api.github.com/users/gmile","html_url":"https://github.com/gmile","followers_url":"https://api.github.com/users/gmile/followers","following_url":"https://api.github.com/users/gmile/following{/other_user}","gists_url":"https://api.github.com/users/gmile/gists{/gist_id}","starred_url":"https://api.github.com/users/gmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmile/subscriptions","organizations_url":"https://api.github.com/users/gmile/orgs","repos_url":"https://api.github.com/users/gmile/repos","events_url":"https://api.github.com/users/gmile/events{/privacy}","received_events_url":"https://api.github.com/users/gmile/received_events","type":"User","site_admin":false},"body":null,"created_at":"2016-08-01T08:57:18Z","updated_at":"2016-08-01T19:22:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2919db75c28b3065fa6a192ca5176d7a56110b8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/philss/floki/pulls/59/commits","review_comments_url":"https://api.github.com/repos/philss/floki/pulls/59/comments","review_comment_url":"https://api.github.com/repos/philss/floki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/philss/floki/issues/59/comments","statuses_url":"https://api.github.com/repos/philss/floki/statuses/76975f1173460433761a560736034c813cf4f7e3","head":{"label":"gmile:extract-traversal-selection","ref":"extract-traversal-selection","sha":"76975f1173460433761a560736034c813cf4f7e3","user":{"login":"gmile","id":207112,"avatar_url":"https://avatars.githubusercontent.com/u/207112?v=3","gravatar_id":"","url":"https://api.github.com/users/gmile","html_url":"https://github.com/gmile","followers_url":"https://api.github.com/users/gmile/followers","following_url":"https://api.github.com/users/gmile/following{/other_user}","gists_url":"https://api.github.com/users/gmile/gists{/gist_id}","starred_url":"https://api.github.com/users/gmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmile/subscriptions","organizations_url":"https://api.github.com/users/gmile/orgs","repos_url":"https://api.github.com/users/gmile/repos","events_url":"https://api.github.com/users/gmile/events{/privacy}","received_events_url":"https://api.github.com/users/gmile/received_events","type":"User","site_admin":false},"repo":{"id":60622357,"name":"floki","full_name":"gmile/floki","owner":{"login":"gmile","id":207112,"avatar_url":"https://avatars.githubusercontent.com/u/207112?v=3","gravatar_id":"","url":"https://api.github.com/users/gmile","html_url":"https://github.com/gmile","followers_url":"https://api.github.com/users/gmile/followers","following_url":"https://api.github.com/users/gmile/following{/other_user}","gists_url":"https://api.github.com/users/gmile/gists{/gist_id}","starred_url":"https://api.github.com/users/gmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmile/subscriptions","organizations_url":"https://api.github.com/users/gmile/orgs","repos_url":"https://api.github.com/users/gmile/repos","events_url":"https://api.github.com/users/gmile/events{/privacy}","received_events_url":"https://api.github.com/users/gmile/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gmile/floki","description":"Floki is a simple HTML parser that enables search for nodes using CSS selectors.","fork":true,"url":"https://api.github.com/repos/gmile/floki","forks_url":"https://api.github.com/repos/gmile/floki/forks","keys_url":"https://api.github.com/repos/gmile/floki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gmile/floki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gmile/floki/teams","hooks_url":"https://api.github.com/repos/gmile/floki/hooks","issue_events_url":"https://api.github.com/repos/gmile/floki/issues/events{/number}","events_url":"https://api.github.com/repos/gmile/floki/events","assignees_url":"https://api.github.com/repos/gmile/floki/assignees{/user}","branches_url":"https://api.github.com/repos/gmile/floki/branches{/branch}","tags_url":"https://api.github.com/repos/gmile/floki/tags","blobs_url":"https://api.github.com/repos/gmile/floki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gmile/floki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gmile/floki/git/refs{/sha}","trees_url":"https://api.github.com/repos/gmile/floki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gmile/floki/statuses/{sha}","languages_url":"https://api.github.com/repos/gmile/floki/languages","stargazers_url":"https://api.github.com/repos/gmile/floki/stargazers","contributors_url":"https://api.github.com/repos/gmile/floki/contributors","subscribers_url":"https://api.github.com/repos/gmile/floki/subscribers","subscription_url":"https://api.github.com/repos/gmile/floki/subscription","commits_url":"https://api.github.com/repos/gmile/floki/commits{/sha}","git_commits_url":"https://api.github.com/repos/gmile/floki/git/commits{/sha}","comments_url":"https://api.github.com/repos/gmile/floki/comments{/number}","issue_comment_url":"https://api.github.com/repos/gmile/floki/issues/comments{/number}","contents_url":"https://api.github.com/repos/gmile/floki/contents/{+path}","compare_url":"https://api.github.com/repos/gmile/floki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gmile/floki/merges","archive_url":"https://api.github.com/repos/gmile/floki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gmile/floki/downloads","issues_url":"https://api.github.com/repos/gmile/floki/issues{/number}","pulls_url":"https://api.github.com/repos/gmile/floki/pulls{/number}","milestones_url":"https://api.github.com/repos/gmile/floki/milestones{/number}","notifications_url":"https://api.github.com/repos/gmile/floki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gmile/floki/labels{/name}","releases_url":"https://api.github.com/repos/gmile/floki/releases{/id}","deployments_url":"https://api.github.com/repos/gmile/floki/deployments","created_at":"2016-06-07T14:59:37Z","updated_at":"2016-06-07T14:59:39Z","pushed_at":"2016-08-01T19:21:47Z","git_url":"git://github.com/gmile/floki.git","ssh_url":"git@github.com:gmile/floki.git","clone_url":"https://github.com/gmile/floki.git","svn_url":"https://github.com/gmile/floki","homepage":"https://hex.pm/packages/floki","size":193,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"philss:master","ref":"master","sha":"ba3b1e3587e7fff90c38df1da7ede09f86d8fcf3","user":{"login":"philss","id":381213,"avatar_url":"https://avatars.githubusercontent.com/u/381213?v=3","gravatar_id":"","url":"https://api.github.com/users/philss","html_url":"https://github.com/philss","followers_url":"https://api.github.com/users/philss/followers","following_url":"https://api.github.com/users/philss/following{/other_user}","gists_url":"https://api.github.com/users/philss/gists{/gist_id}","starred_url":"https://api.github.com/users/philss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philss/subscriptions","organizations_url":"https://api.github.com/users/philss/orgs","repos_url":"https://api.github.com/users/philss/repos","events_url":"https://api.github.com/users/philss/events{/privacy}","received_events_url":"https://api.github.com/users/philss/received_events","type":"User","site_admin":false},"repo":{"id":26092799,"name":"floki","full_name":"philss/floki","owner":{"login":"philss","id":381213,"avatar_url":"https://avatars.githubusercontent.com/u/381213?v=3","gravatar_id":"","url":"https://api.github.com/users/philss","html_url":"https://github.com/philss","followers_url":"https://api.github.com/users/philss/followers","following_url":"https://api.github.com/users/philss/following{/other_user}","gists_url":"https://api.github.com/users/philss/gists{/gist_id}","starred_url":"https://api.github.com/users/philss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philss/subscriptions","organizations_url":"https://api.github.com/users/philss/orgs","repos_url":"https://api.github.com/users/philss/repos","events_url":"https://api.github.com/users/philss/events{/privacy}","received_events_url":"https://api.github.com/users/philss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/philss/floki","description":"Floki is a simple HTML parser that enables search for nodes using CSS selectors.","fork":false,"url":"https://api.github.com/repos/philss/floki","forks_url":"https://api.github.com/repos/philss/floki/forks","keys_url":"https://api.github.com/repos/philss/floki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philss/floki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philss/floki/teams","hooks_url":"https://api.github.com/repos/philss/floki/hooks","issue_events_url":"https://api.github.com/repos/philss/floki/issues/events{/number}","events_url":"https://api.github.com/repos/philss/floki/events","assignees_url":"https://api.github.com/repos/philss/floki/assignees{/user}","branches_url":"https://api.github.com/repos/philss/floki/branches{/branch}","tags_url":"https://api.github.com/repos/philss/floki/tags","blobs_url":"https://api.github.com/repos/philss/floki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philss/floki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philss/floki/git/refs{/sha}","trees_url":"https://api.github.com/repos/philss/floki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philss/floki/statuses/{sha}","languages_url":"https://api.github.com/repos/philss/floki/languages","stargazers_url":"https://api.github.com/repos/philss/floki/stargazers","contributors_url":"https://api.github.com/repos/philss/floki/contributors","subscribers_url":"https://api.github.com/repos/philss/floki/subscribers","subscription_url":"https://api.github.com/repos/philss/floki/subscription","commits_url":"https://api.github.com/repos/philss/floki/commits{/sha}","git_commits_url":"https://api.github.com/repos/philss/floki/git/commits{/sha}","comments_url":"https://api.github.com/repos/philss/floki/comments{/number}","issue_comment_url":"https://api.github.com/repos/philss/floki/issues/comments{/number}","contents_url":"https://api.github.com/repos/philss/floki/contents/{+path}","compare_url":"https://api.github.com/repos/philss/floki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philss/floki/merges","archive_url":"https://api.github.com/repos/philss/floki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philss/floki/downloads","issues_url":"https://api.github.com/repos/philss/floki/issues{/number}","pulls_url":"https://api.github.com/repos/philss/floki/pulls{/number}","milestones_url":"https://api.github.com/repos/philss/floki/milestones{/number}","notifications_url":"https://api.github.com/repos/philss/floki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philss/floki/labels{/name}","releases_url":"https://api.github.com/repos/philss/floki/releases{/id}","deployments_url":"https://api.github.com/repos/philss/floki/deployments","created_at":"2014-11-02T20:49:15Z","updated_at":"2016-07-31T03:20:05Z","pushed_at":"2016-08-01T19:21:47Z","git_url":"git://github.com/philss/floki.git","ssh_url":"git@github.com:philss/floki.git","clone_url":"https://github.com/philss/floki.git","svn_url":"https://github.com/philss/floki","homepage":"https://hex.pm/packages/floki","size":199,"stargazers_count":333,"watchers_count":333,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":5,"forks":31,"open_issues":5,"watchers":333,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/philss/floki/pulls/59"},"html":{"href":"https://github.com/philss/floki/pull/59"},"issue":{"href":"https://api.github.com/repos/philss/floki/issues/59"},"comments":{"href":"https://api.github.com/repos/philss/floki/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/philss/floki/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/philss/floki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/philss/floki/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/philss/floki/statuses/76975f1173460433761a560736034c813cf4f7e3"}}}}
{"actor":{"display_login":"gmile"}}