{"action":"created","issue":{"url":"https://api.github.com/repos/Zewo/Zewo/issues/186","repository_url":"https://api.github.com/repos/Zewo/Zewo","labels_url":"https://api.github.com/repos/Zewo/Zewo/issues/186/labels{/name}","comments_url":"https://api.github.com/repos/Zewo/Zewo/issues/186/comments","events_url":"https://api.github.com/repos/Zewo/Zewo/issues/186/events","html_url":"https://github.com/Zewo/Zewo/issues/186","id":182358293,"number":186,"title":"SHA1 is calculated incorrectly in zewo/Websocket","user":{"login":"JimiSmith","id":914634,"avatar_url":"https://avatars.githubusercontent.com/u/914634?v=3","gravatar_id":"","url":"https://api.github.com/users/JimiSmith","html_url":"https://github.com/JimiSmith","followers_url":"https://api.github.com/users/JimiSmith/followers","following_url":"https://api.github.com/users/JimiSmith/following{/other_user}","gists_url":"https://api.github.com/users/JimiSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/JimiSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimiSmith/subscriptions","organizations_url":"https://api.github.com/users/JimiSmith/orgs","repos_url":"https://api.github.com/users/JimiSmith/repos","events_url":"https://api.github.com/users/JimiSmith/events{/privacy}","received_events_url":"https://api.github.com/users/JimiSmith/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-11T19:55:34Z","updated_at":"2016-10-11T21:06:24Z","closed_at":null,"body":"The SHA1 sum is calculated incorrectly when opening a web socket. This causes the websocket to fail to open on at least Chrome\r\n\r\nAttempt to open a websocket connection to a zewo websocket server from chrome - the socket connection will fail with the following message: WebSocket connection to 'ws://localhost:8080/socket failed: Error during WebSocket handshake: Incorrect 'Sec-WebSocket-Accept' header value\r\n\r\nThe error is in the arrayOfBytes function in SHA1.swift. I replaced the implementation of that with the one from [CryptoSwift](https://github.com/krzyzanowskim/CryptoSwift/blob/13764570021ca73c315c3de18f367e5fdb55d785/Sources/CryptoSwift/Generics.swift#L38) and that resolved the issue. I'm happy to submit a pull request with this change if needed?"},"comment":{"url":"https://api.github.com/repos/Zewo/Zewo/issues/comments/253046249","html_url":"https://github.com/Zewo/Zewo/issues/186#issuecomment-253046249","issue_url":"https://api.github.com/repos/Zewo/Zewo/issues/186","id":253046249,"user":{"login":"Danappelxx","id":3291251,"avatar_url":"https://avatars.githubusercontent.com/u/3291251?v=3","gravatar_id":"","url":"https://api.github.com/users/Danappelxx","html_url":"https://github.com/Danappelxx","followers_url":"https://api.github.com/users/Danappelxx/followers","following_url":"https://api.github.com/users/Danappelxx/following{/other_user}","gists_url":"https://api.github.com/users/Danappelxx/gists{/gist_id}","starred_url":"https://api.github.com/users/Danappelxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Danappelxx/subscriptions","organizations_url":"https://api.github.com/users/Danappelxx/orgs","repos_url":"https://api.github.com/users/Danappelxx/repos","events_url":"https://api.github.com/users/Danappelxx/events{/privacy}","received_events_url":"https://api.github.com/users/Danappelxx/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T21:06:24Z","updated_at":"2016-10-11T21:06:24Z","body":"Just noticed the PR you submitted - awesome! Could you submit it to this repository on the `websocket` branch? That's [how we do our development](https://github.com/Zewo/Zewo/blob/master/Docs/WORKFLOW.md)."}}
{"actor":{"display_login":"Danappelxx"}}