{"action":"created","comment":{"url":"https://api.github.com/repos/apache/curator/pulls/comments/51448587","id":51448587,"diff_hunk":"@@ -126,12 +126,7 @@ public Stat getStat()\n      */\n     public byte[] getData()\n     {\n-        return data.get();\n-    }\n-\n-    void clearData()\n-    {\n-        data.set(null);\n+        return data;","path":"curator-recipes/src/main/java/org/apache/curator/framework/recipes/cache/ChildData.java","position":48,"original_position":48,"commit_id":"b3e3fcc4848beaa148fc3a5b437e4b19b6e7f325","original_commit_id":"b3e3fcc4848beaa148fc3a5b437e4b19b6e7f325","user":{"login":"Randgalt","id":264818,"avatar_url":"https://avatars.githubusercontent.com/u/264818?v=3","gravatar_id":"","url":"https://api.github.com/users/Randgalt","html_url":"https://github.com/Randgalt","followers_url":"https://api.github.com/users/Randgalt/followers","following_url":"https://api.github.com/users/Randgalt/following{/other_user}","gists_url":"https://api.github.com/users/Randgalt/gists{/gist_id}","starred_url":"https://api.github.com/users/Randgalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Randgalt/subscriptions","organizations_url":"https://api.github.com/users/Randgalt/orgs","repos_url":"https://api.github.com/users/Randgalt/repos","events_url":"https://api.github.com/users/Randgalt/events{/privacy}","received_events_url":"https://api.github.com/users/Randgalt/received_events","type":"User","site_admin":false},"body":"clearData() needs to remain. PathChildrenCache uses it to release memory. The data is needed temporarily and is cleared afterwards.","created_at":"2016-02-01T17:18:57Z","updated_at":"2016-02-01T17:18:57Z","html_url":"https://github.com/apache/curator/pull/128#discussion_r51448587","pull_request_url":"https://api.github.com/repos/apache/curator/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/apache/curator/pulls/comments/51448587"},"html":{"href":"https://github.com/apache/curator/pull/128#discussion_r51448587"},"pull_request":{"href":"https://api.github.com/repos/apache/curator/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/apache/curator/pulls/128","id":57729284,"html_url":"https://github.com/apache/curator/pull/128","diff_url":"https://github.com/apache/curator/pull/128.diff","patch_url":"https://github.com/apache/curator/pull/128.patch","issue_url":"https://api.github.com/repos/apache/curator/issues/128","number":128,"state":"open","locked":false,"title":"CURATOR-294: Optimize TreeCache, fix possible concurrency issue","user":{"login":"dragonsinth","id":1919660,"avatar_url":"https://avatars.githubusercontent.com/u/1919660?v=3","gravatar_id":"","url":"https://api.github.com/users/dragonsinth","html_url":"https://github.com/dragonsinth","followers_url":"https://api.github.com/users/dragonsinth/followers","following_url":"https://api.github.com/users/dragonsinth/following{/other_user}","gists_url":"https://api.github.com/users/dragonsinth/gists{/gist_id}","starred_url":"https://api.github.com/users/dragonsinth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragonsinth/subscriptions","organizations_url":"https://api.github.com/users/dragonsinth/orgs","repos_url":"https://api.github.com/users/dragonsinth/repos","events_url":"https://api.github.com/users/dragonsinth/events{/privacy}","received_events_url":"https://api.github.com/users/dragonsinth/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-01-30T03:49:15Z","updated_at":"2016-02-01T17:18:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64c37f4d15d17818b0a6d0d468a5ac029052a5fb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/curator/pulls/128/commits","review_comments_url":"https://api.github.com/repos/apache/curator/pulls/128/comments","review_comment_url":"https://api.github.com/repos/apache/curator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/curator/issues/128/comments","statuses_url":"https://api.github.com/repos/apache/curator/statuses/b3e3fcc4848beaa148fc3a5b437e4b19b6e7f325","head":{"label":"dragonsinth:CURATOR-294","ref":"CURATOR-294","sha":"b3e3fcc4848beaa148fc3a5b437e4b19b6e7f325","user":{"login":"dragonsinth","id":1919660,"avatar_url":"https://avatars.githubusercontent.com/u/1919660?v=3","gravatar_id":"","url":"https://api.github.com/users/dragonsinth","html_url":"https://github.com/dragonsinth","followers_url":"https://api.github.com/users/dragonsinth/followers","following_url":"https://api.github.com/users/dragonsinth/following{/other_user}","gists_url":"https://api.github.com/users/dragonsinth/gists{/gist_id}","starred_url":"https://api.github.com/users/dragonsinth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragonsinth/subscriptions","organizations_url":"https://api.github.com/users/dragonsinth/orgs","repos_url":"https://api.github.com/users/dragonsinth/repos","events_url":"https://api.github.com/users/dragonsinth/events{/privacy}","received_events_url":"https://api.github.com/users/dragonsinth/received_events","type":"User","site_admin":false},"repo":{"id":21664408,"name":"curator","full_name":"dragonsinth/curator","owner":{"login":"dragonsinth","id":1919660,"avatar_url":"https://avatars.githubusercontent.com/u/1919660?v=3","gravatar_id":"","url":"https://api.github.com/users/dragonsinth","html_url":"https://github.com/dragonsinth","followers_url":"https://api.github.com/users/dragonsinth/followers","following_url":"https://api.github.com/users/dragonsinth/following{/other_user}","gists_url":"https://api.github.com/users/dragonsinth/gists{/gist_id}","starred_url":"https://api.github.com/users/dragonsinth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragonsinth/subscriptions","organizations_url":"https://api.github.com/users/dragonsinth/orgs","repos_url":"https://api.github.com/users/dragonsinth/repos","events_url":"https://api.github.com/users/dragonsinth/events{/privacy}","received_events_url":"https://api.github.com/users/dragonsinth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dragonsinth/curator","description":"Mirror of Apache Curator","fork":true,"url":"https://api.github.com/repos/dragonsinth/curator","forks_url":"https://api.github.com/repos/dragonsinth/curator/forks","keys_url":"https://api.github.com/repos/dragonsinth/curator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dragonsinth/curator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dragonsinth/curator/teams","hooks_url":"https://api.github.com/repos/dragonsinth/curator/hooks","issue_events_url":"https://api.github.com/repos/dragonsinth/curator/issues/events{/number}","events_url":"https://api.github.com/repos/dragonsinth/curator/events","assignees_url":"https://api.github.com/repos/dragonsinth/curator/assignees{/user}","branches_url":"https://api.github.com/repos/dragonsinth/curator/branches{/branch}","tags_url":"https://api.github.com/repos/dragonsinth/curator/tags","blobs_url":"https://api.github.com/repos/dragonsinth/curator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dragonsinth/curator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dragonsinth/curator/git/refs{/sha}","trees_url":"https://api.github.com/repos/dragonsinth/curator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dragonsinth/curator/statuses/{sha}","languages_url":"https://api.github.com/repos/dragonsinth/curator/languages","stargazers_url":"https://api.github.com/repos/dragonsinth/curator/stargazers","contributors_url":"https://api.github.com/repos/dragonsinth/curator/contributors","subscribers_url":"https://api.github.com/repos/dragonsinth/curator/subscribers","subscription_url":"https://api.github.com/repos/dragonsinth/curator/subscription","commits_url":"https://api.github.com/repos/dragonsinth/curator/commits{/sha}","git_commits_url":"https://api.github.com/repos/dragonsinth/curator/git/commits{/sha}","comments_url":"https://api.github.com/repos/dragonsinth/curator/comments{/number}","issue_comment_url":"https://api.github.com/repos/dragonsinth/curator/issues/comments{/number}","contents_url":"https://api.github.com/repos/dragonsinth/curator/contents/{+path}","compare_url":"https://api.github.com/repos/dragonsinth/curator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dragonsinth/curator/merges","archive_url":"https://api.github.com/repos/dragonsinth/curator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dragonsinth/curator/downloads","issues_url":"https://api.github.com/repos/dragonsinth/curator/issues{/number}","pulls_url":"https://api.github.com/repos/dragonsinth/curator/pulls{/number}","milestones_url":"https://api.github.com/repos/dragonsinth/curator/milestones{/number}","notifications_url":"https://api.github.com/repos/dragonsinth/curator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dragonsinth/curator/labels{/name}","releases_url":"https://api.github.com/repos/dragonsinth/curator/releases{/id}","deployments_url":"https://api.github.com/repos/dragonsinth/curator/deployments","created_at":"2014-07-09T18:47:16Z","updated_at":"2016-01-18T20:36:02Z","pushed_at":"2016-01-30T03:55:08Z","git_url":"git://github.com/dragonsinth/curator.git","ssh_url":"git@github.com:dragonsinth/curator.git","clone_url":"https://github.com/dragonsinth/curator.git","svn_url":"https://github.com/dragonsinth/curator","homepage":null,"size":6093,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"649e0ba24b4123829e1267c755318a288f6f9e0c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17359057,"name":"curator","full_name":"apache/curator","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/curator","description":"Mirror of Apache Curator","fork":false,"url":"https://api.github.com/repos/apache/curator","forks_url":"https://api.github.com/repos/apache/curator/forks","keys_url":"https://api.github.com/repos/apache/curator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/curator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/curator/teams","hooks_url":"https://api.github.com/repos/apache/curator/hooks","issue_events_url":"https://api.github.com/repos/apache/curator/issues/events{/number}","events_url":"https://api.github.com/repos/apache/curator/events","assignees_url":"https://api.github.com/repos/apache/curator/assignees{/user}","branches_url":"https://api.github.com/repos/apache/curator/branches{/branch}","tags_url":"https://api.github.com/repos/apache/curator/tags","blobs_url":"https://api.github.com/repos/apache/curator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/curator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/curator/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/curator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/curator/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/curator/languages","stargazers_url":"https://api.github.com/repos/apache/curator/stargazers","contributors_url":"https://api.github.com/repos/apache/curator/contributors","subscribers_url":"https://api.github.com/repos/apache/curator/subscribers","subscription_url":"https://api.github.com/repos/apache/curator/subscription","commits_url":"https://api.github.com/repos/apache/curator/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/curator/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/curator/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/curator/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/curator/contents/{+path}","compare_url":"https://api.github.com/repos/apache/curator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/curator/merges","archive_url":"https://api.github.com/repos/apache/curator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/curator/downloads","issues_url":"https://api.github.com/repos/apache/curator/issues{/number}","pulls_url":"https://api.github.com/repos/apache/curator/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/curator/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/curator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/curator/labels{/name}","releases_url":"https://api.github.com/repos/apache/curator/releases{/id}","deployments_url":"https://api.github.com/repos/apache/curator/deployments","created_at":"2014-03-03T08:00:07Z","updated_at":"2016-02-01T07:35:48Z","pushed_at":"2016-01-30T03:55:09Z","git_url":"git://github.com/apache/curator.git","ssh_url":"git@github.com:apache/curator.git","clone_url":"https://github.com/apache/curator.git","svn_url":"https://github.com/apache/curator","homepage":null,"size":9105,"stargazers_count":301,"watchers_count":301,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":189,"mirror_url":"git://git.apache.org/curator.git","open_issues_count":18,"forks":189,"open_issues":18,"watchers":301,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/curator/pulls/128"},"html":{"href":"https://github.com/apache/curator/pull/128"},"issue":{"href":"https://api.github.com/repos/apache/curator/issues/128"},"comments":{"href":"https://api.github.com/repos/apache/curator/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/curator/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/curator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/curator/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/apache/curator/statuses/b3e3fcc4848beaa148fc3a5b437e4b19b6e7f325"}}}}