{"action":"created","issue":{"url":"https://api.github.com/repos/openstax/react-components/issues/88","repository_url":"https://api.github.com/repos/openstax/react-components","labels_url":"https://api.github.com/repos/openstax/react-components/issues/88/labels{/name}","comments_url":"https://api.github.com/repos/openstax/react-components/issues/88/comments","events_url":"https://api.github.com/repos/openstax/react-components/issues/88/events","html_url":"https://github.com/openstax/react-components/pull/88","id":163473816,"number":88,"title":"Switch from components to using SVG images","user":{"login":"nathanstitt","id":79566,"avatar_url":"https://avatars.githubusercontent.com/u/79566?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanstitt","html_url":"https://github.com/nathanstitt","followers_url":"https://api.github.com/users/nathanstitt/followers","following_url":"https://api.github.com/users/nathanstitt/following{/other_user}","gists_url":"https://api.github.com/users/nathanstitt/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanstitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanstitt/subscriptions","organizations_url":"https://api.github.com/users/nathanstitt/orgs","repos_url":"https://api.github.com/users/nathanstitt/repos","events_url":"https://api.github.com/users/nathanstitt/events{/privacy}","received_events_url":"https://api.github.com/users/nathanstitt/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openstax/react-components/labels/needs%20review","name":"needs review","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-01T21:04:41Z","updated_at":"2016-07-05T17:07:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openstax/react-components/pulls/88","html_url":"https://github.com/openstax/react-components/pull/88","diff_url":"https://github.com/openstax/react-components/pull/88.diff","patch_url":"https://github.com/openstax/react-components/pull/88.patch"},"body":"AKA what @philschatz suggested we do from the beginning \r\n\r\nOtherwise when React renders the HTML before and after the placeholder component, sometimes it's not valid HTML, leading to invariant errors.\r\n\r\nNo visible UI changes, but here's a screenshot \r\n![screen shot 2016-07-01 at 4 04 17 pm](https://cloud.githubusercontent.com/assets/79566/16534461/81773500-3fa5-11e6-9774-9daf6d5b2724.png)\r\n"},"comment":{"url":"https://api.github.com/repos/openstax/react-components/issues/comments/230540062","html_url":"https://github.com/openstax/react-components/pull/88#issuecomment-230540062","issue_url":"https://api.github.com/repos/openstax/react-components/issues/88","id":230540062,"user":{"login":"nathanstitt","id":79566,"avatar_url":"https://avatars.githubusercontent.com/u/79566?v=3","gravatar_id":"","url":"https://api.github.com/users/nathanstitt","html_url":"https://github.com/nathanstitt","followers_url":"https://api.github.com/users/nathanstitt/followers","following_url":"https://api.github.com/users/nathanstitt/following{/other_user}","gists_url":"https://api.github.com/users/nathanstitt/gists{/gist_id}","starred_url":"https://api.github.com/users/nathanstitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathanstitt/subscriptions","organizations_url":"https://api.github.com/users/nathanstitt/orgs","repos_url":"https://api.github.com/users/nathanstitt/repos","events_url":"https://api.github.com/users/nathanstitt/events{/privacy}","received_events_url":"https://api.github.com/users/nathanstitt/received_events","type":"User","site_admin":false},"created_at":"2016-07-05T17:07:45Z","updated_at":"2016-07-05T17:07:45Z","body":"Yes, the image path could be a var, but not a global one.  The issue is that `less` needs to find the assets for a `url` call in a relative location from the source file.  So I set a var `images-path` to `'../../../images`, it would work, but only for files that are at the same nesting level.\r\n\r\nI went ahead and set a scoped var with it though - it'll still save us one duplication ."}}
{"actor":{"display_login":"nathanstitt"}}