{"action":"created","comment":{"url":"https://api.github.com/repos/nylas/sync-engine/pulls/comments/73729307","id":73729307,"diff_hunk":"@@ -107,11 +110,160 @@\n     'W. Europe Standard Time': 'Europe/Berlin',\n     'West Asia Standard Time': 'Asia/Tashkent',\n     'West Pacific Standard Time': 'Pacific/Port_Moresby',\n-    'Yakutsk Standard Time': 'Asia/Yakutsk',\n+    'Yakutsk Standard Time': 'Asia/Yakutsk'\n }\n \n+# Also add the friendly timezone names\n+\n+utc_friendly_timezones = {","path":"inbox/events/timezones.py","position":null,"original_position":29,"commit_id":"6aed17727183e7930936975a4b16d2892da56d0f","original_commit_id":"99562e4df527bf40d50b9621491485cb474704d9","user":{"login":"mhahnenberg","id":105052,"avatar_url":"https://avatars.githubusercontent.com/u/105052?v=3","gravatar_id":"","url":"https://api.github.com/users/mhahnenberg","html_url":"https://github.com/mhahnenberg","followers_url":"https://api.github.com/users/mhahnenberg/followers","following_url":"https://api.github.com/users/mhahnenberg/following{/other_user}","gists_url":"https://api.github.com/users/mhahnenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/mhahnenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhahnenberg/subscriptions","organizations_url":"https://api.github.com/users/mhahnenberg/orgs","repos_url":"https://api.github.com/users/mhahnenberg/repos","events_url":"https://api.github.com/users/mhahnenberg/events{/privacy}","received_events_url":"https://api.github.com/users/mhahnenberg/received_events","type":"User","site_admin":false},"body":"Not sure I agree with this, e.g. see `datetime.utcnow()`","created_at":"2016-08-05T17:29:36Z","updated_at":"2016-08-05T17:29:36Z","html_url":"https://github.com/nylas/sync-engine/pull/353#discussion_r73729307","pull_request_url":"https://api.github.com/repos/nylas/sync-engine/pulls/353","_links":{"self":{"href":"https://api.github.com/repos/nylas/sync-engine/pulls/comments/73729307"},"html":{"href":"https://github.com/nylas/sync-engine/pull/353#discussion_r73729307"},"pull_request":{"href":"https://api.github.com/repos/nylas/sync-engine/pulls/353"}}},"pull_request":{"url":"https://api.github.com/repos/nylas/sync-engine/pulls/353","id":80163957,"html_url":"https://github.com/nylas/sync-engine/pull/353","diff_url":"https://github.com/nylas/sync-engine/pull/353.diff","patch_url":"https://github.com/nylas/sync-engine/pull/353.patch","issue_url":"https://api.github.com/repos/nylas/sync-engine/issues/353","number":353,"state":"open","locked":false,"title":"Add 3 missing tzs and add support for friendly timezone names","user":{"login":"bengotow","id":1037212,"avatar_url":"https://avatars.githubusercontent.com/u/1037212?v=3","gravatar_id":"","url":"https://api.github.com/users/bengotow","html_url":"https://github.com/bengotow","followers_url":"https://api.github.com/users/bengotow/followers","following_url":"https://api.github.com/users/bengotow/following{/other_user}","gists_url":"https://api.github.com/users/bengotow/gists{/gist_id}","starred_url":"https://api.github.com/users/bengotow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bengotow/subscriptions","organizations_url":"https://api.github.com/users/bengotow/orgs","repos_url":"https://api.github.com/users/bengotow/repos","events_url":"https://api.github.com/users/bengotow/events{/privacy}","received_events_url":"https://api.github.com/users/bengotow/received_events","type":"User","site_admin":false},"body":"Calendar sync encountered many exceptions for my bengotow@gmail.com Google calendar because it couldn’t find timezones for some of my events. This diff adds a bunch of TZs I discovered in my mail that were missing from https://github.com/regebro/tzlocal.\r\n\r\nIt also adds support for many more timezone strings, drawn from:\r\nhttps://msdn.microsoft.com/en-us/library/ms912391(v=winembedded.11).aspx\r\nhttp://micc.mitel.com/kb/Attachment442.aspx\r\n\r\nThis fixes my calendar.","created_at":"2016-08-04T23:01:18Z","updated_at":"2016-08-05T17:29:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0c92b8c3e7a9df0667e4b3016b07df01f6803d5","assignee":{"login":"khamidou","id":44081,"avatar_url":"https://avatars.githubusercontent.com/u/44081?v=3","gravatar_id":"","url":"https://api.github.com/users/khamidou","html_url":"https://github.com/khamidou","followers_url":"https://api.github.com/users/khamidou/followers","following_url":"https://api.github.com/users/khamidou/following{/other_user}","gists_url":"https://api.github.com/users/khamidou/gists{/gist_id}","starred_url":"https://api.github.com/users/khamidou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khamidou/subscriptions","organizations_url":"https://api.github.com/users/khamidou/orgs","repos_url":"https://api.github.com/users/khamidou/repos","events_url":"https://api.github.com/users/khamidou/events{/privacy}","received_events_url":"https://api.github.com/users/khamidou/received_events","type":"User","site_admin":false},"assignees":[{"login":"khamidou","id":44081,"avatar_url":"https://avatars.githubusercontent.com/u/44081?v=3","gravatar_id":"","url":"https://api.github.com/users/khamidou","html_url":"https://github.com/khamidou","followers_url":"https://api.github.com/users/khamidou/followers","following_url":"https://api.github.com/users/khamidou/following{/other_user}","gists_url":"https://api.github.com/users/khamidou/gists{/gist_id}","starred_url":"https://api.github.com/users/khamidou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khamidou/subscriptions","organizations_url":"https://api.github.com/users/khamidou/orgs","repos_url":"https://api.github.com/users/khamidou/repos","events_url":"https://api.github.com/users/khamidou/events{/privacy}","received_events_url":"https://api.github.com/users/khamidou/received_events","type":"User","site_admin":false},{"login":"spang","id":48515,"avatar_url":"https://avatars.githubusercontent.com/u/48515?v=3","gravatar_id":"","url":"https://api.github.com/users/spang","html_url":"https://github.com/spang","followers_url":"https://api.github.com/users/spang/followers","following_url":"https://api.github.com/users/spang/following{/other_user}","gists_url":"https://api.github.com/users/spang/gists{/gist_id}","starred_url":"https://api.github.com/users/spang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spang/subscriptions","organizations_url":"https://api.github.com/users/spang/orgs","repos_url":"https://api.github.com/users/spang/repos","events_url":"https://api.github.com/users/spang/events{/privacy}","received_events_url":"https://api.github.com/users/spang/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nylas/sync-engine/pulls/353/commits","review_comments_url":"https://api.github.com/repos/nylas/sync-engine/pulls/353/comments","review_comment_url":"https://api.github.com/repos/nylas/sync-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nylas/sync-engine/issues/353/comments","statuses_url":"https://api.github.com/repos/nylas/sync-engine/statuses/6aed17727183e7930936975a4b16d2892da56d0f","head":{"label":"nylas:bengotow/add-missing-tzs","ref":"bengotow/add-missing-tzs","sha":"6aed17727183e7930936975a4b16d2892da56d0f","user":{"login":"nylas","id":4219865,"avatar_url":"https://avatars.githubusercontent.com/u/4219865?v=3","gravatar_id":"","url":"https://api.github.com/users/nylas","html_url":"https://github.com/nylas","followers_url":"https://api.github.com/users/nylas/followers","following_url":"https://api.github.com/users/nylas/following{/other_user}","gists_url":"https://api.github.com/users/nylas/gists{/gist_id}","starred_url":"https://api.github.com/users/nylas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nylas/subscriptions","organizations_url":"https://api.github.com/users/nylas/orgs","repos_url":"https://api.github.com/users/nylas/repos","events_url":"https://api.github.com/users/nylas/events{/privacy}","received_events_url":"https://api.github.com/users/nylas/received_events","type":"Organization","site_admin":false},"repo":{"id":15943682,"name":"sync-engine","full_name":"nylas/sync-engine","owner":{"login":"nylas","id":4219865,"avatar_url":"https://avatars.githubusercontent.com/u/4219865?v=3","gravatar_id":"","url":"https://api.github.com/users/nylas","html_url":"https://github.com/nylas","followers_url":"https://api.github.com/users/nylas/followers","following_url":"https://api.github.com/users/nylas/following{/other_user}","gists_url":"https://api.github.com/users/nylas/gists{/gist_id}","starred_url":"https://api.github.com/users/nylas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nylas/subscriptions","organizations_url":"https://api.github.com/users/nylas/orgs","repos_url":"https://api.github.com/users/nylas/repos","events_url":"https://api.github.com/users/nylas/events{/privacy}","received_events_url":"https://api.github.com/users/nylas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nylas/sync-engine","description":":incoming_envelope: IMAP/SMTP sync system with modern APIs","fork":false,"url":"https://api.github.com/repos/nylas/sync-engine","forks_url":"https://api.github.com/repos/nylas/sync-engine/forks","keys_url":"https://api.github.com/repos/nylas/sync-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nylas/sync-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nylas/sync-engine/teams","hooks_url":"https://api.github.com/repos/nylas/sync-engine/hooks","issue_events_url":"https://api.github.com/repos/nylas/sync-engine/issues/events{/number}","events_url":"https://api.github.com/repos/nylas/sync-engine/events","assignees_url":"https://api.github.com/repos/nylas/sync-engine/assignees{/user}","branches_url":"https://api.github.com/repos/nylas/sync-engine/branches{/branch}","tags_url":"https://api.github.com/repos/nylas/sync-engine/tags","blobs_url":"https://api.github.com/repos/nylas/sync-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nylas/sync-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nylas/sync-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/nylas/sync-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nylas/sync-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/nylas/sync-engine/languages","stargazers_url":"https://api.github.com/repos/nylas/sync-engine/stargazers","contributors_url":"https://api.github.com/repos/nylas/sync-engine/contributors","subscribers_url":"https://api.github.com/repos/nylas/sync-engine/subscribers","subscription_url":"https://api.github.com/repos/nylas/sync-engine/subscription","commits_url":"https://api.github.com/repos/nylas/sync-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/nylas/sync-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/nylas/sync-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/nylas/sync-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/nylas/sync-engine/contents/{+path}","compare_url":"https://api.github.com/repos/nylas/sync-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nylas/sync-engine/merges","archive_url":"https://api.github.com/repos/nylas/sync-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nylas/sync-engine/downloads","issues_url":"https://api.github.com/repos/nylas/sync-engine/issues{/number}","pulls_url":"https://api.github.com/repos/nylas/sync-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/nylas/sync-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/nylas/sync-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nylas/sync-engine/labels{/name}","releases_url":"https://api.github.com/repos/nylas/sync-engine/releases{/id}","deployments_url":"https://api.github.com/repos/nylas/sync-engine/deployments","created_at":"2014-01-15T18:18:17Z","updated_at":"2016-08-05T15:45:49Z","pushed_at":"2016-08-05T17:15:12Z","git_url":"git://github.com/nylas/sync-engine.git","ssh_url":"git@github.com:nylas/sync-engine.git","clone_url":"https://github.com/nylas/sync-engine.git","svn_url":"https://github.com/nylas/sync-engine","homepage":"https://nylas.com/docs/platform","size":24438,"stargazers_count":3054,"watchers_count":3054,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":291,"mirror_url":null,"open_issues_count":70,"forks":291,"open_issues":70,"watchers":3054,"default_branch":"master"}},"base":{"label":"nylas:master","ref":"master","sha":"66cf5ca096c8b327e6facf6bb71b59efe633c1d0","user":{"login":"nylas","id":4219865,"avatar_url":"https://avatars.githubusercontent.com/u/4219865?v=3","gravatar_id":"","url":"https://api.github.com/users/nylas","html_url":"https://github.com/nylas","followers_url":"https://api.github.com/users/nylas/followers","following_url":"https://api.github.com/users/nylas/following{/other_user}","gists_url":"https://api.github.com/users/nylas/gists{/gist_id}","starred_url":"https://api.github.com/users/nylas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nylas/subscriptions","organizations_url":"https://api.github.com/users/nylas/orgs","repos_url":"https://api.github.com/users/nylas/repos","events_url":"https://api.github.com/users/nylas/events{/privacy}","received_events_url":"https://api.github.com/users/nylas/received_events","type":"Organization","site_admin":false},"repo":{"id":15943682,"name":"sync-engine","full_name":"nylas/sync-engine","owner":{"login":"nylas","id":4219865,"avatar_url":"https://avatars.githubusercontent.com/u/4219865?v=3","gravatar_id":"","url":"https://api.github.com/users/nylas","html_url":"https://github.com/nylas","followers_url":"https://api.github.com/users/nylas/followers","following_url":"https://api.github.com/users/nylas/following{/other_user}","gists_url":"https://api.github.com/users/nylas/gists{/gist_id}","starred_url":"https://api.github.com/users/nylas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nylas/subscriptions","organizations_url":"https://api.github.com/users/nylas/orgs","repos_url":"https://api.github.com/users/nylas/repos","events_url":"https://api.github.com/users/nylas/events{/privacy}","received_events_url":"https://api.github.com/users/nylas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nylas/sync-engine","description":":incoming_envelope: IMAP/SMTP sync system with modern APIs","fork":false,"url":"https://api.github.com/repos/nylas/sync-engine","forks_url":"https://api.github.com/repos/nylas/sync-engine/forks","keys_url":"https://api.github.com/repos/nylas/sync-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nylas/sync-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nylas/sync-engine/teams","hooks_url":"https://api.github.com/repos/nylas/sync-engine/hooks","issue_events_url":"https://api.github.com/repos/nylas/sync-engine/issues/events{/number}","events_url":"https://api.github.com/repos/nylas/sync-engine/events","assignees_url":"https://api.github.com/repos/nylas/sync-engine/assignees{/user}","branches_url":"https://api.github.com/repos/nylas/sync-engine/branches{/branch}","tags_url":"https://api.github.com/repos/nylas/sync-engine/tags","blobs_url":"https://api.github.com/repos/nylas/sync-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nylas/sync-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nylas/sync-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/nylas/sync-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nylas/sync-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/nylas/sync-engine/languages","stargazers_url":"https://api.github.com/repos/nylas/sync-engine/stargazers","contributors_url":"https://api.github.com/repos/nylas/sync-engine/contributors","subscribers_url":"https://api.github.com/repos/nylas/sync-engine/subscribers","subscription_url":"https://api.github.com/repos/nylas/sync-engine/subscription","commits_url":"https://api.github.com/repos/nylas/sync-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/nylas/sync-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/nylas/sync-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/nylas/sync-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/nylas/sync-engine/contents/{+path}","compare_url":"https://api.github.com/repos/nylas/sync-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nylas/sync-engine/merges","archive_url":"https://api.github.com/repos/nylas/sync-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nylas/sync-engine/downloads","issues_url":"https://api.github.com/repos/nylas/sync-engine/issues{/number}","pulls_url":"https://api.github.com/repos/nylas/sync-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/nylas/sync-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/nylas/sync-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nylas/sync-engine/labels{/name}","releases_url":"https://api.github.com/repos/nylas/sync-engine/releases{/id}","deployments_url":"https://api.github.com/repos/nylas/sync-engine/deployments","created_at":"2014-01-15T18:18:17Z","updated_at":"2016-08-05T15:45:49Z","pushed_at":"2016-08-05T17:15:12Z","git_url":"git://github.com/nylas/sync-engine.git","ssh_url":"git@github.com:nylas/sync-engine.git","clone_url":"https://github.com/nylas/sync-engine.git","svn_url":"https://github.com/nylas/sync-engine","homepage":"https://nylas.com/docs/platform","size":24438,"stargazers_count":3054,"watchers_count":3054,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":291,"mirror_url":null,"open_issues_count":70,"forks":291,"open_issues":70,"watchers":3054,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nylas/sync-engine/pulls/353"},"html":{"href":"https://github.com/nylas/sync-engine/pull/353"},"issue":{"href":"https://api.github.com/repos/nylas/sync-engine/issues/353"},"comments":{"href":"https://api.github.com/repos/nylas/sync-engine/issues/353/comments"},"review_comments":{"href":"https://api.github.com/repos/nylas/sync-engine/pulls/353/comments"},"review_comment":{"href":"https://api.github.com/repos/nylas/sync-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nylas/sync-engine/pulls/353/commits"},"statuses":{"href":"https://api.github.com/repos/nylas/sync-engine/statuses/6aed17727183e7930936975a4b16d2892da56d0f"}}}}
{"actor":{"display_login":"mhahnenberg"}}