{"action":"created","issue":{"url":"https://api.github.com/repos/zfsonlinux/zfs/issues/4523","repository_url":"https://api.github.com/repos/zfsonlinux/zfs","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/4523/labels{/name}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/4523/comments","events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/4523/events","html_url":"https://github.com/zfsonlinux/zfs/pull/4523","id":148195344,"number":4523,"title":"Create unique partition labels","user":{"login":"behlendorf","id":148917,"avatar_url":"https://avatars.githubusercontent.com/u/148917?v=3","gravatar_id":"","url":"https://api.github.com/users/behlendorf","html_url":"https://github.com/behlendorf","followers_url":"https://api.github.com/users/behlendorf/followers","following_url":"https://api.github.com/users/behlendorf/following{/other_user}","gists_url":"https://api.github.com/users/behlendorf/gists{/gist_id}","starred_url":"https://api.github.com/users/behlendorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behlendorf/subscriptions","organizations_url":"https://api.github.com/users/behlendorf/orgs","repos_url":"https://api.github.com/users/behlendorf/repos","events_url":"https://api.github.com/users/behlendorf/events{/privacy}","received_events_url":"https://api.github.com/users/behlendorf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2016-04-13T22:00:06Z","updated_at":"2016-04-20T01:02:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/4523","html_url":"https://github.com/zfsonlinux/zfs/pull/4523","diff_url":"https://github.com/zfsonlinux/zfs/pull/4523.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/4523.patch"},"body":"When partitioning a device a name may be specified for each partion.\r\nInternally zfs doesn't use this partition name for anything so it\r\nhas always just been set to \"zfs\".\r\n\r\nHowever this isn't optimal because udev will create symlinks using\r\nthis name in /dev/disk/by-partlabel/.  If the name isn't unique\r\nthen all the links cannot be created.\r\n\r\nTherefore a random 64-bit value has been added to the partition\r\nlabel, i.e \"zfs-1234567890abcdef\".  Additional information could\r\nbe encoded here since partitions may be reused that could result\r\nin confusion and was decided against.\r\n\r\nSigned-off-by: Brian Behlendorf <behlendorf1@llnl.gov>\r\nIssue #4517"},"comment":{"url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments/212190028","html_url":"https://github.com/zfsonlinux/zfs/pull/4523#issuecomment-212190028","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/4523","id":212190028,"user":{"login":"rlaager","id":113383,"avatar_url":"https://avatars.githubusercontent.com/u/113383?v=3","gravatar_id":"","url":"https://api.github.com/users/rlaager","html_url":"https://github.com/rlaager","followers_url":"https://api.github.com/users/rlaager/followers","following_url":"https://api.github.com/users/rlaager/following{/other_user}","gists_url":"https://api.github.com/users/rlaager/gists{/gist_id}","starred_url":"https://api.github.com/users/rlaager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlaager/subscriptions","organizations_url":"https://api.github.com/users/rlaager/orgs","repos_url":"https://api.github.com/users/rlaager/repos","events_url":"https://api.github.com/users/rlaager/events{/privacy}","received_events_url":"https://api.github.com/users/rlaager/received_events","type":"User","site_admin":false},"created_at":"2016-04-20T01:02:26Z","updated_at":"2016-04-20T01:02:26Z","body":"@behlendorf I don't know how much review I can add, except that I'm still unclear on why it's necessary to name the ZFS partitions at all. If it's not necessary, simply not setting a name is much simpler (both in terms of less code and for the system administrator) than setting these randomized names."}}