{"action":"closed","number":269,"pull_request":{"url":"https://api.github.com/repos/cc65/cc65/pulls/269","id":60745654,"html_url":"https://github.com/cc65/cc65/pull/269","diff_url":"https://github.com/cc65/cc65/pull/269.diff","patch_url":"https://github.com/cc65/cc65/pull/269.patch","issue_url":"https://api.github.com/repos/cc65/cc65/issues/269","number":269,"state":"closed","locked":false,"title":"New \".feature\" to use brackets instead of parens for 6502 indirect addressing.","user":{"login":"jbrandwood","id":7716990,"avatar_url":"https://avatars.githubusercontent.com/u/7716990?v=3","gravatar_id":"","url":"https://api.github.com/users/jbrandwood","html_url":"https://github.com/jbrandwood","followers_url":"https://api.github.com/users/jbrandwood/followers","following_url":"https://api.github.com/users/jbrandwood/following{/other_user}","gists_url":"https://api.github.com/users/jbrandwood/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrandwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrandwood/subscriptions","organizations_url":"https://api.github.com/users/jbrandwood/orgs","repos_url":"https://api.github.com/users/jbrandwood/repos","events_url":"https://api.github.com/users/jbrandwood/events{/privacy}","received_events_url":"https://api.github.com/users/jbrandwood/received_events","type":"User","site_admin":false},"body":"Things to note ...\r\n\r\n1) It's actually a pretty small change, but it seems bigger because I'm moving the code that checks for the 65816's \"far\" addressing mode to below the check for the 6502 indirect addressing mode. I've also added a comment to the \"far\" check to indicate that it isn't executed when the BracketAsIndirect option is activated.\r\n\r\n2) It could all be done a tiny bit more efficiently with static variables, but that didn't seem to be as easy-to-read.\r\n","created_at":"2016-02-25T20:56:39Z","updated_at":"2016-03-03T08:07:21Z","closed_at":"2016-03-03T08:07:21Z","merged_at":"2016-03-03T08:07:21Z","merge_commit_sha":"83ae14d53575775f1ce3d1aab79e6dcbb37f0d96","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cc65/cc65/pulls/269/commits","review_comments_url":"https://api.github.com/repos/cc65/cc65/pulls/269/comments","review_comment_url":"https://api.github.com/repos/cc65/cc65/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cc65/cc65/issues/269/comments","statuses_url":"https://api.github.com/repos/cc65/cc65/statuses/ef153364eab92e2124035e5555b8c5cfbfa6e5b4","head":{"label":"jbrandwood:squarebracket","ref":"squarebracket","sha":"ef153364eab92e2124035e5555b8c5cfbfa6e5b4","user":{"login":"jbrandwood","id":7716990,"avatar_url":"https://avatars.githubusercontent.com/u/7716990?v=3","gravatar_id":"","url":"https://api.github.com/users/jbrandwood","html_url":"https://github.com/jbrandwood","followers_url":"https://api.github.com/users/jbrandwood/followers","following_url":"https://api.github.com/users/jbrandwood/following{/other_user}","gists_url":"https://api.github.com/users/jbrandwood/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrandwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrandwood/subscriptions","organizations_url":"https://api.github.com/users/jbrandwood/orgs","repos_url":"https://api.github.com/users/jbrandwood/repos","events_url":"https://api.github.com/users/jbrandwood/events{/privacy}","received_events_url":"https://api.github.com/users/jbrandwood/received_events","type":"User","site_admin":false},"repo":{"id":31447221,"name":"cc65","full_name":"jbrandwood/cc65","owner":{"login":"jbrandwood","id":7716990,"avatar_url":"https://avatars.githubusercontent.com/u/7716990?v=3","gravatar_id":"","url":"https://api.github.com/users/jbrandwood","html_url":"https://github.com/jbrandwood","followers_url":"https://api.github.com/users/jbrandwood/followers","following_url":"https://api.github.com/users/jbrandwood/following{/other_user}","gists_url":"https://api.github.com/users/jbrandwood/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrandwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrandwood/subscriptions","organizations_url":"https://api.github.com/users/jbrandwood/orgs","repos_url":"https://api.github.com/users/jbrandwood/repos","events_url":"https://api.github.com/users/jbrandwood/events{/privacy}","received_events_url":"https://api.github.com/users/jbrandwood/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbrandwood/cc65","description":"cc65 - a freeware C compiler for 6502 based systems -","fork":true,"url":"https://api.github.com/repos/jbrandwood/cc65","forks_url":"https://api.github.com/repos/jbrandwood/cc65/forks","keys_url":"https://api.github.com/repos/jbrandwood/cc65/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbrandwood/cc65/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbrandwood/cc65/teams","hooks_url":"https://api.github.com/repos/jbrandwood/cc65/hooks","issue_events_url":"https://api.github.com/repos/jbrandwood/cc65/issues/events{/number}","events_url":"https://api.github.com/repos/jbrandwood/cc65/events","assignees_url":"https://api.github.com/repos/jbrandwood/cc65/assignees{/user}","branches_url":"https://api.github.com/repos/jbrandwood/cc65/branches{/branch}","tags_url":"https://api.github.com/repos/jbrandwood/cc65/tags","blobs_url":"https://api.github.com/repos/jbrandwood/cc65/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbrandwood/cc65/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbrandwood/cc65/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbrandwood/cc65/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbrandwood/cc65/statuses/{sha}","languages_url":"https://api.github.com/repos/jbrandwood/cc65/languages","stargazers_url":"https://api.github.com/repos/jbrandwood/cc65/stargazers","contributors_url":"https://api.github.com/repos/jbrandwood/cc65/contributors","subscribers_url":"https://api.github.com/repos/jbrandwood/cc65/subscribers","subscription_url":"https://api.github.com/repos/jbrandwood/cc65/subscription","commits_url":"https://api.github.com/repos/jbrandwood/cc65/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbrandwood/cc65/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbrandwood/cc65/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbrandwood/cc65/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbrandwood/cc65/contents/{+path}","compare_url":"https://api.github.com/repos/jbrandwood/cc65/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbrandwood/cc65/merges","archive_url":"https://api.github.com/repos/jbrandwood/cc65/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbrandwood/cc65/downloads","issues_url":"https://api.github.com/repos/jbrandwood/cc65/issues{/number}","pulls_url":"https://api.github.com/repos/jbrandwood/cc65/pulls{/number}","milestones_url":"https://api.github.com/repos/jbrandwood/cc65/milestones{/number}","notifications_url":"https://api.github.com/repos/jbrandwood/cc65/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbrandwood/cc65/labels{/name}","releases_url":"https://api.github.com/repos/jbrandwood/cc65/releases{/id}","deployments_url":"https://api.github.com/repos/jbrandwood/cc65/deployments","created_at":"2015-02-28T01:52:15Z","updated_at":"2016-02-25T18:53:16Z","pushed_at":"2016-02-26T16:14:33Z","git_url":"git://github.com/jbrandwood/cc65.git","ssh_url":"git@github.com:jbrandwood/cc65.git","clone_url":"https://github.com/jbrandwood/cc65.git","svn_url":"https://github.com/jbrandwood/cc65","homepage":"http://cc65.github.io/cc65","size":20350,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cc65:master","ref":"master","sha":"f7cdfbf5cba463c4db75cb8e3c4aebd75355df26","user":{"login":"cc65","id":6959645,"avatar_url":"https://avatars.githubusercontent.com/u/6959645?v=3","gravatar_id":"","url":"https://api.github.com/users/cc65","html_url":"https://github.com/cc65","followers_url":"https://api.github.com/users/cc65/followers","following_url":"https://api.github.com/users/cc65/following{/other_user}","gists_url":"https://api.github.com/users/cc65/gists{/gist_id}","starred_url":"https://api.github.com/users/cc65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cc65/subscriptions","organizations_url":"https://api.github.com/users/cc65/orgs","repos_url":"https://api.github.com/users/cc65/repos","events_url":"https://api.github.com/users/cc65/events{/privacy}","received_events_url":"https://api.github.com/users/cc65/received_events","type":"Organization","site_admin":false},"repo":{"id":8932489,"name":"cc65","full_name":"cc65/cc65","owner":{"login":"cc65","id":6959645,"avatar_url":"https://avatars.githubusercontent.com/u/6959645?v=3","gravatar_id":"","url":"https://api.github.com/users/cc65","html_url":"https://github.com/cc65","followers_url":"https://api.github.com/users/cc65/followers","following_url":"https://api.github.com/users/cc65/following{/other_user}","gists_url":"https://api.github.com/users/cc65/gists{/gist_id}","starred_url":"https://api.github.com/users/cc65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cc65/subscriptions","organizations_url":"https://api.github.com/users/cc65/orgs","repos_url":"https://api.github.com/users/cc65/repos","events_url":"https://api.github.com/users/cc65/events{/privacy}","received_events_url":"https://api.github.com/users/cc65/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cc65/cc65","description":"cc65 - a freeware C compiler for 6502 based systems —","fork":false,"url":"https://api.github.com/repos/cc65/cc65","forks_url":"https://api.github.com/repos/cc65/cc65/forks","keys_url":"https://api.github.com/repos/cc65/cc65/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cc65/cc65/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cc65/cc65/teams","hooks_url":"https://api.github.com/repos/cc65/cc65/hooks","issue_events_url":"https://api.github.com/repos/cc65/cc65/issues/events{/number}","events_url":"https://api.github.com/repos/cc65/cc65/events","assignees_url":"https://api.github.com/repos/cc65/cc65/assignees{/user}","branches_url":"https://api.github.com/repos/cc65/cc65/branches{/branch}","tags_url":"https://api.github.com/repos/cc65/cc65/tags","blobs_url":"https://api.github.com/repos/cc65/cc65/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cc65/cc65/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cc65/cc65/git/refs{/sha}","trees_url":"https://api.github.com/repos/cc65/cc65/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cc65/cc65/statuses/{sha}","languages_url":"https://api.github.com/repos/cc65/cc65/languages","stargazers_url":"https://api.github.com/repos/cc65/cc65/stargazers","contributors_url":"https://api.github.com/repos/cc65/cc65/contributors","subscribers_url":"https://api.github.com/repos/cc65/cc65/subscribers","subscription_url":"https://api.github.com/repos/cc65/cc65/subscription","commits_url":"https://api.github.com/repos/cc65/cc65/commits{/sha}","git_commits_url":"https://api.github.com/repos/cc65/cc65/git/commits{/sha}","comments_url":"https://api.github.com/repos/cc65/cc65/comments{/number}","issue_comment_url":"https://api.github.com/repos/cc65/cc65/issues/comments{/number}","contents_url":"https://api.github.com/repos/cc65/cc65/contents/{+path}","compare_url":"https://api.github.com/repos/cc65/cc65/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cc65/cc65/merges","archive_url":"https://api.github.com/repos/cc65/cc65/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cc65/cc65/downloads","issues_url":"https://api.github.com/repos/cc65/cc65/issues{/number}","pulls_url":"https://api.github.com/repos/cc65/cc65/pulls{/number}","milestones_url":"https://api.github.com/repos/cc65/cc65/milestones{/number}","notifications_url":"https://api.github.com/repos/cc65/cc65/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cc65/cc65/labels{/name}","releases_url":"https://api.github.com/repos/cc65/cc65/releases{/id}","deployments_url":"https://api.github.com/repos/cc65/cc65/deployments","created_at":"2013-03-21T15:56:48Z","updated_at":"2016-03-02T04:00:40Z","pushed_at":"2016-03-03T08:07:21Z","git_url":"git://github.com/cc65/cc65.git","ssh_url":"git@github.com:cc65/cc65.git","clone_url":"https://github.com/cc65/cc65.git","svn_url":"https://github.com/cc65/cc65","homepage":"http://cc65.github.io/cc65","size":396209,"stargazers_count":247,"watchers_count":247,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":66,"mirror_url":null,"open_issues_count":26,"forks":66,"open_issues":26,"watchers":247,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cc65/cc65/pulls/269"},"html":{"href":"https://github.com/cc65/cc65/pull/269"},"issue":{"href":"https://api.github.com/repos/cc65/cc65/issues/269"},"comments":{"href":"https://api.github.com/repos/cc65/cc65/issues/269/comments"},"review_comments":{"href":"https://api.github.com/repos/cc65/cc65/pulls/269/comments"},"review_comment":{"href":"https://api.github.com/repos/cc65/cc65/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cc65/cc65/pulls/269/commits"},"statuses":{"href":"https://api.github.com/repos/cc65/cc65/statuses/ef153364eab92e2124035e5555b8c5cfbfa6e5b4"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"oliverschmidt","id":2664009,"avatar_url":"https://avatars.githubusercontent.com/u/2664009?v=3","gravatar_id":"","url":"https://api.github.com/users/oliverschmidt","html_url":"https://github.com/oliverschmidt","followers_url":"https://api.github.com/users/oliverschmidt/followers","following_url":"https://api.github.com/users/oliverschmidt/following{/other_user}","gists_url":"https://api.github.com/users/oliverschmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverschmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverschmidt/subscriptions","organizations_url":"https://api.github.com/users/oliverschmidt/orgs","repos_url":"https://api.github.com/users/oliverschmidt/repos","events_url":"https://api.github.com/users/oliverschmidt/events{/privacy}","received_events_url":"https://api.github.com/users/oliverschmidt/received_events","type":"User","site_admin":false},"comments":2,"review_comments":2,"commits":2,"additions":57,"deletions":20,"changed_files":6}}