{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/62289293","id":62289293,"diff_hunk":"@@ -59,3 +59,28 @@ func TestNamespaceGenerate(t *testing.T) {\n \t\t}\n \t}\n }\n+\n+func TestNamespaceGenerateNoName(t *testing.T) {\n+\ttests := []struct {\n+\t\tparams    map[string]interface{}\n+\t\texpected  *api.Namespace\n+\t\texpectErr bool\n+\t}{\n+\t\t{\n+\t\t\tparams: map[string]interface{}{\n+\t\t\t\t\"name\": 1,\n+\t\t\t},\n+\n+\t\t\texpectErr: true,\n+\t\t},\n+\t}\n+\tgenerator := NamespaceGeneratorV1{}\n+\tfor _, test := range tests {","path":"pkg/kubectl/namespace_test.go","position":41,"original_position":20,"commit_id":"49b8c4eebf148663272cc4a3a1a9386402239e17","original_commit_id":"d76b1abd6e8a74031599c20f8ee4b81ed560f6d2","user":{"login":"rajdeepd","id":1192725,"avatar_url":"https://avatars.githubusercontent.com/u/1192725?v=3","gravatar_id":"","url":"https://api.github.com/users/rajdeepd","html_url":"https://github.com/rajdeepd","followers_url":"https://api.github.com/users/rajdeepd/followers","following_url":"https://api.github.com/users/rajdeepd/following{/other_user}","gists_url":"https://api.github.com/users/rajdeepd/gists{/gist_id}","starred_url":"https://api.github.com/users/rajdeepd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajdeepd/subscriptions","organizations_url":"https://api.github.com/users/rajdeepd/orgs","repos_url":"https://api.github.com/users/rajdeepd/repos","events_url":"https://api.github.com/users/rajdeepd/events{/privacy}","received_events_url":"https://api.github.com/users/rajdeepd/received_events","type":"User","site_admin":false},"body":"i tried and the test cases was becoming little ugly, keeping it separate might be cleaner. Added some more negative use cases","created_at":"2016-05-06T05:10:17Z","updated_at":"2016-05-06T05:10:17Z","html_url":"https://github.com/kubernetes/kubernetes/pull/25191#discussion_r62289293","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25191","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/62289293"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25191#discussion_r62289293"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25191"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25191","id":68982874,"html_url":"https://github.com/kubernetes/kubernetes/pull/25191","diff_url":"https://github.com/kubernetes/kubernetes/pull/25191.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/25191.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25191","number":25191,"state":"open","locked":false,"title":"Added negative test case for namespace","user":{"login":"rajdeepd","id":1192725,"avatar_url":"https://avatars.githubusercontent.com/u/1192725?v=3","gravatar_id":"","url":"https://api.github.com/users/rajdeepd","html_url":"https://github.com/rajdeepd","followers_url":"https://api.github.com/users/rajdeepd/followers","following_url":"https://api.github.com/users/rajdeepd/following{/other_user}","gists_url":"https://api.github.com/users/rajdeepd/gists{/gist_id}","starred_url":"https://api.github.com/users/rajdeepd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajdeepd/subscriptions","organizations_url":"https://api.github.com/users/rajdeepd/orgs","repos_url":"https://api.github.com/users/rajdeepd/repos","events_url":"https://api.github.com/users/rajdeepd/events{/privacy}","received_events_url":"https://api.github.com/users/rajdeepd/received_events","type":"User","site_admin":false},"body":"```release-note-none\r\n* Added a new negative test case for namespace\r\n```\r\n\r\n\r\n","created_at":"2016-05-05T09:15:18Z","updated_at":"2016-05-06T05:10:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e957da01962806a2016fb6f55f42d1e33e3dc71","assignee":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25191/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25191/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/25191/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/49b8c4eebf148663272cc4a3a1a9386402239e17","head":{"label":"rajdeepd:master","ref":"master","sha":"49b8c4eebf148663272cc4a3a1a9386402239e17","user":{"login":"rajdeepd","id":1192725,"avatar_url":"https://avatars.githubusercontent.com/u/1192725?v=3","gravatar_id":"","url":"https://api.github.com/users/rajdeepd","html_url":"https://github.com/rajdeepd","followers_url":"https://api.github.com/users/rajdeepd/followers","following_url":"https://api.github.com/users/rajdeepd/following{/other_user}","gists_url":"https://api.github.com/users/rajdeepd/gists{/gist_id}","starred_url":"https://api.github.com/users/rajdeepd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajdeepd/subscriptions","organizations_url":"https://api.github.com/users/rajdeepd/orgs","repos_url":"https://api.github.com/users/rajdeepd/repos","events_url":"https://api.github.com/users/rajdeepd/events{/privacy}","received_events_url":"https://api.github.com/users/rajdeepd/received_events","type":"User","site_admin":false},"repo":{"id":54713612,"name":"kubernetes","full_name":"rajdeepd/kubernetes","owner":{"login":"rajdeepd","id":1192725,"avatar_url":"https://avatars.githubusercontent.com/u/1192725?v=3","gravatar_id":"","url":"https://api.github.com/users/rajdeepd","html_url":"https://github.com/rajdeepd","followers_url":"https://api.github.com/users/rajdeepd/followers","following_url":"https://api.github.com/users/rajdeepd/following{/other_user}","gists_url":"https://api.github.com/users/rajdeepd/gists{/gist_id}","starred_url":"https://api.github.com/users/rajdeepd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajdeepd/subscriptions","organizations_url":"https://api.github.com/users/rajdeepd/orgs","repos_url":"https://api.github.com/users/rajdeepd/repos","events_url":"https://api.github.com/users/rajdeepd/events{/privacy}","received_events_url":"https://api.github.com/users/rajdeepd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rajdeepd/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/rajdeepd/kubernetes","forks_url":"https://api.github.com/repos/rajdeepd/kubernetes/forks","keys_url":"https://api.github.com/repos/rajdeepd/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rajdeepd/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rajdeepd/kubernetes/teams","hooks_url":"https://api.github.com/repos/rajdeepd/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/rajdeepd/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/rajdeepd/kubernetes/events","assignees_url":"https://api.github.com/repos/rajdeepd/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/rajdeepd/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/rajdeepd/kubernetes/tags","blobs_url":"https://api.github.com/repos/rajdeepd/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rajdeepd/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rajdeepd/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/rajdeepd/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rajdeepd/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/rajdeepd/kubernetes/languages","stargazers_url":"https://api.github.com/repos/rajdeepd/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/rajdeepd/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/rajdeepd/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/rajdeepd/kubernetes/subscription","commits_url":"https://api.github.com/repos/rajdeepd/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/rajdeepd/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/rajdeepd/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/rajdeepd/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/rajdeepd/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/rajdeepd/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rajdeepd/kubernetes/merges","archive_url":"https://api.github.com/repos/rajdeepd/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rajdeepd/kubernetes/downloads","issues_url":"https://api.github.com/repos/rajdeepd/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/rajdeepd/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/rajdeepd/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/rajdeepd/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rajdeepd/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/rajdeepd/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/rajdeepd/kubernetes/deployments","created_at":"2016-03-25T11:01:21Z","updated_at":"2016-03-25T11:01:35Z","pushed_at":"2016-05-06T05:09:14Z","git_url":"git://github.com/rajdeepd/kubernetes.git","ssh_url":"git@github.com:rajdeepd/kubernetes.git","clone_url":"https://github.com/rajdeepd/kubernetes.git","svn_url":"https://github.com/rajdeepd/kubernetes","homepage":"http://kubernetes.io","size":190284,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"4a00266f40cf8ae12c1559bdcd65d1dcc05e0780","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-05-06T04:51:29Z","pushed_at":"2016-05-06T05:09:16Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":391302,"stargazers_count":14236,"watchers_count":14236,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4256,"mirror_url":null,"open_issues_count":3608,"forks":4256,"open_issues":3608,"watchers":14236,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25191"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/25191"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25191"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/25191/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25191/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/25191/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/49b8c4eebf148663272cc4a3a1a9386402239e17"}}}}