{"action":"created","comment":{"url":"https://api.github.com/repos/trilinos/Trilinos/pulls/comments/90936703","pull_request_review_id":11450127,"id":90936703,"diff_hunk":"@@ -126,7 +128,10 @@ class GatherSolution_Epetra<panzer::Traits::Residual,TRAITS,LO,GO>\n   bool useTimeDerivativeSolutionVector_;\n   std::string globalDataKey_; // what global data does this fill?\n \n-  Teuchos::RCP<Epetra_Vector> x_;\n+  Teuchos::RCP<Epetra_Vector>                   x_;\n+  Teuchos::RCP<const Epetra_Map>                ownedMap_;\n+  Teuchos::RCP<const Thyra::VectorBase<double>> xOwned_;\n+  Teuchos::RCP<Epetra_Vector>                   xGhosted_;","path":"packages/panzer/disc-fe/src/evaluators/Panzer_GatherSolution_Epetra_decl.hpp","position":31,"original_position":31,"commit_id":"fbf83dc101722d05cd3a216437e9973b4a521a3f","original_commit_id":"fbf83dc101722d05cd3a216437e9973b4a521a3f","user":{"login":"jmgate","id":20327215,"avatar_url":"https://avatars.githubusercontent.com/u/20327215?v=3","gravatar_id":"","url":"https://api.github.com/users/jmgate","html_url":"https://github.com/jmgate","followers_url":"https://api.github.com/users/jmgate/followers","following_url":"https://api.github.com/users/jmgate/following{/other_user}","gists_url":"https://api.github.com/users/jmgate/gists{/gist_id}","starred_url":"https://api.github.com/users/jmgate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmgate/subscriptions","organizations_url":"https://api.github.com/users/jmgate/orgs","repos_url":"https://api.github.com/users/jmgate/repos","events_url":"https://api.github.com/users/jmgate/events{/privacy}","received_events_url":"https://api.github.com/users/jmgate/received_events","type":"User","site_admin":false},"body":"Instead of just `x_`, which contains all the owned and ghosted information, the new way will have `xOwned_` and `xGhosted_`, where the latter doesn't contain any duplicate information from the former.  We also need the `ownedMap_` to create an `Epetra_Vector` out of `xOwned_` when we need to.","created_at":"2016-12-05T19:25:25Z","updated_at":"2016-12-05T19:25:25Z","html_url":"https://github.com/trilinos/Trilinos/pull/902#discussion_r90936703","pull_request_url":"https://api.github.com/repos/trilinos/Trilinos/pulls/902","_links":{"self":{"href":"https://api.github.com/repos/trilinos/Trilinos/pulls/comments/90936703"},"html":{"href":"https://github.com/trilinos/Trilinos/pull/902#discussion_r90936703"},"pull_request":{"href":"https://api.github.com/repos/trilinos/Trilinos/pulls/902"}}},"pull_request":{"url":"https://api.github.com/repos/trilinos/Trilinos/pulls/902","id":96589756,"html_url":"https://github.com/trilinos/Trilinos/pull/902","diff_url":"https://github.com/trilinos/Trilinos/pull/902.diff","patch_url":"https://github.com/trilinos/Trilinos/pull/902.patch","issue_url":"https://api.github.com/repos/trilinos/Trilinos/issues/902","number":902,"state":"open","locked":false,"title":"Code Review:  Panzer Gather/Scatter","user":{"login":"jmgate","id":20327215,"avatar_url":"https://avatars.githubusercontent.com/u/20327215?v=3","gravatar_id":"","url":"https://api.github.com/users/jmgate","html_url":"https://github.com/jmgate","followers_url":"https://api.github.com/users/jmgate/followers","following_url":"https://api.github.com/users/jmgate/following{/other_user}","gists_url":"https://api.github.com/users/jmgate/gists{/gist_id}","starred_url":"https://api.github.com/users/jmgate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmgate/subscriptions","organizations_url":"https://api.github.com/users/jmgate/orgs","repos_url":"https://api.github.com/users/jmgate/repos","events_url":"https://api.github.com/users/jmgate/events{/privacy}","received_events_url":"https://api.github.com/users/jmgate/received_events","type":"User","site_admin":false},"body":"This pull request is for an intermediate code review of the ongoing @trilinos/panzer gather/scatter work with @eric-c-cyr -- it is not meant to be merged into trilinos/Trilinos/develop.","created_at":"2016-12-05T19:08:59Z","updated_at":"2016-12-05T19:25:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fba1702969126ae2503b9858f660ce95953d1397","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/trilinos/Trilinos/pulls/902/commits","review_comments_url":"https://api.github.com/repos/trilinos/Trilinos/pulls/902/comments","review_comment_url":"https://api.github.com/repos/trilinos/Trilinos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trilinos/Trilinos/issues/902/comments","statuses_url":"https://api.github.com/repos/trilinos/Trilinos/statuses/fbf83dc101722d05cd3a216437e9973b4a521a3f","head":{"label":"jmgate:panzerGatherScatter","ref":"panzerGatherScatter","sha":"fbf83dc101722d05cd3a216437e9973b4a521a3f","user":{"login":"jmgate","id":20327215,"avatar_url":"https://avatars.githubusercontent.com/u/20327215?v=3","gravatar_id":"","url":"https://api.github.com/users/jmgate","html_url":"https://github.com/jmgate","followers_url":"https://api.github.com/users/jmgate/followers","following_url":"https://api.github.com/users/jmgate/following{/other_user}","gists_url":"https://api.github.com/users/jmgate/gists{/gist_id}","starred_url":"https://api.github.com/users/jmgate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmgate/subscriptions","organizations_url":"https://api.github.com/users/jmgate/orgs","repos_url":"https://api.github.com/users/jmgate/repos","events_url":"https://api.github.com/users/jmgate/events{/privacy}","received_events_url":"https://api.github.com/users/jmgate/received_events","type":"User","site_admin":false},"repo":{"id":73102051,"name":"Trilinos","full_name":"jmgate/Trilinos","owner":{"login":"jmgate","id":20327215,"avatar_url":"https://avatars.githubusercontent.com/u/20327215?v=3","gravatar_id":"","url":"https://api.github.com/users/jmgate","html_url":"https://github.com/jmgate","followers_url":"https://api.github.com/users/jmgate/followers","following_url":"https://api.github.com/users/jmgate/following{/other_user}","gists_url":"https://api.github.com/users/jmgate/gists{/gist_id}","starred_url":"https://api.github.com/users/jmgate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmgate/subscriptions","organizations_url":"https://api.github.com/users/jmgate/orgs","repos_url":"https://api.github.com/users/jmgate/repos","events_url":"https://api.github.com/users/jmgate/events{/privacy}","received_events_url":"https://api.github.com/users/jmgate/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmgate/Trilinos","description":"Primary repository for the Trilinos Project","fork":true,"url":"https://api.github.com/repos/jmgate/Trilinos","forks_url":"https://api.github.com/repos/jmgate/Trilinos/forks","keys_url":"https://api.github.com/repos/jmgate/Trilinos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmgate/Trilinos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmgate/Trilinos/teams","hooks_url":"https://api.github.com/repos/jmgate/Trilinos/hooks","issue_events_url":"https://api.github.com/repos/jmgate/Trilinos/issues/events{/number}","events_url":"https://api.github.com/repos/jmgate/Trilinos/events","assignees_url":"https://api.github.com/repos/jmgate/Trilinos/assignees{/user}","branches_url":"https://api.github.com/repos/jmgate/Trilinos/branches{/branch}","tags_url":"https://api.github.com/repos/jmgate/Trilinos/tags","blobs_url":"https://api.github.com/repos/jmgate/Trilinos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmgate/Trilinos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmgate/Trilinos/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmgate/Trilinos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmgate/Trilinos/statuses/{sha}","languages_url":"https://api.github.com/repos/jmgate/Trilinos/languages","stargazers_url":"https://api.github.com/repos/jmgate/Trilinos/stargazers","contributors_url":"https://api.github.com/repos/jmgate/Trilinos/contributors","subscribers_url":"https://api.github.com/repos/jmgate/Trilinos/subscribers","subscription_url":"https://api.github.com/repos/jmgate/Trilinos/subscription","commits_url":"https://api.github.com/repos/jmgate/Trilinos/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmgate/Trilinos/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmgate/Trilinos/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmgate/Trilinos/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmgate/Trilinos/contents/{+path}","compare_url":"https://api.github.com/repos/jmgate/Trilinos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmgate/Trilinos/merges","archive_url":"https://api.github.com/repos/jmgate/Trilinos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmgate/Trilinos/downloads","issues_url":"https://api.github.com/repos/jmgate/Trilinos/issues{/number}","pulls_url":"https://api.github.com/repos/jmgate/Trilinos/pulls{/number}","milestones_url":"https://api.github.com/repos/jmgate/Trilinos/milestones{/number}","notifications_url":"https://api.github.com/repos/jmgate/Trilinos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmgate/Trilinos/labels{/name}","releases_url":"https://api.github.com/repos/jmgate/Trilinos/releases{/id}","deployments_url":"https://api.github.com/repos/jmgate/Trilinos/deployments","created_at":"2016-11-07T17:09:27Z","updated_at":"2016-11-07T17:12:06Z","pushed_at":"2016-12-05T15:53:22Z","git_url":"git://github.com/jmgate/Trilinos.git","ssh_url":"git@github.com:jmgate/Trilinos.git","clone_url":"https://github.com/jmgate/Trilinos.git","svn_url":"https://github.com/jmgate/Trilinos","homepage":"https://trilinos.org/","size":392626,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"trilinos:develop","ref":"develop","sha":"5296923c34b085e069ea353ae9086b7deeb78c7c","user":{"login":"trilinos","id":8566498,"avatar_url":"https://avatars.githubusercontent.com/u/8566498?v=3","gravatar_id":"","url":"https://api.github.com/users/trilinos","html_url":"https://github.com/trilinos","followers_url":"https://api.github.com/users/trilinos/followers","following_url":"https://api.github.com/users/trilinos/following{/other_user}","gists_url":"https://api.github.com/users/trilinos/gists{/gist_id}","starred_url":"https://api.github.com/users/trilinos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trilinos/subscriptions","organizations_url":"https://api.github.com/users/trilinos/orgs","repos_url":"https://api.github.com/users/trilinos/repos","events_url":"https://api.github.com/users/trilinos/events{/privacy}","received_events_url":"https://api.github.com/users/trilinos/received_events","type":"Organization","site_admin":false},"repo":{"id":46297649,"name":"Trilinos","full_name":"trilinos/Trilinos","owner":{"login":"trilinos","id":8566498,"avatar_url":"https://avatars.githubusercontent.com/u/8566498?v=3","gravatar_id":"","url":"https://api.github.com/users/trilinos","html_url":"https://github.com/trilinos","followers_url":"https://api.github.com/users/trilinos/followers","following_url":"https://api.github.com/users/trilinos/following{/other_user}","gists_url":"https://api.github.com/users/trilinos/gists{/gist_id}","starred_url":"https://api.github.com/users/trilinos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trilinos/subscriptions","organizations_url":"https://api.github.com/users/trilinos/orgs","repos_url":"https://api.github.com/users/trilinos/repos","events_url":"https://api.github.com/users/trilinos/events{/privacy}","received_events_url":"https://api.github.com/users/trilinos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trilinos/Trilinos","description":"Primary repository for the Trilinos Project","fork":false,"url":"https://api.github.com/repos/trilinos/Trilinos","forks_url":"https://api.github.com/repos/trilinos/Trilinos/forks","keys_url":"https://api.github.com/repos/trilinos/Trilinos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trilinos/Trilinos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trilinos/Trilinos/teams","hooks_url":"https://api.github.com/repos/trilinos/Trilinos/hooks","issue_events_url":"https://api.github.com/repos/trilinos/Trilinos/issues/events{/number}","events_url":"https://api.github.com/repos/trilinos/Trilinos/events","assignees_url":"https://api.github.com/repos/trilinos/Trilinos/assignees{/user}","branches_url":"https://api.github.com/repos/trilinos/Trilinos/branches{/branch}","tags_url":"https://api.github.com/repos/trilinos/Trilinos/tags","blobs_url":"https://api.github.com/repos/trilinos/Trilinos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trilinos/Trilinos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trilinos/Trilinos/git/refs{/sha}","trees_url":"https://api.github.com/repos/trilinos/Trilinos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trilinos/Trilinos/statuses/{sha}","languages_url":"https://api.github.com/repos/trilinos/Trilinos/languages","stargazers_url":"https://api.github.com/repos/trilinos/Trilinos/stargazers","contributors_url":"https://api.github.com/repos/trilinos/Trilinos/contributors","subscribers_url":"https://api.github.com/repos/trilinos/Trilinos/subscribers","subscription_url":"https://api.github.com/repos/trilinos/Trilinos/subscription","commits_url":"https://api.github.com/repos/trilinos/Trilinos/commits{/sha}","git_commits_url":"https://api.github.com/repos/trilinos/Trilinos/git/commits{/sha}","comments_url":"https://api.github.com/repos/trilinos/Trilinos/comments{/number}","issue_comment_url":"https://api.github.com/repos/trilinos/Trilinos/issues/comments{/number}","contents_url":"https://api.github.com/repos/trilinos/Trilinos/contents/{+path}","compare_url":"https://api.github.com/repos/trilinos/Trilinos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trilinos/Trilinos/merges","archive_url":"https://api.github.com/repos/trilinos/Trilinos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trilinos/Trilinos/downloads","issues_url":"https://api.github.com/repos/trilinos/Trilinos/issues{/number}","pulls_url":"https://api.github.com/repos/trilinos/Trilinos/pulls{/number}","milestones_url":"https://api.github.com/repos/trilinos/Trilinos/milestones{/number}","notifications_url":"https://api.github.com/repos/trilinos/Trilinos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trilinos/Trilinos/labels{/name}","releases_url":"https://api.github.com/repos/trilinos/Trilinos/releases{/id}","deployments_url":"https://api.github.com/repos/trilinos/Trilinos/deployments","created_at":"2015-11-16T19:39:16Z","updated_at":"2016-12-02T18:07:31Z","pushed_at":"2016-12-05T19:09:00Z","git_url":"git://github.com/trilinos/Trilinos.git","ssh_url":"git@github.com:trilinos/Trilinos.git","clone_url":"https://github.com/trilinos/Trilinos.git","svn_url":"https://github.com/trilinos/Trilinos","homepage":"https://trilinos.org/","size":422870,"stargazers_count":124,"watchers_count":124,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":451,"forks":78,"open_issues":451,"watchers":124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trilinos/Trilinos/pulls/902"},"html":{"href":"https://github.com/trilinos/Trilinos/pull/902"},"issue":{"href":"https://api.github.com/repos/trilinos/Trilinos/issues/902"},"comments":{"href":"https://api.github.com/repos/trilinos/Trilinos/issues/902/comments"},"review_comments":{"href":"https://api.github.com/repos/trilinos/Trilinos/pulls/902/comments"},"review_comment":{"href":"https://api.github.com/repos/trilinos/Trilinos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trilinos/Trilinos/pulls/902/commits"},"statuses":{"href":"https://api.github.com/repos/trilinos/Trilinos/statuses/fbf83dc101722d05cd3a216437e9973b4a521a3f"}}}}
{"actor":{"display_login":"jmgate"}}