{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/78428173","id":78428173,"diff_hunk":"@@ -551,7 +551,7 @@ CONFIG_DWORD_INFO_EX(INTERNAL_JitSplitFunctionSize, W(\"JitSplitFunctionSize\"), 0\n RETAIL_CONFIG_DWORD_INFO_EX(EXTERNAL_JitRegisterFP, W(\"JitRegisterFP\"), 3, \"Control FP enregistration\", CLRConfig::REGUTIL_default)\n RETAIL_CONFIG_DWORD_INFO(INTERNAL_JitELTHookEnabled, W(\"JitELTHookEnabled\"), 0, \"On ARM, setting this will emit Enter/Leave/TailCall callbacks\")\n CONFIG_DWORD_INFO_EX(INTERNAL_JitComponentUnitTests, W(\"JitComponentUnitTests\"), 0, \"Run JIT component unit tests\", CLRConfig::REGUTIL_default)\n-CONFIG_DWORD_INFO_EX(INTERNAL_JitMemStats, W(\"JitMemStats\"), 0, \"Display JIT memory usage statistics\", CLRConfig::REGUTIL_default)\n+RETAIL_CONFIG_DWORD_INFO_EX(INTERNAL_JitMemStats, W(\"JitMemStats\"), 0, \"Display JIT memory usage statistics\", CLRConfig::REGUTIL_default)","path":"src/inc/clrconfigvalues.h","position":5,"original_position":5,"commit_id":"3fb46290e6eac2ad3c25cf16c7572248f4e8533d","original_commit_id":"3fb46290e6eac2ad3c25cf16c7572248f4e8533d","user":{"login":"CarolEidt","id":2973870,"avatar_url":"https://avatars.githubusercontent.com/u/2973870?v=3","gravatar_id":"","url":"https://api.github.com/users/CarolEidt","html_url":"https://github.com/CarolEidt","followers_url":"https://api.github.com/users/CarolEidt/followers","following_url":"https://api.github.com/users/CarolEidt/following{/other_user}","gists_url":"https://api.github.com/users/CarolEidt/gists{/gist_id}","starred_url":"https://api.github.com/users/CarolEidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarolEidt/subscriptions","organizations_url":"https://api.github.com/users/CarolEidt/orgs","repos_url":"https://api.github.com/users/CarolEidt/repos","events_url":"https://api.github.com/users/CarolEidt/events{/privacy}","received_events_url":"https://api.github.com/users/CarolEidt/received_events","type":"User","site_admin":false},"body":"This will make this environment variable always available in product versions - is that the intent? I think it is reasonable, but seems like a decision that should be made with some deliberation.","created_at":"2016-09-12T18:30:44Z","updated_at":"2016-09-12T18:30:44Z","html_url":"https://github.com/dotnet/coreclr/pull/7119#discussion_r78428173","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/7119","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/78428173"},"html":{"href":"https://github.com/dotnet/coreclr/pull/7119#discussion_r78428173"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7119"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/7119","id":84579232,"html_url":"https://github.com/dotnet/coreclr/pull/7119","diff_url":"https://github.com/dotnet/coreclr/pull/7119.diff","patch_url":"https://github.com/dotnet/coreclr/pull/7119.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/7119","number":7119,"state":"open","locked":false,"title":"Clean up COMPlus_JitMemStats / MEASURE_MEM_ALLOC","user":{"login":"pkukol","id":148817,"avatar_url":"https://avatars.githubusercontent.com/u/148817?v=3","gravatar_id":"","url":"https://api.github.com/users/pkukol","html_url":"https://github.com/pkukol","followers_url":"https://api.github.com/users/pkukol/followers","following_url":"https://api.github.com/users/pkukol/following{/other_user}","gists_url":"https://api.github.com/users/pkukol/gists{/gist_id}","starred_url":"https://api.github.com/users/pkukol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkukol/subscriptions","organizations_url":"https://api.github.com/users/pkukol/orgs","repos_url":"https://api.github.com/users/pkukol/repos","events_url":"https://api.github.com/users/pkukol/events{/privacy}","received_events_url":"https://api.github.com/users/pkukol/received_events","type":"User","site_admin":false},"body":"All of this is off by default, BTW - @dotnet/jit-contrib PTAL.","created_at":"2016-09-09T01:07:20Z","updated_at":"2016-09-12T18:30:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"793749035643b87e685d79595a19e1f1ab482a51","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/7119/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/7119/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/7119/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/3fb46290e6eac2ad3c25cf16c7572248f4e8533d","head":{"label":"pkukol:cleanup_JitMemStats","ref":"cleanup_JitMemStats","sha":"3fb46290e6eac2ad3c25cf16c7572248f4e8533d","user":{"login":"pkukol","id":148817,"avatar_url":"https://avatars.githubusercontent.com/u/148817?v=3","gravatar_id":"","url":"https://api.github.com/users/pkukol","html_url":"https://github.com/pkukol","followers_url":"https://api.github.com/users/pkukol/followers","following_url":"https://api.github.com/users/pkukol/following{/other_user}","gists_url":"https://api.github.com/users/pkukol/gists{/gist_id}","starred_url":"https://api.github.com/users/pkukol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkukol/subscriptions","organizations_url":"https://api.github.com/users/pkukol/orgs","repos_url":"https://api.github.com/users/pkukol/repos","events_url":"https://api.github.com/users/pkukol/events{/privacy}","received_events_url":"https://api.github.com/users/pkukol/received_events","type":"User","site_admin":false},"repo":{"id":67154822,"name":"coreclr","full_name":"pkukol/coreclr","owner":{"login":"pkukol","id":148817,"avatar_url":"https://avatars.githubusercontent.com/u/148817?v=3","gravatar_id":"","url":"https://api.github.com/users/pkukol","html_url":"https://github.com/pkukol","followers_url":"https://api.github.com/users/pkukol/followers","following_url":"https://api.github.com/users/pkukol/following{/other_user}","gists_url":"https://api.github.com/users/pkukol/gists{/gist_id}","starred_url":"https://api.github.com/users/pkukol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkukol/subscriptions","organizations_url":"https://api.github.com/users/pkukol/orgs","repos_url":"https://api.github.com/users/pkukol/repos","events_url":"https://api.github.com/users/pkukol/events{/privacy}","received_events_url":"https://api.github.com/users/pkukol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pkukol/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/pkukol/coreclr","forks_url":"https://api.github.com/repos/pkukol/coreclr/forks","keys_url":"https://api.github.com/repos/pkukol/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkukol/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkukol/coreclr/teams","hooks_url":"https://api.github.com/repos/pkukol/coreclr/hooks","issue_events_url":"https://api.github.com/repos/pkukol/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/pkukol/coreclr/events","assignees_url":"https://api.github.com/repos/pkukol/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/pkukol/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/pkukol/coreclr/tags","blobs_url":"https://api.github.com/repos/pkukol/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkukol/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkukol/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkukol/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkukol/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/pkukol/coreclr/languages","stargazers_url":"https://api.github.com/repos/pkukol/coreclr/stargazers","contributors_url":"https://api.github.com/repos/pkukol/coreclr/contributors","subscribers_url":"https://api.github.com/repos/pkukol/coreclr/subscribers","subscription_url":"https://api.github.com/repos/pkukol/coreclr/subscription","commits_url":"https://api.github.com/repos/pkukol/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkukol/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkukol/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkukol/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkukol/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/pkukol/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkukol/coreclr/merges","archive_url":"https://api.github.com/repos/pkukol/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkukol/coreclr/downloads","issues_url":"https://api.github.com/repos/pkukol/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/pkukol/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/pkukol/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/pkukol/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkukol/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/pkukol/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/pkukol/coreclr/deployments","created_at":"2016-09-01T18:07:57Z","updated_at":"2016-09-01T18:10:20Z","pushed_at":"2016-09-10T00:27:30Z","git_url":"git://github.com/pkukol/coreclr.git","ssh_url":"git@github.com:pkukol/coreclr.git","clone_url":"https://github.com/pkukol/coreclr.git","svn_url":"https://github.com/pkukol/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":106232,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"193c5816dff234aa7504826eb559360607748563","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-09-12T18:16:51Z","pushed_at":"2016-09-12T18:15:48Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":119208,"stargazers_count":6893,"watchers_count":6893,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1643,"mirror_url":null,"open_issues_count":968,"forks":1643,"open_issues":968,"watchers":6893,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7119"},"html":{"href":"https://github.com/dotnet/coreclr/pull/7119"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/7119"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/7119/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7119/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7119/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/3fb46290e6eac2ad3c25cf16c7572248f4e8533d"}}}}
{"actor":{"display_login":"CarolEidt"}}