{"action":"created","issue":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/952","labels_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/952/labels{/name}","comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/952/comments","events_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/952/events","html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/952","id":127375535,"number":952,"title":"Added AES support to crypto module.","user":{"login":"jmattsson","id":869607,"avatar_url":"https://avatars.githubusercontent.com/u/869607?v=3","gravatar_id":"","url":"https://api.github.com/users/jmattsson","html_url":"https://github.com/jmattsson","followers_url":"https://api.github.com/users/jmattsson/followers","following_url":"https://api.github.com/users/jmattsson/following{/other_user}","gists_url":"https://api.github.com/users/jmattsson/gists{/gist_id}","starred_url":"https://api.github.com/users/jmattsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmattsson/subscriptions","organizations_url":"https://api.github.com/users/jmattsson/orgs","repos_url":"https://api.github.com/users/jmattsson/repos","events_url":"https://api.github.com/users/jmattsson/events{/privacy}","received_events_url":"https://api.github.com/users/jmattsson/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-19T06:25:18Z","updated_at":"2016-01-19T16:52:46Z","closed_at":"2016-01-19T15:28:11Z","pull_request":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/pulls/952","html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/952","diff_url":"https://github.com/nodemcu/nodemcu-firmware/pull/952.diff","patch_url":"https://github.com/nodemcu/nodemcu-firmware/pull/952.patch"},"body":"Merely a wrapper around the (undocumented) internal SDK AES functions.\r\n\r\nPossibly sufficient to satisfy the enhancement request in #540. Both ECB and CBC modes supported."},"comment":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/comments/172915367","html_url":"https://github.com/nodemcu/nodemcu-firmware/pull/952#issuecomment-172915367","issue_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/952","id":172915367,"user":{"login":"robertfoss","id":523260,"avatar_url":"https://avatars.githubusercontent.com/u/523260?v=3","gravatar_id":"","url":"https://api.github.com/users/robertfoss","html_url":"https://github.com/robertfoss","followers_url":"https://api.github.com/users/robertfoss/followers","following_url":"https://api.github.com/users/robertfoss/following{/other_user}","gists_url":"https://api.github.com/users/robertfoss/gists{/gist_id}","starred_url":"https://api.github.com/users/robertfoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertfoss/subscriptions","organizations_url":"https://api.github.com/users/robertfoss/orgs","repos_url":"https://api.github.com/users/robertfoss/repos","events_url":"https://api.github.com/users/robertfoss/events{/privacy}","received_events_url":"https://api.github.com/users/robertfoss/received_events","type":"User","site_admin":false},"created_at":"2016-01-19T16:52:46Z","updated_at":"2016-01-19T16:52:46Z","body":"ECB should _never_ be used for anything but schoolbook examples as it does not actually provide any worthwhile security for data sizes larger than one block (16bytes).\r\n\r\nCBC is also weak and very prone to security issues (like the recent string of SSL issues). But unlike ECB it offers some sort of meaningful security.\r\n\r\nI would prefer ECB to be excluded from this patch."}}