{"action":"created","issue":{"url":"https://api.github.com/repos/opencomputeproject/SAI/issues/171","repository_url":"https://api.github.com/repos/opencomputeproject/SAI","labels_url":"https://api.github.com/repos/opencomputeproject/SAI/issues/171/labels{/name}","comments_url":"https://api.github.com/repos/opencomputeproject/SAI/issues/171/comments","events_url":"https://api.github.com/repos/opencomputeproject/SAI/issues/171/events","html_url":"https://github.com/opencomputeproject/SAI/pull/171","id":171116429,"number":171,"title":"ACL model changes for SAI 1.0.0","user":{"login":"zubinshah","id":775788,"avatar_url":"https://avatars.githubusercontent.com/u/775788?v=3","gravatar_id":"","url":"https://api.github.com/users/zubinshah","html_url":"https://github.com/zubinshah","followers_url":"https://api.github.com/users/zubinshah/followers","following_url":"https://api.github.com/users/zubinshah/following{/other_user}","gists_url":"https://api.github.com/users/zubinshah/gists{/gist_id}","starred_url":"https://api.github.com/users/zubinshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zubinshah/subscriptions","organizations_url":"https://api.github.com/users/zubinshah/orgs","repos_url":"https://api.github.com/users/zubinshah/repos","events_url":"https://api.github.com/users/zubinshah/events{/privacy}","received_events_url":"https://api.github.com/users/zubinshah/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-08-15T06:39:39Z","updated_at":"2016-10-13T17:38:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opencomputeproject/SAI/pulls/171","html_url":"https://github.com/opencomputeproject/SAI/pull/171","diff_url":"https://github.com/opencomputeproject/SAI/pull/171.diff","patch_url":"https://github.com/opencomputeproject/SAI/pull/171.patch"},"body":"Created this preliminary version of ACL model based on the community discussions and changes discussed during the 8/8-8/9 workshop. \r\n\r\nPrimary changes includes binding model. Some more changes and examples to follow. "},"comment":{"url":"https://api.github.com/repos/opencomputeproject/SAI/issues/comments/253583663","html_url":"https://github.com/opencomputeproject/SAI/pull/171#issuecomment-253583663","issue_url":"https://api.github.com/repos/opencomputeproject/SAI/issues/171","id":253583663,"user":{"login":"zubinshah","id":775788,"avatar_url":"https://avatars.githubusercontent.com/u/775788?v=3","gravatar_id":"","url":"https://api.github.com/users/zubinshah","html_url":"https://github.com/zubinshah","followers_url":"https://api.github.com/users/zubinshah/followers","following_url":"https://api.github.com/users/zubinshah/following{/other_user}","gists_url":"https://api.github.com/users/zubinshah/gists{/gist_id}","starred_url":"https://api.github.com/users/zubinshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zubinshah/subscriptions","organizations_url":"https://api.github.com/users/zubinshah/orgs","repos_url":"https://api.github.com/users/zubinshah/repos","events_url":"https://api.github.com/users/zubinshah/events{/privacy}","received_events_url":"https://api.github.com/users/zubinshah/received_events","type":"User","site_admin":false},"created_at":"2016-10-13T17:38:03Z","updated_at":"2016-10-13T17:38:03Z","body":"Completely agree on the first part. “ lag binding point also creates a Lag value match|filter criteria, just like port” - But you see thats very hardware or implementation specific to your switch silicon. There are other switch silicon that may implement the same qualifiers in completely different fashion. And to let the SAI users expose to these level of details is not reasonable. Hence it is better to abstract general switch concepts - (interfaces) ports, lags, rifs, tunnels, bridge interface, etc. and handle them within SAI implementations. I will clarify those details in the specification, but i believe these abstract concepts are already part of SAI object starting from SAI 0.9.1 releases and some even before.\r\n\r\nLooking at the spec before pre-1.0.0 as i mentioned in my presentation we never had any qualifiers. For eg. creating a port qualifier was never mandatory nor expected. So from that perspective all the attributes I added inside port, lag, rif, switch, tunnel, bridge interfaces are new.\r\n\r\n\r\nWhen an ACL group or ACL table is bound to any complex (but well abstracted) SAI object — it definitely creates several physical match criteria - completely relevant for Broadcom ASIC and will be completely different in Cavium or other ASICs.\r\n\r\n\r\n"}}
{"actor":{"display_login":"zubinshah"}}