{"action":"created","comment":{"url":"https://api.github.com/repos/solettaproject/soletta/pulls/comments/59068213","id":59068213,"diff_hunk":"@@ -468,14 +468,55 @@ sol_log_domain_init_level(struct sol_log_domain *domain)\n  *\n  * @see SOL_CRI(), SOL_ERR(), SOL_WRN(), SOL_INF() and SOL_DBG().\n  */\n+#ifdef SOL_LOG_FILES\n+#ifdef SOL_LOG_FUNCTIONS\n #define SOL_LOG(level, fmt, ...) \\\n     do { \\\n         if (SOL_LOG_LEVEL_POSSIBLE(level)) { \\\n             sol_log_print(SOL_LOG_DOMAIN, level, \\\n-                __FILE__, __PRETTY_FUNCTION__, __LINE__, \\\n+                __FILE__, \\\n+                __PRETTY_FUNCTION__, \\\n+                __LINE__, \\","path":"src/lib/common/include/sol-log.h","position":13,"original_position":13,"commit_id":"92f344f978eed02f3a03e7b8501f7d07f32ae434","original_commit_id":"92f344f978eed02f3a03e7b8501f7d07f32ae434","user":{"login":"ibriano","id":3288272,"avatar_url":"https://avatars.githubusercontent.com/u/3288272?v=3","gravatar_id":"","url":"https://api.github.com/users/ibriano","html_url":"https://github.com/ibriano","followers_url":"https://api.github.com/users/ibriano/followers","following_url":"https://api.github.com/users/ibriano/following{/other_user}","gists_url":"https://api.github.com/users/ibriano/gists{/gist_id}","starred_url":"https://api.github.com/users/ibriano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibriano/subscriptions","organizations_url":"https://api.github.com/users/ibriano/orgs","repos_url":"https://api.github.com/users/ibriano/repos","events_url":"https://api.github.com/users/ibriano/events{/privacy}","received_events_url":"https://api.github.com/users/ibriano/received_events","type":"User","site_admin":false},"body":"Would changing __FILE__ and friends to something like LOG_FILE that is defined to __FILE__ or NULL accordingly work?","created_at":"2016-04-08T18:21:46Z","updated_at":"2016-04-08T18:21:46Z","html_url":"https://github.com/solettaproject/soletta/pull/1852#discussion_r59068213","pull_request_url":"https://api.github.com/repos/solettaproject/soletta/pulls/1852","_links":{"self":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/comments/59068213"},"html":{"href":"https://github.com/solettaproject/soletta/pull/1852#discussion_r59068213"},"pull_request":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/1852"}}},"pull_request":{"url":"https://api.github.com/repos/solettaproject/soletta/pulls/1852","id":65821717,"html_url":"https://github.com/solettaproject/soletta/pull/1852","diff_url":"https://github.com/solettaproject/soletta/pull/1852.diff","patch_url":"https://github.com/solettaproject/soletta/pull/1852.patch","issue_url":"https://api.github.com/repos/solettaproject/soletta/issues/1852","number":1852,"state":"open","locked":false,"title":"log: make it possible to skip getting file/function names on output.","user":{"login":"glima","id":67689,"avatar_url":"https://avatars.githubusercontent.com/u/67689?v=3","gravatar_id":"","url":"https://api.github.com/users/glima","html_url":"https://github.com/glima","followers_url":"https://api.github.com/users/glima/followers","following_url":"https://api.github.com/users/glima/following{/other_user}","gists_url":"https://api.github.com/users/glima/gists{/gist_id}","starred_url":"https://api.github.com/users/glima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glima/subscriptions","organizations_url":"https://api.github.com/users/glima/orgs","repos_url":"https://api.github.com/users/glima/repos","events_url":"https://api.github.com/users/glima/events{/privacy}","received_events_url":"https://api.github.com/users/glima/received_events","type":"User","site_admin":false},"body":"Besides logging those entries or not (which was already a run-time\r\nparamemeter), we now have the option of never including those strings to\r\nthe final binay (so even if the user asks to log those, it gets empty\r\nstrings for them). This helps save space on restricted system, while\r\nstill having log enabled, *a lot*. Without this, lots of applications\r\nwould have to be debugged with custom printfs (and Soletta general\r\nlogging turned off), what is a total PITA.\r\n\r\nSigned-off-by: Gustavo Lima Chaves <gustavo.lima.chaves@intel.com>","created_at":"2016-04-08T17:42:57Z","updated_at":"2016-04-08T18:21:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3bc13f4a1696ea4562e7bea7bb992a7dda2e470","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/solettaproject/soletta/pulls/1852/commits","review_comments_url":"https://api.github.com/repos/solettaproject/soletta/pulls/1852/comments","review_comment_url":"https://api.github.com/repos/solettaproject/soletta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solettaproject/soletta/issues/1852/comments","statuses_url":"https://api.github.com/repos/solettaproject/soletta/statuses/92f344f978eed02f3a03e7b8501f7d07f32ae434","head":{"label":"glima:log","ref":"log","sha":"92f344f978eed02f3a03e7b8501f7d07f32ae434","user":{"login":"glima","id":67689,"avatar_url":"https://avatars.githubusercontent.com/u/67689?v=3","gravatar_id":"","url":"https://api.github.com/users/glima","html_url":"https://github.com/glima","followers_url":"https://api.github.com/users/glima/followers","following_url":"https://api.github.com/users/glima/following{/other_user}","gists_url":"https://api.github.com/users/glima/gists{/gist_id}","starred_url":"https://api.github.com/users/glima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glima/subscriptions","organizations_url":"https://api.github.com/users/glima/orgs","repos_url":"https://api.github.com/users/glima/repos","events_url":"https://api.github.com/users/glima/events{/privacy}","received_events_url":"https://api.github.com/users/glima/received_events","type":"User","site_admin":false},"repo":{"id":37601201,"name":"soletta","full_name":"glima/soletta","owner":{"login":"glima","id":67689,"avatar_url":"https://avatars.githubusercontent.com/u/67689?v=3","gravatar_id":"","url":"https://api.github.com/users/glima","html_url":"https://github.com/glima","followers_url":"https://api.github.com/users/glima/followers","following_url":"https://api.github.com/users/glima/following{/other_user}","gists_url":"https://api.github.com/users/glima/gists{/gist_id}","starred_url":"https://api.github.com/users/glima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glima/subscriptions","organizations_url":"https://api.github.com/users/glima/orgs","repos_url":"https://api.github.com/users/glima/repos","events_url":"https://api.github.com/users/glima/events{/privacy}","received_events_url":"https://api.github.com/users/glima/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/glima/soletta","description":"Soletta Project is a framework for making IoT devices.","fork":true,"url":"https://api.github.com/repos/glima/soletta","forks_url":"https://api.github.com/repos/glima/soletta/forks","keys_url":"https://api.github.com/repos/glima/soletta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glima/soletta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glima/soletta/teams","hooks_url":"https://api.github.com/repos/glima/soletta/hooks","issue_events_url":"https://api.github.com/repos/glima/soletta/issues/events{/number}","events_url":"https://api.github.com/repos/glima/soletta/events","assignees_url":"https://api.github.com/repos/glima/soletta/assignees{/user}","branches_url":"https://api.github.com/repos/glima/soletta/branches{/branch}","tags_url":"https://api.github.com/repos/glima/soletta/tags","blobs_url":"https://api.github.com/repos/glima/soletta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glima/soletta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glima/soletta/git/refs{/sha}","trees_url":"https://api.github.com/repos/glima/soletta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glima/soletta/statuses/{sha}","languages_url":"https://api.github.com/repos/glima/soletta/languages","stargazers_url":"https://api.github.com/repos/glima/soletta/stargazers","contributors_url":"https://api.github.com/repos/glima/soletta/contributors","subscribers_url":"https://api.github.com/repos/glima/soletta/subscribers","subscription_url":"https://api.github.com/repos/glima/soletta/subscription","commits_url":"https://api.github.com/repos/glima/soletta/commits{/sha}","git_commits_url":"https://api.github.com/repos/glima/soletta/git/commits{/sha}","comments_url":"https://api.github.com/repos/glima/soletta/comments{/number}","issue_comment_url":"https://api.github.com/repos/glima/soletta/issues/comments{/number}","contents_url":"https://api.github.com/repos/glima/soletta/contents/{+path}","compare_url":"https://api.github.com/repos/glima/soletta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glima/soletta/merges","archive_url":"https://api.github.com/repos/glima/soletta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glima/soletta/downloads","issues_url":"https://api.github.com/repos/glima/soletta/issues{/number}","pulls_url":"https://api.github.com/repos/glima/soletta/pulls{/number}","milestones_url":"https://api.github.com/repos/glima/soletta/milestones{/number}","notifications_url":"https://api.github.com/repos/glima/soletta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glima/soletta/labels{/name}","releases_url":"https://api.github.com/repos/glima/soletta/releases{/id}","deployments_url":"https://api.github.com/repos/glima/soletta/deployments","created_at":"2015-06-17T14:49:23Z","updated_at":"2016-02-24T20:47:43Z","pushed_at":"2016-04-08T17:42:49Z","git_url":"git://github.com/glima/soletta.git","ssh_url":"git@github.com:glima/soletta.git","clone_url":"https://github.com/glima/soletta.git","svn_url":"https://github.com/glima/soletta","homepage":"","size":18202,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solettaproject:master","ref":"master","sha":"013e93c7f9112261ad9cd40762807250b39bbe28","user":{"login":"solettaproject","id":12736897,"avatar_url":"https://avatars.githubusercontent.com/u/12736897?v=3","gravatar_id":"","url":"https://api.github.com/users/solettaproject","html_url":"https://github.com/solettaproject","followers_url":"https://api.github.com/users/solettaproject/followers","following_url":"https://api.github.com/users/solettaproject/following{/other_user}","gists_url":"https://api.github.com/users/solettaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/solettaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solettaproject/subscriptions","organizations_url":"https://api.github.com/users/solettaproject/orgs","repos_url":"https://api.github.com/users/solettaproject/repos","events_url":"https://api.github.com/users/solettaproject/events{/privacy}","received_events_url":"https://api.github.com/users/solettaproject/received_events","type":"Organization","site_admin":false},"repo":{"id":37087063,"name":"soletta","full_name":"solettaproject/soletta","owner":{"login":"solettaproject","id":12736897,"avatar_url":"https://avatars.githubusercontent.com/u/12736897?v=3","gravatar_id":"","url":"https://api.github.com/users/solettaproject","html_url":"https://github.com/solettaproject","followers_url":"https://api.github.com/users/solettaproject/followers","following_url":"https://api.github.com/users/solettaproject/following{/other_user}","gists_url":"https://api.github.com/users/solettaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/solettaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solettaproject/subscriptions","organizations_url":"https://api.github.com/users/solettaproject/orgs","repos_url":"https://api.github.com/users/solettaproject/repos","events_url":"https://api.github.com/users/solettaproject/events{/privacy}","received_events_url":"https://api.github.com/users/solettaproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solettaproject/soletta","description":"Soletta Project is a framework for making IoT devices.  With Soletta Project's libraries developers can easily write software for devices that control actuators/sensors and communicate using standard technologies. It enables adding smartness even on the smallest edge devices.  ","fork":false,"url":"https://api.github.com/repos/solettaproject/soletta","forks_url":"https://api.github.com/repos/solettaproject/soletta/forks","keys_url":"https://api.github.com/repos/solettaproject/soletta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solettaproject/soletta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solettaproject/soletta/teams","hooks_url":"https://api.github.com/repos/solettaproject/soletta/hooks","issue_events_url":"https://api.github.com/repos/solettaproject/soletta/issues/events{/number}","events_url":"https://api.github.com/repos/solettaproject/soletta/events","assignees_url":"https://api.github.com/repos/solettaproject/soletta/assignees{/user}","branches_url":"https://api.github.com/repos/solettaproject/soletta/branches{/branch}","tags_url":"https://api.github.com/repos/solettaproject/soletta/tags","blobs_url":"https://api.github.com/repos/solettaproject/soletta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solettaproject/soletta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solettaproject/soletta/git/refs{/sha}","trees_url":"https://api.github.com/repos/solettaproject/soletta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solettaproject/soletta/statuses/{sha}","languages_url":"https://api.github.com/repos/solettaproject/soletta/languages","stargazers_url":"https://api.github.com/repos/solettaproject/soletta/stargazers","contributors_url":"https://api.github.com/repos/solettaproject/soletta/contributors","subscribers_url":"https://api.github.com/repos/solettaproject/soletta/subscribers","subscription_url":"https://api.github.com/repos/solettaproject/soletta/subscription","commits_url":"https://api.github.com/repos/solettaproject/soletta/commits{/sha}","git_commits_url":"https://api.github.com/repos/solettaproject/soletta/git/commits{/sha}","comments_url":"https://api.github.com/repos/solettaproject/soletta/comments{/number}","issue_comment_url":"https://api.github.com/repos/solettaproject/soletta/issues/comments{/number}","contents_url":"https://api.github.com/repos/solettaproject/soletta/contents/{+path}","compare_url":"https://api.github.com/repos/solettaproject/soletta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solettaproject/soletta/merges","archive_url":"https://api.github.com/repos/solettaproject/soletta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solettaproject/soletta/downloads","issues_url":"https://api.github.com/repos/solettaproject/soletta/issues{/number}","pulls_url":"https://api.github.com/repos/solettaproject/soletta/pulls{/number}","milestones_url":"https://api.github.com/repos/solettaproject/soletta/milestones{/number}","notifications_url":"https://api.github.com/repos/solettaproject/soletta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solettaproject/soletta/labels{/name}","releases_url":"https://api.github.com/repos/solettaproject/soletta/releases{/id}","deployments_url":"https://api.github.com/repos/solettaproject/soletta/deployments","created_at":"2015-06-08T19:13:18Z","updated_at":"2016-04-06T18:28:23Z","pushed_at":"2016-04-08T17:42:57Z","git_url":"git://github.com/solettaproject/soletta.git","ssh_url":"git@github.com:solettaproject/soletta.git","clone_url":"https://github.com/solettaproject/soletta.git","svn_url":"https://github.com/solettaproject/soletta","homepage":"http://solettaproject.org","size":25142,"stargazers_count":83,"watchers_count":83,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":195,"forks":66,"open_issues":195,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/1852"},"html":{"href":"https://github.com/solettaproject/soletta/pull/1852"},"issue":{"href":"https://api.github.com/repos/solettaproject/soletta/issues/1852"},"comments":{"href":"https://api.github.com/repos/solettaproject/soletta/issues/1852/comments"},"review_comments":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/1852/comments"},"review_comment":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solettaproject/soletta/pulls/1852/commits"},"statuses":{"href":"https://api.github.com/repos/solettaproject/soletta/statuses/92f344f978eed02f3a03e7b8501f7d07f32ae434"}}}}