{"action":"created","issue":{"url":"https://api.github.com/repos/watou/vera-ecobee/issues/27","repository_url":"https://api.github.com/repos/watou/vera-ecobee","labels_url":"https://api.github.com/repos/watou/vera-ecobee/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/watou/vera-ecobee/issues/27/comments","events_url":"https://api.github.com/repos/watou/vera-ecobee/issues/27/events","html_url":"https://github.com/watou/vera-ecobee/pull/27","id":148535807,"number":27,"title":"Exposing fanMinOnTime setting","user":{"login":"edutibau","id":5420432,"avatar_url":"https://avatars.githubusercontent.com/u/5420432?v=3","gravatar_id":"","url":"https://api.github.com/users/edutibau","html_url":"https://github.com/edutibau","followers_url":"https://api.github.com/users/edutibau/followers","following_url":"https://api.github.com/users/edutibau/following{/other_user}","gists_url":"https://api.github.com/users/edutibau/gists{/gist_id}","starred_url":"https://api.github.com/users/edutibau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edutibau/subscriptions","organizations_url":"https://api.github.com/users/edutibau/orgs","repos_url":"https://api.github.com/users/edutibau/repos","events_url":"https://api.github.com/users/edutibau/events{/privacy}","received_events_url":"https://api.github.com/users/edutibau/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/watou/vera-ecobee/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2016-04-15T02:16:48Z","updated_at":"2016-04-17T10:41:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/watou/vera-ecobee/pulls/27","html_url":"https://github.com/watou/vera-ecobee/pull/27","diff_url":"https://github.com/watou/vera-ecobee/pull/27.diff","patch_url":"https://github.com/watou/vera-ecobee/pull/27.patch"},"body":"Hello,\r\n\r\nThanks for all the work you've put into this plugin. I've been using it for a while and always wished it supported the fanMinOnTime setting. Today I finally looked at ecobee's API and saw that it was exposed and decided to get it done :)\r\n\r\nI added the action to I_Ecobee1.xml and the ability to use it in a scene in S_Ecobee1.xml.\r\n\r\nUsages:\r\n\r\n```\r\nluup.call_action(\"urn:ecobee-com:serviceId:Ecobee1\", \"SetFanMinOnTime\", {[\"MinOnTime\"] = \"{number between 0 and 60}\"}, {deviceNumber})\r\n\r\nhttp://{veraip}:3480/data_request?id=action&output_format=xml&DeviceNum={deviceNumber}&serviceId=urn:ecobee-com:serviceId:Ecobee1&action=SetFanMinOnTime&MinOnTime={number between 0 and 60}\r\n```\r\n\r\nThis is my first time modifying a vera plugin... Let me know if there are any changes I should make for you to consider adding it to the main repo."},"comment":{"url":"https://api.github.com/repos/watou/vera-ecobee/issues/comments/210997654","html_url":"https://github.com/watou/vera-ecobee/pull/27#issuecomment-210997654","issue_url":"https://api.github.com/repos/watou/vera-ecobee/issues/27","id":210997654,"user":{"login":"watou","id":3008217,"avatar_url":"https://avatars.githubusercontent.com/u/3008217?v=3","gravatar_id":"","url":"https://api.github.com/users/watou","html_url":"https://github.com/watou","followers_url":"https://api.github.com/users/watou/followers","following_url":"https://api.github.com/users/watou/following{/other_user}","gists_url":"https://api.github.com/users/watou/gists{/gist_id}","starred_url":"https://api.github.com/users/watou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watou/subscriptions","organizations_url":"https://api.github.com/users/watou/orgs","repos_url":"https://api.github.com/users/watou/repos","events_url":"https://api.github.com/users/watou/events{/privacy}","received_events_url":"https://api.github.com/users/watou/received_events","type":"User","site_admin":false},"created_at":"2016-04-17T10:41:34Z","updated_at":"2016-04-17T10:41:34Z","body":"I'm not sure that `sendEvents=\"yes\"` is compatible with `<scpd xmlns=\"urn:schemas-upnp-org:service-1-0\">`.  I've seen service XML files that use `sendEvents=\"yes\"` but don't specify the `xmlns` attribute.  It's possible that Vera doesn't mind, but I want to be conservative about things we can't verify (which, when it comes to writing Vera plugins, is a lot of things)."}}