{"action":"created","issue":{"url":"https://api.github.com/repos/deis/fluentd/issues/80","repository_url":"https://api.github.com/repos/deis/fluentd","labels_url":"https://api.github.com/repos/deis/fluentd/issues/80/labels{/name}","comments_url":"https://api.github.com/repos/deis/fluentd/issues/80/comments","events_url":"https://api.github.com/repos/deis/fluentd/issues/80/events","html_url":"https://github.com/deis/fluentd/pull/80","id":196191213,"number":80,"title":"feat(charts): Allow custom environment config for fluentd daemon. [redux]","user":{"login":"awmichel","id":228378,"avatar_url":"https://avatars.githubusercontent.com/u/228378?v=3","gravatar_id":"","url":"https://api.github.com/users/awmichel","html_url":"https://github.com/awmichel","followers_url":"https://api.github.com/users/awmichel/followers","following_url":"https://api.github.com/users/awmichel/following{/other_user}","gists_url":"https://api.github.com/users/awmichel/gists{/gist_id}","starred_url":"https://api.github.com/users/awmichel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awmichel/subscriptions","organizations_url":"https://api.github.com/users/awmichel/orgs","repos_url":"https://api.github.com/users/awmichel/repos","events_url":"https://api.github.com/users/awmichel/events{/privacy}","received_events_url":"https://api.github.com/users/awmichel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-17T02:40:09Z","updated_at":"2016-12-17T02:40:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/deis/fluentd/pulls/80","html_url":"https://github.com/deis/fluentd/pull/80","diff_url":"https://github.com/deis/fluentd/pull/80.diff","patch_url":"https://github.com/deis/fluentd/pull/80.patch"},"body":"Corrected PR for #78.\r\n\r\nSee explanation in #79.\r\n\r\nSorry for the trouble, can someone also double check the output is correct now? I tested with the following values.yml:\r\n```\r\ndaemon_environment:\r\n  DROP_FLUENTD_LOGS: true\r\n  FLUENTD_PLUGIN_1: fluent-plugin-aws-elasticsearch-service\r\n```\r\n\r\nWhich yielded the following by calling `helm install --dry-run --debug charts/fluentd --values values.yml`:\r\n```\r\nSERVER: \"192.168.64.4:32767\"\r\nCHART PATH: /Users/amichel/Development/GitHub/fluentd/charts/fluentd\r\nNAME:   gone-salamander\r\nTARGET NAMESPACE:   default\r\nCHART:  fluentd <Will be populated by the ci before publishing the chart>\r\nMANIFEST:\r\n---\r\n# Source: fluentd/templates/logger-fluentd-service-account.yaml\r\napiVersion: v1\r\nkind: ServiceAccount\r\nmetadata:\r\n  name: deis-logger-fluentd\r\n  labels:\r\n    heritage: deis\r\n\r\n---\r\n# Source: fluentd/templates/logger-fluentd-daemon.yaml\r\napiVersion: extensions/v1beta1\r\nkind: DaemonSet\r\nmetadata:\r\n  name: deis-logger-fluentd\r\n  labels:\r\n    heritage: deis\r\n  annotations:\r\n    component.deis.io/version: canary\r\nspec:\r\n  selector:\r\n    matchLabels:\r\n      app: deis-logger-fluentd\r\n      heritage: deis\r\n  template:\r\n    metadata:\r\n      name: deis-logger-fluentd\r\n      labels:\r\n        heritage: deis\r\n        app: deis-logger-fluentd\r\n    spec:\r\n      serviceAccount: deis-logger-fluentd\r\n      containers:\r\n      - name: deis-logger-fluentd\r\n        image: quay.io/deisci/fluentd:canary\r\n        imagePullPolicy: Always\r\n        env:\r\n          - name: DROP_FLUENTD_LOGS\r\n            value: true\r\n          - name: FLUENTD_PLUGIN_1\r\n            value: fluent-plugin-aws-elasticsearch-service\r\n        volumeMounts:\r\n        - name: varlog\r\n          mountPath: /var/log\r\n        - name: varlibdockercontainers\r\n          mountPath: /var/lib/docker/containers\r\n          readOnly: true\r\n      volumes:\r\n      - name: varlog\r\n        hostPath:\r\n          path: /var/log\r\n      - name: varlibdockercontainers\r\n        hostPath:\r\n          path: /var/lib/docker/containers\r\n```"},"comment":{"url":"https://api.github.com/repos/deis/fluentd/issues/comments/267737921","html_url":"https://github.com/deis/fluentd/pull/80#issuecomment-267737921","issue_url":"https://api.github.com/repos/deis/fluentd/issues/80","id":267737921,"user":{"login":"deis-bot","id":7001982,"avatar_url":"https://avatars.githubusercontent.com/u/7001982?v=3","gravatar_id":"","url":"https://api.github.com/users/deis-bot","html_url":"https://github.com/deis-bot","followers_url":"https://api.github.com/users/deis-bot/followers","following_url":"https://api.github.com/users/deis-bot/following{/other_user}","gists_url":"https://api.github.com/users/deis-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/deis-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis-bot/subscriptions","organizations_url":"https://api.github.com/users/deis-bot/orgs","repos_url":"https://api.github.com/users/deis-bot/repos","events_url":"https://api.github.com/users/deis-bot/events{/privacy}","received_events_url":"https://api.github.com/users/deis-bot/received_events","type":"User","site_admin":false},"created_at":"2016-12-17T02:40:11Z","updated_at":"2016-12-17T02:40:11Z","body":"@kmala and @rimusz are potential reviewers of this pull request based on my analysis of `git blame` information. Thanks @awmichel!"}}
{"actor":{"display_login":"deis-bot"}}