{"action":"created","issue":{"url":"https://api.github.com/repos/syncthing/syncthing-inotify/issues/123","repository_url":"https://api.github.com/repos/syncthing/syncthing-inotify","labels_url":"https://api.github.com/repos/syncthing/syncthing-inotify/issues/123/labels{/name}","comments_url":"https://api.github.com/repos/syncthing/syncthing-inotify/issues/123/comments","events_url":"https://api.github.com/repos/syncthing/syncthing-inotify/issues/123/events","html_url":"https://github.com/syncthing/syncthing-inotify/pull/123","id":166706603,"number":123,"title":"Ignore syncthing files (cleanup of earlier ignore transition)","user":{"login":"imsodin","id":15955093,"avatar_url":"https://avatars.githubusercontent.com/u/15955093?v=3","gravatar_id":"","url":"https://api.github.com/users/imsodin","html_url":"https://github.com/imsodin","followers_url":"https://api.github.com/users/imsodin/followers","following_url":"https://api.github.com/users/imsodin/following{/other_user}","gists_url":"https://api.github.com/users/imsodin/gists{/gist_id}","starred_url":"https://api.github.com/users/imsodin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imsodin/subscriptions","organizations_url":"https://api.github.com/users/imsodin/orgs","repos_url":"https://api.github.com/users/imsodin/repos","events_url":"https://api.github.com/users/imsodin/events{/privacy}","received_events_url":"https://api.github.com/users/imsodin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-07-20T23:36:51Z","updated_at":"2016-07-21T13:30:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/syncthing/syncthing-inotify/pulls/123","html_url":"https://github.com/syncthing/syncthing-inotify/pull/123","diff_url":"https://github.com/syncthing/syncthing-inotify/pull/123.diff","patch_url":"https://github.com/syncthing/syncthing-inotify/pull/123.patch"},"body":"I noticed that I left quite some things undone in PR #111. Most importantly the ignore library from syncthing does not automatically ignore files belonging to syncthing. In our earlier ignoring implementation these were ignored. Therefore I added the function `createIgnoreTest` that returns the function `ignoreTest` which can then be used to test whether files are ignored. The rest is just cleaning up unused stuff."},"comment":{"url":"https://api.github.com/repos/syncthing/syncthing-inotify/issues/comments/234253237","html_url":"https://github.com/syncthing/syncthing-inotify/pull/123#issuecomment-234253237","issue_url":"https://api.github.com/repos/syncthing/syncthing-inotify/issues/123","id":234253237,"user":{"login":"xduugu","id":1039174,"avatar_url":"https://avatars.githubusercontent.com/u/1039174?v=3","gravatar_id":"","url":"https://api.github.com/users/xduugu","html_url":"https://github.com/xduugu","followers_url":"https://api.github.com/users/xduugu/followers","following_url":"https://api.github.com/users/xduugu/following{/other_user}","gists_url":"https://api.github.com/users/xduugu/gists{/gist_id}","starred_url":"https://api.github.com/users/xduugu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xduugu/subscriptions","organizations_url":"https://api.github.com/users/xduugu/orgs","repos_url":"https://api.github.com/users/xduugu/repos","events_url":"https://api.github.com/users/xduugu/events{/privacy}","received_events_url":"https://api.github.com/users/xduugu/received_events","type":"User","site_admin":false},"created_at":"2016-07-21T13:30:18Z","updated_at":"2016-07-21T13:30:18Z","body":"Since .stfolder is an empty file which content is never read (and also never expected to change), I see no issue in ignoring it, but also little advantage.\r\n\r\nI also found two other possibilities for improvement:\r\n* `.stversions` is the complete directory name which only can exists in the folder root\r\n* The other values in ignoreParts are actually file prefixes. I think it would be better to only test if a filename starts with one of these prefixes instead of matching against the complete path. Your current code would also match files like `the.new.syncthing.release.is.great.txt`. For the temp files, you even may want to check for the `.tmp` filename suffix in addition."}}
{"actor":{"display_login":"xduugu"}}