{"action":"created","issue":{"url":"https://api.github.com/repos/lyrixx/symfony/issues/8","repository_url":"https://api.github.com/repos/lyrixx/symfony","labels_url":"https://api.github.com/repos/lyrixx/symfony/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/lyrixx/symfony/issues/8/comments","events_url":"https://api.github.com/repos/lyrixx/symfony/issues/8/events","html_url":"https://github.com/lyrixx/symfony/pull/8","id":152187673,"number":8,"title":"Workflow","user":{"login":"mikeSimonson","id":907613,"avatar_url":"https://avatars.githubusercontent.com/u/907613?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeSimonson","html_url":"https://github.com/mikeSimonson","followers_url":"https://api.github.com/users/mikeSimonson/followers","following_url":"https://api.github.com/users/mikeSimonson/following{/other_user}","gists_url":"https://api.github.com/users/mikeSimonson/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeSimonson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeSimonson/subscriptions","organizations_url":"https://api.github.com/users/mikeSimonson/orgs","repos_url":"https://api.github.com/users/mikeSimonson/repos","events_url":"https://api.github.com/users/mikeSimonson/events{/privacy}","received_events_url":"https://api.github.com/users/mikeSimonson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-05-01T08:25:01Z","updated_at":"2016-05-18T13:44:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lyrixx/symfony/pulls/8","html_url":"https://github.com/lyrixx/symfony/pull/8","diff_url":"https://github.com/lyrixx/symfony/pull/8.diff","patch_url":"https://github.com/lyrixx/symfony/pull/8.patch"},"body":"Hi,\r\n\r\nAs we discussed here is the PR transforming the Places into object of their own.\r\n\r\nI tried to improve the consistent and easy to use API for the workflow component.\r\n\r\nThis include:\r\n- creating a Place object\r\n- creating a static constructor fromNames to create an array of place from an array of place names\r\n- creating a Definition constructor\r\n- adding a method to add an array of Transition to the Definition\r\n- adding methods in marking as to be able to do everything from a Place name or with the place object\r\n- adding docblocks everywhere\r\n- adding tests for the GraphizDumper\r\n- adapting all the tests\r\n\r\nAny remarks ?\r\n\r\nRegards"},"comment":{"url":"https://api.github.com/repos/lyrixx/symfony/issues/comments/220030003","html_url":"https://github.com/lyrixx/symfony/pull/8#issuecomment-220030003","issue_url":"https://api.github.com/repos/lyrixx/symfony/issues/8","id":220030003,"user":{"login":"lyrixx","id":408368,"avatar_url":"https://avatars.githubusercontent.com/u/408368?v=3","gravatar_id":"","url":"https://api.github.com/users/lyrixx","html_url":"https://github.com/lyrixx","followers_url":"https://api.github.com/users/lyrixx/followers","following_url":"https://api.github.com/users/lyrixx/following{/other_user}","gists_url":"https://api.github.com/users/lyrixx/gists{/gist_id}","starred_url":"https://api.github.com/users/lyrixx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyrixx/subscriptions","organizations_url":"https://api.github.com/users/lyrixx/orgs","repos_url":"https://api.github.com/users/lyrixx/repos","events_url":"https://api.github.com/users/lyrixx/events{/privacy}","received_events_url":"https://api.github.com/users/lyrixx/received_events","type":"User","site_admin":false},"created_at":"2016-05-18T13:44:28Z","updated_at":"2016-05-18T13:44:28Z","body":"Thanks for your work on this PR. It's much appreciated.\r\n\r\nEven if I don't like what you did, or more accurately **why** you did it, I merge 90% of your work\r\nin my PR.\r\n\r\nI don't like it because you did that to have a better auto-completion in your IDE.\r\nI think it's wrong because to me it's a fail if you need PHPDoc to discover an API.\r\nIf you can guess what a method do / return / accept as argument just with the name and\r\nthe row signature it's a bigger win. So for me, PHPDoc are here when I fail with naming.\r\n\r\nBut, I don't like throwing work of others, that's why I merge it. But please, next time, wait a bit before working like you did ;)"}}