{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/emission/pulls/comments/80904183","pull_request_review_id":1920102,"id":80904183,"diff_hunk":"@@ -1,10 +1,11 @@\n /* @flow */\n 'use strict'\n \n-import { NativeModules, Promise } from 'react-native'\n+import { NativeModules } from 'react-native'","path":"lib/metaphysics.js","position":5,"original_position":5,"commit_id":"e93fd15f650a2d2292aa5f8822b8afa1d1ef46dd","original_commit_id":"e93fd15f650a2d2292aa5f8822b8afa1d1ef46dd","user":{"login":"orta","id":49038,"avatar_url":"https://avatars.githubusercontent.com/u/49038?v=3","gravatar_id":"","url":"https://api.github.com/users/orta","html_url":"https://github.com/orta","followers_url":"https://api.github.com/users/orta/followers","following_url":"https://api.github.com/users/orta/following{/other_user}","gists_url":"https://api.github.com/users/orta/gists{/gist_id}","starred_url":"https://api.github.com/users/orta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orta/subscriptions","organizations_url":"https://api.github.com/users/orta/orgs","repos_url":"https://api.github.com/users/orta/repos","events_url":"https://api.github.com/users/orta/events{/privacy}","received_events_url":"https://api.github.com/users/orta/received_events","type":"User","site_admin":false},"body":"this use of `Promise`. is consistent with the native ES6 one, and so there's no need to import RNs one","created_at":"2016-09-28T12:33:30Z","updated_at":"2016-09-28T12:34:08Z","html_url":"https://github.com/artsy/emission/pull/324#discussion_r80904183","pull_request_url":"https://api.github.com/repos/artsy/emission/pulls/324","_links":{"self":{"href":"https://api.github.com/repos/artsy/emission/pulls/comments/80904183"},"html":{"href":"https://github.com/artsy/emission/pull/324#discussion_r80904183"},"pull_request":{"href":"https://api.github.com/repos/artsy/emission/pulls/324"}}},"pull_request":{"url":"https://api.github.com/repos/artsy/emission/pulls/324","id":87106349,"html_url":"https://github.com/artsy/emission/pull/324","diff_url":"https://github.com/artsy/emission/pull/324.diff","patch_url":"https://github.com/artsy/emission/pull/324.patch","issue_url":"https://api.github.com/repos/artsy/emission/issues/324","number":324,"state":"open","locked":false,"title":"[WIP] Get down to 0 flow errors","user":{"login":"orta","id":49038,"avatar_url":"https://avatars.githubusercontent.com/u/49038?v=3","gravatar_id":"","url":"https://api.github.com/users/orta","html_url":"https://github.com/orta","followers_url":"https://api.github.com/users/orta/followers","following_url":"https://api.github.com/users/orta/following{/other_user}","gists_url":"https://api.github.com/users/orta/gists{/gist_id}","starred_url":"https://api.github.com/users/orta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orta/subscriptions","organizations_url":"https://api.github.com/users/orta/orgs","repos_url":"https://api.github.com/users/orta/repos","events_url":"https://api.github.com/users/orta/events{/privacy}","received_events_url":"https://api.github.com/users/orta/received_events","type":"User","site_admin":false},"body":"This adds Flow to the CI, and brings us to 0 flow errors for the first time\r\n\r\nI strongly recommend everyone read this PR from top to bottom, I'll try and cover every major change in the review mode. \r\n\r\n### Important\r\n\r\nThis updates React-Native to 0.34, you will probably need to `rm -rf node_modules` and `npm install` after this. \r\n\r\nTODO:\r\n\r\n- [ ] dig into Promises, see discussion [in slack](https://artsy.slack.com/archives/mobile-banter/p1475054984000817)\r\n- [ ] actually use the app to verify React Native update hasn't actually broken things at runtime","created_at":"2016-09-28T12:05:36Z","updated_at":"2016-09-28T12:34:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"516367967f7b43613056607a997e12b939beea66","assignee":{"login":"alloy","id":2320,"avatar_url":"https://avatars.githubusercontent.com/u/2320?v=3","gravatar_id":"","url":"https://api.github.com/users/alloy","html_url":"https://github.com/alloy","followers_url":"https://api.github.com/users/alloy/followers","following_url":"https://api.github.com/users/alloy/following{/other_user}","gists_url":"https://api.github.com/users/alloy/gists{/gist_id}","starred_url":"https://api.github.com/users/alloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alloy/subscriptions","organizations_url":"https://api.github.com/users/alloy/orgs","repos_url":"https://api.github.com/users/alloy/repos","events_url":"https://api.github.com/users/alloy/events{/privacy}","received_events_url":"https://api.github.com/users/alloy/received_events","type":"User","site_admin":false},"assignees":[{"login":"alloy","id":2320,"avatar_url":"https://avatars.githubusercontent.com/u/2320?v=3","gravatar_id":"","url":"https://api.github.com/users/alloy","html_url":"https://github.com/alloy","followers_url":"https://api.github.com/users/alloy/followers","following_url":"https://api.github.com/users/alloy/following{/other_user}","gists_url":"https://api.github.com/users/alloy/gists{/gist_id}","starred_url":"https://api.github.com/users/alloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alloy/subscriptions","organizations_url":"https://api.github.com/users/alloy/orgs","repos_url":"https://api.github.com/users/alloy/repos","events_url":"https://api.github.com/users/alloy/events{/privacy}","received_events_url":"https://api.github.com/users/alloy/received_events","type":"User","site_admin":false},{"login":"sarahscott","id":2712962,"avatar_url":"https://avatars.githubusercontent.com/u/2712962?v=3","gravatar_id":"","url":"https://api.github.com/users/sarahscott","html_url":"https://github.com/sarahscott","followers_url":"https://api.github.com/users/sarahscott/followers","following_url":"https://api.github.com/users/sarahscott/following{/other_user}","gists_url":"https://api.github.com/users/sarahscott/gists{/gist_id}","starred_url":"https://api.github.com/users/sarahscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarahscott/subscriptions","organizations_url":"https://api.github.com/users/sarahscott/orgs","repos_url":"https://api.github.com/users/sarahscott/repos","events_url":"https://api.github.com/users/sarahscott/events{/privacy}","received_events_url":"https://api.github.com/users/sarahscott/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/artsy/emission/pulls/324/commits","review_comments_url":"https://api.github.com/repos/artsy/emission/pulls/324/comments","review_comment_url":"https://api.github.com/repos/artsy/emission/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/emission/issues/324/comments","statuses_url":"https://api.github.com/repos/artsy/emission/statuses/e93fd15f650a2d2292aa5f8822b8afa1d1ef46dd","head":{"label":"artsy:flow","ref":"flow","sha":"e93fd15f650a2d2292aa5f8822b8afa1d1ef46dd","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":52437732,"name":"emission","full_name":"artsy/emission","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/emission","description":"React Native Components","fork":false,"url":"https://api.github.com/repos/artsy/emission","forks_url":"https://api.github.com/repos/artsy/emission/forks","keys_url":"https://api.github.com/repos/artsy/emission/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/emission/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/emission/teams","hooks_url":"https://api.github.com/repos/artsy/emission/hooks","issue_events_url":"https://api.github.com/repos/artsy/emission/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/emission/events","assignees_url":"https://api.github.com/repos/artsy/emission/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/emission/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/emission/tags","blobs_url":"https://api.github.com/repos/artsy/emission/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/emission/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/emission/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/emission/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/emission/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/emission/languages","stargazers_url":"https://api.github.com/repos/artsy/emission/stargazers","contributors_url":"https://api.github.com/repos/artsy/emission/contributors","subscribers_url":"https://api.github.com/repos/artsy/emission/subscribers","subscription_url":"https://api.github.com/repos/artsy/emission/subscription","commits_url":"https://api.github.com/repos/artsy/emission/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/emission/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/emission/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/emission/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/emission/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/emission/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/emission/merges","archive_url":"https://api.github.com/repos/artsy/emission/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/emission/downloads","issues_url":"https://api.github.com/repos/artsy/emission/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/emission/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/emission/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/emission/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/emission/labels{/name}","releases_url":"https://api.github.com/repos/artsy/emission/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/emission/deployments","created_at":"2016-02-24T11:36:24Z","updated_at":"2016-09-27T07:18:48Z","pushed_at":"2016-09-28T12:05:36Z","git_url":"git://github.com/artsy/emission.git","ssh_url":"git@github.com:artsy/emission.git","clone_url":"https://github.com/artsy/emission.git","svn_url":"https://github.com/artsy/emission","homepage":null,"size":52452,"stargazers_count":82,"watchers_count":82,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":44,"forks":4,"open_issues":44,"watchers":82,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"d58b3d57bf41100e3cce3c2c1b1c4d6c19581a68","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":52437732,"name":"emission","full_name":"artsy/emission","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/emission","description":"React Native Components","fork":false,"url":"https://api.github.com/repos/artsy/emission","forks_url":"https://api.github.com/repos/artsy/emission/forks","keys_url":"https://api.github.com/repos/artsy/emission/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/emission/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/emission/teams","hooks_url":"https://api.github.com/repos/artsy/emission/hooks","issue_events_url":"https://api.github.com/repos/artsy/emission/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/emission/events","assignees_url":"https://api.github.com/repos/artsy/emission/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/emission/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/emission/tags","blobs_url":"https://api.github.com/repos/artsy/emission/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/emission/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/emission/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/emission/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/emission/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/emission/languages","stargazers_url":"https://api.github.com/repos/artsy/emission/stargazers","contributors_url":"https://api.github.com/repos/artsy/emission/contributors","subscribers_url":"https://api.github.com/repos/artsy/emission/subscribers","subscription_url":"https://api.github.com/repos/artsy/emission/subscription","commits_url":"https://api.github.com/repos/artsy/emission/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/emission/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/emission/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/emission/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/emission/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/emission/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/emission/merges","archive_url":"https://api.github.com/repos/artsy/emission/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/emission/downloads","issues_url":"https://api.github.com/repos/artsy/emission/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/emission/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/emission/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/emission/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/emission/labels{/name}","releases_url":"https://api.github.com/repos/artsy/emission/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/emission/deployments","created_at":"2016-02-24T11:36:24Z","updated_at":"2016-09-27T07:18:48Z","pushed_at":"2016-09-28T12:05:36Z","git_url":"git://github.com/artsy/emission.git","ssh_url":"git@github.com:artsy/emission.git","clone_url":"https://github.com/artsy/emission.git","svn_url":"https://github.com/artsy/emission","homepage":null,"size":52452,"stargazers_count":82,"watchers_count":82,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":44,"forks":4,"open_issues":44,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/emission/pulls/324"},"html":{"href":"https://github.com/artsy/emission/pull/324"},"issue":{"href":"https://api.github.com/repos/artsy/emission/issues/324"},"comments":{"href":"https://api.github.com/repos/artsy/emission/issues/324/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/emission/pulls/324/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/emission/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/emission/pulls/324/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/emission/statuses/e93fd15f650a2d2292aa5f8822b8afa1d1ef46dd"}}}}
{"actor":{"display_login":"orta"}}