{"action":"created","issue":{"url":"https://api.github.com/repos/Pyomo/pyomo/issues/56","repository_url":"https://api.github.com/repos/Pyomo/pyomo","labels_url":"https://api.github.com/repos/Pyomo/pyomo/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/Pyomo/pyomo/issues/56/comments","events_url":"https://api.github.com/repos/Pyomo/pyomo/issues/56/events","html_url":"https://github.com/Pyomo/pyomo/pull/56","id":184015942,"number":56,"title":"Remove floating return statement in XPRESS.py solver plugin","user":{"login":"kdheepak","id":1813121,"avatar_url":"https://avatars.githubusercontent.com/u/1813121?v=3","gravatar_id":"","url":"https://api.github.com/users/kdheepak","html_url":"https://github.com/kdheepak","followers_url":"https://api.github.com/users/kdheepak/followers","following_url":"https://api.github.com/users/kdheepak/following{/other_user}","gists_url":"https://api.github.com/users/kdheepak/gists{/gist_id}","starred_url":"https://api.github.com/users/kdheepak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdheepak/subscriptions","organizations_url":"https://api.github.com/users/kdheepak/orgs","repos_url":"https://api.github.com/users/kdheepak/repos","events_url":"https://api.github.com/users/kdheepak/events{/privacy}","received_events_url":"https://api.github.com/users/kdheepak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-19T16:46:19Z","updated_at":"2016-10-21T21:29:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Pyomo/pyomo/pulls/56","html_url":"https://github.com/Pyomo/pyomo/pull/56","diff_url":"https://github.com/Pyomo/pyomo/pull/56.diff","patch_url":"https://github.com/Pyomo/pyomo/pull/56.patch"},"body":"This problem is because of a floating `return` statement in the `process_logfile` function in the [xpress solver plugin](https://github.com/Pyomo/pyomo/blob/master/pyomo/solvers/plugins/solvers/XPRESS.py#L201). This returns a `None` object instead of the `results` which causes the function `process_soln_file` to error. This patch removes the floating `return` and fixes #55."},"comment":{"url":"https://api.github.com/repos/Pyomo/pyomo/issues/comments/255469803","html_url":"https://github.com/Pyomo/pyomo/pull/56#issuecomment-255469803","issue_url":"https://api.github.com/repos/Pyomo/pyomo/issues/56","id":255469803,"user":{"login":"jsiirola","id":356359,"avatar_url":"https://avatars.githubusercontent.com/u/356359?v=3","gravatar_id":"","url":"https://api.github.com/users/jsiirola","html_url":"https://github.com/jsiirola","followers_url":"https://api.github.com/users/jsiirola/followers","following_url":"https://api.github.com/users/jsiirola/following{/other_user}","gists_url":"https://api.github.com/users/jsiirola/gists{/gist_id}","starred_url":"https://api.github.com/users/jsiirola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsiirola/subscriptions","organizations_url":"https://api.github.com/users/jsiirola/orgs","repos_url":"https://api.github.com/users/jsiirola/repos","events_url":"https://api.github.com/users/jsiirola/events{/privacy}","received_events_url":"https://api.github.com/users/jsiirola/received_events","type":"User","site_admin":false},"created_at":"2016-10-21T21:29:13Z","updated_at":"2016-10-21T21:29:13Z","body":"@ghackebeil: The spurious `return` that this PR removes was added in 2012 by @jwatsonnm.  From the looks of things, it was a debugging statement that was put in during initial development to fence off the results processing.  JP will have to comment, but I don't see a problem with accepting the PR."}}
{"actor":{"display_login":"jsiirola"}}