{"action":"created","issue":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1209","repository_url":"https://api.github.com/repos/kaldi-asr/kaldi","labels_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1209/labels{/name}","comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1209/comments","events_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1209/events","html_url":"https://github.com/kaldi-asr/kaldi/pull/1209","id":191141734,"number":1209,"title":"Look in right location for new style subdirectories","user":{"login":"aevernon","id":21786,"avatar_url":"https://avatars.githubusercontent.com/u/21786?v=3","gravatar_id":"","url":"https://api.github.com/users/aevernon","html_url":"https://github.com/aevernon","followers_url":"https://api.github.com/users/aevernon/followers","following_url":"https://api.github.com/users/aevernon/following{/other_user}","gists_url":"https://api.github.com/users/aevernon/gists{/gist_id}","starred_url":"https://api.github.com/users/aevernon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aevernon/subscriptions","organizations_url":"https://api.github.com/users/aevernon/orgs","repos_url":"https://api.github.com/users/aevernon/repos","events_url":"https://api.github.com/users/aevernon/events{/privacy}","received_events_url":"https://api.github.com/users/aevernon/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-22T22:27:27Z","updated_at":"2016-11-28T19:10:29Z","closed_at":"2016-11-22T23:38:18Z","pull_request":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/1209","html_url":"https://github.com/kaldi-asr/kaldi/pull/1209","diff_url":"https://github.com/kaldi-asr/kaldi/pull/1209.diff","patch_url":"https://github.com/kaldi-asr/kaldi/pull/1209.patch"},"body":"I tested this patch against `fisher_eng_tr_sp_LDC2004S13.zip`, which I downloaded from LDC today.\r\n\r\nIt looks like original committer mistyped the part number since LDC describes this dataset as \"Fisher English Training Speech Data, Part 1.\""},"comment":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/comments/263364010","html_url":"https://github.com/kaldi-asr/kaldi/pull/1209#issuecomment-263364010","issue_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1209","id":263364010,"user":{"login":"danpovey","id":3298747,"avatar_url":"https://avatars.githubusercontent.com/u/3298747?v=3","gravatar_id":"","url":"https://api.github.com/users/danpovey","html_url":"https://github.com/danpovey","followers_url":"https://api.github.com/users/danpovey/followers","following_url":"https://api.github.com/users/danpovey/following{/other_user}","gists_url":"https://api.github.com/users/danpovey/gists{/gist_id}","starred_url":"https://api.github.com/users/danpovey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danpovey/subscriptions","organizations_url":"https://api.github.com/users/danpovey/orgs","repos_url":"https://api.github.com/users/danpovey/repos","events_url":"https://api.github.com/users/danpovey/events{/privacy}","received_events_url":"https://api.github.com/users/danpovey/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T19:10:29Z","updated_at":"2016-11-28T19:10:29Z","body":"Oh OK.  I did not realize you were using all 4 directories.  I guess what\nyou have is the 'newer' data, and we have the older data which is why we\ndidn't see a problem.\nI'll merge.\n\nOn Mon, Nov 28, 2016 at 11:14 AM, Albert Vernon <notifications@github.com>\nwrote:\n\n> Please consider re-opening this ticket. The details below make me think my\n> patch is correct.\n>\n> Per the usage message, I pass the four directories to fisher_data_prep.sh:\n> Steps to Reproduce\n>\n> cd /kaldi/egs/aspire/s5. ./cmd.sh. ./path.sh\n> mfccdir=`pwd`/mfccset -elocal/fisher_data_prep.sh /export/corpora3/LDC/LDC2004T19 /export/corpora3/LDC/LDC2005T19 \\\n>    /export/corpora3/LDC/LDC2004S13 /export/corpora3/LDC/LDC2005S13\n>\n> Observed Behavior\n>\n> local/fisher_data_prep.sh: could not find the subdirectory fe_03_p1_sph1\n> in any of /export/corpora3/LDC/LDC2004T19 /export/corpora3/LDC/LDC2005T19\n> /export/corpora3/LDC/LDC2004S13 /export/corpora3/LDC/LDC2005S13\n>\n> *Contents of my four corpora directories to show I have extracted them\n> correctly:*\n>\n> ls /export/corpora3/LDC/LDC2004T19\n>\n> fe_03_p1_tran\n>\n> ls /export/corpora3/LDC/LDC2005T19\n>\n> fe_03_p2_tran\n>\n> ls /export/corpora3/LDC/LDC2004S13\n>\n> fisher_eng_tr_sp_d1 fisher_eng_tr_sp_d3 fisher_eng_tr_sp_d5\n> fisher_eng_tr_sp_d7\n> fisher_eng_tr_sp_d2 fisher_eng_tr_sp_d4 fisher_eng_tr_sp_d6\n>\n> ls /export/corpora3/LDC/LDC2005S13\n>\n> fe_03_p2_sph1 fe_03_p2_sph2 fe_03_p2_sph3 fe_03_p2_sph4 fe_03_p2_sph5\n> fe_03_p2_sph6 fe_03_p2_sph7\n>\n> *Determining correct location of fe_03_p1_sph1*:\n>\n> find /export/corpora3 -name fe_03_p1_sph1\n>\n> /export/corpora3/LDC/LDC2004S13/fisher_eng_tr_sp_d1/fe_03_p1_sph1\n>\n> find shows that the patch is correct (at least for LDC data that I\n> downloaded this month.)\n>\n> I agree with @jtrmal <https://github.com/jtrmal> that using find would be\n> more robust. The intention of this patch was to be a quick fix for others\n> who might try to run this recipe.\n>\n> —\n> You are receiving this because you modified the open/close state.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/kaldi-asr/kaldi/pull/1209#issuecomment-263314357>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/ADJVu1jnBER20zCS2bv17WoxcxYrpfH6ks5rCv3hgaJpZM4K6BGD>\n> .\n>\n"}}
{"actor":{"display_login":"danpovey"}}