{"action":"created","comment":{"url":"https://api.github.com/repos/weaveworks/weave/pulls/comments/51289673","id":51289673,"diff_hunk":"@@ -1,4 +1,5 @@\n-FROM alpine\n+#FROM alpine\n+FROM jeanblanchard/alpine-glibc","path":"prog/weaveexec/Dockerfile","position":3,"original_position":3,"commit_id":"588290c5fe3187614998559bdddec19a0d57d295","original_commit_id":"588290c5fe3187614998559bdddec19a0d57d295","user":{"login":"tomdee","id":6635,"avatar_url":"https://avatars.githubusercontent.com/u/6635?v=3","gravatar_id":"","url":"https://api.github.com/users/tomdee","html_url":"https://github.com/tomdee","followers_url":"https://api.github.com/users/tomdee/followers","following_url":"https://api.github.com/users/tomdee/following{/other_user}","gists_url":"https://api.github.com/users/tomdee/gists{/gist_id}","starred_url":"https://api.github.com/users/tomdee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomdee/subscriptions","organizations_url":"https://api.github.com/users/tomdee/orgs","repos_url":"https://api.github.com/users/tomdee/repos","events_url":"https://api.github.com/users/tomdee/events{/privacy}","received_events_url":"https://api.github.com/users/tomdee/received_events","type":"User","site_admin":false},"body":"The calico plugin (and I image a number of other CNI plugins too) have a dependency on glibc.\r\n\r\n(Obviously the commented out line should be removed)","created_at":"2016-01-29T17:34:57Z","updated_at":"2016-01-29T17:34:57Z","html_url":"https://github.com/weaveworks/weave/pull/1933#discussion_r51289673","pull_request_url":"https://api.github.com/repos/weaveworks/weave/pulls/1933","_links":{"self":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/comments/51289673"},"html":{"href":"https://github.com/weaveworks/weave/pull/1933#discussion_r51289673"},"pull_request":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/1933"}}},"pull_request":{"url":"https://api.github.com/repos/weaveworks/weave/pulls/1933","id":57406575,"html_url":"https://github.com/weaveworks/weave/pull/1933","diff_url":"https://github.com/weaveworks/weave/pull/1933.diff","patch_url":"https://github.com/weaveworks/weave/pull/1933.patch","issue_url":"https://api.github.com/repos/weaveworks/weave/issues/1933","number":1933,"state":"open","locked":false,"title":"[WIP] Hack up the Weave Proxy to talk CNI","user":{"login":"tomwilkie","id":444037,"avatar_url":"https://avatars.githubusercontent.com/u/444037?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwilkie","html_url":"https://github.com/tomwilkie","followers_url":"https://api.github.com/users/tomwilkie/followers","following_url":"https://api.github.com/users/tomwilkie/following{/other_user}","gists_url":"https://api.github.com/users/tomwilkie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwilkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwilkie/subscriptions","organizations_url":"https://api.github.com/users/tomwilkie/orgs","repos_url":"https://api.github.com/users/tomwilkie/repos","events_url":"https://api.github.com/users/tomwilkie/events{/privacy}","received_events_url":"https://api.github.com/users/tomwilkie/received_events","type":"User","site_admin":false},"body":"This was an idea in the pub, we could make the weave proxy talk to CNI plugins so they could work nicer with Docker.\r\n\r\nAnd it works!  This is POC code, but feedback is welcome:\r\n\r\n```\r\n$ # setup your CNI network*\r\n$ ./weave launch-proxy --without-dns --no-multicast-route\r\n$ docker run -ti -l cni.network=net1 alpine /bin/sh\r\n/ # ifconfig\r\n...\r\nethwe     Link encap:Ethernet  HWaddr 86:5C:46:0F:F8:A0  \r\n          inet addr:192.168.0.6  Bcast:0.0.0.0  Mask:255.255.255.255\r\n          inet6 addr: fe80::845c:46ff:fe0f:f8a0%32623/64 Scope:Link\r\n          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1\r\n          RX packets:7 errors:0 dropped:0 overruns:0 frame:0\r\n          TX packets:6 errors:0 dropped:0 overruns:0 carrier:0\r\n          collisions:0 txqueuelen:1000 \r\n          RX bytes:738 (738.0 B)  TX bytes:508 (508.0 B)\r\n...\r\n```\r\n\r\nDetails:\r\n- This uses @squaremo's libcni\r\n- We're telling the CNI plugin to make an `ethwe` so that the /w/w script works.\r\n- We have to be careful about volume mounting in the CNI configs and plugins into the proxy container; running the proxy not in a container would be a big help with @awh \r\n- We haven't wired up delete yet.\r\n- `--no-multicast-route` was needed as we hit #1932\r\n\r\nThanks to @tomdee for his help with this.\r\n\r\n* How to setup a calico CNI network:\r\n```\r\n$ mkdir -P /etc/cni/net.d\r\n$ cat >/etc/cni/net.d/10-calico-net1.conf <<EOF\r\n{\r\n    \"name\": \"net1\",\r\n    \"type\": \"calico\",\r\n    \"ipam\": {\r\n        \"type\": \"calico-ipam\"\r\n    }\r\n}\r\nEOF\r\n$ wget -O /etc/cni/plugins/calico https://github.com/projectcalico/calico-cni/releases/download/v1.0.0/calico\r\n$ chmod +x /etc/cni/plugins/calico\r\n$ wget https://github.com/projectcalico/calico-containers/releases/download/v0.15.0/calicoctl\r\n$ chmod +x calicoctl\r\n$ docker run --detach \\\r\n    --net=host \\\r\n   --name calico-etcd quay.io/coreos/etcd:v2.0.11 \\\r\n    --advertise-client-urls \"http://127.0.0.1:2379\" \\\r\n    --listen-client-urls \"http://127.0.0.1:2379\"\r\nsudo ./calicoctl node\r\n```","created_at":"2016-01-27T19:05:07Z","updated_at":"2016-01-29T17:34:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"481d6b593a0939b4aa5a072cfe103ca27f998a16","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/weaveworks/weave/pulls/1933/commits","review_comments_url":"https://api.github.com/repos/weaveworks/weave/pulls/1933/comments","review_comment_url":"https://api.github.com/repos/weaveworks/weave/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weaveworks/weave/issues/1933/comments","statuses_url":"https://api.github.com/repos/weaveworks/weave/statuses/588290c5fe3187614998559bdddec19a0d57d295","head":{"label":"tomwilkie:proxy-cni","ref":"proxy-cni","sha":"588290c5fe3187614998559bdddec19a0d57d295","user":{"login":"tomwilkie","id":444037,"avatar_url":"https://avatars.githubusercontent.com/u/444037?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwilkie","html_url":"https://github.com/tomwilkie","followers_url":"https://api.github.com/users/tomwilkie/followers","following_url":"https://api.github.com/users/tomwilkie/following{/other_user}","gists_url":"https://api.github.com/users/tomwilkie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwilkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwilkie/subscriptions","organizations_url":"https://api.github.com/users/tomwilkie/orgs","repos_url":"https://api.github.com/users/tomwilkie/repos","events_url":"https://api.github.com/users/tomwilkie/events{/privacy}","received_events_url":"https://api.github.com/users/tomwilkie/received_events","type":"User","site_admin":false},"repo":{"id":32328358,"name":"weave","full_name":"tomwilkie/weave","owner":{"login":"tomwilkie","id":444037,"avatar_url":"https://avatars.githubusercontent.com/u/444037?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwilkie","html_url":"https://github.com/tomwilkie","followers_url":"https://api.github.com/users/tomwilkie/followers","following_url":"https://api.github.com/users/tomwilkie/following{/other_user}","gists_url":"https://api.github.com/users/tomwilkie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwilkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwilkie/subscriptions","organizations_url":"https://api.github.com/users/tomwilkie/orgs","repos_url":"https://api.github.com/users/tomwilkie/repos","events_url":"https://api.github.com/users/tomwilkie/events{/privacy}","received_events_url":"https://api.github.com/users/tomwilkie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomwilkie/weave","description":"The Docker Network","fork":true,"url":"https://api.github.com/repos/tomwilkie/weave","forks_url":"https://api.github.com/repos/tomwilkie/weave/forks","keys_url":"https://api.github.com/repos/tomwilkie/weave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomwilkie/weave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomwilkie/weave/teams","hooks_url":"https://api.github.com/repos/tomwilkie/weave/hooks","issue_events_url":"https://api.github.com/repos/tomwilkie/weave/issues/events{/number}","events_url":"https://api.github.com/repos/tomwilkie/weave/events","assignees_url":"https://api.github.com/repos/tomwilkie/weave/assignees{/user}","branches_url":"https://api.github.com/repos/tomwilkie/weave/branches{/branch}","tags_url":"https://api.github.com/repos/tomwilkie/weave/tags","blobs_url":"https://api.github.com/repos/tomwilkie/weave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomwilkie/weave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomwilkie/weave/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomwilkie/weave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomwilkie/weave/statuses/{sha}","languages_url":"https://api.github.com/repos/tomwilkie/weave/languages","stargazers_url":"https://api.github.com/repos/tomwilkie/weave/stargazers","contributors_url":"https://api.github.com/repos/tomwilkie/weave/contributors","subscribers_url":"https://api.github.com/repos/tomwilkie/weave/subscribers","subscription_url":"https://api.github.com/repos/tomwilkie/weave/subscription","commits_url":"https://api.github.com/repos/tomwilkie/weave/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomwilkie/weave/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomwilkie/weave/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomwilkie/weave/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomwilkie/weave/contents/{+path}","compare_url":"https://api.github.com/repos/tomwilkie/weave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomwilkie/weave/merges","archive_url":"https://api.github.com/repos/tomwilkie/weave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomwilkie/weave/downloads","issues_url":"https://api.github.com/repos/tomwilkie/weave/issues{/number}","pulls_url":"https://api.github.com/repos/tomwilkie/weave/pulls{/number}","milestones_url":"https://api.github.com/repos/tomwilkie/weave/milestones{/number}","notifications_url":"https://api.github.com/repos/tomwilkie/weave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomwilkie/weave/labels{/name}","releases_url":"https://api.github.com/repos/tomwilkie/weave/releases{/id}","deployments_url":"https://api.github.com/repos/tomwilkie/weave/deployments","created_at":"2015-03-16T13:54:30Z","updated_at":"2016-01-27T18:02:59Z","pushed_at":"2016-01-27T19:15:15Z","git_url":"git://github.com/tomwilkie/weave.git","ssh_url":"git@github.com:tomwilkie/weave.git","clone_url":"https://github.com/tomwilkie/weave.git","svn_url":"https://github.com/tomwilkie/weave","homepage":"","size":6336,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"weaveworks:master","ref":"master","sha":"31f736b37ef269d5b534b3fe20e9d21c16d12726","user":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"repo":{"id":23059575,"name":"weave","full_name":"weaveworks/weave","owner":{"login":"weaveworks","id":9976052,"avatar_url":"https://avatars.githubusercontent.com/u/9976052?v=3","gravatar_id":"","url":"https://api.github.com/users/weaveworks","html_url":"https://github.com/weaveworks","followers_url":"https://api.github.com/users/weaveworks/followers","following_url":"https://api.github.com/users/weaveworks/following{/other_user}","gists_url":"https://api.github.com/users/weaveworks/gists{/gist_id}","starred_url":"https://api.github.com/users/weaveworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaveworks/subscriptions","organizations_url":"https://api.github.com/users/weaveworks/orgs","repos_url":"https://api.github.com/users/weaveworks/repos","events_url":"https://api.github.com/users/weaveworks/events{/privacy}","received_events_url":"https://api.github.com/users/weaveworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weaveworks/weave","description":"Simple, resilient multi-host Docker networking","fork":false,"url":"https://api.github.com/repos/weaveworks/weave","forks_url":"https://api.github.com/repos/weaveworks/weave/forks","keys_url":"https://api.github.com/repos/weaveworks/weave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weaveworks/weave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weaveworks/weave/teams","hooks_url":"https://api.github.com/repos/weaveworks/weave/hooks","issue_events_url":"https://api.github.com/repos/weaveworks/weave/issues/events{/number}","events_url":"https://api.github.com/repos/weaveworks/weave/events","assignees_url":"https://api.github.com/repos/weaveworks/weave/assignees{/user}","branches_url":"https://api.github.com/repos/weaveworks/weave/branches{/branch}","tags_url":"https://api.github.com/repos/weaveworks/weave/tags","blobs_url":"https://api.github.com/repos/weaveworks/weave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weaveworks/weave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weaveworks/weave/git/refs{/sha}","trees_url":"https://api.github.com/repos/weaveworks/weave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weaveworks/weave/statuses/{sha}","languages_url":"https://api.github.com/repos/weaveworks/weave/languages","stargazers_url":"https://api.github.com/repos/weaveworks/weave/stargazers","contributors_url":"https://api.github.com/repos/weaveworks/weave/contributors","subscribers_url":"https://api.github.com/repos/weaveworks/weave/subscribers","subscription_url":"https://api.github.com/repos/weaveworks/weave/subscription","commits_url":"https://api.github.com/repos/weaveworks/weave/commits{/sha}","git_commits_url":"https://api.github.com/repos/weaveworks/weave/git/commits{/sha}","comments_url":"https://api.github.com/repos/weaveworks/weave/comments{/number}","issue_comment_url":"https://api.github.com/repos/weaveworks/weave/issues/comments{/number}","contents_url":"https://api.github.com/repos/weaveworks/weave/contents/{+path}","compare_url":"https://api.github.com/repos/weaveworks/weave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weaveworks/weave/merges","archive_url":"https://api.github.com/repos/weaveworks/weave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weaveworks/weave/downloads","issues_url":"https://api.github.com/repos/weaveworks/weave/issues{/number}","pulls_url":"https://api.github.com/repos/weaveworks/weave/pulls{/number}","milestones_url":"https://api.github.com/repos/weaveworks/weave/milestones{/number}","notifications_url":"https://api.github.com/repos/weaveworks/weave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weaveworks/weave/labels{/name}","releases_url":"https://api.github.com/repos/weaveworks/weave/releases{/id}","deployments_url":"https://api.github.com/repos/weaveworks/weave/deployments","created_at":"2014-08-18T05:19:07Z","updated_at":"2016-01-29T12:08:28Z","pushed_at":"2016-01-29T16:19:54Z","git_url":"git://github.com/weaveworks/weave.git","ssh_url":"git@github.com:weaveworks/weave.git","clone_url":"https://github.com/weaveworks/weave.git","svn_url":"https://github.com/weaveworks/weave","homepage":"http://weave.works","size":10072,"stargazers_count":4005,"watchers_count":4005,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":253,"mirror_url":null,"open_issues_count":208,"forks":253,"open_issues":208,"watchers":4005,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/1933"},"html":{"href":"https://github.com/weaveworks/weave/pull/1933"},"issue":{"href":"https://api.github.com/repos/weaveworks/weave/issues/1933"},"comments":{"href":"https://api.github.com/repos/weaveworks/weave/issues/1933/comments"},"review_comments":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/1933/comments"},"review_comment":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weaveworks/weave/pulls/1933/commits"},"statuses":{"href":"https://api.github.com/repos/weaveworks/weave/statuses/588290c5fe3187614998559bdddec19a0d57d295"}}}}